From xen-devel-bounces@lists.xenproject.org Tue Aug 01 00:25:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 00:25:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573530.898311 (Exim 4.92) (envelope-from ) id 1qQdC5-00007Y-C5; Tue, 01 Aug 2023 00:24:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573530.898311; Tue, 01 Aug 2023 00:24:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQdC5-00007Q-9L; Tue, 01 Aug 2023 00:24:57 +0000 Received: by outflank-mailman (input) for mailman id 573530; Tue, 01 Aug 2023 00:24:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQdC4-00007K-6a for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 00:24:56 +0000 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [2607:f8b0:4864:20::c2a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6344847-3001-11ee-b257-6b7b168915f2; Tue, 01 Aug 2023 02:24:55 +0200 (CEST) Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-56c4c4e822eso3159783eaf.3 for ; Mon, 31 Jul 2023 17:24:55 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9100:2cb0::61c9]) by smtp.gmail.com with ESMTPSA id g18-20020a633752000000b00563deb296bbsm8405429pgn.22.2023.07.31.17.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 17:24:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6344847-3001-11ee-b257-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690849493; x=1691454293; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=V3mp+yZ23mxHLzJZfI0khV2lyi/pSoOfm/QpJXA/ZAOw6SLdOzbUUGPS4DAWRKRLDD +9tpLW57KyeDnJYwX1o+rkuDu8lPWWkpLmwR+ZCdoiL/W7epQS5D+vJjp9RCDkwZDYq1 fb40x8oX4g9ZGoPEEWlWdRu6pHFlsLhgd9CMd7YSc1VLjQqmuaZbCGcutPxS5ZA0m2mr VZz6EyvGz/8d1295RSl0brz0qrfMZ4HSoknuOySsYoLlsxx/ahAeJHWhf/N8O4Yjn6GR ULDblPHxHTmS9SLUy6ScJ16fcIhqJcsgSdi+W4GQePXS1ufWeKvRfq+tav1QHZE4Q+2h fvAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690849493; x=1691454293; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=MIQ4bgrUy6qRU/AtSFMzFpf8EBB2F1X7zINivSyHdND6+3x1NRaHcAOWU1N/mOAGKc hOCpDFBuIWogm0Zjb/W9bc8VDroGEb4+8rK7NgJLWk76O5Hs71nk22d1M+barch9/z4H TrtGZstyPe780Ma3PTutVSmIVb3FMNpDpSEPMclL8wkE72DdqC165UPGlUKvqOjzn+LI cQcoNf8OBfcc70PXvaqN7pl1sM23IOp5EKubWy+H/H/gxZFIVfUBVO8a3p/mzMACnwxf RcskkgB9DQjmiYSEmJIJZTU1lBl4cmEemOhtyO1jCEGXvzIabD3UVK8USRow9wr21WmC P0NA== X-Gm-Message-State: ABy/qLaOiNK0EFXfY/Q8N637hkZ5fnusedh4siz8UBf0jVivgsemqKhe FyNOFB03V1BwOFSSNI2CNd/yFqO6x0PMxQ== X-Google-Smtp-Source: APBJJlESpaVMSjR1L1NDQvrwbeftg7QTy835b9tNz4N/aGTI0/uZhCm5qMkgJpvkRrosl++aRhHuMg== X-Received: by 2002:a05:6808:2090:b0:3a7:4462:59a4 with SMTP id s16-20020a056808209000b003a7446259a4mr2728290oiw.3.1690849493375; Mon, 31 Jul 2023 17:24:53 -0700 (PDT) From: Khem Raj To: xen-devel@lists.xenproject.org Cc: Khem Raj Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive Date: Mon, 31 Jul 2023 17:24:50 -0700 Message-ID: <20230801002450.556213-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Assembler from binutils 2.41 rejects this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execstr Switch to using ELF syntax .section name[, "flags"[, @type]] [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 Signed-off-by: Khem Raj --- xen/arch/arm/arm32/proc-v7.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index c90a31d80f..6d3d19b873 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -29,7 +29,7 @@ brahma15mp_init: mcr CP32(r0, ACTLR) mov pc, lr - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca15mp_proc_info, #object __v7_ca15mp_proc_info: .long 0x410FC0F0 /* Cortex-A15 */ @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: .long caxx_processor .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca7mp_proc_info, #object __v7_ca7mp_proc_info: .long 0x410FC070 /* Cortex-A7 */ @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: .long caxx_processor .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_brahma15mp_proc_info, #object __v7_brahma15mp_proc_info: .long 0x420F00F0 /* Broadcom Brahma-B15 */ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 00:29:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 00:29:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573534.898322 (Exim 4.92) (envelope-from ) id 1qQdG1-0000m0-Sx; Tue, 01 Aug 2023 00:29:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573534.898322; Tue, 01 Aug 2023 00:29:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQdG1-0000lt-PO; Tue, 01 Aug 2023 00:29:01 +0000 Received: by outflank-mailman (input) for mailman id 573534; Tue, 01 Aug 2023 00:29:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQdG0-0000ln-QZ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 00:29:00 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68160a1b-3002-11ee-b257-6b7b168915f2; Tue, 01 Aug 2023 02:29:00 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bb9e6c2a90so40601765ad.1 for ; Mon, 31 Jul 2023 17:28:59 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9100:2cb0::61c9]) by smtp.gmail.com with ESMTPSA id b3-20020a170902d50300b001b8a1a25e6asm9149965plg.128.2023.07.31.17.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 17:28:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68160a1b-3002-11ee-b257-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690849738; x=1691454538; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=XIl6OORM6QViPbSsB8vdQHQ5jKGtvOvmtjAqv6s5n79Zs2LF6apiC/C3f7f7r548Us 44vy2nLA3lZ/tEbKRfI4GWm8Xb65epwCKpQuhI+AVXtbxJnuQCxBuUBYT9Q2Q3E75OHL 18E8rt1Vc/ElSO3g+Fgzx5H04gfalZ+JMCeHYB0gvyGFsrGkqNZBqYgAVIntM0cbnEHX k6VHo40qel93AK/0KaYX1V3nrs/Ti3aHtx6mzvZr31/Hm0XZVdLUVw9eHfg4v4LJO9X9 QYLCLiKvRuZ5+2r1Q68DhQUBoBphtM/vI5WqMFpwn2U43Ju+JmGbaQckF1YrQLDMHegD H0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690849738; x=1691454538; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=YXifrjvRNHyokL9wShQDUWRENahaJNIW+XVigYCo3LgDNe94o0LYuod6pkNlT8xeRl zjiYndPUwmOYvNK55kacx4QulzmLbud1eUfH43EoNrkaRzSF3gUtgFuixlyAI64g1EMO j9M5xfmsSEK2sJ+RclS9XnfQOfgBs749/+hqj0/kw6YIlcA5aLzUIUQvG9x552LpCE33 vRwnMjvIYsROBIghWn28uFpIGRxr9cl7XhBxXLd38WU03kQuISp9wZmTJ0Yh9BAUIiCG aTDC4azI1NSxo/Q0OqGKGFzDdTVG0uROhI7cfC+0grEL+95eOrVfnlB7IJd0qFUm1rjy o9Tw== X-Gm-Message-State: ABy/qLZ6bUGXjMiAg7wd3S8n21I8HtuRv89llO6lNkBPyMtPD4btm023 e3ABxqYZoD0p2qOsCoFUA6qPLpuMtB1KRQ== X-Google-Smtp-Source: APBJJlH8mFsahdzWs1O/MKEG+Yb+4fpKs0mVP3E1LNzhodBuxy2d5/cW8hqdB5TDegC4n2TuUWn1xQ== X-Received: by 2002:a17:903:228f:b0:1b9:be2e:2b40 with SMTP id b15-20020a170903228f00b001b9be2e2b40mr13912641plh.50.1690849738015; Mon, 31 Jul 2023 17:28:58 -0700 (PDT) From: Khem Raj To: xen-devel@lists.xenproject.org Cc: Khem Raj , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive Date: Mon, 31 Jul 2023 17:28:53 -0700 Message-ID: <20230801002853.556437-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Assembler from binutils 2.41 rejects this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execstr Switch to using ELF syntax .section name[, "flags"[, @type]] [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 Signed-off-by: Khem Raj --- xen/arch/arm/arm32/proc-v7.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index c90a31d80f..6d3d19b873 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -29,7 +29,7 @@ brahma15mp_init: mcr CP32(r0, ACTLR) mov pc, lr - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca15mp_proc_info, #object __v7_ca15mp_proc_info: .long 0x410FC0F0 /* Cortex-A15 */ @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: .long caxx_processor .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca7mp_proc_info, #object __v7_ca7mp_proc_info: .long 0x410FC070 /* Cortex-A7 */ @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: .long caxx_processor .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_brahma15mp_proc_info, #object __v7_brahma15mp_proc_info: .long 0x420F00F0 /* Broadcom Brahma-B15 */ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 01:31:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 01:31:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573540.898332 (Exim 4.92) (envelope-from ) id 1qQeE0-0001jH-Eb; Tue, 01 Aug 2023 01:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573540.898332; Tue, 01 Aug 2023 01:31:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQeE0-0001jA-A9; Tue, 01 Aug 2023 01:31:00 +0000 Received: by outflank-mailman (input) for mailman id 573540; Tue, 01 Aug 2023 01:30:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQeDy-0001j0-Lo; Tue, 01 Aug 2023 01:30:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQeDy-0003fv-KY; Tue, 01 Aug 2023 01:30:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQeDx-0006QT-So; Tue, 01 Aug 2023 01:30:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qQeDx-0007jf-QJ; Tue, 01 Aug 2023 01:30:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pG7+NkIZrVACfGKWFpUuKo459PHNBvRnvjhCRfuodSo=; b=xEX9KR3NnYGadOVhhVV2IDGVnj 9w1h3NFAxpmBk+uWio0tKEGES6DZHnyxTsg3r34MB46Vy3zKBI6i5V3m0zEZM2NztyOBebiOr6ZiS IHJc9UeNu5NfGqVvYeiqCnTJlfdrMMp0ALHuUqGTyJWsTbaLCuvUSKjKHLP14sQVjqoE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182098: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=70eb862b01023c45b943e8ff92ef4f6a7e9e8950 X-Osstest-Versions-That: xen=c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c From: osstest service owner Date: Tue, 01 Aug 2023 01:30:57 +0000 flight 182098 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182098/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 70eb862b01023c45b943e8ff92ef4f6a7e9e8950 baseline version: xen c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c Last test of basis 182091 2023-07-31 13:00:28 Z 0 days Testing same since 182098 2023-07-31 20:00:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Federico Serafini Jan Beulich Jason Andryuk Nicola Vetrini Peter Hoyes Roger Pau MonnĂ© jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c0dd53b8cb..70eb862b01 70eb862b01023c45b943e8ff92ef4f6a7e9e8950 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 01 02:59:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 02:59:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573547.898342 (Exim 4.92) (envelope-from ) id 1qQfay-0001Te-Mi; Tue, 01 Aug 2023 02:58:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573547.898342; Tue, 01 Aug 2023 02:58:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQfay-0001TW-Gw; Tue, 01 Aug 2023 02:58:48 +0000 Received: by outflank-mailman (input) for mailman id 573547; Tue, 01 Aug 2023 02:58:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQfaw-0001TQ-6O for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 02:58:46 +0000 Received: from mgamail.intel.com (unknown [192.55.52.136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5015a7b7-3017-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 04:58:40 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2023 19:58:36 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jul 2023 19:58:36 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 19:58:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 19:58:36 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 31 Jul 2023 19:58:36 -0700 Received: from BL1PR11MB5271.namprd11.prod.outlook.com (2603:10b6:208:31a::21) by PH7PR11MB8569.namprd11.prod.outlook.com (2603:10b6:510:304::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 02:58:32 +0000 Received: from BL1PR11MB5271.namprd11.prod.outlook.com ([fe80::4a3e:51f9:8a29:afe5]) by BL1PR11MB5271.namprd11.prod.outlook.com ([fe80::4a3e:51f9:8a29:afe5%4]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 02:58:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5015a7b7-3017-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690858720; x=1722394720; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ltQMYegyRPp06TIFDLMsKOeZJCfiFN4LHFI3kdSFC5A=; b=gvd0pNYmVmyY/pPeZ1UmgXZK7hUWr2SiCaOZ2nC62rt6Plf49X+8tvEI A7l6+OG/RShmPwIf3Pusi5s9qDz1dXMFg1FHOkryp8kXBlaZm9LEn5CDv JNtTF6+go7LGXIwdex/n0qbJ4SBNsDPIA/GIzLnTnrZrMtsyxMwkFR7iq ZUIMfn6lEbQU/1GGW7dfoIP5OMBc9Uerjb73mgynLsv4HRry+wg84u3oW vW0KVVf1glHmkz4jTZfXSOMJljV8pgSCtXsrNhMEBHISINj8afFJ5pcTt vSDGn5y8Ruj6rLneAs+c1hEV9fsvpgmmRZKlKKQbIn9f35/LRUckaaDtP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="348780458" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="348780458" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="818626585" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="818626585" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CtRZlBkcxMHZuuXRs91QC3MRpbrlddy6AVHNpBjeLHWBJ/vNovuQzGM4DPyP13NCIffvg9S+M+caJLOFymSRaCibUBZw/EEVNGJHopcNvrMb9dZRjnRUyetkbmQ6eT1LOA+TdynnILrrMpVwB2WeQui/gI4Cz/U4E8XTFdk86IffQUSPslz6RhJ2T+NwSo8d7YdTkjZzHINbS407nVdzE3dAQk/X5sNKNo9+SRkLqTs4pGuNHoYmfAbdjoLlaGOo8A7uXVwbIOORlRw8BDEea9/lggvV3Ybrx+/FtZoxpZnKMPyyi9ZuPFwPWk6x5fk3ode6hUmdmBnzB/IcrnNt2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ltQMYegyRPp06TIFDLMsKOeZJCfiFN4LHFI3kdSFC5A=; b=FF9OCYPIR60+fbvxAKBeB4Ad9DYdAiONGUkG2kJfCGMISBFgK9KMEQVRKKh9uPfW6xE05xphITsZafEMmn31MZAylANRkusl15EzTa0m2Al+LPJ0VjEll3e80shiONV+hZZM11Y6kA2q+DNUUlnqiYIDOgJbnaEBtiHHh7p3ZxUO+TWpDcAIZBVylgVCyxb1/QxraWkC0KHOV5FuYznNBhYGBuIVFnJeMmg/KraAhw5Ox1FrvuPkw5kEFoCtyld7d7V0dEQ2fLwu+9gbvUQit3/K1pgNWAOWINYHTClvdyipMoeuWzlYWgoMETvP0qyU7WhdKyPC6b9orvAhdQIRww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Beulich, Jan" , "andrew.cooper3@citrix.com" , Wei Liu , Paul Durrant Subject: RE: [PATCH v4 4/4] x86/iommu: pass full IO-APIC RTE for remapping table update Thread-Topic: [PATCH v4 4/4] x86/iommu: pass full IO-APIC RTE for remapping table update Thread-Index: AQHZwToNmh8G0I7e7EOZhmA6b/SBHq/UxZCw Date: Tue, 1 Aug 2023 02:58:32 +0000 Message-ID: References: <20230726125508.78704-5-roger.pau@citrix.com> <20230728095716.13779-1-roger.pau@citrix.com> In-Reply-To: <20230728095716.13779-1-roger.pau@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR11MB5271:EE_|PH7PR11MB8569:EE_ x-ms-office365-filtering-correlation-id: b12bebff-ecfa-4933-a589-08db923b30fd x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KRyowvgFBjygr/HfVSQ5AkqbSJh05ZUJK6LhpJmlG7SO8XPHLqMNTqESEW7eZQJBkKwzwsFG7xqH3B5Mm8WBPUxoUUp22XcfDIj7khZbtMdnHfp5fl7gztMMG4KC3KJ5milFpGNTlbVoktbR1bM2u50rCsXR/iTz5kX7OK5eueom+AwyZHei5UQDpIxqYeYYgqheiacOsCqyN6HCvyTh6ssYal7sbDbD5eM58ORPs6JxXL1dlYMITFzaDZ6HyORAJixAlgRBYEztp7Z2B/Pzv5/sc9/xUIlOfhoVo+GmJguOMAemklXGz3CDOsuCzKvX87x3l+otfJF6jtIrye3f2gmGZlUGSydEuq+Z8IGrouEu5BEH4FzlL46E7KvXwSwCFzzB5zsI8Hu1826sQ0fM7U3eiTDux6TRTSGieCSjIj03sQbXlgYDji9+EZEdwwqVojy0O45SYhrmb+eIwEowbChc3XOUEKelYNDjTJmd45ACfFTj83H49QF0H1LVNMStl2iecndrPSybqCUjtzs/9oeImY8YHabTWhbYVzRz7h2QrKYfCaJk8qo6nalKXSfd25gQXJQRTnIKZhVoHkY6nCxJ4dhLtWa7OmqWZgCHf8Z/Z7Fgl+F7wxOymfT15ESU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5271.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(136003)(39860400002)(346002)(451199021)(7696005)(38070700005)(9686003)(86362001)(71200400001)(55016003)(186003)(6506007)(83380400001)(33656002)(38100700002)(82960400001)(52536014)(5660300002)(8676002)(15650500001)(4326008)(41300700001)(8936002)(76116006)(66946007)(64756008)(66446008)(66556008)(66476007)(4744005)(316002)(122000001)(2906002)(478600001)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dnJvMDJQTmxsVlFCbTlLNkxUWTllazhOamJienJCL3BHSDdseXZNUi9xT0hY?= =?utf-8?B?cVZpcHhkTEs1S21Dc0Ewc1VjaGVBNjNQc1ppUDYzOXExenFYUmN2ak1mVXk5?= =?utf-8?B?RCtadU5VNEp3ZzBYUWxVdFFIaHMraU1MOXFSVUtWMVZOVStGemtzOENkM3RE?= =?utf-8?B?VzkwM3ZhQkxVbE8yQkRNOFp6b0pNbDdpdDhRUmtJWDkwT251bVBWbFVIcS9Y?= =?utf-8?B?YlYwbUNpNllKUkFFTnVTWmorRWs3a053dkpwemJiWm56Y3FnYzZyQllyS2JF?= =?utf-8?B?cGd5S3hlR0wrY3h4YmJSdkFJRmdiL1dnckpkY0JkaVJkUEkrclZhcnRhSE8r?= =?utf-8?B?eUdya3Z4U2oxbnFFa0JYQlJGVE9JcWNMZHBBVWdoRzVkV2VXY29sU2QxTGEr?= =?utf-8?B?bmlFOW8zNkFTL0RKWm1PYmt4em5mVEVTQzFiRW9BK2RGMDJOam5FVG9MVENN?= =?utf-8?B?NnUzU3ZLZEhLZnBkekR2ZGlqaDY1VjBGNHZZWTdwRlFpM3RrZ3dYWVl2VVN1?= =?utf-8?B?RkllMnpQNjZ1S3RyaC9tNWtXNlZqRkFKS3pBOXh5QWJaM3VsbisrdnV1SXdX?= =?utf-8?B?cFBKRERySGVtalozYjBHeXh0MGpweWs2UVVuRFRBL0hLNGhXcUFFbzBETDdG?= =?utf-8?B?V2h3cTg4aWpDVmdpNjVYSldoTElDNXhLS2lhdXBHYmFMODJPNkI1UGV6RE5y?= =?utf-8?B?Y2xqb3I0NVh5Rk01TTdGWG42dzVYM1QzSE41NDI2N2NFMDZWaHExRlpxWFNo?= =?utf-8?B?Y0lCRFNMU29rTXB5TGt4Nkx3dUIyVjZNR3RROEt4bXFUd29mS2E3ak93amNi?= =?utf-8?B?RjZBR3ZzRTFldXZ2NUVGbW52QldaMTRDUHdCVW5mZUdUWnJVZEtQTUV4OVdK?= =?utf-8?B?MUs3aVlVeUYzM1ZiZ0hOemlCbFFGSm9PUVFNd29EUWc5dldFbktad1RqQUtV?= =?utf-8?B?eno0QnRzTkNValV6TlZVRmtOWksxVXhkYVJjNkJiY0VydnA5bCtSTUJMOWVX?= =?utf-8?B?SHVBZXFyK0hTcTJ0MEw3WDFlTUp3bDRLMC9kaDIzME5ZR1NCNVFjeWVrUWdh?= =?utf-8?B?bDd3NjE4RXNmMnJvQncrYXJYdFhGK3RORnRaRW1TZTRuR0YzRXZPZmk3TU85?= =?utf-8?B?cHM4c2F3ekFQK043Z3hUQlVtT21kZDQ5enBMZTBoUUtnN3lTQTFwdGc0ZU1W?= =?utf-8?B?U1ZWM1VuSTVJeHlIa05zWVlWQXRhVEhCWTN0UVRjNmNwYms5cW5ram9nbnU4?= =?utf-8?B?Q0FPQlQwczVHTHhqYkNtdmZSQ1pwRGxLVE4zWnN6ZVMra0dEditTYzJyNHZO?= =?utf-8?B?VWlyYW1CdkcvUGhrOExjd2FmcWROd3dNM2ZlaGphSTV3UmRLeFFhWUdEZHBr?= =?utf-8?B?VTZjSXlUUGYvb01PYmFvTTRtVkpRMURtZ1lIcnQvNUFqZDh0dXQ5c3hzZThN?= =?utf-8?B?K2NoY0hPaXdTYXB4MnJBU0VYazZUM0phQ3p6QWRRLzRNSWtRZXFoczMxd09X?= =?utf-8?B?cTFCTHdQTGF5cVUvSUdFNXFYRTUveStrd0tRTVgyOUt1YlljamlkTmp0bytU?= =?utf-8?B?NmhWeXpKZjV0b25IVHdCVjhXZUdjalo0TDJBUHZ1WFYvOUhFQVNra3ZteVk0?= =?utf-8?B?Ymp0R0dDWWF5eklNMGNvaXJ5dmcvbmh3UndicVhsaUhUSk1hTi9DcGhIRnc0?= =?utf-8?B?UnpOcmdkenJwZkppVDB1Mm11QnkyQmRRaUdsWlhFMWd5TEFaT2ppQmhCMzQz?= =?utf-8?B?d0ZSS21DRTQ5Q2d2Rklud1YrVEs0aHlCVkJQVVRmTlBPT3BVZmdGMDY0QkFp?= =?utf-8?B?dVpLQzZjSEFOS0hNY1hPUmhuWWh6WU5hQVBFcjFmQkVHblJSclo4WmVFd094?= =?utf-8?B?dWlqeXBPcmtTQTVyY1hzVllxajRWNDU1VFNoVGd4bXRMMU9YNTJOd3doTzZm?= =?utf-8?B?dmJXTXlOTDlTbDJxWGFDRFAvQWd0a2x0R1Zaam5jMmFjbXllcm5Fa0JTcklh?= =?utf-8?B?SnBXcGxKWFFsakZub2xBb0J3eEZ1UCt2aVU3V2NDWVROazd4eEk1US9DY1Nz?= =?utf-8?B?ZHROa2RFSkZ1WGtPZHBTV1JDdEpPVGtTeUhlWG5Kb2c2SFFNQjZtTk8yeFFv?= =?utf-8?Q?OOWg=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5271.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b12bebff-ecfa-4933-a589-08db923b30fd X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 02:58:32.5614 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ewFgKVjTuyhVXek4NhMqgLtrH5eG1fN6+yrVQ1DthIqYLyykXrrSZBLvauUVBXpr/+T03k6umhR7rZAx17sGEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8569 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBTZW50OiBG cmlkYXksIEp1bHkgMjgsIDIwMjMgNTo1NyBQTQ0KPiANCj4gU28gdGhhdCB0aGUgcmVtYXBwaW5n IGVudHJ5IGNhbiBiZSB1cGRhdGVkIGF0b21pY2FsbHkgd2hlbiBwb3NzaWJsZS4NCj4gDQo+IERv aW5nIHN1Y2ggdXBkYXRlIGF0b21pY2FsbHkgd2lsbCBhdm9pZCBYZW4gaGF2aW5nIHRvIG1hc2sg dGhlIElPLUFQSUMNCj4gcGluIHByaW9yIHRvIHBlcmZvcm1pbmcgYW55IGludGVycnVwdCBtb3Zl bWVudHMgKGllOiBjaGFuZ2luZyB0aGUNCj4gZGVzdGluYXRpb24gYW5kIHZlY3RvciBmaWVsZHMp LCBhcyB0aGUgaW50ZXJydXB0IHJlbWFwcGluZyBlbnRyeSBpcw0KPiBhbHdheXMgY29uc2lzdGVu dC4NCj4gDQo+IFRoaXMgYWxzbyBzaW1wbGlmaWVzIHNvbWUgb2YgdGhlIGxvZ2ljIG9uIGJvdGgg VlQtZCBhbmQgQU1ELVZpDQo+IGltcGxlbWVudGF0aW9ucywgYXMgaGF2aW5nIHRoZSBmdWxsIFJU RSBhdmFpbGFibGUgaW5zdGVhZCBvZiBoYWxmIG9mDQo+IGl0IGF2b2lkcyB0byBwb3NzaWJseSBy ZWFkIGFuZCB1cGRhdGUgdGhlIG1pc3Npbmcgb3RoZXIgaGFsZiBmcm9tDQo+IGhhcmR3YXJlLg0K PiANCj4gV2hpbGUgdGhlcmUgcmVtb3ZlIHRoZSBleHBsaWNpdCB6ZXJvaW5nIG9mIG5ld19pcmUg ZmllbGRzIGluDQo+IGlvYXBpY19ydGVfdG9fcmVtYXBfZW50cnkoKSBhbmQgaW5pdGlhbGl6ZSB0 aGUgdmFyaWFibGUgYXQgZGVmaW5pdGlvbg0KPiBzbyBhbGwgZmllbGRzIGFyZSB6ZXJvZWQuICBO b3RlIGZpZWxkcyBjb3VsZCBiZSBhbHNvIGluaXRpYWxpemVkIHdpdGgNCj4gZmluYWwgdmFsdWVz IGF0IGRlZmluaXRpb24sIGJ1dCBJIGZvdW5kIHRoYXQgbGlrZWx5IHRvbyBtdWNoIHRvIGJlDQo+ IGRvbmUgYXQgdGhpcyB0aW1lLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7D qSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZp bi50aWFuQGludGVsLmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:44:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573552.898362 (Exim 4.92) (envelope-from ) id 1qQgJN-00077E-7O; Tue, 01 Aug 2023 03:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573552.898362; Tue, 01 Aug 2023 03:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJN-000777-45; Tue, 01 Aug 2023 03:44:41 +0000 Received: by outflank-mailman (input) for mailman id 573552; Tue, 01 Aug 2023 03:44:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJL-00076X-N7 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id bb877502-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:44:36 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F5F7D75; Mon, 31 Jul 2023 20:45:18 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E50013F59C; Mon, 31 Jul 2023 20:44:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb877502-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Henry Wang Subject: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Date: Tue, 1 Aug 2023 11:44:07 +0800 Message-Id: <20230801034419.2047541-2-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen At the moment, on MMU system, enable_mmu() will return to an address in the 1:1 mapping, then each path is responsible to switch to virtual runtime mapping. Then remove_identity_mapping() is called on the boot CPU to remove all 1:1 mapping. Since remove_identity_mapping() is not necessary on Non-MMU system, and we also avoid creating empty function for Non-MMU system, trying to keep only one codeflow in arm64/head.S, we move path switch and remove_identity_mapping() in enable_mmu() on MMU system. As the remove_identity_mapping should only be called for the boot CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and enable_secondary_cpu_mm() for secondary CPUs in this patch. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng Signed-off-by: Henry Wang --- v4: - Clarify remove_identity_mapping() is called on boot CPU and keep the function/proc format consistent in commit msg. - Drop inaccurate (due to the refactor) in-code comment. - Rename enable_{boot,runtime}_mmu to enable_{boot,secondary}_cpu_mm. - Reword the in-code comment on top of enable_{boot,secondary}_cpu_mm. - Call "fail" for unreachable code. v3: - new patch --- xen/arch/arm/arm64/head.S | 89 ++++++++++++++++++++++++++++++--------- 1 file changed, 70 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 31cdb54d74..2af9f974d5 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -313,21 +313,11 @@ real_start_efi: bl check_cpu_mode bl cpu_init - bl create_page_tables - load_paddr x0, boot_pgtable - bl enable_mmu - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ - ldr x0, =primary_switched - br x0 + ldr lr, =primary_switched + b enable_boot_cpu_mm + primary_switched: - /* - * The 1:1 map may clash with other parts of the Xen virtual memory - * layout. As it is not used anymore, remove it completely to - * avoid having to worry about replacing existing mapping - * afterwards. - */ - bl remove_identity_mapping bl setup_fixmap #ifdef CONFIG_EARLY_PRINTK /* Use a virtual address to access the UART. */ @@ -372,13 +362,10 @@ GLOBAL(init_secondary) #endif bl check_cpu_mode bl cpu_init - load_paddr x0, init_ttbr - ldr x0, [x0] - bl enable_mmu - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ - ldr x0, =secondary_switched - br x0 + ldr lr, =secondary_switched + b enable_secondary_cpu_mm + secondary_switched: #ifdef CONFIG_EARLY_PRINTK /* Use a virtual address to access the UART. */ @@ -737,6 +724,70 @@ enable_mmu: ret ENDPROC(enable_mmu) +/* + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. + * The function will return to the virtual address provided in LR (e.g. the + * runtime mapping). + * + * Inputs: + * lr : Virtual address to return to. + * + * Clobbers x0 - x5 + */ +enable_secondary_cpu_mm: + mov x5, lr + + load_paddr x0, init_ttbr + ldr x0, [x0] + + bl enable_mmu + mov lr, x5 + + /* return to secondary_switched */ + ret +ENDPROC(enable_secondary_cpu_mm) + +/* + * Enable mm (turn on the data cache and the MMU) for the boot CPU. + * The function will return to the virtual address provided in LR (e.g. the + * runtime mapping). + * + * Inputs: + * lr : Virtual address to return to. + * + * Clobbers x0 - x5 + */ +enable_boot_cpu_mm: + mov x5, lr + + bl create_page_tables + load_paddr x0, boot_pgtable + + bl enable_mmu + mov lr, x5 + + /* + * The MMU is turned on and we are in the 1:1 mapping. Switch + * to the runtime mapping. + */ + ldr x0, =1f + br x0 +1: + /* + * The 1:1 map may clash with other parts of the Xen virtual memory + * layout. As it is not used anymore, remove it completely to + * avoid having to worry about replacing existing mapping + * afterwards. Function will return to primary_switched. + */ + b remove_identity_mapping + + /* + * Below is supposed to be unreachable code, as "ret" in + * remove_identity_mapping will use the return address in LR in advance. + */ + b fail +ENDPROC(enable_boot_cpu_mm) + /* * Remove the 1:1 map from the page-tables. It is not easy to keep track * where the 1:1 map was mapped, so we will look for the top-level entry -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:44:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573551.898352 (Exim 4.92) (envelope-from ) id 1qQgJG-0006rW-VK; Tue, 01 Aug 2023 03:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573551.898352; Tue, 01 Aug 2023 03:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJG-0006rP-Rt; Tue, 01 Aug 2023 03:44:34 +0000 Received: by outflank-mailman (input) for mailman id 573551; Tue, 01 Aug 2023 03:44:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJF-0006rJ-Sx for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:33 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id b8ef5b99-301d-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 05:44:31 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8721D75; Mon, 31 Jul 2023 20:45:13 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AD6423F59C; Mon, 31 Jul 2023 20:44:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8ef5b99-301d-11ee-b258-6b7b168915f2 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work Date: Tue, 1 Aug 2023 11:44:06 +0800 Message-Id: <20230801034419.2047541-1-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Based on the discussion in the Xen Summit [1], sending this series out after addressing the comments in v3 [2] as the preparation work to add MPU support. Mostly code movement, with some of Kconfig and build system (mainly Makefiles) adjustment. No functional change expected. [1] https://lore.kernel.org/xen-devel/AS8PR08MB799122F8B0CB841DED64F4819226A@AS8PR08MB7991.eurprd08.prod.outlook.com/ [2] https://lore.kernel.org/xen-devel/20230626033443.2943270-1-Penny.Zheng@arm.com/ Henry Wang (4): xen/arm: Introduce 'choice' for memory system architecture xen/arm64: Split and move MMU-specific head.S to mmu/head.S xen/arm64: Move setup_fixmap() to create_page_tables() xen/arm: Extract MMU-specific code Penny Zheng (6): xen/arm: Fold pmap and fixmap into MMU system xen/arm: mm: Use generic variable/function names for extendability xen/arm: mmu: move MMU-specific setup_mm to mmu/setup.c xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h} xen/arm: mmu: relocate copy_from_paddr() to setup.c xen/arm: mmu: enable SMMU subsystem only in MMU Wei Chen (3): xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm xen/arm64: prepare for moving MMU related code from head.S xen/arm: Move MMU related definitions from config.h to mmu/layout.h xen/arch/arm/Kconfig | 16 +- xen/arch/arm/Makefile | 1 + xen/arch/arm/arm32/head.S | 4 +- xen/arch/arm/arm64/Makefile | 2 +- xen/arch/arm/arm64/head.S | 497 +------ xen/arch/arm/arm64/mmu/Makefile | 2 + xen/arch/arm/arm64/mmu/head.S | 471 ++++++ xen/arch/arm/arm64/{ => mmu}/mm.c | 11 +- xen/arch/arm/arm64/smpboot.c | 6 +- xen/arch/arm/include/asm/arm64/macros.h | 36 + xen/arch/arm/include/asm/arm64/mm.h | 7 +- xen/arch/arm/include/asm/config.h | 132 +- xen/arch/arm/include/asm/fixmap.h | 7 +- xen/arch/arm/include/asm/mm.h | 28 +- xen/arch/arm/include/asm/mmu/layout.h | 146 ++ xen/arch/arm/include/asm/mmu/mm.h | 55 + xen/arch/arm/include/asm/mmu/p2m.h | 18 + xen/arch/arm/include/asm/p2m.h | 33 +- xen/arch/arm/include/asm/page.h | 15 - xen/arch/arm/include/asm/setup.h | 8 +- xen/arch/arm/kernel.c | 27 - xen/arch/arm/mm.c | 1119 -------------- xen/arch/arm/mmu/Makefile | 3 + xen/arch/arm/mmu/mm.c | 1153 +++++++++++++++ xen/arch/arm/mmu/p2m.c | 1610 ++++++++++++++++++++ xen/arch/arm/mmu/setup.c | 366 +++++ xen/arch/arm/p2m.c | 1772 ++--------------------- xen/arch/arm/setup.c | 326 +---- xen/arch/arm/smpboot.c | 4 +- xen/arch/arm/xen.lds.S | 1 + xen/drivers/passthrough/Kconfig | 3 +- 31 files changed, 4064 insertions(+), 3815 deletions(-) create mode 100644 xen/arch/arm/arm64/mmu/Makefile create mode 100644 xen/arch/arm/arm64/mmu/head.S rename xen/arch/arm/arm64/{ => mmu}/mm.c (95%) create mode 100644 xen/arch/arm/include/asm/mmu/layout.h create mode 100644 xen/arch/arm/include/asm/mmu/mm.h create mode 100644 xen/arch/arm/include/asm/mmu/p2m.h create mode 100644 xen/arch/arm/mmu/Makefile create mode 100644 xen/arch/arm/mmu/mm.c create mode 100644 xen/arch/arm/mmu/p2m.c create mode 100644 xen/arch/arm/mmu/setup.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:44:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573553.898369 (Exim 4.92) (envelope-from ) id 1qQgJN-0007Ak-J0; Tue, 01 Aug 2023 03:44:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573553.898369; Tue, 01 Aug 2023 03:44:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJN-0007AU-CF; Tue, 01 Aug 2023 03:44:41 +0000 Received: by outflank-mailman (input) for mailman id 573553; Tue, 01 Aug 2023 03:44:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJM-0006rJ-G5 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id be19a5f9-301d-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 05:44:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D9F9D75; Mon, 31 Jul 2023 20:45:22 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 064103F59C; Mon, 31 Jul 2023 20:44:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be19a5f9-301d-11ee-b258-6b7b168915f2 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Julien Grall Subject: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture Date: Tue, 1 Aug 2023 11:44:08 +0800 Message-Id: <20230801034419.2047541-3-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are two types of memory system architectures available for Arm-based systems, namely the Virtual Memory System Architecture (VMSA) and the Protected Memory System Architecture (PMSA). According to ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that controls address translation, access permissions, and memory attribute determination and checking, for memory accesses made by the PE. And refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection scheme where an Memory Protection Unit (MPU) manages instruction and data access. Currently, Xen only suuports VMSA. As a preparation of the Xen MPU (PMSA) support. Introduce a Kconfig choice under the "Architecture Features" menu for user to choose the memory system architecture for the system. Since currently only VMSA is supported, only add the bool CONFIG_HAS_MMU to keep consistent with the default behavior. User can choose either VMSA or PMSA but not both in the future after PMSA/MPU is supported in Xen. Suggested-by: Julien Grall Signed-off-by: Henry Wang --- v4: - Completely rework "[v3,06/52] xen/arm: introduce CONFIG_HAS_MMU" --- xen/arch/arm/Kconfig | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index fd57a82dd2..0e38e9ba17 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -59,6 +59,20 @@ config PADDR_BITS default 40 if ARM_PA_BITS_40 default 48 if ARM_64 +choice + prompt "Memory system architecture" + default HAS_MMU + help + User can choose the memory system architecture. + A Virtual Memory System Architecture (VMSA) provides a Memory Management + Unit (MMU) that controls address translation, access permissions, and + memory attribute determination and checking, for memory accesses made by + the PE. + +config HAS_MMU + bool "MMU for a VMSA system" +endchoice + source "arch/Kconfig" config ACPI -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:44:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:44:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573555.898382 (Exim 4.92) (envelope-from ) id 1qQgJW-0007kE-1k; Tue, 01 Aug 2023 03:44:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573555.898382; Tue, 01 Aug 2023 03:44:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJV-0007k6-UW; Tue, 01 Aug 2023 03:44:49 +0000 Received: by outflank-mailman (input) for mailman id 573555; Tue, 01 Aug 2023 03:44:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJT-00076X-Nn for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c08dcdcf-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:44:44 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A91D1D75; Mon, 31 Jul 2023 20:45:26 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5A7613F59C; Mon, 31 Jul 2023 20:44:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c08dcdcf-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Henry Wang Subject: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S Date: Tue, 1 Aug 2023 11:44:09 +0800 Message-Id: <20230801034419.2047541-4-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen We want to reuse head.S for MPU systems, but there are some code are implemented for MMU systems only. We will move such code to another MMU specific file. But before that we will do some indentations fix in this patch to make them be easier for reviewing: 1. Fix the indentations and incorrect style of code comments. 2. Fix the indentations for .text.header section. 3. Rename puts() to asm_puts() for global export Signed-off-by: Wei Chen Signed-off-by: Penny Zheng Signed-off-by: Henry Wang --- v4: - Rebase to pick the adr -> adr_l change in PRINT(_s). - Correct in-code comment for asm_puts() and add a note to mention that asm_puts() should be only called from assembly. - Drop redundant puts (now asm_puts) under CONFIG_EARLY_PRINTK. v3: - fix commit message - Rename puts() to asm_puts() for global export v2: - New patch. --- xen/arch/arm/arm64/head.S | 46 ++++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 2af9f974d5..b29bffce5b 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -94,7 +94,7 @@ #define PRINT(_s) \ mov x3, lr ; \ adr_l x0, 98f ; \ - bl puts ; \ + bl asm_puts ; \ mov lr, x3 ; \ RODATA_STR(98, _s) @@ -136,21 +136,21 @@ add \xb, \xb, x20 .endm - .section .text.header, "ax", %progbits - /*.aarch64*/ +.section .text.header, "ax", %progbits +/*.aarch64*/ - /* - * Kernel startup entry point. - * --------------------------- - * - * The requirements are: - * MMU = off, D-cache = off, I-cache = on or off, - * x0 = physical address to the FDT blob. - * - * This must be the very first address in the loaded image. - * It should be linked at XEN_VIRT_START, and loaded at any - * 4K-aligned address. - */ +/* + * Kernel startup entry point. + * --------------------------- + * + * The requirements are: + * MMU = off, D-cache = off, I-cache = on or off, + * x0 = physical address to the FDT blob. + * + * This must be the very first address in the loaded image. + * It should be linked at XEN_VIRT_START, and loaded at any + * 4K-aligned address. + */ GLOBAL(start) /* @@ -535,7 +535,7 @@ ENDPROC(cpu_init) * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd * level table (i.e page granularity) is supported. * - * ptbl: table symbol where the entry will be created + * ptbl: table symbol where the entry will be created * virt: virtual address * phys: physical address (should be page aligned) * tmp1: scratch register @@ -970,19 +970,22 @@ init_uart: ret ENDPROC(init_uart) -/* Print early debug messages. +/* + * Print early debug messages. + * Note: This function is only supposed to be called from assembly. * x0: Nul-terminated string to print. * x23: Early UART base address - * Clobbers x0-x1 */ -puts: + * Clobbers x0-x1 + */ +ENTRY(asm_puts) early_uart_ready x23, 1 ldrb w1, [x0], #1 /* Load next char */ cbz w1, 1f /* Exit on nul */ early_uart_transmit x23, w1 - b puts + b asm_puts 1: ret -ENDPROC(puts) +ENDPROC(asm_puts) /* * Print a 64-bit number in hex. @@ -1012,7 +1015,6 @@ hex: .ascii "0123456789abcdef" ENTRY(early_puts) init_uart: -puts: putn: ret #endif /* !CONFIG_EARLY_PRINTK */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:44:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:44:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573557.898392 (Exim 4.92) (envelope-from ) id 1qQgJZ-00084w-Ai; Tue, 01 Aug 2023 03:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573557.898392; Tue, 01 Aug 2023 03:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJZ-00084l-6s; Tue, 01 Aug 2023 03:44:53 +0000 Received: by outflank-mailman (input) for mailman id 573557; Tue, 01 Aug 2023 03:44:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJX-00076X-JB for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c354d313-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:44:48 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53A67D75; Mon, 31 Jul 2023 20:45:31 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 671733F59C; Mon, 31 Jul 2023 20:44:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c354d313-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Penny Zheng , Volodymyr Babchuk , Wei Chen Subject: [PATCH v4 04/13] xen/arm64: Split and move MMU-specific head.S to mmu/head.S Date: Tue, 1 Aug 2023 11:44:10 +0800 Message-Id: <20230801034419.2047541-5-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MMU specific code in head.S will not be used on MPU systems. Instead of introducing more #ifdefs which will bring complexity to the code, move MMU related code to mmu/head.S and keep common code in head.S. Two notes while moving: - As "fail" in original head.S is very simple and this name is too easy to be conflicted, duplicate it in mmu/head.S instead of exporting it. - Use ENTRY() for enable_secondary_cpu_mm, enable_boot_cpu_mm and setup_fixmap to please the compiler after the code movement. Also move the assembly macros shared by head.S and mmu/head.S to macros.h. Note that, only the first 4KB of Xen image will be mapped as identity (PA == VA). At the moment, Xen guarantees this by having everything that needs to be used in the identity mapping in .text.header section of head.S, and the size will be checked by _idmap_start and _idmap_end at link time if this fits in 4KB. Since we are introducing a new head.S in this patch, although we can add .text.header to the new file to guarantee all identity map code still in the first 4KB. However, the order of these two files on this 4KB depends on the build toolchains. Hence, introduce a new section named .text.idmap in the region between _idmap_start and _idmap_end. And in Xen linker script, we force the .text.idmap contents to linked after .text.header. This will ensure code of head.S always be at the top of Xen binary. Signed-off-by: Henry Wang Signed-off-by: Wei Chen --- v4: - Rework "[v3,08/52] xen/arm64: move MMU related code from head.S to mmu/head.S" - Don't move the "yet to shared" macro such as print_reg. - Fold "[v3,04/52] xen/arm: add .text.idmap in ld script for Xen identity map sections" to this patch. Rework commit msg. --- xen/arch/arm/arm64/Makefile | 1 + xen/arch/arm/arm64/head.S | 497 +----------------------- xen/arch/arm/arm64/mmu/Makefile | 1 + xen/arch/arm/arm64/mmu/head.S | 487 +++++++++++++++++++++++ xen/arch/arm/include/asm/arm64/macros.h | 36 ++ xen/arch/arm/xen.lds.S | 1 + 6 files changed, 527 insertions(+), 496 deletions(-) create mode 100644 xen/arch/arm/arm64/mmu/Makefile create mode 100644 xen/arch/arm/arm64/mmu/head.S diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index 54ad55c75c..ce8749f046 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -1,4 +1,5 @@ obj-y += lib/ +obj-$(CONFIG_HAS_MMU) += mmu/ obj-y += cache.o obj-y += cpufeature.o diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index b29bffce5b..e4f579a48e 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -28,17 +28,6 @@ #include #endif -#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ -#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ -#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ -#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ -#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ - -/* Convenience defines to get slot used by Xen mapping. */ -#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) -#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) -#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) - #define __HEAD_FLAG_PAGE_SIZE ((PAGE_SHIFT - 10) / 2) #define __HEAD_FLAG_PHYS_BASE 1 @@ -85,19 +74,7 @@ * x30 - lr */ -#ifdef CONFIG_EARLY_PRINTK -/* - * Macro to print a string to the UART, if there is one. - * - * Clobbers x0 - x3 - */ -#define PRINT(_s) \ - mov x3, lr ; \ - adr_l x0, 98f ; \ - bl asm_puts ; \ - mov lr, x3 ; \ - RODATA_STR(98, _s) - + #ifdef CONFIG_EARLY_PRINTK /* * Macro to print the value of register \xb * @@ -111,31 +88,11 @@ .endm #else /* CONFIG_EARLY_PRINTK */ -#define PRINT(s) - .macro print_reg xb .endm #endif /* !CONFIG_EARLY_PRINTK */ -/* - * Pseudo-op for PC relative adr , where is - * within the range +/- 4GB of the PC. - * - * @dst: destination register (64 bit wide) - * @sym: name of the symbol - */ -.macro adr_l, dst, sym - adrp \dst, \sym - add \dst, \dst, :lo12:\sym -.endm - -/* Load the physical address of a symbol into xb */ -.macro load_paddr xb, sym - ldr \xb, =\sym - add \xb, \xb, x20 -.endm - .section .text.header, "ax", %progbits /*.aarch64*/ @@ -472,413 +429,6 @@ cpu_init: ret ENDPROC(cpu_init) -/* - * Macro to find the slot number at a given page-table level - * - * slot: slot computed - * virt: virtual address - * lvl: page-table level - */ -.macro get_table_slot, slot, virt, lvl - ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT -.endm - -/* - * Macro to create a page table entry in \ptbl to \tbl - * ptbl: table symbol where the entry will be created - * tbl: physical address of the table to point to - * virt: virtual address - * lvl: page-table level - * tmp1: scratch register - * tmp2: scratch register - * - * Preserves \virt - * Clobbers \tbl, \tmp1, \tmp2 - * - * Note that all parameters using registers should be distinct. - */ -.macro create_table_entry_from_paddr, ptbl, tbl, virt, lvl, tmp1, tmp2 - get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tbl */ - - mov \tmp2, #PT_PT /* \tmp2 := right for linear PT */ - orr \tmp2, \tmp2, \tbl /* + \tbl */ - - adr_l \tbl, \ptbl /* \tbl := address(\ptbl) */ - - str \tmp2, [\tbl, \tmp1, lsl #3] -.endm - -/* - * Macro to create a page table entry in \ptbl to \tbl - * - * ptbl: table symbol where the entry will be created - * tbl: table symbol to point to - * virt: virtual address - * lvl: page-table level - * tmp1: scratch register - * tmp2: scratch register - * tmp3: scratch register - * - * Preserves \virt - * Clobbers \tmp1, \tmp2, \tmp3 - * - * Also use x20 for the phys offset. - * - * Note that all parameters using registers should be distinct. - */ -.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 - load_paddr \tmp1, \tbl - create_table_entry_from_paddr \ptbl, \tmp1, \virt, \lvl, \tmp2, \tmp3 -.endm - -/* - * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd - * level table (i.e page granularity) is supported. - * - * ptbl: table symbol where the entry will be created - * virt: virtual address - * phys: physical address (should be page aligned) - * tmp1: scratch register - * tmp2: scratch register - * tmp3: scratch register - * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) - * - * Preserves \virt, \phys - * Clobbers \tmp1, \tmp2, \tmp3 - * - * Note that all parameters using registers should be distinct. - */ -.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 - and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ - - get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ - - mov \tmp2, #\type /* \tmp2 := right for section PT */ - orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ - - adr_l \tmp3, \ptbl - - str \tmp2, [\tmp3, \tmp1, lsl #3] -.endm - -/* - * Rebuild the boot pagetable's first-level entries. The structure - * is described in mm.c. - * - * After the CPU enables paging it will add the fixmap mapping - * to these page tables, however this may clash with the 1:1 - * mapping. So each CPU must rebuild the page tables here with - * the 1:1 in place. - * - * Inputs: - * x19: paddr(start) - * x20: phys offset - * - * Clobbers x0 - x4 - */ -create_page_tables: - /* Prepare the page-tables for mapping Xen */ - ldr x0, =XEN_VIRT_START - create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 - create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 - - /* - * We need to use a stash register because - * create_table_entry_paddr() will clobber the register storing - * the physical address of the table to point to. - */ - load_paddr x4, boot_third - ldr x1, =XEN_VIRT_START -.rept XEN_NR_ENTRIES(2) - mov x0, x4 /* x0 := paddr(l3 table) */ - create_table_entry_from_paddr boot_second, x0, x1, 2, x2, x3 - add x1, x1, #XEN_PT_LEVEL_SIZE(2) /* x1 := Next vaddr */ - add x4, x4, #PAGE_SIZE /* x4 := Next table */ -.endr - - /* - * Find the size of Xen in pages and multiply by the size of a - * PTE. This will then be compared in the mapping loop below. - * - * Note the multiplication is just to avoid using an extra - * register/instruction per iteration. - */ - ldr x0, =_start /* x0 := vaddr(_start) */ - ldr x1, =_end /* x1 := vaddr(_end) */ - sub x0, x1, x0 /* x0 := effective size of Xen */ - lsr x0, x0, #PAGE_SHIFT /* x0 := Number of pages for Xen */ - lsl x0, x0, #3 /* x0 := Number of pages * PTE size */ - - /* Map Xen */ - adr_l x4, boot_third - - lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ - lsl x2, x2, #THIRD_SHIFT - mov x3, #PT_MEM_L3 /* x2 := Section map */ - orr x2, x2, x3 - - /* ... map of vaddr(start) in boot_third */ - mov x1, xzr -1: str x2, [x4, x1] /* Map vaddr(start) */ - add x2, x2, #PAGE_SIZE /* Next page */ - add x1, x1, #8 /* Next slot */ - cmp x1, x0 /* Loop until we map all of Xen */ - b.lt 1b - - /* - * If Xen is loaded at exactly XEN_VIRT_START then we don't - * need an additional 1:1 mapping, the virtual mapping will - * suffice. - */ - ldr x0, =XEN_VIRT_START - cmp x19, x0 - bne 1f - ret -1: - /* - * Setup the 1:1 mapping so we can turn the MMU on. Note that - * only the first page of Xen will be part of the 1:1 mapping. - */ - - /* - * Find the zeroeth slot used. If the slot is not - * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of - * page-tables from the first level. - */ - get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ - cmp x0, #XEN_ZEROETH_SLOT - beq 1f - create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 - b link_from_first_id - -1: - /* - * Find the first slot used. If the slot is not XEN_FIRST_SLOT, - * then the 1:1 mapping will use its own set of page-tables from - * the second level. - */ - get_table_slot x0, x19, 1 /* x0 := first slot */ - cmp x0, #XEN_FIRST_SLOT - beq 1f - create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 - b link_from_second_id - -1: - /* - * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the - * 1:1 mapping will use its own set of page-tables from the - * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle - * it. - */ - get_table_slot x0, x19, 2 /* x0 := second slot */ - cmp x0, #XEN_SECOND_SLOT - beq virtphys_clash - create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 - b link_from_third_id - -link_from_first_id: - create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 -link_from_second_id: - create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 -link_from_third_id: - create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 - ret - -virtphys_clash: - /* Identity map clashes with boot_third, which we cannot handle yet */ - PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") - b fail -ENDPROC(create_page_tables) - -/* - * Turn on the Data Cache and the MMU. The function will return on the 1:1 - * mapping. In other word, the caller is responsible to switch to the runtime - * mapping. - * - * Inputs: - * x0 : Physical address of the page tables. - * - * Clobbers x0 - x4 - */ -enable_mmu: - mov x4, x0 - PRINT("- Turning on paging -\r\n") - - /* - * The state of the TLBs is unknown before turning on the MMU. - * Flush them to avoid stale one. - */ - tlbi alle2 /* Flush hypervisor TLBs */ - dsb nsh - - /* Write Xen's PT's paddr into TTBR0_EL2 */ - msr TTBR0_EL2, x4 - isb - - mrs x0, SCTLR_EL2 - orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ - orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ - dsb sy /* Flush PTE writes and finish reads */ - msr SCTLR_EL2, x0 /* now paging is enabled */ - isb /* Now, flush the icache */ - ret -ENDPROC(enable_mmu) - -/* - * Enable mm (turn on the data cache and the MMU) for secondary CPUs. - * The function will return to the virtual address provided in LR (e.g. the - * runtime mapping). - * - * Inputs: - * lr : Virtual address to return to. - * - * Clobbers x0 - x5 - */ -enable_secondary_cpu_mm: - mov x5, lr - - load_paddr x0, init_ttbr - ldr x0, [x0] - - bl enable_mmu - mov lr, x5 - - /* return to secondary_switched */ - ret -ENDPROC(enable_secondary_cpu_mm) - -/* - * Enable mm (turn on the data cache and the MMU) for the boot CPU. - * The function will return to the virtual address provided in LR (e.g. the - * runtime mapping). - * - * Inputs: - * lr : Virtual address to return to. - * - * Clobbers x0 - x5 - */ -enable_boot_cpu_mm: - mov x5, lr - - bl create_page_tables - load_paddr x0, boot_pgtable - - bl enable_mmu - mov lr, x5 - - /* - * The MMU is turned on and we are in the 1:1 mapping. Switch - * to the runtime mapping. - */ - ldr x0, =1f - br x0 -1: - /* - * The 1:1 map may clash with other parts of the Xen virtual memory - * layout. As it is not used anymore, remove it completely to - * avoid having to worry about replacing existing mapping - * afterwards. Function will return to primary_switched. - */ - b remove_identity_mapping - - /* - * Below is supposed to be unreachable code, as "ret" in - * remove_identity_mapping will use the return address in LR in advance. - */ - b fail -ENDPROC(enable_boot_cpu_mm) - -/* - * Remove the 1:1 map from the page-tables. It is not easy to keep track - * where the 1:1 map was mapped, so we will look for the top-level entry - * exclusive to the 1:1 map and remove it. - * - * Inputs: - * x19: paddr(start) - * - * Clobbers x0 - x1 - */ -remove_identity_mapping: - /* - * Find the zeroeth slot used. Remove the entry from zeroeth - * table if the slot is not XEN_ZEROETH_SLOT. - */ - get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ - cmp x1, #XEN_ZEROETH_SLOT - beq 1f - /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ - ldr x0, =boot_pgtable /* x0 := root table */ - str xzr, [x0, x1, lsl #3] - b identity_mapping_removed - -1: - /* - * Find the first slot used. Remove the entry for the first - * table if the slot is not XEN_FIRST_SLOT. - */ - get_table_slot x1, x19, 1 /* x1 := first slot */ - cmp x1, #XEN_FIRST_SLOT - beq 1f - /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ - ldr x0, =boot_first /* x0 := first table */ - str xzr, [x0, x1, lsl #3] - b identity_mapping_removed - -1: - /* - * Find the second slot used. Remove the entry for the first - * table if the slot is not XEN_SECOND_SLOT. - */ - get_table_slot x1, x19, 2 /* x1 := second slot */ - cmp x1, #XEN_SECOND_SLOT - beq identity_mapping_removed - /* It is not in slot 1, remove the entry */ - ldr x0, =boot_second /* x0 := second table */ - str xzr, [x0, x1, lsl #3] - -identity_mapping_removed: - /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ - dsb nshst - tlbi alle2 - dsb nsh - isb - - ret -ENDPROC(remove_identity_mapping) - -/* - * Map the UART in the fixmap (when earlyprintk is used) and hook the - * fixmap table in the page tables. - * - * The fixmap cannot be mapped in create_page_tables because it may - * clash with the 1:1 mapping. - * - * Inputs: - * x20: Physical offset - * x23: Early UART base physical address - * - * Clobbers x0 - x3 - */ -setup_fixmap: -#ifdef CONFIG_EARLY_PRINTK - /* Add UART to the fixmap table */ - ldr x0, =EARLY_UART_VIRTUAL_ADDRESS - create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 -#endif - /* Map fixmap into boot_second */ - ldr x0, =FIXMAP_ADDR(0) - create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 - /* Ensure any page table updates made above have occurred. */ - dsb nshst - /* - * The fixmap area will be used soon after. So ensure no hardware - * translation happens before the dsb completes. - */ - isb - - ret -ENDPROC(setup_fixmap) - /* * Setup the initial stack and jump to the C world * @@ -907,51 +457,6 @@ fail: PRINT("- Boot failed -\r\n") b 1b ENDPROC(fail) -/* - * Switch TTBR - * - * x0 ttbr - */ -ENTRY(switch_ttbr_id) - /* 1) Ensure any previous read/write have completed */ - dsb ish - isb - - /* 2) Turn off MMU */ - mrs x1, SCTLR_EL2 - bic x1, x1, #SCTLR_Axx_ELx_M - msr SCTLR_EL2, x1 - isb - - /* - * 3) Flush the TLBs. - * See asm/arm64/flushtlb.h for the explanation of the sequence. - */ - dsb nshst - tlbi alle2 - dsb nsh - isb - - /* 4) Update the TTBR */ - msr TTBR0_EL2, x0 - isb - - /* - * 5) Flush I-cache - * This should not be necessary but it is kept for safety. - */ - ic iallu - isb - - /* 6) Turn on the MMU */ - mrs x1, SCTLR_EL2 - orr x1, x1, #SCTLR_Axx_ELx_M /* Enable MMU */ - msr SCTLR_EL2, x1 - isb - - ret -ENDPROC(switch_ttbr_id) - #ifdef CONFIG_EARLY_PRINTK /* * Initialize the UART. Should only be called on the boot CPU. diff --git a/xen/arch/arm/arm64/mmu/Makefile b/xen/arch/arm/arm64/mmu/Makefile new file mode 100644 index 0000000000..3340058c08 --- /dev/null +++ b/xen/arch/arm/arm64/mmu/Makefile @@ -0,0 +1 @@ +obj-y += head.o diff --git a/xen/arch/arm/arm64/mmu/head.S b/xen/arch/arm/arm64/mmu/head.S new file mode 100644 index 0000000000..b7c3dd423a --- /dev/null +++ b/xen/arch/arm/arm64/mmu/head.S @@ -0,0 +1,487 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * xen/arch/arm/arm64/mmu/head.S + * + * Arm64 MMU specific start-of-day code. + */ + +#include +#include + +#define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */ +#define PT_MEM_L3 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ +#define PT_DEV 0xe71 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=0 P=1 */ +#define PT_DEV_L3 0xe73 /* nG=1 AF=1 SH=10 AP=01 NS=1 ATTR=100 T=1 P=1 */ + +/* Convenience defines to get slot used by Xen mapping. */ +#define XEN_ZEROETH_SLOT zeroeth_table_offset(XEN_VIRT_START) +#define XEN_FIRST_SLOT first_table_offset(XEN_VIRT_START) +#define XEN_SECOND_SLOT second_table_offset(XEN_VIRT_START) + +/* + * Macro to find the slot number at a given page-table level + * + * slot: slot computed + * virt: virtual address + * lvl: page-table level + */ +.macro get_table_slot, slot, virt, lvl + ubfx \slot, \virt, #XEN_PT_LEVEL_SHIFT(\lvl), #XEN_PT_LPAE_SHIFT +.endm + +/* + * Macro to create a page table entry in \ptbl to \tbl + * ptbl: table symbol where the entry will be created + * tbl: physical address of the table to point to + * virt: virtual address + * lvl: page-table level + * tmp1: scratch register + * tmp2: scratch register + * + * Preserves \virt + * Clobbers \tbl, \tmp1, \tmp2 + * + * Note that all parameters using registers should be distinct. + */ +.macro create_table_entry_from_paddr, ptbl, tbl, virt, lvl, tmp1, tmp2 + get_table_slot \tmp1, \virt, \lvl /* \tmp1 := slot in \tbl */ + + mov \tmp2, #PT_PT /* \tmp2 := right for linear PT */ + orr \tmp2, \tmp2, \tbl /* + \tbl */ + + adr_l \tbl, \ptbl /* \tbl := address(\ptbl) */ + + str \tmp2, [\tbl, \tmp1, lsl #3] +.endm + +/* + * Macro to create a page table entry in \ptbl to \tbl + * + * ptbl: table symbol where the entry will be created + * tbl: table symbol to point to + * virt: virtual address + * lvl: page-table level + * tmp1: scratch register + * tmp2: scratch register + * tmp3: scratch register + * + * Preserves \virt + * Clobbers \tmp1, \tmp2, \tmp3 + * + * Also use x20 for the phys offset. + * + * Note that all parameters using registers should be distinct. + */ +.macro create_table_entry, ptbl, tbl, virt, lvl, tmp1, tmp2, tmp3 + load_paddr \tmp1, \tbl + create_table_entry_from_paddr \ptbl, \tmp1, \virt, \lvl, \tmp2, \tmp3 +.endm + +/* + * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd + * level table (i.e page granularity) is supported. + * + * ptbl: table symbol where the entry will be created + * virt: virtual address + * phys: physical address (should be page aligned) + * tmp1: scratch register + * tmp2: scratch register + * tmp3: scratch register + * type: mapping type. If not specified it will be normal memory (PT_MEM_L3) + * + * Preserves \virt, \phys + * Clobbers \tmp1, \tmp2, \tmp3 + * + * Note that all parameters using registers should be distinct. + */ +.macro create_mapping_entry, ptbl, virt, phys, tmp1, tmp2, tmp3, type=PT_MEM_L3 + and \tmp3, \phys, #THIRD_MASK /* \tmp3 := PAGE_ALIGNED(phys) */ + + get_table_slot \tmp1, \virt, 3 /* \tmp1 := slot in \tlb */ + + mov \tmp2, #\type /* \tmp2 := right for section PT */ + orr \tmp2, \tmp2, \tmp3 /* + PAGE_ALIGNED(phys) */ + + adr_l \tmp3, \ptbl + + str \tmp2, [\tmp3, \tmp1, lsl #3] +.endm + +.section .text.idmap, "ax", %progbits + +/* + * Rebuild the boot pagetable's first-level entries. The structure + * is described in mm.c. + * + * After the CPU enables paging it will add the fixmap mapping + * to these page tables, however this may clash with the 1:1 + * mapping. So each CPU must rebuild the page tables here with + * the 1:1 in place. + * + * Inputs: + * x19: paddr(start) + * x20: phys offset + * + * Clobbers x0 - x4 + */ +create_page_tables: + /* Prepare the page-tables for mapping Xen */ + ldr x0, =XEN_VIRT_START + create_table_entry boot_pgtable, boot_first, x0, 0, x1, x2, x3 + create_table_entry boot_first, boot_second, x0, 1, x1, x2, x3 + + /* + * We need to use a stash register because + * create_table_entry_paddr() will clobber the register storing + * the physical address of the table to point to. + */ + load_paddr x4, boot_third + ldr x1, =XEN_VIRT_START +.rept XEN_NR_ENTRIES(2) + mov x0, x4 /* x0 := paddr(l3 table) */ + create_table_entry_from_paddr boot_second, x0, x1, 2, x2, x3 + add x1, x1, #XEN_PT_LEVEL_SIZE(2) /* x1 := Next vaddr */ + add x4, x4, #PAGE_SIZE /* x4 := Next table */ +.endr + + /* + * Find the size of Xen in pages and multiply by the size of a + * PTE. This will then be compared in the mapping loop below. + * + * Note the multiplication is just to avoid using an extra + * register/instruction per iteration. + */ + ldr x0, =_start /* x0 := vaddr(_start) */ + ldr x1, =_end /* x1 := vaddr(_end) */ + sub x0, x1, x0 /* x0 := effective size of Xen */ + lsr x0, x0, #PAGE_SHIFT /* x0 := Number of pages for Xen */ + lsl x0, x0, #3 /* x0 := Number of pages * PTE size */ + + /* Map Xen */ + adr_l x4, boot_third + + lsr x2, x19, #THIRD_SHIFT /* Base address for 4K mapping */ + lsl x2, x2, #THIRD_SHIFT + mov x3, #PT_MEM_L3 /* x2 := Section map */ + orr x2, x2, x3 + + /* ... map of vaddr(start) in boot_third */ + mov x1, xzr +1: str x2, [x4, x1] /* Map vaddr(start) */ + add x2, x2, #PAGE_SIZE /* Next page */ + add x1, x1, #8 /* Next slot */ + cmp x1, x0 /* Loop until we map all of Xen */ + b.lt 1b + + /* + * If Xen is loaded at exactly XEN_VIRT_START then we don't + * need an additional 1:1 mapping, the virtual mapping will + * suffice. + */ + ldr x0, =XEN_VIRT_START + cmp x19, x0 + bne 1f + ret +1: + /* + * Setup the 1:1 mapping so we can turn the MMU on. Note that + * only the first page of Xen will be part of the 1:1 mapping. + */ + + /* + * Find the zeroeth slot used. If the slot is not + * XEN_ZEROETH_SLOT, then the 1:1 mapping will use its own set of + * page-tables from the first level. + */ + get_table_slot x0, x19, 0 /* x0 := zeroeth slot */ + cmp x0, #XEN_ZEROETH_SLOT + beq 1f + create_table_entry boot_pgtable, boot_first_id, x19, 0, x0, x1, x2 + b link_from_first_id + +1: + /* + * Find the first slot used. If the slot is not XEN_FIRST_SLOT, + * then the 1:1 mapping will use its own set of page-tables from + * the second level. + */ + get_table_slot x0, x19, 1 /* x0 := first slot */ + cmp x0, #XEN_FIRST_SLOT + beq 1f + create_table_entry boot_first, boot_second_id, x19, 1, x0, x1, x2 + b link_from_second_id + +1: + /* + * Find the second slot used. If the slot is XEN_SECOND_SLOT, then the + * 1:1 mapping will use its own set of page-tables from the + * third level. For slot XEN_SECOND_SLOT, Xen is not yet able to handle + * it. + */ + get_table_slot x0, x19, 2 /* x0 := second slot */ + cmp x0, #XEN_SECOND_SLOT + beq virtphys_clash + create_table_entry boot_second, boot_third_id, x19, 2, x0, x1, x2 + b link_from_third_id + +link_from_first_id: + create_table_entry boot_first_id, boot_second_id, x19, 1, x0, x1, x2 +link_from_second_id: + create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 +link_from_third_id: + create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 + ret + +virtphys_clash: + /* Identity map clashes with boot_third, which we cannot handle yet */ + PRINT("- Unable to build boot page tables - virt and phys addresses clash. -\r\n") + b fail +ENDPROC(create_page_tables) + +/* + * Turn on the Data Cache and the MMU. The function will return on the 1:1 + * mapping. In other word, the caller is responsible to switch to the runtime + * mapping. + * + * Inputs: + * x0 : Physical address of the page tables. + * + * Clobbers x0 - x4 + */ +enable_mmu: + mov x4, x0 + PRINT("- Turning on paging -\r\n") + + /* + * The state of the TLBs is unknown before turning on the MMU. + * Flush them to avoid stale one. + */ + tlbi alle2 /* Flush hypervisor TLBs */ + dsb nsh + + /* Write Xen's PT's paddr into TTBR0_EL2 */ + msr TTBR0_EL2, x4 + isb + + mrs x0, SCTLR_EL2 + orr x0, x0, #SCTLR_Axx_ELx_M /* Enable MMU */ + orr x0, x0, #SCTLR_Axx_ELx_C /* Enable D-cache */ + dsb sy /* Flush PTE writes and finish reads */ + msr SCTLR_EL2, x0 /* now paging is enabled */ + isb /* Now, flush the icache */ + ret +ENDPROC(enable_mmu) + +/* + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. + * The function will return to the virtual address provided in LR (e.g. the + * runtime mapping). + * + * Inputs: + * lr : Virtual address to return to. + * + * Clobbers x0 - x5 + */ +ENTRY(enable_secondary_cpu_mm) + mov x5, lr + + load_paddr x0, init_ttbr + ldr x0, [x0] + + bl enable_mmu + mov lr, x5 + + /* return to secondary_switched */ + ret +ENDPROC(enable_secondary_cpu_mm) + +/* + * Enable mm (turn on the data cache and the MMU) for the boot CPU. + * The function will return to the virtual address provided in LR (e.g. the + * runtime mapping). + * + * Inputs: + * lr : Virtual address to return to. + * + * Clobbers x0 - x5 + */ +ENTRY(enable_boot_cpu_mm) + mov x5, lr + + bl create_page_tables + load_paddr x0, boot_pgtable + + bl enable_mmu + mov lr, x5 + + /* + * The MMU is turned on and we are in the 1:1 mapping. Switch + * to the runtime mapping. + */ + ldr x0, =1f + br x0 +1: + /* + * The 1:1 map may clash with other parts of the Xen virtual memory + * layout. As it is not used anymore, remove it completely to + * avoid having to worry about replacing existing mapping + * afterwards. Function will return to primary_switched. + */ + b remove_identity_mapping + + /* + * Below is supposed to be unreachable code, as "ret" in + * remove_identity_mapping will use the return address in LR in advance. + */ + b fail +ENDPROC(enable_boot_cpu_mm) + +/* + * Remove the 1:1 map from the page-tables. It is not easy to keep track + * where the 1:1 map was mapped, so we will look for the top-level entry + * exclusive to the 1:1 map and remove it. + * + * Inputs: + * x19: paddr(start) + * + * Clobbers x0 - x1 + */ +remove_identity_mapping: + /* + * Find the zeroeth slot used. Remove the entry from zeroeth + * table if the slot is not XEN_ZEROETH_SLOT. + */ + get_table_slot x1, x19, 0 /* x1 := zeroeth slot */ + cmp x1, #XEN_ZEROETH_SLOT + beq 1f + /* It is not in slot XEN_ZEROETH_SLOT, remove the entry. */ + ldr x0, =boot_pgtable /* x0 := root table */ + str xzr, [x0, x1, lsl #3] + b identity_mapping_removed + +1: + /* + * Find the first slot used. Remove the entry for the first + * table if the slot is not XEN_FIRST_SLOT. + */ + get_table_slot x1, x19, 1 /* x1 := first slot */ + cmp x1, #XEN_FIRST_SLOT + beq 1f + /* It is not in slot XEN_FIRST_SLOT, remove the entry. */ + ldr x0, =boot_first /* x0 := first table */ + str xzr, [x0, x1, lsl #3] + b identity_mapping_removed + +1: + /* + * Find the second slot used. Remove the entry for the first + * table if the slot is not XEN_SECOND_SLOT. + */ + get_table_slot x1, x19, 2 /* x1 := second slot */ + cmp x1, #XEN_SECOND_SLOT + beq identity_mapping_removed + /* It is not in slot 1, remove the entry */ + ldr x0, =boot_second /* x0 := second table */ + str xzr, [x0, x1, lsl #3] + +identity_mapping_removed: + /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ + dsb nshst + tlbi alle2 + dsb nsh + isb + + ret +ENDPROC(remove_identity_mapping) + +/* + * Map the UART in the fixmap (when earlyprintk is used) and hook the + * fixmap table in the page tables. + * + * The fixmap cannot be mapped in create_page_tables because it may + * clash with the 1:1 mapping. + * + * Inputs: + * x20: Physical offset + * x23: Early UART base physical address + * + * Clobbers x0 - x3 + */ +ENTRY(setup_fixmap) +#ifdef CONFIG_EARLY_PRINTK + /* Add UART to the fixmap table */ + ldr x0, =EARLY_UART_VIRTUAL_ADDRESS + create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 +#endif + /* Map fixmap into boot_second */ + ldr x0, =FIXMAP_ADDR(0) + create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 + /* Ensure any page table updates made above have occurred. */ + dsb nshst + /* + * The fixmap area will be used soon after. So ensure no hardware + * translation happens before the dsb completes. + */ + isb + + ret +ENDPROC(setup_fixmap) + +/* Fail-stop */ +fail: PRINT("- Boot failed -\r\n") +1: wfe + b 1b +ENDPROC(fail) + +/* + * Switch TTBR + * + * x0 ttbr + */ +ENTRY(switch_ttbr_id) + /* 1) Ensure any previous read/write have completed */ + dsb ish + isb + + /* 2) Turn off MMU */ + mrs x1, SCTLR_EL2 + bic x1, x1, #SCTLR_Axx_ELx_M + msr SCTLR_EL2, x1 + isb + + /* + * 3) Flush the TLBs. + * See asm/arm64/flushtlb.h for the explanation of the sequence. + */ + dsb nshst + tlbi alle2 + dsb nsh + isb + + /* 4) Update the TTBR */ + msr TTBR0_EL2, x0 + isb + + /* + * 5) Flush I-cache + * This should not be necessary but it is kept for safety. + */ + ic iallu + isb + + /* 6) Turn on the MMU */ + mrs x1, SCTLR_EL2 + orr x1, x1, #SCTLR_Axx_ELx_M /* Enable MMU */ + msr SCTLR_EL2, x1 + isb + + ret +ENDPROC(switch_ttbr_id) + +/* + * Local variables: + * mode: ASM + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm64/macros.h b/xen/arch/arm/include/asm/arm64/macros.h index 140e223b4c..99c401fcaf 100644 --- a/xen/arch/arm/include/asm/arm64/macros.h +++ b/xen/arch/arm/include/asm/arm64/macros.h @@ -32,6 +32,42 @@ hint #22 .endm +#ifdef CONFIG_EARLY_PRINTK +/* + * Macro to print a string to the UART, if there is one. + * + * Clobbers x0 - x3 + */ +#define PRINT(_s) \ + mov x3, lr ; \ + adr_l x0, 98f ; \ + bl asm_puts ; \ + mov lr, x3 ; \ + RODATA_STR(98, _s) + +#else /* CONFIG_EARLY_PRINTK */ +#define PRINT(s) + +#endif /* !CONFIG_EARLY_PRINTK */ + +/* + * Pseudo-op for PC relative adr , where is + * within the range +/- 4GB of the PC. + * + * @dst: destination register (64 bit wide) + * @sym: name of the symbol + */ +.macro adr_l, dst, sym + adrp \dst, \sym + add \dst, \dst, :lo12:\sym +.endm + +/* Load the physical address of a symbol into xb */ +.macro load_paddr xb, sym + ldr \xb, =\sym + add \xb, \xb, x20 +.endm + /* * Register aliases. */ diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index a3c90ca823..59b80d122f 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -34,6 +34,7 @@ SECTIONS _stext = .; /* Text section */ _idmap_start = .; *(.text.header) + *(.text.idmap) _idmap_end = .; *(.text.cold) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:44:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:44:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573558.898402 (Exim 4.92) (envelope-from ) id 1qQgJb-00006P-Pp; Tue, 01 Aug 2023 03:44:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573558.898402; Tue, 01 Aug 2023 03:44:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJb-00005X-MW; Tue, 01 Aug 2023 03:44:55 +0000 Received: by outflank-mailman (input) for mailman id 573558; Tue, 01 Aug 2023 03:44:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJa-00076X-P6 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:54 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c5c24317-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:44:52 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E9D6D75; Mon, 31 Jul 2023 20:45:35 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 208AC3F59C; Mon, 31 Jul 2023 20:44:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5c24317-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Henry Wang Subject: [PATCH v4 05/13] xen/arm: Move MMU related definitions from config.h to mmu/layout.h Date: Tue, 1 Aug 2023 11:44:11 +0800 Message-Id: <20230801034419.2047541-6-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wei Chen Xen defines some global configuration macros for Arm in config.h. However there are some address layout related definitions that are defined for MMU systems only, and these definitions could not be used by MPU systems. Adding ifdefs with CONFIG_HAS_MPU to gate these definitions will result in a messy and hard-to-read/maintain code. So move MMU related definitions to a new file, i.e. mmu/layout.h to avoid spreading "#ifdef" everywhere. Signed-off-by: Wei Chen Signed-off-by: Penny Zheng Signed-off-by: Henry Wang --- v4: - Rebase on top of latest staging to pick the recent UBSAN change to the layout. - Use #ifdef CONFIG_HAS_MMU instead of #ifndef CONFIG_HAS_MPU, add a #else case. - Rework commit message. v3: - name the new header layout.h v2: - Remove duplicated FIXMAP definitions from config_mmu.h --- xen/arch/arm/include/asm/config.h | 132 +---------------------- xen/arch/arm/include/asm/mmu/layout.h | 146 ++++++++++++++++++++++++++ 2 files changed, 149 insertions(+), 129 deletions(-) create mode 100644 xen/arch/arm/include/asm/mmu/layout.h diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 83cbf6b0cb..a3cde7f2d7 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -71,136 +71,10 @@ #include #include -/* - * ARM32 layout: - * 0 - 2M Unmapped - * 2M - 10M Xen text, data, bss - * 10M - 12M Fixmap: special-purpose 4K mapping slots - * 12M - 16M Early boot mapping of FDT - * 16M - 18M Livepatch vmap (if compiled in) - * - * 32M - 128M Frametable: 32 bytes per page for 12GB of RAM - * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address - * space - * - * 1G - 2G Xenheap: always-mapped memory - * 2G - 4G Domheap: on-demand-mapped - * - * ARM64 layout: - * 0x0000000000000000 - 0x000001ffffffffff (2TB, L0 slots [0..3]) - * - * Reserved to identity map Xen - * - * 0x0000020000000000 - 0x0000027fffffffff (512GB, L0 slot [4]) - * (Relative offsets) - * 0 - 2M Unmapped - * 2M - 10M Xen text, data, bss - * 10M - 12M Fixmap: special-purpose 4K mapping slots - * 12M - 16M Early boot mapping of FDT - * 16M - 18M Livepatch vmap (if compiled in) - * - * 1G - 2G VMAP: ioremap and early_ioremap - * - * 32G - 64G Frametable: 56 bytes per page for 2TB of RAM - * - * 0x0000028000000000 - 0x00007fffffffffff (125TB, L0 slots [5..255]) - * Unused - * - * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) - * 1:1 mapping of RAM - * - * 0x0000850000000000 - 0x0000ffffffffffff (123TB, L0 slots [266..511]) - * Unused - */ - -#ifdef CONFIG_ARM_32 -#define XEN_VIRT_START _AT(vaddr_t, MB(2)) +#ifdef CONFIG_HAS_MMU +#include #else - -#define SLOT0_ENTRY_BITS 39 -#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) -#define SLOT0_ENTRY_SIZE SLOT0(1) - -#define XEN_VIRT_START (SLOT0(4) + _AT(vaddr_t, MB(2))) -#endif - -/* - * Reserve enough space so both UBSAN and GCOV can be enabled together - * plus some slack for future growth. - */ -#define XEN_VIRT_SIZE _AT(vaddr_t, MB(8)) -#define XEN_NR_ENTRIES(lvl) (XEN_VIRT_SIZE / XEN_PT_LEVEL_SIZE(lvl)) - -#define FIXMAP_VIRT_START (XEN_VIRT_START + XEN_VIRT_SIZE) -#define FIXMAP_VIRT_SIZE _AT(vaddr_t, MB(2)) - -#define FIXMAP_ADDR(n) (FIXMAP_VIRT_START + (n) * PAGE_SIZE) - -#define BOOT_FDT_VIRT_START (FIXMAP_VIRT_START + FIXMAP_VIRT_SIZE) -#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) - -#ifdef CONFIG_LIVEPATCH -#define LIVEPATCH_VMAP_START (BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE) -#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) -#endif - -#define HYPERVISOR_VIRT_START XEN_VIRT_START - -#ifdef CONFIG_ARM_32 - -#define CONFIG_SEPARATE_XENHEAP 1 - -#define FRAMETABLE_VIRT_START _AT(vaddr_t, MB(32)) -#define FRAMETABLE_SIZE MB(128-32) -#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) - -#define VMAP_VIRT_START _AT(vaddr_t, MB(256)) -#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) - -#define XENHEAP_VIRT_START _AT(vaddr_t, GB(1)) -#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) - -#define DOMHEAP_VIRT_START _AT(vaddr_t, GB(2)) -#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) - -#define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ - -/* Number of domheap pagetable pages required at the second level (2MB mappings) */ -#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) - -/* - * The temporary area is overlapping with the domheap area. This may - * be used to create an alias of the first slot containing Xen mappings - * when turning on/off the MMU. - */ -#define TEMPORARY_AREA_FIRST_SLOT (first_table_offset(DOMHEAP_VIRT_START)) - -/* Calculate the address in the temporary area */ -#define TEMPORARY_AREA_ADDR(addr) \ - (((addr) & ~XEN_PT_LEVEL_MASK(1)) | \ - (TEMPORARY_AREA_FIRST_SLOT << XEN_PT_LEVEL_SHIFT(1))) - -#define TEMPORARY_XEN_VIRT_START TEMPORARY_AREA_ADDR(XEN_VIRT_START) - -#else /* ARM_64 */ - -#define IDENTITY_MAPPING_AREA_NR_L0 4 - -#define VMAP_VIRT_START (SLOT0(4) + GB(1)) -#define VMAP_VIRT_SIZE GB(1) - -#define FRAMETABLE_VIRT_START (SLOT0(4) + GB(32)) -#define FRAMETABLE_SIZE GB(32) -#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) - -#define DIRECTMAP_VIRT_START SLOT0(256) -#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (266 - 256)) -#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) - -#define XENHEAP_VIRT_START directmap_virt_start - -#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END - +# error "Unknown memory management layout" #endif #define NR_hypercalls 64 diff --git a/xen/arch/arm/include/asm/mmu/layout.h b/xen/arch/arm/include/asm/mmu/layout.h new file mode 100644 index 0000000000..da6be276ac --- /dev/null +++ b/xen/arch/arm/include/asm/mmu/layout.h @@ -0,0 +1,146 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __ARM_MMU_LAYOUT_H__ +#define __ARM_MMU_LAYOUT_H__ + +/* + * ARM32 layout: + * 0 - 2M Unmapped + * 2M - 10M Xen text, data, bss + * 10M - 12M Fixmap: special-purpose 4K mapping slots + * 12M - 16M Early boot mapping of FDT + * 16M - 18M Livepatch vmap (if compiled in) + * + * 32M - 128M Frametable: 32 bytes per page for 12GB of RAM + * 256M - 1G VMAP: ioremap and early_ioremap use this virtual address + * space + * + * 1G - 2G Xenheap: always-mapped memory + * 2G - 4G Domheap: on-demand-mapped + * + * ARM64 layout: + * 0x0000000000000000 - 0x000001ffffffffff (2TB, L0 slots [0..3]) + * + * Reserved to identity map Xen + * + * 0x0000020000000000 - 0x0000027fffffffff (512GB, L0 slot [4]) + * (Relative offsets) + * 0 - 2M Unmapped + * 2M - 10M Xen text, data, bss + * 10M - 12M Fixmap: special-purpose 4K mapping slots + * 12M - 16M Early boot mapping of FDT + * 16M - 18M Livepatch vmap (if compiled in) + * + * 1G - 2G VMAP: ioremap and early_ioremap + * + * 32G - 64G Frametable: 56 bytes per page for 2TB of RAM + * + * 0x0000028000000000 - 0x00007fffffffffff (125TB, L0 slots [5..255]) + * Unused + * + * 0x0000800000000000 - 0x000084ffffffffff (5TB, L0 slots [256..265]) + * 1:1 mapping of RAM + * + * 0x0000850000000000 - 0x0000ffffffffffff (123TB, L0 slots [266..511]) + * Unused + */ + +#ifdef CONFIG_ARM_32 +#define XEN_VIRT_START _AT(vaddr_t, MB(2)) +#else + +#define SLOT0_ENTRY_BITS 39 +#define SLOT0(slot) (_AT(vaddr_t,slot) << SLOT0_ENTRY_BITS) +#define SLOT0_ENTRY_SIZE SLOT0(1) + +#define XEN_VIRT_START (SLOT0(4) + _AT(vaddr_t, MB(2))) +#endif + +/* + * Reserve enough space so both UBSAN and GCOV can be enabled together + * plus some slack for future growth. + */ +#define XEN_VIRT_SIZE _AT(vaddr_t, MB(8)) +#define XEN_NR_ENTRIES(lvl) (XEN_VIRT_SIZE / XEN_PT_LEVEL_SIZE(lvl)) + +#define FIXMAP_VIRT_START (XEN_VIRT_START + XEN_VIRT_SIZE) +#define FIXMAP_VIRT_SIZE _AT(vaddr_t, MB(2)) + +#define FIXMAP_ADDR(n) (FIXMAP_VIRT_START + (n) * PAGE_SIZE) + +#define BOOT_FDT_VIRT_START (FIXMAP_VIRT_START + FIXMAP_VIRT_SIZE) +#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) + +#ifdef CONFIG_LIVEPATCH +#define LIVEPATCH_VMAP_START (BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE) +#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) +#endif + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + +#ifdef CONFIG_ARM_32 + +#define CONFIG_SEPARATE_XENHEAP 1 + +#define FRAMETABLE_VIRT_START _AT(vaddr_t, MB(32)) +#define FRAMETABLE_SIZE MB(128-32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) + +#define VMAP_VIRT_START _AT(vaddr_t, MB(256)) +#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) + +#define XENHEAP_VIRT_START _AT(vaddr_t, GB(1)) +#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) + +#define DOMHEAP_VIRT_START _AT(vaddr_t, GB(2)) +#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) + +#define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ + +/* Number of domheap pagetable pages required at the second level (2MB mappings) */ +#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) + +/* + * The temporary area is overlapping with the domheap area. This may + * be used to create an alias of the first slot containing Xen mappings + * when turning on/off the MMU. + */ +#define TEMPORARY_AREA_FIRST_SLOT (first_table_offset(DOMHEAP_VIRT_START)) + +/* Calculate the address in the temporary area */ +#define TEMPORARY_AREA_ADDR(addr) \ + (((addr) & ~XEN_PT_LEVEL_MASK(1)) | \ + (TEMPORARY_AREA_FIRST_SLOT << XEN_PT_LEVEL_SHIFT(1))) + +#define TEMPORARY_XEN_VIRT_START TEMPORARY_AREA_ADDR(XEN_VIRT_START) + +#else /* ARM_64 */ + +#define IDENTITY_MAPPING_AREA_NR_L0 4 + +#define VMAP_VIRT_START (SLOT0(4) + GB(1)) +#define VMAP_VIRT_SIZE GB(1) + +#define FRAMETABLE_VIRT_START (SLOT0(4) + GB(32)) +#define FRAMETABLE_SIZE GB(32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) + +#define DIRECTMAP_VIRT_START SLOT0(256) +#define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (266 - 256)) +#define DIRECTMAP_VIRT_END (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1) + +#define XENHEAP_VIRT_START directmap_virt_start + +#define HYPERVISOR_VIRT_END DIRECTMAP_VIRT_END + +#endif + +#endif /* __ARM_MMU_LAYOUT_H__ */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:45:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:45:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573561.898412 (Exim 4.92) (envelope-from ) id 1qQgJg-0000bq-3Q; Tue, 01 Aug 2023 03:45:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573561.898412; Tue, 01 Aug 2023 03:45:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJf-0000bh-Vv; Tue, 01 Aug 2023 03:44:59 +0000 Received: by outflank-mailman (input) for mailman id 573561; Tue, 01 Aug 2023 03:44:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJe-00076X-OA for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:44:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c82cf606-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:44:56 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7067CD75; Mon, 31 Jul 2023 20:45:39 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 21DF23F59C; Mon, 31 Jul 2023 20:44:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c82cf606-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk Subject: [PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables() Date: Tue, 1 Aug 2023 11:44:12 +0800 Message-Id: <20230801034419.2047541-7-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The original assembly setup_fixmap() is actually doing two seperate tasks, one is enabling the early UART when earlyprintk on, and the other is to set up the fixmap (even when earlyprintk is off). Per discussion in [1], since commit 9d267c049d92 ("xen/arm64: Rework the memory layout"), there is no chance that the fixmap and the mapping of early UART will clash with the 1:1 mapping. Therefore the mapping of both the fixmap and the early UART can be moved to the end of create_pagetables(). For the future MPU support work, the early UART mapping could then be moved in prepare_early_mappings(). No functional change intended. [1] https://lore.kernel.org/xen-devel/78862bb8-fd7f-5a51-a7ae-3c5b5998ed80@xen.org/ Signed-off-by: Henry Wang --- v4: - Rework "[v3,12/52] xen/mmu: extract early uart mapping from setup_fixmap" --- xen/arch/arm/arm64/head.S | 1 - xen/arch/arm/arm64/mmu/head.S | 50 ++++++++++++----------------------- 2 files changed, 17 insertions(+), 34 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index e4f579a48e..56f68a8e37 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -275,7 +275,6 @@ real_start_efi: b enable_boot_cpu_mm primary_switched: - bl setup_fixmap #ifdef CONFIG_EARLY_PRINTK /* Use a virtual address to access the UART. */ ldr x23, =EARLY_UART_VIRTUAL_ADDRESS diff --git a/xen/arch/arm/arm64/mmu/head.S b/xen/arch/arm/arm64/mmu/head.S index b7c3dd423a..6bd94c3a45 100644 --- a/xen/arch/arm/arm64/mmu/head.S +++ b/xen/arch/arm/arm64/mmu/head.S @@ -231,6 +231,23 @@ link_from_second_id: create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 link_from_third_id: create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 + +#ifdef CONFIG_EARLY_PRINTK + /* Add UART to the fixmap table */ + ldr x0, =EARLY_UART_VIRTUAL_ADDRESS + /* x23: Early UART base physical address */ + create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 +#endif + /* Map fixmap into boot_second */ + ldr x0, =FIXMAP_ADDR(0) + create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 + /* Ensure any page table updates made above have occurred. */ + dsb nshst + /* + * The fixmap area will be used soon after. So ensure no hardware + * translation happens before the dsb completes. + */ + isb ret virtphys_clash: @@ -395,39 +412,6 @@ identity_mapping_removed: ret ENDPROC(remove_identity_mapping) -/* - * Map the UART in the fixmap (when earlyprintk is used) and hook the - * fixmap table in the page tables. - * - * The fixmap cannot be mapped in create_page_tables because it may - * clash with the 1:1 mapping. - * - * Inputs: - * x20: Physical offset - * x23: Early UART base physical address - * - * Clobbers x0 - x3 - */ -ENTRY(setup_fixmap) -#ifdef CONFIG_EARLY_PRINTK - /* Add UART to the fixmap table */ - ldr x0, =EARLY_UART_VIRTUAL_ADDRESS - create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 -#endif - /* Map fixmap into boot_second */ - ldr x0, =FIXMAP_ADDR(0) - create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 - /* Ensure any page table updates made above have occurred. */ - dsb nshst - /* - * The fixmap area will be used soon after. So ensure no hardware - * translation happens before the dsb completes. - */ - isb - - ret -ENDPROC(setup_fixmap) - /* Fail-stop */ fail: PRINT("- Boot failed -\r\n") 1: wfe -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:45:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:45:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573567.898422 (Exim 4.92) (envelope-from ) id 1qQgJm-0001Cw-ER; Tue, 01 Aug 2023 03:45:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573567.898422; Tue, 01 Aug 2023 03:45:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJm-0001Ch-AB; Tue, 01 Aug 2023 03:45:06 +0000 Received: by outflank-mailman (input) for mailman id 573567; Tue, 01 Aug 2023 03:45:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJl-00076X-IM for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:05 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id cb217fd5-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:45:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F2ECD75; Mon, 31 Jul 2023 20:45:44 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3A0BD3F59C; Mon, 31 Jul 2023 20:44:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb217fd5-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Henry Wang , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk Subject: [PATCH v4 07/13] xen/arm: Extract MMU-specific code Date: Tue, 1 Aug 2023 11:44:13 +0800 Message-Id: <20230801034419.2047541-8-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, most of the MMU-specific code is in mm.{c,h}. To make the mm extendable, this commit extract the MMU-specific code by firstly: - Create a arch/arm/include/asm/mmu/ subdir. - Create a arch/arm/mmu/ subdir. Then move the MMU-specific code to above mmu subdir, which includes below changes: - Move arch/arm/arm64/mm.c to arch/arm/arm64/mmu/mm.c - Move MMU-related declaration in arch/arm/include/asm/mm.h to arch/arm/include/asm/mmu/mm.h - Move the MMU-related declaration dump_pt_walk() in asm/page.h and pte_of_xenaddr() in asm/setup.h to the new asm/mmu/mm.h. - Move MMU-related code in arch/arm/mm.c to arch/arm/mmu/mm.c. Also modify the build system (Makefiles in this case) to pick above mentioned code changes. This patch is a pure code movement, no functional change intended. Signed-off-by: Henry Wang --- With the code movement of this patch, the descriptions on top of xen/arch/arm/mm.c and xen/arch/arm/mmu/mm.c might need some changes, suggestions? v4: - Rework "[v3,13/52] xen/mmu: extract mmu-specific codes from mm.c/mm.h" with the lastest staging branch, only do the code movement in this patch to ease the review. --- xen/arch/arm/Makefile | 1 + xen/arch/arm/arm64/Makefile | 1 - xen/arch/arm/arm64/mmu/Makefile | 1 + xen/arch/arm/arm64/{ => mmu}/mm.c | 0 xen/arch/arm/include/asm/mm.h | 20 +- xen/arch/arm/include/asm/mmu/mm.h | 55 ++ xen/arch/arm/include/asm/page.h | 15 - xen/arch/arm/include/asm/setup.h | 3 - xen/arch/arm/mm.c | 1119 ---------------------------- xen/arch/arm/mmu/Makefile | 1 + xen/arch/arm/mmu/mm.c | 1146 +++++++++++++++++++++++++++++ 11 files changed, 1208 insertions(+), 1154 deletions(-) rename xen/arch/arm/arm64/{ => mmu}/mm.c (100%) create mode 100644 xen/arch/arm/include/asm/mmu/mm.h create mode 100644 xen/arch/arm/mmu/Makefile create mode 100644 xen/arch/arm/mmu/mm.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 7bf07e9920..9801b9dfd0 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -1,6 +1,7 @@ obj-$(CONFIG_ARM_32) += arm32/ obj-$(CONFIG_ARM_64) += arm64/ obj-$(CONFIG_ACPI) += acpi/ +obj-$(CONFIG_HAS_MMU) += mmu/ obj-$(CONFIG_HAS_PCI) += pci/ ifneq ($(CONFIG_NO_PLAT),y) obj-y += platforms/ diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile index ce8749f046..731d00cc8a 100644 --- a/xen/arch/arm/arm64/Makefile +++ b/xen/arch/arm/arm64/Makefile @@ -11,7 +11,6 @@ obj-y += entry.o obj-y += head.o obj-y += insn.o obj-$(CONFIG_LIVEPATCH) += livepatch.o -obj-y += mm.o obj-y += smc.o obj-y += smpboot.o obj-$(CONFIG_ARM64_SVE) += sve.o sve-asm.o diff --git a/xen/arch/arm/arm64/mmu/Makefile b/xen/arch/arm/arm64/mmu/Makefile index 3340058c08..a8a750a3d0 100644 --- a/xen/arch/arm/arm64/mmu/Makefile +++ b/xen/arch/arm/arm64/mmu/Makefile @@ -1 +1,2 @@ obj-y += head.o +obj-y += mm.o diff --git a/xen/arch/arm/arm64/mm.c b/xen/arch/arm/arm64/mmu/mm.c similarity index 100% rename from xen/arch/arm/arm64/mm.c rename to xen/arch/arm/arm64/mmu/mm.c diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 4262165ce2..e70ce4dc61 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -14,6 +14,10 @@ # error "unknown ARM variant" #endif +#ifdef CONFIG_HAS_MMU +#include +#endif + /* Align Xen to a 2 MiB boundary. */ #define XEN_PADDR_ALIGN (1 << 21) @@ -165,13 +169,6 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated -extern mfn_t directmap_mfn_start, directmap_mfn_end; -extern vaddr_t directmap_virt_end; -#ifdef CONFIG_ARM_64 -extern vaddr_t directmap_virt_start; -extern unsigned long directmap_base_pdx; -#endif - #ifdef CONFIG_ARM_32 #define is_xen_heap_page(page) is_xen_heap_mfn(page_to_mfn(page)) #define is_xen_heap_mfn(mfn) ({ \ @@ -194,7 +191,6 @@ extern unsigned long directmap_base_pdx; #define maddr_get_owner(ma) (page_get_owner(maddr_to_page((ma)))) -#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) /* PDX of the first page in the frame table. */ extern unsigned long frametable_base_pdx; @@ -207,8 +203,6 @@ extern unsigned long total_pages; extern void setup_pagetables(unsigned long boot_phys_offset); /* Map FDT in boot pagetable */ extern void *early_fdt_map(paddr_t fdt_paddr); -/* Switch to a new root page-tables */ -extern void switch_ttbr(uint64_t ttbr); /* Remove early mappings */ extern void remove_early_mappings(void); /* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the @@ -216,12 +210,6 @@ extern void remove_early_mappings(void); extern int init_secondary_pagetables(int cpu); /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ extern void mmu_init_secondary_cpu(void); -/* - * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, - * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. - * For Arm64, map the region in the directmap area. - */ -extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ diff --git a/xen/arch/arm/include/asm/mmu/mm.h b/xen/arch/arm/include/asm/mmu/mm.h new file mode 100644 index 0000000000..3d9755b7b4 --- /dev/null +++ b/xen/arch/arm/include/asm/mmu/mm.h @@ -0,0 +1,55 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef __ARM_MMU_MM_H__ +#define __ARM_MMU_MM_H__ + +extern mfn_t directmap_mfn_start, directmap_mfn_end; +extern vaddr_t directmap_virt_end; +#ifdef CONFIG_ARM_64 +extern vaddr_t directmap_virt_start; +extern unsigned long directmap_base_pdx; +#endif + +#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) + +/* + * Print a walk of a page table or p2m + * + * ttbr is the base address register (TTBR0_EL2 or VTTBR_EL2) + * addr is the PA or IPA to translate + * root_level is the starting level of the page table + * (e.g. TCR_EL2.SL0 or VTCR_EL2.SL0 ) + * nr_root_tables is the number of concatenated tables at the root. + * this can only be != 1 for P2M walks starting at the first or + * subsequent level. + */ +void dump_pt_walk(paddr_t ttbr, paddr_t addr, + unsigned int root_level, + unsigned int nr_root_tables); + +/* Find where Xen will be residing at runtime and return a PT entry */ +lpae_t pte_of_xenaddr(vaddr_t); + +/* Switch to a new root page-tables */ +extern void switch_ttbr(uint64_t ttbr); +/* + * For Arm32, set up the direct-mapped xenheap: up to 1GB of contiguous, + * always-mapped memory. Base must be 32MB aligned and size a multiple of 32MB. + * For Arm64, map the region in the directmap area. + */ +extern void setup_directmap_mappings(unsigned long base_mfn, unsigned long nr_mfns); +extern int xen_pt_update(unsigned long virt, + mfn_t mfn, + /* const on purpose as it is used for TLB flush */ + const unsigned long nr_mfns, + unsigned int flags); + +#endif /* __ARM_MMU_MM_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/page.h b/xen/arch/arm/include/asm/page.h index ea96983ab9..247c170ac8 100644 --- a/xen/arch/arm/include/asm/page.h +++ b/xen/arch/arm/include/asm/page.h @@ -257,21 +257,6 @@ static inline void write_pte(lpae_t *p, lpae_t pte) /* Flush the dcache for an entire page. */ void flush_page_to_ram(unsigned long mfn, bool sync_icache); -/* - * Print a walk of a page table or p2m - * - * ttbr is the base address register (TTBR0_EL2 or VTTBR_EL2) - * addr is the PA or IPA to translate - * root_level is the starting level of the page table - * (e.g. TCR_EL2.SL0 or VTCR_EL2.SL0 ) - * nr_root_tables is the number of concatenated tables at the root. - * this can only be != 1 for P2M walks starting at the first or - * subsequent level. - */ -void dump_pt_walk(paddr_t ttbr, paddr_t addr, - unsigned int root_level, - unsigned int nr_root_tables); - /* Print a walk of the hypervisor's page tables for a virtual addr. */ extern void dump_hyp_walk(vaddr_t addr); /* Print a walk of the p2m for a domain for a physical address. */ diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 19dc637d55..f0f64d228c 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -176,9 +176,6 @@ extern lpae_t boot_first_id[XEN_PT_LPAE_ENTRIES]; extern lpae_t boot_second_id[XEN_PT_LPAE_ENTRIES]; extern lpae_t boot_third_id[XEN_PT_LPAE_ENTRIES]; -/* Find where Xen will be residing at runtime and return a PT entry */ -lpae_t pte_of_xenaddr(vaddr_t); - extern const char __ro_after_init_start[], __ro_after_init_end[]; struct init_info diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index c688227abd..5d7c144995 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -15,16 +15,12 @@ #include #include #include -#include -#include -#include #include #include #include #include -#include #include #include @@ -32,104 +28,6 @@ /* Override macros from asm/page.h to make them work with mfn_t */ #undef virt_to_mfn #define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) -#undef mfn_to_virt -#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) - -#ifdef NDEBUG -static inline void -__attribute__ ((__format__ (__printf__, 1, 2))) -mm_printk(const char *fmt, ...) {} -#else -#define mm_printk(fmt, args...) \ - do \ - { \ - dprintk(XENLOG_ERR, fmt, ## args); \ - WARN(); \ - } while (0) -#endif - -/* Static start-of-day pagetables that we use before the allocators - * are up. These are used by all CPUs during bringup before switching - * to the CPUs own pagetables. - * - * These pagetables have a very simple structure. They include: - * - XEN_VIRT_SIZE worth of L3 mappings of xen at XEN_VIRT_START, boot_first - * and boot_second are used to populate the tables down to boot_third - * which contains the actual mapping. - * - a 1:1 mapping of xen at its current physical address. This uses a - * section mapping at whichever of boot_{pgtable,first,second} - * covers that physical address. - * - * For the boot CPU these mappings point to the address where Xen was - * loaded by the bootloader. For secondary CPUs they point to the - * relocated copy of Xen for the benefit of secondary CPUs. - * - * In addition to the above for the boot CPU the device-tree is - * initially mapped in the boot misc slot. This mapping is not present - * for secondary CPUs. - * - * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped - * by the CPU once it has moved off the 1:1 mapping. - */ -DEFINE_BOOT_PAGE_TABLE(boot_pgtable); -#ifdef CONFIG_ARM_64 -DEFINE_BOOT_PAGE_TABLE(boot_first); -DEFINE_BOOT_PAGE_TABLE(boot_first_id); -#endif -DEFINE_BOOT_PAGE_TABLE(boot_second_id); -DEFINE_BOOT_PAGE_TABLE(boot_third_id); -DEFINE_BOOT_PAGE_TABLE(boot_second); -DEFINE_BOOT_PAGE_TABLES(boot_third, XEN_NR_ENTRIES(2)); - -/* Main runtime page tables */ - -/* - * For arm32 xen_pgtable are per-PCPU and are allocated before - * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. - * - * xen_second, xen_fixmap and xen_xenmap are always shared between all - * PCPUs. - */ - -#ifdef CONFIG_ARM_64 -#define HYP_PT_ROOT_LEVEL 0 -DEFINE_PAGE_TABLE(xen_pgtable); -static DEFINE_PAGE_TABLE(xen_first); -#define THIS_CPU_PGTABLE xen_pgtable -#else -#define HYP_PT_ROOT_LEVEL 1 -/* Per-CPU pagetable pages */ -/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ -DEFINE_PER_CPU(lpae_t *, xen_pgtable); -#define THIS_CPU_PGTABLE this_cpu(xen_pgtable) -/* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ -static DEFINE_PAGE_TABLE(cpu0_pgtable); -#endif - -/* Common pagetable leaves */ -/* Second level page table used to cover Xen virtual address space */ -static DEFINE_PAGE_TABLE(xen_second); -/* Third level page table used for fixmap */ -DEFINE_BOOT_PAGE_TABLE(xen_fixmap); -/* - * Third level page table used to map Xen itself with the XN bit set - * as appropriate. - */ -static DEFINE_PAGE_TABLES(xen_xenmap, XEN_NR_ENTRIES(2)); - -/* Non-boot CPUs use this to find the correct pagetables. */ -uint64_t init_ttbr; - -static paddr_t phys_offset; - -/* Limits of the Xen heap */ -mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; -mfn_t directmap_mfn_end __read_mostly; -vaddr_t directmap_virt_end __read_mostly; -#ifdef CONFIG_ARM_64 -vaddr_t directmap_virt_start __read_mostly; -unsigned long directmap_base_pdx __read_mostly; -#endif unsigned long frametable_base_pdx __read_mostly; unsigned long frametable_virt_end __read_mostly; @@ -139,243 +37,6 @@ unsigned long total_pages; extern char __init_begin[], __init_end[]; -/* Checking VA memory layout alignment. */ -static void __init __maybe_unused build_assertions(void) -{ - /* 2MB aligned regions */ - BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK); - BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK); - /* 1GB aligned regions */ -#ifdef CONFIG_ARM_32 - BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK); -#else - BUILD_BUG_ON(DIRECTMAP_VIRT_START & ~FIRST_MASK); -#endif - /* Page table structure constraints */ -#ifdef CONFIG_ARM_64 - /* - * The first few slots of the L0 table is reserved for the identity - * mapping. Check that none of the other regions are overlapping - * with it. - */ -#define CHECK_OVERLAP_WITH_IDMAP(virt) \ - BUILD_BUG_ON(zeroeth_table_offset(virt) < IDENTITY_MAPPING_AREA_NR_L0) - - CHECK_OVERLAP_WITH_IDMAP(XEN_VIRT_START); - CHECK_OVERLAP_WITH_IDMAP(VMAP_VIRT_START); - CHECK_OVERLAP_WITH_IDMAP(FRAMETABLE_VIRT_START); - CHECK_OVERLAP_WITH_IDMAP(DIRECTMAP_VIRT_START); -#undef CHECK_OVERLAP_WITH_IDMAP -#endif - BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); -#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE - BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK); -#endif - /* - * The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0), - * BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st - * slot in the page tables. - */ -#define CHECK_SAME_SLOT(level, virt1, virt2) \ - BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2)) - -#define CHECK_DIFFERENT_SLOT(level, virt1, virt2) \ - BUILD_BUG_ON(level##_table_offset(virt1) == level##_table_offset(virt2)) - -#ifdef CONFIG_ARM_64 - CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0)); - CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START); -#endif - CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0)); - CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START); - - /* - * For arm32, the temporary mapping will re-use the domheap - * first slot and the second slots will match. - */ -#ifdef CONFIG_ARM_32 - CHECK_SAME_SLOT(first, TEMPORARY_XEN_VIRT_START, DOMHEAP_VIRT_START); - CHECK_DIFFERENT_SLOT(first, XEN_VIRT_START, TEMPORARY_XEN_VIRT_START); - CHECK_SAME_SLOT(second, XEN_VIRT_START, TEMPORARY_XEN_VIRT_START); -#endif - -#undef CHECK_SAME_SLOT -#undef CHECK_DIFFERENT_SLOT -} - -static lpae_t *xen_map_table(mfn_t mfn) -{ - /* - * During early boot, map_domain_page() may be unusable. Use the - * PMAP to map temporarily a page-table. - */ - if ( system_state == SYS_STATE_early_boot ) - return pmap_map(mfn); - - return map_domain_page(mfn); -} - -static void xen_unmap_table(const lpae_t *table) -{ - /* - * During early boot, xen_map_table() will not use map_domain_page() - * but the PMAP. - */ - if ( system_state == SYS_STATE_early_boot ) - pmap_unmap(table); - else - unmap_domain_page(table); -} - -void dump_pt_walk(paddr_t ttbr, paddr_t addr, - unsigned int root_level, - unsigned int nr_root_tables) -{ - static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; - const mfn_t root_mfn = maddr_to_mfn(ttbr); - DECLARE_OFFSETS(offsets, addr); - lpae_t pte, *mapping; - unsigned int level, root_table; - -#ifdef CONFIG_ARM_32 - BUG_ON(root_level < 1); -#endif - BUG_ON(root_level > 3); - - if ( nr_root_tables > 1 ) - { - /* - * Concatenated root-level tables. The table number will be - * the offset at the previous level. It is not possible to - * concatenate a level-0 root. - */ - BUG_ON(root_level == 0); - root_table = offsets[root_level - 1]; - printk("Using concatenated root table %u\n", root_table); - if ( root_table >= nr_root_tables ) - { - printk("Invalid root table offset\n"); - return; - } - } - else - root_table = 0; - - mapping = xen_map_table(mfn_add(root_mfn, root_table)); - - for ( level = root_level; ; level++ ) - { - if ( offsets[level] > XEN_PT_LPAE_ENTRIES ) - break; - - pte = mapping[offsets[level]]; - - printk("%s[0x%03x] = 0x%"PRIx64"\n", - level_strs[level], offsets[level], pte.bits); - - if ( level == 3 || !pte.walk.valid || !pte.walk.table ) - break; - - /* For next iteration */ - xen_unmap_table(mapping); - mapping = xen_map_table(lpae_get_mfn(pte)); - } - - xen_unmap_table(mapping); -} - -void dump_hyp_walk(vaddr_t addr) -{ - uint64_t ttbr = READ_SYSREG64(TTBR0_EL2); - - printk("Walking Hypervisor VA 0x%"PRIvaddr" " - "on CPU%d via TTBR 0x%016"PRIx64"\n", - addr, smp_processor_id(), ttbr); - - dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); -} - -lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) -{ - lpae_t e = (lpae_t) { - .pt = { - .valid = 1, /* Mappings are present */ - .table = 0, /* Set to 1 for links and 4k maps */ - .ai = attr, - .ns = 1, /* Hyp mode is in the non-secure world */ - .up = 1, /* See below */ - .ro = 0, /* Assume read-write */ - .af = 1, /* No need for access tracking */ - .ng = 1, /* Makes TLB flushes easier */ - .contig = 0, /* Assume non-contiguous */ - .xn = 1, /* No need to execute outside .text */ - .avail = 0, /* Reference count for domheap mapping */ - }}; - /* - * For EL2 stage-1 page table, up (aka AP[1]) is RES1 as the translation - * regime applies to only one exception level (see D4.4.4 and G4.6.1 - * in ARM DDI 0487B.a). If this changes, remember to update the - * hard-coded values in head.S too. - */ - - switch ( attr ) - { - case MT_NORMAL_NC: - /* - * ARM ARM: Overlaying the shareability attribute (DDI - * 0406C.b B3-1376 to 1377) - * - * A memory region with a resultant memory type attribute of Normal, - * and a resultant cacheability attribute of Inner Non-cacheable, - * Outer Non-cacheable, must have a resultant shareability attribute - * of Outer Shareable, otherwise shareability is UNPREDICTABLE. - * - * On ARMv8 sharability is ignored and explicitly treated as Outer - * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. - */ - e.pt.sh = LPAE_SH_OUTER; - break; - case MT_DEVICE_nGnRnE: - case MT_DEVICE_nGnRE: - /* - * Shareability is ignored for non-Normal memory, Outer is as - * good as anything. - * - * On ARMv8 sharability is ignored and explicitly treated as Outer - * Shareable for any device memory type. - */ - e.pt.sh = LPAE_SH_OUTER; - break; - default: - e.pt.sh = LPAE_SH_INNER; /* Xen mappings are SMP coherent */ - break; - } - - ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); - - lpae_set_mfn(e, mfn); - - return e; -} - -/* Map a 4k page in a fixmap entry */ -void set_fixmap(unsigned int map, mfn_t mfn, unsigned int flags) -{ - int res; - - res = map_pages_to_xen(FIXMAP_ADDR(map), mfn, 1, flags); - BUG_ON(res != 0); -} - -/* Remove a mapping from a fixmap entry */ -void clear_fixmap(unsigned int map) -{ - int res; - - res = destroy_xen_mappings(FIXMAP_ADDR(map), FIXMAP_ADDR(map) + PAGE_SIZE); - BUG_ON(res != 0); -} - void flush_page_to_ram(unsigned long mfn, bool sync_icache) { void *v = map_domain_page(_mfn(mfn)); @@ -395,13 +56,6 @@ void flush_page_to_ram(unsigned long mfn, bool sync_icache) invalidate_icache(); } -lpae_t pte_of_xenaddr(vaddr_t va) -{ - paddr_t ma = va + phys_offset; - - return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); -} - void * __init early_fdt_map(paddr_t fdt_paddr) { /* We are using 2MB superpage for mapping the FDT */ @@ -455,779 +109,11 @@ void * __init early_fdt_map(paddr_t fdt_paddr) return fdt_virt; } -void __init remove_early_mappings(void) -{ - int rc; - - /* destroy the _PAGE_BLOCK mapping */ - rc = modify_xen_mappings(BOOT_FDT_VIRT_START, - BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, - _PAGE_BLOCK); - BUG_ON(rc); -} - -/* - * After boot, Xen page-tables should not contain mapping that are both - * Writable and eXecutables. - * - * This should be called on each CPU to enforce the policy. - */ -static void xen_pt_enforce_wnx(void) -{ - WRITE_SYSREG(READ_SYSREG(SCTLR_EL2) | SCTLR_Axx_ELx_WXN, SCTLR_EL2); - /* - * The TLBs may cache SCTLR_EL2.WXN. So ensure it is synchronized - * before flushing the TLBs. - */ - isb(); - flush_xen_tlb_local(); -} - -/* Clear a translation table and clean & invalidate the cache */ -static void clear_table(void *table) -{ - clear_page(table); - clean_and_invalidate_dcache_va_range(table, PAGE_SIZE); -} - -/* Boot-time pagetable setup. - * Changes here may need matching changes in head.S */ -void __init setup_pagetables(unsigned long boot_phys_offset) -{ - uint64_t ttbr; - lpae_t pte, *p; - int i; - - phys_offset = boot_phys_offset; - - arch_setup_page_tables(); - -#ifdef CONFIG_ARM_64 - pte = pte_of_xenaddr((uintptr_t)xen_first); - pte.pt.table = 1; - pte.pt.xn = 0; - xen_pgtable[zeroeth_table_offset(XEN_VIRT_START)] = pte; - - p = (void *) xen_first; -#else - p = (void *) cpu0_pgtable; -#endif - - /* Map xen second level page-table */ - p[0] = pte_of_xenaddr((uintptr_t)(xen_second)); - p[0].pt.table = 1; - p[0].pt.xn = 0; - - /* Break up the Xen mapping into pages and protect them separately. */ - for ( i = 0; i < XEN_NR_ENTRIES(3); i++ ) - { - vaddr_t va = XEN_VIRT_START + (i << PAGE_SHIFT); - - if ( !is_kernel(va) ) - break; - pte = pte_of_xenaddr(va); - pte.pt.table = 1; /* third level mappings always have this bit set */ - if ( is_kernel_text(va) || is_kernel_inittext(va) ) - { - pte.pt.xn = 0; - pte.pt.ro = 1; - } - if ( is_kernel_rodata(va) ) - pte.pt.ro = 1; - xen_xenmap[i] = pte; - } - - /* Initialise xen second level entries ... */ - /* ... Xen's text etc */ - for ( i = 0; i < XEN_NR_ENTRIES(2); i++ ) - { - vaddr_t va = XEN_VIRT_START + (i << XEN_PT_LEVEL_SHIFT(2)); - - pte = pte_of_xenaddr((vaddr_t)(xen_xenmap + i * XEN_PT_LPAE_ENTRIES)); - pte.pt.table = 1; - xen_second[second_table_offset(va)] = pte; - } - - /* ... Fixmap */ - pte = pte_of_xenaddr((vaddr_t)xen_fixmap); - pte.pt.table = 1; - xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte; - -#ifdef CONFIG_ARM_64 - ttbr = (uintptr_t) xen_pgtable + phys_offset; -#else - ttbr = (uintptr_t) cpu0_pgtable + phys_offset; -#endif - - switch_ttbr(ttbr); - - xen_pt_enforce_wnx(); - -#ifdef CONFIG_ARM_32 - per_cpu(xen_pgtable, 0) = cpu0_pgtable; -#endif -} - -static void clear_boot_pagetables(void) -{ - /* - * Clear the copy of the boot pagetables. Each secondary CPU - * rebuilds these itself (see head.S). - */ - clear_table(boot_pgtable); -#ifdef CONFIG_ARM_64 - clear_table(boot_first); - clear_table(boot_first_id); -#endif - clear_table(boot_second); - clear_table(boot_third); -} - -#ifdef CONFIG_ARM_64 -int init_secondary_pagetables(int cpu) -{ - clear_boot_pagetables(); - - /* Set init_ttbr for this CPU coming up. All CPus share a single setof - * pagetables, but rewrite it each time for consistency with 32 bit. */ - init_ttbr = (uintptr_t) xen_pgtable + phys_offset; - clean_dcache(init_ttbr); - return 0; -} -#else -int init_secondary_pagetables(int cpu) -{ - lpae_t *first; - - first = alloc_xenheap_page(); /* root == first level on 32-bit 3-level trie */ - - if ( !first ) - { - printk("CPU%u: Unable to allocate the first page-table\n", cpu); - return -ENOMEM; - } - - /* Initialise root pagetable from root of boot tables */ - memcpy(first, cpu0_pgtable, PAGE_SIZE); - per_cpu(xen_pgtable, cpu) = first; - - if ( !init_domheap_mappings(cpu) ) - { - printk("CPU%u: Unable to prepare the domheap page-tables\n", cpu); - per_cpu(xen_pgtable, cpu) = NULL; - free_xenheap_page(first); - return -ENOMEM; - } - - clear_boot_pagetables(); - - /* Set init_ttbr for this CPU coming up */ - init_ttbr = __pa(first); - clean_dcache(init_ttbr); - - return 0; -} -#endif - -/* MMU setup for secondary CPUS (which already have paging enabled) */ -void mmu_init_secondary_cpu(void) -{ - xen_pt_enforce_wnx(); -} - -#ifdef CONFIG_ARM_32 -/* - * Set up the direct-mapped xenheap: - * up to 1GB of contiguous, always-mapped memory. - */ -void __init setup_directmap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) -{ - int rc; - - rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); - if ( rc ) - panic("Unable to setup the directmap mappings.\n"); - - /* Record where the directmap is, for translation routines. */ - directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; -} -#else /* CONFIG_ARM_64 */ -/* Map the region in the directmap area. */ -void __init setup_directmap_mappings(unsigned long base_mfn, - unsigned long nr_mfns) -{ - int rc; - - /* First call sets the directmap physical and virtual offset. */ - if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) - { - unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); - - directmap_mfn_start = _mfn(base_mfn); - directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); - /* - * The base address may not be aligned to the first level - * size (e.g. 1GB when using 4KB pages). This would prevent - * superpage mappings for all the regions because the virtual - * address and machine address should both be suitably aligned. - * - * Prevent that by offsetting the start of the directmap virtual - * address. - */ - directmap_virt_start = DIRECTMAP_VIRT_START + - (base_mfn - mfn_gb) * PAGE_SIZE; - } - - if ( base_mfn < mfn_x(directmap_mfn_start) ) - panic("cannot add directmap mapping at %lx below heap start %lx\n", - base_mfn, mfn_x(directmap_mfn_start)); - - rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), - _mfn(base_mfn), nr_mfns, - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); - if ( rc ) - panic("Unable to setup the directmap mappings.\n"); -} -#endif - -/* Map a frame table to cover physical addresses ps through pe */ -void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) -{ - unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - - mfn_to_pdx(maddr_to_mfn(ps)) + 1; - unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); - mfn_t base_mfn; - const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); - int rc; - - /* - * The size of paddr_t should be sufficient for the complete range of - * physical address. - */ - BUILD_BUG_ON((sizeof(paddr_t) * BITS_PER_BYTE) < PADDR_BITS); - BUILD_BUG_ON(sizeof(struct page_info) != PAGE_INFO_SIZE); - - if ( frametable_size > FRAMETABLE_SIZE ) - panic("The frametable cannot cover the physical region %#"PRIpaddr" - %#"PRIpaddr"\n", - ps, pe); - - frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); - /* Round up to 2M or 32M boundary, as appropriate. */ - frametable_size = ROUNDUP(frametable_size, mapping_size); - base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); - - rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, - frametable_size >> PAGE_SHIFT, - PAGE_HYPERVISOR_RW | _PAGE_BLOCK); - if ( rc ) - panic("Unable to setup the frametable mappings.\n"); - - memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); - memset(&frame_table[nr_pdxs], -1, - frametable_size - (nr_pdxs * sizeof(struct page_info))); - - frametable_virt_end = FRAMETABLE_VIRT_START + (nr_pdxs * sizeof(struct page_info)); -} - -void *__init arch_vmap_virt_end(void) -{ - return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); -} - -/* - * This function should only be used to remap device address ranges - * TODO: add a check to verify this assumption - */ -void *ioremap_attr(paddr_t start, size_t len, unsigned int attributes) -{ - mfn_t mfn = _mfn(PFN_DOWN(start)); - unsigned int offs = start & (PAGE_SIZE - 1); - unsigned int nr = PFN_UP(offs + len); - void *ptr = __vmap(&mfn, nr, 1, 1, attributes, VMAP_DEFAULT); - - if ( ptr == NULL ) - return NULL; - - return ptr + offs; -} - void *ioremap(paddr_t pa, size_t len) { return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); } -static int create_xen_table(lpae_t *entry) -{ - mfn_t mfn; - void *p; - lpae_t pte; - - if ( system_state != SYS_STATE_early_boot ) - { - struct page_info *pg = alloc_domheap_page(NULL, 0); - - if ( pg == NULL ) - return -ENOMEM; - - mfn = page_to_mfn(pg); - } - else - mfn = alloc_boot_pages(1, 1); - - p = xen_map_table(mfn); - clear_page(p); - xen_unmap_table(p); - - pte = mfn_to_xen_entry(mfn, MT_NORMAL); - pte.pt.table = 1; - write_pte(entry, pte); - /* - * No ISB here. It is deferred to xen_pt_update() as the new table - * will not be used for hardware translation table access as part of - * the mapping update. - */ - - return 0; -} - -#define XEN_TABLE_MAP_FAILED 0 -#define XEN_TABLE_SUPER_PAGE 1 -#define XEN_TABLE_NORMAL_PAGE 2 - -/* - * Take the currently mapped table, find the corresponding entry, - * and map the next table, if available. - * - * The read_only parameters indicates whether intermediate tables should - * be allocated when not present. - * - * Return values: - * XEN_TABLE_MAP_FAILED: Either read_only was set and the entry - * was empty, or allocating a new page failed. - * XEN_TABLE_NORMAL_PAGE: next level mapped normally - * XEN_TABLE_SUPER_PAGE: The next entry points to a superpage. - */ -static int xen_pt_next_level(bool read_only, unsigned int level, - lpae_t **table, unsigned int offset) -{ - lpae_t *entry; - int ret; - mfn_t mfn; - - entry = *table + offset; - - if ( !lpae_is_valid(*entry) ) - { - if ( read_only ) - return XEN_TABLE_MAP_FAILED; - - ret = create_xen_table(entry); - if ( ret ) - return XEN_TABLE_MAP_FAILED; - } - - /* The function xen_pt_next_level is never called at the 3rd level */ - if ( lpae_is_mapping(*entry, level) ) - return XEN_TABLE_SUPER_PAGE; - - mfn = lpae_get_mfn(*entry); - - xen_unmap_table(*table); - *table = xen_map_table(mfn); - - return XEN_TABLE_NORMAL_PAGE; -} - -/* Sanity check of the entry */ -static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, - unsigned int flags) -{ - /* Sanity check when modifying an entry. */ - if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) - { - /* We don't allow modifying an invalid entry. */ - if ( !lpae_is_valid(entry) ) - { - mm_printk("Modifying invalid entry is not allowed.\n"); - return false; - } - - /* We don't allow modifying a table entry */ - if ( !lpae_is_mapping(entry, level) ) - { - mm_printk("Modifying a table entry is not allowed.\n"); - return false; - } - - /* We don't allow changing memory attributes. */ - if ( entry.pt.ai != PAGE_AI_MASK(flags) ) - { - mm_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", - entry.pt.ai, PAGE_AI_MASK(flags)); - return false; - } - - /* We don't allow modifying entry with contiguous bit set. */ - if ( entry.pt.contig ) - { - mm_printk("Modifying entry with contiguous bit set is not allowed.\n"); - return false; - } - } - /* Sanity check when inserting a mapping */ - else if ( flags & _PAGE_PRESENT ) - { - /* We should be here with a valid MFN. */ - ASSERT(!mfn_eq(mfn, INVALID_MFN)); - - /* - * We don't allow replacing any valid entry. - * - * Note that the function xen_pt_update() relies on this - * assumption and will skip the TLB flush. The function will need - * to be updated if the check is relaxed. - */ - if ( lpae_is_valid(entry) ) - { - if ( lpae_is_mapping(entry, level) ) - mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", - mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); - else - mm_printk("Trying to replace a table with a mapping.\n"); - return false; - } - } - /* Sanity check when removing a mapping. */ - else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) - { - /* We should be here with an invalid MFN. */ - ASSERT(mfn_eq(mfn, INVALID_MFN)); - - /* We don't allow removing a table */ - if ( lpae_is_table(entry, level) ) - { - mm_printk("Removing a table is not allowed.\n"); - return false; - } - - /* We don't allow removing a mapping with contiguous bit set. */ - if ( entry.pt.contig ) - { - mm_printk("Removing entry with contiguous bit set is not allowed.\n"); - return false; - } - } - /* Sanity check when populating the page-table. No check so far. */ - else - { - ASSERT(flags & _PAGE_POPULATE); - /* We should be here with an invalid MFN */ - ASSERT(mfn_eq(mfn, INVALID_MFN)); - } - - return true; -} - -/* Update an entry at the level @target. */ -static int xen_pt_update_entry(mfn_t root, unsigned long virt, - mfn_t mfn, unsigned int target, - unsigned int flags) -{ - int rc; - unsigned int level; - lpae_t *table; - /* - * The intermediate page tables are read-only when the MFN is not valid - * and we are not populating page table. - * This means we either modify permissions or remove an entry. - */ - bool read_only = mfn_eq(mfn, INVALID_MFN) && !(flags & _PAGE_POPULATE); - lpae_t pte, *entry; - - /* convenience aliases */ - DECLARE_OFFSETS(offsets, (paddr_t)virt); - - /* _PAGE_POPULATE and _PAGE_PRESENT should never be set together. */ - ASSERT((flags & (_PAGE_POPULATE|_PAGE_PRESENT)) != (_PAGE_POPULATE|_PAGE_PRESENT)); - - table = xen_map_table(root); - for ( level = HYP_PT_ROOT_LEVEL; level < target; level++ ) - { - rc = xen_pt_next_level(read_only, level, &table, offsets[level]); - if ( rc == XEN_TABLE_MAP_FAILED ) - { - /* - * We are here because xen_pt_next_level has failed to map - * the intermediate page table (e.g the table does not exist - * and the pt is read-only). It is a valid case when - * removing a mapping as it may not exist in the page table. - * In this case, just ignore it. - */ - if ( flags & (_PAGE_PRESENT|_PAGE_POPULATE) ) - { - mm_printk("%s: Unable to map level %u\n", __func__, level); - rc = -ENOENT; - goto out; - } - else - { - rc = 0; - goto out; - } - } - else if ( rc != XEN_TABLE_NORMAL_PAGE ) - break; - } - - if ( level != target ) - { - mm_printk("%s: Shattering superpage is not supported\n", __func__); - rc = -EOPNOTSUPP; - goto out; - } - - entry = table + offsets[level]; - - rc = -EINVAL; - if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) - goto out; - - /* If we are only populating page-table, then we are done. */ - rc = 0; - if ( flags & _PAGE_POPULATE ) - goto out; - - /* We are removing the page */ - if ( !(flags & _PAGE_PRESENT) ) - memset(&pte, 0x00, sizeof(pte)); - else - { - /* We are inserting a mapping => Create new pte. */ - if ( !mfn_eq(mfn, INVALID_MFN) ) - { - pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); - - /* - * First and second level pages set pte.pt.table = 0, but - * third level entries set pte.pt.table = 1. - */ - pte.pt.table = (level == 3); - } - else /* We are updating the permission => Copy the current pte. */ - pte = *entry; - - /* Set permission */ - pte.pt.ro = PAGE_RO_MASK(flags); - pte.pt.xn = PAGE_XN_MASK(flags); - /* Set contiguous bit */ - pte.pt.contig = !!(flags & _PAGE_CONTIG); - } - - write_pte(entry, pte); - /* - * No ISB or TLB flush here. They are deferred to xen_pt_update() - * as the entry will not be used as part of the mapping update. - */ - - rc = 0; - -out: - xen_unmap_table(table); - - return rc; -} - -/* Return the level where mapping should be done */ -static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, - unsigned int flags) -{ - unsigned int level; - unsigned long mask; - - /* - * Don't take into account the MFN when removing mapping (i.e - * MFN_INVALID) to calculate the correct target order. - * - * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. - * They are or-ed together and then checked against the size of - * each level. - * - * `left` is not included and checked separately to allow - * superpage mapping even if it is not properly aligned (the - * user may have asked to map 2MB + 4k). - */ - mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; - mask |= vfn; - - /* - * Always use level 3 mapping unless the caller request block - * mapping. - */ - if ( likely(!(flags & _PAGE_BLOCK)) ) - level = 3; - else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && - (nr >= BIT(FIRST_ORDER, UL)) ) - level = 1; - else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && - (nr >= BIT(SECOND_ORDER, UL)) ) - level = 2; - else - level = 3; - - return level; -} - -#define XEN_PT_4K_NR_CONTIG 16 - -/* - * Check whether the contiguous bit can be set. Return the number of - * contiguous entry allowed. If not allowed, return 1. - */ -static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn, - unsigned int level, unsigned long left, - unsigned int flags) -{ - unsigned long nr_contig; - - /* - * Allow the contiguous bit to set when the caller requests block - * mapping. - */ - if ( !(flags & _PAGE_BLOCK) ) - return 1; - - /* - * We don't allow to remove mapping with the contiguous bit set. - * So shortcut the logic and directly return 1. - */ - if ( mfn_eq(mfn, INVALID_MFN) ) - return 1; - - /* - * The number of contiguous entries varies depending on the page - * granularity used. The logic below assumes 4KB. - */ - BUILD_BUG_ON(PAGE_SIZE != SZ_4K); - - /* - * In order to enable the contiguous bit, we should have enough entries - * to map left and both the virtual and physical address should be - * aligned to the size of 16 translation tables entries. - */ - nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG; - - if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) ) - return 1; - - return XEN_PT_4K_NR_CONTIG; -} - -static DEFINE_SPINLOCK(xen_pt_lock); - -static int xen_pt_update(unsigned long virt, - mfn_t mfn, - /* const on purpose as it is used for TLB flush */ - const unsigned long nr_mfns, - unsigned int flags) -{ - int rc = 0; - unsigned long vfn = virt >> PAGE_SHIFT; - unsigned long left = nr_mfns; - - /* - * For arm32, page-tables are different on each CPUs. Yet, they share - * some common mappings. It is assumed that only common mappings - * will be modified with this function. - * - * XXX: Add a check. - */ - const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); - - /* - * The hardware was configured to forbid mapping both writeable and - * executable. - * When modifying/creating mapping (i.e _PAGE_PRESENT is set), - * prevent any update if this happen. - */ - if ( (flags & _PAGE_PRESENT) && !PAGE_RO_MASK(flags) && - !PAGE_XN_MASK(flags) ) - { - mm_printk("Mappings should not be both Writeable and Executable.\n"); - return -EINVAL; - } - - if ( flags & _PAGE_CONTIG ) - { - mm_printk("_PAGE_CONTIG is an internal only flag.\n"); - return -EINVAL; - } - - if ( !IS_ALIGNED(virt, PAGE_SIZE) ) - { - mm_printk("The virtual address is not aligned to the page-size.\n"); - return -EINVAL; - } - - spin_lock(&xen_pt_lock); - - while ( left ) - { - unsigned int order, level, nr_contig, new_flags; - - level = xen_pt_mapping_level(vfn, mfn, left, flags); - order = XEN_PT_LEVEL_ORDER(level); - - ASSERT(left >= BIT(order, UL)); - - /* - * Check if we can set the contiguous mapping and update the - * flags accordingly. - */ - nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags); - new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0); - - for ( ; nr_contig > 0; nr_contig-- ) - { - rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, - new_flags); - if ( rc ) - break; - - vfn += 1U << order; - if ( !mfn_eq(mfn, INVALID_MFN) ) - mfn = mfn_add(mfn, 1U << order); - - left -= (1U << order); - } - - if ( rc ) - break; - } - - /* - * The TLBs flush can be safely skipped when a mapping is inserted - * as we don't allow mapping replacement (see xen_pt_check_entry()). - * Although we still need an ISB to ensure any DSB in - * write_pte() will complete because the mapping may be used soon - * after. - * - * For all the other cases, the TLBs will be flushed unconditionally - * even if the mapping has failed. This is because we may have - * partially modified the PT. This will prevent any unexpected - * behavior afterwards. - */ - if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) - flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); - else - isb(); - - spin_unlock(&xen_pt_lock); - - return rc; -} - int map_pages_to_xen(unsigned long virt, mfn_t mfn, unsigned long nr_mfns, @@ -1236,11 +122,6 @@ int map_pages_to_xen(unsigned long virt, return xen_pt_update(virt, mfn, nr_mfns, flags); } -int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) -{ - return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); -} - int destroy_xen_mappings(unsigned long s, unsigned long e) { ASSERT(IS_ALIGNED(s, PAGE_SIZE)); diff --git a/xen/arch/arm/mmu/Makefile b/xen/arch/arm/mmu/Makefile new file mode 100644 index 0000000000..b18cec4836 --- /dev/null +++ b/xen/arch/arm/mmu/Makefile @@ -0,0 +1 @@ +obj-y += mm.o diff --git a/xen/arch/arm/mmu/mm.c b/xen/arch/arm/mmu/mm.c new file mode 100644 index 0000000000..b70982e9d6 --- /dev/null +++ b/xen/arch/arm/mmu/mm.c @@ -0,0 +1,1146 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * xen/arch/arm/mmu/mm.c + * + * MMU code for an ARMv7-A with virt extensions. + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef mfn_to_virt +#define mfn_to_virt(mfn) __mfn_to_virt(mfn_x(mfn)) + +#ifdef NDEBUG +static inline void +__attribute__ ((__format__ (__printf__, 1, 2))) +mm_printk(const char *fmt, ...) {} +#else +#define mm_printk(fmt, args...) \ + do \ + { \ + dprintk(XENLOG_ERR, fmt, ## args); \ + WARN(); \ + } while (0) +#endif + +/* Static start-of-day pagetables that we use before the allocators + * are up. These are used by all CPUs during bringup before switching + * to the CPUs own pagetables. + * + * These pagetables have a very simple structure. They include: + * - XEN_VIRT_SIZE worth of L3 mappings of xen at XEN_VIRT_START, boot_first + * and boot_second are used to populate the tables down to boot_third + * which contains the actual mapping. + * - a 1:1 mapping of xen at its current physical address. This uses a + * section mapping at whichever of boot_{pgtable,first,second} + * covers that physical address. + * + * For the boot CPU these mappings point to the address where Xen was + * loaded by the bootloader. For secondary CPUs they point to the + * relocated copy of Xen for the benefit of secondary CPUs. + * + * In addition to the above for the boot CPU the device-tree is + * initially mapped in the boot misc slot. This mapping is not present + * for secondary CPUs. + * + * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped + * by the CPU once it has moved off the 1:1 mapping. + */ +DEFINE_BOOT_PAGE_TABLE(boot_pgtable); +#ifdef CONFIG_ARM_64 +DEFINE_BOOT_PAGE_TABLE(boot_first); +DEFINE_BOOT_PAGE_TABLE(boot_first_id); +#endif +DEFINE_BOOT_PAGE_TABLE(boot_second_id); +DEFINE_BOOT_PAGE_TABLE(boot_third_id); +DEFINE_BOOT_PAGE_TABLE(boot_second); +DEFINE_BOOT_PAGE_TABLES(boot_third, XEN_NR_ENTRIES(2)); + +/* Main runtime page tables */ + +/* + * For arm32 xen_pgtable are per-PCPU and are allocated before + * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. + * + * xen_second, xen_fixmap and xen_xenmap are always shared between all + * PCPUs. + */ + +#ifdef CONFIG_ARM_64 +#define HYP_PT_ROOT_LEVEL 0 +DEFINE_PAGE_TABLE(xen_pgtable); +static DEFINE_PAGE_TABLE(xen_first); +#define THIS_CPU_PGTABLE xen_pgtable +#else +#define HYP_PT_ROOT_LEVEL 1 +/* Per-CPU pagetable pages */ +/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ +DEFINE_PER_CPU(lpae_t *, xen_pgtable); +#define THIS_CPU_PGTABLE this_cpu(xen_pgtable) +/* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ +static DEFINE_PAGE_TABLE(cpu0_pgtable); +#endif + +/* Common pagetable leaves */ +/* Second level page table used to cover Xen virtual address space */ +static DEFINE_PAGE_TABLE(xen_second); +/* Third level page table used for fixmap */ +DEFINE_BOOT_PAGE_TABLE(xen_fixmap); +/* + * Third level page table used to map Xen itself with the XN bit set + * as appropriate. + */ +static DEFINE_PAGE_TABLES(xen_xenmap, XEN_NR_ENTRIES(2)); + +/* Non-boot CPUs use this to find the correct pagetables. */ +uint64_t init_ttbr; + +static paddr_t phys_offset; + +/* Limits of the Xen heap */ +mfn_t directmap_mfn_start __read_mostly = INVALID_MFN_INITIALIZER; +mfn_t directmap_mfn_end __read_mostly; +vaddr_t directmap_virt_end __read_mostly; +#ifdef CONFIG_ARM_64 +vaddr_t directmap_virt_start __read_mostly; +unsigned long directmap_base_pdx __read_mostly; +#endif + +/* Checking VA memory layout alignment. */ +static void __init __maybe_unused build_assertions(void) +{ + /* 2MB aligned regions */ + BUILD_BUG_ON(XEN_VIRT_START & ~SECOND_MASK); + BUILD_BUG_ON(FIXMAP_ADDR(0) & ~SECOND_MASK); + /* 1GB aligned regions */ +#ifdef CONFIG_ARM_32 + BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK); +#else + BUILD_BUG_ON(DIRECTMAP_VIRT_START & ~FIRST_MASK); +#endif + /* Page table structure constraints */ +#ifdef CONFIG_ARM_64 + /* + * The first few slots of the L0 table is reserved for the identity + * mapping. Check that none of the other regions are overlapping + * with it. + */ +#define CHECK_OVERLAP_WITH_IDMAP(virt) \ + BUILD_BUG_ON(zeroeth_table_offset(virt) < IDENTITY_MAPPING_AREA_NR_L0) + + CHECK_OVERLAP_WITH_IDMAP(XEN_VIRT_START); + CHECK_OVERLAP_WITH_IDMAP(VMAP_VIRT_START); + CHECK_OVERLAP_WITH_IDMAP(FRAMETABLE_VIRT_START); + CHECK_OVERLAP_WITH_IDMAP(DIRECTMAP_VIRT_START); +#undef CHECK_OVERLAP_WITH_IDMAP +#endif + BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE + BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK); +#endif + /* + * The boot code expects the regions XEN_VIRT_START, FIXMAP_ADDR(0), + * BOOT_FDT_VIRT_START to use the same 0th (arm64 only) and 1st + * slot in the page tables. + */ +#define CHECK_SAME_SLOT(level, virt1, virt2) \ + BUILD_BUG_ON(level##_table_offset(virt1) != level##_table_offset(virt2)) + +#define CHECK_DIFFERENT_SLOT(level, virt1, virt2) \ + BUILD_BUG_ON(level##_table_offset(virt1) == level##_table_offset(virt2)) + +#ifdef CONFIG_ARM_64 + CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, FIXMAP_ADDR(0)); + CHECK_SAME_SLOT(zeroeth, XEN_VIRT_START, BOOT_FDT_VIRT_START); +#endif + CHECK_SAME_SLOT(first, XEN_VIRT_START, FIXMAP_ADDR(0)); + CHECK_SAME_SLOT(first, XEN_VIRT_START, BOOT_FDT_VIRT_START); + + /* + * For arm32, the temporary mapping will re-use the domheap + * first slot and the second slots will match. + */ +#ifdef CONFIG_ARM_32 + CHECK_SAME_SLOT(first, TEMPORARY_XEN_VIRT_START, DOMHEAP_VIRT_START); + CHECK_DIFFERENT_SLOT(first, XEN_VIRT_START, TEMPORARY_XEN_VIRT_START); + CHECK_SAME_SLOT(second, XEN_VIRT_START, TEMPORARY_XEN_VIRT_START); +#endif + +#undef CHECK_SAME_SLOT +#undef CHECK_DIFFERENT_SLOT +} + +static lpae_t *xen_map_table(mfn_t mfn) +{ + /* + * During early boot, map_domain_page() may be unusable. Use the + * PMAP to map temporarily a page-table. + */ + if ( system_state == SYS_STATE_early_boot ) + return pmap_map(mfn); + + return map_domain_page(mfn); +} + +static void xen_unmap_table(const lpae_t *table) +{ + /* + * During early boot, xen_map_table() will not use map_domain_page() + * but the PMAP. + */ + if ( system_state == SYS_STATE_early_boot ) + pmap_unmap(table); + else + unmap_domain_page(table); +} + +void dump_pt_walk(paddr_t ttbr, paddr_t addr, + unsigned int root_level, + unsigned int nr_root_tables) +{ + static const char *level_strs[4] = { "0TH", "1ST", "2ND", "3RD" }; + const mfn_t root_mfn = maddr_to_mfn(ttbr); + DECLARE_OFFSETS(offsets, addr); + lpae_t pte, *mapping; + unsigned int level, root_table; + +#ifdef CONFIG_ARM_32 + BUG_ON(root_level < 1); +#endif + BUG_ON(root_level > 3); + + if ( nr_root_tables > 1 ) + { + /* + * Concatenated root-level tables. The table number will be + * the offset at the previous level. It is not possible to + * concatenate a level-0 root. + */ + BUG_ON(root_level == 0); + root_table = offsets[root_level - 1]; + printk("Using concatenated root table %u\n", root_table); + if ( root_table >= nr_root_tables ) + { + printk("Invalid root table offset\n"); + return; + } + } + else + root_table = 0; + + mapping = xen_map_table(mfn_add(root_mfn, root_table)); + + for ( level = root_level; ; level++ ) + { + if ( offsets[level] > XEN_PT_LPAE_ENTRIES ) + break; + + pte = mapping[offsets[level]]; + + printk("%s[0x%03x] = 0x%"PRIx64"\n", + level_strs[level], offsets[level], pte.bits); + + if ( level == 3 || !pte.walk.valid || !pte.walk.table ) + break; + + /* For next iteration */ + xen_unmap_table(mapping); + mapping = xen_map_table(lpae_get_mfn(pte)); + } + + xen_unmap_table(mapping); +} + +void dump_hyp_walk(vaddr_t addr) +{ + uint64_t ttbr = READ_SYSREG64(TTBR0_EL2); + + printk("Walking Hypervisor VA 0x%"PRIvaddr" " + "on CPU%d via TTBR 0x%016"PRIx64"\n", + addr, smp_processor_id(), ttbr); + + dump_pt_walk(ttbr, addr, HYP_PT_ROOT_LEVEL, 1); +} + +lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr) +{ + lpae_t e = (lpae_t) { + .pt = { + .valid = 1, /* Mappings are present */ + .table = 0, /* Set to 1 for links and 4k maps */ + .ai = attr, + .ns = 1, /* Hyp mode is in the non-secure world */ + .up = 1, /* See below */ + .ro = 0, /* Assume read-write */ + .af = 1, /* No need for access tracking */ + .ng = 1, /* Makes TLB flushes easier */ + .contig = 0, /* Assume non-contiguous */ + .xn = 1, /* No need to execute outside .text */ + .avail = 0, /* Reference count for domheap mapping */ + }}; + /* + * For EL2 stage-1 page table, up (aka AP[1]) is RES1 as the translation + * regime applies to only one exception level (see D4.4.4 and G4.6.1 + * in ARM DDI 0487B.a). If this changes, remember to update the + * hard-coded values in head.S too. + */ + + switch ( attr ) + { + case MT_NORMAL_NC: + /* + * ARM ARM: Overlaying the shareability attribute (DDI + * 0406C.b B3-1376 to 1377) + * + * A memory region with a resultant memory type attribute of Normal, + * and a resultant cacheability attribute of Inner Non-cacheable, + * Outer Non-cacheable, must have a resultant shareability attribute + * of Outer Shareable, otherwise shareability is UNPREDICTABLE. + * + * On ARMv8 sharability is ignored and explicitly treated as Outer + * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. + */ + e.pt.sh = LPAE_SH_OUTER; + break; + case MT_DEVICE_nGnRnE: + case MT_DEVICE_nGnRE: + /* + * Shareability is ignored for non-Normal memory, Outer is as + * good as anything. + * + * On ARMv8 sharability is ignored and explicitly treated as Outer + * Shareable for any device memory type. + */ + e.pt.sh = LPAE_SH_OUTER; + break; + default: + e.pt.sh = LPAE_SH_INNER; /* Xen mappings are SMP coherent */ + break; + } + + ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); + + lpae_set_mfn(e, mfn); + + return e; +} + +/* Map a 4k page in a fixmap entry */ +void set_fixmap(unsigned int map, mfn_t mfn, unsigned int flags) +{ + int res; + + res = map_pages_to_xen(FIXMAP_ADDR(map), mfn, 1, flags); + BUG_ON(res != 0); +} + +/* Remove a mapping from a fixmap entry */ +void clear_fixmap(unsigned int map) +{ + int res; + + res = destroy_xen_mappings(FIXMAP_ADDR(map), FIXMAP_ADDR(map) + PAGE_SIZE); + BUG_ON(res != 0); +} + +lpae_t pte_of_xenaddr(vaddr_t va) +{ + paddr_t ma = va + phys_offset; + + return mfn_to_xen_entry(maddr_to_mfn(ma), MT_NORMAL); +} + +void __init remove_early_mappings(void) +{ + int rc; + + /* destroy the _PAGE_BLOCK mapping */ + rc = modify_xen_mappings(BOOT_FDT_VIRT_START, + BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, + _PAGE_BLOCK); + BUG_ON(rc); +} + +/* + * After boot, Xen page-tables should not contain mapping that are both + * Writable and eXecutables. + * + * This should be called on each CPU to enforce the policy. + */ +static void xen_pt_enforce_wnx(void) +{ + WRITE_SYSREG(READ_SYSREG(SCTLR_EL2) | SCTLR_Axx_ELx_WXN, SCTLR_EL2); + /* + * The TLBs may cache SCTLR_EL2.WXN. So ensure it is synchronized + * before flushing the TLBs. + */ + isb(); + flush_xen_tlb_local(); +} + +/* Clear a translation table and clean & invalidate the cache */ +static void clear_table(void *table) +{ + clear_page(table); + clean_and_invalidate_dcache_va_range(table, PAGE_SIZE); +} + +/* Boot-time pagetable setup. + * Changes here may need matching changes in head.S */ +void __init setup_pagetables(unsigned long boot_phys_offset) +{ + uint64_t ttbr; + lpae_t pte, *p; + int i; + + phys_offset = boot_phys_offset; + + arch_setup_page_tables(); + +#ifdef CONFIG_ARM_64 + pte = pte_of_xenaddr((uintptr_t)xen_first); + pte.pt.table = 1; + pte.pt.xn = 0; + xen_pgtable[zeroeth_table_offset(XEN_VIRT_START)] = pte; + + p = (void *) xen_first; +#else + p = (void *) cpu0_pgtable; +#endif + + /* Map xen second level page-table */ + p[0] = pte_of_xenaddr((uintptr_t)(xen_second)); + p[0].pt.table = 1; + p[0].pt.xn = 0; + + /* Break up the Xen mapping into pages and protect them separately. */ + for ( i = 0; i < XEN_NR_ENTRIES(3); i++ ) + { + vaddr_t va = XEN_VIRT_START + (i << PAGE_SHIFT); + + if ( !is_kernel(va) ) + break; + pte = pte_of_xenaddr(va); + pte.pt.table = 1; /* third level mappings always have this bit set */ + if ( is_kernel_text(va) || is_kernel_inittext(va) ) + { + pte.pt.xn = 0; + pte.pt.ro = 1; + } + if ( is_kernel_rodata(va) ) + pte.pt.ro = 1; + xen_xenmap[i] = pte; + } + + /* Initialise xen second level entries ... */ + /* ... Xen's text etc */ + for ( i = 0; i < XEN_NR_ENTRIES(2); i++ ) + { + vaddr_t va = XEN_VIRT_START + (i << XEN_PT_LEVEL_SHIFT(2)); + + pte = pte_of_xenaddr((vaddr_t)(xen_xenmap + i * XEN_PT_LPAE_ENTRIES)); + pte.pt.table = 1; + xen_second[second_table_offset(va)] = pte; + } + + /* ... Fixmap */ + pte = pte_of_xenaddr((vaddr_t)xen_fixmap); + pte.pt.table = 1; + xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte; + +#ifdef CONFIG_ARM_64 + ttbr = (uintptr_t) xen_pgtable + phys_offset; +#else + ttbr = (uintptr_t) cpu0_pgtable + phys_offset; +#endif + + switch_ttbr(ttbr); + + xen_pt_enforce_wnx(); + +#ifdef CONFIG_ARM_32 + per_cpu(xen_pgtable, 0) = cpu0_pgtable; +#endif +} + +static void clear_boot_pagetables(void) +{ + /* + * Clear the copy of the boot pagetables. Each secondary CPU + * rebuilds these itself (see head.S). + */ + clear_table(boot_pgtable); +#ifdef CONFIG_ARM_64 + clear_table(boot_first); + clear_table(boot_first_id); +#endif + clear_table(boot_second); + clear_table(boot_third); +} + +#ifdef CONFIG_ARM_64 +int init_secondary_pagetables(int cpu) +{ + clear_boot_pagetables(); + + /* Set init_ttbr for this CPU coming up. All CPus share a single setof + * pagetables, but rewrite it each time for consistency with 32 bit. */ + init_ttbr = (uintptr_t) xen_pgtable + phys_offset; + clean_dcache(init_ttbr); + return 0; +} +#else +int init_secondary_pagetables(int cpu) +{ + lpae_t *first; + + first = alloc_xenheap_page(); /* root == first level on 32-bit 3-level trie */ + + if ( !first ) + { + printk("CPU%u: Unable to allocate the first page-table\n", cpu); + return -ENOMEM; + } + + /* Initialise root pagetable from root of boot tables */ + memcpy(first, cpu0_pgtable, PAGE_SIZE); + per_cpu(xen_pgtable, cpu) = first; + + if ( !init_domheap_mappings(cpu) ) + { + printk("CPU%u: Unable to prepare the domheap page-tables\n", cpu); + per_cpu(xen_pgtable, cpu) = NULL; + free_xenheap_page(first); + return -ENOMEM; + } + + clear_boot_pagetables(); + + /* Set init_ttbr for this CPU coming up */ + init_ttbr = __pa(first); + clean_dcache(init_ttbr); + + return 0; +} +#endif + +/* MMU setup for secondary CPUS (which already have paging enabled) */ +void mmu_init_secondary_cpu(void) +{ + xen_pt_enforce_wnx(); +} + +#ifdef CONFIG_ARM_32 +/* + * Set up the direct-mapped xenheap: + * up to 1GB of contiguous, always-mapped memory. + */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) +{ + int rc; + + rc = map_pages_to_xen(XENHEAP_VIRT_START, _mfn(base_mfn), nr_mfns, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the directmap mappings.\n"); + + /* Record where the directmap is, for translation routines. */ + directmap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; +} +#else /* CONFIG_ARM_64 */ +/* Map the region in the directmap area. */ +void __init setup_directmap_mappings(unsigned long base_mfn, + unsigned long nr_mfns) +{ + int rc; + + /* First call sets the directmap physical and virtual offset. */ + if ( mfn_eq(directmap_mfn_start, INVALID_MFN) ) + { + unsigned long mfn_gb = base_mfn & ~((FIRST_SIZE >> PAGE_SHIFT) - 1); + + directmap_mfn_start = _mfn(base_mfn); + directmap_base_pdx = mfn_to_pdx(_mfn(base_mfn)); + /* + * The base address may not be aligned to the first level + * size (e.g. 1GB when using 4KB pages). This would prevent + * superpage mappings for all the regions because the virtual + * address and machine address should both be suitably aligned. + * + * Prevent that by offsetting the start of the directmap virtual + * address. + */ + directmap_virt_start = DIRECTMAP_VIRT_START + + (base_mfn - mfn_gb) * PAGE_SIZE; + } + + if ( base_mfn < mfn_x(directmap_mfn_start) ) + panic("cannot add directmap mapping at %lx below heap start %lx\n", + base_mfn, mfn_x(directmap_mfn_start)); + + rc = map_pages_to_xen((vaddr_t)__mfn_to_virt(base_mfn), + _mfn(base_mfn), nr_mfns, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the directmap mappings.\n"); +} +#endif + +/* Map a frame table to cover physical addresses ps through pe */ +void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) +{ + unsigned long nr_pdxs = mfn_to_pdx(mfn_add(maddr_to_mfn(pe), -1)) - + mfn_to_pdx(maddr_to_mfn(ps)) + 1; + unsigned long frametable_size = nr_pdxs * sizeof(struct page_info); + mfn_t base_mfn; + const unsigned long mapping_size = frametable_size < MB(32) ? MB(2) : MB(32); + int rc; + + /* + * The size of paddr_t should be sufficient for the complete range of + * physical address. + */ + BUILD_BUG_ON((sizeof(paddr_t) * BITS_PER_BYTE) < PADDR_BITS); + BUILD_BUG_ON(sizeof(struct page_info) != PAGE_INFO_SIZE); + + if ( frametable_size > FRAMETABLE_SIZE ) + panic("The frametable cannot cover the physical region %#"PRIpaddr" - %#"PRIpaddr"\n", + ps, pe); + + frametable_base_pdx = mfn_to_pdx(maddr_to_mfn(ps)); + /* Round up to 2M or 32M boundary, as appropriate. */ + frametable_size = ROUNDUP(frametable_size, mapping_size); + base_mfn = alloc_boot_pages(frametable_size >> PAGE_SHIFT, 32<<(20-12)); + + rc = map_pages_to_xen(FRAMETABLE_VIRT_START, base_mfn, + frametable_size >> PAGE_SHIFT, + PAGE_HYPERVISOR_RW | _PAGE_BLOCK); + if ( rc ) + panic("Unable to setup the frametable mappings.\n"); + + memset(&frame_table[0], 0, nr_pdxs * sizeof(struct page_info)); + memset(&frame_table[nr_pdxs], -1, + frametable_size - (nr_pdxs * sizeof(struct page_info))); + + frametable_virt_end = FRAMETABLE_VIRT_START + (nr_pdxs * sizeof(struct page_info)); +} + +void *__init arch_vmap_virt_end(void) +{ + return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); +} + +/* + * This function should only be used to remap device address ranges + * TODO: add a check to verify this assumption + */ +void *ioremap_attr(paddr_t start, size_t len, unsigned int attributes) +{ + mfn_t mfn = _mfn(PFN_DOWN(start)); + unsigned int offs = start & (PAGE_SIZE - 1); + unsigned int nr = PFN_UP(offs + len); + void *ptr = __vmap(&mfn, nr, 1, 1, attributes, VMAP_DEFAULT); + + if ( ptr == NULL ) + return NULL; + + return ptr + offs; +} + +static int create_xen_table(lpae_t *entry) +{ + mfn_t mfn; + void *p; + lpae_t pte; + + if ( system_state != SYS_STATE_early_boot ) + { + struct page_info *pg = alloc_domheap_page(NULL, 0); + + if ( pg == NULL ) + return -ENOMEM; + + mfn = page_to_mfn(pg); + } + else + mfn = alloc_boot_pages(1, 1); + + p = xen_map_table(mfn); + clear_page(p); + xen_unmap_table(p); + + pte = mfn_to_xen_entry(mfn, MT_NORMAL); + pte.pt.table = 1; + write_pte(entry, pte); + /* + * No ISB here. It is deferred to xen_pt_update() as the new table + * will not be used for hardware translation table access as part of + * the mapping update. + */ + + return 0; +} + +#define XEN_TABLE_MAP_FAILED 0 +#define XEN_TABLE_SUPER_PAGE 1 +#define XEN_TABLE_NORMAL_PAGE 2 + +/* + * Take the currently mapped table, find the corresponding entry, + * and map the next table, if available. + * + * The read_only parameters indicates whether intermediate tables should + * be allocated when not present. + * + * Return values: + * XEN_TABLE_MAP_FAILED: Either read_only was set and the entry + * was empty, or allocating a new page failed. + * XEN_TABLE_NORMAL_PAGE: next level mapped normally + * XEN_TABLE_SUPER_PAGE: The next entry points to a superpage. + */ +static int xen_pt_next_level(bool read_only, unsigned int level, + lpae_t **table, unsigned int offset) +{ + lpae_t *entry; + int ret; + mfn_t mfn; + + entry = *table + offset; + + if ( !lpae_is_valid(*entry) ) + { + if ( read_only ) + return XEN_TABLE_MAP_FAILED; + + ret = create_xen_table(entry); + if ( ret ) + return XEN_TABLE_MAP_FAILED; + } + + /* The function xen_pt_next_level is never called at the 3rd level */ + if ( lpae_is_mapping(*entry, level) ) + return XEN_TABLE_SUPER_PAGE; + + mfn = lpae_get_mfn(*entry); + + xen_unmap_table(*table); + *table = xen_map_table(mfn); + + return XEN_TABLE_NORMAL_PAGE; +} + +/* Sanity check of the entry */ +static bool xen_pt_check_entry(lpae_t entry, mfn_t mfn, unsigned int level, + unsigned int flags) +{ + /* Sanity check when modifying an entry. */ + if ( (flags & _PAGE_PRESENT) && mfn_eq(mfn, INVALID_MFN) ) + { + /* We don't allow modifying an invalid entry. */ + if ( !lpae_is_valid(entry) ) + { + mm_printk("Modifying invalid entry is not allowed.\n"); + return false; + } + + /* We don't allow modifying a table entry */ + if ( !lpae_is_mapping(entry, level) ) + { + mm_printk("Modifying a table entry is not allowed.\n"); + return false; + } + + /* We don't allow changing memory attributes. */ + if ( entry.pt.ai != PAGE_AI_MASK(flags) ) + { + mm_printk("Modifying memory attributes is not allowed (0x%x -> 0x%x).\n", + entry.pt.ai, PAGE_AI_MASK(flags)); + return false; + } + + /* We don't allow modifying entry with contiguous bit set. */ + if ( entry.pt.contig ) + { + mm_printk("Modifying entry with contiguous bit set is not allowed.\n"); + return false; + } + } + /* Sanity check when inserting a mapping */ + else if ( flags & _PAGE_PRESENT ) + { + /* We should be here with a valid MFN. */ + ASSERT(!mfn_eq(mfn, INVALID_MFN)); + + /* + * We don't allow replacing any valid entry. + * + * Note that the function xen_pt_update() relies on this + * assumption and will skip the TLB flush. The function will need + * to be updated if the check is relaxed. + */ + if ( lpae_is_valid(entry) ) + { + if ( lpae_is_mapping(entry, level) ) + mm_printk("Changing MFN for a valid entry is not allowed (%#"PRI_mfn" -> %#"PRI_mfn").\n", + mfn_x(lpae_get_mfn(entry)), mfn_x(mfn)); + else + mm_printk("Trying to replace a table with a mapping.\n"); + return false; + } + } + /* Sanity check when removing a mapping. */ + else if ( (flags & (_PAGE_PRESENT|_PAGE_POPULATE)) == 0 ) + { + /* We should be here with an invalid MFN. */ + ASSERT(mfn_eq(mfn, INVALID_MFN)); + + /* We don't allow removing a table */ + if ( lpae_is_table(entry, level) ) + { + mm_printk("Removing a table is not allowed.\n"); + return false; + } + + /* We don't allow removing a mapping with contiguous bit set. */ + if ( entry.pt.contig ) + { + mm_printk("Removing entry with contiguous bit set is not allowed.\n"); + return false; + } + } + /* Sanity check when populating the page-table. No check so far. */ + else + { + ASSERT(flags & _PAGE_POPULATE); + /* We should be here with an invalid MFN */ + ASSERT(mfn_eq(mfn, INVALID_MFN)); + } + + return true; +} + +/* Update an entry at the level @target. */ +static int xen_pt_update_entry(mfn_t root, unsigned long virt, + mfn_t mfn, unsigned int target, + unsigned int flags) +{ + int rc; + unsigned int level; + lpae_t *table; + /* + * The intermediate page tables are read-only when the MFN is not valid + * and we are not populating page table. + * This means we either modify permissions or remove an entry. + */ + bool read_only = mfn_eq(mfn, INVALID_MFN) && !(flags & _PAGE_POPULATE); + lpae_t pte, *entry; + + /* convenience aliases */ + DECLARE_OFFSETS(offsets, (paddr_t)virt); + + /* _PAGE_POPULATE and _PAGE_PRESENT should never be set together. */ + ASSERT((flags & (_PAGE_POPULATE|_PAGE_PRESENT)) != (_PAGE_POPULATE|_PAGE_PRESENT)); + + table = xen_map_table(root); + for ( level = HYP_PT_ROOT_LEVEL; level < target; level++ ) + { + rc = xen_pt_next_level(read_only, level, &table, offsets[level]); + if ( rc == XEN_TABLE_MAP_FAILED ) + { + /* + * We are here because xen_pt_next_level has failed to map + * the intermediate page table (e.g the table does not exist + * and the pt is read-only). It is a valid case when + * removing a mapping as it may not exist in the page table. + * In this case, just ignore it. + */ + if ( flags & (_PAGE_PRESENT|_PAGE_POPULATE) ) + { + mm_printk("%s: Unable to map level %u\n", __func__, level); + rc = -ENOENT; + goto out; + } + else + { + rc = 0; + goto out; + } + } + else if ( rc != XEN_TABLE_NORMAL_PAGE ) + break; + } + + if ( level != target ) + { + mm_printk("%s: Shattering superpage is not supported\n", __func__); + rc = -EOPNOTSUPP; + goto out; + } + + entry = table + offsets[level]; + + rc = -EINVAL; + if ( !xen_pt_check_entry(*entry, mfn, level, flags) ) + goto out; + + /* If we are only populating page-table, then we are done. */ + rc = 0; + if ( flags & _PAGE_POPULATE ) + goto out; + + /* We are removing the page */ + if ( !(flags & _PAGE_PRESENT) ) + memset(&pte, 0x00, sizeof(pte)); + else + { + /* We are inserting a mapping => Create new pte. */ + if ( !mfn_eq(mfn, INVALID_MFN) ) + { + pte = mfn_to_xen_entry(mfn, PAGE_AI_MASK(flags)); + + /* + * First and second level pages set pte.pt.table = 0, but + * third level entries set pte.pt.table = 1. + */ + pte.pt.table = (level == 3); + } + else /* We are updating the permission => Copy the current pte. */ + pte = *entry; + + /* Set permission */ + pte.pt.ro = PAGE_RO_MASK(flags); + pte.pt.xn = PAGE_XN_MASK(flags); + /* Set contiguous bit */ + pte.pt.contig = !!(flags & _PAGE_CONTIG); + } + + write_pte(entry, pte); + /* + * No ISB or TLB flush here. They are deferred to xen_pt_update() + * as the entry will not be used as part of the mapping update. + */ + + rc = 0; + +out: + xen_unmap_table(table); + + return rc; +} + +/* Return the level where mapping should be done */ +static int xen_pt_mapping_level(unsigned long vfn, mfn_t mfn, unsigned long nr, + unsigned int flags) +{ + unsigned int level; + unsigned long mask; + + /* + * Don't take into account the MFN when removing mapping (i.e + * MFN_INVALID) to calculate the correct target order. + * + * Per the Arm Arm, `vfn` and `mfn` must be both superpage aligned. + * They are or-ed together and then checked against the size of + * each level. + * + * `left` is not included and checked separately to allow + * superpage mapping even if it is not properly aligned (the + * user may have asked to map 2MB + 4k). + */ + mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; + mask |= vfn; + + /* + * Always use level 3 mapping unless the caller request block + * mapping. + */ + if ( likely(!(flags & _PAGE_BLOCK)) ) + level = 3; + else if ( !(mask & (BIT(FIRST_ORDER, UL) - 1)) && + (nr >= BIT(FIRST_ORDER, UL)) ) + level = 1; + else if ( !(mask & (BIT(SECOND_ORDER, UL) - 1)) && + (nr >= BIT(SECOND_ORDER, UL)) ) + level = 2; + else + level = 3; + + return level; +} + +#define XEN_PT_4K_NR_CONTIG 16 + +/* + * Check whether the contiguous bit can be set. Return the number of + * contiguous entry allowed. If not allowed, return 1. + */ +static unsigned int xen_pt_check_contig(unsigned long vfn, mfn_t mfn, + unsigned int level, unsigned long left, + unsigned int flags) +{ + unsigned long nr_contig; + + /* + * Allow the contiguous bit to set when the caller requests block + * mapping. + */ + if ( !(flags & _PAGE_BLOCK) ) + return 1; + + /* + * We don't allow to remove mapping with the contiguous bit set. + * So shortcut the logic and directly return 1. + */ + if ( mfn_eq(mfn, INVALID_MFN) ) + return 1; + + /* + * The number of contiguous entries varies depending on the page + * granularity used. The logic below assumes 4KB. + */ + BUILD_BUG_ON(PAGE_SIZE != SZ_4K); + + /* + * In order to enable the contiguous bit, we should have enough entries + * to map left and both the virtual and physical address should be + * aligned to the size of 16 translation tables entries. + */ + nr_contig = BIT(XEN_PT_LEVEL_ORDER(level), UL) * XEN_PT_4K_NR_CONTIG; + + if ( (left < nr_contig) || ((mfn_x(mfn) | vfn) & (nr_contig - 1)) ) + return 1; + + return XEN_PT_4K_NR_CONTIG; +} + +static DEFINE_SPINLOCK(xen_pt_lock); + +int xen_pt_update(unsigned long virt, + mfn_t mfn, + /* const on purpose as it is used for TLB flush */ + const unsigned long nr_mfns, + unsigned int flags) +{ + int rc = 0; + unsigned long vfn = virt >> PAGE_SHIFT; + unsigned long left = nr_mfns; + + /* + * For arm32, page-tables are different on each CPUs. Yet, they share + * some common mappings. It is assumed that only common mappings + * will be modified with this function. + * + * XXX: Add a check. + */ + const mfn_t root = maddr_to_mfn(READ_SYSREG64(TTBR0_EL2)); + + /* + * The hardware was configured to forbid mapping both writeable and + * executable. + * When modifying/creating mapping (i.e _PAGE_PRESENT is set), + * prevent any update if this happen. + */ + if ( (flags & _PAGE_PRESENT) && !PAGE_RO_MASK(flags) && + !PAGE_XN_MASK(flags) ) + { + mm_printk("Mappings should not be both Writeable and Executable.\n"); + return -EINVAL; + } + + if ( flags & _PAGE_CONTIG ) + { + mm_printk("_PAGE_CONTIG is an internal only flag.\n"); + return -EINVAL; + } + + if ( !IS_ALIGNED(virt, PAGE_SIZE) ) + { + mm_printk("The virtual address is not aligned to the page-size.\n"); + return -EINVAL; + } + + spin_lock(&xen_pt_lock); + + while ( left ) + { + unsigned int order, level, nr_contig, new_flags; + + level = xen_pt_mapping_level(vfn, mfn, left, flags); + order = XEN_PT_LEVEL_ORDER(level); + + ASSERT(left >= BIT(order, UL)); + + /* + * Check if we can set the contiguous mapping and update the + * flags accordingly. + */ + nr_contig = xen_pt_check_contig(vfn, mfn, level, left, flags); + new_flags = flags | ((nr_contig > 1) ? _PAGE_CONTIG : 0); + + for ( ; nr_contig > 0; nr_contig-- ) + { + rc = xen_pt_update_entry(root, vfn << PAGE_SHIFT, mfn, level, + new_flags); + if ( rc ) + break; + + vfn += 1U << order; + if ( !mfn_eq(mfn, INVALID_MFN) ) + mfn = mfn_add(mfn, 1U << order); + + left -= (1U << order); + } + + if ( rc ) + break; + } + + /* + * The TLBs flush can be safely skipped when a mapping is inserted + * as we don't allow mapping replacement (see xen_pt_check_entry()). + * Although we still need an ISB to ensure any DSB in + * write_pte() will complete because the mapping may be used soon + * after. + * + * For all the other cases, the TLBs will be flushed unconditionally + * even if the mapping has failed. This is because we may have + * partially modified the PT. This will prevent any unexpected + * behavior afterwards. + */ + if ( !((flags & _PAGE_PRESENT) && !mfn_eq(mfn, INVALID_MFN)) ) + flush_xen_tlb_range_va(virt, PAGE_SIZE * nr_mfns); + else + isb(); + + spin_unlock(&xen_pt_lock); + + return rc; +} + +int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) +{ + return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:45:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:45:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573570.898431 (Exim 4.92) (envelope-from ) id 1qQgJx-0002BS-4O; Tue, 01 Aug 2023 03:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573570.898431; Tue, 01 Aug 2023 03:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJx-0002BJ-1f; Tue, 01 Aug 2023 03:45:17 +0000 Received: by outflank-mailman (input) for mailman id 573570; Tue, 01 Aug 2023 03:45:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJv-0006rJ-Ky for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:15 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d2768253-301d-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 05:45:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB417D75; Mon, 31 Jul 2023 20:45:56 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7BA513F59C; Mon, 31 Jul 2023 20:45:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2768253-301d-11ee-b258-6b7b168915f2 From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen , Henry Wang Subject: [PATCH v4 10/13] xen/arm: mmu: move MMU-specific setup_mm to mmu/setup.c Date: Tue, 1 Aug 2023 11:44:16 +0800 Message-Id: <20230801034419.2047541-11-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng setup_mm is used for Xen to setup memory management subsystem at boot time, like boot allocator, direct-mapping, xenheap initialization, frametable and static memory pages. We could inherit some components seamlessly in later MPU system like boot allocator, whilst we need to implement some components differently in MPU, like xenheap, etc. There are some components that is specific to MMU only, like direct-mapping. In the commit, we move MMU-specific components into mmu/setup.c, in preparation of implementing MPU version of setup_mm later in future commit. Also, make init_pdx(), init_staticmem_pages(), setup_mm(), and populate_boot_allocator() public for future MPU inplementation. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen Signed-off-by: Henry Wang --- v4: - No change --- xen/arch/arm/include/asm/setup.h | 5 + xen/arch/arm/mmu/Makefile | 1 + xen/arch/arm/mmu/setup.c | 339 +++++++++++++++++++++++++++++++ xen/arch/arm/setup.c | 326 +---------------------------- 4 files changed, 349 insertions(+), 322 deletions(-) create mode 100644 xen/arch/arm/mmu/setup.c diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index f0f64d228c..0922549631 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -156,6 +156,11 @@ struct bootcmdline *boot_cmdline_find_by_kind(bootmodule_kind kind); struct bootcmdline * boot_cmdline_find_by_name(const char *name); const char *boot_module_kind_as_string(bootmodule_kind kind); +extern void init_pdx(void); +extern void init_staticmem_pages(void); +extern void populate_boot_allocator(void); +extern void setup_mm(void); + extern uint32_t hyp_traps_vector[]; void init_traps(void); diff --git a/xen/arch/arm/mmu/Makefile b/xen/arch/arm/mmu/Makefile index b18cec4836..4aa1fb466d 100644 --- a/xen/arch/arm/mmu/Makefile +++ b/xen/arch/arm/mmu/Makefile @@ -1 +1,2 @@ obj-y += mm.o +obj-y += setup.o diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c new file mode 100644 index 0000000000..e05cca3f86 --- /dev/null +++ b/xen/arch/arm/mmu/setup.c @@ -0,0 +1,339 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * xen/arch/arm/mmu/setup.c + * + * MMU-specific early bringup code for an ARMv7-A with virt extensions. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#ifdef CONFIG_ARM_32 +static unsigned long opt_xenheap_megabytes __initdata; +integer_param("xenheap_megabytes", opt_xenheap_megabytes); + +/* + * Returns the end address of the highest region in the range s..e + * with required size and alignment that does not conflict with the + * modules from first_mod to nr_modules. + * + * For non-recursive callers first_mod should normally be 0 (all + * modules and Xen itself) or 1 (all modules but not Xen). + */ +static paddr_t __init consider_modules(paddr_t s, paddr_t e, + uint32_t size, paddr_t align, + int first_mod) +{ + const struct bootmodules *mi = &bootinfo.modules; + int i; + int nr; + + s = (s+align-1) & ~(align-1); + e = e & ~(align-1); + + if ( s > e || e - s < size ) + return 0; + + /* First check the boot modules */ + for ( i = first_mod; i < mi->nr_mods; i++ ) + { + paddr_t mod_s = mi->module[i].start; + paddr_t mod_e = mod_s + mi->module[i].size; + + if ( s < mod_e && mod_s < e ) + { + mod_e = consider_modules(mod_e, e, size, align, i+1); + if ( mod_e ) + return mod_e; + + return consider_modules(s, mod_s, size, align, i+1); + } + } + + /* Now check any fdt reserved areas. */ + + nr = fdt_num_mem_rsv(device_tree_flattened); + + for ( ; i < mi->nr_mods + nr; i++ ) + { + paddr_t mod_s, mod_e; + + if ( fdt_get_mem_rsv_paddr(device_tree_flattened, + i - mi->nr_mods, + &mod_s, &mod_e ) < 0 ) + /* If we can't read it, pretend it doesn't exist... */ + continue; + + /* fdt_get_mem_rsv_paddr returns length */ + mod_e += mod_s; + + if ( s < mod_e && mod_s < e ) + { + mod_e = consider_modules(mod_e, e, size, align, i+1); + if ( mod_e ) + return mod_e; + + return consider_modules(s, mod_s, size, align, i+1); + } + } + + /* + * i is the current bootmodule we are evaluating, across all + * possible kinds of bootmodules. + * + * When retrieving the corresponding reserved-memory addresses, we + * need to index the bootinfo.reserved_mem bank starting from 0, and + * only counting the reserved-memory modules. Hence, we need to use + * i - nr. + */ + nr += mi->nr_mods; + for ( ; i - nr < bootinfo.reserved_mem.nr_banks; i++ ) + { + paddr_t r_s = bootinfo.reserved_mem.bank[i - nr].start; + paddr_t r_e = r_s + bootinfo.reserved_mem.bank[i - nr].size; + + if ( s < r_e && r_s < e ) + { + r_e = consider_modules(r_e, e, size, align, i + 1); + if ( r_e ) + return r_e; + + return consider_modules(s, r_s, size, align, i + 1); + } + } + return e; +} + +/* + * Find a contiguous region that fits in the static heap region with + * required size and alignment, and return the end address of the region + * if found otherwise 0. + */ +static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) +{ + unsigned int i; + paddr_t end = 0, aligned_start, aligned_end; + paddr_t bank_start, bank_size, bank_end; + + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + if ( bank_size < size ) + continue; + + aligned_end = bank_end & ~(align - 1); + aligned_start = (aligned_end - size) & ~(align - 1); + + if ( aligned_start > bank_start ) + /* + * Allocate the xenheap as high as possible to keep low-memory + * available (assuming the admin supplied region below 4GB) + * for other use (e.g. domain memory allocation). + */ + end = max(end, aligned_end); + } + + return end; +} + +void __init setup_mm(void) +{ + paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; + paddr_t static_heap_end = 0, static_heap_size = 0; + unsigned long heap_pages, xenheap_pages, domheap_pages; + unsigned int i; + const uint32_t ctr = READ_CP32(CTR); + + if ( !bootinfo.mem.nr_banks ) + panic("No memory bank\n"); + + /* We only supports instruction caches implementing the IVIPT extension. */ + if ( ((ctr >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK) == ICACHE_POLICY_AIVIVT ) + panic("AIVIVT instruction cache not supported\n"); + + init_pdx(); + + ram_start = bootinfo.mem.bank[0].start; + ram_size = bootinfo.mem.bank[0].size; + ram_end = ram_start + ram_size; + + for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) + { + bank_start = bootinfo.mem.bank[i].start; + bank_size = bootinfo.mem.bank[i].size; + bank_end = bank_start + bank_size; + + ram_size = ram_size + bank_size; + ram_start = min(ram_start,bank_start); + ram_end = max(ram_end,bank_end); + } + + total_pages = ram_size >> PAGE_SHIFT; + + if ( bootinfo.static_heap ) + { + for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) + continue; + + bank_start = bootinfo.reserved_mem.bank[i].start; + bank_size = bootinfo.reserved_mem.bank[i].size; + bank_end = bank_start + bank_size; + + static_heap_size += bank_size; + static_heap_end = max(static_heap_end, bank_end); + } + + heap_pages = static_heap_size >> PAGE_SHIFT; + } + else + heap_pages = total_pages; + + /* + * If the user has not requested otherwise via the command line + * then locate the xenheap using these constraints: + * + * - must be contiguous + * - must be 32 MiB aligned + * - must not include Xen itself or the boot modules + * - must be at most 1GB or 1/32 the total RAM in the system (or static + heap if enabled) if less + * - must be at least 32M + * + * We try to allocate the largest xenheap possible within these + * constraints. + */ + if ( opt_xenheap_megabytes ) + xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); + else + { + xenheap_pages = (heap_pages/32 + 0x1fffUL) & ~0x1fffUL; + xenheap_pages = max(xenheap_pages, 32UL<<(20-PAGE_SHIFT)); + xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); + } + + do + { + e = bootinfo.static_heap ? + fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : + consider_modules(ram_start, ram_end, + pfn_to_paddr(xenheap_pages), + 32<<20, 0); + if ( e ) + break; + + xenheap_pages >>= 1; + } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); + + if ( ! e ) + panic("Not enough space for xenheap\n"); + + domheap_pages = heap_pages - xenheap_pages; + + printk("Xen heap: %"PRIpaddr"-%"PRIpaddr" (%lu pages%s)\n", + e - (pfn_to_paddr(xenheap_pages)), e, xenheap_pages, + opt_xenheap_megabytes ? ", from command-line" : ""); + printk("Dom heap: %lu pages\n", domheap_pages); + + /* + * We need some memory to allocate the page-tables used for the + * directmap mappings. So populate the boot allocator first. + * + * This requires us to set directmap_mfn_{start, end} first so the + * direct-mapped Xenheap region can be avoided. + */ + directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); + + populate_boot_allocator(); + + setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); + + /* Frame table covers all of RAM region, including holes */ + setup_frametable_mappings(ram_start, ram_end); + max_page = PFN_DOWN(ram_end); + + /* + * The allocators may need to use map_domain_page() (such as for + * scrubbing pages). So we need to prepare the domheap area first. + */ + if ( !init_domheap_mappings(smp_processor_id()) ) + panic("CPU%u: Unable to prepare the domheap page-tables\n", + smp_processor_id()); + + /* Add xenheap memory that was not already added to the boot allocator. */ + init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), + mfn_to_maddr(directmap_mfn_end)); + + init_staticmem_pages(); +} +#else /* CONFIG_ARM_64 */ +void __init setup_mm(void) +{ + const struct meminfo *banks = &bootinfo.mem; + paddr_t ram_start = INVALID_PADDR; + paddr_t ram_end = 0; + paddr_t ram_size = 0; + unsigned int i; + + init_pdx(); + + /* + * We need some memory to allocate the page-tables used for the directmap + * mappings. But some regions may contain memory already allocated + * for other uses (e.g. modules, reserved-memory...). + * + * For simplicity, add all the free regions in the boot allocator. + */ + populate_boot_allocator(); + + total_pages = 0; + + for ( i = 0; i < banks->nr_banks; i++ ) + { + const struct membank *bank = &banks->bank[i]; + paddr_t bank_end = bank->start + bank->size; + + ram_size = ram_size + bank->size; + ram_start = min(ram_start, bank->start); + ram_end = max(ram_end, bank_end); + + setup_directmap_mappings(PFN_DOWN(bank->start), + PFN_DOWN(bank->size)); + } + + total_pages += ram_size >> PAGE_SHIFT; + + directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; + directmap_mfn_start = maddr_to_mfn(ram_start); + directmap_mfn_end = maddr_to_mfn(ram_end); + + setup_frametable_mappings(ram_start, ram_end); + max_page = PFN_DOWN(ram_end); + + init_staticmem_pages(); +} +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index bbf72b69aa..50259552a0 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -2,7 +2,7 @@ /* * xen/arch/arm/setup.c * - * Early bringup code for an ARMv7-A with virt extensions. + * Early bringup code for an ARMv7-A/ARM64v8R with virt extensions. * * Tim Deegan * Copyright (c) 2011 Citrix Systems. @@ -57,11 +57,6 @@ struct cpuinfo_arm __read_mostly system_cpuinfo; bool __read_mostly acpi_disabled; #endif -#ifdef CONFIG_ARM_32 -static unsigned long opt_xenheap_megabytes __initdata; -integer_param("xenheap_megabytes", opt_xenheap_megabytes); -#endif - domid_t __read_mostly max_init_domid; static __used void init_done(void) @@ -546,138 +541,6 @@ static void * __init relocate_fdt(paddr_t dtb_paddr, size_t dtb_size) return fdt; } -#ifdef CONFIG_ARM_32 -/* - * Returns the end address of the highest region in the range s..e - * with required size and alignment that does not conflict with the - * modules from first_mod to nr_modules. - * - * For non-recursive callers first_mod should normally be 0 (all - * modules and Xen itself) or 1 (all modules but not Xen). - */ -static paddr_t __init consider_modules(paddr_t s, paddr_t e, - uint32_t size, paddr_t align, - int first_mod) -{ - const struct bootmodules *mi = &bootinfo.modules; - int i; - int nr; - - s = (s+align-1) & ~(align-1); - e = e & ~(align-1); - - if ( s > e || e - s < size ) - return 0; - - /* First check the boot modules */ - for ( i = first_mod; i < mi->nr_mods; i++ ) - { - paddr_t mod_s = mi->module[i].start; - paddr_t mod_e = mod_s + mi->module[i].size; - - if ( s < mod_e && mod_s < e ) - { - mod_e = consider_modules(mod_e, e, size, align, i+1); - if ( mod_e ) - return mod_e; - - return consider_modules(s, mod_s, size, align, i+1); - } - } - - /* Now check any fdt reserved areas. */ - - nr = fdt_num_mem_rsv(device_tree_flattened); - - for ( ; i < mi->nr_mods + nr; i++ ) - { - paddr_t mod_s, mod_e; - - if ( fdt_get_mem_rsv_paddr(device_tree_flattened, - i - mi->nr_mods, - &mod_s, &mod_e ) < 0 ) - /* If we can't read it, pretend it doesn't exist... */ - continue; - - /* fdt_get_mem_rsv_paddr returns length */ - mod_e += mod_s; - - if ( s < mod_e && mod_s < e ) - { - mod_e = consider_modules(mod_e, e, size, align, i+1); - if ( mod_e ) - return mod_e; - - return consider_modules(s, mod_s, size, align, i+1); - } - } - - /* - * i is the current bootmodule we are evaluating, across all - * possible kinds of bootmodules. - * - * When retrieving the corresponding reserved-memory addresses, we - * need to index the bootinfo.reserved_mem bank starting from 0, and - * only counting the reserved-memory modules. Hence, we need to use - * i - nr. - */ - nr += mi->nr_mods; - for ( ; i - nr < bootinfo.reserved_mem.nr_banks; i++ ) - { - paddr_t r_s = bootinfo.reserved_mem.bank[i - nr].start; - paddr_t r_e = r_s + bootinfo.reserved_mem.bank[i - nr].size; - - if ( s < r_e && r_s < e ) - { - r_e = consider_modules(r_e, e, size, align, i + 1); - if ( r_e ) - return r_e; - - return consider_modules(s, r_s, size, align, i + 1); - } - } - return e; -} - -/* - * Find a contiguous region that fits in the static heap region with - * required size and alignment, and return the end address of the region - * if found otherwise 0. - */ -static paddr_t __init fit_xenheap_in_static_heap(uint32_t size, paddr_t align) -{ - unsigned int i; - paddr_t end = 0, aligned_start, aligned_end; - paddr_t bank_start, bank_size, bank_end; - - for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) - { - if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) - continue; - - bank_start = bootinfo.reserved_mem.bank[i].start; - bank_size = bootinfo.reserved_mem.bank[i].size; - bank_end = bank_start + bank_size; - - if ( bank_size < size ) - continue; - - aligned_end = bank_end & ~(align - 1); - aligned_start = (aligned_end - size) & ~(align - 1); - - if ( aligned_start > bank_start ) - /* - * Allocate the xenheap as high as possible to keep low-memory - * available (assuming the admin supplied region below 4GB) - * for other use (e.g. domain memory allocation). - */ - end = max(end, aligned_end); - } - - return end; -} -#endif - /* * Return the end of the non-module region starting at s. In other * words return s the start of the next modules after s. @@ -712,7 +575,7 @@ static paddr_t __init next_module(paddr_t s, paddr_t *end) return lowest; } -static void __init init_pdx(void) +void __init init_pdx(void) { paddr_t bank_start, bank_size, bank_end; @@ -757,7 +620,7 @@ static void __init init_pdx(void) } /* Static memory initialization */ -static void __init init_staticmem_pages(void) +void __init init_staticmem_pages(void) { #ifdef CONFIG_STATIC_MEMORY unsigned int bank; @@ -791,7 +654,7 @@ static void __init init_staticmem_pages(void) * allocator with the corresponding regions only, but with Xenheap excluded * on arm32. */ -static void __init populate_boot_allocator(void) +void __init populate_boot_allocator(void) { unsigned int i; const struct meminfo *banks = &bootinfo.mem; @@ -860,187 +723,6 @@ static void __init populate_boot_allocator(void) } } -#ifdef CONFIG_ARM_32 -static void __init setup_mm(void) -{ - paddr_t ram_start, ram_end, ram_size, e, bank_start, bank_end, bank_size; - paddr_t static_heap_end = 0, static_heap_size = 0; - unsigned long heap_pages, xenheap_pages, domheap_pages; - unsigned int i; - const uint32_t ctr = READ_CP32(CTR); - - if ( !bootinfo.mem.nr_banks ) - panic("No memory bank\n"); - - /* We only supports instruction caches implementing the IVIPT extension. */ - if ( ((ctr >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK) == ICACHE_POLICY_AIVIVT ) - panic("AIVIVT instruction cache not supported\n"); - - init_pdx(); - - ram_start = bootinfo.mem.bank[0].start; - ram_size = bootinfo.mem.bank[0].size; - ram_end = ram_start + ram_size; - - for ( i = 1; i < bootinfo.mem.nr_banks; i++ ) - { - bank_start = bootinfo.mem.bank[i].start; - bank_size = bootinfo.mem.bank[i].size; - bank_end = bank_start + bank_size; - - ram_size = ram_size + bank_size; - ram_start = min(ram_start,bank_start); - ram_end = max(ram_end,bank_end); - } - - total_pages = ram_size >> PAGE_SHIFT; - - if ( bootinfo.static_heap ) - { - for ( i = 0 ; i < bootinfo.reserved_mem.nr_banks; i++ ) - { - if ( bootinfo.reserved_mem.bank[i].type != MEMBANK_STATIC_HEAP ) - continue; - - bank_start = bootinfo.reserved_mem.bank[i].start; - bank_size = bootinfo.reserved_mem.bank[i].size; - bank_end = bank_start + bank_size; - - static_heap_size += bank_size; - static_heap_end = max(static_heap_end, bank_end); - } - - heap_pages = static_heap_size >> PAGE_SHIFT; - } - else - heap_pages = total_pages; - - /* - * If the user has not requested otherwise via the command line - * then locate the xenheap using these constraints: - * - * - must be contiguous - * - must be 32 MiB aligned - * - must not include Xen itself or the boot modules - * - must be at most 1GB or 1/32 the total RAM in the system (or static - heap if enabled) if less - * - must be at least 32M - * - * We try to allocate the largest xenheap possible within these - * constraints. - */ - if ( opt_xenheap_megabytes ) - xenheap_pages = opt_xenheap_megabytes << (20-PAGE_SHIFT); - else - { - xenheap_pages = (heap_pages/32 + 0x1fffUL) & ~0x1fffUL; - xenheap_pages = max(xenheap_pages, 32UL<<(20-PAGE_SHIFT)); - xenheap_pages = min(xenheap_pages, 1UL<<(30-PAGE_SHIFT)); - } - - do - { - e = bootinfo.static_heap ? - fit_xenheap_in_static_heap(pfn_to_paddr(xenheap_pages), MB(32)) : - consider_modules(ram_start, ram_end, - pfn_to_paddr(xenheap_pages), - 32<<20, 0); - if ( e ) - break; - - xenheap_pages >>= 1; - } while ( !opt_xenheap_megabytes && xenheap_pages > 32<<(20-PAGE_SHIFT) ); - - if ( ! e ) - panic("Not enough space for xenheap\n"); - - domheap_pages = heap_pages - xenheap_pages; - - printk("Xen heap: %"PRIpaddr"-%"PRIpaddr" (%lu pages%s)\n", - e - (pfn_to_paddr(xenheap_pages)), e, xenheap_pages, - opt_xenheap_megabytes ? ", from command-line" : ""); - printk("Dom heap: %lu pages\n", domheap_pages); - - /* - * We need some memory to allocate the page-tables used for the - * directmap mappings. So populate the boot allocator first. - * - * This requires us to set directmap_mfn_{start, end} first so the - * direct-mapped Xenheap region can be avoided. - */ - directmap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); - directmap_mfn_end = mfn_add(directmap_mfn_start, xenheap_pages); - - populate_boot_allocator(); - - setup_directmap_mappings(mfn_x(directmap_mfn_start), xenheap_pages); - - /* Frame table covers all of RAM region, including holes */ - setup_frametable_mappings(ram_start, ram_end); - max_page = PFN_DOWN(ram_end); - - /* - * The allocators may need to use map_domain_page() (such as for - * scrubbing pages). So we need to prepare the domheap area first. - */ - if ( !init_domheap_mappings(smp_processor_id()) ) - panic("CPU%u: Unable to prepare the domheap page-tables\n", - smp_processor_id()); - - /* Add xenheap memory that was not already added to the boot allocator. */ - init_xenheap_pages(mfn_to_maddr(directmap_mfn_start), - mfn_to_maddr(directmap_mfn_end)); - - init_staticmem_pages(); -} -#else /* CONFIG_ARM_64 */ -static void __init setup_mm(void) -{ - const struct meminfo *banks = &bootinfo.mem; - paddr_t ram_start = INVALID_PADDR; - paddr_t ram_end = 0; - paddr_t ram_size = 0; - unsigned int i; - - init_pdx(); - - /* - * We need some memory to allocate the page-tables used for the directmap - * mappings. But some regions may contain memory already allocated - * for other uses (e.g. modules, reserved-memory...). - * - * For simplicity, add all the free regions in the boot allocator. - */ - populate_boot_allocator(); - - total_pages = 0; - - for ( i = 0; i < banks->nr_banks; i++ ) - { - const struct membank *bank = &banks->bank[i]; - paddr_t bank_end = bank->start + bank->size; - - ram_size = ram_size + bank->size; - ram_start = min(ram_start, bank->start); - ram_end = max(ram_end, bank_end); - - setup_directmap_mappings(PFN_DOWN(bank->start), - PFN_DOWN(bank->size)); - } - - total_pages += ram_size >> PAGE_SHIFT; - - directmap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; - directmap_mfn_start = maddr_to_mfn(ram_start); - directmap_mfn_end = maddr_to_mfn(ram_end); - - setup_frametable_mappings(ram_start, ram_end); - max_page = PFN_DOWN(ram_end); - - init_staticmem_pages(); -} -#endif - static bool __init is_dom0less_mode(void) { struct bootmodules *mods = &bootinfo.modules; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:48:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:48:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573583.898441 (Exim 4.92) (envelope-from ) id 1qQgMj-0003bD-J9; Tue, 01 Aug 2023 03:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573583.898441; Tue, 01 Aug 2023 03:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgMj-0003b6-GY; Tue, 01 Aug 2023 03:48:09 +0000 Received: by outflank-mailman (input) for mailman id 573583; Tue, 01 Aug 2023 03:48:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJo-00076X-By for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id cd9379c6-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:45:05 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 916E911FB; Mon, 31 Jul 2023 20:45:48 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 431153F59C; Mon, 31 Jul 2023 20:45:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd9379c6-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Henry Wang Subject: [PATCH v4 08/13] xen/arm: Fold pmap and fixmap into MMU system Date: Tue, 1 Aug 2023 11:44:14 +0800 Message-Id: <20230801034419.2047541-9-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng fixmap and pmap are MMU-specific features, so fold them to MMU system. Do the folding for pmap by moving the HAS_PMAP Kconfig selection under HAS_MMU. Do the folding for fixmap by moving the implementation of virt_to_fix() to mmu/mm.c, so that unnecessary stubs can be avoided. Signed-off-by: Penny Zheng Signed-off-by: Henry Wang --- v4: - Rework "[v3,11/52] xen/arm: mmu: fold FIXMAP into MMU system", change the order of this patch and avoid introducing stubs. --- xen/arch/arm/Kconfig | 2 +- xen/arch/arm/include/asm/fixmap.h | 7 +------ xen/arch/arm/mmu/mm.c | 7 +++++++ 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 0e38e9ba17..1b60a938c2 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -15,7 +15,6 @@ config ARM select HAS_DEVICE_TREE select HAS_PASSTHROUGH select HAS_PDX - select HAS_PMAP select HAS_UBSAN select IOMMU_FORCE_PT_SHARE @@ -71,6 +70,7 @@ choice config HAS_MMU bool "MMU for a VMSA system" + select HAS_PMAP endchoice source "arch/Kconfig" diff --git a/xen/arch/arm/include/asm/fixmap.h b/xen/arch/arm/include/asm/fixmap.h index 734eb9b1d4..5d5de6995a 100644 --- a/xen/arch/arm/include/asm/fixmap.h +++ b/xen/arch/arm/include/asm/fixmap.h @@ -36,12 +36,7 @@ extern void clear_fixmap(unsigned int map); #define fix_to_virt(slot) ((void *)FIXMAP_ADDR(slot)) -static inline unsigned int virt_to_fix(vaddr_t vaddr) -{ - BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START); - - return ((vaddr - FIXADDR_START) >> PAGE_SHIFT); -} +extern unsigned int virt_to_fix(vaddr_t vaddr); #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/arm/mmu/mm.c b/xen/arch/arm/mmu/mm.c index b70982e9d6..1d6267e6c5 100644 --- a/xen/arch/arm/mmu/mm.c +++ b/xen/arch/arm/mmu/mm.c @@ -1136,6 +1136,13 @@ int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); } +unsigned int virt_to_fix(vaddr_t vaddr) +{ + BUG_ON(vaddr >= FIXADDR_TOP || vaddr < FIXADDR_START); + + return ((vaddr - FIXADDR_START) >> PAGE_SHIFT); +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:48:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:48:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573593.898452 (Exim 4.92) (envelope-from ) id 1qQgNV-0004C5-VJ; Tue, 01 Aug 2023 03:48:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573593.898452; Tue, 01 Aug 2023 03:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgNV-0004By-SN; Tue, 01 Aug 2023 03:48:57 +0000 Received: by outflank-mailman (input) for mailman id 573593; Tue, 01 Aug 2023 03:48:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgJs-00076X-PJ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:12 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d010a705-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:45:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C7FADD75; Mon, 31 Jul 2023 20:45:52 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 79AA93F59C; Mon, 31 Jul 2023 20:45:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d010a705-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Volodymyr Babchuk , Henry Wang Subject: [PATCH v4 09/13] xen/arm: mm: Use generic variable/function names for extendability Date: Tue, 1 Aug 2023 11:44:15 +0800 Message-Id: <20230801034419.2047541-10-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng As preparation for MPU support, which will use some variables/functions for both MMU and MPU system, We rename the affected variable/function to more generic names: - init_ttbr -> init_mm, - mmu_init_secondary_cpu() -> mm_init_secondary_cpu() - init_secondary_pagetables() -> init_secondary_mm() - Add a wrapper update_mm_mapping() for MMU system's update_identity_mapping() Modify the related in-code comment to reflect above changes, take the opportunity to fix the incorrect coding style of the in-code comments. Signed-off-by: Penny Zheng Signed-off-by: Henry Wang --- v4: - Extract the renaming part from the original patch: "[v3,13/52] xen/mmu: extract mmu-specific codes from mm.c/mm.h" --- xen/arch/arm/arm32/head.S | 4 ++-- xen/arch/arm/arm64/mmu/head.S | 2 +- xen/arch/arm/arm64/mmu/mm.c | 11 ++++++++--- xen/arch/arm/arm64/smpboot.c | 6 +++--- xen/arch/arm/include/asm/arm64/mm.h | 7 ++++--- xen/arch/arm/include/asm/mm.h | 10 ++++++---- xen/arch/arm/mmu/mm.c | 20 ++++++++++---------- xen/arch/arm/smpboot.c | 4 ++-- 8 files changed, 36 insertions(+), 28 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 33b038e7e0..03ab68578a 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -238,11 +238,11 @@ GLOBAL(init_secondary) secondary_switched: /* * Non-boot CPUs need to move on to the proper pagetables, which were - * setup in init_secondary_pagetables. + * setup in init_secondary_mm. * * XXX: This is not compliant with the Arm Arm. */ - mov_w r4, init_ttbr /* VA of HTTBR value stashed by CPU 0 */ + mov_w r4, init_mm /* VA of HTTBR value stashed by CPU 0 */ ldrd r4, r5, [r4] /* Actual value */ dsb mcrr CP64(r4, r5, HTTBR) diff --git a/xen/arch/arm/arm64/mmu/head.S b/xen/arch/arm/arm64/mmu/head.S index 6bd94c3a45..6e638ff082 100644 --- a/xen/arch/arm/arm64/mmu/head.S +++ b/xen/arch/arm/arm64/mmu/head.S @@ -303,7 +303,7 @@ ENDPROC(enable_mmu) ENTRY(enable_secondary_cpu_mm) mov x5, lr - load_paddr x0, init_ttbr + load_paddr x0, init_mm ldr x0, [x0] bl enable_mmu diff --git a/xen/arch/arm/arm64/mmu/mm.c b/xen/arch/arm/arm64/mmu/mm.c index 78b7c7eb00..ed0fc5ff7b 100644 --- a/xen/arch/arm/arm64/mmu/mm.c +++ b/xen/arch/arm/arm64/mmu/mm.c @@ -106,7 +106,7 @@ void __init arch_setup_page_tables(void) prepare_runtime_identity_mapping(); } -void update_identity_mapping(bool enable) +static void update_identity_mapping(bool enable) { paddr_t id_addr = virt_to_maddr(_start); int rc; @@ -120,6 +120,11 @@ void update_identity_mapping(bool enable) BUG_ON(rc); } +void update_mm_mapping(bool enable) +{ + update_identity_mapping(enable); +} + extern void switch_ttbr_id(uint64_t ttbr); typedef void (switch_ttbr_fn)(uint64_t ttbr); @@ -131,7 +136,7 @@ void __init switch_ttbr(uint64_t ttbr) lpae_t pte; /* Enable the identity mapping in the boot page tables */ - update_identity_mapping(true); + update_mm_mapping(true); /* Enable the identity mapping in the runtime page tables */ pte = pte_of_xenaddr((vaddr_t)switch_ttbr_id); @@ -148,7 +153,7 @@ void __init switch_ttbr(uint64_t ttbr) * Note it is not necessary to disable it in the boot page tables * because they are not going to be used by this CPU anymore. */ - update_identity_mapping(false); + update_mm_mapping(false); } /* diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c index 9637f42469..2b1d086a1e 100644 --- a/xen/arch/arm/arm64/smpboot.c +++ b/xen/arch/arm/arm64/smpboot.c @@ -111,18 +111,18 @@ int arch_cpu_up(int cpu) if ( !smp_enable_ops[cpu].prepare_cpu ) return -ENODEV; - update_identity_mapping(true); + update_mm_mapping(true); rc = smp_enable_ops[cpu].prepare_cpu(cpu); if ( rc ) - update_identity_mapping(false); + update_mm_mapping(false); return rc; } void arch_cpu_up_finish(void) { - update_identity_mapping(false); + update_mm_mapping(false); } /* diff --git a/xen/arch/arm/include/asm/arm64/mm.h b/xen/arch/arm/include/asm/arm64/mm.h index e0bd23a6ed..7a389c4b21 100644 --- a/xen/arch/arm/include/asm/arm64/mm.h +++ b/xen/arch/arm/include/asm/arm64/mm.h @@ -15,13 +15,14 @@ static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr) void arch_setup_page_tables(void); /* - * Enable/disable the identity mapping in the live page-tables (i.e. - * the one pointed by TTBR_EL2). + * In MMU system, enable/disable the identity mapping in the live + * page-tables (i.e. the one pointed by TTBR_EL2) through + * update_identity_mapping(). * * Note that nested call (e.g. enable=true, enable=true) is not * supported. */ -void update_identity_mapping(bool enable); +void update_mm_mapping(bool enable); #endif /* __ARM_ARM64_MM_H__ */ diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index e70ce4dc61..2b61a89b9f 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -205,11 +205,13 @@ extern void setup_pagetables(unsigned long boot_phys_offset); extern void *early_fdt_map(paddr_t fdt_paddr); /* Remove early mappings */ extern void remove_early_mappings(void); -/* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the - * new page table */ -extern int init_secondary_pagetables(int cpu); +/* + * Allocate and initialise pagetables for a secondary CPU. Sets init_mm to the + * new page table + */ +extern int init_secondary_mm(int cpu); /* Switch secondary CPUS to its own pagetables and finalise MMU setup */ -extern void mmu_init_secondary_cpu(void); +extern void mm_init_secondary_cpu(void); /* Map a frame table to cover physical addresses ps through pe */ extern void setup_frametable_mappings(paddr_t ps, paddr_t pe); /* map a physical range in virtual memory */ diff --git a/xen/arch/arm/mmu/mm.c b/xen/arch/arm/mmu/mm.c index 1d6267e6c5..7486c35ec0 100644 --- a/xen/arch/arm/mmu/mm.c +++ b/xen/arch/arm/mmu/mm.c @@ -106,7 +106,7 @@ DEFINE_BOOT_PAGE_TABLE(xen_fixmap); static DEFINE_PAGE_TABLES(xen_xenmap, XEN_NR_ENTRIES(2)); /* Non-boot CPUs use this to find the correct pagetables. */ -uint64_t init_ttbr; +uint64_t init_mm; static paddr_t phys_offset; @@ -492,18 +492,18 @@ static void clear_boot_pagetables(void) } #ifdef CONFIG_ARM_64 -int init_secondary_pagetables(int cpu) +int init_secondary_mm(int cpu) { clear_boot_pagetables(); - /* Set init_ttbr for this CPU coming up. All CPus share a single setof + /* Set init_mm for this CPU coming up. All CPus share a single setof * pagetables, but rewrite it each time for consistency with 32 bit. */ - init_ttbr = (uintptr_t) xen_pgtable + phys_offset; - clean_dcache(init_ttbr); + init_mm = (uintptr_t) xen_pgtable + phys_offset; + clean_dcache(init_mm); return 0; } #else -int init_secondary_pagetables(int cpu) +int init_secondary_mm(int cpu) { lpae_t *first; @@ -529,16 +529,16 @@ int init_secondary_pagetables(int cpu) clear_boot_pagetables(); - /* Set init_ttbr for this CPU coming up */ - init_ttbr = __pa(first); - clean_dcache(init_ttbr); + /* Set init_mm for this CPU coming up */ + init_mm = __pa(first); + clean_dcache(init_mm); return 0; } #endif /* MMU setup for secondary CPUS (which already have paging enabled) */ -void mmu_init_secondary_cpu(void) +void mm_init_secondary_cpu(void) { xen_pt_enforce_wnx(); } diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c index e107b86b7b..8bcdbea66c 100644 --- a/xen/arch/arm/smpboot.c +++ b/xen/arch/arm/smpboot.c @@ -359,7 +359,7 @@ void start_secondary(void) */ update_system_features(¤t_cpu_data); - mmu_init_secondary_cpu(); + mm_init_secondary_cpu(); gic_init_secondary_cpu(); @@ -448,7 +448,7 @@ int __cpu_up(unsigned int cpu) printk("Bringing up CPU%d\n", cpu); - rc = init_secondary_pagetables(cpu); + rc = init_secondary_mm(cpu); if ( rc < 0 ) return rc; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:48:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:48:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573597.898462 (Exim 4.92) (envelope-from ) id 1qQgNX-0004SX-6U; Tue, 01 Aug 2023 03:48:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573597.898462; Tue, 01 Aug 2023 03:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgNX-0004SM-33; Tue, 01 Aug 2023 03:48:59 +0000 Received: by outflank-mailman (input) for mailman id 573597; Tue, 01 Aug 2023 03:48:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgK1-00076X-RX for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:22 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d50ef150-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:45:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B43BD75; Mon, 31 Jul 2023 20:46:01 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8659A3F59C; Mon, 31 Jul 2023 20:45:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d50ef150-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen , Henry Wang Subject: [PATCH v4 11/13] xen/arm: mmu: move MMU specific P2M code to mmu/p2m.{c,h} Date: Tue, 1 Aug 2023 11:44:17 +0800 Message-Id: <20230801034419.2047541-12-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng Current P2M implementation is designed for MMU system only. We move the MMU-specific codes into mmu/p2m.c, and only keep generic codes in p2m.c, like VMID allocator, etc. We also move MMU-specific definitions and declarations to mmu/p2m.h, such as p2m_tlb_flush_sync(). Also expose previously static functions p2m_vmid_allocator_init(), p2m_alloc_vmid(), __p2m_set_entry() and setup_virt_paging_one() for futher MPU usage. With the code movement, global variable max_vmid is used in multiple files instead of a single file (and will be used in MPU P2M implementation), declare it in the header and remove the "static" of this variable. Add #ifdef CONFIG_HAS_MMU to p2m_write_unlock() since future MPU work does not need p2m_tlb_flush_sync(). Signed-off-by: Penny Zheng Signed-off-by: Wei Chen Signed-off-by: Henry Wang --- v4: - Rework the patch to drop the unnecessary changes. - Rework the commit msg a bit. v3: - remove MPU stubs - adapt to the introduction of new directories: mmu/ v2: - new commit --- xen/arch/arm/include/asm/mmu/p2m.h | 18 + xen/arch/arm/include/asm/p2m.h | 33 +- xen/arch/arm/mmu/Makefile | 1 + xen/arch/arm/mmu/p2m.c | 1610 +++++++++++++++++++++++++ xen/arch/arm/p2m.c | 1772 ++-------------------------- 5 files changed, 1745 insertions(+), 1689 deletions(-) create mode 100644 xen/arch/arm/include/asm/mmu/p2m.h create mode 100644 xen/arch/arm/mmu/p2m.c diff --git a/xen/arch/arm/include/asm/mmu/p2m.h b/xen/arch/arm/include/asm/mmu/p2m.h new file mode 100644 index 0000000000..f829e325ce --- /dev/null +++ b/xen/arch/arm/include/asm/mmu/p2m.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#ifndef __ARM_MMU_P2M_H__ +#define __ARM_MMU_P2M_H__ + +struct p2m_domain; +void p2m_force_tlb_flush_sync(struct p2m_domain *p2m); +void p2m_tlb_flush_sync(struct p2m_domain *p2m); + +#endif /* __ARM_MMU_P2M_H__ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h index 940495d42b..37401461fa 100644 --- a/xen/arch/arm/include/asm/p2m.h +++ b/xen/arch/arm/include/asm/p2m.h @@ -19,6 +19,22 @@ extern unsigned int p2m_root_level; #define P2M_ROOT_ORDER p2m_root_order #define P2M_ROOT_LEVEL p2m_root_level +#define MAX_VMID_8_BIT (1UL << 8) +#define MAX_VMID_16_BIT (1UL << 16) + +#define INVALID_VMID 0 /* VMID 0 is reserved */ + +#ifdef CONFIG_ARM_64 +extern unsigned int max_vmid; +/* VMID is by default 8 bit width on AArch64 */ +#define MAX_VMID max_vmid +#else +/* VMID is always 8 bit width on AArch32 */ +#define MAX_VMID MAX_VMID_8_BIT +#endif + +#define P2M_ROOT_PAGES (1< +#ifdef CONFIG_HAS_MMU +#include +#endif + static inline bool arch_acquire_resource_check(struct domain *d) { /* @@ -180,7 +200,11 @@ void p2m_altp2m_check(struct vcpu *v, uint16_t idx) */ void p2m_restrict_ipa_bits(unsigned int ipa_bits); +void p2m_vmid_allocator_init(void); +int p2m_alloc_vmid(struct domain *d); + /* Second stage paging setup, to be called on all CPUs */ +void setup_virt_paging_one(void *data); void setup_virt_paging(void); /* Init the datastructures for later use by the p2m code */ @@ -242,8 +266,6 @@ static inline int p2m_is_write_locked(struct p2m_domain *p2m) return rw_is_write_locked(&p2m->lock); } -void p2m_tlb_flush_sync(struct p2m_domain *p2m); - /* Look up the MFN corresponding to a domain's GFN. */ mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t); @@ -269,6 +291,13 @@ int p2m_set_entry(struct p2m_domain *p2m, p2m_type_t t, p2m_access_t a); +int __p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned int page_order, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a); + bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn); void p2m_clear_root_pages(struct p2m_domain *p2m); diff --git a/xen/arch/arm/mmu/Makefile b/xen/arch/arm/mmu/Makefile index 4aa1fb466d..a4f07ab90a 100644 --- a/xen/arch/arm/mmu/Makefile +++ b/xen/arch/arm/mmu/Makefile @@ -1,2 +1,3 @@ obj-y += mm.o +obj-y += p2m.o obj-y += setup.o diff --git a/xen/arch/arm/mmu/p2m.c b/xen/arch/arm/mmu/p2m.c new file mode 100644 index 0000000000..a916e2318c --- /dev/null +++ b/xen/arch/arm/mmu/p2m.c @@ -0,0 +1,1610 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include +#include +#include +#include + +#include +#include +#include +#include + +unsigned int __read_mostly p2m_root_order; +unsigned int __read_mostly p2m_root_level; + +static mfn_t __read_mostly empty_root_mfn; + +static uint64_t generate_vttbr(uint16_t vmid, mfn_t root_mfn) +{ + return (mfn_to_maddr(root_mfn) | ((uint64_t)vmid << 48)); +} + +static struct page_info *p2m_alloc_page(struct domain *d) +{ + struct page_info *pg; + + /* + * For hardware domain, there should be no limit in the number of pages that + * can be allocated, so that the kernel may take advantage of the extended + * regions. Hence, allocate p2m pages for hardware domains from heap. + */ + if ( is_hardware_domain(d) ) + { + pg = alloc_domheap_page(NULL, 0); + if ( pg == NULL ) + printk(XENLOG_G_ERR "Failed to allocate P2M pages for hwdom.\n"); + } + else + { + spin_lock(&d->arch.paging.lock); + pg = page_list_remove_head(&d->arch.paging.p2m_freelist); + spin_unlock(&d->arch.paging.lock); + } + + return pg; +} + +static void p2m_free_page(struct domain *d, struct page_info *pg) +{ + if ( is_hardware_domain(d) ) + free_domheap_page(pg); + else + { + spin_lock(&d->arch.paging.lock); + page_list_add_tail(pg, &d->arch.paging.p2m_freelist); + spin_unlock(&d->arch.paging.lock); + } +} + +/* Return the size of the pool, in bytes. */ +int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) +{ + *size = (uint64_t)ACCESS_ONCE(d->arch.paging.p2m_total_pages) << PAGE_SHIFT; + return 0; +} + +/* + * Set the pool of pages to the required number of pages. + * Returns 0 for success, non-zero for failure. + * Call with d->arch.paging.lock held. + */ +int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted) +{ + struct page_info *pg; + + ASSERT(spin_is_locked(&d->arch.paging.lock)); + + for ( ; ; ) + { + if ( d->arch.paging.p2m_total_pages < pages ) + { + /* Need to allocate more memory from domheap */ + pg = alloc_domheap_page(NULL, 0); + if ( pg == NULL ) + { + printk(XENLOG_ERR "Failed to allocate P2M pages.\n"); + return -ENOMEM; + } + ACCESS_ONCE(d->arch.paging.p2m_total_pages) = + d->arch.paging.p2m_total_pages + 1; + page_list_add_tail(pg, &d->arch.paging.p2m_freelist); + } + else if ( d->arch.paging.p2m_total_pages > pages ) + { + /* Need to return memory to domheap */ + pg = page_list_remove_head(&d->arch.paging.p2m_freelist); + if( pg ) + { + ACCESS_ONCE(d->arch.paging.p2m_total_pages) = + d->arch.paging.p2m_total_pages - 1; + free_domheap_page(pg); + } + else + { + printk(XENLOG_ERR + "Failed to free P2M pages, P2M freelist is empty.\n"); + return -ENOMEM; + } + } + else + break; + + /* Check to see if we need to yield and try again */ + if ( preempted && general_preempt_check() ) + { + *preempted = true; + return -ERESTART; + } + } + + return 0; +} + +int arch_set_paging_mempool_size(struct domain *d, uint64_t size) +{ + unsigned long pages = size >> PAGE_SHIFT; + bool preempted = false; + int rc; + + if ( (size & ~PAGE_MASK) || /* Non page-sized request? */ + pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */ + return -EINVAL; + + spin_lock(&d->arch.paging.lock); + rc = p2m_set_allocation(d, pages, &preempted); + spin_unlock(&d->arch.paging.lock); + + ASSERT(preempted == (rc == -ERESTART)); + + return rc; +} + +int p2m_teardown_allocation(struct domain *d) +{ + int ret = 0; + bool preempted = false; + + spin_lock(&d->arch.paging.lock); + if ( d->arch.paging.p2m_total_pages != 0 ) + { + ret = p2m_set_allocation(d, 0, &preempted); + if ( preempted ) + { + spin_unlock(&d->arch.paging.lock); + return -ERESTART; + } + ASSERT(d->arch.paging.p2m_total_pages == 0); + } + spin_unlock(&d->arch.paging.lock); + + return ret; +} + +void p2m_dump_info(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m_read_lock(p2m); + printk("p2m mappings for domain %d (vmid %d):\n", + d->domain_id, p2m->vmid); + BUG_ON(p2m->stats.mappings[0] || p2m->stats.shattered[0]); + printk(" 1G mappings: %ld (shattered %ld)\n", + p2m->stats.mappings[1], p2m->stats.shattered[1]); + printk(" 2M mappings: %ld (shattered %ld)\n", + p2m->stats.mappings[2], p2m->stats.shattered[2]); + printk(" 4K mappings: %ld\n", p2m->stats.mappings[3]); + p2m_read_unlock(p2m); +} + +/* + * p2m_save_state and p2m_restore_state work in pair to workaround + * ARM64_WORKAROUND_AT_SPECULATE. p2m_save_state will set-up VTTBR to + * point to the empty page-tables to stop allocating TLB entries. + */ +void p2m_save_state(struct vcpu *p) +{ + p->arch.sctlr = READ_SYSREG(SCTLR_EL1); + + if ( cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + { + WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); + /* + * Ensure VTTBR_EL2 is correctly synchronized so we can restore + * the next vCPU context without worrying about AT instruction + * speculation. + */ + isb(); + } +} + +void p2m_restore_state(struct vcpu *n) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(n->domain); + uint8_t *last_vcpu_ran; + + if ( is_idle_vcpu(n) ) + return; + + WRITE_SYSREG(n->arch.sctlr, SCTLR_EL1); + WRITE_SYSREG(n->arch.hcr_el2, HCR_EL2); + + /* + * ARM64_WORKAROUND_AT_SPECULATE: VTTBR_EL2 should be restored after all + * registers associated to EL1/EL0 translations regime have been + * synchronized. + */ + asm volatile(ALTERNATIVE("nop", "isb", ARM64_WORKAROUND_AT_SPECULATE)); + WRITE_SYSREG64(p2m->vttbr, VTTBR_EL2); + + last_vcpu_ran = &p2m->last_vcpu_ran[smp_processor_id()]; + + /* + * While we are restoring an out-of-context translation regime + * we still need to ensure: + * - VTTBR_EL2 is synchronized before flushing the TLBs + * - All registers for EL1 are synchronized before executing an AT + * instructions targeting S1/S2. + */ + isb(); + + /* + * Flush local TLB for the domain to prevent wrong TLB translation + * when running multiple vCPU of the same domain on a single pCPU. + */ + if ( *last_vcpu_ran != INVALID_VCPU_ID && *last_vcpu_ran != n->vcpu_id ) + flush_guest_tlb_local(); + + *last_vcpu_ran = n->vcpu_id; +} + +/* + * Force a synchronous P2M TLB flush. + * + * Must be called with the p2m lock held. + */ +void p2m_force_tlb_flush_sync(struct p2m_domain *p2m) +{ + unsigned long flags = 0; + uint64_t ovttbr; + + ASSERT(p2m_is_write_locked(p2m)); + + /* + * ARM only provides an instruction to flush TLBs for the current + * VMID. So switch to the VTTBR of a given P2M if different. + */ + ovttbr = READ_SYSREG64(VTTBR_EL2); + if ( ovttbr != p2m->vttbr ) + { + uint64_t vttbr; + + local_irq_save(flags); + + /* + * ARM64_WORKAROUND_AT_SPECULATE: We need to stop AT to allocate + * TLBs entries because the context is partially modified. We + * only need the VMID for flushing the TLBs, so we can generate + * a new VTTBR with the VMID to flush and the empty root table. + */ + if ( !cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + vttbr = p2m->vttbr; + else + vttbr = generate_vttbr(p2m->vmid, empty_root_mfn); + + WRITE_SYSREG64(vttbr, VTTBR_EL2); + + /* Ensure VTTBR_EL2 is synchronized before flushing the TLBs */ + isb(); + } + + flush_guest_tlb(); + + if ( ovttbr != READ_SYSREG64(VTTBR_EL2) ) + { + WRITE_SYSREG64(ovttbr, VTTBR_EL2); + /* Ensure VTTBR_EL2 is back in place before continuing. */ + isb(); + local_irq_restore(flags); + } + + p2m->need_flush = false; +} + +void p2m_tlb_flush_sync(struct p2m_domain *p2m) +{ + if ( p2m->need_flush ) + p2m_force_tlb_flush_sync(p2m); +} + +/* + * Find and map the root page table. The caller is responsible for + * unmapping the table. + * + * The function will return NULL if the offset of the root table is + * invalid. + */ +static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m, + gfn_t gfn) +{ + unsigned long root_table; + + /* + * While the root table index is the offset from the previous level, + * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be + * 0. Yet we still want to check if all the unused bits are zeroed. + */ + root_table = gfn_x(gfn) >> (XEN_PT_LEVEL_ORDER(P2M_ROOT_LEVEL) + + XEN_PT_LPAE_SHIFT); + if ( root_table >= P2M_ROOT_PAGES ) + return NULL; + + return __map_domain_page(p2m->root + root_table); +} + +/* + * Lookup the MFN corresponding to a domain's GFN. + * Lookup mem access in the ratrix tree. + * The entries associated to the GFN is considered valid. + */ +static p2m_access_t p2m_mem_access_radix_get(struct p2m_domain *p2m, gfn_t gfn) +{ + void *ptr; + + if ( !p2m->mem_access_enabled ) + return p2m->default_access; + + ptr = radix_tree_lookup(&p2m->mem_access_settings, gfn_x(gfn)); + if ( !ptr ) + return p2m_access_rwx; + else + return radix_tree_ptr_to_int(ptr); +} + +/* + * In the case of the P2M, the valid bit is used for other purpose. Use + * the type to check whether an entry is valid. + */ +static inline bool p2m_is_valid(lpae_t pte) +{ + return pte.p2m.type != p2m_invalid; +} + +/* + * lpae_is_* helpers don't check whether the valid bit is set in the + * PTE. Provide our own overlay to check the valid bit. + */ +static inline bool p2m_is_mapping(lpae_t pte, unsigned int level) +{ + return p2m_is_valid(pte) && lpae_is_mapping(pte, level); +} + +static inline bool p2m_is_superpage(lpae_t pte, unsigned int level) +{ + return p2m_is_valid(pte) && lpae_is_superpage(pte, level); +} + +#define GUEST_TABLE_MAP_FAILED 0 +#define GUEST_TABLE_SUPER_PAGE 1 +#define GUEST_TABLE_NORMAL_PAGE 2 + +static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry); + +/* + * Take the currently mapped table, find the corresponding GFN entry, + * and map the next table, if available. The previous table will be + * unmapped if the next level was mapped (e.g GUEST_TABLE_NORMAL_PAGE + * returned). + * + * The read_only parameters indicates whether intermediate tables should + * be allocated when not present. + * + * Return values: + * GUEST_TABLE_MAP_FAILED: Either read_only was set and the entry + * was empty, or allocating a new page failed. + * GUEST_TABLE_NORMAL_PAGE: next level mapped normally + * GUEST_TABLE_SUPER_PAGE: The next entry points to a superpage. + */ +static int p2m_next_level(struct p2m_domain *p2m, bool read_only, + unsigned int level, lpae_t **table, + unsigned int offset) +{ + lpae_t *entry; + int ret; + mfn_t mfn; + + entry = *table + offset; + + if ( !p2m_is_valid(*entry) ) + { + if ( read_only ) + return GUEST_TABLE_MAP_FAILED; + + ret = p2m_create_table(p2m, entry); + if ( ret ) + return GUEST_TABLE_MAP_FAILED; + } + + /* The function p2m_next_level is never called at the 3rd level */ + ASSERT(level < 3); + if ( p2m_is_mapping(*entry, level) ) + return GUEST_TABLE_SUPER_PAGE; + + mfn = lpae_get_mfn(*entry); + + unmap_domain_page(*table); + *table = map_domain_page(mfn); + + return GUEST_TABLE_NORMAL_PAGE; +} + +/* + * Get the details of a given gfn. + * + * If the entry is present, the associated MFN will be returned and the + * access and type filled up. The page_order will correspond to the + * order of the mapping in the page table (i.e it could be a superpage). + * + * If the entry is not present, INVALID_MFN will be returned and the + * page_order will be set according to the order of the invalid range. + * + * valid will contain the value of bit[0] (e.g valid bit) of the + * entry. + */ +mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn, + p2m_type_t *t, p2m_access_t *a, + unsigned int *page_order, + bool *valid) +{ + paddr_t addr = gfn_to_gaddr(gfn); + unsigned int level = 0; + lpae_t entry, *table; + int rc; + mfn_t mfn = INVALID_MFN; + p2m_type_t _t; + DECLARE_OFFSETS(offsets, addr); + + ASSERT(p2m_is_locked(p2m)); + BUILD_BUG_ON(THIRD_MASK != PAGE_MASK); + + /* Allow t to be NULL */ + t = t ?: &_t; + + *t = p2m_invalid; + + if ( valid ) + *valid = false; + + /* XXX: Check if the mapping is lower than the mapped gfn */ + + /* This gfn is higher than the highest the p2m map currently holds */ + if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) + { + for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) + if ( (gfn_x(gfn) & (XEN_PT_LEVEL_MASK(level) >> PAGE_SHIFT)) > + gfn_x(p2m->max_mapped_gfn) ) + break; + + goto out; + } + + table = p2m_get_root_pointer(p2m, gfn); + + /* + * the table should always be non-NULL because the gfn is below + * p2m->max_mapped_gfn and the root table pages are always present. + */ + if ( !table ) + { + ASSERT_UNREACHABLE(); + level = P2M_ROOT_LEVEL; + goto out; + } + + for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) + { + rc = p2m_next_level(p2m, true, level, &table, offsets[level]); + if ( rc == GUEST_TABLE_MAP_FAILED ) + goto out_unmap; + else if ( rc != GUEST_TABLE_NORMAL_PAGE ) + break; + } + + entry = table[offsets[level]]; + + if ( p2m_is_valid(entry) ) + { + *t = entry.p2m.type; + + if ( a ) + *a = p2m_mem_access_radix_get(p2m, gfn); + + mfn = lpae_get_mfn(entry); + /* + * The entry may point to a superpage. Find the MFN associated + * to the GFN. + */ + mfn = mfn_add(mfn, + gfn_x(gfn) & ((1UL << XEN_PT_LEVEL_ORDER(level)) - 1)); + + if ( valid ) + *valid = lpae_is_valid(entry); + } + +out_unmap: + unmap_domain_page(table); + +out: + if ( page_order ) + *page_order = XEN_PT_LEVEL_ORDER(level); + + return mfn; +} + +static void p2m_set_permission(lpae_t *e, p2m_type_t t, p2m_access_t a) +{ + /* First apply type permissions */ + switch ( t ) + { + case p2m_ram_rw: + e->p2m.xn = 0; + e->p2m.write = 1; + break; + + case p2m_ram_ro: + e->p2m.xn = 0; + e->p2m.write = 0; + break; + + case p2m_iommu_map_rw: + case p2m_map_foreign_rw: + case p2m_grant_map_rw: + case p2m_mmio_direct_dev: + case p2m_mmio_direct_nc: + case p2m_mmio_direct_c: + e->p2m.xn = 1; + e->p2m.write = 1; + break; + + case p2m_iommu_map_ro: + case p2m_map_foreign_ro: + case p2m_grant_map_ro: + case p2m_invalid: + e->p2m.xn = 1; + e->p2m.write = 0; + break; + + case p2m_max_real_type: + BUG(); + break; + } + + /* Then restrict with access permissions */ + switch ( a ) + { + case p2m_access_rwx: + break; + case p2m_access_wx: + e->p2m.read = 0; + break; + case p2m_access_rw: + e->p2m.xn = 1; + break; + case p2m_access_w: + e->p2m.read = 0; + e->p2m.xn = 1; + break; + case p2m_access_rx: + case p2m_access_rx2rw: + e->p2m.write = 0; + break; + case p2m_access_x: + e->p2m.write = 0; + e->p2m.read = 0; + break; + case p2m_access_r: + e->p2m.write = 0; + e->p2m.xn = 1; + break; + case p2m_access_n: + case p2m_access_n2rwx: + e->p2m.read = e->p2m.write = 0; + e->p2m.xn = 1; + break; + } +} + +static lpae_t mfn_to_p2m_entry(mfn_t mfn, p2m_type_t t, p2m_access_t a) +{ + /* + * sh, xn and write bit will be defined in the following switches + * based on mattr and t. + */ + lpae_t e = (lpae_t) { + .p2m.af = 1, + .p2m.read = 1, + .p2m.table = 1, + .p2m.valid = 1, + .p2m.type = t, + }; + + BUILD_BUG_ON(p2m_max_real_type > (1 << 4)); + + switch ( t ) + { + case p2m_mmio_direct_dev: + e.p2m.mattr = MATTR_DEV; + e.p2m.sh = LPAE_SH_OUTER; + break; + + case p2m_mmio_direct_c: + e.p2m.mattr = MATTR_MEM; + e.p2m.sh = LPAE_SH_OUTER; + break; + + /* + * ARM ARM: Overlaying the shareability attribute (DDI + * 0406C.b B3-1376 to 1377) + * + * A memory region with a resultant memory type attribute of Normal, + * and a resultant cacheability attribute of Inner Non-cacheable, + * Outer Non-cacheable, must have a resultant shareability attribute + * of Outer Shareable, otherwise shareability is UNPREDICTABLE. + * + * On ARMv8 shareability is ignored and explicitly treated as Outer + * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. + * See the note for table D4-40, in page 1788 of the ARM DDI 0487A.j. + */ + case p2m_mmio_direct_nc: + e.p2m.mattr = MATTR_MEM_NC; + e.p2m.sh = LPAE_SH_OUTER; + break; + + default: + e.p2m.mattr = MATTR_MEM; + e.p2m.sh = LPAE_SH_INNER; + } + + p2m_set_permission(&e, t, a); + + ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); + + lpae_set_mfn(e, mfn); + + return e; +} + +/* Generate table entry with correct attributes. */ +static lpae_t page_to_p2m_table(struct page_info *page) +{ + /* + * The access value does not matter because the hardware will ignore + * the permission fields for table entry. + * + * We use p2m_ram_rw so the entry has a valid type. This is important + * for p2m_is_valid() to return valid on table entries. + */ + return mfn_to_p2m_entry(page_to_mfn(page), p2m_ram_rw, p2m_access_rwx); +} + +static inline void p2m_write_pte(lpae_t *p, lpae_t pte, bool clean_pte) +{ + write_pte(p, pte); + if ( clean_pte ) + clean_dcache(*p); +} + +static inline void p2m_remove_pte(lpae_t *p, bool clean_pte) +{ + lpae_t pte; + + memset(&pte, 0x00, sizeof(pte)); + p2m_write_pte(p, pte, clean_pte); +} + +/* Allocate a new page table page and hook it in via the given entry. */ +static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) +{ + struct page_info *page; + lpae_t *p; + + ASSERT(!p2m_is_valid(*entry)); + + page = p2m_alloc_page(p2m->domain); + if ( page == NULL ) + return -ENOMEM; + + page_list_add(page, &p2m->pages); + + p = __map_domain_page(page); + clear_page(p); + + if ( p2m->clean_pte ) + clean_dcache_va_range(p, PAGE_SIZE); + + unmap_domain_page(p); + + p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); + + return 0; +} + +static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, + p2m_access_t a) +{ + int rc; + + if ( !p2m->mem_access_enabled ) + return 0; + + if ( p2m_access_rwx == a ) + { + radix_tree_delete(&p2m->mem_access_settings, gfn_x(gfn)); + return 0; + } + + rc = radix_tree_insert(&p2m->mem_access_settings, gfn_x(gfn), + radix_tree_int_to_ptr(a)); + if ( rc == -EEXIST ) + { + /* If a setting already exists, change it to the new one */ + radix_tree_replace_slot( + radix_tree_lookup_slot( + &p2m->mem_access_settings, gfn_x(gfn)), + radix_tree_int_to_ptr(a)); + rc = 0; + } + + return rc; +} + +/* + * Put any references on the single 4K page referenced by pte. + * TODO: Handle superpages, for now we only take special references for leaf + * pages (specifically foreign ones, which can't be super mapped today). + */ +static void p2m_put_l3_page(const lpae_t pte) +{ + mfn_t mfn = lpae_get_mfn(pte); + + ASSERT(p2m_is_valid(pte)); + + /* + * TODO: Handle other p2m types + * + * It's safe to do the put_page here because page_alloc will + * flush the TLBs if the page is reallocated before the end of + * this loop. + */ + if ( p2m_is_foreign(pte.p2m.type) ) + { + ASSERT(mfn_valid(mfn)); + put_page(mfn_to_page(mfn)); + } + /* Detect the xenheap page and mark the stored GFN as invalid. */ + else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) + page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); +} + +/* Free lpae sub-tree behind an entry */ +static void p2m_free_entry(struct p2m_domain *p2m, + lpae_t entry, unsigned int level) +{ + unsigned int i; + lpae_t *table; + mfn_t mfn; + struct page_info *pg; + + /* Nothing to do if the entry is invalid. */ + if ( !p2m_is_valid(entry) ) + return; + + if ( p2m_is_superpage(entry, level) || (level == 3) ) + { +#ifdef CONFIG_IOREQ_SERVER + /* + * If this gets called then either the entry was replaced by an entry + * with a different base (valid case) or the shattering of a superpage + * has failed (error case). + * So, at worst, the spurious mapcache invalidation might be sent. + */ + if ( p2m_is_ram(entry.p2m.type) && + domain_has_ioreq_server(p2m->domain) ) + ioreq_request_mapcache_invalidate(p2m->domain); +#endif + + p2m->stats.mappings[level]--; + /* Nothing to do if the entry is a super-page. */ + if ( level == 3 ) + p2m_put_l3_page(entry); + return; + } + + table = map_domain_page(lpae_get_mfn(entry)); + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + p2m_free_entry(p2m, *(table + i), level + 1); + + unmap_domain_page(table); + + /* + * Make sure all the references in the TLB have been removed before + * freing the intermediate page table. + * XXX: Should we defer the free of the page table to avoid the + * flush? + */ + p2m_tlb_flush_sync(p2m); + + mfn = lpae_get_mfn(entry); + ASSERT(mfn_valid(mfn)); + + pg = mfn_to_page(mfn); + + page_list_del(pg, &p2m->pages); + p2m_free_page(p2m->domain, pg); +} + +static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry, + unsigned int level, unsigned int target, + const unsigned int *offsets) +{ + struct page_info *page; + unsigned int i; + lpae_t pte, *table; + bool rv = true; + + /* Convenience aliases */ + mfn_t mfn = lpae_get_mfn(*entry); + unsigned int next_level = level + 1; + unsigned int level_order = XEN_PT_LEVEL_ORDER(next_level); + + /* + * This should only be called with target != level and the entry is + * a superpage. + */ + ASSERT(level < target); + ASSERT(p2m_is_superpage(*entry, level)); + + page = p2m_alloc_page(p2m->domain); + if ( !page ) + return false; + + page_list_add(page, &p2m->pages); + table = __map_domain_page(page); + + /* + * We are either splitting a first level 1G page into 512 second level + * 2M pages, or a second level 2M page into 512 third level 4K pages. + */ + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + { + lpae_t *new_entry = table + i; + + /* + * Use the content of the superpage entry and override + * the necessary fields. So the correct permission are kept. + */ + pte = *entry; + lpae_set_mfn(pte, mfn_add(mfn, i << level_order)); + + /* + * First and second level pages set p2m.table = 0, but third + * level entries set p2m.table = 1. + */ + pte.p2m.table = (next_level == 3); + + write_pte(new_entry, pte); + } + + /* Update stats */ + p2m->stats.shattered[level]++; + p2m->stats.mappings[level]--; + p2m->stats.mappings[next_level] += XEN_PT_LPAE_ENTRIES; + + /* + * Shatter superpage in the page to the level we want to make the + * changes. + * This is done outside the loop to avoid checking the offset to + * know whether the entry should be shattered for every entry. + */ + if ( next_level != target ) + rv = p2m_split_superpage(p2m, table + offsets[next_level], + level + 1, target, offsets); + + if ( p2m->clean_pte ) + clean_dcache_va_range(table, PAGE_SIZE); + + unmap_domain_page(table); + + /* + * Even if we failed, we should install the newly allocated LPAE + * entry. The caller will be in charge to free the sub-tree. + */ + p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); + + return rv; +} + +/* + * Insert an entry in the p2m. This should be called with a mapping + * equal to a page/superpage (4K, 2M, 1G). + */ +int __p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned int page_order, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a) +{ + unsigned int level = 0; + unsigned int target = 3 - (page_order / XEN_PT_LPAE_SHIFT); + lpae_t *entry, *table, orig_pte; + int rc; + /* A mapping is removed if the MFN is invalid. */ + bool removing_mapping = mfn_eq(smfn, INVALID_MFN); + DECLARE_OFFSETS(offsets, gfn_to_gaddr(sgfn)); + + ASSERT(p2m_is_write_locked(p2m)); + + /* + * Check if the level target is valid: we only support + * 4K - 2M - 1G mapping. + */ + ASSERT(target > 0 && target <= 3); + + table = p2m_get_root_pointer(p2m, sgfn); + if ( !table ) + return -EINVAL; + + for ( level = P2M_ROOT_LEVEL; level < target; level++ ) + { + /* + * Don't try to allocate intermediate page table if the mapping + * is about to be removed. + */ + rc = p2m_next_level(p2m, removing_mapping, + level, &table, offsets[level]); + if ( rc == GUEST_TABLE_MAP_FAILED ) + { + /* + * We are here because p2m_next_level has failed to map + * the intermediate page table (e.g the table does not exist + * and they p2m tree is read-only). It is a valid case + * when removing a mapping as it may not exist in the + * page table. In this case, just ignore it. + */ + rc = removing_mapping ? 0 : -ENOENT; + goto out; + } + else if ( rc != GUEST_TABLE_NORMAL_PAGE ) + break; + } + + entry = table + offsets[level]; + + /* + * If we are here with level < target, we must be at a leaf node, + * and we need to break up the superpage. + */ + if ( level < target ) + { + /* We need to split the original page. */ + lpae_t split_pte = *entry; + + ASSERT(p2m_is_superpage(*entry, level)); + + if ( !p2m_split_superpage(p2m, &split_pte, level, target, offsets) ) + { + /* + * The current super-page is still in-place, so re-increment + * the stats. + */ + p2m->stats.mappings[level]++; + + /* Free the allocated sub-tree */ + p2m_free_entry(p2m, split_pte, level); + + rc = -ENOMEM; + goto out; + } + + /* + * Follow the break-before-sequence to update the entry. + * For more details see (D4.7.1 in ARM DDI 0487A.j). + */ + p2m_remove_pte(entry, p2m->clean_pte); + p2m_force_tlb_flush_sync(p2m); + + p2m_write_pte(entry, split_pte, p2m->clean_pte); + + /* then move to the level we want to make real changes */ + for ( ; level < target; level++ ) + { + rc = p2m_next_level(p2m, true, level, &table, offsets[level]); + + /* + * The entry should be found and either be a table + * or a superpage if level 3 is not targeted + */ + ASSERT(rc == GUEST_TABLE_NORMAL_PAGE || + (rc == GUEST_TABLE_SUPER_PAGE && target < 3)); + } + + entry = table + offsets[level]; + } + + /* + * We should always be there with the correct level because + * all the intermediate tables have been installed if necessary. + */ + ASSERT(level == target); + + orig_pte = *entry; + + /* + * The radix-tree can only work on 4KB. This is only used when + * memaccess is enabled and during shutdown. + */ + ASSERT(!p2m->mem_access_enabled || page_order == 0 || + p2m->domain->is_dying); + /* + * The access type should always be p2m_access_rwx when the mapping + * is removed. + */ + ASSERT(!mfn_eq(INVALID_MFN, smfn) || (a == p2m_access_rwx)); + /* + * Update the mem access permission before update the P2M. So we + * don't have to revert the mapping if it has failed. + */ + rc = p2m_mem_access_radix_set(p2m, sgfn, a); + if ( rc ) + goto out; + + /* + * Always remove the entry in order to follow the break-before-make + * sequence when updating the translation table (D4.7.1 in ARM DDI + * 0487A.j). + */ + if ( lpae_is_valid(orig_pte) || removing_mapping ) + p2m_remove_pte(entry, p2m->clean_pte); + + if ( removing_mapping ) + /* Flush can be deferred if the entry is removed */ + p2m->need_flush |= !!lpae_is_valid(orig_pte); + else + { + lpae_t pte = mfn_to_p2m_entry(smfn, t, a); + + if ( level < 3 ) + pte.p2m.table = 0; /* Superpage entry */ + + /* + * It is necessary to flush the TLB before writing the new entry + * to keep coherency when the previous entry was valid. + * + * Although, it could be defered when only the permissions are + * changed (e.g in case of memaccess). + */ + if ( lpae_is_valid(orig_pte) ) + { + if ( likely(!p2m->mem_access_enabled) || + P2M_CLEAR_PERM(pte) != P2M_CLEAR_PERM(orig_pte) ) + p2m_force_tlb_flush_sync(p2m); + else + p2m->need_flush = true; + } + else if ( !p2m_is_valid(orig_pte) ) /* new mapping */ + p2m->stats.mappings[level]++; + + p2m_write_pte(entry, pte, p2m->clean_pte); + + p2m->max_mapped_gfn = gfn_max(p2m->max_mapped_gfn, + gfn_add(sgfn, (1UL << page_order) - 1)); + p2m->lowest_mapped_gfn = gfn_min(p2m->lowest_mapped_gfn, sgfn); + } + + if ( is_iommu_enabled(p2m->domain) && + (lpae_is_valid(orig_pte) || lpae_is_valid(*entry)) ) + { + unsigned int flush_flags = 0; + + if ( lpae_is_valid(orig_pte) ) + flush_flags |= IOMMU_FLUSHF_modified; + if ( lpae_is_valid(*entry) ) + flush_flags |= IOMMU_FLUSHF_added; + + rc = iommu_iotlb_flush(p2m->domain, _dfn(gfn_x(sgfn)), + 1UL << page_order, flush_flags); + } + else + rc = 0; + + /* + * Free the entry only if the original pte was valid and the base + * is different (to avoid freeing when permission is changed). + */ + if ( p2m_is_valid(orig_pte) && + !mfn_eq(lpae_get_mfn(*entry), lpae_get_mfn(orig_pte)) ) + p2m_free_entry(p2m, orig_pte, level); + +out: + unmap_domain_page(table); + + return rc; +} + +int p2m_set_entry(struct p2m_domain *p2m, + gfn_t sgfn, + unsigned long nr, + mfn_t smfn, + p2m_type_t t, + p2m_access_t a) +{ + int rc = 0; + + /* + * Any reference taken by the P2M mappings (e.g. foreign mapping) will + * be dropped in relinquish_p2m_mapping(). As the P2M will still + * be accessible after, we need to prevent mapping to be added when the + * domain is dying. + */ + if ( unlikely(p2m->domain->is_dying) ) + return -ENOMEM; + + while ( nr ) + { + unsigned long mask; + unsigned long order; + + /* + * Don't take into account the MFN when removing mapping (i.e + * MFN_INVALID) to calculate the correct target order. + * + * XXX: Support superpage mappings if nr is not aligned to a + * superpage size. + */ + mask = !mfn_eq(smfn, INVALID_MFN) ? mfn_x(smfn) : 0; + mask |= gfn_x(sgfn) | nr; + + /* Always map 4k by 4k when memaccess is enabled */ + if ( unlikely(p2m->mem_access_enabled) ) + order = THIRD_ORDER; + else if ( !(mask & ((1UL << FIRST_ORDER) - 1)) ) + order = FIRST_ORDER; + else if ( !(mask & ((1UL << SECOND_ORDER) - 1)) ) + order = SECOND_ORDER; + else + order = THIRD_ORDER; + + rc = __p2m_set_entry(p2m, sgfn, order, smfn, t, a); + if ( rc ) + break; + + sgfn = gfn_add(sgfn, (1 << order)); + if ( !mfn_eq(smfn, INVALID_MFN) ) + smfn = mfn_add(smfn, (1 << order)); + + nr -= (1 << order); + } + + return rc; +} + +/* Invalidate all entries in the table. The p2m should be write locked. */ +static void p2m_invalidate_table(struct p2m_domain *p2m, mfn_t mfn) +{ + lpae_t *table; + unsigned int i; + + ASSERT(p2m_is_write_locked(p2m)); + + table = map_domain_page(mfn); + + for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) + { + lpae_t pte = table[i]; + + /* + * Writing an entry can be expensive because it may involve + * cleaning the cache. So avoid updating the entry if the valid + * bit is already cleared. + */ + if ( !pte.p2m.valid ) + continue; + + pte.p2m.valid = 0; + + p2m_write_pte(&table[i], pte, p2m->clean_pte); + } + + unmap_domain_page(table); + + p2m->need_flush = true; +} + +/* + * Invalidate all entries in the root page-tables. This is + * useful to get fault on entry and do an action. + * + * p2m_invalid_root() should not be called when the P2M is shared with + * the IOMMU because it will cause IOMMU fault. + */ +void p2m_invalidate_root(struct p2m_domain *p2m) +{ + unsigned int i; + + ASSERT(!iommu_use_hap_pt(p2m->domain)); + + p2m_write_lock(p2m); + + for ( i = 0; i < P2M_ROOT_LEVEL; i++ ) + p2m_invalidate_table(p2m, page_to_mfn(p2m->root + i)); + + p2m_write_unlock(p2m); +} + +/* + * Resolve any translation fault due to change in the p2m. This + * includes break-before-make and valid bit cleared. + */ +bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned int level = 0; + bool resolved = false; + lpae_t entry, *table; + + /* Convenience aliases */ + DECLARE_OFFSETS(offsets, gfn_to_gaddr(gfn)); + + p2m_write_lock(p2m); + + /* This gfn is higher than the highest the p2m map currently holds */ + if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) + goto out; + + table = p2m_get_root_pointer(p2m, gfn); + /* + * The table should always be non-NULL because the gfn is below + * p2m->max_mapped_gfn and the root table pages are always present. + */ + if ( !table ) + { + ASSERT_UNREACHABLE(); + goto out; + } + + /* + * Go down the page-tables until an entry has the valid bit unset or + * a block/page entry has been hit. + */ + for ( level = P2M_ROOT_LEVEL; level <= 3; level++ ) + { + int rc; + + entry = table[offsets[level]]; + + if ( level == 3 ) + break; + + /* Stop as soon as we hit an entry with the valid bit unset. */ + if ( !lpae_is_valid(entry) ) + break; + + rc = p2m_next_level(p2m, true, level, &table, offsets[level]); + if ( rc == GUEST_TABLE_MAP_FAILED ) + goto out_unmap; + else if ( rc != GUEST_TABLE_NORMAL_PAGE ) + break; + } + + /* + * If the valid bit of the entry is set, it means someone was playing with + * the Stage-2 page table. Nothing to do and mark the fault as resolved. + */ + if ( lpae_is_valid(entry) ) + { + resolved = true; + goto out_unmap; + } + + /* + * The valid bit is unset. If the entry is still not valid then the fault + * cannot be resolved, exit and report it. + */ + if ( !p2m_is_valid(entry) ) + goto out_unmap; + + /* + * Now we have an entry with valid bit unset, but still valid from + * the P2M point of view. + * + * If an entry is pointing to a table, each entry of the table will + * have there valid bit cleared. This allows a function to clear the + * full p2m with just a couple of write. The valid bit will then be + * propagated on the fault. + * If an entry is pointing to a block/page, no work to do for now. + */ + if ( lpae_is_table(entry, level) ) + p2m_invalidate_table(p2m, lpae_get_mfn(entry)); + + /* + * Now that the work on the entry is done, set the valid bit to prevent + * another fault on that entry. + */ + resolved = true; + entry.p2m.valid = 1; + + p2m_write_pte(table + offsets[level], entry, p2m->clean_pte); + + /* + * No need to flush the TLBs as the modified entry had the valid bit + * unset. + */ + +out_unmap: + unmap_domain_page(table); + +out: + p2m_write_unlock(p2m); + + return resolved; +} + +static struct page_info *p2m_allocate_root(void) +{ + struct page_info *page; + unsigned int i; + + page = alloc_domheap_pages(NULL, P2M_ROOT_ORDER, 0); + if ( page == NULL ) + return NULL; + + /* Clear both first level pages */ + for ( i = 0; i < P2M_ROOT_PAGES; i++ ) + clear_and_clean_page(page + i); + + return page; +} + +static int p2m_alloc_table(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m->root = p2m_allocate_root(); + if ( !p2m->root ) + return -ENOMEM; + + p2m->vttbr = generate_vttbr(p2m->vmid, page_to_mfn(p2m->root)); + + /* + * Make sure that all TLBs corresponding to the new VMID are flushed + * before using it + */ + p2m_write_lock(p2m); + p2m_force_tlb_flush_sync(p2m); + p2m_write_unlock(p2m); + + return 0; +} + +int p2m_teardown(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned long count = 0; + struct page_info *pg; + int rc = 0; + + p2m_write_lock(p2m); + + while ( (pg = page_list_remove_head(&p2m->pages)) ) + { + p2m_free_page(p2m->domain, pg); + count++; + /* Arbitrarily preempt every 512 iterations */ + if ( !(count % 512) && hypercall_preempt_check() ) + { + rc = -ERESTART; + break; + } + } + + p2m_write_unlock(p2m); + + return rc; +} + +int p2m_init(struct domain *d) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); + int rc; + unsigned int cpu; + + rwlock_init(&p2m->lock); + spin_lock_init(&d->arch.paging.lock); + INIT_PAGE_LIST_HEAD(&p2m->pages); + INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist); + + p2m->vmid = INVALID_VMID; + p2m->max_mapped_gfn = _gfn(0); + p2m->lowest_mapped_gfn = _gfn(ULONG_MAX); + + p2m->default_access = p2m_access_rwx; + p2m->mem_access_enabled = false; + radix_tree_init(&p2m->mem_access_settings); + + /* + * Some IOMMUs don't support coherent PT walk. When the p2m is + * shared with the CPU, Xen has to make sure that the PT changes have + * reached the memory + */ + p2m->clean_pte = is_iommu_enabled(d) && + !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK); + + /* + * Make sure that the type chosen to is able to store the an vCPU ID + * between 0 and the maximum of virtual CPUS supported as long as + * the INVALID_VCPU_ID. + */ + BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0]) * 8)) < MAX_VIRT_CPUS); + BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0])* 8)) < INVALID_VCPU_ID); + + for_each_possible_cpu(cpu) + p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID; + + /* + * "Trivial" initialisation is now complete. Set the backpointer so + * p2m_teardown() and friends know to do something. + */ + p2m->domain = d; + + rc = p2m_alloc_vmid(d); + if ( rc ) + return rc; + + rc = p2m_alloc_table(d); + if ( rc ) + return rc; + + return 0; +} + +/* VTCR value to be configured by all CPUs. Set only once by the boot CPU */ +static register_t __read_mostly vtcr; + +void setup_virt_paging_one(void *data) +{ + WRITE_SYSREG(vtcr, VTCR_EL2); + + /* + * ARM64_WORKAROUND_AT_SPECULATE: We want to keep the TLBs free from + * entries related to EL1/EL0 translation regime until a guest vCPU + * is running. For that, we need to set-up VTTBR to point to an empty + * page-table and turn on stage-2 translation. The TLB entries + * associated with EL1/EL0 translation regime will also be flushed in case + * an AT instruction was speculated before hand. + */ + if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + { + WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); + WRITE_SYSREG(READ_SYSREG(HCR_EL2) | HCR_VM, HCR_EL2); + isb(); + + flush_all_guests_tlb_local(); + } +} + +void __init setup_virt_paging(void) +{ + /* Setup Stage 2 address translation */ + register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; + + static const struct { + unsigned int pabits; /* Physical Address Size */ + unsigned int t0sz; /* Desired T0SZ, minimum in comment */ + unsigned int root_order; /* Page order of the root of the p2m */ + unsigned int sl0; /* Desired SL0, maximum in comment */ + } pa_range_info[] __initconst = { + /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ + /* PA size, t0sz(min), root-order, sl0(max) */ +#ifdef CONFIG_ARM_64 + [0] = { 32, 32/*32*/, 0, 1 }, + [1] = { 36, 28/*28*/, 0, 1 }, + [2] = { 40, 24/*24*/, 1, 1 }, + [3] = { 42, 22/*22*/, 3, 1 }, + [4] = { 44, 20/*20*/, 0, 2 }, + [5] = { 48, 16/*16*/, 0, 2 }, + [6] = { 52, 12/*12*/, 4, 2 }, + [7] = { 0 } /* Invalid */ +#else + { 32, 0/*0*/, 0, 1 }, + { 40, 24/*24*/, 1, 1 } +#endif + }; + + unsigned int i; + unsigned int pa_range = 0x10; /* Larger than any possible value */ + +#ifdef CONFIG_ARM_32 + /* + * Typecast pa_range_info[].t0sz into arm32 bit variant. + * + * VTCR.T0SZ is bits [3:0] and S(sign extension), bit[4] for arm322. + * Thus, pa_range_info[].t0sz is translated to its arm32 variant using + * struct bitfields. + */ + struct + { + signed int val:5; + } t0sz_32; +#else + /* + * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured + * with IPA bits == PA bits, compare against "pabits". + */ + if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < p2m_ipa_bits ) + p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range].pabits; + + /* + * cpu info sanitization made sure we support 16bits VMID only if all + * cores are supporting it. + */ + if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) + max_vmid = MAX_VMID_16_BIT; +#endif + + /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ + for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) + { + if ( p2m_ipa_bits == pa_range_info[i].pabits ) + { + pa_range = i; + break; + } + } + + /* Check if we found the associated entry in the array */ + if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) + panic("%u-bit P2M is not supported\n", p2m_ipa_bits); + +#ifdef CONFIG_ARM_64 + val |= VTCR_PS(pa_range); + val |= VTCR_TG0_4K; + + /* Set the VS bit only if 16 bit VMID is supported. */ + if ( MAX_VMID == MAX_VMID_16_BIT ) + val |= VTCR_VS; +#endif + + val |= VTCR_SL0(pa_range_info[pa_range].sl0); + val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); + + p2m_root_order = pa_range_info[pa_range].root_order; + p2m_root_level = 2 - pa_range_info[pa_range].sl0; + +#ifdef CONFIG_ARM_64 + p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; +#else + t0sz_32.val = pa_range_info[pa_range].t0sz; + p2m_ipa_bits = 32 - t0sz_32.val; +#endif + + printk("P2M: %d-bit IPA with %d-bit PA and %d-bit VMID\n", + p2m_ipa_bits, + pa_range_info[pa_range].pabits, + ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); + + printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", + 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); + + p2m_vmid_allocator_init(); + + /* It is not allowed to concatenate a level zero root */ + BUG_ON( P2M_ROOT_LEVEL == 0 && P2M_ROOT_ORDER > 0 ); + vtcr = val; + + /* + * ARM64_WORKAROUND_AT_SPECULATE requires to allocate root table + * with all entries zeroed. + */ + if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) + { + struct page_info *root; + + root = p2m_allocate_root(); + if ( !root ) + panic("Unable to allocate root table for ARM64_WORKAROUND_AT_SPECULATE\n"); + + empty_root_mfn = page_to_mfn(root); + } + + setup_virt_paging_one(NULL); + smp_call_function(setup_virt_paging_one, NULL, 1); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index de32a2d638..c9f6563597 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1,1466 +1,136 @@ /* SPDX-License-Identifier: GPL-2.0 */ #include -#include #include -#include #include #include #include -#include #include #include #include #include #include -#define MAX_VMID_8_BIT (1UL << 8) -#define MAX_VMID_16_BIT (1UL << 16) - -#define INVALID_VMID 0 /* VMID 0 is reserved */ - -unsigned int __read_mostly p2m_root_order; -unsigned int __read_mostly p2m_root_level; #ifdef CONFIG_ARM_64 -static unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; -/* VMID is by default 8 bit width on AArch64 */ -#define MAX_VMID max_vmid -#else -/* VMID is always 8 bit width on AArch32 */ -#define MAX_VMID MAX_VMID_8_BIT -#endif - -#define P2M_ROOT_PAGES (1<arch.paging.lock); - pg = page_list_remove_head(&d->arch.paging.p2m_freelist); - spin_unlock(&d->arch.paging.lock); - } - - return pg; -} - -static void p2m_free_page(struct domain *d, struct page_info *pg) -{ - if ( is_hardware_domain(d) ) - free_domheap_page(pg); - else - { - spin_lock(&d->arch.paging.lock); - page_list_add_tail(pg, &d->arch.paging.p2m_freelist); - spin_unlock(&d->arch.paging.lock); - } -} - -/* Return the size of the pool, in bytes. */ -int arch_get_paging_mempool_size(struct domain *d, uint64_t *size) -{ - *size = (uint64_t)ACCESS_ONCE(d->arch.paging.p2m_total_pages) << PAGE_SHIFT; - return 0; -} - -/* - * Set the pool of pages to the required number of pages. - * Returns 0 for success, non-zero for failure. - * Call with d->arch.paging.lock held. - */ -int p2m_set_allocation(struct domain *d, unsigned long pages, bool *preempted) -{ - struct page_info *pg; - - ASSERT(spin_is_locked(&d->arch.paging.lock)); - - for ( ; ; ) - { - if ( d->arch.paging.p2m_total_pages < pages ) - { - /* Need to allocate more memory from domheap */ - pg = alloc_domheap_page(NULL, 0); - if ( pg == NULL ) - { - printk(XENLOG_ERR "Failed to allocate P2M pages.\n"); - return -ENOMEM; - } - ACCESS_ONCE(d->arch.paging.p2m_total_pages) = - d->arch.paging.p2m_total_pages + 1; - page_list_add_tail(pg, &d->arch.paging.p2m_freelist); - } - else if ( d->arch.paging.p2m_total_pages > pages ) - { - /* Need to return memory to domheap */ - pg = page_list_remove_head(&d->arch.paging.p2m_freelist); - if( pg ) - { - ACCESS_ONCE(d->arch.paging.p2m_total_pages) = - d->arch.paging.p2m_total_pages - 1; - free_domheap_page(pg); - } - else - { - printk(XENLOG_ERR - "Failed to free P2M pages, P2M freelist is empty.\n"); - return -ENOMEM; - } - } - else - break; - - /* Check to see if we need to yield and try again */ - if ( preempted && general_preempt_check() ) - { - *preempted = true; - return -ERESTART; - } - } - - return 0; -} - -int arch_set_paging_mempool_size(struct domain *d, uint64_t size) -{ - unsigned long pages = size >> PAGE_SHIFT; - bool preempted = false; - int rc; - - if ( (size & ~PAGE_MASK) || /* Non page-sized request? */ - pages != (size >> PAGE_SHIFT) ) /* 32-bit overflow? */ - return -EINVAL; - - spin_lock(&d->arch.paging.lock); - rc = p2m_set_allocation(d, pages, &preempted); - spin_unlock(&d->arch.paging.lock); - - ASSERT(preempted == (rc == -ERESTART)); - - return rc; -} - -int p2m_teardown_allocation(struct domain *d) -{ - int ret = 0; - bool preempted = false; - - spin_lock(&d->arch.paging.lock); - if ( d->arch.paging.p2m_total_pages != 0 ) - { - ret = p2m_set_allocation(d, 0, &preempted); - if ( preempted ) - { - spin_unlock(&d->arch.paging.lock); - return -ERESTART; - } - ASSERT(d->arch.paging.p2m_total_pages == 0); - } - spin_unlock(&d->arch.paging.lock); - - return ret; -} - -/* Unlock the flush and do a P2M TLB flush if necessary */ -void p2m_write_unlock(struct p2m_domain *p2m) -{ - /* - * The final flush is done with the P2M write lock taken to avoid - * someone else modifying the P2M wbefore the TLB invalidation has - * completed. - */ - p2m_tlb_flush_sync(p2m); - - write_unlock(&p2m->lock); -} - -void p2m_dump_info(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m_read_lock(p2m); - printk("p2m mappings for domain %d (vmid %d):\n", - d->domain_id, p2m->vmid); - BUG_ON(p2m->stats.mappings[0] || p2m->stats.shattered[0]); - printk(" 1G mappings: %ld (shattered %ld)\n", - p2m->stats.mappings[1], p2m->stats.shattered[1]); - printk(" 2M mappings: %ld (shattered %ld)\n", - p2m->stats.mappings[2], p2m->stats.shattered[2]); - printk(" 4K mappings: %ld\n", p2m->stats.mappings[3]); - p2m_read_unlock(p2m); -} - -void memory_type_changed(struct domain *d) -{ -} - -void dump_p2m_lookup(struct domain *d, paddr_t addr) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - printk("dom%d IPA 0x%"PRIpaddr"\n", d->domain_id, addr); - - printk("P2M @ %p mfn:%#"PRI_mfn"\n", - p2m->root, mfn_x(page_to_mfn(p2m->root))); - - dump_pt_walk(page_to_maddr(p2m->root), addr, - P2M_ROOT_LEVEL, P2M_ROOT_PAGES); -} - -/* - * p2m_save_state and p2m_restore_state work in pair to workaround - * ARM64_WORKAROUND_AT_SPECULATE. p2m_save_state will set-up VTTBR to - * point to the empty page-tables to stop allocating TLB entries. - */ -void p2m_save_state(struct vcpu *p) -{ - p->arch.sctlr = READ_SYSREG(SCTLR_EL1); - - if ( cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - { - WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); - /* - * Ensure VTTBR_EL2 is correctly synchronized so we can restore - * the next vCPU context without worrying about AT instruction - * speculation. - */ - isb(); - } -} - -void p2m_restore_state(struct vcpu *n) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(n->domain); - uint8_t *last_vcpu_ran; - - if ( is_idle_vcpu(n) ) - return; - - WRITE_SYSREG(n->arch.sctlr, SCTLR_EL1); - WRITE_SYSREG(n->arch.hcr_el2, HCR_EL2); - - /* - * ARM64_WORKAROUND_AT_SPECULATE: VTTBR_EL2 should be restored after all - * registers associated to EL1/EL0 translations regime have been - * synchronized. - */ - asm volatile(ALTERNATIVE("nop", "isb", ARM64_WORKAROUND_AT_SPECULATE)); - WRITE_SYSREG64(p2m->vttbr, VTTBR_EL2); - - last_vcpu_ran = &p2m->last_vcpu_ran[smp_processor_id()]; - - /* - * While we are restoring an out-of-context translation regime - * we still need to ensure: - * - VTTBR_EL2 is synchronized before flushing the TLBs - * - All registers for EL1 are synchronized before executing an AT - * instructions targeting S1/S2. - */ - isb(); - - /* - * Flush local TLB for the domain to prevent wrong TLB translation - * when running multiple vCPU of the same domain on a single pCPU. - */ - if ( *last_vcpu_ran != INVALID_VCPU_ID && *last_vcpu_ran != n->vcpu_id ) - flush_guest_tlb_local(); - - *last_vcpu_ran = n->vcpu_id; -} - -/* - * Force a synchronous P2M TLB flush. - * - * Must be called with the p2m lock held. - */ -static void p2m_force_tlb_flush_sync(struct p2m_domain *p2m) -{ - unsigned long flags = 0; - uint64_t ovttbr; - - ASSERT(p2m_is_write_locked(p2m)); - - /* - * ARM only provides an instruction to flush TLBs for the current - * VMID. So switch to the VTTBR of a given P2M if different. - */ - ovttbr = READ_SYSREG64(VTTBR_EL2); - if ( ovttbr != p2m->vttbr ) - { - uint64_t vttbr; - - local_irq_save(flags); - - /* - * ARM64_WORKAROUND_AT_SPECULATE: We need to stop AT to allocate - * TLBs entries because the context is partially modified. We - * only need the VMID for flushing the TLBs, so we can generate - * a new VTTBR with the VMID to flush and the empty root table. - */ - if ( !cpus_have_const_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - vttbr = p2m->vttbr; - else - vttbr = generate_vttbr(p2m->vmid, empty_root_mfn); - - WRITE_SYSREG64(vttbr, VTTBR_EL2); - - /* Ensure VTTBR_EL2 is synchronized before flushing the TLBs */ - isb(); - } - - flush_guest_tlb(); - - if ( ovttbr != READ_SYSREG64(VTTBR_EL2) ) - { - WRITE_SYSREG64(ovttbr, VTTBR_EL2); - /* Ensure VTTBR_EL2 is back in place before continuing. */ - isb(); - local_irq_restore(flags); - } - - p2m->need_flush = false; -} - -void p2m_tlb_flush_sync(struct p2m_domain *p2m) -{ - if ( p2m->need_flush ) - p2m_force_tlb_flush_sync(p2m); -} - -/* - * Find and map the root page table. The caller is responsible for - * unmapping the table. - * - * The function will return NULL if the offset of the root table is - * invalid. - */ -static lpae_t *p2m_get_root_pointer(struct p2m_domain *p2m, - gfn_t gfn) -{ - unsigned long root_table; - - /* - * While the root table index is the offset from the previous level, - * we can't use (P2M_ROOT_LEVEL - 1) because the root level might be - * 0. Yet we still want to check if all the unused bits are zeroed. - */ - root_table = gfn_x(gfn) >> (XEN_PT_LEVEL_ORDER(P2M_ROOT_LEVEL) + - XEN_PT_LPAE_SHIFT); - if ( root_table >= P2M_ROOT_PAGES ) - return NULL; - - return __map_domain_page(p2m->root + root_table); -} - -/* - * Lookup the MFN corresponding to a domain's GFN. - * Lookup mem access in the ratrix tree. - * The entries associated to the GFN is considered valid. - */ -static p2m_access_t p2m_mem_access_radix_get(struct p2m_domain *p2m, gfn_t gfn) -{ - void *ptr; - - if ( !p2m->mem_access_enabled ) - return p2m->default_access; - - ptr = radix_tree_lookup(&p2m->mem_access_settings, gfn_x(gfn)); - if ( !ptr ) - return p2m_access_rwx; - else - return radix_tree_ptr_to_int(ptr); -} - -/* - * In the case of the P2M, the valid bit is used for other purpose. Use - * the type to check whether an entry is valid. - */ -static inline bool p2m_is_valid(lpae_t pte) -{ - return pte.p2m.type != p2m_invalid; -} - -/* - * lpae_is_* helpers don't check whether the valid bit is set in the - * PTE. Provide our own overlay to check the valid bit. - */ -static inline bool p2m_is_mapping(lpae_t pte, unsigned int level) -{ - return p2m_is_valid(pte) && lpae_is_mapping(pte, level); -} - -static inline bool p2m_is_superpage(lpae_t pte, unsigned int level) -{ - return p2m_is_valid(pte) && lpae_is_superpage(pte, level); -} - -#define GUEST_TABLE_MAP_FAILED 0 -#define GUEST_TABLE_SUPER_PAGE 1 -#define GUEST_TABLE_NORMAL_PAGE 2 - -static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry); - -/* - * Take the currently mapped table, find the corresponding GFN entry, - * and map the next table, if available. The previous table will be - * unmapped if the next level was mapped (e.g GUEST_TABLE_NORMAL_PAGE - * returned). - * - * The read_only parameters indicates whether intermediate tables should - * be allocated when not present. - * - * Return values: - * GUEST_TABLE_MAP_FAILED: Either read_only was set and the entry - * was empty, or allocating a new page failed. - * GUEST_TABLE_NORMAL_PAGE: next level mapped normally - * GUEST_TABLE_SUPER_PAGE: The next entry points to a superpage. - */ -static int p2m_next_level(struct p2m_domain *p2m, bool read_only, - unsigned int level, lpae_t **table, - unsigned int offset) -{ - lpae_t *entry; - int ret; - mfn_t mfn; - - entry = *table + offset; - - if ( !p2m_is_valid(*entry) ) - { - if ( read_only ) - return GUEST_TABLE_MAP_FAILED; - - ret = p2m_create_table(p2m, entry); - if ( ret ) - return GUEST_TABLE_MAP_FAILED; - } - - /* The function p2m_next_level is never called at the 3rd level */ - ASSERT(level < 3); - if ( p2m_is_mapping(*entry, level) ) - return GUEST_TABLE_SUPER_PAGE; - - mfn = lpae_get_mfn(*entry); - - unmap_domain_page(*table); - *table = map_domain_page(mfn); - - return GUEST_TABLE_NORMAL_PAGE; -} - -/* - * Get the details of a given gfn. - * - * If the entry is present, the associated MFN will be returned and the - * access and type filled up. The page_order will correspond to the - * order of the mapping in the page table (i.e it could be a superpage). - * - * If the entry is not present, INVALID_MFN will be returned and the - * page_order will be set according to the order of the invalid range. - * - * valid will contain the value of bit[0] (e.g valid bit) of the - * entry. - */ -mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn, - p2m_type_t *t, p2m_access_t *a, - unsigned int *page_order, - bool *valid) -{ - paddr_t addr = gfn_to_gaddr(gfn); - unsigned int level = 0; - lpae_t entry, *table; - int rc; - mfn_t mfn = INVALID_MFN; - p2m_type_t _t; - DECLARE_OFFSETS(offsets, addr); - - ASSERT(p2m_is_locked(p2m)); - BUILD_BUG_ON(THIRD_MASK != PAGE_MASK); - - /* Allow t to be NULL */ - t = t ?: &_t; - - *t = p2m_invalid; - - if ( valid ) - *valid = false; - - /* XXX: Check if the mapping is lower than the mapped gfn */ - - /* This gfn is higher than the highest the p2m map currently holds */ - if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) - { - for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) - if ( (gfn_x(gfn) & (XEN_PT_LEVEL_MASK(level) >> PAGE_SHIFT)) > - gfn_x(p2m->max_mapped_gfn) ) - break; - - goto out; - } - - table = p2m_get_root_pointer(p2m, gfn); - - /* - * the table should always be non-NULL because the gfn is below - * p2m->max_mapped_gfn and the root table pages are always present. - */ - if ( !table ) - { - ASSERT_UNREACHABLE(); - level = P2M_ROOT_LEVEL; - goto out; - } - - for ( level = P2M_ROOT_LEVEL; level < 3; level++ ) - { - rc = p2m_next_level(p2m, true, level, &table, offsets[level]); - if ( rc == GUEST_TABLE_MAP_FAILED ) - goto out_unmap; - else if ( rc != GUEST_TABLE_NORMAL_PAGE ) - break; - } - - entry = table[offsets[level]]; - - if ( p2m_is_valid(entry) ) - { - *t = entry.p2m.type; - - if ( a ) - *a = p2m_mem_access_radix_get(p2m, gfn); - - mfn = lpae_get_mfn(entry); - /* - * The entry may point to a superpage. Find the MFN associated - * to the GFN. - */ - mfn = mfn_add(mfn, - gfn_x(gfn) & ((1UL << XEN_PT_LEVEL_ORDER(level)) - 1)); - - if ( valid ) - *valid = lpae_is_valid(entry); - } - -out_unmap: - unmap_domain_page(table); - -out: - if ( page_order ) - *page_order = XEN_PT_LEVEL_ORDER(level); - - return mfn; -} - -mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t) -{ - mfn_t mfn; - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m_read_lock(p2m); - mfn = p2m_get_entry(p2m, gfn, t, NULL, NULL, NULL); - p2m_read_unlock(p2m); - - return mfn; -} - -struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn, - p2m_type_t *t) -{ - struct page_info *page; - p2m_type_t p2mt; - mfn_t mfn = p2m_lookup(d, gfn, &p2mt); - - if ( t ) - *t = p2mt; - - if ( !p2m_is_any_ram(p2mt) ) - return NULL; - - if ( !mfn_valid(mfn) ) - return NULL; - - page = mfn_to_page(mfn); - - /* - * get_page won't work on foreign mapping because the page doesn't - * belong to the current domain. - */ - if ( p2m_is_foreign(p2mt) ) - { - struct domain *fdom = page_get_owner_and_reference(page); - ASSERT(fdom != NULL); - ASSERT(fdom != d); - return page; - } - - return get_page(page, d) ? page : NULL; -} - -int guest_physmap_mark_populate_on_demand(struct domain *d, - unsigned long gfn, - unsigned int order) -{ - return -ENOSYS; -} - -unsigned long p2m_pod_decrease_reservation(struct domain *d, gfn_t gfn, - unsigned int order) -{ - return 0; -} - -static void p2m_set_permission(lpae_t *e, p2m_type_t t, p2m_access_t a) -{ - /* First apply type permissions */ - switch ( t ) - { - case p2m_ram_rw: - e->p2m.xn = 0; - e->p2m.write = 1; - break; - - case p2m_ram_ro: - e->p2m.xn = 0; - e->p2m.write = 0; - break; - - case p2m_iommu_map_rw: - case p2m_map_foreign_rw: - case p2m_grant_map_rw: - case p2m_mmio_direct_dev: - case p2m_mmio_direct_nc: - case p2m_mmio_direct_c: - e->p2m.xn = 1; - e->p2m.write = 1; - break; - - case p2m_iommu_map_ro: - case p2m_map_foreign_ro: - case p2m_grant_map_ro: - case p2m_invalid: - e->p2m.xn = 1; - e->p2m.write = 0; - break; - - case p2m_max_real_type: - BUG(); - break; - } - - /* Then restrict with access permissions */ - switch ( a ) - { - case p2m_access_rwx: - break; - case p2m_access_wx: - e->p2m.read = 0; - break; - case p2m_access_rw: - e->p2m.xn = 1; - break; - case p2m_access_w: - e->p2m.read = 0; - e->p2m.xn = 1; - break; - case p2m_access_rx: - case p2m_access_rx2rw: - e->p2m.write = 0; - break; - case p2m_access_x: - e->p2m.write = 0; - e->p2m.read = 0; - break; - case p2m_access_r: - e->p2m.write = 0; - e->p2m.xn = 1; - break; - case p2m_access_n: - case p2m_access_n2rwx: - e->p2m.read = e->p2m.write = 0; - e->p2m.xn = 1; - break; - } -} - -static lpae_t mfn_to_p2m_entry(mfn_t mfn, p2m_type_t t, p2m_access_t a) -{ - /* - * sh, xn and write bit will be defined in the following switches - * based on mattr and t. - */ - lpae_t e = (lpae_t) { - .p2m.af = 1, - .p2m.read = 1, - .p2m.table = 1, - .p2m.valid = 1, - .p2m.type = t, - }; - - BUILD_BUG_ON(p2m_max_real_type > (1 << 4)); - - switch ( t ) - { - case p2m_mmio_direct_dev: - e.p2m.mattr = MATTR_DEV; - e.p2m.sh = LPAE_SH_OUTER; - break; - - case p2m_mmio_direct_c: - e.p2m.mattr = MATTR_MEM; - e.p2m.sh = LPAE_SH_OUTER; - break; - - /* - * ARM ARM: Overlaying the shareability attribute (DDI - * 0406C.b B3-1376 to 1377) - * - * A memory region with a resultant memory type attribute of Normal, - * and a resultant cacheability attribute of Inner Non-cacheable, - * Outer Non-cacheable, must have a resultant shareability attribute - * of Outer Shareable, otherwise shareability is UNPREDICTABLE. - * - * On ARMv8 shareability is ignored and explicitly treated as Outer - * Shareable for Normal Inner Non_cacheable, Outer Non-cacheable. - * See the note for table D4-40, in page 1788 of the ARM DDI 0487A.j. - */ - case p2m_mmio_direct_nc: - e.p2m.mattr = MATTR_MEM_NC; - e.p2m.sh = LPAE_SH_OUTER; - break; - - default: - e.p2m.mattr = MATTR_MEM; - e.p2m.sh = LPAE_SH_INNER; - } - - p2m_set_permission(&e, t, a); - - ASSERT(!(mfn_to_maddr(mfn) & ~PADDR_MASK)); - - lpae_set_mfn(e, mfn); - - return e; -} - -/* Generate table entry with correct attributes. */ -static lpae_t page_to_p2m_table(struct page_info *page) -{ - /* - * The access value does not matter because the hardware will ignore - * the permission fields for table entry. - * - * We use p2m_ram_rw so the entry has a valid type. This is important - * for p2m_is_valid() to return valid on table entries. - */ - return mfn_to_p2m_entry(page_to_mfn(page), p2m_ram_rw, p2m_access_rwx); -} - -static inline void p2m_write_pte(lpae_t *p, lpae_t pte, bool clean_pte) -{ - write_pte(p, pte); - if ( clean_pte ) - clean_dcache(*p); -} - -static inline void p2m_remove_pte(lpae_t *p, bool clean_pte) -{ - lpae_t pte; - - memset(&pte, 0x00, sizeof(pte)); - p2m_write_pte(p, pte, clean_pte); -} - -/* Allocate a new page table page and hook it in via the given entry. */ -static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) -{ - struct page_info *page; - lpae_t *p; - - ASSERT(!p2m_is_valid(*entry)); - - page = p2m_alloc_page(p2m->domain); - if ( page == NULL ) - return -ENOMEM; - - page_list_add(page, &p2m->pages); - - p = __map_domain_page(page); - clear_page(p); - - if ( p2m->clean_pte ) - clean_dcache_va_range(p, PAGE_SIZE); - - unmap_domain_page(p); - - p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); - - return 0; -} - -static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, - p2m_access_t a) -{ - int rc; - - if ( !p2m->mem_access_enabled ) - return 0; - - if ( p2m_access_rwx == a ) - { - radix_tree_delete(&p2m->mem_access_settings, gfn_x(gfn)); - return 0; - } - - rc = radix_tree_insert(&p2m->mem_access_settings, gfn_x(gfn), - radix_tree_int_to_ptr(a)); - if ( rc == -EEXIST ) - { - /* If a setting already exists, change it to the new one */ - radix_tree_replace_slot( - radix_tree_lookup_slot( - &p2m->mem_access_settings, gfn_x(gfn)), - radix_tree_int_to_ptr(a)); - rc = 0; - } - - return rc; -} - -/* - * Put any references on the single 4K page referenced by pte. - * TODO: Handle superpages, for now we only take special references for leaf - * pages (specifically foreign ones, which can't be super mapped today). - */ -static void p2m_put_l3_page(const lpae_t pte) -{ - mfn_t mfn = lpae_get_mfn(pte); - - ASSERT(p2m_is_valid(pte)); - - /* - * TODO: Handle other p2m types - * - * It's safe to do the put_page here because page_alloc will - * flush the TLBs if the page is reallocated before the end of - * this loop. - */ - if ( p2m_is_foreign(pte.p2m.type) ) - { - ASSERT(mfn_valid(mfn)); - put_page(mfn_to_page(mfn)); - } - /* Detect the xenheap page and mark the stored GFN as invalid. */ - else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) - page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); -} - -/* Free lpae sub-tree behind an entry */ -static void p2m_free_entry(struct p2m_domain *p2m, - lpae_t entry, unsigned int level) -{ - unsigned int i; - lpae_t *table; - mfn_t mfn; - struct page_info *pg; - - /* Nothing to do if the entry is invalid. */ - if ( !p2m_is_valid(entry) ) - return; - - if ( p2m_is_superpage(entry, level) || (level == 3) ) - { -#ifdef CONFIG_IOREQ_SERVER - /* - * If this gets called then either the entry was replaced by an entry - * with a different base (valid case) or the shattering of a superpage - * has failed (error case). - * So, at worst, the spurious mapcache invalidation might be sent. - */ - if ( p2m_is_ram(entry.p2m.type) && - domain_has_ioreq_server(p2m->domain) ) - ioreq_request_mapcache_invalidate(p2m->domain); -#endif - - p2m->stats.mappings[level]--; - /* Nothing to do if the entry is a super-page. */ - if ( level == 3 ) - p2m_put_l3_page(entry); - return; - } - - table = map_domain_page(lpae_get_mfn(entry)); - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - p2m_free_entry(p2m, *(table + i), level + 1); - - unmap_domain_page(table); - - /* - * Make sure all the references in the TLB have been removed before - * freing the intermediate page table. - * XXX: Should we defer the free of the page table to avoid the - * flush? - */ - p2m_tlb_flush_sync(p2m); - - mfn = lpae_get_mfn(entry); - ASSERT(mfn_valid(mfn)); - - pg = mfn_to_page(mfn); - - page_list_del(pg, &p2m->pages); - p2m_free_page(p2m->domain, pg); -} - -static bool p2m_split_superpage(struct p2m_domain *p2m, lpae_t *entry, - unsigned int level, unsigned int target, - const unsigned int *offsets) -{ - struct page_info *page; - unsigned int i; - lpae_t pte, *table; - bool rv = true; - - /* Convenience aliases */ - mfn_t mfn = lpae_get_mfn(*entry); - unsigned int next_level = level + 1; - unsigned int level_order = XEN_PT_LEVEL_ORDER(next_level); - - /* - * This should only be called with target != level and the entry is - * a superpage. - */ - ASSERT(level < target); - ASSERT(p2m_is_superpage(*entry, level)); - - page = p2m_alloc_page(p2m->domain); - if ( !page ) - return false; - - page_list_add(page, &p2m->pages); - table = __map_domain_page(page); - - /* - * We are either splitting a first level 1G page into 512 second level - * 2M pages, or a second level 2M page into 512 third level 4K pages. - */ - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - { - lpae_t *new_entry = table + i; - - /* - * Use the content of the superpage entry and override - * the necessary fields. So the correct permission are kept. - */ - pte = *entry; - lpae_set_mfn(pte, mfn_add(mfn, i << level_order)); - - /* - * First and second level pages set p2m.table = 0, but third - * level entries set p2m.table = 1. - */ - pte.p2m.table = (next_level == 3); - - write_pte(new_entry, pte); - } - - /* Update stats */ - p2m->stats.shattered[level]++; - p2m->stats.mappings[level]--; - p2m->stats.mappings[next_level] += XEN_PT_LPAE_ENTRIES; - - /* - * Shatter superpage in the page to the level we want to make the - * changes. - * This is done outside the loop to avoid checking the offset to - * know whether the entry should be shattered for every entry. - */ - if ( next_level != target ) - rv = p2m_split_superpage(p2m, table + offsets[next_level], - level + 1, target, offsets); - - if ( p2m->clean_pte ) - clean_dcache_va_range(table, PAGE_SIZE); - - unmap_domain_page(table); - - /* - * Even if we failed, we should install the newly allocated LPAE - * entry. The caller will be in charge to free the sub-tree. - */ - p2m_write_pte(entry, page_to_p2m_table(page), p2m->clean_pte); - - return rv; -} - -/* - * Insert an entry in the p2m. This should be called with a mapping - * equal to a page/superpage (4K, 2M, 1G). - */ -static int __p2m_set_entry(struct p2m_domain *p2m, - gfn_t sgfn, - unsigned int page_order, - mfn_t smfn, - p2m_type_t t, - p2m_access_t a) -{ - unsigned int level = 0; - unsigned int target = 3 - (page_order / XEN_PT_LPAE_SHIFT); - lpae_t *entry, *table, orig_pte; - int rc; - /* A mapping is removed if the MFN is invalid. */ - bool removing_mapping = mfn_eq(smfn, INVALID_MFN); - DECLARE_OFFSETS(offsets, gfn_to_gaddr(sgfn)); - - ASSERT(p2m_is_write_locked(p2m)); - - /* - * Check if the level target is valid: we only support - * 4K - 2M - 1G mapping. - */ - ASSERT(target > 0 && target <= 3); - - table = p2m_get_root_pointer(p2m, sgfn); - if ( !table ) - return -EINVAL; - - for ( level = P2M_ROOT_LEVEL; level < target; level++ ) - { - /* - * Don't try to allocate intermediate page table if the mapping - * is about to be removed. - */ - rc = p2m_next_level(p2m, removing_mapping, - level, &table, offsets[level]); - if ( rc == GUEST_TABLE_MAP_FAILED ) - { - /* - * We are here because p2m_next_level has failed to map - * the intermediate page table (e.g the table does not exist - * and they p2m tree is read-only). It is a valid case - * when removing a mapping as it may not exist in the - * page table. In this case, just ignore it. - */ - rc = removing_mapping ? 0 : -ENOENT; - goto out; - } - else if ( rc != GUEST_TABLE_NORMAL_PAGE ) - break; - } - - entry = table + offsets[level]; - - /* - * If we are here with level < target, we must be at a leaf node, - * and we need to break up the superpage. - */ - if ( level < target ) - { - /* We need to split the original page. */ - lpae_t split_pte = *entry; - - ASSERT(p2m_is_superpage(*entry, level)); - - if ( !p2m_split_superpage(p2m, &split_pte, level, target, offsets) ) - { - /* - * The current super-page is still in-place, so re-increment - * the stats. - */ - p2m->stats.mappings[level]++; - - /* Free the allocated sub-tree */ - p2m_free_entry(p2m, split_pte, level); - - rc = -ENOMEM; - goto out; - } - - /* - * Follow the break-before-sequence to update the entry. - * For more details see (D4.7.1 in ARM DDI 0487A.j). - */ - p2m_remove_pte(entry, p2m->clean_pte); - p2m_force_tlb_flush_sync(p2m); - - p2m_write_pte(entry, split_pte, p2m->clean_pte); - - /* then move to the level we want to make real changes */ - for ( ; level < target; level++ ) - { - rc = p2m_next_level(p2m, true, level, &table, offsets[level]); - - /* - * The entry should be found and either be a table - * or a superpage if level 3 is not targeted - */ - ASSERT(rc == GUEST_TABLE_NORMAL_PAGE || - (rc == GUEST_TABLE_SUPER_PAGE && target < 3)); - } - - entry = table + offsets[level]; - } - - /* - * We should always be there with the correct level because - * all the intermediate tables have been installed if necessary. - */ - ASSERT(level == target); - - orig_pte = *entry; - - /* - * The radix-tree can only work on 4KB. This is only used when - * memaccess is enabled and during shutdown. - */ - ASSERT(!p2m->mem_access_enabled || page_order == 0 || - p2m->domain->is_dying); - /* - * The access type should always be p2m_access_rwx when the mapping - * is removed. - */ - ASSERT(!mfn_eq(INVALID_MFN, smfn) || (a == p2m_access_rwx)); - /* - * Update the mem access permission before update the P2M. So we - * don't have to revert the mapping if it has failed. - */ - rc = p2m_mem_access_radix_set(p2m, sgfn, a); - if ( rc ) - goto out; - - /* - * Always remove the entry in order to follow the break-before-make - * sequence when updating the translation table (D4.7.1 in ARM DDI - * 0487A.j). - */ - if ( lpae_is_valid(orig_pte) || removing_mapping ) - p2m_remove_pte(entry, p2m->clean_pte); - - if ( removing_mapping ) - /* Flush can be deferred if the entry is removed */ - p2m->need_flush |= !!lpae_is_valid(orig_pte); - else - { - lpae_t pte = mfn_to_p2m_entry(smfn, t, a); - - if ( level < 3 ) - pte.p2m.table = 0; /* Superpage entry */ - - /* - * It is necessary to flush the TLB before writing the new entry - * to keep coherency when the previous entry was valid. - * - * Although, it could be defered when only the permissions are - * changed (e.g in case of memaccess). - */ - if ( lpae_is_valid(orig_pte) ) - { - if ( likely(!p2m->mem_access_enabled) || - P2M_CLEAR_PERM(pte) != P2M_CLEAR_PERM(orig_pte) ) - p2m_force_tlb_flush_sync(p2m); - else - p2m->need_flush = true; - } - else if ( !p2m_is_valid(orig_pte) ) /* new mapping */ - p2m->stats.mappings[level]++; - - p2m_write_pte(entry, pte, p2m->clean_pte); - - p2m->max_mapped_gfn = gfn_max(p2m->max_mapped_gfn, - gfn_add(sgfn, (1UL << page_order) - 1)); - p2m->lowest_mapped_gfn = gfn_min(p2m->lowest_mapped_gfn, sgfn); - } - - if ( is_iommu_enabled(p2m->domain) && - (lpae_is_valid(orig_pte) || lpae_is_valid(*entry)) ) - { - unsigned int flush_flags = 0; - - if ( lpae_is_valid(orig_pte) ) - flush_flags |= IOMMU_FLUSHF_modified; - if ( lpae_is_valid(*entry) ) - flush_flags |= IOMMU_FLUSHF_added; - - rc = iommu_iotlb_flush(p2m->domain, _dfn(gfn_x(sgfn)), - 1UL << page_order, flush_flags); - } - else - rc = 0; - - /* - * Free the entry only if the original pte was valid and the base - * is different (to avoid freeing when permission is changed). - */ - if ( p2m_is_valid(orig_pte) && - !mfn_eq(lpae_get_mfn(*entry), lpae_get_mfn(orig_pte)) ) - p2m_free_entry(p2m, orig_pte, level); - -out: - unmap_domain_page(table); - - return rc; -} - -int p2m_set_entry(struct p2m_domain *p2m, - gfn_t sgfn, - unsigned long nr, - mfn_t smfn, - p2m_type_t t, - p2m_access_t a) -{ - int rc = 0; - - /* - * Any reference taken by the P2M mappings (e.g. foreign mapping) will - * be dropped in relinquish_p2m_mapping(). As the P2M will still - * be accessible after, we need to prevent mapping to be added when the - * domain is dying. - */ - if ( unlikely(p2m->domain->is_dying) ) - return -ENOMEM; - - while ( nr ) - { - unsigned long mask; - unsigned long order; - - /* - * Don't take into account the MFN when removing mapping (i.e - * MFN_INVALID) to calculate the correct target order. - * - * XXX: Support superpage mappings if nr is not aligned to a - * superpage size. - */ - mask = !mfn_eq(smfn, INVALID_MFN) ? mfn_x(smfn) : 0; - mask |= gfn_x(sgfn) | nr; - - /* Always map 4k by 4k when memaccess is enabled */ - if ( unlikely(p2m->mem_access_enabled) ) - order = THIRD_ORDER; - else if ( !(mask & ((1UL << FIRST_ORDER) - 1)) ) - order = FIRST_ORDER; - else if ( !(mask & ((1UL << SECOND_ORDER) - 1)) ) - order = SECOND_ORDER; - else - order = THIRD_ORDER; - - rc = __p2m_set_entry(p2m, sgfn, order, smfn, t, a); - if ( rc ) - break; - - sgfn = gfn_add(sgfn, (1 << order)); - if ( !mfn_eq(smfn, INVALID_MFN) ) - smfn = mfn_add(smfn, (1 << order)); - - nr -= (1 << order); - } - - return rc; -} - -/* Invalidate all entries in the table. The p2m should be write locked. */ -static void p2m_invalidate_table(struct p2m_domain *p2m, mfn_t mfn) -{ - lpae_t *table; - unsigned int i; - - ASSERT(p2m_is_write_locked(p2m)); - - table = map_domain_page(mfn); - - for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) - { - lpae_t pte = table[i]; - - /* - * Writing an entry can be expensive because it may involve - * cleaning the cache. So avoid updating the entry if the valid - * bit is already cleared. - */ - if ( !pte.p2m.valid ) - continue; - - pte.p2m.valid = 0; - - p2m_write_pte(&table[i], pte, p2m->clean_pte); - } - - unmap_domain_page(table); - - p2m->need_flush = true; -} +unsigned int __read_mostly max_vmid = MAX_VMID_8_BIT; +#endif /* - * The domain will not be scheduled anymore, so in theory we should - * not need to flush the TLBs. Do it for safety purpose. - * Note that all the devices have already been de-assigned. So we don't - * need to flush the IOMMU TLB here. + * Set to the maximum configured support for IPA bits, so the number of IPA bits can be + * restricted by external entity (e.g. IOMMU). */ -void p2m_clear_root_pages(struct p2m_domain *p2m) -{ - unsigned int i; - - p2m_write_lock(p2m); - - for ( i = 0; i < P2M_ROOT_PAGES; i++ ) - clear_and_clean_page(p2m->root + i); +unsigned int __read_mostly p2m_ipa_bits = PADDR_BITS; - p2m_force_tlb_flush_sync(p2m); +/* Unlock the flush and do a P2M TLB flush if necessary */ +void p2m_write_unlock(struct p2m_domain *p2m) +{ +#ifdef CONFIG_HAS_MMU + /* + * The final flush is done with the P2M write lock taken to avoid + * someone else modifying the P2M wbefore the TLB invalidation has + * completed. + */ + p2m_tlb_flush_sync(p2m); +#endif - p2m_write_unlock(p2m); + write_unlock(&p2m->lock); } -/* - * Invalidate all entries in the root page-tables. This is - * useful to get fault on entry and do an action. - * - * p2m_invalid_root() should not be called when the P2M is shared with - * the IOMMU because it will cause IOMMU fault. - */ -void p2m_invalidate_root(struct p2m_domain *p2m) +void memory_type_changed(struct domain *d) { - unsigned int i; +} - ASSERT(!iommu_use_hap_pt(p2m->domain)); +void dump_p2m_lookup(struct domain *d, paddr_t addr) +{ + struct p2m_domain *p2m = p2m_get_hostp2m(d); - p2m_write_lock(p2m); + printk("dom%d IPA 0x%"PRIpaddr"\n", d->domain_id, addr); - for ( i = 0; i < P2M_ROOT_LEVEL; i++ ) - p2m_invalidate_table(p2m, page_to_mfn(p2m->root + i)); + printk("P2M @ %p mfn:%#"PRI_mfn"\n", + p2m->root, mfn_x(page_to_mfn(p2m->root))); - p2m_write_unlock(p2m); + dump_pt_walk(page_to_maddr(p2m->root), addr, + P2M_ROOT_LEVEL, P2M_ROOT_PAGES); } -/* - * Resolve any translation fault due to change in the p2m. This - * includes break-before-make and valid bit cleared. - */ -bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn) +mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t) { + mfn_t mfn; struct p2m_domain *p2m = p2m_get_hostp2m(d); - unsigned int level = 0; - bool resolved = false; - lpae_t entry, *table; - - /* Convenience aliases */ - DECLARE_OFFSETS(offsets, gfn_to_gaddr(gfn)); - - p2m_write_lock(p2m); - /* This gfn is higher than the highest the p2m map currently holds */ - if ( gfn_x(gfn) > gfn_x(p2m->max_mapped_gfn) ) - goto out; + p2m_read_lock(p2m); + mfn = p2m_get_entry(p2m, gfn, t, NULL, NULL, NULL); + p2m_read_unlock(p2m); - table = p2m_get_root_pointer(p2m, gfn); - /* - * The table should always be non-NULL because the gfn is below - * p2m->max_mapped_gfn and the root table pages are always present. - */ - if ( !table ) - { - ASSERT_UNREACHABLE(); - goto out; - } + return mfn; +} - /* - * Go down the page-tables until an entry has the valid bit unset or - * a block/page entry has been hit. - */ - for ( level = P2M_ROOT_LEVEL; level <= 3; level++ ) - { - int rc; +struct page_info *p2m_get_page_from_gfn(struct domain *d, gfn_t gfn, + p2m_type_t *t) +{ + struct page_info *page; + p2m_type_t p2mt; + mfn_t mfn = p2m_lookup(d, gfn, &p2mt); - entry = table[offsets[level]]; + if ( t ) + *t = p2mt; - if ( level == 3 ) - break; + if ( !p2m_is_any_ram(p2mt) ) + return NULL; - /* Stop as soon as we hit an entry with the valid bit unset. */ - if ( !lpae_is_valid(entry) ) - break; + if ( !mfn_valid(mfn) ) + return NULL; - rc = p2m_next_level(p2m, true, level, &table, offsets[level]); - if ( rc == GUEST_TABLE_MAP_FAILED ) - goto out_unmap; - else if ( rc != GUEST_TABLE_NORMAL_PAGE ) - break; - } + page = mfn_to_page(mfn); /* - * If the valid bit of the entry is set, it means someone was playing with - * the Stage-2 page table. Nothing to do and mark the fault as resolved. + * get_page won't work on foreign mapping because the page doesn't + * belong to the current domain. */ - if ( lpae_is_valid(entry) ) + if ( p2m_is_foreign(p2mt) ) { - resolved = true; - goto out_unmap; + struct domain *fdom = page_get_owner_and_reference(page); + ASSERT(fdom != NULL); + ASSERT(fdom != d); + return page; } - /* - * The valid bit is unset. If the entry is still not valid then the fault - * cannot be resolved, exit and report it. - */ - if ( !p2m_is_valid(entry) ) - goto out_unmap; + return get_page(page, d) ? page : NULL; +} - /* - * Now we have an entry with valid bit unset, but still valid from - * the P2M point of view. - * - * If an entry is pointing to a table, each entry of the table will - * have there valid bit cleared. This allows a function to clear the - * full p2m with just a couple of write. The valid bit will then be - * propagated on the fault. - * If an entry is pointing to a block/page, no work to do for now. - */ - if ( lpae_is_table(entry, level) ) - p2m_invalidate_table(p2m, lpae_get_mfn(entry)); +int guest_physmap_mark_populate_on_demand(struct domain *d, + unsigned long gfn, + unsigned int order) +{ + return -ENOSYS; +} - /* - * Now that the work on the entry is done, set the valid bit to prevent - * another fault on that entry. - */ - resolved = true; - entry.p2m.valid = 1; +unsigned long p2m_pod_decrease_reservation(struct domain *d, gfn_t gfn, + unsigned int order) +{ + return 0; +} - p2m_write_pte(table + offsets[level], entry, p2m->clean_pte); +/* + * The domain will not be scheduled anymore, so in theory we should + * not need to flush the TLBs. Do it for safety purpose. + * Note that all the devices have already been de-assigned. So we don't + * need to flush the IOMMU TLB here. + */ +void p2m_clear_root_pages(struct p2m_domain *p2m) +{ + unsigned int i; - /* - * No need to flush the TLBs as the modified entry had the valid bit - * unset. - */ + p2m_write_lock(p2m); -out_unmap: - unmap_domain_page(table); + for ( i = 0; i < P2M_ROOT_PAGES; i++ ) + clear_and_clean_page(p2m->root + i); -out: - p2m_write_unlock(p2m); +#ifdef CONFIG_HAS_MMU + p2m_force_tlb_flush_sync(p2m); +#endif - return resolved; + p2m_write_unlock(p2m); } int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr, @@ -1612,44 +282,6 @@ int set_foreign_p2m_entry(struct domain *d, const struct domain *fd, return rc; } -static struct page_info *p2m_allocate_root(void) -{ - struct page_info *page; - unsigned int i; - - page = alloc_domheap_pages(NULL, P2M_ROOT_ORDER, 0); - if ( page == NULL ) - return NULL; - - /* Clear both first level pages */ - for ( i = 0; i < P2M_ROOT_PAGES; i++ ) - clear_and_clean_page(page + i); - - return page; -} - -static int p2m_alloc_table(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - - p2m->root = p2m_allocate_root(); - if ( !p2m->root ) - return -ENOMEM; - - p2m->vttbr = generate_vttbr(p2m->vmid, page_to_mfn(p2m->root)); - - /* - * Make sure that all TLBs corresponding to the new VMID are flushed - * before using it - */ - p2m_write_lock(p2m); - p2m_force_tlb_flush_sync(p2m); - p2m_write_unlock(p2m); - - return 0; -} - - static spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; /* @@ -1660,7 +292,7 @@ static spinlock_t vmid_alloc_lock = SPIN_LOCK_UNLOCKED; */ static unsigned long *vmid_mask; -static void p2m_vmid_allocator_init(void) +void p2m_vmid_allocator_init(void) { /* * allocate space for vmid_mask based on MAX_VMID @@ -1673,7 +305,7 @@ static void p2m_vmid_allocator_init(void) set_bit(INVALID_VMID, vmid_mask); } -static int p2m_alloc_vmid(struct domain *d) +int p2m_alloc_vmid(struct domain *d) { struct p2m_domain *p2m = p2m_get_hostp2m(d); @@ -1713,32 +345,6 @@ static void p2m_free_vmid(struct domain *d) spin_unlock(&vmid_alloc_lock); } -int p2m_teardown(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - unsigned long count = 0; - struct page_info *pg; - int rc = 0; - - p2m_write_lock(p2m); - - while ( (pg = page_list_remove_head(&p2m->pages)) ) - { - p2m_free_page(p2m->domain, pg); - count++; - /* Arbitrarily preempt every 512 iterations */ - if ( !(count % 512) && hypercall_preempt_check() ) - { - rc = -ERESTART; - break; - } - } - - p2m_write_unlock(p2m); - - return rc; -} - void p2m_final_teardown(struct domain *d) { struct p2m_domain *p2m = p2m_get_hostp2m(d); @@ -1771,61 +377,6 @@ void p2m_final_teardown(struct domain *d) p2m->domain = NULL; } -int p2m_init(struct domain *d) -{ - struct p2m_domain *p2m = p2m_get_hostp2m(d); - int rc; - unsigned int cpu; - - rwlock_init(&p2m->lock); - spin_lock_init(&d->arch.paging.lock); - INIT_PAGE_LIST_HEAD(&p2m->pages); - INIT_PAGE_LIST_HEAD(&d->arch.paging.p2m_freelist); - - p2m->vmid = INVALID_VMID; - p2m->max_mapped_gfn = _gfn(0); - p2m->lowest_mapped_gfn = _gfn(ULONG_MAX); - - p2m->default_access = p2m_access_rwx; - p2m->mem_access_enabled = false; - radix_tree_init(&p2m->mem_access_settings); - - /* - * Some IOMMUs don't support coherent PT walk. When the p2m is - * shared with the CPU, Xen has to make sure that the PT changes have - * reached the memory - */ - p2m->clean_pte = is_iommu_enabled(d) && - !iommu_has_feature(d, IOMMU_FEAT_COHERENT_WALK); - - /* - * Make sure that the type chosen to is able to store the an vCPU ID - * between 0 and the maximum of virtual CPUS supported as long as - * the INVALID_VCPU_ID. - */ - BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0]) * 8)) < MAX_VIRT_CPUS); - BUILD_BUG_ON((1 << (sizeof(p2m->last_vcpu_ran[0])* 8)) < INVALID_VCPU_ID); - - for_each_possible_cpu(cpu) - p2m->last_vcpu_ran[cpu] = INVALID_VCPU_ID; - - /* - * "Trivial" initialisation is now complete. Set the backpointer so - * p2m_teardown() and friends know to do something. - */ - p2m->domain = d; - - rc = p2m_alloc_vmid(d); - if ( rc ) - return rc; - - rc = p2m_alloc_table(d); - if ( rc ) - return rc; - - return 0; -} - /* * The function will go through the p2m and remove page reference when it * is required. The mapping will be removed from the p2m. @@ -2217,159 +768,6 @@ void __init p2m_restrict_ipa_bits(unsigned int ipa_bits) p2m_ipa_bits = ipa_bits; } -/* VTCR value to be configured by all CPUs. Set only once by the boot CPU */ -static register_t __read_mostly vtcr; - -static void setup_virt_paging_one(void *data) -{ - WRITE_SYSREG(vtcr, VTCR_EL2); - - /* - * ARM64_WORKAROUND_AT_SPECULATE: We want to keep the TLBs free from - * entries related to EL1/EL0 translation regime until a guest vCPU - * is running. For that, we need to set-up VTTBR to point to an empty - * page-table and turn on stage-2 translation. The TLB entries - * associated with EL1/EL0 translation regime will also be flushed in case - * an AT instruction was speculated before hand. - */ - if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - { - WRITE_SYSREG64(generate_vttbr(INVALID_VMID, empty_root_mfn), VTTBR_EL2); - WRITE_SYSREG(READ_SYSREG(HCR_EL2) | HCR_VM, HCR_EL2); - isb(); - - flush_all_guests_tlb_local(); - } -} - -void __init setup_virt_paging(void) -{ - /* Setup Stage 2 address translation */ - register_t val = VTCR_RES1|VTCR_SH0_IS|VTCR_ORGN0_WBWA|VTCR_IRGN0_WBWA; - - static const struct { - unsigned int pabits; /* Physical Address Size */ - unsigned int t0sz; /* Desired T0SZ, minimum in comment */ - unsigned int root_order; /* Page order of the root of the p2m */ - unsigned int sl0; /* Desired SL0, maximum in comment */ - } pa_range_info[] __initconst = { - /* T0SZ minimum and SL0 maximum from ARM DDI 0487H.a Table D5-6 */ - /* PA size, t0sz(min), root-order, sl0(max) */ -#ifdef CONFIG_ARM_64 - [0] = { 32, 32/*32*/, 0, 1 }, - [1] = { 36, 28/*28*/, 0, 1 }, - [2] = { 40, 24/*24*/, 1, 1 }, - [3] = { 42, 22/*22*/, 3, 1 }, - [4] = { 44, 20/*20*/, 0, 2 }, - [5] = { 48, 16/*16*/, 0, 2 }, - [6] = { 52, 12/*12*/, 4, 2 }, - [7] = { 0 } /* Invalid */ -#else - { 32, 0/*0*/, 0, 1 }, - { 40, 24/*24*/, 1, 1 } -#endif - }; - - unsigned int i; - unsigned int pa_range = 0x10; /* Larger than any possible value */ - -#ifdef CONFIG_ARM_32 - /* - * Typecast pa_range_info[].t0sz into arm32 bit variant. - * - * VTCR.T0SZ is bits [3:0] and S(sign extension), bit[4] for arm322. - * Thus, pa_range_info[].t0sz is translated to its arm32 variant using - * struct bitfields. - */ - struct - { - signed int val:5; - } t0sz_32; -#else - /* - * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured - * with IPA bits == PA bits, compare against "pabits". - */ - if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < p2m_ipa_bits ) - p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range].pabits; - - /* - * cpu info sanitization made sure we support 16bits VMID only if all - * cores are supporting it. - */ - if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) - max_vmid = MAX_VMID_16_BIT; -#endif - - /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ - for ( i = 0; i < ARRAY_SIZE(pa_range_info); i++ ) - { - if ( p2m_ipa_bits == pa_range_info[i].pabits ) - { - pa_range = i; - break; - } - } - - /* Check if we found the associated entry in the array */ - if ( pa_range >= ARRAY_SIZE(pa_range_info) || !pa_range_info[pa_range].pabits ) - panic("%u-bit P2M is not supported\n", p2m_ipa_bits); - -#ifdef CONFIG_ARM_64 - val |= VTCR_PS(pa_range); - val |= VTCR_TG0_4K; - - /* Set the VS bit only if 16 bit VMID is supported. */ - if ( MAX_VMID == MAX_VMID_16_BIT ) - val |= VTCR_VS; -#endif - - val |= VTCR_SL0(pa_range_info[pa_range].sl0); - val |= VTCR_T0SZ(pa_range_info[pa_range].t0sz); - - p2m_root_order = pa_range_info[pa_range].root_order; - p2m_root_level = 2 - pa_range_info[pa_range].sl0; - -#ifdef CONFIG_ARM_64 - p2m_ipa_bits = 64 - pa_range_info[pa_range].t0sz; -#else - t0sz_32.val = pa_range_info[pa_range].t0sz; - p2m_ipa_bits = 32 - t0sz_32.val; -#endif - - printk("P2M: %d-bit IPA with %d-bit PA and %d-bit VMID\n", - p2m_ipa_bits, - pa_range_info[pa_range].pabits, - ( MAX_VMID == MAX_VMID_16_BIT ) ? 16 : 8); - - printk("P2M: %d levels with order-%d root, VTCR 0x%"PRIregister"\n", - 4 - P2M_ROOT_LEVEL, P2M_ROOT_ORDER, val); - - p2m_vmid_allocator_init(); - - /* It is not allowed to concatenate a level zero root */ - BUG_ON( P2M_ROOT_LEVEL == 0 && P2M_ROOT_ORDER > 0 ); - vtcr = val; - - /* - * ARM64_WORKAROUND_AT_SPECULATE requires to allocate root table - * with all entries zeroed. - */ - if ( cpus_have_cap(ARM64_WORKAROUND_AT_SPECULATE) ) - { - struct page_info *root; - - root = p2m_allocate_root(); - if ( !root ) - panic("Unable to allocate root table for ARM64_WORKAROUND_AT_SPECULATE\n"); - - empty_root_mfn = page_to_mfn(root); - } - - setup_virt_paging_one(NULL); - smp_call_function(setup_virt_paging_one, NULL, 1); -} - static int cpu_virt_paging_callback(struct notifier_block *nfb, unsigned long action, void *hcpu) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:49:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:49:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573608.898471 (Exim 4.92) (envelope-from ) id 1qQgNh-0004vM-NN; Tue, 01 Aug 2023 03:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573608.898471; Tue, 01 Aug 2023 03:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgNh-0004vF-KN; Tue, 01 Aug 2023 03:49:09 +0000 Received: by outflank-mailman (input) for mailman id 573608; Tue, 01 Aug 2023 03:49:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgK4-00076X-B1 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id d799d204-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:45:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7769D11FB; Mon, 31 Jul 2023 20:46:05 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D45903F59C; Mon, 31 Jul 2023 20:45:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d799d204-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Wei Chen , Henry Wang Subject: [PATCH v4 12/13] xen/arm: mmu: relocate copy_from_paddr() to setup.c Date: Tue, 1 Aug 2023 11:44:18 +0800 Message-Id: <20230801034419.2047541-13-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng Function copy_from_paddr() is defined in asm/setup.h, so it is better to be implemented in setup.c. Current copy_from_paddr() implementation is mmu-specific, so this commit moves copy_from_paddr() into mmu/setup.c, and it is also benefical for us to implement MPU version of copy_from_paddr() in later commit. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen Signed-off-by: Henry Wang --- v4: - No change v3: - new commit --- xen/arch/arm/kernel.c | 27 --------------------------- xen/arch/arm/mmu/setup.c | 27 +++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c index 508c54824d..0d433a32e7 100644 --- a/xen/arch/arm/kernel.c +++ b/xen/arch/arm/kernel.c @@ -41,33 +41,6 @@ struct minimal_dtb_header { #define DTB_MAGIC 0xd00dfeedU -/** - * copy_from_paddr - copy data from a physical address - * @dst: destination virtual address - * @paddr: source physical address - * @len: length to copy - */ -void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) -{ - void *src = (void *)FIXMAP_ADDR(FIXMAP_MISC); - - while (len) { - unsigned long l, s; - - s = paddr & (PAGE_SIZE-1); - l = min(PAGE_SIZE - s, len); - - set_fixmap(FIXMAP_MISC, maddr_to_mfn(paddr), PAGE_HYPERVISOR_WC); - memcpy(dst, src + s, l); - clean_dcache_va_range(dst, l); - clear_fixmap(FIXMAP_MISC); - - paddr += l; - dst += l; - len -= l; - } -} - static void __init place_modules(struct kernel_info *info, paddr_t kernbase, paddr_t kernend) { diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c index e05cca3f86..889ada6b87 100644 --- a/xen/arch/arm/mmu/setup.c +++ b/xen/arch/arm/mmu/setup.c @@ -329,6 +329,33 @@ void __init setup_mm(void) } #endif +/* + * copy_from_paddr - copy data from a physical address + * @dst: destination virtual address + * @paddr: source physical address + * @len: length to copy + */ +void __init copy_from_paddr(void *dst, paddr_t paddr, unsigned long len) +{ + void *src = (void *)FIXMAP_ADDR(FIXMAP_MISC); + + while (len) { + unsigned long l, s; + + s = paddr & (PAGE_SIZE-1); + l = min(PAGE_SIZE - s, len); + + set_fixmap(FIXMAP_MISC, maddr_to_mfn(paddr), PAGE_HYPERVISOR_WC); + memcpy(dst, src + s, l); + clean_dcache_va_range(dst, l); + clear_fixmap(FIXMAP_MISC); + + paddr += l; + dst += l; + len -= l; + } +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 03:49:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 03:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573609.898477 (Exim 4.92) (envelope-from ) id 1qQgNi-0004z9-3d; Tue, 01 Aug 2023 03:49:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573609.898477; Tue, 01 Aug 2023 03:49:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgNh-0004x5-T0; Tue, 01 Aug 2023 03:49:09 +0000 Received: by outflank-mailman (input) for mailman id 573609; Tue, 01 Aug 2023 03:49:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgK8-00076X-Bt for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 03:45:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id da11a0b3-301d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 05:45:26 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8DDD2D75; Mon, 31 Jul 2023 20:46:09 -0700 (PDT) Received: from a015966.shanghai.arm.com (a015966.shanghai.arm.com [10.169.190.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3617E3F59C; Mon, 31 Jul 2023 20:45:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da11a0b3-301d-11ee-8613-37d641c3527e From: Henry Wang To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Penny Zheng , Wei Chen , Henry Wang Subject: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Date: Tue, 1 Aug 2023 11:44:19 +0800 Message-Id: <20230801034419.2047541-14-Henry.Wang@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng SMMU subsystem is only supported in MMU system, so we make it dependent on CONFIG_HAS_MMU. Signed-off-by: Penny Zheng Signed-off-by: Wei Chen Signed-off-by: Henry Wang --- v4: - No change v3: - new patch --- xen/drivers/passthrough/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig index 864fcf3b0c..5a8d666829 100644 --- a/xen/drivers/passthrough/Kconfig +++ b/xen/drivers/passthrough/Kconfig @@ -5,6 +5,7 @@ config HAS_PASSTHROUGH if ARM config ARM_SMMU bool "ARM SMMUv1 and v2 driver" + depends on HAS_MMU default y ---help--- Support for implementations of the ARM System MMU architecture @@ -15,7 +16,7 @@ config ARM_SMMU config ARM_SMMU_V3 bool "ARM Ltd. System MMU Version 3 (SMMUv3) Support" if EXPERT - depends on ARM_64 && (!ACPI || BROKEN) + depends on ARM_64 && (!ACPI || BROKEN) && HAS_MMU ---help--- Support for implementations of the ARM System MMU architecture version 3. Driver is in experimental stage and should not be used in -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 04:06:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 04:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573628.898491 (Exim 4.92) (envelope-from ) id 1qQgeG-0000JL-GN; Tue, 01 Aug 2023 04:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573628.898491; Tue, 01 Aug 2023 04:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgeG-0000JE-D8; Tue, 01 Aug 2023 04:06:16 +0000 Received: by outflank-mailman (input) for mailman id 573628; Tue, 01 Aug 2023 04:06:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgeF-0000J8-HT for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 04:06:15 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0d5a720-3020-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 06:06:13 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 37145drD098717 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 1 Aug 2023 00:05:44 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 37145aIv098716; Mon, 31 Jul 2023 21:05:36 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0d5a720-3020-11ee-b258-6b7b168915f2 Date: Mon, 31 Jul 2023 21:05:36 -0700 From: Elliott Mitchell To: Ian Jackson Cc: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= , xen-devel@lists.xenproject.org, wl@xen.org, Anthony PERARD , Juergen Gross Subject: Re: Python in Domain Configurations Message-ID: References: <25799.60117.528120.26189@chiark.greenend.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <25799.60117.528120.26189@chiark.greenend.org.uk> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Mon, Jul 31, 2023 at 06:09:41PM +0100, Ian Jackson wrote: > Elliott Mitchell writes ("Re: Python in Domain Configurations"): > > On Mon, Jul 31, 2023 at 05:59:55AM +0200, Marek Marczykowski-Górecki wrote: > > > So, IMHO reducing config file from a full python (like it used to be in > > > xend times) into a static file with well defined syntax was an > > > improvement. Lets not go backward. > > I'm no longer working on this codebase, but since I've been CC'd: > > I was one of the people who replaced the Python-based config parsing > with the current arrangements. We didn't just do this because we were > replacing xend (whose use of Python as implementation language made it > appear convenient to just read and execute the configs as Python > code). > > We did it for the reasons Marek gives. It's true that the existing > format is not as well specified as it could be. It was intended as a > plausible subset of Python literal syntax. We chose that syntax to > preserve compatibility with the vast majority of existing config files > and to provide something familiar. (And it seems we did achieve those > goals.) > > The disk configuration syntax is particularly warty, but we inherited > much of that from the Python version. Okay. I do note allowing full Python does make domain creation by script easier. While I have one use for re-adding the functionality, I'm sure someone else would come up with other high-value ones. > > > As for your original problem, IIUC you would like to add some data that > > > would _not_ be interpreted by libxl, right? For that you can use > > > comments with some specific marker for your script. This approach used > > > to work well for SysV init script, and in fact for a very similar use case > > > (ordering and dependencies, among other things). > > > > That is /not/ the issue. `xl` simply ignores any variables which it > > doesn't interpret (this is in fact a Bad Thing). > > I forget, but isn't there some kind of scheme for warning about > unrecognised configuration options ? There certainly should be and there may have been one in the past, but no there isn't one now. One advantage for using Python is processed data could be removed when creating the domain and anything left over could be warned about. Though such could be added to the existing parser too. > > I need to know what the limits to the syntax are. > > I agree that it's not great that the syntax is not 100% documented. > The parser is in > tools/libs/util/libxlu_cfg_y.y > tools/libs/util/libxlu_cfg_l.l > I'm sure patches to improve the docs would be welcome. That is merely the DFA for the grammar. There is a bunch of extra for interfacing with the parser, then there is the layer above. > Note that it is still a *subset* of Python, so if you wish to use a > Python interpreter to parse it in your own tooling, you're very > welcome to do so. Yup, and this will make that simpler. Having Python dictionaries would make some things even easier though. > > Notice how many init scripts do `. /etc/default/` to load > > configuration? I'm thinking it would be very handy to use a similar > > technique to load domain.cfg files, with Python being the interpreter. > > I don't think this is a good idea. Both because I don't think the > functionality available in a Python interpreter should be available in > the libxl configuration, and because Python is a large and complex > dependency which we don't want to pull in here. While PvGRUB and Tianocore seem likely to displace PyGRUB, PyGRUB still functions on ARM (which PvGRUB isn't ported to yet). As such there is still a dependency. Too me the greater concern is the daemon process. Issue is, for the daemon process the large amount of functionality built into `xl` is a similar liability. Even the temporary data seems a large liability for the daemon. Additionally if that was a separate executable, then the process name could be changed via execve() and make it clearer that process was expected to remain behind. > > I also think some portions of the domain.cfg format might work better > > with full Python syntax. For example might it be handier to allow: > > > > disk = [ > > { > > 'vdev': 'xvda', > > 'format': 'raw', > > 'access': 'rw', > > 'target': '/dev/disk/by-path/foo-bar-baz', > > }, > > ] > > I agree that something like this would be nice. I don't think it > should be done by importing Python. These two files - the main part > of the existing parser - is only 183 loc including comments. > Extending it (and the support code in libxlu_cfg.c) to do dictionaries > as well as lists doesn't seem like it would make it too much bigger. That ignores all the interfacing code. Add in the interfacing and it is closer to 2000 lines. If you merely count the file parser that is only 1000 lines. I suspect I could interface to libpython with 200-300 lines. Those would allow far more functionality than what is currently implemented. On Mon, Jul 31, 2023 at 05:59:55AM +0200, Marek Marczykowski-Górecki wrote: > I don't know full history here, but from my point of view, having a > full-fledged script as a config file is undesirable for several reasons: > - it's easy to have unintended side effects of just loading a config > file > - loading config file can no longer be assumed to be "cheap" If you use full Python functionality in the domain.cfg files, it could indeed do interesting things during config load. This though is good reason not to do those things. Include in documentation, "please don't use complicated Python functionality in domain configurations"? Guarding against this seems to be trying to guard against shooting oneself in the foot. Users will find ways to cause odd situations no matter what you do. > - dynamic config file means you can no long rely on file timestamp/hash > to check if anything changed (I don't think it's an issue for the > current xl/libxl, but could be for some higher level tools) I'm not looking for dynamic configurations. I'm mostly thinking of allowing better configuration constructs. Both disks and network could use Python dictionaries for a better structure. > - leads to issues with various sandboxes - for example SELinux policy > allowing scripted config file would be excessively permissive I suspect someone not using complex Python constructs could have simpler SE Linux policy. Having done a bit of experimentation, it appears libpython can be made to disable some functionality during loading. Notably it appears one could restrict Python to mostly dumb assignments during loading. Further, if this got to the stage of a PoC it should be possible for it to live alongside the existing parser for a time. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 04:19:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 04:19:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573526.898501 (Exim 4.92) (envelope-from ) id 1qQgqc-0001wN-IQ; Tue, 01 Aug 2023 04:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573526.898501; Tue, 01 Aug 2023 04:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgqc-0001wG-Fh; Tue, 01 Aug 2023 04:19:02 +0000 Received: by outflank-mailman (input) for mailman id 573526; Tue, 01 Aug 2023 00:13:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQd17-0007Yy-4m for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 00:13:37 +0000 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [2607:f8b0:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 414c6172-3000-11ee-b257-6b7b168915f2; Tue, 01 Aug 2023 02:13:35 +0200 (CEST) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1bba54f7eefso39462175ad.1 for ; Mon, 31 Jul 2023 17:13:35 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9100:2cb0::61c9]) by smtp.gmail.com with ESMTPSA id x3-20020a170902ea8300b001b8c3c7b102sm9160290plb.127.2023.07.31.17.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 17:13:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 414c6172-3000-11ee-b257-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690848814; x=1691453614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=g4l/cMUxkTocSYYbqSa4Kr4GL8OndltKGe18dhbWtXXBcu5LRWbh3iWJMnbCSrNhuP s1qwEb0i+pxo8jDwEBf9XhgHt0VGOqnpLjNJIzELUN8ByoPHGzDA3rChjSBQCjJuTNmO Q81WoR1YVrlUtHtRKRIBlLV9bBGTC/yrWxF2Ozor+1MckGk6KRmfW9KRz78lDhrLOKmV sKt+WaexQHGwOEN1QWpLP+aBaGqkdCH/GkNejNIopkvclCfdOs1llwq21oN9DiXeaJAP mAHuUG0E++qzUwbvR3Nd8q0rIRs2+ZYx+/4I5452Cyk3RO8dIV2ee4N6IMsX1w44n8O/ FgUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690848814; x=1691453614; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=i7pSGFUmaGKdxcCbKcxmGQZFDtf/DGhE4TdQO+dDESbFJe1TAWUUozL1oc5YqOudhp m6bNdID2dxe+czj59l4nBMAMBLmpkTLXZkcqShEkwJqPvlfK/ewmJKLAdLWHVAUlQjVb FOkX0LiRKVA4pAx37o74eQOVVAkXJLGGcVcn0ywIWnBxU4LNtwj2Ra2Rcgqk3/RJUOVe z4K/veP2dnywXH7K96Y2Skkk+qLWyaYSzCJnquUtglRJBberGrpwPUaATVHI/25izqNO KMeTfsRoiUCNaX8ELEG1R4yq7Vr/l6DKR72FkzRcgrVhSa0kxCKi6BWuudzADr3YKYoS 63IQ== X-Gm-Message-State: ABy/qLbYr3pYFrlsMBKKWjidj5OB+aXYLKjlCI8cokSEUHY7af1fKilM v2hzB9zKHjnHFNVsipJJDcs4ErAILBl7sg== X-Google-Smtp-Source: APBJJlH7rAUhoXCdbru0CWT/GEfhYM8bsWPRlsV0sb/xjZ8HY3XcI0zymX5ckofHgoeAbv0RwdsROA== X-Received: by 2002:a17:902:e5c5:b0:1b2:676d:1143 with SMTP id u5-20020a170902e5c500b001b2676d1143mr15089937plf.15.1690848813956; Mon, 31 Jul 2023 17:13:33 -0700 (PDT) From: Khem Raj To: xen-devel@lists.xenproject.org Cc: Khem Raj Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive Date: Mon, 31 Jul 2023 17:12:58 -0700 Message-ID: <20230801001258.555944-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Assembler from binutils 2.41 rejects this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execstr Switch to using ELF syntax .section name[, "flags"[, @type]] [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 Signed-off-by: Khem Raj --- xen/arch/arm/arm32/proc-v7.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index c90a31d80f..6d3d19b873 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -29,7 +29,7 @@ brahma15mp_init: mcr CP32(r0, ACTLR) mov pc, lr - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca15mp_proc_info, #object __v7_ca15mp_proc_info: .long 0x410FC0F0 /* Cortex-A15 */ @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: .long caxx_processor .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca7mp_proc_info, #object __v7_ca7mp_proc_info: .long 0x410FC070 /* Cortex-A7 */ @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: .long caxx_processor .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_brahma15mp_proc_info, #object __v7_brahma15mp_proc_info: .long 0x420F00F0 /* Broadcom Brahma-B15 */ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 04:19:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 04:19:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573528.898507 (Exim 4.92) (envelope-from ) id 1qQgqc-0001zp-SL; Tue, 01 Aug 2023 04:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573528.898507; Tue, 01 Aug 2023 04:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQgqc-0001zc-Ob; Tue, 01 Aug 2023 04:19:02 +0000 Received: by outflank-mailman (input) for mailman id 573528; Tue, 01 Aug 2023 00:17:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQd4c-0007cZ-OL for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 00:17:14 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c254d0b3-3000-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 02:17:12 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bbc87ded50so31646695ad.1 for ; Mon, 31 Jul 2023 17:17:12 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9100:2cb0::61c9]) by smtp.gmail.com with ESMTPSA id g6-20020a170902740600b001b03842ab78sm9116656pll.89.2023.07.31.17.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 17:17:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c254d0b3-3000-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690849030; x=1691453830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=gnQHITvmAqheMxwdIdbSevZa/UKreSmE0N3u9RwQPyLUzc/4qCPfbLDsYKknGqC/Vz O41VPUl2G9yQplzzLsCYaeC5okwzF63JaLtIfUyxB14zOibJk3x0I1B9+dIPIj9388NX CFhTl9G9VXeHg/l+CnixMyMnxZMceEl2vpBhVG6VuEUvmVvnv3Lf7ojk4jL10jj8ylHM 8lHJQHgaGyAv5R7W/tU0p1Nlr3t1sXlQOEaF88h7a5q+Wwg7NP2GWIkrvQNj4814HAZb Re86dIqp9XBqfiymMK7kFSnHaISKO8tSQdOspM28iXlcBREf2MDilHB45dxvLZNnamOq eDSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690849030; x=1691453830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZUFItuirOVPJCbtBystcht3mbxhNZnp6hC1vcTbgIWQ=; b=Fhrif++vlq3n9pW1mGM3w2vnh36WwQLbpx5IZa+mBkxFiMYO1bo0CZkNtWqc64c6Iz 9PfmzDexzAGzqACVCzUL7xYBUujrXIE45IaA1Tbf1zcU05r7XVE5O2hQnQThDfdBTgpA HmLFWPLAhf9sCi5LeGhqpBdZP0URXQVRLHTU5R+WNDsiaINPeJdEftGXVI8mKxYrem82 XNO9/bDUfX6pR4AOWhh7/tDCfNbsUmWkK9CcnSXZNJ2gSfJ+aMG8DQNFe4eXaKbm6u2r yqnTTmlWJBWbLHlTurvIOp0Tv4r1pLYpKpOwn8ZxhPoUrZ+8wjJs7vpSo1Dtfrz5uarD 0Xbw== X-Gm-Message-State: ABy/qLazvfwjVH2Wq+rds8cTQtmO7NcPuQULhbIn+TnFEaKY6VjZUbW2 S+spEd0/JrvcwUXbhM3BEX2v0Vu93ESYXg== X-Google-Smtp-Source: APBJJlGRyDXLqmBGFHOVTybceq4cX5Va+EF/1UdvEwMhbjtfzQKCjrKh38g1Hyg6juqQRfEiMlApbw== X-Received: by 2002:a17:902:a40d:b0:1bb:20ee:e29e with SMTP id p13-20020a170902a40d00b001bb20eee29emr10646642plq.1.1690849030465; Mon, 31 Jul 2023 17:17:10 -0700 (PDT) From: Khem Raj To: xen-devel@lists.xenproject.org Cc: Khem Raj Subject: [PATCH] arm32: Avoid using solaris syntax for .section directive Date: Mon, 31 Jul 2023 17:17:07 -0700 Message-ID: <20230801001707.556040-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Assembler from binutils 2.41 rejects this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execstr Switch to using ELF syntax .section name[, "flags"[, @type]] [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 Signed-off-by: Khem Raj --- xen/arch/arm/arm32/proc-v7.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index c90a31d80f..6d3d19b873 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -29,7 +29,7 @@ brahma15mp_init: mcr CP32(r0, ACTLR) mov pc, lr - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca15mp_proc_info, #object __v7_ca15mp_proc_info: .long 0x410FC0F0 /* Cortex-A15 */ @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: .long caxx_processor .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca7mp_proc_info, #object __v7_ca7mp_proc_info: .long 0x410FC070 /* Cortex-A7 */ @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: .long caxx_processor .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_brahma15mp_proc_info, #object __v7_brahma15mp_proc_info: .long 0x420F00F0 /* Broadcom Brahma-B15 */ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:02:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:02:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573643.898521 (Exim 4.92) (envelope-from ) id 1qQiSY-0005TK-5W; Tue, 01 Aug 2023 06:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573643.898521; Tue, 01 Aug 2023 06:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiSY-0005TD-2z; Tue, 01 Aug 2023 06:02:18 +0000 Received: by outflank-mailman (input) for mailman id 573643; Tue, 01 Aug 2023 06:02:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiSX-0005T7-5m for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:02:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062d.outbound.protection.outlook.com [2a01:111:f400:7e1a::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6c888e8-3030-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:02:15 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB9126.eurprd04.prod.outlook.com (2603:10a6:20b:449::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 06:02:13 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 06:02:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6c888e8-3030-11ee-b258-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MnAcJlPfDSZ7LkZZ5QakF7zAqsyNSHzTgww3UHTVVG3fPh8k8uOGmIyt29avpoNv2JblDlVlA5BlT6poo3nhDpiwA4675j7f76f/14BpxR+/pR799RdlUm4VeK/Ee+o2OAn27TyR5zBN+cJHgfPBm6iwX2wohP4AYoNN6aum4SsTujqJum+xt/XNSvxeVBdudlDw9uLqHveLHmJGWm6695jWOWY45HgrZ0ynKD4k+oiN2p4nUqwVLWTS9wCoNlPuTSnYKo1yAXQlKGCGU+g1ZgaZrNNoPasMSaR139DgBqMSJFw5Z0W3RkNZRmymtf1sneQK+tEzorA+3n0RpNRuyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VSdxrGNiCrZdrayjyWvZ3Jn8fHxqXvISrwMl3XFogzQ=; b=PQN0v2BZKMtLpom/H1HbOYJKWUwAXsfg8mplvIPAWj9b6KC3oZwXfQxiC1AsfMdx7/MnCq3nKMMnIDkzfa62R1M7ydBfUP3vHB3PmYqIFNLyBDomB/rYSK2ry21ieLlL0eWEB2wqb3qm6w4avRQwYVFWLA6Eaqhmp7FfkfNL0h7MdKawj7wzAzrGR6fnCrfhBXxqojRfOCiXQz0PT6OQ5XXnEovCrd/4+2gucrmaF7ufQLjaXXvsMjRXffC7bT4HApgtnGw0z/IFt4M1/pHgwGAVRInmAk7dsL0OEMbNaqI1F7hojsUu2PaRVMivGL6BqCo5Ua6Qf61lTsi1d3yjgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VSdxrGNiCrZdrayjyWvZ3Jn8fHxqXvISrwMl3XFogzQ=; b=1FAJ+ohBPKSLBCA2VyA+sQajmGae6dXoIIHupIXUlt/tjpOhh00JaAbU0r++QoMtGihqIgrMBCjpZ697bXdcOYNZVddSja+xf0Qla0wbOe08OPELq28GEpr0neWUp1qlvHQh5gP9CIY25uysw6BVALPIECbzfsbiz7Fn4CHdOESvcrCbNZGuimOodf2g8cWkR3lVOSKRds0jN5MKrAEq0Q8sl5VCUNC5TJc/4aPwVnxbsrvui3J8AL53x3WLOw0qQZ/j1l2SOAWl2N4MeKWUlM/6FAOusEix3Qon9agr+HXplOHdk33VXaQun8GGAKgl1uPlKZbewsdyz+lp3GcZyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <40bc7e49-c4be-3d89-c401-347ccf92faac@suse.com> Date: Tue, 1 Aug 2023 08:02:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 1/5] xen/lib: Move simple_strtoul from common/vsprintf.c to lib Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <294e48747a0f9aee0be4fd178fcab029fa317528.1690579561.git.sanastasio@raptorengineering.com> <0127f163-a96b-447b-5a1d-da048f293ea2@raptorengineering.com> From: Jan Beulich In-Reply-To: <0127f163-a96b-447b-5a1d-da048f293ea2@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::22) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB9126:EE_ X-MS-Office365-Filtering-Correlation-Id: 5791594b-5ded-4c3f-0093-08db9254d987 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8B8ciYkJcTxttGTqkn10sat5QyJepFAgt8xBOfcuwJBhWnvuJE+Dl/046ycdCQ+dy9gqJkFMuP2XwRG7l6XtTTtDXpp2P3erPiBpJteNSzbJGOpl+Zah9+yDfA7s/0bSJpRGJHTOGR7IE/qYAMhBi2TOAZmZkC/iEc3YKa45uGJU8jlivLwiEBgJyDrYqq2aNFnAd4ZjcQT9z+rBYxWtGt4cZz+3GC0BJEH89kjSaqhel3TpxV+wePV+lxx4IUs3R5Fnugi3j6GcroPzvP8fYCaZGN50zwRkVsuLpjMFXvrP4nUuLR0dDLGxg1xYMdmwUpEGzJ8otaYzEiGbiON6Synze222VhycXlwgvZ7rFwGytPZBKIl+/PG+x44ec0z3wS/gYhKJf8DHjpawmYzVqpdR8Q0xWGSge5vB+LXMzstxZt3qaTZCAQGCkWE4KGd8skWF6sjG7HKIQj5IvlNxnrIJZ3A+PG3Bf9ix/wCKm8aAwJmdjx36E4foYaWTgIggclRHvEHRe/9VXkHJep3mhCEDLTMFG1/9wEkJ1G8GYusCvBLRiqCnxs1tvQNkCqsZ1EHBdA75qSMjBRLJuX8UHbP5qHUKtwQdtU+khZi04cl0kv6VfcPkytCaBGtVoSASWJE/02pasJ43B6FF/EqeDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199021)(6512007)(6486002)(36756003)(2616005)(53546011)(6506007)(26005)(83380400001)(186003)(66946007)(66556008)(54906003)(41300700001)(38100700002)(31696002)(86362001)(66476007)(316002)(5660300002)(6916009)(4326008)(8676002)(8936002)(31686004)(2906002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTNwQzRsemRYZWpERmF2RnZHS0FlbnU0aEZXWm9QOERjT1hkeEgyMWI2ajRU?= =?utf-8?B?THJlQlhhNW9SemN6bFNjbklVcXkvUk9UT1doa2Jtd2cyRWFWM2hqbWJHaFNT?= =?utf-8?B?MGhyOURFSGFiS0YycnljVy9rQStFaFVkWjJwRHE4MjU1WHRRMUpzVHJjemEz?= =?utf-8?B?VTU4TjNERFFkVUt0em1LYVd0TW53NkZzQm5NWUx4bmYzRkFQV0pDbXBSS0do?= =?utf-8?B?T0lQbWNBU2pYMVpPK2hVWUl6QWdyS3pLYlo2NGRIK01YZDFUWUF0MzJBd1Ny?= =?utf-8?B?RkIyTGQ4c2JsTTdiMzBMcitFMkU5NG5TSEFtamdJOVIzaEk2S0VaUEliUTQr?= =?utf-8?B?K3kyY25SN05aM3lTNmEvL1JZWnlYT0pyMU1uTlQ5Qi9yQTNRL2lMeEpMNERT?= =?utf-8?B?Mk9acCtNaG1KSUtYcmZ2eTBGc1B6VjJEYkJLNzEzVG5IdU1mVWgzMFV1dTI5?= =?utf-8?B?U3RxOU4xc280VEd1dDJGZlEvZWIrdG1tSzdKcUZCdG4zWkVxSUdyMkFMZlRm?= =?utf-8?B?VEE3OGw4dU1BYjBRbVd0NUF3N0lSejl5TUlnTmR4YU81YU1qVzFmRVVNREFU?= =?utf-8?B?Y1Vmd2MxRzdMZjRrSlB0WXI2cDdtYWFkRzQvNTk0bkNyblNZTSttbFhoMFJx?= =?utf-8?B?U0JiRGpjT3dHQW1zZCtoYmtmS0NFV3BZT3Y3MzZwenN0VmtxbEJ5dHh2NS9K?= =?utf-8?B?d3p1OFdQQ1pBcFZyblkzbVdycTJVanlSODVmNUhCVmYyckNvaURMdlczTXdR?= =?utf-8?B?YVJZYW1NV3BHSndqOUp3TUR4RVc4OEhTbmg3K1V3WWJyNllPZkkxeVRwOFZo?= =?utf-8?B?MHdHSHdUcXJiSHFFTXpmWThOV2VlTzk4NzA0ZU1URVFFZHpiZ3lwNjBQZ0Iy?= =?utf-8?B?NW1wcStZNGllMlZXVEFua1NXNnQ0ZWhza1UrWENGcnRxTktQa3owUERZdmRr?= =?utf-8?B?Tk5yVG1QV0tTQ0ZNUndlNHhwY0xMRndKWXVyb0xxOWR2TDFwL1RuVk5BdXNT?= =?utf-8?B?QXBYaXg5UHF2blpzdGNHV1dyN1hrMVFrOHJwYllIdGcwTzBKTXpMRXRFWHpu?= =?utf-8?B?TUVxbDNyUzVOZFJTTms1djlhT0hDQ0Z6NUphV2VqeWM0RDhNYU1veTdMR1pG?= =?utf-8?B?Rkx5Si9qVTBKcVNWVmtJcWRETzRqcnVUNnhieEI1UGhxSmVpTW45emhsTUdY?= =?utf-8?B?aWpyMUtkWkE3WkxrclAzY284djRVMWpTZ2VHSld6Y1FQM05aRDNYNkFHb0pX?= =?utf-8?B?TDRWeTZoZzFzTGxsZS9CeU9pNFpEdjJpMFFBUmtpUjB6OVZZUjJ0L1FCc1hl?= =?utf-8?B?OTgreTNNcTF3WnptNVQxNVluQk9UdElobzFpc29VR0haYjMwWGdEUzM5SklR?= =?utf-8?B?N3lPTGs0UC90ZzV1bVFCMm5hMGRaWDJaY3ZBSmtmRmlleHp1NWhmMHNsRXlM?= =?utf-8?B?VElqNHBucDMzMFNzV09KdlNVWFYvL1ZsRHJrWEZYZXJNOHhlc1NIZGhIS3VX?= =?utf-8?B?emx3S0ZOS3dsL2NEdGY3MXI0Tnk2T3E3M0JtRFZHM24rNXpqMWRLbGlDTmg0?= =?utf-8?B?ZDJjb1pad0VDRm5NWnRmTVRuVUlEaDB3VkNjVCttNEJuN3hVdVhBRkJRa29J?= =?utf-8?B?ajlFS1NmNFMxOXlHTDdHR2lCODg2Nmd5VnlhNmg5L0lLU1J3dXFVQ2tnMnZH?= =?utf-8?B?bVh1OW05QWpkSmhNSnpReHJKY3pac3pMYzBBUTZqM0JLOC9OTjRnTDlWZFdE?= =?utf-8?B?NzdQUmtLVCs0ODBNRmdpVUE5WWp1Yi9Zb0sxRitreFJISitzeTR6dVBQZStI?= =?utf-8?B?SUlTMUFpQ1N3Kzl5WVg4VGFtRHIzbHNBTGh6a0dZdGJPU0YyMzd4RlZzQURn?= =?utf-8?B?OFBDczAzalBpTVJtcjVKajVuM3hBeXpqelVQSG55bEw1MXNMYmp6OVN3ZUwv?= =?utf-8?B?UEdDbTFybGdUYzRONGc2eUxZUkZwSGptRkxHWDh0K2J1dERyeERhSXMwT3h0?= =?utf-8?B?VlJyK3dVSDgvZDdNek5DZ0NZZHJtSjFicE0yZHRmd3JvZ2tPRmo0NzRFaDd1?= =?utf-8?B?cWFnWExqZDMwZmExT282cXRRcmR5OUFvSERlUGswMUtXVmo1b1Rab2ZtQ09Z?= =?utf-8?Q?I7b+4+HiRUb1F5JytOW9jYASl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5791594b-5ded-4c3f-0093-08db9254d987 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 06:02:12.9001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3aNC/asvel6FMJQcVnL5SXWoqRjjCwkepTnwDRAwZfenyGTnef8aC+X8FXrEtmTK96jsXZzvQ/ppPYNPfAu7pA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9126 On 31.07.2023 21:03, Shawn Anastasio wrote: > On 7/31/23 10:52 AM, Jan Beulich wrote: >> On 28.07.2023 23:35, Shawn Anastasio wrote: >>> Move the simple_strtoul routine which is used throughout the codebase >>> from vsprintf.c to its own file in xen/lib. >>> >>> This allows libfdt to be built on ppc64 even though xen/common doesn't >>> build yet. >>> >>> Signed-off-by: Shawn Anastasio >>> --- >>> xen/common/vsprintf.c | 37 ------------------------------------- >>> xen/lib/Makefile | 1 + >>> xen/lib/simple_strtoul.c | 40 ++++++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 41 insertions(+), 37 deletions(-) >>> create mode 100644 xen/lib/simple_strtoul.c >> >> What about its siblings? It'll be irritating to find one here and the >> other there. > > I was debating whether to do this or not and ultimately decided to only > make the minimum changes that were required right now. I can go ahead > and make the change for its siblings as well. > >> Also please no underscores in (new) filenames unless there's a reason >> for this. In the case here, though, I question the need for "simple" >> in the file name in the first place. > > From a look at the other files in xen/lib there seemed to be a > convention of naming files after the exact function they implement. > Would you rather I rename it to just strtoul.c? Or simple-strotoul.c? I'd prefer the former over the latter. While your observation of convention has been true so far, I think the shorter names are to be preferred here. They're not going to cause issues, as I don't see us gaining non-simple_* functions. >>> --- /dev/null >>> +++ b/xen/lib/simple_strtoul.c >>> @@ -0,0 +1,40 @@ >>> +/* >>> + * Copyright (C) 1991, 1992 Linus Torvalds >>> + */ >>> + >>> +#include >>> + >>> +/** >>> + * simple_strtoul - convert a string to an unsigned long >>> + * @cp: The start of the string >>> + * @endp: A pointer to the end of the parsed string will be placed here >>> + * @base: The number base to use >>> + */ >>> +unsigned long simple_strtoul( >>> + const char *cp, const char **endp, unsigned int base) >>> +{ >>> + unsigned long result = 0,value; >>> + >>> + if (!base) { >>> + base = 10; >>> + if (*cp == '0') { >>> + base = 8; >>> + cp++; >>> + if ((toupper(*cp) == 'X') && isxdigit(cp[1])) { >>> + cp++; >>> + base = 16; >>> + } >>> + } >>> + } else if (base == 16) { >>> + if (cp[0] == '0' && toupper(cp[1]) == 'X') >>> + cp += 2; >>> + } >>> + while (isxdigit(*cp) && >>> + (value = isdigit(*cp) ? *cp-'0' : toupper(*cp)-'A'+10) < base) { >>> + result = result*base + value; >>> + cp++; >>> + } >>> + if (endp) >>> + *endp = cp; >>> + return result; >>> +} >> >> While moving, I think it would be nice if this stopped using neither >> Xen nor Linux style. I'm not going to insist, but doing such style >> adjustments right here would be quite nice. > > Especially if I'm going to be moving its siblings, I'd rather just copy > the functions verbatim for this patch, if that's acceptable. As said - I wouldn't insist, but in this case maybe I take the time and make the slightly more "complete" change. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:05:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573648.898531 (Exim 4.92) (envelope-from ) id 1qQiVW-00067c-O1; Tue, 01 Aug 2023 06:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573648.898531; Tue, 01 Aug 2023 06:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiVW-00067V-LR; Tue, 01 Aug 2023 06:05:22 +0000 Received: by outflank-mailman (input) for mailman id 573648; Tue, 01 Aug 2023 06:05:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiVV-00067N-In for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:05:21 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20622.outbound.protection.outlook.com [2a01:111:f400:7eaf::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 646293f9-3031-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:05:19 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9722.eurprd04.prod.outlook.com (2603:10a6:10:4c7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42; Tue, 1 Aug 2023 06:05:16 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 06:05:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 646293f9-3031-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=md+UJ0ui4xmgE5wH7Cot6YDK40K77/akSoOAW/VQPIYpexG+wPHUlBIVSfGM2IxayzDgDrgLIcHScbf3nVfXqUqImenSb4DpbApg6sajbSRwiHziEZQiTSI0Mbd0J8DwETF+W8GuGtQvuIvAnRv7F2DGHKpk3Wgn7uLu40sshN0di/BP8iJ8MN3RE8u5A3kzxWoXinqX2Oot3lsuKd6Pu0Y4rdDbMgHe9nvdjtoAfKTiNiphY1oc0vkJUZHJMqMN++oLQ2SJg8A8cdqcPh6Y3Q4Yw1HbjP/hBiLe0BdBBL3AdkO7G8ar7DoCI49ykCsKAonPnsGWMG3AoCuR40ZbGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AhPl0SC7stn5KY8OCYXi8U52DpOh3sVv03quWlKBUJo=; b=IpuYTLiXv4m4hQvk9VeYpeem7Duo/9uLbSTBHXTdNVtkk9wbIv1rQsdkjOfo7HSDkhHFBQCC16us+r8Ki6AahDx4vnrkQIvUK2r75Zbk+YZhNpx2+dM7U43vfV8zhliTjQ9jqI0HisiRNtSi6TM+AIJtnSj3KuCDxR0oDUtaVheGT01VJwcadXEyeLzuHHf8sF2qwS4dBrTiZKGCSkKxL0hwZPv9wKCjGDYcH/z2potYJoAu3qNTpRtSqXvbixz3vp5xCRh5x/oQ0pf/9DuB/DxqtT7jab7INuJFWwVAZ2qGzhIdqXavR9KL3PH4DS0O/N0ulZ3/gE+ciINDUwcd3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AhPl0SC7stn5KY8OCYXi8U52DpOh3sVv03quWlKBUJo=; b=G0LKhQ41OV2tZsaCl/RzCQfmQ3zZhwuRXAspdh3B4bS64kvNJgl5F5MMLqCxLw6Impv0EwR6oMSmm/SgxVndMP5B3hwV4Q04hh0MiBsVxBs+PAcQTUwcD/0Xj0vuBlno91JoK9w7yVlMIbkoYIC1gK0+0qzK4qCrPmJWsJO05pGwzvqYK0wkjXqeByNYtV0K+CSmlWgmBAqQubo+4o/fFFyFD1SAfQF4BNdIvtl9NgyQVU9BbVXy/QHeZ//zpm251cTq4MmhokN70jXbR/Xf9ymskVf8jrZHWCLQA8O0Jq0IOuFEdpoMXyyXXMyRpl6g9AB/iqqhUJBWo6kw3Gz0cQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <72b624be-b379-6419-38cb-880bb19741c6@suse.com> Date: Tue, 1 Aug 2023 08:05:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <335ce2a18f8cce679dd8b30d11560989131b4337.1690579561.git.sanastasio@raptorengineering.com> <904d9448-1fd8-bcd7-2cbd-c9e5752dec66@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0247.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9722:EE_ X-MS-Office365-Filtering-Correlation-Id: 69ecb7e3-2a62-4b38-10b1-08db9255470f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X/m6gVkH9KyiqGPMc5pBAtnNilw7wUTzH1oi2qQbO/ZN957RFgAH/oW3B5+ipIJ8FCSewGEubyOjhe9BdEB1Npx2WSRDUUli6edYr5qDoTawoAeBq9cLFWqTPgVvt6ouuAk9VAxkEaGD63YOY5BzT7QEvps1VUnuPxTIeo5KM/TIaUJJ9xjERYhNy+VWNsv5BrBwxMwUTvymkBobNVxMfH8URNp9wTUY/P1v6PLGFaIjL6fYo+CxVgJ/7scw+o9vnQMxWGfv9J5hSwaJblBbT9oqs1vNqFzTrYA7DFXICMeA2/8dtqvmxS8s0JMyvLaa/RCZ0NJ70B7j89F+0TGD1v7UmfDwvMtsjE4OPozLUMcqVw8LubcYhkJsv75WLiZegkQiCLdD9ATT8QdoRQBZVYpcXSTR4Pw7RiIXM6hLsVsHpkEET8nuaSqg64u5bKrSpoU6H6M+MrnF2rFcOuBsmQAjIzk8hklV7BbuTfpByu65u3zdYKByw7ChOkLUWaaw8TWVSUEyGFZy0uJsioQfu9L2PsdVFJvkQWYnBrhSJU2ScSxruHRgIBksO0Z9TUa8DA5UAvut0aMNnpGjng87Kh3HqCHyEXrey8V61mXHXC7T3tGm80pT1bx88uRnXk9sbDVO9ROMg/slmHfdYhCp8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199021)(36756003)(478600001)(38100700002)(31696002)(86362001)(6512007)(6486002)(2616005)(53546011)(186003)(26005)(8676002)(8936002)(6506007)(31686004)(5660300002)(4326008)(2906002)(66556008)(6916009)(66946007)(66476007)(41300700001)(54906003)(316002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0JsSVFGbG90OGVyYlJaTHppT2l5RGkwSVFiUFU1UFBFU0ZyMVE2MFg1RXpq?= =?utf-8?B?dnBjV0hYb3ovY21wWWZwT21icTNCQnpQenNyQ0RIaVNMU0h2MDViRWRXMzR2?= =?utf-8?B?VkZlWDltTzBzeENTWElNOFlkcHpFS1N4bVFYbk5KbXN6bGFMQ1U1U05yeVNP?= =?utf-8?B?L2M5Smw1c1Z4aEZKekhwdDdSZm1TeVZKZFVKSi8yNmdCaldxRndsTXU1RGdK?= =?utf-8?B?R09Zb2lRM0Jna1ZRazZjRUQ5L0pEV1Z2VkRseXBGZzFydjFjTHVJaUVXOW1w?= =?utf-8?B?d1Iva01BYmZpZ1ZQanVNQldzdmN2L1lUK2l5cTlIRTlTcW1kclZqNUtBVzBQ?= =?utf-8?B?eFJ6aFpKS2c2cW9kekljY0ZBcU15UW1UZWR0M2VNM2F0cWJvdzhGWjNKSFFl?= =?utf-8?B?UmsrZlJPS2pVaHMzeWc2cXMwUnZlZU1lUFpQRE0rZjFmZlRPeGViTU4xODla?= =?utf-8?B?R3REeXFxZWJydGdpekZZQlBJbW1pdWlvUFEzbEtJWTNaLzRVUzh6ZnUrbkZk?= =?utf-8?B?c0VoZVRCZ1hRSER0MFVoOUJsbVNtQ0Q2TWJvZ3FlcnFNQzB2aVpZNjloV3hh?= =?utf-8?B?czM0VGNUYmkzQU5hSlVrdGFiclJ1ZnZacis3YTAyNWpzQllUNHdYc3I2MUwv?= =?utf-8?B?TlFUdTRvVFNVY0hNb2R0SVFTTmxPSE9FelJUUVNTMWl5OUpyVFhSK1A3dWtY?= =?utf-8?B?R0FMdVlZRHBhRnBUd3V2N0RDYWh6MGJZQk9mSVdGSHBybHF5SFRjTHhlMWlM?= =?utf-8?B?VytmUXpFV3hSSEJOWTVSMmJsNkJES3FCSEZ6TGp6TFdFS0p6dVBaMGN4TXRJ?= =?utf-8?B?ajE5MEpXKzY4WWd2dUo3V0RQVDV6amNYZWxST2xSVFpXUCtBM2l3NHRXUUhZ?= =?utf-8?B?ZWREcE5nMzN3TGlKOG50bzd2L2o0eG1ua0p1cjYxTTdaNjlIQ0xrYnJCWjBr?= =?utf-8?B?ZlJNSjlSemJ0M3N4MlROcWEwcEtxY3NMaTlxR3NvMmNJdTE0MG1PRGZZWWsw?= =?utf-8?B?S2JzNEZoQis1M0l5WVZZdm5jR3lJaHdESi9YUUxsVzBRdEpPV3hXZGYwMDdk?= =?utf-8?B?cVNQNWdGamU0TGh4MUFaVVZEMkVTVTJsb3Rtdyt5QjBNNUtNeFBKTGNvRkRt?= =?utf-8?B?alhWblVqeWFJd1poeksweG5HMk9YV0FEWjd3ZWJXOXljdW82cjhLZFZ5TVBD?= =?utf-8?B?dmFKaisrRHdPcU0vNjBiSUx1VGRPalNRQ3V0QW5UdGY4dmRGMG11UWpnQlN2?= =?utf-8?B?NUd1TU04MWJEdUJXZ0tEQmhqRktIYlZ6QjN3SzRtM1dsTVZpWGNKZGhacWt1?= =?utf-8?B?eGRoTVJPbmNIa282cDY3TCtiNFpDYjJKMmdMTzNQdjBUMGhhandwUmEvTTgv?= =?utf-8?B?eHhPK0N5OVlhaGVrd2YvQ1VFalRsR09mdTNrTUZlZU5TRU5QTFZlOWJLeXNh?= =?utf-8?B?SDRERG9jb2MwVm1mb05JNzRES2V2TDJId2dSUXpYSFNDTVExQ0xaZm0xM2E4?= =?utf-8?B?L0pGNnZnNnMvZWlZcTY1VmE4U3VIeTQzY3ZHaEhLdTBGZzFwa294V0RUa2Vn?= =?utf-8?B?UG8rZnBsbFV5ZUxpbWxVUEhsNjJtVDBLK3A2bVhlQ2ZqaENjT2dmcFBoZkVh?= =?utf-8?B?dDl3bUVXOFNzMnc2MkFyQ1I0eVJEVm01aDZxdWVmN3k2cDQ1bndlOVNCOFZV?= =?utf-8?B?M1NKeFBJZW5QUklEV1NRS2JKZFltNXl3c3FRZDhFdHlub0l3ZUpremZCWTM4?= =?utf-8?B?WGJ0VldkNDkzZ0JJYTZBVFo5V0N1Zis5OUdDUG5IekwvMDU2akhobE1QVDVO?= =?utf-8?B?U285UVdtZVJweXNtMTJMQWI5SXBEWUw3S2tVelBtUldkSUw1OTBtVXBFWTFR?= =?utf-8?B?UjJIaDZTMVNMWExxc3RIQXFHd2F3UStoMzVWOVArbUFYa1lLQURMUEwxQlZH?= =?utf-8?B?b3gxS0FqbnZkRE5hK1BCNkFOc1hsb29jUHgzZWV2NXZnb2NzYUxIeWNtV3ls?= =?utf-8?B?R0VQYzU4YkNHbGtML29yNXJRM0I0cWJSakJUQXlyTFovOVdOb05SSnBBMFNs?= =?utf-8?B?WlFSZWozSEZ4aCtKam53ZDJJWEswK0JOVGJPbEQ2UXN1c0Y1ZERaUFhwTS9m?= =?utf-8?Q?DbgkTQDdDinlgLsvopAKJ639+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69ecb7e3-2a62-4b38-10b1-08db9255470f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 06:05:16.6374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0RNkwsQnnezv7FycZYTKaL8IZiiFLQ/9aJnde5anzKeSi126KWPqxjS+iRB9Xi6bcJeOj2eNgeCvgE+CwTr0+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9722 On 31.07.2023 21:09, Shawn Anastasio wrote: > On 7/31/23 10:58 AM, Jan Beulich wrote: >> On 28.07.2023 23:35, Shawn Anastasio wrote: >>> --- a/xen/arch/ppc/ppc64/head.S >>> +++ b/xen/arch/ppc/ppc64/head.S >>> @@ -1,9 +1,11 @@ >>> /* SPDX-License-Identifier: GPL-2.0-or-later */ >>> >>> #include >>> +#include >>> >>> .section .text.header, "ax", %progbits >>> >>> + >>> ENTRY(start) >> >> Nit: Stray change? >> >>> @@ -11,16 +13,19 @@ ENTRY(start) >>> FIXUP_ENDIAN >>> >>> /* set up the TOC pointer */ >>> - LOAD_IMM32(%r2, .TOC.) >>> + bcl 20, 31, .+4 >> >> Could you use a label name instead of .+4? Aiui you really mean >> >>> +1: mflr %r12 >> >> ... "1f" there? > > Yes, good point. I'll point out that this form of the `bcl` instruction > is specifically defined in the ISA specification as the recommended > way to obtain the address of the next instruction, and hardware > implementations presumably optimize it. Using a label instead of +4 > would of course be fine as long as the label immediately follows the > bcl, but if the label was elsewhere then the optimization that the ISA > allows for this specific instruction might not be hit. Just something > that should be kept in mind in case this code is ever refactored. Hmm, not really. If there was refactoring, the calculations using 1b would also need adjusting. That's why it's relevant that all "sides" agree on using one and the same label. (A similar "optimization" exists in x86 as well, just fyi, so we have precedent of that.) > I'll change it to 1f in v2. Thanks. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:09:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:09:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573654.898542 (Exim 4.92) (envelope-from ) id 1qQiZ2-0006jK-7B; Tue, 01 Aug 2023 06:09:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573654.898542; Tue, 01 Aug 2023 06:09:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiZ2-0006jD-47; Tue, 01 Aug 2023 06:09:00 +0000 Received: by outflank-mailman (input) for mailman id 573654; Tue, 01 Aug 2023 06:08:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiZ0-0006j7-S3 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:08:58 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2088.outbound.protection.outlook.com [40.107.13.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6947f01-3031-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:08:57 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB9909.eurprd04.prod.outlook.com (2603:10a6:102:385::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 06:08:28 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 06:08:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6947f01-3031-11ee-b258-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWrbfhe9GHv1x+iFTPRndnrpcADcqsf/5vjs5LaxYzHkolZNZcXasR7/bDy80lc8410KmY10KPmx9cWupWATHS6WWg5njYRRW9q1fRawTcU/PVzQEztNYXfZNi6RB0qGNHgINaDNW5jfnjhRik0F9mo57TxPb3C4ifwjfP4invisnoJV2Ca+i2BUhqnlWnO5dZUq382mg6VBZ73nCktODnfcsS2TCEfXtJwTve5N1Qp5uMgVdqzekAKsa1kttKDSXcLbqZRyOnL9sA14xXKGBEckIIrczDwUzawu53qE7QXBvLEcy41vwH/WW0lnyJ694bdWx7/IMcGKYrnvU/952g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MIfs5hKDkqyiT/bwRsOXNBcxi8l2PnB/lLqev8A8das=; b=U4XM2hwxeV9seoLA/iOOor4FHexbNmHR0Qf391u89RK0kmxvSwoY9CHij/79X0CnJB8hCWI/yk+OAV+Z6UdvtoSXOH7fpIR0ZM7MKKF/JWo390vANEwd8Lx9SfYzPC+6bZ4u4nR6vw3XGHdrFBHZYzhMz2aQtiqIlngdWpFTHtVU17wUYvBbkndH1zdAJQi1Nv57Q/jNijGrLIHQs+4WaNetywASsfkpFxIExbQkboE0jXU4BliTBfVZ3HshwfxUX4IWkQva9ib8AbvnuHrurggbsRQUxWm1N6Rt3RAIbpexWfwe2Z5DsTZVAi8mkeTf06TNS4k4ovhMIdRfBNnejA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MIfs5hKDkqyiT/bwRsOXNBcxi8l2PnB/lLqev8A8das=; b=lyL0SwspmZkUH5ZShiYFThuv3uST9Z1k/0yIQIZB+ukHti61hKPj5B7zZQ5uz6U8J2jMC9mOJzjjTfIGA3oryGq7j7N+slC77+V2t6G5iRR8CnJkCuc4vcaRFUj7YhBZYYGntrudoaFvjFrkTuc2LE2UOhSODrj4kI49TuYEKH+3svGqrFCjMgm/+X/mRm4fijdAVtVWdeslsx/F7iUYHuz7374Bvc9dOsI67MmxyAZw29sRNHvTtZSLLvuJ7yHpe5ISObMdRjZlTzhoBwfVRBhMhVqOoEz9rrY9V+DHbm0yZy010hOP0588lak/WV/tpUQ+vEHi2puolzZHQk+RmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Aug 2023 08:08:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 2/3] xen/ppc: Relocate kernel to physical address 0 on boot Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <0802fad2743526da4fe49f0225e14161464f192e.1690582001.git.sanastasio@raptorengineering.com> <3b6b0984-89fb-268e-970a-0c7eb19a4863@suse.com> <428aa0e8-70bb-efb5-2b5a-54229b77c5a3@raptorengineering.com> From: Jan Beulich In-Reply-To: <428aa0e8-70bb-efb5-2b5a-54229b77c5a3@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0180.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB9909:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c96a3b5-132d-4ec9-7857-08db9255b954 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GB0tnogLCahuieDJ/Wa8T944Y8T8MUfMzeOAksBgeWHjaY3N7XYK8EYYYhI5hzkH8/ccb4zEAQiKuh12B2uqqODlEaeHcP/qFidAVK21IkzivpydXBxgyFMMnyibrn91qzYJLD2XRofilaMXgnvN7L36QxBetFI1GnrJTO8l5Q+HKvjfCgsJWVD9gPfVclO4TRdoWjh/olgcnxjn0E2bzNj3JDbYAb2niaUGcZ9Da7tj30lRAWn9QY5VNcdsX0W6XErrs+fKlThmOvc+0HEluqitEu+GN+koVMs6f6lfyczgy51wE2PpAGqbH31dFkAbL9J1qU7b5GDd7O8PTiHK+h1+6eb5+Q0rtKk4fKfucjx86bPhdx+xuJrrWMrhDlRMiapx4HaAEvXrXzwWzItISULYeGbYE0/MLMrE0+W81AwxA3WngNv0DtaQNbKeNmXwVexATdmCFOtPB3RVMSafsWg4QYLwKYE95whxK3fZtZl39CMfY102m5WK2w+oOE5oQJtdaILOTWD1YTqPu5r4EjCxY5vpPutb6oXKdcrvzUuOXI3MWxuw4HqgmZCeaAmV4cIc+OGCX6qhZr+pJe9l2+F4Cir+qtFxg1CmA+iJTizvIcxTah6YZen625ZyGxu9TVoj3YErDdux5BAiqLAKwA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199021)(6512007)(6486002)(36756003)(2616005)(53546011)(6506007)(26005)(186003)(66946007)(66556008)(54906003)(41300700001)(38100700002)(31696002)(86362001)(66476007)(316002)(5660300002)(6916009)(4326008)(8676002)(8936002)(31686004)(2906002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1psS3V2SDVFeTViNkdNNS8xUm9obUxzcUNub1I1Q0FiQUZaMDh5ZmpIMUwz?= =?utf-8?B?VHFuUFRoRzlXSk5zVk9rVVpKQzNTekpGV2kzaW1lY1ErT3hwd1l4bjFualZL?= =?utf-8?B?enRCVDRGVDRZcllZajFkdnNZUnNHQSs3OGNVbkpBTDExRlZEVFY4c2xQNlJE?= =?utf-8?B?d0pPWHdLNXlPcGc1Y2VUZlRINFdtVXBNZlJYeHg5T0V5M3ZxR0J3TTF3YmZj?= =?utf-8?B?MTl2WTViYU5ZcUduUnozZHR0bG9vRGFvM3BBWlhqQklFbGZpWjRqa1QxN3FI?= =?utf-8?B?Yjk4eVovNlYzNHNUTGZEL1pzMW0raTFxallycDQ2UDhGd3E3M3htMTUrYmJa?= =?utf-8?B?c2ZuV1UyRFlEa3JvUGdCSVQ4bmlJcGgwb3kxVUkvQ0VMRjRJcWVYcDhjdFZo?= =?utf-8?B?R1lYeENkQy9WdGQ1U1g1dklJRGR3WWFpSWZLVHNOdzRsbFNWemJWK0cyZDVq?= =?utf-8?B?d2NBMzFMdTdHN0VXQ29XYWRtdUJrQkpzWmMreWpjRVFFYVRwd1ZhT3VzbU1M?= =?utf-8?B?bWVoWGNyaGEwaEdNbVlzK090dnpmQ2xUOUdtYytjMHM1Nms3aVA5Rm5rb251?= =?utf-8?B?RnJHdlc2Z2t0RWZNclIyY3hDUWtRem5LNVJ6bkhPZHplK3JBWXErRmxlcWt1?= =?utf-8?B?UWVXZE5nUzBpcmRnVURnQzlUMTd3ZFFEeFVCSVZHeE5Va015MTlnL01HUnV2?= =?utf-8?B?MzNNL2Z3SWlaUVBpNTVta3BnUllyQS94VmxaaG41TFBoNHhHaGdvSjVEdVlo?= =?utf-8?B?UkYyS2tMVWwvWit2ZThCVFBQc29nUnNPbmprTWk2NUlHWXYva1hhNGdJUDBG?= =?utf-8?B?YjR6ZHlpVG4zRzRrdzFMQzRETmVxcnJtRWpTVVJmT0NNSUF3UWFKWHVFS1Fa?= =?utf-8?B?MWRFY3FzTkU0ZXVEeTdvdE96dWxFaTlxckpXR3gyYVcyNVFiTzY3cUN1ZVNH?= =?utf-8?B?WjNFNStyblRRTksyRzJkV1FhV1JQY2s4TDFLY0tuQ2Q5ZjJjWVEraHJhLzNy?= =?utf-8?B?cmdOV3R5RWFVRlRSWEMvekExYXByT0NsYnlWZDM1Z2xrTzV0QkU5ZXVQN05S?= =?utf-8?B?WFIwajdFVDZkdCsyY2Q4RWxHR3ppck50anFDVDBCUXNXeGhFdWwvVVp4OTJY?= =?utf-8?B?UVVISmtNd3AvZ083UlBQd1JxcG0yTGZYMkI5cTFJZkNLajdXbjYzUjY4dlk1?= =?utf-8?B?SmhKN2R3UzBOYlRDcFhHYmdBbnZOdWZqU1YwUDRUc3Yyb1czczlSOWRIbXhR?= =?utf-8?B?TTQ5RnUyZnBPd0NuQ2RLYnBlbUdCU3NXK3N3eisveE41RzRmMWtCTjFGbGh4?= =?utf-8?B?cWcxejRWdXhFcmRmK0ZBTllMbWZka0ZNS3NDSk56RFJtWUJaSUh2dmtUZnRL?= =?utf-8?B?NW9jZFA5TDlYRmpXMHdOU1NNcHV2YTFXRWRLK1V4elhTcnNaNHpPL3NiZDNM?= =?utf-8?B?U2FoVzhvdHJOSFdncGtYQXRoeDJjb0dHditvSFNVZDdVM3FNbzRXc3B5UWZz?= =?utf-8?B?TFBLajloOWxmdFJZMklFNEhZREt4RkNseHE3SnJTTlpvNHRaMit6MUtSOGEx?= =?utf-8?B?dVVRZDRyMG53dUdwVjlSVmNsc2FXWXNjaTZkQ3hwL2xoL0pVdWQ5WW4yczB0?= =?utf-8?B?REs0UlVNeWNXTWRuS0ljNHZVUnRqc3p5ZU9CVitjbGZZZlJIaWJMdUswWHRl?= =?utf-8?B?c0dZcjcxRUVlVmxPaVlhVDR0aGRvQlVKanhUTU1MWkVrVGZYc21VNGZyMlNO?= =?utf-8?B?dTZLV1lTWnRIYWFTcC8xclVJYy9nME1QVXdIVFJDUzMwT3l6Z2YrZ0x2LzBl?= =?utf-8?B?MWZaOTl1VFZuejBVTGpsVlJHU05oTWpMdE5BSVFsNGhLNVBQc0RKS1ViMm4r?= =?utf-8?B?SkduWWdkVmN5TXNUWG0zaVlGWEo2UE94SXpvTXFxMUMwRWZHMXlGUVFUN3FG?= =?utf-8?B?NzJXRE9RLytwT0hGUFM4R0wvVnRLdU9CTU02S1JZZmc5dkRpWFhmTGtLZXZM?= =?utf-8?B?bUNtZjVyUzdnVERBck96RjdtTGVuMHpyS3poUkIxTFdZejUzd1pFbXpQZE5T?= =?utf-8?B?SFRuTDRpOU5PSU52TTVFaU5jaEtMaFJnQ3JwdmNNb2EvZENhTXhWUXBVNjBP?= =?utf-8?Q?3UiQa+s9MbX3VjudvH1qlUTcZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c96a3b5-132d-4ec9-7857-08db9255b954 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 06:08:28.3523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GcKqoaRt/VA7G/fNVOeFL94bbVD7HuhWbyGiUFdqsP79puBT5PQlCEtLDANr7lqYf+GH2OE7t7U7m6NTXGZnpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9909 On 01.08.2023 01:37, Shawn Anastasio wrote: > On 7/31/23 10:46 AM, Jan Beulich wrote: >> On 29.07.2023 00:21, Shawn Anastasio wrote: >>> + /* If we're at the correct address, skip copy */ >>> + cmpld %r1, %r12 >>> + beq .L_correct_address >> >> Can this ever be the case, especially with the MMU-off behavior you >> describe in the comment above? Wouldn't you need to ignore the top >> four bits in the comparison? > > It will always be the case after the code jumps to XEN_VIRT_START after > the copy takes place. Well, of course. > I could have it jump past the copy loop entirely, > but then I'd need to duplicate the TOC setup. I don't think I understand this part of your reply: .L_correct_address _is_ past the copy loop. >>> + /* Copy bytes until _end */ >>> + LOAD_REG_ADDR(%r11, _end) >>> + addi %r1, %r1, -8 >>> + li %r13, -8 >>> +.L_copy_xen: >>> + ldu %r10, 8(%r1) >>> + stdu %r10, 8(%r13) >>> + cmpld %r1, %r11 >>> + blt .L_copy_xen >>> + >>> + /* Jump to XEN_VIRT_START */ >>> + mtctr %r12 >>> + bctr >>> +.L_correct_address: >> >> Can the two regions potentially overlap? Looking at the ELF header >> it's not clear to me what guarantees there are that this can't >> happen. > > As I understand it, any bootloader that placed the kernel at a low > enough address for this to be an issue wouldn't be able to boot Linux or > FreeBSD, so in practice it's a safe bet that this won't be the case. Fair enough then. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:25:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:25:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573658.898552 (Exim 4.92) (envelope-from ) id 1qQip2-0000is-GZ; Tue, 01 Aug 2023 06:25:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573658.898552; Tue, 01 Aug 2023 06:25:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQip2-0000il-Cg; Tue, 01 Aug 2023 06:25:32 +0000 Received: by outflank-mailman (input) for mailman id 573658; Tue, 01 Aug 2023 06:25:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQip0-0000ia-QA for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:25:30 +0000 Received: from frasgout11.his.huawei.com (unknown [14.137.139.23]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32bb0e4a-3034-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:25:25 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.228]) by frasgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFPv71K5Nz9xqcV for ; Tue, 1 Aug 2023 14:13:55 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S2; Tue, 01 Aug 2023 07:24:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32bb0e4a-3034-11ee-b258-6b7b168915f2 From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 0/9] Allow dynamic allocation of software IO TLB bounce buffers Date: Tue, 1 Aug 2023 08:23:55 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S2 X-Coremail-Antispam: 1UD129KBjvJXoW3Wr1Dtw1rJr47Aw4kKrykZrb_yoWDGrWfpF WrKryftF4qqryxA3s7Ca18GFyrKa1kGrW5GrWFvryrur13Cr1j93WktayrXFW7Gr40vF12 qFyYvw13uw1DZ3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBK14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr 1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02 628vn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY1x0264kExVAvwVAq07x20xyl42xK82 IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC2 0s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26rWY6r4UJwCIc40Y0x0EwIxGrw CI42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1U MIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42 IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUjFksDUUUUU= = X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik Motivation ========== The software IO TLB was designed with these assumptions: 1) It would not be used much. Small systems (little RAM) don't need it, and big systems (lots of RAM) would have modern DMA controllers and an IOMMU chip to handle legacy devices. 2) A small fixed memory area (64 MiB by default) is sufficient to handle the few cases which require a bounce buffer. 3) 64 MiB is little enough that it has no impact on the rest of the system. 4) Bounce buffers require large contiguous chunks of low memory. Such memory is precious and can be allocated only early at boot. It turns out they are not always true: 1) Embedded systems may have more than 4GiB RAM but no IOMMU and legacy 32-bit peripheral busses and/or DMA controllers. 2) CoCo VMs use bounce buffers for all I/O but may need substantially more than 64 MiB. 3) Embedded developers put as many features as possible into the available memory. A few dozen "missing" megabytes may limit what features can be implemented. 4) If CMA is available, it can allocate large continuous chunks even after the system has run for some time. Goals ===== The goal of this work is to start with a small software IO TLB at boot and expand it later when/if needed. Design ====== This version of the patch series retains the current slot allocation algorithm with multiple areas to reduce lock contention, but additional slots can be added when necessary. These alternatives have been considered: - Allocate and free buffers as needed using direct DMA API. This works quite well, except in CoCo VMs where each allocation/free requires decrypting/encrypting memory, which is a very expensive operation. - Allocate a very large software IO TLB at boot, but allow to migrate pages to/from it (like CMA does). For systems with CMA, this would mean two big allocations at boot. Finding the balance between CMA, SWIOTLB and rest of available RAM can be challenging. More importantly, there is no clear benefit compared to allocating SWIOTLB memory pools from the CMA. Implementation Constraints ========================== These constraints have been taken into account: 1) Minimize impact on devices which do not benefit from the change. 2) Minimize the number of memory decryption/encryption operations. 3) Avoid contention on a lock or atomic variable to preserve parallel scalability. Additionally, the software IO TLB code is also used to implement restricted DMA pools. These pools are restricted to a pre-defined physical memory region and must not use any other memory. In other words, dynamic allocation of memory pools must be disabled for restricted DMA pools. Data Structures =============== The existing struct io_tlb_mem is the central type for a SWIOTLB allocator, but it now contains multiple memory pools:: io_tlb_mem +---------+ io_tlb_pool | SWIOTLB | +-------+ +-------+ +-------+ |allocator|-->|default|-->|dynamic|-->|dynamic|-->... | | |memory | |memory | |memory | +---------+ | pool | | pool | | pool | +-------+ +-------+ +-------+ The allocator structure contains global state (such as flags and counters) and structures needed to schedule new allocations. Each memory pool contains the actual buffer slots and metadata. The first memory pool in the list is the default memory pool allocated statically at early boot. New memory pools are allocated from a kernel worker thread. That's because bounce buffers are allocated when mapping a DMA buffer, which may happen in interrupt context where large atomic allocations would probably fail. Allocation from process context is much more likely to succeed, especially if it can use CMA. Nonetheless, the onset of a load spike may fill up the SWIOTLB before the worker has a chance to run. In that case, try to allocate a small transient memory pool to accommodate the request. If memory is encrypted and the device cannot do DMA to encrypted memory, this buffer is allocated from the coherent atomic DMA memory pool. Reducing the size of SWIOTLB may therefore require increasing the size of the coherent pool with the "coherent_pool" command-line parameter. Performance =========== All testing compared a vanilla v6.4-rc6 kernel with a fully patched kernel. The kernel was booted with "swiotlb=force" to allow stress-testing the software IO TLB on a high-performance device that would otherwise not need it. CONFIG_DEBUG_FS was set to 'y' to match the configuration of popular distribution kernels; it is understood that parallel workloads suffer from contention on the recently added debugfs atomic counters. These benchmarks were run: - small: single-threaded I/O of 4 KiB blocks, - big: single-threaded I/O of 64 KiB blocks, - 4way: 4-way parallel I/O of 4 KiB blocks. In all tested cases, the default 64 MiB SWIOTLB would be sufficient (but wasteful). The "default" pair of columns shows performance impact when booted with 64 MiB SWIOTLB (i.e. current state). The "growing" pair of columns shows the impact when booted with a 1 MiB initial SWIOTLB, which grew to 5 MiB at run time. The "var" column in the tables below is the coefficient of variance over 5 runs of the test, the "diff" column is the difference in read-write I/O bandwidth (MiB/s). The very first column is the coefficient of variance in the results of the base unpatched kernel. First, on an x86 VM against a QEMU virtio SATA driver backed by a RAM-based block device on the host: base default growing var var diff var diff small 1.96% 0.47% -1.5% 0.52% -2.2% big 2.03% 1.35% +0.9% 2.22% +2.9% 4way 0.80% 0.45% -0.7% 1.22% <0.1% Second, on a Raspberry Pi4 with 8G RAM and a class 10 A1 microSD card: base default growing var var diff var diff small 1.09% 1.69% +0.5% 2.14% -0.2% big 0.03% 0.28% -0.5% 0.03% -0.1% 4way 5.15% 2.39% +0.2% 0.66% <0.1% Third, on a CoCo VM. This was a bigger system, so I also added a 24-thread parallel I/O test: base default growing var var diff var diff small 2.41% 6.02% +1.1% 10.33% +6.7% big 9.20% 2.81% -0.6% 16.84% -0.2% 4way 0.86% 2.66% -0.1% 2.22% -4.9% 24way 3.19% 6.19% +4.4% 4.08% -5.9% Note the increased variance of the CoCo VM, although the host was not otherwise loaded. These are caused by the first run, which includes the overhead of allocating additional bounce buffers and sharing them with the hypervisor. The system was not rebooted between successive runs. Parallel tests suffer from a reduced number of areas in the dynamically allocated memory pools. This can be improved by allocating a larger pool from CMA (not implemented in this series yet). I have no good explanation for the increase in performance of the 24-thread I/O test with the default (non-growing) memory pool. Although the difference is within variance, it seems to be real. The average bandwidth is consistently above that of the unpatched kernel. To sum it up: - All workloads benefit from reduced memory footprint. - No performance regressions have been observed with the default size of the software IO TLB. - Most workloads retain their former performance even if the software IO TLB grows at run time. Changelog ========= Changes from v6: - Rebase on dma-mapping for-next tree. Drop changes to pci-dma.c. Changes from v5: - Re-introduce is_swiotlb_allocated(), now again required because of commit b035f5a6d852 ("mm: slab: reduce the kmalloc() minimum alignment if DMA bouncing possible"). Changes from v4: - Guard the code with a CONFIG_SWIOTLB_DYNAMIC option - Remove is_swiotlb_allocated(); instead, prevent repeated initialization in swiotlb_init_late() - Rename default_swiotlb_start() to default_swiotlb_base() - Embed the default struct io_tlb_pool into struct io_tlb_mem - Do not re-introduce struct io_tlb_pool.used Changes from v3: - Provide swiotlb_is_allocated() instead of extending swiotlb_is_active(). - Do not grow SWIOTLB if its address has been queried (affects Octeon). - Do not grow SWIOTLB if a remap function is used (affects Xen PV). - Use dma_mask instead of coherent_dma_mask. - Replace complex ternary operators with if-else blocks. Changes from v2: - Complete rewrite using dynamically allocated memory pools rather than a list of individual buffers - Depend on other SWIOTLB fixes (already sent) - Fix Xen and MIPS Octeon builds Changes from RFC: - Track dynamic buffers per device instead of per swiotlb - Use a linked list instead of a maple tree - Move initialization of swiotlb fields of struct device to a helper function - Rename __lookup_dyn_slot() to lookup_dyn_slot_locked() - Introduce per-device flag if dynamic buffers are in use - Add one more user of DMA_ATTR_MAY_SLEEP - Add kernel-doc comments for new (and some old) code - Properly escape '*' in dma-attributes.rst Petr Tesarik (9): swiotlb: bail out of swiotlb_init_late() if swiotlb is already allocated swiotlb: make io_tlb_default_mem local to swiotlb.c swiotlb: add documentation and rename swiotlb_do_find_slots() swiotlb: separate memory pool data from other allocator data swiotlb: add a flag whether SWIOTLB is allowed to grow swiotlb: if swiotlb is full, fall back to a transient memory pool swiotlb: determine potential physical address limit swiotlb: allocate a new memory pool when existing pools are full swiotlb: search the software IO TLB only if the device makes use of it arch/arm/xen/mm.c | 10 +- arch/mips/pci/pci-octeon.c | 2 +- drivers/base/core.c | 4 +- drivers/xen/swiotlb-xen.c | 2 +- include/linux/device.h | 10 +- include/linux/dma-mapping.h | 2 + include/linux/swiotlb.h | 131 +++++-- kernel/dma/Kconfig | 13 + kernel/dma/direct.c | 2 +- kernel/dma/swiotlb.c | 683 ++++++++++++++++++++++++++++++++---- mm/slab_common.c | 5 +- 11 files changed, 764 insertions(+), 100 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:25:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:25:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573659.898561 (Exim 4.92) (envelope-from ) id 1qQipJ-000157-QE; Tue, 01 Aug 2023 06:25:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573659.898561; Tue, 01 Aug 2023 06:25:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQipJ-000150-NL; Tue, 01 Aug 2023 06:25:49 +0000 Received: by outflank-mailman (input) for mailman id 573659; Tue, 01 Aug 2023 06:25:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQipH-00011l-KQ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:25:47 +0000 Received: from frasgout13.his.huawei.com (unknown [14.137.139.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d240f77-3034-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:25:44 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.227]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFPvW14P7z9y3D6 for ; Tue, 1 Aug 2023 14:14:15 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S3; Tue, 01 Aug 2023 07:25:04 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d240f77-3034-11ee-8613-37d641c3527e From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 1/9] swiotlb: bail out of swiotlb_init_late() if swiotlb is already allocated Date: Tue, 1 Aug 2023 08:23:56 +0200 Message-Id: <2d7e1823e264aa1990899cc95736e78e1ec21084.1690871004.git.petr.tesarik.ext@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S3 X-Coremail-Antispam: 1UD129KBjvJXoW7WFWxCFyrZr4rWFyUJw18Krg_yoW8Jw1rp3 47AFyvgFWFg3WxArW7C3ZrAFyjkaykK347urW5Wry3Jry5J34rG34UtrWa934rWFW8WF4S yFy5ZFyYv3W2qw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQm14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jr4l82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1U M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2 IY04v7MxkF7I0En4kS14v26r1q6r43MxkF7I0Ew4C26cxK6c8Ij28IcwCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIxAIcV CF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjfU8ApnDUUUU X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik If swiotlb is allocated, immediately return 0, so callers do not have to check io_tlb_default_mem.nslabs explicitly. Signed-off-by: Petr Tesarik --- arch/arm/xen/mm.c | 10 ++++------ kernel/dma/swiotlb.c | 3 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c index 3d826c0b5fee..882cd70c7a2f 100644 --- a/arch/arm/xen/mm.c +++ b/arch/arm/xen/mm.c @@ -125,12 +125,10 @@ static int __init xen_mm_init(void) return 0; /* we can work with the default swiotlb */ - if (!io_tlb_default_mem.nslabs) { - rc = swiotlb_init_late(swiotlb_size_or_default(), - xen_swiotlb_gfp(), NULL); - if (rc < 0) - return rc; - } + rc = swiotlb_init_late(swiotlb_size_or_default(), + xen_swiotlb_gfp(), NULL); + if (rc < 0) + return rc; cflush.op = 0; cflush.a.dev_bus_addr = 0; diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 1c0a49e6685a..ee57fd9949dc 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -384,6 +384,9 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, bool retried = false; int rc = 0; + if (io_tlb_default_mem.nslabs) + return 0; + if (swiotlb_force_disable) return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:26:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:26:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573662.898572 (Exim 4.92) (envelope-from ) id 1qQipW-0001aG-1y; Tue, 01 Aug 2023 06:26:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573662.898572; Tue, 01 Aug 2023 06:26:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQipV-0001a9-VY; Tue, 01 Aug 2023 06:26:01 +0000 Received: by outflank-mailman (input) for mailman id 573662; Tue, 01 Aug 2023 06:26:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQipV-0000ia-Ht for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:26:01 +0000 Received: from frasgout12.his.huawei.com (unknown [14.137.139.154]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47a66e90-3034-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:26:00 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.227]) by frasgout12.his.huawei.com (SkyGuard) with ESMTP id 4RFPsX2drjz9v7Yf for ; Tue, 1 Aug 2023 14:12:32 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S4; Tue, 01 Aug 2023 07:25:22 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47a66e90-3034-11ee-b258-6b7b168915f2 From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 2/9] swiotlb: make io_tlb_default_mem local to swiotlb.c Date: Tue, 1 Aug 2023 08:23:57 +0200 Message-Id: <32456334747b6e7f25e839c21d614815088c3c2f.1690871004.git.petr.tesarik.ext@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S4 X-Coremail-Antispam: 1UD129KBjvJXoW3Jr4DZw13KF1DAF48Zw13Arb_yoWxZr4Upr yUAFyrGF42qrn7urW3Cw1kAF1Ygwn2kay7CrySgwn8Z3WUJwn8JFWktrWYyr1rJrW8uF4f AFyvvryYkF47Aw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQm14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jryl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1U M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2 IY04v7MxkF7I0En4kS14v26r1q6r43MxkF7I0Ew4C26cxK6c8Ij28IcwCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIxAIcV CF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjfU8vtCUUUUU X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik SWIOTLB implementation details should not be exposed to the rest of the kernel. This will allow to make changes to the implementation without modifying non-swiotlb code. To avoid breaking existing users, provide helper functions for the few required fields. As a bonus, using a helper function to initialize struct device allows to get rid of an #ifdef in driver core. Signed-off-by: Petr Tesarik --- arch/mips/pci/pci-octeon.c | 2 +- drivers/base/core.c | 4 +--- drivers/xen/swiotlb-xen.c | 2 +- include/linux/swiotlb.h | 25 +++++++++++++++++++++++- kernel/dma/swiotlb.c | 39 +++++++++++++++++++++++++++++++++++++- mm/slab_common.c | 5 ++--- 6 files changed, 67 insertions(+), 10 deletions(-) diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c index e457a18cbdc5..d19d9d456309 100644 --- a/arch/mips/pci/pci-octeon.c +++ b/arch/mips/pci/pci-octeon.c @@ -664,7 +664,7 @@ static int __init octeon_pci_setup(void) /* BAR1 movable regions contiguous to cover the swiotlb */ octeon_bar1_pci_phys = - io_tlb_default_mem.start & ~((1ull << 22) - 1); + default_swiotlb_base() & ~((1ull << 22) - 1); for (index = 0; index < 32; index++) { union cvmx_pci_bar1_indexx bar1_index; diff --git a/drivers/base/core.c b/drivers/base/core.c index 3dff5037943e..46d1d78c5beb 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -3108,9 +3108,7 @@ void device_initialize(struct device *dev) defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL) dev->dma_coherent = dma_default_coherent; #endif -#ifdef CONFIG_SWIOTLB - dev->dma_io_tlb_mem = &io_tlb_default_mem; -#endif + swiotlb_dev_init(dev); } EXPORT_SYMBOL_GPL(device_initialize); diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 67aa74d20162..946bd56f0ac5 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -381,7 +381,7 @@ xen_swiotlb_sync_sg_for_device(struct device *dev, struct scatterlist *sgl, static int xen_swiotlb_dma_supported(struct device *hwdev, u64 mask) { - return xen_phys_to_dma(hwdev, io_tlb_default_mem.end - 1) <= mask; + return xen_phys_to_dma(hwdev, default_swiotlb_limit()) <= mask; } const struct dma_map_ops xen_swiotlb_dma_ops = { diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 4e52cd5e0bdc..2d453b3e7771 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -110,7 +110,6 @@ struct io_tlb_mem { atomic_long_t used_hiwater; #endif }; -extern struct io_tlb_mem io_tlb_default_mem; static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) { @@ -128,13 +127,22 @@ static inline bool is_swiotlb_force_bounce(struct device *dev) void swiotlb_init(bool addressing_limited, unsigned int flags); void __init swiotlb_exit(void); +void swiotlb_dev_init(struct device *dev); size_t swiotlb_max_mapping_size(struct device *dev); +bool is_swiotlb_allocated(void); bool is_swiotlb_active(struct device *dev); void __init swiotlb_adjust_size(unsigned long size); +phys_addr_t default_swiotlb_base(void); +phys_addr_t default_swiotlb_limit(void); #else static inline void swiotlb_init(bool addressing_limited, unsigned int flags) { } + +static inline void swiotlb_dev_init(struct device *dev) +{ +} + static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) { return false; @@ -151,6 +159,11 @@ static inline size_t swiotlb_max_mapping_size(struct device *dev) return SIZE_MAX; } +static inline bool is_swiotlb_allocated(void) +{ + return false; +} + static inline bool is_swiotlb_active(struct device *dev) { return false; @@ -159,6 +172,16 @@ static inline bool is_swiotlb_active(struct device *dev) static inline void swiotlb_adjust_size(unsigned long size) { } + +static inline phys_addr_t default_swiotlb_base(void) +{ + return 0; +} + +static inline phys_addr_t default_swiotlb_limit(void) +{ + return 0; +} #endif /* CONFIG_SWIOTLB */ extern void swiotlb_print_info(void); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index ee57fd9949dc..0840bc15fb53 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -71,7 +71,7 @@ struct io_tlb_slot { static bool swiotlb_force_bounce; static bool swiotlb_force_disable; -struct io_tlb_mem io_tlb_default_mem; +static struct io_tlb_mem io_tlb_default_mem; static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT; static unsigned long default_nareas; @@ -489,6 +489,15 @@ void __init swiotlb_exit(void) memset(mem, 0, sizeof(*mem)); } +/** + * swiotlb_dev_init() - initialize swiotlb fields in &struct device + * @dev: Device to be initialized. + */ +void swiotlb_dev_init(struct device *dev) +{ + dev->dma_io_tlb_mem = &io_tlb_default_mem; +} + /* * Return the offset into a iotlb slot required to keep the device happy. */ @@ -953,6 +962,14 @@ size_t swiotlb_max_mapping_size(struct device *dev) return ((size_t)IO_TLB_SIZE) * IO_TLB_SEGSIZE - min_align; } +/** + * is_swiotlb_allocated() - check if the default software IO TLB is initialized + */ +bool is_swiotlb_allocated(void) +{ + return io_tlb_default_mem.nslabs; +} + bool is_swiotlb_active(struct device *dev) { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; @@ -960,6 +977,26 @@ bool is_swiotlb_active(struct device *dev) return mem && mem->nslabs; } +/** + * default_swiotlb_base() - get the base address of the default SWIOTLB + * + * Get the lowest physical address used by the default software IO TLB pool. + */ +phys_addr_t default_swiotlb_base(void) +{ + return io_tlb_default_mem.start; +} + +/** + * default_swiotlb_limit() - get the address limit of the default SWIOTLB + * + * Get the highest physical address used by the default software IO TLB pool. + */ +phys_addr_t default_swiotlb_limit(void) +{ + return io_tlb_default_mem.end - 1; +} + #ifdef CONFIG_DEBUG_FS static int io_tlb_used_get(void *data, u64 *val) diff --git a/mm/slab_common.c b/mm/slab_common.c index d1555ea2981a..c639dba9a3b7 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -864,10 +864,9 @@ void __init setup_kmalloc_cache_index_table(void) static unsigned int __kmalloc_minalign(void) { -#ifdef CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC - if (io_tlb_default_mem.nslabs) + if (IS_ENABLED(CONFIG_DMA_BOUNCE_UNALIGNED_KMALLOC) && + is_swiotlb_allocated()) return ARCH_KMALLOC_MINALIGN; -#endif return dma_get_cache_alignment(); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:26:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:26:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573664.898581 (Exim 4.92) (envelope-from ) id 1qQipn-0002D5-A0; Tue, 01 Aug 2023 06:26:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573664.898581; Tue, 01 Aug 2023 06:26:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQipn-0002Cy-7Q; Tue, 01 Aug 2023 06:26:19 +0000 Received: by outflank-mailman (input) for mailman id 573664; Tue, 01 Aug 2023 06:26:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQipm-0000ia-7a for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:26:18 +0000 Received: from frasgout12.his.huawei.com (unknown [14.137.139.154]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 526e480d-3034-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:26:17 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.229]) by frasgout12.his.huawei.com (SkyGuard) with ESMTP id 4RFPst30SXz9v7cM for ; Tue, 1 Aug 2023 14:12:50 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S5; Tue, 01 Aug 2023 07:25:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 526e480d-3034-11ee-b258-6b7b168915f2 From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 3/9] swiotlb: add documentation and rename swiotlb_do_find_slots() Date: Tue, 1 Aug 2023 08:23:58 +0200 Message-Id: <7a92817b18ce0e1bd38967784f53bf76a43cb886.1690871004.git.petr.tesarik.ext@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S5 X-Coremail-Antispam: 1UD129KBjvJXoW3GrWfGF4UuFy8tF1xZF1kKrg_yoW7ur4rpF 4rt3Z8tFs8Jr1xC39Fkw48uF1S9w4kK347uFWavryF9rnrJr9agFyktrW5XFyrJFW8uF4U Ja4a9r48Gr13Xr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQm14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JrWl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1U M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2 IY04v7MxkF7I0En4kS14v26r1q6r43MxkF7I0Ew4C26cxK6c8Ij28IcwCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIxAIcV CF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjfU8Z2-UUUUU X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik Add some kernel-doc comments and move the existing documentation of struct io_tlb_slot to its correct location. The latter was forgotten in commit 942a8186eb445 ("swiotlb: move struct io_tlb_slot to swiotlb.c"). Use the opportunity to give swiotlb_do_find_slots() a more descriptive name and make it clear how it differs from swiotlb_find_slots(). Signed-off-by: Petr Tesarik --- include/linux/swiotlb.h | 15 +++++++--- kernel/dma/swiotlb.c | 61 +++++++++++++++++++++++++++++++++++++---- 2 files changed, 66 insertions(+), 10 deletions(-) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 2d453b3e7771..31625ae507ea 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -76,10 +76,6 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, * @nslabs: The number of IO TLB blocks (in groups of 64) between @start and * @end. For default swiotlb, this is command line adjustable via * setup_io_tlb_npages. - * @list: The free list describing the number of free entries available - * from each index. - * @orig_addr: The original address corresponding to a mapped entry. - * @alloc_size: Size of the allocated buffer. * @debugfs: The dentry to debugfs. * @late_alloc: %true if allocated using the page allocator * @force_bounce: %true if swiotlb bouncing is forced @@ -111,6 +107,17 @@ struct io_tlb_mem { #endif }; +/** + * is_swiotlb_buffer() - check if a physical address belongs to a swiotlb + * @dev: Device which has mapped the buffer. + * @paddr: Physical address within the DMA buffer. + * + * Check if @paddr points into a bounce buffer. + * + * Return: + * * %true if @paddr points into a bounce buffer + * * %false otherwise + */ static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 0840bc15fb53..66793b59c290 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -62,6 +62,13 @@ #define INVALID_PHYS_ADDR (~(phys_addr_t)0) +/** + * struct io_tlb_slot - IO TLB slot descriptor + * @orig_addr: The original address corresponding to a mapped entry. + * @alloc_size: Size of the allocated buffer. + * @list: The free list describing the number of free entries available + * from each index. + */ struct io_tlb_slot { phys_addr_t orig_addr; size_t alloc_size; @@ -635,11 +642,22 @@ static void dec_used(struct io_tlb_mem *mem, unsigned int nslots) } #endif /* CONFIG_DEBUG_FS */ -/* - * Find a suitable number of IO TLB entries size that will fit this request and - * allocate a buffer from that IO TLB pool. +/** + * swiotlb_area_find_slots() - search for slots in one IO TLB memory area + * @dev: Device which maps the buffer. + * @area_index: Index of the IO TLB memory area to be searched. + * @orig_addr: Original (non-bounced) IO buffer address. + * @alloc_size: Total requested size of the bounce buffer, + * including initial alignment padding. + * @alloc_align_mask: Required alignment of the allocated buffer. + * + * Find a suitable sequence of IO TLB entries for the request and allocate + * a buffer from the given IO TLB memory area. + * This function takes care of locking. + * + * Return: Index of the first allocated slot, or -1 on error. */ -static int swiotlb_do_find_slots(struct device *dev, int area_index, +static int swiotlb_area_find_slots(struct device *dev, int area_index, phys_addr_t orig_addr, size_t alloc_size, unsigned int alloc_align_mask) { @@ -734,6 +752,19 @@ static int swiotlb_do_find_slots(struct device *dev, int area_index, return slot_index; } +/** + * swiotlb_find_slots() - search for slots in the whole swiotlb + * @dev: Device which maps the buffer. + * @orig_addr: Original (non-bounced) IO buffer address. + * @alloc_size: Total requested size of the bounce buffer, + * including initial alignment padding. + * @alloc_align_mask: Required alignment of the allocated buffer. + * + * Search through the whole software IO TLB to find a sequence of slots that + * match the allocation constraints. + * + * Return: Index of the first allocated slot, or -1 on error. + */ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, size_t alloc_size, unsigned int alloc_align_mask) { @@ -742,8 +773,8 @@ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, int i = start, index; do { - index = swiotlb_do_find_slots(dev, i, orig_addr, alloc_size, - alloc_align_mask); + index = swiotlb_area_find_slots(dev, i, orig_addr, alloc_size, + alloc_align_mask); if (index >= 0) return index; if (++i >= mem->nareas) @@ -755,6 +786,15 @@ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, #ifdef CONFIG_DEBUG_FS +/** + * mem_used() - get number of used slots in an allocator + * @mem: Software IO TLB allocator. + * + * The result is accurate in this version of the function, because an atomic + * counter is available if CONFIG_DEBUG_FS is set. + * + * Return: Number of used slots. + */ static unsigned long mem_used(struct io_tlb_mem *mem) { return atomic_long_read(&mem->total_used); @@ -762,6 +802,15 @@ static unsigned long mem_used(struct io_tlb_mem *mem) #else /* !CONFIG_DEBUG_FS */ +/** + * mem_used() - get number of used slots in an allocator + * @mem: Software IO TLB allocator. + * + * The result is not accurate, because there is no locking of individual + * areas. + * + * Return: Approximate number of used slots. + */ static unsigned long mem_used(struct io_tlb_mem *mem) { int i; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:26:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:26:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573671.898592 (Exim 4.92) (envelope-from ) id 1qQiq6-0002kP-IJ; Tue, 01 Aug 2023 06:26:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573671.898592; Tue, 01 Aug 2023 06:26:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiq6-0002kG-Eg; Tue, 01 Aug 2023 06:26:38 +0000 Received: by outflank-mailman (input) for mailman id 573671; Tue, 01 Aug 2023 06:26:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiq5-00011l-08 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:26:37 +0000 Received: from frasgout13.his.huawei.com (unknown [14.137.139.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5cb23a92-3034-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:26:34 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.229]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFPwX13zFz9y3D6 for ; Tue, 1 Aug 2023 14:15:08 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S6; Tue, 01 Aug 2023 07:25:57 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cb23a92-3034-11ee-8613-37d641c3527e From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 4/9] swiotlb: separate memory pool data from other allocator data Date: Tue, 1 Aug 2023 08:23:59 +0200 Message-Id: <08141a83c31495a8f4cac59a20c8bd6ddd129a2f.1690871004.git.petr.tesarik.ext@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S6 X-Coremail-Antispam: 1UD129KBjvAXoWfCF4rZw4DCr18Wr1xWF1kGrg_yoW8Zw15Zo W7GFnrWw4fJryjkFW7Aan3Jr47uayqka1rAF1rZay5Xayjyr4Ygw1fta15Xw13Wr1fGFWx AwnxWa48WF4kAr18n29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73VFW2AGmfu7bjvjm3 AaLaJ3UjIYCTnIWjp_UUUOl7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20EY4v20xva j40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l82xGYIkIc2x26280x7IE14v26r126s0DM28Irc Ia0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l 84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJV WxJr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j 6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7V C0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j 6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x0262 8vn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY1x0264kExVAvwVAq07x20xyl42xK82IY c2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s 026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26rWY6r4UJwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UMI IF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E 87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUjeOJ5UUUUU== X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik Carve out memory pool specific fields from struct io_tlb_mem. The original struct now contains shared data for the whole allocator, while the new struct io_tlb_pool contains data that is specific to one memory pool of (potentially) many. Signed-off-by: Petr Tesarik --- include/linux/device.h | 2 +- include/linux/swiotlb.h | 45 +++++++---- kernel/dma/swiotlb.c | 175 +++++++++++++++++++++++++--------------- 3 files changed, 140 insertions(+), 82 deletions(-) diff --git a/include/linux/device.h b/include/linux/device.h index bbaeabd04b0d..d9754a68ba95 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -625,7 +625,7 @@ struct device_physical_location { * @dma_pools: Dma pools (if dma'ble device). * @dma_mem: Internal for coherent mem override. * @cma_area: Contiguous memory area for dma allocations - * @dma_io_tlb_mem: Pointer to the swiotlb pool used. Not for driver use. + * @dma_io_tlb_mem: Software IO TLB allocator. Not for driver use. * @archdata: For arch-specific additions. * @of_node: Associated device tree node. * @fwnode: Associated device node supplied by platform firmware. diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 31625ae507ea..247f0ab8795a 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -62,8 +62,7 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, #ifdef CONFIG_SWIOTLB /** - * struct io_tlb_mem - IO TLB Memory Pool Descriptor - * + * struct io_tlb_pool - IO TLB memory pool descriptor * @start: The start address of the swiotlb memory pool. Used to do a quick * range check to see if the memory was in fact allocated by this * API. @@ -73,15 +72,34 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, * @vaddr: The vaddr of the swiotlb memory pool. The swiotlb memory pool * may be remapped in the memory encrypted case and store virtual * address for bounce buffer operation. - * @nslabs: The number of IO TLB blocks (in groups of 64) between @start and - * @end. For default swiotlb, this is command line adjustable via - * setup_io_tlb_npages. + * @nslabs: The number of IO TLB slots between @start and @end. For the + * default swiotlb, this can be adjusted with a boot parameter, + * see setup_io_tlb_npages(). + * @late_alloc: %true if allocated using the page allocator. + * @nareas: Number of areas in the pool. + * @area_nslabs: Number of slots in each area. + * @areas: Array of memory area descriptors. + * @slots: Array of slot descriptors. + */ +struct io_tlb_pool { + phys_addr_t start; + phys_addr_t end; + void *vaddr; + unsigned long nslabs; + bool late_alloc; + unsigned int nareas; + unsigned int area_nslabs; + struct io_tlb_area *areas; + struct io_tlb_slot *slots; +}; + +/** + * struct io_tlb_mem - Software IO TLB allocator + * @defpool: Default (initial) IO TLB memory pool descriptor. + * @nslabs: Total number of IO TLB slabs in all pools. * @debugfs: The dentry to debugfs. - * @late_alloc: %true if allocated using the page allocator * @force_bounce: %true if swiotlb bouncing is forced * @for_alloc: %true if the pool is used for memory allocation - * @nareas: The area number in the pool. - * @area_nslabs: The slot number in the area. * @total_used: The total number of slots in the pool that are currently used * across all areas. Used only for calculating used_hiwater in * debugfs. @@ -89,18 +107,11 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, * in debugfs. */ struct io_tlb_mem { - phys_addr_t start; - phys_addr_t end; - void *vaddr; + struct io_tlb_pool defpool; unsigned long nslabs; struct dentry *debugfs; - bool late_alloc; bool force_bounce; bool for_alloc; - unsigned int nareas; - unsigned int area_nslabs; - struct io_tlb_area *areas; - struct io_tlb_slot *slots; #ifdef CONFIG_DEBUG_FS atomic_long_t total_used; atomic_long_t used_hiwater; @@ -122,7 +133,7 @@ static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; - return mem && paddr >= mem->start && paddr < mem->end; + return mem && paddr >= mem->defpool.start && paddr < mem->defpool.end; } static inline bool is_swiotlb_force_bounce(struct device *dev) diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 66793b59c290..6fc2606e014b 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -209,7 +209,7 @@ void __init swiotlb_adjust_size(unsigned long size) void swiotlb_print_info(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_pool *mem = &io_tlb_default_mem.defpool; if (!mem->nslabs) { pr_warn("No low mem\n"); @@ -238,7 +238,7 @@ static inline unsigned long nr_slots(u64 val) */ void __init swiotlb_update_mem_attributes(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_pool *mem = &io_tlb_default_mem.defpool; unsigned long bytes; if (!mem->nslabs || mem->late_alloc) @@ -247,9 +247,8 @@ void __init swiotlb_update_mem_attributes(void) set_memory_decrypted((unsigned long)mem->vaddr, bytes >> PAGE_SHIFT); } -static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, - unsigned long nslabs, unsigned int flags, - bool late_alloc, unsigned int nareas) +static void swiotlb_init_io_tlb_pool(struct io_tlb_pool *mem, phys_addr_t start, + unsigned long nslabs, bool late_alloc, unsigned int nareas) { void *vaddr = phys_to_virt(start); unsigned long bytes = nslabs << IO_TLB_SHIFT, i; @@ -261,8 +260,6 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start, mem->nareas = nareas; mem->area_nslabs = nslabs / mem->nareas; - mem->force_bounce = swiotlb_force_bounce || (flags & SWIOTLB_FORCE); - for (i = 0; i < mem->nareas; i++) { spin_lock_init(&mem->areas[i].lock); mem->areas[i].index = 0; @@ -319,7 +316,7 @@ static void __init *swiotlb_memblock_alloc(unsigned long nslabs, void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, int (*remap)(void *tlb, unsigned long nslabs)) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_pool *mem = &io_tlb_default_mem.defpool; unsigned long nslabs; unsigned int nareas; size_t alloc_size; @@ -330,6 +327,9 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, if (swiotlb_force_disable) return; + io_tlb_default_mem.force_bounce = + swiotlb_force_bounce || (flags & SWIOTLB_FORCE); + if (!default_nareas) swiotlb_adjust_nareas(num_possible_cpus()); @@ -363,8 +363,9 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, return; } - swiotlb_init_io_tlb_mem(mem, __pa(tlb), nslabs, flags, false, - default_nareas); + swiotlb_init_io_tlb_pool(mem, __pa(tlb), nslabs, false, + default_nareas); + io_tlb_default_mem.nslabs = nslabs; if (flags & SWIOTLB_VERBOSE) swiotlb_print_info(); @@ -383,7 +384,7 @@ void __init swiotlb_init(bool addressing_limit, unsigned int flags) int swiotlb_init_late(size_t size, gfp_t gfp_mask, int (*remap)(void *tlb, unsigned long nslabs)) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_pool *mem = &io_tlb_default_mem.defpool; unsigned long nslabs = ALIGN(size >> IO_TLB_SHIFT, IO_TLB_SEGSIZE); unsigned int nareas; unsigned char *vstart = NULL; @@ -397,6 +398,8 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, if (swiotlb_force_disable) return 0; + io_tlb_default_mem.force_bounce = swiotlb_force_bounce; + if (!default_nareas) swiotlb_adjust_nareas(num_possible_cpus()); @@ -448,8 +451,9 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, set_memory_decrypted((unsigned long)vstart, (nslabs << IO_TLB_SHIFT) >> PAGE_SHIFT); - swiotlb_init_io_tlb_mem(mem, virt_to_phys(vstart), nslabs, 0, true, - nareas); + swiotlb_init_io_tlb_pool(mem, virt_to_phys(vstart), nslabs, true, + nareas); + io_tlb_default_mem.nslabs = nslabs; swiotlb_print_info(); return 0; @@ -463,7 +467,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, void __init swiotlb_exit(void) { - struct io_tlb_mem *mem = &io_tlb_default_mem; + struct io_tlb_pool *mem = &io_tlb_default_mem.defpool; unsigned long tbl_vaddr; size_t tbl_size, slots_size; unsigned int area_order; @@ -519,7 +523,7 @@ static unsigned int swiotlb_align_offset(struct device *dev, u64 addr) static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir) { - struct io_tlb_mem *mem = dev->dma_io_tlb_mem; + struct io_tlb_pool *mem = &dev->dma_io_tlb_mem->defpool; int index = (tlb_addr - mem->start) >> IO_TLB_SHIFT; phys_addr_t orig_addr = mem->slots[index].orig_addr; size_t alloc_size = mem->slots[index].alloc_size; @@ -601,7 +605,7 @@ static inline unsigned long get_max_slots(unsigned long boundary_mask) return nr_slots(boundary_mask + 1); } -static unsigned int wrap_area_index(struct io_tlb_mem *mem, unsigned int index) +static unsigned int wrap_area_index(struct io_tlb_pool *mem, unsigned int index) { if (index >= mem->area_nslabs) return 0; @@ -645,6 +649,7 @@ static void dec_used(struct io_tlb_mem *mem, unsigned int nslots) /** * swiotlb_area_find_slots() - search for slots in one IO TLB memory area * @dev: Device which maps the buffer. + * @pool: Memory pool to be searched. * @area_index: Index of the IO TLB memory area to be searched. * @orig_addr: Original (non-bounced) IO buffer address. * @alloc_size: Total requested size of the bounce buffer, @@ -657,15 +662,14 @@ static void dec_used(struct io_tlb_mem *mem, unsigned int nslots) * * Return: Index of the first allocated slot, or -1 on error. */ -static int swiotlb_area_find_slots(struct device *dev, int area_index, - phys_addr_t orig_addr, size_t alloc_size, +static int swiotlb_area_find_slots(struct device *dev, struct io_tlb_pool *pool, + int area_index, phys_addr_t orig_addr, size_t alloc_size, unsigned int alloc_align_mask) { - struct io_tlb_mem *mem = dev->dma_io_tlb_mem; - struct io_tlb_area *area = mem->areas + area_index; + struct io_tlb_area *area = pool->areas + area_index; unsigned long boundary_mask = dma_get_seg_boundary(dev); dma_addr_t tbl_dma_addr = - phys_to_dma_unencrypted(dev, mem->start) & boundary_mask; + phys_to_dma_unencrypted(dev, pool->start) & boundary_mask; unsigned long max_slots = get_max_slots(boundary_mask); unsigned int iotlb_align_mask = dma_get_min_align_mask(dev) | alloc_align_mask; @@ -677,7 +681,7 @@ static int swiotlb_area_find_slots(struct device *dev, int area_index, unsigned int slot_index; BUG_ON(!nslots); - BUG_ON(area_index >= mem->nareas); + BUG_ON(area_index >= pool->nareas); /* * For allocations of PAGE_SIZE or larger only look for page aligned @@ -694,19 +698,19 @@ static int swiotlb_area_find_slots(struct device *dev, int area_index, stride = (iotlb_align_mask >> IO_TLB_SHIFT) + 1; spin_lock_irqsave(&area->lock, flags); - if (unlikely(nslots > mem->area_nslabs - area->used)) + if (unlikely(nslots > pool->area_nslabs - area->used)) goto not_found; - slot_base = area_index * mem->area_nslabs; + slot_base = area_index * pool->area_nslabs; index = area->index; - for (slots_checked = 0; slots_checked < mem->area_nslabs; ) { + for (slots_checked = 0; slots_checked < pool->area_nslabs; ) { slot_index = slot_base + index; if (orig_addr && (slot_addr(tbl_dma_addr, slot_index) & iotlb_align_mask) != (orig_addr & iotlb_align_mask)) { - index = wrap_area_index(mem, index + 1); + index = wrap_area_index(pool, index + 1); slots_checked++; continue; } @@ -719,10 +723,10 @@ static int swiotlb_area_find_slots(struct device *dev, int area_index, if (!iommu_is_span_boundary(slot_index, nslots, nr_slots(tbl_dma_addr), max_slots)) { - if (mem->slots[slot_index].list >= nslots) + if (pool->slots[slot_index].list >= nslots) goto found; } - index = wrap_area_index(mem, index + stride); + index = wrap_area_index(pool, index + stride); slots_checked += stride; } @@ -732,58 +736,79 @@ static int swiotlb_area_find_slots(struct device *dev, int area_index, found: for (i = slot_index; i < slot_index + nslots; i++) { - mem->slots[i].list = 0; - mem->slots[i].alloc_size = alloc_size - (offset + + pool->slots[i].list = 0; + pool->slots[i].alloc_size = alloc_size - (offset + ((i - slot_index) << IO_TLB_SHIFT)); } for (i = slot_index - 1; io_tlb_offset(i) != IO_TLB_SEGSIZE - 1 && - mem->slots[i].list; i--) - mem->slots[i].list = ++count; + pool->slots[i].list; i--) + pool->slots[i].list = ++count; /* * Update the indices to avoid searching in the next round. */ - area->index = wrap_area_index(mem, index + nslots); + area->index = wrap_area_index(pool, index + nslots); area->used += nslots; spin_unlock_irqrestore(&area->lock, flags); - inc_used_and_hiwater(mem, nslots); + inc_used_and_hiwater(dev->dma_io_tlb_mem, nslots); return slot_index; } /** - * swiotlb_find_slots() - search for slots in the whole swiotlb + * swiotlb_pool_find_slots() - search for slots in one memory pool * @dev: Device which maps the buffer. + * @pool: Memory pool to be searched. * @orig_addr: Original (non-bounced) IO buffer address. * @alloc_size: Total requested size of the bounce buffer, * including initial alignment padding. * @alloc_align_mask: Required alignment of the allocated buffer. * - * Search through the whole software IO TLB to find a sequence of slots that - * match the allocation constraints. + * Search through one memory pool to find a sequence of slots that match the + * allocation constraints. * * Return: Index of the first allocated slot, or -1 on error. */ -static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, - size_t alloc_size, unsigned int alloc_align_mask) +static int swiotlb_pool_find_slots(struct device *dev, struct io_tlb_pool *pool, + phys_addr_t orig_addr, size_t alloc_size, + unsigned int alloc_align_mask) { - struct io_tlb_mem *mem = dev->dma_io_tlb_mem; - int start = raw_smp_processor_id() & (mem->nareas - 1); + int start = raw_smp_processor_id() & (pool->nareas - 1); int i = start, index; do { - index = swiotlb_area_find_slots(dev, i, orig_addr, alloc_size, - alloc_align_mask); + index = swiotlb_area_find_slots(dev, pool, i, orig_addr, + alloc_size, alloc_align_mask); if (index >= 0) return index; - if (++i >= mem->nareas) + if (++i >= pool->nareas) i = 0; } while (i != start); return -1; } +/** + * swiotlb_find_slots() - search for slots in the whole swiotlb + * @dev: Device which maps the buffer. + * @orig_addr: Original (non-bounced) IO buffer address. + * @alloc_size: Total requested size of the bounce buffer, + * including initial alignment padding. + * @alloc_align_mask: Required alignment of the allocated buffer. + * + * Search through the whole software IO TLB to find a sequence of slots that + * match the allocation constraints. + * + * Return: Index of the first allocated slot, or -1 on error. + */ +static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, + size_t alloc_size, unsigned int alloc_align_mask) +{ + return swiotlb_pool_find_slots(dev, &dev->dma_io_tlb_mem->defpool, + orig_addr, alloc_size, alloc_align_mask); +} + #ifdef CONFIG_DEBUG_FS /** @@ -802,6 +827,24 @@ static unsigned long mem_used(struct io_tlb_mem *mem) #else /* !CONFIG_DEBUG_FS */ +/** + * mem_pool_used() - get number of used slots in a memory pool + * @pool: Software IO TLB memory pool. + * + * The result is not accurate, see mem_used(). + * + * Return: Approximate number of used slots. + */ +static unsigned long mem_pool_used(struct io_tlb_pool *pool) +{ + int i; + unsigned long used = 0; + + for (i = 0; i < pool->nareas; i++) + used += pool->areas[i].used; + return used; +} + /** * mem_used() - get number of used slots in an allocator * @mem: Software IO TLB allocator. @@ -813,12 +856,7 @@ static unsigned long mem_used(struct io_tlb_mem *mem) */ static unsigned long mem_used(struct io_tlb_mem *mem) { - int i; - unsigned long used = 0; - - for (i = 0; i < mem->nareas; i++) - used += mem->areas[i].used; - return used; + return mem_pool_used(&mem->defpool); } #endif /* CONFIG_DEBUG_FS */ @@ -830,6 +868,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; unsigned int offset = swiotlb_align_offset(dev, orig_addr); + struct io_tlb_pool *pool; unsigned int i; int index; phys_addr_t tlb_addr; @@ -864,9 +903,10 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, * This is needed when we sync the memory. Then we sync the buffer if * needed. */ + pool = &mem->defpool; for (i = 0; i < nr_slots(alloc_size + offset); i++) - mem->slots[index + i].orig_addr = slot_addr(orig_addr, i); - tlb_addr = slot_addr(mem->start, index) + offset; + pool->slots[index + i].orig_addr = slot_addr(orig_addr, i); + tlb_addr = slot_addr(pool->start, index) + offset; /* * When dir == DMA_FROM_DEVICE we could omit the copy from the orig * to the tlb buffer, if we knew for sure the device will @@ -880,7 +920,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, static void swiotlb_release_slots(struct device *dev, phys_addr_t tlb_addr) { - struct io_tlb_mem *mem = dev->dma_io_tlb_mem; + struct io_tlb_pool *mem = &dev->dma_io_tlb_mem->defpool; unsigned long flags; unsigned int offset = swiotlb_align_offset(dev, tlb_addr); int index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; @@ -924,7 +964,7 @@ static void swiotlb_release_slots(struct device *dev, phys_addr_t tlb_addr) area->used -= nslots; spin_unlock_irqrestore(&area->lock, flags); - dec_used(mem, nslots); + dec_used(dev->dma_io_tlb_mem, nslots); } /* @@ -1033,7 +1073,7 @@ bool is_swiotlb_active(struct device *dev) */ phys_addr_t default_swiotlb_base(void) { - return io_tlb_default_mem.start; + return io_tlb_default_mem.defpool.start; } /** @@ -1043,7 +1083,7 @@ phys_addr_t default_swiotlb_base(void) */ phys_addr_t default_swiotlb_limit(void) { - return io_tlb_default_mem.end - 1; + return io_tlb_default_mem.defpool.end - 1; } #ifdef CONFIG_DEBUG_FS @@ -1119,6 +1159,7 @@ static inline void swiotlb_create_debugfs_files(struct io_tlb_mem *mem, struct page *swiotlb_alloc(struct device *dev, size_t size) { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; + struct io_tlb_pool *pool; phys_addr_t tlb_addr; int index; @@ -1129,7 +1170,8 @@ struct page *swiotlb_alloc(struct device *dev, size_t size) if (index == -1) return NULL; - tlb_addr = slot_addr(mem->start, index); + pool = &mem->defpool; + tlb_addr = slot_addr(pool->start, index); return pfn_to_page(PFN_DOWN(tlb_addr)); } @@ -1166,29 +1208,34 @@ static int rmem_swiotlb_device_init(struct reserved_mem *rmem, * to it. */ if (!mem) { + struct io_tlb_pool *pool; + mem = kzalloc(sizeof(*mem), GFP_KERNEL); if (!mem) return -ENOMEM; + pool = &mem->defpool; - mem->slots = kcalloc(nslabs, sizeof(*mem->slots), GFP_KERNEL); - if (!mem->slots) { + pool->slots = kcalloc(nslabs, sizeof(*pool->slots), GFP_KERNEL); + if (!pool->slots) { kfree(mem); return -ENOMEM; } - mem->areas = kcalloc(nareas, sizeof(*mem->areas), + pool->areas = kcalloc(nareas, sizeof(*pool->areas), GFP_KERNEL); - if (!mem->areas) { - kfree(mem->slots); + if (!pool->areas) { + kfree(pool->slots); kfree(mem); return -ENOMEM; } set_memory_decrypted((unsigned long)phys_to_virt(rmem->base), rmem->size >> PAGE_SHIFT); - swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, SWIOTLB_FORCE, - false, nareas); + swiotlb_init_io_tlb_pool(pool, rmem->base, nslabs, + false, nareas); + mem->force_bounce = true; mem->for_alloc = true; + mem->nslabs = nslabs; rmem->priv = mem; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:26:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573674.898602 (Exim 4.92) (envelope-from ) id 1qQiqN-0003KX-Tp; Tue, 01 Aug 2023 06:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573674.898602; Tue, 01 Aug 2023 06:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiqN-0003KM-QF; Tue, 01 Aug 2023 06:26:55 +0000 Received: by outflank-mailman (input) for mailman id 573674; Tue, 01 Aug 2023 06:26:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiqL-00011l-Vz for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:26:53 +0000 Received: from frasgout13.his.huawei.com (unknown [14.137.139.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 67279f3d-3034-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:26:52 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.227]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFPws4yyWz9y3D6 for ; Tue, 1 Aug 2023 14:15:25 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S7; Tue, 01 Aug 2023 07:26:15 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67279f3d-3034-11ee-8613-37d641c3527e From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 5/9] swiotlb: add a flag whether SWIOTLB is allowed to grow Date: Tue, 1 Aug 2023 08:24:00 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S7 X-Coremail-Antispam: 1UD129KBjvJXoWxWrW8XF1fKr1fZr13Wr4UArb_yoWrWry5pF 15JF4rXF42qF1xArWxCw1xGF9akw4vkrW3urWa9ry5Ar43Jw1Yqa1DKFWYq34Fqrs2qF4a qFyS9F1Ykr17ZwUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQC14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F 4UJwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_ Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6x IIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_ Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8c xan2IY04v7MxkF7I0En4kS14v26r1q6r43MxkF7I0Ew4C26cxK6c8Ij28IcwCF04k20xvY 0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I 0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF 0xvE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIx AIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2 jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjfU8fHUDUUUU X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik Add a config option (CONFIG_SWIOTLB_DYNAMIC) to enable or disable dynamic allocation of additional bounce buffers. If this option is set, mark the default SWIOTLB as able to grow and restricted DMA pools as unable. However, if the address of the default memory pool is explicitly queried, make the default SWIOTLB also unable to grow. This is currently used to set up PCI BAR movable regions on some Octeon MIPS boards which may not be able to use a SWIOTLB pool elsewhere in physical memory. See octeon_pci_setup() for more details. If a remap function is specified, it must be also called on any dynamically allocated pools, but there are some issues: - The remap function may block, so it should not be called from an atomic context. - There is no corresponding unremap() function if the memory pool is freed. - The only in-tree implementation (xen_swiotlb_fixup) requires that the number of slots in the memory pool is a multiple of SWIOTLB_SEGSIZE. Keep it simple for now and disable growing the SWIOTLB if a remap function was specified. Signed-off-by: Petr Tesarik --- include/linux/swiotlb.h | 4 ++++ kernel/dma/Kconfig | 13 +++++++++++++ kernel/dma/swiotlb.c | 13 +++++++++++++ 3 files changed, 30 insertions(+) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 247f0ab8795a..57be2a0a9fbf 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -100,6 +100,7 @@ struct io_tlb_pool { * @debugfs: The dentry to debugfs. * @force_bounce: %true if swiotlb bouncing is forced * @for_alloc: %true if the pool is used for memory allocation + * @can_grow: %true if more pools can be allocated dynamically. * @total_used: The total number of slots in the pool that are currently used * across all areas. Used only for calculating used_hiwater in * debugfs. @@ -112,6 +113,9 @@ struct io_tlb_mem { struct dentry *debugfs; bool force_bounce; bool for_alloc; +#ifdef CONFIG_SWIOTLB_DYNAMIC + bool can_grow; +#endif #ifdef CONFIG_DEBUG_FS atomic_long_t total_used; atomic_long_t used_hiwater; diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index 562463fe30ea..4c1e9a3c0ab6 100644 --- a/kernel/dma/Kconfig +++ b/kernel/dma/Kconfig @@ -90,6 +90,19 @@ config SWIOTLB bool select NEED_DMA_MAP_STATE +config SWIOTLB_DYNAMIC + bool "Dynamic allocation of DMA bounce buffers" + default n + depends on SWIOTLB + help + This enables dynamic resizing of the software IO TLB. The kernel + starts with one memory pool at boot and it will allocate additional + pools as needed. To reduce run-time kernel memory requirements, you + may have to specify a smaller size of the initial pool using + "swiotlb=" on the kernel command line. + + If unsure, say N. + config DMA_BOUNCE_UNALIGNED_KMALLOC bool depends on SWIOTLB diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 6fc2606e014b..767c8fb36a6b 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -330,6 +330,11 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, io_tlb_default_mem.force_bounce = swiotlb_force_bounce || (flags & SWIOTLB_FORCE); +#ifdef CONFIG_SWIOTLB_DYNAMIC + if (!remap) + io_tlb_default_mem.can_grow = true; +#endif + if (!default_nareas) swiotlb_adjust_nareas(num_possible_cpus()); @@ -400,6 +405,11 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, io_tlb_default_mem.force_bounce = swiotlb_force_bounce; +#ifdef CONFIG_SWIOTLB_DYNAMIC + if (!remap) + io_tlb_default_mem.can_grow = true; +#endif + if (!default_nareas) swiotlb_adjust_nareas(num_possible_cpus()); @@ -1073,6 +1083,9 @@ bool is_swiotlb_active(struct device *dev) */ phys_addr_t default_swiotlb_base(void) { +#ifdef CONFIG_SWIOTLB_DYNAMIC + io_tlb_default_mem.can_grow = false; +#endif return io_tlb_default_mem.defpool.start; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:27:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:27:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573679.898612 (Exim 4.92) (envelope-from ) id 1qQiqs-00040M-6E; Tue, 01 Aug 2023 06:27:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573679.898612; Tue, 01 Aug 2023 06:27:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiqs-00040C-3G; Tue, 01 Aug 2023 06:27:26 +0000 Received: by outflank-mailman (input) for mailman id 573679; Tue, 01 Aug 2023 06:27:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiqe-00011l-8x for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:27:12 +0000 Received: from frasgout13.his.huawei.com (unknown [14.137.139.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71d19bcd-3034-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:27:10 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.228]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFPxC4BzLz9y3D4 for ; Tue, 1 Aug 2023 14:15:43 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S8; Tue, 01 Aug 2023 07:26:32 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71d19bcd-3034-11ee-8613-37d641c3527e From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 6/9] swiotlb: if swiotlb is full, fall back to a transient memory pool Date: Tue, 1 Aug 2023 08:24:01 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S8 X-Coremail-Antispam: 1UD129KBjvAXoW3Cr4UZr48Zr45Jw18Zw17Awb_yoW8CF1rXo W7uFn3Ww4fJ34UCF4rGFs7Gr47Za1kKa18AF4fuayYgayjvryYgrW7ta15X3sI9ryIkFWx Aw1Sqa4fWF4xArykn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73VFW2AGmfu7bjvjm3 AaLaJ3UjIYCTnIWjp_UUUOl7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20EY4v20xva j40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l82xGYIkIc2x26280x7IE14v26r126s0DM28Irc Ia0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l 84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJV WxJr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j 6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7V C0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j 6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x0262 8vn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY1x0264kExVAvwVAq07x20xyl42xK82IY c2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s 026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26rWY6r4UJwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UMI IF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E 87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUjeOJ5UUUUU== X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik Try to allocate a transient memory pool if no suitable slots can be found and the respective SWIOTLB is allowed to grow. The transient pool is just enough big for this one bounce buffer. It is inserted into a per-device list of transient memory pools, and it is freed again when the bounce buffer is unmapped. Transient memory pools are kept in an RCU list. A memory barrier is required after adding a new entry, because any address within a transient buffer must be immediately recognized as belonging to the SWIOTLB, even if it is passed to another CPU. Deletion does not require any synchronization beyond RCU ordering guarantees. After a buffer is unmapped, its physical addresses may no longer be passed to the DMA API, so the memory range of the corresponding stale entry in the RCU list never matches. If the memory range gets allocated again, then it happens only after a RCU quiescent state. Since bounce buffers can now be allocated from different pools, add a parameter to swiotlb_alloc_pool() to let the caller know which memory pool is used. Add swiotlb_find_pool() to find the memory pool corresponding to an address. This function is now also used by is_swiotlb_buffer(), because a simple boundary check is no longer sufficient. The logic in swiotlb_alloc_tlb() is taken from __dma_direct_alloc_pages(), simplified and enhanced to use coherent memory pools if needed. Note that this is not the most efficient way to provide a bounce buffer, but when a DMA buffer can't be mapped, something may (and will) actually break. At that point it is better to make an allocation, even if it may be an expensive operation. Signed-off-by: Petr Tesarik --- include/linux/device.h | 6 + include/linux/dma-mapping.h | 2 + include/linux/swiotlb.h | 29 +++- kernel/dma/direct.c | 2 +- kernel/dma/swiotlb.c | 316 +++++++++++++++++++++++++++++++++++- 5 files changed, 345 insertions(+), 10 deletions(-) diff --git a/include/linux/device.h b/include/linux/device.h index d9754a68ba95..5fd89c9d005c 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -626,6 +626,8 @@ struct device_physical_location { * @dma_mem: Internal for coherent mem override. * @cma_area: Contiguous memory area for dma allocations * @dma_io_tlb_mem: Software IO TLB allocator. Not for driver use. + * @dma_io_tlb_pools: List of transient swiotlb memory pools. + * @dma_io_tlb_lock: Protects changes to the list of active pools. * @archdata: For arch-specific additions. * @of_node: Associated device tree node. * @fwnode: Associated device node supplied by platform firmware. @@ -731,6 +733,10 @@ struct device { #endif #ifdef CONFIG_SWIOTLB struct io_tlb_mem *dma_io_tlb_mem; +#endif +#ifdef CONFIG_SWIOTLB_DYNAMIC + struct list_head dma_io_tlb_pools; + spinlock_t dma_io_tlb_lock; #endif /* arch specific additions */ struct dev_archdata archdata; diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index e13050eb9777..f0ccca16a0ac 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -418,6 +418,8 @@ static inline void dma_sync_sgtable_for_device(struct device *dev, #define dma_get_sgtable(d, t, v, h, s) dma_get_sgtable_attrs(d, t, v, h, s, 0) #define dma_mmap_coherent(d, v, c, h, s) dma_mmap_attrs(d, v, c, h, s, 0) +bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size); + static inline void *dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t gfp) { diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 57be2a0a9fbf..66867d2188ba 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -80,6 +80,9 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys, * @area_nslabs: Number of slots in each area. * @areas: Array of memory area descriptors. * @slots: Array of slot descriptors. + * @node: Member of the IO TLB memory pool list. + * @rcu: RCU head for swiotlb_dyn_free(). + * @transient: %true if transient memory pool. */ struct io_tlb_pool { phys_addr_t start; @@ -91,6 +94,11 @@ struct io_tlb_pool { unsigned int area_nslabs; struct io_tlb_area *areas; struct io_tlb_slot *slots; +#ifdef CONFIG_SWIOTLB_DYNAMIC + struct list_head node; + struct rcu_head rcu; + bool transient; +#endif }; /** @@ -122,6 +130,20 @@ struct io_tlb_mem { #endif }; +#ifdef CONFIG_SWIOTLB_DYNAMIC + +struct io_tlb_pool *swiotlb_find_pool(struct device *dev, phys_addr_t paddr); + +#else + +static inline struct io_tlb_pool *swiotlb_find_pool(struct device *dev, + phys_addr_t paddr) +{ + return &dev->dma_io_tlb_mem->defpool; +} + +#endif + /** * is_swiotlb_buffer() - check if a physical address belongs to a swiotlb * @dev: Device which has mapped the buffer. @@ -137,7 +159,12 @@ static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; - return mem && paddr >= mem->defpool.start && paddr < mem->defpool.end; + if (!mem) + return false; + + if (IS_ENABLED(CONFIG_SWIOTLB_DYNAMIC)) + return swiotlb_find_pool(dev, paddr); + return paddr >= mem->defpool.start && paddr < mem->defpool.end; } static inline bool is_swiotlb_force_bounce(struct device *dev) diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c index d29cade048db..9596ae1aa0da 100644 --- a/kernel/dma/direct.c +++ b/kernel/dma/direct.c @@ -66,7 +66,7 @@ static gfp_t dma_direct_optimal_gfp_mask(struct device *dev, u64 *phys_limit) return 0; } -static bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size) +bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size) { dma_addr_t dma_addr = phys_to_dma_direct(dev, phys); diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 767c8fb36a6b..30d0fcc3ccb9 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -510,6 +511,211 @@ void __init swiotlb_exit(void) memset(mem, 0, sizeof(*mem)); } +#ifdef CONFIG_SWIOTLB_DYNAMIC + +/** + * alloc_dma_pages() - allocate pages to be used for DMA + * @gfp: GFP flags for the allocation. + * @bytes: Size of the buffer. + * + * Allocate pages from the buddy allocator. If successful, make the allocated + * pages decrypted that they can be used for DMA. + * + * Return: Decrypted pages, or %NULL on failure. + */ +static struct page *alloc_dma_pages(gfp_t gfp, size_t bytes) +{ + unsigned int order = get_order(bytes); + struct page *page; + void *vaddr; + + page = alloc_pages(gfp, order); + if (!page) + return NULL; + + vaddr = page_address(page); + if (set_memory_decrypted((unsigned long)vaddr, PFN_UP(bytes))) + goto error; + return page; + +error: + __free_pages(page, order); + return NULL; +} + +/** + * swiotlb_alloc_tlb() - allocate a dynamic IO TLB buffer + * @dev: Device for which a memory pool is allocated. + * @bytes: Size of the buffer. + * @phys_limit: Maximum allowed physical address of the buffer. + * @gfp: GFP flags for the allocation. + * + * Return: Allocated pages, or %NULL on allocation failure. + */ +static struct page *swiotlb_alloc_tlb(struct device *dev, size_t bytes, + u64 phys_limit, gfp_t gfp) +{ + struct page *page; + + /* + * Allocate from the atomic pools if memory is encrypted and + * the allocation is atomic, because decrypting may block. + */ + if (!gfpflags_allow_blocking(gfp) && dev && force_dma_unencrypted(dev)) { + void *vaddr; + + if (!IS_ENABLED(CONFIG_DMA_COHERENT_POOL)) + return NULL; + + return dma_alloc_from_pool(dev, bytes, &vaddr, gfp, + dma_coherent_ok); + } + + gfp &= ~GFP_ZONEMASK; + if (phys_limit <= DMA_BIT_MASK(zone_dma_bits)) + gfp |= __GFP_DMA; + else if (phys_limit <= DMA_BIT_MASK(32)) + gfp |= __GFP_DMA32; + + while ((page = alloc_dma_pages(gfp, bytes)) && + page_to_phys(page) + bytes - 1 > phys_limit) { + /* allocated, but too high */ + __free_pages(page, get_order(bytes)); + + if (IS_ENABLED(CONFIG_ZONE_DMA32) && + phys_limit < DMA_BIT_MASK(64) && + !(gfp & (__GFP_DMA32 | __GFP_DMA))) + gfp |= __GFP_DMA32; + else if (IS_ENABLED(CONFIG_ZONE_DMA) && + !(gfp & __GFP_DMA)) + gfp = (gfp & ~__GFP_DMA32) | __GFP_DMA; + else + return NULL; + } + + return page; +} + +/** + * swiotlb_free_tlb() - free a dynamically allocated IO TLB buffer + * @vaddr: Virtual address of the buffer. + * @bytes: Size of the buffer. + */ +static void swiotlb_free_tlb(void *vaddr, size_t bytes) +{ + if (IS_ENABLED(CONFIG_DMA_COHERENT_POOL) && + dma_free_from_pool(NULL, vaddr, bytes)) + return; + + /* Intentional leak if pages cannot be encrypted again. */ + if (!set_memory_encrypted((unsigned long)vaddr, PFN_UP(bytes))) + __free_pages(virt_to_page(vaddr), get_order(bytes)); +} + +/** + * swiotlb_alloc_pool() - allocate a new IO TLB memory pool + * @dev: Device for which a memory pool is allocated. + * @nslabs: Desired number of slabs. + * @phys_limit: Maximum DMA buffer physical address. + * @gfp: GFP flags for the allocations. + * + * Allocate and initialize a new IO TLB memory pool. + * + * Return: New memory pool, or %NULL on allocation failure. + */ +static struct io_tlb_pool *swiotlb_alloc_pool(struct device *dev, + unsigned int nslabs, u64 phys_limit, gfp_t gfp) +{ + struct io_tlb_pool *pool; + struct page *tlb; + size_t pool_size; + size_t tlb_size; + + pool_size = sizeof(*pool) + array_size(sizeof(*pool->areas), 1) + + array_size(sizeof(*pool->slots), nslabs); + pool = kzalloc(pool_size, gfp); + if (!pool) + goto error; + pool->areas = (void *)pool + sizeof(*pool); + pool->slots = (void *)pool->areas + sizeof(*pool->areas); + + tlb_size = nslabs << IO_TLB_SHIFT; + tlb = swiotlb_alloc_tlb(dev, tlb_size, phys_limit, gfp); + if (!tlb) + goto error_tlb; + + swiotlb_init_io_tlb_pool(pool, page_to_phys(tlb), nslabs, true, 1); + return pool; + +error_tlb: + kfree(pool); +error: + return NULL; +} + +/** + * swiotlb_dyn_free() - RCU callback to free a memory pool + * @rcu: RCU head in the corresponding struct io_tlb_pool. + */ +static void swiotlb_dyn_free(struct rcu_head *rcu) +{ + struct io_tlb_pool *pool = container_of(rcu, struct io_tlb_pool, rcu); + size_t tlb_size = pool->end - pool->start; + + swiotlb_free_tlb(pool->vaddr, tlb_size); + kfree(pool); +} + +/** + * swiotlb_find_pool() - find the IO TLB pool for a physical address + * @dev: Device which has mapped the DMA buffer. + * @paddr: Physical address within the DMA buffer. + * + * Find the IO TLB memory pool descriptor which contains the given physical + * address, if any. + * + * Return: Memory pool which contains @paddr, or %NULL if none. + */ +struct io_tlb_pool *swiotlb_find_pool(struct device *dev, phys_addr_t paddr) +{ + struct io_tlb_mem *mem = dev->dma_io_tlb_mem; + struct io_tlb_pool *pool = &mem->defpool; + + if (paddr >= pool->start && paddr < pool->end) + return pool; + + /* Pairs with smp_wmb() in swiotlb_find_slots(). */ + smp_rmb(); + + rcu_read_lock(); + list_for_each_entry_rcu(pool, &dev->dma_io_tlb_pools, node) { + if (paddr >= pool->start && paddr < pool->end) + goto out; + } + pool = NULL; +out: + rcu_read_unlock(); + return pool; +} + +/** + * swiotlb_del_pool() - remove an IO TLB pool from a device + * @dev: Owning device. + * @pool: Memory pool to be removed. + */ +static void swiotlb_del_pool(struct device *dev, struct io_tlb_pool *pool) +{ + unsigned long flags; + + spin_lock_irqsave(&dev->dma_io_tlb_lock, flags); + list_del_rcu(&pool->node); + spin_unlock_irqrestore(&dev->dma_io_tlb_lock, flags); + + call_rcu(&pool->rcu, swiotlb_dyn_free); +} + +#endif /* CONFIG_SWIOTLB_DYNAMIC */ + /** * swiotlb_dev_init() - initialize swiotlb fields in &struct device * @dev: Device to be initialized. @@ -517,6 +723,10 @@ void __init swiotlb_exit(void) void swiotlb_dev_init(struct device *dev) { dev->dma_io_tlb_mem = &io_tlb_default_mem; +#ifdef CONFIG_SWIOTLB_DYNAMIC + INIT_LIST_HEAD(&dev->dma_io_tlb_pools); + spin_lock_init(&dev->dma_io_tlb_lock); +#endif } /* @@ -533,7 +743,7 @@ static unsigned int swiotlb_align_offset(struct device *dev, u64 addr) static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size, enum dma_data_direction dir) { - struct io_tlb_pool *mem = &dev->dma_io_tlb_mem->defpool; + struct io_tlb_pool *mem = swiotlb_find_pool(dev, tlb_addr); int index = (tlb_addr - mem->start) >> IO_TLB_SHIFT; phys_addr_t orig_addr = mem->slots[index].orig_addr; size_t alloc_size = mem->slots[index].alloc_size; @@ -799,6 +1009,8 @@ static int swiotlb_pool_find_slots(struct device *dev, struct io_tlb_pool *pool, return -1; } +#ifdef CONFIG_SWIOTLB_DYNAMIC + /** * swiotlb_find_slots() - search for slots in the whole swiotlb * @dev: Device which maps the buffer. @@ -806,6 +1018,7 @@ static int swiotlb_pool_find_slots(struct device *dev, struct io_tlb_pool *pool, * @alloc_size: Total requested size of the bounce buffer, * including initial alignment padding. * @alloc_align_mask: Required alignment of the allocated buffer. + * @retpool: Used memory pool, updated on return. * * Search through the whole software IO TLB to find a sequence of slots that * match the allocation constraints. @@ -813,12 +1026,64 @@ static int swiotlb_pool_find_slots(struct device *dev, struct io_tlb_pool *pool, * Return: Index of the first allocated slot, or -1 on error. */ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, - size_t alloc_size, unsigned int alloc_align_mask) + size_t alloc_size, unsigned int alloc_align_mask, + struct io_tlb_pool **retpool) { - return swiotlb_pool_find_slots(dev, &dev->dma_io_tlb_mem->defpool, + struct io_tlb_mem *mem = dev->dma_io_tlb_mem; + struct io_tlb_pool *pool; + unsigned long nslabs; + unsigned long flags; + u64 phys_limit; + int index; + + pool = &mem->defpool; + index = swiotlb_pool_find_slots(dev, pool, orig_addr, + alloc_size, alloc_align_mask); + if (index >= 0) + goto found; + + if (!mem->can_grow) + return -1; + + nslabs = nr_slots(alloc_size); + phys_limit = min_not_zero(*dev->dma_mask, dev->bus_dma_limit); + pool = swiotlb_alloc_pool(dev, nslabs, phys_limit, + GFP_NOWAIT | __GFP_NOWARN); + if (!pool) + return -1; + + index = swiotlb_pool_find_slots(dev, pool, orig_addr, + alloc_size, alloc_align_mask); + if (index < 0) { + swiotlb_dyn_free(&pool->rcu); + return -1; + } + + pool->transient = true; + spin_lock_irqsave(&dev->dma_io_tlb_lock, flags); + list_add_rcu(&pool->node, &dev->dma_io_tlb_pools); + spin_unlock_irqrestore(&dev->dma_io_tlb_lock, flags); + + /* Pairs with smp_rmb() in swiotlb_find_pool(). */ + smp_wmb(); +found: + *retpool = pool; + return index; +} + +#else /* !CONFIG_SWIOTLB_DYNAMIC */ + +static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, + size_t alloc_size, unsigned int alloc_align_mask, + struct io_tlb_pool **retpool) +{ + *retpool = &dev->dma_io_tlb_mem->defpool; + return swiotlb_pool_find_slots(dev, *retpool, orig_addr, alloc_size, alloc_align_mask); } +#endif /* CONFIG_SWIOTLB_DYNAMIC */ + #ifdef CONFIG_DEBUG_FS /** @@ -899,7 +1164,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, } index = swiotlb_find_slots(dev, orig_addr, - alloc_size + offset, alloc_align_mask); + alloc_size + offset, alloc_align_mask, &pool); if (index == -1) { if (!(attrs & DMA_ATTR_NO_WARN)) dev_warn_ratelimited(dev, @@ -913,7 +1178,6 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, * This is needed when we sync the memory. Then we sync the buffer if * needed. */ - pool = &mem->defpool; for (i = 0; i < nr_slots(alloc_size + offset); i++) pool->slots[index + i].orig_addr = slot_addr(orig_addr, i); tlb_addr = slot_addr(pool->start, index) + offset; @@ -930,7 +1194,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *dev, phys_addr_t orig_addr, static void swiotlb_release_slots(struct device *dev, phys_addr_t tlb_addr) { - struct io_tlb_pool *mem = &dev->dma_io_tlb_mem->defpool; + struct io_tlb_pool *mem = swiotlb_find_pool(dev, tlb_addr); unsigned long flags; unsigned int offset = swiotlb_align_offset(dev, tlb_addr); int index = (tlb_addr - offset - mem->start) >> IO_TLB_SHIFT; @@ -977,6 +1241,41 @@ static void swiotlb_release_slots(struct device *dev, phys_addr_t tlb_addr) dec_used(dev->dma_io_tlb_mem, nslots); } +#ifdef CONFIG_SWIOTLB_DYNAMIC + +/** + * swiotlb_del_transient() - delete a transient memory pool + * @dev: Device which mapped the buffer. + * @tlb_addr: Physical address within a bounce buffer. + * + * Check whether the address belongs to a transient SWIOTLB memory pool. + * If yes, then delete the pool. + * + * Return: %true if @tlb_addr belonged to a transient pool that was released. + */ +static bool swiotlb_del_transient(struct device *dev, phys_addr_t tlb_addr) +{ + struct io_tlb_pool *pool; + + pool = swiotlb_find_pool(dev, tlb_addr); + if (!pool->transient) + return false; + + dec_used(dev->dma_io_tlb_mem, pool->nslabs); + swiotlb_del_pool(dev, pool); + return true; +} + +#else /* !CONFIG_SWIOTLB_DYNAMIC */ + +static inline bool swiotlb_del_transient(struct device *dev, + phys_addr_t tlb_addr) +{ + return false; +} + +#endif /* CONFIG_SWIOTLB_DYNAMIC */ + /* * tlb_addr is the physical address of the bounce buffer to unmap. */ @@ -991,6 +1290,8 @@ void swiotlb_tbl_unmap_single(struct device *dev, phys_addr_t tlb_addr, (dir == DMA_FROM_DEVICE || dir == DMA_BIDIRECTIONAL)) swiotlb_bounce(dev, tlb_addr, mapping_size, DMA_FROM_DEVICE); + if (swiotlb_del_transient(dev, tlb_addr)) + return; swiotlb_release_slots(dev, tlb_addr); } @@ -1179,11 +1480,10 @@ struct page *swiotlb_alloc(struct device *dev, size_t size) if (!mem) return NULL; - index = swiotlb_find_slots(dev, 0, size, 0); + index = swiotlb_find_slots(dev, 0, size, 0, &pool); if (index == -1) return NULL; - pool = &mem->defpool; tlb_addr = slot_addr(pool->start, index); return pfn_to_page(PFN_DOWN(tlb_addr)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:28:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:28:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573682.898622 (Exim 4.92) (envelope-from ) id 1qQirV-0004fI-JN; Tue, 01 Aug 2023 06:28:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573682.898622; Tue, 01 Aug 2023 06:28:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQirV-0004fB-Gd; Tue, 01 Aug 2023 06:28:05 +0000 Received: by outflank-mailman (input) for mailman id 573682; Tue, 01 Aug 2023 06:28:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQirU-0004Ye-Sp for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:28:04 +0000 Received: from frasgout12.his.huawei.com (unknown [14.137.139.154]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9213a86c-3034-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:28:04 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.228]) by frasgout12.his.huawei.com (SkyGuard) with ESMTP id 4RFPvw0y0nz9xGWm for ; Tue, 1 Aug 2023 14:14:36 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S11; Tue, 01 Aug 2023 07:27:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9213a86c-3034-11ee-b258-6b7b168915f2 From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 9/9] swiotlb: search the software IO TLB only if the device makes use of it Date: Tue, 1 Aug 2023 08:24:04 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S11 X-Coremail-Antispam: 1UD129KBjvJXoWxZF15Ww18ZF1fWr1UtFW7XFb_yoWrXFy3pF 98AFZ8KayqqryxCryxCF18uF1agw4vk3yfurWagrnYkr1DJwnYqF1DKrWav3s5Ar4xZF43 tryj9wsYkr17Xr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQv14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr1j6r xdM28EF7xvwVC2z280aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJVW0 owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7 IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2 kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY1x0264kExVAvwVAq07x20xyl42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26rWY6r4UJwCIc40Y0x0EwIxGrwCI42IY 6xIIjxv20xvE14v26ryj6F1UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJr0_GcWlIxAIcV CF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Cr1j6rxdYxBIdaVFxhVjvjDU0xZFpf9x0JU2XdbUUUUU= X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik Skip searching the software IO TLB if a device has never used it, making sure these devices are not affected by the introduction of multiple IO TLB memory pools. Additional memory barrier is required to ensure that the new value of the flag is visible to other CPUs after mapping a new bounce buffer. For efficiency, the flag check should be inlined, and then the memory barrier must be moved to is_swiotlb_buffer(). However, it can replace the existing barrier in swiotlb_find_pool(), because all callers use is_swiotlb_buffer() first to verify that the buffer address belongs to the software IO TLB. Signed-off-by: Petr Tesarik --- include/linux/device.h | 2 ++ include/linux/swiotlb.h | 7 ++++++- kernel/dma/swiotlb.c | 14 ++++++-------- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/include/linux/device.h b/include/linux/device.h index 5fd89c9d005c..6fc808d22bfd 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -628,6 +628,7 @@ struct device_physical_location { * @dma_io_tlb_mem: Software IO TLB allocator. Not for driver use. * @dma_io_tlb_pools: List of transient swiotlb memory pools. * @dma_io_tlb_lock: Protects changes to the list of active pools. + * @dma_uses_io_tlb: %true if device has used the software IO TLB. * @archdata: For arch-specific additions. * @of_node: Associated device tree node. * @fwnode: Associated device node supplied by platform firmware. @@ -737,6 +738,7 @@ struct device { #ifdef CONFIG_SWIOTLB_DYNAMIC struct list_head dma_io_tlb_pools; spinlock_t dma_io_tlb_lock; + bool dma_uses_io_tlb; #endif /* arch specific additions */ struct dev_archdata archdata; diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 8371c92a0271..b4536626f8ff 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -172,8 +172,13 @@ static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) if (!mem) return false; - if (IS_ENABLED(CONFIG_SWIOTLB_DYNAMIC)) + if (IS_ENABLED(CONFIG_SWIOTLB_DYNAMIC)) { + /* Pairs with smp_wmb() in swiotlb_find_slots() and + * swiotlb_dyn_alloc(), which modify the RCU lists. + */ + smp_rmb(); return swiotlb_find_pool(dev, paddr); + } return paddr >= mem->defpool.start && paddr < mem->defpool.end; } diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index adf80dec42d7..d7eac84f975b 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -730,7 +730,7 @@ static void swiotlb_dyn_alloc(struct work_struct *work) add_mem_pool(mem, pool); - /* Pairs with smp_rmb() in swiotlb_find_pool(). */ + /* Pairs with smp_rmb() in is_swiotlb_buffer(). */ smp_wmb(); } @@ -764,11 +764,6 @@ struct io_tlb_pool *swiotlb_find_pool(struct device *dev, phys_addr_t paddr) struct io_tlb_mem *mem = dev->dma_io_tlb_mem; struct io_tlb_pool *pool; - /* Pairs with smp_wmb() in swiotlb_find_slots() and - * swiotlb_dyn_alloc(), which modify the RCU lists. - */ - smp_rmb(); - rcu_read_lock(); list_for_each_entry_rcu(pool, &mem->pools, node) { if (paddr >= pool->start && paddr < pool->end) @@ -813,6 +808,7 @@ void swiotlb_dev_init(struct device *dev) #ifdef CONFIG_SWIOTLB_DYNAMIC INIT_LIST_HEAD(&dev->dma_io_tlb_pools); spin_lock_init(&dev->dma_io_tlb_lock); + dev->dma_uses_io_tlb = false; #endif } @@ -1157,9 +1153,11 @@ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, list_add_rcu(&pool->node, &dev->dma_io_tlb_pools); spin_unlock_irqrestore(&dev->dma_io_tlb_lock, flags); - /* Pairs with smp_rmb() in swiotlb_find_pool(). */ - smp_wmb(); found: + dev->dma_uses_io_tlb = true; + /* Pairs with smp_rmb() in is_swiotlb_buffer() */ + smp_wmb(); + *retpool = pool; return index; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:29:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:29:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573691.898632 (Exim 4.92) (envelope-from ) id 1qQit7-0005Jc-0O; Tue, 01 Aug 2023 06:29:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573691.898632; Tue, 01 Aug 2023 06:29:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQit6-0005JV-SJ; Tue, 01 Aug 2023 06:29:44 +0000 Received: by outflank-mailman (input) for mailman id 573691; Tue, 01 Aug 2023 06:29:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQit5-0005JL-B3 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:29:43 +0000 Received: from frasgout13.his.huawei.com (unknown [14.137.139.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbda619b-3034-11ee-b258-6b7b168915f2; Tue, 01 Aug 2023 08:29:41 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.229]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFQ063Qhbz9y7l5 for ; Tue, 1 Aug 2023 14:18:14 +0800 (CST) Received: from [10.81.220.249] (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwC3abkdpshkKRcYAA--.13561S2; Tue, 01 Aug 2023 07:29:03 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbda619b-3034-11ee-b258-6b7b168915f2 Message-ID: <4c2f96bc-f6c0-4a04-e4fa-6ab1b5e56bd6@huaweicloud.com> Date: Tue, 1 Aug 2023 08:28:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/9] Allow dynamic allocation of software IO TLB bounce buffers Content-Language: en-US To: =?UTF-8?B?UGV0ciBUZXNhxZnDrWs=?= , Christoph Hellwig Cc: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , "open list:SLAB ALLOCATOR" , Roberto Sassu References: <20230731160409.GA8991@lst.de> <20230731214618.6e7cde05@meshulam.tesarici.cz> From: Petr Tesarik In-Reply-To: <20230731214618.6e7cde05@meshulam.tesarici.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwC3abkdpshkKRcYAA--.13561S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYc7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87 Iv6xkF7I0E14v26F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAK zVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx 8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwAC I402YVCY1x02628vn2kIc2xKxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJV W8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF 1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcV C0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIxAIcVCF04k26cxKx2IYs7xG6Fyj6rWUJwCI 42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26F4UJVW0obIYCTnIWI evJa73UjIFyTuYvjfUoL0eDUUUU X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected On 7/31/2023 9:46 PM, Petr TesaÅ™Ă­k wrote: > V Mon, 31 Jul 2023 18:04:09 +0200 > Christoph Hellwig napsĂ¡no: > >> I was just going to apply this, but patch 1 seems to have a non-trivial >> conflict with the is_swiotlb_active removal in pci-dma.c. Can you resend >> against the current dma-mapping for-next tree? > > Sure thing, will re-send tomorrow morning. After commit f9a38ea5172a ("x86: always initialize xen-swiotlb when xen-pcifront is enabling") removed that call to swiotlb_init_late(), there is nothing to patch, and the hunk can be dropped. I have just sent v7. Petr T From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:37:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573699.898647 (Exim 4.92) (envelope-from ) id 1qQj0W-0006sZ-2o; Tue, 01 Aug 2023 06:37:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573699.898647; Tue, 01 Aug 2023 06:37:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQj0V-0006rL-Sj; Tue, 01 Aug 2023 06:37:23 +0000 Received: by outflank-mailman (input) for mailman id 573699; Tue, 01 Aug 2023 06:37:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQirE-00011l-Mi for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:27:48 +0000 Received: from frasgout13.his.huawei.com (unknown [14.137.139.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 879d7940-3034-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:27:46 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.227]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFPxv14Dgz9y7l9 for ; Tue, 1 Aug 2023 14:16:19 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S10; Tue, 01 Aug 2023 07:27:08 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 879d7940-3034-11ee-8613-37d641c3527e From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 8/9] swiotlb: allocate a new memory pool when existing pools are full Date: Tue, 1 Aug 2023 08:24:03 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S10 X-Coremail-Antispam: 1UD129KBjvJXoW3ZrWfGFyxAryxCr4UJFWfAFb_yoWkXrW3pF y5Aa47KFWUXrn7CFy2k3WUCF1a9w4vkr47CrWa9rn8Zrn7Wrn8tFyqkryYqr95JF4DZF13 tFWYvF15uw47Zw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQv14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr1j6r xdM28EF7xvwVC2z280aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJVW0 owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7 IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4U M4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2 kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY1x0264kExVAvwVAq07x20xyl42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26rWY6r4UJwCIc40Y0x0EwIxGrwCI42IY 6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJr0_GcWlIxAIcV CF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Cr1j6rxdYxBIdaVFxhVjvjDU0xZFpf9x0JU2XdbUUUUU= X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik When swiotlb_find_slots() cannot find suitable slots, schedule the allocation of a new memory pool. It is not possible to allocate the pool immediately, because this code may run in interrupt context, which is not suitable for large memory allocations. This means that the memory pool will be available too late for the currently requested mapping, but the stress on the software IO TLB allocator is likely to continue, and subsequent allocations will benefit from the additional pool eventually. Keep all memory pools for an allocator in an RCU list to avoid locking on the read side. For modifications, add a new spinlock to struct io_tlb_mem. The spinlock also protects updates to the total number of slabs (nslabs in struct io_tlb_mem), but not reads of the value. Readers may therefore encounter a stale value, but this is not an issue: - swiotlb_tbl_map_single() and is_swiotlb_active() only check for non-zero value. This is ensured by the existence of the default memory pool, allocated at boot. - The exact value is used only for non-critical purposes (debugfs, kernel messages). Signed-off-by: Petr Tesarik --- include/linux/swiotlb.h | 8 +++ kernel/dma/swiotlb.c | 148 +++++++++++++++++++++++++++++++++------- 2 files changed, 131 insertions(+), 25 deletions(-) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 9825fa14abe4..8371c92a0271 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -8,6 +8,7 @@ #include #include #include +#include struct device; struct page; @@ -104,12 +105,16 @@ struct io_tlb_pool { /** * struct io_tlb_mem - Software IO TLB allocator * @defpool: Default (initial) IO TLB memory pool descriptor. + * @pool: IO TLB memory pool descriptor (if not dynamic). * @nslabs: Total number of IO TLB slabs in all pools. * @debugfs: The dentry to debugfs. * @force_bounce: %true if swiotlb bouncing is forced * @for_alloc: %true if the pool is used for memory allocation * @can_grow: %true if more pools can be allocated dynamically. * @phys_limit: Maximum allowed physical address. + * @lock: Lock to synchronize changes to the list. + * @pools: List of IO TLB memory pool descriptors (if dynamic). + * @dyn_alloc: Dynamic IO TLB pool allocation work. * @total_used: The total number of slots in the pool that are currently used * across all areas. Used only for calculating used_hiwater in * debugfs. @@ -125,6 +130,9 @@ struct io_tlb_mem { #ifdef CONFIG_SWIOTLB_DYNAMIC bool can_grow; u64 phys_limit; + spinlock_t lock; + struct list_head pools; + struct work_struct dyn_alloc; #endif #ifdef CONFIG_DEBUG_FS atomic_long_t total_used; diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 0fa081defdbd..adf80dec42d7 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -79,8 +79,23 @@ struct io_tlb_slot { static bool swiotlb_force_bounce; static bool swiotlb_force_disable; +#ifdef CONFIG_SWIOTLB_DYNAMIC + +static void swiotlb_dyn_alloc(struct work_struct *work); + +static struct io_tlb_mem io_tlb_default_mem = { + .lock = __SPIN_LOCK_UNLOCKED(io_tlb_default_mem.lock), + .pools = LIST_HEAD_INIT(io_tlb_default_mem.pools), + .dyn_alloc = __WORK_INITIALIZER(io_tlb_default_mem.dyn_alloc, + swiotlb_dyn_alloc), +}; + +#else /* !CONFIG_SWIOTLB_DYNAMIC */ + static struct io_tlb_mem io_tlb_default_mem; +#endif /* CONFIG_SWIOTLB_DYNAMIC */ + static unsigned long default_nslabs = IO_TLB_DEFAULT_SIZE >> IO_TLB_SHIFT; static unsigned long default_nareas; @@ -278,6 +293,23 @@ static void swiotlb_init_io_tlb_pool(struct io_tlb_pool *mem, phys_addr_t start, return; } +/** + * add_mem_pool() - add a memory pool to the allocator + * @mem: Software IO TLB allocator. + * @pool: Memory pool to be added. + */ +static void add_mem_pool(struct io_tlb_mem *mem, struct io_tlb_pool *pool) +{ +#ifdef CONFIG_SWIOTLB_DYNAMIC + spin_lock(&mem->lock); + list_add_rcu(&pool->node, &mem->pools); + mem->nslabs += pool->nslabs; + spin_unlock(&mem->lock); +#else + mem->nslabs = pool->nslabs; +#endif +} + static void __init *swiotlb_memblock_alloc(unsigned long nslabs, unsigned int flags, int (*remap)(void *tlb, unsigned long nslabs)) @@ -375,7 +407,7 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, swiotlb_init_io_tlb_pool(mem, __pa(tlb), nslabs, false, default_nareas); - io_tlb_default_mem.nslabs = nslabs; + add_mem_pool(&io_tlb_default_mem, mem); if (flags & SWIOTLB_VERBOSE) swiotlb_print_info(); @@ -474,7 +506,7 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, (nslabs << IO_TLB_SHIFT) >> PAGE_SHIFT); swiotlb_init_io_tlb_pool(mem, virt_to_phys(vstart), nslabs, true, nareas); - io_tlb_default_mem.nslabs = nslabs; + add_mem_pool(&io_tlb_default_mem, mem); swiotlb_print_info(); return 0; @@ -625,44 +657,83 @@ static void swiotlb_free_tlb(void *vaddr, size_t bytes) /** * swiotlb_alloc_pool() - allocate a new IO TLB memory pool * @dev: Device for which a memory pool is allocated. - * @nslabs: Desired number of slabs. + * @minslabs: Minimum number of slabs. + * @nslabs: Desired (maximum) number of slabs. + * @nareas: Number of areas. * @phys_limit: Maximum DMA buffer physical address. * @gfp: GFP flags for the allocations. * - * Allocate and initialize a new IO TLB memory pool. + * Allocate and initialize a new IO TLB memory pool. The actual number of + * slabs may be reduced if allocation of @nslabs fails. If even + * @minslabs cannot be allocated, this function fails. * * Return: New memory pool, or %NULL on allocation failure. */ static struct io_tlb_pool *swiotlb_alloc_pool(struct device *dev, - unsigned int nslabs, u64 phys_limit, gfp_t gfp) + unsigned long minslabs, unsigned long nslabs, + unsigned int nareas, u64 phys_limit, gfp_t gfp) { struct io_tlb_pool *pool; + unsigned int slot_order; struct page *tlb; size_t pool_size; size_t tlb_size; - pool_size = sizeof(*pool) + array_size(sizeof(*pool->areas), 1) + - array_size(sizeof(*pool->slots), nslabs); + pool_size = sizeof(*pool) + array_size(sizeof(*pool->areas), nareas); pool = kzalloc(pool_size, gfp); if (!pool) goto error; pool->areas = (void *)pool + sizeof(*pool); - pool->slots = (void *)pool->areas + sizeof(*pool->areas); tlb_size = nslabs << IO_TLB_SHIFT; - tlb = swiotlb_alloc_tlb(dev, tlb_size, phys_limit, gfp); - if (!tlb) - goto error_tlb; + while (!(tlb = swiotlb_alloc_tlb(dev, tlb_size, phys_limit, gfp))) { + if (nslabs <= minslabs) + goto error_tlb; + nslabs = ALIGN(nslabs >> 1, IO_TLB_SEGSIZE); + nareas = limit_nareas(nareas, nslabs); + tlb_size = nslabs << IO_TLB_SHIFT; + } - swiotlb_init_io_tlb_pool(pool, page_to_phys(tlb), nslabs, true, 1); + slot_order = get_order(array_size(sizeof(*pool->slots), nslabs)); + pool->slots = (struct io_tlb_slot *) + __get_free_pages(gfp, slot_order); + if (!pool->slots) + goto error_slots; + + swiotlb_init_io_tlb_pool(pool, page_to_phys(tlb), nslabs, true, nareas); return pool; +error_slots: + swiotlb_free_tlb(page_address(tlb), tlb_size); error_tlb: kfree(pool); error: return NULL; } +/** + * swiotlb_dyn_alloc() - dynamic memory pool allocation worker + * @work: Pointer to dyn_alloc in struct io_tlb_mem. + */ +static void swiotlb_dyn_alloc(struct work_struct *work) +{ + struct io_tlb_mem *mem = + container_of(work, struct io_tlb_mem, dyn_alloc); + struct io_tlb_pool *pool; + + pool = swiotlb_alloc_pool(NULL, IO_TLB_MIN_SLABS, default_nslabs, + default_nareas, mem->phys_limit, GFP_KERNEL); + if (!pool) { + pr_warn_ratelimited("Failed to allocate new pool"); + return; + } + + add_mem_pool(mem, pool); + + /* Pairs with smp_rmb() in swiotlb_find_pool(). */ + smp_wmb(); +} + /** * swiotlb_dyn_free() - RCU callback to free a memory pool * @rcu: RCU head in the corresponding struct io_tlb_pool. @@ -670,8 +741,10 @@ static struct io_tlb_pool *swiotlb_alloc_pool(struct device *dev, static void swiotlb_dyn_free(struct rcu_head *rcu) { struct io_tlb_pool *pool = container_of(rcu, struct io_tlb_pool, rcu); + size_t slots_size = array_size(sizeof(*pool->slots), pool->nslabs); size_t tlb_size = pool->end - pool->start; + free_pages((unsigned long)pool->slots, get_order(slots_size)); swiotlb_free_tlb(pool->vaddr, tlb_size); kfree(pool); } @@ -689,15 +762,19 @@ static void swiotlb_dyn_free(struct rcu_head *rcu) struct io_tlb_pool *swiotlb_find_pool(struct device *dev, phys_addr_t paddr) { struct io_tlb_mem *mem = dev->dma_io_tlb_mem; - struct io_tlb_pool *pool = &mem->defpool; - - if (paddr >= pool->start && paddr < pool->end) - return pool; + struct io_tlb_pool *pool; - /* Pairs with smp_wmb() in swiotlb_find_slots(). */ + /* Pairs with smp_wmb() in swiotlb_find_slots() and + * swiotlb_dyn_alloc(), which modify the RCU lists. + */ smp_rmb(); rcu_read_lock(); + list_for_each_entry_rcu(pool, &mem->pools, node) { + if (paddr >= pool->start && paddr < pool->end) + goto out; + } + list_for_each_entry_rcu(pool, &dev->dma_io_tlb_pools, node) { if (paddr >= pool->start && paddr < pool->end) goto out; @@ -1046,18 +1123,24 @@ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, u64 phys_limit; int index; - pool = &mem->defpool; - index = swiotlb_pool_find_slots(dev, pool, orig_addr, - alloc_size, alloc_align_mask); - if (index >= 0) - goto found; - + rcu_read_lock(); + list_for_each_entry_rcu(pool, &mem->pools, node) { + index = swiotlb_pool_find_slots(dev, pool, orig_addr, + alloc_size, alloc_align_mask); + if (index >= 0) { + rcu_read_unlock(); + goto found; + } + } + rcu_read_unlock(); if (!mem->can_grow) return -1; + schedule_work(&mem->dyn_alloc); + nslabs = nr_slots(alloc_size); phys_limit = min_not_zero(*dev->dma_mask, dev->bus_dma_limit); - pool = swiotlb_alloc_pool(dev, nslabs, phys_limit, + pool = swiotlb_alloc_pool(dev, nslabs, nslabs, 1, phys_limit, GFP_NOWAIT | __GFP_NOWARN); if (!pool) return -1; @@ -1141,7 +1224,19 @@ static unsigned long mem_pool_used(struct io_tlb_pool *pool) */ static unsigned long mem_used(struct io_tlb_mem *mem) { +#ifdef CONFIG_SWIOTLB_DYNAMIC + struct io_tlb_pool *pool; + unsigned long used = 0; + + rcu_read_lock(); + list_for_each_entry_rcu(pool, &mem->pools, node) + used += mem_pool_used(pool); + rcu_read_unlock(); + + return used; +#else return mem_pool_used(&mem->defpool); +#endif } #endif /* CONFIG_DEBUG_FS */ @@ -1562,7 +1657,10 @@ static int rmem_swiotlb_device_init(struct reserved_mem *rmem, false, nareas); mem->force_bounce = true; mem->for_alloc = true; - mem->nslabs = nslabs; +#ifdef CONFIG_SWIOTLB_DYNAMIC + spin_lock_init(&mem->lock); +#endif + add_mem_pool(mem, pool); rmem->priv = mem; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:37:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:37:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573698.898642 (Exim 4.92) (envelope-from ) id 1qQj0V-0006pR-Pp; Tue, 01 Aug 2023 06:37:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573698.898642; Tue, 01 Aug 2023 06:37:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQj0V-0006pD-Kz; Tue, 01 Aug 2023 06:37:23 +0000 Received: by outflank-mailman (input) for mailman id 573698; Tue, 01 Aug 2023 06:37:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQiqz-00011l-B4 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:27:33 +0000 Received: from frasgout12.his.huawei.com (unknown [14.137.139.154]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d028bae-3034-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:27:30 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.227]) by frasgout12.his.huawei.com (SkyGuard) with ESMTP id 4RFPvD5k2mz9ttD0 for ; Tue, 1 Aug 2023 14:14:00 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.220.249]) by APP1 (Coremail) with SMTP id LxC2BwCHOroapchkgAwYAA--.27948S9; Tue, 01 Aug 2023 07:26:50 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d028bae-3034-11ee-8613-37d641c3527e From: Petr Tesarik To: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR ARM), linux-arm-kernel@lists.infradead.org (moderated list:ARM PORT), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), iommu@lists.linux.dev (open list:XEN SWIOTLB SUBSYSTEM), linux-mm@kvack.org (open list:SLAB ALLOCATOR) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v7 7/9] swiotlb: determine potential physical address limit Date: Tue, 1 Aug 2023 08:24:02 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCHOroapchkgAwYAA--.27948S9 X-Coremail-Antispam: 1UD129KBjvJXoWxXw4fJr4xAF4rZr4UWr4kWFg_yoW5AF4DpF y8Jr4FgFsFqF17ArWxCw1IyFn5Ga10k3y29rW5urnxZr17Ww13WrsrKr45trySqF4IgF4f uFyxua4Y9F42v37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQC14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JF0E3s1l82xGYI kIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2 z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F 4UJwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_ Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6x IIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_ Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8c xan2IY04v7MxkF7I0En4kS14v26r1q6r43MxkF7I0Ew4C26cxK6c8Ij28IcwCF04k20xvY 0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I 0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Wrv_Gr1UMIIYrxkI7VAKI48JMIIF 0xvE2Ix0cI8IcVAFwI0_Gr0_Xr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIx AIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2 jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjfU8fHUDUUUU X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik The value returned by default_swiotlb_limit() should be constant, because it is used to decide whether DMA can be used. To allow allocating memory pools on the fly, use the maximum possible physical address rather than the highest address used by the default pool. For swiotlb_init_remap(), this is either an arch-specific limit used by memblock_alloc_low(), or the highest directly mapped physical address if the initialization flags include SWIOTLB_ANY. For swiotlb_init_late(), the highest address is determined by the GFP flags. Signed-off-by: Petr Tesarik --- include/linux/swiotlb.h | 2 ++ kernel/dma/swiotlb.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 66867d2188ba..9825fa14abe4 100644 --- a/include/linux/swiotlb.h +++ b/include/linux/swiotlb.h @@ -109,6 +109,7 @@ struct io_tlb_pool { * @force_bounce: %true if swiotlb bouncing is forced * @for_alloc: %true if the pool is used for memory allocation * @can_grow: %true if more pools can be allocated dynamically. + * @phys_limit: Maximum allowed physical address. * @total_used: The total number of slots in the pool that are currently used * across all areas. Used only for calculating used_hiwater in * debugfs. @@ -123,6 +124,7 @@ struct io_tlb_mem { bool for_alloc; #ifdef CONFIG_SWIOTLB_DYNAMIC bool can_grow; + u64 phys_limit; #endif #ifdef CONFIG_DEBUG_FS atomic_long_t total_used; diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c index 30d0fcc3ccb9..0fa081defdbd 100644 --- a/kernel/dma/swiotlb.c +++ b/kernel/dma/swiotlb.c @@ -334,6 +334,10 @@ void __init swiotlb_init_remap(bool addressing_limit, unsigned int flags, #ifdef CONFIG_SWIOTLB_DYNAMIC if (!remap) io_tlb_default_mem.can_grow = true; + if (flags & SWIOTLB_ANY) + io_tlb_default_mem.phys_limit = virt_to_phys(high_memory - 1); + else + io_tlb_default_mem.phys_limit = ARCH_LOW_ADDRESS_LIMIT; #endif if (!default_nareas) @@ -409,6 +413,12 @@ int swiotlb_init_late(size_t size, gfp_t gfp_mask, #ifdef CONFIG_SWIOTLB_DYNAMIC if (!remap) io_tlb_default_mem.can_grow = true; + if (IS_ENABLED(CONFIG_ZONE_DMA) && (gfp_mask & __GFP_DMA)) + io_tlb_default_mem.phys_limit = DMA_BIT_MASK(zone_dma_bits); + else if (IS_ENABLED(CONFIG_ZONE_DMA32) && (gfp_mask & __GFP_DMA32)) + io_tlb_default_mem.phys_limit = DMA_BIT_MASK(32); + else + io_tlb_default_mem.phys_limit = virt_to_phys(high_memory - 1); #endif if (!default_nareas) @@ -1397,7 +1407,11 @@ phys_addr_t default_swiotlb_base(void) */ phys_addr_t default_swiotlb_limit(void) { +#ifdef CONFIG_SWIOTLB_DYNAMIC + return io_tlb_default_mem.phys_limit; +#else return io_tlb_default_mem.defpool.end - 1; +#endif } #ifdef CONFIG_DEBUG_FS -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 06:38:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 06:38:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573707.898662 (Exim 4.92) (envelope-from ) id 1qQj1J-0007uX-Fg; Tue, 01 Aug 2023 06:38:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573707.898662; Tue, 01 Aug 2023 06:38:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQj1J-0007uQ-BQ; Tue, 01 Aug 2023 06:38:13 +0000 Received: by outflank-mailman (input) for mailman id 573707; Tue, 01 Aug 2023 06:38:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQj1I-0007hB-HJ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 06:38:12 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id faa209d6-3035-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 08:38:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49E1B6147A; Tue, 1 Aug 2023 06:38:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31641C433C8; Tue, 1 Aug 2023 06:38:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faa209d6-3035-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690871887; bh=hDT+iR6AIZkPiUojYsTG3f1l1RIz7J/cYfpHFlOtmcY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ihVqg2sCDGTatgUfOTqQau2d5hVIQ7FhkJ4dQpOT6tNN864bCCltGkeZsSp33J3G6 67N3c/0YoQ7uttpJF1XBIQwpsMlhyfqYfn0RI23AQwNs82WxOMomf6WcFs2wg6yuwo qESSyNtICw/59SiCMx7JA4bv1FkEQ3vhy5wSX/Nc= Date: Tue, 1 Aug 2023 08:38:05 +0200 From: Greg Kroah-Hartman To: Petr Tesarik Cc: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , "open list:SLAB ALLOCATOR" , Roberto Sassu , petr@tesarici.cz Subject: Re: [PATCH v7 0/9] Allow dynamic allocation of software IO TLB bounce buffers Message-ID: <2023080144-cardigan-nerd-2bed@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 01, 2023 at 08:23:55AM +0200, Petr Tesarik wrote: > From: Petr Tesarik > > Motivation > ========== > > The software IO TLB was designed with these assumptions: > > 1) It would not be used much. Small systems (little RAM) don't need it, and > big systems (lots of RAM) would have modern DMA controllers and an IOMMU > chip to handle legacy devices. > 2) A small fixed memory area (64 MiB by default) is sufficient to > handle the few cases which require a bounce buffer. > 3) 64 MiB is little enough that it has no impact on the rest of the > system. > 4) Bounce buffers require large contiguous chunks of low memory. Such > memory is precious and can be allocated only early at boot. > > It turns out they are not always true: > > 1) Embedded systems may have more than 4GiB RAM but no IOMMU and legacy > 32-bit peripheral busses and/or DMA controllers. > 2) CoCo VMs use bounce buffers for all I/O but may need substantially more > than 64 MiB. > 3) Embedded developers put as many features as possible into the available > memory. A few dozen "missing" megabytes may limit what features can be > implemented. > 4) If CMA is available, it can allocate large continuous chunks even after > the system has run for some time. > > Goals > ===== > > The goal of this work is to start with a small software IO TLB at boot and > expand it later when/if needed. > > Design > ====== > > This version of the patch series retains the current slot allocation > algorithm with multiple areas to reduce lock contention, but additional > slots can be added when necessary. > > These alternatives have been considered: > > - Allocate and free buffers as needed using direct DMA API. This works > quite well, except in CoCo VMs where each allocation/free requires > decrypting/encrypting memory, which is a very expensive operation. > > - Allocate a very large software IO TLB at boot, but allow to migrate pages > to/from it (like CMA does). For systems with CMA, this would mean two big > allocations at boot. Finding the balance between CMA, SWIOTLB and rest of > available RAM can be challenging. More importantly, there is no clear > benefit compared to allocating SWIOTLB memory pools from the CMA. > > Implementation Constraints > ========================== > > These constraints have been taken into account: > > 1) Minimize impact on devices which do not benefit from the change. > 2) Minimize the number of memory decryption/encryption operations. > 3) Avoid contention on a lock or atomic variable to preserve parallel > scalability. > > Additionally, the software IO TLB code is also used to implement restricted > DMA pools. These pools are restricted to a pre-defined physical memory > region and must not use any other memory. In other words, dynamic > allocation of memory pools must be disabled for restricted DMA pools. > > Data Structures > =============== > > The existing struct io_tlb_mem is the central type for a SWIOTLB allocator, > but it now contains multiple memory pools:: > > io_tlb_mem > +---------+ io_tlb_pool > | SWIOTLB | +-------+ +-------+ +-------+ > |allocator|-->|default|-->|dynamic|-->|dynamic|-->... > | | |memory | |memory | |memory | > +---------+ | pool | | pool | | pool | > +-------+ +-------+ +-------+ > > The allocator structure contains global state (such as flags and counters) > and structures needed to schedule new allocations. Each memory pool > contains the actual buffer slots and metadata. The first memory pool in the > list is the default memory pool allocated statically at early boot. > > New memory pools are allocated from a kernel worker thread. That's because > bounce buffers are allocated when mapping a DMA buffer, which may happen in > interrupt context where large atomic allocations would probably fail. > Allocation from process context is much more likely to succeed, especially > if it can use CMA. > > Nonetheless, the onset of a load spike may fill up the SWIOTLB before the > worker has a chance to run. In that case, try to allocate a small transient > memory pool to accommodate the request. If memory is encrypted and the > device cannot do DMA to encrypted memory, this buffer is allocated from the > coherent atomic DMA memory pool. Reducing the size of SWIOTLB may therefore > require increasing the size of the coherent pool with the "coherent_pool" > command-line parameter. > > Performance > =========== > > All testing compared a vanilla v6.4-rc6 kernel with a fully patched > kernel. The kernel was booted with "swiotlb=force" to allow stress-testing > the software IO TLB on a high-performance device that would otherwise not > need it. CONFIG_DEBUG_FS was set to 'y' to match the configuration of > popular distribution kernels; it is understood that parallel workloads > suffer from contention on the recently added debugfs atomic counters. > > These benchmarks were run: > > - small: single-threaded I/O of 4 KiB blocks, > - big: single-threaded I/O of 64 KiB blocks, > - 4way: 4-way parallel I/O of 4 KiB blocks. > > In all tested cases, the default 64 MiB SWIOTLB would be sufficient (but > wasteful). The "default" pair of columns shows performance impact when > booted with 64 MiB SWIOTLB (i.e. current state). The "growing" pair of > columns shows the impact when booted with a 1 MiB initial SWIOTLB, which > grew to 5 MiB at run time. The "var" column in the tables below is the > coefficient of variance over 5 runs of the test, the "diff" column is the > difference in read-write I/O bandwidth (MiB/s). The very first column is > the coefficient of variance in the results of the base unpatched kernel. > > First, on an x86 VM against a QEMU virtio SATA driver backed by a RAM-based > block device on the host: > > base default growing > var var diff var diff > small 1.96% 0.47% -1.5% 0.52% -2.2% > big 2.03% 1.35% +0.9% 2.22% +2.9% > 4way 0.80% 0.45% -0.7% 1.22% <0.1% > > Second, on a Raspberry Pi4 with 8G RAM and a class 10 A1 microSD card: > > base default growing > var var diff var diff > small 1.09% 1.69% +0.5% 2.14% -0.2% > big 0.03% 0.28% -0.5% 0.03% -0.1% > 4way 5.15% 2.39% +0.2% 0.66% <0.1% > > Third, on a CoCo VM. This was a bigger system, so I also added a 24-thread > parallel I/O test: > > base default growing > var var diff var diff > small 2.41% 6.02% +1.1% 10.33% +6.7% > big 9.20% 2.81% -0.6% 16.84% -0.2% > 4way 0.86% 2.66% -0.1% 2.22% -4.9% > 24way 3.19% 6.19% +4.4% 4.08% -5.9% > > Note the increased variance of the CoCo VM, although the host was not > otherwise loaded. These are caused by the first run, which includes the > overhead of allocating additional bounce buffers and sharing them with the > hypervisor. The system was not rebooted between successive runs. > > Parallel tests suffer from a reduced number of areas in the dynamically > allocated memory pools. This can be improved by allocating a larger pool > from CMA (not implemented in this series yet). > > I have no good explanation for the increase in performance of the > 24-thread I/O test with the default (non-growing) memory pool. Although the > difference is within variance, it seems to be real. The average bandwidth > is consistently above that of the unpatched kernel. > > To sum it up: > > - All workloads benefit from reduced memory footprint. > - No performance regressions have been observed with the default size of > the software IO TLB. > - Most workloads retain their former performance even if the software IO > TLB grows at run time. > For the driver-core touched portions: Reviewed-by: Greg Kroah-Hartman From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:05:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:05:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573713.898672 (Exim 4.92) (envelope-from ) id 1qQjRd-00032r-HL; Tue, 01 Aug 2023 07:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573713.898672; Tue, 01 Aug 2023 07:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjRd-00032k-EU; Tue, 01 Aug 2023 07:05:25 +0000 Received: by outflank-mailman (input) for mailman id 573713; Tue, 01 Aug 2023 07:05:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjRb-00032e-VD for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:05:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7d1b24a-3039-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:05:22 +0200 (CEST) Received: from Dell.bugseng.com.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 63F004EE0737; Tue, 1 Aug 2023 09:05:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7d1b24a-3039-11ee-b259-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH] xen/lib: address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Tue, 1 Aug 2023 09:05:07 +0200 Message-Id: <18adbd526ec48a83ace2d9049671d3abd2f9c45b.1690873427.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Give a name to unnamed parameters thus addressing violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional changes. Signed-off-by: Federico Serafini --- xen/include/xen/lib.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 359cfdc784..8eef557dd5 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -78,7 +78,7 @@ debugtrace_printk(const char *fmt, ...) {} /* Allows us to use '%p' as general-purpose machine-word format char. */ #define _p(_x) ((void *)(unsigned long)(_x)) -extern void printk(const char *format, ...) +extern void printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2))); #define printk_once(fmt, args...) \ @@ -91,9 +91,9 @@ extern void printk(const char *format, ...) } \ }) -extern void guest_printk(const struct domain *d, const char *format, ...) +extern void guest_printk(const struct domain *d, const char *fmt, ...) __attribute__ ((format (printf, 2, 3))); -extern void noreturn panic(const char *format, ...) +extern void noreturn panic(const char *fmt, ...) __attribute__ ((format (printf, 1, 2))); extern int __printk_ratelimit(int ratelimit_ms, int ratelimit_burst); extern int printk_ratelimit(void); @@ -173,7 +173,7 @@ extern char *print_tainted(char *str); extern void add_taint(unsigned int taint); struct cpu_user_regs; -void cf_check dump_execstate(struct cpu_user_regs *); +void cf_check dump_execstate(struct cpu_user_regs *regs); void init_constructors(void); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:20:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573718.898682 (Exim 4.92) (envelope-from ) id 1qQjg6-0005SY-QC; Tue, 01 Aug 2023 07:20:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573718.898682; Tue, 01 Aug 2023 07:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjg6-0005SR-Mg; Tue, 01 Aug 2023 07:20:22 +0000 Received: by outflank-mailman (input) for mailman id 573718; Tue, 01 Aug 2023 07:20:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjg5-0005SL-Fr for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:20:21 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df36b3f0-303b-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:20:20 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id C882D4EE0737; Tue, 1 Aug 2023 09:20:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df36b3f0-303b-11ee-b259-6b7b168915f2 MIME-Version: 1.0 Date: Tue, 01 Aug 2023 09:20:19 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 3/4] xen: rename variables and parameters to address MISRA C:2012 Rule 5.3 In-Reply-To: References: <8aebc67a150cb4116affdd6da755a8e82c827ffa.1690810346.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <2e0a88de6c6d0e7ef23bf14f0f945c0f@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31/07/2023 16:34, Jan Beulich wrote: > On 31.07.2023 15:35, Nicola Vetrini wrote: >> Rule 5.3 has the following headline: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope" >> >> Local variables have been suitably renamed to address some violations >> of this rule: >> - s/cmp/c/ because it shadows the union declared at line 87. >> - s/nodes/numa_nodes/ shadows the static variable declared at line 18. >> - s/ctrl/controller/ because the homonymous function parameter is >> later >> read. >> - s/baud/baud_rate/ to avoid shadowing the enum constant defined >> at line 1391. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/common/compat/memory.c | 6 +++--- >> xen/common/numa.c | 36 >> ++++++++++++++++++------------------ >> xen/drivers/char/ehci-dbgp.c | 4 ++-- >> xen/drivers/char/ns16550.c | 4 ++-- >> 4 files changed, 25 insertions(+), 25 deletions(-) > > This is an odd mix of files touched in a single patch. How about > splitting > into two, one for common/ and one for drivers/? > Ok, I'll do it. >> --- a/xen/common/compat/memory.c >> +++ b/xen/common/compat/memory.c >> @@ -321,12 +321,12 @@ int compat_memory_op(unsigned int cmd, >> XEN_GUEST_HANDLE_PARAM(void) compat) >> >> case XENMEM_remove_from_physmap: >> { >> - struct compat_remove_from_physmap cmp; >> + struct compat_remove_from_physmap c; > > The intention of the outer scope cmp is to avoid such inner scope > ones then consuming extra stack space. This wants making part of the > union there. > Makes sense, though I've not been able to find a definition for the type 'struct compat_remove_from_physmap'. >> --- a/xen/common/numa.c >> +++ b/xen/common/numa.c >> @@ -382,7 +382,7 @@ static bool __init numa_process_nodes(paddr_t >> start, paddr_t end) >> * 0 if memnodmap[] too small (or shift too small) >> * -1 if node overlap or lost ram (shift too big) >> */ >> -static int __init populate_memnodemap(const struct node *nodes, >> +static int __init populate_memnodemap(const struct node *numa_nodes, >> unsigned int numnodes, unsigned >> int shift, >> const nodeid_t *nodeids) >> { >> @@ -393,8 +393,8 @@ static int __init populate_memnodemap(const struct >> node *nodes, >> >> for ( i = 0; i < numnodes; i++ ) >> { >> - unsigned long spdx = paddr_to_pdx(nodes[i].start); >> - unsigned long epdx = paddr_to_pdx(nodes[i].end - 1); >> + unsigned long spdx = paddr_to_pdx(numa_nodes[i].start); >> + unsigned long epdx = paddr_to_pdx(numa_nodes[i].end - 1); >> >> if ( spdx > epdx ) >> continue; >> @@ -440,7 +440,7 @@ static int __init >> allocate_cachealigned_memnodemap(void) >> * The LSB of all start addresses in the node map is the value of the >> * maximum possible shift. >> */ >> -static unsigned int __init extract_lsb_from_nodes(const struct node >> *nodes, >> +static unsigned int __init extract_lsb_from_nodes(const struct node >> *numa_nodes, >> nodeid_t numnodes, >> const nodeid_t >> *nodeids) >> { >> @@ -449,8 +449,8 @@ static unsigned int __init >> extract_lsb_from_nodes(const struct node *nodes, >> >> for ( i = 0; i < numnodes; i++ ) >> { >> - unsigned long spdx = paddr_to_pdx(nodes[i].start); >> - unsigned long epdx = paddr_to_pdx(nodes[i].end - 1) + 1; >> + unsigned long spdx = paddr_to_pdx(numa_nodes[i].start); >> + unsigned long epdx = paddr_to_pdx(numa_nodes[i].end - 1) + 1; >> >> if ( spdx >= epdx ) >> continue; >> @@ -475,10 +475,10 @@ static unsigned int __init >> extract_lsb_from_nodes(const struct node *nodes, >> return i; >> } >> >> -int __init compute_hash_shift(const struct node *nodes, >> +int __init compute_hash_shift(const struct node *numa_nodes, >> unsigned int numnodes, const nodeid_t >> *nodeids) >> { >> - unsigned int shift = extract_lsb_from_nodes(nodes, numnodes, >> nodeids); >> + unsigned int shift = extract_lsb_from_nodes(numa_nodes, numnodes, >> nodeids); >> >> if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) >> memnodemap = _memnodemap; >> @@ -487,7 +487,7 @@ int __init compute_hash_shift(const struct node >> *nodes, >> >> printk(KERN_DEBUG "NUMA: Using %u for the hash shift\n", shift); >> >> - if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) >> + if ( populate_memnodemap(numa_nodes, numnodes, shift, nodeids) != >> 1 ) >> { >> printk(KERN_INFO "Your memory is not aligned you need to " >> "rebuild your hypervisor with a bigger NODEMAPSIZE " >> @@ -541,7 +541,7 @@ static int __init numa_emulation(unsigned long >> start_pfn, >> { >> int ret; >> unsigned int i; >> - struct node nodes[MAX_NUMNODES]; >> + struct node numa_nodes[MAX_NUMNODES]; >> uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; >> >> /* Kludge needed for the hash function */ >> @@ -556,22 +556,22 @@ static int __init numa_emulation(unsigned long >> start_pfn, >> sz = x; >> } >> >> - memset(&nodes, 0, sizeof(nodes)); >> + memset(&numa_nodes, 0, sizeof(numa_nodes)); >> for ( i = 0; i < numa_fake; i++ ) >> { >> - nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; >> + numa_nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; >> >> if ( i == numa_fake - 1 ) >> - sz = pfn_to_paddr(end_pfn) - nodes[i].start; >> + sz = pfn_to_paddr(end_pfn) - numa_nodes[i].start; >> >> - nodes[i].end = nodes[i].start + sz; >> + numa_nodes[i].end = numa_nodes[i].start + sz; >> printk(KERN_INFO "Faking node %u at %"PRIx64"-%"PRIx64" >> (%"PRIu64"MB)\n", >> - i, nodes[i].start, nodes[i].end, >> - (nodes[i].end - nodes[i].start) >> 20); >> + i, numa_nodes[i].start, numa_nodes[i].end, >> + (numa_nodes[i].end - numa_nodes[i].start) >> 20); >> node_set_online(i); >> } >> >> - ret = compute_hash_shift(nodes, numa_fake, NULL); >> + ret = compute_hash_shift(numa_nodes, numa_fake, NULL); >> if ( ret < 0 ) >> { >> printk(KERN_ERR "No NUMA hash function found. Emulation >> disabled.\n"); >> @@ -580,7 +580,7 @@ static int __init numa_emulation(unsigned long >> start_pfn, >> memnode_shift = ret; >> >> for_each_online_node ( i ) >> - setup_node_bootmem(i, nodes[i].start, nodes[i].end); >> + setup_node_bootmem(i, numa_nodes[i].start, >> numa_nodes[i].end); >> >> numa_init_array(); >> > > I think renaming the file-scope variable this way would be more logical > and less risky (the way you do it it's easy to miss one place without > the build breaking). > Ok >> --- a/xen/drivers/char/ehci-dbgp.c >> +++ b/xen/drivers/char/ehci-dbgp.c >> @@ -424,9 +424,9 @@ static void dbgp_issue_command(struct ehci_dbgp >> *dbgp, u32 ctrl, >> * checks to see if ACPI or some other initialization also >> * reset the EHCI debug port. >> */ >> - u32 ctrl = readl(&dbgp->ehci_debug->control); >> + u32 controller = readl(&dbgp->ehci_debug->control); > > Why "controller" when the field read is named "control"? Perhaps > easiest would be to drop the variablöe altogether: It's used exactly > once, ... > >> - if ( ctrl & DBGP_ENABLED ) >> + if ( controller & DBGP_ENABLED ) > > ... here. > I was fooled by the comment above its declaration. At first sight I don't see anything wrong with dropping the variable, but I'll check it properly before submitting a v2. >> --- a/xen/drivers/char/ns16550.c >> +++ b/xen/drivers/char/ns16550.c >> @@ -1473,7 +1473,7 @@ static enum __init serial_param_type >> get_token(char *token, char **value) >> >> static bool __init parse_positional(struct ns16550 *uart, char **str) >> { >> - int baud; >> + int baud_rate; >> const char *conf; >> char *name_val_pos; >> >> @@ -1504,7 +1504,7 @@ static bool __init parse_positional(struct >> ns16550 *uart, char **str) >> uart->baud = BAUD_AUTO; >> conf += 4; >> } >> - else if ( (baud = simple_strtoul(conf, &conf, 10)) != 0 ) >> + else if ( (baud_rate = simple_strtoul(conf, &conf, 10)) != 0 ) >> uart->baud = baud; > > So along the lines of the earlier remark on common/numa.c: Here you're > actively introducing a bug, by not also renaming the further use of the > variable. Please reconsider the name change. > Good catch, I'll do as suggested in v2. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:24:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:24:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573723.898691 (Exim 4.92) (envelope-from ) id 1qQjjq-00063I-8U; Tue, 01 Aug 2023 07:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573723.898691; Tue, 01 Aug 2023 07:24:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjjq-00062l-5w; Tue, 01 Aug 2023 07:24:14 +0000 Received: by outflank-mailman (input) for mailman id 573723; Tue, 01 Aug 2023 07:24:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjjo-00062e-Lk for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:24:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6943176e-303c-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:24:11 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 59B7A4EE0737; Tue, 1 Aug 2023 09:24:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6943176e-303c-11ee-b259-6b7b168915f2 MIME-Version: 1.0 Date: Tue, 01 Aug 2023 09:24:11 +0200 From: Nicola Vetrini To: Julien Grall Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Bertrand Marquis , Volodymyr Babchuk , "Daniel P. Smith" Subject: Re: [XEN PATCH 4/4] arm/efi: address MISRA C:2012 Rule 5.3 In-Reply-To: <8165e7b1-4eef-7b13-32f3-05ff38837100@xen.org> References: <8165e7b1-4eef-7b13-32f3-05ff38837100@xen.org> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 31/07/2023 16:01, Julien Grall wrote: > Hi, > > On 31/07/2023 14:35, Nicola Vetrini wrote: >> Rule 5.3 has the following headline: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope" >> >> The parameter 'fdt' in static function within this file is removed, >> as they served no purpose and shadowed the homonymous variable. > > I am not convinced this is a good idea to keep 'fdt' as static > variable around because the name is too generic. Also in the future we > may be able to remove the global static variable. > > This means that most of this patch will be reverted. > > So as I wrote on Matrix, I would rather prefer if the global variable > is renamed to 'fdt_efi'. > > Cheers, Will do. Changing the parameters seemed less messy, but I'm fine either way, so I'll submit a v2 with that rename. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:34:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:34:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573729.898702 (Exim 4.92) (envelope-from ) id 1qQjtH-0007eA-A5; Tue, 01 Aug 2023 07:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573729.898702; Tue, 01 Aug 2023 07:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjtH-0007e3-6v; Tue, 01 Aug 2023 07:33:59 +0000 Received: by outflank-mailman (input) for mailman id 573729; Tue, 01 Aug 2023 07:33:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjtF-0007ds-Pu for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:33:57 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2073.outbound.protection.outlook.com [40.107.13.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c5db7083-303d-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:33:56 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB7667.eurprd04.prod.outlook.com (2603:10a6:20b:2d5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 07:33:25 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 07:33:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5db7083-303d-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hgBX+mx2XlbVoC4sJxuKCOEyYGozJsj3+ulWYHH2Zg4v9C2icRfJJxjt7W2IvhKEghOnZTQQnCKezSWlnnA9CzSb61DXSKp/XhUYxB9ic7uM+bvPaJVjoTbTH/vcnAJrVwEjQs0R2oD/HQhuZPvOFDan6H6Mdsx2rp2TO5/m3HvS1uuqnt7CYBpNi1ekr0S8Yd1OQrvZmLbehRVYv0lFBbHXOwumMna9nvKnZtYSxYwCRMXS4Ge2Wj0FLY7Yh+JxEsqsHyMLjIN9sEKXqZecS3Ms7no44b18aok5gyEvVr6zSRUSRGqyiHCGWIqIXQzWq/ttiSCWXNkzdqJOVg90TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7OMh/x05/42TX1QWERn3Tnku7+pQOTwbHOS3lypRLzI=; b=nPFJao3AeV6tqZsJjbdb360mhxiYHX58srbWMKo0HUFxw7gcfI3StirsT1vXsigLPZKUJ6tYxQR0l65ULFDaYvCP1qzg76Bx+xy195Vm+KLEUKiDwFXpHi/EjmHLSbJnjW9yIKGIFQnk+QT2FuYdTWiETDeP9UGL2xJdMf6Ff3hRtYHSW3oAxVz2StaxbX2xM+QoeiaebkZDhnNDIl7ih4JK4+Q+YubjaMWdY+ya0D92+IUONjZSwDCjbwd0Di4SCiFs4ZdFaoZkjbxr+I+MFbvJFCCQsRV1brfNIfPieG3OeDRekDXHsZmUn3GebDz9ScOTLNL+GC5YniVmTJ2GWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7OMh/x05/42TX1QWERn3Tnku7+pQOTwbHOS3lypRLzI=; b=dHPz7CN6BUYFT0ZgpJypWA0TNx2sIrrFp1o3kIkB/b4Qwz4Qs68sHfhuK5YRW8xn3XR4xNEeG1jVKXOVNskiPWpCa8PucpCwT/rybmUGIJjJCM5lezPm8dMdqEYQkgmq+S5qa5XFcuraYhfb/lJw3u94zwKVqhJHYID6f2YHxg/EqpDsXWCbA3lFi104MWRUq8vRrdgkcUvajIpqdvmNKQwucPpkJg8EvsHiJl3KxdExWGr7bf4bEeYOu92k0E8G45N0p6mXsGMf1hftQwWey1bNnHvDvugaNOIMGUXPlXim2v32fq6b63aPKyxB+ThSFBleCUVZDcy0+qrOckeLHw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Aug 2023 09:33:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] arm32: Avoid using solaris syntax for .section directive Content-Language: en-US To: Khem Raj References: <20230801001258.555944-1-raj.khem@gmail.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <20230801001258.555944-1-raj.khem@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0257.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB7667:EE_ X-MS-Office365-Filtering-Correlation-Id: b031b435-7d3d-4aa2-e63d-08db92619794 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b+a14iDaJJLFwMILu+JzbV484USc2l5cMnhy2wbhPZ2k1Mf0py4n2Y5gM2tK+0GyS0GmAZ+1uYe+lKpdcIhr+9R2iNRBd0Capkmucbikzvwx3bjBOtzkvVTI9K9dClo21Op4x+Garoxqq8dHGz5214xYHwvmwP1a2UX/Y25+irYvmTMizwnV5iLGBMf0TCbGa1kbuUtkb4RtVX37txNT1athpQ+QmEhORfZtwIH26M0jY6N5JLTwpX/hwur9xgPeuewuOpLVrTvZ+eH7H1ROolYuE4IsDLSMgrzFXHH1+SBqEPX6GzgYvYRDj22XaB7JXJVdaxarF4xlAIs57vKQ5BCO1iF+ycBBHPKHc4qj5CtQHBDK9QvFQ8wKDUCbMODoiIZwB7NUxNsJBCg/uMtTzIQ0hfZsEsGbXoem9JNUk16wWLKnn4azOFgDqMF5V4ABJ/FQL1u/wcu7Tbdrcfqj03NEvuV/yGV//KyBea8HEJEjHTF9srBooQroQGvbPT9elWafHhcjoTAdE7R0V63rijxqaKwvED71BQ2IU9/lavx8j4m3wDJE/Dd4i4DQoAGdqxoK/v2jsj1wwVU80SB/geobBIRi5U2MnEF4SaIKIxN6XGJP30nTwKM0CARaX7Iee63RxNHKnoCaxFL7AMZ+aDNOZuaCa9h9b7wFlfyYdIE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199021)(966005)(6512007)(26005)(6506007)(6486002)(36756003)(8936002)(8676002)(5660300002)(66946007)(66556008)(66476007)(53546011)(4326008)(6916009)(2906002)(4744005)(2616005)(83380400001)(478600001)(41300700001)(31686004)(86362001)(186003)(38100700002)(316002)(31696002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEFCZnlTTXpvczhmajdrR2ZHV09uTGFuRTRjY1ZTRmdhOXlhQU1oOXkzekY3?= =?utf-8?B?endyMTJaMGp2a3JzQkQzcEJBWTROcXByQ0xCa0VDVFlyRmF1WXUwTk5GT0RD?= =?utf-8?B?NzcxdTRlZFp3NGZBbmk0K2hOMXpVUHZIaEVHelgyL2o0WnkzRUxyaE1mOU5I?= =?utf-8?B?Y3RVQ0pZOW1TVDNBVFBJb1hhbVhNVGV6M0VVZG1ueXJOS1ZWUXFQTG1sUit0?= =?utf-8?B?OVRoZGorTml1OENRdERSK0Z5VnFEN2hVeDJhRzB6NkJsZGlZNW9wV091NFF6?= =?utf-8?B?L1F4UDBaVVR6UDlhdkl5S3o5NmNNV25qS0ZBaUxGWUVlL01JcWFQODNKOWp3?= =?utf-8?B?SVVUQ2hQMnZrOGZwekJUNXl5ZkZkbjJ3aVlnbHkyZFRnZnFlU2ZQOTN6S3Jp?= =?utf-8?B?REY1NjIrK1loUklKQy9HdTdIRTRHRTlEby90di9GclppRXlqSE1KakQ4QjFV?= =?utf-8?B?ZksyWkhjQnNDOEcvN1BibHQrVFdaTXpOb3JaaklsMjEwd3pwZlBYa0NNcWxo?= =?utf-8?B?QUFiV0ZvS2JhOWdPajJaYmh4MmtvWVI3cGdiVXJXTzdOU3pxM0o3UXdoZ2xW?= =?utf-8?B?RzJLbnFYMW9ZSFk5VVQyWjJKK1hyd2gxdm5mWHlCa0c2elF2RnVrR0pKdnFZ?= =?utf-8?B?d1dqWWVjTlJWcDBlUW5jMzlzM3hkekFxSllyayt1M2NjQjBIN3lTZzNrZ3o0?= =?utf-8?B?aXFrb1VYQXZYU29RcmsrdldLdyt5bEthSFlVb0JrYW90WGRGQWkvSXY2SFQr?= =?utf-8?B?a3gyRzNlQUVhZEZyWDZSYUVjek1jTmJieGdtUzVxZXNQcVdGRDhBbHRDdWw1?= =?utf-8?B?RStCTzRweXFIZ1ZsRGJsMml2VlNZUXljVnVBVCt1UHhxUHd5bkowbkFIL044?= =?utf-8?B?WHBVS1BXVEt2OHQrclZDNEE2T3VGa3lyMHd0RytjRXVRM0pPSDVSYTVwQ3ls?= =?utf-8?B?c2Z4eUw2S3FQUHRFQlRZdVFpN29ZaUl2cTE3QlJPdzdCRDNEeWlWdHYwaS9i?= =?utf-8?B?NVpPS2lpakw2YnlZUldudmg3bFYyTndDb0Z4dW9MZUNYU1BFNWRWZDVtRGNE?= =?utf-8?B?UXJmN2VLSW9xd0RtMTk5NnBQOGpkeHhGdE4yS2E1LzJrZHVVTURKNkJtTWJE?= =?utf-8?B?ejFjVUZTcEVMQlRSa0VlVXFDcGNySmd5ejJUaGNVQTNPZTU1TmRZU3RaV2hW?= =?utf-8?B?NmZ5WlBlNFlqbmNnRit2bDBuUzIwL1ZuQkdQZlFBQkRucGVSa3hTNTJKM3hG?= =?utf-8?B?RC9OWWhpcUcwRTZhMFpGd1ZzMHZGOGhwSVF4bGpWRTVoeGRkT2RHV0NqOTAy?= =?utf-8?B?MlpoMHZxK1N4RU81a1NtdkZ4VGNSSGFPOG8wNG1Hc0IzcUl5S3BMdmVOZ3Mx?= =?utf-8?B?WlNiRk91NGVDaEFnUDNiRW9MakU5TzBFQzVmaUV6Sm9meDI2VU15amZPeUlQ?= =?utf-8?B?aGgzY3RWbHRHeTdpcmNmeHE1SnhPVlhXNVJUWTlZbHI4YjRSdkkzVzI1aVp1?= =?utf-8?B?aUpiRzhoeGsweis1NGpGZkk3VHdSM0lYRTE4MlJIQmFFck1aMEE3SksxMEph?= =?utf-8?B?ZEVsT3cxZ25ua1QxcXRLdFlLMFRFYmFkS0Y5VFptL2RUa1FBSER2dGZFdFov?= =?utf-8?B?YTB3cVFMSnVQM0tUQ21UNUdYRldMMWoraWkvRHBUUHIwVzYra0xDWTBieERJ?= =?utf-8?B?c0FCRG9lTExGYnNuYkpnYyszdTRxSGtXS2JOLzlhd3hTNzdVTkpQaFdxZFdM?= =?utf-8?B?QVZ1Y2lHU3h0UUxYT0RzVGY2VEtNT1hHL3diNVBlQS93L2UvTmNSbFVFbnFS?= =?utf-8?B?RVlNaHQ0aVJzOUkyYmEwUUIyREhadmJVT0k1ekpZVXVFVHU2TDZRTHVlbjZn?= =?utf-8?B?V0lNZWQ2azFCcFJUTXJ0WGZiZ01idmZkbWtqYXBtSEVmNXAwSHNuV2RDblhM?= =?utf-8?B?SjBsUHBQUEovUmJRTEZ0Vmd2RDRScmowNnBYa082OWJGRSsvZmdRUC9DU1h3?= =?utf-8?B?cUNSNVI2a2JiWTJWUlFydWlaNHMxSmdsQ29CN05OMlBTSjBJZGU5ekliNVBP?= =?utf-8?B?YklxUHVzOXJDL3hKQXN6dUFud2gxbkVQT2IybUVRTElRRkUvL082Z1JIRmhn?= =?utf-8?Q?GKL0DLTNXcBAUhxoHnS8KVzYV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b031b435-7d3d-4aa2-e63d-08db92619794 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 07:33:25.7087 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: twdrmteSuTtFOtM6B4++tyZJ7A9MFa3Zgip++r0+vYEbjbr0MvHx8s11wzp4VfZLN9V1D3FnTETWxy1sOK+LjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7667 On 01.08.2023 02:12, Khem Raj wrote: > Assembler from binutils 2.41 rejects this syntax > > .section "name"[, flags...] > > where flags could be #alloc, #write, #execstr > Switch to using ELF syntax You mean GNU, not ELF (ELF is describing the object format, not the syntax used). Feels almost like a regression (I'll mention that to Alan), which likely went unnoticed so far because Linux had changed to GNU syntax already in 5.5, to allow building with Clang's integrated assembler. This aspect may be worth mentioning here as well. > .section name[, "flags"[, @type]] > > [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 > > Signed-off-by: Khem Raj Out of curiosity - why were there four instances of the patch? They all look largely identical; if there are differences, I haven't spotted them. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573735.898711 (Exim 4.92) (envelope-from ) id 1qQjyL-0008HC-S7; Tue, 01 Aug 2023 07:39:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573735.898711; Tue, 01 Aug 2023 07:39:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjyL-0008H5-P6; Tue, 01 Aug 2023 07:39:13 +0000 Received: by outflank-mailman (input) for mailman id 573735; Tue, 01 Aug 2023 07:39:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQjyK-0008Gz-K3 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:39:12 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20620.outbound.protection.outlook.com [2a01:111:f400:7eab::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8091c64d-303e-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:39:11 +0200 (CEST) Received: from PH8PR20CA0023.namprd20.prod.outlook.com (2603:10b6:510:23c::29) by SA1PR12MB5614.namprd12.prod.outlook.com (2603:10b6:806:228::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42; Tue, 1 Aug 2023 07:39:06 +0000 Received: from SN1PEPF000252A1.namprd05.prod.outlook.com (2603:10b6:510:23c:cafe::67) by PH8PR20CA0023.outlook.office365.com (2603:10b6:510:23c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Tue, 1 Aug 2023 07:39:06 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF000252A1.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.22 via Frontend Transport; Tue, 1 Aug 2023 07:39:06 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 02:39:00 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 00:38:31 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 02:38:29 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8091c64d-303e-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KmeE+KFDCm87pSD5vNh7lTzirNh4pafilivCNyeC3/qkyTm5VJ0vnmzyqsjetjijx1aul06Vxt/itcih2d3TN+QpfkHfooGrPFwKW96+GwqClOdGbzjF7PtwEMmPchxVSyI+BvLvwlb0Zxukngj6NUmvISQT+s5fwHztXYJp8yzV0L/+U2WyGqVLyJptD8rFPQUnRdPud2RO8POGQ1c76A9LLmhV6tMCrr5jUTJzHG1dqAjijn+EDJbODrSJipyLkXuKhRZ1h7vI8GjynKvhcCnt0RphqePlfJkcLsJvexHx63u/pD4CJDppz9uEBsgAmC0F8CGMqSRlyLaEJVSqqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jrsj4tOqTxTJMHZgg+SgKKHUt7o0rHQ02LTzamC84Wk=; b=Zhsnx3KxKEzJznvQqtoDjVFVOUU6l9cFvl+XzxHUZm0nvzd8RnwIgypRvmzcnO95G7+l+XYWoa9seUWMb851sCkPzLcAwuXvbypIhdPEPcaN1IvdUuG1JeqFhvambZ3egHtXtxkrpXacPaEr1JdeFeezm0EiTuXaalOwrsxzOgn2fmOeGFVN60HQxoebJeVDSo4YwJIdnZ1ufZKqSoUtGUHV3s/TbWwcR2UeLr3CkO42mJgnnKZqFbJca0DMniGU9OLPIbQOmiG1j9lqmDACBjK4HcxcExYBAQt321E+g5cizyXslYekPtXzhIqgIhE0usDtCdZNGtLpzmZLXY3/Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jrsj4tOqTxTJMHZgg+SgKKHUt7o0rHQ02LTzamC84Wk=; b=NvihPH95vM3ROJnrO+RQs24fqdFGsKsASXxlpfbUPWv9AxqCCU43H/OcvV1Y+6niQJu/hQXCNtV5LV/BNZ4OLnYs7rKKOFKNRI0xn0Xs4fSFOm/dudLeL4KllV1jDajMarb/J3GR7hGreK1NMbFYdLZpw2yTvTwb8XKN7KM3HNs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <99574b63-18e5-20fe-659a-432fdaf4b5af@amd.com> Date: Tue, 1 Aug 2023 09:38:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm32: Avoid using solaris syntax for .section directive To: Khem Raj , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: <20230801002853.556437-1-raj.khem@gmail.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20230801002853.556437-1-raj.khem@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A1:EE_|SA1PR12MB5614:EE_ X-MS-Office365-Filtering-Correlation-Id: 00d1367f-d600-42cd-a41e-08db926262c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tfeiLE3SFVTxVzURFB+P5NrSA7puGVWnKXI4H1hU5hLJtJslN/ZKUQikEz7VcC0CzKbpagXUtzszpnqqerDcR/sP+9x72fAivIYaWomVSP1euhNL2/VDhx5YPK+LSGIXwGpM1JlJAlV5I+ausbSNZe0TKDchQZFOaPkRI93KtcKvirgkHXjUqJrVhDlHdNNksXB7QYY7Wg7ONVLF5W3aaOWpci1jTzwaJYaogVIUowwxOv78xlAQeD9EzlUAi4fv3pv9mc5Nv2/EzzNxZU3vYLjOtUGm/tZugbw/1GaITGxoUweroClDFkaOnU69miSxOMbB68PG1Obh1Bky14TYYvHIbUAncsEM9GCPYQUNsfe8G08enFBddt7Bh6BXgZoIWccN9eX3UzJYrRHw27BDFRY+QjXDzwiUiZf4DQ4tf4QGIko+hqvAAK1L/2zpHYQ+szlaicOp4xJb6kd8qFXSswLcEPkt9jlj8e77/H+xzyXX6Gn2GnFpIC9mJdyhvYo6+AoTA6thVXwbBUcQQGTQtqsOsXlyuVTeVu4XwoGjJvFw9scPRKRkj/Q7+VUja9qkSx+lkkeHU2YdXV+0BnpgglhAdyxNryOD4ncSInXiU56mCbx/h9VRHzNNIiBW0idfFOZksbr5EFfUhDWz0FpqIt6VHJcPgw98By9HZhNe40MF34ijUJ6P6t8ejWD45ybgiYcY/tREoHedC9v2pNzfPVsBVm7YNeC00UjOJflFmCw/Wg+SEVn/mUM2XsChwPQ43iupywPlPcWaqneuzy9kx7G8Ua+/rks6coixnxiEFRwM51bQqJFscEAMRuWxZilQ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(376002)(136003)(396003)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(44832011)(966005)(47076005)(36860700001)(36756003)(40460700003)(40480700001)(2616005)(53546011)(26005)(83380400001)(336012)(186003)(426003)(70206006)(70586007)(81166007)(54906003)(110136005)(356005)(82740400003)(41300700001)(31696002)(86362001)(316002)(16576012)(5660300002)(4326008)(8676002)(8936002)(31686004)(2906002)(478600001)(142923001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 07:39:06.3961 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00d1367f-d600-42cd-a41e-08db926262c2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5614 Hi, On 01/08/2023 02:28, Khem Raj wrote: > > > Assembler from binutils 2.41 rejects this syntax > > .section "name"[, flags...] > > where flags could be #alloc, #write, #execstr s/execstr/execinstr + there is also #exclude and #tls if you want to list them all > Switch to using ELF syntax > > .section name[, "flags"[, @type]] > > [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119 I think it would be better to add a link to 2.41 docs instead or to refer to the following commit of binutils: 4cb88cfae843 "PR11601, Solaris assembler compatibility doesn't work" > > Signed-off-by: Khem Raj > --- > xen/arch/arm/arm32/proc-v7.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S > index c90a31d80f..6d3d19b873 100644 > --- a/xen/arch/arm/arm32/proc-v7.S > +++ b/xen/arch/arm/arm32/proc-v7.S > @@ -29,7 +29,7 @@ brahma15mp_init: > mcr CP32(r0, ACTLR) > mov pc, lr > > - .section ".proc.info", #alloc > + .section .proc.info, "a" > .type __v7_ca15mp_proc_info, #object > __v7_ca15mp_proc_info: > .long 0x410FC0F0 /* Cortex-A15 */ > @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: > .long caxx_processor > .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info > > - .section ".proc.info", #alloc > + .section .proc.info, "a" > .type __v7_ca7mp_proc_info, #object > __v7_ca7mp_proc_info: > .long 0x410FC070 /* Cortex-A7 */ > @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: > .long caxx_processor > .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info > > - .section ".proc.info", #alloc > + .section .proc.info, "a" > .type __v7_brahma15mp_proc_info, #object > __v7_brahma15mp_proc_info: > .long 0x420F00F0 /* Broadcom Brahma-B15 */ > -- > 2.41.0 > > The patch looks good but a fast grep shows that ".section .dtb,#alloc" in arch/arm/dtb.S would also want to be changed (I do not have gas 2.41, so you can check it by specifying dtb to be included in Xen image through "menuconfig->Common Features->Absolute path to device tree blob") ~Michal From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:43:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:43:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573738.898721 (Exim 4.92) (envelope-from ) id 1qQk2f-0001Gh-D5; Tue, 01 Aug 2023 07:43:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573738.898721; Tue, 01 Aug 2023 07:43:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQk2f-0001Ga-9m; Tue, 01 Aug 2023 07:43:41 +0000 Received: by outflank-mailman (input) for mailman id 573738; Tue, 01 Aug 2023 07:43:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQk2e-0001GU-2h for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:43:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7d00::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20e07f5d-303f-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:43:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7594.eurprd04.prod.outlook.com (2603:10a6:10:203::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 07:43:37 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 07:43:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20e07f5d-303f-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QJWTNW63zU+us13h/Zdk0Sbv1GFuLpZSEfHB3mVNBC1b7g3be2VAF9S8LCKcsp+O5V82OFQBgXSQ4Nov2Tilb1QlunMj5sPvvSQAO4eavBddEXqZr8O/4B4RW4RRXEhoW5jzM1L7KPkNAyjZgf1flSbByHfoJ1kySU0tbL6ylROsF2+IJAhJY4H7HGysAYVI4BNCVieVVurmGgH/Yu/R+5xgYbk1GzRNgjCHhFs3HwbgBVCQvaz+voycqkFIIQg2P4pEDG/pK+7onW5V+4RMjpHFwTs24a4vDdIDQ6toh8CxSpVEWWX3fB1m6hn5ma/IMvxnwCf94peje35aiyaMeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXhRtAR1xA3P8CYtgrQJq850f6rswlouKxJcR4uEtb8=; b=fcdnm3/MjD2VWW0cswMbz2TAnjYga/NhwF/5DW4E3axo1d32E5FE1xd/OhFXXj1r36i+LthvmAG32QnuXLnAf1NiIm81hAkloZZvT4dYvzEPxRp65F+dwWGUYxdqLPXR458KpvmAk7AZxHk8CXHvuvw3DUAsk/TLtxO8NQKKdBsdQOgOIVNKn7C2p95kaUCTihit6qgc6/DmcWj7KaafK+dn3AW8/k8ZsLZrVMA2YrIM29HoQXcEqsWWbcy2H+2X/iHn0PP9As9MHH/Y/XE/W5yFtUQ/75MXOPFYbzMS+4fwbyPBMWdZeT1MR6LSYIbeDfCQIEP46Vvc/j7YUqC78Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uXhRtAR1xA3P8CYtgrQJq850f6rswlouKxJcR4uEtb8=; b=X0LyQ+z5UIswZN/9Z3kCwJroACxPwxbJFbL0Mzangt/Kq8EazS/akq0yjs8Sy6oRwUTZz+5N2zyLsYAY3OxZNYxVamJeAL6L4kwkykhz6o56KPQuuUW/GPemaVRFawPul1QAr5/goYNEkZ3n8LnoaBgIPBMFkN4fDRcI+7K/GbprMd3H0AKGKE+afUnLSxJJa8qgYGA2k+pAgG5YKbN4s54KysENMALkdRDXsc7jZXpphpoWZ97XA6yrbSDn4glA4WrY9VLEzotdp+/DmJtpe8JsU/RtAbZYnJd+cJRI0ZZxhL6rQME0rcRPH8CyeKyaW4y46sa7iusrLqJONPdnTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6c8f904c-d7f1-343e-2208-6cf963e1e25c@suse.com> Date: Tue, 1 Aug 2023 09:43:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Content-Language: en-US To: Henry Wang Cc: Penny Zheng , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Chen , xen-devel@lists.xenproject.org References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-14-Henry.Wang@arm.com> From: Jan Beulich In-Reply-To: <20230801034419.2047541-14-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7594:EE_ X-MS-Office365-Filtering-Correlation-Id: f3ef1de1-fa11-4fef-cad8-08db926303cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VwM+kfzJ09gTRK3IlMxkWh0JB9jajoRKknPCOcb57K+kMmuQFebTB5Jtv3WvSN0iuBMRaPEPkPS3O82egWtfqDN8Rg+UeiYZOzSNhotXM7+hqHTmUh8iEEf7sAYTVWg5Cp7ZHcMqnM5RCiVYLaDO00l/5nAWQPUG9pskzQQGeVbdpRvPIp2iGPav2nzDRIh/ivhnc7qIyqluQ9ZWfmVZ3Q2Hk7gjUsCrsuknhN33HA9AiXBZhT1DJem7FFGZ/vNao+HD3lslDnrSQn07hzQSLCFfNyJE4eZYHCgMbxJDt5bFvw1/FB8pctp79EtetNtJ2b7mJFpw3jJpMsBtK4k8SQXQU7smV39/1AQrQYzE0MbjTsSwOvG8PtdtQtiztqZAq3UiVXPWD4lMq+YOfx43pnZeMR5VIi8yzOYst/83VKv+aimOFIyVDYcR2ePzP9WgmUNNl28mOe42FNvoU9F64OrXI+3usyVhpH3fK+exKcb5pVcnCVuPHZKEL1PwJo8agQ/iA5t5QttE5lpIwbghgmjjZUgu5goyoXTCikeGPDLFl9TO8jxJr6XJha4hcHbMp5gZ41qbEJHWp6doFeeS3WXZfEABBFQy21bu/b8IpjiykEvNW/ihvlCjgysle3MoFBoY8+mz3LtpWlbOq/H8Jw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199021)(38100700002)(6506007)(5660300002)(53546011)(4326008)(6916009)(66946007)(66556008)(66476007)(54906003)(6512007)(478600001)(2906002)(4744005)(2616005)(8936002)(8676002)(6486002)(41300700001)(36756003)(31686004)(31696002)(186003)(316002)(86362001)(6666004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUorOGVvZmNmQ0IreExUSTlJalF3QWpxTnBuU2xJa09lcmh2QjdZR2ZRZXI4?= =?utf-8?B?OHNlVHFXTWtBd2xSNlpSNkVGZ09RV05kQVpXdk82KzBnZk5LSjJrejN6eUlW?= =?utf-8?B?MDFuRy91ME9ybU1xM0oySHN4NmJObkdxeUJTeFRmY1ZQc3VRNW01NkpVMzNC?= =?utf-8?B?bjVvNHo5RjhhOVFsd0JXTE92WDV0NVpFMlo0UXlQQzNNTEtSemJIM2RjL3gv?= =?utf-8?B?bzZyN3lUNGswVXoxeG5la3BMaW51dWM3V0FWbUlZTjZWOGloSEl4TUhYZmw3?= =?utf-8?B?VFZmYlZZRVpsVmxDNW9Fd1p2bTNld01GU1JwSUpGK0RsMFNkZ2J3K2VpQldO?= =?utf-8?B?MmxURW9kblMvQ1hITlZaNDUxaHk2UWpwNS9XUko2OHhkVmFTayswcDI4ZmJx?= =?utf-8?B?TWp0eFd4UkwxbEZrcW1UbjFlNk9sY3lkTlZrVjBSNFBBbWFFaGwwR0hpY01Q?= =?utf-8?B?eE05bllHMXQ1SExyVzVFWFV0YWhscEpZNnVyUG1JcER0OThscFh1bUJhaE95?= =?utf-8?B?UWE3VXYyb3FsN1NJa1dQWjRlaHNMNUc5QitVdzNSZ21NdlM0d1NYSCt2eVRP?= =?utf-8?B?M3NYNTFldlV0d3hQOUtudGNkQ1k4Q1VMZVBrVkhkRnRUYXJZUklBVkE5bHE3?= =?utf-8?B?NTlkcWZzSDVZallSUUlxcXdvbmRrRS9BRDhaMTlVbHhmTW5uOVpLZFU5aFpa?= =?utf-8?B?a0JpdG9qZld1T1VScThtcEVJZmtWd3VqS3o3WlNLUkg3UDYvd3BnNHV4eS94?= =?utf-8?B?U2NlWWtRQ05adDM3a3RrRWFVbjl6V092aENVZmZlUzhXbmJyQVpucm1GZVV4?= =?utf-8?B?d08vY2x5RFhwSHpHOGRRU2F4d3BxV09wY0lCUTFleG1mZFRtTStEMkRuVUtq?= =?utf-8?B?UUNjTzhVZk9TQUF3VVRURjRBTVlyclE0OXVibmtZby9PeTlNeXdEM1lWUkZk?= =?utf-8?B?MUhaZjV0bmF1OW56akRIMEFRd1FCWlA2Snc2R3V3eWU2UWhscWNvZ1hRTXVw?= =?utf-8?B?NlBzRHNBUHBOY2EzNnJTb3c0Y3FJRGEzRkN1aTk2cTZYWW5KS3YvVUN6UjhE?= =?utf-8?B?YkgyeTZvQ0NqRm9xQytUQnR2L29Rb3RyaGxuWlh3cHFZWEw4TVFHSmphTTZW?= =?utf-8?B?c1FkYXdTNCs4VXBMMitRYmM4NEhvcVNMYjBqeHdwckI4dlJXZVZ5NzMyVjFy?= =?utf-8?B?SUo4MHE2R3hEWXZBWjQ0TGV3clZXeDl3NkVHSm9pQ2ZFeUxYbVFWbVgwajYw?= =?utf-8?B?MGMwWkM1aEF2ZTB1eGF0ZElmc3U4RGpmRjZzWmZsQzBBWW9aSVZDSkpNZzFz?= =?utf-8?B?QzBrRFZJVUxyeEpjak5MdzJxWlJ0cithMTdZdTcxQS9mOFl0UFk5Wm1rcmZJ?= =?utf-8?B?UUg2a1JhdEF5dm1rT3JHaW1uUEdqbTBOb3I3OEtVVWlJQmhUOHY4ZUpON05O?= =?utf-8?B?QVlvNFRuWXloVEw2NkhBVlhacFc3UTlUYnhHRm1INWRPNGxLa0JrS1I1MGJo?= =?utf-8?B?QXdkVTVXWTdJWVhOS2gzMFNJRnN0ajFabDB5RlRVcHBYQ01kSmZBd1RIdGI5?= =?utf-8?B?U3hFRXNVY0JaeEI2RnlSWCtpcm1JZHNIZ0VrcUdxeUhlUkgweGNiMHJ0YWo5?= =?utf-8?B?Z3M5TFdjc2xqRnozcml2MnczdFJiVndRRzBhQnc4NFZPM3lKUERGT25seU1o?= =?utf-8?B?RjNRUThIT2pwSWFpNjU0RXRpOGtoTmpNeFpSNUtDRDUzMlRqNUpoMDhOZ0wv?= =?utf-8?B?bVAweGtlVFVRRkg0Z1ZXMnBxWmlkQ2VYS3V4eTVGaTBJSmJ6TVdkbEZ1cDNO?= =?utf-8?B?NFIvcE8rZ25yb3ZkTHcxR0EyWFk1NVFFNWJ4aG9ZZHMraTRjaGVmdE93U3Np?= =?utf-8?B?alhNbThQaUErZTZpUmUrc0V3aXR1NkhQV2xMUEh5dUdKYmpOK29SWnBFWlpR?= =?utf-8?B?amVBZU1MaTBRRmtNT1BadHdPbWc4Vy9WM05BSlJzMENibGxBc2x2M0FVT1F5?= =?utf-8?B?a1FqeUxmUnZJRXNmRXdOWFN6T2lCQWZKSUJCUFhJeGhqbUZ5YTVrWDZaMjU2?= =?utf-8?B?aTVUNXYwRm1TTU8wT29FUGJxY1JDQ3VvRTNTckxiOFlzTEJ5ZjM3Rm55dVVy?= =?utf-8?Q?3CyUoU6RDgL+QoMk6BiliGIa/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3ef1de1-fa11-4fef-cad8-08db926303cf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 07:43:36.8380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uo5SBSxHU4K2bkOuWcpnBfacVPqbVoBJ2LmHL2GzY/FCffYF1fF8BO2NUxmnDU5Zfp8AinM6oS6LtdPx+3jfbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7594 On 01.08.2023 05:44, Henry Wang wrote: > From: Penny Zheng > > SMMU subsystem is only supported in MMU system, so we make it dependent > on CONFIG_HAS_MMU. > > Signed-off-by: Penny Zheng > Signed-off-by: Wei Chen > Signed-off-by: Henry Wang While entirely Arm-specific, this looks to require a non-Arm ack: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:47:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:47:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573744.898731 (Exim 4.92) (envelope-from ) id 1qQk5u-0001uA-0G; Tue, 01 Aug 2023 07:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573744.898731; Tue, 01 Aug 2023 07:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQk5t-0001u3-Te; Tue, 01 Aug 2023 07:47:01 +0000 Received: by outflank-mailman (input) for mailman id 573744; Tue, 01 Aug 2023 07:47:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQk5s-0001tv-6J for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:47:00 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2061b.outbound.protection.outlook.com [2a01:111:f400:fe16::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97915bac-303f-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 09:46:58 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7594.eurprd04.prod.outlook.com (2603:10a6:10:203::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 07:46:56 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 07:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97915bac-303f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l1UqYlcdERnl5dRISnbPh2/Q6vlBtAUpdAAYOJpAta3zdxzbC9M9plNOlhqBmVgd5/Yclrcs9bMVCdfPa7LMS+sGZgwZ9Iw7AkD6+P8GEb2mHrYN+RUy/9EvgQKAJQD09Cw1Elu4FfChsDHlHS2cNqr14B8h3GFfSpIwl2m5mlM6u/7LG7nJfAVLh+olRa4hosbr1mE50YAm9u2OUxZPW1SWk5u4YLeUMq0VuCdr7Lrnv501VIXxSoovDdKHPvtkzbcTPhb4J23a2VY2jul1wJtrz3byUEd15fbK11IIeBzldIX5qQMBkwSzyL+XjhlmzYXBFXsahJHchmPtQykbaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Gw0CWE+jIe4M6iBCvoM0MNOxL9X3RV4aI5Dc02R25U=; b=McRVWd0U7c38DqVOwBjP4sZLuswVSLU8KpWP8Gwynzx8VYH/v60NY9DgzlypR5StXRboZG3OvV35G0K8M6gW1d2YGL3SdixEAR79ObZjVUrYWKLuSq19BC7xUDWfVa3suM/57shVgaUAtCsK2ph/JUF4WCv36il/dAV6WblmyIWF1g0ojFbIbvbrqXPFRNUg+IgEBuNxtiLn4/59YNRYdpoDiFmPBMCJta/RTISei7zaeN3KuQtWl/aiStAMBdi0igkZ4AqNHAMwMz9e/XNwO8rlLslu8n3Bn9gVF2YwlFNk39Jrpft/7XvNmnH4YNTAVoJYO5JK5dSo3OlCVMf98Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Gw0CWE+jIe4M6iBCvoM0MNOxL9X3RV4aI5Dc02R25U=; b=bptiSpKQDDmmMSVifSJTYEq1sp72itjKk+QvtULVVjLGA7Rlqo7/fEwZZDify/mUUC0VKGsEN63x95paURRMfv8NYdIUbksiHlt7OYEj0/Z16SqD8+G5T+rPo/DrHX67GVJqQeTSpOlDgzE8MHnH8sre3unatq+19TiHAXi1RGJ42EIdyMTkv2hkmINSt2CElr4rTEmNTqSyXyPk/KkE2RVyXLSIhrP5GlzRX+UJLHJSAz18J9jUmD/3CT7qOMIqRqDXtQGLBFkqNNV8swoeAvGX+GjkWXrCR9AG2gglTc1ByY5qicslFxZrXvENeo453KxaVDQ2GQ36K5qUSzwZKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8bdc7a9b-4fd9-ded4-dc13-cdffcb1284e7@suse.com> Date: Tue, 1 Aug 2023 09:46:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 3/4] xen: rename variables and parameters to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <8aebc67a150cb4116affdd6da755a8e82c827ffa.1690810346.git.nicola.vetrini@bugseng.com> <2e0a88de6c6d0e7ef23bf14f0f945c0f@bugseng.com> From: Jan Beulich In-Reply-To: <2e0a88de6c6d0e7ef23bf14f0f945c0f@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7594:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c3f3c11-423a-4958-8f5b-08db92637ad2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ozpa5NOQA0RCVpTm4ZFmhXpZK5C8XHL6/89kmgY9u9w3wdFcm/DQh4JOQFWgeRQUd6HERa4l9j9cTAbadKJMcu7CMBXTzeNMGCffjWFuWmvViRkBVGm27ZzObPHe64zmGFyynyWPwkqULw7UaRXds3ZHjAT/mvqu+Zc5S1qbSW06osamVpnqT/f7IYdlz73cE9bSNn1SDOPNF10V3mLqIyOuAZiTqrOJAPh60ChAlf+Vv71vRgG4RXCqCqbltt+obS+qORr3KtqFEj8+K1/OiVGFBbjNe/l5YzH8nwPI5xZRb2XOStoa9UxUFFtOkSdHEzeOUhv+sa9cr9Zb7xsG+zzRRRypOgxg9p+9HUxpafYTpc1itva1jgtPDW/gu/b1EaCmNr48uF0/Cn+0Du6gk4RySuYyyZR5yxcIXgk5I7MpiQGnXy6yatLUnzdS3vLTWmSwelC+AQ4nLyhhdmsr/ZVvNKG7T1zuPt+8RXGyd5DjKLLa+roNoYB3XEs+MlEsa5dlY6xozMG5wtSftaB4LPF8Cg7+wcgV4iZ08VMj36oJUGU1z2+i486cDB3CioEIKCEMlwEoSFIZz7SCLUK8KHF2k8AJx6ZU2vglawpYRIdQc06tLPs6V2GkeuaLkHO+y0LyYaqnsUcIQfBp66d7Jw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199021)(7416002)(38100700002)(66899021)(6506007)(5660300002)(53546011)(4326008)(6916009)(66946007)(66556008)(66476007)(54906003)(6512007)(478600001)(2906002)(4744005)(2616005)(8936002)(8676002)(6486002)(41300700001)(36756003)(31686004)(31696002)(186003)(316002)(86362001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGdEc2p5NEp1eEppVnZpNEltRjM1SE1jbXp3NXF5NnQrd0VBSjJPc2tLTHBj?= =?utf-8?B?dEE0V0hVeXAxdTY5d3kwN2FKNnhXVjlzTVhuU0grR3JCQ1Zza1JscXRFcWx0?= =?utf-8?B?NGZOaDJHYkx2U2FRK2R1b2NTTTRDNml6Z0hLVG9XV3hHR2UxOU5uai93OUZ6?= =?utf-8?B?V2tQTzBIcVlXaHBhNk5HNGVGRVltNmg5UVR1a0t0MjV3eTZFeG11L0dvbDZ4?= =?utf-8?B?YmhodW4wT2theWpJdXRuN3ZRK0N6NDBZcXRaVlRpdU9hUDZPWlBic3h0K3FW?= =?utf-8?B?V0I5SldPcnJjSkJNeEorZUNGNks0R21ERnJxcWdQdm1SR2pmSkZXVVBNbzBE?= =?utf-8?B?VGQ1NlA5SDMxYVNON1h0QmIyVlc4Y0lOUnhGUTA1SjdpZnhKNE0wRkZ3MW9V?= =?utf-8?B?QlMvd1FGM3VFUVpteWZsMUduS2JhaTVGVGxFTWtiREhVZmJQTG9udGxEMG82?= =?utf-8?B?WUkySC96K1l2bk5jbExYZzBjeE9YSy92M091bklhcEFvd3N3TThUSW5LTHZa?= =?utf-8?B?R21BVUV0Z3JkcFJtS3NyWXRIMnE4MGsvKzBEN3N6UDhJV3RIbU53VUFZckxN?= =?utf-8?B?L1pTMUg4aTVROHFvZ2JKUUpqc2FuMXBxejI3bjBQMUpHU0dlTFBqRmczN29C?= =?utf-8?B?TEpaU0RPNyt6clBWUTVUd3FGaW9HWmZjREFodHRpZTRnR3hRTmV4bzhMOHB1?= =?utf-8?B?N2Q3b0dndlpKdGNjVG0zczNxQmh4OC9vNys4SkEwbXNJV3AwV1NwRlhXa0Vi?= =?utf-8?B?WlY5UFdVaWc2SzRucW1KTTZqR2lZdDZnTytTNEEyalJYT2VNcXFqd3pnbURE?= =?utf-8?B?TU1FSCtpWWZ1dk1kWURKakU2KzRESjZObmI5ZlZJM2ViRmVLdmNYTVQ0b0Rl?= =?utf-8?B?dTg5MHhKdVJuZ3IxTFdlck1qTnQzMG10ZXZIc3JnN25BOXlUeTBoVUhNUG52?= =?utf-8?B?RW9ZU2gyb1pGRzdOUHNRRjlIU0xPd0V5Z0xMWnUxN3c4ZUsyQmJwUU02OU9i?= =?utf-8?B?UlA3Szk2d2RSM0Ruci9sVlZIQkJKck5xaStZU1pRWmhjSkh3dld1SlE5QTVx?= =?utf-8?B?aktENXE5SDBaVXRncys0Ymdhc2g0TkRFelh0WGx3MzQrbm41OWUyOGJXWWZL?= =?utf-8?B?QjFLTWdydHBObEFOai9wTFBxQjFOaUJVZEFaUzJmbExWTDkyeHI4TjlvMThz?= =?utf-8?B?ZkNzbFNidTJ0LzlpV0NnQm1vdXgybnlhSUlTVnh4eFhtOHhyRHAzdThUS2M4?= =?utf-8?B?RkVXOCtrd1Y4L0UzUHdwQ3ZZdDVpRTM5ZStIMklGRnY0ajJCdjY0MW4zMDdZ?= =?utf-8?B?NXJlNS9mcDFxaHNvRFZ6clZ2WkRPVEVKREMrZ2lXYWxzZmk3YWxKVy9iNmt1?= =?utf-8?B?V3RqYzN1UzhLMVNQUzVTVXhUNmxzcFBpMGZDWVI1cjJPbkVOTDFOTElUUlRF?= =?utf-8?B?LzNJYm9lWjJ4TktTaVNrL3NEOGp0bUhkWDE3ZnpmZFZ2UHBQS3l5MUVZTkxx?= =?utf-8?B?VGlPelh3a1J3aEk0MWx0NVVzQlFsQUJrUFM3ZXNxMnF3UXRLZ21uRGtKTmlj?= =?utf-8?B?dnlHYjVaaEZzNGdyZ2pkcVNNRm50enNNTk1VTTFBT3orVndmUFFPblNaY1FX?= =?utf-8?B?aVI1NTE1SUg4WGM3NmFtczJYUDBQM0I0M29xM2hKVUY2TXFCL1lHZXFkTFlX?= =?utf-8?B?UDN0UnFGUCtqZUNMQnh3K1V2N0J3emRYUnVCUkxqSmNJK2d5OTVjWnkwYStC?= =?utf-8?B?cWtOeU1wbmtsZ2QveGxOY2ZGalY3Qk1LMGRLVmNFM0xtQ3IvY3A5UTM1K1o5?= =?utf-8?B?RFVWWmhrM01hbnJxUjF4b1BaY0owNmNlMXh4Tnp6MTFiTWV1TTZ5Y1JGOFZY?= =?utf-8?B?RmcwdDNKMWsrNmtzeFdCYUdzN0Joa2JNbG1oVDMxektXMHA0eXlIOHdmNHRB?= =?utf-8?B?aWFhZytRLzFhWktnazRZZVhUUUtYL0FRVjMreldSTEgwZjBoRWVaNElBaHZm?= =?utf-8?B?Tk11QmYzSDU3ZGxqZTE3N1dESEVCYVE4UDVzM2hzdVozbWNRaWNFQnVWS0p1?= =?utf-8?B?TlVkcjBqbHQyMVVGSjFxdVdnMXI3b2FSMk52UVZINmI0ZDk0RmRiam9LZWtU?= =?utf-8?Q?5FO7TFH15h9vPwvKcFz0pQ6E6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c3f3c11-423a-4958-8f5b-08db92637ad2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 07:46:56.4408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rFVArcxREVQyB4wmCJRMkuKkyx2BKCqObVqAfyqoxYo+AhUjttLqfZ4KB3SFV+geSKzotCZs/mxiNJjjsWknzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7594 On 01.08.2023 09:20, Nicola Vetrini wrote: > On 31/07/2023 16:34, Jan Beulich wrote: >> On 31.07.2023 15:35, Nicola Vetrini wrote: >>> --- a/xen/common/compat/memory.c >>> +++ b/xen/common/compat/memory.c >>> @@ -321,12 +321,12 @@ int compat_memory_op(unsigned int cmd, >>> XEN_GUEST_HANDLE_PARAM(void) compat) >>> >>> case XENMEM_remove_from_physmap: >>> { >>> - struct compat_remove_from_physmap cmp; >>> + struct compat_remove_from_physmap c; >> >> The intention of the outer scope cmp is to avoid such inner scope >> ones then consuming extra stack space. This wants making part of the >> union there. >> > > Makes sense, though I've not been able to find a definition for the type > 'struct compat_remove_from_physmap'. This is a generated type, so you'll need to look in the build tree under xen/include/compat/. (In this context I'm curious how Misra and Eclair deal with generated code.) Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:47:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:47:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573748.898742 (Exim 4.92) (envelope-from ) id 1qQk6o-0002Ss-AE; Tue, 01 Aug 2023 07:47:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573748.898742; Tue, 01 Aug 2023 07:47:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQk6o-0002Sl-6H; Tue, 01 Aug 2023 07:47:58 +0000 Received: by outflank-mailman (input) for mailman id 573748; Tue, 01 Aug 2023 07:47:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQk6n-0002Pp-Ef for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:47:57 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20611.outbound.protection.outlook.com [2a01:111:f400:fe1a::611]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b90983b2-303f-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 09:47:54 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB5PR08MB10253.eurprd08.prod.outlook.com (2603:10a6:10:4a9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 07:47:51 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 07:47:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b90983b2-303f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MeirvmZiZ7WDdzazStfc62tJgsvzX7UctzCSxGQTNImyLiDolSiqU5frnPjoSAwz+G7hna4AWmVv4ibBtEgRItS+HujPQiz4DrDC3Hf8H1tQFm2PzVKuUS/9NC/hq7w/pBEuypUHeJXCyRXZgZhKTP4VpSsMp+J/jebcl4gviBmpLjncEPTgglLRGsv8zAvCt9cLZNrY/lMymrzLqRa2rTmcQBkIx34qr/A9YAZfYyxRKRgxhyGqMEzAouZDLXGrANb6KFadwvckvFF4DgTaJaHF0rR+yvaPN5JEeR4tQ/O2FP4SLg3Ljn3nWZ2ixTevweyL4tz7IVyLPz3rQ01sRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wNATMOPwtM87R+WyTUp6C3cO2tvf2Vb4CWLLGaaKLWs=; b=j9vyPwt5vC8Dp7xYUNPcxptk0irot7tQhOFioYcGzgQitYD7/jIttA68AQ08cWmaaTnDP/md7W7pBSxLT+Fif6lHldcELzuq2DzMPiO2KoJrZBuoA9C1Qy3k2bUexwmYo0dDmlKkq/62Uuq/kpLBFOQkenMHjgs4z+8eKtVDutNAaTGYzKCEA4blcEbZtD+f3u0G2o5qJyF9s9saKUN5WRu9GVLzml+M2QSbc8rIAF9/cB/gEeqkNY5te9b4VkbEs43BOhVuF3jwfbLY8X9pmlhCmKLgcs+TW6SyVklMziL8m6EDBkka0hNiK0IXkk1dSGdqHLswK6W+N+CT8/bqCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wNATMOPwtM87R+WyTUp6C3cO2tvf2Vb4CWLLGaaKLWs=; b=tgQlgZtyCqRsoZeRy1hovUriwHih/Eu/7JX5QNhWvjdc1URKtLwMr+lnFBTSFu+jRrSGKbpSx0lq9AnSgcGkHvO369m37cLAThTVbkUr1sTLlZu4akCZig/AbfitJL2binUgedX0qGTMwccA/n7WPVeJj4SyCzjTE0DJcGXjgUI= From: Henry Wang To: Jan Beulich CC: Penny Zheng , Paul Durrant , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Chen , "xen-devel@lists.xenproject.org" , Julien Grall , "sstabellini@kernel.org" , Bertrand Marquis Subject: RE: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Thread-Topic: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Thread-Index: AQHZxCqigu1wJWpVm0KnP9vpRTw2qK/VD2mAgAAAHvA= Date: Tue, 1 Aug 2023 07:47:50 +0000 Message-ID: References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-14-Henry.Wang@arm.com> <6c8f904c-d7f1-343e-2208-6cf963e1e25c@suse.com> In-Reply-To: <6c8f904c-d7f1-343e-2208-6cf963e1e25c@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2E810C11A217544F87D6BAE6ABBE4206.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB5PR08MB10253:EE_ x-ms-office365-filtering-correlation-id: 5edf3944-023a-46e5-086a-08db92639b2a nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qSoqccTYZ1mU53IJYwZR2AEOyUAxHe5uPMpiZj5pCx3Q8WhpuW/jHiHLrbnBO58nOo6rAS8kVERyYDjuxfC4Eze+ojBroZa7AXv3GO219Vo1ezVlCNKhWkYlNVY6lIKzw9DiE5S+8U4lav5c5UpeCKSgM6E9hXXzpeqU3CdqhFkvs4rs9gMROYBqlhrk3rCYNf+Kz8sIFuC4ed7NAiAL+wlXdWwTAnKYheM0udWQexZKh4Z+tpOoFWa3YOkKvJDhVDQJ2ngK7ahDTeJ4ALXYYAYeDl2t+XDxKPKs5meNrUDOvX6D8QFf2M6ImsEvtxlY4S3Vu57jqmPkhWhTe2+///MNz17HGNApei09pYEEvRLu11ryJMdul6b3dFqW+GfAiAXxrXpqTQQpEnalf0lNCokH/DrrGS9aK66tCoflx7t05OBCy3boA1QnsTO2zXgmsCgRz+r3O0zIz26zgHYMwq+3A3FOM9HoKYxmJ2/BvoaqomsdCSENYp3QgWIHxcqXc9PJGGgWvnLqJwmHkjMitjNV8i8yO9BjyJr3pmxFcnRwa+ZkToxShe1+fcm0sEqKek+76MIfGEnEdqqwYS5bBjsbgfsoF9wNgF21ytvHrw075F6S0NjL1ww3MfGTYrQp x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199021)(38070700005)(8936002)(8676002)(7696005)(41300700001)(478600001)(2906002)(4744005)(83380400001)(26005)(316002)(186003)(86362001)(6506007)(5660300002)(76116006)(33656002)(38100700002)(122000001)(54906003)(9686003)(52536014)(4326008)(53546011)(6916009)(66476007)(71200400001)(66446008)(64756008)(66556008)(66946007)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Wm9ORThPNEYza3dVZ3pvVmJYRTNTK3Bndk1veml2aWtRMVFMWDNiQXdjQW1P?= =?utf-8?B?VnlUQ1o3YUx0MUZzK2U2YVpYZUNDMkZ3aWl6SjRUbEtiSFdWNURhZzZ3Mzh5?= =?utf-8?B?LzBGc3hVbUVaVFpjV0FjMU16Z1ljZ0JzYnVVenkwODVjejNmR0FSVVlYT3RQ?= =?utf-8?B?TUJjdUsyK0VYNW9yMUFPQzZ2RkF3Snlmc0krMW9UNityVXdvM2sxL25hUU8w?= =?utf-8?B?VU9WSWVVUjFEdmpSeVlNUkhVVWtLajlySXNUZVhvWE4xV0NaeXBHMlpkKytP?= =?utf-8?B?RDFob2ptYUlveS96Vjd0SW9FNExmN2l2dnFkdzg2QVNwYzJ6RHowRGNtRkJX?= =?utf-8?B?V2tmL292M1dYdEplbTEyUXFxYTVIcEZWVjlKdHpIVi9kWkZ2aEhYRWZmNXJD?= =?utf-8?B?cms4VXI1L3UyK0RMazZBT3JBanNaRVNoMlJlaVJEZzdkWS9UTURSQm9jUUpU?= =?utf-8?B?S0pTeTVKT3lHMHVaNTF2NGFhYXd5MWppTEtlZ1FVdGo4VHVyNFhSQnZGT3pl?= =?utf-8?B?VjQ2TlA1ZVZpMSsrYTRaVUxmK2M5OXIvNjdmQXpBTThLWS9EdG1EVVVVQXFx?= =?utf-8?B?SGxFOHZNazh0bEw4cXhBSFhBZENxTk9CRnhMYndXanZRQnlwSGtwTkxGMGpD?= =?utf-8?B?WWc5dUhwcHVpY3dGUHFPdk9VdThERnErVXRERDQ1VEtMYlV4MXQ1RXJMS2x1?= =?utf-8?B?Syt2eXYzVnZxWndCcTBHbjBGWUs0bitYSVlHVDBNQ1NBVkdNQjdJN2pKMGhC?= =?utf-8?B?eWZsLytqc1Y1SHBlZlNRNWZJS2lrTEJzMVFZV2FiUFpaNG5xMkl6QmV6UFZ1?= =?utf-8?B?dW9PQ3ZGeitNUFg5RlhDL1d4R0JBL2MrZ1hTd2hUY3kxcFNDYmZyRW9ZTzYw?= =?utf-8?B?ZXVtM2cwRjNaQVBoekF6QmJVZHdicHNwbmtUYkpXcEFsd3VLVjM1QmozbDM2?= =?utf-8?B?SXd1c3U2cmtVYmpBUk5ZMnRMWDh4cjlzTjl0Ly9GMGt4SGh6Nkllc0VWMzdp?= =?utf-8?B?NWRLek00a3lqL3UyTlVPZW1QUS91RklUUVZpOUErVVpjVnFFL2FFWWgreEx4?= =?utf-8?B?WU5kUC85SHVLWEp6aFp4YlpmWmJPcHZwQ3VPMzEvTllHbXd2cW5Td1EwZXdv?= =?utf-8?B?OEpqaUF1cGVzSnpBT24rMEk0RHhiUnJBQWQxY1RWVFB6VXgybWdHUFVwdDRD?= =?utf-8?B?QU9ZY2l4Sk9oVW02bmxOVGM2SEZUTHBTWThFdEVtRmdCNlpqTC8zR2xPT09x?= =?utf-8?B?LzY5djZMY2FFRlQ4SDJVd05pblNiTTlGL0hvQ0h0TFBNWlFVR2JYTFJESklz?= =?utf-8?B?NU9OQXhtdGlkZWJaL3pnK2R6dW9zcE5YbFZTcnNRTW4vb2cwcklaUDlvRnFM?= =?utf-8?B?NkFYYUFBZmJ4UHgyVExYN2pSeUxKWFB1azlCdG5aNzZ2RFVYRTEyTlpYZ3ZQ?= =?utf-8?B?KzVJWjJWcGhnMW1aZFNBOGhrUHdXTDFBY2Y2bVVQUUQrbXVFY21obUN4SFdO?= =?utf-8?B?eWhuLzNlYzBlSWZGZzhpSk92YWFMdnJFWXFqK09UdlVqaFRiODh2Vmh3MjVG?= =?utf-8?B?NmppbTZoZ0ZJMTVVaXNuTFUzSWR1MStaUUIzeFEra3lRWFBsT3l5a1hCMFdZ?= =?utf-8?B?eUtoNnJvNVo2UjFxb3ZQK3NGTWcyTFRjZU1NenFVNUFQWmpRK0dSaWlRY1Z3?= =?utf-8?B?M2ZrNjB1b3F0bFRpSW1TeHhRMFFhT2V6TTg0VlNtNmNyTlI1UTkxYWZxRlM5?= =?utf-8?B?Y0VkaG9LSXVPTlRhb2trOHpNR2crTVNvVTJRRzJheFltbmxYOHNrYlZaRmFU?= =?utf-8?B?T3E2ODRRTS9nOEFOK3NGRXdpNkp6Ukt1OWdCcFZabzdHQkhheDNnZWx5WlhV?= =?utf-8?B?SW1BTEROWllmMkh2RHJ2ckUrN1NsR3M1cFRlVlF0UmtLaDZ6S2R2aUMzTDI3?= =?utf-8?B?QWFqN3ZpRFdxUXdjSUNhbkdGUEZDR3N4enlhTVJ0Nml5UTVsL1Q1eFl2cU9S?= =?utf-8?B?QmduTHJRL3l4T3FxOW9CZGJwcnQwVjhyN3BJQlNmbjVuV2FUek00bWtleldO?= =?utf-8?B?WERKMWhvM0kwWEpVRTUzZklBbm40OGJacHl0MThUVU5OQWRXSzdRK3dBblZu?= =?utf-8?Q?6N/0=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5edf3944-023a-46e5-086a-08db92639b2a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 07:47:50.5536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0s5nzArrbLjKPyU2lpoG/kwlzbwLbdIIKr5iMRY+00T1kr94U/HwK51yoYJ7KobAXv+PDmXcnpt5GpCjkATzjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10253 KCsgSnVsaWVuLCBTdGVmYW5vLCBCZXJ0cmFuZCkNCg0KSGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjQgMTMvMTNdIHhlbi9hcm06 IG1tdTogZW5hYmxlIFNNTVUgc3Vic3lzdGVtIG9ubHkNCj4gaW4gTU1VDQo+IA0KPiBPbiAwMS4w OC4yMDIzIDA1OjQ0LCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IEZyb206IFBlbm55IFpoZW5nIDxQ ZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiA+DQo+ID4gU01NVSBzdWJzeXN0ZW0gaXMgb25seSBzdXBw b3J0ZWQgaW4gTU1VIHN5c3RlbSwgc28gd2UgbWFrZSBpdA0KPiBkZXBlbmRlbnQNCj4gPiBvbiBD T05GSUdfSEFTX01NVS4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5u eS56aGVuZ0Bhcm0uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBh cm0uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJtLmNv bT4NCj4gDQo+IFdoaWxlIGVudGlyZWx5IEFybS1zcGVjaWZpYywgdGhpcyBsb29rcyB0byByZXF1 aXJlIGEgbm9uLUFybSBhY2s6DQoNCkV4YWN0bHksIHRoZSBkZWZhdWx0ICJDYzoiIGxpc3Qgd2Fz IGZyb20gdGhlIGFkZF9tYWludGFpbmVycy5wbCBhbmQNCkkgbm90aWNlZCB0aGlzIHJpZ2h0IGFm dGVyIHNlbmRpbmcgdGhlIHBhdGNoIG91dC4gSSB3aWxsIGFkZCB0aGUgQXJtDQptYWludGFpbmVy cyBpbiB0aGlzIHJlcGx5IChzb3JyeSBmb3IgdGhlIGluY29udmVuaWVuY2UgY2F1c2VkKS4NCg0K PiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KDQpUaGFuayB5b3Ug dmVyeSBtdWNoIQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Tue Aug 01 07:58:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 07:58:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573758.898752 (Exim 4.92) (envelope-from ) id 1qQkH2-000412-88; Tue, 01 Aug 2023 07:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573758.898752; Tue, 01 Aug 2023 07:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQkH2-00040v-4e; Tue, 01 Aug 2023 07:58:32 +0000 Received: by outflank-mailman (input) for mailman id 573758; Tue, 01 Aug 2023 07:58:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQkH1-00040e-6B for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 07:58:31 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2049.outbound.protection.outlook.com [40.107.7.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3442fbc3-3041-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 09:58:30 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB6880.eurprd04.prod.outlook.com (2603:10a6:803:130::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 07:58:00 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 07:58:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3442fbc3-3041-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LI7WqLMMb8mg9szGvF+oKpeF4EiTTaqWJ5OL6BlBBn17I5mfx9jmHG8LDgKeIw/vostqMprE8uBEJfB8ZtGVkob4Vb/fO9s/Sexd6Qm0yUVpLwxHqpe+e9Gqu7d9dooNtWMOUYYUZfFwJa8zihTipwDzit9JPZwcNtZ4H1brPx0jU33KTtULHjeU7ubGO8hvTUlYjcRp8LSxf9kxDGR0/5/UppeXFkAiTXRmZiRZACgs4uXcYs2MsyopFVX2Y3hXGBsCXlB6Os17ZDinICfZcG5cnvnSKytj3ZHMW5vlOBrfbI5H047t/d2jee3ImU020Wgug8NC7OFxkHH68wNabg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q83MC0lS+nwglxKUKCTEzUMU81glNsr/uTas3Fn5ptw=; b=F9RdP7Ka6CKChoP2b+w2/o3Wc+hI8JJCHM5X3EMOF6eCx4/cExCYG0urdDxjh0vJQsQz/zo+QPaEP0Fzq8gNJMYIhUwywhuW/17gG3vpvvGqkeFYAjnv06ve0ZUjRc43VuDSr0Jh5dxtzo6PPx46rhsVUza9xDUiUPEaKUFEatBEQC+AGaIhvJH2ojEXz3/JnbLqbF7ABg1HBsTcXq+9UpoGL+clTk8VXheLVDY1RhaG0+5ZU7LEqV6cbaLPyDw2A0BpPavbUQ10xiJ9hB731GSc2UAKHGdxryjkHOFBCJtAdYFkjgqJ5nt9gNz4qMlbC+HLyyyrBcuPQLpFZdZeVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q83MC0lS+nwglxKUKCTEzUMU81glNsr/uTas3Fn5ptw=; b=GKiLMYmaidzez8fZsD/cTusU3aARk+P59PzfZbnqb6oYIDctMGhi38+lYl8JsLaYWd+wjQHQe1coqB/TsPa9l9Dnp/U0GPdOs+GAS+GmZy/k2hNvbr0Rjaia7m+9ITUZxGHX3wUSder24KJ9/zt5T98W3pMzFLs0zbDnX7QJGIkqhjj3oxF/87h0/Y/wTECOJDD4TiRVlf2tRpZwVwmz2+2zdeCrX+R6d6/a+RwqRbjloWRYPB/upBu8HRXl/L/nR4hYT9MAgpUX/JpWbYUv3OA6ekAsdmK9wYOvPNeM2QPRuLZtxP4ugBOqbM1hzQujoyP76+Qssg7T9HY9oW5DiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <75a70fa0-ab40-e2b0-685d-db752c943a7d@suse.com> Date: Tue, 1 Aug 2023 09:57:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option Content-Language: en-US To: Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Alejandro Vallejo , Xen-devel References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-6-alejandro.vallejo@cloud.com> <9f0b7ab4-090f-21ea-2cf8-6ecdc7c02225@citrix.com> <3470bc26-3cbc-e0de-53ae-203449493b51@citrix.com> <06a3f79e-4345-7a4b-be57-728a8b01befd@suse.com> <67b5c363-a653-3f5c-ea3a-f52bfac3dc49@citrix.com> From: Jan Beulich In-Reply-To: <67b5c363-a653-3f5c-ea3a-f52bfac3dc49@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB6880:EE_ X-MS-Office365-Filtering-Correlation-Id: 80c770a1-3346-4c5c-950e-08db92650648 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0dGMwX7/usHuxyFDI824vWuTsOjDLc8f2SaW05bU8ffCoAwYDeTIMfZOcFHCaw+T5hjsp8jryo4dSgnKWIE6Ub/cdmvQigAAke1vrcodL2v91k3nYhwLSe/pyzo8fVtpk2mECxm3nKeu7SpP/jKbQ4WSU1A+YYO8Q+CnjUwatVqdvkoVXPIUXcR6OozFOAIQM7Lp1JAryaZ3YTH/VvXH1YeikkfKVauLoLVCKqctlFQ5AMVG3nBL/cceyzGj9A6w3uxjYml2gElbACix9zkhqPUWAoS5b29etC3uKyqHSA2Q3Efk27id7HQWJHLe6lvk1CZdDO3mDRL+kov/pK4pxxltZD2nh/blfgvMxrrnW41O9BST7AzriOe/t4i+SbrvhVS46V9G2NE0vQtYsl1pijdRIc3HrKoS7oqJSOP+11NsdPOLcyyv+n3xQfwlcEKQrIZVVJ3hYqnc8KtA5/nSp3B/dRGR0/zTAdjhTmSGbElkq9TEydeypvgjz6Itm2WVYpO3Kp7xSMg+kuseZKU4alanCuJ0vdsws6m/Ign4ciUfAztPtFzWujq/DtuhnYLjd7gT3NJ90JuX0Zmid9myXnZ0e3SvznqinuhOGWB81ky/mpwveFECBizXQOot+/+YPGbrXjdszzJ9ZJBlneIpzQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199021)(7416002)(38100700002)(66899021)(6506007)(5660300002)(53546011)(4326008)(6916009)(66946007)(66556008)(66476007)(54906003)(6512007)(478600001)(2906002)(2616005)(8936002)(8676002)(6486002)(41300700001)(36756003)(31686004)(31696002)(186003)(316002)(86362001)(6666004)(26005)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2RZdG9RNkVhYVA4VXl5K2p6S1FMR1FTWWI5R0p2d1V2VDdBR1ljMzJHa2Ny?= =?utf-8?B?RW5nR2xmZ0J0NHNCeW5UczQzUUZMYmRQOXM0Z0FBOGM5MDJJVFJRaGVMb1dY?= =?utf-8?B?b2N3MmVNT0RjZEJVVnZNbmpFUjFCUXg2VFErUjltMlNNZDJTRCtueVZaN3FB?= =?utf-8?B?aTFRalYyOWhmalVZTTZnSEdvRmdRc0FRMFlRTVlOQjFkbXhsa3p3UTNncGxv?= =?utf-8?B?cWJsSXo2V2ZZL1NNWnkyQVk2WG92Wk0zalhnTm43UVJnUlFIdWJtNDNVdmJj?= =?utf-8?B?OHRGZnVNQkFrWkVTUGV0bjhXU0psRXJLWDdWMUh3V0dvOVd5amdaN2k3czRy?= =?utf-8?B?aUhiZVVseTFLZXNwVEhHejU2NWJ2NjVRT0pTYlowamJUVzR6NUtHdWhCNjJa?= =?utf-8?B?SHVJeGFUTUV5UHd1SWFrZXllNEYraWprN0xwOWhaN3ZkZWFYWk1nK0hXMTBF?= =?utf-8?B?WXNxSTlqdGpLYnpCZmZUV0tuZjVRQ0ZKWVJNY0VKSWZsRXhaa0M2ZjJtdkt1?= =?utf-8?B?MmJaS1lnL0VTUGY2eWJsRXB2QjBoY3FVYWhqOEVDTFhlWXpzdjU1Z2pHTFFB?= =?utf-8?B?Q0dNVExMNzNadVM5dE5hTExyWWtyNWtvdTNFRHZOd0prUVNwdUlKSDU4Qk1Z?= =?utf-8?B?c1ZKV29mcHZpRTlVdzNpcStKZllyMEg1Z2I1bVB4Vmg4ejNjYUh0dW5QUllk?= =?utf-8?B?bE05NDc4MGE4UlRITEJ5VVFUVXd0eklNcWtXQlhLZnEvQk0xMWU4N21tbndY?= =?utf-8?B?a01WWWpxSERHWEszVFJXNkRuSHJ2L2pDazErZWVtZFFQSkZFQXBwQXZ4VEla?= =?utf-8?B?UW5obzZwSG1haHlRWkdKUytBYUpGV1dJME1jNk90S0hyQUlZQXhCQ0l3WEh0?= =?utf-8?B?N3FEZ2xVL29QSzBhSy92d3orbk1wRXRyaDVOSkVnMEdhWTJmOW44MndZSHJL?= =?utf-8?B?YXh3ZlRXc1lUQmxxTTdpNHN4Vi84MDdJNkx0cHhDL0VMSyszajJzYjZCZGI3?= =?utf-8?B?dVhvcDFIeXpaM2VTUU5DNENkYUFla1pVN3dkdFZ0V2czRDJjT2k4UXlaN1hy?= =?utf-8?B?bm84SUVzeDVteE1LZmFFNEZsZkNPYlF2NXJMaVhlbHExZm4zNHE4aG9TVjVL?= =?utf-8?B?bTIwNDdyTm5BdmdEQ0lJRVh4ZlVUdmxYeldlYTJPQWdwQkVpUytOK3NoKzFM?= =?utf-8?B?MUtwQk14S3UrQStBMG5yTitLOVk5UHBSSU1Vb0ZucTJVUmtUR0l6TzVESGo2?= =?utf-8?B?RXl5enN1SzFTaGZNdk5jQ0hEb0pEWVl6cCt3L3owN2FPU2p2cUswSFRCMGxM?= =?utf-8?B?ek53UVZaNEtiOEJpajhyV1h0QzBNSzZXZmhWOTlFTlIvR0M5MDNSUkd0MHV3?= =?utf-8?B?alRqcXRnN3lTVENSY1BBRjhTcG4yYmxFNFY5aUJ1UUxvZjg3NzhjbC84Vm1R?= =?utf-8?B?MUViaGdtZVdXZDNpQWtCaS9aR0NFNldwTWVQVjVENlNuR2hTQWRMaU93b1pW?= =?utf-8?B?SnRkVVVQSW5oc3N5QWpvaFZBTmNlTThVdlR4ZC9MbTFLNHNiL2lRbnVhUFN3?= =?utf-8?B?QmgvUUVSWXhMQ0VmRm5sNmRWOGovWFNGc3VITkE3aDZlOGorbkxzazJPWFND?= =?utf-8?B?SVBhbVdRWlczb2dpM3ZIbUZHcVlFaGVmc1EzMkZXd3JGMzU4ZktJRDZMSW9q?= =?utf-8?B?T2JMcFBBWW9pOU9LRlAweFBFenRGYWZZUTBlUXdTYmJXRWdDNURXOG0wSlF5?= =?utf-8?B?K2lqSHNVVkpLeXVFNzc2RERua0F4N1dhaWJKRUtSM203RDRxaXhidzdpKzNl?= =?utf-8?B?eE93WEh6RktvY0Y5bm9JWDdmTC9JVGVUalZCN242RFVmNnZNYU9iRkpKNHgz?= =?utf-8?B?Znk3bnBlUE1uMnUyYWJJY3hRY01SR2ppQVY0YUJOSEQ2NWFJR0pFazhCQ3Q1?= =?utf-8?B?RDEvREpCVG1HTHJLSU5uV0FsM3JURVV5NlBpWWVFZjVpZ0YxU25NU2xpOFZ0?= =?utf-8?B?RFBlNnBocFNUa0lWSVE2RUlGM202WmVyd05MbFIyM2N0M1k1dFlzRHlRRTJt?= =?utf-8?B?RUNLNTRTTnlxUWZuU0JQazh2UWkvZk5UUmJVSnFGcEF6azFGTDBKSHJna3lM?= =?utf-8?Q?V8SVP6lpO2aQUPLyJhWi5n2lc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80c770a1-3346-4c5c-950e-08db92650648 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 07:57:59.9072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5q4/nHvGeBKW53UMmot8L6vj27iOZLgdd9bb6DTxsIqXL4qtpDVciKu/HkuWsMdZC+swYEm6jVVF5TRHYIhB6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6880 On 31.07.2023 19:38, Andrew Cooper wrote: > On 31/07/2023 9:00 am, Jan Beulich wrote: >> On 28.07.2023 18:58, Andrew Cooper wrote: >>> On 28/07/2023 5:36 pm, Andrew Cooper wrote: >>>> On 28/07/2023 8:59 am, Alejandro Vallejo wrote: >>>>> Adds a new compile-time flag to allow disabling pdx compression and >>>>> compiles out compression-related code/data. It also shorts the pdx<->pfn >>>>> conversion macros and creates stubs for masking fucntions. >>>>> >>>>> While at it, removes the old arch-defined CONFIG_HAS_PDX flag, as it was >>>>> not removable in practice. >>>>> >>>>> Signed-off-by: Alejandro Vallejo >>>>> --- >>>>> v2: >>>>> * Merged v1/patch2: Removal of CONFIG_HAS_PDX here (Jan) >>>> This series is now looking fine, except for the Kconfig aspect. >>>> >>>> This is not something any user or developer should ever be queried >>>> about.  The feedback on the documentation patches alone show that it's >>>> not understood well by the maintainers, even if the principle is accepted. >>>> >>>> There is never any reason to have this active on x86. >> We can of course continue to disagree here. At least with EXPERT=y >> selecting this option ought to remain possible for x86. Whether or >> not the original systems this scheme was developed for ever went >> public, such systems did (do) exist, and hence running Xen sensibly >> on them (without losing all memory except that on node 0) ought to >> be possible. > > There's one system which never made its way into production, > support-for-which in the no-op case is causing a 10% perf hit in at > least one metric, 17% in another. > > ... and your seriously arguing that we should continue to take this perf > hit? Have I asked anywhere to keep this enabled by default? Have I been the one to first propose a way to reduce this overhead? > It is very likely that said machine(s) aren't even powered on these > days, and even if it is on, the vendor can take the overhead of turning > PDX compression on until such time as they make a production system. > > Furthermore, it is unrealistic to think that such a machine will ever > make its way into production.  Linux has never PDX compression, and > by-and-large if it doesn't run Linux, you can't sell it in the first place. I'm sure you recall that Linux has much more VA space for its directmap, so aiui there simply was no immediate need there. > It is utterly unreasonable to be carrying this overhead in the first > place.  PDX compression *should not* have been committed on-by-default > in the first place.  (Yes, I know there was no Kconfig back then, and > the review process was non-existent, but someone really should have said > no). Are you suggesting no code should be committed supporting new hardware, ahead of that hardware going public? > It is equally unreasonable to offer people (under Expert or not) an > ability to shoot themselves in the foot like this. Shoot themselves in the foot? If you enable EXPERT, you better know what you're doing. >>>   Indeed, Julien's >>>> quick metric shows how much performance we waste by having it enabled. >>> Further to this, bloat-o-meter says net -30k of code and there are >>> plenty of fastpaths getting a several cacheline reduction from this. >> A similar reduction was achieved > > Really?  You think that replacing the innermost shift and masking with > an alternative that has a shorter instruction sequence gets you the same > net reduction in code? > > I do not find that claim credible. Did you ever seriously look at those patches? >> by the BMI2-alt-patching series I >> had put together, yet you weren't willing to come to consensus on >> it. > > You have AMD machines, and your patch was alleged to be a performance > improvement.  So the fact you didn't spot the problems with PEXT/PDEP on > all AMD hardware prior to Fam19h suggests there was insufficient testing > for an alleged performance improvement. > > The patch you posted: > > 1) Added extra complexity via alternatives, and > 2) Reduced performance on AMD systems prior to Fam19h. > > in an area of code which useless on all shipping x86 systems. > > You literally micro-anti-optimised a no-op path to a more expensive (on > one vendor at least) no-op path, claiming it to be a performance > improvement. You appear to forget the patch patching to MOV instructions ("x86: use MOV for PFN/PDX conversion when possible"). Are you saying MOV has performance problems on any CPU? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 08:30:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 08:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573821.898762 (Exim 4.92) (envelope-from ) id 1qQklz-0000cM-AT; Tue, 01 Aug 2023 08:30:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573821.898762; Tue, 01 Aug 2023 08:30:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQklz-0000cF-7S; Tue, 01 Aug 2023 08:30:31 +0000 Received: by outflank-mailman (input) for mailman id 573821; Tue, 01 Aug 2023 08:30:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQklx-0000c4-6S for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 08:30:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQklw-0002Zu-O9; Tue, 01 Aug 2023 08:30:28 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qQklw-00031x-DE; Tue, 01 Aug 2023 08:30:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TqoozpqwtYlI+Cg7N5cwNpfE/d12kuDYjR33SyYgq+M=; b=OK8xo31NTfxJu+T1ynhos4h3Hg V4YJ+Jyjg5yGkFdxdnUN/kY4EZIu7I6xL5kpEYla97zoGYMABCjECYwBlT6ZAuD849R3hp0taM6/X kFKl0Wjhe7c55ZOxdLnHZp5xFNxLkeWKbL4vTwZP8zxKpC0QUaEh3gwzPn8X/bh7Wy1I=; Message-ID: <4f43b069-cb78-f356-628e-29b8ca8e595a@xen.org> Date: Tue, 1 Aug 2023 09:30:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20230801034419.2047541-1-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20230801034419.2047541-1-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 01/08/2023 04:44, Henry Wang wrote: > Based on the discussion in the Xen Summit [1], sending this series out after > addressing the comments in v3 [2] as the preparation work to add MPU support. > > Mostly code movement, with some of Kconfig and build system (mainly Makefiles) > adjustment. No functional change expected. I can't really review this series without knowing how this will integrate with the rest of the MPU work. Can you at least provide a tree with all the patches applied (including the MPU one)? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 08:50:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 08:50:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573831.898772 (Exim 4.92) (envelope-from ) id 1qQl5R-00036m-Ub; Tue, 01 Aug 2023 08:50:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573831.898772; Tue, 01 Aug 2023 08:50:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQl5R-00036f-Ry; Tue, 01 Aug 2023 08:50:37 +0000 Received: by outflank-mailman (input) for mailman id 573831; Tue, 01 Aug 2023 08:50:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQl5Q-00036Z-MG for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 08:50:36 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a5e2ab2-3048-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 10:50:34 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe0d5f719dso8918939e87.2 for ; Tue, 01 Aug 2023 01:50:34 -0700 (PDT) Received: from [192.168.203.100] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id y5-20020a197505000000b004fb738796casm2459971lfe.40.2023.08.01.01.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 01:50:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a5e2ab2-3048-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690879834; x=1691484634; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=euq1qPdtfnAaXo3+i1yckJxd7MWbpEfx+jqJg8HWVv0=; b=ePa6RAL5LAxnlVC1eUbu8IZbvWhzulAtxvVyDHJ0LGmEWS1gbzRAcjZWKnuS0zGPG7 Nd1A3a5UwgVIP0RMYn97Tz7JKhdc8vqcWq4oQKvMz4XDcYpQMrpYs/HmMHdT7OFMipTA EU2CrENjRjAdOEYHElekiGK03MfKFa8zljxj50dWdEE2dHD4b5OMdzC0Ty7ydvU46Y0T HMddIiFIV9au8f8MU7r64qAoZgiF9+RmNWNMC5psj6+Mkj6+0avzZqDCf0ObvsMHgsE1 uGGwYCd7EXhPywwu/lQH6C54wBfU4KMajkbo3kvBeGiJpXmU3rXak+KpX5uYYMJvFXok eiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690879834; x=1691484634; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=euq1qPdtfnAaXo3+i1yckJxd7MWbpEfx+jqJg8HWVv0=; b=foLEKTjH6zgFXYY2rRunswll16nz4Fn+F12hcNC9i+ItmVxBd/eL49axEduz/mZBbF 6LtD3XqJwwosLcAWO7KMaTaKscassKMOP9bYpo8f331z8HLFLO870ucAEU0DyCCULjTG MIZBkX56huhYE9yJcoOmSCCXoGKhXQtBb6SvXGPSk/9Ke/HrKh3battYB0QYwFmUe/fN ZwxWgmVmayAuI7rANBrpujsNwJba7AieMUsWPtqn3L0kG8Uu3zqQwl1UJ52GWdQqYKph 451IclfksYel0htlL2g8/J9MeL79qeuWA69cMCItwTOBwIEKvKSf6URcb5yb4dasBNA0 /mEg== X-Gm-Message-State: ABy/qLb1tp73rFtmuamg1moVao3qZNgRijChuXPHB++QFAV7ZL5vpeFb t9HDZq7kSdXaLDd7kKM5am0= X-Google-Smtp-Source: APBJJlHAlOnZJh6Sprr38MD3TiMWYKeUD4U5eIteWw0pal75KsZsrE+Oy7ZQgaxhlcIalUHITsaOMQ== X-Received: by 2002:a05:6512:b8b:b0:4fe:cc0:348 with SMTP id b11-20020a0565120b8b00b004fe0cc00348mr2130059lfv.66.1690879833536; Tue, 01 Aug 2023 01:50:33 -0700 (PDT) Message-ID: <0bcbcb53db1f0c9ae279347c3f5c762e5324dd15.camel@gmail.com> Subject: Re: [PATCH v5 2/2] xen/riscv: introduce identity mapping From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 01 Aug 2023 11:50:32 +0300 In-Reply-To: <911eba8e-a92b-896c-e5dc-e54dcd570664@suse.com> References: <911eba8e-a92b-896c-e5dc-e54dcd570664@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 T24gTW9uLCAyMDIzLTA3LTMxIGF0IDE2OjA3ICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToKPiBP biAyNy4wNy4yMDIzIDE1OjM4LCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOgo+ID4gLS0tIGEveGVu L2FyY2gvcmlzY3YvcmlzY3Y2NC9oZWFkLlMKPiA+ICsrKyBiL3hlbi9hcmNoL3Jpc2N2L3Jpc2N2 NjQvaGVhZC5TCj4gPiBAQCAtMzksNiArMzksMjMgQEAgRU5UUlkoc3RhcnQpCj4gPiDCoMKgwqDC oMKgwqDCoMKgIGphbMKgwqDCoMKgIGNhbGNfcGh5c19vZmZzZXQKPiA+IMKgwqDCoMKgwqDCoMKg wqAgbXbCoMKgwqDCoMKgIHMyLCBhMAo+ID4gwqAKPiA+ICvCoMKgwqDCoMKgwqDCoCBqYWzCoMKg wqDCoCBzZXR1cF9pbml0aWFsX3BhZ2V0YWJsZXMKPiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCAv KiBDYWxjdWxhdGUgcHJvcGVyIFZBIGFmdGVyIGp1bXAgZnJvbSAxOjEgbWFwcGluZyAqLwo+ID4g K8KgwqDCoMKgwqDCoMKgIGxhwqDCoMKgwqDCoCB0MCwgLkxfcHJpbWFyeV9zd2l0Y2hlZAo+ID4g K8KgwqDCoMKgwqDCoMKgIHN1YsKgwqDCoMKgIHQwLCB0MCwgczIKPiA+ICsKPiA+ICvCoMKgwqDC oMKgwqDCoCBtdsKgwqDCoMKgwqAgYTAsIHQwCj4gPiArwqDCoMKgwqDCoMKgwqAgamFswqDCoMKg wqAgdHVybl9vbl9tbXUKPiAKPiBBbnkgcmVhc29uIHlvdSBkb24ndCBkbyB0aGUgY2FsY3VsYXRp b24gcmlnaHQgaW4gYTA/ClByb2JhYmx5IGl0IHdhcyBiZWZvcmUuIEJ1dCB5b3UgYXJlIHJpZ2h0 IHRoZXJlIGlzIG5vIGFueSBzZW5zZSBpbgp1c2luZyBvZiB0MCBpbiB0aGUgY3VycmVudCBjb2Rl LgpJJ2xsIHVwZGF0ZSB0aGF0LiBUaGFua3MuCgo+IAo+ID4gQEAgLTU0LDMgKzcxLDE4IEBAIEVO VFJZKHJlc2V0X3N0YWNrKQo+ID4gwqAKPiA+IMKgwqDCoMKgwqDCoMKgwqAgcmV0Cj4gPiDCoAo+ ID4gK8KgwqDCoMKgwqDCoMKgIC5zZWN0aW9uIC50ZXh0LmlkZW50LCAiYXgiLCAlcHJvZ2JpdHMK PiA+ICsKPiA+ICtFTlRSWSh0dXJuX29uX21tdSkKPiA+ICvCoMKgwqDCoMKgwqDCoCBzZmVuY2Uu dm1hCj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqAgbGnCoMKgwqDCoMKgIHQwLCBSVl9TVEFHRTFf TU9ERQo+ID4gK8KgwqDCoMKgwqDCoMKgIGxpwqDCoMKgwqDCoCB0MSwgU0FUUF9NT0RFX1NISUZU Cj4gPiArwqDCoMKgwqDCoMKgwqAgc2xswqDCoMKgwqAgdDAsIHQwLCB0MQo+IAo+IENhbid0IHRo ZSBsYXN0IHR3byBiZSBmb2xkZWQgdG8KPiAKPiDCoMKgwqDCoMKgwqDCoCBzbGxpwqDCoMKgwqAg dDAsIHQwLCBTQVRQX01PREVfU0hJRlQKPiAKPiAoSSBkb24ndCByZWNhbGwgd2hhdCBsaSdzIHZh bGlkIHZhbHVlIHJhbmdlIGlzLCBzbyBJJ20gbm90IHN1cmUgaWYKPiAKPiDCoMKgwqDCoMKgwqDC oCBsacKgwqDCoMKgwqAgdDAsIFJWX1NUQUdFMV9NT0RFIDw8IFNBVFBfTU9ERV9TSElGVAo+IAo+ IHdvdWxkIGJlIGFuIG9wdGlvbi4pCkJvdGggb2Ygb3B0aW9ucyB3aWxsIHdvcmsgYnV0IEkgcHJl ZmVyIHRvIHVzZSBTTExJIGFzIExJIGV4cGFuZHMgaW50byBhCnBvdGVudGlhbGx5IGxvbmcgYW5k IGluZWZmaWNpZW50IHNoaWZ0LWFuZC1hZGQgc2VxdWVuY2UgKCBidXQgaW4gdGhpcwpjYXNlIEkg dGhpbmsgdGhpcyBpcyBub3Qgc28gaW1wb3J0YW50ICkuCj4gCj4gRXZlcnl0aGluZyBlbHNlIGxv b2tzIGdvb2QgdG8gbWUgbm93LCBidXQgd2lsbCBvZiBjb3Vyc2Ugd2FudCBhCj4gbWFpbnRhaW5l ciBsb29raW5nIG92ZXIuCldvdWxkIGl0IGJlIGJldHRlciB0byBzZW5kIGEgbmV3IHZlcnNpb24g bm93IG9yIHdhaXQgZm9yIGEgcmVzcG9uc2UKZnJvbSBvdGhlciBtYWludGFpbmVycz8KCn4gT2xl a3NpaQo= From xen-devel-bounces@lists.xenproject.org Tue Aug 01 08:59:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 08:59:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573835.898782 (Exim 4.92) (envelope-from ) id 1qQlDd-0003l7-Pa; Tue, 01 Aug 2023 08:59:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573835.898782; Tue, 01 Aug 2023 08:59:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlDd-0003l0-LX; Tue, 01 Aug 2023 08:59:05 +0000 Received: by outflank-mailman (input) for mailman id 573835; Tue, 01 Aug 2023 08:59:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlDc-0003ku-Pa for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 08:59:04 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9692204-3049-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 10:59:03 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 1A9A44EE0737; Tue, 1 Aug 2023 10:59:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9692204-3049-11ee-b259-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH] x86: mechanically rename to address MISRA C:2012 Rule 5.3 Date: Tue, 1 Aug 2023 10:58:46 +0200 Message-Id: <6c421b903cf11e4dafdb0883e0401ebc2d6cb318.1690880275.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The renames done by this patch avoid shadowing from happening. They are as follows: - s/socket_info/sock_info/ in 'do_write_psr_msrs' The parameter 'cpu_khz' that causes a violation in 'pit_init' is unused, and hence can be removed. Parameter 'debug_stack_lines' in 'compat_show_guest_stack' is removed, since the shadowed static variable has the same purpose. The declaration of 'init_e820' is renamed to be consistent with its definition. Signed-off-by: Nicola Vetrini --- This patch is the non-controversial part of patch 1/4 from series https://lore.kernel.org/xen-devel/cover.1690788513.git.nicola.vetrini@bugseng.com/ The other part has been dealt with with a patch from Jan Beulich (not yet committed at the time of writing) https://lore.kernel.org/xen-devel/e9035197-b329-af2e-65ed-af31cd0375c2@suse.com/ --- xen/arch/x86/domain.c | 2 +- xen/arch/x86/emul-i8254.c | 2 +- xen/arch/x86/include/asm/e820.h | 2 +- xen/arch/x86/include/asm/hvm/vpt.h | 2 +- xen/arch/x86/psr.c | 4 ++-- xen/arch/x86/traps.c | 5 ++--- 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5f66c2ae33..fe86a7f853 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -858,7 +858,7 @@ int arch_domain_create(struct domain *d, } /* PV/PVH guests get an emulated PIT too for video BIOSes to use. */ - pit_init(d, cpu_khz); + pit_init(d); /* * If the FPU does not save FCS/FDS then we can always diff --git a/xen/arch/x86/emul-i8254.c b/xen/arch/x86/emul-i8254.c index a81232fc55..41ec4a1ef1 100644 --- a/xen/arch/x86/emul-i8254.c +++ b/xen/arch/x86/emul-i8254.c @@ -495,7 +495,7 @@ void pit_reset(struct domain *d) spin_unlock(&pit->lock); } -void pit_init(struct domain *d, unsigned long cpu_khz) +void pit_init(struct domain *d) { PITState *pit = domain_vpit(d); diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e820.h index 92f5efa4f5..213d5b5dd2 100644 --- a/xen/arch/x86/include/asm/e820.h +++ b/xen/arch/x86/include/asm/e820.h @@ -31,7 +31,7 @@ extern int e820_change_range_type( uint32_t orig_type, uint32_t new_type); extern int e820_add_range( struct e820map *, uint64_t s, uint64_t e, uint32_t type); -extern unsigned long init_e820(const char *, struct e820map *); +extern unsigned long init_e820(const char *str, struct e820map *raw); extern void print_e820_memory_map(const struct e820entry *map, unsigned int entries); extern struct e820map e820; diff --git a/xen/arch/x86/include/asm/hvm/vpt.h b/xen/arch/x86/include/asm/hvm/vpt.h index 2af76ca8dc..feb0bf43f1 100644 --- a/xen/arch/x86/include/asm/hvm/vpt.h +++ b/xen/arch/x86/include/asm/hvm/vpt.h @@ -179,7 +179,7 @@ void destroy_periodic_time(struct periodic_time *pt); int pv_pit_handler(int port, int data, int write); void pit_reset(struct domain *d); -void pit_init(struct domain *d, unsigned long cpu_khz); +void pit_init(struct domain *d); void pit_stop_channel0_irq(PITState * pit); void pit_deinit(struct domain *d); void rtc_init(struct domain *d); diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c index a1e0af27c5..90bcb25e60 100644 --- a/xen/arch/x86/psr.c +++ b/xen/arch/x86/psr.c @@ -1252,7 +1252,7 @@ static void cf_check do_write_psr_msrs(void *data) { const struct cos_write_info *info = data; unsigned int i, index, cos = info->cos; - const struct psr_socket_info *socket_info = + const struct psr_socket_info *sock_info = get_socket_info(cpu_to_socket(smp_processor_id())); /* @@ -1261,7 +1261,7 @@ static void cf_check do_write_psr_msrs(void *data) */ for ( index = i = 0; i < ARRAY_SIZE(feat_props); i++ ) { - struct feat_node *feat = socket_info->features[i]; + struct feat_node *feat = sock_info->features[i]; const struct feat_props *props = feat_props[i]; unsigned int cos_num, j; diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 4229bda159..f11239fd0f 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -195,8 +195,7 @@ void show_code(const struct cpu_user_regs *regs) } static void compat_show_guest_stack(struct vcpu *v, - const struct cpu_user_regs *regs, - int debug_stack_lines) + const struct cpu_user_regs *regs) { unsigned int i, *stack, addr, mask = STACK_SIZE; void *stack_page = NULL; @@ -273,7 +272,7 @@ static void show_guest_stack(struct vcpu *v, const struct cpu_user_regs *regs) if ( is_pv_32bit_vcpu(v) ) { - compat_show_guest_stack(v, regs, debug_stack_lines); + compat_show_guest_stack(v, regs); return; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573840.898791 (Exim 4.92) (envelope-from ) id 1qQlGU-0005Cc-5i; Tue, 01 Aug 2023 09:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573840.898791; Tue, 01 Aug 2023 09:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGU-0005CV-2Z; Tue, 01 Aug 2023 09:02:02 +0000 Received: by outflank-mailman (input) for mailman id 573840; Tue, 01 Aug 2023 09:02:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGS-0005CK-2o for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:00 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f56c019-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:01:56 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:51 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:50 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f56c019-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880516; x=1722416516; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=VNTVJuExdWzMgMIJDnYnYchd3KTTE96ZhRNNSfTQvuI=; b=V0Atx1ZdG4ygsgmctKA6aZw0m9r0GIzCL2XUipQr0S14WdV5A9GMwstV //q7UI4Z6Qx/d7j8p6DSl9tSF4MsYOBviV3yL8S+6myO9n/zd1PhtMj9X uWpkWXgQyXlI7nv7DPeFXRrwa9h2UtdNfv/IRBbhstDY1wDJ0+DUsiy5z +R3lL4w60fPweLuyeLZr2oNILu/Kze5OQwlGwy0Wzonxg513nF7FkqbC8 JrOobudFksaYhbkogz62/8iJhRn0PdzDxKwGEJs2U6ZvfM9ZtY4phE+rB xfV7RUpI5NyIpPPIh5XY9Z3bdb3ti5oQTkF83s4eoXSiUR40LBtg5yyLT g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082036" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082036" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216940" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216940" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Date: Tue, 1 Aug 2023 01:32:42 -0700 Message-Id: <20230801083318.8363-1-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Resend because the mail system failed to deliver some messages yesterday. This patch set enables the Intel flexible return and event delivery (FRED) architecture for x86-64. The FRED architecture defines simple new transitions that change privilege level (ring transitions). The FRED architecture was designed with the following goals: 1) Improve overall performance and response time by replacing event delivery through the interrupt descriptor table (IDT event delivery) and event return by the IRET instruction with lower latency transitions. 2) Improve software robustness by ensuring that event delivery establishes the full supervisor context and that event return establishes the full user context. The new transitions defined by the FRED architecture are FRED event delivery and, for returning from events, two FRED return instructions. FRED event delivery can effect a transition from ring 3 to ring 0, but it is used also to deliver events incident to ring 0. One FRED instruction (ERETU) effects a return from ring 0 to ring 3, while the other (ERETS) returns while remaining in ring 0. Collectively, FRED event delivery and the FRED return instructions are FRED transitions. Search for the latest FRED spec in most search engines with this search pattern: site:intel.com FRED (flexible return and event delivery) specification As of now there is no publicly avaiable CPU supporting FRED, thus the Intel Simics® Simulator is used as software development and testing vehicles. And it can be downloaded from: https://www.intel.com/content/www/us/en/developer/articles/tool/simics-simulator.html To enable FRED, the Simics package 8112 QSP-CPU needs to be installed with CPU model configured as: $cpu_comp_class = "x86-experimental-fred" Changes since v8: * Move the FRED initialization patch after all required changes are in place (Thomas Gleixner). * Don't do syscall early out in fred_entry_from_user() before there are proper performance numbers and justifications (Thomas Gleixner). * Add the control exception handler to the FRED exception handler table (Thomas Gleixner). * Introduce a macro sysvec_install() to derive the asm handler name from a C handler, which simplifies the code and avoids an ugly typecast (Thomas Gleixner). * Remove junk code that assumes no local APIC on x86_64 (Thomas Gleixner). * Put IDTENTRY changes in a separate patch (Thomas Gleixner). * Use high-order 48 bits above the lowest 16 bit SS only when FRED is enabled (Thomas Gleixner). * Explain why writing directly to the IA32_KERNEL_GS_BASE MSR is doing the right thing (Thomas Gleixner). * Reword some patch descriptions (Thomas Gleixner). * Add a new macro VMX_DO_FRED_EVENT_IRQOFF for FRED instead of refactoring VMX_DO_EVENT_IRQOFF (Sean Christopherson). * Do NOT use a trampoline, just LEA+PUSH the return RIP, PUSH the error code, and jump to the FRED kernel entry point for NMI or call external_interrupt() for IRQs (Sean Christopherson). * Call external_interrupt() only when FRED is enabled, and convert the non-FRED handling to external_interrupt() after FRED lands (Sean Christopherson). * Use __packed instead of __attribute__((__packed__)) (Borislav Petkov). * Put all comments above the members, like the rest of the file does (Borislav Petkov). * Reflect the FRED spec 5.0 change that ERETS and ERETU add 8 to %rsp before popping the return context from the stack. * Reflect stack frame definition changes from FRED spec 3.0 to 5.0. * Add ENDBR to the FRED_ENTER asm macro after kernel IBT is added to FRED base line in FRED spec 5.0. * Add a document which briefly introduces FRED features. * Remove 2 patches, "allow FRED systems to use interrupt vectors 0x10-0x1f" and "allow dynamic stack frame size", from this patch set, as they are "optimizations" only. * Send 2 patches, "header file for event types" and "do not modify the DPL bits for a null selector", as pre-FRED patches. Changes since v7: * Always call external_interrupt() for VMX IRQ handling on x86_64, thus avoid re-entering the noinstr code. * Create a FRED stack frame when FRED is compiled-in but not enabled, which uses some extra stack space but simplifies the code. * Add a log message when FRED is enabled. Changes since v6: * Add a comment to explain why it is safe to write to a previous FRED stack frame. (Lai Jiangshan). * Export fred_entrypoint_kernel(), required when kvm-intel built as a module. * Reserve a REDZONE for CALL emulation and Align RSP to a 64-byte boundary before pushing a new FRED stack frame. * Replace pt_regs csx flags prefix FRED_CSL_ with FRED_CSX_. Changes since v5: * Initialize system_interrupt_handlers with dispatch_table_spurious_interrupt() instead of NULL to get rid of a branch (Peter Zijlstra). * Disallow #DB inside #MCE for robustness sake (Peter Zijlstra). * Add a comment for FRED stack level settings (Lai Jiangshan). * Move the NMI bit from an invalid stack frame, which caused ERETU to fault, to the fault handler's stack frame, thus to unblock NMI ASAP if NMI is blocked (Lai Jiangshan). * Refactor VMX_DO_EVENT_IRQOFF to handle IRQ/NMI in IRQ/NMI induced VM exits when FRED is enabled (Sean Christopherson). Changes since v4: * Do NOT use the term "injection", which in the KVM context means to reinject an event into the guest (Sean Christopherson). * Add the explanation of why to execute "int $2" to invoke the NMI handler in NMI caused VM exits (Sean Christopherson). * Use cs/ss instead of csx/ssx when initializing the pt_regs structure for calling external_interrupt(), otherwise it breaks i386 build. Changes since v3: * Call external_interrupt() to handle IRQ in IRQ caused VM exits. * Execute "int $2" to handle NMI in NMI caused VM exits. * Rename csl/ssl of the pt_regs structure to csx/ssx (x for extended) (Andrew Cooper). Changes since v2: * Improve comments for changes in arch/x86/include/asm/idtentry.h. Changes since v1: * call irqentry_nmi_{enter,exit}() in both IDT and FRED debug fault kernel handler (Peter Zijlstra). * Initialize a FRED exception handler to fred_bad_event() instead of NULL if no FRED handler defined for an exception vector (Peter Zijlstra). * Push calling irqentry_{enter,exit}() and instrumentation_{begin,end}() down into individual FRED exception handlers, instead of in the dispatch framework (Peter Zijlstra). H. Peter Anvin (Intel) (22): x86/fred: Add Kconfig option for FRED (CONFIG_X86_FRED) x86/fred: Disable FRED support if CONFIG_X86_FRED is disabled x86/cpufeatures: Add the cpu feature bit for FRED x86/opcode: Add ERETU, ERETS instructions to x86-opcode-map x86/objtool: Teach objtool about ERETU and ERETS x86/cpu: Add X86_CR4_FRED macro x86/cpu: Add MSR numbers for FRED configuration x86/fred: Make unions for the cs and ss fields in struct pt_regs x86/fred: Add a new header file for FRED definitions x86/fred: Reserve space for the FRED stack frame x86/fred: Update MSR_IA32_FRED_RSP0 during task switch x86/fred: Let ret_from_fork_asm() jmp to fred_exit_user when FRED is enabled x86/fred: Disallow the swapgs instruction when FRED is enabled x86/fred: No ESPFIX needed when FRED is enabled x86/fred: Allow single-step trap and NMI when starting a new task x86/fred: Add a page fault entry stub for FRED x86/fred: Add a debug fault entry stub for FRED x86/fred: Add a NMI entry stub for FRED x86/traps: Add a system interrupt handler table for system interrupt dispatch x86/traps: Add external_interrupt() to dispatch external interrupts x86/fred: FRED entry/exit and dispatch code x86/fred: FRED initialization code Xin Li (14): Documentation/x86/64: Add documentation for FRED x86/fred: Define a common function type fred_handler x86/fred: Add a machine check entry stub for FRED x86/fred: Add a double fault entry stub for FRED x86/entry: Remove idtentry_sysvec from entry_{32,64}.S x86/idtentry: Incorporate definitions/declarations of the FRED external interrupt handler type x86/traps: Add sysvec_install() to install a system interrupt handler x86/idtentry: Incorporate declaration/definition of the FRED exception handler type x86/fred: Fixup fault on ERETU by jumping to fred_entrypoint_user x86/traps: Export external_interrupt() for handling IRQ in IRQ induced VM exits x86/fred: Export fred_entrypoint_kernel() for handling NMI in NMI induced VM exits KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling x86/syscall: Split IDT syscall setup code into idt_syscall_init() x86/fred: Disable FRED by default in its early stage .../admin-guide/kernel-parameters.txt | 4 + Documentation/arch/x86/x86_64/fred.rst | 102 ++++++++ Documentation/arch/x86/x86_64/index.rst | 1 + arch/x86/Kconfig | 9 + arch/x86/entry/Makefile | 5 +- arch/x86/entry/entry_32.S | 4 - arch/x86/entry/entry_64.S | 14 +- arch/x86/entry/entry_64_fred.S | 58 +++++ arch/x86/entry/entry_fred.c | 220 ++++++++++++++++++ arch/x86/entry/vsyscall/vsyscall_64.c | 2 +- arch/x86/include/asm/asm-prototypes.h | 1 + arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/extable_fixup_types.h | 4 +- arch/x86/include/asm/fred.h | 157 +++++++++++++ arch/x86/include/asm/idtentry.h | 115 ++++++++- arch/x86/include/asm/msr-index.h | 13 +- arch/x86/include/asm/ptrace.h | 57 ++++- arch/x86/include/asm/switch_to.h | 11 +- arch/x86/include/asm/thread_info.h | 12 +- arch/x86/include/asm/traps.h | 23 ++ arch/x86/include/uapi/asm/processor-flags.h | 2 + arch/x86/kernel/Makefile | 1 + arch/x86/kernel/cpu/acrn.c | 5 +- arch/x86/kernel/cpu/common.c | 47 +++- arch/x86/kernel/cpu/mce/core.c | 15 ++ arch/x86/kernel/cpu/mshyperv.c | 16 +- arch/x86/kernel/espfix_64.c | 8 + arch/x86/kernel/fred.c | 67 ++++++ arch/x86/kernel/irqinit.c | 7 +- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/nmi.c | 19 ++ arch/x86/kernel/process_64.c | 31 ++- arch/x86/kernel/traps.c | 153 ++++++++++-- arch/x86/kvm/vmx/vmenter.S | 88 +++++++ arch/x86/kvm/vmx/vmx.c | 19 +- arch/x86/lib/x86-opcode-map.txt | 2 +- arch/x86/mm/extable.c | 79 +++++++ arch/x86/mm/fault.c | 18 +- drivers/xen/events/events_base.c | 3 +- tools/arch/x86/include/asm/cpufeatures.h | 1 + .../arch/x86/include/asm/disabled-features.h | 8 +- tools/arch/x86/include/asm/msr-index.h | 13 +- tools/arch/x86/lib/x86-opcode-map.txt | 2 +- tools/objtool/arch/x86/decode.c | 19 +- 45 files changed, 1348 insertions(+), 98 deletions(-) create mode 100644 Documentation/arch/x86/x86_64/fred.rst create mode 100644 arch/x86/entry/entry_64_fred.S create mode 100644 arch/x86/entry/entry_fred.c create mode 100644 arch/x86/include/asm/fred.h create mode 100644 arch/x86/kernel/fred.c -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573842.898812 (Exim 4.92) (envelope-from ) id 1qQlGV-0005h7-Q3; Tue, 01 Aug 2023 09:02:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573842.898812; Tue, 01 Aug 2023 09:02:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGV-0005gz-Lz; Tue, 01 Aug 2023 09:02:03 +0000 Received: by outflank-mailman (input) for mailman id 573842; Tue, 01 Aug 2023 09:02:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGU-0005CK-8H for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:02 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13ae1b3c-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:01 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:54 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:53 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13ae1b3c-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880521; x=1722416521; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tXI/C++YYSo9nyQMGnRVNwF3YsuprVE9KCho8shF7bg=; b=FBrTccm1qP69TBPG13LdDhfig5WgYaMoIz7PFFbEgJQThQFc0W55BqkV +Uqv041tr72H7Fn9DVl5s/w1uBW0zfEqKpiesD+VUAJ2iPOAm2l8Gvhmw 9LmUR713IrRBFhpQQLqU32CPrNOC2jjPoPc2zMVOwV72cSDyQg/lkKGZx CnbL6kfvSRZr165+Hm29r4LHKcPCafWd32ZCvsUyeNt4cPDReE0DiP4hU Gx+sWuA6jditj7v4tKbWxtyUJxPUiHJlkB4ucfeVMW0N4WksPfsTb0Pe7 VDaG+4Ts3cYD/jsvX9EJcZKBhYjDdtLq+iB1KhtIwSEy/2iaW7Hj+GY+S g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082167" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082167" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216959" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216959" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 04/36] x86/cpufeatures: Add the cpu feature bit for FRED Date: Tue, 1 Aug 2023 01:32:46 -0700 Message-Id: <20230801083318.8363-5-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add the CPU feature bit for FRED. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/cpufeatures.h | 1 + tools/arch/x86/include/asm/cpufeatures.h | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index cb8ca46213be..fd3ddd5c0283 100644 --- a/arch/x86/include/asm/cpufeatures.h +++ b/arch/x86/include/asm/cpufeatures.h @@ -317,6 +317,7 @@ #define X86_FEATURE_FZRM (12*32+10) /* "" Fast zero-length REP MOVSB */ #define X86_FEATURE_FSRS (12*32+11) /* "" Fast short REP STOSB */ #define X86_FEATURE_FSRC (12*32+12) /* "" Fast short REP {CMPSB,SCASB} */ +#define X86_FEATURE_FRED (12*32+17) /* Flexible Return and Event Delivery */ #define X86_FEATURE_LKGS (12*32+18) /* "" Load "kernel" (userspace) GS */ #define X86_FEATURE_AMX_FP16 (12*32+21) /* "" AMX fp16 Support */ #define X86_FEATURE_AVX_IFMA (12*32+23) /* "" Support for VPMADD52[H,L]UQ */ diff --git a/tools/arch/x86/include/asm/cpufeatures.h b/tools/arch/x86/include/asm/cpufeatures.h index cb8ca46213be..fd3ddd5c0283 100644 --- a/tools/arch/x86/include/asm/cpufeatures.h +++ b/tools/arch/x86/include/asm/cpufeatures.h @@ -317,6 +317,7 @@ #define X86_FEATURE_FZRM (12*32+10) /* "" Fast zero-length REP MOVSB */ #define X86_FEATURE_FSRS (12*32+11) /* "" Fast short REP STOSB */ #define X86_FEATURE_FSRC (12*32+12) /* "" Fast short REP {CMPSB,SCASB} */ +#define X86_FEATURE_FRED (12*32+17) /* Flexible Return and Event Delivery */ #define X86_FEATURE_LKGS (12*32+18) /* "" Load "kernel" (userspace) GS */ #define X86_FEATURE_AMX_FP16 (12*32+21) /* "" AMX fp16 Support */ #define X86_FEATURE_AVX_IFMA (12*32+23) /* "" Support for VPMADD52[H,L]UQ */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573841.898797 (Exim 4.92) (envelope-from ) id 1qQlGU-0005Ej-FK; Tue, 01 Aug 2023 09:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573841.898797; Tue, 01 Aug 2023 09:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGU-0005EG-A4; Tue, 01 Aug 2023 09:02:02 +0000 Received: by outflank-mailman (input) for mailman id 573841; Tue, 01 Aug 2023 09:02:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGT-0005CK-25 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:01 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12ee93e4-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:00 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:54 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:53 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12ee93e4-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880520; x=1722416520; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ok7xj4KwdkLOXDJ1J3mT1oirCcERqdhXdoxphTKdFWY=; b=kzkHHiOPQ793eCPVXdayOLHpLd0Hq8rtoqH5q625TYiviubgOukDORmB 6y+gyb4LMmNbUwXsWtagZeh3WYx3+ucB1OfjkYXj93nr4N+hpQ1fmycLS 30vTtDB82BL9sROJX9nj3/q60ITCeSe49fKEHUpg8cvq2RXTjRdeODUuy dn2qIXTb74te+RrDvHWV9oZbs+Ie+yQ/nx1yewVP7orjdAO82//pwVutQ I9lY/zZt12/Xb6haEDOjpr9SUUp674kUPyanxcutUZLBWXKqiEzKNlwun Wr0Ck64ZA5iDl4Z0DiW7rMh+49L8d/K1Z/Xl1JSMLbAbBeaJ5fzoAjFhu Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082135" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082135" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216956" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216956" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 03/36] x86/fred: Disable FRED support if CONFIG_X86_FRED is disabled Date: Tue, 1 Aug 2023 01:32:45 -0700 Message-Id: <20230801083318.8363-4-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add CONFIG_X86_FRED to to make cpu_feature_enabled() work correctly with FRED. Originally-by: Megha Dey Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/disabled-features.h | 8 +++++++- tools/arch/x86/include/asm/disabled-features.h | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h index fafe9be7a6f4..85fd67c67ce1 100644 --- a/arch/x86/include/asm/disabled-features.h +++ b/arch/x86/include/asm/disabled-features.h @@ -105,6 +105,12 @@ # define DISABLE_TDX_GUEST (1 << (X86_FEATURE_TDX_GUEST & 31)) #endif +#ifdef CONFIG_X86_FRED +# define DISABLE_FRED 0 +#else +# define DISABLE_FRED (1 << (X86_FEATURE_FRED & 31)) +#endif + /* * Make sure to add features to the correct mask */ @@ -122,7 +128,7 @@ #define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET| \ DISABLE_CALL_DEPTH_TRACKING) #define DISABLED_MASK12 (DISABLE_LAM) -#define DISABLED_MASK13 0 +#define DISABLED_MASK13 (DISABLE_FRED) #define DISABLED_MASK14 0 #define DISABLED_MASK15 0 #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE|DISABLE_LA57|DISABLE_UMIP| \ diff --git a/tools/arch/x86/include/asm/disabled-features.h b/tools/arch/x86/include/asm/disabled-features.h index fafe9be7a6f4..85fd67c67ce1 100644 --- a/tools/arch/x86/include/asm/disabled-features.h +++ b/tools/arch/x86/include/asm/disabled-features.h @@ -105,6 +105,12 @@ # define DISABLE_TDX_GUEST (1 << (X86_FEATURE_TDX_GUEST & 31)) #endif +#ifdef CONFIG_X86_FRED +# define DISABLE_FRED 0 +#else +# define DISABLE_FRED (1 << (X86_FEATURE_FRED & 31)) +#endif + /* * Make sure to add features to the correct mask */ @@ -122,7 +128,7 @@ #define DISABLED_MASK11 (DISABLE_RETPOLINE|DISABLE_RETHUNK|DISABLE_UNRET| \ DISABLE_CALL_DEPTH_TRACKING) #define DISABLED_MASK12 (DISABLE_LAM) -#define DISABLED_MASK13 0 +#define DISABLED_MASK13 (DISABLE_FRED) #define DISABLED_MASK14 0 #define DISABLED_MASK15 0 #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE|DISABLE_LA57|DISABLE_UMIP| \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573843.898816 (Exim 4.92) (envelope-from ) id 1qQlGW-0005jk-2r; Tue, 01 Aug 2023 09:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573843.898816; Tue, 01 Aug 2023 09:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGV-0005j5-UD; Tue, 01 Aug 2023 09:02:03 +0000 Received: by outflank-mailman (input) for mailman id 573843; Tue, 01 Aug 2023 09:02:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGU-0005E5-In for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:02 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11a990c0-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:01:59 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:53 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:52 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11a990c0-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880519; x=1722416519; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7IEqijDovSKiraXkZB5AveXiayuWDixrga5p5CTJEmM=; b=HChlJijnmkyEoWl4NcgeZmCDexEeCGIj0Lbc7CJlMeJlnhEda+tLbOlm 4DFv5cU03XHoDPt+V2pcXQpsBDeu35hsurp9UgCNAzjygu+Sz3T1icCro 846oZlMVt7Rf7XZqTtcgIwUGR9MaUkwS5+G9m0tTSx4MehpnI2+czS1Uj Jeoilk1bF92jWyHOlFn4j3OkGsSsr20SnXZWcAeKAqI8h94JjuJsqS8S7 NowuDJdfilAgtmgpvrxxRsLjgdMMUC7KbC/eklDaWHGjd5onVnoOb4zv/ Ekc5dG8bcyJgITEn+njarQ7eMkbzuN5MRmwAiMNkb+nFXPYbt6dBhwUqG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082101" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082101" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216951" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216951" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 02/36] x86/fred: Add Kconfig option for FRED (CONFIG_X86_FRED) Date: Tue, 1 Aug 2023 01:32:44 -0700 Message-Id: <20230801083318.8363-3-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add the configuration option CONFIG_X86_FRED to enable FRED. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 7422db409770..700d94cb8330 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -494,6 +494,15 @@ config X86_CPU_RESCTRL Say N if unsure. +config X86_FRED + bool "Flexible Return and Event Delivery" + depends on X86_64 + help + When enabled, try to use Flexible Return and Event Delivery + instead of the legacy SYSCALL/SYSENTER/IDT architecture for + ring transitions and exception/interrupt handling if the + system supports. + if X86_32 config X86_BIGSMP bool "Support for big SMP systems with more than 8 CPUs" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573844.898823 (Exim 4.92) (envelope-from ) id 1qQlGW-0005ob-Eq; Tue, 01 Aug 2023 09:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573844.898823; Tue, 01 Aug 2023 09:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGW-0005m6-6s; Tue, 01 Aug 2023 09:02:04 +0000 Received: by outflank-mailman (input) for mailman id 573844; Tue, 01 Aug 2023 09:02:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGV-0005E5-8R for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:03 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10edf405-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:01:59 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:52 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:51 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10edf405-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880519; x=1722416519; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6FF6EgUyznIqvHXwn5+F1gytlgvayKLTt5Pzm0+v43k=; b=QuNFywc+UMpHpIbFImf6ilSe8NIVmH1wzA3OfKAbyCAgOCnK4yNVgbxP WP3icBVaReSFeX+TcvWMi6+ApwJpI0EG1BB29A1S13ci12RnBilxcwsMl Gac6bI282B8Yv04G9dy0/pFUFAazorgz4Sc/GMKThN2tB7Dyp7sfBpNyB oqCccw6NkiUiizzpXL4dav6CeRulDABlBNihElIfyAKCp9c9Hn9Bc2blw BlYzHetUuPZUefWQevdwTKlJ62iTyydpgQ18veiZi53NE7+NjHClGR5Hw 8fu72evGTMXeaKUWiZFEX29klZ23l1jAWiBYB58cHqOnsDuw1NfY7o2fB g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082066" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082066" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216947" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216947" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 01/36] Documentation/x86/64: Add documentation for FRED Date: Tue, 1 Aug 2023 01:32:43 -0700 Message-Id: <20230801083318.8363-2-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Briefly introduce FRED, its advantages compared to IDT, and its Linux enabling. Signed-off-by: Xin Li --- Documentation/arch/x86/x86_64/fred.rst | 102 ++++++++++++++++++++++++ Documentation/arch/x86/x86_64/index.rst | 1 + 2 files changed, 103 insertions(+) create mode 100644 Documentation/arch/x86/x86_64/fred.rst diff --git a/Documentation/arch/x86/x86_64/fred.rst b/Documentation/arch/x86/x86_64/fred.rst new file mode 100644 index 000000000000..27c980e882ba --- /dev/null +++ b/Documentation/arch/x86/x86_64/fred.rst @@ -0,0 +1,102 @@ +.. SPDX-License-Identifier: GPL-2.0 + +========================================= +Flexible Return and Event Delivery (FRED) +========================================= + +Overview +======== + +The FRED architecture defines simple new transitions that change +privilege level (ring transitions). The FRED architecture was +designed with the following goals: + +1) Improve overall performance and response time by replacing event + delivery through the interrupt descriptor table (IDT event + delivery) and event return by the IRET instruction with lower + latency transitions. + +2) Improve software robustness by ensuring that event delivery + establishes the full supervisor context and that event return + establishes the full user context. + +The new transitions defined by the FRED architecture are FRED event +delivery and, for returning from events, two FRED return instructions. +FRED event delivery can effect a transition from ring 3 to ring 0, but +it is used also to deliver events incident to ring 0. One FRED +instruction (ERETU) effects a return from ring 0 to ring 3, while the +other (ERETS) returns while remaining in ring 0. Collectively, FRED +event delivery and the FRED return instructions are FRED transitions. + +In addition to these transitions, the FRED architecture defines a new +instruction (LKGS) for managing the state of the GS segment register. +The LKGS instruction can be used by 64-bit operating systems that do +not use the new FRED transitions. + +Software based event dispatching +================================ + +FRED operates differently from IDT in terms of event handling. Instead +of directly dispatching an event to its handler based on the event +vector, FRED requires the software to dispatch an event to its handler +based on both the event's type and vector. Therefore, an event +dispatch framework must be implemented to facilitate the +event-to-handler dispatch process. The FRED event dispatch framework +assumes control once an event is delivered, starting from two FRED +entry points, after which several event dispatch tables are introduced +to facilitate the dispatching. + +The first level dispatching is event type based, and two tables need +to be defined, one for ring 3 event dispatching, and the other +for ring 0. + +The second level dispatching is event vector based, and +several tables need to be defined, e.g., an exception handler table +for exception dispatching. + +Full supervisor/user context +============================ + +FRED event delivery atomically save and restore full supervisor/user +context upon event delivery and return. Thus it avoids the problem of +transient states due to %cr2 and/or %dr6, thus it is no longer needed +to handle all the ugly corner cases caused by half baked CPU states. + +FRED allows explicit unblock of NMI with new event return instructions +ERETS/ERETU, avoiding the mess caused by IRET which unconditionally +unblocks NMI, when an exception happens during NMI handling. + +FRED always restores the full value of %rsp, thus ESPFIX is no longer +needed when FRED is enabled. + +LKGS +==== + +LKGS behaves like the MOV to GS instruction except that it loads the +base address into the IA32_KERNEL_GS_BASE MSR instead of the GS +segment’s descriptor cache, which is exactly what Linux kernel does +to load user level GS base. With LKGS, it ends up with avoiding +mucking with kernel GS. + +Because FRED event delivery from ring 3 swaps the value of the GS base +address and that of the IA32_KERNEL_GS_BASE MSR, and ERETU swaps the +value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR, +plus the introduction of LKGS instruction, the SWAPGS instruction is +no longer needed when FRED is enabled, thus is disallowed (#UD). + +Stack levels +============ + +4 stack levels 0~3 are introduced to replace the un-reentrant IST for +handling events. Each stack level could be configured to use a +dedicated stack. + +The current stack level could be unchanged or go higher upon FRED +event delivery. If unchanged, the CPU keeps using the current event +stack. If higher, the CPU switches to a new stack specified by the +stack MSR of the new stack level. + +Only execution of a FRED return instruction ERETU or ERETS could lower +the current stack level, causing the CPU to switch back to the stack +it was on before a previous event delivery. +satck. diff --git a/Documentation/arch/x86/x86_64/index.rst b/Documentation/arch/x86/x86_64/index.rst index a56070fc8e77..ad15e9bd623f 100644 --- a/Documentation/arch/x86/x86_64/index.rst +++ b/Documentation/arch/x86/x86_64/index.rst @@ -15,3 +15,4 @@ x86_64 Support cpu-hotplug-spec machinecheck fsgs + fred -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573845.898828 (Exim 4.92) (envelope-from ) id 1qQlGX-00060d-1v; Tue, 01 Aug 2023 09:02:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573845.898828; Tue, 01 Aug 2023 09:02:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGW-0005yb-RJ; Tue, 01 Aug 2023 09:02:04 +0000 Received: by outflank-mailman (input) for mailman id 573845; Tue, 01 Aug 2023 09:02:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGV-0005CK-HQ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:03 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1464ee31-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:02 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:57 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:56 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1464ee31-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880522; x=1722416522; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ks9fQ3QR6UqRMocjQpLz+yk1iYvQPVTbiFl2BDd8yPg=; b=NAPIbyZIKv5DrR7BPINGcZPR/dmN67i6cSKgYGGqixiyqI+NoGjojH9z PRn9oAvSZiQjd0NJ+OpU36zPManyXRvKv7UBrX4OjenF2fB2uD2TKUdDo 5S5sfQEi1QEwDO78xWuj6ZXGQLgsyla6QRO9+w5Ru12vC8cQvLquTebNK K2E8CL7KG+aiawEm+W21PestMYHBuWuNBITr8IRzqW/50sFEsuszSeLHT /RsjhDHThtV0OLY+LmtWberNvm1JlbVDJyqwVeAjumoqfvs6PeWREF3cb /gOMFkSpuevXgmECORWuq2gpAq97W3LQkpKI36ShhzEZ+XGICazpUeXFz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082268" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082268" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216979" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216979" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 07/36] x86/cpu: Add X86_CR4_FRED macro Date: Tue, 1 Aug 2023 01:32:49 -0700 Message-Id: <20230801083318.8363-8-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add X86_CR4_FRED macro for the FRED bit in %cr4. This bit should be a pinned bit, not to be changed after initialization. CR4 macros are defined in arch/x86/include/uapi/asm/processor-flags.h, which is uapi, and thus cannot depend on CONFIG_X86_64. Using _BITUL() causes build errors on 32 bits, and there is no guarantee that user space applications (e.g. something like Qemu) might not want to use this declaration even when building for i386 or x32. However, %cr4 is a machine word (unsigned long), so to avoid build warnings on 32 bits, explicitly cast the value to unsigned long, truncating upper 32 bits. The other alternative would be to use CONFIG_X86_64 around the definition of cr4_pinned_mask. It is probably not desirable to make cr4_pinned_mask non-const. Another option, which may be preferable, to be honest: explicitly enumerate the CR4 bits which *may* be changed (a whitelist), instead of the ones that may not. That would be a separate, pre-FRED, patch, and would automatically resolve this problem as a side effect. The following flags probably should have been in this set all along, as they are all controls affecting the kernel runtime environment as opposed to user space: X86_CR4_DE, X86_CR4_PAE, X86_CR4_PSE, X86_CR4_MCE, X86_CR4_PGE, X86_CR4_OSFXSR, X86_CR4_OSXMMEXCPT, X86_CR4_LA57, X86_CR4_PCIDE, X86_CR4_LAM_SUP Possibly X86_CR4_VMXE as well, which seems harmless even if KVM is not loaded; X86_CR4_PKE can be fixed as long as the PKE configuration registers are at least initialized to disabled. It is relatively simple to do an audit of which flags are allowed to be modified at runtime and whitelist only those. There is no reason why we should allow bits in CR4 to be toggled by default. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/uapi/asm/processor-flags.h | 2 ++ arch/x86/kernel/cpu/common.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/uapi/asm/processor-flags.h b/arch/x86/include/uapi/asm/processor-flags.h index d898432947ff..ce08c2ca70b5 100644 --- a/arch/x86/include/uapi/asm/processor-flags.h +++ b/arch/x86/include/uapi/asm/processor-flags.h @@ -138,6 +138,8 @@ #define X86_CR4_CET _BITUL(X86_CR4_CET_BIT) #define X86_CR4_LAM_SUP_BIT 28 /* LAM for supervisor pointers */ #define X86_CR4_LAM_SUP _BITUL(X86_CR4_LAM_SUP_BIT) +#define X86_CR4_FRED_BIT 32 /* enable FRED kernel entry */ +#define X86_CR4_FRED _BITULL(X86_CR4_FRED_BIT) /* * x86-64 Task Priority Register, CR8 diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 0ba1067f4e5f..331b06d19f7f 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -402,8 +402,9 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c) /* These bits should not change their value after CPU init is finished. */ static const unsigned long cr4_pinned_mask = - X86_CR4_SMEP | X86_CR4_SMAP | X86_CR4_UMIP | - X86_CR4_FSGSBASE | X86_CR4_CET; + (unsigned long) + (X86_CR4_SMEP | X86_CR4_SMAP | X86_CR4_UMIP | + X86_CR4_FSGSBASE | X86_CR4_CET | X86_CR4_FRED); static DEFINE_STATIC_KEY_FALSE_RO(cr_pinning); static unsigned long cr4_pinned_bits __ro_after_init; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573846.898848 (Exim 4.92) (envelope-from ) id 1qQlGY-0006Wt-HR; Tue, 01 Aug 2023 09:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573846.898848; Tue, 01 Aug 2023 09:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGY-0006Uz-6Q; Tue, 01 Aug 2023 09:02:06 +0000 Received: by outflank-mailman (input) for mailman id 573846; Tue, 01 Aug 2023 09:02:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGW-0005E5-Cy for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:04 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 144f88ca-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:02 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:56 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:55 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 144f88ca-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880522; x=1722416522; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+857ZiZ3kYB9kvyULHXUrCarfExj5Gil+GQ461ib92M=; b=Bhy1h6qqrKd+OmXALsrai/YGgiWTzzDS40jbpoRHJA+m8jg/vgxHjnwL UtnlVosFoAGcw78zS39r3otzyIc2+rbsVTvuxA50kgHjEwAK0JM8vsNsy xiYypTA4w3eXM9cc6WKQggzxhDWhqEXVpMs3Slhec7rlUafQBu8lgfkB2 iq83vVmrqGPjipG0eTaCjlJStOhNTgGCkbYqxhmiM3e1oC7wpjHprlYK4 T+D9zk+Qv0hRB2bRpfom7Lri0sbaeYgr54qYA0fUjOCo0JY5pXRfuHAf/ wUauIm2QfbpIeKAMHdyEbFt0G9sVuLuQiI5j4TerFhKNxBu4SbqwqvATZ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082232" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082232" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216976" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216976" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 06/36] x86/objtool: Teach objtool about ERETU and ERETS Date: Tue, 1 Aug 2023 01:32:48 -0700 Message-Id: <20230801083318.8363-7-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Update the objtool decoder to know about the ERETU and ERETS instructions (type INSN_CONTEXT_SWITCH). Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- tools/objtool/arch/x86/decode.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c index 2e1caabecb18..a486485cff20 100644 --- a/tools/objtool/arch/x86/decode.c +++ b/tools/objtool/arch/x86/decode.c @@ -509,11 +509,20 @@ int arch_decode_instruction(struct objtool_file *file, const struct section *sec if (op2 == 0x01) { - if (modrm == 0xca) - insn->type = INSN_CLAC; - else if (modrm == 0xcb) - insn->type = INSN_STAC; - + switch (insn_last_prefix_id(&ins)) { + case INAT_PFX_REPE: + case INAT_PFX_REPNE: + if (modrm == 0xca) + /* eretu/erets */ + insn->type = INSN_CONTEXT_SWITCH; + break; + default: + if (modrm == 0xca) + insn->type = INSN_CLAC; + else if (modrm == 0xcb) + insn->type = INSN_STAC; + break; + } } else if (op2 >= 0x80 && op2 <= 0x8f) { insn->type = INSN_JUMP_CONDITIONAL; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573847.898852 (Exim 4.92) (envelope-from ) id 1qQlGY-0006dm-SW; Tue, 01 Aug 2023 09:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573847.898852; Tue, 01 Aug 2023 09:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGY-0006bP-MD; Tue, 01 Aug 2023 09:02:06 +0000 Received: by outflank-mailman (input) for mailman id 573847; Tue, 01 Aug 2023 09:02:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGW-0005CK-Rl for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:04 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15299869-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:03 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:58 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:57 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15299869-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880523; x=1722416523; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4BQfFZvfF2FO6NJuqP2rESZLyKeNKRqaVIW2rUp/ej0=; b=DM33ycWPt/lnS/yPJd4VjncxVMg7Sssbbj0SKNg4pQBDR3R+F4utCr2i pEfC9THyeJgNdt0ryuaAYSsXvbwt4NYFXDaDVCvnNGmGD+NwXDAep9W9P JJPn4RauZA7kR7NGFQ4y+eoUgMn5WxlWUwFgLX2E+KqavJcvuLFl7IyFO 7wu92UGJjmlBROjVsFbH1P4VHDq5LfUPS4M8j5JFqbbQ3QRA79zjg398w PYOJjwNc7/VettikkDQ6781Tlc04ZiK5rgAOE5+Haq8q+B8jhC4F7/skq yQrMKOyH+7SIdbaraBm424V6nfZaSjVFL9TfsHXZe8ExVLHIfFpQjU4sy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082298" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082298" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216988" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216988" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 08/36] x86/cpu: Add MSR numbers for FRED configuration Date: Tue, 1 Aug 2023 01:32:50 -0700 Message-Id: <20230801083318.8363-9-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add MSR numbers for the FRED configuration registers. Originally-by: Megha Dey Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/msr-index.h | 13 ++++++++++++- tools/arch/x86/include/asm/msr-index.h | 13 ++++++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h index a00a53e15ab7..111fb76f6dbe 100644 --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -36,8 +36,19 @@ #define EFER_FFXSR (1<<_EFER_FFXSR) #define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) -/* Intel MSRs. Some also available on other CPUs */ +/* FRED MSRs */ +#define MSR_IA32_FRED_RSP0 0x1cc /* Level 0 stack pointer */ +#define MSR_IA32_FRED_RSP1 0x1cd /* Level 1 stack pointer */ +#define MSR_IA32_FRED_RSP2 0x1ce /* Level 2 stack pointer */ +#define MSR_IA32_FRED_RSP3 0x1cf /* Level 3 stack pointer */ +#define MSR_IA32_FRED_STKLVLS 0x1d0 /* Exception stack levels */ +#define MSR_IA32_FRED_SSP0 MSR_IA32_PL0_SSP /* Level 0 shadow stack pointer */ +#define MSR_IA32_FRED_SSP1 0x1d1 /* Level 1 shadow stack pointer */ +#define MSR_IA32_FRED_SSP2 0x1d2 /* Level 2 shadow stack pointer */ +#define MSR_IA32_FRED_SSP3 0x1d3 /* Level 3 shadow stack pointer */ +#define MSR_IA32_FRED_CONFIG 0x1d4 /* Entrypoint and interrupt stack level */ +/* Intel MSRs. Some also available on other CPUs */ #define MSR_TEST_CTRL 0x00000033 #define MSR_TEST_CTRL_SPLIT_LOCK_DETECT_BIT 29 #define MSR_TEST_CTRL_SPLIT_LOCK_DETECT BIT(MSR_TEST_CTRL_SPLIT_LOCK_DETECT_BIT) diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h index 3aedae61af4f..565cade0785a 100644 --- a/tools/arch/x86/include/asm/msr-index.h +++ b/tools/arch/x86/include/asm/msr-index.h @@ -36,8 +36,19 @@ #define EFER_FFXSR (1<<_EFER_FFXSR) #define EFER_AUTOIBRS (1<<_EFER_AUTOIBRS) -/* Intel MSRs. Some also available on other CPUs */ +/* FRED MSRs */ +#define MSR_IA32_FRED_RSP0 0x1cc /* Level 0 stack pointer */ +#define MSR_IA32_FRED_RSP1 0x1cd /* Level 1 stack pointer */ +#define MSR_IA32_FRED_RSP2 0x1ce /* Level 2 stack pointer */ +#define MSR_IA32_FRED_RSP3 0x1cf /* Level 3 stack pointer */ +#define MSR_IA32_FRED_STKLVLS 0x1d0 /* Exception stack levels */ +#define MSR_IA32_FRED_SSP0 MSR_IA32_PL0_SSP /* Level 0 shadow stack pointer */ +#define MSR_IA32_FRED_SSP1 0x1d1 /* Level 1 shadow stack pointer */ +#define MSR_IA32_FRED_SSP2 0x1d2 /* Level 2 shadow stack pointer */ +#define MSR_IA32_FRED_SSP3 0x1d3 /* Level 3 shadow stack pointer */ +#define MSR_IA32_FRED_CONFIG 0x1d4 /* Entrypoint and interrupt stack level */ +/* Intel MSRs. Some also available on other CPUs */ #define MSR_TEST_CTRL 0x00000033 #define MSR_TEST_CTRL_SPLIT_LOCK_DETECT_BIT 29 #define MSR_TEST_CTRL_SPLIT_LOCK_DETECT BIT(MSR_TEST_CTRL_SPLIT_LOCK_DETECT_BIT) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573848.898862 (Exim 4.92) (envelope-from ) id 1qQlGZ-0006r3-LV; Tue, 01 Aug 2023 09:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573848.898862; Tue, 01 Aug 2023 09:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGZ-0006ot-BM; Tue, 01 Aug 2023 09:02:07 +0000 Received: by outflank-mailman (input) for mailman id 573848; Tue, 01 Aug 2023 09:02:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGX-0005E5-8S for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:05 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 144b77da-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:02 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:55 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:54 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 144b77da-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880522; x=1722416522; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F/SemwGNBG6weEZopYj3iIwsf6sy0XGLv5PanieJeUc=; b=PTf1qI/ntclSmq1E2/3athJC4+4Uw8AXodqtZ1ZdAzqdFaR+P44xWfaN NKBFci8grUrleWddGCMdr7nLnVeDndsQmaiQebxXxxW18oOrQpgTLGBiV o7KVaO9UCuhVhD1aaEFrtTNbEAYti3xqOCXHSxzlAekNz96NJBdHVQZkM JIV5HQqjLFrWnLq98+xyULmBkylJwlcdInYiMoVqvDcq7irkjzogvMlAs K23NPVPsatH0RhwsKtcPK5V/OzXnaKB325gasMLMjlPSQBaEY1TtLNA+g yl3lRyLsYKJvBHXWW2nc9PdT3YogRGKI24D1AwZA84Fx2tIC07d9NJuby w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082199" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082199" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216963" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216963" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 05/36] x86/opcode: Add ERETU, ERETS instructions to x86-opcode-map Date: Tue, 1 Aug 2023 01:32:47 -0700 Message-Id: <20230801083318.8363-6-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add instruction opcodes used by FRED ERETU/ERETS to x86-opcode-map. Opcode numbers are per FRED spec v5.0. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/lib/x86-opcode-map.txt | 2 +- tools/arch/x86/lib/x86-opcode-map.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt index 5168ee0360b2..7a269e269dc0 100644 --- a/arch/x86/lib/x86-opcode-map.txt +++ b/arch/x86/lib/x86-opcode-map.txt @@ -1052,7 +1052,7 @@ EndTable GrpTable: Grp7 0: SGDT Ms | VMCALL (001),(11B) | VMLAUNCH (010),(11B) | VMRESUME (011),(11B) | VMXOFF (100),(11B) | PCONFIG (101),(11B) | ENCLV (000),(11B) -1: SIDT Ms | MONITOR (000),(11B) | MWAIT (001),(11B) | CLAC (010),(11B) | STAC (011),(11B) | ENCLS (111),(11B) +1: SIDT Ms | MONITOR (000),(11B) | MWAIT (001),(11B) | CLAC (010),(11B) | STAC (011),(11B) | ENCLS (111),(11B) | ERETU (F3),(010),(11B) | ERETS (F2),(010),(11B) 2: LGDT Ms | XGETBV (000),(11B) | XSETBV (001),(11B) | VMFUNC (100),(11B) | XEND (101)(11B) | XTEST (110)(11B) | ENCLU (111),(11B) 3: LIDT Ms 4: SMSW Mw/Rv diff --git a/tools/arch/x86/lib/x86-opcode-map.txt b/tools/arch/x86/lib/x86-opcode-map.txt index 5168ee0360b2..7a269e269dc0 100644 --- a/tools/arch/x86/lib/x86-opcode-map.txt +++ b/tools/arch/x86/lib/x86-opcode-map.txt @@ -1052,7 +1052,7 @@ EndTable GrpTable: Grp7 0: SGDT Ms | VMCALL (001),(11B) | VMLAUNCH (010),(11B) | VMRESUME (011),(11B) | VMXOFF (100),(11B) | PCONFIG (101),(11B) | ENCLV (000),(11B) -1: SIDT Ms | MONITOR (000),(11B) | MWAIT (001),(11B) | CLAC (010),(11B) | STAC (011),(11B) | ENCLS (111),(11B) +1: SIDT Ms | MONITOR (000),(11B) | MWAIT (001),(11B) | CLAC (010),(11B) | STAC (011),(11B) | ENCLS (111),(11B) | ERETU (F3),(010),(11B) | ERETS (F2),(010),(11B) 2: LGDT Ms | XGETBV (000),(11B) | XSETBV (001),(11B) | VMFUNC (100),(11B) | XEND (101)(11B) | XTEST (110)(11B) | ENCLU (111),(11B) 3: LIDT Ms 4: SMSW Mw/Rv -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573849.898872 (Exim 4.92) (envelope-from ) id 1qQlGa-0007EI-Sw; Tue, 01 Aug 2023 09:02:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573849.898872; Tue, 01 Aug 2023 09:02:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGa-0007CG-JY; Tue, 01 Aug 2023 09:02:08 +0000 Received: by outflank-mailman (input) for mailman id 573849; Tue, 01 Aug 2023 09:02:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGY-0005CK-90 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:06 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15f6f484-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:05 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:01 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:00 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15f6f484-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880525; x=1722416525; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+L7aUhS6u+4qwVp6754zs3SWJDqRpOJYTCoF5qb+V6E=; b=g2sDu022VTc1+4G5uAVLwL6WUnnLArVoJS6blZ8YWHfmg4UC5CF+VD6R t9EXgX2sYMiHjGHcOcEBJ5IQdL5tSnsqMAzdp2MEK65fmoGYPSlgec+dU tVvO4eK7jA2zogEmfy2xt2ZOH412B7AFcFsrUZiAR9kZKCx6iOVP00e4Q QZu2qkwj8hhOjMzc7D2HRbsRp8rFo5GWuaR2ZrDbRmlU8bmPY9uC7nQ3C 7kSzaI3M8jIOof/8k0c0xD2MaHgUaPAiz4Ribm3iIozuc6Y2IFCET+XmV y8b94CM7m3RQ7qrdU6lSZ2Kh6h8qbQ7TmQXbi+EtRElJ1FzbUT+JgWJ5A Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082397" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082397" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217010" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217010" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 11/36] x86/fred: Reserve space for the FRED stack frame Date: Tue, 1 Aug 2023 01:32:53 -0700 Message-Id: <20230801083318.8363-12-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" When using FRED, reserve space at the top of the stack frame, just like i386 does. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/thread_info.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h index d63b02940747..089cab875cba 100644 --- a/arch/x86/include/asm/thread_info.h +++ b/arch/x86/include/asm/thread_info.h @@ -31,7 +31,9 @@ * In vm86 mode, the hardware frame is much longer still, so add 16 * bytes to make room for the real-mode segments. * - * x86_64 has a fixed-length stack frame. + * x86-64 has a fixed-length stack frame, but it depends on whether + * or not FRED is enabled. Future versions of FRED might make this + * dynamic, but for now it is always 2 words longer. */ #ifdef CONFIG_X86_32 # ifdef CONFIG_VM86 @@ -39,8 +41,12 @@ # else # define TOP_OF_KERNEL_STACK_PADDING 8 # endif -#else -# define TOP_OF_KERNEL_STACK_PADDING 0 +#else /* x86-64 */ +# ifdef CONFIG_X86_FRED +# define TOP_OF_KERNEL_STACK_PADDING (2*8) +# else +# define TOP_OF_KERNEL_STACK_PADDING 0 +# endif #endif /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573850.898882 (Exim 4.92) (envelope-from ) id 1qQlGb-0007RV-Uu; Tue, 01 Aug 2023 09:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573850.898882; Tue, 01 Aug 2023 09:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGb-0007Ot-Ii; Tue, 01 Aug 2023 09:02:09 +0000 Received: by outflank-mailman (input) for mailman id 573850; Tue, 01 Aug 2023 09:02:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGY-0005E5-Qv for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:06 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15b1e78a-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:04 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:01:59 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:58 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15b1e78a-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880524; x=1722416524; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=f1KjXTBSCMC/3m47AKFmo72XHXtCtx2wNvJSmQVR8WU=; b=fwynLGsd5v2loGYXM4Hft+oFPHnM3/Pv0Zo8P//zk03wXzwWUQZ8emQd 61iNt3mjqBE4PCg93E1wauN6aTcpjLZ6Eehx4EBQyaOA3u5OzUfDLa0/T 69Wx6FzMUwyZVJU3SBhjqBEL6bp6Qj23NGKce7In6DjmZA09U/C39Knhx YAN8w5g5DGimnA5Mo+nZeM/lZ7E4PgZ3AIDFpnZlRWWijLYECFTrsr995 rjOpe0M5YjgjdXc6VZYJfSE6qItSSyRYqzHfPmoubvMgPqt57R+g940nI PsNjMK25Eb0fqTDZWnInDacvGWGcJ77PC6lluPUW8Vf0cieQksFU2ofgN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082330" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082330" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975216994" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975216994" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 09/36] x86/fred: Make unions for the cs and ss fields in struct pt_regs Date: Tue, 1 Aug 2023 01:32:51 -0700 Message-Id: <20230801083318.8363-10-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Make the cs and ss fields in struct pt_regs unions between the actual selector and the unsigned long stack slot. FRED uses this space to store additional flags. The printk changes are simply due to the cs and ss fields changed to unsigned short from unsigned long. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Reflect stack frame definition changes from FRED spec 3.0 to 5.0. * Use __packed instead of __attribute__((__packed__)) (Borislav Petkov). * Put all comments above the members, like the rest of the file does (Borislav Petkov). Changes since v3: * Rename csl/ssl of the pt_regs structure to csx/ssx (x for extended) (Andrew Cooper). --- arch/x86/entry/vsyscall/vsyscall_64.c | 2 +- arch/x86/include/asm/ptrace.h | 57 +++++++++++++++++++++++++-- arch/x86/kernel/process_64.c | 2 +- 3 files changed, 56 insertions(+), 5 deletions(-) diff --git a/arch/x86/entry/vsyscall/vsyscall_64.c b/arch/x86/entry/vsyscall/vsyscall_64.c index e0ca8120aea8..a3c0df11d0e6 100644 --- a/arch/x86/entry/vsyscall/vsyscall_64.c +++ b/arch/x86/entry/vsyscall/vsyscall_64.c @@ -76,7 +76,7 @@ static void warn_bad_vsyscall(const char *level, struct pt_regs *regs, if (!show_unhandled_signals) return; - printk_ratelimited("%s%s[%d] %s ip:%lx cs:%lx sp:%lx ax:%lx si:%lx di:%lx\n", + printk_ratelimited("%s%s[%d] %s ip:%lx cs:%x sp:%lx ax:%lx si:%lx di:%lx\n", level, current->comm, task_pid_nr(current), message, regs->ip, regs->cs, regs->sp, regs->ax, regs->si, regs->di); diff --git a/arch/x86/include/asm/ptrace.h b/arch/x86/include/asm/ptrace.h index f4db78b09c8f..f1690beffd15 100644 --- a/arch/x86/include/asm/ptrace.h +++ b/arch/x86/include/asm/ptrace.h @@ -80,15 +80,66 @@ struct pt_regs { /* * On syscall entry, this is syscall#. On CPU exception, this is error code. * On hw interrupt, it's IRQ number: + * + * A FRED stack frame starts here: + * 1) It _always_ includes an error code; + * 2) The return frame for eretu/erets starts here. */ unsigned long orig_ax; /* Return frame for iretq */ unsigned long ip; - unsigned long cs; + union { +/* CS extended: CS + any fields above it */ + unsigned long csx; + struct { +/* CS selector proper */ + unsigned short cs; +/* The stack level (SL) at the time the event occurred */ + unsigned int sl : 2; +/* Set to indicate that indirect branch tracker in WAIT_FOR_ENDBRANCH state */ + unsigned int wfe : 1; + unsigned int __csx_resv1: 13; + unsigned int __csx_resv2: 32; + } __packed; + }; unsigned long flags; unsigned long sp; - unsigned long ss; -/* top of stack page */ + union { +/* SS extended: SS + any fields above it */ + unsigned long ssx; + struct { +/* SS selector proper */ + unsigned short ss; +/* Set to indicate that interrupt blocking by STI was in effect */ + unsigned int sti : 1; +/* For SYSCALL, SYSENTER, or INT n (for any value of n) */ + unsigned int sys : 1; + unsigned int nmi : 1; + unsigned int __ssx_resv1: 13; +/* Event information fields, ignored by the FRED return instructions */ + unsigned int vector : 8; + unsigned int __ssx_resv2: 8; + unsigned int type : 4; + unsigned int __ssx_resv3: 4; +/* Set to indicate that the event was incident to enclave execution */ + unsigned int enc : 1; +/* Set to indicate that the logical processor had been in 64-bit mode */ + unsigned int l : 1; +/* + * Set to indicate the event is a nested exception encountered during FRED + * event delivery of another event. This bit is not set if the event is + * double fault (#DF). + */ + unsigned int nst : 1; + unsigned int __ssx_resv4: 1; +/* The length of the instruction causing the event */ + unsigned int instr_len : 4; + } __packed; + }; +/* + * Top of stack page on IDT systems, while FRED systems have extra fields + * defined above, see . + */ }; #endif /* !__i386__ */ diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 3d181c16a2f6..265ab8fcb146 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -117,7 +117,7 @@ void __show_regs(struct pt_regs *regs, enum show_regs_mode mode, printk("%sFS: %016lx(%04x) GS:%016lx(%04x) knlGS:%016lx\n", log_lvl, fs, fsindex, gs, gsindex, shadowgs); - printk("%sCS: %04lx DS: %04x ES: %04x CR0: %016lx\n", + printk("%sCS: %04x DS: %04x ES: %04x CR0: %016lx\n", log_lvl, regs->cs, ds, es, cr0); printk("%sCR2: %016lx CR3: %016lx CR4: %016lx\n", log_lvl, cr2, cr3, cr4); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573851.898887 (Exim 4.92) (envelope-from ) id 1qQlGc-0007ZQ-Kr; Tue, 01 Aug 2023 09:02:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573851.898887; Tue, 01 Aug 2023 09:02:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGc-0007Y1-7D; Tue, 01 Aug 2023 09:02:10 +0000 Received: by outflank-mailman (input) for mailman id 573851; Tue, 01 Aug 2023 09:02:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGZ-0005E5-8l for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:07 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15b46ede-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:04 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:00 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:01:59 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15b46ede-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880524; x=1722416524; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2rbYs2KdLMV2D8jndr60eRf402MI8mOow/QviwqPNSc=; b=E2z02fDFeo6ctaAHB+B0QT0QwqeGReNzee59Z0IHF3A8cKtTf5u0xI69 71AXOdDxfQBi0hd9TfEdpnu0ebSSRsUJ3kfDhhTNb/hPn1dMHSNDBPdxV naQnQtbMydYs8oaBRjapOx3ADC7Tu7ISwwJbJQZiXOcijV/sV/1hNTiDr AHpigdlQr+ypSnrJBRE7PskiCocKpP6lRTuYVtsC2pax9aicmpFOXl8tT 1lfDZ/nLyDDwosQlEGWUKpQrqKL/AM/YcNSVNLBXHDS2cemC5kkApNgUK LhHd57NnVOyhKY9Fo1a/Vg7LgLiaZGLw+vXBz6aNMS7lXVALb4fDFSEj1 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082363" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082363" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217001" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217001" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 10/36] x86/fred: Add a new header file for FRED definitions Date: Tue, 1 Aug 2023 01:32:52 -0700 Message-Id: <20230801083318.8363-11-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add a header file for FRED prototypes and definitions. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v6: * Replace pt_regs csx flags prefix FRED_CSL_ with FRED_CSX_. --- arch/x86/include/asm/fred.h | 104 ++++++++++++++++++++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 arch/x86/include/asm/fred.h diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h new file mode 100644 index 000000000000..d76e681a806f --- /dev/null +++ b/arch/x86/include/asm/fred.h @@ -0,0 +1,104 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Macros for Flexible Return and Event Delivery (FRED) + */ + +#ifndef ASM_X86_FRED_H +#define ASM_X86_FRED_H + +#include +#include + +/* + * FRED return instructions + * + * Replace with "ERETS"/"ERETU" once binutils support FRED return instructions. + * The binutils version supporting FRED instructions is still TBD, and will + * update once we have it. + */ +#define ERETS _ASM_BYTES(0xf2,0x0f,0x01,0xca) +#define ERETU _ASM_BYTES(0xf3,0x0f,0x01,0xca) + +/* + * RSP is aligned to a 64-byte boundary before used to push a new stack frame + */ +#define FRED_STACK_FRAME_RSP_MASK _AT(unsigned long, (~0x3f)) + +/* + * Event stack level macro for the FRED_STKLVLS MSR. + * Usage example: FRED_STKLVL(X86_TRAP_DF, 3) + * Multiple values can be ORd together. + */ +#define FRED_STKLVL(v,l) (_AT(unsigned long, l) << (2*(v))) + +/* FRED_CONFIG MSR */ +#define FRED_CONFIG_CSL_MASK 0x3 +/* + * Used for the return address for call emulation during code patching, + * and measured in 64-byte cache lines. + */ +#define FRED_CONFIG_REDZONE_AMOUNT 1 +#define FRED_CONFIG_REDZONE (_AT(unsigned long, FRED_CONFIG_REDZONE_AMOUNT) << 6) +#define FRED_CONFIG_INT_STKLVL(l) (_AT(unsigned long, l) << 9) +#define FRED_CONFIG_ENTRYPOINT(p) _AT(unsigned long, (p)) + +/* + * FRED event type and vector bit width and counts. + * + * There is space in the stack frame making it possible to extend event type + * and vector fields in the future. + */ +#define FRED_EVENT_TYPE_BITS 3 +#define FRED_EVENT_TYPE_COUNT _BITUL(FRED_EVENT_TYPE_BITS) +#define FRED_EVENT_VECTOR_BITS 8 +#define FRED_EVENT_VECTOR_COUNT _BITUL(FRED_EVENT_VECTOR_BITS) + +/* FRED EVENT_TYPE_OTHER vector numbers */ +#define FRED_SYSCALL 1 +#define FRED_SYSENTER 2 +#define FRED_NUM_OTHER_VECTORS 3 + +/* Flags above the SS selector (regs->ssx) */ +#define FRED_SSX_INTERRUPT_SHADOW_BIT 16 +#define FRED_SSX_INTERRUPT_SHADOW _BITUL(FRED_SSX_INTERRUPT_SHADOW_BIT) +#define FRED_SSX_SOFTWARE_INITIATED_BIT 17 +#define FRED_SSX_SOFTWARE_INITIATED _BITUL(FRED_SSX_SOFTWARE_INITIATED_BIT) +#define FRED_SSX_NMI_BIT 18 +#define FRED_SSX_NMI _BITUL(FRED_SSX_NMI_BIT) +#define FRED_SSX_64_BIT_MODE_BIT 57 +#define FRED_SSX_64_BIT_MODE _BITUL(FRED_SSX_64_BIT_MODE_BIT) + +#ifdef CONFIG_X86_FRED + +#ifndef __ASSEMBLY__ + +#include +#include + +struct fred_info { + /* Event data: CR2, DR6, ... */ + unsigned long edata; + unsigned long resv; +}; + +/* Full format of the FRED stack frame */ +struct fred_frame { + struct pt_regs regs; + struct fred_info info; +}; + +static __always_inline struct fred_info *fred_info(struct pt_regs *regs) +{ + return &container_of(regs, struct fred_frame, regs)->info; +} + +static __always_inline unsigned long fred_event_data(struct pt_regs *regs) +{ + return fred_info(regs)->edata; +} + +#endif /* __ASSEMBLY__ */ + +#endif /* CONFIG_X86_FRED */ + +#endif /* ASM_X86_FRED_H */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573852.898897 (Exim 4.92) (envelope-from ) id 1qQlGd-0007nG-J6; Tue, 01 Aug 2023 09:02:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573852.898897; Tue, 01 Aug 2023 09:02:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGd-0007kx-0b; Tue, 01 Aug 2023 09:02:11 +0000 Received: by outflank-mailman (input) for mailman id 573852; Tue, 01 Aug 2023 09:02:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGZ-0005CK-I1 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:07 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16c89ace-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:06 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:02 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:01 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16c89ace-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880526; x=1722416526; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lZsnH9xZ+sSI0HJfWdXFi2jVveN7fME2POBe5mQbKKE=; b=HcVaThGnaKpuSYErS/ovXzFXKxGhluRl0nl7EgI60sqm1S7xY8hWOQQP IAvuhcFnAVm77Qakw9/mHk3ld8+U+VT7TiIPI7Vd/CAPWoF1M9qLdVlbH lRNdtCWWaAh+N112PZJs0pAfEGHtfIwxd2JwXpDKzS+TIOH0/VmC9Yc2M s+3Lw1iVhDgI/gH6/dzavRxxzyAQukD/x5XdJRiI0jFXLeROPCsuuIOR+ idEqYPf8KhcLIb6BEyAi2Hrhj1s6Ol5wiOf10kwlcIKgE9vX9lAntEaug xVWH5Dp+lj6oFn5k8gYmSDD+ubKJaImgPEcKk5XafZOIo1XFlXyN/P6rM w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082432" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082432" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217021" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217021" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 12/36] x86/fred: Update MSR_IA32_FRED_RSP0 during task switch Date: Tue, 1 Aug 2023 01:32:54 -0700 Message-Id: <20230801083318.8363-13-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" MSR_IA32_FRED_RSP0 is used during ring 3 event delivery, and needs to be updated to point to the top of next task stack during task switch. Update MSR_IA32_FRED_RSP0 with WRMSR instruction for now, and will use WRMSRNS/WRMSRLIST for performance once it gets upstreamed. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/switch_to.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/switch_to.h b/arch/x86/include/asm/switch_to.h index f42dbf17f52b..6c911fd400b2 100644 --- a/arch/x86/include/asm/switch_to.h +++ b/arch/x86/include/asm/switch_to.h @@ -70,9 +70,16 @@ static inline void update_task_stack(struct task_struct *task) #ifdef CONFIG_X86_32 this_cpu_write(cpu_tss_rw.x86_tss.sp1, task->thread.sp0); #else - /* Xen PV enters the kernel on the thread stack. */ - if (cpu_feature_enabled(X86_FEATURE_XENPV)) + if (cpu_feature_enabled(X86_FEATURE_FRED)) { + /* + * Will use WRMSRNS/WRMSRLIST for performance once it's upstreamed. + */ + wrmsrl(MSR_IA32_FRED_RSP0, + (unsigned long)task_stack_page(task) + THREAD_SIZE); + } else if (cpu_feature_enabled(X86_FEATURE_XENPV)) { + /* Xen PV enters the kernel on the thread stack. */ load_sp0(task_top_of_stack(task)); + } #endif } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573853.898904 (Exim 4.92) (envelope-from ) id 1qQlGe-00083G-Ns; Tue, 01 Aug 2023 09:02:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573853.898904; Tue, 01 Aug 2023 09:02:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGe-000815-3W; Tue, 01 Aug 2023 09:02:12 +0000 Received: by outflank-mailman (input) for mailman id 573853; Tue, 01 Aug 2023 09:02:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGa-0005CK-Nx for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:08 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 179212f7-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:07 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:05 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:04 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 179212f7-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880528; x=1722416528; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YTgEgmA3f1uzY8PacyZ6XmpZcGIgDW5/dB0vDrivilc=; b=TgQeZ39kiLky/KUf9slRjlh3JhN/R50NF9uxU8aFRVI7EhwXXDttmP91 DWk+xnd0TEyNPJ8K+4I+1ue4PdKo4W2TMbVX2dhbA2MbAdpb1HsADuCux 6ytXq+DinNWZsq8sw/B107qCzv96l55nzmMc4dUEJLrWRDhz1RmS3jWL0 nnBbxZoRPwbYnbhGQxZvRTxLBh4ywjz3iDdOo7jkLP8f5ElcPV0nHrWYl vBIYaYxy2tzyr49bUwOW/PUQFe1IBI7pUWtVc3IYBZtND9s8MVpa/cYMm IYMps2TA1cDrPTiqJaG0L+jiOoipFclehYPUUy4Clmf2iLN6ds9mmNzd9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082536" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082536" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217048" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217048" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 15/36] x86/fred: No ESPFIX needed when FRED is enabled Date: Tue, 1 Aug 2023 01:32:57 -0700 Message-Id: <20230801083318.8363-16-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Because FRED always restores the full value of %rsp, ESPFIX is no longer needed when it's enabled. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/kernel/espfix_64.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/kernel/espfix_64.c b/arch/x86/kernel/espfix_64.c index 16f9814c9be0..48d133a54f45 100644 --- a/arch/x86/kernel/espfix_64.c +++ b/arch/x86/kernel/espfix_64.c @@ -106,6 +106,10 @@ void __init init_espfix_bsp(void) pgd_t *pgd; p4d_t *p4d; + /* FRED systems don't need ESPFIX */ + if (cpu_feature_enabled(X86_FEATURE_FRED)) + return; + /* Install the espfix pud into the kernel page directory */ pgd = &init_top_pgt[pgd_index(ESPFIX_BASE_ADDR)]; p4d = p4d_alloc(&init_mm, pgd, ESPFIX_BASE_ADDR); @@ -129,6 +133,10 @@ void init_espfix_ap(int cpu) void *stack_page; pteval_t ptemask; + /* FRED systems don't need ESPFIX */ + if (cpu_feature_enabled(X86_FEATURE_FRED)) + return; + /* We only have to do this once... */ if (likely(per_cpu(espfix_stack, cpu))) return; /* Already initialized */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573854.898912 (Exim 4.92) (envelope-from ) id 1qQlGf-0008FR-OU; Tue, 01 Aug 2023 09:02:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573854.898912; Tue, 01 Aug 2023 09:02:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGf-0008CQ-09; Tue, 01 Aug 2023 09:02:13 +0000 Received: by outflank-mailman (input) for mailman id 573854; Tue, 01 Aug 2023 09:02:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGb-0005E5-1t for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:09 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 171c33d0-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:07 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:03 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:02 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 171c33d0-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880527; x=1722416527; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=90z+Db4H8sAaozlh1y54siqgX9Yc5fCU6uoHEAi25BE=; b=cgPYb+Vqk/u9DWUMF9emDccm+N33YOPD1cJCE2EKYkXWAcIE27cF1RzL 5Cka8GccwA9hSA1C1jhTQjmbqz3RQF5BG2SstDqQ0E6yCM1PTjm79WNXt t3V3iayFh3gh8WJc3iXfEZCMnX9hBxTO27ekMe4zwguCtxwLGLphxgufe /d8isGqTXrCmjMYAzO7XpUlBhcoYPqGXa8kBuT510d/Jyz+JL/ZSPIomu wZekXFgrfwqfF4+RxK50RXlQ/ntp1nBkAMAjuJn5nm5ARqus0keYtaDF7 JWZrnZTSCIbaFzzSPqBFwcxMHTadJHmpSygUrzw8op3rvCPYRi38NtecD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082467" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082467" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217035" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217035" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 13/36] x86/fred: Let ret_from_fork_asm() jmp to fred_exit_user when FRED is enabled Date: Tue, 1 Aug 2023 01:32:55 -0700 Message-Id: <20230801083318.8363-14-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Let ret_from_fork_asm() jmp to fred_exit_user when FRED is enabled, otherwise the existing IDT code is chosen. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/entry/entry_64.S | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 43606de22511..8069151176f2 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -309,7 +309,13 @@ SYM_CODE_START(ret_from_fork_asm) * and unwind should work normally. */ UNWIND_HINT_REGS + +#ifdef CONFIG_X86_FRED + ALTERNATIVE "jmp swapgs_restore_regs_and_return_to_usermode", \ + "jmp fred_exit_user", X86_FEATURE_FRED +#else jmp swapgs_restore_regs_and_return_to_usermode +#endif SYM_CODE_END(ret_from_fork_asm) .popsection -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573855.898920 (Exim 4.92) (envelope-from ) id 1qQlGg-000063-Rx; Tue, 01 Aug 2023 09:02:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573855.898920; Tue, 01 Aug 2023 09:02:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGg-0008UB-8X; Tue, 01 Aug 2023 09:02:14 +0000 Received: by outflank-mailman (input) for mailman id 573855; Tue, 01 Aug 2023 09:02:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGb-0005E5-AP for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:09 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 174592e4-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:07 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:04 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:03 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 174592e4-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880527; x=1722416527; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=sycVsd87zmfA3yJCdcgOgrxd4mm6nSq5VT1UdIRGngQ=; b=VL88UkAHLPt5w5rRXn4+tKduHpmX3gxKDgGBxNDUF3NyDpRdWssXKK8B Ye014wrThl6ozh7CtprZZQ93xbbefbX7qjrO4qzgYTX3qOSFUKlH+5FAv sX4fAWck/2i67lnrOB6CycLogb6AEVnYPBQP4hEMiG6E1yhiGPUFwdpEJ TNZlgSqz+lbREuE4LoIH7c4XjR9eH1Hx3u6N4ULDvObycnVWIIb6iJPZr zegVnBYPLmE6zdCPVAKJve3gAG5QF4y1OeKY0DwzbIdJs4GAihYQAcrNJ Rpc967nrPl3EXiz9AoFB6vNv2L+BQv7q+gmnHy6iNmcBHSaEYR1aMSG0V Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082503" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082503" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217041" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217041" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 14/36] x86/fred: Disallow the swapgs instruction when FRED is enabled Date: Tue, 1 Aug 2023 01:32:56 -0700 Message-Id: <20230801083318.8363-15-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" The FRED architecture establishes the full supervisor/user through: 1) FRED event delivery from ring 3 swaps the value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR. 2) ERETU swaps the value of the GS base address and that of the IA32_KERNEL_GS_BASE MSR. 3) LKGS is already upstreamed and automatically enabled with FRED to load the GS base address directly into the IA32_KERNEL_GS_BASE MSR instead of the GS segment’s descriptor cache. As a result, there is no need to SWAPGS away from the kernel GS base, i.e., the swapgs instruction is no longer needed when FRED is enabled, thus is disallowed. Otherwise it causes #UD. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Explain why writing directly to the IA32_KERNEL_GS_BASE MSR is doing the right thing (Thomas Gleixner). --- arch/x86/kernel/process_64.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 265ab8fcb146..6d5fed29f552 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -166,7 +166,8 @@ static noinstr unsigned long __rdgsbase_inactive(void) lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); gsbase = rdgsbase(); native_swapgs(); @@ -191,7 +192,8 @@ static noinstr void __wrgsbase_inactive(unsigned long gsbase) { lockdep_assert_irqs_disabled(); - if (!cpu_feature_enabled(X86_FEATURE_XENPV)) { + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + !cpu_feature_enabled(X86_FEATURE_XENPV)) { native_swapgs(); wrgsbase(gsbase); native_swapgs(); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573856.898931 (Exim 4.92) (envelope-from ) id 1qQlGi-0000Qx-WF; Tue, 01 Aug 2023 09:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573856.898931; Tue, 01 Aug 2023 09:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGh-0000KE-JV; Tue, 01 Aug 2023 09:02:15 +0000 Received: by outflank-mailman (input) for mailman id 573856; Tue, 01 Aug 2023 09:02:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGc-0005CK-CJ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:10 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18475fba-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:09 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:06 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:05 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18475fba-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880529; x=1722416529; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=R/F68dINSJ894CWgsWAeNvE3sYeHzSDBLZY+Pavzuys=; b=NiQp2LLPEJBx+Id30oM5Io4k+pFWPqTQHMVFpp0GjQbDmFIjx+oWEznd 0b0kvhttO3MwXyTY8LmLcaKsaWsMmA1VC7kaaLi6xU3Gjuk0RYZGVoVjc i4vQA/f1LH4s4S6jWppxLQ+k5gTXtZs9Q7rsiCM3m/fn17S/0F9fBBv/m aKUv73Wtnmcj05Jl8xfYZyhKa/0i0DSxV6K6e4+u1bm186qVA+xFpkcY+ uXinsKHplsXtbOB0L53CsQnkKzMywYU22y31w2wy/6K7J7mk3ODdnl9Tl +HwI+C6CqAK/VNIX0dJPDuG8lSLoRNfX0iFl4flvXLlZpXwOdbgnES/b4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082570" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082570" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217053" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217053" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 16/36] x86/fred: Allow single-step trap and NMI when starting a new task Date: Tue, 1 Aug 2023 01:32:58 -0700 Message-Id: <20230801083318.8363-17-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Entering a new task is logically speaking a return from a system call (exec, fork, clone, etc.). As such, if ptrace enables single stepping a single step exception should be allowed to trigger immediately upon entering user space. This is not optional. NMI should *never* be disabled in user space. As such, this is an optional, opportunistic way to catch errors. Allow single-step trap and NMI when starting a new task, thus once the new task enters user space, single-step trap and NMI are both enabled immediately. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Use high-order 48 bits above the lowest 16 bit SS only when FRED is enabled (Thomas Gleixner). --- arch/x86/kernel/process_64.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 6d5fed29f552..0b47871a6141 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -56,6 +56,7 @@ #include #include #include +#include #ifdef CONFIG_IA32_EMULATION /* Not included via unistd.h */ #include @@ -507,8 +508,18 @@ void x86_gsbase_write_task(struct task_struct *task, unsigned long gsbase) static void start_thread_common(struct pt_regs *regs, unsigned long new_ip, unsigned long new_sp, - unsigned int _cs, unsigned int _ss, unsigned int _ds) + u16 _cs, u16 _ss, u16 _ds) { + /* + * Paranoia: High-order 48 bits above the lowest 16 bit SS are + * discarded by the legacy IRET instruction on all Intel, AMD, + * and Cyrix/Centaur/VIA CPUs, thus can be set unconditionally, + * even when FRED is not enabled. But we choose the safer side + * to use these bits only when FRED is enabled. + */ + const unsigned long ssx_flags = cpu_feature_enabled(X86_FEATURE_FRED) ? + (FRED_SSX_SOFTWARE_INITIATED | FRED_SSX_NMI) : 0; + WARN_ON_ONCE(regs != current_pt_regs()); if (static_cpu_has(X86_BUG_NULL_SEG)) { @@ -522,11 +533,11 @@ start_thread_common(struct pt_regs *regs, unsigned long new_ip, loadsegment(ds, _ds); load_gs_index(0); - regs->ip = new_ip; - regs->sp = new_sp; - regs->cs = _cs; - regs->ss = _ss; - regs->flags = X86_EFLAGS_IF; + regs->ip = new_ip; + regs->sp = new_sp; + regs->csx = _cs; + regs->ssx = _ss | ssx_flags; + regs->flags = X86_EFLAGS_IF | X86_EFLAGS_FIXED; } void -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573857.898937 (Exim 4.92) (envelope-from ) id 1qQlGk-0000jy-FI; Tue, 01 Aug 2023 09:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573857.898937; Tue, 01 Aug 2023 09:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGj-0000ff-7M; Tue, 01 Aug 2023 09:02:17 +0000 Received: by outflank-mailman (input) for mailman id 573857; Tue, 01 Aug 2023 09:02:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGd-0005E5-FH for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:11 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 187f4a42-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:09 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:07 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:06 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 187f4a42-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880529; x=1722416529; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1h9fTPNcW28O8bu/nclSFH4GxPR5CW0Rl9/PbASKNuY=; b=B/5TJEGb5N9Rz832QXoRF6k0AltwEf+rz1bdXMvotOzbLPZF4cOY1Jz1 8pKtxnJjDs8lHbGjLdxv32BZ17kGlObkUqRAt6UAlsmoLKEoFwfkYhiCl nM7bi0vblRGfRtkmrmfW9A0cHlZ/YD1xXHeFSGwNiwQw836EtvZ2yzjHt OFxN1Y4Nwy+AcVl3R0cnPgFG0NX6fAdiKhBdZ2G+vzCY40nlhyZJWHTiU qdnvKjJFBWtJ5TAJMSZvewiw53a8zBdKhl7UgpdElHtU6VF9NDjNmxa0D r+vLCF12nJphny0QnH1iIq1/GXu3uLxh6MjO/fO/8Vphzio0LfA58nW3H w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082610" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082610" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217056" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217056" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 17/36] x86/fred: Define a common function type fred_handler Date: Tue, 1 Aug 2023 01:32:59 -0700 Message-Id: <20230801083318.8363-18-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FRED event delivery establishes a full supervisor context by saving the essential information about an event to a FRED stack frame, e.g., the faulting linear address of a #PF is saved as event data of a FRED stack frame. Thus a struct pt_regs has all the needed data to handle an event and it's the only input argument of a FRED event handler. Define fred_handler, a common function type used in the FRED event dispatch framework, which makes it easier to find the entry points (via grep), allows the prototype to change if necessary without requiring changing changes everywhere, and makes sure that all the entry points have the proper decorations (currently noinstr, but could change in the future.) Signed-off-by: Xin Li --- arch/x86/include/asm/fred.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index d76e681a806f..b45c1bea5b7f 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -68,6 +68,19 @@ #define FRED_SSX_64_BIT_MODE_BIT 57 #define FRED_SSX_64_BIT_MODE _BITUL(FRED_SSX_64_BIT_MODE_BIT) +/* + * FRED event delivery establishes a full supervisor context by + * saving the essential information about an event to a FRED + * stack frame, e.g., the faulting linear address of a #PF is + * saved as event data of a FRED #PF stack frame. Thus a struct + * pt_regs has all the needed data to handle an event and it's + * the only input argument of a FRED event handler. + * + * FRED handlers need to be placed in the noinstr text section. + */ +#define DECLARE_FRED_HANDLER(f) void f (struct pt_regs *regs) +#define DEFINE_FRED_HANDLER(f) noinstr DECLARE_FRED_HANDLER(f) + #ifdef CONFIG_X86_FRED #ifndef __ASSEMBLY__ @@ -97,6 +110,8 @@ static __always_inline unsigned long fred_event_data(struct pt_regs *regs) return fred_info(regs)->edata; } +typedef DECLARE_FRED_HANDLER((*fred_handler)); + #endif /* __ASSEMBLY__ */ #endif /* CONFIG_X86_FRED */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:02:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573858.898944 (Exim 4.92) (envelope-from ) id 1qQlGl-00016c-PM; Tue, 01 Aug 2023 09:02:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573858.898944; Tue, 01 Aug 2023 09:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGk-0000yW-Ip; Tue, 01 Aug 2023 09:02:18 +0000 Received: by outflank-mailman (input) for mailman id 573858; Tue, 01 Aug 2023 09:02:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGe-0005E5-6k for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:12 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18e3aa30-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:10 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:07 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:06 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18e3aa30-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880530; x=1722416530; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=61pP2ZrTnfM4AWC4LzTY02SWj0Yo4OSnGRh0vm8RTJ0=; b=UyI4LP4ken8e5E3ET9j9+coFJVq6qEtMq38jXkVz9hQ8K5vyVUYjx0b/ J1XBDzDu/xF/UvrpO1V0xWCk6P8frkPc/cTylMJCRRyl+9RyYR+RKhFPP JkLcQ/T8OJ2meaIUhGnUn4OAjLtcISeFU7QWVRfZ16Vp2f6TPPRcmxQES ItoNgQ38cZn7SEnc5PhXeOu1zO6kPUTDbrNRl/dD7GYpr44S5o2zjA6GK rMRYMZVLzxcfgQimCfc1+yf/ylPY9yg1tWiZDt0pkOzUxxLDXNei/K6kq a5UVneo4fVe0yyhf73jVZfoxMCphovbdab8cMgQFZPQuIwsWRQGuYZ5x7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082643" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082643" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217060" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217060" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 18/36] x86/fred: Add a page fault entry stub for FRED Date: Tue, 1 Aug 2023 01:33:00 -0700 Message-Id: <20230801083318.8363-19-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add a page fault entry stub for FRED. On a FRED system, the faulting address (CR2) is passed on the stack, to avoid the problem of transient state. Thus we get the page fault address from the stack instead of CR2. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/fred.h | 2 ++ arch/x86/mm/fault.c | 18 ++++++++++++++++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index b45c1bea5b7f..fb8e7b4f2d38 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -112,6 +112,8 @@ static __always_inline unsigned long fred_event_data(struct pt_regs *regs) typedef DECLARE_FRED_HANDLER((*fred_handler)); +DECLARE_FRED_HANDLER(fred_exc_page_fault); + #endif /* __ASSEMBLY__ */ #endif /* CONFIG_X86_FRED */ diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index e8711b2cafaf..dd3df092d0f2 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c @@ -34,6 +34,7 @@ #include /* kvm_handle_async_pf */ #include /* fixup_vdso_exception() */ #include +#include #define CREATE_TRACE_POINTS #include @@ -1495,9 +1496,10 @@ handle_page_fault(struct pt_regs *regs, unsigned long error_code, } } -DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) +static __always_inline void page_fault_common(struct pt_regs *regs, + unsigned int error_code, + unsigned long address) { - unsigned long address = read_cr2(); irqentry_state_t state; prefetchw(¤t->mm->mmap_lock); @@ -1544,3 +1546,15 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) irqentry_exit(regs, state); } + +DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) +{ + page_fault_common(regs, error_code, read_cr2()); +} + +#ifdef CONFIG_X86_FRED +DEFINE_FRED_HANDLER(fred_exc_page_fault) +{ + page_fault_common(regs, regs->orig_ax, fred_event_data(regs)); +} +#endif -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573861.898991 (Exim 4.92) (envelope-from ) id 1qQlIx-0007aA-Lq; Tue, 01 Aug 2023 09:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573861.898991; Tue, 01 Aug 2023 09:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIx-0007Zx-JE; Tue, 01 Aug 2023 09:04:35 +0000 Received: by outflank-mailman (input) for mailman id 573861; Tue, 01 Aug 2023 09:04:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIw-0007Jn-V5 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:34 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ddb8c0b-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:33 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:29 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:27 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ddb8c0b-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880674; x=1722416674; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Aa5CvA7MmnPHyksJQgqEteFVOvaio1lA17Ke5qS+vL0=; b=ZbDJ0SKnXt8+wU2fjJaPps1juOiC5b4LkUuNS8m4Tq04HWrWXIfGAq7d fkVyEJV/n9iCJHwRZr3DOOVp4p3csR90zalwvsBaM7HDqjKDcJwv7lU9c NOa/8OBNySWoNT/OH4hpGhWZbgYkREUPvII+llIE2ad9xgYMHxHEQK+OQ 8XQtDvXkWWYJeMD+7oZski2F1xSCIaL9D9g3ae6bKLgo533/UJ+9ZxIyS 2gTq5inFzqKlFVtZ1oFzyJdF938VlknzkIKG/RHUzFSXswyIyr0MiNknD vVQ8U8CapKPaNb9DHU4zFH4GlQihnYmwt2F1SCTJ38gKXptO1C7MzCe41 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713490" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713490" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420715" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420715" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 28/36] x86/idtentry: Incorporate declaration/definition of the FRED exception handler type Date: Tue, 1 Aug 2023 01:35:45 -0700 Message-Id: <20230801083553.8468-2-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The existing IDT exception C-handlers of X86_TRAP_TS, X86_TRAP_NP, X86_TRAP_SS, X86_TRAP_GP, X86_TRAP_AC and X86_TRAP_CP take an error code as the second argument, thus their FRED version handlers simply call the corresponding existing IDT handlers with orig_ax from the pt_regs structure as the second argument. Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/idtentry.h | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index e67d111bf932..3b743c3fbe91 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -11,6 +11,7 @@ #include #include +#include #include /** @@ -67,13 +68,16 @@ static __always_inline void __##func(struct pt_regs *regs) /** * DECLARE_IDTENTRY_ERRORCODE - Declare functions for simple IDT entry points + * and their corresponding software based + * dispatch handler * Error code pushed by hardware * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Declares three functions: + * Declares four functions: * - The ASM entry point: asm_##func * - The XEN PV trap entry point: xen_##func (maybe unused) + * - The C handler called from the FRED event dispatch framework * - The C handler called from the ASM entry point * * Same as DECLARE_IDTENTRY, but has an extra error_code argument for the @@ -82,14 +86,19 @@ static __always_inline void __##func(struct pt_regs *regs) #define DECLARE_IDTENTRY_ERRORCODE(vector, func) \ asmlinkage void asm_##func(void); \ asmlinkage void xen_asm_##func(void); \ + __visible DECLARE_FRED_HANDLER(fred_##func); \ __visible void func(struct pt_regs *regs, unsigned long error_code) /** * DEFINE_IDTENTRY_ERRORCODE - Emit code for simple IDT entry points + * and their corresponding software based + * dispatch handler * Error code pushed by hardware * @func: Function name of the entry point * - * Same as DEFINE_IDTENTRY, but has an extra error_code argument + * Same as DEFINE_IDTENTRY, but has an extra error_code argument. The + * fred_func() simply calls func() with passing orig_ax as its second + * argument. */ #define DEFINE_IDTENTRY_ERRORCODE(func) \ static __always_inline void __##func(struct pt_regs *regs, \ @@ -106,6 +115,11 @@ __visible noinstr void func(struct pt_regs *regs, \ irqentry_exit(regs, state); \ } \ \ +__visible DEFINE_FRED_HANDLER(fred_##func) \ +{ \ + func(regs, regs->orig_ax); \ +} \ + \ static __always_inline void __##func(struct pt_regs *regs, \ unsigned long error_code) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573860.898982 (Exim 4.92) (envelope-from ) id 1qQlIv-0007KM-GE; Tue, 01 Aug 2023 09:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573860.898982; Tue, 01 Aug 2023 09:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIv-0007KF-Cr; Tue, 01 Aug 2023 09:04:33 +0000 Received: by outflank-mailman (input) for mailman id 573860; Tue, 01 Aug 2023 09:04:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIu-0007Jn-K5 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:32 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bbce850-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:31 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:27 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:25 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bbce850-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880671; x=1722416671; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=BTa7pFRtc5hN79memTk6tlfkpBhDUr274mj/lMgq9SQ=; b=iwWWZKuu4xbsqr19bzfC8K3WoG9XzEp5B0XQzMT+x6Moxf6XMwjzmLPo HQDk8ALog3LT/kvc3ccUb5YjwwY+JwHKdiP9r+p51KPrBmC6+nKs8Pz6z qCKMTdKOJY8uHVq+J0mCxKzWhlulldZunvU2teOiRymiGzS+KTHHW7ExQ 3yIXqND2VsOje6YfOStFk46C89M0O79/RkRBKKzNF0ZHkTDwOzUKuI4qD O5dDcaE2Guk1wBnCwd/QwnXuLmpY8KunpsJ+DbABie96ee0dkob26UV14 A6JU5FNZlXWy5ameY5eyj2rlhssc9WR+oS/9vmpDc9lQHNh35/njCXRaL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713452" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713452" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420705" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420705" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 27/36] x86/traps: Add external_interrupt() to dispatch external interrupts Date: Tue, 1 Aug 2023 01:35:44 -0700 Message-Id: <20230801083553.8468-1-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" external_interrupt() dispatches all external interrupts: it checks if an external interrupt is a system interrupt, if yes it dipatches it through the system_interrupt_handlers table, otherwise to dispatch_common_interrupt(). Signed-off-by: H. Peter Anvin (Intel) Co-developed-by: Xin Li Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Reword the patch description, which was confusing (Thomas Gleixner). Changes since v5: * Initialize system_interrupt_handlers with dispatch_table_spurious_interrupt() instead of NULL to get rid of a branch (Peter Zijlstra). --- arch/x86/include/asm/traps.h | 2 ++ arch/x86/kernel/traps.c | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/arch/x86/include/asm/traps.h b/arch/x86/include/asm/traps.h index cba3e4dfc329..48daa78ee88c 100644 --- a/arch/x86/include/asm/traps.h +++ b/arch/x86/include/asm/traps.h @@ -66,4 +66,6 @@ static inline void sysvec_setup_fred(unsigned int vector, system_interrupt_handl alloc_intr_gate(vector, asm_##func); \ } +int external_interrupt(struct pt_regs *regs); + #endif /* _ASM_X86_TRAPS_H */ diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 9040c7f01c93..90fdfcccee7a 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -1542,6 +1542,24 @@ void set_sysvec_handler(unsigned int i, system_interrupt_handler func) system_interrupt_handlers[i] = func; } +int external_interrupt(struct pt_regs *regs) +{ + unsigned int vector = regs->vector; + unsigned int sysvec = vector - FIRST_SYSTEM_VECTOR; + + if (unlikely(vector < FIRST_EXTERNAL_VECTOR)) { + pr_err("invalid external interrupt vector %d\n", vector); + return -EINVAL; + } + + if (sysvec < NR_SYSTEM_VECTORS) + system_interrupt_handlers[sysvec](regs); + else + dispatch_common_interrupt(regs, vector); + + return 0; +} + #endif /* CONFIG_X86_64 */ void __init trap_init(void) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573862.899002 (Exim 4.92) (envelope-from ) id 1qQlIz-0007rm-VY; Tue, 01 Aug 2023 09:04:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573862.899002; Tue, 01 Aug 2023 09:04:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIz-0007rX-RM; Tue, 01 Aug 2023 09:04:37 +0000 Received: by outflank-mailman (input) for mailman id 573862; Tue, 01 Aug 2023 09:04:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIy-0007Jn-07 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:36 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d5c006a-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:34 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:30 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:29 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d5c006a-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880674; x=1722416674; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mV4jSKbY2d+wZLYFM+7NRxftfBvXd0NC2fevZMSM55Q=; b=JDNQbvog+RFarXLdldpfUH9JO2BugDHaaiwn7A4PeypqUDKOhjLz2IBz MAa6iZxe5IirGrD7I7/ol/hH4nfLk0TffYp6j+r2zhqNVuJCn6xP1pi/Q wUV92C6cBNj+1w9DG31Zo/NhhdJhI1A6sAZx7rYEuDMXrGIJMss7+oq8D /GWjacpBeSaT+Z9r2UE23sQ/PZqcjaTAOlF497P7kmqQD075sH4w4sRIn XLb1SS5YpmfYA1yrf8uf/pvuf01M/YHK98wiqKDVlCAIFz4RA+vGmG4oD m30aKK/IlYEDgh/E/mLi1u4qHAkiBt8T80xEDkYXAXWzZESEgYPY8HO2I A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713522" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713522" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420725" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420725" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 29/36] x86/fred: FRED entry/exit and dispatch code Date: Tue, 1 Aug 2023 01:35:46 -0700 Message-Id: <20230801083553.8468-3-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" The code to actually handle kernel and event entry/exit using FRED. It is split up into two files thus: - entry_64_fred.S contains the actual entrypoints and exit code, and saves and restores registers. - entry_fred.c contains the two-level event dispatch code for FRED. The first-level dispatch is on the event type, and the second-level is on the event vector. Originally-by: Megha Dey Signed-off-by: H. Peter Anvin (Intel) Co-developed-by: Xin Li Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Don't do syscall early out in fred_entry_from_user() before there are proper performance numbers and justifications (Thomas Gleixner). * Add the control exception handler to the FRED exception handler table (Thomas Gleixner). * Add ENDBR to the FRED_ENTER asm macro. * Reflect the FRED spec 5.0 change that ERETS and ERETU add 8 to %rsp before popping the return context from the stack. Changes since v1: * Initialize a FRED exception handler to fred_bad_event() instead of NULL if no FRED handler defined for an exception vector (Peter Zijlstra). * Push calling irqentry_{enter,exit}() and instrumentation_{begin,end}() down into individual FRED exception handlers, instead of in the dispatch framework (Peter Zijlstra). --- arch/x86/entry/Makefile | 5 +- arch/x86/entry/entry_64_fred.S | 53 +++++++ arch/x86/entry/entry_fred.c | 220 ++++++++++++++++++++++++++ arch/x86/include/asm/asm-prototypes.h | 1 + arch/x86/include/asm/fred.h | 4 + arch/x86/include/asm/idtentry.h | 4 + 6 files changed, 286 insertions(+), 1 deletion(-) create mode 100644 arch/x86/entry/entry_64_fred.S create mode 100644 arch/x86/entry/entry_fred.c diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile index ca2fe186994b..c93e7f5c2a06 100644 --- a/arch/x86/entry/Makefile +++ b/arch/x86/entry/Makefile @@ -18,6 +18,9 @@ obj-y += vdso/ obj-y += vsyscall/ obj-$(CONFIG_PREEMPTION) += thunk_$(BITS).o +CFLAGS_entry_fred.o += -fno-stack-protector +CFLAGS_REMOVE_entry_fred.o += -pg $(CC_FLAGS_FTRACE) +obj-$(CONFIG_X86_FRED) += entry_64_fred.o entry_fred.o + obj-$(CONFIG_IA32_EMULATION) += entry_64_compat.o syscall_32.o obj-$(CONFIG_X86_X32_ABI) += syscall_x32.o - diff --git a/arch/x86/entry/entry_64_fred.S b/arch/x86/entry/entry_64_fred.S new file mode 100644 index 000000000000..4ae12d557db3 --- /dev/null +++ b/arch/x86/entry/entry_64_fred.S @@ -0,0 +1,53 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * The actual FRED entry points. + */ + +#include + +#include "calling.h" + + .code64 + .section ".noinstr.text", "ax" + +.macro FRED_ENTER + UNWIND_HINT_END_OF_STACK + ENDBR + PUSH_AND_CLEAR_REGS + movq %rsp, %rdi /* %rdi -> pt_regs */ +.endm + +.macro FRED_EXIT + UNWIND_HINT_REGS + POP_REGS +.endm + +/* + * The new RIP value that FRED event delivery establishes is + * IA32_FRED_CONFIG & ~FFFH for events that occur in ring 3. + * Thus the FRED ring 3 entry point must be 4K page aligned. + */ + .align 4096 + +SYM_CODE_START_NOALIGN(fred_entrypoint_user) + FRED_ENTER + call fred_entry_from_user +SYM_INNER_LABEL(fred_exit_user, SYM_L_GLOBAL) + FRED_EXIT + ERETU +SYM_CODE_END(fred_entrypoint_user) + +.fill fred_entrypoint_kernel - ., 1, 0xcc + +/* + * The new RIP value that FRED event delivery establishes is + * (IA32_FRED_CONFIG & ~FFFH) + 256 for events that occur in + * ring 0, i.e., fred_entrypoint_user + 256. + */ + .org fred_entrypoint_user+256 +SYM_CODE_START_NOALIGN(fred_entrypoint_kernel) + FRED_ENTER + call fred_entry_from_kernel + FRED_EXIT + ERETS +SYM_CODE_END(fred_entrypoint_kernel) diff --git a/arch/x86/entry/entry_fred.c b/arch/x86/entry/entry_fred.c new file mode 100644 index 000000000000..1688e7e09370 --- /dev/null +++ b/arch/x86/entry/entry_fred.c @@ -0,0 +1,220 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * This contains the dispatch functions called from the entry point + * assembly. + */ + +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +static DEFINE_FRED_HANDLER(fred_bad_event) +{ + irqentry_state_t irq_state = irqentry_nmi_enter(regs); + + instrumentation_begin(); + + /* Panic on events from a high stack level */ + if (regs->sl > 0) { + pr_emerg("PANIC: invalid or fatal FRED event; event type %u " + "vector %u error 0x%lx aux 0x%lx at %04x:%016lx\n", + regs->type, regs->vector, regs->orig_ax, + fred_event_data(regs), regs->cs, regs->ip); + die("invalid or fatal FRED event", regs, regs->orig_ax); + panic("invalid or fatal FRED event"); + } else { + unsigned long flags = oops_begin(); + int sig = SIGKILL; + + pr_alert("BUG: invalid or fatal FRED event; event type %u " + "vector %u error 0x%lx aux 0x%lx at %04x:%016lx\n", + regs->type, regs->vector, regs->orig_ax, + fred_event_data(regs), regs->cs, regs->ip); + + if (__die("Invalid or fatal FRED event", regs, regs->orig_ax)) + sig = 0; + + oops_end(flags, regs, sig); + } + + instrumentation_end(); + irqentry_nmi_exit(regs, irq_state); +} + +static DEFINE_FRED_HANDLER(fred_exception) +{ + /* + * Exceptions that cannot happen on FRED h/w are set to fred_bad_event(). + */ + static const fred_handler exception_handlers[NUM_EXCEPTION_VECTORS] = { + [0 ... NUM_EXCEPTION_VECTORS-1] = fred_bad_event, + + [X86_TRAP_DE] = exc_divide_error, + [X86_TRAP_DB] = fred_exc_debug, + [X86_TRAP_BP] = exc_int3, + [X86_TRAP_OF] = exc_overflow, + [X86_TRAP_BR] = exc_bounds, + [X86_TRAP_UD] = exc_invalid_op, + [X86_TRAP_NM] = exc_device_not_available, + [X86_TRAP_DF] = fred_exc_double_fault, + [X86_TRAP_TS] = fred_exc_invalid_tss, + [X86_TRAP_NP] = fred_exc_segment_not_present, + [X86_TRAP_SS] = fred_exc_stack_segment, + [X86_TRAP_GP] = fred_exc_general_protection, + [X86_TRAP_PF] = fred_exc_page_fault, + [X86_TRAP_MF] = exc_coprocessor_error, + [X86_TRAP_AC] = fred_exc_alignment_check, + [X86_TRAP_MC] = fred_exc_machine_check, + [X86_TRAP_XF] = exc_simd_coprocessor_error, + [X86_TRAP_CP] = fred_exc_control_protection, + }; + + exception_handlers[regs->vector](regs); +} + +static __always_inline void fred_emulate_trap(struct pt_regs *regs) +{ + regs->orig_ax = 0; + fred_exception(regs); +} + +static __always_inline void fred_emulate_fault(struct pt_regs *regs) +{ + regs->ip -= regs->instr_len; + fred_emulate_trap(regs); +} + +static DEFINE_FRED_HANDLER(fred_sw_interrupt_user) +{ + /* + * In compat mode INT $0x80 (32bit system call) is + * performance-critical. Handle it first. + */ + if (IS_ENABLED(CONFIG_IA32_EMULATION) && + likely(regs->vector == IA32_SYSCALL_VECTOR)) { + regs->orig_ax = regs->ax; + regs->ax = -ENOSYS; + return do_int80_syscall_32(regs); + } + + /* + * Some software exceptions can also be triggered as + * int instructions, for historical reasons. + */ + switch (regs->vector) { + case X86_TRAP_BP: + case X86_TRAP_OF: + fred_emulate_trap(regs); + break; + default: + regs->vector = X86_TRAP_GP; + fred_emulate_fault(regs); + break; + } +} + +static DEFINE_FRED_HANDLER(fred_other_default) +{ + regs->vector = X86_TRAP_UD; + fred_emulate_fault(regs); +} + +static DEFINE_FRED_HANDLER(fred_syscall) +{ + regs->orig_ax = regs->ax; + regs->ax = -ENOSYS; + do_syscall_64(regs, regs->orig_ax); +} + +#if IS_ENABLED(CONFIG_IA32_EMULATION) +/* + * Emulate SYSENTER if applicable. This is not the preferred system + * call in 32-bit mode under FRED, rather int $0x80 is preferred and + * exported in the vdso. + */ +static DEFINE_FRED_HANDLER(fred_sysenter) +{ + regs->orig_ax = regs->ax; + regs->ax = -ENOSYS; + do_fast_syscall_32(regs); +} +#else +#define fred_sysenter fred_other_default +#endif + +static DEFINE_FRED_HANDLER(fred_other) +{ + static const fred_handler user_other_handlers[FRED_NUM_OTHER_VECTORS] = + { + /* + * Vector 0 of the other event type is not used + * per FRED spec 5.0. + */ + [0] = fred_other_default, + [FRED_SYSCALL] = fred_syscall, + [FRED_SYSENTER] = fred_sysenter + }; + + user_other_handlers[regs->vector](regs); +} + +static DEFINE_FRED_HANDLER(fred_hw_interrupt) +{ + irqentry_state_t state = irqentry_enter(regs); + + instrumentation_begin(); + external_interrupt(regs); + instrumentation_end(); + irqentry_exit(regs, state); +} + +__visible noinstr void fred_entry_from_user(struct pt_regs *regs) +{ + static const fred_handler user_handlers[FRED_EVENT_TYPE_COUNT] = + { + [EVENT_TYPE_HWINT] = fred_hw_interrupt, + [EVENT_TYPE_RESERVED] = fred_bad_event, + [EVENT_TYPE_NMI] = fred_exc_nmi, + [EVENT_TYPE_SWINT] = fred_sw_interrupt_user, + [EVENT_TYPE_HWFAULT] = fred_exception, + [EVENT_TYPE_SWFAULT] = fred_exception, + [EVENT_TYPE_PRIVSW] = fred_exception, + [EVENT_TYPE_OTHER] = fred_other + }; + + /* + * FRED employs a two-level event dispatch mechanism, with the + * first-level on the type of an event and the second-level on + * its vector. Here is the first-level dispatch for ring 3 events. + */ + user_handlers[regs->type](regs); +} + +__visible noinstr void fred_entry_from_kernel(struct pt_regs *regs) +{ + static const fred_handler kernel_handlers[FRED_EVENT_TYPE_COUNT] = + { + [EVENT_TYPE_HWINT] = fred_hw_interrupt, + [EVENT_TYPE_RESERVED] = fred_bad_event, + [EVENT_TYPE_NMI] = fred_exc_nmi, + [EVENT_TYPE_SWINT] = fred_bad_event, + [EVENT_TYPE_HWFAULT] = fred_exception, + [EVENT_TYPE_SWFAULT] = fred_exception, + [EVENT_TYPE_PRIVSW] = fred_exception, + [EVENT_TYPE_OTHER] = fred_bad_event + }; + + /* + * FRED employs a two-level event dispatch mechanism, with the + * first-level on the type of an event and the second-level on + * its vector. Here is the first-level dispatch for ring 0 events. + */ + kernel_handlers[regs->type](regs); +} diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h index b1a98fa38828..36505b991f88 100644 --- a/arch/x86/include/asm/asm-prototypes.h +++ b/arch/x86/include/asm/asm-prototypes.h @@ -13,6 +13,7 @@ #include #include #include +#include #ifndef CONFIG_X86_CMPXCHG64 extern void cmpxchg8b_emu(void); diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index bd701ac87528..3c91f0eae62e 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -118,6 +118,10 @@ DECLARE_FRED_HANDLER(fred_exc_page_fault); DECLARE_FRED_HANDLER(fred_exc_machine_check); DECLARE_FRED_HANDLER(fred_exc_double_fault); +/* The actual assembly entry point for ring 3 and 0 */ +extern asmlinkage __visible void fred_entrypoint_user(void); +extern asmlinkage __visible void fred_entrypoint_kernel(void); + #endif /* __ASSEMBLY__ */ #endif /* CONFIG_X86_FRED */ diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index 3b743c3fbe91..0df3a3cc7e0f 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -661,6 +661,8 @@ DECLARE_IDTENTRY_RAW(X86_TRAP_MC, exc_machine_check); #ifdef CONFIG_XEN_PV DECLARE_IDTENTRY_RAW(X86_TRAP_MC, xenpv_exc_machine_check); #endif +#else +#define fred_exc_machine_check fred_bad_event #endif /* NMI */ @@ -699,6 +701,8 @@ DECLARE_IDTENTRY_RAW_ERRORCODE(X86_TRAP_DF, xenpv_exc_double_fault); /* #CP */ #ifdef CONFIG_X86_KERNEL_IBT DECLARE_IDTENTRY_ERRORCODE(X86_TRAP_CP, exc_control_protection); +#else +#define fred_exc_control_protection fred_bad_event #endif /* #VC */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573863.899008 (Exim 4.92) (envelope-from ) id 1qQlJ0-0007vq-Bm; Tue, 01 Aug 2023 09:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573863.899008; Tue, 01 Aug 2023 09:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ0-0007v8-6C; Tue, 01 Aug 2023 09:04:38 +0000 Received: by outflank-mailman (input) for mailman id 573863; Tue, 01 Aug 2023 09:04:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlIy-0007Jn-GA for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:36 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f6ef32f-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:35 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:33 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:30 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f6ef32f-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880675; x=1722416675; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U03M3kZ8BDHSBlTSXJIlVDmlKpE5VAGPdolj0bAVLvI=; b=LUmupCWS0eloOvVChYNMDirFvx/zfDWKHJbnDCmG706JyjF8of4Cv1b8 ASM+0q0uc0ipkvQota1gKN32+9MvMMygCtVZJeZbRNMgn8oDXpHned3ec TDmKcto3wV2C1t3WfBrlcIzCKvOCzG5Rp7ZCkxZFCXWKW0jkVON087hL8 ALiOJQxF3b7hffdHy5M8qxhpYS8sBHj2WUcF0ozsIyV1p/qHB7bJTcvp2 nuaVrh29a2jkenyxby6ftN1jOH7GRrcCbutqQBTr469oEZL7tvGDOgwGq Y8FKc1ptNNZ0S5YH/yzA7XLmITizlsWDsNhkwBAEvgb9SIYqGsBY2dthB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713569" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713569" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420732" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420732" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 30/36] x86/fred: Fixup fault on ERETU by jumping to fred_entrypoint_user Date: Tue, 1 Aug 2023 01:35:47 -0700 Message-Id: <20230801083553.8468-4-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the stack frame contains an invalid user context (e.g. due to invalid SS, a non-canonical RIP, etc.) the ERETU instruction will trap (#SS or #GP). >From a Linux point of view, this really should be considered a user space failure, so use the standard fault fixup mechanism to intercept the fault, fix up the exception frame, and redirect execution to fred_entrypoint_user. The end result is that it appears just as if the hardware had taken the exception immediately after completing the transition to user space. Suggested-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Reflect the FRED spec 5.0 change that ERETS and ERETU add 8 to %rsp before popping the return context from the stack. Changes since v6: * Add a comment to explain why it is safe to write to the previous FRED stack frame. (Lai Jiangshan). Changes since v5: * Move the NMI bit from an invalid stack frame, which caused ERETU to fault, to the fault handler's stack frame, thus to unblock NMI ASAP if NMI is blocked (Lai Jiangshan). --- arch/x86/entry/entry_64_fred.S | 5 +- arch/x86/include/asm/extable_fixup_types.h | 4 +- arch/x86/mm/extable.c | 79 ++++++++++++++++++++++ 3 files changed, 86 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_64_fred.S b/arch/x86/entry/entry_64_fred.S index 4ae12d557db3..d24bf7f10ac8 100644 --- a/arch/x86/entry/entry_64_fred.S +++ b/arch/x86/entry/entry_64_fred.S @@ -3,6 +3,7 @@ * The actual FRED entry points. */ +#include #include #include "calling.h" @@ -34,7 +35,9 @@ SYM_CODE_START_NOALIGN(fred_entrypoint_user) call fred_entry_from_user SYM_INNER_LABEL(fred_exit_user, SYM_L_GLOBAL) FRED_EXIT - ERETU +1: ERETU + + _ASM_EXTABLE_TYPE(1b, fred_entrypoint_user, EX_TYPE_ERETU) SYM_CODE_END(fred_entrypoint_user) .fill fred_entrypoint_kernel - ., 1, 0xcc diff --git a/arch/x86/include/asm/extable_fixup_types.h b/arch/x86/include/asm/extable_fixup_types.h index 991e31cfde94..1585c798a02f 100644 --- a/arch/x86/include/asm/extable_fixup_types.h +++ b/arch/x86/include/asm/extable_fixup_types.h @@ -64,6 +64,8 @@ #define EX_TYPE_UCOPY_LEN4 (EX_TYPE_UCOPY_LEN | EX_DATA_IMM(4)) #define EX_TYPE_UCOPY_LEN8 (EX_TYPE_UCOPY_LEN | EX_DATA_IMM(8)) -#define EX_TYPE_ZEROPAD 20 /* longword load with zeropad on fault */ +#define EX_TYPE_ZEROPAD 20 /* longword load with zeropad on fault */ + +#define EX_TYPE_ERETU 21 #endif diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c index 271dcb2deabc..0874f29e85ef 100644 --- a/arch/x86/mm/extable.c +++ b/arch/x86/mm/extable.c @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -223,6 +224,80 @@ static bool ex_handler_ucopy_len(const struct exception_table_entry *fixup, return ex_handler_uaccess(fixup, regs, trapnr, fault_address); } +#ifdef CONFIG_X86_FRED +static bool ex_handler_eretu(const struct exception_table_entry *fixup, + struct pt_regs *regs, unsigned long error_code) +{ + struct pt_regs *uregs = (struct pt_regs *) + (regs->sp - offsetof(struct pt_regs, orig_ax)); + unsigned short ss = uregs->ss; + unsigned short cs = uregs->cs; + + /* + * Move the NMI bit from the invalid stack frame, which caused ERETU + * to fault, to the fault handler's stack frame, thus to unblock NMI + * with the fault handler's ERETS instruction ASAP if NMI is blocked. + */ + regs->nmi = uregs->nmi; + + /* + * Sync event information to uregs, i.e., the ERETU return frame, but + * is it safe to write to the ERETU return frame which is just above + * current event stack frame? + * + * The RSP used by FRED to push a stack frame is not the value in %rsp, + * it is calculated from %rsp with the following 2 steps: + * 1) RSP = %rsp - (IA32_FRED_CONFIG & 0x1c0) // Reserve N*64 bytes + * 2) RSP = RSP & ~0x3f // Align to a 64-byte cache line + * when an event delivery doesn't trigger a stack level change. + * + * Here is an example with N*64 (N=1) bytes reserved: + * + * 64-byte cache line ==> ______________ + * |___Reserved___| + * |__Event_data__| + * |_____SS_______| + * |_____RSP______| + * |_____FLAGS____| + * |_____CS_______| + * |_____IP_______| + * 64-byte cache line ==> |__Error_code__| <== ERETU return frame + * |______________| + * |______________| + * |______________| + * |______________| + * |______________| + * |______________| + * |______________| + * 64-byte cache line ==> |______________| <== RSP after step 1) and 2) + * |___Reserved___| + * |__Event_data__| + * |_____SS_______| + * |_____RSP______| + * |_____FLAGS____| + * |_____CS_______| + * |_____IP_______| + * 64-byte cache line ==> |__Error_code__| <== ERETS return frame + * + * Thus a new FRED stack frame will always be pushed below a previous + * FRED stack frame ((N*64) bytes may be reserved between), and it is + * safe to write to a previous FRED stack frame as they never overlap. + */ + fred_info(uregs)->edata = fred_event_data(regs); + uregs->ssx = regs->ssx; + uregs->ss = ss; + /* The NMI bit was moved away above */ + uregs->nmi = 0; + uregs->csx = regs->csx; + uregs->sl = 0; + uregs->wfe = 0; + uregs->cs = cs; + uregs->orig_ax = error_code; + + return ex_handler_default(fixup, regs); +} +#endif + int ex_get_fixup_type(unsigned long ip) { const struct exception_table_entry *e = search_exception_tables(ip); @@ -300,6 +375,10 @@ int fixup_exception(struct pt_regs *regs, int trapnr, unsigned long error_code, return ex_handler_ucopy_len(e, regs, trapnr, fault_addr, reg, imm); case EX_TYPE_ZEROPAD: return ex_handler_zeropad(e, regs, fault_addr); +#ifdef CONFIG_X86_FRED + case EX_TYPE_ERETU: + return ex_handler_eretu(e, regs, error_code); +#endif } BUG(); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573864.899022 (Exim 4.92) (envelope-from ) id 1qQlJ1-0008PV-Rv; Tue, 01 Aug 2023 09:04:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573864.899022; Tue, 01 Aug 2023 09:04:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ1-0008OW-Nn; Tue, 01 Aug 2023 09:04:39 +0000 Received: by outflank-mailman (input) for mailman id 573864; Tue, 01 Aug 2023 09:04:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ0-0007sM-Ak for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:38 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6df44d94-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:04:36 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:34 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:32 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6df44d94-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880676; x=1722416676; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QJo+FdezOu/7r5CtwRnG6EayDGJs/agjxSi0oClRDik=; b=LJ3fyLruDPs5uYPMxpUokpiz5GD2N0VvPWAkxd1zkcieDy89uuHZ5Utn G1SUgXRYaPZxQkByR4jv6sGpiMJOf14LZJRm8yhLmp9PX+ucPWLx/sr/A 8MkBxGSSdXQDeTOGpiMbSNRqawUBBLLbhOaCo1KAQi9y6GzCphEnIZ6zl WbHqjEyncD8mqNGs48Q3K3paoWSLYD0x2xzX31wXcWXQY7c2xz8f3mnoV KpHKWmaKcCKnk2kb4fX8FQt6Gi/o9u0t+jmBj/a4B8vWgyHDHtyHaD4SX 8kjOojzXY64Ro0VJH4Edyz5EywoqQ8LOf/xSBxeR2a+DZOMmvKo8htMK4 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713612" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713612" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420738" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420738" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 31/36] x86/traps: Export external_interrupt() for handling IRQ in IRQ induced VM exits Date: Tue, 1 Aug 2023 01:35:48 -0700 Message-Id: <20230801083553.8468-5-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Export external_interrupt() for handling IRQ in IRQ induced VM exits. Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/kernel/traps.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 90fdfcccee7a..6143ad56008e 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -1560,6 +1560,11 @@ int external_interrupt(struct pt_regs *regs) return 0; } +#if IS_ENABLED(CONFIG_KVM_INTEL) +/* For KVM VMX to handle IRQs in IRQ induced VM exits. */ +EXPORT_SYMBOL_GPL(external_interrupt); +#endif + #endif /* CONFIG_X86_64 */ void __init trap_init(void) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573865.899032 (Exim 4.92) (envelope-from ) id 1qQlJ4-0000JR-6G; Tue, 01 Aug 2023 09:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573865.899032; Tue, 01 Aug 2023 09:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ4-0000Iv-0L; Tue, 01 Aug 2023 09:04:42 +0000 Received: by outflank-mailman (input) for mailman id 573865; Tue, 01 Aug 2023 09:04:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ2-0007sM-D1 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:40 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7132afa8-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:04:38 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:36 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:34 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7132afa8-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880678; x=1722416678; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0k0T0+NBS4NOJOU0xtkOh6eqcDmcObEt/EaW35o1kMc=; b=MY1FzVtq/L4zjilpun8TivaKg4bfyNcszGLMTse9K/wjuYgPLlJFuZJo 1je/wZXJlWRMGXLMKaOOP07o4PRMsblLCmSfXbsq0QbL/srtL61MrQ0So W91aFWFQjWr31KYsgKC3wRHEXrRUTxg6qF6IL9op5CObAXI+3AlM6SPnL 6PCi1h1U09aNhDpBl3Oe73Vz+pyD6TS8Mvq/AGgUZsrDYAZI1UyIDxS6u LF1esA5SXQ9TCCMSrswhTUFcBdfd99BdNJIPjyIVA9GpuhiiohRYFyZEC UN7tzEydKxhTawSWfvrMmnJJRQaC7EzeCom/blUN0g7SPzlXzILUVw/bG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713646" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713646" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420743" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420743" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 32/36] x86/fred: Export fred_entrypoint_kernel() for handling NMI in NMI induced VM exits Date: Tue, 1 Aug 2023 01:35:49 -0700 Message-Id: <20230801083553.8468-6-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Export fred_entrypoint_kernel() for handling NMI in NMI induced VM exits. Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/entry/entry_64_fred.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/entry/entry_64_fred.S b/arch/x86/entry/entry_64_fred.S index d24bf7f10ac8..12063267d2ac 100644 --- a/arch/x86/entry/entry_64_fred.S +++ b/arch/x86/entry/entry_64_fred.S @@ -4,6 +4,7 @@ */ #include +#include #include #include "calling.h" @@ -54,3 +55,4 @@ SYM_CODE_START_NOALIGN(fred_entrypoint_kernel) FRED_EXIT ERETS SYM_CODE_END(fred_entrypoint_kernel) +EXPORT_SYMBOL(fred_entrypoint_kernel) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573866.899037 (Exim 4.92) (envelope-from ) id 1qQlJ4-0000NQ-K3; Tue, 01 Aug 2023 09:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573866.899037; Tue, 01 Aug 2023 09:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ4-0000Mq-Bf; Tue, 01 Aug 2023 09:04:42 +0000 Received: by outflank-mailman (input) for mailman id 573866; Tue, 01 Aug 2023 09:04:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ2-0007Jn-Gc for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:40 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70a4ac49-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:39 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:38 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:36 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70a4ac49-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880679; x=1722416679; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nRz3qqnddKXYmfF22m/o97+CO0o46xEgUK6odjAvUmY=; b=GJqjPjtzrFXwi1NuOogNWvXN5ohoTowUaLAMlflzvg/JuWon776u52o6 fg9SO/FOWP2DhKs4QeY0SEEcljiLMK7a8Xgk+XJWQe+FtknTmrUVMByGh QW0tMiDR7oNlVE9XwZt3fxo5PqIjZgatmvE8G+2uvRi47nHUpLaQ/wtUZ UI8W1AOkK0iL9hPDI9EYmyfGo2nayMbv8AnoL40lseTNPv//dV66iknVg sPqDagpZ5jIzSOxo7hO5NDXeu09ArozgzDcVf7VOYOw4Ij59ThRteC1t9 EfbGLhmQppBw3eFNvzUznhMVAcTuGlMxb5VC770AdSRVsz2Xh18sMxb1C A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713682" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713682" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420749" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420749" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling Date: Tue, 1 Aug 2023 01:35:50 -0700 Message-Id: <20230801083553.8468-7-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Compared to an IDT stack frame, a FRED stack frame has extra 16 bytes of information pushed at the regular stack top and 8 bytes of error code _always_ pushed at the regular stack bottom, add VMX_DO_FRED_EVENT_IRQOFF to generate FRED stack frames with event type and vector properly set. Thus, IRQ/NMI can be handled with the existing approach when FRED is enabled. For IRQ handling, general purpose registers are pushed to the stack to form a pt_regs structure, which is then used to call external_interrupt(). As a result, IRQ handling no longer re-enters the noinstr code. Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Add a new macro VMX_DO_FRED_EVENT_IRQOFF for FRED instead of refactoring VMX_DO_EVENT_IRQOFF (Sean Christopherson). * Do NOT use a trampoline, just LEA+PUSH the return RIP, PUSH the error code, and jump to the FRED kernel entry point for NMI or call external_interrupt() for IRQs (Sean Christopherson). * Call external_interrupt() only when FRED is enabled, and convert the non-FRED handling to external_interrupt() after FRED lands (Sean Christopherson). --- arch/x86/kvm/vmx/vmenter.S | 88 ++++++++++++++++++++++++++++++++++++++ arch/x86/kvm/vmx/vmx.c | 19 ++++++-- 2 files changed, 104 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S index 07e927d4d099..5ee6a57b59a5 100644 --- a/arch/x86/kvm/vmx/vmenter.S +++ b/arch/x86/kvm/vmx/vmenter.S @@ -2,12 +2,14 @@ #include #include #include +#include #include #include #include #include #include "kvm-asm-offsets.h" #include "run_flags.h" +#include "../../entry/calling.h" #define WORD_SIZE (BITS_PER_LONG / 8) @@ -31,6 +33,80 @@ #define VCPU_R15 __VCPU_REGS_R15 * WORD_SIZE #endif +#ifdef CONFIG_X86_FRED +.macro VMX_DO_FRED_EVENT_IRQOFF branch_insn branch_target nmi=0 + /* + * Unconditionally create a stack frame, getting the correct RSP on the + * stack (for x86-64) would take two instructions anyways, and RBP can + * be used to restore RSP to make objtool happy (see below). + */ + push %_ASM_BP + mov %_ASM_SP, %_ASM_BP + + /* + * Don't check the FRED stack level, the call stack leading to this + * helper is effectively constant and shallow (relatively speaking). + * + * Emulate the FRED-defined redzone and stack alignment. + */ + sub $(FRED_CONFIG_REDZONE_AMOUNT << 6), %rsp + and $FRED_STACK_FRAME_RSP_MASK, %rsp + + /* + * A FRED stack frame has extra 16 bytes of information pushed at the + * regular stack top compared to an IDT stack frame. + */ + push $0 /* Reserved by FRED, must be 0 */ + push $0 /* FRED event data, 0 for NMI and external interrupts */ + + shl $32, %rdi /* FRED event type and vector */ + .if \nmi + bts $FRED_SSX_NMI_BIT, %rdi /* Set the NMI bit */ + .endif + bts $FRED_SSX_64_BIT_MODE_BIT, %rdi /* Set the 64-bit mode */ + or $__KERNEL_DS, %rdi + push %rdi + push %rbp + pushf + mov $__KERNEL_CS, %rax + push %rax + + /* + * Unlike the IDT event delivery, FRED _always_ pushes an error code + * after pushing the return RIP, thus the CALL instruction CANNOT be + * used here to push the return RIP, otherwise there is no chance to + * push an error code before invoking the IRQ/NMI handler. + * + * Use LEA to get the return RIP and push it, then push an error code. + */ + lea 1f(%rip), %rax + push %rax + push $0 /* FRED error code, 0 for NMI and external interrupts */ + + .if \nmi == 0 + PUSH_REGS + mov %rsp, %rdi + .endif + + \branch_insn \branch_target + + .if \nmi == 0 + POP_REGS + .endif + +1: + /* + * "Restore" RSP from RBP, even though IRET has already unwound RSP to + * the correct value. objtool doesn't know the callee will IRET and, + * without the explicit restore, thinks the stack is getting walloped. + * Using an unwind hint is problematic due to x86-64's dynamic alignment. + */ + mov %_ASM_BP, %_ASM_SP + pop %_ASM_BP + RET +.endm +#endif + .macro VMX_DO_EVENT_IRQOFF call_insn call_target /* * Unconditionally create a stack frame, getting the correct RSP on the @@ -299,6 +375,12 @@ SYM_INNER_LABEL_ALIGN(vmx_vmexit, SYM_L_GLOBAL) SYM_FUNC_END(__vmx_vcpu_run) +#ifdef CONFIG_X86_FRED +SYM_FUNC_START(vmx_do_fred_nmi_irqoff) + VMX_DO_FRED_EVENT_IRQOFF jmp fred_entrypoint_kernel nmi=1 +SYM_FUNC_END(vmx_do_fred_nmi_irqoff) +#endif + SYM_FUNC_START(vmx_do_nmi_irqoff) VMX_DO_EVENT_IRQOFF call asm_exc_nmi_kvm_vmx SYM_FUNC_END(vmx_do_nmi_irqoff) @@ -357,6 +439,12 @@ SYM_FUNC_START(vmread_error_trampoline) SYM_FUNC_END(vmread_error_trampoline) #endif +#ifdef CONFIG_X86_FRED +SYM_FUNC_START(vmx_do_fred_interrupt_irqoff) + VMX_DO_FRED_EVENT_IRQOFF call external_interrupt +SYM_FUNC_END(vmx_do_fred_interrupt_irqoff) +#endif + SYM_FUNC_START(vmx_do_interrupt_irqoff) VMX_DO_EVENT_IRQOFF CALL_NOSPEC _ASM_ARG1 SYM_FUNC_END(vmx_do_interrupt_irqoff) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 0ecf4be2c6af..4e90c69a92bf 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6890,6 +6890,14 @@ static void vmx_apicv_post_state_restore(struct kvm_vcpu *vcpu) memset(vmx->pi_desc.pir, 0, sizeof(vmx->pi_desc.pir)); } +#ifdef CONFIG_X86_FRED +void vmx_do_fred_interrupt_irqoff(unsigned int vector); +void vmx_do_fred_nmi_irqoff(unsigned int vector); +#else +#define vmx_do_fred_interrupt_irqoff(x) BUG() +#define vmx_do_fred_nmi_irqoff(x) BUG() +#endif + void vmx_do_interrupt_irqoff(unsigned long entry); void vmx_do_nmi_irqoff(void); @@ -6932,14 +6940,16 @@ static void handle_external_interrupt_irqoff(struct kvm_vcpu *vcpu) { u32 intr_info = vmx_get_intr_info(vcpu); unsigned int vector = intr_info & INTR_INFO_VECTOR_MASK; - gate_desc *desc = (gate_desc *)host_idt_base + vector; if (KVM_BUG(!is_external_intr(intr_info), vcpu->kvm, "unexpected VM-Exit interrupt info: 0x%x", intr_info)) return; kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); - vmx_do_interrupt_irqoff(gate_offset(desc)); + if (cpu_feature_enabled(X86_FEATURE_FRED)) + vmx_do_fred_interrupt_irqoff(vector); /* Event type is 0 */ + else + vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base + vector)); kvm_after_interrupt(vcpu); vcpu->arch.at_instruction_boundary = true; @@ -7225,7 +7235,10 @@ static noinstr void vmx_vcpu_enter_exit(struct kvm_vcpu *vcpu, if ((u16)vmx->exit_reason.basic == EXIT_REASON_EXCEPTION_NMI && is_nmi(vmx_get_intr_info(vcpu))) { kvm_before_interrupt(vcpu, KVM_HANDLING_NMI); - vmx_do_nmi_irqoff(); + if (cpu_feature_enabled(X86_FEATURE_FRED)) + vmx_do_fred_nmi_irqoff((EVENT_TYPE_NMI << 16) | NMI_VECTOR); + else + vmx_do_nmi_irqoff(); kvm_after_interrupt(vcpu); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573867.899051 (Exim 4.92) (envelope-from ) id 1qQlJ7-0000wN-5E; Tue, 01 Aug 2023 09:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573867.899051; Tue, 01 Aug 2023 09:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ7-0000vx-24; Tue, 01 Aug 2023 09:04:45 +0000 Received: by outflank-mailman (input) for mailman id 573867; Tue, 01 Aug 2023 09:04:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ5-0007Jn-Ul for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:44 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72f4c373-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:42 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:42 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:40 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72f4c373-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880682; x=1722416682; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lojZodI3hwQLsEtOWQ3jf2ThLdccjOvBbgNRJld8Dhw=; b=R9DkPACzIdK4HypBghr3yD7fZVKf36Z+6lRzlEkTjMNEJsT5SJ5WWV3v av0ExNEU3gLF94PWbHIj6dfFw52Buap335AMHMTS8xHLGCZH+/99PcmMV hQkCia5fYmtq95o5PvMJ7+hvXut/jxgXofml/L9LEfVApKtt9K4e4dYjN nYAMs4lx2vPYcyHvlMoOQ6kUr8kv9RUvF3bLjW71ywfAuyM1dMNELkRso u3B+EqWqYtQtyw/ZJjXcOZr8ddnUbUKceCheU7fSRLc+fuOXihUDIKfVS SafVaMpIZvqZcm1Jnz7JrEgGmtaqAYwmUoicxBm7eVf7m7jE55sF1DV6G g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713751" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713751" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420766" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420766" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 35/36] x86/fred: FRED initialization code Date: Tue, 1 Aug 2023 01:35:52 -0700 Message-Id: <20230801083553.8468-9-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" The code to initialize FRED when it's available and _not_ disabled. cpu_init_fred_exceptions() is the core function to initialize FRED, which 1. Sets up FRED entrypoints for events happening in ring 0 and 3. 2. Sets up a default stack for event handling. 3. Sets up dedicated event stacks for DB/NMI/MC/DF, equivalent to the IDT IST stacks. 4. Forces 32-bit system calls to use "int $0x80" only. 5. Enables FRED and invalidtes IDT. When the FRED is used, cpu_init_exception_handling() initializes FRED through calling cpu_init_fred_exceptions(), otherwise it sets up TSS IST and loads IDT. As FRED uses the ring 3 FRED entrypoint for SYSCALL and SYSENTER, it skips setting up SYSCALL/SYSENTER related MSRs, e.g., MSR_LSTAR. Signed-off-by: H. Peter Anvin (Intel) Co-developed-by: Xin Li Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Move this patch after all required changes are in place (Thomas Gleixner). Changes since v5: * Add a comment for FRED stack level settings (Lai Jiangshan). * Define #DB/NMI/#MC/#DF stack levels using macros. --- arch/x86/include/asm/fred.h | 28 ++++++++++++++++ arch/x86/include/asm/traps.h | 4 ++- arch/x86/kernel/Makefile | 1 + arch/x86/kernel/cpu/common.c | 28 +++++++++++++--- arch/x86/kernel/fred.c | 64 ++++++++++++++++++++++++++++++++++++ arch/x86/kernel/irqinit.c | 7 +++- arch/x86/kernel/traps.c | 11 ++++++- 7 files changed, 135 insertions(+), 8 deletions(-) create mode 100644 arch/x86/kernel/fred.c diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index 3c91f0eae62e..6031138b778c 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -68,6 +68,19 @@ #define FRED_SSX_64_BIT_MODE_BIT 57 #define FRED_SSX_64_BIT_MODE _BITUL(FRED_SSX_64_BIT_MODE_BIT) +/* #DB in the kernel would imply the use of a kernel debugger. */ +#define FRED_DB_STACK_LEVEL 1 +#define FRED_NMI_STACK_LEVEL 2 +#define FRED_MC_STACK_LEVEL 2 +/* + * #DF is the highest level because a #DF means "something went wrong + * *while delivering an exception*." The number of cases for which that + * can happen with FRED is drastically reduced and basically amounts to + * "the stack you pointed me to is broken." Thus, always change stacks + * on #DF, which means it should be at the highest level. + */ +#define FRED_DF_STACK_LEVEL 3 + /* * FRED event delivery establishes a full supervisor context by * saving the essential information about an event to a FRED @@ -122,8 +135,23 @@ DECLARE_FRED_HANDLER(fred_exc_double_fault); extern asmlinkage __visible void fred_entrypoint_user(void); extern asmlinkage __visible void fred_entrypoint_kernel(void); +void cpu_init_fred_exceptions(void); +void fred_setup_apic(void); + #endif /* __ASSEMBLY__ */ +#else +#ifndef __ASSEMBLY__ +static inline void cpu_init_fred_exceptions(void) +{ + BUG(); +} + +static inline void fred_setup_apic(void) +{ + BUG(); +} +#endif #endif /* CONFIG_X86_FRED */ #endif /* ASM_X86_FRED_H */ diff --git a/arch/x86/include/asm/traps.h b/arch/x86/include/asm/traps.h index 48daa78ee88c..da7e8ab1d66d 100644 --- a/arch/x86/include/asm/traps.h +++ b/arch/x86/include/asm/traps.h @@ -49,6 +49,7 @@ void __noreturn handle_stack_overflow(struct pt_regs *regs, #ifdef CONFIG_X86_64 inline void set_sysvec_handler(unsigned int i, system_interrupt_handler func); +bool is_sysvec_used(unsigned int i); static inline void sysvec_setup_fred(unsigned int vector, system_interrupt_handler func) { @@ -63,7 +64,8 @@ static inline void sysvec_setup_fred(unsigned int vector, system_interrupt_handl #define sysvec_install(vector, func) { \ sysvec_setup_fred(vector, func); \ - alloc_intr_gate(vector, asm_##func); \ + if (!cpu_feature_enabled(X86_FEATURE_FRED)) \ + alloc_intr_gate(vector, asm_##func); \ } int external_interrupt(struct pt_regs *regs); diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 4070a01c11b7..46d8daa11c17 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -48,6 +48,7 @@ obj-y += platform-quirks.o obj-y += process_$(BITS).o signal.o signal_$(BITS).o obj-y += traps.o idt.o irq.o irq_$(BITS).o dumpstack_$(BITS).o obj-y += time.o ioport.o dumpstack.o nmi.o +obj-$(CONFIG_X86_FRED) += fred.o obj-$(CONFIG_MODIFY_LDT_SYSCALL) += ldt.o obj-y += setup.o x86_init.o i8259.o irqinit.o obj-$(CONFIG_JUMP_LABEL) += jump_label.o diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index bb03dacc5fb8..b34a8a138755 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -62,6 +62,7 @@ #include #include #include +#include #include #include #include @@ -2062,13 +2063,24 @@ static inline void idt_syscall_init(void) X86_EFLAGS_AC|X86_EFLAGS_ID); } +static inline void fred_syscall_init(void) +{ + /* Both sysexit and sysret cause #UD when FRED is enabled */ + wrmsrl_safe(MSR_IA32_SYSENTER_CS, (u64)GDT_ENTRY_INVALID_SEG); + wrmsrl_safe(MSR_IA32_SYSENTER_ESP, 0ULL); + wrmsrl_safe(MSR_IA32_SYSENTER_EIP, 0ULL); +} + /* May not be marked __init: used by software suspend */ void syscall_init(void) { /* The default user and kernel segments */ wrmsr(MSR_STAR, 0, (__USER32_CS << 16) | __KERNEL_CS); - idt_syscall_init(); + if (cpu_feature_enabled(X86_FEATURE_FRED)) + fred_syscall_init(); + else + idt_syscall_init(); } #else /* CONFIG_X86_64 */ @@ -2184,8 +2196,6 @@ void cpu_init_exception_handling(void) /* paranoid_entry() gets the CPU number from the GDT */ setup_getcpu(cpu); - /* IST vectors need TSS to be set up. */ - tss_setup_ist(tss); tss_setup_io_bitmap(tss); set_tss_desc(cpu, &get_cpu_entry_area(cpu)->tss.x86_tss); @@ -2194,8 +2204,16 @@ void cpu_init_exception_handling(void) /* GHCB needs to be setup to handle #VC. */ setup_ghcb(); - /* Finally load the IDT */ - load_current_idt(); + if (cpu_feature_enabled(X86_FEATURE_FRED)) { + /* Set up FRED exception handling */ + cpu_init_fred_exceptions(); + } else { + /* IST vectors need TSS to be set up. */ + tss_setup_ist(tss); + + /* Finally load the IDT */ + load_current_idt(); + } } /* diff --git a/arch/x86/kernel/fred.c b/arch/x86/kernel/fred.c new file mode 100644 index 000000000000..7fdf79c964a8 --- /dev/null +++ b/arch/x86/kernel/fred.c @@ -0,0 +1,64 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#include + +#include +#include +#include +#include + +void cpu_init_fred_exceptions(void) +{ + wrmsrl(MSR_IA32_FRED_CONFIG, + /* Reserve for CALL emulation */ + FRED_CONFIG_REDZONE | + FRED_CONFIG_INT_STKLVL(0) | + FRED_CONFIG_ENTRYPOINT(fred_entrypoint_user)); + + /* + * The purpose of separate stacks for NMI, #DB and #MC *in the kernel* + * (remember that user space faults are always taken on stack level 0) + * is to avoid overflowing the kernel stack. + */ + wrmsrl(MSR_IA32_FRED_STKLVLS, + FRED_STKLVL(X86_TRAP_DB, FRED_DB_STACK_LEVEL) | + FRED_STKLVL(X86_TRAP_NMI, FRED_NMI_STACK_LEVEL) | + FRED_STKLVL(X86_TRAP_MC, FRED_MC_STACK_LEVEL) | + FRED_STKLVL(X86_TRAP_DF, FRED_DF_STACK_LEVEL)); + + /* The FRED equivalents to IST stacks... */ + wrmsrl(MSR_IA32_FRED_RSP1, __this_cpu_ist_top_va(DB)); + wrmsrl(MSR_IA32_FRED_RSP2, __this_cpu_ist_top_va(NMI)); + wrmsrl(MSR_IA32_FRED_RSP3, __this_cpu_ist_top_va(DF)); + + /* Not used with FRED */ + wrmsrl(MSR_LSTAR, 0ULL); + wrmsrl(MSR_CSTAR, 0ULL); + wrmsrl_safe(MSR_IA32_SYSENTER_CS, (u64)GDT_ENTRY_INVALID_SEG); + wrmsrl_safe(MSR_IA32_SYSENTER_ESP, 0ULL); + wrmsrl_safe(MSR_IA32_SYSENTER_EIP, 0ULL); + + /* Enable FRED */ + cr4_set_bits(X86_CR4_FRED); + /* Any further IDT use is a bug */ + idt_invalidate(); + + /* Use int $0x80 for 32-bit system calls in FRED mode */ + setup_clear_cpu_cap(X86_FEATURE_SYSENTER32); + setup_clear_cpu_cap(X86_FEATURE_SYSCALL32); +} + +/* + * Initialize system vectors from a FRED perspective, so + * lapic_assign_system_vectors() can do its job. + */ +void __init fred_setup_apic(void) +{ + int i; + + for (i = 0; i < FIRST_EXTERNAL_VECTOR; i++) + set_bit(i, system_vectors); + + for (i = 0; i < NR_SYSTEM_VECTORS; i++) + if (is_sysvec_used(i)) + set_bit(i + FIRST_SYSTEM_VECTOR, system_vectors); +} diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c index c683666876f1..2a510f72dd11 100644 --- a/arch/x86/kernel/irqinit.c +++ b/arch/x86/kernel/irqinit.c @@ -28,6 +28,7 @@ #include #include #include +#include #include /* @@ -96,7 +97,11 @@ void __init native_init_IRQ(void) /* Execute any quirks before the call gates are initialised: */ x86_init.irqs.pre_vector_init(); - idt_setup_apic_and_irq_gates(); + if (cpu_feature_enabled(X86_FEATURE_FRED)) + fred_setup_apic(); + else + idt_setup_apic_and_irq_gates(); + lapic_assign_system_vectors(); if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs()) { diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 6143ad56008e..21eeba7b188f 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -1542,6 +1542,12 @@ void set_sysvec_handler(unsigned int i, system_interrupt_handler func) system_interrupt_handlers[i] = func; } +bool is_sysvec_used(unsigned int i) +{ + BUG_ON(i >= NR_SYSTEM_VECTORS); + return system_interrupt_handlers[i] != dispatch_table_spurious_interrupt; +} + int external_interrupt(struct pt_regs *regs) { unsigned int vector = regs->vector; @@ -1577,7 +1583,10 @@ void __init trap_init(void) /* Initialize TSS before setting up traps so ISTs work */ cpu_init_exception_handling(); + /* Setup traps as cpu_init() might #GP */ - idt_setup_traps(); + if (!cpu_feature_enabled(X86_FEATURE_FRED)) + idt_setup_traps(); + cpu_init(); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573868.899062 (Exim 4.92) (envelope-from ) id 1qQlJ8-0001Ez-L2; Tue, 01 Aug 2023 09:04:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573868.899062; Tue, 01 Aug 2023 09:04:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ8-0001EF-FU; Tue, 01 Aug 2023 09:04:46 +0000 Received: by outflank-mailman (input) for mailman id 573868; Tue, 01 Aug 2023 09:04:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ6-0007sM-D0 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:44 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72e4e914-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:04:42 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:40 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:38 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72e4e914-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880682; x=1722416682; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=g76n0qqOm69A/O2uudI0FugS1H+Frufn6xIPQbl7rb0=; b=J/FFtWfl50s1pk6QMvbrsRBbXieTub+lNzXb7jQVnb9Q0KRWiSiTr+nd YOWP0ZRfFuIs+Hqxp5+H0thj2/81hYRZ/UwnlILNWxKIxP60k4GVyR8wI A4er+qCth5Ngwag6BNBdy9Q2nxqFtfD84DeXWHEvBIV544486whK8O09K jPRqLXi2ReAnoFCACwIV886j3y55e76JHJFEed7ZKoGw7O8g9rgGejELV qTjhQctaog5BYB4k//0qKc76cksfoLBqNDhyRhsVI8FzJQlDohbLOHBHr 8zJhH5cdgTv6J1GEHEUvmpAMDBvjNN8BR+05U6BhW7OEruEedB77ZVeNJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713718" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713718" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420755" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420755" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 34/36] x86/syscall: Split IDT syscall setup code into idt_syscall_init() Date: Tue, 1 Aug 2023 01:35:51 -0700 Message-Id: <20230801083553.8468-8-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Split IDT syscall setup code into idt_syscall_init() to make it cleaner to add FRED syscall setup code. Suggested-by: Thomas Gleixner Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/kernel/cpu/common.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 331b06d19f7f..bb03dacc5fb8 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2027,10 +2027,8 @@ static void wrmsrl_cstar(unsigned long val) wrmsrl(MSR_CSTAR, val); } -/* May not be marked __init: used by software suspend */ -void syscall_init(void) +static inline void idt_syscall_init(void) { - wrmsr(MSR_STAR, 0, (__USER32_CS << 16) | __KERNEL_CS); wrmsrl(MSR_LSTAR, (unsigned long)entry_SYSCALL_64); #ifdef CONFIG_IA32_EMULATION @@ -2064,6 +2062,15 @@ void syscall_init(void) X86_EFLAGS_AC|X86_EFLAGS_ID); } +/* May not be marked __init: used by software suspend */ +void syscall_init(void) +{ + /* The default user and kernel segments */ + wrmsr(MSR_STAR, 0, (__USER32_CS << 16) | __KERNEL_CS); + + idt_syscall_init(); +} + #else /* CONFIG_X86_64 */ #ifdef CONFIG_STACKPROTECTOR -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:04:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:04:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573869.899067 (Exim 4.92) (envelope-from ) id 1qQlJ9-0001NC-DF; Tue, 01 Aug 2023 09:04:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573869.899067; Tue, 01 Aug 2023 09:04:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ9-0001KU-34; Tue, 01 Aug 2023 09:04:47 +0000 Received: by outflank-mailman (input) for mailman id 573869; Tue, 01 Aug 2023 09:04:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlJ7-0007Jn-Ms for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:04:45 +0000 Received: from mgamail.intel.com (unknown [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 750ae0e8-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:04:44 +0200 (CEST) Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:04:43 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga007.jf.intel.com with ESMTP; 01 Aug 2023 02:04:42 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 750ae0e8-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880684; x=1722416684; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gEY4ZGGaaQpe3vscglEO/Z/ZNgQa2ejE/Ek77q9vAj0=; b=QFIE8Szr7GbNnf0WcdEBwBq/u2eE3k1tDtEPMZLbFbZJXd7GhBceJPFP tUKorNIdVL8t+ScOfYP7lO7vCYKYh34PWt+/xAr64jOcHWlxKXbvGEmhG PIpQu6G22Fa3NiihLeRUYWW8OwyFY5IzNHOHYaKvElSgvP7NPoO+TVMog ZazPcdcc5yO8a+vLmlYdW/jTGVceK8TvtDgYvb7Xm/FJZF3QHxg8xpmHm TCH9tpfb4oJV2cEHv0rThDae8El6xVNQQEKTouk5uTGMOn8p9DxurMXFX OqBSTHoJ/99/N/IOkAG6KUFIjRNiuhaA1tYd7R12wGv9Y21BIQygSRf4l g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="366713784" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="366713784" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="722420775" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="722420775" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 36/36] x86/fred: Disable FRED by default in its early stage Date: Tue, 1 Aug 2023 01:35:53 -0700 Message-Id: <20230801083553.8468-10-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083553.8468-1-xin3.li@intel.com> References: <20230801083553.8468-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Disable FRED by default in its early stage. To enable FRED, a new kernel command line option "fred" needs to be added. Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v7: * Add a log message when FRED is enabled. --- Documentation/admin-guide/kernel-parameters.txt | 4 ++++ arch/x86/kernel/cpu/common.c | 3 +++ arch/x86/kernel/fred.c | 3 +++ 3 files changed, 10 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a1457995fd41..cb12decfcdc0 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1513,6 +1513,10 @@ Warning: use of this parameter will taint the kernel and may cause unknown problems. + fred + Forcefully enable flexible return and event delivery, + which is otherwise disabled by default. + ftrace=[tracer] [FTRACE] will set and start the specified tracer as early as possible in order to facilitate early diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index b34a8a138755..38cf4f64a56e 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1451,6 +1451,9 @@ static void __init cpu_parse_early_param(void) char *argptr = arg, *opt; int arglen, taint = 0; + if (!cmdline_find_option_bool(boot_command_line, "fred")) + setup_clear_cpu_cap(X86_FEATURE_FRED); + #ifdef CONFIG_X86_32 if (cmdline_find_option_bool(boot_command_line, "no387")) #ifdef CONFIG_MATH_EMULATION diff --git a/arch/x86/kernel/fred.c b/arch/x86/kernel/fred.c index 7fdf79c964a8..a4a726ea9fc2 100644 --- a/arch/x86/kernel/fred.c +++ b/arch/x86/kernel/fred.c @@ -8,6 +8,9 @@ void cpu_init_fred_exceptions(void) { + /* When FRED is enabled by default, this log message may not needed */ + pr_info("Initialize FRED on CPU%d\n", smp_processor_id()); + wrmsrl(MSR_IA32_FRED_CONFIG, /* Reserve for CALL emulation */ FRED_CONFIG_REDZONE | -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573930.899081 (Exim 4.92) (envelope-from ) id 1qQlME-0004rX-D4; Tue, 01 Aug 2023 09:07:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573930.899081; Tue, 01 Aug 2023 09:07:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlME-0004rQ-9u; Tue, 01 Aug 2023 09:07:58 +0000 Received: by outflank-mailman (input) for mailman id 573930; Tue, 01 Aug 2023 09:07:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGm-0005CK-0V for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:20 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e3ff35a-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:19 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:11 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:10 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e3ff35a-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880539; x=1722416539; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QeZUtDgMAPwFIrdo9TmaG72+ignP6GGIZpxe8B2aw6k=; b=WQl6TwPrN6Sy0l3M4N9YPr7w8tT645eltV74dGUcBukoP7OtWEQhomST yHhoujrwYNpdqb3LLemUZEHFJHoEdqD/LXMMIIEmhir8yVnBd9f6roMAI ydfKMVXNaKpSfnj51pcIVmyLXPyC2zOW134BHNGT4E04avgYIBIzmpHdX jfGepdVKDTsTNWYCp8/PjAfX21wJ+vudiZc5CrY1ysrVNyhiGTEZIOsiI ojLeEuRHjcw192UTIsbFAZaZ1uIcE3uxzFdWdtgPBHQ+x6V1gztueQEff P5Cy4Erb7RC7+EtLSq5XB5eA6ModcQRbWsN6aPsNPcdnu4Ph4aDStmUX6 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082780" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082780" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217078" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217078" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 22/36] x86/fred: Add a double fault entry stub for FRED Date: Tue, 1 Aug 2023 01:33:04 -0700 Message-Id: <20230801083318.8363-23-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IDT event delivery of a double fault pushes an error code into the orig_ax member of the pt_regs structure, and the error code is passed as the second argument of its C-handler exc_double_fault(), although the pt_regs structure is already passed as the first argument. The existing IDT double fault asm entry code does the following movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ to set the orig_ax member to -1 just before calling the C-handler. X86_TRAP_TS, X86_TRAP_NP, X86_TRAP_SS, X86_TRAP_GP, X86_TRAP_AC and X86_TRAP_CP are all handled in the same way because the IDT event delivery pushes an error code into their stack frame for them. The commit d99015b1abbad ("x86: move entry_64.S register saving out of the macros") introduced the changes to set orig_ax to -1, but I can't see why. Our tests with FRED seem fine if orig_ax is left unchanged instead of set to -1. It's probably cleaner and simpler to remove the second argument from exc_double_fault() while leave orig_ax unchanged to pass the error code inside the first argument, at least on native x86_64. That would be a separate, pre-FRED, patch. For now just add a double fault entry stub for FRED, which simply calls the existing exc_double_fault(). Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/fred.h | 1 + arch/x86/kernel/traps.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index f559dd9dc4f2..bd701ac87528 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -116,6 +116,7 @@ DECLARE_FRED_HANDLER(fred_exc_nmi); DECLARE_FRED_HANDLER(fred_exc_debug); DECLARE_FRED_HANDLER(fred_exc_page_fault); DECLARE_FRED_HANDLER(fred_exc_machine_check); +DECLARE_FRED_HANDLER(fred_exc_double_fault); #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index b10464966a81..49dd92458eb0 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -555,6 +555,13 @@ DEFINE_IDTENTRY_DF(exc_double_fault) instrumentation_end(); } +#ifdef CONFIG_X86_FRED +DEFINE_FRED_HANDLER(fred_exc_double_fault) +{ + exc_double_fault(regs, regs->orig_ax); +} +#endif + DEFINE_IDTENTRY(exc_bounds) { if (notify_die(DIE_TRAP, "bounds", regs, 0, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573938.899092 (Exim 4.92) (envelope-from ) id 1qQlMI-00058m-KJ; Tue, 01 Aug 2023 09:08:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573938.899092; Tue, 01 Aug 2023 09:08:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMI-00058f-Hg; Tue, 01 Aug 2023 09:08:02 +0000 Received: by outflank-mailman (input) for mailman id 573938; Tue, 01 Aug 2023 09:08:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGn-0005CK-9s for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:21 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1effbd01-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:20 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:12 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:11 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1effbd01-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880540; x=1722416540; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=e41GdB5DEWVT44n/+24ZLrn6jlcg49oHxwygKL8Pbqk=; b=A+1flqiEw8dMX2wPYysxaD3/gAk2kQw3/Vd5t9eI0hf4nrOOjWTzdV3A xfspG5eTEQ6oJ2TKy3s/25FDnDFqm/Rd9oF7ppthXAVFOESuk33c6dm+H GyYKx6w2a8Jgy/G+jIeIj3/XgochE7V8RDuYkba8YNFPGvV5G3nV7aqwf 7kziMYW6OR38WFvleASOVENltIqYwegD4bedvFqWKf255r3122ZrU0dPV /vav+bFbILa5dtrIBDcYpwB6V9sKSdUIMnsGGn5+9CRt/VodXGpNr2ATO k6C7CTpd28wdAL8VVtAM7gUcyHS4IDr1EJlr04xrJXG1NcHLkN3dEb2io g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082814" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082814" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217082" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217082" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 23/36] x86/entry: Remove idtentry_sysvec from entry_{32,64}.S Date: Tue, 1 Aug 2023 01:33:05 -0700 Message-Id: <20230801083318.8363-24-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit idtentry_sysvec is really just DECLARE_IDTENTRY defined in , no need to define it separately. Signed-off-by: Xin Li --- arch/x86/entry/entry_32.S | 4 ---- arch/x86/entry/entry_64.S | 8 -------- arch/x86/include/asm/idtentry.h | 2 +- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index 6e6af42e044a..e0f22ad8ff7e 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -649,10 +649,6 @@ SYM_CODE_START_LOCAL(asm_\cfunc) SYM_CODE_END(asm_\cfunc) .endm -.macro idtentry_sysvec vector cfunc - idtentry \vector asm_\cfunc \cfunc has_error_code=0 -.endm - /* * Include the defines which emit the idt entries which are shared * shared between 32 and 64 bit and emit the __irqentry_text_* markers diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 8069151176f2..44f14b990597 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -438,14 +438,6 @@ SYM_CODE_END(\asmsym) idtentry \vector asm_\cfunc \cfunc has_error_code=1 .endm -/* - * System vectors which invoke their handlers directly and are not - * going through the regular common device interrupt handling code. - */ -.macro idtentry_sysvec vector cfunc - idtentry \vector asm_\cfunc \cfunc has_error_code=0 -.endm - /** * idtentry_mce_db - Macro to generate entry stubs for #MC and #DB * @vector: Vector number diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index cd5c10a74071..6817c0f8e323 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -447,7 +447,7 @@ __visible noinstr void func(struct pt_regs *regs, \ /* System vector entries */ #define DECLARE_IDTENTRY_SYSVEC(vector, func) \ - idtentry_sysvec vector func + DECLARE_IDTENTRY(vector, func) #ifdef CONFIG_X86_64 # define DECLARE_IDTENTRY_MCE(vector, func) \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573940.899102 (Exim 4.92) (envelope-from ) id 1qQlMN-0005Tu-SV; Tue, 01 Aug 2023 09:08:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573940.899102; Tue, 01 Aug 2023 09:08:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMN-0005Tm-PO; Tue, 01 Aug 2023 09:08:07 +0000 Received: by outflank-mailman (input) for mailman id 573940; Tue, 01 Aug 2023 09:08:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGk-0005CK-O6 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:18 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cad0178-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:17 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:09 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:08 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cad0178-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880537; x=1722416537; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CDXH8O7ex78Bl5bAFBaH8EJ8EpWaGJ2TaZytElzEDrs=; b=iKCET4nu2td9LD1US09FDuYAzFoT6/Nv9TRtc3CQS2f5MKCV0QOYbrxW BhJUI93avdfbluLIgI4L0LuQOuQCl0TjTRn0JDaMKB+lvebGEGq0rFQOq EkgHHCpjsjQYCMRquRMc7Xot3gQNUXSdQfXl2FrxcRa45uATW0GLagFjr e5YUUBu3SQCrjM8VomA1yew0ryAACWmXMDePN4tf3BitvJKWkmHo5PgIj bZFXGvriKuCHgLWzZWBTRVzO4a5W9Ho27K+bhcoMqHgVI/vnx62iAalvB 2Nm0eKaMWrjKFrQtYyXX8SPG6DzFUlJhnrju6WooNqnjBtHZCjOOBt2NE A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082713" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082713" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217069" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217069" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 20/36] x86/fred: Add a NMI entry stub for FRED Date: Tue, 1 Aug 2023 01:33:02 -0700 Message-Id: <20230801083318.8363-21-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" On a FRED system, NMIs nest both with themselves and faults, transient information is saved into the stack frame, and NMI unblocking only happens when the stack frame indicates that so should happen. Thus, the NMI entry stub for FRED is really quite small... Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- arch/x86/include/asm/fred.h | 1 + arch/x86/kernel/nmi.c | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index ad7b79130b1e..2a7c47dfd733 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -112,6 +112,7 @@ static __always_inline unsigned long fred_event_data(struct pt_regs *regs) typedef DECLARE_FRED_HANDLER((*fred_handler)); +DECLARE_FRED_HANDLER(fred_exc_nmi); DECLARE_FRED_HANDLER(fred_exc_debug); DECLARE_FRED_HANDLER(fred_exc_page_fault); diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c index a0c551846b35..f803e2bcd024 100644 --- a/arch/x86/kernel/nmi.c +++ b/arch/x86/kernel/nmi.c @@ -34,6 +34,7 @@ #include #include #include +#include #define CREATE_TRACE_POINTS #include @@ -643,6 +644,24 @@ void nmi_backtrace_stall_check(const struct cpumask *btp) #endif +#ifdef CONFIG_X86_FRED +DEFINE_FRED_HANDLER(fred_exc_nmi) +{ + /* + * With FRED, CR2 and DR6 are pushed atomically on faults, + * so we don't have to worry about saving and restoring them. + * Breakpoint faults nest, so assume it is OK to leave DR7 + * enabled. + */ + irqentry_state_t irq_state = irqentry_nmi_enter(regs); + + inc_irq_stat(__nmi_count); + default_do_nmi(regs); + + irqentry_nmi_exit(regs, irq_state); +} +#endif + void stop_nmi(void) { ignore_nmis++; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573945.899112 (Exim 4.92) (envelope-from ) id 1qQlMP-0005kR-6H; Tue, 01 Aug 2023 09:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573945.899112; Tue, 01 Aug 2023 09:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMP-0005kB-2C; Tue, 01 Aug 2023 09:08:09 +0000 Received: by outflank-mailman (input) for mailman id 573945; Tue, 01 Aug 2023 09:08:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGh-0005E5-ML for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:15 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a50fda1-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:12 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:08 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:07 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a50fda1-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880533; x=1722416533; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j/3qauZAla4FAGFWojUuQZ7eYbLWgN4OkDYWsZA4A8I=; b=kwmquXZf3nsAGk36Kaa7x3VbY23Gx+NFJzJtlaIRUxZXzYJdxgnLyUkK bvBIWGV27d9jYzwxJBDvx4KC2kcbOEURifuOkoqmXcBmI+iF5U5T+XWWB RLMNQcie+WEhaShBkOlwSIuRAtTHvkwv7jJixgYSov7BVz0rajtczleBc cB+nVYUiiiz7GTm4CN8ixGkOS4wP7IqVfV1xqJQLKn+zOxRXvu8sod91N wPLUVQ1cT7QJFObtbOOy7gHghrjRrZYBiiBQyhb1G9fI8bOm4NtzHFak1 tLnffMnjXJjJDSrVJGT8ULpb1zsvibNFpGQUWBTc2SE+9c+rG0FcyoAbc g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082675" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082675" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217066" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217066" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 19/36] x86/fred: Add a debug fault entry stub for FRED Date: Tue, 1 Aug 2023 01:33:01 -0700 Message-Id: <20230801083318.8363-20-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" Add a debug fault entry stub for FRED. On a FRED system, the debug trap status information (DR6) is passed on the stack, to avoid the problem of transient state. Furthermore, FRED transitions avoid a lot of ugly corner cases the handling of which can, and should be, skipped. The FRED debug trap status information saved on the stack differs from DR6 in both stickiness and polarity; it is exactly what debug_read_clear_dr6() returns, and exc_debug_user()/exc_debug_kernel() expect. Signed-off-by: H. Peter Anvin (Intel) Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v1: * call irqentry_nmi_{enter,exit}() in both IDT and FRED debug fault kernel handler (Peter Zijlstra). --- arch/x86/include/asm/fred.h | 1 + arch/x86/kernel/traps.c | 56 +++++++++++++++++++++++++++---------- 2 files changed, 42 insertions(+), 15 deletions(-) diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index fb8e7b4f2d38..ad7b79130b1e 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -112,6 +112,7 @@ static __always_inline unsigned long fred_event_data(struct pt_regs *regs) typedef DECLARE_FRED_HANDLER((*fred_handler)); +DECLARE_FRED_HANDLER(fred_exc_debug); DECLARE_FRED_HANDLER(fred_exc_page_fault); #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 4a817d20ce3b..b10464966a81 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -47,6 +47,7 @@ #include #include #include +#include #include #include #include @@ -1021,21 +1022,9 @@ static bool notify_debug(struct pt_regs *regs, unsigned long *dr6) return false; } -static __always_inline void exc_debug_kernel(struct pt_regs *regs, - unsigned long dr6) +static __always_inline void debug_kernel_common(struct pt_regs *regs, + unsigned long dr6) { - /* - * Disable breakpoints during exception handling; recursive exceptions - * are exceedingly 'fun'. - * - * Since this function is NOKPROBE, and that also applies to - * HW_BREAKPOINT_X, we can't hit a breakpoint before this (XXX except a - * HW_BREAKPOINT_W on our stack) - * - * Entry text is excluded for HW_BP_X and cpu_entry_area, which - * includes the entry stack is excluded for everything. - */ - unsigned long dr7 = local_db_save(); irqentry_state_t irq_state = irqentry_nmi_enter(regs); instrumentation_begin(); @@ -1063,7 +1052,8 @@ static __always_inline void exc_debug_kernel(struct pt_regs *regs, * Catch SYSENTER with TF set and clear DR_STEP. If this hit a * watchpoint at the same time then that will still be handled. */ - if ((dr6 & DR_STEP) && is_sysenter_singlestep(regs)) + if (!cpu_feature_enabled(X86_FEATURE_FRED) && + (dr6 & DR_STEP) && is_sysenter_singlestep(regs)) dr6 &= ~DR_STEP; /* @@ -1091,7 +1081,25 @@ static __always_inline void exc_debug_kernel(struct pt_regs *regs, out: instrumentation_end(); irqentry_nmi_exit(regs, irq_state); +} +static __always_inline void exc_debug_kernel(struct pt_regs *regs, + unsigned long dr6) +{ + /* + * Disable breakpoints during exception handling; recursive exceptions + * are exceedingly 'fun'. + * + * Since this function is NOKPROBE, and that also applies to + * HW_BREAKPOINT_X, we can't hit a breakpoint before this (XXX except a + * HW_BREAKPOINT_W on our stack) + * + * Entry text is excluded for HW_BP_X and cpu_entry_area, which + * includes the entry stack is excluded for everything. + */ + unsigned long dr7 = local_db_save(); + + debug_kernel_common(regs, dr6); local_db_restore(dr7); } @@ -1180,6 +1188,24 @@ DEFINE_IDTENTRY_DEBUG_USER(exc_debug) { exc_debug_user(regs, debug_read_clear_dr6()); } + +# ifdef CONFIG_X86_FRED +DEFINE_FRED_HANDLER(fred_exc_debug) +{ + /* + * The FRED debug information saved onto stack differs from + * DR6 in both stickiness and polarity; it is exactly what + * debug_read_clear_dr6() returns. + */ + unsigned long dr6 = fred_event_data(regs); + + if (user_mode(regs)) + exc_debug_user(regs, dr6); + else + debug_kernel_common(regs, dr6); +} +# endif /* CONFIG_X86_FRED */ + #else /* 32 bit does not have separate entry points. */ DEFINE_IDTENTRY_RAW(exc_debug) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573946.899117 (Exim 4.92) (envelope-from ) id 1qQlMP-0005or-JZ; Tue, 01 Aug 2023 09:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573946.899117; Tue, 01 Aug 2023 09:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMP-0005oC-Ca; Tue, 01 Aug 2023 09:08:09 +0000 Received: by outflank-mailman (input) for mailman id 573946; Tue, 01 Aug 2023 09:08:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGp-0005E5-Vu for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:24 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f941154-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:21 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:13 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:12 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f941154-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880541; x=1722416541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=noUm+C4jbhw0mC8rdAqNdlrDhDQPWQ7nu1SRrIUqW1s=; b=cfcqHCV6MVt1dSSCeYpGuLuuVv1HiIuEpr8aALTGu5WTcSGfUa725rUq zpWaEN19WqIkIjqwtfFIkF8+Ggx+JFIqdlBR5GncXJedwX8Kcwdksy0mx h7y0gVCdIScXVIAfl5ewS1JNa75lpBPi+xyejc/hya0DBwhTdJ5wnjYKz S6absSKgKzqmRNAHTLFl48Fz+Doyv8+7robP1s1eGxDmlX0oZ2DqoIwu/ GXVRY5oVuBWmwz3XJLD/pdUV+qFnJVqMS6IpAfOYCrP9LruFTMNlM1vY+ sP+ppd9Q87KbNK3Va3UvRDNMnSHtlGVNN4Z1AkRaa0uPFysqmVZ9U7cxz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082844" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082844" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217087" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217087" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 24/36] x86/idtentry: Incorporate definitions/declarations of the FRED external interrupt handler type Date: Tue, 1 Aug 2023 01:33:06 -0700 Message-Id: <20230801083318.8363-25-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FRED operates differently from IDT in terms of interrupt handling. Instead of directly dispatching an interrupt to its handler based on the interrupt vector, FRED requires the software to dispatch an event to its handler based on both the event's type and vector. Therefore, an event dispatch framework must be implemented to facilitate the event-to-handler dispatch process. The FRED event dispatch framework assumes control once an event is delivered, starting from two FRED entry points, after which several event dispatch tables are introduced to facilitate the dispatching. The first level dispatching is event type based, and two tables need to be defined, one for ring 3 event dispatching, and the other for ring 0. The second level dispatching is event vector based, and several tables need to be defined, e.g., an exception handler table for exception dispatching. Handlers in these tables are typically noinstr. However for external interrupt dispatching, irqentry_{enter,exit}() and instrumentation_{begin,end}() can be extracted from respective interrupt handler to the dispatch framework. As a result, FRED external interrupt handlers don't need to be noinstr. Incorporate definitions/declarations of FRED external interrupt handler types into the IDT entry macros. It is probably better to rename idtentry as event_entry. Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Put IDTENTRY changes in a separate patch (Thomas Gleixner). --- arch/x86/include/asm/idtentry.h | 91 +++++++++++++++++++++++++++++---- 1 file changed, 82 insertions(+), 9 deletions(-) diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index 6817c0f8e323..e67d111bf932 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -167,17 +167,22 @@ __visible noinstr void func(struct pt_regs *regs, unsigned long error_code) /** * DECLARE_IDTENTRY_IRQ - Declare functions for device interrupt IDT entry - * points (common/spurious) + * points (common/spurious) and their corresponding + * software based dispatch handlers in the non-noinstr + * text section * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Maps to DECLARE_IDTENTRY_ERRORCODE() + * Maps to DECLARE_IDTENTRY_ERRORCODE(), plus a dispatch function prototype */ #define DECLARE_IDTENTRY_IRQ(vector, func) \ - DECLARE_IDTENTRY_ERRORCODE(vector, func) + DECLARE_IDTENTRY_ERRORCODE(vector, func); \ + void dispatch_##func(struct pt_regs *regs, unsigned long error_code) /** * DEFINE_IDTENTRY_IRQ - Emit code for device interrupt IDT entry points + * and their corresponding software based dispatch + * handlers in the non-noinstr text section * @func: Function name of the entry point * * The vector number is pushed by the low level entry stub and handed @@ -187,6 +192,11 @@ __visible noinstr void func(struct pt_regs *regs, unsigned long error_code) * irq_enter/exit_rcu() are invoked before the function body and the * KVM L1D flush request is set. Stack switching to the interrupt stack * has to be done in the function body if necessary. + * + * dispatch_func() is a software based dispatch handler in the non-noinstr + * text section, assuming the irqentry_{enter,exit}() and + * instrumentation_{begin,end}() helpers are invoked in the external + * interrupt dispatch framework before and after dispatch_func(). */ #define DEFINE_IDTENTRY_IRQ(func) \ static void __##func(struct pt_regs *regs, u32 vector); \ @@ -204,31 +214,68 @@ __visible noinstr void func(struct pt_regs *regs, \ irqentry_exit(regs, state); \ } \ \ +__visible void dispatch_##func(struct pt_regs *regs, \ + unsigned long error_code) \ +{ \ + u32 vector = (u32)(u8)error_code; \ + \ + kvm_set_cpu_l1tf_flush_l1d(); \ + run_irq_on_irqstack_cond(__##func, regs, vector); \ +} \ + \ static noinline void __##func(struct pt_regs *regs, u32 vector) +/* + * Define a function type system_interrupt_handler as the element type of + * the table system_interrupt_handlers. + * + * System interrupt handlers don't take any interrupt vector number, or + * any interrupt error code as arguments, as a system interrupt handler + * is defined to handle a specific interrupt vector, and no error code + * is defined for external interrupts. It takes only one argument of type + * struct pt_regs *. + */ +#define DECLARE_SYSTEM_INTERRUPT_HANDLER(f) \ + void f (struct pt_regs *regs) +#define DEFINE_SYSTEM_INTERRUPT_HANDLER(f) \ + __visible DECLARE_SYSTEM_INTERRUPT_HANDLER(f) +typedef DECLARE_SYSTEM_INTERRUPT_HANDLER((*system_interrupt_handler)); + /** * DECLARE_IDTENTRY_SYSVEC - Declare functions for system vector entry points + * and their corresponding software based dispatch + * handlers in the non-noinstr text section * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Declares three functions: + * Declares four functions: * - The ASM entry point: asm_##func * - The XEN PV trap entry point: xen_##func (maybe unused) * - The C handler called from the ASM entry point + * - The C handler used in the system interrupt handler table * - * Maps to DECLARE_IDTENTRY(). + * Maps to DECLARE_IDTENTRY(), plus a dispatch table function prototype */ #define DECLARE_IDTENTRY_SYSVEC(vector, func) \ - DECLARE_IDTENTRY(vector, func) + DECLARE_IDTENTRY(vector, func); \ + DECLARE_SYSTEM_INTERRUPT_HANDLER(dispatch_table_##func) /** * DEFINE_IDTENTRY_SYSVEC - Emit code for system vector IDT entry points + * and their corresponding software based dispatch + * handlers in the non-noinstr text section * @func: Function name of the entry point * * irqentry_enter/exit() and irq_enter/exit_rcu() are invoked before the * function body. KVM L1D flush request is set. * - * Runs the function on the interrupt stack if the entry hit kernel mode + * Runs the function on the interrupt stack if the entry hit kernel mode. + * + * dispatch_table_func() is used to fill the system interrupt handler table + * for system interrupts dispatching, assuming the irqentry_{enter,exit}() + * and instrumentation_{begin,end}() helpers are invoked in the external + * interrupt dispatch framework before and after dispatch_table_func(), + * thus in the non-noinstr text section. */ #define DEFINE_IDTENTRY_SYSVEC(func) \ static void __##func(struct pt_regs *regs); \ @@ -244,11 +291,19 @@ __visible noinstr void func(struct pt_regs *regs) \ irqentry_exit(regs, state); \ } \ \ +DEFINE_SYSTEM_INTERRUPT_HANDLER(dispatch_table_##func) \ +{ \ + kvm_set_cpu_l1tf_flush_l1d(); \ + run_sysvec_on_irqstack_cond(__##func, regs); \ +} \ + \ static noinline void __##func(struct pt_regs *regs) /** * DEFINE_IDTENTRY_SYSVEC_SIMPLE - Emit code for simple system vector IDT - * entry points + * entry points and their corresponding + * software based dispatch handlers in + * the non-noinstr text section * @func: Function name of the entry point * * Runs the function on the interrupted stack. No switch to IRQ stack and @@ -256,6 +311,12 @@ static noinline void __##func(struct pt_regs *regs) * * Only use for 'empty' vectors like reschedule IPI and KVM posted * interrupt vectors. + * + * dispatch_table_func() is used to fill the system interrupt handler table + * for system interrupts dispatching, assuming the irqentry_{enter,exit}() + * and instrumentation_{begin,end}() helpers are invoked in the external + * interrupt dispatch framework before and after dispatch_table_func(), + * thus in the non-noinstr text section. */ #define DEFINE_IDTENTRY_SYSVEC_SIMPLE(func) \ static __always_inline void __##func(struct pt_regs *regs); \ @@ -273,6 +334,14 @@ __visible noinstr void func(struct pt_regs *regs) \ irqentry_exit(regs, state); \ } \ \ +DEFINE_SYSTEM_INTERRUPT_HANDLER(dispatch_table_##func) \ +{ \ + __irq_enter_raw(); \ + kvm_set_cpu_l1tf_flush_l1d(); \ + __##func (regs); \ + __irq_exit_raw(); \ +} \ + \ static __always_inline void __##func(struct pt_regs *regs) /** @@ -647,7 +716,11 @@ DECLARE_IDTENTRY_SYSVEC(X86_PLATFORM_IPI_VECTOR, sysvec_x86_platform_ipi); #endif #ifdef CONFIG_SMP -DECLARE_IDTENTRY(RESCHEDULE_VECTOR, sysvec_reschedule_ipi); +/* + * Use DECLARE_IDTENTRY_SYSVEC instead of DECLARE_IDTENTRY to add a + * software based dispatch handler declaration for RESCHEDULE_VECTOR. + */ +DECLARE_IDTENTRY_SYSVEC(RESCHEDULE_VECTOR, sysvec_reschedule_ipi); DECLARE_IDTENTRY_SYSVEC(REBOOT_VECTOR, sysvec_reboot); DECLARE_IDTENTRY_SYSVEC(CALL_FUNCTION_SINGLE_VECTOR, sysvec_call_function_single); DECLARE_IDTENTRY_SYSVEC(CALL_FUNCTION_VECTOR, sysvec_call_function); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573957.899132 (Exim 4.92) (envelope-from ) id 1qQlMZ-0006nr-1S; Tue, 01 Aug 2023 09:08:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573957.899132; Tue, 01 Aug 2023 09:08:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMY-0006nf-TF; Tue, 01 Aug 2023 09:08:18 +0000 Received: by outflank-mailman (input) for mailman id 573957; Tue, 01 Aug 2023 09:08:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGs-0005E5-1v for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:26 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f0b02d1-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:23 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:15 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:14 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f0b02d1-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880543; x=1722416543; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0Vsn6bDzpRkXYLGAG2NP2KMCccOE1uQI/p8GcVukrL0=; b=DMaiO47Z2+wpPhrKmZNLe4YnyWJ8bHznHAQrQTp3H/fKcVglw0ubF8mS TZCmJCzy8lvh85PuyfjG8XzaybLxXrvPRv5nHo/knKFWzSF8ZSxtT68Rr Rm0u4/EbEF8nbvs/Z8aglgyo9Pc7viiKk5Fq39+wTU0M2E3BHUV9S/w29 AN3tITji3aXTmV9Oe3y06L8V4ifmzoUDxZOAmbH6d9KTQv024L2uO0pXe eJjKaI6vunRYzJJKu2SL53COwIAZPkYDyHqqTR8qHlBQjx0GAa8rsVPwu W39OQr9lY6rx+SQk8ZBytSl0vB/e2dQhTeYf8IdiWXr5EAdtEoMiVFr19 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082913" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082913" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217094" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217094" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 26/36] x86/traps: Add sysvec_install() to install a system interrupt handler Date: Tue, 1 Aug 2023 01:33:08 -0700 Message-Id: <20230801083318.8363-27-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add sysvec_install() to install a system interrupt handler into both the IDT and system_interrupt_handlers. The latter is used to dispatch system interrupts to their respective handlers when FRED is enabled. Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Introduce a macro sysvec_install() to derive the asm handler name from a C handler, which simplifies the code and avoids an ugly typecast (Thomas Gleixner). --- arch/x86/include/asm/traps.h | 19 +++++++++++++++++++ arch/x86/kernel/cpu/acrn.c | 5 +++-- arch/x86/kernel/cpu/mshyperv.c | 16 ++++++++-------- arch/x86/kernel/kvm.c | 2 +- arch/x86/kernel/traps.c | 6 ++++++ drivers/xen/events/events_base.c | 3 ++- 6 files changed, 39 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/traps.h b/arch/x86/include/asm/traps.h index 47ecfff2c83d..cba3e4dfc329 100644 --- a/arch/x86/include/asm/traps.h +++ b/arch/x86/include/asm/traps.h @@ -47,4 +47,23 @@ void __noreturn handle_stack_overflow(struct pt_regs *regs, struct stack_info *info); #endif +#ifdef CONFIG_X86_64 +inline void set_sysvec_handler(unsigned int i, system_interrupt_handler func); + +static inline void sysvec_setup_fred(unsigned int vector, system_interrupt_handler func) +{ + BUG_ON(vector < FIRST_SYSTEM_VECTOR); + set_sysvec_handler(vector - FIRST_SYSTEM_VECTOR, func); +} +#else +static inline void sysvec_setup_fred(unsigned int vector, system_interrupt_handler func) +{ +} +#endif + +#define sysvec_install(vector, func) { \ + sysvec_setup_fred(vector, func); \ + alloc_intr_gate(vector, asm_##func); \ +} + #endif /* _ASM_X86_TRAPS_H */ diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c index 485441b7f030..a879b4b87740 100644 --- a/arch/x86/kernel/cpu/acrn.c +++ b/arch/x86/kernel/cpu/acrn.c @@ -18,6 +18,7 @@ #include #include #include +#include static u32 __init acrn_detect(void) { @@ -26,8 +27,8 @@ static u32 __init acrn_detect(void) static void __init acrn_init_platform(void) { - /* Setup the IDT for ACRN hypervisor callback */ - alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, asm_sysvec_acrn_hv_callback); + /* Install system interrupt handler for ACRN hypervisor callback */ + sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_acrn_hv_callback); x86_platform.calibrate_tsc = acrn_get_tsc_khz; x86_platform.calibrate_cpu = acrn_get_tsc_khz; diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index c7969e806c64..134830a7f575 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -480,19 +481,18 @@ static void __init ms_hyperv_init_platform(void) */ x86_platform.apic_post_init = hyperv_init; hyperv_setup_mmu_ops(); - /* Setup the IDT for hypervisor callback */ - alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, asm_sysvec_hyperv_callback); - /* Setup the IDT for reenlightenment notifications */ + /* Install system interrupt handler for hypervisor callback */ + sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_hyperv_callback); + + /* Install system interrupt handler for reenlightenment notifications */ if (ms_hyperv.features & HV_ACCESS_REENLIGHTENMENT) { - alloc_intr_gate(HYPERV_REENLIGHTENMENT_VECTOR, - asm_sysvec_hyperv_reenlightenment); + sysvec_install(HYPERV_REENLIGHTENMENT_VECTOR, sysvec_hyperv_reenlightenment); } - /* Setup the IDT for stimer0 */ + /* Install system interrupt handler for stimer0 */ if (ms_hyperv.misc_features & HV_STIMER_DIRECT_MODE_AVAILABLE) { - alloc_intr_gate(HYPERV_STIMER0_VECTOR, - asm_sysvec_hyperv_stimer0); + sysvec_install(HYPERV_STIMER0_VECTOR, sysvec_hyperv_stimer0); } # ifdef CONFIG_SMP diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 1cceac5984da..12c799412c5d 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -829,7 +829,7 @@ static void __init kvm_guest_init(void) if (kvm_para_has_feature(KVM_FEATURE_ASYNC_PF_INT) && kvmapf) { static_branch_enable(&kvm_async_pf_enabled); - alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, asm_sysvec_kvm_asyncpf_interrupt); + sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_kvm_asyncpf_interrupt); } #ifdef CONFIG_SMP diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index e430a8c47931..9040c7f01c93 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -1536,6 +1536,12 @@ static system_interrupt_handler system_interrupt_handlers[NR_SYSTEM_VECTORS] = { #undef SYSV +void set_sysvec_handler(unsigned int i, system_interrupt_handler func) +{ + BUG_ON(i >= NR_SYSTEM_VECTORS); + system_interrupt_handlers[i] = func; +} + #endif /* CONFIG_X86_64 */ void __init trap_init(void) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index c7715f8bd452..16d51338e1f8 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #include #endif @@ -2249,7 +2250,7 @@ static __init void xen_alloc_callback_vector(void) return; pr_info("Xen HVM callback vector for event delivery is enabled\n"); - alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, asm_sysvec_xen_hvm_callback); + sysvec_install(HYPERVISOR_CALLBACK_VECTOR, sysvec_xen_hvm_callback); } #else void xen_setup_callback_vector(void) {} -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573963.899142 (Exim 4.92) (envelope-from ) id 1qQlMd-0007RJ-9M; Tue, 01 Aug 2023 09:08:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573963.899142; Tue, 01 Aug 2023 09:08:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMd-0007R1-5h; Tue, 01 Aug 2023 09:08:23 +0000 Received: by outflank-mailman (input) for mailman id 573963; Tue, 01 Aug 2023 09:08:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGo-0005CK-L6 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:22 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1fc97179-304a-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:02:21 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:14 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:13 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fc97179-304a-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880541; x=1722416541; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=X4MZTo9+yUn1bPdeMYVQLWvNe1DyIq6KwUj9R7l5YRg=; b=iE4ZBWN6FHKfIHdRVuSxtVHMjl6rKHVKxWjV3i3+NMDwCuCuSPo1SE2o tbwfRZr4CDSKJZznO7cfD4DArrmrdNaLwV++uBocdEWEVABIg0+kARtq1 AYapsDpfvXA3IahW9maEcnKuCbtEUO9K9zLhv4xR9pMpFdST6eJMObiy0 FuXobJdqiFZpDvtZxDdR2vAVcMr2vFYSGTJ7LgYMjnKWoPiu7f9ZXQ3fq JN+DOAtcjNGb84R2xguwuTwWxA3Ff7zwa7IHHpGImQh/52aKIvfDuOLdI yAduIZWinRzGln5NwRszHvaGuLpmrBTSG2PG7oJhTU51CszU3s6ZV42e5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082882" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082882" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217090" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217090" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 25/36] x86/traps: Add a system interrupt handler table for system interrupt dispatch Date: Tue, 1 Aug 2023 01:33:07 -0700 Message-Id: <20230801083318.8363-26-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: "H. Peter Anvin (Intel)" On x86, external interrupts can be categorized into two groups: 1) System interrupts 2) External device interrupts All external device interrupts are directed to the common_interrupt(), which, in turn, dispatches these external device interrupts using a per-CPU external device interrupt dispatch table vector_irq. To handle system interrupts, a system interrupt handler table needs to be introduced. This table enables the direct dispatching of a system interrupt to its corresponding handler. As a result, a software-based dispatch function will be implemented as: void external_interrupt(struct pt_regs *regs) { u8 vector = regs->vector; if (is_system_interrupt(vector)) system_interrupt_handlers[vector_to_sysvec(vector)](regs); else /* external device interrupt */ common_interrupt(regs); } Signed-off-by: H. Peter Anvin (Intel) Co-developed-by: Xin Li Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v8: * Remove junk code that assumes no local APIC on x86_64 (Thomas Gleixner). Changes since v5: * Initialize system_interrupt_handlers with dispatch_table_spurious_interrupt() instead of NULL to get rid of any NULL check (Peter Zijlstra). --- arch/x86/kernel/traps.c | 50 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 49dd92458eb0..e430a8c47931 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -1488,6 +1488,56 @@ DEFINE_IDTENTRY_SW(iret_error) } #endif +#ifdef CONFIG_X86_64 + +static void dispatch_table_spurious_interrupt(struct pt_regs *regs) +{ + dispatch_spurious_interrupt(regs, regs->vector); +} + +#define SYSV(x,y) [(x) - FIRST_SYSTEM_VECTOR] = y + +static system_interrupt_handler system_interrupt_handlers[NR_SYSTEM_VECTORS] = { + [0 ... NR_SYSTEM_VECTORS-1] = dispatch_table_spurious_interrupt, +#ifdef CONFIG_SMP + SYSV(RESCHEDULE_VECTOR, dispatch_table_sysvec_reschedule_ipi), + SYSV(CALL_FUNCTION_VECTOR, dispatch_table_sysvec_call_function), + SYSV(CALL_FUNCTION_SINGLE_VECTOR, dispatch_table_sysvec_call_function_single), + SYSV(REBOOT_VECTOR, dispatch_table_sysvec_reboot), +#endif + +#ifdef CONFIG_X86_THERMAL_VECTOR + SYSV(THERMAL_APIC_VECTOR, dispatch_table_sysvec_thermal), +#endif + +#ifdef CONFIG_X86_MCE_THRESHOLD + SYSV(THRESHOLD_APIC_VECTOR, dispatch_table_sysvec_threshold), +#endif + +#ifdef CONFIG_X86_MCE_AMD + SYSV(DEFERRED_ERROR_VECTOR, dispatch_table_sysvec_deferred_error), +#endif + +#ifdef CONFIG_X86_LOCAL_APIC + SYSV(LOCAL_TIMER_VECTOR, dispatch_table_sysvec_apic_timer_interrupt), + SYSV(X86_PLATFORM_IPI_VECTOR, dispatch_table_sysvec_x86_platform_ipi), +# ifdef CONFIG_HAVE_KVM + SYSV(POSTED_INTR_VECTOR, dispatch_table_sysvec_kvm_posted_intr_ipi), + SYSV(POSTED_INTR_WAKEUP_VECTOR, dispatch_table_sysvec_kvm_posted_intr_wakeup_ipi), + SYSV(POSTED_INTR_NESTED_VECTOR, dispatch_table_sysvec_kvm_posted_intr_nested_ipi), +# endif +# ifdef CONFIG_IRQ_WORK + SYSV(IRQ_WORK_VECTOR, dispatch_table_sysvec_irq_work), +# endif + SYSV(SPURIOUS_APIC_VECTOR, dispatch_table_sysvec_spurious_apic_interrupt), + SYSV(ERROR_APIC_VECTOR, dispatch_table_sysvec_error_interrupt), +#endif +}; + +#undef SYSV + +#endif /* CONFIG_X86_64 */ + void __init trap_init(void) { /* Init cpu_entry_area before IST entries are set up */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:08:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:08:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.573965.899152 (Exim 4.92) (envelope-from ) id 1qQlMg-0007t5-Mk; Tue, 01 Aug 2023 09:08:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 573965.899152; Tue, 01 Aug 2023 09:08:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlMg-0007sy-JY; Tue, 01 Aug 2023 09:08:26 +0000 Received: by outflank-mailman (input) for mailman id 573965; Tue, 01 Aug 2023 09:08:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlGn-0005E5-0i for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:02:21 +0000 Received: from mgamail.intel.com (unknown [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d523a12-304a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:02:19 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:02:10 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 02:02:09 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d523a12-304a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690880539; x=1722416539; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dQPbDjEqQWsCazdenr4wm1/cp/YJX7zOnAx3X5niG4Q=; b=n+rYQuhcIvzNJLmsXBEw8Lwsem76O8IpiNHXC+Nr3gsLSUuUdShApJMs vDqLN06+yrUsgLryFPnaC+Xc8GWMeIaVU7lbuhbmce1nybQ8TR9xHE9nX k/mvLKHP7/+m5rrtj/dYUeE1ynS1KMayUTi/siF/crjn7YGkL1fKHVPlQ GmOHsQAufB/AplysljpMC39cfVZLOWmLx0eEXXCx6T4b7cIIqTPY+efwS 1XaVjRKAC2vU2E/cwY5eRD8hVduFYOhX4C1tgsoVMb40MVuPwkdBsEDna iD9wwhNx1fS6TyMwHG9GWVRMdcjTAiIoHem+MtO7kOeVStbKxQfgy7CT5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433082746" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433082746" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="975217074" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="975217074" From: Xin Li To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Xin Li , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: [PATCH RESEND v9 21/36] x86/fred: Add a machine check entry stub for FRED Date: Tue, 1 Aug 2023 01:33:03 -0700 Message-Id: <20230801083318.8363-22-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a machine check entry stub for FRED. Tested-by: Shan Kang Signed-off-by: Xin Li --- Changes since v5: * Disallow #DB inside #MCE for robustness sake (Peter Zijlstra). --- arch/x86/include/asm/fred.h | 1 + arch/x86/kernel/cpu/mce/core.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index 2a7c47dfd733..f559dd9dc4f2 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -115,6 +115,7 @@ typedef DECLARE_FRED_HANDLER((*fred_handler)); DECLARE_FRED_HANDLER(fred_exc_nmi); DECLARE_FRED_HANDLER(fred_exc_debug); DECLARE_FRED_HANDLER(fred_exc_page_fault); +DECLARE_FRED_HANDLER(fred_exc_machine_check); #endif /* __ASSEMBLY__ */ diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index b8ad5a5b4026..98456e20f155 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -52,6 +52,7 @@ #include #include #include +#include #include "internal.h" @@ -2118,6 +2119,20 @@ DEFINE_IDTENTRY_MCE_USER(exc_machine_check) exc_machine_check_user(regs); local_db_restore(dr7); } + +#ifdef CONFIG_X86_FRED +DEFINE_FRED_HANDLER(fred_exc_machine_check) +{ + unsigned long dr7; + + dr7 = local_db_save(); + if (user_mode(regs)) + exc_machine_check_user(regs); + else + exc_machine_check_kernel(regs); + local_db_restore(dr7); +} +#endif #else /* 32bit unified entry point */ DEFINE_IDTENTRY_RAW(exc_machine_check) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:12:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:12:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574000.899161 (Exim 4.92) (envelope-from ) id 1qQlQp-000247-9R; Tue, 01 Aug 2023 09:12:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574000.899161; Tue, 01 Aug 2023 09:12:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlQp-000240-6m; Tue, 01 Aug 2023 09:12:43 +0000 Received: by outflank-mailman (input) for mailman id 574000; Tue, 01 Aug 2023 09:12:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlQo-00023t-HN for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:12:42 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20605.outbound.protection.outlook.com [2a01:111:f400:7eaf::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 912da532-304b-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:12:41 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB6911.eurprd04.prod.outlook.com (2603:10a6:803:12e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 09:12:37 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 09:12:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 912da532-304b-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ys+2K/JN4yXCRCYGR1ixspZmF2JVpM2ouHjctoWbP+4rH6UvDpdYzudYjD0Da6zJ72VDRAcrw/AGZL83qeBOFXQOkN/0TqdXdDnp7VwQjZOYfczZaEY4Eb9UeYrArJtX89e1rD9kBi5aMc14cQNGtc5+3/5s5sB9EdWKuMU1qbF+2rv4ErVWujUI5qvRqX4HDBSpgAHJ+JCQC3lgIufixMwpknGQUJOpZj9lG8stZUcZaWiTf10e1ODcrc71X+vONyBrYrZ2jzBtA6AFmJ88iiZ3yZA7psf6Reo0mnffHKhk+MBSi8oOvDyWz0PgSujngO/BB9RzRiUtGRTQZpgifg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EHKD4iMmkPdgbq5iQ88Y4kY4iH5j/1SDkoXotYoUXAs=; b=VBhMHQ7fC7CD9Y3OGBwCju+CzEdsrNQbVCNQHvDRA22q4LF2H9TYSuNUEf+fkSMLQBkbdZWUZnRZEcZ7XH2hRJNDPKZtxWNf1wY9HqLUO7W6nCauKbyjYtlK4aCZhKc4D7K5JBeFJHnwlB7uwWVnIL7DwhXmymGt3Kn4g0ADzc0oMaYuUeyMArfVx2zkmqScfCRnrBVFIsINyg9zEG0bVJBZ14ks/ktH/8CMDtcklGB75ykaYo8fEJ6ExSbA4+CxIcdHXx5RkvGOcVHiUwqQuf4YZfBF7cWKEX1vWDLV3Icu7wf5y+b0ffYSeYVNP37FB8FND5Qo0H3jeJA8zLWB2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHKD4iMmkPdgbq5iQ88Y4kY4iH5j/1SDkoXotYoUXAs=; b=nEutwpJKJzRRSEaKKBW7rBqr+gXCZP5TD7FJ5ti2QIdm6eU7mcf2cvGM1oGBwdeSIn0uRmhzshvZ9I/5gtyBSOTwm4dEUsfgOUhrO/Agfg3VRpifpmemjPLTH9hoQxGZikfu9MY+sxqsfEzY0vHLLBkyTcWIFXKq+ZQP1ue4fS98j0iSWltIU0A4OFPz4gS1N5PAn3ww7T/Vv3lcaiYoAhoEYwdMQbOwNurw3hpLR6kTaMwxMZ9+BdNgXGT/Svm4dUQF9dYcKuxOwCAk1SVYS0VxTRcSxJzPDPID5j0MxbMd4TUdiK02awNp6oxH9ubmFu0zKC/ghFC8lbK1mlBMzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <98f49c19-67e3-7a79-7fc3-02d065f50c79@suse.com> Date: Tue, 1 Aug 2023 11:12:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v5 2/2] xen/riscv: introduce identity mapping Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <911eba8e-a92b-896c-e5dc-e54dcd570664@suse.com> <0bcbcb53db1f0c9ae279347c3f5c762e5324dd15.camel@gmail.com> From: Jan Beulich In-Reply-To: <0bcbcb53db1f0c9ae279347c3f5c762e5324dd15.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB6911:EE_ X-MS-Office365-Filtering-Correlation-Id: d8aa5858-a458-4383-df15-08db926f72c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3dEYwOXZQAiZ5RPpEIqAiWiW2c3LZR1uTI3xjWxH7ChqKqIyz5PRbkMfGPnhupEwaDirZysmKClTE6lKKgNjDWhfR7RpS4WjBIf/Crfckz2cAeauwj9i6KkcgjmF2kmvxDUtLmgZUDi1e3zTohvfcBvwLqa+GzPpn39e3nEVcEJvJwkEw7XIA0bxIZ/CpAbccqHjCoJi6e3JVjn8wpLaauRwSXNvJuGALvKQX2kBKlooUkAGTl3llOUHKLUV4NVvBuajPwYv0YBQ3nTJlmP4DVjB3ySG7E45rqzYtcB9+xMDzEbppztj44jvZvb9JzCoPP2+glvwHM6KmeWtLZx9W7+3HAqjxvZsqDHPFI2javhqaolRvmoAEhLp51gE5rrRCt43+1zKHg5bgSJrjCb73XJuW5VlORemMIxkFzFU5xAZedCWZzzjmgQvW7LVWrFlw950v3rRejncjf9YF+NHbn2CCWo8rxddrcqJnyIOd70syWcihbx2qYSUg1/KMQj1ys4vZKmaL2NaqSPiqt8Shx26hDNlFJLWLme5yK5pUFL1ZiyOL0ZNN2cSHxAFMARBZgNTSm0/cqT05tT2QcczJZOQGG8CfuCw5Bcy70K4E8KL8WQ2t0sjUq1iigAF9umTgPo3eybvg62jiqGAJne83Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(346002)(366004)(376002)(451199021)(6512007)(31686004)(6666004)(5660300002)(186003)(66946007)(66476007)(66556008)(4326008)(6916009)(478600001)(54906003)(6486002)(316002)(41300700001)(8936002)(8676002)(26005)(38100700002)(31696002)(86362001)(53546011)(36756003)(2906002)(6506007)(2616005)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmZjb1l5Q1BlL1hncGlOWHRxM0Q1VjBqNnZHNnEvbW5oU3RSWU9YUXJ4dytI?= =?utf-8?B?eVMxd0NJdUpmMWZWZkVzcit4MVUyVVNHd2xodmtzZG1QUVVuQm94UnJJblA2?= =?utf-8?B?WVpVcU5CekZ0UHVJK24zOVExdnBPQ0hhWjNReUo4WlJUWXRwdkhkdXlidHk4?= =?utf-8?B?bWw2QVA3MCs3RS85UHFMM0xsWWl2MFBsalRmZlRycmlYWDdsTzEyRmVlNDl4?= =?utf-8?B?VUltTjZnWG4zdmJhemxLTk15eUdnV2IzTzBUcU8xRitJWmY3TGpJbUxTMmU4?= =?utf-8?B?am5jZEhCTHpzRnVFdjlaTU5TZFJUTVBIMG9rSUE3QlZVZWVJWlcyT2VncU50?= =?utf-8?B?NXRFZTZLeUlkRjkwczU4eEFNK3hnNkhEbU56enJNTGdCQ211RnJmYXBTQ0l0?= =?utf-8?B?SXMzNHEvWmJXL2xXVEdBdDd5WW9tdzdaZ0VSclozcmRhNlVzYXFSVnF4Vkli?= =?utf-8?B?QlBaWmJrTUNGbmU0d2Fzcm9TdmJRR0Q1TWFTOVBLVWhwZ280ejg3QzZJd1Ja?= =?utf-8?B?MlkvbnZzVVJ5RGE4NEdlTEZXZDRIcEZFWG1lN3IrWFczVXE0WjU2T1RDalRw?= =?utf-8?B?VFJBSUFoT1FybFZ0UVRvWlA1Z0tBMHdwd0tTbG5odXcwTy9xTnY1UzFDQWhk?= =?utf-8?B?Y3BGUTV3Y1FQOVR5Y09vYjVjV2NFZUJ1Um9CUmw4bmxzV3pITzh0YVBscldX?= =?utf-8?B?ZXh6VWhoYUdOcmIxSjJneFkvRHYyS2VmVFk1VjJreTk5dTVOdUtCRG5nWFNh?= =?utf-8?B?dGxDVDFYb2hnQ0ZrRlpGbEo1T0dQTjVyVmQ4ODJxdWxRZHNYV29XVGNpUzFr?= =?utf-8?B?cy9hQnd0TjZtU3VsNS9WOUVzS3ZGeVB6bzdhbnU0NUhVbFJJamY5VUpqQldr?= =?utf-8?B?UHNVN2R3MWRHQXlWakxCOEM1RnpSRmhRY1pyUVo0RE8zQjg1KzY3Y2ZSUk80?= =?utf-8?B?Y1NJc2Q4SVNzaFJNd0thNno2a08xL3N3UTQ5Z0JHdTZtUDE0VGRXSE1aZEZI?= =?utf-8?B?cCsxUHFsRk13TFFSajFsZUIwZkJFeXNYZXVNWWdXRzErRmZlR3hoMmt0eUVK?= =?utf-8?B?empmSlpCMmZoWlcxcFo0QUJjaDVLVFJLMmdWZEJrSFJoWUMvK3B0SjFIamEz?= =?utf-8?B?MW83bDJPTCtLQ1R1SGlVeCt4RFNFalZKYmR1ZGJmNk5TMGpqbWE4Uy9WdVYr?= =?utf-8?B?NE5xcGtYV1R6b1NuSDVhc1JTU1R6OWx5aDRTT1A5MlN0NkE4TDFveUtua28v?= =?utf-8?B?ZGk5eXd6b01uQ3d4Q01QTDM0aFVzRGdtRGRtdUV0Y00vbHlXbUs1MURxQllj?= =?utf-8?B?bEJUcGd4b3MwSlpLdDhHdmtvNXVJc3ZjVUtOQ3JWZFdCZGJFSnNpd05JM2xR?= =?utf-8?B?THBzc0gyQ2xyODJtaERJcDdDT1pRcmpTVFBOaGVkeHlCMk5rdGxBVU8zREdo?= =?utf-8?B?MnJOT3FNTWRNbm0zKzFXWG1PYXFJM01vUVdna2FrcnZkdUl5bEdKSnhyd2xm?= =?utf-8?B?MUNwUEplTHplRU9TeGhaNHlGVnpCWXpxYXhydzhwUExEZnBsWjZlR09lMGtV?= =?utf-8?B?NDkwYngrMmwrdjZOUnNOSHZrOG5vYVFuSGJXVGV5OGVSWStaaVpDdTI4WDF6?= =?utf-8?B?YmltN2xnZTFOVUhHYmRHR1VFS0tONlRFR0YyUWpDS0w1UTc5R29BcnZSc2to?= =?utf-8?B?YnREKzN3Q1cxQWh0a1cxazIvNE5XT09rNHNzSWowV1IwVHF3ejluVDcrdjVR?= =?utf-8?B?MndDNEljZUx3R0FDMXpxbjAzdWRJb3l3Q3V0eC9RSFM3QTcxczNMY1JxanRV?= =?utf-8?B?bEZneFFaTGNDMjQ2N2crQVlHMmxWUlQ3Q0t0UXVqZ2tWcDdQZm5Zb3JPZlFK?= =?utf-8?B?YmFpQmdWNVpaZ1NWL01CV1JvSEdiVEU0c0pJMFRDallaSExBZ2xBLzNCR3lT?= =?utf-8?B?MlVoUnM0VmU1WHB1TVFBWVJqWWhZek1SRGM5M0d1MklKS2FyT2IyTUFZcVNB?= =?utf-8?B?QkxEWEpEVXB6OVRCZTE0dXlWQ3IrL055dFB2MFY1VDBHdHBDZi9xaDNJMzBi?= =?utf-8?B?b0J6c240dWZWcGt1T0ZFcERDc1lvTDhTOTl6dVFmRlJLSlc2d2d6SjN3cEF5?= =?utf-8?Q?k8TbnE6grzlvtZJwpRDNUmQtt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8aa5858-a458-4383-df15-08db926f72c1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 09:12:36.9592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f0QFHS1xFsVuzR03QmOxg3+zR4Y+oUwzTLcLacumwj9kzHASgAUXH0mlgN8imBqxm0h5iLb3WPrLOfVj6hwzvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6911 On 01.08.2023 10:50, Oleksii wrote: > On Mon, 2023-07-31 at 16:07 +0200, Jan Beulich wrote: >> Everything else looks good to me now, but will of course want a >> maintainer looking over. > Would it be better to send a new version now or wait for a response > from other maintainers? Hard to tell. Maybe send a new version in the hope that that's what then can go in. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:46:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:46:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574015.899173 (Exim 4.92) (envelope-from ) id 1qQlxW-0006nG-Sa; Tue, 01 Aug 2023 09:46:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574015.899173; Tue, 01 Aug 2023 09:46:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlxW-0006n9-Nr; Tue, 01 Aug 2023 09:46:30 +0000 Received: by outflank-mailman (input) for mailman id 574015; Tue, 01 Aug 2023 09:46:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlxV-0006mz-Bl for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:46:29 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 485ea312-3050-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:46:26 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4fe15bfb1adso8613317e87.0 for ; Tue, 01 Aug 2023 02:46:27 -0700 (PDT) Received: from [192.168.203.100] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id x9-20020ac259c9000000b004fe1e7f98c2sm2107420lfn.146.2023.08.01.02.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 02:46:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 485ea312-3050-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690883187; x=1691487987; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=3kD4jwF4XYlZmlfx9xBip173VfVUmrJboJ5I19wteY0=; b=brsgSITzajd9TMe0Ci2qzsiwWC2nDEujBAarpIBjwNEiICODXj9DTAjeTxAiJfGHYg 9Wc86erRKrlfpn35asei7lQMegHZXBpAqgdBoNYuKspCPAysgPEAM/iqqxMJ4+M1YxoD MtHR0bn8tmL4tTIH8i6kGfZ2fXHYjtd1X/3fk6OjX34X8ZiGVrktD+QYJrrDUQ+U4nn7 dOplxamojkIiQOgT3xVY/7fB3/7a6M7UP3XLCiPwKQ+b0ycDvYheKp5c+N4hUfcYQu3a nW+Fs11AoXxxRwBCtknSNJYP8Nz10/mwyriv5mmvn8DlbevuGyZkolE5F99S+8Q2CGgr JdjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690883187; x=1691487987; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3kD4jwF4XYlZmlfx9xBip173VfVUmrJboJ5I19wteY0=; b=ZFN+3QHy6Ltt8g2KpSSDWndmxkc6eVxr5E2cnfVHJRm2NmiSmjQukk1nSZlSIZlGst fDQzDiWlgmUmhnH7c0X+GtzcskFUkCfaxBE0lD1IMDxLgcPLrSLPP/PcrqXtfzkfAJF9 8dSazWcP91l25fuYnH4hcAOB7Ai3e/WDJtoCmUKsFDo2lSt1htmjYOrb0prsWu3T2Hal xPH37d6CRSv0RUcmFcSTaMAJZHc5LaFAz+b8bfZJhB5DzzvDuanoSkONuZbcMgtWQa6i QNrW5p7Wd25ak6zSIE6XWaZQVgfqNAwNnKg6BWnSr6HlPhcI1nBVYigGxgn3WsKQyTyv 3LdQ== X-Gm-Message-State: ABy/qLZf+6wW0shoVOE/HNMsoP8Z96k4D1WzB3cvJtMftDMfp20Danlv QukuAKizeRUSmjTd00SnjvQ= X-Google-Smtp-Source: APBJJlGmiUB+yvAC5Y/tYdMZrMzLmR8IzH7NzrAJVlaQKJrgVJND5nhEUYvS3R4HA8f+ASemjtjF8Q== X-Received: by 2002:ac2:5f5a:0:b0:4fe:590:53ca with SMTP id 26-20020ac25f5a000000b004fe059053camr1451707lfz.4.1690883186273; Tue, 01 Aug 2023 02:46:26 -0700 (PDT) Message-ID: <75cd58c00ac6b9f49f1656d6793888ef470c9eff.camel@gmail.com> Subject: Re: [PATCH v4 1/1] ns16550: add support for polling mode when device tree is used From: Oleksii To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Date: Tue, 01 Aug 2023 12:46:25 +0300 In-Reply-To: <98596d8e-6c11-715a-7842-910806abda77@suse.com> References: <6e8f243284b53a9c56e7faf5e0e5ee5e20de9958.1690475512.git.oleksii.kurochko@gmail.com> <98596d8e-6c11-715a-7842-910806abda77@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 On Mon, 2023-07-31 at 15:24 +0200, Jan Beulich wrote: > On 27.07.2023 18:45, Oleksii Kurochko wrote: > > @@ -654,6 +674,9 @@ static void ns16550_init_common(struct ns16550 > > *uart) > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0 /* Default lsr_mask =3D UART_LSR_THRE */ > > =C2=A0=C2=A0=C2=A0=C2=A0 uart->lsr_mask=C2=A0 =3D UART_LSR_THRE; > > + > > +=C2=A0=C2=A0=C2=A0 if ( strstr(opt_com1, "poll") || strstr(opt_com2, "= poll") ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uart->intr_works =3D pollin= g; > > =C2=A0} >=20 > A non-__init function may not reference __initdata objects. But > strstr() > is too lax anyway, and you also shouldn't check the wrong port's > options. > You want to recognize "poll" _only_ where all other command line > options > are processed. Just to confirm, do you mean that I should use parse_positional() ( or something similar ) for the device-tree method of initializing ns16550? I checked the polling behavior as described above because parse_positional() is utilized solely for X86. It appears that command line options are parsed only in the case of x86. >=20 > Also may I remind you that extending command line options requires > their > doc to also be updated? Thank you for the reminder. It seems I misunderstood which doc I need to update. I believed you were referring to the comment above the declaration of opt_com1[]. I think you meant xen-command-line.pandoc. >=20 > > @@ -1333,9 +1356,13 @@ pci_uart_config(struct ns16550 *uart, bool_t > > skip_amt, unsigned int idx) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uart->irq =3D 0; > > =C2=A0#endif > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( !uart->irq ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uart->intr_works =3D polling; > > + > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk(XENLOG_INFO > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 "ns16550: %pp: no legacy IRQ, using > > poll mode\n", > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 &PCI_SBDF(0, b, d, f)); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 } >=20 > I'm okay to leave it at this for now, since this way at least nothing > regresses that was working before. I'm not convinced this is all > correct, but that's a largely separate (and pre-existing) issue then. >=20 > > @@ -1791,8 +1808,11 @@ static int __init > > ns16550_uart_dt_init(struct dt_device_node *dev, > > =C2=A0=C2=A0=C2=A0=C2=A0 } > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0 res =3D platform_get_irq(dev, 0); > > -=C2=A0=C2=A0=C2=A0 if ( ! res ) > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -EINVAL; > > +=C2=A0=C2=A0=C2=A0 if ( res < 0 ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk("there is no interru= pt property, polling will be > > used\n"); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uart->intr_works =3D pollin= g; > > +=C2=A0=C2=A0=C2=A0 } > > =C2=A0=C2=A0=C2=A0=C2=A0 uart->irq =3D res; >=20 > Shouldn't you avoid writing uart->irq when res is negative? I think you are right, and I missed that. I'll update it in a new patch version. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:46:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:46:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574016.899182 (Exim 4.92) (envelope-from ) id 1qQlxy-0007GZ-3x; Tue, 01 Aug 2023 09:46:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574016.899182; Tue, 01 Aug 2023 09:46:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlxy-0007GS-0c; Tue, 01 Aug 2023 09:46:58 +0000 Received: by outflank-mailman (input) for mailman id 574016; Tue, 01 Aug 2023 09:46:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQlxw-0007G2-JC for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:46:56 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58787a72-3050-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:46:55 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id EE4FA4EE0737; Tue, 1 Aug 2023 11:46:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58787a72-3050-11ee-b259-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH] xen/spinlock: address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Tue, 1 Aug 2023 11:46:46 +0200 Message-Id: <29b6a47a2711f065c02a3d2d94e1a201986cf015.1690882872.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional changes. Signed-off-by: Federico Serafini --- xen/include/xen/spinlock.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h index 0a02a527dc..4a1c155e96 100644 --- a/xen/include/xen/spinlock.h +++ b/xen/include/xen/spinlock.h @@ -125,8 +125,9 @@ struct lock_profile_qhead { } while(0) void _lock_profile_register_struct( - int32_t, struct lock_profile_qhead *, int32_t); -void _lock_profile_deregister_struct(int32_t, struct lock_profile_qhead *); + int32_t type, struct lock_profile_qhead *qhead, int32_t idx); +void _lock_profile_deregister_struct(int32_t type, + struct lock_profile_qhead *qhead); #define lock_profile_register_struct(type, ptr, idx) \ _lock_profile_register_struct(type, &((ptr)->profile_head), idx) @@ -178,7 +179,7 @@ typedef struct spinlock { #define spin_lock_init(l) (*(l) = (spinlock_t)SPIN_LOCK_UNLOCKED) void _spin_lock(spinlock_t *lock); -void _spin_lock_cb(spinlock_t *lock, void (*cond)(void *), void *data); +void _spin_lock_cb(spinlock_t *lock, void (*cb)(void *), void *data); void _spin_lock_irq(spinlock_t *lock); unsigned long _spin_lock_irqsave(spinlock_t *lock); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:57:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:57:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574024.899192 (Exim 4.92) (envelope-from ) id 1qQm8H-0000wY-2B; Tue, 01 Aug 2023 09:57:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574024.899192; Tue, 01 Aug 2023 09:57:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8G-0000wR-Vb; Tue, 01 Aug 2023 09:57:36 +0000 Received: by outflank-mailman (input) for mailman id 574024; Tue, 01 Aug 2023 09:57:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8F-0000wJ-9y for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:57:35 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d647499f-3051-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:57:34 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 81CB64EE0737; Tue, 1 Aug 2023 11:57:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d647499f-3051-11ee-b259-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 0/4] automation/eclair: improvements to the ECLAIR integration Date: Tue, 1 Aug 2023 11:57:00 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series contains a series of improvements to the ECLAIR integration. The integration was not initially intended to operate in tag pipelines, for this reason the analyses fail when triggered from xen-project/patchew. This series add support for such pipelines. The summary() reporting facility in action.helpers has been partially rewritten to make it more readable and easier to follow. The utility has been extended to print directs links to the findings in the GitLab console log. Six new ECLAIR jobs have been added, these jobs run only when triggered by a scheduled pipeline. This series avoids failures when a merge point with xen-project/xen(staging) is not found. Simone Ballarin (4): automation/eclair: add support for tag pipelines automation/eclair: add direct link to reports automation/eclair: add scheduled pipelines automation/eclair: avoid failure in case of missing merge point .../eclair_analysis/ECLAIR/action.helpers | 84 ++++++++++++++----- .../eclair_analysis/ECLAIR/action.settings | 30 ++++--- automation/gitlab-ci/analyze.yaml | 65 +++++++++++++- 3 files changed, 145 insertions(+), 34 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:58:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:58:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574028.899201 (Exim 4.92) (envelope-from ) id 1qQm8i-0001UP-Ej; Tue, 01 Aug 2023 09:58:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574028.899201; Tue, 01 Aug 2023 09:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8i-0001UG-Br; Tue, 01 Aug 2023 09:58:04 +0000 Received: by outflank-mailman (input) for mailman id 574028; Tue, 01 Aug 2023 09:58:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8h-0001NH-9v for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:58:03 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e62f2a7e-3051-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:58:00 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 1D9A84EE0737; Tue, 1 Aug 2023 11:58:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e62f2a7e-3051-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 1/4] automation/eclair: add support for tag pipelines Date: Tue, 1 Aug 2023 11:57:01 +0200 Message-Id: <5e79b954062385c4d765c32347bcb45896d3ed5e.1690881495.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ECLAIR jobs fail when triggered by tag pipelines (e.g. xen-project/patchew/xen). This patch extends the integration to support such pipelines. Signed-off-by: Simone Ballarin --- .../eclair_analysis/ECLAIR/action.settings | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings index 96426811a8..71c10d5141 100644 --- a/automation/eclair_analysis/ECLAIR/action.settings +++ b/automation/eclair_analysis/ECLAIR/action.settings @@ -41,7 +41,7 @@ github) push | workflow_dispatch) event=push # Extract the branch name from "refs/heads/" - branch="${GITHUB_REF#refs/heads/}" + ref="${GITHUB_REF#refs/heads/}" headCommitId="${GITHUB_SHA}" pushUser="${GITHUB_ACTOR}" ;; @@ -75,7 +75,13 @@ gitlab) ;; push | pipeline | web) event=push - branch="${CI_COMMIT_BRANCH}" + if [ -n "${CI_COMMIT_BRANCH:-}" ]; then + ref_kind=branch + ref="${CI_COMMIT_BRANCH}" + else + ref_kind=tag + ref="${CI_COMMIT_TAG}" + fi headCommitId="${CI_COMMIT_SHA}" pushUser="${GITLAB_USER_NAME}" ;; @@ -99,7 +105,7 @@ jenkins) jenkinsBotToken="${ECLAIR_BOT_TOKEN:-}" event=push - branch="${GIT_BRANCH}" + ref="${GIT_BRANCH}" headCommitId="${GIT_COMMIT}" pushUser=$(git show --pretty='format:%aN' -s) ;; @@ -111,7 +117,7 @@ esac if [ "${event}" = "push" ] && [ -n "${autoPRBranch:-}" ]; then # AUTO PR Feature enabled - if ! [ "${branch}" = "${autoPRBranch}" ] || + if ! [ "${ref}" = "${autoPRBranch}" ] || ! [ "${repository}" = "${autoPRRepository}" ]; then event=auto_pull_request fi @@ -123,17 +129,17 @@ pull_request) jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pullRequestUser} wants to merge ${pullRequestHeadRepo}:${pullRequestHeadRef} (${headCommitId}) into ${pullRequestBaseRef} (${baseCommitId})" ;; push) - subDir="${branch}" - jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: branch ${branch} (${headCommitId})" - badgeLabel="ECLAIR ${ANALYSIS_KIND} ${branch}${variantHeadline} #${jobId}" + subDir="${ref}" + jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${ref_kind} ${ref} (${headCommitId})" + badgeLabel="ECLAIR ${ANALYSIS_KIND} ${ref}${variantHeadline} #${jobId}" ;; auto_pull_request) git remote remove autoPRRemote || true git remote add autoPRRemote "${autoPRRemoteUrl}" git fetch -q autoPRRemote - subDir="${branch}" + subDir="${ref}" baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" HEAD) - jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pushUser} wants to merge ${repository}:${branch} (${headCommitId}) into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" + jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pushUser} wants to merge ${repository}:${ref} (${headCommitId}) into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" ;; *) echo "Unexpected event ${event}" >&2 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:58:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:58:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574029.899212 (Exim 4.92) (envelope-from ) id 1qQm8k-0001ka-MG; Tue, 01 Aug 2023 09:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574029.899212; Tue, 01 Aug 2023 09:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8k-0001kR-JD; Tue, 01 Aug 2023 09:58:06 +0000 Received: by outflank-mailman (input) for mailman id 574029; Tue, 01 Aug 2023 09:58:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8j-0001NH-AG for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:58:05 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7637744-3051-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:58:02 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 2029F4EE0740; Tue, 1 Aug 2023 11:58:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7637744-3051-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 2/4] automation/eclair: add direct link to reports Date: Tue, 1 Aug 2023 11:57:02 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds direct links to the analysis findings in the console log. Signed-off-by: Simone Ballarin --- .../eclair_analysis/ECLAIR/action.helpers | 84 ++++++++++++++----- 1 file changed, 65 insertions(+), 19 deletions(-) diff --git a/automation/eclair_analysis/ECLAIR/action.helpers b/automation/eclair_analysis/ECLAIR/action.helpers index 2ad6428eaa..df9bf2bd11 100644 --- a/automation/eclair_analysis/ECLAIR/action.helpers +++ b/automation/eclair_analysis/ECLAIR/action.helpers @@ -1,17 +1,26 @@ +esc=$(printf '\e') +cr=$(printf '\r') + if [ -n "${GITLAB_CI:-}" ]; then ci=gitlab + eol= + link_start="${esc}[33m" + link_end="${esc}[m" elif [ -n "${GITHUB_ACTION:-}" ]; then ci=github + eol="\\" + link_start= + link_end= elif [ -n "${JENKINS_HOME:-}" ]; then ci=jenkins + eol="
" + link_start= + link_end= else echo "Unexpected CI/CD context" >&2 exit 1 fi -esc=$(printf '\e') -cr=$(printf '\r') - open_section() { id=$1 title=$2 @@ -36,54 +45,86 @@ summary() { case "${ci}" in github) - nl="\\" + eol="\\" ;; gitlab) - nl= + eol= ;; jenkins) - nl="
" + eol="
" ;; *) - nl= + eol= ;; esac + currentDbReportsUrl="${eclairReportUrlPrefix}/fs${jobDir}/PROJECT.ecd;/by_service.html#service&kind" if [ -z "${newReports}" ]; then - fixedMsg= + fixedMsg="No fixed reports as there is no baseline" unfixedMsg="Unfixed reports: ${unfixedReports}" - countsMsg="${unfixedMsg}" + referenceReportsMsgTxt= + referenceReportsMsgLog= else fixedMsg="Fixed reports: ${fixedReports}" unfixedMsg="Unfixed reports: ${unfixedReports} [new: ${newReports}]" - countsMsg="${fixedMsg}${nl} -${unfixedMsg}" + case "${event}" in + pull_request | auto_pull_request) + referenceDbReportsUrl="${eclairReportUrlPrefix}/fs${jobDir}/base/PROJECT.ecd;/by_service.html#service&kind" + reference_kind=base + ;; + push) + referenceDbReportsUrl="${eclairReportUrlPrefix}/fs${jobDir}/prev/PROJECT.ecd;/by_service.html#service&kind" + reference_kind=previous + ;; + *) + echo "Unexpected event ${event}" >&2 + exit 1 + ;; + esac fi + case "${ci}" in jenkins) + if [ -n "${newReports}" ]; then + referenceReportsMsgTxt="Browse ${reference_kind} reports" + fi cat <"${summaryTxt}" -${countsMsg} ${nl} +${fixedMsg}${eol} +${unfixedMsg} ${eol}

${jobHeadline}

-Browse analysis results +Browse analysis summary +Browse current reports +${referenceReportsMsgTxt} EOF ;; *) + if [ -n "${newReports}" ]; then + referenceReportsMsgTxt="Browse ${reference_kind} reports: ${referenceDbReportsUrl}" + fi cat <"${summaryTxt}" Analysis Summary -${jobHeadline}${nl} -${countsMsg}${nl} -[Browse analysis](${indexHtmlUrl}) +${jobHeadline}${eol} +${fixedMsg}${eol} +${unfixedMsg}${eol} +Browse analysis summary: ${indexHtmlUrl} +Browse current reports: ${currentDbReportsUrl} +${referenceReportsMsgTxt} EOF ;; esac + analysisSummaryMsgLog="Browse analysis summary: ${link_start}${indexHtmlUrl}${link_end}" + currentReportsMsgLog="Browse current reports: ${link_start}${currentDbReportsUrl}${link_end}" + if [ -n "${newReports}" ]; then + referenceReportsMsgLog="Browse ${reference_kind} reports: ${link_start}${referenceDbReportsUrl}${link_end}" + fi case ${ci} in github) cat "${summaryTxt}" >"${GITHUB_STEP_SUMMARY}" @@ -93,8 +134,11 @@ EOF # Generate summary and print it (GitLab-specific) cat < Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574030.899222 (Exim 4.92) (envelope-from ) id 1qQm8l-00021w-V0; Tue, 01 Aug 2023 09:58:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574030.899222; Tue, 01 Aug 2023 09:58:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8l-00021k-Rw; Tue, 01 Aug 2023 09:58:07 +0000 Received: by outflank-mailman (input) for mailman id 574030; Tue, 01 Aug 2023 09:58:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8k-0001NH-KZ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:58:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e83784b4-3051-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:58:04 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 8062B4EE0741; Tue, 1 Aug 2023 11:58:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e83784b4-3051-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines Date: Tue, 1 Aug 2023 11:57:03 +0200 Message-Id: <76f3cdddcba485e8124659566b2f992b3b14da17.1690881495.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch introduces six new ECLAIR jobs that run only when triggered by a GitLab scheduled pipeline. Signed-off-by: Simone Ballarin --- .../eclair_analysis/ECLAIR/action.settings | 2 +- automation/gitlab-ci/analyze.yaml | 65 +++++++++++++++++-- 2 files changed, 62 insertions(+), 5 deletions(-) diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings index 71c10d5141..528bc24c72 100644 --- a/automation/eclair_analysis/ECLAIR/action.settings +++ b/automation/eclair_analysis/ECLAIR/action.settings @@ -73,7 +73,7 @@ gitlab) headCommitId="${CI_COMMIT_SHA}" baseCommitId="${CI_MERGE_REQUEST_DIFF_BASE_SHA}" ;; - push | pipeline | web) + push | pipeline | web | schedule) event=push if [ -n "${CI_COMMIT_BRANCH:-}" ]; then ref_kind=branch diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml index 3d8166572b..3325ef9d9a 100644 --- a/automation/gitlab-ci/analyze.yaml +++ b/automation/gitlab-ci/analyze.yaml @@ -8,6 +8,8 @@ ENABLE_ECLAIR_BOT: "n" AUTO_PR_BRANCH: "staging" AUTO_PR_REPOSITORY: "xen-project/xen" + script: + - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}" artifacts: when: always paths: @@ -23,8 +25,6 @@ eclair-x86_64: LOGFILE: "eclair-x86_64.log" VARIANT: "X86_64" RULESET: "Set1" - script: - - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}" allow_failure: true eclair-ARM64: @@ -33,6 +33,63 @@ eclair-ARM64: LOGFILE: "eclair-ARM64.log" VARIANT: "ARM64" RULESET: "Set1" - script: - - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}" + allow_failure: true + +.eclair-analysis:on-schedule: + extends: .eclair-analysis + rules: + - if: $CI_PIPELINE_SOURCE == "schedule" + +eclair-x86_64-Set1:on-schedule: + extends: .eclair-analysis:on-schedule + variables: + VARIANT: "X86_64" + RULESET: "Set1" + ANALYSIS_KIND: "${RULESET}-scheduled" + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" + allow_failure: true + +eclair-x86_64-Set2:on-schedule: + extends: .eclair-analysis:on-schedule + variables: + VARIANT: "X86_64" + RULESET: "Set2" + ANALYSIS_KIND: "${RULESET}-scheduled" + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" + allow_failure: true + +eclair-x86_64-Set3:on-schedule: + extends: .eclair-analysis:on-schedule + variables: + VARIANT: "X86_64" + RULESET: "Set3" + ANALYSIS_KIND: "${RULESET}-scheduled" + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" + allow_failure: true + +eclair-ARM64-Set1:on-schedule: + extends: .eclair-analysis:on-schedule + variables: + VARIANT: "ARM64" + RULESET: "Set1" + ANALYSIS_KIND: "${RULESET}-scheduled" + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" + allow_failure: true + +eclair-ARM64-Set2:on-schedule: + extends: .eclair-analysis:on-schedule + variables: + VARIANT: "ARM64" + RULESET: "Set2" + ANALYSIS_KIND: "${RULESET}-scheduled" + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" + allow_failure: true + +eclair-ARM64-Set3:on-schedule: + extends: .eclair-analysis:on-schedule + variables: + VARIANT: "ARM64" + RULESET: "Set3" + ANALYSIS_KIND: "${RULESET}-scheduled" + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" allow_failure: true -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 09:58:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 09:58:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574031.899232 (Exim 4.92) (envelope-from ) id 1qQm8n-0002J4-6R; Tue, 01 Aug 2023 09:58:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574031.899232; Tue, 01 Aug 2023 09:58:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8n-0002Iu-3S; Tue, 01 Aug 2023 09:58:09 +0000 Received: by outflank-mailman (input) for mailman id 574031; Tue, 01 Aug 2023 09:58:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQm8l-0000wJ-Fv for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:58:07 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9cfcd28-3051-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 11:58:07 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 733144EE0737; Tue, 1 Aug 2023 11:58:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9cfcd28-3051-11ee-b259-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 4/4] automation/eclair: avoid failure in case of missing merge point Date: Tue, 1 Aug 2023 11:57:04 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In the context of an auto pull request, when a common merge point is not found the integration will continue the analysis without failing. Signed-off-by: Simone Ballarin --- automation/eclair_analysis/ECLAIR/action.settings | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings index 528bc24c72..f96368ffc7 100644 --- a/automation/eclair_analysis/ECLAIR/action.settings +++ b/automation/eclair_analysis/ECLAIR/action.settings @@ -138,7 +138,9 @@ auto_pull_request) git remote add autoPRRemote "${autoPRRemoteUrl}" git fetch -q autoPRRemote subDir="${ref}" - baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" HEAD) + if ! baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" HEAD); then + baseCommitId=no_merge_point + fi jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pushUser} wants to merge ${repository}:${ref} (${headCommitId}) into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" ;; *) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 10:00:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 10:00:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574043.899242 (Exim 4.92) (envelope-from ) id 1qQmAa-0003re-JL; Tue, 01 Aug 2023 10:00:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574043.899242; Tue, 01 Aug 2023 10:00:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQmAa-0003rX-Ga; Tue, 01 Aug 2023 10:00:00 +0000 Received: by outflank-mailman (input) for mailman id 574043; Tue, 01 Aug 2023 09:59:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQmAY-0003pU-Vg for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 09:59:58 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20603.outbound.protection.outlook.com [2a01:111:f400:7eaf::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2a36be2c-3052-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 11:59:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB7073.eurprd04.prod.outlook.com (2603:10a6:208:1a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 09:59:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 09:59:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a36be2c-3052-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4VofkmLQJnVK7TtnIiTIP+LEq4uKurD2dvb0A+tzBbPFSF5FzphGjAALSC7uEHEZhgv1A6ToU96MDbEQ1UdREGVnFZGlPGBkNRiFXG04inxAYgPOAdu9KEN7WPLArXb3CKOfh1+1YXGPkXF/f6EmoVHrWh7x2Z2Z9OK0BqAoEDaJcSlK0P3mSi9xS3SrgUPwnD6PcjK7bwAmFKNNlAAoSyWPzoVWn2FSOOTWlDRqxKWCrT82pw/zOK4onkeZQLiSAu2XZHux3xCHq8T27gv1vaC+HbJ0oJ2hbxt9tLvQsWq70Vhk8JqI3KD4I0j2/V4aF/B27XAzRbQ9hsGTgdqDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sy2fHjwQKHBfHzb7HKzlmPo3cQ4nWBIyPbHqvTuASvM=; b=mK9DDPT127gI5dLLOZOZB0XUsKe82EFhIBkdUAOf8vyOgL2nRiqx8Bba5tCKvZbTUr1MCSB7hPUAfXWZoh6rKyioiwkC4RfW7DZUjRrKiveZ0NWhAKxkkh/RhVGRZLg9xzk8Ntx0UVJYSzK8qOyEiDrJcfrLRDnlUdM4jewgLxh/Ooegteehy7RIXV/oHrPRuVPBQ+PwvDmAD/bwZOHNi/7G8zCiiKvo2OomB/y0TllY1AZY0pYTh/pZQqHAjYc2oABceMXntubMk+4wmAIMAybPxNN50pVDWd9ZUo7AQ45L2uPfURcqLFYfAlNHUlF1f/7TZZ3OHqkshuOkUYR/tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sy2fHjwQKHBfHzb7HKzlmPo3cQ4nWBIyPbHqvTuASvM=; b=aNByDxaLz3UxCE5vlME4jTC7g8g+FN0u04les7EPDxBV0dcxz+sMQ7BVXFhhE+YhojR1JZziV8QRobt0FVXeDhVo4o5VWxttgdJLnQKIOu+hjCALHfKLj1+0YX8gNl4CsB5fJGGwJYKNp5vYKxtVQt4TjlgQ13f6Ak1WiKLpZEOrUzncIEqNWSKPus8gKvdd2Mzj+5SdqNk8XA6YzNOCmzzNGPxIW6ii8feyMWcAF0LX17vJ8+1PfbyLpw6cn+7QV/z4RNbdUkEFcbUrPtM+KNayj/Q9UKiVF4hp1lE+MtKUmBcogTGaO9GK1V9hnv1rDnRvxu5IxATQz6Bwl+TjQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c74b2a2-450c-6932-868f-6109374de6bc@suse.com> Date: Tue, 1 Aug 2023 11:59:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v4 1/1] ns16550: add support for polling mode when device tree is used Content-Language: en-US To: Oleksii Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <6e8f243284b53a9c56e7faf5e0e5ee5e20de9958.1690475512.git.oleksii.kurochko@gmail.com> <98596d8e-6c11-715a-7842-910806abda77@suse.com> <75cd58c00ac6b9f49f1656d6793888ef470c9eff.camel@gmail.com> From: Jan Beulich In-Reply-To: <75cd58c00ac6b9f49f1656d6793888ef470c9eff.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB7073:EE_ X-MS-Office365-Filtering-Correlation-Id: 97027dd3-0332-48a3-ec3b-08db92760d6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vRtrThVAVCB1ND9uwvBBUsThTOzJJhWIbzRzNIxLb9cN0459CimuQSSJ1dSbBnsiZxcN2B4e+Zp0IlRMaeUScM88YX5nJQ3pFdjRe5tlK62d3V84laAZ6DTn2nWdXwfbbM7/y59qhdBe0X2Dvt7XJyky13SMQ7uDU83YZFUYXXiEKCWs3ziYPfIfw4jklE4kp5oTqucT/QPpoQXPQNCqrj5YBmrrBlZ8Hu/v8g9ERuRHS2x4D2pwzMidBqRHyoKhkBnqDTZCdWa6n642tLCXN6gGhiTc8tDQPBW8OaBk8guXmyzKan6Bkai6oXWt9ntszHGSxIWV8WjQGWCJetR3HGbMqOjbyWGe7+6v9BW+T9O8Usm1dgX5r1yxXLJFGTKDBx2MkBwiWc9ZaTWXWNAAxWebRn4lENc2lPos5y60aZvwy4HQS+9N4LHSH9V73sURJHNcnCvsqlBqbtNPaz3GOMQ70Cc0XM+wCgPSJtAeaE4V94s7CqSWhlvHE+6yE464zptC+KPP8kUbOch1SwWRXh2Fh+QdD1I/CX3kNmPfO6UcqaB6Fj0aPgrAIVwjVAPLnm6la4hxuH0mQoaXQsrb/AhZ3l4xSCtzo4VAg8QiN2bO0L4RlsONX1aPvmUL+6DPNIVDpmoK8ADn+7T/m3aVaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(136003)(39860400002)(376002)(396003)(451199021)(8936002)(8676002)(36756003)(31686004)(6486002)(41300700001)(478600001)(2616005)(2906002)(83380400001)(26005)(316002)(186003)(31696002)(86362001)(6506007)(5660300002)(38100700002)(6512007)(54906003)(4326008)(53546011)(6916009)(66556008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWk1bHhBRlRoYjdxQVBjQkkzRm9ydHBYcEZsNWxwemNQN2JrVXJNcHk2d2NZ?= =?utf-8?B?dHM0RXd2TjROemZ5ejlqU2hCN2dLY3JmaDJBeFZTVFplZW5GNGt1b2Z5Y0tY?= =?utf-8?B?R0hNNXNMMW1BMWp0UzJZRE5nSnU5b0IvMGxFWXpsZnV3VlBGU1FlOHg4SlNp?= =?utf-8?B?SC9zellvRXJocFppMjZRU3hEbm03VU9VaGtPcmhjRjg1NVBzUkFERFVPbURL?= =?utf-8?B?RWRNaVdzbUROQzkwQ1Y4REJYUzlkMUk3ank2NlRLQkVWY0h2b3RzbjhiMUs2?= =?utf-8?B?R1J2cVRNRjZQaHFVSTFOTlhmd25QUWdtK3gzSVdKc1VRblJIQ1VQQTUyL3pV?= =?utf-8?B?WFZHME90Mmh0NHJnTERveXhyeGx3K29mQkZ6SUN2RFNrMTdaeHBLNHhrNUpQ?= =?utf-8?B?Z010eE15ay9hMmdYMjd2NWUvQW1mN2hXV214WXFlRzJFdmhGT2l3U3BGUEpy?= =?utf-8?B?TmNWQTJ5SkJyUDdMWG1ZaUhVQkZnbGRXaWRhRjBNY2dOcEcxUUVZSXRXb3NR?= =?utf-8?B?OEpaS0ZLdzNXeHhFTUlnQmpOSWNhbVYxUjB0OXUyNys3WmtZOFJjVDg2Z3NY?= =?utf-8?B?Y0t5WE5tT3NKTTJSaXFhUkNSMUNDaHZjeXcwUWcvZWt0T05mQXN4YldNcC9q?= =?utf-8?B?OC9UZFpHYzNiWmg4cVFzQ2tXM21EY3BSUFdGUDllL1JMdUVCQnJCdDZhSWN4?= =?utf-8?B?THZmU2lFM05SaWhGQUQyaHFLdWRkcEtXL3BXbXFZcDl6SFYxL0w0V3AwOGQ5?= =?utf-8?B?MmEvQjlhOEFCcndLK3YvU2VaTm1CdTMwTGhNWjdKU1dXTzJOWU45c3JQZ1N3?= =?utf-8?B?Qy8yblJaajdmU2FUaWM1dzNxVS85UXBYSForSnVjM09UN21nb3pCQzR5MGNv?= =?utf-8?B?V0F0ak44NFZRZk42T1p0Wnc3SDRMZmdIcmpGY2NrYko3VzZrUnFJc1NrK0Vu?= =?utf-8?B?K3o2bDhQbTllcmY1VWxtOHBmRnJRbllwOUZXUjB2SHRJMWQrV2lOQ3JrSnov?= =?utf-8?B?LzRxcTdQMWRKMmFYajF6U2d0dHJxcmlGeDBuNTNySWgwNHY5Qi9HQ2xuTjFY?= =?utf-8?B?SWtodi9SRm9kcklFMkNoOFhVdWdwNExNQW9lM1IvUEJndW9OR2o2SlNxeGJS?= =?utf-8?B?bWpDUGVqVnl2TzNNRVIwTUpHMzIzNCtuY0NydFRKYlhNNWdudmFBb3djUlpo?= =?utf-8?B?dzdDQWk1OVhoTVV6Zk04UnN4MkwzWk5LRVN3N21qK2t2d2NPZTdLd0JORS9w?= =?utf-8?B?NkpLWDdWUVVTL3p3ZnhhM0FWcnVwR3I1RFVSaFBQVkcwZHVpUnV0Uy9iakdM?= =?utf-8?B?cUdobXczeXBKdlpBRjlodHVFcHVrRzhZc29RdTVoZXhzY05CK0xKUmd3QmlE?= =?utf-8?B?b0dzSU80cHdzVllXc005TjhnYS95WXlIZ3c1R2V6KzRMNlcrdXBkZUVReHN6?= =?utf-8?B?MDMwakMrR0FkbStEaHh1RVRvWlJNMTVIWFNIS0Qxb0xKOSswRnprVHczRjR0?= =?utf-8?B?MDVIOHJwaWNZZGVEZmRnNkYvUnZLWTBob25XZ3JnaXFlYnlWQ3luMVZpdkNN?= =?utf-8?B?WG9GWWZhOHRqaFBKc1RWdEJlMzJ4WnVKQ05WTkxPQmVsTjh2eFU3dWFtVXRR?= =?utf-8?B?cUpML0FuWm9HU3RkWXZQMXZMUEFuWnFwUmdzcis3VGV6elVabWJVNmxJcnhE?= =?utf-8?B?bDVYdExDajZnTjI5TGFVTTZER3llTnBKejlxZTVKak9JRWxxRUVvVlRpSFkr?= =?utf-8?B?NTNjSjVMbWw0WW1xbGFTSW5xOXhZMTNMQVhBK3NrRnArZUQ5M0tjWkdkVWVT?= =?utf-8?B?b01ReGk1TXN3cHhOc0h1K1FFUnh5RzZ3bmVDclJpZzN1RkFnbjVBb1FYNzVL?= =?utf-8?B?WjJSdGdJZmtZZWZUZldOTTNWZmlxSGEwYmc5OGVicGdkYmJ4azJNdzhoQmtM?= =?utf-8?B?ek82eWNjWmsrQmVzcnpQalVoaDB3dVpvVkpZRkppZUxQNmtDYm9rc3hQMFZt?= =?utf-8?B?TVYyVUluRnpVdWRiNWJJMFI1RkhhVmNadHFjaERSMExYUHFhcVNKYUMvQlFQ?= =?utf-8?B?MWw0UTQ0T3BsYzRoei9FRXFxeTNwdm1UM2pEbUJqUkVySStsYXdiVlRIcWxp?= =?utf-8?Q?wJ6+Hlm9MG23aJ+9RsLEoSJ1u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97027dd3-0332-48a3-ec3b-08db92760d6c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 09:59:53.3277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jNkmsfpq4hGr/9XmGufFt+ORpdNS9KvvKRdh0L9FHnihCmX3I9NSWz61nICqe5TgCU5tywonIfkybr8sQKym7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7073 On 01.08.2023 11:46, Oleksii wrote: > On Mon, 2023-07-31 at 15:24 +0200, Jan Beulich wrote: >> On 27.07.2023 18:45, Oleksii Kurochko wrote: >>> @@ -654,6 +674,9 @@ static void ns16550_init_common(struct ns16550 >>> *uart) >>>   >>>      /* Default lsr_mask = UART_LSR_THRE */ >>>      uart->lsr_mask  = UART_LSR_THRE; >>> + >>> +    if ( strstr(opt_com1, "poll") || strstr(opt_com2, "poll") ) >>> +        uart->intr_works = polling; >>>  } >> >> A non-__init function may not reference __initdata objects. But >> strstr() >> is too lax anyway, and you also shouldn't check the wrong port's >> options. >> You want to recognize "poll" _only_ where all other command line >> options >> are processed. > Just to confirm, do you mean that I should use parse_positional() ( or > something similar ) for the device-tree method of initializing ns16550? > > I checked the polling behavior as described above because > parse_positional() is utilized solely for X86. > > It appears that command line options are parsed only in the case of > x86. Hmm, looks like you're right. Arm folks will want to clarify how they got away without any command line overrides so far, and how they think now necessary ones should be suitably added. I recall I had reservations when the file was massaged to compile out supposedly x86-only code. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 10:02:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 10:02:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574053.899252 (Exim 4.92) (envelope-from ) id 1qQmDP-0005aS-5b; Tue, 01 Aug 2023 10:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574053.899252; Tue, 01 Aug 2023 10:02:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQmDP-0005aL-2Z; Tue, 01 Aug 2023 10:02:55 +0000 Received: by outflank-mailman (input) for mailman id 574053; Tue, 01 Aug 2023 10:02:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQmDO-0005aC-3E for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 10:02:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7d00::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94556e74-3052-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 12:02:53 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6812.eurprd04.prod.outlook.com (2603:10a6:10:f8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 10:02:50 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 10:02:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94556e74-3052-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SLSHL4aCJbmaLWoejDSO2HK8Tq+j25oekT06nHDWGrgHz8CwdhmNxuAl0Z+0SsE9hQh5tQHysdoLrzHPmqjIShWRZJQzifA1oHEmcVWD/Av1qDkrZ9PW9HloeCTp4uX6tVu0IeUW2I3Ytui7n7DkyWjrBLfDogJ1iuRVXGcXWgyDSfHKk5BkdTB410a2joml+rJCqv0tuXA4naPnKhHLZZEzIRBYmWtWNHOX27BYtWLVGZDdyk0HAHN0bsfuRJFTxPj1vSYheEBIoRYQWaHz8vRrrLk6OCMZyKS4P2c6amq9taodYREVOYFhzmdWKFXYcDdauERD7jseeI3Sq1oWZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7LyG1zoyz3OS5EGkp2uO6EEEnUE6rD+iMNPMFIRNiQ=; b=bQZTOL5PRciSDxVnd//G8NSfeR10GQ5FlReF7+76GxwclAMn2lcE2PGLXCXDHd+2EGMbmn6OFLIo76A4Ho9+ubTCGBzHheZqMLwJ9te6MI7nPVIO4Mv5oqXLtarTDRdg91g7aU5TE1mzR4NM5pr0+d5r6HCmD6r9xEPgAOOwencnkBTDAsmgqmj7DTFokBYGM/HbSAO9MWgOBNXTjXzFeDUVED3BM2L8P28uA7FHvYWDeZ50ixzkSI/z+5WGivTgeEq4Eq7tgcpbV3MsD8vMRfm9monJwLrA3QhieGNuTMaJRlynxGHV5rxigiqpsdIv6YmHsDNCBdQhbpL0c1F4Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7LyG1zoyz3OS5EGkp2uO6EEEnUE6rD+iMNPMFIRNiQ=; b=vEtNBMv9+pHWk5Y234Jzpx1Z9S2QZr//y1UXxhtCNHmdBgWZMYhl61HGrD2WU6ZPwZn5YVImQGduqZVFBYaVagUCdnT3mI2p2zmyQAcdjFRDUbNBvk4+vQXAAlfw35l1AJ1OcAwKoqjA3rb8LmxC6NXPnEK41aGh3iPG2M5AoXMtoOb8g1GkSJ2eGzcU5uTR+bxdhrylES1iSecDerg1iWa9b+10hqfMXTKFdHoeaiguZU7XXZs5/sMTSrhgMnhbnBsQWtdIyL5igjhIC09FYGvO+5qgo27Z3QBwuvxfhQyuiDyBq6lJsQNXcWZsZCjITeHlNFQCGg5bXcmX7Boc0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Aug 2023 12:02:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 0/3] x86: Some MISRA Rule 5.3 fixes Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Roberto Bagnara , Nicola Vetrini , Xen-devel References: <20230728194320.3082120-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230728194320.3082120-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6812:EE_ X-MS-Office365-Filtering-Correlation-Id: 148e14cf-3075-4cba-3f0b-08db9276770e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: St5ccnhY53u1p7XqsPjaf1dSMs6N7NvBne7J7w6NtqMyqVvJsrj4OoF/I+w+O6qZs2neW3dAZiKpwsZnRlBrAZzVaUYN8DlcWtODh7FFfkkjv+L4LJvhRNrSbaYsSGMRTMlVfhiAbI3+6qH/7A8gmjCS8qWGgvc6AiF9e3vSvWV2z3BHCMyKQIL8gmTTNxJsBgjoTLudsyp9DN0XgGXw8OH2/Q3QdtHreltz1bsyPg2CMacDtqVJdbGMM6I+9+qvu+kUF8OHPN2NbaQkiEhs+HB3bY/JBRHffa9EX39OAkl++sdii63NSgxjgNiQ07ywHuqxawbkpD4hrSBgwNMGL0V6A7rwa1Qmh5bv7zZu4xoTOu6dkRapPT3ka0Dw1AmE8EEwXxhRx7RGDVZvLNCNXlHxFI5lFzj7iYyrRapF1I9stOKtaqjfYkaIRHzN8q55qRLd4l7oXAV/8x+S/zU8+PbO/QFW1gWvpGjE7gFY+6pppD/rLPyz2+dhKoOFDmyfNCjbNqVGmRHKQuUZwtd3uB8tEkZGJEzh+cpuTCXCuxWxt3NaNsY3o/0g/qy1YYp2QobdcQB1fHfNqIdXF84sBN14IbWErKHPH19RNbbHh9BXPQ8UJ4IlvDIfVGjlvrhMrVnJZv1/Ws5btkLCi2of3w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199021)(54906003)(8936002)(41300700001)(38100700002)(186003)(478600001)(6512007)(2906002)(83380400001)(5660300002)(36756003)(6486002)(6916009)(2616005)(4326008)(4744005)(31686004)(66556008)(66476007)(66946007)(8676002)(31696002)(53546011)(86362001)(6506007)(26005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVA5TkM0aWtZSlRBSGcxZTF2dHBQU0VpOXU4VjN0MGdYY0xRT24wMkl0eE1j?= =?utf-8?B?d09hV25wQSs2MStvMFJFbzQrL2k4UDloRnBHZ0dIa2g4bmRFa01FVnFjS2pY?= =?utf-8?B?VWRuc2x3dW1kMVVPWjJGMW56OE1lTjl0Y21BblNMVlR2UjFLa1VDZ011Z0pV?= =?utf-8?B?RmpjVXdvSmVhL0JBOENWTm80b09MU0dZamNNYjFLNm5zbkNINkVVN1RmUmFu?= =?utf-8?B?aTVnZW93VWpVR0l1S2tJb2FDeVpvNmpxYzJ2UHlpbHdkVDhJNUJoZFNhejlz?= =?utf-8?B?aUR4WUNodkJEOU1waXM3aGZnK1IySFhKdloxN0NlRnJjQnMvdENFMzEvNldt?= =?utf-8?B?TElBOEdwTlRoU3o5bEFSZmVzWTVqSk5TM1Z2K0JmbStZUVJ6MjgxS01MNllS?= =?utf-8?B?U3hDTnc5SGhZQnVWVkFlWW5iQ1VzQXFOb0Q0UVVDYW91T2c5OFRaaThIelRZ?= =?utf-8?B?MjNKbnZMNVVOVUtiOEJ1NVRuQWVBNVlTR25vTnYrOFFTd2RWYlZkdkpWYU1m?= =?utf-8?B?bEhkUWNYdnNxdW10dHpLUmdTb044aWR4Si93cEs2bXZ5Qmh6MGRVdnVMN3VN?= =?utf-8?B?L0tDYnc1RTFRU011b1NDMy94L1lWSy9HeFZtSlQwa0RMTjZPbWd6NEtvZUVL?= =?utf-8?B?U2dYOTNsRWJIeXhjcERtMVRHZ2VkY21zaGgreFNDOHpoWkRZaDRrUG9EVWtX?= =?utf-8?B?ZTg1aUR2RnI0THlERHpUOHVQZS9taFVGOHBHM0xYaFlvM0wyQW9qeXNheUpw?= =?utf-8?B?Y1Y1bmIzUnRVc2s5MkZYL0xGRFRETndlcGJVRVJFZ2hxYk9nNXVLRVBuc2Mr?= =?utf-8?B?VFVaVXlhYnlSNGNKUUxNTmF1dnBuRUxlQkhFOWpQYzRjR0oxakhZV29vVFA0?= =?utf-8?B?OUZCVS8rejBkWWo1algwTS82QW1Qdm92MXd4M1NZaGpNU29NZTY0cVFYMzBP?= =?utf-8?B?d2JOSDVwUzA1OE0rTUdzM2RVakRKOXk2VGdrRFV4WWRFNzZrZFFaNzBqZ0dU?= =?utf-8?B?ZjRsejFuWDhwc1RIeWFLZ0dqQzVwNjZtaUxJenV4SStXR2tibjYvNUhzZGl2?= =?utf-8?B?eUVqaXpYWngwU2VFZjFyKytjd0wwSVBQMzNQV0VFUlByUW5SMDNGNFZTWnRL?= =?utf-8?B?VzhNUnh3MzR0K3VWVmliaFNYa3FSamlBS0pqZzNYcm9FRmp1S3A1MTNUTmN1?= =?utf-8?B?N2hRK1hpZDM4Ujdrd05BYzZRd3JKL21kWUdGNEpBeUdwWTJzbDNQT0RBZmtT?= =?utf-8?B?N3dCVDRWSGdZM0NjSzJCMUtiSEkzQlZtdmUxU0dBYTBTNTZNbGtwTzNkSWYy?= =?utf-8?B?aGgzekE2RnVWcUlPNTROMzIwS2t6amU0MVVlbXJ6d0JueVlBelVqb3BabnQx?= =?utf-8?B?Y1Vnb2ptUzF1WHhSTW4yOXZJWnpkR2xxYjV0RzZSdW84UTRRYS9iWVpINzZC?= =?utf-8?B?dkFoSWxVZk9FbkxNbHZ0YlA5V2RTNDI4aTdwcnE3ZmIwRHNFSWZveXhweHBG?= =?utf-8?B?L2hkWm5lTlBhSldDL1RHQlBBeFhWck52TXVvYVRqRC9uemNlRG5IZUpDYW13?= =?utf-8?B?TVBnbGxMZFhDUnhMZHlTOEpWWjJTRmIyT2ZESWYwdUZkMDNWR0Y1b2ZxUitx?= =?utf-8?B?NTcyTUg5UnBBQm5lS2gya2VsN3hoV1Uxc0htRUhHNDE1RmUxakx0dm5jTUxr?= =?utf-8?B?dnhmbENEcjR0MlgyVjh0ZGtQc21uZU5ENCtxYXFlZjB4YXkzanFIVFVRa2JM?= =?utf-8?B?V1UrUFRIWkkyZVhBOTJad2NrMGVya0h4dm9odXhCOXNTN3RQZ0NMSkxKVDd6?= =?utf-8?B?Mk5Jbk1BNHdVUkZpTHRvUTdXbklyczlNV1NEQzdDTWN5eWN5c0FEOGppdzB6?= =?utf-8?B?SCtmaytZVnN6MktPUEVjM3ZmRDUvYTgvd1Nhcm9VMTA4UFlnMjIxekEwVHE5?= =?utf-8?B?dXZCTGxTQ2xpeDNYNnpITW9xcWs4VGlOd0dXUStpcXRib2lnemViUERwa3J3?= =?utf-8?B?Njcxa2RNVnFMWmxTVjU4N3dBRnNHTUo4dnZMOXhDUzBlYndtOXkrUTdWWGtY?= =?utf-8?B?TEt4V2FIbGNESHdmSFNveVF5L1Fld3d0aWdWL1N5ZnpCay9WblRhUzI2ZHFj?= =?utf-8?Q?MxckMV0jdkZl7etJ9nwEkTok9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 148e14cf-3075-4cba-3f0b-08db9276770e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 10:02:50.6389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IW929sSpwmFLWHg7HZKWjelLVafu9jb37y34s9ZWDkK5aTOWnvLwAkhQQS1axVY9SWg0pCNqsMAhq+gOH2glUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6812 On 28.07.2023 21:43, Andrew Cooper wrote: > 'debug' and 'str' account for an awefully large number of shadowed variable > violations. > > Andrew Cooper (3): > x86/traps: Move do_general_protection() earlier > x86/entry: Rename the exception entrypoints > x86: Delete str() Series Acked-by: Jan Beulich with a slightly amended description in patch 3, and preferably also with at least mentioning the Misra angle in patch 2. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 10:34:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 10:34:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574063.899262 (Exim 4.92) (envelope-from ) id 1qQmi2-0001sZ-IV; Tue, 01 Aug 2023 10:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574063.899262; Tue, 01 Aug 2023 10:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQmi2-0001sS-FS; Tue, 01 Aug 2023 10:34:34 +0000 Received: by outflank-mailman (input) for mailman id 574063; Tue, 01 Aug 2023 10:34:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQmi0-0001sE-Jp for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 10:34:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1b::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ffc35661-3056-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 12:34:31 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7632.eurprd04.prod.outlook.com (2603:10a6:102:e8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 10:34:28 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 10:34:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffc35661-3056-11ee-b259-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJ9CjExknNtp8EHGjQG+rxkUex3lVDTrrwhvHLWInk6n+UYiMb2+OmJ6Bz3YEArrkRAIAg0Ri0nkS62Icf2Xgjz83LZ6gLOAmzsKBrDyVTe+xAMRLKdwbltmEsw6vkHP4NcW0xy2o+zFd7g1B8gPut2mroow1CCa9BEFjTRgLq8rIZGemcieqcWkMjfkr0dmVMxlu2g9YsOAu24KPOPgB9TMB+RC9lsdJoTCxVaETDpYRuwzgCnB6PgkZlr92v84TFtIvdw0pJn5w6zv0w+mJELpiN8XTvyT8IHmP4JVIFQT0QQrVRogfPcayLBU8nQf8+TqF/Ai+ANBz8RgBaRNYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mPetlcq0W8Si/8ESOPYhHdDKK+dXarC7uGuQ7gajC7I=; b=XyRv9Ui8C/8/xmzCkw8Thf33v9IeRtC5MoQ8RyrH066sLd48GNvB00G25yiv39s1mLFsJogipj0ix0YIriw9MMcMJmRLE8lpEcQCUFWzSBnvjgeDUk9KEVt5E2MUzYz/pd62BIzxJFvx7NowotWI/PUhlhdrq1FvBr4Rfwoov/0X/IIrY8woSTVG3u21Uy9ObeLnWWklKpCpvCarSoCYoRN/1y7yKoNxSWkTOlC1Kb8/eH06/nr6SJ1uRjHePGnwzwKgkx6IU8Nu9FHvp1DYwRmUC+h7wT8KWjuWZzzMIB+cBDpgcvBHWDimNLQo4UgG5hxd9rhcpk2n4sPIYFD0aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mPetlcq0W8Si/8ESOPYhHdDKK+dXarC7uGuQ7gajC7I=; b=LC/RolXF2JmXHB+EJhKKAOAOcBJJHbByoncfgRARC/9n5Z8Glwb1bWtPNsnYjlE4XlUDogoDE+BN6LEe0ipVmWrvgQwmZaSVaM0W9G4I1JRcXIPN5a9Ah7zBW6xdo6hgU/jougZqBvsTQfpGuicqtYOZRRu/ww8ae+a9v1qGq1aH8Pj6Dq4QGPDm7QQlq2n0QJAQr+C1osvFvx/UauVbO4YL7+/FvNXjoiv3e8R1iN4p3o5IbyYvkr2xhEflZFYSyOTtYcq8/UpMQR12v6Dv1i0GeYP2CVG5kST6l+hi9XDCnp7XqmyrmYDAFGnqXncUmqZdYf7/Zy20IOeZ/1i5OA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4ba63342-6200-1f76-bf63-8df62e8955a4@suse.com> Date: Tue, 1 Aug 2023 12:34:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Shawn Anastasio From: Jan Beulich Subject: [PATCH] common: move simple_strto{,u}l{,l}() to lib/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7632:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bf6bebd-fac5-43ce-12bd-08db927ae228 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NZzwQ+ltOd6lJzIWMPmwef75wgDWHKwXukbWsLvytNRsnw5TLpAp7lOHKbFf5CpVqqZ7Lpi3g2BxrTLIccv2RSK6+qmXV9l9XTlIM1Ad01Yk/74NzghFKF8XK3hcr1QDnbx5NP1VCLHfd8hR/oI4J20P8qfn4TwuCsMt+0xZh2zbKgy0hFpul9ThnRIUr3qcM9gnn4xOMsbzKTrgazvzMC75akWvXzNM66B7bMvvqmi/c1w2bOeTDxgOOD/Rim2Vvklgc7uJT2X5nfhlJKxWpzm9h9VXHZDR52v+B+HOWR8od8dw1yu1nJnUZM4vQF9N845e9DAaKCPASz3mrtqHukYbrtGzdFNDLg3wzU4qEeR/jEr3s/lF2ak0YvinmMlFbdhQWClneSd8925HLSGuEVPYNCmM0732jf75u19728c0390aQsghuEnFmTeMYAUBAnreXUjiN0kZEGeBhUoS9ApuLMWjB2KR+AYUVscVzqRzMhn0mQhaNb8m4fV2t/ucCqHyvvWXRPK2fT2Dwa5O0iniw+x+sT71AHFGZv3KCocaCwZme5jYugH4nl1uhHewHAyfkIYJCgQMCuw0SVRJ9/4yGy0KyUMBU2DUx1pbx22oHFLHTSUoHSQE5rANYOe+qIPs2gFFDspiUGDMZXG2Vg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199021)(6916009)(2906002)(4326008)(2616005)(83380400001)(186003)(66899021)(316002)(38100700002)(31696002)(31686004)(41300700001)(478600001)(86362001)(6512007)(54906003)(5660300002)(66556008)(66476007)(66946007)(6506007)(26005)(8676002)(8936002)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzZEWWdSVDk2TkNZOURINzlLZkxpbDI1N3R5UDJYRUpka09hYjBZaTNsZ2Jl?= =?utf-8?B?T21tSE5ZZUR2dmt0a0xVRXJDRzlxdGVBVHJoNUFOYjBhc3VwRmRyMDI0eXdY?= =?utf-8?B?SitHTGJXVmttUlQwcU9NRFBydndvUzVtWTdQUGRpNkZEWHBha3VJeEdnZlAv?= =?utf-8?B?cjdsR2V6anhrd2huRnVBakp1Q0RON3p4WjVFeUFTY1VJaE5aZDQ4U0ZhV2tq?= =?utf-8?B?VVNZK3REc0l1ZTV6bHlwYWJJK3NWWXVNUEo2Q3VWWkxHcFlrbWg2Q2pzaGsy?= =?utf-8?B?SmdncnpPUTVabEJrRjB5NjhtZXRPWjQvV3lKOGphbGgvSTRxOHJVMlNjSG9o?= =?utf-8?B?MDdVekNmTk01MFphOVNacTBmQk9CRllVbmJFRm5GR1Y4ZmQ3YWY4ZUIvMFc0?= =?utf-8?B?SjJFM2xWZmV0dmIva2VhRm9hc0NDSjdCeWRoOTVhWXloQU9lNFlIVncvdnhR?= =?utf-8?B?aStyOWFLaGl4Vk5TQzVLUmJKNURBK3dVZ1dMdmtSeksvbS9zRkJobzZpSHY1?= =?utf-8?B?Y05FdXdkUS8rZFAyYS81dnRqS0FYZEtqTnFjbDdwNkN3ZHdnMGxaTlk2NkVM?= =?utf-8?B?Q2VNRXBJaC94clI2OVQ4a3RsL0N2LytnYzVObVZQYkJCeFJDUmQ3b2U5Nmox?= =?utf-8?B?RmVGZzN0a0NjUTVDZUQwRHhkSjB1eWQyN3lueUVYZEtsZVRuQlp2VTduaHV1?= =?utf-8?B?MDZCN3kxaEZrRzdKbVRiR2tManZsTUdWWEYxN3BMNnZGLy9FbHJTREdURUFo?= =?utf-8?B?NkZqY0tlYllnUzlLQld5ZkdINWZUQkVNM2VjM3lFSWVEVTlwSDFlOUVzL2Uv?= =?utf-8?B?N3U5YVZFSEFzRjd1TUNGcHAzMjdRblVZdXNUQUdPT3lST0pRaWE2SmxOK2ZB?= =?utf-8?B?SmZ2cWhjOWEwaHFwSG5UMzNPbWNXb091SEFCVWRFTGordDVkdUpnUTVUQmd0?= =?utf-8?B?eVVoR3dNWTYyVmoveVhLeW9MYktTY3plOUYwRzdoRFI4a2ZrUGFkQnM2QmEw?= =?utf-8?B?bjVpcm8wUlVuMEdoRENQRk11dGNMbnExcWRVY3l5Z2l0MEgwMkhzZ1V5S01U?= =?utf-8?B?WUtyTVdtU2tSVjU1M2JyaVI3bkVtMjUrWUk5eFRTM1llR1JtOXplWmx1NVo1?= =?utf-8?B?MUtYMVBobjRYaU9QOHZ5OHJWcitOSzFydmsxUlJmQVFKK3F4ZWFFTjl6Qk1X?= =?utf-8?B?M1pzRkEyd0dRTGQ0ZzhGdkFsc09kYXFucVVmOFQvVG54Wnk3VUtuOFgxUjNH?= =?utf-8?B?dWlQNDlVMkE4d3o0NCsvR0RFUTltcE04c2w4UFZxNVk3b29ZYzd5Mm9uWWtF?= =?utf-8?B?bjIvUWpFRkgxZ1hmNU9ZSHlzZHhPOU9TSFF3UC90MjRsbDhUVGdXZlM5dHgz?= =?utf-8?B?NWJjaFlMSzVXSkVkVEd6a0FpcUxJQ0JmNlY5QnF3OUpQTkdURytqVWpNaWRX?= =?utf-8?B?UHFsdUZsS0NQaVU3OU9OSC8vVzh1c0Y1WTZqYmd1RzFXb2VObVlrZEdTTjht?= =?utf-8?B?amJ4Zllzc29SWlZxaVhGaXJvWkZVQThUMmJMZjdhb0VOTk9JSStmSW1maEV1?= =?utf-8?B?OU5WK1VoVUtiMS8vYXJFRXBaK1l6c28wVm5RRmw5L3BYRTY2TnNDeS9zbCtr?= =?utf-8?B?TytkQTNDUlQ4MmFTeHdXMDk0VWFwZWtjYStUd2FKZFJSZHM4bGxGNDVWa2w5?= =?utf-8?B?eXI0bHNuZUtKbzI0STM5VDlOQVNoOEVsMjZVcDMxbGxLeGdDdkw0dENRR0dO?= =?utf-8?B?WnRGUlJKeUVFbWN3dTlMSC9RcUVPUE5hSnNDbDJZeTc4dThFMmtSVUZRb004?= =?utf-8?B?cDh0cUd3ZzBpajlBMFIvcFlFUXIyRTNLSkIyUUFpU01MaG9XZ0RrVXVCQWZq?= =?utf-8?B?NGR6Ty9MTW5McnBmRDFQQU45Tko2SlZ1QWQxVEZCRldRUzRSS2tNWmg3T2JX?= =?utf-8?B?YzZvbzFnMEJjdmFGVTg5L1JWa3NZWGJNS0RodlJ1SWpzTWVwVkFFTC9ZRTk5?= =?utf-8?B?YmoxYkdrT3JTYmxQVHd4bEdOREZFbit0K1Z4bXhNUEhFWGltdWp5cHFuS2pY?= =?utf-8?B?d1oxOENuOTZyQUc1dEZJOXR5WlZhY2lIeDhwL3FVV3I2aEwvc0l0NG94ZDBI?= =?utf-8?Q?0mpxG0g7dAe/40YLe3+4agItX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bf6bebd-fac5-43ce-12bd-08db927ae228 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 10:34:28.2089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jga3wutTo2CBCYiGXIB3Y6jBHQBhHCrHLVYF1E/CsnBastg6EFCECRMKt7T4IzbVsC5xB/cIeYMwmNI2T3PDMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7632 Convert style from a Xen/Linux mix to pure Xen while doing the move. No other changes, despite having been heavily tempted to do some - at the very least to make simple_strtoul() and simple_strtoull() the same in how they deal with non-numeric digits. Requested-by: Shawn Anastasio Signed-off-by: Jan Beulich --- Further changes I was considering: - "value" doesn't need to be unsigned long, and even less so unsigned long long, - strtoull.c could simply include strtoul.c, after #define-ing "long" to "long long" and "simple_strtoul" to "simple_strtoull", - "else if ( base == 16 )" wants folding with its inner if(). --- a/xen/common/vsprintf.c +++ b/xen/common/vsprintf.c @@ -24,108 +24,6 @@ #include #include -/** - * simple_strtoul - convert a string to an unsigned long - * @cp: The start of the string - * @endp: A pointer to the end of the parsed string will be placed here - * @base: The number base to use - */ -unsigned long simple_strtoul( - const char *cp, const char **endp, unsigned int base) -{ - unsigned long result = 0,value; - - if (!base) { - base = 10; - if (*cp == '0') { - base = 8; - cp++; - if ((toupper(*cp) == 'X') && isxdigit(cp[1])) { - cp++; - base = 16; - } - } - } else if (base == 16) { - if (cp[0] == '0' && toupper(cp[1]) == 'X') - cp += 2; - } - while (isxdigit(*cp) && - (value = isdigit(*cp) ? *cp-'0' : toupper(*cp)-'A'+10) < base) { - result = result*base + value; - cp++; - } - if (endp) - *endp = cp; - return result; -} - -EXPORT_SYMBOL(simple_strtoul); - -/** - * simple_strtol - convert a string to a signed long - * @cp: The start of the string - * @endp: A pointer to the end of the parsed string will be placed here - * @base: The number base to use - */ -long simple_strtol(const char *cp, const char **endp, unsigned int base) -{ - if(*cp=='-') - return -simple_strtoul(cp+1,endp,base); - return simple_strtoul(cp,endp,base); -} - -EXPORT_SYMBOL(simple_strtol); - -/** - * simple_strtoull - convert a string to an unsigned long long - * @cp: The start of the string - * @endp: A pointer to the end of the parsed string will be placed here - * @base: The number base to use - */ -unsigned long long simple_strtoull( - const char *cp, const char **endp, unsigned int base) -{ - unsigned long long result = 0,value; - - if (!base) { - base = 10; - if (*cp == '0') { - base = 8; - cp++; - if ((toupper(*cp) == 'X') && isxdigit(cp[1])) { - cp++; - base = 16; - } - } - } else if (base == 16) { - if (cp[0] == '0' && toupper(cp[1]) == 'X') - cp += 2; - } - while (isxdigit(*cp) && (value = isdigit(*cp) ? *cp-'0' : (islower(*cp) - ? toupper(*cp) : *cp)-'A'+10) < base) { - result = result*base + value; - cp++; - } - if (endp) - *endp = cp; - return result; -} - -EXPORT_SYMBOL(simple_strtoull); - -/** - * simple_strtoll - convert a string to a signed long long - * @cp: The start of the string - * @endp: A pointer to the end of the parsed string will be placed here - * @base: The number base to use - */ -long long simple_strtoll(const char *cp,const char **endp,unsigned int base) -{ - if(*cp=='-') - return -simple_strtoull(cp+1,endp,base); - return simple_strtoull(cp,endp,base); -} - static int skip_atoi(const char **s) { int i=0; --- a/xen/lib/Makefile +++ b/xen/lib/Makefile @@ -28,6 +28,10 @@ lib-y += strrchr.o lib-y += strsep.o lib-y += strspn.o lib-y += strstr.o +lib-y += strtol.o +lib-y += strtoll.o +lib-y += strtoul.o +lib-y += strtoull.o lib-$(CONFIG_X86) += xxhash32.o lib-$(CONFIG_X86) += xxhash64.o --- /dev/null +++ b/xen/lib/strtol.c @@ -0,0 +1,28 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * simple_strtol - convert a string to a signed long + * @cp: The start of the string + * @endp: A pointer to the end of the parsed string will be placed here + * @base: The number base to use + */ +long simple_strtol(const char *cp, const char **endp, unsigned int base) +{ + if ( *cp == '-' ) + return -simple_strtoul(cp + 1, endp, base); + return simple_strtoul(cp, endp, base); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ --- /dev/null +++ b/xen/lib/strtoll.c @@ -0,0 +1,28 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include + +/** + * simple_strtoll - convert a string to a signed long long + * @cp: The start of the string + * @endp: A pointer to the end of the parsed string will be placed here + * @base: The number base to use + */ +long long simple_strtoll(const char *cp, const char **endp, unsigned int base) +{ + if ( *cp == '-' ) + return -simple_strtoull(cp + 1, endp, base); + return simple_strtoull(cp, endp, base); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ --- /dev/null +++ b/xen/lib/strtoul.c @@ -0,0 +1,61 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include +#include + +/** + * simple_strtoul - convert a string to an unsigned long + * @cp: The start of the string + * @endp: A pointer to the end of the parsed string will be placed here + * @base: The number base to use + */ +unsigned long simple_strtoul( + const char *cp, const char **endp, unsigned int base) +{ + unsigned long result = 0, value; + + if ( !base ) + { + base = 10; + if ( *cp == '0' ) + { + base = 8; + cp++; + if ( (toupper(*cp) == 'X') && isxdigit(cp[1]) ) + { + cp++; + base = 16; + } + } + } + else if ( base == 16 ) + { + if ( cp[0] == '0' && toupper(cp[1]) == 'X' ) + cp += 2; + } + + while ( isxdigit(*cp) && + (value = isdigit(*cp) ? *cp - '0' + : toupper(*cp) - 'A' + 10) < base ) + { + result = result * base + value; + cp++; + } + + if ( endp ) + *endp = cp; + + return result; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ --- /dev/null +++ b/xen/lib/strtoull.c @@ -0,0 +1,62 @@ +/* + * Copyright (C) 1991, 1992 Linus Torvalds + */ + +#include +#include + +/** + * simple_strtoull - convert a string to an unsigned long long + * @cp: The start of the string + * @endp: A pointer to the end of the parsed string will be placed here + * @base: The number base to use + */ +unsigned long long simple_strtoull( + const char *cp, const char **endp, unsigned int base) +{ + unsigned long long result = 0, value; + + if ( !base ) + { + base = 10; + if ( *cp == '0' ) + { + base = 8; + cp++; + if ( (toupper(*cp) == 'X') && isxdigit(cp[1]) ) + { + cp++; + base = 16; + } + } + } + else if ( base == 16 ) + { + if ( cp[0] == '0' && toupper(cp[1]) == 'X' ) + cp += 2; + } + + while ( isxdigit(*cp) && + (value = isdigit(*cp) ? *cp - '0' + : (islower(*cp) ? toupper(*cp) + : *cp) - 'A' + 10) < base ) + { + result = result * base + value; + cp++; + } + + if ( endp ) + *endp = cp; + + return result; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ From xen-devel-bounces@lists.xenproject.org Tue Aug 01 10:53:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 10:53:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574073.899272 (Exim 4.92) (envelope-from ) id 1qQn0V-0005Am-Vs; Tue, 01 Aug 2023 10:53:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574073.899272; Tue, 01 Aug 2023 10:53:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQn0V-0005Af-Su; Tue, 01 Aug 2023 10:53:39 +0000 Received: by outflank-mailman (input) for mailman id 574073; Tue, 01 Aug 2023 10:53:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQn0S-00058n-In for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 10:53:38 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9c71d2e-3059-11ee-b259-6b7b168915f2; Tue, 01 Aug 2023 12:53:35 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qQmzX-008BnD-Bk; Tue, 01 Aug 2023 10:52:39 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id EF22B300134; Tue, 1 Aug 2023 12:52:36 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id D59162119E820; Tue, 1 Aug 2023 12:52:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9c71d2e-3059-11ee-b259-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YE2qKJj0nGqnS749mvZ5YUYTvinBv+jyNwtgFmZ3+Q8=; b=B4FnZuoFBN+F7R8DhAptG4cq8z pPAaq6jCEOFFR82ZVOVboWY8+HWwV3rlE2vVb4LcpJDDaCI4WVTuxm8u6FVkIebNJt/3gcIQm6EhL uXQ9+1AOGEwGNY69X2a3xZYhi/Agcfkhl1LN/EwnbZXdP/CmzjrmglNYVirBrsSPtCbRQsVzvlhp5 SDHPPm61BKP47UPCPAMttegoehcM9Ft77iB3YVbCYJpLGtKta4ZnlPIAqWwoHHV5XeZ7nOyk/P+mp XoyolXg40nLd0D8FykoUZP4HDTHUG8dWEBpVmrSeli8/hyAPgtOsPcp1Ip1gsGBrgvP3hSx85WCwW 0Lt8kRjw==; Date: Tue, 1 Aug 2023 12:52:36 +0200 From: Peter Zijlstra To: Xin Li Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: Re: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Message-ID: <20230801105236.GB79828@hirez.programming.kicks-ass.net> References: <20230801083318.8363-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801083318.8363-1-xin3.li@intel.com> On Tue, Aug 01, 2023 at 01:32:42AM -0700, Xin Li wrote: > Resend because the mail system failed to deliver some messages yesterday. Well, you need to figure out how to send patches, because both yesterday and today are screwy. The one from yesterday came in 6 thread groups: 0-25, 26, 27, 28, 29, 30-36, while the one from today comes in 2 thread groups: 0-26, 27-36. Which I suppose one can count as an improvement :/ Seriously, it should not be hard to send 36 patches in a single thread. I see you're trying to send through the regular corporate email trainwreck; do you have a linux.intel.com account? Or really anything else besides intel.com? You can try sending the series to yourself to see if it arrives correctly as a whole before sending it out to the list again. I also believe there is a kernel.org service for sending patch series, but i'm not sure I remember the details. From xen-devel-bounces@lists.xenproject.org Tue Aug 01 11:19:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 11:19:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574087.899282 (Exim 4.92) (envelope-from ) id 1qQnPI-00086P-1o; Tue, 01 Aug 2023 11:19:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574087.899282; Tue, 01 Aug 2023 11:19:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQnPH-00086I-VR; Tue, 01 Aug 2023 11:19:15 +0000 Received: by outflank-mailman (input) for mailman id 574087; Tue, 01 Aug 2023 11:19:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQnPG-00086C-Pf for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 11:19:14 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20606.outbound.protection.outlook.com [2a01:111:f400:fe13::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3dc30a1a-305d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 13:19:12 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB7959.eurprd04.prod.outlook.com (2603:10a6:20b:289::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 11:19:10 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 11:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dc30a1a-305d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S4hYImOk4wVT/YiAp0rC5Fy+dtYsZIEfMMdFmnAIc2DRO5HO6oGA/TrnmRsgXDJLg+xlRvZE/aJKqouV97+YgXAlKac/Q3p3JcnnUprwDGIBwePRzk3DYLDacXDW4r5WEw1UXyTxMLBpWU87YudkYXbRkwX30MF1y1n828Sn6lNh0WWZK8EtQqSDWNuHj7I79h3nw+W9pu527aMPiKr7+P7dPriJK+owKtOU3tCI/61kDGq2/L2HYlkxnU3/5NR+fDyAh4biUCnermFW2C2YIS0HULeuP9QXv/VNcOP/BL+1WIQ12/S18SZSlyK6i9dI1RVOPh/g/ERwtg/5udpBJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=enT4m1wrpXUknXwT+jQ4JN1Ee92JCTLa1Ujmdd4kd7c=; b=cmEiMU4dLfywa8w/hk5lBMapfIVEJ9bEoFTXobt6oTyJ+/UaYqmQ6G76DMsbuA5CElRXqsPzDDYLd1hQDdygw6XBtaaxqZtX+Zj736YDrhcR/WaH34ojet2eMTW1JY+fdZKXERICLIfEEpjDr1dg/vnQIk7vOVV6yxGK6fLnQe5CoRZ/18x3YD5PF96LOD8E3OuVvscz6nJpgEn1pP5st3OwZFc5mEYyYWSINoa5ZvZgE71DBONbUnfaeVdp6UvZ2h9cIcfvzVMVoBIiU/NXhG3VprzaxC0SxLwePutj32T1wPPxzGHR92O5C7febZLrqpu+HfBQc/qGrZtVh3RAEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enT4m1wrpXUknXwT+jQ4JN1Ee92JCTLa1Ujmdd4kd7c=; b=TIfVWd+N1dNT55/f9TkTy3T41rd9ahxjUGEXB09aYwbQatJsuiu5eu1fO8DVv40R+ZahA/Ihq8+41UVwtYVnsA0KkFs2FyG7RNXnZWMMW7/5PmOXe0GxfRCAD1E8XeFckpej1C/oZCjbfBfOWjF5LF3AOcnrnYblz76dGlOhSMboDJfZ2NbEEvN5SgKFUq5cJPcMJTFkG93B1Rxl+XPGm4j1bQuhaoXcKmCEcrchDtHw/PVxaLdHgKwr9AUmcKrsow+h6Z6VD5asmOmhiUWUTFTwRBtV757/Wlz9/V5pLV46UGCRsqQART4ghF3y7ye0lbagwNudoWdBqW7a9dV4Yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <41b33115-274c-7172-f100-85d6a4f1d538@suse.com> Date: Tue, 1 Aug 2023 13:19:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <3023ad320b42fa3787bb71a9cf83b34965668fe9.1690579561.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <3023ad320b42fa3787bb71a9cf83b34965668fe9.1690579561.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB7959:EE_ X-MS-Office365-Filtering-Correlation-Id: 318968b5-31ae-4a0e-46f3-08db928120d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lS20hl5ap2sFm7KPHhxzLsL/qM+Ly9lqN3VQhAP9DKqAODNGu3/42t1oFbnoNx60CYL8hE3eqgOLNSGxYVRrlYduOUNtFkpFQS/S8j8OQlNuoMPC8o3/7e6Yf2tz+EOSNsRh88+TmJtsfCmdZ8LW7+KhxPpU1l8W/6Bsqxx64mP5ncTbRSPTs9CBBAT8lo+o2Z0tJha8fNyTOEc/qI87xn77urbEmXbNcptoiS9zOau29fusLCd3Dk4wi5QbuowJvXW3akl2ojWeC3ryNRJqei5Q7NwQS/N9EpbzD+8TS6NcxywMgrGR9oSHx9K6QoLo0GHrCe/vv8le26bayTN+nCsuHlTDk4qshXego3g844T4Ke3eR/lCMzugGE59l33VPm1HCMGoNNzDxenZy0czOvd25Ywo6DG+z9nsVl1b1TM+v81kivuzLqgqDdI8HaZ4tpwhv7b9B2FGNnxryvAkJgdMmXRDZR7gAKOrD/VY0VNHsyuwkQ9wu1Otpg5MGDvmAy7KejVLzI36XyPuvuFcvjU2EzRlhyIIVSX1rTpcC5tIloxAk1ktHtWuX7G2M6gw4Mce6Km/tpL20coWPNq7UBpxWl07inkSVLmLASdqMquMRAvy94UyGF7EF6APMhZk4L2BJgTwSQh9BQtcwasdTw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(376002)(366004)(396003)(136003)(451199021)(54906003)(6512007)(26005)(6506007)(6486002)(36756003)(8676002)(8936002)(5660300002)(66946007)(66476007)(66556008)(53546011)(4326008)(6916009)(2906002)(2616005)(41300700001)(478600001)(31686004)(86362001)(186003)(38100700002)(31696002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjZ2RnRvb0tGSkM0OTZUN0lUSHA4QmFrRkhJKzE3d0N6SUZqNmNYVDRWcHlM?= =?utf-8?B?cTRHblhPTW91UVhxbEo2M1htdW05d0pTQ2N6T1RIQkVrMzEwS2V0eXVwc3Fx?= =?utf-8?B?Q1gwMmViRmdWVDJFYmdGNzNuYXJPWWRIWlcxU0wwa1JzRktUQXk5K281MmVu?= =?utf-8?B?M21JYjFkV25XeWRDY2R3S2dEL1pnRnJSLzc3TEJpL3BxNnZ1RUcyY2pBRGhE?= =?utf-8?B?SHlkUUM3NU12dStWY05zR2lPTTZXc1UwQUliYXFncVk3TENDSy9tV0RtTmdu?= =?utf-8?B?WE5yaEhMTnNsSll1VVNzUlZ2Zy9nQWNwajFVVG1MTzE4Nm5kdEJEQUhZamRW?= =?utf-8?B?M2Uya2JKWVd5OXhxdm5LdG9xN1VETm5nMHhlT09Jc1ZOMkhaVTBmUnBtaDMr?= =?utf-8?B?QVJWS1F5TTZpd1hsSmJFWkYyajZKVmFJUmlURktOU1RNa1o0ZGQxd0tLWGY1?= =?utf-8?B?MlRjT25YeW51cUxyNW1PbkZjSTUzcVBveW5JQVpBMVQ2NXZSR05uNEYzeDFM?= =?utf-8?B?NGQ0UjJNT042eWd3V01kTS9VdlZleUl1SWVxTVF4RFJXZ2dLcS9YWUJYMnhN?= =?utf-8?B?WWhNZTBpTXp3THllRC9LNDdiNy9xWVIxMnBtQytvZjVJYU15K3RtYkp6UDFF?= =?utf-8?B?OFg4VGMyam9oUXNCM3AyRUY5RFZrdUpJSmhwakRjMkdraS9ITlJtTmFBaGNs?= =?utf-8?B?VFZ2L252bzY4UER0S1ZDeFFjNUErSXFhVVNRTlVtRFlBSkFzODNNZzlRTEF2?= =?utf-8?B?ZkdzeUVJMnRHQ3l1bzJkelZVelY4d2xXV29zRTVaRytmNkJRcVA4U2x1bTg5?= =?utf-8?B?UkRsY1REUUZydVBkVFlOYnhRRHNMejdraEYycTJtaDhobFpEcUdFVkRJRzRW?= =?utf-8?B?VHI1RWorbXJzaWsyaFZvenJ3VnBhM2RjV25tQVpPdHVEd3M3ZGl1QmNMLzha?= =?utf-8?B?NWlqdHR3QnhiZmlibXJyWHNSZkliTUJwRkI4RVM1YmRMVVppMDRoc2ZYK01G?= =?utf-8?B?aU9wNk1pTk9Ub2FWazlxamlTT2R2L2taQndHd0hmOExnYjR1MnZkOTBsd1R0?= =?utf-8?B?Nk1ObGNteVlvSzFJMWdqTzhDQVZDV0RGd241aDR1LzV5d3hoVlNNTGxOZUly?= =?utf-8?B?eGVielFoaElSVHc0di9jR3BqYzBSdUJha3VWUy81UnVJaXRoczNvR2dNZzVm?= =?utf-8?B?ak9TaHV3V1dxR2ZqMHJQWnlSQXozNmxvRThGdzdmMldtcmUzTWM4TGxjZk1H?= =?utf-8?B?RzdGT0k1ZXBsVFE3VUgzdnRPVjV5NVRadURCVDhaY2hVZGo5Z1NWSGYrNTJ3?= =?utf-8?B?enU0YktvaDMrUG1VM2tFTHhJMitNQkF2d3FuNFdWMTkxNU1Ia0tFM2tscU9a?= =?utf-8?B?VHgzRDE4N21vVzFFQm9jYytMTzdBOEtZalMxaXNBcEUyN21qdDAydCs4b2p0?= =?utf-8?B?K0ZqV2VoK0VGY1plS0pDSVJTbmNRU1RhaUluSG1oOWYxdmlHMUVNUTJzYTkz?= =?utf-8?B?S21CelY5QmJlbC9YT2h6QmdQOTNha3FzcHJxWFBJNEFmWWhZSTlVV2R6WFhX?= =?utf-8?B?L0kxdUNWcU1sU1BpZzNiVGdUOHU1MU1ncjlBYnZOSitKcUhYZ1ZSTUlDUE9h?= =?utf-8?B?ZExuRStFSTVTTWtzcXpRaExzcElQbnRFSW5NNGh2Zk9FMGtRMUI4TC8wdXV4?= =?utf-8?B?T1NDdlQyakxKNDlDQk9Kd2NPR2gzYnhSY1hRZnZBaVFlQ0JGam8rUVVOTi81?= =?utf-8?B?Z3RlbWxIMC9CdVRudWZPb0krSW1UOXlJUmF0QVJYRGJtRGJaUjRWQ1RlbzZV?= =?utf-8?B?MjdzNTZ1ajZqNmNhSCs3cks5VTV3cjZHVDR0WEhoNEtNaWxCVTRTd1VoUWVw?= =?utf-8?B?SWJVSUg0Q0VrVXBhdjh3aVlrSWxGTEJObzF5MmFSck52bFR5d3BzY3VFUnhl?= =?utf-8?B?SnVqQWhkODg0RFAwaTg0c2VYNHd1MWozaERlaGp2VVFhWm1YZ2wxeUVWQm1q?= =?utf-8?B?a2pqUU54NFN5bG5NQ0M4TnRHdFZpSjZQYUJ5cXE5ZXFJQTRFYnFTTGkwbXBy?= =?utf-8?B?eHNnaGFqQ2hScm9ZajBsL1lteEZMbWM2ZXpkb1p3NElqYUtSOE1uY3Nqa0pv?= =?utf-8?Q?uYXUK3LhBBi5tmbT6FEVZ4YaS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 318968b5-31ae-4a0e-46f3-08db928120d1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 11:19:10.4143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yCYDmChxSSMHXiZTZ2RFU2RMgcoFcL1VZAjA48GoLWikwQvA+M8Oim12mUVyrJQR7gIV5l4K554JrsYu/xlQMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7959 On 28.07.2023 23:35, Shawn Anastasio wrote: > --- a/xen/arch/ppc/include/asm/asm-defns.h > +++ b/xen/arch/ppc/include/asm/asm-defns.h > @@ -23,6 +23,18 @@ > addis reg,%r2,name@toc@ha; \ > addi reg,reg,name@toc@l Noticing only now, because of the issue ... > +/* > + * Declare a global assembly function with a proper TOC setup prologue > + */ > +#define _GLOBAL_TOC(name) \ > + .balign 4; \ > + .type name,@function; \ > + .globl name; \ > +name: \ > +0: addis %r2,%r12,(.TOC.-0b)@ha; \ > + addi %r2,%r2,(.TOC.-0b)@l; \ > + .localentry name,.-name ... being widened - could we gain blanks after the commas? Down here (to match the code in context) another padding blank after "addi" would also be nice. > --- a/xen/arch/ppc/opal.c > +++ b/xen/arch/ppc/opal.c > @@ -8,9 +8,28 @@ > #include > #include > > -/* Global OPAL struct containing entrypoint and base */ > +/* Global OPAL struct containing entrypoint and base used by opal-calls.S */ > struct opal opal; > > +int64_t opal_console_write(int64_t term_number, uint64_t *length, > + uint8_t *buffer); Would this perhaps better be void *, eliminating the need for casting in calls of this function? > +int64_t opal_console_flush(int64_t term_number); > +int64_t opal_reinit_cpus(uint64_t flags); > + > +static void opal_putchar(char c) Can't this be __init? > +{ > + uint64_t len; > + if (c == '\n') Nit: Blank line please between declaration(s) and statement(s). (At least one more instance below.) Also please add the missing blanks in the if(), seeing that otherwise the file is aiming at being Xen style. > + { > + char buf = '\r'; > + len = cpu_to_be64(1); > + opal_console_write(0, &len, (uint8_t *) &buf); > + } > + len = cpu_to_be64(1); > + opal_console_write(0, &len, (uint8_t *) &c); > + opal_console_flush(0); > +} > + > void __init boot_opal_init(const void *fdt) > { > int opal_node; > @@ -45,4 +64,10 @@ void __init boot_opal_init(const void *fdt) > > opal.base = be64_to_cpu(*opal_base); > opal.entry = be64_to_cpu(*opal_entry); > + > + early_printk_init(opal_putchar); > + > + /* Ask OPAL to set HID0 for Little Endian interrupts + Radix TLB support */ > + opal_reinit_cpus(OPAL_REINIT_CPUS_HILE_LE | OPAL_REINIT_CPUS_MMU_RADIX > + | OPAL_REINIT_CPUS_MMU_HASH); Nit: operators on continued lines go at the end of the earlier line. > --- /dev/null > +++ b/xen/arch/ppc/ppc64/opal-calls.S > @@ -0,0 +1,82 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Adapted from Linux's arch/powerpc/boot/opal-calls.S > + * > + * Copyright (c) 2016 IBM Corporation. > + * Copyright Raptor Engineering, LLC > + */ > + > +#include > +#include Would it make sense to have asm-defns.h include asm-offsets.h, like x86 and Arm do? > +#include > +#include > + > + .text Is any of this code still needed post-init? > +#define OPAL_CALL(name, token) \ > + .globl name; \ > +name: \ > + li %r0, token; \ > + b opal_call; I think the trailing semicolon wants omitting. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:13:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:13:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574109.899291 (Exim 4.92) (envelope-from ) id 1qQoFy-00069W-9s; Tue, 01 Aug 2023 12:13:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574109.899291; Tue, 01 Aug 2023 12:13:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQoFy-00069P-7N; Tue, 01 Aug 2023 12:13:42 +0000 Received: by outflank-mailman (input) for mailman id 574109; Tue, 01 Aug 2023 12:13:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQoFw-00069J-Ln for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:13:40 +0000 Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d920d718-3064-11ee-b25a-6b7b168915f2; Tue, 01 Aug 2023 14:13:39 +0200 (CEST) Received: from sender by smtp.strato.de (RZmta 49.6.6 AUTH) with ESMTPSA id jd2f5az71CDQQlu (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 1 Aug 2023 14:13:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d920d718-3064-11ee-b25a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690892006; cv=none; d=strato.com; s=strato-dkim-0002; b=hlyrkG3upPwylhpKCY70T7olKKv3MPc3Ro+hkooftpd3KrftJ4p99qPdLYStHTLb82 TwULyqqsWs8xS47amaK1otp2OskjtH8thHyNXfabo63732WWKzYvYUam4mDVRlhlxB6P AtmCUP5anXT54cwgRCQGbC69Er5P6UZK8V1V9/Kgn4JDBFkvhbVvj9ibO9VYhbdfGVX1 RE2LBkWUS3d+zNlTuAeUC+7f65RzZTWQWpvQl0XnEq2SPscmwfyngZaPafd+p2pPggHY nXdFHQllRtmsjvDvTgTPIGh1LnZVvF5MIaLJUGwQzftBumuEN5U8qRBGUpbh9WF9b0Ue tjbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1690892006; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cjRqM+XjqX1Xuvw0nxwkdauQMImA252wVov7Kg5/gfo=; b=EsDRaa/NnC7MtoLZWYjjNxltk6iEUz3BboFvsMj0MP14/dh03LSy5sxicaKWlAX2dL cGQzGxcnaCg7fvyAd40JsGcS8B54c7Ye05oahU9KWW2bR1qIdajs1/TjtQk/SGVmQ4HH 5kd8rUr/tmNClZ6AtSFqlWqRXxI6BWj9+8BfFRgeNKJFq3WpwpSo6JndmcWVqFrwhT4l J19bffWRasdD/Juit9zV8Me+JQ2loGAfgJ+Lbhs+s8SDzab0XAbUkOSXcsPVwYVmij6m xrai54viwlGG1sJC8F18n5RRDuJihMa9ZKBg4G8K0CTzoVSupay01QTJxdjsM78Lk0N5 3xIw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1690892006; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cjRqM+XjqX1Xuvw0nxwkdauQMImA252wVov7Kg5/gfo=; b=B2yTSpb9ZG5W4q0AuKy4bbPz5AA0vsbp0lDB8vP5aAWyi2+9ST65sl6tJf5k96V5eu gJA0rvP7cS02gA293BaNBT+DpDeCYrkqN1qbV6kMvaVuUEZnxrrqOXqv7SbIZ1aJ4PSH 9Q+Yut7DxYFhp4pn/T8rYdEXRX+s27Q2pnVOWRrSE5KQKwdkmYKpjrt/nGCdXlhLHW+0 hB+O6cKtysSLZkaeDDIw+yhRx3YTc7cGnc2mtwdndMxRI4hnQo8kYql0jtoZJSNgsWSo sa1yQOROGl6QguxdkAq3TbDPsZR28aEtKAEm6X8jorOcqH3+HPFVmbEloYgszu2RZsal EdkQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1690892006; s=strato-dkim-0003; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cjRqM+XjqX1Xuvw0nxwkdauQMImA252wVov7Kg5/gfo=; b=RAjlMPjQoRY7IBn74SP4oslNAYtx4bnC3tgSxZsLDc74KdTCNRVVGbUAFhMCRP9ADv DagtMgP1A/wIA1DZVgCg== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisR5U0GIOxzsQPrGAhfM0BJebfTWeDWMtcJLtvI+aQ==" Date: Tue, 1 Aug 2023 14:13:17 +0200 From: Olaf Hering To: George Dunlap Cc: xen-devel@lists.xenproject.org, George Dunlap , Wei Liu , Anthony PERARD Subject: Re: [PATCH v1 7/7] xenalyze: handle more potential exit reason values from vmx.h Message-ID: <20230801141317.53844521.olaf@aepfle.de> In-Reply-To: References: <20230601142742.15489-1-olaf@aepfle.de> <20230601142742.15489-8-olaf@aepfle.de> X-Mailer: Claws Mail 20230724T063118.58ae3d58 hat ein Softwareproblem, kann man nichts machen. MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/5OA8GnnQmIdpCHIvi1e7iim"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit --Sig_/5OA8GnnQmIdpCHIvi1e7iim Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Fri, 28 Jul 2023 21:35:54 +0100 George Dunlap : > Everything looks good (including adding the missing strings), except for > the removal of the fixed array size. Call me paranoid, but if we define = it > as REASON_MAX length, then there will never be any way that a value less > than REASON_MAX causes a segfault (and if we assign a value higher than > REASON_MAX, the compiler will complain); whereas if we make it variable, = we > leave open the possibility that someone won't update REASON_MAX properly, > resulting in either segfaults (if REASON_MAX is too high) or missing > strings (if REASON_MAX is too low). I think the code needs to be rearranged to work with "array_size" instead. Olaf --Sig_/5OA8GnnQmIdpCHIvi1e7iim Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmTI9t0ACgkQ86SN7mm1 DoDJRRAAhg9TndADa8iMkqaX96wWJunwbGup/eUS/YRqgDjB0yt5hw4S+XscIVni DHkmnUJBMefeVmpZKeRSIKSBqjXPhPN7AUdebxYEFHbX0p+UdSXy8mLP5seUNLK5 REy7AT/zdG49AsfIV8t0AZvsQ9kDeey2TBDX0egnBSU94HtqmcuY1K4k0DE6XiA2 QjOkN4WW59ZPOLkGx/+y55X/sKN+eEOTHov2dXjbHpdC81CHh2i/iG/kXrBXjupj ppGzlcvtuHSnCDhj1YuIDiCpiKBDr6kZFM4P2LLK+ym9WV84q3k6+o2Kzj3eD1Hz thiqU6lCaVbOgCAeWIH5QTYSVk31sMUO6OqQsD0jh7t/VCaMA+4yZDgvHesZV0R4 q8OOsFGs/vkYdpPo2TQ8jAXyZLVNy3Flfz4l9VkE7uwT8tlCcttIafITII7mcbhD UGxVICO2OUSxTkJusx6FcXjd0jYoVto2iV1rOYBEv0oO87L6VtShG596Rg66WC09 YjUw+LVEGjiLARB5YvobQp8v9fqrMT/pqzXQUa+q3Hh0ZWpGfygQLL9byhA85m+x B3vHen5SugJJff5fMtrDxIfTJ5G4i6bzHuD067cEl9aoYJZ1ZPQUMzPmAZr3sJYC f/rDE9vhr6VGaKRESsDPfnswIgDpE6o54yIM8+0nAGryiDU6HHc= =OFI8 -----END PGP SIGNATURE----- --Sig_/5OA8GnnQmIdpCHIvi1e7iim-- From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:20:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:20:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574121.899302 (Exim 4.92) (envelope-from ) id 1qQoMq-0007f1-1Q; Tue, 01 Aug 2023 12:20:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574121.899302; Tue, 01 Aug 2023 12:20:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQoMp-0007eu-Tv; Tue, 01 Aug 2023 12:20:47 +0000 Received: by outflank-mailman (input) for mailman id 574121; Tue, 01 Aug 2023 12:20:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQoMo-0007eo-V8 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:20:47 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061b.outbound.protection.outlook.com [2a01:111:f400:fe1f::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6805a69-3065-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 14:20:44 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7695.eurprd04.prod.outlook.com (2603:10a6:102:e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 12:20:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 12:20:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6805a69-3065-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMSF/kDxDrmlWXFk5HTkBqPsaKf3b7eKWaIXNI6s6F5lEmOL6uC03xMJktkxNLFJk/g9ONNrRa5HfrrRG0Z9IpOcnjFqlQ2TO7yQCmVv94p2H27Gwt52f4CJWu7KDvyqwm3ibIFUCqg0DPjr9bgbibacvyPL9EH32tAsRUVRTZWrdXbas8oZ9nSEI9X9Y4zeZF4YgtZLCsu4Rb0/V+wicT3vK0Yobyq7n0IJy64CwTGux2UOmez/0emk61Oa+dB/IIWfvyoZVLFG5UJfpsLGteXDamehZ/3XSDBeHRmbEg1uddxURAd+f8Q5atpYR7iLsj+B4nSssKKdcMUZXqsncA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJAsgBWzXbaUDPMv8WqrnEVuL1ySu6i20kYftQ3JtMw=; b=j5VssgTIMw5QIqaIGvuaFyZq8LjLq8EgcfHNYnbm/HRm0nk1fow9P1Y28pfFtcaLEo4hxsKWjC0IHQgKX4YCkWsTmaFTEyEIQrlSJulox9OJ4mYrxiSVL8yXZ8Rj4lw3J5vbh5W0L54ySK3sU1AlpGusewp0MjbhNA0UZmHEeXB+VzmoYDY4Y5qy8J7uZQpm4sJ8+gC2Icm/uKMweddmoNGM5iZihXingJ811WBLWiNtBd0sU4g8guASj67lR/0jJIOLgdiz5+HS2CEjFcE1DVon/b3jR/IS6M0Yc6XypCp5QewbaY51sO8XpylH16V9XpKfKsxv7EhPb/3/KRIJ8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJAsgBWzXbaUDPMv8WqrnEVuL1ySu6i20kYftQ3JtMw=; b=1rFz3LBimzzvu+8sGb9vOe3UGGGyv9DgpKsdu9EyrI8R6SsfIv5uf7SFXFUoxE0nMfiw7Gq2PMjmNXQqv6OPJDQJVBoXNdoyo+mQ61Zr7Qtkqm9oIZeQDqNTGYihuc3NZOWYVoonZ08nFcAt13pu6GT9/oynIVV6nsJsK8bjh05Z/g37Pz8ZUed/CjBIhCEdi40u/YJ7Q4jbE3Q1innt3ScreZM7pbghcR7LSLgQcUR5ufLQvBoSxDs1c/3rKy5Ioog2qsT8ucHj3AEEvOBvMkPPBx69AFrm3avYzzHiVnsZrd4mZggu+Uk7gcMLaVC7FDLWnegPHG9xsUnr0jgmUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0b2cb188-bcb1-1ed3-1181-9e1d0d98ab4a@suse.com> Date: Tue, 1 Aug 2023 14:20:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <335ce2a18f8cce679dd8b30d11560989131b4337.1690579561.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <335ce2a18f8cce679dd8b30d11560989131b4337.1690579561.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7695:EE_ X-MS-Office365-Filtering-Correlation-Id: 3bf7b5ad-1b52-4986-a438-08db9289b99e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Qvc/TFTdbsxvw6+6FkSXuPSuI8PPgGfgrRgyh4C/DcardTSZV3FYZfRggshHawqzv732ogWls1RIeH2hE5ih2XazJ09TVCoDd2f+QDS2qZM+8eUeC+oE30BoXAT6Gvbdr8SbAptPN9oXlL6XZ/BnukxjStnWoWR0wHXBQxHqGrTooccUgy6TJnEalM5ZKX4Wo5rdBsUUyp32bGdcPZbzHdJM+kATf4LfCqjyMnh0rNxnrI4RigZnzqOk9hEfqtm1L9ehMatAL4jGdGvbzP3VYBBsD9dKwSDDis4JT5C7UHu2eOg0PIpYdBTWPJjW4Vxx92ilmaOu4b5j5c1d06JmSuAE4hLTmUheu2GSItnE1isIt6D+4+X0S8I6oBiHKja3V7pv//MLHByKG1E7MGMJK/fUFdQYEUk6H7kdIfn+pFG6G2GKFYYm8+XTsVgTYtSNc9CjevTRNsMn4cTI7qTbl3/GgUifH/mBdn0Oz4oS2D6Xbpphm8bydmdO0678LpN2WfIgGdPG+Nt0y3oxmaYW32lFNLhDpAIZiC/OfEqrBPeVGI169HbFrJMGNrwkK2RhyivLsdWPAXEAWEraKx5DEEWK4CdRq8cY4WWPJO3JNPokN+MR5R5QDGnulNMSO7esmm4Djib+spx+IFYDo2Ckg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(376002)(396003)(366004)(451199021)(8676002)(8936002)(38100700002)(31696002)(26005)(86362001)(41300700001)(2616005)(4744005)(2906002)(36756003)(6506007)(53546011)(186003)(5660300002)(4326008)(6916009)(66556008)(66476007)(66946007)(6512007)(31686004)(54906003)(478600001)(6486002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjVQci9QOWRxTVd4QnRIZzdJSnZqdFQrVGlyRWVWYVlrSGRtRTZCOGI5QllG?= =?utf-8?B?aTZqWjdaYmxCSDc3eUpQTk9pMlFvY3QydjFBYkg3QkF0UGQ1ZDZBNkJiSWZL?= =?utf-8?B?SXdOM2tDak52bDhmTWdEdlkvUGR6RW1aNERFRTRzU2EycjFjSi80YVBoZVZm?= =?utf-8?B?U1JBR056Sm9EQ05GVyt3NU1IN01vc3pFc2dhMVdOSzc2YWV1ZWFEUGMzbE9U?= =?utf-8?B?ZVBBY0xiUGx3OTFmaW0xZkdhN0RVbE1KREJ0ZWh4Q1drcjgvek9wdXlRV1Q1?= =?utf-8?B?eUtjd1JmVEFLckNkUk5lcHMzUE5EMzJWZnlSZS9hVzdicGNlVmRnQlVSMW1r?= =?utf-8?B?S3NDcm5ZUGx1WHA4ZmJpNnB2d0s0NEpCU01iZ2hCMEdvOHVBanc5TjFhZmRN?= =?utf-8?B?ZERpSUt6K3NOaGJyV2ZnVS94RkxGUjEzbXNwQnZtai93SFNhNVpSc1l4Z05w?= =?utf-8?B?TERZQWhyNmZCREMwUUc3MjJOSDJpS3phZkxicDMwYWlJNG1RMVltSkozalFu?= =?utf-8?B?c09SalhFSWFjRXYwaWZ2NGZiZklCNGNUY0VtZ2pKbHZ0L3lpWWdLOElBdm5T?= =?utf-8?B?RU4zVFdmSUZIK29vVmRpR1lJL0M5b3lnWHNqTGN1NUJGbUtzTlU5Q0xmb1Mz?= =?utf-8?B?cU9VTDZ1YWJQQ0pUR2VLcFVlNXg2d01TcDFIYmJ1VEpocGViUVU5d3BCWjd1?= =?utf-8?B?Y2hDOTZkaCt3T3NRRHJSczZQQzFWM045VmZDdTNzeU1hWThQTEd1a2JYOHEr?= =?utf-8?B?ZTBIdGg4aTlmN0t2SHhVQ0ptMHR2Q3Zvb3NON28zaUhwaGpxQUJPZXZZenpr?= =?utf-8?B?VzRsSlZjdC9jbDRwQVNPVG1TTUxwUHExZFFiRStCU3RQcHFUcTFkTHoyNmV6?= =?utf-8?B?SDVNVldTdFYzUTQwV1p3eVQ4Mmh3S3kvVlZ1VkFyMlJyZ29BTEhFS2dJa1lu?= =?utf-8?B?U25xdHlPTHJDc1FPQ1pvbi9FUmk0NkFiUmhuclZoS2pFcXBzdi9KSnkyNmZj?= =?utf-8?B?QUl1dkVGR2dMMjFlMW9oNlhZUko1UWhycUVVMHhWS3h4STN2emYvNUxmMzcr?= =?utf-8?B?TXEwOE81ZEdjNnUvY2d0NjBSeTE5ZHRNTHQ0WmNDTWhVa3RNVkZQWjA1YkRn?= =?utf-8?B?ZE12S2V4RjlCdzJGdVpPL25TalF0V3A0bzhVNlFkcktWdWhKRlpJcFVzMWpU?= =?utf-8?B?dnIvcmVJV29TYWRkbUwxRnlTSHJ3TmMxYS9jVkRUZ08rYlhpbUF3U0xud3B5?= =?utf-8?B?N01ua25tdXZvZDNFVCs1VTcwMGhsSG1JVGRpQ25OWFFka21EcktXSUpFNUpW?= =?utf-8?B?SVFuWmFpVE5pMjlOVEtIdS9IcXJHT2VjNkpOUU9qQWxEYjdHbmV2d2NjUWhR?= =?utf-8?B?UDRiVGEzdDRJL3AyY2EwMGNURjQvUVZLcHl3c3RYNG5WaGovRG1JWWxqNTQr?= =?utf-8?B?aEpPRkVNblhOVkcxNEV3dnVGUTY5TGVtU1VEcnpSZmRncnMrT052UW5OM3p1?= =?utf-8?B?cHJ0WW5uc2pJNUtmbnpidHgwQzI3czM1UDVNZzBBSU0zY2FIc3RzdU84SGI3?= =?utf-8?B?Z1ltQUZXUThWNkkrTmR1aXJhMUtra0J4a1J4SndNWTVPZmlpSHlna1FlS1pH?= =?utf-8?B?Yzc2OW0ycjYybTQraEpJdXhxT0RCMlQwOFFJay90YlpTLzMvVlNtVENvK3A2?= =?utf-8?B?b0JyQ0Fzc2p5SGhlMkNWUy80WTZCQ3cvMXJJVEhsVUxPVk1IcDZNZTFkT1Iv?= =?utf-8?B?eWp2UjluZzNGK3VNSWoxMVFMNGJ3ZUE4OFBySEFtTGNMRWd3aHRQakMrNXRh?= =?utf-8?B?b2FQVVN3ekdOZmFkVXMxQXdpWmErUEYwZFVIaW5CNTlWSGRaNnQ1WG1QME1D?= =?utf-8?B?SmlXWWN6UjZVUlR3Q1RJQU5SekhNVjRremFqenZrMHU4dGtXU0xDYXF6N0cz?= =?utf-8?B?UXlXVXVpNHBGckcxby9ieVVmcFhoSXdSZUlVN3lETXN0QzJVLzFFa3hEQlJB?= =?utf-8?B?VXRHSGtVcHJGTmdaM1hxaGtKenc1Wm5mZlQyRTRhVFl0dGd1cU0rdVIyeTF0?= =?utf-8?B?NTJGbmRzVncxZDBmNmhQakgySFpHaGtzOVFHVkdGay9oOEdVZjFmOCtuUzdo?= =?utf-8?Q?YE5D7tVnqjVdhSYxCiua5oWcH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3bf7b5ad-1b52-4986-a438-08db9289b99e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 12:20:42.7648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xH7z5oPfZ6O0SQAin63ndwkf/XLBaE5HbVTAHBukt0YBedAa3OWwYbbaEHcjC/W82MRkYUPMkO6DPuTI6OpzJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7695 On 28.07.2023 23:35, Shawn Anastasio wrote: > @@ -11,16 +13,19 @@ ENTRY(start) > FIXUP_ENDIAN > > /* set up the TOC pointer */ > - LOAD_IMM32(%r2, .TOC.) > + bcl 20, 31, .+4 > +1: mflr %r12 > + addis %r2, %r12, .TOC.-1b@ha > + addi %r2, %r2, .TOC.-1b@l > > /* set up the initial stack */ > - LOAD_IMM32(%r1, cpu0_boot_stack) > + LOAD_REG_ADDR(%r1, cpu0_boot_stack) Question: Would perhaps make sense to use %sp and %rtoc in place of %r1 and %r2 (not just here of course)? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:39:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:39:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574128.899311 (Exim 4.92) (envelope-from ) id 1qQof8-0000rP-GX; Tue, 01 Aug 2023 12:39:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574128.899311; Tue, 01 Aug 2023 12:39:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQof8-0000rI-E2; Tue, 01 Aug 2023 12:39:42 +0000 Received: by outflank-mailman (input) for mailman id 574128; Tue, 01 Aug 2023 12:39:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQof7-0000r8-4t; Tue, 01 Aug 2023 12:39:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQof7-0003qY-2F; Tue, 01 Aug 2023 12:39:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQof6-0007HI-Ia; Tue, 01 Aug 2023 12:39:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qQof6-0005cZ-I3; Tue, 01 Aug 2023 12:39:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lmAfiUsMHa4WXes13kR2BK2h29MjO/JZpxnYByTClHs=; b=njqxdzqAIWi2rzjNhQof2pFlc8 YL23nBL1ZL4Ojm9fMbmSaQlt/9s40wbcrpT4M3ouZUt7FG83QPWyycfwDEiLnCp5aP8sMdmCe+I7c noJStmAAkHCVp4SgTuWasVtTg36lAXy1jF0p+Dh+Do45A+8cGVjlNf15GHR9G/syYDyo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182100: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c2026b88b58cbb6a84e2885c320a8cfe08f8ffc8 X-Osstest-Versions-That: xen=70eb862b01023c45b943e8ff92ef4f6a7e9e8950 From: osstest service owner Date: Tue, 01 Aug 2023 12:39:40 +0000 flight 182100 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182100/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c2026b88b58cbb6a84e2885c320a8cfe08f8ffc8 baseline version: xen 70eb862b01023c45b943e8ff92ef4f6a7e9e8950 Last test of basis 182098 2023-07-31 20:00:37 Z 0 days Testing same since 182100 2023-08-01 10:03:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Federico Serafini Jan Beulich Nicola Vetrini Roger Pau MonnĂ© jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 70eb862b01..c2026b88b5 c2026b88b58cbb6a84e2885c320a8cfe08f8ffc8 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:48:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574137.899326 (Exim 4.92) (envelope-from ) id 1qQonf-0002QM-Kd; Tue, 01 Aug 2023 12:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574137.899326; Tue, 01 Aug 2023 12:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQonf-0002PQ-Fu; Tue, 01 Aug 2023 12:48:31 +0000 Received: by outflank-mailman (input) for mailman id 574137; Tue, 01 Aug 2023 12:48:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQond-0002MY-Og for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:48:29 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5b11ccd-3069-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 14:48:27 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 9D86E4EE0737; Tue, 1 Aug 2023 14:48:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5b11ccd-3069-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , "Daniel P. Smith" Subject: [XEN PATCH v2 0/3] xen: address MISRA C:2012 Rule 5.3 Date: Tue, 1 Aug 2023 14:47:41 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". The following two strategies are adopted to deal with some violations of this rule: - renaming of local variables, functions or parameters; - removal of unnecessary declarations. No functional changes. Changes in v2: - Patches 1/4 and 2/4 from the previous version of this patch (https://lore.kernel.org/xen-devel/cover.1690810346.git.nicola.vetrini@bugseng.com/) are already committed to staging, therefore are excluded from this series. Nicola Vetrini (3): xen/common: address MISRA C:2012 Rule 5.3 drivers/char: address MISRA C:2012 Rule 5.3 arm/efi: address MISRA C:2012 Rule 5.3 xen/arch/arm/efi/efi-boot.h | 84 ++++++++++++++++++------------------ xen/common/compat/memory.c | 7 ++- xen/common/numa.c | 20 ++++----- xen/drivers/char/ehci-dbgp.c | 4 +- xen/drivers/char/ns16550.c | 6 +-- 5 files changed, 59 insertions(+), 62 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:48:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574136.899322 (Exim 4.92) (envelope-from ) id 1qQonf-0002N0-Bg; Tue, 01 Aug 2023 12:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574136.899322; Tue, 01 Aug 2023 12:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQonf-0002Mt-8q; Tue, 01 Aug 2023 12:48:31 +0000 Received: by outflank-mailman (input) for mailman id 574136; Tue, 01 Aug 2023 12:48:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQond-0002MS-I7 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:48:29 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6a4c424-3069-11ee-b25a-6b7b168915f2; Tue, 01 Aug 2023 14:48:29 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 0CFED4EE0742; Tue, 1 Aug 2023 14:48:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6a4c424-3069-11ee-b25a-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH v2 2/3] drivers/char: address MISRA C:2012 Rule 5.3 Date: Tue, 1 Aug 2023 14:47:43 +0200 Message-Id: <69fad93eeafdceae5de1f2483015f05d1798b6be.1690893696.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following strategies are adopted to deal with violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". Local variable 'ctrl' shadows a variable defined in an outer scope. Since the innermost variable is used only once after being set, it is safe to remove it entirely. The enum constant 'baud' is shadowed by local a local variable at line 1476, and renaming the enum constant avoid such conflicts. Signed-off-by: Nicola Vetrini --- Changes in v2: - Renamed the enum constant instead of the local variable 'baud'. - Removed the inner variable entirely, as it serves no purpose. --- xen/drivers/char/ehci-dbgp.c | 4 +--- xen/drivers/char/ns16550.c | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c index 4d8d765122..72be4d9cc9 100644 --- a/xen/drivers/char/ehci-dbgp.c +++ b/xen/drivers/char/ehci-dbgp.c @@ -424,9 +424,7 @@ static void dbgp_issue_command(struct ehci_dbgp *dbgp, u32 ctrl, * checks to see if ACPI or some other initialization also * reset the EHCI debug port. */ - u32 ctrl = readl(&dbgp->ehci_debug->control); - - if ( ctrl & DBGP_ENABLED ) + if ( readl(&dbgp->ehci_debug->control) & DBGP_ENABLED ) { cmd |= CMD_RUN; writel(cmd, &dbgp->ehci_regs->command); diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 212a9c49ae..b75e7f8fa0 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1388,7 +1388,7 @@ string_param("com1", opt_com1); string_param("com2", opt_com2); enum serial_param_type { - baud, + baud_rate, clock_hz, data_bits, io_base, @@ -1416,7 +1416,7 @@ struct serial_param_var { * com_console_options for serial port com1 and com2. */ static const struct serial_param_var __initconst sp_vars[] = { - {"baud", baud}, + {"baud", baud_rate}, {"clock-hz", clock_hz}, {"data-bits", data_bits}, {"io-base", io_base}, @@ -1596,7 +1596,7 @@ static bool __init parse_namevalue_pairs(char *str, struct ns16550 *uart) switch ( get_token(token, ¶m_value) ) { - case baud: + case baud_rate: uart->baud = simple_strtoul(param_value, NULL, 0); break; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:48:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574138.899333 (Exim 4.92) (envelope-from ) id 1qQonf-0002Ws-Te; Tue, 01 Aug 2023 12:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574138.899333; Tue, 01 Aug 2023 12:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQonf-0002UK-OV; Tue, 01 Aug 2023 12:48:31 +0000 Received: by outflank-mailman (input) for mailman id 574138; Tue, 01 Aug 2023 12:48:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQone-0002MY-EP for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:48:30 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b614396e-3069-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 14:48:28 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 256D34EE0741; Tue, 1 Aug 2023 14:48:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b614396e-3069-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH v2 1/3] xen/common: address MISRA C:2012 Rule 5.3 Date: Tue, 1 Aug 2023 14:47:42 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following strategies are adopted to deal with violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". - s/nodes/numa_nodes/ for the file-scope variable in 'common/numa.c'; - move the variable 'struct compat_remove_from_physmap cmp' inside the outer union variable 'cmp' to avoid shadowing it. Signed-off-by: Nicola Vetrini --- Changes in v2: - Split the patch in common/ and drivers/. - Moved the local cmp into the union as a member. - Renamed the file-scope variable instead of parameters/local variables. --- xen/common/compat/memory.c | 7 +++---- xen/common/numa.c | 20 ++++++++++---------- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/xen/common/compat/memory.c b/xen/common/compat/memory.c index 8ca63ceda6..d000a5d93d 100644 --- a/xen/common/compat/memory.c +++ b/xen/common/compat/memory.c @@ -81,6 +81,7 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat) struct compat_memory_exchange xchg; struct compat_add_to_physmap atp; struct compat_add_to_physmap_batch atpb; + struct compat_remove_from_physmap rmfp; struct compat_vnuma_topology_info vnuma; struct compat_mem_access_op mao; struct compat_mem_acquire_resource mar; @@ -321,12 +322,10 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat) case XENMEM_remove_from_physmap: { - struct compat_remove_from_physmap cmp; - - if ( copy_from_guest(&cmp, compat, 1) ) + if ( copy_from_guest(&cmp.rmfp, compat, 1) ) return -EFAULT; - XLAT_remove_from_physmap(nat.xrfp, &cmp); + XLAT_remove_from_physmap(nat.xrfp, &cmp.rmfp); break; } diff --git a/xen/common/numa.c b/xen/common/numa.c index fc1f7f665b..f454c4d894 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -15,7 +15,7 @@ static nodemask_t __initdata processor_nodes_parsed; static nodemask_t __initdata memory_nodes_parsed; -static struct node __initdata nodes[MAX_NUMNODES]; +static struct node __initdata numa_nodes[MAX_NUMNODES]; static unsigned int __ro_after_init num_node_memblks; static struct node __ro_after_init node_memblk_range[NR_NODE_MEMBLKS]; @@ -117,7 +117,7 @@ static enum conflicts __init conflicting_memblks( static void __init cutoff_node(nodeid_t i, paddr_t start, paddr_t end) { - struct node *nd = &nodes[i]; + struct node *nd = &numa_nodes[i]; if ( nd->start < start ) { @@ -157,7 +157,7 @@ bool __init numa_update_node_memblks(nodeid_t node, unsigned int arch_nid, paddr_t end = start + size; paddr_t nd_start = start; paddr_t nd_end = end; - struct node *nd = &nodes[node]; + struct node *nd = &numa_nodes[node]; /* * For the node that already has some memory blocks, we will @@ -292,17 +292,17 @@ static bool __init nodes_cover_memory(void) do { found = false; for_each_node_mask ( j, memory_nodes_parsed ) - if ( start < nodes[j].end && end > nodes[j].start ) + if ( start < numa_nodes[j].end && end > numa_nodes[j].start ) { - if ( start >= nodes[j].start ) + if ( start >= numa_nodes[j].start ) { - start = nodes[j].end; + start = numa_nodes[j].end; found = true; } - if ( end <= nodes[j].end ) + if ( end <= numa_nodes[j].end ) { - end = nodes[j].start; + end = numa_nodes[j].start; found = true; } } @@ -356,10 +356,10 @@ static bool __init numa_process_nodes(paddr_t start, paddr_t end) /* Finally register nodes */ for_each_node_mask ( i, all_nodes_parsed ) { - if ( nodes[i].end == nodes[i].start ) + if ( numa_nodes[i].end == numa_nodes[i].start ) printk(KERN_INFO "NUMA: node %u has no memory\n", i); - setup_node_bootmem(i, nodes[i].start, nodes[i].end); + setup_node_bootmem(i, numa_nodes[i].start, numa_nodes[i].end); } for ( i = 0; i < nr_cpu_ids; i++ ) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:48:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:48:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574139.899342 (Exim 4.92) (envelope-from ) id 1qQong-0002hV-DB; Tue, 01 Aug 2023 12:48:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574139.899342; Tue, 01 Aug 2023 12:48:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQong-0002eB-5B; Tue, 01 Aug 2023 12:48:32 +0000 Received: by outflank-mailman (input) for mailman id 574139; Tue, 01 Aug 2023 12:48:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQone-0002MS-Th for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:48:31 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b72c0eff-3069-11ee-b25a-6b7b168915f2; Tue, 01 Aug 2023 14:48:30 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 0193A4EE0743; Tue, 1 Aug 2023 14:48:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b72c0eff-3069-11ee-b25a-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "Daniel P. Smith" Subject: [XEN PATCH v2 3/3] arm/efi: address MISRA C:2012 Rule 5.3 Date: Tue, 1 Aug 2023 14:47:44 +0200 Message-Id: <688eea3584d537b6f41bb32f227f8be74ffd2783.1690893696.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The file-scope variable 'fdt' is shadowed by function parameters, and thus violates the rule, hence it's renamed to 'fdt_efi' No functional changes. Signed-off-by: Nicola Vetrini --- Changes in v2: - Renamed the file-scope variable instead of removing function parameters. --- xen/arch/arm/efi/efi-boot.h | 84 ++++++++++++++++++------------------- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index 6126a71400..f24df2abb9 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -49,7 +49,7 @@ static void PrintMessage(const CHAR16 *s); {0xb1b621d5U, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0}} static struct file __initdata dtbfile; -static void __initdata *fdt; +static void __initdata *fdt_efi; static void __initdata *memmap; static int __init setup_chosen_node(void *fdt, int *addr_cells, int *size_cells) @@ -383,7 +383,7 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable, if ( EFI_ERROR(status) ) blexit(L"EFI memory map processing failed"); - status = fdt_add_uefi_nodes(SystemTable, fdt, map, map_size, desc_size, + status = fdt_add_uefi_nodes(SystemTable, fdt_efi, map, map_size, desc_size, desc_ver); if ( EFI_ERROR(status) ) PrintErrMesg(L"Updating FDT failed", status); @@ -395,7 +395,7 @@ static void __init efi_arch_pre_exit_boot(void) static void __init noreturn efi_arch_post_exit_boot(void) { - efi_xen_start(fdt, fdt_totalsize(fdt)); + efi_xen_start(fdt_efi, fdt_totalsize(fdt_efi)); } static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, @@ -420,8 +420,8 @@ static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, efi_bs->FreePool(name.w); } } - fdt = fdt_increase_size(&dtbfile, cfg.size + EFI_PAGE_SIZE); - if ( !fdt ) + fdt_efi = fdt_increase_size(&dtbfile, cfg.size + EFI_PAGE_SIZE); + if ( !fdt_efi ) blexit(L"Unable to create new FDT"); } @@ -465,7 +465,7 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, int chosen; /* locate chosen node, which is where we add Xen module info. */ - chosen = fdt_subnode_offset(fdt, 0, "chosen"); + chosen = fdt_subnode_offset(fdt_efi, 0, "chosen"); if ( chosen < 0 ) blexit(L"Unable to find chosen node"); @@ -498,7 +498,7 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, else { /* Get xen,xen-bootargs in /chosen if it is specified */ - const char *dt_bootargs_prop = fdt_getprop(fdt, chosen, + const char *dt_bootargs_prop = fdt_getprop(fdt_efi, chosen, "xen,xen-bootargs", NULL); if ( dt_bootargs_prop ) { @@ -526,7 +526,7 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, blexit(L"FDT string overflow"); } - if ( fdt_setprop_string(fdt, chosen, "xen,xen-bootargs", buf) < 0 ) + if ( fdt_setprop_string(fdt_efi, chosen, "xen,xen-bootargs", buf) < 0 ) blexit(L"Unable to set xen,xen-bootargs property."); efi_bs->FreePool(buf); @@ -542,7 +542,7 @@ static void __init efi_arch_handle_module(const struct file *file, if ( file == &dtbfile ) return; - chosen = setup_chosen_node(fdt, &addr_len, &size_len); + chosen = setup_chosen_node(fdt_efi, &addr_len, &size_len); if ( chosen < 0 ) blexit(L"Unable to setup chosen node"); @@ -551,13 +551,13 @@ static void __init efi_arch_handle_module(const struct file *file, static const char __initconst ramdisk_compat[] = "multiboot,ramdisk\0" "multiboot,module"; - node = fdt_add_subnode(fdt, chosen, "ramdisk"); + node = fdt_add_subnode(fdt_efi, chosen, "ramdisk"); if ( node < 0 ) blexit(L"Unable to add ramdisk FDT node."); - if ( fdt_setprop(fdt, node, "compatible", ramdisk_compat, + if ( fdt_setprop(fdt_efi, node, "compatible", ramdisk_compat, sizeof(ramdisk_compat)) < 0 ) blexit(L"Unable to set compatible property."); - if ( fdt_set_reg(fdt, node, addr_len, size_len, ramdisk.addr, + if ( fdt_set_reg(fdt_efi, node, addr_len, size_len, ramdisk.addr, ramdisk.size) < 0 ) blexit(L"Unable to set reg property."); } @@ -566,13 +566,13 @@ static void __init efi_arch_handle_module(const struct file *file, static const char __initconst xsm_compat[] = "xen,xsm-policy\0" "multiboot,module"; - node = fdt_add_subnode(fdt, chosen, "xsm"); + node = fdt_add_subnode(fdt_efi, chosen, "xsm"); if ( node < 0 ) blexit(L"Unable to add xsm FDT node."); - if ( fdt_setprop(fdt, node, "compatible", xsm_compat, + if ( fdt_setprop(fdt_efi, node, "compatible", xsm_compat, sizeof(xsm_compat)) < 0 ) blexit(L"Unable to set compatible property."); - if ( fdt_set_reg(fdt, node, addr_len, size_len, xsm.addr, + if ( fdt_set_reg(fdt_efi, node, addr_len, size_len, xsm.addr, xsm.size) < 0 ) blexit(L"Unable to set reg property."); } @@ -581,15 +581,15 @@ static void __init efi_arch_handle_module(const struct file *file, static const char __initconst kernel_compat[] = "multiboot,kernel\0" "multiboot,module"; - node = fdt_add_subnode(fdt, chosen, "kernel"); + node = fdt_add_subnode(fdt_efi, chosen, "kernel"); if ( node < 0 ) blexit(L"Unable to add dom0 FDT node."); - if ( fdt_setprop(fdt, node, "compatible", kernel_compat, + if ( fdt_setprop(fdt_efi, node, "compatible", kernel_compat, sizeof(kernel_compat)) < 0 ) blexit(L"Unable to set compatible property."); - if ( options && fdt_setprop_string(fdt, node, "bootargs", options) < 0 ) + if ( options && fdt_setprop_string(fdt_efi, node, "bootargs", options) < 0 ) blexit(L"Unable to set bootargs property."); - if ( fdt_set_reg(fdt, node, addr_len, size_len, kernel.addr, + if ( fdt_set_reg(fdt_efi, node, addr_len, size_len, kernel.addr, kernel.size) < 0 ) blexit(L"Unable to set reg property."); } @@ -719,7 +719,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, module_info *file; /* Check if the node is a multiboot,module otherwise return */ - module_compat = fdt_node_check_compatible(fdt, module_node_offset, + module_compat = fdt_node_check_compatible(fdt_efi, module_node_offset, "multiboot,module"); if ( module_compat < 0 ) /* Error while checking the compatible string */ @@ -730,7 +730,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, return 0; /* Read xen,uefi-binary property to get the file name. */ - uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary", + uefi_name_prop = fdt_getprop(fdt_efi, module_node_offset, "xen,uefi-binary", &uefi_name_len); if ( !uefi_name_prop ) @@ -751,13 +751,13 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, snprintf(mod_string, sizeof(mod_string), "module@%"PRIx64, file->addr); /* Rename the module to be module@{address} */ - if ( fdt_set_name(fdt, module_node_offset, mod_string) < 0 ) + if ( fdt_set_name(fdt_efi, module_node_offset, mod_string) < 0 ) { PrintMessage(L"Unable to modify module node name."); return ERROR_RENAME_MODULE_NAME; } - if ( fdt_set_reg(fdt, module_node_offset, reg_addr_cells, reg_size_cells, + if ( fdt_set_reg(fdt_efi, module_node_offset, reg_addr_cells, reg_size_cells, file->addr, file->size) < 0 ) { PrintMessage(L"Unable to set module reg property."); @@ -766,7 +766,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, if ( !is_domu_module ) { - if ( (fdt_node_check_compatible(fdt, module_node_offset, + if ( (fdt_node_check_compatible(fdt_efi, module_node_offset, "multiboot,kernel") == 0) ) { /* @@ -784,14 +784,14 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, kernel.size = file->size; } else if ( ramdisk.addr && - (fdt_node_check_compatible(fdt, module_node_offset, + (fdt_node_check_compatible(fdt_efi, module_node_offset, "multiboot,ramdisk") == 0) ) { PrintMessage(L"Dom0 ramdisk already found in cfg file."); return ERROR_DOM0_RAMDISK_FOUND; } else if ( xsm.addr && - (fdt_node_check_compatible(fdt, module_node_offset, + (fdt_node_check_compatible(fdt_efi, module_node_offset, "xen,xsm-policy") == 0) ) { PrintMessage(L"XSM policy already found in cfg file."); @@ -816,7 +816,7 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima unsigned int mb_modules_found = 0; /* Get #address-cells and #size-cells from domain node */ - prop = fdt_get_property(fdt, domain_node, "#address-cells", &len); + prop = fdt_get_property(fdt_efi, domain_node, "#address-cells", &len); if ( !prop ) { PrintMessage(L"#address-cells not found in domain node."); @@ -825,7 +825,7 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima addr_cells = fdt32_to_cpu(*((uint32_t *)prop->data)); - prop = fdt_get_property(fdt, domain_node, "#size-cells", &len); + prop = fdt_get_property(fdt_efi, domain_node, "#size-cells", &len); if ( !prop ) { PrintMessage(L"#size-cells not found in domain node."); @@ -835,9 +835,9 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima size_cells = fdt32_to_cpu(*((uint32_t *)prop->data)); /* Check for nodes compatible with multiboot,module inside this node */ - for ( module_node = fdt_first_subnode(fdt, domain_node); + for ( module_node = fdt_first_subnode(fdt_efi, domain_node); module_node > 0; - module_node = fdt_next_subnode(fdt, module_node) ) + module_node = fdt_next_subnode(fdt_efi, module_node) ) { int ret = handle_module_node(loaded_image, dir_handle, module_node, addr_cells, size_cells, true); @@ -862,7 +862,7 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) EFI_FILE_HANDLE dir_handle = NULL; /* Check for the chosen node in the current DTB */ - chosen = setup_chosen_node(fdt, &addr_len, &size_len); + chosen = setup_chosen_node(fdt_efi, &addr_len, &size_len); if ( chosen < 0 ) { PrintMessage(L"Unable to setup chosen node"); @@ -870,13 +870,13 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) } /* Check for nodes compatible with xen,domain under the chosen node */ - for ( node = fdt_first_subnode(fdt, chosen); + for ( node = fdt_first_subnode(fdt_efi, chosen); node > 0; - node = fdt_next_subnode(fdt, node) ) + node = fdt_next_subnode(fdt_efi, node) ) { int ret; - if ( !fdt_node_check_compatible(fdt, node, "xen,domain") ) + if ( !fdt_node_check_compatible(fdt_efi, node, "xen,domain") ) { /* Found a node with compatible xen,domain; handle this node. */ ret = handle_dom0less_domain_node(loaded_image, &dir_handle, node); @@ -951,29 +951,29 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) * node to decide whether to skip the UEFI Xen configuration file or not. */ - fdt = lookup_fdt_config_table(SystemTable); - dtbfile.ptr = fdt; + fdt_efi = lookup_fdt_config_table(SystemTable); + dtbfile.ptr = fdt_efi; dtbfile.need_to_free = false; /* Config table memory can't be freed. */ - if ( fdt && - (fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0) ) + if ( fdt_efi && + (fdt_node_offset_by_compatible(fdt_efi, 0, "multiboot,module") > 0) ) { /* Locate chosen node */ - int node = fdt_subnode_offset(fdt, 0, "chosen"); + int node = fdt_subnode_offset(fdt_efi, 0, "chosen"); const void *cfg_load_prop; int cfg_load_len; if ( node > 0 ) { /* Check if xen,uefi-cfg-load property exists */ - cfg_load_prop = fdt_getprop(fdt, node, "xen,uefi-cfg-load", + cfg_load_prop = fdt_getprop(fdt_efi, node, "xen,uefi-cfg-load", &cfg_load_len); if ( !cfg_load_prop ) load_cfg_file = false; } } - if ( !fdt || load_cfg_file ) + if ( !fdt_efi || load_cfg_file ) { /* * We either have no FDT, or one without modules, so we must have a @@ -983,7 +983,7 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) } PrintStr(L"Using modules provided by bootloader in FDT\r\n"); /* We have modules already defined in fdt, just add space. */ - fdt = fdt_increase_size(&dtbfile, EFI_PAGE_SIZE); + fdt_efi = fdt_increase_size(&dtbfile, EFI_PAGE_SIZE); return false; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 12:54:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 12:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574158.899362 (Exim 4.92) (envelope-from ) id 1qQotn-0005VT-00; Tue, 01 Aug 2023 12:54:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574158.899362; Tue, 01 Aug 2023 12:54:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQotm-0005VM-S9; Tue, 01 Aug 2023 12:54:50 +0000 Received: by outflank-mailman (input) for mailman id 574158; Tue, 01 Aug 2023 12:54:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQotl-0005VG-SR for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 12:54:50 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 981b27ce-306a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 14:54:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BBEB01FD7C; Tue, 1 Aug 2023 12:54:46 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 600F1139BD; Tue, 1 Aug 2023 12:54:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sr9XFpYAyWQSNAAAMHmgww (envelope-from ); Tue, 01 Aug 2023 12:54:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 981b27ce-306a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690894486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+eWlQeeVC2euHUSOeWbcjmCz76Xb9mTKJnw2WhwjLg=; b=t7s75b7DrHPYfkCXw7FDYSyFbZ+eFfBMn15m7OYOVuSyyLrlrCbVEtuSsgMFKIyIvv5Ho5 CXs2jrmvNmzRG22y9IPvSJeuTYeoARHIdanewOkoZNAj1zOai/qIhM0+qzi/l1cfU0dgBj nlIvHEHnHQqn+SrpvAfOym8rWB7ZtPY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690894486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+eWlQeeVC2euHUSOeWbcjmCz76Xb9mTKJnw2WhwjLg=; b=L/+EhMg6JTslMiA7SDZmOv5ox9H011tP9374Q3zbVOlIKn4lUfyKLSfdapnaVSEAMmM1w9 gR5xSz+JTBsoWoDg== Date: Tue, 01 Aug 2023 14:54:45 +0200 Message-ID: <87leeugbxm.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: alsa-devel@alsa-project.org, Andy Shevchenko , Andrey Utkin , Anton Sviridenko , Arnaud Pouliquen , Banajit Goswami , Bluecherry Maintainers , Claudiu Beznea , Ismael Luceno , Lars-Peter Clausen , Mauro Carvalho Chehab , Oleksandr Andrushchenko , Olivier Moysan , Srinivas Kandagatla , linux-media@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t In-Reply-To: References: <20230731154718.31048-1-tiwai@suse.de> <87h6pjj2ui.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Mon, 31 Jul 2023 21:40:20 +0200, Mark Brown wrote: > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > It really feels like we ought to rename, or add an alias for, the type > > > if we're going to start using it more widely - it's not helping to make > > > the code clearer. > > > That was my very first impression, too, but I changed my mind after > > seeing the already used code. An alias might work, either typedef or > > define genptr_t or such as sockptr_t. But we'll need to copy the > > bunch of helper functions, too... > > I would predict that if the type becomes more widely used that'll happen > eventually and the longer it's left the more work it'll be. That's true. The question is how more widely it'll be used, then. Is something like below what you had in mind, too? Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] Introduce uniptr_t as replacement of sockptr_t Although sockptr_t is used already in several places as a "universal" pointer, it's still too confusing as if were related with network stuff. Make a more generic type, uniptr_t, that does exactly as same as sockptr_t for a wider use. sockptr_t becomes now alias to uniptr_t. Signed-off-by: Takashi Iwai --- include/linux/sockptr.h | 124 +++++----------------------------------- include/linux/uniptr.h | 117 +++++++++++++++++++++++++++++++++++++ 2 files changed, 132 insertions(+), 109 deletions(-) create mode 100644 include/linux/uniptr.h diff --git a/include/linux/sockptr.h b/include/linux/sockptr.h index bae5e2369b4f..dc803989a4d6 100644 --- a/include/linux/sockptr.h +++ b/include/linux/sockptr.h @@ -1,118 +1,24 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* - * Copyright (c) 2020 Christoph Hellwig. - * - * Support for "universal" pointers that can point to either kernel or userspace - * memory. + * Aliases for the old sockptr_t and its helpers for the new uniptr_t */ #ifndef _LINUX_SOCKPTR_H #define _LINUX_SOCKPTR_H -#include -#include +#include -typedef struct { - union { - void *kernel; - void __user *user; - }; - bool is_kernel : 1; -} sockptr_t; - -static inline bool sockptr_is_kernel(sockptr_t sockptr) -{ - return sockptr.is_kernel; -} - -static inline sockptr_t KERNEL_SOCKPTR(void *p) -{ - return (sockptr_t) { .kernel = p, .is_kernel = true }; -} - -static inline sockptr_t USER_SOCKPTR(void __user *p) -{ - return (sockptr_t) { .user = p }; -} - -static inline bool sockptr_is_null(sockptr_t sockptr) -{ - if (sockptr_is_kernel(sockptr)) - return !sockptr.kernel; - return !sockptr.user; -} - -static inline int copy_from_sockptr_offset(void *dst, sockptr_t src, - size_t offset, size_t size) -{ - if (!sockptr_is_kernel(src)) - return copy_from_user(dst, src.user + offset, size); - memcpy(dst, src.kernel + offset, size); - return 0; -} - -static inline int copy_from_sockptr(void *dst, sockptr_t src, size_t size) -{ - return copy_from_sockptr_offset(dst, src, 0, size); -} - -static inline int copy_to_sockptr_offset(sockptr_t dst, size_t offset, - const void *src, size_t size) -{ - if (!sockptr_is_kernel(dst)) - return copy_to_user(dst.user + offset, src, size); - memcpy(dst.kernel + offset, src, size); - return 0; -} - -static inline int copy_to_sockptr(sockptr_t dst, const void *src, size_t size) -{ - return copy_to_sockptr_offset(dst, 0, src, size); -} - -static inline void *memdup_sockptr(sockptr_t src, size_t len) -{ - void *p = kmalloc_track_caller(len, GFP_USER | __GFP_NOWARN); - - if (!p) - return ERR_PTR(-ENOMEM); - if (copy_from_sockptr(p, src, len)) { - kfree(p); - return ERR_PTR(-EFAULT); - } - return p; -} - -static inline void *memdup_sockptr_nul(sockptr_t src, size_t len) -{ - char *p = kmalloc_track_caller(len + 1, GFP_KERNEL); - - if (!p) - return ERR_PTR(-ENOMEM); - if (copy_from_sockptr(p, src, len)) { - kfree(p); - return ERR_PTR(-EFAULT); - } - p[len] = '\0'; - return p; -} - -static inline long strncpy_from_sockptr(char *dst, sockptr_t src, size_t count) -{ - if (sockptr_is_kernel(src)) { - size_t len = min(strnlen(src.kernel, count - 1) + 1, count); - - memcpy(dst, src.kernel, len); - return len; - } - return strncpy_from_user(dst, src.user, count); -} - -static inline int check_zeroed_sockptr(sockptr_t src, size_t offset, - size_t size) -{ - if (!sockptr_is_kernel(src)) - return check_zeroed_user(src.user + offset, size); - return memchr_inv(src.kernel + offset, 0, size) == NULL; -} +#define sockptr_t uniptr_t +#define sockptr_is_kernel uniptr_is_kernel +#define KERNEL_SOCKPTR KERNEL_UNIPTR +#define USER_SOCKPTR USER_UNIPTR +#define sockptr_is_null uniptr_is_null +#define copy_from_sockptr_offset copy_from_uniptr_offset +#define copy_from_sockptr copy_from_uniptr +#define copy_to_sockptr_offset copy_to_uniptr_offset +#define copy_to_sockptr copy_to_uniptr +#define memdup_sockptr memdup_uniptr +#define memdup_sockptr_nul memdup_uniptr_nul +#define strncpy_from_sockptr strncpy_from_uniptr +#define check_zeroed_sockptr check_zeroed_uniptr #endif /* _LINUX_SOCKPTR_H */ diff --git a/include/linux/uniptr.h b/include/linux/uniptr.h new file mode 100644 index 000000000000..3ca9fc8eab4e --- /dev/null +++ b/include/linux/uniptr.h @@ -0,0 +1,117 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) 2020 Christoph Hellwig. + * + * Support for "universal" pointers that can point to either kernel or userspace + * memory. + */ +#ifndef _LINUX_UNIPTR_H +#define _LINUX_UNIPTR_H + +#include +#include + +typedef struct { + union { + void *kernel; + void __user *user; + }; + bool is_kernel : 1; +} uniptr_t; + +static inline bool uniptr_is_kernel(uniptr_t uniptr) +{ + return uniptr.is_kernel; +} + +static inline uniptr_t KERNEL_UNIPTR(void *p) +{ + return (uniptr_t) { .kernel = p, .is_kernel = true }; +} + +static inline uniptr_t USER_UNIPTR(void __user *p) +{ + return (uniptr_t) { .user = p }; +} + +static inline bool uniptr_is_null(uniptr_t uniptr) +{ + if (uniptr_is_kernel(uniptr)) + return !uniptr.kernel; + return !uniptr.user; +} + +static inline int copy_from_uniptr_offset(void *dst, uniptr_t src, + size_t offset, size_t size) +{ + if (!uniptr_is_kernel(src)) + return copy_from_user(dst, src.user + offset, size); + memcpy(dst, src.kernel + offset, size); + return 0; +} + +static inline int copy_from_uniptr(void *dst, uniptr_t src, size_t size) +{ + return copy_from_uniptr_offset(dst, src, 0, size); +} + +static inline int copy_to_uniptr_offset(uniptr_t dst, size_t offset, + const void *src, size_t size) +{ + if (!uniptr_is_kernel(dst)) + return copy_to_user(dst.user + offset, src, size); + memcpy(dst.kernel + offset, src, size); + return 0; +} + +static inline int copy_to_uniptr(uniptr_t dst, const void *src, size_t size) +{ + return copy_to_uniptr_offset(dst, 0, src, size); +} + +static inline void *memdup_uniptr(uniptr_t src, size_t len) +{ + void *p = kmalloc_track_caller(len, GFP_USER | __GFP_NOWARN); + + if (!p) + return ERR_PTR(-ENOMEM); + if (copy_from_uniptr(p, src, len)) { + kfree(p); + return ERR_PTR(-EFAULT); + } + return p; +} + +static inline void *memdup_uniptr_nul(uniptr_t src, size_t len) +{ + char *p = kmalloc_track_caller(len + 1, GFP_KERNEL); + + if (!p) + return ERR_PTR(-ENOMEM); + if (copy_from_uniptr(p, src, len)) { + kfree(p); + return ERR_PTR(-EFAULT); + } + p[len] = '\0'; + return p; +} + +static inline long strncpy_from_uniptr(char *dst, uniptr_t src, size_t count) +{ + if (uniptr_is_kernel(src)) { + size_t len = min(strnlen(src.kernel, count - 1) + 1, count); + + memcpy(dst, src.kernel, len); + return len; + } + return strncpy_from_user(dst, src.user, count); +} + +static inline int check_zeroed_uniptr(uniptr_t src, size_t offset, size_t size) +{ + if (!uniptr_is_kernel(src)) + return check_zeroed_user(src.user + offset, size); + return memchr_inv(src.kernel + offset, 0, size) == NULL; +} + +#endif /* _LINUX_UNIPTR_H */ -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:03:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574165.899371 (Exim 4.92) (envelope-from ) id 1qQp2S-00073A-Pv; Tue, 01 Aug 2023 13:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574165.899371; Tue, 01 Aug 2023 13:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQp2S-000733-Mf; Tue, 01 Aug 2023 13:03:48 +0000 Received: by outflank-mailman (input) for mailman id 574165; Tue, 01 Aug 2023 13:03:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQp2Q-00072s-4f for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:03:46 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7f623b5-306b-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:03:44 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qQp1P-008w3d-Jr; Tue, 01 Aug 2023 13:02:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AE68A300134; Tue, 1 Aug 2023 15:02:40 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 96CCC20A9524A; Tue, 1 Aug 2023 15:02:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7f623b5-306b-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GWiMsfat+BRyslkDKxTk4DrpasSmhXX1x9NIMnqNp+U=; b=pVVMMv9mJ3P7n2Pg071xoYksdK xBLJ8ZTlpFbic/85m30ybcx9Idc+Jq8yP8Rrr5fiUSzzOlYK+JWYhZkQQn/67jGoQyJfVqoJEIeim tTExlHg9EFtChpQPkIoIfdO6XudfnwrXEdT/45vavnCOS9WmZuQk385z1RAFWS9q72iO3bWQUsykW hEYr/hRkJYyUFJrhG2kYooD+k+gIFteiWqD4tE6yK488HbCx6aBNrlYnxDo8sgb5vXbQfpoRtpKXi +fB+tQKIxRtv7Pf5nmMnFbtkbydeM7Gl6c3hNolw6Xjcz8abx2iV5jltmcuV+GRTNu8yvZx5Uu7Ei qUJppYZA==; Date: Tue, 1 Aug 2023 15:02:40 +0200 From: Peter Zijlstra To: Xin Li Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Sean Christopherson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: Re: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Message-ID: <20230801130240.GA80967@hirez.programming.kicks-ass.net> References: <20230801083318.8363-1-xin3.li@intel.com> <20230801105236.GB79828@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801105236.GB79828@hirez.programming.kicks-ass.net> On Tue, Aug 01, 2023 at 12:52:36PM +0200, Peter Zijlstra wrote: > I also believe there is a kernel.org service for sending patch series, > but i'm not sure I remember the details. https://b4.docs.kernel.org/en/latest/contributor/send.html From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:06:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:06:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574169.899381 (Exim 4.92) (envelope-from ) id 1qQp5I-0007h4-Bx; Tue, 01 Aug 2023 13:06:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574169.899381; Tue, 01 Aug 2023 13:06:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQp5I-0007gx-9E; Tue, 01 Aug 2023 13:06:44 +0000 Received: by outflank-mailman (input) for mailman id 574169; Tue, 01 Aug 2023 13:06:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQp5H-0007gp-FI for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:06:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 41ae7702-306c-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:06:41 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 3575B4EE0737; Tue, 1 Aug 2023 15:06:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41ae7702-306c-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 Date: Tue, 1 Aug 2023 15:06:17 +0200 Message-Id: <9ec42e01258968d2dc71d59c5ad41da448a7112e.1690895099.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the struct declaration to have no named members, hence violating Rule 1.3: "There shall be no occurrence of undefined or critical unspecified behaviour" because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: "If the struct-declaration-list contains no named members, the behavior is undefined." It has been assessed that the feature set declaration is intentionally empty, and that no risk of undesired behaviour stems from it, hence the struct declaration is marked safe. No functional changes. Signed-off-by: Nicola Vetrini --- As agreed during the MISRA C group meetings, this violation is dealt with by means of a comment deviation, as future changes may eliminate the root cause, which is the empty feature set. My justification for the claim and the commit message may need some adjusting. --- docs/misra/safe.json | 9 +++++++++ xen/include/xen/lib/x86/cpu-policy.h | 1 + 2 files changed, 10 insertions(+) diff --git a/docs/misra/safe.json b/docs/misra/safe.json index e3c8a1d8eb..9239460e63 100644 --- a/docs/misra/safe.json +++ b/docs/misra/safe.json @@ -12,6 +12,15 @@ }, { "id": "SAF-1-safe", + "analyser": { + "eclair": "MC3R1.R1.3", + "text": "The following declaration of a struct with no named members results is deliberate and it has been assessed that no unintended behaviour arises from it." + }, + "name": "Sentinel", + "text": "Next ID to be used" + }, + { + "id": "SAF-2-safe", "analyser": {}, "name": "Sentinel", "text": "Next ID to be used" diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index bab3eecda6..6b52f080c9 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -203,6 +203,7 @@ struct cpu_policy }; union { uint32_t _7c1; + /* SAF-1-safe */ struct { DECL_BITFIELD(7c1); }; }; union { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:19:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:19:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574176.899392 (Exim 4.92) (envelope-from ) id 1qQpHC-0000qF-FR; Tue, 01 Aug 2023 13:19:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574176.899392; Tue, 01 Aug 2023 13:19:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpHC-0000q8-CZ; Tue, 01 Aug 2023 13:19:02 +0000 Received: by outflank-mailman (input) for mailman id 574176; Tue, 01 Aug 2023 13:19:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpHB-0000q2-2y for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:19:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061e.outbound.protection.outlook.com [2a01:111:f400:fe0c::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f8c2d523-306d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:18:58 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VE1PR04MB7422.eurprd04.prod.outlook.com (2603:10a6:800:1af::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.42; Tue, 1 Aug 2023 13:18:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:18:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8c2d523-306d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKn/AfZmnsrEoQtM6IrgY6bYG/BeNaSA2gMBkx/uYbPKfW1CKGlNGswoU3ro1b+bOD2gQXxCqGjpqJM+ovUwmETeiHqA+DCOSx7wIZigtcwObjg2Fk7spNVnlbRbDhoEL2DLyjaOjxQcd0ZedSTzgjGMJWKTo4jymEz60p+Jx4vTgTYfwzJMO5416RymnJF1A4F9LMlbEh1ec5mOdDwiFE7WRXQtt3Syyi3wOnDfF8pHabstMfc86OnrHM0+s2G2OESpgn8ubYXYR7BeXKqQ4Kok0UPixojv+Sn+LlmdGfE3rDIaJKyYkXPzgh5b2ad8qJ4F82D1uxyqJHmXHy6QMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AAxuY/+Juw7eCN2o8a+hTQFX/OTGahEDYva8rf7rjck=; b=eWNmFadFhVjHBatpD1NUQAjcTrXP3vCekoKu0avIGh1Dq4BW17PxS4ZHymU0PrGK6FyM23VJRaj1XFDgSdkP+BmW0/shw+wkPkQkdet5m56rvy/KvNbw2qvXYN7GV1HlDNv/rvGy5wXOs7degJBVTqH4yy4L1pO5YPCYzKenj8mXvRYNyro2GoH8KwxDNdmjdg+44BJGIfHwz3AtCEBNvp/WGOnX0srh/ondrLSPzn3aMkRpnLx4Ose2Kwm7ardyMdpm7Sm6Jy1w8SQvabYMekQ7sG9+xZTm1j4J+L5LbNpsxdtnQrjF5TvlymG4BSQQUe4L01wRYYhMUNGCNxwiOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AAxuY/+Juw7eCN2o8a+hTQFX/OTGahEDYva8rf7rjck=; b=MTwU78BVaAazfpkiJWmVE/gvNVyQuFL3qsgYBBbhfpD+7Mu9l6uddc8PrdHVwnjVB8uUyHZsD5/75UniYYdNQk2k8q12AFo/Ee5KnhJpTKqNddfQ7bTgCrXRT9RLFMdpQtV+kMBESQ9RZO8SEf0MK2m4qLqIYwYJAB2WAFJR0M/PmfwtdsYdlVx0b8E+mU4ch9yoccJd/0sBmDbTEAH3Rupu0tXzthGW9BNn8yMySDWTym6PtXfKb/eYkJ2hUClVJ6YUMWocSyXSyrR3B8HaIaDYa/wrWS26zb+DX8AWyjkZOt22+ciIk9c6UGhp8Ua2QxRTQMFxeFAgCgnTwzt6lQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55e1391e-a289-72bd-f663-62276cf4b065@suse.com> Date: Tue, 1 Aug 2023 15:18:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 3/3] xen/ppc: Implement initial Radix MMU support Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0158.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VE1PR04MB7422:EE_ X-MS-Office365-Filtering-Correlation-Id: e19c6a46-9457-4c24-ebdc-08db9291db6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bwWc9wSU01TVpGCRmE/n8toqE2zwkgO+23TSCmNjOosfJN12I3gStbNv3qw2PUieEDv4S5mJai1i52osFwkEfeW82kixVTHbB9lxv1x/wA5OjSychyNzO/m0RZKxGRlC2kUGP9P+tqQlB5W4M+olmH6hDFXv3EXtVHDk+HDIgzxkwMH5rZT9uAc59Mx/7sfSMKcEC+4EfU8lqcjmpinBfQdNj7ssRPwqy8U5nnmOozt191ybOmsHCkpxPKRr+Ub+HsXDHmpKdWmqvZ4/pP7ZAf1FkPc1cQthcnbiPYoGvFK7xaW5ro6rWuzSsdRWhBKpkpeiHM76lgAUfH9+JHQi62iPDH23mva+a1QwsFnmlYv5g/Hsj9tYkQGLdT7DVtuBRsJNvKoOmeiN9ZPYNPQSSAXqUV0cSRh11OXiuJiCCVt3K9v44lpA3rruq8fFFdYcWo3JlDJQuuccwIq/w88sSx9xRQOPvzldRznX5kxdnKVYw+LYIqnCj4NWznq+3znYeLkBw0nPr2aaqqmu04ZD7hFW31j0ODgYmOeOfiO7fkbua4V7Cz8DDhf6mCeCuq7q2RGdbsIOGupikVApWIFfTT05Xqk9q7qE0qWwMxpdgalQnDPOjkcpYJyl6EOs792nYo/DfCux4Fme0x5YXq+tbKY3nIB7NsSijSd8w7R0ZSE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39860400002)(366004)(376002)(136003)(451199021)(31686004)(66899021)(2616005)(5660300002)(30864003)(38100700002)(36756003)(2906002)(31696002)(316002)(26005)(83380400001)(478600001)(4326008)(8676002)(53546011)(186003)(6506007)(8936002)(41300700001)(86362001)(6486002)(6512007)(66556008)(66946007)(6916009)(66476007)(54906003)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkJtcjVNMXdKTlVSZzFRUUVEaHpQdDhacEpTbExCL2ljbGJLMFREOVJtejZB?= =?utf-8?B?eWo5TTNzQUhxNmRPTGxabkpWVnFnV1pVLzFrT1RKVld6TVZkM2NVWGZuNzgw?= =?utf-8?B?b2RlWmxmTEdTUjhNekJubkx1Sy9pR0lJMGl0UEtzc29nd1N0ZXk5WXhBNmIz?= =?utf-8?B?dlNxR2VYazVZZlNDUWNVelJLWXlVNjhtTHd4OUgxeUdtTm8wUHAwMnErVHpG?= =?utf-8?B?QjVxT2JHSmh1dzBPa3RRZjAzNjZLTlVoME5RWGUvQXFoWXFNdmZxeWZUd0Vx?= =?utf-8?B?d3dYamdMVk1lYWRmZUtQVzY1R3RUSWJ2VDZ4MmVxckhqOVFQYU1kSVRJQ2cr?= =?utf-8?B?YWVHbXVmRHZaL2RLRXd3NElyR1lPeFd3eGl3QVR5bElVWEdkZFdJbmVRMG5Q?= =?utf-8?B?RjFPWEJabDhWWW94YWRUSEYzNUtIRHNJcUN5M0pDSmtVakFuaHdZTjh1QlNI?= =?utf-8?B?WlpLVlpCVytJbG91VGd0cHMzOVI5VGg1YmVUSnBRZzlZa1IzL0tBOXNQL2Mv?= =?utf-8?B?Snltb0FZQTRuQ0ZOS2Y0WGV2MUxXSFFPbTF6Y2I5TUVXZk51ai9FRjkrbDNu?= =?utf-8?B?emtjWG1TM2EweWVoUXFNajVxdmMvZ3IxYWNhMGNIU2NLS3hocWFIZ0VSWk45?= =?utf-8?B?Y3pyMisyQ1N5SjVvNU5wV05KN0d4V29sTmFPRFdSejlKTC9WdUZXNzhjTVZ4?= =?utf-8?B?VnIrZzVYTHJTSDgzQUJWUlhwd3BKUzVKSlFjT3FMRDIyQmNhVFBNMC9aVjN0?= =?utf-8?B?WFgzNjFPK0ZqcURxZHpoMnlxUG1pUlRucGhYQkdTQzNFbnVJVHorR21Ed2RX?= =?utf-8?B?dFFqd2lPWno2aitQbldCbnhDc2tSM1U4M0luaU5jbnhMeVZaS05IZHBQL1V3?= =?utf-8?B?OXVNNWVNUGZzOGtISlRaTHRQeENtUVVjd0o0RUNEMTRTalI0Tk1kelFiam9B?= =?utf-8?B?am9aRm5UNWlBZE93R1lmckVsZkE0ZUJMUy9jQ0FCVjhrUGZtcG9kQUgvNmlL?= =?utf-8?B?S3lRSFVlbU1UczhPUC9yaitYR0ZnUThmcFh1UFAvNWVXNVp1ckJyb0JncUVa?= =?utf-8?B?bVI1REhmVjdTQmdtZGZCRVR0OC9LMWRxSEJRRHZ1Nmk2T0FpcHIxY3V1ZjR4?= =?utf-8?B?TjFZayt6cmkzbnRFRnNLdHJTT2xReEFPRUlycVFLSXNXV2RzNU41UGRaZnpw?= =?utf-8?B?ajBLakMyMmpZdVZjSytNTUhNMmtNb1NrcTcwVlBQTHFJNTZhZFVDR01BckUv?= =?utf-8?B?bXljdldkSVV3Nnh4c09GY21oR0MyM21nMnI5eVB5MklBa3owLy9ybHY2cGJl?= =?utf-8?B?UUREajVSMkN2RE9uL2M4WVlEdTBEcnNVYVNMeGxIRGdyeUxiZUY2V0lyZ0Nu?= =?utf-8?B?NHNUWFVlSW5abllUN2gxaWZiL2FYK241Wi9yVGxTSzlZVmJ5RVdya09WV2N6?= =?utf-8?B?b3lMMTBQVDgybW1weHhuVVBoNDZtYXAyUFlVSTZmSFN5Z0FPaSt6eVRXcnFH?= =?utf-8?B?VzMvNFNacFoweVo4NDVLbHllZDFoS1FyZi8yTWtBVjkvaGVlRGpJeVp3M0tB?= =?utf-8?B?d211YU9VVi9JZ2g5U2tjU2xkcTZobnFYclRINTVBSlBBV3JOb2JPY3MvRmps?= =?utf-8?B?K2hjQzZNcGtCZC9NQU5XcFlsb2h4UXUrdkptY2FpbndiQXJVOFpzeGdwZjR5?= =?utf-8?B?UUN5NDlRdFNGMzNpVW02dnl6UGJOc1R4K2xpZzVGVDBOd0tuNXBYU0p2VFA4?= =?utf-8?B?UzZWeEEyTUtjMU8zVWVGWGNpWUtZRFB1eERHN0JEMmpiT0JtdlF3L1prSFhh?= =?utf-8?B?cDNUMW1PUTNKZk9WOWhES1pUQnhkN0VEM2FIK0tnbzZ4NGhlTkQ1NmdDMFMr?= =?utf-8?B?YXBLdWk0VndqZ01yempadlozakx2ekVCdTFrMm5uZFF2Z00ybGw5emdtMXB3?= =?utf-8?B?QXhtcHBmTXZNc0JqMElHSzNBdHBiQ21CSGRQTkJVcHptQ1VoYTBRMFhBRVgv?= =?utf-8?B?R2wxQkNHcDl3Tld1K0NvZ3FZeG5uUmRIbzgzNEx0bTNORy9iUUhZNkdzdkVS?= =?utf-8?B?TUM3VDdVdUI4K3ZzRVRtS2txdUZaZHZFRTVpZlk5YWpJRklCQS93TnBQVStj?= =?utf-8?Q?G4nBAZjwoct/8f5q6lWx7PS4l?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e19c6a46-9457-4c24-ebdc-08db9291db6d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:18:55.3849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xMVCzAxLguQnW00MU1P9lUDLjUIOetNE6TxHTPJ407n31+SstlOtajbH5odmWllZCYfsZTTKZXeGpVzN8ctkJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7422 On 29.07.2023 00:21, Shawn Anastasio wrote: > --- /dev/null > +++ b/xen/arch/ppc/include/asm/bitops.h > @@ -0,0 +1,11 @@ > +#ifndef _ASM_PPC_BITOPS_H > +#define _ASM_PPC_BITOPS_H > + > +#include Not a big deal, but ... > +/* PPC bit number conversion */ > +#define PPC_BITLSHIFT(be) (BITS_PER_LONG - 1 - (be)) > +#define PPC_BIT(bit) (1UL << PPC_BITLSHIFT(bit)) > +#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs)) > + > +#endif /* _ASM_PPC_BITOPS_H */ ... nothing here looks to require that #include. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/mm.h > @@ -0,0 +1,19 @@ > +#ifndef _ASM_PPC_MM_H > +#define _ASM_PPC_MM_H > + > +#include This is included by xen/config.h, which in turn is included from the compiler command line. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/page.h > @@ -0,0 +1,178 @@ > +#ifndef _ASM_PPC_PAGE_H > +#define _ASM_PPC_PAGE_H > + > +#include > + > +#include > +#include > + > +#define PDE_VALID PPC_BIT(0) > +#define PDE_NLB_MASK 0xfffffffffffffUL > +#define PDE_NLB_SHIFT 5UL > +#define PDE_NLS_MASK 0x1f > + > +#define PTE_VALID PPC_BIT(0) > +#define PTE_LEAF PPC_BIT(1) > +#define PTE_REFERENCE PPC_BIT(55) > +#define PTE_CHANGE PPC_BIT(56) > + > +/* PTE Attributes */ > +#define PTE_ATT_SAO PPC_BIT(59) /* Strong Access Ordering */ > +#define PTE_ATT_NON_IDEMPOTENT PPC_BIT(58) > +#define PTE_ATT_TOLERANT (PPC_BIT(58) | PPC_BIT(59)) > + > +/* PTE Encoded Access Authority*/ > +#define PTE_EAA_PRIVILEGED PPC_BIT(60) > +#define PTE_EAA_READ PPC_BIT(61) > +#define PTE_EAA_WRITE PPC_BIT(62) > +#define PTE_EAA_EXECUTE PPC_BIT(63) > + > +/* Field shifts/masks */ > +#define PTE_RPN_MASK 0x1fffffffffffUL > +#define PTE_RPN_SHIFT 12UL > +#define PTE_ATT_MASK 0x3UL > +#define PTE_ATT_SHIFT 4UL > +#define PTE_EAA_MASK 0xfUL Did you consider introducing just *_MASK values, utilizing MASK_INSR() and MASK_EXTR() instead of open-coded shifting/masking? > +#define PTE_XEN_BASE (PTE_VALID | PTE_EAA_PRIVILEGED | PTE_REFERENCE) > +#define PTE_XEN_RW (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_WRITE | PTE_CHANGE) > +#define PTE_XEN_RO (PTE_XEN_BASE | PTE_EAA_READ) > +#define PTE_XEN_RX (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_EXECUTE) > + > +/* > + * Radix Tree layout for 64KB pages: > + * > + * [ L1 (ROOT) PAGE DIRECTORY (8192 * sizeof(pde_t)) ] > + * | > + * | > + * v > + * [ L2 PAGE DIRECTORY (512 * sizeof(pde_t)) ] > + * | > + * | > + * v > + * [ L3 PAGE DIRECTORY (512 * sizeof(pde_t)) ] > + * | > + * | > + * v > + * [ L4 PAGE TABLE (32 * sizeof(pte_t)) ] > + * | > + * | > + * v > + * [ PAGE TABLE ENTRY ] > + */ > + > +#define XEN_PT_ENTRIES_LOG2_LVL_1 13 /* 2**13 entries, maps 2**13 * 512GB = 4PB */ > +#define XEN_PT_ENTRIES_LOG2_LVL_2 9 /* 2**9 entries, maps 2**9 * 1GB = 512GB */ > +#define XEN_PT_ENTRIES_LOG2_LVL_3 9 /* 2**9 entries, maps 2**9 * 1GB = 512GB */ > +#define XEN_PT_ENTRIES_LOG2_LVL_4 5 /* 2**5 entries, maps 2**5 * 64K = 2MB */ > + > +#define XEN_PT_SHIFT_LVL_1 (XEN_PT_SHIFT_LVL_2 + XEN_PT_ENTRIES_LOG2_LVL_2) > +#define XEN_PT_SHIFT_LVL_2 (XEN_PT_SHIFT_LVL_3 + XEN_PT_ENTRIES_LOG2_LVL_3) > +#define XEN_PT_SHIFT_LVL_3 (XEN_PT_SHIFT_LVL_4 + XEN_PT_ENTRIES_LOG2_LVL_4) > +#define XEN_PT_SHIFT_LVL_4 PAGE_SHIFT > + > +#define XEN_PT_ENTRIES_LOG2_LVL(lvl) (XEN_PT_ENTRIES_LOG2_LVL_##lvl) > +#define XEN_PT_SHIFT_LVL(lvl) (XEN_PT_SHIFT_LVL_##lvl) > +#define XEN_PT_ENTRIES_LVL(lvl) (1UL << XEN_PT_ENTRIES_LOG2_LVL(lvl)) > +#define XEN_PT_MASK_LVL(lvl) (XEN_PT_ENTRIES_LVL(lvl) - 1) > +#define XEN_PT_INDEX_LVL(lvl, va) ((va >> XEN_PT_SHIFT_LVL(lvl)) & XEN_PT_MASK_LVL(lvl)) > + > +/* > + * Calculate the index of the provided virtual address in the provided > + * page table struct > + */ > +#define pt_index(pt, va) _Generic((pt), \ Earlier on I did ask about the minimum compiler version you require for building the PPC hypervisor. Iirc you said about any, but here you're using another feature where I'm not sure how far back it is available. As indicated back then, it would be nice if ./README could gain respective information. > + struct lvl1_pd * : XEN_PT_INDEX_LVL(1, (va)), \ > + struct lvl2_pd * : XEN_PT_INDEX_LVL(2, (va)), \ > + struct lvl3_pd * : XEN_PT_INDEX_LVL(3, (va)), \ > + struct lvl4_pt * : XEN_PT_INDEX_LVL(4, (va))) > + > +#define pt_entry(pt, va) (&((pt)->entries[pt_index((pt), (va))])) As to style: Here (and elsewhere) you put unnecessary parentheses around two of the three uses of the macro arguments. If you think you want to keep it like that, feel free; in general we're recommending to omit ones not really needed, to help readability. Otoh a little higher up in XEN_PT_INDEX_LVL() parentheses are missing around va. > +typedef struct > +{ > + __be64 pde; > +} pde_t; > + > +typedef struct > +{ > + __be64 pte; > +} pte_t; > + > +struct lvl1_pd > +{ > + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_1]; > +}; > + > +struct lvl2_pd > +{ > + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_2]; > +}; > + > +struct lvl3_pd > +{ > + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_3]; > +}; > + > +struct lvl4_pt > +{ > + pte_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_4]; > +}; > + > +static inline pte_t paddr_to_pte(paddr_t paddr, unsigned long flags) > +{ > + return (pte_t){ .pte = cpu_to_be64(paddr | flags | PTE_LEAF) }; > +} > + > +static inline pde_t paddr_to_pde(paddr_t paddr, unsigned long flags, unsigned long nls) > +{ > + return (pde_t){ .pde = cpu_to_be64(paddr | flags | nls) }; > +} In these two, are you sure you want to demand all callers to only ever pass in page-aligned addresses? > +static inline paddr_t pte_to_paddr(pte_t pte) > +{ > + return be64_to_cpu(pte.pte) & (PTE_RPN_MASK << PTE_RPN_SHIFT); > +} > + > +static inline paddr_t pde_to_paddr(pde_t pde) > +{ > + return be64_to_cpu(pde.pde) & (PDE_NLB_MASK << PDE_NLB_SHIFT); > +} > + > +static inline bool pte_is_valid(pte_t pte) > +{ > + return pte.pte & be64_to_cpu(PTE_VALID); > +} > + > +static inline bool pde_is_valid(pde_t pde) > +{ > + return pde.pde & be64_to_cpu(PDE_VALID); > +} > + > +/* > + * ISA 3.0 partition and process table entry format > + */ > +struct patb_entry { > + __be64 patb0; > + __be64 patb1; > +}; > +#define PATB0_HR PPC_BIT(0) /* host uses radix */ > +#define PATB1_GR PPC_BIT(0) /* guest uses radix; must match HR */ > + > +struct prtb_entry { > + __be64 prtb0; > + __be64 reserved; > +}; > + > +/* > + * We support 52 bits, hence: > + * bits 52 - 31 = 21, 0b10101 > + * RTS encoding details > + * bits 0 - 3 of rts -> bits 6 - 8 unsigned long > + * bits 4 - 5 of rts -> bits 62 - 63 of unsigned long > + */ > +#define RTS_FIELD ((0x2UL << 61) | (0x5UL << 5)) I'm afraid I can't bring comment and #define together. Bits 0-3 are 4 bits; bits 6-8 are only three. And I'd expect the lower ends of the ranges to appear as shift counts in the expression. > --- a/xen/arch/ppc/include/asm/processor.h > +++ b/xen/arch/ppc/include/asm/processor.h > @@ -133,6 +133,37 @@ struct cpu_user_regs > uint32_t entry_vector; > }; > > +static __inline__ void sync(void) > +{ > + asm volatile ( "sync" ); > +} > + > +static __inline__ void isync(void) > +{ > + asm volatile ( "isync" ); > +} > + > +static inline unsigned long mfmsr(void) > +{ > + unsigned long msr; > + asm volatile ( "mfmsr %0" : "=&r"(msr) ); Why the &? Also nit: Missing blank between closing double quote and opening paren. More instances of this below. > + return msr; > +} > + > +static inline void mtmsrd(unsigned long msr) > +{ > + asm volatile ( "mtmsrd %0" : : "r"(msr) ); > +} > + > +#define mtspr(reg, val) asm volatile ( "mtspr %0,%1" : : "K"(reg), "r"(val) ) > + > +#define mfspr(reg) \ > + ({ \ > + unsigned long val; \ > + asm volatile ( "mfspr %0,%1" : "=r"(val) : "K"(reg) ); \ > + val; \ > + }) Why #define-s here when higher up you successfully use inline functions? Also (nit) blanks would again be nice ahead of the commas. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/regs.h > @@ -0,0 +1,138 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. You have an SPDX line first thing - why the spelled out license? > --- /dev/null > +++ b/xen/arch/ppc/mm-radix.c > @@ -0,0 +1,268 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#include > +#include > +#include > +#include Nit: Please sort headers whenever possibly; also ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include ... this group then. > +void enable_mmu(void); > + > +#define INITIAL_LVL1_PD_COUNT 1 > +#define INITIAL_LVL2_LVL3_PD_COUNT 2 > +#define INITIAL_LVL4_PT_COUNT 256 > + > +static size_t initial_lvl1_pd_pool_used; > +static struct lvl1_pd __aligned(sizeof(struct lvl1_pd)) > +initial_lvl1_pd_pool[INITIAL_LVL1_PD_COUNT]; > + > +static size_t initial_lvl2_lvl3_pd_pool_used; > +static struct lvl2_pd __aligned(sizeof(struct lvl2_pd)) > +initial_lvl2_lvl3_pd_pool[INITIAL_LVL2_LVL3_PD_COUNT]; > + > +static size_t initial_lvl4_pt_pool_used; > +static struct lvl4_pt __aligned(sizeof(struct lvl4_pt)) > +initial_lvl4_pt_pool[INITIAL_LVL4_PT_COUNT]; Can instances of these structures usefully exist and be not suitably aligned? If not, having the types rather than the instances already declare the necessary alignment would seem better to me. > +/* Only reserve minimum Partition and Process tables */ > +#define PATB_SIZE_LOG2 16 /* Only supported partition table size on POWER9 */ > +#define PATB_SIZE (1UL << PATB_SIZE_LOG2) > +#define PRTB_SIZE_LOG2 12 > +#define PRTB_SIZE (1UL << PRTB_SIZE_LOG2) > + > +static struct patb_entry > + __aligned(PATB_SIZE) initial_patb[PATB_SIZE / sizeof(struct patb_entry)]; > + > +static struct prtb_entry > + __aligned(PRTB_SIZE) initial_prtb[PRTB_SIZE / sizeof(struct prtb_entry)]; The situation is different here, as array here aren't embedded into the type (being just single entries). > +_Static_assert(sizeof(initial_patb) == PATB_SIZE); Is this really useful. And if so, why no similar check for prtb? Furthermore BUILD_BUG_ON() would be better, playing again into what the range of suitable compilers is for this to build. > +static void __init setup_initial_mapping(struct lvl1_pd *lvl1, > + vaddr_t map_start, > + vaddr_t map_end, > + paddr_t phys_base) > +{ > + uint64_t page_addr; > + > + if ( map_start & ~PAGE_MASK ) > + { > + early_printk("Xen _start be aligned to 64k (PAGE_SIZE) boundary\n"); > + die(); > + } > + > + if ( (uint64_t) phys_base & ~PAGE_MASK ) Why the cast? > + { > + early_printk("Xen should be loaded at 64k (PAGE_SIZE) boundary\n"); > + die(); > + } > + > + for ( page_addr = map_start; page_addr < map_end; page_addr += PAGE_SIZE ) > + { > + struct lvl2_pd *lvl2; > + struct lvl3_pd *lvl3; > + struct lvl4_pt *lvl4; > + pde_t *pde; > + pte_t *pte; > + > + /* Allocate LVL 2 PD if necessary */ > + pde = pt_entry(lvl1, page_addr); > + if ( !pde_is_valid(*pde) ) > + { > + lvl2 = lvl2_pd_pool_alloc(); > + *pde = paddr_to_pde(__pa(lvl2), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_2); paddr_to_pde() doesn't mask off the top bits. Are you relying on lvl2_pd_pool_alloc() using PIC addressing to get at the value it then returns? Also this and the similar lines below look to be a little too long. > + } > + else > + lvl2 = (struct lvl2_pd *) pde_to_paddr(*pde); This casts a physical address to a pointer; normally only virtual addresses can be used this way. Could there be a helper added to have such a dangerous-looking construct in (ideally) just a single place? > + /* Allocate LVL 3 PD if necessary */ > + pde = pt_entry(lvl2, page_addr); > + if ( !pde_is_valid(*pde) ) > + { > + lvl3 = lvl3_pd_pool_alloc(); > + *pde = paddr_to_pde(__pa(lvl3), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_3); > + } > + else > + lvl3 = (struct lvl3_pd *) pde_to_paddr(*pde); > + > + /* Allocate LVL 4 PT if necessary */ > + pde = pt_entry(lvl3, page_addr); > + if ( !pde_is_valid(*pde) ) > + { > + lvl4 = lvl4_pt_pool_alloc(); > + *pde = paddr_to_pde(__pa(lvl4), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_4); > + } > + else > + lvl4 = (struct lvl4_pt *) pde_to_paddr(*pde); > + > + /* Finally, create PTE in LVL 4 PT */ > + pte = pt_entry(lvl4, page_addr); > + if ( !pte_is_valid(*pte) ) > + { > + unsigned long paddr = (page_addr - map_start) + phys_base; > + unsigned long flags; > + radix_dprint(paddr, "being mapped to "); Blank line again please between declarations and statements. > + radix_dprint(page_addr, "!\n"); > + if ( is_kernel_text(page_addr) || is_kernel_inittext(page_addr) ) > + { > + radix_dprint(page_addr, "being marked as TEXT (RX)\n"); > + flags = PTE_XEN_RX; > + } > + else if ( is_kernel_rodata(page_addr) ) > + { > + radix_dprint(page_addr, "being marked as RODATA (RO)\n"); > + flags = PTE_XEN_RO; > + } > + else > + { > + radix_dprint(page_addr, "being marked as DEFAULT (RW)\n"); > + flags = PTE_XEN_RW; > + } > + > + *pte = paddr_to_pte(paddr, flags); > + radix_dprint(paddr_to_pte(paddr, flags).pte, > + "is result of PTE map!\n"); > + } > + else > + { > + early_printk("BUG: Tried to create PTE for already-mapped page!"); > + die(); > + } > + } > +} > + > +static void setup_partition_table(struct patb_entry *patb, struct lvl1_pd *root) __init? > +{ > + unsigned long ptcr; > + > + /* Configure entry for LPID 0 to enable Radix and point to root PD */ > + uint64_t patb0 = RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_1 | PATB0_HR; > + uint64_t patb1 = __pa(initial_prtb) | (PRTB_SIZE_LOG2 - 12) | PATB1_GR; > + patb[0].patb0 = cpu_to_be64(patb0); > + patb[0].patb1 = cpu_to_be64(patb1); > + > + ptcr = __pa(initial_patb) | (PATB_SIZE_LOG2 - 12); > + mtspr(SPRN_PTCR, ptcr); > +} > + > +static void setup_process_table(struct prtb_entry *prtb, struct lvl1_pd *root) __init? > +{ > + /* Configure entry for PID 0 to point to root PD */ > + uint64_t prtb0 = RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_1; > + initial_prtb[0].prtb0 = cpu_to_be64(prtb0); > +} > + > +void __init setup_initial_pagetables(void) > +{ > + struct lvl1_pd *root = lvl1_pd_pool_alloc(); > + unsigned long lpcr; > + > + setup_initial_mapping(root, > + (vaddr_t) _start, > + (vaddr_t) _end, > + __pa(_start)); setup_initial_mapping(root, (vaddr_t)_start, (vaddr_t)_end, __pa(_start)); (if flowing across multiple lines is needed / wanted) > --- a/xen/arch/ppc/opal.c > +++ b/xen/arch/ppc/opal.c > @@ -1,8 +1,10 @@ > /* SPDX-License-Identifier: GPL-2.0-or-later */ > +#include "xen/compiler.h" Surely , but then neither this nor ... > #include > #include > #include > #include > +#include ... this addition look motivated when nothing else changes in this file. Also (I overlooked this in the earlier patch) all xen/ headers generally want to come ahead of all asm/ ones. > --- a/xen/arch/ppc/setup.c > +++ b/xen/arch/ppc/setup.c > @@ -7,6 +7,8 @@ > /* Xen stack for bringing up the first CPU. */ > unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); > > +void __init setup_initial_pagetables(void); This needs to live in a header which is included both here and in the file defining the function. > +static void tlbiel_radix_set_isa300(unsigned int set, unsigned int is, > + unsigned int pid, unsigned int ric, > + unsigned int prs) > +{ > + unsigned long rb; > + unsigned long rs; > + > + rb = (set << PPC_BITLSHIFT(51)) | (is << PPC_BITLSHIFT(53)); > + rs = ((unsigned long) pid << PPC_BITLSHIFT(31)); > + > + asm volatile ( "tlbiel %0, %1, %2, %3, 1" : > + : "r"(rb), "r"(rs), "i"(ric), "i"(prs) : "memory" ); Nit: One too few indenting blanks (besides others that are missing). Perhaps also better to pull the standalone : onto this second line. Overall perhaps (also for line length) asm volatile ( "tlbiel %0, %1, %2, %3, 1" :: "r" (rb), "r" (rs), "i" (ric), "i" (prs) : "memory" ); > +void radix__tlbiel_all(unsigned int action) Is the double underscore in here intentional? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:22:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:22:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574180.899401 (Exim 4.92) (envelope-from ) id 1qQpKF-0002JM-20; Tue, 01 Aug 2023 13:22:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574180.899401; Tue, 01 Aug 2023 13:22:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpKE-0002JF-Vd; Tue, 01 Aug 2023 13:22:10 +0000 Received: by outflank-mailman (input) for mailman id 574180; Tue, 01 Aug 2023 13:22:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpKE-0002J5-1w; Tue, 01 Aug 2023 13:22:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpKD-0005Ef-TK; Tue, 01 Aug 2023 13:22:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpKD-0002iQ-J4; Tue, 01 Aug 2023 13:22:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qQpKD-0005oD-IT; Tue, 01 Aug 2023 13:22:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vpRbuGLJNWVu5SETRBsQabgNMDh2C5guTgrlR3sClzM=; b=EpjqaVO5uaYFqivjQQW6fLk9Cj hrBuB+yDJjTxVRnym4LSXhTxn3fGmNRgF3X4Eb9ShFrIro/X823pHiP2sEs/Um3qqIke+aD2Zg3Ar 83tmYcPEIUZnNXNpBK0XxdlZJG+qcVEGRB2hz2G8f/dEvfJeCu/tLa4WiL7Iyxj4rRSc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182087: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit1:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start.2:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5d0c230f1de8c7515b6567d9afba1f196fb4e2f4 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 01 Aug 2023 13:22:09 +0000 flight 182087 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit1 20 guest-localmigrate/x10 fail in 182083 pass in 182087 test-amd64-amd64-xl-credit2 14 guest-start fail pass in 182083 test-amd64-amd64-xl-qemuu-ovmf-amd64 21 guest-start.2 fail pass in 182083 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 106 days Failing since 180281 2023-04-17 06:24:36 Z 106 days 196 attempts Testing same since 182083 2023-07-31 00:41:50 Z 1 days 2 attempts ------------------------------------------------------------ 3874 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 651356 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:33:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:33:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574190.899412 (Exim 4.92) (envelope-from ) id 1qQpVH-0003qA-2t; Tue, 01 Aug 2023 13:33:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574190.899412; Tue, 01 Aug 2023 13:33:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpVG-0003q3-WB; Tue, 01 Aug 2023 13:33:35 +0000 Received: by outflank-mailman (input) for mailman id 574190; Tue, 01 Aug 2023 13:33:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpVF-0003pt-EZ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:33:33 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2062c.outbound.protection.outlook.com [2a01:111:f400:fe13::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00f46d3b-3070-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 15:33:32 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB8020.eurprd04.prod.outlook.com (2603:10a6:20b:244::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 13:33:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:33:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00f46d3b-3070-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UM/lJX48GUWKCW8Y2aWAcRG3fkp4/taLadsBo9C1g6QVOJDY18MzEdu6Mkr9s2NO72/P5M8lpFOaJjs0lMA5GRax8AOzcp7b7m+RIl2IiPmpFtB0pgJRHJ178veJJlzv0qAJ3XRmxG3oJOqiVnK09XJwmlH8c3hyVkkp7sCVyST1Su53tXrZ/I3yUxWvAvUzfde0XiN8Tj0irxxuBfA4N1uGIGxNBqwpMQzEXgmUo9FEYvrDEcDwnmeIKVAMa5LmcniF82ceeXPerGgY4Gi+plLqL2NCAROj4Qubln6PG6lNbXv++SfH1OWzVxOJwuDxMZVc2cgXh4W6eA7J+HXOgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X6jcdQMXOD+ZH52n5pvz4Gz3DBFJrho+rSxakIkbNSo=; b=U15iLV6otr9Jd3kvqjuRK/p+KPxWVqxLyvfF3VL9GF0eKvvnSCL2HnMuaenm8ijAwZLLibSd+k7ivqY79eRJMHGOJBh89Xppaz1nra9Jeu5H7xJhdkSYf9KUM6Xke5NpAVlx1EyZW29BcGEvDNlKS2M9W8NVrQN8R8M3jlJWXAozDQMv/FKGCCXRVY0RJ/uErbbIEK1q/3nhLTpmpbQTS2B75Wlv9rq37YvP+wFTibexHacJQQJA2dR9FHWek13tp/eD4n0KgPi37bd9edpf5MWteHKKOP6JHvFwO4T92QszjKWCFqi/gcuffZzxDduhDszc5CNyhDJkISzJeNmg8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X6jcdQMXOD+ZH52n5pvz4Gz3DBFJrho+rSxakIkbNSo=; b=5uFnTsYxRiUA+DGUUXlRzMRXf16mGm/9SScn7jj4ZrUOMFbrDmXyd+TAZelO50jU6o5cCSDD1+U/E/iWbIKtH/WzrHmXqu6voXmkxkm+8xR6TD4j/SjgNGW253NOccfMXbVVL0T1MchcDOuwtVMm/lX9S7ch4zljeoElaOKNUWW8Tn1vp3FNvNupGjR1xrysD3Q514ptXjBFZFBbxB5wEDKJXHtoPQREuSE6N3aP6JAWpGGuLs2hONY5NnoCyFsWZ4uCdZmmJN0UMo4DWvCAY2IfwTPB1+G9jOJD2Yj+qFxMGzoGCwagK4W6aL9LUyQGxwASuUogR3NsLTGCTseUxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c29439b-cfb8-68d0-8677-91ba897f5e7e@suse.com> Date: Tue, 1 Aug 2023 15:33:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH v2 1/3] xen/common: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB8020:EE_ X-MS-Office365-Filtering-Correlation-Id: f297f3f5-759f-4f67-05fc-08db9293e33f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: en6Q2rEHdFgbD1APINTKPQIcIJkhftBoWWKtYyEOG9VERcVNtOzJec9llZrlx9Jg9wWQNcKbUFuc1Qlm/gpjIslMX230vT7t3+MU1PvNxZtUlco+14hfvw9vBYTUBPdc6x71ws58f0U5hRnWP4M5FuvjmeQmGDnpkbA+CTHQcyy70TQx6tJjM/B+23VYkDCNcA0IzGCpEPuqoShke80dpPiUBYIwxBdXBv25YGHlEkLBfPvaK3g/nY8bJ18OQdQLgOj4ERbmM+Iu0HjLX9yZf6rUBtM66g5RUYKuaBgrkR6t7w/6Jq5lzfyml4x5npoIvb7BXrFJgvvyjjucnl+MVG5Ow3valsA4kHeCVEc+CZzPpYJaE7NRT7RDrLfPbHyNVh9BoV8hNEsolwgtmBj2cLa1v9YMWuD/MkJt0TbXzRKo1PecC5psotzo87GazCRHbm8O/ACj+yScVatj8buY8A3+hHQCwD3pZioZZHFVsLwzoxdrNykd10+KITawj5sOMKHX3RbiAm3A1bZ5j+jigNJLvxHaZTo27szDHgJXaUd2d9k2SEpkraLK2z9YLAkD6JF+yUUbZ4jT24KIjRYzDQA2M6zDn8yomM7a9OKLs3ttZ4L5LesiNDsBcfOzCBFj3ClDRASq/YpAFZ6l5NNpFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199021)(6512007)(6486002)(36756003)(53546011)(2616005)(186003)(6506007)(26005)(83380400001)(66946007)(66556008)(7416002)(54906003)(4326008)(38100700002)(86362001)(66476007)(31696002)(41300700001)(316002)(6916009)(8936002)(8676002)(5660300002)(31686004)(2906002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N01OSzBjVjZuU3lHcFg3OFZDbTJhejBZNXlRN252aXBIeC9KRFBKUUtUcWg1?= =?utf-8?B?alFuU25rNEVSMkl2ZkNxMTNRRmsrZkkyekVLQnlpQXluSnZTL1YxcVN0MWFG?= =?utf-8?B?Ky8wcGFOeEpDRUtnbWNnUXFqdE03SUpxSEx0QWttcUhKWG5zaEMxZ1NmWVlM?= =?utf-8?B?bmVpZkc1emFlaFJCYTV1eUN1dmpoMUNJWFZVK1V5RFhpbklINHAzRUtLQ0U2?= =?utf-8?B?YlVrcldUMTRvZ2pVYi9tWXBGSkJsU1NIS2theGRMT0IzL3NOZVhxVXdCRFp0?= =?utf-8?B?Q1l5SjVjdnBybUc5aERjcDFvS2F2MmVkaGhqK0c1MmlOYVdTdVZ2ZWdEbjBp?= =?utf-8?B?dVBpM3ovb01pNktjN3BYOXRvVG9wYkJEUk9kQlRVWW5abUFMWlpQeThOMHdq?= =?utf-8?B?ZSs0Q1VPZldXSmY1YTlNbFlsQkdRb3ZGVk5VVitXWWVnWk5rTThLTm1tZzYy?= =?utf-8?B?b2RZVm9YcnBtSnZ0TzlJdDBOVzJuY3hiQ2ViQXREODExS1hOdmNnSEdMK2p5?= =?utf-8?B?cjZ4S0t4dEk1Y3dDQ0xLbWxwV2YwbnBObXFYRm5qM3lWbWJzaVQwT1BCR2Qr?= =?utf-8?B?bXJNWUgvZU0wUmhSMHFCcGNjMXlZREpYb2RQUUl2WlhnZ3ZpUW5taUR5OFAz?= =?utf-8?B?S3JGQWhkNDc0aGtpdXNNUU11YkI3YkRqZGdwUUtac2FXMW13NWMrcnFOVllD?= =?utf-8?B?dUt6NDVmeFpEZ3owRGUvV0daUStabGxVelU0THc4YmF5RG1RWllOeVpBYXJk?= =?utf-8?B?a21YaUxJUE92c0tLOGFtQXJkTjR1cW5YcGFWZnB5MU5FRGtZRXExbXJpU1h6?= =?utf-8?B?RFRnd25NODFwWnJmNUhEWUpKQXR0bGZRb0hZajljS1d0MnFiaU45bzBYT0Qw?= =?utf-8?B?T05PRzg4SHJBcFgwTW42cjZWWjZZU1hhUlZxcUo3d09XZ1hTa3dpWmk3a2JQ?= =?utf-8?B?WHNKUXNHVlV5UUhZeXQ4M0kwNUlaQTQ4MUlaZGR6Q3ZCeDgwOGRJbTZlVHM3?= =?utf-8?B?aGVra09mUHpuSGE4MWUycDNpMXhnM09rc3ZDdzNzZVFhc1B5ZjRTLzBXTnhP?= =?utf-8?B?NXo0ckcweUhQbWJCdmtLQXd2aXJmaVF5d0VCaEN2SmVJZDduTURIWU5kbGMw?= =?utf-8?B?MTB6cGZTS2VUS01UdndVbzkyUUtTMkF3WXVFK2RCMWpTaUswRHcwRFRkSmk4?= =?utf-8?B?UlphSzhVV25tUjU2ZlFtSXZEa0tXSlFNSndPSWIydmptYU9yVitzRFBETzJ2?= =?utf-8?B?S2NwKzEvRjFjekdmSzIvaFZ3d1grNGs0MFBDK1FPN2xjTGIyRDJQRVpwVWU5?= =?utf-8?B?M0JaV0xqdm41M09hc1U2a3RjalNLQjByd1FQNnVSdmpVRUVaaE5OOXlkSEZr?= =?utf-8?B?cHFhSmZPNWJ0MWxGZ0NhSjFaZGJSS2Y3WVY4dmRiWDRqbmZKNVVtc3R3L0FQ?= =?utf-8?B?eHNSWk9MZnAwNXgxenJFVHplbkwxczQ3RGE0VG10WDFaN1crcXZRNWJBMTNk?= =?utf-8?B?ZCs0eWN5S1F1SmxqZEVCbGxuOFQ0aTYyNG92UmVOaE9ibFFGT3o0Ny91RDFD?= =?utf-8?B?T2hJRi9hK0VBZFNOZndLZmZIMWZSdFNpNk9TTWl1d3hUSUZTSW84UDlaMWNI?= =?utf-8?B?YUoxTy90M00xQnk5VlhjaC81M0NxNzBGYlZrWld3TXdjWDg1NjMvSXYrWVpQ?= =?utf-8?B?MFp4akp6VXJzOFNJV25DV003WS91VDZYa21QS2RURDJIVTRnRHVDMjFSWFhr?= =?utf-8?B?QnNNVXUrc1J2amEvTXFzaDQzQnhHd0JVSEZ2Mm9vM05lQVNjcnYxR0JWdW50?= =?utf-8?B?c2lwa0tNaXdXSHJhcTZzT0dVRFFwdkhqT2ZIZnRZbWdQalEwUkhuc3pzUkZi?= =?utf-8?B?QnMyYUF4RUNwOGpNUVRVZUoxOWpGcnl4Y1ZMbVRicU9uc1VjanZoNWtJUkhW?= =?utf-8?B?KzZXOTErUDVDOXQ2eFJXSkIwdWJkSG8yS0pLaXYyN0lyVDY0WllOaWhkcDFt?= =?utf-8?B?cVd0RSsyaXFMMTJQSGpBUXVtODVjYnY3cjJJL1VLemR2ek1IN0JZbklHcWpy?= =?utf-8?B?Nzlwc09FSGJ1RlNLR1FMajJQcUZrTGVMSnB4THhqNTJEQjJTTTJSRXFOeUJG?= =?utf-8?Q?y4/ff0J003kj7gpfikdCeVBX5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f297f3f5-759f-4f67-05fc-08db9293e33f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:33:27.4298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hie37q/eIz2LOO4xNP1Z1+tzZcp/4lL0HI8TltP8CrJGJlyV03sjRA3aqI4zjpj2S7eGxGPKqf+RsNf/k7pRVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8020 On 01.08.2023 14:47, Nicola Vetrini wrote: > --- a/xen/common/compat/memory.c > +++ b/xen/common/compat/memory.c > @@ -81,6 +81,7 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat) > struct compat_memory_exchange xchg; > struct compat_add_to_physmap atp; > struct compat_add_to_physmap_batch atpb; > + struct compat_remove_from_physmap rmfp; > struct compat_vnuma_topology_info vnuma; > struct compat_mem_access_op mao; > struct compat_mem_acquire_resource mar; > @@ -321,12 +322,10 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat) > > case XENMEM_remove_from_physmap: > { > - struct compat_remove_from_physmap cmp; > - > - if ( copy_from_guest(&cmp, compat, 1) ) > + if ( copy_from_guest(&cmp.rmfp, compat, 1) ) > return -EFAULT; > > - XLAT_remove_from_physmap(nat.xrfp, &cmp); > + XLAT_remove_from_physmap(nat.xrfp, &cmp.rmfp); Is there a reason not to use the same name in the compat union as is used in the native one, like all other members do? Preferably with consistent naming (which I'd be okay switching to while committing) Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:36:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:36:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574194.899422 (Exim 4.92) (envelope-from ) id 1qQpYF-0004QI-GD; Tue, 01 Aug 2023 13:36:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574194.899422; Tue, 01 Aug 2023 13:36:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpYF-0004QB-D0; Tue, 01 Aug 2023 13:36:39 +0000 Received: by outflank-mailman (input) for mailman id 574194; Tue, 01 Aug 2023 13:36:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpYE-0004Q1-3e for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:36:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on061c.outbound.protection.outlook.com [2a01:111:f400:fe1f::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6fd846e1-3070-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 15:36:37 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8458.eurprd04.prod.outlook.com (2603:10a6:102:1d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:36:34 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:36:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fd846e1-3070-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4ITu7ZdNEDYe8tPY23Di+f5HOzumdazDSq4CPS7mIeH1Pd0ZmirhnTy6CHQ2fbOlfbCV1HOKlUJ7NN3MMZx98g8I7PVgIeWy6LiH2wjOKv0Z4u6oojdKPIFujFh/5tscAHpqoiaDNZPonCkwY2gSJe4tnw6mLZ0c4Vkj0YcK6qIFxGkAKjLMlbIfOBzOnwKffPrNA8HMymRVQqA25FQ8cVB4NoSMEdAOshi2rjpcfUhToPWJanMHTETWxLmWr2TNlPWqcb8VNOY/w3GgKZNfMWHM6VkS6NLQefdfyEvzcordrDi1HLpns8LnCEfdjJMo1Ka6RuEetO9mPh0eZVc1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hozC17tjp/omz3GU5XAC+yq/4W5SBZ74JNY0BYP1XQU=; b=gevGrBb6iAHHgmVe/es0x2Vnbu6GrRMb8gtxXw6dTjgJ9437cY3K9q29Dz5CSMRu/U6gdJz4aP1UQ9Q+gJbhpjkcYef7yO9PXXvr9aY5ZHI5icrgMtx233raegYdbENSbZNIIjmsbaYj3m4LzvI3nOQuNtzfEMeirLjP7dOQrn0IQRRjUn5c19C/0ttbw2h59utiKt8uWxhYEF/TS2BaQuSDj3LImQAQEaC+I203ep/rZ2rtNjDJ90mq53zuwsPNWdiaKjexWEXlut1cTggBYYFJpEHuKxIieiqBBkDqIZbb9tEDiZtcfjQHeZ74HGaqn4n16JnqIThOz0ZDZoRelg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hozC17tjp/omz3GU5XAC+yq/4W5SBZ74JNY0BYP1XQU=; b=Pnd33K6GujtS++tpoxX0QVKi15Mh3+JOImaV70tHqhoh+wXLR1C7pkwvpm/X9d3ystRcdtS7czh6kisLLUk2TUg1ckqCOvFdSFXSTo+WWMUsltR+O1Z6E4Mm7gFy4cv39Zq/ZFWyIh6jsQcG0GSEG8L0KxD/ZRNwnq+cRCzhj6UP7b5M3yOuDE8oUb3wStTduI8gzJ370SB5khCYaSML009j61ZBnaORl2eoZkdreLsqXLSKrSdwu/RSUUSvm9rgFW0e59DDGQaETjteFBxNFIEtPgnQIpANjfGJy2SUgeemDsvNL7ctB2p95/3blERZ5i7UsKPm+Iio3MqbNyo3Nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Aug 2023 15:36:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH v2 2/3] drivers/char: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <69fad93eeafdceae5de1f2483015f05d1798b6be.1690893696.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <69fad93eeafdceae5de1f2483015f05d1798b6be.1690893696.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0218.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8458:EE_ X-MS-Office365-Filtering-Correlation-Id: 888fc257-c8b8-4cf2-cd71-08db92945290 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MMHDjYSwCFouI6pAydHLnDVnJhDCmCiNQ9aWQd0M4GcfycLCSbTzwyW4Dn5jiREw2AWBdIpbhkwzMkorv5HPNJCk6SY77KAWcfdw16SGbBetoKHW7zWGJmAbyTkSWCXRuKMk/OcmTFfd/Hf3iXLzB/4UMhhxLEWU+UFgkrjAFw2viv0GnYcSuQLRcSWxszdwwRZqDD9PnZdaOIw+vzGk681UoftV2KVGGCEDLw/hr3/ztD4lMond1c6w/+hOcKwi2C7riS33D7RJHHUIvdLxymAkCFtF+/9BD+XIp6U4fZ7G0LZ3g2KKkcBHo2cLrzBpEc+oviV7VIwLkfuAsd3nawhN3IL7csmeL6v4yRMpMtw58U6R1pxzccwk3kxYe1JGSYHyPtF9PK2o/N9E78pK7raVg1G0r52lPc29KzhJcjz6TaYFfjiCHgHb6ikfuXvBrDy52xGRClAtsbs43hUVvSzHrxguX7L1/ow9+UPsQY/8d5dCvdRQFOWGXgeAdBPFqTiSUoIBS9yz31zvaN3GGxPI+daJtJFxApgwgxK/68FbJQFqnRxeKGxRq+nwSW2N4uM/ir5RUFzDIrLagrYeC6Ygyp2c6t6oqqJ6yRShr42Qckv7/ln9AcYw82T2JfL5wQxS5kq4H7TYlCL1VB2v+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199021)(6512007)(31686004)(6666004)(5660300002)(7416002)(186003)(66946007)(66556008)(66476007)(4326008)(6916009)(66899021)(478600001)(54906003)(6486002)(316002)(41300700001)(8936002)(8676002)(26005)(38100700002)(31696002)(86362001)(53546011)(6506007)(36756003)(2906002)(4744005)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RE40eEd1SjZEQUMzVEV1b2Y2Sm02RXpGUlF1Mk1peDcweERkUWFxSFJwQWs2?= =?utf-8?B?YmRvaW14bVpHc1NhM1U1SlpuYzRNaEtGTXJuMmlFUUNxRkYyU1RoN3FOYU9v?= =?utf-8?B?NDNqNDFRV0hZSCs2OHIyYmFZaEx3Mys5TkZmZld6RnQzWUNqYUZkNjAvREhU?= =?utf-8?B?bFFqNWdQb3Zia0NHR05SckJEd3BZWlA2Z0U1VXNNaDJXMFZwdnhLcmR2Sytm?= =?utf-8?B?cmNhZUJacXFhdkdtN0RJVCtXMXppU2JPaTgwWFJ2T1FZdEI5ekM2Z29xSVRS?= =?utf-8?B?MVB1NVEremNlWGlrbktIS2k3NlRndGZ5dFRrZzJlN25VaCtOaDFLSTVULzVz?= =?utf-8?B?bDAzQmVubUhtNUhUcW9ld3lmcmR5M0ZDWGl3TlhTdTZPNUxoQ3JBMXFCQUM3?= =?utf-8?B?WWtxa3EzZE8vV3hDVTVDczMxQm1ma01paDVZbWhNMVNUVGdyZkZ3ei9uRUZ0?= =?utf-8?B?eCtFWElYY3FOUnJSaDVxd05aSGc0OU9SSyt2bnBvN3JRc0RPWFY5SDMxMDE2?= =?utf-8?B?djVkR0gvYTJSSDNBODNCNDYwT1JWTFUrNXN3N2V4VnpnVndVb3U5MjBaUXYx?= =?utf-8?B?eERoRTE0d1k3d3BzNHg2R3NMcXI5Z3JGQ1F6MTdLalNrQi82THdaa0pjY0w4?= =?utf-8?B?TkkxaGdZcEtKSVpRdXp0ZlIzVEdWUk9mZEplK1BzQ3lRZzlFTVBHQXAvVlh5?= =?utf-8?B?anpCdG8vVlFOalY1WmxtMkNDaUJrQWV3anowQ1FWbjB3bHQrZEsvVEVOZjZt?= =?utf-8?B?Qy9FL0FPV1VPUjhQQVVJR0tpOWhJcUhNNzc3NzBRUTIxYy9ldm5yMVBTRkl4?= =?utf-8?B?MnJ2ZUpLc1ZjMEFsVThZTlBISUtpWTluVUpRSy9EeDVEbmxRcFFCUjFTblFu?= =?utf-8?B?MGRFb29Dc3FaUCtOckNkNWs2L2dXNWRQSnlINWd5bmd0ZFBjSHR5Ulh4Y29p?= =?utf-8?B?WXFPV0tyaUI4ZnQ0b085M1MwRmllUU1PM0lZL2NSaU9hT3c4cHZzK3NyK0xk?= =?utf-8?B?OGNQK1g1UC9hQ0lSOUMvUGdJVm1lbmFqZTJxSkZBMUdpSXVBSGlYakFnUEJx?= =?utf-8?B?M2VCRVVuSGRZTHZOaW1wcU1NZFo4UzQ5SUpjeC9RS1VaTWZCcFplak4zdHpM?= =?utf-8?B?UFE2bENLY24xQWxvUkhEODBOekgxaWVMSjNtUityMWYwWlRIK0lwdWdaYmNO?= =?utf-8?B?ek1Idnh4enVFRlkvcy8yWGRuWGMwNEtFUlRoZ2R0Y3V0VGZTazY0OURPalFy?= =?utf-8?B?OUpoYVU3M2MwZUoyYUE5QXNwbSttRHVYKyt3UDg0OXpDdklkQm0vbnUvZEpl?= =?utf-8?B?cHBvWXJOK21hVmx1V0x1MDNXQjZpczFYWThnbDZyUncyZ05ISXBIeFNzMFJw?= =?utf-8?B?eS9rbDBFdDNLTmlUZjJCWEVndXhyUFpFZjg0VEtESUxxVzUzMkluSi9XbC8v?= =?utf-8?B?MnJpcGhtNWNrQUozVFozSktQSFFESlJCRHNIRkZqUWxHKzZIYjhVV2RudzBD?= =?utf-8?B?SWZObU5SNDd3TmRTVCtTaWR4RW5rVGhXd0JJK2VpejVnVzBVYlY4eEIrM0Ni?= =?utf-8?B?SWlMWFdidXBXdUdXVE1XZmJUOGtCV3l4MXRENk9TZk5jY3YreitrSkJqMjFr?= =?utf-8?B?emhOYWNGQUtBNTJYbno2c3krTkNmNk9EQk1tck5VWkt5cWJRbllXYWowWlRi?= =?utf-8?B?RS91UDhtUlkxL2llY1FGYi9vc0k2QnovdGxTTmJZR3JKVUxoZmpFdmQ0eXl5?= =?utf-8?B?aFZ1ZHkyZEtMVWo1TEZPYWdrNEtqTnFzZ2IwTUwwRjMzZllnZUtCVEh4WU9E?= =?utf-8?B?MU4zNDBqWkxJQWsrQzhhd1N3YVVadktlbFdYU3U4TjduaU9aN0NZY3AvT3lV?= =?utf-8?B?ZTVvRTJ5SUYyNWZkRmY4WmxiRy9DMlM0Mi9HcVE0T2VoT0hmalBZbzUyTEhi?= =?utf-8?B?aXg5N0lHVm9wWGdCajBEbVpHakYxMU9XTjZlQ3FWZ0Vmank2eGthNUtBQzZm?= =?utf-8?B?aGUwTjlWOHpwRWxNUTdjT1RGRG1Wb0RLd1ROSFR5OEM2VSt6cXY5NFY0TC9u?= =?utf-8?B?ODVqeXlNSC9uVk0vSEhvOEpuMVNOMFpxVTJHU2IzdUVhck5Dbk10SzVpM0w5?= =?utf-8?Q?BXZySUJOh0qlhTRSCHysV/B2c?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 888fc257-c8b8-4cf2-cd71-08db92945290 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:36:34.1940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yTwIbitSdyasAsnoVxynS4EcIliggnWwGl9HCNHAEuLptGOqesr8OBRyrO7tpMs8TC2SqqvSELBhIsH1fS1lpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8458 On 01.08.2023 14:47, Nicola Vetrini wrote: > The following strategies are adopted to deal with violations > of MISRA C:2012 Rule 5.3: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope". > > Local variable 'ctrl' shadows a variable defined in an outer scope. > Since the innermost variable is used only once after being set, it is safe > to remove it entirely. > > The enum constant 'baud' is shadowed by local a local variable at line > 1476, and renaming the enum constant avoid such conflicts. > > Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:39:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:39:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574200.899431 (Exim 4.92) (envelope-from ) id 1qQpbK-00054q-2v; Tue, 01 Aug 2023 13:39:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574200.899431; Tue, 01 Aug 2023 13:39:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpbK-00054j-0D; Tue, 01 Aug 2023 13:39:50 +0000 Received: by outflank-mailman (input) for mailman id 574200; Tue, 01 Aug 2023 13:39:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpbJ-00054d-HL for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:39:49 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1950b4e-3070-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:39:47 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 33C4A4EE0737; Tue, 1 Aug 2023 15:39:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1950b4e-3070-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Tue, 01 Aug 2023 15:39:47 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2 1/3] xen/common: address MISRA C:2012 Rule 5.3 In-Reply-To: <3c29439b-cfb8-68d0-8677-91ba897f5e7e@suse.com> References: <3c29439b-cfb8-68d0-8677-91ba897f5e7e@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 01/08/2023 15:33, Jan Beulich wrote: > On 01.08.2023 14:47, Nicola Vetrini wrote: >> --- a/xen/common/compat/memory.c >> +++ b/xen/common/compat/memory.c >> @@ -81,6 +81,7 @@ int compat_memory_op(unsigned int cmd, >> XEN_GUEST_HANDLE_PARAM(void) compat) >> struct compat_memory_exchange xchg; >> struct compat_add_to_physmap atp; >> struct compat_add_to_physmap_batch atpb; >> + struct compat_remove_from_physmap rmfp; >> struct compat_vnuma_topology_info vnuma; >> struct compat_mem_access_op mao; >> struct compat_mem_acquire_resource mar; >> @@ -321,12 +322,10 @@ int compat_memory_op(unsigned int cmd, >> XEN_GUEST_HANDLE_PARAM(void) compat) >> >> case XENMEM_remove_from_physmap: >> { >> - struct compat_remove_from_physmap cmp; >> - >> - if ( copy_from_guest(&cmp, compat, 1) ) >> + if ( copy_from_guest(&cmp.rmfp, compat, 1) ) >> return -EFAULT; >> >> - XLAT_remove_from_physmap(nat.xrfp, &cmp); >> + XLAT_remove_from_physmap(nat.xrfp, &cmp.rmfp); > > Is there a reason not to use the same name in the compat union as is > used in the native one, like all other members do? > No, I just didn't notice there was a native remove_from_physmap field when choosing the name. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:40:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:40:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574203.899441 (Exim 4.92) (envelope-from ) id 1qQpbd-0006J4-9d; Tue, 01 Aug 2023 13:40:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574203.899441; Tue, 01 Aug 2023 13:40:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpbd-0006Ix-77; Tue, 01 Aug 2023 13:40:09 +0000 Received: by outflank-mailman (input) for mailman id 574203; Tue, 01 Aug 2023 13:40:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpbb-00054d-Uj for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:40:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1b::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecc55504-3070-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:40:06 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8458.eurprd04.prod.outlook.com (2603:10a6:102:1d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:40:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:40:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecc55504-3070-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzJH4stPdSJdHl5TKNx9FsJqI3iXm3IPRgWayWnG2S//Izws3QuvuNAnxM9znd3u5p/fFDfNry7RwCG5KRViq+MKa1vQFSJAxDXOf+c9oO337yvGuikBP5BNiE0RFeRkW13ChwlQtmJiGSVrUNG2Fu5jShE0L6GAdTR4IQvTEEBfCorwmUIA2aiCtQK0M7Xugmm7uuJWhKKzHertC58oK5s8FBFcQg/nFbt5AhpZ/sEAO0b6mMYlHRAmP38vlAfePoTmLiMnZmOnRyJR2MmSajgwVpKygCz9RMAu6iedfNfC3cLs3usxW0JsecGddCQSDuBxgNrKtbZhfWnkAhwGWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=How/S47Xv9emA9E1mw2tT1xwEq8x3RCZXP65VyZuHWk=; b=Spvh6rqIkVbHXKmxS/+ZRV26NNu8wYvX8h7nyoEdIyMFPoH5AgZ+WDjAHUeSEtMTfoyWlkUhNUfgAty1UJcU9LG6jUTDs6jdJjqDYbmRIDMQTQ3anOW0g2Fy7BgUBYKmodbXY5rJfvTqfPITQCJcdXaZ5QVCMvtas3ysuiNFJM1bEhXJFVMqH65Ef1gNR/FXa1bm0ejAhvV6Oiv1p0HumxpljHgxUZvpB/C4wU8FbqGduQ9JolEceNmVxgzZC7xMil/wfBlN6lNpsEt8OsLCFk9MmDP/QEzH8u0ltJO5A23p6irus6m8OU9CulopLvlcXHUCnksG2cgxCfvDX4dsXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=How/S47Xv9emA9E1mw2tT1xwEq8x3RCZXP65VyZuHWk=; b=A7edsJ4PmVNhNGvlbnVDlPqBCGuuaAAEpKZIFzGMaeIRkPAtP/wjKqMszAOzpI/e6GfUBOLwL+3sUkQrhf4NFEhcfJJ2Z63zIIT1UfX+8f7O5p3hmgWweBwfG5cHTCvmyZZnJcvZQNPXwn2s89W0MaqLRuNNU6tr/IZJr1MLDmtbHk54b2lD3TrgxSuuWOMjGM341Ve34Oct29v/6zgwfUfPM5Or6QoWT61eOX/OsZQe8X3AV9vQZIKM0B2HHxXdZd9EaxYHe1W1AZ6NECvT/Z44V0RdAiuUbJqSp3rEh1t4MiIgBxa32lLGaluq27yNtAYsPRANhoUq3C3lS0amsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Aug 2023 15:40:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <9ec42e01258968d2dc71d59c5ad41da448a7112e.1690895099.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <9ec42e01258968d2dc71d59c5ad41da448a7112e.1690895099.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8458:EE_ X-MS-Office365-Filtering-Correlation-Id: be19f6f3-9325-4ff6-2380-08db9294cfc7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E4+krsXXqBRwETfSY3knfBPPNPhAJ0ekQzqgAwoz5rtb4Utj8v7O3kmVqOEY9/7s6u8sSaHPPx6aw2Q8SQS1h0sL9Rjoy4tRlt0sfmEAwMIi5798RUxLyX9yegmqyvGHa6RdLTsMikeXqq1xzlTQ2P93H1nNO4H30wq5YeW+pXRWW/dqY27yunIPpfiGWzfn4Vqaa08uLuORC2Pg7y90om1zJsRG5o8oqNTrclAGGslkU7YA+B8ROJqBXpajde50x+WR01xXgq3a2waBatYqx7K0RcVDFyoCa5jth3PrS92Fsimivz4VLIjY1sCkab9KgGQQw8eRtrjVVKP8JxBvuE25wAdS25gOd4QMFc5DhTHkP8YzfCHfgELWYDblat2Uxt5Lv81DnmtPIcLegmZFdHr5SeLyp3fBU54hk/AapmGTjF7mM6XWEZhAd687+oo+j3leksI1FTYKIpeXpHUHR511oxXeDEayt01AO1rC9D8fuTALAkXn99rSIJINXAVrJXKpNGWoXt1BW6vIrXhJtv1DtJn2FSQT7JWmi+KB7pxUvs1SAWsfp8/TpyJMDTdoETx+kMNaunhO+WuAcV4cE2qRBxgne1jJIVNTQCjO1iIXMf75ZCL6H8nwiJPqp5qDPuYN17O1EdAmeFPQPMP5Hg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(39860400002)(346002)(136003)(451199021)(6512007)(31686004)(6666004)(5660300002)(7416002)(186003)(66946007)(66556008)(66476007)(4326008)(6916009)(66899021)(478600001)(54906003)(6486002)(316002)(41300700001)(8936002)(8676002)(26005)(38100700002)(31696002)(86362001)(53546011)(6506007)(36756003)(2906002)(83380400001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z09obTZvNFE2NjlsWC9MbkVOV0RpZGRNOG1Qc1MvQ3pNZUJUUVVVRnlqaTdz?= =?utf-8?B?SlpDK1VKbjR0ODZqN3hRcEEvR2RXeGpnbHZNdndUdm0vSTl2NStURjhtRCtI?= =?utf-8?B?RmdYSFlIK0tTRUZaY251ZlVkckswTjhhejkwcStyZDBTYlYyME04VzFXOW9Q?= =?utf-8?B?aEhLRFRMWS9tOENYeFZONC9iODZRNW0zNmJxZDBaU3hwQis4b3JpV3FCQmVV?= =?utf-8?B?WE9GN2pEc2kwRUVhakVyZ1NYNm51TUY5SmdiM0F0a2hyL1E3QWhWYlpWT0sw?= =?utf-8?B?UEY0b1ErN3BUQVVYTW1tYk85NmtLcFRQY1RhYURUemtSZzRTYlNxVlVkcGds?= =?utf-8?B?NThUUG1YNmovVUxwWHB4WGd0cVJ2S3FJRnNmK1hLY2FEYlZ1d3JCTHV4dklo?= =?utf-8?B?dnQ5a3VBWm0rRXRXZjdJWkFYQ0NiQUdrQWZVcCtTaUs2MHJKSCtVV1dzaGRL?= =?utf-8?B?TE1kaWFSektzSTZ1Z2ZCU2lBTnZBWXRROGhJMkhYMno0TnJMME1TN0pGUWg3?= =?utf-8?B?TXNkUmFRc0xsMTcwL1hRdHpsWHB6Q1FrelBWdjhjVHRBVTZCVHhhODdlZU5a?= =?utf-8?B?YStKZUpyNHJTQVE2S2lZbytGendXRFlxb25lRHFhT1Z2d25qMUM2MGc3TjJu?= =?utf-8?B?WWdkd3p6R1l6MHJlWjR5ZFJrU3dEOGNScnN6TElnd3laUEJrUGpBRUpyU3Jh?= =?utf-8?B?cEhiWkdBKzVCbXd5WE9TWTJLcUVoR2F5RGRRQUE1WjUwWXBobFZ5NGtPaEVa?= =?utf-8?B?cHNlWUN6ZXkyN3VUVkVOL3ZWbndpNzF2b1NJL3RoaHRJQmdPbE1lb2paSjBG?= =?utf-8?B?THVnUG41VHpWdEFWU3ltL3JGVitxWGs0ZzN3WmhWSVJYNUhWd1RtUXlybGJl?= =?utf-8?B?RTJNM2F4c3Exay9YU3kxUkRvWDZJTFhqallvZjYvMWtWNXhrWjduS3ZOeXRG?= =?utf-8?B?RHY2ZjNtYVVqYWZvWDBqSUNMN0dpSWdZQ2RrVS84clp2cHJNQTI4clBTdUU0?= =?utf-8?B?a0h1NE1wYWcvUzZMT3VmUWZVSHVjRmxPRXozR1FLTUFUdTZuckRhUHNqTUlz?= =?utf-8?B?T3FKQlpueU55SlZ4YmZsV1BnajIyajFRNEM5NmRsMVZPVGFqeSt3MGdDSWdT?= =?utf-8?B?VWoxYTdmU0VwVVJ0T0ZveFZvWW0yL3dITndWTGlNQ2crZnVGOUMyekFZUFM5?= =?utf-8?B?ajZsMWl4cklqT3l3TVVpMW0rMDhxZHZJMXF5QUEvYU4xZzhvTW9vZHcyaHEx?= =?utf-8?B?d2RXWjY5TWJrWml2bG5LSTRFTThocTFHaEVpeCttTzcrQ3VEVTI4MlZ6WXFa?= =?utf-8?B?Q3NDOE4xSVhTUkduMVkzT1BDN1hpNEIxMDFKNytPVVdhSkIyem5xQzRSd0hR?= =?utf-8?B?MXNBYWZ5aUk5MjhBb0ppQ3R2REdZdFVPU29HeDhDdmdkaHcwRkhrN2FTZU4r?= =?utf-8?B?eGQvTE5ramFFajBOZVJwelpjZi9wMTNzUHhNaGoyMEtsc1N5czFiSUJYTmhH?= =?utf-8?B?V0RtNVlWOHZhdXhHK1lnZkZyclorTXRuemRRZ0d0WjF3M3RxZDdqODhNc3NV?= =?utf-8?B?Q0dTYjhmdW1XR3BpL201MWNpQTVoK3FyQ01CSDV5NXV4dmIwamc2SmNIUzdi?= =?utf-8?B?OTB5ZzRBL3lwcWhWa1JWck1nSFQyVG4rajc2SkpqeDdTTVBGK2dLUU1OZ01x?= =?utf-8?B?VGJFTXg3WktXRm1MRjBPUG91Wmt1Zm1WbWwrSDFiWGY5YzZ4RlhzaGN4bDNP?= =?utf-8?B?bXcxYU9GbGpINWRFTHA4RmUwRkI2MjlVN1FCZ2ExVHRjQ01EUTlrOWd1SFox?= =?utf-8?B?MDRYZnlPZStMc25EWGkyekVhTnE2T29ocmw0YjdyQVNGUExNaFdncW00NkpF?= =?utf-8?B?WDU3MlhPVkQ5UTRnQzBBUWI0bVNKS1VtUkZtcjhodmNWeXZnVjRGdEppMGNp?= =?utf-8?B?cWo1L2hhWGE1bHR6R09zNk1zQUtrZS9SNSt0TXZ6OFdXcWFSS1VxTW9mc0Zp?= =?utf-8?B?UDFpUVdjM2l0V0hpL3pQZDJBT3l2NmZGWTRXaWY4dGdrMEE1YWw1RkpSREZi?= =?utf-8?B?T1kwcmdNYUZCTG1GdzNNY1ludXgwV0ZHUTViTXFsdUR2TFZXSG84MjJsRWVS?= =?utf-8?Q?2tcDxrp6JA++gl6WdpD+FalXY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: be19f6f3-9325-4ff6-2380-08db9294cfc7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:40:04.3035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bSODcTpKqLyTtQebq8Cd7EYwbHDKMAx3475i6Isrdtesgp4om80/aO1KUHM6DOu7wkVnaDTC02aCtLzgxN8gUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8458 On 01.08.2023 15:06, Nicola Vetrini wrote: > The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the > struct declaration to have no named members, hence violating > Rule 1.3: > "There shall be no occurrence of undefined or critical unspecified behaviour" > because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: > "If the struct-declaration-list contains no named > members, the behavior is undefined." > > It has been assessed that the feature set declaration is intentionally empty, > and that no risk of undesired behaviour stems from it, hence the struct > declaration is marked safe. > > No functional changes. > > Signed-off-by: Nicola Vetrini > --- > As agreed during the MISRA C group meetings, this violation is dealt > with by means of a comment deviation, as future changes may eliminate the > root cause, which is the empty feature set. > My justification for the claim and the commit message may need some adjusting. A reference to the compiler extension would be nice; the use of extensions (which generally are well-defined, even if not always well-documented) should eliminate the UB that the standard specifies. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:43:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574212.899453 (Exim 4.92) (envelope-from ) id 1qQpek-00075I-Q8; Tue, 01 Aug 2023 13:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574212.899453; Tue, 01 Aug 2023 13:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpek-00075B-Le; Tue, 01 Aug 2023 13:43:22 +0000 Received: by outflank-mailman (input) for mailman id 574212; Tue, 01 Aug 2023 13:43:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpej-000753-T5 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:43:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7e1b::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 601c0d20-3071-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:43:19 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8175.eurprd04.prod.outlook.com (2603:10a6:102:1bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:43:17 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:43:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 601c0d20-3071-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kaa55exP1dH53h6NXOA8g9mLqzi0vWhJQ7Qfvoa8ODFOexS4acFTMp0xDZxsQhCuiaARLbImLpFXjY3RQap19K/HyFM6ThPBrlixHIor6eGoGQnTWAXLK05L6nFUjus6ImW8TP8D3q128YBHn0yv2DDQIBRT3zU52h4WingD7KzrY6eWB0JCfeRrWAiolIie1tgU1IXHaHzD9QYPcf/enPp/eMroMSRuNDt1rAXmSLrCzqceFhuMCCGhUQ5ZOAgM3UUD7m1hya4ctXBmvtpNpfVM8c1EgfDsXOYmkxLgjAd/YoByuvmlitdWSb5PcI6QNcRiUA3++X1knrLV6hQg3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/4fHfafuHZMx5+gVWA6f0qz5qDoXR/Uug1l1ra//4ec=; b=EVgNO5z3DsC16/2CjFelOQV1xXnFQ3dJfChH7MMdyQ37TzNImJJkJNTXUMFtyy/UZuRQl+fhK0vowciR/Hp6UUkH7u/vVf7dhtxToflDAsa5mipDMiIod0zV3iA9rBknTgOCVjTe6chNso9aD5yiugic9HoBbvTn/dA6dU50aKU6YOjqr78yhhWHRpt5jOeMW0RCb0MxBA7fUezavoNozY4SL3tskTWwfabCT0XAmVqe7G/Nt/jMk6sHKC/IoWUFELEAbqFMLhAz+JLOR8tatI3AUsJJ+u0MK5+bWzYLNw9ocxkg0XPARlwFka6KC/6NIqVnCprhB3Go4Bf59Ci4RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/4fHfafuHZMx5+gVWA6f0qz5qDoXR/Uug1l1ra//4ec=; b=zL05pNQ8Yqx0j1Nan+0x268mp3ciKxTeYQjIy4GnQ0vvmiddfFoqZByiv5upRpg/PUeieVMKERtyUnXih2Y5lxiS7SKnBRIHIz68kdiLMc0msG/m5NumfTCRlnmG0xN+yZxivTsagw3qIy3C1JC6DOjMdWfqwKQx/Cm4ZyDieEk8v7jo32zDpJ65stmLXXDxg7CDMTYiyWCvUWTlzkRpOMtxWDxnwyKTqvQ+qi/y/HTzW8eBtdoKwWTNmJRijyWyku/lq6UB2zgr/p7z5wIcLu5+phF5mxluOubpZHFPE0xClVwZUZI8QzCDQ0TUuIFxnFvLSBQ8Sg4mCvIeF/ctwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9d76dd1d-3001-3d5d-996c-7bd3e0319a77@suse.com> Date: Tue, 1 Aug 2023 15:43:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: xen | Failed pipeline for staging | c2026b88 Content-Language: en-US To: "xen-devel@lists.xenproject.org" References: <64c90a07e72e5_2810b7bdc200923@gitlab-sidekiq-catchall-v2-d6969f8b4-tmdbc.mail> From: Jan Beulich In-Reply-To: <64c90a07e72e5_2810b7bdc200923@gitlab-sidekiq-catchall-v2-d6969f8b4-tmdbc.mail> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8175:EE_ X-MS-Office365-Filtering-Correlation-Id: f18b262e-57b0-4c1c-3d02-08db929542d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L1+TjBuhQ82ffeJBPZaREd3VIvavG5cTgyrOIRPZChQbIIsW8cJ4AvUbIdUj4g9I6xuJanReiiFXKl4woPWIBPzRrY/UkuAszBEfr36X/fVVghfAhRAAVBWQKhq8RUpRe+oTQMuRatEvGJtcK2XRLboZHVACKiTFLlYujwCTpuVwp10Tz5JxSZyOq5AzvD08pV3tnSj6H9urOTRlEv9sFbtH1iQahBCM/44RfvJOME1fnRUg3tJK5UngvoFrhfu9L5Qxo5TN/xhWFC47eojfBySmW0LyMhxy94KtTSpApdc57uSHgwA5pBgycJL38z9rBfoBKkagF1S3UDjjxVHM2WqHW5wNXooSgBS/FMc+qqRxhojCA8smzl8ycg1jKcxBzwS3ySo3AinR18SMZ6W57xB8o1jK+XfrlBeDFApjfzloMpPzEUXiL2zpX6QzmpAZ16pQyGcZZRichhNAkbCNWTzyv/Kr9cQ8Brpkn4eigG26tJGaO2tZq3KOK5tqqXpJjRCiZ2MPPRxCwS5WGCqH4WBz58yv1bKIi242YkkIjkDtdr3lChBcoHAXm8h9g4Wj0saFJS/o5Mhcy361VRRQV0T0f2nI/5NIYY9Za4QZYQ0qfqqAgcBaS97BvrhWqLfujEylvv8EmWKI5rppstgIuqmMi6pXpfRHSxEnRluKN9qoB+atZkWSz15z3eMv6vwy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199021)(6916009)(2616005)(83380400001)(2906002)(86362001)(186003)(316002)(31696002)(38100700002)(31686004)(41300700001)(478600001)(966005)(6512007)(5660300002)(66556008)(66946007)(66476007)(53546011)(6506007)(26005)(8676002)(8936002)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTFKTGNlanZOTUdwTVg5M3VLN1EyN2Z1MTdaTVhJYUM1NVYrZUFWL3I3akox?= =?utf-8?B?Z0NURyt3ZWlVNm1JNWV4elhIdVdiWFRsdE1qKzltV0lNL25sWTU5ZFZqK09V?= =?utf-8?B?NFJ6TmZpQWZPT0VLdTZnWmZETkc3SVQ2cjMzazZ4eXhhbGdrNm9RWEVtblpB?= =?utf-8?B?NDdwdDhEVC8xWm9QNVEvR0MzNkNncHpKV2JqcUdYeXJlYnoxUExUbVBKVndC?= =?utf-8?B?NmNQYjBGTndaSmRXaERtSGUydWNyakJsUEpZZWtqalFkeEtzRkI1cE5keGRD?= =?utf-8?B?UVhicVdIZXRQMStGSXdKN2sydHBiQVp1bjZlQWhZWmlqS2RRNTUrTXg5Ylg2?= =?utf-8?B?TURmS1JVcnprTi9icnZySnplSGhOaUNQd2RsY3NCb3hYMVlBcEZGKzQ4MXNI?= =?utf-8?B?a3l0dmdkTHJKb0x6NHlvclRvU2xEcjhFZ3U5d3N3bXU0UGNEYVpuWnByNUxZ?= =?utf-8?B?QTdPMnpIWXVTQi90eE1GUEw3L2xBTjhTTlZZd3BGVzZHY0ZvbVE2S1BmcGNN?= =?utf-8?B?OUcxUjdFVUtna0kvWm13bXZsa08xem9nekJEV0hlQ0hmVW13Ym5iSTNTRndC?= =?utf-8?B?ZnlEek00cjEvK3hSOGgxWXQybHd1OGFpSDVlUVRDaUp1bmFYUVVqM3E1MTlB?= =?utf-8?B?eEIzZGNGdzZLZnVlZXQzSHRZeG5CWlhaNTdLSy9USWV0TzlZT1RRRVhCVGdG?= =?utf-8?B?NW1mNEUzQ2w3WGpnaVQyS0FsYXVKb1h5eTU4aFpHUVFSMVdiRU10ZlpGYkNH?= =?utf-8?B?TWZINHVZMmo5Q0JCZXNXMVNLTTcvcGQvY2hrb3ZNTmFlbTVwRDEvcDJ1T3FG?= =?utf-8?B?MXdlZkNscVJ6eG1CanZGWXRmcHV1RGY4TEpDMkQ4enNxM3o4WWJ0M0kxYU9k?= =?utf-8?B?aU9qR2RsaTV6VGlzeUgwanphVEJHUTVxaFkxOXFITTFEZjN2bGNzbU4vZEd2?= =?utf-8?B?Wk96ZFIxenl3eE5ZQTVCczNFWUlURUlZa2pRRHpSNDZtUUNlVVdQN01oN3pN?= =?utf-8?B?MzdZaXFwQzc1OXpuMEdYbWJxMWJlRjA3NU9SWlk0TXpWNjd5MkIzQ2ltVkJQ?= =?utf-8?B?L3ZlVWZQSm5zWHB6S1I5RmdiUEpYVkJaMWtPVGpEdGhGS1MxSVp5TXM2ZnRn?= =?utf-8?B?NGppTmsybmZUTFF5UjVNNzhWT3IzbTFZZ2dYU3RZck1DcWxZYkVwM3BkbnNw?= =?utf-8?B?ZjVmNTFkc0VTNjdPelhpVVRTVlRORU16MWlSaldzdStjLzY4Z0o2dUEzWGoz?= =?utf-8?B?c1VtcnRnTGFQVEtXcnY0a3JoL28xZ3ltS3ArU1dwKzAyQmhRbm94Y25LdlIv?= =?utf-8?B?eG5QeHdkdkxZSG93TjJxNURzcXhCQzN5Y2JBTzlmQ2p2SVFQSDlFTVNmKzYy?= =?utf-8?B?UE9vT2ZsMW4wRlJqdDJ2TXRnNzJkWmtxQmtRWFFUWGlNZVNtWjdyNkxmQ1gz?= =?utf-8?B?VmRjbnErdE5LNTZBSkRZTE9aQWRoVlgvTVJ5M2MzNTlxTW1qdDBzT25NVGRO?= =?utf-8?B?dlJHYXhQcFkyaFlGeWJQUjRUU2FmK1hXck0rRHBEeTkreHhKRU9lcU11MGc2?= =?utf-8?B?TmlWRGlMK0hWM01JNVY2WkVxQ1djanNkZWxST3B5NGtxckd0Y2FyOHBWMnNz?= =?utf-8?B?MXlRSW0ycW14Y0VKeGRGbjhQY25HcWN0QlFNQmFoZHk0dW1UL3pSSGIwU0tM?= =?utf-8?B?UkFrVG9QN01TSWhnQUhNTU01eTdSR082YThJZTlDV1hMaDkwV3VaMCthNlZD?= =?utf-8?B?MEJHTXBwTjQzbkowT05mOVZrRG1VZno0ZDd2UmswL0RPR2ZMUk9vTnk3TWJv?= =?utf-8?B?b0R6ZGYxeE1oZUZSVHFST2Q3bnFtZ01RV2dUWjNLOGYwVHNicnJvaE1NOWlp?= =?utf-8?B?ai81aDJ4OXhhS05LMHJqSHlDMkQwMHQ1U21Hb0lzNW1TbXl4b0xhOEhuYWFP?= =?utf-8?B?NnZ5Smt6c2hsSy9mWi9ZeVB5Um51SFpTRzF1ODVSZjFXZndqRHgxZnE0Zjdo?= =?utf-8?B?YUVjSEJTanlzeVIvcGhIY1pGdXI3WGdvL2R4dFhQaGc3VkxoRFl0T1V6SllN?= =?utf-8?B?NlowSEpMSHRobTI4NlVpQWRPazlGWm8zMUV2cjFzTGkyQ3BzSk1ySkxaNGk5?= =?utf-8?Q?lV7BhuNLmcQR9bOh/Hitvg+i5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f18b262e-57b0-4c1c-3d02-08db929542d7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:43:17.3318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IL5SjDQ+KOt9lVtIEZRaW/67tTobAbyQLqavEBQJRl5YAd4QkNjPhAsOcdOH81SAt7gECE1BldePsrTFOW7sWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8175 On 01.08.2023 15:35, GitLab wrote: > > > Pipeline #951705012 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) > > Commit: c2026b88 ( https://gitlab.com/xen-project/xen/-/commit/c2026b88b58cbb6a84e2885c320a8cfe08f8ffc8 ) > Commit Message: xen/arm/IRQ: uniform irq_set_affinity() with x8... > Commit Author: Federico Serafini > Committed by: Jan Beulich ( https://gitlab.com/jbeulich ) > > > Pipeline #951705012 ( https://gitlab.com/xen-project/xen/-/pipelines/951705012 ) triggered by Ganis ( https://gitlab.com/ganis ) > had 11 failed jobs. > > Job #4777864648 ( https://gitlab.com/xen-project/xen/-/jobs/4777864648/raw ) > > Stage: build > Name: opensuse-leap-gcc > Job #4777864742 ( https://gitlab.com/xen-project/xen/-/jobs/4777864742/raw ) > > Stage: test > Name: qemu-alpine-x86_64-gcc > Job #4777864646 ( https://gitlab.com/xen-project/xen/-/jobs/4777864646/raw ) > > Stage: build > Name: opensuse-leap-clang-debug > Job #4777864652 ( https://gitlab.com/xen-project/xen/-/jobs/4777864652/raw ) > > Stage: build > Name: opensuse-tumbleweed-clang > Job #4777864633 ( https://gitlab.com/xen-project/xen/-/jobs/4777864633/raw ) > > Stage: build > Name: ubuntu-bionic-gcc > Job #4777864636 ( https://gitlab.com/xen-project/xen/-/jobs/4777864636/raw ) > > Stage: build > Name: ubuntu-focal-gcc At the example of this (the first one I picked; I didn't look further): ../qemu-xen-dir-remote/hw/core/qdev-properties.c:974:1: fatal error: error writing to /tmp/ccxkeJPr.s: No space left on device Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:45:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:45:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574216.899462 (Exim 4.92) (envelope-from ) id 1qQpgm-0007fH-6a; Tue, 01 Aug 2023 13:45:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574216.899462; Tue, 01 Aug 2023 13:45:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpgm-0007fA-1o; Tue, 01 Aug 2023 13:45:28 +0000 Received: by outflank-mailman (input) for mailman id 574216; Tue, 01 Aug 2023 13:45:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpgk-0007ez-Qr for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:45:26 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7e1b::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa381060-3071-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:45:24 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8175.eurprd04.prod.outlook.com (2603:10a6:102:1bc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:45:22 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:45:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa381060-3071-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DW1zceUW/l+lBh25JXeyA4sQO/DzHP9WnDq8V4lFBbY7s81cyEGoLkUt7EeEMk9U9REhW3BFTIEtYgZTBEjDnUpJEiAh3/CeHUsEYeH+1sMHVSCFHB7lplnOfAoZqAVbb24SfJECa17eQwquBONSi50cKJK0s9GYo3oCqkP0KoYY/e2kE5JZ4zU9cTTQr+T5JJWKyEiUTFMFjP31POhzasJ49Pw9Ckams/P2FRuu5SXuF/ArXNi4++XUzsYyM7DxSdE6hj9IGG9Wo7QWaAt9TEoouZHKXH0xxlvJmQ1/MLsJW1ZJbFtPS29HNTkOCSSo7WMvViNHfJvc3+z+06qglg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RF5UILdxX3+rsRR/QOoKs/cOA02ZmELD24IGI/l96TE=; b=k3rXhs4nuU9+NrDHe3fVbXkH7Mi+dUlusIoeUfXrfEwE6h3qPTa/MNDcWxRRYjxhKR+vNWIDBssC+G6BWWws+hKwyjtTUKWMLvqpV/my89tyzfd5sU9NiT+AMJqOesjgLjeQzdVkG1pVXkhbPHhfcLpTXSN0mH7SwIqQ85xKZprU/Xaw6h6iQUf+t6b4Drks2eYjLe85VKyzV1yhtd4Hu0A9k6i4rb3RbusxHpNuFXWggm4KXa+DY/fsGxZY4PbK+eYy8habiXp0mOgLtd3pBDKmSe4NPPueZ6E6isF8oiCuAtoBn5Tl/lN2ejhR22yzF1m+UuI0xY8wCULc1P6Vsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RF5UILdxX3+rsRR/QOoKs/cOA02ZmELD24IGI/l96TE=; b=YdOpcSD7qoK3tgbpcTohxrYMSXOiyXPkGq6nIVics+nxa2cWo5gu6LsAo0KbcfioFruEQYndCl+mFS4gYnYSTEtNv7iMwTc8+vPVrsZncqmscZ9Hh+z6oUDBbUUEcOTeV4T9XdX8BwCsEgfqaR6ihAoZBkPclqx9f94IHbqb+08nALTM5EIHA3RKf3R13pGeH7mWK/0rL2aGzxWUBsbIZo7itXzqEmJb0Q/AB48bLQB2pNxezk8tMJbT8nMM3hA+Goss+/HDZNGBXmSRrnyyw/AuAx1oa72/nVqOcwaIptP6RF8SHFwhhZHO1uN3HfN0P0OP+jk+ZX5AMUiyoLrQaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 1 Aug 2023 15:45:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH] xen/lib: address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <18adbd526ec48a83ace2d9049671d3abd2f9c45b.1690873427.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <18adbd526ec48a83ace2d9049671d3abd2f9c45b.1690873427.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8175:EE_ X-MS-Office365-Filtering-Correlation-Id: 83bb88ef-ce61-47de-abf8-08db92958d89 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ieuZ0A1Zto9bUqVMz/H3ltVo8YRYN5xCXl7traiPY5oROUAQS/JF8JYUCeTXAhwjjCwHkDS/bDzAS81dwmQkG+hTkP0Z5rhvWPwunG8FI8dX9XtVkFZes5nnTAKAcUX2foducCTXtL8UHc9Ib8ZFYk6EfwV5gNOqTLdpeDtc/DZJeyoqWDB8SAnPACRdBWbUoGgSZg6eYHypBIGUFZGFkC04p69401GDDS7aDXYLAVIm0fEp+KJaW0uyF55LGtQngDWeBsh7JCXI6dUF4v9HxwmiDs/cwIjGfoDxzyhH9/NyW1/qqo1IXJxcJTJt+IxEvj1SdhaImrFIco5ZUshpiraIAV9pxvuud7mqp0OiqrJFAY9YhRkwMIplMEF7A+UeBM4nHFbhmRpbOjhilF3n13byI30dqtXf7TyJ3zuhOQ5YS/C/jVjoaXIk+LaMOMkiCnLvJcDZACfQ2a/JS1L7Cr1OyKUe8HVgRPc6+kOFMVrLZ3+0reis6G7oDQx0F4Ze5akByRviRAn2l+GGRcEHu86SgUW2xOmwR/f3y2bfay38XImFoQMCv3zQRWPfKVe1OlhYHHakx8KP66CVcNFCId3mzgWpJRElwixgvwP8oICiuN7YDLImVLB050V5C84rCxRYSJinQ1dumsJod7LKJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(396003)(366004)(39860400002)(451199021)(6916009)(4326008)(2616005)(2906002)(4744005)(86362001)(186003)(316002)(31696002)(38100700002)(31686004)(41300700001)(478600001)(6512007)(54906003)(5660300002)(66556008)(66946007)(66476007)(53546011)(6506007)(26005)(8676002)(8936002)(6486002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2c4NGlQekoxUzdrQjc0dUVZcklDdkNkQ0hJeUN5UUlOWWFrRG9wUHErd3pw?= =?utf-8?B?SmlzeXRJTFJTZnpyTDNoYW5Qc2JwMGI0NWJicUVveW5idUdwWWdQeStFOVAy?= =?utf-8?B?dXpTSWFpQVhSWlRnNWxIKzVpazAwUGNMcDdlR0psMEdxcUx5OGtaZ0NaRHRt?= =?utf-8?B?akgzN1A1NzArZDJ6UnlqL0NnVXQ3cUhGRlFnbXZPekZ3bnFCT0hnUFJCRDZz?= =?utf-8?B?NDJNVS9mZUhnYjNsWDNkTmd2MDJESElUcDFFR3IrWjFTZ1c4Ynp6dVZvMnhj?= =?utf-8?B?WS9mbVE2Z3NqZG1YMTNuaGo3UFB3akk0VGVWeU1VOHhSV2tva01icE9ITk5N?= =?utf-8?B?UmhkOGU5d3J1UHpDUXhtWTU0OWt5NHFxV0dJd1kxTmdMYmluR21kZXMxZkkr?= =?utf-8?B?QVpIZjh2bEhOMzlXN3pjdjhGTmU4SjA4OWFqaVVyRHRlcVV5KzlUZTNEWEM3?= =?utf-8?B?SExkeXhpR1h1dmEwN29sVTBUUEY2TVBneHJncXRTOFNFKzgyemV3cmRaSy8r?= =?utf-8?B?NmlISDAzOC9ySUF6Z2Q4UTdPZDJKNk9OOGkrL1FlamtpSDZuRkpwbGpVdHNB?= =?utf-8?B?MFUybks4aW56TjJ6TWNPbHNZTzZZdkhpWDd2VXF4M1I4bExQd3JLNERRdjdV?= =?utf-8?B?Mm5RRTJDTmQyanhsT2Nkcmt5anRHYjYvVlhXallHU21CYTd5dWZpWG1JdDRG?= =?utf-8?B?ZUI4N3dtKzgreUt4ME14K0diMFpCQ1ZyTUxsQnZMenZjV3hPaVY1bTVMU3p6?= =?utf-8?B?cUVHbi9JSEJnYWd3MzR2MmowandpREhLeXhWQnBjZitDRU1yWXdtSCt4U0kz?= =?utf-8?B?aXU2Q2E5b0J5ZzhqOTlkeVlaN2E3dTNwWEcvRnJsUzRkeXIxNzFPbXN5c0xR?= =?utf-8?B?SlR0SGtjcWJUTDZJbnBvaEluUmVhR0dEVlM1b0ttbDRWYmdDTFp6LzByM0lv?= =?utf-8?B?L1drRXBEUHVGVW5vYkordjZCbmtxb014dTZnU0tjNHdOeGVpK3c0bEQrT3ZQ?= =?utf-8?B?enRjWVdxZHJWMnNjT01tSTJ0eDJzZlA2TTBTL0FtbXduS1NHR1ltWGw1N1Rk?= =?utf-8?B?QmJxaE4yZVF0OTY0QTVnYzBYbzUvNjQ0THQxS25UbS9HODM1cDJLZzVrNngw?= =?utf-8?B?TWZaN0ZORXo4MW5JT3JvN0JYMFU0SDNTaG1Bd1VvVzhiNXc2WUJmV29oWGNG?= =?utf-8?B?czl6aW5ubVBDWVowQUZTVzdXcTBFcU96QUI0OTNQS2YvZy9xWjBRVWI2dnAx?= =?utf-8?B?NUZhSGxWd3hmWXVFT0h1enBJUDN3Wk00T01rSjkrUzZHY1I2Mk44YmR1Znll?= =?utf-8?B?K1ppZ0Uxa2xnSE5hTG5tUVdET3VOKzRFMU5xc3ZrWE1aSTNhS1pqSmpSeGhT?= =?utf-8?B?MitHZitVajlUenBJT0VZazhFQXJ2TVNNTSsrWm5lTDNUMzkvS3J3THUxbkNp?= =?utf-8?B?YU40RTFjQ2wwUThPQ0tYNmNJclZobVkrbStXNDJUWVZzcjhlamZQU0ZyL0N5?= =?utf-8?B?VThxYlZNa3h5MmUyNld2QTkrY3RoS1pOT096NVg0TjlEVFlNSi9wSHFHWHRO?= =?utf-8?B?SkRMUXRXVTVuTERqcGNwZEEvRjJHMkhaTTNQWlN2azZ5TkJVbm93QTh1dk5W?= =?utf-8?B?eDVnR2U5RUlNNk9TQ280NFdnOUc5cUJJaTV6OWhzUlh2ZVBGcC9NOGpacVpo?= =?utf-8?B?Y1hlZUNWK2dkdDIyTkhWUm45aHdoZVhxMVNueDZZK2YyMGVXbzN3UGtCOFBj?= =?utf-8?B?d3ZhYS9xVDZvVFdPeFBabE5MMm1HY3hjTHhUM1o5eVhQMmRBbjRZOFpIb1Y2?= =?utf-8?B?NkdBT0RsdzJKUVUxdFdxbTUrVGgramMyeit3RDkvUjBIRW1SMXhuazBnT0p5?= =?utf-8?B?cTQ3OWRPQVdac1ZzYUNsZEt6V3kxbnB6c0JEUkNzWmZEL3NVa1VleW9VWG1T?= =?utf-8?B?aHJlOWdHN3FzRERGbVRiV0JiZW5IUTdsb2NISnNkeXlPSGtxdU1pdGprZTFS?= =?utf-8?B?TnBWQks4SnJaRHAvY1htWFdBbEFjbVFQd0FGUnA1MjUwYld2Q01rc0pjMGg4?= =?utf-8?B?SHlJdHo1c0VQK3h4eVJEK2pwUDc4TjZGNkpyU2ZDV1BDWGpmSUlYeGs0Q1Ni?= =?utf-8?Q?M5GDv55BbBAgSa5n8eEmZHZAM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83bb88ef-ce61-47de-abf8-08db92958d89 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:45:22.6796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /FrajwvgNx3BhXU/c7tTOvS+L0fCKzopUks+3j2aPx8h8nvYMnyY2FwfP1o1ohaaYuJyXXsU96UJlkyxbfWidQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8175 On 01.08.2023 09:05, Federico Serafini wrote: > Give a name to unnamed parameters thus addressing violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names and types used in function > declarations and the ones used in the corresponding function > definitions, thus addressing violations of MISRA C:2012 Rule 8.3 > ("All declarations of an object or function shall use the same names > and type qualifiers"). > > No functional changes. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:48:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:48:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574223.899471 (Exim 4.92) (envelope-from ) id 1qQpjL-0008Jn-Nl; Tue, 01 Aug 2023 13:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574223.899471; Tue, 01 Aug 2023 13:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpjL-0008Jg-L8; Tue, 01 Aug 2023 13:48:07 +0000 Received: by outflank-mailman (input) for mailman id 574223; Tue, 01 Aug 2023 13:48:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpjK-0008JF-ET for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:48:06 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20601.outbound.protection.outlook.com [2a01:111:f400:fe13::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a42e769-3072-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 15:48:05 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU0PR04MB9228.eurprd04.prod.outlook.com (2603:10a6:10:353::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:48:03 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:48:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a42e769-3072-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BM+Ylq7dGahQph/Qj1AQspYBh3eb0ovcRqKNbmCC1TAWJKUfYSGpYglmARowTo5L1YYY0Qk9HuNS3zdQytT807ZiNcSQB9emyGC0PuvGlq0oj7ZvvMtd5+gOw6oguEBPCm0fL/vU2rvscxQmx/kh/lvZrTc9/7HL4+m7i8aNn0dOq0ulvkhOtwUt6fxzJ11UcDvfqYcs+KBKPDZR3H/A2tuyc/Gg39VV5fixQnpaKDae8Y7SHq7E9UYDKzacUHS0biB9uvap9pBhSOfu6GnrNuMoJAe4YpK8REKs4pWIz4H/ICLA0/WjOXgjDN4mz3CJ7alZf5FS18/b01NGSO/uvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YphD5DSyEpD09Z5GHtJ4XjWYPjpu6zR/PRBsmuYun2c=; b=hAIZkJEhpOCF5zMRt/V5dQk4hczHdno2eOq+2aWMZy0b90C+C36nI7foizlGKIFWxrKAfcoabIRRWR1U+iD1FlUa9O3ZJre57LYC1LyK9G21luE3ROyOkIrDbewBbmdttzN+Yu2vyZEVu8o29D2KiZ80tcd+kV7DoA8mME9gccp6XBUufLisMx/yr+CEKQZcFr8n382mT7JbqLSQGzYEb7lagKzJzUO98D/KTpnQ4Zooly7b2khCRc+PYB+1Lm5SB+rh9bYcVwhxCJDe9otaYorllnio9YHjrnQwUxiUa/Co21g3Gx1WBzHMSi+K9QUohYabzsyWhkcJSWvf8luAkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YphD5DSyEpD09Z5GHtJ4XjWYPjpu6zR/PRBsmuYun2c=; b=IIqkaW0PcVMAG/Fv1mtJaRqw5p3RV98L/8N/7HjLBmSLeUxzWQyBj/CzLO35hcx8BclgGSCMHBTx1Z9VY2Sx7gjP4ZwzfYm6AqIzdUH5mN6BZXM2kpQAwY2nmQkPCWB3j9/fdlTenH0/ArgBFwODTLUpescibVulHz9/G88A4fOhp6UzfOBkPgw4Kl3vNbZdTjts6N96odeDAfqUcCVjjvaBCvWLGBEFUnueFmYVYhO9whKJVidgByVnrkof+PQEHjStY1z257Daxq8sq8pa3TrWohjcS7+bAgV41GSxc9kBAReNrqhn+/m6QdRGaj+UJ9l1cFlXBZKEL3+VbIKfLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <362e0c38-c799-eb4f-af32-3827ec223129@suse.com> Date: Tue, 1 Aug 2023 15:48:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH] x86: mechanically rename to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <6c421b903cf11e4dafdb0883e0401ebc2d6cb318.1690880275.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <6c421b903cf11e4dafdb0883e0401ebc2d6cb318.1690880275.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0168.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU0PR04MB9228:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f1dd6d9-cc8a-42c4-63cf-08db9295ecf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pi3oeX1jE8kPt2eXqnmr5hem9kJxAhs5WbihVv5rc4nZjuaiRbGU/I47mCmuYM9mqkLq4T87tJdwpO4W9ykZRVqwOKPuNm86b9o0RbkdM2VyktL3fowy4jYvLje7r/smaEEkKIIvkCvsRra88VqzlJoAcQSKeBJ7+XfyO/NqSxwVSZH36fxIqK8lYrtfAdo68la3Pul1+MkeQsP64m3uGiZSsppB2m4pxDrFdFD93r/ueXndmVoO8aQX9ps4rAgcGm66bOa3kTtPd0g/mX7mAafZcvDG+i6IG8mqGa6UDgmVgWhBFdxYpAPyEcDrfbPfrzSv+wcm44GXZbllnASQNNzgqnktT+NpJw53eg3gYfLOmW2PAzHYkCb1I7s0xLEYLpp06ZsdzgDybswsPBJqOrl1PgoMTp+fhAl3e0q/G9oqCH5N75slOcFobgx9eGuuSWIdmdsj/1oepkwzV5ON55FP6Nkl5BO7jlD1FpKro1rX3dAIn1AWsQuLlMucmpqPQ16DZkKTXfXqpGPgQvUQ7J3ASHkWiSea82/SDLD3FsU9jbE1+dH7nIKTOcR9GkPhDbtQWzcxce2g/MaDqz3LUXpMMfCQPwhZvf7RoPrhJcV+rk5fHWxtZSVVvPYIfF0GetwXdQrBj3rLuPPDpS383zyUQelvr+P/HoeZgj4UYR1wqYHV7NeNL9uIPlVvMOr6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(376002)(366004)(346002)(451199021)(8936002)(8676002)(31686004)(36756003)(6486002)(41300700001)(478600001)(2616005)(2906002)(26005)(316002)(31696002)(186003)(86362001)(6506007)(5660300002)(66899021)(7416002)(38100700002)(966005)(6512007)(54906003)(4326008)(53546011)(6916009)(66556008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3AxRUFmUGd2UnV0Q2xQTkZQV0FmU2ptRFZQTVRFamRXS2xDOVJlMC9aK1hv?= =?utf-8?B?MHVILzBwbU9LOU5wRkloT0MyYkJLTDVlRXFaU0tvRzZ1UTNjei93OVN0UlZ6?= =?utf-8?B?Vkp4b3gyYzAzcG0vbnJRZEdnZHlsbzI5Q1ZIY3cxQnA5YSszYjJxd2lPZVlv?= =?utf-8?B?Nk84ZGo4VmdoQXh5L2lBSjJlbFErOTB0RXhFY3c4Z1lkd0pjMWdCWHBvNS9P?= =?utf-8?B?Ykg1TG1MeE52TGI5bjhVajVBZ3RNbGphVU5qZ3F0RnlBdHRUUVhnOEJOUWZh?= =?utf-8?B?UDBMT2g3Y0ltQ2JlNmEyTlFUTjZQbTVpM1FPK2F2TnNWVHVKOEQ1SFNVNS9S?= =?utf-8?B?TnV0YTVJcDE3WFlqVnA3MUo4OTFkcStEN3Rqd3BrbzJtaHZzRlhGSlg0a2g3?= =?utf-8?B?MXdUQ0V2NjVQcUMzbGJIblc0TjdyWFdZWnZGZ1h4dThodzVjVkREN2tHZ2ZR?= =?utf-8?B?RzV1dW1pcFhHL09RRTlEaFlaeWd4SVhuRlZBUytobU5vVjNvRHRmVmtnMkFw?= =?utf-8?B?aHdiS1p1MmtvMkQ0SE93ZFFaSm9wZ2x2SHlnR2pLN3Z5d09qWGdIaFRuMHZ6?= =?utf-8?B?RjFxU0M2SmMrMEhMaUNQNlc1TVJwRzFuRXd5MFd4ci9VME1KbXl4bjVjUDRX?= =?utf-8?B?cmltL3lHZHlOazR3d1lqZjhqVXRScWJTbENPdVQrMHVZdFJyTW40dXcyZlFF?= =?utf-8?B?VjhMRzh1VUpCMFJlbERwMmJFMWdUQ1dLSzlCdFdDTEJ3dXNXQXJLOWpUOXNn?= =?utf-8?B?elVtOGFFVVBWcE1EWFJVWTBKWmtoNHR5M2J0NzVpdy91bk1zN0VCcWszWnhO?= =?utf-8?B?bUtGdFNDMlp2cm1IOHhGMDZJODhKZWt0MGVBU2xYL0NvQnVpZjlKd0hJdzA2?= =?utf-8?B?dEFFKzFLdWorS0VxbFdTS0xYV1lueXBxamg1Q2FsYTR0OVI5enJKN1AwbHNj?= =?utf-8?B?R3JGM0xlU1JjS0NtMm9rTGVZQzJzUmRybXBVZDV1TkZpMlpRdTQ5cklnYktB?= =?utf-8?B?STBDQU84TURtbmNsek53L3hsZzhRVXNwdFhDall3YmFrWnVVWURZdWJZMjUr?= =?utf-8?B?ckIvSFVXeDNjWHdsWlBldzB0MFZ4UjZEc21seTlxY3dWYVBOazREMVBFL09D?= =?utf-8?B?bnc4M3Zrd0Z3K2JHaXVxVWxkU2hyZVBqMzA2N2w1OHY0U0QyMFhhb3VLbFVJ?= =?utf-8?B?OVZvWDV5a21ialdCeWFtbm5GOHRab2VMVjNKZkRONnJERmNwcjRZc0NqdTNL?= =?utf-8?B?VEdqT3FxVXQ0aHhjdlZNVHdWN2l5NVlwZFBQYVp2QnhldlcxbUswNGZQV1ZT?= =?utf-8?B?QktaRUYzR3RBZGJrRlViTHNkaktzSFM0b2ZmdTd2WG9NK3NNUVNBdWdoQU9I?= =?utf-8?B?UERyOGZZd2JiQWxhYXVBMHBKVmk0WWxObHdScWdrVjFPeXN2ZEZERUZBN09R?= =?utf-8?B?RWgrY2NPNlZFUzVFNWY4Rm1CbHBCL21FbC9rQTZrUXlCdk1XY1krSStGT29p?= =?utf-8?B?c0hlT293R1ZybW13K0h4UWY3cU1VVHV2ckJkekoyRU9NaTREb1VMOHMxd1pK?= =?utf-8?B?cWc0VDZUWWNpTDA1R0tiYWMvRE0zS2lSZ3FWQnlIZnRzMmxIVW1nYk5aeFN2?= =?utf-8?B?aDdoa1FtZVAzamdPVVkvMlk5ekNadDRXSTZwRE9ta25zVUFNUUY0Sm5pT0pt?= =?utf-8?B?RXVEcnZ2c24zdVRLRkMzWW5iZnlwZVZLQmVnTTFYZjlpdFh6UndqMzNjNmNu?= =?utf-8?B?QTBKdEFHV2JmWW5BSVR2OTB5Nm05N3NZQmZpSzZqL3FZSFN4ZTZ2ZTRYWEFM?= =?utf-8?B?aXlYWlhsdFUwMHdsb0VmZUdudUg5T3hCbm1uSk5ONTBCSmoxNFlrbHlYV2JD?= =?utf-8?B?RlJDWW0rV0Jjam1vb0txZ081NFU0TER2RHZiU2NvU3lsOE9wWDBEbDQ5VVJE?= =?utf-8?B?clExa2didmpVVXhibmhXWUlPRVNnQjQ1QWtVYmdZeHJ1SVA5Z2ZBS2JNOFZB?= =?utf-8?B?dW4yY09nTG9pMkxwR3pRVHFtQWkzNFhmQjR3T0tzTEw4b1pESy9PdEpnTG01?= =?utf-8?B?VnZMcThMeDF3SkpoS0VvY0ovUWlSL0dHS2pPMStsdTRacTQ1SDUvVk9TcXEz?= =?utf-8?Q?Vrl2W+MJe7fSXvaSHs/LP3h6G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1dd6d9-cc8a-42c4-63cf-08db9295ecf6 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:48:02.7441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6hlRarVgODUGUWZKV7oU+G62MWXqkv2CpTT8gZwBSHuw1LrZ6PN76n+DYGD72CSa6nSp4nCJm8PQejE8/ejz5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9228 On 01.08.2023 10:58, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The renames done by this patch avoid shadowing from happening. > They are as follows: > - s/socket_info/sock_info/ in 'do_write_psr_msrs' > > The parameter 'cpu_khz' that causes a violation in 'pit_init' > is unused, and hence can be removed. > > Parameter 'debug_stack_lines' in 'compat_show_guest_stack' is removed, > since the shadowed static variable has the same purpose. > > The declaration of 'init_e820' is renamed to be consistent with its > definition. > > Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich > This patch is the non-controversial part of patch 1/4 from series > https://lore.kernel.org/xen-devel/cover.1690788513.git.nicola.vetrini@bugseng.com/ > The other part has been dealt with with a patch from Jan Beulich > (not yet committed at the time of writing) > https://lore.kernel.org/xen-devel/e9035197-b329-af2e-65ed-af31cd0375c2@suse.com/ (Just) naming this v2 (or whichever version would have come next) would have been nice. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:50:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:50:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574228.899482 (Exim 4.92) (envelope-from ) id 1qQplc-0001HE-5g; Tue, 01 Aug 2023 13:50:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574228.899482; Tue, 01 Aug 2023 13:50:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQplc-0001H7-2Y; Tue, 01 Aug 2023 13:50:28 +0000 Received: by outflank-mailman (input) for mailman id 574228; Tue, 01 Aug 2023 13:50:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpla-0001H0-Oy for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:50:26 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20624.outbound.protection.outlook.com [2a01:111:f400:fe13::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5de01467-3072-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 15:50:25 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU0PR04MB9228.eurprd04.prod.outlook.com (2603:10a6:10:353::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 13:50:24 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 13:50:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5de01467-3072-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ckfpZ6uavn+QeeLKX72g41Fc4uEp3MkUfJkMbXyx81uzXWLOWVLUI868t0T5UWbsA8x0x/VIYlGxYh3kVK3qmkV61fUNcwF/DPnPP6TISR+sKp0cT4YonBjMryrcqrFUWb3MtyY74GP42Xk7mXpcO36pJd7/eZdSSs4FzRJQpf1aw2R8vVw5YuXoOz1g+mQJOndIs5/gJqWlkwaiFj7CJm1ySsW+vfxKvIdyrA0FIFcG8cEVYMQFgzeq5U3kruGQUaKQETlpm4hzEaA1t6nBQvoe1BoP01V/7T1jRffM/D28brQzMVxAhAgYgIw59eoS/cyiYLf3vxG/pYt8Pezeqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvPg3IhUWh1TBgh1T8s3jZPBueX+NMrRIifczvw5C3Y=; b=HImhE4ZK2rePLlOv0tzG9StXiggxTOtIPMJ54RLXICXNpeFG+3hvuILtW/faR5ej8XmDTSTiAYjZNiY4HE9b/7u0X3e3g43cclpxYr6tFda9bPOrayAj8D4Hu2S3SAN3z7tQiIEYL2H55zE2O0nad/DgTmhtm/SaPsSbWmMl43w3wlSxFPSTxTnKjvwamlmHvoMFyubo+svQ2UV/ETnq7QAhzXDUYgU8Kg8ehRE0gbazVMxTJxtz6eJ+HTMrrgUWQc9xzqP5oniyEcACxzDH3aHePcmgXcCInEOi6g+AXj1Aw4KL5gzHoONqrzweiMmjyUjoNNoqhGOIp2Y1TmG/Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvPg3IhUWh1TBgh1T8s3jZPBueX+NMrRIifczvw5C3Y=; b=1YA8vFk58or+Bpoal9kBa+pDsjnRnrdPcsxnrzgDvNejM0kB1vaaof5pV1xqIfatabUk8H5prADiz0kZsTBxsNNFSbR2uQ+tpw9yFM3HbnW3vlNfIELXDk4fPeb3OvD0hiHdrN4HCk9ieYGAgg0I93QpBM9mk3Ye0ZjQ+IMTq8FC9Se1ZLFeyPfKHdVOWBtPn51Dvh1ZnKOokeGAkBwOLufs9RdUQWrIh+ejTodh6OvqtsN3e+anXCFGPgEUgI56iWiX7BKKl51/oQiU0oOieP+mLJBmmjFWttywXbP6WhEc4bWH6i1FpYS6dWMSzboPBH9kivPXRqkznP/QOjBX1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4200c47e-6626-506c-1a17-991aef6e0be1@suse.com> Date: Tue, 1 Aug 2023 15:50:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH] xen/spinlock: address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <29b6a47a2711f065c02a3d2d94e1a201986cf015.1690882872.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <29b6a47a2711f065c02a3d2d94e1a201986cf015.1690882872.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU0PR04MB9228:EE_ X-MS-Office365-Filtering-Correlation-Id: 54246ce2-fe19-4e37-993a-08db92964136 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uq6EqldjzXoSmd4x7wmKsLqD/T4q8bzEhqKkCMlk0AkJjpdBSI+owHwCgGVSue+Ld0M6aIVL1nxWfJnrhEZQO3GtSTE5qiyky+zBUu6DM+dizcPYBevZRZ97uK1Dr/3uvCPQ1vRsn2p4BR1ooinezjl5YCPfdC7wQvw90WSIMo0srt4igxj3YQjsvCfq2Cjmq+qo9S3Kw6gd1mpsMVaV50hgjusLAvTFyS4CU1DIGuTPwQPLh1e9/BNx5uN+504bFkJC9i3TXqE6RcePdp/5q4JO7wicecJI0XXxgj8pW8U8vmkxd1px27VjndN65ag/MG2B7g6/+pvsTAiopOEVbETlLdFBY5ajPmcf8AVYvDa1XKExzhBkA/CCBpLe7fiLlD84+C8dXO2XX8tQFyT1jMgd/lipyN2SREwVPEpnzVgjgUTaqyBAUjflVS62OcbC3InVFmk+wmCJKava5kyJpfvj3Zu5P099JGxp6s558Fs8xlLCsNWEC+uEyk+StjKf4uZtBAkX3ZDcQyJvC2LBcX1VngMLJnSBVJSsVSht5ODfr6Uwyu/U6iEj8xcEkphLrsiR0/x9y3KfSc9qDGfasb/KiXIqknVn7mlzhq31vWFInlRuVP8MT8I4rrDW2waHO/2CFxR7f+3+vF71Lad+Xg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(376002)(366004)(346002)(451199021)(8936002)(8676002)(31686004)(36756003)(6486002)(41300700001)(478600001)(2616005)(2906002)(4744005)(26005)(83380400001)(316002)(31696002)(186003)(86362001)(6506007)(5660300002)(38100700002)(6512007)(54906003)(4326008)(53546011)(6916009)(66556008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW9ITytxS3gzS2svMzJlMXY2Z1VuMUxiaVVnbnI1akhZS2xJZzB2VWRwRVIr?= =?utf-8?B?S0VMOVVML2Z2d1ZhY2VrWFMzYW82MlZLSnIybmg0bEt4QU4waW5USS9vWE9s?= =?utf-8?B?V2hPbnU2VENXamxDdEgxclpWVzZMYWVaUDhDR2N5aEl3NHg0UnhJWkpGZFJR?= =?utf-8?B?ZUg5bDdqUnZtQ2VOZzYvSUtUSElsS1FZKzNaOTdCQW5BbUs3Q1JLTURrT1Av?= =?utf-8?B?V2NIU2pzY1c3Z3ZGaHY2elVjRndETTFEUGVBRmI4aVE5UFZoNitVVGo3T3I5?= =?utf-8?B?dnRWZklTWGM0UGgzdzk5a2NWVC9ISC8zbVBDeWhwOXE4eFZ1Y1hiR1QvNFI3?= =?utf-8?B?N2xpdmFFRkJHdk1OcGRqNjVGbHJpbEUvUHFLOWE2UUJRUnY0Y0ZNQmRVZXNa?= =?utf-8?B?OFRqb2c0UTRyVG9JS2VxVmk4R1QxdEU5STJwK3FleVNYWmVBaWJaMmQrcE5l?= =?utf-8?B?NEpKK1NkL2pxeEUyRzVQcmhpbkY4b0E2MDlQd0dxUnNTOGNBUDJqbkhvS29M?= =?utf-8?B?VWNodnhZRmw0TkJvOHBvQXV6eURWdXFoNVhpaDZZdnRBaGFQZ01Xc3c0ZTQ0?= =?utf-8?B?ZjEwc0pVZXJBSGgyczBqMDAxYWd4SmZDWTB5NjlPSmlNVDI3cmg4VzNQOVJo?= =?utf-8?B?OVcrMG16aU44ME96cDJ5L2xlZUhwS3VjMEFZSUkyOGlHNzZZdmFZSkNEdm1z?= =?utf-8?B?UTNzQ0NkeHVpZ25IVHRyanZpZHFyOTJrRTRneHlqM0p4TFJ6TE1GMitJbTd5?= =?utf-8?B?bStJNkU5MFNZRllPeG1kVUNyVUpYS1l4akF3dTZUYkxaaWtxbmVKWk9kQjFn?= =?utf-8?B?VVYwYXJqUlVpcjM4MENrYVNHWFZUZ25TNGpKVE5SbHhjNWlsWEZ1d1ltdlk2?= =?utf-8?B?SmhHd1dSV3crd0d1SFJVMlhpdVlkTG0yK3BUM29HdXRoampERi9Mc1pOQkV0?= =?utf-8?B?bFQzRnZWUVNYMURNVmJweXR1Qldzc29hMUhTTXdwakUzYWhFZWJTVDh0VFE0?= =?utf-8?B?MmtYZGoraXVSRHRSUWVoNDJEQ2YvR1BRaUNIcEpVZXNIbUVpdHN6WGJNWHIz?= =?utf-8?B?VnlMcFozREZkMzU0WjdOVmZoaE1LSUdreS84T1dha21ybnlmOGhuY2hhb3lx?= =?utf-8?B?RVEvMnF4QW9zb0JuNFNkVjRiWVoyZ0duVVNUU1ZBdG9JOFNScDcvTElPanFz?= =?utf-8?B?V21rQVEzaDE2K2ZWSE5DMEV5RGxsZ0lGZjY3VHhkaWVBa05jVnlxSlQwaVVN?= =?utf-8?B?OCtGTVNNdWdHbmdIV2JOYnZYaEpFY1lzUnUveWtXYXpKNXdJUTE2a2NMQkE5?= =?utf-8?B?TkZROUxpeXFaUzBQWXJDRGk3eVgvQlBsUGZMRGpDd05uSWMzVHpPRXphekhC?= =?utf-8?B?NGhNWVhIZHRZcnRCcy9VSElwY3VNbmg5VkVBdzRPckQ2TUZVOWFnQjN4bEFC?= =?utf-8?B?cG0yNjJhcGsxNnZGZElHa2ppWVBrTWIza1BLOFE4TDdvQlNvUG1ZR1EvR3hr?= =?utf-8?B?bzRYTDF4ckJMajE2ZXBDc0xudVkyOHA0UFNZTVZmT3Fndm9PK09ZaE0xWTkx?= =?utf-8?B?ZitSUHFhMG00Nkl4MXJEQUovWmJOb0x3KzYzOFhnQTZCUkttMTl6QjFMZUZM?= =?utf-8?B?WG81MnB3ZmdRNXllK2JJS3NhMytlQmlheUNXQ3lTbk5tVnRwT1RncW1nQ1J6?= =?utf-8?B?cUxxcERmT3RsVmYzakNqQ0lqc0xhaFg1ajhhN1Y3RlhjZUtYT2VzblE2TXE2?= =?utf-8?B?NzFUQkVRbWt5aDNDdWFjZThGbng5eVdCS29tUFVsMjR0V1h0MU40R1JneVRn?= =?utf-8?B?UVVGOGVKTWlOZURxakliK0dRdjFFNENieHRubnFuTDhhcE5YaWZBTFhtUnEy?= =?utf-8?B?cUN0amk4N2R3VSt1MEhiNndYRStXK0gvZ2UxejJlRytXbmxVWnVxYjd1aGoy?= =?utf-8?B?V216c2JWUDU3SGcvSXdOdkpGcWRUaWhKUXR4RmZVQXp2ZjlVOXRBQkhxUy8r?= =?utf-8?B?d1N5MERxUVJoZEVhbE0zWDJjS21QZXZPanZSeG1yS21kSnBIb0ZGMEN1M1o1?= =?utf-8?B?S2N4eWI4TDJBcUhMc2IzUjNJUzF6K2Q4VmUrQk9yc1czWE4reUR5OEFoNUF0?= =?utf-8?Q?/k+Ld8f18cYFLEQEmcgKYRMo0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54246ce2-fe19-4e37-993a-08db92964136 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 13:50:24.1017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Lr415+olxs8K/OCGyTSdGqVIkqnBOXOS7EOzzfYgHOSCZ9r4rYopz0cqpFsLHzbitJnoCYK5ZLEnajpZDY/0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9228 On 01.08.2023 11:46, Federico Serafini wrote: > --- a/xen/include/xen/spinlock.h > +++ b/xen/include/xen/spinlock.h > @@ -125,8 +125,9 @@ struct lock_profile_qhead { > } while(0) > > void _lock_profile_register_struct( > - int32_t, struct lock_profile_qhead *, int32_t); > -void _lock_profile_deregister_struct(int32_t, struct lock_profile_qhead *); > + int32_t type, struct lock_profile_qhead *qhead, int32_t idx); > +void _lock_profile_deregister_struct(int32_t type, > + struct lock_profile_qhead *qhead); In adjacent declaration it would be nice if the same line wrapping style was used. Can surely be taken care of while committing. With the adjustment: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:50:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:50:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574230.899492 (Exim 4.92) (envelope-from ) id 1qQplp-0001aJ-E8; Tue, 01 Aug 2023 13:50:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574230.899492; Tue, 01 Aug 2023 13:50:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQplp-0001a9-BB; Tue, 01 Aug 2023 13:50:41 +0000 Received: by outflank-mailman (input) for mailman id 574230; Tue, 01 Aug 2023 13:50:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpln-0001H0-Pf for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:50:39 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65bcb690-3072-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 15:50:38 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 58C894EE0737; Tue, 1 Aug 2023 15:50:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65bcb690-3072-11ee-b25c-6b7b168915f2 MIME-Version: 1.0 Date: Tue, 01 Aug 2023 15:50:38 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_P?= =?UTF-8?Q?au_Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 In-Reply-To: References: <9ec42e01258968d2dc71d59c5ad41da448a7112e.1690895099.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <3f9c68649fa1e5ca4151a46a110a8b8c@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 01/08/2023 15:40, Jan Beulich wrote: > On 01.08.2023 15:06, Nicola Vetrini wrote: >> The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the >> struct declaration to have no named members, hence violating >> Rule 1.3: >> "There shall be no occurrence of undefined or critical unspecified >> behaviour" >> because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: >> "If the struct-declaration-list contains no named >> members, the behavior is undefined." >> >> It has been assessed that the feature set declaration is intentionally >> empty, >> and that no risk of undesired behaviour stems from it, hence the >> struct >> declaration is marked safe. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> As agreed during the MISRA C group meetings, this violation is dealt >> with by means of a comment deviation, as future changes may eliminate >> the >> root cause, which is the empty feature set. >> My justification for the claim and the commit message may need some >> adjusting. > > A reference to the compiler extension would be nice; the use of > extensions > (which generally are well-defined, even if not always well-documented) > should eliminate the UB that the standard specifies. > It sure is a good idea to specify this. Since the use of this compiler extension is already documented in 'docs/misra/C-language-toolchain.rst' I can just add a reference to that in the justification. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 01 13:58:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 13:58:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574239.899502 (Exim 4.92) (envelope-from ) id 1qQptO-0002VJ-5T; Tue, 01 Aug 2023 13:58:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574239.899502; Tue, 01 Aug 2023 13:58:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQptO-0002VC-2q; Tue, 01 Aug 2023 13:58:30 +0000 Received: by outflank-mailman (input) for mailman id 574239; Tue, 01 Aug 2023 13:58:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQptM-0002V6-Jr for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 13:58:29 +0000 Received: from mgamail.intel.com (unknown [192.55.52.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a14cbe0-3073-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 15:58:24 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 06:57:59 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 01 Aug 2023 06:57:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQpsm-005MX9-2k; Tue, 01 Aug 2023 16:57:52 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a14cbe0-3073-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690898304; x=1722434304; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZKIy+hH5QB+KBuMy5Vbg4Dhcb8h2GptMzqQNMbJ5fGU=; b=cxaJWq2SuAMDVIwUPtisnAfJnEyWqk6PJGyJI7FgFXdOrOa/uErM27Hp +NqPQWx+qiE16jc8bAHywSdJl0GXb/w4WSMzRTvGpnGs/T3WlG6rHkFBD sFtZ4AYuN7ABb0kUTSZLaT0GEOrd8R1fNlI1H47G0iA3lfYP3d1qzWlty gnrePRbXgjJCMKwY2sjjwnnuGMAOUU2xwxI2J08U1/lQ1ySYI2Xa/Rts6 NXojIWQYEwtMHbbLHK46XLgCNipCYBKU0hninmLw+4GsO/CLvK+2cIn9D 7lTXDgolHMkUHPbHqB52/LivRnwAgPNDIdOQso51DWr49IEP0IC/+I1eK A==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="400250896" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="400250896" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="763772313" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="763772313" Date: Tue, 1 Aug 2023 16:57:52 +0300 From: Andy Shevchenko To: Takashi Iwai Cc: Mark Brown , alsa-devel@alsa-project.org, Andrey Utkin , Anton Sviridenko , Arnaud Pouliquen , Banajit Goswami , Bluecherry Maintainers , Claudiu Beznea , Ismael Luceno , Lars-Peter Clausen , Mauro Carvalho Chehab , Oleksandr Andrushchenko , Olivier Moysan , Srinivas Kandagatla , linux-media@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Message-ID: References: <20230731154718.31048-1-tiwai@suse.de> <87h6pjj2ui.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h6pjj2ui.wl-tiwai@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > On Mon, 31 Jul 2023 19:20:54 +0200, > Mark Brown wrote: > > > > On Mon, Jul 31, 2023 at 05:46:54PM +0200, Takashi Iwai wrote: > > > > > this is a patch set to clean up the PCM copy ops using sockptr_t as a > > > "universal" pointer, inspired by the recent patch from Andy > > > Shevchenko: > > > https://lore.kernel.org/r/20230721100146.67293-1-andriy.shevchenko@linux.intel.com > > > > > Even though it sounds a bit weird, sockptr_t is a generic type that is > > > used already in wide ranges, and it can fit our purpose, too. With > > > sockptr_t, the former split of copy_user and copy_kernel PCM ops can > > > be unified again gracefully. > > > > It really feels like we ought to rename, or add an alias for, the type > > if we're going to start using it more widely - it's not helping to make > > the code clearer. > > That was my very first impression, too, but I changed my mind after > seeing the already used code. An alias might work, either typedef or > define genptr_t or such as sockptr_t. But we'll need to copy the > bunch of helper functions, too... Maybe we should define a genptr_t (in genptr.h) and convert sockptr infra to use it (in sockptr.h)? This will leave network and other existing users to convert to it step-by-step. Another approach is to simply copy sockptr.h to genptr.h with changed naming scheme and add a deprecation note to the former. Thank you, Takashi, for doing this! -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:04:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:04:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574244.899512 (Exim 4.92) (envelope-from ) id 1qQpzS-00044o-VV; Tue, 01 Aug 2023 14:04:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574244.899512; Tue, 01 Aug 2023 14:04:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpzS-00044h-SZ; Tue, 01 Aug 2023 14:04:46 +0000 Received: by outflank-mailman (input) for mailman id 574244; Tue, 01 Aug 2023 14:04:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQpzR-00044b-HR for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:04:45 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5cefeb77-3074-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 16:04:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 47857615B4; Tue, 1 Aug 2023 14:04:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB7D0C433C7; Tue, 1 Aug 2023 14:04:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cefeb77-3074-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690898681; bh=lI3n00luUKNfopH9HotLexiOPOuMEZpaKLOmB06ooZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OEIpwVYkDq+meyS+F0NrjUec5s/e0v8SK2Iox7Y/zdkxJGa9HYCY+Qqv7P4WEfWkA kAoMlWAh+2te7rC1NLxY/R2kSiuXFh8wAvmYJibLgpADDbLlPyB16g5LTBMwjlEn1a G7PJjbM8fcOMRLDsi16jWNwGtrtbOMeTtKdLWHh8mu10k+SjrM2XtaV5pAZ4wWEZs7 c9odn6bRGk8znCKs/8LH6xAP+wHnp1AXA5K2jOPPBq43w9OqfSl9oJB/cc8ZMmTL21 1GOld3yySZ0K5npTLbN0VCfgXuNIqRPpImE/uS3azcZEP9z1QH5rL1s+UctXocUCsK NCSFJqIkD2kfQ== Date: Tue, 1 Aug 2023 15:04:34 +0100 From: Mark Brown To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Andy Shevchenko , Andrey Utkin , Anton Sviridenko , Arnaud Pouliquen , Banajit Goswami , Bluecherry Maintainers , Claudiu Beznea , Ismael Luceno , Lars-Peter Clausen , Mauro Carvalho Chehab , Oleksandr Andrushchenko , Olivier Moysan , Srinivas Kandagatla , linux-media@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Message-ID: References: <20230731154718.31048-1-tiwai@suse.de> <87h6pjj2ui.wl-tiwai@suse.de> <87leeugbxm.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VsD3ApJSux4lzU26" Content-Disposition: inline In-Reply-To: <87leeugbxm.wl-tiwai@suse.de> X-Cookie: I thought YOU silenced the guard! --VsD3ApJSux4lzU26 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: > That's true. The question is how more widely it'll be used, then. Indeed. > Is something like below what you had in mind, too? Yes, or Andy's suggestion of just copying without trying to put a redirect in works for me too. I imagine there might be some bikeshedding of the name, your proposal seems fine to me. --VsD3ApJSux4lzU26 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTJEPIACgkQJNaLcl1U h9A8iAf/VmHGSowoYOko6J42O7KZJk6ZjskuMxi0WOqbX1goKvceOkJwETo8Cfzm MrLOBWuTXcN5avbnlMHgH9HUEXcDXBFq+IUj/thURpKG+qdVrdqIwhKMzUcobR5T DwqVPa45MfFzLxWBZwtl1nYXit0CAgTpar2lRq9GCWfHv3dwMGLNmvI67USOGHN0 3F8lmVRbVBzlZwOU+CTq+VBey5YGevoARVwdbbjdCnZwGYFWsO8OSRX+L207+mGa LUEf7DHkkhqnQn8YNjYJmQD9al7Yp1DWBPA9P33bVWXXD22WlsbTDX5ofbJUOVrx roVhdFa8eRp+iqemnmwT0/1rr0LHoA== =qtD0 -----END PGP SIGNATURE----- --VsD3ApJSux4lzU26-- From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:31:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574252.899542 (Exim 4.92) (envelope-from ) id 1qQqOx-000802-EF; Tue, 01 Aug 2023 14:31:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574252.899542; Tue, 01 Aug 2023 14:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqOx-0007zv-Aq; Tue, 01 Aug 2023 14:31:07 +0000 Received: by outflank-mailman (input) for mailman id 574252; Tue, 01 Aug 2023 14:31:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqOw-0007Uu-De for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:31:06 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0ba77181-3078-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:31:04 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4fe44955decso994707e87.1 for ; Tue, 01 Aug 2023 07:31:04 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id q28-20020ac24a7c000000b004fbac025223sm2568051lfp.22.2023.08.01.07.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 07:31:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ba77181-3078-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690900264; x=1691505064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z2wBe/2TT0oHArlSRwcilGBSfEqeRZv1FMy3mGku8To=; b=AU76X6HrvfCwR7orXC8F9s4jnlr6u2luF1+/ASp8aivUV2X7rvkYzmArwUonerDH48 x03LklVGcIPHaCZ8R3J5x8NFxVCuZXpQFdu4+1z7HcT2qIorFTzgldS5TcYJt9b84BFH EDwvQAniErVgCPQO1Dmmpbc6a5DSQMrqUy/BhNUgwGRR1m5hXYvLNRKtlFwp1+djgZZO u9pOQJKcJx1ldyzW1iR6UmC9Xy1G5EAsE4KPX5p1cYchjDpR1pi4cv+32FvTdGTXtXff ZTP5mICQTU02F/obFhdZIoeNejBeePnHEizQuc043Bed8vl80tFFnoU8HfsK0cdiV6fD tMXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690900264; x=1691505064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2wBe/2TT0oHArlSRwcilGBSfEqeRZv1FMy3mGku8To=; b=RhvhpYq8CnmQSIunDQ3JHk8d/oh8+yRIMxM5X+uYODLSPL1pva6/H4wfLjnRSzzW7o COIYrmCaX+08j5E6ahiORl5Mzoq5632TFsa+4J60l4LATE1ddaPRqvXgSz4C15vSlqDm yTSfg+nNcfBUlEC4bflMtvZQ9GK7qzj9jiADpjY+xa27pYDpAyvLUF6bP1vT0feXXt9w hbZqrUnZ1I2WI9x0VtUNDLslQtde2vBAbpLdqMC/uYrjy9Fs7+5Agr4EDA/+7pZ/BDiT JEKPaEOdlIiD3+Og7tcrJlRZ18jFjpZdBbQPq4fduM+/Cx+6+G8yy8902NLhS3FTdPZH 26VA== X-Gm-Message-State: ABy/qLY2d8kO0HeWAatAwEsv/g+d/K8gApmO9LovJ01j53kd7ji5Zixu 7bT84UYkZ9T9DEEO/j1lLIvC37mE2do= X-Google-Smtp-Source: APBJJlF9w5TFyHopitQl6vnQPeRhznG3phXV1OJZ1E0AsSUez1+ydMX4mmjoc6wqpyYBPFddAahfJw== X-Received: by 2002:a19:6707:0:b0:4fb:8ff3:1f74 with SMTP id b7-20020a196707000000b004fb8ff31f74mr1033067lfc.20.1690900263593; Tue, 01 Aug 2023 07:31:03 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 2/2] xen/riscv: introduce identity mapping Date: Tue, 1 Aug 2023 17:30:50 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The way how switch to virtual address was implemented in the commit e66003e7be ("xen/riscv: introduce setup_initial_pages") isn't safe enough as: * enable_mmu() depends on hooking all exceptions and pagefault. * Any exception other than pagefault, or not taking a pagefault causes it to malfunction, which means you will fail to boot depending on where Xen was loaded into memory. Instead of the proposed way of switching to virtual addresses was decided to use identity mapping for area which constains needed code to switch from identity mapping and after switching to virtual addresses, identity mapping is removed from page-tables in the following way: search for top-most page table entry and remove it. Fixes: e66003e7be ("xen/riscv: introduce setup_initial_pages") Signed-off-by: Oleksii Kurochko Suggested-by: Andrew Cooper --- Changes in V6: - t2 register was renamed to t1 as t1 isn't used anymore in turn_on_mmu(). - fold li, sll instructions to slli. - use a0 directly to calculate an argument of turn_on_mmu() instead of t0. --- Changes in V5: - update the algo of identity mapping removing. - introduce IDENT_AREA_SIZE. - introduce turn_on_mmu() function to enable and switch from 1:1 mapping. - fix typo in PGTBL_INITIAL_COUNT define. - update the comment above PGTBL_INITIAL_COUNT. - update the commit message. --- Changes in V4: - remove definition of ARRAY_SIZE and ROUNDUP as was introduced where these macros are located now. - update definition of PGTBL_INITIAL_COUNT - update the commit message - update the algo of identity mapping removing --- Changes in V3: - remove unrelated to the patch changes ( SPDX tags in config.h ). - update definition of PGTBL_INITIAL_COUNT taking into account identity mapping. - refactor remove_identity_mapping() function. - add explanatory comments in xen.lds.S and mm.c. - update commit message. - move save/restore of a0/a1 registers to [PATCH v2 2/3] xen/riscv: introduce function for physical offset calculation. --- Changes in V2: - update definition of PGTBL_INITIAL_COUNT and the comment above. - code style fixes. - 1:1 mapping for entire Xen. - remove id_addrs array becase entire Xen is mapped. - reverse condition for cycle inside remove_identity_mapping(). - fix page table walk in remove_identity_mapping(). - update the commit message. - add Suggested-by: Andrew Cooper - save hart_id and dtb_addr before call MMU related C functions. - use phys_offset variable instead of doing calcultations to get phys offset in head.S file. ( it can be easily done as entire Xen is 1:1 mapped ) - declare enable_muu() as __init. --- xen/arch/riscv/include/asm/config.h | 2 + xen/arch/riscv/include/asm/mm.h | 5 +- xen/arch/riscv/mm.c | 90 +++++++++++++++-------------- xen/arch/riscv/riscv64/head.S | 30 ++++++++++ xen/arch/riscv/setup.c | 14 +---- xen/arch/riscv/xen.lds.S | 11 ++++ 6 files changed, 97 insertions(+), 55 deletions(-) diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index fa90ae0898..f0544c6a20 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -95,6 +95,8 @@ #define RV_STAGE1_MODE SATP_MODE_SV32 #endif +#define IDENT_AREA_SIZE 64 + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h index 7b94cbadd7..07c7a0abba 100644 --- a/xen/arch/riscv/include/asm/mm.h +++ b/xen/arch/riscv/include/asm/mm.h @@ -13,8 +13,11 @@ extern unsigned char cpu0_boot_stack[]; void setup_initial_pagetables(void); void enable_mmu(void); -void cont_after_mmu_is_enabled(void); + +void remove_identity_mapping(void); unsigned long calc_phys_offset(void); +void turn_on_mmu(unsigned long ra); + #endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index a73f135a3c..053f043a3d 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include @@ -35,8 +36,11 @@ static unsigned long __ro_after_init phys_offset; * * It might be needed one more page table in case when Xen load address * isn't 2 MB aligned. + * + * CONFIG_PAGING_LEVELS page tables are needed for the identity mapping, + * except that the root page table is shared with the initial mapping */ -#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) + 1) +#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) * 2 + 1) pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) stage1_pgtbl_root[PAGETABLE_ENTRIES]; @@ -75,6 +79,7 @@ static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, unsigned int index; pte_t *pgtbl; unsigned long page_addr; + bool is_identity_mapping = map_start == pa_start; if ( (unsigned long)_start % XEN_PT_LEVEL_SIZE(0) ) { @@ -108,16 +113,18 @@ static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, { unsigned long paddr = (page_addr - map_start) + pa_start; unsigned int permissions = PTE_LEAF_DEFAULT; + unsigned long addr = is_identity_mapping + ? page_addr : LINK_TO_LOAD(page_addr); pte_t pte_to_be_written; index = pt_index(0, page_addr); - if ( is_kernel_text(LINK_TO_LOAD(page_addr)) || - is_kernel_inittext(LINK_TO_LOAD(page_addr)) ) - permissions = - PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; + if ( is_kernel_text(addr) || + is_kernel_inittext(addr) ) + permissions = + PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; - if ( is_kernel_rodata(LINK_TO_LOAD(page_addr)) ) + if ( is_kernel_rodata(addr) ) permissions = PTE_READABLE | PTE_VALID; pte_to_be_written = paddr_to_pte(paddr, permissions); @@ -211,6 +218,13 @@ void __init setup_initial_pagetables(void) unsigned long linker_start = LOAD_TO_LINK(load_start); unsigned long linker_end = LOAD_TO_LINK(load_end); + unsigned long ident_start; + unsigned long ident_end; + + /* + * If the overlapping check will be removed then remove_identity_mapping() + * logic should be updated. + */ if ( (linker_start != load_start) && (linker_start <= load_end) && (load_start <= linker_end) ) { @@ -232,48 +246,40 @@ void __init setup_initial_pagetables(void) linker_start, linker_end, load_start); + + if ( linker_start == load_start ) + return; + + ident_start = (unsigned long)turn_on_mmu & XEN_PT_LEVEL_MAP_MASK(0); + ident_end = ident_start + PAGE_SIZE; + + setup_initial_mapping(&mmu_desc, + ident_start, + ident_end, + ident_start); } -void __init noreturn noinline enable_mmu() +void __init remove_identity_mapping(void) { - /* - * Calculate a linker time address of the mmu_is_enabled - * label and update CSR_STVEC with it. - * MMU is configured in a way where linker addresses are mapped - * on load addresses so in a case when linker addresses are not equal - * to load addresses, after MMU is enabled, it will cause - * an exception and jump to linker time addresses. - * Otherwise if load addresses are equal to linker addresses the code - * after mmu_is_enabled label will be executed without exception. - */ - csr_write(CSR_STVEC, LOAD_TO_LINK((unsigned long)&&mmu_is_enabled)); - - /* Ensure page table writes precede loading the SATP */ - sfence_vma(); + unsigned int i; + pte_t *pgtbl; + unsigned int index, xen_index; + unsigned long ident_start = + LINK_TO_LOAD(turn_on_mmu) & XEN_PT_LEVEL_MAP_MASK(0); - /* Enable the MMU and load the new pagetable for Xen */ - csr_write(CSR_SATP, - PFN_DOWN((unsigned long)stage1_pgtbl_root) | - RV_STAGE1_MODE << SATP_MODE_SHIFT); + for ( pgtbl = stage1_pgtbl_root, i = CONFIG_PAGING_LEVELS; i; i-- ) + { + index = pt_index(i - 1, ident_start); + xen_index = pt_index(i - 1, XEN_VIRT_START); - asm volatile ( ".p2align 2" ); - mmu_is_enabled: - /* - * Stack should be re-inited as: - * 1. Right now an address of the stack is relative to load time - * addresses what will cause an issue in case of load start address - * isn't equal to linker start address. - * 2. Addresses in stack are all load time relative which can be an - * issue in case when load start address isn't equal to linker - * start address. - * - * We can't return to the caller because the stack was reseted - * and it may have stash some variable on the stack. - * Jump to a brand new function as the stack was reseted - */ + if ( index != xen_index ) + { + pgtbl[index].pte = 0; + break; + } - switch_stack_and_jump((unsigned long)cpu0_boot_stack + STACK_SIZE, - cont_after_mmu_is_enabled); + pgtbl = (pte_t *)LOAD_TO_LINK(pte_to_paddr(pgtbl[index])); + } } /* diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index ae194bb099..cb8888a572 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -39,6 +39,22 @@ ENTRY(start) jal calc_phys_offset mv s2, a0 + jal setup_initial_pagetables + + /* Calculate proper VA after jump from 1:1 mapping */ + la a0, .L_primary_switched + sub a0, a0, s2 + + jal turn_on_mmu + +.L_primary_switched: + /* + * cpu0_boot_stack address is 1:1 mapping related so it should be + * recalculated after jump from 1:1 mapping world as 1:1 mapping + * will be removed soon in start_xen(). + */ + jal reset_stack + /* restore hart_id ( bootcpu_id ) and dtb address */ mv a0, s0 mv a1, s1 @@ -54,3 +70,17 @@ ENTRY(reset_stack) ret + .section .text.ident, "ax", %progbits + +ENTRY(turn_on_mmu) + sfence.vma + + li t0, RV_STAGE1_MODE + slli t0, t0, SATP_MODE_SHIFT + + la t1, stage1_pgtbl_root + srl t1, t1, PAGE_SHIFT + or t1, t1, t0 + csrw CSR_SATP, t1 + + jr a0 diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index dde8fb898b..6593f601c1 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -13,20 +13,10 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] void __init noreturn start_xen(unsigned long bootcpu_id, paddr_t dtb_addr) { - early_printk("Hello from C env\n"); - - setup_initial_pagetables(); - - enable_mmu(); - - for ( ;; ) - asm volatile ("wfi"); + remove_identity_mapping(); - unreachable(); -} + early_printk("Hello from C env\n"); -void __init noreturn cont_after_mmu_is_enabled(void) -{ early_printk("All set up\n"); for ( ;; ) diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 9064852173..3fa7db3bf9 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -31,6 +31,11 @@ SECTIONS *(.text.*) #endif + . = ALIGN(IDENT_AREA_SIZE); + _ident_start = .; + *(.text.ident) + _ident_end = .; + *(.fixup) *(.gnu.warning) . = ALIGN(POINTER_ALIGN); @@ -173,4 +178,10 @@ ASSERT(IS_ALIGNED(__bss_end, POINTER_ALIGN), "__bss_end is misaligned") ASSERT(!SIZEOF(.got), ".got non-empty") ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") +/* + * Changing the size of Xen binary can require an update of + * PGTBL_INITIAL_COUNT. + */ ASSERT(_end - _start <= MB(2), "Xen too large for early-boot assumptions") + +ASSERT(_ident_end - _ident_start <= IDENT_AREA_SIZE, "identity region is too big"); -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:31:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574250.899521 (Exim 4.92) (envelope-from ) id 1qQqOs-0007V7-UE; Tue, 01 Aug 2023 14:31:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574250.899521; Tue, 01 Aug 2023 14:31:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqOs-0007V0-Rb; Tue, 01 Aug 2023 14:31:02 +0000 Received: by outflank-mailman (input) for mailman id 574250; Tue, 01 Aug 2023 14:31:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqOr-0007Uu-Ry for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:31:01 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08a5b33a-3078-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:30:59 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe27849e6aso5058654e87.1 for ; Tue, 01 Aug 2023 07:30:59 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id q28-20020ac24a7c000000b004fbac025223sm2568051lfp.22.2023.08.01.07.30.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 07:30:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08a5b33a-3078-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690900259; x=1691505059; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DphTfRycXy0USz4kNo5pnBYhh0AwrgYUK+qSbwAz5Wo=; b=dPokXKpRWLy+t7BlH3OfFOZXgq1LwTRBcXqicB6tWiHtEJm/3L6bv4IccL0pH1eO0x b7i6pH9cIxjSb3YukDP6XYbHWDYBHQs/cmTcJ8UvWsGOvxO24VX19dmnMHDMpTSXfCZU Mj7qrjGhPWTMbstW84c1T5hAjtAYF0/YrZcC97Fye+JiRO12LmSlzlP2vaiO/ec3SYtC FxBknJlr/NmF7vp6XRV8NExesbrX5sOeQseseEK3d4x2VTSjO4nQh2c0BPFZTnNqEtka 68faSd3oKOQfwdCXxpIvaUo5t2ST6HkhGU1/jSNAijLa1MOFhHov6RXLgGUhG9LZnIj3 vF9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690900259; x=1691505059; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DphTfRycXy0USz4kNo5pnBYhh0AwrgYUK+qSbwAz5Wo=; b=ZYrfO7aBTJRQyI0QaK3d+XJ3EbnMe6d/QRcRkVqHnVY/kr9r2R6SGa/DzDGl+K9qvB itoWcAGsRYiP8H32uoC8pObueV1C6jPxXNykpqN6kny7oO+JOFneA3mf180FZF8OdDjk kvuo3RFRarXh9+G3EGJZDm7WZPbXf1iyq05XdCMmvhna2S4dOoeAKpiCi9/rkOZ29Nc+ Gtlux+rP7le6vbguyKC/6OyspMZOty/+XdYoMhg4Dis9FsB47K2059+C3qi2uIR9MNQn VCoFya2ZLnjgkwkGUOmvvbr3RFBavSoMvq4nf+r3oYqbPC9pizGfSwc0mqyf8nUhYm+I WHHQ== X-Gm-Message-State: ABy/qLZrRWfKPrxlPUdVWETjPZee8OcAkvGbqsJq4DFRhsrWrWov0q8N 1sKzVCInR56+X0BgNLwwEh3aVLtN3vk= X-Google-Smtp-Source: APBJJlE7LbUx9Yu5LJbLc0bJ3jJKrRbps3MEvTpQJ5vfGEUwaOxXCE0oHmc0cvm3DC7M3Zg1sXIOlA== X-Received: by 2002:a19:9119:0:b0:4fe:3364:6c20 with SMTP id t25-20020a199119000000b004fe33646c20mr2033117lfd.16.1690900258405; Tue, 01 Aug 2023 07:30:58 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 0/2] xen/riscv: introduce identity mapping Date: Tue, 1 Aug 2023 17:30:48 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces things necessary to implement identity mapping: 1. Make identity mapping for the entire Xen. 2. Enable MMU. 3. Jump to the virtual address world 4. Remove identity mapping. Also current patch series introduces the calculation of physical offset before MMU is enabled as access to physical offset will be calculated wrong after MMU will be enabled because access to phys_off variable is PC-relative and in the case when linker address != load address, it will cause MMU fault. The reason for this patch series can be found here: https://lore.kernel.org/xen-devel/4e336121-fc0c-b007-bf7b-430352563d55@citrix.com/ --- Changes in V6: - Update calc_phys_offset() after rebase. - Refactor turn_on_mmu() and a way how an argument of turn_on_mmu() is calculated. --- Changes in V5: - update the algo of identity mapping removing. - introduce IDENT_AREA_SIZE. - introduce turn_on_mmu() function to enable and switch from 1:1 mapping. - fix typo in PGTBL_INITIAL_COUNT define. - update the comment above PGTBL_INITIAL_COUNT. - update prototype of calc_phys_offset(). now it returns phys_offset. - declare phys_offset as static. - save returned value of calc_phys_offset to register s2. --- Changes in V4: - drop patch [PATCH v3 1/3] xen/riscv: add SPDX tag to config.h as it was merged to staging - remove definition of ARRAY_SIZE and ROUNDUP as was introduced where these macros are located now. - update definition of PGTBL_INITIAL_COUNT - update the commit message for patch 'xen/riscv: introduce identity mapping' - update the comments in head.S - update the algo of identity mapping removing --- Changes in V3: - Update the patch series message. - The following patches were merged to staging so droped from the patch series: * xen/riscv: add .sbss section to .bss * xen/riscv: introduce reset_stack() function * xen/riscv: move extern of cpu0_boot_stack to header * xen/riscv: add SPDX tags - move save/restore of a0/a1 registers from patch 4 to patch 2 ( numbers are from the previous patch series version ) - add SPDX tag in config.h - update definition of PGTBL_INITIAL_COUNT taking into account identity mapping. - refactor remove_identity_mapping() function. - add explanatory comments in xen.lds.S and mm.c. --- Changes in V2: - update the patch series message. - drop patches from the previous version of the patch series: * xen/riscv: add __ASSEMBLY__ guards". ( merged ) * xen/riscv: make sure that identity mapping isn't bigger then page size ( entire Xen is 1:1 mapped so there is no need for the checks from the patch ) - add .sbss.* and put it befor .bss* . - move out reset_stack() to .text section. - add '__ro_after_init' for phys_offset variable. - add '__init' for calc_phys_offset(). - declaring variable phys_off as non static as it will be used in head.S. - update definition of PGTBL_INITIAL_COUNT and the comment above. - code style fixes. - remove id_addrs array becase entire Xen is mapped. - reverse condition for cycle inside remove_identity_mapping(). - fix page table walk in remove_identity_mapping(). - save hart_id and dtb_addr before call MMU related C functions - use phys_offset variable instead of doing calcultations to get phys offset in head.S file. ( it can be easily done as entire Xen is 1:1 mapped now ) - declare enable_muu() as __init. - Update SPDX tags. - Add Review-By/Suggested-By for some patches. - code style fixes. Oleksii Kurochko (2): xen/riscv: introduce function for physical offset calculation xen/riscv: introduce identity mapping xen/arch/riscv/include/asm/config.h | 2 + xen/arch/riscv/include/asm/mm.h | 7 +- xen/arch/riscv/mm.c | 109 +++++++++++++++++----------- xen/arch/riscv/riscv64/head.S | 44 +++++++++++ xen/arch/riscv/setup.c | 14 +--- xen/arch/riscv/xen.lds.S | 11 +++ 6 files changed, 130 insertions(+), 57 deletions(-) -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:31:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574251.899531 (Exim 4.92) (envelope-from ) id 1qQqOu-0007ju-5k; Tue, 01 Aug 2023 14:31:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574251.899531; Tue, 01 Aug 2023 14:31:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqOu-0007jn-2r; Tue, 01 Aug 2023 14:31:04 +0000 Received: by outflank-mailman (input) for mailman id 574251; Tue, 01 Aug 2023 14:31:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqOt-0007Uu-3I for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:31:03 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09c80964-3078-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:31:01 +0200 (CEST) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4fe383c1a26so3449395e87.1 for ; Tue, 01 Aug 2023 07:31:01 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id q28-20020ac24a7c000000b004fbac025223sm2568051lfp.22.2023.08.01.07.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 07:30:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09c80964-3078-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690900261; x=1691505061; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LUja0JE13agYREw0RGgZhxeHvXKg+830hNOPqDqfhTY=; b=lge5p9xcmTfGaaGQ9e+A3K37zgrGb+t6wHM2SMcJH9QbU4IA5XlRRCfPTnAIsvW4mF JgpW7dHuhDQxD2c/cIDllrqrAhUl7w7vQ53pNxm6Ljjnd8LivKvPyVpQGEgKzuhydLb6 7oPX3ubeKxz0paEonowdWqHxFImRnmWOOzbev1ltDVEUNiYbreclfHvj5WmtNePeRFcK tmb8DVWDkNei1woNbJdydIIbbIgfP5xiN90IPlBS/XeXyL5KoivLQpg5Lm4j0H0xUb+J LaqSxQExSFgnJ+RQtk2GMwLIXOL4P0x8iA/s6WV6t3Vr/KXfFl0qkTrCqojNY3yqW/9j f3iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690900261; x=1691505061; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LUja0JE13agYREw0RGgZhxeHvXKg+830hNOPqDqfhTY=; b=ceyuystbpNTg2pfJ0dSvZbDJrGGpOiUJ4+iIm9B/KusRZ4QrD/jGKaYvAfJ1G6ANxB bghtMJABDD8Lp6OcJu5R0cEXFGBQszUZaSoUJ71bAZIbJxCup28fQotZSD0DUlvnv2KL jb6HLeSLfQOtJtU/HwPbM+uNpt87YYopW8EkZXo5SQ11y81sfafSKD+HSSNoZo/MX6Xk tw28IQyoWVSOzavXqW+ZfcnQ0uVRGVLz7oZxP4RcHATIdLf2mEoh+npT9fTqq/tcWYJp 3AYsTUVeX7/VzVY54QDhMAixPJR9YnocuVkBNMpuKbHcOPtH8RQvNKiuarTpe0S/fp5+ OE6w== X-Gm-Message-State: ABy/qLajBrM3wweIXnQi0k1a2HkXai/cP3qItrWf/9MRCY2UpAFK4S57 yX1yNV0aoiAQq95E3Hi7z7rnZQpaGxY= X-Google-Smtp-Source: APBJJlEENUeOEhAG0XHIXrMsupEp7O2idyzLkgPM2oOVWGd5xuYU/qcvAPm1rLiXLiQqEmRk7lFLdQ== X-Received: by 2002:ac2:4d19:0:b0:4f8:6625:f2ca with SMTP id r25-20020ac24d19000000b004f86625f2camr2382262lfi.61.1690900260555; Tue, 01 Aug 2023 07:31:00 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v6 1/2] xen/riscv: introduce function for physical offset calculation Date: Tue, 1 Aug 2023 17:30:49 +0300 Message-ID: <1efa59f7296bd7b36f6c118b71180d86e89c72b1.1690899325.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function was introduced to calculate and save physical offset before MMU is enabled because access to start() is PC-relative and in case of linker_addr != load_addr it will result in incorrect value in phys_offset. Signed-off-by: Oleksii Kurochko --- Changes in V6: - After 9380f06fe8("xen: Drop the (almost) unused extern start[]") an update of calc_phys_offset() was needed: - change start to _start. - add local volatile variable load_start to get properly Xens' load address. Otherwise compile thinks that (start - XEN_VIRT_START) is equal to 0. --- Changes in V5: - update prototype of calc_phys_offset(). now it returns phys_offset. - declare phys_offset as static. - save returned value of calc_phys_offset to register s2. --- Changes in V4: - update the comment messages in head.S related to save/restore of a0/a1 regs. --- Changes in V3: - save/restore of a0/a1 registers before C first function call. --- Changes in V2: - add __ro_after_init for phys_offset variable. - remove double blank lines. - add __init for calc_phys_offset(). - update the commit message. - declaring variable phys_off as non static as it will be used in head.S. --- xen/arch/riscv/include/asm/mm.h | 2 ++ xen/arch/riscv/mm.c | 21 ++++++++++++++++++--- xen/arch/riscv/riscv64/head.S | 14 ++++++++++++++ 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h index 5e3ac5cde3..7b94cbadd7 100644 --- a/xen/arch/riscv/include/asm/mm.h +++ b/xen/arch/riscv/include/asm/mm.h @@ -15,4 +15,6 @@ void setup_initial_pagetables(void); void enable_mmu(void); void cont_after_mmu_is_enabled(void); +unsigned long calc_phys_offset(void); + #endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index 99ed5e9623..a73f135a3c 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include #include #include #include @@ -19,9 +20,10 @@ struct mmu_desc { pte_t *pgtbl_base; }; -#define PHYS_OFFSET ((unsigned long)_start - XEN_VIRT_START) -#define LOAD_TO_LINK(addr) ((addr) - PHYS_OFFSET) -#define LINK_TO_LOAD(addr) ((addr) + PHYS_OFFSET) +static unsigned long __ro_after_init phys_offset; + +#define LOAD_TO_LINK(addr) ((unsigned long)(addr) - phys_offset) +#define LINK_TO_LOAD(addr) ((unsigned long)(addr) + phys_offset) /* * It is expected that Xen won't be more then 2 MB. @@ -273,3 +275,16 @@ void __init noreturn noinline enable_mmu() switch_stack_and_jump((unsigned long)cpu0_boot_stack + STACK_SIZE, cont_after_mmu_is_enabled); } + +/* + * calc_phys_offset() should be used before MMU is enabled because access to + * start() is PC-relative and in case when load_addr != linker_addr phys_offset + * will have an incorrect value + */ +unsigned long __init calc_phys_offset(void) +{ + volatile unsigned long load_start = (unsigned long)_start; + + phys_offset = load_start - XEN_VIRT_START; + return phys_offset; +} diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 2c0304646a..ae194bb099 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -29,6 +29,20 @@ ENTRY(start) jal reset_stack + /* + * save hart_id ( bootcpu_id ) and dtb_base as a0 and a1 register can + * be used by C code + */ + mv s0, a0 + mv s1, a1 + + jal calc_phys_offset + mv s2, a0 + + /* restore hart_id ( bootcpu_id ) and dtb address */ + mv a0, s0 + mv a1, s1 + tail start_xen .section .text, "ax", %progbits -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:45:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574270.899562 (Exim 4.92) (envelope-from ) id 1qQqcN-0001tL-9y; Tue, 01 Aug 2023 14:44:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574270.899562; Tue, 01 Aug 2023 14:44:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqcN-0001sB-40; Tue, 01 Aug 2023 14:44:59 +0000 Received: by outflank-mailman (input) for mailman id 574270; Tue, 01 Aug 2023 14:44:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqcL-0001l9-R9 for xen-devel@lists.xen.org; Tue, 01 Aug 2023 14:44:58 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7e35ead-3079-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:44:52 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqc6-00077U-Hn; Tue, 01 Aug 2023 14:44:42 +0000 Received: from julieng by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qQqc6-0003DF-Fl; Tue, 01 Aug 2023 14:44:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7e35ead-3079-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=SZXqskAvCr2m3Sg9JnEDMbVAwCNoFywf9GxMzz8UySw=; b=A5SSiGbqu6Jo+u+jhTA6RP/d0Z v+Py5L9yo1saysKXLeVDBSa1vrPe90zx4Kc4Xe4tkl+Fth+Ir7TsRVSURToLDm9JD2oZ/6mtkGNmN MQ89J7Ux2k7jiD71MB+lLWrt+9lxj5+zf2o8w7VDX96RYAdee/GpXez6Tspw39AJ/cBc=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 436 v1 (CVE-2023-34320) - arm: Guests can trigger a deadlock on Cortex-A77 Message-Id: Date: Tue, 01 Aug 2023 14:44:42 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2023-34320 / XSA-436 arm: Guests can trigger a deadlock on Cortex-A77 ISSUE DESCRIPTION ================= Cortex-A77 cores (r0p0 and r1p0) are affected by erratum 1508412 where software, under certain circumstances, could deadlock a core due to the execution of either a load to device or non-cacheable memory, and either a store exclusive or register read of the Physical Address Register (PAR_EL1) in close proximity. IMPACT ====== A (malicious) guest that doesn't include the workaround for erratum 1508412 could deadlock the core. This will ultimately result to a deadlock of the system. VULNERABLE SYSTEMS ================== Systems running all version of Xen are affected. This bug is specific to Arm Cortex-A77 cores r0p0 and r1p0. MITIGATION ========== There are no known mitigations. NOTE REGARDING LACK OF EMBARGO ============================== This issue has been publicly documented. RESOLUTION ========== To handle properly the erratum, it is necessary to have an updated firmware and that both the hypervisor and guest OSes have the workaround. This means it is not possible to security support Xen on the Cortex-A77, even on systems which have the workaround enabled. Applying the attached patches will document the situation and also add the workaround in Xen if someone wish to run on Cortex-A77 with only trusted guests. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa436/xsa436.patch xen-unstable - Xen 4.17.x xsa436/xsa436-4.16.patch Xen 4.16.x xsa436/xsa436-4.15.patch Xen 4.15.x $ sha256sum xsa436* xsa436*/* 64d34753cdbbcfec2c80db2daad98529bf900935419d0214057e962098b38160 xsa436.meta cc0f1303d4ad4c4750bd555622b87a9721e0253759b07915e6ba5216c24e8f8d xsa436/xsa436.patch 97d1bd7716637efce1fa5d7f608d7f26b2b396fa20b966c8c0cd22ef61dc07d4 xsa436/xsa436-4.15.patch e1264a44df39d56a2c6246d8f9f511d0371a5f416c364ef766ea5a59e7b46f92 xsa436/xsa436-4.16.patch $ -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmTJGVoMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZIpMIAJJ/58V/2+aEQfc0Fd+UDegr+69PsgRVRKofbX5o M8r0hCLoowsEvI8vxloaOCTtgEwzFq2zCYsUED1nn0iLk0MqK6t9njkuVD3cmuqt WaVXiW7uJU8ph2pwscv2tVPBBYblT7+Y3fuHsbXEjEW40yQkStkD5NMgwH5Z0bhq 61zCZm+/xK66VBKnrWFdlTaueOLT11/lGPskISquWrYjz7Vr873k89fXdGURn6+9 N7gdl3eIDqkpGTXvUPFdPwwE+z1ESxGig24RYNQmt3UpLbIQO2wGp0HXbsJ8e1cj r4KNhSFm/h6tsjOYxm5Jmi4an4gAOlVxCSNds2/+oZQVHpQ= =GNOw -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa436.meta" Content-Disposition: attachment; filename="xsa436.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MzYsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNyIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIK ICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwKICAiUmVjaXBlcyI6 IHsKICAgICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAi eGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJkZjMzOTVmNmIyZDc1 OWFiYTM5ZmI2N2E3YmMwZmU0OTE0N2M4YjM5IiwKICAgICAgICAgICJQcmVy ZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAg InhzYTQzNi94c2E0MzYtNC4xNS5wYXRjaCIKICAgICAgICAgIF0KICAgICAg ICB9CiAgICAgIH0KICAgIH0sCiAgICAiNC4xNiI6IHsKICAgICAgIlJlY2lw ZXMiOiB7CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJTdGFibGVSZWYi OiAiODlmZTZkMGVkZWE4NDFkMWQyNjkwY2YzZjUxNzNlMzM0YzY4NzgyMyIs CiAgICAgICAgICAiUHJlcmVxcyI6IFtdLAogICAgICAgICAgIlBhdGNoZXMi OiBbCiAgICAgICAgICAgICJ4c2E0MzYveHNhNDM2LTQuMTYucGF0Y2giCiAg ICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAogICAgIjQuMTci OiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAg ICAgICAiU3RhYmxlUmVmIjogIjMxNDFhMGI4NWMzN2I3NmUwNjllYzdkY2I5 MDZmZjIwMmY1YzQwNzUiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwKICAg ICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDM2L3hzYTQz Ni5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0s CiAgICAibWFzdGVyIjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAi eGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIwMWNhMjlmMGIxN2E1 MGE5NGIwZTIzMmJhMjc2YzMyZTk1ZDgwYWUzIiwKICAgICAgICAgICJQcmVy ZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAg InhzYTQzNi94c2E0MzYucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQog ICAgICB9CiAgICB9CiAgfQp9 --=separator Content-Type: application/octet-stream; name="xsa436/xsa436.patch" Content-Disposition: attachment; filename="xsa436/xsa436.patch" Content-Transfer-Encoding: base64 RnJvbSBiNmMyOGIwYTdmYTkxZTljOTJjYWYzODhhYzg3NTYzOWM0MjRhYmNl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBMdWNhIEZhbmNlbGx1 IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+CkRhdGU6IE1vbiwgMTcgSnVsIDIw MjMgMTM6MjU6NDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSB4ZW4vYXJtOiBB ZGQgQ29ydGV4LUE3NyBlcnJhdHVtIDE1MDg0MTIgaGFuZGxpbmcKCkNvcnRl eC1BNzcgY29yZXMgKHIwcDAsIHIxcDApIGNvdWxkIGRlYWRsb2NrIG9uIGEg c2VxdWVuY2Ugb2YgYQpzdG9yZS1leGNsdXNpdmUgb3IgcmVhZCBvZiBQQVJf RUwxIGFuZCBhIGxvYWQgd2l0aCBkZXZpY2Ugb3Igbm9uLWNhY2hlYWJsZQpt ZW1vcnkgYXR0cmlidXRlcy4KQSB3b3JrYXJvdW5kIGlzIGF2YWlsYWJsZSwg YnV0IGl0IGRlcGVuZHMgb24gYSBmaXJtd2FyZSBjb3VudGVycGFydC4KClRo ZSBwcm9wb3NlZCB3b3JrYXJvdW5kIGZyb20gdGhlIGVycmF0YSBkb2N1bWVu dCBpcyB0byBtb2RpZnkgdGhlIHNvZnR3YXJlCnJ1bm5pbmcgYXQgRUwxIGFu ZCBhYm92ZSB0byBpbmNsdWRlIGEgRE1CIFNZIGJlZm9yZSBhbmQgYWZ0ZXIg YWNjZXNzaW5nClBBUl9FTDEuCgpJbiBjb25qdW5jdGlvbiB0byB0aGUgYWJv dmUsIHRoZSBmaXJtd2FyZSBuZWVkcyB0byB1c2UgYSBzcGVjaWZpYyB3cml0 ZQpzZXF1ZW5jZSB0byBzZXZlcmFsIElNUExFTUVOVEFUSU9OIERFRklORUQg cmVnaXN0ZXJzIHRvIGhhdmUgdGhlIGhhcmR3YXJlCmluc2VydCBhIERNQiBT WSBhZnRlciBhbGwgbG9hZC1leGNsdXNpdmUgYW5kIHN0b3JlLWV4Y2x1c2l2 ZSBpbnN0cnVjdGlvbnMuCgpBcHBseSB0aGUgd29ya2Fyb3VuZCB0byBYZW4g d2hlcmUgUEFSX0VMMSBpcyByZWFkLCBpbXBsZW1lbnRpbmcgYW4gaGVscGVy CmZ1bmN0aW9uIHRvIGRvIHRoYXQuClNpbmNlIFhlbiBjYW4gYmUgaW50ZXJy dXB0ZWQgYnkgaXJxcyBpbiBhbnkgbW9tZW50LCBhZGQgYSBiYXJyaWVyIG9u CmVudHJ5L2V4aXQgd2hlbiB3ZSBhcmUgcnVubmluZyBvbiB0aGUgYWZmZWN0 ZWQgY29yZXMuCgpBIGd1ZXN0IHdpdGhvdXQgdGhlIHdvcmthcm91bmQgY2Fu IGRlYWRsb2NrIHRoZSBzeXN0ZW0sIHNvIHdhcm4gdGhlIHVzZXJzCm9mIFhl biB3aXRoIHRoZSBhYm92ZSB0eXBlIG9mIGNvcmVzIHRvIHVzZSBvbmx5IHRy dXN0ZWQgZ3Vlc3RzLCBieQpwcmludGluZyBhIG1lc3NhZ2Ugb24gWGVuIHN0 YXJ0dXAuCgpTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZh bmNlbGx1QGFybS5jb20+ClJldmlld2VkLWJ5OiBCZXJ0cmFuZCBNYXJxdWlz IDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+ClJldmlld2VkLWJ5OiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgotLS0KIFNVUFBPUlQubWQg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArKwogZG9jcy9taXNj L2FybS9zaWxpY29uLWVycmF0YS50eHQgICAgICB8ICAxICsKIHhlbi9hcmNo L2FybS9LY29uZmlnICAgICAgICAgICAgICAgICAgfCAyMSArKysrKysrKysr KysrKysrKysrKysKIHhlbi9hcmNoL2FybS9hcm02NC9lbnRyeS5TICAgICAg ICAgICAgfCAxOSArKysrKysrKysrKysrKysrKysrCiB4ZW4vYXJjaC9hcm0v Y3B1ZXJyYXRhLmMgICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKysrLS0t LQogeGVuL2FyY2gvYXJtL2RvbWFpbi5jICAgICAgICAgICAgICAgICB8ICAy ICstCiB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvcGFnZS5oIHwg MTIgKysrKysrLS0tLS0tCiB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY3B1 ZmVhdHVyZS5oIHwgIDMgKystCiB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v c3lzcmVncy5oICAgIHwgMjQgKysrKysrKysrKysrKysrKysrKysrKysrCiA5 IGZpbGVzIGNoYW5nZWQsIDg4IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NVUFBPUlQubWQgYi9TVVBQT1JULm1kCmlu ZGV4IDhlMDQwZDFjMWVmNS4uYjYzMzc2ZjRkOGQyIDEwMDY0NAotLS0gYS9T VVBQT1JULm1kCisrKyBiL1NVUFBPUlQubWQKQEAgLTM5LDggKzM5LDEwIEBA IHN1cHBvcnRlZCBpbiB0aGlzIGRvY3VtZW50LgogCiAgICAgU3RhdHVzOiBT dXBwb3J0ZWQKICAgICBTdGF0dXMsIENvcnRleCBBNTcgcjBwMC1yMXAxOiBT dXBwb3J0ZWQsIG5vdCBzZWN1cml0eSBzdXBwb3J0ZWQKKyAgICBTdGF0dXMs IENvcnRleCBBNzcgcjBwMC1yMXAwOiBTdXBwb3J0ZWQsIG5vdCBzZWN1cml0 eSBzdXBwb3J0ZWQKIAogRm9yIHRoZSBDb3J0ZXggQTU3IHIwcDAgLSByMXAx LCBzZWUgRXJyYXRhIDgzMjA3NS4KK0ZvciB0aGUgQ29ydGV4IEE3NyByMHAw IC0gcjFwMCwgc2VlIEVycmF0YSAxNTA4NDEyLgogCiAjIyBIb3N0IGhhcmR3 YXJlIHN1cHBvcnQKIApkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9zaWxp Y29uLWVycmF0YS50eHQgYi9kb2NzL21pc2MvYXJtL3NpbGljb24tZXJyYXRh LnR4dAppbmRleCAxOTI1ZDhmZDRlZTAuLmM0ZTgyZGY1MzU2NiAxMDA2NDQK LS0tIGEvZG9jcy9taXNjL2FybS9zaWxpY29uLWVycmF0YS50eHQKKysrIGIv ZG9jcy9taXNjL2FybS9zaWxpY29uLWVycmF0YS50eHQKQEAgLTU4LDQgKzU4 LDUgQEAgc3RhYmxlIGh5cGVydmlzb3JzLgogfCBBUk0gICAgICAgICAgICB8 IENvcnRleC1BNzYgICAgICB8ICMxMjg2ODA3ICAgICAgICB8IEFSTTY0X0VS UkFUVU1fMTI4NjgwNyAgIHwKIHwgQVJNICAgICAgICAgICAgfCBOZW92ZXJz ZS1OMSAgICAgfCAjMTE2NTUyMiAgICAgICAgfCBOL0EKIHwgQVJNICAgICAg ICAgICAgfCBOZW92ZXJzZS1OMSAgICAgfCAjMTI4NjgwNyAgICAgICAgfCBB Uk02NF9FUlJBVFVNXzEyODY4MDcgICB8Cit8IEFSTSAgICAgICAgICAgIHwg Q29ydGV4LUE3NyAgICAgIHwgIzE1MDg0MTIgICAgICAgIHwgQVJNNjRfRVJS QVRVTV8xNTA4NDEyICAgfAogfCBBUk0gICAgICAgICAgICB8IE1NVS01MDAg ICAgICAgICB8ICM4NDI4NjkgICAgICAgICB8IE4vQSAgICAgICAgICAgICAg ICAgICAgIHwKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9LY29uZmlnIGIv eGVuL2FyY2gvYXJtL0tjb25maWcKaW5kZXggMzNlMDA0ZDcwMmJmLi42ZWQx ZDUxNzkxZTEgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmlnCisr KyBiL3hlbi9hcmNoL2FybS9LY29uZmlnCkBAIC0zMTIsNiArMzEyLDI3IEBA IGNvbmZpZyBBUk02NF9FUlJBVFVNXzEyODY4MDcKIAogCSAgSWYgdW5zdXJl LCBzYXkgWS4KIAorY29uZmlnIEFSTTY0X0VSUkFUVU1fMTUwODQxMgorCWJv b2wgIkNvcnRleC1BNzc6IDE1MDg0MTI6IHBvc3NpYmxlIGRlYWRsb2NrIG9u IHNlcXVlbmNlIG9mIE5DL0RldmljZSBsb2FkIGFuZCBzdG9yZSBleGNsdXNp dmUgb3IgUEFSIHJlYWQiCisJZGVmYXVsdCB5CisJZGVwZW5kcyBvbiBBUk1f NjQKKwloZWxwCisJICBUaGlzIG9wdGlvbiBhZGRzIGEgd29ya2Fyb3VuZCBm b3IgQXJtIENvcnRleC1BNzcgZXJyYXR1bSAxNTA4NDEyLgorCisJICBBZmZl Y3RlZCBDb3J0ZXgtQTc3IGNvcmVzIChyMHAwLCByMXAwKSBjb3VsZCBkZWFk bG9jayBvbiBhIHNlcXVlbmNlCisJICBvZiBhIHN0b3JlLWV4Y2x1c2l2ZSBv ciByZWFkIG9mIFBBUl9FTDEgYW5kIGEgbG9hZCB3aXRoIGRldmljZSBvcgor CSAgbm9uLWNhY2hlYWJsZSBtZW1vcnkgYXR0cmlidXRlcy4gVGhlIHdvcmth cm91bmQgZGVwZW5kcyBvbiBhIGZpcm13YXJlCisJICBjb3VudGVycGFydC4K KworCSAgWGVuIGd1ZXN0cyBtdXN0IGFsc28gaGF2ZSB0aGUgd29ya2Fyb3Vu ZCBpbXBsZW1lbnRlZCBvciB0aGV5IGNhbgorCSAgZGVhZGxvY2sgdGhlIHN5 c3RlbS4KKworCSAgV29yayBhcm91bmQgdGhlIGlzc3VlIGJ5IGluc2VydGlu ZyBETUIgU1kgYmFycmllcnMgYXJvdW5kIFBBUl9FTDEKKwkgIHJlZ2lzdGVy IHJlYWRzIGFuZCB3YXJuaW5nIFhlbiB1c2Vycy4gVGhlIERNQiBiYXJyaWVy IGlzIHN1ZmZpY2llbnQKKwkgIHRvIHByZXZlbnQgYSBzcGVjdWxhdGl2ZSBQ QVJfRUwxIHJlYWQuCisKKwkgIElmIHVuc3VyZSwgc2F5IFkuCisKIGVuZG1l bnUKIAogY29uZmlnIEFSTTY0X0hBUkRFTl9CUkFOQ0hfUFJFRElDVE9SCmRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvZW50cnkuUyBiL3hlbi9h cmNoL2FybS9hcm02NC9lbnRyeS5TCmluZGV4IDk1ZjFhOTI2ODQxOS4uOTVm ZjRlM2UwNTE3IDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvZW50 cnkuUworKysgYi94ZW4vYXJjaC9hcm0vYXJtNjQvZW50cnkuUwpAQCAtMTM0 LDYgKzEzNCwxNiBAQAogICogcG9zaXRpb24gb24gdGhlIHN0YWNrIGJlZm9y ZS4KICAqLwogICAgICAgICAubWFjcm8gIGVudHJ5LCBoeXAsIGNvbXBhdCwg c2F2ZV94MF94MT0xCisKKyAgICAgICAgLyoKKyAgICAgICAgICogRW5zdXJl IGFueSBQQVJfRUwxIHJlYWRzIGNvbXBsZXRlLCBpbiBjYXNlIHdlIHdlcmUg aW50ZXJydXB0ZWQKKyAgICAgICAgICogYmV0d2VlbiB0aGUgUEFSX0VMMSBy ZWFkIGFuZCB0aGUgbWVtb3J5IGJhcnJpZXIgZm9yIHRoZSBlcnJhdHVtCisg ICAgICAgICAqIDE1MDg0MTIgd29ya2Fyb3VuZC4KKyAgICAgICAgICovCisg ICAgICAgIGFsdGVybmF0aXZlX2lmIEFSTTY0X1dPUktBUk9VTkRfMTUwODQx MgorICAgICAgICBkbWIgc3kKKyAgICAgICAgYWx0ZXJuYXRpdmVfZWxzZV9u b3BfZW5kaWYKKwogICAgICAgICBzdWIgICAgIHNwLCBzcCwgIyhVUkVHU19T UFNSX2VsMSAtIFVSRUdTX0xSKSAvKiBDUFNSLCBQQywgU1AsIExSICovCiAK ICAgICAgICAgLmlmIFxoeXAgPT0gMCAgICAgICAgIC8qIEd1ZXN0IG1vZGUg Ki8KQEAgLTQ5Miw2ICs1MDIsMTUgQEAgcmV0dXJuX2Zyb21fdHJhcDoKIAog ICAgICAgICBsZHIgICAgIGxyLCBbc3BdLCAjKFVSRUdTX1NQU1JfZWwxIC0g VVJFR1NfTFIpIC8qIENQU1IsIFBDLCBTUCwgTFIgKi8KIAorICAgICAgICAv KgorICAgICAgICAgKiBFbnN1cmUgYW55IGRldmljZS9OQyByZWFkcyBjb21w bGV0ZSwgaW4gY2FzZSB3ZSB3ZXJlIGludGVycnVwdGVkCisgICAgICAgICAq IGJldHdlZW4gdGhlIG1lbW9yeSBiYXJyaWVyIGZvciB0aGUgZXJyYXR1bSAx NTA4NDEyIHdvcmthcm91bmQgYW5kCisgICAgICAgICAqIGFueSBQQVJfRUwx IHJlYWQuCisgICAgICAgICAqLworICAgICAgICBhbHRlcm5hdGl2ZV9pZiBB Uk02NF9XT1JLQVJPVU5EXzE1MDg0MTIKKyAgICAgICAgZG1iIHN5CisgICAg ICAgIGFsdGVybmF0aXZlX2Vsc2Vfbm9wX2VuZGlmCisKICAgICAgICAgZXJl dAogICAgICAgICBzYgogCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vY3B1 ZXJyYXRhLmMgYi94ZW4vYXJjaC9hcm0vY3B1ZXJyYXRhLmMKaW5kZXggYWU2 NDlkMTZlZjAyLi5lYTY4MGZhYzJlNDQgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNo L2FybS9jcHVlcnJhdGEuYworKysgYi94ZW4vYXJjaC9hcm0vY3B1ZXJyYXRh LmMKQEAgLTY2OCw2ICs2NjgsMTQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBh cm1fY3B1X2NhcGFiaWxpdGllcyBhcm1fZXJyYXRhW10gPSB7CiAgICAgICAg IC5jYXBhYmlsaXR5ID0gQVJNNjRfV09SS0FST1VORF9BVF9TUEVDVUxBVEUs CiAgICAgICAgIE1JRFJfQUxMX1ZFUlNJT05TKE1JRFJfQ09SVEVYX0E1Nyks CiAgICAgfSwKKyNpZmRlZiBDT05GSUdfQVJNNjRfRVJSQVRVTV8xNTA4NDEy CisgICAgeworICAgICAgICAvKiBDb3J0ZXgtQTc3IHIwcDAgLSByMXAwICov CisgICAgICAgIC5kZXNjID0gIkFSTSBlcnJhdHVtIDE1MDg0MTIgKGh5cGVy dmlzb3IgcG9ydGlvbikiLAorICAgICAgICAuY2FwYWJpbGl0eSA9IEFSTTY0 X1dPUktBUk9VTkRfMTUwODQxMiwKKyAgICAgICAgTUlEUl9SQU5HRShNSURS X0NPUlRFWF9BNzcsIDAsIDEpLAorICAgIH0sCisjZW5kaWYKICAgICB7CiAg ICAgICAgIC8qIENvcnRleC1BNTUgKEFsbCB2ZXJzaW9ucyBhcyBlcnJhdHVt IGlzIG9wZW4gaW4gU0RFTiB2MTQpICovCiAgICAgICAgIC5kZXNjID0gIkFS TSBlcnJhdHVtIDE1MzA5MjMiLApAQCAtNjg2LDExICs2OTQsMTEgQEAgdm9p ZCBfX2luaXQgZW5hYmxlX2VycmF0YV93b3JrYXJvdW5kcyh2b2lkKQogewog ICAgIGVuYWJsZV9jcHVfY2FwYWJpbGl0aWVzKGFybV9lcnJhdGEpOwogCi0j aWZkZWYgQ09ORklHX0FSTTY0X0VSUkFUVU1fODMyMDc1Ci0gICAgaWYgKCBj cHVzX2hhdmVfY2FwKEFSTTY0X1dPUktBUk9VTkRfREVWSUNFX0xPQURfQUNR VUlSRSkgKQorI2lmIGRlZmluZWQoQ09ORklHX0FSTTY0X0VSUkFUVU1fODMy MDc1KSB8fCBkZWZpbmVkKENPTkZJR19BUk02NF9FUlJBVFVNXzE1MDg0MTIp CisgICAgaWYgKCBjcHVzX2hhdmVfY2FwKEFSTTY0X1dPUktBUk9VTkRfREVW SUNFX0xPQURfQUNRVUlSRSkgfHwKKyAgICAgICAgIGNwdXNfaGF2ZV9jYXAo QVJNNjRfV09SS0FST1VORF8xNTA4NDEyKSApCiAgICAgewotICAgICAgICBw cmludGtfb25jZSgiKioqKiBUaGlzIENQVSBpcyBhZmZlY3RlZCBieSB0aGUg ZXJyYXRhIDgzMjA3NS4gICAgICAgICAgICAgICAgICAgICAgKioqKlxuIgot ICAgICAgICAgICAgICAgICAgICAiKioqKiBHdWVzdHMgd2l0aG91dCBDUFUg ZXJyYXR1bSB3b3JrYXJvdW5kcyBjYW4gZGVhZGxvY2sgdGhlIHN5c3RlbSEg KioqKlxuIgorICAgICAgICBwcmludGtfb25jZSgiKioqKiBHdWVzdHMgd2l0 aG91dCBDUFUgZXJyYXR1bSB3b3JrYXJvdW5kcyBjYW4gZGVhZGxvY2sgdGhl IHN5c3RlbSEgKioqKlxuIgogICAgICAgICAgICAgICAgICAgICAiKioqKiBP bmx5IHRydXN0ZWQgZ3Vlc3RzIHNob3VsZCBiZSB1c2VkLiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKioqKlxuIik7CiAKICAgICAgICAgLyogVGFp bnQgdGhlIG1hY2hpbmUgaGFzIGJlaW5nIGluc2VjdXJlICovCmRpZmYgLS1n aXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMgYi94ZW4vYXJjaC9hcm0vZG9t YWluLmMKaW5kZXggMmNkNDgxOTc5Y2YxLi4zZTM3MmZiNzBiOTkgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYworKysgYi94ZW4vYXJjaC9h cm0vZG9tYWluLmMKQEAgLTEzNyw3ICsxMzcsNyBAQCBzdGF0aWMgdm9pZCBj dHh0X3N3aXRjaF9mcm9tKHN0cnVjdCB2Y3B1ICpwKQogICAgIHAtPmFyY2gu dHRicjEgPSBSRUFEX1NZU1JFRzY0KFRUQlIxX0VMMSk7CiAgICAgaWYgKCBp c18zMmJpdF9kb21haW4ocC0+ZG9tYWluKSApCiAgICAgICAgIHAtPmFyY2gu ZGFjciA9IFJFQURfU1lTUkVHKERBQ1IzMl9FTDIpOwotICAgIHAtPmFyY2gu cGFyID0gUkVBRF9TWVNSRUc2NChQQVJfRUwxKTsKKyAgICBwLT5hcmNoLnBh ciA9IHJlYWRfc3lzcmVnX3BhcigpOwogI2lmIGRlZmluZWQoQ09ORklHX0FS TV8zMikKICAgICBwLT5hcmNoLm1haXIwID0gUkVBRF9DUDMyKE1BSVIwKTsK ICAgICBwLT5hcmNoLm1haXIxID0gUkVBRF9DUDMyKE1BSVIxKTsKZGlmZiAt LWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm02NC9wYWdlLmgg Yi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvcGFnZS5oCmluZGV4 IDBjYmEyNjYzNzMzYi4uZmJmZTY3YmY4OTUxIDEwMDY0NAotLS0gYS94ZW4v YXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtNjQvcGFnZS5oCisrKyBiL3hlbi9h cmNoL2FybS9pbmNsdWRlL2FzbS9hcm02NC9wYWdlLmgKQEAgLTQ4LDExICs0 OCwxMSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW52YWxpZGF0ZV9pY2FjaGVf bG9jYWwodm9pZCkKIC8qIEFzayB0aGUgTU1VIHRvIHRyYW5zbGF0ZSBhIFZB IGZvciB1cyAqLwogc3RhdGljIGlubGluZSB1aW50NjRfdCBfX3ZhX3RvX3Bh cih2YWRkcl90IHZhKQogewotICAgIHVpbnQ2NF90IHBhciwgdG1wID0gUkVB RF9TWVNSRUc2NChQQVJfRUwxKTsKKyAgICB1aW50NjRfdCBwYXIsIHRtcCA9 IHJlYWRfc3lzcmVnX3BhcigpOwogCiAgICAgYXNtIHZvbGF0aWxlICgiYXQg czFlMnIsICUwOyIgOiA6ICJyIiAodmEpKTsKICAgICBpc2IoKTsKLSAgICBw YXIgPSBSRUFEX1NZU1JFRzY0KFBBUl9FTDEpOworICAgIHBhciA9IHJlYWRf c3lzcmVnX3BhcigpOwogICAgIFdSSVRFX1NZU1JFRzY0KHRtcCwgUEFSX0VM MSk7CiAgICAgcmV0dXJuIHBhcjsKIH0KQEAgLTYwLDI4ICs2MCwyOCBAQCBz dGF0aWMgaW5saW5lIHVpbnQ2NF90IF9fdmFfdG9fcGFyKHZhZGRyX3QgdmEp CiAvKiBBc2sgdGhlIE1NVSB0byB0cmFuc2xhdGUgYSBHdWVzdCBWQSBmb3Ig dXMgKi8KIHN0YXRpYyBpbmxpbmUgdWludDY0X3QgZ3ZhX3RvX21hX3Bhcih2 YWRkcl90IHZhLCB1bnNpZ25lZCBpbnQgZmxhZ3MpCiB7Ci0gICAgdWludDY0 X3QgcGFyLCB0bXAgPSBSRUFEX1NZU1JFRzY0KFBBUl9FTDEpOworICAgIHVp bnQ2NF90IHBhciwgdG1wID0gcmVhZF9zeXNyZWdfcGFyKCk7CiAKICAgICBp ZiAoIChmbGFncyAmIEdWMk1fV1JJVEUpID09IEdWMk1fV1JJVEUgKQogICAg ICAgICBhc20gdm9sYXRpbGUgKCJhdCBzMTJlMXcsICUwOyIgOiA6ICJyIiAo dmEpKTsKICAgICBlbHNlCiAgICAgICAgIGFzbSB2b2xhdGlsZSAoImF0IHMx MmUxciwgJTA7IiA6IDogInIiICh2YSkpOwogICAgIGlzYigpOwotICAgIHBh ciA9IFJFQURfU1lTUkVHNjQoUEFSX0VMMSk7CisgICAgcGFyID0gcmVhZF9z eXNyZWdfcGFyKCk7CiAgICAgV1JJVEVfU1lTUkVHNjQodG1wLCBQQVJfRUwx KTsKICAgICByZXR1cm4gcGFyOwogfQogCiBzdGF0aWMgaW5saW5lIHVpbnQ2 NF90IGd2YV90b19pcGFfcGFyKHZhZGRyX3QgdmEsIHVuc2lnbmVkIGludCBm bGFncykKIHsKLSAgICB1aW50NjRfdCBwYXIsIHRtcCA9IFJFQURfU1lTUkVH NjQoUEFSX0VMMSk7CisgICAgdWludDY0X3QgcGFyLCB0bXAgPSByZWFkX3N5 c3JlZ19wYXIoKTsKIAogICAgIGlmICggKGZsYWdzICYgR1YyTV9XUklURSkg PT0gR1YyTV9XUklURSApCiAgICAgICAgIGFzbSB2b2xhdGlsZSAoImF0IHMx ZTF3LCAlMDsiIDogOiAiciIgKHZhKSk7CiAgICAgZWxzZQogICAgICAgICBh c20gdm9sYXRpbGUgKCJhdCBzMWUxciwgJTA7IiA6IDogInIiICh2YSkpOwog ICAgIGlzYigpOwotICAgIHBhciA9IFJFQURfU1lTUkVHNjQoUEFSX0VMMSk7 CisgICAgcGFyID0gcmVhZF9zeXNyZWdfcGFyKCk7CiAgICAgV1JJVEVfU1lT UkVHNjQodG1wLCBQQVJfRUwxKTsKICAgICByZXR1cm4gcGFyOwogfQpkaWZm IC0tZ2l0IGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NwdWZlYXR1cmUu aCBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jcHVmZWF0dXJlLmgKaW5k ZXggYzg2YTJlN2YyOTFjLi4zYTM5ZmU0YjVhZmUgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jcHVmZWF0dXJlLmgKKysrIGIveGVu L2FyY2gvYXJtL2luY2x1ZGUvYXNtL2NwdWZlYXR1cmUuaApAQCAtNjgsOCAr NjgsOSBAQAogI2RlZmluZSBBUk1fV09SS0FST1VORF9CSEJfTE9PUF8zMiAx NAogI2RlZmluZSBBUk1fV09SS0FST1VORF9CSEJfU01DQ18zIDE1CiAjZGVm aW5lIEFSTV9IQVNfU0IgMTYKKyNkZWZpbmUgQVJNNjRfV09SS0FST1VORF8x NTA4NDEyIDE3CiAKLSNkZWZpbmUgQVJNX05DQVBTICAgICAgICAgICAxNwor I2RlZmluZSBBUk1fTkNBUFMgICAgICAgICAgIDE4CiAKICNpZm5kZWYgX19B U1NFTUJMWV9fCiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRl L2FzbS9zeXNyZWdzLmggYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc3lz cmVncy5oCmluZGV4IDVjNWM1MWJiY2RiZi4uNjFlMzBjOWU1MTdjIDEwMDY0 NAotLS0gYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vc3lzcmVncy5oCisr KyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9zeXNyZWdzLmgKQEAgLTks NiArOSwzMCBAQAogIyBlcnJvciAidW5rbm93biBBUk0gdmFyaWFudCIKICNl bmRpZgogCisjaWZuZGVmIF9fQVNTRU1CTFlfXworCisjaW5jbHVkZSA8YXNt L2FsdGVybmF0aXZlLmg+CisKK3N0YXRpYyBpbmxpbmUgcmVnaXN0ZXJfdCBy ZWFkX3N5c3JlZ19wYXIodm9pZCkKK3sKKyAgICByZWdpc3Rlcl90IHBhcl9l bDE7CisKKyAgICAvKgorICAgICAqIE9uIENvcnRleC1BNzcgcjBwMCBhbmQg cjFwMCwgcmVhZCBhY2Nlc3MgdG8gUEFSX0VMMSBzaGFsbCBpbmNsdWRlIGEK KyAgICAgKiBETUIgU1kgYmVmb3JlIGFuZCBhZnRlciBhY2Nlc3NpbmcgaXQs IGFzIHBhcnQgb2YgdGhlIHdvcmthcm91bmQgZm9yIHRoZQorICAgICAqIGVy cmF0YSAxNTA4NDEyLgorICAgICAqLworICAgIGFzbSB2b2xhdGlsZShBTFRF Uk5BVElWRSgibm9wIiwgImRtYiBzeSIsIEFSTTY0X1dPUktBUk9VTkRfMTUw ODQxMiwKKyAgICAgICAgICAgICAgICAgQ09ORklHX0FSTTY0X0VSUkFUVU1f MTUwODQxMikpOworICAgIHBhcl9lbDEgPSBSRUFEX1NZU1JFRzY0KFBBUl9F TDEpOworICAgIGFzbSB2b2xhdGlsZShBTFRFUk5BVElWRSgibm9wIiwgImRt YiBzeSIsIEFSTTY0X1dPUktBUk9VTkRfMTUwODQxMiwKKyAgICAgICAgICAg ICAgICAgQ09ORklHX0FSTTY0X0VSUkFUVU1fMTUwODQxMikpOworCisgICAg cmV0dXJuIHBhcl9lbDE7Cit9CisKKyNlbmRpZiAvKiAgIV9fQVNTRU1CTFlf XyAgKi8KKwogI2VuZGlmIC8qIF9fQVNNX0FSTV9TWVNSRUdTX0ggKi8KIC8q CiAgKiBMb2NhbCB2YXJpYWJsZXM6Ci0tIAoyLjQwLjEKCg== --=separator Content-Type: application/octet-stream; name="xsa436/xsa436-4.15.patch" Content-Disposition: attachment; filename="xsa436/xsa436-4.15.patch" Content-Transfer-Encoding: base64 RnJvbSBiY2IwNzc3NjkyZWVjYjYwMzdmNmMxMzI0MGRmNTkxZmE3MGU3NWVl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBMdWNhIEZhbmNlbGx1 IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+CkRhdGU6IE1vbiwgMTcgSnVsIDIw MjMgMTM6MjU6NDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSB4ZW4vYXJtOiBB ZGQgQ29ydGV4LUE3NyBlcnJhdHVtIDE1MDg0MTIgaGFuZGxpbmcKCkNvcnRl eC1BNzcgY29yZXMgKHIwcDAsIHIxcDApIGNvdWxkIGRlYWRsb2NrIG9uIGEg c2VxdWVuY2Ugb2YgYQpzdG9yZS1leGNsdXNpdmUgb3IgcmVhZCBvZiBQQVJf RUwxIGFuZCBhIGxvYWQgd2l0aCBkZXZpY2Ugb3Igbm9uLWNhY2hlYWJsZQpt ZW1vcnkgYXR0cmlidXRlcy4KQSB3b3JrYXJvdW5kIGlzIGF2YWlsYWJsZSwg YnV0IGl0IGRlcGVuZHMgb24gYSBmaXJtd2FyZSBjb3VudGVycGFydC4KClRo ZSBwcm9wb3NlZCB3b3JrYXJvdW5kIGZyb20gdGhlIGVycmF0YSBkb2N1bWVu dCBpcyB0byBtb2RpZnkgdGhlIHNvZnR3YXJlCnJ1bm5pbmcgYXQgRUwxIGFu ZCBhYm92ZSB0byBpbmNsdWRlIGEgRE1CIFNZIGJlZm9yZSBhbmQgYWZ0ZXIg YWNjZXNzaW5nClBBUl9FTDEuCgpJbiBjb25qdW5jdGlvbiB0byB0aGUgYWJv dmUsIHRoZSBmaXJtd2FyZSBuZWVkcyB0byB1c2UgYSBzcGVjaWZpYyB3cml0 ZQpzZXF1ZW5jZSB0byBzZXZlcmFsIElNUExFTUVOVEFUSU9OIERFRklORUQg cmVnaXN0ZXJzIHRvIGhhdmUgdGhlIGhhcmR3YXJlCmluc2VydCBhIERNQiBT WSBhZnRlciBhbGwgbG9hZC1leGNsdXNpdmUgYW5kIHN0b3JlLWV4Y2x1c2l2 ZSBpbnN0cnVjdGlvbnMuCgpBcHBseSB0aGUgd29ya2Fyb3VuZCB0byBYZW4g d2hlcmUgUEFSX0VMMSBpcyByZWFkLCBpbXBsZW1lbnRpbmcgYW4gaGVscGVy CmZ1bmN0aW9uIHRvIGRvIHRoYXQuClNpbmNlIFhlbiBjYW4gYmUgaW50ZXJy dXB0ZWQgYnkgaXJxcyBpbiBhbnkgbW9tZW50LCBhZGQgYSBiYXJyaWVyIG9u CmVudHJ5L2V4aXQgd2hlbiB3ZSBhcmUgcnVubmluZyBvbiB0aGUgYWZmZWN0 ZWQgY29yZXMuCgpBIGd1ZXN0IHdpdGhvdXQgdGhlIHdvcmthcm91bmQgY2Fu IGRlYWRsb2NrIHRoZSBzeXN0ZW0sIHNvIHdhcm4gdGhlIHVzZXJzCm9mIFhl biB3aXRoIHRoZSBhYm92ZSB0eXBlIG9mIGNvcmVzIHRvIHVzZSBvbmx5IHRy dXN0ZWQgZ3Vlc3RzLCBieQpwcmludGluZyBhIG1lc3NhZ2Ugb24gWGVuIHN0 YXJ0dXAuCgpTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZh bmNlbGx1QGFybS5jb20+ClJldmlld2VkLWJ5OiBCZXJ0cmFuZCBNYXJxdWlz IDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+ClJldmlld2VkLWJ5OiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgotLS0KIFNVUFBPUlQubWQg ICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysKIGRvY3MvbWlzYy9hcm0v c2lsaWNvbi1lcnJhdGEudHh0IHwgIDEgKwogeGVuL2FyY2gvYXJtL0tjb25m aWcgICAgICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysrKysKIHhl bi9hcmNoL2FybS9hcm02NC9lbnRyeS5TICAgICAgIHwgMTkgKysrKysrKysr KysrKysrKysrKwogeGVuL2FyY2gvYXJtL2NwdWVycmF0YS5jICAgICAgICAg fCAxNiArKysrKysrKysrKystLS0tCiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMg ICAgICAgICAgICB8ICAyICstCiB4ZW4vaW5jbHVkZS9hc20tYXJtL2FybTY0 L3BhZ2UuaCB8IDEyICsrKysrKy0tLS0tLQogeGVuL2luY2x1ZGUvYXNtLWFy bS9jcHVmZWF0dXJlLmggfCAgMyArKy0KIHhlbi9pbmNsdWRlL2FzbS1hcm0v c3lzcmVncy5oICAgIHwgMjQgKysrKysrKysrKysrKysrKysrKysrKysrCiA5 IGZpbGVzIGNoYW5nZWQsIDg4IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NVUFBPUlQubWQgYi9TVVBQT1JULm1kCmlu ZGV4IDBmYjI2MmY4MWY0MC4uZDU3MTlmMDA1YmE5IDEwMDY0NAotLS0gYS9T VVBQT1JULm1kCisrKyBiL1NVUFBPUlQubWQKQEAgLTM5LDggKzM5LDEwIEBA IHN1cHBvcnRlZCBpbiB0aGlzIGRvY3VtZW50LgogCiAgICAgU3RhdHVzOiBT dXBwb3J0ZWQKICAgICBTdGF0dXMsIENvcnRleCBBNTcgcjBwMC1yMXAxOiBT dXBwb3J0ZWQsIG5vdCBzZWN1cml0eSBzdXBwb3J0ZWQKKyAgICBTdGF0dXMs IENvcnRleCBBNzcgcjBwMC1yMXAwOiBTdXBwb3J0ZWQsIG5vdCBzZWN1cml0 eSBzdXBwb3J0ZWQKIAogRm9yIHRoZSBDb3J0ZXggQTU3IHIwcDAgLSByMXAx LCBzZWUgRXJyYXRhIDgzMjA3NS4KK0ZvciB0aGUgQ29ydGV4IEE3NyByMHAw IC0gcjFwMCwgc2VlIEVycmF0YSAxNTA4NDEyLgogCiAjIyBIb3N0IGhhcmR3 YXJlIHN1cHBvcnQKIApkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9zaWxp Y29uLWVycmF0YS50eHQgYi9kb2NzL21pc2MvYXJtL3NpbGljb24tZXJyYXRh LnR4dAppbmRleCAxOTI1ZDhmZDRlZTAuLmM0ZTgyZGY1MzU2NiAxMDA2NDQK LS0tIGEvZG9jcy9taXNjL2FybS9zaWxpY29uLWVycmF0YS50eHQKKysrIGIv ZG9jcy9taXNjL2FybS9zaWxpY29uLWVycmF0YS50eHQKQEAgLTU4LDQgKzU4 LDUgQEAgc3RhYmxlIGh5cGVydmlzb3JzLgogfCBBUk0gICAgICAgICAgICB8 IENvcnRleC1BNzYgICAgICB8ICMxMjg2ODA3ICAgICAgICB8IEFSTTY0X0VS UkFUVU1fMTI4NjgwNyAgIHwKIHwgQVJNICAgICAgICAgICAgfCBOZW92ZXJz ZS1OMSAgICAgfCAjMTE2NTUyMiAgICAgICAgfCBOL0EKIHwgQVJNICAgICAg ICAgICAgfCBOZW92ZXJzZS1OMSAgICAgfCAjMTI4NjgwNyAgICAgICAgfCBB Uk02NF9FUlJBVFVNXzEyODY4MDcgICB8Cit8IEFSTSAgICAgICAgICAgIHwg Q29ydGV4LUE3NyAgICAgIHwgIzE1MDg0MTIgICAgICAgIHwgQVJNNjRfRVJS QVRVTV8xNTA4NDEyICAgfAogfCBBUk0gICAgICAgICAgICB8IE1NVS01MDAg ICAgICAgICB8ICM4NDI4NjkgICAgICAgICB8IE4vQSAgICAgICAgICAgICAg ICAgICAgIHwKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9LY29uZmlnIGIv eGVuL2FyY2gvYXJtL0tjb25maWcKaW5kZXggMzMwYmJmNjIzMmQ0Li5lM2M4 Yjg5NTk0M2UgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmlnCisr KyBiL3hlbi9hcmNoL2FybS9LY29uZmlnCkBAIC0yODQsNiArMjg0LDI3IEBA IGNvbmZpZyBBUk02NF9FUlJBVFVNXzEyODY4MDcKIAogCSAgSWYgdW5zdXJl LCBzYXkgWS4KIAorY29uZmlnIEFSTTY0X0VSUkFUVU1fMTUwODQxMgorCWJv b2wgIkNvcnRleC1BNzc6IDE1MDg0MTI6IHBvc3NpYmxlIGRlYWRsb2NrIG9u IHNlcXVlbmNlIG9mIE5DL0RldmljZSBsb2FkIGFuZCBzdG9yZSBleGNsdXNp dmUgb3IgUEFSIHJlYWQiCisJZGVmYXVsdCB5CisJZGVwZW5kcyBvbiBBUk1f NjQKKwloZWxwCisJICBUaGlzIG9wdGlvbiBhZGRzIGEgd29ya2Fyb3VuZCBm b3IgQXJtIENvcnRleC1BNzcgZXJyYXR1bSAxNTA4NDEyLgorCisJICBBZmZl Y3RlZCBDb3J0ZXgtQTc3IGNvcmVzIChyMHAwLCByMXAwKSBjb3VsZCBkZWFk bG9jayBvbiBhIHNlcXVlbmNlCisJICBvZiBhIHN0b3JlLWV4Y2x1c2l2ZSBv ciByZWFkIG9mIFBBUl9FTDEgYW5kIGEgbG9hZCB3aXRoIGRldmljZSBvcgor CSAgbm9uLWNhY2hlYWJsZSBtZW1vcnkgYXR0cmlidXRlcy4gVGhlIHdvcmth cm91bmQgZGVwZW5kcyBvbiBhIGZpcm13YXJlCisJICBjb3VudGVycGFydC4K KworCSAgWGVuIGd1ZXN0cyBtdXN0IGFsc28gaGF2ZSB0aGUgd29ya2Fyb3Vu ZCBpbXBsZW1lbnRlZCBvciB0aGV5IGNhbgorCSAgZGVhZGxvY2sgdGhlIHN5 c3RlbS4KKworCSAgV29yayBhcm91bmQgdGhlIGlzc3VlIGJ5IGluc2VydGlu ZyBETUIgU1kgYmFycmllcnMgYXJvdW5kIFBBUl9FTDEKKwkgIHJlZ2lzdGVy IHJlYWRzIGFuZCB3YXJuaW5nIFhlbiB1c2Vycy4gVGhlIERNQiBiYXJyaWVy IGlzIHN1ZmZpY2llbnQKKwkgIHRvIHByZXZlbnQgYSBzcGVjdWxhdGl2ZSBQ QVJfRUwxIHJlYWQuCisKKwkgIElmIHVuc3VyZSwgc2F5IFkuCisKIGVuZG1l bnUKIAogY29uZmlnIEFSTTY0X0hBUkRFTl9CUkFOQ0hfUFJFRElDVE9SCmRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvZW50cnkuUyBiL3hlbi9h cmNoL2FybS9hcm02NC9lbnRyeS5TCmluZGV4IGE4YzIxNDUwNjc4Ni4uNGYz M2NlZjBiM2NkIDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvZW50 cnkuUworKysgYi94ZW4vYXJjaC9hcm0vYXJtNjQvZW50cnkuUwpAQCAtMTEy LDYgKzExMiwxNiBAQAogICogcG9zaXRpb24gb24gdGhlIHN0YWNrIGJlZm9y ZS4KICAqLwogICAgICAgICAubWFjcm8gIGVudHJ5LCBoeXAsIGNvbXBhdCwg c2F2ZV94MF94MT0xCisKKyAgICAgICAgLyoKKyAgICAgICAgICogRW5zdXJl IGFueSBQQVJfRUwxIHJlYWRzIGNvbXBsZXRlLCBpbiBjYXNlIHdlIHdlcmUg aW50ZXJydXB0ZWQKKyAgICAgICAgICogYmV0d2VlbiB0aGUgUEFSX0VMMSBy ZWFkIGFuZCB0aGUgbWVtb3J5IGJhcnJpZXIgZm9yIHRoZSBlcnJhdHVtCisg ICAgICAgICAqIDE1MDg0MTIgd29ya2Fyb3VuZC4KKyAgICAgICAgICovCisg ICAgICAgIGFsdGVybmF0aXZlX2lmIEFSTTY0X1dPUktBUk9VTkRfMTUwODQx MgorICAgICAgICBkbWIgc3kKKyAgICAgICAgYWx0ZXJuYXRpdmVfZWxzZV9u b3BfZW5kaWYKKwogICAgICAgICBzdWIgICAgIHNwLCBzcCwgIyhVUkVHU19T UFNSX2VsMSAtIFVSRUdTX0xSKSAvKiBDUFNSLCBQQywgU1AsIExSICovCiAg ICAgICAgIHB1c2ggICAgeDI4LCB4MjkKICAgICAgICAgcHVzaCAgICB4MjYs IHgyNwpAQCAtNDY1LDYgKzQ3NSwxNSBAQCByZXR1cm5fZnJvbV90cmFwOgog CiAgICAgICAgIGxkciAgICAgbHIsIFtzcF0sICMoVVJFR1NfU1BTUl9lbDEg LSBVUkVHU19MUikgLyogQ1BTUiwgUEMsIFNQLCBMUiAqLwogCisgICAgICAg IC8qCisgICAgICAgICAqIEVuc3VyZSBhbnkgZGV2aWNlL05DIHJlYWRzIGNv bXBsZXRlLCBpbiBjYXNlIHdlIHdlcmUgaW50ZXJydXB0ZWQKKyAgICAgICAg ICogYmV0d2VlbiB0aGUgbWVtb3J5IGJhcnJpZXIgZm9yIHRoZSBlcnJhdHVt IDE1MDg0MTIgd29ya2Fyb3VuZCBhbmQKKyAgICAgICAgICogYW55IFBBUl9F TDEgcmVhZC4KKyAgICAgICAgICovCisgICAgICAgIGFsdGVybmF0aXZlX2lm IEFSTTY0X1dPUktBUk9VTkRfMTUwODQxMgorICAgICAgICBkbWIgc3kKKyAg ICAgICAgYWx0ZXJuYXRpdmVfZWxzZV9ub3BfZW5kaWYKKwogICAgICAgICBl cmV0CiAgICAgICAgIHNiCiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9j cHVlcnJhdGEuYyBiL3hlbi9hcmNoL2FybS9jcHVlcnJhdGEuYwppbmRleCBh ZTY0OWQxNmVmMDIuLmVhNjgwZmFjMmU0NCAxMDA2NDQKLS0tIGEveGVuL2Fy Y2gvYXJtL2NwdWVycmF0YS5jCisrKyBiL3hlbi9hcmNoL2FybS9jcHVlcnJh dGEuYwpAQCAtNjY4LDYgKzY2OCwxNCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGFybV9jcHVfY2FwYWJpbGl0aWVzIGFybV9lcnJhdGFbXSA9IHsKICAgICAg ICAgLmNhcGFiaWxpdHkgPSBBUk02NF9XT1JLQVJPVU5EX0FUX1NQRUNVTEFU RSwKICAgICAgICAgTUlEUl9BTExfVkVSU0lPTlMoTUlEUl9DT1JURVhfQTU3 KSwKICAgICB9LAorI2lmZGVmIENPTkZJR19BUk02NF9FUlJBVFVNXzE1MDg0 MTIKKyAgICB7CisgICAgICAgIC8qIENvcnRleC1BNzcgcjBwMCAtIHIxcDAg Ki8KKyAgICAgICAgLmRlc2MgPSAiQVJNIGVycmF0dW0gMTUwODQxMiAoaHlw ZXJ2aXNvciBwb3J0aW9uKSIsCisgICAgICAgIC5jYXBhYmlsaXR5ID0gQVJN NjRfV09SS0FST1VORF8xNTA4NDEyLAorICAgICAgICBNSURSX1JBTkdFKE1J RFJfQ09SVEVYX0E3NywgMCwgMSksCisgICAgfSwKKyNlbmRpZgogICAgIHsK ICAgICAgICAgLyogQ29ydGV4LUE1NSAoQWxsIHZlcnNpb25zIGFzIGVycmF0 dW0gaXMgb3BlbiBpbiBTREVOIHYxNCkgKi8KICAgICAgICAgLmRlc2MgPSAi QVJNIGVycmF0dW0gMTUzMDkyMyIsCkBAIC02ODYsMTEgKzY5NCwxMSBAQCB2 b2lkIF9faW5pdCBlbmFibGVfZXJyYXRhX3dvcmthcm91bmRzKHZvaWQpCiB7 CiAgICAgZW5hYmxlX2NwdV9jYXBhYmlsaXRpZXMoYXJtX2VycmF0YSk7CiAK LSNpZmRlZiBDT05GSUdfQVJNNjRfRVJSQVRVTV84MzIwNzUKLSAgICBpZiAo IGNwdXNfaGF2ZV9jYXAoQVJNNjRfV09SS0FST1VORF9ERVZJQ0VfTE9BRF9B Q1FVSVJFKSApCisjaWYgZGVmaW5lZChDT05GSUdfQVJNNjRfRVJSQVRVTV84 MzIwNzUpIHx8IGRlZmluZWQoQ09ORklHX0FSTTY0X0VSUkFUVU1fMTUwODQx MikKKyAgICBpZiAoIGNwdXNfaGF2ZV9jYXAoQVJNNjRfV09SS0FST1VORF9E RVZJQ0VfTE9BRF9BQ1FVSVJFKSB8fAorICAgICAgICAgY3B1c19oYXZlX2Nh cChBUk02NF9XT1JLQVJPVU5EXzE1MDg0MTIpICkKICAgICB7Ci0gICAgICAg IHByaW50a19vbmNlKCIqKioqIFRoaXMgQ1BVIGlzIGFmZmVjdGVkIGJ5IHRo ZSBlcnJhdGEgODMyMDc1LiAgICAgICAgICAgICAgICAgICAgICAqKioqXG4i Ci0gICAgICAgICAgICAgICAgICAgICIqKioqIEd1ZXN0cyB3aXRob3V0IENQ VSBlcnJhdHVtIHdvcmthcm91bmRzIGNhbiBkZWFkbG9jayB0aGUgc3lzdGVt ISAqKioqXG4iCisgICAgICAgIHByaW50a19vbmNlKCIqKioqIEd1ZXN0cyB3 aXRob3V0IENQVSBlcnJhdHVtIHdvcmthcm91bmRzIGNhbiBkZWFkbG9jayB0 aGUgc3lzdGVtISAqKioqXG4iCiAgICAgICAgICAgICAgICAgICAgICIqKioq IE9ubHkgdHJ1c3RlZCBndWVzdHMgc2hvdWxkIGJlIHVzZWQuICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAqKioqXG4iKTsKIAogICAgICAgICAvKiBU YWludCB0aGUgbWFjaGluZSBoYXMgYmVpbmcgaW5zZWN1cmUgKi8KZGlmZiAt LWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW4uYyBiL3hlbi9hcmNoL2FybS9k b21haW4uYwppbmRleCA1ZWFmNGM3MThlYzMuLjk2MWI2ZGM4MmE1NiAxMDA2 NDQKLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jCisrKyBiL3hlbi9hcmNo L2FybS9kb21haW4uYwpAQCAtMTM2LDcgKzEzNiw3IEBAIHN0YXRpYyB2b2lk IGN0eHRfc3dpdGNoX2Zyb20oc3RydWN0IHZjcHUgKnApCiAgICAgcC0+YXJj aC50dGJyMSA9IFJFQURfU1lTUkVHNjQoVFRCUjFfRUwxKTsKICAgICBpZiAo IGlzXzMyYml0X2RvbWFpbihwLT5kb21haW4pICkKICAgICAgICAgcC0+YXJj aC5kYWNyID0gUkVBRF9TWVNSRUcoREFDUjMyX0VMMik7Ci0gICAgcC0+YXJj aC5wYXIgPSBSRUFEX1NZU1JFRzY0KFBBUl9FTDEpOworICAgIHAtPmFyY2gu cGFyID0gcmVhZF9zeXNyZWdfcGFyKCk7CiAjaWYgZGVmaW5lZChDT05GSUdf QVJNXzMyKQogICAgIHAtPmFyY2gubWFpcjAgPSBSRUFEX0NQMzIoTUFJUjAp OwogICAgIHAtPmFyY2gubWFpcjEgPSBSRUFEX0NQMzIoTUFJUjEpOwpkaWZm IC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9hcm02NC9wYWdlLmggYi94 ZW4vaW5jbHVkZS9hc20tYXJtL2FybTY0L3BhZ2UuaAppbmRleCAwY2JhMjY2 MzczM2IuLmZiZmU2N2JmODk1MSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLWFybS9hcm02NC9wYWdlLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLWFy bS9hcm02NC9wYWdlLmgKQEAgLTQ4LDExICs0OCwxMSBAQCBzdGF0aWMgaW5s aW5lIHZvaWQgaW52YWxpZGF0ZV9pY2FjaGVfbG9jYWwodm9pZCkKIC8qIEFz ayB0aGUgTU1VIHRvIHRyYW5zbGF0ZSBhIFZBIGZvciB1cyAqLwogc3RhdGlj IGlubGluZSB1aW50NjRfdCBfX3ZhX3RvX3Bhcih2YWRkcl90IHZhKQogewot ICAgIHVpbnQ2NF90IHBhciwgdG1wID0gUkVBRF9TWVNSRUc2NChQQVJfRUwx KTsKKyAgICB1aW50NjRfdCBwYXIsIHRtcCA9IHJlYWRfc3lzcmVnX3Bhcigp OwogCiAgICAgYXNtIHZvbGF0aWxlICgiYXQgczFlMnIsICUwOyIgOiA6ICJy IiAodmEpKTsKICAgICBpc2IoKTsKLSAgICBwYXIgPSBSRUFEX1NZU1JFRzY0 KFBBUl9FTDEpOworICAgIHBhciA9IHJlYWRfc3lzcmVnX3BhcigpOwogICAg IFdSSVRFX1NZU1JFRzY0KHRtcCwgUEFSX0VMMSk7CiAgICAgcmV0dXJuIHBh cjsKIH0KQEAgLTYwLDI4ICs2MCwyOCBAQCBzdGF0aWMgaW5saW5lIHVpbnQ2 NF90IF9fdmFfdG9fcGFyKHZhZGRyX3QgdmEpCiAvKiBBc2sgdGhlIE1NVSB0 byB0cmFuc2xhdGUgYSBHdWVzdCBWQSBmb3IgdXMgKi8KIHN0YXRpYyBpbmxp bmUgdWludDY0X3QgZ3ZhX3RvX21hX3Bhcih2YWRkcl90IHZhLCB1bnNpZ25l ZCBpbnQgZmxhZ3MpCiB7Ci0gICAgdWludDY0X3QgcGFyLCB0bXAgPSBSRUFE X1NZU1JFRzY0KFBBUl9FTDEpOworICAgIHVpbnQ2NF90IHBhciwgdG1wID0g cmVhZF9zeXNyZWdfcGFyKCk7CiAKICAgICBpZiAoIChmbGFncyAmIEdWMk1f V1JJVEUpID09IEdWMk1fV1JJVEUgKQogICAgICAgICBhc20gdm9sYXRpbGUg KCJhdCBzMTJlMXcsICUwOyIgOiA6ICJyIiAodmEpKTsKICAgICBlbHNlCiAg ICAgICAgIGFzbSB2b2xhdGlsZSAoImF0IHMxMmUxciwgJTA7IiA6IDogInIi ICh2YSkpOwogICAgIGlzYigpOwotICAgIHBhciA9IFJFQURfU1lTUkVHNjQo UEFSX0VMMSk7CisgICAgcGFyID0gcmVhZF9zeXNyZWdfcGFyKCk7CiAgICAg V1JJVEVfU1lTUkVHNjQodG1wLCBQQVJfRUwxKTsKICAgICByZXR1cm4gcGFy OwogfQogCiBzdGF0aWMgaW5saW5lIHVpbnQ2NF90IGd2YV90b19pcGFfcGFy KHZhZGRyX3QgdmEsIHVuc2lnbmVkIGludCBmbGFncykKIHsKLSAgICB1aW50 NjRfdCBwYXIsIHRtcCA9IFJFQURfU1lTUkVHNjQoUEFSX0VMMSk7CisgICAg dWludDY0X3QgcGFyLCB0bXAgPSByZWFkX3N5c3JlZ19wYXIoKTsKIAogICAg IGlmICggKGZsYWdzICYgR1YyTV9XUklURSkgPT0gR1YyTV9XUklURSApCiAg ICAgICAgIGFzbSB2b2xhdGlsZSAoImF0IHMxZTF3LCAlMDsiIDogOiAiciIg KHZhKSk7CiAgICAgZWxzZQogICAgICAgICBhc20gdm9sYXRpbGUgKCJhdCBz MWUxciwgJTA7IiA6IDogInIiICh2YSkpOwogICAgIGlzYigpOwotICAgIHBh ciA9IFJFQURfU1lTUkVHNjQoUEFSX0VMMSk7CisgICAgcGFyID0gcmVhZF9z eXNyZWdfcGFyKCk7CiAgICAgV1JJVEVfU1lTUkVHNjQodG1wLCBQQVJfRUwx KTsKICAgICByZXR1cm4gcGFyOwogfQpkaWZmIC0tZ2l0IGEveGVuL2luY2x1 ZGUvYXNtLWFybS9jcHVmZWF0dXJlLmggYi94ZW4vaW5jbHVkZS9hc20tYXJt L2NwdWZlYXR1cmUuaAppbmRleCBkNGU3Y2RlNjc1ZTUuLjQxYWNhOWM1OGM2 ZCAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9jcHVmZWF0dXJl LmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9jcHVmZWF0dXJlLmgKQEAg LTUzLDggKzUzLDkgQEAKICNkZWZpbmUgQVJNX1dPUktBUk9VTkRfQkhCX0xP T1BfMjQgMTMKICNkZWZpbmUgQVJNX1dPUktBUk9VTkRfQkhCX0xPT1BfMzIg MTQKICNkZWZpbmUgQVJNX1dPUktBUk9VTkRfQkhCX1NNQ0NfMyAxNQorI2Rl ZmluZSBBUk02NF9XT1JLQVJPVU5EXzE1MDg0MTIgMTYKIAotI2RlZmluZSBB Uk1fTkNBUFMgICAgICAgICAgIDE2CisjZGVmaW5lIEFSTV9OQ0FQUyAgICAg ICAgICAgMTcKIAogI2lmbmRlZiBfX0FTU0VNQkxZX18KIApkaWZmIC0tZ2l0 IGEveGVuL2luY2x1ZGUvYXNtLWFybS9zeXNyZWdzLmggYi94ZW4vaW5jbHVk ZS9hc20tYXJtL3N5c3JlZ3MuaAppbmRleCA1YzVjNTFiYmNkYmYuLjYxZTMw YzllNTE3YyAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9zeXNy ZWdzLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9zeXNyZWdzLmgKQEAg LTksNiArOSwzMCBAQAogIyBlcnJvciAidW5rbm93biBBUk0gdmFyaWFudCIK ICNlbmRpZgogCisjaWZuZGVmIF9fQVNTRU1CTFlfXworCisjaW5jbHVkZSA8 YXNtL2FsdGVybmF0aXZlLmg+CisKK3N0YXRpYyBpbmxpbmUgcmVnaXN0ZXJf dCByZWFkX3N5c3JlZ19wYXIodm9pZCkKK3sKKyAgICByZWdpc3Rlcl90IHBh cl9lbDE7CisKKyAgICAvKgorICAgICAqIE9uIENvcnRleC1BNzcgcjBwMCBh bmQgcjFwMCwgcmVhZCBhY2Nlc3MgdG8gUEFSX0VMMSBzaGFsbCBpbmNsdWRl IGEKKyAgICAgKiBETUIgU1kgYmVmb3JlIGFuZCBhZnRlciBhY2Nlc3Npbmcg aXQsIGFzIHBhcnQgb2YgdGhlIHdvcmthcm91bmQgZm9yIHRoZQorICAgICAq IGVycmF0YSAxNTA4NDEyLgorICAgICAqLworICAgIGFzbSB2b2xhdGlsZShB TFRFUk5BVElWRSgibm9wIiwgImRtYiBzeSIsIEFSTTY0X1dPUktBUk9VTkRf MTUwODQxMiwKKyAgICAgICAgICAgICAgICAgQ09ORklHX0FSTTY0X0VSUkFU VU1fMTUwODQxMikpOworICAgIHBhcl9lbDEgPSBSRUFEX1NZU1JFRzY0KFBB Ul9FTDEpOworICAgIGFzbSB2b2xhdGlsZShBTFRFUk5BVElWRSgibm9wIiwg ImRtYiBzeSIsIEFSTTY0X1dPUktBUk9VTkRfMTUwODQxMiwKKyAgICAgICAg ICAgICAgICAgQ09ORklHX0FSTTY0X0VSUkFUVU1fMTUwODQxMikpOworCisg ICAgcmV0dXJuIHBhcl9lbDE7Cit9CisKKyNlbmRpZiAvKiAgIV9fQVNTRU1C TFlfXyAgKi8KKwogI2VuZGlmIC8qIF9fQVNNX0FSTV9TWVNSRUdTX0ggKi8K IC8qCiAgKiBMb2NhbCB2YXJpYWJsZXM6Ci0tIAoyLjQwLjEKCg== --=separator Content-Type: application/octet-stream; name="xsa436/xsa436-4.16.patch" Content-Disposition: attachment; filename="xsa436/xsa436-4.16.patch" Content-Transfer-Encoding: base64 RnJvbSA1MDgzYjhiNGE0MjVjNjQ4MjBhYzEwNmNlMGY3OWNjNWFmMTk1YjVi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBMdWNhIEZhbmNlbGx1 IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+CkRhdGU6IE1vbiwgMTcgSnVsIDIw MjMgMTM6MjU6NDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSB4ZW4vYXJtOiBB ZGQgQ29ydGV4LUE3NyBlcnJhdHVtIDE1MDg0MTIgaGFuZGxpbmcKCkNvcnRl eC1BNzcgY29yZXMgKHIwcDAsIHIxcDApIGNvdWxkIGRlYWRsb2NrIG9uIGEg c2VxdWVuY2Ugb2YgYQpzdG9yZS1leGNsdXNpdmUgb3IgcmVhZCBvZiBQQVJf RUwxIGFuZCBhIGxvYWQgd2l0aCBkZXZpY2Ugb3Igbm9uLWNhY2hlYWJsZQpt ZW1vcnkgYXR0cmlidXRlcy4KQSB3b3JrYXJvdW5kIGlzIGF2YWlsYWJsZSwg YnV0IGl0IGRlcGVuZHMgb24gYSBmaXJtd2FyZSBjb3VudGVycGFydC4KClRo ZSBwcm9wb3NlZCB3b3JrYXJvdW5kIGZyb20gdGhlIGVycmF0YSBkb2N1bWVu dCBpcyB0byBtb2RpZnkgdGhlIHNvZnR3YXJlCnJ1bm5pbmcgYXQgRUwxIGFu ZCBhYm92ZSB0byBpbmNsdWRlIGEgRE1CIFNZIGJlZm9yZSBhbmQgYWZ0ZXIg YWNjZXNzaW5nClBBUl9FTDEuCgpJbiBjb25qdW5jdGlvbiB0byB0aGUgYWJv dmUsIHRoZSBmaXJtd2FyZSBuZWVkcyB0byB1c2UgYSBzcGVjaWZpYyB3cml0 ZQpzZXF1ZW5jZSB0byBzZXZlcmFsIElNUExFTUVOVEFUSU9OIERFRklORUQg cmVnaXN0ZXJzIHRvIGhhdmUgdGhlIGhhcmR3YXJlCmluc2VydCBhIERNQiBT WSBhZnRlciBhbGwgbG9hZC1leGNsdXNpdmUgYW5kIHN0b3JlLWV4Y2x1c2l2 ZSBpbnN0cnVjdGlvbnMuCgpBcHBseSB0aGUgd29ya2Fyb3VuZCB0byBYZW4g d2hlcmUgUEFSX0VMMSBpcyByZWFkLCBpbXBsZW1lbnRpbmcgYW4gaGVscGVy CmZ1bmN0aW9uIHRvIGRvIHRoYXQuClNpbmNlIFhlbiBjYW4gYmUgaW50ZXJy dXB0ZWQgYnkgaXJxcyBpbiBhbnkgbW9tZW50LCBhZGQgYSBiYXJyaWVyIG9u CmVudHJ5L2V4aXQgd2hlbiB3ZSBhcmUgcnVubmluZyBvbiB0aGUgYWZmZWN0 ZWQgY29yZXMuCgpBIGd1ZXN0IHdpdGhvdXQgdGhlIHdvcmthcm91bmQgY2Fu IGRlYWRsb2NrIHRoZSBzeXN0ZW0sIHNvIHdhcm4gdGhlIHVzZXJzCm9mIFhl biB3aXRoIHRoZSBhYm92ZSB0eXBlIG9mIGNvcmVzIHRvIHVzZSBvbmx5IHRy dXN0ZWQgZ3Vlc3RzLCBieQpwcmludGluZyBhIG1lc3NhZ2Ugb24gWGVuIHN0 YXJ0dXAuCgpTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZh bmNlbGx1QGFybS5jb20+ClJldmlld2VkLWJ5OiBCZXJ0cmFuZCBNYXJxdWlz IDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+ClJldmlld2VkLWJ5OiBKdWxp ZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPgotLS0KIFNVUFBPUlQubWQg ICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysKIGRvY3MvbWlzYy9hcm0v c2lsaWNvbi1lcnJhdGEudHh0IHwgIDEgKwogeGVuL2FyY2gvYXJtL0tjb25m aWcgICAgICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysrKysKIHhl bi9hcmNoL2FybS9hcm02NC9lbnRyeS5TICAgICAgIHwgMTkgKysrKysrKysr KysrKysrKysrKwogeGVuL2FyY2gvYXJtL2NwdWVycmF0YS5jICAgICAgICAg fCAxNiArKysrKysrKysrKystLS0tCiB4ZW4vYXJjaC9hcm0vZG9tYWluLmMg ICAgICAgICAgICB8ICAyICstCiB4ZW4vaW5jbHVkZS9hc20tYXJtL2FybTY0 L3BhZ2UuaCB8IDEyICsrKysrKy0tLS0tLQogeGVuL2luY2x1ZGUvYXNtLWFy bS9jcHVmZWF0dXJlLmggfCAgMyArKy0KIHhlbi9pbmNsdWRlL2FzbS1hcm0v c3lzcmVncy5oICAgIHwgMjQgKysrKysrKysrKysrKysrKysrKysrKysrCiA5 IGZpbGVzIGNoYW5nZWQsIDg4IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NVUFBPUlQubWQgYi9TVVBQT1JULm1kCmlu ZGV4IDg1NzI2MTAyZWFiOC4uNzhhOTMxNTllM2RhIDEwMDY0NAotLS0gYS9T VVBQT1JULm1kCisrKyBiL1NVUFBPUlQubWQKQEAgLTM5LDggKzM5LDEwIEBA IHN1cHBvcnRlZCBpbiB0aGlzIGRvY3VtZW50LgogCiAgICAgU3RhdHVzOiBT dXBwb3J0ZWQKICAgICBTdGF0dXMsIENvcnRleCBBNTcgcjBwMC1yMXAxOiBT dXBwb3J0ZWQsIG5vdCBzZWN1cml0eSBzdXBwb3J0ZWQKKyAgICBTdGF0dXMs IENvcnRleCBBNzcgcjBwMC1yMXAwOiBTdXBwb3J0ZWQsIG5vdCBzZWN1cml0 eSBzdXBwb3J0ZWQKIAogRm9yIHRoZSBDb3J0ZXggQTU3IHIwcDAgLSByMXAx LCBzZWUgRXJyYXRhIDgzMjA3NS4KK0ZvciB0aGUgQ29ydGV4IEE3NyByMHAw IC0gcjFwMCwgc2VlIEVycmF0YSAxNTA4NDEyLgogCiAjIyBIb3N0IGhhcmR3 YXJlIHN1cHBvcnQKIApkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2FybS9zaWxp Y29uLWVycmF0YS50eHQgYi9kb2NzL21pc2MvYXJtL3NpbGljb24tZXJyYXRh LnR4dAppbmRleCAxOTI1ZDhmZDRlZTAuLmM0ZTgyZGY1MzU2NiAxMDA2NDQK LS0tIGEvZG9jcy9taXNjL2FybS9zaWxpY29uLWVycmF0YS50eHQKKysrIGIv ZG9jcy9taXNjL2FybS9zaWxpY29uLWVycmF0YS50eHQKQEAgLTU4LDQgKzU4 LDUgQEAgc3RhYmxlIGh5cGVydmlzb3JzLgogfCBBUk0gICAgICAgICAgICB8 IENvcnRleC1BNzYgICAgICB8ICMxMjg2ODA3ICAgICAgICB8IEFSTTY0X0VS UkFUVU1fMTI4NjgwNyAgIHwKIHwgQVJNICAgICAgICAgICAgfCBOZW92ZXJz ZS1OMSAgICAgfCAjMTE2NTUyMiAgICAgICAgfCBOL0EKIHwgQVJNICAgICAg ICAgICAgfCBOZW92ZXJzZS1OMSAgICAgfCAjMTI4NjgwNyAgICAgICAgfCBB Uk02NF9FUlJBVFVNXzEyODY4MDcgICB8Cit8IEFSTSAgICAgICAgICAgIHwg Q29ydGV4LUE3NyAgICAgIHwgIzE1MDg0MTIgICAgICAgIHwgQVJNNjRfRVJS QVRVTV8xNTA4NDEyICAgfAogfCBBUk0gICAgICAgICAgICB8IE1NVS01MDAg ICAgICAgICB8ICM4NDI4NjkgICAgICAgICB8IE4vQSAgICAgICAgICAgICAg ICAgICAgIHwKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9LY29uZmlnIGIv eGVuL2FyY2gvYXJtL0tjb25maWcKaW5kZXggZWNmYTY4MjJlNGQzLi5jNzg3 YTA0MmEwYTIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmlnCisr KyBiL3hlbi9hcmNoL2FybS9LY29uZmlnCkBAIC0yNzgsNiArMjc4LDI3IEBA IGNvbmZpZyBBUk02NF9FUlJBVFVNXzEyODY4MDcKIAogCSAgSWYgdW5zdXJl LCBzYXkgWS4KIAorY29uZmlnIEFSTTY0X0VSUkFUVU1fMTUwODQxMgorCWJv b2wgIkNvcnRleC1BNzc6IDE1MDg0MTI6IHBvc3NpYmxlIGRlYWRsb2NrIG9u IHNlcXVlbmNlIG9mIE5DL0RldmljZSBsb2FkIGFuZCBzdG9yZSBleGNsdXNp dmUgb3IgUEFSIHJlYWQiCisJZGVmYXVsdCB5CisJZGVwZW5kcyBvbiBBUk1f NjQKKwloZWxwCisJICBUaGlzIG9wdGlvbiBhZGRzIGEgd29ya2Fyb3VuZCBm b3IgQXJtIENvcnRleC1BNzcgZXJyYXR1bSAxNTA4NDEyLgorCisJICBBZmZl Y3RlZCBDb3J0ZXgtQTc3IGNvcmVzIChyMHAwLCByMXAwKSBjb3VsZCBkZWFk bG9jayBvbiBhIHNlcXVlbmNlCisJICBvZiBhIHN0b3JlLWV4Y2x1c2l2ZSBv ciByZWFkIG9mIFBBUl9FTDEgYW5kIGEgbG9hZCB3aXRoIGRldmljZSBvcgor CSAgbm9uLWNhY2hlYWJsZSBtZW1vcnkgYXR0cmlidXRlcy4gVGhlIHdvcmth cm91bmQgZGVwZW5kcyBvbiBhIGZpcm13YXJlCisJICBjb3VudGVycGFydC4K KworCSAgWGVuIGd1ZXN0cyBtdXN0IGFsc28gaGF2ZSB0aGUgd29ya2Fyb3Vu ZCBpbXBsZW1lbnRlZCBvciB0aGV5IGNhbgorCSAgZGVhZGxvY2sgdGhlIHN5 c3RlbS4KKworCSAgV29yayBhcm91bmQgdGhlIGlzc3VlIGJ5IGluc2VydGlu ZyBETUIgU1kgYmFycmllcnMgYXJvdW5kIFBBUl9FTDEKKwkgIHJlZ2lzdGVy IHJlYWRzIGFuZCB3YXJuaW5nIFhlbiB1c2Vycy4gVGhlIERNQiBiYXJyaWVy IGlzIHN1ZmZpY2llbnQKKwkgIHRvIHByZXZlbnQgYSBzcGVjdWxhdGl2ZSBQ QVJfRUwxIHJlYWQuCisKKwkgIElmIHVuc3VyZSwgc2F5IFkuCisKIGVuZG1l bnUKIAogY29uZmlnIEFSTTY0X0hBUkRFTl9CUkFOQ0hfUFJFRElDVE9SCmRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvZW50cnkuUyBiL3hlbi9h cmNoL2FybS9hcm02NC9lbnRyeS5TCmluZGV4IDk1ZjFhOTI2ODQxOS4uOTVm ZjRlM2UwNTE3IDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vYXJtNjQvZW50 cnkuUworKysgYi94ZW4vYXJjaC9hcm0vYXJtNjQvZW50cnkuUwpAQCAtMTM0 LDYgKzEzNCwxNiBAQAogICogcG9zaXRpb24gb24gdGhlIHN0YWNrIGJlZm9y ZS4KICAqLwogICAgICAgICAubWFjcm8gIGVudHJ5LCBoeXAsIGNvbXBhdCwg c2F2ZV94MF94MT0xCisKKyAgICAgICAgLyoKKyAgICAgICAgICogRW5zdXJl IGFueSBQQVJfRUwxIHJlYWRzIGNvbXBsZXRlLCBpbiBjYXNlIHdlIHdlcmUg aW50ZXJydXB0ZWQKKyAgICAgICAgICogYmV0d2VlbiB0aGUgUEFSX0VMMSBy ZWFkIGFuZCB0aGUgbWVtb3J5IGJhcnJpZXIgZm9yIHRoZSBlcnJhdHVtCisg ICAgICAgICAqIDE1MDg0MTIgd29ya2Fyb3VuZC4KKyAgICAgICAgICovCisg ICAgICAgIGFsdGVybmF0aXZlX2lmIEFSTTY0X1dPUktBUk9VTkRfMTUwODQx MgorICAgICAgICBkbWIgc3kKKyAgICAgICAgYWx0ZXJuYXRpdmVfZWxzZV9u b3BfZW5kaWYKKwogICAgICAgICBzdWIgICAgIHNwLCBzcCwgIyhVUkVHU19T UFNSX2VsMSAtIFVSRUdTX0xSKSAvKiBDUFNSLCBQQywgU1AsIExSICovCiAK ICAgICAgICAgLmlmIFxoeXAgPT0gMCAgICAgICAgIC8qIEd1ZXN0IG1vZGUg Ki8KQEAgLTQ5Miw2ICs1MDIsMTUgQEAgcmV0dXJuX2Zyb21fdHJhcDoKIAog ICAgICAgICBsZHIgICAgIGxyLCBbc3BdLCAjKFVSRUdTX1NQU1JfZWwxIC0g VVJFR1NfTFIpIC8qIENQU1IsIFBDLCBTUCwgTFIgKi8KIAorICAgICAgICAv KgorICAgICAgICAgKiBFbnN1cmUgYW55IGRldmljZS9OQyByZWFkcyBjb21w bGV0ZSwgaW4gY2FzZSB3ZSB3ZXJlIGludGVycnVwdGVkCisgICAgICAgICAq IGJldHdlZW4gdGhlIG1lbW9yeSBiYXJyaWVyIGZvciB0aGUgZXJyYXR1bSAx NTA4NDEyIHdvcmthcm91bmQgYW5kCisgICAgICAgICAqIGFueSBQQVJfRUwx IHJlYWQuCisgICAgICAgICAqLworICAgICAgICBhbHRlcm5hdGl2ZV9pZiBB Uk02NF9XT1JLQVJPVU5EXzE1MDg0MTIKKyAgICAgICAgZG1iIHN5CisgICAg ICAgIGFsdGVybmF0aXZlX2Vsc2Vfbm9wX2VuZGlmCisKICAgICAgICAgZXJl dAogICAgICAgICBzYgogCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vY3B1 ZXJyYXRhLmMgYi94ZW4vYXJjaC9hcm0vY3B1ZXJyYXRhLmMKaW5kZXggYWU2 NDlkMTZlZjAyLi5lYTY4MGZhYzJlNDQgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNo L2FybS9jcHVlcnJhdGEuYworKysgYi94ZW4vYXJjaC9hcm0vY3B1ZXJyYXRh LmMKQEAgLTY2OCw2ICs2NjgsMTQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBh cm1fY3B1X2NhcGFiaWxpdGllcyBhcm1fZXJyYXRhW10gPSB7CiAgICAgICAg IC5jYXBhYmlsaXR5ID0gQVJNNjRfV09SS0FST1VORF9BVF9TUEVDVUxBVEUs CiAgICAgICAgIE1JRFJfQUxMX1ZFUlNJT05TKE1JRFJfQ09SVEVYX0E1Nyks CiAgICAgfSwKKyNpZmRlZiBDT05GSUdfQVJNNjRfRVJSQVRVTV8xNTA4NDEy CisgICAgeworICAgICAgICAvKiBDb3J0ZXgtQTc3IHIwcDAgLSByMXAwICov CisgICAgICAgIC5kZXNjID0gIkFSTSBlcnJhdHVtIDE1MDg0MTIgKGh5cGVy dmlzb3IgcG9ydGlvbikiLAorICAgICAgICAuY2FwYWJpbGl0eSA9IEFSTTY0 X1dPUktBUk9VTkRfMTUwODQxMiwKKyAgICAgICAgTUlEUl9SQU5HRShNSURS X0NPUlRFWF9BNzcsIDAsIDEpLAorICAgIH0sCisjZW5kaWYKICAgICB7CiAg ICAgICAgIC8qIENvcnRleC1BNTUgKEFsbCB2ZXJzaW9ucyBhcyBlcnJhdHVt IGlzIG9wZW4gaW4gU0RFTiB2MTQpICovCiAgICAgICAgIC5kZXNjID0gIkFS TSBlcnJhdHVtIDE1MzA5MjMiLApAQCAtNjg2LDExICs2OTQsMTEgQEAgdm9p ZCBfX2luaXQgZW5hYmxlX2VycmF0YV93b3JrYXJvdW5kcyh2b2lkKQogewog ICAgIGVuYWJsZV9jcHVfY2FwYWJpbGl0aWVzKGFybV9lcnJhdGEpOwogCi0j aWZkZWYgQ09ORklHX0FSTTY0X0VSUkFUVU1fODMyMDc1Ci0gICAgaWYgKCBj cHVzX2hhdmVfY2FwKEFSTTY0X1dPUktBUk9VTkRfREVWSUNFX0xPQURfQUNR VUlSRSkgKQorI2lmIGRlZmluZWQoQ09ORklHX0FSTTY0X0VSUkFUVU1fODMy MDc1KSB8fCBkZWZpbmVkKENPTkZJR19BUk02NF9FUlJBVFVNXzE1MDg0MTIp CisgICAgaWYgKCBjcHVzX2hhdmVfY2FwKEFSTTY0X1dPUktBUk9VTkRfREVW SUNFX0xPQURfQUNRVUlSRSkgfHwKKyAgICAgICAgIGNwdXNfaGF2ZV9jYXAo QVJNNjRfV09SS0FST1VORF8xNTA4NDEyKSApCiAgICAgewotICAgICAgICBw cmludGtfb25jZSgiKioqKiBUaGlzIENQVSBpcyBhZmZlY3RlZCBieSB0aGUg ZXJyYXRhIDgzMjA3NS4gICAgICAgICAgICAgICAgICAgICAgKioqKlxuIgot ICAgICAgICAgICAgICAgICAgICAiKioqKiBHdWVzdHMgd2l0aG91dCBDUFUg ZXJyYXR1bSB3b3JrYXJvdW5kcyBjYW4gZGVhZGxvY2sgdGhlIHN5c3RlbSEg KioqKlxuIgorICAgICAgICBwcmludGtfb25jZSgiKioqKiBHdWVzdHMgd2l0 aG91dCBDUFUgZXJyYXR1bSB3b3JrYXJvdW5kcyBjYW4gZGVhZGxvY2sgdGhl IHN5c3RlbSEgKioqKlxuIgogICAgICAgICAgICAgICAgICAgICAiKioqKiBP bmx5IHRydXN0ZWQgZ3Vlc3RzIHNob3VsZCBiZSB1c2VkLiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKioqKlxuIik7CiAKICAgICAgICAgLyogVGFp bnQgdGhlIG1hY2hpbmUgaGFzIGJlaW5nIGluc2VjdXJlICovCmRpZmYgLS1n aXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMgYi94ZW4vYXJjaC9hcm0vZG9t YWluLmMKaW5kZXggOTZlMWIyMzU1MDFkLi5jYjFkNTRiYTg1NDkgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYworKysgYi94ZW4vYXJjaC9h cm0vZG9tYWluLmMKQEAgLTEzNyw3ICsxMzcsNyBAQCBzdGF0aWMgdm9pZCBj dHh0X3N3aXRjaF9mcm9tKHN0cnVjdCB2Y3B1ICpwKQogICAgIHAtPmFyY2gu dHRicjEgPSBSRUFEX1NZU1JFRzY0KFRUQlIxX0VMMSk7CiAgICAgaWYgKCBp c18zMmJpdF9kb21haW4ocC0+ZG9tYWluKSApCiAgICAgICAgIHAtPmFyY2gu ZGFjciA9IFJFQURfU1lTUkVHKERBQ1IzMl9FTDIpOwotICAgIHAtPmFyY2gu cGFyID0gUkVBRF9TWVNSRUc2NChQQVJfRUwxKTsKKyAgICBwLT5hcmNoLnBh ciA9IHJlYWRfc3lzcmVnX3BhcigpOwogI2lmIGRlZmluZWQoQ09ORklHX0FS TV8zMikKICAgICBwLT5hcmNoLm1haXIwID0gUkVBRF9DUDMyKE1BSVIwKTsK ICAgICBwLT5hcmNoLm1haXIxID0gUkVBRF9DUDMyKE1BSVIxKTsKZGlmZiAt LWdpdCBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vYXJtNjQvcGFnZS5oIGIveGVu L2luY2x1ZGUvYXNtLWFybS9hcm02NC9wYWdlLmgKaW5kZXggMGNiYTI2NjM3 MzNiLi5mYmZlNjdiZjg5NTEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2Fz bS1hcm0vYXJtNjQvcGFnZS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0v YXJtNjQvcGFnZS5oCkBAIC00OCwxMSArNDgsMTEgQEAgc3RhdGljIGlubGlu ZSB2b2lkIGludmFsaWRhdGVfaWNhY2hlX2xvY2FsKHZvaWQpCiAvKiBBc2sg dGhlIE1NVSB0byB0cmFuc2xhdGUgYSBWQSBmb3IgdXMgKi8KIHN0YXRpYyBp bmxpbmUgdWludDY0X3QgX192YV90b19wYXIodmFkZHJfdCB2YSkKIHsKLSAg ICB1aW50NjRfdCBwYXIsIHRtcCA9IFJFQURfU1lTUkVHNjQoUEFSX0VMMSk7 CisgICAgdWludDY0X3QgcGFyLCB0bXAgPSByZWFkX3N5c3JlZ19wYXIoKTsK IAogICAgIGFzbSB2b2xhdGlsZSAoImF0IHMxZTJyLCAlMDsiIDogOiAiciIg KHZhKSk7CiAgICAgaXNiKCk7Ci0gICAgcGFyID0gUkVBRF9TWVNSRUc2NChQ QVJfRUwxKTsKKyAgICBwYXIgPSByZWFkX3N5c3JlZ19wYXIoKTsKICAgICBX UklURV9TWVNSRUc2NCh0bXAsIFBBUl9FTDEpOwogICAgIHJldHVybiBwYXI7 CiB9CkBAIC02MCwyOCArNjAsMjggQEAgc3RhdGljIGlubGluZSB1aW50NjRf dCBfX3ZhX3RvX3Bhcih2YWRkcl90IHZhKQogLyogQXNrIHRoZSBNTVUgdG8g dHJhbnNsYXRlIGEgR3Vlc3QgVkEgZm9yIHVzICovCiBzdGF0aWMgaW5saW5l IHVpbnQ2NF90IGd2YV90b19tYV9wYXIodmFkZHJfdCB2YSwgdW5zaWduZWQg aW50IGZsYWdzKQogewotICAgIHVpbnQ2NF90IHBhciwgdG1wID0gUkVBRF9T WVNSRUc2NChQQVJfRUwxKTsKKyAgICB1aW50NjRfdCBwYXIsIHRtcCA9IHJl YWRfc3lzcmVnX3BhcigpOwogCiAgICAgaWYgKCAoZmxhZ3MgJiBHVjJNX1dS SVRFKSA9PSBHVjJNX1dSSVRFICkKICAgICAgICAgYXNtIHZvbGF0aWxlICgi YXQgczEyZTF3LCAlMDsiIDogOiAiciIgKHZhKSk7CiAgICAgZWxzZQogICAg ICAgICBhc20gdm9sYXRpbGUgKCJhdCBzMTJlMXIsICUwOyIgOiA6ICJyIiAo dmEpKTsKICAgICBpc2IoKTsKLSAgICBwYXIgPSBSRUFEX1NZU1JFRzY0KFBB Ul9FTDEpOworICAgIHBhciA9IHJlYWRfc3lzcmVnX3BhcigpOwogICAgIFdS SVRFX1NZU1JFRzY0KHRtcCwgUEFSX0VMMSk7CiAgICAgcmV0dXJuIHBhcjsK IH0KIAogc3RhdGljIGlubGluZSB1aW50NjRfdCBndmFfdG9faXBhX3Bhcih2 YWRkcl90IHZhLCB1bnNpZ25lZCBpbnQgZmxhZ3MpCiB7Ci0gICAgdWludDY0 X3QgcGFyLCB0bXAgPSBSRUFEX1NZU1JFRzY0KFBBUl9FTDEpOworICAgIHVp bnQ2NF90IHBhciwgdG1wID0gcmVhZF9zeXNyZWdfcGFyKCk7CiAKICAgICBp ZiAoIChmbGFncyAmIEdWMk1fV1JJVEUpID09IEdWMk1fV1JJVEUgKQogICAg ICAgICBhc20gdm9sYXRpbGUgKCJhdCBzMWUxdywgJTA7IiA6IDogInIiICh2 YSkpOwogICAgIGVsc2UKICAgICAgICAgYXNtIHZvbGF0aWxlICgiYXQgczFl MXIsICUwOyIgOiA6ICJyIiAodmEpKTsKICAgICBpc2IoKTsKLSAgICBwYXIg PSBSRUFEX1NZU1JFRzY0KFBBUl9FTDEpOworICAgIHBhciA9IHJlYWRfc3lz cmVnX3BhcigpOwogICAgIFdSSVRFX1NZU1JFRzY0KHRtcCwgUEFSX0VMMSk7 CiAgICAgcmV0dXJuIHBhcjsKIH0KZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L2FzbS1hcm0vY3B1ZmVhdHVyZS5oIGIveGVuL2luY2x1ZGUvYXNtLWFybS9j cHVmZWF0dXJlLmgKaW5kZXggZjczNjg3NjZjMDdjLi4yZjM4MTM3ZjM5ZDUg MTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vY3B1ZmVhdHVyZS5o CisrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vY3B1ZmVhdHVyZS5oCkBAIC02 Nyw4ICs2Nyw5IEBACiAjZGVmaW5lIEFSTV9XT1JLQVJPVU5EX0JIQl9MT09Q XzI0IDEzCiAjZGVmaW5lIEFSTV9XT1JLQVJPVU5EX0JIQl9MT09QXzMyIDE0 CiAjZGVmaW5lIEFSTV9XT1JLQVJPVU5EX0JIQl9TTUNDXzMgMTUKKyNkZWZp bmUgQVJNNjRfV09SS0FST1VORF8xNTA4NDEyIDE2CiAKLSNkZWZpbmUgQVJN X05DQVBTICAgICAgICAgICAxNgorI2RlZmluZSBBUk1fTkNBUFMgICAgICAg ICAgIDE3CiAKICNpZm5kZWYgX19BU1NFTUJMWV9fCiAKZGlmZiAtLWdpdCBh L3hlbi9pbmNsdWRlL2FzbS1hcm0vc3lzcmVncy5oIGIveGVuL2luY2x1ZGUv YXNtLWFybS9zeXNyZWdzLmgKaW5kZXggNWM1YzUxYmJjZGJmLi42MWUzMGM5 ZTUxN2MgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vc3lzcmVn cy5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vc3lzcmVncy5oCkBAIC05 LDYgKzksMzAgQEAKICMgZXJyb3IgInVua25vd24gQVJNIHZhcmlhbnQiCiAj ZW5kaWYKIAorI2lmbmRlZiBfX0FTU0VNQkxZX18KKworI2luY2x1ZGUgPGFz bS9hbHRlcm5hdGl2ZS5oPgorCitzdGF0aWMgaW5saW5lIHJlZ2lzdGVyX3Qg cmVhZF9zeXNyZWdfcGFyKHZvaWQpCit7CisgICAgcmVnaXN0ZXJfdCBwYXJf ZWwxOworCisgICAgLyoKKyAgICAgKiBPbiBDb3J0ZXgtQTc3IHIwcDAgYW5k IHIxcDAsIHJlYWQgYWNjZXNzIHRvIFBBUl9FTDEgc2hhbGwgaW5jbHVkZSBh CisgICAgICogRE1CIFNZIGJlZm9yZSBhbmQgYWZ0ZXIgYWNjZXNzaW5nIGl0 LCBhcyBwYXJ0IG9mIHRoZSB3b3JrYXJvdW5kIGZvciB0aGUKKyAgICAgKiBl cnJhdGEgMTUwODQxMi4KKyAgICAgKi8KKyAgICBhc20gdm9sYXRpbGUoQUxU RVJOQVRJVkUoIm5vcCIsICJkbWIgc3kiLCBBUk02NF9XT1JLQVJPVU5EXzE1 MDg0MTIsCisgICAgICAgICAgICAgICAgIENPTkZJR19BUk02NF9FUlJBVFVN XzE1MDg0MTIpKTsKKyAgICBwYXJfZWwxID0gUkVBRF9TWVNSRUc2NChQQVJf RUwxKTsKKyAgICBhc20gdm9sYXRpbGUoQUxURVJOQVRJVkUoIm5vcCIsICJk bWIgc3kiLCBBUk02NF9XT1JLQVJPVU5EXzE1MDg0MTIsCisgICAgICAgICAg ICAgICAgIENPTkZJR19BUk02NF9FUlJBVFVNXzE1MDg0MTIpKTsKKworICAg IHJldHVybiBwYXJfZWwxOworfQorCisjZW5kaWYgLyogICFfX0FTU0VNQkxZ X18gICovCisKICNlbmRpZiAvKiBfX0FTTV9BUk1fU1lTUkVHU19IICovCiAv KgogICogTG9jYWwgdmFyaWFibGVzOgotLSAKMi40MC4xCgo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:50:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:50:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574346.899596 (Exim 4.92) (envelope-from ) id 1qQqhl-0005K6-I1; Tue, 01 Aug 2023 14:50:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574346.899596; Tue, 01 Aug 2023 14:50:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqhl-0005Jz-EP; Tue, 01 Aug 2023 14:50:33 +0000 Received: by outflank-mailman (input) for mailman id 574346; Tue, 01 Aug 2023 14:50:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqhj-0005Jr-VB for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:50:32 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0622.outbound.protection.outlook.com [2a01:111:f400:fe1f::622]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1e83bdd-307a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:50:29 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9865.eurprd04.prod.outlook.com (2603:10a6:10:4f0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 14:50:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.026; Tue, 1 Aug 2023 14:50:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1e83bdd-307a-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cB5X9TaytQilnF7vBZiIiZ40c4ZHlcvtsQNSjcq8lcLgWcdrvNzEOh5GOmIuSD8FfnbROZCy5QcZk2rIeySQq+z910d54Mg50c3e1F13iMxD97ZhFGaZSxzW3APRGw196ZNe6pR0HPqh27AJrhnm4BUEuYWIp5vXx7S67HgIHePRxLbfImnIOv/z0StGEHw4qv1nDcdX6FxF6wwGkutnFUqaEL7fxU2/T/tbvOiAiycy1PrXVBVjSMGPp2CHIFba/iox2Rj4uKWzMdliEvi1ZhaNoCUPymPBYk3BvaYxUHDFSaGU26dYuXaVCx7B4Mc38Aba9rRic1r11P0ewtk4QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gs1JOrX2quhXPpOm/hsB2Y/9bXV8kVqK94dVS7bKTWY=; b=NvbooTn/81BL+u/Fsrd7NLGr0MA+cyzCepFKahPBbtjTRjOKWVFG9D8OF3G5XXEfa+hUddd+CsxLDL4UJFlAfjQeFk6xSwIWgz6uwikRh1uag0RxkpuaxKLvYPLd5ef2vjLi1Q6ABr2vLdOAG5H3+V8BpgI3x3K3oBsJmxdcEaiWXW5l1xIHWydi9Rql4JwjHgKuhbvrT1V87/ZI/rtVeEwKWGDq/3jpA9HYu9ItxSCRwgHGOPCbi5u/ftNhOHE/zyD07eqZ4B2Cv+U3oK6we8BhZBAdXs2Lp4Mm2TZyUewudJW7VQe4aFXLgqUVQXIqPip/av3xFs2LyDEoAijyrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gs1JOrX2quhXPpOm/hsB2Y/9bXV8kVqK94dVS7bKTWY=; b=ty7GkQnZ6CmF2EyRnSGPi4N6ArshK71Sq9G6tLwY2arTodLQEul4mndiTxCyvIeVw+1C1G+4VKOA3r+vDQhsTbUcsSJUFoCTJPhLe9VNAn3MUuPe+5JTOWyhBIKKYb1lV4GpGRpYuoD4FlIS/9gPnDxz9P9B84FFzbJp+YYGgZqmI3vz9x72Mgd303DBeGfW3nkLgywXsmOk9f3SOqd/K7P6WWDAQGtFFLB8kqsiQE1kPJeEXkcghACQGy5nK/en/Y5um3nOoVGCYlJ7wrft6oOgkBw/XkQ4JC3+gn/uG2MEXJrtARdrdLPDN3I6h2Toa/oZU5hGItyGzqbJLez+RA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <45d03ac2-94f5-d05f-fc7c-7402b3e6eaf6@suse.com> Date: Tue, 1 Aug 2023 16:50:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v6 2/2] xen/riscv: introduce identity mapping Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0174.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9865:EE_ X-MS-Office365-Filtering-Correlation-Id: 6db133a7-a86c-4f8f-36ca-08db929ea49a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n813i/UfYW88ZEb8cdnvHSb/Zq50TvwpSBLUMY7uT4OXeY/7K85gk5zkw8tc7u8IgkeNYowhB2zdW1oXKHVFFez+eiWXUTKB12mMX4RTJkFsjrtw/1bNQ8LgrjGcwYnBq8gh0ZXF+1tsGguYzKCgQ0hulCLja0IQyy5I5PeD7EawoV/JYxxEto92kJjeoW/esm5Yc1K1gJyRdcAAcd8rcdBDXqKg5UmDx89svWKXm60u0e7TU3NDiiaq4QtH/bUBRdlb+Rx499gVypsyhERB6zpgZmy5akFQEAMl1QRlh2WeAjvNiWpfBBCIyWRjhZOf93iYkBN1JI5ZCe/TiRCaiAcddD6IeFCIxgvzhK811egPY9nxkgrfADy7sKtM6yukQ8fkFELubuxQGK0h/Njt6wTLVqpPV4rFwB1rpLlgMnPVXFAhwPIQfCxe3/cGQZfkCIKpcDjMf+n401jXqGlX8BstommZKLAxq7bOO/i8CjAVpRNhqsDTUMFzEHmuZ6ZDZ7ckEImTosOhjykB/Axu3iE51/BZvhgHRyQCPRedqVENHvxsoVxkX8yuHWiq1xZAWdOyNo06ubfuz4kU6GpqwX94+A4qbaqax+HLrgDed6/ONpZs8ADfsTIK9ps/MjbaheFXarBbic0J1NodndFoHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(366004)(376002)(136003)(39860400002)(451199021)(2906002)(6916009)(4326008)(2616005)(4744005)(186003)(86362001)(316002)(31696002)(31686004)(478600001)(41300700001)(38100700002)(6512007)(54906003)(5660300002)(66556008)(66476007)(53546011)(66946007)(6506007)(26005)(8676002)(8936002)(36756003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXdJaFdqUTVPRk9MNlVtSzlxQ1NOb2ZSYjhWQkJLTnR0MDh0RGFRT2s4Tksr?= =?utf-8?B?bU5uRXYwR29qeDFLVFc4a01vdUsya081WXUzd2tmY3FzOFNsK3hUcGIzcEtF?= =?utf-8?B?cEFock5zc09SVmt1UVZsazZhYjZRd0FHU0ZDb2lzQm5XQlhHdUNWZTNGdHlR?= =?utf-8?B?bG5QTERGeGNBWHBoOXNHcFVjMldpS3dZTENZTDNqTDgrM2pFL3J4RUFlUXoy?= =?utf-8?B?NTQ0KzVXOGJwMk96WVRNWE0wRWRHc2xDdjhGMzNNeUwyUG9jR1lIdjZxMGdm?= =?utf-8?B?ck1oNk1DWWtZTzA0Nms3OVJBSWN4UFZKT3dXTDF3WUo5ME12VWVKakVOOUUw?= =?utf-8?B?Z1lhV1ZzRGUySnNKUXVvaWIzb3hqYWZhcmJtb0gyL3YxUHdKTHBYQXRtbjc3?= =?utf-8?B?SithUVB0bndKOElON1dSSjBqL3ZhbzdLbythNEpzMm5tZytlTnpYRmt5enpD?= =?utf-8?B?Qm5RNittWk1UUnhFWnhBcXAvWS9aaTlzcjhyWnlVaUt3VTI4djhXY0xabnpK?= =?utf-8?B?VUhFWll2a1YxanpPV3RLWUlUZGd6Y2lEOGluNTZyVW5nbHBkVitYa1BGcW0x?= =?utf-8?B?VTlWV1VIdldnNHhsT2wxdjZ2MXhpblJQbGRSR2NzOHZqclUxYVJHYmlBVmRr?= =?utf-8?B?TU5JME5ONlc1YlJDeFlEa1Npc2t5S1lDZFh6Rmhad0U0NFhyTkNKS3EzUW55?= =?utf-8?B?Ny9YWmRRbTBwT3J3d00zb2ZaS3M2MFRHbHBINjZOUnRkZ1VITnpiSlluRkZy?= =?utf-8?B?S2E2WElNSGxScE1xeXQrMHZaNVpMT3k5dmhhUkVvY1lFWmlHY3ZnTFBhZ2Uw?= =?utf-8?B?ZUhMYm5heUZoMnF4WHNNbGFqakRGR0RET3JWeUxHR3Y3alJ6S1BPck50WkZV?= =?utf-8?B?SVRpT2ZhVEdNdXZwQU5NVUdCMkI2ODIxZjErWGV2MGljZ3VBUWRzMTFOcFoz?= =?utf-8?B?aDN4VWNXaEFNWVNEdVFyampBVjBkVFdUTXFxbTVYRlRwcHpLdXpzU0Iyc2o4?= =?utf-8?B?WG1TMEdqTDFhOCtNeDJRNC9uby9hZXMyNmxiUW5YMUg5bXNTdDhuZ3h1eFNN?= =?utf-8?B?V1pqckdWQjJtdkZmT2hMWVhxZG1aVnBWVk0weFhOYkJ0NmxTYU1YajVXUmN4?= =?utf-8?B?VTIzVDh4TCtoOFRrT3RZRzAwZzVNOXhMWE9oTzZtenREcitSMFNZbE9GaXhQ?= =?utf-8?B?OVh3YW1YMDRlNThwRWpnRkV6b3VsQ0JRbWI5cWJnU2JCYUl0QzBLUXRya1NT?= =?utf-8?B?L0ZlMzM0cnBqMkMwdlp2VDl5eG1JeUpOZDJEMk9vOU9ELzd0clBNdjlnSmFq?= =?utf-8?B?MXlRRnlGVlJvbk9pZEtldWpuVDgyc1RlWWRHeDlMT0pEaWJwMGFmQ2R1dzZE?= =?utf-8?B?OWVlcDFvbU9iODl3RW9hdVRWK2lqUzFtc2s1YTU4ZVZDakVTbGNYTzhKVmRP?= =?utf-8?B?dC8xN2craXY2cXNYVGwwT0hLMmswRXd0b2ttdFg2UUVua0ZNY1FqNWJsalhj?= =?utf-8?B?U2lzbnFsbkUybEhqenFhR3d3NmhoVzQrVmx6RDNJOVFuTjd0OXdUbFpUZmpw?= =?utf-8?B?bk5lbjJuYmJvdnBlRFV3T1pDSDhRZzdya2p5YmRLT1VjWGRHQSsyODJuV2Jr?= =?utf-8?B?TGJQUnM1K0U3VE12QTVUb3BqVmlmU216U3NyQndJQ2JSMFZSOGx3alowcWRq?= =?utf-8?B?ZGdiL1kwR1pxMWxxbW9WM1ZFazg0dUV1UHZsUnhkZWFCZE5RYS9Ob3RhY1hi?= =?utf-8?B?aUNrL3FXTitQM25lN3Z2emdhYUh1Skd4RW9sZktxMjUyOFVhbThCZThOYmhK?= =?utf-8?B?Slk4bi83aE5tdWdwSzNGQ25naGptSDFITnU3bG9MKzcwZmVVMWVEVzNCb3lt?= =?utf-8?B?Ni9WblFBRzhRWFJXR0FmSk56Z0RPa0JRUnlDelFiTlUyeE1ISUxpd0tvZW1v?= =?utf-8?B?K3QvVlZCdVdQSEhzNno3L0t1S3YrNmcyVU0ydnlhVUhGNHBhNHE0aWRJR1BU?= =?utf-8?B?cXlZWkpKUzcwdUlWdkhwazlDY25aVUw2T0ViQ0FuVW9zMndqVWtJRHpGcDM1?= =?utf-8?B?VU1rUHNlZEVHRHBSYURqdzVrMWpmRGw3UEhiYjUyODdIL1VjbjBUVGNJVGRU?= =?utf-8?Q?1uvg58Vb5cAroXt7WeXqJ/9I9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6db133a7-a86c-4f8f-36ca-08db929ea49a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 14:50:26.9071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zyYSi911thsOciblBZa/7mT1xHUW/xdwQ+YVMs3SnAFxXeTY6DuQaBvdvLnFkUaAraBsSRCP3Hv8NsQlyndiwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9865 On 01.08.2023 16:30, Oleksii Kurochko wrote: > @@ -54,3 +70,17 @@ ENTRY(reset_stack) > > ret > > + .section .text.ident, "ax", %progbits > + > +ENTRY(turn_on_mmu) > + sfence.vma > + > + li t0, RV_STAGE1_MODE > + slli t0, t0, SATP_MODE_SHIFT > + > + la t1, stage1_pgtbl_root > + srl t1, t1, PAGE_SHIFT I think it would be good to be consistent in the use of pseudo insns: Above you use slli, so here it would want to be srli (or the other way around). Jan > + or t1, t1, t0 > + csrw CSR_SATP, t1 > + > + jr a0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:51:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574358.899606 (Exim 4.92) (envelope-from ) id 1qQqio-0005t0-3l; Tue, 01 Aug 2023 14:51:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574358.899606; Tue, 01 Aug 2023 14:51:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqio-0005st-0Z; Tue, 01 Aug 2023 14:51:38 +0000 Received: by outflank-mailman (input) for mailman id 574358; Tue, 01 Aug 2023 14:51:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqim-0005lo-Th for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:51:36 +0000 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [2607:f8b0:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8e59a8a-307a-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:51:35 +0200 (CEST) Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6bca5d6dcedso1755751a34.1 for ; Tue, 01 Aug 2023 07:51:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8e59a8a-307a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690901494; x=1691506294; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H88X5gfHf9VxmAkjJBqSKV70I+aQh9Izc8ZfPc/BhRg=; b=S4lezuvicEDGzoR/m9HZk0SMsBwHoMinC1LMlVO0wVObRRo+8h+QlmU3M4OsbOW9Jq UhqxuWHSRQHCrfrTCMKq0grHpdYc4tAm5hAYPjuntAsEbQdU86JxF6+NlI9ioDE+kwfv JUCk/W5bbLUhXtotdPcw+O/IrNrfb5VrYMOI5kqPg05cxOGI8LIT4ic8coww2mY7QSBw 9HdNx2XaaDmPoaKFOM1WEyTjYbhJAnPe7SwCJpAGNniCnUEB5NV6aK7nBVrwmHU4LGSW ORiXy9dIaKrvlnG0C5uZxx+BYHs+PNkV5rJJfxjqylVj9WlIpOc5DDCDzOTJu37kvYSi gbwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690901494; x=1691506294; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H88X5gfHf9VxmAkjJBqSKV70I+aQh9Izc8ZfPc/BhRg=; b=Zv65Xm5OASK+q+kTZhPsxwhGog4JUypHfDCVGa4zGd+R71yKfSWJIz5XQO8APbHEJg AVf0y6rOMancgCpAxO0B2GQVP38tYkN5ZBxBSYLZCJ2KLdJhGGhOu3cE3X0Ss6eS+TCy 3pr1TboaLxvBgGJmDNmJ4h2To+VRKEx2muoLY0am9KdRjW/+ZUfkwCrW9OqYILMYi8R3 xzBF6ci7jkvU3VVhAOfqrBRDuVGOmuWGQNhehDgnRf/Hh3grYMYJmPlbsmV3TmtyezAj 1kkBRUX+x417kRFnI0yh/hwYuwJrqQBIJQRr43qJnZGMo4Svb9oj10rB6kr84EfCyUoW LSiQ== X-Gm-Message-State: ABy/qLbbPrSErfYkxXz/z3gtAfSssbjPA+RUx8ihjOtn0WA42ZaE95lO FPyTkd5unp/uc3MhbZIl7/B2DfZ/hIBzSOxvquI2wYJwXEc= X-Google-Smtp-Source: APBJJlFqUq7uzRO3KioIVq8hurFoIOS+BN5308K5b9dIadr0OS3Ne5WsQLdAo6tM2o3DNYocWWEwINndhJzCnUfZ1cI= X-Received: by 2002:a05:6870:210a:b0:1b0:57f8:dabf with SMTP id f10-20020a056870210a00b001b057f8dabfmr13933189oae.33.1690901493893; Tue, 01 Aug 2023 07:51:33 -0700 (PDT) MIME-Version: 1.0 References: <20230801001258.555944-1-raj.khem@gmail.com> In-Reply-To: From: Khem Raj Date: Tue, 1 Aug 2023 07:51:07 -0700 Message-ID: Subject: Re: [PATCH] arm32: Avoid using solaris syntax for .section directive To: Jan Beulich Cc: xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 1, 2023 at 12:33=E2=80=AFAM Jan Beulich wro= te: > > On 01.08.2023 02:12, Khem Raj wrote: > > Assembler from binutils 2.41 rejects this syntax > > > > .section "name"[, flags...] > > > > where flags could be #alloc, #write, #execstr > > Switch to using ELF syntax > > You mean GNU, not ELF (ELF is describing the object format, not the > syntax used). Feels almost like a regression (I'll mention that to > Alan), which likely went unnoticed so far because Linux had changed > to GNU syntax already in 5.5, to allow building with Clang's > integrated assembler. This aspect may be worth mentioning here as > well. OK will send v2 > > > .section name[, "flags"[, @type]] > > > > [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.htm= l#SEC119 > > > > Signed-off-by: Khem Raj > > Out of curiosity - why were there four instances of the patch? > They all look largely identical; if there are differences, I haven't > spotted them. there should not have been I was a not a subscriber to mailing list, did not realize why it was not appearing on ml :) > > Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:53:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:53:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574363.899615 (Exim 4.92) (envelope-from ) id 1qQqkW-0006Tq-Da; Tue, 01 Aug 2023 14:53:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574363.899615; Tue, 01 Aug 2023 14:53:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqkW-0006Tj-Am; Tue, 01 Aug 2023 14:53:24 +0000 Received: by outflank-mailman (input) for mailman id 574363; Tue, 01 Aug 2023 14:53:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqkV-0006Td-2s for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:53:23 +0000 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [2001:4860:4864:20::2e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27ecf86b-307b-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:53:21 +0200 (CEST) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-1be267b1c88so1875648fac.1 for ; Tue, 01 Aug 2023 07:53:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27ecf86b-307b-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690901600; x=1691506400; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=71zAllxtILSJMl520qYLiyamgeSvcpZWU9eA3eCkpBg=; b=UhizypcMY2to4q0uTpe5WPzOLh2JqcV1Wzblu6URCNECWrSeukGfIVaxAy8O6zqiej vFnHxSSG5YAZK/tkqdl5bDLfW0TSB7sDBw3DR29dZ6i6v+tGR8GQAIqj6xtN4J1me/Yn A2YCJZq4tFtS4/d0iBj26htt30nVPEKV2zGh/vtRokU8Nii6l+u9pmOiFc/JuCay4+LC tpaByhzyibsuN0t8s+PVJecpQbtvWvoc3Rl5GutbVhXdovp5WtqXhQIP8sxuOOHWTIKf QZ80VUZQJ8uC5gnA4hkRfvwbhQ+oCxhDGZGC8cwjEfxVJGXUNyD6N092juO9/UKwG2eG g3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690901600; x=1691506400; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=71zAllxtILSJMl520qYLiyamgeSvcpZWU9eA3eCkpBg=; b=VbKOOT+bHp26/sRWuQ5T6hnmuRR09RBtzXukGDRauakZ96iVLyVZO6QTME3OTMUbGH OF/BOAAd8XopAFB2dfMstq179ppB9IrmetJdalLla1ftQPG+ivUQSp0FQxUcHd9CNRZb NGkqtCEKbd43uMWcUl5etux9/zPKLSYiN3wM0mr4B6NXj8GfHy7u0wx/u2BwAG4jeh5Y hvjpGzUDSulyRHMiEqN4mfoL0lwb2WHcO7HdinHdL6+4C45oazL8nYr8/O+k53OjPJhb q9pA7n+lfaGGN9lUJKpTlQKwW6gZSeqkUc+mxthPwbad4VCB8tef0xGWRE5Gy4nrL2lD mL4w== X-Gm-Message-State: ABy/qLYgfFAU8afupM4JbNJRPj7rk98wKokJyHjw3NBEoam9RTcIS/nu j+czQbKRQMswggyhSlS0ZCs/xEsK6FF7XpQ8BHw= X-Google-Smtp-Source: APBJJlGIPxTL+25/2g0PKkhyvr9HbdTpYHGjM6kcQz7zSEfsYN/de92yRQA2VVqmynM/kaHLFdK38x6flER1iZj2PJA= X-Received: by 2002:a05:6870:ec8e:b0:1b0:d28:2a76 with SMTP id eo14-20020a056870ec8e00b001b00d282a76mr10379283oab.21.1690901599794; Tue, 01 Aug 2023 07:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20230801002853.556437-1-raj.khem@gmail.com> <99574b63-18e5-20fe-659a-432fdaf4b5af@amd.com> In-Reply-To: <99574b63-18e5-20fe-659a-432fdaf4b5af@amd.com> From: Khem Raj Date: Tue, 1 Aug 2023 07:52:53 -0700 Message-ID: Subject: Re: [PATCH] arm32: Avoid using solaris syntax for .section directive To: Michal Orzel Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 1, 2023 at 12:39=E2=80=AFAM Michal Orzel = wrote: > > Hi, > > On 01/08/2023 02:28, Khem Raj wrote: > > > > > > Assembler from binutils 2.41 rejects this syntax > > > > .section "name"[, flags...] > > > > where flags could be #alloc, #write, #execstr > s/execstr/execinstr + there is also #exclude and #tls if you want to list= them all > > > Switch to using ELF syntax > > > > .section name[, "flags"[, @type]] > > > > [1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.htm= l#SEC119 > I think it would be better to add a link to 2.41 docs instead or to refer= to the following commit > of binutils: > 4cb88cfae843 "PR11601, Solaris assembler compatibility doesn't work" > > > > > > Signed-off-by: Khem Raj > > --- > > xen/arch/arm/arm32/proc-v7.S | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.= S > > index c90a31d80f..6d3d19b873 100644 > > --- a/xen/arch/arm/arm32/proc-v7.S > > +++ b/xen/arch/arm/arm32/proc-v7.S > > @@ -29,7 +29,7 @@ brahma15mp_init: > > mcr CP32(r0, ACTLR) > > mov pc, lr > > > > - .section ".proc.info", #alloc > > + .section .proc.info, "a" > > .type __v7_ca15mp_proc_info, #object > > __v7_ca15mp_proc_info: > > .long 0x410FC0F0 /* Cortex-A15 */ > > @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: > > .long caxx_processor > > .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info > > > > - .section ".proc.info", #alloc > > + .section .proc.info, "a" > > .type __v7_ca7mp_proc_info, #object > > __v7_ca7mp_proc_info: > > .long 0x410FC070 /* Cortex-A7 */ > > @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: > > .long caxx_processor > > .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info > > > > - .section ".proc.info", #alloc > > + .section .proc.info, "a" > > .type __v7_brahma15mp_proc_info, #object > > __v7_brahma15mp_proc_info: > > .long 0x420F00F0 /* Broadcom Brahma-B15 */ > > -- > > 2.41.0 > > > > > > The patch looks good but a fast grep shows that ".section .dtb,#alloc" in= arch/arm/dtb.S would also want > to be changed (I do not have gas 2.41, so you can check it by specifying = dtb to be included in Xen image through > "menuconfig->Common Features->Absolute path to device tree blob") thanks will add it to v2 as well > > ~Michal From xen-devel-bounces@lists.xenproject.org Tue Aug 01 14:54:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 14:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574370.899627 (Exim 4.92) (envelope-from ) id 1qQqla-000726-OR; Tue, 01 Aug 2023 14:54:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574370.899627; Tue, 01 Aug 2023 14:54:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqla-00071z-Jk; Tue, 01 Aug 2023 14:54:30 +0000 Received: by outflank-mailman (input) for mailman id 574370; Tue, 01 Aug 2023 14:54:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQqlZ-00071t-1J for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 14:54:29 +0000 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c68509b-307b-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 16:54:25 +0200 (CEST) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RFdMf2GZVzNmQW; Tue, 1 Aug 2023 22:50:54 +0800 (CST) Received: from localhost (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 22:54:19 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c68509b-307b-11ee-8613-37d641c3527e From: Yue Haibing To: , , , CC: , Subject: [PATCH -next] xen/evtchn: Remove unused function declaration xen_set_affinity_evtchn() Date: Tue, 1 Aug 2023 22:54:13 +0800 Message-ID: <20230801145413.40684-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected Commit 67473b8194bc ("xen/events: Remove disfunct affinity spreading") leave this unused declaration. Signed-off-by: Yue Haibing --- include/xen/events.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/xen/events.h b/include/xen/events.h index 95970a2f7695..95d5e28de324 100644 --- a/include/xen/events.h +++ b/include/xen/events.h @@ -75,7 +75,6 @@ void evtchn_put(evtchn_port_t evtchn); void xen_send_IPI_one(unsigned int cpu, enum ipi_vector vector); void rebind_evtchn_irq(evtchn_port_t evtchn, int irq); -int xen_set_affinity_evtchn(struct irq_desc *desc, unsigned int tcpu); static inline void notify_remote_via_evtchn(evtchn_port_t port) { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 15:47:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 15:47:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574401.899636 (Exim 4.92) (envelope-from ) id 1qQraS-0004Fg-Jc; Tue, 01 Aug 2023 15:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574401.899636; Tue, 01 Aug 2023 15:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQraS-0004FZ-Gi; Tue, 01 Aug 2023 15:47:04 +0000 Received: by outflank-mailman (input) for mailman id 574401; Tue, 01 Aug 2023 15:47:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQraQ-0004FT-E7 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 15:47:02 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6f932fa-3082-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 17:47:00 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fe1344b707so9256552e87.1 for ; Tue, 01 Aug 2023 08:47:00 -0700 (PDT) Received: from [192.168.203.100] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id h11-20020ac25d6b000000b004fa4323ec97sm2598283lft.301.2023.08.01.08.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 08:46:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6f932fa-3082-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690904819; x=1691509619; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bniAvYrttii6JtZVaUgncqBFmgEinZ4rXQ+fm8PB9kg=; b=ZJKeBfHafaJxkInQPtZo2jLn5+oBpZPPbLramUa4mjweG+/A8Rkz3QeZlxuwzbCqGp h+EumFUhN2K1lxeL/cTvenJmaFuNyPebG3T+U/681RaIV/uRDGh2eP7y/e7dYdlLGbng t2KUuGb4FVd0ggOrvVp/tbvZdKy2498FBVvvsnHvi9FwSVjYcbkULki3hdfE/2OYpgnu F1ZJbz774SwD9XYX3dJm5ubguugPE1FTMo0np4eb3A4AaT+CnfJyYlsZ6JUe9q7ePlzZ 6pdIBQne703MnsaOKcFqKzI+m7H7IqSfSQU5brlAXXTIOBiJRrCxBOvmTLnxGAewfvDf Burw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690904819; x=1691509619; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bniAvYrttii6JtZVaUgncqBFmgEinZ4rXQ+fm8PB9kg=; b=YndycwssFGHpcZh/EmFGWn0POjRElJrJzWN0a5txrNmAfgf1WCazuVQT1eSXfio5RZ QAgcy+NSh4fEtS3o76Zc0VMgOEdQRuiDuvQX814Et9NBkvhAeGFwuQZzLqE04zsV5RSC k7EMDTpyleMRuQ3xEiOuEb7TbAuxBAM4VIOWOjo+aAvVk68AHnastC+YZIIUjFetpCYd nh4Nq4DdL8eOXSxW8687aHnJmZ/ywH3Y+H6Qd1CUs7LvyW2mpfBjOo59I25edh6ZVaic fFypjrQDkzhTfkSLr1e32p21POJWxyUB2fFPG0+kyQ9nTTX9qlazlAKwV/CkAw4QkPJ5 YIuA== X-Gm-Message-State: ABy/qLbcVnIKilqujNqDxjPqGDyYkBDX827qb4WJ7LDkAME6Z+ya6liW 8cIhYmOYu5a6yr9STU8zUsQ= X-Google-Smtp-Source: APBJJlF8SVc1mEaiapCKbhRbQlHODk4BafmyiZn4aarAubtNFjjCBPNmWk3lo+m0M+dq6vCdXtCU4g== X-Received: by 2002:ac2:5306:0:b0:4fe:25bc:71f5 with SMTP id c6-20020ac25306000000b004fe25bc71f5mr2470828lfh.11.1690904819377; Tue, 01 Aug 2023 08:46:59 -0700 (PDT) Message-ID: <261b20991738cc14cb62ef248901d02fd1c002a1.camel@gmail.com> Subject: Re: [PATCH v6 2/2] xen/riscv: introduce identity mapping From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 01 Aug 2023 18:46:58 +0300 In-Reply-To: <45d03ac2-94f5-d05f-fc7c-7402b3e6eaf6@suse.com> References: <45d03ac2-94f5-d05f-fc7c-7402b3e6eaf6@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 T24gVHVlLCAyMDIzLTA4LTAxIGF0IDE2OjUwICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToKPiBP biAwMS4wOC4yMDIzIDE2OjMwLCBPbGVrc2lpIEt1cm9jaGtvIHdyb3RlOgo+ID4gQEAgLTU0LDMg KzcwLDE3IEBAIEVOVFJZKHJlc2V0X3N0YWNrKQo+ID4gwqAKPiA+IMKgwqDCoMKgwqDCoMKgwqAg cmV0Cj4gPiDCoAo+ID4gK8KgwqDCoMKgwqDCoMKgIC5zZWN0aW9uIC50ZXh0LmlkZW50LCAiYXgi LCAlcHJvZ2JpdHMKPiA+ICsKPiA+ICtFTlRSWSh0dXJuX29uX21tdSkKPiA+ICvCoMKgwqDCoMKg wqDCoCBzZmVuY2Uudm1hCj4gPiArCj4gPiArwqDCoMKgwqDCoMKgwqAgbGnCoMKgwqDCoMKgIHQw LCBSVl9TVEFHRTFfTU9ERQo+ID4gK8KgwqDCoMKgwqDCoMKgIHNsbGnCoMKgwqAgdDAsIHQwLCBT QVRQX01PREVfU0hJRlQKPiA+ICsKPiA+ICvCoMKgwqDCoMKgwqDCoCBsYcKgwqDCoMKgwqAgdDEs IHN0YWdlMV9wZ3RibF9yb290Cj4gPiArwqDCoMKgwqDCoMKgwqAgc3JswqDCoMKgwqAgdDEsIHQx LCBQQUdFX1NISUZUCj4gCj4gSSB0aGluayBpdCB3b3VsZCBiZSBnb29kIHRvIGJlIGNvbnNpc3Rl bnQgaW4gdGhlIHVzZSBvZiBwc2V1ZG8gaW5zbnM6Cj4gQWJvdmUgeW91IHVzZSBzbGxpLCBzbyBo ZXJlIGl0IHdvdWxkIHdhbnQgdG8gYmUgc3JsaSAob3IgdGhlIG90aGVyCj4gd2F5IGFyb3VuZCku Ck9vcHMsIEkgb3Zlcmxvb2tlZCB0aGF0LgpXaGVuIEkgZXhhbWluZWQgdGhlIGRpc2Fzc2VtYmxl ciwgaXQgYXV0b21hdGljYWxseSB0cmFuc2Zvcm1lZCBpdCB0bwonc3JsaScsCnNvIEkgZm9yZ290 IHRvIGNoYW5nZSBpdC4KCkl0IHdvdWxkIGJlIG1vcmUgYXBwcm9wcmlhdGUgdG8gdXNlICdzcmxp Jy4KCkknbGwgd2FpdCBmb3IgYW55IGFkZGl0aW9uYWwgY29tbWVudHMsIGFuZCBpZiB0aGVyZSBh cmUgbm9uZSwgSSdsbCBzZW5kCmEgbmV3IHBhdGNoIHNlcmllcyB2ZXJzaW9uLgoKVGhhbmtzLgoK fiBPbGVrc2lpCj4gCj4gPiArwqDCoMKgwqDCoMKgwqAgb3LCoMKgwqDCoMKgIHQxLCB0MSwgdDAK PiA+ICvCoMKgwqDCoMKgwqDCoCBjc3J3wqDCoMKgIENTUl9TQVRQLCB0MQo+ID4gKwo+ID4gK8Kg wqDCoMKgwqDCoMKgIGpywqDCoMKgwqDCoCBhMAo+IAoKCg== From xen-devel-bounces@lists.xenproject.org Tue Aug 01 16:03:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 16:03:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574410.899646 (Exim 4.92) (envelope-from ) id 1qQrqd-0007JA-3T; Tue, 01 Aug 2023 16:03:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574410.899646; Tue, 01 Aug 2023 16:03:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQrqd-0007J3-0k; Tue, 01 Aug 2023 16:03:47 +0000 Received: by outflank-mailman (input) for mailman id 574410; Tue, 01 Aug 2023 16:03:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQrqc-0007Ix-FR for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 16:03:46 +0000 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd56bc48-3084-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 18:03:44 +0200 (CEST) Received: by verein.lst.de (Postfix, from userid 2407) id 74FA16732D; Tue, 1 Aug 2023 18:03:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd56bc48-3084-11ee-8613-37d641c3527e Date: Tue, 1 Aug 2023 18:03:39 +0200 From: Christoph Hellwig To: Petr Tesarik Cc: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , "open list:SLAB ALLOCATOR" , Roberto Sassu , petr@tesarici.cz Subject: Re: [PATCH v7 0/9] Allow dynamic allocation of software IO TLB bounce buffers Message-ID: <20230801160339.GB13111@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Thanks, I've applied this to a new swiotlb-dynamic branch that I'll pull into the dma-mapping for-next tree. From xen-devel-bounces@lists.xenproject.org Tue Aug 01 16:06:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 16:06:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574413.899655 (Exim 4.92) (envelope-from ) id 1qQrtI-0007tl-Fu; Tue, 01 Aug 2023 16:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574413.899655; Tue, 01 Aug 2023 16:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQrtI-0007te-DH; Tue, 01 Aug 2023 16:06:32 +0000 Received: by outflank-mailman (input) for mailman id 574413; Tue, 01 Aug 2023 16:06:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQrtH-0007tU-6E for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 16:06:31 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d721bbf-3085-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 18:06:27 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690905978394667.5904322669267; Tue, 1 Aug 2023 09:06:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d721bbf-3085-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1690905980; cv=none; d=zohomail.com; s=zohoarc; b=E0+G4/RbxkFKV79+eB7HIqeT2L1Q1Nqvfl4LNWWQVHo0lpK+Xea1PjHP7Il35THdaVAxq7In1PZG1unoBc+ZSGEyOtmXqtD8fnTldABpVYUDnHX7lZij1utAPrKUThDF+Terij31PMjGe5taePHAV1RKuGSB8c4HpdKkqe4xew4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690905980; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=O/CJBISWz6EI4/Y6OymY+j6HswAHAIyZi8m02gX250o=; b=C3FzfMVWW33z+pFKbs1aL06U5g2h+LkyL+Of8tR1KNixGj1iX9WRqw7nf2DFlVGXpxlRa8mBTI/owkc0vuYe+Dpkoj5TKkffepf34jUUSNgaB5NUHNUQxe8sK9rXvbdLOWf8mhVe5k2bqa8CnCcZFJ6tX8uQHWebB/bcCJOr2cI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690905980; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=O/CJBISWz6EI4/Y6OymY+j6HswAHAIyZi8m02gX250o=; b=O4m12KzDUnvCnEgF+iMd/0v91UJSt9CAYvQ+fVnMYDOd7itpEmbYppypQLzJdzn0 x9S5ggTSQXbDNCn3Gv6eb0etTc7vY+D9VDTRqFZBXSz1l1PKuo81Nkt+luQ8O2KSTa9 meKmiTmnU5F9et6Zu1+G6TDgDC6bnp9iYGocNDa0= From: "Daniel P. Smith" To: Wei Liu , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH] console: generalize the ability for domU access Date: Tue, 1 Aug 2023 12:06:07 -0400 Message-Id: <20230801160608.19219-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This patch reworks the console rotation logic to provide a general mechanism to incorporate domU in to the rotation. It does so by walking the domain list using the XSM console privlege check to determine if the domain is given access. In reworking the rotation logic, the assumption that the hardware domain is the first domain created is removed and is changed to explicitly locate the hardware domain at boot. As part of this removal, the reliance on the `max_init_domid` global is eliminated, allowing the removal of a compatibility `#define` for the x86 arch. Suggested-by: Stefano Stabellini Signed-off-by: Daniel P. Smith --- This patch was developed as part of enabling PVH domain construction for hyperlaunch. There will be a corresponding Linux patch to enable the kernel to make use of console_io when running as a DomU. For x86, this will only be usable by leveraging FLASK to assign the privilege to a label that is applied to domains desired to be able to use the Xen console. When hyperlaunch is merged, it will become possible to assign the privilege without FLASK. This should work for Arm environments with or without vp1011 backend. xen/arch/x86/include/asm/setup.h | 2 - xen/drivers/char/console.c | 134 +++++++++++++++++++++++-------- 2 files changed, 99 insertions(+), 37 deletions(-) diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 51fce66607..5242dfcf93 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -64,6 +64,4 @@ extern bool opt_dom0_verbose; extern bool opt_dom0_cpuid_faulting; extern bool opt_dom0_msr_relaxed; -#define max_init_domid (0) - #endif diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 0e410fa086..f5b759898e 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -473,45 +473,102 @@ static void cf_check dump_console_ring_key(unsigned char key) */ static unsigned int __read_mostly console_rx = 0; -#define max_console_rx (max_init_domid + 1) +#define CON_RX_DOMID (console_rx - 1) /* Make sure to rcu_unlock_domain after use */ struct domain *console_input_domain(void) { if ( console_rx == 0 ) return NULL; - return rcu_lock_domain_by_id(console_rx - 1); + return rcu_lock_domain_by_id(CON_RX_DOMID); } static void switch_serial_input(void) { - unsigned int next_rx = console_rx; + struct domain *next, *d = console_input_domain(); - /* - * Rotate among Xen, dom0 and boot-time created domUs while skipping - * switching serial input to non existing domains. - */ - for ( ; ; ) + if ( d == NULL ) { - struct domain *d; + if ( hardware_domain ) + { + console_rx = hardware_domain->domain_id + 1; + printk("*** Serial input to DOM%d", CON_RX_DOMID); + goto out; //print switch_code statement & newline + } + else + { + for_each_domain(next) + { + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) + { + console_rx = next->domain_id + 1; + printk("*** Serial input to DOM%d", CON_RX_DOMID); + goto out; //print switch_code statement & newline + } + } - if ( next_rx++ >= max_console_rx ) + console_rx = 0; + printk("*** Serial input to Xen"); + goto out; + } + } + + for ( next = rcu_dereference(d->next_in_list); next != NULL; + next = rcu_dereference(next->next_in_list) ) + { + if ( hardware_domain && next == hardware_domain ) { console_rx = 0; printk("*** Serial input to Xen"); - break; + goto out; } - d = rcu_lock_domain_by_id(next_rx - 1); - if ( d ) + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) { - rcu_unlock_domain(d); - console_rx = next_rx; - printk("*** Serial input to DOM%u", next_rx - 1); - break; + console_rx = next->domain_id + 1; + printk("*** Serial input to DOM%d", CON_RX_DOMID); + goto out; + } + } + + /* + * Hit the end of the domain list and instead of assuming that the + * hardware domain is the first in the list, get the first domain + * in the domain list and then if it is not the hardware domain or + * does not have console privilege, iterate the list until we find + * the hardware domain or a domain with console privilege. + */ + if ( next == NULL ) + { + for_each_domain(next) + { + if ( hardware_domain && next == hardware_domain ) + { + console_rx = 0; + printk("*** Serial input to Xen"); + goto out; + } + + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) + { + console_rx = next->domain_id + 1; + printk("*** Serial input to DOM%d", CON_RX_DOMID); + goto out; + } } } + /* + * If we got here, could not find a domain with console io privilege. + * Default to Xen. + */ + console_rx = 0; + printk("*** Serial input to Xen"); + +out: + if ( d != NULL) + rcu_unlock_domain(d); + if ( switch_code ) printk(" (type 'CTRL-%c' three times to switch input)", opt_conswitch[0]); @@ -520,12 +577,11 @@ static void switch_serial_input(void) static void __serial_rx(char c, struct cpu_user_regs *regs) { - switch ( console_rx ) - { - case 0: + if ( console_rx == 0 ) return handle_keypress(c, regs); - case 1: + if ( hardware_domain->domain_id == CON_RX_DOMID ) + { /* * Deliver input to the hardware domain buffer, unless it is * already full. @@ -538,31 +594,37 @@ static void __serial_rx(char c, struct cpu_user_regs *regs) * getting stuck. */ send_global_virq(VIRQ_CONSOLE); - break; - -#ifdef CONFIG_SBSA_VUART_CONSOLE - default: + } + else { - struct domain *d = rcu_lock_domain_by_id(console_rx - 1); + struct domain *d = rcu_lock_domain_by_any_id(CON_RX_DOMID); + if ( d == NULL ) + goto unlock_out; + +#ifdef CONFIG_SBSA_VUART_CONSOLE /* * If we have a properly initialized vpl011 console for the * domain, without a full PV ring to Dom0 (in that case input * comes from the PV ring), then send the character to it. */ - if ( d != NULL && - !d->arch.vpl011.backend_in_domain && + if ( !d->arch.vpl011.backend_in_domain && d->arch.vpl011.backend.xen != NULL ) + { vpl011_rx_char_xen(d, c); - else - printk("Cannot send chars to Dom%d: no UART available\n", - console_rx - 1); + goto unlock_out; + } +#endif + + if ( (serial_rx_prod - serial_rx_cons) != SERIAL_RX_SIZE ) + serial_rx_ring[SERIAL_RX_MASK(serial_rx_prod++)] = c; + send_guest_global_virq(d, VIRQ_CONSOLE); + +unlock_out: if ( d != NULL ) rcu_unlock_domain(d); } -#endif - } #ifdef CONFIG_X86 if ( pv_shim && pv_console ) @@ -627,7 +689,7 @@ static long guest_console_write(XEN_GUEST_HANDLE_PARAM(char) buffer, if ( copy_from_guest(kbuf, buffer, kcount) ) return -EFAULT; - if ( is_hardware_domain(cd) ) + if ( cd->domain_id == CON_RX_DOMID ) { /* Use direct console output as it could be interactive */ spin_lock_irq(&console_lock); @@ -717,6 +779,8 @@ long do_console_io( rc = -E2BIG; if ( count > INT_MAX ) break; + if ( CON_RX_DOMID != current->domain->domain_id ) + return 0; rc = 0; while ( (serial_rx_cons != serial_rx_prod) && (rc < count) ) @@ -1107,7 +1171,7 @@ void __init console_endboot(void) * a useful 'how to switch' message. */ if ( opt_conswitch[1] == 'x' ) - console_rx = max_console_rx; + console_rx = 0; register_keyhandler('w', dump_console_ring_key, "synchronously dump console ring buffer (dmesg)", 0); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 16:14:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 16:14:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574420.899666 (Exim 4.92) (envelope-from ) id 1qQs0x-0000zl-96; Tue, 01 Aug 2023 16:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574420.899666; Tue, 01 Aug 2023 16:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQs0x-0000ze-5i; Tue, 01 Aug 2023 16:14:27 +0000 Received: by outflank-mailman (input) for mailman id 574420; Tue, 01 Aug 2023 16:14:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQs0v-0000zY-I1 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 16:14:25 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79b057a0-3086-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 18:14:23 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690906457983258.8849360837505; Tue, 1 Aug 2023 09:14:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79b057a0-3086-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690906459; cv=none; d=zohomail.com; s=zohoarc; b=FCalTfY/E0aAARrLJfuwrakIySVz0BGh0t/d7czwDRM+5whXdVj55Wyhmfw5KtjvO7SwBDNOF2w+3S2RM+P9c7vuuTN4LYsvXbQV7cZtO9H1ZpNhdvn4GSA36F4Fqv1kSCuGLqFn+jOAXOyA6x+HiLff1ywRsb756w3IsS/mEIw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690906459; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=pCr0JdRG9q1ElrX475c2UAk9oXat/55aUxS95iDoabE=; b=DB0OBlpAaswZDKABw4uoCZGGdWImU4i0kh6Ko+nE+1BcwvACU+LSXiUUnOf3MMP5LHlljox1ikMEMan5z/N0aPAtItcRtQVllVqUYCICLTThNJ5LuUcG0ivGY25pqLSkPwgZFaeY2mLNGxKF6GlcGohJT8m61yw7JwTYqBpZMLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690906459; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=pCr0JdRG9q1ElrX475c2UAk9oXat/55aUxS95iDoabE=; b=ggNPW559vdCH4iJr7NqNzPpzSbA37ybSIczyTfldvLc3ZQxk6hnmCmIkdE3uoso9 i0btBdjGB8MFS818MIwx7l12lrSIU41qfZk4CU6tlz9+hnC6V+ggQzewfqnWJqEd1ir nOOvAwD/291TBm/IAxcyMc9KwWaMsbT7oFHOKiTY= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Christopher Clark , Rich Persaud , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD Subject: [PATCH 0/2] Rebranding dom0less to hyperlaunch part 1 Date: Tue, 1 Aug 2023 12:14:07 -0400 Message-Id: <20230801161409.25905-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This is the first series of the proposal put forth on moving to have dom0less folded under and thus rebranded as a part of hyperlaunch. As laid out in the proposal, the series updates the hyperlaunch device tree documentation and applies the general refactoring of FDT parsing to make core logic common. Daniel P. Smith (2): docs: update hyperlaunch device tree fdt: make fdt handling reusable across arch MAINTAINERS | 11 + .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++-------- xen/arch/arm/bootfdt.c | 141 +---- xen/common/Kconfig | 4 + xen/common/Makefile | 3 +- xen/common/fdt.c | 153 +++++ xen/include/xen/device_tree.h | 50 +- xen/include/xen/fdt.h | 79 +++ 8 files changed, 551 insertions(+), 456 deletions(-) create mode 100644 xen/common/fdt.c create mode 100644 xen/include/xen/fdt.h -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 16:14:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 16:14:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574421.899676 (Exim 4.92) (envelope-from ) id 1qQs17-0001HT-FS; Tue, 01 Aug 2023 16:14:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574421.899676; Tue, 01 Aug 2023 16:14:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQs17-0001HM-CR; Tue, 01 Aug 2023 16:14:37 +0000 Received: by outflank-mailman (input) for mailman id 574421; Tue, 01 Aug 2023 16:14:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQs16-0000zY-4n for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 16:14:36 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 80573520-3086-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 18:14:34 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690906459472812.6746861262045; Tue, 1 Aug 2023 09:14:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80573520-3086-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690906461; cv=none; d=zohomail.com; s=zohoarc; b=SpFGSRZv168vMV09mTTWUKEVz9JNfC42MiXsVB2tnQy3YLFfo02HsuyjJ2oon5UwgRk9plmQkm4ntlt1sIBqgxwWPreyCK3QAg/EIA2UTa+yhWh6KgzovOc8/gHjKNHwwnj6bt2yMVI2YCSoNbQbJLeqRlwcazQ413rOA8MTAXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690906461; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=EW4AyI36gTHVj3MBWRAetoSpPzDjxbKjm9mKfWizXOo=; b=jY63lARPwfH/uJLrqqVKRDoXDrJycvewxdqi6AboR97Cofj+X1IC5IBabkcytx3ISrwEUl0oZVkclU0ie8cAYkEW25Vf5i9mD5K0/2bzaRvPq3AHvEJfaEf1JerJ1FMWRzgYOKBReAMyVQwfSsZE1Vapwn0VJuulyaZB/mso6xw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690906461; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=EW4AyI36gTHVj3MBWRAetoSpPzDjxbKjm9mKfWizXOo=; b=jUQn0/BiXXca9SaScHVBiryK0BNMviYvvdTIm2fMnlLLX4SUv8JTxzzdfuQQ0Gy2 82R62H8P51oZwrKbx4z+NT7k3RBLVFHMHDSbxEI2tyyGIvXPGMRM/2a2CBHVP2pZkJc zefG+OtHit7OBM9hlsOdO6pm6ixWz8C97C3I07TQ= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/2] docs: update hyperlaunch device tree Date: Tue, 1 Aug 2023 12:14:08 -0400 Message-Id: <20230801161409.25905-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801161409.25905-1-dpsmith@apertussolutions.com> References: <20230801161409.25905-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External With on going development of hyperlaunch, changes to the device tree definitions has been necessary. This commit updates the specification for all current changes along with changes expected to be made in finalizing the capability. This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places this documentation under its purview. It also reserves the path `xen/common/domain-builder` for the hyperlaunch domain builder code base. Signed-off-by: Daniel P. Smith --- MAINTAINERS | 9 + .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++-------- 2 files changed, 309 insertions(+), 266 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d8a02a6c19..694412a961 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -332,6 +332,15 @@ M: Nick Rosbrook S: Maintained F: tools/golang +HYPERLAUNCH +M: Daniel P. Smith +M: Christopher Clark +W: https://wiki.xenproject.org/wiki/Hyperlaunch +S: Supported +F: docs/design/launch/hyperlaunch.rst +F: docs/design/launch/hyperlaunch-devicetree.rst +F: xen/common/domain-builder/ + HYPFS M: Juergen Gross S: Supported diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst index b49c98cfbd..0bc719e4ae 100644 --- a/docs/designs/launch/hyperlaunch-devicetree.rst +++ b/docs/designs/launch/hyperlaunch-devicetree.rst @@ -2,10 +2,11 @@ Xen Hyperlaunch Device Tree Bindings ------------------------------------- -The Xen Hyperlaunch device tree adopts the dom0less device tree structure and -extends it to meet the requirements for the Hyperlaunch capability. The primary -difference is the introduction of the ``hypervisor`` node that is under the -``/chosen`` node. The move to a dedicated node was driven by: +The Xen Hyperlaunch device tree is informed by the dom0less device tree +structure with extensions to meet the requirements for the Hyperlaunch +capability. A major depature from the dom0less device tree is the introduction +of the ``hypervisor`` node that is under the ``/chosen`` node. The move to a +dedicated node was driven by: 1. Reduces the need to walk over nodes that are not of interest, e.g. only nodes of interest should be in ``/chosen/hypervisor`` @@ -13,331 +14,364 @@ difference is the introduction of the ``hypervisor`` node that is under the 2. Allows for the domain construction information to easily be sanitized by simple removing the ``/chosen/hypervisor`` node. -Example Configuration ---------------------- - -Below are two example device tree definitions for the hypervisor node. The -first is an example of a multiboot-based configuration for x86 and the second -is a module-based configuration for Arm. - -Multiboot x86 Configuration: -"""""""""""""""""""""""""""" - -:: - - hypervisor { - #address-cells = <1>; - #size-cells = <0>; - compatible = “hypervisor,xen†- - // Configuration container - config { - compatible = "xen,config"; - - module { - compatible = "module,microcode", "multiboot,module"; - mb-index = <1>; - }; - - module { - compatible = "module,xsm-policy", "multiboot,module"; - mb-index = <2>; - }; - }; - - // Boot Domain definition - domain { - compatible = "xen,domain"; - - domid = <0x7FF5>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0x00000001>; - - memory = <0x0 0x20000>; - cpus = <1>; - module { - compatible = "module,kernel", "multiboot,module"; - mb-index = <3>; - }; - - module { - compatible = "module,ramdisk", "multiboot,module"; - mb-index = <4>; - }; - module { - compatible = "module,config", "multiboot,module"; - mb-index = <5>; - }; - - // Classic Dom0 definition - domain { - compatible = "xen,domain"; - - domid = <0>; - - // PERMISSION_NONE (0) - // PERMISSION_CONTROL (1 << 0) - // PERMISSION_HARDWARE (1 << 1) - permissions = <3>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0xC0000006>; - - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ - mode = <5>; /* 64 BIT, PV */ - - // UUID - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; - - cpus = <1>; - memory = <0x0 0x20000>; - security-id = “dom0_t; - - module { - compatible = "module,kernel", "multiboot,module"; - mb-index = <6>; - bootargs = "console=hvc0"; - }; - module { - compatible = "module,ramdisk", "multiboot,module"; - mb-index = <7>; - }; - }; - -The multiboot modules supplied when using the above config would be, in order: +The Hypervisor node +------------------- -* (the above config, compiled) -* CPU microcode -* XSM policy -* kernel for boot domain -* ramdisk for boot domain -* boot domain configuration file -* kernel for the classic dom0 domain -* ramdisk for the classic dom0 domain +The ``hypervisor`` node is a top level container for all information relating +to how the hyperlaunch is to proceed. This includes definitions of the domains +that will be built by hypervisor on start up. The node will be named +``hypervisor`` with a ``compatible`` property to identify which hypervisors +the configuration is intended. The hypervisor node will consist of one or more +config nodes and one or more domain nodes. -Module Arm Configuration: -""""""""""""""""""""""""" +Properties +"""""""""" -:: +compatible + Identifies which hypervisors the configuration is compatible. Required. - hypervisor { - compatible = “hypervisor,xen†+ Format: "hypervisor,", e.g "hypervisor,xen" - // Configuration container - config { - compatible = "xen,config"; +Child Nodes +""""""""""" - module { - compatible = "module,microcodeâ€; - module-addr = <0x0000ff00 0x80>; - }; +* config +* domain - module { - compatible = "module,xsm-policy"; - module-addr = <0x0000ff00 0x80>; +Config Node +----------- - }; - }; +A ``config`` node is for passing configuration data and identifying any boot +modules that is of interest to the hypervisor. For example this would be where +Xen would be informed of microcode or XSM policy locations. Each ``config`` +node will require a unique device-tree compliant name as there may be one or +more ``config`` nodes present in a single dtb file. To identify which +hypervisor the configuration is intended, the required ``compatible`` property +must be present. - // Boot Domain definition - domain { - compatible = "xen,domain"; - - domid = <0x7FF5>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0x00000001>; - - memory = <0x0 0x20000>; - cpus = <1>; - module { - compatible = "module,kernel"; - module-addr = <0x0000ff00 0x80>; - }; +While the config node is not meant to replace the hypervisor commandline, there +may be cases where it is better suited for passing configuration details at +boot time. This additional information may be carried in properties assigned +to a ``config`` node. If there are any boot modules that are intended for the +hypervisor, then a ``module`` child node should be provided to identify the +boot module. - module { - compatible = "module,ramdisk"; - module-addr = <0x0000ff00 0x80>; - }; - module { - compatible = "module,config"; - module-addr = <0x0000ff00 0x80>; - }; +Properties +"""""""""" - // Classic Dom0 definition - domain@0 { - compatible = "xen,domain"; - - domid = <0>; - - // PERMISSION_NONE (0) - // PERMISSION_CONTROL (1 << 0) - // PERMISSION_HARDWARE (1 << 1) - permissions = <3>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0xC0000006>; - - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ - mode = <5>; /* 64 BIT, PV */ - - // UUID - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; - - cpus = <1>; - memory = <0x0 0x20000>; - security-id = “dom0_tâ€; - - module { - compatible = "module,kernel"; - module-addr = <0x0000ff00 0x80>; - bootargs = "console=hvc0"; - }; - module { - compatible = "module,ramdisk"; - module-addr = <0x0000ff00 0x80>; - }; - }; +compatible + Identifies the hypervisor the confiugration is intended. Required. -The modules that would be supplied when using the above config would be: + Format: ",config", e.g "xen,config" -* (the above config, compiled into hardware tree) -* CPU microcode -* XSM policy -* kernel for boot domain -* ramdisk for boot domain -* boot domain configuration file -* kernel for the classic dom0 domain -* ramdisk for the classic dom0 domain +bootargs + This is used to provide the boot params for Xen. -The hypervisor device tree would be compiled into the hardware device tree and -provided to Xen using the standard method currently in use. The remaining -modules would need to be loaded in the respective addresses specified in the -`module-addr` property. + Format: String, e.g. "flask=silo" +Child Nodes +""""""""""" -The Hypervisor node -------------------- +* module -The hypervisor node is a top level container for the domains that will be built -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` -property is used to identify the type of hypervisor node present.. +Domain Node +----------- -compatible - Identifies the type of node. Required. +A ``domain`` node is for describing the construction of a domain. Since there +may be one or more domain nodes, each one requires a unique, DTB compliant name +and a ``compatible`` property to identify as a domain node. -The Config node ---------------- +A ``domain`` node may provide a ``domid`` property which will be used as the +requested domain id for the domain with a value of “0†signifying to use the +next available domain id, which is the default behavior if omitted. It should +be noted that a domain configuration is not able to request a domid of “0â€. +Beyond that, a domain node may have any of the following optional properties. -A config node is for detailing any modules that are of interest to Xen itself. -For example this would be where Xen would be informed of microcode or XSM -policy locations. If the modules are multiboot modules and are able to be -located by index within the module chain, the ``mb-index`` property should be -used to specify the index in the multiboot module chain.. If the module will be -located by physical memory address, then the ``module-addr`` property should be -used to identify the location and size of the module. +Properties +"""""""""" compatible - Identifies the type of node. Required. - -The Domain node ---------------- + Identifies the node as a domain node and for which hypervisor. Required. -A domain node is for describing the construction of a domain. It may provide a -domid property which will be used as the requested domain id for the domain -with a value of “0†signifying to use the next available domain id, which is -the default behavior if omitted. A domain configuration is not able to request -a domid of “0â€. After that a domain node may have any of the following -parameters, - -compatible - Identifies the type of node. Required. + Format: ",domain", e.g "xen,domain" domid - Identifies the domid requested to assign to the domain. Required. + Identifies the domid requested to assign to the domain. -permissions + Format: Integer, e.g <0> + +role This sets what Discretionary Access Control permissions a domain is assigned. Optional, default is none. -functions - This identifies what system functions a domain will fulfill. + Format: Bitfield, e.g <3> or <0x00000003> + + ROLE_NONE (0) + ROLE_UNBOUNDED_DOMAIN (1U<<0) + ROLE_CONTROL_DOMAIN (1U<<1) + ROLE_HARDWARE_DOMAIN (1U<<2) + ROLE_XENSTORE_DOMAIN (1U<<3) + +capability + This identifies what system capabilities a domain may have beyond the role it + was assigned. Optional, the default is none. -.. note:: The `functions` bits that have been selected to indicate - ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits - (30, 31) such that should these features ever be fully retired, the flags may - be dropped without leaving a gap in the flag set. + Format: Bitfield, e.g <3221225487> or <0xC0000007> + + CAP_NONE (0) + CAP_CONSOLE_IO (1U<<0) mode The mode the domain will be executed under. Required. + Format: Bitfield, e.g <5> or <0x00000005> + + MODE_PARAVIRTUALIZED (1 << 0) PV | PVH/HVM + MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH + MODE_LONG (1 << 2) 64 BIT | 32 BIT + domain-uuid A globally unique identifier for the domain. Optional, the default is NULL. + Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] + cpus The number of vCPUs to be assigned to the domain. Optional, the default is “1â€. + Format: Integer, e.g <0> + memory - The amount of memory to assign to the domain, in KBs. + The amount of memory to assign to the domain, in KBs. This field uses a DTB + Reg which contains a start and size. For memory allocation start may or may + not have significance but size will always be used for the amount of memory Required. + Format: String min: | max: | , e.g. "256M" + security-id The security identity to be assigned to the domain when XSM is the access control mechanism being used. Optional, - the default is “domu_tâ€. + the default is “system_u:system_r:domU_tâ€. + + Format: string, e.g. "system_u:system_r:domU_t" + +Child Nodes +""""""""""" + +* module + +Module node +----------- -The Module node ---------------- +This node describes a boot module loaded by the boot loader. A ``module`` node +will often appear repeatedly and will require a unique and DTB compliant name +for each instance. The compatible property is required to identify that the +node is a ``module`` node, the type of boot module, and what it represents. -This node describes a boot module loaded by the boot loader. The required -compatible property follows the format: module, where type can be -“kernelâ€, “ramdiskâ€, “device-treeâ€, “microcodeâ€, “xsm-policy†or “configâ€. In -the case the module is a multiboot module, the additional property string -“multiboot,module†may be present. One of two properties is required and -identifies how to locate the module. They are the mb-index, used for multiboot -modules, and the module-addr for memory address based location. +Depending on the type of boot module, the ``module`` node will require either a +``module-index`` or ``module-addr`` property must be present. They provide the +boot module specific way of locating the boot module in memory. + +Properties +"""""""""" compatible This identifies what the module is and thus what the hypervisor should use the module for during domain construction. Required. -mb-index - This identifies the index for this module in the multiboot module chain. + Format: "module,"[, "module,"] + module type: kernel, ramdisk, device-tree, microcode, xsm-policy, + config + + locating type: index, addr + +module-index + This identifies the index for this module when in a module chain. Required for multiboot environments. + Format: Integer, e.g. <0> + module-addr This identifies where in memory this module is located. Required for non-multiboot environments. + Format: DTB Reg , e.g. <0x0 0x20000> + bootargs This is used to provide the boot params to kernel modules. + Format: String, e.g. "ro quiet" + .. note:: The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain. + +Example Configuration +--------------------- + +Below are two example device tree definitions for the hypervisor node. The +first is an example of a multiboot-based configuration for x86 and the second +is a module-based configuration for Arm. + +Multiboot x86 Configuration: +"""""""""""""""""""""""""""" + +:: + + /dts-v1/; + + / { + chosen { + hypervisor { + compatible = "hypervisor,xen", "xen,x86"; + + dom0 { + compatible = "xen,domain"; + + domid = <0>; + + role = <9>; + mode = <12>; + + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 13 F0 8C]; + + cpus = <1>; + memory = "1024M"; + + kernel { + compatible = "module,kernel", "module,index"; + module-index = <1>; + }; + + initrd { + compatible = "module,ramdisk", "module,index"; + module-index = <2>; + }; + }; + + dom1 { + compatible = "xen,domain"; + domid = <1>; + role = <0>; + capability = <1>; + mode = <12>; + domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 54 1A 74]; + cpus = <1>; + memory = "1024M"; + + kernel { + compatible = "module,kernel", "module,index"; + module-index = <3>; + bootargs = "console=hvc0 earlyprintk=xen root=/dev/ram0 rw"; + }; + + initrd { + compatible = "module,ramdisk", "module,index"; + module-index = <4>; + }; + }; + }; + }; + }; + + + +The multiboot modules supplied when using the above config would be, in order: + +* (the above config, compiled) +* kernel for PVH unbounded domain +* ramdisk for PVH unbounded domain +* kernel for PVH guest domain +* ramdisk for PVH guest domain + +Module Arm Configuration: +""""""""""""""""""""""""" + +:: + + /dts-v1/; + + / { + chosen { + hypervisor { + compatible = “hypervisor,xen†+ + // Configuration container + config { + compatible = "xen,config"; + + module { + compatible = "module,xsm-policy"; + module-addr = <0x0000ff00 0x80>; + + }; + }; + + // Unbounded Domain definition + dom0 { + compatible = "xen,domain"; + + domid = <0>; + + role = <9>; + + mode = <12>; /* 64 BIT, PVH */ + + memory = <0x0 0x20000>; + cpus = <1>; + module { + compatible = "module,kernel"; + module-addr = <0x0000ff00 0x80>; + }; + + module { + compatible = "module,ramdisk"; + module-addr = <0x0000ff00 0x80>; + }; + + // Guest definition + dom1 { + compatible = "xen,domain"; + + domid = <0>; + + role = <0>; + capability = <1>; + + mode = <12>; /* 64 BIT, PVH */ + + // UUID + domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 54 1A 74]; + + cpus = <1>; + memory = <0x0 0x20000>; + security-id = “dom0_tâ€; + + module { + compatible = "module,kernel"; + module-addr = <0x0000ff00 0x80>; + bootargs = "console=hvc0"; + }; + module { + compatible = "module,ramdisk"; + module-addr = <0x0000ff00 0x80>; + }; + }; + }; + }; + }; + +The modules that would be supplied when using the above config would be: + +* (the above config, compiled into hardware tree) +* XSM policy +* kernel for unbounded domain +* ramdisk for unbounded domain +* kernel for guest domain +* ramdisk for guest domain + +The hypervisor device tree would be compiled into the hardware device tree and +provided to Xen using the standard method currently in use. The remaining +modules would need to be loaded in the respective addresses specified in the +`module-addr` property. -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 16:14:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 16:14:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574423.899685 (Exim 4.92) (envelope-from ) id 1qQs1J-0001k7-QE; Tue, 01 Aug 2023 16:14:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574423.899685; Tue, 01 Aug 2023 16:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQs1J-0001jy-NG; Tue, 01 Aug 2023 16:14:49 +0000 Received: by outflank-mailman (input) for mailman id 574423; Tue, 01 Aug 2023 16:14:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQs1I-0000zY-9O for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 16:14:48 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87e3c789-3086-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 18:14:47 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690906461023126.57678525510755; Tue, 1 Aug 2023 09:14:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87e3c789-3086-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690906463; cv=none; d=zohomail.com; s=zohoarc; b=kftLtAyCVJotdA+tt7yqfJOhwVST4aPQMxRMzvSRp7aeNADv5rsz80FSMozg7f4NTBaCZ2oe5mo94zConlBM5Eubqe4CZ3QyE+fz3UvaE7lP9c6JoPXjsyUIlV3vQeJY4Bo0sof1JjZJRtndwwAuwm+O7s4O+sX1wok6m8+vtgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690906463; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=iJdTGx0QdelpoFD1gaU2LsNp6huwPZ2m+dQ4G7t7rbs=; b=WjVWo4DJMPa0yL5qbmTQoxBN9m4S/Y8SOpu4GOoje9ivvc4GcHgb8T0yTpNUuLuGinzE/abUukuvAfCTKByAyboT8Y6rYXrnLqb6uuvg5czxzJFoJEz1jLxybyi78LL15RJowGSaAVvavg5XzExHqmHEwsdqGxsBaqVK35FfwmQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690906463; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=iJdTGx0QdelpoFD1gaU2LsNp6huwPZ2m+dQ4G7t7rbs=; b=VqEFUyBtKQmiWsMHzt/mIM5ZOd6U5YSBmiBG8E1EyKmUcAOfHB1lM1M+eqvEGO/a BgfTlTk84xjPgTOCvG7H1eddgFqfwae4/4DSPtcceW6AZLehnYjubMBAr3vmo9XKXDa zS+181/TMUKb702qQgZXQY1YfYtknttYT4a9Ps1A= From: "Daniel P. Smith" To: Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: [PATCH 2/2] fdt: make fdt handling reusable across arch Date: Tue, 1 Aug 2023 12:14:09 -0400 Message-Id: <20230801161409.25905-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801161409.25905-1-dpsmith@apertussolutions.com> References: <20230801161409.25905-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch. Signed-off-by: Daniel P. Smith --- MAINTAINERS | 2 + xen/arch/arm/bootfdt.c | 141 +------------------------------ xen/common/Kconfig | 4 + xen/common/Makefile | 3 +- xen/common/fdt.c | 153 ++++++++++++++++++++++++++++++++++ xen/include/xen/device_tree.h | 50 +---------- xen/include/xen/fdt.h | 79 ++++++++++++++++++ 7 files changed, 242 insertions(+), 190 deletions(-) create mode 100644 xen/common/fdt.c create mode 100644 xen/include/xen/fdt.h diff --git a/MAINTAINERS b/MAINTAINERS index 694412a961..b7fc3ed805 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -303,7 +303,9 @@ F: xen/common/libfdt/ F: xen/common/device_tree.c F: xen/include/xen/libfdt/ F: xen/include/xen/device_tree.h +F: include/xen/fdt.h F: xen/drivers/passthrough/device_tree.c +F: common/fdt.c ECLAIR R: Simone Ballarin diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 2673ad17a1..cdf4f17789 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -12,79 +12,11 @@ #include #include #include +#include #include #include #include -static bool __init device_tree_node_matches(const void *fdt, int node, - const char *match) -{ - const char *name; - size_t match_len; - - name = fdt_get_name(fdt, node, NULL); - match_len = strlen(match); - - /* Match both "match" and "match@..." patterns but not - "match-foo". */ - return strncmp(name, match, match_len) == 0 - && (name[match_len] == '@' || name[match_len] == '\0'); -} - -static bool __init device_tree_node_compatible(const void *fdt, int node, - const char *match) -{ - int len, l; - const void *prop; - - prop = fdt_getprop(fdt, node, "compatible", &len); - if ( prop == NULL ) - return false; - - while ( len > 0 ) { - if ( !dt_compat_cmp(prop, match) ) - return true; - l = strlen(prop) + 1; - prop += l; - len -= l; - } - - return false; -} - -void __init device_tree_get_reg(const __be32 **cell, uint32_t address_cells, - uint32_t size_cells, paddr_t *start, - paddr_t *size) -{ - uint64_t dt_start, dt_size; - - /* - * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit. - * Thus, there is an implicit cast from uint64_t to paddr_t. - */ - dt_start = dt_next_cell(address_cells, cell); - dt_size = dt_next_cell(size_cells, cell); - - if ( dt_start != (paddr_t)dt_start ) - { - printk("Physical address greater than max width supported\n"); - WARN(); - } - - if ( dt_size != (paddr_t)dt_size ) - { - printk("Physical size greater than max width supported\n"); - WARN(); - } - - /* - * Xen will truncate the address/size if it is greater than the maximum - * supported width and it will give an appropriate warning. - */ - *start = dt_start; - *size = dt_size; -} - static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, @@ -135,77 +67,6 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, return 0; } -u32 __init device_tree_get_u32(const void *fdt, int node, - const char *prop_name, u32 dflt) -{ - const struct fdt_property *prop; - - prop = fdt_get_property(fdt, node, prop_name, NULL); - if ( !prop || prop->len < sizeof(u32) ) - return dflt; - - return fdt32_to_cpu(*(uint32_t*)prop->data); -} - -/** - * device_tree_for_each_node - iterate over all device tree sub-nodes - * @fdt: flat device tree. - * @node: parent node to start the search from - * @func: function to call for each sub-node. - * @data: data to pass to @func. - * - * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored. - * - * Returns 0 if all nodes were iterated over successfully. If @func - * returns a value different from 0, that value is returned immediately. - */ -int __init device_tree_for_each_node(const void *fdt, int node, - device_tree_node_func func, - void *data) -{ - /* - * We only care about relative depth increments, assume depth of - * node is 0 for simplicity. - */ - int depth = 0; - const int first_node = node; - u32 address_cells[DEVICE_TREE_MAX_DEPTH]; - u32 size_cells[DEVICE_TREE_MAX_DEPTH]; - int ret; - - do { - const char *name = fdt_get_name(fdt, node, NULL); - u32 as, ss; - - if ( depth >= DEVICE_TREE_MAX_DEPTH ) - { - printk("Warning: device tree node `%s' is nested too deep\n", - name); - continue; - } - - as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT; - ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT; - - address_cells[depth] = device_tree_get_u32(fdt, node, - "#address-cells", as); - size_cells[depth] = device_tree_get_u32(fdt, node, - "#size-cells", ss); - - /* skip the first node */ - if ( node != first_node ) - { - ret = func(fdt, node, name, depth, as, ss, data); - if ( ret != 0 ) - return ret; - } - - node = fdt_next_node(fdt, node, &depth); - } while ( node >= 0 && depth > 0 ); - - return 0; -} - static int __init process_memory_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0d248ab941..e2fdb3cbc3 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -38,8 +38,12 @@ config HAS_ALTERNATIVE config HAS_COMPAT bool +config CORE_DEVICE_TREE + bool + config HAS_DEVICE_TREE bool + select CORE_DEVICE_TREE config HAS_EX_TABLE bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 46049eac35..fd3769e1c6 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -11,6 +11,7 @@ obj-y += domain.o obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o +obj-$(CONFIG_CORE_DEVICE_TREE) += fdt.o obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += guestcopy.o @@ -75,7 +76,7 @@ obj-y += sched/ obj-$(CONFIG_UBSAN) += ubsan/ obj-$(CONFIG_NEEDS_LIBELF) += libelf/ -obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ +obj-$(CONFIG_CORE_DEVICE_TREE) += libfdt/ CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(objtree)/)$(KCONFIG_CONFIG) $(obj)/config.gz: $(CONF_FILE) diff --git a/xen/common/fdt.c b/xen/common/fdt.c new file mode 100644 index 0000000000..8d7acaaa43 --- /dev/null +++ b/xen/common/fdt.c @@ -0,0 +1,153 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012-2014 Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ +#include +#include +#include +#include +#include + +bool __init device_tree_node_matches( + const void *fdt, int node, const char *match) +{ + const char *name; + size_t match_len; + + name = fdt_get_name(fdt, node, NULL); + match_len = strlen(match); + + /* Match both "match" and "match@..." patterns but not + "match-foo". */ + return strncmp(name, match, match_len) == 0 + && (name[match_len] == '@' || name[match_len] == '\0'); +} + +bool __init device_tree_node_compatible( + const void *fdt, int node, const char *match) +{ + int len, l; + const void *prop; + + prop = fdt_getprop(fdt, node, "compatible", &len); + if ( prop == NULL ) + return false; + + while ( len > 0 ) { + if ( !dt_compat_cmp(prop, match) ) + return true; + l = strlen(prop) + 1; + prop += l; + len -= l; + } + + return false; +} + +void __init device_tree_get_reg( + const __be32 **cell, uint32_t address_cells, uint32_t size_cells, + paddr_t *start, paddr_t *size) +{ + uint64_t dt_start, dt_size; + + /* + * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit. + * Thus, there is an implicit cast from uint64_t to paddr_t. + */ + dt_start = dt_next_cell(address_cells, cell); + dt_size = dt_next_cell(size_cells, cell); + + if ( dt_start != (paddr_t)dt_start ) + { + printk("Physical address greater than max width supported\n"); + WARN(); + } + + if ( dt_size != (paddr_t)dt_size ) + { + printk("Physical size greater than max width supported\n"); + WARN(); + } + + /* + * Xen will truncate the address/size if it is greater than the maximum + * supported width and it will give an appropriate warning. + */ + *start = dt_start; + *size = dt_size; +} + +u32 __init device_tree_get_u32( + const void *fdt, int node, const char *prop_name, u32 dflt) +{ + const struct fdt_property *prop; + + prop = fdt_get_property(fdt, node, prop_name, NULL); + if ( !prop || prop->len < sizeof(u32) ) + return dflt; + + return fdt32_to_cpu(*(uint32_t*)prop->data); +} + +/** + * device_tree_for_each_node - iterate over all device tree sub-nodes + * @fdt: flat device tree. + * @node: parent node to start the search from + * @func: function to call for each sub-node. + * @data: data to pass to @func. + * + * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored. + * + * Returns 0 if all nodes were iterated over successfully. If @func + * returns a value different from 0, that value is returned immediately. + */ +int __init device_tree_for_each_node( + const void *fdt, int node, device_tree_node_func func, void *data) +{ + /* + * We only care about relative depth increments, assume depth of + * node is 0 for simplicity. + */ + int depth = 0; + const int first_node = node; + u32 address_cells[DEVICE_TREE_MAX_DEPTH]; + u32 size_cells[DEVICE_TREE_MAX_DEPTH]; + int ret; + + do { + const char *name = fdt_get_name(fdt, node, NULL); + u32 as, ss; + + if ( depth >= DEVICE_TREE_MAX_DEPTH ) + { + printk("Warning: device tree node `%s' is nested too deep\n", + name); + continue; + } + + as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT; + ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT; + + address_cells[depth] = device_tree_get_u32(fdt, node, + "#address-cells", as); + size_cells[depth] = device_tree_get_u32(fdt, node, + "#size-cells", ss); + + /* skip the first node */ + if ( node != first_node ) + { + ret = func(fdt, node, name, depth, as, ss, data); + if ( ret != 0 ) + return ret; + } + + node = fdt_next_node(fdt, node, &depth); + } while ( node >= 0 && depth > 0 ); + + return 0; +} diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index c2eada7489..f59aa54423 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -14,13 +14,12 @@ #include #include #include +#include #include #include #include #include -#define DEVICE_TREE_MAX_DEPTH 16 - /* * Struct used for matching a device */ @@ -159,17 +158,8 @@ struct dt_raw_irq { u32 specifier[DT_MAX_IRQ_SPEC]; }; -typedef int (*device_tree_node_func)(const void *fdt, - int node, const char *name, int depth, - u32 address_cells, u32 size_cells, - void *data); - extern const void *device_tree_flattened; -int device_tree_for_each_node(const void *fdt, int node, - device_tree_node_func func, - void *data); - /** * dt_unflatten_host_device_tree - Unflatten the host device tree * @@ -214,14 +204,6 @@ extern const struct dt_device_node *dt_interrupt_controller; struct dt_device_node * dt_find_interrupt_controller(const struct dt_device_match *matches); -#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) -#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) -#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) - -/* Default #address and #size cells */ -#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 -#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 - #define dt_for_each_property_node(dn, pp) \ for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) @@ -231,16 +213,6 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); #define dt_for_each_child_node(dt, dn) \ for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling ) -/* Helper to read a big number; size is in cells (not bytes) */ -static inline u64 dt_read_number(const __be32 *cell, int size) -{ - u64 r = 0; - - while ( size-- ) - r = (r << 32) | be32_to_cpu(*(cell++)); - return r; -} - /* Wrapper for dt_read_number() to return paddr_t (instead of uint64_t) */ static inline paddr_t dt_read_paddr(const __be32 *cell, int size) { @@ -268,26 +240,6 @@ static inline paddr_t dt_read_paddr(const __be32 *cell, int size) return r; } -/* Helper to convert a number of cells to bytes */ -static inline int dt_cells_to_size(int size) -{ - return (size * sizeof (u32)); -} - -/* Helper to convert a number of bytes to cells, rounds down */ -static inline int dt_size_to_cells(int bytes) -{ - return (bytes / sizeof(u32)); -} - -static inline u64 dt_next_cell(int s, const __be32 **cellp) -{ - const __be32 *p = *cellp; - - *cellp = p + s; - return dt_read_number(p, s); -} - static inline const char *dt_node_full_name(const struct dt_device_node *np) { return (np && np->full_name) ? np->full_name : ""; diff --git a/xen/include/xen/fdt.h b/xen/include/xen/fdt.h new file mode 100644 index 0000000000..00f9f3792f --- /dev/null +++ b/xen/include/xen/fdt.h @@ -0,0 +1,79 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012 Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ +#ifndef __XEN_FDT_H__ +#define __XEN_FDT_H__ + +#include +#include +#include + +#define DEVICE_TREE_MAX_DEPTH 16 + +/* Default #address and #size cells */ +#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 +#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 + +#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) +#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) +#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) + +/* Helper to read a big number; size is in cells (not bytes) */ +static inline u64 dt_read_number(const __be32 *cell, int size) +{ + u64 r = 0; + + while ( size-- ) + r = (r << 32) | be32_to_cpu(*(cell++)); + return r; +} + +/* Helper to convert a number of cells to bytes */ +static inline int dt_cells_to_size(int size) +{ + return (size * sizeof (u32)); +} + +/* Helper to convert a number of bytes to cells, rounds down */ +static inline int dt_size_to_cells(int bytes) +{ + return (bytes / sizeof(u32)); +} + +static inline u64 dt_next_cell(int s, const __be32 **cellp) +{ + const __be32 *p = *cellp; + + *cellp = p + s; + return dt_read_number(p, s); +} + + +bool __init device_tree_node_matches( + const void *fdt, int node, const char *match); + +bool __init device_tree_node_compatible( + const void *fdt, int node, const char *match); + +void __init device_tree_get_reg( + const __be32 **cell, u32 address_cells, u32 size_cells, u64 *start, + u64 *size); + +u32 __init device_tree_get_u32( + const void *fdt, int node, const char *prop_name, u32 dflt); + +typedef int (*device_tree_node_func)( + const void *fdt, int node, const char *name, int depth, u32 address_cells, + u32 size_cells, void *data); + +int device_tree_for_each_node( + const void *fdt, int node, device_tree_node_func func, void *data); + + +#endif /* __XEN_FDT_H__ */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 16:50:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 16:50:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574438.899695 (Exim 4.92) (envelope-from ) id 1qQsa1-0006av-BQ; Tue, 01 Aug 2023 16:50:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574438.899695; Tue, 01 Aug 2023 16:50:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQsa1-0006ao-8k; Tue, 01 Aug 2023 16:50:41 +0000 Received: by outflank-mailman (input) for mailman id 574438; Tue, 01 Aug 2023 16:50:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQsa0-0006ai-EG for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 16:50:40 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8a0748e9-308b-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 18:50:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 4790682855CD; Tue, 1 Aug 2023 11:50:36 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dxiFkFjZgdqP; Tue, 1 Aug 2023 11:50:35 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 0F1B38285615; Tue, 1 Aug 2023 11:50:35 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id B0wLQ-t1NMT0; Tue, 1 Aug 2023 11:50:34 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 5030D82855CD; Tue, 1 Aug 2023 11:50:34 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a0748e9-308b-11ee-b25c-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 0F1B38285615 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690908635; bh=O0CDEXKqIDdnsT6c++fa+0YtT9ok5dHmC7fBHzW1hdc=; h=Message-ID:Date:MIME-Version:To:From; b=dCtPdWOdKJzuqfNh8AmUcTG/EeZ5h3/fG4LjPiJlPGAOx0+R8rYTGtWjckovFgBsn DRPrxRaWMD8wiT+Mhpu+nqvPhHpfIskOJiJesSZVLeGDMBqvmqcXkp0HvjIkIgKpeq 75RI3lCpkShe6kC7tNdjFj+4Dq+HqJLGs1F/dUZo= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <56795c25-1b81-32d3-e839-a3331c1922a4@raptorengineering.com> Date: Tue, 1 Aug 2023 11:50:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] common: move simple_strto{,u}l{,l}() to lib/ Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <4ba63342-6200-1f76-bf63-8df62e8955a4@suse.com> From: Shawn Anastasio In-Reply-To: <4ba63342-6200-1f76-bf63-8df62e8955a4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/23 5:34 AM, Jan Beulich wrote: > Convert style from a Xen/Linux mix to pure Xen while doing the move. No > other changes, despite having been heavily tempted to do some - at the > very least to make simple_strtoul() and simple_strtoull() the same in > how they deal with non-numeric digits. > > Requested-by: Shawn Anastasio > Signed-off-by: Jan Beulich > --- > Further changes I was considering: > - "value" doesn't need to be unsigned long, and even less so unsigned > long long, > - strtoull.c could simply include strtoul.c, after #define-ing "long" > to "long long" and "simple_strtoul" to "simple_strtoull", > - "else if ( base == 16 )" wants folding with its inner if(). > > --- a/xen/common/vsprintf.c > +++ b/xen/common/vsprintf.c > @@ -24,108 +24,6 @@ > #include > #include > > -/** > - * simple_strtoul - convert a string to an unsigned long > - * @cp: The start of the string > - * @endp: A pointer to the end of the parsed string will be placed here > - * @base: The number base to use > - */ > -unsigned long simple_strtoul( > - const char *cp, const char **endp, unsigned int base) > -{ > - unsigned long result = 0,value; > - > - if (!base) { > - base = 10; > - if (*cp == '0') { > - base = 8; > - cp++; > - if ((toupper(*cp) == 'X') && isxdigit(cp[1])) { > - cp++; > - base = 16; > - } > - } > - } else if (base == 16) { > - if (cp[0] == '0' && toupper(cp[1]) == 'X') > - cp += 2; > - } > - while (isxdigit(*cp) && > - (value = isdigit(*cp) ? *cp-'0' : toupper(*cp)-'A'+10) < base) { > - result = result*base + value; > - cp++; > - } > - if (endp) > - *endp = cp; > - return result; > -} > - > -EXPORT_SYMBOL(simple_strtoul); > - > -/** > - * simple_strtol - convert a string to a signed long > - * @cp: The start of the string > - * @endp: A pointer to the end of the parsed string will be placed here > - * @base: The number base to use > - */ > -long simple_strtol(const char *cp, const char **endp, unsigned int base) > -{ > - if(*cp=='-') > - return -simple_strtoul(cp+1,endp,base); > - return simple_strtoul(cp,endp,base); > -} > - > -EXPORT_SYMBOL(simple_strtol); > - > -/** > - * simple_strtoull - convert a string to an unsigned long long > - * @cp: The start of the string > - * @endp: A pointer to the end of the parsed string will be placed here > - * @base: The number base to use > - */ > -unsigned long long simple_strtoull( > - const char *cp, const char **endp, unsigned int base) > -{ > - unsigned long long result = 0,value; > - > - if (!base) { > - base = 10; > - if (*cp == '0') { > - base = 8; > - cp++; > - if ((toupper(*cp) == 'X') && isxdigit(cp[1])) { > - cp++; > - base = 16; > - } > - } > - } else if (base == 16) { > - if (cp[0] == '0' && toupper(cp[1]) == 'X') > - cp += 2; > - } > - while (isxdigit(*cp) && (value = isdigit(*cp) ? *cp-'0' : (islower(*cp) > - ? toupper(*cp) : *cp)-'A'+10) < base) { > - result = result*base + value; > - cp++; > - } > - if (endp) > - *endp = cp; > - return result; > -} > - > -EXPORT_SYMBOL(simple_strtoull); > - > -/** > - * simple_strtoll - convert a string to a signed long long > - * @cp: The start of the string > - * @endp: A pointer to the end of the parsed string will be placed here > - * @base: The number base to use > - */ > -long long simple_strtoll(const char *cp,const char **endp,unsigned int base) > -{ > - if(*cp=='-') > - return -simple_strtoull(cp+1,endp,base); > - return simple_strtoull(cp,endp,base); > -} > - > static int skip_atoi(const char **s) > { > int i=0; > --- a/xen/lib/Makefile > +++ b/xen/lib/Makefile > @@ -28,6 +28,10 @@ lib-y += strrchr.o > lib-y += strsep.o > lib-y += strspn.o > lib-y += strstr.o > +lib-y += strtol.o > +lib-y += strtoll.o > +lib-y += strtoul.o > +lib-y += strtoull.o > lib-$(CONFIG_X86) += xxhash32.o > lib-$(CONFIG_X86) += xxhash64.o > > --- /dev/null > +++ b/xen/lib/strtol.c > @@ -0,0 +1,28 @@ > +/* > + * Copyright (C) 1991, 1992 Linus Torvalds > + */ > + > +#include > + > +/** > + * simple_strtol - convert a string to a signed long > + * @cp: The start of the string > + * @endp: A pointer to the end of the parsed string will be placed here > + * @base: The number base to use > + */ > +long simple_strtol(const char *cp, const char **endp, unsigned int base) > +{ > + if ( *cp == '-' ) > + return -simple_strtoul(cp + 1, endp, base); > + return simple_strtoul(cp, endp, base); > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > --- /dev/null > +++ b/xen/lib/strtoll.c > @@ -0,0 +1,28 @@ > +/* > + * Copyright (C) 1991, 1992 Linus Torvalds > + */ > + > +#include > + > +/** > + * simple_strtoll - convert a string to a signed long long > + * @cp: The start of the string > + * @endp: A pointer to the end of the parsed string will be placed here > + * @base: The number base to use > + */ > +long long simple_strtoll(const char *cp, const char **endp, unsigned int base) > +{ > + if ( *cp == '-' ) > + return -simple_strtoull(cp + 1, endp, base); > + return simple_strtoull(cp, endp, base); > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > --- /dev/null > +++ b/xen/lib/strtoul.c > @@ -0,0 +1,61 @@ > +/* > + * Copyright (C) 1991, 1992 Linus Torvalds > + */ > + > +#include > +#include > + > +/** > + * simple_strtoul - convert a string to an unsigned long > + * @cp: The start of the string > + * @endp: A pointer to the end of the parsed string will be placed here > + * @base: The number base to use > + */ > +unsigned long simple_strtoul( > + const char *cp, const char **endp, unsigned int base) > +{ > + unsigned long result = 0, value; > + > + if ( !base ) > + { > + base = 10; > + if ( *cp == '0' ) > + { > + base = 8; > + cp++; > + if ( (toupper(*cp) == 'X') && isxdigit(cp[1]) ) > + { > + cp++; > + base = 16; > + } > + } > + } > + else if ( base == 16 ) > + { > + if ( cp[0] == '0' && toupper(cp[1]) == 'X' ) > + cp += 2; > + } > + > + while ( isxdigit(*cp) && > + (value = isdigit(*cp) ? *cp - '0' > + : toupper(*cp) - 'A' + 10) < base ) > + { > + result = result * base + value; > + cp++; > + } > + > + if ( endp ) > + *endp = cp; > + > + return result; > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > --- /dev/null > +++ b/xen/lib/strtoull.c > @@ -0,0 +1,62 @@ > +/* > + * Copyright (C) 1991, 1992 Linus Torvalds > + */ > + > +#include > +#include > + > +/** > + * simple_strtoull - convert a string to an unsigned long long > + * @cp: The start of the string > + * @endp: A pointer to the end of the parsed string will be placed here > + * @base: The number base to use > + */ > +unsigned long long simple_strtoull( > + const char *cp, const char **endp, unsigned int base) > +{ > + unsigned long long result = 0, value; > + > + if ( !base ) > + { > + base = 10; > + if ( *cp == '0' ) > + { > + base = 8; > + cp++; > + if ( (toupper(*cp) == 'X') && isxdigit(cp[1]) ) > + { > + cp++; > + base = 16; > + } > + } > + } > + else if ( base == 16 ) > + { > + if ( cp[0] == '0' && toupper(cp[1]) == 'X' ) > + cp += 2; > + } > + > + while ( isxdigit(*cp) && > + (value = isdigit(*cp) ? *cp - '0' > + : (islower(*cp) ? toupper(*cp) > + : *cp) - 'A' + 10) < base ) > + { > + result = result * base + value; > + cp++; > + } > + > + if ( endp ) > + *endp = cp; > + > + return result; > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ Reviewed-by: Shawn Anastasio From xen-devel-bounces@lists.xenproject.org Tue Aug 01 17:06:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 17:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574446.899705 (Exim 4.92) (envelope-from ) id 1qQsop-0008FW-OG; Tue, 01 Aug 2023 17:05:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574446.899705; Tue, 01 Aug 2023 17:05:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQsop-0008FP-Le; Tue, 01 Aug 2023 17:05:59 +0000 Received: by outflank-mailman (input) for mailman id 574446; Tue, 01 Aug 2023 17:05:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQsoo-0008FJ-RK for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 17:05:58 +0000 Received: from frasgout13.his.huawei.com (ecs-14-137-139-46.compute.hwclouds-dns.com [14.137.139.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad73914e-308d-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 19:05:56 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.227]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4RFh6D0F8tz9yMKx for ; Wed, 2 Aug 2023 00:54:28 +0800 (CST) Received: from [10.81.206.119] (unknown [10.81.206.119]) by APP1 (Coremail) with SMTP id LxC2BwAn2bg5O8lkq2QeAA--.14915S2; Tue, 01 Aug 2023 18:05:17 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad73914e-308d-11ee-b25c-6b7b168915f2 Message-ID: <56be3268-60ee-a496-4781-a59ce34bfca8@huaweicloud.com> Date: Tue, 1 Aug 2023 19:04:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/9] Allow dynamic allocation of software IO TLB bounce buffers Content-Language: en-US To: Christoph Hellwig Cc: Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Jonathan Corbet , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , "open list:SLAB ALLOCATOR" , Roberto Sassu , petr@tesarici.cz References: <20230801160339.GB13111@lst.de> From: Petr Tesarik In-Reply-To: <20230801160339.GB13111@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:LxC2BwAn2bg5O8lkq2QeAA--.14915S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY77AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4A2js IEc7CjxVAFwI0_Cr1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE 6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72 CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4II rI8v6xkF7I0E8cxan2IY04v7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWrXVW8Jr1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6x IIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAI cVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVWxJr0_GcJvcSsGvfC2Kf nxnUUI43ZEXa7VUbJ73DUUUUU== X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected On 8/1/2023 6:03 PM, Christoph Hellwig wrote: > Thanks, > > I've applied this to a new swiotlb-dynamic branch that I'll pull into > the dma-mapping for-next tree. Thank you. I guess I can prepare some follow-up series now. ;-) Petr T From xen-devel-bounces@lists.xenproject.org Tue Aug 01 17:16:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 17:16:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574450.899716 (Exim 4.92) (envelope-from ) id 1qQsyi-0001Kk-N7; Tue, 01 Aug 2023 17:16:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574450.899716; Tue, 01 Aug 2023 17:16:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQsyi-0001Kd-J3; Tue, 01 Aug 2023 17:16:12 +0000 Received: by outflank-mailman (input) for mailman id 574450; Tue, 01 Aug 2023 17:16:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQsyh-0001KX-E7 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 17:16:11 +0000 Received: from mgamail.intel.com (unknown [192.55.52.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19060a7c-308f-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 19:16:07 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 10:09:56 -0700 Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 01 Aug 2023 10:09:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 10:09:39 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 10:09:38 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 10:09:38 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 10:09:38 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by SN7PR11MB6827.namprd11.prod.outlook.com (2603:10b6:806:2a2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 17:09:35 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 17:09:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19060a7c-308f-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690910167; x=1722446167; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+CCVzjLnbeSNysyEXz6yi7nFGWkI9dBZ7iOSmBeOerw=; b=NaiPaHnRpeayRFpt8Y3gMKnGyAjk6rHDSbtYcMH4ECwVZ8vWrtsdjQL7 i98ig4UQGiOUQ2Az+CYP6Zv9oH36pL8uV4PwgjAJAkdCd6zll8t7pOqFR hRJcJABhcg7htllFldGvFolENqtv4ZW3quhPd2IJSOM2oAfrAr8WTpsnl 0CCFrcexyTTLDjB01bES5smlTdBOkiVqTb9KfyuHr8CDBbHFS+O66Z1OA ml7pcSxKfcZ3gaof4KjyLxvPjAn9sjrLM5jf1G+SKsDRj/QyrTLO9gzmL 6eAbTb5MXjn2mvdWPDkawYKOdJDjbcLZXaFQD7A62zAPGJvLWcxnMzJXX g==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="400307989" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="400307989" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="678730789" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="678730789" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkCF/TeNkhevV1YALkTdsTqyojOTIoA9Udt5KouUzmStgo5TFsZtoryW7UIXCsyS4osT/JIuW+iZ4fiWt4WGFwDS35E2vFkGhsd5OO3c5SRWSGTzIAmlpDDG2n74lmIuC+lW8Ptyeg5uDxB2o7E6XeVV06YjF9wPv9CTg970KuccEuQT2llJtMNJt00lTN/KroFyS4AHTQ1nlox9WYtnYRLm540gS4pdaeTY3IlQtc9Phi4ixeqNYaa0ONDpXXCG3a4ukmI61wBxgTSohqu1tE1jY+GvG64Y/T/DehwDKOkXf9SNI+PWQdxMbhgJHNImX2MjWejkhu6hxjYKFd3/3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+CCVzjLnbeSNysyEXz6yi7nFGWkI9dBZ7iOSmBeOerw=; b=D3NPIsmaepn+W2gRk4wDV7WsarTPyBYJb7IqBfkaY76bSROZUXlp2+a6nCN3bhB7DTPPE8l2qAp/jZG4ZRhNDLlZGIU/e/skhwknLLaWYanYu+g8iAWPQAxm511bcvat/++vVAXsOmY8jGzk+KjnIR5T0+tUvYuT1owkcFskop6wjJHi619trZmQKCKRUEILhZkEzIuUfjS+IpY7ykjAf1U77fiRfvmXi0cJyU8zUT03zM2u8H4iXbQTTZ0FOQsLul9uOYfGZM4Z1clhcdkYnYDGytZ1DlKaaXY5p1JIIoLKM5J+czSxXsKIpRk6rCwGOIh68CE79OT3NdFyNpSpcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: Peter Zijlstra CC: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Jonathan Corbet , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Lutomirski, Andy" , Oleg Nesterov , "Luck, Tony" , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , "Cui, Dexuan" , Paolo Bonzini , "Wanpeng Li" , Vitaly Kuznetsov , "Christopherson,, Sean" , "Gross, Jurgen" , Stefano Stabellini , "Oleksandr Tyshchenko" , Josh Poimboeuf , "Paul E . McKenney" , "Catalin Marinas" , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , "Chatre, Reinette" , "Daniel Sneddon" , Breno Leitao , Nikunj A Dadhania , Brian Gerst , "Sami Tolvanen" , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , "Masahiro Yamada" , Ze Gao , "Li, Fei1" , Conghui , "Raj, Ashok" , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , "Jiapeng Chong" , Jane Malalane , "Woodhouse, David" , "Ostrovsky, Boris" , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: RE: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Thread-Topic: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Thread-Index: AQHZxFK8XA18LlhFCECR8aoFrmHwB6/VQ+oAgABgJaA= Date: Tue, 1 Aug 2023 17:09:35 +0000 Message-ID: References: <20230801083318.8363-1-xin3.li@intel.com> <20230801105236.GB79828@hirez.programming.kicks-ass.net> In-Reply-To: <20230801105236.GB79828@hirez.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|SN7PR11MB6827:EE_ x-ms-office365-filtering-correlation-id: bf9786ca-6ce3-4e4f-68d8-08db92b214c9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CDKQ0TjGJh/7/cVvM+pqz1HbOAdr5D2EtjMzX1Gx2Vi5AfP0mN/JUocX2BTFvTQLpZG7nDkBUEqyQYAAGI2l/SN7kKCGgYTRnwA7Kdd4mvqiGSInh8xE2AIFNWr5SPJy2EjUYiD1lFBEQb130JvD4Mjht6WUqRpXA1vDQoSJ0vhW7FC/j6WhIiSBFUEviCRWqB9WoYo/l1kEfX7FW7stNtZHvnkfS/qXNv84H/9V6K0yc+6wa2fm1v8AP2mcsGKF5euS+srWr24YfLb1cgsB8USI4HHlShimvUeFshzxcMeXzz7fbg2YuzZzo7kWZSOT+WNKKh4uR31wk2FIqt0tQY0QPW1MvXbsZz/i7vqWq2TxWfs0hT9MphjZAeh2DJuu/GqLExiIBd9OQ3TkoULzC+ZTG/f/gYOPWTjVdXcapz3FkdsPiG6VXNi5b4y5FFYaGmCrt+9Uyb7f+e4f2hKWaQUJ/Z0TV/RagM2I/XD4Q2TKh927AX8B30ZDjLS8LFqWU+s5J6hI647m9CG89Pil3znLv1r5kv7TTxGNzgmHgqE3l4jjVm8fe6RSV7wlMWBHOFJ4UxgaJjKpRZ0BzZLQFT2/HzKXEH9dmeDCLQeGkjtsK0GSc6+S3AD3+K1WZsPX x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199021)(478600001)(38100700002)(82960400001)(122000001)(55016003)(86362001)(33656002)(38070700005)(9686003)(7696005)(71200400001)(7416002)(186003)(8676002)(26005)(8936002)(6506007)(7406005)(5660300002)(76116006)(7366002)(52536014)(2906002)(4326008)(66446008)(66556008)(64756008)(6916009)(66946007)(66476007)(54906003)(41300700001)(316002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?81Tp7M1Ra2r7Mk/hI8OqMUQD86NtOytB/N1LDRFjK4VO5A6Tmqt58QWm+DNX?= =?us-ascii?Q?ncwjOAgmEANPbQsvM6qvlfSnCIRhvxWpIrNMtRQ7v6SDJv9XR7cjscMn8N4W?= =?us-ascii?Q?3v6iUSY2VHDiKHHhy+zWLAZbh9jjpflAryi/1MIBztyq0v5/LhrpAZ/Fevp1?= =?us-ascii?Q?sxTMVAcm7A1tjB5QmBX2xe5QIuH9KtRdYPTXD80nN3WiGJUFuc1wpyyWuYlt?= =?us-ascii?Q?nKuMYZDWXnUmCViHFM0t9gS9okT1LJK6l3tq+NXmP0rXtxT6aWctvRpQtC5S?= =?us-ascii?Q?WHcNFwEx2xkw2fX/mTJMeOZterP3BNcdcRlcG7Q2xwr5f7UsC31ajfjE4qBE?= =?us-ascii?Q?ox72dkKunRiCWtPLfhsG3K1wVU+lLelFEmDTNojdLFjrmmDP3Va0nyI1yley?= =?us-ascii?Q?IQTlUduKi/WByOo6QAQtTG4DgfMHUfXVc9ZqpSHizZzfQHmHqvtkGCw7QsDG?= =?us-ascii?Q?ggnrka5KPKvLGG2NtYxcdGzJUWJcS8mGJKGS4GkGZLOyMLXJ3M1AwITAyLBV?= =?us-ascii?Q?V1LGjgCyRsMO2NOpZFZ81QMz8iPEFu0Ji82WfAqh+5cr8x57UyTlDyoujX5V?= =?us-ascii?Q?BccV2rjNm436169kADd4aHNwcXOZFPkKSO0xGcq8cQ0A5cnKKxg8t+hvCE3T?= =?us-ascii?Q?BBi+CBLaXooEnk4wdLsX43Hk0aAnsdFnJz7MNP55BPD/RNKMpJZfDjqw60X9?= =?us-ascii?Q?Qk1pnlcSiUJ6KwlF8g/GRxv2IUfyBels5tvyMPzOac9UmvKSa57pFbzJ+61v?= =?us-ascii?Q?uC+aSpU3ZjUNKWsixaxgw24EtMjpgFA7S/MRCRm9PeI6efEubftgRpwToumd?= =?us-ascii?Q?PXiE1wD0oBMFa1eq09KG3HQZFA3OASj2iYb6UbRbRszkQZo5lfh4xScCqshK?= =?us-ascii?Q?9bxo+92dvyyQEB9Q9Bo+vArHsAMlJMAMFxvM7+jC7WQN1kNPFDRqwG8Wsld6?= =?us-ascii?Q?1lcvhidq19e/+DcMyIhGdXLaOKjZKHDFdBIwNMMhbHJEHPIVxXw5nydvWDoW?= =?us-ascii?Q?R2IBra0+Vr+ToNElPRe1AC/cXx5XkZQLIsZsOY68pRdesLEGNXpbrHubFI9v?= =?us-ascii?Q?VZXodzZ5zBJvruHH7JcFmf641qKLYVlH0VE1R4Aj8T+5Ru46q/oQBfKYdXOT?= =?us-ascii?Q?t1gp3XYcHZfBio4zWJNYdIo5AdkXIpzuXztZsF61e1hmq3bCyI/VO2cjkPY0?= =?us-ascii?Q?WfRg6Otzupp8axwCAT+qAPLpBJDUUgCviGrjN0IgSeyadVW43M5p6Ul2Edlp?= =?us-ascii?Q?FS/0Iip2r/i61WFADtCVL7ebirqQIzdlePzPGhHdhxwxuGjyHLhEFctmA3Ao?= =?us-ascii?Q?p96at9KyjsIPNM+3VJI6Rydiz650kNb7jgbLhF1THKxaaZaqibklvwd2em0c?= =?us-ascii?Q?6vlSN+2Jb2bGpNSeu+GEXTw5FPnSH305Oy9HiCL12gMSDsZ9TUgz8ogS2CXf?= =?us-ascii?Q?RwgLaKy5tG/CP6/DOObNvAGRo9rjrtrukFgxDl0rdpYWw5JdFSOXoim4qpIk?= =?us-ascii?Q?qJo5Rgmn+i2KCPth9odVnamVKNHd2fXaB9i3kccf+DqUPiIXKMIU9r48bYfi?= =?us-ascii?Q?2oP9NNwXK14SuEpWbIQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf9786ca-6ce3-4e4f-68d8-08db92b214c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 17:09:35.3481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dz4UjiirvuvXZbLrF9Wf+pNK1IwNG9f98n0EuAQ9Srl+HrTQFnxuOMeSLtsM1hpe7/6aQDL/a8rzB42L96M0Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6827 X-OriginatorOrg: intel.com > > Resend because the mail system failed to deliver some messages yesterda= y. >=20 > The one from yesterday came in 6 thread groups: 0-25, 26, 27, 28, 29, 30-= 36, > while the one from today comes in 2 thread groups: 0-26, 27-36. Which I > suppose one can count as an improvement :/ Sigh, sorry for the chaos. > > Seriously, it should not be hard to send 36 patches in a single thread. No, but it worked fine before thus I didn't realize there an email service policy which prevents sending email to too many recipients in a short period (I have a long CC list in this v9 patch set). > I see you're trying to send through the regular corporate email > trainwreck; do you have a linux.intel.com account? Or really anything > else besides intel.com? You can try sending the series to yourself to > see if it arrives correctly as a whole before sending it out to the list > again. I did try sending to myself before to LKML, and it worked fine. But now you know why it happened. As mentioned, I should avoid "the regular corporate email trainwreck" before doing it again. Working on it... From xen-devel-bounces@lists.xenproject.org Tue Aug 01 17:41:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 17:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574455.899725 (Exim 4.92) (envelope-from ) id 1qQtNS-0004hh-Nu; Tue, 01 Aug 2023 17:41:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574455.899725; Tue, 01 Aug 2023 17:41:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQtNS-0004ha-K3; Tue, 01 Aug 2023 17:41:46 +0000 Received: by outflank-mailman (input) for mailman id 574455; Tue, 01 Aug 2023 17:41:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQtNQ-0004hU-DQ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 17:41:44 +0000 Received: from mgamail.intel.com (unknown [192.55.52.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab53decd-3092-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 19:41:41 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 10:41:37 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 01 Aug 2023 10:41:37 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 10:41:36 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 10:41:36 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 10:41:36 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 10:41:36 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by CO1PR11MB5027.namprd11.prod.outlook.com (2603:10b6:303:9d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.40; Tue, 1 Aug 2023 17:41:32 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 17:41:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab53decd-3092-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690911701; x=1722447701; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qS4CPA9EKW0OJfbbVJ1lseYCR6nfbdaDN/hUHotm144=; b=EsITI6D3wObpHectKQcbgkv6sZVwRu24fFdDQ62R/v5+6h+jcTfbpNpU TFNdV/GDddW5CuJJX3F+eIGP3dO/cBu82tl+ZWqoatFvM7K5r1Nz6Pp5R 08WSD8O50oIgsA/bYWeVP8Rcbb6VhslXsQ0Tdip5GypJT0lU3fmEd/azj meWltgHmnfOWl7chQu2c6FD45E+9e9Y55lWo71STTDT6iAftUhlmQY1xk S1h17LhReIBY3OvRvK8oMptOq8Jp1DvKODVDMDFkioV/9KaFJEvO7REox /LiKrkqfx7qwkEcU/Y+LSk5A82X1qITstaPlFKNwHTUMQGWJduP20M7K/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="455741882" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="455741882" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="798769997" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="798769997" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwlyRzHtPWPBWGy8ggnGXWwtcrp8MX+Xf1eokRZNd4nAt1o6ipc44ZvEvAkl7YETGQVtvbbVW3050FLPH+zvbdjlXMs7YmqCE+n7AJe5sVTDJoufe21b6tTRUR8wUNo1uyAZVeM/c4nyaRTJJnFXOHJ8/gbIdYY7roS1XxW7gZZioNkk13HzMMDIZYDS/S5hQAuLNlwg82l9Q61r1OiSR+dXf+efQMbV+5z9yb+FnudPM/0VdZyatRBsn8+911E5DLq3n0xmzsoG96/Hfz2s4ncejFsRWCcO2v5DpBOdQBWy45P78tgASpo0/NglAXnKJV/wuC+vDLNY/1hfYpRLQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/oGFI5LY6O1zy/8NOdL5CXeIwuqJxl0Y5UaYhyX0+40=; b=HzIbP6eKwQE8AZmyUY533nfBewWcmY1wPA3r+3SyVBdm/hhEffA6OeV/v3Qfth/uEXqmdJ7RVs28m80cyEQbV3YPz09lS2T9RqONhfcqWsHow3m9Cb6m9qempvxwZsCjaHYDycfE3sOSoZ6G2rtoMN7brYMk35sYVzu2Q530hcg9k3Ia/os2ZRg2V6mVrLT2vb/MfNApYKAdD8smK2ONGF/6jA+YM9iQzuBc9GyjfWLxP14NNi1Tt70+3EaY1Cc0UXIu4gLJRuBt5i89zyU5vXyvmERZg4mydGCQGDAo4QT1cjQns97bDbO3nciM+EXSoIKFOgpxrw/+v1vYrj0dMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: Peter Zijlstra CC: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Jonathan Corbet , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Lutomirski, Andy" , Oleg Nesterov , "Luck, Tony" , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , "Cui, Dexuan" , Paolo Bonzini , "Wanpeng Li" , Vitaly Kuznetsov , "Christopherson,, Sean" , "Gross, Jurgen" , Stefano Stabellini , "Oleksandr Tyshchenko" , Josh Poimboeuf , "Paul E . McKenney" , "Catalin Marinas" , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , "Chatre, Reinette" , "Daniel Sneddon" , Breno Leitao , Nikunj A Dadhania , Brian Gerst , "Sami Tolvanen" , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , "Masahiro Yamada" , Ze Gao , "Li, Fei1" , Conghui , "Raj, Ashok" , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , "Jiapeng Chong" , Jane Malalane , "Woodhouse, David" , "Ostrovsky, Boris" , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: RE: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Thread-Topic: [PATCH RESEND v9 00/36] x86: enable FRED for x86-64 Thread-Index: AQHZxFK8XA18LlhFCECR8aoFrmHwB6/VQ+oAgAAkVwCAAExQ8A== Date: Tue, 1 Aug 2023 17:41:32 +0000 Message-ID: References: <20230801083318.8363-1-xin3.li@intel.com> <20230801105236.GB79828@hirez.programming.kicks-ass.net> <20230801130240.GA80967@hirez.programming.kicks-ass.net> In-Reply-To: <20230801130240.GA80967@hirez.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|CO1PR11MB5027:EE_ x-ms-office365-filtering-correlation-id: 816e65fe-dfe9-4a81-1eb4-08db92b68b91 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hbZBEgrMrSkukRlhRInro59naLc8vtW89qNg99W/JoEDrg1vZPjqBg/u4FEzRpbdt5HO9n3YhZ+s60rOGWaeJ4JvOlhgRK+NI7ATnneSDZB4P8FcKWam+yYn+En8JNkDAbgqyuyC8QakgKIZA+D2KeDhu2oDW8/ROyrASOQ0qZPC4SM/XL86ffPCul1P99rEXmh2yIGFw4NmyzfwsB53noi5Oztj+ERI1eXQioteUH1Dx9amYk7hAuohNJvRuAPS/Cw/Nn0Wsv8Gq4/j6OJz+tfFCoQdTVI6HdhBphRkuxsen359RArg0aFjQNikQGKVaAdBoZrM6xLtq+9olf4YyDzbCu8Qf5nAnAKU8owMWW0g0sICXRfQ4E9HnBu0TCHEeVybq3g3jaCItPv+dzkyu68aba2LVGF2V+0gcweu8WMWQl8erzUZy8WRgvZ/cZ7GRPjhmkB6xHaMyER/roQfGUOdqQYe8SGUUIDsj2CsdtdJR5qYu30cretfK62yJ1S/V0dF38SEyrrokSZlroSm70S6Xs6cLk2XOaUSqe3FCFdx1vubUU8nImxh+1JwOHanjOveg9TNGYl4WfBQYGv2UmadFzty42nWii5hQE4E0dI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(396003)(39860400002)(366004)(346002)(451199021)(38100700002)(66476007)(86362001)(316002)(8676002)(8936002)(64756008)(5660300002)(66446008)(4326008)(6916009)(41300700001)(54906003)(7416002)(7366002)(122000001)(33656002)(52536014)(76116006)(66946007)(66556008)(82960400001)(7406005)(38070700005)(478600001)(4744005)(2906002)(71200400001)(966005)(9686003)(7696005)(6506007)(26005)(186003)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9S376hmpo4BhJC85NLrvpSb+4HNunXLP+7Y/90z2sNCXPaYTJCGYBVP69XP3?= =?us-ascii?Q?R38CnDhUy12iDryXj356vd70qWLvkFEPPnKs9QSXPMeQn9e1+2KDwqV5q1Ad?= =?us-ascii?Q?UDxSob9WX8WY5Rtl5bQxzb8q43+ay5YjBdtj76fpa8ly1YR79IVBcSwzkpAC?= =?us-ascii?Q?ONS0Wt7DqTJVkYUCmW45kipLv/LJEt/VplBKs4VRqiKojV+gFelT8ruP5nju?= =?us-ascii?Q?nnf5u+xEQPYQC7ARPBaHqo67gm41GaHZOmBAXDSMqrJkK15mVHhsHS8Q1RcJ?= =?us-ascii?Q?9R8DdjEl7GpIFZGQT+UQ6glJDwBAjckQLOFcdegodVfGebaP9eJF0kpni/1I?= =?us-ascii?Q?TxkRJCJTi32sMkOsW+MDfkvrCLGohEBY5TiR+5Dd4gofRICcWePlLVn8eK76?= =?us-ascii?Q?6VEaCKB+Uo/ItV6nsCtMBinmbMpiYwUs2m6Va1RrhpSpUnKw+II8QMMD+Slv?= =?us-ascii?Q?qNZoVjjTb+Gaj8rUaMOevgnXQ46B2zEGomEFpRVrw0VIoQ+sojxKTqfshlJB?= =?us-ascii?Q?3xLN4uYWs5jdDjENcukBUdQXmmtkq4AWnYiXUZ9JZBo/dE3dYIve6PWU6U/G?= =?us-ascii?Q?JoGzKouwiw/GrEo08HPIsaDkguQnlTgeNW1BypWbTfs5uS+pLoVwgosokYg2?= =?us-ascii?Q?eaHu7sk+9s7T9eQSBLZCjSQ7YNvm5oSJiMmBAV77CTZTRTRxtiMY4Y2e6h4M?= =?us-ascii?Q?tWHJkxUT2TMBpHX8bp8IMbTv0tzcTSJQG8ZCgHdnQzZudDK0/9g1ZTGziQiL?= =?us-ascii?Q?mOPoWDyiAcqbAu1Mxa54pTkvbdivC5ItrM7AQvQt0TG6Cc/Bgg2ZIYV3ZgGK?= =?us-ascii?Q?YKvRfjt2S5aPMkboAPOv2U3CZTAHmkyXHKZpqPz+ulJ5sZHaB3BB3rGPLcl5?= =?us-ascii?Q?ilQ9REuSRMtvNsq/JFBqm2KRd8RYP9GRxuU25ydzTFzcoOV/uxDEf5NFI0jn?= =?us-ascii?Q?mVRrXjWMPe+saQ/jDa7+UUS5l5cAHHgLuOHs0P+RuuLBZqKMotgu/acYbUlE?= =?us-ascii?Q?UUiVrd2ERZXQFJWhxcr2SpULzLqLe6ik5r1JB0NTnJ7UuCIxDOSgYDQbVqYm?= =?us-ascii?Q?EmdfFu/TTfFaBjUmkoecNcArt3qFdhTkBS/CIjcJPCChqHu3WP0K2p28/5WA?= =?us-ascii?Q?hSvl68zkyS+e1TkrvKNYXQ6gGiz5I9c6eVFSgdxPB47mtia4F6L+cKf9QxhM?= =?us-ascii?Q?/hgaq9FZsNxiEKICf/WTsNBxI3SF5Y7t28bNWGghrCMEQ/Zdt0Xu1ThATuwp?= =?us-ascii?Q?Y8V9WxSVmsqHHf3l6P0jVmEx5RXzwLbnjmxRj0agul8u9RaQtfTPVv3rOS+3?= =?us-ascii?Q?RA28LWVNpXQZ8hQs229ahH7zwrWqwyKmb13SCjTGTZZIFQeC8sx4TQI4EXn8?= =?us-ascii?Q?tDtzWwZWbU/8KFRZ2dLW6QZQGJN+IRFztg6CZB0aBRP5UNYu9sfwYOFkOuOn?= =?us-ascii?Q?I8xzAm74L+de8SMApxaOSFrNIJ+0LmJ5Uq4Z3dyzvyMwXOYkQrzqfC7+z/Sr?= =?us-ascii?Q?sitm0GKIm9ob3fuTsribPqNmnLDJOkM8J1XMIM300Vn2svzZIuiCVYdC5tc0?= =?us-ascii?Q?c5H/mL8qbblKNUsarks=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 816e65fe-dfe9-4a81-1eb4-08db92b68b91 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 17:41:32.5745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Kr0p4GM7rbulXd6menIn/NIkH7YsL0JXwhFRCBBrfmbU0hxYTP9IhCqLJRY2JshGhxJ/9DwLX/odK2AoYSxrYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5027 X-OriginatorOrg: intel.com > > I also believe there is a kernel.org service for sending patch series, > > but i'm not sure I remember the details. >=20 > https://b4.docs.kernel.org/en/latest/contributor/send.html It says: The kernel.org endpoint can only be used for kernel.org-hosted projects. If there are no recognized mailing lists in the to/cc headers, then the submission will be rejected. If I want to test the email sending service, how could I test it with sendi= ng just to myself? Maybe it allows only sending to the sender. From xen-devel-bounces@lists.xenproject.org Tue Aug 01 17:49:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 17:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574460.899736 (Exim 4.92) (envelope-from ) id 1qQtV5-0005P7-Kk; Tue, 01 Aug 2023 17:49:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574460.899736; Tue, 01 Aug 2023 17:49:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQtV5-0005P0-ID; Tue, 01 Aug 2023 17:49:39 +0000 Received: by outflank-mailman (input) for mailman id 574460; Tue, 01 Aug 2023 17:49:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQtV4-0005Ou-HJ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 17:49:38 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6df2ccf-3093-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 19:49:35 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1bb81809ca8so46969665ad.3 for ; Tue, 01 Aug 2023 10:49:36 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9100:2cb0::94c8]) by smtp.gmail.com with ESMTPSA id c5-20020a170902c1c500b001b85a4821f8sm5012699plc.276.2023.08.01.10.49.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 10:49:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6df2ccf-3093-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690912175; x=1691516975; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HD89QJtBs0B8JZHVQe5+HG6SdeeQku6GpLIOjBFTcZg=; b=FIezstmcY3HMWQdOQPd1AuBW9Iyn2ARm4WhVc602oO/wNpI0MrNjQp4zuaM94Xhm7p d/hIQsmzsLHvKFnLwlTTL/R3olmENOAwzeOgTlQSl2HLMmHbFFsJ2b7q6kXPmzP1LEWQ SYa1pL3jC3/Beal0bs2hayYQOTjd2GIjF3RLJ21HW2lQwo9vacEG0UPk7CegBjzQIaM7 7iOxjIM5+ZV68XjBgj9uOEzFJ5Lw4ZX2PKQ+5caTlMmbFsRCy3a3cjqAVUU2gd76NVHG vQ9DGao+ZA2eVGVaEbdynMmvjwelkQRW0uBWqZWy05vUh7v58gop6uFEHxSm8e1IJ9Qo HKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690912175; x=1691516975; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HD89QJtBs0B8JZHVQe5+HG6SdeeQku6GpLIOjBFTcZg=; b=SLU3ELDxE6Ua5wO+yIXCAPQYn0tA0Z7MVqi4uCRDdnpBqDmlQj8fDGljNb2ttwu5Nn V9v0EExVKczzMgGRgQh3pfMWeDcSOPgMZJ0IJlMy5xopNOkpuA9/seK/ycfm4JRYIfxx pmWMVldStGxUsRZq/z18AySi6BLC7vxGFtfsNcCA4NBEuHDVie6ACOim0xMcgTnwhlSY nwU3JMtuJIB/9od/M7TMgYAot8JRW8NDiNjUIZ5uGC4T6Bgry52zMTIJ5cJy+Mjx+bqU tbHCx+820wpfVE0lRsRRFt07t1xEId2WOVNrrjzC+XGb0GtX+SKOnf8UAsCJLmb9cftH LclA== X-Gm-Message-State: ABy/qLYsVDjFUtEej+yW+xc1T3Viv9HvIJ4DmJ+wLYAMvStli2cL4Bu3 WZGYKMrF1MBSicJ8QJ//7Vq3FGfSGGQk8g== X-Google-Smtp-Source: APBJJlGm7gIbbgr3MmRCHl5ITFMri5K7SK1TIt3OY5+nDlwX6uOT0xTOzP7+TH3raQZyU8537vnafw== X-Received: by 2002:a17:902:c947:b0:1bb:ab0d:4f76 with SMTP id i7-20020a170902c94700b001bbab0d4f76mr17561709pla.58.1690912174564; Tue, 01 Aug 2023 10:49:34 -0700 (PDT) From: Khem Raj To: xen-devel@lists.xenproject.org Cc: Khem Raj , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Michal Orzel Subject: [PATCH v2] arm32: Avoid using solaris syntax for .section directive Date: Tue, 1 Aug 2023 10:49:30 -0700 Message-ID: <20230801174930.2995947-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Assembler from binutils 2.41 rejects [1] this syntax .section "name"[, flags...] where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] It is almost like a regression compared to 2.40 or older release, It likely went unnoticed so far because Linux kernel changed to GNU syntax already in 5.5, to allow building with Clang's integrated assembler. Switch to using GNU syntax .section name[, "flags"[, @type]] [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 [2] https://sourceware.org/binutils/docs-2.41/as.html#Section Signed-off-by: Khem Raj --- v1 -> v2: - Improvise on commit message - Make similar change in xen/arch/arm/dtb.S xen/arch/arm/arm32/proc-v7.S | 6 +++--- xen/arch/arm/dtb.S | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S index c90a31d80f..6d3d19b873 100644 --- a/xen/arch/arm/arm32/proc-v7.S +++ b/xen/arch/arm/arm32/proc-v7.S @@ -29,7 +29,7 @@ brahma15mp_init: mcr CP32(r0, ACTLR) mov pc, lr - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca15mp_proc_info, #object __v7_ca15mp_proc_info: .long 0x410FC0F0 /* Cortex-A15 */ @@ -38,7 +38,7 @@ __v7_ca15mp_proc_info: .long caxx_processor .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_ca7mp_proc_info, #object __v7_ca7mp_proc_info: .long 0x410FC070 /* Cortex-A7 */ @@ -47,7 +47,7 @@ __v7_ca7mp_proc_info: .long caxx_processor .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info - .section ".proc.info", #alloc + .section .proc.info, "a" .type __v7_brahma15mp_proc_info, #object __v7_brahma15mp_proc_info: .long 0x420F00F0 /* Broadcom Brahma-B15 */ diff --git a/xen/arch/arm/dtb.S b/xen/arch/arm/dtb.S index c39f3a095c..386f83ba64 100644 --- a/xen/arch/arm/dtb.S +++ b/xen/arch/arm/dtb.S @@ -1,3 +1,3 @@ - .section .dtb,#alloc + .section .dtb, "a" GLOBAL(_sdtb) .incbin CONFIG_DTB_FILE -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 17:52:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 17:52:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574463.899745 (Exim 4.92) (envelope-from ) id 1qQtXN-0006of-0V; Tue, 01 Aug 2023 17:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574463.899745; Tue, 01 Aug 2023 17:52:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQtXM-0006oY-U7; Tue, 01 Aug 2023 17:52:00 +0000 Received: by outflank-mailman (input) for mailman id 574463; Tue, 01 Aug 2023 17:51:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQtXL-0006oO-Fx for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 17:51:59 +0000 Received: from mgamail.intel.com (unknown [192.55.52.120]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 170b10fc-3094-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 19:51:54 +0200 (CEST) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 10:51:47 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 01 Aug 2023 10:51:43 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qQtX2-00DKb2-0b; Tue, 01 Aug 2023 20:51:40 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 170b10fc-3094-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690912314; x=1722448314; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=23Wc3k0mFLbrQycUcEsHy3FEUV7003iJlGRdyTKc6ms=; b=PCUoIkXMQeK6PgQqyzurFvxhlQkIf3OUGJ1J2qKMomkcrETlAdSnp1GD rU8AiWlWtXaXuWdghcFoEIJ7Yz5CM12CRk/9BrS36Oezi/0NBosa+5/km M7gW3PiDBYp75S/MYFyMe25TtKJPIcj7Ed01Q/0sGaIpCkKa/LSzFXx+U QnTlc+iThqyfcoJBSy5IQgQt23D7H8kQ3PNmTcl+D1ZP4/dp2jiH9A5Pt urMCwDcikMi72miS23C2Ko0SPeV2Gc6ONlnT5IBygkR/hGbC0Ilfj70tY 3tm0S41Q+mRy7xVc2J2/rfxPzPk/sQMgWykG4yn80wAVZ6lLAofgzRXYl Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="368273820" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="368273820" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="758441153" X-IronPort-AV: E=Sophos;i="6.01,247,1684825200"; d="scan'208";a="758441153" Date: Tue, 1 Aug 2023 20:51:39 +0300 From: Andy Shevchenko To: Takashi Iwai Cc: Mark Brown , alsa-devel@alsa-project.org, Andrey Utkin , Anton Sviridenko , Arnaud Pouliquen , Banajit Goswami , Bluecherry Maintainers , Claudiu Beznea , Ismael Luceno , Lars-Peter Clausen , Mauro Carvalho Chehab , Oleksandr Andrushchenko , Olivier Moysan , Srinivas Kandagatla , linux-media@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Message-ID: References: <20230731154718.31048-1-tiwai@suse.de> <87h6pjj2ui.wl-tiwai@suse.de> <87leeugbxm.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leeugbxm.wl-tiwai@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: > On Mon, 31 Jul 2023 21:40:20 +0200, > Mark Brown wrote: > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > > > Mark Brown wrote: > > > > > > It really feels like we ought to rename, or add an alias for, the type > > > > if we're going to start using it more widely - it's not helping to make > > > > the code clearer. > > > > > That was my very first impression, too, but I changed my mind after > > > seeing the already used code. An alias might work, either typedef or > > > define genptr_t or such as sockptr_t. But we'll need to copy the > > > bunch of helper functions, too... > > > > I would predict that if the type becomes more widely used that'll happen > > eventually and the longer it's left the more work it'll be. > > That's true. The question is how more widely it'll be used, then. > > Is something like below what you had in mind, too? I agree with your proposal (uniptr_t also works for me), but see below. ... > +#include > +#include But let make the list of the headers right this time. It seems to me that err.h minmax.h // maybe not, see a remark at the bottom string.h types.h are missing. More below. ... > + void *p = kmalloc_track_caller(len, GFP_USER | __GFP_NOWARN); > + > + if (!p) > + return ERR_PTR(-ENOMEM); This can use cleanup.h. > + if (copy_from_uniptr(p, src, len)) { > + kfree(p); > + return ERR_PTR(-EFAULT); > + } > + return p; > +} > + > +static inline void *memdup_uniptr_nul(uniptr_t src, size_t len) > +{ > + char *p = kmalloc_track_caller(len + 1, GFP_KERNEL); Ditto. > + if (!p) > + return ERR_PTR(-ENOMEM); > + if (copy_from_uniptr(p, src, len)) { > + kfree(p); > + return ERR_PTR(-EFAULT); > + } > + p[len] = '\0'; > + return p; > +} ... > +static inline long strncpy_from_uniptr(char *dst, uniptr_t src, size_t count) > +{ > + if (uniptr_is_kernel(src)) { > + size_t len = min(strnlen(src.kernel, count - 1) + 1, count); I didn't get why do we need min()? To check the count == 0 case? Wouldn't size_t len; len = strnlen(src.kernel, count); if (len == 0) return 0; /* Copy a trailing NUL if found */ if (len < count) len++; be a good equivalent? > + memcpy(dst, src.kernel, len); > + return len; > + } > + return strncpy_from_user(dst, src.user, count); > +} ... > +static inline int check_zeroed_uniptr(uniptr_t src, size_t offset, size_t size) > +{ > + if (!uniptr_is_kernel(src)) Why not to align all the functions to use same conditional (either always positive or negative)? > + return check_zeroed_user(src.user + offset, size); > + return memchr_inv(src.kernel + offset, 0, size) == NULL; > +} ... Taking all remarks into account I would rather go with sockptr.h being untouched for now, just a big /* DO NOT USE, it's obsolete, use uniptr.h instead! */ to be added. -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Tue Aug 01 18:23:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 18:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574468.899757 (Exim 4.92) (envelope-from ) id 1qQu1U-0001ty-E7; Tue, 01 Aug 2023 18:23:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574468.899757; Tue, 01 Aug 2023 18:23:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQu1U-0001tr-9T; Tue, 01 Aug 2023 18:23:08 +0000 Received: by outflank-mailman (input) for mailman id 574468; Tue, 01 Aug 2023 18:23:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQu1T-0001tk-BQ for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 18:23:07 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 746a07b3-3098-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 20:23:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 8BC9982853A7; Tue, 1 Aug 2023 13:23:03 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XoBu06R2ebb9; Tue, 1 Aug 2023 13:23:02 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 59AC882853DF; Tue, 1 Aug 2023 13:23:02 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oGYoZW4Pvb6j; Tue, 1 Aug 2023 13:23:02 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id D0D4C82853A7; Tue, 1 Aug 2023 13:23:01 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 746a07b3-3098-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 59AC882853DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690914182; bh=vVuA9sK/GcfstVkfqozkCI+BlEvlmi8R5qcN3jfU8M0=; h=Message-ID:Date:MIME-Version:To:From; b=o1vhQOZKVOtzzCyoQltX3q4FyeFhIrOxoTpOjgmBtvy2ZGZflBNIhWNKozO6WApYF y10jxpmw8p1KcFfLvn8C7lzyFwt/QemE82irZbNTG5OKz7q0J/ubq07mnY6sbxsDnB Z6BzbJ8cS8MM05c7YAdGYHoKNfrhN3T7u93XyON8= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <3b492bff-6ef6-f242-7d74-206a599afaab@raptorengineering.com> Date: Tue, 1 Aug 2023 13:23:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <335ce2a18f8cce679dd8b30d11560989131b4337.1690579561.git.sanastasio@raptorengineering.com> <0b2cb188-bcb1-1ed3-1181-9e1d0d98ab4a@suse.com> From: Shawn Anastasio In-Reply-To: <0b2cb188-bcb1-1ed3-1181-9e1d0d98ab4a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/23 7:20 AM, Jan Beulich wrote: > On 28.07.2023 23:35, Shawn Anastasio wrote: >> @@ -11,16 +13,19 @@ ENTRY(start) >> FIXUP_ENDIAN >> >> /* set up the TOC pointer */ >> - LOAD_IMM32(%r2, .TOC.) >> + bcl 20, 31, .+4 >> +1: mflr %r12 >> + addis %r2, %r12, .TOC.-1b@ha >> + addi %r2, %r2, .TOC.-1b@l >> >> /* set up the initial stack */ >> - LOAD_IMM32(%r1, cpu0_boot_stack) >> + LOAD_REG_ADDR(%r1, cpu0_boot_stack) > > Question: Would perhaps make sense to use %sp and %rtoc in place of > %r1 and %r2 (not just here of course)? In my opinion, usage of the aliased register names ends up making the code less clear. From xen-devel-bounces@lists.xenproject.org Tue Aug 01 18:24:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 18:24:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574471.899766 (Exim 4.92) (envelope-from ) id 1qQu2w-0002RF-Na; Tue, 01 Aug 2023 18:24:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574471.899766; Tue, 01 Aug 2023 18:24:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQu2w-0002R8-KO; Tue, 01 Aug 2023 18:24:38 +0000 Received: by outflank-mailman (input) for mailman id 574471; Tue, 01 Aug 2023 18:24:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQu2u-0002R0-Qp for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 18:24:36 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa2c0585-3098-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 20:24:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 2399D8285497; Tue, 1 Aug 2023 13:24:34 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pfcc-9Db09eW; Tue, 1 Aug 2023 13:24:33 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 3BDFC82853DF; Tue, 1 Aug 2023 13:24:33 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jA2m5m0n0gwk; Tue, 1 Aug 2023 13:24:33 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id C738F82853A7; Tue, 1 Aug 2023 13:24:32 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa2c0585-3098-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 3BDFC82853DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690914273; bh=J+KyGv3B071ltB41m2dhkYpEyS/dfVfCw6N9IXMQuXg=; h=Message-ID:Date:MIME-Version:To:From; b=tFc/gBF/GYxmm8tIU0WS0JMCr4nz2Xp63agoBUSIKNk3ohVAGCsIxeKadhCMQVYEs FW5nU1Z3etiUCug82F13hvV/PpJnhWEVPgs8Sx5/eYyWPoQMEyzUyXJYUzv94T2QMe yPEE0Tmc04Kx3swFnGlfiV9MLfcbtJL4GoH2dljY= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: Date: Tue, 1 Aug 2023 13:24:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/5] xen/ppc: Parse device tree for OPAL node on PowerNV Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: From: Shawn Anastasio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/31/23 11:06 AM, Jan Beulich wrote: > On 28.07.2023 23:35, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/arch.mk >> +++ b/xen/arch/ppc/arch.mk >> @@ -10,5 +10,5 @@ CFLAGS += -mstrict-align -mcmodel=medium -mabi=elfv2 -fPIC -mno-altivec -mno-vsx >> LDFLAGS += -m elf64lppc >> >> # TODO: Drop override when more of the build is working >> -override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o >> -override ALL_LIBS-y = >> +override ALL_OBJS-y = arch/$(SRCARCH)/built_in.o common/libfdt/built_in.o lib/built_in.o >> +override ALL_LIBS-y = lib/lib.a > > Can't you drop the ALL_LIBS-y override right here? Just tested this and it does indeed work. I'll drop the override in v2. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Tue Aug 01 19:01:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 19:01:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574478.899775 (Exim 4.92) (envelope-from ) id 1qQucV-0006rl-G6; Tue, 01 Aug 2023 19:01:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574478.899775; Tue, 01 Aug 2023 19:01:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQucV-0006re-DT; Tue, 01 Aug 2023 19:01:23 +0000 Received: by outflank-mailman (input) for mailman id 574478; Tue, 01 Aug 2023 19:01:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQucU-0006rY-Fk for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 19:01:22 +0000 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [2607:f8b0:4864:20::1149]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb8b08c9-309d-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 21:01:18 +0200 (CEST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-583312344e7so74397927b3.1 for ; Tue, 01 Aug 2023 12:01:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb8b08c9-309d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690916477; x=1691521277; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6dm7mDs/QRbe10huX8K6gEhxhyCrqJzyAo9u27HeE6w=; b=J5GQt97bUuhSZbWtCfXdnF37hw3zRFmggpgXFePbfydkgIO7T1qEq3TC7f2qz7LLlB 4S49rV6qgmg3/1l7yVS022ikDEXmKlfxNhAqIDWvOchRNowXWLLBy8iIxpAA/cT2wvOj 0Jut4JR9bEMoTT1P2cTZf83PChcuoKX14DaGcu7FEuFVDg3mxNwmKtE3VgJDMNgE7MkD qC/oqkmws4pn49hZ8CNZrDufM0eGNvp8S3xY09c5Nn1FRHXe1bqAvy/+d7JqHlPxTLKn yaIphA2Z9J7Icu9PWR1Vc38L8VhqePDOXgAC9cI1GdFOazdrFTAWSjBwE0/ppSeYpBGV xMeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690916477; x=1691521277; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6dm7mDs/QRbe10huX8K6gEhxhyCrqJzyAo9u27HeE6w=; b=XvvJ10voN5w4ywGHteF5FbebzBhNDxXdIrkagLaUbh1brXosLyA3vN77Au+J9rmTJ5 FY0FQIcWPT7JcfW8IwXN/nntHI74oNmxMR8npE+F6LdHw+fHDgu0Q3aPD/Mw+Q8pgo4k JiWPjizrPryBreTXbV2QJKrk5VN4VyF0Uk/jqfggduBLzZT5lrmGZGd0lFJJSP+I6x6o pv8noNoMa31Ss3FWudNPZEPmPPP93GRmmZpmkaWEGqwB2nbn+367CAM6cZwm9vW6WE0L 0BdWt1p/YTDZmXmQVmltV5FYylJEDpFZBjNOC2+aeOXZafQUXGWN5ibYOPqdZyG9haSD 8Xsw== X-Gm-Message-State: ABy/qLaACfgPH6S0+h+66ZSuUazdR8NiOlmTdMckm/f02FhoYEhYpG9v qnuQfg50Kfq9bLBfJ3fCSImVBaP034A= X-Google-Smtp-Source: APBJJlGmS9vDxvKMs0vj75dQg8WdrWLo21/ggGbLQ/stLSWTeYc5YOHqkncZwnm3qxat2TVzW25JPR0Oz6k= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:ad15:0:b0:d12:d6e4:a08f with SMTP id y21-20020a25ad15000000b00d12d6e4a08fmr86035ybi.6.1690916477204; Tue, 01 Aug 2023 12:01:17 -0700 (PDT) Date: Tue, 1 Aug 2023 19:01:15 +0000 In-Reply-To: <20230801083553.8468-7-xin3.li@intel.com> Mime-Version: 1.0 References: <20230801083553.8468-1-xin3.li@intel.com> <20230801083553.8468-7-xin3.li@intel.com> Message-ID: Subject: Re: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling From: Sean Christopherson To: Xin Li Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Peter Zijlstra , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Content-Type: text/plain; charset="us-ascii" On Tue, Aug 01, 2023, Xin Li wrote: > > diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S > index 07e927d4d099..5ee6a57b59a5 100644 > --- a/arch/x86/kvm/vmx/vmenter.S > +++ b/arch/x86/kvm/vmx/vmenter.S > @@ -2,12 +2,14 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > #include "kvm-asm-offsets.h" > #include "run_flags.h" > +#include "../../entry/calling.h" Rather than do the low level PUSH_REGS and POP_REGS, I vote to have core code expose a FRED-specific wrapper for invoking external_interrupt(). More below. > > #define WORD_SIZE (BITS_PER_LONG / 8) > > @@ -31,6 +33,80 @@ > #define VCPU_R15 __VCPU_REGS_R15 * WORD_SIZE > #endif > > +#ifdef CONFIG_X86_FRED > +.macro VMX_DO_FRED_EVENT_IRQOFF branch_insn branch_target nmi=0 objtool isn't happy. arch/x86/kvm/vmx/vmenter.o: warning: objtool: vmx_do_fred_interrupt_irqoff+0x6c: return with modified stack frame arch/x86/kvm/vmx/vmenter.o: warning: objtool: vmx_do_fred_nmi_irqoff+0x37: sibling call from callable instruction with modified stack frame The "return with modified stack frame" goes away with my suggested changes, but the sibling call remains for the NMI case due to the JMP instead of a call. > + /* > + * Unconditionally create a stack frame, getting the correct RSP on the > + * stack (for x86-64) would take two instructions anyways, and RBP can > + * be used to restore RSP to make objtool happy (see below). > + */ > + push %_ASM_BP > + mov %_ASM_SP, %_ASM_BP The frame stuff is worth throwing in a macro, if only to avoid a copy+pasted comment, which by the by, is wrong. (a) it's ERETS, not IRET. (b) the IRQ does a vanilla RET, not ERETS. E.g. like so: .macro VMX_DO_EVENT_FRAME_BEGIN /* * Unconditionally create a stack frame, getting the correct RSP on the * stack (for x86-64) would take two instructions anyways, and RBP can * be used to restore RSP to make objtool happy (see below). */ push %_ASM_BP mov %_ASM_SP, %_ASM_BP .endm .macro VMX_DO_EVENT_FRAME_END /* * "Restore" RSP from RBP, even though {E,I}RET has already unwound RSP * to the correct value *in most cases*. KVM's IRQ handling with FRED * doesn't do ERETS, and objtool doesn't know the callee will IRET/ERET * and, without the explicit restore, thinks the stack is getting walloped. * Using an unwind hint is problematic due to x86-64's dynamic alignment. */ mov %_ASM_BP, %_ASM_SP pop %_ASM_BP .endm > + > + /* > + * Don't check the FRED stack level, the call stack leading to this > + * helper is effectively constant and shallow (relatively speaking). > + * > + * Emulate the FRED-defined redzone and stack alignment. > + */ > + sub $(FRED_CONFIG_REDZONE_AMOUNT << 6), %rsp > + and $FRED_STACK_FRAME_RSP_MASK, %rsp > + > + /* > + * A FRED stack frame has extra 16 bytes of information pushed at the > + * regular stack top compared to an IDT stack frame. There is pretty much no chance that anyone remembers the layout of an IDT stack frame off the top of their head. I.e. saying "FRED has 16 bytes more" isn't all that useful. It also fails to capture the fact that FRED stuff a hell of a lot more information in those "common" 48 bytes. It'll be hard/impossible to capture all of the overload info in a comment, but showing the actual layout of the frame would be super helpful, e.g. something like this /* * FRED stack frames are always 64 bytes: * * ------------------------------ * | Bytes | Usage | * -----------------------------| * | 63:56 | Reserved | * | 55:48 | Event Data | * | 47:40 | SS + Event Info | * | 39:32 | RSP | * | 31:24 | RFLAGS | * | 23:16 | CS + Aux Info | * | 15:8 | RIP | * | 7:0 | Error Code | * ------------------------------ */ > + */ > + push $0 /* Reserved by FRED, must be 0 */ > + push $0 /* FRED event data, 0 for NMI and external interrupts */ > + > + shl $32, %rdi /* FRED event type and vector */ > + .if \nmi > + bts $FRED_SSX_NMI_BIT, %rdi /* Set the NMI bit */ The spec I have from May 2022 says the NMI bit colocated with CS, not SS. And the cover letter's suggestion to use a search engine to find the spec ain't exactly helpful, that just gives me the same "May 2022 Revision 3.0" spec. So either y'all have a spec that I can't find, or this is wrong. > + .endif > + bts $FRED_SSX_64_BIT_MODE_BIT, %rdi /* Set the 64-bit mode */ > + or $__KERNEL_DS, %rdi > + push %rdi > + push %rbp > + pushf > + mov $__KERNEL_CS, %rax > + push %rax > + > + /* > + * Unlike the IDT event delivery, FRED _always_ pushes an error code > + * after pushing the return RIP, thus the CALL instruction CANNOT be > + * used here to push the return RIP, otherwise there is no chance to > + * push an error code before invoking the IRQ/NMI handler. > + * > + * Use LEA to get the return RIP and push it, then push an error code. > + */ > + lea 1f(%rip), %rax This is quite misleading for IRQs. It took me a while to figure out that the only reason it's functionally ok is that external_interrupt() will do RET, not ERETS, i.e. the RIP that's pushed here isn't used for IRQs! Expanding the above comment would be quite helpful, e.g. * * Use LEA to get the return RIP and push it, then push an error code. * Note, only NMI handling does an ERETS to the target! IRQ handling * doesn't need to unmask NMIs and so simply uses CALL+RET, i.e. the * RIP pushed here is only truly consumed for NMIs! > + push %rax > + push $0 /* FRED error code, 0 for NMI and external interrupts */ > + > + .if \nmi == 0 > + PUSH_REGS > + mov %rsp, %rdi Nit, *if* this stays in KVM, please use %_ASM_ARG1 instead of %rdi. I normally dislike unnecessary abstraction, but in this case using _ASM_ARG1 makes it clear (without a comment) that this code is loading a param for a funciton call, *not* for some FRED magic. > + .endif Jumping way back to providing a wrapper for FRED, if we do that, then there's no need to include calling.h, and the weird wrinkle about the ERET target kinda goes away too. E.g. provide this in arch/x86/entry/entry_64_fred.S .section .text, "ax" /* Note, this is instrumentation safe, and returns via RET, not ERETS! */ #if IS_ENABLED(CONFIG_KVM_INTEL) SYM_CODE_START(fred_irq_entry_from_kvm) FRED_ENTER call external_interrupt FRED_EXIT RET SYM_CODE_END(fred_irq_entry_from_kvm) EXPORT_SYMBOL_GPL(fred_irq_entry_from_kvm); #endif and then the KVM side for this particular chunk is more simply: lea 1f(%rip), %rax push %rax push $0 /* FRED error code, 0 for NMI and external interrupts */ \branch_insn \branch_target 1: VMX_DO_EVENT_FRAME_END RET Alternatively, the whole thing could be shoved into arch/x86/entry/entry_64_fred.S, but at a glance I don't think that would be a net positive due to the need to handle IRQs vs. NMIs. > + \branch_insn \branch_target > + > + .if \nmi == 0 > + POP_REGS > + .endif > + > +1: > + /* > + * "Restore" RSP from RBP, even though IRET has already unwound RSP to As mentioned above, this is incorrect on two fronts. > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index 0ecf4be2c6af..4e90c69a92bf 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -6890,6 +6890,14 @@ static void vmx_apicv_post_state_restore(struct kvm_vcpu *vcpu) > memset(vmx->pi_desc.pir, 0, sizeof(vmx->pi_desc.pir)); > } > > +#ifdef CONFIG_X86_FRED > +void vmx_do_fred_interrupt_irqoff(unsigned int vector); > +void vmx_do_fred_nmi_irqoff(unsigned int vector); > +#else > +#define vmx_do_fred_interrupt_irqoff(x) BUG() > +#define vmx_do_fred_nmi_irqoff(x) BUG() > +#endif My slight preference is to open code the BUG() as a ud2 in assembly, purely to avoid more #ifdefs. > + > void vmx_do_interrupt_irqoff(unsigned long entry); > void vmx_do_nmi_irqoff(void); > > @@ -6932,14 +6940,16 @@ static void handle_external_interrupt_irqoff(struct kvm_vcpu *vcpu) > { > u32 intr_info = vmx_get_intr_info(vcpu); > unsigned int vector = intr_info & INTR_INFO_VECTOR_MASK; > - gate_desc *desc = (gate_desc *)host_idt_base + vector; > > if (KVM_BUG(!is_external_intr(intr_info), vcpu->kvm, > "unexpected VM-Exit interrupt info: 0x%x", intr_info)) > return; > > kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); > - vmx_do_interrupt_irqoff(gate_offset(desc)); > + if (cpu_feature_enabled(X86_FEATURE_FRED)) > + vmx_do_fred_interrupt_irqoff(vector); /* Event type is 0 */ I strongly prefer to use code to document what's going on. E.g. the tail comment just left me wondering, what event type is 0? Whereas this makes it quite clear that KVM is signaling a hardware interrupt. The fact that it's a nop as far as code generation goes is irrelevant. vmx_do_fred_interrupt_irqoff((EVENT_TYPE_HWINT << 16) | vector); > + else > + vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base + vector)); > kvm_after_interrupt(vcpu); > > vcpu->arch.at_instruction_boundary = true; Here's a diff for (hopefully) everything I've suggested above. --- arch/x86/entry/entry_64_fred.S | 17 ++++++- arch/x86/kernel/traps.c | 5 -- arch/x86/kvm/vmx/vmenter.S | 84 +++++++++++++++------------------- arch/x86/kvm/vmx/vmx.c | 7 +-- 4 files changed, 55 insertions(+), 58 deletions(-) diff --git a/arch/x86/entry/entry_64_fred.S b/arch/x86/entry/entry_64_fred.S index 12063267d2ac..a973c0bd29f6 100644 --- a/arch/x86/entry/entry_64_fred.S +++ b/arch/x86/entry/entry_64_fred.S @@ -10,7 +10,6 @@ #include "calling.h" .code64 - .section ".noinstr.text", "ax" .macro FRED_ENTER UNWIND_HINT_END_OF_STACK @@ -24,6 +23,22 @@ POP_REGS .endm + .section .text, "ax" + +/* Note, this is instrumentation safe, and returns via RET, not ERETS! */ +#if IS_ENABLED(CONFIG_KVM_INTEL) +SYM_CODE_START(fred_irq_entry_from_kvm) + FRED_ENTER + call external_interrupt + FRED_EXIT + RET +SYM_CODE_END(fred_irq_entry_from_kvm) +EXPORT_SYMBOL_GPL(fred_irq_entry_from_kvm); +#endif + + .section ".noinstr.text", "ax" + + /* * The new RIP value that FRED event delivery establishes is * IA32_FRED_CONFIG & ~FFFH for events that occur in ring 3. diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 21eeba7b188f..cbcb83c71dab 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -1566,11 +1566,6 @@ int external_interrupt(struct pt_regs *regs) return 0; } -#if IS_ENABLED(CONFIG_KVM_INTEL) -/* For KVM VMX to handle IRQs in IRQ induced VM exits. */ -EXPORT_SYMBOL_GPL(external_interrupt); -#endif - #endif /* CONFIG_X86_64 */ void __init trap_init(void) diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S index 79a4c91d9434..e25df565c3f8 100644 --- a/arch/x86/kvm/vmx/vmenter.S +++ b/arch/x86/kvm/vmx/vmenter.S @@ -9,7 +9,6 @@ #include #include "kvm-asm-offsets.h" #include "run_flags.h" -#include "../../entry/calling.h" #define WORD_SIZE (BITS_PER_LONG / 8) @@ -33,15 +32,31 @@ #define VCPU_R15 __VCPU_REGS_R15 * WORD_SIZE #endif +.macro VMX_DO_EVENT_FRAME_BEGIN + /* + * Unconditionally create a stack frame, getting the correct RSP on the + * stack (for x86-64) would take two instructions anyways, and RBP can + * be used to restore RSP to make objtool happy (see below). + */ + push %_ASM_BP + mov %_ASM_SP, %_ASM_BP +.endm + +.macro VMX_DO_EVENT_FRAME_END + /* + * "Restore" RSP from RBP, even though {E,I}RET has already unwound RSP + * to the correct value *in most cases*. KVM's IRQ handling with FRED + * doesn't do ERETS, and objtool doesn't know the callee will IRET/ERET + * and, without the explicit restore, thinks the stack is getting walloped. + * Using an unwind hint is problematic due to x86-64's dynamic alignment. + */ + mov %_ASM_BP, %_ASM_SP + pop %_ASM_BP +.endm + #ifdef CONFIG_X86_FRED .macro VMX_DO_FRED_EVENT_IRQOFF branch_insn branch_target nmi=0 - /* - * Unconditionally create a stack frame, getting the correct RSP on the - * stack (for x86-64) would take two instructions anyways, and RBP can - * be used to restore RSP to make objtool happy (see below). - */ - push %_ASM_BP - mov %_ASM_SP, %_ASM_BP + VMX_DO_EVENT_FRAME_BEGIN /* * Don't check the FRED stack level, the call stack leading to this @@ -78,43 +93,23 @@ * push an error code before invoking the IRQ/NMI handler. * * Use LEA to get the return RIP and push it, then push an error code. + * Note, only NMI handling does an ERETS to the target! IRQ handling + * doesn't need to unmask NMIs and so simply uses CALL+RET, i.e. the + * RIP pushed here is only truly consumed for NMIs! */ lea 1f(%rip), %rax push %rax push $0 /* FRED error code, 0 for NMI and external interrupts */ - .if \nmi == 0 - PUSH_REGS - mov %rsp, %rdi - .endif - \branch_insn \branch_target - - .if \nmi == 0 - POP_REGS - .endif - 1: - /* - * "Restore" RSP from RBP, even though IRET has already unwound RSP to - * the correct value. objtool doesn't know the callee will IRET and, - * without the explicit restore, thinks the stack is getting walloped. - * Using an unwind hint is problematic due to x86-64's dynamic alignment. - */ - mov %_ASM_BP, %_ASM_SP - pop %_ASM_BP + VMX_DO_EVENT_FRAME_END RET .endm #endif .macro VMX_DO_EVENT_IRQOFF call_insn call_target - /* - * Unconditionally create a stack frame, getting the correct RSP on the - * stack (for x86-64) would take two instructions anyways, and RBP can - * be used to restore RSP to make objtool happy (see below). - */ - push %_ASM_BP - mov %_ASM_SP, %_ASM_BP + VMX_DO_EVENT_FRAME_BEGIN #ifdef CONFIG_X86_64 /* @@ -129,14 +124,7 @@ push $__KERNEL_CS \call_insn \call_target - /* - * "Restore" RSP from RBP, even though IRET has already unwound RSP to - * the correct value. objtool doesn't know the callee will IRET and, - * without the explicit restore, thinks the stack is getting walloped. - * Using an unwind hint is problematic due to x86-64's dynamic alignment. - */ - mov %_ASM_BP, %_ASM_SP - pop %_ASM_BP + VMX_DO_EVENT_FRAME_END RET .endm @@ -375,11 +363,13 @@ SYM_INNER_LABEL_ALIGN(vmx_vmexit, SYM_L_GLOBAL) SYM_FUNC_END(__vmx_vcpu_run) -#ifdef CONFIG_X86_FRED SYM_FUNC_START(vmx_do_fred_nmi_irqoff) +#ifdef CONFIG_X86_FRED VMX_DO_FRED_EVENT_IRQOFF jmp fred_entrypoint_kernel nmi=1 +#else + ud2 +#endif SYM_FUNC_END(vmx_do_fred_nmi_irqoff) -#endif SYM_FUNC_START(vmx_do_nmi_irqoff) VMX_DO_EVENT_IRQOFF call asm_exc_nmi_kvm_vmx @@ -438,11 +428,13 @@ SYM_FUNC_END(vmread_error_trampoline) #endif .section .text, "ax" -#ifdef CONFIG_X86_FRED SYM_FUNC_START(vmx_do_fred_interrupt_irqoff) - VMX_DO_FRED_EVENT_IRQOFF call external_interrupt +#ifdef CONFIG_X86_FRED + VMX_DO_FRED_EVENT_IRQOFF call fred_irq_entry_from_kvm +#else + ud2 +#endif SYM_FUNC_END(vmx_do_fred_interrupt_irqoff) -#endif SYM_FUNC_START(vmx_do_interrupt_irqoff) VMX_DO_EVENT_IRQOFF CALL_NOSPEC _ASM_ARG1 diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index bf757f5071e4..cb4675dd87df 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6919,13 +6919,8 @@ static void vmx_apicv_post_state_restore(struct kvm_vcpu *vcpu) memset(vmx->pi_desc.pir, 0, sizeof(vmx->pi_desc.pir)); } -#ifdef CONFIG_X86_FRED void vmx_do_fred_interrupt_irqoff(unsigned int vector); void vmx_do_fred_nmi_irqoff(unsigned int vector); -#else -#define vmx_do_fred_interrupt_irqoff(x) BUG() -#define vmx_do_fred_nmi_irqoff(x) BUG() -#endif void vmx_do_interrupt_irqoff(unsigned long entry); void vmx_do_nmi_irqoff(void); @@ -6976,7 +6971,7 @@ static void handle_external_interrupt_irqoff(struct kvm_vcpu *vcpu) kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); if (cpu_feature_enabled(X86_FEATURE_FRED)) - vmx_do_fred_interrupt_irqoff(vector); /* Event type is 0 */ + vmx_do_fred_interrupt_irqoff((EVENT_TYPE_HWINT << 16) | vector); else vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base + vector)); kvm_after_interrupt(vcpu); base-commit: 8961078ffe509a97ec7803b17912e57c47b93fa2 -- From xen-devel-bounces@lists.xenproject.org Tue Aug 01 19:39:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 19:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574484.899786 (Exim 4.92) (envelope-from ) id 1qQvCu-00020S-Di; Tue, 01 Aug 2023 19:39:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574484.899786; Tue, 01 Aug 2023 19:39:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvCu-00020L-Az; Tue, 01 Aug 2023 19:39:00 +0000 Received: by outflank-mailman (input) for mailman id 574484; Tue, 01 Aug 2023 19:38:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvCq-00020F-C4 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 19:38:59 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c77ad8d-30a3-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 21:38:54 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qQvBp-00Erfk-29; Tue, 01 Aug 2023 19:37:54 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 01EB0300134; Tue, 1 Aug 2023 21:37:51 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id DAE66201BD3C3; Tue, 1 Aug 2023 21:37:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c77ad8d-30a3-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XUuRgq2k+Zj7Cps3kG/jmE/mhHsCYkzavBA/LPVkFBs=; b=jllufagrIa/lR21PAk9SYyMhAG pQAKupOfSK4Dhh0bm8iu1sQUv9lMhmRfH/zIvVnAM8LOfko59SeoulYg7NALKjJ4L9wG27jLaoCUk gVCMqQbB9DVabk0U/daweZJfrGQMpNcCkOCcvsgrPQ4KE5dfmfOj0n2s0xa62dY1PDmFWpMB45jNu LOPPbQsrn054suZVnJ1EWOzTD5AT5eORcFhvn29qDMNKwPt8+TQatJHQzhZXvfRyi4ozGOpj7FuWL cOM24LcfEIScuEycHMT/AYoj4Clhch0kIau5XVicK1eYoms8Rz55EE4BCNn7jkt3fSY6vPg3byZad 2AEwkPlg==; Date: Tue, 1 Aug 2023 21:37:50 +0200 From: Peter Zijlstra To: Sean Christopherson Cc: Xin Li , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: Re: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling Message-ID: <20230801193750.GA119080@hirez.programming.kicks-ass.net> References: <20230801083553.8468-1-xin3.li@intel.com> <20230801083553.8468-7-xin3.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 01, 2023 at 07:01:15PM +0000, Sean Christopherson wrote: > The spec I have from May 2022 says the NMI bit colocated with CS, not SS. And > the cover letter's suggestion to use a search engine to find the spec ain't > exactly helpful, that just gives me the same "May 2022 Revision 3.0" spec. So > either y'all have a spec that I can't find, or this is wrong. https://intel.com/sdm is a useful shorthand I've recently been told about. On that page is also "Flexible Return and Event Delivery Specification", when clicked it will gift you a FRED v5.0 PDF. From xen-devel-bounces@lists.xenproject.org Tue Aug 01 19:49:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 19:49:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574489.899795 (Exim 4.92) (envelope-from ) id 1qQvMg-0003WP-94; Tue, 01 Aug 2023 19:49:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574489.899795; Tue, 01 Aug 2023 19:49:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvMg-0003WI-6L; Tue, 01 Aug 2023 19:49:06 +0000 Received: by outflank-mailman (input) for mailman id 574489; Tue, 01 Aug 2023 19:49:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvMe-0003WC-Mi for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 19:49:04 +0000 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [2607:f8b0:4864:20::64a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7709b043-30a4-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 21:49:03 +0200 (CEST) Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1bbb97d27d6so42581245ad.1 for ; Tue, 01 Aug 2023 12:49:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7709b043-30a4-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690919342; x=1691524142; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ymMuGbXslfyJGs4W/pBqFuGxl9xUvy7q5fX4QbBoOtQ=; b=CydE6ofDFbki4OoGOG75dPf8HjmzdP4bx8vverzkUAQVtD69mMn7n68FWR8AAp7DXQ w+dl1y5zJGShPu6hUhv3xWgs0RLuDKkU1QeFVeAkGndzTQF4ejZ1rYTen/R2bDlQiGdt p2JE4NI74wSzCDPayw3C3EPUnZHQ6AwVPX7+Hr/id3ZzAXZ75VD1wArInmjbenyfG79V cEByprzGAc4WBhBRZXFreyy3tDtKJhpsG+vPyPTXY7LVerieG5d/K0kioNLl2WhELfBY ntCCC/ISdhA9syO12Y1PCPSKi59/fx8iNJKpcw07IuHVOLESRbk7CVIj2E7rNQ0Q4Awv rGdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690919342; x=1691524142; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ymMuGbXslfyJGs4W/pBqFuGxl9xUvy7q5fX4QbBoOtQ=; b=Kn50+t53uU5NOm8Km3htzxTmehToWLKgCZ8oinGiCRFxhxWq52eAldm8vX2R5wHZdN zvotcZjjHa+FQI8CZY0qRBye0Jn2cvbDEjBCFpAYmAMYqfZgDzzVVYN+2d98FGAOmoKE ka1pwuXiCCH5V5aK3bmAZ4NSgKu09zhvzQ7CgoW57MbH7gG1g/mBo4idqTOEQDdXXu7h hfQ4ny5BENwmrAaarSgu+ZCLihuUOHjQ8GJfIzucftXRAveQoG/Dut673iA11w4+sdeq u3x5b2152uf+jTqLbMxZpoU73zPvNYIXXdZQNIlQb2/IMFFpL9Ek+G9eG2QkQy7Cq7Sb 6Bcw== X-Gm-Message-State: ABy/qLbTgnd+o0Vurg2TekbT6b6vc+33ErxsCV0eGMH2yPFxHpHF6OIX RQt/as1wKmqvjNcMFBleh7yi4Pne9q0= X-Google-Smtp-Source: APBJJlHzs/CPjAfxg4yY07jd2lFS2uJwEiSQkwxUoufms67SS+axZJeOfATbgdLU+XSQqEOfpNJp/uAu49A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:f683:b0:1b8:a54c:61ef with SMTP id l3-20020a170902f68300b001b8a54c61efmr67559plg.9.1690919341844; Tue, 01 Aug 2023 12:49:01 -0700 (PDT) Date: Tue, 1 Aug 2023 19:49:00 +0000 In-Reply-To: <20230801193750.GA119080@hirez.programming.kicks-ass.net> Mime-Version: 1.0 References: <20230801083553.8468-1-xin3.li@intel.com> <20230801083553.8468-7-xin3.li@intel.com> <20230801193750.GA119080@hirez.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling From: Sean Christopherson To: Peter Zijlstra Cc: Xin Li , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Tony Luck , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , Steven Rostedt , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , Reinette Chatre , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , Fei Li , Conghui , Ashok Raj , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , Jiapeng Chong , Jane Malalane , David Woodhouse , Boris Ostrovsky , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Content-Type: text/plain; charset="us-ascii" On Tue, Aug 01, 2023, Peter Zijlstra wrote: > On Tue, Aug 01, 2023 at 07:01:15PM +0000, Sean Christopherson wrote: > > The spec I have from May 2022 says the NMI bit colocated with CS, not SS. And > > the cover letter's suggestion to use a search engine to find the spec ain't > > exactly helpful, that just gives me the same "May 2022 Revision 3.0" spec. So > > either y'all have a spec that I can't find, or this is wrong. > > https://intel.com/sdm > > is a useful shorthand I've recently been told about. Hallelujah! > On that page is also "Flexible Return and Event Delivery Specification", when > clicked it will gift you a FRED v5.0 PDF. Worked for me, too. Thanks! From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:20:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574495.899805 (Exim 4.92) (envelope-from ) id 1qQvr3-0007tP-Fo; Tue, 01 Aug 2023 20:20:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574495.899805; Tue, 01 Aug 2023 20:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvr3-0007tI-D7; Tue, 01 Aug 2023 20:20:29 +0000 Received: by outflank-mailman (input) for mailman id 574495; Tue, 01 Aug 2023 20:20:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvr2-0007tB-EA for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:20:28 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d78e14aa-30a8-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 22:20:23 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 16909212173621014.5551400025472; Tue, 1 Aug 2023 13:20:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d78e14aa-30a8-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1690921219; cv=none; d=zohomail.com; s=zohoarc; b=E413ofvZPo9ecp1I5vBmTYsC5yIJ9vgdigDQfffgzj1GXG4fTxzJG+sU3eGcyeLzqgHdLOETjpd/7i27BlzU6X+FZN1XeZ2dat1euy4Ktdvnf1lGUxUoxE5No9vBk4AvB5MBKpi7BqhgKGOK/kf+CbSXDOvseZF0ugU1XZAc794= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921219; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=ko9U8cGQhnmgoATzcdLjAMLp8cggi3FR/MqknwYUGjw=; b=XLDon0Q6hOidpC6DAmlQx5CG79Cc5StFCEvKiwXux0Fdk1Gli/nWneU4mOqG6z1l1R1n6bei2zfiwf/dMIV/F5B1Gw+lVqfjWBZGIhOxzL5ZOyPfo7W4mQvTI+vMxlGu6vBipb+2Lx67/HHjxrYmhvb1Mwgl0XRnLQF0UqpJk4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921219; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=ko9U8cGQhnmgoATzcdLjAMLp8cggi3FR/MqknwYUGjw=; b=L8B+SkqbAs+n+BtTOmiwTj30QSvyY1S+C9oj/2NQgj9D2uCsoeu9c+/U4DBCAqFt r24RWirHEzRW3jB7DTK1E+d+2WIwlZ6DvroJ+x3k4yhQvOLWCePyW2oPD1HU+cjEuzt hHIYiraxeaUYKx0Uu46Hz9VPT+3x7LUl+0MOBmW0= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Christopher Clark , Rich Persaud , Stefano Stabellini Subject: [RFC 0/6] Hyperlaunch domain roles and capabilities Date: Tue, 1 Aug 2023 16:20:00 -0400 Message-Id: <20230801202006.20322-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External A goal of the hyperlaunch effort was to solidify the concept of the different types of domains the hypervisor has some notion around. The initial approach was to formalize these types as roles enforced through the XSM framework. In this RFC, a simpler approach is taken to lay a foundation of domain roles and assignable capabilities. The approach in this series is to collapse the relevant bools in struct domain into a pair of bit flag entries that represent roles and capabilities that a domain is assigned. Daniel P. Smith (6): dom0: replace explict zero checks roles: provide abstraction for the possible domain roles roles: add a role for xenstore domain capabilities: introduce console io as a domain capability capabilities: add dom0 cpu faulting disable capabilities: convert attach debugger into a capability xen/arch/arm/domain_build.c | 6 ++- xen/arch/x86/cpu-policy.c | 2 +- xen/arch/x86/cpu/common.c | 82 ++++++++++++++++----------------- xen/arch/x86/hvm/svm/svm.c | 8 ++-- xen/arch/x86/hvm/vmx/realmode.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 10 ++-- xen/arch/x86/setup.c | 6 +++ xen/arch/x86/traps.c | 6 ++- xen/common/domain.c | 21 +++++++-- xen/common/domctl.c | 6 ++- xen/common/sched/arinc653.c | 2 +- xen/common/sched/core.c | 4 +- xen/include/xen/sched.h | 58 +++++++++++++++++++---- xen/include/xsm/dummy.h | 6 +-- xen/xsm/flask/hooks.c | 12 ++--- 16 files changed, 150 insertions(+), 83 deletions(-) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:20:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574496.899816 (Exim 4.92) (envelope-from ) id 1qQvr6-00088b-My; Tue, 01 Aug 2023 20:20:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574496.899816; Tue, 01 Aug 2023 20:20:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvr6-00088U-K0; Tue, 01 Aug 2023 20:20:32 +0000 Received: by outflank-mailman (input) for mailman id 574496; Tue, 01 Aug 2023 20:20:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvr5-0007tB-6f for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:20:31 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db082af5-30a8-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 22:20:29 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690921219023154.7244666059837; Tue, 1 Aug 2023 13:20:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db082af5-30a8-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1690921221; cv=none; d=zohomail.com; s=zohoarc; b=lNiYjknsKhksJuvxpu+1YL5h1k8mUf7MfDMTehx9xU9qY5ePFGqwxPnrerUsLBUENjnbLVykTx6E+3375JIzcLHVjrH1owt/cSAJx4+MsyWXAOYsyQ8QyOhYARJSdBcWS7hfpcs2IHDbWgZ0pPzTKoy12sj88af3NZYp1j/eQc8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921221; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=QxHgg6odiTfgWhhWOuj3R7wSlDiixIdY8mSDQ2Z3eHA=; b=QxaM6Mozt3aw6tfNbgM0mdmi6SZMN2qq8JWlFgWqRoVslhpfCKnpUG/ju1IJ8IHddkjWz3pKHO9jlZ6yqU6s/BvvLgeOITobNtuGmvPmm+JYx7JaL4W1axtMW4kQXTeMnhZ6yUSd74Cmq86A25KWy88w6SpnkfXs7KLG9/tpICQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921221; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=QxHgg6odiTfgWhhWOuj3R7wSlDiixIdY8mSDQ2Z3eHA=; b=JENP3hnykOC520uj6z57yLCmOzl6QU/5aI46l4vND4WKa2l/AGeUazOqIK8Vtu6y MapOgQvnxH7eaGAvDTmUhJDP+KGAsizdabjmyucONUw15X0hwzYwxdOfkJHLBZsU9aj hpPLkJScrv/frwb24yryVd6pgxcf0S297t3YL7CE= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, xen-devel@dornerworks.com Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli Subject: [RFC 1/6] dom0: replace explict zero checks Date: Tue, 1 Aug 2023 16:20:01 -0400 Message-Id: <20230801202006.20322-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801202006.20322-1-dpsmith@apertussolutions.com> References: <20230801202006.20322-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External A legacy concept is that the initial domain will have a domain id of zero. As a result there are places where a check that a domain is the inital domain is determined by an explicit check that the domid is zero. This commit seeks to abstract this check into a function call and replace all check locations with the function call. Signed-off-by: Daniel P. Smith --- xen/common/domain.c | 4 ++-- xen/common/sched/arinc653.c | 2 +- xen/common/sched/core.c | 4 ++-- xen/include/xen/sched.h | 7 +++++++ 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 304aa04fa6..8fb3c052f5 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -309,7 +309,7 @@ static int late_hwdom_init(struct domain *d) struct domain *dom0; int rv; - if ( d != hardware_domain || d->domain_id == 0 ) + if ( d != hardware_domain || is_initial_domain(d) ) return 0; rv = xsm_init_hardware_domain(XSM_HOOK, d); @@ -612,7 +612,7 @@ struct domain *domain_create(domid_t domid, d->is_privileged = flags & CDF_privileged; /* Sort out our idea of is_hardware_domain(). */ - if ( domid == 0 || domid == hardware_domid ) + if ( is_initial_domain(d) || domid == hardware_domid ) { if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED ) panic("The value of hardware_dom must be a valid domain ID\n"); diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index a82c0d7314..31e8270af3 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -404,7 +404,7 @@ a653sched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit, * Add every one of dom0's units to the schedule, as long as there are * slots available. */ - if ( unit->domain->domain_id == 0 ) + if ( is_initial_domain(unit->domain) ) { entry = sched_priv->num_schedule_entries; diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 022f548652..210ad30f94 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -585,7 +585,7 @@ int sched_init_vcpu(struct vcpu *v) */ sched_set_affinity(unit, cpumask_of(0), cpumask_of(0)); } - else if ( d->domain_id == 0 && opt_dom0_vcpus_pin ) + else if ( is_initial_domain(d) && opt_dom0_vcpus_pin ) { /* * If dom0_vcpus_pin is specified, dom0 vCPUs are pinned 1:1 to @@ -594,7 +594,7 @@ int sched_init_vcpu(struct vcpu *v) sched_set_affinity(unit, cpumask_of(processor), &cpumask_all); } #ifdef CONFIG_X86 - else if ( d->domain_id == 0 ) + else if ( is_initial_domain(d) ) { /* * In absence of dom0_vcpus_pin instead, the hard and soft affinity of diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 854f3e32c0..a9276a7bed 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -1058,6 +1058,13 @@ void scheduler_disable(void); void watchdog_domain_init(struct domain *d); void watchdog_domain_destroy(struct domain *d); +static always_inline bool is_initial_domain(const struct domain *d) +{ + static int init_domain_id = 0; + + return d->domain_id == init_domain_id; +} + /* * Use this check when the following are both true: * - Using this feature or interface requires full access to the hardware -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:20:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574497.899826 (Exim 4.92) (envelope-from ) id 1qQvrL-00007Z-W0; Tue, 01 Aug 2023 20:20:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574497.899826; Tue, 01 Aug 2023 20:20:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvrL-00007P-St; Tue, 01 Aug 2023 20:20:47 +0000 Received: by outflank-mailman (input) for mailman id 574497; Tue, 01 Aug 2023 20:20:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvrK-0007tB-NS for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:20:46 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e42cb24b-30a8-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 22:20:44 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690921220423235.25435125968477; Tue, 1 Aug 2023 13:20:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e42cb24b-30a8-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1690921222; cv=none; d=zohomail.com; s=zohoarc; b=DCsyMRf8xAaiW6V1MikN6A+7KB+qawGSQaoE+fU00o0RtbQCtfU4We3Qv4qG5GmZF57GQJbbB7Bl8ecL62/ZddTQxc0eLGPJfii7l+TG+WwQ76H9Qfxn1qZ2GNbZKXCURhg40/bf6gUloroHct+k1G9hIF1dsHzfW2OD5pb9pqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921222; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=deDaH1mtD3wmtBLBicRQEslJzzR5NTIhnW//O7OUueo=; b=adqNUS2vwkEOP74LrJxnjLB3DpNLDejgALxzqz1qHmAPf/TPzdSdRnOT9UtoXLhhOwJc/xbXtDj7hClTyKSS8GYl0hZ+eUShT5EbYzV0GSKQT6XVNI0dSiuX0R5cNOh4C1CqCEtcNKyaIqYcKmTtJzku2ibzwsuB5MaHxRdIQjE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921222; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=deDaH1mtD3wmtBLBicRQEslJzzR5NTIhnW//O7OUueo=; b=Nq/4qPInj010nlvQY8Aj5jx/3/svbtKYrChM01e+EM79DiY7ZY4YWw7EznUDp+Da G5DETugcWT93dlg6z9pbgUdppwpBS0v/sRj9eMBw1oS321J39Bb9zFnuHU4AUlMQVOe SIEZN4U1zv5X5EKi85IC9W7t3DLeguLr5isP2feg= From: "Daniel P. Smith" To: Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC 2/6] roles: provide abstraction for the possible domain roles Date: Tue, 1 Aug 2023 16:20:02 -0400 Message-Id: <20230801202006.20322-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801202006.20322-1-dpsmith@apertussolutions.com> References: <20230801202006.20322-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The existing concepts such as unbounded domain, ie. all powerful, control domain and hardware domain are, effectively, roles the domains provide for the system. Currently, these are represented with booleans within `struct domain` or global domid variables that are compared against. This patch begins to formalize these roles by replacing the `is_control` and `is_console`, along with expanding the check against the global `hardware_domain` with a single encapsulating role attribute in `struct domain`. Signed-off-by: Daniel P. Smith --- xen/arch/arm/domain_build.c | 2 ++ xen/arch/x86/setup.c | 2 ++ xen/common/domain.c | 14 +++++++++++++- xen/include/xen/sched.h | 16 +++++++++------- xen/include/xsm/dummy.h | 4 ++-- xen/xsm/flask/hooks.c | 12 ++++++------ 6 files changed, 34 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 39b4ee03a5..51b4daefe1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -4201,6 +4201,8 @@ void __init create_dom0(void) if ( IS_ERR(dom0) ) panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); + dom0->role |= ROLE_UNBOUNDED_DOMAIN; + if ( alloc_dom0_vcpu0(dom0) == NULL ) panic("Error creating domain 0 vcpu0\n"); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2dbe9857aa..4e20edc3bf 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const module_t *image, if ( IS_ERR(d) ) panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); + d->role |= ROLE_UNBOUNDED_DOMAIN; + init_dom0_cpuid_policy(d); if ( alloc_dom0_vcpu0(d) == NULL ) diff --git a/xen/common/domain.c b/xen/common/domain.c index 8fb3c052f5..0ff1d52e3d 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) setup_io_bitmap(dom0); #endif + /* + * "dom0" may have been created under the unbounded role, demote it from + * that role, reducing it to the control domain role and any other roles it + * may have been given. + */ + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); + dom0->role |= ROLE_CONTROL_DOMAIN; + rcu_unlock_domain(dom0); iommu_hwdom_init(d); @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, } /* Sort out our idea of is_control_domain(). */ - d->is_privileged = flags & CDF_privileged; + if ( flags & CDF_privileged ) + d->role |= ROLE_CONTROL_DOMAIN; + else + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ /* Sort out our idea of is_hardware_domain(). */ if ( is_initial_domain(d) || domid == hardware_domid ) @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, old_hwdom = hardware_domain; hardware_domain = d; + d->role |= ROLE_HARDWARE_DOMAIN; } TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index a9276a7bed..695f240326 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -467,8 +467,10 @@ struct domain #endif /* is node-affinity automatically computed? */ bool auto_node_affinity; - /* Is this guest fully privileged (aka dom0)? */ - bool is_privileged; +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) +#define ROLE_CONTROL_DOMAIN (1U<<1) +#define ROLE_HARDWARE_DOMAIN (1U<<2) + uint8_t role; /* Can this guest access the Xen console? */ bool is_console; /* Is this guest being debugged by dom0? */ @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); static always_inline bool is_initial_domain(const struct domain *d) { - static int init_domain_id = 0; - - return d->domain_id == init_domain_id; + return d->role & ROLE_UNBOUNDED_DOMAIN; } /* @@ -1076,7 +1076,8 @@ static always_inline bool is_hardware_domain(const struct domain *d) if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) return false; - return evaluate_nospec(d == hardware_domain); + return evaluate_nospec(((d->role & ROLE_HARDWARE_DOMAIN) || + is_initial_domain(d)) && (d == hardware_domain)); } /* This check is for functionality specific to a control domain */ @@ -1085,7 +1086,8 @@ static always_inline bool is_control_domain(const struct domain *d) if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) return false; - return evaluate_nospec(d->is_privileged); + return evaluate_nospec((d->role & ROLE_CONTROL_DOMAIN) || + is_initial_domain(d)); } #define VM_ASSIST(d, t) (test_bit(VMASST_TYPE_ ## t, &(d)->vm_assist)) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 8671af1ba4..18f1ddd127 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -108,7 +108,7 @@ static XSM_INLINE int cf_check xsm_set_system_active(void) { struct domain *d = current->domain; - ASSERT(d->is_privileged); + ASSERT(d->role & ROLE_CONTROL_DOMAIN); if ( d->domain_id != DOMID_IDLE ) { @@ -116,7 +116,7 @@ static XSM_INLINE int cf_check xsm_set_system_active(void) return -EPERM; } - d->is_privileged = false; + d->role &= ~ROLE_CONTROL_DOMAIN; return 0; } diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 78225f68c1..0a31719f43 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -193,7 +193,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) default: if ( domain_sid(current->domain) == SECINITSID_XENBOOT ) { - if ( d->is_privileged ) + if ( d->role & ROLE_CONTROL_DOMAIN ) dsec->sid = SECINITSID_DOM0; else if ( pv_shim ) dsec->sid = SECINITSID_DOMU; @@ -213,7 +213,7 @@ static int cf_check flask_set_system_active(void) dsec = d->ssid; - ASSERT(d->is_privileged); + ASSERT(d->role & ROLE_CONTROL_DOMAIN); ASSERT(dsec->sid == SECINITSID_XENBOOT); ASSERT(dsec->self_sid == SECINITSID_XENBOOT); @@ -224,11 +224,11 @@ static int cf_check flask_set_system_active(void) } /* - * While is_privileged has no significant meaning under flask, set to false - * as is_privileged is not only used for a privilege check but also as a - * type of domain check, specifically if the domain is the control domain. + * While domain roles have no significant meaning under flask, mask out + * control domain role as it is not only used for a privilege check but + * also as a type of domain check. */ - d->is_privileged = false; + d->role &= ~ROLE_CONTROL_DOMAIN; dsec->self_sid = dsec->sid = SECINITSID_XEN; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:21:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:21:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574500.899836 (Exim 4.92) (envelope-from ) id 1qQvra-0000el-AG; Tue, 01 Aug 2023 20:21:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574500.899836; Tue, 01 Aug 2023 20:21:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvra-0000ee-7l; Tue, 01 Aug 2023 20:21:02 +0000 Received: by outflank-mailman (input) for mailman id 574500; Tue, 01 Aug 2023 20:21:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvrY-0000Vh-UH for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:21:00 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed01d9c5-30a8-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 22:21:00 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690921221539148.37958387649314; Tue, 1 Aug 2023 13:20:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed01d9c5-30a8-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690921223; cv=none; d=zohomail.com; s=zohoarc; b=kjFnFBapoQ7lQPlaLmhBGvI7h1nmY845AgXgJ0HUtbJqdU5LFjp4IS1FXBnKy7xkeKljZeRqAjxiXA5syLROHfw3HyA9jjsdv70zwIGlSF7oFV9Mk1wloUHUzpiMgQG+rLdNp7iyaNegw5MhvpDZ6Qb8B5GylqTCGPxWwhU7P04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921223; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=c36aqSstXSR6pA2kH24inhu4JODBmXhwXRJ9bra9rs8=; b=c9QZqfFpDJ1w86/B7pmdMPyXkRhywCD71Kv1KwC6Kp6mex/HXD7uxLoxYbUpq50xNhj6ARDZHQbuj3ueb/Ls9UdZd7q2Vg6NmYlh6daU2wgug+3ULYvb3ZCZWllp8vdoE3umD0M6unNdqko8YH3y+gonbTmOOKVwTMPqMbVzyM4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921223; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=c36aqSstXSR6pA2kH24inhu4JODBmXhwXRJ9bra9rs8=; b=btgPcKIbUkSCLwMaCRscbjh82/cPU6TGLwPP0U3S/ywG+tUxcBk5jNvSLzy4/hZc xDBuVQuZrMeyJSFNsNe7P0xIGLMxLW1bax6KROOPs58YV0AADiOcQNToX+WyuqtVaQF Qms39sOusy73/lmd4LFVl0dafI4DtzhOXSaca6JQ= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC 3/6] roles: add a role for xenstore domain Date: Tue, 1 Aug 2023 16:20:03 -0400 Message-Id: <20230801202006.20322-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801202006.20322-1-dpsmith@apertussolutions.com> References: <20230801202006.20322-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Expand the possible roles for a domain to include a role for the Xenstore domain. Signed-off-by: Daniel P. Smith --- xen/common/domain.c | 3 +++ xen/include/xen/sched.h | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 0ff1d52e3d..dbf055c559 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -633,6 +633,9 @@ struct domain *domain_create(domid_t domid, d->role |= ROLE_HARDWARE_DOMAIN; } + if ( d->options & XEN_DOMCTL_CDF_xs_domain ) + d->role |= ROLE_XENSTORE_DOMAIN; + TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); lock_profile_register_struct(LOCKPROF_TYPE_PERDOM, d, domid); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 695f240326..ec0f9baff6 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -470,6 +470,7 @@ struct domain #define ROLE_UNBOUNDED_DOMAIN (1U<<0) #define ROLE_CONTROL_DOMAIN (1U<<1) #define ROLE_HARDWARE_DOMAIN (1U<<2) +#define ROLE_XENSTORE_DOMAIN (1U<<3) uint8_t role; /* Can this guest access the Xen console? */ bool is_console; @@ -1165,7 +1166,7 @@ static inline bool is_vcpu_online(const struct vcpu *v) static inline bool is_xenstore_domain(const struct domain *d) { - return d->options & XEN_DOMCTL_CDF_xs_domain; + return d->role & ROLE_XENSTORE_DOMAIN; } static always_inline bool is_iommu_enabled(const struct domain *d) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:21:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:21:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574503.899845 (Exim 4.92) (envelope-from ) id 1qQvrl-0001Eg-IA; Tue, 01 Aug 2023 20:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574503.899845; Tue, 01 Aug 2023 20:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvrl-0001EZ-F4; Tue, 01 Aug 2023 20:21:13 +0000 Received: by outflank-mailman (input) for mailman id 574503; Tue, 01 Aug 2023 20:21:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvrk-0000Vh-73 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:21:12 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f3c81379-30a8-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 22:21:11 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690921222919263.86301750890664; Tue, 1 Aug 2023 13:20:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3c81379-30a8-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690921225; cv=none; d=zohomail.com; s=zohoarc; b=LJWZTW9Bg+L3Q9L21qmOk/5B1b4zY0rfPZxLFiwzTbtB2gaThkYoDLs1Gw8mYQy6W2grTkYZvfTx8zecJeh0hlctmBdjVEmJ0XWJyXQ3Ew4it1mVuTqus6oF9tujOpH0JPW4j5UYXW6VFQhMYOcUPAxSz1jsUEG4dYo5V5PccC4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921225; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=kf2Rd6TYnxR8dfigS+pnLDBD8C8lGV2r426kdzFRdWo=; b=SHxaszVus3sPdBwiai8onFiR+mMahjhb+zsdUVdbFpevDmDlXQuShYnIDemHUX6lkVu0C+wYcHebM2YbDDoi2hjisRn2eB/s2lHKcaE82rcWwU/fVtLynCYk4uKnRPEWAr1Xj5U5mh4kake3JFFm8NGoScphuAQ2rlyXUDrWoIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921225; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=kf2Rd6TYnxR8dfigS+pnLDBD8C8lGV2r426kdzFRdWo=; b=a8Qo8Oav2zQrW8HSf67m7NJOl5msUgbNz0s6kOusuLrAyDHJkLZB2NVXh5pr6cXf nCAA2mi2ldd85jpcM8Rxt9y0vtKP1g0PLhHP5QhORLyT/xq6KJxJPfeyWhAKrfo7cfi 4TOdW0fi7xdhVJKZx4NUs1n6DkdN0+upfuvu7GkU= From: "Daniel P. Smith" To: Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [RFC 4/6] capabilities: introduce console io as a domain capability Date: Tue, 1 Aug 2023 16:20:04 -0400 Message-Id: <20230801202006.20322-5-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801202006.20322-1-dpsmith@apertussolutions.com> References: <20230801202006.20322-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The field `is_console` suggests that the field represents a state of being or posession, not that it reflects the privilege to access the console. In this patch the field is renamed to capabilities to encapsulate the capabilities a domain has been granted. The first capability being the ability to read/write the Xen console. Signed-off-by: Daniel P. Smith --- xen/arch/arm/domain_build.c | 4 +++- xen/include/xen/sched.h | 25 +++++++++++++++++++++++-- xen/include/xsm/dummy.h | 2 +- 3 files changed, 27 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 51b4daefe1..ad7432b029 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -4076,7 +4076,9 @@ void __init create_domUs(void) panic("Error creating domain %s (rc = %ld)\n", dt_node_name(node), PTR_ERR(d)); - d->is_console = true; + if ( ! domain_set_cap(d, CAP_CONSOLE_IO) ) + printk("failed setting console_io on %pd\n", d); + dt_device_set_used_by(node, d->domain_id); rc = construct_domU(d, node); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index ec0f9baff6..b04fbe0565 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -472,8 +472,8 @@ struct domain #define ROLE_HARDWARE_DOMAIN (1U<<2) #define ROLE_XENSTORE_DOMAIN (1U<<3) uint8_t role; - /* Can this guest access the Xen console? */ - bool is_console; +#define CAP_CONSOLE_IO (1U<<0) + uint8_t capabilities; /* Is this guest being debugged by dom0? */ bool debugger_attached; /* @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const struct vcpu *v) return is_hvm_domain(v->domain); } +static always_inline bool domain_has_cap( + const struct domain *d, uint8_t cap) +{ + return d->capabilities & cap; +} + +static always_inline bool domain_set_cap( + struct domain *d, uint8_t cap) +{ + switch ( cap ) + { + case CAP_CONSOLE_IO: + d->capabilities |= cap; + break; + default: + return false; + } + + return domain_has_cap(d, cap); +} + static always_inline bool hap_enabled(const struct domain *d) { /* sanitise_domain_config() rejects HAP && !HVM */ diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 18f1ddd127..067ff1d111 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -268,7 +268,7 @@ static XSM_INLINE int cf_check xsm_console_io( XSM_DEFAULT_ARG struct domain *d, int cmd) { XSM_ASSERT_ACTION(XSM_OTHER); - if ( d->is_console ) + if ( domain_has_cap(d, CAP_CONSOLE_IO) ) return xsm_default_action(XSM_HOOK, d, NULL); #ifdef CONFIG_VERBOSE_DEBUG if ( cmd == CONSOLEIO_write ) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:21:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574505.899855 (Exim 4.92) (envelope-from ) id 1qQvry-0001rM-Oz; Tue, 01 Aug 2023 20:21:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574505.899855; Tue, 01 Aug 2023 20:21:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvry-0001rF-MO; Tue, 01 Aug 2023 20:21:26 +0000 Received: by outflank-mailman (input) for mailman id 574505; Tue, 01 Aug 2023 20:21:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvrx-0000Vh-8u for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:21:25 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fbb9076f-30a8-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 22:21:24 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1690921224303856.0970233237165; Tue, 1 Aug 2023 13:20:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbb9076f-30a8-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690921226; cv=none; d=zohomail.com; s=zohoarc; b=g2IEczmY3ijXZ1YHho3IZfu6YTmF4eaEB/eX7H499qCJcVzbN3siHaE30Z50NywMmdX/UUQyM1pQ5ROIMmims1eH4GYG8VXFEO9w7f8zeCKV0lco35/iZ/zJVOi5VlhNlVOhrh1rib2T/ymt43cWzxAKPJ90RIO2/H3BilYHwN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921226; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7ND+sooMpw5YPJbP1s16uk5VZG1QVw0bGyicpPO6T2Q=; b=iDypGFFju+iorCRbCu1v6Vydraf2VoFooKlXDnMMoCxatBohmqq7MLXRYZ6EvtmVhIRCYTY0IcJB5IJDGRDlxn7kLmSvzMRBSzc+ny80UReQAQhMEadFq6EkpXbM3vmFzBt76dVh+RKHgwoft2HdbzBhIW79uR/xA9iFW29V51E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921226; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=7ND+sooMpw5YPJbP1s16uk5VZG1QVw0bGyicpPO6T2Q=; b=oCTDWLjidEWDIMQf7q7AdaFYNGMNs8thaCk/9VpBUqfOOxXI0I0yoAZywHIrnxPJ /NSZn9/wo5V2ec8POU4XZMIsUtO7/uVT7+PXa+8UhtGVTcJzYgtjmXssgOfK9VEc+Hx Q/5HXKNq+cQNyRErpZBxGle0x/6EUtFtv67tOfdc= From: "Daniel P. Smith" To: Wei Liu , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [RFC 5/6] capabilities: add dom0 cpu faulting disable Date: Tue, 1 Aug 2023 16:20:05 -0400 Message-Id: <20230801202006.20322-6-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801202006.20322-1-dpsmith@apertussolutions.com> References: <20230801202006.20322-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This encapsulates disableing cpu faulting for PV dom0 as a capability. Signed-off-by: Daniel P. Smith --- xen/arch/x86/cpu-policy.c | 2 +- xen/arch/x86/cpu/common.c | 82 +++++++++++++++++++-------------------- xen/arch/x86/setup.c | 4 ++ xen/include/xen/sched.h | 8 +++- 4 files changed, 52 insertions(+), 44 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 1f954d4e59..42c3193938 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -912,7 +912,7 @@ void __init init_dom0_cpuid_policy(struct domain *d) * If the domain is getting unfiltered CPUID, don't let the guest kernel * play with CPUID faulting either, as Xen's CPUID path won't cope. */ - if ( !opt_dom0_cpuid_faulting && is_control_domain(d) && is_pv_domain(d) ) + if ( domain_has_cap(d, CAP_DISABLE_CPU_FAULT) ) p->platform_info.cpuid_faulting = false; recalculate_cpuid_policy(d); diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index cfcdaace12..937581e353 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -164,48 +164,46 @@ static void set_cpuid_faulting(bool enable) void ctxt_switch_levelling(const struct vcpu *next) { - const struct domain *nextd = next ? next->domain : NULL; - bool enable_cpuid_faulting; - - if (cpu_has_cpuid_faulting || - boot_cpu_has(X86_FEATURE_CPUID_USER_DIS)) { - /* - * No need to alter the faulting setting if we are switching - * to idle; it won't affect any code running in idle context. - */ - if (nextd && is_idle_domain(nextd)) - return; - /* - * We *should* be enabling faulting for PV control domains. - * - * The domain builder has now been updated to not depend on - * seeing host CPUID values. This makes it compatible with - * PVH toolstack domains, and lets us enable faulting by - * default for all PV domains. - * - * However, as PV control domains have never had faulting - * enforced on them before, there might plausibly be other - * dependenices on host CPUID data. Therefore, we have left - * an interim escape hatch in the form of - * `dom0=no-cpuid-faulting` to restore the older behaviour. - */ - enable_cpuid_faulting = nextd && (opt_dom0_cpuid_faulting || - !is_control_domain(nextd) || - !is_pv_domain(nextd)) && - (is_pv_domain(nextd) || - next->arch.msrs-> - misc_features_enables.cpuid_faulting); - - if (cpu_has_cpuid_faulting) - set_cpuid_faulting(enable_cpuid_faulting); - else - amd_set_cpuid_user_dis(enable_cpuid_faulting); - - return; - } - - if (ctxt_switch_masking) - alternative_vcall(ctxt_switch_masking, next); + const struct domain *nextd = next ? next->domain : NULL; + bool enable_cpuid_faulting; + + if ( cpu_has_cpuid_faulting || + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS) ) { + /* + * No need to alter the faulting setting if we are switching + * to idle; it won't affect any code running in idle context. + */ + if (nextd && is_idle_domain(nextd)) + return; + /* + * We *should* be enabling faulting for PV control domains. + * + * The domain builder has now been updated to not depend on + * seeing host CPUID values. This makes it compatible with + * PVH toolstack domains, and lets us enable faulting by + * default for all PV domains. + * + * However, as PV control domains have never had faulting + * enforced on them before, there might plausibly be other + * dependenices on host CPUID data. Therefore, we have left + * an interim escape hatch in the form of + * `dom0=no-cpuid-faulting` to restore the older behaviour. + */ + enable_cpuid_faulting = nextd && + domain_has_cap(nextd, CAP_DISABLE_CPU_FAULT) && + (is_pv_domain(nextd) || + next->arch.msrs->misc_features_enables.cpuid_faulting); + + if (cpu_has_cpuid_faulting) + set_cpuid_faulting(enable_cpuid_faulting); + else + amd_set_cpuid_user_dis(enable_cpuid_faulting); + + return; + } + + if (ctxt_switch_masking) + alternative_vcall(ctxt_switch_masking, next); } bool_t opt_cpu_info; diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 4e20edc3bf..d65144da01 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -907,6 +907,10 @@ static struct domain *__init create_dom0(const module_t *image, d->role |= ROLE_UNBOUNDED_DOMAIN; + if ( !opt_dom0_cpuid_faulting && + !domain_set_cap(d, CAP_DISABLE_CPU_FAULT) ) + printk(XENLOG_WARNING "failed to set CPU faulting on Dom %pd\n", d); + init_dom0_cpuid_policy(d); if ( alloc_dom0_vcpu0(d) == NULL ) diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b04fbe0565..ebfe65cd73 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -472,7 +472,8 @@ struct domain #define ROLE_HARDWARE_DOMAIN (1U<<2) #define ROLE_XENSTORE_DOMAIN (1U<<3) uint8_t role; -#define CAP_CONSOLE_IO (1U<<0) +#define CAP_CONSOLE_IO (1U<<0) +#define CAP_DISABLE_CPU_FAULT (1U<<1) uint8_t capabilities; /* Is this guest being debugged by dom0? */ bool debugger_attached; @@ -1160,6 +1161,11 @@ static always_inline bool domain_set_cap( case CAP_CONSOLE_IO: d->capabilities |= cap; break; + case CAP_DISABLE_CPU_FAULT: + /* Disabling cpu faulting is only allowed for a PV control domain. */ + if ( is_pv_domain(d) && is_control_domain(d) ) + d->capabilities |= cap; + break; default: return false; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 20:21:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 20:21:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574506.899866 (Exim 4.92) (envelope-from ) id 1qQvs8-0002HV-1j; Tue, 01 Aug 2023 20:21:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574506.899866; Tue, 01 Aug 2023 20:21:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvs7-0002HO-Ub; Tue, 01 Aug 2023 20:21:35 +0000 Received: by outflank-mailman (input) for mailman id 574506; Tue, 01 Aug 2023 20:21:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQvs6-0000Vh-NB for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 20:21:34 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 015545d7-30a9-11ee-b25c-6b7b168915f2; Tue, 01 Aug 2023 22:21:33 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 169092122567987.94507889080217; Tue, 1 Aug 2023 13:20:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 015545d7-30a9-11ee-b25c-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1690921227; cv=none; d=zohomail.com; s=zohoarc; b=eG/Jtj2jjhormLMJ8XaVecZkgDIqh8gVxgA4QY1AJ284PvyjA8JAMQ69PlgD5dj/o9HsZPzDydB1/djt8Thmj1SFXlXELhLph/E0r+BOpyOpze+/57pFXGJiTTCuJiSMro+AHiwzn8HiqoGm0mej89q49uEMansFfQ9fQbqinp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690921227; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=svZfhnzIdfl7IZVzuYzxJG9861EfU+6CgnykhTEOAGo=; b=gcq3ynDrvoMA+5ma7mE1tahSxRik03zdp5XIFeYhwZzhONbzcKcZrrHpTDpDTLdQUTLhEWHWSQNSyuIT6hBV8NSIr6hjnnfKnc1VLTpsYm9n7dop2JP9rxGvnT0MkXYHP+pFQrciwPLrXKsc2tsEM1ozQnTMqZvklB+yGqUtZxg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1690921227; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=svZfhnzIdfl7IZVzuYzxJG9861EfU+6CgnykhTEOAGo=; b=mSptNUuNqsChDAreussuY050V7fWTUHVOlYiNTMjMZt9oOuskamL7WrMR6aEMIG+ PLxoMKPl1sBCkvGqp4KDDSrCfqo39vlF7GSYF8CO+SuFfjIe+yVW3iTXp4vRApmrDve ZVg5vjrZFJ6bog455l770X5d1NuIuTfiohv1dQBg= From: "Daniel P. Smith" To: Wei Liu , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian Subject: [RFC 6/6] capabilities: convert attach debugger into a capability Date: Tue, 1 Aug 2023 16:20:06 -0400 Message-Id: <20230801202006.20322-7-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230801202006.20322-1-dpsmith@apertussolutions.com> References: <20230801202006.20322-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Expresses the ability to attach a debugger as a capability that a domain can be provisioned. Signed-off-by: Daniel P. Smith --- xen/arch/x86/hvm/svm/svm.c | 8 ++++---- xen/arch/x86/hvm/vmx/realmode.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 2 +- xen/arch/x86/hvm/vmx/vmx.c | 10 +++++----- xen/arch/x86/traps.c | 6 ++++-- xen/common/domctl.c | 6 ++++-- xen/include/xen/sched.h | 9 ++++++--- 7 files changed, 25 insertions(+), 18 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 27170213ae..9872804d39 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -999,7 +999,7 @@ static void noreturn cf_check svm_do_resume(void) { struct vcpu *v = current; struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; - bool debug_state = (v->domain->debugger_attached || + bool debug_state = (domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) || v->domain->arch.monitor.software_breakpoint_enabled || v->domain->arch.monitor.debug_exception_enabled); bool_t vcpu_guestmode = 0; @@ -1335,7 +1335,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) } /* fall through */ case X86_EXC_BP: - if ( curr->domain->debugger_attached ) + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) { /* Debug/Int3: Trap to debugger. */ domain_pause_for_debugger(); @@ -2732,7 +2732,7 @@ void svm_vmexit_handler(void) case VMEXIT_ICEBP: case VMEXIT_EXCEPTION_DB: - if ( !v->domain->debugger_attached ) + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) { unsigned int trap_type; @@ -2769,7 +2769,7 @@ void svm_vmexit_handler(void) if ( insn_len == 0 ) break; - if ( v->domain->debugger_attached ) + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) { /* AMD Vol2, 15.11: INT3, INTO, BOUND intercepts do not update RIP. */ __update_guest_eip(regs, insn_len); diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c index ff44ddcfa6..f761026a9d 100644 --- a/xen/arch/x86/hvm/vmx/realmode.c +++ b/xen/arch/x86/hvm/vmx/realmode.c @@ -121,7 +121,7 @@ void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt) if ( rc == X86EMUL_EXCEPTION ) { - if ( unlikely(curr->domain->debugger_attached) && + if ( unlikely(domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH)) && ((hvmemul_ctxt->ctxt.event.vector == X86_EXC_DB) || (hvmemul_ctxt->ctxt.event.vector == X86_EXC_BP)) ) { diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 13719cc923..9474869018 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1912,7 +1912,7 @@ void cf_check vmx_do_resume(void) hvm_asid_flush_vcpu(v); } - debug_state = v->domain->debugger_attached + debug_state = domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) || v->domain->arch.monitor.software_breakpoint_enabled || v->domain->arch.monitor.singlestep_enabled; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 7ec44018d4..5069e3cbf3 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2041,7 +2041,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) break; /* fall through */ case X86_EXC_BP: - if ( curr->domain->debugger_attached ) + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) { /* Debug/Int3: Trap to debugger. */ domain_pause_for_debugger(); @@ -2121,7 +2121,7 @@ static void cf_check vmx_set_info_guest(struct vcpu *v) * immediately vmexit and hence make no progress. */ __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); - if ( v->domain->debugger_attached && + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) && (v->arch.user_regs.eflags & X86_EFLAGS_TF) && (intr_shadow & VMX_INTR_SHADOW_STI) ) { @@ -4283,7 +4283,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) } } - if ( !v->domain->debugger_attached ) + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) { unsigned long insn_len = 0; int rc; @@ -4307,7 +4307,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) break; case X86_EXC_BP: HVMTRACE_1D(TRAP, vector); - if ( !v->domain->debugger_attached ) + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) { unsigned long insn_len; int rc; @@ -4647,7 +4647,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) HVM_MONITOR_SINGLESTEP_BREAKPOINT, 0, 0, 0); - if ( v->domain->debugger_attached ) + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) domain_pause_for_debugger(); } diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 4229bda159..041ced35ea 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1214,7 +1214,8 @@ void do_int3(struct cpu_user_regs *regs) return; } - if ( guest_kernel_mode(curr, regs) && curr->domain->debugger_attached ) + if ( guest_kernel_mode(curr, regs) && + domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) { curr->arch.gdbsx_vcpu_event = X86_EXC_BP; domain_pause_for_debugger(); @@ -1995,7 +1996,8 @@ void do_debug(struct cpu_user_regs *regs) v->arch.dr6 |= (dr6 & ~X86_DR6_DEFAULT); v->arch.dr6 &= (dr6 | ~X86_DR6_DEFAULT); - if ( guest_kernel_mode(v, regs) && v->domain->debugger_attached ) + if ( guest_kernel_mode(v, regs) && + domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) { domain_pause_for_debugger(); return; diff --git a/xen/common/domctl.c b/xen/common/domctl.c index 505e29c0dc..895ddf0600 100644 --- a/xen/common/domctl.c +++ b/xen/common/domctl.c @@ -99,7 +99,8 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying : 0) | (d->is_shut_down ? XEN_DOMINF_shutdown : 0) | (d->controller_pause_count > 0 ? XEN_DOMINF_paused : 0) | - (d->debugger_attached ? XEN_DOMINF_debugged : 0) | + (domain_has_cap(d, CAP_DEBUGGER_ATTACH) ? + XEN_DOMINF_debugged : 0) | (is_xenstore_domain(d) ? XEN_DOMINF_xs_domain : 0) | (is_hvm_domain(d) ? XEN_DOMINF_hvm_guest : 0) | d->shutdown_code << XEN_DOMINF_shutdownshift; @@ -643,7 +644,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) else { domain_pause(d); - d->debugger_attached = !!op->u.setdebugging.enable; + if ( !!op->u.setdebugging.enable ) + domain_set_cap(d, CAP_DEBUGGER_ATTACH); domain_unpause(d); /* causes guest to latch new status */ } break; diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index ebfe65cd73..47eadb5008 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -474,9 +474,8 @@ struct domain uint8_t role; #define CAP_CONSOLE_IO (1U<<0) #define CAP_DISABLE_CPU_FAULT (1U<<1) - uint8_t capabilities; - /* Is this guest being debugged by dom0? */ - bool debugger_attached; +#define CAP_DEBUGGER_ATTACH (1U<<2) + uint16_t capabilities; /* * Set to true at the very end of domain creation, when the domain is * unpaused for the first time by the systemcontroller. @@ -1166,6 +1165,10 @@ static always_inline bool domain_set_cap( if ( is_pv_domain(d) && is_control_domain(d) ) d->capabilities |= cap; break; + case CAP_DEBUGGER_ATTACH: + if ( !is_control_domain(d) ) + d->capabilities |= cap; + break; default: return false; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 21:03:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 21:03:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574525.899875 (Exim 4.92) (envelope-from ) id 1qQwWF-0007It-5p; Tue, 01 Aug 2023 21:03:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574525.899875; Tue, 01 Aug 2023 21:03:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwWF-0007Im-2m; Tue, 01 Aug 2023 21:03:03 +0000 Received: by outflank-mailman (input) for mailman id 574525; Tue, 01 Aug 2023 21:03:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwWD-0007Id-GL for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 21:03:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwWD-0007y7-2t; Tue, 01 Aug 2023 21:03:01 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qQwWC-0000HK-R9; Tue, 01 Aug 2023 21:03:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=5xAoF19G5on0AAgh3e8gncEBAhAwmSFAmOP58Ky81R4=; b=YFSpjnfbYwpQkIKdmDmVb3E3d9 BkrxyKDoHq6cK4211Ssb5BVD3wBG9WA0R+G8yorjyHD6NC1Nc1+DCY3k8cwrifM4yxIQBmVcviHEV 4vGkNNXRkQr9OCOOUD4nj91ximxpgeCPfc/T+P+KFZKmTfMsBwIG3E62+sUNagwLN9pQ=; Message-ID: <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> Date: Tue, 1 Aug 2023 22:02:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Khem Raj , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Michal Orzel References: <20230801174930.2995947-1-raj.khem@gmail.com> From: Julien Grall Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive In-Reply-To: <20230801174930.2995947-1-raj.khem@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Title: This patch is not arm32 specific anymore. So I would replace 'arm32' with 'arm'. This can be done on commit. On 01/08/2023 18:49, Khem Raj wrote: > Assembler from binutils 2.41 rejects [1] this syntax > > .section "name"[, flags...] > > where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] > > It is almost like a regression compared to 2.40 or older release, The next word after ',' start with an uppercase. Did you intend to use '.' rather than ','? That said, the documentation has the following: For SPARC ELF targets, the assembler supports another type of .section directive for compatibility with the Solaris assembler:" This leads me to think this is not a regression and instead an intended behavior (even though it breaks older build) even it breaks build. I would suggest to reword the commit message to: " Assembler from binutiles 2.41 will rejects ([1], [2]) the following syntax .section "name", #alloc for any other any target other than ELF SPARC. This means we can't use it in the Arm code. So switch to the GNU syntax .section name [, "flags"[, @type]] [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 [2] https://sourceware.org/binutils/docs-2.41/as.html#Section If you agree with the commit message, I can update it while committing. We should also consider to backport. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 21:22:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 21:22:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574533.899889 (Exim 4.92) (envelope-from ) id 1qQwon-0001Mj-Lm; Tue, 01 Aug 2023 21:22:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574533.899889; Tue, 01 Aug 2023 21:22:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwon-0001Mc-J8; Tue, 01 Aug 2023 21:22:13 +0000 Received: by outflank-mailman (input) for mailman id 574533; Tue, 01 Aug 2023 21:22:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwom-0001MO-HX; Tue, 01 Aug 2023 21:22:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwom-0008Qo-EJ; Tue, 01 Aug 2023 21:22:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwol-0008Fv-Tv; Tue, 01 Aug 2023 21:22:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qQwol-0001I9-TR; Tue, 01 Aug 2023 21:22:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xnsDnzCINM3KD3vxcozsDMYUPpfRShH50fkVNrm7m9c=; b=nQJUvhigVq11856Jw8IxlQa3oh c7wmymJ5FJXFX1qkKpI120OxK1cU70tZxuU8AK0ZY7Ji/B4J+7JL75UXP3+F5Yv+vxo9zQbmZcnae YfJfa5lvvK6KG/xAlreXcOuSOc7orUXzOfBLwH0XyOm3sZZFCGLAlX1jhSPvAnGQepeU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 182092: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:heisenbug xen-4.14-testing:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=602ee4c2954ed3f9f8552e08043146bee60ec012 X-Osstest-Versions-That: xen=64b40594f589c9069fb8cf3899d4aac59c86d4f1 From: osstest service owner Date: Tue, 01 Aug 2023 21:22:11 +0000 flight 182092 xen-4.14-testing real [real] flight 182104 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182092/ http://logs.test-lab.xenproject.org/osstest/logs/182104/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail pass in 182104-retest test-armhf-armhf-xl-vhd 13 guest-start fail pass in 182104-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 182104 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 182104 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181996 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181996 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181996 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181996 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181996 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181996 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181996 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181996 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181996 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181996 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181996 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181996 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 602ee4c2954ed3f9f8552e08043146bee60ec012 baseline version: xen 64b40594f589c9069fb8cf3899d4aac59c86d4f1 Last test of basis 181996 2023-07-24 16:37:10 Z 8 days Testing same since 182092 2023-07-31 13:06:48 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 64b40594f5..602ee4c295 602ee4c2954ed3f9f8552e08043146bee60ec012 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Tue Aug 01 21:29:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 21:29:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574539.899900 (Exim 4.92) (envelope-from ) id 1qQwvx-00021c-Ej; Tue, 01 Aug 2023 21:29:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574539.899900; Tue, 01 Aug 2023 21:29:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwvx-00021V-Ar; Tue, 01 Aug 2023 21:29:37 +0000 Received: by outflank-mailman (input) for mailman id 574539; Tue, 01 Aug 2023 21:29:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwvv-00021P-QP for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 21:29:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQwvu-00007d-Vm; Tue, 01 Aug 2023 21:29:34 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qQwvu-0001JL-Pz; Tue, 01 Aug 2023 21:29:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=mWg3GZe2EMYm8jv+TPe6s28ff4x2p+sSJJfNamkRpVI=; b=J1+xlsNLJb81lUGUEsGg5VR+O0 /GTVpweTIpoIAyuzkPYiKI6EBskx1bpFiILDUmgyV+02NF4TtHW3ldFNqECOWA7oEwo/cOxqWaQ8t r9ZnZutmfvjKmct7bR+mvl6JVSo7ROtZNmQ6vAuaBg9ASbHnKeL7ji+NARpYex44nycU=; Message-ID: <41f92dc6-7d3f-9342-5521-cdb99d8ee405@xen.org> Date: Tue, 1 Aug 2023 22:29:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-19-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH v3 18/25] tools/xenstore: don't use struct node_perms in struct node In-Reply-To: <20230724110247.10520-19-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: > Open code struct node_perms in struct node in order to prepare using > struct node_hdr in struct node. > > Add two helpers to transfer permissions between struct node and struct > node_perms. > > Signed-off-by: Juergen Gross > --- > V2: > - new patch > --- > tools/xenstore/xenstored_core.c | 76 ++++++++++++++------------ > tools/xenstore/xenstored_core.h | 21 ++++++- > tools/xenstore/xenstored_domain.c | 13 ++--- > tools/xenstore/xenstored_transaction.c | 8 +-- > tools/xenstore/xenstored_watch.c | 7 ++- > 5 files changed, 75 insertions(+), 50 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 86b7c9bf36..c72fc0c725 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -735,7 +735,7 @@ struct node *read_node(struct connection *conn, const void *ctx, > > /* Datalen, childlen, number of permissions */ > node->generation = hdr->generation; > - node->perms.num = hdr->num_perms; > + node->num_perms = hdr->num_perms; > node->datalen = hdr->datalen; > node->childlen = hdr->childlen; > node->acc.domid = perms_from_node_hdr(hdr)->id; > @@ -743,8 +743,8 @@ struct node *read_node(struct connection *conn, const void *ctx, > > /* Copy node data to new memory area, starting with permissions. */ > size -= sizeof(*hdr); > - node->perms.p = talloc_memdup(node, perms_from_node_hdr(hdr), size); > - if (node->perms.p == NULL) { > + node->perms = talloc_memdup(node, perms_from_node_hdr(hdr), size); > + if (node->perms == NULL) { > errno = ENOMEM; > goto error; > } > @@ -757,7 +757,7 @@ struct node *read_node(struct connection *conn, const void *ctx, > node->acc.memory = 0; > > /* Data is binary blob (usually ascii, no nul). */ > - node->data = node->perms.p + hdr->num_perms; > + node->data = node->perms + hdr->num_perms; > /* Children is strings, nul separated. */ > node->children = node->data + node->datalen; > > @@ -796,7 +796,7 @@ int write_node_raw(struct connection *conn, const char *db_name, > return errno; > > size = sizeof(*hdr) > - + node->perms.num * sizeof(node->perms.p[0]) > + + node->num_perms * sizeof(node->perms[0]) > + node->datalen + node->childlen; > > /* Call domain_max_chk() in any case in order to record max values. */ > @@ -813,13 +813,13 @@ int write_node_raw(struct connection *conn, const char *db_name, > > hdr = data; > hdr->generation = node->generation; > - hdr->num_perms = node->perms.num; > + hdr->num_perms = node->num_perms; > hdr->datalen = node->datalen; > hdr->childlen = node->childlen; > > p = perms_from_node_hdr(hdr); > - memcpy(p, node->perms.p, node->perms.num * sizeof(*node->perms.p)); > - p += node->perms.num * sizeof(*node->perms.p); > + memcpy(p, node->perms, node->num_perms * sizeof(*node->perms)); > + p += node->num_perms * sizeof(*node->perms); > memcpy(p, node->data, node->datalen); > p += node->datalen; > memcpy(p, node->children, node->childlen); > @@ -900,6 +900,7 @@ static int ask_parents(struct connection *conn, const void *ctx, > const char *name, unsigned int *perm) > { > struct node *node; > + struct node_perms perms; > > do { > name = get_parent(ctx, name); > @@ -919,7 +920,8 @@ static int ask_parents(struct connection *conn, const void *ctx, > return 0; > } > > - *perm = perm_for_conn(conn, &node->perms); > + node_to_node_perms(node, &perms); > + *perm = perm_for_conn(conn, &perms); This seems to be a common pattern. Can you introduce a wrapper? > return 0; > } > > @@ -956,11 +958,13 @@ static struct node *get_node(struct connection *conn, > unsigned int perm) > { > struct node *node; > + struct node_perms perms; > > node = read_node(conn, ctx, name); > /* If we don't have permission, we don't have node. */ > if (node) { > - if ((perm_for_conn(conn, &node->perms) & perm) != perm) { > + node_to_node_perms(node, &perms); > + if ((perm_for_conn(conn, &perms) & perm) != perm) { > errno = EACCES; > node = NULL; > } > @@ -1434,14 +1438,14 @@ static struct node *construct_node(struct connection *conn, const void *ctx, > node->name = talloc_steal(node, names[levels - 1]); > > /* Inherit permissions, unpriv domains own what they create. */ > - node->perms.num = parent->perms.num; > - node->perms.p = talloc_memdup(node, parent->perms.p, > - node->perms.num * > - sizeof(*node->perms.p)); > - if (!node->perms.p) > + node->num_perms = parent->num_perms; > + node->perms = talloc_memdup(node, parent->perms, > + node->num_perms * > + sizeof(*node->perms)); > + if (!node->perms) > goto nomem; > if (domain_is_unprivileged(conn)) > - node->perms.p[0].id = conn->id; > + node->perms[0].id = conn->id; > > /* No children, no data */ > node->children = node->data = NULL; > @@ -1764,12 +1768,14 @@ static int do_get_perms(const void *ctx, struct connection *conn, > struct node *node; > char *strings; > unsigned int len; > + struct node_perms perms; > > node = get_spec_node(conn, ctx, onearg(in), NULL, XS_PERM_READ); > if (!node) > return errno; > > - strings = perms_to_strings(node, &node->perms, &len); > + node_to_node_perms(node, &perms); > + strings = perms_to_strings(node, &perms, &len); This is the only user of perms_to_strings(). So can we just pass the node rather than the perms? This would avoid the call to node_to_node_perms(). > if (!strings) > return errno; > > @@ -1818,10 +1824,10 @@ static int do_set_perms(const void *ctx, struct connection *conn, > perms.p[0].id != get_node_owner(node)) > return EPERM; > > - old_perms = node->perms; > + node_to_node_perms(node, &old_perms); > if (domain_nbentry_dec(conn, get_node_owner(node))) > return ENOMEM; > - node->perms = perms; > + node_perms_to_node(&perms, node); > if (domain_nbentry_inc(conn, get_node_owner(node))) > return ENOMEM; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 21:34:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 21:34:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574545.899909 (Exim 4.92) (envelope-from ) id 1qQx0J-0003Vv-1Y; Tue, 01 Aug 2023 21:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574545.899909; Tue, 01 Aug 2023 21:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQx0I-0003Vo-VJ; Tue, 01 Aug 2023 21:34:06 +0000 Received: by outflank-mailman (input) for mailman id 574545; Tue, 01 Aug 2023 21:34:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQx0H-0003Vi-Sm for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 21:34:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQx0H-0000D3-70; Tue, 01 Aug 2023 21:34:05 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qQx0H-0001X9-1w; Tue, 01 Aug 2023 21:34:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tnhdVY1efL6wdvUGeDL7OkJOXxe7OXVl6sH5Tez9BSU=; b=a6TFJhlyi3VeShbff21naQM42C 9xtV1nCaKXXrXo950RhzqFLzh2/8pFIqSo6OWGGiub9m2HWbgZsMVgSRec/8OgafqKbc6pviDpJC7 O28TVkZITPT4ZC2YV9S2VPvSvDzHz3YD7HFTFyIkpkyd1/bhdv5WPXFT9uiLbRq8Dp1E=; Message-ID: Date: Tue, 1 Aug 2023 22:34:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 19/25] tools/xenstore: use struct node_hdr in struct node To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-20-jgross@suse.com> From: Julien Grall In-Reply-To: <20230724110247.10520-20-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index c72fc0c725..404ecd0c62 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -555,6 +555,12 @@ static void initialize_fds(int *p_sock_pollfd_idx, int *ptimeout) > } > } > > +static size_t calc_node_acc_size(struct node_hdr *hdr) The parameter can be const. > +{ > + return sizeof(*hdr) + hdr->num_perms * sizeof(struct xs_permissions) + > + hdr->datalen + hdr->childlen; > +} > + [...] > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 9cb4c2f3eb..adf8a785fc 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -181,6 +181,7 @@ extern struct list_head connections; > */ > struct node_hdr { > uint64_t generation; > +#define NO_GENERATION ~((uint64_t)0) > uint16_t num_perms; > uint16_t datalen; > uint32_t childlen; > @@ -197,6 +198,10 @@ struct node_account_data { > }; > > struct node { > + /* Data direct for data base. */ I can't parse it. Did you mean 'from' rather than 'for'? > + struct node_hdr hdr; > + > + /* Xenstore path. */ > const char *name; > /* Name used to access data base. */ > const char *db_name; > @@ -204,20 +209,13 @@ struct node { > /* Parent (optional) */ > struct node *parent; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 21:46:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 21:46:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574549.899920 (Exim 4.92) (envelope-from ) id 1qQxC1-00053z-52; Tue, 01 Aug 2023 21:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574549.899920; Tue, 01 Aug 2023 21:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxC1-00053s-1r; Tue, 01 Aug 2023 21:46:13 +0000 Received: by outflank-mailman (input) for mailman id 574549; Tue, 01 Aug 2023 21:46:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxBz-00053m-PA for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 21:46:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxBy-0000OY-R9; Tue, 01 Aug 2023 21:46:10 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qQxBy-00024c-M1; Tue, 01 Aug 2023 21:46:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=DfN7B1+PFgLt4NmDJOm3OKQ0rnGv+Wa/Cy3yHVp9wdw=; b=mKh8ahpKfBKWs9GK2R+scYK/4V LaCr05ldOgZxVh52+rBO06dKQ4wm1XsWJ7pcs9ILGBIygSYruJ9B/H8RaEG68vqRu7XOTqfWSOvtE tRIOMF+EzVrpSqwsXqdzHXCv19KMzf6SMMjMGXAKfx7nEdsbsZPKjbp8umdaBNA19xug=; Message-ID: Date: Tue, 1 Aug 2023 22:46:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-21-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH v3 20/25] tools/xenstore: alloc new memory in domain_adjust_node_perms() In-Reply-To: <20230724110247.10520-21-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 24/07/2023 12:02, Juergen Gross wrote: > In order to avoid modifying the node data in the data base in case a > domain is gone, let domain_adjust_node_perms() allocate new memory for > the permissions in case they need to be modified. As this should > happen only in very rare cases, it is fine to do this even when having > copied the node data already. > > Signed-off-by: Juergen Gross > --- > V3: > - new patch > --- > tools/xenstore/xenstored_core.c | 10 +++++----- > tools/xenstore/xenstored_domain.c | 19 +++++++++++++++---- > 2 files changed, 20 insertions(+), 9 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index 404ecd0c62..ea3d20a372 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -751,6 +751,11 @@ struct node *read_node(struct connection *conn, const void *ctx, > goto error; > } > > + /* Data is binary blob (usually ascii, no nul). */ > + node->data = node->perms + hdr->num_perms; > + /* Children is strings, nul separated. */ > + node->children = node->data + node->hdr.datalen; > + It took me a while to understand why you move the lines above. I tihnk it would be worth documenting in the code (possibly on top of the declaration domain_adjust_node_perms()) that domain_adjust_node_perms() may re-allocate the permissions. > if (domain_adjust_node_perms(node)) > goto error; > > @@ -758,11 +763,6 @@ struct node *read_node(struct connection *conn, const void *ctx, > if (node->acc.domid != get_node_owner(node)) > node->acc.memory = 0; > > - /* Data is binary blob (usually ascii, no nul). */ > - node->data = node->perms + hdr->num_perms; > - /* Children is strings, nul separated. */ > - node->children = node->data + node->hdr.datalen; > - > if (access_node(conn, node, NODE_ACCESS_READ, NULL)) > goto error; > > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstored_domain.c > index fdf1095acb..cdef6efef4 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -1334,13 +1334,24 @@ int domain_alloc_permrefs(struct node_perms *perms) > int domain_adjust_node_perms(struct node *node) > { > unsigned int i; > + struct xs_permissions *perms = node->perms; > + bool copied = false; > > for (i = 1; i < node->hdr.num_perms; i++) { > - if (node->perms[i].perms & XS_PERM_IGNORE) > + if ((perms[i].perms & XS_PERM_IGNORE) || > + chk_domain_generation(perms[i].id, node->hdr.generation)) > continue; > - if (!chk_domain_generation(node->perms[i].id, > - node->hdr.generation)) > - node->perms[i].perms |= XS_PERM_IGNORE; > + > + if (!copied) { This wants a coment explain why you need to copy it. > + perms = talloc_memdup(node, node->perms, > + node->hdr.num_perms * sizeof(*perms)); > + if (!perms) > + return ENOMEM; > + node->perms = perms; > + copied = true; > + } > + > + perms[i].perms |= XS_PERM_IGNORE; > } > > return 0; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 21:50:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 21:50:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574554.899929 (Exim 4.92) (envelope-from ) id 1qQxG4-0006Wb-Ks; Tue, 01 Aug 2023 21:50:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574554.899929; Tue, 01 Aug 2023 21:50:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxG4-0006WU-Hv; Tue, 01 Aug 2023 21:50:24 +0000 Received: by outflank-mailman (input) for mailman id 574554; Tue, 01 Aug 2023 21:50:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxG3-0006WO-Iz for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 21:50:23 +0000 Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [2001:4860:4864:20::32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69347b35-30b5-11ee-8613-37d641c3527e; Tue, 01 Aug 2023 23:50:21 +0200 (CEST) Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1bba7717d3bso4559742fac.1 for ; Tue, 01 Aug 2023 14:50:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69347b35-30b5-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690926620; x=1691531420; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d5rCAtpBNZXLPF1OmSD+Axody9pboeWmdmrPPO1MaOI=; b=QF+pguATSKLHX1a7qURHsLDFb43GgVsOkXf+YuzRuMvfzL9u5Lm6/098at+Bo0X0OF psFPWkV9dkhMY3jlc/rMbwXI9UTZiBF/RW+8PRi1lG6+4ghn/8BehNZybrIdpaEH5JEV 5pt+N8rDlySShFuIpvdijSW30mWvyqDireSey6RvsweRndchMt8+whuKYgGbmY2sGnV0 W81/3ELo1uaMGYSWLnuD5zVt1vYULErJbl3gL/o8D9teaFjxXO4BSYHJNe4ridR97gF0 ix99cvJ/CRW3DfSABez1awxLg5qXsUazFs+BzNi+R6PkkrNNCAJkEcOSv+D6rAxybGPa F4cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690926620; x=1691531420; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d5rCAtpBNZXLPF1OmSD+Axody9pboeWmdmrPPO1MaOI=; b=JHiRUe9R/CKNh6/HssyBOJYAiIvcGNER7wj0pbsid/VXOdS81jhN8JSamFzBZrjNyH 2NR+dT+9mTvS1uv4rZ9kUBKEmbwkt2IEDJ4RZZFIHVIgD4lYArxgs5u5+UGzrPvH8rMZ Gda14bDllD9gYEDqh8LvemK294gJ6gAEps0kkQWv5opGNKBq7R53AIkxrGnEEiiTqASU PQUXbIO6aZMeeFPA+tsPeDgfXIKS6gZaUv6DstW1hXnTmR4lg5CiBGscbN3sFFNNrX9s Cvb2E5HHiQWQsnIHQu+JFlxvzzgxCEbhbcwePn4oC1Fovn9P+rZt6CLTm8H2OJwZuaSz 7GHw== X-Gm-Message-State: ABy/qLYAtvLuvVu3EQWAieXGX/yFZ8kApFxxo1Oj4y98XMGa0u1i57Q/ jTDeroRf9RXlhPcPZedAt4hGceUtPBaMc8GFqFg= X-Google-Smtp-Source: APBJJlHX6m3nhYISCmTsQNwrp4Xd3U2QurjDzHUUYAgcbCgWYobQ5O1r4hHvwoL383XfwQOaaqHnRgBIJ51SsErIQi4= X-Received: by 2002:a05:6870:46a5:b0:1b0:25b4:4b7a with SMTP id a37-20020a05687046a500b001b025b44b7amr17682930oap.51.1690926620049; Tue, 01 Aug 2023 14:50:20 -0700 (PDT) MIME-Version: 1.0 References: <20230801174930.2995947-1-raj.khem@gmail.com> <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> In-Reply-To: <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> From: Khem Raj Date: Tue, 1 Aug 2023 14:49:53 -0700 Message-ID: Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Michal Orzel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 1, 2023 at 2:03=E2=80=AFPM Julien Grall wrote: > > Hi, > > Title: This patch is not arm32 specific anymore. So I would replace > 'arm32' with 'arm'. This can be done on commit. > > On 01/08/2023 18:49, Khem Raj wrote: > > Assembler from binutils 2.41 rejects [1] this syntax > > > > .section "name"[, flags...] > > > > where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] > > > > It is almost like a regression compared to 2.40 or older release, > > The next word after ',' start with an uppercase. Did you intend to use > '.' rather than ','? > > That said, the documentation has the following: > > For SPARC ELF targets, the assembler supports another type of .section > directive for compatibility with the Solaris assembler:" > > This leads me to think this is not a regression and instead an intended > behavior (even though it breaks older build) even it breaks build. > > I would suggest to reword the commit message to: > > " > Assembler from binutiles 2.41 will rejects ([1], [2]) the following synta= x > > .section "name", #alloc > > for any other any target other than ELF SPARC. This means we can't use > it in the Arm code. > > So switch to the GNU syntax > > .section name [, "flags"[, @type]] > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=3D11601 > [2] https://sourceware.org/binutils/docs-2.41/as.html#Section > > If you agree with the commit message, I can update it while committing. LGTM, go ahead. > > We should also consider to backport. > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:00:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:00:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574560.899940 (Exim 4.92) (envelope-from ) id 1qQxQA-00084S-FI; Tue, 01 Aug 2023 22:00:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574560.899940; Tue, 01 Aug 2023 22:00:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxQA-00084L-Bl; Tue, 01 Aug 2023 22:00:50 +0000 Received: by outflank-mailman (input) for mailman id 574560; Tue, 01 Aug 2023 22:00:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxQ9-00084F-Mt for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:00:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxQ8-0000oj-V7; Tue, 01 Aug 2023 22:00:48 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qQxQ8-0002a3-PG; Tue, 01 Aug 2023 22:00:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=gLfJupRwQ7HYE1cXcogQMMCy5YqnUZMWBbvO46IEjB0=; b=l2ksIYWLtQhr8tUB86lXcO3F0h M7I50l7QzaUmCi2JZLE1nx4qOMRMkDivIsuz7MxzgxlOLu6fKtU+XUTp1dLQOUnX0+qEjbVqre/Ea scyMRjWDk1LI8mSYNWY17VNzgG2Zx4OrtL8XqJTlP5LEsrLSoYoncIw2CQ68CQpdm2WQ=; Message-ID: Date: Tue, 1 Aug 2023 23:00:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-22-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH v3 21/25] tools/xenstore: introduce read_node_nocopy() In-Reply-To: <20230724110247.10520-22-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, Title: I can't find read_node_nocopy(). I found a read_node_const(). Which name did you intend to use? On 24/07/2023 12:02, Juergen Gross wrote: > +static int read_node_helper(struct connection *conn, struct node *node) > +{ > /* Data is binary blob (usually ascii, no nul). */ > - node->data = node->perms + hdr->num_perms; > + node->data = node->perms + node->hdr.num_perms; > /* Children is strings, nul separated. */ > node->children = node->data + node->hdr.datalen; > > if (domain_adjust_node_perms(node)) > - goto error; > + return -1; You are either returning 0 or -1 which is then only used in if ( ... ). Can we simply return a boolean (true for success, false for a failure)? The rest LGTM. > > /* If owner is gone reset currently accounted memory size. */ > if (node->acc.domid != get_node_owner(node)) > node->acc.memory = 0; > > if (access_node(conn, node, NODE_ACCESS_READ, NULL)) > + return -1; > + > + return 0; > +} Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:29:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:29:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574569.899951 (Exim 4.92) (envelope-from ) id 1qQxrz-0002GE-Nm; Tue, 01 Aug 2023 22:29:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574569.899951; Tue, 01 Aug 2023 22:29:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxrz-0002G7-IC; Tue, 01 Aug 2023 22:29:35 +0000 Received: by outflank-mailman (input) for mailman id 574569; Tue, 01 Aug 2023 22:29:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQxry-0002G1-0d for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:29:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e20faa3f-30ba-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 00:29:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3520E61696; Tue, 1 Aug 2023 22:29:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04990C433C7; Tue, 1 Aug 2023 22:29:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e20faa3f-30ba-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690928969; bh=y7Xj3uYtClikgUD+bLbpt8U+auf0lAO5gADuiw8ZcWM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EHuXYE+ZYSKFBO+sr5dpsomE3370A4lpxngSk+43GmuwhwtUt9n1JlcpE+1BymtNC NsPdcZBSc2u1yh+gScXJDIkeD6YENbxBTgRh7FBmtWprIx8O4hKxZFczjBTb0yK2Pb fa4UGenoZNE0zG6fRieLwAAW8FClRGineWPY9GsdOAldrD1Ih2tf7bNZeR0CEJkkyZ t1p1eh02Cl5LYU66jDc8lYRZ3HW6CqQENh5YX+y+ZY1ioWG0SNHGZjJJrjMp8wFBCO thzF2mKsjDacoClWKusGINl2KPLPw3sRkx2iJPNsnczzLALVXDUmzlc2XLWyafHm3s A/wfdBI/zc/4Q== Date: Tue, 1 Aug 2023 15:29:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "Daniel P. Smith" Subject: Re: [XEN PATCH v2 3/3] arm/efi: address MISRA C:2012 Rule 5.3 In-Reply-To: <688eea3584d537b6f41bb32f227f8be74ffd2783.1690893696.git.nicola.vetrini@bugseng.com> Message-ID: References: <688eea3584d537b6f41bb32f227f8be74ffd2783.1690893696.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Nicola Vetrini wrote: > Rule 5.3 has the following headline: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The file-scope variable 'fdt' is shadowed by function parameters, > and thus violates the rule, hence it's renamed to 'fdt_efi' > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Renamed the file-scope variable instead of removing function parameters. > --- > xen/arch/arm/efi/efi-boot.h | 84 ++++++++++++++++++------------------- > 1 file changed, 42 insertions(+), 42 deletions(-) > > diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h > index 6126a71400..f24df2abb9 100644 > --- a/xen/arch/arm/efi/efi-boot.h > +++ b/xen/arch/arm/efi/efi-boot.h > @@ -49,7 +49,7 @@ static void PrintMessage(const CHAR16 *s); > {0xb1b621d5U, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0}} > > static struct file __initdata dtbfile; > -static void __initdata *fdt; > +static void __initdata *fdt_efi; > static void __initdata *memmap; > > static int __init setup_chosen_node(void *fdt, int *addr_cells, int *size_cells) > @@ -383,7 +383,7 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable, > if ( EFI_ERROR(status) ) > blexit(L"EFI memory map processing failed"); > > - status = fdt_add_uefi_nodes(SystemTable, fdt, map, map_size, desc_size, > + status = fdt_add_uefi_nodes(SystemTable, fdt_efi, map, map_size, desc_size, > desc_ver); > if ( EFI_ERROR(status) ) > PrintErrMesg(L"Updating FDT failed", status); > @@ -395,7 +395,7 @@ static void __init efi_arch_pre_exit_boot(void) > > static void __init noreturn efi_arch_post_exit_boot(void) > { > - efi_xen_start(fdt, fdt_totalsize(fdt)); > + efi_xen_start(fdt_efi, fdt_totalsize(fdt_efi)); > } > > static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, > @@ -420,8 +420,8 @@ static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, > efi_bs->FreePool(name.w); > } > } > - fdt = fdt_increase_size(&dtbfile, cfg.size + EFI_PAGE_SIZE); > - if ( !fdt ) > + fdt_efi = fdt_increase_size(&dtbfile, cfg.size + EFI_PAGE_SIZE); > + if ( !fdt_efi ) > blexit(L"Unable to create new FDT"); > } > > @@ -465,7 +465,7 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, > int chosen; > > /* locate chosen node, which is where we add Xen module info. */ > - chosen = fdt_subnode_offset(fdt, 0, "chosen"); > + chosen = fdt_subnode_offset(fdt_efi, 0, "chosen"); > if ( chosen < 0 ) > blexit(L"Unable to find chosen node"); > > @@ -498,7 +498,7 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, > else > { > /* Get xen,xen-bootargs in /chosen if it is specified */ > - const char *dt_bootargs_prop = fdt_getprop(fdt, chosen, > + const char *dt_bootargs_prop = fdt_getprop(fdt_efi, chosen, > "xen,xen-bootargs", NULL); > if ( dt_bootargs_prop ) > { > @@ -526,7 +526,7 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, > blexit(L"FDT string overflow"); > } > > - if ( fdt_setprop_string(fdt, chosen, "xen,xen-bootargs", buf) < 0 ) > + if ( fdt_setprop_string(fdt_efi, chosen, "xen,xen-bootargs", buf) < 0 ) > blexit(L"Unable to set xen,xen-bootargs property."); > > efi_bs->FreePool(buf); > @@ -542,7 +542,7 @@ static void __init efi_arch_handle_module(const struct file *file, > > if ( file == &dtbfile ) > return; > - chosen = setup_chosen_node(fdt, &addr_len, &size_len); > + chosen = setup_chosen_node(fdt_efi, &addr_len, &size_len); > if ( chosen < 0 ) > blexit(L"Unable to setup chosen node"); > > @@ -551,13 +551,13 @@ static void __init efi_arch_handle_module(const struct file *file, > static const char __initconst ramdisk_compat[] = "multiboot,ramdisk\0" > "multiboot,module"; > > - node = fdt_add_subnode(fdt, chosen, "ramdisk"); > + node = fdt_add_subnode(fdt_efi, chosen, "ramdisk"); > if ( node < 0 ) > blexit(L"Unable to add ramdisk FDT node."); > - if ( fdt_setprop(fdt, node, "compatible", ramdisk_compat, > + if ( fdt_setprop(fdt_efi, node, "compatible", ramdisk_compat, > sizeof(ramdisk_compat)) < 0 ) > blexit(L"Unable to set compatible property."); > - if ( fdt_set_reg(fdt, node, addr_len, size_len, ramdisk.addr, > + if ( fdt_set_reg(fdt_efi, node, addr_len, size_len, ramdisk.addr, > ramdisk.size) < 0 ) > blexit(L"Unable to set reg property."); > } > @@ -566,13 +566,13 @@ static void __init efi_arch_handle_module(const struct file *file, > static const char __initconst xsm_compat[] = "xen,xsm-policy\0" > "multiboot,module"; > > - node = fdt_add_subnode(fdt, chosen, "xsm"); > + node = fdt_add_subnode(fdt_efi, chosen, "xsm"); > if ( node < 0 ) > blexit(L"Unable to add xsm FDT node."); > - if ( fdt_setprop(fdt, node, "compatible", xsm_compat, > + if ( fdt_setprop(fdt_efi, node, "compatible", xsm_compat, > sizeof(xsm_compat)) < 0 ) > blexit(L"Unable to set compatible property."); > - if ( fdt_set_reg(fdt, node, addr_len, size_len, xsm.addr, > + if ( fdt_set_reg(fdt_efi, node, addr_len, size_len, xsm.addr, > xsm.size) < 0 ) > blexit(L"Unable to set reg property."); > } > @@ -581,15 +581,15 @@ static void __init efi_arch_handle_module(const struct file *file, > static const char __initconst kernel_compat[] = "multiboot,kernel\0" > "multiboot,module"; > > - node = fdt_add_subnode(fdt, chosen, "kernel"); > + node = fdt_add_subnode(fdt_efi, chosen, "kernel"); > if ( node < 0 ) > blexit(L"Unable to add dom0 FDT node."); > - if ( fdt_setprop(fdt, node, "compatible", kernel_compat, > + if ( fdt_setprop(fdt_efi, node, "compatible", kernel_compat, > sizeof(kernel_compat)) < 0 ) > blexit(L"Unable to set compatible property."); > - if ( options && fdt_setprop_string(fdt, node, "bootargs", options) < 0 ) > + if ( options && fdt_setprop_string(fdt_efi, node, "bootargs", options) < 0 ) > blexit(L"Unable to set bootargs property."); > - if ( fdt_set_reg(fdt, node, addr_len, size_len, kernel.addr, > + if ( fdt_set_reg(fdt_efi, node, addr_len, size_len, kernel.addr, > kernel.size) < 0 ) > blexit(L"Unable to set reg property."); > } > @@ -719,7 +719,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, > module_info *file; > > /* Check if the node is a multiboot,module otherwise return */ > - module_compat = fdt_node_check_compatible(fdt, module_node_offset, > + module_compat = fdt_node_check_compatible(fdt_efi, module_node_offset, > "multiboot,module"); > if ( module_compat < 0 ) > /* Error while checking the compatible string */ > @@ -730,7 +730,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, > return 0; > > /* Read xen,uefi-binary property to get the file name. */ > - uefi_name_prop = fdt_getprop(fdt, module_node_offset, "xen,uefi-binary", > + uefi_name_prop = fdt_getprop(fdt_efi, module_node_offset, "xen,uefi-binary", > &uefi_name_len); > > if ( !uefi_name_prop ) > @@ -751,13 +751,13 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, > snprintf(mod_string, sizeof(mod_string), "module@%"PRIx64, file->addr); > > /* Rename the module to be module@{address} */ > - if ( fdt_set_name(fdt, module_node_offset, mod_string) < 0 ) > + if ( fdt_set_name(fdt_efi, module_node_offset, mod_string) < 0 ) > { > PrintMessage(L"Unable to modify module node name."); > return ERROR_RENAME_MODULE_NAME; > } > > - if ( fdt_set_reg(fdt, module_node_offset, reg_addr_cells, reg_size_cells, > + if ( fdt_set_reg(fdt_efi, module_node_offset, reg_addr_cells, reg_size_cells, > file->addr, file->size) < 0 ) > { > PrintMessage(L"Unable to set module reg property."); > @@ -766,7 +766,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, > > if ( !is_domu_module ) > { > - if ( (fdt_node_check_compatible(fdt, module_node_offset, > + if ( (fdt_node_check_compatible(fdt_efi, module_node_offset, > "multiboot,kernel") == 0) ) > { > /* > @@ -784,14 +784,14 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, > kernel.size = file->size; > } > else if ( ramdisk.addr && > - (fdt_node_check_compatible(fdt, module_node_offset, > + (fdt_node_check_compatible(fdt_efi, module_node_offset, > "multiboot,ramdisk") == 0) ) > { > PrintMessage(L"Dom0 ramdisk already found in cfg file."); > return ERROR_DOM0_RAMDISK_FOUND; > } > else if ( xsm.addr && > - (fdt_node_check_compatible(fdt, module_node_offset, > + (fdt_node_check_compatible(fdt_efi, module_node_offset, > "xen,xsm-policy") == 0) ) > { > PrintMessage(L"XSM policy already found in cfg file."); > @@ -816,7 +816,7 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima > unsigned int mb_modules_found = 0; > > /* Get #address-cells and #size-cells from domain node */ > - prop = fdt_get_property(fdt, domain_node, "#address-cells", &len); > + prop = fdt_get_property(fdt_efi, domain_node, "#address-cells", &len); > if ( !prop ) > { > PrintMessage(L"#address-cells not found in domain node."); > @@ -825,7 +825,7 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima > > addr_cells = fdt32_to_cpu(*((uint32_t *)prop->data)); > > - prop = fdt_get_property(fdt, domain_node, "#size-cells", &len); > + prop = fdt_get_property(fdt_efi, domain_node, "#size-cells", &len); > if ( !prop ) > { > PrintMessage(L"#size-cells not found in domain node."); > @@ -835,9 +835,9 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima > size_cells = fdt32_to_cpu(*((uint32_t *)prop->data)); > > /* Check for nodes compatible with multiboot,module inside this node */ > - for ( module_node = fdt_first_subnode(fdt, domain_node); > + for ( module_node = fdt_first_subnode(fdt_efi, domain_node); > module_node > 0; > - module_node = fdt_next_subnode(fdt, module_node) ) > + module_node = fdt_next_subnode(fdt_efi, module_node) ) > { > int ret = handle_module_node(loaded_image, dir_handle, module_node, > addr_cells, size_cells, true); > @@ -862,7 +862,7 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) > EFI_FILE_HANDLE dir_handle = NULL; > > /* Check for the chosen node in the current DTB */ > - chosen = setup_chosen_node(fdt, &addr_len, &size_len); > + chosen = setup_chosen_node(fdt_efi, &addr_len, &size_len); > if ( chosen < 0 ) > { > PrintMessage(L"Unable to setup chosen node"); > @@ -870,13 +870,13 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) > } > > /* Check for nodes compatible with xen,domain under the chosen node */ > - for ( node = fdt_first_subnode(fdt, chosen); > + for ( node = fdt_first_subnode(fdt_efi, chosen); > node > 0; > - node = fdt_next_subnode(fdt, node) ) > + node = fdt_next_subnode(fdt_efi, node) ) > { > int ret; > > - if ( !fdt_node_check_compatible(fdt, node, "xen,domain") ) > + if ( !fdt_node_check_compatible(fdt_efi, node, "xen,domain") ) > { > /* Found a node with compatible xen,domain; handle this node. */ > ret = handle_dom0less_domain_node(loaded_image, &dir_handle, node); > @@ -951,29 +951,29 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) > * node to decide whether to skip the UEFI Xen configuration file or not. > */ > > - fdt = lookup_fdt_config_table(SystemTable); > - dtbfile.ptr = fdt; > + fdt_efi = lookup_fdt_config_table(SystemTable); > + dtbfile.ptr = fdt_efi; > dtbfile.need_to_free = false; /* Config table memory can't be freed. */ > > - if ( fdt && > - (fdt_node_offset_by_compatible(fdt, 0, "multiboot,module") > 0) ) > + if ( fdt_efi && > + (fdt_node_offset_by_compatible(fdt_efi, 0, "multiboot,module") > 0) ) > { > /* Locate chosen node */ > - int node = fdt_subnode_offset(fdt, 0, "chosen"); > + int node = fdt_subnode_offset(fdt_efi, 0, "chosen"); > const void *cfg_load_prop; > int cfg_load_len; > > if ( node > 0 ) > { > /* Check if xen,uefi-cfg-load property exists */ > - cfg_load_prop = fdt_getprop(fdt, node, "xen,uefi-cfg-load", > + cfg_load_prop = fdt_getprop(fdt_efi, node, "xen,uefi-cfg-load", > &cfg_load_len); > if ( !cfg_load_prop ) > load_cfg_file = false; > } > } > > - if ( !fdt || load_cfg_file ) > + if ( !fdt_efi || load_cfg_file ) > { > /* > * We either have no FDT, or one without modules, so we must have a > @@ -983,7 +983,7 @@ static bool __init efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) > } > PrintStr(L"Using modules provided by bootloader in FDT\r\n"); > /* We have modules already defined in fdt, just add space. */ > - fdt = fdt_increase_size(&dtbfile, EFI_PAGE_SIZE); > + fdt_efi = fdt_increase_size(&dtbfile, EFI_PAGE_SIZE); > > return false; > } > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:54:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:54:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574574.899960 (Exim 4.92) (envelope-from ) id 1qQyFp-0005fx-NI; Tue, 01 Aug 2023 22:54:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574574.899960; Tue, 01 Aug 2023 22:54:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyFp-0005fq-KI; Tue, 01 Aug 2023 22:54:13 +0000 Received: by outflank-mailman (input) for mailman id 574574; Tue, 01 Aug 2023 22:54:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyFo-0005fU-5y for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:54:12 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51ea000c-30be-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 00:54:08 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 623B582859F4; Tue, 1 Aug 2023 17:54:06 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Lm04u2qqgvGr; Tue, 1 Aug 2023 17:54:04 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 949408285A2B; Tue, 1 Aug 2023 17:54:04 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CkcdfIuHHHN4; Tue, 1 Aug 2023 17:54:04 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 2954682859F4; Tue, 1 Aug 2023 17:54:04 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51ea000c-30be-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 949408285A2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690930444; bh=3/X49LZtB0q8e21PzAIz8wSdVqrP+VUI0RFYwJYNlwA=; h=Message-ID:Date:MIME-Version:To:From; b=El/x5ogrVjI9rZ0iMhB49KFXlxeyiGpLKoDbGjBPuVqQTOioLljJx8vj2g9UVhCbi BDhMupQdVgv6RvBTZKCrajGd6YgdSwO9/hvBPbQ9wnvPxPCXRftgM8F2MWPhdtuWef 8uhmRDO18s7uLiCWp66c7z0be/x3C3qBIKFHoW2k= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: Date: Tue, 1 Aug 2023 17:54:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <3023ad320b42fa3787bb71a9cf83b34965668fe9.1690579561.git.sanastasio@raptorengineering.com> <41b33115-274c-7172-f100-85d6a4f1d538@suse.com> From: Shawn Anastasio In-Reply-To: <41b33115-274c-7172-f100-85d6a4f1d538@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/23 6:19 AM, Jan Beulich wrote: > On 28.07.2023 23:35, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/include/asm/asm-defns.h >> +++ b/xen/arch/ppc/include/asm/asm-defns.h >> @@ -23,6 +23,18 @@ >> addis reg,%r2,name@toc@ha; \ >> addi reg,reg,name@toc@l > > Noticing only now, because of the issue ... > >> +/* >> + * Declare a global assembly function with a proper TOC setup prologue >> + */ >> +#define _GLOBAL_TOC(name) \ >> + .balign 4; \ >> + .type name,@function; \ >> + .globl name; \ >> +name: \ >> +0: addis %r2,%r12,(.TOC.-0b)@ha; \ >> + addi %r2,%r2,(.TOC.-0b)@l; \ >> + .localentry name,.-name > > ... being widened - could we gain blanks after the commas? Down here > (to match the code in context) another padding blank after "addi" > would also be nice. Sure, will do in v2. >> --- a/xen/arch/ppc/opal.c >> +++ b/xen/arch/ppc/opal.c >> @@ -8,9 +8,28 @@ >> #include >> #include >> >> -/* Global OPAL struct containing entrypoint and base */ >> +/* Global OPAL struct containing entrypoint and base used by opal-calls.S */ >> struct opal opal; >> >> +int64_t opal_console_write(int64_t term_number, uint64_t *length, >> + uint8_t *buffer); > > Would this perhaps better be void *, eliminating the need for casting > in calls of this function? I made it uint8_t to match the official OPAL API documentation (though I now see I missed a `const`): https://open-power.github.io/skiboot/doc/opal-api/opal-console-read-write-1-2.html#opal-console-write In this case though, the type information of this parameter might not be that important and changing it to void* to avoid the cast is fine with me. >> +int64_t opal_console_flush(int64_t term_number); >> +int64_t opal_reinit_cpus(uint64_t flags); >> + >> +static void opal_putchar(char c) > > Can't this be __init? Unlike OpenFirmware, OPAL calls are expected to be used by the OS during its entire lifecycle, not just during early boot, so the full (non-early) serial console driver would likely want to use these functions as well. > >> +{ >> + uint64_t len; >> + if (c == '\n') > > Nit: Blank line please between declaration(s) and statement(s). (At > least one more instance below.) Will fix. > Also please add the missing blanks in the if(), seeing that otherwise > the file is aiming at being Xen style. Ditto. >> + { >> + char buf = '\r'; >> + len = cpu_to_be64(1); >> + opal_console_write(0, &len, (uint8_t *) &buf); >> + } >> + len = cpu_to_be64(1); >> + opal_console_write(0, &len, (uint8_t *) &c); >> + opal_console_flush(0); >> +} >> + >> void __init boot_opal_init(const void *fdt) >> { >> int opal_node; >> @@ -45,4 +64,10 @@ void __init boot_opal_init(const void *fdt) >> >> opal.base = be64_to_cpu(*opal_base); >> opal.entry = be64_to_cpu(*opal_entry); >> + >> + early_printk_init(opal_putchar); >> + >> + /* Ask OPAL to set HID0 for Little Endian interrupts + Radix TLB support */ >> + opal_reinit_cpus(OPAL_REINIT_CPUS_HILE_LE | OPAL_REINIT_CPUS_MMU_RADIX >> + | OPAL_REINIT_CPUS_MMU_HASH); > > Nit: operators on continued lines go at the end of the earlier line. Will fix. >> --- /dev/null >> +++ b/xen/arch/ppc/ppc64/opal-calls.S >> @@ -0,0 +1,82 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * Adapted from Linux's arch/powerpc/boot/opal-calls.S >> + * >> + * Copyright (c) 2016 IBM Corporation. >> + * Copyright Raptor Engineering, LLC >> + */ >> + >> +#include >> +#include > > Would it make sense to have asm-defns.h include asm-offsets.h, like > x86 and Arm do? Sure, I'll make this change along with the formatting updates in asm-defns.h >> +#include >> +#include >> + >> + .text > > Is any of this code still needed post-init? Yes, see above. >> +#define OPAL_CALL(name, token) \ >> + .globl name; \ >> +name: \ >> + li %r0, token; \ >> + b opal_call; > > I think the trailing semicolon wants omitting. Will fix. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:55:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574576.899970 (Exim 4.92) (envelope-from ) id 1qQyGf-0006E1-0d; Tue, 01 Aug 2023 22:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574576.899970; Tue, 01 Aug 2023 22:55:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyGe-0006Du-Sw; Tue, 01 Aug 2023 22:55:04 +0000 Received: by outflank-mailman (input) for mailman id 574576; Tue, 01 Aug 2023 22:55:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyGd-00068k-JI for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:55:03 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72496b3b-30be-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 00:55:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF9006170A; Tue, 1 Aug 2023 22:55:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99F44C433C7; Tue, 1 Aug 2023 22:54:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72496b3b-30be-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690930500; bh=5zn9kQv49Hcnf6MfXJ5JEWSAtAYEyHbETuWQJIOn3VM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MovoLszg0Z68inlF15OiVMeq/UlHp7SuYiSpbut4jksERd0LouU3daPTlcA/te9Hr EsT9qY6Tq6XHAxiYOftnwYapkQ+kBLkiKqpJfTfx3gbijFpIJE8Mzxv49++1biuwQB +ISVEQYOR53AB/4ZvnAmGeaNrlWZeoE7ukMMBfRXlbXh07H/vZAEu3Jkh9INK/89Qi /4CSOvnNScTCs0wuO0N3M+gHvSS5kor+LhpY27f7BPsxKeig0QHv6aqtOmsmXSqlFI Hot5ivEqyi0+tjOpx01YP6LEgcOCE75gcB+BtRZY95gk7vWGVgMaOGu/JeAk12vqKK D83F9d547wRCw== Date: Tue, 1 Aug 2023 15:54:58 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 1/4] automation/eclair: add support for tag pipelines In-Reply-To: <5e79b954062385c4d765c32347bcb45896d3ed5e.1690881495.git.simone.ballarin@bugseng.com> Message-ID: References: <5e79b954062385c4d765c32347bcb45896d3ed5e.1690881495.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Simone Ballarin wrote: > The ECLAIR jobs fail when triggered by tag pipelines (e.g. > xen-project/patchew/xen). > > This patch extends the integration to support such pipelines. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini Thanks for the fix! One good suggestion from Andrew would be to check for required variables at the beginning, rather than at the end. As it is now we are doing all the work just to fail at the end. It would have been better to fail immediately saving resources. It could be another patch :-) > --- > .../eclair_analysis/ECLAIR/action.settings | 24 ++++++++++++------- > 1 file changed, 15 insertions(+), 9 deletions(-) > > diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings > index 96426811a8..71c10d5141 100644 > --- a/automation/eclair_analysis/ECLAIR/action.settings > +++ b/automation/eclair_analysis/ECLAIR/action.settings > @@ -41,7 +41,7 @@ github) > push | workflow_dispatch) > event=push > # Extract the branch name from "refs/heads/" > - branch="${GITHUB_REF#refs/heads/}" > + ref="${GITHUB_REF#refs/heads/}" > headCommitId="${GITHUB_SHA}" > pushUser="${GITHUB_ACTOR}" > ;; > @@ -75,7 +75,13 @@ gitlab) > ;; > push | pipeline | web) > event=push > - branch="${CI_COMMIT_BRANCH}" > + if [ -n "${CI_COMMIT_BRANCH:-}" ]; then > + ref_kind=branch > + ref="${CI_COMMIT_BRANCH}" > + else > + ref_kind=tag > + ref="${CI_COMMIT_TAG}" > + fi > headCommitId="${CI_COMMIT_SHA}" > pushUser="${GITLAB_USER_NAME}" > ;; > @@ -99,7 +105,7 @@ jenkins) > jenkinsBotToken="${ECLAIR_BOT_TOKEN:-}" > > event=push > - branch="${GIT_BRANCH}" > + ref="${GIT_BRANCH}" > headCommitId="${GIT_COMMIT}" > pushUser=$(git show --pretty='format:%aN' -s) > ;; > @@ -111,7 +117,7 @@ esac > > if [ "${event}" = "push" ] && [ -n "${autoPRBranch:-}" ]; then > # AUTO PR Feature enabled > - if ! [ "${branch}" = "${autoPRBranch}" ] || > + if ! [ "${ref}" = "${autoPRBranch}" ] || > ! [ "${repository}" = "${autoPRRepository}" ]; then > event=auto_pull_request > fi > @@ -123,17 +129,17 @@ pull_request) > jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pullRequestUser} wants to merge ${pullRequestHeadRepo}:${pullRequestHeadRef} (${headCommitId}) into ${pullRequestBaseRef} (${baseCommitId})" > ;; > push) > - subDir="${branch}" > - jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: branch ${branch} (${headCommitId})" > - badgeLabel="ECLAIR ${ANALYSIS_KIND} ${branch}${variantHeadline} #${jobId}" > + subDir="${ref}" > + jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${ref_kind} ${ref} (${headCommitId})" > + badgeLabel="ECLAIR ${ANALYSIS_KIND} ${ref}${variantHeadline} #${jobId}" > ;; > auto_pull_request) > git remote remove autoPRRemote || true > git remote add autoPRRemote "${autoPRRemoteUrl}" > git fetch -q autoPRRemote > - subDir="${branch}" > + subDir="${ref}" > baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" HEAD) > - jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pushUser} wants to merge ${repository}:${branch} (${headCommitId}) into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" > + jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pushUser} wants to merge ${repository}:${ref} (${headCommitId}) into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" > ;; > *) > echo "Unexpected event ${event}" >&2 > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:55:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:55:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574577.899979 (Exim 4.92) (envelope-from ) id 1qQyGs-0006ct-7Y; Tue, 01 Aug 2023 22:55:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574577.899979; Tue, 01 Aug 2023 22:55:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyGs-0006cm-4j; Tue, 01 Aug 2023 22:55:18 +0000 Received: by outflank-mailman (input) for mailman id 574577; Tue, 01 Aug 2023 22:55:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyGr-0006a5-Fi for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:55:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 79d8104c-30be-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 00:55:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD3BD6173D; Tue, 1 Aug 2023 22:55:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84F30C433C8; Tue, 1 Aug 2023 22:55:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79d8104c-30be-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690930513; bh=QkLQ9kast8vfIEvHrFehxIBcnIuL8yfQwANOYm+u+uo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=k/8WSzUNyZTNrX+Q8TS8L4nKgsJBgGarlkbUiGPU//ubkOjglinZWk/cWHH60VJd8 9L4kqk1l/8+NA5fbmFRDKi6WehB7/z53tRHgatBCspT2Tr4tShmjKHH/cpPr/7NCB+ ZqLT/qZoQI7jdlq7RCG+mN6LVMARM9Qeej2bIQS9ULnNRdCNPwsr4ojLPODvAU97ID vBhME5rB9MS1fqtqAewalsnXHg52JzYMxZflhaZdoRPqkhpZrHnZu35kFBc18+X7rb qCImrQxusu+MbBgyjvbxKsDvNl07lLlo5U3zJaXuBWNm+roEdB7dcrfJLLaLfIB1gr KGPlyClMcHDCg== Date: Tue, 1 Aug 2023 15:55:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 2/4] automation/eclair: add direct link to reports In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Simone Ballarin wrote: > This patch adds direct links to the analysis findings in the > console log. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini > --- > .../eclair_analysis/ECLAIR/action.helpers | 84 ++++++++++++++----- > 1 file changed, 65 insertions(+), 19 deletions(-) > > diff --git a/automation/eclair_analysis/ECLAIR/action.helpers b/automation/eclair_analysis/ECLAIR/action.helpers > index 2ad6428eaa..df9bf2bd11 100644 > --- a/automation/eclair_analysis/ECLAIR/action.helpers > +++ b/automation/eclair_analysis/ECLAIR/action.helpers > @@ -1,17 +1,26 @@ > +esc=$(printf '\e') > +cr=$(printf '\r') > + > if [ -n "${GITLAB_CI:-}" ]; then > ci=gitlab > + eol= > + link_start="${esc}[33m" > + link_end="${esc}[m" > elif [ -n "${GITHUB_ACTION:-}" ]; then > ci=github > + eol="\\" > + link_start= > + link_end= > elif [ -n "${JENKINS_HOME:-}" ]; then > ci=jenkins > + eol="
" > + link_start= > + link_end= > else > echo "Unexpected CI/CD context" >&2 > exit 1 > fi > > -esc=$(printf '\e') > -cr=$(printf '\r') > - > open_section() { > id=$1 > title=$2 > @@ -36,54 +45,86 @@ summary() { > > case "${ci}" in > github) > - nl="\\" > + eol="\\" > ;; > gitlab) > - nl= > + eol= > ;; > jenkins) > - nl="
" > + eol="
" > ;; > *) > - nl= > + eol= > ;; > esac > > + currentDbReportsUrl="${eclairReportUrlPrefix}/fs${jobDir}/PROJECT.ecd;/by_service.html#service&kind" > if [ -z "${newReports}" ]; then > - fixedMsg= > + fixedMsg="No fixed reports as there is no baseline" > unfixedMsg="Unfixed reports: ${unfixedReports}" > - countsMsg="${unfixedMsg}" > + referenceReportsMsgTxt= > + referenceReportsMsgLog= > else > fixedMsg="Fixed reports: ${fixedReports}" > unfixedMsg="Unfixed reports: ${unfixedReports} [new: ${newReports}]" > - countsMsg="${fixedMsg}${nl} > -${unfixedMsg}" > + case "${event}" in > + pull_request | auto_pull_request) > + referenceDbReportsUrl="${eclairReportUrlPrefix}/fs${jobDir}/base/PROJECT.ecd;/by_service.html#service&kind" > + reference_kind=base > + ;; > + push) > + referenceDbReportsUrl="${eclairReportUrlPrefix}/fs${jobDir}/prev/PROJECT.ecd;/by_service.html#service&kind" > + reference_kind=previous > + ;; > + *) > + echo "Unexpected event ${event}" >&2 > + exit 1 > + ;; > + esac > fi > + > case "${ci}" in > jenkins) > + if [ -n "${newReports}" ]; then > + referenceReportsMsgTxt="Browse ${reference_kind} reports" > + fi > cat <"${summaryTxt}" > -${countsMsg} ${nl} > +${fixedMsg}${eol} > +${unfixedMsg} ${eol} > > > >

${jobHeadline}

> -Browse analysis results > +Browse analysis summary > +Browse current reports > +${referenceReportsMsgTxt} > EOF > ;; > *) > + if [ -n "${newReports}" ]; then > + referenceReportsMsgTxt="Browse ${reference_kind} reports: ${referenceDbReportsUrl}" > + fi > cat <"${summaryTxt}" > > > > Analysis Summary > > -${jobHeadline}${nl} > -${countsMsg}${nl} > -[Browse analysis](${indexHtmlUrl}) > +${jobHeadline}${eol} > +${fixedMsg}${eol} > +${unfixedMsg}${eol} > +Browse analysis summary: ${indexHtmlUrl} > +Browse current reports: ${currentDbReportsUrl} > +${referenceReportsMsgTxt} > EOF > ;; > esac > > + analysisSummaryMsgLog="Browse analysis summary: ${link_start}${indexHtmlUrl}${link_end}" > + currentReportsMsgLog="Browse current reports: ${link_start}${currentDbReportsUrl}${link_end}" > + if [ -n "${newReports}" ]; then > + referenceReportsMsgLog="Browse ${reference_kind} reports: ${link_start}${referenceDbReportsUrl}${link_end}" > + fi > case ${ci} in > github) > cat "${summaryTxt}" >"${GITHUB_STEP_SUMMARY}" > @@ -93,8 +134,11 @@ EOF > # Generate summary and print it (GitLab-specific) > cat < ${jobHeadline} > -${countsMsg} > -Browse analysis: ${esc}[33m${indexHtmlUrl}${esc}[m > +${fixedMsg} > +${unfixedMsg} > +${analysisSummaryMsgLog} > +${currentReportsMsgLog} > +${referenceReportsMsgLog} > EOF > close_section ECLAIR_summary > ;; > @@ -103,7 +147,9 @@ EOF > ${jobHeadline} > ${fixedMsg} > ${unfixedMsg} > -Browse analysis: ${indexHtmlUrl} > +${analysisSummaryMsgLog} > +${currentReportsMsgLog} > +${referenceReportsMsgLog} > EOF > ;; > *) > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:55:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574579.899990 (Exim 4.92) (envelope-from ) id 1qQyH1-00073A-Fz; Tue, 01 Aug 2023 22:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574579.899990; Tue, 01 Aug 2023 22:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyH1-00072x-Cp; Tue, 01 Aug 2023 22:55:27 +0000 Received: by outflank-mailman (input) for mailman id 574579; Tue, 01 Aug 2023 22:55:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyH0-0006a5-2l for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:55:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f5b4dfd-30be-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 00:55:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 157C76175E; Tue, 1 Aug 2023 22:55:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE8B4C433C9; Tue, 1 Aug 2023 22:55:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f5b4dfd-30be-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690930522; bh=Zq4j4sA91c4fjlF94qx8L1rfRV34WFvbrKGFOAGpuOE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SqPd81tUzhEYU06GHVrfqv34VqnwxjkevKZZIf8vgeSoZav/gjZEYvyIem3nnnicN kAHuJYw1LpZePHRn8R9czN3ka4WASvRRKXD+5uiU8mvAXApaIJmcLJZHw2sfyGpEye ZeJCsUdctWBZ/wiG0UTa5VOzKLuG3inmLk6FQWVb4ivcvuR5Ik6xkedl4u7oq1yUnq fWcdedj1wwNIIB2zsaCLH0xpkMq+t4YD3a0XUw70GKVL9TjN8gYJD8PSjQZNubsME1 0f5VeN7WEiPPSHLEUgCaVQ6hYYbOhGhldlJrsNQrfFc9/8k0oTOQTdd+uvGxllBhT/ RaAD+DYheUnSA== Date: Tue, 1 Aug 2023 15:55:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines In-Reply-To: <76f3cdddcba485e8124659566b2f992b3b14da17.1690881495.git.simone.ballarin@bugseng.com> Message-ID: References: <76f3cdddcba485e8124659566b2f992b3b14da17.1690881495.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Simone Ballarin wrote: > This patch introduces six new ECLAIR jobs that run only > when triggered by a GitLab scheduled pipeline. > > Signed-off-by: Simone Ballarin > --- > .../eclair_analysis/ECLAIR/action.settings | 2 +- > automation/gitlab-ci/analyze.yaml | 65 +++++++++++++++++-- > 2 files changed, 62 insertions(+), 5 deletions(-) > > diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings > index 71c10d5141..528bc24c72 100644 > --- a/automation/eclair_analysis/ECLAIR/action.settings > +++ b/automation/eclair_analysis/ECLAIR/action.settings > @@ -73,7 +73,7 @@ gitlab) > headCommitId="${CI_COMMIT_SHA}" > baseCommitId="${CI_MERGE_REQUEST_DIFF_BASE_SHA}" > ;; > - push | pipeline | web) > + push | pipeline | web | schedule) > event=push > if [ -n "${CI_COMMIT_BRANCH:-}" ]; then > ref_kind=branch > diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml > index 3d8166572b..3325ef9d9a 100644 > --- a/automation/gitlab-ci/analyze.yaml > +++ b/automation/gitlab-ci/analyze.yaml > @@ -8,6 +8,8 @@ > ENABLE_ECLAIR_BOT: "n" > AUTO_PR_BRANCH: "staging" > AUTO_PR_REPOSITORY: "xen-project/xen" > + script: > + - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}" > artifacts: > when: always > paths: > @@ -23,8 +25,6 @@ eclair-x86_64: > LOGFILE: "eclair-x86_64.log" > VARIANT: "X86_64" > RULESET: "Set1" > - script: > - - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}" > allow_failure: true > > eclair-ARM64: > @@ -33,6 +33,63 @@ eclair-ARM64: > LOGFILE: "eclair-ARM64.log" > VARIANT: "ARM64" > RULESET: "Set1" > - script: > - - ./automation/scripts/eclair 2>&1 | tee "${LOGFILE}" > + allow_failure: true > + > +.eclair-analysis:on-schedule: > + extends: .eclair-analysis > + rules: > + - if: $CI_PIPELINE_SOURCE == "schedule" If I understand this right, the idea is that someone would schedule a pipeline (Build -> "Pipeline Schedules") and as part of that, they would also define the variable "CI_PIPELINE_SOURCE" to schedule. Is that correct? If so, please add a good in-code comments here on top of .eclair-analysis:on-schedule to explain it. So that someone reading this might know how what to do with the Gitlab CI settings. > +eclair-x86_64-Set1:on-schedule: > + extends: .eclair-analysis:on-schedule > + variables: > + VARIANT: "X86_64" > + RULESET: "Set1" > + ANALYSIS_KIND: "${RULESET}-scheduled" > + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" > + allow_failure: true > + > +eclair-x86_64-Set2:on-schedule: > + extends: .eclair-analysis:on-schedule > + variables: > + VARIANT: "X86_64" > + RULESET: "Set2" > + ANALYSIS_KIND: "${RULESET}-scheduled" > + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" > + allow_failure: true > + > +eclair-x86_64-Set3:on-schedule: > + extends: .eclair-analysis:on-schedule > + variables: > + VARIANT: "X86_64" > + RULESET: "Set3" > + ANALYSIS_KIND: "${RULESET}-scheduled" > + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" > + allow_failure: true > + > +eclair-ARM64-Set1:on-schedule: > + extends: .eclair-analysis:on-schedule > + variables: > + VARIANT: "ARM64" > + RULESET: "Set1" > + ANALYSIS_KIND: "${RULESET}-scheduled" > + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" > + allow_failure: true > + > +eclair-ARM64-Set2:on-schedule: > + extends: .eclair-analysis:on-schedule > + variables: > + VARIANT: "ARM64" > + RULESET: "Set2" > + ANALYSIS_KIND: "${RULESET}-scheduled" > + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" > + allow_failure: true > + > +eclair-ARM64-Set3:on-schedule: > + extends: .eclair-analysis:on-schedule > + variables: > + VARIANT: "ARM64" > + RULESET: "Set3" > + ANALYSIS_KIND: "${RULESET}-scheduled" > + LOGFILE: "eclair-${VARIANT}-${RULESET}.log" > allow_failure: true > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Tue Aug 01 22:55:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 22:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574580.900000 (Exim 4.92) (envelope-from ) id 1qQyHA-0007Yv-U9; Tue, 01 Aug 2023 22:55:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574580.900000; Tue, 01 Aug 2023 22:55:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyHA-0007Ym-Qr; Tue, 01 Aug 2023 22:55:36 +0000 Received: by outflank-mailman (input) for mailman id 574580; Tue, 01 Aug 2023 22:55:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQyH9-00068k-9M for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 22:55:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 858e2184-30be-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 00:55:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7BA706170A; Tue, 1 Aug 2023 22:55:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4132BC433C7; Tue, 1 Aug 2023 22:55:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 858e2184-30be-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690930532; bh=Ee7DDAYHauG77sy+uzAQQVwyNNEPwIv9SOzMTw9Jtf0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LfWzSf+7c01925+Yic7h1PjDb2MPLbd6pWIQs5myUaeK2hKOGoAq1HMfcAu02IzE+ xC3GMd3P/X9p9TW5ffdIHUY00udhP51VEp0O28eNsoLFec/y2zf7HXXcs1I95sOjDh CnVKVIwb0vF0XRL7eREjEcCTb4jDUr/aqt9WEn5HQJuh06Xqjg/ENhtKmkqklFCwiT exCGK2yLruncG9jAauZ4U/5ZHI7cNHE0Y8QDeaniibVXpIYmZSJ+D/SMVEfsKOrok0 DpcB55v5sWsx9y7ZPAXgE1aekvQqGo0rMd+PEn6MEr+ZIwlHeYbQILyhSWDIli4Kpk i+ZHlN+EMvO3w== Date: Tue, 1 Aug 2023 15:55:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 4/4] automation/eclair: avoid failure in case of missing merge point In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Simone Ballarin wrote: > In the context of an auto pull request, when a common merge point > is not found the integration will continue the analysis without > failing. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini > --- > automation/eclair_analysis/ECLAIR/action.settings | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/automation/eclair_analysis/ECLAIR/action.settings b/automation/eclair_analysis/ECLAIR/action.settings > index 528bc24c72..f96368ffc7 100644 > --- a/automation/eclair_analysis/ECLAIR/action.settings > +++ b/automation/eclair_analysis/ECLAIR/action.settings > @@ -138,7 +138,9 @@ auto_pull_request) > git remote add autoPRRemote "${autoPRRemoteUrl}" > git fetch -q autoPRRemote > subDir="${ref}" > - baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" HEAD) > + if ! baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" HEAD); then > + baseCommitId=no_merge_point > + fi > jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: ${pushUser} wants to merge ${repository}:${ref} (${headCommitId}) into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" > ;; > *) > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Tue Aug 01 23:19:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 01 Aug 2023 23:19:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574596.900010 (Exim 4.92) (envelope-from ) id 1qQye3-0003BE-OO; Tue, 01 Aug 2023 23:19:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574596.900010; Tue, 01 Aug 2023 23:19:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQye3-0003B7-Lg; Tue, 01 Aug 2023 23:19:15 +0000 Received: by outflank-mailman (input) for mailman id 574596; Tue, 01 Aug 2023 23:19:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQye1-0003Au-88 for xen-devel@lists.xenproject.org; Tue, 01 Aug 2023 23:19:13 +0000 Received: from mgamail.intel.com (unknown [134.134.136.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf16d94f-30c1-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 01:19:08 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 16:19:04 -0700 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 01 Aug 2023 16:19:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 16:19:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 16:19:02 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 16:19:02 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 16:19:01 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by BN9PR11MB5531.namprd11.prod.outlook.com (2603:10b6:408:104::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Tue, 1 Aug 2023 23:18:58 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 23:18:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf16d94f-30c1-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690931948; x=1722467948; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Bj5w8ug5nXkPeA631Z/FPHszoX+SVqqkPZbhd/00H+M=; b=jO7e9TAPDJSo47rE0yB6TvLgF252z5GELRD86UG7HouxaxetO3SmIxvx 0eD1YNisakyv55CqEAJ7K8y52cMCJWG5o92mytQg2w69LmBwSiDVTHGeh p3vWX8bk0jO+dIXwZMvcEcLT6Dcs28RdnZh4bytdLyhsWU2swi45sqBOI 2l9H3ltmbYkHfdjvY92Ja+paO3gjfM8qYn3g0qKHsKSkdO5R5r/fIB/1w SVmJtRjcAdR7MCFl3HFlT7CKpt+MNz7uVi72j3zw9Cj6U5IlSCR+GCVPo 0oHIMDWsVC85ilfnpQnmKFmd9I4QAXB/YvHxoZsJ3V9A6bC1gKUrX0z0T A==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="372164218" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="372164218" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="975463188" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="975463188" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6OnvTlFB0Z4Az04FF2JP/OQPJXQARjUEk6tuZWuEzxwzNx1am73RzC4tRurLIPmOE0nAN5+MNDPh/hNYLcuBW+dampqcxvRaf4i+1vrmAdrZ6I4JSGdc0gYtOkKVVnAAsNrsAigNHYN+FECMc3qOuwOXTHFoRIkqspvkvpJ/aiLrD7ra5AfUR6YEyl+G1UQBKJWgLMQ1ifjQAttI4FinsaIYCHwzYcqMLuEiNQald+8WlgpqZEkKctJFJOOUxEPTLnjDaKu0KgItzPXmF6IbLYHelpeBt4Hy0ZkmfyYDeDW+SX+SWh9QxoB5k0pV2/lnoBI2ht/ekn3lBawsPTZOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S8XlHjVcyfKORPqwqUUtCNjTJnsqwsptu6fUDZ6EwMc=; b=h8Gx5TfTzNt1IIu4IBBZ1PsLgHJHdv5h06581B9Ptv37El2/n5d1c69T36NonHbCHd9u4utT71NF44OeLZtZakNvFOEM6OV1ro5AVqgH+sMnyZx3qtg/kxo1JhNIh6y3Leo+VF9RrQmwWDWteX1SYYyPNQrcvDCp00TCmWIUT2Dvd/dIKZqBbeePbgrGUFnt76ex1m+9GlCjwqTwCPcYXt6XtsgwActzeORHTm+wfJ8W3zwtJpYW/FnbUAcE2qT+RVzOORGY7fEdg/t6gugHbk/XN7HRodpZRICYsxa9DOH+Wjs+5S8w6SgUmym4iNGtQOn1pbowpYFRPGss64oqrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: "Christopherson,, Sean" CC: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Jonathan Corbet , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Lutomirski, Andy" , Oleg Nesterov , "Luck, Tony" , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , "Cui, Dexuan" , Paolo Bonzini , "Wanpeng Li" , Vitaly Kuznetsov , "Peter Zijlstra" , "Gross, Jurgen" , "Stefano Stabellini" , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , "Steven Rostedt" , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , "Chatre, Reinette" , "Daniel Sneddon" , Breno Leitao , Nikunj A Dadhania , Brian Gerst , "Sami Tolvanen" , Alexander Potapenko , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , "Masahiro Yamada" , Ze Gao , "Li, Fei1" , Conghui , "Raj, Ashok" , "Jason A . Donenfeld" , Mark Rutland , Jacob Pan , "Jiapeng Chong" , Jane Malalane , "Woodhouse, David" , "Ostrovsky, Boris" , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: RE: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling Thread-Topic: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling Thread-Index: AQHZxFc6Fm9A65hsiUKYksIzWWSQ5K/VzGiAgABBoTA= Date: Tue, 1 Aug 2023 23:18:58 +0000 Message-ID: References: <20230801083553.8468-1-xin3.li@intel.com> <20230801083553.8468-7-xin3.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|BN9PR11MB5531:EE_ x-ms-office365-filtering-correlation-id: dcaf6d6e-4187-4417-1291-08db92e5aef5 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r+cxM3pPta8sYitUgROn2PDucNcvUltiyujBLIB2Z3wc/WA1AbpGfiDgnG9ZYXNPCazHzJRSrD7yg9SlHm0RpgIU92mD//G2FOnZbMXYqkS9rAXw8oGg29t03wb9+L8oj34ta6j/zwjU159ZxdM4/KUGyubBdtUbQwPvR2Fcu82GfE6XgEgEcZPoFpG18sWnfD8mwsKSZ/IPzxtmQULTfv0bfMlSUrigqSh/dityjnqxcvC1NlobvtkVFxDX/EtrPJDHDBI33wmCK4NWV/Jfm/PXW6Ojbs3wqBWGKVYnB+mg2ReWtV0Rr7HmOhZ9r0V6/M9Deske9dBdlz/eYLTWAckiJLc6RNaaxIKUrcQc+l8ZHNcuu8pibRB2E/uGeoBe8Z+HejgkJfxE18Xyz1P1r7PwUEPz554vq8wLD/3HflT+OF4VkbiEeEpEadkuRjFktwPyolvk7fmbSq24tNm0qQV+6NuJMDzha/lLGYG6v+KZcAyUfOHWDLWQBrbhrBKYbB+vdNv8paD2fKP2UkojnMLGw5Gfri8nYlkqhwOlRfQgqWfdPfxcVDNZEYmL1Bci+KJ3nYJ/TQkJrRWXZ4ZmOUiM+pw1wFV/3ZLR/xfij2Y= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(376002)(346002)(396003)(136003)(451199021)(55016003)(186003)(9686003)(316002)(86362001)(478600001)(122000001)(54906003)(38100700002)(76116006)(71200400001)(66946007)(66556008)(66476007)(66446008)(33656002)(64756008)(7696005)(4326008)(6916009)(82960400001)(6506007)(41300700001)(26005)(52536014)(8676002)(5660300002)(8936002)(30864003)(2906002)(38070700005)(7416002)(7406005)(7366002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a/2pvAgarmi6UxxjEwF9/15YLf2D0Eyn4fdBB8TeZPD1X1viRO//B83LSg+W?= =?us-ascii?Q?Kb1IdO9MiI6onQllU79snUl5ERrgGYi0IcI196Hl3kip2suAMqWODPMTM2LP?= =?us-ascii?Q?eNrdGtYbxu7IVB71bzz8NR4HhEADC8Iz/0UpQWzmDOg5jYVpP9bheXJFvSu0?= =?us-ascii?Q?Pe8yWpoq72YuJCN1vn/WZbfmimwy1GnFcNimvVFQmWCVn5sW06QeSYH2BUNQ?= =?us-ascii?Q?rWMxGTwHW6TUTD3cJ9N7wIjTotFv7mx6lzbIbfmNaa5Kq8vPbBJbrFC2pkz6?= =?us-ascii?Q?o0XywMr2OPye+wB1KthXoxT9FlPr5knw9mevANI78AgCQqBTo/HdQwxLsa9q?= =?us-ascii?Q?mh4OmuzyKkQYl1rW2Y/Qj606hKl8yXua+muHOsNGOGoQkzKXsUh4wBdP3IVp?= =?us-ascii?Q?9w2RARPvzINL29PxfzwHggsig+iwYOv/hQbxbUE0EOnbLeR34bSucGOl50L1?= =?us-ascii?Q?RzjSNl1Mmj872iKuR7IdZKVnx3P125fcFI6Wms7Fwrf7xUstqDQeZJ/831Qg?= =?us-ascii?Q?AHrT5Hhoea963KRxmwvc+xTs7h3jDDmwy6cuoEAPzbCze2I/jD1J0JdE00nh?= =?us-ascii?Q?8JUkhP1iq2/nkMAv5HP3WBMstojrhSwGAHUmAyVTe9ejwgGWOogZN7/1oKHq?= =?us-ascii?Q?gXWYUgLlg1D3JQv8ytHKjTWuXcYkFH9UcUusaGJ6xYpoqhQVfhtyRM5UtaBo?= =?us-ascii?Q?E+CLgpxhhHMPkFaYhCub2XqviDWFDoFIUOif5Mp/6mwhYGvozE1/88Kug/f6?= =?us-ascii?Q?i8Ip+TfcXnB8OyuoNL/tfdZ7auSwDB9TUvdaQJmjIKxnVPkVu/X75wezWphi?= =?us-ascii?Q?YwcyUPwBXPXXiGWXCJfkYBSCGXjDFs7sNpdm8eOoBNeZcRgMQ+kBDC0CHw3M?= =?us-ascii?Q?0giAooLfQrIrOvOMgmG8n/rsthYIg+qCw3n8hsjNr3FtZBMLZLh4+JhIjF2o?= =?us-ascii?Q?M9b9a+CPz4Fx+VNCkhsSXlnECKrQ2Mx0IYM7PjgyM/WufkvWwbRagO4F8Bcs?= =?us-ascii?Q?88T8Rui1/HKgQq2tkgICF13dQehrvtfhw857nucMvWVWxu4il690S0aoVUdu?= =?us-ascii?Q?J6L9aje42joksBmHiVoAdRjr8TNotpKWCu+0R33wHKEQhEPuCldsiNkr5mnD?= =?us-ascii?Q?gNoxHrhUA19rkcAf+3NcKQkhRqVlDjWjPBPMHFOQ/9IC1MuGWmxe3VwrKM5+?= =?us-ascii?Q?6NLq3/MvzcwkJg7MeruyNC7FSHYrnJRJjtTfyFzBV68ahPqny6nmjHhaXXQg?= =?us-ascii?Q?mS7kWPhezOmDMXB4j/afudj8xvnEBFaRJg38Clj6x+lohzd9A75OGSQj/wnO?= =?us-ascii?Q?0IZVVPSPZCpZF0GRQ2QBUOzS3WFZ/CUcZ1URSH6YA+mhFG7xeXctwtMps1FE?= =?us-ascii?Q?QC6Fj1+UhReDZAV4AQUd8m+vvsKtPa2Z+vkSow4Wd0rZmLQBBXGRJHvtAnqm?= =?us-ascii?Q?csHgiAtZu+rrRMLsJ62P/DbeDtSc2BkZ8sxdMrOc0sMfRikfW50dzH/O/tdl?= =?us-ascii?Q?Ep2bVYks3d+ffPtxBwQm3xVJ2lalH6UQdOZuQW0i1dbQum+zAwaiL3YtjpSq?= =?us-ascii?Q?ybJJ8ADOJcos5uSX+uE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcaf6d6e-4187-4417-1291-08db92e5aef5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 23:18:58.3382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zLD37UF9Af+/IutB05oxvOXT646Uz9bT1I+muC63nEsLa2MpWAeg8hpAy4QXyWL2PwYzM6wcEojbDrn0Es+yLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5531 X-OriginatorOrg: intel.com > > +#include "../../entry/calling.h" >=20 > Rather than do the low level PUSH_REGS and POP_REGS, I vote to have core = code > expose a FRED-specific wrapper for invoking external_interrupt(). More b= elow. Nice idea! > > + /* > > + * A FRED stack frame has extra 16 bytes of information pushed at the > > + * regular stack top compared to an IDT stack frame. >=20 > There is pretty much no chance that anyone remembers the layout of an IDT= stack > frame off the top of their head. I.e. saying "FRED has 16 bytes more" is= n't all > that useful. It also fails to capture the fact that FRED stuff a hell of= a lot > more information in those "common" 48 bytes. >=20 > It'll be hard/impossible to capture all of the overload info in a comment= , but > showing the actual layout of the frame would be super helpful, e.g. somet= hing > like > this >=20 > /* > * FRED stack frames are always 64 bytes: > * > * ------------------------------ > * | Bytes | Usage | > * -----------------------------| > * | 63:56 | Reserved | > * | 55:48 | Event Data | > * | 47:40 | SS + Event Info | > * | 39:32 | RSP | > * | 31:24 | RFLAGS | > * | 23:16 | CS + Aux Info | > * | 15:8 | RIP | > * | 7:0 | Error Code | > * ------------------------------ > */ > * > * Use LEA to get the return RIP and push it, then push an error code. > * Note, only NMI handling does an ERETS to the target! IRQ handling > * doesn't need to unmask NMIs and so simply uses CALL+RET, i.e. the > * RIP pushed here is only truly consumed for NMIs! I take these as ASM code does need more love, i.e., nice comments :/ Otherwise only more confusion. =20 >=20 > Jumping way back to providing a wrapper for FRED, if we do that, then the= re's no > need to include calling.h, and the weird wrinkle about the ERET target ki= nda goes > away too. E.g. provide this in arch/x86/entry/entry_64_fred.S >=20 > .section .text, "ax" >=20 > /* Note, this is instrumentation safe, and returns via RET, not ERETS! */ > #if IS_ENABLED(CONFIG_KVM_INTEL) > SYM_CODE_START(fred_irq_entry_from_kvm) > FRED_ENTER > call external_interrupt > FRED_EXIT > RET > SYM_CODE_END(fred_irq_entry_from_kvm) > EXPORT_SYMBOL_GPL(fred_irq_entry_from_kvm); > #endif >=20 > and then the KVM side for this particular chunk is more simply: >=20 > lea 1f(%rip), %rax > push %rax > push $0 /* FRED error code, 0 for NMI and external > interrupts */ >=20 > \branch_insn \branch_target > 1: > VMX_DO_EVENT_FRAME_END > RET >=20 >=20 > Alternatively, the whole thing could be shoved into > arch/x86/entry/entry_64_fred.S, > but at a glance I don't think that would be a net positive due to the nee= d to > handle > IRQs vs. NMIs. >=20 > > + \branch_insn \branch_target > > + > > + .if \nmi =3D=3D 0 > > + POP_REGS > > + .endif > > + > > +1: > > + /* > > + * "Restore" RSP from RBP, even though IRET has already unwound RSP t= o >=20 > As mentioned above, this is incorrect on two fronts. >=20 > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > > index 0ecf4be2c6af..4e90c69a92bf 100644 > > --- a/arch/x86/kvm/vmx/vmx.c > > +++ b/arch/x86/kvm/vmx/vmx.c > > @@ -6890,6 +6890,14 @@ static void vmx_apicv_post_state_restore(struct > kvm_vcpu *vcpu) > > memset(vmx->pi_desc.pir, 0, sizeof(vmx->pi_desc.pir)); > > } > > > > +#ifdef CONFIG_X86_FRED > > +void vmx_do_fred_interrupt_irqoff(unsigned int vector); > > +void vmx_do_fred_nmi_irqoff(unsigned int vector); > > +#else > > +#define vmx_do_fred_interrupt_irqoff(x) BUG() > > +#define vmx_do_fred_nmi_irqoff(x) BUG() > > +#endif >=20 > My slight preference is to open code the BUG() as a ud2 in assembly, pure= ly to > avoid more #ifdefs. >=20 > > + > > void vmx_do_interrupt_irqoff(unsigned long entry); > > void vmx_do_nmi_irqoff(void); > > > > @@ -6932,14 +6940,16 @@ static void handle_external_interrupt_irqoff(st= ruct > kvm_vcpu *vcpu) > > { > > u32 intr_info =3D vmx_get_intr_info(vcpu); > > unsigned int vector =3D intr_info & INTR_INFO_VECTOR_MASK; > > - gate_desc *desc =3D (gate_desc *)host_idt_base + vector; > > > > if (KVM_BUG(!is_external_intr(intr_info), vcpu->kvm, > > "unexpected VM-Exit interrupt info: 0x%x", intr_info)) > > return; > > > > kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); > > - vmx_do_interrupt_irqoff(gate_offset(desc)); > > + if (cpu_feature_enabled(X86_FEATURE_FRED)) > > + vmx_do_fred_interrupt_irqoff(vector); /* Event type is 0 */ >=20 > I strongly prefer to use code to document what's going on. E.g. the tail= comment > just left me wondering, what event type is 0? Whereas this makes it quit= e clear > that KVM is signaling a hardware interrupt. The fact that it's a nop as = far as > code generation goes is irrelevant. >=20 > vmx_do_fred_interrupt_irqoff((EVENT_TYPE_HWINT << 16) | vector); Better readability. >=20 > > + else > > + vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base > + vector)); > > kvm_after_interrupt(vcpu); > > > > vcpu->arch.at_instruction_boundary =3D true; >=20 > Here's a diff for (hopefully) everything I've suggested above. Thanks a lot! I will test it and update the patch in this mail thread. >=20 > --- > arch/x86/entry/entry_64_fred.S | 17 ++++++- > arch/x86/kernel/traps.c | 5 -- > arch/x86/kvm/vmx/vmenter.S | 84 +++++++++++++++------------------- > arch/x86/kvm/vmx/vmx.c | 7 +-- > 4 files changed, 55 insertions(+), 58 deletions(-) >=20 > diff --git a/arch/x86/entry/entry_64_fred.S b/arch/x86/entry/entry_64_fre= d.S > index 12063267d2ac..a973c0bd29f6 100644 > --- a/arch/x86/entry/entry_64_fred.S > +++ b/arch/x86/entry/entry_64_fred.S > @@ -10,7 +10,6 @@ > #include "calling.h" >=20 > .code64 > - .section ".noinstr.text", "ax" >=20 > .macro FRED_ENTER > UNWIND_HINT_END_OF_STACK > @@ -24,6 +23,22 @@ > POP_REGS > .endm >=20 > + .section .text, "ax" > + > +/* Note, this is instrumentation safe, and returns via RET, not ERETS! *= / > +#if IS_ENABLED(CONFIG_KVM_INTEL) > +SYM_CODE_START(fred_irq_entry_from_kvm) > + FRED_ENTER > + call external_interrupt > + FRED_EXIT > + RET > +SYM_CODE_END(fred_irq_entry_from_kvm) > +EXPORT_SYMBOL_GPL(fred_irq_entry_from_kvm); > +#endif > + > + .section ".noinstr.text", "ax" > + > + > /* > * The new RIP value that FRED event delivery establishes is > * IA32_FRED_CONFIG & ~FFFH for events that occur in ring 3. > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c > index 21eeba7b188f..cbcb83c71dab 100644 > --- a/arch/x86/kernel/traps.c > +++ b/arch/x86/kernel/traps.c > @@ -1566,11 +1566,6 @@ int external_interrupt(struct pt_regs *regs) > return 0; > } >=20 > -#if IS_ENABLED(CONFIG_KVM_INTEL) > -/* For KVM VMX to handle IRQs in IRQ induced VM exits. */ > -EXPORT_SYMBOL_GPL(external_interrupt); > -#endif > - > #endif /* CONFIG_X86_64 */ >=20 > void __init trap_init(void) > diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S > index 79a4c91d9434..e25df565c3f8 100644 > --- a/arch/x86/kvm/vmx/vmenter.S > +++ b/arch/x86/kvm/vmx/vmenter.S > @@ -9,7 +9,6 @@ > #include > #include "kvm-asm-offsets.h" > #include "run_flags.h" > -#include "../../entry/calling.h" >=20 > #define WORD_SIZE (BITS_PER_LONG / 8) >=20 > @@ -33,15 +32,31 @@ > #define VCPU_R15 __VCPU_REGS_R15 * WORD_SIZE > #endif >=20 > +.macro VMX_DO_EVENT_FRAME_BEGIN > + /* > + * Unconditionally create a stack frame, getting the correct RSP on the > + * stack (for x86-64) would take two instructions anyways, and RBP can > + * be used to restore RSP to make objtool happy (see below). > + */ > + push %_ASM_BP > + mov %_ASM_SP, %_ASM_BP > +.endm > + > +.macro VMX_DO_EVENT_FRAME_END > + /* > + * "Restore" RSP from RBP, even though {E,I}RET has already unwound RSP > + * to the correct value *in most cases*. KVM's IRQ handling with FRED > + * doesn't do ERETS, and objtool doesn't know the callee will IRET/ERET > + * and, without the explicit restore, thinks the stack is getting wallo= ped. > + * Using an unwind hint is problematic due to x86-64's dynamic alignmen= t. > + */ > + mov %_ASM_BP, %_ASM_SP > + pop %_ASM_BP > +.endm > + > #ifdef CONFIG_X86_FRED > .macro VMX_DO_FRED_EVENT_IRQOFF branch_insn branch_target nmi=3D0 > - /* > - * Unconditionally create a stack frame, getting the correct RSP on the > - * stack (for x86-64) would take two instructions anyways, and RBP can > - * be used to restore RSP to make objtool happy (see below). > - */ > - push %_ASM_BP > - mov %_ASM_SP, %_ASM_BP > + VMX_DO_EVENT_FRAME_BEGIN >=20 > /* > * Don't check the FRED stack level, the call stack leading to this > @@ -78,43 +93,23 @@ > * push an error code before invoking the IRQ/NMI handler. > * > * Use LEA to get the return RIP and push it, then push an error code. > + * Note, only NMI handling does an ERETS to the target! IRQ handling > + * doesn't need to unmask NMIs and so simply uses CALL+RET, i.e. the > + * RIP pushed here is only truly consumed for NMIs! > */ > lea 1f(%rip), %rax > push %rax > push $0 /* FRED error code, 0 for NMI and external > interrupts */ >=20 > - .if \nmi =3D=3D 0 > - PUSH_REGS > - mov %rsp, %rdi > - .endif > - > \branch_insn \branch_target > - > - .if \nmi =3D=3D 0 > - POP_REGS > - .endif > - > 1: > - /* > - * "Restore" RSP from RBP, even though IRET has already unwound RSP to > - * the correct value. objtool doesn't know the callee will IRET and, > - * without the explicit restore, thinks the stack is getting walloped. > - * Using an unwind hint is problematic due to x86-64's dynamic alignmen= t. > - */ > - mov %_ASM_BP, %_ASM_SP > - pop %_ASM_BP > + VMX_DO_EVENT_FRAME_END > RET > .endm > #endif >=20 > .macro VMX_DO_EVENT_IRQOFF call_insn call_target > - /* > - * Unconditionally create a stack frame, getting the correct RSP on the > - * stack (for x86-64) would take two instructions anyways, and RBP can > - * be used to restore RSP to make objtool happy (see below). > - */ > - push %_ASM_BP > - mov %_ASM_SP, %_ASM_BP > + VMX_DO_EVENT_FRAME_BEGIN >=20 > #ifdef CONFIG_X86_64 > /* > @@ -129,14 +124,7 @@ > push $__KERNEL_CS > \call_insn \call_target >=20 > - /* > - * "Restore" RSP from RBP, even though IRET has already unwound RSP to > - * the correct value. objtool doesn't know the callee will IRET and, > - * without the explicit restore, thinks the stack is getting walloped. > - * Using an unwind hint is problematic due to x86-64's dynamic alignmen= t. > - */ > - mov %_ASM_BP, %_ASM_SP > - pop %_ASM_BP > + VMX_DO_EVENT_FRAME_END > RET > .endm >=20 > @@ -375,11 +363,13 @@ SYM_INNER_LABEL_ALIGN(vmx_vmexit, > SYM_L_GLOBAL) >=20 > SYM_FUNC_END(__vmx_vcpu_run) >=20 > -#ifdef CONFIG_X86_FRED > SYM_FUNC_START(vmx_do_fred_nmi_irqoff) > +#ifdef CONFIG_X86_FRED > VMX_DO_FRED_EVENT_IRQOFF jmp fred_entrypoint_kernel nmi=3D1 > +#else > + ud2 > +#endif > SYM_FUNC_END(vmx_do_fred_nmi_irqoff) > -#endif >=20 > SYM_FUNC_START(vmx_do_nmi_irqoff) > VMX_DO_EVENT_IRQOFF call asm_exc_nmi_kvm_vmx > @@ -438,11 +428,13 @@ SYM_FUNC_END(vmread_error_trampoline) > #endif >=20 > .section .text, "ax" > -#ifdef CONFIG_X86_FRED > SYM_FUNC_START(vmx_do_fred_interrupt_irqoff) > - VMX_DO_FRED_EVENT_IRQOFF call external_interrupt > +#ifdef CONFIG_X86_FRED > + VMX_DO_FRED_EVENT_IRQOFF call fred_irq_entry_from_kvm > +#else > + ud2 > +#endif > SYM_FUNC_END(vmx_do_fred_interrupt_irqoff) > -#endif >=20 > SYM_FUNC_START(vmx_do_interrupt_irqoff) > VMX_DO_EVENT_IRQOFF CALL_NOSPEC _ASM_ARG1 > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index bf757f5071e4..cb4675dd87df 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -6919,13 +6919,8 @@ static void vmx_apicv_post_state_restore(struct > kvm_vcpu *vcpu) > memset(vmx->pi_desc.pir, 0, sizeof(vmx->pi_desc.pir)); > } >=20 > -#ifdef CONFIG_X86_FRED > void vmx_do_fred_interrupt_irqoff(unsigned int vector); > void vmx_do_fred_nmi_irqoff(unsigned int vector); > -#else > -#define vmx_do_fred_interrupt_irqoff(x) BUG() > -#define vmx_do_fred_nmi_irqoff(x) BUG() > -#endif >=20 > void vmx_do_interrupt_irqoff(unsigned long entry); > void vmx_do_nmi_irqoff(void); > @@ -6976,7 +6971,7 @@ static void handle_external_interrupt_irqoff(struct > kvm_vcpu *vcpu) >=20 > kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); > if (cpu_feature_enabled(X86_FEATURE_FRED)) > - vmx_do_fred_interrupt_irqoff(vector); /* Event type is 0 */ > + vmx_do_fred_interrupt_irqoff((EVENT_TYPE_HWINT << 16) | > vector); > else > vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base > + vector)); > kvm_after_interrupt(vcpu); >=20 > base-commit: 8961078ffe509a97ec7803b17912e57c47b93fa2 > -- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:05:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:05:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574602.900019 (Exim 4.92) (envelope-from ) id 1qQzMn-0001Fq-0o; Wed, 02 Aug 2023 00:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574602.900019; Wed, 02 Aug 2023 00:05:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzMm-0001Fj-UN; Wed, 02 Aug 2023 00:05:28 +0000 Received: by outflank-mailman (input) for mailman id 574602; Wed, 02 Aug 2023 00:05:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzMl-0001Fc-CE for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:05:27 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46ba67e0-30c8-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 02:05:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E60415C01A1; Tue, 1 Aug 2023 20:05:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 01 Aug 2023 20:05:22 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Aug 2023 20:05:21 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46ba67e0-30c8-11ee-b25c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690934722; x=1691021122; bh=8WhJYcgNJo9vOQ4evmBwmKMCj1RPcplmZPN dqAmCGbA=; b=rWeCAnaHP0g+ajeAOTMXYz8UMeMBmxdmVtiVHopEaJlJLCoLn+m SEn6QQAfooD5KXe6+nl7kveQdsqG123O2LlzUNi25QyaK9A1QUBrj0+zTirpGf90 fAFfVvdBRN8TQc726N0/hMmjNsHuqtkzEjC7r3XQvmFPv4CtJYsTDuMBaYgBo0Jg iYzGUWMP8Okm2RFxHUo3OOcazeuDdBqIqIjUsc3fcITU027QPgDSDD5KrP7/uJi7 nd/GP79I4SZJh2J87Gli9f3WTFrpFu7x1NMuo7VH8y4IFGD54mSXaR8h0Ze8Et6F cKq1LVrzys9BJXQexCNre7yzhj0w2j4q1xQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690934722; x=1691021122; bh=8WhJYcgNJo9vO Q4evmBwmKMCj1RPcplmZPNdqAmCGbA=; b=cMaJEJmSX28+T/QKK4/OwvCzykGzG 2u4kd8MUF02ue71pT2Y2i4Xxd1VP+jsIW9pK+uGMXd9jV/1ushTaWgANcaR7ER0f iCkCd3GUhhswZXPK5utlM4/qOKa+VggAdxRNYlwNqsRgmAkkpbCSl8CosvY/0OpU PXY+bej3OKPBisjmIPRTereYmF3pC3qTmuKplxxCT5EYcNoO3UcVkW0tUPDb8tOh HKZnr1nwciQOIDVRxnLmWvaJ7RvIrtJTYqV2wFLCqaIS2IVSdaMInKP3+yk4SUoP zXz9fRAy1xJlYMKCSGt8XDoukCWwI72zWapSzZWWhjGgm/ximBjvgdUKQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeejgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeevueej teegleelteduueevhfetgfffjeevtddvgfeiveehteehleegueelvdejveenucffohhmrg hinhepghhithhlrggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 2 Aug 2023 02:05:17 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Stefano Stabellini Cc: Simone Ballarin , xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein Subject: Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines Message-ID: References: <76f3cdddcba485e8124659566b2f992b3b14da17.1690881495.git.simone.ballarin@bugseng.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+YnZtu0Gyqk33/ME" Content-Disposition: inline In-Reply-To: --+YnZtu0Gyqk33/ME Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 2 Aug 2023 02:05:17 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Stefano Stabellini Cc: Simone Ballarin , xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein Subject: Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines On Tue, Aug 01, 2023 at 03:55:20PM -0700, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Simone Ballarin wrote: > > This patch introduces six new ECLAIR jobs that run only > > when triggered by a GitLab scheduled pipeline. > >=20 > > Signed-off-by: Simone Ballarin > > --- > > +.eclair-analysis:on-schedule: > > + extends: .eclair-analysis > > + rules: > > + - if: $CI_PIPELINE_SOURCE =3D=3D "schedule" >=20 > If I understand this right, the idea is that someone would schedule a > pipeline (Build -> "Pipeline Schedules") and as part of that, they would > also define the variable "CI_PIPELINE_SOURCE" to schedule. No, this is pre-defined variable in gitlab: https://docs.gitlab.com/ee/ci/variables/predefined_variables.html >=20 > Is that correct? >=20 > If so, please add a good in-code comments here on top of > .eclair-analysis:on-schedule to explain it. So that someone reading this > might know how what to do with the Gitlab CI settings. >=20 --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --+YnZtu0Gyqk33/ME Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmTJnb4ACgkQ24/THMrX 1yz9rgf+M38/Y0SWqKAwhTVqJNOx6NknckOsDs5c2DtB5GMozpVPF+15a8FA/ZO0 MWz8BF9c/KUfhIxPY9PvDkkRNM/q+xslNUUrR1K2eEfoUvgMLyHQ4cC6YPIb7RHb v1DKUIOqmKnzGMFAKUAmlZY0l+cmx6AVN4iJ3otAVvYOC2ZDPdP5kCW17H4PUpEK qJg44jeb6RVVrUaBLCBMLlBCVRoMVImhDP8RcfiUUmXg83c6h7g3lvhsUCRcDrSw GP+Dk6qAl4UilnJ14F2ysepNv9gE9I+GZ7MdjGuGT2YUMFBLyPQM0QrLjYo50ICC kZLSs1Tn6jxLy3BErX4/X5TjccaOog== =CZVL -----END PGP SIGNATURE----- --+YnZtu0Gyqk33/ME-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:09:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:09:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574606.900031 (Exim 4.92) (envelope-from ) id 1qQzQI-0001pv-JF; Wed, 02 Aug 2023 00:09:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574606.900031; Wed, 02 Aug 2023 00:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzQI-0001po-EQ; Wed, 02 Aug 2023 00:09:06 +0000 Received: by outflank-mailman (input) for mailman id 574606; Wed, 02 Aug 2023 00:09:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzQH-0001pg-Iw for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:09:05 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c93d1eb4-30c8-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 02:09:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9152D6176B; Wed, 2 Aug 2023 00:09:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3689EC433C8; Wed, 2 Aug 2023 00:09:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c93d1eb4-30c8-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690934941; bh=roaBjhdPe5cHaDSRDczjRWCxieCCrBLzaiLSjYR+7Kg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=QuBnPiMJzQv/hmQELFgBH0DASMeTOtQXkdaSAJToCtKpswiD86kHqPkp6XKff5SQu haAMhb93r4yFJqiGr/6hdN0+4vSi0mAJtCBQ9AhgntsaaZFWJSSLOLAVXaTsJKfNMo jCCzM5rL7CQPNRkJpbEs+XtOPntlsHr5JfOfQGPNW2aTld3zstjOti3qHsMzw3DjxE pVfgXObLhUXor6ZDGVTu4MqXBa+FSyBJk2agA0IwnFoTBfU5Z0U3HCYkgbgplT1SN/ a92jZNnmXn4I2tXKyWOSz3CVbV2zJtZHCYxdrFgadR+6/VByLiLQYa8ZX+/Sh9iOZS jzw3RgA8PqeDA== Date: Tue, 1 Aug 2023 17:08:58 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= cc: Stefano Stabellini , Simone Ballarin , xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein Subject: Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines In-Reply-To: Message-ID: References: <76f3cdddcba485e8124659566b2f992b3b14da17.1690881495.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1622732373-1690934941=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1622732373-1690934941=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 2 Aug 2023, Marek Marczykowski-GĂ³recki wrote: > On Tue, Aug 01, 2023 at 03:55:20PM -0700, Stefano Stabellini wrote: > > On Tue, 1 Aug 2023, Simone Ballarin wrote: > > > This patch introduces six new ECLAIR jobs that run only > > > when triggered by a GitLab scheduled pipeline. > > > > > > Signed-off-by: Simone Ballarin > > > --- > > > +.eclair-analysis:on-schedule: > > > + extends: .eclair-analysis > > > + rules: > > > + - if: $CI_PIPELINE_SOURCE == "schedule" > > > > If I understand this right, the idea is that someone would schedule a > > pipeline (Build -> "Pipeline Schedules") and as part of that, they would > > also define the variable "CI_PIPELINE_SOURCE" to schedule. > > No, this is pre-defined variable in gitlab: > https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Even better! Thanks! Then no need for a comment and the patch is OK as is. Reviewed-by: Stefano Stabellini --8323329-1622732373-1690934941=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574612.900057 (Exim 4.92) (envelope-from ) id 1qQzSk-0003Ym-MM; Wed, 02 Aug 2023 00:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574612.900057; Wed, 02 Aug 2023 00:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSk-0003YO-E1; Wed, 02 Aug 2023 00:11:38 +0000 Received: by outflank-mailman (input) for mailman id 574612; Wed, 02 Aug 2023 00:11:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSj-0003Fo-4K for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:11:37 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23bf799c-30c9-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 02:11:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id E16608285393; Tue, 1 Aug 2023 19:11:33 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jmLuI6QSiIjo; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id AE9DD82865A8; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ksnYdg15_S0P; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 074B282860C6; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23bf799c-30c9-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com AE9DD82865A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690935092; bh=O7tKNlbYGTBKU34+OS6G3eEZ3bNtT5+tgy+g2otdYhY=; h=From:To:Date:Message-Id:MIME-Version; b=V/3EqYNrKKtMm/16ssB2zqoK89/dcxqBADN4KXTDJAOOLV73GByo4nUzisq/nL/ym kb1QDaOsd6x972vpY6m4Zb9QwcyMKV5hTFpwdzGgDnLZHJQUAHMVON1DXPuIlQnjBZ 1G8boDVthyNjJDi5p3dcMydwTS27PAu5xnnuEq4M= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 3/4] xen/ppc: Parse device tree for OPAL node on PowerNV Date: Tue, 1 Aug 2023 19:11:05 -0500 Message-Id: <7026e54897e360d935d065c7ec904dc3f6082857.1690934409.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Communication with firmware boot services on PowerNV requires parsing the fdt blob passed by the bootloader in order to obtain the firmware entrypoint. Use Xen's libfdt to do this and store the information required for firmware calls, to be implemented in a future patch. The full xen/common build doesn't yet work, but libfdt and its xen/lib dependency can be made to build by defining a few stub headers. Signed-off-by: Shawn Anastasio --- Changed in v2: - Remove ALL_LIBS-y override xen/arch/ppc/Kconfig | 1 + xen/arch/ppc/Makefile | 1 + xen/arch/ppc/arch.mk | 3 +- xen/arch/ppc/include/asm/boot.h | 16 +++++++++- xen/arch/ppc/include/asm/bug.h | 18 +++++++++++ xen/arch/ppc/include/asm/cache.h | 6 ++++ xen/arch/ppc/include/asm/processor.h | 13 +++++++- xen/arch/ppc/include/asm/string.h | 6 ++++ xen/arch/ppc/include/asm/system.h | 6 ++++ xen/arch/ppc/opal.c | 48 ++++++++++++++++++++++++++++ xen/arch/ppc/setup.c | 9 ++++-- 11 files changed, 121 insertions(+), 6 deletions(-) create mode 100644 xen/arch/ppc/include/asm/bug.h create mode 100644 xen/arch/ppc/include/asm/cache.h create mode 100644 xen/arch/ppc/include/asm/string.h create mode 100644 xen/arch/ppc/include/asm/system.h create mode 100644 xen/arch/ppc/opal.c diff --git a/xen/arch/ppc/Kconfig b/xen/arch/ppc/Kconfig index a2ade2ecf4..b32dce39b8 100644 --- a/xen/arch/ppc/Kconfig +++ b/xen/arch/ppc/Kconfig @@ -1,5 +1,6 @@ config PPC def_bool y + select HAS_DEVICE_TREE config PPC64 def_bool y diff --git a/xen/arch/ppc/Makefile b/xen/arch/ppc/Makefile index 098a4dd0a9..0c0a7884a1 100644 --- a/xen/arch/ppc/Makefile +++ b/xen/arch/ppc/Makefile @@ -2,6 +2,7 @@ obj-$(CONFIG_PPC64) +=3D ppc64/ obj-y +=3D boot-of.init.o obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.init.o +obj-y +=3D opal.o obj-y +=3D setup.o $(TARGET): $(TARGET)-syms diff --git a/xen/arch/ppc/arch.mk b/xen/arch/ppc/arch.mk index 0183b9ac6a..3bf79bac37 100644 --- a/xen/arch/ppc/arch.mk +++ b/xen/arch/ppc/arch.mk @@ -10,5 +10,4 @@ CFLAGS +=3D -mstrict-align -mcmodel=3Dmedium -mabi=3Del= fv2 -fPIC -mno-altivec -mno-vsx LDFLAGS +=3D -m elf64lppc # TODO: Drop override when more of the build is working -override ALL_OBJS-y =3D arch/$(SRCARCH)/built_in.o -override ALL_LIBS-y =3D +override ALL_OBJS-y =3D arch/$(SRCARCH)/built_in.o common/libfdt/built_i= n.o lib/built_in.o diff --git a/xen/arch/ppc/include/asm/boot.h b/xen/arch/ppc/include/asm/b= oot.h index 9b8a7c43c2..296539cd9e 100644 --- a/xen/arch/ppc/include/asm/boot.h +++ b/xen/arch/ppc/include/asm/boot.h @@ -4,7 +4,10 @@ #include -/* a collection of interfaces used during boot. */ +/* + * OpenFirmware boot interfaces + */ + enum { OF_FAILURE =3D -1, OF_SUCCESS =3D 0, @@ -20,4 +23,15 @@ struct of_service { int enter_of(struct of_service *args, unsigned long entry); void boot_of_init(unsigned long vec); +/* + * OPAL boot interfaces + */ + +struct opal { + uint64_t base; + uint64_t entry; +}; + +void boot_opal_init(const void *fdt); + #endif /* _ASM_PPC_BOOT_H */ diff --git a/xen/arch/ppc/include/asm/bug.h b/xen/arch/ppc/include/asm/bu= g.h new file mode 100644 index 0000000000..e5e874b31c --- /dev/null +++ b/xen/arch/ppc/include/asm/bug.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _ASM_PPC_BUG_H +#define _ASM_PPC_BUG_H + +#include + +/* + * Power ISA guarantees that an instruction consisting of all zeroes is + * illegal. + */ +#define BUG_OPCODE 0x00000000 + +#define BUG_INSTR ".long " __stringify(BUG_OPCODE) + +#define BUG_FN_REG r0 + +#endif /* _ASM_PPC_BUG_H */ diff --git a/xen/arch/ppc/include/asm/cache.h b/xen/arch/ppc/include/asm/= cache.h new file mode 100644 index 0000000000..8a0a6b7b17 --- /dev/null +++ b/xen/arch/ppc/include/asm/cache.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _ASM_PPC_CACHE_H +#define _ASM_PPC_CACHE_H + +#endif /* _ASM_PPC_CACHE_H */ diff --git a/xen/arch/ppc/include/asm/processor.h b/xen/arch/ppc/include/= asm/processor.h index 838d279508..2300640787 100644 --- a/xen/arch/ppc/include/asm/processor.h +++ b/xen/arch/ppc/include/asm/processor.h @@ -133,6 +133,17 @@ struct cpu_user_regs uint32_t entry_vector; }; -#endif +/* + * panic() isn't available at the moment so an infinite loop will be + * used temporarily. + * TODO: change it to panic() + */ +static inline void noreturn die(void) +{ + for ( ; ; ) + HMT_very_low(); +} + +#endif /* __ASSEMBLY__ */ #endif /* _ASM_PPC_PROCESSOR_H */ diff --git a/xen/arch/ppc/include/asm/string.h b/xen/arch/ppc/include/asm= /string.h new file mode 100644 index 0000000000..7a420e05e4 --- /dev/null +++ b/xen/arch/ppc/include/asm/string.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _ASM_PPC_STRING_H +#define _ASM_PPC_STRING_H + +#endif /* _ASM_PPC_STRING_H */ diff --git a/xen/arch/ppc/include/asm/system.h b/xen/arch/ppc/include/asm= /system.h new file mode 100644 index 0000000000..94091df644 --- /dev/null +++ b/xen/arch/ppc/include/asm/system.h @@ -0,0 +1,6 @@ +#ifndef _ASM_SYSTEM_H_ +#define _ASM_SYSTEM_H_ + +#define smp_wmb() __asm__ __volatile__ ( "lwsync" : : : "memory" ) + +#endif /* _ASM_SYSTEM_H */ diff --git a/xen/arch/ppc/opal.c b/xen/arch/ppc/opal.c new file mode 100644 index 0000000000..251de8ac23 --- /dev/null +++ b/xen/arch/ppc/opal.c @@ -0,0 +1,48 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include +#include +#include +#include +#include +#include +#include +#include + +/* Global OPAL struct containing entrypoint and base */ +struct opal opal; + +void __init boot_opal_init(const void *fdt) +{ + int opal_node; + const __be64 *opal_base; + const __be64 *opal_entry; + + if ( fdt_check_header(fdt) < 0 ) + { + /* + * NOTE: This won't actually print since the early serial + * console isn't set up yet. + */ + early_printk("Booted without valid FDT pointer in r3!\n"); + die(); + } + + opal_node =3D fdt_path_offset(fdt, "/ibm,opal"); + if ( opal_node < 0 ) + { + early_printk("Unable to find ibm,opal node!\n"); + die(); + } + + opal_base =3D fdt_getprop(fdt, opal_node, "opal-base-address", NULL)= ; + opal_entry =3D fdt_getprop(fdt, opal_node, "opal-entry-address", NUL= L); + if ( !opal_base || !opal_entry ) + { + early_printk("Failed to get opal-base-address/opal-entry-address= " + "property from DT!\n"); + die(); + } + + opal.base =3D be64_to_cpu(*opal_base); + opal.entry =3D be64_to_cpu(*opal_entry); +} diff --git a/xen/arch/ppc/setup.c b/xen/arch/ppc/setup.c index 7c623a49f5..bacd6d1acd 100644 --- a/xen/arch/ppc/setup.c +++ b/xen/arch/ppc/setup.c @@ -18,8 +18,13 @@ void __init noreturn start_xen(unsigned long r3, unsig= ned long r4, } else { - /* kexec boot: Unimplemented */ - __builtin_trap(); + /* + * kexec boot protocol + * + * TODO: This currently assumes an OPAL/PowerNV system, but it's= also + * possible to be kexec'd on an OF system. + */ + boot_opal_init((void *) r3); } early_printk("Hello, ppc64le!\n"); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574613.900065 (Exim 4.92) (envelope-from ) id 1qQzSl-0003kg-7D; Wed, 02 Aug 2023 00:11:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574613.900065; Wed, 02 Aug 2023 00:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSk-0003iW-VB; Wed, 02 Aug 2023 00:11:38 +0000 Received: by outflank-mailman (input) for mailman id 574613; Wed, 02 Aug 2023 00:11:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSj-0003Fo-P8 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:11:37 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 24068f59-30c9-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 02:11:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 54EA182860C6; Tue, 1 Aug 2023 19:11:34 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GKvhWNa3NfSJ; Tue, 1 Aug 2023 19:11:33 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 3B72F8285BEB; Tue, 1 Aug 2023 19:11:33 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BCZX--nrtIun; Tue, 1 Aug 2023 19:11:33 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 97F828285393; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24068f59-30c9-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 3B72F8285BEB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690935093; bh=p+DRgSuWZDmGJuetNvOOlJpomr6S/4OpH3mhhUD04Oc=; h=From:To:Date:Message-Id:MIME-Version; b=hLhwH/nuDNpwfiyDhZcTAm0Rx0PElf7t3DcFyDabxTjHA/oDjkia+tbjrJt+zcC77 vsd6dLUJX2PxCYZFFWIHCSgxGtCFAHhw0P86vBOHkfO+vsYEHeo2rxdzFhNwYaKgPi tB3cWgcs/ZPtmNHgDrBiBo+1AU7XaxNH7ollBkaA= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 4/4] xen/ppc: Implement early serial console on PowerNV Date: Tue, 1 Aug 2023 19:11:06 -0500 Message-Id: <3176762c2eb09d01d65a348e296a94cf0356ff46.1690934409.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Implement the OPAL firmware calls required to write to the serial console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL firmware interface can be used past early boot and as such the relevant functions are not marked as __init. Signed-off-by: Shawn Anastasio --- Changed in v2: - Include asm-offsets in asm-defns.h - Clean up assembly formatting in asm-defns.h - Clean up formatting of opal.c - Clean up stray semicolon in OPAL_CALL macro in opal-calls.S xen/arch/ppc/include/asm/asm-defns.h | 18 ++++++- xen/arch/ppc/opal.c | 28 +++++++++- xen/arch/ppc/ppc64/Makefile | 1 + xen/arch/ppc/ppc64/asm-offsets.c | 4 ++ xen/arch/ppc/ppc64/opal-calls.S | 81 ++++++++++++++++++++++++++++ 5 files changed, 129 insertions(+), 3 deletions(-) create mode 100644 xen/arch/ppc/ppc64/opal-calls.S diff --git a/xen/arch/ppc/include/asm/asm-defns.h b/xen/arch/ppc/include/= asm/asm-defns.h index 5821f9024d..f1c49808bd 100644 --- a/xen/arch/ppc/include/asm/asm-defns.h +++ b/xen/arch/ppc/include/asm/asm-defns.h @@ -2,6 +2,8 @@ #ifndef _ASM_PPC_ASM_DEFNS_H #define _ASM_PPC_ASM_DEFNS_H +#include + /* * Load a 64-bit immediate value into the specified GPR. */ @@ -20,8 +22,20 @@ * Load the address of a symbol from the TOC into the specified GPR. */ #define LOAD_REG_ADDR(reg,name) = \ - addis reg,%r2,name@toc@ha; = \ - addi reg,reg,name@toc@l + addis reg, %r2, name@toc@ha; = \ + addi reg, reg, name@toc@l + +/* + * Declare a global assembly function with a proper TOC setup prologue + */ +#define _GLOBAL_TOC(name) = \ + .balign 4; = \ + .type name, @function; = \ + .globl name; = \ +name: = \ +0: addis %r2, %r12, (.TOC.-0b)@ha; = \ + addi %r2, %r2, (.TOC.-0b)@l; = \ + .localentry name, .-name /* * Depending on how we were booted, the CPU could be running in either diff --git a/xen/arch/ppc/opal.c b/xen/arch/ppc/opal.c index 251de8ac23..1183b7d5ef 100644 --- a/xen/arch/ppc/opal.c +++ b/xen/arch/ppc/opal.c @@ -8,9 +8,29 @@ #include #include -/* Global OPAL struct containing entrypoint and base */ +/* Global OPAL struct containing entrypoint and base used by opal-calls.= S */ struct opal opal; +int64_t opal_console_write(int64_t term_number, uint64_t *length, + const void *buffer); +int64_t opal_console_flush(int64_t term_number); +int64_t opal_reinit_cpus(uint64_t flags); + +static void opal_putchar(char c) +{ + uint64_t len; + + if ( c =3D=3D '\n' ) + { + char buf =3D '\r'; + len =3D cpu_to_be64(1); + opal_console_write(0, &len, &buf); + } + len =3D cpu_to_be64(1); + opal_console_write(0, &len, &c); + opal_console_flush(0); +} + void __init boot_opal_init(const void *fdt) { int opal_node; @@ -45,4 +65,10 @@ void __init boot_opal_init(const void *fdt) opal.base =3D be64_to_cpu(*opal_base); opal.entry =3D be64_to_cpu(*opal_entry); + + early_printk_init(opal_putchar); + + /* Ask OPAL to set HID0 for Little Endian interrupts + Radix TLB sup= port */ + opal_reinit_cpus(OPAL_REINIT_CPUS_HILE_LE | OPAL_REINIT_CPUS_MMU_RAD= IX | + OPAL_REINIT_CPUS_MMU_HASH); } diff --git a/xen/arch/ppc/ppc64/Makefile b/xen/arch/ppc/ppc64/Makefile index f4956daaa9..b9a91dc15f 100644 --- a/xen/arch/ppc/ppc64/Makefile +++ b/xen/arch/ppc/ppc64/Makefile @@ -1,2 +1,3 @@ obj-y +=3D head.o obj-y +=3D of-call.o +obj-y +=3D opal-calls.o diff --git a/xen/arch/ppc/ppc64/asm-offsets.c b/xen/arch/ppc/ppc64/asm-of= fsets.c index e1129cb0f4..c15c1bf136 100644 --- a/xen/arch/ppc/ppc64/asm-offsets.c +++ b/xen/arch/ppc/ppc64/asm-offsets.c @@ -6,6 +6,7 @@ #include #include +#include #define DEFINE(_sym, _val) = \ asm volatile ( "\n.ascii\"=3D=3D>#define " #_sym " %0 /* " #_val " *= /<=3D=3D\"" \ @@ -46,6 +47,9 @@ void __dummy__(void) OFFSET(UREGS_cr, struct cpu_user_regs, cr); OFFSET(UREGS_fpscr, struct cpu_user_regs, fpscr); DEFINE(UREGS_sizeof, sizeof(struct cpu_user_regs)); + + OFFSET(OPAL_base, struct opal, base); + OFFSET(OPAL_entry, struct opal, entry); } /* diff --git a/xen/arch/ppc/ppc64/opal-calls.S b/xen/arch/ppc/ppc64/opal-ca= lls.S new file mode 100644 index 0000000000..cc5de75c8a --- /dev/null +++ b/xen/arch/ppc/ppc64/opal-calls.S @@ -0,0 +1,81 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Adapted from Linux's arch/powerpc/boot/opal-calls.S + * + * Copyright (c) 2016 IBM Corporation. + * Copyright Raptor Engineering, LLC + */ + +#include +#include +#include + + .text + +#define OPAL_CALL(name, token) \ + .globl name; \ +name: \ + li %r0, token; \ + b opal_call + + _GLOBAL_TOC(opal_call) + /* Back up LR, CR, r2 in caller's stack frame */ + mflr %r11 + mfcr %r12 + std %r2, 24(%r1) + std %r11, 16(%r1) + stw %r12, 8(%r1) + + /* Use r14 (non-volatile) to store the virtual address of opal_retur= n_mmu */ + std %r14, -8(%r1) + stdu %r1, -48(%r1) + LOAD_REG_ADDR(%r14, opal_return_mmu) + + /* + * Setup new MSR without LE or MMU. Original MSR will be preserved a= cross + * opal call in r13 + */ + mfmsr %r13 + li %r11, MSR_LE | MSR_IR | MSR_DR + andc %r12, %r13, %r11 + mthsrr1 %r12 + + LOAD_REG_ADDR(%r11, opal_return_real) + mtlr %r11 + + /* Load the opal call entry point and base */ + LOAD_REG_ADDR(%r11, opal) + ld %r12, OPAL_entry(%r11) + ld %r2, OPAL_base(%r11) + mthsrr0 %r12 + hrfid + +opal_return_real: + /* + * OPAL will always return to us in Big Endian mode. Since we are go= ing + * to restore the old MSR with the correct endianness and MMU status= set, we + * can avoid an unnecessary FIXUP_ENDIAN trampoline by just encoding= the + * required Big Endian instructions to restore the old MSR direclty. + */ + .long 0xa64bbb7d /* mthsrr1 %r13 (Old MSR) */ + .long 0xa64bda7d /* mthsrr0 %r14 (Virtual address of opal_return_mmu= ) */ + .long 0x2402004c /* hrfid */ + +opal_return_mmu: + /* + * We're back in the correct endianness and MMU mode, restore regist= ers + * and return + */ + addi %r1, %r1, 48 + ld %r14, -8(%r1) + lwz %r11, 8(%r1) + ld %r12, 16(%r1) + ld %r2, 24(%r1) + mtcr %r11 + mtlr %r12 + + blr + +OPAL_CALL(opal_console_write, OPAL_CONSOLE_WRITE) +OPAL_CALL(opal_console_flush, OPAL_CONSOLE_FLUSH) +OPAL_CALL(opal_reinit_cpus, OPAL_REINIT_CPUS) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574611.900049 (Exim 4.92) (envelope-from ) id 1qQzSk-0003Us-5j; Wed, 02 Aug 2023 00:11:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574611.900049; Wed, 02 Aug 2023 00:11:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSk-0003Ul-2k; Wed, 02 Aug 2023 00:11:38 +0000 Received: by outflank-mailman (input) for mailman id 574611; Wed, 02 Aug 2023 00:11:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSi-0003Fc-79 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:11:36 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23034186-30c9-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 02:11:33 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id A538B828574A; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DUQIxQ5pEZEn; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 6DE398284EB7; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sEqQJTs6SKw6; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 171CE8285491; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23034186-30c9-11ee-b25c-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 6DE398284EB7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690935091; bh=evTmLh29uUc24NiflnIA1Cij5ypJhBmERpFc9O8S3xI=; h=From:To:Date:Message-Id:MIME-Version; b=caEcdTwlQbhKy8QLdyCBbZLRGtqRv7YaDeFXDJlJ/YnRhdU+LjpFDhvYX39D2fITo +/+2mJi8jWHC/e2o3lbo1oBy4Gvo/xgTPWZEXEMWRxGiyJu/Z+njG+jhxuzBzZ4kQD IqG8pvweAKvZ1FBcDIwqUScYaiZdHMPcaaYYiXiM= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 1/4] xen/ppc: Switch to medium PIC code model Date: Tue, 1 Aug 2023 19:11:03 -0500 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Switch Xen to the medium PIC code model on Power. Among other things, this allows us to be load address agnostic and will open the door to booting on bare metal PowerNV systems that don't use OpenFirmware. Also update XEN_VIRT_START to 0xc000000000000000, which is equivalent to address 0x0 when the MMU is off. This prevents Open Firmware from loading Xen at an offset from its base load address, so the DECL_SECTION hack in xen.lds.S is no longer required. Signed-off-by: Shawn Anastasio --- Changed in v2: - Remove stray newline - Use label instead of .+4 in TOC setup branch xen/arch/ppc/arch.mk | 2 +- xen/arch/ppc/include/asm/asm-defns.h | 7 +++++ xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/ppc64/head.S | 12 +++++--- xen/arch/ppc/xen.lds.S | 44 ++++++++++------------------ 5 files changed, 33 insertions(+), 34 deletions(-) diff --git a/xen/arch/ppc/arch.mk b/xen/arch/ppc/arch.mk index 7eec22c283..0183b9ac6a 100644 --- a/xen/arch/ppc/arch.mk +++ b/xen/arch/ppc/arch.mk @@ -5,7 +5,7 @@ ppc-march-$(CONFIG_POWER_ISA_2_07B) :=3D power8 ppc-march-$(CONFIG_POWER_ISA_3_00) :=3D power9 CFLAGS +=3D -m64 -mlittle-endian -mcpu=3D$(ppc-march-y) -CFLAGS +=3D -mstrict-align -mcmodel=3Dlarge -mabi=3Delfv2 -mno-altivec -= mno-vsx +CFLAGS +=3D -mstrict-align -mcmodel=3Dmedium -mabi=3Delfv2 -fPIC -mno-al= tivec -mno-vsx -msoft-float LDFLAGS +=3D -m elf64lppc diff --git a/xen/arch/ppc/include/asm/asm-defns.h b/xen/arch/ppc/include/= asm/asm-defns.h index 35b1c89d4e..5821f9024d 100644 --- a/xen/arch/ppc/include/asm/asm-defns.h +++ b/xen/arch/ppc/include/asm/asm-defns.h @@ -16,6 +16,13 @@ lis reg, (val) @h; = \ ori reg, reg, (val) @l; = \ +/* + * Load the address of a symbol from the TOC into the specified GPR. + */ +#define LOAD_REG_ADDR(reg,name) = \ + addis reg,%r2,name@toc@ha; = \ + addi reg,reg,name@toc@l + /* * Depending on how we were booted, the CPU could be running in either * Little Endian or Big Endian mode. The following trampoline from Linux diff --git a/xen/arch/ppc/include/asm/config.h b/xen/arch/ppc/include/asm= /config.h index cb27d2781e..d060f0dca7 100644 --- a/xen/arch/ppc/include/asm/config.h +++ b/xen/arch/ppc/include/asm/config.h @@ -39,7 +39,7 @@ name: #endif -#define XEN_VIRT_START _AT(UL, 0x400000) +#define XEN_VIRT_START _AT(UL, 0xc000000000000000) #define SMP_CACHE_BYTES (1 << 6) diff --git a/xen/arch/ppc/ppc64/head.S b/xen/arch/ppc/ppc64/head.S index 02ff520458..4172f1b8ec 100644 --- a/xen/arch/ppc/ppc64/head.S +++ b/xen/arch/ppc/ppc64/head.S @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include +#include .section .text.header, "ax", %progbits @@ -11,16 +12,19 @@ ENTRY(start) FIXUP_ENDIAN /* set up the TOC pointer */ - LOAD_IMM32(%r2, .TOC.) + bcl 20, 31, 1f +1: mflr %r12 + addis %r2, %r12, .TOC.-1b@ha + addi %r2, %r2, .TOC.-1b@l /* set up the initial stack */ - LOAD_IMM32(%r1, cpu0_boot_stack) + LOAD_REG_ADDR(%r1, cpu0_boot_stack) li %r11, 0 stdu %r11, -STACK_FRAME_OVERHEAD(%r1) /* clear .bss */ - LOAD_IMM32(%r14, __bss_start) - LOAD_IMM32(%r15, __bss_end) + LOAD_REG_ADDR(%r14, __bss_start) + LOAD_REG_ADDR(%r15, __bss_end) 1: std %r11, 0(%r14) addi %r14, %r14, 8 diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S index c628cc0e5c..2fa81d5a83 100644 --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -15,25 +15,12 @@ PHDRS #endif } -/** - * OpenFirmware's base load address is 0x400000 (XEN_VIRT_START). - * By defining sections this way, we can keep our virtual address base a= t 0x400000 - * while keeping the physical base at 0x0. - * - * Otherwise, OpenFirmware incorrectly loads .text at 0x400000 + 0x40000= 0 =3D 0x800000. - * Taken from x86/xen.lds.S - */ -#ifdef CONFIG_LD_IS_GNU -# define DECL_SECTION(x) x : AT(ADDR(#x) - XEN_VIRT_START) -#else -# define DECL_SECTION(x) x : AT(ADDR(x) - XEN_VIRT_START) -#endif - SECTIONS { . =3D XEN_VIRT_START; + _start =3D .; - DECL_SECTION(.text) { + .text : { _stext =3D .; /* Text section */ *(.text.header) @@ -52,7 +39,7 @@ SECTIONS } :text . =3D ALIGN(PAGE_SIZE); - DECL_SECTION(.rodata) { + .rodata : { _srodata =3D .; /* Read-only data */ *(.rodata) *(.rodata.*) @@ -67,7 +54,7 @@ SECTIONS #if defined(BUILD_ID) . =3D ALIGN(4); - DECL_SECTION(.note.gnu.build-id) { + .note.gnu.build-id : { __note_gnu_build_id_start =3D .; *(.note.gnu.build-id) __note_gnu_build_id_end =3D .; @@ -76,19 +63,19 @@ SECTIONS _erodata =3D .; /* End of read-only data */ . =3D ALIGN(PAGE_SIZE); - DECL_SECTION(.data.ro_after_init) { + .data.ro_after_init : { __ro_after_init_start =3D .; *(.data.ro_after_init) . =3D ALIGN(PAGE_SIZE); __ro_after_init_end =3D .; - } : text + } :text - DECL_SECTION(.data.read_mostly) { + .data.read_mostly : { *(.data.read_mostly) } :text . =3D ALIGN(PAGE_SIZE); - DECL_SECTION(.data) { /* Data */ + .data : { /* Data */ *(.data.page_aligned) . =3D ALIGN(8); __start_schedulers_array =3D .; @@ -103,7 +90,7 @@ SECTIONS . =3D ALIGN(PAGE_SIZE); /* Init code and data */ __init_begin =3D .; - DECL_SECTION(.init.text) { + .init.text : { _sinittext =3D .; *(.init.text) _einittext =3D .; @@ -111,7 +98,7 @@ SECTIONS } :text . =3D ALIGN(PAGE_SIZE); - DECL_SECTION(.init.data) { + .init.data : { *(.init.rodata) *(.init.rodata.*) @@ -140,18 +127,18 @@ SECTIONS __ctors_end =3D .; } :text - DECL_SECTION(.got) { - *(.got) + .got : { + *(.got .toc) } :text - DECL_SECTION(.got.plt) { + .got.plt : { *(.got.plt) } :text . =3D ALIGN(POINTER_ALIGN); __init_end =3D .; - DECL_SECTION(.bss) { /* BSS */ + .bss : { /* BSS */ __bss_start =3D .; *(.bss.stack_aligned) *(.bss.page_aligned) @@ -167,10 +154,11 @@ SECTIONS . =3D ALIGN(POINTER_ALIGN); __bss_end =3D .; } :text + _end =3D . ; /* Section for the device tree blob (if any). */ - DECL_SECTION(.dtb) { *(.dtb) } :text + .dtb : { *(.dtb) } :text DWARF2_DEBUG_SECTIONS -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574614.900069 (Exim 4.92) (envelope-from ) id 1qQzSl-0003sA-GF; Wed, 02 Aug 2023 00:11:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574614.900069; Wed, 02 Aug 2023 00:11:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSl-0003r4-AT; Wed, 02 Aug 2023 00:11:39 +0000 Received: by outflank-mailman (input) for mailman id 574614; Wed, 02 Aug 2023 00:11:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSk-0003Fc-0J for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:11:38 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 24b88c23-30c9-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 02:11:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 80E598285BEB; Tue, 1 Aug 2023 19:11:35 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ytrMOHAsggp4; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 26F8882860D8; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z9G1bl3ezzIu; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 74A98828574A; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24b88c23-30c9-11ee-b25c-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 26F8882860D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690935092; bh=fdyVe894HHgk3h8xSGSF2mcH94BslBHZiYxBadv73ms=; h=From:To:Date:Message-Id:MIME-Version; b=BTcPUHaGK03OzgC5KnVPQsovwzg51MZfMf9h+LWDgW01CWSg6ePWsRoKfsnxlVc24 Ogw7Wg1SGVNuFoayiBSbtFQvVirwRIqr/vjVh+In8IQr6VmY624LiCGGK7RHUDQLSk KmvFLfMpynvU4y4Ta8gvFZDMEi0FmmMD3UraFnR8= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 2/4] xen/ppc: Add OPAL API definition header file Date: Tue, 1 Aug 2023 19:11:04 -0500 Message-Id: <398ef92c0103fbc70f53b26403fa6596ac73ec0c.1690934409.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable OPAL (OpenPower Abstraction Layer) is the interface exposed by firmware on PowerNV (bare metal) systems. Import Linux's header definining the API and related information. >From Linux commit 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc Signed-off-by: Shawn Anastasio --- Changed in v2: - Add Linux commit reference to commit message xen/arch/ppc/include/asm/opal-api.h | 1190 +++++++++++++++++++++++++++ 1 file changed, 1190 insertions(+) create mode 100644 xen/arch/ppc/include/asm/opal-api.h diff --git a/xen/arch/ppc/include/asm/opal-api.h b/xen/arch/ppc/include/a= sm/opal-api.h new file mode 100644 index 0000000000..75100eda83 --- /dev/null +++ b/xen/arch/ppc/include/asm/opal-api.h @@ -0,0 +1,1190 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * OPAL API definitions. + * + * Copyright 2011-2015 IBM Corp. + */ + +#ifndef __OPAL_API_H +#define __OPAL_API_H + +/****** OPAL APIs ******/ + +/* Return codes */ +#define OPAL_SUCCESS 0 +#define OPAL_PARAMETER -1 +#define OPAL_BUSY -2 +#define OPAL_PARTIAL -3 +#define OPAL_CONSTRAINED -4 +#define OPAL_CLOSED -5 +#define OPAL_HARDWARE -6 +#define OPAL_UNSUPPORTED -7 +#define OPAL_PERMISSION -8 +#define OPAL_NO_MEM -9 +#define OPAL_RESOURCE -10 +#define OPAL_INTERNAL_ERROR -11 +#define OPAL_BUSY_EVENT -12 +#define OPAL_HARDWARE_FROZEN -13 +#define OPAL_WRONG_STATE -14 +#define OPAL_ASYNC_COMPLETION -15 +#define OPAL_EMPTY -16 +#define OPAL_I2C_TIMEOUT -17 +#define OPAL_I2C_INVALID_CMD -18 +#define OPAL_I2C_LBUS_PARITY -19 +#define OPAL_I2C_BKEND_OVERRUN -20 +#define OPAL_I2C_BKEND_ACCESS -21 +#define OPAL_I2C_ARBT_LOST -22 +#define OPAL_I2C_NACK_RCVD -23 +#define OPAL_I2C_STOP_ERR -24 +#define OPAL_XIVE_PROVISIONING -31 +#define OPAL_XIVE_FREE_ACTIVE -32 +#define OPAL_TIMEOUT -33 + +/* API Tokens (in r0) */ +#define OPAL_INVALID_CALL -1 +#define OPAL_TEST 0 +#define OPAL_CONSOLE_WRITE 1 +#define OPAL_CONSOLE_READ 2 +#define OPAL_RTC_READ 3 +#define OPAL_RTC_WRITE 4 +#define OPAL_CEC_POWER_DOWN 5 +#define OPAL_CEC_REBOOT 6 +#define OPAL_READ_NVRAM 7 +#define OPAL_WRITE_NVRAM 8 +#define OPAL_HANDLE_INTERRUPT 9 +#define OPAL_POLL_EVENTS 10 +#define OPAL_PCI_SET_HUB_TCE_MEMORY 11 +#define OPAL_PCI_SET_PHB_TCE_MEMORY 12 +#define OPAL_PCI_CONFIG_READ_BYTE 13 +#define OPAL_PCI_CONFIG_READ_HALF_WORD 14 +#define OPAL_PCI_CONFIG_READ_WORD 15 +#define OPAL_PCI_CONFIG_WRITE_BYTE 16 +#define OPAL_PCI_CONFIG_WRITE_HALF_WORD 17 +#define OPAL_PCI_CONFIG_WRITE_WORD 18 +#define OPAL_SET_XIVE 19 +#define OPAL_GET_XIVE 20 +#define OPAL_GET_COMPLETION_TOKEN_STATUS 21 /* obsolete */ +#define OPAL_REGISTER_OPAL_EXCEPTION_HANDLER 22 +#define OPAL_PCI_EEH_FREEZE_STATUS 23 +#define OPAL_PCI_SHPC 24 +#define OPAL_CONSOLE_WRITE_BUFFER_SPACE 25 +#define OPAL_PCI_EEH_FREEZE_CLEAR 26 +#define OPAL_PCI_PHB_MMIO_ENABLE 27 +#define OPAL_PCI_SET_PHB_MEM_WINDOW 28 +#define OPAL_PCI_MAP_PE_MMIO_WINDOW 29 +#define OPAL_PCI_SET_PHB_TABLE_MEMORY 30 +#define OPAL_PCI_SET_PE 31 +#define OPAL_PCI_SET_PELTV 32 +#define OPAL_PCI_SET_MVE 33 +#define OPAL_PCI_SET_MVE_ENABLE 34 +#define OPAL_PCI_GET_XIVE_REISSUE 35 +#define OPAL_PCI_SET_XIVE_REISSUE 36 +#define OPAL_PCI_SET_XIVE_PE 37 +#define OPAL_GET_XIVE_SOURCE 38 +#define OPAL_GET_MSI_32 39 +#define OPAL_GET_MSI_64 40 +#define OPAL_START_CPU 41 +#define OPAL_QUERY_CPU_STATUS 42 +#define OPAL_WRITE_OPPANEL 43 /* unimplemented */ +#define OPAL_PCI_MAP_PE_DMA_WINDOW 44 +#define OPAL_PCI_MAP_PE_DMA_WINDOW_REAL 45 +#define OPAL_PCI_RESET 49 +#define OPAL_PCI_GET_HUB_DIAG_DATA 50 +#define OPAL_PCI_GET_PHB_DIAG_DATA 51 +#define OPAL_PCI_FENCE_PHB 52 +#define OPAL_PCI_REINIT 53 +#define OPAL_PCI_MASK_PE_ERROR 54 +#define OPAL_SET_SLOT_LED_STATUS 55 +#define OPAL_GET_EPOW_STATUS 56 +#define OPAL_SET_SYSTEM_ATTENTION_LED 57 +#define OPAL_RESERVED1 58 +#define OPAL_RESERVED2 59 +#define OPAL_PCI_NEXT_ERROR 60 +#define OPAL_PCI_EEH_FREEZE_STATUS2 61 +#define OPAL_PCI_POLL 62 +#define OPAL_PCI_MSI_EOI 63 +#define OPAL_PCI_GET_PHB_DIAG_DATA2 64 +#define OPAL_XSCOM_READ 65 +#define OPAL_XSCOM_WRITE 66 +#define OPAL_LPC_READ 67 +#define OPAL_LPC_WRITE 68 +#define OPAL_RETURN_CPU 69 +#define OPAL_REINIT_CPUS 70 +#define OPAL_ELOG_READ 71 +#define OPAL_ELOG_WRITE 72 +#define OPAL_ELOG_ACK 73 +#define OPAL_ELOG_RESEND 74 +#define OPAL_ELOG_SIZE 75 +#define OPAL_FLASH_VALIDATE 76 +#define OPAL_FLASH_MANAGE 77 +#define OPAL_FLASH_UPDATE 78 +#define OPAL_RESYNC_TIMEBASE 79 +#define OPAL_CHECK_TOKEN 80 +#define OPAL_DUMP_INIT 81 +#define OPAL_DUMP_INFO 82 +#define OPAL_DUMP_READ 83 +#define OPAL_DUMP_ACK 84 +#define OPAL_GET_MSG 85 +#define OPAL_CHECK_ASYNC_COMPLETION 86 +#define OPAL_SYNC_HOST_REBOOT 87 +#define OPAL_SENSOR_READ 88 +#define OPAL_GET_PARAM 89 +#define OPAL_SET_PARAM 90 +#define OPAL_DUMP_RESEND 91 +#define OPAL_ELOG_SEND 92 /* Deprecated */ +#define OPAL_PCI_SET_PHB_CAPI_MODE 93 +#define OPAL_DUMP_INFO2 94 +#define OPAL_WRITE_OPPANEL_ASYNC 95 +#define OPAL_PCI_ERR_INJECT 96 +#define OPAL_PCI_EEH_FREEZE_SET 97 +#define OPAL_HANDLE_HMI 98 +#define OPAL_CONFIG_CPU_IDLE_STATE 99 +#define OPAL_SLW_SET_REG 100 +#define OPAL_REGISTER_DUMP_REGION 101 +#define OPAL_UNREGISTER_DUMP_REGION 102 +#define OPAL_WRITE_TPO 103 +#define OPAL_READ_TPO 104 +#define OPAL_GET_DPO_STATUS 105 +#define OPAL_OLD_I2C_REQUEST 106 /* Deprecated */ +#define OPAL_IPMI_SEND 107 +#define OPAL_IPMI_RECV 108 +#define OPAL_I2C_REQUEST 109 +#define OPAL_FLASH_READ 110 +#define OPAL_FLASH_WRITE 111 +#define OPAL_FLASH_ERASE 112 +#define OPAL_PRD_MSG 113 +#define OPAL_LEDS_GET_INDICATOR 114 +#define OPAL_LEDS_SET_INDICATOR 115 +#define OPAL_CEC_REBOOT2 116 +#define OPAL_CONSOLE_FLUSH 117 +#define OPAL_GET_DEVICE_TREE 118 +#define OPAL_PCI_GET_PRESENCE_STATE 119 +#define OPAL_PCI_GET_POWER_STATE 120 +#define OPAL_PCI_SET_POWER_STATE 121 +#define OPAL_INT_GET_XIRR 122 +#define OPAL_INT_SET_CPPR 123 +#define OPAL_INT_EOI 124 +#define OPAL_INT_SET_MFRR 125 +#define OPAL_PCI_TCE_KILL 126 +#define OPAL_NMMU_SET_PTCR 127 +#define OPAL_XIVE_RESET 128 +#define OPAL_XIVE_GET_IRQ_INFO 129 +#define OPAL_XIVE_GET_IRQ_CONFIG 130 +#define OPAL_XIVE_SET_IRQ_CONFIG 131 +#define OPAL_XIVE_GET_QUEUE_INFO 132 +#define OPAL_XIVE_SET_QUEUE_INFO 133 +#define OPAL_XIVE_DONATE_PAGE 134 +#define OPAL_XIVE_ALLOCATE_VP_BLOCK 135 +#define OPAL_XIVE_FREE_VP_BLOCK 136 +#define OPAL_XIVE_GET_VP_INFO 137 +#define OPAL_XIVE_SET_VP_INFO 138 +#define OPAL_XIVE_ALLOCATE_IRQ 139 +#define OPAL_XIVE_FREE_IRQ 140 +#define OPAL_XIVE_SYNC 141 +#define OPAL_XIVE_DUMP 142 +#define OPAL_XIVE_GET_QUEUE_STATE 143 +#define OPAL_XIVE_SET_QUEUE_STATE 144 +#define OPAL_SIGNAL_SYSTEM_RESET 145 +#define OPAL_NPU_INIT_CONTEXT 146 +#define OPAL_NPU_DESTROY_CONTEXT 147 +#define OPAL_NPU_MAP_LPAR 148 +#define OPAL_IMC_COUNTERS_INIT 149 +#define OPAL_IMC_COUNTERS_START 150 +#define OPAL_IMC_COUNTERS_STOP 151 +#define OPAL_GET_POWERCAP 152 +#define OPAL_SET_POWERCAP 153 +#define OPAL_GET_POWER_SHIFT_RATIO 154 +#define OPAL_SET_POWER_SHIFT_RATIO 155 +#define OPAL_SENSOR_GROUP_CLEAR 156 +#define OPAL_PCI_SET_P2P 157 +#define OPAL_QUIESCE 158 +#define OPAL_NPU_SPA_SETUP 159 +#define OPAL_NPU_SPA_CLEAR_CACHE 160 +#define OPAL_NPU_TL_SET 161 +#define OPAL_SENSOR_READ_U64 162 +#define OPAL_SENSOR_GROUP_ENABLE 163 +#define OPAL_PCI_GET_PBCQ_TUNNEL_BAR 164 +#define OPAL_PCI_SET_PBCQ_TUNNEL_BAR 165 +#define OPAL_HANDLE_HMI2 166 +#define OPAL_NX_COPROC_INIT 167 +#define OPAL_XIVE_GET_VP_STATE 170 +#define OPAL_MPIPL_UPDATE 173 +#define OPAL_MPIPL_REGISTER_TAG 174 +#define OPAL_MPIPL_QUERY_TAG 175 +#define OPAL_SECVAR_GET 176 +#define OPAL_SECVAR_GET_NEXT 177 +#define OPAL_SECVAR_ENQUEUE_UPDATE 178 +#define OPAL_LAST 178 + +#define QUIESCE_HOLD 1 /* Spin all calls at entry */ +#define QUIESCE_REJECT 2 /* Fail all calls with OPAL_BUSY */ +#define QUIESCE_LOCK_BREAK 3 /* Set to ignore locks. */ +#define QUIESCE_RESUME 4 /* Un-quiesce */ +#define QUIESCE_RESUME_FAST_REBOOT 5 /* Un-quiesce, fast reboot */ + +/* Device tree flags */ + +/* + * Flags set in power-mgmt nodes in device tree describing + * idle states that are supported in the platform. + */ + +#define OPAL_PM_TIMEBASE_STOP 0x00000002 +#define OPAL_PM_LOSE_HYP_CONTEXT 0x00002000 +#define OPAL_PM_LOSE_FULL_CONTEXT 0x00004000 +#define OPAL_PM_NAP_ENABLED 0x00010000 +#define OPAL_PM_SLEEP_ENABLED 0x00020000 +#define OPAL_PM_WINKLE_ENABLED 0x00040000 +#define OPAL_PM_SLEEP_ENABLED_ER1 0x00080000 /* with workaround */ +#define OPAL_PM_STOP_INST_FAST 0x00100000 +#define OPAL_PM_STOP_INST_DEEP 0x00200000 + +/* + * OPAL_CONFIG_CPU_IDLE_STATE parameters + */ +#define OPAL_CONFIG_IDLE_FASTSLEEP 1 +#define OPAL_CONFIG_IDLE_UNDO 0 +#define OPAL_CONFIG_IDLE_APPLY 1 + +#ifndef __ASSEMBLY__ + +#include + +/* Other enums */ +enum OpalFreezeState { + OPAL_EEH_STOPPED_NOT_FROZEN =3D 0, + OPAL_EEH_STOPPED_MMIO_FREEZE =3D 1, + OPAL_EEH_STOPPED_DMA_FREEZE =3D 2, + OPAL_EEH_STOPPED_MMIO_DMA_FREEZE =3D 3, + OPAL_EEH_STOPPED_RESET =3D 4, + OPAL_EEH_STOPPED_TEMP_UNAVAIL =3D 5, + OPAL_EEH_STOPPED_PERM_UNAVAIL =3D 6 +}; + +enum OpalEehFreezeActionToken { + OPAL_EEH_ACTION_CLEAR_FREEZE_MMIO =3D 1, + OPAL_EEH_ACTION_CLEAR_FREEZE_DMA =3D 2, + OPAL_EEH_ACTION_CLEAR_FREEZE_ALL =3D 3, + + OPAL_EEH_ACTION_SET_FREEZE_MMIO =3D 1, + OPAL_EEH_ACTION_SET_FREEZE_DMA =3D 2, + OPAL_EEH_ACTION_SET_FREEZE_ALL =3D 3 +}; + +enum OpalPciStatusToken { + OPAL_EEH_NO_ERROR =3D 0, + OPAL_EEH_IOC_ERROR =3D 1, + OPAL_EEH_PHB_ERROR =3D 2, + OPAL_EEH_PE_ERROR =3D 3, + OPAL_EEH_PE_MMIO_ERROR =3D 4, + OPAL_EEH_PE_DMA_ERROR =3D 5 +}; + +enum OpalPciErrorSeverity { + OPAL_EEH_SEV_NO_ERROR =3D 0, + OPAL_EEH_SEV_IOC_DEAD =3D 1, + OPAL_EEH_SEV_PHB_DEAD =3D 2, + OPAL_EEH_SEV_PHB_FENCED =3D 3, + OPAL_EEH_SEV_PE_ER =3D 4, + OPAL_EEH_SEV_INF =3D 5 +}; + +enum OpalErrinjectType { + OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR =3D 0, + OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR64 =3D 1, +}; + +enum OpalErrinjectFunc { + /* IOA bus specific errors */ + OPAL_ERR_INJECT_FUNC_IOA_LD_MEM_ADDR =3D 0, + OPAL_ERR_INJECT_FUNC_IOA_LD_MEM_DATA =3D 1, + OPAL_ERR_INJECT_FUNC_IOA_LD_IO_ADDR =3D 2, + OPAL_ERR_INJECT_FUNC_IOA_LD_IO_DATA =3D 3, + OPAL_ERR_INJECT_FUNC_IOA_LD_CFG_ADDR =3D 4, + OPAL_ERR_INJECT_FUNC_IOA_LD_CFG_DATA =3D 5, + OPAL_ERR_INJECT_FUNC_IOA_ST_MEM_ADDR =3D 6, + OPAL_ERR_INJECT_FUNC_IOA_ST_MEM_DATA =3D 7, + OPAL_ERR_INJECT_FUNC_IOA_ST_IO_ADDR =3D 8, + OPAL_ERR_INJECT_FUNC_IOA_ST_IO_DATA =3D 9, + OPAL_ERR_INJECT_FUNC_IOA_ST_CFG_ADDR =3D 10, + OPAL_ERR_INJECT_FUNC_IOA_ST_CFG_DATA =3D 11, + OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_ADDR =3D 12, + OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_DATA =3D 13, + OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_MASTER =3D 14, + OPAL_ERR_INJECT_FUNC_IOA_DMA_RD_TARGET =3D 15, + OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_ADDR =3D 16, + OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_DATA =3D 17, + OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_MASTER =3D 18, + OPAL_ERR_INJECT_FUNC_IOA_DMA_WR_TARGET =3D 19, +}; + +enum OpalMmioWindowType { + OPAL_M32_WINDOW_TYPE =3D 1, + OPAL_M64_WINDOW_TYPE =3D 2, + OPAL_IO_WINDOW_TYPE =3D 3 +}; + +enum OpalExceptionHandler { + OPAL_MACHINE_CHECK_HANDLER =3D 1, + OPAL_HYPERVISOR_MAINTENANCE_HANDLER =3D 2, + OPAL_SOFTPATCH_HANDLER =3D 3 +}; + +enum OpalPendingState { + OPAL_EVENT_OPAL_INTERNAL =3D 0x1, + OPAL_EVENT_NVRAM =3D 0x2, + OPAL_EVENT_RTC =3D 0x4, + OPAL_EVENT_CONSOLE_OUTPUT =3D 0x8, + OPAL_EVENT_CONSOLE_INPUT =3D 0x10, + OPAL_EVENT_ERROR_LOG_AVAIL =3D 0x20, + OPAL_EVENT_ERROR_LOG =3D 0x40, + OPAL_EVENT_EPOW =3D 0x80, + OPAL_EVENT_LED_STATUS =3D 0x100, + OPAL_EVENT_PCI_ERROR =3D 0x200, + OPAL_EVENT_DUMP_AVAIL =3D 0x400, + OPAL_EVENT_MSG_PENDING =3D 0x800, +}; + +enum OpalThreadStatus { + OPAL_THREAD_INACTIVE =3D 0x0, + OPAL_THREAD_STARTED =3D 0x1, + OPAL_THREAD_UNAVAILABLE =3D 0x2 /* opal-v3 */ +}; + +enum OpalPciBusCompare { + OpalPciBusAny =3D 0, /* Any bus number match */ + OpalPciBus3Bits =3D 2, /* Match top 3 bits of bus number */ + OpalPciBus4Bits =3D 3, /* Match top 4 bits of bus number */ + OpalPciBus5Bits =3D 4, /* Match top 5 bits of bus number */ + OpalPciBus6Bits =3D 5, /* Match top 6 bits of bus number */ + OpalPciBus7Bits =3D 6, /* Match top 7 bits of bus number */ + OpalPciBusAll =3D 7, /* Match bus number exactly */ +}; + +enum OpalDeviceCompare { + OPAL_IGNORE_RID_DEVICE_NUMBER =3D 0, + OPAL_COMPARE_RID_DEVICE_NUMBER =3D 1 +}; + +enum OpalFuncCompare { + OPAL_IGNORE_RID_FUNCTION_NUMBER =3D 0, + OPAL_COMPARE_RID_FUNCTION_NUMBER =3D 1 +}; + +enum OpalPeAction { + OPAL_UNMAP_PE =3D 0, + OPAL_MAP_PE =3D 1 +}; + +enum OpalPeltvAction { + OPAL_REMOVE_PE_FROM_DOMAIN =3D 0, + OPAL_ADD_PE_TO_DOMAIN =3D 1 +}; + +enum OpalMveEnableAction { + OPAL_DISABLE_MVE =3D 0, + OPAL_ENABLE_MVE =3D 1 +}; + +enum OpalM64Action { + OPAL_DISABLE_M64 =3D 0, + OPAL_ENABLE_M64_SPLIT =3D 1, + OPAL_ENABLE_M64_NON_SPLIT =3D 2 +}; + +enum OpalPciResetScope { + OPAL_RESET_PHB_COMPLETE =3D 1, + OPAL_RESET_PCI_LINK =3D 2, + OPAL_RESET_PHB_ERROR =3D 3, + OPAL_RESET_PCI_HOT =3D 4, + OPAL_RESET_PCI_FUNDAMENTAL =3D 5, + OPAL_RESET_PCI_IODA_TABLE =3D 6 +}; + +enum OpalPciReinitScope { + /* + * Note: we chose values that do not overlap + * OpalPciResetScope as OPAL v2 used the same + * enum for both + */ + OPAL_REINIT_PCI_DEV =3D 1000 +}; + +enum OpalPciResetState { + OPAL_DEASSERT_RESET =3D 0, + OPAL_ASSERT_RESET =3D 1 +}; + +enum OpalPciSlotPresence { + OPAL_PCI_SLOT_EMPTY =3D 0, + OPAL_PCI_SLOT_PRESENT =3D 1 +}; + +enum OpalPciSlotPower { + OPAL_PCI_SLOT_POWER_OFF =3D 0, + OPAL_PCI_SLOT_POWER_ON =3D 1, + OPAL_PCI_SLOT_OFFLINE =3D 2, + OPAL_PCI_SLOT_ONLINE =3D 3 +}; + +enum OpalSlotLedType { + OPAL_SLOT_LED_TYPE_ID =3D 0, /* IDENTIFY LED */ + OPAL_SLOT_LED_TYPE_FAULT =3D 1, /* FAULT LED */ + OPAL_SLOT_LED_TYPE_ATTN =3D 2, /* System Attention LED */ + OPAL_SLOT_LED_TYPE_MAX =3D 3 +}; + +enum OpalSlotLedState { + OPAL_SLOT_LED_STATE_OFF =3D 0, /* LED is OFF */ + OPAL_SLOT_LED_STATE_ON =3D 1 /* LED is ON */ +}; + +/* + * Address cycle types for LPC accesses. These also correspond + * to the content of the first cell of the "reg" property for + * device nodes on the LPC bus + */ +enum OpalLPCAddressType { + OPAL_LPC_MEM =3D 0, + OPAL_LPC_IO =3D 1, + OPAL_LPC_FW =3D 2, +}; + +enum opal_msg_type { + OPAL_MSG_ASYNC_COMP =3D 0, /* params[0] =3D token, params[1] =3D rc, + * additional params function-specific + */ + OPAL_MSG_MEM_ERR =3D 1, + OPAL_MSG_EPOW =3D 2, + OPAL_MSG_SHUTDOWN =3D 3, /* params[0] =3D 1 reboot, 0 shutdown */ + OPAL_MSG_HMI_EVT =3D 4, + OPAL_MSG_DPO =3D 5, + OPAL_MSG_PRD =3D 6, + OPAL_MSG_OCC =3D 7, + OPAL_MSG_PRD2 =3D 8, + OPAL_MSG_TYPE_MAX, +}; + +struct opal_msg { + __be32 msg_type; + __be32 reserved; + __be64 params[8]; +}; + +/* System parameter permission */ +enum OpalSysparamPerm { + OPAL_SYSPARAM_READ =3D 0x1, + OPAL_SYSPARAM_WRITE =3D 0x2, + OPAL_SYSPARAM_RW =3D (OPAL_SYSPARAM_READ | OPAL_SYSPARAM_WRITE), +}; + +enum { + OPAL_IPMI_MSG_FORMAT_VERSION_1 =3D 1, +}; + +struct opal_ipmi_msg { + uint8_t version; + uint8_t netfn; + uint8_t cmd; + uint8_t data[]; +}; + +/* FSP memory errors handling */ +enum OpalMemErr_Version { + OpalMemErr_V1 =3D 1, +}; + +enum OpalMemErrType { + OPAL_MEM_ERR_TYPE_RESILIENCE =3D 0, + OPAL_MEM_ERR_TYPE_DYN_DALLOC, +}; + +/* Memory Reilience error type */ +enum OpalMemErr_ResilErrType { + OPAL_MEM_RESILIENCE_CE =3D 0, + OPAL_MEM_RESILIENCE_UE, + OPAL_MEM_RESILIENCE_UE_SCRUB, +}; + +/* Dynamic Memory Deallocation type */ +enum OpalMemErr_DynErrType { + OPAL_MEM_DYNAMIC_DEALLOC =3D 0, +}; + +struct OpalMemoryErrorData { + enum OpalMemErr_Version version:8; /* 0x00 */ + enum OpalMemErrType type:8; /* 0x01 */ + __be16 flags; /* 0x02 */ + uint8_t reserved_1[4]; /* 0x04 */ + + union { + /* Memory Resilience corrected/uncorrected error info */ + struct { + enum OpalMemErr_ResilErrType resil_err_type:8; + uint8_t reserved_1[7]; + __be64 physical_address_start; + __be64 physical_address_end; + } resilience; + /* Dynamic memory deallocation error info */ + struct { + enum OpalMemErr_DynErrType dyn_err_type:8; + uint8_t reserved_1[7]; + __be64 physical_address_start; + __be64 physical_address_end; + } dyn_dealloc; + } u; +}; + +/* HMI interrupt event */ +enum OpalHMI_Version { + OpalHMIEvt_V1 =3D 1, + OpalHMIEvt_V2 =3D 2, +}; + +enum OpalHMI_Severity { + OpalHMI_SEV_NO_ERROR =3D 0, + OpalHMI_SEV_WARNING =3D 1, + OpalHMI_SEV_ERROR_SYNC =3D 2, + OpalHMI_SEV_FATAL =3D 3, +}; + +enum OpalHMI_Disposition { + OpalHMI_DISPOSITION_RECOVERED =3D 0, + OpalHMI_DISPOSITION_NOT_RECOVERED =3D 1, +}; + +enum OpalHMI_ErrType { + OpalHMI_ERROR_MALFUNC_ALERT =3D 0, + OpalHMI_ERROR_PROC_RECOV_DONE, + OpalHMI_ERROR_PROC_RECOV_DONE_AGAIN, + OpalHMI_ERROR_PROC_RECOV_MASKED, + OpalHMI_ERROR_TFAC, + OpalHMI_ERROR_TFMR_PARITY, + OpalHMI_ERROR_HA_OVERFLOW_WARN, + OpalHMI_ERROR_XSCOM_FAIL, + OpalHMI_ERROR_XSCOM_DONE, + OpalHMI_ERROR_SCOM_FIR, + OpalHMI_ERROR_DEBUG_TRIG_FIR, + OpalHMI_ERROR_HYP_RESOURCE, + OpalHMI_ERROR_CAPP_RECOVERY, +}; + +enum OpalHMI_XstopType { + CHECKSTOP_TYPE_UNKNOWN =3D 0, + CHECKSTOP_TYPE_CORE =3D 1, + CHECKSTOP_TYPE_NX =3D 2, + CHECKSTOP_TYPE_NPU =3D 3 +}; + +enum OpalHMI_CoreXstopReason { + CORE_CHECKSTOP_IFU_REGFILE =3D 0x00000001, + CORE_CHECKSTOP_IFU_LOGIC =3D 0x00000002, + CORE_CHECKSTOP_PC_DURING_RECOV =3D 0x00000004, + CORE_CHECKSTOP_ISU_REGFILE =3D 0x00000008, + CORE_CHECKSTOP_ISU_LOGIC =3D 0x00000010, + CORE_CHECKSTOP_FXU_LOGIC =3D 0x00000020, + CORE_CHECKSTOP_VSU_LOGIC =3D 0x00000040, + CORE_CHECKSTOP_PC_RECOV_IN_MAINT_MODE =3D 0x00000080, + CORE_CHECKSTOP_LSU_REGFILE =3D 0x00000100, + CORE_CHECKSTOP_PC_FWD_PROGRESS =3D 0x00000200, + CORE_CHECKSTOP_LSU_LOGIC =3D 0x00000400, + CORE_CHECKSTOP_PC_LOGIC =3D 0x00000800, + CORE_CHECKSTOP_PC_HYP_RESOURCE =3D 0x00001000, + CORE_CHECKSTOP_PC_HANG_RECOV_FAILED =3D 0x00002000, + CORE_CHECKSTOP_PC_AMBI_HANG_DETECTED =3D 0x00004000, + CORE_CHECKSTOP_PC_DEBUG_TRIG_ERR_INJ =3D 0x00008000, + CORE_CHECKSTOP_PC_SPRD_HYP_ERR_INJ =3D 0x00010000, +}; + +enum OpalHMI_NestAccelXstopReason { + NX_CHECKSTOP_SHM_INVAL_STATE_ERR =3D 0x00000001, + NX_CHECKSTOP_DMA_INVAL_STATE_ERR_1 =3D 0x00000002, + NX_CHECKSTOP_DMA_INVAL_STATE_ERR_2 =3D 0x00000004, + NX_CHECKSTOP_DMA_CH0_INVAL_STATE_ERR =3D 0x00000008, + NX_CHECKSTOP_DMA_CH1_INVAL_STATE_ERR =3D 0x00000010, + NX_CHECKSTOP_DMA_CH2_INVAL_STATE_ERR =3D 0x00000020, + NX_CHECKSTOP_DMA_CH3_INVAL_STATE_ERR =3D 0x00000040, + NX_CHECKSTOP_DMA_CH4_INVAL_STATE_ERR =3D 0x00000080, + NX_CHECKSTOP_DMA_CH5_INVAL_STATE_ERR =3D 0x00000100, + NX_CHECKSTOP_DMA_CH6_INVAL_STATE_ERR =3D 0x00000200, + NX_CHECKSTOP_DMA_CH7_INVAL_STATE_ERR =3D 0x00000400, + NX_CHECKSTOP_DMA_CRB_UE =3D 0x00000800, + NX_CHECKSTOP_DMA_CRB_SUE =3D 0x00001000, + NX_CHECKSTOP_PBI_ISN_UE =3D 0x00002000, +}; + +struct OpalHMIEvent { + uint8_t version; /* 0x00 */ + uint8_t severity; /* 0x01 */ + uint8_t type; /* 0x02 */ + uint8_t disposition; /* 0x03 */ + uint8_t reserved_1[4]; /* 0x04 */ + + __be64 hmer; + /* TFMR register. Valid only for TFAC and TFMR_PARITY error type. */ + __be64 tfmr; + + /* version 2 and later */ + union { + /* + * checkstop info (Core/NX). + * Valid for OpalHMI_ERROR_MALFUNC_ALERT. + */ + struct { + uint8_t xstop_type; /* enum OpalHMI_XstopType */ + uint8_t reserved_1[3]; + __be32 xstop_reason; + union { + __be32 pir; /* for CHECKSTOP_TYPE_CORE */ + __be32 chip_id; /* for CHECKSTOP_TYPE_NX */ + } u; + } xstop_error; + } u; +}; + +/* OPAL_HANDLE_HMI2 out_flags */ +enum { + OPAL_HMI_FLAGS_TB_RESYNC =3D (1ull << 0), /* Timebase has been resynced= */ + OPAL_HMI_FLAGS_DEC_LOST =3D (1ull << 1), /* DEC lost, needs to be repr= ogrammed */ + OPAL_HMI_FLAGS_HDEC_LOST =3D (1ull << 2), /* HDEC lost, needs to be rep= rogrammed */ + OPAL_HMI_FLAGS_TOD_TB_FAIL =3D (1ull << 3), /* TOD/TB recovery failed. = */ + OPAL_HMI_FLAGS_NEW_EVENT =3D (1ull << 63), /* An event has been created= */ +}; + +enum { + OPAL_P7IOC_DIAG_TYPE_NONE =3D 0, + OPAL_P7IOC_DIAG_TYPE_RGC =3D 1, + OPAL_P7IOC_DIAG_TYPE_BI =3D 2, + OPAL_P7IOC_DIAG_TYPE_CI =3D 3, + OPAL_P7IOC_DIAG_TYPE_MISC =3D 4, + OPAL_P7IOC_DIAG_TYPE_I2C =3D 5, + OPAL_P7IOC_DIAG_TYPE_LAST =3D 6 +}; + +struct OpalIoP7IOCErrorData { + __be16 type; + + /* GEM */ + __be64 gemXfir; + __be64 gemRfir; + __be64 gemRirqfir; + __be64 gemMask; + __be64 gemRwof; + + /* LEM */ + __be64 lemFir; + __be64 lemErrMask; + __be64 lemAction0; + __be64 lemAction1; + __be64 lemWof; + + union { + struct OpalIoP7IOCRgcErrorData { + __be64 rgcStatus; /* 3E1C10 */ + __be64 rgcLdcp; /* 3E1C18 */ + }rgc; + struct OpalIoP7IOCBiErrorData { + __be64 biLdcp0; /* 3C0100, 3C0118 */ + __be64 biLdcp1; /* 3C0108, 3C0120 */ + __be64 biLdcp2; /* 3C0110, 3C0128 */ + __be64 biFenceStatus; /* 3C0130, 3C0130 */ + + uint8_t biDownbound; /* BI Downbound or Upbound */ + }bi; + struct OpalIoP7IOCCiErrorData { + __be64 ciPortStatus; /* 3Dn008 */ + __be64 ciPortLdcp; /* 3Dn010 */ + + uint8_t ciPort; /* Index of CI port: 0/1 */ + }ci; + }; +}; + +/** + * This structure defines the overlay which will be used to store PHB er= ror + * data upon request. + */ +enum { + OPAL_PHB_ERROR_DATA_VERSION_1 =3D 1, +}; + +enum { + OPAL_PHB_ERROR_DATA_TYPE_P7IOC =3D 1, + OPAL_PHB_ERROR_DATA_TYPE_PHB3 =3D 2, + OPAL_PHB_ERROR_DATA_TYPE_PHB4 =3D 3 +}; + +enum { + OPAL_P7IOC_NUM_PEST_REGS =3D 128, + OPAL_PHB3_NUM_PEST_REGS =3D 256, + OPAL_PHB4_NUM_PEST_REGS =3D 512 +}; + +struct OpalIoPhbErrorCommon { + __be32 version; + __be32 ioType; + __be32 len; +}; + +struct OpalIoP7IOCPhbErrorData { + struct OpalIoPhbErrorCommon common; + + __be32 brdgCtl; + + // P7IOC utl regs + __be32 portStatusReg; + __be32 rootCmplxStatus; + __be32 busAgentStatus; + + // P7IOC cfg regs + __be32 deviceStatus; + __be32 slotStatus; + __be32 linkStatus; + __be32 devCmdStatus; + __be32 devSecStatus; + + // cfg AER regs + __be32 rootErrorStatus; + __be32 uncorrErrorStatus; + __be32 corrErrorStatus; + __be32 tlpHdr1; + __be32 tlpHdr2; + __be32 tlpHdr3; + __be32 tlpHdr4; + __be32 sourceId; + + __be32 rsv3; + + // Record data about the call to allocate a buffer. + __be64 errorClass; + __be64 correlator; + + //P7IOC MMIO Error Regs + __be64 p7iocPlssr; // n120 + __be64 p7iocCsr; // n110 + __be64 lemFir; // nC00 + __be64 lemErrorMask; // nC18 + __be64 lemWOF; // nC40 + __be64 phbErrorStatus; // nC80 + __be64 phbFirstErrorStatus; // nC88 + __be64 phbErrorLog0; // nCC0 + __be64 phbErrorLog1; // nCC8 + __be64 mmioErrorStatus; // nD00 + __be64 mmioFirstErrorStatus; // nD08 + __be64 mmioErrorLog0; // nD40 + __be64 mmioErrorLog1; // nD48 + __be64 dma0ErrorStatus; // nD80 + __be64 dma0FirstErrorStatus; // nD88 + __be64 dma0ErrorLog0; // nDC0 + __be64 dma0ErrorLog1; // nDC8 + __be64 dma1ErrorStatus; // nE00 + __be64 dma1FirstErrorStatus; // nE08 + __be64 dma1ErrorLog0; // nE40 + __be64 dma1ErrorLog1; // nE48 + __be64 pestA[OPAL_P7IOC_NUM_PEST_REGS]; + __be64 pestB[OPAL_P7IOC_NUM_PEST_REGS]; +}; + +struct OpalIoPhb3ErrorData { + struct OpalIoPhbErrorCommon common; + + __be32 brdgCtl; + + /* PHB3 UTL regs */ + __be32 portStatusReg; + __be32 rootCmplxStatus; + __be32 busAgentStatus; + + /* PHB3 cfg regs */ + __be32 deviceStatus; + __be32 slotStatus; + __be32 linkStatus; + __be32 devCmdStatus; + __be32 devSecStatus; + + /* cfg AER regs */ + __be32 rootErrorStatus; + __be32 uncorrErrorStatus; + __be32 corrErrorStatus; + __be32 tlpHdr1; + __be32 tlpHdr2; + __be32 tlpHdr3; + __be32 tlpHdr4; + __be32 sourceId; + + __be32 rsv3; + + /* Record data about the call to allocate a buffer */ + __be64 errorClass; + __be64 correlator; + + /* PHB3 MMIO Error Regs */ + __be64 nFir; /* 000 */ + __be64 nFirMask; /* 003 */ + __be64 nFirWOF; /* 008 */ + __be64 phbPlssr; /* 120 */ + __be64 phbCsr; /* 110 */ + __be64 lemFir; /* C00 */ + __be64 lemErrorMask; /* C18 */ + __be64 lemWOF; /* C40 */ + __be64 phbErrorStatus; /* C80 */ + __be64 phbFirstErrorStatus; /* C88 */ + __be64 phbErrorLog0; /* CC0 */ + __be64 phbErrorLog1; /* CC8 */ + __be64 mmioErrorStatus; /* D00 */ + __be64 mmioFirstErrorStatus; /* D08 */ + __be64 mmioErrorLog0; /* D40 */ + __be64 mmioErrorLog1; /* D48 */ + __be64 dma0ErrorStatus; /* D80 */ + __be64 dma0FirstErrorStatus; /* D88 */ + __be64 dma0ErrorLog0; /* DC0 */ + __be64 dma0ErrorLog1; /* DC8 */ + __be64 dma1ErrorStatus; /* E00 */ + __be64 dma1FirstErrorStatus; /* E08 */ + __be64 dma1ErrorLog0; /* E40 */ + __be64 dma1ErrorLog1; /* E48 */ + __be64 pestA[OPAL_PHB3_NUM_PEST_REGS]; + __be64 pestB[OPAL_PHB3_NUM_PEST_REGS]; +}; + +struct OpalIoPhb4ErrorData { + struct OpalIoPhbErrorCommon common; + + __be32 brdgCtl; + + /* PHB4 cfg regs */ + __be32 deviceStatus; + __be32 slotStatus; + __be32 linkStatus; + __be32 devCmdStatus; + __be32 devSecStatus; + + /* cfg AER regs */ + __be32 rootErrorStatus; + __be32 uncorrErrorStatus; + __be32 corrErrorStatus; + __be32 tlpHdr1; + __be32 tlpHdr2; + __be32 tlpHdr3; + __be32 tlpHdr4; + __be32 sourceId; + + /* PHB4 ETU Error Regs */ + __be64 nFir; /* 000 */ + __be64 nFirMask; /* 003 */ + __be64 nFirWOF; /* 008 */ + __be64 phbPlssr; /* 120 */ + __be64 phbCsr; /* 110 */ + __be64 lemFir; /* C00 */ + __be64 lemErrorMask; /* C18 */ + __be64 lemWOF; /* C40 */ + __be64 phbErrorStatus; /* C80 */ + __be64 phbFirstErrorStatus; /* C88 */ + __be64 phbErrorLog0; /* CC0 */ + __be64 phbErrorLog1; /* CC8 */ + __be64 phbTxeErrorStatus; /* D00 */ + __be64 phbTxeFirstErrorStatus; /* D08 */ + __be64 phbTxeErrorLog0; /* D40 */ + __be64 phbTxeErrorLog1; /* D48 */ + __be64 phbRxeArbErrorStatus; /* D80 */ + __be64 phbRxeArbFirstErrorStatus; /* D88 */ + __be64 phbRxeArbErrorLog0; /* DC0 */ + __be64 phbRxeArbErrorLog1; /* DC8 */ + __be64 phbRxeMrgErrorStatus; /* E00 */ + __be64 phbRxeMrgFirstErrorStatus; /* E08 */ + __be64 phbRxeMrgErrorLog0; /* E40 */ + __be64 phbRxeMrgErrorLog1; /* E48 */ + __be64 phbRxeTceErrorStatus; /* E80 */ + __be64 phbRxeTceFirstErrorStatus; /* E88 */ + __be64 phbRxeTceErrorLog0; /* EC0 */ + __be64 phbRxeTceErrorLog1; /* EC8 */ + + /* PHB4 REGB Error Regs */ + __be64 phbPblErrorStatus; /* 1900 */ + __be64 phbPblFirstErrorStatus; /* 1908 */ + __be64 phbPblErrorLog0; /* 1940 */ + __be64 phbPblErrorLog1; /* 1948 */ + __be64 phbPcieDlpErrorLog1; /* 1AA0 */ + __be64 phbPcieDlpErrorLog2; /* 1AA8 */ + __be64 phbPcieDlpErrorStatus; /* 1AB0 */ + __be64 phbRegbErrorStatus; /* 1C00 */ + __be64 phbRegbFirstErrorStatus; /* 1C08 */ + __be64 phbRegbErrorLog0; /* 1C40 */ + __be64 phbRegbErrorLog1; /* 1C48 */ + + __be64 pestA[OPAL_PHB4_NUM_PEST_REGS]; + __be64 pestB[OPAL_PHB4_NUM_PEST_REGS]; +}; + +enum { + OPAL_REINIT_CPUS_HILE_BE =3D (1 << 0), + OPAL_REINIT_CPUS_HILE_LE =3D (1 << 1), + + /* These two define the base MMU mode of the host on P9 + * + * On P9 Nimbus DD2.0 and Cumlus (and later), KVM can still + * create hash guests in "radix" mode with care (full core + * switch only). + */ + OPAL_REINIT_CPUS_MMU_HASH =3D (1 << 2), + OPAL_REINIT_CPUS_MMU_RADIX =3D (1 << 3), + + OPAL_REINIT_CPUS_TM_SUSPEND_DISABLED =3D (1 << 4), +}; + +typedef struct oppanel_line { + __be64 line; + __be64 line_len; +} oppanel_line_t; + +enum opal_prd_msg_type { + OPAL_PRD_MSG_TYPE_INIT =3D 0, /* HBRT --> OPAL */ + OPAL_PRD_MSG_TYPE_FINI, /* HBRT/kernel --> OPAL */ + OPAL_PRD_MSG_TYPE_ATTN, /* HBRT <-- OPAL */ + OPAL_PRD_MSG_TYPE_ATTN_ACK, /* HBRT --> OPAL */ + OPAL_PRD_MSG_TYPE_OCC_ERROR, /* HBRT <-- OPAL */ + OPAL_PRD_MSG_TYPE_OCC_RESET, /* HBRT <-- OPAL */ +}; + +struct opal_prd_msg_header { + uint8_t type; + uint8_t pad[1]; + __be16 size; +}; + +struct opal_prd_msg; + +#define OCC_RESET 0 +#define OCC_LOAD 1 +#define OCC_THROTTLE 2 +#define OCC_MAX_THROTTLE_STATUS 5 + +struct opal_occ_msg { + __be64 type; + __be64 chip; + __be64 throttle_status; +}; + +/* + * SG entries + * + * WARNING: The current implementation requires each entry + * to represent a block that is 4k aligned *and* each block + * size except the last one in the list to be as well. + */ +struct opal_sg_entry { + __be64 data; + __be64 length; +}; + +/* + * Candidate image SG list. + * + * length =3D VER | length + */ +struct opal_sg_list { + __be64 length; + __be64 next; + struct opal_sg_entry entry[]; +}; + +/* + * Dump region ID range usable by the OS + */ +#define OPAL_DUMP_REGION_HOST_START 0x80 +#define OPAL_DUMP_REGION_LOG_BUF 0x80 +#define OPAL_DUMP_REGION_HOST_END 0xFF + +/* CAPI modes for PHB */ +enum { + OPAL_PHB_CAPI_MODE_PCIE =3D 0, + OPAL_PHB_CAPI_MODE_CAPI =3D 1, + OPAL_PHB_CAPI_MODE_SNOOP_OFF =3D 2, + OPAL_PHB_CAPI_MODE_SNOOP_ON =3D 3, + OPAL_PHB_CAPI_MODE_DMA =3D 4, + OPAL_PHB_CAPI_MODE_DMA_TVT1 =3D 5, +}; + +/* OPAL I2C request */ +struct opal_i2c_request { + uint8_t type; +#define OPAL_I2C_RAW_READ 0 +#define OPAL_I2C_RAW_WRITE 1 +#define OPAL_I2C_SM_READ 2 +#define OPAL_I2C_SM_WRITE 3 + uint8_t flags; +#define OPAL_I2C_ADDR_10 0x01 /* Not supported yet */ + uint8_t subaddr_sz; /* Max 4 */ + uint8_t reserved; + __be16 addr; /* 7 or 10 bit address */ + __be16 reserved2; + __be32 subaddr; /* Sub-address if any */ + __be32 size; /* Data size */ + __be64 buffer_ra; /* Buffer real address */ +}; + +/* + * EPOW status sharing (OPAL and the host) + * + * The host will pass on OPAL, a buffer of length OPAL_SYSEPOW_MAX + * with individual elements being 16 bits wide to fetch the system + * wide EPOW status. Each element in the buffer will contain the + * EPOW status in it's bit representation for a particular EPOW sub + * class as defined here. So multiple detailed EPOW status bits + * specific for any sub class can be represented in a single buffer + * element as it's bit representation. + */ + +/* System EPOW type */ +enum OpalSysEpow { + OPAL_SYSEPOW_POWER =3D 0, /* Power EPOW */ + OPAL_SYSEPOW_TEMP =3D 1, /* Temperature EPOW */ + OPAL_SYSEPOW_COOLING =3D 2, /* Cooling EPOW */ + OPAL_SYSEPOW_MAX =3D 3, /* Max EPOW categories */ +}; + +/* Power EPOW */ +enum OpalSysPower { + OPAL_SYSPOWER_UPS =3D 0x0001, /* System on UPS power */ + OPAL_SYSPOWER_CHNG =3D 0x0002, /* System power config change */ + OPAL_SYSPOWER_FAIL =3D 0x0004, /* System impending power failure */ + OPAL_SYSPOWER_INCL =3D 0x0008, /* System incomplete power */ +}; + +/* Temperature EPOW */ +enum OpalSysTemp { + OPAL_SYSTEMP_AMB =3D 0x0001, /* System over ambient temperature */ + OPAL_SYSTEMP_INT =3D 0x0002, /* System over internal temperature */ + OPAL_SYSTEMP_HMD =3D 0x0004, /* System over ambient humidity */ +}; + +/* Cooling EPOW */ +enum OpalSysCooling { + OPAL_SYSCOOL_INSF =3D 0x0001, /* System insufficient cooling */ +}; + +/* Argument to OPAL_CEC_REBOOT2() */ +enum { + OPAL_REBOOT_NORMAL =3D 0, + OPAL_REBOOT_PLATFORM_ERROR =3D 1, + OPAL_REBOOT_FULL_IPL =3D 2, + OPAL_REBOOT_MPIPL =3D 3, + OPAL_REBOOT_FAST =3D 4, +}; + +/* Argument to OPAL_PCI_TCE_KILL */ +enum { + OPAL_PCI_TCE_KILL_PAGES, + OPAL_PCI_TCE_KILL_PE, + OPAL_PCI_TCE_KILL_ALL, +}; + +/* The xive operation mode indicates the active "API" and + * corresponds to the "mode" parameter of the opal_xive_reset() + * call + */ +enum { + OPAL_XIVE_MODE_EMU =3D 0, + OPAL_XIVE_MODE_EXPL =3D 1, +}; + +/* Flags for OPAL_XIVE_GET_IRQ_INFO */ +enum { + OPAL_XIVE_IRQ_TRIGGER_PAGE =3D 0x00000001, + OPAL_XIVE_IRQ_STORE_EOI =3D 0x00000002, + OPAL_XIVE_IRQ_LSI =3D 0x00000004, + OPAL_XIVE_IRQ_SHIFT_BUG =3D 0x00000008, /* P9 DD1.0 workaround */ + OPAL_XIVE_IRQ_MASK_VIA_FW =3D 0x00000010, /* P9 DD1.0 workaround */ + OPAL_XIVE_IRQ_EOI_VIA_FW =3D 0x00000020, /* P9 DD1.0 workaround */ + OPAL_XIVE_IRQ_STORE_EOI2 =3D 0x00000040, +}; + +/* Flags for OPAL_XIVE_GET/SET_QUEUE_INFO */ +enum { + OPAL_XIVE_EQ_ENABLED =3D 0x00000001, + OPAL_XIVE_EQ_ALWAYS_NOTIFY =3D 0x00000002, + OPAL_XIVE_EQ_ESCALATE =3D 0x00000004, +}; + +/* Flags for OPAL_XIVE_GET/SET_VP_INFO */ +enum { + OPAL_XIVE_VP_ENABLED =3D 0x00000001, + OPAL_XIVE_VP_SINGLE_ESCALATION =3D 0x00000002, +}; + +/* "Any chip" replacement for chip ID for allocation functions */ +enum { + OPAL_XIVE_ANY_CHIP =3D 0xffffffff, +}; + +/* Xive sync options */ +enum { + /* This bits are cumulative, arg is a girq */ + XIVE_SYNC_EAS =3D 0x00000001, /* Sync irq source */ + XIVE_SYNC_QUEUE =3D 0x00000002, /* Sync irq target */ +}; + +/* Dump options */ +enum { + XIVE_DUMP_TM_HYP =3D 0, + XIVE_DUMP_TM_POOL =3D 1, + XIVE_DUMP_TM_OS =3D 2, + XIVE_DUMP_TM_USER =3D 3, + XIVE_DUMP_VP =3D 4, + XIVE_DUMP_EMU_STATE =3D 5, +}; + +/* "type" argument options for OPAL_IMC_COUNTERS_* calls */ +enum { + OPAL_IMC_COUNTERS_NEST =3D 1, + OPAL_IMC_COUNTERS_CORE =3D 2, + OPAL_IMC_COUNTERS_TRACE =3D 3, +}; + + +/* PCI p2p descriptor */ +#define OPAL_PCI_P2P_ENABLE 0x1 +#define OPAL_PCI_P2P_LOAD 0x2 +#define OPAL_PCI_P2P_STORE 0x4 + +/* MPIPL update operations */ +enum opal_mpipl_ops { + OPAL_MPIPL_ADD_RANGE =3D 0, + OPAL_MPIPL_REMOVE_RANGE =3D 1, + OPAL_MPIPL_REMOVE_ALL =3D 2, + OPAL_MPIPL_FREE_PRESERVED_MEMORY =3D 3, +}; + +/* Tag will point to various metadata area. Kernel will + * use tag to get metadata value. + */ +enum opal_mpipl_tags { + OPAL_MPIPL_TAG_CPU =3D 0, + OPAL_MPIPL_TAG_OPAL =3D 1, + OPAL_MPIPL_TAG_KERNEL =3D 2, + OPAL_MPIPL_TAG_BOOT_MEM =3D 3, +}; + +/* Preserved memory details */ +struct opal_mpipl_region { + __be64 src; + __be64 dest; + __be64 size; +}; + +/* Structure version */ +#define OPAL_MPIPL_VERSION 0x01 + +struct opal_mpipl_fadump { + u8 version; + u8 reserved[7]; + __be32 crashing_pir; /* OPAL crashing CPU PIR */ + __be32 cpu_data_version; + __be32 cpu_data_size; + __be32 region_cnt; + struct opal_mpipl_region region[]; +} __packed; + +#endif /* __ASSEMBLY__ */ + +#endif /* __OPAL_API_H */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:11:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574610.900039 (Exim 4.92) (envelope-from ) id 1qQzSi-0003Fw-Tf; Wed, 02 Aug 2023 00:11:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574610.900039; Wed, 02 Aug 2023 00:11:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSi-0003Fp-R9; Wed, 02 Aug 2023 00:11:36 +0000 Received: by outflank-mailman (input) for mailman id 574610; Wed, 02 Aug 2023 00:11:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzSh-0003Fc-P6 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:11:35 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 22f12058-30c9-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 02:11:33 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 1A12A8285491; Tue, 1 Aug 2023 19:11:32 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id j4Lm-4MEYJ2j; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 124328285393; Tue, 1 Aug 2023 19:11:31 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id R0MSFixpmkbU; Tue, 1 Aug 2023 19:11:30 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 99D808284EB7; Tue, 1 Aug 2023 19:11:30 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22f12058-30c9-11ee-b25c-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 124328285393 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690935091; bh=dXQ4sbcV3/HyJrYh/QxCwscwRLOih6LVbq3xto6wpbE=; h=From:To:Date:Message-Id:MIME-Version; b=vmbTdtja4J6tbwLZFKikWvUOS0itYocviw2IpKM2DcbLfd6JlcfMR+qwt3VFzHAVA VwyjzsR9cD7gpJK39iy7UM9AHUoBpGJezvQPG92uvikMHdctPiliA6hLfvd3IcxhFS 68YeR0ATLs+jAMDExooa+DZoCSCzIZEpsNJliMog= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 0/4] xen/ppc: Add PowerNV bare metal support Date: Tue, 1 Aug 2023 19:11:02 -0500 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hello all, This series adds support for booting and using the serial console on bare metal PowerNV/OpenPOWER systems. Up until now, Xen could only be booted on the QEMU pseries model, which was initially targetted for ease of development, but which differs significantly from the bare metal systems where this port is likely to be the most useful. In addition to adding support for the PowerNV boot protocol and firmware interface, changes required to get libfdt from xen/libfdt building are included. This is required to obtain the firmware entrypoint address on PowerNV. This series is based on Jan's "common: move simple_strto{,u}l{,l}() to li= b/" https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg00095.htm= l Thanks, Shawn -- Changed in v2: - Drop simple_strtoul patch, base on Jan's patch instead - Remove ALL_LIBS-y override - Clean up formatting of opal.c, opal-calls.S, asm-defns.h - Consistently use label in TOC address calculation in head.S Shawn Anastasio (4): xen/ppc: Switch to medium PIC code model xen/ppc: Add OPAL API definition header file xen/ppc: Parse device tree for OPAL node on PowerNV xen/ppc: Implement early serial console on PowerNV xen/arch/ppc/Kconfig | 1 + xen/arch/ppc/Makefile | 1 + xen/arch/ppc/arch.mk | 5 +- xen/arch/ppc/include/asm/asm-defns.h | 21 + xen/arch/ppc/include/asm/boot.h | 16 +- xen/arch/ppc/include/asm/bug.h | 18 + xen/arch/ppc/include/asm/cache.h | 6 + xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/include/asm/opal-api.h | 1190 ++++++++++++++++++++++++++ xen/arch/ppc/include/asm/processor.h | 13 +- xen/arch/ppc/include/asm/string.h | 6 + xen/arch/ppc/include/asm/system.h | 6 + xen/arch/ppc/opal.c | 74 ++ xen/arch/ppc/ppc64/Makefile | 1 + xen/arch/ppc/ppc64/asm-offsets.c | 4 + xen/arch/ppc/ppc64/head.S | 12 +- xen/arch/ppc/ppc64/opal-calls.S | 81 ++ xen/arch/ppc/setup.c | 9 +- xen/arch/ppc/xen.lds.S | 44 +- 19 files changed, 1470 insertions(+), 40 deletions(-) create mode 100644 xen/arch/ppc/include/asm/bug.h create mode 100644 xen/arch/ppc/include/asm/cache.h create mode 100644 xen/arch/ppc/include/asm/opal-api.h create mode 100644 xen/arch/ppc/include/asm/string.h create mode 100644 xen/arch/ppc/include/asm/system.h create mode 100644 xen/arch/ppc/opal.c create mode 100644 xen/arch/ppc/ppc64/opal-calls.S -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:13:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574628.900090 (Exim 4.92) (envelope-from ) id 1qQzUA-00062V-63; Wed, 02 Aug 2023 00:13:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574628.900090; Wed, 02 Aug 2023 00:13:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzUA-00062O-2z; Wed, 02 Aug 2023 00:13:06 +0000 Received: by outflank-mailman (input) for mailman id 574628; Wed, 02 Aug 2023 00:13:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzU8-00062C-Un for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:13:04 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59017bab-30c9-11ee-b25c-6b7b168915f2; Wed, 02 Aug 2023 02:13:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 4393B8285491; Tue, 1 Aug 2023 19:13:03 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8FFkcEg6oGCh; Tue, 1 Aug 2023 19:13:02 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 29C28828573A; Tue, 1 Aug 2023 19:13:02 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3I6xQspQvnn6; Tue, 1 Aug 2023 19:13:02 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id BB5188285491; Tue, 1 Aug 2023 19:13:01 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59017bab-30c9-11ee-b25c-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 29C28828573A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1690935182; bh=ZlK/EaXWdc0s8a3b4yh4TLuSDzNdwGh+7w7fL5yZcNk=; h=Message-ID:Date:MIME-Version:To:From; b=JoAKtIXP4hVsvk85RzyftPBFQYDxslf8hMlipuuU8F7RoEL46OhDLAM6pv/jChX7a Fp4a49wyOeIUqcXuyYriKXeI9jiCT37j7riDJV0YxbJPdK/qS9W21IMkE9ZB6evVh5 vxyOl4hzeIlJENxyjTIOJMyGPYsFb9fYHJ6gWVX8= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <70d8e49c-df00-6243-f5f7-066dd56312f2@raptorengineering.com> Date: Tue, 1 Aug 2023 19:13:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/4] xen/ppc: Add PowerNV bare metal support Content-Language: en-US To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich References: From: Shawn Anastasio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/23 7:11 PM, Shawn Anastasio wrote: > Hello all, Apologies, the subject should indicate that this is a v2 but I forgot to pass the appropriate argument to git-send-email. Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:24:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:24:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574637.900100 (Exim 4.92) (envelope-from ) id 1qQzf9-0007eA-4t; Wed, 02 Aug 2023 00:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574637.900100; Wed, 02 Aug 2023 00:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzf9-0007e3-1t; Wed, 02 Aug 2023 00:24:27 +0000 Received: by outflank-mailman (input) for mailman id 574637; Wed, 02 Aug 2023 00:24:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQzf7-0007dx-JB for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:24:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed4fd8ac-30ca-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 02:24:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CC726177B; Wed, 2 Aug 2023 00:24:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF1A3C433C7; Wed, 2 Aug 2023 00:24:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed4fd8ac-30ca-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690935860; bh=IU56Re5B1oCRydK/QbSInlmtW9Qv3T7gpkgBQPxJCQU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=d9mPKEZerNrgr/GdxmP4WqxygB/gERXpg6z2H6N7n4neeyqvHW8q8j8v/7PAAXDrR bSDyjNovjASvQATQMlgpAanEF5C2wmYuI3bKhPU7Tmbi7FxQzvvs5i3zBjTjEgREMH HPeD4oHsn+NCofu/gWC6ebyPey3ubvKcDAxGDEMYE25fMoibKHFB/5+e2tuph2WRl3 t2cS8B4b8ECv6JONy1RhUZmniosWryR4Npy3qWetZ3uno6djoWB/yIGENmu9zE2vfo N2aK/kLmF2KLa0yid+NWD6+P/PRxIZyeydhpknL3kzo0wN2mRrI1/zu6g1lbqinM8s OHe9o+KM3UllQ== Date: Tue, 1 Aug 2023 17:24:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: xen-devel@lists.xenproject.org, xen-devel@dornerworks.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , roberto.bagnara@bugseng.com Subject: Re: [RFC 1/6] dom0: replace explict zero checks In-Reply-To: <20230801202006.20322-2-dpsmith@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Daniel P. Smith wrote: > A legacy concept is that the initial domain will have a domain id of zero. As a > result there are places where a check that a domain is the inital domain is > determined by an explicit check that the domid is zero. > > This commit seeks to abstract this check into a function call and replace all > check locations with the function call. > > Signed-off-by: Daniel P. Smith Thanks for the patch, this is a good cleanup! > --- > xen/common/domain.c | 4 ++-- > xen/common/sched/arinc653.c | 2 +- > xen/common/sched/core.c | 4 ++-- > xen/include/xen/sched.h | 7 +++++++ > 4 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 304aa04fa6..8fb3c052f5 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -309,7 +309,7 @@ static int late_hwdom_init(struct domain *d) > struct domain *dom0; > int rv; > > - if ( d != hardware_domain || d->domain_id == 0 ) > + if ( d != hardware_domain || is_initial_domain(d) ) > return 0; > > rv = xsm_init_hardware_domain(XSM_HOOK, d); > @@ -612,7 +612,7 @@ struct domain *domain_create(domid_t domid, > d->is_privileged = flags & CDF_privileged; > > /* Sort out our idea of is_hardware_domain(). */ > - if ( domid == 0 || domid == hardware_domid ) > + if ( is_initial_domain(d) || domid == hardware_domid ) > { > if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED ) > panic("The value of hardware_dom must be a valid domain ID\n"); > diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c > index a82c0d7314..31e8270af3 100644 > --- a/xen/common/sched/arinc653.c > +++ b/xen/common/sched/arinc653.c > @@ -404,7 +404,7 @@ a653sched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit, > * Add every one of dom0's units to the schedule, as long as there are > * slots available. > */ > - if ( unit->domain->domain_id == 0 ) > + if ( is_initial_domain(unit->domain) ) > { > entry = sched_priv->num_schedule_entries; > > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index 022f548652..210ad30f94 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -585,7 +585,7 @@ int sched_init_vcpu(struct vcpu *v) > */ > sched_set_affinity(unit, cpumask_of(0), cpumask_of(0)); > } > - else if ( d->domain_id == 0 && opt_dom0_vcpus_pin ) > + else if ( is_initial_domain(d) && opt_dom0_vcpus_pin ) > { > /* > * If dom0_vcpus_pin is specified, dom0 vCPUs are pinned 1:1 to > @@ -594,7 +594,7 @@ int sched_init_vcpu(struct vcpu *v) > sched_set_affinity(unit, cpumask_of(processor), &cpumask_all); > } > #ifdef CONFIG_X86 > - else if ( d->domain_id == 0 ) > + else if ( is_initial_domain(d) ) > { > /* > * In absence of dom0_vcpus_pin instead, the hard and soft affinity of > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index 854f3e32c0..a9276a7bed 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -1058,6 +1058,13 @@ void scheduler_disable(void); > void watchdog_domain_init(struct domain *d); > void watchdog_domain_destroy(struct domain *d); > > +static always_inline bool is_initial_domain(const struct domain *d) I know you used always_inline only because is_hardware_domain just below also uses it, but I wonder if we need it. Also, Robero, it looks like always_inline is missing from docs/misra/C-language-toolchain.rst? Or do we plan to get rid of it? > +{ > + static int init_domain_id = 0; I take it is done this way because you plan to make it configurable? > + return d->domain_id == init_domain_id; > +} > + > /* > * Use this check when the following are both true: > * - Using this feature or interface requires full access to the hardware > -- > 2.20.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:54:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574643.900109 (Exim 4.92) (envelope-from ) id 1qR08K-0002fb-ES; Wed, 02 Aug 2023 00:54:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574643.900109; Wed, 02 Aug 2023 00:54:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR08K-0002fU-Bn; Wed, 02 Aug 2023 00:54:36 +0000 Received: by outflank-mailman (input) for mailman id 574643; Wed, 02 Aug 2023 00:54:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR08J-0002fO-8I for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:54:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 242ecbf4-30cf-11ee-b25d-6b7b168915f2; Wed, 02 Aug 2023 02:54:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24A7D61781; Wed, 2 Aug 2023 00:54:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 297FEC433C8; Wed, 2 Aug 2023 00:54:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 242ecbf4-30cf-11ee-b25d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690937670; bh=kPIPs0tagdc7wz6cqm078wsT0VP4Nz7bEp25hTn+ynA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lngzkikAvDJmbubFKAzWHvjOPc6IjSc7iAoyxhdR7mMkwGaCFpw+aiH74wZlPxtk2 ekTUbGcQ+AF/y5Tm1cVAofeUOZvG1kKkroqMIgZzo75bL7orToucWfqvZrBWbFdfcW 3yQybtUYbBi0xQD94xF0woYiGbZl5gVyYO4vbR/iwOk6oJCNRCjITmWfPhC3oXeP8H zW8oZ4fyTuTYSwDxSGnG4BuILRYPVkT+Dr8yuvyT9lxDMh4BTd3WBeFvOnJL9JnssK oK4qybVevErV7TsIJpmsnYlyWZLNRwSKEN2rG6oJ1N9U44SDflKZodM09uHXT3PX8O s6hjVxW/ffoJg== Date: Tue, 1 Aug 2023 17:54:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles In-Reply-To: <20230801202006.20322-3-dpsmith@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Daniel P. Smith wrote: > The existing concepts such as unbounded domain, ie. all powerful, control > domain and hardware domain are, effectively, roles the domains provide for the > system. Currently, these are represented with booleans within `struct domain` > or global domid variables that are compared against. This patch begins to > formalize these roles by replacing the `is_control` and `is_console`, along > with expanding the check against the global `hardware_domain` with a single > encapsulating role attribute in `struct domain`. > > Signed-off-by: Daniel P. Smith This is definitely heading in the right direction > --- > xen/arch/arm/domain_build.c | 2 ++ > xen/arch/x86/setup.c | 2 ++ > xen/common/domain.c | 14 +++++++++++++- > xen/include/xen/sched.h | 16 +++++++++------- > xen/include/xsm/dummy.h | 4 ++-- > xen/xsm/flask/hooks.c | 12 ++++++------ > 6 files changed, 34 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 39b4ee03a5..51b4daefe1 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -4201,6 +4201,8 @@ void __init create_dom0(void) > if ( IS_ERR(dom0) ) > panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); > > + dom0->role |= ROLE_UNBOUNDED_DOMAIN; I am not a fan of "UNBOUNDED". Maybe "PRIMARY"? "PRIVILEGED"? "SUPER"? "ROOT"? I also recognize I am not good at naming things so I'll stop here and let other provide better feedback :-) Also, do we actually need unbounded given that it gets replaced with control_domain pretty soon? I am asking because I think that at least from a safety perspective it would be a problem to run a domain as "unbounded". In a safety system, we wouldn't want anything to be unbounded, not even temporarily at boot. If "unbounded" is removed before running dom0, then of course it is no problem because actually dom0 never gets to run with "unbounded" set. (I am currently thinking of solving the privilege issue by using XSM and removing most privileges from Dom0.) > if ( alloc_dom0_vcpu0(dom0) == NULL ) > panic("Error creating domain 0 vcpu0\n"); > > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 2dbe9857aa..4e20edc3bf 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const module_t *image, > if ( IS_ERR(d) ) > panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); > > + d->role |= ROLE_UNBOUNDED_DOMAIN; > + > init_dom0_cpuid_policy(d); > > if ( alloc_dom0_vcpu0(d) == NULL ) > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 8fb3c052f5..0ff1d52e3d 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) > setup_io_bitmap(dom0); > #endif > > + /* > + * "dom0" may have been created under the unbounded role, demote it from > + * that role, reducing it to the control domain role and any other roles it > + * may have been given. > + */ > + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); > + dom0->role |= ROLE_CONTROL_DOMAIN; I think we need a better definition of the three roles to understand what this mean. > rcu_unlock_domain(dom0); > > iommu_hwdom_init(d); > @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, > } > > /* Sort out our idea of is_control_domain(). */ > - d->is_privileged = flags & CDF_privileged; > + if ( flags & CDF_privileged ) > + d->role |= ROLE_CONTROL_DOMAIN; > + else > + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ > > /* Sort out our idea of is_hardware_domain(). */ > if ( is_initial_domain(d) || domid == hardware_domid ) > @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, > > old_hwdom = hardware_domain; > hardware_domain = d; > + d->role |= ROLE_HARDWARE_DOMAIN; > } > > TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index a9276a7bed..695f240326 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -467,8 +467,10 @@ struct domain > #endif > /* is node-affinity automatically computed? */ > bool auto_node_affinity; > - /* Is this guest fully privileged (aka dom0)? */ > - bool is_privileged; > +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) > +#define ROLE_CONTROL_DOMAIN (1U<<1) > +#define ROLE_HARDWARE_DOMAIN (1U<<2) This is a great step in the right direction but I think at least a short in-code comment to explain the difference between the three > + uint8_t role; > /* Can this guest access the Xen console? */ > bool is_console; > /* Is this guest being debugged by dom0? */ > @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); > > static always_inline bool is_initial_domain(const struct domain *d) > { > - static int init_domain_id = 0; > - > - return d->domain_id == init_domain_id; > + return d->role & ROLE_UNBOUNDED_DOMAIN; > } As far as I can tell this is the only functional change in this patch: given that dom0 loses unbounded soon after boot, the "is_initial_domain" checks will start to fail? We have a few of them in the code and I couldn't rule out that at least these 3 could happen at runtime: xen/common/sched/core.c: else if ( is_initial_domain(d) && opt_dom0_vcpus_pin ) xen/common/sched/core.c: else if ( is_initial_domain(d) ) xen/common/sched/arinc653.c: if ( is_initial_domain(unit->domain) ) Maybe they need to be changed to control_domain checks? > /* > @@ -1076,7 +1076,8 @@ static always_inline bool is_hardware_domain(const struct domain *d) > if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) > return false; > > - return evaluate_nospec(d == hardware_domain); > + return evaluate_nospec(((d->role & ROLE_HARDWARE_DOMAIN) || > + is_initial_domain(d)) && (d == hardware_domain)); > } > > /* This check is for functionality specific to a control domain */ > @@ -1085,7 +1086,8 @@ static always_inline bool is_control_domain(const struct domain *d) > if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) > return false; > > - return evaluate_nospec(d->is_privileged); > + return evaluate_nospec((d->role & ROLE_CONTROL_DOMAIN) || > + is_initial_domain(d)); > } > > #define VM_ASSIST(d, t) (test_bit(VMASST_TYPE_ ## t, &(d)->vm_assist)) > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 8671af1ba4..18f1ddd127 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -108,7 +108,7 @@ static XSM_INLINE int cf_check xsm_set_system_active(void) > { > struct domain *d = current->domain; > > - ASSERT(d->is_privileged); > + ASSERT(d->role & ROLE_CONTROL_DOMAIN); > > if ( d->domain_id != DOMID_IDLE ) > { > @@ -116,7 +116,7 @@ static XSM_INLINE int cf_check xsm_set_system_active(void) > return -EPERM; > } > > - d->is_privileged = false; > + d->role &= ~ROLE_CONTROL_DOMAIN; > > return 0; > } > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 78225f68c1..0a31719f43 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -193,7 +193,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) > default: > if ( domain_sid(current->domain) == SECINITSID_XENBOOT ) > { > - if ( d->is_privileged ) > + if ( d->role & ROLE_CONTROL_DOMAIN ) > dsec->sid = SECINITSID_DOM0; > else if ( pv_shim ) > dsec->sid = SECINITSID_DOMU; > @@ -213,7 +213,7 @@ static int cf_check flask_set_system_active(void) > > dsec = d->ssid; > > - ASSERT(d->is_privileged); > + ASSERT(d->role & ROLE_CONTROL_DOMAIN); > ASSERT(dsec->sid == SECINITSID_XENBOOT); > ASSERT(dsec->self_sid == SECINITSID_XENBOOT); > > @@ -224,11 +224,11 @@ static int cf_check flask_set_system_active(void) > } > > /* > - * While is_privileged has no significant meaning under flask, set to false > - * as is_privileged is not only used for a privilege check but also as a > - * type of domain check, specifically if the domain is the control domain. > + * While domain roles have no significant meaning under flask, mask out > + * control domain role as it is not only used for a privilege check but > + * also as a type of domain check. > */ > - d->is_privileged = false; > + d->role &= ~ROLE_CONTROL_DOMAIN; > > dsec->self_sid = dsec->sid = SECINITSID_XEN; > > -- > 2.20.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:55:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:55:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574646.900123 (Exim 4.92) (envelope-from ) id 1qR09c-0003GV-Q6; Wed, 02 Aug 2023 00:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574646.900123; Wed, 02 Aug 2023 00:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR09c-0003GO-My; Wed, 02 Aug 2023 00:55:56 +0000 Received: by outflank-mailman (input) for mailman id 574646; Wed, 02 Aug 2023 00:55:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR09a-0003G6-My; Wed, 02 Aug 2023 00:55:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR09a-0005C3-LO; Wed, 02 Aug 2023 00:55:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR09a-0005d4-7R; Wed, 02 Aug 2023 00:55:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qR09a-00053G-6x; Wed, 02 Aug 2023 00:55:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bJp0QIkUrB/CfwqBGyX9FGwTep4O3LnGVCaX622y4nQ=; b=6E/Xr/RKUd3gP25bPD9+MyMZ6o kN7tqXnshNtG4rP6g7YAy1XkXIAxkTgvGL/8nokQ5LnCK6ypiu1BOn7tTkrgHtpeT0SkF/MPjnwvT Mnd7+zz/saYaKm7TBFpMOp8BjrBXQPSJmbeS38oT1s1MrJzvIJYS/3/uTx9Fa5EWrO/Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 182093: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e05a0e65b09d8512fdf4881c7fae713045c7d83d X-Osstest-Versions-That: xen=faa4e2b1cf8022497a7b60c5b50a3bd280a5fc65 From: osstest service owner Date: Wed, 02 Aug 2023 00:55:54 +0000 flight 182093 xen-4.15-testing real [real] flight 182105 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182093/ http://logs.test-lab.xenproject.org/osstest/logs/182105/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 13 guest-start fail pass in 182105-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 182105 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 182105 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181995 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181995 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181995 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181995 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181995 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181995 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181995 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181995 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181995 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181995 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181995 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181995 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: xen e05a0e65b09d8512fdf4881c7fae713045c7d83d baseline version: xen faa4e2b1cf8022497a7b60c5b50a3bd280a5fc65 Last test of basis 181995 2023-07-24 16:37:09 Z 8 days Testing same since 182093 2023-07-31 13:06:54 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git faa4e2b1cf..e05a0e65b0 e05a0e65b09d8512fdf4881c7fae713045c7d83d -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 00:57:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 00:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574653.900135 (Exim 4.92) (envelope-from ) id 1qR0BI-0003vC-Br; Wed, 02 Aug 2023 00:57:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574653.900135; Wed, 02 Aug 2023 00:57:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR0BI-0003v5-7W; Wed, 02 Aug 2023 00:57:40 +0000 Received: by outflank-mailman (input) for mailman id 574653; Wed, 02 Aug 2023 00:57:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR0BG-0003ux-6N for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 00:57:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9217e946-30cf-11ee-b25d-6b7b168915f2; Wed, 02 Aug 2023 02:57:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECCED6176D; Wed, 2 Aug 2023 00:57:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2607AC433C8; Wed, 2 Aug 2023 00:57:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9217e946-30cf-11ee-b25d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690937855; bh=BfGIuwpRCN4qhBSwEVz0f3fnhIPy1Gr2sJI264ojiNE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ofNyJD9I3d+T3Ng/0MZYU3mcPbRvx8rNXtFv7k9gErQ4LmNHM8PqdQJcZX+kKYTbs 53RBLMWKWTML+v3Cu2ZxYpdKnx8XQR8p/yyo4/3LJJIE/q20kq26vK5Fsr+A5ok6xa yWjKs864IStLwjBHFMrksn9eQhNoxk9ptRlFv1DrfPGCz/0pG5MuYjGj0XTUaAYZQ4 qODZ+yet4Sb1vH2Yb3Ef41ddsRyW4wE9nEs3qjr1RuocNXAlhl8oVpBZIpJADBT3Vn USDvJZEsfRnH1barv2YGcP0uv6YAmDT3CrTkKHq35mXS/n2Et/ucdsUyyr/81nFNpD 3yG3x2vYT175A== Date: Tue, 1 Aug 2023 17:57:32 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [RFC 3/6] roles: add a role for xenstore domain In-Reply-To: <20230801202006.20322-4-dpsmith@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-4-dpsmith@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Daniel P. Smith wrote: > Expand the possible roles for a domain to include a role for the Xenstore > domain. > > Signed-off-by: Daniel P. Smith Reviewed-by: Stefano Stabellini > --- > xen/common/domain.c | 3 +++ > xen/include/xen/sched.h | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 0ff1d52e3d..dbf055c559 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -633,6 +633,9 @@ struct domain *domain_create(domid_t domid, > d->role |= ROLE_HARDWARE_DOMAIN; > } > > + if ( d->options & XEN_DOMCTL_CDF_xs_domain ) > + d->role |= ROLE_XENSTORE_DOMAIN; > + > TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); > > lock_profile_register_struct(LOCKPROF_TYPE_PERDOM, d, domid); > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index 695f240326..ec0f9baff6 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -470,6 +470,7 @@ struct domain > #define ROLE_UNBOUNDED_DOMAIN (1U<<0) > #define ROLE_CONTROL_DOMAIN (1U<<1) > #define ROLE_HARDWARE_DOMAIN (1U<<2) > +#define ROLE_XENSTORE_DOMAIN (1U<<3) > uint8_t role; > /* Can this guest access the Xen console? */ > bool is_console; > @@ -1165,7 +1166,7 @@ static inline bool is_vcpu_online(const struct vcpu *v) > > static inline bool is_xenstore_domain(const struct domain *d) > { > - return d->options & XEN_DOMCTL_CDF_xs_domain; > + return d->role & ROLE_XENSTORE_DOMAIN; > } > > static always_inline bool is_iommu_enabled(const struct domain *d) > -- > 2.20.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 02 01:01:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 01:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574659.900144 (Exim 4.92) (envelope-from ) id 1qR0FM-00079G-Qt; Wed, 02 Aug 2023 01:01:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574659.900144; Wed, 02 Aug 2023 01:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR0FM-00078h-O6; Wed, 02 Aug 2023 01:01:52 +0000 Received: by outflank-mailman (input) for mailman id 574659; Wed, 02 Aug 2023 01:01:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR0FM-0006sE-7Q for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 01:01:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28ac7f5a-30d0-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 03:01:49 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AEC461781; Wed, 2 Aug 2023 01:01:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB19C433C7; Wed, 2 Aug 2023 01:01:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28ac7f5a-30d0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690938107; bh=b8ZTI0DUyypX2jJSHtf2hriCyizM8M3M0RYQ+M4v/YA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=A7kTImnC2LsEX0aY+x2+ZLnBYazmGEpgL2PlR6uND+YzoC6ZaBWOnST7EMeJtaGMH jTR+336XRJo6pVtBMutRIooXSS6dgNvpXppd9O9mUoeHCK1o/lsnZNACBkWVnJBx7M /4pVtFtuMa21J50jCvvk0T4ee5dkfANUfGiOgaIuDfMrAWBQ5HteBhX6prUCfu3iYa yYp0o3GKPl6jpJ9uw4irXl2EJ8lJ6TDK/t1ZHJ04VDFC1uXm176M90gauxp/EctY3q HZaaDxiH8i3EqPF6z/3++yhIHvzQy1TW+T+nE+SlBee+x/2qhbKSZWLalFl02Dk7AO +X2si9ICrZx1A== Date: Tue, 1 Aug 2023 18:01:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Volodymyr Babchuk , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability In-Reply-To: <20230801202006.20322-5-dpsmith@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Daniel P. Smith wrote: > The field `is_console` suggests that the field represents a state of being or > posession, not that it reflects the privilege to access the console. In this ^ possession > patch the field is renamed to capabilities to encapsulate the capabilities a > domain has been granted. The first capability being the ability to read/write > the Xen console. > > Signed-off-by: Daniel P. Smith Patch looks fine to me aside the two minor nits. I am not sure I understand 100% the difference between capabilities and roles but I am OK with the patch. I'd like to hear Julien's feedback on this as well. > --- > xen/arch/arm/domain_build.c | 4 +++- > xen/include/xen/sched.h | 25 +++++++++++++++++++++++-- > xen/include/xsm/dummy.h | 2 +- > 3 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 51b4daefe1..ad7432b029 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -4076,7 +4076,9 @@ void __init create_domUs(void) > panic("Error creating domain %s (rc = %ld)\n", > dt_node_name(node), PTR_ERR(d)); > > - d->is_console = true; > + if ( ! domain_set_cap(d, CAP_CONSOLE_IO) ) code style > + printk("failed setting console_io on %pd\n", d); > + > dt_device_set_used_by(node, d->domain_id); > > rc = construct_domU(d, node); > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index ec0f9baff6..b04fbe0565 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -472,8 +472,8 @@ struct domain > #define ROLE_HARDWARE_DOMAIN (1U<<2) > #define ROLE_XENSTORE_DOMAIN (1U<<3) > uint8_t role; > - /* Can this guest access the Xen console? */ > - bool is_console; > +#define CAP_CONSOLE_IO (1U<<0) > + uint8_t capabilities; > /* Is this guest being debugged by dom0? */ > bool debugger_attached; > /* > @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const struct vcpu *v) > return is_hvm_domain(v->domain); > } > > +static always_inline bool domain_has_cap( > + const struct domain *d, uint8_t cap) > +{ > + return d->capabilities & cap; > +} > + > +static always_inline bool domain_set_cap( > + struct domain *d, uint8_t cap) > +{ > + switch ( cap ) > + { > + case CAP_CONSOLE_IO: > + d->capabilities |= cap; > + break; > + default: > + return false; > + } > + > + return domain_has_cap(d, cap); > +} > + > static always_inline bool hap_enabled(const struct domain *d) > { > /* sanitise_domain_config() rejects HAP && !HVM */ > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 18f1ddd127..067ff1d111 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -268,7 +268,7 @@ static XSM_INLINE int cf_check xsm_console_io( > XSM_DEFAULT_ARG struct domain *d, int cmd) > { > XSM_ASSERT_ACTION(XSM_OTHER); > - if ( d->is_console ) > + if ( domain_has_cap(d, CAP_CONSOLE_IO) ) > return xsm_default_action(XSM_HOOK, d, NULL); > #ifdef CONFIG_VERBOSE_DEBUG > if ( cmd == CONSOLEIO_write ) > -- > 2.20.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 02 01:06:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 01:06:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574663.900154 (Exim 4.92) (envelope-from ) id 1qR0K7-0001tl-Cv; Wed, 02 Aug 2023 01:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574663.900154; Wed, 02 Aug 2023 01:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR0K7-0001td-9C; Wed, 02 Aug 2023 01:06:47 +0000 Received: by outflank-mailman (input) for mailman id 574663; Wed, 02 Aug 2023 01:06:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR0K6-0001tX-8z for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 01:06:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7b7b512-30d0-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 03:06:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42D266177D; Wed, 2 Aug 2023 01:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43283C433C8; Wed, 2 Aug 2023 01:06:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7b7b512-30d0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690938401; bh=kd4wYEFviwXVQfwPUHkNXQA46VC++kHg1EJl8BsckaQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=iedw+7pKxOjwZXGBUB76zAplcVmUjyPWOgcirxKap3r3xkLaPXCW8C2ebu2uunaDf SORKjJ8elixUdyr90/n+O11b4OaPsZYJLhz3jIJnWJIQEqtAdClwloYsHu4dCTMbv0 OYK43E4sdHJgNt6c3UIHkYo/8VOhaEUAADzJBi738APvA3Nsvto0cfcUG5Ic+A3hUw IKii6q2VOj0QFsEZFrXvSmaKqyNtUNcVU9Njq4zDPeBV8nPZ0lWhO17hjhDgI4TF7K LBSPN7ZDE8+FmgSCTv/mQHwBsZlZJr9hFsnT4QSHL+IKteK7Di5J+jja2ljEaL4Hat reQJLZSEHQomA== Date: Tue, 1 Aug 2023 18:06:39 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Wei Liu , xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian Subject: Re: [RFC 6/6] capabilities: convert attach debugger into a capability In-Reply-To: <20230801202006.20322-7-dpsmith@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-7-dpsmith@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 1 Aug 2023, Daniel P. Smith wrote: > Expresses the ability to attach a debugger as a capability that a domain can be > provisioned. > > Signed-off-by: Daniel P. Smith > --- > xen/arch/x86/hvm/svm/svm.c | 8 ++++---- > xen/arch/x86/hvm/vmx/realmode.c | 2 +- > xen/arch/x86/hvm/vmx/vmcs.c | 2 +- > xen/arch/x86/hvm/vmx/vmx.c | 10 +++++----- > xen/arch/x86/traps.c | 6 ++++-- > xen/common/domctl.c | 6 ++++-- > xen/include/xen/sched.h | 9 ++++++--- > 7 files changed, 25 insertions(+), 18 deletions(-) > > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c > index 27170213ae..9872804d39 100644 > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -999,7 +999,7 @@ static void noreturn cf_check svm_do_resume(void) > { > struct vcpu *v = current; > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > - bool debug_state = (v->domain->debugger_attached || > + bool debug_state = (domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) || > v->domain->arch.monitor.software_breakpoint_enabled || > v->domain->arch.monitor.debug_exception_enabled); > bool_t vcpu_guestmode = 0; > @@ -1335,7 +1335,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) > } > /* fall through */ > case X86_EXC_BP: > - if ( curr->domain->debugger_attached ) > + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) > { > /* Debug/Int3: Trap to debugger. */ > domain_pause_for_debugger(); > @@ -2732,7 +2732,7 @@ void svm_vmexit_handler(void) > > case VMEXIT_ICEBP: > case VMEXIT_EXCEPTION_DB: > - if ( !v->domain->debugger_attached ) > + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > unsigned int trap_type; > > @@ -2769,7 +2769,7 @@ void svm_vmexit_handler(void) > if ( insn_len == 0 ) > break; > > - if ( v->domain->debugger_attached ) > + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > /* AMD Vol2, 15.11: INT3, INTO, BOUND intercepts do not update RIP. */ > __update_guest_eip(regs, insn_len); > diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c > index ff44ddcfa6..f761026a9d 100644 > --- a/xen/arch/x86/hvm/vmx/realmode.c > +++ b/xen/arch/x86/hvm/vmx/realmode.c > @@ -121,7 +121,7 @@ void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt) > > if ( rc == X86EMUL_EXCEPTION ) > { > - if ( unlikely(curr->domain->debugger_attached) && > + if ( unlikely(domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH)) && > ((hvmemul_ctxt->ctxt.event.vector == X86_EXC_DB) || > (hvmemul_ctxt->ctxt.event.vector == X86_EXC_BP)) ) > { > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index 13719cc923..9474869018 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -1912,7 +1912,7 @@ void cf_check vmx_do_resume(void) > hvm_asid_flush_vcpu(v); > } > > - debug_state = v->domain->debugger_attached > + debug_state = domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) > || v->domain->arch.monitor.software_breakpoint_enabled > || v->domain->arch.monitor.singlestep_enabled; > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index 7ec44018d4..5069e3cbf3 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2041,7 +2041,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) > break; > /* fall through */ > case X86_EXC_BP: > - if ( curr->domain->debugger_attached ) > + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) > { > /* Debug/Int3: Trap to debugger. */ > domain_pause_for_debugger(); > @@ -2121,7 +2121,7 @@ static void cf_check vmx_set_info_guest(struct vcpu *v) > * immediately vmexit and hence make no progress. > */ > __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); > - if ( v->domain->debugger_attached && > + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) && > (v->arch.user_regs.eflags & X86_EFLAGS_TF) && > (intr_shadow & VMX_INTR_SHADOW_STI) ) > { > @@ -4283,7 +4283,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > } > } > > - if ( !v->domain->debugger_attached ) > + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > unsigned long insn_len = 0; > int rc; > @@ -4307,7 +4307,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > break; > case X86_EXC_BP: > HVMTRACE_1D(TRAP, vector); > - if ( !v->domain->debugger_attached ) > + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > unsigned long insn_len; > int rc; > @@ -4647,7 +4647,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > HVM_MONITOR_SINGLESTEP_BREAKPOINT, > 0, 0, 0); > > - if ( v->domain->debugger_attached ) > + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > domain_pause_for_debugger(); > } > > diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c > index 4229bda159..041ced35ea 100644 > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -1214,7 +1214,8 @@ void do_int3(struct cpu_user_regs *regs) > return; > } > > - if ( guest_kernel_mode(curr, regs) && curr->domain->debugger_attached ) > + if ( guest_kernel_mode(curr, regs) && > + domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) > { > curr->arch.gdbsx_vcpu_event = X86_EXC_BP; > domain_pause_for_debugger(); > @@ -1995,7 +1996,8 @@ void do_debug(struct cpu_user_regs *regs) > v->arch.dr6 |= (dr6 & ~X86_DR6_DEFAULT); > v->arch.dr6 &= (dr6 | ~X86_DR6_DEFAULT); > > - if ( guest_kernel_mode(v, regs) && v->domain->debugger_attached ) > + if ( guest_kernel_mode(v, regs) && > + domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > domain_pause_for_debugger(); > return; > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 505e29c0dc..895ddf0600 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -99,7 +99,8 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) > ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying : 0) | > (d->is_shut_down ? XEN_DOMINF_shutdown : 0) | > (d->controller_pause_count > 0 ? XEN_DOMINF_paused : 0) | > - (d->debugger_attached ? XEN_DOMINF_debugged : 0) | > + (domain_has_cap(d, CAP_DEBUGGER_ATTACH) ? > + XEN_DOMINF_debugged : 0) | > (is_xenstore_domain(d) ? XEN_DOMINF_xs_domain : 0) | > (is_hvm_domain(d) ? XEN_DOMINF_hvm_guest : 0) | > d->shutdown_code << XEN_DOMINF_shutdownshift; > @@ -643,7 +644,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > else > { > domain_pause(d); > - d->debugger_attached = !!op->u.setdebugging.enable; > + if ( !!op->u.setdebugging.enable ) > + domain_set_cap(d, CAP_DEBUGGER_ATTACH); > domain_unpause(d); /* causes guest to latch new status */ > } > break; > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index ebfe65cd73..47eadb5008 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -474,9 +474,8 @@ struct domain > uint8_t role; > #define CAP_CONSOLE_IO (1U<<0) > #define CAP_DISABLE_CPU_FAULT (1U<<1) > - uint8_t capabilities; > - /* Is this guest being debugged by dom0? */ > - bool debugger_attached; > +#define CAP_DEBUGGER_ATTACH (1U<<2) > + uint16_t capabilities; No need to switch to uint16_t just yet? > /* > * Set to true at the very end of domain creation, when the domain is > * unpaused for the first time by the systemcontroller. > @@ -1166,6 +1165,10 @@ static always_inline bool domain_set_cap( > if ( is_pv_domain(d) && is_control_domain(d) ) > d->capabilities |= cap; > break; > + case CAP_DEBUGGER_ATTACH: > + if ( !is_control_domain(d) ) > + d->capabilities |= cap; I take it is not possible to attach it to dom0? I am not familiar with XEN_DOMCTL_setdebugging but the hypercall doesn't seem to have such restriction. > + break; > default: > return false; > } > -- > 2.20.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 02 02:33:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 02:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574670.900164 (Exim 4.92) (envelope-from ) id 1qR1fK-000329-Ai; Wed, 02 Aug 2023 02:32:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574670.900164; Wed, 02 Aug 2023 02:32:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR1fK-000321-66; Wed, 02 Aug 2023 02:32:46 +0000 Received: by outflank-mailman (input) for mailman id 574670; Wed, 02 Aug 2023 02:32:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR1fJ-00031r-2c; Wed, 02 Aug 2023 02:32:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR1fI-0003xh-Vu; Wed, 02 Aug 2023 02:32:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR1fI-0008Tr-Dh; Wed, 02 Aug 2023 02:32:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qR1fI-0003xz-DA; Wed, 02 Aug 2023 02:32:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l4y6Y1WbLh21+OiA1WEF39hIpV24kTzlhp5dnv0XikI=; b=dBqW+4lb0GdDtLi+vNTN0FSKVg jAOcXztWQKFO4G5BS6+ZqZOOy5rMbGGGTR31she1BRSWOkfqw9qrNqWKaWz8uhIgzi2p+7AVgk9/I ykQj9n1tRT4XqNigzKkhyVXTqrWZ7C7+0U2O2/Nze0VYPcaJOcAzlFSmkTksVfvLuLlo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 182094: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a910e3f2a4d128bc045ac6be374459e73ddf9fde X-Osstest-Versions-That: xen=82c5ab6be04a1f5544e38ed5198e79b91cecac45 From: osstest service owner Date: Wed, 02 Aug 2023 02:32:44 +0000 flight 182094 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182094/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 181998 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 181998 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181998 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 181998 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 181998 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181998 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 181998 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181998 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 181998 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 181998 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181998 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181998 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen a910e3f2a4d128bc045ac6be374459e73ddf9fde baseline version: xen 82c5ab6be04a1f5544e38ed5198e79b91cecac45 Last test of basis 181998 2023-07-24 16:37:44 Z 8 days Testing same since 182094 2023-07-31 13:07:24 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 82c5ab6be0..a910e3f2a4 a910e3f2a4d128bc045ac6be374459e73ddf9fde -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 03:59:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 03:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574680.900178 (Exim 4.92) (envelope-from ) id 1qR31B-000361-Mg; Wed, 02 Aug 2023 03:59:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574680.900178; Wed, 02 Aug 2023 03:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR31B-00035u-Jk; Wed, 02 Aug 2023 03:59:25 +0000 Received: by outflank-mailman (input) for mailman id 574680; Wed, 02 Aug 2023 03:59:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR319-00035o-W2 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 03:59:24 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20625.outbound.protection.outlook.com [2a01:111:f400:7eaf::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f558cc07-30e8-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 05:59:20 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB7600.eurprd08.prod.outlook.com (2603:10a6:102:23f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Wed, 2 Aug 2023 03:59:14 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 03:59:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f558cc07-30e8-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQ7hy4kt3MOBvJpIkl2UMzoPI11BxW+LEYL7nLhX2dzYc62LJy7dqM6AVLWkXFTmO3JOTaEfQAj8akwvJFJ/Ne5EHf5oiNSrJngSTbuuxyeW+FM6N1zi2Js8FsjgBhuaS5URaZ9LuRvU/W9pE6IG1P5BFdGEJEaWQlDDM/NPqOcfPRNIi3CzZSF2gtowbsJOJbKx0LcGgmkZIAzWSgXdOdAeNAyz434iVqcvoRcuOOWRsp8Ctj+s1PUx1KSRVYZL+/+TCL3r36C/HR6xrZGivIjM4hThDKi7B4DZ2qQRdKvel1wgHo/MoRrIP259msv2+DMylwccdL2en1yANiqv2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6pPRehJouAJ14zJDuwpjJGN2EJjKr4+iWJK4Lzd6pvo=; b=FQbnyT2UIqcHPOnjV6Wkko5BX30HKGG2UdBc4eDPfpUUMuYNuylbCoTgRz8L4Q8y8/wAC93BhKgUWIBLw6+TevFIqv6w3mLK7NUcAZJiC74XS8MK07eWoJ6SFL9qZx9IgEaPiqF1CKQEnJcqdeJu9cH3bDoABZgnEHYbN/lZ1eMcGHU0KB5zGmk/66klfsj+j3921dpM4IT4ylvf3qc/nCyLXuzFa9+4dHYjOY8MB/tbZpR5bLyQ4ZDqrLLdLEUoR01sNQcRty3pf3VbXaXQ0oGiXSxLIDb11nOFkzNijv6ryBClRMpDLIi+e5EzAFHhi9Uv7bxMI0vrcwXCXpGf1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6pPRehJouAJ14zJDuwpjJGN2EJjKr4+iWJK4Lzd6pvo=; b=2nU79hqxnjNUvZHsMg3B9B1HavxpuhRCrHKHSE6Q7uYaexi03A+2MJAv/s6XyZRQkr2bmwqfwwf1pbOpIo0EnEw/sjJ3l+LHI/ArZ/cCcY45S78FYY7BUuikJX20/UEwQ0ulUG3a/0qeufdJa1jvpAO7JOEnpuK/etLykLDW4+4= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Jan Beulich , Paul Durrant , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: RE: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work Thread-Topic: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work Thread-Index: AQHZxCqGkXVqhatOiEqMa3qeqTOTXK/VHIIAgAEp0BA= Date: Wed, 2 Aug 2023 03:59:13 +0000 Message-ID: References: <20230801034419.2047541-1-Henry.Wang@arm.com> <4f43b069-cb78-f356-628e-29b8ca8e595a@xen.org> In-Reply-To: <4f43b069-cb78-f356-628e-29b8ca8e595a@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 58B84113F4AF0842A5BDAB482C07EBBD.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB7600:EE_ x-ms-office365-filtering-correlation-id: 34db764c-15e7-41bc-5b64-08db930cd5ce nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FE8jbiYZBprAVeR7Znv4/ZhdJceTwE3/fyLXCRLrGb+vmICmW3mP0l/QZK4JMgey8NO1svGML/NMONfL9h3IQlBJ5b7RdF9Wy0OapW3oofPxjPVEo3f+Dxi+6olJytBkO3k0IMWSmnSMGHhVfrkfkQus8woxc9vv3zDCGVMdUFv+ofqSAabgLY99eHc8BwY1ZaEVkYWAgHXZUQsb8MS8dGwxXj5+0Wj5muWj2yvVlcmuMRPc2jG8IxHnV6FAq0YfWGSXwM4+EQ1hEhZzelFIqBFW3U1dysTRbJxMKPwQRbxDoMNynwyXW7sD2T73wATGYJzU+AYSouDoMzO8lzPvHz2QDYMcgI6SFWj1yePXyZXzUWNuGGcPyng7uJqIkZwU47F7uMBv2sW5AnGwcyC0Y44Ak6lYJrw3Z0U07jXsNIR3sDDb2cN68fcN1DeHRCwa9QHgjg91q+CeXZWnFDR0njakQM4KHbNiQ71JfkwEl9f+ZE+xtVVBtfEex4rtDBrIIB3i8MSFFQfWPInCnVgeGkQDSq9qrwPphbG3lswgjEoXToeYClPgSLntyv2eqhsoRP0efxWRgOSVaRVNEdD4bE4D3qr21qEOHzkm2ObRMp/wHKQsXkA/l+OM1maw2NYy56iel1x7ISxPdJDo8unFeQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(451199021)(38070700005)(2906002)(4326008)(83380400001)(41300700001)(186003)(86362001)(316002)(478600001)(38100700002)(76116006)(9686003)(966005)(122000001)(110136005)(54906003)(52536014)(55016003)(5660300002)(66556008)(66476007)(66446008)(53546011)(64756008)(71200400001)(33656002)(26005)(6506007)(8676002)(66946007)(8936002)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cUQrZkRZZlB1R3crYnVxTmNDd3JMVjVZcjZZRVJZMDhzQTY3ci9UMEV3R3dJ?= =?utf-8?B?OUFRVTRSV3JDNmNGSU9JWTgyZjR4cURRL3duS0ZZakVRNmxRNHFPN1k2bXlp?= =?utf-8?B?aVYyVmtIc20yQktyNW8vMnp4ZU0yUGFjWFJMS2twS0wyWEdnQUd0ZDZxK1BV?= =?utf-8?B?bWI5dU5mRGR2OC9vdEp0OWQvL2FocElpdUV5SUtBWjhweGRkYW1ucVZ1elk1?= =?utf-8?B?Q0E1eFh3a0RVK1NjNTVXSmk3RlFWcWNiVXpPNTRqQlorb0gwYVJSVk5yYlAr?= =?utf-8?B?K1RFZitDKzFmMEczV0hvdGRYRTY1YTdRZHMvRStwTVlSZFEwY0RWTTlCbXMx?= =?utf-8?B?d2wxSjQveCsxSFM1K1RhaVZYRFFsTU1IeFh1OVNIM25aLzlJNFVzeEFoSUFV?= =?utf-8?B?cXd0cFBoNlFxcUJCeTRIZGk0OUFPK0hIZng2SnE2UjF2QWJzZ0FKc2IvaXlo?= =?utf-8?B?Uk5Ja3JjNDcrVzF0R3NhWklXZHRlZjJ1TDR3YXplcVZVRFBxN3A3TWZtb3ll?= =?utf-8?B?NE43NjN2amZXWlhhSVZWQm9hRFBBVEs3RVNCc0hnQ3N6dDFHcXhLTWdFeTV2?= =?utf-8?B?b1E5U3NpR3dGS0NhTnVCdjkwT0ZtSVFQQkJENGp4VjV4SSszaEZRWlU0YTFV?= =?utf-8?B?S3VRNjhKU0hQWnVTRW9IRmptTGJGemJwc2VlWVBsYnhQczAxbTVDTGdMZzVq?= =?utf-8?B?OGdDOUhEd0d2TGIrdG5wd1ZFUHk0VU5jVVZEVEZVQUQvV1NERjJnNGdKdmhH?= =?utf-8?B?TExDbUplSlEwQ1BvWU8zTDJCeWo3eXNWU2YvZG8zdDM2d0RsZEc4RXk1U2Q5?= =?utf-8?B?cmEybFp2dGNSWjBTWE5INzFMMTJ2cVFwd09NWm5odDFtZVRRVDJuenpXdnlK?= =?utf-8?B?eDZjSWxONEc2N3dIUERtbEhLSlFVMDdoOTJCVm9Wekdacm5sS3k5T25Mc2lN?= =?utf-8?B?MTZZWlNlZ2NjcDZnOVFsQS9KaFFvWWdJR0hMVXRDK1grK2U5eHU5d1EvNm1W?= =?utf-8?B?cjd3Tkp2Nk5IOGdjVHlCcTBYN3BGa0xQbXJwemF3TTVnYW42dGUrVWp3NXJV?= =?utf-8?B?V2VTcnMyZEtUVGM2eWlJRFlZNGs5VG1qSWFaV0FHeHFVVUNQbmZuNmpuT2hV?= =?utf-8?B?VW5mWTJsUXIxMzhyTW9pZmxOOTFpUWMwNzhyNFFpcWc0VkpWZ1ZHUnEyODFT?= =?utf-8?B?Skp0cDVvZURleFptNjFKcVR3Z2xsOXRuVDBISXJYb3hON0E5R1FGSjNsNU4x?= =?utf-8?B?N2dRazJlQUVZblhpMGVkbjJhL3FQNUF0anFmeWgxSGVPY0h4YmRxY2NpRWJH?= =?utf-8?B?aER3V2NTR0ovYlNGQjczeFNDaXArUUxTaG01VFNqZkVOeGtaZENUTmR6MDYy?= =?utf-8?B?YTZQanEzZHBvMHZkOUhjK2pNSStVTGtKTXhNMms1bThzcENpbkxSd1ZWbFk3?= =?utf-8?B?THpCS0tXQXBMK1lCQ1JUOGZnN2VOTVRyRVdGTmJ5aDkwbzFvN3JzcnR4di9t?= =?utf-8?B?b1ZQbjdKOTZaSmJOU2d2cnE5QUl5bHV6V1M4L1JKUm9WNkthM09LTEdIQmtx?= =?utf-8?B?U25pVnp6N2d3TVVCci9WcWVPNURQeXIzbm9BdC9Fc1FMZjFyU21LWVBzanVt?= =?utf-8?B?UXNOeGxvZjY5RU9EbkFFSEVTc1l3T1IyUzJZTXNibjFoelRVUGQ1UDBtUDlQ?= =?utf-8?B?NDBKK2oxVEpSRTNUOHkxOXdPdnQwWHJncjVRdS94djFJVTN4ZHdsS0JRNm9p?= =?utf-8?B?RXZUcGYvczRQNVVMa2U0UHNySSs2Tm9ESW5vbU95OGZqZlozWDRpRFk4dTJY?= =?utf-8?B?emNoTTdHMXc1VDArVGs4Z2t5ZjUzT3BQRHRRTTRrZWdqd0NsYjlPaTFYS29h?= =?utf-8?B?STVFSzJiWWhqTmlBc04rcDJRQjRwYnZKNGFXdzVZZVFUOVJTZ0g3OWZYR3Bm?= =?utf-8?B?OXB4bGpJV1lBNXpPdlA5RnQ3UjhhRWorbnlKUGhyL3dyVmtyQmZMZGk2Sng2?= =?utf-8?B?dkc2Zit3eU5DbFNxcmNVOXlkNm5DQ25GVWl3SmRlM3V6QWZ2elFlUVRhSWw2?= =?utf-8?B?TFErNGVEWk83TU1tRk5YOFZKcWdFMFdLYXJaUHZncSswYUpmOEREUjFXelZj?= =?utf-8?Q?7e4RhziraehqxF+GqC1Bss9Bx?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34db764c-15e7-41bc-5b64-08db930cd5ce X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 03:59:13.8773 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5oU959sPJojez4nd8VwQsRHgN7ok1uc5twUSx3vQjOKuTwfm6PgJAyQsddx6j99rlAwepVH+OZUIEv2d2K65yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7600 SGkgSnVsaWVuLA0KDQpUaGFua3MgZm9yIHlvdXIgcHJvbXB0IHJlc3BvbnNlIGFuZCB5b3VyIHRp bWUgb24gdGhlIHJldmlldyENCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY0 IDAwLzEzXSB4ZW4vYXJtOiBTcGxpdCBNTVUgY29kZSBhcyB0aGUgcHJlcHJhdGlvbiBvZg0KPiBN UFUgd29yaw0KPiANCj4gSGksDQo+IA0KPiBPbiAwMS8wOC8yMDIzIDA0OjQ0LCBIZW5yeSBXYW5n IHdyb3RlOg0KPiA+IEJhc2VkIG9uIHRoZSBkaXNjdXNzaW9uIGluIHRoZSBYZW4gU3VtbWl0IFsx XSwgc2VuZGluZyB0aGlzIHNlcmllcyBvdXQgYWZ0ZXINCj4gPiBhZGRyZXNzaW5nIHRoZSBjb21t ZW50cyBpbiB2MyBbMl0gYXMgdGhlIHByZXBhcmF0aW9uIHdvcmsgdG8gYWRkIE1QVQ0KPiBzdXBw b3J0Lg0KPiA+DQo+ID4gTW9zdGx5IGNvZGUgbW92ZW1lbnQsIHdpdGggc29tZSBvZiBLY29uZmln IGFuZCBidWlsZCBzeXN0ZW0gKG1haW5seQ0KPiBNYWtlZmlsZXMpDQo+ID4gYWRqdXN0bWVudC4g Tm8gZnVuY3Rpb25hbCBjaGFuZ2UgZXhwZWN0ZWQuDQo+IA0KPiBJIGNhbid0IHJlYWxseSByZXZp ZXcgdGhpcyBzZXJpZXMgd2l0aG91dCBrbm93aW5nIGhvdyB0aGlzIHdpbGwNCj4gaW50ZWdyYXRl IHdpdGggdGhlIHJlc3Qgb2YgdGhlIE1QVSB3b3JrLiANCg0KU29ycnkgYWJvdXQgaXQsIEkgc2hv dWxkIGhhdmUgYXNrZWQgYmVmb3JlIHNlbmRpbmcgdGhlIHNlcmllcy4NCg0KPiBDYW4geW91IGF0 IGxlYXN0IHByb3ZpZGUgYSB0cmVlDQo+IHdpdGggYWxsIHRoZSBwYXRjaGVzIGFwcGxpZWQgKGlu Y2x1ZGluZyB0aGUgTVBVIG9uZSk/DQoNClNlZSBbMV0gZm9yIHRoZSBmdWxsIHNpbmdsZSBjb3Jl IE1QVSBpbXBsZW1lbnRhdGlvbiB3aGljaCBJJ3ZlIHZlcmlmaWVkDQpsb2NhbGx5IGFib3V0IHRo ZSBNTVUgYW5kIE1QVSBzaW5nbGUgY29yZSBMaW51eCBib290IG9uIEZWUCwgYW5kDQpsb29rcyBs aWtlIEdpdGxhYiBpcyBhbHNvIG5vdCBjb21wbGFpbmluZyBbMl0uDQoNCk5vdGUgdGhhdCBJJ3Zl IGFkZHJlc3NlZCBjb21tZW50cyBmcm9tIHlvdSBhbmQgQXlhbiBpbiB2MyBhYm91dCB0aGUNCk1N VS9NUFUgaGVscGVycyBkdXBsaWNhdGlvbiBhbmQgdGhlIGFybTMyL2FybTY0IHNwbGl0IHdvcmsu IEkgZGlkbid0DQphZGRyZXNzIHRoZSBjb21tZW50IGluIFszXSBhYm91dCB0aGUgUkVTMCBzdHVm ZiwgYnV0IEkgdGhpbmsgdGhpcyBpcyBub3QNCnJlbGF0ZWQgdG8gdGhlIE1NVSBzcGxpdCBzZXJp ZXMgSSBzZW50IHllc3RlcmRheSB0byBtYWlsaW5nIGxpc3QgYW5kIHRoZQ0KZm9ybWFsIHY0IE1Q VSB3b3JrIHNlbnQgdG8gdGhlIG1haWxpbmcgbGlzdCB3aWxsIGNvbnRhaW4gdGhlIGZpeCBmb3Ig dGhpcw0KY29tbWVudC4NCg0KWzFdIGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9w bGUvaGVucnl3L3hlbi8tL2NvbW1pdHMvbXB1X3Y0DQpbMl0gaHR0cHM6Ly9naXRsYWIuY29tL3hl bi1wcm9qZWN0L3Blb3BsZS9oZW5yeXcveGVuLy0vcGlwZWxpbmVzLzk1Mjc0MjAyNQ0KWzNdIGh0 dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC94ZW4tZGV2ZWwvcGF0Y2gvMjAyMzA2 MjYwMzM0NDMuMjk0MzI3MC0zMi1QZW5ueS5aaGVuZ0Bhcm0uY29tLw0KDQpLaW5kIHJlZ2FyZHMs DQpIZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Wed Aug 02 04:47:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 04:47:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574685.900188 (Exim 4.92) (envelope-from ) id 1qR3lN-0008UE-6e; Wed, 02 Aug 2023 04:47:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574685.900188; Wed, 02 Aug 2023 04:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3lN-0008U7-3h; Wed, 02 Aug 2023 04:47:09 +0000 Received: by outflank-mailman (input) for mailman id 574685; Wed, 02 Aug 2023 04:47:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3lL-0008U1-C9 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 04:47:07 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1379177-30ef-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 06:47:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0CF8821ACF; Wed, 2 Aug 2023 04:47:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D1E7213909; Wed, 2 Aug 2023 04:47:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WOc0McjfyWSZVQAAMHmgww (envelope-from ); Wed, 02 Aug 2023 04:47:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1379177-30ef-11ee-b25e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690951625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ABqtY7IgbgBW9NBSM6+342auGDC0z78g/OwW11uUkjE=; b=Llmd92Px49npHmhksYPcxkjgB3UequQGdo4XvyXhe4JH4LA+6lBR7JpeIvwjTyjXtyIv7A 6BQGq/qs7zrJ3UV1KAhxhy4u7f0mLflMCgtxwaF0CRaAGGdi57oW8elS+HJhkkcfuvllJv KFpC9xx6+gPnnuRm3XkgY/1yt5EH5qE= Message-ID: Date: Wed, 2 Aug 2023 06:47:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 18/25] tools/xenstore: don't use struct node_perms in struct node Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-19-jgross@suse.com> <41f92dc6-7d3f-9342-5521-cdb99d8ee405@xen.org> From: Juergen Gross In-Reply-To: <41f92dc6-7d3f-9342-5521-cdb99d8ee405@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------P6KH9mfzd0GcRKzn0cBru0zS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------P6KH9mfzd0GcRKzn0cBru0zS Content-Type: multipart/mixed; boundary="------------nBQ0uUdTaMDaq0ADEwermb9I"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v3 18/25] tools/xenstore: don't use struct node_perms in struct node References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-19-jgross@suse.com> <41f92dc6-7d3f-9342-5521-cdb99d8ee405@xen.org> In-Reply-To: <41f92dc6-7d3f-9342-5521-cdb99d8ee405@xen.org> --------------nBQ0uUdTaMDaq0ADEwermb9I Content-Type: multipart/mixed; boundary="------------0MuVBaBTXEAzJdHhWt1b2nl5" --------------0MuVBaBTXEAzJdHhWt1b2nl5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDguMjMgMjM6MjksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDI0LzA3LzIwMjMgMTI6MDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP cGVuIGNvZGUgc3RydWN0IG5vZGVfcGVybXMgaW4gc3RydWN0IG5vZGUgaW4gb3JkZXIgdG8g cHJlcGFyZSB1c2luZw0KPj4gc3RydWN0IG5vZGVfaGRyIGluIHN0cnVjdCBub2RlLg0KPj4N Cj4+IEFkZCB0d28gaGVscGVycyB0byB0cmFuc2ZlciBwZXJtaXNzaW9ucyBiZXR3ZWVuIHN0 cnVjdCBub2RlIGFuZCBzdHJ1Y3QNCj4+IG5vZGVfcGVybXMuDQo+Pg0KPj4gU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4gLS0tDQo+PiBWMjoN Cj4+IC0gbmV3IHBhdGNoDQo+PiAtLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3Jl ZF9jb3JlLmPCoMKgwqDCoMKgwqDCoCB8IDc2ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0t DQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5owqDCoMKgwqDCoMKgwqAg fCAyMSArKysrKystDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmPC oMKgwqDCoMKgIHwgMTMgKystLS0NCj4+IMKgIHRvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF90 cmFuc2FjdGlvbi5jIHzCoCA4ICstLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3RvcmVk X3dhdGNoLmPCoMKgwqDCoMKgwqAgfMKgIDcgKystDQo+PiDCoCA1IGZpbGVzIGNoYW5nZWQs IDc1IGluc2VydGlvbnMoKyksIDUwIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jIGIvdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuYw0KPj4gaW5kZXggODZiN2M5YmYzNi4uYzcyZmMwYzcyNSAxMDA2NDQN Cj4+IC0tLSBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+ICsrKyBiL3Rv b2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+IEBAIC03MzUsNyArNzM1LDcgQEAg c3RydWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qg dm9pZCANCj4+ICpjdHgsDQo+PiDCoMKgwqDCoMKgIC8qIERhdGFsZW4sIGNoaWxkbGVuLCBu dW1iZXIgb2YgcGVybWlzc2lvbnMgKi8NCj4+IMKgwqDCoMKgwqAgbm9kZS0+Z2VuZXJhdGlv biA9IGhkci0+Z2VuZXJhdGlvbjsNCj4+IC3CoMKgwqAgbm9kZS0+cGVybXMubnVtID0gaGRy LT5udW1fcGVybXM7DQo+PiArwqDCoMKgIG5vZGUtPm51bV9wZXJtcyA9IGhkci0+bnVtX3Bl cm1zOw0KPj4gwqDCoMKgwqDCoCBub2RlLT5kYXRhbGVuID0gaGRyLT5kYXRhbGVuOw0KPj4g wqDCoMKgwqDCoCBub2RlLT5jaGlsZGxlbiA9IGhkci0+Y2hpbGRsZW47DQo+PiDCoMKgwqDC oMKgIG5vZGUtPmFjYy5kb21pZCA9IHBlcm1zX2Zyb21fbm9kZV9oZHIoaGRyKS0+aWQ7DQo+ PiBAQCAtNzQzLDggKzc0Myw4IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNv bm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgDQo+PiAqY3R4LA0KPj4gwqDCoMKgwqDCoCAv KiBDb3B5IG5vZGUgZGF0YSB0byBuZXcgbWVtb3J5IGFyZWEsIHN0YXJ0aW5nIHdpdGggcGVy bWlzc2lvbnMuICovDQo+PiDCoMKgwqDCoMKgIHNpemUgLT0gc2l6ZW9mKCpoZHIpOw0KPj4g LcKgwqDCoCBub2RlLT5wZXJtcy5wID0gdGFsbG9jX21lbWR1cChub2RlLCBwZXJtc19mcm9t X25vZGVfaGRyKGhkciksIHNpemUpOw0KPj4gLcKgwqDCoCBpZiAobm9kZS0+cGVybXMucCA9 PSBOVUxMKSB7DQo+PiArwqDCoMKgIG5vZGUtPnBlcm1zID0gdGFsbG9jX21lbWR1cChub2Rl LCBwZXJtc19mcm9tX25vZGVfaGRyKGhkciksIHNpemUpOw0KPj4gK8KgwqDCoCBpZiAobm9k ZS0+cGVybXMgPT0gTlVMTCkgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGVycm5vID0gRU5P TUVNOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZXJyb3I7DQo+PiDCoMKgwqDCoMKg IH0NCj4+IEBAIC03NTcsNyArNzU3LDcgQEAgc3RydWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1 Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCANCj4+ICpjdHgsDQo+PiDCoMKgwqDC oMKgwqDCoMKgwqAgbm9kZS0+YWNjLm1lbW9yeSA9IDA7DQo+PiDCoMKgwqDCoMKgIC8qIERh dGEgaXMgYmluYXJ5IGJsb2IgKHVzdWFsbHkgYXNjaWksIG5vIG51bCkuICovDQo+PiAtwqDC oMKgIG5vZGUtPmRhdGEgPSBub2RlLT5wZXJtcy5wICsgaGRyLT5udW1fcGVybXM7DQo+PiAr wqDCoMKgIG5vZGUtPmRhdGEgPSBub2RlLT5wZXJtcyArIGhkci0+bnVtX3Blcm1zOw0KPj4g wqDCoMKgwqDCoCAvKiBDaGlsZHJlbiBpcyBzdHJpbmdzLCBudWwgc2VwYXJhdGVkLiAqLw0K Pj4gwqDCoMKgwqDCoCBub2RlLT5jaGlsZHJlbiA9IG5vZGUtPmRhdGEgKyBub2RlLT5kYXRh bGVuOw0KPj4gQEAgLTc5Niw3ICs3OTYsNyBAQCBpbnQgd3JpdGVfbm9kZV9yYXcoc3RydWN0 IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IGNoYXIgDQo+PiAqZGJfbmFtZSwNCj4+IMKgwqDC oMKgwqDCoMKgwqDCoCByZXR1cm4gZXJybm87DQo+PiDCoMKgwqDCoMKgIHNpemUgPSBzaXpl b2YoKmhkcikNCj4+IC3CoMKgwqDCoMKgwqDCoCArIG5vZGUtPnBlcm1zLm51bSAqIHNpemVv Zihub2RlLT5wZXJtcy5wWzBdKQ0KPj4gK8KgwqDCoMKgwqDCoMKgICsgbm9kZS0+bnVtX3Bl cm1zICogc2l6ZW9mKG5vZGUtPnBlcm1zWzBdKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgICsg bm9kZS0+ZGF0YWxlbiArIG5vZGUtPmNoaWxkbGVuOw0KPj4gwqDCoMKgwqDCoCAvKiBDYWxs IGRvbWFpbl9tYXhfY2hrKCkgaW4gYW55IGNhc2UgaW4gb3JkZXIgdG8gcmVjb3JkIG1heCB2 YWx1ZXMuICovDQo+PiBAQCAtODEzLDEzICs4MTMsMTMgQEAgaW50IHdyaXRlX25vZGVfcmF3 KHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCBjaGFyIA0KPj4gKmRiX25hbWUsDQo+ PiDCoMKgwqDCoMKgIGhkciA9IGRhdGE7DQo+PiDCoMKgwqDCoMKgIGhkci0+Z2VuZXJhdGlv biA9IG5vZGUtPmdlbmVyYXRpb247DQo+PiAtwqDCoMKgIGhkci0+bnVtX3Blcm1zID0gbm9k ZS0+cGVybXMubnVtOw0KPj4gK8KgwqDCoCBoZHItPm51bV9wZXJtcyA9IG5vZGUtPm51bV9w ZXJtczsNCj4+IMKgwqDCoMKgwqAgaGRyLT5kYXRhbGVuID0gbm9kZS0+ZGF0YWxlbjsNCj4+ IMKgwqDCoMKgwqAgaGRyLT5jaGlsZGxlbiA9IG5vZGUtPmNoaWxkbGVuOw0KPj4gwqDCoMKg wqDCoCBwID0gcGVybXNfZnJvbV9ub2RlX2hkcihoZHIpOw0KPj4gLcKgwqDCoCBtZW1jcHko cCwgbm9kZS0+cGVybXMucCwgbm9kZS0+cGVybXMubnVtICogc2l6ZW9mKCpub2RlLT5wZXJt cy5wKSk7DQo+PiAtwqDCoMKgIHAgKz0gbm9kZS0+cGVybXMubnVtICogc2l6ZW9mKCpub2Rl LT5wZXJtcy5wKTsNCj4+ICvCoMKgwqAgbWVtY3B5KHAsIG5vZGUtPnBlcm1zLCBub2RlLT5u dW1fcGVybXMgKiBzaXplb2YoKm5vZGUtPnBlcm1zKSk7DQo+PiArwqDCoMKgIHAgKz0gbm9k ZS0+bnVtX3Blcm1zICogc2l6ZW9mKCpub2RlLT5wZXJtcyk7DQo+PiDCoMKgwqDCoMKgIG1l bWNweShwLCBub2RlLT5kYXRhLCBub2RlLT5kYXRhbGVuKTsNCj4+IMKgwqDCoMKgwqAgcCAr PSBub2RlLT5kYXRhbGVuOw0KPj4gwqDCoMKgwqDCoCBtZW1jcHkocCwgbm9kZS0+Y2hpbGRy ZW4sIG5vZGUtPmNoaWxkbGVuKTsNCj4+IEBAIC05MDAsNiArOTAwLDcgQEAgc3RhdGljIGlu dCBhc2tfcGFyZW50cyhzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgY29uc3Qgdm9pZCANCj4+ ICpjdHgsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb25zdCBjaGFy ICpuYW1lLCB1bnNpZ25lZCBpbnQgKnBlcm0pDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHN0 cnVjdCBub2RlICpub2RlOw0KPj4gK8KgwqDCoCBzdHJ1Y3Qgbm9kZV9wZXJtcyBwZXJtczsN Cj4+IMKgwqDCoMKgwqAgZG8gew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIG5hbWUgPSBnZXRf cGFyZW50KGN0eCwgbmFtZSk7DQo+PiBAQCAtOTE5LDcgKzkyMCw4IEBAIHN0YXRpYyBpbnQg YXNrX3BhcmVudHMoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgDQo+PiAq Y3R4LA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAwOw0KPj4gwqDCoMKgwqDCoCB9 DQo+PiAtwqDCoMKgICpwZXJtID0gcGVybV9mb3JfY29ubihjb25uLCAmbm9kZS0+cGVybXMp Ow0KPj4gK8KgwqDCoCBub2RlX3RvX25vZGVfcGVybXMobm9kZSwgJnBlcm1zKTsNCj4+ICvC oMKgwqAgKnBlcm0gPSBwZXJtX2Zvcl9jb25uKGNvbm4sICZwZXJtcyk7DQo+IA0KPiBUaGlz IHNlZW1zIHRvIGJlIGEgY29tbW9uIHBhdHRlcm4uIENhbiB5b3UgaW50cm9kdWNlIGEgd3Jh cHBlcj8NCg0KT2theS4NCg0KPiANCj4+IMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+PiDCoCB9 DQo+PiBAQCAtOTU2LDExICs5NTgsMTMgQEAgc3RhdGljIHN0cnVjdCBub2RlICpnZXRfbm9k ZShzdHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB1bnNpZ25lZCBpbnQgcGVybSkNCj4+IMKgIHsNCj4+IMKgwqDCoMKg wqAgc3RydWN0IG5vZGUgKm5vZGU7DQo+PiArwqDCoMKgIHN0cnVjdCBub2RlX3Blcm1zIHBl cm1zOw0KPj4gwqDCoMKgwqDCoCBub2RlID0gcmVhZF9ub2RlKGNvbm4sIGN0eCwgbmFtZSk7 DQo+PiDCoMKgwqDCoMKgIC8qIElmIHdlIGRvbid0IGhhdmUgcGVybWlzc2lvbiwgd2UgZG9u J3QgaGF2ZSBub2RlLiAqLw0KPj4gwqDCoMKgwqDCoCBpZiAobm9kZSkgew0KPj4gLcKgwqDC oMKgwqDCoMKgIGlmICgocGVybV9mb3JfY29ubihjb25uLCAmbm9kZS0+cGVybXMpICYgcGVy bSkgIT0gcGVybSkgew0KPj4gK8KgwqDCoMKgwqDCoMKgIG5vZGVfdG9fbm9kZV9wZXJtcyhu b2RlLCAmcGVybXMpOw0KPj4gK8KgwqDCoMKgwqDCoMKgIGlmICgocGVybV9mb3JfY29ubihj b25uLCAmcGVybXMpICYgcGVybSkgIT0gcGVybSkgew0KPj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgZXJybm8gPSBFQUNDRVM7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBub2RlID0gTlVMTDsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiBAQCAtMTQzNCwx NCArMTQzOCwxNCBAQCBzdGF0aWMgc3RydWN0IG5vZGUgKmNvbnN0cnVjdF9ub2RlKHN0cnVj dCBjb25uZWN0aW9uIA0KPj4gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwNCj4+IMKgwqDCoMKg wqDCoMKgwqDCoCBub2RlLT5uYW1lID0gdGFsbG9jX3N0ZWFsKG5vZGUsIG5hbWVzW2xldmVs cyAtIDFdKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBJbmhlcml0IHBlcm1pc3Npb25z LCB1bnByaXYgZG9tYWlucyBvd24gd2hhdCB0aGV5IGNyZWF0ZS4gKi8NCj4+IC3CoMKgwqDC oMKgwqDCoCBub2RlLT5wZXJtcy5udW0gPSBwYXJlbnQtPnBlcm1zLm51bTsNCj4+IC3CoMKg wqDCoMKgwqDCoCBub2RlLT5wZXJtcy5wID0gdGFsbG9jX21lbWR1cChub2RlLCBwYXJlbnQt PnBlcm1zLnAsDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgbm9kZS0+cGVybXMubnVtICoNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzaXplb2YoKm5vZGUtPnBlcm1zLnAp KTsNCj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAoIW5vZGUtPnBlcm1zLnApDQo+PiArwqDCoMKg wqDCoMKgwqAgbm9kZS0+bnVtX3Blcm1zID0gcGFyZW50LT5udW1fcGVybXM7DQo+PiArwqDC oMKgwqDCoMKgwqAgbm9kZS0+cGVybXMgPSB0YWxsb2NfbWVtZHVwKG5vZGUsIHBhcmVudC0+ cGVybXMsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBub2RlLT5udW1fcGVybXMgKg0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgc2l6ZW9mKCpub2RlLT5wZXJtcykpOw0KPj4gK8KgwqDC oMKgwqDCoMKgIGlmICghbm9kZS0+cGVybXMpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBnb3RvIG5vbWVtOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChkb21haW5faXNf dW5wcml2aWxlZ2VkKGNvbm4pKQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9kZS0+ cGVybXMucFswXS5pZCA9IGNvbm4tPmlkOw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg bm9kZS0+cGVybXNbMF0uaWQgPSBjb25uLT5pZDsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCAv KiBObyBjaGlsZHJlbiwgbm8gZGF0YSAqLw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIG5vZGUt PmNoaWxkcmVuID0gbm9kZS0+ZGF0YSA9IE5VTEw7DQo+PiBAQCAtMTc2NCwxMiArMTc2OCwx NCBAQCBzdGF0aWMgaW50IGRvX2dldF9wZXJtcyhjb25zdCB2b2lkICpjdHgsIHN0cnVjdCAN Cj4+IGNvbm5lY3Rpb24gKmNvbm4sDQo+PiDCoMKgwqDCoMKgIHN0cnVjdCBub2RlICpub2Rl Ow0KPj4gwqDCoMKgwqDCoCBjaGFyICpzdHJpbmdzOw0KPj4gwqDCoMKgwqDCoCB1bnNpZ25l ZCBpbnQgbGVuOw0KPj4gK8KgwqDCoCBzdHJ1Y3Qgbm9kZV9wZXJtcyBwZXJtczsNCj4+IMKg wqDCoMKgwqAgbm9kZSA9IGdldF9zcGVjX25vZGUoY29ubiwgY3R4LCBvbmVhcmcoaW4pLCBO VUxMLCBYU19QRVJNX1JFQUQpOw0KPj4gwqDCoMKgwqDCoCBpZiAoIW5vZGUpDQo+PiDCoMKg wqDCoMKgwqDCoMKgwqAgcmV0dXJuIGVycm5vOw0KPj4gLcKgwqDCoCBzdHJpbmdzID0gcGVy bXNfdG9fc3RyaW5ncyhub2RlLCAmbm9kZS0+cGVybXMsICZsZW4pOw0KPj4gK8KgwqDCoCBu b2RlX3RvX25vZGVfcGVybXMobm9kZSwgJnBlcm1zKTsNCj4+ICvCoMKgwqAgc3RyaW5ncyA9 IHBlcm1zX3RvX3N0cmluZ3Mobm9kZSwgJnBlcm1zLCAmbGVuKTsNCj4gDQo+IFRoaXMgaXMg dGhlIG9ubHkgdXNlciBvZiBwZXJtc190b19zdHJpbmdzKCkuIFNvIGNhbiB3ZSBqdXN0IHBh c3MgdGhlIG5vZGUgcmF0aGVyIA0KPiB0aGFuIHRoZSBwZXJtcz8gVGhpcyB3b3VsZCBhdm9p ZCB0aGUgY2FsbCB0byBub2RlX3RvX25vZGVfcGVybXMoKS4NCg0KRmluZSB3aXRoIG1lLg0K DQoNCkp1ZXJnZW4NCg== --------------0MuVBaBTXEAzJdHhWt1b2nl5 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0MuVBaBTXEAzJdHhWt1b2nl5-- --------------nBQ0uUdTaMDaq0ADEwermb9I-- --------------P6KH9mfzd0GcRKzn0cBru0zS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTJ38gFAwAAAAAACgkQsN6d1ii/Ey+B Ogf/WiJkuqRyVrT5rjg1Qe2d0PLxHrVMl0NoCjMLqFYoec47bZWYK13SLBoeqRd2LsgJzQi2uyk5 L8TwdFBOAyYNLHdxTe+kzmQYYgkEst5yPAUL058T0DmofS05Al73Yzdyq8LOGRMNp+37U36+d/4j aUK9H2v5zkhxor6RXuztJ/rEED66w99J6ApHIodJxiwRTekcDWy6w+NIYW0aSWt+XI0/8OYZXi1L q+2ULXtW8mcu34PDgrpofCbdJG+3oX1tCyZi+rID/bre3i6oFcOTCfGIRR7yL87K9kdl+VuFnf4v dXVlgxXismgLXMNGCYgPia9nhDUYlGv/ISXTYHQA0A== =Rrs9 -----END PGP SIGNATURE----- --------------P6KH9mfzd0GcRKzn0cBru0zS-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 04:50:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 04:50:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574688.900197 (Exim 4.92) (envelope-from ) id 1qR3of-0001Vj-L2; Wed, 02 Aug 2023 04:50:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574688.900197; Wed, 02 Aug 2023 04:50:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3of-0001Vc-IX; Wed, 02 Aug 2023 04:50:33 +0000 Received: by outflank-mailman (input) for mailman id 574688; Wed, 02 Aug 2023 04:50:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3oe-0001VS-54 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 04:50:32 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ba25f9a-30f0-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 06:50:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BFE391F38D; Wed, 2 Aug 2023 04:50:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A06C13909; Wed, 2 Aug 2023 04:50:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OowjJJbgyWT+VgAAMHmgww (envelope-from ); Wed, 02 Aug 2023 04:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ba25f9a-30f0-11ee-b25e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690951830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O9bKgcdWKomLWy0HXyWDVTSHUSkrbXKE1jyDrwiAGAc=; b=BcJyH7XoKhEmX1vTLSnJCMFCzupA/m8NPozRqPVcC+aitAn4jgZd1uoIz2lG+NDl0D9Cdt XW37OcfWWUUpuQ7I+19klbizIVOv71lXNIkEzAbVPC0DXRzGFvtTwIc2BRNGOZ0Hdk+Ljk yCyqNXX6bhVFjtgNCT2AUK32ZV/mZRM= Message-ID: <09811df6-96da-c1a0-be1c-24e2f6d6dacb@suse.com> Date: Wed, 2 Aug 2023 06:50:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 19/25] tools/xenstore: use struct node_hdr in struct node Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-20-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------43R0FoyWmr04auMdovkISPsS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------43R0FoyWmr04auMdovkISPsS Content-Type: multipart/mixed; boundary="------------Zjb7PCGdBmkKPLGeyTjhW6GI"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <09811df6-96da-c1a0-be1c-24e2f6d6dacb@suse.com> Subject: Re: [PATCH v3 19/25] tools/xenstore: use struct node_hdr in struct node References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-20-jgross@suse.com> In-Reply-To: --------------Zjb7PCGdBmkKPLGeyTjhW6GI Content-Type: multipart/mixed; boundary="------------HGEQ8N0lasvqxxGD0fBYFuGl" --------------HGEQ8N0lasvqxxGD0fBYFuGl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDguMjMgMjM6MzQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDI0LzA3LzIwMjMgMTI6MDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBk aWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYyBiL3Rvb2xzL3hl bnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMNCj4+IGluZGV4IGM3MmZjMGM3MjUuLjQwNGVjZDBj NjIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+ PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiBAQCAtNTU1LDYg KzU1NSwxMiBAQCBzdGF0aWMgdm9pZCBpbml0aWFsaXplX2ZkcyhpbnQgKnBfc29ja19wb2xs ZmRfaWR4LCBpbnQgDQo+PiAqcHRpbWVvdXQpDQo+PiDCoMKgwqDCoMKgIH0NCj4+IMKgIH0N Cj4+ICtzdGF0aWMgc2l6ZV90IGNhbGNfbm9kZV9hY2Nfc2l6ZShzdHJ1Y3Qgbm9kZV9oZHIg KmhkcikNCj4gDQo+IFRoZSBwYXJhbWV0ZXIgY2FuIGJlIGNvbnN0Lg0KDQpJJ3ZlIGNoYW5n ZWQgdGhpcyBhbHJlYWR5IGluIG15IHBlbmRpbmcgVjQuIDotKQ0KDQo+IA0KPj4gK3sNCj4+ ICvCoMKgwqAgcmV0dXJuIHNpemVvZigqaGRyKSArIGhkci0+bnVtX3Blcm1zICogc2l6ZW9m KHN0cnVjdCB4c19wZXJtaXNzaW9ucykgKw0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgIGhk ci0+ZGF0YWxlbiArIGhkci0+Y2hpbGRsZW47DQo+PiArfQ0KPj4gKw0KPiANCj4gWy4uLl0N Cj4gDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuaCBi L3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmgNCj4+IGluZGV4IDljYjRjMmYzZWIu LmFkZjhhNzg1ZmMgMTAwNjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5oDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5oDQo+PiBA QCAtMTgxLDYgKzE4MSw3IEBAIGV4dGVybiBzdHJ1Y3QgbGlzdF9oZWFkIGNvbm5lY3Rpb25z Ow0KPj4gwqDCoCAqLw0KPj4gwqAgc3RydWN0IG5vZGVfaGRyIHsNCj4+IMKgwqDCoMKgwqAg dWludDY0X3QgZ2VuZXJhdGlvbjsNCj4+ICsjZGVmaW5lIE5PX0dFTkVSQVRJT04gfigodWlu dDY0X3QpMCkNCj4+IMKgwqDCoMKgwqAgdWludDE2X3QgbnVtX3Blcm1zOw0KPj4gwqDCoMKg wqDCoCB1aW50MTZfdCBkYXRhbGVuOw0KPj4gwqDCoMKgwqDCoCB1aW50MzJfdCBjaGlsZGxl bjsNCj4+IEBAIC0xOTcsNiArMTk4LDEwIEBAIHN0cnVjdCBub2RlX2FjY291bnRfZGF0YSB7 DQo+PiDCoCB9Ow0KPj4gwqAgc3RydWN0IG5vZGUgew0KPj4gK8KgwqDCoCAvKiBEYXRhIGRp cmVjdCBmb3IgZGF0YSBiYXNlLiAqLw0KPiANCj4gSSBjYW4ndCBwYXJzZSBpdC4gRGlkIHlv dSBtZWFuICdmcm9tJyByYXRoZXIgdGhhbiAnZm9yJz8NCg0KSSdsbCBjaGFuZ2UgaXQgdG86 DQoNCgkvKiBDb3BpZWQgdG8vZnJvbSBkYXRhIGJhc2UuICovDQoNCg0KSnVlcmdlbg0KDQo= --------------HGEQ8N0lasvqxxGD0fBYFuGl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------HGEQ8N0lasvqxxGD0fBYFuGl-- --------------Zjb7PCGdBmkKPLGeyTjhW6GI-- --------------43R0FoyWmr04auMdovkISPsS Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTJ4JYFAwAAAAAACgkQsN6d1ii/Ey9s LwgAmF49Pj9dMd2PzOTmoW5Gj96J+onAMnhMqnZx8uCbqdwiEL1ETWhIzelYw/45PW16nHxqMBC7 LAKPkPM3DIO4hJsFn7dR28ga3R1IUvswnMK0nnJ3xYJpb+vMN+gz9OaSkoFBDx21TTUFPfZFVaMa 0rQ1jDYARaf/LrXChEpc4Yt51Rn2aoqaiEp9Xe3au5uPH8H250lxGtztQlbCmhwfb95rTM9k6RdB w8V70KYvwnXdcC/PtaEUYx7jZOFwJz6FUjjD3WreX42NY+efKxdfVOo0xaTnad2LGMt6EeZf1NCS xnwkTmkckgW/XIlonV89KaD3GdWSLTPXljKsdJbKHQ== =RvDv -----END PGP SIGNATURE----- --------------43R0FoyWmr04auMdovkISPsS-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 04:51:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 04:51:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574693.900207 (Exim 4.92) (envelope-from ) id 1qR3pV-00026I-38; Wed, 02 Aug 2023 04:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574693.900207; Wed, 02 Aug 2023 04:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3pV-00026B-0M; Wed, 02 Aug 2023 04:51:25 +0000 Received: by outflank-mailman (input) for mailman id 574693; Wed, 02 Aug 2023 04:51:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3pU-00025i-5Q for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 04:51:24 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 387eb699-30f0-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 06:51:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 408B021B73; Wed, 2 Aug 2023 04:51:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 16FD413909; Wed, 2 Aug 2023 04:51:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PFgxBMfgyWRLVwAAMHmgww (envelope-from ); Wed, 02 Aug 2023 04:51:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 387eb699-30f0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690951879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J4PSGMwWbk4P8w7ztqk0CAWrzy5bIeDcfk2lLlw0U0s=; b=pp5SnA66a/BYX7FpEb6/kmCiTrCgeOCYAPnZfevFB8WCht6yu6g6xe1GIDnZoW32na+7xB Oo+a53wHHld8gjEp0y8K702oDF6mknzlWjkVyfTtAKBDw8iy3tBZiAzYmDR/qX9dltyyUC FLA4O6dr6L9Rxm3uTjXNDHW6Cw6mFFM= Message-ID: Date: Wed, 2 Aug 2023 06:51:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 20/25] tools/xenstore: alloc new memory in domain_adjust_node_perms() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-21-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------xXcQ60UYAMJuYm0d5bkISI2M" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------xXcQ60UYAMJuYm0d5bkISI2M Content-Type: multipart/mixed; boundary="------------bNNvoBGTLP7dHvGY06PeJjGQ"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v3 20/25] tools/xenstore: alloc new memory in domain_adjust_node_perms() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-21-jgross@suse.com> In-Reply-To: --------------bNNvoBGTLP7dHvGY06PeJjGQ Content-Type: multipart/mixed; boundary="------------n5g42DvTrRRlpIu0JpklBvq3" --------------n5g42DvTrRRlpIu0JpklBvq3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDguMjMgMjM6NDYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDI0LzA3LzIwMjMgMTI6MDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBJ biBvcmRlciB0byBhdm9pZCBtb2RpZnlpbmcgdGhlIG5vZGUgZGF0YSBpbiB0aGUgZGF0YSBi YXNlIGluIGNhc2UgYQ0KPj4gZG9tYWluIGlzIGdvbmUsIGxldCBkb21haW5fYWRqdXN0X25v ZGVfcGVybXMoKSBhbGxvY2F0ZSBuZXcgbWVtb3J5IGZvcg0KPj4gdGhlIHBlcm1pc3Npb25z IGluIGNhc2UgdGhleSBuZWVkIHRvIGJlIG1vZGlmaWVkLiBBcyB0aGlzIHNob3VsZA0KPj4g aGFwcGVuIG9ubHkgaW4gdmVyeSByYXJlIGNhc2VzLCBpdCBpcyBmaW5lIHRvIGRvIHRoaXMg ZXZlbiB3aGVuIGhhdmluZw0KPj4gY29waWVkIHRoZSBub2RlIGRhdGEgYWxyZWFkeS4NCj4+ DQo+PiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+ PiAtLS0NCj4+IFYzOg0KPj4gLSBuZXcgcGF0Y2gNCj4+IC0tLQ0KPj4gwqAgdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuY8KgwqAgfCAxMCArKysrKy0tLS0tDQo+PiDCoCB0b29s cy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMgfCAxOSArKysrKysrKysrKysrKystLS0t DQo+PiDCoCAyIGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25z KC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9jb3Jl LmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jDQo+PiBpbmRleCA0MDRlY2Qw YzYyLi5lYTNkMjBhMzcyIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX2NvcmUuYw0KPj4gKysrIGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0K Pj4gQEAgLTc1MSw2ICs3NTEsMTEgQEAgc3RydWN0IG5vZGUgKnJlYWRfbm9kZShzdHJ1Y3Qg Y29ubmVjdGlvbiAqY29ubiwgY29uc3QgDQo+PiB2b2lkICpjdHgsDQo+PiDCoMKgwqDCoMKg wqDCoMKgwqAgZ290byBlcnJvcjsNCj4+IMKgwqDCoMKgwqAgfQ0KPj4gK8KgwqDCoCAvKiBE YXRhIGlzIGJpbmFyeSBibG9iICh1c3VhbGx5IGFzY2lpLCBubyBudWwpLiAqLw0KPj4gK8Kg wqDCoCBub2RlLT5kYXRhID0gbm9kZS0+cGVybXMgKyBoZHItPm51bV9wZXJtczsNCj4+ICvC oMKgwqAgLyogQ2hpbGRyZW4gaXMgc3RyaW5ncywgbnVsIHNlcGFyYXRlZC4gKi8NCj4+ICvC oMKgwqAgbm9kZS0+Y2hpbGRyZW4gPSBub2RlLT5kYXRhICsgbm9kZS0+aGRyLmRhdGFsZW47 DQo+PiArDQo+IA0KPiBJdCB0b29rIG1lIGEgd2hpbGUgdG8gdW5kZXJzdGFuZCB3aHkgeW91 IG1vdmUgdGhlIGxpbmVzIGFib3ZlLiBJIHRpaG5rIGl0IHdvdWxkIA0KPiBiZSB3b3J0aCBk b2N1bWVudGluZyBpbiB0aGUgY29kZSAocG9zc2libHkgb24gdG9wIG9mIHRoZSBkZWNsYXJh dGlvbiANCj4gZG9tYWluX2FkanVzdF9ub2RlX3Blcm1zKCkpIHRoYXQgZG9tYWluX2FkanVz dF9ub2RlX3Blcm1zKCkgbWF5IHJlLWFsbG9jYXRlIHRoZSANCj4gcGVybWlzc2lvbnMuDQoN Ck9rYXkuDQoNCj4gDQo+PiDCoMKgwqDCoMKgIGlmIChkb21haW5fYWRqdXN0X25vZGVfcGVy bXMobm9kZSkpDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBlcnJvcjsNCj4+IEBAIC03 NTgsMTEgKzc2Myw2IEBAIHN0cnVjdCBub2RlICpyZWFkX25vZGUoc3RydWN0IGNvbm5lY3Rp b24gKmNvbm4sIGNvbnN0IA0KPj4gdm9pZCAqY3R4LA0KPj4gwqDCoMKgwqDCoCBpZiAobm9k ZS0+YWNjLmRvbWlkICE9IGdldF9ub2RlX293bmVyKG5vZGUpKQ0KPj4gwqDCoMKgwqDCoMKg wqDCoMKgIG5vZGUtPmFjYy5tZW1vcnkgPSAwOw0KPj4gLcKgwqDCoCAvKiBEYXRhIGlzIGJp bmFyeSBibG9iICh1c3VhbGx5IGFzY2lpLCBubyBudWwpLiAqLw0KPj4gLcKgwqDCoCBub2Rl LT5kYXRhID0gbm9kZS0+cGVybXMgKyBoZHItPm51bV9wZXJtczsNCj4+IC3CoMKgwqAgLyog Q2hpbGRyZW4gaXMgc3RyaW5ncywgbnVsIHNlcGFyYXRlZC4gKi8NCj4+IC3CoMKgwqAgbm9k ZS0+Y2hpbGRyZW4gPSBub2RlLT5kYXRhICsgbm9kZS0+aGRyLmRhdGFsZW47DQo+PiAtDQo+ PiDCoMKgwqDCoMKgIGlmIChhY2Nlc3Nfbm9kZShjb25uLCBub2RlLCBOT0RFX0FDQ0VTU19S RUFELCBOVUxMKSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGVycm9yOw0KPj4gZGlm ZiAtLWdpdCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF9kb21haW4uYyANCj4+IGIvdG9v bHMveGVuc3RvcmUveGVuc3RvcmVkX2RvbWFpbi5jDQo+PiBpbmRleCBmZGYxMDk1YWNiLi5j ZGVmNmVmZWY0IDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2Rv bWFpbi5jDQo+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfZG9tYWluLmMNCj4+ IEBAIC0xMzM0LDEzICsxMzM0LDI0IEBAIGludCBkb21haW5fYWxsb2NfcGVybXJlZnMoc3Ry dWN0IG5vZGVfcGVybXMgKnBlcm1zKQ0KPj4gwqAgaW50IGRvbWFpbl9hZGp1c3Rfbm9kZV9w ZXJtcyhzdHJ1Y3Qgbm9kZSAqbm9kZSkNCj4+IMKgIHsNCj4+IMKgwqDCoMKgwqAgdW5zaWdu ZWQgaW50IGk7DQo+PiArwqDCoMKgIHN0cnVjdCB4c19wZXJtaXNzaW9ucyAqcGVybXMgPSBu b2RlLT5wZXJtczsNCj4+ICvCoMKgwqAgYm9vbCBjb3BpZWQgPSBmYWxzZTsNCj4+IMKgwqDC oMKgwqAgZm9yIChpID0gMTsgaSA8IG5vZGUtPmhkci5udW1fcGVybXM7IGkrKykgew0KPj4g LcKgwqDCoMKgwqDCoMKgIGlmIChub2RlLT5wZXJtc1tpXS5wZXJtcyAmIFhTX1BFUk1fSUdO T1JFKQ0KPj4gK8KgwqDCoMKgwqDCoMKgIGlmICgocGVybXNbaV0ucGVybXMgJiBYU19QRVJN X0lHTk9SRSkgfHwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNoa19kb21haW5fZ2Vu ZXJhdGlvbihwZXJtc1tpXS5pZCwgbm9kZS0+aGRyLmdlbmVyYXRpb24pKQ0KPj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgY29udGludWU7DQo+PiAtwqDCoMKgwqDCoMKgwqAgaWYg KCFjaGtfZG9tYWluX2dlbmVyYXRpb24obm9kZS0+cGVybXNbaV0uaWQsDQo+PiAtwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9kZS0+aGRyLmdlbmVy YXRpb24pKQ0KPj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9kZS0+cGVybXNbaV0ucGVy bXMgfD0gWFNfUEVSTV9JR05PUkU7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAgaWYgKCFj b3BpZWQpIHsNCj4gDQo+IFRoaXMgd2FudHMgYSBjb21lbnQgZXhwbGFpbiB3aHkgeW91IG5l ZWQgdG8gY29weSBpdC4NCg0KT2theS4NCg0KDQpKdWVyZ2VuDQo= --------------n5g42DvTrRRlpIu0JpklBvq3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------n5g42DvTrRRlpIu0JpklBvq3-- --------------bNNvoBGTLP7dHvGY06PeJjGQ-- --------------xXcQ60UYAMJuYm0d5bkISI2M Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTJ4MYFAwAAAAAACgkQsN6d1ii/Ey9d rAf/QRNqqfEvhxbalOUwNxnFZ6G3YMDkovla43OEQ70WQNYjlGUEyG9u44CbtYh41nmELGUtoW85 6tg694PzGgo8uVnC3JGu4wyaEj7oG+aWmDhnhsSzXKx32JlKue/Y6XCdNcHWOvYMIQIYt8pAJRVf 25+5L7jgm8qbceRMc0FzZT2PYdbP4i3M2qIRNUjVIKPGJ9HTpjbTX7WYOv2EvmlGnAD+C/GIJ7BC /2BjaNkZohs4EK40Yuxbb6txR44FmJD4aJ0TkCMp5MrTauGHH+88/UiGKYg8tbXzpjbU50MTVmUp nhX431Vce5Qs2RRgaqkXCz7a2kNUb2AwCUz4j7OdIA== =KVKY -----END PGP SIGNATURE----- --------------xXcQ60UYAMJuYm0d5bkISI2M-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 04:52:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 04:52:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574696.900218 (Exim 4.92) (envelope-from ) id 1qR3qu-0002fS-Da; Wed, 02 Aug 2023 04:52:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574696.900218; Wed, 02 Aug 2023 04:52:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3qu-0002fL-Af; Wed, 02 Aug 2023 04:52:52 +0000 Received: by outflank-mailman (input) for mailman id 574696; Wed, 02 Aug 2023 04:52:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR3qs-0002fB-MW for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 04:52:50 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e0183a3-30f0-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 06:52:49 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E7E9221B75; Wed, 2 Aug 2023 04:52:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B5CAB13909; Wed, 2 Aug 2023 04:52:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZaLhKiDhyWTcVwAAMHmgww (envelope-from ); Wed, 02 Aug 2023 04:52:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e0183a3-30f0-11ee-b25e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690951968; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fq7kb0HcM1QBcZeZMgFh4gEofAabwcbg7KEnZLeYvNE=; b=NpGWNZ6Z/Bu9Sq6AALiH9ARLzleGmj1WkyoabiNXoXrUREfrI3xur3zALWUCkJsVrJFjim jyv1B/a/kxr5hFW8ha4jy+/mJD2/+dUzWHA5B0/cHX/0yyFpHchzrw5yGxRJ1jVv9/QtD/ WKabq8sgOcDEqRFGX6IPoiSX15gLdI0= Message-ID: <1d4a41af-9a7c-baf5-7d40-0fbbf9229de6@suse.com> Date: Wed, 2 Aug 2023 06:52:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 21/25] tools/xenstore: introduce read_node_nocopy() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-22-jgross@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------XXHcZFzv1yJDvPvpI4C2NA5O" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------XXHcZFzv1yJDvPvpI4C2NA5O Content-Type: multipart/mixed; boundary="------------qWaLtQ1B0tw2ZgsA4hRAX6Ym"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <1d4a41af-9a7c-baf5-7d40-0fbbf9229de6@suse.com> Subject: Re: [PATCH v3 21/25] tools/xenstore: introduce read_node_nocopy() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-22-jgross@suse.com> In-Reply-To: --------------qWaLtQ1B0tw2ZgsA4hRAX6Ym Content-Type: multipart/mixed; boundary="------------OPUSvSJWRwikYmlSolbeTGRm" --------------OPUSvSJWRwikYmlSolbeTGRm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDIuMDguMjMgMDA6MDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IFRpdGxlOiBJIGNhbid0IGZpbmQgcmVhZF9ub2RlX25vY29weSgpLiBJIGZvdW5k IGEgcmVhZF9ub2RlX2NvbnN0KCkuIFdoaWNoIG5hbWUgDQo+IGRpZCB5b3UgaW50ZW5kIHRv IHVzZT8NCg0KT2gsIHNvcnJ5IGZvciB0aGF0LiBJIHRoaW5rIHJlYWRfbm9kZV9jb25zdCgp IGlzIHRoZSBiZXR0ZXIgY2hvaWNlLg0KDQo+IA0KPiBPbiAyNC8wNy8yMDIzIDEyOjAyLCBK dWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gK3N0YXRpYyBpbnQgcmVhZF9ub2RlX2hlbHBlcihz dHJ1Y3QgY29ubmVjdGlvbiAqY29ubiwgc3RydWN0IG5vZGUgKm5vZGUpDQo+PiArew0KPj4g wqDCoMKgwqDCoCAvKiBEYXRhIGlzIGJpbmFyeSBibG9iICh1c3VhbGx5IGFzY2lpLCBubyBu dWwpLiAqLw0KPj4gLcKgwqDCoCBub2RlLT5kYXRhID0gbm9kZS0+cGVybXMgKyBoZHItPm51 bV9wZXJtczsNCj4+ICvCoMKgwqAgbm9kZS0+ZGF0YSA9IG5vZGUtPnBlcm1zICsgbm9kZS0+ aGRyLm51bV9wZXJtczsNCj4+IMKgwqDCoMKgwqAgLyogQ2hpbGRyZW4gaXMgc3RyaW5ncywg bnVsIHNlcGFyYXRlZC4gKi8NCj4+IMKgwqDCoMKgwqAgbm9kZS0+Y2hpbGRyZW4gPSBub2Rl LT5kYXRhICsgbm9kZS0+aGRyLmRhdGFsZW47DQo+PiDCoMKgwqDCoMKgIGlmIChkb21haW5f YWRqdXN0X25vZGVfcGVybXMobm9kZSkpDQo+PiAtwqDCoMKgwqDCoMKgwqAgZ290byBlcnJv cjsNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLTE7DQo+IA0KPiBZb3UgYXJlIGVpdGhl ciByZXR1cm5pbmcgMCBvciAtMSB3aGljaCBpcyB0aGVuIG9ubHkgdXNlZCBpbiBpZiAoIC4u LiApLiBDYW4gd2UgDQo+IHNpbXBseSByZXR1cm4gYSBib29sZWFuICh0cnVlIGZvciBzdWNj ZXNzLCBmYWxzZSBmb3IgYSBmYWlsdXJlKT8NCg0KRmluZSB3aXRoIG1lLg0KDQo+IA0KPiBU aGUgcmVzdCBMR1RNLg0KDQpUaGFua3MsDQoNCg0KSnVlcmdlbg0KDQo= --------------OPUSvSJWRwikYmlSolbeTGRm Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------OPUSvSJWRwikYmlSolbeTGRm-- --------------qWaLtQ1B0tw2ZgsA4hRAX6Ym-- --------------XXHcZFzv1yJDvPvpI4C2NA5O Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTJ4SAFAwAAAAAACgkQsN6d1ii/Ey8K igf8DW3KTxuvBxuJwVEeO1kHw0Ap45EHkTVr2xJwxcja1NlsGBuXb6dPc85b3fz8rFwGgZgUNuTC W6PF6+TAll9QmtoLqw3O4eAZKm6XioE0petz9WO6EePLyyJ8lASV1/KW16p6AHa9S2Usotv4U5w7 EzHL7CA2506e0us/xSiFrt8+CDJPbI3/LdPVzbb5te1JXPIJSkoSRF9YPfFiJG4tqjiyMXs+3RgG SBEpELpzx8yg+PH292iMWmtbix1QewmVunxyoHMS3Wk/vV7lSGyClMzLjgZQhUoHV6QQvPs6crnk 6SC4TR0EuMSMLbCvATVYffVlZAd9LmvNNTsPRPZzgA== =4bG4 -----END PGP SIGNATURE----- --------------XXHcZFzv1yJDvPvpI4C2NA5O-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 06:14:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 06:14:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574704.900228 (Exim 4.92) (envelope-from ) id 1qR57I-00032j-4h; Wed, 02 Aug 2023 06:13:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574704.900228; Wed, 02 Aug 2023 06:13:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR57I-00032c-1p; Wed, 02 Aug 2023 06:13:52 +0000 Received: by outflank-mailman (input) for mailman id 574704; Wed, 02 Aug 2023 06:13:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR57F-00032W-Qg for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 06:13:50 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20605.outbound.protection.outlook.com [2a01:111:f400:fe12::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bce8901e-30fb-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 08:13:46 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB8683.eurprd08.prod.outlook.com (2603:10a6:20b:563::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 06:13:43 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 06:13:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bce8901e-30fb-11ee-b25e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=POlnQ7PiXPHuezO7vc8Wineosa+11S/uSCLo/RAiAkrizh//25AKCzrF1tKbYR3UVpUacR3W2yqBhzwd8GH4oUTzjybBZixs+gR9ldxNSf/y7NFXde486p0MQC2+LApEjbC0ASYc0F3nvzjJ+qrGeZ1sHcWBCt/olLPkxwlXRAyetwZGQwkcR2mvlVMSoULBSzyv4viOPJFA73lLWfimIs9TwfyTDRskp8IIFURIW8Orv7qoQQ0SDZZwsJG9wQ3gLbkMk73QaQsozZoF6zxssogxST//vuw/KyVZg8WQFT5Tbe4wCwtSdajqZvOFEpWDTco7A9ztOjWss6E+TC57RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ndeMOJpnV5l16pEpE8gpP+JmxPx03elHUu9IBQo0zVo=; b=jY7rm7twOOdLZuJ/tYI1lVUkxVMTh/c/qsIKwogkRXuyUdvm0ZoJi76tTxGZ8m/Fs3piFQ3cbkA1TR7fuKBznPUnNEeRofE5XTb3I5ycI90wDjXNUOMHNM64Vo6XCUdxa0bS7N8PoVgE29s+kAgbGvYCiZAwGxLW7z6eg8kyFnCWIBDD90j5EbYtdhlazX5j+rO+LsVvO6P1LtEdslnEsmKGNqNuU439tjs+mvc0YlE6i921W2gN5lzs2shQZl88pmKlgGOODJ7wDARhk1ZVWvo2f1F/WopEpAt15Bj1L2P8QpR7ltVnO1+Y/7Ys1m3MIIxHMVH6b+JBFl2I9d2huw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ndeMOJpnV5l16pEpE8gpP+JmxPx03elHUu9IBQo0zVo=; b=6PYK/fFsrIqdkye56VaIOjNoDtxJPWi45Kscs2pvovW0eV/uZxBmRqwvg+y/2uxS1+VwkhjdgbSOAlOJcVfjSKPSI+cI7zZBujW41u5HF1dRGl8sIuYgxSEPaw7wW294DoQJh4GYPATQJVTLYTOQ/UpHbIXdJ3/hG3UzBqjSDvw= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Volodymyr Babchuk , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: RE: [PATCH 2/2] fdt: make fdt handling reusable across arch Thread-Topic: [PATCH 2/2] fdt: make fdt handling reusable across arch Thread-Index: AQHZxJNabMSouWTajUmNjHUgHUELYa/Whhow Date: Wed, 2 Aug 2023 06:13:42 +0000 Message-ID: References: <20230801161409.25905-1-dpsmith@apertussolutions.com> <20230801161409.25905-3-dpsmith@apertussolutions.com> In-Reply-To: <20230801161409.25905-3-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5506CBA16CD1DC4AA5CB26A3932700C5.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB8683:EE_ x-ms-office365-filtering-correlation-id: c7b406d1-58fc-462a-bc83-08db931f9f5c nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xsyvd2dpE9PFM7AXt9Jbs0j6xC0tQMeBEb5Uv7Ss+utSx/EhxfIHCgEJNShXEzrXtEcn/5JPF9anGpIFmuw931LlSnAUMnPkN/tfHI62xOQCSAqI96jWSC4vcqBdAwvtHEfGe2/hFwLGfrk/NFVDD6j8t9D0LkrTwmoicWSASwXNq9i+xJ2AHdDOJlSK9e6pG/HatdCda5tAatmYI5abnJIC4z/iWyjWNye/E5f5M5o+M2k/f7UBZvTYV/Q5xIC/I2pYe0giHMw5ZNOSpTvy60/Y9yxBJBE1+4DxgkoOgsXQYDAsy/SYt89+druEl1TTbk6Who2kkPrcFoo/yL+K1usEO0VxEtaEoIEaOhH55qwS1AeNpOMLUqSSQOdXk1+3Y8gkgV7G1nvc8f0qndZyn+Y9z/3u6hDvZXUXQoyTkRDDXgW1xbirVjuYjo5Jeq5tcE7agvM/EHwMv2aqKwl+ktOttrNRBCUYupzzTBkvjhv+FNfKuR94xFkdfJg2oNQH/uDIASZvkDFM6vBX9ZPqb5QvJ1z58hWLopRBW/8gMzQucevbdNIWHlKIe+Is7QHn36/7ZpSBkPCdlambYiLKFMKyrUscoBjIDMzRJ4vihf2Ya5WOlqfCTff6G5bS20Zg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199021)(66476007)(66446008)(64756008)(4326008)(316002)(41300700001)(66556008)(66946007)(76116006)(2906002)(86362001)(52536014)(38070700005)(8936002)(8676002)(55016003)(5660300002)(6506007)(33656002)(26005)(186003)(122000001)(71200400001)(83380400001)(9686003)(54906003)(110136005)(478600001)(38100700002)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DZcZAyNa3isCz2bRybKF8v/qObguEZv6ErUvnXLIBMtsgPlhRkLURtLwRcC7?= =?us-ascii?Q?Us7/9EQFqA+zLQZb7vQ7fzX+qZuVXcB5UpmnEZTW+BmIYoyGw91alwDKPb87?= =?us-ascii?Q?8tup0BwdnK2XyH08bb3IPBkOvxSyeVsTAeR1KT7jLwNLgMv0p36z9qcRRJHL?= =?us-ascii?Q?G9NsJFSKqsEUnEzCTARTaHZPdUhqQKVQAhmIYD86y6NYx1jr6eBH+HhjdfHq?= =?us-ascii?Q?FeGMpwoQmyWNvwkhg1fhnkKkQg8P98vCEuuJI4ktNEpGnyAGTiOkK1QvSyM1?= =?us-ascii?Q?XQEu7iAkdLrsg7BwLSey7tRCm9QFDA/1J4iF3tir9Bo3qqlycBXFpXbumD7s?= =?us-ascii?Q?RnmPN2WX9u2R2Otq4qkTxI04jMrByYVj9FprSMpiVTeZ56mSTKdF8EiebCpu?= =?us-ascii?Q?lAeD4Mw7MN9yq2+yHFvAofOtOGZP0oqS2Tnv4Mtj/BmIyjebiI4IrF+ao8ed?= =?us-ascii?Q?Kg/89+1vVdxhyx8QkPlsf4oHle8CNKjuVaTnrdbATIBqWOghWFAOUyvaRwKl?= =?us-ascii?Q?lQXjCl5hqTc9bB5SKUz9M0W+VTnAc6Anxl5pMznjFD88B01TDJpyq2RPdzyB?= =?us-ascii?Q?ozSbYCv/FOG7ZqAkSRM7OCt+m0E7SIvF3oVeoXPBOjOl56K8k8ffu1JtaffC?= =?us-ascii?Q?Wc7dR1BnK+kaJwdwBPKQkpkltyTiIDZy5rSg6Tn2ACFGRyjA4xI2rHy8hHdI?= =?us-ascii?Q?miL3YW5ADRhCHTPoOrU1mIBNU/tHPw+McBXgWQkWJn4PMZ249AXhDldznQ6F?= =?us-ascii?Q?D/TsBdH8Kwf5tOgNBioRO+etjqtMU7BNl+jZLs4WnbT/V/5ddHFTMd+vFAJu?= =?us-ascii?Q?UxG/zQhZ9IhS85ANrLFm4PgWAxsRwSl6pWqbgRA/RAKJE9ddzPPvPuAQEsz4?= =?us-ascii?Q?LhEqKt7Ukb/x73KgL88pv7P8cnXNt86IDy5IiSJ/OuPDiixpjD2RpFZ54QAd?= =?us-ascii?Q?odiHxIBVZO2XfUnxKFI1mCt8Kvmjgxs9NFYzqVexbBZwgCAiemQNpVyKmSrB?= =?us-ascii?Q?LDSXuGF7kDWQeDTjLVMeR/DIe5jUSb2vOaFOgTvrF/V9MmxDn4seTvVrcrgI?= =?us-ascii?Q?FFBiXb67FRDPJEdsfsrm1eTsx7xcJfhQmxyxvzAwBc+CtMAQb1TmrOqCGY12?= =?us-ascii?Q?rRrAh3wJiDy1OjYbSe6/2R2/HPacR3ZqfHeOEhRP5QrjJOGPMhLH/z5QEuKo?= =?us-ascii?Q?9AnA+E4eSLlGeUb8/qTjFnlcoP26U15gN2ekm7/MOE6avy77mR5PjHp4yJ3O?= =?us-ascii?Q?f90DpW7StptPKf9GrM71KwoKPTwFyv+IrakBgIG4j3E9znTYMcOLjSB/cWBw?= =?us-ascii?Q?idmejFQ8FUVqNcxc+YGXGFNv02l8P8v0OHuH7Wcn1UyZgPMDo8eKcR75dbfl?= =?us-ascii?Q?t69cyWMxSNvrSh/YZ4P6zGHQ6s9NbMB3sS2WSANyHg5PlHjPqAIqXVOyWqRx?= =?us-ascii?Q?uZebadfhTdCKGQbnjh69BoWhiVpo52RK+LSzbu32PIzygNgJWmYsPhJj785Y?= =?us-ascii?Q?V4mNGGEqepGi46AiVKhmeCav5Fx38AqBRNraRIa0RqfzNCIoIEwq5IOBKy6V?= =?us-ascii?Q?j+1qkOvKnxyW3Km2Y0kr6DuYfGyxW40k5lbezBLH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7b406d1-58fc-462a-bc83-08db931f9f5c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 06:13:42.9426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AugjDFum2+Fe5HKJKJ7AzuaGII+Ph/5HIZMDyKljNFUHDqP8RJL2QI8LEZ+pCCVaFF/2LZgSCuJ0nLT16w+aag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8683 Hi Daniel, > -----Original Message----- > Subject: [PATCH 2/2] fdt: make fdt handling reusable across arch >=20 > This refactors reusable code from Arm's bootfdt.c and device-tree.h that = is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of parsing DTB files is needed by a capab= ility > such as hyperlaunch. >=20 > Signed-off-by: Daniel P. Smith > --- > MAINTAINERS | 2 + > xen/arch/arm/bootfdt.c | 141 +------------------------------ > xen/common/Kconfig | 4 + > xen/common/Makefile | 3 +- > xen/common/fdt.c | 153 ++++++++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 50 +---------- > xen/include/xen/fdt.h | 79 ++++++++++++++++++ > 7 files changed, 242 insertions(+), 190 deletions(-) > create mode 100644 xen/common/fdt.c > create mode 100644 xen/include/xen/fdt.h >=20 > +void __init device_tree_get_reg( > + const __be32 **cell, uint32_t address_cells, uint32_t size_cells, > + paddr_t *start, paddr_t *size) > +{ > + uint64_t dt_start, dt_size; > + > + /* > + * dt_next_cell will return uint64_t whereas paddr_t may not be 64-b= it. > + * Thus, there is an implicit cast from uint64_t to paddr_t. > + */ > + dt_start =3D dt_next_cell(address_cells, cell); > + dt_size =3D dt_next_cell(size_cells, cell); > + > + if ( dt_start !=3D (paddr_t)dt_start ) > + { > + printk("Physical address greater than max width supported\n"); > + WARN(); > + } > + > + if ( dt_size !=3D (paddr_t)dt_size ) > + { > + printk("Physical size greater than max width supported\n"); > + WARN(); > + } > + > + /* > + * Xen will truncate the address/size if it is greater than the maxi= mum > + * supported width and it will give an appropriate warning. > + */ > + *start =3D dt_start; > + *size =3D dt_size; > +} > + > +u32 __init device_tree_get_u32( > + const void *fdt, int node, const char *prop_name, u32 dflt) > +{ > + const struct fdt_property *prop; > + > + prop =3D fdt_get_property(fdt, node, prop_name, NULL); > + if ( !prop || prop->len < sizeof(u32) ) > + return dflt; > + > + return fdt32_to_cpu(*(uint32_t*)prop->data); > +} When I tested this patch by our internal CI (I applied this patch on top of today's staging: c2026b88b5 xen/arm/IRQ: uniform irq_set_affinity() with x86 version), there are some build errors as below: aarch64-linux-gnu-gcc -MMD -MP -MF ./.asm-offsets.s.d -DBUILD_ID -fno-stric= t-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-state= ment -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O2 -fomit-fra= me-pointer -nostdinc -fno-builtin -fno-common -Werror -Wredundant-decls -Wn= o-pointer-arith -Wvla -pipe -D__XEN__ -include /jenkins/workspace/ais-xenbi= ts-xen/layers/xen/xen/include/xen/config.h -mcpu=3Dgeneric -mgeneral-regs-o= nly -mno-outline-atomics -I./include -I./arch/arm/include -I/jenkins/worksp= ace/ais-xenbits-xen/layers/xen/xen/include -I/jenkins/workspace/ais-xenbits= -xen/layers/xen/xen/arch/arm/include -fno-pie -fno-stack-protector -fno-exc= eptions -fno-asynchronous-unwind-tables -Wnested-externs -S -g0 -o asm-offs= ets.s.new -MQ asm-offsets.s /jenkins/workspace/ais-xenbits-xen/layers/xen/x= en/arch/arm/arm64/asm-offsets.c In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arc= h/arm/arm64/asm-offsets.c:13: /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setu= p.h:162:6: error: redundant redeclaration of 'device_tree_get_reg' [-Werror= =3Dredundant-decls] 162 | void device_tree_get_reg(const __be32 **cell, uint32_t address_cell= s, | ^~~~~~~~~~~~~~~~~~~ In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/device_tree.h:17, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arc= h/arm/include/asm/smp.h:6, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/smp.h:4, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/rwlock.h:6, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/sched.h:7, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arc= h/arm/arm64/asm-offsets.c:9: /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:64:13: = note: previous declaration of 'device_tree_get_reg' with type 'void(const _= _be32 **, u32, u32, u64 *, u64 *)' {aka 'void(const unsigned int **, unsi= gned int, unsigned int, long unsigned int *, long unsigned int *)'} 64 | void __init device_tree_get_reg( | ^~~~~~~~~~~~~~~~~~~ In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arc= h/arm/arm64/asm-offsets.c:13: /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setu= p.h:165:5: error: redundant redeclaration of 'device_tree_get_u32' [-Werror= =3Dredundant-decls] 165 | u32 device_tree_get_u32(const void *fdt, int node, | ^~~~~~~~~~~~~~~~~~~ In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/device_tree.h:17, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arc= h/arm/include/asm/smp.h:6, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/smp.h:4, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/rwlock.h:6, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/inc= lude/xen/sched.h:7, from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arc= h/arm/arm64/asm-offsets.c:9: /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:68:12: = note: previous declaration of 'device_tree_get_u32' with type 'u32(const vo= id *, int, const char *, u32)' {aka 'unsigned int(const void *, int, cons= t char *, unsigned int)'} 68 | u32 __init device_tree_get_u32( | ^~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[2]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/./build.mk:= 45: asm-offsets.s] Error 1 make[1]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/Makefile:59= 7: xen] Error 2 make[1]: Leaving directory '/jenkins/workspace/ais-xenbits-xen/build/xen-fv= p-base' make: *** [Makefile:183: __sub-make] Error 2 make: Leaving directory '/jenkins/workspace/ais-xenbits-xen/layers/xen/xen' The staging itself passed the CI check. Did I miss some context to make this patch works? Could you please provide some hints? Thanks in advance! Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Wed Aug 02 06:45:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 06:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574713.900237 (Exim 4.92) (envelope-from ) id 1qR5bn-0006Yn-KK; Wed, 02 Aug 2023 06:45:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574713.900237; Wed, 02 Aug 2023 06:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR5bn-0006Yg-Hq; Wed, 02 Aug 2023 06:45:23 +0000 Received: by outflank-mailman (input) for mailman id 574713; Wed, 02 Aug 2023 06:45:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR5bm-0006Ya-JK for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 06:45:22 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20630.outbound.protection.outlook.com [2a01:111:f400:7eaa::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25ae4399-3100-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 08:45:19 +0200 (CEST) Received: from CY5PR14CA0011.namprd14.prod.outlook.com (2603:10b6:930:2::20) by CY8PR12MB8267.namprd12.prod.outlook.com (2603:10b6:930:7c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 06:45:16 +0000 Received: from CY4PEPF0000E9DA.namprd05.prod.outlook.com (2603:10b6:930:2:cafe::c9) by CY5PR14CA0011.outlook.office365.com (2603:10b6:930:2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 06:45:16 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000E9DA.mail.protection.outlook.com (10.167.241.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.24 via Frontend Transport; Wed, 2 Aug 2023 06:45:16 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 01:45:16 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 23:45:15 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Wed, 2 Aug 2023 01:45:14 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25ae4399-3100-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DaYqJA3aOBpO647RufGyZbp1dCMaGMOg/2Ovh07jw5pYqtPEPh98tnrIJ3YQPXUCvtbn+xWs+14JvIIp9AGTo0TaNbzPexj89NcYJNZ1M07DUOy0W79PzR8ed4UU3HSrpqW9Z6/XW4bKG5yRz8H88ecu5GlZFZclUMrz+JhKFGB0RdvtxV0OuRAeB7gVwfjBnkZN6FsC/1amaGy/SknsjEuL86Hwb51PcinYhKKgCqmpbytGvpYPUctUEfd11vOs66KscjX5OIXVc6ROC3HmKqOKAegcL7ufvirt5Zzd7/TuFMEaKPdHlEYT19rmzqfxmHscicIqvRL0n1dmmj5iCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8182KY+n3aHnqyfWZHGhA1CwEz6eV9ppeOvRRMd53U=; b=bQuxqHWbtWpgUImvOgV/gQhPVEXuqAeX/hmQoxygsmOi3R0HBzw5z7vu9+IQGaMMJ7CBvUgBhRh9K0d7a0dN2d+2UxhIEuevF/CMKpQsrVrRjVD5dqfKOwFnW+YPaxVS86aICHn/5EMHp/iK73PrTOzfoba/OXviADGyCgrdrA/VixYJiyk1ccfE4ZxDmqF/XEx9O6yflTBrGxTcSb/srCqpfkUf3F7nhVD1U3mDWV3aroz9l3diYaGr/kiB/ApSaa0axfVicVsrADDsF3s18G7V1UfeA+VURovKqCraZJdsVK8SgEjUtcyCKHreQdi6rH/tHbRefv5G4WeY/3Yp1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8182KY+n3aHnqyfWZHGhA1CwEz6eV9ppeOvRRMd53U=; b=4OlZD8oNF07VJ+3f95HYqNLoMKj14FIuFYx+caasRjPMPR1BF0yEyrxy8CdUTXERhZ9uwmJfxrVYni7EHBgE2BPvGbB/eZHHdOD0LuecU6nywk4xz4dhgSz1STom/xcWrbOfHGXudMtOoQOa4m6POkaQN2cwotkgazGUNRQmi0k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <321cb38e-7622-5e3c-cec7-77321ac9a4c3@amd.com> Date: Wed, 2 Aug 2023 08:45:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive Content-Language: en-US To: Khem Raj , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" , Jan Beulich References: <20230801174930.2995947-1-raj.khem@gmail.com> From: Michal Orzel In-Reply-To: <20230801174930.2995947-1-raj.khem@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DA:EE_|CY8PR12MB8267:EE_ X-MS-Office365-Filtering-Correlation-Id: 92d2ac82-917e-4115-ba7b-08db9324082b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5dydmuWGIlKOItuFdFJBqEJax/5DuUCPCXVEn33kkLUfls5SBPQFFTzHeDRF89gA8Z2QoUI7zVDhCzwHOlVCSYmO/xgzt+H5/kyXuITkMS0hxvwLblGgufYLvsZ6uqCxH6Y03WqMzCl/i5UAgN2vuD9SvIwaAgCpn84MR0X0t8JM/d8hWeAmoReQRWVX0eYKQw0tNM0BGl8WZiRGK6ZhwJXnp4g5z2XAqKZIQfLf4QmIXuOBahdgDvKnIOk4Xli+cIug+/cTlYoEKpN9/udcybPxVfuoIa72Y8SAFZY6I+9E7xdH04k0b4/GKjdWryjCY2FWUuayllYMt2kuu+8BnSbiCL6Sivs8iGGKi487yvj4pblFp77jvST9oKuxnC6gz2UIS/FAgKQK/Mv5dkBvdj3oXuqIp6gGp7vLy2y5kFLXtr/CrvaMLmv4HohUDqu+G37lm50LkZ3BK65bux7LeBtpZcqOHf/yVqHCpVPW8WBLXizMHYI6Cx7dZBjmdmKGYHJv/eXyN3/Vi944TQhjvU8QboSLibxrk6GXuP/6yIzryf8sjoMv/0U8JI7FwwF/P5vrTEh6PmVRIPT+EWl3UnQlS8p7GgVC77aB8Lj2OI6OhYUJJKbxNcQ/nAuxUmFlHXqjlbaSA1hh2xMMVwp65mbIl6jPkyVBayNSxBLvbi9TrhZAJKkMoEiZNVs8PITILLrrYdcQioY79sR6kN0MO0pN9ZQmMEG/j2rN/OQRlyHOiv4u0l3Gp/lZIXaA6eWri1ru56SS2l49vW93o3MUe/yDLE8r3IID3ZyERy83AYeSqmrs71WLXjTtk46f4uDj6MNkTrnI9eC3auB59M9a3fAu9PJfwj2pqlBRtpeTggA= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(376002)(39860400002)(82310400008)(451199021)(36840700001)(40470700004)(46966006)(70206006)(70586007)(86362001)(31696002)(966005)(2906002)(31686004)(4326008)(54906003)(110136005)(44832011)(40480700001)(36756003)(40460700003)(478600001)(83380400001)(82740400003)(426003)(47076005)(41300700001)(2616005)(356005)(81166007)(5660300002)(36860700001)(8676002)(8936002)(26005)(53546011)(316002)(336012)(186003)(16576012)(4744005)(142923001)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 06:45:16.6996 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92d2ac82-917e-4115-ba7b-08db9324082b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8267 Hi, On 01/08/2023 19:49, Khem Raj wrote: > > > Assembler from binutils 2.41 rejects [1] this syntax > > .section "name"[, flags...] > > where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] > > It is almost like a regression compared to 2.40 or older release, > It likely went unnoticed so far because Linux kernel changed > to GNU syntax already in 5.5, to allow building with Clang's > integrated assembler. > > Switch to using GNU syntax > > .section name[, "flags"[, @type]] > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 > [2] https://sourceware.org/binutils/docs-2.41/as.html#Section > > Signed-off-by: Khem Raj With the changes suggested by Julien: Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Wed Aug 02 06:54:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 06:54:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574717.900248 (Exim 4.92) (envelope-from ) id 1qR5k7-00081d-FS; Wed, 02 Aug 2023 06:53:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574717.900248; Wed, 02 Aug 2023 06:53:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR5k7-00081W-Ax; Wed, 02 Aug 2023 06:53:59 +0000 Received: by outflank-mailman (input) for mailman id 574717; Wed, 02 Aug 2023 06:53:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR5k6-00081M-PM; Wed, 02 Aug 2023 06:53:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR5k6-0001k8-Lg; Wed, 02 Aug 2023 06:53:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR5k6-00085v-1Y; Wed, 02 Aug 2023 06:53:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qR5k6-0005Kl-12; Wed, 02 Aug 2023 06:53:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+SsAqF/Qh83NF1SnMwQ5rxo/cGdyUMQUkrpEVB8QV5M=; b=S45G1cLvgyL7I1NRmt2On1GXL0 Y0SQvlskr+Wf4MvpHVOGAzKIlxSdH4t0B8lVE6lSAzZfublTKlV95EXYqlPlikzmjACZEoEbAFWgq c/HQ5BpmAZVmsPEJzCM/79VEB29xMiXi/K1webr5dnKI3L7tAhBNsUve9yXCsgK7N1VU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 182095: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-qemut-rhel6hvm-amd:guest-start/redhat.repeat:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c18b2dd93f396eadd116d0016cf7285523a13505 X-Osstest-Versions-That: xen=04f14792a6c7a4e4cd8fda10b29c7e72837c5433 From: osstest service owner Date: Wed, 02 Aug 2023 06:53:58 +0000 flight 182095 xen-4.17-testing real [real] flight 182109 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182095/ http://logs.test-lab.xenproject.org/osstest/logs/182109/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 14 guest-start/redhat.repeat fail pass in 182109-retest Tests which did not succeed, but are not blocking: test-amd64-i386-migrupgrade 10 xen-install/src_host fail like 182016 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182016 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182016 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182016 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182016 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182016 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182016 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182016 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182016 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182016 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail starved in 182016 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail starved in 182016 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail starved in 182016 version targeted for testing: xen c18b2dd93f396eadd116d0016cf7285523a13505 baseline version: xen 04f14792a6c7a4e4cd8fda10b29c7e72837c5433 Last test of basis 182016 2023-07-26 00:36:44 Z 7 days Testing same since 182095 2023-07-31 13:07:46 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 04f14792a6..c18b2dd93f c18b2dd93f396eadd116d0016cf7285523a13505 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:11:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:11:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574725.900262 (Exim 4.92) (envelope-from ) id 1qR60h-00029G-TS; Wed, 02 Aug 2023 07:11:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574725.900262; Wed, 02 Aug 2023 07:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR60h-000299-Qc; Wed, 02 Aug 2023 07:11:07 +0000 Received: by outflank-mailman (input) for mailman id 574725; Wed, 02 Aug 2023 07:11:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR60g-000293-UU for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:11:07 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20601.outbound.protection.outlook.com [2a01:111:f400:7eaf::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc4bb421-3103-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 09:11:01 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9930.eurprd04.prod.outlook.com (2603:10a6:800:1e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:10:57 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:10:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc4bb421-3103-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVGlsekUpoVvHp2TRgbmwvf4pU+oAHHhAygHQCUzLUuqbpcvk4RO1cLsJ/2be7T6enreJCKVYV4bSb7cz1/yixkAre69u3B7D9JEvEW7fG6w4GlCGZUImD7wxlVFdy1w9wOqT8sN18yEbASFpoZNS69gSJw1zp/rgFHz15Axu4UP7QhE/0bcPfWs/HaRl2c0rerE0ueAR+3GwyWlC01sg5/JjeXxJE/dfFUkgXRswD52RznLIIZK3k1EmOYFefjRWmXcer4EAin4oD7PEZoooA20EW7uERBNZ3i4J6SSw9qqwC/44mxEHItTGTPSMJmv9kwo6dDUg43nJhsJNpGOfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2gsbWAK1hWxBxzH9Ld1Tp9I8VrXn5DEEemrE12FGPw=; b=lfn/6jgUsv4u1FDAR2dpx4fG9oJ/eRbfS7GYaSxj/2roalM/vToND40NvTssX+4LcXTqsdocUk0bXNUpwdml/YZdkvN50p/TApI9uslN77T8wDbwnYDTNUSgZsxwscEiUppJxPapCJE4jbzH7lFAYjUmXsh1v3gzuEE7E5Pp1gYV1st7lEjqKt489sZj0jDHneWquJWHlK+szqKj/VJFsmuE6VCpElVr7h36Z3N+Oxo3iKrT2Rz1bn/u+0V4ge06EpXt//i7ba2uAo9y6kgHU86BEEv8ljVeioPItReEUNhykH8qx11uae0VRy6JY8AK5jVOTIqCOYYjzIQjpfVNIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y2gsbWAK1hWxBxzH9Ld1Tp9I8VrXn5DEEemrE12FGPw=; b=f1BWOJKBsTmQpX9MRGU3r7lVqBNOmuE8HhywE8i4ug39VwxjymYH48d9lfkPFiRamJPHVuzc/Kgvr+VkBVL/8nY0NJzGekJzQUgkDSi11Z6P354xbk6Sf5qQtx1/na0vrT89SB5CEuv5r93XtbFq2KgNSPCAkchSdoqxmjqLnzELSBUulP55pSp2Fdu651OVEIneN4OZIEhVFV5BUeC5cBf4EEojbP3NdA/r4CYnwqoQxi2K1ql4DnluVKazkavmtUKie6lEy2cq2Uw+My1ebEHPtMgzo1Li1QiYWitz9EYevwnuGjmoQOL+BNriZ4wQe9Ks33Ep4Xo4uzW9XMkOIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 09:10:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <3023ad320b42fa3787bb71a9cf83b34965668fe9.1690579561.git.sanastasio@raptorengineering.com> <41b33115-274c-7172-f100-85d6a4f1d538@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9930:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c66a140-2288-43bb-668e-08db93279e84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y4bJg326GxCCyO8v9ySgBBDUR014keTm/XRKNN0DPs41o2kWXSKzKirmOEwbFcmWit9vq679IJpt8NCGtBXCpu0qQT3ywDFTBmGD65R/5+D6jxR869MO5KDtrzeRgPrOqvRCyU98KT4bnXwsfqcgghlJ5AD6eBHcFz9sPP0nc3eXmR65uGO3E7F4gfD0qgL+qBQufbCMegTDw/ghWhSN0JL9Hxe98pLERW4ZIfJ8E3k8DkMcXHWwG9iUfsAoS2MQ1WAo9t7wLMrn593LXLkTHeeGrWn8UOyw7jizdqRF/5K2iqu4YobTHIbVOSOKqRyjvujYPJkmM5PpG1uW9eol3ST2Rf93whDo2jGF4mmppyX6P+Uldc54IcR4ii0cJBhAARxKvQmlA4XHfLPf7u88Odewvsvq9ebPQg98un7dPSB2m/uCPJsblLVr9avl6abue33jyrAF9Vm5XnWPQ3v8UedVsITO4Fg+fyoJxlDe4E1lEVa54AU9W9r7Bx0zxbzbnFHMHmE21MB8nsuQvL5ZcFVzNa8MMWkHsZordAc9WYiVzXSf9rGkIwzkMcVpThoLb2w2BEQ3BgyF4uqBc3IaV5Mq2Z25F2xqAM271SXazDyKpoYveG9G5O6zr4gBZQjFntFiumPDQJKuwtDEWC4U9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39850400004)(136003)(396003)(346002)(451199021)(2616005)(36756003)(6512007)(316002)(86362001)(478600001)(54906003)(38100700002)(66946007)(66476007)(66556008)(6486002)(4326008)(6916009)(31696002)(53546011)(6506007)(41300700001)(26005)(186003)(8676002)(8936002)(5660300002)(4744005)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjdXS0xkWFR3V2RLak9USVB5c1VkaTk5c3p3QmEydjBqQnkxZVRvMmFOdlJ3?= =?utf-8?B?Vzlma2plTWFidUhPU1NFY3ZyKzV6a2lkNDBaUC9tOEg1UWlEM0U0cHBwbytC?= =?utf-8?B?TEY4MEpGNUZINmtFNWY2emFPbjNLMkZSSE1vSDhmYzJkU1J4UWo0U1ZaRkNX?= =?utf-8?B?Y1p1azkrNTRmQU1Ma3F0TWdodXRLckhaNEFVd2NPcmdBMTVnbGtYRDFzenA5?= =?utf-8?B?Tk5LemlYMXRDeStCRDdLSmZBek9wUHJFNENBemtLdUlMdmdqUkZWWnQybnBl?= =?utf-8?B?NFhBbkZkTVNXNWdIZ0J4aDRwVWhDSFcvRWhDM3VFUjllSldPdkFEUGEwc1Vl?= =?utf-8?B?TUhnaHBLNlVycDRiVTJxc1hGSWVyNG1HcXZVbnJDck5vR2JUc3RwWEExRGNn?= =?utf-8?B?azlDSEdoRG5Sc1FPbEYwRlJ1c0hYQ1hlU1JYREtmVmZ4RVVXdXpOM2wvdnF6?= =?utf-8?B?QlA2UWpkZVJMZlZUdjVWS2h4Nk0yeDZkdDBxeWRSSnQzWDI3eVhOaWtGMitl?= =?utf-8?B?Q3M1bXl1WGZ5UktjSGVCUjNjTnBSQmxkVmdXampTRExuYWhxSXlYS3hhMW82?= =?utf-8?B?bVRLMVlDQjhmQlp2Uk9PVThrWnNrTVR3b1dvQTByN2JtUlZ6RVRVWnN0ak5W?= =?utf-8?B?d2tUTG1xWWRLeFg1b29hbjVnbDc2QUU1ZkFQUkdjMzNzOGtQVk1CNGxjc2Va?= =?utf-8?B?dEQ4L0tPWFdDSmFoSHpKNTA3UVVaRTBXWGgxOUdSQ3ZlSVgwaGtHVGRWYU42?= =?utf-8?B?bFV4OFZvZkh0bU5sbVhackFXa1dLUDdERXc4OXk1YWZDcUI4OXpBYTZsckMr?= =?utf-8?B?ZWZjblJrREpLYjlrbGp6T1ZkMC9OZytSUXlJeUJ1RUtFU3loYnJnbFRPUUNw?= =?utf-8?B?aUo5QWxXY1NnM29qY0lpZnhOZEpvZHd3TU42Q1JPcEpMUTB3TityUTAxS3g3?= =?utf-8?B?WERQRjhJM3VWQzBML0RXUkg3QTRqOHo5azJwV1g2bGdDcGE3TEx0TmlkeHNZ?= =?utf-8?B?Q0M4NHpuWUtrb3hyVkl5TFFGaTFiV1hvWmVFUlJNVXpDc1k0WVlhMUtTWnB6?= =?utf-8?B?dHlWYUtFV1haT093ckFjOTREV2tXV0NjN1VKb2IxT2VuTXl6cWxOTkVLT3JE?= =?utf-8?B?d3NVUEVNWUdOcENPbXVSU09jUDBlR0dUZERsWFNXUUJ2cDFLTkxablVFRmZ5?= =?utf-8?B?ZlFnZ3RNUWRkTXJSWWw4Wm9NUHZDVU4vNThsM240SHo4NWIwa2ppTUpyQTkx?= =?utf-8?B?NUkwMDB4RnpIUUhYcjNkaFQ1b3BLZGZXK20xQnpYb2cvbURXOTYrc05JWDRR?= =?utf-8?B?amtBcmRkd2g5M3hKbUkvbDZYS1g5dE0xZ3Y1Y2xYVTEzc2Zwd1UyYjYyaTlr?= =?utf-8?B?bzVKaGpVa2gwU2preTI2Q01CdCt2M241TFdNMUF6RmFkY0V6RUtUTUdsdkRY?= =?utf-8?B?QlNCQ2RKUWNYQ3NqK2tOK2N1YXMyUGZhRUlGVkdYQWxKdkprdlN4OHpWVElR?= =?utf-8?B?L3BaaTJDRzlUSXNINW4xV3ZWZkNHaWJIbHZtNzNuemhuUFhFTUlPcTFMSWps?= =?utf-8?B?bjE2eUh5VEdTVHlWRXZXaVMzWHQxR0ZuTk8xM21xTDNKTEFsd0NVVkxWZTVW?= =?utf-8?B?dEZoZFJWckV1K3BmU3ZXVng2YXFUc1Y5Y08zZ3B6OEdFN3FCVXRVcURFc1FQ?= =?utf-8?B?aDQ2YU83ZnFtU04xTS9uSHozRVozOWNiUWl4WWF4NWVCMUhQMWxZUVU4aGpj?= =?utf-8?B?VGFJYk9sbVB1MnFIVWszWERpd2xrNEkwRkpHNzFnRTh3ckwwVlFLYitkSENH?= =?utf-8?B?eFdjeXc1dFcwMDExbnNnbDhSbGpHUUdPVTFDMVBLS3RLQWxJZlZVYThsbmZU?= =?utf-8?B?aDFtZVFDOVRvOXRxaW9ldC9TNC9xMlVpU0o4MTZ3RXJhWWxiRk5jRXVuSnN2?= =?utf-8?B?WERvNXFFRUR3MkQ2bGtOR2tCYWFnWHJzSmVuNFNxY3lWRVV2Q1JhdW12clBk?= =?utf-8?B?SmJFaGFLdVMwNmNPNXJRWWUvVjhLbFpGN3gxZHhoNk1YSWY5bUFhY28yU1Np?= =?utf-8?B?ekZNdEVLUncwL052cnpzSjhtdHovNk5XeUxZQXpUNjRydGMyODVEVzlIOWMr?= =?utf-8?Q?g2e/Yk2Ojt49ebKJBi0rFpk+7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c66a140-2288-43bb-668e-08db93279e84 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:10:57.7021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KhGKOX3mAt6ho5oJEITXtKnITQfGt1+k3BvBXjlqBwAfTDFcd0JOMEcbQgnXX67e8ziwFMmrKNL6DDes4zYZFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9930 On 02.08.2023 00:54, Shawn Anastasio wrote: > On 8/1/23 6:19 AM, Jan Beulich wrote: >> On 28.07.2023 23:35, Shawn Anastasio wrote: >>> +static void opal_putchar(char c) >> >> Can't this be __init? > > Unlike OpenFirmware, OPAL calls are expected to be used by the OS during > its entire lifecycle, not just during early boot, so the full > (non-early) serial console driver would likely want to use these > functions as well. Well, in the present usage it's unneeded post-init afaict. Hence if you don't want to add __init until another use appears, please add a respective remark in the description. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:17:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574731.900272 (Exim 4.92) (envelope-from ) id 1qR66L-0002ol-NF; Wed, 02 Aug 2023 07:16:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574731.900272; Wed, 02 Aug 2023 07:16:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR66L-0002oe-K4; Wed, 02 Aug 2023 07:16:57 +0000 Received: by outflank-mailman (input) for mailman id 574731; Wed, 02 Aug 2023 07:16:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR66K-0002oY-N0 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:16:56 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20622.outbound.protection.outlook.com [2a01:111:f400:7e1a::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f870f26-3104-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 09:16:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM7PR04MB6998.eurprd04.prod.outlook.com (2603:10a6:20b:10a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:16:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:16:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f870f26-3104-11ee-b25e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l2ZfC0DcxMjs8JULLXxV/dh0fWsBzlKM5vwVQGrxq/BSGVmJkEfYZ2DYmWhl6Pkt22oDfw9J/ZmjrxEQY3K/m/P2kCp3/EfqAFtLW2U3M3Y7lbPU3ebZpIJRLo3olTiPL09gqgjsNDGvfMxAsW0d5n9ULpw/WsAObQ9CLB1kkjhRB9BjCYJdUs5uFpU6jbz2p/jkDn+y0fwJgsIsC4S9BHXkDA9m12ld6qtgfGze/hF7w4AImTB+AK4zUb4Ev6gRvkPygcOjXOztv8eQdPlZrd5piXN/vkh1GFFWE8sAfL1iNBCgwhArvCpT/0FA7M3ucrcDio9CLRO0vwGDqHDGhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KsbyRsYos73yyDPCpkKl5JV5OdZ2xsaCh+55LwFQFm8=; b=eED1apRzQnRCGnfblkw+lDKvLO8LfPMPJeMbquB23U9jlBsMP3Hl9LlDx12w4cbYPG9k7Me2J2K7tor429ralLmay/78Fbd4vA0FDPjESaBDWNMoZIeOaf+vi22LQiA9GZ8LMlcslDlYWP2THIUYvLUyvbiUTIxEVpMxnjjpDF5b1XvNTNWXag98DZjtyDsXfQAmG8/T0LaUvEKZfyIbWgElv96aMkWye/CNga+K66hyIq0yDi9caC2XCvBgn35/DxuabVTh4T2INn9ziaAZH28SfF1hBbr6wm2v0zov83VeOopPlUJx/KKkGAFGvwM1KMC9tut6RAxmj3hnS7G0SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KsbyRsYos73yyDPCpkKl5JV5OdZ2xsaCh+55LwFQFm8=; b=pbdQNfdFsma0STjtqK2P7cq5VVYLSRzgf/eb/5o40NU/LZ2ASvmNMA9NYq3mL2aJGcNyiRWa+Nm1n3rh/+B/6C8OfYE11oNUt1NWNqA37ooVrmkNAVNYxwQvPzTw39aakrT3la+ZBsoACXnvZ2E3joMaQR86NH7ZnpCf/fgVu/VrHsImaLR71Jq47ux5qH6Q4Z0eo9eP1TdTNw8rtcq4N0obV+bDrIOjz2TbVI4UXWUzcLpF9D9HPokXNPJ3Ufeok+afLWy5buvPgLdaNu+If1/jocrWnyrEnmcMgGBL0YjSvUUz6mZDuSfJZn/aSnv0hNO0lZQhD2PMWSlj1muLUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 09:16:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM7PR04MB6998:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c9f6479-1253-44de-00f1-08db93287275 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OGaAGDlfQDZNjo+CPhs2fa2AGm6qoWf4d0PpGxVBSkxl1aZ2W7iBeih/PFrFCUOnJD4WYUYfQMDLG/5MwkDZc+iWBBzFu8rC3bDSS9uALcPgJtPmJ8Uxy+mxkwy+OfZuDJqxeRLI61AD5+fu1+xmC/Eu91cyO0JlPefy51s68wqIBjal/E9z65Oe0UpLiSQkD++6lMVpQCml4QILamgN4c9nQA+U6Ryo9BSAGWnm+Z8w7yNZrVBJNQdrWO7dAnkiJ8+nkwGIxRmUNHUH/3ubJPJDgYhR67rJmMAvd5tUafwo8DlylTn4MrmmfAtAo5fVsEnCHsZCXN+6fb/JSFf9Ra/090bqy19+6/K7a13dNobQucXAFOiLqptqwd8w/GIv82oOacq8DiMF3IYJ3F1aaC/g3NgCEeo6Lb0GEwg4Qm/zwMMv8LV57cxU8r9ydkWvPh5cnCpkfOg70U/M282jsJ9J4vN0kGMTeJSSzmXWhknAmRsWGTdpamba48I4wCsDwPd1tmVSd9AjTWJhA4fkkIP92dxWnANUuNXtVW6NdFX35Teee3yNzYdKWgSnl8M9Nmjvbiijy5GNbwUT9toMSPRur/PoLzjt8BntRhLbWEc88DMsMtI+g1bILTbdSCmLRMa/frtJtTVNHTQzibOv0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39850400004)(346002)(396003)(376002)(451199021)(2616005)(5660300002)(53546011)(8936002)(6506007)(186003)(8676002)(478600001)(26005)(4326008)(54906003)(6916009)(66946007)(66476007)(66556008)(316002)(41300700001)(6486002)(6512007)(31696002)(86362001)(36756003)(2906002)(4744005)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTNab3FiMDNZYzlNSDExSUFhSUtQcms5UGJUcWV5UWxoZjV4ekVqTU5QVGUz?= =?utf-8?B?cnVFNHFOTjMwY0QvekliZU1RYTdoeTFVWmJ5UjdKZER1YzB4U0V6UVV6VHNE?= =?utf-8?B?anRYdjV2OUQ2Vk5WTnRNa1VjMkYvMkRGV1UwNWFvMG5OaWg2TWNtMm56Q0ZH?= =?utf-8?B?RjhLYWpWdytQY0p4bmF5djNUZ0JnWmU3dU1JTE1lTndNcHQxUERFY2hvV1lN?= =?utf-8?B?c1NwdTlHV1JwdjZFbzJ0MlZrZXk0SjlIQjB5TnZ3WmxNdzZOaS9sZU9qTVlU?= =?utf-8?B?UE81a0VudnlHNnM5Zk9hcXNKUHllQnkzQ1BrZyswR1ovTXFJbUFpcER5REtv?= =?utf-8?B?SEZnN3B1S2k1OHFjdU1DalNuTEZwLytiM3ExT3FBS2NJa1EwSmdBTythNHE5?= =?utf-8?B?M1ArTEtuaDFaVnd5T0creGdYVVhSa2ZIWUNlaTlDRjNpNWQwVTVFdlRtYzR2?= =?utf-8?B?c1lUazJ0YVU2LzlFOFhYVlZmQUVSOHM5UCtVbjNjRU1TZUM0eXhoQlpGWVNM?= =?utf-8?B?dElqL3JSWC94Nk1ha21EM05mdXFraDVTb1NaMGMxaUViakdsNlAyOVI3NGdM?= =?utf-8?B?c1BTTWlpczF2blNHaDlDK2NTV0FTRzRINm1Cc28xdWFBSGtwNmtTclhUbGxz?= =?utf-8?B?cE9oeTZJdktGdHBsOExOTUNkZnhxVkFSdzRGRERCMzcwSTFROU5QMkVRejlC?= =?utf-8?B?azZhMWJVNjJLOXZxd2E5NGc4UVpGV1dmUHNaTmRjMkk0a3FjZGd3dm03MDhP?= =?utf-8?B?Q0ZVVFFvcmhBcXNmVlg4b0tSVEJJSjBrb0VWRzF3V0xvYWJiRlZLU0ZMaDZ2?= =?utf-8?B?cHBKQk9RdTdNZDNpOHppcEdyeWNUQzRUeXpCdWt2b2NBNEFTZy9zeUo0Q2Nj?= =?utf-8?B?NGNXbEVNdjZPeE92SXN4T0orODdQbDBJOW15NVNGMVpXNEIvb1hWWGs5citr?= =?utf-8?B?b1JqQmFtaUNraUI0SVFuNW5jMGVwM3ZBWDQ5Z2lzNXlHYlJQak51RlYvSGp1?= =?utf-8?B?SittcTMxRlZNcEk4T2NUMU13bWs5SUhLV1AwcW5wV0h1Q3VVZ1RIb012UWN4?= =?utf-8?B?aElqNlhETGRmNmc4SDAzYXN4STFONUtCU1dOSHZFQWxzZER3QmlqVmhiS2Fn?= =?utf-8?B?MXhERERlc3lrdVRxTEV4QjRFYUhRMk1wc0RTQ24zSTA5WmFTSnFtS3g1Z1Bx?= =?utf-8?B?czBXWlJrbE85bWVYbTNqdXhsQmNQSU9wZlZuVUNXcVB0Rzk5YTdRWTRnMVhK?= =?utf-8?B?YU1PNnpxRU1kSUx4QXEwK213QVlHdzFRZUltQ25XWjB2UC85cnUreUw5RVFJ?= =?utf-8?B?UC9jcXI0Y0ZrQUpmcXFVTzROS0t6UkdWTmg4MFF3czR0SFk1aUdaRFgxbisy?= =?utf-8?B?VkhQMzMyNzlpWlo1OWxSYnlDcDNtd1hwcXBHUFVLczF2a3A5MEc5czB0NmFC?= =?utf-8?B?aTJwYWZqRnIwWjRnVmdXR2R0NndsbWp3b25lTjJScGpRWjZiMTkyMEF4Ujla?= =?utf-8?B?UHBMd2pyNjFpckRLNDRJOUtZdEVONFBNeCtRSkZUTTRlRVd0djFyQVM4WmNF?= =?utf-8?B?YjE0RGloejZyZE84WGNhREpwVHg4REIvQms5SHV5clNlQUdaZEs4MnYxdkF6?= =?utf-8?B?YTNTYTBXd2tvSjZmdUFTUHA5OFYwZ1BIWEdNcVlHbUZBRml6eHp2ZjJ4cnMv?= =?utf-8?B?NUdYN254cSt1SWh0OENJeldMdTNuOEFqekdyTSswK3lRaFhTbUR6Z2kyWVRC?= =?utf-8?B?Q3lmSDhhd3VKVk5wNnNyRkNTc0pEMGNKVUdOVHpDUU01UFhJT1E2RytwT0NB?= =?utf-8?B?M1ZwWGJNTTVQaXNxdWMzdEhUM3UyQXFqeHozdGxDVjduL0pzUGYxcjdXNUZx?= =?utf-8?B?dnNnc2s3My9FUnZ1Ymhqa1VJVlpSc09sSkRscVRIZ2dPTHVHRFpFQVZndU9O?= =?utf-8?B?VU5iSlR3ejVGRUJ6bEk1eURyV2hlbmRLMitqSHFmYU5wK3hDMTNzbjFHalox?= =?utf-8?B?Vk5pTXN5cllpWGdLdnZZbUxsOU83cnBaaHRISnpUVERXbEdNY3NTVDJXN3J4?= =?utf-8?B?YTM0Y3NwcjBGbjBkUG9UZmo3Y0cvTWRTRmdqTG1oY2cvK3ZRRzdyS2UvWHlX?= =?utf-8?Q?v3NQBvE/R1DGS56uU4uSyF2PC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c9f6479-1253-44de-00f1-08db93287275 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:16:53.3141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9aIwMBP9bxMtRd7ALWMl5DuGqXeZd0D+G0SNgzuFFOHCLxOMQkMZuJKhl/PEUOaWthRSKw+E6xPGkURVkhCBFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6998 On 02.08.2023 02:11, Shawn Anastasio wrote: > --- a/xen/arch/ppc/include/asm/asm-defns.h > +++ b/xen/arch/ppc/include/asm/asm-defns.h > @@ -16,6 +16,13 @@ > lis reg, (val) @h; \ > ori reg, reg, (val) @l; \ > > +/* > + * Load the address of a symbol from the TOC into the specified GPR. > + */ > +#define LOAD_REG_ADDR(reg,name) \ > + addis reg,%r2,name@toc@ha; \ > + addi reg,reg,name@toc@l Didn't you indicate you'd add blanks after the commas (also) here? > --- a/xen/arch/ppc/ppc64/head.S > +++ b/xen/arch/ppc/ppc64/head.S > @@ -1,6 +1,7 @@ > /* SPDX-License-Identifier: GPL-2.0-or-later */ > > #include > +#include > > .section .text.header, "ax", %progbits > > @@ -11,16 +12,19 @@ ENTRY(start) > FIXUP_ENDIAN > > /* set up the TOC pointer */ > - LOAD_IMM32(%r2, .TOC.) > + bcl 20, 31, 1f Hard tab slipped in. I'm happy to take care of both while committing; then: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:22:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:22:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574735.900282 (Exim 4.92) (envelope-from ) id 1qR6BX-0004Gk-AX; Wed, 02 Aug 2023 07:22:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574735.900282; Wed, 02 Aug 2023 07:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6BX-0004Gd-6I; Wed, 02 Aug 2023 07:22:19 +0000 Received: by outflank-mailman (input) for mailman id 574735; Wed, 02 Aug 2023 07:22:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6BV-0004GH-Al for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:22:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1b::61c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e03c6a5-3105-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 09:22:15 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8106.eurprd04.prod.outlook.com (2603:10a6:10:24b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:22:12 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:22:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e03c6a5-3105-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Du1ULJ7lrsl5Z356G7qKKoAohXkUltzit5Es1uNAtdI8csayD5qZHQofQSCvg6u6ej4Sw5JvtGda1uFf/Hjxxg+UcpDv2MGFiddI3Y5tA7kFjhVHH/MgFWNKxLC+al+e5qeE490OglMF2vjuBq34JBEWtd5+9tccKZuLQL9YeRAlEu6iHP/NmOFmWQl1zZBfz17fiRy7VOYywnUG5maffGEnrLuzO2ELsmUsWAXSerMuQ9KtmNr3T2XHcFpVEX2B9uQe/4XF7YO5X27ppCZg1j+NvgKTPrMwV3cOAHsNe+GsimcatgIdCHUi3mKJmk56YjXJRFGxMVZMLIZAEWFf6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J+DUHtIaXyD72TldqUTpHnQTaJ8xCIyWshquJfI0BDg=; b=W32Mc3e8J5MMcbgPRpSdnupQJcPoz5/koavFDqNN0nobwchkQDZqVvhDyeYsC65F34e8KePMQjsFKPPFKEMpbZtDLlZV8JZcVv0JOOz9S4tLVL+NMXJ+ZHnOFLtmYeUJz/e9BOd3lBDPaDdiFZqOOF0mSb49xmdHUOslPVpKSPutHKEk+oGzkznqX2ke8CojvO/TKmLBLA0G0sw/cI7QlmmCzu0aBdCBA4r0UrCPpkVMiiG/FDRrcedWr96reIE6B3gmQQu79kVxqq0JU8+2jUvYNK9dO21sBvoF1UkLaEsvzBHcugdY3T2Uq1QmdhXfUZe7H5KcKCZ++baarL6gvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+DUHtIaXyD72TldqUTpHnQTaJ8xCIyWshquJfI0BDg=; b=Y23jqz1GXfec4Ul4ZF9VvJlCE8VnTqBCdBaZv3CDzF0k06Qbhc0Hy2iApYKNzgoAT21omcMLZsD2y2NhRdvYD3lvTpN4J+Gdn+2qrHH/eeSNKi0W/y1kdZeksjlcJOH3FVX/ITaSF33B8ItCCk11PIz2DX5nrgGv+5S/9H6kRnF+OabBH6W2FPkyOZt0FQr1JIf5PM+awA0qPo6gdcKSMFS1DE5Xw+Fz1zExCvw8TQYsNEQNeK4HMX7QSi67bO4VnZzmONvAQ4WR3p/LJ3U1zFyLLz50faz3lGj7TSg2pYcXD62PO6wNfE+eDc1gClQyC49AkMqbDn+1rnwA+yfrUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 09:22:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive Content-Language: en-US To: Julien Grall , Khem Raj , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel References: <20230801174930.2995947-1-raj.khem@gmail.com> <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> From: Jan Beulich In-Reply-To: <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8106:EE_ X-MS-Office365-Filtering-Correlation-Id: 65fa041a-8034-49ae-6506-08db932930bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TnnhvaBTQ6pg7xhQ2d9VAp3u5HOrDGNSFVjo/XLKF+7K4G+zphwK0xSWy/g2JqdaqV/6Z5APXk2ZtIX+Dw1M3BzHMGZKhnPFFNcwFoPQpd1x1qmM++SM56Zuiyo9ef6wyV6omm/R+FwnLFsZd0fHs+kx2VSSMI+iRPHX++h/gxk7ZCVVTMdLIiR5vB9fdVbLIyum12NqL6oFs6zmySr5FjhLQO3rH8Z5RrPqVY2EwGbi4LVduNZSg8xW+Ud4S5armkwQqByNyh6F6SQXnEcNlkrHm6ZVFf4uKgYo/QZF65jlFTm5EvqQuIomU2oilEsogs+1+SZWKWOqdA4RmVrTh6Ob9+pg28om0WXJGG7ZXtc4yIOMTgWsNNROmlBMyZH7idXUFtHhCvaxu9p81QV4M9uoHBqyzTbdzKVGFSN5V3G+Mwg7ysKWkz43jh+ZU44ig61h1eL/vP+R6P2FjIuElJb8++iyZjmVKrDc3Q+QI15N3fvt/L1NvAorqTInabcuWUt7gobxOvzVM+nwnBOQYt1g5KHwGSNtg4BZ0OBW44tbIIcCHu5+ZFFOibNxJzXimRABMzk6s9NYTo0O6tTRQHJn3o5W6h7ZJtX1cEYs62FSNjPxq9dFAqxZFpvcnXWX3UUHyNtRreRnDSidkvTxM1VvhjuBPECMOESc3iGIMS0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199021)(2616005)(186003)(966005)(6512007)(316002)(86362001)(478600001)(54906003)(110136005)(38100700002)(66946007)(66556008)(66476007)(6486002)(4326008)(31696002)(6506007)(53546011)(36756003)(41300700001)(26005)(8676002)(5660300002)(8936002)(2906002)(83380400001)(31686004)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nm9NTkZTcEFUNGt1YS85L3cvSkovS0ppdUhaN2VDRlVKS1AxdTR5RDduMFVY?= =?utf-8?B?MG91RlBTbjFiNmsxelExQlAxWW8zQW9RSmQ0RzZlQ3gyU0tmekcrdzZhL2Za?= =?utf-8?B?RGdhVEpzQkF1QjVFWWN0dGdHSTVyUllVclNzTEU4Y2l5VitpWmdwVWdHMTkr?= =?utf-8?B?WEFVTXYyTmV6S2ZpR3RBbGZkM0ZDVmJhcCsvdUJ6dnd3dFczNHVzQkpFTGxq?= =?utf-8?B?M0RPazEwTHdLSnVEUWhRR3V2UklBdEI3eDdDMiszSHlieFYzbVlIRm1MbElh?= =?utf-8?B?N1RsdFFDZ0JxTDcyMmdndmRFa0dsbDFFRWlneGJOQmxwSlYwMU4vZjlNNnNa?= =?utf-8?B?ZmxlYVhzdDUzRFROcXBKeXdPdE5lbXk5NmZuK0NMbFZtUzgvMUdTdFpTbUtM?= =?utf-8?B?NTlMREdabW9DaGVMMVI2ZnlsbUIwb2tzbjJMdVJSUWJGYUR5QXRWQ0J1MlBW?= =?utf-8?B?cnhLdEFlQ2prVStmUlVxWGV0NTM0MzA5cGpkdFJZdzhvMFR3UXRjSG5qK1pP?= =?utf-8?B?RG1FdHpiZDFBY0VoNXlxTVB2SVBZRGZFRk9yb00rMVlQenZkRlV0SUlzVHBP?= =?utf-8?B?dnViTGZjcWJMaW5iR2tTYTZNOXg4Qmdob2QzeU45b3hsTGJnQjVTMm13RlJD?= =?utf-8?B?MlAwd0ZkT0ZHR1NmeWp4bmo1alRIUWtOSkwyaGVPWk9XYzZueWU0bVBZMjFw?= =?utf-8?B?bTRTbFd3WS8vOFRrY09PR0wyYjlnbWk0QVJMVE94OExwT3UzcHVBUldtQVNB?= =?utf-8?B?QnhBRkdaaGxGOUViMGQ4WElhcmk4eE16OVc1aTg4bkZJSUVSczJSUnhtbGpI?= =?utf-8?B?eUlzWDA3aTRMcjc2K01jbCtoR0k4VG1hNk15RlVnNkVGSng4aVZNNDRTdVhX?= =?utf-8?B?ai81RjBlUG1vSGN2d0laNkdnYWRLYlk2Y3JDV3l2NEg4YXBKSUhtdC96bm1I?= =?utf-8?B?aVJWZEJTQ2FURXlkMVJsdDV4OVRYbk91NlJhN2cyWVMvWEprSnA1SGpHSjdH?= =?utf-8?B?ZTZaR3RrYnB1ODdneFJ3U05ZOVdZWDFQc2pnVityVGI1OXQ5MlAyV3p2emVj?= =?utf-8?B?QXpBZGo2eGRxaTIyTE9WbUMyRlBTUDFQQlVqc3FVOXN6VXVoNWxDMndOOVQ4?= =?utf-8?B?L1A1KytuQkZvcEgvRlN4MlZvMGc2L1JnZk5GKzhsQ1krbVJIUEQxVUJkSklX?= =?utf-8?B?Z0ZBOHIyRFUzR0VYbnFHRnJ5Y3NIdnFTQWY1NDZvRlAydFZSbk1ZcVMza05E?= =?utf-8?B?VGV0RG54aGt2c0w4UEVBYlZrOC9BRUk1d2hWbStnOHRIT2Y0RllzQTZIYzY4?= =?utf-8?B?U3ZrMzY2MGdLeDB3ekg1cW9jeHd6RXRJZXVDamVaUytvckdnY0FhQjd2bHJL?= =?utf-8?B?U2pQdDc4bVVzVjJpMnRvaStyWUtlVHo5R3BxU09EQm9PNDFSTmx2L3NuM2h4?= =?utf-8?B?aE43aVBWaG1Mekl1TTU1Rnl4aE4zclRtNi9jbWEyWEVuNm9tcVNGNStvbS92?= =?utf-8?B?NVg3d2Q4Y0x0UStVUjFlTmgyZDRzeXQvVlNmTFNveTZObldKSGdmVTYyenRk?= =?utf-8?B?Rjhtd0JaRkxmZ29MNnl0MDZ1aldmcmw5VjVQSjltYU1UdEEyVnRPYXpMYTFt?= =?utf-8?B?L2lLLzNxUGUveXNnUGNDKzJpZk4vYnBnaWM1N2wxaVVuQnJWNnc5c1RGOWxh?= =?utf-8?B?alNxZ3hZRDJmL2xyM1pBM216ZlB4QzY1Zyt5N3IraVlIdUdVMHYxdXJJNDJE?= =?utf-8?B?eC9BN3JhMWw4QVQ5NXIvMVZZQ1Z1anRjbVRSN281MUI1WWRla3FFK3dnYmor?= =?utf-8?B?NTh5ejQ5Y05IeldxZ01mUGZJaTFGODNwazFIcnV5Y3o2NFpkeFZUVC9SRkhL?= =?utf-8?B?QWE4cDIvRk5YUjRNNk5VYWlBWFNEOWV3ZHpldWx0NktWMmZtSVJ1dHg4ejNW?= =?utf-8?B?RjNkNkFpUmFZWjBNNXRxL0lkMVJmQUxNenFlVzlzc3FWbks5SVZpNWxQUEN5?= =?utf-8?B?OUxGVmthWnNOMFNUNjVrVDF1Tm5TZ3o5cmZmQmU3VXhnZkszN3JZdGovT0or?= =?utf-8?B?V0ZhajFjNGFRdTFVTGJYakVsQVJjemcydE81MmFRWDlrNlMxbUNEQ2Yxd3pJ?= =?utf-8?Q?lLERUv99xjjoNOtD2j7MVHME1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65fa041a-8034-49ae-6506-08db932930bf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:22:12.5402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EXsqwY9wDgQREcj4L41vvOyV0qDv38/tn7FZ6yvQqmWL/YQqn9r/5lx+Rw8QoEA2c1iB8SkECQsH4b9wJMd4Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8106 On 01.08.2023 23:02, Julien Grall wrote: > Hi, > > Title: This patch is not arm32 specific anymore. So I would replace > 'arm32' with 'arm'. This can be done on commit. > > On 01/08/2023 18:49, Khem Raj wrote: >> Assembler from binutils 2.41 rejects [1] this syntax >> >> .section "name"[, flags...] >> >> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] >> >> It is almost like a regression compared to 2.40 or older release, > > The next word after ',' start with an uppercase. Did you intend to use > '.' rather than ','? > > That said, the documentation has the following: > > For SPARC ELF targets, the assembler supports another type of .section > directive for compatibility with the Solaris assembler:" But note that "SPARC" was added there only by the commit introducing the perceived regression. Jan > This leads me to think this is not a regression and instead an intended > behavior (even though it breaks older build) even it breaks build. > > I would suggest to reword the commit message to: > > " > Assembler from binutiles 2.41 will rejects ([1], [2]) the following syntax > > .section "name", #alloc > > for any other any target other than ELF SPARC. This means we can't use > it in the Arm code. > > So switch to the GNU syntax > > .section name [, "flags"[, @type]] > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 > [2] https://sourceware.org/binutils/docs-2.41/as.html#Section > > If you agree with the commit message, I can update it while committing. > > We should also consider to backport. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:27:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:27:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574739.900292 (Exim 4.92) (envelope-from ) id 1qR6Gl-0004te-TM; Wed, 02 Aug 2023 07:27:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574739.900292; Wed, 02 Aug 2023 07:27:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Gl-0004tX-PQ; Wed, 02 Aug 2023 07:27:43 +0000 Received: by outflank-mailman (input) for mailman id 574739; Wed, 02 Aug 2023 07:27:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Gj-0004tL-M1 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:27:41 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fc73d92-3106-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 09:27:40 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-87-5-121-62.retail.telecomitalia.it [87.5.121.62]) by support.bugseng.com (Postfix) with ESMTPSA id 676644EE0737; Wed, 2 Aug 2023 09:27:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fc73d92-3106-11ee-b25e-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH] xen/string: add missing parameter names Date: Wed, 2 Aug 2023 09:27:32 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add missing parameter names to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). No functional changes. Signed-off-by: Federico Serafini --- xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h index b4d2217a96..805947d82b 100644 --- a/xen/include/xen/string.h +++ b/xen/include/xen/string.h @@ -12,27 +12,27 @@ #define strncpy __xen_has_no_strncpy__ #define strncat __xen_has_no_strncat__ -size_t strlcpy(char *, const char *, size_t); -size_t strlcat(char *, const char *, size_t); -int strcmp(const char *, const char *); -int strncmp(const char *, const char *, size_t); -int strcasecmp(const char *, const char *); -int strncasecmp(const char *, const char *, size_t); -char *strchr(const char *, int); -char *strrchr(const char *, int); -char *strstr(const char *, const char *); -size_t strlen(const char *); -size_t strnlen(const char *, size_t); -char *strpbrk(const char *, const char *); -char *strsep(char **, const char *); -size_t strspn(const char *, const char *); - -void *memset(void *, int, size_t); -void *memcpy(void *, const void *, size_t); -void *memmove(void *, const void *, size_t); -int memcmp(const void *, const void *, size_t); -void *memchr(const void *, int, size_t); -void *memchr_inv(const void *, int, size_t); +size_t strlcpy(char *dest, const char *src, size_t size); +size_t strlcat(char *dest, const char *src, size_t size); +int strcmp(const char *cs, const char *ct); +int strncmp(const char *cs, const char *ct, size_t count); +int strcasecmp(const char *s1, const char *s2); +int strncasecmp(const char *s1, const char *s2, size_t len); +char *strchr(const char *s, int c); +char *strrchr(const char *s, int c); +char *strstr(const char *s1, const char *s2); +size_t strlen(const char *s); +size_t strnlen(const char *s, size_t count); +char *strpbrk(const char *cs, const char *ct); +char *strsep(char **s, const char *ct); +size_t strspn(const char *s, const char *accept); + +void *memset(void *s, int c, size_t n); +void *memcpy(void *dest, const void *src, size_t count); +void *memmove(void *dest, const void *src, size_t count); +int memcmp(const void *cs, const void *ct, size_t count); +void *memchr(const void *s, int c, size_t n); +void *memchr_inv(const void *s, int c, size_t n); #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:27:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:27:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574740.900296 (Exim 4.92) (envelope-from ) id 1qR6Gm-0004wo-4p; Wed, 02 Aug 2023 07:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574740.900296; Wed, 02 Aug 2023 07:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Gm-0004vZ-0j; Wed, 02 Aug 2023 07:27:44 +0000 Received: by outflank-mailman (input) for mailman id 574740; Wed, 02 Aug 2023 07:27:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Gj-0004tM-S5 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:27:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2070.outbound.protection.outlook.com [40.107.7.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f7a321c-3106-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 09:27:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8343.eurprd04.prod.outlook.com (2603:10a6:20b:3f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:27:10 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:27:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f7a321c-3106-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LLJ1bccHBmM8NFJvdgXz9YumDHKh1xh76rscYl8UkkX1Sa/KXtfteUA5P1I0hOt0tu8SW0arXi3Pe4wZ8tLhsI4LI1JtCzZPUfNnnau7pLMlxjyc2bwshmQ92OVsdoG8HPddg8P4uiNm70snzjfZFyowbU4Fuz33BaBBhtP5ZFusIo+U2jo/F13w0C/2Jf1cHnemYM7O7ozPU9TsCvd9hIBajAc2jCO/BvrQpzXJfCdQFteGhFKWXEerQ9pnoO5KYt9PGKyqsz1jGD8Q4GuL/VnKFB24kt1crLx9i2pcwTTvjIr/V/q07gL/FE/mlAGCkav0vhUr50kPz7QMsogJsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5pRboXmPxAwZ6LRmPy3jmICi5TEhvx+Bu2Lh7GmNhJs=; b=dq7hDxBgh+B85l3t3GtP332ayiZdUp8OoU2Tfb3jLRle1f8dg54FTZmdpMV8G+gGJ+mKU37ZbZ3yqbdVdkLjV7wktOEdcE1jSCWqcTGnhgqz9BFSZozJoAXe0Mwq372yNzy0gzdJ72EJsyb/peFRkKLm5Y9G7QDKTwpku7ZbZKDlmmnI1CyBhcL1o/dumOzZ5mXiKws5oCGOVZ1z1mxbAo+mj5shyCHpFhBom7WxDwVQe6UHvMra9s0OcbXeWzoc7qME4g4FpUwgrRRA98DkQ+O2pXHJL55yMWL7XVBsnMMOU1fwUTtWXhFAj37MVFRWqFDAHEGcVohHAM/0DcMgog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5pRboXmPxAwZ6LRmPy3jmICi5TEhvx+Bu2Lh7GmNhJs=; b=2DQ1yXe7ZIWvFMCJAAm7if3/xI47C8MMbrXjoYY80Jl2ZwbkCzZgwF65ZObGDwHHmU6A8kkCHDCpL+FI4IjbwAw875sBeLyQIXWiJoNQckZenUsnyX8VdnAZXFO7gMQGNNs0ZQJ/v4uOoV94V98yHnvtyE2Js2fw2GwXfjy0ZKZuuc9JtCVEDQaqadZSu1oDWHmo7ZWPwyrQtPQLJFYqC/m4Po/i8YdCg9HCmRlmlXR1CH6sTQzVwNcUClCgYTGY7KpGrotVbQ0qOjffprFNLl2DrwTItdnO4FqCQsqAfxn9t6Y23Jr8X/zxCDvwPhnVb/84laJ6IeGnOF5RNdjOVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6ce3a936-e35e-caf6-b197-66441292bb9b@suse.com> Date: Wed, 2 Aug 2023 09:27:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20230801161409.25905-1-dpsmith@apertussolutions.com> <20230801161409.25905-3-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801161409.25905-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8343:EE_ X-MS-Office365-Filtering-Correlation-Id: c568ad1d-6076-4e58-c428-08db9329e258 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MxEXircvWrdY1uffGuTQ/+ZsfMX+94uzQRf91bTCcZJMcf9WEkXU0ayN5Qk845jgJJc2TCg3loH5sIAhakft1RApCeiX1SAt71gDXTQuZPMyNKGRSi6vlX2OAZKm7NPi7woUzpTGB11AOmmCG9yFfm6w84sT54zxQWvweNFOMaRrxilSASvliJ0vpca0h3vW1Akr3AUNvDqW/vjuXpvKxUtcM+yoZ+kdxf+O97Wu2QWgTkPjYngj+aDHgwQ08/cBi5mh/kvH27QGrtsxaSD/RZFhz7hD3gaHTmV9aq02LaVdor7rJT96h+KvCBxMeafSuVqRag2QFrG8Iw7QPEOnWN7RJpjHntSH7sKxjB0t5JYlB5vLRDzYj/8qt50KCLE6OY/9rVGkdJ/W+zKvJHf67YILiLQtWKDr4iGRSKcqg6P8IOdWvfdAYonaxKS1rdLOazlTP/uPOke8Mykjakgije4KLxbts027qEbeKYaz0R+vcIld15ZG4LA28cFddP0VK2VIzrC0XV5Pk8S+H+bypUYLIrUnOu1aujS87iVNA4CjdwQQWOtSIx+5tH72+Cyw1hlgaLpS1qyioC1yT67tLLRv0x4UF4mcdJFHgkN1KEBHQNetsKZ1/jCmUQmoB/0jKgBXmvbIr7eI6+2FoA6JtA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199021)(2616005)(186003)(6512007)(316002)(86362001)(478600001)(54906003)(38100700002)(66946007)(66556008)(66476007)(6666004)(6486002)(6916009)(4326008)(31696002)(6506007)(53546011)(36756003)(41300700001)(26005)(8676002)(5660300002)(8936002)(2906002)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHBZc3RPdFVLRWtrcnZ6emlib29ndEx5UUtMZzFZQnVidVZReFYyQTdPOVFt?= =?utf-8?B?RUFob1orajltWU1mcUVjaWRCZDJINFkxVlRIOVdXQWI2TnlzT2lyL3d4N2Jy?= =?utf-8?B?bEw1WHoyM3FPcThsc2Z5Rnh5SGpKU1hQNi9ZTU8yUk1NcDZlTjNWRW1hdTAr?= =?utf-8?B?V3VwbHkwQVl1UzFUT21mYzl4MGl1RmRPWDV0cytDQUgwNE0ycWFwYUtibUU4?= =?utf-8?B?N1BadVV5UjlOb3BHL0lLSjhTT1ZRU2lnOW5XNlJFVjdwbzRhQ3liZ2hQdnVQ?= =?utf-8?B?a2V1V1JFRDJjOHB2OWduVlV1TjRyc2ZEL3BkaDZVWituUXdQY2ordXpUMlAz?= =?utf-8?B?WmhxS1JISTdHNUJLSGR6aDA3YWdnVmVwNVVKSk9XMjFzcUxSVDB2bEFqRkNp?= =?utf-8?B?TE1VcGVvNTVYVXVUYnhZMVhBZEhXU3VzQlo5ZE9qT0NvTk1VWDEyQThRNXBZ?= =?utf-8?B?ak42RFlITEg1UlVQNWo2RWo0R3Fvd1o1YzF2WDJrQWNSblJPRm1KZTU0RGUy?= =?utf-8?B?MU9vWjhoSXNsM2Fac3g5a1QraGJTSDBNalhUTUd3ZG83L01QdytIS0xJOGJT?= =?utf-8?B?VFptaHJCVm9pTUMxcHZIa2RZR2N4NFJSU2huN0NjYlA3cTFhZzkvTXBmS0lV?= =?utf-8?B?T0lXWEI0ZGdWZityaHhTYWZ0TGdpRGZUY0lITlUraWZycm9hZmZXSCtobnJE?= =?utf-8?B?b0VGSWdELzBrNnNwclNVYndVVC91VE52L2NxeDFmdU5URm5HRHVxV2R2NU9W?= =?utf-8?B?VDVzRmQ4S2FCd2VRNmNGQVZpUnFjUDErbDhpMEVMTlJqaFNSUU9Mc2Y1clNU?= =?utf-8?B?amxyMU55TFdwNGQyQVVjR0ovR2VlN3RIa1NCRTlGTjlMdjFLOVhiSm9DcXAw?= =?utf-8?B?ZlJqMmFvZ2RNcnNOK1Ayb2pCeU95M1YwYlVpTUtZNkc5S05pT3d6SlhpZWpB?= =?utf-8?B?MTZKYVVUK3hDWi9RUDBhQlNQQUp0QlpkZlpKSjNOdFphUG12Z3p1V2RBVDEw?= =?utf-8?B?MW05MVJxUjNXdDZ4dHFrb0RmVE5UUXdCQUF0WEE4NzlramNZTXZlQ3lObU1V?= =?utf-8?B?WGhaa0diQnMzM1lJTzlLTWxnaFl4N1JyL0U3Y0RobkljWmxySGN2RHZKdFhz?= =?utf-8?B?VnljbTBtWDQyTGtUQnpQNWQvTVhWdEd1VnVKTytWMU5sZUxtdUtlQWlRRTlS?= =?utf-8?B?dlBYY3JBVGxZV0d1T3pjTWxPWnRUVEIzbDhWUmVpVXZKbys0Ui81QWcyRi9v?= =?utf-8?B?aTdJQjNqQ2dianBOa0grRVJOb2l2SUdkaklVVCszd2k1Q0o3YmVLYUxuVHRB?= =?utf-8?B?dGtKSEZQRWVBRSsvam5HY2dpZW9lcUp4Vit4OUpybGI4c001QTQ0S0tOWmhD?= =?utf-8?B?dnBxL0xHcncrSGpPdjdoYVl6MW5NdTdjRVFFRWwvUngzWXc1S2JGaVI3bk5z?= =?utf-8?B?aGhzcHJISkw2YWY4cHhteElhWVZUSFo1OG8zcmhaZEN3YWdhQXE2TUtCZTFU?= =?utf-8?B?TzRvRzVEbUs1eHhyaHVVL2NuazRQN3pUM3ZvbFlabElJV1FQU09TSCtwOHJk?= =?utf-8?B?dUhnL2VJYzhtQndCZmtoTUJnTWl4UGNSUXVIRlZEaUVueit0RUt2N3BpbHhJ?= =?utf-8?B?cmN0SU5uVGFKUGpZSXlIaXp4WE1odS82QTlFbWNYa1p1c1FtTGZwbE9TSWxG?= =?utf-8?B?SUZWcmJtbzNVemRUY1Z4VnpaTTh5MFQ3RmZkbmgyRzgwZTB3UkFlK1ZBbWcr?= =?utf-8?B?cHVja1dGYXJoUU51amFEY09tM2N3ZkZ2NmY5MlFRYlViMW9iVURSZlRUTUlt?= =?utf-8?B?VjZQTUhKOWt0MVpQcVZHYTN2cEQvejUvVHhWamcvS2FNekg1MEhWL05ZR1Zh?= =?utf-8?B?a1dVejVSek9WaVlnRU9oYVhWbSt2NGc2WDRnWjF0ZXMrdk9lVXNMdFpEZkVZ?= =?utf-8?B?OVBCQkgyQ3AwYkhML0ZFcURBWWQ4dXprWFRiQmdrZ0VLdlo5ckVsS0pXNjNG?= =?utf-8?B?ZVFJRG9tcTRjVzZCWGxvYlM0ZXFFUXdJM3pLa2NiQURERDZ0MkVVODcrdjdU?= =?utf-8?B?MkZhWmdIa0ZDT1hFT3lMNVdBM2tzRXBIcTB3Vkc0N2JFSFA0ZmRkcGVUaXVD?= =?utf-8?Q?gvv6R8M5te79WTYZwwBQPO+y8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c568ad1d-6076-4e58-c428-08db9329e258 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:27:10.4475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rgKh/Q3e6lyhwpQwZcgYndj/ZVWD+lQ6vl7OfLMZ7th0kW1iN1XZjxf1dUtD9PmTGz8SPhyjqL09kiWFyBjxLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8343 On 01.08.2023 18:14, Daniel P. Smith wrote: > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of parsing DTB files is needed by a capability > such as hyperlaunch. > > Signed-off-by: Daniel P. Smith > --- > MAINTAINERS | 2 + > xen/arch/arm/bootfdt.c | 141 +------------------------------ > xen/common/Kconfig | 4 + > xen/common/Makefile | 3 +- > xen/common/fdt.c | 153 ++++++++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 50 +---------- > xen/include/xen/fdt.h | 79 ++++++++++++++++++ > 7 files changed, 242 insertions(+), 190 deletions(-) > create mode 100644 xen/common/fdt.c > create mode 100644 xen/include/xen/fdt.h The filename here ... > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -303,7 +303,9 @@ F: xen/common/libfdt/ > F: xen/common/device_tree.c > F: xen/include/xen/libfdt/ > F: xen/include/xen/device_tree.h > +F: include/xen/fdt.h > F: xen/drivers/passthrough/device_tree.c > +F: common/fdt.c ... don't match the additions here. Also please insert in alphabetically sorted order, ignoring the previously misplaced final entry (entries), unless you want to take the opportunity and get things properly sorted again in this section. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:39:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574749.900312 (Exim 4.92) (envelope-from ) id 1qR6Rz-000711-Aq; Wed, 02 Aug 2023 07:39:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574749.900312; Wed, 02 Aug 2023 07:39:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Rz-00070u-7y; Wed, 02 Aug 2023 07:39:19 +0000 Received: by outflank-mailman (input) for mailman id 574749; Wed, 02 Aug 2023 07:39:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Ry-00070T-0I for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:39:18 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ae6d6273-3107-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 09:39:15 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 502164EE0737; Wed, 2 Aug 2023 09:39:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae6d6273-3107-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Wed, 02 Aug 2023 09:39:15 +0200 From: Simone Ballarin To: Stefano Stabellini Cc: =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein Subject: Re: [XEN PATCH 3/4] automation/eclair: add scheduled pipelines Reply-To: simone.ballarin@bugseng.com In-Reply-To: References: <76f3cdddcba485e8124659566b2f992b3b14da17.1690881495.git.simone.ballarin@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <3b62d7e9d7d630e2bc31f0579d3bdb1f@bugseng.com> X-Sender: simone.ballarin@bugseng.com Organization: BUGSENG Srl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 02/08/2023 02:08 Stefano Stabellini ha scritto: > On Wed, 2 Aug 2023, Marek Marczykowski-GĂ³recki wrote: >> On Tue, Aug 01, 2023 at 03:55:20PM -0700, Stefano Stabellini wrote: >> > On Tue, 1 Aug 2023, Simone Ballarin wrote: >> > > This patch introduces six new ECLAIR jobs that run only >> > > when triggered by a GitLab scheduled pipeline. >> > > >> > > Signed-off-by: Simone Ballarin >> > > --- >> > > +.eclair-analysis:on-schedule: >> > > + extends: .eclair-analysis >> > > + rules: >> > > + - if: $CI_PIPELINE_SOURCE == "schedule" >> > >> > If I understand this right, the idea is that someone would schedule a >> > pipeline (Build -> "Pipeline Schedules") and as part of that, they would >> > also define the variable "CI_PIPELINE_SOURCE" to schedule. >> >> No, this is pre-defined variable in gitlab: >> https://docs.gitlab.com/ee/ci/variables/predefined_variables.html > > Even better! Thanks! Then no need for a comment and the patch is OK as > is. > > Reviewed-by: Stefano Stabellini Here is a link with the instructions for creating scheduled pipelines: https://docs.gitlab.com/ee/ci/pipelines/schedules.html -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:42:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574754.900321 (Exim 4.92) (envelope-from ) id 1qR6V2-0008Qr-Oa; Wed, 02 Aug 2023 07:42:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574754.900321; Wed, 02 Aug 2023 07:42:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6V2-0008Qk-Li; Wed, 02 Aug 2023 07:42:28 +0000 Received: by outflank-mailman (input) for mailman id 574754; Wed, 02 Aug 2023 07:42:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6V1-0008Qd-IJ for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:42:27 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0621.outbound.protection.outlook.com [2a01:111:f400:fe02::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1fa3bf18-3108-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 09:42:26 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7249.eurprd04.prod.outlook.com (2603:10a6:20b:1d0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:42:22 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:42:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fa3bf18-3108-11ee-b25e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VQNDVesECgA8x0MH6Po4rUnBqEetg29KdK5Bmov0mumH14YwYpxuLI47MNE22NmVvEuryf41duEbODrCoruFh5du+lYLvU0/SBggm8/ZJtxZ0xWh3TvqZ5wYIpro7ZfS5dJFn45hRY3hgmO7Cb8x0O89pFA1juc8xvmhXL1pWP9AJAVprzPEEpJQEZIjCGk8QFeRIzDxCFC8nidzkpUUsA3H/4ELakvTtijtkHcitwJHaIwjpudajpK/iHpR+2ntX3d8yaX5yrk7skBBJdB8h77Hg1JQ/RBf3Y99PQHqp2OCszHJMuOmJ6O4HOJEk4prUq4VRAccI0JI0Vsjnzul5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Wn7uAtj3uJy6zSmTzq4KrF5V4bBuF2v5ugXcovyBDE=; b=SrKunJLJ/OI7kwx7ZSVeB6pfZj9M+8+AXqL0EL4gByuRBrO5fiUU013mAdSqXI6AEqoa7G7FHdPPYH98CuiAZc2Fm1/5A/gQQBzfu1gmoUFFSJGdzCGv/4L+aYYFd+CZnoH/cSLhYdFpKVcNrPgf12Qx0r/Vaj0U/xev4KLqRL71aoxPooV1qfr+KVL9yTK3Pcl5Qqp1KQ+Ko6SOTxed+PpNDih0i/DNtMG/fohq3OHjam7yT5WWSaq5ym6sG5O9fY+XZINgR/ptMGWsbTwjAxd+TpqIlJWfh3AS4oA4rtyN8wVMym5nm/3cPtd4lZz3SznxxeoZjW9uNc492xStGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Wn7uAtj3uJy6zSmTzq4KrF5V4bBuF2v5ugXcovyBDE=; b=NC61oG0Qj0OAvfkfdgOKSDidS6dziIC3FdxJj5v26/AOc/uKlJq+NyNmDAbbZ0GJk4iGptS5x29b0kxmRjyLpT9RbRrRyplz+alc/JkQFdXZ1SOHWTq3gNHWFXFx+LugRv1jy72pdWYuZhlo+w9cCdEZry6RFEZpqX8A/gWkeNbZiUngT224B1v4kolAnWdEqMiT0E1hGMaBDLWPRimYY2KQ99+XaSkK5L+LGh6rHb+nS2DK4JNWjh3COmzwlYteDufKH91zze/AG1MK7Ii+cuYvLHHnn88dhMFG7THm6EUsz5l6JuEeCqSZdxKBXN6Ua+R5CKXI0P31EHITLgOoww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f4c0430-42ce-bb2c-3755-d5f6af8e3b40@suse.com> Date: Wed, 2 Aug 2023 09:42:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 1/6] dom0: replace explict zero checks Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, xen-devel@dornerworks.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , roberto.bagnara@bugseng.com, "Daniel P. Smith" References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7249:EE_ X-MS-Office365-Filtering-Correlation-Id: c51bc3a9-edfd-40a0-4227-08db932c021f X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6J5eUIwCYel/77T3DMmFnaiwVK5vKE3gWvBZmpRNQw6g7BJCD2T2ov767TfIeD9d7wT1+VriwKhTdq6RkuSZUNdBkaPQv7AFD3vlw7zztPj/7+xdzOLjLkvq16iFp8FWit7OVeYzSp6e2yQ/gb0loLXwmUgysKBmpPy6PIlGG2LdhPaOpKmaTYMG7vl+03i4hh/UuvQbo5bvJQsS+bQD03BoqzEBHShPC9bc/eBWiqVQl17ZOaFFMtN9DXwuhZBJy/rlh2zSXFhGUzEtlNmPZtC2yIi7EsQQrnIT8nt+FChZffctXUZ1wk4zakasgB3VppITrteBDCQQVFSdFHT2ZgOb+ywJhb+6bQojecxln59oQY4SlAdMPE9h1ttqRVnrZEhdCHRGT6Oyr0GNY95EBCqdl0keveplw7g655s0kEIOvXphvwoeRfdxu60O5q3xOyKt40vWVY9WUICjjMPuSRIsTIF1aKJGYMsaQ6WDLDhNmmvPhlzI78Kx4LfRTwf9VxD/VdFPYqDGwD+W19e1NzqqyY2vmkXwwJSKl80gaOkEHuTAS8CqHF2OwDhlbk1udPIKnhvkvaelsk5Fig7Jp+75nKf5bYjwuzm6hioGHF+6MKIMHEPEH1DZpbSrmJmU2wla8RQU6ltrPOO6BDSung== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(346002)(366004)(376002)(451199021)(6486002)(8936002)(8676002)(478600001)(54906003)(31686004)(6916009)(316002)(66476007)(66556008)(4326008)(6512007)(66946007)(38100700002)(41300700001)(186003)(53546011)(7416002)(6506007)(26005)(5660300002)(36756003)(31696002)(2906002)(86362001)(4744005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm1RRGVkeUJnUURBQlZiVWdmd1o3My83Nm80OUl2WnBVT2VqSFEvVVpxa3RS?= =?utf-8?B?VzIvT2o3RC9KUzVsV1RNRkNVVjBsR1p0WXN4OGJobEI0TGU2anRJbndXaGI1?= =?utf-8?B?U1VPaFVGeExVMzFKYklGL1oyNTRMTXZuMnRHaTZweUhyeldwM0J6dGZINTZx?= =?utf-8?B?SWNkQXNlT0I3c0pQZmlBemdIL2tlRFhhV1FRNXJvRUFJQnpiN3JRUlRGdXJ1?= =?utf-8?B?c1ArNUZsdllUWWlqd2E5cko1RENyZTQ2Ky9IT1hTVERRdG9aZU51SnRMcC9U?= =?utf-8?B?akVqNU9VNTYyNTIrazhwT0s0WW11VEJPMDQ3VDlqNlIzdTdXdWlpK21nWGsw?= =?utf-8?B?SEVtblV2MGxIZXYxQk1uUnhEOWUwZUdERDdGdTZxdTQ2NXJlZmV6czg2U0dH?= =?utf-8?B?Rld2OEw3djhybGdtL0VFNklCUC9PQ2kyZ1dkZStaZFJyaitvRzBGU0ZRTE5m?= =?utf-8?B?c1QrRFptY3JLMXU5RHNVRGM5QXJOWTREbWxOYWZqOFpQeWorWVljMWRiOHY1?= =?utf-8?B?Y0djQVpzU1c5RCtTVFE0ZE9mRDVPME02c2pvZ0hwSlZZSWxWeTkrU2hHbjl2?= =?utf-8?B?R2FWZmFZWmQwcUVRd3Vud2phNmFhZytjdUJlR3gxQ1oyT2pBeU9ic0g1VUV2?= =?utf-8?B?dU1vanRXRGtGc0RicTNXamJHd1p5ZEM1b3hJNkVZL1hXWmxyZmQ4QjlaTjhD?= =?utf-8?B?Qm1JN1lCSDZjU21zdVppT09aemdLbjcxaXM2Y0JGaTRBUDlQYjNTaDZlMlho?= =?utf-8?B?R05ueUYrMUVhQnpOcTdWU3JBeUU4OHlUbkJXOUtzSVhtamMvWElhbjE2Y2pK?= =?utf-8?B?NTdsNitiMFRpcVF5RmRRbklMdzdYL1FTbXhLRlhCbi9pcXNkbm1wVXlZZDNx?= =?utf-8?B?czdpYW1aM2dlMmZ1ZU9rMklCb2Y0cVZtQVRrSytnN3VPZTVMajVZNThIRnNh?= =?utf-8?B?YW42YS9IVFNaRXRYM0xqNEZHb2V6Ukg3OHhoR2dDRXNMeU5GSmZQNVFCR3Na?= =?utf-8?B?VmxtSzBLaVNXVTZCSGhFQ1ZMTC9GZ2kyOWtzUzRnTDJwUEprUEFKdDIyNEJ3?= =?utf-8?B?MnlORXN5NVc4MDNGTTZQcnFweUJxUDBhdURxcTl2VUxoUlRMWnY4cFZZSnd1?= =?utf-8?B?ZGViVktaMTYzcUxjd2dqd2cybHdqYTdBWDE1aWlaWVpaSjJkdjBSVXJCUHNy?= =?utf-8?B?alZGb1lUK1MzNlkzdWFFTWJLSHdFTlQ3aHVNVTQvaDRTTnEvRDhTMGw0dmk0?= =?utf-8?B?TXpnYW8xYi91N1p3TS8zSnZkOVM0MTVRSjExRnhwR3hpOGY1S1NmQi9vbmdX?= =?utf-8?B?dGpMRTNFSkQzSzRqZlpVS3pTYktPYzQ0OEJZZy83amplRUJnNk04VEhJMFlP?= =?utf-8?B?ZUUrNWZ1RXVvR0lyeWJBbnV4Umw1elovMnhQQTZyak42WkFKNmZkdWhHOGho?= =?utf-8?B?QnZvT0xUSGYzSWxjVkRQbE1ZS3NPMldXZldNNnBDeFhPYnozMUlxNTFCVE50?= =?utf-8?B?d0tYQ0xWV1NqaHFGKzBFdUJQKzhDa2hXbnlqSkVucEpNYUpVK2tRcGNlUWMv?= =?utf-8?B?Y3dXWmd1YVdKbFpOWkN1eFB3dzZwUWN2eVRnMm1FRTF4QXZDUjg4ZnVZZlcx?= =?utf-8?B?VHByWXhYRXgyUHZ5TldVOG9zU2thazU4V0J2MktSMzZSUHRTTTlSNjB3Sldq?= =?utf-8?B?K1Yzb0MrRlNsQjh2cmJaWE9hS0dpSktkaGlwODhPT1JYTUxyZjgrU1g3S2I3?= =?utf-8?B?K0QzVUo3L1ZrTm9ORElzTm5BQ1krVlZ5Q2lmejdzQ3JwbHd4YUh4OWV3b0k1?= =?utf-8?B?ZFFxWHlWbHl2SWFQOGJoZFZvTmlWZ0VFdmsxTXRYNXlleFRBaVdYWFhqNVEr?= =?utf-8?B?d1dib1pUcnRRclV3SzNRL0lidTJqMnFrM2MrWWRLNUhnZHU0K0RUM25PNklk?= =?utf-8?B?SGY0bm85cE1PdHJGcFY2QWQ4enVoSEVlY3FYQnArSFZNZjd1Q1dERGNJN0Ux?= =?utf-8?B?YmQyTUljUFdmcUl2UzVDZkJUcnJWbXZrVUUyclVkeStLd2R1Qmp0NzVoNDlj?= =?utf-8?B?bUhKckNUc3pRZUhtclpyNi9EV1Y1ZWFrNXdjWmM3RWR0YXBrVVhBTmVzM0JH?= =?utf-8?Q?XCpg/IMbbqpZ90FxhxTC9Fpt/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c51bc3a9-edfd-40a0-4227-08db932c021f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:42:22.7841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6pO78Epa877BiJzPIVoz+XU0DqpNizOcOVy1aXi8GyJeRSi48dog4FTX3OT9R0Q7ACAmg8zRoYUm/FbDspE9cQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7249 On 02.08.2023 02:24, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Daniel P. Smith wrote: >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -1058,6 +1058,13 @@ void scheduler_disable(void); >> void watchdog_domain_init(struct domain *d); >> void watchdog_domain_destroy(struct domain *d); >> >> +static always_inline bool is_initial_domain(const struct domain *d) > > I know you used always_inline only because is_hardware_domain just below > also uses it, but I wonder if we need it. > > Also, Robero, it looks like always_inline is missing from > docs/misra/C-language-toolchain.rst? Or do we plan to get rid of it? Under "Non-standard tokens" we have both __inline__ and __attribute__ listed, which I think is enough to cover this specific case as well? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:43:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:43:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574757.900331 (Exim 4.92) (envelope-from ) id 1qR6Vj-0000Vn-0W; Wed, 02 Aug 2023 07:43:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574757.900331; Wed, 02 Aug 2023 07:43:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Vi-0000Vg-Tz; Wed, 02 Aug 2023 07:43:10 +0000 Received: by outflank-mailman (input) for mailman id 574757; Wed, 02 Aug 2023 07:43:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6Vg-0000V1-U1 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:43:08 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3907be46-3108-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 09:43:08 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id BF9504EE0737; Wed, 2 Aug 2023 09:43:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3907be46-3108-11ee-b25e-6b7b168915f2 MIME-Version: 1.0 Date: Wed, 02 Aug 2023 09:43:07 +0200 From: Simone Ballarin To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein Subject: Re: [XEN PATCH 1/4] automation/eclair: add support for tag pipelines Reply-To: simone.ballarin@bugseng.com In-Reply-To: References: <5e79b954062385c4d765c32347bcb45896d3ed5e.1690881495.git.simone.ballarin@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <35333b6e9a43c6b3cfb27b0808689e66@bugseng.com> X-Sender: simone.ballarin@bugseng.com Organization: BUGSENG Srl Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Il 02/08/2023 00:54 Stefano Stabellini ha scritto: > On Tue, 1 Aug 2023, Simone Ballarin wrote: >> The ECLAIR jobs fail when triggered by tag pipelines (e.g. >> xen-project/patchew/xen). >> >> This patch extends the integration to support such pipelines. >> >> Signed-off-by: Simone Ballarin > > Acked-by: Stefano Stabellini > > Thanks for the fix! One good suggestion from Andrew would be to check > for required variables at the beginning, rather than at the end. As it > is now we are doing all the work just to fail at the end. It would have > been better to fail immediately saving resources. It could be another > patch :-) > Yes, this is definitely a good idea. I will propose a new patch. > >> --- >> .../eclair_analysis/ECLAIR/action.settings | 24 >> ++++++++++++------- >> 1 file changed, 15 insertions(+), 9 deletions(-) >> >> diff --git a/automation/eclair_analysis/ECLAIR/action.settings >> b/automation/eclair_analysis/ECLAIR/action.settings >> index 96426811a8..71c10d5141 100644 >> --- a/automation/eclair_analysis/ECLAIR/action.settings >> +++ b/automation/eclair_analysis/ECLAIR/action.settings >> @@ -41,7 +41,7 @@ github) >> push | workflow_dispatch) >> event=push >> # Extract the branch name from "refs/heads/" >> - branch="${GITHUB_REF#refs/heads/}" >> + ref="${GITHUB_REF#refs/heads/}" >> headCommitId="${GITHUB_SHA}" >> pushUser="${GITHUB_ACTOR}" >> ;; >> @@ -75,7 +75,13 @@ gitlab) >> ;; >> push | pipeline | web) >> event=push >> - branch="${CI_COMMIT_BRANCH}" >> + if [ -n "${CI_COMMIT_BRANCH:-}" ]; then >> + ref_kind=branch >> + ref="${CI_COMMIT_BRANCH}" >> + else >> + ref_kind=tag >> + ref="${CI_COMMIT_TAG}" >> + fi >> headCommitId="${CI_COMMIT_SHA}" >> pushUser="${GITLAB_USER_NAME}" >> ;; >> @@ -99,7 +105,7 @@ jenkins) >> jenkinsBotToken="${ECLAIR_BOT_TOKEN:-}" >> >> event=push >> - branch="${GIT_BRANCH}" >> + ref="${GIT_BRANCH}" >> headCommitId="${GIT_COMMIT}" >> pushUser=$(git show --pretty='format:%aN' -s) >> ;; >> @@ -111,7 +117,7 @@ esac >> >> if [ "${event}" = "push" ] && [ -n "${autoPRBranch:-}" ]; then >> # AUTO PR Feature enabled >> - if ! [ "${branch}" = "${autoPRBranch}" ] || >> + if ! [ "${ref}" = "${autoPRBranch}" ] || >> ! [ "${repository}" = "${autoPRRepository}" ]; then >> event=auto_pull_request >> fi >> @@ -123,17 +129,17 @@ pull_request) >> jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: >> ${pullRequestUser} wants to merge >> ${pullRequestHeadRepo}:${pullRequestHeadRef} (${headCommitId}) into >> ${pullRequestBaseRef} (${baseCommitId})" >> ;; >> push) >> - subDir="${branch}" >> - jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: >> branch ${branch} (${headCommitId})" >> - badgeLabel="ECLAIR ${ANALYSIS_KIND} ${branch}${variantHeadline} >> #${jobId}" >> + subDir="${ref}" >> + jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: >> ${ref_kind} ${ref} (${headCommitId})" >> + badgeLabel="ECLAIR ${ANALYSIS_KIND} ${ref}${variantHeadline} >> #${jobId}" >> ;; >> auto_pull_request) >> git remote remove autoPRRemote || true >> git remote add autoPRRemote "${autoPRRemoteUrl}" >> git fetch -q autoPRRemote >> - subDir="${branch}" >> + subDir="${ref}" >> baseCommitId=$(git merge-base "autoPRRemote/${autoPRBranch}" >> HEAD) >> - jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: >> ${pushUser} wants to merge ${repository}:${branch} (${headCommitId}) >> into ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" >> + jobHeadline="ECLAIR ${ANALYSIS_KIND} on repository ${repository}: >> ${pushUser} wants to merge ${repository}:${ref} (${headCommitId}) into >> ${autoPRRepository}/${autoPRBranch} (${baseCommitId})" >> ;; >> *) >> echo "Unexpected event ${event}" >&2 >> -- >> 2.34.1 >> -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:47:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:47:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574763.900342 (Exim 4.92) (envelope-from ) id 1qR6ZU-0001Ai-Gr; Wed, 02 Aug 2023 07:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574763.900342; Wed, 02 Aug 2023 07:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6ZU-0001Ab-D3; Wed, 02 Aug 2023 07:47:04 +0000 Received: by outflank-mailman (input) for mailman id 574763; Wed, 02 Aug 2023 07:47:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6ZS-0001AV-G5 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:47:02 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20603.outbound.protection.outlook.com [2a01:111:f400:fe16::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3c88916-3108-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 09:47:01 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB6831.eurprd04.prod.outlook.com (2603:10a6:803:135::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:46:57 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:46:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c88916-3108-11ee-b25e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0zPL0yEK4l8cgjLTQPuk4pjf15gYTy5TbwXnN6F/gCxAdhtWOPuqnLjDeeDeoPsucIsaOkOU4yLpH8t/moUotEbl35FsQYUXGpYSEIwx0HcE+7n7VtfLrW1DhU56rWIJ1A8M8uvZdhAEkjqLVrtmg1wQwcHKfJtBMiQ9mDZN8YLiGirCf73MFUSFeMaU/mDUbTxrkrXq8dfYcGLfjdlqdGXgszEtzqSw9XFq3nsj8YfMW4Sr+XbX2NckI1rS1+JaZjGPS1Nrac/rqbk/xj/ctCsgLTX+FShtGfvsfpIsUXxeyODSNW9NvYOyLaUEvL9zSyD1Fd+lDtbqLSFIjR64w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0s7bvAesuRkdCPN/OC5YevGNnXHQrUja18fb/4dflmA=; b=FNFWm3tGa+78Z9xxF2YxFGAniUXeSPIfCfnVcjNgtTcCzxJy1Kc6eFE9Z1e+00bjisR/zF2tbEgv4sNckDSYTCh7H5zPtg4HL5c6Za+GcJYO4CtyMGix4QFMKAI5kx4JOFj0vQvCpc62qC1I9Wo9N4Fnfq3zrUyMA3SVipuMMTdOjHZU/uFOMifGsD2HjMBaRJzfNLhkIhR2eojXvsSjuem7qt+Nu98oUpZRRRTORzibfDj81cETRIHavXfUju1/+Fyv4AlOsYqxEmHJZlE5AaK1bx+LAEyhwpqNMnYHb5ynI7jxVy5gexemJb8XtppmQmasI4Sjsbpk6JOr4eSWIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0s7bvAesuRkdCPN/OC5YevGNnXHQrUja18fb/4dflmA=; b=oQuPiYvki1z+gQ8rtBv60E7cKtTqWdnCV0zP1X6lt8uHlydu4CXncuetO5fGNT+7inqQJukqcdvhSrk362BEGSAcQB9Zadj78UyM2ya/brNUbCFcFtKz0jM/0WzCY6wfKYXaqn9ZGwiNA0N4MZKGcdHvj/QfNj+6An9TVGwvP+gCYr1PfmHaIelLGTz66pj7sl13F1eEUsor/83ICGG60Tlrsin8PuQ7s7y7a4Nc6TW9jBXr8zNjPGHfb3GfT0BWow0JBiEokvZJWvJAEhxYnInOHs5j8+DH8YFXDAaHH/2WUYJRbo6aNYtDFkIaWnqJ98LVcEgbjgO260FYuPc3TQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 09:46:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 1/6] dom0: replace explict zero checks Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , xen-devel@lists.xenproject.org, xen-devel@dornerworks.com References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801202006.20322-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB6831:EE_ X-MS-Office365-Filtering-Correlation-Id: 9823530b-271e-4e24-88aa-08db932ca58c X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9/NKRCnT7KmyRL5xCPQs+f6zA4a/XS6dBaJ4xwpjDNJP4cxVhSVrJkPWJJajX/7wVvXhwNLIDJlmjRi+Xuu9bTW1OmRsJ5aLZP/3FQ+TbcCwE6IlvnUo9wqzKO1obodSe73nuc0Im6AO7ibvluzHW3qaPK5fXRzlv9WdAcFqR17X+L302XSbbe4QwEEeY+3L5o7ghOH7p7UU+c1WdRI2RxWFXjkW8l5j5cX9jXjy2ZImoEf0Fm181nHOfWD8Y7mgz10TOHWStUiacoQuEgp5xchA0OYGS+6GTMkomAZy0DkDmKWcO9v/lpV/IxrpA602nuhvkADPhg4JlvMuOBBXgCM5klIXXp090/RvRx32X45Q60GwPNG3ldYHkfhya9QbT2XDUlYtJwzWrczBGt8bHtsamGLRPs1QYFLYh85A78BoyhjT19qKjMptA87wSxhFIWnSL0ghRU6ErN3WuP9YxEraIvUAAf+BAFncGxNTzfq432hd+0/mMUc5JiJhZVw3T+IUbnO2him0IC96YOJ1qDEW721PXu4lonROP/X7/7CbeBlHRVZ0JbD/0kMwfmDKPnwjTNyjiElNVquP7eZY/alSztHkqi4LvuOIgH1GNlPEUvSL2FawL/FAa90VsJyfwR//Eih7wCmLX9+swRsY+g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(136003)(39850400004)(346002)(366004)(451199021)(2616005)(186003)(6506007)(53546011)(26005)(4744005)(316002)(66946007)(2906002)(66476007)(5660300002)(6916009)(4326008)(7416002)(41300700001)(8676002)(8936002)(6666004)(6486002)(6512007)(478600001)(54906003)(38100700002)(66556008)(31696002)(86362001)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHRrNzFuZ0hqc24wV1h0cDNaSDFGOUphWFdqMzNocjVaRnNCbkQybVNoU0VT?= =?utf-8?B?VVhKTkRTZXZqcTVvdjgyZFRvYUxGaS9MTUFNL0VwVmp4eVVrZXRNWTliSEc4?= =?utf-8?B?OU1EM2cxZzNZWGZPZ3A1Sks3Qm51NVRaL1lGc1pNd3kwNmFRWjR5VlBBNGhE?= =?utf-8?B?K0UzYmhJenhhL1VlSjMxUXJ0MzMyL0JNTDluN3R4K0gxd1hRZENwNlcyajlM?= =?utf-8?B?QUNIOG1zRW5sNHBaVkNJUmFPSUExRkU5bG80dkQ2eTBydXhWdUJwRnFIcS9P?= =?utf-8?B?TDhBcS9ldGF2bG1WUXMwTVFYckFVdVNlMUltWTBROVQrMGdSZWpZUk9iR0Vj?= =?utf-8?B?anpOUmxxYjVvL0RJOTBrNHFhY1VCeGVuMTFZQWpEMmNFcnM4ZUkveFVrSXVH?= =?utf-8?B?TVc0dEh2cXZZeHpoaHNqZFpFbEFCMFZEOUNpOE5GZjg4Z1BpVk5BamVqKytN?= =?utf-8?B?NiswSzVpSnJKZWYwZGRwc0svMXdwdEtSYXRDYjhCQWtRZUQ0NUVRc1AwMk1q?= =?utf-8?B?RThGVDNCK2VPYnBDSDduMER3QThqd1h0WlE2SForaytLazVlMzVMdGQ4U0Z6?= =?utf-8?B?QUljcEpnYjBIcjYrN3YvTWxGTHZOWG5kSVkzSVVvdWxYUVJMb25BNmpUclJU?= =?utf-8?B?NHpHVDZiZFNUUkozYkludm94N0tjcEtNYk5DZzhRMUYzS25saXY2c1YwN2lU?= =?utf-8?B?UWdMcldJdXhiQVFLNmg1cjZzS254a2xVRmI2YlVMb05oeTBBd1dTWHVEeW52?= =?utf-8?B?Y2xrQVUrRTZIUjk3cThxTjVKeWRXWkJIN1c5MnF0cmN5NitaVXRiSVdsNDlh?= =?utf-8?B?NFpCUXVVaDR4K1pYaVhPUWxQb1daTWVHdnhIZ1hEUDJMTHFEZTFwL0E1RkRZ?= =?utf-8?B?S2NLY0JWSnd1Q3JDblhkUTVwWFRHOEhJOS8zUHZYMDYwVXFaUVNpT3cwMzFN?= =?utf-8?B?d1psQUdsQW1rNXJlMEZOQVRCSmdMSzF4MXdNKzNOZWhKSWJjT1FHekh4S3pl?= =?utf-8?B?NDhYKzBCOVYvdDhoQUEvdUlRYkd6OFlHT2I3aElYUXhTSHQweXY2VzJNTFR1?= =?utf-8?B?eU9UMTdWNnRBdlg3ekFYUkZoeFo2NzRFcDhiMkVBaGRDYXVSSE0yZEZzenA1?= =?utf-8?B?RE14RVUwVXMwcUd3enB4THY0eWVUaEJYTzlJRVZBZnpzV0JJeC9NenE1UU5I?= =?utf-8?B?cWRkTmhiWGI0c29Xd1dBZFFwYmwwVjRSZWVkNG14L3pDdGxNM2dDKzBjUmRX?= =?utf-8?B?VWJqNFhRUlFZRDZUd2tIT3ZJNXJoM1NnNnQwL1VQUnlNS2ZmT0VBZGxncy9D?= =?utf-8?B?aFFaOWZ1WXZZYlBTMG1MTWUxVkdiVTkzZlUwQi9CckpCVG1ZYVhoL3lNL3g1?= =?utf-8?B?UWZ1UUJNRHJJM2h5SDdaWlFTUFg5aEVFa01aNTNLeWlnaHNMY1J4TXJJRjlX?= =?utf-8?B?eGhkcnQwVnJ3N0dEa0RDVWV4cTJ1U2JjeFlqSTAxUU5tNkhnWjBBbTdLY213?= =?utf-8?B?M1Qvd0MvajQ4WjQ3dlRzT1Z5bWVZc3RvSmZuMkJRTldXQlZuZmlWcVB4UlpJ?= =?utf-8?B?SkM0UUVMUGVRVUdVVTJqSnhMUFN6M2lCK3BaTmNDYW9ndDdhN1ZIZXNlQlpG?= =?utf-8?B?Z2xBNm50N1ppaytLSXFvMytRaFNhOUxEY2oxcmtlOWdFOXY3UXAxb0YwZ2ZL?= =?utf-8?B?WGhDMXNkRC9WS3lhSGZiTVg1YjQ0by9tU1I4cEpWc0NOaDdoQ1QvdDRNNzBt?= =?utf-8?B?OGFwQ3VEY0IyRXdsaUdraC9SeG54K0dBMGIyVVc4djRwd2FldFFPRklHRzVV?= =?utf-8?B?Y01haVgyeXFXbDBZT3R3b1IwdzY2WSt3NnJVa2haQVNCWGJOek1NODhCbTg3?= =?utf-8?B?M1duYU1Ib2JKdlAxWXlzdGp0YnY4ajlwQkRxam5XY3dSWCtzNjRwQXRLU1g3?= =?utf-8?B?algxNHZIMFNVQnAvOEhrMmI1aURMMVlTVnpXRkNTUStPYno1R1U2UFdGSWZp?= =?utf-8?B?cjVCb041em9QZ0szNU5zSmNrdlI0dFRWVTY4ZFdHTkQvWC93R1JaQU1WNWZw?= =?utf-8?B?a20wSHlqd0FJSFVhN3Q3bDB6ZEs3dldHdmw5bDNDaTlXYlB2enV5QUIzdi9I?= =?utf-8?Q?ChWJHXHwex9wWrgmSjxGpT0YU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9823530b-271e-4e24-88aa-08db932ca58c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:46:56.9465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ShRE0KPKVAkn8/k9JjdLfGC83Smt7YmJrE+8oFpYMkZNLepWIXDsofQUMSyKvGL8Yr0ylRmoC5hBu0Nt+B0nIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6831 On 01.08.2023 22:20, Daniel P. Smith wrote: > A legacy concept is that the initial domain will have a domain id of zero. As a > result there are places where a check that a domain is the inital domain is > determined by an explicit check that the domid is zero. It might help if you at least outlined here why/how this is going to change. > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -1058,6 +1058,13 @@ void scheduler_disable(void); > void watchdog_domain_init(struct domain *d); > void watchdog_domain_destroy(struct domain *d); > > +static always_inline bool is_initial_domain(const struct domain *d) > +{ > + static int init_domain_id = 0; This may then also help with the question on why you use a static variable here. (In any event the type of this variable wants to be correct; plain int isn't appropriate ... > + return d->domain_id == init_domain_id; ... for this comparison.) Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:51:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:51:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574768.900351 (Exim 4.92) (envelope-from ) id 1qR6eA-0002g9-5a; Wed, 02 Aug 2023 07:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574768.900351; Wed, 02 Aug 2023 07:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6eA-0002g2-2s; Wed, 02 Aug 2023 07:51:54 +0000 Received: by outflank-mailman (input) for mailman id 574768; Wed, 02 Aug 2023 07:51:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6e8-0002fw-MY for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:51:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7e1a::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7032f187-3109-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 09:51:50 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB10029.eurprd04.prod.outlook.com (2603:10a6:102:380::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 07:51:48 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 07:51:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7032f187-3109-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3+wVmf6SfmAmmR3fI0jrPiCZbuj0jdtvIkTNMMDjm8mUE52/8wQIeJhTk5bLuqXa1SSEkStE7K7mo+7G5KfHQWCLEETQAUCuYiUXWXtyym9iXqx/acGJAEOmmtDElXIpld9KjK/ue33vUyo00Hmk9WMcXTPxjRKLzrrouMNvI1P4NbLdu3GdxsE1QRoSICUYZygXcU3PzmX7JPfSVV+I4siTMIWiDgx0VjcEK94Mfwv+liJ7fFkIk7zRdFka+wW+Y2xVVmUemGJf6poFZKKFuxM23PGfS2AJxl/XBx9w+PCZpiSKwXc2NXS844nFws1o9r0aSzaMpHtUiUJmXFUbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bo1KwlTLRh23X2gWkgL4nTGICIXqpMUpvj9JprEOskg=; b=XXh2kJGWpegQPtfnVVoY2kLgzwHhAIxDc4iBOIZhT1KWzDhoxZXQEwHmRC8Ws4feVCBhH42dFxiZ+35ATPUZnXGYLEeemxcYpdunq0kghEdCKg+/d8+bKOcEqHm75oux+JpPu8RGKj0IojCUTzsDzvVZLEqr89nME2Q1DE2D5fMp/yYaR008FsHiPJ0wSmLryikNmRV9/SX9b20buasWi0suJxc8Y1IEop11LwDU14qOKtmeFasgGbsIryguKRrP0tZO/UomsbEktPg56KzjSGIqpbkfBIgvs2LWeCgMZnycHuoidhMRQjAV9YUIbASliUVMvZHU86oFQch6wLHFcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bo1KwlTLRh23X2gWkgL4nTGICIXqpMUpvj9JprEOskg=; b=DsPKxtXP9SfXndTz0V3FUxdcUgLDByBix9Jmy2mnKn6qLgymKc1yrimKzl317jJ0SbumJafddDS85zFLAWoBBN5eNCVg2FIUoQDunmauxn62WlH4XHJmW0QrNAht3KnvtOjCRiKSDLJCnxGGF+3BLjwzEH66Rah+gNbMg7OBsJ3V0CALVPG7cDnnj48ftrocL6l95LcWZ+xSR3/E8b/r2K/CVw2eUpXQkcCPqgQTvCeVSkQkb71GqjICXgfRkBHHNa153YpHeVPg2t3+5DQLne3mwvmEaf5+JYqVnLEiGxO1uyCk9gL1emUTpp06VPOxJGOCzbmu6zikW68RMGkRQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 09:51:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: "Daniel P. Smith" Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801202006.20322-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0161.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB10029:EE_ X-MS-Office365-Filtering-Correlation-Id: 14f52f26-0b0c-44bb-ff63-08db932d534a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i2nh6mNS7nec8lc3Z7ZabGa9gdasLIt/BJFj/FOUJ4m8zKLzW9NQmJy3cms/b4+9nbARceEw2MPIlwgPtgsmA1YlfWPDTMYMIlLVKFOY3H3+aJgTr+hnEZUfT+eDJMrN6TBUN3jLQkPHsvSFx8RhkN9zQrRcp+qN09WesrgNGEZcr/+WXDbyIlyFsBxIZILr/n0t5RrfclBAco6kEbQDEYhTBzu+Gqcd0yqueL6m7FSUUo6egE8aS9PHR9ere6i1qq+uf4AA8mVqKK3oc5/2/SxwlkytPGhUwRVPtePRHEXC5nF8x9w8+fdS9EYvb1+wPi+FWd9hHqSUDNsJmAufriMaZknR2dZ00J+ksnvwTLadCQkqG45bh9vOm2kYFT3u5yJ2LwZXB6iOD7fnXbNXGSft5Rd7nw4BgBKyt++sXw4LNkxgaCPsa5ljoX6QKojrOC6/KCWM7tSu0NTl8VdcDttiPCGKB3NTiHzZn1bt9E5DGCUisteyPeDd1kTdc102aEyNOrEx/5ePebCj4kCKirhKHEuwvpcoHY79TyJ1Q5oryFRFshlqQf7EeKhZgvjbi4cZx85KhY6GArIiNNNaXed0V1uFpuD6Txu/VKIljdHKLnapLtU9szyPTYzx0vp94TEbuawVUIPxdUioEpcBXw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199021)(66946007)(86362001)(31696002)(6916009)(66476007)(66556008)(6486002)(6512007)(2906002)(31686004)(4326008)(54906003)(36756003)(478600001)(83380400001)(41300700001)(38100700002)(2616005)(7416002)(5660300002)(8676002)(8936002)(26005)(53546011)(6506007)(316002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1BsbTY4NXdUOFlKZWd3RUFReDAzc0tsNGtPRDlMNkx1UTBsR3F6WXNZN0Nj?= =?utf-8?B?b1UwRUxXT1ovN3JLQmpFMUgwb3dsQzhHSGFiNjlGNllEbFdJeVptZFNoODNa?= =?utf-8?B?ZWdESkNrVVZvMUQxd1ErdERWaHl6WWFpczZUdkhYZTl0OW5yWEk5ZGJuRzI0?= =?utf-8?B?Q09PR1Y0ZDNacGM3MVQ0OXFSMFpmWnNqTDMyUlRTbWovUitqZnpRZVUwUUNi?= =?utf-8?B?ZjN3Z3pHOExBTE9IUXdyUkJRMlluQnBod2RLYVhsSXducVVNQ24xK09ENGpR?= =?utf-8?B?L3BudUpKc3R1SEdHb3lCOUlOdUd1UDkyaERXbVF2RHJFSEY4cEN0RUttaEFw?= =?utf-8?B?Mis3cmlRNEVheml0M3F6Q0hpRDE5cWNPVW1kSHJLcEw5QmU0ZTdLdHIxblZG?= =?utf-8?B?ODEwK1Y4RFRXck13TlhpN0dJbGJyaUtGSk1tWU9HRTBqazNkbXdJVXNTdWJM?= =?utf-8?B?SFlaUjl2bGJ2R1EvbFRxWjQvUHExTWtCUnIvajZ5azdQZDQ1QXpub1pZdUF6?= =?utf-8?B?bmY0L09vMitWbm1vczh2V2ViZC9NZ3Nlc0k1Q3lMUGlxaTFqTU9yNk9UWU5H?= =?utf-8?B?ZC90ZkNYWjFBWXdWY3RSSzhZQ091aExuaTNnZDR3b1pWQ2F3L0lkVm9GNDV3?= =?utf-8?B?K2QvSHVYSDdsT2E4ZHlRS0dBVW41WVFQa0d6MmJ1b2c1aWpIRnl5NHRzVElq?= =?utf-8?B?am1HY1FXbVhtNG8wQWNRSnZ2ZWFFRHIwOGRQYTUydmRER2RocXQ3VVlFOHZY?= =?utf-8?B?ejZXbWU5ZDhmbno3RytZQXY4OE9BamZXWXUxZDRuYi9hUEQ5NHgxd3NpL3Nx?= =?utf-8?B?WmdiQ2c4RFZYQmJZMVVaTjNOTGNKQmFCWThZUmVxeVBYV01ieXZZa05RZlU2?= =?utf-8?B?UXJsOWgwSVRFbGdEYjV4SFRKclVrTDI0Q3dlODEyd2FrdXpzcjVXUFFQT2gr?= =?utf-8?B?MloyN2JyclR1YkJOeWhKdFNrMzYvV1I3enc1QjNKTVl4UTI3M01vZ3NZT3lW?= =?utf-8?B?b3R3MzhZVm9zZ1NLTDZ2Slc1WTBJVWhsb3F0L0kvK282MjRHbDZndWVta0pM?= =?utf-8?B?bEdKMzNxWUxTTGdyRkNNZEN5c1pEUGxIV1VKTWxKTkpyeExsSEUyTzk1eDJT?= =?utf-8?B?OW9aZnN1aUJnYUp4YUpqeUNrTTAxTEVOTjQwckxvbk94ZTJpU1RpbnhHWDhI?= =?utf-8?B?LzM0TWtMTFBTNEFySlZ0UUdrY0RlVzk1SXF6ZDg1TnQrelNzcUgwSVR0dzhs?= =?utf-8?B?M2YrTTRHamE0eURLQzROMVAvM0FLaXNHdThVcjBUUndlYXVQNjNOREhYM0s1?= =?utf-8?B?aTZKT29ISzFKaGFkOWpoMnBvc1lIa05LVCtLcXRKTmU4QUJzZmJrUnZPMUw0?= =?utf-8?B?SnlGQnBCc2RCam5uT3diMi9PYTQ5cXFydTJrUkRWWTBUYkl4aUZaL0FLamxw?= =?utf-8?B?VFFFa3loWWY4eEFLMU1td0xISE9KL0h1bnBXVmxDbmtVbE41aDVGbzl1dWZs?= =?utf-8?B?UFBoS0MxNi9mTTdxNEJiRllCUEEydThRbERjWmxmSlpLdGlZdTZoZ01hUFlI?= =?utf-8?B?OUdmejlZRnU5Ym9KZ0RDY1A2LzlTNTBGcGovcXlGay9HWlJXSkswNnN5NG54?= =?utf-8?B?TjVWMlQzOHZOS2JTL2VVR0UxK3lSZGtSYWtvVXJOYXdVY0RmYWJiZjd4djN5?= =?utf-8?B?eUpCR2kzODVUUzJVTzAxWmpYYmxMdEpqVmkwZmMwSE1LeUdBVWU0OU5zNGE2?= =?utf-8?B?SHlBcGRsV2M2b01JbEg5U0IyY0NRbThuRkNRUkxVZXExS0hVNmd3NEFGSXRH?= =?utf-8?B?Rk5reDY2aHFkNmZINUVZejBDZ0FwYVpPbFJVbjdBMkZvcWhJalcxUEVQL3dr?= =?utf-8?B?b2NRYnlySzgxRVhNenNRdHlZdXRxem9vOGhIYU9COHlRVGN0ekVCMGJJdExn?= =?utf-8?B?OTlwekFibUJreXFlSUZ1UGExa1VzQ1EyeGlZUkUvUmVQMkl2Sjdzb3Q3TXhK?= =?utf-8?B?U1puS1NrRm1CdzNOb3poT2JqNGg0Sit5c1hFMHQwN0o2SmdvWVAzNXl4dXp5?= =?utf-8?B?TVpjK2c1Z1NualJwbXVPR2MrL2g0VVM2ajEveWI2TEw1bWM5TVh0Y2I5NGsx?= =?utf-8?Q?7nlrM6FjPUnHOnYYtM6dJQhaK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14f52f26-0b0c-44bb-ff63-08db932d534a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 07:51:48.4784 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xNayUwo8wcUANXhdVOuQAe6sTsAePiTOyEl3jZHeA7nXCBefBdtI+qr5OwlQ8YceICrSk9U9VkJGU6DSvEm5Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10029 On 01.08.2023 22:20, Daniel P. Smith wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) > setup_io_bitmap(dom0); > #endif > > + /* > + * "dom0" may have been created under the unbounded role, demote it from > + * that role, reducing it to the control domain role and any other roles it > + * may have been given. > + */ > + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); This doesn't look to remove anything, when taking into account ... > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -467,8 +467,10 @@ struct domain > #endif > /* is node-affinity automatically computed? */ > bool auto_node_affinity; > - /* Is this guest fully privileged (aka dom0)? */ > - bool is_privileged; > +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) > +#define ROLE_CONTROL_DOMAIN (1U<<1) > +#define ROLE_HARDWARE_DOMAIN (1U<<2) ... that each of the constants has just a single bit set. Seeing the & there I was expecting something like #define ROLE_UNBOUNDED_DOMAIN (ROLE_CONTROL_DOMAIN | ROLE_HARDWARE_DOMAIN) instead. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 07:54:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 07:54:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574771.900361 (Exim 4.92) (envelope-from ) id 1qR6gh-0003FB-Ia; Wed, 02 Aug 2023 07:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574771.900361; Wed, 02 Aug 2023 07:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6gh-0003F4-G0; Wed, 02 Aug 2023 07:54:31 +0000 Received: by outflank-mailman (input) for mailman id 574771; Wed, 02 Aug 2023 07:54:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6gg-0003Ey-LJ for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 07:54:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6gf-00034e-S3; Wed, 02 Aug 2023 07:54:29 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qR6gf-0002Ky-Kj; Wed, 02 Aug 2023 07:54:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=2hy0VfCSnJmQ7IYq0zC9qMqOGe29w9Pn0XRR3XHSWUA=; b=iZNl3KSQbZrkL2U0A9Vj0DmuOZ TaAaVq7o3gtvljHedcl78LQ9hYyCC+8r9amzDDtKssCV2kPwo8nBy0H/z2Ro+viS5e75vIQ8MXbtO eRM1OlYmapd3k0ZWM6H/zkYoQ41QOBLUnb9UPgLeOq10yjAezdHnr3uFqVwqGCY+kdJQ=; Message-ID: Date: Wed, 2 Aug 2023 08:54:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Jan Beulich , Khem Raj , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel References: <20230801174930.2995947-1-raj.khem@gmail.com> <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> From: Julien Grall Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 02/08/2023 08:22, Jan Beulich wrote: > On 01.08.2023 23:02, Julien Grall wrote: >> Hi, >> >> Title: This patch is not arm32 specific anymore. So I would replace >> 'arm32' with 'arm'. This can be done on commit. >> >> On 01/08/2023 18:49, Khem Raj wrote: >>> Assembler from binutils 2.41 rejects [1] this syntax >>> >>> .section "name"[, flags...] >>> >>> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] >>> >>> It is almost like a regression compared to 2.40 or older release, >> >> The next word after ',' start with an uppercase. Did you intend to use >> '.' rather than ','? >> >> That said, the documentation has the following: >> >> For SPARC ELF targets, the assembler supports another type of .section >> directive for compatibility with the Solaris assembler:" > > But note that "SPARC" was added there only by the commit introducing the > perceived regression. Yes, I noticed it while replying yesterday. I still would not describe it as a regression mainly because I am not convinced binutils will revert the change and it feels like a good move. Also, regarding your point about older tree on the bug report. I don't think we guarantee that stable works all new toolchain without any change. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 08:02:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 08:02:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574781.900371 (Exim 4.92) (envelope-from ) id 1qR6nv-0005It-NI; Wed, 02 Aug 2023 08:01:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574781.900371; Wed, 02 Aug 2023 08:01:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6nv-0005Im-Kg; Wed, 02 Aug 2023 08:01:59 +0000 Received: by outflank-mailman (input) for mailman id 574781; Wed, 02 Aug 2023 08:01:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR6nu-0005Ig-7C for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 08:01:58 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060a.outbound.protection.outlook.com [2a01:111:f400:fe1a::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d999d7ec-310a-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 10:01:57 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9332.eurprd04.prod.outlook.com (2603:10a6:10:36c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 08:01:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 08:01:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d999d7ec-310a-11ee-b25e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IIWV1IrFXSzknm2xKbIrS0v+CXZnYv5Mwa5bQK1VCf3nCvKW66OPvwhxrpw5zxFRF4sY3z8QYfE+EsRWqsXre7ZKfFJ/8aZ5XHgT1gTl7Db42cZmnm+2X40n4QwLTI4bXmPrll1KnLkyvJE6g0YLRCpl8VVqH9lfqNSbx3kLJcyI2RsOD4d2TDn/BcaLG3C2SgjZnJgTIxBp+hdZkxcls5cHVOKhmdvf05zVaoa27y+UIxdmqYQhOGwXxWZuUAG4Yqbp7K/WxqciFdWvBUXYPvup1GVu/VvhGkg5IAiOQYlzy1nvfeKppbX8Bv4CAMltmkQ7ivCD6J9jtkm5HMO8bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DetXZRLRb8zggcsk1BEVOLIqZPtJHYj5cs+EhHzAgkc=; b=a2jZzlb22lLM90zTiR6A5Cdgl+AKXvS4wiDsWNeYxeK++QaIMLem/nZTRWhtAxBYC56/hxmQNIVXzf+T6TtRffpgO4obhvcyABLUic/d2hzfmceBEB0L5m2fo0fBegzLUtBCxBZCMO+h/DD9RxDS0P5TbzEIyz+kXXhlFuTmqe9y0DtBJ9WKIl6GoYWJRg++qkx5z6Hvush7DxYCvaZlcmhP4u+Yj2hw6QpGCth6k7h90JqhPV/SWiVilO9+aaEwxSgoHn1JJ57JYO/LNWi+Vi/kjP9pg4dcsYzkX7umxgW2aZ5kAmMkK4UlSSQ9JoLJASIW72WQpuiN+WhlUY5q3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DetXZRLRb8zggcsk1BEVOLIqZPtJHYj5cs+EhHzAgkc=; b=R/i3Pl9IZPzxUpZYXcQsU6NZJLVPo16h+QOc3h7cqJXCQa9/0EzuHq9xwpQrV4SxQ2LtZIW3FuuKycDXnQarPykSHlRqjiJEQzSdNf6W+4WwOlJT0NxxX1znuGCR2o7WHIVuMTAKVvFunPd8SYlHUmZkFkSKejGBbqy0+wDgf3+BueceJ05TJE6DpjI8dmNKQIyqdW8IDk/+JL3Xzqkyoo3ceMC032E9JYK9n93bGDDgGo8ghDOMmo2Mg+8gTCSajayfQNYKeCh+PFAKe7lsJBufnEC8DKzUPjqbayPPsn76lKl2kWiwzmipfzIIDkrZilY5PM39qK+7Kz6IjBLyzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 10:01:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive Content-Language: en-US To: Julien Grall Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel , Khem Raj , xen-devel@lists.xenproject.org References: <20230801174930.2995947-1-raj.khem@gmail.com> <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0261.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9332:EE_ X-MS-Office365-Filtering-Correlation-Id: bc917bb7-6a32-4a6c-bcf0-08db932ebbda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xyniPKc/BRizI6ps8tT8s/2zketR0Q4j7bOwMZGR1n4FHWkYAna0jfGVynyU9oysWBuYnPH62vbrcYkcqCRDzcpYVTFzxpvw1RUFy+SWhAyazW0OQaPLu2CNVrrciNMQ/LClTay1sEralbKkzsn5ogSD0X+Y9zwxrmwaFNSnvFlx7UrFKs32eatH2FpnHNtTVwaooa8bk/aKkQ49tzpn1lbC9LS9ZAQX0gEGyj8vY8CBS23T/wf5Q+OJdfp2bEIVCg0mLjUtiqDJMmAtPOjgXmQgcQX8rbOsVc0gvtOacwJp5DVRG2vips24veBf2h8uW9HbpdAJZEsZz3YEgwwr4PxmxoKC42IKp4enirGbAuzYnAh/FyT7bTM7j8F+r5x1VgJMj2rDIi0qkc8XxyI7Ka2nGWiZG77FMTpAnALxcuwfOCjeArgW2amyenh0LdN0RsYHCdpSw25GEeVbGh6Q9z2IKRkL7hRs9XJBlerpPAS/vhMQLkCseq/zXuAmiq+Kb3jeBXW2FHPltiQiRYpsuLA38ycVKystzpNNWx3DNgZDCORLhNujMYax0fwRSJV5jxeNgIw0wqn0/eQ3z1DihckWzOYJ5TmT4iZX1uDzVn3v7jYconCfbayq5OvTtfqRlW7Ag1NPuPv+DHKJATeb11rl9Tg9wqt9Vhoh/cPdF9OF/tZW8paeo3Ld4z5xIofn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(396003)(346002)(451199021)(2616005)(186003)(6512007)(316002)(86362001)(478600001)(54906003)(38100700002)(66946007)(66556008)(66476007)(6486002)(6916009)(4326008)(31696002)(6506007)(53546011)(36756003)(41300700001)(26005)(8676002)(5660300002)(8936002)(2906002)(83380400001)(31686004)(142923001)(60764002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXk4a0tDR3JteW0zNjFxK3dpamFMNjVOMXhJeWpGcTBYNEoxVVN0S2xDSCs4?= =?utf-8?B?U29MeTZCaUppaTFHajdrdGFEUkFQVDluenh1NGhmR3JlNzdkYy9VQVl2bHpp?= =?utf-8?B?RUZUZThKeVMzU1ZPOFU1NzZjK1ZmY1d2L2NNQm4rZkRUSnB1cVYyeFNWTWo4?= =?utf-8?B?T2MxUUQydUtIUXl2RnBSQS9KVldTUEQ3OFduUnpnejVVRlBxWGhNMlBUMGt0?= =?utf-8?B?bUxqWEZ3UDlXZ2lveVhvWHdjNVZnaU1MNGFVdnM5cDVtR01YNDBhWlhKQ3Jz?= =?utf-8?B?TzduSlhZSURUbnFnVHJzbkFjTkVpbXYxQlAyc3ZjaXBrSDBVVjhJQkVON3Fp?= =?utf-8?B?SUloZFRBdUx3S3JDem5BNE9GV21LTjU3VEJhSHBJMzBwSkRXSjlCWlRVbEdz?= =?utf-8?B?eDE1MTdaNHh4Sy9nR1V6T2JIdkdJWjdodzhQdTVXY1orc1pmbXNOc2VFTjhQ?= =?utf-8?B?cC9zakFpQTIyMDZQa1Q1c1pCb2Q2TnpsMVMrSXRIbkVPQ2xqRmwrTzlSaldZ?= =?utf-8?B?V2NHV0NFWFQrYjRiT2hHdFhBK3pQVkpHUXNQS0x1a0FzSFRtNnl5bS9COTF1?= =?utf-8?B?Qko4TlpGdEFtL1R1S0laYUk1NzJ3dHJGeUhRc2dCSTlIZ094aXVLalU2UFRT?= =?utf-8?B?eHRxajU5WFhudWNEalExOGppYXR4cnNhWkVuMnByNDJRYk56SlVhTnB3S3Zs?= =?utf-8?B?OUtoc3FMdmlQVnR5T2dnVGtsSWJyRDFOM1RkREV1TGpRLzV0VTFxSzc5U09H?= =?utf-8?B?K1N1R2l5dUtMMzhvZmlua0tydnJrV0dJL2dOUG5qd0VVMFA3blJMS3N6NTZt?= =?utf-8?B?cncxeUEzbmFOVTR0SENqS3ZSMTUraXdxR1NYeUpXRFp6MURVN1hTZzBQR3ZI?= =?utf-8?B?cFRGQTkrYXRkNXNteG16eDNTVlQ5ODladXg5em5sdVR6NTZoRCt1Vlg0K25j?= =?utf-8?B?UUhkb1dmNVJqN3Z5Wmc3NGxSMFludTgyc1g3ZnMwTnRLT3g0REZHSC92Y2F4?= =?utf-8?B?NmtoTUlFWFhoeXZkV3dNS2dNSDU5bzVpQ3pTaHhQaWFWTU02SWFyQkh3cXMw?= =?utf-8?B?ZGZVLy9KdWVEMVV5Yk1sL2kyZndnd2QvaCt2VS9CRXhpWHo3OEJZVytpUkNF?= =?utf-8?B?WlVZRXdRNHpkeHM0TW5tUmRtejViRFhBS1hWd0FDd3kzSE5YWDhaTk1XN3BP?= =?utf-8?B?OTd6a29kTTlSM01lYVd3aFpIVW4xNUl2QzRUcnovUEVzZkJOdlQxL21DWm1n?= =?utf-8?B?OW1kR2pjazBpdXY4bmhnbGV3VWZIV3Q2WWdVRFlpRzJYb1htajBqdnFpSHBp?= =?utf-8?B?Uk5EM3RhZ3JkWk44RkxkSWNnOHJpTkE5cjRrWUR0RkdUbGc1eGtpTHNyRlFo?= =?utf-8?B?RmprY3VzNUdlOHR4UEdwa3JDK3dQd3lDVWN4MFJQYjYrNEdsWHkwakcxWjhJ?= =?utf-8?B?LzdEVUVBeHRhUXk5Yjh4cEtTQnVLL3lSVmNrRGVFNmlXSDhxVHAxLzlDUUJO?= =?utf-8?B?ZTB0Y202WnRNUmZrZ0wxb2FqNmZnd1krdmNCek11bHpnOGtzZHRpZldWd3M3?= =?utf-8?B?VXk4L0plc0ozSEZXcFo2SC9NcTZTRHhiT21Cc3lXOVBod2hhYWN4Q1NBeGty?= =?utf-8?B?NTVweWduNDhtZHVjMXN1ajMrOC9DWmI3V1NFbWJsVlg1aE1wTjlETUd1SXVx?= =?utf-8?B?bUlhcncveFFnK252ZjFObWNCQ2hlQUEwZElrd2FEbEtveGZzSGE5SDV5TG5O?= =?utf-8?B?dlJMcWxDTlQ2RktYY2diZ3JUVjQ0d0x1ZTNMY3JNdW1sVjZaaE9KNTVwQ3JH?= =?utf-8?B?cHVwQTlLNDFwblFSNjVyT3lqejZhczBSN3ljQlNFbndwaGpreFR1RjFOMDRK?= =?utf-8?B?TnRaL2FDYzg0S09PVUd5ZVNkcGp3OEoxZFcvc2krd3lyeWVjRlhSMlNQQjds?= =?utf-8?B?VEJvRTFxUm1rRDVwbWRLc1ZUNTNQbWxxeXBmOGxRTmxpaUU0V3B6aWFnQU9q?= =?utf-8?B?ZDFzUlNGSTZUVlFieUNrdXludC9KVnBEM1NuaWM4TTlGZzRQbVZDUWQ4cnJm?= =?utf-8?B?TVhJMFRoNmJBakIwREZZS2h1K2JQejBtblZzQnVNUkFBRVVYZUY5VGlJVkdp?= =?utf-8?Q?LhT1mUFNkbcopONJhfKH5c3CP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc917bb7-6a32-4a6c-bcf0-08db932ebbda X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 08:01:53.3641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u7F+YbT0aHmOmzoEV8kMpCDFyZaTasdqMx5wq0EjPliqy9vtTNjk4fTr/NHuynmLq5WFVlPZFf55Q6o53eYf9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9332 On 02.08.2023 09:54, Julien Grall wrote: > On 02/08/2023 08:22, Jan Beulich wrote: >> On 01.08.2023 23:02, Julien Grall wrote: >>> Title: This patch is not arm32 specific anymore. So I would replace >>> 'arm32' with 'arm'. This can be done on commit. >>> >>> On 01/08/2023 18:49, Khem Raj wrote: >>>> Assembler from binutils 2.41 rejects [1] this syntax >>>> >>>> .section "name"[, flags...] >>>> >>>> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] >>>> >>>> It is almost like a regression compared to 2.40 or older release, >>> >>> The next word after ',' start with an uppercase. Did you intend to use >>> '.' rather than ','? >>> >>> That said, the documentation has the following: >>> >>> For SPARC ELF targets, the assembler supports another type of .section >>> directive for compatibility with the Solaris assembler:" >> >> But note that "SPARC" was added there only by the commit introducing the >> perceived regression. > > Yes, I noticed it while replying yesterday. I still would not describe > it as a regression mainly because I am not convinced binutils will > revert the change and it feels like a good move. I agree as to it being unlikely that the change is going to be (partly) reverted, unless someone strongly advocated for it. It also wouldn't be of much use to us, unless a 2.41.1 was cut very soon. > Also, regarding your point about older tree on the bug report. I don't > think we guarantee that stable works all new toolchain without any change. We don't guarantee that, no, but I think it is in our own interest to keep things building with the newest tool chains. When build-testing stable tree commits before pushing, I don't want to always have to remember to force the build to use an older tool chain, when normally my build rune would default to a pretty up-to-date one. This is also why for this specific class of changes I typically prefer to see them also go onto the security-only stable trees. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 08:19:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 08:19:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574794.900382 (Exim 4.92) (envelope-from ) id 1qR74N-0006uu-5q; Wed, 02 Aug 2023 08:18:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574794.900382; Wed, 02 Aug 2023 08:18:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR74N-0006un-1U; Wed, 02 Aug 2023 08:18:59 +0000 Received: by outflank-mailman (input) for mailman id 574794; Wed, 02 Aug 2023 08:18:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR74M-0006ud-5B; Wed, 02 Aug 2023 08:18:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR74M-00044T-1q; Wed, 02 Aug 2023 08:18:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR74L-0004OC-Kx; Wed, 02 Aug 2023 08:18:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qR74L-00069l-KW; Wed, 02 Aug 2023 08:18:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/8xT2lzrodVcsoi1AbXIqYwzOx7fU+RQ2aEc9BFhBxk=; b=Wkq4C+wr/mpdZ0qsF2KTokG3DC Z7gkYQWuCPise8HKDU/tttjpzMJk3fCITe5pTbQNhIUd1aVcI7lIetLyFaiAsZWYm4ZhY40mLoUvA kbk4ZzECx4FfNHXjNdpWlTxM2NvpmwMdzRoObQJyPdSXN6Wj39AoVb3x1bJS5x9wOZ+8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182108: all pass - PUSHED X-Osstest-Versions-This: ovmf=d11968fcc56cbbffef7d906048b00faea9415447 X-Osstest-Versions-That: ovmf=677f2c6f1509da21258e02957b869b71b008fc61 From: osstest service owner Date: Wed, 02 Aug 2023 08:18:57 +0000 flight 182108 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182108/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d11968fcc56cbbffef7d906048b00faea9415447 baseline version: ovmf 677f2c6f1509da21258e02957b869b71b008fc61 Last test of basis 182090 2023-07-31 12:44:11 Z 1 days Testing same since 182108 2023-08-02 03:40:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ranbir Singh Ranbir Singh jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 677f2c6f15..d11968fcc5 d11968fcc56cbbffef7d906048b00faea9415447 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Aug 02 08:58:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 08:58:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574808.900392 (Exim 4.92) (envelope-from ) id 1qR7gU-0002xe-6C; Wed, 02 Aug 2023 08:58:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574808.900392; Wed, 02 Aug 2023 08:58:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR7gU-0002xX-3Z; Wed, 02 Aug 2023 08:58:22 +0000 Received: by outflank-mailman (input) for mailman id 574808; Wed, 02 Aug 2023 08:58:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR7gT-0002xR-Hr for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 08:58:21 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba0df38c-3112-11ee-b25e-6b7b168915f2; Wed, 02 Aug 2023 10:58:19 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id A030B4EE0737; Wed, 2 Aug 2023 10:58:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba0df38c-3112-11ee-b25e-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH v2] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 Date: Wed, 2 Aug 2023 10:57:59 +0200 Message-Id: <30fdada8b08b2060c6f1ccc2ecb06d418efd97b0.1690966632.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the struct declaration to have no named members, hence violating Rule 1.3: "There shall be no occurrence of undefined or critical unspecified behaviour" because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: "If the struct-declaration-list contains no named members, the behavior is undefined." Given that Xen is using an undocumented GCC extension that specifies the behaviour upon defining a struct with no named member, this construct is well-defined and thus it is marked as safe. No functional changes. Signed-off-by: Nicola Vetrini --- Changes in v2: - Added a comment mentioning the use of a GCC extension. Note for v1: As agreed during the MISRA C group meetings, this violation is dealt with by means of a comment deviation, as future changes may eliminate the root cause, which is the empty feature set. My justification for the claim and the commit message may need some adjusting. Note for v2: Note that GCC does not document the particular usage of non-empty structs with no named members, but it works as expected nonetheless. --- docs/misra/safe.json | 9 +++++++++ xen/include/xen/lib/x86/cpu-policy.h | 1 + 2 files changed, 10 insertions(+) diff --git a/docs/misra/safe.json b/docs/misra/safe.json index e3c8a1d8eb..ec2bd58777 100644 --- a/docs/misra/safe.json +++ b/docs/misra/safe.json @@ -12,6 +12,15 @@ }, { "id": "SAF-1-safe", + "analyser": { + "eclair": "MC3R1.R1.3", + "text": "The following declaration of a struct with no named members is deliberate and the use of an undocumented GCC extension ensures that the behaviour is fully defined for that compiler." + }, + "name": "Sentinel", + "text": "Next ID to be used" + }, + { + "id": "SAF-2-safe", "analyser": {}, "name": "Sentinel", "text": "Next ID to be used" diff --git a/xen/include/xen/lib/x86/cpu-policy.h b/xen/include/xen/lib/x86/cpu-policy.h index bab3eecda6..6b52f080c9 100644 --- a/xen/include/xen/lib/x86/cpu-policy.h +++ b/xen/include/xen/lib/x86/cpu-policy.h @@ -203,6 +203,7 @@ struct cpu_policy }; union { uint32_t _7c1; + /* SAF-1-safe */ struct { DECL_BITFIELD(7c1); }; }; union { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:43:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:43:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574817.900402 (Exim 4.92) (envelope-from ) id 1qR8OG-0008FO-H3; Wed, 02 Aug 2023 09:43:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574817.900402; Wed, 02 Aug 2023 09:43:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8OG-0008FH-Dl; Wed, 02 Aug 2023 09:43:36 +0000 Received: by outflank-mailman (input) for mailman id 574817; Wed, 02 Aug 2023 09:43:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8OE-0008F7-Mm for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:43:34 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061a.outbound.protection.outlook.com [2a01:111:f400:fe0c::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 095db98b-3119-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 11:43:31 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8960.eurprd04.prod.outlook.com (2603:10a6:102:20f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 09:43:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 09:43:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 095db98b-3119-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kW/1+cr+StnCQmI79Z9amuALg8WIaLckvPDrgw5Sazr1eD/0QJzgkXX7Ccl11ZMS2SfZfkO/IYASKGB2w0cGQxX1L/S1fWhVr+eJY0S1l2yNpyFBxY4G4gvZk8a3tozdMMCADDw4b+QkZ3qSm2K/L7Wz4S77FkVwXOXC99WONXEkxIEmOooi1WPmZ/3IW6Uod7xa/nnP3WZ2DaCsKShY97a8qV2QtNZkJx/xfASBfDexh7zth3h4Hs4DiJUH8mvl0AnVBeMPw2OjHN5nM8UfNEuovUIaI/BKIlvHBhucG8uuL5hzp3vpzg6OnHra56LSL6ZU7a7LpEWzcaBQBA6RFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xmAn4ea9Ft5uLOmWRqAcascwlZgYJ3Ef4JqGmYRj/ls=; b=CrBsktgy4/bSypTGE8TCqftG1qwthlux49uOqR/ldqHKREWfpjVKkoy4cwKaAvhHx4i2RAU36FOA260gvT2GVQZK91XVkOdswfEpjjzPBIa0VZKf8QcRAUfCcOfgoMczAvhDqECmG5/dM+L5Oa9LZr1nIslQD20RtmsK1BitZj1AN1mmCaurcl53+q+TGUv7OY5AwqFv8tpv1wcxdzpiERXKsbcXMHNbdJPKwBwOXp6vOt6ez+QSV6GDUuMJdiSJIZTqu7j72c/BwUUUuW1OP+N32D4jbSKNkXAyG1zTZIE49IR+K48/KzZQIyBVOXXvY8hDNbySMjze6z4nWeU16A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xmAn4ea9Ft5uLOmWRqAcascwlZgYJ3Ef4JqGmYRj/ls=; b=47AINLJg5MSJmgKS4NoNG2+L8GrlT80UgTpOL4XDHMBFJZd+c32gXKT6TeS7VVPhO3SgP7+0GK6vHyUmkaEszadxPIptQCYLuyve7p1KJ+Vhi7Z9lDxc4pmHPgS/Ji4B05CHyljstIoXZjy8cfuw6j0tavBwu1Ug4DDaxFk5hHPH85Y/YMLTksHlm87YYEQbpGmt/Ru0kNsg6XssviSBTIlMRBzWUIdZl62mZ3IqTjjtShOrW8+ixmoGuRx31MGGSxTs//bCIBwISU0uSOeb8K6gUbk3dbhdgJl8YQ3XcxF/0gig374GMJaK3mbNGMDUDTKBYicc0kIDuuSICPlmqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 11:43:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Nicola Vetrini From: Jan Beulich Subject: [PATCH] x86/gen-cpuid: avoid violations of Misra rule 1.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8960:EE_ X-MS-Office365-Filtering-Correlation-Id: 2aa002f1-9978-48be-df23-08db933cec46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kyyTl4anwRVoN+WjSnoW+BlMYSrhPFGEuppZIVMLdqC6F2IR+PU0MznfUEwRrObnMCAK6I+3u/pYJpfhrtI43E1q1OttxJUVfXFivWHxdJmnMN3iz3ZzS2d3A+LuA7UlpVZsJFn/bqDTYNfPLkasYgUiou/NO6KTm/xI4uq+urSt3u8MGZYAP0hHKBShhU3Z0J/PsNhp9306bDZ5beECD97eQzoEWcDW8/1FpmBQ/fNQo9N53UqEiO44Xi8O2XASzs+JZyftETO/MfAXnTJWS746wS+KtyNBRNd4zIw5PaFOOOTZ/TRsZKhVkMVuTao0NjsAzQbydgC0TTHLPl665BncuksolXIfmVjtpEZTo5DU/anLhk5nBIabwHj0et4SUm/9uqnYhBkQGSHqPguq4fQaA5vqWTe+O/2gcb3L5tD9J0RDuvzNmKyM/oruNIaSM5foQ9/3CvjLZWnh+wNEwbRY+PMU6EulS20ax4G0V7Z60xVLYDNL22cO+vTXClc/GX6yYmiaAY/gxTuDVZfnJxNHqgUSeSYfMkn0i3BCcxHM+gmnH7why/Kma5p0xdVFAX0+EuOLlbzRVNp0I2EE2Qigp5G/+ZNceHFb3wj/9RTioxadV9B8gFXxtUeoyzRTAEG2IzCG6UwZP7I5Vg/tRw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199021)(186003)(8936002)(8676002)(26005)(41300700001)(31686004)(2906002)(5660300002)(2616005)(86362001)(478600001)(54906003)(316002)(38100700002)(6506007)(6486002)(66946007)(66476007)(66556008)(31696002)(6916009)(4326008)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFBCTkl6NTJTOFM3OElFWHExZUdINW1sWXZjNVpwRnFQUERhb2lZVFdndHl4?= =?utf-8?B?WVdmU29oQVRCNllYbFdINnVvYjRmM3ZtbkxDSzA0Z0NRSDBJNTNZT2sybmtE?= =?utf-8?B?N0dTWUlFR3JGZ3ozOU5mZjcycDh6V0Rwd3BCeWxiUWh5NVNDckppNEV1bitV?= =?utf-8?B?Mjl1ZlhHd3dGS2ZaSmRVVS8zeTd2aktVSXo3V2xCbDFMb2xKcmZodFFFNFJF?= =?utf-8?B?TFhzRTB5NXIzazIrYTdBWFhEV3Nqbjl3d1RscDMwQWxTOUVsUUxRbmtVVGMv?= =?utf-8?B?bi9iVmlBUHJQODVTTkNyd2lSa0o5SXVOVFlQWXE5YTZiM1dWbElFdDU1QXo4?= =?utf-8?B?eG1WaEkyTjlvZDNBV2ppTXBhTnpldDNpRmFoOE9YcWJxY214RnM5SEJDS1Nk?= =?utf-8?B?djBrbjF2L0NMTExzZGNwV0RaR0RSdVNXcnFRd3Q0QzBuUDVKV1FiUUoyVUxN?= =?utf-8?B?UGFzdU1sd0FXYVRWZWd5SC9NNFV6dWhxdXBORVlMeUtzYXJTV2JaUkN0MmdU?= =?utf-8?B?T0pBdTNqN08ra1JiNUV2cTF3Q0gxNGlFOTdEUWZ3RnYrRUxrTHRaQi9FMnpL?= =?utf-8?B?dkJ0OGM1eFpsMXc2TEtDdmd2ekhwRDF5cUI1c0pwRnBrWHZITUdNTnJiRlp1?= =?utf-8?B?MU9NbndqejlQcW83M2VWVmhReURHejZSUm51TW54UHdQYnVJdVVCbFpPSkJY?= =?utf-8?B?NUF5a1lwZ1dadUhDaHlMc2J0MURMNUVUT0lWM0YycWwrdXhtdXlMM0tNTEZi?= =?utf-8?B?ekZEbzYvRVQvQWQxN1FubG1CUjAwcGsyVVJsUGk5QlZrMnBlRHlyMnl6blhz?= =?utf-8?B?bXVDL1l6UzlnaXRCVVpEYlNnMXZvK1hNdU94L3VaZE5QQnFWY2V6VGtiZ2pP?= =?utf-8?B?VmNKSnZSQ1gwSit6SGs3M3czSWRhMCtBSWpuRXpCeml0L2VPVHZwdGFJYnFs?= =?utf-8?B?QThjWEU4bVpIdmUxTk9XcEFZcFk0WE9CaVVtZzZxSTJaM0hmNm9waTE0ZzJI?= =?utf-8?B?b2t0Z0g3SVdlZXhFMGJNaWdTWXI0RUhoQkRXb2hnUjhsQk9lTFd1aVZ4WXhz?= =?utf-8?B?Tk0wSEQ0cWtNZmg5WWI5NUhSbFVjcVBlMzJEWHhGYlVVS3RycHBzZDQzNC8w?= =?utf-8?B?YVUwVGVUL2F2b2xvSmtmWmZuazQzZXhwWXhvam5UK05RbHVoSmZJV0crcWsy?= =?utf-8?B?V1pZTWZTaTVRakhzQ0kySUI4YlEyZnBsM3BUalZhd0NFTmVxemZ6YmQ0WGJ5?= =?utf-8?B?WkliQlVTa3Z6T3BaZ0llOU1laU5ibVg4blNWRGlMVk5KUkNhZGU1YzFCbmNq?= =?utf-8?B?WkphcTVOdSs5MG5RaytKZW85WDl1UVRwMjI3dFhDSnV6dW8yZ21Kd0RFdTAw?= =?utf-8?B?RE1HeVpOTlJxTEVZNWpIdFJGeU44THNtandkZUh0T0hQaWtyTnpFOUtCWm1h?= =?utf-8?B?eHJ6SmthRWVIbGdqZUYzNEZ3ekw2NTRFSlRVdmJXZEJmRE44dHp2OU1WUGNU?= =?utf-8?B?MWg5bEpWVVVGRlo1RCtENmIzajhFSS9iU0RsRGUvMjRIVW9jOWIrQ3VBR244?= =?utf-8?B?UnJ4bk5xZ3E1VlpuLzFZRUo3ZTcwNEozeG5KaGJoOTZMSEhLQTg0Qm9rT2Mw?= =?utf-8?B?OVhBRS9vTnFmZDEzV0VtWkVVVExxRmJDbmxiZ2c4akhBMUFVTFlaQ2ZDekM3?= =?utf-8?B?L3hNUDJzRGVMTGlYcjFLTU1ldWp2Nmd3SVI5OGZZVUJpWUVPRDdnODFTbzV2?= =?utf-8?B?VHlxdGFGVmpZNDBVeG1SN1pGaUVqQit4WkRBdWRlRi8raERCNjZNWE96YUFS?= =?utf-8?B?Wm9zNTNudG04SkkrbGZyUlFpRUpFREUvZ3QzRm1vUHIwYytYM3NEZ1Z4ZThr?= =?utf-8?B?RVZHeW5kMFVmVlBpSnRDSmVNWTc0UkVaWStabldjYlJBWGJTZjZQOE9kV0tJ?= =?utf-8?B?L3RSdUZMTU1ERllIRWZKSDZjMGF0aFNuY2xPTEd6QVR5bzZtcWdSamlIL29G?= =?utf-8?B?VzVEZ21lUW8xdkxwT0lZSUdKaHFWRE1DeHEzOVIvamdCWDAyQ2VEb0QwL2VV?= =?utf-8?B?OTBaTmU4YnFCRW00TTVJM0J2bnJ3Rjdob0JEZmFJYnJHcjlCa0Zhb0RZZGVV?= =?utf-8?Q?yMICvfgpJ162KU94HeqevrJag?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aa002f1-9978-48be-df23-08db933cec46 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 09:43:27.5893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GQrTKhFo8drt6AymAjNymJfszicIf+gdGYjpBcmaLaR9zuUcQPRqdjw0T5q36w/7qdvbgax27eU6tMh4MSZIPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8960 Structures or unions without any named members aren't liked by Misra (nor the C standard). Avoid emitting such for leaves without any known bits. At this occasion also add the script to the X86 section in ./MAINTAINERS. Signed-off-by: Jan Beulich --- a/MAINTAINERS +++ b/MAINTAINERS @@ -601,6 +601,7 @@ F: xen/arch/x86/ F: xen/include/public/arch-x86/ F: xen/include/xen/lib/x86 F: xen/lib/x86 +F: xen/tools/gen-cpuid.py F: tools/firmware/hvmloader/ F: tools/firmware/rombios/ F: tools/firmware/vgabios/ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -367,6 +367,7 @@ def crunch_numbers(state): for word in range(state.nr_entries): names = [] + empty = 1 for bit in range(32): name = state.names.get(word * 32 + bit, "") @@ -380,9 +381,15 @@ def crunch_numbers(state): if name in ("APIC", "OSXSAVE", "OSPKE"): name = "" + if name: + empty = 0 + names.append(name.lower()) - state.bitfields.append("bool " + ":1, ".join(names) + ":1") + if empty: + state.bitfields.append("unsigned int empty_" + str(word) + ":32") + else: + state.bitfields.append("bool " + ":1, ".join(names) + ":1") def write_results(state): From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:45:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:45:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574819.900411 (Exim 4.92) (envelope-from ) id 1qR8Pd-0000M5-QJ; Wed, 02 Aug 2023 09:45:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574819.900411; Wed, 02 Aug 2023 09:45:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pd-0000Ly-NE; Wed, 02 Aug 2023 09:45:01 +0000 Received: by outflank-mailman (input) for mailman id 574819; Wed, 02 Aug 2023 09:44:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pb-0000LL-LD for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:44:59 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e698eaf-3119-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 11:44:58 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id CE9A64EE0740; Wed, 2 Aug 2023 11:44:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e698eaf-3119-11ee-b25f-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 1/4] x86/mce: address MISRA C:2012 Rule 5.3 Date: Wed, 2 Aug 2023 11:44:28 +0200 Message-Id: <52ec7caf08089e3aaaad2bcf709a7d387d55d58f.1690969271.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Suitable mechanical renames are made to avoid shadowing, thus addressing violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" Signed-off-by: Nicola Vetrini --- xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- xen/arch/x86/cpu/mcheck/barrier.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/barrier.c b/xen/arch/x86/cpu/mcheck/barrier.c index a7e5b19a44..51a1d37a76 100644 --- a/xen/arch/x86/cpu/mcheck/barrier.c +++ b/xen/arch/x86/cpu/mcheck/barrier.c @@ -16,11 +16,11 @@ void mce_barrier_dec(struct mce_softirq_barrier *bar) atomic_dec(&bar->val); } -void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait) { int gen; - if ( !wait ) + if ( !do_wait ) return; atomic_inc(&bar->ingen); gen = atomic_read(&bar->outgen); @@ -34,11 +34,11 @@ void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) } } -void mce_barrier_exit(struct mce_softirq_barrier *bar, bool wait) +void mce_barrier_exit(struct mce_softirq_barrier *bar, bool do_wait) { int gen; - if ( !wait ) + if ( !do_wait ) return; atomic_inc(&bar->outgen); gen = atomic_read(&bar->ingen); diff --git a/xen/arch/x86/cpu/mcheck/barrier.h b/xen/arch/x86/cpu/mcheck/barrier.h index c4d52b6192..5cd1b4e4bf 100644 --- a/xen/arch/x86/cpu/mcheck/barrier.h +++ b/xen/arch/x86/cpu/mcheck/barrier.h @@ -32,14 +32,14 @@ void mce_barrier_init(struct mce_softirq_barrier *); void mce_barrier_dec(struct mce_softirq_barrier *); /* - * If @wait is false, mce_barrier_enter/exit() will return immediately + * If @do_wait is false, mce_barrier_enter/exit() will return immediately * without touching the barrier. It's used when handling a * non-broadcasting MCE (e.g. MCE on some old Intel CPU, MCE on AMD * CPU and LMCE on Intel Skylake-server CPU) which is received on only * one CPU and thus does not invoke mce_barrier_enter/exit() calls on * all CPUs. * - * If @wait is true, mce_barrier_enter/exit() will handle the given + * If @do_wait is true, mce_barrier_enter/exit() will handle the given * barrier as below. * * Increment the generation number and the value. The generation number @@ -53,8 +53,8 @@ void mce_barrier_dec(struct mce_softirq_barrier *); * These barrier functions should always be paired, so that the * counter value will reach 0 again after all CPUs have exited. */ -void mce_barrier_enter(struct mce_softirq_barrier *, bool wait); -void mce_barrier_exit(struct mce_softirq_barrier *, bool wait); +void mce_barrier_enter(struct mce_softirq_barrier *, bool do_wait); +void mce_barrier_exit(struct mce_softirq_barrier *, bool do_wait); void mce_barrier(struct mce_softirq_barrier *); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:45:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:45:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574821.900422 (Exim 4.92) (envelope-from ) id 1qR8Pe-0000TX-93; Wed, 02 Aug 2023 09:45:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574821.900422; Wed, 02 Aug 2023 09:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pe-0000Qh-4x; Wed, 02 Aug 2023 09:45:02 +0000 Received: by outflank-mailman (input) for mailman id 574821; Wed, 02 Aug 2023 09:45:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pc-0000LL-AA for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:45:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ed653e6-3119-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 11:44:59 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 9C0044EE0741; Wed, 2 Aug 2023 11:44:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ed653e6-3119-11ee-b25f-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 Date: Wed, 2 Aug 2023 11:44:29 +0200 Message-Id: <16fa23ecb465442c566a18af0a569092075eef26.1690969271.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename variables to avoid shadowing and thus address MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/hvm/mtrr.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index 29f3fb1607..d504d1e43b 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, uint64_t gfn_start, static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) { - const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr; + const struct mtrr_state *mtrr = &v->arch.hvm.mtrr; struct hvm_hw_mtrr hw_mtrr = { - .msr_mtrr_def_type = mtrr_state->def_type | - MASK_INSR(mtrr_state->fixed_enabled, + .msr_mtrr_def_type = mtrr->def_type | + MASK_INSR(mtrr->fixed_enabled, MTRRdefType_FE) | - MASK_INSR(mtrr_state->enabled, MTRRdefType_E), - .msr_mtrr_cap = mtrr_state->mtrr_cap, + MASK_INSR(mtrr->enabled, MTRRdefType_E), + .msr_mtrr_cap = mtrr->mtrr_cap, }; unsigned int i; @@ -710,14 +710,14 @@ static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) { - hw_mtrr.msr_mtrr_var[i * 2] = mtrr_state->var_ranges->base; - hw_mtrr.msr_mtrr_var[i * 2 + 1] = mtrr_state->var_ranges->mask; + hw_mtrr.msr_mtrr_var[i * 2] = mtrr->var_ranges->base; + hw_mtrr.msr_mtrr_var[i * 2 + 1] = mtrr->var_ranges->mask; } BUILD_BUG_ON(sizeof(hw_mtrr.msr_mtrr_fixed) != - sizeof(mtrr_state->fixed_ranges)); + sizeof(mtrr->fixed_ranges)); - memcpy(hw_mtrr.msr_mtrr_fixed, mtrr_state->fixed_ranges, + memcpy(hw_mtrr.msr_mtrr_fixed, mtrr->fixed_ranges, sizeof(hw_mtrr.msr_mtrr_fixed)); return hvm_save_entry(MTRR, v->vcpu_id, h, &hw_mtrr); @@ -727,7 +727,7 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) { unsigned int vcpuid, i; struct vcpu *v; - struct mtrr_state *mtrr_state; + struct mtrr_state *mtrr; struct hvm_hw_mtrr hw_mtrr; vcpuid = hvm_load_instance(h); @@ -749,26 +749,26 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) return -EINVAL; } - mtrr_state = &v->arch.hvm.mtrr; + mtrr = &v->arch.hvm.mtrr; hvm_set_guest_pat(v, hw_mtrr.msr_pat_cr); - mtrr_state->mtrr_cap = hw_mtrr.msr_mtrr_cap; + mtrr->mtrr_cap = hw_mtrr.msr_mtrr_cap; for ( i = 0; i < NUM_FIXED_MSR; i++ ) - mtrr_fix_range_msr_set(d, mtrr_state, i, hw_mtrr.msr_mtrr_fixed[i]); + mtrr_fix_range_msr_set(d, mtrr, i, hw_mtrr.msr_mtrr_fixed[i]); for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) { - mtrr_var_range_msr_set(d, mtrr_state, + mtrr_var_range_msr_set(d, mtrr, MSR_IA32_MTRR_PHYSBASE(i), hw_mtrr.msr_mtrr_var[i * 2]); - mtrr_var_range_msr_set(d, mtrr_state, + mtrr_var_range_msr_set(d, mtrr, MSR_IA32_MTRR_PHYSMASK(i), hw_mtrr.msr_mtrr_var[i * 2 + 1]); } - mtrr_def_type_msr_set(d, mtrr_state, hw_mtrr.msr_mtrr_def_type); + mtrr_def_type_msr_set(d, mtrr, hw_mtrr.msr_mtrr_def_type); return 0; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:45:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:45:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574820.900416 (Exim 4.92) (envelope-from ) id 1qR8Pe-0000PT-21; Wed, 02 Aug 2023 09:45:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574820.900416; Wed, 02 Aug 2023 09:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pd-0000O4-TX; Wed, 02 Aug 2023 09:45:01 +0000 Received: by outflank-mailman (input) for mailman id 574820; Wed, 02 Aug 2023 09:45:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pc-0000Lc-5p for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:45:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3df6e956-3119-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 11:44:58 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id C26E14EE0737; Wed, 2 Aug 2023 11:44:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3df6e956-3119-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: [XEN PATCH 0/4] x86: address some violations of MISRA C:2012 Rule 5.3 Date: Wed, 2 Aug 2023 11:44:27 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some variables are renamed or deleted in this series to avoid shadowing, which violates MISRA C:2012 Rule 5.3, whose headline is: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". Nicola Vetrini (4): x86/mce: address MISRA C:2012 Rule 5.3 x86/mtrr: address MISRA C:2012 Rule 5.3 x86/irq: rename variable to address MISRA C:2012 Rule 5.3 x86/setup: address MISRA C:2012 Rule 5.3 xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- xen/arch/x86/cpu/mcheck/barrier.h | 8 ++++---- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/mtrr.c | 32 +++++++++++++++---------------- xen/arch/x86/include/asm/irq.h | 2 +- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/io_apic.c | 10 +++++----- xen/arch/x86/irq.c | 12 ++++++------ xen/arch/x86/msi.c | 4 ++-- xen/arch/x86/setup.c | 3 +-- xen/include/xen/irq.h | 2 +- 11 files changed, 42 insertions(+), 43 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:45:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:45:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574822.900427 (Exim 4.92) (envelope-from ) id 1qR8Pe-0000cs-Kv; Wed, 02 Aug 2023 09:45:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574822.900427; Wed, 02 Aug 2023 09:45:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pe-0000ag-Fp; Wed, 02 Aug 2023 09:45:02 +0000 Received: by outflank-mailman (input) for mailman id 574822; Wed, 02 Aug 2023 09:45:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pd-0000LL-AU for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:45:01 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f5c049e-3119-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 11:45:00 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 5CF0D4EE0742; Wed, 2 Aug 2023 11:44:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f5c049e-3119-11ee-b25f-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: [XEN PATCH 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 Date: Wed, 2 Aug 2023 11:44:30 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The extern variable 'irq_desc' defined in 'irq.h' is shadowed by local variables in the changed file. To avoid this, the variable is renamed to 'irq_description'. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/include/asm/irq.h | 2 +- xen/arch/x86/io_apic.c | 10 +++++----- xen/arch/x86/irq.c | 12 ++++++------ xen/arch/x86/msi.c | 4 ++-- xen/include/xen/irq.h | 2 +- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 2180abeb33..ca5bb96388 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -474,7 +474,7 @@ void hvm_migrate_pirq(struct hvm_pirq_dpci *pirq_dpci, const struct vcpu *v) if ( !desc ) return; - ASSERT(MSI_IRQ(desc - irq_desc)); + ASSERT(MSI_IRQ(desc - irq_descriptor)); irq_set_affinity(desc, cpumask_of(v->processor)); spin_unlock_irq(&desc->lock); } diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h index ad907fc97f..f6df977170 100644 --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -172,7 +172,7 @@ int assign_irq_vector(int irq, const cpumask_t *mask); void cf_check irq_complete_move(struct irq_desc *desc); -extern struct irq_desc *irq_desc; +extern struct irq_desc *irq_descriptor; void lock_vector_lock(void); void unlock_vector_lock(void); diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index b3afef8933..b59d6cfb9e 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -990,9 +990,9 @@ static inline void ioapic_register_intr(int irq, unsigned long trigger) { if ((trigger == IOAPIC_AUTO && IO_APIC_irq_trigger(irq)) || trigger == IOAPIC_LEVEL) - irq_desc[irq].handler = &ioapic_level_type; + irq_descriptor[irq].handler = &ioapic_level_type; else - irq_desc[irq].handler = &ioapic_edge_type; + irq_descriptor[irq].handler = &ioapic_edge_type; } static void __init setup_IO_APIC_irqs(void) @@ -1098,7 +1098,7 @@ static void __init setup_ExtINT_IRQ0_pin(unsigned int apic, unsigned int pin, in * The timer IRQ doesn't have to know that behind the * scene we have a 8259A-master in AEOI mode ... */ - irq_desc[0].handler = &ioapic_edge_type; + irq_descriptor[0].handler = &ioapic_edge_type; /* * Add it to the IO-APIC irq-routing table: @@ -1912,7 +1912,7 @@ static void __init check_timer(void) if ((ret = bind_irq_vector(0, vector, &cpumask_all))) printk(KERN_ERR"..IRQ0 is not set correctly with ioapic!!!, err:%d\n", ret); - irq_desc[0].status &= ~IRQ_DISABLED; + irq_descriptor[0].status &= ~IRQ_DISABLED; /* * Subtle, code in do_timer_interrupt() expects an AEOI @@ -2009,7 +2009,7 @@ static void __init check_timer(void) printk(KERN_INFO "...trying to set up timer as Virtual Wire IRQ..."); disable_8259A_irq(irq_to_desc(0)); - irq_desc[0].handler = &lapic_irq_type; + irq_descriptor[0].handler = &lapic_irq_type; apic_write(APIC_LVT0, APIC_DM_FIXED | vector); /* Fixed mode */ enable_8259A_irq(irq_to_desc(0)); diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 6abfd81621..ed95896bce 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -45,7 +45,7 @@ integer_param("irq-max-guests", irq_max_guests); vmask_t global_used_vector_map; -struct irq_desc __read_mostly *irq_desc = NULL; +struct irq_desc __read_mostly *irq_descriptor = NULL; static DECLARE_BITMAP(used_vectors, X86_NR_VECTORS); @@ -424,9 +424,9 @@ int __init init_irq_data(void) for ( vector = 0; vector < X86_NR_VECTORS; ++vector ) this_cpu(vector_irq)[vector] = INT_MIN; - irq_desc = xzalloc_array(struct irq_desc, nr_irqs); - - if ( !irq_desc ) + irq_descriptor = xzalloc_array(struct irq_desc, nr_irqs); + + if ( !irq_descriptor ) return -ENOMEM; for ( irq = 0; irq < nr_irqs_gsi; irq++ ) @@ -1133,7 +1133,7 @@ static void cf_check set_eoi_ready(void *data); static void cf_check irq_guest_eoi_timer_fn(void *data) { struct irq_desc *desc = data; - unsigned int i, irq = desc - irq_desc; + unsigned int i, irq = desc - irq_descriptor; irq_guest_action_t *action; spin_lock_irq(&desc->lock); @@ -1382,7 +1382,7 @@ static void __set_eoi_ready(const struct irq_desc *desc) struct pending_eoi *peoi = this_cpu(pending_eoi); int irq, sp; - irq = desc - irq_desc; + irq = desc - irq_descriptor; if ( !action || action->in_flight || !cpumask_test_and_clear_cpu(smp_processor_id(), diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index d0bf63df1d..35d417c63a 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -1322,7 +1322,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) unsigned int i = 0, nr = 1; irq = entry->irq; - desc = &irq_desc[irq]; + desc = &irq_descriptor[irq]; spin_lock_irqsave(&desc->lock, flags); @@ -1377,7 +1377,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) break; spin_unlock_irqrestore(&desc->lock, flags); - desc = &irq_desc[entry[++i].irq]; + desc = &irq_descriptor[entry[++i].irq]; spin_lock_irqsave(&desc->lock, flags); if ( desc->msi_desc != entry + i ) goto bogus; diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index 9747e818f7..56a3aa6a29 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -107,7 +107,7 @@ typedef struct irq_desc { } __cacheline_aligned irq_desc_t; #ifndef irq_to_desc -#define irq_to_desc(irq) (&irq_desc[irq]) +#define irq_to_desc(irq) (&irq_descriptor[irq]) #endif int init_one_irq_desc(struct irq_desc *desc); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:45:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:45:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574823.900451 (Exim 4.92) (envelope-from ) id 1qR8Pg-0001Hw-86; Wed, 02 Aug 2023 09:45:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574823.900451; Wed, 02 Aug 2023 09:45:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pg-0001GB-2a; Wed, 02 Aug 2023 09:45:04 +0000 Received: by outflank-mailman (input) for mailman id 574823; Wed, 02 Aug 2023 09:45:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8Pe-0000Lc-Oz for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:45:02 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fdaf24d-3119-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 11:45:01 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 452BD4EE0743; Wed, 2 Aug 2023 11:45:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fdaf24d-3119-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 4/4] x86/setup: address MISRA C:2012 Rule 5.3 Date: Wed, 2 Aug 2023 11:44:31 +0200 Message-Id: <807b238780c3e2dfce785c6bb173099a4bd38e4b.1690969271.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The parameters renamed in the function declaration caused shadowing with the homonymous variable in 'xen/common/efi/boot.c'. Renaming them also addresses Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". The local variable 'mask' is removed because it shadows the homonymous variable defined in an outer scope, with no change to the semantics. It was introduced by commit 5a771800114c437fb857b44b3ed74f60e87979c2 as a refactoring of the branch that handles 'CONFIG_X86_64' for function '__start_xen'. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/setup.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 51fce66607..b0e6a39e23 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -33,7 +33,7 @@ static inline void vesa_init(void) {}; int construct_dom0( struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, + const module_t *image, unsigned long image_headroom, module_t *initrd, const char *cmdline); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2dbe9857aa..80ae973d64 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1577,8 +1577,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) s = map_s; if ( s < map_e ) { - uint64_t mask = (1UL << L2_PAGETABLE_SHIFT) - 1; - + mask = (1UL << L2_PAGETABLE_SHIFT) - 1; map_s = (s + mask) & ~mask; map_e &= ~mask; init_boot_pages(map_s, map_e); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 09:48:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 09:48:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574848.900461 (Exim 4.92) (envelope-from ) id 1qR8SV-0003G3-No; Wed, 02 Aug 2023 09:47:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574848.900461; Wed, 02 Aug 2023 09:47:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8SV-0003Fw-LI; Wed, 02 Aug 2023 09:47:59 +0000 Received: by outflank-mailman (input) for mailman id 574848; Wed, 02 Aug 2023 09:47:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8SU-0003Fq-Dl for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 09:47:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2089.outbound.protection.outlook.com [40.107.7.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8ab1ae8-3119-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 11:47:57 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8646.eurprd04.prod.outlook.com (2603:10a6:10:2dd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Wed, 2 Aug 2023 09:47:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 09:47:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8ab1ae8-3119-11ee-b25f-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PiwyOlrehs8Xq5TOXigJ3qKPE2QnCX2+lWyZLN8xkJlIKyPUuzvT0+30dgnOzkRu6J1wXo036y55XkzuyweRnp5ODHuzfCG3VAKqedVlhkBAYy5iqsQSJCWWdALDseD2UX3oIsV5SRSbMQu+D3j577zilYAmhk7yuCMUQwD7zl5K8DoxZQd35CsDzhTFgJPi5BE6HIyUylSpxmG1SH3LcYmduIIxVORGSFZvuAhORPsFqqxaF5rEDRLVo35hQySsF2/VhBtudBLjirCcdWUbJiqDG2N9cPRQrSD/yqmM+kCRex1E+RugNqZrnvNVG/IK1jTxNDJoohiIEJ1Z4aFFgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GPHQI3HV/ISYU//I4owjCgl9bftVPfSPRgtTkcbD1a4=; b=ejHHr0kpLipgxDxhZGoNC425P4F+SWhi98ZP9tQ0PNOy+mPoZxdM6CAO5v0zS9IJ8Uk9vlrh2Phm2QV/J8GQmLjpjKMiBDUSDnIV2nzOtC5RzRF4zRqkXxZi9ayUlAFZTahGskQNyVtSQD9oiwdSEQmq62g2bMPFAXrOOUszm7XW/P4TblwxFaf9hKxj5SxBB2exBiqcPtUwsEuMXdde0WlsadfX+4Tjf/8gegjO5S2+GoJQ5wRL34XFr/zBxZLZ0DvRLMkYvOTfK9qf5GijfohJslbBbC/0O4gNNN0MhfCEiy5F/51lR5X7OUxmWNfuDumcjZE9aK/Qvv/Ljr8U0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPHQI3HV/ISYU//I4owjCgl9bftVPfSPRgtTkcbD1a4=; b=HzF/HckZPqZ5OKtUxZ5uV0P+0M3pw7LVHMAuhnXEOig+h9kKuGO/rMBowWIdId2SIQC6uqsAL5kZNao+245yCvC4DJcNX9AY6f0F7MCEMoM4qAZ2xI+1Jwk1Cr6trIT/lhq6Zr5UuaX5qOsia0fPpGor9pJm1iN5MJu9dJ/1ypmcG9Fq3jX//vBgM+p4zucZ+VKTcS0rE2uPx2vM5mOfo5nnN58sh3CDzR9pL7FgWE8TYOBqVtJLp4bMcVdXmNhviFKtNj+L/4qm5fMw0lWwyuRDTv+McjGJ0VBJ70+56MK/yTE1ufjxo1/s1CgFj7d6myXpI8EU0aLpdeo/o/ymgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ff38731-fed7-91eb-c933-28d191fb429b@suse.com> Date: Wed, 2 Aug 2023 11:47:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH v2] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <30fdada8b08b2060c6f1ccc2ecb06d418efd97b0.1690966632.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <30fdada8b08b2060c6f1ccc2ecb06d418efd97b0.1690966632.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0241.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8646:EE_ X-MS-Office365-Filtering-Correlation-Id: d95b31ab-3168-4b82-a6c2-08db933d7b5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pw09r5ais+37lVtH4pr1aMBUQkmQmQxhYOzpaQECiPxWk2SF/odSruzdxik0hUZYsU+Xxcpbg6b8sgULq7EqR0oSrJnZgVTWV6T4RHMPrRGJWowNWLfpar42xcWK6SVhvjCiiiMajev6l3YIBPU7nSYX/0eVX79JrenYi5oGFQUHS7YNjO3JmieJHMUX/FfvH+1Z/eBKMioL76z91HqDUvpxCDOavhW/pzQWruY73hwrVigkkEGWSJiSUyHmT1/c2mx/cB4iY4wxnCyrX9ATDG2ychRDGRZTr1QDP/LQPPARfijftPqo8fw8n+iF4Bk5P3H6NM5QdLQGh/YQ6kHLLTJJm3z9UKWz0uR2nmcim71deZ9MB7/qQt4GDWwcfxDOvr/zZUjtTHoyrV3tyliWbtieSHVntZRPghD0egLdI61T7NTzm2TKMMY17SsOfy0BMBuU2Bu/VYitPf731UmcIaUYJZKDDl+iThkaciuM16Eg6fWL4pHe0aYRbUTspwXEoe+9qSdbfn7EqYmkZLaDicwULV+yYcgFxmoRnn407BY4lEFc4CAzv1F/c6SDD0Oh3NgX4oh0uT9pl7oWfsNuWW1tud+fvqPwDsRywGqQDizYnczaikUvv/+5pAGc/eKf4MRJOOjftBi4pem2n1awUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(4744005)(8936002)(2616005)(41300700001)(8676002)(5660300002)(86362001)(2906002)(36756003)(186003)(7416002)(53546011)(6506007)(6916009)(4326008)(66946007)(66556008)(26005)(66476007)(54906003)(6486002)(38100700002)(31686004)(316002)(31696002)(6512007)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1RoVGY4Mno1UXBhM3FHcDZKb1dBbjMxaW1WWVNXR2tCWit3SXRkMXV1YVlE?= =?utf-8?B?K2dGbFZVVXN5dXplSURlZTUra3dnM2hiZGFyWXlVS0lzbXZXcnR0QlY4ZjJQ?= =?utf-8?B?Z0hWalU5OVRjYTVmNzIwU1NLN3l4NEpYczlVV3RoelpBN2pSU1h3aGFKbDBT?= =?utf-8?B?SGNJR05uZENBM09abnhjSUUvNFdUSUJzWkJpUFVVMlMzZVBlUE5tZzlDNnV5?= =?utf-8?B?RjhXbTMwZXJmVVVRa0tCb3k0b3hGYVlQYjNyVXMxYy9nTGpUd2ZIcThEeEVM?= =?utf-8?B?c1BuOUIyRDgwaW9qTFYyMzNLdzl0MlIxZUl0MmR6V1UvMXlKeGc3N1g1VjY1?= =?utf-8?B?SngzYW5TWkhmaDhWQjdOSFFFeERUc1BSd1dqaHdaRE5ET1BlZU5jR2xyMTh5?= =?utf-8?B?NGxod2F5UFRTcWlVR0lFVTNJL2V5M09xMFYxdFFwMTZtY2k2T0Q3TldiZEtQ?= =?utf-8?B?RGtpUE1Ic1YwZENkWU5SV0lPbEpKTVo4eE8xT0pHbXREK3laOUN2V3pCNkJQ?= =?utf-8?B?RnNzM25nU2w0dnZuUnU0QWkvMy94eU8rbGphR01lWnpnYmh6MUQ0SVBtZlRK?= =?utf-8?B?RGU0aE5IYnRwOVc4Q0ozVmpsR1lNelVIRkdPM3JIYVM2ZTRoKzFndVJWWnp3?= =?utf-8?B?OG90UTVKbTNhZGlUTUY0RzFxUnZacG1iVE4xZTNESWZpZDdFRUFySWVLYTh1?= =?utf-8?B?bGJTbUc2TE9DL0h2dHNXVFNSY3FlWWppcWJRekVwbUlVUW5uMUx6SVM3OXFy?= =?utf-8?B?akE0bWNWWUZhVk1YemN0TWZrblJFbm9RcGEzWm9MVGk2UVBtazJuVTVQdDZx?= =?utf-8?B?cExzNXpxRWxIYi82ZVNvUkE0d0hJelNwcUJaUk9HcVM0TkdaamhTUkVXQkhQ?= =?utf-8?B?amJpWGFqNkFONktUUGJTTFdBckVhYjZOVXBHeUZYUWtyTHVwNTdiOTlPSnQw?= =?utf-8?B?NWpWQ1Bkd3dRNFUvMkttOGlaLzI3OWxPRTZZUElEckg4SDYrdURJYTVhWmQ5?= =?utf-8?B?emM1dFYzMUxpdTdIYTc0eVBNdU1RNEp6cGx5MVU4dTFrZVFBa1ZsN0liaUph?= =?utf-8?B?dEFzMlNTT2IwekY4NG1VaUZvMlZLc0hZWFIydE9zckQ2SU1FRTBWczNGZEZS?= =?utf-8?B?M3dIUFpMbTdDUjNkRXExclUyTm5JWHpCNUt5dXVIWG1YcDlIb01sekF1WGx5?= =?utf-8?B?VlRzNUlrUlN2M3VKODhadVVQMWttQUtHK2NvZmZmaDNpWUdZOTdnZTcvWGx5?= =?utf-8?B?OE5qN2RmSzFyY2t1UXF3UEljWGZWMnZORHFVMnh4RGd1b09ZZVRjaWNWS01i?= =?utf-8?B?TWtzRnNtaWNFU0JXWHdIeUFxVjdnV2h4QXd2aDdvYUVWbEZFOEMrVXVrWHg3?= =?utf-8?B?ZHZUODdVNW9GYzFtNVROUkhRaGF3UlNiUnJkcXFRZEgvRjVSVjRzQUYwSUF3?= =?utf-8?B?ZTRxRCtqQWN6VGNXRXc4SHQ0Z3Z4eXU3QzRyd05Rd1lQQnRqbHc3YU9FRkQw?= =?utf-8?B?MUZJUFF0bHJURG5kcDdFZHZOTHJjc3drZ1hNWXMxOFBBNzNQdTcrT1p6NU5t?= =?utf-8?B?eVhIaDQ1QSs0WHlQQ2JDNVQrR2MwaGVUTS84c0NtVG9EUG5YSmRFcUdZbVJE?= =?utf-8?B?THo1REo2bTBtcFFLVi9FQ0Y5YjQrMThsaWo4YlJobXp6dzgyNWVjaEJ0NnVQ?= =?utf-8?B?VFFxVytINXJWbjdFdlBBWHdUd0dBOWFKUG96SE1hWU5GMzlCekJuZmkvWVFJ?= =?utf-8?B?VWVTLzJiZUtCcUIwdFNoTXV5bHFhSUZ3bkcwNGhzNHRzOFIyejIza2d4VlVY?= =?utf-8?B?WUxQbjBxNk5RMHMwazloRVZWTzNVa2U2OUNjNXhraG0wWURLcVNaL3AzT1RP?= =?utf-8?B?S1pOeGxaS1JzN3FBWlZCT0Y2L1lpc3JscERBUDM0U0tTYmc5UDBGR2EyWGhh?= =?utf-8?B?SnpUc0pZSi9nR1dnaWs3NUliNmx2ZmpBbmsyUXlsRGRudFkzM1pGSGRYcXBI?= =?utf-8?B?N01qZnE2QkJPOVlxa3NsMnA0Qy9OVVRJWjVLOVZOQ2psVWR3dFNvbWUyNGJS?= =?utf-8?B?ZTJ2TUE1NU1DUVVOeFJXQ1JseEFDMGo0Ui9hdkI1cTBLR040YThVNXlFTVhT?= =?utf-8?Q?Ei7EfPCzyK8d/Xr3koIHO4cm1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d95b31ab-3168-4b82-a6c2-08db933d7b5b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 09:47:27.6135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k4qNlHU7T3GI/N718nWUucc1wMMaU6+eb5hb0RmyjcUrzVDo/IrpJEIWUWzUW/gWrH9cLWTpUtvKH8816TaMNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8646 On 02.08.2023 10:57, Nicola Vetrini wrote: > The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the > struct declaration to have no named members, hence violating > Rule 1.3: > "There shall be no occurrence of undefined or critical unspecified behaviour" > because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: > "If the struct-declaration-list contains no named > members, the behavior is undefined." > > Given that Xen is using an undocumented GCC extension that specifies the > behaviour upon defining a struct with no named member, this construct is > well-defined and thus it is marked as safe. Especially after realizing that I was wrong here (I was under the wrong impression that we'd generate a struct without members, when it's one without named members, yet [to me at least] only the former is a known gcc extension we use), I've sent an alternative proposal. Let's see whether in particular Andrew considers this acceptable. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 10:01:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 10:01:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574853.900471 (Exim 4.92) (envelope-from ) id 1qR8fn-0005i8-TN; Wed, 02 Aug 2023 10:01:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574853.900471; Wed, 02 Aug 2023 10:01:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8fn-0005i1-Qu; Wed, 02 Aug 2023 10:01:43 +0000 Received: by outflank-mailman (input) for mailman id 574853; Wed, 02 Aug 2023 10:01:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR8fm-0005hv-So for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 10:01:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93f766f4-311b-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 12:01:41 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id C81584EE0737; Wed, 2 Aug 2023 12:01:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93f766f4-311b-11ee-b25f-6b7b168915f2 MIME-Version: 1.0 Date: Wed, 02 Aug 2023 12:01:40 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_P?= =?UTF-8?Q?au_Monn=C3=A9?= , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 In-Reply-To: <5ff38731-fed7-91eb-c933-28d191fb429b@suse.com> References: <30fdada8b08b2060c6f1ccc2ecb06d418efd97b0.1690966632.git.nicola.vetrini@bugseng.com> <5ff38731-fed7-91eb-c933-28d191fb429b@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <796058860d0536799e40fc14f169efd2@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 02/08/2023 11:47, Jan Beulich wrote: > On 02.08.2023 10:57, Nicola Vetrini wrote: >> The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the >> struct declaration to have no named members, hence violating >> Rule 1.3: >> "There shall be no occurrence of undefined or critical unspecified >> behaviour" >> because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: >> "If the struct-declaration-list contains no named >> members, the behavior is undefined." >> >> Given that Xen is using an undocumented GCC extension that specifies >> the >> behaviour upon defining a struct with no named member, this construct >> is >> well-defined and thus it is marked as safe. > > Especially after realizing that I was wrong here (I was under the wrong > impression that we'd generate a struct without members, when it's one > without named members, yet [to me at least] only the former is a known > gcc extension we use), I've sent an alternative proposal. Let's see > whether in particular Andrew considers this acceptable. > Well, I don't know the exact discussion on this in that MISRA meeting (25/07 iirc), but the outcome I'm aware of was to deviate that construct because there are possibly others like that in other configurations/future patches. Anyway, this usage does not fall under gcc's documented extensions (either the one you mentioned or the one about unnamed fields, 6.63), but it does allow it (has a warning only on -pedantic afaict), hence why I put undocumented here. In the meantime, I can test your patch to see if it has no unintended impact on other code w.r.t. Rule 1.3. Regards, -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 02 10:34:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 10:34:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574861.900481 (Exim 4.92) (envelope-from ) id 1qR9B8-0000iq-9t; Wed, 02 Aug 2023 10:34:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574861.900481; Wed, 02 Aug 2023 10:34:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9B8-0000iI-78; Wed, 02 Aug 2023 10:34:06 +0000 Received: by outflank-mailman (input) for mailman id 574861; Wed, 02 Aug 2023 10:34:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9B7-0000i8-Az; Wed, 02 Aug 2023 10:34:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9B7-00077X-6j; Wed, 02 Aug 2023 10:34:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9B6-00034j-PS; Wed, 02 Aug 2023 10:34:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qR9B6-00078P-Ou; Wed, 02 Aug 2023 10:34:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uRhghlJ1IlzNPwqV/a7aa+mgZgB6uufALbtsOq34mpM=; b=6Ce5xZqRj/+E7yZkBKNjxE1qny iaB8rlCJt5BmWqC4A0vADKAWv7cGyPMTWe+wr+AVQySyu2y/qVkDMZbB7nz7DhYMbK8zll4eyezBw tNsgiLQCo4kG6TUOjvVP1uGDrcWN4QYteZARo/D+flijBRpevSb1SeQAlNkcFpMkrvvA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182096: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8cb945be2d6d7c3f8ad9bbc4ec1ec5c189a6717b X-Osstest-Versions-That: qemuu=ccb86f079a9e4d94918086a9df18c1844347aff8 From: osstest service owner Date: Wed, 02 Aug 2023 10:34:04 +0000 flight 182096 qemu-mainline real [real] flight 182113 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182096/ http://logs.test-lab.xenproject.org/osstest/logs/182113/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 182067 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 182113-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182067 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182067 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182067 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182067 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182067 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182067 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182067 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182067 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 8cb945be2d6d7c3f8ad9bbc4ec1ec5c189a6717b baseline version: qemuu ccb86f079a9e4d94918086a9df18c1844347aff8 Last test of basis 182067 2023-07-29 02:34:52 Z 4 days Testing same since 182096 2023-07-31 15:38:52 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: CĂ©dric Le Goater Klaus Jensen Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 8cb945be2d6d7c3f8ad9bbc4ec1ec5c189a6717b Merge: ccb86f079a c1e244b655 Author: Richard Henderson Date: Sun Jul 30 13:07:47 2023 -0700 Merge tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu into staging hw/nvme fixes - use the stl/ldl pci dma api # -----BEGIN PGP SIGNATURE----- # # iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmTGuc8ACgkQTeGvMW1P # Dek41wgAwqgRmtUhmmaQJJpF5Pya3J7n3Zkbp+cULdnSp/su7W7yIUTcTzdbr34d # 9LbNHmWerXYinlIxG08ZWw2lq0TwApKj+8gv/wf8H7dG86/pBYfoQvOlkNx2QKyR # vtRNlILCEbJpbSfY3LbFNvRGOkArr6HkzT4hZprUIfCvRg58u5oIxEx/ZYa+m3WU # ED0y/46e7HbVbmbwJKrn4EK3k0zGdFyeINRZ5TB5DML3lCTX6eaZTLUXGIb7LLcK # Xyv6/TCkPTggDszTam24kx0A7DhC+3f2C8DsJg7H8jnWb1F+oq/2EJam/0HU22Uk # n348MrWOusuF7kbHMCP9h28gYT3aWw== # =KjVO # -----END PGP SIGNATURE----- # gpg: Signature made Sun 30 Jul 2023 12:28:15 PM PDT # gpg: using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9 # gpg: Good signature from "Klaus Jensen " [unknown] # gpg: aka "Klaus Jensen " [unknown] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468 4272 63D5 6FC5 E55D A838 # Subkey fingerprint: 5228 33AA 75E2 DCE6 A247 66C0 4DE1 AF31 6D4F 0DE9 * tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu: hw/nvme: use stl/ldl pci dma api Signed-off-by: Richard Henderson commit c1e244b6552efdff5612a33c6630aaf95964eaf5 Author: Klaus Jensen Date: Thu Jul 20 11:42:24 2023 +0200 hw/nvme: use stl/ldl pci dma api Use the stl/ldl pci dma api for writing/reading doorbells. This removes the explicit endian conversions. Reviewed-by: Philippe Mathieu-DaudĂ© Reviewed-by: CĂ©dric Le Goater Tested-by: CĂ©dric Le Goater Reviewed-by: Thomas Huth Signed-off-by: Klaus Jensen From xen-devel-bounces@lists.xenproject.org Wed Aug 02 11:00:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 11:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574873.900495 (Exim 4.92) (envelope-from ) id 1qR9aG-00045U-Ij; Wed, 02 Aug 2023 11:00:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574873.900495; Wed, 02 Aug 2023 11:00:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9aG-00045N-FP; Wed, 02 Aug 2023 11:00:04 +0000 Received: by outflank-mailman (input) for mailman id 574873; Wed, 02 Aug 2023 11:00:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9aF-0003oY-EX for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 11:00:03 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8f9b1c6-3123-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 13:00:01 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Aug 2023 06:59:54 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6475.namprd03.prod.outlook.com (2603:10b6:303:122::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 10:59:52 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Wed, 2 Aug 2023 10:59:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8f9b1c6-3123-11ee-b25f-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1690974001; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=oUgvU7aeNf3v7ae8QQ0uyj+OkUFKYhxjCzflP9AkPQM=; b=YKwR7jlqO/tsJ2S2pkB5K2Vm+Kscxfy+4w3xLoJuDD4AIS2lXOMgwCpx k2qz4Z4ualmSexU0ew8SlOwyUoyN59fZQfnkLj5ODQb6c4WKjcXkwGsib oiikUBxlFFzgmdwPii39zp5NCD2vh4SukYfA/ODDzqippQXphUO4uuHer U=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 120876147 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xRzzBKyHrqJ8eHA2Y6N6t+f2xyrEfRIJ4+MujC+fZmUNrF6WrkVUm DAYW2HQOKnbYWHyftslOd++9RsPsMeDzt4yTAA5pCAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPaoT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUVK8 aUcDhYUUg2C3fmmxrCEY+dLme12eaEHPKtH0p1h5RfwKK98BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjmVlVMuuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAtpCS+PhqqECbFu77TU3OTQvT2OAsNKpl0WfA4luF nIe0397xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqC8p+EoDX0PjIaRUcEZCQDSQJD/dT/uoA1jzrFU9l4Hai6yNbyHFnNL yuiqSE/g/AfiJAN3qDip1Tf2Wvz+d7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lRdlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:gktUoaHYTpmPrepTpLqELMeALOsnbusQ8zAXPiBKJCC9E/bo8v xG+c5w6faaslkssR0b9+xoW5PwI080l6QU3WB5B97LMDUO0FHCEGgI1/qA/9SPIUzDHu4279 YbT0B9YueAcGSTW6zBkXWF+9VL+qj5zEix792uq0uE1WtRGtldBwESMHf9LmRGADNoKLAeD5 Sm6s9Ot1ObCA8qhpTSPAhiYwDbzee77a7bXQ== X-Talos-CUID: =?us-ascii?q?9a23=3AYBsHWWm3YY4pcSk2tIyLuRPVTrvXOVnZyC7UBWm?= =?us-ascii?q?hNXtoEqaFT12v0a1DjOM7zg=3D=3D?= X-Talos-MUID: 9a23:oKz+SwUeGTK6uAbq/BS1oABLDd1Q2LWFGF0GsM1divS6PwUlbg== X-IronPort-AV: E=Sophos;i="6.01,249,1684814400"; d="scan'208";a="120876147" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAd3yBBpQJQHpAS0lJy4GRnntigoBjVONMwA/CKFngO6AjM+LJYBTPMaSbqNCL0R4qA1YnvIAmfK7M4V+SvVlWhUrEyjpo48fEnN5zbkt7WSeHP8Go/tPWOdU3kjw6j3RYJg2h+If4QYyWYeJfMKExMmbRuJYmLA+zvQLFq7Aqyn7k16pTj4EwCWBQ81GRLv8bA2bjngVzBPxZ2r4W+ItboshdqREQXhoPeGTNeot2w36LkWLpWMmtcGOF37Dqln0jxw+75z4rpPkF3lhHmM8nYsuEWpPk/N6gdumWkGnI0niiJJ7kqiGoPC3j7qu8zLosM+MlZxgNx39AVRAgrn8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ULTEx47mnRQuAP2u8jn8rm48uieFQBZpTlSRk2k0kvw=; b=Zrz1FFUSIjunXEkVEUsqOK4ktc0m4iBfRoLGCovp55m4cSpTO9ZUTl/8YwhJef54+V36YeD+vEfK70EftYeGnNTXwUxtYbEImvlVkCCthwJ6ka+QMLVPY9t1PVZwmDbPQ3P9TO7sLwd6T/HFQ2wf4kHd2niF32kjRsGS1TcoVeWYmLbREKHFeWdnqRaUlbbs0KGhbkKBJjeGcccrqdCeLix6Vok5jRhEy3VcyaSm/iTjEifx0630nvKEMUNcey8CtmzRcfJ7Hnaqw2SGfn/b9LJRyksl+fX+hQ0A7SGlKs8J0qAJzKyOVV81C5c0uxWizwcbxNDv+a9A58ATcbQjZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ULTEx47mnRQuAP2u8jn8rm48uieFQBZpTlSRk2k0kvw=; b=QSnZKbjOgrqYDMIEzOeURNfPOzV0J7OjDLuqA2WmLUqXWbuViN9id9He1Geia+5R9Cn92g8KicjO5X/3xBQvcgL9LR0nSoFI00BHYNRzis9uQHSxvX2uhxQggQS8kK190rWG8epAzF/9HiJ+7MnrKMEt1req4IrdENuL10mFv1U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <423ec861-52b7-67c9-26b6-c069c8bf1df4@citrix.com> Date: Wed, 2 Aug 2023 11:59:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] x86/gen-cpuid: avoid violations of Misra rule 1.3 Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Nicola Vetrini References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0020.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::32) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW4PR03MB6475:EE_ X-MS-Office365-Filtering-Correlation-Id: dd58b1d3-d494-41cd-06e8-08db93479845 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pmszJfu+uXigBOb9MAQpxdEEcX+UjMYVIhQ4xQ+z5bvWF8mk/1oUsZRm6UWEfQ2+FClzyvQBdKFs94H2W6lHzfM2cUJNOg3iUKEZnxt3zWvbpxPk4MPAIAPyUV535l4GzpJDdR60Qm6g2jDAvGY5yOdiEYTeNf3LrAc/ANQtG2aEXSQkC8g8ssc42eGPJYcCZA0tCBCt54q/tDi1WRbSFQDT10XxXKP2WxQfULOizpoe8BzwIootHgqgzhyGiOrZxocUoPXWzz2xyrGaA1oTCVHECQh/T/SyP0ikbuwObPcDLE9jI0LgGJATMYoDt6icTsmwHs19a3rlJbmBHdNYIkBw+iJ1EvZPENfXwRnQa/tIl0ff9GPh8Bg6Y1tjpvKYp9wbMCtLJESdW0i/fLvKl/m8gshbflKaI9ONxK6kxdZ2s//t9YYTI3D0GA7TT5P+b06fEwEBbp3Zqy3hqkvBStPTzCmzpF9fjdPB+tsFTlRECsECgK+RMTzmMvFpVgpQt9iiCqgYyVa1lqe01Wg3N/9FvDjhXCBNVbv35Iy98xSOXdn0ejNPHHeh6qr6xClhd4JsVUfPfdJQan39ymXoqhXSdu79XVvzBY5oO97EbXTTWqGwT2pTH1W4uPBx27+lBIail6ispCEJRXB77pkl9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199021)(8936002)(8676002)(31686004)(41300700001)(5660300002)(2906002)(83380400001)(2616005)(186003)(86362001)(478600001)(54906003)(110136005)(316002)(53546011)(26005)(82960400001)(6506007)(38100700002)(66946007)(6666004)(66476007)(66556008)(31696002)(6486002)(4326008)(6512007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkxGZnlZTjh5Qi9BcGZIbmZWazVUdUtjSzdNbHNJQTJ0T1E1Uk4yN3h4SEdp?= =?utf-8?B?VnYvOEFiQXB6ZStiUE56c05RS0puSjZYNkM4M0R3bmxrZlM0RU1Vd2llNSs1?= =?utf-8?B?VForUHdyK1FhZ3krcEtrQjlvQllaUjNzRGhGamQ2aXZzQTBxUUpaRmFWc3hV?= =?utf-8?B?enRPMXBtTzJ6VTJFL2pjbndMVzRBNUNoY3ZXaVBrMjlNTlB3V2JpQ0tzTWx6?= =?utf-8?B?RHlLN3NSdjJhRTBjUWk3Q0w3TjNKK0dNc2dKOXdHRjMrd1kxb2RPS0trMEpG?= =?utf-8?B?ZDFmelZXYzRodk5walgwam5IZkdGWEN1VmVrcGpuYUhsckdFZjFMZUVvZXV5?= =?utf-8?B?UW1WcHpWSEJ4Tng4KzdCQ2UvK3ZpeDJQMXVUNVFNMTAvSWE0OUJ6WUV2OW45?= =?utf-8?B?VzdtYi93S05nNk14UXRNU2cxZ1U2aFROQzIrRVIyelZTSzU2NndMTHNGVzhz?= =?utf-8?B?TnJCb3U3eTU0UWFWUVVFVDlEUXRXOHUzbXh4UStYSlBtS3dLVEZkZG5GRTJT?= =?utf-8?B?UXUydWpKVjJvT2VaRTNMeWpqTFZ1QUtvTUpXaHBKbUlKcVJyaEVGUzM3eVVI?= =?utf-8?B?NGNJNlBhTkl0UHNqd3JoRW1kU014a0lwMTkreVUva2RYekFJSG9zbVBnbzEy?= =?utf-8?B?di9rMzEvaEY2UlJWVTdQR2NLb2paVFJLaElSVlNlV1ZyblBhMjFNVGdKMDN0?= =?utf-8?B?NDRzMmkwMmxBTVN0NkJYMkZ5ei9ST2xwcHZGdWtYOEtKSE1WQ0M3REgraTEv?= =?utf-8?B?QklxRHlWTktLemNzZ3Z6YkZEaVRTeDZBYytOUDczRzZpdFh5ZENOa1lwVUdJ?= =?utf-8?B?WC96cUVvM0JCTUZ2MWt3RTNJYlpHYUtiTmhjaE1PWWdYaEwzVDVJYnlJb1Zt?= =?utf-8?B?a3dOYmpBUWUwMGVpS1VWUUQrMk5YbkFRTktIOWNjOWZLYkkxWEQva1JWd1F6?= =?utf-8?B?dVNKTDNHSksrRndka1g3SlBPRlZ2bU1YTmsrallWVUs4Mk9FYTF3YWJCNFBZ?= =?utf-8?B?OWdUTFNQZUhuOVdmUVUzM0svcE9QMkdlSTBUVWdjQ3FFcDBmRzJ2YU5JbEty?= =?utf-8?B?ZnlIbEtBRjhscmQydjFreDJuaFpNaE9DQ1pxc3M3WVhrNEpteTVNVkQveTE1?= =?utf-8?B?WWNRemM3M3Y3VytvcFA2ME1sanM5emhnbmZJenFudThMODd2ZVRneGlWM0Yy?= =?utf-8?B?UWl4MThWTDh1TkZMeTR6RkZBOTRWazEyaVkrRllRQUcwWmxPOFpUUXRjWDc2?= =?utf-8?B?ZERKRGdWVmNIcElHNWgyOThmV2FreWQ3TlVVQXgxUW45a0JZVjdueGZ2ckNn?= =?utf-8?B?M0pzaGtCU2NoTDRrQWN0WUdqc3FRNVNIMGlDMjdBc0dFK2ZEcjNxSzBlMU9I?= =?utf-8?B?SW82a1VNcUFDWGxoM3JZWGZtOHpEZHozYjNDTGx0RmQ4T0wyMktYQ3NaNGpL?= =?utf-8?B?eXRoR25nellpUXBxaENLR1hkMGxoVVZFUnpXOFY2dzBjWnZVR1lEM1JDRWR4?= =?utf-8?B?V2Ztd3Y2RjlOaUUvaThsMU4zUW8yeld1cmlVdXNNUWFYUHNFdEtEaXF4b2dC?= =?utf-8?B?RC94WnVGMERXbWNjN3R3LzlCcmhLY2pRcDhUMFJja0kvdUFMUVpUZW5KUnFG?= =?utf-8?B?bGl6U3gwbzMyVFFUZVA0c1IzeXRVZjBPME0vL0pYQUtud1R3R093MGlZNHla?= =?utf-8?B?ZlEyNG1NRW1hTGhpVnJOQUd6L3NkOVRZNlhtcG8rV0xTYU9nWExiM29VQTlZ?= =?utf-8?B?NVFqWitXUTVjb2wrT1pjS2R5dERTUGVVUjJZUWROeVBDdmltVHBKblNibFFH?= =?utf-8?B?Q01OMGNqYXVLRWlROTdlY1BDRjRBNGp0NGFPZk83dHJIcnlpOWl6YmE4ZkU2?= =?utf-8?B?V2h5RytMYlZBaktmYTVaNjQ5aW0vQnlUM280QjZvbDZZSUVJLzNuRTBJN0xC?= =?utf-8?B?a2JYM04xaE9wb2xJTkR2b1lrUWdINW16d0ZyLzNjTGV0UXdQc0FialcyVXRp?= =?utf-8?B?QjRobGUvYUFzbVliVzNXSkpvR0UycmZVd3hrdUZpaGxEcFJjNFB0UWg2TC9S?= =?utf-8?B?QXlrZHpRbDkzUjlzTnBOMXBzZS9lMzBwSC9IZVBoOXBtbWVoZXVNQmtxTWUr?= =?utf-8?B?K0EvM0E5SGVDbXhnOGJXem5sTCs1NW9hbzZsNWlrWm9ranFZdjcycjF4K2V4?= =?utf-8?B?ZlE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /pOuDbEfvlXCQ02if9f8ObsGBZ3gI2qibtAfW7h6WFxqdcmlTx8IS+6+H7ucwMYGnyBUgIJUOxyfVUZvqxtKhPjImlg72Y2O1KIY5qMFw6ImU6sL3wWouZcQPycopqv15YyOAvmLHbN01hmnJzlqlFauQkY/hzdYvbmtlTqnX1g22aqqQISSD7Tltcule+R/N5pR1udTwkFQ3fSfA0Krje0jDvF6pkcEH3yUn++Iyv13dKSl3AiSwFDIhgkSLSiA2+46nppKEPlKsKzokP/ZUHMrrlvCL88cOyhDWPG5AyYkP5oGkR0gszQQiBhRdbVuBZRWIHcU08oBQ01MCuZEpJTcduBYzqNlIhNooCoUZ7QGgA7z0Ghx4T6wZ41dsCOASu66O/BRZafz3ndP6LRtPrxJYpu6IdVxhJ0AjjNBqGR5GMVAp+W1fTIkLlDSaYry6SY9mv3VQOFSCNI23OC2d45o9iYvCMvH13lB6fSJCl/QQkx/ThWRuqHGGZhPrNXXD8U80dMbQPAYtanybFJS2u9DgOElzV4gAtegVsNkdA2S/tj6Xv5w1TxjXwk9H5OG6Qt4uFvJXwWsFAJmMvH1mOEbYydzhWWWrTq42nprjpT8/tmGnEgadTdknxPvuriTxf97Jpq3t5vJEMeyla2LD+tZJg6Mz39M/0pYsyE/anVZ+WceTDkFZ0yh2r7vPp2w71pdhtLf1n313GhJnclyD0W7oVQDIHtZanBn4xT2u7mJ7K79zjy7rbZ+ibwk1QLvSbzRjZL/WiFLTr2pENPTLMSbvmW7LUv8HcbCx73UDH7+FbcTO8K8po0z9Z5c1b3UDwsP8rRs36bKPiVx5owjnuflWfIaxpYAqFSCukV6AQs= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd58b1d3-d494-41cd-06e8-08db93479845 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 10:59:51.8461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZUD5AkXuR7pkPdJONM5T2gvofUwlj58eelciXI6OXQVMWyFbxJxj9d0x2S2D+AD0+0po4iLadltk5JmPJk9MIebiqP9hXUW+zfQj+ipK+uc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6475 On 02/08/2023 10:43 am, Jan Beulich wrote: > Structures or unions without any named members aren't liked by Misra > (nor the C standard). Avoid emitting such for leaves without any known > bits. > > At this occasion also add the script to the X86 section in ./MAINTAINERS. > > Signed-off-by: Jan Beulich > > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -601,6 +601,7 @@ F: xen/arch/x86/ > F: xen/include/public/arch-x86/ > F: xen/include/xen/lib/x86 > F: xen/lib/x86 > +F: xen/tools/gen-cpuid.py > F: tools/firmware/hvmloader/ > F: tools/firmware/rombios/ > F: tools/firmware/vgabios/ > --- a/xen/tools/gen-cpuid.py > +++ b/xen/tools/gen-cpuid.py > @@ -367,6 +367,7 @@ def crunch_numbers(state): > for word in range(state.nr_entries): > > names = [] > + empty = 1 > for bit in range(32): > > name = state.names.get(word * 32 + bit, "") > @@ -380,9 +381,15 @@ def crunch_numbers(state): > if name in ("APIC", "OSXSAVE", "OSPKE"): > name = "" > > + if name: > + empty = 0 > + > names.append(name.lower()) > > - state.bitfields.append("bool " + ":1, ".join(names) + ":1") > + if empty: > + state.bitfields.append("unsigned int empty_" + str(word) + ":32") > + else: > + state.bitfields.append("bool " + ":1, ".join(names) + ":1") There's no need for the extra empty variable (this is python, not C). if any(names):     state.bitfields.append("bool " + ":1, ".join(names) + ":1") else:     state.bitfields.append("uint32_t empty_%s" % (word, )) But there's a related bug later in the script which MISRA won't notice unless it happens to run on the cset boundary introducing a new leaf. I'll see about doing a patch to address both. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 02 11:01:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 11:01:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574876.900504 (Exim 4.92) (envelope-from ) id 1qR9bm-0004lW-Tn; Wed, 02 Aug 2023 11:01:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574876.900504; Wed, 02 Aug 2023 11:01:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9bm-0004lP-R1; Wed, 02 Aug 2023 11:01:38 +0000 Received: by outflank-mailman (input) for mailman id 574876; Wed, 02 Aug 2023 11:01:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9bl-0004lH-VU for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 11:01:38 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061b.outbound.protection.outlook.com [2a01:111:f400:fe02::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2cb66d2-3123-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 13:01:36 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VE1PR04MB7342.eurprd04.prod.outlook.com (2603:10a6:800:1a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 11:01:32 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 11:01:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2cb66d2-3123-11ee-b25f-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/VRk1PHO9C5sYd+LDcuc007V4W0AuR522r5spzO1v4EloEFrMMqfZku9wzblOvUg6LHa6hbXkMElf+pxxzaL2Q8RXt3GvjTQh2mQOtREm8+3i5BpUuAmnJ5AZ4g2NcpFyQn3SeGLi6L1Rk4CbJjniT+ZgpJYeg3T8wEtvDVQAQhSYKfMVZavUS5t6+o5Ph+BoMmKwWz/dyVlqBmgj6++N+NvyzlshCboOlnZs78EaveokO7MtQqgBeww6xOVBqH7yi17Ho96jvrmlcDIuIfdhDGtxYbY7U1SRV6W23TZKw2dITgLAUz4HgG+R8U7t0Q13h8yhBzc04u1RF6TEU8lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fdh5TOzTgAphRoEI55SIoaVipyL6Mk5004Y1GLqMc8E=; b=A34yWaBP7MT4+F4MDlYvxLnyqy1cCj9N8RvHauaZAqESOOLmZGydbh19Z7i30pAAqsu280D4KEUKJhCWmyIGf/wHtv8MUzL7h9FW5w7QSh8Ldr7c/KQOxEF/LYG3ZiEPgosM/XWVkEQW+WhoUWqyHHo/ETqkpQi6XqovjHWce+zNCaq6cOj9snRivy1MJsDXs7gt8ZInkUicQfhKs12bQ2+YNSVapSxj2JqDM3wz0WhZdhpFOY68h6YG8Mqr1DHkXxJ9biLPSkE5TTCSu9BPirYUqYlhhL0+M4amRu5hXfJMdcEZKeFM5L6uvheueZdMDFBMuIQGHo1B2nLhmKMCJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fdh5TOzTgAphRoEI55SIoaVipyL6Mk5004Y1GLqMc8E=; b=gspky/Lilw5kVsHZVub/qnHoAvR2IHpjQa7DixAd1dgKjiWMJXcu2aHuWk3Bn5qkn8jsLlsZJ8ymhqS7ksNoZ6szoHPpnBxw3ipBF3BlRCVSbaZjXj2nqTj2eRaLHUY2zzVPnhcIDCuHjED1T84yqVnQLoS7Vd2bVa7ddbVXWgrJX/qWKZ3R3kq1We14BO6RJOUG/MtjmAduKo9MVqwgjX2G0zGn5mPPaeB2673iNeabGDbpDUotiz0dQW12N2yriT0uci9FBvGi+iz90IBtbdQIpo2zEfjtOhiZVbHLFz5l0Yh5r3rjFJpHpZYuwKdvyujEtg/FfwDU1DkVrTkp0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> Date: Wed, 2 Aug 2023 13:01:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: "Daniel P. Smith" Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801160608.19219-1-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VE1PR04MB7342:EE_ X-MS-Office365-Filtering-Correlation-Id: bd09ca9d-5243-4b65-88e5-08db9347d48e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yuzgaeL9XaVHpGz1BL7Rs8Y+HhjkT4Rd/T2wuqXwuoL+NRQb/I30qTaiML3ct58n0ktxfGw8gUb4cjAxItZBjEw32kD+5J45mwKOmMVg6d08WToqaTwkGlx0uruZzg3iqMEUrE1u2psm3adkUZOXyD0hyCxIbiGDnfgB13ldx6R/0ndpxRyETTqrE+lACXWM2x83zTf4uy3PRLQZTX3FeOZ210hQA56PaF9wP02BFLWtMj3LCpBQBWrbjyVRgK76DvaR612y92SKeyocBq2zyxuJH6YhwC0jpQxJl2RqyUX4JoKkNc12aBw48O2Sva622jP8qL5UDyQ0/0i9tSb2ja5pB6sAojFZdFCwZmpMhObok7g03LELjQSK4zhY3ZccxSFj99TBx+AXyOS68n+kOD/5UgmQzZVkWbFoqgLTpkH1wC5BjFfGM1qIqCYKAT9/HCI/H80+mV3djmXq5whsJVXefP7xbKYXi2d3xD1f0v9J/voJLS/NAwDE6q8654au3EUhGB6wehMvNS0qBl9PDGs02ShfDUkF+z3BXSPBSdInSrVdIlLSazC5U4dKn64sM83yHU59/PHXt2DOfABBnGsPgxNa5xlzz01zFrhQ1ENjfPhXCthhBadguNfzJ3kdLwb4Ma46lKnUKw6EvKCBNg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(39850400004)(366004)(136003)(396003)(451199021)(478600001)(86362001)(31696002)(6512007)(36756003)(6666004)(6486002)(316002)(8676002)(8936002)(41300700001)(5660300002)(31686004)(6916009)(4326008)(66556008)(66476007)(83380400001)(7416002)(54906003)(2906002)(38100700002)(66946007)(26005)(2616005)(186003)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mmlhcnd2VGJzdUlLTEE3eFdkVVRMbUpKaUQyZzBkdzY4VTBhcW5GL0hrZFBM?= =?utf-8?B?dUhZdERidEFrT2JCYytvbEsxMDJTYll5VENmZjVSRkh2RzBsWUpWNkRVcmlB?= =?utf-8?B?NDFTd0pmWlEzcFEvZ3VOWEVQcDExZFBYVEVyMjJWSmN2R1M0Z1lwbzhpQ25W?= =?utf-8?B?ZzM2Mjd1cVhVSEdUWXZoVHhMQUNyWUZEakovWkVWbGl5S1lLcFVGSFZzSHdN?= =?utf-8?B?ckhQZzYwbUJjaTdiRktWL016S05idFdNcDg4U3lycGlIeHFSRnZxYnpVZ2dT?= =?utf-8?B?eXpPbkdtTmFYTGJwYUlkWTJPRGpBdnVXZTZDMGJlL3UvTkxXdkVBMURvWXY4?= =?utf-8?B?Y3d6dTZ1QTBvWVE3Z0lMa2xEZ0hMdEVUSjFRQmtBNGhOQXhneEZwSnBWODJC?= =?utf-8?B?Z1dwdTNOdkwycGFDQzNXZGFBaUJxTlNweEpoaEkrTGQ2NEM2QkMyRmJZRUNE?= =?utf-8?B?RUc0UHJ4UnBjc1VFN0ZuYnBwSXJNQ0MyOVUrSDdUbk5nVEhYR055Vk1jRzE5?= =?utf-8?B?VWNtTGxabThOcDJlN2RUS3pSVEp1eWc4Tk0xMzhTMDByUVZ6dnF2QSt5dnZK?= =?utf-8?B?SS9sTmMwcTNuS2RZUWMzYlVzMjRxM0pjdGlpWStaOXk3ejZ1Zk03bC9JT011?= =?utf-8?B?Z3lLbFlmYXFydEhFbmFVQU9Yb0c2ZUsvMGVvRmZoeXcrOWp0VTVUVnlmQ1Bz?= =?utf-8?B?b245bE1yU0NBS0dKZ0pnMm1zTnBta2Q0bWVBNHJxOFlURGEybXB2R1lqUUdD?= =?utf-8?B?THNRKzViSEJRNm0ra3piemlOSU03dXN1VnhnV0pyTTQweTlZaVFJUGszOTd3?= =?utf-8?B?cW01aE9zcGl2OHFjNWdCSEZIUVJENFdib0ZFS3dTek12Vk5QSEtyS0p6LzVJ?= =?utf-8?B?U20zZllFY3BPeUo4QXloMXl6Ny9YYjhHc0NiTXJSenNwVmhSbnZXdklScGdh?= =?utf-8?B?ZTNpVis1MXl5NFRjWm5wQTVJaXBTQmlVQW1kb0RXRU1Rc0QzaDlqOEc5VjZa?= =?utf-8?B?WVhWNDRxTlZSWFFUWks2cUIrbVVlT2xiRzUzV2JiNER6QWc0WTZKU0NacTc4?= =?utf-8?B?OEZEUzI0anE5R0FDMkVHL2EydktrOVRpQWdTSTVoanliOVJESHEzZ0hHMU12?= =?utf-8?B?WDQzdUpmYjB0dFF2SkxmdFRPTURNaDRvaFliVFZDakFURXV3VkZ5bm0zVnl6?= =?utf-8?B?SlRvWWJkUzZ2Q0tFbngvSlFKanpXTkc1MGR4bm9NZDE5dzNZK1ExQjQ5WStT?= =?utf-8?B?dnZ1aFVtME8rT2htSTBMbXF4L0hQaHRkOHRFN1hOTmNNZlN6R3ZDZ2s5Ujdv?= =?utf-8?B?Nm05QlpwMmtrTVo1Z1FPbHVZRGFKRWJiRDZabVJ2N1FFNGFValNQeUwzU1BW?= =?utf-8?B?NklaRVduRUIzZ0lKQUl2WndyOFhRUHlBaGJXbm15MnNNQ3h4YnUrTTF3RlFD?= =?utf-8?B?VG10NVc4Y2RtRys5ZzMvejZlSG5tajBCbTltOFFnTzdnbi9RNFdEMlB4ZFhC?= =?utf-8?B?MnBVTUc1NkcyOFYxSWlGUWxGNGNqYjZPZFBLVXdYRTVydmxDcW03U1JBV0x0?= =?utf-8?B?SytLV1JZbWFxMGtuQS9NVzl2NW1oWHhuSmwvWHNmelhwUFFDZDNVbEMvQ0NY?= =?utf-8?B?YVlZTGJqUEM0a3kwTnFmdmNweHV3enNSZGlialNEVThmQnc3MGJSM0EvdjVM?= =?utf-8?B?Zi9pRFF5YWI5RFVXcUY3RUQyR2hpKzhOaDR0T1BsV2xNQjNIVk9LaUd1bTZC?= =?utf-8?B?dCtZejdJemN2aFVkejdNQS9pQVdzVlhpMklmS1k1NVdIYzdkL281U212NjJM?= =?utf-8?B?a3VUSjZFVXY5ODFCcHlNazYzMHFOeE9GdHVIeGRDRjV0TWg5ZzNCblN4L2lF?= =?utf-8?B?OWVBTFRlMSs2Qi9RSzByYlplNEh2THpCL29Lc2tyOEw3OFZtV09xUXVkSUx4?= =?utf-8?B?dW8xckxwRGdnc3llTTRMUEFaOXpJZnNDcGt4WmVJMzI5dlhJeGViT3doSlZP?= =?utf-8?B?bDc0cExKMmFobVJaS2tFK2FROGpQOXJodFptRCtYTWZRRDA1SGcyTjg0eVZI?= =?utf-8?B?Qzg0WTRLdUZsU01Ubm5oSisxbExuVy8xSmVmWnBpOHQ1blFENktvTTc2SHdF?= =?utf-8?Q?kEzcPZ9TCndoUPBGwTtZLLkLB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd09ca9d-5243-4b65-88e5-08db9347d48e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 11:01:32.2429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: np+GiwZTC29IJwLLOgS6Rz9GPXS9PW1ZPZo2tqm4dWIK2Ll5SMuHySRDzH5Kox60zPs361H4Pvio5u3vegGkpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7342 On 01.08.2023 18:06, Daniel P. Smith wrote: > This patch reworks the console rotation logic to provide a general mechanism to > incorporate domU in to the rotation. It does so by walking the domain list > using the XSM console privlege check to determine if the domain is given access. > > In reworking the rotation logic, the assumption that the hardware domain is the > first domain created is removed and is changed to explicitly locate the > hardware domain at boot. I guess I'm unable to identify any "at boot only" code. I'm also puzzled by this indicating there is a need to do so, when the global variable "hardware_domain" is available, and you actually use it. > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -473,45 +473,102 @@ static void cf_check dump_console_ring_key(unsigned char key) > */ > static unsigned int __read_mostly console_rx = 0; > > -#define max_console_rx (max_init_domid + 1) > +#define CON_RX_DOMID (console_rx - 1) > > /* Make sure to rcu_unlock_domain after use */ > struct domain *console_input_domain(void) > { > if ( console_rx == 0 ) > return NULL; > - return rcu_lock_domain_by_id(console_rx - 1); > + return rcu_lock_domain_by_id(CON_RX_DOMID); > } > > static void switch_serial_input(void) > { > - unsigned int next_rx = console_rx; > + struct domain *next, *d = console_input_domain(); Looks like "next" cannot be pointer-to-const just because the XSM hooks still aren't properly const-ified. Oh well. > - /* > - * Rotate among Xen, dom0 and boot-time created domUs while skipping > - * switching serial input to non existing domains. > - */ While it would need adjustment, I don't think the comment wants deleting altogether. > - for ( ; ; ) > + if ( d == NULL ) This covers both Xen receiving input and the domain receiving input having gone away. Originally in the latter case the next sequential (in domid numbering) domain would be switched to. In the new logic you start over from the beginning of the domain list. Such a change in behavior (if deemed acceptable at all, which I'm not convinced of) needs calling out in the description. > { > - struct domain *d; > + if ( hardware_domain ) > + { > + console_rx = hardware_domain->domain_id + 1; > + printk("*** Serial input to DOM%d", CON_RX_DOMID); Here and elsewhere - why %d when original code properly used %u? I also think there are now quite a few too many of these all identical printk()s. > + goto out; //print switch_code statement & newline Leftover development comment? (There's at least one more.) > + } > + else Please avoid "else" after an if() that ends in "return", "goto", or alike. > + { > + for_each_domain(next) What guarantees that the list won't change behind your back? You don't hold domlist_read_lock here afaict. It might be that you're safe because that lock is an RCU one and this function is only invoked at init time or from some form of interrupt handler. But that's far from obvious and will hence need both properly confirming and stating in a comment. (It is actually this concern, iirc, which so far had us avoid iterating the domain list here.) > + { > + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) > + { > + console_rx = next->domain_id + 1; > + printk("*** Serial input to DOM%d", CON_RX_DOMID); > + goto out; //print switch_code statement & newline > + } > + } > > - if ( next_rx++ >= max_console_rx ) > + console_rx = 0; > + printk("*** Serial input to Xen"); > + goto out; > + } > + } > + > + for ( next = rcu_dereference(d->next_in_list); next != NULL; > + next = rcu_dereference(next->next_in_list) ) This looks like an open-coded continuation of for_each_domain() - I'm afraid I'm wary of introducing anything like this. > + { > + if ( hardware_domain && next == hardware_domain ) > { > console_rx = 0; > printk("*** Serial input to Xen"); > - break; > + goto out; Since you use "goto" anyway, this wants introducing a 2nd label (maybe "xen"?) ahead of the identical code you add further down (immediately ahead of the "out" label), to avoid code duplication. > } > > - d = rcu_lock_domain_by_id(next_rx - 1); > - if ( d ) > + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) > { > - rcu_unlock_domain(d); > - console_rx = next_rx; > - printk("*** Serial input to DOM%u", next_rx - 1); > - break; > + console_rx = next->domain_id + 1; > + printk("*** Serial input to DOM%d", CON_RX_DOMID); > + goto out; > + } > + } > + > + /* > + * Hit the end of the domain list and instead of assuming that the > + * hardware domain is the first in the list, get the first domain > + * in the domain list and then if it is not the hardware domain or > + * does not have console privilege, iterate the list until we find > + * the hardware domain or a domain with console privilege. > + */ > + if ( next == NULL ) > + { > + for_each_domain(next) > + { > + if ( hardware_domain && next == hardware_domain ) > + { > + console_rx = 0; > + printk("*** Serial input to Xen"); > + goto out; > + } > + > + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) > + { > + console_rx = next->domain_id + 1; > + printk("*** Serial input to DOM%d", CON_RX_DOMID); > + goto out; > + } > } > } > > + /* > + * If we got here, could not find a domain with console io privilege. > + * Default to Xen. > + */ "Default to" is a little odd when there are no other options. > + console_rx = 0; > + printk("*** Serial input to Xen"); > + > +out: Labels indented by at least one blank please. > @@ -520,12 +577,11 @@ static void switch_serial_input(void) > > static void __serial_rx(char c, struct cpu_user_regs *regs) > { > - switch ( console_rx ) > - { > - case 0: > + if ( console_rx == 0 ) By using CON_RX_DOMID everywhere else you try to carefully avoid and open-coded assumptions on the precise biasing used there. With this it would seem to me that here "CON_RX_DOMID > DOMID_MASK" would be more in line with that model then. > return handle_keypress(c, regs); > > - case 1: > + if ( hardware_domain->domain_id == CON_RX_DOMID ) No check of hardware_domain against NULL? > + { > /* > * Deliver input to the hardware domain buffer, unless it is > * already full. > @@ -538,31 +594,37 @@ static void __serial_rx(char c, struct cpu_user_regs *regs) > * getting stuck. > */ > send_global_virq(VIRQ_CONSOLE); > - break; > - > -#ifdef CONFIG_SBSA_VUART_CONSOLE > - default: > + } > + else > { > - struct domain *d = rcu_lock_domain_by_id(console_rx - 1); > + struct domain *d = rcu_lock_domain_by_any_id(CON_RX_DOMID); > > + if ( d == NULL ) > + goto unlock_out; > + > +#ifdef CONFIG_SBSA_VUART_CONSOLE > /* > * If we have a properly initialized vpl011 console for the > * domain, without a full PV ring to Dom0 (in that case input > * comes from the PV ring), then send the character to it. > */ > - if ( d != NULL && > - !d->arch.vpl011.backend_in_domain && > + if ( !d->arch.vpl011.backend_in_domain && > d->arch.vpl011.backend.xen != NULL ) > + { > vpl011_rx_char_xen(d, c); > - else > - printk("Cannot send chars to Dom%d: no UART available\n", > - console_rx - 1); > + goto unlock_out; > + } > +#endif > + > + if ( (serial_rx_prod - serial_rx_cons) != SERIAL_RX_SIZE ) > + serial_rx_ring[SERIAL_RX_MASK(serial_rx_prod++)] = c; This is Dom0's buffer; I don't think sharing with DomU-s is correct. You also cannot ... > @@ -717,6 +779,8 @@ long do_console_io( > rc = -E2BIG; > if ( count > INT_MAX ) > break; > + if ( CON_RX_DOMID != current->domain->domain_id ) > + return 0; > > rc = 0; > while ( (serial_rx_cons != serial_rx_prod) && (rc < count) ) ... assume that by the time this hypercall is invoked input focus hasn't switched. I think there's no way around a per-domain input buffer, which of course would need setting up only for console-io- capable domains. > @@ -1107,7 +1171,7 @@ void __init console_endboot(void) > * a useful 'how to switch' message. > */ > if ( opt_conswitch[1] == 'x' ) > - console_rx = max_console_rx; > + console_rx = 0; I can't bring this change in line with the comment ahead of the if(): Won't this result in switch_serial_input() switching to Dom0? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 11:08:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 11:08:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574884.900515 (Exim 4.92) (envelope-from ) id 1qR9i2-0005To-Ke; Wed, 02 Aug 2023 11:08:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574884.900515; Wed, 02 Aug 2023 11:08:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9i2-0005Th-H9; Wed, 02 Aug 2023 11:08:06 +0000 Received: by outflank-mailman (input) for mailman id 574884; Wed, 02 Aug 2023 11:08:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qR9i1-0005Tb-J8 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 11:08:05 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20618.outbound.protection.outlook.com [2a01:111:f400:fe1a::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9de9540-3124-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 13:08:04 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6873.eurprd04.prod.outlook.com (2603:10a6:10:115::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 11:08:00 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 11:08:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9de9540-3124-11ee-b25f-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+wGWGAb0xlQYkuiDYSH34mxH55RlX5OftpDlPqeSjorco/9PSgz23GbqJqbQr5G8kog9MVCMhb4G93MfOuPmLTYSIvvfILyWJr3oPEXacc1XuVSt5wh0GnsvvXwr+deb09p2gRhIhGRGu2IcE8QVDOMrnR4d2FOW/bwqBw9y3330hk8CXLhUm907ZP9NzbedZRkHZ52Z0zX9vTBSZltYqNQbonAAMC/2dot0kcjERkFyOU6tfLzB6tzekbLsvuxlUo14Vueus8VAxhEQYZwd0RyUjA/PeziEcYP5NO6xoKj7LSAzBvBx9XqYwS1ru0EV/VxCiJuK3LG3bskYlcBqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PplYT8/GebARzSPmiPx58erRYbxhvjke7VWAyczDLiU=; b=XH5408gCISSp20mwTlzSeFDQPQHOwKcA3JUXhoGqCH18V3OTSPSAe5jhVhHKGrC7smZKw+c5Esqj0tbamkZdMDy8cOWkB8K3umS3IgkcBSKDo6vSuyQeOLdsVP/QkEg4+2p/M/UVqo7yhQEqHeJpkCkVbPc7BpYNGnS0eKLe8sUx76zZtMov0QFsJ3ydMjxKW/di0wsA0upwBw2ua0LFgCmTLQTYYdOKeZfA6CZvj4ExKnDnCObFVW4cHrtVE+emAPExsxXIBHGXBXmNSIkt9fBm1OaatgCmIL43lczDdGL0A6GI12SG7TJhDLBUTVJB1l4AMILcfWcE51fD2nwwGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PplYT8/GebARzSPmiPx58erRYbxhvjke7VWAyczDLiU=; b=SOFk/I/H1iA2ErNnnzH/QjS4zjaEtw9ATokiW904427mHgOGQlwq/HPMObQEPtAS+z/ztMVHER8R9+0iYNOG2rvN2ikrjrutps7Mq1yLv+fOavqbHlKm5VbVkZR2kF7IoT3RwA4hfc050tainhUnxSXQ7w2SU381nNk/yyP3mPBaRfdGFetV9CGxRE9WqUuW6q8/Cnqg8DRwAzVByKI8cwzB0R4gaTxonXqdnJdNOS/Jb1nnRN5rMxIR4QF1OEWwzP2WJlSWm9Clsw/8zst/3u0b6UD+3xLmvFtlz+pOMo7mOrdKT8Fh7AW6qVbZSPsYAdpIngdNlkBlLINOgh/xFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20b1d680-d69c-264d-7764-ff2143ded9da@suse.com> Date: Wed, 2 Aug 2023 13:07:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH v2] x86/cpu-policy: justify a violation of MISRA C:2012 Rule 1.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <30fdada8b08b2060c6f1ccc2ecb06d418efd97b0.1690966632.git.nicola.vetrini@bugseng.com> <5ff38731-fed7-91eb-c933-28d191fb429b@suse.com> <796058860d0536799e40fc14f169efd2@bugseng.com> From: Jan Beulich In-Reply-To: <796058860d0536799e40fc14f169efd2@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6873:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c44db7b-7d32-480a-ec45-08db9348bbe6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SnFMXHLgM0MYJS5yrVKEPaHLa0sT423PNIEIhg2biWxQP4wVDvaEfBN3Wvkn2WpaURumRbBN5vlrA1Bigy0YmlLBhae5/YNZXJP1jChlxbxty8gb9BLw60zjWD8DUhy/eO4Y5jBWe1svwySCPVxp//uRr9fe+hC9Pqs1XOkeRxz5NreRe8l4nD7IsNH4QOwT6AttxAuCjekSQ4bNreiFVuJ/0R7wlCLUiAoTz3ngUPNdB+q87Q+giNjiqXA9PthOpfnw1+Xm7ggoTGoBgJgAa/61PTVlbdVL+61s/IEr0u3sVfawJ0CJ6yg5e48dJzFCg8XUyCBK92OUYmxwu6xQXXjyfeMb40WUd7B2/EdfAbCLiET4x935ZVEMc5ybAT8xCn8ucysQZyWRtwUwaMiXSLWtdexqiieSUkoBUBawrzT5mo3YjAMpSVYyuEw6yl7kMD3f1n+5qls2zhyuCGupZOZ/EE6FhOWp38UOKRxXDcgYK28WcanQ4fnkHTp9SUZndtFKvD3L9+2jumSmCteubRBHC4fC/Ccsb3p4M5qG49Go4KpOZAkvvHPEwdZwulgvkD9gCghRyGxy37jI6fkrmaXmBJI9uOhAyssfW29KYLJczTLw+l09Q1ws7LSwRqSR78ird+XfA4ckiNEsTJFSFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199021)(8936002)(8676002)(5660300002)(26005)(41300700001)(2906002)(31686004)(7416002)(36756003)(2616005)(478600001)(54906003)(38100700002)(316002)(86362001)(6506007)(53546011)(6486002)(66946007)(66556008)(66476007)(31696002)(4326008)(6916009)(186003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzhBeFFzSkN3anNkL1R3eGMwMWJEM2c3SDZmQUF1elpIcTEzWk1GN3EyTXpr?= =?utf-8?B?S0hrWkxUUW1pc2ZJY3NWbjNVT0ExemkrRXR2Z21mbThnQjMxZVJhcXkxSFJq?= =?utf-8?B?K3Z3UDVwaXpwVG45TUFzY29CT0hJRXJicE93UFBHclpnWHowNVI3Y0xodGhM?= =?utf-8?B?bmMwMXVKUkxGc01xeHZsS1hVT0pGOENLT1U0Zkt0aFdRRXRZMmg0SElVazdM?= =?utf-8?B?QlgramIvOHlkMVhYQkJNZlRtaWNVS2Mxd3gxanBVdytncXkrNnRkdmtLYm5u?= =?utf-8?B?T1Vna21JN1BkbEJucFZSK0dIYkNuSWZYK3JNRGl1djZkYk9nVk1ieDZXRXlI?= =?utf-8?B?UEhZS1RkRXhHSitwUVpvUU11eWE0NGd5c2k3cFl5eTg2SjlQbk1kaVBWelFN?= =?utf-8?B?N1RLYjl1cGtPWmhCYkhaS1dYZnB3WE1hR21NYll1d1l1TSthUE1EZ3l0ZHlm?= =?utf-8?B?Y25paG9ieUUwa0V6N0xOTTVpN3lNc2d3UVNSTGkrTlhLalh6V0laRWR5dUVl?= =?utf-8?B?cjB6MHFmaERjbWZyRE1DZGROQi9ONHpLOEdSR2ZEcWdOUnJGS1ZTY0QxQ1Yx?= =?utf-8?B?SUhGUngxZlpnTVNua1RPaWwwQkhOejAzR0xGOUxBZDkvY2tXK0Z2VXNLT3Ux?= =?utf-8?B?dUxnbERJVG9OYzF6SFVrdHJpUnExWUxCR2Z3Z1RsWDZxNExpc3ViblpiQjUv?= =?utf-8?B?RzVRc3RZYmJZWFJwbHJ2eWNGb3dhV1FUNkVLUGk4K05HeXhaL0FXWU9PQ2Zr?= =?utf-8?B?L1ExS3NlZmxMLzgvcndtNHdFZXRsUTVnU1lVTWRUcFRPOWx4V0RxUlVXMkFq?= =?utf-8?B?Y0V6RThYMDZ0N3h6YU9BNzZ0Y0dDYzJJSmVqVEFEeDVPL05qZlA5MjVUdEZV?= =?utf-8?B?Vll6M3F1ZGNWK2VvZzZsUUZFUStFanV6eXJrWWNLTDRZU3prS3NCaFhQbGNS?= =?utf-8?B?UkpScSs2bVJZYlVwNnRiSGdHSm8xTnRNU0FEeDRodGFUT3FpZm1rY0tUKzZT?= =?utf-8?B?NWt5RW5wV0JMamo0VnJES1llSytyb1lybWpBYmI2bnAzK0MvdGZRdEhwZ2VC?= =?utf-8?B?bzAzNThMc3QyK1FYODRqQzFUeVBtNkZPVk9IbXE0UjVZTFdEMzUweGJGMlNv?= =?utf-8?B?L0Y2T0ZMS3dBNk9jUytlRE1ualBKcW52LzNSYjdHRWtYOVkwWS9NUDFhQ2xx?= =?utf-8?B?U3RhL3lhenNFUVd4cngyZzZEd1hyS3lIbWhNRURVWlZwNHZ1L3hHV0lCejdj?= =?utf-8?B?MlBzbW1qV24zRXBHMXFlSlhMOG9xdlk3NEYvRDR3dGlZY3FCWDlJSVVnTFBx?= =?utf-8?B?MnZ2N1JXd0ZpR1NsVjNpN1ZVZ25ZSHlyZ0dpTFJnMjlnUDZrbVhsdlh0dlc0?= =?utf-8?B?R0RaclVlY3dKaWU2TkJlNWxUbEt2N2lyWXhacFlvUENraVBybm5oZHYvdkFh?= =?utf-8?B?QXhCV0FPWVIvVDJQdEQyNEptNkVjVTVJaThjRGlXTlVxMzYyT1FDUXBhU3VP?= =?utf-8?B?cTB6ckgzdzM1cm5VVnlVMHlWZ1lGTVhhcU5iRU5oMVZ6VGY5Q0hDclZud1RB?= =?utf-8?B?R2hYNnY3WHI1WnNDOCs3cEFjSm9zc1dFUkxRRVMxTDloYnZLRm0wQ0NlZzRz?= =?utf-8?B?R2pGYWRqeTFHVzRKOXlUMnlqTTNZdGw5cEdiZjE1OUJwV1lobk9VYi9mVzkw?= =?utf-8?B?M09rb3pTTTkrWEJIdGlWSlR3aThvWXZVdkJNTTM0UWczWS8wdklhYjJ6RXlk?= =?utf-8?B?WmhkV1A0cXoyVVhsV0c5eDdWQnZGejZVRkpTTVJ2N0p6dC9KazJRVUZuc3BB?= =?utf-8?B?WDBQUUhhL0R5SGZuM0hSWXcrckxsSU1GL2VtbDQwb3ZnVGVPai9rWUFtOEJj?= =?utf-8?B?aXRPNWwvcVhvN0RmMU9BcVhGVTNoSjk5TWlhV21oeXJ2bm9oY2dnRXE5UjlH?= =?utf-8?B?VGNIQmtBTUl0eW9TYVN4cmhENHFjTGJYZHAyVVhEWXJFdU9SSzA1YTY0WnJa?= =?utf-8?B?S1k4U2tHVEo0QlRyN0ZrZjdDUlZqTktpWWN5YXUwQzF0MzlmT3JZR3o0UDF4?= =?utf-8?B?RkQ4YWp6YWh3RG9uc0RkV0dleDZkbkxtZzRoREd0b25ESG82ajFqcHRZK3pq?= =?utf-8?Q?KLe9p486lfQ6x+e9SCyo9uoZn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c44db7b-7d32-480a-ec45-08db9348bbe6 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 11:08:00.4114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fiHqRIKho245qKADx6ZYHh6FzbgrjOax9nkn/H7eZfHI5MWdmr/iADdSGgZ981DKr1KPQsbi9oHzu/xe1L7ayg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6873 On 02.08.2023 12:01, Nicola Vetrini wrote: > On 02/08/2023 11:47, Jan Beulich wrote: >> On 02.08.2023 10:57, Nicola Vetrini wrote: >>> The empty feature set 'str_7c1' in 'tools/misc/xen-cpuid.c' causes the >>> struct declaration to have no named members, hence violating >>> Rule 1.3: >>> "There shall be no occurrence of undefined or critical unspecified >>> behaviour" >>> because it is forbidden by ISO/IEC 9899:1999(E), Section 6.7.2.1.7: >>> "If the struct-declaration-list contains no named >>> members, the behavior is undefined." >>> >>> Given that Xen is using an undocumented GCC extension that specifies >>> the >>> behaviour upon defining a struct with no named member, this construct >>> is >>> well-defined and thus it is marked as safe. >> >> Especially after realizing that I was wrong here (I was under the wrong >> impression that we'd generate a struct without members, when it's one >> without named members, yet [to me at least] only the former is a known >> gcc extension we use), I've sent an alternative proposal. Let's see >> whether in particular Andrew considers this acceptable. >> > > Well, I don't know the exact discussion on this in that MISRA meeting > (25/07 iirc), > but the outcome I'm aware of was to deviate that construct because there > are possibly > others like that in other configurations/future patches. Correct. The goal wants to be to allow for such future changes in as seamless a manner as possible. By tweaking the script generating these struct fields, we can eliminate the present instance and avoid any future instances showing up, and we also won't need to remember to add SAF-* comments at any point in time. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 11:34:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 11:34:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574889.900524 (Exim 4.92) (envelope-from ) id 1qRA7s-0000Q8-LS; Wed, 02 Aug 2023 11:34:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574889.900524; Wed, 02 Aug 2023 11:34:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRA7s-0000Q1-Il; Wed, 02 Aug 2023 11:34:48 +0000 Received: by outflank-mailman (input) for mailman id 574889; Wed, 02 Aug 2023 11:34:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRA7r-0000Pr-CE; Wed, 02 Aug 2023 11:34:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRA7r-0008QH-6c; Wed, 02 Aug 2023 11:34:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRA7q-0006dc-Qs; Wed, 02 Aug 2023 11:34:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRA7q-0002Z9-QR; Wed, 02 Aug 2023 11:34:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M6wi6lRmvRloNOiX4+aHsjkWldqozMeMShXY12YsCn4=; b=m89U+LpvcyECGlQwUO91sLU/JX tiXESDLi+1mh4vcYBt74zeJETZa6e9xEjXWO8sGIQGC+J88KzQyGnvVsFtb8LwmHCTWk6MEdjO9zy JramaScDIwjciQ05IUgq6sUb5u6cTkzdeF7gafuw4bsy+W1Ju/x77emi/8MEoIXwfTO4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182111: all pass - PUSHED X-Osstest-Versions-This: ovmf=5cadb8ce2148979b6c464f6da5a8cd97425c5165 X-Osstest-Versions-That: ovmf=d11968fcc56cbbffef7d906048b00faea9415447 From: osstest service owner Date: Wed, 02 Aug 2023 11:34:46 +0000 flight 182111 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182111/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5cadb8ce2148979b6c464f6da5a8cd97425c5165 baseline version: ovmf d11968fcc56cbbffef7d906048b00faea9415447 Last test of basis 182108 2023-08-02 03:40:51 Z 0 days Testing same since 182111 2023-08-02 08:42:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Joey Vagedes Joey Vagedes jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d11968fcc5..5cadb8ce21 5cadb8ce2148979b6c464f6da5a8cd97425c5165 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Aug 02 11:45:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 11:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574896.900535 (Exim 4.92) (envelope-from ) id 1qRAIB-00020L-KV; Wed, 02 Aug 2023 11:45:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574896.900535; Wed, 02 Aug 2023 11:45:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRAIB-00020E-HK; Wed, 02 Aug 2023 11:45:27 +0000 Received: by outflank-mailman (input) for mailman id 574896; Wed, 02 Aug 2023 11:45:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRAIA-000203-Dn; Wed, 02 Aug 2023 11:45:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRAIA-000095-Bu; Wed, 02 Aug 2023 11:45:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRAIA-0007Gy-20; Wed, 02 Aug 2023 11:45:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRAIA-0005ZV-1W; Wed, 02 Aug 2023 11:45:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UUHwm1+gXd4q0XKKsNHGbmq8CYJZkFmoI6dxZ7jR3MQ=; b=tmx2vS8w75C8fCIXYHdJIFo0WJ yTvHZS1y+vpndPQq8I+osaSa+pi3OcEMt6rTH+P4kB51NqaUquGS2vQKaFJODNGpyKAuG+Z48ryZn E6Ro3aQRm43dVSd4OjP9caD5rVYRFfH2PnlYTY84UkHUv3ZlCdOlitTV+HGnaq4THsmI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182112: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=51588938e0cd0e02dbc1d6d8c697c577135ff666 X-Osstest-Versions-That: xen=c2026b88b58cbb6a84e2885c320a8cfe08f8ffc8 From: osstest service owner Date: Wed, 02 Aug 2023 11:45:26 +0000 flight 182112 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182112/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 51588938e0cd0e02dbc1d6d8c697c577135ff666 baseline version: xen c2026b88b58cbb6a84e2885c320a8cfe08f8ffc8 Last test of basis 182100 2023-08-01 10:03:51 Z 1 days Testing same since 182112 2023-08-02 09:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Federico Serafini Jan Beulich Nicola Vetrini Shawn Anastasio jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c2026b88b5..51588938e0 51588938e0cd0e02dbc1d6d8c697c577135ff666 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 02 13:10:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 13:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574927.900550 (Exim 4.92) (envelope-from ) id 1qRBcW-00033J-46; Wed, 02 Aug 2023 13:10:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574927.900550; Wed, 02 Aug 2023 13:10:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBcW-00033C-1P; Wed, 02 Aug 2023 13:10:32 +0000 Received: by outflank-mailman (input) for mailman id 574927; Wed, 02 Aug 2023 13:10:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBcU-000331-RH for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 13:10:31 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2d6ea2d-3135-11ee-b25f-6b7b168915f2; Wed, 02 Aug 2023 15:10:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2d6ea2d-3135-11ee-b25f-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1690981828; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pN+ikulm61CRL3YUYcg8p+iLYA0x8CIURTvBSYwIGuQ=; b=GkK7mVBSq2u6IEJqziNio0zFX9sY2bQrOS+aPxQVwxtLtufrx6SM5cTe yLnv57sr08mnrN8IDy1KipyjWj0AKNTI7Q/m9CEKVfSr3cAizEnxXN+Uw sfadLEWuNIJ/EUEFAYtwz6DjwX3LxuIZAvunqcBO/9iXDa6Ewg7yBVhca c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 120889552 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:kdUL3K0nU1Q7GZNya/bD5cxxkn2cJEfYwER7XKvMYLTBsI5bpzwGm DAWWjuFbP2LamDzetkiPI6/oB4BuZeEyNUxGwtlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8XuDgNyo4GlD5gxmP6gS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfQkJF0 NAVCj02Qy+8htCUn4qJdvMvv5F2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiHJ8NzhbJ+ z+cl4j/KiMCM9Cw9QWiy2ClrKyfjD72aak0SrLto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwAsUTppeNEg8sgsSlQC0 F6CmNfgQyJirKeUT3O1/Kqbtj60Nm4eKmpqWMMfZVJbuZ+5+th110+RCI85S8ZZk+EZBxmz4 DuvgCUcio4+svEK5YfkxWL7mXGV882hohEO2unHYo60xlonNdb0Ptb0sQCzAeVod9jAEATY1 JQQs43Htb1VU8nQ/MCYaL9VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX aMyhe+yzMUJVJdSRfUrC79d8uxzpUQaKfzrV+rPcv1FaYVreQmM8UlGPBDBhzG0zBh9wPBmY P93lPpA6l5DWMxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+W3oH yJkH5LSkX13CbSuChQ7BKZPdTjm21BnX8GpwyGWH8bfSjdb9JYJVqeNmuh+INM790mX/8+Rl kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:54CkdK6zOTmgfuTqCwPXwUGBI+orL9Y04lQ7vn2ZESYlCvBxl6 iV/MjzpiWEygr5OUtQ3OxoXZPqfZqyz+8Q3WB8B9mftUzdyRKVxeJZnPzfKl/bakrDH4dmvM 8LH8dD4Z/LfD5HZK3BkWqF+qMbsby6GdeT9IXjJhlWLD2DxspbgjtRO0K+KAlbVQNGDZ02GN 63/cxcvQetfnwRc4CSGmQFd/KrnayDqLvWJTo9QzI34giHij2lrJTgFQKD4xsYWzRThZ8/7G n+lRDj7KnLiYDy9vac7R6Z031loqqt9jJxPr3BtiHTEESitu+cXvUqZ1RFhkF6nAjg0idqrD CGmWZaAy060QKqQokzyiGdmDUJBF0Vmj/fIBmj8A3eiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfGH9dQnGlqj1vitR5zmJiGtnlfRWg21UUIMYZrMUpYsD/FlNGJNFGC7h8ogoHO RnEcmZvZ9tACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39F/pMgTJtP4f jCL81T5cRzZ95Tabg4CPYKQMOxBGCISRXQMHiKKVCiD60DM2Klke+H3Fz03pDVRHUl9upMpH 2aaiIkiYcbQTOTNfGz X-Talos-CUID: 9a23:elNd/2yW2z7EziqLijI5BgVXOcsAXnD/wUz9HHC5O0Q2cI+pUxyprfY= X-Talos-MUID: =?us-ascii?q?9a23=3AGea6gQxldMitsp1cmVbUITasMnOaqJa2D0wirao?= =?us-ascii?q?hgtuNH28gKiqQvR+RHIByfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,249,1684814400"; d="scan'208";a="120889552" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Nicola Vetrini Subject: [PATCH v2] x86/gen-cpuid: Avoid violations of Misra rule 1.3 Date: Wed, 2 Aug 2023 14:10:03 +0100 Message-ID: <20230802131003.166670-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add the script to the X86 section in ./MAINTAINERS. Structures or unions without any named members aren't liked by Misra (nor the C standard). Avoid emitting such for leaves without any known bits. The placeholders are affected similarly, but are only visible to MISRA in the middle of a patch series adding a new leaf. The absence of a name was intentional as these defines need to not duplicate names. As that's not deemed acceptable any more, move placeholder processing into the main loop and append the the word number to generate unique names. $ diff cpuid-autogen-{before,after}.h @@ -1034,7 +1034,7 @@ bool intel_psfd:1, ipred_ctrl:1, rrsba_ctrl:1, ddp_ctrl:1, ... #define CPUID_BITFIELD_14 \ - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... + uint32_t _placeholder_14 #define CPUID_BITFIELD_15 \ bool :1, :1, :1, :1, avx_vnni_int8:1, avx_ne_convert:1, :1, ... @@ -1043,19 +1043,19 @@ bool rdcl_no:1, eibrs:1, rsba:1, skip_l1dfl:1, intel_ssb_no:1, ... #define CPUID_BITFIELD_17 \ - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... + uint32_t _placeholder_17 #define CPUID_BITFIELD_18 \ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_18 #define CPUID_BITFIELD_19 \ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_19 #define CPUID_BITFIELD_20 \ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_20 #define CPUID_BITFIELD_21 \ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_21 #endif /* __XEN_X86__FEATURESET_DATA__ */ No functional change. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau MonnĂ© CC: Wei Liu CC: Nicola Vetrini v2: * Write it more pythonically. Fix up the placeholders too. --- MAINTAINERS | 1 + xen/tools/gen-cpuid.py | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d8a02a6c1918..a0805d35cd71 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -601,6 +601,7 @@ F: xen/arch/x86/ F: xen/include/public/arch-x86/ F: xen/include/xen/lib/x86 F: xen/lib/x86 +F: xen/tools/gen-cpuid.py F: tools/firmware/hvmloader/ F: tools/firmware/rombios/ F: tools/firmware/vgabios/ diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py index 72cf11654ba9..5797bc64c803 100755 --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -363,8 +363,8 @@ def crunch_numbers(state): state.deep_features = deps.keys() state.nr_deep_deps = len(state.deep_deps.keys()) - # Calculate the bitfield name declarations - for word in range(state.nr_entries): + # Calculate the bitfield name declarations. Leave 4 placeholders on the end + for word in range(state.nr_entries + 4): names = [] for bit in range(32): @@ -382,7 +382,10 @@ def crunch_numbers(state): names.append(name.lower()) - state.bitfields.append("bool " + ":1, ".join(names) + ":1") + if any(names): + state.bitfields.append("bool " + ":1, ".join(names) + ":1") + else: + state.bitfields.append("uint32_t _placeholder_%s" % (word, )) def write_results(state): @@ -464,8 +467,6 @@ def write_results(state): """) - state.bitfields += ["uint32_t :32 /* placeholder */"] * 4 - for idx, text in enumerate(state.bitfields): state.output.write( "#define CPUID_BITFIELD_%d \\\n %s\n\n" base-commit: 51588938e0cd0e02dbc1d6d8c697c577135ff666 -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 13:22:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 13:22:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574932.900561 (Exim 4.92) (envelope-from ) id 1qRBoI-0004ZI-7r; Wed, 02 Aug 2023 13:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574932.900561; Wed, 02 Aug 2023 13:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBoI-0004ZB-3o; Wed, 02 Aug 2023 13:22:42 +0000 Received: by outflank-mailman (input) for mailman id 574932; Wed, 02 Aug 2023 13:22:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBoH-0004Z5-F0 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 13:22:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0615.outbound.protection.outlook.com [2a01:111:f400:fe0e::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6c8ee88-3137-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 15:22:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM7PR04MB7142.eurprd04.prod.outlook.com (2603:10a6:20b:113::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 13:22:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 13:22:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6c8ee88-3137-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jm1YgyxlQXaBelA7xtGyiHhb5UasncN8CiQYoyH+w6pPh7NvHsj0m5FlQGGKimlTWiszdV3d7OeI9xcr3yoBwHoljLyuTSTIwZCfsAdgm65cdSADIi7a3oM5liIOPh+MJM80zI/5CGoT+yuG6K22rThSa+6Mh2iQL9jjZ68/1FVsWXo91UgsvRahMq3O93dzGVxXE3J/jaqj8TLl7Az8CpKy7zjD3TbUZw3XckrYybBmB2Nx3MoO7UMrbCY9MNzXh95tnhB32acTcMD4SP/Qbw6o8vMKraX2DJYIExzlCR1w9ERf3NHM2QHJNKgUiyvQUIueL7dss+YXOgkUhNyy8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jbmkM94i4Y6Kbqbs5bDYN11RQAXqd8uCacxrc9BCgyM=; b=OEQ5FCdm1TZkUyQ/NLvgg2EJzIzN1GK+Q0stU7tcqaRLIB5XmMmR3ZPas8Vm6y36X1AOBQccoRmvvsqZ5qfqDIKNmzziuP1xnNiRNbK45yJ1CTlkf478gW15+U0bFFSb8d05rIPx7OQgvPwD+Uua1LxS37jMJn55OLLHfE4CUlJ9eDZAUkZ1rby5XseAX7FlTsZL8AoXhQQnIrxsPEHKpHh7YMXjTyqUACLawo+5TL7eu7wUipGSUKuQ6XAHtU/HJX+cSoxGz/NJItHhie2tu1vsx/UirjO4Lp+ISigWYyaPTsQfXylzO0KBCTaSVGsx2bgLNmPyf8TtIYfHwLdzrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jbmkM94i4Y6Kbqbs5bDYN11RQAXqd8uCacxrc9BCgyM=; b=2j7b4uhw0gPzdn34tbymYTzSEPFMlSgf0/qjRL5CV72zlEsGHGQpFbJz5SvESSLkG1zZ0unBQvrmPvPqF82cHiq4OtnO9dpV62xZGtzPQ8EJk29fDPavC20wJvaqiWWIDnDQvfBZdaCBK036ba4nW8vs81qBHkOVpNDR7rVmayfrnlnlBwQnOYrHdb4qbXbbMxObcXLFK2EEsVlCpP1FQMB04ahR5hY7Qi9hxG22lLNtEUOxQcTJuIvRJf+ZmLCPxK3YGw1GaavCNkbD/AhsLqgdG8MtBQ7wKfQk//0qLuVDJ66Vir9w5lxPIRRWJC04re6bnl26o+8Ho/Tpw2t4MQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 2 Aug 2023 15:22:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2] x86/gen-cpuid: Avoid violations of Misra rule 1.3 Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Nicola Vetrini , Xen-devel References: <20230802131003.166670-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230802131003.166670-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0191.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM7PR04MB7142:EE_ X-MS-Office365-Filtering-Correlation-Id: d188a132-a21e-4ef2-e077-08db935b8949 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H5utEMK/HmmPYZbUuZJXoGU6S8xqzBn+7z7F/w8sRlacO39zIrO7EnpN5MzlYsZcB86m8iyUcqtfuKj62ipqN4Ve9qIjEhBRadFvsGSZO7I+TsALZDT2kF+iacS2IR+UON1GCuGWwJ5r/xOc735xxWrDhm5Ky7rGsIdDrbNcEld9BdFsajW0PE3vl+UfNLUGHsyKCkeg/kF1xvhW8O1IsiHXSXc1BhQ99/lRN9EKHUm6EJjHKZ9nabW4hxxhgxf1FpcP0EDJ0IBmMPoWtvEMdLWoLaKJs2oAyRMfYTyQnPs6nY0gs0LkNm+BZWhBDDH8Nh9wvCMx/6XE0TRbzxZ8x3Mw2ljeZlIVolDNRZ4Rt5CJhYam53MffphV/phk2dW3I5ZLVS3xi9FikfsmVmYLJBVQ6FcerXTkk4g31VjmP9CZN+SM9JFWFH409y/0zjKfal9aYg7qp5GpjCYWOlSR4NaJoYAsuIdMdU/NofhsFePno5Fx7GSvAdLTCMopY3+KSJm/ZOBYHH0ERVgBhDZ+eqntuRrG031aozm2OrKXePcc8Hx4RGVPOccOnqtGsUKKi0AnW7vuH5sjkT4dh+78Qm8TKvZ9uvamddjfAXMS8oLpvveUORWG0ypJVLoAgG8qDU4WtumVSzI2HNR30Fm7HA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(396003)(136003)(376002)(39860400002)(451199021)(31686004)(2616005)(26005)(6506007)(36756003)(38100700002)(54906003)(186003)(53546011)(2906002)(6486002)(478600001)(8676002)(8936002)(5660300002)(86362001)(6666004)(31696002)(66946007)(66556008)(6916009)(4326008)(66476007)(41300700001)(316002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkFGamtzazdqQW5ocHJvR1AyYzZMaU9yc2xhakNoYzA2SE5IOC93eGZXRFBH?= =?utf-8?B?MjN2Mk5ZNEhEY1lzZ3hTNTZVM0Zwb3B1VHM0UlV4dVA3azV1V0RFVHk3LzhD?= =?utf-8?B?dFNZVHFQeGxGYXhSWlZoaVZqa0dUOWpwL0J5Yy9MdlR1dGxxTVVseE9FMDRx?= =?utf-8?B?RGcrWElsZGE4NzdyWGFUd0VVTkdhSENiNE9iazZhcUgwY1lWcDYvYVk5eURi?= =?utf-8?B?b1dLRUxsYXlkUDgzSkp1R01WRk90RURGM3RxMDV2K0tTd0FabUVyYXZNWm1n?= =?utf-8?B?dkFmM3VHRGtqUDFNbVFxaG9qVFdJUWhzMjBOcnV2cTFqZnF0WDBOcVBqRnhF?= =?utf-8?B?NzNTYmdzS0xXeU91OWFYUjhFbWpPSzlKUEUxSlM4UFNCUStUUlpoQUxUOU01?= =?utf-8?B?Q0ZQWm5mRThMYjNGRDV0Q0lmR01aOVc0eFFWY2JaZm1EbWhDZ0I2UWI3WVdr?= =?utf-8?B?bFl3L2NyU0RZWkE5REN6OUsxUzBrU3hBTEZ0RHdpSjBGN3A3bW0yUlVZK0k2?= =?utf-8?B?S2JVUW9LQVJrN1VETWpHYUJDdXpvczB4YnhuMGV6MHhQT3AwUFNRV2xsWVhW?= =?utf-8?B?WDNqWDZjemxneVNaQ2kxdzl0V25sdVZVM1d2ZXVmeHNHS3N1b1dTZDhvYzNx?= =?utf-8?B?THYvTGhWYzIvOUF0NGR5dEY1ejZLTVp5cTJDTUh0cWs4aTV1MnFWMjVVVXQ3?= =?utf-8?B?RTB2TGFqS3JsSHFnQkNQa2VMdXQ4LzZPcWNrdi9YRTJjM3RRSlZiV3I0L29O?= =?utf-8?B?UngzNEJ4ZDZydGZldHFLdXplbW5JSkt5UkxXYkV3S0c5NjA5akZ4ZGxXMSs5?= =?utf-8?B?eXJmTm4wMElZenVPQ2ZjWnhBYUJHbWVEVFpaNnhTbDdCSWtVZHFkdm5iZ1BO?= =?utf-8?B?dS8vS2ovMzExZXNYWHdOakdNMTZTNU93M01taDNZdnNJYkJFZkhEcEV5RkEx?= =?utf-8?B?VUlOWTkybS8yUE8wT1MxSkNxU3lqUitoVGtEMUZkcXVPK2hWamlYMFBYVVpy?= =?utf-8?B?QXNobXRLUXNGcGowZHliUm16c1JFV2RrQTdLdGpqeitxenJKb3hEUG1aeG5q?= =?utf-8?B?dVFNeStlUVY3NHRXYkR4OFFpNnNzT3UzbEoybGpzR0pSWGtkTDM2Ukk4ZjNr?= =?utf-8?B?WXZMUDNicXpTd2g4VVJHVmJOcnlYbVQ4T0hNam9lUWcwQW04Y21CV1czS2JU?= =?utf-8?B?cURvVkxUSWxYVHdjSG82YVBIMWRsa1VhZVNrT1h3Y3dpTjkvdURwd1NHWXdy?= =?utf-8?B?VUVjUzRWd0tmRThQd25xSTEvUGtKZE9zd0EvaWNvdzVYMkJqemthWkxqVWw3?= =?utf-8?B?cjFpU0g4MjdxYzhwdGkrRk5TOFIrbGFFTnZXdThYRTdQclpJSDFZaWJIMmN6?= =?utf-8?B?WXJEcFBNY05WWUFpcjc5MlJJMVNlc09MU3JhU3RFVGRWMUpQQXQ2M08vWmlt?= =?utf-8?B?OThHc2ZsV2VDczlZdnRUNHkwcFZtK1JScVdCSGN3azJHL3dPR1V4ZTNMZ3Yw?= =?utf-8?B?OUJISG1vbXZ4T0xpOURacDZ6SkdtNk1BS1doNlBwblBSU0NJZHRWWmt3ZjVt?= =?utf-8?B?dldoNCtNcllsTFYxVk5JeTVCb0RkQ1Z3cHYrcVJnYitmNFNsOUl4bHBwRVhC?= =?utf-8?B?VGd1YXVGY0t2emJhRFRqOGRlWUdQVWs1d2wyYnNqOEFhb2M0VDZ4STBxRDhw?= =?utf-8?B?Q0hydDlpM0dGS1dPWmJsYTRxNXp5dHRIWkcrZFNPVVNUejl1T2Q3cnFxVDha?= =?utf-8?B?cGI0dG1YeHVEVnhlRWltVkNYOGdXRXJwNWpvODJ4a2dLV2R1R1R0WjU4MTlj?= =?utf-8?B?czg5ZlBhcUxwR1djbGlEYTJYa0FhQ05PWktYVVNSbXhDQ2NsdWhMUjc5ZXNN?= =?utf-8?B?ckdxWFhWZk5lRHNDQVgwb1N2NEZDZFcxUGljc1lkY2RZNHhvTDU3Sm44a0kx?= =?utf-8?B?OVNuYTJXSG0rVUI0dVpvMTdjWHVONGNUeVZVZFhRTXp4L1F6dXc2MmhsOHN1?= =?utf-8?B?MW9iai80Nmd4cWJHYzZud01NVWZoSE5HSk5rajQ2dVRMTmZ4UHM0R2I0Q3pu?= =?utf-8?B?U280dG5kanB4a21jbEp1MEx0alhVczE5QkxscXZzTDFBL1JMdGZheXhHbUhp?= =?utf-8?Q?O5q2pQTddnsTiJ9KzaBZopfnz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d188a132-a21e-4ef2-e077-08db935b8949 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 13:22:35.9250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PzAywFGCymx+FQnf9RH+zrtonP2pGQ1xA4fZNjvsZbM+umHb52JCuyZDp1+qdiWOC5CoVIApr48GFMhjWviMRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7142 On 02.08.2023 15:10, Andrew Cooper wrote: > Add the script to the X86 section in ./MAINTAINERS. > > Structures or unions without any named members aren't liked by Misra > (nor the C standard). Avoid emitting such for leaves without any known > bits. > > The placeholders are affected similarly, but are only visible to MISRA in the > middle of a patch series adding a new leaf. The absence of a name was > intentional as these defines need to not duplicate names. > > As that's not deemed acceptable any more, move placeholder processing into the > main loop and append the the word number to generate unique names. > > $ diff cpuid-autogen-{before,after}.h > @@ -1034,7 +1034,7 @@ > bool intel_psfd:1, ipred_ctrl:1, rrsba_ctrl:1, ddp_ctrl:1, ... > > #define CPUID_BITFIELD_14 \ > - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... > + uint32_t _placeholder_14 > > #define CPUID_BITFIELD_15 \ > bool :1, :1, :1, :1, avx_vnni_int8:1, avx_ne_convert:1, :1, ... > @@ -1043,19 +1043,19 @@ > bool rdcl_no:1, eibrs:1, rsba:1, skip_l1dfl:1, intel_ssb_no:1, ... > > #define CPUID_BITFIELD_17 \ > - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... > + uint32_t _placeholder_17 > > #define CPUID_BITFIELD_18 \ > - uint32_t :32 /* placeholder */ > + uint32_t _placeholder_18 > > #define CPUID_BITFIELD_19 \ > - uint32_t :32 /* placeholder */ > + uint32_t _placeholder_19 > > #define CPUID_BITFIELD_20 \ > - uint32_t :32 /* placeholder */ > + uint32_t _placeholder_20 > > #define CPUID_BITFIELD_21 \ > - uint32_t :32 /* placeholder */ > + uint32_t _placeholder_21 > > #endif /* __XEN_X86__FEATURESET_DATA__ */ > > No functional change. > > Signed-off-by: Jan Beulich > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one question below. > v2: > * Write it more pythonically. Yeah, you know I don't speak Python very well. I was glad I got it to work without overly much hassle. > @@ -382,7 +382,10 @@ def crunch_numbers(state): > > names.append(name.lower()) > > - state.bitfields.append("bool " + ":1, ".join(names) + ":1") > + if any(names): > + state.bitfields.append("bool " + ":1, ".join(names) + ":1") > + else: > + state.bitfields.append("uint32_t _placeholder_%s" % (word, )) I thought % could be used here, but then I wouldn't have known to use %s (elsewhere we use %u), nor to add an empty argument (which I see is done in a few other places as well, but not uniformly when %s is used). I assume there's a reason for the specific way you've done it here? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 02 13:27:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 13:27:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574936.900571 (Exim 4.92) (envelope-from ) id 1qRBsb-0005AV-PY; Wed, 02 Aug 2023 13:27:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574936.900571; Wed, 02 Aug 2023 13:27:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBsb-0005AO-LR; Wed, 02 Aug 2023 13:27:09 +0000 Received: by outflank-mailman (input) for mailman id 574936; Wed, 02 Aug 2023 13:27:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBsa-0005AI-IS for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 13:27:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46219955-3138-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 15:27:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ADB281F8A4; Wed, 2 Aug 2023 13:27:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8190E13919; Wed, 2 Aug 2023 13:27:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t26+HalZymQZbQAAMHmgww (envelope-from ); Wed, 02 Aug 2023 13:27:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46219955-3138-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1690982825; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k0kitvcA5nLs9AE7chmpglfgup5XkxvTAeLnE2nilus=; b=eDyNUA2ny7A+uaeC7/YkNh0O9dvj3+wCCtUmuHiKdpBLZHhxSu94BUT7aYGQO/S0LyVQsT UUnV2lsoUBeempgiIbOx8l8iS2UHHfwYwroUgHnoQ3GGBZjbWeHCjiXJc0FX6gyGIw8cc9 p/UmShxA1S63jFwtiv1SvuOYNBKlt54= Message-ID: Date: Wed, 2 Aug 2023 15:27:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH -next] xen/evtchn: Remove unused function declaration xen_set_affinity_evtchn() Content-Language: en-US To: Yue Haibing , sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, rahul.singh@arm.com Cc: xen-devel@lists.xenproject.org References: <20230801145413.40684-1-yuehaibing@huawei.com> From: Juergen Gross In-Reply-To: <20230801145413.40684-1-yuehaibing@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ETSmEXOC7kgD4PkgRcJI7DNu" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ETSmEXOC7kgD4PkgRcJI7DNu Content-Type: multipart/mixed; boundary="------------i4vxukn0iBhI50xMe64E7w8c"; protected-headers="v1" From: Juergen Gross To: Yue Haibing , sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, rahul.singh@arm.com Cc: xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH -next] xen/evtchn: Remove unused function declaration xen_set_affinity_evtchn() References: <20230801145413.40684-1-yuehaibing@huawei.com> In-Reply-To: <20230801145413.40684-1-yuehaibing@huawei.com> --------------i4vxukn0iBhI50xMe64E7w8c Content-Type: multipart/mixed; boundary="------------SkXK70tpRqP4YkofH8oklmr6" --------------SkXK70tpRqP4YkofH8oklmr6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDguMjMgMTY6NTQsIFl1ZSBIYWliaW5nIHdyb3RlOg0KPiBDb21taXQgNjc0NzNi ODE5NGJjICgieGVuL2V2ZW50czogUmVtb3ZlIGRpc2Z1bmN0IGFmZmluaXR5IHNwcmVhZGlu ZyIpDQo+IGxlYXZlIHRoaXMgdW51c2VkIGRlY2xhcmF0aW9uLg0KPiANCj4gU2lnbmVkLW9m Zi1ieTogWXVlIEhhaWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNvbT4NCg0KUmV2aWV3ZWQt Ynk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQoNCg== --------------SkXK70tpRqP4YkofH8oklmr6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------SkXK70tpRqP4YkofH8oklmr6-- --------------i4vxukn0iBhI50xMe64E7w8c-- --------------ETSmEXOC7kgD4PkgRcJI7DNu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTKWagFAwAAAAAACgkQsN6d1ii/Ey8e Uwf/YjnfblYcOtHENtUKkZiqZxCanu4hF/AGilVcnQYSnDGgeA033mKMjLurUwqS5ote5G9PN620 HuVgbHqU/U0jVaxp6Uvs4n9pe+EVgNjnexg9BjqKguN2+5DotZO5mD5DKYuLkAC8JC6rAeAfNuwo F4IYpcS3vhwGjyyVwO2GbWpX6QnZaOc4T9XdxoBqPxYOqir0celSbthkhrPFvgeg9pwo4K3J7c3n aGKHXAKDAhLr4hhr5bIGKV1g9os41DAPIgifUoLS65Q/HXMBV15QiivGkMcg38O+USQBP/+8eX2I mEywHkmpZ2FHXYJGD6l2M3PDXcxwM6yXu+aV7ZLCvw== =ojaL -----END PGP SIGNATURE----- --------------ETSmEXOC7kgD4PkgRcJI7DNu-- From xen-devel-bounces@lists.xenproject.org Wed Aug 02 13:31:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 13:31:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574941.900581 (Exim 4.92) (envelope-from ) id 1qRBwx-0006cv-9v; Wed, 02 Aug 2023 13:31:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574941.900581; Wed, 02 Aug 2023 13:31:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBwx-0006co-6M; Wed, 02 Aug 2023 13:31:39 +0000 Received: by outflank-mailman (input) for mailman id 574941; Wed, 02 Aug 2023 13:31:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRBwv-0006ci-LE for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 13:31:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5755142-3138-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 15:31:34 +0200 (CEST) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Aug 2023 09:31:31 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5604.namprd03.prod.outlook.com (2603:10b6:208:29a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 13:31:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Wed, 2 Aug 2023 13:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5755142-3138-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1690983094; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=mmIj5gQS9Glz/5KnZL6kz4FZF0Dtt1GbJvEsBCFSfQo=; b=dFLervU9AQA2raDA1QucjIc1u0CEyDcdAY8lROv+p07S7WwMP3K7WrU2 uTiAi3l04g+0pEMqp6CHG6rDTw3jW7qQHNl35LoTSllZiDrf7txF1wL0e jYqoRaMsG+6b+H5zPvsYNbzl0jux8Oq08ddUwuFACZ9aFzKfihnqKWMGk w=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 118269684 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rLbff6KhUMdV1lfcFE+REJQlxSXFcZb7ZxGr2PjKsXjdYENS0mFUx zcZDz2CPq6NYmv2fYx+Poy09kwF7ZGBnYViQFNlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRkPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5pKF4Vy +UnLgoxNDKB3sWk642YVNJF05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLl2Sd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqrAtxDSu3knhJsqEaXw3AuLSYGbgK2+9W3p3CfdfkCe mVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rXQyxaUAC4DVDEpQNonv8gyTHo02 0OTntXoLTZyv6aYT33b/bCRxRuiNC5QIWIcaCssSQoe/8KlsIw1lgjITNtoDOiylNKdJN3r6 zWDrSx7jbNMi8cOjv2/5Qqe22nqoYXVRAko4AmRRnii8g5yeI+iYcqv9ETf6vFDao2eSzFto UQ5piRX18hWZbnlqcBHaLxl8G2BjxpdDADhvA== IronPort-HdrOrdr: A9a23:aA43sqhtgF/DCgR6Hqbz9CJHE3BQXgYji2hC6mlwRA09TyX4rb HUoB1/73TJYVkqNk3I9ersBEDCewK5yXcN2+gs1O6ZPDUO21HYTr2Kj7GSuwEIcheWnoRgPM FbAs1D4bbLYmSS4/yX3OD2KadG/DArytHPuc7Oi11WZUVBbaV46gdwDQyWVndxWBJNCfMCZf mhD4581kOdRUg= X-Talos-CUID: 9a23:WKn5UW+qZTZCmf0yrCuVv1A9JZsba0Lb9kuKAU3hLnRCd56LcnbFrQ== X-Talos-MUID: 9a23:SLDBbwjO6g0R1ENl8skFQMMpL8Nt/5mLM1A2yJhcl8epCw1eEGrMpWHi X-IronPort-AV: E=Sophos;i="6.01,249,1684814400"; d="scan'208";a="118269684" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJMijDyyu/ZOEaWeIyh4d3OEaHhja83ko2FAYAZWOyK4OVg6npDkBcOR+CaKDGNHiUOJ3/FdSW33twh9AVp6VJoQtRnwBZVBmfHotPt8/fxLA0ksLG70g2NniVcsLsZ6bNxC2mFoECUN5LxjCYnm5QLU74xf9p5deVd9u97W/Wps0uSjvlc4xhKluRx8WTU4pMlLHAs/NJTapfeMzdO6o5KpVWcngvERQ27Ljb3nUrvf9BGbqqKii3HzJMufiup7R/xuEUay3FF3yzPhsDKm1sfaOl0rIsEMCBc3TS+9lmKF/qhGIsIMl5sUiXnJAf5iWbwJtmD2sRoujuI/D/XspA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2TbtnL/m8prfhEqUqlTW4I8qNZGxszTAgBNOj+2dmDg=; b=Q0AXBDxnHqiY4NUeEwp2WuYCdRUZaXJocnuM69RupY5gGZha1yYv51UoK6xHxQwuXHAUSKClfHuvHOTCKBm/8L+ZFWsfSUyiR0AjspsZRjGf/vhEJR08FhwSASCiwSKvKkXeUr1zd9hlnZsG3WA5muLV+IPg7Ss7V9swOrF0AS5cS4+YqBoNnCQIUZ+vVggwSfdj8wBK/v84eZKpwrmKfj11tKnC5nNhASe8eLji+IU9oj+FVJQyj9Yl//cvOO43OV8svScSKE/XOcNEeRPxbwoxdQGH9HhvnbmAzqJuwmS4/8vNIKYMsJlX4IRIAL1vYODQnCN0zYduXAE2oqaSdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2TbtnL/m8prfhEqUqlTW4I8qNZGxszTAgBNOj+2dmDg=; b=pE2FjnvbmSgMgBYJ4sFXbkzvpSPp1WNobowxScC6DCuda8RlE4XywFPL74jSvyYz0xteVW+fwHzKs0mz8FzSeQ9gwggEv3V1Rx/wK5MkyQmWwXk2bZTog4y7A5UHMuirujrh6ChiLjYjZeoL8rsiL1wDQj7SXYq+MXjntewz4mU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <185d2ddf-9461-564c-5d29-4a5afe88596d@citrix.com> Date: Wed, 2 Aug 2023 14:31:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH v2] x86/gen-cpuid: Avoid violations of Misra rule 1.3 Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Nicola Vetrini , Xen-devel References: <20230802131003.166670-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0185.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::29) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BLAPR03MB5604:EE_ X-MS-Office365-Filtering-Correlation-Id: 28c263fd-0c20-4d8a-059b-08db935cc5b7 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R/PYo+nYyIttISvwou1+TUgGfrDzJQqdDLCcXy2W7vhGcRRrcIZoxYGoCvAQnb8qxqFdj660IwsOcwaIAMCGeivy9c7sgcmv07XASRaTfXDDsUR/mngtqGJsxGVl/jjjW/TOgO+TgpkowChecKQovJgzekDU9ZvTHmwgluYBU0Pc6TZv/PHHDOXVjAQPl9+aDf+JkBoULJQcwX40rQqKjnMwyh1wREi7eNxXKUoSoDb64vLRTwEJ+fjufjsTY3lXeZKgoq1EBxDZUV0ikAYYlt9f7QHcyeDN+soADXskyh6hFNAGCJ31YGWCOa2cRby+p/1HqDH0Od3YTHmajDREz/CSIT3piKa1J9RwCCeAoIpiqZUxJEo6a53Xhg/EbC7ItGzPKQAUmcqOYOT3/zP+PX8w4xmCRnk9rysCRBDSZUEsc+o2Xvz01ij72HyzvBLhCFzMjIGvZwk6ZvWaxXya6hCEOGQn1gefQltR1eQEHhxdUJ2ykzLq8S7gr3t3JWqH4F12uYMJk4RSt2kbO8zCbqkJ+ySvwhnZ5uFr5vGj8MypNU3IXbR7ozVyDdl2nirdkLiFPQhXVlUZjlbQAlclMB1vG827/hDccJU8+sjoL2d60dHeHNBdHvlUZbFdOLBzAd+LGtzOa1lcuFsAT+FCKg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(366004)(346002)(396003)(376002)(451199021)(31686004)(4326008)(6916009)(31696002)(86362001)(36756003)(38100700002)(82960400001)(53546011)(6506007)(2616005)(83380400001)(186003)(26005)(6666004)(6486002)(6512007)(478600001)(54906003)(66556008)(66476007)(66946007)(8676002)(8936002)(316002)(41300700001)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1Exc2lmdUdVT2RvMTdyallDSVo5TUJ6SHo4M3JVRy9EYmxsdENaNEFMSHBY?= =?utf-8?B?eTJMdEc1UktYeUJlU0loQkRDeU1jVUhLTHd3eDI1T2dhNkNZRk5jRHpTVXly?= =?utf-8?B?Q0JBQ2dNKzJvZEROQ0lnTjZCQWNsZHdpQWFwVEdwU2NvWnRVcm4ybVNKYXZM?= =?utf-8?B?bTdmTkpVVytyc0FZS09mcVZIVkJvT1ZWT21tckRGTGZOcVNSZThnNmg2TVBy?= =?utf-8?B?RUVUTm1ESjA2ZzV5dTFLQys0MWVwUFlUU3dvdEhRSjJxSEhIbC9UbDlKc1Zk?= =?utf-8?B?SzEyVmpiL0NwSWc5Q1V5RXBnT1dBbHJlUSs5aTZXbDllSTYyTWl0SGNSM1dS?= =?utf-8?B?S1daQklXK1ZUZzZ5N3FtekZ3dStQTUc3a3ZVMUVPbVc1a0NIK29MdHp2TVRp?= =?utf-8?B?UTVtZlRET0xlUWd4Zk10UTJxOC9lRG1TS3FNMzFpM01teS81L3FySHZqYU0z?= =?utf-8?B?ZXp4dEZZaU92ZURGbFRUSFZIM2o3VUdsd0djTFpRZ3EvZklhUnM1cUNQUWFq?= =?utf-8?B?ak4zcjNQRFRycW54b2VpUUJUSTRqcnhIZGhkUnRqYTFQUktCaEtHek4zQWh4?= =?utf-8?B?cTRxUFh2TXpEU0tvZzF0WW9rSjVpbk0ycG1ScmJ2Sy9qalJUY280Z1hZTFNL?= =?utf-8?B?MFFDRmJZK3I1WXRORE8xa2JOLzgvdVNON0ZDY3hOekY4clo5YUJYVXhMSHB1?= =?utf-8?B?dldSbzFQY3U1aDJqaUlnSHkvRmVnZVAxTXRaTlZKSmVpM2p4NTJQVWNicTcz?= =?utf-8?B?UXdUWGZNVjBMdnBmNkd0ZGo2cTZ4TWYxQi9VVkc3eFJycGM0MjgzamNlczlR?= =?utf-8?B?MXRZSWJFQzV3M25mNEMrcDZOWUZEdkFUSUUySmI2dldmRkVieGJQbmpVV2Rp?= =?utf-8?B?bis3c1hPQkhBNHV0M3FPVEpZdHNkTTE4eWs4Zjk4NXkzeEFLU1VvckNnUUEx?= =?utf-8?B?RlE2TTMrR2owaFRPR1JGV3VobHRiWXp0MG8xU2tZeVJvUUVmV0hnN0crd2w3?= =?utf-8?B?OUMrRVJIdDFJRFl5LzZsMTdPcXN4ZTFWaEtzS2FwODA2d0xua2NEbzdnWDBh?= =?utf-8?B?VEthYUZ6Sjl1RmdWc1ZaaHIrS3lrMzVMOGdWcTNhM2hNWFQ5aWdQMEdlMGxM?= =?utf-8?B?cWR6U3lhWnpTUHNTQlB6ZU52YWRvaU81amY4SGljU0YzQUt6UExSVjdPUXYv?= =?utf-8?B?SWJYKyt1V0N3M0lUY3lDQ1ZvdWhHbUVzcDN0RGRPR3lWek5MVFlmNmdxcmNT?= =?utf-8?B?OVEvOTJYQjg0VVRTL1dJaTc0dXJlcm8vTTkrVkVlOEVaMEFMMkJZRWh5dzZ2?= =?utf-8?B?Q3poKzg2N2toSEJUaVhDamlPbFpBdGJOT2s4Nk96T2ZiZytUaHRQMDFXNEFN?= =?utf-8?B?VWF5T3pId05hOEluZ3F1bFF3ME55ZzdFbkJWWThtQ0JJd3czM2JPWEtHT3k2?= =?utf-8?B?QWt0THdlNWV1Y0NJNzRZVXNhNlJtK3V6ZzdkWUQ4VWVFYzY5MVFERTFIeWJv?= =?utf-8?B?N1FjRVcyeFJxaGQvSFlwMXZWbWtCRjByVnh4Q0xMaUtvVXNoK1JXb0l4dmhK?= =?utf-8?B?enZIU3hUZ0VXbkNkRU5WSFhpZVVjSlZQUUtZYmpwcWdRQm02YURsV0MvVGla?= =?utf-8?B?YW9WUkJnSFZKYVFDMTNCOGdrcnYvcDU0Ym1pWjdINUczMkZvZ2gwNC8vczlq?= =?utf-8?B?UkcxYTJMRHU0Mk9rNElmSmVZNVpCT3ZxYkhnWCtieSszZGtKVDhqcktYYnhj?= =?utf-8?B?TlEzWUxranF3dCtEU1dPWnB2NkxuamlSNllTYmE1ZGttL2F3WnlRaTkwdEJa?= =?utf-8?B?RHIvSDd2WEg2dGdNeEFwMWtsT1EzRjhlR1JtQXhkWEJMYUY2T1EwcDJYTUN5?= =?utf-8?B?OXd3cDE5aWZWWWJRSXVCQ2pWWDlvSUQwV0FUUnhOdzlYUDBTWUlUcXQrOVhG?= =?utf-8?B?VzJzTGZkTElPQnVsdU1KQnBQRlZpcTFpMC9NQmV6dFJPZzZpaUVOWVA0Mmkr?= =?utf-8?B?WDY4UmllUS9IWnd4VmJqWVBVYmlSTU5uanQ2Z2tvOTVldk01azhBcDVYazNF?= =?utf-8?B?Ym9FQ2duV04rbUg0bzF4c0tkdEJTZjkvUnk0cS96clc5YVZmSlcyUzBDMHI5?= =?utf-8?B?RFcvWWxPVm1UYWc4empnTFVVWkpZaVRpR1RYaGZHRE96c3o0ZGFPTVcvYzRM?= =?utf-8?B?YVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 30RuHhsc58mOUG7tWYHz1DtmQgnbCSCtqrI2vC/jXxHuZOMtc5nLAEroLRF9UgFVKC/bv4iLs9uvmaMp/nYPjN39HL7PmebVhOz6y7Fk3jCLYML9HckO4v2AkioVbnnGG4SET1bbJjI/SMVh4RcgvYYJKAPJ3NTRqu0OX/s5dzbevuBFoKGI3CvGWa8eZdGcrurcL2VFW2hWKnRyTFA6a7ET+4xIIMcdbUBHVZWKV7Hi0eqUqof5IvEDtFf2K4yeFlqvx4Fn1kY7QqDqZwTKCX7QgSsQcz7//I13Ek6dMVigAyAmkixRwUHtc82cGbYceC7MIAsmwcr4It94pLS3xBESNwe3aFxeC7t5z1pu0/7Ud5+O5fe+5PyvzeTnafLmdt5kLMXI7Fck6Qt+VBYL4eKc5HM+g9GowrTV3gZ6sqJvfdE1xk5heHmBm9rnFY7us51cFdG/mdlG9AQL97G4416lWJjUUjObmmQgpdJ+LT2ZHdfXpIcPu/Fz0zNgzYoecj8uYn5WYIrXbG9TsEmxPdaCJZ0oIxInNGye+6awisjII3Y5M2oVI9ieAwRWv5HTmWqkqz7FPe9Xc41YPqXscMyzb6BHwS9aI/cdKr057hrQPbmvnuJkiaCnVRIro4r83fUH8hs9GbmzWdTgtfijuN2uy736bPH/J2rjQmKJF36ZZ1vsRa+ipSfa7xTq7jlp1HhvJAaM1Io88zfsoR6oNRDHSzT/9Abummb9IorbCQLR9kTq/NOTsULyozwPzksIeIPnbfZrMjEuEDLtRyizAv26MtwWZpvbSNugSU7IjoxawF6OYmtRcVSH5LEpC3nOb1FFXbZmLnlO/lkjZ3FWSh8iAmx4tcScJv7xeUWicqE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28c263fd-0c20-4d8a-059b-08db935cc5b7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 13:31:26.9036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HCrN9RJmyzmffooiWv/9mbHqfTnpM18uQKoOHnRNkJaaXQZjxsG/RlToysTEyv0JPldwaPoiXmVHIsUrM2dVWxeOVnNC3qyuXXUSNDyHCBI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5604 On 02/08/2023 2:22 pm, Jan Beulich wrote: > On 02.08.2023 15:10, Andrew Cooper wrote: >> Add the script to the X86 section in ./MAINTAINERS. >> >> Structures or unions without any named members aren't liked by Misra >> (nor the C standard). Avoid emitting such for leaves without any known >> bits. >> >> The placeholders are affected similarly, but are only visible to MISRA in the >> middle of a patch series adding a new leaf. The absence of a name was >> intentional as these defines need to not duplicate names. >> >> As that's not deemed acceptable any more, move placeholder processing into the >> main loop and append the the word number to generate unique names. >> >> $ diff cpuid-autogen-{before,after}.h >> @@ -1034,7 +1034,7 @@ >> bool intel_psfd:1, ipred_ctrl:1, rrsba_ctrl:1, ddp_ctrl:1, ... >> >> #define CPUID_BITFIELD_14 \ >> - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... >> + uint32_t _placeholder_14 >> >> #define CPUID_BITFIELD_15 \ >> bool :1, :1, :1, :1, avx_vnni_int8:1, avx_ne_convert:1, :1, ... >> @@ -1043,19 +1043,19 @@ >> bool rdcl_no:1, eibrs:1, rsba:1, skip_l1dfl:1, intel_ssb_no:1, ... >> >> #define CPUID_BITFIELD_17 \ >> - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... >> + uint32_t _placeholder_17 >> >> #define CPUID_BITFIELD_18 \ >> - uint32_t :32 /* placeholder */ >> + uint32_t _placeholder_18 >> >> #define CPUID_BITFIELD_19 \ >> - uint32_t :32 /* placeholder */ >> + uint32_t _placeholder_19 >> >> #define CPUID_BITFIELD_20 \ >> - uint32_t :32 /* placeholder */ >> + uint32_t _placeholder_20 >> >> #define CPUID_BITFIELD_21 \ >> - uint32_t :32 /* placeholder */ >> + uint32_t _placeholder_21 >> >> #endif /* __XEN_X86__FEATURESET_DATA__ */ >> >> No functional change. >> >> Signed-off-by: Jan Beulich >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. > with one question below. > >> v2: >> * Write it more pythonically. > Yeah, you know I don't speak Python very well. I was glad I got it to > work without overly much hassle. Generally speaking, if you've got bool-like variables around loops, there's a neater way of expressing it. This one relies on truthy/falsy values where "" is treated as false.  (Same too with None, 0, (,), {} and [] for the other primitive datatypes). > >> @@ -382,7 +382,10 @@ def crunch_numbers(state): >> >> names.append(name.lower()) >> >> - state.bitfields.append("bool " + ":1, ".join(names) + ":1") >> + if any(names): >> + state.bitfields.append("bool " + ":1, ".join(names) + ":1") >> + else: >> + state.bitfields.append("uint32_t _placeholder_%s" % (word, )) > I thought % could be used here, but then I wouldn't have known to use > %s (elsewhere we use %u), nor to add an empty argument (which I see > is done in a few other places as well, but not uniformly when %s is > used). I assume there's a reason for the specific way you've done it > here? Hmm.  That was taken from your version. In python, %s means "call str() on whatever you have".  Similarly, %r means repr().  str() on an integer behaves as %d. But yes, %u would be better here, and consistent with the rest of the script. Happy to fix on commit. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 02 13:44:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 13:44:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574948.900591 (Exim 4.92) (envelope-from ) id 1qRC8x-0008DT-Gh; Wed, 02 Aug 2023 13:44:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574948.900591; Wed, 02 Aug 2023 13:44:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRC8x-0008DM-DO; Wed, 02 Aug 2023 13:44:03 +0000 Received: by outflank-mailman (input) for mailman id 574948; Wed, 02 Aug 2023 13:44:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRC8w-0008DG-QV for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 13:44:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a213386f-313a-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 15:43:59 +0200 (CEST) Received: from AS4P192CA0029.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5e1::14) by DU0PR08MB7787.eurprd08.prod.outlook.com (2603:10a6:10:3b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19; Wed, 2 Aug 2023 13:43:24 +0000 Received: from AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5e1:cafe::f) by AS4P192CA0029.outlook.office365.com (2603:10a6:20b:5e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45 via Frontend Transport; Wed, 2 Aug 2023 13:43:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT056.mail.protection.outlook.com (100.127.140.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45 via Frontend Transport; Wed, 2 Aug 2023 13:43:24 +0000 Received: ("Tessian outbound d7adc65d10b4:v145"); Wed, 02 Aug 2023 13:43:24 +0000 Received: from 0fe65365a262.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3798346E-7498-4EA4-AA87-B1F5C51D0A84.1; Wed, 02 Aug 2023 13:43:17 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0fe65365a262.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Aug 2023 13:43:17 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV1PR08MB7874.eurprd08.prod.outlook.com (2603:10a6:150:5d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 13:43:15 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::4560:65a:d8e2:719c]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::4560:65a:d8e2:719c%4]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 13:43:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a213386f-313a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pH3bkCIKuTVL3DEWeAq83+jifAYz5QQcYRZXgDudh9o=; b=9YI2vjXMulWiI2h0aKhWfS5vdlW4lQAFs/oGD4l7O/hiW64iIbGWtV+vQBvDMrRT+nhD5l/EO87HgG4E4nANtTTFwV7kyb4jU//mfsG80hJe9o1Xq0OmgKVdtnYmpM2himo9RKyuz6oGT1pIm/NSKXOpXLduw/1T5Ln/lG1EXPA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: defbb318eaf48460 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJl2nDPo5fg2hg0Zt8KnunawWc0VWZQnBixHtdKqm1NfRQKJglask/48OGsxJj8lYIa4/U4bxPjnoNvyXc6Tnrz1YGuglgjnPD3gBT3v4bwBNB3TNJlEiV2H0b5ic5sN2henElRV/TL54JrGuhu/GsYP7DvDBsg8NEvsSw7Z3y06rOXAxr2+dsyqa4PmSfBSSticPI1cWNixLA79xOzWRysAdDb9JOlkKUcBMyqz6fVJbTGochlA8Su73Hp/KayBoTSCvya2aNgBlbAPiOx2Olz8VP7+FRnzBu6atcdRcZVuwFPwdkyov7WxsT8/UVyR7vQZk18+6vdXFI74cnNDKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pH3bkCIKuTVL3DEWeAq83+jifAYz5QQcYRZXgDudh9o=; b=mTJ6mc+tr25rFk2VhNELclXvhanAqHGyCnlAr+cV6GM/rqTldqgGndKPkQU2mYtGDHgfn83qIn+4D0Yu3EK9/DCjVW+OZZ2+Uo1KPjoF/KjVV7QjUpUZb21dPP215BKZ9XDdr3JOPKXG5s8UfaH8CfbVQc9EgszmG7l6UQvljUeynWJrrHMTv2ON/FV/43QOOrzYYV6WRNQeSKBJz4mKa0VXYCr0gx/RO3TmLkvGvY8T65/eP7/pRAWFqMWkR6ZJVRgmHnJgJ2DY6ObaWKU+2ACT8OaNQHluykKDr4PoaZV6tTP0lRYca9F1eeAtOkWZj+94nS14mvxFOf7Z07NhJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pH3bkCIKuTVL3DEWeAq83+jifAYz5QQcYRZXgDudh9o=; b=9YI2vjXMulWiI2h0aKhWfS5vdlW4lQAFs/oGD4l7O/hiW64iIbGWtV+vQBvDMrRT+nhD5l/EO87HgG4E4nANtTTFwV7kyb4jU//mfsG80hJe9o1Xq0OmgKVdtnYmpM2himo9RKyuz6oGT1pIm/NSKXOpXLduw/1T5Ln/lG1EXPA= From: Rahul Singh To: Yue Haibing CC: Juergen Gross , Stefano Stabellini , "oleksandr_tyshchenko@epam.com" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH -next] xen/evtchn: Remove unused function declaration xen_set_affinity_evtchn() Thread-Topic: [PATCH -next] xen/evtchn: Remove unused function declaration xen_set_affinity_evtchn() Thread-Index: AQHZxIgYKn4PxeouQUGx1NvFxt0zwq/XBWqA Date: Wed, 2 Aug 2023 13:43:14 +0000 Message-ID: References: <20230801145413.40684-1-yuehaibing@huawei.com> In-Reply-To: <20230801145413.40684-1-yuehaibing@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7158:EE_|GV1PR08MB7874:EE_|AM7EUR03FT056:EE_|DU0PR08MB7787:EE_ X-MS-Office365-Filtering-Correlation-Id: cea9dbd8-298a-429e-baed-08db935e7187 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MKcNWW86242y84aKVs4eI/wpBzyJngqjRj4k3KQUytlLa22KspP/lde6WAoL4gCaR6clbbWosFEFiuEkWX4Hc+UoSmnoWauHIzYu41F34kDXj9UzTpD////PCsCdMYQQxbbN5zHPjyyw+SCr6vUVd4wh2nbmt1xvqz0MsRFY+rmco8DGadj64ExszH6AaHydt1j3W7GhOR+VballePgmhNz5n/OvoTKdS6feurki9g9tpdwOMaLYyZrYMBTy/ltJbYJieB7E9TykHs0Yx+PivsT4eXmyeHvlowQiLg7s0kA8TsB7NwfybCl3Hq2QvfGSjVwof6dyCC7ngvHMNmP8UupZIX3h8ykJ4k6dOIoEb+0wS7eQjMdw4pNO64Wa0dz2FwQkL+Jf8bsUFmVQYE+K8loFmabZpZ+09eZle8Bq1p90CiBJgMmT+8M4sAJJKuqvNXei8YhrF/GO7bT9zE1yrolS9uEkXCY60gLmydRBUKdHzbUI2bcod0oZE1SjJ8/dtMIBuXg5cJrD3czGCDCWRkO1CE5Cr7BN9p2Ukz9ckynQtDth337S7FajI35x3u2ohiz3amL/dowHW8PgH3I+7lZT8QvfyK7VHDQoo8QW91d9ejAEa9qa/tumJfB3RQk3R5lzY4RBvFIFgDyNP6nY2Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(451199021)(41300700001)(36756003)(71200400001)(86362001)(33656002)(478600001)(6512007)(316002)(6486002)(66446008)(66556008)(76116006)(66946007)(64756008)(91956017)(4326008)(6916009)(66476007)(5660300002)(26005)(8676002)(8936002)(6506007)(38070700005)(53546011)(186003)(54906003)(4744005)(2616005)(38100700002)(2906002)(122000001)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7874 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 764144d6-9545-4a8d-2f6e-08db935e6bc2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YH/iUHCXV48rjkEatsu5HjgSAa0c91E+SaYggz0ziNoesbWNNvK1kThVGW5doc7hiN2GpzUy8wBSHGPFBzgd4VYVA+U6o2JXCL6xwfO4ppY5r7Gnh+C8IxMkBpZdPl9+fTaGoN/vh0QaZMNrrEYMhUWcf67hBwPdxxVVn7h/EXEyo6dOAY5Q/k3pqDB8TyWHR8VyrfIlAjY05eoFAxOWr537tejf4aVB49yrVfRpiXolqa9PQRWTdITQF/2kJtP65BUm8IUGdfrvITTfOYdHoiefXu29wDiM1walTlCfbFWnzEPzPaez1XmhDNUDQ9ePz0AdpO03zet2sx4GC+EKy04yVfast9iQLjgqi0ODJknPiKZUa7FKospUkl3nPzDZaWBWuutIbH0XQ8S1jjeYcSKnsnm3BR9763GeiAbRH4LvmExeBocU049Tc23gfMeiiVFUymyBNrDtjr0GQ5Ow4UaTWzhWlH5mNBKVfD7mbfDZa86CD/Pr8PMZHoDqxpzPGk/iCSdkOEFt8yWCjJmVjjSGJiC3lQg5U0eh67nm3iyH4VJcjwMwEkOMTYfCyMieqcH46h84yyAGMM4Ch4is1wkNMikH+bi0rDaP0ttM49cx1zUzVzcNTadpxI7jHEXSYAdaK7D3T0JAZr7Zy25S0YuGN3vzVMnj0AsfSF3TMFjslN5PTOZFi0NoMvidoP4SUp4Mt1WaEyQW7N1PqEhkBzjfLH7n9ghJZorbM61frs8X2dGqRWwt3LKfDCcK3B/7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199021)(82310400008)(46966006)(36840700001)(40470700004)(4744005)(33656002)(36756003)(40480700001)(86362001)(478600001)(6512007)(6486002)(8676002)(6862004)(8936002)(41300700001)(316002)(5660300002)(4326008)(40460700003)(36860700001)(47076005)(83380400001)(54906003)(2906002)(70586007)(70206006)(26005)(81166007)(356005)(82740400003)(2616005)(186003)(6506007)(336012)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 13:43:24.3361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cea9dbd8-298a-429e-baed-08db935e7187 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7787 Hi Yue, > On 1 Aug 2023, at 3:54 pm, Yue Haibing wrote: >=20 > Commit 67473b8194bc ("xen/events: Remove disfunct affinity spreading") > leave this unused declaration. >=20 > Signed-off-by: Yue Haibing Reviewed-by: Rahul Singh Regards, Rahul Singh > --- > include/xen/events.h | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/include/xen/events.h b/include/xen/events.h > index 95970a2f7695..95d5e28de324 100644 > --- a/include/xen/events.h > +++ b/include/xen/events.h > @@ -75,7 +75,6 @@ void evtchn_put(evtchn_port_t evtchn); >=20 > void xen_send_IPI_one(unsigned int cpu, enum ipi_vector vector); > void rebind_evtchn_irq(evtchn_port_t evtchn, int irq); > -int xen_set_affinity_evtchn(struct irq_desc *desc, unsigned int tcpu); >=20 > static inline void notify_remote_via_evtchn(evtchn_port_t port) > { > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 13:54:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 13:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574953.900600 (Exim 4.92) (envelope-from ) id 1qRCIf-0001JI-Cb; Wed, 02 Aug 2023 13:54:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574953.900600; Wed, 02 Aug 2023 13:54:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCIf-0001JB-9x; Wed, 02 Aug 2023 13:54:05 +0000 Received: by outflank-mailman (input) for mailman id 574953; Wed, 02 Aug 2023 13:54:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCIe-0001J5-0p for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 13:54:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 08958414-313c-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 15:54:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91D9D113E; Wed, 2 Aug 2023 06:54:43 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 75D893F5A1; Wed, 2 Aug 2023 06:53:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08958414-313c-11ee-8613-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Date: Wed, 2 Aug 2023 14:53:50 +0100 Message-Id: <20230802135350.745251-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles the GICv2 emulation for guests, it is required only when using GICV2 driver, otherwise using GICV3 it is optional and can be deselected if the user doesn't want to offer the vGICv2 interface to guests or maybe its GICv3 hardware can't offer the GICv2 compatible mode. Signed-off-by: Luca Fancellu --- xen/arch/arm/Kconfig | 13 +++++++++++++ xen/arch/arm/Makefile | 4 ++-- xen/arch/arm/domain_build.c | 4 ++++ xen/arch/arm/gic-v3.c | 4 ++++ xen/arch/arm/vgic.c | 2 ++ 5 files changed, 25 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index fd57a82dd284..dc702f08ace7 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -78,6 +78,14 @@ config ARM_EFI UEFI firmware. A UEFI stub is provided to allow Xen to be booted as an EFI application. +config GICV2 + bool "GICv2 driver" + default y + select VGICV2 + help + Driver for the ARM Generic Interrupt Controller v2. + If unsure, say Y + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC @@ -92,6 +100,11 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config VGICV2 + bool "vGICv2 interface for guests" + default y + depends on (GICV2 || GICV3) && !NEW_VGIC + config HVM def_bool y diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 7bf07e992046..81c31c36fc3d 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -22,7 +22,7 @@ obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += efi/ obj-y += gic.o -obj-y += gic-v2.o +obj-$(CONFIG_GICV2) += gic-v2.o obj-$(CONFIG_GICV3) += gic-v3.o obj-$(CONFIG_HAS_ITS) += gic-v3-its.o obj-$(CONFIG_HAS_ITS) += gic-v3-lpi.o @@ -57,7 +57,7 @@ obj-$(CONFIG_NEW_VGIC) += vgic/ ifneq ($(CONFIG_NEW_VGIC),y) obj-y += gic-vgic.o obj-y += vgic.o -obj-y += vgic-v2.o +obj-$(CONFIG_VGICV2) += vgic-v2.o obj-$(CONFIG_GICV3) += vgic-v3.o obj-$(CONFIG_HAS_ITS) += vgic-v3-its.o endif diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 39b4ee03a505..b2b609eb0c2d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2775,6 +2775,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, return res; } +#ifdef CONFIG_VGICV2 static int __init make_gicv2_domU_node(struct kernel_info *kinfo) { void *fdt = kinfo->fdt; @@ -2826,6 +2827,7 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo) return res; } +#endif #ifdef CONFIG_GICV3 static int __init make_gicv3_domU_node(struct kernel_info *kinfo) @@ -2901,8 +2903,10 @@ static int __init make_gic_domU_node(struct kernel_info *kinfo) case GIC_V3: return make_gicv3_domU_node(kinfo); #endif +#ifdef CONFIG_VGICV2 case GIC_V2: return make_gicv2_domU_node(kinfo); +#endif default: panic("Unsupported GIC version\n"); } diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 95e4f020febe..d18a3317ccc4 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1334,6 +1334,7 @@ static paddr_t __initdata dbase = INVALID_PADDR; static paddr_t __initdata vbase = INVALID_PADDR, vsize = 0; static paddr_t __initdata cbase = INVALID_PADDR, csize = 0; +#ifdef CONFIG_VGICV2 /* If the GICv3 supports GICv2, initialize it */ static void __init gicv3_init_v2(void) { @@ -1359,6 +1360,9 @@ static void __init gicv3_init_v2(void) vgic_v2_setup_hw(dbase, cbase, csize, vbase, 0); } +#else +static inline void gicv3_init_v2(void) { } +#endif static void __init gicv3_ioremap_distributor(paddr_t dist_paddr) { diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 97d6f6106638..86fa8bc7e894 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -95,10 +95,12 @@ int domain_vgic_register(struct domain *d, int *mmio_count) return -ENODEV; break; #endif +#ifdef CONFIG_VGICV2 case GIC_V2: if ( vgic_v2_init(d, mmio_count) ) return -ENODEV; break; +#endif default: printk(XENLOG_G_ERR "d%d: Unknown vGIC version %u\n", d->domain_id, d->arch.vgic.version); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:27:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:27:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574963.900611 (Exim 4.92) (envelope-from ) id 1qRCog-00052x-Su; Wed, 02 Aug 2023 14:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574963.900611; Wed, 02 Aug 2023 14:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCog-00052q-QD; Wed, 02 Aug 2023 14:27:10 +0000 Received: by outflank-mailman (input) for mailman id 574963; Wed, 02 Aug 2023 14:27:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCof-00052k-6v for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:27:09 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20623.outbound.protection.outlook.com [2a01:111:f400:7e89::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7af8ce3-3140-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 16:27:07 +0200 (CEST) Received: from MW4PR04CA0342.namprd04.prod.outlook.com (2603:10b6:303:8a::17) by SJ2PR12MB9244.namprd12.prod.outlook.com (2603:10b6:a03:574::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 14:27:02 +0000 Received: from CO1PEPF000044FD.namprd21.prod.outlook.com (2603:10b6:303:8a:cafe::9e) by MW4PR04CA0342.outlook.office365.com (2603:10b6:303:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 14:27:02 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000044FD.mail.protection.outlook.com (10.167.241.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Wed, 2 Aug 2023 14:27:02 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 09:27:00 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 09:27:00 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Wed, 2 Aug 2023 09:26:59 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7af8ce3-3140-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETz/y/5ay50DkvE2BIq4agIte2RKPTrnT0tov1tfnvICvtV7/I8Oz6HQy4aotq4xkDWWKPGPTNpNuYbV8xMJqYH/yvtVKpV0mSp29t7WAPxlwbXafMExUhoqsW3vlGBWFfgZEv5I+uCKi1OpEJVY6Z94TAsa+0vg9lr99jmjQnDj4t0UyYf0tVw0WWVkOqDXhd8AM3H1k3pmKF6bp9OjuO/oFcb6RxO7x3AYca/7yXQwVRffmNHn2ZiWG0Hf21bPnmWvf80FJkO73cvhkStFGfmHGJjOM8cKJnriRC1QmzJZ6WAlMNVWqvFfXarvip1/hZVhCBSTc5L0RDRdTthL0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nohBqLPQWx4dTuM4PWNJLXKTSyzFHK5QNQ1WRz6kULU=; b=Hq0z+OIyfGgsy8v0yk1xwcqZwAR7i/Xh/0rk8toGGRUSpDy7q0GxXIwcaY/CkpbOQerQpWwSW4uqO/1wk30BSnSPAj5yGM3Or3fiV0Qj5O+NAeB/k9/TGuLN6J5n6JLb+jdwISyGtVh/JIX+PloGQMNgQsDcTjCCliUzKtuKlOhKDdJhyefcR2zeiOvWpmw+I3urevcqyPyu56tYZx+RnpfPJYl/DlwxnEZpuZ4ya2IiOIu1JsoQ9wfjoBiaNUpzFj0bZcUafGOowCc2sHDHAtpW9dVxWkK1R4LX74pUcU/QIOjESWbLhL7g6gWcmgB5cs1I4wiO3FNbebtUFb+ToA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nohBqLPQWx4dTuM4PWNJLXKTSyzFHK5QNQ1WRz6kULU=; b=nm+tammUCSXaxSdG1yylCYhwRH8OVkq5Ws0lTXLKCqBjQss5iFAqTKzn4dBqDgC4PYN/+DCOf0yYeB6qVQHzXG37utn43HZeSxmPOlmazmbVvCc8lazz9xJbO44lwrBRZw91q80K6sPSyQW14J14ThiWR/nDgkGpp9wkRKAHOqU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> Date: Wed, 2 Aug 2023 16:26:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-US To: Luca Fancellu , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: <20230802135350.745251-1-luca.fancellu@arm.com> From: Michal Orzel In-Reply-To: <20230802135350.745251-1-luca.fancellu@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044FD:EE_|SJ2PR12MB9244:EE_ X-MS-Office365-Filtering-Correlation-Id: 69a3f33b-c919-479e-5d5f-08db93648a12 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ds0KnKK5gQ036SbIJ+2bJQuDItA0AH1STLo10vqy4T9JCeof/5DIvF2d+FBEZXOVuXXYVviDUdOvH0z1ab4T0i2BsQwh/am4POi5tvgX3jNIsKVCWrInV2tVmSk08JPs2cFL/HMhIQDdWUw+xrnjtwCmEcOTttr92UHAUt3l7F3i81CXoorNUxLty33JD8jZCgHlnJO/pC20r5YcyU5l9v9IJCLO6PVMO0m1sRKbZA2RmDWqdSy6EVjttzYEulDXgu6yB/ecNILiKjg9B2ZRIiBB0V4zg2EjNSM56lFeanAApAqFGgGWyfDkl+tmEgw0WtYCUNBkWaZ5q3dC6kt0mLeEnpTGAu3gfbKoJfe/r0cmGQka+Tb1xdBCCD14uETZJ8ru07CIbzVKOvJ16C6EP2z/jWnDMRzzPxCUpY36lLaFQjrC540msStJ6LoEyEorr+7ig3lY3kaYQYd18dZxz2VYFz79TK7K/N4LTKuaZdzFI0pfZIeXA/q08O++6ZbZkWU+MSy7YihKALIcGHlWMZdabb/zXRi8zlCEC9faLoP+MB2BdYpyQ7vVI93bPz8n637ZbEs31pQUtfuIlp7LMBgJZVycjyBc9HBubNGfK7NY4W0UgaCDgDlDEGAMB0kcBboqvkB/hLROmb48tynfZboTHRSxJBshuk9CsDu1W1uVWteqegfE0WrcH/UyN5SbKZ0F2ff8qZ0dxugs0LFGqOxHva1RUfZmvEdRACWoaq64hi6B/OwovvvLKhSbyRmHMqJDIoCqWp/cbi0Kp+egBJ1lVdTyU9RepG/aU04HUmVlSvlAEy9P2lmWEjU0mYyN X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(39860400002)(376002)(82310400008)(451199021)(46966006)(36840700001)(40470700004)(44832011)(4326008)(40460700003)(70586007)(70206006)(2906002)(426003)(2616005)(81166007)(82740400003)(356005)(53546011)(336012)(186003)(26005)(83380400001)(47076005)(36860700001)(110136005)(54906003)(40480700001)(86362001)(31696002)(36756003)(478600001)(41300700001)(8936002)(8676002)(5660300002)(31686004)(16576012)(316002)(66899021)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:27:02.3654 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69a3f33b-c919-479e-5d5f-08db93648a12 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044FD.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9244 Hi Luca, On 02/08/2023 15:53, Luca Fancellu wrote: > > > Introduce Kconfig GICV2 to be able to compile the GICv2 driver only > when needed, the option is active by default. > > Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles > the GICv2 emulation for guests, it is required only when using GICV2 > driver, otherwise using GICV3 it is optional and can be deselected > if the user doesn't want to offer the vGICv2 interface to guests or > maybe its GICv3 hardware can't offer the GICv2 compatible mode. > > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/Kconfig | 13 +++++++++++++ > xen/arch/arm/Makefile | 4 ++-- > xen/arch/arm/domain_build.c | 4 ++++ > xen/arch/arm/gic-v3.c | 4 ++++ > xen/arch/arm/vgic.c | 2 ++ > 5 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index fd57a82dd284..dc702f08ace7 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -78,6 +78,14 @@ config ARM_EFI > UEFI firmware. A UEFI stub is provided to allow Xen to > be booted as an EFI application. > > +config GICV2 So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. This means that Xen would fail on boot without any message as it happens before serial driver initialization. Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. ~Michal From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574973.900637 (Exim 4.92) (envelope-from ) id 1qRCzo-0006px-NU; Wed, 02 Aug 2023 14:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574973.900637; Wed, 02 Aug 2023 14:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzo-0006ms-Hy; Wed, 02 Aug 2023 14:38:40 +0000 Received: by outflank-mailman (input) for mailman id 574973; Wed, 02 Aug 2023 14:38:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzn-0006bO-Pv for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:39 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44f44a64-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:39 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D50094EE0741; Wed, 2 Aug 2023 16:38:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44f44a64-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:08 +0200 Message-Id: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Variable declarations between a switch statement guard and before any case label are unreachable code, and hence violate Rule 2.1: "A project shall not contain unreachable code". Therefore the declarations are moved in the smallest enclosing scope, near other variable definitions. Signed-off-by: Nicola Vetrini --- xen/arch/x86/cpuid.c | 3 +-- xen/arch/x86/domain.c | 23 +++++++++++------------ xen/arch/x86/irq.c | 3 +-- xen/arch/x86/msr.c | 3 +-- 4 files changed, 14 insertions(+), 18 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 455a09b2dd..90e1370e90 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -37,6 +37,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, { const struct domain *d = v->domain; const struct cpu_policy *p = d->arch.cpu_policy; + const struct cpu_user_regs *regs; *res = EMPTY_LEAF; @@ -136,8 +137,6 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, */ switch ( leaf ) { - const struct cpu_user_regs *regs; - case 0x1: /* TODO: Rework topology logic. */ res->b &= 0x00ffffffu; diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 5f66c2ae33..015f7b14ab 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2268,6 +2268,17 @@ int domain_relinquish_resources(struct domain *d) { int ret; struct vcpu *v; + enum { + PROG_iommu_pagetables = 1, + PROG_shared, + PROG_paging, + PROG_vcpu_pagetables, + PROG_xen, + PROG_l4, + PROG_l3, + PROG_l2, + PROG_done, + }; BUG_ON(!cpumask_empty(d->dirty_cpumask)); @@ -2291,18 +2302,6 @@ int domain_relinquish_resources(struct domain *d) #define PROGRESS(x) \ d->arch.rel_priv = PROG_ ## x; /* Fallthrough */ case PROG_ ## x - enum { - PROG_iommu_pagetables = 1, - PROG_shared, - PROG_paging, - PROG_vcpu_pagetables, - PROG_xen, - PROG_l4, - PROG_l3, - PROG_l2, - PROG_done, - }; - case 0: ret = pci_release_devices(d); if ( ret ) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 6abfd81621..4fd0cc163d 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -1135,6 +1135,7 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) struct irq_desc *desc = data; unsigned int i, irq = desc - irq_desc; irq_guest_action_t *action; + cpumask_t *cpu_eoi_map; spin_lock_irq(&desc->lock); @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) switch ( action->ack_type ) { - cpumask_t *cpu_eoi_map; - case ACKTYPE_UNMASK: if ( desc->handler->end ) desc->handler->end(desc, 0); diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index ecf126566d..0e61e0fe4e 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -335,11 +335,10 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) const struct cpu_policy *cp = d->arch.cpu_policy; struct vcpu_msrs *msrs = v->arch.msrs; int ret = X86EMUL_OKAY; + uint64_t rsvd; switch ( msr ) { - uint64_t rsvd; - /* Read-only */ case MSR_IA32_PLATFORM_ID: case MSR_CORE_CAPABILITIES: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574971.900624 (Exim 4.92) (envelope-from ) id 1qRCzo-0006bk-1A; Wed, 02 Aug 2023 14:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574971.900624; Wed, 02 Aug 2023 14:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzn-0006bd-TF; Wed, 02 Aug 2023 14:38:39 +0000 Received: by outflank-mailman (input) for mailman id 574971; Wed, 02 Aug 2023 14:38:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzm-0006bO-3e for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 437097a0-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:36 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 784624EE0737; Wed, 2 Aug 2023 16:38:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 437097a0-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , George Dunlap , Julien Grall , Dario Faggioli Subject: [XEN PATCH 00/11] xen: address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:06 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The headline for Rule 2.1 states: "A project shall not contain unreachable code". Violations of this rule addressed by this patch are caused by two constructs: 1. Declarations inside switch statements, before any clause. This construct is allowed by the language, but is considered unreachable code, since the program execution doesn't ever reach these statements, even though the variables are introduced in the switch block. 2. Code following functions that are not intended to return to the caller or additional statements required by defensive programming practices or other MISRA rules (such as a break to end each switch clause, even if that break is effectively unreachable). (1) is resolved by moving the declarations in an appropriate scope, while (2) is addressed by adding ASSERT_UNREACHABLE() calls to signal that the code below is intentionally unreachable, thus motivating the violation of the rule. --- The approach taken in this series to address the violations is the outcome of a MISRA C group meeting held 25/07/2023. Nicola Vetrini (11): x86/efi: move variable declaration to address MISRA C:2012 Rule 2.1 x86: move declarations to address MISRA C:2012 Rule 2.1 x86/uaccess: move declarations to address MISRA C:2012 Rule 2.1 x86emul: move variable definitions to address MISRA C:2012 Rule 2.1 drivers/pci: move variable definitions to address MISRA C:2012 Rule 2.1 xen/ioreq: move variable declaration to address MISRA C:2012 Rule 2.1 xen: address MISRA C:2012 Rule 2.1 xen: move declarations to address MISRA C:2012 Rule 2.1 x86/xstate: moved BUILD_BUG_ON to address MISRA C:2012 Rule 2.1 xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 x86/mm: Add assertion to address MISRA C:2012 Rule 2.1 xen/arch/x86/cpuid.c | 3 +-- xen/arch/x86/domain.c | 23 +++++++++++------------ xen/arch/x86/efi/efi-boot.h | 5 ++--- xen/arch/x86/hvm/emulate.c | 9 ++++----- xen/arch/x86/hvm/hvm.c | 10 ++++------ xen/arch/x86/include/asm/uaccess.h | 6 ++++-- xen/arch/x86/irq.c | 3 +-- xen/arch/x86/mm.c | 1 + xen/arch/x86/mm/p2m-pod.c | 1 + xen/arch/x86/msr.c | 3 +-- xen/arch/x86/x86_emulate/0f01.c | 7 +++---- xen/arch/x86/x86_emulate/blk.c | 17 ++++++++--------- xen/arch/x86/x86_emulate/decode.c | 3 ++- xen/arch/x86/x86_emulate/fpu.c | 3 +-- xen/arch/x86/x86_emulate/util-xen.c | 4 ++-- xen/arch/x86/x86_emulate/x86_emulate.c | 14 +++++++------- xen/arch/x86/xstate.c | 3 ++- xen/common/compat/memory.c | 3 +-- xen/common/domain.c | 15 +++++++-------- xen/common/ioreq.c | 3 +-- xen/common/sched/core.c | 1 + xen/common/shutdown.c | 18 ++++++++++++------ xen/drivers/passthrough/pci.c | 10 ++++------ 23 files changed, 81 insertions(+), 84 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574974.900654 (Exim 4.92) (envelope-from ) id 1qRCzp-0007KM-TU; Wed, 02 Aug 2023 14:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574974.900654; Wed, 02 Aug 2023 14:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzp-0007J7-PX; Wed, 02 Aug 2023 14:38:41 +0000 Received: by outflank-mailman (input) for mailman id 574974; Wed, 02 Aug 2023 14:38:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzo-0006bO-Px for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:40 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 45699fe4-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:39 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 04B374EE0742; Wed, 2 Aug 2023 16:38:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45699fe4-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 03/11] x86/uaccess: move declarations to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:09 +0200 Message-Id: <6d5e4f307b360393e29641d727ef78b697643f47.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable declarations inside macros {put,get}_unsafe_size are considered unreachable code, as they appear in a switch statement, before any clause. They are moved in the enclosing scope to resolve the violation. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/include/asm/uaccess.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/uaccess.h b/xen/arch/x86/include/asm/uaccess.h index 684fccd95c..a2aaab1e87 100644 --- a/xen/arch/x86/include/asm/uaccess.h +++ b/xen/arch/x86/include/asm/uaccess.h @@ -191,11 +191,12 @@ struct __large_struct { unsigned long buf[100]; }; #define put_unsafe_size(x, ptr, size, grd, retval, errret) \ do { \ + long dummy_; \ + \ retval = 0; \ stac(); \ switch ( size ) \ { \ - long dummy_; \ case 1: \ put_unsafe_asm(x, ptr, grd, retval, "b", "b", "iq", errret); \ break; \ @@ -218,11 +219,12 @@ do { \ #define get_unsafe_size(x, ptr, size, grd, retval, errret) \ do { \ + long dummy_; \ + \ retval = 0; \ stac(); \ switch ( size ) \ { \ - long dummy_; \ case 1: get_unsafe_asm(x, ptr, grd, retval, "b", "=q", errret); break; \ case 2: get_unsafe_asm(x, ptr, grd, retval, "w", "=r", errret); break; \ case 4: get_unsafe_asm(x, ptr, grd, retval, "k", "=r", errret); break; \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574972.900629 (Exim 4.92) (envelope-from ) id 1qRCzo-0006eR-9z; Wed, 02 Aug 2023 14:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574972.900629; Wed, 02 Aug 2023 14:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzo-0006dO-4Z; Wed, 02 Aug 2023 14:38:40 +0000 Received: by outflank-mailman (input) for mailman id 574972; Wed, 02 Aug 2023 14:38:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzm-0006bO-Pb for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 444042f5-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:37 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 4A5D14EE0740; Wed, 2 Aug 2023 16:38:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 444042f5-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 01/11] x86/efi: move variable declaration to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:07 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable declaration is moved where it's actually used, rather than being declared in the switch before any clause, thus being classified as unreachable code. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/efi/efi-boot.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 92f4cfe8bd..b00441b1a2 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -390,8 +390,6 @@ static void __init efi_arch_edd(void) { switch ( DevicePathType(devp.DevPath) ) { - const u8 *p; - case ACPI_DEVICE_PATH: if ( state != root || boot_edd_info_nr > EDD_INFO_MAX ) break; @@ -463,7 +461,8 @@ static void __init efi_arch_edd(void) params->device_path_info_length = sizeof(struct edd_device_params) - offsetof(struct edd_device_params, key); - for ( p = (const u8 *)¶ms->key; p < ¶ms->checksum; ++p ) + for ( const u8 *p = (const u8 *)¶ms->key; + p < ¶ms->checksum; ++p ) params->checksum -= *p; break; case MEDIA_DEVICE_PATH: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574975.900663 (Exim 4.92) (envelope-from ) id 1qRCzs-0007d3-4K; Wed, 02 Aug 2023 14:38:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574975.900663; Wed, 02 Aug 2023 14:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzs-0007cn-0n; Wed, 02 Aug 2023 14:38:44 +0000 Received: by outflank-mailman (input) for mailman id 574975; Wed, 02 Aug 2023 14:38:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzp-0006bO-WE for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 465e692a-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:41 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 978C14EE0744; Wed, 2 Aug 2023 16:38:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 465e692a-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 05/11] drivers/pci: move variable definitions to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:11 +0200 Message-Id: <99f434f5d8b9c8eca275f23799a642ba34e79eb8.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Variable declarations between a switch statement guard and before any case label are unreachable code, and hence violate Rule 2.1: "A project shall not contain unreachable code". Therefore the variable declarations are moved in the smallest enclosing scope, near other variable definitions. Signed-off-by: Nicola Vetrini --- xen/drivers/passthrough/pci.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 33452791a8..3f5fa5beef 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -315,6 +315,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) struct pci_dev *pdev; unsigned int pos; int rc; + unsigned int cap, sec_bus, sub_bus; list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list ) if ( pdev->bus == bus && pdev->devfn == devfn ) @@ -343,8 +344,6 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) /* update bus2bridge */ switch ( pdev->type = pdev_type(pseg->nr, bus, devfn) ) { - unsigned int cap, sec_bus, sub_bus; - case DEV_TYPE_PCIe2PCI_BRIDGE: case DEV_TYPE_LEGACY_PCI_BRIDGE: sec_bus = pci_conf_read8(pdev->sbdf, PCI_SECONDARY_BUS); @@ -424,11 +423,11 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) static void free_pdev(struct pci_seg *pseg, struct pci_dev *pdev) { + unsigned int sec_bus, sub_bus; + /* update bus2bridge */ switch ( pdev->type ) { - unsigned int sec_bus, sub_bus; - case DEV_TYPE_PCIe2PCI_BRIDGE: case DEV_TYPE_LEGACY_PCI_BRIDGE: sec_bus = pci_conf_read8(pdev->sbdf, PCI_SECONDARY_BUS); @@ -1555,11 +1554,10 @@ int iommu_do_pci_domctl( u8 bus, devfn; int ret = 0; uint32_t machine_sbdf; + unsigned int flags; switch ( domctl->cmd ) { - unsigned int flags; - case XEN_DOMCTL_get_device_group: { u32 max_sdevs; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574976.900670 (Exim 4.92) (envelope-from ) id 1qRCzs-0007gH-Kn; Wed, 02 Aug 2023 14:38:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574976.900670; Wed, 02 Aug 2023 14:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzs-0007fA-BK; Wed, 02 Aug 2023 14:38:44 +0000 Received: by outflank-mailman (input) for mailman id 574976; Wed, 02 Aug 2023 14:38:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzq-0006bO-QF for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46b8c10b-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:42 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 5E2AE4EE0745; Wed, 2 Aug 2023 16:38:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46b8c10b-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Paul Durrant Subject: [XEN PATCH 06/11] xen/ioreq: move variable declaration to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:12 +0200 Message-Id: <587d42fef7a0fc3fb3e7e5ef3deed6617b84cf03.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Variable declarations between a switch statement guard and before any case label are unreachable code, and hence violate Rule 2.1: "A project shall not contain unreachable code". Therefore the variable declarations are moved in the smallest enclosing scope, near other variable definitions. Signed-off-by: Nicola Vetrini --- xen/common/ioreq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index 7cb717f7a2..5044f43b81 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -1111,6 +1111,7 @@ struct ioreq_server *ioreq_server_select(struct domain *d, FOR_EACH_IOREQ_SERVER(d, id, s) { struct rangeset *r; + unsigned long start, end; if ( !s->enabled ) continue; @@ -1119,8 +1120,6 @@ struct ioreq_server *ioreq_server_select(struct domain *d, switch ( type ) { - unsigned long start, end; - case XEN_DMOP_IO_RANGE_PORT: start = addr; end = start + p->size - 1; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574977.900676 (Exim 4.92) (envelope-from ) id 1qRCzt-0007nI-09; Wed, 02 Aug 2023 14:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574977.900676; Wed, 02 Aug 2023 14:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzs-0007ly-OA; Wed, 02 Aug 2023 14:38:44 +0000 Received: by outflank-mailman (input) for mailman id 574977; Wed, 02 Aug 2023 14:38:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzr-0007ap-7l for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 45e7e813-3142-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 16:38:40 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id BFDC64EE0743; Wed, 2 Aug 2023 16:38:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45e7e813-3142-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 04/11] x86emul: move variable definitions to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:10 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Variable declarations between a switch statement guard and before any case label are unreachable code, and hence violate Rule 2.1: "A project shall not contain unreachable code". Therefore the variable declarations are moved in the only clause scope that uses it. Signed-off-by: Nicola Vetrini --- xen/arch/x86/hvm/emulate.c | 9 ++++----- xen/arch/x86/hvm/hvm.c | 10 ++++------ xen/arch/x86/x86_emulate/0f01.c | 7 +++---- xen/arch/x86/x86_emulate/blk.c | 17 ++++++++--------- xen/arch/x86/x86_emulate/decode.c | 3 ++- xen/arch/x86/x86_emulate/fpu.c | 3 +-- xen/arch/x86/x86_emulate/util-xen.c | 4 ++-- xen/arch/x86/x86_emulate/x86_emulate.c | 14 +++++++------- 8 files changed, 31 insertions(+), 36 deletions(-) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 75ee98a73b..2261e8655b 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -1994,6 +1994,7 @@ static int cf_check hvmemul_rep_stos( bool_t df = !!(ctxt->regs->eflags & X86_EFLAGS_DF); int rc = hvmemul_virtual_to_linear(seg, offset, bytes_per_rep, reps, hvm_access_write, hvmemul_ctxt, &addr); + char *buf; if ( rc != X86EMUL_OKAY ) return rc; @@ -2025,7 +2026,6 @@ static int cf_check hvmemul_rep_stos( switch ( p2mt ) { unsigned long bytes; - char *buf; default: /* Allocate temporary buffer. */ @@ -2289,16 +2289,15 @@ static int cf_check hvmemul_cache_op( struct hvm_emulate_ctxt *hvmemul_ctxt = container_of(ctxt, struct hvm_emulate_ctxt, ctxt); uint32_t pfec = PFEC_page_present; + unsigned long addr; + int rc; + void *mapping; if ( !cache_flush_permitted(current->domain) ) return X86EMUL_OKAY; switch ( op ) { - unsigned long addr; - int rc; - void *mapping; - case x86emul_clflush: case x86emul_clflushopt: case x86emul_clwb: diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 2180abeb33..4170343b34 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -1494,10 +1494,10 @@ static int cf_check hvm_load_cpu_msrs(struct domain *d, hvm_domain_context_t *h) for ( i = 0; i < ctxt->count; ++i ) { + int rc; + switch ( ctxt->msr[i].index ) { - int rc; - case MSR_SPEC_CTRL: case MSR_INTEL_MISC_FEATURES_ENABLES: case MSR_PKRS: @@ -3522,6 +3522,7 @@ int hvm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) struct domain *d = v->domain; uint64_t *var_range_base, *fixed_range_base; int ret; + unsigned int index; var_range_base = (uint64_t *)v->arch.hvm.mtrr.var_ranges; fixed_range_base = (uint64_t *)v->arch.hvm.mtrr.fixed_ranges; @@ -3533,8 +3534,6 @@ int hvm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) switch ( msr ) { - unsigned int index; - case MSR_EFER: *msr_content = v->arch.hvm.guest_efer; break; @@ -3636,6 +3635,7 @@ int hvm_msr_write_intercept(unsigned int msr, uint64_t msr_content, struct vcpu *v = current; struct domain *d = v->domain; int ret; + unsigned int index; HVMTRACE_3D(MSR_WRITE, msr, (uint32_t)msr_content, (uint32_t)(msr_content >> 32)); @@ -3668,8 +3668,6 @@ int hvm_msr_write_intercept(unsigned int msr, uint64_t msr_content, switch ( msr ) { - unsigned int index; - case MSR_EFER: if ( hvm_set_efer(msr_content) ) return X86EMUL_EXCEPTION; diff --git a/xen/arch/x86/x86_emulate/0f01.c b/xen/arch/x86/x86_emulate/0f01.c index ba43fc394b..22a14b12c3 100644 --- a/xen/arch/x86/x86_emulate/0f01.c +++ b/xen/arch/x86/x86_emulate/0f01.c @@ -24,13 +24,12 @@ int x86emul_0f01(struct x86_emulate_state *s, { enum x86_segment seg = (s->modrm_reg & 1) ? x86_seg_idtr : x86_seg_gdtr; int rc; + unsigned long base, limit, cr0, cr0w, cr4; + struct segment_register sreg; + uint64_t msr_val; switch ( s->modrm ) { - unsigned long base, limit, cr0, cr0w, cr4; - struct segment_register sreg; - uint64_t msr_val; - case 0xc6: switch ( s->vex.pfx ) { diff --git a/xen/arch/x86/x86_emulate/blk.c b/xen/arch/x86/x86_emulate/blk.c index e790f4f900..f2956c0d52 100644 --- a/xen/arch/x86/x86_emulate/blk.c +++ b/xen/arch/x86/x86_emulate/blk.c @@ -26,19 +26,18 @@ int x86_emul_blk( struct x86_emulate_ctxt *ctxt) { int rc = X86EMUL_OKAY; - - switch ( s->blk ) - { - bool zf; + bool zf; #ifndef X86EMUL_NO_FPU + struct { + struct x87_env32 env; struct { - struct x87_env32 env; - struct { - uint8_t bytes[10]; - } freg[8]; - } fpstate; + uint8_t bytes[10]; + } freg[8]; + } fpstate; #endif + switch ( s->blk ) + { /* * Throughout this switch(), memory clobbers are used to compensate * that other operands may not properly express the (full) memory diff --git a/xen/arch/x86/x86_emulate/decode.c b/xen/arch/x86/x86_emulate/decode.c index f58ca3984e..daebf3a9bd 100644 --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -1758,9 +1758,9 @@ int x86emul_decode(struct x86_emulate_state *s, /* Fetch the immediate operand, if present. */ switch ( d & SrcMask ) { + case SrcImm: { unsigned int bytes; - case SrcImm: if ( !(d & ByteOp) ) { if ( mode_64bit() && !amd_like(ctxt) && @@ -1785,6 +1785,7 @@ int x86emul_decode(struct x86_emulate_state *s, case SrcImm16: s->imm1 = insn_fetch_type(uint16_t); break; + } } ctxt->opcode = opcode; diff --git a/xen/arch/x86/x86_emulate/fpu.c b/xen/arch/x86/x86_emulate/fpu.c index 480d879657..002d5e1253 100644 --- a/xen/arch/x86/x86_emulate/fpu.c +++ b/xen/arch/x86/x86_emulate/fpu.c @@ -84,11 +84,10 @@ int x86emul_fpu(struct x86_emulate_state *s, uint8_t b; int rc; struct x86_emulate_stub stub = {}; + unsigned long dummy; switch ( b = ctxt->opcode ) { - unsigned long dummy; - case 0x9b: /* wait/fwait */ host_and_vcpu_must_have(fpu); get_fpu(X86EMUL_FPU_wait); diff --git a/xen/arch/x86/x86_emulate/util-xen.c b/xen/arch/x86/x86_emulate/util-xen.c index 5e90818010..7ab2ac712f 100644 --- a/xen/arch/x86/x86_emulate/util-xen.c +++ b/xen/arch/x86/x86_emulate/util-xen.c @@ -77,10 +77,10 @@ bool cf_check x86_insn_is_portio(const struct x86_emulate_state *s, bool cf_check x86_insn_is_cr_access(const struct x86_emulate_state *s, const struct x86_emulate_ctxt *ctxt) { + unsigned int ext; + switch ( ctxt->opcode ) { - unsigned int ext; - case X86EMUL_OPC(0x0f, 0x01): if ( x86_insn_modrm(s, NULL, &ext) >= 0 && (ext & 5) == 4 ) /* SMSW / LMSW */ diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index e88245eae9..d6c04fd5f3 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -1479,15 +1479,15 @@ x86_emulate( break; } + enum x86_segment seg; + struct segment_register cs, sreg; + struct cpuid_leaf leaf; + uint64_t msr_val; + unsigned int i, n; + unsigned long dummy; + switch ( ctxt->opcode ) { - enum x86_segment seg; - struct segment_register cs, sreg; - struct cpuid_leaf leaf; - uint64_t msr_val; - unsigned int i, n; - unsigned long dummy; - case 0x00: case 0x01: add: /* add reg,mem */ if ( ops->rmw && dst.type == OP_MEM ) state->rmw = rmw_add; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574978.900680 (Exim 4.92) (envelope-from ) id 1qRCzt-0007yB-FC; Wed, 02 Aug 2023 14:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574978.900680; Wed, 02 Aug 2023 14:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzt-0007vk-7n; Wed, 02 Aug 2023 14:38:45 +0000 Received: by outflank-mailman (input) for mailman id 574978; Wed, 02 Aug 2023 14:38:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzr-0006bO-QZ for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 473a13cb-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:42 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id EE2194EE073F; Wed, 2 Aug 2023 16:38:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 473a13cb-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:13 +0200 Message-Id: <7f8cbd8c8ad64cd3a0d099f31cb4d3fad48aa63b.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rule 2.1 states: "A project shall not contain unreachable code". The functions - machine_halt - maybe_reboot - machine_restart are not supposed to return, hence the following break statement is marked as intentionally unreachable with the ASSERT_UNREACHABLE() macro to justify the violation of the rule. Signed-off-by: Nicola Vetrini --- xen/common/shutdown.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/xen/common/shutdown.c b/xen/common/shutdown.c index a933ee001e..88f735a30e 100644 --- a/xen/common/shutdown.c +++ b/xen/common/shutdown.c @@ -38,39 +38,45 @@ void hwdom_shutdown(u8 reason) printk("Hardware Dom%u halted: halting machine\n", hardware_domain->domain_id); machine_halt(); - break; /* not reached */ + ASSERT_UNREACHABLE(); + break; case SHUTDOWN_crash: debugger_trap_immediate(); printk("Hardware Dom%u crashed: ", hardware_domain->domain_id); kexec_crash(CRASHREASON_HWDOM); maybe_reboot(); - break; /* not reached */ + ASSERT_UNREACHABLE(); + break; case SHUTDOWN_reboot: printk("Hardware Dom%u shutdown: rebooting machine\n", hardware_domain->domain_id); machine_restart(0); - break; /* not reached */ + ASSERT_UNREACHABLE(); + break; case SHUTDOWN_watchdog: printk("Hardware Dom%u shutdown: watchdog rebooting machine\n", hardware_domain->domain_id); kexec_crash(CRASHREASON_WATCHDOG); machine_restart(0); - break; /* not reached */ + ASSERT_UNREACHABLE(); + break; case SHUTDOWN_soft_reset: printk("Hardware domain %d did unsupported soft reset, rebooting.\n", hardware_domain->domain_id); machine_restart(0); - break; /* not reached */ + ASSERT_UNREACHABLE(); + break; default: printk("Hardware Dom%u shutdown (unknown reason %u): ", hardware_domain->domain_id, reason); maybe_reboot(); - break; /* not reached */ + ASSERT_UNREACHABLE(); + break; } } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574980.900702 (Exim 4.92) (envelope-from ) id 1qRCzv-00009w-Bd; Wed, 02 Aug 2023 14:38:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574980.900702; Wed, 02 Aug 2023 14:38:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzv-00007s-4D; Wed, 02 Aug 2023 14:38:47 +0000 Received: by outflank-mailman (input) for mailman id 574980; Wed, 02 Aug 2023 14:38:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzt-0006bO-Hd for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4884aa7a-3142-11ee-b260-6b7b168915f2; Wed, 02 Aug 2023 16:38:45 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 519DB4EE0746; Wed, 2 Aug 2023 16:38:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4884aa7a-3142-11ee-b260-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , George Dunlap , Dario Faggioli Subject: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:16 +0200 Message-Id: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The break statement after the return statement is definitely unreachable. As such, an call to the ASSERT_UNREACHABLE() macro is added to signal the intentionality of such construct. Signed-off-by: Nicola Vetrini --- The break in the clause is mandated by Required Rule 16.3, which is not yet an accepted rule for Xen, but may be in the future. --- xen/common/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 022f548652..fcee902b4e 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) /* fallthrough */ case TASKLET_enqueued|TASKLET_scheduled: return true; + ASSERT_UNREACHABLE(); break; case TASKLET_scheduled: clear_bit(_TASKLET_scheduled, tasklet_work); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574979.900708 (Exim 4.92) (envelope-from ) id 1qRCzv-0000Fe-UB; Wed, 02 Aug 2023 14:38:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574979.900708; Wed, 02 Aug 2023 14:38:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzv-0000Dx-Fv; Wed, 02 Aug 2023 14:38:47 +0000 Received: by outflank-mailman (input) for mailman id 574979; Wed, 02 Aug 2023 14:38:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzt-0007ap-7L for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47b43c9a-3142-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 16:38:43 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id C89704EE0740; Wed, 2 Aug 2023 16:38:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47b43c9a-3142-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 08/11] xen: move declarations to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:14 +0200 Message-Id: <055dce166662183c68fb488fa7f7722a3a5fcd98.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Declarations between a switch statement guard and before any case label are unreachable code, and hence violate Rule 2.1: "A project shall not contain unreachable code". Therefore the variable declarations are moved in the smallest enclosing scope, near other variable definitions. Signed-off-by: Nicola Vetrini --- xen/common/compat/memory.c | 3 +-- xen/common/domain.c | 15 +++++++-------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/xen/common/compat/memory.c b/xen/common/compat/memory.c index 8ca63ceda6..d4c4204119 100644 --- a/xen/common/compat/memory.c +++ b/xen/common/compat/memory.c @@ -85,13 +85,12 @@ int compat_memory_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) compat) struct compat_mem_access_op mao; struct compat_mem_acquire_resource mar; } cmp; + xen_pfn_t *space; set_xen_guest_handle(nat.hnd, COMPAT_ARG_XLAT_VIRT_BASE); split = 0; switch ( op ) { - xen_pfn_t *space; - case XENMEM_increase_reservation: case XENMEM_decrease_reservation: case XENMEM_populate_physmap: diff --git a/xen/common/domain.c b/xen/common/domain.c index 304aa04fa6..e3aeaf059d 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -401,6 +401,13 @@ static int domain_teardown(struct domain *d) { struct vcpu *v; int rc; + enum { + PROG_none, + PROG_gnttab_mappings, + PROG_vcpu_teardown, + PROG_arch_teardown, + PROG_done, + }; BUG_ON(!d->is_dying); @@ -435,14 +442,6 @@ static int domain_teardown(struct domain *d) case PROG_vcpu_ ## x: \ v = d->teardown.vcpu - enum { - PROG_none, - PROG_gnttab_mappings, - PROG_vcpu_teardown, - PROG_arch_teardown, - PROG_done, - }; - case PROG_none: BUILD_BUG_ON(PROG_none != 0); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574981.900712 (Exim 4.92) (envelope-from ) id 1qRCzw-0000Kk-8t; Wed, 02 Aug 2023 14:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574981.900712; Wed, 02 Aug 2023 14:38:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzv-0000J0-Sz; Wed, 02 Aug 2023 14:38:47 +0000 Received: by outflank-mailman (input) for mailman id 574981; Wed, 02 Aug 2023 14:38:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzt-0007ap-U6 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48220271-3142-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 16:38:44 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 95DD24EE0742; Wed, 2 Aug 2023 16:38:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48220271-3142-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 09/11] x86/xstate: moved BUILD_BUG_ON to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:15 +0200 Message-Id: <4cdcd0a9f99109463686420d6c3fc6681d215d99.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Variable declarations between a switch statement guard and before any case label are unreachable code, and hence violate Rule 2.1: "A project shall not contain unreachable code". Therefore the variable declarations are moved in the smallest enclosing scope, near other variable definitions. Signed-off-by: Nicola Vetrini --- xen/arch/x86/xstate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 92496f3795..cb2b9e720c 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -396,9 +396,10 @@ void xrstor(struct vcpu *v, uint64_t mask) */ for ( prev_faults = faults = 0; ; prev_faults = faults ) { + BUILD_BUG_ON(sizeof(faults) != 4); /* Clang doesn't support %z in asm. */ + switch ( __builtin_expect(ptr->fpu_sse.x[FPU_WORD_SIZE_OFFSET], 8) ) { - BUILD_BUG_ON(sizeof(faults) != 4); /* Clang doesn't support %z in asm. */ #define _xrstor(insn) \ asm volatile ( "1: .byte " insn "\n" \ "3:\n" \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:38:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.574982.900728 (Exim 4.92) (envelope-from ) id 1qRCzx-0000y3-Vj; Wed, 02 Aug 2023 14:38:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 574982.900728; Wed, 02 Aug 2023 14:38:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzx-0000vx-Kp; Wed, 02 Aug 2023 14:38:49 +0000 Received: by outflank-mailman (input) for mailman id 574982; Wed, 02 Aug 2023 14:38:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRCzv-0007ap-E4 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:38:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4900c027-3142-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 16:38:45 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id F2D134EE0747; Wed, 2 Aug 2023 16:38:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4900c027-3142-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap Subject: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1 Date: Wed, 2 Aug 2023 16:38:17 +0200 Message-Id: <91b2f2c9e728c1f19f7baab301299d995a074279.1690985045.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ASSERT_UNREACHABLE() assertion is added before a definitely unreachable return statement to address MISRA C:2012 Rule 2.1, because the explicit return from a non-void function is a defensive coding measure, and thus intended to be unreachable. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/mm.c | 1 + xen/arch/x86/mm/p2m-pod.c | 1 + 2 files changed, 2 insertions(+) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index be2b10a391..ebd4f3827a 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) return subarch_memory_op(cmd, arg); } + ASSERT_UNREACHABLE(); return 0; } diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index 9969eb45fa..cd5501217f 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const gfn_t *gfns, unsigned int count } return; + ASSERT_UNREACHABLE(); out_unmap: /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:43:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:43:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575007.900744 (Exim 4.92) (envelope-from ) id 1qRD4B-0005kB-Ep; Wed, 02 Aug 2023 14:43:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575007.900744; Wed, 02 Aug 2023 14:43:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD4B-0005k4-CD; Wed, 02 Aug 2023 14:43:11 +0000 Received: by outflank-mailman (input) for mailman id 575007; Wed, 02 Aug 2023 14:43:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD4A-0005ju-Ha; Wed, 02 Aug 2023 14:43:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD4A-000480-Bl; Wed, 02 Aug 2023 14:43:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD49-0007at-QU; Wed, 02 Aug 2023 14:43:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRD49-0001EQ-Pq; Wed, 02 Aug 2023 14:43:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u2Piyq9SZRJ88ivwyRjoHVgJQI/01i9aGzgHVMqXNPo=; b=oie3te2etrlngw1ljuE8VxW5z7 uLteLa4GnkPQUTmy2SosYxkbxg0Ri18n+f+c8ypAGqKXGW2G9Kpo2Rfi+WJ+JQ7gF5LgemHxN/LnH lXm0pKYR8Uc+/uBJ5poHUHXSwY96hrqEoUQMARKkQ1X/XSZr9HE46M5sCIh4EQi1AE1M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 182110: regressions - trouble: fail/pass/starved X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:regression xen-4.17-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:build-arm64:hosts-allocate:starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking xen-4.17-testing:build-arm64-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=3d0aa6f23d54a4d3c608010c58c1147a1500d865 X-Osstest-Versions-That: xen=c18b2dd93f396eadd116d0016cf7285523a13505 From: osstest service owner Date: Wed, 02 Aug 2023 14:43:09 +0000 flight 182110 xen-4.17-testing real [real] flight 182117 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182110/ http://logs.test-lab.xenproject.org/osstest/logs/182117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-migrupgrade 11 xen-install/dst_host fail REGR. vs. 182095 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 182117-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182095 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182095 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182095 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182095 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182095 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 1 build-check(1) starved n/a build-arm64-libvirt 1 build-check(1) starved n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved n/a test-arm64-arm64-xl 1 build-check(1) starved n/a test-arm64-arm64-xl-credit1 1 build-check(1) starved n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved n/a test-armhf-armhf-libvirt-raw 3 hosts-allocate starved n/a build-arm64 2 hosts-allocate starved n/a build-arm64-pvops 2 hosts-allocate starved n/a build-arm64-xsm 2 hosts-allocate starved n/a test-armhf-armhf-libvirt 3 hosts-allocate starved n/a test-armhf-armhf-libvirt-qcow2 3 hosts-allocate starved n/a test-armhf-armhf-xl-vhd 3 hosts-allocate starved n/a test-armhf-armhf-xl 3 hosts-allocate starved n/a test-armhf-armhf-xl-arndale 3 hosts-allocate starved n/a test-armhf-armhf-xl-credit1 3 hosts-allocate starved n/a test-armhf-armhf-xl-multivcpu 3 hosts-allocate starved n/a test-armhf-armhf-xl-rtds 3 hosts-allocate starved n/a test-armhf-armhf-xl-credit2 3 hosts-allocate starved n/a version targeted for testing: xen 3d0aa6f23d54a4d3c608010c58c1147a1500d865 baseline version: xen c18b2dd93f396eadd116d0016cf7285523a13505 Last test of basis 182095 2023-07-31 13:07:46 Z 2 days Testing same since 182110 2023-08-02 06:56:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Luca Fancellu Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm starved build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 starved build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt starved build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops starved build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale starved test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 3d0aa6f23d54a4d3c608010c58c1147a1500d865 Author: Luca Fancellu Date: Mon Jul 17 13:25:46 2023 +0100 xen/arm: Add Cortex-A77 erratum 1508412 handling Cortex-A77 cores (r0p0, r1p0) could deadlock on a sequence of a store-exclusive or read of PAR_EL1 and a load with device or non-cacheable memory attributes. A workaround is available, but it depends on a firmware counterpart. The proposed workaround from the errata document is to modify the software running at EL1 and above to include a DMB SY before and after accessing PAR_EL1. In conjunction to the above, the firmware needs to use a specific write sequence to several IMPLEMENTATION DEFINED registers to have the hardware insert a DMB SY after all load-exclusive and store-exclusive instructions. Apply the workaround to Xen where PAR_EL1 is read, implementing an helper function to do that. Since Xen can be interrupted by irqs in any moment, add a barrier on entry/exit when we are running on the affected cores. A guest without the workaround can deadlock the system, so warn the users of Xen with the above type of cores to use only trusted guests, by printing a message on Xen startup. This is XSA-436 / CVE-2023-34320. Signed-off-by: Luca Fancellu [stefano: add XSA-436 to commit message] Signed-off-by: Stefano Stabellini Reviewed-by: Bertrand Marquis Reviewed-by: Julien Grall (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:43:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575012.900753 (Exim 4.92) (envelope-from ) id 1qRD4g-0006Gf-S5; Wed, 02 Aug 2023 14:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575012.900753; Wed, 02 Aug 2023 14:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD4g-0006GY-PD; Wed, 02 Aug 2023 14:43:42 +0000 Received: by outflank-mailman (input) for mailman id 575012; Wed, 02 Aug 2023 14:43:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD4f-00067Z-Cf for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:43:41 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f87db47f-3142-11ee-b261-6b7b168915f2; Wed, 02 Aug 2023 16:43:40 +0200 (CEST) Received: from DUZPR01CA0208.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::6) by PAVPR08MB9187.eurprd08.prod.outlook.com (2603:10a6:102:30b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 14:43:06 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b6:cafe::1f) by DUZPR01CA0208.outlook.office365.com (2603:10a6:10:4b6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 14:43:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 14:43:06 +0000 Received: ("Tessian outbound e1fdbe8a48d3:v145"); Wed, 02 Aug 2023 14:43:06 +0000 Received: from e1c22c1a775c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 48748ED1-619D-419B-B29F-09B0C87E4012.1; Wed, 02 Aug 2023 14:42:56 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e1c22c1a775c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Aug 2023 14:42:56 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DBBPR08MB6298.eurprd08.prod.outlook.com (2603:10a6:10:1f7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 14:42:53 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 14:42:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f87db47f-3142-11ee-b261-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8rPRUL91NEXqFBgvQIvumIDzFRaE95Z0bjyHtDytK4=; b=qAvfpETCC3pYqW8j2+lV6tNZB+ZkrmUxbbjTvCne+gpBwDuhe5EO2lSs/+Zo5tZFrP3r+iMlal+mxhrPmgJetUkUZR1tNli4k9c+cbnA2BeDdAZPy9elXtzeuinNRfvogOZkAiC3icUjUUjq3oU22z/4ufVi3i6DQGRgDGK1+pk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5501f7eec9eea79d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oejz501g3Feek8NzGhNDM3XNvWeVf79TlZHXH1HfZtJXQ1LUwj1FpcMnGFfoLbYwnJrHQ1Z29TF515oA2cvB0yH4zX2bQYlvfPUdt8hbKfgjmPvKMx2C8OZUSkxbGf6VlRiJQHxg36wm0oj0ld64535PAdcOmQAAyOAPBwY/UfJuEEGKbKN1bmHBacSHqp7p44m7Agix/KM6Wgsj62rtJHyKXTcmnqFLN0arqD4p+taQY1LTKIA0ya020GgKwYNcxPGyr2UqVgrZMFARvF1lpFS8bViGGI5MA/RVrt1VFM0pMd4m2zo/Z3MlEoh3YCXb84Pore1eijAGlgNjVtFcKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x8rPRUL91NEXqFBgvQIvumIDzFRaE95Z0bjyHtDytK4=; b=jN05A8FeeIKvajFMWYBgBe3J0c6rSD8r6PrcgVBEg23E6mV9p37X/JP0JroZLS7+pdGWrxAZth34ppN4zyFYoekV2hJU7lPYvA1XtMC1MITz/wZnH1ZQtrFpKUepIsrGfUQtqg6hlfZRMp/8WrloopQVF99u9UQFTRa4ZLtExK/lAcIeM7++1O+hdu5zvETL8fDBSUS0D3wMegGoXoQ6vkft54+aWZXhVXb4trireTUoqlG4XKKKahSfBXaOKcGFKIFExnTmbjJNrpLGwUN/F0EKW5zERb7cFF8OlYAcM8NwfiKrMia2hk3iXUJxOSRPV91t2mxITEugr4w72zFg7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8rPRUL91NEXqFBgvQIvumIDzFRaE95Z0bjyHtDytK4=; b=qAvfpETCC3pYqW8j2+lV6tNZB+ZkrmUxbbjTvCne+gpBwDuhe5EO2lSs/+Zo5tZFrP3r+iMlal+mxhrPmgJetUkUZR1tNli4k9c+cbnA2BeDdAZPy9elXtzeuinNRfvogOZkAiC3icUjUUjq3oU22z/4ufVi3i6DQGRgDGK1+pk= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/XEDgAgAAEZQA= Date: Wed, 2 Aug 2023 14:42:53 +0000 Message-ID: <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> In-Reply-To: <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DBBPR08MB6298:EE_|DBAEUR03FT060:EE_|PAVPR08MB9187:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e5128f7-8698-4488-9779-08db9366c8cc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Fh9xQdUu/4BtIn2iFG5OTuWMlD5Ge/pO7jN1+kmOpZGN/KKoSdMXO6Ou9Jx2kXTuqzI8JtOcYmDVFJoOJ+h0Naq7B8xgwtOdjg0pX4sFG0LtfDa/+mNbNyyRp+DovvSsSsS7J4LCcdrrIUMS9AeW1ME/QBlkkbu9X2R8mbVT/mUd83sSJ6cHBsbwLB6LoA2HDUT68T9tOuSLx4MsivnwDSTvtwp7pmTlr79lZa/wuY+SmU9NnSs5cqGijDcC9X6y+1FQ3mFHiDJPkdZ5aojxGEnxYEVdPSGzJf56xYBe/kwc9jPa7INAb/BSY1tV7FzIJWjrHx4/3h0yFf5y7pjMzEDwhb6bgWyQ72ZA43NnqV1PY+6SIn/5cRxXzhKojHUed46GYso0QASuOzTZUZA3+mOkYBNMqw6htc3cp4HRbiBiQNKry5zxI6bwbAOEtzTpdRAu3Gn6O5/+W5g6BbsnZP/bDihaZ/Ul1BlnzAPk07saHH5JQA2wenpGp5J2K60yRCCGvXsOVRJjZKI5aax/XFqBMggOA52JukHwPEFEE8riHcG0D5AW3/GegXK0vOig9iTGrTqt2yOpaoWYJtIz3Zl/OZuOt7YGL9ApHYe/23M1XDyMSOUcBKoXNMX8VMl9maHLBcicffz+vWfpPXYewg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(451199021)(66899021)(2616005)(5660300002)(36756003)(38070700005)(122000001)(38100700002)(2906002)(33656002)(83380400001)(478600001)(26005)(186003)(53546011)(6506007)(8936002)(8676002)(6512007)(41300700001)(71200400001)(6486002)(86362001)(54906003)(6916009)(66946007)(66556008)(66476007)(91956017)(76116006)(66446008)(4326008)(64756008)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6298 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a46ba5e4-2990-41e7-c7ad-08db9366c0ee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x0NfPCacsR6Ht8no/D1FNp4n71owBR+mWru4B0Ftzv7/J1eGCbv13+3kSKDkMOddvC/+E9b26G19/Pi7AnigcT427MNehRoezzfWSgp4gBmgIeJ/vncWCcHxXFGq+3fpGz1gwNl+5SBoXuwIvdNegAyIObwzbgVOzaHXFTB28OMq7EFDamKyYrMTXVZZBjKERwBMVnJqdOxLzN4gP7NlZ0O697WPAa9QRrKU1X+SZflhL0CVRlvSKD2jjZZl4lRct7yMzRNylr7pWhKDEfxvt6NqHNl2T/O5LI+RPASBwySUgdhhhT6AU/2mEj0XypvbtigRAVrjb7LzXClPlVduOXdEAUzcP1xk6fJfJCu7tbuox5w8MUIBqn5xEp+r0HxEvbMqqFXSE8G755syDJOAFdCfhJ6t2SZhNtyowfvBT9NE1HuUkojeNNEctW73nDUF5+bbaa9LZwNQ20UJ4lctVGh9sk7gppxM5DFRQN4eC3GaZns5RJj8LwV8uO+CG8IBkrDnCfMNKSNWvpCdxdUA5zdOUIGJZCZh9m+q85i8kjp56Hc4CEkn24i1ZzjfzjHmscXVYCdr3TxPz0O4zYKgrqqyQxUNh0c0BJzv4qbCCGWwoLJgMx4Pq+Mw2pMUw54dO8aPt/dukjRliWCvdPEnhaBRW0kV29L1baFqXAEH32CNdLpPNDbhESfezcqSUyVd0NIkf3LDyD6Dd097IXIP6Y6yZi9yzbT52tWb6/3X5eRM4G9k3BaS5ukWceRuJ9Ru X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39850400004)(346002)(396003)(136003)(376002)(82310400008)(451199021)(40470700004)(36840700001)(46966006)(6862004)(8676002)(5660300002)(41300700001)(107886003)(66899021)(2906002)(8936002)(83380400001)(47076005)(36860700001)(40460700003)(2616005)(40480700001)(186003)(336012)(86362001)(81166007)(478600001)(54906003)(316002)(53546011)(82740400003)(26005)(6506007)(33656002)(356005)(70586007)(70206006)(6486002)(4326008)(6512007)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:43:06.7699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e5128f7-8698-4488-9779-08db9366c8cc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9187 DQoNCj4gT24gMiBBdWcgMjAyMywgYXQgMTU6MjYsIE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs QGFtZC5jb20+IHdyb3RlOg0KPiANCj4gSGkgTHVjYSwNCj4gDQo+IE9uIDAyLzA4LzIwMjMgMTU6 NTMsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+PiANCj4+IA0KPj4gSW50cm9kdWNlIEtjb25maWcg R0lDVjIgdG8gYmUgYWJsZSB0byBjb21waWxlIHRoZSBHSUN2MiBkcml2ZXIgb25seQ0KPj4gd2hl biBuZWVkZWQsIHRoZSBvcHRpb24gaXMgYWN0aXZlIGJ5IGRlZmF1bHQuDQo+PiANCj4+IEludHJv ZHVjZSBLY29uZmlnIFZHSUNWMiB0aGF0IGRlcGVuZHMgb24gR0lDVjIgb3IgR0lDVjMgYW5kIGNv bXBpbGVzDQo+PiB0aGUgR0lDdjIgZW11bGF0aW9uIGZvciBndWVzdHMsIGl0IGlzIHJlcXVpcmVk IG9ubHkgd2hlbiB1c2luZyBHSUNWMg0KPj4gZHJpdmVyLCBvdGhlcndpc2UgdXNpbmcgR0lDVjMg aXQgaXMgb3B0aW9uYWwgYW5kIGNhbiBiZSBkZXNlbGVjdGVkDQo+PiBpZiB0aGUgdXNlciBkb2Vz bid0IHdhbnQgdG8gb2ZmZXIgdGhlIHZHSUN2MiBpbnRlcmZhY2UgdG8gZ3Vlc3RzIG9yDQo+PiBt YXliZSBpdHMgR0lDdjMgaGFyZHdhcmUgY2FuJ3Qgb2ZmZXIgdGhlIEdJQ3YyIGNvbXBhdGlibGUg bW9kZS4NCj4+IA0KPj4gU2lnbmVkLW9mZi1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxs dUBhcm0uY29tPg0KPj4gLS0tDQo+PiB4ZW4vYXJjaC9hcm0vS2NvbmZpZyAgICAgICAgfCAxMyAr KysrKysrKysrKysrDQo+PiB4ZW4vYXJjaC9hcm0vTWFrZWZpbGUgICAgICAgfCAgNCArKy0tDQo+ PiB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgfCAgNCArKysrDQo+PiB4ZW4vYXJjaC9hcm0v Z2ljLXYzLmMgICAgICAgfCAgNCArKysrDQo+PiB4ZW4vYXJjaC9hcm0vdmdpYy5jICAgICAgICAg fCAgMiArKw0KPj4gNSBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL0tjb25maWcgYi94ZW4vYXJj aC9hcm0vS2NvbmZpZw0KPj4gaW5kZXggZmQ1N2E4MmRkMjg0Li5kYzcwMmYwOGFjZTcgMTAwNjQ0 DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL0tj b25maWcNCj4+IEBAIC03OCw2ICs3OCwxNCBAQCBjb25maWcgQVJNX0VGSQ0KPj4gICAgICAgICAg VUVGSSBmaXJtd2FyZS4gQSBVRUZJIHN0dWIgaXMgcHJvdmlkZWQgdG8gYWxsb3cgWGVuIHRvDQo+ PiAgICAgICAgICBiZSBib290ZWQgYXMgYW4gRUZJIGFwcGxpY2F0aW9uLg0KPj4gDQo+PiArY29u ZmlnIEdJQ1YyDQo+IFNvLCBub3cgaXQgd291bGQgYmUgcG9zc2libGUgdG8gZGVzZWxlY3QgYm90 aCBHSUMgZHJpdmVycyBhbmQgWGVuIHdvdWxkIG5vdCBjb21wbGFpbiB3aGVuIGJ1aWxkaW5nLg0K PiBUaGlzIG1lYW5zIHRoYXQgWGVuIHdvdWxkIGZhaWwgb24gYm9vdCB3aXRob3V0IGFueSBtZXNz YWdlIGFzIGl0IGhhcHBlbnMgYmVmb3JlIHNlcmlhbCBkcml2ZXIgaW5pdGlhbGl6YXRpb24uDQo+ IFNpbmNlIGhhdmluZyBHSUMgZHJpdmVyIGJ1aWx0IGluIGlzIGEgbXVzdC1oYXZlIEkgdGhpbmsg d2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBhdCBsZWFzdCBvbmUgaXMgZW5hYmxlZC4NCg0KSGkg TWljaGFsLA0KDQpJIHRyaWVkIGFuZCBJIGhhZDoNCg0KU3RhcnRpbmcga2VybmVsIC4uLg0KDQot IFVBUlQgZW5hYmxlZCAtDQotIEJvb3QgQ1BVIGJvb3RpbmcgLQ0KLSBDdXJyZW50IEVMIDAwMDAw MDAwMDAwMDAwMDggLQ0KLSBJbml0aWFsaXplIENQVSAtDQotIFR1cm5pbmcgb24gcGFnaW5nIC0N Ci0gWmVybyBCU1MgLQ0KLSBSZWFkeSAtDQooWEVOKSBDaGVja2luZyBmb3IgaW5pdHJkIGluIC9j aG9zZW4NCihYRU4pIFJBTTogMDAwMDAwMDA4MDAwMDAwMCAtIDAwMDAwMDAwZmVmZmZmZmYNCihY RU4pIFJBTTogMDAwMDAwMDg4MDAwMDAwMCAtIDAwMDAwMDA4ZmZmZmZmZmYNCihYRU4pDQooWEVO KSBNT0RVTEVbMF06IDAwMDAwMDAwODQwMDAwMDAgLSAwMDAwMDAwMDg0MTVkMDAwIFhlbg0KKFhF TikgTU9EVUxFWzFdOiAwMDAwMDAwMGZkNmM1MDAwIC0gMDAwMDAwMDBmZDZjODAwMCBEZXZpY2Ug VHJlZQ0KKFhFTikgTU9EVUxFWzJdOiAwMDAwMDAwMDgwMDgwMDAwIC0gMDAwMDAwMDA4MTRmMWEw MCBLZXJuZWwNCihYRU4pICBSRVNWRFswXTogMDAwMDAwMDA4MDAwMDAwMCAtIDAwMDAwMDAwODAw MTAwMDANCihYRU4pICBSRVNWRFsxXTogMDAwMDAwMDAxODAwMDAwMCAtIDAwMDAwMDAwMTg3ZmZm ZmYNCihYRU4pDQooWEVOKQ0KKFhFTikgQ29tbWFuZCBsaW5lOiBub3JlYm9vdCBkb20wX21lbT0x MDI0TSBjb25zb2xlPWR0dWFydCBkdHVhcnQ9c2VyaWFsMCBib290c2NydWI9MA0KKFhFTikgUEZO IGNvbXByZXNzaW9uIG9uIGJpdHMgMjAuLi4yMg0KKFhFTikgRG9tYWluIGhlYXAgaW5pdGlhbGlz ZWQNCihYRU4pIEJvb3RpbmcgdXNpbmcgRGV2aWNlIFRyZWUNCihYRU4pIFBsYXRmb3JtOiBHZW5l cmljIFN5c3RlbQ0KKFhFTikNCihYRU4pICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioNCihYRU4pIFBhbmljIG9uIENQVSAwOg0KKFhFTikgVW5hYmxlIHRvIGZpbmQgY29t cGF0aWJsZSBHSUMgaW4gdGhlIGRldmljZSB0cmVlDQooWEVOKSAqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqDQooWEVOKQ0KKFhFTikgTWFudWFsIHJlc2V0IHJlcXVpcmVk ICgnbm9yZWJvb3QnIHNwZWNpZmllZCkNCg0KV291bGRu4oCZdCBiZSBlbm91Z2ggdG8gc3VnZ2Vz dCB0aGUgdXNlciB0aGF0IGF0IGxlYXN0IG9uZSBHSUMgbmVlZHMgdG8gYmUgc2VsZWN0ZWQ/IElu IHRoZSBoZWxwIGl0DQphbHNvIHN0YXRlcyDigJxpZiB1bnN1cmUsIHNheSBZIg0KDQo+IA0KPiB+ TWljaGFsDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:44:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:44:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575016.900764 (Exim 4.92) (envelope-from ) id 1qRD5Z-0006rh-5J; Wed, 02 Aug 2023 14:44:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575016.900764; Wed, 02 Aug 2023 14:44:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD5Z-0006rZ-2P; Wed, 02 Aug 2023 14:44:37 +0000 Received: by outflank-mailman (input) for mailman id 575016; Wed, 02 Aug 2023 14:44:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD5Y-0006bA-3D for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:44:36 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16f7db42-3143-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 16:44:33 +0200 (CEST) Received: from mail-co1nam11lp2177.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Aug 2023 10:44:29 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5032.namprd03.prod.outlook.com (2603:10b6:a03:1eb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 14:44:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Wed, 2 Aug 2023 14:44:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16f7db42-3143-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1690987472; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=UNeF6WAyrYDXqzjP+1UB8Hs+VZNNbhNjmB9zY5OzRkM=; b=WsIjBmbi9zkBBkdwmXMBU7fL2x4JlLyVPZuXrK8F/YG8+MWI8bGdY4/e yOT3nmB8WTLT9kb1HkBQj5JRkRzlUT9wpU+DtrlORrL79FtAjuV6pfnGl dVhmFWgYSZkppqFHPmARQ3OjisZaWAPK/manIw5PWfAAfYtJjCahsgtuY c=; X-IronPort-RemoteIP: 104.47.56.177 X-IronPort-MID: 118696024 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:7mdw1a7BCUB3A50UuvNXGwxRtILGchMFZxGqfqrLsTDasY5as4F+v mQWWWiBO/6KYmXyet9xbd6x9U0FvsTUxoRkSQZq+Xo2Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPaAT5geH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1 KxGKA5KUUu63f+Snpnqdtk32el5I5y+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtLROPpqKYw3DV/wEQuNzAXa1GDhcKX0FC9S+hyK H0p2gUH+P1aGEuDC4OVsweDiHiFtRkYUpxOHvEg6QeM4qDJ7B2UAGdCRTlEAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BXQZeSYOQA8B4t/iiII+lBTCSpBkCqHdptj0EjH5x 3aNtjozg50aiMJN3KK+lXjXjjStr97TRwE07wneXWW4xgp8aMiuYInAwVHK5PAGL5ucR0PHv HEAl8WExOkLAdeGkynlaO4KGqq04+qENjL0i0NgBJQn+HKm/HvLVYJa7Sx6JUxpGt0ZYjKva 0jW0StO4LdDMX3sarV4C79dEOwvxKnkUN/iD/bda4MXZoArLVDYuiZzeUSXwmbh1lA2lr0yM ouadsDqCmsGDaNgz3y9QOJ1PaIX+x3SDFj7HfjTpylLG5LHDJJJYd/p6GezU90= IronPort-HdrOrdr: A9a23:841YB6lG9Ntq75cZ07tXrgrCQ6zpDfLm3DAbv31ZSRFFG/Fwz/ re5cjy1XfP6Ar5K0tQ4exoWZPwPk80kKQf3WB/B8bGYOCLggWVxcRZnO3fKl7balPDH4xmpM NdmsFFYbWdYmSSz/yKhzVQeOxM/DDzytHLuQ6o9QYPcegFUcBdBgFCYDpzWXcGPjWuTaBJaa a0145iqz28eXIRdK2AdwI4tsb41qH2qK4= X-Talos-CUID: =?us-ascii?q?9a23=3AzI1BymgRaqiiIDrTAjLuTdNwEzJuUy2DzEmXHBS?= =?us-ascii?q?BU3tNFpbEdW/Lp44+nJ87?= X-Talos-MUID: 9a23:vOcqBQgc4cRq3e5gqioSTsMpCfhF4pqkMGQ2v88YuNm+GC9BBheypWHi X-IronPort-AV: E=Sophos;i="6.01,249,1684814400"; d="scan'208";a="118696024" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m0KQMbrulpcy1MazCf14/3J3AkzNH2aInI4ul3ifMNIgLBEIQ9Ptm/ZxAjTO4PgoBSqyPL/V/zTKb8azuWbW8R4vHk+lun9tPfSnKcg+hmn7g3oUPxlPjRnY2tIfyTRYFIdJ06tB8YflRyziqkNDZlSU3xWpdKaV/9TUlIaDEJidD1WPPmucq/Q8k+SL6yVN/X/HFbGq573spml6Vjd8LiQTb9xD9g4x+5WfHBbNGbUBAISs2r7uIytSocepLmZvWmyO7kYw4aZ1LOZYfglwEJtX+D+5T1p0a1kJZGgeEQskcfkwCkaQGBvt18svvuH3synS3HcFRxno9eqTFqDA8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UhKHw/piiMVIfAz6pOjG7eVxMM10gNolgIJmF2iIWvw=; b=evfeR9ihuZYvOin/rQ5nCXBh20HrspVvKG2bS1/xVWjbXCPC3FGVvm1wRYDqiETIwvz9Q7RQAYMe+egjLXyUQTWRq4C402TkODg194QqGo82xInsE+1SvVuOmPmhqR5envqQqzHNVFSVEAWwOcm1KNqXEQYlOkRjhAvNQQsvoCMBQfnuRwKsHLj9l7lsFf+AOtT+3e0/1900+a7ZuL9gGAH18viuwr/o2KSKPZ9uTHtOjN5Gzw19e39dSaSa+dkQHz60BhBahtK0qoED+TbMHYqjzAwpDX9AuiWeMHr6cMOaT4kC5UNgxQxjfKLoCOJTwUVo+CrGAja+eYxXWj3LSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UhKHw/piiMVIfAz6pOjG7eVxMM10gNolgIJmF2iIWvw=; b=L8rPWGHY50LBfx5QSiXmOmw2iifkdgyN2+8A181tXLwfHRgVqqMhOB+quUDDWyb2Ab4qpuqyW/aCuQAQZWRM9KPSlCvs3qLWGOOQg9fi2B6lM/OXU2k+laWJfRg+zfcWMBoO04dTEC+oGyqyvUTFMF/PMKE1WC46lXZb+H3fIM8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <22224dbf-352f-710c-7708-bc1ac0bb5803@citrix.com> Date: Wed, 2 Aug 2023 15:44:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 Content-Language: en-GB To: Nicola Vetrini , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> In-Reply-To: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0114.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5032:EE_ X-MS-Office365-Filtering-Correlation-Id: 4304b82f-1595-4697-f98c-08db9366f4a3 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C2/1RTZXTuv/bnLonxidDTMS/klPvv0bjF2N3StoYOHoTwgC8BVx3kqRROYRwioccGaH8eoi3Jbe5l2QELHhpR3dP30gjkItcd8UMxGFk/6P8zZO96vS6GNiWyqx+qblC/f3OV3vXvws/2CivQSZNYPqChXgX53S8KY3ulO6w+ND+TnnonNzlXtFldR4/bfGYEcAZlACZuXMilVxB4iuZ/9icueZ2fCiA53zAcXmAFvteAHtg1TjwdkbSD3fyxxX2sKMFKZfKK2biuSkLA9kIOFkwVTwecA/nYthTnykJcA7vq8yy3DlZiN6xSOPblboriOtsoVAdz0DEK53mcMrXnBzOIHCPbgxpjAdChjU0KYMr84+cEf2xxfLvRvYLaeQmxnEaR49bBh6JiZgXHR27P5Wk8Oofi23XgIcTZH3BPSdLGW79SXuEi8QCu2xYNUjl4j0Fr2UMkN2R856ozf1KT1H/HWiSeI8HUl3GYZwhkmDWgzGFb2NpVkyep45QEHL6y5+cN6y2ShKarjliK0U9Wyj9M/zq+fNtDZCwjSprphi+ySlhHlIKl5ijDmU0xKuDb5Ecwnugap/mzJ9/QFpxY7YSRnZ4NO1dAEsoJVWQZCX272S2eMpif9SVFO+wW92IBns5WfGB2eiHL0kqjnJkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199021)(8936002)(8676002)(5660300002)(26005)(41300700001)(2906002)(31686004)(7416002)(36756003)(2616005)(478600001)(54906003)(38100700002)(316002)(86362001)(6506007)(53546011)(6486002)(66946007)(66556008)(66476007)(6666004)(31696002)(82960400001)(4326008)(186003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUozdjdoVFJPSWZpK2pEWXhVMzFhdmFVWlhvYTdjRFFEdXNrZVpGd2JzZEtV?= =?utf-8?B?YlJvWTdSS2VCdWNRbnpEeEFSOGZrZ1I3WjZNQlVzN0M4QXkxT29BT0ZXblFB?= =?utf-8?B?eEJ5ZHRVeUNpUG0wcExMNlN1UjczV3NTZlJUK3lKcklQdVF4blFjL1Q2VTY2?= =?utf-8?B?NFB5ZGNSbVl6TDNWSWV6RXNNUjRsM1dZdjhhM2pjc2N2aWp2N2ZkMzBsUGFD?= =?utf-8?B?R1BCaDN3OFhMMGVVZ1N4Z0l1ZFphWGZ2WXZBanRUQ2RKZTZ5bzZhNG9HbS9D?= =?utf-8?B?QkhWUitCUS9FZEE2b2VWN2ErNW1RMEZ0ZjhZeDNiQUpiTVFjNEx2RURBeEY3?= =?utf-8?B?WjhON1VqQTVwUmtML1VWNGRhMlVTREJ2SXIyd1VGOGtGVkN2MzdqQXN3bzM4?= =?utf-8?B?cUYrUU1KTGNuL1BwQWxheUMvazNtMnJrS0RlUHBqSkFmaEhJT3Y0VldQcHpv?= =?utf-8?B?OHBocDNxWnNaK1RBc20rNnM2MDJjMnhrRWpkT09hWlF2SlQ1aFphVDAwSzVl?= =?utf-8?B?Y2hYK3JhVVhRUjJFcEdRdDhIS3hMd0ozRkxmRkdKUm9Rdm1UdGxJTGI4azdZ?= =?utf-8?B?U08wclJqcEcwa1ZyU1Zydm1SMkJ0YmNWdmY1UVlXSEpkT1A3alBOMEIyb2dN?= =?utf-8?B?NCtCUC9rQmU2SlVQTE9oNzl2K3ZXaGVHVEZxeEVUTEhaZDZMaFl5eGpYVFRF?= =?utf-8?B?NWJRdXBUSlZteEtkUkdueXEvTjhqS3lQNkEweWNKQW50eWpGa1d2MUxtREhp?= =?utf-8?B?VndsVU0zY1Q3M0RDclE0OTNrcTVqaDBQajdNUlpLMzVCcVRDQXdjZ3FLT0cr?= =?utf-8?B?SWdWMStMQ1lPRyszYmhoYjM0T1ltQk9IOHFtZ29vU3VzaFFSL3BYRlpIemFK?= =?utf-8?B?U0J5TFJWNmdJcUVuSW05Y05nd1dmcmNyZzUydDZIaHcxNnRMVXFoTFNJeEtw?= =?utf-8?B?UzdTSjVpaGZTYW5hZGZwblJkVTluK3ZaaDBzQnN4bDB4dFk0LzEveUpGaVVn?= =?utf-8?B?NHBQeVpNK3lGRVNnMS9OUG5pRldFaGg1d0Qwd2E4b2ttTEFmVE1NK0Yrc0s5?= =?utf-8?B?T1YwQ3BsL1BkNHBjV096MGpsUnF5dytDWmlFc1JZMldjRWpWRG9LbVdlVFBG?= =?utf-8?B?Ry9ZTkE2My9RSi9hb3hwMGpJaG5mcytVaEF3aGNpVjJGbm5JR3p1OGFlbi9k?= =?utf-8?B?cHBRMGpaUndzWC9zR2hvNW5kbW5HYVlXR1ZUaE5PckEwUkg3emlZdEpYYWcy?= =?utf-8?B?UmJ1WW1SN2drMFZhL0Q1c0hRM3kvdkgrYURkQ3JEak44alduN0ZhbC9xeXIv?= =?utf-8?B?Unc5Mkg3YmE3K2dNUHdoWkdtZUpFY2RZSXhOM3ZnRmM2cE1kZU9VZ3JmaFlX?= =?utf-8?B?ait4NW9uM2JLcXZCNGk1MVFXa3hHdmQrK1BLMWdMRHdKcWVONGFaci9GY01z?= =?utf-8?B?SUxQRTZXK0s4dlFMUVc3WU1seEkyVGI0dGdkaXB5d0NSK1hJbXEzVDUzRFVr?= =?utf-8?B?Y3E4TUY4NjdscjVwRldZTENsMzRpMk1KTnIrbHExYjliVkFhNmZyUkhLbW9P?= =?utf-8?B?QlVkalJzNTE1ZGFXY2s2MlR4blZOcGFSNEhZRm53eUhOSENYVndQMzFiaC9E?= =?utf-8?B?bmdxdm5DbTk2RlA3TW9NQXorL3hvTExDSXFNUjVJZ0hMM1J2NlR5dEhOYVpn?= =?utf-8?B?cUdUQk9TSS9jRDNlNG9qMDB3NjNaelArTTNSZUpMa3JCdFBHRXFRRzhUNlZW?= =?utf-8?B?U1h0RkNsTDR0aWxRQVpJQ0JQV2ppcVZ2a2ZUc21hNHg4UUxzR01nTk1BUmFD?= =?utf-8?B?clNWaC9Jblh1MW1NQkdva0FXME1zUWZDdXhFMFEzckFCSXFkbVUra0kyQllW?= =?utf-8?B?MXJ5dGI1ajBIOGlzNVVreTVCT3RWSGNLMitHOHRKbytxSXp3VVpMd3hPMTZ3?= =?utf-8?B?Z1FpK3FRVkgrWUpkUHRTRmR5RFBBUmJUVW95Y2UyT2h0YytiYjJSYnlnY0pR?= =?utf-8?B?MDgvbzRYc3lZanpHVXRoMGFQT1BLVStpWnYxUlplOG1QdGgwYzR3cU1UZW1x?= =?utf-8?B?VU5jQmFJZzgzOXlybVZOZHlZRWNrWE1tMGVPcUtGKytvT3ZvRzVodE80QnZO?= =?utf-8?B?SlJFRjE2QnNPS3VnNlk1dHRnb1BmbHlTbis4cDZoMGJBWjFYaU92ZXJ5Z00w?= =?utf-8?B?THc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 5KKC7Y4RS8VnXkOnhA2SMQ7UYg3ljSO/QS9L7YAlpb0b9L0PlyThXQKu2hbgpvq6jtQA0UiRhpqhVzfPJr1+PeaIbb/C2uitdgsuXBZXZVmT6XVKjAPd8ncGrJ1fs8bpbQg6Gsdjpc/UJgZ6AMRfIbzCt4g4ZCUPXM/AX7Pi5DzTt1iqBIzw0Iu18YRB997XDApKOuJZtaL0KkQ6km5bdgHwg7QPdf6br5Zwrq2vz3wUMy1vnS5lTgH40/ap0y17LqNOG8rQtcWZ8r2/dRJkXahQq5k5j3RNZL2yH9X9ehxfaGjMy7xkCdY9zB3TyobiRaFXjk8LIzDexlwwE5FbnYjochRu6jZqkLHzu83Y56D6F5FDl5mvxpepAduHR1IUkurp/TBfqi/SadKnAu8Svp1NNjnSRJTme2ESCUUWhkmRxZw+LoKWBGRONSERRfjP1XrQviU5skK1wCuy0toYkSYqTZ0ZcviYQP37rTfX73ENGdObIGeF5m0JdzL7HVWuigli+J/Y4qRxzL7Oj09/BXDdz8sleaE5+RE4IIglFG9szK9uORFl4NKVbl6mC/wVTqsKqJRVUeukjcsYbD9U+ugkSBiM0oWv3JHv0qUJ0ysxs9Hc9kw6cfBHjL/cID8BoUE7Iz6CjdIG25N/LhoXONglVaZPhdqifjdbrvHjf5zj92gbF8dsQ2080kjHoxACzgJ30BXnxVm4wCvbiSfu+rMdZ5qPInOt9s+3F/a7QtBDfa04cT+I/L3HANll9gVRre++Xj6qUwYQyBCiymLsPwle4m8Cw5fZUkmB3Xj/pQMxX0M/bkiqco7YFxQGhBMi+vb+B0jQMKycnf+dwecitzF2eMGj7iZoqM/cWDdHlpmwh5kYzVMgDdK8DIy1GBtSFg1lps2zQwDZWrVhWPby+Q== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4304b82f-1595-4697-f98c-08db9366f4a3 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:44:20.5895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GO3n/EOvsxjzAEYhKKGJi/uZG0UNyUd1ftDF3LmdC9ENkajHF8RWz616akbK6OmnPsJrzbrvtIeERDS7qZE3rBLxQ7WutaWDDj0u/7SPmRo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5032 On 02/08/2023 3:38 pm, Nicola Vetrini wrote: > diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c > index 5f66c2ae33..015f7b14ab 100644 > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2268,6 +2268,17 @@ int domain_relinquish_resources(struct domain *d) > { > int ret; > struct vcpu *v; > + enum { > + PROG_iommu_pagetables = 1, > + PROG_shared, > + PROG_paging, > + PROG_vcpu_pagetables, > + PROG_xen, > + PROG_l4, > + PROG_l3, > + PROG_l2, > + PROG_done, > + }; > > BUG_ON(!cpumask_empty(d->dirty_cpumask)); > > @@ -2291,18 +2302,6 @@ int domain_relinquish_resources(struct domain *d) > #define PROGRESS(x) \ > d->arch.rel_priv = PROG_ ## x; /* Fallthrough */ case PROG_ ## x > > - enum { > - PROG_iommu_pagetables = 1, > - PROG_shared, > - PROG_paging, > - PROG_vcpu_pagetables, > - PROG_xen, > - PROG_l4, > - PROG_l3, > - PROG_l2, > - PROG_done, > - }; > - > case 0: > ret = pci_release_devices(d); > if ( ret ) Why does this get moved?  There's no code (reachable or unreachable) in there. This is very subtle logic to start with, and you're moving one part of it away from the comment explaining how the magic works. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:48:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575048.900774 (Exim 4.92) (envelope-from ) id 1qRD9W-0007dK-Ln; Wed, 02 Aug 2023 14:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575048.900774; Wed, 02 Aug 2023 14:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD9W-0007d9-I5; Wed, 02 Aug 2023 14:48:42 +0000 Received: by outflank-mailman (input) for mailman id 575048; Wed, 02 Aug 2023 14:48:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRD9U-0007co-Kd for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:48:40 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061f.outbound.protection.outlook.com [2a01:111:f400:7eaa::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9f9821b-3143-11ee-b262-6b7b168915f2; Wed, 02 Aug 2023 16:48:39 +0200 (CEST) Received: from CY5PR03CA0021.namprd03.prod.outlook.com (2603:10b6:930:8::36) by SN7PR12MB6766.namprd12.prod.outlook.com (2603:10b6:806:26a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 14:48:35 +0000 Received: from CY4PEPF0000EE37.namprd05.prod.outlook.com (2603:10b6:930:8:cafe::2d) by CY5PR03CA0021.outlook.office365.com (2603:10b6:930:8::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Wed, 2 Aug 2023 14:48:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE37.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Wed, 2 Aug 2023 14:48:35 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 09:48:34 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 2 Aug 2023 07:48:34 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Wed, 2 Aug 2023 09:48:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9f9821b-3143-11ee-b262-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HPymXie5d7HNWM7USa88HZ257RD5vIyw/xwM1oIx0yx7nr6tnPVJU5KsEHI/wModXQ4rdHVTC3wCR5oFiQF4VRwJV8pZX5mMFXQcUC6RKnCePFNgAXeoJ3CvRmQvBQtv4XvAywF8xXL2ZKaNqJXSnWq+DTxw9TfxasQ5BMRMisEQ8tB7+rgJg6LOy+BCUArfZuR5Ha5OgEdvhA6Ild7cyFQoVvvGANOZO9LQhx6Z4qBYjpYcmas1LTREEJ9aYhbqSAVE8wQBgP9VN50BQt+/UX8hiFHsd6yUKOFLQeUJosWqo0ooZ99lHe/tzjO9grP0Rix/21QmPGKQs1ExNvYcig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hg7jkSVwUQysoOXw/WmRJXplEQ3B3+UCu3avV0ef9p8=; b=aY8xNT8hDDosq1X1KxCrX80LfzszXnlNeK7kGWJP6NMRTc9/sjHyrqLemWYtZCpjMjtR9WYV0JHden/8CLxTROFFdcOLJ9nfWdGGKQ/00M0auFBzI+SZf3q0dgbZlV7TC6uXE0RXuSiblbB7qdHAiUEMJSqiBCHcNCYwMDNXSqskPIuHuybBD7twHEOYbrfQB/HDaMsn3ztTc+c8gF9LoO8sIRH3cLgbfaA3WSSU6HQ9XPagqMZ3aWF2FYxBRkF+29hmtm3rHHo6zghu0BLNdQYjT36iyj5r7btqxz4mfdAtKimrGkpU+tnmM3N8skeoGEW5Zu2N2gNUReXwxlk9/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hg7jkSVwUQysoOXw/WmRJXplEQ3B3+UCu3avV0ef9p8=; b=tzL/g/LV3u/qQqzxMmtgcUOvn7bB6Jiup1po6c2M/0d0xFaHBDv5LtGXWDTlNnMN+mZPVeZTSaUbuyLe5t+9k3xFlChdmHk8zcH3YybNfXD6HDOvA9LU7XHnq6DLyEtnpiLdx1cyvFagIhq9lV/ojTl5XLSfnHFuyFgptZL/X/w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> Date: Wed, 2 Aug 2023 16:48:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-US To: Luca Fancellu CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> From: Michal Orzel In-Reply-To: <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE37:EE_|SN7PR12MB6766:EE_ X-MS-Office365-Filtering-Correlation-Id: 78ee1989-240e-4eb0-f946-08db93678cad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +9qZp5FnLodqoa5Z/0CpfFYWFDGkIHKHu5orl2yb5qVWtBf6fiT89FuLjczymUIJ8kx17fngzkHqfSiZIzWynI1SHbYpS1ebu6TQA/lItryNLp/xjK8pyNByOzaJ14IrAB1VWJkvtoWdUj4Mwyr4TewK7Ug/qrL4lC8DVUmu9YZTLOFE24ZKs73nWIMkXvEJ8/nPlBQ/5ceQKIS0DwH2x70bcnjrCykqA8B29yOSAIbWCLzuqdQ+kPK+gI6g90V+ghf3ASYj0+LTrujg+shyMiJAVFdW1F5/JaM/3kW9rK6Nhrex6E+tt/2SzQOLUYOLQ+UVTzhCDxC/9amO4KtSb9z9bosV4ELjKWHev2Ci/YGYCKo9+6Bque9tZEznNm8Nn6+7QOmrexMx6YYTo5TgPlZ3/oBdHvbtlNxOuWMTjBbXh44gmIdD2rcIWbzwsDXgxtzNBaHSXRMKQbSPzA5EJTxS/ovZq+a6x2n9fAfH4N8c+9iAmVTkw4w8nd6XLe2X8up9HLygaxERsffIHTWJzNq/dLqhMdLjyX29kKxNcAHn0vkHv4fiu/KF/41uQ0wQWQpYrtQKGUbJJRY87J0HSt90AnTBDjLRqSrMlD2KEl7y6P6eYuVTICzOxmpNISoQTZRM7Z4J2P7rkCJrPM7m8UIEDFBklL98T7qNxOFZb4tsenvILmuRs2NzZ46x9Hc5RkPgfd/5Ch4hh5SfW1LFY070ufqlXBFBn3wX2L7GZ1rgm4A56Z8Kkba7PtJQNnnygl/AcgBSnRKlvXcnLPUYIT7tdGRBQy7/Ocpq6b5qxEVT48Vq7geX7+zK8+Ptfuj4 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(396003)(39860400002)(451199021)(82310400008)(46966006)(40470700004)(36840700001)(478600001)(40480700001)(86362001)(31696002)(36756003)(6666004)(16576012)(316002)(66899021)(8676002)(8936002)(41300700001)(5660300002)(31686004)(4326008)(6916009)(44832011)(40460700003)(36860700001)(47076005)(83380400001)(54906003)(70586007)(2906002)(70206006)(426003)(26005)(81166007)(356005)(82740400003)(2616005)(336012)(186003)(53546011)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:48:35.2933 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78ee1989-240e-4eb0-f946-08db93678cad X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE37.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6766 Hi, On 02/08/2023 16:42, Luca Fancellu wrote: > > >> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >> >> Hi Luca, >> >> On 02/08/2023 15:53, Luca Fancellu wrote: >>> >>> >>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>> when needed, the option is active by default. >>> >>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>> the GICv2 emulation for guests, it is required only when using GICV2 >>> driver, otherwise using GICV3 it is optional and can be deselected >>> if the user doesn't want to offer the vGICv2 interface to guests or >>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>> >>> Signed-off-by: Luca Fancellu >>> --- >>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>> xen/arch/arm/Makefile | 4 ++-- >>> xen/arch/arm/domain_build.c | 4 ++++ >>> xen/arch/arm/gic-v3.c | 4 ++++ >>> xen/arch/arm/vgic.c | 2 ++ >>> 5 files changed, 25 insertions(+), 2 deletions(-) >>> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>> index fd57a82dd284..dc702f08ace7 100644 >>> --- a/xen/arch/arm/Kconfig >>> +++ b/xen/arch/arm/Kconfig >>> @@ -78,6 +78,14 @@ config ARM_EFI >>> UEFI firmware. A UEFI stub is provided to allow Xen to >>> be booted as an EFI application. >>> >>> +config GICV2 >> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. > > Hi Michal, > > I tried and I had: > > Starting kernel ... > > - UART enabled - > - Boot CPU booting - > - Current EL 0000000000000008 - > - Initialize CPU - > - Turning on paging - > - Zero BSS - > - Ready - > (XEN) Checking for initrd in /chosen > (XEN) RAM: 0000000080000000 - 00000000feffffff > (XEN) RAM: 0000000880000000 - 00000008ffffffff > (XEN) > (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen > (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree > (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel > (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 > (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff > (XEN) > (XEN) > (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 > (XEN) PFN compression on bits 20...22 > (XEN) Domain heap initialised > (XEN) Booting using Device Tree > (XEN) Platform: Generic System > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Unable to find compatible GIC in the device tree > (XEN) **************************************** > (XEN) > (XEN) Manual reset required ('noreboot' specified) Having early printk enabled all the time is not common and not enabled in release builds FWIK. So in general, user would just see "Starting kernel" from u-boot and had to debug what's going on. > > Wouldn’t be enough to suggest the user that at least one GIC needs to be selected? In the help it > also states “if unsure, say Y" I always think it is better to meet the users needs by preventing unwise mistakes like unselecting both drivers. As always, it is up to maintainers. ~Michal From xen-devel-bounces@lists.xenproject.org Wed Aug 02 14:56:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 14:56:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575055.900784 (Exim 4.92) (envelope-from ) id 1qRDGf-0000lZ-Ie; Wed, 02 Aug 2023 14:56:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575055.900784; Wed, 02 Aug 2023 14:56:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRDGf-0000lS-FE; Wed, 02 Aug 2023 14:56:05 +0000 Received: by outflank-mailman (input) for mailman id 575055; Wed, 02 Aug 2023 14:56:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRDGe-0000lM-Mi for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 14:56:04 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2202a1f-3144-11ee-b262-6b7b168915f2; Wed, 02 Aug 2023 16:56:02 +0200 (CEST) Received: from mail-dm6nam04lp2047.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Aug 2023 10:55:59 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5502.namprd03.prod.outlook.com (2603:10b6:a03:279::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19; Wed, 2 Aug 2023 14:55:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Wed, 2 Aug 2023 14:55:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2202a1f-3144-11ee-b262-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1690988162; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=5uhLGxYOXyEg7PZAexzzZHJMpwmhbJYFsqRd8ABdZtU=; b=U3rYQ20Gw+LClCxEsfvQRoWJmKQb0k1QpJpiq/mf6gTe4+uh7By5K6hA Lf4a4a8J3QUrIvCYBdP5o6D4dkJWtVJ0+WjlF+7x3UfKxV8bz/cvjRTmG TrFWd6o0T7pbFgJ0c87E+p0wvVFyKWWpHXQHlAR15porYK0mKmxJ+QMny A=; X-IronPort-RemoteIP: 104.47.73.47 X-IronPort-MID: 118281120 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:S2SaLaNK9Lapc5DvrR1AlsFynXyQoLVcMsEvi/4bfWQNrUp30zEPn GEYCm+PafyJMGukc98jYd/g8xkPuMKGzNBiQQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/vrRC9H5qyo42tI5gZmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0qFrXD986 MEJEz0Qf0iZgrzv+7u5auY506zPLOGzVG8ekldJ6GmFSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vFxvze7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraWzXmrAdtITNVU8NZt0XGemVUoDyQOTECKjfOYjUi3VtZmf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmSzoLE7gDfAXILJhZbb9YrrtMxAzYj2 VmAhdrBDyFgq7CTRjSW8bL8hTWzMi8RJCkcaDMeTA0Ey9P+r5o+iB2JRdFmeIalg9uwFTzuz jSiqCklm65VncMNz7+8/13Mn3SrvJehc+IuzgDeX2bg4gYnYoegP9Cs8QKDsakGK5uFRF6cu nRCg9KZ8O0FEZCKkmqKXfkJG7aqof2CNVUwnGJSInXozBz1k1bLQGyayGgWyJtBWircRQLUX Q== IronPort-HdrOrdr: A9a23:Ka7lMKGGmRCvUiedpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-Talos-CUID: 9a23:8dW3W2DMB7Kh0m36E257qRAmB/00SXDA3S/KJhHhMm9raLLAHA== X-Talos-MUID: =?us-ascii?q?9a23=3AIgWOrA0BaLbR3EGOXBXPIDDYkjUj5PWCBR80qpI?= =?us-ascii?q?/o9CfBAB6GjCbhTmze9py?= X-IronPort-AV: E=Sophos;i="6.01,249,1684814400"; d="scan'208";a="118281120" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hmu68aQHVMB+x0EuiRIUAIVpI+UInhJ18s8KHabBK2c2DI5i0EPdt7ip8r/v0SHA4T/lVHob3w+1nwSdHjz7BkmohlV8LrvwWqtGqTWFdq3mDj04qYWbzCy8UnMdVH7UNdQ1PV/WyNHBCuaeMudpsnQ02awoBoP6ByUF5/qovxFkvTA961ATHYV9SoLAGJVUeHOaK0C2LqAjkB6KKwJP+9w7ppBWolTA7+NoQNK95dK1qqCr3v6WjPptZBYniAUgPb1s0kgXKnQ1zZe0hGzAN6l8nkXO8UXTjQM+MT/SKub/XsGQ45gl4leTWFTSlPW5sFlL3LvUdJoGEeMkFA5XEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5uhLGxYOXyEg7PZAexzzZHJMpwmhbJYFsqRd8ABdZtU=; b=LYf2HkYKRDN6Ex/8cm6m83x256zIBznAc+Ru4L4kZzP8qosF7kv8jicQ77c6KoWqC3DaODDp1/CZaWp5/f2nWl8Rc69tV+kcpk8xuj5Be2m7lH/Eg7vr5Gsr021mv+OyFlGhwJvjgoH8F4s4DSVtguq6tL/xxHeb/4B0eeCvBvD7BRvO3XqSFAeuINmf9DeYCCtK8l1d/pK8TmZ/8VZOZiQQp/w4eOD+YIJMf3LRkBWD64zV3DqzVeHgdCtGfBMijRYRgr4B4ZzMturoYkcDBz4pcGrOK7DI9smZqRyYOzgnbqDGdbqgRof3YGAWJt7Q84FPEEg49YZ3v4pz3tQl6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5uhLGxYOXyEg7PZAexzzZHJMpwmhbJYFsqRd8ABdZtU=; b=mabKcbfUaGR9XjNNk+rkVgzLhex9X33E/EpQUmSxhvq1qGYdl7lf5d3ywmSCJequsPMOtS1f7UVYg1eRTQppIDJGfBKmSRXmHTyNdgND2iYmbbhHUmbSVCOT6cHCXP5RwipHQnZbU3QrqIV9awzWACPt1qkCxmmyOC2XbBdpNp8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <366d308a-92c2-bb7f-3c93-c1fdb23c2e68@citrix.com> Date: Wed, 2 Aug 2023 15:55:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH 3/3] x86: Delete str() Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Roberto Bagnara , Nicola Vetrini , Xen-devel References: <20230728194320.3082120-1-andrew.cooper3@citrix.com> <20230728194320.3082120-4-andrew.cooper3@citrix.com> <88fc0c4d-de8c-73ae-93ea-5df60a30493d@suse.com> In-Reply-To: <88fc0c4d-de8c-73ae-93ea-5df60a30493d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0470.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::26) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ0PR03MB5502:EE_ X-MS-Office365-Filtering-Correlation-Id: fa3c94b5-dd4f-422c-f617-08db93689444 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y1sBtBBQh8qCU7x9UsvL6MYwN3RD98U6GytfHseI2dZRzGN++vNFNYHCO+s0/SzrfqDvObK895T+UfCXD7YGRLxiodCg6l211gqiljvlpc1wteWCkFqSW8bA1gkos10RVc81FtaqA1Q/S8EL2LGhHgrIetIS7fCdLcTanDqN8s3oa/48BYqRLzDtBnORFST5d/ec40BJZYgPXyuzYNuemSjP13sqLbJofq4/65fr2iA6oFtnOF3oxQdmMCBy716peLdR+o67FPV7xSS8912qSUrl1yNrbnOtcmw5VXRaCwwXIa0iwcRPQUl0JWiv2Di2Lojs6LjLJrahJI/fGpsRdP7GtcJc7BJX3DU5Auq9ZkLh0L+ul54HsfXz6X/woz4EgunXYkvTwx79zxpHB07HBjQ+/FfnQUQkNV3KDISZhBsH7ZxOHDxRmM13hS1MrhExZqozxfF7q8lq8drLbaKOvs7S3Q/xsFFjmgu2y2OLdsLr2GVJPd++wQ49Nfxc5veoL3zmEsu9Hb7RN5HQMF+71/xIeIZAoyiGurAEgGd78IvbbNsBe2fuUx+ds7q3yckZ7eiRZjau4V5fvS18At3VdhQqX5ksUkbkr6BcZLazYynxTIPSoEazscdRKXkliLHR5Rmv05QyCp1Bivkz7FKccQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(39860400002)(376002)(366004)(451199021)(66556008)(66476007)(6916009)(4326008)(66946007)(2906002)(38100700002)(2616005)(82960400001)(53546011)(186003)(6506007)(26005)(83380400001)(54906003)(86362001)(31696002)(36756003)(478600001)(6512007)(6666004)(6486002)(4744005)(41300700001)(8936002)(8676002)(5660300002)(31686004)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUNEanptMlNLVi9STlJDazZvanM5U2paaUNtbnBNZE05ZzMwMFFyTlBHSG9o?= =?utf-8?B?UnBxYTMyUWhTNnYxcHpobzJzY1RkUUs3OVBoNmtKWjAzaHhnbDV1cFpZc1hU?= =?utf-8?B?SEU3OXoxZk1Rb1Z2WHRsVXc2bUZ5NFRKV0g1emxCU2h2UHlXREtaSTVQSVY3?= =?utf-8?B?bTNrNmYyZFd3dG1RcDdUMnRwbzBYRVgrNFdnV3hFM3dVczcxZlBPcUdUNkNk?= =?utf-8?B?NlI5aHJCWlFMUmtzZElyRCtRc3J1Snd4bU9vaFBOc0pPaUhnT3dZamhDVlJG?= =?utf-8?B?NkVBcVh5UGQ0ejdiM0tEYk16UnRab0FNQUpQTFpBNEFNNnhJdG1aMHd6SHdr?= =?utf-8?B?SkR3dmRwNHJ1NEp0OVNTUVRCamlPWktaTUxBV1dlQVFKOHFEWm5VZU1EaGVv?= =?utf-8?B?ZGxiUjFBMThJVmlNOXJPajZ5UlVLYXcvWEc1N0tDQlpLYVFzQ2VKeHNrM3Ay?= =?utf-8?B?VmdxS3RZaFZRRjFzRVdLWjR3RkltdFYwY2tCZWVhd1hCNzlMUWliKzJzRk0y?= =?utf-8?B?bnN4M29BM0ZqcGg1aytPd2d6TWZXcHZvK2JadFY4OHpIUWQ2SVlKaC9tR3NU?= =?utf-8?B?MlBmaG5wRVVtandrNVZmVEY5L2tZUUpqbmNCYms3ejlIRWxNamxsbXpqQVhI?= =?utf-8?B?ZFJTTVdlYThtWlRBbE5FbE5aQ2NsdTZ6bjBrblF4aExTTjdJak8wbDlySy91?= =?utf-8?B?Q204dzk4em9pZDJkdTVwNjF2cy9STUFMQVl6cVRhZG9Jdjc1c2Z5L014bHU5?= =?utf-8?B?UURSbHg1TGFYVkMwekRGenlrNjQxeEVQdVQ5MXlPOHBpcyt0L0dVZy83MmI4?= =?utf-8?B?VmRUcU1PNHhWeGpVeXJ1ZGZYaTNjcXlLV2d4WDNCK1NlQ0MrTzVuRjZBVmk2?= =?utf-8?B?T3F5RWJYOVprazhScjRsNzdWS1RmRGx3dTJkMEp0Sy9HNXc4OHdnRVBJbldu?= =?utf-8?B?R3AxZXdSM2tTUDlHcnNtbTJSM2tsUENHUUFuVVdlR1BxSU5VUHloRjRtbFdP?= =?utf-8?B?S0ZISFF1WitRSTlvMWRLY3VlNmRwZWdXazRSOEtmcy9GUUI3cnBwbUNGMFZn?= =?utf-8?B?Z0NtZUl1TTNTL2VKQ0Q0NGkwdVNqM0tpWnpmWEpaRXR5dHR2RkxFK1F4SnVS?= =?utf-8?B?M0toSjQvVXJHaFF6WFp2SVhhTHM4YzV3aHVQVTJPdHV3L25PTDFaTGRPYm1u?= =?utf-8?B?UUpablJZcHVISXZ1SnpRenBYY3cxSlhSYnVUVkNVeWMwTVQ3N2JjSEF6K3Zv?= =?utf-8?B?bkNyMkFIdUFEZGsxQXgyOUhGVXJSYzQvSWIyV2FpKzFWWTlkU2tSdjdDcVly?= =?utf-8?B?aDIzME9WYUlpNHNpazJnV0Rpdzk4UVVVbjQ2eXAzTFJKQ2JHV0tMQllKLy8x?= =?utf-8?B?cGlhUkVJVEpmcWZDTFFHUDNPM1dYWE9BaklSUm9yZzIwRmhLS0U5QkNta0h1?= =?utf-8?B?d1pZMHZCM09lVE9pcnhCWEVBSDg4dEUvZjgxWTg0SFBmcWtLSFhnRmJUa082?= =?utf-8?B?dSs0clNBT29tWnF6Nk4vWDBvMEZlZkRjNEdpa3pGYUdYdEpaTTVBM2lyRXpi?= =?utf-8?B?MWdCaGhKQm9YbCtWUHk5aWF5V3k1T1ZwZXFPY2FLSHRYZUh5RGg3bTFoZ3pu?= =?utf-8?B?VmNpazNaRnRxQzRQa3htaXFMcVdESUNjMmd0aXZVWnNWWmFEUC81T2FvZ1dw?= =?utf-8?B?bXM2eFUzUlVBUkFwMURpNVFvTk9obE8yMjBzMHNPNWlrWjJvK285MFFRMHZp?= =?utf-8?B?YmZnNGMxdllZem8vZVd4bHVYd2JwMURadzF5Q09hSVVKVzJXL3BIUzNhY3VF?= =?utf-8?B?WXl4dE00UmpIZmw4NWNISnp4OU1KMVJxWW9GME9LOGdnNFZUcmo4UUZUcCtu?= =?utf-8?B?NW4yMkk3U2VWeFlWYU14N3IrVVhyemRUT2s0MHkrb0t4emJ2TFN2K1BUQVk2?= =?utf-8?B?YnRsNFJ2YXVGSFZ5SjNMY3ZUSEw0aDJ3TnF3c2xwV0wweUExTW43bU9OdThQ?= =?utf-8?B?eXo3ZndBSDRpc0xQbGlpV0tZMVFzcDdMYVNocDFVN1N5dW1YWVc2ZThGdHBz?= =?utf-8?B?SXRYRGpKRzB0MkQ4SUtOZnA3R2VoYTVXT3JtcTJmYVJ6S25qZlo3MjNuSmJq?= =?utf-8?B?MjlSVjFvZ1RzSHczM0FXS0haWjVlZlM2cll5ejcvSmZ3WmVrTTNTNnZFU1hk?= =?utf-8?B?ZEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QnWXo44RahUYBqkgu/P2elM1Q9oCnQaS6lF1DaxaoMx5T6ZOuDQWxVMVJGd/44qe3emQ3oFMfX1sbHgj/aoC/Kfgqcysj8GDKF2f1N+UEx5FSR3zwMhWZYqkZgHGZ85RPA8iUSJXU+RjL81x3DpiS5JjxrNA3juDVLyKThbKB+CqYwEs2oZQ2gvvQw3D9hLzUUatqFfF5+A8ePtYoNHn376xEl4f595g6lc59Fg7cCwZIq2m9JHMRzH4x5f2JnegPTY9C1yiMCx/IYWxrpBwvce1UyiT5ANHfbGED+Ufw/EAgwHu8ntEWOWJ/8rpplPt0pR/TGdlmCtIKN9jMd605gUEds0hhkGR7MxYaJqJKE09Lpx1ESErG0dSlmTOKcEnUfbcHlr8RxDVAQjIvs0rfy7ixq1PeEseeytMhmwZj7WctCY+2lA0Pw00uGAhcsVYU9nHszdBLgVaKQty5/lSP1x5OgBBFN6ed5mEWRZ5xsFCVNolR7v29hGOAgtpOQ1upiaZi09aY63GNDwcaoFIRbdXHIrAU4EVNGbZDntX8exx8MBRJP4XqrBNReBkqkVVod3Hdn4WqMHvgaIOsvnsYgs7tHBeaNLC/sUfpjl7u8yXNM4ktJPDcfxZ5IhX5nSiHc1FOqXM1RIpZ96ys/+y6ke1qF0KOgDR+UtFPnq/1jSEe/zFbKF/hAoFnBb0t/7Xb3H6dTijEypGbQSAmCb9ncW909tKIuIUgDCZKKEu+H+9xMo5hhEGdqGVHJD6CmK3MksTMtlZ0BiBOcC+5ut97JBppZkjMZ44WOkFwBhjaUa+0DrhhsEzzwvGlC1GQq8IrhPrHsBhSa2W7Ruc1AMnEcyhVwY10gSi46ddFo3VLDM= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa3c94b5-dd4f-422c-f617-08db93689444 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 14:55:57.9859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aPiIyrBzxz8XAzWX4nOuOWCf0l63DK5Q33gSFtK/F3SGTQjXmLp0jeNhgZCqQmZl+oo5a54KT8bER785jqJUNcEWKy8bQ5lQ01pt8IkMRlo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5502 On 31/07/2023 9:25 am, Jan Beulich wrote: > On 28.07.2023 21:43, Andrew Cooper wrote: >> This is used in an assertion only, which is somewhat dubious to begin with and >> won't surivive the x86-S work (where TR will become be a NUL selector). > I'm kind of okay with the removal, but I can't read anything like the > above out of the doc. Can you point me at where this is said? A future draft of the spec. FRED removes the IDT completely, most of the TSS, and can let you get away with GDT/LDT limits of 0. x86-S removes the final aspects of the TSS (the IO perm bitmap, and PVI). Intel have agreed that being able to (effectively) `ltr $0x0000` to set the TSS invalid (like NULL selectors do for all other segments) would be useful, as it means you don't need to have a transiently non-empty GDT just to load an empty TR. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 02 15:05:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 15:05:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575059.900794 (Exim 4.92) (envelope-from ) id 1qRDPp-0002KD-Ek; Wed, 02 Aug 2023 15:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575059.900794; Wed, 02 Aug 2023 15:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRDPp-0002K6-Bg; Wed, 02 Aug 2023 15:05:33 +0000 Received: by outflank-mailman (input) for mailman id 575059; Wed, 02 Aug 2023 15:05:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRDPn-0002K0-O6 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 15:05:31 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1b::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0464b31d-3146-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 17:05:28 +0200 (CEST) Received: from AM6PR01CA0063.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::40) by AS8PR08MB6005.eurprd08.prod.outlook.com (2603:10a6:20b:298::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 15:05:22 +0000 Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::5b) by AM6PR01CA0063.outlook.office365.com (2603:10a6:20b:e0::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 15:05:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 15:05:21 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Wed, 02 Aug 2023 15:05:21 +0000 Received: from 6bcb336d501e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5C8649B-675E-42B4-85E4-7C0C06DEF681.1; Wed, 02 Aug 2023 15:05:10 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6bcb336d501e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Aug 2023 15:05:10 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB8646.eurprd08.prod.outlook.com (2603:10a6:20b:55d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 15:05:07 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 15:05:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0464b31d-3146-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghsrb5yPr7B3yO8mr2dFhlWwYP0lbcf1aRChOIn058w=; b=JBZ+HxjJ5FZ+WmQwowRb4Rh4FMPcoEi7WF5wBqX/UjDmGS8c47I5gwpHsDimf+Jl0bhinLLpgofasE4uCY9dryEtGrr/8Hvh0jmbE3IxbLYZU7mfO0+oaOq9x08eWOSOPHCwqiBmjTfvIkYq6Ixn+7zGnRfj6jl1dH97R6K0Mmo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 836e7222c394a90c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQCvr41PHvNW7SfBb943XQfNFBm68ApKaaR+AAkD9D6vd/uG43D3y+OJoDMToaTjqCckrgONXlsULwufQL95Jt6DV6M+xumDAZz18w/CJvmxEpu025bshRxpqu6/h1g0NAt4EMLGiSJpXudtR0kUCyVcvHV2wBm7i3mrxWoXAiO4FArggWwEe2cJrPfaOlE4x8p0uKG3hvvAs7DKUanXspZooFVYWSyxYRw1MyGfQ5+MQPOdG+JVDGZBqzrARenQTltI21ozL3axkJ7NamdI9bC2mQfjxBmeRoxUSNpd4npV0nd5e13S2Mvz66SfCLdK7piLNSOrYiZoMqJOrqoSFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghsrb5yPr7B3yO8mr2dFhlWwYP0lbcf1aRChOIn058w=; b=cOPcQCrjmKc/N6m/gkNlTjrIuCRHt4CbZxazFEKAnJgISWmrOPCRprsTSI/dbfuC16lpf9wsPpPI7RH+SIj1/VJDGcgPQiVfBRgoyhuVLRqzbYXOlp1+HBeme/JcEcW4AGU38913rQy+zkcCx4JpOIX4synKdfO3jb1XvnErOKiXjlrhcbmBQRhrmDy9f4uzE1CQ5AKJ4ws/btIpHt/KjaWpJbKrlkcYnRgAnOoBS4S7xUxn7PHzfCGTUs0KEfPVH7PySerFvuq+uwxzZnwoM8T5D42w9BJex9VueD1KVNhvkfu9tuasTSe/skLpFh9YbBiNDgRoAGHR/fZaICwOAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghsrb5yPr7B3yO8mr2dFhlWwYP0lbcf1aRChOIn058w=; b=JBZ+HxjJ5FZ+WmQwowRb4Rh4FMPcoEi7WF5wBqX/UjDmGS8c47I5gwpHsDimf+Jl0bhinLLpgofasE4uCY9dryEtGrr/8Hvh0jmbE3IxbLYZU7mfO0+oaOq9x08eWOSOPHCwqiBmjTfvIkYq6Ixn+7zGnRfj6jl1dH97R6K0Mmo= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/XEDgAgAAEZQCAAAGbgIAABJqA Date: Wed, 2 Aug 2023 15:05:06 +0000 Message-ID: <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> In-Reply-To: <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB8646:EE_|AM7EUR03FT033:EE_|AS8PR08MB6005:EE_ X-MS-Office365-Filtering-Correlation-Id: a86d7b37-bcd1-444a-be7e-08db9369e455 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XZC4xWo2mk6RXvMco4tKlWQqdbl2EKjA4rIyFID+u0uFs8CPfXQcLj5gQ2OHCJHN7X14kd5UkvYYFp2756xLGPllRWAdOieFdfzLUhkt7njI6fqCyxz2ZkEcqG45KoGFiThi6jVi5qilE018GQYutplnAeT0XBJdpwxnZuijYrucMeA1v+vJzt0qG4lSVjTqXmjwdp70D1SczC6Z4KWRKweRijQhH79TezjWH0mZJkVzbV7Bna7KPsmcl/N5DYMzKn1bjpIV1/u4mC9wO9sCyBGUOFuHClBfC3t8b0bBNokJZlfbj2a5JV1qNJSOWaQocH4tk/1VZOSuqzXeNSvUsdxOEqpnXZ8iFbQ0GlYVX1md2lh31/bcFmBXiW/r1S5VZDoQMa7++CeHq3ZzwaJoDQ/DprGQNB+eDSDpLo+h5WLWDD3C0TypxssfS/TOI7GBzG/7XX9LwWfDWxNnbTkmEHSwnLVNCu0lK2Y6yUeiPe079o5sLXa8U+yHg7llZZTYY1idl1XHgFXU3AfMUK+/jGtFgLc/iOxHBjUlnl9l5x8xu5c/bQxPTYiFIsLWWR6EwABzlVaezqLzdL/chwTSzSqm1bwQXCBtnpdwywyqfmC2UUAVu5dSh/SNdtzptsTDoHlGKyfqkR+L0PMHkmvSYg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(366004)(376002)(39860400002)(451199021)(8936002)(8676002)(5660300002)(26005)(41300700001)(66899021)(2906002)(83380400001)(38070700005)(36756003)(2616005)(478600001)(54906003)(122000001)(38100700002)(316002)(86362001)(6506007)(53546011)(64756008)(6486002)(76116006)(71200400001)(66946007)(66556008)(66476007)(91956017)(66446008)(33656002)(4326008)(6916009)(186003)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <68FCCAAB4848A4428056140E271D6B2D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8646 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d52c6dfa-ba13-4e46-64f8-08db9369db74 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hRrfNR+KvCKf7YYyj/ry6Cj+M+zZtLaORjzPGccd3YmdkNhFaVhmjlt7dt2wHDC2sLKZR+Zh1YDF+v5+uT1qpBdTHos6GxTVLguQHfzEzPl08oLxF3gP2Ngjx8vMieXrCrHufjTwUs7Is/cesTaORRLb97lwkruO1p+HYWC3cBJx95YlXdn6HEBU4YjY9KO6M6Ik2CI9r+pDJC5zEGazv7p5QRK1bDxKBew/3AnWIGmp0nRhPecbH1Sgi99qy/kr9r9kACsgJyz8sMpcAtA1wXeVnzwiu8lwG7hmJ21NtDrBidoTo996W36Hz78wbo/bitPNJhDJasCiY4DDmyGHmzQg4Q/Bt6tGQK4tmZHDL/lwZrRtYtzxbiu0k3r4m3e1HbJ5aNpt7s09SpgKIfVcsXspPfr2na+angI5jSP/G4xIe/+J2u79uFyT4fJoCtAIe8S0JQo3CFhCXU+WnUOcJM+PrWE8F9gyFKpiU3Tub53qOkdcmaANqX4ddg1mlxCLPynmdKvuRENDR+IgpoGlG+vK+RlsyqToNqFYQ8SgFpdvdMgsZ4jxKE+xc4le64Sr7bNY9eabOWVdZDKNt3YlV7HdohMNR9uWafjx159G5/viSVC8FKPNiLXqb/hUfXDSN61pdxaB0UkWnyd9dubkKjMUvCqqHzsJBHygODnZGXtCWZG1HiUgoQiSnliIio2VW5QOM7BvEmM6PBpYIh88y9gFs/ujpxUyFpnCeEB+pHEROCvPYN5gI+K5FZvdSjx0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(376002)(39860400002)(82310400008)(451199021)(36840700001)(40470700004)(46966006)(8936002)(8676002)(5660300002)(26005)(41300700001)(107886003)(66899021)(36860700001)(2906002)(83380400001)(6862004)(47076005)(36756003)(40460700003)(336012)(2616005)(40480700001)(478600001)(54906003)(81166007)(316002)(86362001)(6506007)(53546011)(82740400003)(6486002)(356005)(70586007)(70206006)(33656002)(4326008)(186003)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 15:05:21.3949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a86d7b37-bcd1-444a-be7e-08db9369e455 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6005 DQoNCj4gT24gMiBBdWcgMjAyMywgYXQgMTU6NDgsIE1pY2hhbCBPcnplbCA8bWljaGFsLm9yemVs QGFtZC5jb20+IHdyb3RlOg0KPiANCj4gSGksDQo+IA0KPiBPbiAwMi8wOC8yMDIzIDE2OjQyLCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4gDQo+PiANCj4+PiBPbiAyIEF1ZyAyMDIzLCBhdCAxNToy NiwgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4g SGkgTHVjYSwNCj4+PiANCj4+PiBPbiAwMi8wOC8yMDIzIDE1OjUzLCBMdWNhIEZhbmNlbGx1IHdy b3RlOg0KPj4+PiANCj4+Pj4gDQo+Pj4+IEludHJvZHVjZSBLY29uZmlnIEdJQ1YyIHRvIGJlIGFi bGUgdG8gY29tcGlsZSB0aGUgR0lDdjIgZHJpdmVyIG9ubHkNCj4+Pj4gd2hlbiBuZWVkZWQsIHRo ZSBvcHRpb24gaXMgYWN0aXZlIGJ5IGRlZmF1bHQuDQo+Pj4+IA0KPj4+PiBJbnRyb2R1Y2UgS2Nv bmZpZyBWR0lDVjIgdGhhdCBkZXBlbmRzIG9uIEdJQ1YyIG9yIEdJQ1YzIGFuZCBjb21waWxlcw0K Pj4+PiB0aGUgR0lDdjIgZW11bGF0aW9uIGZvciBndWVzdHMsIGl0IGlzIHJlcXVpcmVkIG9ubHkg d2hlbiB1c2luZyBHSUNWMg0KPj4+PiBkcml2ZXIsIG90aGVyd2lzZSB1c2luZyBHSUNWMyBpdCBp cyBvcHRpb25hbCBhbmQgY2FuIGJlIGRlc2VsZWN0ZWQNCj4+Pj4gaWYgdGhlIHVzZXIgZG9lc24n dCB3YW50IHRvIG9mZmVyIHRoZSB2R0lDdjIgaW50ZXJmYWNlIHRvIGd1ZXN0cyBvcg0KPj4+PiBt YXliZSBpdHMgR0lDdjMgaGFyZHdhcmUgY2FuJ3Qgb2ZmZXIgdGhlIEdJQ3YyIGNvbXBhdGlibGUg bW9kZS4NCj4+Pj4gDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFu Y2VsbHVAYXJtLmNvbT4NCj4+Pj4gLS0tDQo+Pj4+IHhlbi9hcmNoL2FybS9LY29uZmlnICAgICAg ICB8IDEzICsrKysrKysrKysrKysNCj4+Pj4geGVuL2FyY2gvYXJtL01ha2VmaWxlICAgICAgIHwg IDQgKystLQ0KPj4+PiB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgfCAgNCArKysrDQo+Pj4+ IHhlbi9hcmNoL2FybS9naWMtdjMuYyAgICAgICB8ICA0ICsrKysNCj4+Pj4geGVuL2FyY2gvYXJt L3ZnaWMuYyAgICAgICAgIHwgIDIgKysNCj4+Pj4gNSBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4+PiANCj4+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNo L2FybS9LY29uZmlnIGIveGVuL2FyY2gvYXJtL0tjb25maWcNCj4+Pj4gaW5kZXggZmQ1N2E4MmRk Mjg0Li5kYzcwMmYwOGFjZTcgMTAwNjQ0DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmln DQo+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+Pj4+IEBAIC03OCw2ICs3OCwxNCBA QCBjb25maWcgQVJNX0VGSQ0KPj4+PiAgICAgICAgIFVFRkkgZmlybXdhcmUuIEEgVUVGSSBzdHVi IGlzIHByb3ZpZGVkIHRvIGFsbG93IFhlbiB0bw0KPj4+PiAgICAgICAgIGJlIGJvb3RlZCBhcyBh biBFRkkgYXBwbGljYXRpb24uDQo+Pj4+IA0KPj4+PiArY29uZmlnIEdJQ1YyDQo+Pj4gU28sIG5v dyBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBkZXNlbGVjdCBib3RoIEdJQyBkcml2ZXJzIGFuZCBY ZW4gd291bGQgbm90IGNvbXBsYWluIHdoZW4gYnVpbGRpbmcuDQo+Pj4gVGhpcyBtZWFucyB0aGF0 IFhlbiB3b3VsZCBmYWlsIG9uIGJvb3Qgd2l0aG91dCBhbnkgbWVzc2FnZSBhcyBpdCBoYXBwZW5z IGJlZm9yZSBzZXJpYWwgZHJpdmVyIGluaXRpYWxpemF0aW9uLg0KPj4+IFNpbmNlIGhhdmluZyBH SUMgZHJpdmVyIGJ1aWx0IGluIGlzIGEgbXVzdC1oYXZlIEkgdGhpbmsgd2UgbmVlZCB0byBtYWtl IHN1cmUgdGhhdCBhdCBsZWFzdCBvbmUgaXMgZW5hYmxlZC4NCj4+IA0KPj4gSGkgTWljaGFsLA0K Pj4gDQo+PiBJIHRyaWVkIGFuZCBJIGhhZDoNCj4+IA0KPj4gU3RhcnRpbmcga2VybmVsIC4uLg0K Pj4gDQo+PiAtIFVBUlQgZW5hYmxlZCAtDQo+PiAtIEJvb3QgQ1BVIGJvb3RpbmcgLQ0KPj4gLSBD dXJyZW50IEVMIDAwMDAwMDAwMDAwMDAwMDggLQ0KPj4gLSBJbml0aWFsaXplIENQVSAtDQo+PiAt IFR1cm5pbmcgb24gcGFnaW5nIC0NCj4+IC0gWmVybyBCU1MgLQ0KPj4gLSBSZWFkeSAtDQo+PiAo WEVOKSBDaGVja2luZyBmb3IgaW5pdHJkIGluIC9jaG9zZW4NCj4+IChYRU4pIFJBTTogMDAwMDAw MDA4MDAwMDAwMCAtIDAwMDAwMDAwZmVmZmZmZmYNCj4+IChYRU4pIFJBTTogMDAwMDAwMDg4MDAw MDAwMCAtIDAwMDAwMDA4ZmZmZmZmZmYNCj4+IChYRU4pDQo+PiAoWEVOKSBNT0RVTEVbMF06IDAw MDAwMDAwODQwMDAwMDAgLSAwMDAwMDAwMDg0MTVkMDAwIFhlbg0KPj4gKFhFTikgTU9EVUxFWzFd OiAwMDAwMDAwMGZkNmM1MDAwIC0gMDAwMDAwMDBmZDZjODAwMCBEZXZpY2UgVHJlZQ0KPj4gKFhF TikgTU9EVUxFWzJdOiAwMDAwMDAwMDgwMDgwMDAwIC0gMDAwMDAwMDA4MTRmMWEwMCBLZXJuZWwN Cj4+IChYRU4pICBSRVNWRFswXTogMDAwMDAwMDA4MDAwMDAwMCAtIDAwMDAwMDAwODAwMTAwMDAN Cj4+IChYRU4pICBSRVNWRFsxXTogMDAwMDAwMDAxODAwMDAwMCAtIDAwMDAwMDAwMTg3ZmZmZmYN Cj4+IChYRU4pDQo+PiAoWEVOKQ0KPj4gKFhFTikgQ29tbWFuZCBsaW5lOiBub3JlYm9vdCBkb20w X21lbT0xMDI0TSBjb25zb2xlPWR0dWFydCBkdHVhcnQ9c2VyaWFsMCBib290c2NydWI9MA0KPj4g KFhFTikgUEZOIGNvbXByZXNzaW9uIG9uIGJpdHMgMjAuLi4yMg0KPj4gKFhFTikgRG9tYWluIGhl YXAgaW5pdGlhbGlzZWQNCj4+IChYRU4pIEJvb3RpbmcgdXNpbmcgRGV2aWNlIFRyZWUNCj4+IChY RU4pIFBsYXRmb3JtOiBHZW5lcmljIFN5c3RlbQ0KPj4gKFhFTikNCj4+IChYRU4pICoqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioNCj4+IChYRU4pIFBhbmljIG9uIENQVSAw Og0KPj4gKFhFTikgVW5hYmxlIHRvIGZpbmQgY29tcGF0aWJsZSBHSUMgaW4gdGhlIGRldmljZSB0 cmVlDQo+PiAoWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+ PiAoWEVOKQ0KPj4gKFhFTikgTWFudWFsIHJlc2V0IHJlcXVpcmVkICgnbm9yZWJvb3QnIHNwZWNp ZmllZCkNCj4gSGF2aW5nIGVhcmx5IHByaW50ayBlbmFibGVkIGFsbCB0aGUgdGltZSBpcyBub3Qg Y29tbW9uIGFuZCBub3QgZW5hYmxlZCBpbiByZWxlYXNlIGJ1aWxkcyBGV0lLLg0KPiBTbyBpbiBn ZW5lcmFsLCB1c2VyIHdvdWxkIGp1c3Qgc2VlICJTdGFydGluZyBrZXJuZWwiIGZyb20gdS1ib290 IGFuZCBoYWQgdG8gZGVidWcgd2hhdCdzIGdvaW5nIG9uLg0KPiANCj4+IA0KPj4gV291bGRu4oCZ dCBiZSBlbm91Z2ggdG8gc3VnZ2VzdCB0aGUgdXNlciB0aGF0IGF0IGxlYXN0IG9uZSBHSUMgbmVl ZHMgdG8gYmUgc2VsZWN0ZWQ/IEluIHRoZSBoZWxwIGl0DQo+PiBhbHNvIHN0YXRlcyDigJxpZiB1 bnN1cmUsIHNheSBZIg0KPiBJIGFsd2F5cyB0aGluayBpdCBpcyBiZXR0ZXIgdG8gbWVldCB0aGUg dXNlcnMgbmVlZHMgYnkgcHJldmVudGluZyB1bndpc2UgbWlzdGFrZXMgbGlrZSB1bnNlbGVjdGlu ZyBib3RoIGRyaXZlcnMuDQo+IEFzIGFsd2F5cywgaXQgaXMgdXAgdG8gbWFpbnRhaW5lcnMuDQoN CkFueXdheSBJIHVuZGVyc3RhbmQgeW91ciBwb2ludCwgZG8geW91IHRoaW5rIHNvbWV0aGluZyBs aWtlIHRoYXQgY291bGQgYmUgb2s/IEnigJl2ZSBjaGVja2VkIGFuZCBpdCB3b3JrcywgaXQNCmNv bXBpbGUgb25seSBpZiBhdCBsZWFzdCBvbmUgR0lDIGRyaXZlciBpcyBlbmFibGVkDQoNCmRpZmYg LS1naXQgYS94ZW4vYXJjaC9hcm0vc2V0dXAuYyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQppbmRl eCAyNjRkMmYyZDRiMDkuLjg1YjRhN2YwODkzMiAxMDA2NDQNCi0tLSBhL3hlbi9hcmNoL2FybS9z ZXR1cC5jDQorKysgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KQEAgLTEwOTYsNiArMTA5Niw5IEBA IHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25nIGJvb3RfcGh5c19vZmZzZXQsDQog DQogICAgIHByZWluaXRfeGVuX3RpbWUoKTsNCiANCisgICAgLyogRG9uJ3QgYnVpbGQgaWYgYXQg bGVhc3Qgb25lIEdJQyBkcml2ZXIgaXMgZW5hYmxlZCAqLw0KKyAgICBCVUlMRF9CVUdfT04oIShJ U19FTkFCTEVEKENPTkZJR19HSUNWMykgfHwgSVNfRU5BQkxFRChDT05GSUdfR0lDVjIpDQorICAg ICAgICAgICAgICAgICB8fCBJU19FTkFCTEVEKENPTkZJR19ORVdfVkdJQykpKTsNCiAgICAgZ2lj X3ByZWluaXQoKTsNCiANCiAgICAgYXJtX3VhcnRfaW5pdCgpOw0KDQo+IA0KPiB+TWljaGFsDQoN Cg== From xen-devel-bounces@lists.xenproject.org Wed Aug 02 15:47:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 15:47:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575068.900807 (Exim 4.92) (envelope-from ) id 1qRE4A-0006m6-Kn; Wed, 02 Aug 2023 15:47:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575068.900807; Wed, 02 Aug 2023 15:47:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRE4A-0006lz-I1; Wed, 02 Aug 2023 15:47:14 +0000 Received: by outflank-mailman (input) for mailman id 575068; Wed, 02 Aug 2023 15:47:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRE48-0006lt-KO for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 15:47:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRE48-0005Xa-DM; Wed, 02 Aug 2023 15:47:12 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRE48-0005q5-55; Wed, 02 Aug 2023 15:47:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=JcRcT5GsB9W1AnjvjW1VWtnJX4Dzo7/Z8y9C0RNk4CA=; b=GqoNAt m7w1BaISQjHmf1TIoeMOiIiF4hfOF2XzJYsoBcPgnxEjZ+fUhpyHtUtL/ZQ5/wLZpNPGX/BEFvPZf WgdL2eHskh7xkTZ4lF+v0dwGHIK/NIkCwXPi2suzx6iKDdusnK7lX0vedQKcjzmYZTnqORxTHd/lf eR/1yYS4CsE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen/x86: Constify the vCPU parameter for expand_xsave_states() Date: Wed, 2 Aug 2023 16:47:05 +0100 Message-Id: <20230802154705.84530-1-julien@xen.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall expand_xsave_states() is not meant to modify the vCPU. So the parameter can be const. Signed-off-by: Julien Grall --- xen/arch/x86/include/asm/xstate.h | 2 +- xen/arch/x86/xstate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/xstate.h b/xen/arch/x86/include/asm/xstate.h index 7ab0bdde89cf..c08c267884f0 100644 --- a/xen/arch/x86/include/asm/xstate.h +++ b/xen/arch/x86/include/asm/xstate.h @@ -100,7 +100,7 @@ int __must_check validate_xstate(const struct domain *d, uint64_t xcr0, uint64_t xcr0_accum, const struct xsave_hdr *hdr); int __must_check handle_xsetbv(u32 index, u64 new_bv); -void expand_xsave_states(struct vcpu *v, void *dest, unsigned int size); +void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size); void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size); /* extended state init and cleanup functions */ diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 92496f379546..3d566252eaa2 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -172,7 +172,7 @@ static void setup_xstate_comp(uint16_t *comp_offsets, * It is the callers responsibility to ensure that there is xsave state to * serialise, and that the provided buffer is exactly the right size. */ -void expand_xsave_states(struct vcpu *v, void *dest, unsigned int size) +void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) { const struct xsave_struct *xsave = v->arch.xsave_area; const void *src; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 16:19:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 16:19:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575076.900822 (Exim 4.92) (envelope-from ) id 1qREZB-0002N8-RC; Wed, 02 Aug 2023 16:19:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575076.900822; Wed, 02 Aug 2023 16:19:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qREZB-0002N1-Og; Wed, 02 Aug 2023 16:19:17 +0000 Received: by outflank-mailman (input) for mailman id 575076; Wed, 02 Aug 2023 16:19:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qREZ9-0002Mt-SP for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 16:19:16 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 528be2e0-3150-11ee-b262-6b7b168915f2; Wed, 02 Aug 2023 18:19:14 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fe2bc2701bso241745e9.2 for ; Wed, 02 Aug 2023 09:19:14 -0700 (PDT) Received: from [192.168.2.1] (82-64-138-184.subs.proxad.net. [82.64.138.184]) by smtp.googlemail.com with ESMTPSA id 22-20020a05600c22d600b003fbb618f7adsm2069195wmg.15.2023.08.02.09.19.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 09:19:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 528be2e0-3150-11ee-b262-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rabbit-lu.20221208.gappssmtp.com; s=20221208; t=1690993154; x=1691597954; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=uOrjw3OVIELigHd6J8onu3wawRYKujsftrlpLv+TAgM=; b=Sk24tqc+5FebLHoamkHyQEzK2ViGxDcERwYLQhqe952i3HuExmq1Lu6XmQEJKX8z1p fOF/Wo4Qex4X6t8seClEDBcW1GJINe7Am7ICiyv41/egw5ocX8VPEheeQ1/lsDvDytOp IrWV1G8OrPTAKnjS3ZjvBOimO4j9xordBAIQznq5tSd9N9F6p5V3ux24yhlMTR15kkRm 5eDqSKGVsTqjMtae40yEOtx1FrEc2X4GrQa+ylNt9OHovAkm9K1MzqXS5m5NXgdeXj05 EnZExh4B+4/hk8f/ffM06iN5LD3lZLBgWTaM6tyOo3ynfO1W2QjiNEErnOyfG4aCaPQ5 0Abw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690993154; x=1691597954; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uOrjw3OVIELigHd6J8onu3wawRYKujsftrlpLv+TAgM=; b=EYUB60TuuyT4bKXIeKb1qA/vfygNkl7nldajRzOuStkKCn8a8/IjSle5pKFjsyXxUL HRHZDcbGLQQcATxSO8Cqu+P+7GCHIJ/9qKOQ/ASO+xERHnsc42QkTJDF5hLbuyIWqdVC Ln+5U4SO1uxlwvsRNMLti9emWNb9n3Vp73FtjDM/2aO+GqNXrsVai/tN/f5/4AF9n9Z9 Dp5A3yKGCS4lGaJ7CYrnfmjQ4vjTsPi9d4Ul7A163lo2IOD4WpezPCmPUOk5RDNhzkmk Bq48zhxakrEZb8nk3nAnAtOrEeHDBlVMcg+9/HOEu5tFh8e8E3DQxgq4gXpI3/XmIFWM HitQ== X-Gm-Message-State: ABy/qLbZp0RaL/AN6V/J18ATzkkUFY8S0XDWVK+fGfQnSh8PdcUMSjLw rTsJVF5sNHU5p+MGxykSiFJX+DWq1zt3JN6XU40= X-Google-Smtp-Source: APBJJlEh6fCrXDrhqN2eTIB19YNxuRiNTr5vrGAEBDadKq1INRMdqQzX/2Zqt4AkPatzS3HByMvBRg== X-Received: by 2002:a1c:7c03:0:b0:3fe:2140:f504 with SMTP id x3-20020a1c7c03000000b003fe2140f504mr5553845wmc.20.1690993154130; Wed, 02 Aug 2023 09:19:14 -0700 (PDT) Message-ID: Date: Wed, 2 Aug 2023 18:19:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Content-Language: en-US To: xen-devel@lists.xenproject.org From: zithro Subject: Network interfaces naming changes in domUs with >10 vifs (Debian bug 1042842) Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello all, I report here following a discussion on #xen-devel about Debian bug 1042842 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042842). When using more than 10 vifs in a domU on Xen 4.14 (deb11), the attributions are like : vifX.0 <> eth0 vifX.1 <> eth1 vifX.2 <> eth2 [...] vifX.10 <> eth10 With Xen 4.17 (deb12), it changes to : vifX.0 <> eth0 vifX.1 <> eth1 vifX.10 <> eth2 vifX.2 <> eth3 [...] Both tests are using oxenstored (the default in Debian 11/12), I don't know for the bug reporter. I didn't try cxenstored. The bug reporter mentionned commit "http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=fce6999", I don't know if it's related or not. For now, he's using "/etc/network/interfaces" to force the attribution. If I understood correctly, all people who answered on IRC think this is "not-a-Xen bug", but I was asked to post here for all to discuss. For more context, I extracted some comments from IRC (I removed usernames as I didn't know if I was allowed to quote them). Thanks ! -------------- IRC DISCUSSION -------------- - AFAIK, there is no sorting in Xenstored. And you should not expect that even if libxl sorted properly it will be seen in the same order on the other end. - is the ethN number in domU related to vif number in xenstore, or to device detection order? - there's no order to eth names at all. they're allocated first-come-first-serve, so it entirely depends on how parallel the probing of nic drivers are. even if netfront is serialised around xenstore accesses, it probably allocates in the order that XS_DIRECTORY comes back with - from simple tests, it looks like VIFs are created in Xenstore in the order of the config file, but if you "xenstore-ls /[...]/vif", you can see vifs are ordered like vif1,vif10,vif11,vif2,etc - the order is different between Xen 4.14 and 4.17 (ie. the "expected" order works on 4.14, not 4.17) - But really, Debian should have never relied on how the nodes are ordered. This is not something we guarantee in the Xenstored API - the last big batch of XSA content for the xenstoreds did some major rearranging of oxenstored. We dropped a NIH second garbage collector, and a NIH weakref system IIRC. I could entirely believe that the apparent sort order changed as a result - generally, I think Linux world established quite some time ago that ethN names are not stable - It's definitely a complicated issue. Perhaps best to post to xen-devel so we can have a discussion. I expect the answer is not-a-Xen bug, but I don't think we have a clear understanding of the problem yet -- zithro / Cyril From xen-devel-bounces@lists.xenproject.org Wed Aug 02 16:32:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 16:32:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575083.900832 (Exim 4.92) (envelope-from ) id 1qRElr-0004jd-Ur; Wed, 02 Aug 2023 16:32:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575083.900832; Wed, 02 Aug 2023 16:32:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRElr-0004jW-SC; Wed, 02 Aug 2023 16:32:23 +0000 Received: by outflank-mailman (input) for mailman id 575083; Wed, 02 Aug 2023 16:32:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRElr-0004jQ-C2 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 16:32:23 +0000 Received: from frasgout12.his.huawei.com (unknown [14.137.139.154]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2627c717-3152-11ee-b262-6b7b168915f2; Wed, 02 Aug 2023 18:32:20 +0200 (CEST) Received: from mail02.huawei.com (unknown [172.18.147.229]) by frasgout12.his.huawei.com (SkyGuard) with ESMTP id 4RGHGc4KMvz9xFbJ for ; Thu, 3 Aug 2023 00:18:48 +0800 (CST) Received: from A2101119013HW2.china.huawei.com (unknown [10.81.207.228]) by APP1 (Coremail) with SMTP id LxC2BwCnWbn9hMpkgNcsAA--.36049S2; Wed, 02 Aug 2023 17:32:06 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2627c717-3152-11ee-b262-6b7b168915f2 From: Petr Tesarik To: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR X86), linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Cc: Roberto Sassu , petr@tesarici.cz Subject: [PATCH v1] xen: remove a confusing comment on auto-translated guest I/O Date: Wed, 2 Aug 2023 18:31:51 +0200 Message-Id: <20230802163151.1486-1-petrtesarik@huaweicloud.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:LxC2BwCnWbn9hMpkgNcsAA--.36049S2 X-Coremail-Antispam: 1UD129KBjvdXoWruw1fCF1DKFy5Ary3AFyUGFg_yoWDKwcE9F 4xZF48Ww45tr93X34UKr4avaySyan3trWF9Fn2y34YyFWxXFs7XFs2g3Z0kw4xXFWrCrZx XF9xXry7Jw40kjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJV WxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFylc7CjxVAKzI0EY4vE52x082I5MxAIw28Icx kI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2Iq xVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42 IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY 6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2js IEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUxUUUUUUUU= X-CM-SenderInfo: hshw23xhvd2x3n6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected From: Petr Tesarik After removing the conditional return from xen_create_contiguous_region(), the accompanying comment was left in place, but it now precedes an unrelated conditional and confuses readers. Fixes: 989513a735f5 ("xen: cleanup pvh leftovers from pv-only sources") Signed-off-by: Petr Tesarik --- arch/x86/xen/mmu_pv.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index e0a975165de7..804a5441324c 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2310,12 +2310,6 @@ int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, int success; unsigned long vstart = (unsigned long)phys_to_virt(pstart); - /* - * Currently an auto-translated guest will not perform I/O, nor will - * it require PAE page directories below 4GB. Therefore any calls to - * this function are redundant and can be ignored. - */ - if (unlikely(order > MAX_CONTIG_ORDER)) return -ENOMEM; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 17:40:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 17:40:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575095.900852 (Exim 4.92) (envelope-from ) id 1qRFp3-0003Kf-V5; Wed, 02 Aug 2023 17:39:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575095.900852; Wed, 02 Aug 2023 17:39:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRFp3-0003KY-SL; Wed, 02 Aug 2023 17:39:45 +0000 Received: by outflank-mailman (input) for mailman id 575095; Wed, 02 Aug 2023 17:39:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRFp2-0003KQ-Cn for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 17:39:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRFp1-00006W-Nq; Wed, 02 Aug 2023 17:39:43 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.26.206]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRFp1-0007Mz-Dm; Wed, 02 Aug 2023 17:39:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=amogQHwyZFPdalebZNK/V3bo9V+QlBmSGFdST+gtu+E=; b=ahyk85dEVp7/fQb/rzogO2sTV0 tVxhlyhZJtOfE0XwVaV+UbFQhoed3qhmSMGiE40dbPR0ypuZFAw56epgPN/njpjlqPtt+zKm0RYVV edAhYkt1kuxvlwwcjdFJ/PxbHEnc8OtjBNzKovEKAErFScJ+XLYw4sQBYOlOYsNQeMig=; Message-ID: <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> Date: Wed, 2 Aug 2023 18:39:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu , Michal Orzel Cc: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> From: Julien Grall In-Reply-To: <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 02/08/2023 16:05, Luca Fancellu wrote: >> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >> >> Hi, >> >> On 02/08/2023 16:42, Luca Fancellu wrote: >>> >>> >>>> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >>>> >>>> Hi Luca, >>>> >>>> On 02/08/2023 15:53, Luca Fancellu wrote: >>>>> >>>>> >>>>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>>>> when needed, the option is active by default. >>>>> >>>>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>>>> the GICv2 emulation for guests, it is required only when using GICV2 >>>>> driver, otherwise using GICV3 it is optional and can be deselected >>>>> if the user doesn't want to offer the vGICv2 interface to guests or >>>>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>>>> >>>>> Signed-off-by: Luca Fancellu >>>>> --- >>>>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>>>> xen/arch/arm/Makefile | 4 ++-- >>>>> xen/arch/arm/domain_build.c | 4 ++++ >>>>> xen/arch/arm/gic-v3.c | 4 ++++ >>>>> xen/arch/arm/vgic.c | 2 ++ >>>>> 5 files changed, 25 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>>> index fd57a82dd284..dc702f08ace7 100644 >>>>> --- a/xen/arch/arm/Kconfig >>>>> +++ b/xen/arch/arm/Kconfig >>>>> @@ -78,6 +78,14 @@ config ARM_EFI >>>>> UEFI firmware. A UEFI stub is provided to allow Xen to >>>>> be booted as an EFI application. >>>>> >>>>> +config GICV2 >>>> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >>>> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >>>> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. >>> >>> Hi Michal, >>> >>> I tried and I had: >>> >>> Starting kernel ... >>> >>> - UART enabled - >>> - Boot CPU booting - >>> - Current EL 0000000000000008 - >>> - Initialize CPU - >>> - Turning on paging - >>> - Zero BSS - >>> - Ready - >>> (XEN) Checking for initrd in /chosen >>> (XEN) RAM: 0000000080000000 - 00000000feffffff >>> (XEN) RAM: 0000000880000000 - 00000008ffffffff >>> (XEN) >>> (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen >>> (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree >>> (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel >>> (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 >>> (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff >>> (XEN) >>> (XEN) >>> (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 >>> (XEN) PFN compression on bits 20...22 >>> (XEN) Domain heap initialised >>> (XEN) Booting using Device Tree >>> (XEN) Platform: Generic System >>> (XEN) >>> (XEN) **************************************** >>> (XEN) Panic on CPU 0: >>> (XEN) Unable to find compatible GIC in the device tree >>> (XEN) **************************************** >>> (XEN) >>> (XEN) Manual reset required ('noreboot' specified) >> Having early printk enabled all the time is not common and not enabled in release builds FWIK. There are a lot of information printed before the console is properly brought up. I wonder if we should look at adding early console like Linux does? >> So in general, user would just see "Starting kernel" from u-boot and had to debug what's going on. >> >>> >>> Wouldn’t be enough to suggest the user that at least one GIC needs to be selected? In the help it >>> also states “if unsure, say Y" >> I always think it is better to meet the users needs by preventing unwise mistakes like unselecting both drivers. >> As always, it is up to maintainers. > > Anyway I understand your point, do you think something like that could be ok? I’ve checked and it works, it > compile only if at least one GIC driver is enabled > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 264d2f2d4b09..85b4a7f08932 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -1096,6 +1096,9 @@ void __init start_xen(unsigned long boot_phys_offset, > > preinit_xen_time(); > > + /* Don't build if at least one GIC driver is enabled */ > + BUILD_BUG_ON(!(IS_ENABLED(CONFIG_GICV3) || IS_ENABLED(CONFIG_GICV2) > + || IS_ENABLED(CONFIG_NEW_VGIC))); randconfig in gitlab will now randomly fail compilation. If we want to encode the dependency then it should be done in Kconfig. But I haven't looked at how to do that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 17:55:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 17:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575101.900869 (Exim 4.92) (envelope-from ) id 1qRG4J-0006Fx-AI; Wed, 02 Aug 2023 17:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575101.900869; Wed, 02 Aug 2023 17:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRG4J-0006Fq-7V; Wed, 02 Aug 2023 17:55:31 +0000 Received: by outflank-mailman (input) for mailman id 575101; Wed, 02 Aug 2023 17:55:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRG4G-0006FX-Tt for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 17:55:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2864d76-315d-11ee-b262-6b7b168915f2; Wed, 02 Aug 2023 19:55:26 +0200 (CEST) Received: from AS9PR06CA0034.eurprd06.prod.outlook.com (2603:10a6:20b:463::18) by VI1PR08MB5373.eurprd08.prod.outlook.com (2603:10a6:803:131::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 17:54:56 +0000 Received: from AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:463:cafe::d8) by AS9PR06CA0034.outlook.office365.com (2603:10a6:20b:463::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Wed, 2 Aug 2023 17:54:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT055.mail.protection.outlook.com (100.127.141.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Wed, 2 Aug 2023 17:54:54 +0000 Received: ("Tessian outbound d7adc65d10b4:v145"); Wed, 02 Aug 2023 17:54:54 +0000 Received: from 8775f5645cc4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6A53934A-EED9-431F-960B-2B5F22A94A2B.1; Wed, 02 Aug 2023 17:54:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8775f5645cc4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Aug 2023 17:54:48 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by VI1PR08MB10074.eurprd08.prod.outlook.com (2603:10a6:800:1be::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 2 Aug 2023 17:54:45 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 17:54:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2864d76-315d-11ee-b262-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wGdoDvdQ15yG/UVpeZwNNtXlkuSiD2NZBrIKzlTlkgM=; b=vk4Vz8/sSewaf+GPLbdUbO3SnXBZOLwr0fbfoa6yxe0MXEsnLF+y0p8Nc9I+JDtmODtRgSBze9Mk0YGbLnwJUj9lrmECUf44eoIKGTCV0MA+0OitI+quv3+aJs6d0rKVlJZ8Cl39lTsLItLgxSXXFXCgT4WY9G5CRmBja9/wJuA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 34aaec0725b9895a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hq7mkhMMHaKEiSouS6on9WQCBUFTzQPQpmhNQeqi4oBE4bAVJhSy8sFDRqsMUHsGTJ+T5/zd2xDPxpC4ppb5sHO7C3y+mJ4NUcd3xQUS+JeDqhXSvlFBQm/qTBTAI4/ns9EWWtA/m7xnNBUFGShmU5jsU8zKxopb7aQCjrsayu+yWdiRquJCqjrMOCW+ru/8zjogpc+0KXA70INwNRJhgljmRNBCH4CrRmCrqyTRhwOmrT9Kmv/iCcEXs7lYSWpto46UFxnJnR+JePnUffYKsGFZQYSoMi8Q+4t0j9pFnt1V20Fo2j131H4Inam7zs6C33LnbAPcBLmy7OCVvTuXYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wGdoDvdQ15yG/UVpeZwNNtXlkuSiD2NZBrIKzlTlkgM=; b=UU2AWFMODyzunHZ+5UbmT4aHKsPVYHdocSfudjTxv47lJ42vOKoUZtoHR1yYYNYhAI4nuu0EeIsrN3B0LRYyBDCg/4oa59HbHLayin3k+XrVopKUkjd5glcbWMZS7JHA+WV39DEHyWCuYPmm5gnGDEDiZB0aQqZ9cDQrCrQphamAvKaPJr4oudm2uShqeYEngy/q5j3dkP5wy1UERZco2x+ssKVeW1SHfSkHVFXMIgypcwX4CFHnZDuS0Fj/HI4Rk7JlDRhoYHILl31wRuqjJLFol8oGBpjXqtMSED9yqUOKlVMIbVy10XyujmWlpUvtBSpKZiTfKLu11Q9TFKm5ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wGdoDvdQ15yG/UVpeZwNNtXlkuSiD2NZBrIKzlTlkgM=; b=vk4Vz8/sSewaf+GPLbdUbO3SnXBZOLwr0fbfoa6yxe0MXEsnLF+y0p8Nc9I+JDtmODtRgSBze9Mk0YGbLnwJUj9lrmECUf44eoIKGTCV0MA+0OitI+quv3+aJs6d0rKVlJZ8Cl39lTsLItLgxSXXFXCgT4WY9G5CRmBja9/wJuA= From: Luca Fancellu To: Julien Grall CC: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/XEDgAgAAEZQCAAAGbgIAABJqAgAArPoCAAAQngA== Date: Wed, 2 Aug 2023 17:54:43 +0000 Message-ID: <9B62D8DC-2425-42A4-A95F-BC41FA27238D@arm.com> References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> In-Reply-To: <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|VI1PR08MB10074:EE_|AM7EUR03FT055:EE_|VI1PR08MB5373:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ed789e5-04f1-4767-3c37-08db93819435 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tpo8iftuQ8pd61fSxpMlgL5ns5cw6eHChgVK3rCxzNb7UQ1JJv+jCDFS4oz3piv8iLXGppdGOtQVrFrYKgxiQcmceSLPi3pIb0//dSKp4LULW/j3zxn6mwyTH35jasvdoXKZutMmtjKdcpEVP6tHz6ghpXPTxKvGLU5SjGtfWCLJRe1YUZ9LdlrnZlMkpoiqv8nofeD9vKwRW+cF+vmgR9p5K7nxS4pRokIJqF19sALxt5Df0ZrQ/89srYVLh7CHRKELinYqApbqr4Yn7/G9cmw+8YV7PCQ94U88FhYsFJ9eO29Vitgjxt5nr9K1EmIPAMAhffSidc5+YUX1C5I/ZQymknrEx/JXR/5REDCzajp6yUv9h4fR4Hoo+qXss5PsA8rFsmAKZO7SYduNn/OfEyJ2bSGYPykl3Ckm9/K+YDzSWVsNw2/joO/2yPem1KLKXt/gw3vWtDgXPXlD1Vsyh+lGTGrTML0oirCsViG5okBH68wLQm2GL/NbZ1Lp2SnJJoOPe6Pnj+7IQavlm++JkWxXEP8i4hLW+iXbQqgcpKTKU6sEXWMMBowdQp3VqNBsUG99bQ7KRaZVGLdbUvU/6cIrNspOiGVenXGRGoTaRcc/EM7z6KAlm8+cwSafOHmjDcUClSNep+F1fZruFkEmfQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199021)(2906002)(8936002)(316002)(86362001)(66899021)(8676002)(5660300002)(38070700005)(41300700001)(33656002)(36756003)(6486002)(71200400001)(478600001)(122000001)(186003)(26005)(53546011)(6506007)(54906003)(83380400001)(2616005)(76116006)(66556008)(91956017)(66946007)(38100700002)(6512007)(64756008)(66476007)(4326008)(66446008)(6916009)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10074 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e624f4c9-4e56-4441-1c35-08db93818da5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Zn3eBY21AdnPSopNI/1nMWnCQIQcVpFdoPRQkC5+Z8aY5s4/rL5sSR24wu6/J+Km53GRJAKK0hnn1opiR6uyevOKZ8R8C77ayCZx9OVXtRcrK6JUQY8AonO40jzVse+aOOO/U0/njEo6tRM2u0Zv73h+Rarc6SGXULDyPfJRHpwYh79veNsDWsP0mc8uKfVDgDsUTdj13zP/952AwORjIdyXm59fheoZZMh+S6i85rSP6+bgz4cAEkzlBQl+sEui530diXhFBFhvBq45Jo2UMEoTteEVNOGbh4f3R+QmjuOaW0akcpnCUqxGAjCVYr4VgEKcVYLRIXbIpWDBcvsCkAIv0OTmagyKYf5u88Duc5+3fMBoqiWdNXF4LPCip3LVSg8Xeh5YZFwXhQ0LOicleXEBsglGboubHAzdGFYlkce/8RthpBTs5Ck1FZqOSo1mPyAqG4z+eXe0mDY2wYGTz/Pdz+FRraGBvERlAsWrw/9BLL9OweNkr4RGR4GdpWCoT3Ewqzu7eJu4vd4K8zdCfo05dGVax5aMpGiAeaDEYgTePfV2paNjl8sD4qW4Rls0C3L6f8v4SG3EOTIfPBIvp12nm9+cQXa0KSVmiYnBjEbX2iBtWarRAxPveqZLBCRS5JATgS/swHYz/0d9unwEyv9eDDss2rZJ/ijtzMJsN7j8107It6pxmrrCr9sCSMe01NrVgP5/qloDK85P2jWXrpfF4tjolWvwMyFiBUyiweOilZh3mryGa1MFvP8XplD X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(396003)(136003)(376002)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(40480700001)(336012)(40460700003)(2616005)(186003)(6512007)(316002)(86362001)(478600001)(54906003)(81166007)(33656002)(6486002)(70206006)(70586007)(356005)(4326008)(82740400003)(53546011)(6506007)(36756003)(41300700001)(26005)(107886003)(8676002)(5660300002)(8936002)(47076005)(6862004)(2906002)(66899021)(36860700001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 17:54:54.9013 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed789e5-04f1-4767-3c37-08db93819435 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5373 DQoNCj4gT24gMiBBdWcgMjAyMywgYXQgMTg6MzksIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gSGkgTHVjYSwNCj4gDQo+IE9uIDAyLzA4LzIwMjMgMTY6MDUsIEx1 Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4gT24gMiBBdWcgMjAyMywgYXQgMTU6NDgsIE1pY2hhbCBP cnplbCA8bWljaGFsLm9yemVsQGFtZC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IEhpLA0KPj4+IA0K Pj4+IE9uIDAyLzA4LzIwMjMgMTY6NDIsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+IA0KPj4+ PiANCj4+Pj4+IE9uIDIgQXVnIDIwMjMsIGF0IDE1OjI2LCBNaWNoYWwgT3J6ZWwgPG1pY2hhbC5v cnplbEBhbWQuY29tPiB3cm90ZToNCj4+Pj4+IA0KPj4+Pj4gSGkgTHVjYSwNCj4+Pj4+IA0KPj4+ Pj4gT24gMDIvMDgvMjAyMyAxNTo1MywgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+PiANCj4+ Pj4+PiANCj4+Pj4+PiBJbnRyb2R1Y2UgS2NvbmZpZyBHSUNWMiB0byBiZSBhYmxlIHRvIGNvbXBp bGUgdGhlIEdJQ3YyIGRyaXZlciBvbmx5DQo+Pj4+Pj4gd2hlbiBuZWVkZWQsIHRoZSBvcHRpb24g aXMgYWN0aXZlIGJ5IGRlZmF1bHQuDQo+Pj4+Pj4gDQo+Pj4+Pj4gSW50cm9kdWNlIEtjb25maWcg VkdJQ1YyIHRoYXQgZGVwZW5kcyBvbiBHSUNWMiBvciBHSUNWMyBhbmQgY29tcGlsZXMNCj4+Pj4+ PiB0aGUgR0lDdjIgZW11bGF0aW9uIGZvciBndWVzdHMsIGl0IGlzIHJlcXVpcmVkIG9ubHkgd2hl biB1c2luZyBHSUNWMg0KPj4+Pj4+IGRyaXZlciwgb3RoZXJ3aXNlIHVzaW5nIEdJQ1YzIGl0IGlz IG9wdGlvbmFsIGFuZCBjYW4gYmUgZGVzZWxlY3RlZA0KPj4+Pj4+IGlmIHRoZSB1c2VyIGRvZXNu J3Qgd2FudCB0byBvZmZlciB0aGUgdkdJQ3YyIGludGVyZmFjZSB0byBndWVzdHMgb3INCj4+Pj4+ PiBtYXliZSBpdHMgR0lDdjMgaGFyZHdhcmUgY2FuJ3Qgb2ZmZXIgdGhlIEdJQ3YyIGNvbXBhdGli bGUgbW9kZS4NCj4+Pj4+PiANCj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxs dWNhLmZhbmNlbGx1QGFybS5jb20+DQo+Pj4+Pj4gLS0tDQo+Pj4+Pj4geGVuL2FyY2gvYXJtL0tj b25maWcgICAgICAgIHwgMTMgKysrKysrKysrKysrKw0KPj4+Pj4+IHhlbi9hcmNoL2FybS9NYWtl ZmlsZSAgICAgICB8ICA0ICsrLS0NCj4+Pj4+PiB4ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMg fCAgNCArKysrDQo+Pj4+Pj4geGVuL2FyY2gvYXJtL2dpYy12My5jICAgICAgIHwgIDQgKysrKw0K Pj4+Pj4+IHhlbi9hcmNoL2FybS92Z2ljLmMgICAgICAgICB8ICAyICsrDQo+Pj4+Pj4gNSBmaWxl cyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4+Pj4+IA0KPj4+ Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29u ZmlnDQo+Pj4+Pj4gaW5kZXggZmQ1N2E4MmRkMjg0Li5kYzcwMmYwOGFjZTcgMTAwNjQ0DQo+Pj4+ Pj4gLS0tIGEveGVuL2FyY2gvYXJtL0tjb25maWcNCj4+Pj4+PiArKysgYi94ZW4vYXJjaC9hcm0v S2NvbmZpZw0KPj4+Pj4+IEBAIC03OCw2ICs3OCwxNCBAQCBjb25maWcgQVJNX0VGSQ0KPj4+Pj4+ ICAgICAgICAgVUVGSSBmaXJtd2FyZS4gQSBVRUZJIHN0dWIgaXMgcHJvdmlkZWQgdG8gYWxsb3cg WGVuIHRvDQo+Pj4+Pj4gICAgICAgICBiZSBib290ZWQgYXMgYW4gRUZJIGFwcGxpY2F0aW9uLg0K Pj4+Pj4+IA0KPj4+Pj4+ICtjb25maWcgR0lDVjINCj4+Pj4+IFNvLCBub3cgaXQgd291bGQgYmUg cG9zc2libGUgdG8gZGVzZWxlY3QgYm90aCBHSUMgZHJpdmVycyBhbmQgWGVuIHdvdWxkIG5vdCBj b21wbGFpbiB3aGVuIGJ1aWxkaW5nLg0KPj4+Pj4gVGhpcyBtZWFucyB0aGF0IFhlbiB3b3VsZCBm YWlsIG9uIGJvb3Qgd2l0aG91dCBhbnkgbWVzc2FnZSBhcyBpdCBoYXBwZW5zIGJlZm9yZSBzZXJp YWwgZHJpdmVyIGluaXRpYWxpemF0aW9uLg0KPj4+Pj4gU2luY2UgaGF2aW5nIEdJQyBkcml2ZXIg YnVpbHQgaW4gaXMgYSBtdXN0LWhhdmUgSSB0aGluayB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGF0 IGF0IGxlYXN0IG9uZSBpcyBlbmFibGVkLg0KPj4+PiANCj4+Pj4gSGkgTWljaGFsLA0KPj4+PiAN Cj4+Pj4gSSB0cmllZCBhbmQgSSBoYWQ6DQo+Pj4+IA0KPj4+PiBTdGFydGluZyBrZXJuZWwgLi4u DQo+Pj4+IA0KPj4+PiAtIFVBUlQgZW5hYmxlZCAtDQo+Pj4+IC0gQm9vdCBDUFUgYm9vdGluZyAt DQo+Pj4+IC0gQ3VycmVudCBFTCAwMDAwMDAwMDAwMDAwMDA4IC0NCj4+Pj4gLSBJbml0aWFsaXpl IENQVSAtDQo+Pj4+IC0gVHVybmluZyBvbiBwYWdpbmcgLQ0KPj4+PiAtIFplcm8gQlNTIC0NCj4+ Pj4gLSBSZWFkeSAtDQo+Pj4+IChYRU4pIENoZWNraW5nIGZvciBpbml0cmQgaW4gL2Nob3Nlbg0K Pj4+PiAoWEVOKSBSQU06IDAwMDAwMDAwODAwMDAwMDAgLSAwMDAwMDAwMGZlZmZmZmZmDQo+Pj4+ IChYRU4pIFJBTTogMDAwMDAwMDg4MDAwMDAwMCAtIDAwMDAwMDA4ZmZmZmZmZmYNCj4+Pj4gKFhF TikNCj4+Pj4gKFhFTikgTU9EVUxFWzBdOiAwMDAwMDAwMDg0MDAwMDAwIC0gMDAwMDAwMDA4NDE1 ZDAwMCBYZW4NCj4+Pj4gKFhFTikgTU9EVUxFWzFdOiAwMDAwMDAwMGZkNmM1MDAwIC0gMDAwMDAw MDBmZDZjODAwMCBEZXZpY2UgVHJlZQ0KPj4+PiAoWEVOKSBNT0RVTEVbMl06IDAwMDAwMDAwODAw ODAwMDAgLSAwMDAwMDAwMDgxNGYxYTAwIEtlcm5lbA0KPj4+PiAoWEVOKSAgUkVTVkRbMF06IDAw MDAwMDAwODAwMDAwMDAgLSAwMDAwMDAwMDgwMDEwMDAwDQo+Pj4+IChYRU4pICBSRVNWRFsxXTog MDAwMDAwMDAxODAwMDAwMCAtIDAwMDAwMDAwMTg3ZmZmZmYNCj4+Pj4gKFhFTikNCj4+Pj4gKFhF TikNCj4+Pj4gKFhFTikgQ29tbWFuZCBsaW5lOiBub3JlYm9vdCBkb20wX21lbT0xMDI0TSBjb25z b2xlPWR0dWFydCBkdHVhcnQ9c2VyaWFsMCBib290c2NydWI9MA0KPj4+PiAoWEVOKSBQRk4gY29t cHJlc3Npb24gb24gYml0cyAyMC4uLjIyDQo+Pj4+IChYRU4pIERvbWFpbiBoZWFwIGluaXRpYWxp c2VkDQo+Pj4+IChYRU4pIEJvb3RpbmcgdXNpbmcgRGV2aWNlIFRyZWUNCj4+Pj4gKFhFTikgUGxh dGZvcm06IEdlbmVyaWMgU3lzdGVtDQo+Pj4+IChYRU4pDQo+Pj4+IChYRU4pICoqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioNCj4+Pj4gKFhFTikgUGFuaWMgb24gQ1BVIDA6 DQo+Pj4+IChYRU4pIFVuYWJsZSB0byBmaW5kIGNvbXBhdGlibGUgR0lDIGluIHRoZSBkZXZpY2Ug dHJlZQ0KPj4+PiAoWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq DQo+Pj4+IChYRU4pDQo+Pj4+IChYRU4pIE1hbnVhbCByZXNldCByZXF1aXJlZCAoJ25vcmVib290 JyBzcGVjaWZpZWQpDQo+Pj4gSGF2aW5nIGVhcmx5IHByaW50ayBlbmFibGVkIGFsbCB0aGUgdGlt ZSBpcyBub3QgY29tbW9uIGFuZCBub3QgZW5hYmxlZCBpbiByZWxlYXNlIGJ1aWxkcyBGV0lLLg0K PiANCj4gVGhlcmUgYXJlIGEgbG90IG9mIGluZm9ybWF0aW9uIHByaW50ZWQgYmVmb3JlIHRoZSBj b25zb2xlIGlzIHByb3Blcmx5IGJyb3VnaHQgdXAuIEkgd29uZGVyIGlmIHdlIHNob3VsZCBsb29r IGF0IGFkZGluZyBlYXJseSBjb25zb2xlIGxpa2UgTGludXggZG9lcz8NCj4gDQo+Pj4gU28gaW4g Z2VuZXJhbCwgdXNlciB3b3VsZCBqdXN0IHNlZSAiU3RhcnRpbmcga2VybmVsIiBmcm9tIHUtYm9v dCBhbmQgaGFkIHRvIGRlYnVnIHdoYXQncyBnb2luZyBvbi4NCj4+PiANCj4+Pj4gDQo+Pj4+IFdv dWxkbuKAmXQgYmUgZW5vdWdoIHRvIHN1Z2dlc3QgdGhlIHVzZXIgdGhhdCBhdCBsZWFzdCBvbmUg R0lDIG5lZWRzIHRvIGJlIHNlbGVjdGVkPyBJbiB0aGUgaGVscCBpdA0KPj4+PiBhbHNvIHN0YXRl cyDigJxpZiB1bnN1cmUsIHNheSBZIg0KPj4+IEkgYWx3YXlzIHRoaW5rIGl0IGlzIGJldHRlciB0 byBtZWV0IHRoZSB1c2VycyBuZWVkcyBieSBwcmV2ZW50aW5nIHVud2lzZSBtaXN0YWtlcyBsaWtl IHVuc2VsZWN0aW5nIGJvdGggZHJpdmVycy4NCj4+PiBBcyBhbHdheXMsIGl0IGlzIHVwIHRvIG1h aW50YWluZXJzLg0KPj4gQW55d2F5IEkgdW5kZXJzdGFuZCB5b3VyIHBvaW50LCBkbyB5b3UgdGhp bmsgc29tZXRoaW5nIGxpa2UgdGhhdCBjb3VsZCBiZSBvaz8gSeKAmXZlIGNoZWNrZWQgYW5kIGl0 IHdvcmtzLCBpdA0KPj4gY29tcGlsZSBvbmx5IGlmIGF0IGxlYXN0IG9uZSBHSUMgZHJpdmVyIGlz IGVuYWJsZWQNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2V0dXAuYyBiL3hlbi9hcmNo L2FybS9zZXR1cC5jDQo+PiBpbmRleCAyNjRkMmYyZDRiMDkuLjg1YjRhN2YwODkzMiAxMDA2NDQN Cj4+IC0tLSBhL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vc2V0 dXAuYw0KPj4gQEAgLTEwOTYsNiArMTA5Niw5IEBAIHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNp Z25lZCBsb25nIGJvb3RfcGh5c19vZmZzZXQsDQo+PiAgICAgICAgcHJlaW5pdF94ZW5fdGltZSgp Ow0KPj4gICsgICAgLyogRG9uJ3QgYnVpbGQgaWYgYXQgbGVhc3Qgb25lIEdJQyBkcml2ZXIgaXMg ZW5hYmxlZCAqLw0KPj4gKyAgICBCVUlMRF9CVUdfT04oIShJU19FTkFCTEVEKENPTkZJR19HSUNW MykgfHwgSVNfRU5BQkxFRChDT05GSUdfR0lDVjIpDQo+PiArICAgICAgICAgICAgICAgICB8fCBJ U19FTkFCTEVEKENPTkZJR19ORVdfVkdJQykpKTsNCj4gcmFuZGNvbmZpZyBpbiBnaXRsYWIgd2ls bCBub3cgcmFuZG9tbHkgZmFpbCBjb21waWxhdGlvbi4gSWYgd2Ugd2FudCB0byBlbmNvZGUgdGhl IGRlcGVuZGVuY3kgdGhlbiBpdCBzaG91bGQgYmUgZG9uZSBpbiBLY29uZmlnLiBCdXQgSSBoYXZl bid0IGxvb2tlZCBhdCBob3cgdG8gZG8gdGhhdC4NCg0KT2sgSeKAmWxsIGludmVzdGlnYXRlIGl0 LCBhcGFydCBmcm9tIHRoYXQsIGlmIEkgZmluZCBhIHBvc3NpYmxlIHdheSB0byBoYXZlIHRoYXQg aW4gS2NvbmZpZywgZG8geW91IGhhdmUgYW55IG9iamVjdGlvbiBvbiB3aGF0IHRoaXMgcGF0Y2gg aXMgZG9pbmcgYW5kIHRoZSBhcHByb2FjaCB0YWtlbj8NCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4g LS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Aug 02 18:01:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 18:01:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575107.900879 (Exim 4.92) (envelope-from ) id 1qRG9w-00081r-1t; Wed, 02 Aug 2023 18:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575107.900879; Wed, 02 Aug 2023 18:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRG9v-00081j-Tn; Wed, 02 Aug 2023 18:01:19 +0000 Received: by outflank-mailman (input) for mailman id 575107; Wed, 02 Aug 2023 18:01:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRG9v-00081X-4e; Wed, 02 Aug 2023 18:01:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRG9u-0000kL-Vo; Wed, 02 Aug 2023 18:01:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRG9u-0007nz-Ft; Wed, 02 Aug 2023 18:01:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRG9u-0004VC-F3; Wed, 02 Aug 2023 18:01:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rs6UCZtzs7OB8AKJmCbfY3x0c1JpLUMytOSYOBjlXJM=; b=fCp5789QbHBYBx4UJ98z+iAPew MvcTjWKYdF+tsXWGz+MxcFJPTP5ZsDEiKN4ZPjGTV7KzIiIH898eKu3oq+DpnpzJG4E53B5OEI5NG yQaX4pF9u8cMIyvB2YQYt1C3VCSfVLeaCSfCN7choiapYQ6M+Wqeo+EPDZE8m5YpSiEw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182097: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c X-Osstest-Versions-That: xen=fff3c99f84589a876fcd8467ea99f2c8d9ff8d21 From: osstest service owner Date: Wed, 02 Aug 2023 18:01:18 +0000 flight 182097 xen-unstable real [real] flight 182122 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182097/ http://logs.test-lab.xenproject.org/osstest/logs/182122/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 182122-retest test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail pass in 182122-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail like 182072 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182079 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182079 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182085 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182085 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182085 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182085 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182085 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182085 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182085 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail like 182085 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182085 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182085 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182085 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c baseline version: xen fff3c99f84589a876fcd8467ea99f2c8d9ff8d21 Last test of basis 182085 2023-07-31 01:52:13 Z 2 days Testing same since 182097 2023-07-31 19:40:22 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fff3c99f84..c0dd53b8cb c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c -> master From xen-devel-bounces@lists.xenproject.org Wed Aug 02 18:40:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 18:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575117.900894 (Exim 4.92) (envelope-from ) id 1qRGlG-0003j0-TZ; Wed, 02 Aug 2023 18:39:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575117.900894; Wed, 02 Aug 2023 18:39:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRGlG-0003it-Qx; Wed, 02 Aug 2023 18:39:54 +0000 Received: by outflank-mailman (input) for mailman id 575117; Wed, 02 Aug 2023 18:39:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRGlF-0003in-NY for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 18:39:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRGlF-0001i1-3K; Wed, 02 Aug 2023 18:39:53 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.26.206]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRGlE-0001X1-OF; Wed, 02 Aug 2023 18:39:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=GzOA+EIFInXB9PUvby4YlhpdN8FpNm3/+NnR918g4kM=; b=ioP0H6bbkhK5Q57k5XpaiIFt0x LpmbxNOCF1yX9W2wdScczioEDrjjpVD02i2pJx/1rsN5AFdUqMpew8GW8/sMeVFsbgWcOUy7onOJH /F4N+CJ19mpMiV7mzx/GG7At0bmFvNevbk4pKI8kSZWq61UsfalKsj7YMCUEMRhjaZCQ=; Message-ID: <46a985da-03e9-b05d-0107-7c54526c71f9@xen.org> Date: Wed, 2 Aug 2023 19:39:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu Cc: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <9B62D8DC-2425-42A4-A95F-BC41FA27238D@arm.com> From: Julien Grall In-Reply-To: <9B62D8DC-2425-42A4-A95F-BC41FA27238D@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 02/08/2023 18:54, Luca Fancellu wrote: > > >> On 2 Aug 2023, at 18:39, Julien Grall wrote: >> >> Hi Luca, >> >> On 02/08/2023 16:05, Luca Fancellu wrote: >>>> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >>>> >>>> Hi, >>>> >>>> On 02/08/2023 16:42, Luca Fancellu wrote: >>>>> >>>>> >>>>>> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >>>>>> >>>>>> Hi Luca, >>>>>> >>>>>> On 02/08/2023 15:53, Luca Fancellu wrote: >>>>>>> >>>>>>> >>>>>>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>>>>>> when needed, the option is active by default. >>>>>>> >>>>>>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>>>>>> the GICv2 emulation for guests, it is required only when using GICV2 >>>>>>> driver, otherwise using GICV3 it is optional and can be deselected >>>>>>> if the user doesn't want to offer the vGICv2 interface to guests or >>>>>>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>>>>>> >>>>>>> Signed-off-by: Luca Fancellu >>>>>>> --- >>>>>>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>>>>>> xen/arch/arm/Makefile | 4 ++-- >>>>>>> xen/arch/arm/domain_build.c | 4 ++++ >>>>>>> xen/arch/arm/gic-v3.c | 4 ++++ >>>>>>> xen/arch/arm/vgic.c | 2 ++ >>>>>>> 5 files changed, 25 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>>>>> index fd57a82dd284..dc702f08ace7 100644 >>>>>>> --- a/xen/arch/arm/Kconfig >>>>>>> +++ b/xen/arch/arm/Kconfig >>>>>>> @@ -78,6 +78,14 @@ config ARM_EFI >>>>>>> UEFI firmware. A UEFI stub is provided to allow Xen to >>>>>>> be booted as an EFI application. >>>>>>> >>>>>>> +config GICV2 >>>>>> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >>>>>> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >>>>>> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. >>>>> >>>>> Hi Michal, >>>>> >>>>> I tried and I had: >>>>> >>>>> Starting kernel ... >>>>> >>>>> - UART enabled - >>>>> - Boot CPU booting - >>>>> - Current EL 0000000000000008 - >>>>> - Initialize CPU - >>>>> - Turning on paging - >>>>> - Zero BSS - >>>>> - Ready - >>>>> (XEN) Checking for initrd in /chosen >>>>> (XEN) RAM: 0000000080000000 - 00000000feffffff >>>>> (XEN) RAM: 0000000880000000 - 00000008ffffffff >>>>> (XEN) >>>>> (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen >>>>> (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree >>>>> (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel >>>>> (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 >>>>> (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff >>>>> (XEN) >>>>> (XEN) >>>>> (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 >>>>> (XEN) PFN compression on bits 20...22 >>>>> (XEN) Domain heap initialised >>>>> (XEN) Booting using Device Tree >>>>> (XEN) Platform: Generic System >>>>> (XEN) >>>>> (XEN) **************************************** >>>>> (XEN) Panic on CPU 0: >>>>> (XEN) Unable to find compatible GIC in the device tree >>>>> (XEN) **************************************** >>>>> (XEN) >>>>> (XEN) Manual reset required ('noreboot' specified) >>>> Having early printk enabled all the time is not common and not enabled in release builds FWIK. >> >> There are a lot of information printed before the console is properly brought up. I wonder if we should look at adding early console like Linux does? >> >>>> So in general, user would just see "Starting kernel" from u-boot and had to debug what's going on. >>>> >>>>> >>>>> Wouldn’t be enough to suggest the user that at least one GIC needs to be selected? In the help it >>>>> also states “if unsure, say Y" >>>> I always think it is better to meet the users needs by preventing unwise mistakes like unselecting both drivers. >>>> As always, it is up to maintainers. >>> Anyway I understand your point, do you think something like that could be ok? I’ve checked and it works, it >>> compile only if at least one GIC driver is enabled >>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >>> index 264d2f2d4b09..85b4a7f08932 100644 >>> --- a/xen/arch/arm/setup.c >>> +++ b/xen/arch/arm/setup.c >>> @@ -1096,6 +1096,9 @@ void __init start_xen(unsigned long boot_phys_offset, >>> preinit_xen_time(); >>> + /* Don't build if at least one GIC driver is enabled */ >>> + BUILD_BUG_ON(!(IS_ENABLED(CONFIG_GICV3) || IS_ENABLED(CONFIG_GICV2) >>> + || IS_ENABLED(CONFIG_NEW_VGIC))); >> randconfig in gitlab will now randomly fail compilation. If we want to encode the dependency then it should be done in Kconfig. But I haven't looked at how to do that. > > Ok I’ll investigate it, apart from that, if I find a possible way to have that in Kconfig, do you have any objection on what this patch is doing and the approach taken? Even if it is not possible, I wouldn't worry too much about it. While I agree with Michal that it is not great to have nothing printed, Kconfig can only reject configuration that are properly broken. But there are plenty that are sound but would still not boot on some platform. A pretty good example is someone may decide to disable GICv3 and try to boot on a GICv3 platform... Another one is not enabling the UART driver for your platform :). The latter there is nothing we can do without earlyprintk. But for the former, then we can try to enable the console earlier and/or delay when the GIC is initialized. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 18:48:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 18:48:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575122.900905 (Exim 4.92) (envelope-from ) id 1qRGtg-0005Dw-Ne; Wed, 02 Aug 2023 18:48:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575122.900905; Wed, 02 Aug 2023 18:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRGtg-0005Dp-Kh; Wed, 02 Aug 2023 18:48:36 +0000 Received: by outflank-mailman (input) for mailman id 575122; Wed, 02 Aug 2023 18:48:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRGtf-0005Dj-Pk for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 18:48:35 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7e1a::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2dc02f67-3165-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 20:48:33 +0200 (CEST) Received: from DB7PR02CA0022.eurprd02.prod.outlook.com (2603:10a6:10:52::35) by PR3PR08MB5738.eurprd08.prod.outlook.com (2603:10a6:102:81::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 18:48:27 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::52) by DB7PR02CA0022.outlook.office365.com (2603:10a6:10:52::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Wed, 2 Aug 2023 18:48:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45 via Frontend Transport; Wed, 2 Aug 2023 18:48:27 +0000 Received: ("Tessian outbound f5de790fcf89:v145"); Wed, 02 Aug 2023 18:48:26 +0000 Received: from 0776538ef36a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8AADE72D-01B9-4818-ADDE-3AAA5A1491B3.1; Wed, 02 Aug 2023 18:48:20 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0776538ef36a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Aug 2023 18:48:20 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM0PR08MB5364.eurprd08.prod.outlook.com (2603:10a6:208:186::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 18:48:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 18:48:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dc02f67-3165-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nr1QaiDje45fN5p7/GB+rS2vVH33PQsie3UEFvVOUW8=; b=vfEkUlMCZTRn/GWB4H5xxieO781QdiIgDLnwvziyCKXYf2TMcIRRzmfyUb6YJKK/5BcK3vn5UND1lwhQ8ZZHz0eN3k6c5eczxmha4wPx9x/JfQs7fULFk5mvrWLH3WGayQ3pzlxnwbG2gbfF8tnmYhfwP7rfEs+DoESivuFp+Iw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 112f36a131564bb6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GZ6l3Gx4MFKlaxb5whUOWHc/horA5To4WC5epQOu1yKIckDU4cvVqfgXZ8CFg9SXU+5d0kN24x3rtAOnCy40WPjIaNJ0IBPihDKNBcz58u88TiAFxJ/WxPQA5Uqu9YR3x/8ktszrl+S354+DWUsHfb5H86gdYeuMVbibwt7eZ7OTtz+0/eDPDYrO4LdBUKtO2amgjC+KLJ++UakHEOvwq7N2SqSoH4mTxNTACxfnyYL0tSBeQmuvaVQ+umemVvK+FCfz1R6Oqd0tMh8KYh5aejGib0z6RqshaYlm0MoFPTuIePrVEX2MjsTcS73G9mAsHMIELUJopoYwaOFkp23RGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nr1QaiDje45fN5p7/GB+rS2vVH33PQsie3UEFvVOUW8=; b=FrycME60j1VwgdmDdf59cirXeFUjVYIXk5JCIdKnQc6sBaV70UzUPTfHittMKATbIrzIXMegLdrmkKcKrtNcxWqw6MGqniR1Od/cYTk55YNdfrmMwfASgjvhYy8RrFdZPGfk/RknufzYpcDNMwPHNNxy90kBGINVuiSO8B2H2agLMrbqrvASWKo3h7SsIo/alqEZRj+aO0AIVrk70bSXXYHIb+HZVQAXeddQ0coXP55TJuh9K3SbYW2jeDp7jnhrmJlqzqU9WzDjrbAPpJ3CUYJeArxRkDwf7u2c1AsWKzv2rCQbajDNee4+fq13KWr3Yuq8iY2P5H+ftWhVhJsfFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nr1QaiDje45fN5p7/GB+rS2vVH33PQsie3UEFvVOUW8=; b=vfEkUlMCZTRn/GWB4H5xxieO781QdiIgDLnwvziyCKXYf2TMcIRRzmfyUb6YJKK/5BcK3vn5UND1lwhQ8ZZHz0eN3k6c5eczxmha4wPx9x/JfQs7fULFk5mvrWLH3WGayQ3pzlxnwbG2gbfF8tnmYhfwP7rfEs+DoESivuFp+Iw= From: Luca Fancellu To: Julien Grall CC: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/XEDgAgAAEZQCAAAGbgIAABJqAgAArPoCAAAQngIAADKcAgAACUgA= Date: Wed, 2 Aug 2023 18:48:18 +0000 Message-ID: References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <9B62D8DC-2425-42A4-A95F-BC41FA27238D@arm.com> <46a985da-03e9-b05d-0107-7c54526c71f9@xen.org> In-Reply-To: <46a985da-03e9-b05d-0107-7c54526c71f9@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM0PR08MB5364:EE_|DBAEUR03FT018:EE_|PR3PR08MB5738:EE_ X-MS-Office365-Filtering-Correlation-Id: 11a7a808-3ab7-4f94-d768-08db93890ec6 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tMc2opZUmLEsfIBYb7zjCQJyoSkteTJJkLZK8LFS6rytI/jiKLll+YXdrNoUa9chEHs9EsKkyJacL55XZm7QDsD6YOzL1z0IEdw5Ht6KEmu4uvrbJHNVG4mLEUd0+8sTdfIc6bMFVmWqzNyXng6acGKwUqS7bVHZuVsNiLAeZcZQsby+CnoGukl8uH0h6+tEWRDb13Szn8sw6E6ar7NXdBPoawu85sCCH5MvaZr53jlBmk3y0D36KRZobzpZzww5Sp23Wl8q6xQDrOVkB4qvuIwdEnagxBIsUKktfm9CQqEfnCgWmQ5dBt1hWWtSFR6GCIkRKUm6eMySmZfmhuNca6RaGhaTJR+drsNPUdQLkoINAdxYBlpfURgj8TmyqPynibOIvhowfb2hSQXpgmY1DbW0JqAxwo2zqCE81fBToMjflw2gg/u0k0fjwUy6I89mYaz4fJfCY6iB/fncUHin9gPaQaTtmzS0mL6oBS3hpSg72+dKfqNgkRrfabJDoyh6lni+gpFcvJaKjjTtvtahPj3SbFMi/mHXc1nrksM9psyVzi3tyBSDwbnraIYUPR4UDvVPCuX6vzkmd3cWdvFZSGlyCdaPjxEvghBk+xf/ALtOqJldJ9FB/QpjcQQp0vrvKxHKQXv7SfF1ya4l840Xrw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(396003)(366004)(136003)(376002)(451199021)(2616005)(186003)(6512007)(316002)(86362001)(478600001)(54906003)(122000001)(38100700002)(66476007)(66556008)(91956017)(66446008)(33656002)(6486002)(66946007)(71200400001)(76116006)(4326008)(6916009)(64756008)(53546011)(6506007)(36756003)(41300700001)(26005)(8676002)(5660300002)(8936002)(2906002)(66899021)(38070700005)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <73BE56D147FB5442ADF1CC8477AD975C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5364 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 31e93a97-f348-4135-eacf-08db938909bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7czGggujyUqV+Qpso75Nje0g+hZODUS1zcTwPVetrymferReAxG+ZLVICqO6I2UyPEKPeGekwDLgrRKPtewtbPa+r/WeLVHwag8c1bOn9sgC+eWvnuenHji/U5TBCfirIjyO31c0lwwQVXqQfL047Rbmj8OSF1AA1TeKU+3Wa5YFHT2CL+8z1vCrISCjLCaJnKC/nB4zR1zzCTwm+2IbbQQ34TFf9Q5gRHJfCXigMKCweE5Jeqv1p/kyrDDPBEZCEU0LaloPd/R17WggDVZSLqwPv59UwokC8FJs8ZzGwlqS6QlZvzRp9qixlUF9WLf1ma/lMxEevFuAcFmWvMaSendp717yc74QC6Cy9h9/xLgvEvEdKhXO1fAbFRNtP/6zjg7zx59zwHZB7f83uXSGR6vhL2gF1JFbTV/RnwuQymuF89AsHC//FXBdVWCeN6TojRYh3FkobXCMlz0ugDy8EqZa9u/IGXHAPM/4K2lk7VrHUfh9bFU9ztpgS6sFEZAviSZBMXu+e9YZ3M5Fh6ab+QYVIMTHyUACOqZfJcH/IWvnGgqgjmzq7cWoBDN0M9ipPJo37TkkrE2AJvz0IOsmKBXPXJybCg6XJ18ZxAKjv6+cDvElTDrE/W24uBcnQbCvslsymG50QbxJ8kuY+rwf2kuiAzpY7Qzcygqz8muWOU3vtRo+v2bZFK77oOBoH8a5X3PFK9QGGNcw5jg0DwFFiDnNr3tESXcv8D6jOlSQVWS1ixbH3DDb0d/N4B7VWeKn X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(396003)(136003)(376002)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(40480700001)(336012)(40460700003)(2616005)(186003)(6512007)(316002)(86362001)(478600001)(54906003)(81166007)(33656002)(6486002)(70206006)(70586007)(356005)(4326008)(82740400003)(53546011)(6506007)(36756003)(41300700001)(26005)(107886003)(8676002)(5660300002)(8936002)(47076005)(6862004)(2906002)(66899021)(36860700001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 18:48:27.0772 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11a7a808-3ab7-4f94-d768-08db93890ec6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5738 DQoNCj4gT24gMiBBdWcgMjAyMywgYXQgMTk6MzksIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gSGksDQo+IA0KPiBPbiAwMi8wOC8yMDIzIDE4OjU0LCBMdWNhIEZh bmNlbGx1IHdyb3RlOg0KPj4+IE9uIDIgQXVnIDIwMjMsIGF0IDE4OjM5LCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+PiBIaSBMdWNhLA0KPj4+IA0KPj4+IE9u IDAyLzA4LzIwMjMgMTY6MDUsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4+PiBPbiAyIEF1ZyAy MDIzLCBhdCAxNTo0OCwgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6 DQo+Pj4+PiANCj4+Pj4+IEhpLA0KPj4+Pj4gDQo+Pj4+PiBPbiAwMi8wOC8yMDIzIDE2OjQyLCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+Pj4+IA0KPj4+Pj4+IA0KPj4+Pj4+PiBPbiAyIEF1ZyAy MDIzLCBhdCAxNToyNiwgTWljaGFsIE9yemVsIDxtaWNoYWwub3J6ZWxAYW1kLmNvbT4gd3JvdGU6 DQo+Pj4+Pj4+IA0KPj4+Pj4+PiBIaSBMdWNhLA0KPj4+Pj4+PiANCj4+Pj4+Pj4gT24gMDIvMDgv MjAyMyAxNTo1MywgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gDQo+ Pj4+Pj4+PiBJbnRyb2R1Y2UgS2NvbmZpZyBHSUNWMiB0byBiZSBhYmxlIHRvIGNvbXBpbGUgdGhl IEdJQ3YyIGRyaXZlciBvbmx5DQo+Pj4+Pj4+PiB3aGVuIG5lZWRlZCwgdGhlIG9wdGlvbiBpcyBh Y3RpdmUgYnkgZGVmYXVsdC4NCj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4gSW50cm9kdWNlIEtjb25maWcg VkdJQ1YyIHRoYXQgZGVwZW5kcyBvbiBHSUNWMiBvciBHSUNWMyBhbmQgY29tcGlsZXMNCj4+Pj4+ Pj4+IHRoZSBHSUN2MiBlbXVsYXRpb24gZm9yIGd1ZXN0cywgaXQgaXMgcmVxdWlyZWQgb25seSB3 aGVuIHVzaW5nIEdJQ1YyDQo+Pj4+Pj4+PiBkcml2ZXIsIG90aGVyd2lzZSB1c2luZyBHSUNWMyBp dCBpcyBvcHRpb25hbCBhbmQgY2FuIGJlIGRlc2VsZWN0ZWQNCj4+Pj4+Pj4+IGlmIHRoZSB1c2Vy IGRvZXNuJ3Qgd2FudCB0byBvZmZlciB0aGUgdkdJQ3YyIGludGVyZmFjZSB0byBndWVzdHMgb3IN Cj4+Pj4+Pj4+IG1heWJlIGl0cyBHSUN2MyBoYXJkd2FyZSBjYW4ndCBvZmZlciB0aGUgR0lDdjIg Y29tcGF0aWJsZSBtb2RlLg0KPj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBMdWNh IEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQo+Pj4+Pj4+PiAtLS0NCj4+Pj4+Pj4+ IHhlbi9hcmNoL2FybS9LY29uZmlnICAgICAgICB8IDEzICsrKysrKysrKysrKysNCj4+Pj4+Pj4+ IHhlbi9hcmNoL2FybS9NYWtlZmlsZSAgICAgICB8ICA0ICsrLS0NCj4+Pj4+Pj4+IHhlbi9hcmNo L2FybS9kb21haW5fYnVpbGQuYyB8ICA0ICsrKysNCj4+Pj4+Pj4+IHhlbi9hcmNoL2FybS9naWMt djMuYyAgICAgICB8ICA0ICsrKysNCj4+Pj4+Pj4+IHhlbi9hcmNoL2FybS92Z2ljLmMgICAgICAg ICB8ICAyICsrDQo+Pj4+Pj4+PiA1IGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pDQo+Pj4+Pj4+PiANCj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9h cm0vS2NvbmZpZyBiL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+Pj4+Pj4+PiBpbmRleCBmZDU3YTgy ZGQyODQuLmRjNzAyZjA4YWNlNyAxMDA2NDQNCj4+Pj4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9L Y29uZmlnDQo+Pj4+Pj4+PiArKysgYi94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPj4+Pj4+Pj4gQEAg LTc4LDYgKzc4LDE0IEBAIGNvbmZpZyBBUk1fRUZJDQo+Pj4+Pj4+PiAgICAgICAgIFVFRkkgZmly bXdhcmUuIEEgVUVGSSBzdHViIGlzIHByb3ZpZGVkIHRvIGFsbG93IFhlbiB0bw0KPj4+Pj4+Pj4g ICAgICAgICBiZSBib290ZWQgYXMgYW4gRUZJIGFwcGxpY2F0aW9uLg0KPj4+Pj4+Pj4gDQo+Pj4+ Pj4+PiArY29uZmlnIEdJQ1YyDQo+Pj4+Pj4+IFNvLCBub3cgaXQgd291bGQgYmUgcG9zc2libGUg dG8gZGVzZWxlY3QgYm90aCBHSUMgZHJpdmVycyBhbmQgWGVuIHdvdWxkIG5vdCBjb21wbGFpbiB3 aGVuIGJ1aWxkaW5nLg0KPj4+Pj4+PiBUaGlzIG1lYW5zIHRoYXQgWGVuIHdvdWxkIGZhaWwgb24g Ym9vdCB3aXRob3V0IGFueSBtZXNzYWdlIGFzIGl0IGhhcHBlbnMgYmVmb3JlIHNlcmlhbCBkcml2 ZXIgaW5pdGlhbGl6YXRpb24uDQo+Pj4+Pj4+IFNpbmNlIGhhdmluZyBHSUMgZHJpdmVyIGJ1aWx0 IGluIGlzIGEgbXVzdC1oYXZlIEkgdGhpbmsgd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBhdCBs ZWFzdCBvbmUgaXMgZW5hYmxlZC4NCj4+Pj4+PiANCj4+Pj4+PiBIaSBNaWNoYWwsDQo+Pj4+Pj4g DQo+Pj4+Pj4gSSB0cmllZCBhbmQgSSBoYWQ6DQo+Pj4+Pj4gDQo+Pj4+Pj4gU3RhcnRpbmcga2Vy bmVsIC4uLg0KPj4+Pj4+IA0KPj4+Pj4+IC0gVUFSVCBlbmFibGVkIC0NCj4+Pj4+PiAtIEJvb3Qg Q1BVIGJvb3RpbmcgLQ0KPj4+Pj4+IC0gQ3VycmVudCBFTCAwMDAwMDAwMDAwMDAwMDA4IC0NCj4+ Pj4+PiAtIEluaXRpYWxpemUgQ1BVIC0NCj4+Pj4+PiAtIFR1cm5pbmcgb24gcGFnaW5nIC0NCj4+ Pj4+PiAtIFplcm8gQlNTIC0NCj4+Pj4+PiAtIFJlYWR5IC0NCj4+Pj4+PiAoWEVOKSBDaGVja2lu ZyBmb3IgaW5pdHJkIGluIC9jaG9zZW4NCj4+Pj4+PiAoWEVOKSBSQU06IDAwMDAwMDAwODAwMDAw MDAgLSAwMDAwMDAwMGZlZmZmZmZmDQo+Pj4+Pj4gKFhFTikgUkFNOiAwMDAwMDAwODgwMDAwMDAw IC0gMDAwMDAwMDhmZmZmZmZmZg0KPj4+Pj4+IChYRU4pDQo+Pj4+Pj4gKFhFTikgTU9EVUxFWzBd OiAwMDAwMDAwMDg0MDAwMDAwIC0gMDAwMDAwMDA4NDE1ZDAwMCBYZW4NCj4+Pj4+PiAoWEVOKSBN T0RVTEVbMV06IDAwMDAwMDAwZmQ2YzUwMDAgLSAwMDAwMDAwMGZkNmM4MDAwIERldmljZSBUcmVl DQo+Pj4+Pj4gKFhFTikgTU9EVUxFWzJdOiAwMDAwMDAwMDgwMDgwMDAwIC0gMDAwMDAwMDA4MTRm MWEwMCBLZXJuZWwNCj4+Pj4+PiAoWEVOKSAgUkVTVkRbMF06IDAwMDAwMDAwODAwMDAwMDAgLSAw MDAwMDAwMDgwMDEwMDAwDQo+Pj4+Pj4gKFhFTikgIFJFU1ZEWzFdOiAwMDAwMDAwMDE4MDAwMDAw IC0gMDAwMDAwMDAxODdmZmZmZg0KPj4+Pj4+IChYRU4pDQo+Pj4+Pj4gKFhFTikNCj4+Pj4+PiAo WEVOKSBDb21tYW5kIGxpbmU6IG5vcmVib290IGRvbTBfbWVtPTEwMjRNIGNvbnNvbGU9ZHR1YXJ0 IGR0dWFydD1zZXJpYWwwIGJvb3RzY3J1Yj0wDQo+Pj4+Pj4gKFhFTikgUEZOIGNvbXByZXNzaW9u IG9uIGJpdHMgMjAuLi4yMg0KPj4+Pj4+IChYRU4pIERvbWFpbiBoZWFwIGluaXRpYWxpc2VkDQo+ Pj4+Pj4gKFhFTikgQm9vdGluZyB1c2luZyBEZXZpY2UgVHJlZQ0KPj4+Pj4+IChYRU4pIFBsYXRm b3JtOiBHZW5lcmljIFN5c3RlbQ0KPj4+Pj4+IChYRU4pDQo+Pj4+Pj4gKFhFTikgKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKg0KPj4+Pj4+IChYRU4pIFBhbmljIG9uIENQ VSAwOg0KPj4+Pj4+IChYRU4pIFVuYWJsZSB0byBmaW5kIGNvbXBhdGlibGUgR0lDIGluIHRoZSBk ZXZpY2UgdHJlZQ0KPj4+Pj4+IChYRU4pICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioNCj4+Pj4+PiAoWEVOKQ0KPj4+Pj4+IChYRU4pIE1hbnVhbCByZXNldCByZXF1aXJl ZCAoJ25vcmVib290JyBzcGVjaWZpZWQpDQo+Pj4+PiBIYXZpbmcgZWFybHkgcHJpbnRrIGVuYWJs ZWQgYWxsIHRoZSB0aW1lIGlzIG5vdCBjb21tb24gYW5kIG5vdCBlbmFibGVkIGluIHJlbGVhc2Ug YnVpbGRzIEZXSUsuDQo+Pj4gDQo+Pj4gVGhlcmUgYXJlIGEgbG90IG9mIGluZm9ybWF0aW9uIHBy aW50ZWQgYmVmb3JlIHRoZSBjb25zb2xlIGlzIHByb3Blcmx5IGJyb3VnaHQgdXAuIEkgd29uZGVy IGlmIHdlIHNob3VsZCBsb29rIGF0IGFkZGluZyBlYXJseSBjb25zb2xlIGxpa2UgTGludXggZG9l cz8NCj4+PiANCj4+Pj4+IFNvIGluIGdlbmVyYWwsIHVzZXIgd291bGQganVzdCBzZWUgIlN0YXJ0 aW5nIGtlcm5lbCIgZnJvbSB1LWJvb3QgYW5kIGhhZCB0byBkZWJ1ZyB3aGF0J3MgZ29pbmcgb24u DQo+Pj4+PiANCj4+Pj4+PiANCj4+Pj4+PiBXb3VsZG7igJl0IGJlIGVub3VnaCB0byBzdWdnZXN0 IHRoZSB1c2VyIHRoYXQgYXQgbGVhc3Qgb25lIEdJQyBuZWVkcyB0byBiZSBzZWxlY3RlZD8gSW4g dGhlIGhlbHAgaXQNCj4+Pj4+PiBhbHNvIHN0YXRlcyDigJxpZiB1bnN1cmUsIHNheSBZIg0KPj4+ Pj4gSSBhbHdheXMgdGhpbmsgaXQgaXMgYmV0dGVyIHRvIG1lZXQgdGhlIHVzZXJzIG5lZWRzIGJ5 IHByZXZlbnRpbmcgdW53aXNlIG1pc3Rha2VzIGxpa2UgdW5zZWxlY3RpbmcgYm90aCBkcml2ZXJz Lg0KPj4+Pj4gQXMgYWx3YXlzLCBpdCBpcyB1cCB0byBtYWludGFpbmVycy4NCj4+Pj4gQW55d2F5 IEkgdW5kZXJzdGFuZCB5b3VyIHBvaW50LCBkbyB5b3UgdGhpbmsgc29tZXRoaW5nIGxpa2UgdGhh dCBjb3VsZCBiZSBvaz8gSeKAmXZlIGNoZWNrZWQgYW5kIGl0IHdvcmtzLCBpdA0KPj4+PiBjb21w aWxlIG9ubHkgaWYgYXQgbGVhc3Qgb25lIEdJQyBkcml2ZXIgaXMgZW5hYmxlZA0KPj4+PiBkaWZm IC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NldHVwLmMgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPj4+ PiBpbmRleCAyNjRkMmYyZDRiMDkuLjg1YjRhN2YwODkzMiAxMDA2NDQNCj4+Pj4gLS0tIGEveGVu L2FyY2gvYXJtL3NldHVwLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3NldHVwLmMNCj4+Pj4g QEAgLTEwOTYsNiArMTA5Niw5IEBAIHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25n IGJvb3RfcGh5c19vZmZzZXQsDQo+Pj4+ICAgICAgICBwcmVpbml0X3hlbl90aW1lKCk7DQo+Pj4+ ICArICAgIC8qIERvbid0IGJ1aWxkIGlmIGF0IGxlYXN0IG9uZSBHSUMgZHJpdmVyIGlzIGVuYWJs ZWQgKi8NCj4+Pj4gKyAgICBCVUlMRF9CVUdfT04oIShJU19FTkFCTEVEKENPTkZJR19HSUNWMykg fHwgSVNfRU5BQkxFRChDT05GSUdfR0lDVjIpDQo+Pj4+ICsgICAgICAgICAgICAgICAgIHx8IElT X0VOQUJMRUQoQ09ORklHX05FV19WR0lDKSkpOw0KPj4+IHJhbmRjb25maWcgaW4gZ2l0bGFiIHdp bGwgbm93IHJhbmRvbWx5IGZhaWwgY29tcGlsYXRpb24uIElmIHdlIHdhbnQgdG8gZW5jb2RlIHRo ZSBkZXBlbmRlbmN5IHRoZW4gaXQgc2hvdWxkIGJlIGRvbmUgaW4gS2NvbmZpZy4gQnV0IEkgaGF2 ZW4ndCBsb29rZWQgYXQgaG93IHRvIGRvIHRoYXQuDQo+PiBPayBJ4oCZbGwgaW52ZXN0aWdhdGUg aXQsIGFwYXJ0IGZyb20gdGhhdCwgaWYgSSBmaW5kIGEgcG9zc2libGUgd2F5IHRvIGhhdmUgdGhh dCBpbiBLY29uZmlnLCBkbyB5b3UgaGF2ZSBhbnkgb2JqZWN0aW9uIG9uIHdoYXQgdGhpcyBwYXRj aCBpcyBkb2luZyBhbmQgdGhlIGFwcHJvYWNoIHRha2VuPw0KPiANCj4gRXZlbiBpZiBpdCBpcyBu b3QgcG9zc2libGUsIEkgd291bGRuJ3Qgd29ycnkgdG9vIG11Y2ggYWJvdXQgaXQuIFdoaWxlIEkg YWdyZWUgd2l0aCBNaWNoYWwgdGhhdCBpdCBpcyBub3QgZ3JlYXQgdG8gaGF2ZSBub3RoaW5nIHBy aW50ZWQsIEtjb25maWcgY2FuIG9ubHkgcmVqZWN0IGNvbmZpZ3VyYXRpb24gdGhhdCBhcmUgcHJv cGVybHkgYnJva2VuLiBCdXQgdGhlcmUgYXJlIHBsZW50eSB0aGF0IGFyZSBzb3VuZCBidXQgd291 bGQgc3RpbGwgbm90IGJvb3Qgb24gc29tZSBwbGF0Zm9ybS4NCj4gDQo+IEEgcHJldHR5IGdvb2Qg ZXhhbXBsZSBpcyBzb21lb25lIG1heSBkZWNpZGUgdG8gZGlzYWJsZSBHSUN2MyBhbmQgdHJ5IHRv IGJvb3Qgb24gYSBHSUN2MyBwbGF0Zm9ybS4uLiBBbm90aGVyIG9uZSBpcyBub3QgZW5hYmxpbmcg dGhlIFVBUlQgZHJpdmVyIGZvciB5b3VyIHBsYXRmb3JtIDopLg0KPiANCj4gVGhlIGxhdHRlciB0 aGVyZSBpcyBub3RoaW5nIHdlIGNhbiBkbyB3aXRob3V0IGVhcmx5cHJpbnRrLiBCdXQgZm9yIHRo ZSBmb3JtZXIsIHRoZW4gd2UgY2FuIHRyeSB0byBlbmFibGUgdGhlIGNvbnNvbGUgZWFybGllciBh bmQvb3IgZGVsYXkgd2hlbiB0aGUgR0lDIGlzIGluaXRpYWxpemVkLg0KDQo6KSBKdXN0IGZvdW5k IGEgd2F5DQoNCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBiL3hlbi9hcmNoL2Fy bS9LY29uZmlnDQppbmRleCA1Y2RiYTA3ZGY5NjQuLjkzMzA5Y2Q0OTE0NCAxMDA2NDQNCi0tLSBh L3hlbi9hcmNoL2FybS9LY29uZmlnDQorKysgYi94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KQEAgLTE4 LDYgKzE4LDcgQEAgY29uZmlnIEFSTQ0KICAgICAgICBzZWxlY3QgSEFTX1BNQVANCiAgICAgICAg c2VsZWN0IEhBU19VQlNBTg0KICAgICAgICBzZWxlY3QgSU9NTVVfRk9SQ0VfUFRfU0hBUkUNCisg ICAgICAgc2VsZWN0IEdJQ1YyIGlmICFHSUNWMyAmJiAhTkVXX1ZHSUMNCiANCiBjb25maWcgQVJD SF9ERUZDT05GSUcNCiAgICAgICAgc3RyaW5nDQoNCklmIEnigJl2ZSBwbGF5ZWQgYSBiaXQgd2l0 aCB0aGUgbWVudWNvbmZpZyBhbmQgaXQgc2VsZWN0cyBHSUN2MiBpZiBubyBvdGhlciBnaWMgZHJp dmVyIGlzIHNlbGVjdGVkLCBzbyBiYXNpY2FsbHkNCmFzIGJlZm9yZSB3aGVuIGdpY3YyIHdhcyBh bHdheXMgZW5hYmxlZC4NCklmIGV2ZXJ5b25lIGFncmVlcyBJIGNhbiB1c2UgdGhpcyBzb2x1dGlv biBhbmQgaW5jbHVkZSBpdCBpbiB0aGUgbmV4dCBwdXNoDQoNCg0KPiANCj4gQ2hlZXJzLA0KPiAN Cj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Aug 02 18:57:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 18:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575129.900918 (Exim 4.92) (envelope-from ) id 1qRH2N-0006mq-OT; Wed, 02 Aug 2023 18:57:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575129.900918; Wed, 02 Aug 2023 18:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRH2N-0006mj-Ld; Wed, 02 Aug 2023 18:57:35 +0000 Received: by outflank-mailman (input) for mailman id 575129; Wed, 02 Aug 2023 18:57:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRH2M-0006md-ET for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 18:57:34 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e32f7f1-3166-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 20:57:31 +0200 (CEST) Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 372HJ7fh009355; Wed, 2 Aug 2023 18:56:52 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s4spc839u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Aug 2023 18:56:52 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 372Iixod015769; Wed, 2 Aug 2023 18:56:51 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2046.outbound.protection.outlook.com [104.47.57.46]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3s4s78jk7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 02 Aug 2023 18:56:51 +0000 Received: from CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22) by CO6PR10MB5585.namprd10.prod.outlook.com (2603:10b6:303:144::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Wed, 2 Aug 2023 18:56:49 +0000 Received: from CH0PR10MB5020.namprd10.prod.outlook.com ([fe80::847f:ef72:f382:87f2]) by CH0PR10MB5020.namprd10.prod.outlook.com ([fe80::847f:ef72:f382:87f2%7]) with mapi id 15.20.6652.019; Wed, 2 Aug 2023 18:56:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e32f7f1-3166-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=UEtdnVsxy+ikkjByO/gkZiKE1KvjbFWBawdvnlleMGE=; b=NuWpDFZsiUNAumuC75W6LLG8D/eR7ZHHNLu39z3r6dCzzujQ7puwcIYc+S1WPSVR1JFf nUCSSEnQsf3KMMFGhTdTaAESPo4Cv98S8U92ByUgl3azHHsdXrBizUSIRPJAFqLUKo+b 50W1xALFLnvUXM+FKEJma/FCNy+ZKIfuvY1kJracoenoqYC9b9yCMESSgQQKdyBswTgF 1Ktul6b5T/ct16lv6clYZLTaSb5B2vXwR9xkvYBAa2eO1Ic/eGKkS/66syyI+TgeweZa L1tk5dZr6MR/vB/CTJy+lUYohIyE2I1VgY/6OLP6/C+J/XaqIOIx9m4tgIYAVAFOjUgz zQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NyW5c7YXC0mFK/Gp3UbgaqazBLRRZp1rLXdjq4nvWM5OhXzYx+OtBK5ma/uGHXSAe+OZx3INwr0YqrJHmAfn3rT2t17J5PyOOxBvvEt99xGUrupuueIsbrr2d2R3WdzZwPINlBDa5Jx4v+MINtPAULCQbc7FDiwpklWeijI7VreP+oSNqLUWU6yXkLeFZzJ5iPf3gDtQdxA0xlOUW8duyK/FUpa0C8Ixy13YEESTwcWqvxuVFALPaZgM+NjGK/oqepWc72rG5CSH6mP3F4jVFc2ndWRQwLt0pqElqeuj1MK6xlYbKsK/POThYvMUyAvDg1EFkWLjL79oHa205/V8gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UEtdnVsxy+ikkjByO/gkZiKE1KvjbFWBawdvnlleMGE=; b=md1LgvDEm3V3BnIpz8pc0vZYaL66SJcGPZMt/FbXx0Ra0IvJkzSzhrFOkBhl6G86AchdkK4HkDgGTfvFdRcKW66Os9h/9U0BeT7ESdKRpYL//ThhlHnVoiV3RpgWCjOULBlZHI2rvYwlnycDtD+lPpVYTl7k8phqIjq0a47NY519vUJWX35tPmqnfgb3xNVOv7R+cOyFz9mlofHEpV0eetFVV5T56t+svlgP9BmsQjz4dNvxn4DJ5pE6aN61x8SCBVB+G8B3zgg1wzQKR9QawUyjTCP4SDZLeFl2TWsDCQ2crIksW3OV6qLZDRAkCMq5fRXaXe/o+6Lo4xRpHPhx1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UEtdnVsxy+ikkjByO/gkZiKE1KvjbFWBawdvnlleMGE=; b=NRF0cJB/6FOYMyyLwltiN7LwtoGhzrAb8RfkQEBfJFdLVNm6W593QoZs71gwxQSVWV7d8QGwJ93JwNFhZL1n6Vw0dmKt0cr/IfpNDqY/3/KNYdP94Duco++L6X1R3FPpmgLpRjIyV7RN0+Ujw1Yji3UAfoFC1LfdMehdHK3vGVU= Message-ID: Date: Wed, 2 Aug 2023 14:56:39 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v1] xen: remove a confusing comment on auto-translated guest I/O Content-Language: en-US To: Petr Tesarik , Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "moderated list:XEN HYPERVISOR X86" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Cc: Roberto Sassu , petr@tesarici.cz References: <20230802163151.1486-1-petrtesarik@huaweicloud.com> From: Boris Ostrovsky In-Reply-To: <20230802163151.1486-1-petrtesarik@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0043.namprd11.prod.outlook.com (2603:10b6:806:d0::18) To CH0PR10MB5020.namprd10.prod.outlook.com (2603:10b6:610:c0::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH0PR10MB5020:EE_|CO6PR10MB5585:EE_ X-MS-Office365-Filtering-Correlation-Id: 51d65094-5bde-4a50-e46e-08db938a39d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oVoc2OEZ2FV+CoL10csXoRVghcz2kKQeXm+n/hDcgWMItq8aKV19Vb5JG2wYDvoOHznCOEKvaYcR3xqq3EGFN9roDlvxGgm74O0UlbUpSTO8PXSS5UF1fnJQwzj9iiMUUuYBCaYVheupbi664dRulTnxjaH0Slbt+jv0DkzOLDZDRwiUJf9EF1Fv1qzUmJFjf3xyaDZ+tToAdkrwVIfMRIse2plOx3C4wVYzolE2jLtwUWP+fWr90bwheLjmntPg1LYQ2C4MlPL8blvNVJNr/PXIRan9UsVytPdAWSVxfv38WCt25CKOrUFbsEgb7gtBghRjMyQD1p9VVN19EVQp9Hilupatu2ZeFYTmaSdmhyPCL/6nxwJYCtSwWVkc45k1YouJlAiAKFF+bPRGgi1o2Gwl9acAG5T0gvGmTts5fQJkIEW0YOLpUkIdGSNFHbnWvkoxbHroMUpg1720Ud9ocILvHu5T+hUS7R1xXu9yC/q+kprUhMOXZKWn5W4BEMcW9aLCX6NrG1V9MQ2n+Wvq/9PQM93051jeAdXFIbB6Lr0XsLfo5Fj9ees3StZZdEknVW3Kt2wDYutXinb9eUy81YeXRX0hPStVRDxyNU/CWoTnXmfmnR4z8LVPj1PaXPfqrSzbN3gHISxAuB+MWi+eShkm+DYViHyOdAI+IW8kM1c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR10MB5020.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199021)(44832011)(6512007)(6486002)(36756003)(53546011)(2616005)(186003)(6506007)(26005)(66946007)(921005)(38100700002)(7416002)(110136005)(4326008)(316002)(31696002)(86362001)(66476007)(41300700001)(8936002)(8676002)(5660300002)(31686004)(2906002)(66556008)(6666004)(478600001)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWVEYm8ySXNOU0RqckM1cWJYVnVlbWhjODF2M0J4VXdqV3RnU2RKMkxhNFgw?= =?utf-8?B?YmxUM2daSVdGV2tXQXNCdzc4dThTVnM3bFROSGJlRmxlMWZtM3lubG8wSjRx?= =?utf-8?B?cUdJL3NKaTk4czZBa0UyaE1YY2NEU0NMUklGcWRxZGk3SHZPQVFjS2Jac1V5?= =?utf-8?B?NGQxNG9qT0xMbS9vZkxxbUpMakpjWnNUYWJtL293cmxvOUdKa0t1b2gyK0l5?= =?utf-8?B?Z2JXNkUxSUtzaUY1bENTKzdMR1p6a0VJbHJLK3p2am85SzY0bzQyUy9MRXJh?= =?utf-8?B?WE5obDhLc1QvZjVFd25DdW1RRHZlaHYvMTZzN2I2ZHAyNHJlZDRwQk85RnJ6?= =?utf-8?B?d1NVLzhpa293bUlGQ0FvKzllWHA4UC9xWitxTit3VUxKTHU1eVVCMHdNNk1K?= =?utf-8?B?Y0RreTg4eEhiaEVpWGNSd2ZFaU1SeFdNOHhrd0FDSmFoaTdaL2tUR1FoMFVs?= =?utf-8?B?WkZYdk11SHRFSlkvVGhUb1JIc3BhRlNXNVhxTXhWbnlQclVPN1pmbVZrN1Jp?= =?utf-8?B?ci81MWpjbmFMcDVxbzFtNkw0cHJyOFY4T2FuUklSYjdpSlZsYzM1N2NEL3ZI?= =?utf-8?B?SVdhZTlCTzFNbEp3RUtiWmtkZCtRUE43ZUxlV1UzN0hNd0F6R1BRZ1ZpRGhs?= =?utf-8?B?K0NMNCt3TlUvbWE0OFVHS0V2VTlHeWlZaVVYMllITkxUNW5qRWV1QVhhYUkw?= =?utf-8?B?eVVDZFhJOWdVUEF2SFd4SjdJTm9lMzRaN085ejZTL3pRSGJqRlNVVDkrS0Fl?= =?utf-8?B?dWllQ0F6dGFkWjI2YmMrSGpFcWtiS1hxUlVSNHRLZjlkUUhPVGhZQnVocXpk?= =?utf-8?B?U3MvNlZuQ0hZS1ZKVDlXS2FoVEJ6N0lPNERhRmgzLzRFOTJ6V25zZ0IrVHNV?= =?utf-8?B?TDROS3dSSW9JV0ZxQjVoYjlqVHMrVHJxSXU1M3NaVWZYK3FvbDdDS3dDUXls?= =?utf-8?B?ZU9ETmpmTjRzajE4SXFGTXhYaXBTamllbisvR1o1QlBha2hLMGhwdW40b3hw?= =?utf-8?B?dzhQQStwdHFnVmZ3SGoyZDlMdVllZTN3QmE1M050MGlVVDMxdjhDc1R1TVdm?= =?utf-8?B?eTNQNmRvS3hUZnY4NXdFRTZ5Nk1QQVJuOUd3RlFEYy95RVRoTVR6TWRNTWZR?= =?utf-8?B?WDV4clJOeUFNQlQ4SjJ5RXFrVFpwVGhlcTNHMng2djZIZ1BXVTE3SkFJeCt1?= =?utf-8?B?MVN6UnFtUm9kYk5zbEZ1ZTBEUVhmeEc4cHl6U2V1ZXdLTS8vK09jOENsSTRV?= =?utf-8?B?TUp3YjAwTWVnOUlKU1ZaYmdhSGt3Q2xHKzA0THJsUU50M0RUdDNsSXNrOWEr?= =?utf-8?B?TEVCZlJzVXRaL2twTkxuNSs0b2l0dThWWUwrSzBBVkcvRzgxSGNtcGE1RTVa?= =?utf-8?B?ZlR6b1ZSN3F5OEVyZUhRbEplZDVaK01WcGtOZE80ekFoMVp6dHJ2ZEhuSDUx?= =?utf-8?B?azVNeTIrcmo4VHZnWFU3N1FmNGtyV0E0Ty83Vkk4Sy94V0lvVFhPc0pyMlc3?= =?utf-8?B?WCtmSUlmZm0rOW80NGVXYmRmdnoyaHZCNWlJcWxuV28wRk5jT1M5YndDczdI?= =?utf-8?B?OFl6MGJMY0tRbHhOUzAxQzZ4bTRiNTNnOXRwZHgyTHFyNExwK1ZvRFBjVzJS?= =?utf-8?B?bnpxbmY2VEk2aVpZK1ExNmN2dHNDUW5MdkJadmNjekg4NlFVajB3RklYWTFl?= =?utf-8?B?Tm52SDRpRVFVaW5aalR2NjRhWmhYRms4RHVqa0ZDZ1FPanluQUN1aFRYVkVO?= =?utf-8?B?dmVBWkNXcUNLODhNMkNPNndyNHRQdFpKY2xhbzkrMnlNbTJZTWlnaGhrYTBy?= =?utf-8?B?Y01HaXhPVSt6T1d0UGtGYWFVNUE1R05DYU5XMTIzZ3MzV0VXWVBxQmtBbE1Z?= =?utf-8?B?TnFSSUFMQzZOZjJpaVZxK3B0V3BCY3Z1cWw3V0p5U0E0ZjBuaUtST1VhMmFn?= =?utf-8?B?Q1crU3NhUkFFdEh5aitwZ2NwaDRScDY5Q2NKai90MHRTSFJqV0w2VG9yYVlo?= =?utf-8?B?dit1d290MDVIY0svaytiY1lEVTRsQjFqRUNMeldpa1BiMVdDR3RHa1E1RFlE?= =?utf-8?B?d2lmdUFac0tZTytaajZiQWFQWnNqQk9vK3pyaG45TUtZa1N5dkVJQXRPdnU4?= =?utf-8?B?MDVvZHFCak9aM1ZmdnV2Vms3ckFuYjEzMEh0TzIvS25nemhFR1lLdUlhZWVW?= =?utf-8?B?d1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YUppOHhiL3owaGdIWlpxTzlJc0hYVnVmOTR0Y0xiclUyaVk2akNjSHNlaDVt?= =?utf-8?B?Rlk2SVowbkZYdnNFWW5GU2lSOHk1OU9lM3ErK0RYaWU5SHNhLytSeGJzNkxk?= =?utf-8?B?VEhCL1J6SXZDckdwVVdsb09pVGNpOTV6YWFQNHBhNHhkdUpobzYrRzFaRHZ6?= =?utf-8?B?bzdySEtPS0gweEh2dEZydjFKSjBWWmIzVzdFTXFzTlg2Sys4dWtBTkViNWEy?= =?utf-8?B?SGs5aWFMTlY3elpmOTFJTGlvZU53dmdmcmNkcU4wWndyMkZkd1BNSFU5aFBL?= =?utf-8?B?R1E4aDZqdHl2NHdTaHFBVGlWdUxsNGkzQW9kdEZWbUdTYWdwU002TWNiajdE?= =?utf-8?B?NlZPWGRQYlJCaGdvYTkvdlQwVEY3NG4rTUw3anh2UWpvUHcwcEFTV2NLVzgr?= =?utf-8?B?WkFvREFGdHhsamw1ZGdzaUJLVzZVV2xxRUJoWFdGR29JSEt4OWZTZnpHSy9h?= =?utf-8?B?WjZqVjAzcC9UOU9OY0d5d2p1bjlGMFd6cC91NFpjVC90UEdTckNCT2RjYk1P?= =?utf-8?B?UTdiVGpSSU51blRHa3kwQVVvbk84bjRxcjBzQ2lINmFOUDRXSnVxSUpQSTU2?= =?utf-8?B?c2FHbk9GOUh5REVkR3hRR2xZTDl3VkY4TldSOGVDcUY0UjUyamZ0RUIzQWFB?= =?utf-8?B?R0xLS1dvQ3l6NTJsTkhmV2E0Qlk3eU1LNW1zU3hQd0dkTWVOc2doQzJhbExs?= =?utf-8?B?UThvZG90ZUhKWnFJenV0ckpKdGdLY3NKRkhhOW1ENjI1eGxrL3BxaWhMb0ZI?= =?utf-8?B?ckp5REMzL09TZGR4Z2NGSEZRT0hGMUN5OFl4RnNHS1JtMklUcnFXY0RxbklD?= =?utf-8?B?SVpneHFXTFB1cE5oSm1lS1lRdmlBNkZzdVZ6T0QrN1VqaGM4S21HeCtzeWxR?= =?utf-8?B?aW9YeEJhRm44Zm80OUIyV1VoZlRFY2g3S1JPK3FxeHFZNWlHN25DcWVzUGxp?= =?utf-8?B?TjlvUXNBNGpRdk5MRmt6MDIrV2R6Rm1SamV0QTBPdm9EOGlrVWlYMk1GVjFh?= =?utf-8?B?RXphY3lTQlA5N3FkWnlzRk1sS0pnKzVoUXhkekZuaTRIdUIxdGgrdEh0WFZx?= =?utf-8?B?NUdFOVUzZnJVNGFnbFVyQ0pHWmFTa080bjA3WDVTQXJ5T3RydHJDejJueTBO?= =?utf-8?B?MHhQVDA3dVdwZFNLaHpDZDdDS3d6OXIwRHl5QUNJQ25tOTNOa0V3QlBiaTg0?= =?utf-8?B?U1NxSVg2R0FIM2xuRGxKVlhydzZxMXdmaTBrMHk4Qi9HTGlNZ3R4VmRTVCtW?= =?utf-8?B?Z0N4bk9rbGcyVGpib2RkeTZRTmNxL0JmOUdvNkNrWkdyU2N0TVNKRGpTbWNX?= =?utf-8?B?N0YyVVNDUkhpekd0SGRmZU4xczBqK21HMDVrZi9DaVNCZW15NXFBdXBiNUtr?= =?utf-8?B?eDZkZkNtOWZVOURKR0lFN2NPRUtxWW5oeStUaXhld0lodmswVzIxSTkxWjRo?= =?utf-8?B?a1JGL1lkdEhMcjU2SWJ3bnBFWDhHWVUreTN3emxMWXRYZjRTRzJaYzVET1NR?= =?utf-8?Q?vKopuA=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51d65094-5bde-4a50-e46e-08db938a39d2 X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5020.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2023 18:56:48.9789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 07zrAWeLSrUhF94OECeIr04eE9i2SdqcTmxooiPEFXXDI6ZHj5v3WeS3BeF7jVnj81IzuTeKdR+G0Y7PgCQys7MH0AWOqW7x0oBC0YDvVYA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5585 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-02_15,2023-08-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308020167 X-Proofpoint-ORIG-GUID: k5QIQZ3bJpy7Tc2F4b9X9y2ETc8NWHLV X-Proofpoint-GUID: k5QIQZ3bJpy7Tc2F4b9X9y2ETc8NWHLV On 8/2/23 12:31 PM, Petr Tesarik wrote: > From: Petr Tesarik > > After removing the conditional return from xen_create_contiguous_region(), > the accompanying comment was left in place, but it now precedes an > unrelated conditional and confuses readers. > > Fixes: 989513a735f5 ("xen: cleanup pvh leftovers from pv-only sources") > Signed-off-by: Petr Tesarik Reviewed-by: Boris Ostrovsky From xen-devel-bounces@lists.xenproject.org Wed Aug 02 19:07:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 19:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575133.900928 (Exim 4.92) (envelope-from ) id 1qRHBo-0008Ip-O2; Wed, 02 Aug 2023 19:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575133.900928; Wed, 02 Aug 2023 19:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHBo-0008IY-Ig; Wed, 02 Aug 2023 19:07:20 +0000 Received: by outflank-mailman (input) for mailman id 575133; Wed, 02 Aug 2023 19:07:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHBo-0008II-5P; Wed, 02 Aug 2023 19:07:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHBn-0002O0-W1; Wed, 02 Aug 2023 19:07:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHBn-0002c4-ET; Wed, 02 Aug 2023 19:07:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRHBn-00031W-Dv; Wed, 02 Aug 2023 19:07:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B+8Zafxj7xdEO39u8VL+n1y0SwRZMEiEXLk1iFu7CWQ=; b=lqBLL8+wSH3jiC0SbPvqBW27QV okq010PnqQkTvQC573+Vb1aytzC8neVk7YyfrrdCux8JfEmIKg7YYOSWdd9DpSH3VrsQ4Oz2xdiW6 U0W/lyHxceDfCSS72Tu2jkiCChMEoqyGjxewg4rubuXPU0DYRqpPu7pPdeO5UkAAKA18=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 182099: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=a3a8cc0415cc46ffc4d89d60ba3d742a02880a36 X-Osstest-Versions-That: libvirt=010cfec9690d68e26ba4e3747c5c636d3d1f39f0 From: osstest service owner Date: Wed, 02 Aug 2023 19:07:19 +0000 flight 182099 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182099/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182068 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182068 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182068 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt a3a8cc0415cc46ffc4d89d60ba3d742a02880a36 baseline version: libvirt 010cfec9690d68e26ba4e3747c5c636d3d1f39f0 Last test of basis 182068 2023-07-29 04:18:56 Z 4 days Testing same since 182099 2023-08-01 04:20:48 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Privoznik ê¹€́¸́ˆ˜ jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 010cfec969..a3a8cc0415 a3a8cc0415cc46ffc4d89d60ba3d742a02880a36 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Aug 02 19:15:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 19:15:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575140.900941 (Exim 4.92) (envelope-from ) id 1qRHJh-0001Od-G7; Wed, 02 Aug 2023 19:15:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575140.900941; Wed, 02 Aug 2023 19:15:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHJh-0001OW-Cw; Wed, 02 Aug 2023 19:15:29 +0000 Received: by outflank-mailman (input) for mailman id 575140; Wed, 02 Aug 2023 19:15:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHJf-0001OQ-Qw for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 19:15:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHJd-0002X8-Qs; Wed, 02 Aug 2023 19:15:25 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.26.206]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRHJd-0002tN-JG; Wed, 02 Aug 2023 19:15:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=d1wLjcJg9FiEWaX/Xn3WopQJZQYBCLitG5chy4hwaxs=; b=sMTpKGAKHprp63kxop31AE9YrV E8K/w80G/j6Lf1RVUtIhRSyV9reZSIg43m/lkjsDfq+DDzIGVCGUEMfW1LNDZ9DSTa3x3s4mo4he0 WTMkflFLNryJlf0zJxYZe0MEDj5lp6DkOFaGZkejFFEHzVaotZoVE/4Gmq96WBmgEtCs=; Message-ID: Date: Wed, 2 Aug 2023 20:15:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu Cc: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <9B62D8DC-2425-42A4-A95F-BC41FA27238D@arm.com> <46a985da-03e9-b05d-0107-7c54526c71f9@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 02/08/2023 19:48, Luca Fancellu wrote: > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 5cdba07df964..93309cd49144 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -18,6 +18,7 @@ config ARM > select HAS_PMAP > select HAS_UBSAN > select IOMMU_FORCE_PT_SHARE > + select GICV2 if !GICV3 && !NEW_VGIC > > config ARCH_DEFCONFIG > string > > If I’ve played a bit with the menuconfig and it selects GICv2 if no other gic driver is selected, so basically > as before when gicv2 was always enabled. > If everyone agrees I can use this solution and include it in the next push I am not thrilled with this approach. I understand that the default today is GICv2, but why should it continue to be like that? Even if we were switching to GICv3, it feels rather a odd approach because you would make it work for one set of the users but not the others. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 19:17:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 19:17:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575143.900950 (Exim 4.92) (envelope-from ) id 1qRHL9-0001wK-Qw; Wed, 02 Aug 2023 19:16:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575143.900950; Wed, 02 Aug 2023 19:16:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHL9-0001wD-OC; Wed, 02 Aug 2023 19:16:59 +0000 Received: by outflank-mailman (input) for mailman id 575143; Wed, 02 Aug 2023 19:16:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHL8-0001w3-Me; Wed, 02 Aug 2023 19:16:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHL8-0002Yn-Lo; Wed, 02 Aug 2023 19:16:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRHL8-00038A-Dm; Wed, 02 Aug 2023 19:16:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRHL8-0006F7-DK; Wed, 02 Aug 2023 19:16:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/A9jcQgu82W2daKxACbEoJxl2WtNy9GipRlWvoJMxTw=; b=JCWGJ3/6b/JF/KPB4454yOHZwA S+GzNKwZkW7nwtdvoGtvjNIsJ3Ktwr070pTrOS2gh9u3+TMtr0bF5q1oOlvRO1vJwBUw+Z5qfgHWE 0WgOnXGsub+urwoUf8hYB8agga82Rj6bsTFwuO/eCuLOMLIIOOo/RJ5Ud62HBdouvT3o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182124: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=da55d9dc919752e092e591a74ab54c2f7d5adfab X-Osstest-Versions-That: xen=51588938e0cd0e02dbc1d6d8c697c577135ff666 From: osstest service owner Date: Wed, 02 Aug 2023 19:16:58 +0000 flight 182124 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182124/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen da55d9dc919752e092e591a74ab54c2f7d5adfab baseline version: xen 51588938e0cd0e02dbc1d6d8c697c577135ff666 Last test of basis 182112 2023-08-02 09:00:26 Z 0 days Testing same since 182124 2023-08-02 16:10:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Nicola Vetrini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 51588938e0..da55d9dc91 da55d9dc919752e092e591a74ab54c2f7d5adfab -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 02 20:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 20:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575161.900969 (Exim 4.92) (envelope-from ) id 1qRIIm-00009n-JG; Wed, 02 Aug 2023 20:18:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575161.900969; Wed, 02 Aug 2023 20:18:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIIm-00009e-GF; Wed, 02 Aug 2023 20:18:36 +0000 Received: by outflank-mailman (input) for mailman id 575161; Wed, 02 Aug 2023 20:18:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIIl-00009S-TD; Wed, 02 Aug 2023 20:18:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIIl-0004C0-Ro; Wed, 02 Aug 2023 20:18:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIIl-0007Nt-Gu; Wed, 02 Aug 2023 20:18:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRIIl-00064q-GQ; Wed, 02 Aug 2023 20:18:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WW3CnyCo5oqE4S8av5AUU8E8WLCj6QoZaXb44jbsiGE=; b=0QW0tx8kkC798clXJAJBJ6Dgfv e0j6NRpKC+Hf266QHffuyj/Sh8zhfDElqVYC5blUWQB6NhlhQodlJWILLIueUnCKSiKKCjcVVQ6NR W9k7MkiicV2sEd8CUmgBGZcSIweLQSYiiYGEhY1rim+jveAm6HtoLI7+7XnoOVjsGivQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182121: all pass - PUSHED X-Osstest-Versions-This: ovmf=fa789cc68a85a5781c18c64b9112c779750b2125 X-Osstest-Versions-That: ovmf=5cadb8ce2148979b6c464f6da5a8cd97425c5165 From: osstest service owner Date: Wed, 02 Aug 2023 20:18:35 +0000 flight 182121 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182121/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fa789cc68a85a5781c18c64b9112c779750b2125 baseline version: ovmf 5cadb8ce2148979b6c464f6da5a8cd97425c5165 Last test of basis 182111 2023-08-02 08:42:38 Z 0 days Testing same since 182121 2023-08-02 15:40:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Joey Vagedes Joey Vagedes jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5cadb8ce21..fa789cc68a fa789cc68a85a5781c18c64b9112c779750b2125 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Aug 02 20:19:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 20:19:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575165.900980 (Exim 4.92) (envelope-from ) id 1qRIJx-0000gI-Ty; Wed, 02 Aug 2023 20:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575165.900980; Wed, 02 Aug 2023 20:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIJx-0000gB-R7; Wed, 02 Aug 2023 20:19:49 +0000 Received: by outflank-mailman (input) for mailman id 575165; Wed, 02 Aug 2023 20:19:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIJw-0000fz-Ar for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 20:19:48 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb0f4094-3171-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 22:19:45 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691007580777367.84003628495543; Wed, 2 Aug 2023 13:19:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb0f4094-3171-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691007583; cv=none; d=zohomail.com; s=zohoarc; b=b7hovrLJM2gMZUtVHQojyZiIU+PiuLTi02e9181eLDfBFvrvI73R+cKfOyhyos23ZjyXBPBQ+eYYAdq8bawsOw+aDtiKSM72DMPpAmhsfVvBVGA2eNtb1XVbnD7U4Eflv8+P8zFDV3F1a/cy90df0tmA7SP2oomtfm7JQQfZb2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691007583; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=cXdqKLC6su+a6fFUARpsTMErLg/CXMnfU4mRRHRkGKE=; b=JMRqWkVJSKUuynFFxDtw1wAzi2B3xZnjiRjAeSSRs/1YchgMsHh9N3smEGEAojP7aUMAytpstXDGJkFwIFhwV6vA91oLCKaABKY6NNW+pEls831arwIpNImEWLE7HhpyzGsnIHvnaPyXJHR0xVyEHv6e5vf8iLXRsRagdrgD+2M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691007583; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=cXdqKLC6su+a6fFUARpsTMErLg/CXMnfU4mRRHRkGKE=; b=syKOAf7NScc8ArgMsH1zxg0VDolAMJuNrZDVspxYy5DET2NaDbqtr544o31KVQbg kAreS3teJP9qJK7A3eviEGu5y2dmC2Kc/nOlFvz5A01bqaQvNroXsypqLLqPkug38QB fPVzycaAehklGhnhWGIR1Ov95NGgxOmFx5YAWkgY= Message-ID: <7afba030-48f2-baaf-02f9-dae84107a620@apertussolutions.com> Date: Wed, 2 Aug 2023 16:19:38 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Volodymyr Babchuk , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230801161409.25905-1-dpsmith@apertussolutions.com> <20230801161409.25905-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 02:13, Henry Wang wrote: > Hi Daniel, Hey Henry! >> -----Original Message----- >> Subject: [PATCH 2/2] fdt: make fdt handling reusable across arch >> >> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is >> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is >> introduced for when the ability of parsing DTB files is needed by a capability >> such as hyperlaunch. >> >> Signed-off-by: Daniel P. Smith >> --- >> MAINTAINERS | 2 + >> xen/arch/arm/bootfdt.c | 141 +------------------------------ >> xen/common/Kconfig | 4 + >> xen/common/Makefile | 3 +- >> xen/common/fdt.c | 153 ++++++++++++++++++++++++++++++++++ >> xen/include/xen/device_tree.h | 50 +---------- >> xen/include/xen/fdt.h | 79 ++++++++++++++++++ >> 7 files changed, 242 insertions(+), 190 deletions(-) >> create mode 100644 xen/common/fdt.c >> create mode 100644 xen/include/xen/fdt.h >> >> +void __init device_tree_get_reg( >> + const __be32 **cell, uint32_t address_cells, uint32_t size_cells, >> + paddr_t *start, paddr_t *size) >> +{ >> + uint64_t dt_start, dt_size; >> + >> + /* >> + * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit. >> + * Thus, there is an implicit cast from uint64_t to paddr_t. >> + */ >> + dt_start = dt_next_cell(address_cells, cell); >> + dt_size = dt_next_cell(size_cells, cell); >> + >> + if ( dt_start != (paddr_t)dt_start ) >> + { >> + printk("Physical address greater than max width supported\n"); >> + WARN(); >> + } >> + >> + if ( dt_size != (paddr_t)dt_size ) >> + { >> + printk("Physical size greater than max width supported\n"); >> + WARN(); >> + } >> + >> + /* >> + * Xen will truncate the address/size if it is greater than the maximum >> + * supported width and it will give an appropriate warning. >> + */ >> + *start = dt_start; >> + *size = dt_size; >> +} >> + >> +u32 __init device_tree_get_u32( >> + const void *fdt, int node, const char *prop_name, u32 dflt) >> +{ >> + const struct fdt_property *prop; >> + >> + prop = fdt_get_property(fdt, node, prop_name, NULL); >> + if ( !prop || prop->len < sizeof(u32) ) >> + return dflt; >> + >> + return fdt32_to_cpu(*(uint32_t*)prop->data); >> +} > > When I tested this patch by our internal CI (I applied this patch on top > of today's staging: > c2026b88b5 xen/arm/IRQ: uniform irq_set_affinity() with x86 version), > there are some build errors as below: > > aarch64-linux-gnu-gcc -MMD -MP -MF ./.asm-offsets.s.d -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O2 -fomit-frame-pointer -nostdinc -fno-builtin -fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla -pipe -D__XEN__ -include /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/config.h -mcpu=generic -mgeneral-regs-only -mno-outline-atomics -I./include -I./arch/arm/include -I/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include -I/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include -fno-pie -fno-stack-protector -fno-exceptions -fno-asynchronous-unwind-tables -Wnested-externs -S -g0 -o asm-offsets.s.new -MQ asm-offsets.s /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c > In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:13: > /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setup.h:162:6: error: redundant redeclaration of 'device_tree_get_reg' [-Werror=redundant-decls] > 162 | void device_tree_get_reg(const __be32 **cell, uint32_t address_cells, > | ^~~~~~~~~~~~~~~~~~~ > In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/device_tree.h:17, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/smp.h:6, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/smp.h:4, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/rwlock.h:6, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/sched.h:7, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:9: > /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:64:13: note: previous declaration of 'device_tree_get_reg' with type 'void(const __be32 **, u32, u32, u64 *, u64 *)' {aka 'void(const unsigned int **, unsigned int, unsigned int, long unsigned int *, long unsigned int *)'} > 64 | void __init device_tree_get_reg( > | ^~~~~~~~~~~~~~~~~~~ > In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:13: > /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/setup.h:165:5: error: redundant redeclaration of 'device_tree_get_u32' [-Werror=redundant-decls] > 165 | u32 device_tree_get_u32(const void *fdt, int node, > | ^~~~~~~~~~~~~~~~~~~ > In file included from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/device_tree.h:17, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/include/asm/smp.h:6, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/smp.h:4, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/rwlock.h:6, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/sched.h:7, > from /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/arch/arm/arm64/asm-offsets.c:9: > /jenkins/workspace/ais-xenbits-xen/layers/xen/xen/include/xen/fdt.h:68:12: note: previous declaration of 'device_tree_get_u32' with type 'u32(const void *, int, const char *, u32)' {aka 'unsigned int(const void *, int, const char *, unsigned int)'} > 68 | u32 __init device_tree_get_u32( > | ^~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[2]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/./build.mk:45: asm-offsets.s] Error 1 > make[1]: *** [/jenkins/workspace/ais-xenbits-xen/layers/xen/xen/Makefile:597: xen] Error 2 > make[1]: Leaving directory '/jenkins/workspace/ais-xenbits-xen/build/xen-fvp-base' > make: *** [Makefile:183: __sub-make] Error 2 > make: Leaving directory '/jenkins/workspace/ais-xenbits-xen/layers/xen/xen' > > The staging itself passed the CI check. Did I miss some context to make > this patch works? Could you please provide some hints? Thanks in advance! Nope you are correct, I now need to go back and look if I sent patches out of the wrong branch or if I really did miss cleaning up the original declarations in the Arm tree. I fairly confident I made sure gitlab-ci passed before I cut the patches for sending, but since I had three different series in flight, I may have gotten jumbled. Apologies for the unnecessary churn here. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Wed Aug 02 20:22:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 20:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575169.900990 (Exim 4.92) (envelope-from ) id 1qRIM6-000290-8z; Wed, 02 Aug 2023 20:22:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575169.900990; Wed, 02 Aug 2023 20:22:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIM6-00028t-68; Wed, 02 Aug 2023 20:22:02 +0000 Received: by outflank-mailman (input) for mailman id 575169; Wed, 02 Aug 2023 20:22:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRIM4-00028n-Lg for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 20:22:00 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a42c37f-3172-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 22:21:58 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691007707481648.6787527259322; Wed, 2 Aug 2023 13:21:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a42c37f-3172-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691007709; cv=none; d=zohomail.com; s=zohoarc; b=Zz0MjaajDsFBonzv5hWRfcG9dn1TVzO9pufGPhBA74mSIgGTw05Sb7Rp8nD71psO3wHZ+RnBlvkwnDD3yR66XNO6sfGbSBIWgPphDy+A+AWOfgoDTlElrxta+CI0wToaFi8b3cUYZaeAt+gh6VuZmuRPnfconff4hhaGE17Zw3c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691007709; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Po1VrRofBB295pCEpyxAkDJUrJEKqzaejllOsbYbV7c=; b=LmQWkSNdj7efhEpCmyRHzc4fNfu72rEBiRF0uw65VhpT4F0X6AMrXGYvfdheZ7deaHFW44z5xBlXsaj+HLBHRXFHE2uDVaX4jhPjce1JA6yYlLIYL7edIU7WjV9cuKLtqVfwMuqKY/2rjt1rpzFM9pWnzZV/V91XaJzNNcAMFPU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691007709; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Po1VrRofBB295pCEpyxAkDJUrJEKqzaejllOsbYbV7c=; b=UVHOcOLXVo2d6UQW28XFDE8dMLmvk45dYFhGBEPozIHnXkXur4D6ZSNkeXuSuCfB GrhGHgYcC71fNESgHWMv/faCio7u4mb2IbQFyOR+v4KRBWflm8GCaaTPORGr5Rgq0Jm bfz2FNijYNszDjK+RJr8AdDSMGiBuJsPDhgve9QM= Message-ID: Date: Wed, 2 Aug 2023 16:21:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20230801161409.25905-1-dpsmith@apertussolutions.com> <20230801161409.25905-3-dpsmith@apertussolutions.com> <6ce3a936-e35e-caf6-b197-66441292bb9b@suse.com> From: "Daniel P. Smith" In-Reply-To: <6ce3a936-e35e-caf6-b197-66441292bb9b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 03:27, Jan Beulich wrote: > On 01.08.2023 18:14, Daniel P. Smith wrote: >> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is >> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is >> introduced for when the ability of parsing DTB files is needed by a capability >> such as hyperlaunch. >> >> Signed-off-by: Daniel P. Smith >> --- >> MAINTAINERS | 2 + >> xen/arch/arm/bootfdt.c | 141 +------------------------------ >> xen/common/Kconfig | 4 + >> xen/common/Makefile | 3 +- >> xen/common/fdt.c | 153 ++++++++++++++++++++++++++++++++++ >> xen/include/xen/device_tree.h | 50 +---------- >> xen/include/xen/fdt.h | 79 ++++++++++++++++++ >> 7 files changed, 242 insertions(+), 190 deletions(-) >> create mode 100644 xen/common/fdt.c >> create mode 100644 xen/include/xen/fdt.h > > The filename here ... > >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -303,7 +303,9 @@ F: xen/common/libfdt/ >> F: xen/common/device_tree.c >> F: xen/include/xen/libfdt/ >> F: xen/include/xen/device_tree.h >> +F: include/xen/fdt.h >> F: xen/drivers/passthrough/device_tree.c >> +F: common/fdt.c > > ... don't match the additions here. Also please insert in alphabetically > sorted order, ignoring the previously misplaced final entry (entries), > unless you want to take the opportunity and get things properly sorted > again in this section. Ack, will fix along with ensuring they are properly sorted. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:09:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575241.901043 (Exim 4.92) (envelope-from ) id 1qRJ67-0000G8-DH; Wed, 02 Aug 2023 21:09:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575241.901043; Wed, 02 Aug 2023 21:09:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJ67-0000G1-9q; Wed, 02 Aug 2023 21:09:35 +0000 Received: by outflank-mailman (input) for mailman id 575241; Wed, 02 Aug 2023 21:09:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJ65-0000Fv-LM for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:09:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJ61-0005Oi-Bm; Wed, 02 Aug 2023 21:09:29 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRJ61-0007NH-5y; Wed, 02 Aug 2023 21:09:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NakkT8skXSoyT0IxvsaSFsYRCvpGqz0PGAqwjJn4Rec=; b=Pc9DO3TXie9PzBRUoQiOyt1juF oJ3jKGrNKU5DgC0qbncPhBcHRqh7JCIB+pYAQdSghGmNtzC/8X/NjTtDJ4EoLOTmHrpIOgpjoChYl UFs3syDmvXmhspTL52RxI6J+RiO33PaCBTkJX3rFHZfCatakY/gWHPbJ18rF1l5UZMQE=; Message-ID: <78c71235-a4f8-ecce-cd58-56d3cc44e88f@xen.org> Date: Wed, 2 Aug 2023 22:09:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive To: Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel , Khem Raj , xen-devel@lists.xenproject.org References: <20230801174930.2995947-1-raj.khem@gmail.com> <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 02/08/2023 09:01, Jan Beulich wrote: > On 02.08.2023 09:54, Julien Grall wrote: >> On 02/08/2023 08:22, Jan Beulich wrote: >>> On 01.08.2023 23:02, Julien Grall wrote: >>>> Title: This patch is not arm32 specific anymore. So I would replace >>>> 'arm32' with 'arm'. This can be done on commit. >>>> >>>> On 01/08/2023 18:49, Khem Raj wrote: >>>>> Assembler from binutils 2.41 rejects [1] this syntax >>>>> >>>>> .section "name"[, flags...] >>>>> >>>>> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] >>>>> >>>>> It is almost like a regression compared to 2.40 or older release, >>>> >>>> The next word after ',' start with an uppercase. Did you intend to use >>>> '.' rather than ','? >>>> >>>> That said, the documentation has the following: >>>> >>>> For SPARC ELF targets, the assembler supports another type of .section >>>> directive for compatibility with the Solaris assembler:" >>> >>> But note that "SPARC" was added there only by the commit introducing the >>> perceived regression. >> >> Yes, I noticed it while replying yesterday. I still would not describe >> it as a regression mainly because I am not convinced binutils will >> revert the change and it feels like a good move. > > I agree as to it being unlikely that the change is going to be (partly) > reverted, unless someone strongly advocated for it. It also wouldn't be > of much use to us, unless a 2.41.1 was cut very soon. > >> Also, regarding your point about older tree on the bug report. I don't >> think we guarantee that stable works all new toolchain without any change. > > We don't guarantee that, no, but I think it is in our own interest to > keep things building with the newest tool chains. When build-testing > stable tree commits before pushing, I don't want to always have to > remember to force the build to use an older tool chain, when normally > my build rune would default to a pretty up-to-date one. This is where gitlab would definitely help because we can keep containers around to build older Xen versions. > This is also > why for this specific class of changes I typically prefer to see them > also go onto the security-only stable trees. I am ok if this is backported to older tree. This is trivial enough. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:16:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575245.901053 (Exim 4.92) (envelope-from ) id 1qRJCe-0001jz-2V; Wed, 02 Aug 2023 21:16:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575245.901053; Wed, 02 Aug 2023 21:16:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJCd-0001js-W2; Wed, 02 Aug 2023 21:16:19 +0000 Received: by outflank-mailman (input) for mailman id 575245; Wed, 02 Aug 2023 21:16:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJCc-0001jm-Q3 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:16:18 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfd17f12-3179-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:16:15 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LFrXm008271 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:15:59 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LFrg0008270; Wed, 2 Aug 2023 14:15:53 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfd17f12-3179-11ee-8613-37d641c3527e Message-Id: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Wed, 2 Aug 2023 08:33:47 -0700 Subject: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing X-Spam-Status: No, score=1.5 required=10.0 tests=DATE_IN_PAST_03_06, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Is there a freeze on that I'm unaware of? Is there so much traffic from other developers that smaller output ones are being missed? I'm wondering about the initial revision of this series not getting any feedback: https://lists.xenproject.org/archives/html/xen-devel/2023-07/msg01264.html Due to the lack of news on the first thread, I've done some looking to assess the feasibility. The xl.cfg parser looks a bit jumbled. Too many things are visible to too many places. In general some pieces have really needed some TLC for a long time. Note, some portions of this are semi-WIP. The first 5 patches are simply overdue maintenance. Not particularly urgent, but should probably be done. Patch #06 is rather more urgent maintenance. While it might not explode soon, that is a landmine. Patch #07 is the first big issue. The roles of the various headers had never been sorted out. The underlying issue was more the contents of "libxlu_cfg_i.h" needed to be merged into "libxlu_cfg_y.h". Bison 2.3 may not have had the ability to embedded things into its header in 2010, but the functionality appears to have been present in Bison 3.3. There is an issue of what level of indentation should be used in libxlu_cfg_y.y? Normally the sections being added wouldn't be indented, but normally they would be directly in headers. I'm unsure of which direction to go here. Patch #08 seemed best to leave after #07 due to overlap and difficulty with reordering. I'm a bit worried about the interfacing with flex. Then comes the issue of moving things out of libxlu_internal.h which should never have been there. The XLU_Config* values should have been placed in libxlu_cfg_i.h instead. Since I'm doing a thorough job, they're instead moving to libxlu_cfg.c. I'm unsure splitting libxlu_cfg.c is worthwhile. The resultant reusable libxlu_cfg.c is rather small. Yet avoiding the need to reimplement the small portion is handy. Is the decision to keep in-tree copies of current Flex/Bison output still valid? I would be awful tempted to remove them from main/master, even if copies are maintained on release branches. Elliott Mitchell (22): tools/utils: cleanup formatting of libxlutil.h tools/utils: rename "n" arguments to "key" tools/utils: remove old declaration of xlu__cfg_yyparse() tools/utils: enable all Bison warnings tools/utils: update Bison parser directives tools/utils: remove libxlu_cfg_i.h from libxlu_disk.c tools/utils: merge contents of libxlu_cfg_i.h to libxlu_cfg_y.y tools/utils: Bison: switch from name-prefix to api.prefix tools/utils: move CfgParseContext to top of libxlu_cfg_y.y tools/utils: move XLU_ConfigSetting to libxl_cfg.c tools/utils: move XLU_ConfigValue to libxl_cfg.c tools/utils: remove YYLTYPE definition from libxlu_internal.h tools/utils: move XLU_ConfigList to libxl_cfg.c tools/utils: introduce xlu_cfg_printf() function tools/utils: move XLU_Config to libxlu_cfg.c tools/utils: move XLU_Operation to libxlu_cfg_y.h tools/utils: move setting free loop to xlu__cfg_set_free() tools/utils: spread xlu_cfg_printf() over libxlu_cfg.c tools/utils: add pointer to in-progress settings to CfgParseContext tools/utils: add wrapper for readfile()/readdata() functions tools/utils: add settings get function tools/utils: break flex/bison parser away from main config file tools/include/libxlutil.h | 31 +- tools/libs/util/Makefile | 3 +- tools/libs/util/libxlu_cfg.c | 679 ++---------------- .../util/{libxlu_cfg.c => libxlu_cfg_i.c} | 196 +++-- tools/libs/util/libxlu_cfg_i.h | 59 -- tools/libs/util/libxlu_cfg_l.l | 2 +- tools/libs/util/libxlu_cfg_y.y | 58 +- tools/libs/util/libxlu_disk.c | 15 +- tools/libs/util/libxlu_internal.h | 59 +- tools/libs/util/libxlu_pci.c | 11 +- tools/libs/util/libxlu_vif.c | 4 +- 11 files changed, 223 insertions(+), 894 deletions(-) copy tools/libs/util/{libxlu_cfg.c => libxlu_cfg_i.c} (78%) delete mode 100644 tools/libs/util/libxlu_cfg_i.h -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:17:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:17:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575263.901063 (Exim 4.92) (envelope-from ) id 1qRJDL-0002KV-HN; Wed, 02 Aug 2023 21:17:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575263.901063; Wed, 02 Aug 2023 21:17:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJDL-0002KO-El; Wed, 02 Aug 2023 21:17:03 +0000 Received: by outflank-mailman (input) for mailman id 575263; Wed, 02 Aug 2023 21:17:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJDK-0001jm-97 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:17:02 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eab11be8-3179-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:17:00 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LGkRh008303 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:16:51 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LGkHC008302; Wed, 2 Aug 2023 14:16:46 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eab11be8-3179-11ee-8613-37d641c3527e Message-Id: <81a887863224ef22b8d582129fc3cbda596c7880.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Mon, 10 Jul 2023 15:55:30 -0700 Subject: [PATCH 01/22] tools/utils: cleanup formatting of libxlutil.h X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Some arguments included a name, but not all did. Now use "cfg" for all uses of XLU_Config * and "list" for uses of XLU_ConfigList *. Also fix some spaces missing from xlu_cfg_get_defbool()'s prototype. Rename the "b" argument of xlu_cfg_get_defbool() to "value_r". Similar to other functions this is where the returned value is stored. Signed-off-by: Elliott Mitchell --- tools/include/libxlutil.h | 22 +++++++++++----------- tools/libs/util/libxlu_cfg.c | 6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/include/libxlutil.h b/tools/include/libxlutil.h index 4dd3c5e92b..fcbe41b15a 100644 --- a/tools/include/libxlutil.h +++ b/tools/include/libxlutil.h @@ -40,12 +40,12 @@ XLU_Config *xlu_cfg_init(FILE *report, const char *report_filename); /* report_filename is copied; report is saved and must remain valid * until the Config is destroyed. */ -int xlu_cfg_readfile(XLU_Config*, const char *real_filename); -int xlu_cfg_readdata(XLU_Config*, const char *data, int length); +int xlu_cfg_readfile(XLU_Config *cfg, const char *real_filename); +int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length); /* If these fail, then it is undefined behaviour to call xlu_cfg_get_... * functions. You have to just xlu_cfg_destroy. */ -void xlu_cfg_destroy(XLU_Config*); +void xlu_cfg_destroy(XLU_Config *cfg); /* All of the following print warnings to "report" if there is a problem. @@ -56,26 +56,26 @@ void xlu_cfg_destroy(XLU_Config*); * ERANGE value out of range (from strtol) */ -int xlu_cfg_get_string(const XLU_Config*, const char *n, const char **value_r, - int dont_warn); +int xlu_cfg_get_string(const XLU_Config *cfg, const char *n, + const char **value_r, int dont_warn); /* free/strdup version */ int xlu_cfg_replace_string(const XLU_Config *cfg, const char *n, char **value_r, int dont_warn); -int xlu_cfg_get_long(const XLU_Config*, const char *n, long *value_r, +int xlu_cfg_get_long(const XLU_Config *cfg, const char *n, long *value_r, int dont_warn); -int xlu_cfg_get_bounded_long(const XLU_Config*, const char *n, long min, +int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *n, long min, long max, long *value_r, int dont_warn); -int xlu_cfg_get_defbool(const XLU_Config*, const char *n, libxl_defbool *b, - int dont_warn); +int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *n, + libxl_defbool *value_r, int dont_warn); -int xlu_cfg_get_list(const XLU_Config*, const char *n, +int xlu_cfg_get_list(const XLU_Config *cfg, const char *n, XLU_ConfigList **list_r /* may be 0 */, int *entries_r /* may be 0 */, int dont_warn); /* there is no need to free *list_r; lifetime is that of the XLU_Config */ int xlu_cfg_get_list_as_string_list(const XLU_Config *cfg, const char *n, libxl_string_list *sl, int dont_warn); -const char *xlu_cfg_get_listitem(const XLU_ConfigList*, int entry); +const char *xlu_cfg_get_listitem(const XLU_ConfigList *list, int entry); /* xlu_cfg_get_listitem cannot fail, except that if entry is * out of range it returns 0 (not setting errno) */ diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 874f5abfb9..87ac8c4b41 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -328,15 +328,15 @@ int xlu_cfg_get_long(const XLU_Config *cfg, const char *n, dont_warn); } -int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *n, libxl_defbool *b, - int dont_warn) +int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *n, + libxl_defbool *value_r, int dont_warn) { int ret; long l; ret = xlu_cfg_get_long(cfg, n, &l, dont_warn); if (ret) return ret; - libxl_defbool_set(b, !!l); + libxl_defbool_set(value_r, !!l); return 0; } -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:18:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:18:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575281.901073 (Exim 4.92) (envelope-from ) id 1qRJEv-0002w9-Sc; Wed, 02 Aug 2023 21:18:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575281.901073; Wed, 02 Aug 2023 21:18:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJEv-0002w2-PK; Wed, 02 Aug 2023 21:18:41 +0000 Received: by outflank-mailman (input) for mailman id 575281; Wed, 02 Aug 2023 21:18:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJEu-0002vw-Gn for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:18:40 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25e12516-317a-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:18:39 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LIUvV008334 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:18:36 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LIUPs008333; Wed, 2 Aug 2023 14:18:30 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25e12516-317a-11ee-b263-6b7b168915f2 Message-Id: <2d87776c7cf9637f10cade3de5c9dcd3d1c96931.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Wed, 26 Jul 2023 21:09:21 -0700 Subject: [PATCH 03/22] tools/utils: remove old declaration of xlu__cfg_yyparse() X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com This was added at b104c3762dc. Appears this was fixed in the intervening decade. Otherwise this could have been an issue from using advanced features of Bison. Now this appears unnecessary. Signed-off-by: Elliott Mitchell --- tools/libs/util/libxlu_cfg_i.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/libs/util/libxlu_cfg_i.h b/tools/libs/util/libxlu_cfg_i.h index 4217f5b28d..3717b9460c 100644 --- a/tools/libs/util/libxlu_cfg_i.h +++ b/tools/libs/util/libxlu_cfg_i.h @@ -42,12 +42,6 @@ void xlu__cfgl_lexicalerror(CfgParseContext*, char const *msg); void xlu__cfgl_likely_python(CfgParseContext *ctx); - - -/* Why oh why does bison not declare this in its autogenerated .h ? */ -int xlu__cfg_yyparse(CfgParseContext *ctx); - - #endif /*LIBXLU_CFG_I_H*/ /* -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:19:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:19:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575297.901082 (Exim 4.92) (envelope-from ) id 1qRJFm-0003UB-4Y; Wed, 02 Aug 2023 21:19:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575297.901082; Wed, 02 Aug 2023 21:19:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJFm-0003U4-1l; Wed, 02 Aug 2023 21:19:34 +0000 Received: by outflank-mailman (input) for mailman id 575297; Wed, 02 Aug 2023 21:19:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJFk-0003Tu-Br for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:19:32 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44d95d70-317a-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:19:31 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LJMDH008355 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:19:27 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LJMYx008354; Wed, 2 Aug 2023 14:19:22 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44d95d70-317a-11ee-b263-6b7b168915f2 Message-Id: <3aa2df31a341c97d0cc21b1837233446ff1d48c2.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Thu, 27 Jul 2023 14:43:15 -0700 Subject: [PATCH 04/22] tools/utils: enable all Bison warnings X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Warnings from Bison seem less likely to be urgent, but on general principle enable everything. Signed-off-by: Elliott Mitchell --- tools/libs/util/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile index c3b21875dc..d2c90ced69 100644 --- a/tools/libs/util/Makefile +++ b/tools/libs/util/Makefile @@ -50,7 +50,7 @@ $(OBJS-y) $(PIC_OBJS): libxlu_cfg_l.c libxlu_cfg_y.c libxlu_disk_l.c %.c %.h:: %.y @rm -f $*.[ch] - $(BISON) --output=$*.c $< + $(BISON) -Wall --output=$*.c $< %.c %.h:: %.l @rm -f $*.[ch] -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:21:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575318.901093 (Exim 4.92) (envelope-from ) id 1qRJHS-0004vc-FR; Wed, 02 Aug 2023 21:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575318.901093; Wed, 02 Aug 2023 21:21:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJHS-0004vV-C7; Wed, 02 Aug 2023 21:21:18 +0000 Received: by outflank-mailman (input) for mailman id 575318; Wed, 02 Aug 2023 21:21:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJHR-0004vP-NF for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:21:17 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 83949012-317a-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:21:16 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LL7DC008373 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:21:12 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LL6lp008372; Wed, 2 Aug 2023 14:21:06 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 83949012-317a-11ee-b263-6b7b168915f2 Message-Id: <07d4758b3ce8b3680c7b0107329033925832a15d.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 18 Jul 2023 22:02:48 -0700 Subject: [PATCH 06/22] tools/utils: remove libxlu_cfg_i.h from libxlu_disk.c X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com The upper layer disk string parser doesn't need the internals of the lower layer file parser. Split the layers apart. This looks to have been a copy&paste issue. Fixes: 5c206536ad ("libxl: disks: new xlu_disk_parse function") Signed-off-by: Elliott Mitchell --- tools/libs/util/libxlu_disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/libs/util/libxlu_disk.c b/tools/libs/util/libxlu_disk.c index 1de16a6a06..e94f4d06cd 100644 --- a/tools/libs/util/libxlu_disk.c +++ b/tools/libs/util/libxlu_disk.c @@ -1,7 +1,6 @@ #include "libxlu_internal.h" #include "libxlu_disk_l.h" #include "libxlu_disk_i.h" -#include "libxlu_cfg_i.h" void xlu__disk_err(DiskParseContext *dpc, const char *erroneous, const char *message) { -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:22:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575335.901103 (Exim 4.92) (envelope-from ) id 1qRJIJ-0005Ul-Ow; Wed, 02 Aug 2023 21:22:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575335.901103; Wed, 02 Aug 2023 21:22:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJIJ-0005Ue-M5; Wed, 02 Aug 2023 21:22:11 +0000 Received: by outflank-mailman (input) for mailman id 575335; Wed, 02 Aug 2023 21:22:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJII-0005Ie-Kh for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:22:10 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a2aa3667-317a-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:22:08 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LLxep008383 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:22:05 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LLx0F008382; Wed, 2 Aug 2023 14:21:59 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2aa3667-317a-11ee-8613-37d641c3527e Message-Id: <39785555d883fa43b03423e68964bd21f92e791a.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Fri, 28 Jul 2023 12:10:14 -0700 Subject: [PATCH 07/22] tools/utils: merge contents of libxlu_cfg_i.h to libxlu_cfg_y.y X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Bison has added the ability to emit declarations in its header. As such everything can instead be dumped in Bison's header instead of having a private one. This resolves the mixed up situation with the libxlu headers. Problem is libxlu_cfg_i.h was trying to function as a wrapper for libxlu_cfg_y.h. Issue is libxlu_cfg.c's #include order didn't match and thus everything was fragile. Fixes: b104c3762d ('Replace config file parser for "xl"') Signed-off-by: Elliott Mitchell --- The bug @b104c3762d was the incorrect ordering of #includes in libxlu_cfg.c. It should instead have been: #include "libxlu_cfg_i.h" #include "libxlu_cfg_l.h" Had this bug not been present, later commits might have looked deeper and chosen correct solutions. Instead this resulted in all the ripples which this series fixes. I'm unsure whether Bison had implemented the %code feature by this point in time. The one and a half remaining issues are whether to convert the %{ %} section to %code and move it after the %union. The %union construct ends up in libxlu_cfg_y.h, whereas the %{ %}/%code construct ends up in libxlu_cfg_y.c. --- tools/libs/util/libxlu_cfg.c | 1 - tools/libs/util/libxlu_cfg_i.h | 53 ---------------------------------- tools/libs/util/libxlu_cfg_l.l | 2 +- tools/libs/util/libxlu_cfg_y.y | 29 ++++++++++++++++++- 4 files changed, 29 insertions(+), 56 deletions(-) delete mode 100644 tools/libs/util/libxlu_cfg_i.h diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 87ac8c4b41..7e9eec550d 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -22,7 +22,6 @@ #include "libxlu_internal.h" #include "libxlu_cfg_y.h" #include "libxlu_cfg_l.h" -#include "libxlu_cfg_i.h" XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { XLU_Config *cfg; diff --git a/tools/libs/util/libxlu_cfg_i.h b/tools/libs/util/libxlu_cfg_i.h deleted file mode 100644 index 3717b9460c..0000000000 --- a/tools/libs/util/libxlu_cfg_i.h +++ /dev/null @@ -1,53 +0,0 @@ -/* - * libxlu_cfg_i.h - xl configuration file parsing: parser-internal declarations - * - * Copyright (C) 2010 Citrix Ltd. - * Author Ian Jackson - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as published - * by the Free Software Foundation; version 2.1 only. with the special - * exception on linking described in file LICENSE. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. - */ - -#ifndef LIBXLU_CFG_I_H -#define LIBXLU_CFG_I_H - -#include "libxlu_internal.h" -#include "libxlu_cfg_y.h" - -void xlu__cfg_set_free(XLU_ConfigSetting *set); -void xlu__cfg_set_store(CfgParseContext*, char *name, - enum XLU_Operation op, - XLU_ConfigValue *val, int lineno); -XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, - char *atom, YYLTYPE *loc); -XLU_ConfigValue *xlu__cfg_list_mk(CfgParseContext *ctx, - XLU_ConfigValue *val, - YYLTYPE *loc); -void xlu__cfg_list_append(CfgParseContext *ctx, - XLU_ConfigValue *list, - XLU_ConfigValue *val); -void xlu__cfg_value_free(XLU_ConfigValue *value); -char *xlu__cfgl_strdup(CfgParseContext*, const char *src); -char *xlu__cfgl_dequote(CfgParseContext*, const char *src); - -void xlu__cfg_yyerror(YYLTYPE *locp, CfgParseContext*, char const *msg); -void xlu__cfgl_lexicalerror(CfgParseContext*, char const *msg); - -void xlu__cfgl_likely_python(CfgParseContext *ctx); - -#endif /*LIBXLU_CFG_I_H*/ - -/* - * Local variables: - * mode: C - * c-basic-offset: 4 - * indent-tabs-mode: nil - * End: - */ diff --git a/tools/libs/util/libxlu_cfg_l.l b/tools/libs/util/libxlu_cfg_l.l index 390d6e2c2b..ba023fd679 100644 --- a/tools/libs/util/libxlu_cfg_l.l +++ b/tools/libs/util/libxlu_cfg_l.l @@ -17,7 +17,7 @@ */ %{ -#include "libxlu_cfg_i.h" +#include "libxlu_cfg_y.h" #define ctx ((CfgParseContext*)yyextra) #define YY_NO_INPUT diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index e53d8ed337..e796066941 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -16,9 +16,36 @@ * GNU Lesser General Public License for more details. */ +%code requires { +#include "libxlu_internal.h" +} + +%code provides { +void xlu__cfg_set_free(XLU_ConfigSetting *set); +void xlu__cfg_set_store(CfgParseContext*, char *name, + enum XLU_Operation op, + XLU_ConfigValue *val, int lineno); +XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, + char *atom, YYLTYPE *loc); +XLU_ConfigValue *xlu__cfg_list_mk(CfgParseContext *ctx, + XLU_ConfigValue *val, + YYLTYPE *loc); +void xlu__cfg_list_append(CfgParseContext *ctx, + XLU_ConfigValue *list, + XLU_ConfigValue *val); +void xlu__cfg_value_free(XLU_ConfigValue *value); +char *xlu__cfgl_strdup(CfgParseContext*, const char *src); +char *xlu__cfgl_dequote(CfgParseContext*, const char *src); + +void xlu__cfg_yyerror(YYLTYPE *locp, CfgParseContext*, char const *msg); +void xlu__cfgl_lexicalerror(CfgParseContext*, char const *msg); + +void xlu__cfgl_likely_python(CfgParseContext *ctx); +} + %{ #define ctx_scanner ctx->scanner -#include "libxlu_cfg_i.h" +#include "libxlu_cfg_y.h" #include "libxlu_cfg_l.h" %} -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:23:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:23:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575359.901116 (Exim 4.92) (envelope-from ) id 1qRJK0-000680-5P; Wed, 02 Aug 2023 21:23:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575359.901116; Wed, 02 Aug 2023 21:23:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJK0-00067t-2j; Wed, 02 Aug 2023 21:23:56 +0000 Received: by outflank-mailman (input) for mailman id 575359; Wed, 02 Aug 2023 21:23:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJJz-00067Z-5k for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:23:55 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0e72bc8-317a-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:23:53 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LNhnU008407 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:23:49 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LNhDC008406; Wed, 2 Aug 2023 14:23:43 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0e72bc8-317a-11ee-8613-37d641c3527e Message-Id: <58041bfb2a8ce9a54a337a2293c5094c119f7390.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Wed, 26 Jul 2023 21:56:32 -0700 Subject: [PATCH 09/22] tools/utils: move CfgParseContext to top of libxlu_cfg_y.y X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com The CfgParseContext structure/typedef is used inside the parser. Whereas most #include's of libxlu_internal.h need the common declarations, not the parser internals. Due to this, the structure should be near the top of libxlu_cfg_y.h (libxlu_cfg_i.h @b104c3762d), and not towards the middle of libxlu_internal.h. Fixes: b104c3762d ('Replace config file parser for "xl"') Signed-off-by: Elliott Mitchell --- Ideally at @b104c3762d Bison might already have implemented its %code feature. Less ideal, but workable CfgParseContext should have been placed in libxlu_cfg_i.h, between the two #includes: #include "libxlu_internal.h" typedef struct { } CfgParseContext; #include "libxlu_cfg_y.h" Using Bison's %code feature is rather superior though. This patch is where indentation in Bison.y files becomes crucial. I'm unsure of the call to make, so I've left this as cut&paste which means this will almost certainly change. --- tools/libs/util/libxlu_cfg_y.y | 6 ++++++ tools/libs/util/libxlu_internal.h | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index adbb74ff11..75e7140478 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -18,6 +18,12 @@ %code requires { #include "libxlu_internal.h" + +typedef struct { + XLU_Config *cfg; + int err, lexerrlineno, likely_python; + void *scanner; +} CfgParseContext; } %code provides { diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 01fe073069..246ad0bde7 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -63,12 +63,6 @@ struct XLU_Config { char *config_source; }; -typedef struct { - XLU_Config *cfg; - int err, lexerrlineno, likely_python; - void *scanner; -} CfgParseContext; - #define STRINGIFY(x) #x #define TOSTRING(x) STRINGIFY(x) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:24:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:24:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575374.901126 (Exim 4.92) (envelope-from ) id 1qRJKq-0006l8-IS; Wed, 02 Aug 2023 21:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575374.901126; Wed, 02 Aug 2023 21:24:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJKq-0006l1-Fn; Wed, 02 Aug 2023 21:24:48 +0000 Received: by outflank-mailman (input) for mailman id 575374; Wed, 02 Aug 2023 21:24:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJKo-00067Z-UA for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:24:46 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ffe0de99-317a-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:24:45 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LOZ04008420 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:24:41 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LOZN1008419; Wed, 2 Aug 2023 14:24:35 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffe0de99-317a-11ee-8613-37d641c3527e Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 18 Jul 2023 16:31:34 -0700 Subject: [PATCH 10/22] tools/utils: move XLU_ConfigSetting to libxl_cfg.c X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com XLU_ConfigSetting is only used inside libxl_cfg.c, so no need for it in the internal header. Keep the type definition in libxlu_internal.h as the incomplete definition is needed for xlu__cfg_set_free(). There is no longer any need for XLU_ConfigSetting to be transparent. Fixes: b104c3762d, 1a09c5113a ("libxlu: rework internal representation of setting") Signed-off-by: Elliott Mitchell --- @1a09c5113a deeper probing should have been done and figured out everything needed to move to libxlu_cfg_i.h. Making use of %code would have been better, but moving would have been sufficient. Note: If the decision is made to keep libxlu_cfg.c intact, then the type definition should be in libxlu_cfg_y.y/libxlu_cfg_y.h. --- tools/libs/util/libxlu_cfg.c | 8 ++++++++ tools/libs/util/libxlu_internal.h | 8 +------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 20534343f4..2ad58d4240 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -23,6 +23,14 @@ #include "libxlu_cfg_y.h" #include "libxlu_cfg_l.h" +struct XLU_ConfigSetting { + struct XLU_ConfigSetting *next; + char *name; + XLU_ConfigValue *value; + enum XLU_Operation op; + int lineno; +}; + XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { XLU_Config *cfg; diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 246ad0bde7..bf1827ea73 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -49,13 +49,7 @@ struct XLU_ConfigValue { XLU__CFG_YYLTYPE loc; }; -typedef struct XLU_ConfigSetting { /* transparent */ - struct XLU_ConfigSetting *next; - char *name; - XLU_ConfigValue *value; - enum XLU_Operation op; - int lineno; -} XLU_ConfigSetting; +typedef struct XLU_ConfigSetting XLU_ConfigSetting; struct XLU_Config { XLU_ConfigSetting *settings; -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:27:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575437.901171 (Exim 4.92) (envelope-from ) id 1qRJNe-0008G6-7X; Wed, 02 Aug 2023 21:27:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575437.901171; Wed, 02 Aug 2023 21:27:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJNe-0008Ew-0h; Wed, 02 Aug 2023 21:27:42 +0000 Received: by outflank-mailman (input) for mailman id 575437; Wed, 02 Aug 2023 21:27:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJMU-0004vP-FI for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:26:30 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e3e1e12-317b-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:26:29 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LQKx1008439 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:26:26 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LQKN6008438; Wed, 2 Aug 2023 14:26:20 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e3e1e12-317b-11ee-b263-6b7b168915f2 Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 18 Jul 2023 23:07:20 -0700 Subject: [PATCH 12/22] tools/utils: remove YYLTYPE definition from libxlu_internal.h X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com The definition was needed due to XLU_ConfigValue being before Bison's declaration of YYLTYPE. Since XLU_ConfigValue has moved to libxlu_cfg.c, the duplication is now unnecessary. Fixes: 1a09c5113a, 6ec86e91c8 ("libxlu: record location when parsing values") Signed-off-by: Elliott Mitchell --- Had @1a09c5113a placed the structure definition in libxlu_cfg_i.h, there never would have been a need to override YYLTYPE. --- tools/libs/util/libxlu_internal.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 1a9d25e14e..c68669c3a1 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -31,15 +31,6 @@ struct XLU_ConfigList { XLU_ConfigValue **values; }; -typedef struct XLU__CFG_YYLTYPE -{ - int first_line; - int first_column; - int last_line; - int last_column; -} XLU__CFG_YYLTYPE; -#define XLU__CFG_YYLTYPE_IS_DECLARED - typedef struct XLU_ConfigSetting XLU_ConfigSetting; struct XLU_Config { -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:27:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575436.901167 (Exim 4.92) (envelope-from ) id 1qRJNd-0008DV-Rm; Wed, 02 Aug 2023 21:27:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575436.901167; Wed, 02 Aug 2023 21:27:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJNd-0008DE-MB; Wed, 02 Aug 2023 21:27:41 +0000 Received: by outflank-mailman (input) for mailman id 575436; Wed, 02 Aug 2023 21:27:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJE7-0001jm-EO for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:17:51 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08349857-317a-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:17:49 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LHc3i008327 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:17:43 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LHcDt008326; Wed, 2 Aug 2023 14:17:38 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08349857-317a-11ee-8613-37d641c3527e Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Wed, 12 Jul 2023 23:29:59 -0700 Subject: [PATCH 02/22] tools/utils: rename "n" arguments to "key" X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Hopefully make it clearer to others this is the key associated with the storage value to retrieve. Signed-off-by: Elliott Mitchell --- tools/include/libxlutil.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/include/libxlutil.h b/tools/include/libxlutil.h index fcbe41b15a..0ce66c2096 100644 --- a/tools/include/libxlutil.h +++ b/tools/include/libxlutil.h @@ -56,24 +56,24 @@ void xlu_cfg_destroy(XLU_Config *cfg); * ERANGE value out of range (from strtol) */ -int xlu_cfg_get_string(const XLU_Config *cfg, const char *n, +int xlu_cfg_get_string(const XLU_Config *cfg, const char *key, const char **value_r, int dont_warn); /* free/strdup version */ -int xlu_cfg_replace_string(const XLU_Config *cfg, const char *n, +int xlu_cfg_replace_string(const XLU_Config *cfg, const char *key, char **value_r, int dont_warn); -int xlu_cfg_get_long(const XLU_Config *cfg, const char *n, long *value_r, +int xlu_cfg_get_long(const XLU_Config *cfg, const char *key, long *value_r, int dont_warn); -int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *n, long min, +int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *key, long min, long max, long *value_r, int dont_warn); -int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *n, +int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *key, libxl_defbool *value_r, int dont_warn); -int xlu_cfg_get_list(const XLU_Config *cfg, const char *n, +int xlu_cfg_get_list(const XLU_Config *cfg, const char *key, XLU_ConfigList **list_r /* may be 0 */, int *entries_r /* may be 0 */, int dont_warn); /* there is no need to free *list_r; lifetime is that of the XLU_Config */ -int xlu_cfg_get_list_as_string_list(const XLU_Config *cfg, const char *n, +int xlu_cfg_get_list_as_string_list(const XLU_Config *cfg, const char *key, libxl_string_list *sl, int dont_warn); const char *xlu_cfg_get_listitem(const XLU_ConfigList *list, int entry); /* xlu_cfg_get_listitem cannot fail, except that if entry is -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:27:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575421.901136 (Exim 4.92) (envelope-from ) id 1qRJNb-0007Sv-0f; Wed, 02 Aug 2023 21:27:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575421.901136; Wed, 02 Aug 2023 21:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJNa-0007Sj-TH; Wed, 02 Aug 2023 21:27:38 +0000 Received: by outflank-mailman (input) for mailman id 575421; Wed, 02 Aug 2023 21:27:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJGb-0003L7-Jc for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:20:25 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 64102d71-317a-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:20:23 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LKEVN008367 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:20:19 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LKE6T008366; Wed, 2 Aug 2023 14:20:14 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64102d71-317a-11ee-8613-37d641c3527e Message-Id: <6a645ebcf70c46df5a3ce0d8539d1108d9927d19.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Sat, 29 Jul 2023 16:04:18 -0700 Subject: [PATCH 05/22] tools/utils: update Bison parser directives X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Update per Bison's obsolete warnings. Testing indicates these are simple and safe. Signed-off-by: Elliott Mitchell --- Someone check for acceptable Bison versions? I'm testing with Flex 2.6.4 and Bison 3.7.5. --- tools/libs/util/libxlu_cfg_y.y | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index 020fc63eb3..e53d8ed337 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -28,9 +28,9 @@ } %locations -%pure-parser +%define api.pure %defines -%error-verbose +%define parse.error verbose %name-prefix "xlu__cfg_yy" %parse-param { CfgParseContext *ctx } %lex-param { ctx_scanner } @@ -48,7 +48,7 @@ file: stmts | stmts assignment -stmts: /* empty */ +stmts: %empty | stmts stmt stmt: assignment endstmt @@ -67,13 +67,12 @@ value: atom { $$= xlu__cfg_string_mk(ctx,$1,&@1); } atom: STRING { $$= $1; } | NUMBER { $$= $1; } -valuelist: /* empty */ { $$= xlu__cfg_list_mk(ctx,NULL,&yylloc); } +valuelist: %empty { $$= xlu__cfg_list_mk(ctx,NULL,&yylloc); } | values { $$= $1; } | values ',' nlok { $$= $1; } values: value nlok { $$= xlu__cfg_list_mk(ctx,$1,&@1); } | values ',' nlok value nlok { xlu__cfg_list_append(ctx,$1,$4); $$= $1; } -nlok: - /* nothing */ +nlok: %empty | nlok NEWLINE -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:27:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575426.901147 (Exim 4.92) (envelope-from ) id 1qRJNb-0007YR-KB; Wed, 02 Aug 2023 21:27:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575426.901147; Wed, 02 Aug 2023 21:27:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJNb-0007WQ-Bz; Wed, 02 Aug 2023 21:27:39 +0000 Received: by outflank-mailman (input) for mailman id 575426; Wed, 02 Aug 2023 21:27:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJLe-0004vP-1G for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:25:38 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ef7b072-317b-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:25:37 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LPSkE008432 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:25:33 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LPS4R008431; Wed, 2 Aug 2023 14:25:28 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ef7b072-317b-11ee-b263-6b7b168915f2 Message-Id: <22cd5f8f7d7d7c54a1a02a36bcd32c88632c6dbb.1690990427.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 18 Jul 2023 23:07:20 -0700 Subject: [PATCH 11/22] tools/utils: move XLU_ConfigValue to libxl_cfg.c X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com At no point was the complete type for XLU_ConfigValue used anywhere besides libxlu_cfg.c, overdue for a move. Fixes: 1a09c5113a ("libxlu: rework internal representation of setting") Signed-off-by: Elliott Mitchell --- tools/libs/util/libxlu_cfg.c | 9 +++++++++ tools/libs/util/libxlu_internal.h | 9 --------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 2ad58d4240..d3b5c86ed6 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -31,6 +31,15 @@ struct XLU_ConfigSetting { int lineno; }; +struct XLU_ConfigValue { + enum XLU_ConfigValueType type; + union { + char *string; + XLU_ConfigList list; + } u; + XLU__CFG_YYLTYPE loc; +}; + XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { XLU_Config *cfg; diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index bf1827ea73..1a9d25e14e 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -40,15 +40,6 @@ typedef struct XLU__CFG_YYLTYPE } XLU__CFG_YYLTYPE; #define XLU__CFG_YYLTYPE_IS_DECLARED -struct XLU_ConfigValue { - enum XLU_ConfigValueType type; - union { - char *string; - XLU_ConfigList list; - } u; - XLU__CFG_YYLTYPE loc; -}; - typedef struct XLU_ConfigSetting XLU_ConfigSetting; struct XLU_Config { -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:27:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575423.901141 (Exim 4.92) (envelope-from ) id 1qRJNb-0007V6-A5; Wed, 02 Aug 2023 21:27:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575423.901141; Wed, 02 Aug 2023 21:27:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJNb-0007Tn-3h; Wed, 02 Aug 2023 21:27:39 +0000 Received: by outflank-mailman (input) for mailman id 575423; Wed, 02 Aug 2023 21:27:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJJ7-0004vP-OS for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:23:01 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c1bf85c8-317a-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:23:01 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LMpRt008400 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:22:57 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LMphh008399; Wed, 2 Aug 2023 14:22:51 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1bf85c8-317a-11ee-b263-6b7b168915f2 Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Sat, 29 Jul 2023 17:03:47 -0700 Subject: [PATCH 08/22] tools/utils: Bison: switch from name-prefix to api.prefix X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com bison -Wall declares %name-prefix deprecated. The suggested replacement is "api.prefix". "api.prefix" though effects rather a lot more places than %name-prefix does. As a result, rename YYLTYPE/YYSTYPE to match. As a quick workaround #define YYLTYPE/YYSTYPE to convince flex to interface correctly. Signed-off-by: Elliott Mitchell --- According to the documentation api.prefix was introduced in Bison 2.6, while braces became recommended with Bison 3.0. This seems sufficiently in the past to be worth adopting now. A better workaround for flex is needed. --- tools/libs/util/libxlu_cfg.c | 9 +++++---- tools/libs/util/libxlu_cfg_y.y | 13 +++++++++---- tools/libs/util/libxlu_internal.h | 8 ++++---- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 7e9eec550d..20534343f4 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -388,7 +388,7 @@ const char *xlu_cfg_get_listitem(const XLU_ConfigList *list, int entry) { XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, char *atom, - YYLTYPE *loc) + XLU__CFG_YYLTYPE *loc) { XLU_ConfigValue *value = NULL; @@ -412,7 +412,7 @@ XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, char *atom, XLU_ConfigValue *xlu__cfg_list_mk(CfgParseContext *ctx, XLU_ConfigValue *val, - YYLTYPE *loc) + XLU__CFG_YYLTYPE *loc) { XLU_ConfigValue *value = NULL; XLU_ConfigValue **values = NULL; @@ -667,13 +667,14 @@ char *xlu__cfgl_dequote(CfgParseContext *ctx, const char *src) { } void xlu__cfgl_lexicalerror(CfgParseContext *ctx, char const *msg) { - YYLTYPE loc; + XLU__CFG_YYLTYPE loc; loc.first_line= xlu__cfg_yyget_lineno(ctx->scanner); xlu__cfg_yyerror(&loc, ctx, msg); ctx->lexerrlineno= loc.first_line; } -void xlu__cfg_yyerror(YYLTYPE *loc, CfgParseContext *ctx, char const *msg) { +void xlu__cfg_yyerror(XLU__CFG_YYLTYPE *loc, CfgParseContext *ctx, + char const *msg) { const char *text, *newline; int len, lineno; diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index e796066941..adbb74ff11 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -26,10 +26,10 @@ void xlu__cfg_set_store(CfgParseContext*, char *name, enum XLU_Operation op, XLU_ConfigValue *val, int lineno); XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, - char *atom, YYLTYPE *loc); + char *atom, XLU__CFG_YYLTYPE *loc); XLU_ConfigValue *xlu__cfg_list_mk(CfgParseContext *ctx, XLU_ConfigValue *val, - YYLTYPE *loc); + XLU__CFG_YYLTYPE *loc); void xlu__cfg_list_append(CfgParseContext *ctx, XLU_ConfigValue *list, XLU_ConfigValue *val); @@ -37,10 +37,15 @@ void xlu__cfg_value_free(XLU_ConfigValue *value); char *xlu__cfgl_strdup(CfgParseContext*, const char *src); char *xlu__cfgl_dequote(CfgParseContext*, const char *src); -void xlu__cfg_yyerror(YYLTYPE *locp, CfgParseContext*, char const *msg); +void xlu__cfg_yyerror(XLU__CFG_YYLTYPE *locp, CfgParseContext*, + char const *msg); void xlu__cfgl_lexicalerror(CfgParseContext*, char const *msg); void xlu__cfgl_likely_python(CfgParseContext *ctx); + +/* issue of name-prefix versus api.prefix and Flex Bison-bridge */ +#define YYLTYPE XLU__CFG_YYLTYPE +#define YYSTYPE XLU__CFG_YYSTYPE } %{ @@ -58,7 +63,7 @@ void xlu__cfgl_likely_python(CfgParseContext *ctx); %define api.pure %defines %define parse.error verbose -%name-prefix "xlu__cfg_yy" +%define api.prefix {xlu__cfg_yy} %parse-param { CfgParseContext *ctx } %lex-param { ctx_scanner } diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 1f7559ecd9..01fe073069 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -31,14 +31,14 @@ struct XLU_ConfigList { XLU_ConfigValue **values; }; -typedef struct YYLTYPE +typedef struct XLU__CFG_YYLTYPE { int first_line; int first_column; int last_line; int last_column; -} YYLTYPE; -#define YYLTYPE_IS_DECLARED +} XLU__CFG_YYLTYPE; +#define XLU__CFG_YYLTYPE_IS_DECLARED struct XLU_ConfigValue { enum XLU_ConfigValueType type; @@ -46,7 +46,7 @@ struct XLU_ConfigValue { char *string; XLU_ConfigList list; } u; - YYLTYPE loc; + XLU__CFG_YYLTYPE loc; }; typedef struct XLU_ConfigSetting { /* transparent */ -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:29:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575503.901186 (Exim 4.92) (envelope-from ) id 1qRJP2-0001pQ-Iz; Wed, 02 Aug 2023 21:29:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575503.901186; Wed, 02 Aug 2023 21:29:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJP2-0001pH-F2; Wed, 02 Aug 2023 21:29:08 +0000 Received: by outflank-mailman (input) for mailman id 575503; Wed, 02 Aug 2023 21:29:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJP2-0001nP-0O for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:29:08 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b7a40ad-317b-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:29:06 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LSusM008502 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:29:02 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LSusJ008501; Wed, 2 Aug 2023 14:28:56 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b7a40ad-317b-11ee-8613-37d641c3527e Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Thu, 13 Jul 2023 19:01:19 -0700 Subject: [PATCH 15/22] tools/utils: move XLU_Config to libxlu_cfg.c X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Only the lowest layer of configuration handling looks inside XLU_Config. As such the structure can move to this header instead of the shared header. Mark ->config_source as constant. Most places it truly is constant, only the free() violates the constant. Signed-off-by: Elliott Mitchell --- This could also move to libxlu_cfg_y.h and make preserving messages easier while allowing libxlu_cfg.c to split. --- tools/libs/util/libxlu_cfg.c | 8 +++++++- tools/libs/util/libxlu_internal.h | 6 ------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index e37f84829f..69b95a4ed0 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -47,6 +47,12 @@ struct XLU_ConfigValue { XLU__CFG_YYLTYPE loc; }; +struct XLU_Config { + XLU_ConfigSetting *settings; + FILE *report; + const char *config_source; +}; + XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { XLU_Config *cfg; @@ -188,7 +194,7 @@ void xlu_cfg_destroy(XLU_Config *cfg) { set_next= set->next; xlu__cfg_set_free(set); } - free(cfg->config_source); + free((void *)cfg->config_source); free(cfg); } diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 214ebe5f48..93caf24a6e 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -27,12 +27,6 @@ typedef struct XLU_ConfigSetting XLU_ConfigSetting; -struct XLU_Config { - XLU_ConfigSetting *settings; - FILE *report; - char *config_source; -}; - #define STRINGIFY(x) #x #define TOSTRING(x) STRINGIFY(x) -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:30:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:30:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575537.901195 (Exim 4.92) (envelope-from ) id 1qRJQk-0003Oy-1G; Wed, 02 Aug 2023 21:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575537.901195; Wed, 02 Aug 2023 21:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJQj-0003Or-Uk; Wed, 02 Aug 2023 21:30:53 +0000 Received: by outflank-mailman (input) for mailman id 575537; Wed, 02 Aug 2023 21:30:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJQi-0003Og-9l for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:30:52 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d971e1d6-317b-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:30:50 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LUerU008520 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:30:46 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LUeMk008519; Wed, 2 Aug 2023 14:30:40 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d971e1d6-317b-11ee-8613-37d641c3527e Message-Id: <829def3bc27e138286677b95d549684b82f864f4.1690990428.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 25 Jul 2023 11:06:06 -0700 Subject: [PATCH 17/22] tools/utils: move setting free loop to xlu__cfg_set_free() X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com This better breaks layers apart. xlu_cfg_destroy() now only knows about the XLU_Config structure, while xlu__cfg_set_free() knows about XLU_ConfigSetting. Move declaration of xlu__cfg_set_free() to shared header to indicate it will bridge layers. Signed-off-by: Elliott Mitchell --- This is the end of the higher-value series. Moving the loop is appropriate whether or not libxlu_cfg.c is split. Moving the declaration and patches after this though are mostly valuable for splitting libxlu_cfg.c into reusable and non-reusable portions. --- tools/libs/util/libxlu_cfg.c | 20 ++++++++------------ tools/libs/util/libxlu_cfg_y.y | 1 - tools/libs/util/libxlu_internal.h | 5 +++++ 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 69b95a4ed0..7fec7fe7be 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -178,22 +178,18 @@ void xlu__cfg_value_free(XLU_ConfigValue *value) } void xlu__cfg_set_free(XLU_ConfigSetting *set) { - if (!set) return; - free(set->name); - xlu__cfg_value_free(set->value); - free(set); + while(set) { + XLU_ConfigSetting *next = set->next; + free(set->name); + xlu__cfg_value_free(set->value); + free(set); + set = next; + } } void xlu_cfg_destroy(XLU_Config *cfg) { - XLU_ConfigSetting *set, *set_next; - if (!cfg) return; - for (set= cfg->settings; - set; - set= set_next) { - set_next= set->next; - xlu__cfg_set_free(set); - } + xlu__cfg_set_free(cfg->settings); free((void *)cfg->config_source); free(cfg); } diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index 5dfb06941a..5c7e31222d 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -32,7 +32,6 @@ enum XLU_Operation { XLU_OP_ADDITION, }; -void xlu__cfg_set_free(XLU_ConfigSetting *set); void xlu__cfg_set_store(CfgParseContext*, char *name, enum XLU_Operation op, XLU_ConfigValue *val, int lineno); diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 93caf24a6e..cc98efba27 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -35,6 +35,11 @@ typedef struct XLU_ConfigSetting XLU_ConfigSetting; extern int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) __attribute__((__format__(__printf__, 2, 3))); +/* + * Internals for file parser *only*, NOT to be used by other parsing/lexing + */ +extern void xlu__cfg_set_free(XLU_ConfigSetting *set); + #endif /*LIBXLU_INTERNAL_H*/ /* -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:31:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:31:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575560.901206 (Exim 4.92) (envelope-from ) id 1qRJRa-0003xr-A5; Wed, 02 Aug 2023 21:31:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575560.901206; Wed, 02 Aug 2023 21:31:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJRa-0003xi-7K; Wed, 02 Aug 2023 21:31:46 +0000 Received: by outflank-mailman (input) for mailman id 575560; Wed, 02 Aug 2023 21:31:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJRZ-0003Og-5O for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:31:45 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f90ad61c-317b-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:31:43 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LVX8K008530 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:31:38 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LVXH9008529; Wed, 2 Aug 2023 14:31:33 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f90ad61c-317b-11ee-8613-37d641c3527e Message-Id: <88fee0319d859ab9643a735bc3a3038e245afe6d.1690990428.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Wed, 19 Jul 2023 10:31:21 -0700 Subject: [PATCH 18/22] tools/utils: spread xlu_cfg_printf() over libxlu_cfg.c X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com There are far more printf()s inside libxlu_cfg.c, so these had been left alone briefly. Now attack all of these. Signed-off-by: Elliott Mitchell --- Note, several messages change mildly. The message in parse() didn't previously include the filename. --- tools/libs/util/libxlu_cfg.c | 78 ++++++++++++++++-------------------- 1 file changed, 35 insertions(+), 43 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 7fec7fe7be..91e056bb33 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -78,8 +78,7 @@ static int ctx_prep(CfgParseContext *ctx, XLU_Config *cfg) { e= xlu__cfg_yylex_init_extra(ctx, &ctx->scanner); if (e) { - fprintf(cfg->report,"%s: unable to create scanner: %s\n", - cfg->config_source, strerror(e)); + xlu_cfg_printf(cfg, " unable to create scanner: %s\n", strerror(e)); return e; } return 0; @@ -99,11 +98,12 @@ static void parse(CfgParseContext *ctx) { if (r) assert(ctx->err); if (ctx->err && ctx->likely_python) { - fputs( - "warning: Config file looks like it contains Python code.\n" - "warning: Arbitrary Python is no longer supported.\n" - "warning: See https://wiki.xen.org/wiki/PythonInXlConfig\n", - ctx->cfg->report); + xlu_cfg_printf(ctx->cfg, + " warning: Config file looks like it contains Python code.\n"); + xlu_cfg_printf(ctx->cfg, + " warning: Arbitrary Python is no longer supported.\n"); + xlu_cfg_printf(ctx->cfg, + " warning: See https://wiki.xen.org/wiki/PythonInXlConfig\n"); } } @@ -144,8 +144,7 @@ int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length) { buf = xlu__cfg_yy_scan_bytes(data, length, ctx.scanner); if (!buf) { - fprintf(cfg->report,"%s: unable to allocate scanner buffer\n", - cfg->config_source); + xlu_cfg_printf(cfg, " unable to allocate scanner buffer\n"); ctx.err= ENOMEM; goto xe; } @@ -236,10 +235,10 @@ static int find_atom(const XLU_Config *cfg, const char *n, if (set->value->type!=XLU_STRING) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d: warning: parameter `%s' is" + xlu_cfg_printf(cfg, + "%d: warning: parameter `%s' is" " a list but should be a single value\n", - cfg->config_source, set->lineno, n); + set->lineno, n); return EINVAL; } *set_r= set; @@ -257,10 +256,8 @@ int xlu_cfg_value_get_string(const XLU_Config *cfg, XLU_ConfigValue *value, { if (value->type != XLU_STRING) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d:%d: warning: value is not a string\n", - cfg->config_source, value->loc.first_line, - value->loc.first_column); + xlu_cfg_printf(cfg, "%d:%d: warning: value is not a string\n", + value->loc.first_line, value->loc.first_column); *value_r = NULL; return EINVAL; } @@ -274,10 +271,8 @@ int xlu_cfg_value_get_list(const XLU_Config *cfg, XLU_ConfigValue *value, { if (value->type != XLU_LIST) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d:%d: warning: value is not a list\n", - cfg->config_source, value->loc.first_line, - value->loc.first_column); + xlu_cfg_printf(cfg, "%d:%d: warning: value is not a list\n", + value->loc.first_line, value->loc.first_column); *value_r = NULL; return EINVAL; } @@ -325,10 +320,10 @@ int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *n, e= find_atom(cfg,n,&set,dont_warn); if (e) return e; if (set->op == XLU_OP_ADDITION) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d: warning: can't use += with numbers" + xlu_cfg_printf(cfg, + "%d: warning: can't use += with numbers" " for parameter `%s'\n", - cfg->config_source, set->lineno, n); + set->lineno, n); return EINVAL; } errno= 0; l= strtol(set->value->u.string, &ep, 0); @@ -337,31 +332,31 @@ int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *n, e= errno; assert(e==EINVAL || e==ERANGE); if (!dont_warn) - fprintf(cfg->report, - "%s:%d: warning: parameter `%s' could not be parsed" + xlu_cfg_printf(cfg, + "%d: warning: parameter `%s' could not be parsed" " as a number: %s\n", - cfg->config_source, set->lineno, n, strerror(e)); + set->lineno, n, strerror(e)); return e; } if (*ep || ep==set->value->u.string) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d: warning: parameter `%s' is not a valid number\n", - cfg->config_source, set->lineno, n); + xlu_cfg_printf(cfg, + "%d: warning: parameter `%s' is not a valid number\n", + set->lineno, n); return EINVAL; } if (l < min) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d: warning: value `%ld' is smaller than minimum bound '%ld'\n", - cfg->config_source, set->lineno, l, min); + xlu_cfg_printf(cfg, + "%d: warning: value `%ld' is smaller than minimum bound '%ld'\n", + set->lineno, l, min); return EINVAL; } if (l > max) { if (!dont_warn) - fprintf(cfg->report, - "%s:%d: warning: value `%ld' is greater than maximum bound '%ld'\n", - cfg->config_source, set->lineno, l, max); + xlu_cfg_printf(cfg, + "%d: warning: value `%ld' is greater than maximum bound '%ld'\n", + set->lineno, l, max); return EINVAL; } @@ -393,10 +388,10 @@ int xlu_cfg_get_list(const XLU_Config *cfg, const char *n, set= find(cfg,n); if (!set) return ESRCH; if (set->value->type!=XLU_LIST) { if (!dont_warn) { - fprintf(cfg->report, - "%s:%d: warning: parameter `%s' is a single value" + xlu_cfg_printf(cfg, + "%d: warning: parameter `%s' is a single value" " but should be a list\n", - cfg->config_source, set->lineno, n); + set->lineno, n); } return EINVAL; } @@ -743,11 +738,8 @@ void xlu__cfg_yyerror(XLU__CFG_YYLTYPE *loc, CfgParseContext *ctx, len--; } - fprintf(ctx->cfg->report, - "%s:%d: config parsing error near %s%.*s%s%s: %s\n", - ctx->cfg->config_source, lineno, - len?"`":"", len, text, len?"'":"", newline, - msg); + xlu_cfg_printf(ctx->cfg, "%d: config parsing error near %s%.*s%s%s: %s\n", + lineno, len?"`":"", len, text, len?"'":"", newline, msg); if (!ctx->err) ctx->err= EINVAL; } -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:32:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:32:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575568.901216 (Exim 4.92) (envelope-from ) id 1qRJS0-0004SP-Hj; Wed, 02 Aug 2023 21:32:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575568.901216; Wed, 02 Aug 2023 21:32:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJS0-0004SI-F2; Wed, 02 Aug 2023 21:32:12 +0000 Received: by outflank-mailman (input) for mailman id 575568; Wed, 02 Aug 2023 21:32:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJRy-0004Rr-Pb for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:32:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJRy-0006AL-D6; Wed, 02 Aug 2023 21:32:10 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRJRy-00085k-7f; Wed, 02 Aug 2023 21:32:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wx9wWzO62qpM3Q3HJhjfG7MpH0kyWjiPahf2FbxCNWk=; b=x9RmiT6GXPgVIXgqtuzwVc7jmu LtKz5HslaZLNsZSP93dvpfi00avFmanojJlJJBY8yjdyiET7BYtyyz1hO60/unaiLyLSJZrZAULKv MLeazuSRtAhFYdkN4v/OHV0woZpuklNKtp09X9WJBM47jJSkRrjqpA+0zSavLFOTFFM8=; Message-ID: Date: Wed, 2 Aug 2023 22:32:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] arm32: Avoid using solaris syntax for .section directive To: Khem Raj Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Michal Orzel References: <20230801174930.2995947-1-raj.khem@gmail.com> <18d3b823-22b2-85fc-18d2-09cf102b4506@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 01/08/2023 22:49, Khem Raj wrote: > On Tue, Aug 1, 2023 at 2:03 PM Julien Grall wrote: >> >> Hi, >> >> Title: This patch is not arm32 specific anymore. So I would replace >> 'arm32' with 'arm'. This can be done on commit. >> >> On 01/08/2023 18:49, Khem Raj wrote: >>> Assembler from binutils 2.41 rejects [1] this syntax >>> >>> .section "name"[, flags...] >>> >>> where flags could be #alloc, #write, #execinstr, #exclude, and #tls [2] >>> >>> It is almost like a regression compared to 2.40 or older release, >> >> The next word after ',' start with an uppercase. Did you intend to use >> '.' rather than ','? >> >> That said, the documentation has the following: >> >> For SPARC ELF targets, the assembler supports another type of .section >> directive for compatibility with the Solaris assembler:" >> >> This leads me to think this is not a regression and instead an intended >> behavior (even though it breaks older build) even it breaks build. >> >> I would suggest to reword the commit message to: >> >> " >> Assembler from binutiles 2.41 will rejects ([1], [2]) the following syntax >> >> .section "name", #alloc >> >> for any other any target other than ELF SPARC. This means we can't use >> it in the Arm code. >> >> So switch to the GNU syntax >> >> .section name [, "flags"[, @type]] >> >> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 >> [2] https://sourceware.org/binutils/docs-2.41/as.html#Section >> >> If you agree with the commit message, I can update it while committing. > > LGTM, go ahead. I have committed with: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:35:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:35:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575578.901226 (Exim 4.92) (envelope-from ) id 1qRJUx-00059N-WD; Wed, 02 Aug 2023 21:35:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575578.901226; Wed, 02 Aug 2023 21:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJUx-00059G-TI; Wed, 02 Aug 2023 21:35:15 +0000 Received: by outflank-mailman (input) for mailman id 575578; Wed, 02 Aug 2023 21:35:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJUw-00059A-Mu for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:35:14 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75fc2764-317c-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:35:12 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LZ28o008587 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:35:07 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LZ2Ae008586; Wed, 2 Aug 2023 14:35:02 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75fc2764-317c-11ee-b263-6b7b168915f2 Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 25 Jul 2023 15:50:14 -0700 Subject: [PATCH 22/22] tools/utils: break flex/bison parser away from main config file X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Potentially allowing a different parser to be substituted. Omit libxlu_internal.h from libxlu_cfg_i.c, since it is kept in libxlu_cfg_y.h. Signed-off-by: Elliott Mitchell --- tools/libs/util/Makefile | 1 + tools/libs/util/libxlu_cfg.c | 662 ------------------ .../util/{libxlu_cfg.c => libxlu_cfg_i.c} | 87 --- 3 files changed, 1 insertion(+), 749 deletions(-) copy tools/libs/util/{libxlu_cfg.c => libxlu_cfg_i.c} (90%) diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile index d2c90ced69..bfca15b9b5 100644 --- a/tools/libs/util/Makefile +++ b/tools/libs/util/Makefile @@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk OBJS-y += libxlu_cfg_y.o OBJS-y += libxlu_cfg_l.o +OBJS-y += libxlu_cfg_i.o OBJS-y += libxlu_cfg.o OBJS-y += libxlu_disk_l.o OBJS-y += libxlu_disk.o diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 7bbedde8f6..040d3ea914 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -21,31 +21,6 @@ #include #include "libxlu_internal.h" -#include "libxlu_cfg_y.h" -#include "libxlu_cfg_l.h" - -struct XLU_ConfigSetting { - struct XLU_ConfigSetting *next; - char *name; - XLU_ConfigValue *value; - enum XLU_Operation op; - int lineno; -}; - -struct XLU_ConfigList { - int avalues; /* available slots */ - int nvalues; /* actual occupied slots */ - XLU_ConfigValue **values; -}; - -struct XLU_ConfigValue { - enum XLU_ConfigValueType type; - union { - char *string; - XLU_ConfigList list; - } u; - XLU__CFG_YYLTYPE loc; -}; struct XLU_Config { XLU_ConfigSetting *settings; @@ -67,49 +42,6 @@ XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { return cfg; } -static int ctx_prep(CfgParseContext *ctx, XLU_Config *cfg, - XLU_ConfigSetting **psettings) -{ - int e; - - ctx->cfg= cfg; - ctx->psettings = psettings; - ctx->err= 0; - ctx->lexerrlineno= -1; - ctx->likely_python= 0; - ctx->scanner= 0; - - e= xlu__cfg_yylex_init_extra(ctx, &ctx->scanner); - if (e) { - xlu_cfg_printf(cfg, " unable to create scanner: %s\n", strerror(e)); - return e; - } - return 0; -} - -static void ctx_dispose(CfgParseContext *ctx) { - if (ctx->scanner) xlu__cfg_yylex_destroy(ctx->scanner); -} - -static void parse(CfgParseContext *ctx) { - /* On return, ctx.err will be updated with the error status. */ - int r; - - xlu__cfg_yyset_lineno(1, ctx->scanner); - - r= xlu__cfg_yyparse(ctx); - if (r) assert(ctx->err); - - if (ctx->err && ctx->likely_python) { - xlu_cfg_printf(ctx->cfg, - " warning: Config file looks like it contains Python code.\n"); - xlu_cfg_printf(ctx->cfg, - " warning: Arbitrary Python is no longer supported.\n"); - xlu_cfg_printf(ctx->cfg, - " warning: See https://wiki.xen.org/wiki/PythonInXlConfig\n"); - } -} - int xlu_cfg_readfile(XLU_Config *cfg, const char *name) { FILE *file; @@ -129,85 +61,12 @@ int xlu_cfg_readfile(XLU_Config *cfg, const char *name) return ret; } -int xlu__cfg_readfile(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, - XLU_ConfigSetting **psettings, FILE *f, const char *name) -{ - int e; - - CfgParseContext ctx; - e = ctx_prep(&ctx, cfg, psettings); - if (e) { ctx.err= e; goto xe; } - - xlu__cfg_yyrestart(f, ctx.scanner); - - parse(&ctx); - - xe: - ctx_dispose(&ctx); - - return ctx.err; -} - int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length) { return xlu__cfg_readdata(cfg, cfg->report, cfg->config_source, &cfg->settings, data, length); } -int xlu__cfg_readdata(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, - XLU_ConfigSetting **psettings, const char *data, int length) -{ - int e; - YY_BUFFER_STATE buf= 0; - - CfgParseContext ctx; - e = ctx_prep(&ctx, cfg, psettings); - if (e) { ctx.err= e; goto xe; } - - buf = xlu__cfg_yy_scan_bytes(data, length, ctx.scanner); - if (!buf) { - xlu_cfg_printf(cfg, " unable to allocate scanner buffer\n"); - ctx.err= ENOMEM; - goto xe; - } - - parse(&ctx); - - xe: - if (buf) xlu__cfg_yy_delete_buffer(buf, ctx.scanner); - ctx_dispose(&ctx); - - return ctx.err; -} - -void xlu__cfg_value_free(XLU_ConfigValue *value) -{ - int i; - - if (!value) return; - - switch (value->type) { - case XLU_STRING: - free(value->u.string); - break; - case XLU_LIST: - for (i = 0; i < value->u.list.nvalues; i++) - xlu__cfg_value_free(value->u.list.values[i]); - free(value->u.list.values); - } - free(value); -} - -void xlu__cfg_set_free(XLU_ConfigSetting *set) { - while(set) { - XLU_ConfigSetting *next = set->next; - free(set->name); - xlu__cfg_value_free(set->value); - free(set); - set = next; - } -} - void xlu_cfg_destroy(XLU_Config *cfg) { if (!cfg) return; xlu__cfg_set_free(cfg->settings); @@ -237,539 +96,18 @@ int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) return -errno; } -static XLU_ConfigSetting *find(const XLU_Config *cfg, const char *n) { - XLU_ConfigSetting *set; - - for (set = xlu__cfg_get_settings(cfg); - set; - set= set->next) - if (!strcmp(set->name, n)) - return set; - return 0; -} - -static int find_atom(const XLU_Config *cfg, const char *n, - XLU_ConfigSetting **set_r, int dont_warn) { - XLU_ConfigSetting *set; - - set= find(cfg,n); - if (!set) return ESRCH; - - if (set->value->type!=XLU_STRING) { - if (!dont_warn) - xlu_cfg_printf(cfg, - "%d: warning: parameter `%s' is" - " a list but should be a single value\n", - set->lineno, n); - return EINVAL; - } - *set_r= set; - return 0; -} - XLU_ConfigSetting *xlu__cfg_get_settings(const XLU_Config *cfg) { return cfg->settings; } -enum XLU_ConfigValueType xlu_cfg_value_type(const XLU_ConfigValue *value) -{ - return value->type; -} - -int xlu_cfg_value_get_string(const XLU_Config *cfg, XLU_ConfigValue *value, - char **value_r, int dont_warn) -{ - if (value->type != XLU_STRING) { - if (!dont_warn) - xlu_cfg_printf(cfg, "%d:%d: warning: value is not a string\n", - value->loc.first_line, value->loc.first_column); - *value_r = NULL; - return EINVAL; - } - - *value_r = value->u.string; - return 0; -} - -int xlu_cfg_value_get_list(const XLU_Config *cfg, XLU_ConfigValue *value, - XLU_ConfigList **value_r, int dont_warn) -{ - if (value->type != XLU_LIST) { - if (!dont_warn) - xlu_cfg_printf(cfg, "%d:%d: warning: value is not a list\n", - value->loc.first_line, value->loc.first_column); - *value_r = NULL; - return EINVAL; - } - - *value_r = &value->u.list; - return 0; -} - -XLU_ConfigValue *xlu_cfg_get_listitem2(const XLU_ConfigList *list, - int entry) -{ - if (entry < 0 || entry >= list->nvalues) return NULL; - return list->values[entry]; -} - -int xlu_cfg_get_string(const XLU_Config *cfg, const char *n, - const char **value_r, int dont_warn) { - XLU_ConfigSetting *set; - int e; - - e= find_atom(cfg,n,&set,dont_warn); if (e) return e; - *value_r= set->value->u.string; - return 0; -} - -int xlu_cfg_replace_string(const XLU_Config *cfg, const char *n, - char **value_r, int dont_warn) { - XLU_ConfigSetting *set; - int e; - - e= find_atom(cfg,n,&set,dont_warn); if (e) return e; - free(*value_r); - *value_r= strdup(set->value->u.string); - return 0; -} - -int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *n, - long min, long max, long *value_r, - int dont_warn) { - long l; - XLU_ConfigSetting *set; - int e; - char *ep; - - e= find_atom(cfg,n,&set,dont_warn); if (e) return e; - if (set->op == XLU_OP_ADDITION) { - if (!dont_warn) - xlu_cfg_printf(cfg, - "%d: warning: can't use += with numbers" - " for parameter `%s'\n", - set->lineno, n); - return EINVAL; - } - errno= 0; l= strtol(set->value->u.string, &ep, 0); - e= errno; - if (errno) { - e= errno; - assert(e==EINVAL || e==ERANGE); - if (!dont_warn) - xlu_cfg_printf(cfg, - "%d: warning: parameter `%s' could not be parsed" - " as a number: %s\n", - set->lineno, n, strerror(e)); - return e; - } - if (*ep || ep==set->value->u.string) { - if (!dont_warn) - xlu_cfg_printf(cfg, - "%d: warning: parameter `%s' is not a valid number\n", - set->lineno, n); - return EINVAL; - } - if (l < min) { - if (!dont_warn) - xlu_cfg_printf(cfg, - "%d: warning: value `%ld' is smaller than minimum bound '%ld'\n", - set->lineno, l, min); - return EINVAL; - } - if (l > max) { - if (!dont_warn) - xlu_cfg_printf(cfg, - "%d: warning: value `%ld' is greater than maximum bound '%ld'\n", - set->lineno, l, max); - return EINVAL; - } - - *value_r= l; - return 0; -} - int xlu_cfg_get_long(const XLU_Config *cfg, const char *n, long *value_r, int dont_warn) { return xlu_cfg_get_bounded_long(cfg, n, LONG_MIN, LONG_MAX, value_r, dont_warn); } -int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *n, - libxl_defbool *value_r, int dont_warn) -{ - int ret; - long l; - - ret = xlu_cfg_get_long(cfg, n, &l, dont_warn); - if (ret) return ret; - libxl_defbool_set(value_r, !!l); - return 0; -} - -int xlu_cfg_get_list(const XLU_Config *cfg, const char *n, - XLU_ConfigList **list_r, int *entries_r, int dont_warn) { - XLU_ConfigSetting *set; - set= find(cfg,n); if (!set) return ESRCH; - if (set->value->type!=XLU_LIST) { - if (!dont_warn) { - xlu_cfg_printf(cfg, - "%d: warning: parameter `%s' is a single value" - " but should be a list\n", - set->lineno, n); - } - return EINVAL; - } - if (list_r) *list_r= &set->value->u.list; - if (entries_r) *entries_r= set->value->u.list.nvalues; - return 0; -} - -int xlu_cfg_get_list_as_string_list(const XLU_Config *cfg, const char *n, - libxl_string_list *psl, int dont_warn) { - int i, rc, nr; - XLU_ConfigList *list; - libxl_string_list sl; - - rc = xlu_cfg_get_list(cfg, n, &list, &nr, dont_warn); - if (rc) return rc; - - sl = malloc(sizeof(char*)*(nr + 1)); - if (sl == NULL) return ENOMEM; - - for (i=0; i= list->nvalues) return 0; - if (list->values[entry]->type != XLU_STRING) return 0; - return list->values[entry]->u.string; -} - - -XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, char *atom, - XLU__CFG_YYLTYPE *loc) -{ - XLU_ConfigValue *value = NULL; - - if (ctx->err) goto x; - - value = malloc(sizeof(*value)); - if (!value) goto xe; - value->type = XLU_STRING; - value->u.string = atom; - memcpy(&value->loc, loc, sizeof(*loc)); - - return value; - - xe: - ctx->err= errno; - x: - free(value); - free(atom); - return NULL; -} - -XLU_ConfigValue *xlu__cfg_list_mk(CfgParseContext *ctx, - XLU_ConfigValue *val, - XLU__CFG_YYLTYPE *loc) -{ - XLU_ConfigValue *value = NULL; - XLU_ConfigValue **values = NULL; - - if (ctx->err) goto x; - - values = malloc(sizeof(*values)); - if (!values) goto xe; - values[0] = val; - - value = malloc(sizeof(*value)); - if (!value) goto xe; - value->type = XLU_LIST; - value->u.list.nvalues = !!val; - value->u.list.avalues = 1; - value->u.list.values = values; - memcpy(&value->loc, loc, sizeof(*loc)); - - return value; - - xe: - ctx->err= errno; - x: - free(value); - free(values); - xlu__cfg_value_free(val); - return NULL; -} - -void xlu__cfg_list_append(CfgParseContext *ctx, - XLU_ConfigValue *list, - XLU_ConfigValue *val) -{ - if (ctx->err) return; - - assert(val); - assert(list->type == XLU_LIST); - - if (list->u.list.nvalues >= list->u.list.avalues) { - int new_avalues; - XLU_ConfigValue **new_values = NULL; - - if (list->u.list.avalues > INT_MAX / 100) { - ctx->err = ERANGE; - xlu__cfg_value_free(val); - return; - } - - new_avalues = list->u.list.avalues * 4; - new_values = realloc(list->u.list.values, - sizeof(*new_values) * new_avalues); - if (!new_values) { - ctx->err = errno; - xlu__cfg_value_free(val); - return; - } - - list->u.list.avalues = new_avalues; - list->u.list.values = new_values; - } - - list->u.list.values[list->u.list.nvalues] = val; - list->u.list.nvalues++; -} - -static int xlu__cfg_concat_vals(CfgParseContext *ctx, - XLU_ConfigValue *prev, - XLU_ConfigValue *to_add) -{ - int r; - - if (prev->type != to_add->type) { - xlu__cfgl_lexicalerror(ctx, - "can't add [list] to \"string\" or vice versa"); - return EINVAL; - } - - switch (to_add->type) { - case XLU_STRING: { - char *new_string = NULL; - - r = asprintf(&new_string, "%s%s", prev->u.string, - to_add->u.string); - if (r < 0) { - return errno; - } - free(to_add->u.string); - to_add->u.string = new_string; - return 0; - } - case XLU_LIST: { - XLU_ConfigList *const prev_list = &prev->u.list; - XLU_ConfigList *const cur_list = &to_add->u.list; - int nvalues; - - if (prev->u.list.nvalues > INT_MAX - to_add->u.list.nvalues) { - return ERANGE; - } - nvalues = prev->u.list.nvalues + to_add->u.list.nvalues; - - if (nvalues >= cur_list->avalues) { - XLU_ConfigValue **new_vals; - new_vals = realloc(cur_list->values, - nvalues * sizeof(*new_vals)); - if (!new_vals) { - return ENOMEM; - } - cur_list->avalues = nvalues; - cur_list->values = new_vals; - } - - /* make space for `prev' into `to_add' */ - memmove(cur_list->values + prev_list->nvalues, - cur_list->values, - cur_list->nvalues * sizeof(XLU_ConfigValue *)); - /* move values from `prev' to `to_add' as the list in `prev' will - * not be reachable by find(). */ - memcpy(cur_list->values, - prev_list->values, - prev_list->nvalues * sizeof(XLU_ConfigValue *)); - cur_list->nvalues = nvalues; - prev_list->nvalues = 0; - memset(prev_list->values, 0, - prev_list->nvalues * sizeof(XLU_ConfigValue *)); - return 0; - } - default: - abort(); - } - return -1; -} - -void xlu__cfg_set_store(CfgParseContext *ctx, char *name, - enum XLU_Operation op, - XLU_ConfigValue *val, int lineno) { - XLU_ConfigSetting *set; - int r; - - if (ctx->err) goto out; - - assert(name); - - if (op == XLU_OP_ADDITION) { - /* If we have += concatenate with previous value with same name */ - XLU_ConfigSetting *prev_set = find(ctx->cfg, name); - if (prev_set) { - r = xlu__cfg_concat_vals(ctx, prev_set->value, val); - if (r) { - ctx->err = r; - goto out; - } - } - } - - set = malloc(sizeof(*set)); - if (!set) { - ctx->err = errno; - goto out; - } - set->name= name; - set->value = val; - set->op = op; - set->lineno= lineno; - set->next = *ctx->psettings; - *ctx->psettings = set; - return; -out: - assert(ctx->err); - free(name); - xlu__cfg_value_free(val); -} - -char *xlu__cfgl_strdup(CfgParseContext *ctx, const char *src) { - char *result; - - if (ctx->err) return 0; - result= strdup(src); - if (!result) ctx->err= errno; - return result; -} - -char *xlu__cfgl_dequote(CfgParseContext *ctx, const char *src) { - char *result; - const char *p; - char *q; - int len, c, nc; - - if (ctx->err) return 0; - - len= strlen(src); - assert(len>=2 && src[0]==src[len-1]); - - result= malloc(len-1); - if (!result) { ctx->err= errno; return 0; } - - q= result; - - for (p= src+1; - p < src+len-1; - ) { - c= *p++; - if (c=='\\') { - assert(p < src+len-1); - nc= *p++; - if (nc=='"' || nc=='\'' || nc=='\\') { - *q++= nc; - } else if (nc=='a') { *q++= '\007'; - } else if (nc=='b') { *q++= '\010'; - } else if (nc=='f') { *q++= '\014'; - } else if (nc=='n') { *q++= '\n'; - } else if (nc=='r') { *q++= '\r'; - } else if (nc=='t') { *q++= '\t'; - } else if (nc=='v') { *q++= '\013'; - } else if (nc=='x') { - -#define NUMERIC_CHAR(minlen,maxlen,base,basetext) do{ \ - char numbuf[(maxlen)+1], *ep; \ - unsigned long val; \ - \ - strncpy(numbuf,p,(maxlen)); \ - numbuf[(maxlen)]= 0; \ - val= strtoul(numbuf, &ep, (base)); \ - if (ep <= numbuf+(minlen)) { \ - xlu__cfgl_lexicalerror(ctx,"invalid digit after" \ - " backslash " basetext "numerical character escape" \ - " in quoted string"); \ - ctx->err= EINVAL; \ - goto x; \ - } \ - p += (ep - numbuf); \ - }while(0) - - p++; - NUMERIC_CHAR(2,2,16,"hex"); - } else if (nc>='0' && nc<='7') { - NUMERIC_CHAR(1,3,10,"octal"); - } else { - xlu__cfgl_lexicalerror(ctx, - "invalid character after backlash in quoted string"); - ctx->err= EINVAL; - goto x; - } - assert(p <= src+len-1); - } else { - *q++= c; - } - } - - x: - *q++= 0; - return result; -} - -void xlu__cfgl_lexicalerror(CfgParseContext *ctx, char const *msg) { - XLU__CFG_YYLTYPE loc; - loc.first_line= xlu__cfg_yyget_lineno(ctx->scanner); - xlu__cfg_yyerror(&loc, ctx, msg); - ctx->lexerrlineno= loc.first_line; -} - -void xlu__cfg_yyerror(XLU__CFG_YYLTYPE *loc, CfgParseContext *ctx, - char const *msg) { - const char *text, *newline; - int len, lineno; - - lineno= loc->first_line; - if (lineno <= ctx->lexerrlineno) return; - - text= xlu__cfg_yyget_text(ctx->scanner); - len= xlu__cfg_yyget_leng(ctx->scanner); - newline= ""; - if (len>0 && text[len-1]=='\n') { - len--; - lineno--; - if (!len) { - newline= ""; - } - } - while (len>0 && (text[len-1]=='\t' || text[len-1]==' ')) { - len--; - } - - xlu_cfg_printf(ctx->cfg, "%d: config parsing error near %s%.*s%s%s: %s\n", - lineno, len?"`":"", len, text, len?"'":"", newline, msg); - if (!ctx->err) ctx->err= EINVAL; -} - /* * Local variables: * mode: C diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg_i.c similarity index 90% copy from tools/libs/util/libxlu_cfg.c copy to tools/libs/util/libxlu_cfg_i.c index 7bbedde8f6..bf5890b273 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg_i.c @@ -20,7 +20,6 @@ #include #include -#include "libxlu_internal.h" #include "libxlu_cfg_y.h" #include "libxlu_cfg_l.h" @@ -47,26 +46,6 @@ struct XLU_ConfigValue { XLU__CFG_YYLTYPE loc; }; -struct XLU_Config { - XLU_ConfigSetting *settings; - FILE *report; - const char *config_source; -}; - -XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { - XLU_Config *cfg; - - cfg= malloc(sizeof(*cfg)); - if (!cfg) return 0; - - cfg->report= report; - cfg->config_source= strdup(report_source); - if (!cfg->config_source) { free(cfg); return 0; } - - cfg->settings= 0; - return cfg; -} - static int ctx_prep(CfgParseContext *ctx, XLU_Config *cfg, XLU_ConfigSetting **psettings) { @@ -110,25 +89,6 @@ static void parse(CfgParseContext *ctx) { } } -int xlu_cfg_readfile(XLU_Config *cfg, const char *name) -{ - FILE *file; - int ret; - - file = fopen(name, "r"); - if (file) { - ret = xlu__cfg_readfile(cfg, cfg->report, cfg->config_source, - &cfg->settings, file, name); - fclose(file); - } else { - ret = errno; - fprintf(cfg->report,"%s: unable to open configuration file: %s\n", - name, strerror(ret)); - } - - return ret; -} - int xlu__cfg_readfile(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, XLU_ConfigSetting **psettings, FILE *f, const char *name) { @@ -148,12 +108,6 @@ int xlu__cfg_readfile(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, return ctx.err; } -int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length) -{ - return xlu__cfg_readdata(cfg, cfg->report, cfg->config_source, - &cfg->settings, data, length); -} - int xlu__cfg_readdata(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, XLU_ConfigSetting **psettings, const char *data, int length) { @@ -208,35 +162,6 @@ void xlu__cfg_set_free(XLU_ConfigSetting *set) { } } -void xlu_cfg_destroy(XLU_Config *cfg) { - if (!cfg) return; - xlu__cfg_set_free(cfg->settings); - free((void *)cfg->config_source); - free(cfg); -} - -int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) -{ - va_list args; - int ret; - - if (!cfg || !cfg->report) - return EFAULT; - - ret = fputs(cfg->config_source, cfg->report); - if (ret < 0) - return -errno; - ret = fputc(':', cfg->report); - if (ret < 0) - return -errno; - - va_start(args, format); - ret = vfprintf(cfg->report, format, args); - va_end(args); - - return -errno; -} - static XLU_ConfigSetting *find(const XLU_Config *cfg, const char *n) { XLU_ConfigSetting *set; @@ -267,11 +192,6 @@ static int find_atom(const XLU_Config *cfg, const char *n, return 0; } -XLU_ConfigSetting *xlu__cfg_get_settings(const XLU_Config *cfg) -{ - return cfg->settings; -} - enum XLU_ConfigValueType xlu_cfg_value_type(const XLU_ConfigValue *value) { @@ -391,12 +311,6 @@ int xlu_cfg_get_bounded_long(const XLU_Config *cfg, const char *n, return 0; } -int xlu_cfg_get_long(const XLU_Config *cfg, const char *n, - long *value_r, int dont_warn) { - return xlu_cfg_get_bounded_long(cfg, n, LONG_MIN, LONG_MAX, value_r, - dont_warn); -} - int xlu_cfg_get_defbool(const XLU_Config *cfg, const char *n, libxl_defbool *value_r, int dont_warn) { @@ -456,7 +370,6 @@ const char *xlu_cfg_get_listitem(const XLU_ConfigList *list, int entry) { return list->values[entry]->u.string; } - XLU_ConfigValue *xlu__cfg_string_mk(CfgParseContext *ctx, char *atom, XLU__CFG_YYLTYPE *loc) { -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:37:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:37:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575603.901237 (Exim 4.92) (envelope-from ) id 1qRJX0-0005nx-GS; Wed, 02 Aug 2023 21:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575603.901237; Wed, 02 Aug 2023 21:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJX0-0005nq-C3; Wed, 02 Aug 2023 21:37:22 +0000 Received: by outflank-mailman (input) for mailman id 575603; Wed, 02 Aug 2023 21:37:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJU4-0003Og-Oi for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:34:20 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55ed6a32-317c-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:34:19 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LY9lp008578 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:34:15 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LY9Dr008577; Wed, 2 Aug 2023 14:34:09 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55ed6a32-317c-11ee-8613-37d641c3527e Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 25 Jul 2023 20:11:06 -0700 Subject: [PATCH 21/22] tools/utils: add settings get function X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com The better to isolate the shared portion of the interface from the low-level implementation. Signed-off-by: Elliott Mitchell --- tools/libs/util/libxlu_cfg.c | 7 ++++++- tools/libs/util/libxlu_internal.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index cb99b0aab0..7bbedde8f6 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -240,7 +240,7 @@ int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) static XLU_ConfigSetting *find(const XLU_Config *cfg, const char *n) { XLU_ConfigSetting *set; - for (set= cfg->settings; + for (set = xlu__cfg_get_settings(cfg); set; set= set->next) if (!strcmp(set->name, n)) @@ -267,6 +267,11 @@ static int find_atom(const XLU_Config *cfg, const char *n, return 0; } +XLU_ConfigSetting *xlu__cfg_get_settings(const XLU_Config *cfg) +{ + return cfg->settings; +} + enum XLU_ConfigValueType xlu_cfg_value_type(const XLU_ConfigValue *value) { diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 34c6c7a443..993ff88171 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -45,6 +45,8 @@ extern int xlu__cfg_readfile(XLU_Config *cfg, FILE *msgfile, extern int xlu__cfg_readdata(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, XLU_ConfigSetting **psettings, const char *data, int length); +extern XLU_ConfigSetting *xlu__cfg_get_settings(const XLU_Config *cfg) + __attribute__((access(read_only, 1))); #endif /*LIBXLU_INTERNAL_H*/ -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:37:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:37:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575608.901245 (Exim 4.92) (envelope-from ) id 1qRJX2-00063n-Mm; Wed, 02 Aug 2023 21:37:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575608.901245; Wed, 02 Aug 2023 21:37:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJX2-00063e-Jf; Wed, 02 Aug 2023 21:37:24 +0000 Received: by outflank-mailman (input) for mailman id 575608; Wed, 02 Aug 2023 21:37:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJOE-0004vP-Mr for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:28:18 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c87010a-317b-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:28:14 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LS4dU008489 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:28:10 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LS4M9008488; Wed, 2 Aug 2023 14:28:04 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c87010a-317b-11ee-b263-6b7b168915f2 Message-Id: <7c33609a299bcec685b9a77becd73abefbb9d237.1690990428.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Thu, 13 Jul 2023 19:01:19 -0700 Subject: [PATCH 14/22] tools/utils: introduce xlu_cfg_printf() function X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Isolate the lower layer configuration handling from the upper layer. Now only the lowest layer of configuration handling looks inside XLU_Config. Also make error messages a bit more consistent. Now PCI device parsing will report filename. Replace the XLU__PCI_ERR() with xlu_cfg_printf(). The new function encompasses the full functionality of the macro. Signed-off-by: Elliott Mitchell --- Someone else can decide where xlu__disk_err() should have its linebreaks and indentation. That string isn't very good. I'm wondering about the return codes. *printf() can return errors, but so many places are ignoring them. If the output is a console the errors are fairly unlikely, but full storage does happen. --- tools/libs/util/libxlu_cfg.c | 23 +++++++++++++++++++++++ tools/libs/util/libxlu_disk.c | 14 +++++--------- tools/libs/util/libxlu_internal.h | 4 ++++ tools/libs/util/libxlu_pci.c | 11 ++++------- tools/libs/util/libxlu_vif.c | 4 +--- 5 files changed, 37 insertions(+), 19 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 67d1a8123f..e37f84829f 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -18,6 +18,7 @@ #define _GNU_SOURCE #include +#include #include "libxlu_internal.h" #include "libxlu_cfg_y.h" @@ -191,6 +192,28 @@ void xlu_cfg_destroy(XLU_Config *cfg) { free(cfg); } +int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) +{ + va_list args; + int ret; + + if (!cfg || !cfg->report) + return EFAULT; + + ret = fputs(cfg->config_source, cfg->report); + if (ret < 0) + return -errno; + ret = fputc(':', cfg->report); + if (ret < 0) + return -errno; + + va_start(args, format); + ret = vfprintf(cfg->report, format, args); + va_end(args); + + return -errno; +} + static XLU_ConfigSetting *find(const XLU_Config *cfg, const char *n) { XLU_ConfigSetting *set; diff --git a/tools/libs/util/libxlu_disk.c b/tools/libs/util/libxlu_disk.c index e94f4d06cd..8728c9e133 100644 --- a/tools/libs/util/libxlu_disk.c +++ b/tools/libs/util/libxlu_disk.c @@ -4,13 +4,10 @@ void xlu__disk_err(DiskParseContext *dpc, const char *erroneous, const char *message) { - fprintf(dpc->cfg->report, - "%s: config parsing error in disk specification: %s" - "%s%s%s" - " in `%s'\n", - dpc->cfg->config_source, message, - erroneous?": near `":"", erroneous?erroneous:"", erroneous?"'":"", - dpc->spec); + xlu_cfg_printf(dpc->cfg, + " config parsing error in disk specification: %s%s%s%s in `%s'\n", + message, erroneous?": near `":"", erroneous?erroneous:"", + erroneous?"'":"", dpc->spec); if (!dpc->err) dpc->err= EINVAL; } @@ -28,8 +25,7 @@ static int dpc_prep(DiskParseContext *dpc, const char *spec) { return 0; fail: - fprintf(dpc->cfg->report, "cannot init disk scanner: %s\n", - strerror(errno)); + xlu_cfg_printf(dpc->cfg, " cannot init disk scanner: %s\n", strerror(errno)); return e; } diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index 310e2145a7..214ebe5f48 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -37,6 +37,10 @@ struct XLU_Config { #define STRINGIFY(x) #x #define TOSTRING(x) STRINGIFY(x) + +extern int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) + __attribute__((__format__(__printf__, 2, 3))); + #endif /*LIBXLU_INTERNAL_H*/ /* diff --git a/tools/libs/util/libxlu_pci.c b/tools/libs/util/libxlu_pci.c index 294482c6d7..1f75317428 100644 --- a/tools/libs/util/libxlu_pci.c +++ b/tools/libs/util/libxlu_pci.c @@ -5,9 +5,6 @@ #include "libxlu_internal.h" -#define XLU__PCI_ERR(_c, _x, _a...) \ - if((_c) && (_c)->report) fprintf((_c)->report, _x, ##_a) - static int parse_bdf(libxl_device_pci *pci, const char *str, const char **endp) { const char *ptr = str; @@ -129,7 +126,7 @@ static int parse_rdm_policy(XLU_Config *cfg, libxl_rdm_reserve_policy *policy, int ret = libxl_rdm_reserve_policy_from_string(str, policy); if (ret) - XLU__PCI_ERR(cfg, "Unknown RDM policy: %s", str); + xlu_cfg_printf(cfg, " Unknown RDM policy: %s", str); return ret; } @@ -193,7 +190,7 @@ int xlu_pci_parse_spec_string(XLU_Config *cfg, libxl_device_pci *pci, pci->name = strdup(val); if (!pci->name) ret = ERROR_NOMEM; } else { - XLU__PCI_ERR(cfg, "Unknown PCI_SPEC_STRING option: %s", key); + xlu_cfg_printf(cfg, " Unknown PCI_SPEC_STRING option: %s", key); ret = ERROR_INVAL; } @@ -233,7 +230,7 @@ int xlu_rdm_parse(XLU_Config *cfg, libxl_rdm_reserve *rdm, const char *str) } else if (!strcmp(tok, "policy")) { state = STATE_RESERVE_POLICY; } else { - XLU__PCI_ERR(cfg, "Unknown RDM state option: %s", tok); + xlu_cfg_printf(cfg, " Unknown RDM state option: %s", tok); goto parse_error; } tok = ptr + 1; @@ -246,7 +243,7 @@ int xlu_rdm_parse(XLU_Config *cfg, libxl_rdm_reserve *rdm, const char *str) if (!strcmp(tok, "host")) { rdm->strategy = LIBXL_RDM_RESERVE_STRATEGY_HOST; } else { - XLU__PCI_ERR(cfg, "Unknown RDM strategy option: %s", tok); + xlu_cfg_printf(cfg, " Unknown RDM strategy option: %s", tok); goto parse_error; } tok = ptr + 1; diff --git a/tools/libs/util/libxlu_vif.c b/tools/libs/util/libxlu_vif.c index ccf0cbdf57..8331010550 100644 --- a/tools/libs/util/libxlu_vif.c +++ b/tools/libs/util/libxlu_vif.c @@ -6,9 +6,7 @@ static const char *vif_bytes_per_sec_re = "^[0-9]+[GMK]?[Bb]/s$"; static const char *vif_internal_usec_re = "^[0-9]+[mu]?s?$"; static void xlu__vif_err(XLU_Config *cfg, const char *msg, const char *rate) { - fprintf(cfg->report, - "%s: config parsing error in vif: %s in `%s'\n", - cfg->config_source, msg, rate); + xlu_cfg_printf(cfg, " config parsing error in vif: %s in `%s'\n", msg, rate); } static int vif_parse_rate_bytes_per_sec(XLU_Config *cfg, const char *bytes, -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:37:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:37:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575646.901257 (Exim 4.92) (envelope-from ) id 1qRJXJ-0006kv-0i; Wed, 02 Aug 2023 21:37:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575646.901257; Wed, 02 Aug 2023 21:37:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJXI-0006ko-RQ; Wed, 02 Aug 2023 21:37:40 +0000 Received: by outflank-mailman (input) for mailman id 575646; Wed, 02 Aug 2023 21:37:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJSQ-0003Og-JX for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:32:38 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18eeff17-317c-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:32:36 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LWPL5008540 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:32:31 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LWPo4008539; Wed, 2 Aug 2023 14:32:25 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18eeff17-317c-11ee-8613-37d641c3527e Message-Id: <6452c9eae533fbed7e156f71f53045fe7438174b.1690990428.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Wed, 26 Jul 2023 14:22:14 -0700 Subject: [PATCH 19/22] tools/utils: add pointer to in-progress settings to CfgParseContext X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com Rather than needing the full structure, for many operations the settings pointer is enough. Signed-off-by: Elliott Mitchell --- tools/libs/util/libxlu_cfg.c | 13 ++++++++----- tools/libs/util/libxlu_cfg_y.y | 1 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 91e056bb33..3c0703f9df 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -67,10 +67,13 @@ XLU_Config *xlu_cfg_init(FILE *report, const char *report_source) { return cfg; } -static int ctx_prep(CfgParseContext *ctx, XLU_Config *cfg) { +static int ctx_prep(CfgParseContext *ctx, XLU_Config *cfg, + XLU_ConfigSetting **psettings) +{ int e; ctx->cfg= cfg; + ctx->psettings = psettings; ctx->err= 0; ctx->lexerrlineno= -1; ctx->likely_python= 0; @@ -112,7 +115,7 @@ int xlu_cfg_readfile(XLU_Config *cfg, const char *real_filename) { int e; CfgParseContext ctx; - e = ctx_prep(&ctx, cfg); + e = ctx_prep(&ctx, cfg, &cfg->settings); if (e) { ctx.err= e; goto xe; } f= fopen(real_filename, "r"); @@ -139,7 +142,7 @@ int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length) { YY_BUFFER_STATE buf= 0; CfgParseContext ctx; - e= ctx_prep(&ctx, cfg); + e = ctx_prep(&ctx, cfg, &cfg->settings); if (e) { ctx.err= e; goto xe; } buf = xlu__cfg_yy_scan_bytes(data, length, ctx.scanner); @@ -619,8 +622,8 @@ void xlu__cfg_set_store(CfgParseContext *ctx, char *name, set->value = val; set->op = op; set->lineno= lineno; - set->next= ctx->cfg->settings; - ctx->cfg->settings= set; + set->next = *ctx->psettings; + *ctx->psettings = set; return; out: assert(ctx->err); diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index 5c7e31222d..5bd4cbb0ab 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -21,6 +21,7 @@ typedef struct { XLU_Config *cfg; + XLU_ConfigSetting **psettings; int err, lexerrlineno, likely_python; void *scanner; } CfgParseContext; -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:37:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:37:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575654.901266 (Exim 4.92) (envelope-from ) id 1qRJXK-00070e-64; Wed, 02 Aug 2023 21:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575654.901266; Wed, 02 Aug 2023 21:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJXK-00070T-2D; Wed, 02 Aug 2023 21:37:42 +0000 Received: by outflank-mailman (input) for mailman id 575654; Wed, 02 Aug 2023 21:37:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJNK-0004vP-G1 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:27:22 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d25a01e-317b-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:27:21 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LRCsJ008463 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:27:18 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LRCav008462; Wed, 2 Aug 2023 14:27:12 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d25a01e-317b-11ee-b263-6b7b168915f2 Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 18 Jul 2023 23:07:20 -0700 Subject: [PATCH 13/22] tools/utils: move XLU_ConfigList to libxl_cfg.c X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com With XLU_ConfigValue now in libxlu_cfg.c, XLU_ConfigList can follow. Fixes: 1a09c5113a ("libxlu: rework internal representation of setting") Signed-off-by: Elliott Mitchell --- Placing XLU_ConfigValue/XLU_ConfigList in libxlu_internal.h was certainly *wrong*. --- tools/libs/util/libxlu_cfg.c | 6 ++++++ tools/libs/util/libxlu_internal.h | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index d3b5c86ed6..67d1a8123f 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -31,6 +31,12 @@ struct XLU_ConfigSetting { int lineno; }; +struct XLU_ConfigList { + int avalues; /* available slots */ + int nvalues; /* actual occupied slots */ + XLU_ConfigValue **values; +}; + struct XLU_ConfigValue { enum XLU_ConfigValueType type; union { diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index c68669c3a1..310e2145a7 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -25,12 +25,6 @@ #include "libxlutil.h" -struct XLU_ConfigList { - int avalues; /* available slots */ - int nvalues; /* actual occupied slots */ - XLU_ConfigValue **values; -}; - typedef struct XLU_ConfigSetting XLU_ConfigSetting; struct XLU_Config { -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:37:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:37:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575686.901276 (Exim 4.92) (envelope-from ) id 1qRJXQ-0007Uu-Em; Wed, 02 Aug 2023 21:37:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575686.901276; Wed, 02 Aug 2023 21:37:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJXQ-0007Un-B4; Wed, 02 Aug 2023 21:37:48 +0000 Received: by outflank-mailman (input) for mailman id 575686; Wed, 02 Aug 2023 21:37:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJPq-0002A0-N2 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:29:58 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba56475f-317b-11ee-b263-6b7b168915f2; Wed, 02 Aug 2023 23:29:58 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LTmp6008512 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:29:54 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LTm1g008511; Wed, 2 Aug 2023 14:29:48 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba56475f-317b-11ee-b263-6b7b168915f2 Message-Id: In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Sun, 9 Jul 2023 16:06:30 -0700 Subject: [PATCH 16/22] tools/utils: move XLU_Operation to libxlu_cfg_y.h X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com This enumerated value is never used outside of the lowest layer of the configuration parser. As such, move to the internal header. Fixes: a30910bfd7 ("libxlu: Handle += in config files") Signed-off-by: Elliott Mitchell --- I'm unsure whether this is fixing a30910bfd7. Placing XLU_Operation in libxlutil.h was certainly erroneous, but it is quite unlikely to directly result in actual bugs. --- tools/include/libxlutil.h | 5 ----- tools/libs/util/libxlu_cfg_y.y | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/include/libxlutil.h b/tools/include/libxlutil.h index 0ce66c2096..de57ca4200 100644 --- a/tools/include/libxlutil.h +++ b/tools/include/libxlutil.h @@ -25,11 +25,6 @@ enum XLU_ConfigValueType { XLU_LIST, }; -enum XLU_Operation { - XLU_OP_ASSIGNMENT = 0, - XLU_OP_ADDITION, -}; - /* Unless otherwise stated, all functions return an errno value. */ typedef struct XLU_Config XLU_Config; typedef struct XLU_ConfigList XLU_ConfigList; diff --git a/tools/libs/util/libxlu_cfg_y.y b/tools/libs/util/libxlu_cfg_y.y index 75e7140478..5dfb06941a 100644 --- a/tools/libs/util/libxlu_cfg_y.y +++ b/tools/libs/util/libxlu_cfg_y.y @@ -27,6 +27,11 @@ typedef struct { } %code provides { +enum XLU_Operation { + XLU_OP_ASSIGNMENT = 0, + XLU_OP_ADDITION, +}; + void xlu__cfg_set_free(XLU_ConfigSetting *set); void xlu__cfg_set_store(CfgParseContext*, char *name, enum XLU_Operation op, -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:37:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:37:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575692.901286 (Exim 4.92) (envelope-from ) id 1qRJXR-0007l5-Pa; Wed, 02 Aug 2023 21:37:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575692.901286; Wed, 02 Aug 2023 21:37:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJXR-0007kW-Iz; Wed, 02 Aug 2023 21:37:49 +0000 Received: by outflank-mailman (input) for mailman id 575692; Wed, 02 Aug 2023 21:37:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJTE-0003Og-So for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:33:28 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36f5476d-317c-11ee-8613-37d641c3527e; Wed, 02 Aug 2023 23:33:27 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 372LXHYp008558 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 2 Aug 2023 17:33:23 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 372LXHcA008557; Wed, 2 Aug 2023 14:33:17 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36f5476d-317c-11ee-8613-37d641c3527e Message-Id: <52d5a8411767aa17ce0db845471ad38dd49f6594.1690990428.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Tue, 25 Jul 2023 20:26:48 -0700 Subject: [PATCH 20/22] tools/utils: add wrapper for readfile()/readdata() functions X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com These functions needs to cross the boundary between core and lower-layer. As such split them in two. Pass most of the values from XLU_Config as they can be used by the lower-layer. Signed-off-by: Elliott Mitchell --- tools/libs/util/libxlu_cfg.c | 47 ++++++++++++++++++++++--------- tools/libs/util/libxlu_internal.h | 6 ++++ 2 files changed, 39 insertions(+), 14 deletions(-) diff --git a/tools/libs/util/libxlu_cfg.c b/tools/libs/util/libxlu_cfg.c index 3c0703f9df..cb99b0aab0 100644 --- a/tools/libs/util/libxlu_cfg.c +++ b/tools/libs/util/libxlu_cfg.c @@ -110,39 +110,58 @@ static void parse(CfgParseContext *ctx) { } } -int xlu_cfg_readfile(XLU_Config *cfg, const char *real_filename) { - FILE *f = 0; +int xlu_cfg_readfile(XLU_Config *cfg, const char *name) +{ + FILE *file; + int ret; + + file = fopen(name, "r"); + if (file) { + ret = xlu__cfg_readfile(cfg, cfg->report, cfg->config_source, + &cfg->settings, file, name); + fclose(file); + } else { + ret = errno; + fprintf(cfg->report,"%s: unable to open configuration file: %s\n", + name, strerror(ret)); + } + + return ret; +} + +int xlu__cfg_readfile(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, + XLU_ConfigSetting **psettings, FILE *f, const char *name) +{ int e; CfgParseContext ctx; - e = ctx_prep(&ctx, cfg, &cfg->settings); + e = ctx_prep(&ctx, cfg, psettings); if (e) { ctx.err= e; goto xe; } - f= fopen(real_filename, "r"); - if (!f) { - ctx.err = errno; - fprintf(cfg->report,"%s: unable to open configuration file: %s\n", - real_filename, strerror(e)); - goto xe; - } - xlu__cfg_yyrestart(f, ctx.scanner); parse(&ctx); xe: ctx_dispose(&ctx); - if (f) fclose(f); return ctx.err; } -int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length) { +int xlu_cfg_readdata(XLU_Config *cfg, const char *data, int length) +{ + return xlu__cfg_readdata(cfg, cfg->report, cfg->config_source, + &cfg->settings, data, length); +} + +int xlu__cfg_readdata(XLU_Config *cfg, FILE *msgfile, const char *msgprefix, + XLU_ConfigSetting **psettings, const char *data, int length) +{ int e; YY_BUFFER_STATE buf= 0; CfgParseContext ctx; - e = ctx_prep(&ctx, cfg, &cfg->settings); + e = ctx_prep(&ctx, cfg, psettings); if (e) { ctx.err= e; goto xe; } buf = xlu__cfg_yy_scan_bytes(data, length, ctx.scanner); diff --git a/tools/libs/util/libxlu_internal.h b/tools/libs/util/libxlu_internal.h index cc98efba27..34c6c7a443 100644 --- a/tools/libs/util/libxlu_internal.h +++ b/tools/libs/util/libxlu_internal.h @@ -39,6 +39,12 @@ extern int xlu_cfg_printf(const XLU_Config *cfg, const char *format, ...) * Internals for file parser *only*, NOT to be used by other parsing/lexing */ extern void xlu__cfg_set_free(XLU_ConfigSetting *set); +extern int xlu__cfg_readfile(XLU_Config *cfg, FILE *msgfile, + const char *msgprefix, XLU_ConfigSetting **psettings, FILE *file, + const char *name); +extern int xlu__cfg_readdata(XLU_Config *cfg, FILE *msgfile, + const char *msgprefix, XLU_ConfigSetting **psettings, const char *data, + int length); #endif /*LIBXLU_INTERNAL_H*/ -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 21:42:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 21:42:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575765.901299 (Exim 4.92) (envelope-from ) id 1qRJbO-0001tg-Ct; Wed, 02 Aug 2023 21:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575765.901299; Wed, 02 Aug 2023 21:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJbO-0001tY-9v; Wed, 02 Aug 2023 21:41:54 +0000 Received: by outflank-mailman (input) for mailman id 575765; Wed, 02 Aug 2023 21:41:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJbM-0001tQ-OR for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 21:41:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRJbJ-0006Pk-63; Wed, 02 Aug 2023 21:41:49 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRJbJ-00008O-0a; Wed, 02 Aug 2023 21:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=5OX86ePTqckG8JhNv/p3p6t5dZGA691nyQRGEt/NfsA=; b=hr/WJbdyWhsdJYWBE1kkalzft9 QqY2Zu1HkYzlzQw0GH9Wun9VRxIgYGzV6VekX3o7SwDrTWKZe7W82pSZWNWaLreJLXlCR+T8K3QWs L/zkAavB6jnLtkTpV9CoIOGDySLk115EITVY0cVsY6Gnka0dd6NKr1i5FT9N63eXXhNE=; Message-ID: Date: Wed, 2 Aug 2023 22:41:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Jan Beulich , Oleksii Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <6e8f243284b53a9c56e7faf5e0e5ee5e20de9958.1690475512.git.oleksii.kurochko@gmail.com> <98596d8e-6c11-715a-7842-910806abda77@suse.com> <75cd58c00ac6b9f49f1656d6793888ef470c9eff.camel@gmail.com> <9c74b2a2-450c-6932-868f-6109374de6bc@suse.com> From: Julien Grall Subject: Re: [PATCH v4 1/1] ns16550: add support for polling mode when device tree is used In-Reply-To: <9c74b2a2-450c-6932-868f-6109374de6bc@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 01/08/2023 10:59, Jan Beulich wrote: > On 01.08.2023 11:46, Oleksii wrote: >> On Mon, 2023-07-31 at 15:24 +0200, Jan Beulich wrote: >>> On 27.07.2023 18:45, Oleksii Kurochko wrote: >>>> @@ -654,6 +674,9 @@ static void ns16550_init_common(struct ns16550 >>>> *uart) >>>> >>>>      /* Default lsr_mask = UART_LSR_THRE */ >>>>      uart->lsr_mask  = UART_LSR_THRE; >>>> + >>>> +    if ( strstr(opt_com1, "poll") || strstr(opt_com2, "poll") ) >>>> +        uart->intr_works = polling; >>>>  } >>> >>> A non-__init function may not reference __initdata objects. But >>> strstr() >>> is too lax anyway, and you also shouldn't check the wrong port's >>> options. >>> You want to recognize "poll" _only_ where all other command line >>> options >>> are processed. >> Just to confirm, do you mean that I should use parse_positional() ( or >> something similar ) for the device-tree method of initializing ns16550? >> >> I checked the polling behavior as described above because >> parse_positional() is utilized solely for X86. >> >> It appears that command line options are parsed only in the case of >> x86. > > Hmm, looks like you're right. Arm folks will want to clarify how they > got away without any command line overrides so far, So far, everything we needed was described in the firmware table (e.g. ACPI/Device-Tree). > and how they think > now necessary ones should be suitably added. I think "poll" is the only parameter that we should parse on Arm. > I recall I had reservations > when the file was massaged to compile out supposedly x86-only code. I had a look at the code protected by CONFIG_X86. Most of it still want to be configured behind CONFIG_X86 at least until we have PCI support. But even with it, some work would be necessary to be able to support PCI UART. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 02 22:45:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 22:45:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575852.901315 (Exim 4.92) (envelope-from ) id 1qRKax-0008Ut-Ts; Wed, 02 Aug 2023 22:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575852.901315; Wed, 02 Aug 2023 22:45:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKax-0008Ul-Pz; Wed, 02 Aug 2023 22:45:31 +0000 Received: by outflank-mailman (input) for mailman id 575852; Wed, 02 Aug 2023 22:45:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKaw-0008UW-Eh; Wed, 02 Aug 2023 22:45:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKaw-0007pC-5i; Wed, 02 Aug 2023 22:45:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKav-0007ns-PW; Wed, 02 Aug 2023 22:45:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRKav-0001k2-P4; Wed, 02 Aug 2023 22:45:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dtpdOLMdwIw1aVyiLg57UyL0gyKJccIffeEQrfyzOOc=; b=iKfkc/8YMzZhrRHaSglGpmkZI1 PbbpM5p2XD5c2p2iso2MpFU42bJF+syCnvlNRjadixq9siyGQtLK4SGJtOLpz39IgT/dWOI0zGkzZ k5RwREjL9g7eCn2XCQUu+YF8fR5IDqVLZu56QoU0xqzTAT6FM4LaYvZu2cmNb7BHBzCM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182101: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start.2:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start.2:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-saverestore:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl:host-ping-check-xen:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:xen-boot:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5d0c230f1de8c7515b6567d9afba1f196fb4e2f4 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Wed, 02 Aug 2023 22:45:29 +0000 flight 182101 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182101/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 14 guest-start fail in 182087 pass in 182101 test-amd64-amd64-xl-qemuu-ovmf-amd64 21 guest-start.2 fail in 182087 pass in 182101 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail pass in 182087 test-amd64-amd64-xl-shadow 8 xen-boot fail pass in 182087 test-amd64-amd64-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 182087 test-amd64-amd64-dom0pvh-xl-amd 23 guest-start.2 fail pass in 182087 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 15 guest-saverestore fail pass in 182087 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 182087 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail pass in 182087 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 10 host-ping-check-xen fail blocked in 180278 test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 182087 blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail in 182087 like 180278 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 182087 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 182087 never pass test-armhf-armhf-xl 15 migrate-support-check fail in 182087 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 182087 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 182087 never pass test-armhf-armhf-xl-rtds 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-armhf-armhf-libvirt-raw 8 xen-boot fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 5d0c230f1de8c7515b6567d9afba1f196fb4e2f4 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 108 days Failing since 180281 2023-04-17 06:24:36 Z 107 days 197 attempts Testing same since 182083 2023-07-31 00:41:50 Z 2 days 3 attempts ------------------------------------------------------------ 3874 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 651356 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575859.901327 (Exim 4.92) (envelope-from ) id 1qRKsE-0002Xy-6Y; Wed, 02 Aug 2023 23:03:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575859.901327; Wed, 02 Aug 2023 23:03:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsE-0002Xr-3u; Wed, 02 Aug 2023 23:03:22 +0000 Received: by outflank-mailman (input) for mailman id 575859; Wed, 02 Aug 2023 23:03:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsC-0002Xg-Vq for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:21 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c461511c-3188-11ee-b265-6b7b168915f2; Thu, 03 Aug 2023 01:03:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 20C018285570; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id L50En6x9HQe5; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id D5AB982853DD; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2FNVpzo_oeqE; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 694448285570; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c461511c-3188-11ee-b265-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com D5AB982853DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017395; bh=E+ZWgBHexIIC5drESkxQIt9+akyKQK9mOXv/LPhfb4Q=; h=From:To:Date:Message-Id:MIME-Version; b=pjB+X0hSerN2rUHKxTcnAfmizRMpvZMhGE7AQBDKKqHFNnbg/6czAiGEOl41rxIxT FrrVzUYoUnLeYvKKS8KubPQxSIBYqxhnrISMfeT9cCCyCKH/QaQ6tKQCnVcQeA2zPB TC/YoWujZn/nJ6ATFkINIV7dx0rvwFYYeoRmG810= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 1/9] xen/common: Add missing #includes treewide Date: Wed, 2 Aug 2023 18:02:57 -0500 Message-Id: <2c9eb4fc175a1bdd21293f2e2611d8e21991636d.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable A few files treewide depend on defininitions in headers that they don't include. This works when arch headers end up including the required headers by chance, but broke on ppc64 with only minimal/stub arch headers. Signed-off-by: Shawn Anastasio --- xen/common/memory.c | 1 + xen/common/symbols.c | 1 + xen/common/xmalloc_tlsf.c | 1 + xen/include/xen/domain.h | 1 + xen/include/xen/iommu.h | 1 + xen/include/xen/sched.h | 1 + 6 files changed, 6 insertions(+) diff --git a/xen/common/memory.c b/xen/common/memory.c index c206fa4808..1b185b00e4 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include =20 diff --git a/xen/common/symbols.c b/xen/common/symbols.c index 9377f41424..691e617925 100644 --- a/xen/common/symbols.c +++ b/xen/common/symbols.c @@ -19,6 +19,7 @@ #include #include #include +#include =20 #ifdef SYMBOLS_ORIGIN extern const unsigned int symbols_offsets[]; diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c index c603c39bb9..349b31cb4c 100644 --- a/xen/common/xmalloc_tlsf.c +++ b/xen/common/xmalloc_tlsf.c @@ -27,6 +27,7 @@ #include #include #include +#include =20 #define MAX_POOL_NAME_LEN 16 =20 diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index d35af34841..767127b440 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -4,6 +4,7 @@ =20 #include =20 +#include #include #include #include diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 405db59971..ef817efec9 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 854f3e32c0..6a96534a45 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575860.901338 (Exim 4.92) (envelope-from ) id 1qRKsF-0002mr-D3; Wed, 02 Aug 2023 23:03:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575860.901338; Wed, 02 Aug 2023 23:03:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsF-0002mk-AG; Wed, 02 Aug 2023 23:03:23 +0000 Received: by outflank-mailman (input) for mailman id 575860; Wed, 02 Aug 2023 23:03:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsD-0002Xg-KX for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:21 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c461f0e5-3188-11ee-b265-6b7b168915f2; Thu, 03 Aug 2023 01:03:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id CCB3382867D6; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 89gNs2vIgyAc; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 858D082854B3; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fUmWstjzii5g; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 0975682853DD; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c461f0e5-3188-11ee-b265-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 858D082854B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017395; bh=tcDUbXvor3Abx3L0/suO4KclBQRdywXt5N4X3WqZUt8=; h=From:To:Date:Message-Id:MIME-Version; b=ZcdhIBKkTIX0iC2GYS9WP2stox3fAcZx7VzpECgVJap6ytyLcaZeMxS1rtOGiPlwX vpQF/5Y43ijsrJGHSaxOMCfeMb2U2PE+d4y/um5KQ76lrPL5hTkAKV4JROdbDHSo9f 4mVsygeluQw2zSrRAv7QdrW2YkFAX2k2TanbLAcw= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 0/9] ppc: Enable full Xen build Date: Wed, 2 Aug 2023 18:02:56 -0500 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hello all, This patch series performs all of the additions necessary to drop the build overrides for PPC and enable the full Xen build. Except in cases where compatibile implementations already exist (e.g. atomic.h and bitops.h), the newly added definitions are simple, unimplemented stubs that just call BUG(). A few miscellaneous changes were also made to non-ppc code as well, namely a few missing header fixes as well as an ARM-ism in the ns16550 driver. Thanks, Shawn Shawn Anastasio (9): xen/common: Add missing #includes treewide xen/ppc: Add public/arch-ppc.h xen/ppc: Implement atomic.h xen/ppc: Implement bitops.h xen/ppc: Define minimal stub headers required for full build ns16550: Guard accesses to `vuart` field by CONFIG_ARM xen/ppc: Define bug frames table in linker script xen/ppc: Add stub function and symbol definitions xen/ppc: Enable full Xen build xen/arch/ppc/Kconfig | 1 + xen/arch/ppc/Makefile | 17 +- xen/arch/ppc/arch.mk | 3 - xen/arch/ppc/include/asm/altp2m.h | 39 +++ xen/arch/ppc/include/asm/atomic.h | 387 +++++++++++++++++++++++ xen/arch/ppc/include/asm/bitops.h | 331 ++++++++++++++++++- xen/arch/ppc/include/asm/bug.h | 7 + xen/arch/ppc/include/asm/cache.h | 2 + xen/arch/ppc/include/asm/config.h | 9 + xen/arch/ppc/include/asm/cpufeature.h | 9 + xen/arch/ppc/include/asm/current.h | 42 +++ xen/arch/ppc/include/asm/delay.h | 11 + xen/arch/ppc/include/asm/desc.h | 0 xen/arch/ppc/include/asm/device.h | 53 ++++ xen/arch/ppc/include/asm/div64.h | 14 + xen/arch/ppc/include/asm/domain.h | 46 +++ xen/arch/ppc/include/asm/event.h | 35 ++ xen/arch/ppc/include/asm/flushtlb.h | 23 ++ xen/arch/ppc/include/asm/grant_table.h | 0 xen/arch/ppc/include/asm/guest_access.h | 54 ++++ xen/arch/ppc/include/asm/guest_atomics.h | 14 + xen/arch/ppc/include/asm/hardirq.h | 18 ++ xen/arch/ppc/include/asm/hypercall.h | 0 xen/arch/ppc/include/asm/io.h | 15 + xen/arch/ppc/include/asm/iocap.h | 7 + xen/arch/ppc/include/asm/iommu.h | 7 + xen/arch/ppc/include/asm/irq.h | 32 ++ xen/arch/ppc/include/asm/mem_access.h | 0 xen/arch/ppc/include/asm/memory.h | 34 ++ xen/arch/ppc/include/asm/mm.h | 255 ++++++++++++++- xen/arch/ppc/include/asm/monitor.h | 48 +++ xen/arch/ppc/include/asm/nospec.h | 18 ++ xen/arch/ppc/include/asm/numa.h | 26 ++ xen/arch/ppc/include/asm/p2m.h | 105 ++++++ xen/arch/ppc/include/asm/page.h | 19 ++ xen/arch/ppc/include/asm/paging.h | 7 + xen/arch/ppc/include/asm/pci.h | 7 + xen/arch/ppc/include/asm/percpu.h | 26 ++ xen/arch/ppc/include/asm/procarea.h | 38 +++ xen/arch/ppc/include/asm/processor.h | 6 + xen/arch/ppc/include/asm/random.h | 9 + xen/arch/ppc/include/asm/regs.h | 2 + xen/arch/ppc/include/asm/setup.h | 6 + xen/arch/ppc/include/asm/smp.h | 18 ++ xen/arch/ppc/include/asm/softirq.h | 8 + xen/arch/ppc/include/asm/spinlock.h | 15 + xen/arch/ppc/include/asm/system.h | 243 +++++++++++++- xen/arch/ppc/include/asm/time.h | 20 ++ xen/arch/ppc/include/asm/vm_event.h | 49 +++ xen/arch/ppc/include/asm/xenoprof.h | 0 xen/arch/ppc/mm-radix.c | 46 ++- xen/arch/ppc/opal.c | 2 - xen/arch/ppc/setup.c | 10 +- xen/arch/ppc/stubs.c | 351 ++++++++++++++++++++ xen/arch/ppc/tlb-radix.c | 2 +- xen/arch/ppc/xen.lds.S | 10 + xen/common/memory.c | 1 + xen/common/symbols.c | 1 + xen/common/xmalloc_tlsf.c | 1 + xen/drivers/char/ns16550.c | 2 + xen/include/public/arch-ppc.h | 140 ++++++++ xen/include/public/hvm/save.h | 2 + xen/include/public/pmu.h | 2 + xen/include/public/xen.h | 2 + xen/include/xen/domain.h | 1 + xen/include/xen/iommu.h | 1 + xen/include/xen/sched.h | 1 + 67 files changed, 2693 insertions(+), 17 deletions(-) create mode 100644 xen/arch/ppc/include/asm/altp2m.h create mode 100644 xen/arch/ppc/include/asm/atomic.h create mode 100644 xen/arch/ppc/include/asm/cpufeature.h create mode 100644 xen/arch/ppc/include/asm/current.h create mode 100644 xen/arch/ppc/include/asm/delay.h create mode 100644 xen/arch/ppc/include/asm/desc.h create mode 100644 xen/arch/ppc/include/asm/device.h create mode 100644 xen/arch/ppc/include/asm/div64.h create mode 100644 xen/arch/ppc/include/asm/domain.h create mode 100644 xen/arch/ppc/include/asm/event.h create mode 100644 xen/arch/ppc/include/asm/flushtlb.h create mode 100644 xen/arch/ppc/include/asm/grant_table.h create mode 100644 xen/arch/ppc/include/asm/guest_access.h create mode 100644 xen/arch/ppc/include/asm/guest_atomics.h create mode 100644 xen/arch/ppc/include/asm/hardirq.h create mode 100644 xen/arch/ppc/include/asm/hypercall.h create mode 100644 xen/arch/ppc/include/asm/io.h create mode 100644 xen/arch/ppc/include/asm/iocap.h create mode 100644 xen/arch/ppc/include/asm/iommu.h create mode 100644 xen/arch/ppc/include/asm/irq.h create mode 100644 xen/arch/ppc/include/asm/mem_access.h create mode 100644 xen/arch/ppc/include/asm/memory.h create mode 100644 xen/arch/ppc/include/asm/monitor.h create mode 100644 xen/arch/ppc/include/asm/nospec.h create mode 100644 xen/arch/ppc/include/asm/numa.h create mode 100644 xen/arch/ppc/include/asm/p2m.h create mode 100644 xen/arch/ppc/include/asm/paging.h create mode 100644 xen/arch/ppc/include/asm/pci.h create mode 100644 xen/arch/ppc/include/asm/percpu.h create mode 100644 xen/arch/ppc/include/asm/procarea.h create mode 100644 xen/arch/ppc/include/asm/random.h create mode 100644 xen/arch/ppc/include/asm/setup.h create mode 100644 xen/arch/ppc/include/asm/smp.h create mode 100644 xen/arch/ppc/include/asm/softirq.h create mode 100644 xen/arch/ppc/include/asm/spinlock.h create mode 100644 xen/arch/ppc/include/asm/time.h create mode 100644 xen/arch/ppc/include/asm/vm_event.h create mode 100644 xen/arch/ppc/include/asm/xenoprof.h create mode 100644 xen/arch/ppc/stubs.c create mode 100644 xen/include/public/arch-ppc.h -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575864.901373 (Exim 4.92) (envelope-from ) id 1qRKsI-0003ZY-29; Wed, 02 Aug 2023 23:03:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575864.901373; Wed, 02 Aug 2023 23:03:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsH-0003Yp-SX; Wed, 02 Aug 2023 23:03:25 +0000 Received: by outflank-mailman (input) for mailman id 575864; Wed, 02 Aug 2023 23:03:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsF-0002Xg-L9 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:23 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6497382-3188-11ee-b265-6b7b168915f2; Thu, 03 Aug 2023 01:03:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 7F86B82867D6; Wed, 2 Aug 2023 18:03:20 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 5_ulkB8bEAwK; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 18B8682853DD; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PKJPQVnVlc8g; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id A87368286988; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6497382-3188-11ee-b265-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 18B8682853DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017399; bh=1Z3BHp5C4S6qyWtJBZVL9zKOQ4J/V94ak8r3E6OfMhE=; h=From:To:Date:Message-Id:MIME-Version; b=OxSSE0AbnR2XSjQTFUqjkz660FTxvImjkTr0IhY5FmyQTiHcq2I12bHlbSICfLs8u qISW10KsmeJ5MHH9muogX6u82BMmVh0MMDKfGBlpEtP1MCgDHNqrUNb39a24/nWMyv hMyXh8BPQfu7Xbc0/7iaPfVYwpnqTkuuuTePSHO0= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions Date: Wed, 2 Aug 2023 18:03:04 -0500 Message-Id: <2702cfa486aa92e82fccd6393519073f10f4c40c.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Add stub function and symbol definitions required by common code. If the file that the definition is supposed to be located in doesn't already exist yet, temporarily place its definition in the new stubs.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile | 1 + xen/arch/ppc/mm-radix.c | 44 +++++ xen/arch/ppc/setup.c | 10 +- xen/arch/ppc/stubs.c | 351 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 404 insertions(+), 2 deletions(-) create mode 100644 xen/arch/ppc/stubs.c diff --git a/xen/arch/ppc/Makefile b/xen/arch/ppc/Makefile index a059ac4c0a..969910b3b6 100644 --- a/xen/arch/ppc/Makefile +++ b/xen/arch/ppc/Makefile @@ -5,6 +5,7 @@ obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.init.o obj-y +=3D mm-radix.o obj-y +=3D opal.o obj-y +=3D setup.o +obj-y +=3D stubs.o obj-y +=3D tlb-radix.o =20 $(TARGET): $(TARGET)-syms diff --git a/xen/arch/ppc/mm-radix.c b/xen/arch/ppc/mm-radix.c index 399898a36d..1ed6897366 100644 --- a/xen/arch/ppc/mm-radix.c +++ b/xen/arch/ppc/mm-radix.c @@ -266,3 +266,47 @@ void __init setup_initial_pagetables(void) /* Turn on the MMU */ enable_mmu(); } + + +/* + * TODO: Implement the functions below + */ +unsigned long total_pages; +unsigned long frametable_base_pdx __read_mostly; + +void put_page(struct page_info *p) +{ + BUG(); +} + +void arch_dump_shared_mem_info(void) +{ + BUG(); +} + +int xenmem_add_to_physmap_one(struct domain *d, + unsigned int space, + union add_to_physmap_extra extra, + unsigned long idx, + gfn_t gfn) +{ + BUG(); +} + +int destroy_xen_mappings(unsigned long s, unsigned long e) +{ + BUG(); +} + +int map_pages_to_xen(unsigned long virt, + mfn_t mfn, + unsigned long nr_mfns, + unsigned int flags) +{ + BUG(); +} + +int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) +{ + BUG(); +} diff --git a/xen/arch/ppc/setup.c b/xen/arch/ppc/setup.c index 466993987b..06c0a5fa80 100644 --- a/xen/arch/ppc/setup.c +++ b/xen/arch/ppc/setup.c @@ -1,5 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include #include +#include +#include #include #include #include @@ -7,8 +10,6 @@ /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZ= E); =20 -void __init setup_initial_pagetables(void); - void __init noreturn start_xen(unsigned long r3, unsigned long r4, unsigned long r5, unsigned long r6, unsigned long r7) @@ -39,3 +40,8 @@ void __init noreturn start_xen(unsigned long r3, unsign= ed long r4, =20 unreachable(); } + +void arch_get_xen_caps(xen_capabilities_info_t *info) +{ + BUG(); +} diff --git a/xen/arch/ppc/stubs.c b/xen/arch/ppc/stubs.c new file mode 100644 index 0000000000..2b3ee94115 --- /dev/null +++ b/xen/arch/ppc/stubs.c @@ -0,0 +1,351 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#include +#include +#include +#include +#include +#include +#include + +#include + +/* smpboot.c */ + +cpumask_t cpu_online_map; +cpumask_t cpu_present_map; +cpumask_t cpu_possible_map; + +/* ID of the PCPU we're running on */ +DEFINE_PER_CPU(unsigned int, cpu_id); +/* XXX these seem awfully x86ish... */ +/* representing HT siblings of each logical CPU */ +DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_sibling_mask); +/* representing HT and core siblings of each logical CPU */ +DEFINE_PER_CPU_READ_MOSTLY(cpumask_var_t, cpu_core_mask); + +nodemask_t __read_mostly node_online_map =3D { { [0] =3D 1UL } }; + +/* time.c */ + +s_time_t get_s_time(void) +{ + BUG(); +} + +int reprogram_timer(s_time_t timeout) +{ + BUG(); +} + +void send_timer_event(struct vcpu *v) +{ + BUG(); +} + +/* traps.c */ + +void show_execution_state(const struct cpu_user_regs *regs) +{ + BUG(); +} + +void arch_hypercall_tasklet_result(struct vcpu *v, long res) +{ + BUG(); +} + +void vcpu_show_execution_state(struct vcpu *v) +{ + BUG(); +} + +/* shutdown.c */ + +void machine_restart(unsigned int delay_millisecs) +{ + BUG(); +} + +void machine_halt(void) +{ + BUG(); +} + +/* vm_event.c */ + +void vm_event_fill_regs(vm_event_request_t *req) +{ + BUG(); +} + +void vm_event_set_registers(struct vcpu *v, vm_event_response_t *rsp) +{ + BUG(); +} + +void vm_event_monitor_next_interrupt(struct vcpu *v) +{ + /* Not supported on PPC. */ +} + +/* domctl.c */ +void arch_get_domain_info(const struct domain *d, + struct xen_domctl_getdomaininfo *info) +{ + BUG(); +} + +/* monitor.c */ + +int arch_monitor_domctl_event(struct domain *d, + struct xen_domctl_monitor_op *mop) +{ + BUG(); +} + +/* smp.c */ + +void arch_flush_tlb_mask(const cpumask_t *mask) +{ + BUG(); +} + +void smp_send_event_check_mask(const cpumask_t *mask) +{ + BUG(); +} + +void smp_send_call_function_mask(const cpumask_t *mask) +{ + BUG(); +} + +/* irq.c */ + +struct pirq *alloc_pirq_struct(struct domain *d) +{ + BUG(); +} + +int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, int will_share) +{ + BUG(); +} + +void pirq_guest_unbind(struct domain *d, struct pirq *pirq) +{ + BUG(); +} + +void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask= ) +{ + BUG(); +} + +static void ack_none(struct irq_desc *irq) +{ + BUG(); +} + +static void end_none(struct irq_desc *irq) +{ + BUG(); +} + +hw_irq_controller no_irq_type =3D { + .typename =3D "none", + .startup =3D irq_startup_none, + .shutdown =3D irq_shutdown_none, + .enable =3D irq_enable_none, + .disable =3D irq_disable_none, + .ack =3D ack_none, + .end =3D end_none +}; + +int arch_init_one_irq_desc(struct irq_desc *desc) +{ + BUG(); +} + +void smp_send_state_dump(unsigned int cpu) +{ + BUG(); +} + +/* domain.c */ + +DEFINE_PER_CPU(struct vcpu *, curr_vcpu); +unsigned long __per_cpu_offset[NR_CPUS]; + +void context_switch(struct vcpu *prev, struct vcpu *next) +{ + BUG(); +} + +void continue_running(struct vcpu *same) +{ + BUG(); +} + +void sync_local_execstate(void) +{ + BUG(); +} + +void sync_vcpu_execstate(struct vcpu *v) +{ + BUG(); +} + +void startup_cpu_idle_loop(void) +{ + BUG(); +} + +void free_domain_struct(struct domain *d) +{ + BUG(); +} + +void dump_pageframe_info(struct domain *d) +{ + BUG(); +} + +void free_vcpu_struct(struct vcpu *v) +{ + BUG(); +} + +int arch_vcpu_create(struct vcpu *v) +{ + BUG(); +} + +void arch_vcpu_destroy(struct vcpu *v) +{ + BUG(); +} + +void vcpu_switch_to_aarch64_mode(struct vcpu *v) +{ + BUG(); +} + +int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) +{ + BUG(); +} + +int arch_domain_create(struct domain *d, + struct xen_domctl_createdomain *config, + unsigned int flags) +{ + BUG(); +} + +int arch_domain_teardown(struct domain *d) +{ + BUG(); +} + +void arch_domain_destroy(struct domain *d) +{ + BUG(); +} + +void arch_domain_shutdown(struct domain *d) +{ + BUG(); +} + +void arch_domain_pause(struct domain *d) +{ + BUG(); +} + +void arch_domain_unpause(struct domain *d) +{ + BUG(); +} + +int arch_domain_soft_reset(struct domain *d) +{ + BUG(); +} + +void arch_domain_creation_finished(struct domain *d) +{ + BUG(); +} + +int arch_set_info_guest(struct vcpu *v, vcpu_guest_context_u c) +{ + BUG(); +} + +int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) ar= g) +{ + BUG(); +} + +int arch_vcpu_reset(struct vcpu *v) +{ + BUG(); +} + +int domain_relinquish_resources(struct domain *d) +{ + BUG(); +} + +void arch_dump_domain_info(struct domain *d) +{ + BUG(); +} + +void arch_dump_vcpu_info(struct vcpu *v) +{ + BUG(); +} + +void vcpu_mark_events_pending(struct vcpu *v) +{ + BUG(); +} + +void vcpu_update_evtchn_irq(struct vcpu *v) +{ + BUG(); +} + +void vcpu_block_unless_event_pending(struct vcpu *v) +{ + BUG(); +} + +void vcpu_kick(struct vcpu *v) +{ + BUG(); +} + +struct domain *alloc_domain_struct(void) +{ + BUG(); +} + +struct vcpu *alloc_vcpu_struct(const struct domain *d) +{ + BUG(); +} + +unsigned long +hypercall_create_continuation(unsigned int op, const char *format, ...) +{ + BUG(); +} + +int __init parse_arch_dom0_param(const char *s, const char *e) +{ + BUG(); +} --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575862.901350 (Exim 4.92) (envelope-from ) id 1qRKsG-0002zg-Bm; Wed, 02 Aug 2023 23:03:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575862.901350; Wed, 02 Aug 2023 23:03:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsG-0002y1-4C; Wed, 02 Aug 2023 23:03:24 +0000 Received: by outflank-mailman (input) for mailman id 575862; Wed, 02 Aug 2023 23:03:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsE-0002ha-Vq for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:23 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c52108b4-3188-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 01:03:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 8525C82857CC; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rrykhtEJfngC; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id B5F548285755; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id h0xsFUFCJUW2; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 549648285570; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c52108b4-3188-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com B5F548285755 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017396; bh=lLrkou/Ji/TdfUO/m/EFd+jofhnUCIg/laAuoA5SU4Q=; h=From:To:Date:Message-Id:MIME-Version; b=Vh2PyYIMAFUm+xC0GS7Jt5f0z3KnWMNVFZuA7r8xSv0XD/Dvhd/d5I0xv9QAAM4pv S7EW6eY/okJCgkuN22nMnQHTwkQkRONvfxIQyJnz+Hj91a6oLD/QmSjO5R93Cazxsz EClDd2U0j6w/eUVvAKOZvZV88SdeXiPVMAzSp498= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 3/9] xen/ppc: Implement atomic.h Date: Wed, 2 Aug 2023 18:02:59 -0500 Message-Id: <8035b9659a5930c00802dd36ab52574695d6b419.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Implement atomic.h for PPC, based off of the original Xen 3.2 implementation. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/atomic.h | 387 ++++++++++++++++++++++++++++++ xen/arch/ppc/include/asm/memory.h | 34 +++ 2 files changed, 421 insertions(+) create mode 100644 xen/arch/ppc/include/asm/atomic.h create mode 100644 xen/arch/ppc/include/asm/memory.h diff --git a/xen/arch/ppc/include/asm/atomic.h b/xen/arch/ppc/include/asm= /atomic.h new file mode 100644 index 0000000000..336dedc476 --- /dev/null +++ b/xen/arch/ppc/include/asm/atomic.h @@ -0,0 +1,387 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * PowerPC64 atomic operations + * + * Copyright (C) 2001 Paul Mackerras , IBM + * Copyright (C) 2001 Anton Blanchard , IBM + * Copyright Raptor Engineering LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * as published by the Free Software Foundation; either version + * 2 of the License, or (at your option) any later version. + */ + +#ifndef _ASM_PPC64_ATOMIC_H_ +#define _ASM_PPC64_ATOMIC_H_ + +#include + +#include +#include + +static inline int atomic_read(const atomic_t *v) +{ + return *(volatile int *)&v->counter; +} + +static inline int _atomic_read(atomic_t v) +{ + return v.counter; +} + +static inline void atomic_set(atomic_t *v, int i) +{ + v->counter =3D i; +} + +static inline void _atomic_set(atomic_t *v, int i) +{ + v->counter =3D i; +} + +void __bad_atomic_read(const volatile void *p, void *res); +void __bad_atomic_size(void); + +#define build_atomic_read(name, insn, type) = \ + static inline type name(const volatile type *addr) = \ + { = \ + type ret; = \ + asm volatile ( insn "%U1%X1 %0,%1" : "=3Dr"(ret) : "m<>"(*addr) = ); \ + return ret; = \ + } + +#define build_atomic_write(name, insn, type) = \ + static inline void name(volatile type *addr, type val) = \ + { = \ + asm volatile ( insn "%U0%X0 %1,%0" : "=3Dm<>"(*addr) : "r"(val) = ); \ + } + +#define build_add_sized(name, ldinsn, stinsn, type) = \ + static inline void name(volatile type *addr, type val) = \ + { = \ + type t; = \ + asm volatile ( "1: " ldinsn " %0,0,%3\n" = \ + "add%I2 %0,%0,%2\n" = \ + stinsn " %0,0,%3 \n" = \ + "bne- 1b\n" = \ + : "=3D&r"(t), "+m"(*addr) = \ + : "r"(val), "r"(addr) = \ + : "cc" ); = \ + } + +build_atomic_read(read_u8_atomic, "lbz", uint8_t) +build_atomic_read(read_u16_atomic, "lhz", uint16_t) +build_atomic_read(read_u32_atomic, "lwz", uint32_t) +build_atomic_read(read_u64_atomic, "ldz", uint64_t) + +build_atomic_write(write_u8_atomic, "stb", uint8_t) +build_atomic_write(write_u16_atomic, "sth", uint16_t) +build_atomic_write(write_u32_atomic, "stw", uint32_t) +build_atomic_write(write_u64_atomic, "std", uint64_t) + +build_add_sized(add_u8_sized, "lbarx", "stbcx.",uint8_t) +build_add_sized(add_u16_sized, "lharx", "sthcx.", uint16_t) +build_add_sized(add_u32_sized, "lwarx", "stwcx.", uint32_t) + +#undef build_atomic_read +#undef build_atomic_write +#undef build_add_sized + +static always_inline void read_atomic_size(const volatile void *p, void = *res, + unsigned int size) +{ + ASSERT(IS_ALIGNED((vaddr_t) p, size)); + switch ( size ) + { + case 1: + *(uint8_t *)res =3D read_u8_atomic(p); + break; + case 2: + *(uint16_t *)res =3D read_u16_atomic(p); + break; + case 4: + *(uint32_t *)res =3D read_u32_atomic(p); + break; + case 8: + *(uint64_t *)res =3D read_u64_atomic(p); + break; + default: + __bad_atomic_read(p, res); + break; + } +} + +static always_inline void write_atomic_size(volatile void *p, void *val, + unsigned int size) +{ + ASSERT(IS_ALIGNED((vaddr_t) p, size)); + switch ( size ) + { + case 1: + write_u8_atomic(p, *(uint8_t *)val); + break; + case 2: + write_u16_atomic(p, *(uint16_t *)val); + break; + case 4: + write_u32_atomic(p, *(uint32_t *)val); + break; + case 8: + write_u64_atomic(p, *(uint64_t *)val); + break; + default: + __bad_atomic_size(); + break; + } +} + +#define read_atomic(p) = \ + ({ = \ + union { = \ + typeof(*(p)) val; = \ + char c[0]; = \ + } x_; = \ + read_atomic_size(p, x_.c, sizeof(*(p))); = \ + x_.val; = \ + }) + +#define write_atomic(p, x) = \ + do = \ + { = \ + typeof(*(p)) x_ =3D (x); = \ + write_atomic_size(p, &x_, sizeof(*(p))); = \ + } while ( 0 ) + +#define add_sized(p, x) = \ + ({ = \ + typeof(*(p)) __x =3D (x); = \ + switch ( sizeof(*(p)) ) = \ + { = \ + case 1: = \ + add_u8_sized((uint8_t *) (p), __x); = \ + break; = \ + case 2: = \ + add_u16_sized((uint16_t *) (p), __x); = \ + break; = \ + case 4: = \ + add_u32_sized((uint32_t *) (p), __x); = \ + break; = \ + default: = \ + __bad_atomic_size(); = \ + break; = \ + } = \ + }) + +static inline void atomic_add(int a, atomic_t *v) +{ + int t; + + asm volatile ( "1: lwarx %0,0,%3\n" + "add %0,%2,%0\n" + "stwcx. %0,0,%3\n" + "bne- 1b" + : "=3D&r"(t), "=3Dm"(v->counter) + : "r"(a), "r"(&v->counter), "m"(v->counter) : "cc" ); +} + +static inline int atomic_add_return(int a, atomic_t *v) +{ + int t; + + asm volatile ( PPC_ATOMIC_ENTRY_BARRIER + "1: lwarx %0,0,%2\n" + "add %0,%1,%0\n" + "stwcx. %0,0,%2\n" + "bne- 1b" + PPC_ATOMIC_EXIT_BARRIER + : "=3D&r"(t) + : "r"(a), "r"(&v->counter) + : "cc", "memory" ); + + return t; +} + +static inline void atomic_sub(int a, atomic_t *v) +{ + int t; + + asm volatile ( "1: lwarx %0,0,%3\n" + "subf %0,%2,%0\n" + "stwcx. %0,0,%3\n" + "bne- 1b" + : "=3D&r"(t), "=3Dm"(v->counter) + : "r"(a), "r"(&v->counter), "m"(v->counter) + : "cc" ); +} + +static inline int atomic_sub_return(int a, atomic_t *v) +{ + int t; + + asm volatile ( PPC_ATOMIC_ENTRY_BARRIER + "1: lwarx %0,0,%2\n" + "subf %0,%1,%0\n" + "stwcx. %0,0,%2\n" + "bne- 1b" + PPC_ATOMIC_EXIT_BARRIER + : "=3D&r"(t) + : "r"(a), "r"(&v->counter) + : "cc", "memory" ); + + return t; +} + +static inline void atomic_inc(atomic_t *v) +{ + int t; + + asm volatile ( "1: lwarx %0,0,%2\n" + "addic %0,%0,1\n" + "stwcx. %0,0,%2\n" + "bne- 1b" + : "=3D&r"(t), "=3Dm"(v->counter) + : "r"(&v->counter), "m"(v->counter) + : "cc" ); +} + +static inline int atomic_inc_return(atomic_t *v) +{ + int t; + + asm volatile ( PPC_ATOMIC_ENTRY_BARRIER + "1: lwarx %0,0,%1\n" + "addic %0,%0,1\n" + "stwcx. %0,0,%1\n" + "bne- 1b" + PPC_ATOMIC_EXIT_BARRIER + : "=3D&r"(t) + : "r"(&v->counter) + : "cc", "memory" ); + + return t; +} + +static inline void atomic_dec(atomic_t *v) +{ + int t; + + asm volatile ( "1: lwarx %0,0,%2\n" + "addic %0,%0,-1\n" + "stwcx. %0,0,%2\n" + "bne- 1b" + : "=3D&r"(t), "=3Dm"(v->counter) + : "r"(&v->counter), "m"(v->counter) + : "cc" ); +} + +static inline int atomic_dec_return(atomic_t *v) +{ + int t; + + asm volatile ( PPC_ATOMIC_ENTRY_BARRIER + "1: lwarx %0,0,%1\n" + "addic %0,%0,-1\n" + "stwcx. %0,0,%1\n" + "bne- 1b" + PPC_ATOMIC_EXIT_BARRIER + : "=3D&r"(t) + : "r"(&v->counter) + : "cc", "memory" ); + + return t; +} + +/* + * Atomically test *v and decrement if it is greater than 0. + * The function returns the old value of *v minus 1. + */ +static inline int atomic_dec_if_positive(atomic_t *v) +{ + int t; + + asm volatile(PPC_ATOMIC_ENTRY_BARRIER + "1: lwarx %0,0,%1 # atomic_dec_if_positive= \n" + "addic. %0,%0,-1\n" + "blt- 2f\n" + "stwcx. %0,0,%1\n" + "bne- 1b\n" + PPC_ATOMIC_EXIT_BARRIER + "2:" : "=3D&r"(t) + : "r"(&v->counter) : "cc", "memory"); + + return t; +} + +static inline atomic_t atomic_compareandswap(atomic_t old, atomic_t new, + atomic_t *v) +{ + atomic_t rc; + rc.counter =3D __cmpxchg(&v->counter, old.counter, new.counter, size= of(int)); + return rc; +} + +#define arch_cmpxchg(ptr, o, n) = \ + ({ = \ + __typeof__(*(ptr)) _o_ =3D (o); = \ + __typeof__(*(ptr)) _n_ =3D (n); = \ + (__typeof__(*(ptr))) __cmpxchg((ptr), (unsigned long) _o_, = \ + (unsigned long) _n_, sizeof(*(ptr= ))); \ + }) + +static inline int atomic_cmpxchg(atomic_t *v, int old, int new) +{ + return arch_cmpxchg(&v->counter, old, new); +} + +#define ATOMIC_OP(op, insn, suffix, sign) \ + static inline void atomic_##op(int a, atomic_t *v) = \ + { = \ + int t; = \ + asm volatile ( "1: lwarx %0,0,%3\n" = \ + insn "%I2" suffix " %0,%0,%2\n" = \ + "stwcx. %0,0,%3 \n" = \ + "bne- 1b\n" = \ + : "=3D&r"(t), "+m"(v->counter) = \ + : "r" #sign(a), "r"(&v->counter) = \ + : "cc" ); = \ + } + +ATOMIC_OP(and, "and", ".", K) + +static inline int atomic_sub_and_test(int i, atomic_t *v) +{ + return atomic_sub_return(i, v) =3D=3D 0; +} + +static inline int atomic_inc_and_test(atomic_t *v) +{ + return atomic_add_return(1, v) =3D=3D 0; +} + +static inline int atomic_dec_and_test(atomic_t *v) +{ + return atomic_sub_return(1, v) =3D=3D 0; +} + +static inline int atomic_add_negative(int i, atomic_t *v) +{ + return atomic_add_return(i, v) < 0; +} + +static inline int __atomic_add_unless(atomic_t *v, int a, int u) +{ + int c, old; + + c =3D atomic_read(v); + while (c !=3D u && (old =3D atomic_cmpxchg((v), c, c + a)) !=3D c) + c =3D old; + return c; +} + +static inline int atomic_add_unless(atomic_t *v, int a, int u) +{ + return __atomic_add_unless(v, a, u); +} + +#endif /* _ASM_PPC64_ATOMIC_H_ */ diff --git a/xen/arch/ppc/include/asm/memory.h b/xen/arch/ppc/include/asm= /memory.h new file mode 100644 index 0000000000..7b12e01b1a --- /dev/null +++ b/xen/arch/ppc/include/asm/memory.h @@ -0,0 +1,34 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, = USA. + * + * Copyright (C) IBM Corp. 2005 + * + * Authors: Jimi Xenidis + */ + +#ifndef _ASM_MEMORY_H_ +#define _ASM_MEMORY_H_ + +#include + +#ifdef CONFIG_SMP +#define PPC_ATOMIC_ENTRY_BARRIER "sync\n" +#define PPC_ATOMIC_EXIT_BARRIER "sync\n" +#else +#define PPC_ATOMIC_ENTRY_BARRIER +#define PPC_ATOMIC_EXIT_BARRIER +#endif + +#endif --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575863.901368 (Exim 4.92) (envelope-from ) id 1qRKsH-0003Ws-NH; Wed, 02 Aug 2023 23:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575863.901368; Wed, 02 Aug 2023 23:03:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsH-0003Vo-JJ; Wed, 02 Aug 2023 23:03:25 +0000 Received: by outflank-mailman (input) for mailman id 575863; Wed, 02 Aug 2023 23:03:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsF-0002ha-K9 for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:23 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c48f3022-3188-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 01:03:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 8476682854B3; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aZx53xWMIUrw; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 5A90282857CC; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KeZPv3Og7xUN; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id ECB318285755; Wed, 2 Aug 2023 18:03:15 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c48f3022-3188-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 5A90282857CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017396; bh=/NqBjJ2QqrMRxqfD0TktMNubuD+Oy6q5OiAFylCvLXw=; h=From:To:Date:Message-Id:MIME-Version; b=NvDnMh3sMDwd8EfBcxA5F5FsRtP8g0Ve+fM0s3yIte6Yy23dwnX5IaCZC2Z10ygI1 1YZDZDWBqSIqdqiNNTUq3hkEAMUx4pg09L/jNejXqO2G18nFZd1QAGxTcmW+xFgqNg wjkeTJ5Pd1ddx93S1kDo1i6p/QlwgO0EXMFbA3DM= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 2/9] xen/ppc: Add public/arch-ppc.h Date: Wed, 2 Aug 2023 18:02:58 -0500 Message-Id: <14d8455ca49f69a56e87aad5d4e20cf8f77e55cd.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Signed-off-by: Shawn Anastasio --- xen/include/public/arch-ppc.h | 140 ++++++++++++++++++++++++++++++++++ 1 file changed, 140 insertions(+) create mode 100644 xen/include/public/arch-ppc.h diff --git a/xen/include/public/arch-ppc.h b/xen/include/public/arch-ppc.= h new file mode 100644 index 0000000000..0eb7ce4208 --- /dev/null +++ b/xen/include/public/arch-ppc.h @@ -0,0 +1,140 @@ +/* + * Permission is hereby granted, free of charge, to any person obtaining= a copy + * of this software and associated documentation files (the "Software"),= to + * deal in the Software without restriction, including without limitatio= n the + * rights to use, copy, modify, merge, publish, distribute, sublicense, = and/or + * sell copies of the Software, and to permit persons to whom the Softwa= re is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be includ= ed in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHA= LL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHE= R + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISI= NG + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Copyright (C) IBM Corp. 2005, 2006 + * Copyright (C) Raptor Engineering, LLC 2023 + * + * Authors: Hollis Blanchard + * Timothy Pearson + */ + +#ifndef __XEN_PUBLIC_ARCH_PPC64_H__ +#define __XEN_PUBLIC_ARCH_PPC64_H__ + +#define int64_aligned_t int64_t __attribute__((aligned(8))) +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) + +#ifndef __ASSEMBLY__ +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ + typedef union { type *p; unsigned long q; } \ + __guest_handle_ ## name; \ + typedef union { type *p; uint64_aligned_t q; } \ + __guest_handle_64_ ## name + +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, = name) +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name +#define set_xen_guest_handle_raw(hnd, val) \ + do { \ + __typeof__(&(hnd)) _sxghr_tmp =3D &(hnd); \ + _sxghr_tmp->q =3D 0; \ + _sxghr_tmp->p =3D val; \ + } while ( 0 ) +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val= ) + +#ifdef __XEN_TOOLS__ +#define get_xen_guest_handle(val, hnd) do { val =3D (hnd).p; } while (0= ) +#endif + +typedef uint64_t xen_pfn_t; +#define PRI_xen_pfn PRIx64 +#define PRIu_xen_pfn PRIu64 + +/* + * Maximum number of virtual CPUs in legacy multi-processor guests. + * Only one. All other VCPUS must use VCPUOP_register_vcpu_info. + */ +#define XEN_LEGACY_MAX_VCPUS 1 + +typedef uint64_t xen_ulong_t; +#define PRI_xen_ulong PRIx64 +#endif + +/* + * Pointers and other address fields inside interface structures are pad= ded to + * 64 bits. This means that field alignments aren't different between 32= - and + * 64-bit architectures. + */ +/* NB. Multi-level macro ensures __LINE__ is expanded before concatenati= on. */ +#define __MEMORY_PADDING(_X) +#define _MEMORY_PADDING(_X) __MEMORY_PADDING(_X) +#define MEMORY_PADDING _MEMORY_PADDING(__LINE__) + +/* And the trap vector is... */ +#define TRAP_INSTR "li 0,-1; sc" /* XXX just "sc"? */ + +#ifndef __ASSEMBLY__ + +#define XENCOMM_INLINE_FLAG (1UL << 63) + +typedef uint64_t xen_ulong_t; + +/* User-accessible registers: nost of these need to be saved/restored + * for every nested Xen invocation. */ +struct vcpu_guest_core_regs +{ + uint64_t gprs[32]; + uint64_t lr; + uint64_t ctr; + uint64_t srr0; + uint64_t srr1; + uint64_t pc; + uint64_t msr; + uint64_t fpscr; /* XXX Is this necessary */ + uint64_t xer; + uint64_t hid4; /* debug only */ + uint64_t dar; /* debug only */ + uint32_t dsisr; /* debug only */ + uint32_t cr; + uint32_t __pad; /* good spot for another 32bit reg */ + uint32_t entry_vector; +}; +typedef struct vcpu_guest_core_regs vcpu_guest_core_regs_t; + +typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ /* XXX timebase = */ + +/* ONLY used to communicate with dom0! See also struct exec_domain. */ +struct vcpu_guest_context { + vcpu_guest_core_regs_t user_regs; /* User-level CPU register= s */ + uint64_t sdr1; /* Pagetable base *= / + /* XXX etc */ +}; +typedef struct vcpu_guest_context vcpu_guest_context_t; +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); + +struct arch_shared_info { + uint64_t boot_timebase; +}; + +struct arch_vcpu_info { +}; + +struct xen_arch_domainconfig { +}; + +typedef struct xen_pmu_arch { uint8_t dummy; } xen_pmu_arch_t; + +/* Support for multi-processor guests. */ +#endif + +#endif --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575865.901379 (Exim 4.92) (envelope-from ) id 1qRKsI-0003g9-GY; Wed, 02 Aug 2023 23:03:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575865.901379; Wed, 02 Aug 2023 23:03:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsI-0003d6-5X; Wed, 02 Aug 2023 23:03:26 +0000 Received: by outflank-mailman (input) for mailman id 575865; Wed, 02 Aug 2023 23:03:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsG-0002ha-KE for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:24 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c630ba31-3188-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 01:03:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 3BCD58286985; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id stl2bWSDymwU; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id CD8ED8286986; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id awEEu_sSYccA; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 3AB2A8285801; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c630ba31-3188-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com CD8ED8286986 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017398; bh=IRB/k9AAEsYW3GbnY7XYEQDTmCQcNBCKgPHrjMuNqBM=; h=From:To:Date:Message-Id:MIME-Version; b=fVtp3qJ4toRy7w4GJ53dyAY6jo82bfhuX8WVP11rW4I0gi3pk+YORa4cvIfurrRXQ 4ShGAVQcjKAz7qxmUpFWA3zjko7bewpCdf4gcgv1yF93fuoipyQXvwYMltFPxC2n3A BICoRsAchBTkZGHBYusdrJ+kXEuk/uyjA+y2kxM0= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 7/9] xen/ppc: Define bug frames table in linker script Date: Wed, 2 Aug 2023 18:03:03 -0500 Message-Id: <65e26bb63977749cc50daad4ecaf891bf7cc6b0a.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Define the bug frames table in ppc's linker script as is done by other architectures. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/xen.lds.S | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/xen/arch/ppc/xen.lds.S b/xen/arch/ppc/xen.lds.S index 2fa81d5a83..692aa34add 100644 --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -41,6 +41,16 @@ SECTIONS . =3D ALIGN(PAGE_SIZE); .rodata : { _srodata =3D .; /* Read-only data */ + /* Bug frames table */ + __start_bug_frames =3D .; + *(.bug_frames.0) + __stop_bug_frames_0 =3D .; + *(.bug_frames.1) + __stop_bug_frames_1 =3D .; + *(.bug_frames.2) + __stop_bug_frames_2 =3D .; + *(.bug_frames.3) + __stop_bug_frames_3 =3D .; *(.rodata) *(.rodata.*) *(.data.rel.ro) --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575861.901345 (Exim 4.92) (envelope-from ) id 1qRKsF-0002vU-WD; Wed, 02 Aug 2023 23:03:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575861.901345; Wed, 02 Aug 2023 23:03:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsF-0002uE-S9; Wed, 02 Aug 2023 23:03:23 +0000 Received: by outflank-mailman (input) for mailman id 575861; Wed, 02 Aug 2023 23:03:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsE-0002Xg-Kp for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:22 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c556464b-3188-11ee-b265-6b7b168915f2; Thu, 03 Aug 2023 01:03:19 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 9B5FD8286987; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EoR4xdmHyltq; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 414C582853DD; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NuW5S9AYKLyX; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id BBCF98285801; Wed, 2 Aug 2023 18:03:16 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c556464b-3188-11ee-b265-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 414C582853DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017397; bh=rZAldAQK00ovSXSpgF7Lp58mw77D/MWNT5l6iW6CChk=; h=From:To:Date:Message-Id:MIME-Version; b=dZMQ3XBNkxo4errxPUnFLgXNh0mDY/dATXwqgJfpw05xrpStnw9JRhdyZvtUFagds PGlKVK3mZbgOp0UP5hJhSluMMnMYbMynO9J3iqXHsR4OTlM0HvA/6MaaJQw9PcHDx7 J62CWVRpYzH6B40yO3xehHkKSu2mJKLioyM3XGQs= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 4/9] xen/ppc: Implement bitops.h Date: Wed, 2 Aug 2023 18:03:00 -0500 Message-Id: <63b89c627948015cc9a1c1e5d1775ee9e41508ba.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Implement bitops.h, based on Linux's implementation as of commit 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/bitops.h | 331 +++++++++++++++++++++++++++++- 1 file changed, 327 insertions(+), 4 deletions(-) diff --git a/xen/arch/ppc/include/asm/bitops.h b/xen/arch/ppc/include/asm= /bitops.h index a7cd8ec7c5..286f68cbfe 100644 --- a/xen/arch/ppc/include/asm/bitops.h +++ b/xen/arch/ppc/include/asm/bitops.h @@ -1,11 +1,334 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Adapted from Linux's arch/powerpc/include/asm/bitops.h. + * + * Merged version by David Gibson . + * Based on ppc64 versions by: Dave Engebretsen, Todd Inglett, Don + * Reed, Pat McCarthy, Peter Bergner, Anton Blanchard. They + * originally took it from the ppc32 code. + */ #ifndef _ASM_PPC_BITOPS_H #define _ASM_PPC_BITOPS_H =20 -#include +#define __set_bit(n,p) set_bit(n,p) +#define __clear_bit(n,p) clear_bit(n,p) + +#define BITOP_BITS_PER_WORD 32 +#define BITOP_MASK(nr) (1UL << ((nr) % BITOP_BITS_PER_WORD)) +#define BITOP_WORD(nr) ((nr) / BITOP_BITS_PER_WORD) +#define BITS_PER_BYTE 8 =20 /* PPC bit number conversion */ -#define PPC_BITLSHIFT(be) (BITS_PER_LONG - 1 - (be)) -#define PPC_BIT(bit) (1UL << PPC_BITLSHIFT(bit)) -#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs)) +#define PPC_BITLSHIFT(be) (BITS_PER_LONG - 1 - (be)) +#define PPC_BIT(bit) (1UL << PPC_BITLSHIFT(bit)) +#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs)) + +/* Macro for generating the ***_bits() functions */ +#define DEFINE_BITOP(fn, op, prefix) \ +static inline void fn(unsigned long mask, \ + volatile unsigned int *_p) \ +{ \ + unsigned long old; \ + unsigned int *p =3D (unsigned int *)_p; \ + __asm__ __volatile__ ( \ + prefix \ +"1: lwarx %0,0,%3,0\n" \ + #op "%I2 %0,%0,%2\n" \ + "stwcx. %0,0,%3\n" \ + "bne- 1b\n" \ + : "=3D&r" (old), "+m" (*p) \ + : "rK" (mask), "r" (p) \ + : "cc", "memory"); \ +} + +DEFINE_BITOP(set_bits, or, "") +DEFINE_BITOP(change_bits, xor, "") + +#define DEFINE_CLROP(fn, prefix) \ +static inline void fn(unsigned long mask, volatile unsigned int *_p) = \ +{ \ + unsigned long old; \ + unsigned int *p =3D (unsigned int *)_p; \ + \ + asm volatile ( \ + prefix \ + "1: lwarx %0,0,%3,0\n" \ + "andc %0,%0,%2\n" \ + "stwcx. %0,0,%3\n" \ + "bne- 1b\n" \ + : "=3D&r" (old), "+m" (*p) \ + : "r" (mask), "r" (p) \ + : "cc", "memory"); \ +} + +DEFINE_CLROP(clear_bits, "") + +static inline void set_bit(int nr, volatile void *addr) +{ + set_bits(BITOP_MASK(nr), (volatile unsigned int *)addr + BITOP_WORD(= nr)); +} +static inline void clear_bit(int nr, volatile void *addr) +{ + clear_bits(BITOP_MASK(nr), (volatile unsigned int *)addr + BITOP_WOR= D(nr)); +} + +/** + * test_bit - Determine whether a bit is set + * @nr: bit number to test + * @addr: Address to start counting from + */ +static inline int test_bit(int nr, const volatile void *addr) +{ + const volatile unsigned long *p =3D (const volatile unsigned lon= g *)addr; + return 1UL & (p[BITOP_WORD(nr)] >> (nr & (BITOP_BITS_PER_WORD-1)= )); +} + +static inline unsigned long test_and_clear_bits(unsigned long mask, vola= tile void *_p) +{ + unsigned long old, t; + unsigned int *p =3D (unsigned int *)_p; + + asm volatile ( + "sync\n" + "1:" "lwarx %0,0,%3,0\n" + "andc %1,%0,%2\n" + "stwcx. %1,0,%3\n" + "bne- 1b\n" + "sync\n" + : "=3D&r" (old), "=3D&r" (t) + : "r" (mask), "r" (p) + : "cc", "memory"); + + return (old & mask); +} + +static inline int test_and_clear_bit(unsigned int nr, + volatile void *addr) +{ + return test_and_clear_bits(BITOP_MASK(nr), addr + BITOP_WORD(nr)) !=3D = 0; +} + +#define DEFINE_TESTOP(fn, op, eh) \ +static inline unsigned long fn( \ + unsigned long mask, \ + volatile unsigned int *_p) \ +{ \ + unsigned long old, t; \ + unsigned int *p =3D (unsigned int *)_p; \ + __asm__ __volatile__ ( \ + "sync\n" \ +"1:" "lwarx %0,0,%3,%4\n" \ + #op "%I2 %1,%0,%2\n" \ + "stwcx. %1,0,%3\n" \ + "bne- 1b\n" \ + "sync\n" \ + : "=3D&r" (old), "=3D&r" (t) \ + : "rK" (mask), "r" (p), "n" (eh) \ + : "cc", "memory"); \ + return (old & mask); \ +} + +DEFINE_TESTOP(test_and_set_bits, or, 0) + +static inline int test_and_set_bit(unsigned long nr, volatile void *addr= ) +{ + return test_and_set_bits(BITOP_MASK(nr), (volatile unsigned int *)addr = + BITOP_WORD(nr)) !=3D 0; +} + +/** + * __test_and_set_bit - Set a bit and return its old value + * @nr: Bit to set + * @addr: Address to count from + * + * This operation is non-atomic and can be reordered. + * If two examples of this operation race, one can appear to succeed + * but actually fail. You must protect multiple accesses with a lock. + */ +static inline int __test_and_set_bit(int nr, volatile void *addr) +{ + unsigned int mask =3D BITOP_MASK(nr); + volatile unsigned int *p =3D + ((volatile unsigned int *)addr) + BITOP_WORD(nr); + unsigned int old =3D *p; + + *p =3D old | mask; + return (old & mask) !=3D 0; +} + +/** + * __test_and_clear_bit - Clear a bit and return its old value + * @nr: Bit to clear + * @addr: Address to count from + * + * This operation is non-atomic and can be reordered. + * If two examples of this operation race, one can appear to succeed + * but actually fail. You must protect multiple accesses with a lock. + */ +static inline int __test_and_clear_bit(int nr, volatile void *addr) +{ + unsigned int mask =3D BITOP_MASK(nr); + volatile unsigned int *p =3D + ((volatile unsigned int *)addr) + BITOP_WORD(nr); + unsigned int old =3D *p; + + *p =3D old & ~mask; + return (old & mask) !=3D 0; +} + +#define flsl(x) generic_flsl(x) +#define fls(x) generic_fls(x) +#define ffs(x) ({ unsigned int __t =3D (x); fls(__t & -__t); }) +#define ffsl(x) ({ unsigned long __t =3D (x); flsl(__t & -__t); }) + +/* Based on linux/include/asm-generic/bitops/ffz.h */ +/* + * ffz - find first zero in word. + * @word: The word to search + * + * Undefined if no zero exists, so code should check against ~0UL first. + */ +#define ffz(x) __ffs(~(x)) + +/** + * hweightN - returns the hamming weight of a N-bit word + * @x: the word to weigh + * + * The Hamming Weight of a number is the total number of bits set in it. + */ +#define hweight64(x) generic_hweight64(x) +#define hweight32(x) generic_hweight32(x) +#define hweight16(x) generic_hweight16(x) +#define hweight8(x) generic_hweight8(x) + +/* Based on linux/include/asm-generic/bitops/builtin-__ffs.h */ +/** + * __ffs - find first bit in word. + * @word: The word to search + * + * Undefined if no bit exists, so code should check against 0 first. + */ +static /*__*/always_inline unsigned long __ffs(unsigned long word) +{ + return __builtin_ctzl(word); +} + +/** + * find_first_set_bit - find the first set bit in @word + * @word: the word to search + * + * Returns the bit-number of the first set bit (first bit being 0). + * The input must *not* be zero. + */ +#define find_first_set_bit(x) ({ ffsl(x) - 1; }) + +/* + * Find the first set bit in a memory region. + */ +static inline unsigned long find_first_bit(const unsigned long *addr, + unsigned long size) +{ + const unsigned long *p =3D addr; + unsigned long result =3D 0; + unsigned long tmp; + + while (size & ~(BITS_PER_LONG-1)) { + if ((tmp =3D *(p++))) + goto found; + result +=3D BITS_PER_LONG; + size -=3D BITS_PER_LONG; + } + if (!size) + return result; + + tmp =3D (*p) & (~0UL >> (BITS_PER_LONG - size)); + if (tmp =3D=3D 0UL) /* Are any bits set? */ + return result + size; /* Nope. */ +found: + return result + __ffs(tmp); +} + +static inline unsigned long find_next_bit(const unsigned long *addr, + unsigned long size, + unsigned long offset) +{ + const unsigned long *p =3D addr + BITOP_WORD(offset); + unsigned long result =3D offset & ~(BITS_PER_LONG-1); + unsigned long tmp; + + if (offset >=3D size) + return size; + size -=3D result; + offset %=3D BITS_PER_LONG; + if (offset) { + tmp =3D *(p++); + tmp &=3D (~0UL << offset); + if (size < BITS_PER_LONG) + goto found_first; + if (tmp) + goto found_middle; + size -=3D BITS_PER_LONG; + result +=3D BITS_PER_LONG; + } + while (size & ~(BITS_PER_LONG-1)) { + if ((tmp =3D *(p++))) + goto found_middle; + result +=3D BITS_PER_LONG; + size -=3D BITS_PER_LONG; + } + if (!size) + return result; + tmp =3D *p; + +found_first: + tmp &=3D (~0UL >> (BITS_PER_LONG - size)); + if (tmp =3D=3D 0UL) /* Are any bits set? */ + return result + size; /* Nope. */ +found_middle: + return result + __ffs(tmp); +} + +/* + * This implementation of find_{first,next}_zero_bit was stolen from + * Linus' asm-alpha/bitops.h. + */ +static inline unsigned long find_next_zero_bit(const unsigned long *addr= , + unsigned long size, + unsigned long offset) +{ + const unsigned long *p =3D addr + BITOP_WORD(offset); + unsigned long result =3D offset & ~(BITS_PER_LONG-1); + unsigned long tmp; + + if (offset >=3D size) + return size; + size -=3D result; + offset %=3D BITS_PER_LONG; + if (offset) { + tmp =3D *(p++); + tmp |=3D ~0UL >> (BITS_PER_LONG - offset); + if (size < BITS_PER_LONG) + goto found_first; + if (~tmp) + goto found_middle; + size -=3D BITS_PER_LONG; + result +=3D BITS_PER_LONG; + } + while (size & ~(BITS_PER_LONG-1)) { + if (~(tmp =3D *(p++))) + goto found_middle; + result +=3D BITS_PER_LONG; + size -=3D BITS_PER_LONG; + } + if (!size) + return result; + tmp =3D *p; + +found_first: + tmp |=3D ~0UL << size; + if (tmp =3D=3D ~0UL) /* Are any bits zero? */ + return result + size; /* Nope. */ +found_middle: + return result + ffz(tmp); +} =20 #endif /* _ASM_PPC_BITOPS_H */ --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575866.901392 (Exim 4.92) (envelope-from ) id 1qRKsJ-00049W-LS; Wed, 02 Aug 2023 23:03:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575866.901392; Wed, 02 Aug 2023 23:03:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsJ-00047Z-Hd; Wed, 02 Aug 2023 23:03:27 +0000 Received: by outflank-mailman (input) for mailman id 575866; Wed, 02 Aug 2023 23:03:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsH-0002ha-KG for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:25 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c630955c-3188-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 01:03:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id D90A58285755; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id q5S3udTYLjJ5; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 3CF748286985; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EVp_UIJ6pOb8; Wed, 2 Aug 2023 18:03:18 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id BEC5182857CC; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c630955c-3188-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 3CF748286985 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017398; bh=mTHIJoDesvUL/1mvvl/fu0GmqgkC6yCd3GyR+DEjPQM=; h=From:To:Date:Message-Id:MIME-Version; b=gyhBMPrbZOxx2NbfavaS5idAmmnHNgceVgOSB2PqpVWV1kD5ciH4ZT6KQra/sBk0f ZKanThnkAWEw2pqLbkB6W2y9fYkk8hbs905OBqMGWFFAi4CoZL+Wxxo4K/PFThpH2e 4BXUcx1chDr7AJ6PQb5zo+eJnfZwpg2072AmoJAg= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 6/9] ns16550: Guard accesses to `vuart` field by CONFIG_ARM Date: Wed, 2 Aug 2023 18:03:02 -0500 Message-Id: <1bee2fe06c4a9262b05cb4b8cd392d9630279f30.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable When CONFIG_ARM is defined, a `vuart` field is added to struct ns16550, but accesses to this field in ns16550_uart_dt_init weren't correctly guarded. Fix build on !ARM platforms that define CONFIG_HAS_DEVICE_TREE by correctly guarding access to the vuart field in this function. Signed-off-by: Shawn Anastasio --- xen/drivers/char/ns16550.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 212a9c49ae..c0598efb27 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1797,11 +1797,13 @@ static int __init ns16550_uart_dt_init(struct dt_= device_node *dev, =20 uart->dw_usr_bsy =3D dt_device_is_compatible(dev, "snps,dw-apb-uart"= ); =20 +#ifdef CONFIG_ARM uart->vuart.base_addr =3D uart->io_base; uart->vuart.size =3D uart->io_size; uart->vuart.data_off =3D UART_THR <reg_shift; uart->vuart.status_off =3D UART_LSR<reg_shift; uart->vuart.status =3D UART_LSR_THRE|UART_LSR_TEMT; +#endif =20 /* Register with generic serial driver. */ serial_register_uart(uart - ns16550_com, &ns16550_driver, uart); --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575867.901407 (Exim 4.92) (envelope-from ) id 1qRKsL-0004a4-60; Wed, 02 Aug 2023 23:03:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575867.901407; Wed, 02 Aug 2023 23:03:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsK-0004Zh-VY; Wed, 02 Aug 2023 23:03:28 +0000 Received: by outflank-mailman (input) for mailman id 575867; Wed, 02 Aug 2023 23:03:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsI-0002Xg-8h for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:26 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7f4ff75-3188-11ee-b265-6b7b168915f2; Thu, 03 Aug 2023 01:03:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 41E9582853DD; Wed, 2 Aug 2023 18:03:23 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 4Fb2Nfq4bCbN; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id C92968286980; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z5LRkq34hd61; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 248908286985; Wed, 2 Aug 2023 18:03:17 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7f4ff75-3188-11ee-b265-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com C92968286980 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017397; bh=K/1O9TRQA10A6v+g1F1roS24XihOkwDHxxE5UQO9nJ8=; h=From:To:Date:Message-Id:MIME-Version; b=cV7KLHzN+chE8lGLs4rX/CIN95ws2j23JrIIK4+Goyg5B7gMOWrW38StqfjC91plA WiL0qySXJiORYFLri+CJDDZKvKGfFLTHJMZ9X2+dMZlp1Iv81ByCJ4YSycY7yGUz+I F1iwPdl4LE/4sqL/g36soeIr3ibnzrHkwePTFI3k= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 5/9] xen/ppc: Define minimal stub headers required for full build Date: Wed, 2 Aug 2023 18:03:01 -0500 Message-Id: <9cd545a4a9ef55d06ea0b81044e22f64ee42823e.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Additionally, change inclusion of asm/ headers to corresponding xen/ ones throughout arch/ppc now that they work. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Kconfig | 1 + xen/arch/ppc/include/asm/altp2m.h | 39 ++++ xen/arch/ppc/include/asm/bug.h | 7 + xen/arch/ppc/include/asm/cache.h | 2 + xen/arch/ppc/include/asm/config.h | 9 + xen/arch/ppc/include/asm/cpufeature.h | 9 + xen/arch/ppc/include/asm/current.h | 42 ++++ xen/arch/ppc/include/asm/delay.h | 11 + xen/arch/ppc/include/asm/desc.h | 0 xen/arch/ppc/include/asm/device.h | 53 +++++ xen/arch/ppc/include/asm/div64.h | 14 ++ xen/arch/ppc/include/asm/domain.h | 46 ++++ xen/arch/ppc/include/asm/event.h | 35 ++++ xen/arch/ppc/include/asm/flushtlb.h | 23 ++ xen/arch/ppc/include/asm/grant_table.h | 0 xen/arch/ppc/include/asm/guest_access.h | 54 +++++ xen/arch/ppc/include/asm/guest_atomics.h | 14 ++ xen/arch/ppc/include/asm/hardirq.h | 18 ++ xen/arch/ppc/include/asm/hypercall.h | 0 xen/arch/ppc/include/asm/io.h | 15 ++ xen/arch/ppc/include/asm/iocap.h | 7 + xen/arch/ppc/include/asm/iommu.h | 7 + xen/arch/ppc/include/asm/irq.h | 32 +++ xen/arch/ppc/include/asm/mem_access.h | 0 xen/arch/ppc/include/asm/mm.h | 255 ++++++++++++++++++++++- xen/arch/ppc/include/asm/monitor.h | 48 +++++ xen/arch/ppc/include/asm/nospec.h | 18 ++ xen/arch/ppc/include/asm/numa.h | 26 +++ xen/arch/ppc/include/asm/p2m.h | 105 ++++++++++ xen/arch/ppc/include/asm/page.h | 19 ++ xen/arch/ppc/include/asm/paging.h | 7 + xen/arch/ppc/include/asm/pci.h | 7 + xen/arch/ppc/include/asm/percpu.h | 26 +++ xen/arch/ppc/include/asm/procarea.h | 38 ++++ xen/arch/ppc/include/asm/processor.h | 6 + xen/arch/ppc/include/asm/random.h | 9 + xen/arch/ppc/include/asm/regs.h | 2 + xen/arch/ppc/include/asm/setup.h | 6 + xen/arch/ppc/include/asm/smp.h | 18 ++ xen/arch/ppc/include/asm/softirq.h | 8 + xen/arch/ppc/include/asm/spinlock.h | 15 ++ xen/arch/ppc/include/asm/system.h | 243 ++++++++++++++++++++- xen/arch/ppc/include/asm/time.h | 20 ++ xen/arch/ppc/include/asm/vm_event.h | 49 +++++ xen/arch/ppc/include/asm/xenoprof.h | 0 xen/arch/ppc/mm-radix.c | 2 +- xen/arch/ppc/opal.c | 2 - xen/arch/ppc/tlb-radix.c | 2 +- xen/include/public/hvm/save.h | 2 + xen/include/public/pmu.h | 2 + xen/include/public/xen.h | 2 + 51 files changed, 1368 insertions(+), 7 deletions(-) create mode 100644 xen/arch/ppc/include/asm/altp2m.h create mode 100644 xen/arch/ppc/include/asm/cpufeature.h create mode 100644 xen/arch/ppc/include/asm/current.h create mode 100644 xen/arch/ppc/include/asm/delay.h create mode 100644 xen/arch/ppc/include/asm/desc.h create mode 100644 xen/arch/ppc/include/asm/device.h create mode 100644 xen/arch/ppc/include/asm/div64.h create mode 100644 xen/arch/ppc/include/asm/domain.h create mode 100644 xen/arch/ppc/include/asm/event.h create mode 100644 xen/arch/ppc/include/asm/flushtlb.h create mode 100644 xen/arch/ppc/include/asm/grant_table.h create mode 100644 xen/arch/ppc/include/asm/guest_access.h create mode 100644 xen/arch/ppc/include/asm/guest_atomics.h create mode 100644 xen/arch/ppc/include/asm/hardirq.h create mode 100644 xen/arch/ppc/include/asm/hypercall.h create mode 100644 xen/arch/ppc/include/asm/io.h create mode 100644 xen/arch/ppc/include/asm/iocap.h create mode 100644 xen/arch/ppc/include/asm/iommu.h create mode 100644 xen/arch/ppc/include/asm/irq.h create mode 100644 xen/arch/ppc/include/asm/mem_access.h create mode 100644 xen/arch/ppc/include/asm/monitor.h create mode 100644 xen/arch/ppc/include/asm/nospec.h create mode 100644 xen/arch/ppc/include/asm/numa.h create mode 100644 xen/arch/ppc/include/asm/p2m.h create mode 100644 xen/arch/ppc/include/asm/paging.h create mode 100644 xen/arch/ppc/include/asm/pci.h create mode 100644 xen/arch/ppc/include/asm/percpu.h create mode 100644 xen/arch/ppc/include/asm/procarea.h create mode 100644 xen/arch/ppc/include/asm/random.h create mode 100644 xen/arch/ppc/include/asm/setup.h create mode 100644 xen/arch/ppc/include/asm/smp.h create mode 100644 xen/arch/ppc/include/asm/softirq.h create mode 100644 xen/arch/ppc/include/asm/spinlock.h create mode 100644 xen/arch/ppc/include/asm/time.h create mode 100644 xen/arch/ppc/include/asm/vm_event.h create mode 100644 xen/arch/ppc/include/asm/xenoprof.h diff --git a/xen/arch/ppc/Kconfig b/xen/arch/ppc/Kconfig index ab116ffb2a..a6eae597af 100644 --- a/xen/arch/ppc/Kconfig +++ b/xen/arch/ppc/Kconfig @@ -1,6 +1,7 @@ config PPC def_bool y select HAS_DEVICE_TREE + select HAS_PDX =20 config PPC64 def_bool y diff --git a/xen/arch/ppc/include/asm/altp2m.h b/xen/arch/ppc/include/asm= /altp2m.h new file mode 100644 index 0000000000..73a1e3a114 --- /dev/null +++ b/xen/arch/ppc/include/asm/altp2m.h @@ -0,0 +1,39 @@ +/* + * Alternate p2m + * + * Copyright (c) 2014, Intel Corporation. + * + * This program is free software; you can redistribute it and/or modify = it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOU= T + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License= for + * more details. + * + * You should have received a copy of the GNU General Public License alo= ng with + * this program; If not, see . + */ + +#ifndef __ASM_PPC_ALTP2M_H__ +#define __ASM_PPC_ALTP2M_H__ + +#include + +/* Alternate p2m on/off per domain */ +static inline bool altp2m_active(const struct domain *d) +{ + /* Not implemented on PPC. */ + return false; +} + +/* Alternate p2m VCPU */ +static inline uint16_t altp2m_vcpu_idx(const struct vcpu *v) +{ + /* Not implemented on PPC, should not be reached. */ + BUG(); + return 0; +} + +#endif /* __ASM_PPC_ALTP2M_H__ */ diff --git a/xen/arch/ppc/include/asm/bug.h b/xen/arch/ppc/include/asm/bu= g.h index e5e874b31c..d02e8e2898 100644 --- a/xen/arch/ppc/include/asm/bug.h +++ b/xen/arch/ppc/include/asm/bug.h @@ -4,6 +4,7 @@ #define _ASM_PPC_BUG_H =20 #include +#include =20 /* * Power ISA guarantees that an instruction consisting of all zeroes is @@ -15,4 +16,10 @@ =20 #define BUG_FN_REG r0 =20 +#define BUG() do { \ + die(); \ +} while (0) + +#define BUG_FRAME(type, line, ptr, second_frame, msg) do { } while (0) + #endif /* _ASM_PPC_BUG_H */ diff --git a/xen/arch/ppc/include/asm/cache.h b/xen/arch/ppc/include/asm/= cache.h index 8a0a6b7b17..0d7323d789 100644 --- a/xen/arch/ppc/include/asm/cache.h +++ b/xen/arch/ppc/include/asm/cache.h @@ -3,4 +3,6 @@ #ifndef _ASM_PPC_CACHE_H #define _ASM_PPC_CACHE_H =20 +#define __read_mostly __section(".data.read_mostly") + #endif /* _ASM_PPC_CACHE_H */ diff --git a/xen/arch/ppc/include/asm/config.h b/xen/arch/ppc/include/asm= /config.h index b76f940431..965b79aa64 100644 --- a/xen/arch/ppc/include/asm/config.h +++ b/xen/arch/ppc/include/asm/config.h @@ -41,6 +41,15 @@ =20 #define XEN_VIRT_START _AT(vaddr_t, 0xc000000000000000) =20 +#define VMAP_VIRT_START (XEN_VIRT_START + GB(1)) +#define VMAP_VIRT_SIZE GB(1) + +#define FRAMETABLE_VIRT_START (XEN_VIRT_START + GB(32)) +#define FRAMETABLE_SIZE GB(32) +#define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) + +#define HYPERVISOR_VIRT_START XEN_VIRT_START + #define SMP_CACHE_BYTES (1 << 6) =20 #define STACK_ORDER 0 diff --git a/xen/arch/ppc/include/asm/cpufeature.h b/xen/arch/ppc/include= /asm/cpufeature.h new file mode 100644 index 0000000000..3552b9231d --- /dev/null +++ b/xen/arch/ppc/include/asm/cpufeature.h @@ -0,0 +1,9 @@ +#ifndef __ASM_PPC_CPUFEATURE_H__ +#define __ASM_PPC_CPUFEATURE_H__ + +static inline int cpu_nr_siblings(unsigned int cpu) +{ + return 1; +} + +#endif /* __ASM_PPC_CPUFEATURE_H__ */ diff --git a/xen/arch/ppc/include/asm/current.h b/xen/arch/ppc/include/as= m/current.h new file mode 100644 index 0000000000..87a854d6b0 --- /dev/null +++ b/xen/arch/ppc/include/asm/current.h @@ -0,0 +1,42 @@ +#ifndef __ASM_PPC_CURRENT_H__ +#define __ASM_PPC_CURRENT_H__ + +#include + +#ifndef __ASSEMBLY__ + +struct vcpu; + +/* Which VCPU is "current" on this PCPU. */ +DECLARE_PER_CPU(struct vcpu *, curr_vcpu); + +#define current (this_cpu(curr_vcpu)) +#define set_current(vcpu) do { current =3D (vcpu); } while (0) +#define get_cpu_current(cpu) (per_cpu(curr_vcpu, cpu)) + +/* Per-VCPU state that lives at the top of the stack */ +struct cpu_info { + struct cpu_user_regs guest_cpu_user_regs; + unsigned long elr; + uint32_t flags; +}; + +static inline struct cpu_info *get_cpu_info(void) +{ +#ifdef __clang__ + unsigned long sp; + + asm ("mr %0, 1" : "=3Dr" (sp)); +#else + register unsigned long sp asm ("r1"); +#endif + + return (struct cpu_info *)((sp & ~(STACK_SIZE - 1)) + + STACK_SIZE - sizeof(struct cpu_info)); +} + +#define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) + +#endif /* __ASSEMBLY__ */ + +#endif /* __ASM_PPC_CURRENT_H__ */ diff --git a/xen/arch/ppc/include/asm/delay.h b/xen/arch/ppc/include/asm/= delay.h new file mode 100644 index 0000000000..36be1775f8 --- /dev/null +++ b/xen/arch/ppc/include/asm/delay.h @@ -0,0 +1,11 @@ +#ifndef __ASM_PPC_DELAY_H__ +#define __ASM_PPC_DELAY_H__ + +#include + +static inline void udelay(unsigned long usecs) +{ + BUG(); +} + +#endif /* __ASM_PPC_DELAY_H__ */ diff --git a/xen/arch/ppc/include/asm/desc.h b/xen/arch/ppc/include/asm/d= esc.h new file mode 100644 index 0000000000..e69de29bb2 diff --git a/xen/arch/ppc/include/asm/device.h b/xen/arch/ppc/include/asm= /device.h new file mode 100644 index 0000000000..cb8454f605 --- /dev/null +++ b/xen/arch/ppc/include/asm/device.h @@ -0,0 +1,53 @@ +#ifndef __ASM_PPC_DEVICE_H__ +#define __ASM_PPC_DEVICE_H__ + +enum device_type +{ + DEV_DT, + DEV_PCI, +}; + +struct device { + enum device_type type; +#ifdef CONFIG_HAS_DEVICE_TREE + struct dt_device_node *of_node; /* Used by drivers imported from Lin= ux */ +#endif +}; + +enum device_class +{ + DEVICE_SERIAL, + DEVICE_IOMMU, + DEVICE_GIC, + DEVICE_PCI_HOSTBRIDGE, + /* Use for error */ + DEVICE_UNKNOWN, +}; + +struct device_desc { + /* Device name */ + const char *name; + /* Device class */ + enum device_class class; + /* List of devices supported by this driver */ + const struct dt_device_match *dt_match; + /* + * Device initialization. + * + * -EAGAIN is used to indicate that device probing is deferred. + */ + int (*init)(struct dt_device_node *dev, const void *data); +}; + +typedef struct device device_t; + +#define DT_DEVICE_START(_name, _namestr, _class) \ +static const struct device_desc __dev_desc_##_name __used \ +__section(".dev.info") =3D { \ + .name =3D _namestr, \ + .class =3D _class, \ + +#define DT_DEVICE_END \ +}; + +#endif /* __ASM_PPC_DEVICE_H__ */ diff --git a/xen/arch/ppc/include/asm/div64.h b/xen/arch/ppc/include/asm/= div64.h new file mode 100644 index 0000000000..6959c3fb26 --- /dev/null +++ b/xen/arch/ppc/include/asm/div64.h @@ -0,0 +1,14 @@ +#ifndef __ASM_PPC_DIV64_H__ +#define __ASM_PPC_DIV64_H__ + +#include + +#define do_div(n,base) ({ \ + uint32_t __base =3D (base); \ + uint32_t __rem; \ + __rem =3D ((uint64_t)(n)) % __base; \ + (n) =3D ((uint64_t)(n)) / __base; \ + __rem; \ +}) + +#endif /* __ASM_PPC_DIV64_H__ */ diff --git a/xen/arch/ppc/include/asm/domain.h b/xen/arch/ppc/include/asm= /domain.h new file mode 100644 index 0000000000..4ade3d484e --- /dev/null +++ b/xen/arch/ppc/include/asm/domain.h @@ -0,0 +1,46 @@ +#ifndef __ASM_PPC_DOMAIN_H__ +#define __ASM_PPC_DOMAIN_H__ + +#include +#include + +struct hvm_domain +{ + uint64_t params[HVM_NR_PARAMS]; +}; + +#define is_domain_direct_mapped(d) ((void)(d), 0) + +/* TODO: Implement */ +#define guest_mode(r) ({ (void) (r); BUG(); 0; }) + +struct arch_vcpu_io { +}; + +struct arch_vcpu { +}; + +struct arch_domain { + struct hvm_domain hvm; +}; + +#include + +static inline struct vcpu_guest_context *alloc_vcpu_guest_context(void) +{ + return xmalloc(struct vcpu_guest_context); +} + +static inline void free_vcpu_guest_context(struct vcpu_guest_context *vg= c) +{ + xfree(vgc); +} + +struct guest_memory_policy {}; +static inline void update_guest_memory_policy(struct vcpu *v, + struct guest_memory_policy= *gmp) +{} + +static inline void arch_vcpu_block(struct vcpu *v) {} + +#endif /* __ASM_PPC_DOMAIN_H__ */ diff --git a/xen/arch/ppc/include/asm/event.h b/xen/arch/ppc/include/asm/= event.h new file mode 100644 index 0000000000..3141127f31 --- /dev/null +++ b/xen/arch/ppc/include/asm/event.h @@ -0,0 +1,35 @@ +#ifndef __ASM_PPC_EVENT_H__ +#define __ASM_PPC_EVENT_H__ + +#include + +/* TODO: implement */ +static inline void vcpu_kick(struct vcpu *v) { BUG(); } +static inline void vcpu_mark_events_pending(struct vcpu *v) { BUG(); } +static inline void vcpu_update_evtchn_irq(struct vcpu *v) { BUG(); } +static inline void vcpu_block_unless_event_pending(struct vcpu *v) { BUG= (); } + +static inline int vcpu_event_delivery_is_enabled(struct vcpu *v) +{ + BUG(); + return 0; +} + +/* No arch specific virq definition now. Default to global. */ +static inline bool arch_virq_is_global(unsigned int virq) +{ + return true; +} + +static inline int local_events_need_delivery(void) +{ + BUG(); + return 0; +} + +static inline void local_event_delivery_enable(void) +{ + BUG(); +} + +#endif /* __ASM_PPC_EVENT_H__ */ diff --git a/xen/arch/ppc/include/asm/flushtlb.h b/xen/arch/ppc/include/a= sm/flushtlb.h new file mode 100644 index 0000000000..1af3bd2301 --- /dev/null +++ b/xen/arch/ppc/include/asm/flushtlb.h @@ -0,0 +1,23 @@ +#ifndef __ASM_PPC_FLUSHTLB_H__ +#define __ASM_PPC_FLUSHTLB_H__ + +#include + +/* + * Filter the given set of CPUs, removing those that definitely flushed = their + * TLB since @page_timestamp. + */ +/* XXX lazy implementation just doesn't clear anything.... */ +static inline void tlbflush_filter(cpumask_t *mask, uint32_t page_timest= amp) {} + +#define tlbflush_current_time() (0) + +static inline void page_set_tlbflush_timestamp(struct page_info *page) +{ + page->tlbflush_timestamp =3D tlbflush_current_time(); +} + +/* Flush specified CPUs' TLBs */ +void arch_flush_tlb_mask(const cpumask_t *mask); + +#endif /* __ASM_PPC_FLUSHTLB_H__ */ diff --git a/xen/arch/ppc/include/asm/grant_table.h b/xen/arch/ppc/includ= e/asm/grant_table.h new file mode 100644 index 0000000000..e69de29bb2 diff --git a/xen/arch/ppc/include/asm/guest_access.h b/xen/arch/ppc/inclu= de/asm/guest_access.h new file mode 100644 index 0000000000..1919e0566f --- /dev/null +++ b/xen/arch/ppc/include/asm/guest_access.h @@ -0,0 +1,54 @@ +#ifndef __ASM_PPC_GUEST_ACCESS_H__ +#define __ASM_PPC_GUEST_ACCESS_H__ + +#include + +/* TODO */ + +static inline unsigned long raw_copy_to_guest(void *to, const void *from= , unsigned int len) +{ + BUG(); +} +static inline unsigned long raw_copy_to_guest_flush_dcache(void *to, con= st void *from, + unsigned int len) +{ + BUG(); +} +static inline unsigned long raw_copy_from_guest(void *to, const void *fr= om, unsigned int len) +{ + BUG(); +} +static inline unsigned long raw_clear_guest(void *to, unsigned int len) +{ + BUG(); +} + +/* Copy data to guest physical address, then clean the region. */ +static inline unsigned long copy_to_guest_phys_flush_dcache(struct domai= n *d, + paddr_t gpa, + void *buf, + unsigned int len) +{ + BUG(); +} + +static inline int access_guest_memory_by_gpa(struct domain *d, paddr_t g= pa, void *buf, + uint32_t size, bool is_write) +{ + BUG(); +} + + +#define __raw_copy_to_guest raw_copy_to_guest +#define __raw_copy_from_guest raw_copy_from_guest +#define __raw_clear_guest raw_clear_guest + +/* + * Pre-validate a guest handle. + * Allows use of faster __copy_* functions. + */ +/* All PPC guests are paging mode external and hence safe */ +#define guest_handle_okay(hnd, nr) (1) +#define guest_handle_subrange_okay(hnd, first, last) (1) + +#endif /* __ASM_PPC_GUEST_ACCESS_H__ */ diff --git a/xen/arch/ppc/include/asm/guest_atomics.h b/xen/arch/ppc/incl= ude/asm/guest_atomics.h new file mode 100644 index 0000000000..bf4f802a15 --- /dev/null +++ b/xen/arch/ppc/include/asm/guest_atomics.h @@ -0,0 +1,14 @@ +#ifndef __ASM_PPC_GUEST_ATOMICS_H__ +#define __ASM_PPC_GUEST_ATOMICS_H__ + +#include + +/* TODO: implement */ +#define guest_test_bit(d, nr, p) ({ (void) (d); (void) (nr); = (void) (p); BUG(); false; }) +#define guest_clear_bit(d, nr, p) ({ (void) (d); (void) (nr); = (void) (p); BUG(); false; }) +#define guest_set_bit(d, nr, p) ({ (void) (d); (void) (nr); = (void) (p); BUG(); false; }) +#define guest_test_and_set_bit(d, nr, p) ({ (void) (d); (void) (nr); = (void) (p); BUG(); false; }) +#define guest_test_and_clear_bit(d, nr, p) ({ (void) (d); (void) (nr); = (void) (p); BUG(); false; }) +#define guest_test_and_change_bit(d, nr, p) ({ (void) (d); (void) (nr); = (void) (p); BUG(); false; }) + +#endif /* __ASM_PPC_GUEST_ATOMICS_H__ */ diff --git a/xen/arch/ppc/include/asm/hardirq.h b/xen/arch/ppc/include/as= m/hardirq.h new file mode 100644 index 0000000000..51ef290961 --- /dev/null +++ b/xen/arch/ppc/include/asm/hardirq.h @@ -0,0 +1,18 @@ +#ifndef __ASM_PPC_HARDIRQ_H__ +#define __ASM_PPC_HARDIRQ_H__ + +#include + +typedef struct { + unsigned long __softirq_pending; + unsigned int __local_irq_count; +} __cacheline_aligned irq_cpustat_t; + +#include /* Standard mappings for irq_cpustat_t a= bove */ + +#define in_irq() (local_irq_count(smp_processor_id()) !=3D 0) + +#define irq_enter() (local_irq_count(smp_processor_id())++) +#define irq_exit() (local_irq_count(smp_processor_id())--) + +#endif /* __ASM_PPC_HARDIRQ_H__ */ diff --git a/xen/arch/ppc/include/asm/hypercall.h b/xen/arch/ppc/include/= asm/hypercall.h new file mode 100644 index 0000000000..e69de29bb2 diff --git a/xen/arch/ppc/include/asm/io.h b/xen/arch/ppc/include/asm/io.= h new file mode 100644 index 0000000000..f8f3bd6ff7 --- /dev/null +++ b/xen/arch/ppc/include/asm/io.h @@ -0,0 +1,15 @@ +#ifndef __ASM_PPC_IO_H__ +#define __ASM_PPC_IO_H__ + +#include + +/* TODO */ +#define readb(c) ({ (void)(c); BUG(); 0; }) +#define readw(c) ({ (void)(c); BUG(); 0; }) +#define readl(c) ({ (void)(c); BUG(); 0; }) + +#define writeb(v,c) ({ (void)(v); (void)(c); BUG(); }) +#define writew(v,c) ({ (void)(v); (void)(c); BUG(); }) +#define writel(v,c) ({ (void)(v); (void)(c); BUG(); }) + +#endif /* __ASM_PPC_IO_H__ */ diff --git a/xen/arch/ppc/include/asm/iocap.h b/xen/arch/ppc/include/asm/= iocap.h new file mode 100644 index 0000000000..16ae0cf1c8 --- /dev/null +++ b/xen/arch/ppc/include/asm/iocap.h @@ -0,0 +1,7 @@ +#ifndef __ASM_PPC_IOCAP_H__ +#define __ASM_PPC_IOCAP_H__ + +#define cache_flush_permitted(d) \ + (!rangeset_is_empty((d)->iomem_caps)) + +#endif /* __ASM_PPC_IOCAP_H__ */ diff --git a/xen/arch/ppc/include/asm/iommu.h b/xen/arch/ppc/include/asm/= iommu.h new file mode 100644 index 0000000000..fb1a381518 --- /dev/null +++ b/xen/arch/ppc/include/asm/iommu.h @@ -0,0 +1,7 @@ +#ifndef __ASM_PPC_IOMMU_H__ +#define __ASM_PPC_IOMMU_H__ + +struct arch_iommu { +}; + +#endif /* __ASM_PPC_IOMMU_H__ */ diff --git a/xen/arch/ppc/include/asm/irq.h b/xen/arch/ppc/include/asm/ir= q.h new file mode 100644 index 0000000000..99d30dd2bf --- /dev/null +++ b/xen/arch/ppc/include/asm/irq.h @@ -0,0 +1,32 @@ +#ifndef __ASM_PPC_IRQ_H__ +#define __ASM_PPC_IRQ_H__ + +#include +#include +#include + +/* TODO */ +#define nr_irqs 0U +#define nr_static_irqs 0 +#define arch_hwdom_irqs(domid) 0U + +#define domain_pirq_to_irq(d, pirq) (pirq) + +struct arch_pirq { +}; + +struct arch_irq_desc { + unsigned int type; +}; + +static inline void arch_move_irqs(struct vcpu *v) +{ + BUG(); +} + +static inline int platform_get_irq(const struct dt_device_node *device, = int index) +{ + BUG(); +} + +#endif /* __ASM_PPC_IRQ_H__ */ diff --git a/xen/arch/ppc/include/asm/mem_access.h b/xen/arch/ppc/include= /asm/mem_access.h new file mode 100644 index 0000000000..e69de29bb2 diff --git a/xen/arch/ppc/include/asm/mm.h b/xen/arch/ppc/include/asm/mm.= h index 36e44a4356..86e5cbf609 100644 --- a/xen/arch/ppc/include/asm/mm.h +++ b/xen/arch/ppc/include/asm/mm.h @@ -1,19 +1,270 @@ #ifndef _ASM_PPC_MM_H #define _ASM_PPC_MM_H =20 +#include +#include +#include #include #include =20 +void setup_initial_pagetables(void); + +extern unsigned long total_pages; + #define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT) #define paddr_to_pfn(pa) ((unsigned long)((pa) >> PAGE_SHIFT)) +#define paddr_to_pdx(pa) mfn_to_pdx(maddr_to_mfn(pa)) +#define gfn_to_gaddr(gfn) pfn_to_paddr(gfn_x(gfn)) +#define gaddr_to_gfn(ga) _gfn(paddr_to_pfn(ga)) +#define mfn_to_maddr(mfn) pfn_to_paddr(mfn_x(mfn)) +#define maddr_to_mfn(ma) _mfn(paddr_to_pfn(ma)) +#define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) +#define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) =20 #define virt_to_maddr(va) ((paddr_t)((vaddr_t)(va) & PADDR_MASK)) -#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START) +#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START)) =20 /* Convert between Xen-heap virtual addresses and machine addresses. */ #define __pa(x) (virt_to_maddr(x)) #define __va(x) (maddr_to_virt(x)) =20 -void setup_initial_pagetables(void); +/* Convert between Xen-heap virtual addresses and machine frame numbers.= */ +#define __virt_to_mfn(va) (virt_to_maddr(va) >> PAGE_SHIFT) +#define __mfn_to_virt(mfn) (maddr_to_virt((paddr_t)(mfn) << PAGE_SHIFT)) + +/* Convert between Xen-heap virtual addresses and page-info structures. = */ +static inline struct page_info *virt_to_page(const void *v) +{ + BUG(); + return NULL; +} + +/* + * We define non-underscored wrappers for above conversion functions. + * These are overriden in various source files while underscored version + * remain intact. + */ +#define virt_to_mfn(va) __virt_to_mfn(va) +#define mfn_to_virt(mfn) __mfn_to_virt(mfn) + +#define PG_shift(idx) (BITS_PER_LONG - (idx)) +#define PG_mask(x, idx) (x ## UL << PG_shift(idx)) + +#define PGT_none PG_mask(0, 1) /* no special uses of this page= */ +#define PGT_writable_page PG_mask(1, 1) /* has writable mappings? = */ +#define PGT_type_mask PG_mask(1, 1) /* Bits 31 or 63. = */ + + /* 2-bit count of uses of this frame as its current type. */ +#define PGT_count_mask PG_mask(3, 3) + +/* Cleared when the owning guest 'frees' this page. */ +#define _PGC_allocated PG_shift(1) +#define PGC_allocated PG_mask(1, 1) +/* Page is Xen heap? */ +#define _PGC_xen_heap PG_shift(2) +#define PGC_xen_heap PG_mask(1, 2) +/* Page is static memory */ +#define PGC_static 0 +/* Page is broken? */ +#define _PGC_broken PG_shift(7) +#define PGC_broken PG_mask(1, 7) + /* Mutually-exclusive page states: { inuse, offlining, offlined, free }= . */ +#define PGC_state PG_mask(3, 9) +#define PGC_state_inuse PG_mask(0, 9) +#define PGC_state_offlining PG_mask(1, 9) +#define PGC_state_offlined PG_mask(2, 9) +#define PGC_state_free PG_mask(3, 9) +#define page_state_is(pg, st) (((pg)->count_info&PGC_state) =3D=3D PGC_s= tate_##st) +/* Page is not reference counted */ +#define _PGC_extra PG_shift(10) +#define PGC_extra PG_mask(1, 10) + +/* Count of references to this frame. */ +#define PGC_count_width PG_shift(10) +#define PGC_count_mask ((1UL<count_info & PGC_xen_heap) +#define is_xen_heap_mfn(mfn) \ + (mfn_valid(mfn) && is_xen_heap_page(mfn_to_page(mfn))) + +#define is_xen_fixed_mfn(mfn) \ + ((mfn_to_maddr(mfn) >=3D virt_to_maddr(&_start)) && \ + (mfn_to_maddr(mfn) <=3D virt_to_maddr((vaddr_t)_end - 1))) + +#define page_get_owner(_p) (_p)->v.inuse.domain +#define page_set_owner(_p,_d) ((_p)->v.inuse.domain =3D (_d)) + +/* TODO: implement */ +#define mfn_valid(mfn) ({ (void) (mfn); 0; }) +#define max_page ((unsigned long )0) + +#define mfn_to_gfn(d, mfn) ((void)(d), _gfn(mfn_x(mfn))) + +#define domain_set_alloc_bitsize(d) ((void)0) +#define domain_clamp_alloc_bitsize(d, b) (b) + +#define PFN_ORDER(_pfn) ((_pfn)->v.free.order) + +struct page_info +{ + /* Each frame can be threaded onto a doubly-linked list. */ + struct page_list_entry list; + + /* Reference count and various PGC_xxx flags and fields. */ + unsigned long count_info; + + /* Context-dependent fields follow... */ + union { + /* Page is in use: ((count_info & PGC_count_mask) !=3D 0). */ + struct { + /* Type reference count and various PGT_xxx flags and fields= . */ + unsigned long type_info; + } inuse; + /* Page is on a free list: ((count_info & PGC_count_mask) =3D=3D= 0). */ + union { + struct { + /* + * Index of the first *possibly* unscrubbed page in the = buddy. + * One more bit than maximum possible order to accommoda= te + * INVALID_DIRTY_IDX. + */ +#define INVALID_DIRTY_IDX ((1UL << (MAX_ORDER + 1)) - 1) + unsigned long first_dirty:MAX_ORDER + 1; + + /* Do TLBs need flushing for safety before next page use= ? */ + bool need_tlbflush:1; + +#define BUDDY_NOT_SCRUBBING 0 +#define BUDDY_SCRUBBING 1 +#define BUDDY_SCRUB_ABORT 2 + unsigned long scrub_state:2; + }; + + unsigned long val; + } free; + + } u; + + union { + /* Page is in use, but not as a shadow. */ + struct { + /* Owner of this page (zero if page is anonymous). */ + struct domain *domain; + } inuse; + + /* Page is on a free list. */ + struct { + /* Order-size of the free chunk this page is the head of. */ + unsigned int order; + } free; + + } v; + + union { + /* + * Timestamp from 'TLB clock', used to avoid extra safety flushe= s. + * Only valid for: a) free pages, and b) pages with zero type co= unt + */ + u32 tlbflush_timestamp; + }; + u64 pad; +}; + + +#define FRAMETABLE_VIRT_START (XEN_VIRT_START + GB(32)) +#define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) + +/* PDX of the first page in the frame table. */ +extern unsigned long frametable_base_pdx; + +/* Convert between machine frame numbers and page-info structures. */ +#define mfn_to_page(mfn) \ + (frame_table + (mfn_to_pdx(mfn) - frametable_base_pdx)) +#define page_to_mfn(pg) \ + pdx_to_mfn((unsigned long)((pg) - frame_table) + frametable_base_pdx= ) + +static inline void *page_to_virt(const struct page_info *pg) +{ + return mfn_to_virt(mfn_x(page_to_mfn(pg))); +} + +/* + * Common code requires get_page_type and put_page_type. + * We don't care about typecounts so we just do the minimum to make it + * happy. + */ +static inline int get_page_type(struct page_info *page, unsigned long ty= pe) +{ + return 1; +} + +static inline void put_page_type(struct page_info *page) +{ + return; +} + +/* TODO */ +static inline bool get_page_nr(struct page_info *page, const struct doma= in *domain, + unsigned long nr) +{ + BUG(); +} +static inline void put_page_nr(struct page_info *page, unsigned long nr) +{ + BUG(); +} + +static inline void put_page_and_type(struct page_info *page) +{ + put_page_type(page); + put_page(page); +} + +/* + * PPC does not have an M2P, but common code expects a handful of + * M2P-related defines and functions. Provide dummy versions of these. + */ +#define INVALID_M2P_ENTRY (~0UL) +#define SHARED_M2P_ENTRY (~0UL - 1UL) +#define SHARED_M2P(_e) ((_e) =3D=3D SHARED_M2P_ENTRY) + +/* Xen always owns P2M on PPC */ +#define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } wh= ile (0) +#define mfn_to_gfn(d, mfn) ((void)(d), _gfn(mfn_x(mfn))) + +#define PDX_GROUP_SHIFT (16 + 5) + +static inline unsigned long domain_get_maximum_gpfn(struct domain *d) +{ + BUG(); + return 0; +} + +static inline long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) a= rg) +{ + BUG(); + return 0; +} + +static inline unsigned int arch_get_dma_bitsize(void) +{ + return 32; /* TODO */ +} + +/* + * On PPC, all the RAM is currently direct mapped in Xen. + * Hence return always true. + */ +static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned lo= ng nr) +{ + return true; +} =20 #endif /* _ASM_PPC_MM_H */ diff --git a/xen/arch/ppc/include/asm/monitor.h b/xen/arch/ppc/include/as= m/monitor.h new file mode 100644 index 0000000000..f810a367c7 --- /dev/null +++ b/xen/arch/ppc/include/asm/monitor.h @@ -0,0 +1,48 @@ +/* Derived from xen/arch/arm/include/asm/monitor.h */ +#ifndef __ASM_PPC_MONITOR_H__ +#define __ASM_PPC_MONITOR_H__ + +#include + +#include +#include + +static inline +void arch_monitor_allow_userspace(struct domain *d, bool allow_userspace= ) +{ +} + +static inline +int arch_monitor_domctl_op(struct domain *d, struct xen_domctl_monitor_o= p *mop) +{ + /* No arch-specific monitor ops on PPC. */ + return -EOPNOTSUPP; +} + +int arch_monitor_domctl_event(struct domain *d, + struct xen_domctl_monitor_op *mop); + +static inline +int arch_monitor_init_domain(struct domain *d) +{ + /* No arch-specific domain initialization on PPC. */ + return 0; +} + +static inline +void arch_monitor_cleanup_domain(struct domain *d) +{ + /* No arch-specific domain cleanup on PPC. */ +} + +static inline uint32_t arch_monitor_get_capabilities(struct domain *d) +{ + uint32_t capabilities =3D 0; + + capabilities =3D (1U << XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST | + 1U << XEN_DOMCTL_MONITOR_EVENT_PRIVILEGED_CALL); + + return capabilities; +} + +#endif /* __ASM_PPC_MONITOR_H__ */ diff --git a/xen/arch/ppc/include/asm/nospec.h b/xen/arch/ppc/include/asm= /nospec.h new file mode 100644 index 0000000000..4d8ec923e9 --- /dev/null +++ b/xen/arch/ppc/include/asm/nospec.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * From arch/arm/include/asm/nospec.h. + * Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserve= d. + */ +#ifndef __ASM_PPC_NOSPEC_H__ +#define __ASM_PPC_NOSPEC_H__ + +static inline bool evaluate_nospec(bool condition) +{ + return condition; +} + +static inline void block_speculation(void) +{ +} + +#endif /* __ASM_PPC_NOSPEC_H__ */ diff --git a/xen/arch/ppc/include/asm/numa.h b/xen/arch/ppc/include/asm/n= uma.h new file mode 100644 index 0000000000..d857bba2ba --- /dev/null +++ b/xen/arch/ppc/include/asm/numa.h @@ -0,0 +1,26 @@ +#ifndef __ASM_PPC_NUMA_H__ +#define __ASM_PPC_NUMA_H__ + +#include +#include + +typedef uint8_t nodeid_t; + +/* Fake one node for now. See also node_online_map. */ +#define cpu_to_node(cpu) 0 +#define node_to_cpumask(node) (cpu_online_map) + +/* + * TODO: make first_valid_mfn static when NUMA is supported on Arm, this + * is required because the dummy helpers are using it. + */ +extern mfn_t first_valid_mfn; + +/* XXX: implement NUMA support */ +#define node_spanned_pages(nid) (max_page - mfn_x(first_valid_mfn)) +#define node_start_pfn(nid) (mfn_x(first_valid_mfn)) +#define __node_distance(a, b) (20) + +#define arch_want_default_dmazone() (false) + +#endif /* __ASM_PPC_NUMA_H__ */ diff --git a/xen/arch/ppc/include/asm/p2m.h b/xen/arch/ppc/include/asm/p2= m.h new file mode 100644 index 0000000000..851e9f011a --- /dev/null +++ b/xen/arch/ppc/include/asm/p2m.h @@ -0,0 +1,105 @@ +#ifndef __ASM_PPC_P2M_H__ +#define __ASM_PPC_P2M_H__ + +#include + +#define paddr_bits PADDR_BITS + +/* + * List of possible type for each page in the p2m entry. + * The number of available bit per page in the pte for this purpose is 4= bits. + * So it's possible to only have 16 fields. If we run out of value in th= e + * future, it's possible to use higher value for pseudo-type and don't s= tore + * them in the p2m entry. + */ +typedef enum { + p2m_invalid =3D 0, /* Nothing mapped here */ + p2m_ram_rw, /* Normal read/write guest RAM */ + p2m_ram_ro, /* Read-only; writes are silently dropped */ + p2m_mmio_direct_dev,/* Read/write mapping of genuine Device MMIO are= a */ + p2m_mmio_direct_nc, /* Read/write mapping of genuine MMIO area non-c= acheable */ + p2m_mmio_direct_c, /* Read/write mapping of genuine MMIO area cache= able */ + p2m_map_foreign_rw, /* Read/write RAM pages from foreign domain */ + p2m_map_foreign_ro, /* Read-only RAM pages from foreign domain */ + p2m_grant_map_rw, /* Read/write grant mapping */ + p2m_grant_map_ro, /* Read-only grant mapping */ + /* The types below are only used to decide the page attribute in the= P2M */ + p2m_iommu_map_rw, /* Read/write iommu mapping */ + p2m_iommu_map_ro, /* Read-only iommu mapping */ + p2m_max_real_type, /* Types after this won't be store in the p2m */ +} p2m_type_t; + +#include + +static inline int get_page_and_type(struct page_info *page, + struct domain *domain, + unsigned long type) +{ + BUG(); + return 1; +} + +/* Look up a GFN and take a reference count on the backing page. */ +typedef unsigned int p2m_query_t; +#define P2M_ALLOC (1u<<0) /* Populate PoD and paged-out entries */ +#define P2M_UNSHARE (1u<<1) /* Break CoW sharing */ + +static inline struct page_info *get_page_from_gfn( + struct domain *d, unsigned long gfn, p2m_type_t *t, p2m_query_t q) +{ + BUG(); + return NULL; +} + +static inline void memory_type_changed(struct domain *d) +{ + BUG(); +} + + +static inline int guest_physmap_mark_populate_on_demand(struct domain *d= , unsigned long gfn, + unsigned int ord= er) +{ + BUG(); + return 1; +} + +static inline int guest_physmap_add_entry(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned long page_order, + p2m_type_t t) +{ + BUG(); + return 1; +} + +/* Untyped version for RAM only, for compatibility */ +static inline int __must_check +guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, + unsigned int page_order) +{ + return guest_physmap_add_entry(d, gfn, mfn, page_order, p2m_ram_rw); +} + +static inline mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn) +{ + BUG(); + return _mfn(0); +} + +static inline bool arch_acquire_resource_check(struct domain *d) +{ + /* + * The reference counting of foreign entries in set_foreign_p2m_entr= y() + * is supported on PPC. + */ + return true; +} + +static inline void p2m_altp2m_check(struct vcpu *v, uint16_t idx) +{ + /* Not supported on PPC. */ +} + +#endif /* __ASM_PPC_P2M_H__ */ diff --git a/xen/arch/ppc/include/asm/page.h b/xen/arch/ppc/include/asm/p= age.h index e58b0a7354..713630c393 100644 --- a/xen/arch/ppc/include/asm/page.h +++ b/xen/arch/ppc/include/asm/page.h @@ -39,6 +39,9 @@ #define PTE_XEN_RO (PTE_XEN_BASE | PTE_EAA_READ) #define PTE_XEN_RX (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_EXECUTE) =20 +/* TODO */ +#define PAGE_HYPERVISOR 0 + /* * Radix Tree layout for 64KB pages: * @@ -175,4 +178,20 @@ struct prtb_entry { =20 void tlbie_all(void); =20 +static inline void invalidate_icache(void) +{ + BUG(); +} + +#define clear_page(page) memset((void *)(page), 0, PAGE_SIZE) +#define copy_page(dp, sp) memcpy(dp, sp, PAGE_SIZE) + +/* TODO: Flush the dcache for an entire page. */ +static inline void flush_page_to_ram(unsigned long mfn, bool sync_icache= ) +{ + BUG(); +} + +#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) + #endif /* _ASM_PPC_PAGE_H */ diff --git a/xen/arch/ppc/include/asm/paging.h b/xen/arch/ppc/include/asm= /paging.h new file mode 100644 index 0000000000..eccacece29 --- /dev/null +++ b/xen/arch/ppc/include/asm/paging.h @@ -0,0 +1,7 @@ +#ifndef __ASM_PPC_PAGING_H__ +#define __ASM_PPC_PAGING_H__ + +#define paging_mode_translate(d) (1) +#define paging_mode_external(d) (1) + +#endif /* __ASM_PPC_PAGING_H__ */ diff --git a/xen/arch/ppc/include/asm/pci.h b/xen/arch/ppc/include/asm/pc= i.h new file mode 100644 index 0000000000..e76c8e5475 --- /dev/null +++ b/xen/arch/ppc/include/asm/pci.h @@ -0,0 +1,7 @@ +#ifndef __ASM_PPC_PCI_H__ +#define __ASM_PPC_PCI_H__ + +struct arch_pci_dev { +}; + +#endif /* __ASM_PPC_PCI_H__ */ diff --git a/xen/arch/ppc/include/asm/percpu.h b/xen/arch/ppc/include/asm= /percpu.h new file mode 100644 index 0000000000..faae72ee41 --- /dev/null +++ b/xen/arch/ppc/include/asm/percpu.h @@ -0,0 +1,26 @@ +#ifndef __PPC_PERCPU_H__ +#define __PPC_PERCPU_H__ + +#ifndef __ASSEMBLY__ + +#include + +extern char __per_cpu_start[], __per_cpu_data_end[]; +extern unsigned long __per_cpu_offset[NR_CPUS]; +void percpu_init_areas(void); + +#define smp_processor_id() 0 /* TODO: Fix this */ + +#define per_cpu(var, cpu) \ + (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu])) +#define this_cpu(var) \ + (*RELOC_HIDE(&per_cpu__##var, smp_processor_id())) + +#define per_cpu_ptr(var, cpu) \ + (*RELOC_HIDE(var, __per_cpu_offset[cpu])) +#define this_cpu_ptr(var) \ + (*RELOC_HIDE(var, smp_processor_id())) + +#endif + +#endif /* __PPC_PERCPU_H__ */ diff --git a/xen/arch/ppc/include/asm/procarea.h b/xen/arch/ppc/include/a= sm/procarea.h new file mode 100644 index 0000000000..55a358f1e4 --- /dev/null +++ b/xen/arch/ppc/include/asm/procarea.h @@ -0,0 +1,38 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, = USA. + * + * Copyright (C) IBM Corp. 2005 + * + * Authors: Hollis Blanchard + */ + +#ifndef _ASM_PROCAREA_H_ +#define _ASM_PROCAREA_H_ + +#include + +struct vcpu; +struct gdb_state; + +struct processor_area +{ + unsigned int whoami; + unsigned int hard_id; + struct vcpu *cur_vcpu; + void *hyp_stack_base; + unsigned long saved_regs[2]; +}; + +#endif diff --git a/xen/arch/ppc/include/asm/processor.h b/xen/arch/ppc/include/= asm/processor.h index 417288738c..695f98af5b 100644 --- a/xen/arch/ppc/include/asm/processor.h +++ b/xen/arch/ppc/include/asm/processor.h @@ -110,6 +110,10 @@ /* Macro to adjust thread priority for hardware multithreading */ #define HMT_very_low() asm volatile ( "or %r31, %r31, %r31" ) =20 +/* TODO: This isn't correct */ +#define cpu_to_core(_cpu) (0) +#define cpu_to_socket(_cpu) (0) + /* * User-accessible registers: most of these need to be saved/restored * for every nested Xen invocation. @@ -175,6 +179,8 @@ static inline void noreturn die(void) HMT_very_low(); } =20 +#define cpu_relax() asm volatile ( "or %r1, %r1, %r1; or %r2, %r2, %r2" = ) + #endif /* __ASSEMBLY__ */ =20 #endif /* _ASM_PPC_PROCESSOR_H */ diff --git a/xen/arch/ppc/include/asm/random.h b/xen/arch/ppc/include/asm= /random.h new file mode 100644 index 0000000000..2f9e9bbae4 --- /dev/null +++ b/xen/arch/ppc/include/asm/random.h @@ -0,0 +1,9 @@ +#ifndef __ASM_PPC_RANDOM_H__ +#define __ASM_PPC_RANDOM_H__ + +static inline unsigned int arch_get_random(void) +{ + return 0; +} + +#endif /* __ASM_PPC_RANDOM_H__ */ diff --git a/xen/arch/ppc/include/asm/regs.h b/xen/arch/ppc/include/asm/r= egs.h index d5f47a6ff1..68135ca584 100644 --- a/xen/arch/ppc/include/asm/regs.h +++ b/xen/arch/ppc/include/asm/regs.h @@ -23,6 +23,8 @@ #ifndef _ASM_REG_DEFS_H_ #define _ASM_REG_DEFS_H_ =20 +#include + /* Special Purpose Registers */ #define SPRN_VRSAVE 256 #define SPRN_DSISR 18 diff --git a/xen/arch/ppc/include/asm/setup.h b/xen/arch/ppc/include/asm/= setup.h new file mode 100644 index 0000000000..e4f64879b6 --- /dev/null +++ b/xen/arch/ppc/include/asm/setup.h @@ -0,0 +1,6 @@ +#ifndef __ASM_PPC_SETUP_H__ +#define __ASM_PPC_SETUP_H__ + +#define max_init_domid (0) + +#endif /* __ASM_PPC_SETUP_H__ */ diff --git a/xen/arch/ppc/include/asm/smp.h b/xen/arch/ppc/include/asm/sm= p.h new file mode 100644 index 0000000000..eca43f0e6c --- /dev/null +++ b/xen/arch/ppc/include/asm/smp.h @@ -0,0 +1,18 @@ +#ifndef __ASM_SMP_H +#define __ASM_SMP_H + +#include +#include + +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); + +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) + +/* + * Do we, for platform reasons, need to actually keep CPUs online when w= e + * would otherwise prefer them to be off? + */ +#define park_offline_cpus false + +#endif diff --git a/xen/arch/ppc/include/asm/softirq.h b/xen/arch/ppc/include/as= m/softirq.h new file mode 100644 index 0000000000..a0b28a5e51 --- /dev/null +++ b/xen/arch/ppc/include/asm/softirq.h @@ -0,0 +1,8 @@ +#ifndef __ASM_PPC_SOFTIRQ_H__ +#define __ASM_PPC_SOFTIRQ_H__ + +#define NR_ARCH_SOFTIRQS 0 + +#define arch_skip_send_event_check(cpu) 0 + +#endif /* __ASM_PPC_SOFTIRQ_H__ */ diff --git a/xen/arch/ppc/include/asm/spinlock.h b/xen/arch/ppc/include/a= sm/spinlock.h new file mode 100644 index 0000000000..4bdb4b1e98 --- /dev/null +++ b/xen/arch/ppc/include/asm/spinlock.h @@ -0,0 +1,15 @@ +#ifndef __ASM_SPINLOCK_H +#define __ASM_SPINLOCK_H + +#define arch_lock_acquire_barrier() smp_mb() +#define arch_lock_release_barrier() smp_mb() + +#define arch_lock_relax() cpu_relax() +#define arch_lock_signal() +#define arch_lock_signal_wmb() \ +({ \ + smp_wmb(); \ + arch_lock_signal(); \ +}) + +#endif /* __ASM_SPINLOCK_H */ diff --git a/xen/arch/ppc/include/asm/system.h b/xen/arch/ppc/include/asm= /system.h index 94091df644..5adc321e88 100644 --- a/xen/arch/ppc/include/asm/system.h +++ b/xen/arch/ppc/include/asm/system.h @@ -1,6 +1,247 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, = USA. + * + * Copyright (C) IBM Corp. 2005 + * Copyright (C) Raptor Engineering LLC + * + * Authors: Jimi Xenidis + * Shawn Anastasio + */ + #ifndef _ASM_SYSTEM_H_ #define _ASM_SYSTEM_H_ =20 -#define smp_wmb() __asm__ __volatile__ ( "lwsync" : : : "memory" ) +#include +#include +#include +#include +#include +#include + +#define xchg(ptr,x) \ +({ \ + __typeof__(*(ptr)) _x_ =3D (x); \ + (__typeof__(*(ptr))) __xchg((ptr), (unsigned long)_x_, sizeof(*(ptr)));= \ +}) + +#define build_xchg(fn, type, ldinsn, stinsn) \ +static inline unsigned long \ +fn(volatile type *m, unsigned long val) \ +{ \ + unsigned long dummy; \ + \ + __asm__ __volatile__( \ + PPC_ATOMIC_ENTRY_BARRIER \ +"1: " ldinsn " %0,0,%3\n" \ + stinsn " %2,0,%3\n" \ +"2: bne- 1b" \ + PPC_ATOMIC_EXIT_BARRIER \ + : "=3D&r" (dummy), "=3Dm" (*m) \ + : "r" (val), "r" (m) \ + : "cc", "memory"); \ + return dummy; \ +} + +build_xchg(__xchg_u8, uint8_t, "lbarx", "stbcx.") +build_xchg(__xchg_u16, uint16_t, "lharx", "sthcx.") +build_xchg(__xchg_u32, uint32_t, "lwarx", "stwcx.") +build_xchg(__xchg_u64, uint64_t, "ldarx", "stdcx.") + +#undef build_xchg + +/* + * This function doesn't exist, so you'll get a linker error + * if something tries to do an invalid xchg(). + */ +extern void __xchg_called_with_bad_pointer(void); + +static inline unsigned long +__xchg(volatile void *ptr, unsigned long x, int size) +{ + switch (size) { + case 1: + return __xchg_u8(ptr, x); + case 2: + return __xchg_u16(ptr, x); + case 4: + return __xchg_u32(ptr, x); + case 8: + return __xchg_u64(ptr, x); + } + __xchg_called_with_bad_pointer(); + return x; +} + + +static inline unsigned long +__cmpxchg_u32(volatile int *p, int old, int new) +{ + unsigned int prev; + + __asm__ __volatile__ ( + PPC_ATOMIC_ENTRY_BARRIER +"1: lwarx %0,0,%2 # __cmpxchg_u32\n\ + cmpw 0,%0,%3\n\ + bne- 2f\n\ + stwcx. %4,0,%2\n\ + bne- 1b" + PPC_ATOMIC_EXIT_BARRIER + "\n\ +2:" + : "=3D&r" (prev), "=3Dm" (*p) + : "r" (p), "r" (old), "r" (new), "m" (*p) + : "cc", "memory"); + + return prev; +} + +static inline unsigned long +__cmpxchg_u64(volatile long *p, unsigned long old, unsigned long new) +{ + unsigned long prev; + + __asm__ __volatile__ ( + PPC_ATOMIC_ENTRY_BARRIER +"1: ldarx %0,0,%2 # __cmpxchg_u64\n\ + cmpd 0,%0,%3\n\ + bne- 2f\n\ + stdcx. %4,0,%2\n\ + bne- 1b" + PPC_ATOMIC_EXIT_BARRIER + "\n\ +2:" + : "=3D&r" (prev), "=3Dm" (*p) + : "r" (p), "r" (old), "r" (new), "m" (*p) + : "cc", "memory"); + + return prev; +} + +/* This function doesn't exist, so you'll get a linker error + if something tries to do an invalid cmpxchg(). */ +extern void __cmpxchg_called_with_bad_pointer(void); + +static always_inline unsigned long +__cmpxchg(volatile void *ptr, unsigned long old, unsigned long new, int = size) +{ + switch (size) { + case 2: + BUG(); return 0; /* XXX implement __cmpxchg_u16 ? */ + case 4: + return __cmpxchg_u32(ptr, old, new); + case 8: + return __cmpxchg_u64(ptr, old, new); + } + __cmpxchg_called_with_bad_pointer(); + return old; +} + +#define cmpxchg_user(ptr,o,n) cmpxchg(ptr,o,n) + +#define cmpxchg(ptr,o,n) \ + ({ \ + __typeof__(*(ptr)) _o_ =3D (o); \ + __typeof__(*(ptr)) _n_ =3D (n); \ + (__typeof__(*(ptr))) __cmpxchg((ptr), (unsigned long)_o_, \ + (unsigned long)_n_, sizeof(*(ptr))); \ + }) + + +/* + * Memory barrier. + * The sync instruction guarantees that all memory accesses initiated + * by this processor have been performed (with respect to all other + * mechanisms that access memory). The eieio instruction is a barrier + * providing an ordering (separately) for (a) cacheable stores and (b) + * loads and stores to non-cacheable memory (e.g. I/O devices). + * + * mb() prevents loads and stores being reordered across this point. + * rmb() prevents loads being reordered across this point. + * wmb() prevents stores being reordered across this point. + * read_barrier_depends() prevents data-dependent loads being reordered + * across this point (nop on PPC). + * + * We have to use the sync instructions for mb(), since lwsync doesn't + * order loads with respect to previous stores. Lwsync is fine for + * rmb(), though. + * For wmb(), we use sync since wmb is used in drivers to order + * stores to system memory with respect to writes to the device. + * However, smp_wmb() can be a lighter-weight eieio barrier on + * SMP since it is only used to order updates to system memory. + */ +#define mb() __asm__ __volatile__ ("sync" : : : "memory") +#define rmb() __asm__ __volatile__ ("lwsync" : : : "memory") +#define wmb() __asm__ __volatile__ ("sync" : : : "memory") +#define read_barrier_depends() do { } while(0) + +#define set_mb(var, value) do { var =3D value; smp_mb(); } while (0) +#define set_wmb(var, value) do { var =3D value; smp_wmb(); } while (0) + +#define smp_mb__before_atomic() smp_mb() +#define smp_mb__after_atomic() smp_mb() + +#ifdef CONFIG_SMP +#define smp_mb() mb() +#define smp_rmb() rmb() +#define smp_wmb() __asm__ __volatile__ ("lwsync" : : : "memory") +#define smp_read_barrier_depends() read_barrier_depends() +#else +#define smp_mb() __asm__ __volatile__("": : :"memory") +#define smp_rmb() __asm__ __volatile__("": : :"memory") +#define smp_wmb() __asm__ __volatile__("": : :"memory") +#define smp_read_barrier_depends() do { } while(0) +#endif /* CONFIG_SMP */ + +#define local_save_flags(flags) ((flags) =3D mfmsr()) +#define local_irq_restore(flags) do { \ + __asm__ __volatile__("": : :"memory"); \ + mtmsrd((flags)); \ +} while(0) + +static inline void local_irq_disable(void) +{ + unsigned long msr; + msr =3D mfmsr(); + mtmsrd(msr & ~MSR_EE); + __asm__ __volatile__("" : : : "memory"); +} + +static inline void local_irq_enable(void) +{ + unsigned long msr; + __asm__ __volatile__("" : : : "memory"); + msr =3D mfmsr(); + mtmsrd(msr | MSR_EE); +} + +static inline void __do_save_and_cli(unsigned long *flags) +{ + unsigned long msr; + msr =3D mfmsr(); + *flags =3D msr; + mtmsrd(msr & ~MSR_EE); + __asm__ __volatile__("" : : : "memory"); +} + +#define local_irq_save(flags) __do_save_and_cli(&flags) + +static inline int local_irq_is_enabled(void) +{ + return !!(mfmsr() & MSR_EE); +} + +#define arch_fetch_and_add(x, v) __sync_fetch_and_add(x, v) =20 #endif /* _ASM_SYSTEM_H */ diff --git a/xen/arch/ppc/include/asm/time.h b/xen/arch/ppc/include/asm/t= ime.h new file mode 100644 index 0000000000..7872d3c15b --- /dev/null +++ b/xen/arch/ppc/include/asm/time.h @@ -0,0 +1,20 @@ +#ifndef __ASM_PPC_TIME_H__ +#define __ASM_PPC_TIME_H__ + +#include +#include +#include + +struct vcpu; + +/* TODO: implement */ +static inline void force_update_vcpu_system_time(struct vcpu *v) { BUG()= ; } + +typedef unsigned long cycles_t; + +static inline cycles_t get_cycles(void) +{ + return mfspr(SPRN_TBRL); +} + +#endif /* __ASM_PPC_TIME_H__ */ diff --git a/xen/arch/ppc/include/asm/vm_event.h b/xen/arch/ppc/include/a= sm/vm_event.h new file mode 100644 index 0000000000..346653f32a --- /dev/null +++ b/xen/arch/ppc/include/asm/vm_event.h @@ -0,0 +1,49 @@ +#ifndef __ASM_PPC_VM_EVENT_H__ +#define __ASM_PPC_VM_EVENT_H__ + +#include +#include +#include + +static inline int vm_event_init_domain(struct domain *d) +{ + /* Nothing to do. */ + return 0; +} + +static inline void vm_event_cleanup_domain(struct domain *d) +{ + memset(&d->monitor, 0, sizeof(d->monitor)); +} + +static inline void vm_event_toggle_singlestep(struct domain *d, struct v= cpu *v, + vm_event_response_t *rsp) +{ + /* Not supported on PPC. */ +} + +static inline +void vm_event_register_write_resume(struct vcpu *v, vm_event_response_t = *rsp) +{ + /* Not supported on PPC. */ +} + +static inline +void vm_event_emulate_check(struct vcpu *v, vm_event_response_t *rsp) +{ + /* Not supported on PPC. */ +} + +static inline +void vm_event_sync_event(struct vcpu *v, bool value) +{ + /* Not supported on PPC. */ +} + +static inline +void vm_event_reset_vmtrace(struct vcpu *v) +{ + /* Not supported on PPC. */ +} + +#endif /* __ASM_PPC_VM_EVENT_H__ */ diff --git a/xen/arch/ppc/include/asm/xenoprof.h b/xen/arch/ppc/include/a= sm/xenoprof.h new file mode 100644 index 0000000000..e69de29bb2 diff --git a/xen/arch/ppc/mm-radix.c b/xen/arch/ppc/mm-radix.c index 071e71b73e..399898a36d 100644 --- a/xen/arch/ppc/mm-radix.c +++ b/xen/arch/ppc/mm-radix.c @@ -1,13 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include #include +#include #include #include =20 #include #include #include -#include #include #include #include diff --git a/xen/arch/ppc/opal.c b/xen/arch/ppc/opal.c index 396a9e403b..1183b7d5ef 100644 --- a/xen/arch/ppc/opal.c +++ b/xen/arch/ppc/opal.c @@ -1,10 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include "xen/compiler.h" #include #include #include #include -#include #include #include #include diff --git a/xen/arch/ppc/tlb-radix.c b/xen/arch/ppc/tlb-radix.c index 69934076a7..551e8280de 100644 --- a/xen/arch/ppc/tlb-radix.c +++ b/xen/arch/ppc/tlb-radix.c @@ -5,9 +5,9 @@ * * Copyright 2015-2016, Aneesh Kumar K.V, IBM Corporation. */ +#include #include =20 -#include #include #include =20 diff --git a/xen/include/public/hvm/save.h b/xen/include/public/hvm/save.= h index 464ebdb0da..2cf4238daa 100644 --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -89,6 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); #include "../arch-x86/hvm/save.h" #elif defined(__arm__) || defined(__aarch64__) #include "../arch-arm/hvm/save.h" +#elif defined(__powerpc64__) +#include "../arch-ppc.h" #else #error "unsupported architecture" #endif diff --git a/xen/include/public/pmu.h b/xen/include/public/pmu.h index eb87a81e7b..5a176b6ac3 100644 --- a/xen/include/public/pmu.h +++ b/xen/include/public/pmu.h @@ -11,6 +11,8 @@ #include "arch-x86/pmu.h" #elif defined (__arm__) || defined (__aarch64__) #include "arch-arm.h" +#elif defined (__powerpc64__) +#include "arch-ppc.h" #else #error "Unsupported architecture" #endif diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h index 920567e006..b812a0a324 100644 --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -16,6 +16,8 @@ #include "arch-x86/xen.h" #elif defined(__arm__) || defined (__aarch64__) #include "arch-arm.h" +#elif defined(__powerpc64__) +#include "arch-ppc.h" #else #error "Unsupported architecture" #endif --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:03:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:03:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575868.901412 (Exim 4.92) (envelope-from ) id 1qRKsL-0004fy-Nr; Wed, 02 Aug 2023 23:03:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575868.901412; Wed, 02 Aug 2023 23:03:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsL-0004ez-Ea; Wed, 02 Aug 2023 23:03:29 +0000 Received: by outflank-mailman (input) for mailman id 575868; Wed, 02 Aug 2023 23:03:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRKsI-0002ha-KR for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:03:26 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c638a8ca-3188-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 01:03:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 5EAF38285801; Wed, 2 Aug 2023 18:03:20 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xhEj096is2P6; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id CC73F8286986; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id m71qTlx5EDTo; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 0E9CE8285801; Wed, 2 Aug 2023 18:03:19 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c638a8ca-3188-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com CC73F8286986 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691017399; bh=YjlYohwL3eAJPEYKReeeAY3HrxNXgmlGT5VKjdLta3c=; h=From:To:Date:Message-Id:MIME-Version; b=cdIn5slO1nJk9TEPSLCT2MK526NhohahrjwqqMD+D0nH3+kpBVWPq0tgFcLtwlkNW PdJNv2xsda1QqN3Km60VKIu8kUgbjBFGr2PjBiKgAdYxWqJQCXJXz6ZD/JwARqZgN8 WJFDkceDmuzGuglyDWW5NjX2OYomgLbaMTAWZXC0= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH 9/9] xen/ppc: Enable full Xen build Date: Wed, 2 Aug 2023 18:03:05 -0500 Message-Id: <44fe62a196e2621ac88d0f4b9e7ee97bf1874d59.1691016993.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Bring ppc's Makefile and arch.mk in line with arm and x86 to disable the build overrides and enable the full Xen build. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile | 16 +++++++++++++++- xen/arch/ppc/arch.mk | 3 --- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/xen/arch/ppc/Makefile b/xen/arch/ppc/Makefile index 969910b3b6..7b68b5ace2 100644 --- a/xen/arch/ppc/Makefile +++ b/xen/arch/ppc/Makefile @@ -12,10 +12,24 @@ $(TARGET): $(TARGET)-syms cp -f $< $@ =20 $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds - $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ + $(objtree)/common/symbols-dummy.o -o $(dot-target).0 + $(NM) -pa --format=3Dsysv $(dot-target).0 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ + > $(dot-target).0.S + $(MAKE) $(build)=3D$(@D) $(dot-target).0.o + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< \ + $(dot-target).0.o -o $(dot-target).1 + $(NM) -pa --format=3Dsysv $(dot-target).1 \ + | $(objtree)/tools/symbols $(all_symbols) --sysv --sort \ + > $(dot-target).1.S + $(MAKE) $(build)=3D$(@D) $(dot-target).1.o + $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ + $(dot-target).1.o -o $@ $(NM) -pa --format=3Dsysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > $@.map + rm -f $(@D)/.$(@F).[0-9]* =20 $(obj)/xen.lds: $(src)/xen.lds.S FORCE $(call if_changed_dep,cpp_lds_S) diff --git a/xen/arch/ppc/arch.mk b/xen/arch/ppc/arch.mk index d05cbf1df5..917ad0e6a8 100644 --- a/xen/arch/ppc/arch.mk +++ b/xen/arch/ppc/arch.mk @@ -7,6 +7,3 @@ CFLAGS +=3D -m64 -mlittle-endian -mcpu=3D$(ppc-march-y) CFLAGS +=3D -mstrict-align -mcmodel=3Dmedium -mabi=3Delfv2 -fPIC -mno-al= tivec -mno-vsx -msoft-float =20 LDFLAGS +=3D -m elf64lppc - -# TODO: Drop override when more of the build is working -override ALL_OBJS-y =3D arch/$(SRCARCH)/built_in.o common/libfdt/built_i= n.o lib/built_in.o --=20 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 02 23:59:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 02 Aug 2023 23:59:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575909.901436 (Exim 4.92) (envelope-from ) id 1qRLk8-0004kB-85; Wed, 02 Aug 2023 23:59:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575909.901436; Wed, 02 Aug 2023 23:59:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRLk8-0004k4-5I; Wed, 02 Aug 2023 23:59:04 +0000 Received: by outflank-mailman (input) for mailman id 575909; Wed, 02 Aug 2023 23:59:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRLk6-0004jy-HB for xen-devel@lists.xenproject.org; Wed, 02 Aug 2023 23:59:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c6ef2d2-3190-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 01:59:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 091B1601FF; Wed, 2 Aug 2023 23:58:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C2A3C433C7; Wed, 2 Aug 2023 23:58:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c6ef2d2-3190-11ee-b267-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691020738; bh=CGf6zLHod+gBC6eVW+X/5kQwWtgG5PS8YiOXAxpMj6Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=B1G9WbziHbZykkttskmVH/ZyJn0iaSH4zAJXJ3JG3Ybxajyjf+aUm8ieVXTFJsM+V j8xW0MNwoXcudXuvL2E/qcvF4pcyz3f2Jvn3DOGFzSMuM5lna75C+x1ZmFCFaiWc88 3jSuvme6y+nMRXMhJV6vUBqO/9MqvQ4jv3wd1Ux7UlMsK74X7xksigSzstAhy9/aV9 iCMiX6Ctw7P5E8Vd2ja9c+u1Cp0uc2HHamccll9v0Kn5ztPGD9YZkM2cuEWw5AqwtN 5nOcydnK2gGxOUe+QL2MGwKDKq7W/RRX2GL4JMEkP8N89L2WHqUcX7qkaJf9swdwyZ RoCvY0zRu8iMQ== Date: Wed, 2 Aug 2023 16:58:55 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: "Daniel P. Smith" , Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] console: generalize the ability for domU access In-Reply-To: <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> Message-ID: References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Jan Beulich wrote: > > - for ( ; ; ) > > + if ( d == NULL ) > > This covers both Xen receiving input and the domain receiving input having > gone away. Originally in the latter case the next sequential (in domid > numbering) domain would be switched to. In the new logic you start over > from the beginning of the domain list. Such a change in behavior (if > deemed acceptable at all, which I'm not convinced of) needs calling out in > the description. I think it would be best to keep the current behavior as we already have people using it unless we have strong reasons to change it. From xen-devel-bounces@lists.xenproject.org Thu Aug 03 01:40:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 01:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575925.901474 (Exim 4.92) (envelope-from ) id 1qRNJa-0001BO-4H; Thu, 03 Aug 2023 01:39:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575925.901474; Thu, 03 Aug 2023 01:39:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNJZ-0001B2-Up; Thu, 03 Aug 2023 01:39:45 +0000 Received: by outflank-mailman (input) for mailman id 575925; Thu, 03 Aug 2023 01:39:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNJZ-0001As-Ck for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 01:39:45 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e32b50d-319e-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 03:39:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA4B261B71; Thu, 3 Aug 2023 01:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C845C433C8; Thu, 3 Aug 2023 01:39:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e32b50d-319e-11ee-b267-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691026781; bh=cq+sPioqIkCaTlixIBx1YmCuR88cVtypYWRXHYlNyCg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Z+44jwIYxeN6zdEdjp9Wuhq57+o7Qw3p748gm4IePJx2LjxsH0f+/OiVERDXfz1sU 74/AR8Kli9TeMGz0fZhuGNmiUAjNpMXMz2idT/NOgOzkzUu4M0rcSmKkP2wHQSwz9i d1SaIRu9xBV/PSL3JBoJAYWxVfoLMlugkwTYyGvfv/LwRxYoZxwDq5nwWs3fK5F38n DJuAcbwqYroKYp1t37nk4XKkw4BqJfs816YAZgae94pLUzaSG283+E5870hbTzOEhs iIAc1w6gJoAe4PTCdSkd5Ge4c88nz1nGnkfHAI2N7TEOwTvhO3S8zbgDIxGAaZaS+m Wkwno2khz43Nw== Date: Wed, 2 Aug 2023 18:39:38 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Federico Serafini cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH] xen/string: add missing parameter names In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Federico Serafini wrote: > Add missing parameter names to address violations of MISRA C:2012 > Rule 8.2 ("Function types shall be in prototype form with named > parameters"). > > No functional changes. > > Signed-off-by: Federico Serafini > --- > xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h > index b4d2217a96..805947d82b 100644 > --- a/xen/include/xen/string.h > +++ b/xen/include/xen/string.h > @@ -12,27 +12,27 @@ > #define strncpy __xen_has_no_strncpy__ > #define strncat __xen_has_no_strncat__ > > -size_t strlcpy(char *, const char *, size_t); > -size_t strlcat(char *, const char *, size_t); > -int strcmp(const char *, const char *); > -int strncmp(const char *, const char *, size_t); > -int strcasecmp(const char *, const char *); > -int strncasecmp(const char *, const char *, size_t); > -char *strchr(const char *, int); > -char *strrchr(const char *, int); > -char *strstr(const char *, const char *); > -size_t strlen(const char *); > -size_t strnlen(const char *, size_t); > -char *strpbrk(const char *, const char *); > -char *strsep(char **, const char *); > -size_t strspn(const char *, const char *); > - > -void *memset(void *, int, size_t); > -void *memcpy(void *, const void *, size_t); > -void *memmove(void *, const void *, size_t); > -int memcmp(const void *, const void *, size_t); > -void *memchr(const void *, int, size_t); > -void *memchr_inv(const void *, int, size_t); > +size_t strlcpy(char *dest, const char *src, size_t size); > +size_t strlcat(char *dest, const char *src, size_t size); > +int strcmp(const char *cs, const char *ct); > +int strncmp(const char *cs, const char *ct, size_t count); > +int strcasecmp(const char *s1, const char *s2); > +int strncasecmp(const char *s1, const char *s2, size_t len); > +char *strchr(const char *s, int c); > +char *strrchr(const char *s, int c); > +char *strstr(const char *s1, const char *s2); > +size_t strlen(const char *s); > +size_t strnlen(const char *s, size_t count); > +char *strpbrk(const char *cs, const char *ct); > +char *strsep(char **s, const char *ct); > +size_t strspn(const char *s, const char *accept); > + > +void *memset(void *s, int c, size_t n); This should be void *memset(void *s, int c, size_t count); > +void *memcpy(void *dest, const void *src, size_t count); > +void *memmove(void *dest, const void *src, size_t count); > +int memcmp(const void *cs, const void *ct, size_t count); > +void *memchr(const void *s, int c, size_t n); > +void *memchr_inv(const void *s, int c, size_t n); > > #include > > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 01:40:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 01:40:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575927.901484 (Exim 4.92) (envelope-from ) id 1qRNKa-0002XT-Bb; Thu, 03 Aug 2023 01:40:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575927.901484; Thu, 03 Aug 2023 01:40:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNKa-0002XM-7l; Thu, 03 Aug 2023 01:40:48 +0000 Received: by outflank-mailman (input) for mailman id 575927; Thu, 03 Aug 2023 01:40:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNKZ-0002XG-4U for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 01:40:47 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20624.outbound.protection.outlook.com [2a01:111:f400:fe12::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2f5f4f3-319e-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 03:40:44 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAVPR08MB9818.eurprd08.prod.outlook.com (2603:10a6:102:31e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Thu, 3 Aug 2023 01:40:41 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 01:40:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2f5f4f3-319e-11ee-b267-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAOf11muDPiVnMIUhhLHEA7WJU+eB4P7IiIkIvHc9s5vH0dfOWMCtsfiS6H+yKf7kwQPdAitWvufZnV5OUFDhcEHD/b4phjfWzaYgpGZwdRfLRhilxOBgMrG0RXih8+2Z/7qevsWnqREbo63ZZWzzlImukjj61mlzFcKJEg36eSv84/82pbEbeu9jGWv3Kfp0PPgMPNY1y3t5jtX6zlSyV5OBYztDiz5v9hhkbps/eCEeHIXnHvTSn26pU/zV4yl14ivrxyjoTeBSQqNnCStCItyNIzoX7DbPxiZ3t4qoHEK2Z+w4U+vmCEnTaESp4iX3qxVHU2ojoghHkgUXptfyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TalCKGhmv8pur2cReg9h8iMB+kbTlhu4a28bwsjAXY0=; b=lTU4l+wFBN61ohfiKktY4JOwtdGjth0ij447YYtAXE0//G6NIPmw82h9y4MRKMygs3ut2d3MeJ4aT9XT1oq4Q1/Jvxv8x7Fzor874SDktPOzpmqD5pzoI60vDUus197uASyG7gTfIlzhFjFa43CSGNo+kqtRNvnd1xX+/UoadpNo5GUOes+GT7WbGVF5TQ0Qd1Ov+MPoVaD8ndOehSfVTDf17Fo8SzP5WjNBiKmA1vOxoct4wJA52f85mLCdRNPx5L+M/hRpjHjhgqgDBIRAd/0EpN5i4kSQr3WQWsmQam4RZ2F/pPRfLjn2N/OUMdDUsbwUlJxKgSt0mf+EiPsLlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TalCKGhmv8pur2cReg9h8iMB+kbTlhu4a28bwsjAXY0=; b=vkmUfdVEfLWlAPdxCRs8CrhfbhIGkfv/UFD6wvTj1yC3tNMQdV+qTfhG4kNdCS0yOQ9QoSodeavRta7PuJF4ci/RRVguQjv9DdQ0+1NGp/jAkNA9mQLQOSk+HFMbLSh4z1ED7ehh4s1BxYxBXZGAHhaht+Ymh4B7e6CRf4h309Q= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Volodymyr Babchuk , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: RE: [PATCH 2/2] fdt: make fdt handling reusable across arch Thread-Topic: [PATCH 2/2] fdt: make fdt handling reusable across arch Thread-Index: AQHZxJNabMSouWTajUmNjHUgHUELYa/WhhowgADuEQCAAFUFoA== Date: Thu, 3 Aug 2023 01:40:40 +0000 Message-ID: References: <20230801161409.25905-1-dpsmith@apertussolutions.com> <20230801161409.25905-3-dpsmith@apertussolutions.com> <7afba030-48f2-baaf-02f9-dae84107a620@apertussolutions.com> In-Reply-To: <7afba030-48f2-baaf-02f9-dae84107a620@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5AB0CE3F1013594EAA0BA62AF7527390.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAVPR08MB9818:EE_ x-ms-office365-filtering-correlation-id: 7d3b0012-e107-4f0a-b4b3-08db93c2a4e8 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w3OtiOyvHicy0P22wxa/zETrdUBSMtqdIix6IIz146IqgXvWKwGxPSr2RYrTCPguekRJsy+6jbL/UTF5XRbI445Ci6NOBDlXZkQeIT6m377gGzBWEvd/lncG0TzhptrHdDEOEXaITKRs5ZvfFaghihmJHP7R3CgaRxpRIC2RAElAbOLKuFufCaOGeaWNPhUmaN4JILswdrl4uSipXOO31BVPwQsxg8OE02QislG25vM4Z7x3wYn6UQy/1sUeGKu8TnWNapJCMMUebdG//Zdiv0rVQBmlxPN3QgBQFSlYCm3Q3LM0ruczl6wU0d2StyV4LqtGC6nvBdu+1UphzjzIJNMvMzpg/MPacbmhNBzyML8Fe+6YjWBTzlx46fgv7P29EcKWFjwIbiN34RCLJn2YFZvgYNdXckmURm7eFwIpd5G0ru2inI7fl3M152cP5XT6TLHOXy5D8C//WxQ3ZiWwIxtxPIzWiPEySkZ0K3eDrD7axl2OkVdNyiH63Nf99IlDUwZsMs8Mq14NoxaTNJ6bREIkbCimt/desaP7rfQddi+9uw2pVccOATIGR/A+oLRtEuHCokMIKZ4rPka0Yq0t0/xdqpY+1akJX6ACWBxc7nEi79l65skMY3KgbfczeO2h x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(451199021)(66946007)(64756008)(86362001)(66446008)(66476007)(66556008)(7696005)(71200400001)(52536014)(76116006)(9686003)(2906002)(4326008)(54906003)(110136005)(55016003)(33656002)(478600001)(83380400001)(38100700002)(41300700001)(122000001)(5660300002)(8676002)(8936002)(26005)(38070700005)(6506007)(186003)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RnVCczZUUjhVMzRtTWwyYjVFOUdTMjlXRDNGb2VrcFBnazRpU1ZxR3Y1UWMz?= =?utf-8?B?N3ltODJVRlZaWnl6emVaVDcyQTQyMk5qTFh6SGRoN2o3WnE2RjA5NENTcjM0?= =?utf-8?B?UlM4VUtqNlVlaVNNZ2NOa1N2TS9WZlBVaVJVTzFISXdzMkpOVG9GNTllNGUy?= =?utf-8?B?K2pLOVAxYVU2S0JKUjVYSFZRTHVtOU5McEs2czUwTzdpbWQ2L0FTdEo1MjZt?= =?utf-8?B?cmUwK3VPWnlBZUV2dzdzenJ1S1ZvTUVPV3dyaWpUd3I4akdsdE11eVVaTTNL?= =?utf-8?B?MlZsaFdIVDNDNG1SODdLMWpMZGJuaWc2SmF0UjlpWVNuQlZ3ZHM1T3V6dVF5?= =?utf-8?B?OGhQQTVFTWh6eWV0ZmFjWmFEOFZjV0JwVGhDL3h6TmMxbzRZbXNEV3hKWVpv?= =?utf-8?B?K3pPd3I3UDNyWXppOElKL0p0SDlHUW5ZbXpvZzk0WkYrU3dON3Rlb2plRDk4?= =?utf-8?B?WDByVk9KUm84K2h0VG1EbXdMSndIVnBYZFovWGNSeUMwUXk1ZHZ4bTh1aThQ?= =?utf-8?B?NlFkT0tibFErUEhWUnFBa3JaRE9OUkR6NlhtUWZ5TVVGQUxZWmNsT0dvSTNV?= =?utf-8?B?WGx6elVLbGwybFdwTkF0NFprT0NrYm8yS0x1Q29HaWJibEJva1RvbDNZTnhM?= =?utf-8?B?RS9LVFgxbldNUy9JQmpENWNCZUFramZBMzBEdnhkajFRZjZQNmlYcUtqeUVr?= =?utf-8?B?VDlLZW1sVzl1b0NnUHV3aUR2Yyt0WVdNUXIrSnpTcWZKWnM0UnFBcURhejhF?= =?utf-8?B?dDZERWRPMHYybi83a09uUUdxYTBiS05SRFlMRjhiV2QvcTVvVFlENDlCNmIz?= =?utf-8?B?UEQwUm9WOE45bmpMc0MrMTJJL1p1WW5Oa2poM2VRdEozTVdZbjJPa2N5WjJ4?= =?utf-8?B?MmxzT1BKeS84cjJBSkxkcnB6THlWMTR1OTg5alBEQzBZWHNSTnNTVTFRRWps?= =?utf-8?B?bFBlWXA5c1Erb3F2MTRDWElSZWFyRy9EY0FMQS9acTdDV1h2YkZOSkJRWGU5?= =?utf-8?B?cHhLVlBDZE9IdkE2L1R0UWxvUUVjbmNMay8zZU43TkdvOWhZVVpMdEpCNkUx?= =?utf-8?B?R081TW10T0g3b1pFeUR3dlg1ZTBjNFFtbUt0SlRBN3QrN2J3bml2dFBvMVRI?= =?utf-8?B?ejhqSFpMQUg4NCt6N0tFVndIdEY3UXJwQmdZei9aZlE3ZDYvMFdqc2NIOVZs?= =?utf-8?B?UElFcHBpNThJRjBZNTc4NkJMQThSd3poMzZMM0N2dkZ1RkVyTVVKMFdxQTh6?= =?utf-8?B?Mm9pcGI5QXFoVytnYkJPTnZHbFhYZDFneEFBWWhiRXhRNjhZRHNIaks4M3hE?= =?utf-8?B?WFpRMnovMUM1RWVveGlBanpuRXM3anJGOWF4TkpTN1laNHBLS3hHYUk5cEl4?= =?utf-8?B?dTdGTitCQ3Y2SU9udWJpMU52ckdJYUxQMy91QTFMNGNLdVFhZmJFazJpc0h6?= =?utf-8?B?d1JzWmpOT0Z5TUNTTVpkQWlFOVJkRWNGdDZSSk1qMVNvQnp2VWJ5cVAxL2ZK?= =?utf-8?B?NXVLUllWYnBvM0htN2EwR1d6NVRyUncrWVlMNExiQWF3MXZEVDVPdFU4b2Q2?= =?utf-8?B?cmhGUzJrdnIzVlh3T1NQZC9kMVFGamg1QjJrY0xxQUdBTGtlay9pV01kcGgx?= =?utf-8?B?RUllL0JUWDY3U2Z2Z1QyV3VZNWhMS2FWQXNLZGZrejZhMHRvRG85am4xUi9J?= =?utf-8?B?cE1rMXcxV0hnUDJVajBUdVFhOGF1RUJrNHdtNDBMK3U0Nk5CRG9FekQ0aHN1?= =?utf-8?B?NDhTeG9xRmgxUkw4bHJjMU45blQrRVA0WkIzMEVCUngvdndhLzg2aUNtc1dM?= =?utf-8?B?MFVxSUQwUzcxSlFVZ1dwWEF3NmE0NVFHUnozVHRBK1RvUTZCS0ErMDFxbzdB?= =?utf-8?B?b0MvNFZTN0NUUSsyeDB2SlRYQkc0Zk13ZUY5WVR6M01nY1E2NWQ5cTRPQnNN?= =?utf-8?B?WlU2enk2UWM4Mnp5Z2pRVlpjb2FRMjc3NERoNUY2SXNVbkI4aFBIbTF1SkZ1?= =?utf-8?B?aTFiWFozd25iWmlTZkY2MjgyQWF2cmlhNnBlbDR1Vll5amxSeHVTVDNYYUVo?= =?utf-8?B?aWtSbHVlVzVsSjlwMmJPb203ZW41UjlFVWdGUDVXenIwVTNpU2luREticTN4?= =?utf-8?Q?aPURhcB3GkAvB3/zmFodWcPJP?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3b0012-e107-4f0a-b4b3-08db93c2a4e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 01:40:40.2550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BVvNs6d/kBJV9wpiKqPwKxKfO3lrTnLb1r/GKryR8dDonrFEjy5DQldF9pToJQnP9u6p5E+PdhY9jyKBgzzKlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9818 SGkgRGFuaWVsLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggMi8yXSBmZHQ6IG1ha2UgZmR0IGhhbmRsaW5nIHJldXNhYmxlIGFjcm9zcyBhcmNo DQo+ID4gbWFrZTogKioqIFtNYWtlZmlsZToxODM6IF9fc3ViLW1ha2VdIEVycm9yIDINCj4gPiBt YWtlOiBMZWF2aW5nIGRpcmVjdG9yeSAnL2plbmtpbnMvd29ya3NwYWNlL2Fpcy14ZW5iaXRzLQ0K PiB4ZW4vbGF5ZXJzL3hlbi94ZW4nDQo+ID4NCj4gPiBUaGUgc3RhZ2luZyBpdHNlbGYgcGFzc2Vk IHRoZSBDSSBjaGVjay4gRGlkIEkgbWlzcyBzb21lIGNvbnRleHQgdG8gbWFrZQ0KPiA+IHRoaXMg cGF0Y2ggd29ya3M/IENvdWxkIHlvdSBwbGVhc2UgcHJvdmlkZSBzb21lIGhpbnRzPyBUaGFua3Mg aW4gYWR2YW5jZSENCj4gDQo+IE5vcGUgeW91IGFyZSBjb3JyZWN0LCBJIG5vdyBuZWVkIHRvIGdv IGJhY2sgYW5kIGxvb2sgaWYgSSBzZW50IHBhdGNoZXMNCj4gb3V0IG9mIHRoZSB3cm9uZyBicmFu Y2ggb3IgaWYgSSByZWFsbHkgZGlkIG1pc3MgY2xlYW5pbmcgdXAgdGhlIG9yaWdpbmFsDQo+IGRl Y2xhcmF0aW9ucyBpbiB0aGUgQXJtIHRyZWUuIEkgZmFpcmx5IGNvbmZpZGVudCBJIG1hZGUgc3Vy ZSBnaXRsYWItY2kNCj4gcGFzc2VkIGJlZm9yZSBJIGN1dCB0aGUgcGF0Y2hlcyBmb3Igc2VuZGlu ZywgDQoNCkkgdGhpbmsgc28sIGFzIEkgc2F3IHNvbWV0aGluZyByZWxhdGVkIHRvIHRoZSBHaXRs YWItQ0kgcnVubmVycyBkaXNjdXNzaW9uDQppbiBJUkMgeWVzdGVyZGF5Lg0KDQo+IGJ1dCBzaW5j ZSBJIGhhZCB0aHJlZQ0KPiBkaWZmZXJlbnQgc2VyaWVzIGluIGZsaWdodCwgSSBtYXkgaGF2ZSBn b3R0ZW4ganVtYmxlZC4gQXBvbG9naWVzIGZvciB0aGUNCj4gdW5uZWNlc3NhcnkgY2h1cm4gaGVy ZS4NCg0KTm8gcHJvYmxlbSBhdCBhbGwsIEkgYW0gbW9yZSB0aGFuIGhhcHB5IHRvIGRvIHRoZSB0 ZXN0IGZvciB5b3VyDQp2MiBzZXJpZXMgb25jZSBpdCBpcyBpbiB0aGUgbWFpbGluZyBsaXN0IDop KQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiBWL3IsDQo+IERhbmllbCBQLiBTbWl0 aA0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Aug 03 01:40:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 01:40:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575928.901494 (Exim 4.92) (envelope-from ) id 1qRNKk-0002qT-JX; Thu, 03 Aug 2023 01:40:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575928.901494; Thu, 03 Aug 2023 01:40:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNKk-0002qO-FU; Thu, 03 Aug 2023 01:40:58 +0000 Received: by outflank-mailman (input) for mailman id 575928; Thu, 03 Aug 2023 01:40:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNKj-0002pl-6H for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 01:40:57 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8cfc42a-319e-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 03:40:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97E4161B71; Thu, 3 Aug 2023 01:40:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61382C433C7; Thu, 3 Aug 2023 01:40:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8cfc42a-319e-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691026853; bh=Czl4qfeCMTghZNpoaiNGcIqLh3cNDFfqV69KFZU3Np4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pGXLQ0umjDkCzhAPdSjgnRlBjt8qJiwmf5oB7tAbz7FDXFFFyBOlnxbnU77B/4yz6 DCAGDPb2IwqRJW58PYTIhEbrWpMUWqPluQXiC0uqsYJ7/cCz3MgQVwDks4MmTaxzY/ 8X8JOLVMDJwvZwx9Xhww2FiJMG8bHqEgpTT+tBWGwlhq8gAGEk5KhSBNPFrs1nQJb2 LiXw1He8NwmRx2GhzW5XmVNK6WG2riheQpidO0ynPvIyFxReYZgM1EFV4yxQkXSeLx owzy3XgDkdF2+G24vJffLLFrfDAi93IaZfLL21q3e/FIdUVWMc0EhHlIRcsz63SXPh 8VRjF/2lLE80Q== Date: Wed, 2 Aug 2023 18:40:50 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , xen-devel@lists.xenproject.org, xen-devel@dornerworks.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , roberto.bagnara@bugseng.com, "Daniel P. Smith" Subject: Re: [RFC 1/6] dom0: replace explict zero checks In-Reply-To: <3f4c0430-42ce-bb2c-3755-d5f6af8e3b40@suse.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> <3f4c0430-42ce-bb2c-3755-d5f6af8e3b40@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Jan Beulich wrote: > On 02.08.2023 02:24, Stefano Stabellini wrote: > > On Tue, 1 Aug 2023, Daniel P. Smith wrote: > >> --- a/xen/include/xen/sched.h > >> +++ b/xen/include/xen/sched.h > >> @@ -1058,6 +1058,13 @@ void scheduler_disable(void); > >> void watchdog_domain_init(struct domain *d); > >> void watchdog_domain_destroy(struct domain *d); > >> > >> +static always_inline bool is_initial_domain(const struct domain *d) > > > > I know you used always_inline only because is_hardware_domain just below > > also uses it, but I wonder if we need it. > > > > Also, Robero, it looks like always_inline is missing from > > docs/misra/C-language-toolchain.rst? Or do we plan to get rid of it? > > Under "Non-standard tokens" we have both __inline__ and __attribute__ > listed, which I think is enough to cover this specific case as well? I think we should add always_inline explicitely to docs/misra/C-language-toolchain.rst to avoid any doubts about it From xen-devel-bounces@lists.xenproject.org Thu Aug 03 01:41:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 01:41:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575935.901504 (Exim 4.92) (envelope-from ) id 1qRNLX-0003e5-2j; Thu, 03 Aug 2023 01:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575935.901504; Thu, 03 Aug 2023 01:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNLW-0003dy-Vc; Thu, 03 Aug 2023 01:41:46 +0000 Received: by outflank-mailman (input) for mailman id 575935; Thu, 03 Aug 2023 01:41:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNLV-0003di-CU; Thu, 03 Aug 2023 01:41:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNLV-0006Ff-9x; Thu, 03 Aug 2023 01:41:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNLU-00006n-QJ; Thu, 03 Aug 2023 01:41:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRNLU-0005Y5-Oz; Thu, 03 Aug 2023 01:41:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zcBrDb/1JD1tQpkMHOjb4SEB1AjHA6uTCSCpAGuFrCk=; b=fCtLN8dS2cBdBF3tasmKU4l8te tzrVZZmPFn/DXqnavpYKIfgz7nRYbGoIJAZ6W/gnGULMg/igDU1yIl03n9KpH20qzZiCxBjt+6Zqq dFskGBzaBJrUueUVeAXZ7W9XTiqYv8xs1aKxKknqJ/D54QGmwGuK7Zts5xBx0VcjfIXw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182136: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dfc490a3740bb7d6889939934afadcb58891fbce X-Osstest-Versions-That: xen=da55d9dc919752e092e591a74ab54c2f7d5adfab From: osstest service owner Date: Thu, 03 Aug 2023 01:41:44 +0000 flight 182136 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182136/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen dfc490a3740bb7d6889939934afadcb58891fbce baseline version: xen da55d9dc919752e092e591a74ab54c2f7d5adfab Last test of basis 182124 2023-08-02 16:10:28 Z 0 days Testing same since 182136 2023-08-02 22:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Khem Raj jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git da55d9dc91..dfc490a374 dfc490a3740bb7d6889939934afadcb58891fbce -> smoke From xen-devel-bounces@lists.xenproject.org Thu Aug 03 01:45:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 01:45:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575944.901513 (Exim 4.92) (envelope-from ) id 1qRNPO-0004MT-I5; Thu, 03 Aug 2023 01:45:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575944.901513; Thu, 03 Aug 2023 01:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNPO-0004MM-FW; Thu, 03 Aug 2023 01:45:46 +0000 Received: by outflank-mailman (input) for mailman id 575944; Thu, 03 Aug 2023 01:45:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNPM-0004MG-Ol for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 01:45:44 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 735bcd55-319f-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 03:45:40 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A1B7C61BAA; Thu, 3 Aug 2023 01:45:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6182C433C8; Thu, 3 Aug 2023 01:45:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 735bcd55-319f-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691027139; bh=nynb/XD0+dwJaz0ovN23T/F0FlHbEyQJRCUDo7kQ6bs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kq7EAPVxXwmCmmPYRn9WTDWc1jNbqvTHfW5SXL4fFE3BTSs3lQUxj6ENQSMaBf37N tQQjQbbFJDG3zCMAM2TuP1cephKlzu5/rutkb6kWqJE5UrtAwhgmFx54LljfU9mXL2 ldGisjKT2UOiHeROqgHl8TzEbL4r0YBTGWc4+3c33YqFtNXFNZMbEPlp+hO3K6DQ1+ elvBefMqAlpblyhMj4Zcho1dkrDIFeR71Zj3uEO0nKrQRsGbme5qpykFvkOTBiaSDi 3QT7g9l9GsdUMSfpqlLIWKLEcfnbuuZ+ytyvLvSmN6mUgNaeuKNCeLRnaJe8+3Q3l2 uCFpjfkcGMAQg== Date: Wed, 2 Aug 2023 18:45:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 1/4] x86/mce: address MISRA C:2012 Rule 5.3 In-Reply-To: <52ec7caf08089e3aaaad2bcf709a7d387d55d58f.1690969271.git.nicola.vetrini@bugseng.com> Message-ID: References: <52ec7caf08089e3aaaad2bcf709a7d387d55d58f.1690969271.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > Suitable mechanical renames are made to avoid shadowing, thus > addressing violations of MISRA C:2012 Rule 5.3: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > Signed-off-by: Nicola Vetrini > --- > xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- > xen/arch/x86/cpu/mcheck/barrier.h | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/x86/cpu/mcheck/barrier.c b/xen/arch/x86/cpu/mcheck/barrier.c > index a7e5b19a44..51a1d37a76 100644 > --- a/xen/arch/x86/cpu/mcheck/barrier.c > +++ b/xen/arch/x86/cpu/mcheck/barrier.c > @@ -16,11 +16,11 @@ void mce_barrier_dec(struct mce_softirq_barrier *bar) > atomic_dec(&bar->val); > } > > -void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) > +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait) "wait" clashes with xen/common/sched/core.c:wait, which is globally exported, right? I think it would be good to add this info to the commit message in this kind of patches. > { > int gen; > > - if ( !wait ) > + if ( !do_wait ) > return; > atomic_inc(&bar->ingen); > gen = atomic_read(&bar->outgen); > @@ -34,11 +34,11 @@ void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) > } > } > > -void mce_barrier_exit(struct mce_softirq_barrier *bar, bool wait) > +void mce_barrier_exit(struct mce_softirq_barrier *bar, bool do_wait) > { > int gen; > > - if ( !wait ) > + if ( !do_wait ) > return; > atomic_inc(&bar->outgen); > gen = atomic_read(&bar->ingen); > diff --git a/xen/arch/x86/cpu/mcheck/barrier.h b/xen/arch/x86/cpu/mcheck/barrier.h > index c4d52b6192..5cd1b4e4bf 100644 > --- a/xen/arch/x86/cpu/mcheck/barrier.h > +++ b/xen/arch/x86/cpu/mcheck/barrier.h > @@ -32,14 +32,14 @@ void mce_barrier_init(struct mce_softirq_barrier *); > void mce_barrier_dec(struct mce_softirq_barrier *); > > /* > - * If @wait is false, mce_barrier_enter/exit() will return immediately > + * If @do_wait is false, mce_barrier_enter/exit() will return immediately > * without touching the barrier. It's used when handling a > * non-broadcasting MCE (e.g. MCE on some old Intel CPU, MCE on AMD > * CPU and LMCE on Intel Skylake-server CPU) which is received on only > * one CPU and thus does not invoke mce_barrier_enter/exit() calls on > * all CPUs. > * > - * If @wait is true, mce_barrier_enter/exit() will handle the given > + * If @do_wait is true, mce_barrier_enter/exit() will handle the given > * barrier as below. > * > * Increment the generation number and the value. The generation number > @@ -53,8 +53,8 @@ void mce_barrier_dec(struct mce_softirq_barrier *); > * These barrier functions should always be paired, so that the > * counter value will reach 0 again after all CPUs have exited. > */ > -void mce_barrier_enter(struct mce_softirq_barrier *, bool wait); > -void mce_barrier_exit(struct mce_softirq_barrier *, bool wait); > +void mce_barrier_enter(struct mce_softirq_barrier *, bool do_wait); > +void mce_barrier_exit(struct mce_softirq_barrier *, bool do_wait); You might as well add "bar" as first parameter? > void mce_barrier(struct mce_softirq_barrier *); > > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 01:52:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 01:52:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575949.901526 (Exim 4.92) (envelope-from ) id 1qRNVR-0005pi-8M; Thu, 03 Aug 2023 01:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575949.901526; Thu, 03 Aug 2023 01:52:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNVR-0005pb-5C; Thu, 03 Aug 2023 01:52:01 +0000 Received: by outflank-mailman (input) for mailman id 575949; Thu, 03 Aug 2023 01:52:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNVQ-0005pV-6I for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 01:52:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53d8b120-31a0-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 03:51:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED2C561AC0; Thu, 3 Aug 2023 01:51:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1C68C433C8; Thu, 3 Aug 2023 01:51:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53d8b120-31a0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691027515; bh=2IK/EQDswiEIawo9ypafj9tfC/m/hF62pOzQJce9/nk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=LrukKmL/FZdc6411n7wCcaTyIjFhyWisK5MxWve2jYk2kTCHglqmja/5FjUmM5+uV KAL4qYGNE529pIP9BO4O+5/t4vm9unFzNbXlL+Xufkq7gYGSvdgHI+Y3QmfrjNbJRS X/XLlfVAehLIvk0XIDRT9idlnlv08be3AfMRrDbNxhos9T28G6V2hQuXFrb1xRVOZ9 i4ENV1vNiJl8G2g7uyx++TJsza3yj2XbL21SB4bVWiSpkgsed+KgFfRgrp62P7fODL OymgrsqXS94uywvKYg0iOQZ91+hn+1fGxXBtl1dt1iZqD4y1b/k256nBNCyO4bXQ53 1f0EWk541pVqw== Date: Wed, 2 Aug 2023 18:51:52 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 In-Reply-To: <16fa23ecb465442c566a18af0a569092075eef26.1690969271.git.nicola.vetrini@bugseng.com> Message-ID: References: <16fa23ecb465442c566a18af0a569092075eef26.1690969271.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > Rename variables to avoid shadowing and thus address > MISRA C:2012 Rule 5.3: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > No functional changes. > > Signed-off-by: Nicola Vetrini This one clashes with xen/arch/x86/include/asm/mtrr.h:struct mtrr_state right? > --- > xen/arch/x86/hvm/mtrr.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c > index 29f3fb1607..d504d1e43b 100644 > --- a/xen/arch/x86/hvm/mtrr.c > +++ b/xen/arch/x86/hvm/mtrr.c > @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, uint64_t gfn_start, > > static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) > { > - const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr; > + const struct mtrr_state *mtrr = &v->arch.hvm.mtrr; I can see in hvm_vcpu_cacheattr_init, mtrr_get_type and other places that we use: const struct mtrr_state *m maybe that's better? I'll let Jan comment. Anyway, the patch looks correct to me. > struct hvm_hw_mtrr hw_mtrr = { > - .msr_mtrr_def_type = mtrr_state->def_type | > - MASK_INSR(mtrr_state->fixed_enabled, > + .msr_mtrr_def_type = mtrr->def_type | > + MASK_INSR(mtrr->fixed_enabled, > MTRRdefType_FE) | > - MASK_INSR(mtrr_state->enabled, MTRRdefType_E), > - .msr_mtrr_cap = mtrr_state->mtrr_cap, > + MASK_INSR(mtrr->enabled, MTRRdefType_E), > + .msr_mtrr_cap = mtrr->mtrr_cap, > }; > unsigned int i; > > @@ -710,14 +710,14 @@ static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) > > for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) > { > - hw_mtrr.msr_mtrr_var[i * 2] = mtrr_state->var_ranges->base; > - hw_mtrr.msr_mtrr_var[i * 2 + 1] = mtrr_state->var_ranges->mask; > + hw_mtrr.msr_mtrr_var[i * 2] = mtrr->var_ranges->base; > + hw_mtrr.msr_mtrr_var[i * 2 + 1] = mtrr->var_ranges->mask; > } > > BUILD_BUG_ON(sizeof(hw_mtrr.msr_mtrr_fixed) != > - sizeof(mtrr_state->fixed_ranges)); > + sizeof(mtrr->fixed_ranges)); > > - memcpy(hw_mtrr.msr_mtrr_fixed, mtrr_state->fixed_ranges, > + memcpy(hw_mtrr.msr_mtrr_fixed, mtrr->fixed_ranges, > sizeof(hw_mtrr.msr_mtrr_fixed)); > > return hvm_save_entry(MTRR, v->vcpu_id, h, &hw_mtrr); > @@ -727,7 +727,7 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) > { > unsigned int vcpuid, i; > struct vcpu *v; > - struct mtrr_state *mtrr_state; > + struct mtrr_state *mtrr; > struct hvm_hw_mtrr hw_mtrr; > > vcpuid = hvm_load_instance(h); > @@ -749,26 +749,26 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) > return -EINVAL; > } > > - mtrr_state = &v->arch.hvm.mtrr; > + mtrr = &v->arch.hvm.mtrr; > > hvm_set_guest_pat(v, hw_mtrr.msr_pat_cr); > > - mtrr_state->mtrr_cap = hw_mtrr.msr_mtrr_cap; > + mtrr->mtrr_cap = hw_mtrr.msr_mtrr_cap; > > for ( i = 0; i < NUM_FIXED_MSR; i++ ) > - mtrr_fix_range_msr_set(d, mtrr_state, i, hw_mtrr.msr_mtrr_fixed[i]); > + mtrr_fix_range_msr_set(d, mtrr, i, hw_mtrr.msr_mtrr_fixed[i]); > > for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) > { > - mtrr_var_range_msr_set(d, mtrr_state, > + mtrr_var_range_msr_set(d, mtrr, > MSR_IA32_MTRR_PHYSBASE(i), > hw_mtrr.msr_mtrr_var[i * 2]); > - mtrr_var_range_msr_set(d, mtrr_state, > + mtrr_var_range_msr_set(d, mtrr, > MSR_IA32_MTRR_PHYSMASK(i), > hw_mtrr.msr_mtrr_var[i * 2 + 1]); > } > > - mtrr_def_type_msr_set(d, mtrr_state, hw_mtrr.msr_mtrr_def_type); > + mtrr_def_type_msr_set(d, mtrr, hw_mtrr.msr_mtrr_def_type); > > return 0; > } > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:00:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575954.901540 (Exim 4.92) (envelope-from ) id 1qRNdS-0007pt-36; Thu, 03 Aug 2023 02:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575954.901540; Thu, 03 Aug 2023 02:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNdS-0007pl-02; Thu, 03 Aug 2023 02:00:18 +0000 Received: by outflank-mailman (input) for mailman id 575954; Thu, 03 Aug 2023 02:00:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNdR-0007pf-8V for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:00:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c72e0fa-31a1-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 04:00:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D841A61069; Thu, 3 Aug 2023 02:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1A47C433C8; Thu, 3 Aug 2023 02:00:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c72e0fa-31a1-11ee-b267-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691028013; bh=8V7IIqQLl9s20Gt2MiDLHn34a5YPUaUtQhF0fee8D7U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FaqR3DxxRTSiU7rMxUnBDTpcteqIBBtJUuqDFGWdBng7tvHbYxfgo20/4fVT0RJJT JP0zigJtuIYio6DzJLGIGv0Fq56eZRxxJYCLRU4SXOWTNWzAq6rjFsQ5VwPb+0vVAc Xr365xYx17Cx+K6ur3KNdqCWvUdnvNA2WNDpBEpFeMoIT0AoLVJpa3MS/oNeI3hQT2 BBNUWqizuw53Y5/ayKBsw9xPIxCVwpbsiiOJ+7pa1lphOUqrkNBbjKB6Gl2NNvhgxO VM74NO23b+7P3amP3EIrLxfU1wrWTHrE9T/+ft7erJD4acj4TGZig1yphFuOlvVYB9 0/h087a+qUuuQ== Date: Wed, 2 Aug 2023 19:00:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: Re: [XEN PATCH 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > The extern variable 'irq_desc' defined in 'irq.h' is shadowed by > local variables in the changed file. To avoid this, the variable is > renamed to 'irq_description'. > > No functional change. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > xen/arch/x86/hvm/hvm.c | 2 +- > xen/arch/x86/include/asm/irq.h | 2 +- > xen/arch/x86/io_apic.c | 10 +++++----- > xen/arch/x86/irq.c | 12 ++++++------ > xen/arch/x86/msi.c | 4 ++-- > xen/include/xen/irq.h | 2 +- > 6 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 2180abeb33..ca5bb96388 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -474,7 +474,7 @@ void hvm_migrate_pirq(struct hvm_pirq_dpci *pirq_dpci, const struct vcpu *v) > > if ( !desc ) > return; > - ASSERT(MSI_IRQ(desc - irq_desc)); > + ASSERT(MSI_IRQ(desc - irq_descriptor)); > irq_set_affinity(desc, cpumask_of(v->processor)); > spin_unlock_irq(&desc->lock); > } > diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h > index ad907fc97f..f6df977170 100644 > --- a/xen/arch/x86/include/asm/irq.h > +++ b/xen/arch/x86/include/asm/irq.h > @@ -172,7 +172,7 @@ int assign_irq_vector(int irq, const cpumask_t *mask); > > void cf_check irq_complete_move(struct irq_desc *desc); > > -extern struct irq_desc *irq_desc; > +extern struct irq_desc *irq_descriptor; > > void lock_vector_lock(void); > void unlock_vector_lock(void); > diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c > index b3afef8933..b59d6cfb9e 100644 > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -990,9 +990,9 @@ static inline void ioapic_register_intr(int irq, unsigned long trigger) > { > if ((trigger == IOAPIC_AUTO && IO_APIC_irq_trigger(irq)) || > trigger == IOAPIC_LEVEL) > - irq_desc[irq].handler = &ioapic_level_type; > + irq_descriptor[irq].handler = &ioapic_level_type; > else > - irq_desc[irq].handler = &ioapic_edge_type; > + irq_descriptor[irq].handler = &ioapic_edge_type; > } > > static void __init setup_IO_APIC_irqs(void) > @@ -1098,7 +1098,7 @@ static void __init setup_ExtINT_IRQ0_pin(unsigned int apic, unsigned int pin, in > * The timer IRQ doesn't have to know that behind the > * scene we have a 8259A-master in AEOI mode ... > */ > - irq_desc[0].handler = &ioapic_edge_type; > + irq_descriptor[0].handler = &ioapic_edge_type; > > /* > * Add it to the IO-APIC irq-routing table: > @@ -1912,7 +1912,7 @@ static void __init check_timer(void) > if ((ret = bind_irq_vector(0, vector, &cpumask_all))) > printk(KERN_ERR"..IRQ0 is not set correctly with ioapic!!!, err:%d\n", ret); > > - irq_desc[0].status &= ~IRQ_DISABLED; > + irq_descriptor[0].status &= ~IRQ_DISABLED; > > /* > * Subtle, code in do_timer_interrupt() expects an AEOI > @@ -2009,7 +2009,7 @@ static void __init check_timer(void) > printk(KERN_INFO "...trying to set up timer as Virtual Wire IRQ..."); > > disable_8259A_irq(irq_to_desc(0)); > - irq_desc[0].handler = &lapic_irq_type; > + irq_descriptor[0].handler = &lapic_irq_type; > apic_write(APIC_LVT0, APIC_DM_FIXED | vector); /* Fixed mode */ > enable_8259A_irq(irq_to_desc(0)); > > diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c > index 6abfd81621..ed95896bce 100644 > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -45,7 +45,7 @@ integer_param("irq-max-guests", irq_max_guests); > > vmask_t global_used_vector_map; > > -struct irq_desc __read_mostly *irq_desc = NULL; > +struct irq_desc __read_mostly *irq_descriptor = NULL; > > static DECLARE_BITMAP(used_vectors, X86_NR_VECTORS); > > @@ -424,9 +424,9 @@ int __init init_irq_data(void) > for ( vector = 0; vector < X86_NR_VECTORS; ++vector ) > this_cpu(vector_irq)[vector] = INT_MIN; > > - irq_desc = xzalloc_array(struct irq_desc, nr_irqs); > - > - if ( !irq_desc ) > + irq_descriptor = xzalloc_array(struct irq_desc, nr_irqs); > + > + if ( !irq_descriptor ) > return -ENOMEM; > > for ( irq = 0; irq < nr_irqs_gsi; irq++ ) > @@ -1133,7 +1133,7 @@ static void cf_check set_eoi_ready(void *data); > static void cf_check irq_guest_eoi_timer_fn(void *data) > { > struct irq_desc *desc = data; > - unsigned int i, irq = desc - irq_desc; > + unsigned int i, irq = desc - irq_descriptor; > irq_guest_action_t *action; > > spin_lock_irq(&desc->lock); > @@ -1382,7 +1382,7 @@ static void __set_eoi_ready(const struct irq_desc *desc) > struct pending_eoi *peoi = this_cpu(pending_eoi); > int irq, sp; > > - irq = desc - irq_desc; > + irq = desc - irq_descriptor; > > if ( !action || action->in_flight || > !cpumask_test_and_clear_cpu(smp_processor_id(), > diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c > index d0bf63df1d..35d417c63a 100644 > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -1322,7 +1322,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) > unsigned int i = 0, nr = 1; > > irq = entry->irq; > - desc = &irq_desc[irq]; > + desc = &irq_descriptor[irq]; > > spin_lock_irqsave(&desc->lock, flags); > > @@ -1377,7 +1377,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) > break; > > spin_unlock_irqrestore(&desc->lock, flags); > - desc = &irq_desc[entry[++i].irq]; > + desc = &irq_descriptor[entry[++i].irq]; > spin_lock_irqsave(&desc->lock, flags); > if ( desc->msi_desc != entry + i ) > goto bogus; > diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h > index 9747e818f7..56a3aa6a29 100644 > --- a/xen/include/xen/irq.h > +++ b/xen/include/xen/irq.h > @@ -107,7 +107,7 @@ typedef struct irq_desc { > } __cacheline_aligned irq_desc_t; > > #ifndef irq_to_desc > -#define irq_to_desc(irq) (&irq_desc[irq]) > +#define irq_to_desc(irq) (&irq_descriptor[irq]) > #endif > > int init_one_irq_desc(struct irq_desc *desc); > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:05:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575958.901549 (Exim 4.92) (envelope-from ) id 1qRNiW-0008SB-L8; Thu, 03 Aug 2023 02:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575958.901549; Thu, 03 Aug 2023 02:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNiW-0008S4-IS; Thu, 03 Aug 2023 02:05:32 +0000 Received: by outflank-mailman (input) for mailman id 575958; Thu, 03 Aug 2023 02:05:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNiV-0008Rv-JR for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:05:31 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 382cbd67-31a2-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 04:05:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A519761BA2; Thu, 3 Aug 2023 02:05:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A19BBC433C8; Thu, 3 Aug 2023 02:05:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 382cbd67-31a2-11ee-b267-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691028328; bh=GBnPtI8PPafHynrWGs1h9p7I5P+S0S74fgmbouf7Akk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jTNIGRUA/7SA20mvd8KIEbzOu3R1smFpiTq8qMzyZRFWE8rxcrIZag5lATckdbtcb AA+HditFPJJwZFYJtXfH3jltqYUNLH1ntaWc4fZtjznuZ9/xJh9V9XDLdWGyLICBj4 Kmz8s0TnGSXkNZywiZJSu092QXsLhu0BTf6cFQwP9XmmiGsJv7gqbnrIKPifmvuVl0 DT4uZm0GrumkjLdt77DKEEMjpU8J4hQoy2Uiox9TeIhrzIWOgMNxcIy1wDemHZ+/xA jYoIxlg4OxehOGhq5DVqhhYL92NguEKXYKntKsYSy+TSqVnGHUs0IfO63MMiKPFMX0 jr/qy3aykPd6A== Date: Wed, 2 Aug 2023 19:05:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 4/4] x86/setup: address MISRA C:2012 Rule 5.3 In-Reply-To: <807b238780c3e2dfce785c6bb173099a4bd38e4b.1690969271.git.nicola.vetrini@bugseng.com> Message-ID: References: <807b238780c3e2dfce785c6bb173099a4bd38e4b.1690969271.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > The parameters renamed in the function declaration caused shadowing > with the homonymous variable in 'xen/common/efi/boot.c'. Renaming > them also addresses Rule 8.3: > "All declarations of an object or function shall use the same names > and type qualifiers". > > The local variable 'mask' is removed because it shadows the homonymous > variable defined in an outer scope, with no change to the semantics. > It was introduced by commit 5a771800114c437fb857b44b3ed74f60e87979c2 > as a refactoring of the branch that handles 'CONFIG_X86_64' for function > '__start_xen'. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > xen/arch/x86/include/asm/setup.h | 2 +- > xen/arch/x86/setup.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h > index 51fce66607..b0e6a39e23 100644 > --- a/xen/arch/x86/include/asm/setup.h > +++ b/xen/arch/x86/include/asm/setup.h > @@ -33,7 +33,7 @@ static inline void vesa_init(void) {}; > > int construct_dom0( > struct domain *d, > - const module_t *kernel, unsigned long kernel_headroom, > + const module_t *image, unsigned long image_headroom, > module_t *initrd, > const char *cmdline); > void setup_io_bitmap(struct domain *d); > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 2dbe9857aa..80ae973d64 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1577,8 +1577,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > s = map_s; > if ( s < map_e ) > { > - uint64_t mask = (1UL << L2_PAGETABLE_SHIFT) - 1; > - > + mask = (1UL << L2_PAGETABLE_SHIFT) - 1; > map_s = (s + mask) & ~mask; > map_e &= ~mask; > init_boot_pages(map_s, map_e); > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:08:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575964.901563 (Exim 4.92) (envelope-from ) id 1qRNlT-0000gc-8Q; Thu, 03 Aug 2023 02:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575964.901563; Thu, 03 Aug 2023 02:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNlT-0000gV-4g; Thu, 03 Aug 2023 02:08:35 +0000 Received: by outflank-mailman (input) for mailman id 575964; Thu, 03 Aug 2023 02:08:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNlR-0000gL-L5 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:08:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3fa6c0f-31a2-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 04:08:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B748F61A55; Thu, 3 Aug 2023 02:08:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4B98C433C8; Thu, 3 Aug 2023 02:08:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3fa6c0f-31a2-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691028509; bh=aA4v9h6t6gO/CizV6u27fPJ0WGPVWaL/wPZimXZ9TTk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AZ5jQHaSAx8zb39wSfyXbgqcZx/tMUjunnIR7lpJoLCByPab88TkYaVbZpREGYpTD nnufxQ6hIVQoNZjNEzuHlZTes+9G5ydPwH7Ik7ly/ax+7AXM6Gc3Paglo5b8U9i9hc G6PAaAiIyiO7mBgGHGdSBbRUn/BeE3chFOEgmWCb5AFbdAxsUmpc/4RMa1xPaLTUBD TXkS7jrXJ+9yCHoJtKfOS2xOqDwmOW4RyNGbpBshpU9wxTCVqunJPTxgeeihfCCE0d odTZvybce7JkxMHnxiemGWsnrR2znRU6ndpbA8mOiPHuJzWu54Qy3ZcnAvXgntRS5J S/XNi6SyGAVkg== Date: Wed, 2 Aug 2023 19:08:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 01/11] x86/efi: move variable declaration to address MISRA C:2012 Rule 2.1 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > The variable declaration is moved where it's actually used, rather > than being declared in the switch before any clause, thus being > classified as unreachable code. > > No functional changes. > > Signed-off-by: Nicola Vetrini > --- > xen/arch/x86/efi/efi-boot.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > index 92f4cfe8bd..b00441b1a2 100644 > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -390,8 +390,6 @@ static void __init efi_arch_edd(void) > { > switch ( DevicePathType(devp.DevPath) ) > { > - const u8 *p; > - > case ACPI_DEVICE_PATH: > if ( state != root || boot_edd_info_nr > EDD_INFO_MAX ) > break; > @@ -463,7 +461,8 @@ static void __init efi_arch_edd(void) > params->device_path_info_length = > sizeof(struct edd_device_params) - > offsetof(struct edd_device_params, key); > - for ( p = (const u8 *)¶ms->key; p < ¶ms->checksum; ++p ) > + for ( const u8 *p = (const u8 *)¶ms->key; > + p < ¶ms->checksum; ++p ) In Xen we don't mix declaration and code. So the following is not something we use: for (int i = 0; i < 10; i++) I think you'd have to introduce another block under case MESSAGING_DEVICE_PATH so that you can moved const u8 *p there > params->checksum -= *p; > break; > case MEDIA_DEVICE_PATH: > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:13:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575969.901575 (Exim 4.92) (envelope-from ) id 1qRNqH-00028Q-Q0; Thu, 03 Aug 2023 02:13:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575969.901575; Thu, 03 Aug 2023 02:13:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNqH-00028J-NP; Thu, 03 Aug 2023 02:13:33 +0000 Received: by outflank-mailman (input) for mailman id 575969; Thu, 03 Aug 2023 02:13:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNqG-00028D-Vv for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:13:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 570b0f5c-31a3-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 04:13:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF50761069; Thu, 3 Aug 2023 02:13:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0AF7C433C8; Thu, 3 Aug 2023 02:13:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 570b0f5c-31a3-11ee-b267-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691028809; bh=mHiAOK+yWX5612sP3VmpYF6Q8GiD9sWY3VWtK0hgF7w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=skQgGv7XFoePf6wxt5S7WJikW/sEbGi3/IxuB4l4IhuLmjR2qtJBBT8FSAJ6Ny6sl fLJ+x5Vm9Tsa6QGrlpT1+ujh3ukKGhia1TfLcsW57ZnLDQ5qdPe1jYMM70JMPuaY12 +i5LQd46uT9eyfVZxW4BZC5nnt27UPoKRUhQ5FCXLRSTfEfVt2sN5NGz6uJxy3TB/a KWHVZY6RoEhiQ7cz4OzixlkE4XdMbJ0+pIMMgJxMhZ5fFTk1dhtXCZJrUJkKF9qDcm yjhRZI4At9C5h7dG2XTKm2Stj5L8QRf8khzzIlSSe3eS27HxCJLdWj57BvIAyckcKZ uCTqJYZy3+WDg== Date: Wed, 2 Aug 2023 19:13:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> Message-ID: References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > Variable declarations between a switch statement guard and before > any case label are unreachable code, and hence violate Rule 2.1: > "A project shall not contain unreachable code". > > Therefore the declarations are moved in the smallest enclosing > scope, near other variable definitions. > > Signed-off-by: Nicola Vetrini > --- > xen/arch/x86/cpuid.c | 3 +-- > xen/arch/x86/domain.c | 23 +++++++++++------------ > xen/arch/x86/irq.c | 3 +-- > xen/arch/x86/msr.c | 3 +-- > 4 files changed, 14 insertions(+), 18 deletions(-) > > diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c > index 455a09b2dd..90e1370e90 100644 > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -37,6 +37,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, > { > const struct domain *d = v->domain; > const struct cpu_policy *p = d->arch.cpu_policy; > + const struct cpu_user_regs *regs; > > *res = EMPTY_LEAF; > > @@ -136,8 +137,6 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, > */ > switch ( leaf ) > { > - const struct cpu_user_regs *regs; > - > case 0x1: > /* TODO: Rework topology logic. */ > res->b &= 0x00ffffffu; > diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c > index 5f66c2ae33..015f7b14ab 100644 > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -2268,6 +2268,17 @@ int domain_relinquish_resources(struct domain *d) > { > int ret; > struct vcpu *v; > + enum { > + PROG_iommu_pagetables = 1, > + PROG_shared, > + PROG_paging, > + PROG_vcpu_pagetables, > + PROG_xen, > + PROG_l4, > + PROG_l3, > + PROG_l2, > + PROG_done, > + }; > > BUG_ON(!cpumask_empty(d->dirty_cpumask)); > > @@ -2291,18 +2302,6 @@ int domain_relinquish_resources(struct domain *d) > #define PROGRESS(x) \ > d->arch.rel_priv = PROG_ ## x; /* Fallthrough */ case PROG_ ## x > > - enum { > - PROG_iommu_pagetables = 1, > - PROG_shared, > - PROG_paging, > - PROG_vcpu_pagetables, > - PROG_xen, > - PROG_l4, > - PROG_l3, > - PROG_l2, > - PROG_done, > - }; > - > case 0: > ret = pci_release_devices(d); > if ( ret ) > diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c > index 6abfd81621..4fd0cc163d 100644 > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -1135,6 +1135,7 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) > struct irq_desc *desc = data; > unsigned int i, irq = desc - irq_desc; > irq_guest_action_t *action; > + cpumask_t *cpu_eoi_map; > > spin_lock_irq(&desc->lock); > > @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) > > switch ( action->ack_type ) > { > - cpumask_t *cpu_eoi_map; It is only used by case ACKTYPE_EOI so it can be moved there (with a new block): case ACKTYPE_EOI: { cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); spin_unlock_irq(&desc->lock); on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); return; } } > case ACKTYPE_UNMASK: > if ( desc->handler->end ) > desc->handler->end(desc, 0); > diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > index ecf126566d..0e61e0fe4e 100644 > --- a/xen/arch/x86/msr.c > +++ b/xen/arch/x86/msr.c > @@ -335,11 +335,10 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) > const struct cpu_policy *cp = d->arch.cpu_policy; > struct vcpu_msrs *msrs = v->arch.msrs; > int ret = X86EMUL_OKAY; > + uint64_t rsvd; > > switch ( msr ) > { > - uint64_t rsvd; > - It is only used by case MSR_INTEL_MISC_FEATURES_ENABLES so it can be moved there > /* Read-only */ > case MSR_IA32_PLATFORM_ID: > case MSR_CORE_CAPABILITIES: > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:14:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:14:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575970.901586 (Exim 4.92) (envelope-from ) id 1qRNr4-0002dp-36; Thu, 03 Aug 2023 02:14:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575970.901586; Thu, 03 Aug 2023 02:14:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNr4-0002di-0F; Thu, 03 Aug 2023 02:14:22 +0000 Received: by outflank-mailman (input) for mailman id 575970; Thu, 03 Aug 2023 02:14:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRNr3-0002da-Dv for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:14:21 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73737b75-31a3-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 04:14:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CD1B261069; Thu, 3 Aug 2023 02:14:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7C8FC433C8; Thu, 3 Aug 2023 02:14:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73737b75-31a3-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691028857; bh=fv9ZSf3cy7anxtXJVausBOb/A4E4rO2D1oyZ7XzEenE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kwIWMVPAS9kfIQrlvQ74ZE53SON1HeViR3CFAQw5UmZUyCmsIQjSs9mUeQpzosbRu rkTh9SM4VLtziDAKiamADCawGOhMlXbEcohAtJLqzQTE6RsuBfIz7N2BG80VBl6Oct Ph7f/OKcqiD3AYUzugbaxNBmUPtUTP6K0evBpxmkJJSUk5kYTaz+xEmzN7GTOtPLEH d6otn27i61FOLFrqE5r3AJ7KAu6hgBOhpljarACWwtG/uO0ZFvKbfM1Gm+XpO/6S2t ihk0akY+lIsTbGeLjCQNkBX5Vq70VLkEmQeGP/KInIw/34i5AS30aLVplAe+IzANIO 95glttTXFR7tw== Date: Wed, 2 Aug 2023 19:14:14 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 03/11] x86/uaccess: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: <6d5e4f307b360393e29641d727ef78b697643f47.1690985045.git.nicola.vetrini@bugseng.com> Message-ID: References: <6d5e4f307b360393e29641d727ef78b697643f47.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > The variable declarations inside macros {put,get}_unsafe_size are > considered unreachable code, as they appear in a switch statement, before > any clause. They are moved in the enclosing scope to resolve the violation. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > xen/arch/x86/include/asm/uaccess.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/include/asm/uaccess.h b/xen/arch/x86/include/asm/uaccess.h > index 684fccd95c..a2aaab1e87 100644 > --- a/xen/arch/x86/include/asm/uaccess.h > +++ b/xen/arch/x86/include/asm/uaccess.h > @@ -191,11 +191,12 @@ struct __large_struct { unsigned long buf[100]; }; > > #define put_unsafe_size(x, ptr, size, grd, retval, errret) \ > do { \ > + long dummy_; \ > + \ > retval = 0; \ > stac(); \ > switch ( size ) \ > { \ > - long dummy_; \ > case 1: \ > put_unsafe_asm(x, ptr, grd, retval, "b", "b", "iq", errret); \ > break; \ > @@ -218,11 +219,12 @@ do { \ > > #define get_unsafe_size(x, ptr, size, grd, retval, errret) \ > do { \ > + long dummy_; \ > + \ > retval = 0; \ > stac(); \ > switch ( size ) \ > { \ > - long dummy_; \ > case 1: get_unsafe_asm(x, ptr, grd, retval, "b", "=q", errret); break; \ > case 2: get_unsafe_asm(x, ptr, grd, retval, "w", "=r", errret); break; \ > case 4: get_unsafe_asm(x, ptr, grd, retval, "k", "=r", errret); break; \ > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:33:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:33:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575979.901601 (Exim 4.92) (envelope-from ) id 1qRO9N-0005DL-LR; Thu, 03 Aug 2023 02:33:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575979.901601; Thu, 03 Aug 2023 02:33:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRO9N-0005DE-Ip; Thu, 03 Aug 2023 02:33:17 +0000 Received: by outflank-mailman (input) for mailman id 575979; Thu, 03 Aug 2023 02:33:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRO9M-0005D8-8r for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:33:16 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18582948-31a6-11ee-b267-6b7b168915f2; Thu, 03 Aug 2023 04:33:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20E6261BB0; Thu, 3 Aug 2023 02:33:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04C69C433C8; Thu, 3 Aug 2023 02:33:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18582948-31a6-11ee-b267-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691029992; bh=J4i76pf8BZVyTZBwFcrYkyQx+BbOr+RRV7ik23DZfVs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=h0hnAjYLRQFjlJpj2Z3bh7pzWKjRYq/w56ObbTBqcvV3HaTRQRbqcMntYAWk/dBnU bhtu9rEUJwAvuznero1Y//7cz8z22ls/IvjUlheox9WiVLjT6mlqV9Jbh3lFobNyTK nE0AN6yfdqU7Z4+1a6b3AFCGNy0p3ObsBP0TW50+ZLrXUhXZX2kaYdL3QiizVBUZvi bcfUniy7Nk++gOTjGLYfm1006vnYcJGTzR0IvJHXG/zzYrX9QKaosdBY8dXkVGUUEF LTEMQCrYGcMJk0enITywcfZtWXIe4Fkjd+1p4Kcx3ykpIkyXCe8RtF9LtBOGWdlOOU qnp5Ir9iTf25w== Date: Wed, 2 Aug 2023 19:33:09 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 04/11] x86emul: move variable definitions to address MISRA C:2012 Rule 2.1 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > Variable declarations between a switch statement guard and before > any case label are unreachable code, and hence violate Rule 2.1: > "A project shall not contain unreachable code". > > Therefore the variable declarations are moved in the only clause > scope that uses it. > > Signed-off-by: Nicola Vetrini > --- > xen/arch/x86/hvm/emulate.c | 9 ++++----- > xen/arch/x86/hvm/hvm.c | 10 ++++------ > xen/arch/x86/x86_emulate/0f01.c | 7 +++---- > xen/arch/x86/x86_emulate/blk.c | 17 ++++++++--------- > xen/arch/x86/x86_emulate/decode.c | 3 ++- > xen/arch/x86/x86_emulate/fpu.c | 3 +-- > xen/arch/x86/x86_emulate/util-xen.c | 4 ++-- > xen/arch/x86/x86_emulate/x86_emulate.c | 14 +++++++------- > 8 files changed, 31 insertions(+), 36 deletions(-) > > diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c > index 75ee98a73b..2261e8655b 100644 > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -1994,6 +1994,7 @@ static int cf_check hvmemul_rep_stos( > bool_t df = !!(ctxt->regs->eflags & X86_EFLAGS_DF); > int rc = hvmemul_virtual_to_linear(seg, offset, bytes_per_rep, reps, > hvm_access_write, hvmemul_ctxt, &addr); > + char *buf; > > if ( rc != X86EMUL_OKAY ) > return rc; > @@ -2025,7 +2026,6 @@ static int cf_check hvmemul_rep_stos( > switch ( p2mt ) > { > unsigned long bytes; > - char *buf; why can "bytes" where it is? Bith buf and bytes could be declared under "default" with a new block > default: > /* Allocate temporary buffer. */ > @@ -2289,16 +2289,15 @@ static int cf_check hvmemul_cache_op( > struct hvm_emulate_ctxt *hvmemul_ctxt = > container_of(ctxt, struct hvm_emulate_ctxt, ctxt); > uint32_t pfec = PFEC_page_present; > + unsigned long addr; > + int rc; > + void *mapping; > > if ( !cache_flush_permitted(current->domain) ) > return X86EMUL_OKAY; > > switch ( op ) > { > - unsigned long addr; > - int rc; > - void *mapping; These three could be... > case x86emul_clflush: > case x86emul_clflushopt: > case x86emul_clwb: ... here in a new block > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 2180abeb33..4170343b34 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -1494,10 +1494,10 @@ static int cf_check hvm_load_cpu_msrs(struct domain *d, hvm_domain_context_t *h) > > for ( i = 0; i < ctxt->count; ++i ) > { > + int rc; > + > switch ( ctxt->msr[i].index ) > { > - int rc; > - > case MSR_SPEC_CTRL: > case MSR_INTEL_MISC_FEATURES_ENABLES: > case MSR_PKRS: > @@ -3522,6 +3522,7 @@ int hvm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > struct domain *d = v->domain; > uint64_t *var_range_base, *fixed_range_base; > int ret; > + unsigned int index; > > var_range_base = (uint64_t *)v->arch.hvm.mtrr.var_ranges; > fixed_range_base = (uint64_t *)v->arch.hvm.mtrr.fixed_ranges; > @@ -3533,8 +3534,6 @@ int hvm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) > > switch ( msr ) > { > - unsigned int index; > - > case MSR_EFER: > *msr_content = v->arch.hvm.guest_efer; > break; > @@ -3636,6 +3635,7 @@ int hvm_msr_write_intercept(unsigned int msr, uint64_t msr_content, > struct vcpu *v = current; > struct domain *d = v->domain; > int ret; > + unsigned int index; > > HVMTRACE_3D(MSR_WRITE, msr, > (uint32_t)msr_content, (uint32_t)(msr_content >> 32)); > @@ -3668,8 +3668,6 @@ int hvm_msr_write_intercept(unsigned int msr, uint64_t msr_content, > > switch ( msr ) > { > - unsigned int index; > - > case MSR_EFER: > if ( hvm_set_efer(msr_content) ) > return X86EMUL_EXCEPTION; > diff --git a/xen/arch/x86/x86_emulate/0f01.c b/xen/arch/x86/x86_emulate/0f01.c > index ba43fc394b..22a14b12c3 100644 > --- a/xen/arch/x86/x86_emulate/0f01.c > +++ b/xen/arch/x86/x86_emulate/0f01.c > @@ -24,13 +24,12 @@ int x86emul_0f01(struct x86_emulate_state *s, > { > enum x86_segment seg = (s->modrm_reg & 1) ? x86_seg_idtr : x86_seg_gdtr; > int rc; > + unsigned long base, limit, cr0, cr0w, cr4; > + struct segment_register sreg; > + uint64_t msr_val; base and limit can go under case 0xfc cr0 and cr0w can go under case GRP7_ALL(6) > switch ( s->modrm ) > { > - unsigned long base, limit, cr0, cr0w, cr4; > - struct segment_register sreg; > - uint64_t msr_val; > - > case 0xc6: > switch ( s->vex.pfx ) > { > diff --git a/xen/arch/x86/x86_emulate/blk.c b/xen/arch/x86/x86_emulate/blk.c > index e790f4f900..f2956c0d52 100644 > --- a/xen/arch/x86/x86_emulate/blk.c > +++ b/xen/arch/x86/x86_emulate/blk.c > @@ -26,19 +26,18 @@ int x86_emul_blk( > struct x86_emulate_ctxt *ctxt) > { > int rc = X86EMUL_OKAY; > - > - switch ( s->blk ) > - { > - bool zf; > + bool zf; > #ifndef X86EMUL_NO_FPU > + struct { > + struct x87_env32 env; > struct { > - struct x87_env32 env; > - struct { > - uint8_t bytes[10]; > - } freg[8]; > - } fpstate; > + uint8_t bytes[10]; > + } freg[8]; > + } fpstate; > #endif > > + switch ( s->blk ) > + { > /* > * Throughout this switch(), memory clobbers are used to compensate > * that other operands may not properly express the (full) memory > diff --git a/xen/arch/x86/x86_emulate/decode.c b/xen/arch/x86/x86_emulate/decode.c > index f58ca3984e..daebf3a9bd 100644 > --- a/xen/arch/x86/x86_emulate/decode.c > +++ b/xen/arch/x86/x86_emulate/decode.c > @@ -1758,9 +1758,9 @@ int x86emul_decode(struct x86_emulate_state *s, > /* Fetch the immediate operand, if present. */ > switch ( d & SrcMask ) > { > + case SrcImm: { The Xen coding style is: case SrcImm: { Also, this change looks wrong? > unsigned int bytes; > > - case SrcImm: > if ( !(d & ByteOp) ) > { > if ( mode_64bit() && !amd_like(ctxt) && > @@ -1785,6 +1785,7 @@ int x86emul_decode(struct x86_emulate_state *s, > case SrcImm16: > s->imm1 = insn_fetch_type(uint16_t); > break; > + } > } > > ctxt->opcode = opcode; > diff --git a/xen/arch/x86/x86_emulate/fpu.c b/xen/arch/x86/x86_emulate/fpu.c > index 480d879657..002d5e1253 100644 > --- a/xen/arch/x86/x86_emulate/fpu.c > +++ b/xen/arch/x86/x86_emulate/fpu.c > @@ -84,11 +84,10 @@ int x86emul_fpu(struct x86_emulate_state *s, > uint8_t b; > int rc; > struct x86_emulate_stub stub = {}; > + unsigned long dummy; > > switch ( b = ctxt->opcode ) > { > - unsigned long dummy; > - > case 0x9b: /* wait/fwait */ > host_and_vcpu_must_have(fpu); > get_fpu(X86EMUL_FPU_wait); > diff --git a/xen/arch/x86/x86_emulate/util-xen.c b/xen/arch/x86/x86_emulate/util-xen.c > index 5e90818010..7ab2ac712f 100644 > --- a/xen/arch/x86/x86_emulate/util-xen.c > +++ b/xen/arch/x86/x86_emulate/util-xen.c > @@ -77,10 +77,10 @@ bool cf_check x86_insn_is_portio(const struct x86_emulate_state *s, > bool cf_check x86_insn_is_cr_access(const struct x86_emulate_state *s, > const struct x86_emulate_ctxt *ctxt) > { > + unsigned int ext; > + > switch ( ctxt->opcode ) > { > - unsigned int ext; This can go under case X86EMUL_OPC with a new block > case X86EMUL_OPC(0x0f, 0x01): > if ( x86_insn_modrm(s, NULL, &ext) >= 0 > && (ext & 5) == 4 ) /* SMSW / LMSW */ > diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c > index e88245eae9..d6c04fd5f3 100644 > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -1479,15 +1479,15 @@ x86_emulate( > break; > } > > + enum x86_segment seg; > + struct segment_register cs, sreg; > + struct cpuid_leaf leaf; > + uint64_t msr_val; > + unsigned int i, n; > + unsigned long dummy; > + > switch ( ctxt->opcode ) > { > - enum x86_segment seg; > - struct segment_register cs, sreg; > - struct cpuid_leaf leaf; > - uint64_t msr_val; > - unsigned int i, n; > - unsigned long dummy; In Xen we don't mix declarations and code, so they would have to go to the top of the function > case 0x00: case 0x01: add: /* add reg,mem */ > if ( ops->rmw && dst.type == OP_MEM ) > state->rmw = rmw_add; > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 02:36:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 02:36:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575984.901614 (Exim 4.92) (envelope-from ) id 1qROCE-0005sm-9H; Thu, 03 Aug 2023 02:36:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575984.901614; Thu, 03 Aug 2023 02:36:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qROCE-0005sf-6n; Thu, 03 Aug 2023 02:36:14 +0000 Received: by outflank-mailman (input) for mailman id 575984; Thu, 03 Aug 2023 02:36:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qROCC-0005sZ-Eu for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 02:36:12 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80d24fcd-31a6-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 04:36:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C054C61BB5; Thu, 3 Aug 2023 02:36:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB666C433C8; Thu, 3 Aug 2023 02:36:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80d24fcd-31a6-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691030168; bh=RdX8b0xHNNxkZ4bcak3+rkH60PSPk9TzSUqo3+cssGY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=olGTfOJPZIe3mFCrsTrP1HzSWMna0DWQwqnjaiSyAMG+sAFq+NoSvc2lTGPp1hS9n 7RcrpZg4lxFgk+eS5nMsvSh9j4bvlNl/e+TZiHB+hFZhKzAcV2LMdatEinHJtvA5hd yqz7TfCxLN8KG6aR+3XiyWHa8xQ11Gz0AtN8yP88RDT0Jsw7viZMQ0YyEWhICfln5h /AQUxESmu09c5Tz0YmYjk/BhQJ2lvP5tIHnk7KsLdC5FcW5H1Asi6JVjpbsepXU4V0 fNgBec6RYc7sSvKPU/jnz93gDI1Wjs9E9VUCZLg8ir0zgIpbL5fqUCi+npJ8ADDs8L zzo15UjZcYnhA== Date: Wed, 2 Aug 2023 19:36:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [XEN PATCH 05/11] drivers/pci: move variable definitions to address MISRA C:2012 Rule 2.1 In-Reply-To: <99f434f5d8b9c8eca275f23799a642ba34e79eb8.1690985045.git.nicola.vetrini@bugseng.com> Message-ID: References: <99f434f5d8b9c8eca275f23799a642ba34e79eb8.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 2 Aug 2023, Nicola Vetrini wrote: > Variable declarations between a switch statement guard and before > any case label are unreachable code, and hence violate Rule 2.1: > "A project shall not contain unreachable code". > > Therefore the variable declarations are moved in the smallest enclosing > scope, near other variable definitions. > > Signed-off-by: Nicola Vetrini > --- > xen/drivers/passthrough/pci.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 33452791a8..3f5fa5beef 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -315,6 +315,7 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) > struct pci_dev *pdev; > unsigned int pos; > int rc; > + unsigned int cap, sec_bus, sub_bus; > > list_for_each_entry ( pdev, &pseg->alldevs_list, alldevs_list ) > if ( pdev->bus == bus && pdev->devfn == devfn ) > @@ -343,8 +344,6 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) > /* update bus2bridge */ > switch ( pdev->type = pdev_type(pseg->nr, bus, devfn) ) > { > - unsigned int cap, sec_bus, sub_bus; sub_bus and sec_bus could go under case DEV_TYPE_LEGACY_PCI_BRIDGE cap could go under case DEV_TYPE_PCIe_ENDPOINT > case DEV_TYPE_PCIe2PCI_BRIDGE: > case DEV_TYPE_LEGACY_PCI_BRIDGE: > sec_bus = pci_conf_read8(pdev->sbdf, PCI_SECONDARY_BUS); > @@ -424,11 +423,11 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) > > static void free_pdev(struct pci_seg *pseg, struct pci_dev *pdev) > { > + unsigned int sec_bus, sub_bus; > + > /* update bus2bridge */ > switch ( pdev->type ) > { > - unsigned int sec_bus, sub_bus; They could go under case DEV_TYPE_LEGACY_PCI_BRIDGE > case DEV_TYPE_PCIe2PCI_BRIDGE: > case DEV_TYPE_LEGACY_PCI_BRIDGE: > sec_bus = pci_conf_read8(pdev->sbdf, PCI_SECONDARY_BUS); > @@ -1555,11 +1554,10 @@ int iommu_do_pci_domctl( > u8 bus, devfn; > int ret = 0; > uint32_t machine_sbdf; > + unsigned int flags; > > switch ( domctl->cmd ) > { > - unsigned int flags; it could go under case XEN_DOMCTL_test_assign_device > case XEN_DOMCTL_get_device_group: > { > u32 max_sdevs; > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Aug 03 03:16:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 03:16:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.575995.901640 (Exim 4.92) (envelope-from ) id 1qROop-0001yQ-FE; Thu, 03 Aug 2023 03:16:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 575995.901640; Thu, 03 Aug 2023 03:16:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qROop-0001yJ-AR; Thu, 03 Aug 2023 03:16:07 +0000 Received: by outflank-mailman (input) for mailman id 575995; Thu, 03 Aug 2023 03:16:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qROoo-0001y9-Et; Thu, 03 Aug 2023 03:16:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qROoo-0000Ta-AJ; Thu, 03 Aug 2023 03:16:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qROon-0002W4-Ur; Thu, 03 Aug 2023 03:16:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qROon-0007Fz-UR; Thu, 03 Aug 2023 03:16:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dNUoIba/Q34vIqRr3fU/GGbMz2iEKMoU8UD+bz10pUA=; b=FIRq9FZpMbxMX+H2rYkczUjZTm YNcwxRc8/WsBWFsM584+cEvB5+8pkHD1X1l/GZ2kZ3GnUPPITcJofvUi8BWrAbt6UzifpdvZX7U17 GAwQ66+rw3NsQaz7fcuWP0fo4aN1GvNYnl+L8b8OtG+/oJaXlKQfb3ttQqbKDl3nZvAE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-upstream-unstable test] 182103: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: qemu-upstream-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-libvirt:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-libvirt-qcow2:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-libvirt-raw:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-arndale:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-multivcpu:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-credit1:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-rtds:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-vhd:hosts-allocate:starved:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-credit2:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: qemuu=690346043db881debcace7d22249f3355527c5f9 X-Osstest-Versions-That: qemuu=698407ef8395521a9a5b15ed9cd0b7e1fc258ded From: osstest service owner Date: Thu, 03 Aug 2023 03:16:05 +0000 flight 182103 qemu-upstream-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182103/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 181975 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 181975 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 181975 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 181975 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 181975 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 3 hosts-allocate starved n/a test-armhf-armhf-libvirt 3 hosts-allocate starved n/a test-armhf-armhf-libvirt-qcow2 3 hosts-allocate starved n/a test-armhf-armhf-libvirt-raw 3 hosts-allocate starved n/a test-armhf-armhf-xl-arndale 3 hosts-allocate starved n/a test-armhf-armhf-xl-multivcpu 3 hosts-allocate starved n/a test-armhf-armhf-xl-credit1 3 hosts-allocate starved n/a test-armhf-armhf-xl-rtds 3 hosts-allocate starved n/a test-armhf-armhf-xl-vhd 3 hosts-allocate starved n/a test-armhf-armhf-xl-credit2 3 hosts-allocate starved n/a version targeted for testing: qemuu 690346043db881debcace7d22249f3355527c5f9 baseline version: qemuu 698407ef8395521a9a5b15ed9cd0b7e1fc258ded Last test of basis 181975 2023-07-22 17:52:53 Z 11 days Testing same since 182103 2023-08-01 18:08:53 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl starved test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale starved test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 starved test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 starved test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt starved test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu starved test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 starved test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw starved test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds starved test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd starved test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 698407ef83..690346043d 690346043db881debcace7d22249f3355527c5f9 -> master From xen-devel-bounces@lists.xenproject.org Thu Aug 03 06:21:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 06:21:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576026.901717 (Exim 4.92) (envelope-from ) id 1qRRi5-0004zt-VF; Thu, 03 Aug 2023 06:21:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576026.901717; Thu, 03 Aug 2023 06:21:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRRi5-0004zm-SN; Thu, 03 Aug 2023 06:21:21 +0000 Received: by outflank-mailman (input) for mailman id 576026; Thu, 03 Aug 2023 06:21:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRRi4-0004zc-MR; Thu, 03 Aug 2023 06:21:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRRi4-0005FN-Jk; Thu, 03 Aug 2023 06:21:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRRi4-00074p-94; Thu, 03 Aug 2023 06:21:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRRi4-0005Uj-8b; Thu, 03 Aug 2023 06:21:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EZCbhwptoau4mWZ4snLrWywUBCCdG4xWO6JgC0h9eYE=; b=rID38f2JtYP4IL911HO29wC8B0 S1ZNrEsgY2G20C+3t5jKlOmz7OYb6n+IZcCbu2DRAKFKoSpljmWrnnroI1lQ3sDxWBIUKj+Za6sBF 47pKhhHfvs77tugZggk9O3PUAwcPrx7aUQq2GWIqZQQnG/LnEl80cBYd/AgW2SXAFe7E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 182120: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug xen-4.17-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-libvirt:build-check(1):starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:build-check(1):starved:nonblocking xen-4.17-testing:build-arm64-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:build-arm64-pvops:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:build-arm64:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=3d0aa6f23d54a4d3c608010c58c1147a1500d865 X-Osstest-Versions-That: xen=c18b2dd93f396eadd116d0016cf7285523a13505 From: osstest service owner Date: Thu, 03 Aug 2023 06:21:20 +0000 flight 182120 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182120/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 11 xen-install/dst_host fail in 182110 pass in 182120 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 182110 pass in 182120 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 182110 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail pass in 182110 Tests which did not succeed, but are not blocking: test-amd64-i386-migrupgrade 10 xen-install/src_host fail like 182095 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182095 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182095 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182095 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182095 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182095 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182095 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182095 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182095 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182095 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 1 build-check(1) starved in 182110 n/a test-arm64-arm64-xl 1 build-check(1) starved in 182110 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) starved in 182110 n/a test-arm64-arm64-xl-vhd 1 build-check(1) starved in 182110 n/a test-arm64-arm64-xl-xsm 1 build-check(1) starved in 182110 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) starved in 182110 n/a test-arm64-arm64-xl-credit2 1 build-check(1) starved in 182110 n/a build-arm64-libvirt 1 build-check(1) starved in 182110 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) starved in 182110 n/a build-arm64-xsm 2 hosts-allocate starved in 182110 n/a build-arm64-pvops 2 hosts-allocate starved in 182110 n/a test-armhf-armhf-libvirt-qcow2 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-libvirt 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-libvirt-raw 3 hosts-allocate starved in 182110 n/a build-arm64 2 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl-vhd 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl-arndale 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl-rtds 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl-multivcpu 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl-credit2 3 hosts-allocate starved in 182110 n/a test-armhf-armhf-xl-credit1 3 hosts-allocate starved in 182110 n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a version targeted for testing: xen 3d0aa6f23d54a4d3c608010c58c1147a1500d865 baseline version: xen c18b2dd93f396eadd116d0016cf7285523a13505 Last test of basis 182095 2023-07-31 13:07:46 Z 2 days Testing same since 182110 2023-08-02 06:56:35 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Luca Fancellu Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c18b2dd93f..3d0aa6f23d 3d0aa6f23d54a4d3c608010c58c1147a1500d865 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 07:15:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 07:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576035.901734 (Exim 4.92) (envelope-from ) id 1qRSYS-0002CP-3D; Thu, 03 Aug 2023 07:15:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576035.901734; Thu, 03 Aug 2023 07:15:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRSYS-0002CI-0Q; Thu, 03 Aug 2023 07:15:28 +0000 Received: by outflank-mailman (input) for mailman id 576035; Thu, 03 Aug 2023 07:15:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRSYQ-0002CB-IK for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 07:15:26 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061d.outbound.protection.outlook.com [2a01:111:f400:fe5b::61d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8332b98b-31cd-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 09:15:24 +0200 (CEST) Received: from SA0PR11CA0172.namprd11.prod.outlook.com (2603:10b6:806:1bb::27) by SJ1PR12MB6267.namprd12.prod.outlook.com (2603:10b6:a03:456::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 07:15:19 +0000 Received: from SN1PEPF0002529E.namprd05.prod.outlook.com (2603:10b6:806:1bb:cafe::e9) by SA0PR11CA0172.outlook.office365.com (2603:10b6:806:1bb::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 07:15:18 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SN1PEPF0002529E.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 07:15:18 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 02:15:18 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 00:15:17 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 02:15:16 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8332b98b-31cd-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kZetXMIRQCxZn6mWiy7xbH+vglrtwHbTdpQEs7e9VM5VOScBvKWBbtXVMBSeuNpRdv4A+Av/S7YLnksePm8yuicJchISCmcGRsWciUV3TCFf0Fm4jV75YhT0/kU0fmeUT3s3tgYKWnEOQ0bpSGdVCzkQcBmyBCN8l2i8NfO7tow+Y8Gl65lbS29770K0hMpUU1IhapDGdPb5fpe9akuIFna4tuwFf9Vf/cXZMoHscAUi1HyvZvYmJCIvrZPxmK0x+pRqHEwQV92IyYR5spEiBs7ZGPKh8V7GwrX/Ji4GjlwPvUVsvda5MGHviG/A0dlBMMO3q7AyXjl3mnd/S7MODA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r3QbZelKwxhDNvT7zVJTaE8jeQTT4RR730grwMLw5MI=; b=j+i+fvuWXj0Gkt1Sdeei3P327Wi80HpjvHtYsOheSLq7By5DaDCbxUwwnIrZ1vZstjNXDg9CKIoC7dTy8SvsOq+AKiCHVxVsW884FUpC4pvIcMe41nFFP64Y75KnrDy5Hv3gKT3VWdCYk6J2FlfQMUeiZQyzvnWq2fLcglwj6awhWGu2U/TpVczi2Bbwh2C6NPfPOomjhoXp2Tgfbh/WhGH9VWZuZEyWgPuorttj/B4T2++Ud4rC/VG8ZEjUM12JIbMCdJ88dQd+p+79ntfGQtGKgw3E2DwMwDqmFKx2liCHoh5DecApQ/5FblQA8tV09Fts+txW2zpkjj6ZDB/KTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r3QbZelKwxhDNvT7zVJTaE8jeQTT4RR730grwMLw5MI=; b=aikWgEuXbfcO8y//+w3UyfitTRcSMAiwt70Q29Caj7bxXO2eLEmKqaoYtlGL7Y1hi146DtR33Wtz5wMj6QF7WZAeLWHmh+d+Dp8BwK+VR3GwOxlcTHQEjGxkOwXKK8QMOmVxriLXGgw21Xr3c8/E5mbXCKeGbwmUKM8vKAZ4oO0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> Date: Thu, 3 Aug 2023 09:15:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional To: Julien Grall , Luca Fancellu CC: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> Content-Language: en-US From: Michal Orzel In-Reply-To: <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002529E:EE_|SJ1PR12MB6267:EE_ X-MS-Office365-Filtering-Correlation-Id: 6555ca15-0dbe-4ccf-78a0-08db93f1647d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h2KuGXQ5kFXWk2ilV6Yn7dRLYDpHPgJ7TnoZUs7OVnpb3XnqJvlAscCBgz9YjlM66xs0uSBGqJGnTgH9DtQJ9SplVy5dTl9MHyC3zEcI9fOx15Ql019P++fCBinxhT2m3FOVtO5VoiP8myCUQv6xQGAdk5zt3QPYbpnpfml/BTW8COwhpZvKOmGUl/wBsTiYMLjRabQ+4lS3MWQLgAeYJP8XJ4m0okBhJUtmFRAin9e9NGRriG87Bp58w00RdvVHRMPy8u7ZQ6Dtdg2zG+c6YlslEjebWddCck5fyulL/uXcnuN0avD+Bfue4kWqr5F8ErOac3nwBTevICykyepkZvQf/8poQh9F6vl9cSKzmPFca97ipxru9bpRvW0rEGpR8i5CL8gmg+srZ+whT2M1ZbRNWe0aB5XnOCq9VFqsiBwYMFSPpbYSM900rGh3yU6WNPYYoWmYUoP83xyKRTN1aS+4i54DZI8dNZUjk1BWpPV90jeH7HLNjDR+zkw8FJ0Ivw38g4BXjX7p2XhVNM7z4CSsuSiEKGSahtEz7045aOMonGP5l7Kipd2LGAPQxiPYMOlpsB3fQM38dtwZac8YafKJPhTh9KyVMK7lzFVjlpJHZf9ZUQOzpL2mJY/wxvXt47AKCMdHpU3+0fvWR/5DDATkykoec7yJTMsWYkg9W4bWyAbN+1ufajhEoedDS5+iDwgok12BDLoXJLlWghq7uE7To62Pr7J6huykBYWTcMM6ZUQsEQHUJG/AAjItTGtDhkgXhdS6h02/JX5jmEaz4pNq3hYAZI4LYoeG3Cau5nY= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(346002)(39860400002)(376002)(451199021)(82310400008)(40470700004)(36840700001)(46966006)(36756003)(31696002)(86362001)(31686004)(66899021)(82740400003)(40460700003)(40480700001)(54906003)(478600001)(110136005)(356005)(81166007)(47076005)(336012)(426003)(2616005)(186003)(26005)(83380400001)(53546011)(41300700001)(8676002)(8936002)(44832011)(316002)(16576012)(36860700001)(5660300002)(4326008)(70206006)(70586007)(2906002)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 07:15:18.4778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6555ca15-0dbe-4ccf-78a0-08db93f1647d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002529E.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6267 On 02/08/2023 19:39, Julien Grall wrote: > > > Hi Luca, > > On 02/08/2023 16:05, Luca Fancellu wrote: >>> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >>> >>> Hi, >>> >>> On 02/08/2023 16:42, Luca Fancellu wrote: >>>> >>>> >>>>> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >>>>> >>>>> Hi Luca, >>>>> >>>>> On 02/08/2023 15:53, Luca Fancellu wrote: >>>>>> >>>>>> >>>>>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>>>>> when needed, the option is active by default. >>>>>> >>>>>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>>>>> the GICv2 emulation for guests, it is required only when using GICV2 >>>>>> driver, otherwise using GICV3 it is optional and can be deselected >>>>>> if the user doesn't want to offer the vGICv2 interface to guests or >>>>>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>>>>> >>>>>> Signed-off-by: Luca Fancellu >>>>>> --- >>>>>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>>>>> xen/arch/arm/Makefile | 4 ++-- >>>>>> xen/arch/arm/domain_build.c | 4 ++++ >>>>>> xen/arch/arm/gic-v3.c | 4 ++++ >>>>>> xen/arch/arm/vgic.c | 2 ++ >>>>>> 5 files changed, 25 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>>>> index fd57a82dd284..dc702f08ace7 100644 >>>>>> --- a/xen/arch/arm/Kconfig >>>>>> +++ b/xen/arch/arm/Kconfig >>>>>> @@ -78,6 +78,14 @@ config ARM_EFI >>>>>> UEFI firmware. A UEFI stub is provided to allow Xen to >>>>>> be booted as an EFI application. >>>>>> >>>>>> +config GICV2 >>>>> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >>>>> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >>>>> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. >>>> >>>> Hi Michal, >>>> >>>> I tried and I had: >>>> >>>> Starting kernel ... >>>> >>>> - UART enabled - >>>> - Boot CPU booting - >>>> - Current EL 0000000000000008 - >>>> - Initialize CPU - >>>> - Turning on paging - >>>> - Zero BSS - >>>> - Ready - >>>> (XEN) Checking for initrd in /chosen >>>> (XEN) RAM: 0000000080000000 - 00000000feffffff >>>> (XEN) RAM: 0000000880000000 - 00000008ffffffff >>>> (XEN) >>>> (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen >>>> (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree >>>> (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel >>>> (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 >>>> (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff >>>> (XEN) >>>> (XEN) >>>> (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 >>>> (XEN) PFN compression on bits 20...22 >>>> (XEN) Domain heap initialised >>>> (XEN) Booting using Device Tree >>>> (XEN) Platform: Generic System >>>> (XEN) >>>> (XEN) **************************************** >>>> (XEN) Panic on CPU 0: >>>> (XEN) Unable to find compatible GIC in the device tree >>>> (XEN) **************************************** >>>> (XEN) >>>> (XEN) Manual reset required ('noreboot' specified) >>> Having early printk enabled all the time is not common and not enabled in release builds FWIK. > > There are a lot of information printed before the console is properly > brought up. I wonder if we should look at adding early console like > Linux does? I guess it is not a matter of "if" but "when" and I think it's just that no one has time to do that since it is more a like a feature for developers rather than for customers (they just report the issue and we need to fix it :)). There are so many things that can go wrong during early boot including the entire boofdt parsing and having earlycon would be so desirable. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 03 07:36:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 07:36:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576040.901744 (Exim 4.92) (envelope-from ) id 1qRSsM-0004i6-Me; Thu, 03 Aug 2023 07:36:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576040.901744; Thu, 03 Aug 2023 07:36:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRSsM-0004hz-Jp; Thu, 03 Aug 2023 07:36:02 +0000 Received: by outflank-mailman (input) for mailman id 576040; Thu, 03 Aug 2023 07:36:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRSsK-0004ht-V2 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 07:36:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRSsK-0006lm-Hj; Thu, 03 Aug 2023 07:36:00 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRSsK-00082q-7R; Thu, 03 Aug 2023 07:36:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=BeG+6oeCw7mY+IH05PJsyCj/NoFiq6CRV82Xc/vjVKY=; b=ae0/0cXRoWXFOgec+Fy6QDs6W2 XaAyIEXxCuZmjed0tseiTrpHaqvWDPBG8PO+730Wx/iJPvppkB68Ao35YutNn9AL9efwGQoBQCpOD M9VfGQQa4FZAQFFI7izRfqydZTgC6UGN50cqGE2E2BmtNhf3rRh4JgYwMnZuH2mrK8q0=; Message-ID: <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> Date: Thu, 3 Aug 2023 08:35:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Michal Orzel , Luca Fancellu Cc: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> From: Julien Grall Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional In-Reply-To: <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/08/2023 08:15, Michal Orzel wrote: > On 02/08/2023 19:39, Julien Grall wrote: >> >> >> Hi Luca, >> >> On 02/08/2023 16:05, Luca Fancellu wrote: >>>> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >>>> >>>> Hi, >>>> >>>> On 02/08/2023 16:42, Luca Fancellu wrote: >>>>> >>>>> >>>>>> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >>>>>> >>>>>> Hi Luca, >>>>>> >>>>>> On 02/08/2023 15:53, Luca Fancellu wrote: >>>>>>> >>>>>>> >>>>>>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>>>>>> when needed, the option is active by default. >>>>>>> >>>>>>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>>>>>> the GICv2 emulation for guests, it is required only when using GICV2 >>>>>>> driver, otherwise using GICV3 it is optional and can be deselected >>>>>>> if the user doesn't want to offer the vGICv2 interface to guests or >>>>>>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>>>>>> >>>>>>> Signed-off-by: Luca Fancellu >>>>>>> --- >>>>>>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>>>>>> xen/arch/arm/Makefile | 4 ++-- >>>>>>> xen/arch/arm/domain_build.c | 4 ++++ >>>>>>> xen/arch/arm/gic-v3.c | 4 ++++ >>>>>>> xen/arch/arm/vgic.c | 2 ++ >>>>>>> 5 files changed, 25 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>>>>> index fd57a82dd284..dc702f08ace7 100644 >>>>>>> --- a/xen/arch/arm/Kconfig >>>>>>> +++ b/xen/arch/arm/Kconfig >>>>>>> @@ -78,6 +78,14 @@ config ARM_EFI >>>>>>> UEFI firmware. A UEFI stub is provided to allow Xen to >>>>>>> be booted as an EFI application. >>>>>>> >>>>>>> +config GICV2 >>>>>> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >>>>>> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >>>>>> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. >>>>> >>>>> Hi Michal, >>>>> >>>>> I tried and I had: >>>>> >>>>> Starting kernel ... >>>>> >>>>> - UART enabled - >>>>> - Boot CPU booting - >>>>> - Current EL 0000000000000008 - >>>>> - Initialize CPU - >>>>> - Turning on paging - >>>>> - Zero BSS - >>>>> - Ready - >>>>> (XEN) Checking for initrd in /chosen >>>>> (XEN) RAM: 0000000080000000 - 00000000feffffff >>>>> (XEN) RAM: 0000000880000000 - 00000008ffffffff >>>>> (XEN) >>>>> (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen >>>>> (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree >>>>> (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel >>>>> (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 >>>>> (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff >>>>> (XEN) >>>>> (XEN) >>>>> (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 >>>>> (XEN) PFN compression on bits 20...22 >>>>> (XEN) Domain heap initialised >>>>> (XEN) Booting using Device Tree >>>>> (XEN) Platform: Generic System >>>>> (XEN) >>>>> (XEN) **************************************** >>>>> (XEN) Panic on CPU 0: >>>>> (XEN) Unable to find compatible GIC in the device tree >>>>> (XEN) **************************************** >>>>> (XEN) >>>>> (XEN) Manual reset required ('noreboot' specified) >>>> Having early printk enabled all the time is not common and not enabled in release builds FWIK. >> >> There are a lot of information printed before the console is properly >> brought up. I wonder if we should look at adding early console like >> Linux does? > I guess it is not a matter of "if" but "when" and I think it's just that no one has time to do that > since it is more a like a feature for developers rather than for customers (they just report the issue > and we need to fix it :)). Sure. This is always the case, but it also means developpers will continue to waste time when investigating early boot issues. I wouldn't be surprised if the total time wasted is more than the actual effort to add support :). > There are so many things that can go wrong during early boot including the entire boofdt parsing > and having earlycon would be so desirable. It is not clear what to take from your reply. Earlier you were concerned about the error not showing up in the log if the .config is not correct. There is no really quick fix for that as a .config may work for platform A but not platform B. The only viable solution is having an early console. Anything else like forcing to always have one GICvX selected is just a hack that would work for one set of people but not the others. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:05:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:05:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576050.901754 (Exim 4.92) (envelope-from ) id 1qRTL0-0000J6-DS; Thu, 03 Aug 2023 08:05:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576050.901754; Thu, 03 Aug 2023 08:05:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTL0-0000Iz-A6; Thu, 03 Aug 2023 08:05:38 +0000 Received: by outflank-mailman (input) for mailman id 576050; Thu, 03 Aug 2023 08:05:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTKy-0000It-JJ for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:05:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 859a529e-31d4-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:05:34 +0200 (CEST) Received: from DB8PR06CA0018.eurprd06.prod.outlook.com (2603:10a6:10:100::31) by AS8PR08MB8063.eurprd08.prod.outlook.com (2603:10a6:20b:54c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:04:59 +0000 Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::e4) by DB8PR06CA0018.outlook.office365.com (2603:10a6:10:100::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 3 Aug 2023 08:04:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Thu, 3 Aug 2023 08:04:59 +0000 Received: ("Tessian outbound f1e964b3a9be:v145"); Thu, 03 Aug 2023 08:04:59 +0000 Received: from ce50d277fe64.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 793C0985-07A5-4C5D-A3AB-5347362104F0.1; Thu, 03 Aug 2023 08:04:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ce50d277fe64.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 08:04:52 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS4PR08MB7853.eurprd08.prod.outlook.com (2603:10a6:20b:51c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:04:50 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:04:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 859a529e-31d4-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDvI8MDbYKaDXjqZ0zTEM8J4YD4KVCCgqp6VT0TZlOY=; b=aWQOUnUC4He6RFdvWBUVCRO/EGav0Z18M98xWEEUikDzUqj6CoRMJ7pMlZC3bPDdxpeXJcfCA4YoCWRjkEvx/b+eSwsINlQId4DEkom4iQojK+qSUw9X/aOlCm634Fy3ywJ2d7W6uTIa12JW8lCX+fCaGy6Vwq89RHV9AYPo7qE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 24f99669834b1f0c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUVPtldjlEP2GAmbOG7N3cLp+hiZzNR+E7yP9haVa5fWRQ1qSjfq6z2esQ+NwCj+WdmGwSaR0+2oJ3FNSRDYnB++tHDQZU/qne2ZOmkcMBW6h88Wv8BNgBDawIlmWe9Itr+XjP59F3soXX8WlGnV/aGKIUh8+E/5RVKRjg/EUzC+ol1pTYnqcQA4j7ECCHvcCRH33s4IqLO3CY3mUXppXevxM5LTu2iGIZ/k3AJluzx/McZ7kE/+ACuM63yAoZdfzlRKCx7GbYV5e9JG+1M/Q8eHEm0OixCoevesIpPj2zoeIXUpP9hlMzfz78bJxNSivGRufbB28H1dMOVnIAvRCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TDvI8MDbYKaDXjqZ0zTEM8J4YD4KVCCgqp6VT0TZlOY=; b=fh2XSc45nR3NgXhV4LCPHYw7abUGPUVn+cFD8F8rXmhPDGW+tM5wOXTKLYiCyA5Du4qyp1zM2lIeSpi9NMR9dKmuZw7LkZg/16jU5ZzpqSg8coaXnzN6RmXjbTnX5UXxWsBHfiMTwupZg9L/zsEttPpXdRB3Z8xW96DLgAgz1B0NVfhNLWMEZkzvcjUjNHIWa3z5mbY3ZjCYo2x+1yoN2mix3zf667NoAKCSxbpUZ/Y1RsmG6J2Lbtqrg8P9NgDOMxYKxDh7Ts+35n/Sb1uCm1WOt0puvSOn3ZgMr/pcC8gFFSko8tIRfEKUMJzvJAkaLGIDirwtnJmpHtfiwv8yrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDvI8MDbYKaDXjqZ0zTEM8J4YD4KVCCgqp6VT0TZlOY=; b=aWQOUnUC4He6RFdvWBUVCRO/EGav0Z18M98xWEEUikDzUqj6CoRMJ7pMlZC3bPDdxpeXJcfCA4YoCWRjkEvx/b+eSwsINlQId4DEkom4iQojK+qSUw9X/aOlCm634Fy3ywJ2d7W6uTIa12JW8lCX+fCaGy6Vwq89RHV9AYPo7qE= From: Luca Fancellu To: Julien Grall CC: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/XEDgAgAAEZQCAAAGbgIAABJqAgAArPoCAAOPegIAABcoAgAAIA4A= Date: Thu, 3 Aug 2023 08:04:49 +0000 Message-ID: <33DCC5E2-7190-464C-B25A-68BC68CA4021@arm.com> References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> In-Reply-To: <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS4PR08MB7853:EE_|DBAEUR03FT017:EE_|AS8PR08MB8063:EE_ X-MS-Office365-Filtering-Correlation-Id: fc0e48d3-7591-453f-fddd-08db93f8551c x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ux3HFo/Dnomf/0VhD+ZWh7eJ66XgRmlktDlWIHhiwcvZV8c4sgOxNz0iPrH3etQr5709jubO45f2aRFgit9b0zOYxPVbJfCkYyuZswY0Yf5TYFQfOR9FPNgDiXQPcBGBN37bal6Pn2/MwWt1hGlNxLv/iLLkXPiVaad/Q6muBPhtGFcXUePwkhYPlqlk/aXNvlm2GOdkxgjyv4nYLsF9MZ8fH1a5KC4DyrtT9UX8TfecOVJsRVz790kTsYz9/cYlRklgoQ7beya0N//5x5C9xrGaKto4TcL7xryOtv57MLvVMeBj9/0Wif802xM6aq0ttJIpw2lpiERUjtuVLiuQTbQTlocntZHNJJQ6/x/b4tV35M5XQuZWePVv+kMXnJRE7L7u6IW4Ra+Jbhdli000glvN32nTK5MBTWj8p6Ae51ArNfgUaUKnQcnAJ7O1Ohovk++i/AYKyh6OtXZF7gWIHDjGIbgtPEjXQt7shtwQccoHY8so2y77sDkxn8VE6sF4PX7Gv1RF4pXX/3IVcKKyzlwxA96yLn7VUM7HEOR2IaMVQ/EccL4oe+AnFYkgV3c5x4AiaeLzNp/9V4ca1qD6W7GlVp2O36XiqLys8SOTK5pkWzYyPlxVim98b51XRhQDBG3iUFS+CGwORQaKyhyaZg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199021)(2616005)(83380400001)(6506007)(26005)(186003)(41300700001)(2906002)(91956017)(66946007)(76116006)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(6916009)(316002)(8676002)(8936002)(6486002)(71200400001)(6512007)(478600001)(54906003)(38100700002)(122000001)(33656002)(86362001)(36756003)(38070700005)(66899021)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <0F6A0ABC3CDDD8418989182A0D19B3D0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7853 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9cac6697-6c9d-4d91-a809-08db93f84f85 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cwup3RxPtBD7ynY+u4hQokSnK3rnxW4hexp37Rkp8OaUqNpHU/0xOVS1bUf0WMGi/w4SDJ8tNC21X7h1CNoFlrnjFlaj8WlR5BPfAnZqBr82BW3/cba8Mm/ZzwXdkM25/DoAHDc+azgL+Xnrt5//JrN+XnAPc63FGd+ZNDYV9WyQphdPuq0ATjXVmHClG2+Lpf9ms56KvuUvwKGhK+1kwaY/woERX04h5P0ABS1n/Xo9QbbAqThHkE7KXg9Xljs4cZgaJA+bdsTquliYZdh8YRPo5gIN1PeXLNM+sWFH9zybtjkaSrLgRvtLn/p23VU1Df6WMmQp6GfFjH0b0KR+zikyvDLmsraqZm+/uoIHYkDuQPHD3wmOVz1sbaO5xGJCoFZZN3tzRyDD+0t7kVg9HB+cM3Iq2TfHk5sTNlzc4s4WykiXUC8A8+SokWe9JklZXVaS2IyMWkIN/HXl9d/umTWnXh7rpuXw7R+HJYq0q2x8nCh2b0At+LWztO3nf3i2/oTwVNtHloDQi2ygMcBNm3C57BJ5SNZoZ0NxM88gDc5x08LveCN3kh26+DYrVJRTzMYNWD9p+ANiOfgkeewFTY7zzsnrDIfuScYFRMxKA7rONWbo/fkznYFPUK2gEPJ6HdKXuxYAQrDXuQ8OFh3X6iZlaDCirG+aRVQZNiMl0UKvH8zJTBaDZLoKQq/M5/5GnsFQO0BtOZB0LcR8inUqaQhGswUzUcCHbblmY+lgh1PMGf2o5CtegF4euRXwiNYd X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199021)(82310400008)(36840700001)(46966006)(40470700004)(40460700003)(2616005)(107886003)(6506007)(83380400001)(26005)(186003)(336012)(47076005)(36860700001)(316002)(2906002)(70586007)(70206006)(4326008)(5660300002)(6862004)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(40480700001)(356005)(81166007)(33656002)(86362001)(36756003)(82740400003)(66899021);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:04:59.2036 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc0e48d3-7591-453f-fddd-08db93f8551c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8063 DQo+Pj4+Pj4gDQo+Pj4+Pj4gLSBVQVJUIGVuYWJsZWQgLQ0KPj4+Pj4+IC0gQm9vdCBDUFUgYm9v dGluZyAtDQo+Pj4+Pj4gLSBDdXJyZW50IEVMIDAwMDAwMDAwMDAwMDAwMDggLQ0KPj4+Pj4+IC0g SW5pdGlhbGl6ZSBDUFUgLQ0KPj4+Pj4+IC0gVHVybmluZyBvbiBwYWdpbmcgLQ0KPj4+Pj4+IC0g WmVybyBCU1MgLQ0KPj4+Pj4+IC0gUmVhZHkgLQ0KPj4+Pj4+IChYRU4pIENoZWNraW5nIGZvciBp bml0cmQgaW4gL2Nob3Nlbg0KPj4+Pj4+IChYRU4pIFJBTTogMDAwMDAwMDA4MDAwMDAwMCAtIDAw MDAwMDAwZmVmZmZmZmYNCj4+Pj4+PiAoWEVOKSBSQU06IDAwMDAwMDA4ODAwMDAwMDAgLSAwMDAw MDAwOGZmZmZmZmZmDQo+Pj4+Pj4gKFhFTikNCj4+Pj4+PiAoWEVOKSBNT0RVTEVbMF06IDAwMDAw MDAwODQwMDAwMDAgLSAwMDAwMDAwMDg0MTVkMDAwIFhlbg0KPj4+Pj4+IChYRU4pIE1PRFVMRVsx XTogMDAwMDAwMDBmZDZjNTAwMCAtIDAwMDAwMDAwZmQ2YzgwMDAgRGV2aWNlIFRyZWUNCj4+Pj4+ PiAoWEVOKSBNT0RVTEVbMl06IDAwMDAwMDAwODAwODAwMDAgLSAwMDAwMDAwMDgxNGYxYTAwIEtl cm5lbA0KPj4+Pj4+IChYRU4pICBSRVNWRFswXTogMDAwMDAwMDA4MDAwMDAwMCAtIDAwMDAwMDAw ODAwMTAwMDANCj4+Pj4+PiAoWEVOKSAgUkVTVkRbMV06IDAwMDAwMDAwMTgwMDAwMDAgLSAwMDAw MDAwMDE4N2ZmZmZmDQo+Pj4+Pj4gKFhFTikNCj4+Pj4+PiAoWEVOKQ0KPj4+Pj4+IChYRU4pIENv bW1hbmQgbGluZTogbm9yZWJvb3QgZG9tMF9tZW09MTAyNE0gY29uc29sZT1kdHVhcnQgZHR1YXJ0 PXNlcmlhbDAgYm9vdHNjcnViPTANCj4+Pj4+PiAoWEVOKSBQRk4gY29tcHJlc3Npb24gb24gYml0 cyAyMC4uLjIyDQo+Pj4+Pj4gKFhFTikgRG9tYWluIGhlYXAgaW5pdGlhbGlzZWQNCj4+Pj4+PiAo WEVOKSBCb290aW5nIHVzaW5nIERldmljZSBUcmVlDQo+Pj4+Pj4gKFhFTikgUGxhdGZvcm06IEdl bmVyaWMgU3lzdGVtDQo+Pj4+Pj4gKFhFTikNCj4+Pj4+PiAoWEVOKSAqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqDQo+Pj4+Pj4gKFhFTikgUGFuaWMgb24gQ1BVIDA6DQo+ Pj4+Pj4gKFhFTikgVW5hYmxlIHRvIGZpbmQgY29tcGF0aWJsZSBHSUMgaW4gdGhlIGRldmljZSB0 cmVlDQo+Pj4+Pj4gKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq Kg0KPj4+Pj4+IChYRU4pDQo+Pj4+Pj4gKFhFTikgTWFudWFsIHJlc2V0IHJlcXVpcmVkICgnbm9y ZWJvb3QnIHNwZWNpZmllZCkNCg0KSGkgSnVsaWVuLCBNaWNoYWwsDQoNCj4+Pj4+IEhhdmluZyBl YXJseSBwcmludGsgZW5hYmxlZCBhbGwgdGhlIHRpbWUgaXMgbm90IGNvbW1vbiBhbmQgbm90IGVu YWJsZWQgaW4gcmVsZWFzZSBidWlsZHMgRldJSy4NCj4+PiANCj4+PiBUaGVyZSBhcmUgYSBsb3Qg b2YgaW5mb3JtYXRpb24gcHJpbnRlZCBiZWZvcmUgdGhlIGNvbnNvbGUgaXMgcHJvcGVybHkNCj4+ PiBicm91Z2h0IHVwLiBJIHdvbmRlciBpZiB3ZSBzaG91bGQgbG9vayBhdCBhZGRpbmcgZWFybHkg Y29uc29sZSBsaWtlDQo+Pj4gTGludXggZG9lcz8NCj4+IEkgZ3Vlc3MgaXQgaXMgbm90IGEgbWF0 dGVyIG9mICJpZiIgYnV0ICJ3aGVuIiBhbmQgSSB0aGluayBpdCdzIGp1c3QgdGhhdCBubyBvbmUg aGFzIHRpbWUgdG8gZG8gdGhhdA0KPj4gc2luY2UgaXQgaXMgbW9yZSBhIGxpa2UgYSBmZWF0dXJl IGZvciBkZXZlbG9wZXJzIHJhdGhlciB0aGFuIGZvciBjdXN0b21lcnMgKHRoZXkganVzdCByZXBv cnQgdGhlIGlzc3VlDQo+PiBhbmQgd2UgbmVlZCB0byBmaXggaXQgOikpLg0KPiANCj4gU3VyZS4g VGhpcyBpcyBhbHdheXMgdGhlIGNhc2UsIGJ1dCBpdCBhbHNvIG1lYW5zIGRldmVsb3BwZXJzIHdp bGwgY29udGludWUgdG8gd2FzdGUgdGltZSB3aGVuIGludmVzdGlnYXRpbmcgZWFybHkgYm9vdCBp c3N1ZXMuIEkgd291bGRuJ3QgYmUgc3VycHJpc2VkIGlmIHRoZSB0b3RhbCB0aW1lIHdhc3RlZCBp cyBtb3JlIHRoYW4gdGhlIGFjdHVhbCBlZmZvcnQgdG8gYWRkIHN1cHBvcnQgOikuDQoNCknigJl2 ZSBub3QgaW52ZXN0aWdhdGVkIG9uIHRoZSBhbW91bnQgb2YgdGltZSBuZWVkZWQgdG8gYWRkIHRo YXQsIEkgd291bGRu4oCZdCB1bmRlcmVzdGltYXRlIHRoYXQgYW5kIHVuZm9ydHVuYXRlbHkgcGVv cGxlIGhhdmUNCmRpZmZlcmVudCBjYXBhY2l0eSBhbmQgY29tcGFuaWVzIGhhdmUgZGlmZmVyZW50 IHByaW9yaXRpZXMsIHNvIGEgcXVpY2sgZmVhdHVyZSBjYW4gdHJhbnNsYXRlIG9uIG1vbnRocyB3 aGVuIHRoZSB0aW1lIGFsbG9jYXRlZA0KZm9yIGEgcGFydGljdWxhciBqb2IgaXMsIGxldOKAmXMg c2F5LCBvbmUgZGF5IGEgbW9udGguDQoNCj4gDQo+PiBUaGVyZSBhcmUgc28gbWFueSB0aGluZ3Mg dGhhdCBjYW4gZ28gd3JvbmcgZHVyaW5nIGVhcmx5IGJvb3QgaW5jbHVkaW5nIHRoZSBlbnRpcmUg Ym9vZmR0IHBhcnNpbmcNCj4+IGFuZCBoYXZpbmcgZWFybHljb24gd291bGQgYmUgc28gZGVzaXJh YmxlLg0KPiBJdCBpcyBub3QgY2xlYXIgd2hhdCB0byB0YWtlIGZyb20geW91ciByZXBseS4gRWFy bGllciB5b3Ugd2VyZSBjb25jZXJuZWQgYWJvdXQgdGhlIGVycm9yIG5vdCBzaG93aW5nIHVwIGlu IHRoZSBsb2cgaWYgdGhlIC5jb25maWcgaXMgbm90IGNvcnJlY3QuDQo+IA0KPiBUaGVyZSBpcyBu byByZWFsbHkgcXVpY2sgZml4IGZvciB0aGF0IGFzIGEgLmNvbmZpZyBtYXkgd29yayBmb3IgcGxh dGZvcm0gQSBidXQgbm90IHBsYXRmb3JtIEIuIFRoZSBvbmx5IHZpYWJsZSBzb2x1dGlvbiBpcyBo YXZpbmcgYW4gZWFybHkgY29uc29sZS4NCj4gDQo+IEFueXRoaW5nIGVsc2UgbGlrZSBmb3JjaW5n IHRvIGFsd2F5cyBoYXZlIG9uZSBHSUN2WCBzZWxlY3RlZCBpcyBqdXN0IGEgaGFjayB0aGF0IHdv dWxkIHdvcmsgZm9yIG9uZSBzZXQgb2YgcGVvcGxlIGJ1dCBub3QgdGhlIG90aGVycy4NCg0KSSBh Z3JlZSB3aXRoIHlvdSBpbiBwYXJ0LCB3aGVuIHlvdSBzYXkgdGhhdCBpdCB3b3VsZCB3b3JrIGZv ciBvbmUgc2V0IG9mIHBlb3BsZSBidXQgbm90IHRoZSBvdGhlcnMsIGlzbuKAmXQgaXQgYWx3YXlz IHRoZSBjYXNlPyBXZSBhcmUgcHJvdmlkaW5nDQphIGRlZmNvbmZpZyB0aGF0IHdvdWxkIGZpdCB0 aGUgbWFqb3JpdHkgb2YgdGhlIHBlb3BsZSwgYnV0IGl04oCZcyBhbHdheXMgYSBzZXQgb2YgdGhl bS4NCg0KTW9yZSBzcGVjaWZpYyB0byB0aGlzIHBhdGNoLCB3aXRoIHRoZSBwcm92aWRlZCBLY29u ZmlnIOKAnGhhY2vigJ0gYXMgeW91IHNheSwgaXQgaXMgbm90IG9ubHkgcHJvdmlkaW5nIHRoZSBz YW1lIHVzZXIgZXhwZXJpZW5jZSBhcyB0aGUgY3VycmVudCBzdGF0ZSwNCml0IGlzIGRvaW5nIG1v cmUsIGl0IGlzIHByb3ZpZGluZyBhIHdheSB0byBleGNsdWRlIGZyb20gdGhlIGJ1aWxkIHRoZSBH SUN2MiB3aGljaCBpcyBub3QgcG9zc2libGUgY3VycmVudGx5LCB0aGlzIHdvcmsgYWltcyB0byBw cm92aWRlIGEgbW9yZQ0KZmluZSBncmFudWxhciBjb25maWd1cmF0aW9uIHNvIHRoYXQgZXhwZXJp ZW5jZWQgdXNlcnMgY2FuIHJlbW92ZSBlbnRpcmUgbW9kdWxlcyB0aGF0IHRoZXkgZG9u4oCZdCBu ZWVkIGluIHRoZWlyIHBsYXRmb3JtIHNvIHRoYXQgdGhleSBkb27igJl0IGhhdmUNCnRvIHRha2Ug dGhlbSBpbnRvIGFjY291bnQgd2hlbiBnb2luZyB0bywgZm9yIGV4YW1wbGUsIHNhZmV0eSBjcml0 aWNhbCBhdWRpdHMuDQoNCkkgYWdyZWUgd2l0aCB5b3UgdGhhdCBlYXJseWNvbiB3b3VsZCBiZSBw ZXJmZWN0LCBzbyB0aGF0IHdlIGNvdWxkIG1ha2UgdGhlIHVzZXIgcmVtb3ZlIGV2ZXJ5IG1vZHVs ZSBhbmQgbGV0IGhpbSBrbm93IHF1aWNrbHkgdGhlIGlzc3VlLA0KYnV0IG9uIHRoZSBvdGhlciBo YW5kIGl0IGlzIGEgY29tcGxldGUgbmV3IGZlYXR1cmUgdGhhdCB5b3UgYXJlIHJlcXVlc3Rpbmcg KGFyZSB5b3U/KSB0byBtYWtlIHRoaXMgcGF0Y2ggZ28gZm9yd2FyZC4NCg0KTXkgcGVyc29uYWwg b3BpbmlvbiBpcyB0aGF0LCBzaW5jZSB0aGlzIHBhdGNoIGlzIG5vdCBhZmZlY3RpbmcgdGhlIHVz ZXIgZXhwZXJpZW5jZSwgaXQgaXMgbWFpbnRhaW5pbmcgdGhlIGN1cnJlbnQgc3RhdHVzIChub3Qg aWRlYWwpLCBidXQgYXQgbGVhc3QNCkl0IGlzIHByb3ZpZGluZyBzb21ldGhpbmcgbW9yZSwgaXQg d291bGQgYmUgYSBzaGFtZSB0byB0aHJvdyB0aGF0IGluIHRoZSBiaW4gYmVjYXVzZSBubyBvbmUg aGFzIHRpbWUgdG8gd29yayBvbiBlYXJseWNvbi4NCg0KQ2hlZXJzLA0KTHVjYQ0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:07:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:07:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576054.901763 (Exim 4.92) (envelope-from ) id 1qRTML-0000tM-S1; Thu, 03 Aug 2023 08:07:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576054.901763; Thu, 03 Aug 2023 08:07:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTML-0000tF-PS; Thu, 03 Aug 2023 08:07:01 +0000 Received: by outflank-mailman (input) for mailman id 576054; Thu, 03 Aug 2023 08:07:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTMK-0000t9-ND for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:07:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b846049c-31d4-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 10:06:59 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 8A7EC4EE0737; Thu, 3 Aug 2023 10:06:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b846049c-31d4-11ee-b268-6b7b168915f2 MIME-Version: 1.0 Date: Thu, 03 Aug 2023 10:06:58 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 1/4] x86/mce: address MISRA C:2012 Rule 5.3 In-Reply-To: References: <52ec7caf08089e3aaaad2bcf709a7d387d55d58f.1690969271.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <5c07fb2501c305db444d42eb280fab36@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 03:45, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> Suitable mechanical renames are made to avoid shadowing, thus >> addressing violations of MISRA C:2012 Rule 5.3: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope" >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- >> xen/arch/x86/cpu/mcheck/barrier.h | 8 ++++---- >> 2 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/xen/arch/x86/cpu/mcheck/barrier.c >> b/xen/arch/x86/cpu/mcheck/barrier.c >> index a7e5b19a44..51a1d37a76 100644 >> --- a/xen/arch/x86/cpu/mcheck/barrier.c >> +++ b/xen/arch/x86/cpu/mcheck/barrier.c >> @@ -16,11 +16,11 @@ void mce_barrier_dec(struct mce_softirq_barrier >> *bar) >> atomic_dec(&bar->val); >> } >> >> -void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) >> +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait) > > "wait" clashes with xen/common/sched/core.c:wait, which is globally > exported, right? > > I think it would be good to add this info to the commit message in this > kind of patches. > Correct, it's in 'xen/include/xen/wait.h' that makes it visible in the file modified by the patch. I'll add it in v2. >> -void mce_barrier_enter(struct mce_softirq_barrier *, bool wait); >> -void mce_barrier_exit(struct mce_softirq_barrier *, bool wait); >> +void mce_barrier_enter(struct mce_softirq_barrier *, bool do_wait); >> +void mce_barrier_exit(struct mce_softirq_barrier *, bool do_wait); > > You might as well add "bar" as first parameter? > > >> void mce_barrier(struct mce_softirq_barrier *); >> Will do. I checked that this would not interfere with other patches related to Rules 8.2 and 8.3. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:07:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576057.901773 (Exim 4.92) (envelope-from ) id 1qRTMo-0001M6-4X; Thu, 03 Aug 2023 08:07:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576057.901773; Thu, 03 Aug 2023 08:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTMo-0001Lx-1h; Thu, 03 Aug 2023 08:07:30 +0000 Received: by outflank-mailman (input) for mailman id 576057; Thu, 03 Aug 2023 08:07:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTMm-0000t9-Qv for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:07:28 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2060e.outbound.protection.outlook.com [2a01:111:f400:7e83::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c92b4638-31d4-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 10:07:27 +0200 (CEST) Received: from SJ0PR05CA0147.namprd05.prod.outlook.com (2603:10b6:a03:33d::32) by PH0PR12MB7790.namprd12.prod.outlook.com (2603:10b6:510:289::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Thu, 3 Aug 2023 08:07:23 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:a03:33d:cafe::7f) by SJ0PR05CA0147.outlook.office365.com (2603:10b6:a03:33d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.18 via Frontend Transport; Thu, 3 Aug 2023 08:07:23 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 3 Aug 2023 08:07:22 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 03:07:21 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 01:07:21 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 03:07:19 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c92b4638-31d4-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZ796zQEps7zKScBDUXVuVeSx4wJ45bRBGZXijSqgHnv60YJR7U6ZUcmqvTQNwpjkX8BWdQ56fE7OxaecvoL0Dh8enZXCgQpA/upiRWmyUYKW1BPV0jabLED9gqv3lvr6cuydnxtx2qvWsMqZGx1VGpt4YDvf5dgSh/921l/X+RsMeCpim+nvWjhCActcgVDn+KZs3NOhbKQ2sVO02NYu230LPXajhUcQ8lAyNJkofspjGPKVcoCeDkrp0yIG/cKtkgctyXxRNZGx+POMCmBBnL+uuzODR9J7lqi+q31hZzDf3rUVzHe2ND/SH9VPeyL0znrGAtvJq8cLKW9As5CQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vtu01wfErjl8p1ZXHqqdIcDF25BBmHSforxtkzCzv0I=; b=EIJd6PMd29/QDiYpiP3YlV8/X75QTbS+DckvKOw/T8lnTZqMdBte98UVSxSzh14jEMSSLUOLcvLlLFnW+KtXptqi1fA77AE38x2bJsbjBfw7+Z/40msRbUAEc85tqWvQ2mPmT3z65zAs3LVbY8YhThNQ2Ed7ShZXJiit1pYgNQ5XnU+DDjQi7tEZTyArieW3ZdIM1kc5okdWdVR+dQjP8ukvtX/I8A2BqrGPhOEEv/YcdyQbihsT/ivUjdFbpMTPxoSHesBw4uK4/KdsI36PunFJGJzxCmMWcWCpBN/9ThJ/PSxLTq7pqBZjeWzWmSVp/H1oQXYlegUHYHs3UWMHVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vtu01wfErjl8p1ZXHqqdIcDF25BBmHSforxtkzCzv0I=; b=B7Su1dPo5HNJMPEGe1okPMoluBa+zczGtn6QZ04f8e8kUNrUntgv1YZrefKVU3QKCIgYRmge02rt5C5eTyo7wGwbxExPFbPIV2wOKhcr7TBJcx9g+89rQHClx5t8mBulIBOBGjEF0NbMOutF3RPLKer8CQTBsha8waBSJdxNK6w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <2c16c9c2-afed-3dda-7e88-b4c5269665f2@amd.com> Date: Thu, 3 Aug 2023 10:07:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-US To: Julien Grall , Luca Fancellu CC: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> From: Michal Orzel In-Reply-To: <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|PH0PR12MB7790:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a0532f1-7d99-401c-80f4-08db93f8aab9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pFU6hZOtsQn9tT6ZfcQ/lCbNQGjany1MY1Og2lr1xPIvHpd7tCGuEr6okkBRyGBiKPJGwc3X9Q5n19zBXASvC3PRiLU1wdmBXCpKGs3wbuzQoBPdlShmRIrNXxjK414meWyuJ9X11smyqJ4ooz2uQa6u0O6/u+RlihIo8P2rey1ECrJ6X/JBc8YIPEbpZsguqwVyNWmnZoRtaYot3v84Fk6kyS9zlaXpZShyhSpS2ROUgjPUkQwhcwVemSEQ4OgoUpIOBh8tH6S7x1UejoeIc70Zj3lBlr2zUpWBGMBu9xTTlIM0Q8vyber03O8ywHdI//65Dw03hcqCLxSzkRNgl75XiNo13TVqUecv/XKrsfvGAy36paAvI3/wQ7SxYvNuC7/oUdV7erbYn6ES+w3OZLnY385aY6tlFtu1otX43lht6l7j/Qx9e8l4yOcZZueICxssTzbs5BnXWNGHLcZxIl7bQ3fVE8rE/YcQtXSpjBwJjphITB7od3ezmAT0oR362axnhJAXwvm3A1BxaNOzZMkauMowhKKNu6F0PpCT5lruinOVYq2gwITNxzk0BnhD+VaHqMQribPfpQxD7zcEW5PazIsanHcNdZQ1Q0TuANV2RVR00Fw3f+CXY7bG3LzTAJCLahT3BEYV5etwwkli4jaKaOcY4bqxkGypFIUdCn/u7Nuorm9zneJq/1rQmyhMRXyGrBijATA5DhGCJLs7ieHF0PS0ZbbSRnCF7xQQWoyZK3FRD1jzgi1vfKOeoNBABdqKxLYnfEs/qSUJJv9dbcuFcsBG3jx7N8uZzdQk4W5Bv/htaIWj8gpNDeZ3dD8v X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(376002)(396003)(82310400008)(451199021)(40470700004)(36840700001)(46966006)(40480700001)(2616005)(40460700003)(336012)(186003)(16576012)(316002)(86362001)(478600001)(54906003)(81166007)(110136005)(4326008)(356005)(31696002)(70586007)(70206006)(82740400003)(53546011)(36756003)(41300700001)(26005)(426003)(5660300002)(8676002)(8936002)(47076005)(2906002)(66899021)(36860700001)(44832011)(83380400001)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:07:22.7107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a0532f1-7d99-401c-80f4-08db93f8aab9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7790 On 03/08/2023 09:35, Julien Grall wrote: > > > Hi, > > On 03/08/2023 08:15, Michal Orzel wrote: >> On 02/08/2023 19:39, Julien Grall wrote: >>> >>> >>> Hi Luca, >>> >>> On 02/08/2023 16:05, Luca Fancellu wrote: >>>>> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >>>>> >>>>> Hi, >>>>> >>>>> On 02/08/2023 16:42, Luca Fancellu wrote: >>>>>> >>>>>> >>>>>>> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >>>>>>> >>>>>>> Hi Luca, >>>>>>> >>>>>>> On 02/08/2023 15:53, Luca Fancellu wrote: >>>>>>>> >>>>>>>> >>>>>>>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>>>>>>> when needed, the option is active by default. >>>>>>>> >>>>>>>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>>>>>>> the GICv2 emulation for guests, it is required only when using GICV2 >>>>>>>> driver, otherwise using GICV3 it is optional and can be deselected >>>>>>>> if the user doesn't want to offer the vGICv2 interface to guests or >>>>>>>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>>>>>>> >>>>>>>> Signed-off-by: Luca Fancellu >>>>>>>> --- >>>>>>>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>>>>>>> xen/arch/arm/Makefile | 4 ++-- >>>>>>>> xen/arch/arm/domain_build.c | 4 ++++ >>>>>>>> xen/arch/arm/gic-v3.c | 4 ++++ >>>>>>>> xen/arch/arm/vgic.c | 2 ++ >>>>>>>> 5 files changed, 25 insertions(+), 2 deletions(-) >>>>>>>> >>>>>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>>>>>> index fd57a82dd284..dc702f08ace7 100644 >>>>>>>> --- a/xen/arch/arm/Kconfig >>>>>>>> +++ b/xen/arch/arm/Kconfig >>>>>>>> @@ -78,6 +78,14 @@ config ARM_EFI >>>>>>>> UEFI firmware. A UEFI stub is provided to allow Xen to >>>>>>>> be booted as an EFI application. >>>>>>>> >>>>>>>> +config GICV2 >>>>>>> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >>>>>>> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >>>>>>> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. >>>>>> >>>>>> Hi Michal, >>>>>> >>>>>> I tried and I had: >>>>>> >>>>>> Starting kernel ... >>>>>> >>>>>> - UART enabled - >>>>>> - Boot CPU booting - >>>>>> - Current EL 0000000000000008 - >>>>>> - Initialize CPU - >>>>>> - Turning on paging - >>>>>> - Zero BSS - >>>>>> - Ready - >>>>>> (XEN) Checking for initrd in /chosen >>>>>> (XEN) RAM: 0000000080000000 - 00000000feffffff >>>>>> (XEN) RAM: 0000000880000000 - 00000008ffffffff >>>>>> (XEN) >>>>>> (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen >>>>>> (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree >>>>>> (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel >>>>>> (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 >>>>>> (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff >>>>>> (XEN) >>>>>> (XEN) >>>>>> (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 >>>>>> (XEN) PFN compression on bits 20...22 >>>>>> (XEN) Domain heap initialised >>>>>> (XEN) Booting using Device Tree >>>>>> (XEN) Platform: Generic System >>>>>> (XEN) >>>>>> (XEN) **************************************** >>>>>> (XEN) Panic on CPU 0: >>>>>> (XEN) Unable to find compatible GIC in the device tree >>>>>> (XEN) **************************************** >>>>>> (XEN) >>>>>> (XEN) Manual reset required ('noreboot' specified) >>>>> Having early printk enabled all the time is not common and not enabled in release builds FWIK. >>> >>> There are a lot of information printed before the console is properly >>> brought up. I wonder if we should look at adding early console like >>> Linux does? >> I guess it is not a matter of "if" but "when" and I think it's just that no one has time to do that >> since it is more a like a feature for developers rather than for customers (they just report the issue >> and we need to fix it :)). > > Sure. This is always the case, but it also means developpers will > continue to waste time when investigating early boot issues. I wouldn't > be surprised if the total time wasted is more than the actual effort to > add support :). most probably > >> There are so many things that can go wrong during early boot including the entire boofdt parsing >> and having earlycon would be so desirable. > It is not clear what to take from your reply. Earlier you were concerned > about the error not showing up in the log if the .config is not correct. > > There is no really quick fix for that as a .config may work for platform > A but not platform B. The only viable solution is having an early console. > > Anything else like forcing to always have one GICvX selected is just a > hack that would work for one set of people but not the others. Yes, having early console would solve these issues and for now we might need to be on the mercy of users to do wise selection. That said, the scenario with GIC is not really the same as for something that can work on platform A and not on B. No GIC built-in cannot work on any platform, hence my concern (it is different than selecting wrong GIC). But because I do not see any simple solution other than building always both and you don't like what Luca just did (fallback to GICv2), I'm ok. Initializing UART prior to GIC would also require quite some work to defer the IRQ translation that depends on the GIC. ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:12:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576065.901784 (Exim 4.92) (envelope-from ) id 1qRTRf-0002vO-NN; Thu, 03 Aug 2023 08:12:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576065.901784; Thu, 03 Aug 2023 08:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTRf-0002vH-Ka; Thu, 03 Aug 2023 08:12:31 +0000 Received: by outflank-mailman (input) for mailman id 576065; Thu, 03 Aug 2023 08:12:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTRe-0002v8-C5 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:12:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTRd-0008El-SX; Thu, 03 Aug 2023 08:12:29 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRTRd-0001Jw-Jt; Thu, 03 Aug 2023 08:12:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yfxp1bZM15OcNspcFyALedShd5Zo2jreE3hhmpofOp4=; b=hWHRMp5aIksin1qS6gkKzZZ7/F 9RS+gk5NcPqhZVFFfbahgol0qVvkPu/jb60Pq1nj6IgO7NoLi3NUtTDzroPCYi9V8Q0ISNzNxIbu4 kg2ogsrnYNawrxK1bwf9ZooVcZIoRPF/b7cVL7pAKjP62r35GZj9lkxQZtb9mfVZN5lw=; Message-ID: Date: Thu, 3 Aug 2023 09:12:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Michal Orzel , Luca Fancellu Cc: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> <2c16c9c2-afed-3dda-7e88-b4c5269665f2@amd.com> From: Julien Grall In-Reply-To: <2c16c9c2-afed-3dda-7e88-b4c5269665f2@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 03/08/2023 09:07, Michal Orzel wrote: > On 03/08/2023 09:35, Julien Grall wrote: >> On 03/08/2023 08:15, Michal Orzel wrote: >>> On 02/08/2023 19:39, Julien Grall wrote: >>>> >>>> >>>> Hi Luca, >>>> >>>> On 02/08/2023 16:05, Luca Fancellu wrote: >>>>>> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> On 02/08/2023 16:42, Luca Fancellu wrote: >>>>>>> >>>>>>> >>>>>>>> On 2 Aug 2023, at 15:26, Michal Orzel wrote: >>>>>>>> >>>>>>>> Hi Luca, >>>>>>>> >>>>>>>> On 02/08/2023 15:53, Luca Fancellu wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> Introduce Kconfig GICV2 to be able to compile the GICv2 driver only >>>>>>>>> when needed, the option is active by default. >>>>>>>>> >>>>>>>>> Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles >>>>>>>>> the GICv2 emulation for guests, it is required only when using GICV2 >>>>>>>>> driver, otherwise using GICV3 it is optional and can be deselected >>>>>>>>> if the user doesn't want to offer the vGICv2 interface to guests or >>>>>>>>> maybe its GICv3 hardware can't offer the GICv2 compatible mode. >>>>>>>>> >>>>>>>>> Signed-off-by: Luca Fancellu >>>>>>>>> --- >>>>>>>>> xen/arch/arm/Kconfig | 13 +++++++++++++ >>>>>>>>> xen/arch/arm/Makefile | 4 ++-- >>>>>>>>> xen/arch/arm/domain_build.c | 4 ++++ >>>>>>>>> xen/arch/arm/gic-v3.c | 4 ++++ >>>>>>>>> xen/arch/arm/vgic.c | 2 ++ >>>>>>>>> 5 files changed, 25 insertions(+), 2 deletions(-) >>>>>>>>> >>>>>>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >>>>>>>>> index fd57a82dd284..dc702f08ace7 100644 >>>>>>>>> --- a/xen/arch/arm/Kconfig >>>>>>>>> +++ b/xen/arch/arm/Kconfig >>>>>>>>> @@ -78,6 +78,14 @@ config ARM_EFI >>>>>>>>> UEFI firmware. A UEFI stub is provided to allow Xen to >>>>>>>>> be booted as an EFI application. >>>>>>>>> >>>>>>>>> +config GICV2 >>>>>>>> So, now it would be possible to deselect both GIC drivers and Xen would not complain when building. >>>>>>>> This means that Xen would fail on boot without any message as it happens before serial driver initialization. >>>>>>>> Since having GIC driver built in is a must-have I think we need to make sure that at least one is enabled. >>>>>>> >>>>>>> Hi Michal, >>>>>>> >>>>>>> I tried and I had: >>>>>>> >>>>>>> Starting kernel ... >>>>>>> >>>>>>> - UART enabled - >>>>>>> - Boot CPU booting - >>>>>>> - Current EL 0000000000000008 - >>>>>>> - Initialize CPU - >>>>>>> - Turning on paging - >>>>>>> - Zero BSS - >>>>>>> - Ready - >>>>>>> (XEN) Checking for initrd in /chosen >>>>>>> (XEN) RAM: 0000000080000000 - 00000000feffffff >>>>>>> (XEN) RAM: 0000000880000000 - 00000008ffffffff >>>>>>> (XEN) >>>>>>> (XEN) MODULE[0]: 0000000084000000 - 000000008415d000 Xen >>>>>>> (XEN) MODULE[1]: 00000000fd6c5000 - 00000000fd6c8000 Device Tree >>>>>>> (XEN) MODULE[2]: 0000000080080000 - 00000000814f1a00 Kernel >>>>>>> (XEN) RESVD[0]: 0000000080000000 - 0000000080010000 >>>>>>> (XEN) RESVD[1]: 0000000018000000 - 00000000187fffff >>>>>>> (XEN) >>>>>>> (XEN) >>>>>>> (XEN) Command line: noreboot dom0_mem=1024M console=dtuart dtuart=serial0 bootscrub=0 >>>>>>> (XEN) PFN compression on bits 20...22 >>>>>>> (XEN) Domain heap initialised >>>>>>> (XEN) Booting using Device Tree >>>>>>> (XEN) Platform: Generic System >>>>>>> (XEN) >>>>>>> (XEN) **************************************** >>>>>>> (XEN) Panic on CPU 0: >>>>>>> (XEN) Unable to find compatible GIC in the device tree >>>>>>> (XEN) **************************************** >>>>>>> (XEN) >>>>>>> (XEN) Manual reset required ('noreboot' specified) >>>>>> Having early printk enabled all the time is not common and not enabled in release builds FWIK. >>>> >>>> There are a lot of information printed before the console is properly >>>> brought up. I wonder if we should look at adding early console like >>>> Linux does? >>> I guess it is not a matter of "if" but "when" and I think it's just that no one has time to do that >>> since it is more a like a feature for developers rather than for customers (they just report the issue >>> and we need to fix it :)). >> >> Sure. This is always the case, but it also means developpers will >> continue to waste time when investigating early boot issues. I wouldn't >> be surprised if the total time wasted is more than the actual effort to >> add support :). > most probably > >> >>> There are so many things that can go wrong during early boot including the entire boofdt parsing >>> and having earlycon would be so desirable. >> It is not clear what to take from your reply. Earlier you were concerned >> about the error not showing up in the log if the .config is not correct. >> >> There is no really quick fix for that as a .config may work for platform >> A but not platform B. The only viable solution is having an early console. >> >> Anything else like forcing to always have one GICvX selected is just a >> hack that would work for one set of people but not the others. > Yes, having early console would solve these issues and for now we might need to be > on the mercy of users to do wise selection. That said, the scenario with GIC is not really > the same as for something that can work on platform A and not on B. No GIC built-in > cannot work on any platform, hence my concern (it is different than selecting wrong GIC). The assumption behind this is the user will always have a platform where it can boot Xen. I am not aware of many users with this opportunity of choice. So to me this is not very different from Xen can't boot on A but can on B. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:14:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576068.901793 (Exim 4.92) (envelope-from ) id 1qRTTY-0003TQ-2y; Thu, 03 Aug 2023 08:14:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576068.901793; Thu, 03 Aug 2023 08:14:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTTY-0003TJ-0M; Thu, 03 Aug 2023 08:14:28 +0000 Received: by outflank-mailman (input) for mailman id 576068; Thu, 03 Aug 2023 08:14:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTTX-0003TD-7L for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:14:27 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1e12223-31d5-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:14:24 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 1A1644EE0737; Thu, 3 Aug 2023 10:14:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1e12223-31d5-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Thu, 03 Aug 2023 10:14:24 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 In-Reply-To: References: <16fa23ecb465442c566a18af0a569092075eef26.1690969271.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <56d5b07a4194e5036ef92dcb56072851@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 03:51, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> Rename variables to avoid shadowing and thus address >> MISRA C:2012 Rule 5.3: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope" >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini > > This one clashes with xen/arch/x86/include/asm/mtrr.h:struct mtrr_state > right? > Yes, indeed. You can also check this when in doubt at https://saas.eclairit.com, but I do agree that mentioning it directly in the commit would make review easier. > >> --- >> xen/arch/x86/hvm/mtrr.c | 32 ++++++++++++++++---------------- >> 1 file changed, 16 insertions(+), 16 deletions(-) >> >> diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c >> index 29f3fb1607..d504d1e43b 100644 >> --- a/xen/arch/x86/hvm/mtrr.c >> +++ b/xen/arch/x86/hvm/mtrr.c >> @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain >> *d, uint64_t gfn_start, >> >> static int cf_check hvm_save_mtrr_msr(struct vcpu *v, >> hvm_domain_context_t *h) >> { >> - const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr; >> + const struct mtrr_state *mtrr = &v->arch.hvm.mtrr; > > I can see in hvm_vcpu_cacheattr_init, mtrr_get_type and other places > that we use: > > const struct mtrr_state *m > > maybe that's better? I'll let Jan comment. > > Anyway, the patch looks correct to me. > > I though about it, and it seemed too generic, so in the end I decided for mtrr, but as always with names, I'm open to alternative suggestions. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:26:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:26:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576075.901803 (Exim 4.92) (envelope-from ) id 1qRTfU-00056J-Bb; Thu, 03 Aug 2023 08:26:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576075.901803; Thu, 03 Aug 2023 08:26:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTfU-00056C-8z; Thu, 03 Aug 2023 08:26:48 +0000 Received: by outflank-mailman (input) for mailman id 576075; Thu, 03 Aug 2023 08:26:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTfT-000566-6f for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:26:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7afaa859-31d7-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:26:44 +0200 (CEST) Received: from Dell.bugseng.com.homenet.telecomitalia.it (host-87-5-121-62.retail.telecomitalia.it [87.5.121.62]) by support.bugseng.com (Postfix) with ESMTPSA id E99034EE0737; Thu, 3 Aug 2023 10:26:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7afaa859-31d7-11ee-8613-37d641c3527e From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v2] xen/string: add missing parameter names Date: Thu, 3 Aug 2023 10:26:34 +0200 Message-Id: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add missing parameter names to address violation of MISRA C:2012 rule 8.2 ("Function types shall be in prototype form with named parameters"). No functional changes. Signed-off-by: Federico Serafini --- Changes in v2: - memset() adjusted. --- xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h index b4d2217a96..e91e3112e0 100644 --- a/xen/include/xen/string.h +++ b/xen/include/xen/string.h @@ -12,27 +12,27 @@ #define strncpy __xen_has_no_strncpy__ #define strncat __xen_has_no_strncat__ -size_t strlcpy(char *, const char *, size_t); -size_t strlcat(char *, const char *, size_t); -int strcmp(const char *, const char *); -int strncmp(const char *, const char *, size_t); -int strcasecmp(const char *, const char *); -int strncasecmp(const char *, const char *, size_t); -char *strchr(const char *, int); -char *strrchr(const char *, int); -char *strstr(const char *, const char *); -size_t strlen(const char *); -size_t strnlen(const char *, size_t); -char *strpbrk(const char *, const char *); -char *strsep(char **, const char *); -size_t strspn(const char *, const char *); - -void *memset(void *, int, size_t); -void *memcpy(void *, const void *, size_t); -void *memmove(void *, const void *, size_t); -int memcmp(const void *, const void *, size_t); -void *memchr(const void *, int, size_t); -void *memchr_inv(const void *, int, size_t); +size_t strlcpy(char *dest, const char *src, size_t size); +size_t strlcat(char *dest, const char *src, size_t size); +int strcmp(const char *cs, const char *ct); +int strncmp(const char *cs, const char *ct, size_t count); +int strcasecmp(const char *s1, const char *s2); +int strncasecmp(const char *s1, const char *s2, size_t len); +char *strchr(const char *s, int c); +char *strrchr(const char *s, int c); +char *strstr(const char *s1, const char *s2); +size_t strlen(const char *s); +size_t strnlen(const char *s, size_t count); +char *strpbrk(const char *cs, const char *ct); +char *strsep(char **s, const char *ct); +size_t strspn(const char *s, const char *accept); + +void *memset(void *s, int c, size_t count); +void *memcpy(void *dest, const void *src, size_t count); +void *memmove(void *dest, const void *src, size_t count); +int memcmp(const void *cs, const void *ct, size_t count); +void *memchr(const void *s, int c, size_t n); +void *memchr_inv(const void *s, int c, size_t n); #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:30:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:30:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576079.901814 (Exim 4.92) (envelope-from ) id 1qRTib-0005sC-PP; Thu, 03 Aug 2023 08:30:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576079.901814; Thu, 03 Aug 2023 08:30:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTib-0005rY-Mj; Thu, 03 Aug 2023 08:30:01 +0000 Received: by outflank-mailman (input) for mailman id 576079; Thu, 03 Aug 2023 08:30:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTia-0005jU-0m for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:30:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTiZ-0000GS-KI; Thu, 03 Aug 2023 08:29:59 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRTiZ-0001l5-DR; Thu, 03 Aug 2023 08:29:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mVJOpTN/SMXgzQ3juWQOsGhVuQYcAPpO4fcB+I4DqFM=; b=23U7AzbbK1Bp9MyIYLe5XCKy+A zOHqalCnNpmIMmai2cQ4kklrEJsav65VuJL8pcoucF/BxSvkbxkCtwizBhifbMbFAZs8A2cvE+3u4 EigrTz+YU1OYlTJSYQ5HlZTE/JlvB5638BD/uBHDKRqzf6y16W8cFwBpXV8V+7dte4Fo=; Message-ID: <3942c22a-80e1-29bd-4bd8-15d4bc43d220@xen.org> Date: Thu, 3 Aug 2023 09:29:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu Cc: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> <33DCC5E2-7190-464C-B25A-68BC68CA4021@arm.com> From: Julien Grall In-Reply-To: <33DCC5E2-7190-464C-B25A-68BC68CA4021@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/08/2023 09:04, Luca Fancellu wrote: >>> There are so many things that can go wrong during early boot including the entire boofdt parsing >>> and having earlycon would be so desirable. >> It is not clear what to take from your reply. Earlier you were concerned about the error not showing up in the log if the .config is not correct. >> >> There is no really quick fix for that as a .config may work for platform A but not platform B. The only viable solution is having an early console. >> >> Anything else like forcing to always have one GICvX selected is just a hack that would work for one set of people but not the others. > > I agree with you in part, when you say that it would work for one set of people but not the others, isn’t it always the case? We are providing > a defconfig that would fit the majority of the people, but it’s always a set of them. Correct. > > More specific to this patch, with the provided Kconfig “hack†as you say, it is not only providing the same user experience as the current state, > it is doing more, it is providing a way to exclude from the build the GICv2 which is not possible currently, this work aims to provide a more > fine granular configuration so that experienced users can remove entire modules that they don’t need in their platform so that they don’t have > to take them into account when going to, for example, safety critical audits. There seems to be some misunderstanding about the hack I am referring to. This is not about the patch itself but the following line: select GICV2 if !GICV3 && !NEW_VGIC Now that GICv2 can be deselecting, I see no point to force select GICV2 if GICV3 is not selected. As I wrote earlier, there is so many way for someone to create .config that is wrong or doesn't boot on their platform. So someone tweaking .config should always be careful when selecting/deselecting options. > > I agree with you that earlycon would be perfect, so that we could make the user remove every module and let him know quickly the issue, > but on the other hand it is a complete new feature that you are requesting (are you?) to make this patch go forward. I didn't suggest it. I was making the point that if you have time, it is best to spend it trying to enable the early console rather than trying to prevent the user to disable both GIC. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:36:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:36:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576084.901824 (Exim 4.92) (envelope-from ) id 1qRToN-0007CR-EF; Thu, 03 Aug 2023 08:35:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576084.901824; Thu, 03 Aug 2023 08:35:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRToN-0007CK-Ai; Thu, 03 Aug 2023 08:35:59 +0000 Received: by outflank-mailman (input) for mailman id 576084; Thu, 03 Aug 2023 08:35:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRToM-0007CE-L0 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:35:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0616.outbound.protection.outlook.com [2a01:111:f400:fe0c::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c4596aed-31d8-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 10:35:57 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8226.eurprd04.prod.outlook.com (2603:10a6:20b:3ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:35:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:35:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4596aed-31d8-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RfS2pyDu4D+hup8GbXVmHu5UjvgtCjTFodVNFTAe5+HsPVC4f9lCIzYSTpmk/pcQJJf9QA8hwKmZlnQEhFr/gBzmT/wmAt/Y6e3tbJhRsjkNJLQz/m0FpeeAsjuw/r0xsEFYWVNSR+UVSUstWgNuj/wzQDiXxGoBTihiNb775xwo+PGK2gZP85KDcQByk34LSz+x2byYaNT+fn2DeXiHdm8p4vekEwD4CwUQVNWhGTX/4801B+RxLcoxzVcnl8rVmJaF+nO/bwTgSc6+sNf7D4mW4buJMnkP4MfSFULZR8y7OtFJCjlkeQvQnwDkyYfWZshtGHzVhG3/1kbaFoI6vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mQNgGyCcg1CmsUg3fNOMBUw3IOBCWjocZRi19DmmcMM=; b=cucbzQTgvdkXzajVfGzn61kfTu02dz4a+LcZ9LGztSU2Jpz9uY4FM//l6UpCMk8oMkR8Dv7ttDg6PrAaWUxL1LMGt7qmVPllE0JQ2R3QPX8+ZQdPkpgM1UGTrrNZrzJUEUD/ZLfHayBylOc74euOlB5m/xAZ6g6qpu+9+BPODOZaIsua5dkd0cmnvXhpJQJQ0lLWl3oSdswPqmxS4eEPwfW9Xs2DsC0eFZITxwre10s+vKsLa8Jb7HtA0lluQ83Om4MqPkRMbUWcc7lA5eBCjxIZRagw+X2R8/ubzeHhVJMS2vWubxKzC87cjFLC8bcelDVrTiTJLxLZpeW8LxVyhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQNgGyCcg1CmsUg3fNOMBUw3IOBCWjocZRi19DmmcMM=; b=xo7DPPz1JDdIaLTE9+sapSR7h3p9FK/FOy6Vqv/OxSNBMJuNcISJ+PtNvLeZ9Ajo1I39YtceM3wVl8L6of1JuRrZKmS6LUXghayGYaP3krJcEVmCvpFCJTyiPK9oFakG0NonafD3lo6BjNUXoyR6RY3TyhJp5tJFT02b/7PjPPnzvPeR653Yv+VzLDd6IUxtaXimfHYrBeMRZOXG3crFJmxfKKUikF2rkvhC+rAddAbE2tipav1+Og88bYhazHdu2nyDoA0873F/No53dzBLfysEfUIS0rIzWV6/lzeP7TYiNvjUWtgaBmMmDxaYMTWYNwyIJyxTz8WOT336pEbfbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> Date: Thu, 3 Aug 2023 10:35:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing Content-Language: en-US To: Elliott Mitchell Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8226:EE_ X-MS-Office365-Filtering-Correlation-Id: 506f03ac-5127-4b18-a8e0-08db93fca745 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5MsEnmZe0mgSq/NkB+jwCAUhLTj/oDFugU+RgFdm+SPxiFlTRuuMpyQKi0rQGvQpdJAHrTv8lSdmO5H8flZk+Vcpq2RGeXfVt1nzkdaJtCtT/WMKZmT9AyWb6op0BBx0SI8S6rFvZgujmfIJUt5F1sI+JGFeFmeiKTPZlHznMURYjzFE6QsaQIyrAZ1G4ztYy1+LOEYBr2SRJ+4W1CuSTzq6fFqVCEKxnW8hVx7b7xQiJkliJfPY+/q8PYWV+GwqzcDsnRXRZvhXhNNr5dVlzb2x/rvYBUOoll0pB6bWCNuSfvZX4c1jwhKxUb9sW9kNsZZVmFqYcMC7tUQlfaqGqgY2R34x43MbW2moAspAOqXkhAPs/LJ/KsJniKXFYWZ2znNKg7qjX4vPwX+ZZwK6XvBvVOFNsknDDVFJPJ7YDV19rUrEEXdVXCXgqZySluuGNS8jY63PAiMgqhzYNA46YNdth4Pc1MnK7gixSPZljAet+E0zlnz/DUTuyrAAl1RewGKn8x5jPH8qN78ue7f9tZgyX8HNCqmNv5XyLlhqZAlnLbSj4EAejcu+igRO/A7mhc/aZVudmXM5DSCrEyFJ1ZzbrE3A+T0zNwhSp06bWKInHVhhqUlwJrqndTvfnVRf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(36756003)(31696002)(86362001)(31686004)(54906003)(478600001)(38100700002)(2616005)(6506007)(186003)(26005)(83380400001)(53546011)(8676002)(8936002)(41300700001)(966005)(6512007)(6486002)(316002)(66476007)(66556008)(5660300002)(4326008)(66946007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXU2ZVRsSEFsblVtSytMdHBUNGErYWlxeGNPQ1lVR2xrbmI0bGVXekpHZnVh?= =?utf-8?B?c1pkdGxuQ2x0NWM5bGQwSExvNVM2dUgxOTd2NXJDZ0hqQ3BOMXZ3THlVeFBl?= =?utf-8?B?TE5NY2YyeDhNYlNEU3A4UllRdEVWdDZ1SHc1VEhEZXVXaWlwVlh6cWJ5Q1JN?= =?utf-8?B?NTRoM3R1K2wwSVBqejZrRVp3UWtIKzZCUGVkNllNQm9oamJYL3M4aFkvRzRJ?= =?utf-8?B?WThKYzhVbEpJdS9tL1pELzI5QW5lQ3ZWMmowcEpMdWZjaGI4SE5GbnNLZXVw?= =?utf-8?B?eEtoUmZQWTk1bEJ1N1lEV0w4eWNreWc4L0hsdmdkQmZTVGI3RVpteEYxN3Nn?= =?utf-8?B?eG54M2ZVVThsN01vYnluSEJxTFE1K0V4bCtJYS9YSG13UEs1bCtKT3lka3Nu?= =?utf-8?B?cjJ6WmJ1QS9PdHNwamFLUG0xaThJZnJaNDcxRXhoUFFldmdLS2RTTW81azlj?= =?utf-8?B?TzRtSU4yWE9DeVpDaWRhRFhCVmU4NGRHRDhYcktMcmN6QjY3bm1uSCtNQlpS?= =?utf-8?B?aStqTFZ3NC93UlJHeW8zWkF2cGQ1V0lDZHRHYWNEdTNZLzNLRS9wS0VrWG9N?= =?utf-8?B?VEhLbWJVLzlzaWZpZDVoTFQxVnpEZUxqbEFjQktPN1NoS3JkOStQalhuTXRK?= =?utf-8?B?SEdjSFFTcnhPdTA4RERPRmlQalp6UWgrL2M2b0RIUm9hd0svL1lXaExHems4?= =?utf-8?B?aXpMUFBORUYwYXdrdUF1d0xaSDZyMFhLM2RrTG02aU5LZU11WW9ZeTUzSHA4?= =?utf-8?B?ajd5VmFETE9OeUlKdGN5bUJvVEV2dTVQTmxJQ09yZ3VTdkRIRFIyVkl6dVlm?= =?utf-8?B?WWVEWGNjS016bVZDNzFsSk5jSWdwL3hlTUtvaHZ5TFNGcXVLczd0MktUK1FT?= =?utf-8?B?SkNXdGdmNVRWbVFYRkE2V0xhWmtaem54YWJEYzZZSUZ3VmxWY01UekRwdEV0?= =?utf-8?B?cDh4VFBNVTJHb0kzTVoySU11Q3NzZytzbGFRbzk5MURucUVLczVJV1hXUmgw?= =?utf-8?B?MVBGcFRFc2QrVzNyeEJxdEZMQUh6dm1ONG1UNVRUOXh3NDVaOXRKdnNya2pZ?= =?utf-8?B?dUtkZFFDUHVja0Nmei9TSTFsSUZuTjVGOVR4czJvUnZDc0hHemx1QXkzZUJi?= =?utf-8?B?aWJPdFBvS2JQMWZZZEdEeXd3aWt2Rkd0bTJIMnJXMzIyb3Z3WUtTemtIeFNj?= =?utf-8?B?bC80dHYrOUJLOEo0bE1BeE5iNzNybUNVZ0dwT3I3Z056QWNWMEhxb0k4RzJI?= =?utf-8?B?NWVMMFdSVlEwTG45T2hQcDgrb3Y3SmZ1eTRkdWFSUUlBOWUvOHVsSXovbkJ2?= =?utf-8?B?QzYxb2FDc0hjM04wQW9FSkdhK0hoWCtrNzhsakJpRys1QUF0dEQxcnVkN0k0?= =?utf-8?B?WjJJMXRzZzFDekc2eWk1czBlYkJodnJsWU1LVVpXT21XZ2EwQUtWK0p5QThx?= =?utf-8?B?UW9kWUNHN2x0Q1U5UkxIN1ZxNUhrdTBFL2VPSWFCM2tKV0g2VGhUd0VYN0du?= =?utf-8?B?TmpoYzZydHRCQnE1OGxFNzJOZjV0R0J5YUlYTlhmb2VWd0ZDMmFoV05Hck84?= =?utf-8?B?eGNHTzdkYVdVUnQ2VVZkcjBHdys5TnBuazR1YVdDWklHaEhBWHVmOW9nSXZj?= =?utf-8?B?WElDMStHY0xmc29OVnJhYWU3SXhuS3VGOW81dHhQYk1OYmVkeForb2lCOHVq?= =?utf-8?B?cWlrVm5QOWhLaVVaaEtLSFloSG5WSmx4NWVDUUFqZWpiTjlKakZJSlp0YXl3?= =?utf-8?B?Y0pVWnM3bnB1ZyttUTVObTBaWEI1YVhCVlV3Z2dHd2ZhUEpqR1MyRWtkVWsy?= =?utf-8?B?VjRtYllRRVZYbTM1bmVLRjZySE4rZUthYzVqalRpajdFT0QyajJnd1N4TW5H?= =?utf-8?B?THQ4KzVuOFp0a0d0WXRkQ2FaOW5EenIyRlo1Nm5YYzljM2s0MTdNdzRQQmhX?= =?utf-8?B?NThYbVhjQ2U1NXRPMVVmcFIxRUZIUWVxb3ZYb1VvTitGMW5QZ2hrcDZOL1g2?= =?utf-8?B?eDhvYm14OHRhQi9EaWZaZ0JscStWVmNsUk0vSHpwY0NKa0RUak43ZzFYbG1B?= =?utf-8?B?aEkwYzgxVnJGaTJqYUNFY1NSelN0RzdnY3VKQmE4blhXdzVaeFZIK085WTlY?= =?utf-8?Q?+DUyijx04hJQRGlC+kXcb2jRb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 506f03ac-5127-4b18-a8e0-08db93fca745 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:35:55.1995 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H9eS/4o/mYaCizWOoRtURy/3V97m3Yueww5ba9vgAu9+kH7pmI8uarBUcugHVWsPkOeYVipI8AZsCY8EsDyb5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8226 On 02.08.2023 17:33, Elliott Mitchell wrote: > Is there a freeze on that I'm unaware of? Is there so much traffic from > other developers that smaller output ones are being missed? I'm > wondering about the initial revision of this series not getting any > feedback: > https://lists.xenproject.org/archives/html/xen-devel/2023-07/msg01264.html > > > Due to the lack of news on the first thread, I've done some looking to > assess the feasibility. The xl.cfg parser looks a bit jumbled. Too many > things are visible to too many places. In general some pieces have > really needed some TLC for a long time. > > Note, some portions of this are semi-WIP. The first 5 patches are simply > overdue maintenance. Not particularly urgent, but should probably be > done. > > Patch #06 is rather more urgent maintenance. While it might not explode > soon, that is a landmine. > > Patch #07 is the first big issue. The roles of the various headers had > never been sorted out. The underlying issue was more the contents of > "libxlu_cfg_i.h" needed to be merged into "libxlu_cfg_y.h". Bison 2.3 > may not have had the ability to embedded things into its header in 2010, > but the functionality appears to have been present in Bison 3.3. > > There is an issue of what level of indentation should be used in > libxlu_cfg_y.y? Normally the sections being added wouldn't be indented, > but normally they would be directly in headers. I'm unsure of which > direction to go here. > > Patch #08 seemed best to leave after #07 due to overlap and difficulty > with reordering. I'm a bit worried about the interfacing with flex. > > > Then comes the issue of moving things out of libxlu_internal.h which > should never have been there. The XLU_Config* values should have been > placed in libxlu_cfg_i.h instead. Since I'm doing a thorough job, > they're instead moving to libxlu_cfg.c. > > I'm unsure splitting libxlu_cfg.c is worthwhile. The resultant reusable > libxlu_cfg.c is rather small. Yet avoiding the need to reimplement the > small portion is handy. > > > Is the decision to keep in-tree copies of current Flex/Bison output still > valid? I would be awful tempted to remove them from main/master, even > if copies are maintained on release branches. > > > Elliott Mitchell (22): > tools/utils: cleanup formatting of libxlutil.h > tools/utils: rename "n" arguments to "key" > tools/utils: remove old declaration of xlu__cfg_yyparse() > tools/utils: enable all Bison warnings > tools/utils: update Bison parser directives > tools/utils: remove libxlu_cfg_i.h from libxlu_disk.c > tools/utils: merge contents of libxlu_cfg_i.h to libxlu_cfg_y.y > tools/utils: Bison: switch from name-prefix to api.prefix > tools/utils: move CfgParseContext to top of libxlu_cfg_y.y > tools/utils: move XLU_ConfigSetting to libxl_cfg.c > tools/utils: move XLU_ConfigValue to libxl_cfg.c > tools/utils: remove YYLTYPE definition from libxlu_internal.h > tools/utils: move XLU_ConfigList to libxl_cfg.c > tools/utils: introduce xlu_cfg_printf() function > tools/utils: move XLU_Config to libxlu_cfg.c > tools/utils: move XLU_Operation to libxlu_cfg_y.h > tools/utils: move setting free loop to xlu__cfg_set_free() > tools/utils: spread xlu_cfg_printf() over libxlu_cfg.c > tools/utils: add pointer to in-progress settings to CfgParseContext > tools/utils: add wrapper for readfile()/readdata() functions > tools/utils: add settings get function > tools/utils: break flex/bison parser away from main config file Some of the patches looks to have been posted previously as a 7-patch series. It would have been nice if therefore this one was marked as v2, indicating in a revision log what the differences are. It appears as if at least one out of those 7 earlier patches was dropped (or maybe assimilated into another one). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:39:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576088.901833 (Exim 4.92) (envelope-from ) id 1qRTro-0007mz-Tj; Thu, 03 Aug 2023 08:39:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576088.901833; Thu, 03 Aug 2023 08:39:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTro-0007ms-QZ; Thu, 03 Aug 2023 08:39:32 +0000 Received: by outflank-mailman (input) for mailman id 576088; Thu, 03 Aug 2023 08:39:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTrn-0007mk-PP for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:39:31 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0629.outbound.protection.outlook.com [2a01:111:f400:fe1f::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42b32575-31d9-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:39:29 +0200 (CEST) Received: from AM0PR04CA0116.eurprd04.prod.outlook.com (2603:10a6:208:55::21) by VI1PR08MB5408.eurprd08.prod.outlook.com (2603:10a6:803:130::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:39:20 +0000 Received: from AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:55:cafe::e9) by AM0PR04CA0116.outlook.office365.com (2603:10a6:208:55::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 08:39:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT009.mail.protection.outlook.com (100.127.140.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Thu, 3 Aug 2023 08:39:19 +0000 Received: ("Tessian outbound f5de790fcf89:v145"); Thu, 03 Aug 2023 08:39:19 +0000 Received: from 80dc86cb0a2b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 272FC1CD-FB26-4604-B345-2468A09FF1D5.1; Thu, 03 Aug 2023 08:39:08 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 80dc86cb0a2b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 08:39:08 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB9617.eurprd08.prod.outlook.com (2603:10a6:20b:60a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:39:04 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:39:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42b32575-31d9-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=24UuytHTGu6W1sbBtxfuRtUA8GkKrUW9H/7CxJT7wNM=; b=43FsXKkm3bcuHgQTJMLATplBLoOYQzCZKdhXAZKA3vSUOvYS0/plDxNY0xDCbc9GeESPpNAH+BqP9MDj349fseldULRU31duuceQu3nqW/M/wX1hNKYYftFOuEjS+cOcJOwCZpANxlVXs6lIDshI/c2b2UXmdioQMSxLZt+2o+8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 64fe5bd1c2aa6dc6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZ23lFN038n8ZDBXy5oii3/ePupS7J/kaPHidYXZmmEpu8QJ7EGJcLNBO7rR4qBC3hyrmNUtpDymxG+XLW4ToAjW6kC8woT/AP41RqkXWNIyHpfap39HfoiiD/KctQq217kAxjK+uAu3KXGohse9u0eScvXMOE/gBa8oT70uFkUy5jOiJiUbDM4VDTSqzFhFusQBMh1yI28UdOxK7gCpK9n0WrixClNUqV884gPe2lZy/L3x4xxe9g6cxYU1X1/rogNXxeweSk251mg6XFi430/mF5bFZPiroiSlQbjSuzqV52dsBkv0ddaQe9IQMBkMeWRkAVBFhjdqJbJRnAo8MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=24UuytHTGu6W1sbBtxfuRtUA8GkKrUW9H/7CxJT7wNM=; b=adWpHjqwX+wWLqy+zQvB70oD4OAMaWtRvOf61f/K8LGPSaS/9VwLskEPpQabQ/XQOG3Bz+E/aTdG02/IKpHRh21K6liN6+B5W9bdprLdxDAEyVLwgqQxZXb2EqBrW4MGhR8GoCuKyMG3cvrHnWynushMFWeHzV9wLIAFf8fRFe+wiyYbW/up2xd5Nc4rbNAB3lnNbt9oKX33Mr8rftmbM12J4jXURfcWY6FEMX0ivvl0ZANwqdFiJYSO3aIttBnUnOGEOi8wTfWFV1HXGYYSjrtu9Yy9/2N0rERjk01GvZHImvGmOMPpG9QrkCzKZL5IPemGMuC/BxcYbrKQawZOeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=24UuytHTGu6W1sbBtxfuRtUA8GkKrUW9H/7CxJT7wNM=; b=43FsXKkm3bcuHgQTJMLATplBLoOYQzCZKdhXAZKA3vSUOvYS0/plDxNY0xDCbc9GeESPpNAH+BqP9MDj349fseldULRU31duuceQu3nqW/M/wX1hNKYYftFOuEjS+cOcJOwCZpANxlVXs6lIDshI/c2b2UXmdioQMSxLZt+2o+8= From: Luca Fancellu To: Julien Grall CC: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/XEDgAgAAEZQCAAAGbgIAABJqAgAArPoCAAOPegIAABcoAgAAIA4CAAAcSgIAAAn4A Date: Thu, 3 Aug 2023 08:39:02 +0000 Message-ID: References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> <33DCC5E2-7190-464C-B25A-68BC68CA4021@arm.com> <3942c22a-80e1-29bd-4bd8-15d4bc43d220@xen.org> In-Reply-To: <3942c22a-80e1-29bd-4bd8-15d4bc43d220@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB9617:EE_|AM7EUR03FT009:EE_|VI1PR08MB5408:EE_ X-MS-Office365-Filtering-Correlation-Id: e910746c-1a42-4f4a-364c-08db93fd2122 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: j6dKEaeu9v7FoOJAuYVf50/oruq1Kae+agxyJm9G010LsI0L5T/sqK3L5uMA9zGBKkS+4hRVqbFSqBP3cZD+rYDTEv0qQHzM6iVFjMjyKHd6Qi44aws1GsV6HBQ5oCS8pUrCu5DMkuDfhaWnBiPe/jnk45wvYB9H/nchgBJ5Ss8yp5h/nku++CYOo1q6XzgXVpx2RW4le3WZ5UjT6va/QAh8N/EJ//j9tZpuR7EOO9ap5ns0zi9ehlTuMWKihCBvft309Yu4TkJa7S4sPBcTmkY1NN0H0sLpaPGOx/qHBvsEtfHCbzJ453vJjTyHpxaWcXeDBHW/GRUv4C54C9b2Yccy7fPgnFPpp7DpzEXAlc/Ua1KPS8MEky0guB9KsuwPSinthddRHtqSZuNDNrPNm4xckap24TIHmtGzbih5AG7rl9LclrPdightIQ+sQ1ce+mAqKsoXs4f0I2p8kdrwU+H2D8uB6wjvNFJB8nbFeSCxhEAzCglA6Akc4gxazMKVh5YsZU1tm/oxHyN/2W15Oahqtf1ZSRZaplwCYJbc/Q0e1OHC1edMB+WVVQrHlJqYdkvYMNoQbdjrq0GXQX9puekr8Yc18u4E+k026aeAnMqkpqesixhkm1EdSxwP5dhJpCKHlHGi+dK039SLeC3B5w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(451199021)(38070700005)(36756003)(86362001)(33656002)(54906003)(478600001)(38100700002)(122000001)(41300700001)(2616005)(83380400001)(186003)(26005)(6506007)(53546011)(8936002)(8676002)(6512007)(6486002)(71200400001)(66556008)(6916009)(5660300002)(4326008)(316002)(66476007)(66446008)(64756008)(2906002)(66946007)(91956017)(76116006)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9617 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1732d8af-f9eb-40af-6bc6-08db93fd1744 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hzkpuR2sqAJyKs1Sk7NDEfc8SAE6dV4RcjSGILTuqa9cBo84kCiRlamgynKv6SCVNfqyBwjiFW55w+g/m1r5DAuXqZIS4ojl1375rDrqEmpCUFJbDfzxkHJVHZVczCqSspUYDOtB9gNEB8f+U+Jy5ig3fDd2exZg+dY22bI8fg7L8w8FRY3WD8CymrQ2GXryArs41PebX9NKq6Ip2fybaxLLsEG4pfIikGOscy/z7ZN1i70N4JQZ/ck5RZozHtyvWnppmokHXGJS/G4qnhUBjjbRax+QVn2q4rHoGdOifnquSXDAmE5hXxmccXtSbOn8oFyxBCwPY2IWso2e7VgSX624G4nMyllfIbGbsRmjrNCXakojlwLaKs0AMvu+lmg06XBakAvIaTYiSl9PJDMdKdcvGPaoyU3wEOcy/CMoZ8M/7GVND3VHAahuKnvAjQiUM+N4tfRqy0Q3jiDAN52y6Fewp/4Qc788ezvoqgp17QKd7MzmvzkKhIjwdUrCpWktTj/3wUAKwy7JFfQdv0KqU8AYuZfjQqCE/zXZ5qHb/tUZSKcJ4CQS7Il6n/4uahx7KssbhqW8dJdrcM6O21NFxTvjNQVNqIXUgaT300H/Lf5n56+RbQ8a6hpzsc36/eYrPVHbA/yTxiu5yrXze+LfM2jlaTF8BqVCCUWFy4uqH45E5A2KFX/rj1Lx5phD/Hy12C7K6GsApZLkCs59Ga54T4p1qH2TNMx3sv+FIPSRmLHVOIvG7x2P131GYFXpr2RF X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(82310400008)(40470700004)(46966006)(36840700001)(40460700003)(2616005)(107886003)(53546011)(6506007)(83380400001)(26005)(186003)(336012)(47076005)(36860700001)(316002)(2906002)(70586007)(70206006)(4326008)(5660300002)(6862004)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(40480700001)(356005)(81166007)(86362001)(33656002)(36756003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:39:19.4175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e910746c-1a42-4f4a-364c-08db93fd2122 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5408 DQoNCj4gT24gMyBBdWcgMjAyMywgYXQgMDk6MjksIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwMy8wOC8yMDIzIDA5OjA0LCBMdWNhIEZhbmNl bGx1IHdyb3RlOg0KPj4+PiBUaGVyZSBhcmUgc28gbWFueSB0aGluZ3MgdGhhdCBjYW4gZ28gd3Jv bmcgZHVyaW5nIGVhcmx5IGJvb3QgaW5jbHVkaW5nIHRoZSBlbnRpcmUgYm9vZmR0IHBhcnNpbmcN Cj4+Pj4gYW5kIGhhdmluZyBlYXJseWNvbiB3b3VsZCBiZSBzbyBkZXNpcmFibGUuDQo+Pj4gSXQg aXMgbm90IGNsZWFyIHdoYXQgdG8gdGFrZSBmcm9tIHlvdXIgcmVwbHkuIEVhcmxpZXIgeW91IHdl cmUgY29uY2VybmVkIGFib3V0IHRoZSBlcnJvciBub3Qgc2hvd2luZyB1cCBpbiB0aGUgbG9nIGlm IHRoZSAuY29uZmlnIGlzIG5vdCBjb3JyZWN0Lg0KPj4+IA0KPj4+IFRoZXJlIGlzIG5vIHJlYWxs eSBxdWljayBmaXggZm9yIHRoYXQgYXMgYSAuY29uZmlnIG1heSB3b3JrIGZvciBwbGF0Zm9ybSBB IGJ1dCBub3QgcGxhdGZvcm0gQi4gVGhlIG9ubHkgdmlhYmxlIHNvbHV0aW9uIGlzIGhhdmluZyBh biBlYXJseSBjb25zb2xlLg0KPj4+IA0KPj4+IEFueXRoaW5nIGVsc2UgbGlrZSBmb3JjaW5nIHRv IGFsd2F5cyBoYXZlIG9uZSBHSUN2WCBzZWxlY3RlZCBpcyBqdXN0IGEgaGFjayB0aGF0IHdvdWxk IHdvcmsgZm9yIG9uZSBzZXQgb2YgcGVvcGxlIGJ1dCBub3QgdGhlIG90aGVycy4NCj4+IEkgYWdy ZWUgd2l0aCB5b3UgaW4gcGFydCwgd2hlbiB5b3Ugc2F5IHRoYXQgaXQgd291bGQgd29yayBmb3Ig b25lIHNldCBvZiBwZW9wbGUgYnV0IG5vdCB0aGUgb3RoZXJzLCBpc27igJl0IGl0IGFsd2F5cyB0 aGUgY2FzZT8gV2UgYXJlIHByb3ZpZGluZw0KPj4gYSBkZWZjb25maWcgdGhhdCB3b3VsZCBmaXQg dGhlIG1ham9yaXR5IG9mIHRoZSBwZW9wbGUsIGJ1dCBpdOKAmXMgYWx3YXlzIGEgc2V0IG9mIHRo ZW0uDQo+IA0KPiBDb3JyZWN0Lg0KPiANCj4+IE1vcmUgc3BlY2lmaWMgdG8gdGhpcyBwYXRjaCwg d2l0aCB0aGUgcHJvdmlkZWQgS2NvbmZpZyDigJxoYWNr4oCdIGFzIHlvdSBzYXksIGl0IGlzIG5v dCBvbmx5IHByb3ZpZGluZyB0aGUgc2FtZSB1c2VyIGV4cGVyaWVuY2UgYXMgdGhlIGN1cnJlbnQg c3RhdGUsDQo+PiBpdCBpcyBkb2luZyBtb3JlLCBpdCBpcyBwcm92aWRpbmcgYSB3YXkgdG8gZXhj bHVkZSBmcm9tIHRoZSBidWlsZCB0aGUgR0lDdjIgd2hpY2ggaXMgbm90IHBvc3NpYmxlIGN1cnJl bnRseSwgdGhpcyB3b3JrIGFpbXMgdG8gcHJvdmlkZSBhIG1vcmUNCj4+IGZpbmUgZ3JhbnVsYXIg Y29uZmlndXJhdGlvbiBzbyB0aGF0IGV4cGVyaWVuY2VkIHVzZXJzIGNhbiByZW1vdmUgZW50aXJl IG1vZHVsZXMgdGhhdCB0aGV5IGRvbuKAmXQgbmVlZCBpbiB0aGVpciBwbGF0Zm9ybSBzbyB0aGF0 IHRoZXkgZG9u4oCZdCBoYXZlDQo+PiB0byB0YWtlIHRoZW0gaW50byBhY2NvdW50IHdoZW4gZ29p bmcgdG8sIGZvciBleGFtcGxlLCBzYWZldHkgY3JpdGljYWwgYXVkaXRzLg0KPiANCj4gVGhlcmUg c2VlbXMgdG8gYmUgc29tZSBtaXN1bmRlcnN0YW5kaW5nIGFib3V0IHRoZSBoYWNrIEkgYW0gcmVm ZXJyaW5nIHRvLiBUaGlzIGlzIG5vdCBhYm91dCB0aGUgcGF0Y2ggaXRzZWxmIGJ1dCB0aGUgZm9s bG93aW5nIGxpbmU6DQo+IA0KPiBzZWxlY3QgR0lDVjIgaWYgIUdJQ1YzICYmICFORVdfVkdJQw0K PiANCj4gTm93IHRoYXQgR0lDdjIgY2FuIGJlIGRlc2VsZWN0aW5nLCBJIHNlZSBubyBwb2ludCB0 byBmb3JjZSBzZWxlY3QgR0lDVjIgaWYgR0lDVjMgaXMgbm90IHNlbGVjdGVkLg0KDQpPayBJIHNl ZQ0KDQo+IA0KPiBBcyBJIHdyb3RlIGVhcmxpZXIsIHRoZXJlIGlzIHNvIG1hbnkgd2F5IGZvciBz b21lb25lIHRvIGNyZWF0ZSAuY29uZmlnIHRoYXQgaXMgd3Jvbmcgb3IgZG9lc24ndCBib290IG9u IHRoZWlyIHBsYXRmb3JtLiBTbyBzb21lb25lIHR3ZWFraW5nIC5jb25maWcgc2hvdWxkIGFsd2F5 cyBiZSBjYXJlZnVsIHdoZW4gc2VsZWN0aW5nL2Rlc2VsZWN0aW5nIG9wdGlvbnMuDQoNClllcyBp bmRlZWQNCg0KPiANCj4+IEkgYWdyZWUgd2l0aCB5b3UgdGhhdCBlYXJseWNvbiB3b3VsZCBiZSBw ZXJmZWN0LCBzbyB0aGF0IHdlIGNvdWxkIG1ha2UgdGhlIHVzZXIgcmVtb3ZlIGV2ZXJ5IG1vZHVs ZSBhbmQgbGV0IGhpbSBrbm93IHF1aWNrbHkgdGhlIGlzc3VlLA0KPj4gYnV0IG9uIHRoZSBvdGhl ciBoYW5kIGl0IGlzIGEgY29tcGxldGUgbmV3IGZlYXR1cmUgdGhhdCB5b3UgYXJlIHJlcXVlc3Rp bmcgKGFyZSB5b3U/KSB0byBtYWtlIHRoaXMgcGF0Y2ggZ28gZm9yd2FyZC4NCj4gDQo+IEkgZGlk bid0IHN1Z2dlc3QgaXQuIEkgd2FzIG1ha2luZyB0aGUgcG9pbnQgdGhhdCBpZiB5b3UgaGF2ZSB0 aW1lLCBpdCBpcyBiZXN0IHRvIHNwZW5kIGl0IHRyeWluZyB0byBlbmFibGUgdGhlIGVhcmx5IGNv bnNvbGUgcmF0aGVyIHRoYW4gdHJ5aW5nIHRvIHByZXZlbnQgdGhlIHVzZXIgdG8gZGlzYWJsZSBi b3RoIEdJQy4NCg0KSXQgd2lsbCBiZSBmb3Igc3VyZSBzb21ldGhpbmcgSSB3aWxsIGludmVzdGln YXRlLCBidXQgaW4gdGhlIG1lYW4gdGltZSB1bmZvcnR1bmF0ZWx5IEkgd29u4oCZdCBoYXZlIHRp bWUgYXQgbGVhc3QgdW50aWwgT2N0b2Jlcg0KdG8gZXZlbiBzdGFydCBhbiBpbnZlc3RpZ2F0aW9u Lg0KDQpJIHdvdWxkIGxpa2UgdG8gYXNrIGlmIHlvdSBzZWUgdGhpcyBvbmUgZ29pbmcgZm9yd2Fy ZHMgb3Igbm90IChhcyBpdCBpcyksIGJlY2F1c2UgSSBoYXZlIGEgc2V0IG9mIHBhdGNoZXMgdG8g aXNvbGF0ZSBhbmQgS2NvbmZpZy1vdXQNCnRoZSBkb20wbGVzcyBjb2RlLCB0aGF0IGlzIGRlcGVu ZGluZyBvbiB0aGlzIG9uZSAoZm9yIGEgc21hbGwgYml0KSBhbmQgYmVmb3JlIHNlbmRpbmcgdGhl bSBJIG5lZWQgdG8gdW5kZXJzdGFuZCBpZiB0aGlzIG9uZSBjYW4NCnNlZSB0aGUgbGlnaHQgb3Ig bm90Lg0KDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:42:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:42:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576092.901844 (Exim 4.92) (envelope-from ) id 1qRTuA-0000p0-Dk; Thu, 03 Aug 2023 08:41:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576092.901844; Thu, 03 Aug 2023 08:41:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTuA-0000ot-Ax; Thu, 03 Aug 2023 08:41:58 +0000 Received: by outflank-mailman (input) for mailman id 576092; Thu, 03 Aug 2023 08:41:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTu9-0000ol-A8 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:41:57 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0628.outbound.protection.outlook.com [2a01:111:f400:fe02::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 997c99b8-31d9-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:41:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB7989.eurprd04.prod.outlook.com (2603:10a6:20b:28b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:41:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:41:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 997c99b8-31d9-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4g41+gvolXteh4lu96LCzOh+jH7vUgMYcYo72e8zT7/cPmugqNppkmE8UejuQxNZL7jF+1W6iH79TvtzV20dUWPoDAvIniACM4CGDqnVREa7b5Wo+QjXovetClJ9nkxKB6rrT13q/2+CYFMIAjQcRdAUfQ/1Qg6JESLgc0h+rHWJuy3FshRNXtp63pDfwbnhsaK69Fv/soeurSEh1DLc/eU2m2Uy9wZQyi5oOGniy5HJJQD3iuDEJSSvECT81nN1+/85F9EsRKqJe/DW8MloBDUu9/1Fzt1An0KrEoMiWepkxbM1Tw7wmMNombAx6GZqKw+wj/CXyk6bPNK4ejIeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3O1vSwflEAE9qOo/cmIsG9F6LMui8WCEtFaeweP8yEo=; b=R+FYtC5Sje9k7PXSAzYVx9utIcxoEMSikQaoElPSPEjpxVwQvPzhfxoQfBBrtdaRYboWmZ/izX6WdSwtDVR5jysZmQTVjVT4C/+2Z6yZqvR7l7sqQfLNTZUVLE4PI0k9x/Q5JVHFHhtyqE0loZAA+CkRVP6ewzxN4Uaw5fneQ6dgDDgWpHQ7anb0O/ceybMsPXMNxq9bErU126Dw0+kNMN/8hSGsro2PQjEvdtMY2hZbmlEyW3bIfhoHEoe/Rl0NSHj+0YusOIMIC9ELDrPuU0qgp/baK7vArQscqd2dJipyzw3F4IQT8tAObHkKIcODWNr4A7Jc7PiLbHTjZczLtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3O1vSwflEAE9qOo/cmIsG9F6LMui8WCEtFaeweP8yEo=; b=X+y5bOBqgOI01VAXxhaT+7zUExeipsrPFz1haFks03JKewybHMTSjfkvQXN3zdC9B41gJ4WxtBpzKnf3gYnml79W6qVVlhSoOltnGbQfG7dpOVjVVVbjy6Mx5l40n//UHOFtw8v/XTN/3iu+LdHc6AUDQJ0PPl10ZDwOou50lN0ZHgpGAltLDvm8zshS2FBUycnk41HBhkY7q0xCc7RO9FZDsabKgMNa34FLH0a3Njm+sPDGM/9anHc2YANE/fY0At66/EID82RvFhcvIsDgeLh4WSVwar1P9uCAKSNEUf8nvG8xLDyeFZ8LUnn5VGapsvqqRmJd11w1L6JQ9saliA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 10:41:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Stefano Stabellini , Nicola Vetrini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <16fa23ecb465442c566a18af0a569092075eef26.1690969271.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB7989:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c941f1d-c4ba-464f-b1fa-08db93fd7cb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 04lM+C9c7+hcrrAhG2Y+6xbBNxAgnDF40QZutwzkUIJhWvqiC8lKxWtPi2ATTwuhZ7vU8Jgd0GmzxeB6rHba1dzuLd4+i9pvlXgUy8k50OLnRe30bIZITrUFrWu4fhttLyPododCq+Wyh0GV3x/OqJPFWdw3rh3ZMjoxWXxLgAJ2pnlGRnT8wT0yyAEPopFX7LEOSqTPTkns07gEGOuAI2hUZJyvSsEzqZj+FkrqL/AKGLe2oK1nw9NdChsmb8+QiCfC4iRLHzgW+EqD0T1GPDZKxeVrKtY484HGrzktZtdlK73wXygeYYPMzrj0vxgPDiF2qP9UcxbeqGASAsin11ZNa3MGhwuhNyFwm+bsuxf2LeVDz0hBqegnIB4T9V1RIo6SaC6B07LnCMJXH0hESAD3XuD+8ChfF0VKGNf+g6Oxw8YphCKYnZ6MCTOvc+5F6IOvJAZawNUKoETy7wF5kBY8yJCdwHaBaKI+tD8YlVt60n8R+Qjfvuyx1RHh+1gqOdBOfKRyXOG0Yx215RcCav+C+Q3BgpmfCSSbSc8WfzaMNepPBG/e2ShsTTDPXdGrR1BxIrnJoxdFXd+WIeEpxPno6pUEqe5Abzyz9HYrxJtRRRvR0pxTCLzGWsPtYnhBDJKb0bdtu3BP0YvHylx10w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(41300700001)(4744005)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(316002)(7416002)(8676002)(8936002)(6486002)(6512007)(478600001)(54906003)(110136005)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDg4OEJzb0NOTEJkQ3pqZDVWdTlPTEdqU296UkpKaytNUlVFUDNUUEZmT2g2?= =?utf-8?B?SUNyZkZGczRUVTI1OG5vMU1GTUhMS2tMOExnT3ZQWFd4anRsQk43WnRZdXJU?= =?utf-8?B?M3ljZHBJSGR4TDRoV3JIeGdXSXdqV01MNUdnWmRKRklrZkVhbFA0b29rZzlX?= =?utf-8?B?SWlTWkY4WDkzcGc2UzAvODZ6dGVJamhZQTZycDU3dk8yWGIraU9FMWxHa1E4?= =?utf-8?B?dkdycFJBNUJ2bjArc1BqQTgra0RQQlFaYjh5K0pHVXYrVWEvSThJYjhETzdS?= =?utf-8?B?dE9SS3lVVUIrYUZRMkMwWjIwVWFUbk55RXkrS2pkdHRDaVlGd0ErcUMxUzUv?= =?utf-8?B?SU5jS2VudS8zZ3B5Ym45ekxRQWNxSWs1V1ZtTFJRUHRZQ3JKOFVSdmFWZUFF?= =?utf-8?B?RUdGMk1KckRLTEVNaEQwOTFIcWptbnZmbHpnVDFzRGlHUWNIdTFsZGhqOUho?= =?utf-8?B?WFdHek8vYXRWcmhaeFNENm1BemRWeGxXdnN5VDdZSFFOdTAwOHltNzErMzVy?= =?utf-8?B?SzVvZXlSMkVTbENzTHFDQkxKVUdtS0RGdXJ0eDR4NXg4YnNmWFFuaUp6YWVi?= =?utf-8?B?ejhpVzYyRTVhZjFUNHFKWm85NDQxc25oTUtmUWZuMEJzYjFsQ1I1aHlwTm1W?= =?utf-8?B?T0lLek81a3FMZG13ekU5clNMa01mVlp6bGpXNGErN0pWbVh4VWxqZVNZYzV1?= =?utf-8?B?L0U5Sm02QzRDRWNId1JNOExWZ3pMUzBGendUWitCbnRjVDNtWHAvUHRETHEr?= =?utf-8?B?bS9rTFVDbXAvZmozUERaU2d1azY0K0pvRmI0R1dLeWFvMy9yVnN1bkdnbmVT?= =?utf-8?B?TDV3dXRoWkNPRDkxMlVMbGZaNVRqN2ZNM0FyeHQ4UzBMWjFNS1Ixcy9GbDRv?= =?utf-8?B?RGhyN2tFUXNEWktMMWVFeCt0N2h2QjJKWFpobnI3TDE4RXdaZEsyaGRVSGls?= =?utf-8?B?SkYwck5iMzZuM2RDb3Fra1dmbXhhSXpuLzJIcWRqc2kzRjltUklMakN6ZmJI?= =?utf-8?B?dmw4MERxMkVRa3RvdEFJWk4vWTF0T2pCRnRPdVFhWFA4NjJFZEdaRVZ1Tmx5?= =?utf-8?B?YVI2RjBtWGZhM3RLUFhMNC9ZZlN0Mk9IM0JUZGRQZll0MUFRUlUwZ3FJci8w?= =?utf-8?B?YnBVSWVKOTZKRDQrcjFVcEEvRlBCaUhqRjg1cGZndy9qQzFwcUZyaUtvbWZR?= =?utf-8?B?cmkrTWFJUWIwVU02bFdIYU5wTHl0ZHhQRm9oU2FLREdpVGxndUVsU0hEZ3RS?= =?utf-8?B?UEpBZUJyOTQvU0xFMk5uVlRDakxHQ0NuaWtBbEZUWXlKSnhHMUdqQ2t0Q29S?= =?utf-8?B?R2N3V2hIZCtQK1pHTGxyTEJRL0wvNFhYdmJLOVhuV2tIdTlVYzd6MlBtbjZH?= =?utf-8?B?ZkxKRk95aGFFTFBnSmMzQ0Z6Tld2TUVxVWhJQXdBUzF6eGdEOWZFMGZWc2E1?= =?utf-8?B?aHg5MVlaL3N0aERLODhHTFdiNzBLTDJuZjZWNVE5eW82U0lFbmloeFNBTDdl?= =?utf-8?B?MExjZCt1UFdWWjFDZTVkNVBNTWdOVXdnSVZwVXdCSDFLcUkwVXQvTmJCOTdR?= =?utf-8?B?VFFrSG5KV2dCRVpnTGlrb0lzcGc3d0UxUEZkQ0g2aWNKK0tFZ0pFZnVpSGlo?= =?utf-8?B?NFZjeXRFeDYyM2Fpc2s4WVNaTTduMjRSb3diMGdGb1RTRksxbmlMbFRWMU1v?= =?utf-8?B?VWZsc2N6emE1OVZyeDFkRCtSNG4vZkpBRFVoWHZ2d0NFMy9jbTV4bVhFQnRQ?= =?utf-8?B?UmJTaWRzYzdhZHcyS21vdmY1TmVKWDdDaDd0QWlwZmNDcjlMbW5oc1RLMGJl?= =?utf-8?B?N1lZSENKdFlkQVlzakllRmlhelppcnpERjZjRy8yR1Vhbjk4d0kwVndLZXM5?= =?utf-8?B?b3ZzaWlhdVU2U2x2OHBOcW40UXBhOCtEenBsY1d4MTB5Zi9PejFodmNpVHBQ?= =?utf-8?B?V1lHNktKMlRzOVJiaVZLMGk4N1QzcWE2N1UyQWEwVmhlWldqdUE5dDhGbWxN?= =?utf-8?B?VmIxYThCQUlyNHJHMXBRZnNJM1Q3NGFKVi9CTWRwbUpTTnFxOUNxYWk4cnR4?= =?utf-8?B?WGw0amRUbjQ2YW1zMGxJeDQyTFJMVWkrMlJqRFFmMDhlMHNzY0xiNTQyM1Zl?= =?utf-8?Q?HNY0z/yN3m2ZI6ZTxngub9nd3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c941f1d-c4ba-464f-b1fa-08db93fd7cb3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:41:53.3059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DyqGVNAUDgr+j4iqPBwXKf8WmlTHXqxlJusXxeumBhW2AHH5vyuQ+bGfFp7wwhxYztgIcnUWYxztEYZHR81pBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7989 On 03.08.2023 03:51, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> --- a/xen/arch/x86/hvm/mtrr.c >> +++ b/xen/arch/x86/hvm/mtrr.c >> @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, uint64_t gfn_start, >> >> static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) >> { >> - const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr; >> + const struct mtrr_state *mtrr = &v->arch.hvm.mtrr; > > I can see in hvm_vcpu_cacheattr_init, mtrr_get_type and other places > that we use: > > const struct mtrr_state *m > > maybe that's better? I'll let Jan comment. When unambiguous, personally I prefer shorter names (and as you say existing code supports me in that). Obviously the longer a function, the more potential future ambiguities also need taking into consideration. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:43:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:43:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576096.901853 (Exim 4.92) (envelope-from ) id 1qRTvw-0001OB-On; Thu, 03 Aug 2023 08:43:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576096.901853; Thu, 03 Aug 2023 08:43:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTvw-0001O3-Lm; Thu, 03 Aug 2023 08:43:48 +0000 Received: by outflank-mailman (input) for mailman id 576096; Thu, 03 Aug 2023 08:43:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRTvv-0001Nx-7d for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:43:47 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20620.outbound.protection.outlook.com [2a01:111:f400:fe1a::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dbb06ce8-31d9-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 10:43:46 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8333.eurprd04.prod.outlook.com (2603:10a6:102:1c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 08:43:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:43:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbb06ce8-31d9-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WQ1SLYyj7jEm3ynpPOMAF2rCMRh3VH/WuEtnsNEaWqpNM7xvS1adCsihGJJxej+Jgt6+c6wpVHLXqM3jGzgRUe0Egnh/UJjon6zSVUP5wT0PPrh+WGb841RY85T56GAcYVG0ogb0nlVVOhpEWwL7WwmfFtbXSxVBXFoPdjJ779jmDrerdgcPBH9RsHN6Ff/FilitPHmg8uplzyITxYjZxfWdaA2kVdJlpasfEG4qdSHSQ7AJI3vW0GOPAcMRu0tT1iTdoWKVOkRlAQHNuVyshB4GnkqN9I+c7qH1jsK2gJ7DHjWpnMYmZm6ACjH7HDcSTf1CUnpJ9YJ7Co8Fa9YOvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0+U+7andq4PMomAokpMT4FjNJbi+2tsGvsddXhjZ8fo=; b=Aywp4c9NIEiybV8Ge18wJ6h4c5dyXZtUrkd/+y9rZGV5IY4rx//xmE8vp/BGfbIqYP2EUk7EJYsV2dzD9uM/s/x4clFv2ehOCp3ukch3LEkwkseQajUdt7usPhX6SZCsF3nQ49gnCSpNAlcBcAUrrZ78m0PchbSCRTANoo2y2fVeiSqRJOFMoswmc35i24nLlqlsSuyXlNdrdxnlFmQXQdD2fY39AIemASlbDtPNzUSe8m79Vl9mOpbnASRm4C2ZLjAqcmIlVkmHMOb61CPewmdX634V84uf0ueYOI/HnYkfN90f/RHiQxAZ912JY5X1mY1CGHRUPb5+kpBjZtkEWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+U+7andq4PMomAokpMT4FjNJbi+2tsGvsddXhjZ8fo=; b=GyKdc2NQkzuQKosPW6MTRP0u+X1e+unh6aRSLYEwJ5Ee6pK4q++WD3mDytjG0fpwpGNDsz0JAbsz2FFTVIMIeInfDZzCI3naqlBTcuMEuOFy+SJs/qB6GFKn2AgRRp8Cx8vGkcTVJxulFuWvuceGsbm8vVVjjVx6Nxq1gW8rGuYgc1hofNTB/5xMiSa4RAS12rGkx+x2rakdItb4xsYxE2RXyTNrxaNyUG/O0LmoOUOHDiNq6kmEHNYpbiXSJFBCIiXCMH24gCdCjfRwgfkKvhd0pbh9SpuL2J5P3FZtvg4IeZCA0gaVwkGk/RRUtGWu/qQasbYLc+9QLBl6c3fnmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e89a09e-ed5e-5322-2b94-4547d930ac7f@suse.com> Date: Thu, 3 Aug 2023 10:43:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Nicola Vetrini References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8333:EE_ X-MS-Office365-Filtering-Correlation-Id: a12debc3-1298-41b7-eefd-08db93fdbe7c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /Bb3q3dhpnI0uRrD2oF3I4MW7hyOoNwW1NVhg0N2CYMtJgRsJ3oiSRCQI+Urawgd2JsnjnA3gTB5NI4Ox9MGEcsJloo/DTA5pg5LbWd9a57M/KvoJatCGKXVQXQDqfjaCAWTxesq5si+QjUQy3QUsIb5QdIWRWsFclJWLJkfxJzMd9w40qgx4fqf+USf9HWsfcfjOUlb1FBaKcc77zj0EeE7cgFCHY4RhXsAoqhxLUmzP5JxTh4n454gCIVk5TRyjX8VA4qGZvqRSDHer+n/5rcaU5YconQwXezBmr5ggsfyBcL+jiYdmwMLxJchXB6dZVdvIzlhI74WbFGjxuiF4ObzFzNp0aH/5vtIKR0RwQiLuh7yR//WRtHOMun+PLzkMVe6VtQuY5MIuh9KOJ4Eluf3oIRzJF6u6pbkXiG3/V+9SYbcEb96x75Cn7YUtNpA/KdkR2BhbHbLvggUtOO76o8pgGrJm2IGvk7oikxKRrEAvrQa5oq8GfrtaMNkLC/pg1OqQWmCKGDE7X00RBKEPafS4uLYlJtqCxmRebpwG6JoxbpGh9/d6ln19VccZHPKBIfSAxDt+s2O+ocQWk2+6u0Y0Y9BBVO6KKiB2w6g2OyyNERROh5yRaWnNZLW8kI4m63UwHXBKaLGYgZk33bfjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(4744005)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(7416002)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(38100700002)(31696002)(86362001)(36756003)(31686004)(66899021)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmNPM0JralEvcGtOS093YlR3bzYraHdDazlDUitKVEdNRDBLem5pMVlQb2dV?= =?utf-8?B?TDBhZGFYeEhDYjJnSlIyaS8vVnB6NzlpdWxFcFlGTjRMTCtoZ3Y5UEk2K2s4?= =?utf-8?B?ajE3YjVlUWwyWnpraVlJMTFRNUozSEJJeVdoWG5ZeVNWbmhyK2VzeU1EeERE?= =?utf-8?B?Y05FcmxXWFNJZWJsVHdXbVlER20rL0N5TkFwazhDNE02MGdvU1NjajFaMlpu?= =?utf-8?B?OEZZWWFUd29vZG1WaFl6SDRBZWhFcjdWZkZYWjFURmIvMUxFbFRtbEIrbFEw?= =?utf-8?B?SDZjUlU5MUZWRndZR1RZTTl1UDlrU0JnUXJ2SWlUcVZHQi9Ba1BTL1JpbDN4?= =?utf-8?B?OHNibU9BS3ZQZjUvb2tDSzNEWVlTaXVkTzNZd2dMVk4rekYxdi9YbXZwQTFJ?= =?utf-8?B?NGFBRE8yUVpXQzd0UGVUK0hTZDZmdlN6Y0F4SVBvOUd6SjdhdTBXdndVaGd1?= =?utf-8?B?ekRQODZMQVNDR2NWM3VDdGk1VlQ1ZTZIci9XaVdrdEJGbWphOHUzeHREL1JR?= =?utf-8?B?Rms0WE5ycDdwa1dyVFpzSGJLaXdCUkJJeEdQanpLSlJUc0lwSFlCa0dmTGJI?= =?utf-8?B?dUh3cC94cjRUUXI3V0duK2VxQllyMGRYSEtFTVNWMjRsNnlHMEFRdXE2ZnlN?= =?utf-8?B?cTZhRzRFbm90bGNRaE5qZlYwd2R2MGwyZWsyYjZFL05mL2lreHQxK25Wc0Zm?= =?utf-8?B?UVFwVjhZMjd4Wk5nc25RNmtQY0FNNFdlcklUUk9SS3ZoOGVaS2VFRk1iQ3dT?= =?utf-8?B?akp2NjhuVWVJZGQ0T3VnS0Vld0pIUUpWR2VBaWwzbVMwUDV3RElEZkhlSERm?= =?utf-8?B?Mmc0SFZjM3dkbmo0Y0ZRYm1VWk50UmJWQzhPZWd1LzFNdVRYZ0tES1hNcWJ1?= =?utf-8?B?Z0h5dHpjSnJxZ09HWEdtZm5GYlpCTTBXM2liRHZBbjdzcGtMVWkwc2hrR3JJ?= =?utf-8?B?bXVWYnZ1RVBOd3VaRUxMU1ZhRWU4T2JCd3BNWE5nTy9Sb0hTWVR4dkRwc0sz?= =?utf-8?B?dFZvZTRycjM5TWljR3RubmVWcG5MYVJieXdZN050NjFjWmZnN0QxTTBMSy9n?= =?utf-8?B?S0NSQVlPZEl2dWhEWGdyUGovU3ZDTGNjS1JRbktBNk9mOGM5eE1yZ2k3Z3hF?= =?utf-8?B?UzlRdWJMMVZlK3ozOTU2d2p4UGtQV29HTFVVSmVJcnFVU29kVUZyOHdMVG5Z?= =?utf-8?B?K1VRZCtmMkZRWjBYczhKWStjTnVNcXRnSFdBN0pzbzloVmsxTUloNXduYnZv?= =?utf-8?B?S0pJWU9TQzdjZjM4UjNkS1pYS3Aza0JFUEdBZlg1WVIyZElyWVJIVTRXSUUz?= =?utf-8?B?S0ZOdlJ1UnFZWkFnK1hSQmEvWE5sblNhSlNHS1E1T0xuaFNiQTZGZDJxamVR?= =?utf-8?B?MWlwRGhIQkdpd1BESDFCZ3RLWk5RVXExaWR0NE4zS2Z6MWpseEhFOFY2YkFW?= =?utf-8?B?RnFWYS9OTW5oNUdSZnpjMWFpbVlBREtDNDdBVWZGZjZsZmdmMEJDejdsaVZF?= =?utf-8?B?QWtKcWlQSS9HMFVXeFpwMFhTdGJyQU5xOThXWk5UeTFHQmRuNWtYRmRRNUFh?= =?utf-8?B?SUJqcnNsZldRRFQySGRNbG44dGM2Z0QrbGhGVHZjN1l6VFR2NGtvcWFVYkF2?= =?utf-8?B?d3RjeFcrY1MrbktTRUNSRndBVW5YcUFUTVJ1OUxnV1JHaTZHaGNHdG5wZm5j?= =?utf-8?B?V29wK0hjUVlKRGFGZlRwRkUrenl0TTFEYlBDWWFLeVNuV2ZtRjI3ZVBML2lo?= =?utf-8?B?dkl1ZWltcThRTHJQWHlzNWEydW44SHJlT2dGUG90aHBSaVhwZktyQ3FXS1NO?= =?utf-8?B?OFlwTWN3d1lHQjBxdlEvMnQ0M2k1bWxRYUVzOFdhNjd2MlBJTEU4NWdBNG9P?= =?utf-8?B?TXdtRXg2T1RqeFg3VTQxYndPTnQwT0hnZ1ArUEpuL01ydkgwOG5HNFV1RkdF?= =?utf-8?B?anBYUXdpaHA4Z3lTNFdWRzJqRi82bk5UeVhvcE1MSkFtc2d6aWxEdDNZdWlj?= =?utf-8?B?dzZUK0JMZEswZUlycUlRTVl2VERmVnUyd0ExYmh6Tmo3SlJIQnVKMC9sWjAr?= =?utf-8?B?MHp6OVFpcXFlM1k5VzNxeFJydGxLUFQ5bDdmVS9BZE5yS2cwcXlFeGRFL29l?= =?utf-8?Q?gmFRzoBiJxWj50Fu9ny1fPNDA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a12debc3-1298-41b7-eefd-08db93fdbe7c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:43:43.7664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I377kftQ2fYXwC5ibwuo202sAtBAOBn6MJWLFRmT7C3ftn6dcRPK0Dl/QSdpNpL/GmKkKOx/UBcecKahcXMoSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8333 On 03.08.2023 04:00, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> The extern variable 'irq_desc' defined in 'irq.h' is shadowed by >> local variables in the changed file. To avoid this, the variable is >> renamed to 'irq_description'. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini > > Reviewed-by: Stefano Stabellini Btw, Stefano, could you please trim context when you reply to patches, and when you add no other remarks besides offering a tag? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:54:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576102.901864 (Exim 4.92) (envelope-from ) id 1qRU5n-0002vs-Lh; Thu, 03 Aug 2023 08:53:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576102.901864; Thu, 03 Aug 2023 08:53:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRU5n-0002vl-IL; Thu, 03 Aug 2023 08:53:59 +0000 Received: by outflank-mailman (input) for mailman id 576102; Thu, 03 Aug 2023 08:53:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRU5m-0002vf-88 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:53:58 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20630.outbound.protection.outlook.com [2a01:111:f400:7eaf::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47519263-31db-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:53:56 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7347.eurprd04.prod.outlook.com (2603:10a6:20b:1d0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 08:53:54 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:53:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47519263-31db-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyNMHPm4+0iQixansHIXlRtHwcQSqJMfDp7ZWha5Koyp0uI82HF2eYy2BGFUe89eKzy4kXgwYbXrUlz4OjjG23UaWMOHKMRE4n+FVBcmChsnyTA3HGz9eN9IPGiFkXADmIPPQfLuu0iEjr674Dq1Z5b/WEt8fQuw43J1sge3AgR6u+zhsuX/EvSJrad5DuIlqxPfcYu8Nxk1KIjS0d/5SbL3vMhkfo5FrSCHht3P0BBEIFMnCLiWsyDe5dZ7+kaDkbEDi81z63NNYhyrknPYOHxkWBEZdlWph4ktD+/rJhObw+NzhoJ7LbgDvIKAYqsn9nNgJXZtyATwmx01dStUBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbuCDpq2unlXBKLhBLNPBb8KMEi2PfbPxj6w/wTRvQI=; b=MUtXGU/ECSubAZCg6FalB0wTa9wv+k3G6m2xKyhfE7eji+qpC3jg46766bZi5tdf5PmJ+1leR0s2oTP0ZkB4CeOIcL8Fz73SIvguIQaorJBeknaK99lhCxcUUZHmLmxF8pIWMJYcZbm5iPkQHniObmcG7HN/BC6imQIS2WHIWWSbOKQOf1RJwoFdzjml/J2fmQGBcV7Uprj5K/vf3LySgXoVgw66CQl5ZSJv25XzA1I8H9+xHUd7D98Qjhox9mpc8pUDNr7UOx2XTWEoFCCOxJDKnR0Au0c9Q1Dz0oUUTzGnwafsOJoDr5F8KrdT5VF+sCOJaAo1MQ+qaD1fNEzi1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbuCDpq2unlXBKLhBLNPBb8KMEi2PfbPxj6w/wTRvQI=; b=EIRM/+IVxLKYwCZ6Hhb6dqQWz7m6i6HCrXzcNm4fGakBTIZ3TqbqixZcsSjnAMUp5u0PpjXGiEmNJEsWBlOJ1Y8GMlOP2WF8PHSDtRYqRkWc2hDD2S73Po9bLURQwA0gpxA5dB3YQtSsoGEst+KTe+Yp/2N2L7WC1GUJQJQEiKMwzBtYkhB72BY1mxRnR/XGM54xujdKupEY4obPwb/SZy9tUz/M8twtyiZb+lNXc/+wn91gSX2Iic87VBU4MNyjGlzTpJGMd0/8yb2QFAzBhSFqRxlaSvlKo4Mf3siBvy0Q0OuKcOuZ9F7pCSUEUBjl3KsBNPrYBnS04NqHglGPUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <376a6586-388b-271c-7667-e63bb1565eef@suse.com> Date: Thu, 3 Aug 2023 10:53:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] xen/x86: Constify the vCPU parameter for expand_xsave_states() Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230802154705.84530-1-julien@xen.org> From: Jan Beulich In-Reply-To: <20230802154705.84530-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0195.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7347:EE_ X-MS-Office365-Filtering-Correlation-Id: 55829d34-760a-4ef9-b290-08db93ff2a02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: txwgLymvlzNKy2iuspoekp4Wnz9LBK8EkMFq8mxC5x+pihmQvViMW9lttM7gpIDDes1W0cwF0vzZm/avVU+hsnH+7Rbh3IqpnGnmxhfFmf+JUt9OWtDg5LySSDmJM8BIuuuJQDewn4CmIPxAe1OhRggCqTKl3eCe4AQzWf9loETvdx5PAqdQZAwrDE5zVglAUZnNKtDyknHdD+r75Nwc2qUwyqHwXb/WQsLrrIy49QTQ8g5+ZTtNGkT5KBNYhpWe/FCzfxG0lisU7WckqQgVKLUyMG+F4oMAy73Tw7IimFMxkpuHm3n+QD2NnAIuLGacJbYLMs3MyGmQi3wRQYYtFRea2YiTvl8vXinSCYqXBm7gupHnSb5L+g9jTlWHAWZW2jlPID+dSAgP//ke3ywRAgZMCUB3agZBAxi3koklnZfs170yPtH6SzZsmlJGJdx4iG2vwU1l83W1TntOW8j8PXZNK8XPAAj4b+OKDYMUscHbXL4XjDR6lZdJftqKt3OFf+NuqqQs//Qz9Mhc+hpinEQHBGcCNWYFv7ar5f0XCjlbhSH5cWYBPgQjhJ21HJKNem9RerhVx3wc38c8+Mo2EhySNHTiHn/nuP4qTT6bTBCyRAFLNlDFzryS7VOpOZ/U5ZoYYspgR7nGOlGARiFq2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(36756003)(31696002)(86362001)(558084003)(31686004)(54906003)(478600001)(38100700002)(2616005)(6506007)(186003)(26005)(53546011)(8676002)(8936002)(41300700001)(6512007)(6486002)(6916009)(316002)(66476007)(66556008)(5660300002)(4326008)(66946007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkNGaXgwdng4Mk04OWtaclBkUk9QVmRsR1FKdCtRZG8xUHEyYkpmMXZHSjhJ?= =?utf-8?B?NVpqU3JkRnYwa2d2WHp2NGxHeFJnWVVST2tQSFc1bmMzTktXdXh2aVNNTGV1?= =?utf-8?B?UzFrZmZCL2wzaEUzUm01L0VNSUdPRHBjbmZVRk44b0s1T2ErZ1hzNldocXQ5?= =?utf-8?B?Nzl5WFBxNlRIWmJVOURnSC9aWDJNaFNhTGVIWVN6RmNzNVArbWlMTmpCK3JW?= =?utf-8?B?NTRLczBFUFNGOEwxYnJiVi9CVzdURXBkU0RBaUdpZEluUE1OT2ZKd0RXbEVu?= =?utf-8?B?VDEwVm9EZzJKZkZ5RUxxVjlxTmVOaWVyR3JvUFR5K1ZnMnl4ZTZ4RTcyQ1Fs?= =?utf-8?B?OS9XY1hJeityUEpzUTl2a3VZaklGNitPMktWOGlnUHh4STU5OUFEUjloZEpS?= =?utf-8?B?ZnRvSWhETThRcmVWNXBJZkI5T3lsYzd0amdERHdZOUpKMksxVTRaYnRRbFlP?= =?utf-8?B?SlNJSkptWEVqQnVyNzFOMS91UTVYSnNBTG1PTkdzcjlzZUMrTUR1Z01tVjl4?= =?utf-8?B?WCtXWFpDZElQalRscUVLMWhGejR1T0I0ZTZZUG5BMEZvK1ZkMlpiZzZGY1hT?= =?utf-8?B?eVg5ZWhyYUlRbHJJd09UeUVpdUFNcG1IOEZyNVlxK3hJSENRN3prRUU0UmNU?= =?utf-8?B?YTQvbS9pK0tPZ01CKzRqc2tTM0F1TlI2Uk92N2JqMjRTOVYrZENHRjRsTUxk?= =?utf-8?B?WWwwZHcrRlBhNy9QVmcwR0x2NzYyYkNQWThEYnQycENkaDR4Q0NFMzZoMVND?= =?utf-8?B?S3Y4Njkzb1JReElmWmVnY3FSSjMvZkppUWd5c3FLR21TOTdidU4zWGpFUW5r?= =?utf-8?B?LzF2ZFpRMDBVZlFRRzdGZlNaT2lGdHVRbi9vV3Ivc05TZUVPNjJPWXFFMktv?= =?utf-8?B?d0Jnb1hoUkp2OFRNQmgvQW9hZWtmbkhHVXpqRERCV3BPRlJreUJZTnNtOVEv?= =?utf-8?B?S2FMNURoQ1JoY0h5UFNiY2xxdW9vVm9QNFhKMnhPR1psSWUzZFM4K0hGb0hJ?= =?utf-8?B?Y2NXdURSclNCU0RrUlF5ZGhsdjRvWldoYzZCbG1zSEUvVUNMeEJJT2dOOHdC?= =?utf-8?B?UkI1RXJNZTJmOUlmUnZSOHBDcjJ6cUlXK1JvdlRqY1FrOUVucEY5TzI3d3ZJ?= =?utf-8?B?cTNDRWV1bXNjMWprVWh3NXU1M3VCSnhGZ2dGY2NXOStRRmVCL0F4MFRNRjBo?= =?utf-8?B?UVhWMzlYRjg1TnNpUUYvWFJqRVFHaXBmVU5qa3FiS3pybDBPV2FkVHBLQktv?= =?utf-8?B?ZG9VRDJTVVlhcm9vbkZzMzlXMEs5a1JLZTQxOHRpTitzbFFvUUhaVEc4cjdi?= =?utf-8?B?YW1COUlvblNtTEY0c0hsY0VNVzB4UnQ2YUlweDlkWThGZ0VzMFB2WGUxWW1a?= =?utf-8?B?THVIZlArVnMyOEdNQ0xkOHhpTW4wRDVVUkVlRm5xUGlnTU1SZWpMaUN4amt6?= =?utf-8?B?MGdXa1VUZzhCVEVlMCt2eVh4VTVEdjdIMlpQT2ZUVUZZV2o0ZXRySG9VckpI?= =?utf-8?B?MUJockl1T0ZqNG1xaURvd0hYZDljR094TEVpOVN1SS8vazVtSGp3eXkvTWZL?= =?utf-8?B?R21HWHVjelFuSkN6WFVrTU94TEt4aHQyNllmWWVDV3JvVHY0UjhmSFZITGlT?= =?utf-8?B?Y3VUTzJ3MUtzTmJuS2dmOFJWSjk3c0VrOG5oZW01eUNsK2VMbnlOTGZQRVUv?= =?utf-8?B?T1Vta21UZmJsbUJKWDRJSXdUN3FtMHFud2pMSmljaUVOR0RrcEl2NFZPWDhZ?= =?utf-8?B?a3ZMWjRRY2ZVRjVaT2M5TVhycWF0SVNJZzlzQy9uUHBVU2ZyQzcrYzlxSmtX?= =?utf-8?B?Sy9nZmFvd2Izb1pOT2tMMExzKytybzFtOHV1QS85QTh6VU5keFlDeE5OY3Zq?= =?utf-8?B?M1E5SGNpUUZJZDhjbnp1RHF2dTZkY0E2SkRidjdWQUlGVlJ6SWg4enJRM2ky?= =?utf-8?B?a0p2YkI2ZXQybjl6VHVBWGI1YnJYTDBxSjAzZTZsTm9JN2pOYXlhUlBxOXJl?= =?utf-8?B?T2crUmlkemRKSGQ3U0pnNElDaGJhbEJkTDNsSHUvRm5LQmlwK3RLWXBad2xL?= =?utf-8?B?MVBYWGdlUHBqdGxjWmlpYktHM0JOaGZ0SnNtcHFweUJ4RGpHaTZNZ1VtOVR0?= =?utf-8?Q?sfNuswqimyex3P8HwnIXGPcMh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55829d34-760a-4ef9-b290-08db93ff2a02 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:53:53.6292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r4I7W9d09ufDm0/8dXhCErNreOOncO+lqdELduDL9o3vM3GyTz1joczz2ZiDMpaCuofZp8zRrdeFQgLhhKrZFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7347 On 02.08.2023 17:47, Julien Grall wrote: > From: Julien Grall > > expand_xsave_states() is not meant to modify the vCPU. So the parameter > can be const. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Aug 03 08:57:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 08:57:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576108.901873 (Exim 4.92) (envelope-from ) id 1qRU9G-0003c3-6a; Thu, 03 Aug 2023 08:57:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576108.901873; Thu, 03 Aug 2023 08:57:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRU9G-0003bw-3x; Thu, 03 Aug 2023 08:57:34 +0000 Received: by outflank-mailman (input) for mailman id 576108; Thu, 03 Aug 2023 08:57:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRU9F-0003bq-5D for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 08:57:33 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20629.outbound.protection.outlook.com [2a01:111:f400:7e1a::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c74ff36f-31db-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 10:57:31 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8825.eurprd04.prod.outlook.com (2603:10a6:20b:408::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 08:57:28 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:57:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c74ff36f-31db-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8NE/dYkCE8kI5SFu7Q4AUn3lLRr7RfxezZk1qxugD3J4ZbEgi+/r/2r3KzKDKFu2OcD2zJXU1raESp6li8yzzsDw6Kkum/rU2dWVZnx7PT+3l9LPMCmxkmnrY5crHZqfcc3MmDjWHsNlAq4F3cCeVzj3AeyRIGZRTSVxxNMTUCltMCt0wL3uRH80TfRR0w6JX3+rkN+1BMFRoNEuWrVEnDeUNCl57CEcrXEKTy3Nw0XJn6trAdsnqroUkkzRdVLJdLOJIx639c/RLBDEciex/YBkAotQJibntEoa3pCUGNIKCrKdNn8AL2rQ3ng/l74kD4QaM5Mo/jfUh9xvfFUng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RT9ryw0LZDBkectChClncy0rb3IV7pG2xjcg6yTcE10=; b=cTyTI6ZGBtg/KVQGR3LTFTkeuKTCuRSH6ArohsfTgqxLrsn1r1Y/6UKtIENH67NzuzvuG+/kf+3CzNOgxx/prXCrvzOteqCxV2QUW5yAO5Tjqsrr9KnjuJ1414Nz64hodgaRI53JurUTFAdaVOWBul/o9LWNudxDMm9cWw3pS6jcPO1VYMhejZ+TWswT1cgSXYWweXrip/KNCJoMgPGw8xQj7jemAGlskctXLn4lfzOyy6xvl2LUWRzUZxMDC2BsoGr+bryaO/u1p0OnKF74NEfP8JZuArjpCh6xttfP+uTSL1kbHYyHvJmZwhzYCSZiDx1VDBQOx9dW/zO1bAipKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RT9ryw0LZDBkectChClncy0rb3IV7pG2xjcg6yTcE10=; b=RvelaCQEPmHbGl/xh8kJ/GpGNTFrHMKMbMFj41nKEQYHFGx90ilYSJQYs+AuE6aS1VKcMYLhBDcjTkAL4cxnjwtwQX0u4Z9gAeYxX8fRz0hpwldIworkuKxrrXhzbvo4jWtZj2k8UZIV6JcrgjArfwypi1PhKNk3UXcpVDBMGMkShfTO0o3ZLfvpOxgYqZ6ZMg3L778i1ddy3bNO99Yx9jOpGfN8pqJj/DVJWw+zE+jrAP634wE9+Tauvi9rVGoe0RI+KLgzjV3Ph/FWlJYOgiOoHl0sI9yntRZQc7KV+YFujko9AmAZ5tVdFgFQ5HjrJABGu3h54WGwx+Myua8ePA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3af75576-4a34-ab0e-3c1a-20a143e993e8@suse.com> Date: Thu, 3 Aug 2023 10:57:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 01/11] x86/efi: move variable declaration to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Stefano Stabellini , Nicola Vetrini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8825:EE_ X-MS-Office365-Filtering-Correlation-Id: bc00d21b-de8a-4913-c863-08db93ffa9e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lMJx3AhdgOfIEaVqpWEEb0zR3wDLENyV4DIsUhDTXrom7zqe/JpN+u6jqhYjYVzCMi8qOqIBFtZYKBwIGJX5Yd1pEr6cByCLdXVlEGQenZtYsMv8nQ3lZQ2bPOTtcP9KWSRto1YfLi5/LZkBjdJ+pdZPjhRzJZqPrqaN30S1H5/imyRjfVyYetXwNTbX+FHqg8UptpuMOrKadhBOMKicht4wAiXYIiN8g+W6Xf9SBxjcefIRu0yN5awYv9LRzNohST34GSN0zHjNyKDBNyruZkOqERYf5Ryo4ahtbxngJdZ+HbqBQOdhmdtBdHeQsVj57mdp16qEXjCHt8cHfvMGXwtsTA9GHhjKMHWcQSHafCB6lPUw9BQToQR8Y7WZL37au8/HnVFcH4CkMaZp+PY+cBsCPEqpHylqmmbrNRlJiqVMrOW4UfqMdotwvFRLRhBhBHvnH6kit626tIx2WW2bSrhfPWo7uZj+5RmhNzAR9z18WmBW0huqla/YRyLE6vF/vRX6u19HtvXlVKkNG3xP/6OaCy+qZMv8phfv9F2zdsOCtlOpQv/RaIYN8X/7H24A1HzkrfGoK6Lo01zI6rd+kmbSu0k+4pogUhVhDbX9h1GvIxiRu8I/IkHYIaBjbIB1LD+8XykTN+ZwC8GN4gjCjA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(36756003)(31696002)(86362001)(31686004)(54906003)(478600001)(110136005)(38100700002)(2616005)(6506007)(186003)(26005)(83380400001)(53546011)(8676002)(8936002)(41300700001)(6512007)(6486002)(316002)(66476007)(66556008)(5660300002)(4326008)(7416002)(66946007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVFaOUhXT2R2WVdPSU9zNG1raHF4OXFEcDJ0b3l0U3ExUStHWnRoMTQweHJZ?= =?utf-8?B?aDdxNDFDRVVLdEtyUGJUSTV4ZFVzUzBUQUlZYTJHOGFKWnB3S1NraU0zSWQ2?= =?utf-8?B?Y1l1RlJlMVBKSHRBYjRBeml3WWJDVmx5SjNTMjFRaHE5VzBMcFNIYXJ0dnJp?= =?utf-8?B?aEtjMFFoRHc4bWlmSlVyN1l0RDJoWkpaRWl0dURTUVRmbWtsRnBDQ3FBb1p4?= =?utf-8?B?Q2pEV3pMS2l5MzBhOENZNDR6Y0xGR2V1Q3lXN1lyV2Rxeks0OU41bCtrazFJ?= =?utf-8?B?ZHF1V1ZmcTVrM2F5VFk4TXViSlByR3YxaDhQWEkxSWNFclF0N3lBV3hNMmhY?= =?utf-8?B?aHBtQ0xMS2V2M1M3QVB6SG1IM2hicDlnM2RVeDlmRHRHNVEzMFAxaGNCdDdz?= =?utf-8?B?UDhNc3J6dDYwTUtSUkZtSThuVURIRGRIRDFNVTBGcG1VOUJMMllBcEcvK3cv?= =?utf-8?B?c2tYTm5PU3c5cCtwTEJidTk4S1dlNStrb1kwVldHZG9oSnYxN1RSbTFUREhx?= =?utf-8?B?L0xUL2NrRDBxTmg3MDFnWXVTdER0MlFKRkN2bmxHejJETFN3MmRTd3dQMlRR?= =?utf-8?B?RU1adXBWaU16UUNOMmxrOTJINmdpVytNdjBPYWVlUkcySXZ4d0RlL2ZXWHI3?= =?utf-8?B?Nm9TODdLN1l0T21PTUV5Z29Pdll4S1RIb3YybmM3OGpDV0gzN0pDNjNGeXNz?= =?utf-8?B?dk1LQ0xuWUluWEk4SElhRzhsSlByRXZ4UjBJTlFUalIzYm5QczQ1a2FZaStC?= =?utf-8?B?VlpzZWZKS1UrK3oray9UV1BNWVpra0pzU0VvN081azR5eGVCSE8zNXpsYVc4?= =?utf-8?B?ektiWVAxb2FuQm53NS8wdHJCdHp2QTFSWDBnVVJRRUM4cW5TZUNsTWFLMjNZ?= =?utf-8?B?VFEwc1ZScmFCc0xIK0dsekNZUTU0Ty9kRFBwbVU2a3NWN0IwaVdsUVF1eDBh?= =?utf-8?B?Sno4RTEwZHYyVks2R1gzUmtBZmJjaUMvNFNkR212Y2dOYWRNMlZrSjJIS2sr?= =?utf-8?B?TFBnRzZoaldjdVNtcG50aE1ieStmcXF4M2hDeWtSZEZXRDNyUmFxdlM3V0c5?= =?utf-8?B?T3BXTFRKQ3hlMi8vL2l4V1AyYklDY0hEcmRsQWRqdUNobXNLc0xNWW9DR2lL?= =?utf-8?B?bDRobkkrOWZxd0JaNVNVMjFVeHAwTiszOG5vZ3g3RzE3ZnEvUXM2dXg3Nndu?= =?utf-8?B?OVNMQ3kvUDFEU2tWcjVIQjhYVUtDeENIK0dLQnlidE15OGh5L3p3UE5YK0Nj?= =?utf-8?B?QzhNOEVSbUUyTGIwbnhkMlVoQ2lwbVZ3TDZXanBvWDVTZ0g0Zlh6MGZtTUZK?= =?utf-8?B?Z0YvSmhWS3RkK3ora3BmUm9TZnN2NDl4R0tyMTFFeDZnRm84RXZiM3hqMEZq?= =?utf-8?B?RzZjbTZwbDBrOXhTWXZjTklpcmxuWWZDMTczenRtYmptamhsMFJlSmtvTkQ4?= =?utf-8?B?dTJqSUlSdlVYRGpaS25nYldrYWgxbHFxLzBuMUxqaFFlUnF1cEI2ejJROE5l?= =?utf-8?B?R2REcGxNSG1ScERCSVBLUktrZ2JXN3NhdXVZeTAvUlBNOWFRRnJMdmFJRk43?= =?utf-8?B?YXNPRXhZU2Myd1drNk9XUDZwdW91ejBaUkFhZ21SZnJHVjVjbDI2cUVXUmlq?= =?utf-8?B?VkNRZTRjaDdqdjhiZ0NVd3kwUG10aVlKS1BVMkNGTkxYelFZTlhFN1dYb01T?= =?utf-8?B?Y2gzYVJOeTBiK2IvNGVlRkI2a2lMOFBDaEpzQXFsVW15bWFybXB6YitnYmRJ?= =?utf-8?B?WUlzekJqL21oOVpLRVFBelo0N201SlR0RFk4RkdJdlFBYkRjUXpHNVQ5QnpB?= =?utf-8?B?RzFJRmpXWVRJN0JWMUxyK1RoMU9JclE2aUZCL3RiNnZKSVpqdDZ3eEFyc2Fz?= =?utf-8?B?Qy9hUTVWRG45c3lPR1J2VmU4QjE0VksxVWoyVXZockxJNytzM01kaVVFUE1X?= =?utf-8?B?WDFJOEs5T0JzakxmNjdoN2NGWGhVemE2YzBKOWFPMFg4UEdSbjBKY1VyUzhu?= =?utf-8?B?eE4rUDlDQW4vaVBZL3hLSWhpUVNUcVBhUjgxaEM2SnVyM0RhcmFxcitSU1Rq?= =?utf-8?B?N0F5U0gwR0JkNHVqM3ZGdkVkSTZBSkVGaU4zK0doVk9NQmhIRGU5SWE0d1pv?= =?utf-8?Q?KHMrnoDZNmkaOZVUpE+LTAg/I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc00d21b-de8a-4913-c863-08db93ffa9e2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:57:28.2391 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n4G5k8rFqLH/osLL8c6JiULqdNEaUIxGzLV97Jbh+ram1yYWWdLdVWY9a7DDAvybS0HwNJxwAdcplTjTlrTvEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8825 On 03.08.2023 04:08, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> The variable declaration is moved where it's actually used, rather >> than being declared in the switch before any clause, thus being >> classified as unreachable code. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/arch/x86/efi/efi-boot.h | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h >> index 92f4cfe8bd..b00441b1a2 100644 >> --- a/xen/arch/x86/efi/efi-boot.h >> +++ b/xen/arch/x86/efi/efi-boot.h >> @@ -390,8 +390,6 @@ static void __init efi_arch_edd(void) >> { >> switch ( DevicePathType(devp.DevPath) ) >> { >> - const u8 *p; >> - >> case ACPI_DEVICE_PATH: >> if ( state != root || boot_edd_info_nr > EDD_INFO_MAX ) >> break; >> @@ -463,7 +461,8 @@ static void __init efi_arch_edd(void) >> params->device_path_info_length = >> sizeof(struct edd_device_params) - >> offsetof(struct edd_device_params, key); >> - for ( p = (const u8 *)¶ms->key; p < ¶ms->checksum; ++p ) >> + for ( const u8 *p = (const u8 *)¶ms->key; >> + p < ¶ms->checksum; ++p ) > > In Xen we don't mix declaration and code. So the following is not > something we use: > > for (int i = 0; i < 10; i++) You're aware that we gained a couple of such uses already? I also think that when we discussed this we said this style could be at least okay-ish (until formalized in ./CODING_STYLE). What I'm unhappy with here is the retaining of u8, when it could easily become uint8_t at this occasion. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:01:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:01:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576111.901884 (Exim 4.92) (envelope-from ) id 1qRUDA-00054v-PA; Thu, 03 Aug 2023 09:01:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576111.901884; Thu, 03 Aug 2023 09:01:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUDA-00054o-MR; Thu, 03 Aug 2023 09:01:36 +0000 Received: by outflank-mailman (input) for mailman id 576111; Thu, 03 Aug 2023 09:01:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUD9-00054h-Px for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:01:35 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061b.outbound.protection.outlook.com [2a01:111:f400:fe12::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58a9f840-31dc-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 11:01:34 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7347.eurprd04.prod.outlook.com (2603:10a6:20b:1d0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 09:01:31 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:01:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58a9f840-31dc-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jd0na9u7ndVbVsUbaSUfbXNpGgOgtpm/X8Y8z6yCE1Y7xfMM5/rWua575TNrGU7cIypZwAJHfMja9oNFrLwQw61h4kcstX+2LEIyoVmpLpqZjLK1DSSDlAPs9VywNIVni6BxMZIwRd6mkBKMPnvUm5SHogxXTJzLAZbtS26l6Q/SL3WOuHaPBHRZf4t+70ufVu7UnWE8D81EEFmYPGtqIdQ5wcCH13FiNGK06Ma7ZHKlhce6lYQTF7sVN9aWkGsYfM14nDv23s5AoVr7fdnTliGT3PXq9/R1E3DW4eYrrm6Df8CB3frtJVeJj5RWVQz+X8JDBbB8mLCxE6QU9BwPCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xFyfZvvP2uaovuJM+c1ngdvlhJmsALwSlhhtKueHeYA=; b=S6OftbX2/6CSdDn4UVTWGQekGhbBIEK85oVj77gugB4HLT9HPZYOhfqIeIDuY8cnZ6ARkBi9+Cf0a70pu03hxuZvnOMd1N5NZkiCmDri8NmBEb2lDomX1L4FIFT+oNIpvUfPme9vGABgvG2WYkneo9meBYiLBryDsd/CVGTaaxNYxP54Tz/vFKqNifsxFvVLNEKSjdswEVloz88ojSgdU8LWhRvbehmQNtPWYDK8XwQecQMzjE5nFsvLNUGPB3H+tfG9nWsFgluudjvaxL6t/WV1fHwnXWFknEfx7Re5JgIV5XKAtLdz9iPnkr6KCAY1NAdCX4fovkMd6Y8T9ncgZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xFyfZvvP2uaovuJM+c1ngdvlhJmsALwSlhhtKueHeYA=; b=Kc2wFxJLK2RgsSwKe9E7C/fysE3qd5dGFAbCYTxUzc/8jVOYejoqsQ2RhRvXk3813Y3DvRc6PMLnaSebdq9CDWILJX5c4TRGykk9l750oJzNKhqOOJnkO3GkSRRH/WT9zedYEpJy6+zRAza6sb2L4KjhOoVZGkkJUL3ddrSAASvcENrnTHqgYGYYTouN90NLo3Pfr025Ix+pfqttaPK6eTvnGT8MJ81RRyu4XhTlD50m+VnM7UslKj02b5L7oxKkIh21xajyt3dhMDyQKtgnvZllHjATztlff/Y7yGPnzniU5uivmmo9SRyD8OXNlk97/9anZtCu2tzm0ws2r0Zy5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 11:01:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Stefano Stabellini , Nicola Vetrini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7347:EE_ X-MS-Office365-Filtering-Correlation-Id: 902989ab-7308-4b32-37d4-08db94003aff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dE4N9Eo72lYYeMktimdbhvH4t0hRc4ODoRLGwaJaVErkvFpitC5sqEXBJKZvXDoPhQ26saciuOHYATZ4W2gMiF+5LHf6nlfcUmSWwavtJfQ/FP9FTpqV5vErwIj95a3f/yEMIa7yz72GP596hoUqdhSFgRXNHX6R+B/UmleOvbTe3SU/W5WvlVjCpzKINGxat5+qwbxU1AxqvWxGOWA2cKq8moCs4oAwVTiDQ/Tpp0z4S/Rl+iW7rcMiebrnGEvM7b248OUe4NUBm51YifuLdsg3q7+WgQkSQO9mLYrRyrGHGYr00OlEra9BnC1fOzOqBHPuUn0gJoyQGVbsEjSeN5pcveok5FTM8M5nvPu+kFkFwTrWU+w27HqiV6yE9b3tIg5+SAsSDfkuAAlDO29F+T+VAOw3tNIhjmTSB0DVmZlP2D5V5z2mGEMF+bRkBYv+h+lDfjKDHJ82evNVrTSvylfP5jtEiwAoIoJT4v3/GNUbQQj2tAWE5CtHV5Ioh9doStuVvjLNjo0UrsuEMjXBKAuJNm0ZrMLiZefsDbHzqL0OKgNZsO++z9mto7cXEFxHPsmMY7BrmA/Sv/DDcMsC0pmsj3m0uUARq46cQb0KIKNu7JhYA04Yhlq3cViqpmYSPsl/7jLOqLcAOVBIxKPcaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(36756003)(31696002)(86362001)(31686004)(54906003)(478600001)(110136005)(38100700002)(2616005)(6506007)(186003)(26005)(83380400001)(53546011)(8676002)(8936002)(41300700001)(6512007)(6486002)(316002)(4744005)(66476007)(66556008)(5660300002)(4326008)(7416002)(66946007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkQ5WWZqU3RlTWdrSmVBTlZMUVZWbzYrSlc0bjVML0g1YTZnZTQ4Q2NjTk9B?= =?utf-8?B?VmN4OEY1R2p6NWZ1RU9LV1JmVzRJMzlidzdFT1hRQ0xUMHNpdXo3Mzdod2Ez?= =?utf-8?B?UkxMbzdLUXZaVWRqYXB6bVJSbUJtNTRYbEVFRWlVMUkvd1Q1MUVLbWhtWUpY?= =?utf-8?B?UEJwYU5lVkwzc2IxTnJYZGt2M3phMTh4czlPbk5UVm5CNFJYSWZTUmFqWEd4?= =?utf-8?B?bSs5cnM4RjV5M1QvUkZ5czVXLzRERVQ3Z1REMWhYZW00MUgxSmkzMCtkOTJZ?= =?utf-8?B?eWFieWhKbXk1b1BuNmk3WmpmSUQrU0d3bmtPd0duR3dxSGhCRis3ODRiVUdR?= =?utf-8?B?RlU4d2VtQkF6bFlrRTRyZ0diSFFvQThwU2lGKzgvQUgwYVNzK3dnL2tSMFRt?= =?utf-8?B?d00zQnlHRUFhaVE4am85eVB2V3JWOUo5NEhvZEg2a2RlSXVRVWorR002NkFC?= =?utf-8?B?SzVnMTRlejBYZkw2Y0QwZnpmYXl3Ry8rNmFCMzV6ZU1lT3RsdnpXdnI2b0Nt?= =?utf-8?B?ZnRiRTlmSG9GNVladVBDeGhwb0F0T0NTTzFLeDFibWFzOWpJUCtjamxkbnEv?= =?utf-8?B?TGh3Q1puYkpNR3c3QnFWczhRMU5YTkZkUVlCeXVmdENQdjVrRThRSmdNS25P?= =?utf-8?B?OTEwRldWVGk0bDlWQkltZzNaeGFhNjJHOXRYNXVxWnlVYTd3SWZpY1pjU1l6?= =?utf-8?B?c1lSQmRZMDcxSC9JTDNoZ09UMjkvSi9IcEpnbmZiR3BkbHVwSzlrUGQxdzdx?= =?utf-8?B?ZUM2Mkljd3I2dUVOSlI1MUppb1orTDZvYmg3bk1MWndTVkdJWlorbUxOYVFO?= =?utf-8?B?THBOUE5XUzg3YXIvdjVYa2R0dXJySmVQM3BMaWhHcFdLT242TWgwK2Vzanor?= =?utf-8?B?NWtwdVRvK21vMG5jdlJMWS8zdlkwKzd3VTJwRmlQTGtZcFpGaGliSUFPQVVS?= =?utf-8?B?VkJZMVdNbmtPRTF4a3JwUFN3WHp6U3hHYlRXZnlPT21FM2p6OXR2Sit3UXQ5?= =?utf-8?B?OVQ0TGlqa1ZKZmlYV3BCdWk4QlFtZ1ltWGpHN2ZXa2JRc3NVNVRIeHhoUG1t?= =?utf-8?B?UGlYS1BlTU4rMVdrNzc4cWFMbWhNUzhWT09WMTdZbTZEaW5GTGNBblU4VFVX?= =?utf-8?B?VktxSjN1Q2Zsd3N2aitBSjNBL0VKN0k4ZSt0dDFNbmxoUHhQanA0YU9GUGt2?= =?utf-8?B?MDNyV0dQQkFkWlJOeCtYNXVDWklOTm5FK0NnSHIva1lnTmJieUQyblZsclpF?= =?utf-8?B?NFRFcDdndnBjZnZ3YlZNbW50a3RKcGtlSitvOWZUWFMxYjJXYzFDd1lvUzJ1?= =?utf-8?B?aW1HWC9XVEdOTVk1OXlCdVIzTEZ1M2lEUTRoZTNmcGxaR2pJZXM0NEZIcXkw?= =?utf-8?B?aTV1eEVLTFNEbEs1ZGFqU3M2bSttQUpVeHU2dlQvQzI1TUZJSXpBQU9XY09B?= =?utf-8?B?Q1NaVjBMTHV6ZW5WR3VCeW1zNEJ1YkZwdU9QOGprWnNxWW80UGxYeG9KS3p3?= =?utf-8?B?K0JEYzhjaE8xaHpYenFDMi95NDR3ajlNRFJqdEtIQ2o1OHpscmpiTmFmYWo2?= =?utf-8?B?WTlVaVluYXd6MmJ3QXBacGxmTklEendBNlA4eHVMUmJvUGZmREY1MEF5NHBz?= =?utf-8?B?dXhEVWZXTHBCQXNvTEdxYVJzTXNDalZ2cHpOdUN5VUhHU3BJN3RRQXJLdmN1?= =?utf-8?B?N0hBUmtwYmpjd0llTGl5OXl2aDVXbGc2STRGekFsMWhUZURZZW90N3BsMnFV?= =?utf-8?B?UkhYNVVsSGdlZVZxMUlXc0VoeDF1b0ZWOC9YUVNWZEdFN051dG5yR3E2NnZj?= =?utf-8?B?YXk0T3R6SnNzaWc2WGVZVER2ZFBjd2NMQTYvcWpUSDRMcXcyak9GQndibFFz?= =?utf-8?B?TVU5bmRKUkVMazlyMmxjQVlPZWplS0hMbVlUNnlnamtGOExYeFZ5Wm9nOHd3?= =?utf-8?B?ajdUVzhET01JcGVKb1NQNTVuWDArb3NTTjN2MytuTldscG5XdmN4cXd4YlFq?= =?utf-8?B?dDdPUml0UGU1cGNHS3kraWZkOCsrRnFVZUdRdVNXNG96aWEvR0c4cTJ5bVhO?= =?utf-8?B?ZURReEhEZkFHMEMvZWpSZTc2dm56RlB5QkVrSTNYdVlxdHFSd1g2T2VNUnp5?= =?utf-8?Q?35xmP26WI1A1GE/t1pIArHgHF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 902989ab-7308-4b32-37d4-08db94003aff X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:01:31.5223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AKuBiqqH8ery9cBQkgCjfPMXRTfadUj/vQYSRUMtmbMv9x/myN40HrYuHeKSm/ccIby4alaAs7U/ekq9oIipdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7347 On 03.08.2023 04:13, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) >> >> switch ( action->ack_type ) >> { >> - cpumask_t *cpu_eoi_map; > > It is only used by case ACKTYPE_EOI so it can be moved there (with a new > block): > > > case ACKTYPE_EOI: > { > cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); > cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); > spin_unlock_irq(&desc->lock); > on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); > return; > } > } This pattern (two closing braces at the same level) is why switch scope variable declarations were introduced (at least as far as introductions by me go). If switch scope variables aren't okay (which I continue to consider questionable), then this stylistic aspect needs sorting first (if everyone else thinks the above style is okay - with the missing blank line inserted -, then so be it). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:05:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:05:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576115.901893 (Exim 4.92) (envelope-from ) id 1qRUHE-0005gu-8X; Thu, 03 Aug 2023 09:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576115.901893; Thu, 03 Aug 2023 09:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUHE-0005gn-5s; Thu, 03 Aug 2023 09:05:48 +0000 Received: by outflank-mailman (input) for mailman id 576115; Thu, 03 Aug 2023 09:05:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUHD-0005gg-C2 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:05:47 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20612.outbound.protection.outlook.com [2a01:111:f400:7d00::612]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id edf4b94f-31dc-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 11:05:45 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7625.eurprd04.prod.outlook.com (2603:10a6:10:202::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:05:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:05:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edf4b94f-31dc-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QyrX5O5fkmHRBI54yX/NnCP/daYMi+9aKIdG8MH5WGkLSvJcYbaxOQubjJg5CY7EiHHsdq3BVj+0kM/V6Z17ulBboLxfitPlp+XgDrEMYb5QFo0B6Pc5xjbSFPwEbzymvjj9UMoiENUHbXsHwMj+HlXjabXDaRcBNI2PMn8Y5HZKjdI2YdL02elvn6KuXaFL5KfSX3eIu3K6/PQFwTJfz5Y9JnQNWAmBMLL8F3zz26LW2mMzjE6xCbSodZRa5qweteHbw7llXavNb0PREoWAYu9Ma642ks4XhJFM2lUNI5Ay8A7n46eqaAI4QI1i4vO4r2tulKIOHZ51sPXVWu7qHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ct6eL2qweUjt6jjItz65Fg+I3CL67e6ZcInGGy57IiA=; b=FHCu2vf4XTRm8PhNG3/yL+s1lp7hQLiWsbvLlsM/X/OW4+6nBuN51/sgxEJU8ra0EWDNk6NXJ3ZHhl0aCeulcWwETjL8dVXom8ighLv1rHdJGJFdBQ5Xo9Dt0ImEt9CPOPMHchbSkz3Kl2s48QhqqPtMPqlB+jam82rgLd3GXc3y60ajjgx/Es6wlLzHCHjMNPclZrGUyeNCZ4prBYrU+PA/4MXfvWF3SIR6ryyI4P6tKCvVU8/SrtmfcWQcUCt8vrgqISMW3prDOG4CZEFOo2zNLBU+wHeg/ndm1LqqWJ5sEhUEWyfKD39mqLHzuASEXpQPsqfGfJnKcKqZ5CXuZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ct6eL2qweUjt6jjItz65Fg+I3CL67e6ZcInGGy57IiA=; b=WP4mvyGPVUAM9TaVhSvyeyp4qpdcgKNeSgcgC7zzvaXAgvb9WAXzC1QmwhlTNlw4y22hbZRtZ9M12gGeEDilucxC/VM6MPBJbxV6JhT1Ork8vYO2uQ+u1rzOL9sOadgf2DtpDEYBD2ymn35eLbkqiEy1z+hlMiKo+PcJxCSRRhyM0g9UtbH4kcicoBIv1rANVIEjnY/zzq0Zx2NN2KCAGF3u8ScUjDwcGWBLPp3ECaNtywzPH49RtLvAe3tF5hXLd7ObRgh47YlUqmrHxTNd51khEBzw6fDUwTVdbglN7B8ZXz7ZAOeUWAPXybFe1xkb6jbkx3b+QLGtO9sk/dw0ug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 11:05:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7625:EE_ X-MS-Office365-Filtering-Correlation-Id: cacafcd9-ac69-469f-aab7-08db9400d0ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ac+7Fvme0NpSlrKSvvexU9uXRRWoIvgBAOp6EU2oyV8tfOPWB2ko0gO+4vN2PmIco3LZxOxhaFHHG72k4hlwmOBnwvR8+DVLII71dkHpSHcltnm8SOF+h/UmUIRcjYBimRB3mindfznPLfdpnwdz4IsDsZ4g1MM8sojWHyQs76XgS8CEiMQ/2VDAhf2vyqeglXHIo9iv97AASOYsNrWCH4J+Jx97q3ZkMl09uiS0MAhnp1eZBsXt7lJDKQ2rTpsQLbmeOURgUKBfC5YfnL+PIByXWb1GT45nnOgwIJW8xQsxE+MkNVkmMac9icjq9KDyTHaRTf6rSTm+cTUcbIUl8z6l20X9/oHj9zvk7Lq//Is6LAxH5jPta5jK1AuFQX+X2KtuUfE4GrM+kVURuRXEafLlTXNSOEW627sC8IbLHPf2J36OJsIFMpelRVQXFau0P6t9kyTPju+kduUExWd0o/4WTsrFyhXAe+Fk4rGpeJ9lZK2Flt9FFdO1mIYZYoP/UxUPWQF8DhU8sjQzqkbYsHfT0NqOh41+CGP2HcpbWy5Ad5BBKo5xWHBXhJsuk7a4dolD3MHsO5Dxaz8plqILdpfGdQ+8ooExEodFjp7HZqAqIdTYOx+0zwS9vvnWjJEt35gEzdXyz7g9qnMOXax8QA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(7416002)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(38100700002)(31696002)(86362001)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTBPMWVKTHQ3RDN3NlZicVducWhvemNNSU9NZFo1YUx6bHBPRUI3T2k3YlM0?= =?utf-8?B?V3kzTllPYjFscmtnTjB5dHY5SHo3VUpraUVkNzg3Z2IyOW5Td3hsZGxKbEI2?= =?utf-8?B?WlVEUjJmb0hhSHZ1VUxmakFpZW5ZdFlzam41SCtDZTd1djU2U21BYm12NUlh?= =?utf-8?B?VVg0WnJZS3R1c0gxaG51ckNKMDNRYmVoV0NpSVpEZ215Uzd0QXAra3NGY0lQ?= =?utf-8?B?ZGZteTZEWllZQkVrZ2xURml0T2paRTJvSkw2RFhTVWxDVitlZmowcGo3OFNM?= =?utf-8?B?SXVtdzZjdEhxSmpVc2xEVGJaVUxQejBNZzJsSVdYMHJlWHZCcC9SZTNlR2xv?= =?utf-8?B?S0J1a3Rzb2dIK1k5Q2gzMktYL25ZR1lwQXRsVDBSdFNFaUhxbndBRndJWjBO?= =?utf-8?B?ZUx5L2RXaVFVWW1RdUxpeXdOR0ljYVQwNy80RXZSRGlRekY0VFFCZGgzaDVm?= =?utf-8?B?aHRVNDRib1Iva3hEa3RKNlVzSGtWb3hHNVI2Yjdweit1aU5QcEk0aUtVTjB5?= =?utf-8?B?UVpLRzE1dHVwcjE3QXRSYmZtZTVpbHFzTGQ0ZzJ1ZHovNWpMV2dVUVpvUlE0?= =?utf-8?B?OGFiTTJHbndYQ1ZPV1VMdytWaXd6Z3QvOTBuZi91Y2JFaTlQTkFVWmFCSkoz?= =?utf-8?B?L1BQQVQ3OFI1YklPL0ZtNUFOcVNNTnZMcUJXbFJNUFJIZktYekpMSXVxZDMx?= =?utf-8?B?SStQM0JidzhnZzFaR0lrUXJmVk56clZLTVU3ZXRpQXQyT0hac21saXZFVEpB?= =?utf-8?B?VFpIMHJBNW9GZUsrZzBzYnhZUTRMT2J3NlFiKyt0cUE4MHJ1QUtFdkh0SG10?= =?utf-8?B?dGY0RE4rV0paemZlWXl4RW13SDhhZTlZQSt5WVRFY2o4SXMxdFJidWFnSUNN?= =?utf-8?B?dnNMOUFnMnk5b2w1TmpibVBoclRsY2h5WjZwTitIMFQ5V2tlWCtGVm41alVJ?= =?utf-8?B?Y09OcDAvbEtHalRkVnpibGYzRnFpUFJoM3l1TFlXVlc4RTc3UFVBY0c1NEtL?= =?utf-8?B?VXEwcXBLYkZpOWJuM0hPQmYwNEcyYllrOGRHQjY2bVFXdG9BMFpUa2crS1hE?= =?utf-8?B?eS9TY1I0bms0SmF0dWRhQ21ORFFzY0Npa3NYTCs5aitEeEpKejRqZnphY2t6?= =?utf-8?B?QjFYRWRhTk5wMjNDS3I4dHdScE5YbnhpU3ViU0M2TEVNM0c2eXcvZDRJVVhp?= =?utf-8?B?Qkh3TzhRN29PWVU2UERzSlhyb0QwcG5wS3lPV2xxNUdlUE9HSGdwWGZNc0Fa?= =?utf-8?B?bXZpMGVJWVlBcjhCYy8rNG9zOFRpL3d6ODJJMlhpYWlrTHl0cjRFTWFVSlJW?= =?utf-8?B?UCtZTXFnODNFaHN4RHRLQkRPUUhhUllEeHFqSkNBTXhOSEVqYS9SalU5MVIw?= =?utf-8?B?bDNxeUZZK2ErMjVrNzZqVGduK09qZ2VOblhKWmZ0RVZBT000a0lJYjFXZDVt?= =?utf-8?B?ZCtUbk14OTR0YzhlRFpEQXB4WGtUOGNpS3Q1TFRMeHlqT1pLTTN0RFhKSXZr?= =?utf-8?B?bWtDU3o1VWhPalcwY2U5Zitrc2lrYzF1V1RHKy9oNU9GTzIrWmVsQjRETE9K?= =?utf-8?B?Sm1iZ1JsMEh2SGVTbG0wU2RWajR2bXRybkNFN2l3UG1UUkg5elk2MXI3UTl6?= =?utf-8?B?K1BzMmhWdHYraXUxVHFWMnBidm94S3MrUnp3Z29hbWNnMDhIMFhwVmtXZktH?= =?utf-8?B?MUxsRGYxUTZERDZpWTlIeElXVWJMOFpPOFhsMXg4OUVYdFBPK3ZOcFVXQkt4?= =?utf-8?B?OXBsSGtrdzRGTXNScStmNHg5SlpOM3poOHQ4eEpkRkVVay9MMzBpc0QxM3BK?= =?utf-8?B?THY0R2tNYW5lWUp1WFlPRDFQcnI2MUtBemdmblBlVlpMR05HSFlyU0VNUnRy?= =?utf-8?B?TWtBQlRWRWtNU0M4MVIrN3FNUlR4U0thUk5HR21jTWd4cU45Y0hYRnNvdkNI?= =?utf-8?B?WDFQU2VheGptSGk1SVlyTG41VHVqclYxZkwvcGtRK1NRSG9kODRodTVQVSt6?= =?utf-8?B?RnZYZmdHRGZkbjBlOFcxK0pGOVQwZ3ArQWFoWWlhNE9aVzQ4MTM2MzBVZjY4?= =?utf-8?B?SWhCN0Z2V1lRaHBGY1cyWmFnOHpHS3Y4SGs0VkZ0VEcvc005NEw0YnZvbUp5?= =?utf-8?Q?Qsc3tGryuSxGx1I4Efxy1QwPy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cacafcd9-ac69-469f-aab7-08db9400d0ca X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:05:42.9030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JgQY/wOHLvHzR/r5IZYmBZI8TxkirjcAKvy2m1RcQ1AEaEVY4tJlFzUwnMZIorXU0Dqlw+nfSc+2jj7LLC2jIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7625 On 02.08.2023 16:38, Nicola Vetrini wrote: > Variable declarations between a switch statement guard and before > any case label are unreachable code, and hence violate Rule 2.1: > "A project shall not contain unreachable code". > > Therefore the declarations are moved in the smallest enclosing > scope, near other variable definitions. This needs further clarification: There's no "code" involved here in the sense that a compiler might eliminate it. Yet that's what the rule's rationale is focusing on. There's no even mention of declarations like the ones you move. In particular (and on top of my comment on patch 1) ... > --- a/xen/arch/x86/cpuid.c > +++ b/xen/arch/x86/cpuid.c > @@ -37,6 +37,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, > { > const struct domain *d = v->domain; > const struct cpu_policy *p = d->arch.cpu_policy; > + const struct cpu_user_regs *regs; > > *res = EMPTY_LEAF; > > @@ -136,8 +137,6 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, > */ > switch ( leaf ) > { > - const struct cpu_user_regs *regs; > - > case 0x1: > /* TODO: Rework topology logic. */ > res->b &= 0x00ffffffu; ... I'm not happy to see scopes of variables widened. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:09:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:09:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576121.901904 (Exim 4.92) (envelope-from ) id 1qRUKt-0006Ms-S3; Thu, 03 Aug 2023 09:09:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576121.901904; Thu, 03 Aug 2023 09:09:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUKt-0006Ml-Oi; Thu, 03 Aug 2023 09:09:35 +0000 Received: by outflank-mailman (input) for mailman id 576121; Thu, 03 Aug 2023 09:09:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUKs-0006MM-8o for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:09:34 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7e1a::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75a322b6-31dd-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 11:09:33 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB6851.eurprd04.prod.outlook.com (2603:10a6:208:182::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:09:31 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:09:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75a322b6-31dd-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQCsFwQA117si/FdDE+LP0fgHvRW6uPAo4uK3s5MzNKYtZl9S6wkg+nsHgjSqTNL1+soxtVuESRGJPKYgUcJqPcAajla2B5IlePXUh7nRsT6IApRJapaFLVi4eJLST8K02CSkZWXVNGpCAl8SXKMJ1h1lBZ1ippHL62M7DdurJMfYbCYmV656XooEFG5MnSVoLuNTHhzWnIXxuSrk5Bxv7DA7ZxRkhcRn5fVtj2M1F4hhxNv8DXRTTmrnrvOmNk7s/hNkvrxBoRW3V+901v8Bv6AGHjnJUd+ZhPYwMWEjfM87PXLGNC0XfbBzxvn0lLTlx42CxQkh6Xj+C+GyhENWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8eveVOsOqlgiWdKX5XlNF3lqVszhPaGXVqKswy2xkU=; b=WZTDJNZ67h5eRe44aRzysFQ9N+b3InYJ0qoLcuZ+uOqgmLRgJEnhN7+6VDNayKhf35G3vUWL5UVNT1VULFMjmSbeCZELZTcB462NcyEk5lw2G2Xq4lCUH3VXr0890vCJ83/kT3TFK88QqM/7TglsS2WuvTC+xAbCBjxDkPBxTnPxQ8ZaOHhizthAig+ZasKnJ9bxXFDPDZZ2yQojKH70qY397nwy2Z7wy0KKv19dgK84V+kngwrf40Cmwg3AB0CD8kHX8nzG07CvueOJxySat1IeAmsxDVN5959MJ9zwZiGEqodCb7wBaw9cTfx6KI+7yRyoQneq3tbWJDd8WWtwXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8eveVOsOqlgiWdKX5XlNF3lqVszhPaGXVqKswy2xkU=; b=JEDWqCcxRJVZKp5FZYA3hk3DyuooIgTJASoo1RlAGAHlX949TU4tYFbIAlbYHVsoJxskgEj1E+fIu4mN6vmWTbMyoBA4moYJFqm60ESgDY88RiO+rxyzxT3IN7BoOCqch0qVubaLGid/32deP25NOLkh+hQzigvP8FbDHq0ssLVWe4vdNbb8bq/Amw5B979UM3tt7VHb8PQHrtCAQnxDn+26G8oo1aS5zBBaYvA1lEqq2DxG9P9ancH2alUDdmRtfCB0jk8Ap7ZckqCEr+0uK4iyKSwoO69v0YCy7UHMyeSJz45FCnV1Z6JdaALyNi5+X+RoyUT2aTA2bn/OvJEiGw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <02c49ab5-e943-d256-e5a1-95b5770f48a8@suse.com> Date: Thu, 3 Aug 2023 11:09:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 04/11] x86emul: move variable definitions to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Stefano Stabellini , Nicola Vetrini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB6851:EE_ X-MS-Office365-Filtering-Correlation-Id: e53dc178-4f19-4bd8-8f73-08db94015892 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +igWFaFi8y6x3PUqbOBNhKnOHzbmSwEbiPlaKnmbytoqdYTJ4pTCh57kRlnvmv+D1md1XgmuAhYy1kyO88rTOJcf9kVMYvuooqb8ZP0ACR5P/kylRHUbKFQXOQZy6MvUh7880JNDFBZ9AJSB6yVGsjFzHpN01/N6O22G83GVBvywMZgjSxQVaAP0F2InBAOq6vlgIySn0q7LBHibjqLFqX0J+pOxyWKiBgIAtQ/oZ3MbNY5pekl19rB8vcYNbIi21kpF+YXOgqaK2g8AwvUWDWL+j/Wtrko4NR6z5PFciU0KLvhxugtNOUzbxsZSgp0L7fdYEvIMFGoiPfODji71WOCXmVRly4pMllgGvVxI8NFFu+cz4fLHZFsk+zRNZ7gi7jBnj7+TlsgUOJTKr0ZszqS6ZE90FUITejv1MwNysbgzWN9M5lqIL/LI1Ne/fvlsyME8pi7hleem9nbd/CPnJpRCnaGhoCT7MXkL84rVhKOjog37YxcZtCqEa23lNDMF6M9rC8Y079YlLy9dwbDaHw/yMBp7OEqBAG/2ADnFlocCkBM0RUnVVewso+TieuQOP7CiaA8BbQ91BpcyvEoivOfv/zJGQ9ox971aU3TVV3GgYaXoY4dHr4LMzyttd1/N8V4NUasLjVjCJbrADZoQBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199021)(2616005)(53546011)(83380400001)(6506007)(26005)(186003)(41300700001)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(316002)(7416002)(8676002)(8936002)(6486002)(6512007)(478600001)(54906003)(110136005)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bitEdytpcXJjOFlqZ1RVSlFOSXlPSVEreDVWK3NoQkVSSkY2UnFYZ0luejZ0?= =?utf-8?B?cURxMXNlQXcyU2ZxOEdjdGFMaXRzYjY0ZENQd0JvQWdIVlk3KytMb29BVmxX?= =?utf-8?B?eHhDVW9CZGlLRzlVZk9BbTRrMjhHWDJ0eFQ4WExhYmhjYkJDQkp1R2tjamxi?= =?utf-8?B?K0VCNFQ1S2k3Z0N4Y3ZNcXhHV0NNM1hQWkF4UGZFNXFjVDJuK1JUSHhIbVFJ?= =?utf-8?B?eno0Y0ZpdXJCSUpRVmJFMkVrd3IwRERIc0krbmh6QnRpckJkRXdVSWV6azNo?= =?utf-8?B?eHBUZTgrcHFYRzhIZWYwM0pQMmhpYzNWM0RvNlZ1Zms2SmlqVlVFdThMNFow?= =?utf-8?B?YVQyWDMyaFV0OEFFb1lyeldnTFVocmg0SndjK1Y1amVqMUR5YmhYaVl2QkpK?= =?utf-8?B?VnpJQ0ZYZ2FtYWtjYi9hR05ZOVMweTRNbWpxUE41NGIxY0ExMlY5N0s3ZUtX?= =?utf-8?B?Wk10T0E5ZDBYYlB6Yi9venMrT2JxNnFtZTRqOUNtVWpSZitvbENoUmFqOHpy?= =?utf-8?B?L1REbHlFb1Nidzd2bXpGRTBpOXlDaGRxa2FqcFA2ZHI5R2kweThSenZJd21H?= =?utf-8?B?a3lwY1BhcE1Bb29uSk9RZTlkSmZoY1RJaUxzOFFWUlVqdUN1T0Q4NCtNaStZ?= =?utf-8?B?TEcxNVVjOEVTZWt6OXFlYmpBMlM1dE00S3BDdTcwMXBnRFlJbHdOSC9LZjVy?= =?utf-8?B?VVFpSUlsSkxQSkNwRHcxOC80K0lBckxsak1zcFBGTnIybUkwSW5WWUgxdXhU?= =?utf-8?B?eDlvWWk2YjliWUVrN2RMMEdaUkdXN3J2MFYwYUVVaHdwTUNmVHA1RzVsOFQ4?= =?utf-8?B?YmR6aCtwUVdnWDNYTnMxUVZSdE5KRDdkdzA3UEhCbTNhRjRRaTByK2xqQ0h2?= =?utf-8?B?QnQrMlpiVE9OVUN4M3hKRVExZVhxSUFSOE1UcFUvOFoyeXNaQUphVCtsNzd3?= =?utf-8?B?V05mK3BhKzhZTHgwSkxpekkvVldUcDNJN3hkZXpiT3h4WVRoQU1ZcmNLbHQ2?= =?utf-8?B?SEo0THhPamU3d0w4VHBaWnplRE83T2pHMlI4SUVucVdySWljWUo5TDl0SU16?= =?utf-8?B?cndVdnJKSnBDczdadVJIR0YrY3krNUEyeUdLOUc4K0tkWGQxK2p0c1NQS2hn?= =?utf-8?B?Sm1NNUV4blF0Nk5vMk5zUzl2cXlQUUhQMHVPWFFNQmZFWlB3TjhWeDdqdmZU?= =?utf-8?B?SGdsdmNybU5hem1TS0FDVmZITEU1VTJTSk1jZW5BblZBeW1ERWFGTmFRZ0Y0?= =?utf-8?B?QldIeWVXZ0FWRW16aTRIYnBXYkorR2hsMzJQVG4xU3dua3htY3VBZFpVb0My?= =?utf-8?B?MlpTL242UmNMbGxEd3BFeEtuYlJ2c3pDWHBDTE1iRFhHVndWcGxNVHMxTGVa?= =?utf-8?B?NWFvdmdmUVRmSmVJMDZsZHVVSVAvaCtmcmJQQVh3V1pQZzZWMnN0dUFPK3pQ?= =?utf-8?B?UGViUlR1dmoxVkxtV3ZKTEM2b0ttQVpHWHpyTm5oTDQvaWJYbUVnSlR5VDd0?= =?utf-8?B?bTkvaXRqZVJQWFF2eWp6SEtYZ1hZQnBqV1JzWk5PSzl4VU1tcllpMFo5OEYv?= =?utf-8?B?Y3VkRjV4TldGMG8xa2QwTDRlc0tUeXVVNWZnYmZzK0ZKQUM0SEFJUlNRN3A5?= =?utf-8?B?WXFCa3FRTlgvUkI2NjhabUNDOVpHeUJRT09sM3B1S2dWMmE1YmRPcWt1ckxx?= =?utf-8?B?bTFzczdBSlpuTHB2eVNXdWRjdHNFbnk2dGsxUFF1WGovb09rbEdHSGd1bkIy?= =?utf-8?B?eTg1NFhtVzdNWkx2WXFmM2l0V0NBS1hNcXNIVVJ6UEZHcVpkSzEzTHowUVNj?= =?utf-8?B?RXpBNFBYdnB1MFlKdmV5T1NXVXNCMzdmVkFPcTVVaEFSbVhqT29UZkdQTEs2?= =?utf-8?B?UnpuUW9pQVREWFdwdDFHRVpGRUVRRWMxZ0dFZUNha2laNCtNcEMrRjZSa2Fx?= =?utf-8?B?M1pzY3dZbnZBT3MyS0orR3I1MVRFSXJVTFIwZEVaSURJSklVdTFRTWdJTUhX?= =?utf-8?B?S3dHWjhnWHh3MERQZ3VVaE9VVEF6T1BsV3U3SkZCbXJiQkw1SmdKTVNxWU5x?= =?utf-8?B?NDZROVRDWFR6dThPS0lWQld4YzFtQWEyckJtT0lBNjVpTC9sVmw1N3VhMTJ2?= =?utf-8?Q?Bsq2IihcPg3VrIb5fospA6PF5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e53dc178-4f19-4bd8-8f73-08db94015892 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:09:30.6693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /jDDVrYT3vhbzn1Os774ehJUdrrBSU2xqN/bgURLqz+6+HtFOwlG5EyvqKL5ivUNe0PaHmQ+gIN+PlDmNalRTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6851 On 03.08.2023 04:33, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> @@ -2289,16 +2289,15 @@ static int cf_check hvmemul_cache_op( >> struct hvm_emulate_ctxt *hvmemul_ctxt = >> container_of(ctxt, struct hvm_emulate_ctxt, ctxt); >> uint32_t pfec = PFEC_page_present; >> + unsigned long addr; >> + int rc; >> + void *mapping; >> >> if ( !cache_flush_permitted(current->domain) ) >> return X86EMUL_OKAY; >> >> switch ( op ) >> { >> - unsigned long addr; >> - int rc; >> - void *mapping; > > These three could be... > > >> case x86emul_clflush: >> case x86emul_clflushopt: >> case x86emul_clwb: > > ... here in a new block Except they're likely to be re-used as new enumerators are added. >> --- a/xen/arch/x86/x86_emulate/util-xen.c >> +++ b/xen/arch/x86/x86_emulate/util-xen.c >> @@ -77,10 +77,10 @@ bool cf_check x86_insn_is_portio(const struct x86_emulate_state *s, >> bool cf_check x86_insn_is_cr_access(const struct x86_emulate_state *s, >> const struct x86_emulate_ctxt *ctxt) >> { >> + unsigned int ext; >> + >> switch ( ctxt->opcode ) >> { >> - unsigned int ext; > > This can go under case X86EMUL_OPC with a new block Same here. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:16:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:16:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576125.901913 (Exim 4.92) (envelope-from ) id 1qRURV-0007qA-H6; Thu, 03 Aug 2023 09:16:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576125.901913; Thu, 03 Aug 2023 09:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRURV-0007q3-ET; Thu, 03 Aug 2023 09:16:25 +0000 Received: by outflank-mailman (input) for mailman id 576125; Thu, 03 Aug 2023 09:16:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRURV-0007pw-50 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:16:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7d00::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 693f3aab-31de-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 11:16:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8636.eurprd04.prod.outlook.com (2603:10a6:20b:43f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:16:19 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:16:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 693f3aab-31de-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UUPvXqQLlcpGrmHBxoCMFObe8JK91q1IJ+W7bA1UaTYm+nlGy9jRJs/4pyn40fv+txk0qMAXilGYmhkjjcHshbqV8gP3JyVNKUVx6MIH2STQulL8gB3iRB2UetWgtnfSviiBdbaug/x1U4pUAYW8gzdeP9cRLWWM82wKwtOxAbKrI6abS4XCzh0U3v0jlK5Yd3XEgWa4Te/Ax7Ngq8bspIwRvH1iK7bpiWL8XS4JETAfRtIjKjK3+7CXv3orcjMFL8LNuujaT4Kj0ZFLog1F7uHh8lJ6qRMBterEsGx51tFYzkuh8NVbpgZFQkdksQ/Hs04L5kmAwWwIEBnA6tdYKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1kj9ri09BREZFT2T6zcvI87nG5Txd5cPnlOAP7pxLDM=; b=MEAL98fu3CWBgqE6GwwPwJu8XVp0+S4WFhBZKOM7w/UAL2WD4KK5Qxf4CFN0QjhajiMNtxWQ+qb5dQT5i5ujql3VZ1Z11ZU8EGpJrJDMj5M0kGtF1tQt5ELLF+g1BHXaD8Hx+LmY1mVSdgCchc9GFkOuh1u+i0FPysbvFsBQr5kM93aqjPxh0zB6UI5iH2dY2SPEiVg65F0YXHXRmbOGxRbAo2JzPKY2yAjU45yOR/kzMgz4HZi54kbJlJb+xT+t4eFjwVokaG49at8huSPH8bjWLN4+iDL5JeCSxkh0MgPwV2AT7v2dFa8rXWFQO1rvbxczbs8w/YT8h5rAZ+fxIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1kj9ri09BREZFT2T6zcvI87nG5Txd5cPnlOAP7pxLDM=; b=MB/NMgelSiG1eRPSnVlOsdpjR9yLLk3yUfZf0fcW6ZuSiE+6KmemR+6HPofgeToYkYDF58ZDb6XQVTgBwa36fGetMA7aSslIfQfhmYaNfkCYkM6XNnVGZeyf+EiNHE8O3AGDyWWze+y4kZILlKlpcOCASAP0VLD4l3SRsNG+3VquInf797dAGou40NwglHnXzAh0DuAvpw0zCwiAUEcTQyBhAV2x6mAUZZlRCVFm3fBmVDQOSCfQLN/JbGUvPXHn2fYyVy19v5BykOisli6nNC6AAAw6k2GL3rLR5oOdvCt+i+ihLjLeQLhfLtZqUotW3FPWaVQEn1o+Z7sPyE2jUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 11:16:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <7f8cbd8c8ad64cd3a0d099f31cb4d3fad48aa63b.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <7f8cbd8c8ad64cd3a0d099f31cb4d3fad48aa63b.1690985045.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8636:EE_ X-MS-Office365-Filtering-Correlation-Id: 90cc0d34-57da-4d69-6c97-08db94024c03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZT8cbMB5al2XSuUyAJNq1QDuDhHehKBoCWzkXh8+1/muuiozapiMDymwDXGbxhIwm7OOUbbFnMfF8w68EHzpydo9BkutW5QQgREhscwlgm6wTt7nxP+HRbF3eGbIjngC9XCOXPZ7dEbxmhX/huEfG/hfbyKTSAYQQXOlpBiR5SWvbuQ2TsJzUVIplAcZpqK+QJJvwhr/uKR3vtf+7Tc/x631tc2x9Sw+sMDIIpSXse750s6ywKjFCxXgxlThPCQBOfOK+AVwYqttUgaPLue6Gvj+vYT39rvc1grpBbTjV0W+E9xZ95RaJh6fsNntmf2wXH79/DK+ThceDtLWx1EzJO5H85XfAICX3PD8XGcntlk4UjazHmzZhAoQRQtQRdHf2gm8gMGbmZZ/sXv93mImkP726ouXfPex/587vmmuMkGZOoaebl0dJec24FrjK5ySlOAwij9zIONveGz2dTrgzWe55Gd4Tmp8rUge2SX4dUWlYrwl8bZ43Lk/X+mD1+EJK63a7y9KYM0AuxL6rrFqPNbzTwAJVhSL6yJcBt+OVghzyGkgcuYEiRNJQKHok+7rKo8YvWDuGtq88MnIQulEis/C3EwkuG8CDfg0eLcnGKO2sYfMR/eJ+SlC2dDsQfYPW9bjeMWsLS3EjmHKEXMNAw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(366004)(396003)(136003)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(4744005)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(7416002)(41300700001)(8676002)(8936002)(6486002)(6666004)(6512007)(54906003)(478600001)(38100700002)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0l5cEE2YXIwdTMxanB0N2pNeE0zK0lkMWg3VWtnMVlRbSs1TnNubnJGTGdM?= =?utf-8?B?bDd1Qzh4YXJubzFIN2kxTDdrQkhCMm9tUkFhNjV6L2JSRTBRcWZRcHYweGRx?= =?utf-8?B?TFFpVmtJRTJUUnVMSTFtQUcwMVBrMXc0V09kSm5sL0lkNXNrYTZEN3VXSFlt?= =?utf-8?B?N014b0tZYjhvRU92bWVHNDR5TlNnR2VBYnJjQzBDOEp2ZHhmd3pkQmNQZm5Q?= =?utf-8?B?SHQyVnFVVVUweFE2UDZMOXZJaXgvNG5GMVNIV3IzaXVtMjFlVjJ4TUJuWC9a?= =?utf-8?B?OTljbXRYR2Uwenc1ekw1TjRUQjYyZWZLbmhUK3hWVEVFS2l6TXdVRnNFZ2hY?= =?utf-8?B?VDNSSHdRTHRiMnE3SHZKU0J0a3dvZDJuNVFaQ2lqVldFRE8ydzN4R3RCRmJK?= =?utf-8?B?WCtYTzdjUHR2b285ZVF0S0ZBL0hIaE91Zmlwc1l0ZzZxT0dEcXllU2NrL3lO?= =?utf-8?B?VU92aEExZ2wyMndmM0VZYzVXZ2FVNHArdHh4MlM1ZCtrOGp2NjJWZFRKMjVT?= =?utf-8?B?ZjFERUNnWXFaSldyU2NGb2tJWFppWXZDMFBZam9MWTQyaktKNU5hSVlEWi9N?= =?utf-8?B?Q2dDREY1QTdZdWh6OS9DRFFXdTRBTTB0RzNwQ1J6NnNjRHF6RjhicGRrWmlD?= =?utf-8?B?YUlXV21UMkN4MS9vNEFBRG14K1g1NG53R1N4K2pUN0E0SzhseVVHODVqdDR1?= =?utf-8?B?L0Q1RzA1NzgvLzZ0ZU9hRU5OelJnSzJHdk5BVm1ZVTF5b3QzekFFT0c3NXdS?= =?utf-8?B?OUs2T2lYUGllMUZFZDJJeDFXcmxuc1VBaTNGZHlyNmFOR3JHMkpPSHVoTGF3?= =?utf-8?B?Y0psV0lKZnpad2tsUnN1bElMSXVPMGFPdzlIQzJLS1FLWm56K1JqQTE1WXZv?= =?utf-8?B?bEswZWVqRng0T2w5M2dCRjlNejJGTVNneGZpZGc5NUQvekpFS3ZiTkFKRWRx?= =?utf-8?B?Q09CRDNQVWNNTUNOakpTOHppTG54UkRGWEZyandQMStTSlRJWkhsN2RsUldT?= =?utf-8?B?Y2FqdXVKQzFaUDVwQU5pVDVNditGVExPek8wVTNKaUNnRm90SGU0RzdZMncy?= =?utf-8?B?YWFFL09YcktmTzY5dW1iYXVybDRpTTFYR2Y1akdtOGZ3Mnh3WXN2dnN1R080?= =?utf-8?B?NFVkZER2dTluT3NpeVpybm4xaFZzcURuYkg5OXkyNE9pbXpiRzh6N3BFQ1Nw?= =?utf-8?B?RndXOTdJSSthM0piajFtbWhickNOWE9iOVdXNkN4Y2JKTVpGQ2J5TkcyS3hB?= =?utf-8?B?MmtDT05TUWgrdkY4UC9sUy81MCtNSGdPNFp4QTd5emEyY1NPYnk3ZE5VZGJk?= =?utf-8?B?YWhUNldGNzhBb0diNWVhWmZmL0twM3Y5SjJyb3h2dDlnTHVhRzQ0UyszTjRj?= =?utf-8?B?WUt1UFVFOU1wWjBES2krMlA4VFFSckJVYnMyQVdJYlZSY1ZFTExIeEFwWG54?= =?utf-8?B?T09MZUJPOTVjbjNleXVjY05SOWhEVkhLR0thMXRVV3FteXVEVHdYSERhV2p2?= =?utf-8?B?NCtCcVZDMEpab2pHSzI2bm9BZ3ZleWZYdlI5QzllRjZKc2w2emhVSlJjMXll?= =?utf-8?B?OGRVY1V6Zlo3eFErMnRsR2w5U0FzVFVmY1oyWkRBZExlRFZvOXR2Q1dhNWZx?= =?utf-8?B?aFluOFdoeHZ0V3dJTGZ5WHZUalpjdGVSc0lkeEV1N2FqKytrNHAxUEp1SE1E?= =?utf-8?B?OG9sdTZUUFhLdUptMEdOZGtRSFpFZk5TTWwzcDZNNUJqWlBrWEVRQzVwcGtU?= =?utf-8?B?WEVxVTBzdmk0RmJhbFVoSWxXOTcvcTM2OVdhN1UxUmUzYUdHTW5jbEIxdVdt?= =?utf-8?B?UHBhTlkxbWhkNU85NlFPWkhINmc3WXBiZ2UybkI4VVc5ZEE5UHAwK1VlYk8w?= =?utf-8?B?VjhIV1VUZTJPV3NDdC9lQ2Q1YVVEM21JbU10WjM4aXIzV085V01mb2pYWExs?= =?utf-8?B?Zm5VQVYxUmdQQmhCMyswMnpSV21BRFRZWmlpRHhuRk9XL2hKa2pNbjcwWm9I?= =?utf-8?B?MlJrN0tBNVpvQjNPdlg5SXM1by9UWHc5ODNMTTRZT3dsTVdRb2ZKdXRwanY2?= =?utf-8?B?N0p2TnVtZ3RlYkEvL3BJSENyQ0kvcGZpYkFCNU1DWnhrbFFUYU5ranhxV3JG?= =?utf-8?Q?OzIG91gkaOAfWlUSuaQwhej31?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90cc0d34-57da-4d69-6c97-08db94024c03 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:16:19.0263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FIY3NByFOOjJS4g/Lp5xglIkhxMlmD3PneI2/HkHJGs40GHrNlOd2Q/z8/9evxBTS8WAMWueXtG9WqBDnkzFgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8636 On 02.08.2023 16:38, Nicola Vetrini wrote: > Rule 2.1 states: "A project shall not contain unreachable code". > > The functions > - machine_halt > - maybe_reboot > - machine_restart > are not supposed to return, hence the following break statement > is marked as intentionally unreachable with the ASSERT_UNREACHABLE() > macro to justify the violation of the rule. During the discussion it was mentioned that this won't help with release builds, where right now ASSERT_UNREACHABLE() expands to effectively nothing. You want to clarify here how release builds are to be taken care of, as those are what eventual certification will be run against. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:17:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576128.901924 (Exim 4.92) (envelope-from ) id 1qRUSu-0008PC-SC; Thu, 03 Aug 2023 09:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576128.901924; Thu, 03 Aug 2023 09:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUSu-0008P5-Op; Thu, 03 Aug 2023 09:17:52 +0000 Received: by outflank-mailman (input) for mailman id 576128; Thu, 03 Aug 2023 09:17:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUSt-0008Ox-Qs for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:17:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7e1a::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9de3da00-31de-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 11:17:50 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8678.eurprd04.prod.outlook.com (2603:10a6:10:2dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:17:47 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:17:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9de3da00-31de-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfSmX5lDI7WU/+3s1fMwFAoK5fwYkUGS0BRfQaenDQlNYtg5eQrrr8uo2WYVrnP9Zm2wSL/v/Xt0uR8etWl07An1v9c7IBoMSelrfo5KrkGeJw5+g5OJYeLcq1JH/wbR970ZIU1p/nwsynAV3udkgm2PaTfXje4D2C7D3NfbGjxK3GZy0TncJclhNrwMLZDY67I0SGy7NqDAgsTnh4RPWGluVsannN2Ychzutzh0nrx66OhT9CMLXrW6oLIoIa3ZmbUSU38fomtBDbLSyWNcSVXYctJq7tajzUCahpTaD7BAZ1fPexqpIGhZBRKPAQ2MR6mlPy2aWnGX0zpm35w/Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=enfIGUhhvDBmZOOL1jGIxqtRs6Basm68Vb70YeM5t5A=; b=BQsl7swxVwQzPZGumSXYsDKiLW9+J8emC5bFkyR20VhCSMSRYjYhoHfdwrxG8sNETGmXrfzZRCul7PIZHgVDkMCao8tJPbT1J+Ti535JxQBNopewz3/orf5PUivzHvnu6aV/S4SR9XnjOExKd51FWwtquQL4r2ahsYw8pf7LHQPv6pJU+qS6qa/939Q68RaiWSmxjdKiZsGfTI7I0m9IV/P+h2O6MXwgOQvl43OO9ziIvr9WoRQHxQ8R/d8M3yz3L9XMdgltVvtMbsDkLjyYY0CsHTumHVEJ5ylJpwQ15QwyqGrDc/oJ4SCs1OkgkHycT/dbRWCyaTZQao9BKK6tPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=enfIGUhhvDBmZOOL1jGIxqtRs6Basm68Vb70YeM5t5A=; b=NnMx/KpXZECVIPSwdB3aw2yEQ5COuD1525h79nnG/baGKXholK3AjBNyTLcX5Gd5bwwhGS/slRNIQSWuRR3fOBBt26xwe1xgoM7J8iH2U3+aU3tDpLB7YlExyjRyWlhTNMkuH5+TGA66xAbpxRvrb//Oouap31VmlDdBUMgoxnGHU5qsVeKjDFmnhTpOWuEH5p88b4E2nXJPn8DvAh+lERQVKfI9vongT4xOS6WdQfFYuYwePxmQB+P7KtOS/sqCyLdjjZo1zVq7RmOrZJyFQwoy+146ebOMpr3BvxF19L/2C9MIVkuaWvdx7l9GxtKVeE8++bXzOxQG9afIquIguw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 11:17:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8678:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c6feaa4-8585-48a2-b5dd-08db940280b2 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xHCoWj2w69YZQJYSqZX586pz0PEPyRBj5pUexGPupeckulG1wCe2VI7nEbhIqpZltehrirmD3TCKdkMLO9CB1AeMDtQ1GuyMlKLxnG6jLiDEWukCWJ7EnFPvQmHt+ahJwRcxJveRmKO7M0kC5P3q6jF08+vADyzMbgBWB0LGHi9r90883u6AxUHCDEWnHZd77vRqxBQUpFhLHACIMajofKudSueuaEbXL3PoI0FeMOH/xuki00tlPk+wg0fubIQnw2E2kpYgYnq38Z2ifQoIRSK9vmIgCVZsxY1r4C2CJRySyg6rK/zU3ZFrIOZ+mqap8hjzpl6k4MuiPhAXK4I1YRCvzQtE5xQTF1K64nvaWMdzOFbWfmj4XY+3K9VDg0/cMVySLPbRxsoQwbf6dQnS2csQyuBjQ0H0Irdcp9GlS25B9nV7Tft0pw4RTsF2AQu8ih83Ihz9Ks/4izoRMh3p8zDLv9qRqLBOZbAgWLwtWRjTlD4NtuPSPkOMjQBwlqYRRQugzLkeOlPz45R1Kg34gxcxSgHlT2D5qm/Qu+sb5T4lvFAuPnKCXJ17nJfeIGfZrHjwYsO0AsaOzWX5fS7QkrJvWQaD9EK2IznmdybkbYXmVG/Io/Md5IsdAFgMBh2/1QM5UHcbVpJBgyEVOKsYQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(366004)(396003)(136003)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(4744005)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(38100700002)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2w2cThSdDZNM0xKRVRmSnJaczEwZDBIT212enI2T2lQU054SEU2cHU1UUdL?= =?utf-8?B?eGJCdisvZHNqcFRCSkJzMjBlOUhXKzVpU1huMVlKLzBObkNRVEN2bVVFYk5t?= =?utf-8?B?UlNjK0pVRkxMSmlKNnE4dnJpWXJCNktlakl0TUZTdzh1TWtyNmVkVmxkMUd6?= =?utf-8?B?Vk9VYm5BTEFTZkZUdUYxeUFCS1BzVTNyeWdkK1BoeU9yRk96c0VTODZyM2VU?= =?utf-8?B?Mk9lNit4dHJoMmFnQkFaVksrSXdFNjhMbzgxUmRnZitTZEs3Mnhza3oyNGVx?= =?utf-8?B?YXdpcWYwWVcyc0Rma1hBTHFmT2d4ZnA4Yzc1RkQzVFVWb2ZNNlVtaHhUeHMv?= =?utf-8?B?UWxUeXdKY051VVdadFhaTEcxY2ZGNmhoTUg2M3kzOXh1clo1ajU2ejJkNTBC?= =?utf-8?B?bnJVemx5QTB0TmZVT0lZbGU2QzB6WHJUY2dzNnFiTC9PcjJ2aHBNVEp0VnVI?= =?utf-8?B?QXhVRU94aU1Na0ZFTjdlMDFqckh5NVdJOXROODBCNGRqNFRJd0o3ek1PTEhE?= =?utf-8?B?aWt1RVEzU2tBMTRxaVgrYXlpb2orZGlyckI3bnpQbmkrVlN3bUNjN3pqbEkw?= =?utf-8?B?dmdxQjBsQUtxMjMwNnVLNDk0aHpKZm9KZzVsMHpTZlJPanM1MW1WQVd1M0Nw?= =?utf-8?B?TUNTZ0hDei9Mb3EwM3QxOGVuN25VVlJuQW1qdk5WRmJEcEt1MURSQVhrRFdw?= =?utf-8?B?dm1nZmFwWHFSR2ZiaUJXQkxwcnF4aVVvR3ltRlNYbC9CSDdCY0hjQW1uYXpo?= =?utf-8?B?KzZIcTJKNGs5QkVZRmhBMFk2RUdkT3FrbDllZWFKck12NGc2ZG1sL1MvSzQy?= =?utf-8?B?cTVyRDIvTDJvR2w5ZzZrVEJQa2NrcDA1aVJUblY4Y0duQzRKVEpzMVZMNkRx?= =?utf-8?B?S3psTFRDOHAzOEd5QzdUeTNSZWRjOEk2bWJzRFI3SUgzb2svYzROcm9zN0F6?= =?utf-8?B?QUdRNlJkVmgzL0g1WDZDcFMwMUNlQ3pjU0d3aE1RZ1dGVVhXeUhlNG9BeklN?= =?utf-8?B?RnBoYW5meGtKa280VS9hZlBDSHNGeGc1bnJHbXJKZWJ0RGZjZE8yYVlxSlNi?= =?utf-8?B?MGVVc09aVGk0VTlZMCt3Q2JKUlR2UXBwTVRQNHZyeXpQcDZtaU5qS3pxUXd2?= =?utf-8?B?MUJpYUwxV00rKzhXOUNVc3FxNVBGTWR6WmZzM3VrVHB2S3d5T3QzcFpUWHZy?= =?utf-8?B?bWlzT25WOUpKL0x1Wll2ZmUrSXhzZ0hGVHlLcEhmTmFURlhjRm1TaTFtMnZa?= =?utf-8?B?NXoyQkRBWkloQmlnaEF1eHJ1d055Z0I1LzFVanRQT0svNFA4TWxYS3hjU3hI?= =?utf-8?B?ZlJGenVBa2VldTU0dTdCSzFOWmQ4aC8vY01QMC9RK21JMFRDYTN6WEJkTDJl?= =?utf-8?B?Y0xURUh1QVNFUTU2OHcraFZhdUJLY1R1TDQwVXBlRmlsWnhzN2N3anZTTXRy?= =?utf-8?B?ZzQwU2Z4Ukhjb25GZ292WnR6M296K0hGKzdReTlVSk5YdE5VRzJXYUxLd2VG?= =?utf-8?B?bTlydDNnclg5VXBsVVprbzU0RDZkMUN2SksrWFJmb3c1OWlkdWt0ODlSbW00?= =?utf-8?B?ek92WGQ5RUF4S2x3OEE4NjhzSGV6SFJGcEJZUkNiRnNFd2ZmK0R1WEZKWUNw?= =?utf-8?B?azdXc0xNTmM0S1k0RXdPQ1BweUFxRTlkT3RITFFLQjQ1c2krdEtYcGlDVmQw?= =?utf-8?B?R1lhWHJudGJlVWNOTy9mS01jUER3bXgvRFpwUUhuQzBaMC9lekV5SDdMY29q?= =?utf-8?B?UXhkTXgyalFDc25iaFF0MGNvZHluaDZxMUJDckN6UWx2THQ0aGtiRjlpdE9x?= =?utf-8?B?akVQYlRqakNscHRwSFUzRkJJOW9sNmpVZlBCdkpSM2ZxYUpMS1pmSzdEaVVN?= =?utf-8?B?WUxGUlRPcmJqM29GTE1VVXgyL2JaZ2ZMVWM0VHlqOTdrYVlNNFFubSt2NkxV?= =?utf-8?B?YTU4dGVwQlpPVVNQaEJsTGNoVFBKUmxwbVduZXpGeU5WRDhsVENvbUpYSEVa?= =?utf-8?B?dU1yK3IrSno1eTB4c25KYkNZd2pSckEwVm8xRFlSM2lXNXp2d2pzdzdqMDdV?= =?utf-8?B?OG9yOC9Md3g5RGs4UjFMMHNqVUtZTWhDSTZKaVNhbFNBdUx5b3NDS0FLclo2?= =?utf-8?Q?3F4ZFZcvKt1gvgm3YUxXby2R4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6feaa4-8585-48a2-b5dd-08db940280b2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:17:47.4384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nFvUo+XwPl58QuBY5dSca8uDirfjvQUYHnUnfLR0PpTAr1S+gt6nIDMSLIi5AQwHLvNWLHcs0+EWtNbKe09KMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8678 On 02.08.2023 16:38, Nicola Vetrini wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) > /* fallthrough */ > case TASKLET_enqueued|TASKLET_scheduled: > return true; > + ASSERT_UNREACHABLE(); > break; What use is "break" after "return"? IOW rather than adding code here, imo a line wants removing. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:20:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:20:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576133.901933 (Exim 4.92) (envelope-from ) id 1qRUVQ-0001Si-Aq; Thu, 03 Aug 2023 09:20:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576133.901933; Thu, 03 Aug 2023 09:20:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUVQ-0001Sb-8D; Thu, 03 Aug 2023 09:20:28 +0000 Received: by outflank-mailman (input) for mailman id 576133; Thu, 03 Aug 2023 09:20:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUVP-0001ST-38 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:20:27 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa7edf91-31de-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 11:20:25 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id CE68F4EE0737; Thu, 3 Aug 2023 11:20:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa7edf91-31de-11ee-b268-6b7b168915f2 MIME-Version: 1.0 Date: Thu, 03 Aug 2023 11:20:24 +0200 From: Nicola Vetrini To: Xen-devel Cc: Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Jan Beulich , Andrew Cooper , Julien Grall , George Dunlap , Wei Liu Subject: Address MISRA C:2012 Rule 8.4 User-Agent: Roundcube Webmail/1.4.3 Message-ID: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit The headline of Rule 8.4 is as follows: "A compatible declaration shall be visible when an object or function with external linkage is defined". Some functions reported in [1][2] are lacking a declaration in the respective header files; as remarked on xen-devel's IRC channel, this is ok since they are only called from asm code (e.g., start_xen). A similar discussion had taken place in the past (see [3]) and the general consensus was to deviate these cases. If that is still the case, a suitable project-wide deviation can be added to address these violations. [1] https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html [2] https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html [3] https://lore.kernel.org/all/20220705210218.483854-2-burzalodowa@gmail.com/ Regards, -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:20:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:20:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576136.901944 (Exim 4.92) (envelope-from ) id 1qRUVf-0001q3-I7; Thu, 03 Aug 2023 09:20:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576136.901944; Thu, 03 Aug 2023 09:20:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUVf-0001pw-FS; Thu, 03 Aug 2023 09:20:43 +0000 Received: by outflank-mailman (input) for mailman id 576136; Thu, 03 Aug 2023 09:20:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUVd-0001ST-M5 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:20:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7e1a::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03b7f1d8-31df-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 11:20:40 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8678.eurprd04.prod.outlook.com (2603:10a6:10:2dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:20:39 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:20:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03b7f1d8-31df-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJlx66OZkNQHDNQEHHKfhZow7njOA8UR1ijunZRTJmTw5dLxCXYu53CAXp/fQoZmpPN+Zw0Il+80AKJIoEtOnhaK78//kjyKsLFRKG98ncIOD9Q7HfLppKYdu/GF455bUtSQhnyK1hdcUFVdq6/paY6RwTLcVeALfYCAxkVkUyEbu4Or3oEZZ06Dun+DGWPiJiGgKiOJDt9oCczDD2+XcZPqjjR8v7KBxwCBgOJSaxOKFGsniocRqHvQkyYPvJY9aJOvFQDwP9mKOjNWbl9U+8hT02HXT0XUsDqFY4njUMSQ5EMJ5VWS+ESyjBBFQNf302DV88Y5YdZhc4TSbQcdtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tA1PdkAWBB6c0y72UrfcTIBqgkop7cNxizi7uWeUh6w=; b=R4r7Ubpbde8JAo4mxXescEVAVuJgrmPQbB+3uMjZmjMi4lQyrPvmOXwolPhl6S2EfrbxQLuh9DexSfc/RNBiKuBU3suE+LEJ2WxgIl5blakCTcjM9K8Pv6w/z+hUwDJ0U3ZiXA3GerWtjQR4vvSVfYC4ZrkKONWlxfFZKrDaYKXx0LoW56h2RO+ynms5o5FMks78XjqR8X5AJscuEEtekRiCW2jKRnelInXGcU+svCeCXm5eXWsRB6Rm7fkyMqomezka1HbXVL1ONxIxAmwsXjtxotir7zZtg0KNv5PJLrSvWkA0dZKGs5WMb8hWCgpn7Q4PYOtEl6fRFEGFbcuT/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tA1PdkAWBB6c0y72UrfcTIBqgkop7cNxizi7uWeUh6w=; b=oyQC8SZ6iKQfCngEL0lnc9wFZwuCVXxmZJxQkX4R6uVevSN2KASHuqAasjm/utNLjcHeYazPEuoW/Dvn9nVL5t31YLQNoVH96O7JYSeLrCX6sZHaGf8Jy3CX1XcWWWc3WwWLCXeADEqBvZPlr48vqLA0rbgxPJcVl8QkOnIj8bsryDa/28RM6iBVyZp1izZ9zzmaoU6oqcqubHxiaotp1lQw6cJtbS8roClrRPCixpEPAeUCCspT5r8w8MNJiVgkQ4m1IYH6ciumbtCQGNvd2M758+uY7vPASv1qW+LZi/hOCgBih4vCSsklKYNEi4lVLRwnXyvYLZa9dAI12CWb0A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0ba36273-33ad-753c-06a5-be117b6658e0@suse.com> Date: Thu, 3 Aug 2023 11:20:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , xen-devel@lists.xenproject.org References: <91b2f2c9e728c1f19f7baab301299d995a074279.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <91b2f2c9e728c1f19f7baab301299d995a074279.1690985045.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8678:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f333f81-b4a1-4895-ea92-08db9402e74a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /l0MpECWaENy9MOPbCNbji8bWyg+031oRhtBoori8dJBIZnXEatrmBOx9rvqjJwog5nh+0ZWrVfHyZMf7Uzn8Uby142URyznsps4lLQFqlCa7q0fVcZOXZkrUu8AgUAlpecdMXH3fbdFEdSXURy3g5+p+528fH7SblZVIt/dUBdgBzVWH0nQd4aHsUFWb8DFwjC7C5TJuLf9swVD77g0gwZmwxiYKKPQehST1YUgzd5UPHYSxbL1npH63cEpRz2Yv6/OEc6YAYfe1KHeFJPXZLc+wB+nUd75TgxUyd8gB2k0L0qAJCqmiaqE3Vil9K/OmfEzh9ZK2I2FYz8gMbZTo23bcbjSo/BSbA/BoqO4Dj+uFsRAV0+hC9VWZ92i5//4JasVSbQ4zAVoyQqCPLpARwNezIZJV57FS4fisgJL4POIndnWBz8f2L7z4Qm/brzB+MjrH+opGi+T41mqiizfcTVpvp8gjAJFi0SvN2BubkG8DZNEtnWNjsUBsEWd37pgOUGsKctgK+0xdKgnCS3tpLZq2tKQQeHLUCVnaEGPH9onb/+UUnTLUDKb+H2n2cTcl4CEERg9Pr2hVPs1ORV0BY4/sMEvBU9HnjCGmMRA32kWPCBldycuLZHL1Votsc+01SUmvsG80c8R1aJtjePDWA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(366004)(396003)(136003)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(4744005)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(7416002)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(38100700002)(36756003)(31696002)(86362001)(31686004)(66899021)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUd0TzlJckZLMHRIQVdvS2pZc2MxTEgzMW40eUJjNU9TZVo2cVE5RXNxOGZw?= =?utf-8?B?c2pXdDhtMHM1RGR5QWtzdW9UczZQc3NUdXRpSHJyVVZiQUZyQmd6S25sOTdo?= =?utf-8?B?QVo5bjNzczNmUlVmUkRlTHF3OWNyeVVpMVVJeURLMndMMlJaNmVaNVVaWGV5?= =?utf-8?B?bzVUNzhSNm5WWHhGZEQ0U29nazZkMEpGUmhQdmdUKzlVNnFlVnhRQUZDODZR?= =?utf-8?B?QVk1RjV1eTE0aVh2cVB3dndkQTBaeG9ZVklNZDl4eHQ2Q08zejlWanFjM3pD?= =?utf-8?B?M0tVNVpLbnFGbmUvQ1FyRVFOVUdPalFsaXpSNlRMT21BUWZQemRnVFBQQVVy?= =?utf-8?B?U1d4eWFGZlMyTHh3eVFua3phcmdDUjg0VmFBMnNPem1zWDVnKzVKeGtHV2F0?= =?utf-8?B?WGQ3akpEWkV0b3ZEd05PdG80RXZLTVcwU1hTS3BMQmttWWxGWTlJSkFGM3Bi?= =?utf-8?B?UVVSYkg0Y2QrT2ErY204c0lzbUF6UzlVNVc4MU82V3Zic2ZjUHBEamN0bVNi?= =?utf-8?B?U09FMlJWcWxvdnBRa1FESlVEcnJSRzlTbTdZMXcyT3EvTHNxMUQ1eFRReWVm?= =?utf-8?B?L3FtUk9oZkFiRmNTeERoUm1ad2tsNWxVV3p1d3lHdWp0VWNoVWFFL3Z2L1ZR?= =?utf-8?B?alluOVl2NEtYdmZSTlY2ZGp3WXZyNDNUWnFNVXhUOHhZNC9GaGprUE5pR080?= =?utf-8?B?ZCtZaHA5dnZ3UncxYWRsZGlNbnI1VE90YWxqK0dPNmFramtnS20yaHk4RmV5?= =?utf-8?B?d01jb2wwTzY3a0JlTTgxTk90amhoWFdVOElDRzhtMDdmTG9QeDBLWGVkRURx?= =?utf-8?B?bnUrNkdweTA3UWdRVzA0MWoydlFLYnZiandEbENlUFVBTm5hSEVJUnBCVE5j?= =?utf-8?B?a2VoRUU5Z29rcVJ3ZE9jc3NDSE5BeWltbjQ1cTFFdkpCWG9TSzc2clNKMkdE?= =?utf-8?B?V3RMR05jKzNydE5rUmpzSkpac0JMN2pHYkZiOW0wVkt4dTVBZWErVlYxU3M3?= =?utf-8?B?Qis3djBRcDZtZ0VvRTJyR0ZobDk0WkxTZm13Z1F2RTZPaG5WWTFra091U3NI?= =?utf-8?B?K3BybzRacGQrZ1R1V1BLek8xZUtPNHA3Z1F6SFZGb0pzZEdGMWZIN0Y3c0da?= =?utf-8?B?d3IwWkpkaW9BUVpGOXhML3ZVMlg2OHQramNJSWpXbURuYUcySGpQVy9Ddlpi?= =?utf-8?B?c1NNNElWaTQ4RFAvOU5aZEVTWDFLeGNsWGNoeDNmeG93U0VWaWpXb1FweHFK?= =?utf-8?B?U0VSYU50RVh5TVNiZHhxa1pwUWFhSTBjN2xtdnhDQ3FOTkYwL3hGQXFlb1lV?= =?utf-8?B?Z0RxVzlSeTBFTUhBZktURFgwTlRrT0M0UzF5V29Od2dRUkYyY243OGlhS1gx?= =?utf-8?B?U0w5MVZQWktmWG13NXlRMkxzZXFxeC9XLzF3L1FlOUwxOVZHaUlwekJKOVhS?= =?utf-8?B?Uy9RWHBiVmEwSFE2NDZ3S0hoc2tvVlBCSHlaTGpmYkcyTmFxZ2tFdG5iZ3Iy?= =?utf-8?B?SWw0Smh4bmQreU52ck9kSlJvTGUyenhrRG1BcDN4U29pRStzdklOUVMzVTNI?= =?utf-8?B?b2JiQXc0Tml4YXFoYyswbmVQU0ZjYUVjd3R5elovU0xmMGs2V3dvNlRVSHZ3?= =?utf-8?B?ZjZJSkZNYjhMNk9FMnkzanB5UjJaWEdyMnFFRHFMSUt5RVZPM0I1Q2w1YnJK?= =?utf-8?B?elRJWVk3RVF6TVJuVzZDOG43elhxdStoUVl4L0VGZ3R0ekxWNVFGUWMrRi81?= =?utf-8?B?SjJrQVJHbTZ4R09sem9wLzVpM1VzZTdXVCtXQTlIamVYQlM2Tkk2TWlucG9F?= =?utf-8?B?ckxKZzI1U0t5SU02MmNlRGhmMDI2NDlFUXJ1T29uSGlYeStwaUM0T1hOU2Qz?= =?utf-8?B?b1FENHd6S1NzSnFrTVhvQWt2cVVoM3IzTWZSNnRnL1g5aUFOc0NGY0hESXJa?= =?utf-8?B?UmUxcEZsb0ZiQlpReEtSRFk0VEd2VmdEdThuZWlmM0ZlNThCcVZOMU1OUTJz?= =?utf-8?B?QXAwV3lRaERyQ0RKSUJnNWc2M0p3VTg5SHRkc2ExSlpkck80NTRNQjlkVVlE?= =?utf-8?B?a2ZrY3d6Q29CSk9YNzNRWDV6K09YNjNXa29MRnFyV1VTTjBWN3RpbWJKSWxu?= =?utf-8?Q?kIyCZHIjrFAxauwvV59qLFrAN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f333f81-b4a1-4895-ea92-08db9402e74a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:20:39.5325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uL8qXNx1tNHC25H65FU8H9vznNENzjGLkWdPAO6nQiy+D6XFVTRzyTJ5iGhMcTWh/3ImUdG2oKdWdFNrYGOYWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8678 On 02.08.2023 16:38, Nicola Vetrini wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > return subarch_memory_op(cmd, arg); > } > > + ASSERT_UNREACHABLE(); > return 0; > } I'd prefer to instead switch earlier "return 0" to "break". > --- a/xen/arch/x86/mm/p2m-pod.c > +++ b/xen/arch/x86/mm/p2m-pod.c > @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const gfn_t *gfns, unsigned int count > } > > return; > + ASSERT_UNREACHABLE(); > > out_unmap: > /* In the description you say "before", but here you add something _after_ "return". What's the deal? Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:30:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:30:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576143.901953 (Exim 4.92) (envelope-from ) id 1qRUf4-0003Xr-Dx; Thu, 03 Aug 2023 09:30:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576143.901953; Thu, 03 Aug 2023 09:30:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUf4-0003Xk-BG; Thu, 03 Aug 2023 09:30:26 +0000 Received: by outflank-mailman (input) for mailman id 576143; Thu, 03 Aug 2023 09:30:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUf2-0003Xe-BL for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:30:24 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e6316d3-31e0-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 11:30:22 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id A6EBA4EE0737; Thu, 3 Aug 2023 11:30:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e6316d3-31e0-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Thu, 03 Aug 2023 11:30:21 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1 In-Reply-To: <0ba36273-33ad-753c-06a5-be117b6658e0@suse.com> References: <91b2f2c9e728c1f19f7baab301299d995a074279.1690985045.git.nicola.vetrini@bugseng.com> <0ba36273-33ad-753c-06a5-be117b6658e0@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 11:20, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, >> XEN_GUEST_HANDLE_PARAM(void) arg) >> return subarch_memory_op(cmd, arg); >> } >> >> + ASSERT_UNREACHABLE(); >> return 0; >> } > > I'd prefer to instead switch earlier "return 0" to "break". Ok > >> --- a/xen/arch/x86/mm/p2m-pod.c >> +++ b/xen/arch/x86/mm/p2m-pod.c >> @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const >> gfn_t *gfns, unsigned int count >> } >> >> return; >> + ASSERT_UNREACHABLE(); >> >> out_unmap: >> /* > > In the description you say "before", but here you add something _after_ > "return". What's the deal? > > Jan In this case the unreachable part is that after the label (looking at it now, I should have put the assert after the label to make it clear), because earlier all jumps to 'out_unmap' are like this: ASSERT_UNREACHABLE(); domain_crash(d); goto out_unmap; As I understood it, this is a defensive coding measure, preventing pages to remain mapped if, for some reason the above code actually executes. Am I correct? Regards, -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:46:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:46:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576148.901963 (Exim 4.92) (envelope-from ) id 1qRUuS-00057h-LJ; Thu, 03 Aug 2023 09:46:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576148.901963; Thu, 03 Aug 2023 09:46:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUuS-00057a-If; Thu, 03 Aug 2023 09:46:20 +0000 Received: by outflank-mailman (input) for mailman id 576148; Thu, 03 Aug 2023 09:46:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUuR-00057U-Gl for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:46:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUuR-00021n-1L; Thu, 03 Aug 2023 09:46:19 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRUuQ-00058N-PS; Thu, 03 Aug 2023 09:46:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uKQlEQh2f1FeMdUq8Ub6MJCuP8O/rZdEBeih/oP3A3E=; b=q8FONRsff89uU1OBGVDHOSB7Qu qVPHuQclpkcD41010jtrWAPOSR+SH6Pv1EkIutuFvgOzqOxykgoYeVcn3r68Bvy5JxthUVcz2rrFa 1yW0tHlgeJ+cyrGkrNuMH68thdB88SzOpE0Tz1JBdxtB1kMOHOpd8U3XBXzPCMaesE3k=; Message-ID: <15e52d9f-8d45-fd22-71bc-fbc71ff39470@xen.org> Date: Thu, 3 Aug 2023 10:46:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu Cc: Michal Orzel , Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <17bc595a-dc30-9e76-4d31-aad62f9c9672@amd.com> <3ED442CB-0569-4C9C-9770-39D2FE4852A0@arm.com> <8c8f2564-935b-e3c8-ad15-348135140a53@amd.com> <92AE30B2-B2CE-465F-A6FC-A86961BED85A@arm.com> <9d40bd81-dc3a-0288-8f8a-1de62dc30d1d@xen.org> <1a364aa9-4549-80b9-4319-d91551f228bd@amd.com> <8516a6bb-8321-fc84-c7ce-10a7b41ecb59@xen.org> <33DCC5E2-7190-464C-B25A-68BC68CA4021@arm.com> <3942c22a-80e1-29bd-4bd8-15d4bc43d220@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/08/2023 09:39, Luca Fancellu wrote: > I would like to ask if you see this one going forwards or not (as it is), because I have a set of patches to isolate and Kconfig-out > the dom0less code, that is depending on this one (for a small bit) and before sending them I need to understand if this one can > see the light or not. In principle, I have no issues with trying to disable some part of Xen code. I will still need to look at each one to confirm I am happy with the changes. For this case, I will have a look in a bit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:51:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:51:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576151.901974 (Exim 4.92) (envelope-from ) id 1qRUzI-0006aF-9B; Thu, 03 Aug 2023 09:51:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576151.901974; Thu, 03 Aug 2023 09:51:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUzI-0006a8-4q; Thu, 03 Aug 2023 09:51:20 +0000 Received: by outflank-mailman (input) for mailman id 576151; Thu, 03 Aug 2023 09:51:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUzG-0006Zy-UD; Thu, 03 Aug 2023 09:51:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUzG-0002Gk-PB; Thu, 03 Aug 2023 09:51:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRUzG-0003uF-D1; Thu, 03 Aug 2023 09:51:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRUzG-0000DV-Ce; Thu, 03 Aug 2023 09:51:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gpCmXiSlLSUh8/Nj/Fuz0vFIq1hRx6Q/s8yvuZZcuH0=; b=QP1cqNwLb95wFS7j3Qwd+wO9uQ hSj31h19BgmTC+odVVbo3EyX/JQVod2wFkUeal2LzTzrg9lyfi/UQCkeNfgERSPgux4W3y0vbYTzK viX136bC0jsDT2dmeKPCvnb1DZvumY3HcHOdQBKHbcLfLxcvp4jOVHBD54CA9peI1F1o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 182106: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=87eaa43b30f8ffb600f8e6f765d5c7e4bcb241b9 X-Osstest-Versions-That: xen=e05a0e65b09d8512fdf4881c7fae713045c7d83d From: osstest service owner Date: Thu, 03 Aug 2023 09:51:18 +0000 flight 182106 xen-4.15-testing real [real] flight 182162 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182106/ http://logs.test-lab.xenproject.org/osstest/logs/182162/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 182162-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182093 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182093 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182093 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182093 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182093 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182093 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182093 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182093 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182093 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182093 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182093 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182093 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: xen 87eaa43b30f8ffb600f8e6f765d5c7e4bcb241b9 baseline version: xen e05a0e65b09d8512fdf4881c7fae713045c7d83d Last test of basis 182093 2023-07-31 13:06:54 Z 2 days Testing same since 182106 2023-08-02 00:59:52 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Luca Fancellu Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e05a0e65b0..87eaa43b30 87eaa43b30f8ffb600f8e6f765d5c7e4bcb241b9 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:53:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:53:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576158.901983 (Exim 4.92) (envelope-from ) id 1qRV1Z-0007Cv-P1; Thu, 03 Aug 2023 09:53:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576158.901983; Thu, 03 Aug 2023 09:53:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRV1Z-0007Co-MP; Thu, 03 Aug 2023 09:53:41 +0000 Received: by outflank-mailman (input) for mailman id 576158; Thu, 03 Aug 2023 09:53:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRV1Z-0007Cg-2U for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:53:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1b::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e8d1b21-31e3-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 11:53:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9186.eurprd04.prod.outlook.com (2603:10a6:102:232::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:53:35 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:53:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e8d1b21-31e3-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eSd1e+66fk1F1OlY4/VSUquaXhxZlLxsF7WoPt7mL92evXOej89xpfJMZFd2EV0BEhAeKj9TwdgpXo4UmpEdkJeCsBET/x7Kn3MPNuCnS8cj9I257/WFOFW6ZJzjiN3Z9qX9L++YGoYIMc8w8c1HXSptPhHPKAEXtk1taKzSQnVEpZlipJD/ILAGdrqhQvlcCHxbpCcOf8WZORnlTHv1Cb23XrsOOmTwZBxHaD/F6qVf25EivTKcteOkrfIWV1kjlEtlTHcynCHDqWp+EViBI9WcPNsOjoCCRXeucK7Jy1jJYfTJvO9FVrj9wUiZiYghRjSsTgi1Mhp6ioDEZArxCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J+/SplQubp7bsJRDx2BCsiBz6B8hWfpy15gr46xSccY=; b=Q8I/NAWWqhuPDDaWkjwJootpzgwSUyiNUHKkKLndjePsdqHqzLf4HOG3yMNE6maySWKroqIi9D45dfMh4VwrARW1GikmiTIYJrjPtHf/Y67r1hOyWWiC3Kxn3R5rEqvVFa6405Yn8WIuQD2zQn5kuhjYIe7Un7FUM4i9HVW5nUD+LeMsoFQBTyJYSkRMB/fN/a9ygUHec/py2TrsFz0Xj6SQ6Nz9Ycr7+LrN0Ruia498Hmw4Sz29T0s99KppPFhnYytEA9azTiBUch7dmz60ktvrKr6kbogAxAnunWDdJ6SqFSE6c8VNbYjBYr54kOyLDFUNi2Nv0ButOuajH8iv7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+/SplQubp7bsJRDx2BCsiBz6B8hWfpy15gr46xSccY=; b=WTQ2KZ4MlLpmRkeK6CqzdA3dN/o1I6sDzLfb/bLcCcUtVyb78C1aS1IE1cC6Su3OTxmKS855PNk+wCNJjtHCPpHpn0jOAvs9/makgUgnUkxcA0QG126qbDYXKOug9rHgDDxh40x6ZQFieK3gQVqfh4WuKz9YyK8NyBEpfLFcaCrKSGJxe1Gq2wC1TLMT21LlkYclkzLatGAKkbVx2EM/wtiod6WqDm6EoAdq52NhwULSMHPh66RmMJexChWlX/fk+sGezg1tIeFvJX0uOuho+J35A7ec+buRUe720siyD+icN17xaB9iqhSj9l3QFzDd/7dRsUwf9GTVS/IXmPwJ4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 11:53:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v3 2/2] tools/xenstore: fix get_spec_node() Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Julien Grall , Anthony PERARD , Julien Grall , xen-devel@lists.xenproject.org References: <20230724103324.4207-1-jgross@suse.com> <20230724103324.4207-3-jgross@suse.com> <5aaf37aa-cb7d-59e5-5e0b-40fa73177d35@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9186:EE_ X-MS-Office365-Filtering-Correlation-Id: 28dbda1e-38b0-47e7-66e6-08db94078112 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ToyvH2mByXmhCr1MpkrTPGYTPRjdip2m7IHbEmz9joovJA05hNymGcDRVVrCujJN1H2kbk7oT23JnsQ4oY3Jvy0M9oRedvR5ow29RTYl+5O9/yN9G5mbk8SbMqUCClZ9L/LslJ3+E6/Nq+24OUyWy8+UmZzUn6XKnm9bl0ADWEzhyMDqaeMtYTx00Mq94Qc3AZuq+rOep1Bh6gMjB1U1PLV6KMtYRiYGZybE+ZyISkhT2FvWh+Av8f+Ni1BurxKLdJrhIzEV0bF8VG+mIcNmbxEMqO7+yDfe2RGo10NqMoUylvzjn+fpgvl533bRC8Qa4+ljkIWBWD8HEmfOzpZKqwyIhwVIAj3kRjN8WMheIExCuO3BwiO70Xwxurzdw/gtqk06/UuTxr7q1ZYz/+oTlOi29MQONYRb42JH2dFncTXPWEn8SZ6cGVnc0ltauAmGVEWzAUNvdakd5oOhGfTpMQstFi7gl/rgtvvbfPGCmOgyMlpLLfn4Tc5Ryv3i7tfetyXAV339l9JNn9ZPY+B//paBGqZyXCTE1F0Bhjquz3qXCAszZyVJKEynT8DxBV0IlTV+kgC7H+l4pxIDPrt9p7mlXaDbIjgXL/artarUEASSoyCphy1oEbRpdRGN+b1HiNgEaasg3ZpMm4ZMXZdujA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(41300700001)(66556008)(316002)(2906002)(4326008)(66946007)(6636002)(66476007)(6862004)(8936002)(8676002)(5660300002)(38100700002)(26005)(36756003)(53546011)(186003)(6506007)(86362001)(83380400001)(2616005)(31696002)(6512007)(478600001)(54906003)(6486002)(37006003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVBYZmZjTTQ4clBUdjg3RjdFNFNUWVNiNlNpaEh6YUxrakVWNkQxNzRjbm83?= =?utf-8?B?ZDdBTVg5eG5NSldYcTVlOUtZTG95K3ZpT1ZsM2E4Y1ZUUWVNVWI0L2FwTXhG?= =?utf-8?B?RXkvTjlZemNFcXRRVThHak1MeDVaWmM2VG96ZnMyZGV2cHM1RTFaTWVQY2py?= =?utf-8?B?VkxjakdkNHVPL095NUkya0sxQXR6d2dPMDVDVThwd3JPTmVHSDdGcmRjNW5H?= =?utf-8?B?eHNSczJpYiszMWVkb0NQSWl0UFNnajNrZmJ5UDI1eXFuckRvbW5LeDNwY0Mz?= =?utf-8?B?dE1hME1iaGM2dUVEbnJZcXI4OUx0MWpyL1BCWGhSNGhPNUY2Q3kxNHQ1TUdX?= =?utf-8?B?YkZMaVF3OS83WWVYS3pFRXdsZUJkRlBCMW9pdnNXNjVhcW9BL3V1b0VCcTI1?= =?utf-8?B?dGM1TnIveDQ2amwvTW1uNTA5VWNFbDJXWkFsdmFZM1lzU0J1b1lRVms5QzlC?= =?utf-8?B?MVlKN0plYmJqTUo1N1JweDBsRGxZbXh6VmcxZmpBSkxVanY5WkdocFgrUjdQ?= =?utf-8?B?T2xnbTdvSHFFNTdUeCtOajQyZDBkaFZlZzZua3RkaFBTd0VsaHJoZ0ZlRGVz?= =?utf-8?B?QW5IOE5DVGcybkNlOGNLVldOb0xaY2RXUHIvYTdrTG9pcTB0T0pvUFhTL0kx?= =?utf-8?B?UWdhR0lSdW9HMzc1a3dRSkxQOXQvaXhPSUg2UzlWMXJkalgvb0hUUGVxVW9U?= =?utf-8?B?VCtubGdPY2tteHpCOVM0ZlNOQ3NzWExuQkg0Ry9GNjNhMEZkWG80eWZXelhr?= =?utf-8?B?NkxFYzBuOHhLYWNuK0w4NURyTmFuRWlUQmtXaGJjTnZ5SXNaWDQzdzRuNkdR?= =?utf-8?B?SWZhLytXWS9GaE9XZFF2ckdQemJWZE8vRFRsanE1UW5HMHJGQTM2R1oyVXZO?= =?utf-8?B?aTNrMkpVVVFWVytJcjdrUjcrc3NGT01FZWE3NlZONloxQUpYWlRqdktRVWN6?= =?utf-8?B?eUFtZDc3RUxHc21pTHFFMDc1L1ozYTBUYm5UaEUzQ0Myd2JIVi8rSVNEVnVt?= =?utf-8?B?ekt5QUl1MXlFQ01qNW9kQTdVbmlyR0hJS3V1d1k3K1hacGlodmJNZkU2RWJN?= =?utf-8?B?VFdTRXd1VHR2d0VaV1hzMEErYU9MT3FNaDdCSFc5K2ZDbXIzbzV2WjNDbG1P?= =?utf-8?B?TE5yVDkydGUrU0NERnBTM0hRWUJoSlZlT0I3M0lUWk5wUnJSS3Z5Z3dQNjZo?= =?utf-8?B?dkJBTlpNZ3VLMUo4UGlnZGdtREY3c2hteGw1MzRoN3VCM2FucVIyaVhJV0lG?= =?utf-8?B?V1JjRDUvVXN0NC9XR0N6RkQrSy8ySk4veXIwNkVQRGg1dFp3ejNUY3kyaWpl?= =?utf-8?B?ZXZIaTI3QXpoMWhNUXZIU1c5NzBXeHRDTWJLWnZ4ZHMwL2w0VERUTW5YUzlM?= =?utf-8?B?NlJBSVZjMXRRaGRwOVRQNEFXbTI1b2tGUGJ6M0FUR1NXbGhMVmkvZktHSEVl?= =?utf-8?B?czYzdG1lS3hUUExwcno5V0JqR2FBQ0pySEtsMlo4T1FRSXl1UlVGKzFMOGcw?= =?utf-8?B?YVZDb25IUkNpcmQxdDRvdjJ2NWV4emVGY3JGMndoSXVGQzJraEJwckdnODZO?= =?utf-8?B?MzFRK0lLd2xTLzJMYkpIOUZOZTJIOHFaV3k5WjE5SERtUG02N1Q0WisrbStT?= =?utf-8?B?TU5hS3Q4dmVSVStualByczAvRlgvZnZRNnJCL0c4RmY2OHBEZDV5L2YwSGdO?= =?utf-8?B?UWhsVEJEcU4xVjMxdVNtNUIzVUo1amgvdW80QS82djFrcmFMKzNTcGhTWjl3?= =?utf-8?B?bXJucU95YU1HMmR5STJDQ0tjdVhQYlVSRXVxZC9qMWdibDFPaDdlWTlGNzJp?= =?utf-8?B?WUxEc1hkVjVUUzNrNDVGUHhlT2FBTHdOb2hOOXIwS09sK2J2OGhWR2lqZytX?= =?utf-8?B?QVVwbkhsRysyWjVrK2RFdDZySjBwVFNiTlcxMkJEbmZaTjJlSVZQM2I0OVl0?= =?utf-8?B?eHRydzIvSVp1QndVcm45SC9pZXVWSldjVE5yNlZBeExrNVNyNGliQ1FUVkJh?= =?utf-8?B?bGV5cWo5ZWJjOExvOTF5eUFGaXdHbVFLVnYxMUhnYWNURmZCNktmOXdSOEJv?= =?utf-8?B?NTBaZlBoT1NtMFhqWGthY1FEMm94WkMrUloyMW84NHlxaHZ4RGgyUm1zcy9v?= =?utf-8?Q?qI0dtS7DNgiE/Dxe4mOn4whIa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28dbda1e-38b0-47e7-66e6-08db94078112 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:53:35.6668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VraN7nLlohslcpP9n7hbAA2AFnMG75gplVpZItuQlxk9mhNQIdAYNCTy/R+GEW5nIov+6Qc22ukYPxXnwF5Atw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9186 On 27.07.2023 09:55, Juergen Gross wrote: > On 27.07.23 09:53, Jan Beulich wrote: >> On 24.07.2023 12:33, Juergen Gross wrote: >>> In case get_spec_node() is being called for a special node starting >>> with '@' it won't set *canonical_name. This can result in a crash of >>> xenstored due to dereferencing the uninitialized name in >>> fire_watches(). >>> >>> This is no security issue as it requires either a privileged caller or >>> ownership of the special node in question by an unprivileged caller >>> (which is questionable, as this would make the owner privileged in some >>> way). >>> >>> Fixes: d6bb63924fc2 ("tools/xenstore: introduce dummy nodes for special watch paths") >>> Signed-off-by: Juergen Gross >>> Reviewed-by: Julien Grall >> >> I've committed the two patches, and I've queued this one for backporting. > > Thanks. > >> Can at least one of you please confirm that the earlier patch is not >> intended to be backported, and that instead a cast will need adding in >> the backport of the one here? > > Yes, that was the plan. Hmm, looks like the offending patch exists only on the master branch. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 09:58:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 09:58:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576164.901998 (Exim 4.92) (envelope-from ) id 1qRV65-0007t0-DM; Thu, 03 Aug 2023 09:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576164.901998; Thu, 03 Aug 2023 09:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRV65-0007st-Ad; Thu, 03 Aug 2023 09:58:21 +0000 Received: by outflank-mailman (input) for mailman id 576164; Thu, 03 Aug 2023 09:58:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRV64-0007sn-AH for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 09:58:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRV64-0002O8-11; Thu, 03 Aug 2023 09:58:20 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRV63-0005mA-RY; Thu, 03 Aug 2023 09:58:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vXXwLeKSesqW6P0my9eiMh/3Mour9Agu9cMHmw+/bag=; b=tDs27RUoq2EUCDFlW61kovnrf4 SR3j64V3PtXa4DW23CdIIcJNPcdTa8JsaQ7SkWOnvxt4inXOZUrE3n6y+Dn49CwMOTooER5F4W3Wg pa6qyaoG4cQnGkSK+egfm9JjLUBehIkrRZxGHs+Y64uMSx294h9msiJ99YzBXIBMyDNk=; Message-ID: <9320a2b7-18cd-2766-b115-300755d64932@xen.org> Date: Thu, 3 Aug 2023 10:58:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230802135350.745251-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 02/08/2023 14:53, Luca Fancellu wrote: > Introduce Kconfig GICV2 to be able to compile the GICv2 driver only > when needed, the option is active by default. > > Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles > the GICv2 emulation for guests, it is required only when using GICV2 > driver, otherwise using GICV3 it is optional and can be deselected > if the user doesn't want to offer the vGICv2 interface to guests or > maybe its GICv3 hardware can't offer the GICv2 compatible mode. > > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/Kconfig | 13 +++++++++++++ > xen/arch/arm/Makefile | 4 ++-- > xen/arch/arm/domain_build.c | 4 ++++ > xen/arch/arm/gic-v3.c | 4 ++++ > xen/arch/arm/vgic.c | 2 ++ > 5 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index fd57a82dd284..dc702f08ace7 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -78,6 +78,14 @@ config ARM_EFI > UEFI firmware. A UEFI stub is provided to allow Xen to > be booted as an EFI application. > > +config GICV2 > + bool "GICv2 driver" > + default y > + select VGICV2 > + help > + Driver for the ARM Generic Interrupt Controller v2. > + If unsure, say Y > + > config GICV3 > bool "GICv3 driver" > depends on !NEW_VGIC > @@ -92,6 +100,11 @@ config HAS_ITS > bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED > depends on GICV3 && !NEW_VGIC && !ARM_32 > > +config VGICV2 > + bool "vGICv2 interface for guests" This description is a bit misleading as the vGICv2 will also be used for dom0 in the case of vGICv2. > + default y Please add a longer help. > + depends on (GICV2 || GICV3) && !NEW_VGIC In the near future, I don't expect anyone to introduce a new non-GIC of interrupt controller for Arm. But I would expect new version of the GIC. So I would drop (GICV2 || GICV3). Also when !NEW_VGIC is selected, this will make VGICV2 will be unselected. I was actually expecting the other way around given that new vGIC only offer v2 support. The rest of the changes LGTM. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:15:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:15:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576168.902007 (Exim 4.92) (envelope-from ) id 1qRVMm-0002MJ-NT; Thu, 03 Aug 2023 10:15:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576168.902007; Thu, 03 Aug 2023 10:15:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVMm-0002MB-Kd; Thu, 03 Aug 2023 10:15:36 +0000 Received: by outflank-mailman (input) for mailman id 576168; Thu, 03 Aug 2023 10:15:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVMk-0002Lc-Rx for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:15:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20616.outbound.protection.outlook.com [2a01:111:f400:7d00::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae2cdd08-31e6-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:15:33 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB6963.eurprd04.prod.outlook.com (2603:10a6:208:18b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 10:15:30 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 10:15:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae2cdd08-31e6-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CTogRfIfphU3kX4C/e9M9lGRbYO5GK1D1pIKjtN6ukE+um8z+x7uVCkcdxmt4PvDvp0Rj8xQCQECV2DRlnRiek0AGE+tNMLjTIi7Bdmt8JSciGPEKcY6lyQlmHf9CRk4HA2r5BtF5kn1356E+LiJ21LryQ18d+qRRTRaSnBqYbv+pUAxSTbFFTLVgs5zA9K8Sub9NAZ+8lc8PXHHzFw7V8SdnMUXSV0if6yOP64IaPitaXiG49frMKGvYKzKFDa+uAyo+PLTALJOdVzrDsmYuzClVXyhi2SFuVIrnLQQ7yVCooPDRoy1xnHRuaDakpDDsnO/22KHwRWZqE8flt/hLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4q9BXtk8s2rkrLIMpuk5869VQ4BI6xtPmbxxCg4i8TM=; b=A6hzeFZ24dvzHOrjMhllm1aBAeJwp2nAIFWIrQCtY0lH2JEshoqLwkBEZ9SWESS9jfi+wlXREoJaJd8lJejZcWLM2L46j9SDen297Mbkytk5/MyORL8oYOWh60DPtmjBeNUsqEsqdiPhmGJRLIPuTZumfz07PL/WxolqCJhs/yOpk2naIlMiXZ0WEyU9J+xAIJH5/opEEWz6RpQlKeWd1XnnkXFZS6eph33wmDR9GIjwciaC2eMmWqrHm2+pxnSLGbYZAXvTkhPx5QAhO2uFCYwLk8Ks85SnhHts7EYivLpzds8QO93WdSUsluR40qGcdV9ffoVCPVce4wLt0tm+ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4q9BXtk8s2rkrLIMpuk5869VQ4BI6xtPmbxxCg4i8TM=; b=aoH7nemT3VpTcDlC2gj6Yjp5Rrn+eIpqQRDlb1UyhJKckVAeuDqfJVUdxOY0UWh0RPcN1Y33BmYWjGq+TAC9SudQNcBCgAtvY8V/TElrepusJettbRv4XRXCTH321Zjqo06armxRu8pBXfs+AtHJ+F2Zmg4eBJIBb/DtLbs1AQd+TknSCMKYgEJDmlYtrFuFuyHuaejHBBbRVVhKq5mOTNSHPpqjTWGIYzL3kcBPefaAFtAJUfxn4i7PwZIShwdlVM3D3cO9l+p0SxL12yEb7m1nMVY1rulX9xviXZnGESyAmMFtXPoqD+0nF3j5L8O4WkoDMwU2J71w71hUBytU4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <99d89bce-42ff-f6e5-090b-3b9f8e130e66@suse.com> Date: Thu, 3 Aug 2023 12:15:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] xenctrl_stubs.c: fix NULL dereference Content-Language: en-US To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <3b6374c44ae7e4afce427a9ea852d8d1ebbb42b3.1689236671.git.edwin.torok@cloud.com> From: Jan Beulich In-Reply-To: <3b6374c44ae7e4afce427a9ea852d8d1ebbb42b3.1689236671.git.edwin.torok@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0201.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB6963:EE_ X-MS-Office365-Filtering-Correlation-Id: ca2bba31-ec35-4998-0f44-08db940a8fdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G1fBwV7dz4aUa47nCE1sqbgd0LtDS4opDKtQm6uwGiNNlacTrDcHQvpGUe6ZOfbzvaQz3aGDCR4XK3hSeqx/Y4/EdgYhD0xaYc0qT/xU16Mj3atzSpqDPtAuJAxZOLQJV1mJQKJfra7APRcR1OOJAUt4o+TETi5Z+lFPrkTymM+yQVLQuRHhMIkFiJvHOABdN589qDB/wBtBSzLsxMXs9SW3O5YvXV9GWHmE2e7ZLsP8l/D0nu0dUyXqIAFeS+girKZ5pRHFZ45D6MCTz4AcwobsIf3ipvH9LluYuE8Zrt7AftxmUzm6RtymE7clEjoddBBRQ1t0yRXpO1PP5Ag1I2JRlvKvAgREC0dST9t/iQb26BcXY7OXY0jY1oY3wchb/8hCZesXtZqW3SeyGDlVuaQgxBjN/oqvNS9L3WcyGQMdJd5ZlXZpDGdnp2WJVQwtGvQnUsh+dw6CBnA+VrOfy7IiKJDAdmr0nQ647IjqvaIBoNo1MRUFwjj19kQSJjmzwDCqaIR6vPCZX5AzGov6qElgvYywIT6sLy424xF4uCcTXqV+v2J8Eg8winGrhlhP5kGn8zlvh/HDm7i1JhHQ2V0st1/kZtGU7cigtjqXw8J1y0aPd8HGf1nPNgZDH2MzVCo3pCfgaPVPxWSIo0q/OQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(4744005)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(41300700001)(8676002)(8936002)(6486002)(6666004)(6512007)(54906003)(478600001)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjdYc1lxS2I2dktHRm5pbTJrUXhwcmR2QlJnZTJTb0YzOHZBZ0FzdUVqdytQ?= =?utf-8?B?OUhhS3pRUHZDVFNZbUFJZHF1cWwzOHNaQnJwZWVKemxzWEhEVHlzL1d3Z090?= =?utf-8?B?WU1vVE1tWTdOcmFSUFZsa0ZudE5EN1VEYmJNOUVkWDlwTUJtV3E5dmVObENz?= =?utf-8?B?VllKRjNrT2hySUtZSjdPOTJLYXFTRzZnYUQ3cWhRV1FoMjgxbmpiUWRJbjNl?= =?utf-8?B?UXIzUkFPclJubmdac3ZlTUhDMUdoam1jbjhmS21UdnpCSDc1ZzFkOTkxMTB1?= =?utf-8?B?dVppZ0cwb2d1bm1Qbk1SbTRNbEVkT2VRRVAzZ0RXQlFlZ2pzTzhpNXpFZVJh?= =?utf-8?B?RG8rSUxLT0c2akpodXJBOFFhQnlWUkVHcjRhcnNlbUErM0pzM1ZqM3NlOGpj?= =?utf-8?B?MVlIK3FMYXlJUHRTNDdDRndzT0RFUmgvMHRQZU9ONWU5dUNBYjZuVGFYVnVr?= =?utf-8?B?Z1JqY05BdUhidTJublpqUisxNHNWVldiTVM0NTEwMmcrTlJEM0hjclpDQ1JE?= =?utf-8?B?Z2Q4U3A1aFhiZU9scVpvT0tnbmhmNnZzWGNEK2o5UHBjb25CUjBhRUlxRlBW?= =?utf-8?B?VndST3BqWlJaMi9RNkZ1Tzg3N1R4TVFVVEZWNmVlTnVlOWNhRlgzSGpyL3A5?= =?utf-8?B?M2ptc2hScnpicW9GcVBleGVQUjQ4Q282akxmSHl1M0JLUG9HUmRhajBzWlhL?= =?utf-8?B?R0dvL21OaXVxTVM3cnY4eW11VWFJck1sY3FIeFdzTGdpRFRMOExxRE1IY3hk?= =?utf-8?B?ODZsdEVTaVFrZmYzY1p6VDdoY2VzSG5VRnBwcW9GWXM4Ty9wNEg0cFJwaXY5?= =?utf-8?B?Z3ovMVZyRmRESEkwVllVMnFFcUpDMFl5dE1MSjg5TDZjQ3lsRHpMM1VGd2xo?= =?utf-8?B?eVY4b3czNnhYMGpsb1dQOFVEeGFPN3loS3pDeXZVamJtSS9XeG1Wd3ZEU3NN?= =?utf-8?B?dmxLVVRsQnl2QU54UU5vTCtneTA4U1dFSmRlVkNiM2tWaUplOERHOENOWU1t?= =?utf-8?B?dVdYSExsdllrZTVwOEFxV3VjbmtrazFWMjJ0azJDOGRPUzFPcitiWDhmTUxy?= =?utf-8?B?ekdySG1FNlRMU3lpOFJpL1BYTk5FeTB0TEJLUUh2R2tFVHlzVXVtVGFSVitB?= =?utf-8?B?N3hlWE9aUDZVMFIxTi9BSzVuaHBQMnVsM242bHErMDRuMEIwWHN6SnVhekEv?= =?utf-8?B?UHVsTUVxN3B5b3pDUkFkaEdhMHRaclNTSHdhYkp4cFRWL1FKL1d3ZzRXdFJv?= =?utf-8?B?dk9vYnhuSlozNEEycmV1WXhSL2IyVEZOeHNIS3ZHaHNsVEJJWVRCWElWRE93?= =?utf-8?B?L21UNlA5YmZoSHA5ZzQ2a3FkMkc2TGVVWmUvRW50NC9pbFRXRDFqWDdBNk5O?= =?utf-8?B?YkhXbHVMRVJGTCtocUhrT21adXFUc0MvcFVHMWtZcXBFNlJlMk1ZYVJVMERO?= =?utf-8?B?L2Q0UGl0djRPaGptZ0FIVTNLVWxGNWNyODdoZkdjM0hZUThlMFgzbmlLbjIw?= =?utf-8?B?VjdzRDU0U0tuQ1RNaG54NUErbGhaM0NNNjJra1lQdjZNRGMzNlZEbTZiQ0xv?= =?utf-8?B?L2RVVUgvU0VhR0p6RWdKYko0SDdCeXdXMGxrdHNMeXhCT1BKL1FXaHZnMlN3?= =?utf-8?B?UFpHdU9uNllxTmtZRmx0K202Mk9XMlgweU13aXhvbFowZTZlQWNFSXY5L2cw?= =?utf-8?B?VjZQVmRqQklVZ2RlcE44eEZRcVhHRlM4bzJ3MXVVS2VoQW41RHRycUxORlJ3?= =?utf-8?B?bDNyRDlnRldrcEJ4NGhUZ2xwY0t1VGpyOGZGOEZuempYVVNsa1VKbE81ak5T?= =?utf-8?B?NGJBZmxhUUp6aERWd21KUzQyeVJNWDhCckpVdDcxczlid2FTRWRxZjJpZ0xy?= =?utf-8?B?dityc1owTDBnMWtlTlJ2Z1pPcE5KUm1UaW1zQVRKbyswTm1uOFVTaVNkVU5u?= =?utf-8?B?ajNhd1RZVVZmTUZ5MXBIejN6eVpySFE2K29rQjg3K201N2h2S2xYV1pxVWR4?= =?utf-8?B?dExXNXpsV0k5dlJwcDIwZEI1Y0lSU1kzS1YrTFo2c0Fzb1UyMjl2MEpvbFpk?= =?utf-8?B?TTE3Q0NqY1pDMWFKQkdVdjRIcVV3SXZmNWFqb3llSE83OTRYQ2ZIUC9UWFZX?= =?utf-8?Q?LYJ+TXgkVR8I8cb3JdDRauRkh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca2bba31-ec35-4998-0f44-08db940a8fdb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 10:15:29.1281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0jOKw8wB7vWje8o9wArXA4Fy+67Qrmq/8WA5ddQ+tZhatEHXA2LwGZQ26e3IjRDAR6u5/xPxeIzOaZ3bqy/WhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6963 On 13.07.2023 10:30, Edwin Török wrote: > --- a/tools/ocaml/libs/xc/xenctrl_stubs.c > +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c > @@ -832,7 +832,7 @@ CAMLprim value physinfo_arch_caps(const xc_physinfo_t *info) > > tag = 1; /* tag x86 */ > > - arch_obj = Tag_cons; > + arch_obj = Val_emptylist; > > #endif > Since, aiui, this also affects 4.17, but the patch as is doesn't apply there, could you please provide a suitable backport of what went onto the master branch? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:21:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:21:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576172.902018 (Exim 4.92) (envelope-from ) id 1qRVSe-0003rK-Dh; Thu, 03 Aug 2023 10:21:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576172.902018; Thu, 03 Aug 2023 10:21:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVSe-0003rD-9f; Thu, 03 Aug 2023 10:21:40 +0000 Received: by outflank-mailman (input) for mailman id 576172; Thu, 03 Aug 2023 10:21:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVSd-0003r5-48 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:21:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 874996f1-31e7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:21:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 05703219AD; Thu, 3 Aug 2023 10:21:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C6ACF134B0; Thu, 3 Aug 2023 10:21:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mnITL7B/y2QEEAAAMHmgww (envelope-from ); Thu, 03 Aug 2023 10:21:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 874996f1-31e7-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691058097; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TWXN2ElWv8BEV6Ycc9EHkQ5nJH5s0YKDnJHm35J5odc=; b=Xpd292P6wH1JGfGsDH9pIqEALlHISNQPJ7n59HFk/x3ZnbvFYSuIVKsRofyJF43wqC21RB LnWQQOPMyBN+wvsPIGmKjEUOCwFnas8RWmqfIOU1QAH97oHc24Jltcsh9icMtLAuO6ADM8 GE8vgKt4mYvLC92RbpXgGEpNEI9BUrU= Message-ID: <2bd36102-0373-dcf4-552f-5b4bed67d595@suse.com> Date: Thu, 3 Aug 2023 12:21:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/2] tools/xenstore: fix get_spec_node() Content-Language: en-US To: Jan Beulich Cc: Wei Liu , Julien Grall , Anthony PERARD , Julien Grall , xen-devel@lists.xenproject.org References: <20230724103324.4207-1-jgross@suse.com> <20230724103324.4207-3-jgross@suse.com> <5aaf37aa-cb7d-59e5-5e0b-40fa73177d35@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RYAYTMBsjGHju0T6r5kKyxqG" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RYAYTMBsjGHju0T6r5kKyxqG Content-Type: multipart/mixed; boundary="------------vEj2nenpQEgjPku105qIaLnc"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Wei Liu , Julien Grall , Anthony PERARD , Julien Grall , xen-devel@lists.xenproject.org Message-ID: <2bd36102-0373-dcf4-552f-5b4bed67d595@suse.com> Subject: Re: [PATCH v3 2/2] tools/xenstore: fix get_spec_node() References: <20230724103324.4207-1-jgross@suse.com> <20230724103324.4207-3-jgross@suse.com> <5aaf37aa-cb7d-59e5-5e0b-40fa73177d35@suse.com> In-Reply-To: --------------vEj2nenpQEgjPku105qIaLnc Content-Type: multipart/mixed; boundary="------------8noQYMSZeSBgEQGpPe9oSvND" --------------8noQYMSZeSBgEQGpPe9oSvND Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjMgMTE6NTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNy4wNy4yMDIz IDA5OjU1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMjcuMDcuMjMgMDk6NTMsIEph biBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDI0LjA3LjIwMjMgMTI6MzMsIEp1ZXJnZW4gR3Jv c3Mgd3JvdGU6DQo+Pj4+IEluIGNhc2UgZ2V0X3NwZWNfbm9kZSgpIGlzIGJlaW5nIGNhbGxl ZCBmb3IgYSBzcGVjaWFsIG5vZGUgc3RhcnRpbmcNCj4+Pj4gd2l0aCAnQCcgaXQgd29uJ3Qg c2V0ICpjYW5vbmljYWxfbmFtZS4gVGhpcyBjYW4gcmVzdWx0IGluIGEgY3Jhc2ggb2YNCj4+ Pj4geGVuc3RvcmVkIGR1ZSB0byBkZXJlZmVyZW5jaW5nIHRoZSB1bmluaXRpYWxpemVkIG5h bWUgaW4NCj4+Pj4gZmlyZV93YXRjaGVzKCkuDQo+Pj4+DQo+Pj4+IFRoaXMgaXMgbm8gc2Vj dXJpdHkgaXNzdWUgYXMgaXQgcmVxdWlyZXMgZWl0aGVyIGEgcHJpdmlsZWdlZCBjYWxsZXIg b3INCj4+Pj4gb3duZXJzaGlwIG9mIHRoZSBzcGVjaWFsIG5vZGUgaW4gcXVlc3Rpb24gYnkg YW4gdW5wcml2aWxlZ2VkIGNhbGxlcg0KPj4+PiAod2hpY2ggaXMgcXVlc3Rpb25hYmxlLCBh cyB0aGlzIHdvdWxkIG1ha2UgdGhlIG93bmVyIHByaXZpbGVnZWQgaW4gc29tZQ0KPj4+PiB3 YXkpLg0KPj4+Pg0KPj4+PiBGaXhlczogZDZiYjYzOTI0ZmMyICgidG9vbHMveGVuc3RvcmU6 IGludHJvZHVjZSBkdW1teSBub2RlcyBmb3Igc3BlY2lhbCB3YXRjaCBwYXRocyIpDQo+Pj4+ IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+Pj4g UmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+Pj4NCj4+ PiBJJ3ZlIGNvbW1pdHRlZCB0aGUgdHdvIHBhdGNoZXMsIGFuZCBJJ3ZlIHF1ZXVlZCB0aGlz IG9uZSBmb3IgYmFja3BvcnRpbmcuDQo+Pg0KPj4gVGhhbmtzLg0KPj4NCj4+PiBDYW4gYXQg bGVhc3Qgb25lIG9mIHlvdSBwbGVhc2UgY29uZmlybSB0aGF0IHRoZSBlYXJsaWVyIHBhdGNo IGlzIG5vdA0KPj4+IGludGVuZGVkIHRvIGJlIGJhY2twb3J0ZWQsIGFuZCB0aGF0IGluc3Rl YWQgYSBjYXN0IHdpbGwgbmVlZCBhZGRpbmcgaW4NCj4+PiB0aGUgYmFja3BvcnQgb2YgdGhl IG9uZSBoZXJlPw0KPj4NCj4+IFllcywgdGhhdCB3YXMgdGhlIHBsYW4uDQo+IA0KPiBIbW0s IGxvb2tzIGxpa2UgdGhlIG9mZmVuZGluZyBwYXRjaCBleGlzdHMgb25seSBvbiB0aGUgbWFz dGVyIGJyYW5jaC4NCg0KT2gsIGluZGVlZC4gSXQgc2VlbWVkIHRvIGJlIHNvIGxvbmcgYWdv IHRoYXQgSSBjaGFuZ2VkIHRoaXMgLi4uDQoNCg0KSnVlcmdlbg0K --------------8noQYMSZeSBgEQGpPe9oSvND Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8noQYMSZeSBgEQGpPe9oSvND-- --------------vEj2nenpQEgjPku105qIaLnc-- --------------RYAYTMBsjGHju0T6r5kKyxqG Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTLf7AFAwAAAAAACgkQsN6d1ii/Ey+y /wf/Vi+zGDyf8XONEfpwO5juD9g6AHJFjbE4Ts6T/FWYq0lYwVuCyYtOAjQKdXhMvN5K9IQlPuD3 kE8eqD+ujlQS7cRGxMrgNLYBgQ1lbGpah3GoLYTedmMj+QabmmNPjr8oY/s33zK2VQgCgzbwI466 JtTGBpGzb5PAvKUWXWfKIh5heQa1LEYfVxDjkUtFXojgB3jdtU1f8TzF1TjSjmd2Ooq7OHUPNff5 zmIZZpLp6U5bjm5+2SFMzl1Y8054IlmB5yRkv2IBxlQBQ1F8t+QAd2ghQPJYTRU+D0lWpB28zBsx UGmIv1dxMs5Fmku06X29PTNGorQqqxOo0ZZSAATy0A== =9g84 -----END PGP SIGNATURE----- --------------RYAYTMBsjGHju0T6r5kKyxqG-- From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576176.902027 (Exim 4.92) (envelope-from ) id 1qRVTz-0004S5-Ra; Thu, 03 Aug 2023 10:23:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576176.902027; Thu, 03 Aug 2023 10:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVTz-0004Ry-Os; Thu, 03 Aug 2023 10:23:03 +0000 Received: by outflank-mailman (input) for mailman id 576176; Thu, 03 Aug 2023 10:23:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVTy-0004Rp-Du for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:02 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9381d91-31e7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:23:01 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 97D464EE0737; Thu, 3 Aug 2023 12:22:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9381d91-31e7-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Paul Durrant , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , George Dunlap Subject: [XEN PATCH 00/13] xen: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:15 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series aims to address some violations ofMISRA C:2012 Rule 7.3: "The lowercase character 'l' shall not be used in a literal suffix". This patch replaces "l" suffixes with "L", to comply with the rule. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. Gianluca Luparini (13): AMD/IOMMU: address violations of MISRA C:2012 Rule 7.3 x86/svm: address violations of MISRA C:2012 Rule 7.3 xen/arm: address violations of MISRA C:2012 Rule 7.3 x86/IOMMU: address violations of MISRA C:2012 Rule 7.3 xen/ioreq: address violations of MISRA C:2012 Rule 7.3 xen/mem_access: address violations of MISRA C:2012 Rule 7.3 xen/vpci: address violations of MISRA C:2012 Rule 7.3 xen/hvm: address violations of MISRA C:2012 Rule 7.3 x86/mm: address violations of MISRA C:2012 Rule 7.3 x86/viridian: address violations of MISRA C:2012 Rule 7.3 xen/x86: address violations of MISRA C:2012 Rule 7.3 xen/common: address violations of MISRA C:2012 Rule 7.3 xen: address violations of MISRA C:2012 Rule 7.3 xen/arch/arm/include/asm/processor.h | 6 +++--- xen/arch/arm/vtimer.c | 2 +- xen/arch/x86/cpu-policy.c | 4 ++-- xen/arch/x86/dom0_build.c | 2 +- xen/arch/x86/e820.c | 2 +- xen/arch/x86/hpet.c | 2 +- xen/arch/x86/hvm/emulate.c | 2 +- xen/arch/x86/hvm/hpet.c | 6 +++--- xen/arch/x86/hvm/hvm.c | 6 +++--- xen/arch/x86/hvm/io.c | 2 +- xen/arch/x86/hvm/stdvga.c | 2 +- xen/arch/x86/hvm/svm/svm.c | 4 ++-- xen/arch/x86/hvm/viridian/synic.c | 2 +- xen/arch/x86/hvm/viridian/time.c | 10 +++++----- xen/arch/x86/include/asm/apicdef.h | 4 ++-- xen/arch/x86/include/asm/debugreg.h | 16 ++++++++-------- xen/arch/x86/include/asm/guest_pt.h | 16 ++++++++-------- xen/arch/x86/include/asm/pv/domain.h | 2 +- xen/arch/x86/mm.c | 4 ++-- xen/arch/x86/mm/p2m-pt.c | 6 +++--- xen/arch/x86/mm/p2m.c | 20 ++++++++++---------- xen/arch/x86/mm/physmap.c | 4 ++-- xen/arch/x86/msr.c | 2 +- xen/arch/x86/nmi.c | 2 +- xen/arch/x86/psr.c | 8 ++++---- xen/arch/x86/spec_ctrl.c | 6 +++--- xen/arch/x86/x86_64/mm.c | 4 ++-- xen/arch/x86/xstate.c | 2 +- xen/common/ioreq.c | 2 +- xen/common/mem_access.c | 4 ++-- xen/common/page_alloc.c | 6 +++--- xen/common/rangeset.c | 2 +- xen/common/softirq.c | 8 ++++---- xen/common/vsprintf.c | 2 +- xen/drivers/passthrough/amd/iommu_guest.c | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 2 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/x86/iommu.c | 8 ++++---- xen/drivers/vpci/header.c | 2 +- xen/drivers/vpci/msi.c | 2 +- xen/drivers/vpci/msix.c | 10 +++++----- xen/include/xen/bitops.h | 8 ++++---- xen/include/xen/ioreq.h | 2 +- xen/include/xen/tasklet.h | 4 ++-- xen/include/xen/time.h | 4 ++-- xen/lib/x86/cpuid.c | 4 ++-- 46 files changed, 111 insertions(+), 111 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576177.902038 (Exim 4.92) (envelope-from ) id 1qRVUG-0004pY-3z; Thu, 03 Aug 2023 10:23:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576177.902038; Thu, 03 Aug 2023 10:23:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUG-0004pR-0J; Thu, 03 Aug 2023 10:23:20 +0000 Received: by outflank-mailman (input) for mailman id 576177; Thu, 03 Aug 2023 10:23:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUF-0004Rp-Cw for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:19 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3c9bffb-31e7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:23:18 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 509D94EE0737; Thu, 3 Aug 2023 12:23:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3c9bffb-31e7-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , Simone Ballarin Subject: [XEN PATCH 01/13] AMD/IOMMU: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:16 +0200 Message-Id: <2af1f76d2c002dd9f0b01eebf7af516d86bfe91e.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/drivers/passthrough/amd/iommu_guest.c | 2 +- xen/drivers/passthrough/amd/iommu_map.c | 2 +- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index 47a912126a..80d289b8bf 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -87,7 +87,7 @@ static uint64_t dte_get_gcr3_table(const struct amd_iommu_dte *dte) static void dte_set_gcr3_table(struct amd_iommu_dte *dte, uint16_t dom_id, uint64_t addr, bool gv, uint8_t glx) { -#define GCR3_MASK(hi, lo) (((1ul << ((hi) + 1)) - 1) & ~((1ul << (lo)) - 1)) +#define GCR3_MASK(hi, lo) (((1UL << ((hi) + 1)) - 1) & ~((1UL << (lo)) - 1)) /* I bit must be set when gcr3 is enabled */ dte->i = true; diff --git a/xen/drivers/passthrough/amd/iommu_map.c b/xen/drivers/passthrough/amd/iommu_map.c index 993bac6f88..daa24a4858 100644 --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -838,7 +838,7 @@ int cf_check amd_iommu_quarantine_init(struct pci_dev *pdev, bool scratch_page) { struct domain_iommu *hd = dom_iommu(dom_io); unsigned long end_gfn = - 1ul << (DEFAULT_DOMAIN_ADDRESS_WIDTH - PAGE_SHIFT); + 1UL << (DEFAULT_DOMAIN_ADDRESS_WIDTH - PAGE_SHIFT); unsigned int level = amd_iommu_get_paging_mode(end_gfn); unsigned int req_id = get_dma_requestor_id(pdev->seg, pdev->sbdf.bdf); const struct ivrs_mappings *ivrs_mappings = get_ivrs_mappings(pdev->seg); diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 94e3775506..bea70db4b7 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -368,7 +368,7 @@ static int cf_check amd_iommu_domain_init(struct domain *d) */ hd->arch.amd.paging_mode = max(amd_iommu_get_paging_mode( is_hvm_domain(d) - ? 1ul << (DEFAULT_DOMAIN_ADDRESS_WIDTH - PAGE_SHIFT) + ? 1UL << (DEFAULT_DOMAIN_ADDRESS_WIDTH - PAGE_SHIFT) : get_upper_mfn_bound() + 1), amd_iommu_min_paging_mode); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576178.902048 (Exim 4.92) (envelope-from ) id 1qRVUI-0005Ak-BZ; Thu, 03 Aug 2023 10:23:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576178.902048; Thu, 03 Aug 2023 10:23:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUI-0005Ab-7h; Thu, 03 Aug 2023 10:23:22 +0000 Received: by outflank-mailman (input) for mailman id 576178; Thu, 03 Aug 2023 10:23:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUG-0004Rp-NY for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:20 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c48b5c64-31e7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:23:20 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 7BA0A4EE0740; Thu, 3 Aug 2023 12:23:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c48b5c64-31e7-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Simone Ballarin Subject: [XEN PATCH 02/13] x86/svm: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:17 +0200 Message-Id: <2779c3b2cbe27d95274a4ab44f6b9c877e59e8bc.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/arch/x86/hvm/svm/svm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index b3845bdca7..01dd592d9b 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c @@ -1077,7 +1077,7 @@ static void svm_guest_osvw_init(struct domain *d) * Guests should see errata 400 and 415 as fixed (assuming that * HLT and IO instructions are intercepted). */ - svm->osvw.length = min(max(3ul, osvw_length), 64ul); + svm->osvw.length = min(max(3UL, osvw_length), 64UL); svm->osvw.status = osvw_status & ~6; /* @@ -1652,7 +1652,7 @@ static void svm_do_nested_pgfault(struct vcpu *v, else if ( pfec & NPT_PFEC_in_gpt ) npfec.kind = npfec_kind_in_gpt; - ret = hvm_hap_nested_page_fault(gpa, ~0ul, npfec); + ret = hvm_hap_nested_page_fault(gpa, ~0UL, npfec); if ( tb_init_done ) { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576180.902058 (Exim 4.92) (envelope-from ) id 1qRVUL-0005U1-Ki; Thu, 03 Aug 2023 10:23:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576180.902058; Thu, 03 Aug 2023 10:23:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUL-0005Tu-Gl; Thu, 03 Aug 2023 10:23:25 +0000 Received: by outflank-mailman (input) for mailman id 576180; Thu, 03 Aug 2023 10:23:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUJ-0004Rp-Ja for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c64a8d92-31e7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:23:23 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 765244EE0737; Thu, 3 Aug 2023 12:23:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c64a8d92-31e7-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Simone Ballarin Subject: [XEN PATCH 04/13] x86/IOMMU: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:19 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/drivers/passthrough/x86/iommu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/drivers/passthrough/x86/iommu.c b/xen/drivers/passthrough/x86/iommu.c index d290855959..c85549ccad 100644 --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -576,16 +576,16 @@ struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd, ASSERT((CONTIG_LEVEL_SHIFT & (contig_mask >> shift)) == CONTIG_LEVEL_SHIFT); - p[0] = (CONTIG_LEVEL_SHIFT + 0ull) << shift; + p[0] = (CONTIG_LEVEL_SHIFT + 0ULL) << shift; p[1] = 0; - p[2] = 1ull << shift; + p[2] = 1ULL << shift; p[3] = 0; for ( i = 4; i < PAGE_SIZE / sizeof(*p); i += 4 ) { - p[i + 0] = (find_first_set_bit(i) + 0ull) << shift; + p[i + 0] = (find_first_set_bit(i) + 0ULL) << shift; p[i + 1] = 0; - p[i + 2] = 1ull << shift; + p[i + 2] = 1ULL << shift; p[i + 3] = 0; } } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576181.902064 (Exim 4.92) (envelope-from ) id 1qRVUM-0005XO-1f; Thu, 03 Aug 2023 10:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576181.902064; Thu, 03 Aug 2023 10:23:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUL-0005Wh-P3; Thu, 03 Aug 2023 10:23:25 +0000 Received: by outflank-mailman (input) for mailman id 576181; Thu, 03 Aug 2023 10:23:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUJ-0005QX-Lm for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c587ec01-31e7-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:23:21 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 217904EE0741; Thu, 3 Aug 2023 12:23:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c587ec01-31e7-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Simone Ballarin Subject: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:18 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/arch/arm/include/asm/processor.h | 6 +++--- xen/arch/arm/vtimer.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 7e42ff8811..8e02410465 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -521,9 +521,9 @@ extern register_t __cpu_logical_map[]; #define CNTKCTL_EL1_EL0PTEN (1u<<9) /* Expose phys timer registers to EL0 */ /* Timer control registers */ -#define CNTx_CTL_ENABLE (1ul<<0) /* Enable timer */ -#define CNTx_CTL_MASK (1ul<<1) /* Mask IRQ */ -#define CNTx_CTL_PENDING (1ul<<2) /* IRQ pending */ +#define CNTx_CTL_ENABLE (1UL<<0) /* Enable timer */ +#define CNTx_CTL_MASK (1UL<<1) /* Mask IRQ */ +#define CNTx_CTL_PENDING (1UL<<2) /* IRQ pending */ /* Timer frequency mask */ #define CNTFRQ_MASK GENMASK(31, 0) diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c index 48f2daa907..c54360e202 100644 --- a/xen/arch/arm/vtimer.c +++ b/xen/arch/arm/vtimer.c @@ -206,7 +206,7 @@ static bool vtimer_cntp_tval(struct cpu_user_regs *regs, register_t *r, if ( read ) { - *r = (uint32_t)((v->arch.phys_timer.cval - cntpct) & 0xffffffffull); + *r = (uint32_t)((v->arch.phys_timer.cval - cntpct) & 0xffffffffULL); } else { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576182.902067 (Exim 4.92) (envelope-from ) id 1qRVUM-0005br-7u; Thu, 03 Aug 2023 10:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576182.902067; Thu, 03 Aug 2023 10:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUM-0005a4-2T; Thu, 03 Aug 2023 10:23:26 +0000 Received: by outflank-mailman (input) for mailman id 576182; Thu, 03 Aug 2023 10:23:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUL-0004Rp-0m for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:25 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c718767e-31e7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:23:24 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id E185C4EE0740; Thu, 3 Aug 2023 12:23:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c718767e-31e7-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Simone Ballarin Subject: [XEN PATCH 05/13] xen/ioreq: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:20 +0200 Message-Id: <771362e703548e55d4ccc420fa880585a5748c4f.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/common/ioreq.c | 2 +- xen/include/xen/ioreq.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/ioreq.c b/xen/common/ioreq.c index 7cb717f7a2..62b907f4c4 100644 --- a/xen/common/ioreq.c +++ b/xen/common/ioreq.c @@ -1182,7 +1182,7 @@ static int ioreq_send_buffered(struct ioreq_server *s, ioreq_t *p) * - the count field is usually used with data_is_ptr and since we don't * support data_is_ptr we do not waste space for the count field either */ - if ( (p->addr > 0xffffful) || p->data_is_ptr || (p->count != 1) ) + if ( (p->addr > 0xfffffUL) || p->data_is_ptr || (p->count != 1) ) return 0; switch ( p->size ) diff --git a/xen/include/xen/ioreq.h b/xen/include/xen/ioreq.h index a26614d331..cd399adf17 100644 --- a/xen/include/xen/ioreq.h +++ b/xen/include/xen/ioreq.h @@ -60,7 +60,7 @@ struct ioreq_server { static inline paddr_t ioreq_mmio_first_byte(const ioreq_t *p) { return unlikely(p->df) ? - p->addr - (p->count - 1ul) * p->size : + p->addr - (p->count - 1UL) * p->size : p->addr; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:23:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:23:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576183.902088 (Exim 4.92) (envelope-from ) id 1qRVUO-0006Ir-HW; Thu, 03 Aug 2023 10:23:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576183.902088; Thu, 03 Aug 2023 10:23:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUO-0006Ii-DC; Thu, 03 Aug 2023 10:23:28 +0000 Received: by outflank-mailman (input) for mailman id 576183; Thu, 03 Aug 2023 10:23:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUN-0005QX-EG for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:27 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c7fccec2-31e7-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:23:25 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 483E64EE0737; Thu, 3 Aug 2023 12:23:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7fccec2-31e7-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Simone Ballarin Subject: [XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:21 +0200 Message-Id: <7e4ff67a24206177c5a304055f395cc2983bb994.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/common/mem_access.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c index 010e6f8dbf..385950789c 100644 --- a/xen/common/mem_access.c +++ b/xen/common/mem_access.c @@ -60,7 +60,7 @@ int mem_access_memop(unsigned long cmd, case XENMEM_access_op_set_access: rc = -EINVAL; - if ( (mao.pfn != ~0ull) && + if ( (mao.pfn != ~0ULL) && (mao.nr < start_iter || ((mao.pfn + mao.nr - 1) < mao.pfn) || ((mao.pfn + mao.nr - 1) > domain_get_maximum_gpfn(d))) ) @@ -96,7 +96,7 @@ int mem_access_memop(unsigned long cmd, break; rc = -EINVAL; - if ( (mao.pfn > domain_get_maximum_gpfn(d)) && mao.pfn != ~0ull ) + if ( (mao.pfn > domain_get_maximum_gpfn(d)) && mao.pfn != ~0ULL ) break; rc = p2m_get_mem_access(d, _gfn(mao.pfn), &access, 0); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576203.902109 (Exim 4.92) (envelope-from ) id 1qRVXy-0000FG-JC; Thu, 03 Aug 2023 10:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576203.902109; Thu, 03 Aug 2023 10:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVXy-0000F9-EF; Thu, 03 Aug 2023 10:27:10 +0000 Received: by outflank-mailman (input) for mailman id 576203; Thu, 03 Aug 2023 10:27:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVXx-0008Qm-E4 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:09 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cef0546-31e8-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:27:09 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 464F84EE0740; Thu, 3 Aug 2023 12:27:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cef0546-31e8-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Simone Ballarin Subject: [XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:23 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/arch/x86/hvm/emulate.c | 2 +- xen/arch/x86/hvm/io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index 75ee98a73b..053c6b495d 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -74,7 +74,7 @@ static int cf_check null_read( const struct hvm_io_handler *io_handler, uint64_t addr, uint32_t size, uint64_t *data) { - *data = ~0ul; + *data = ~0UL; return X86EMUL_OKAY; } diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c index 53de1a967d..d75af83ad0 100644 --- a/xen/arch/x86/hvm/io.c +++ b/xen/arch/x86/hvm/io.c @@ -400,7 +400,7 @@ static int cf_check vpci_mmcfg_read( unsigned int reg; pci_sbdf_t sbdf; - *data = ~0ul; + *data = ~0UL; read_lock(&d->arch.hvm.mmcfg_lock); mmcfg = vpci_mmcfg_find(d, addr); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576202.902097 (Exim 4.92) (envelope-from ) id 1qRVXv-0008Qz-9X; Thu, 03 Aug 2023 10:27:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576202.902097; Thu, 03 Aug 2023 10:27:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVXv-0008Qs-6h; Thu, 03 Aug 2023 10:27:07 +0000 Received: by outflank-mailman (input) for mailman id 576202; Thu, 03 Aug 2023 10:27:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVXt-0008Qm-Rq for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:05 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a719cfb-31e8-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:27:04 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 4440D4EE0737; Thu, 3 Aug 2023 12:27:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a719cfb-31e8-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Simone Ballarin Subject: [XEN PATCH 07/13] xen/vpci: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:22 +0200 Message-Id: <4b97aa8203935ba6e202926add0baf8901af5ee9.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/drivers/vpci/header.c | 2 +- xen/drivers/vpci/msi.c | 2 +- xen/drivers/vpci/msix.c | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 60f7049e34..767c1ba718 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -447,7 +447,7 @@ static void cf_check bar_write( * Update the cached address, so that when memory decoding is enabled * Xen can map the BAR into the guest p2m. */ - bar->addr &= ~(0xffffffffull << (hi ? 32 : 0)); + bar->addr &= ~(0xffffffffULL << (hi ? 32 : 0)); bar->addr |= (uint64_t)val << (hi ? 32 : 0); /* Make sure Xen writes back the same value for the BAR RO bits. */ diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c index 8f2b59e61a..9090d97c9a 100644 --- a/xen/drivers/vpci/msi.c +++ b/xen/drivers/vpci/msi.c @@ -103,7 +103,7 @@ static void cf_check address_write( struct vpci_msi *msi = data; /* Clear low part. */ - msi->address &= ~0xffffffffull; + msi->address &= ~0xffffffffULL; msi->address |= val; update_msi(pdev, msi); diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 25bde77586..bc77d4825d 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -273,7 +273,7 @@ static int adjacent_read(const struct domain *d, const struct vpci_msix *msix, struct vpci *vpci = msix->pdev->vpci; unsigned int slot; - *data = ~0ul; + *data = ~0UL; if ( !adjacent_handle(msix, addr + len - 1) ) return X86EMUL_OKAY; @@ -305,13 +305,13 @@ static int adjacent_read(const struct domain *d, const struct vpci_msix *msix, */ for ( i = 0; i < len; i++ ) { - unsigned long partial = ~0ul; + unsigned long partial = ~0UL; int rc = adjacent_read(d, msix, addr + i, 1, &partial); if ( rc != X86EMUL_OKAY ) return rc; - *data &= ~(0xfful << (i * 8)); + *data &= ~(0xffUL << (i * 8)); *data |= (partial & 0xff) << (i * 8); } @@ -363,7 +363,7 @@ static int cf_check msix_read( const struct vpci_msix_entry *entry; unsigned int offset; - *data = ~0ul; + *data = ~0UL; if ( !msix ) return X86EMUL_RETRY; @@ -525,7 +525,7 @@ static int cf_check msix_write( entry->addr = data; break; } - entry->addr &= ~0xffffffffull; + entry->addr &= ~0xffffffffULL; entry->addr |= data; break; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576204.902118 (Exim 4.92) (envelope-from ) id 1qRVY6-0000bK-Pu; Thu, 03 Aug 2023 10:27:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576204.902118; Thu, 03 Aug 2023 10:27:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVY6-0000b6-MP; Thu, 03 Aug 2023 10:27:18 +0000 Received: by outflank-mailman (input) for mailman id 576204; Thu, 03 Aug 2023 10:27:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVY6-0000aV-3w for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:18 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 513cee2c-31e8-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:27:16 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 752E24EE0737; Thu, 3 Aug 2023 12:27:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 513cee2c-31e8-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Simone Ballarin Subject: [XEN PATCH 09/13] x86/mm: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:24 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/arch/x86/mm/p2m-pt.c | 6 +++--- xen/arch/x86/mm/p2m.c | 20 ++++++++++---------- xen/arch/x86/mm/physmap.c | 4 ++-- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c index 6d1bb5daad..b2b14746c1 100644 --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -552,7 +552,7 @@ static void check_entry(mfn_t mfn, p2m_type_t new, p2m_type_t old, if ( new == p2m_mmio_direct ) ASSERT(!mfn_eq(mfn, INVALID_MFN) && !rangeset_overlaps_range(mmio_ro_ranges, mfn_x(mfn), - mfn_x(mfn) + (1ul << order))); + mfn_x(mfn) + (1UL << order))); else if ( p2m_allows_invalid_mfn(new) || new == p2m_invalid || new == p2m_mmio_dm ) ASSERT(mfn_valid(mfn) || mfn_eq(mfn, INVALID_MFN)); @@ -745,9 +745,9 @@ p2m_pt_set_entry(struct p2m_domain *p2m, gfn_t gfn_, mfn_t mfn, if ( need_iommu_pt_sync(p2m->domain) && (iommu_old_flags != iommu_pte_flags || old_mfn != mfn_x(mfn)) ) rc = iommu_pte_flags - ? iommu_legacy_map(d, _dfn(gfn), mfn, 1ul << page_order, + ? iommu_legacy_map(d, _dfn(gfn), mfn, 1UL << page_order, iommu_pte_flags) - : iommu_legacy_unmap(d, _dfn(gfn), 1ul << page_order); + : iommu_legacy_unmap(d, _dfn(gfn), 1UL << page_order); /* * Free old intermediate tables if necessary. This has to be the diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index f6df35767a..0983bd71d9 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -392,7 +392,7 @@ int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn, unsigned int page_order, p2m_type_t p2mt, p2m_access_t p2ma) { bool hap = hap_enabled(p2m->domain); - unsigned long todo = 1ul << page_order; + unsigned long todo = 1UL << page_order; int set_rc, rc = 0; ASSERT(gfn_locked_by_me(p2m, gfn)); @@ -401,10 +401,10 @@ int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn, { unsigned long fn_mask = (!mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0) | gfn_x(gfn) | todo; - unsigned int order = (!(fn_mask & ((1ul << PAGE_ORDER_1G) - 1)) && + unsigned int order = (!(fn_mask & ((1UL << PAGE_ORDER_1G) - 1)) && hap && hap_has_1gb) ? PAGE_ORDER_1G - : (!(fn_mask & ((1ul << PAGE_ORDER_2M) - 1)) && + : (!(fn_mask & ((1UL << PAGE_ORDER_2M) - 1)) && (!hap || hap_has_2mb)) ? PAGE_ORDER_2M : PAGE_ORDER_4K; @@ -412,10 +412,10 @@ int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn, if ( set_rc ) rc = set_rc; - gfn = gfn_add(gfn, 1ul << order); + gfn = gfn_add(gfn, 1UL << order); if ( !mfn_eq(mfn, INVALID_MFN) ) - mfn = mfn_add(mfn, 1ul << order); - todo -= 1ul << order; + mfn = mfn_add(mfn, 1UL << order); + todo -= 1UL << order; } return rc; @@ -1407,7 +1407,7 @@ void np2m_flush_base(struct vcpu *v, unsigned long np2m_base) struct p2m_domain *p2m; unsigned int i; - np2m_base &= ~(0xfffull); + np2m_base &= ~(0xfffULL); nestedp2m_lock(d); for ( i = 0; i < MAX_NESTEDP2M; i++ ) @@ -1456,7 +1456,7 @@ p2m_get_nestedp2m_locked(struct vcpu *v) bool needs_flush = true; /* Mask out low bits; this avoids collisions with P2M_BASE_EADDR */ - np2m_base &= ~(0xfffull); + np2m_base &= ~(0xfffULL); if (nv->nv_flushp2m && nv->nv_p2m) { nv->nv_p2m = NULL; @@ -1614,8 +1614,8 @@ unsigned long paging_gva_to_gfn(struct vcpu *v, * Sanity check that l1_gfn can be used properly as a 4K mapping, even * if it mapped by a nested superpage. */ - ASSERT((l2_gfn & ((1ul << l1_page_order) - 1)) == - (l1_gfn & ((1ul << l1_page_order) - 1))); + ASSERT((l2_gfn & ((1UL << l1_page_order) - 1)) == + (l1_gfn & ((1UL << l1_page_order) - 1))); return l1_gfn; } diff --git a/xen/arch/x86/mm/physmap.c b/xen/arch/x86/mm/physmap.c index f1695e456e..098ccdf541 100644 --- a/xen/arch/x86/mm/physmap.c +++ b/xen/arch/x86/mm/physmap.c @@ -72,7 +72,7 @@ int set_identity_p2m_entry(struct domain *d, unsigned long gfn, if ( !is_iommu_enabled(d) ) return 0; return iommu_legacy_map(d, _dfn(gfn), _mfn(gfn), - 1ul << PAGE_ORDER_4K, + 1UL << PAGE_ORDER_4K, p2m_access_to_iommu_flags(p2ma)); } @@ -85,7 +85,7 @@ int clear_identity_p2m_entry(struct domain *d, unsigned long gfn) { if ( !is_iommu_enabled(d) ) return 0; - return iommu_legacy_unmap(d, _dfn(gfn), 1ul << PAGE_ORDER_4K); + return iommu_legacy_unmap(d, _dfn(gfn), 1UL << PAGE_ORDER_4K); } return p2m_remove_identity_entry(d, gfn); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576218.902128 (Exim 4.92) (envelope-from ) id 1qRVYC-00016W-1c; Thu, 03 Aug 2023 10:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576218.902128; Thu, 03 Aug 2023 10:27:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYB-00016L-V2; Thu, 03 Aug 2023 10:27:23 +0000 Received: by outflank-mailman (input) for mailman id 576218; Thu, 03 Aug 2023 10:27:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYB-0000aV-0i for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54644258-31e8-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:27:21 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id BD84F4EE0737; Thu, 3 Aug 2023 12:27:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54644258-31e8-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Simone Ballarin Subject: [XEN PATCH 10/13] x86/viridian: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:25 +0200 Message-Id: <63f0d6385f302517244604af5536ffebd74ba589.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/arch/x86/hvm/viridian/synic.c | 2 +- xen/arch/x86/hvm/viridian/time.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c index 83d7addfc3..8cf600cec6 100644 --- a/xen/arch/x86/hvm/viridian/synic.c +++ b/xen/arch/x86/hvm/viridian/synic.c @@ -233,7 +233,7 @@ int viridian_synic_rdmsr(const struct vcpu *v, uint32_t idx, uint64_t *val) * should be set to. Assume everything but the bottom bit * should be zero. */ - *val = 1ul; + *val = 1UL; break; case HV_X64_MSR_SIEFP: diff --git a/xen/arch/x86/hvm/viridian/time.c b/xen/arch/x86/hvm/viridian/time.c index a3ea3fa067..137577384f 100644 --- a/xen/arch/x86/hvm/viridian/time.c +++ b/xen/arch/x86/hvm/viridian/time.c @@ -66,7 +66,7 @@ static void update_reference_tsc(const struct domain *d, bool initialize) * The offset value is calculated on restore after migration and * ensures that Windows will not see a large jump in ReferenceTime. */ - p->tsc_scale = ((10000ul << 32) / d->arch.tsc_khz) << 32; + p->tsc_scale = ((10000UL << 32) / d->arch.tsc_khz) << 32; p->tsc_offset = trc->off; smp_wmb(); @@ -79,7 +79,7 @@ static uint64_t trc_val(const struct domain *d, int64_t offset) uint64_t tsc, scale; tsc = hvm_get_guest_tsc(pt_global_vcpu_target(d)); - scale = ((10000ul << 32) / d->arch.tsc_khz) << 32; + scale = ((10000UL << 32) / d->arch.tsc_khz) << 32; return hv_scale_tsc(tsc, scale, offset); } @@ -201,7 +201,7 @@ static void start_stimer(struct viridian_stimer *vs) ASSERT(expiration - now > 0); vs->expiration = expiration; - timeout = (expiration - now) * 100ull; + timeout = (expiration - now) * 100ULL; vs->started = true; clear_bit(stimerx, &vv->stimer_pending); @@ -413,14 +413,14 @@ int viridian_time_rdmsr(const struct vcpu *v, uint32_t idx, uint64_t *val) if ( viridian_feature_mask(d) & HVMPV_no_freq ) return X86EMUL_EXCEPTION; - *val = (uint64_t)d->arch.tsc_khz * 1000ull; + *val = (uint64_t)d->arch.tsc_khz * 1000ULL; break; case HV_X64_MSR_APIC_FREQUENCY: if ( viridian_feature_mask(d) & HVMPV_no_freq ) return X86EMUL_EXCEPTION; - *val = 1000000000ull / APIC_BUS_CYCLE_NS; + *val = 1000000000ULL / APIC_BUS_CYCLE_NS; break; case HV_X64_MSR_REFERENCE_TSC: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576219.902138 (Exim 4.92) (envelope-from ) id 1qRVYG-0001XR-C4; Thu, 03 Aug 2023 10:27:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576219.902138; Thu, 03 Aug 2023 10:27:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYG-0001XH-8k; Thu, 03 Aug 2023 10:27:28 +0000 Received: by outflank-mailman (input) for mailman id 576219; Thu, 03 Aug 2023 10:27:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYE-0008Qm-Iv for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:26 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56df6d5b-31e8-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:27:25 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id F3C004EE0737; Thu, 3 Aug 2023 12:27:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56df6d5b-31e8-11ee-b268-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Simone Ballarin Subject: [XEN PATCH 11/13] xen/x86: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:26 +0200 Message-Id: <40f438ad05338dd86587eb469c7b0614e1d69462.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/arch/x86/cpu-policy.c | 4 ++-- xen/arch/x86/dom0_build.c | 2 +- xen/arch/x86/e820.c | 2 +- xen/arch/x86/hpet.c | 2 +- xen/arch/x86/hvm/hpet.c | 6 +++--- xen/arch/x86/hvm/hvm.c | 6 +++--- xen/arch/x86/hvm/stdvga.c | 2 +- xen/arch/x86/include/asm/apicdef.h | 4 ++-- xen/arch/x86/include/asm/debugreg.h | 16 ++++++++-------- xen/arch/x86/include/asm/guest_pt.h | 16 ++++++++-------- xen/arch/x86/include/asm/pv/domain.h | 2 +- xen/arch/x86/mm.c | 4 ++-- xen/arch/x86/msr.c | 2 +- xen/arch/x86/nmi.c | 2 +- xen/arch/x86/psr.c | 8 ++++---- xen/arch/x86/spec_ctrl.c | 6 +++--- xen/arch/x86/x86_64/mm.c | 4 ++-- xen/arch/x86/xstate.c | 2 +- xen/lib/x86/cpuid.c | 4 ++-- 19 files changed, 47 insertions(+), 47 deletions(-) diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c index 1f954d4e59..5fbb3602ae 100644 --- a/xen/arch/x86/cpu-policy.c +++ b/xen/arch/x86/cpu-policy.c @@ -250,9 +250,9 @@ static void recalculate_xstate(struct cpu_policy *p) else xstates &= ~XSTATE_XSAVES_ONLY; - for ( i = 2; i < min(63ul, ARRAY_SIZE(p->xstate.comp)); ++i ) + for ( i = 2; i < min(63UL, ARRAY_SIZE(p->xstate.comp)); ++i ) { - uint64_t curr_xstate = 1ul << i; + uint64_t curr_xstate = 1UL << i; if ( !(xstates & curr_xstate) ) continue; diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 8b1fcc6471..09fb8b063a 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -537,7 +537,7 @@ int __init dom0_setup_permissions(struct domain *d) for ( i = 0; i < e820.nr_map; i++ ) { unsigned long sfn, efn; - sfn = max_t(unsigned long, paddr_to_pfn(e820.map[i].addr), 0x100ul); + sfn = max_t(unsigned long, paddr_to_pfn(e820.map[i].addr), 0x100UL); efn = paddr_to_pfn(e820.map[i].addr + e820.map[i].size - 1); if ( (e820.map[i].type == E820_UNUSABLE) && (e820.map[i].size != 0) && diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c index 0b89935510..4911e64b8c 100644 --- a/xen/arch/x86/e820.c +++ b/xen/arch/x86/e820.c @@ -450,7 +450,7 @@ static uint64_t __init mtrr_top_of_ram(void) /* paddr_bits must have been set at this point */ ASSERT(paddr_bits); - addr_mask = ((1ull << paddr_bits) - 1) & PAGE_MASK; + addr_mask = ((1ULL << paddr_bits) - 1) & PAGE_MASK; rdmsrl(MSR_MTRRcap, mtrr_cap); rdmsrl(MSR_MTRRdefType, mtrr_def); diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index bc164dd82c..a2df1c7df4 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -619,7 +619,7 @@ void __init cf_check hpet_broadcast_init(void) * math multiplication factor for nanosecond to hpet tick conversion. */ hpet_events[i].mult = div_sc((unsigned long)hpet_rate, - 1000000000ul, 32); + 1000000000UL, 32); hpet_events[i].shift = 32; hpet_events[i].next_event = STIME_MAX; spin_lock_init(&hpet_events[i].lock); diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c index dff27b760e..80f323316c 100644 --- a/xen/arch/x86/hvm/hpet.c +++ b/xen/arch/x86/hvm/hpet.c @@ -161,7 +161,7 @@ static int cf_check hpet_read( if ( !v->domain->arch.hvm.params[HVM_PARAM_HPET_ENABLED] ) { - result = ~0ul; + result = ~0UL; goto out; } @@ -169,7 +169,7 @@ static int cf_check hpet_read( if ( hpet_check_access_length(addr, length) != 0 ) { - result = ~0ul; + result = ~0UL; goto out; } @@ -486,7 +486,7 @@ static int cf_check hpet_write( if ( timer_is_periodic(h, tn) && !(h->hpet.timers[tn].config & HPET_TN_SETVAL) ) { - uint64_t max_period = (timer_is_32bit(h, tn) ? ~0u : ~0ull) >> 1; + uint64_t max_period = (timer_is_32bit(h, tn) ? ~0u : ~0ULL) >> 1; /* * Clamp period to reasonable min/max values: diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 2180abeb33..3a99c0ff20 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -294,7 +294,7 @@ void hvm_get_guest_pat(struct vcpu *v, uint64_t *guest_pat) static bool pat_valid(uint64_t val) { /* Yields a non-zero value in any lane which had value greater than 7. */ - uint64_t any_gt_7 = val & 0xf8f8f8f8f8f8f8f8ull; + uint64_t any_gt_7 = val & 0xf8f8f8f8f8f8f8f8ULL; /* * With the > 7 case covered, identify lanes with the value 0-3 by finding @@ -302,7 +302,7 @@ static bool pat_valid(uint64_t val) * * Yields bit 2 set in each lane which has a value <= 3. */ - uint64_t any_le_3 = ~val & 0x0404040404040404ull; + uint64_t any_le_3 = ~val & 0x0404040404040404ULL; /* * Logically, any_2_or_3 is "any_le_3 && bit 1 set". @@ -3626,7 +3626,7 @@ int hvm_msr_read_intercept(unsigned int msr, uint64_t *msr_content) gp_fault: ret = X86EMUL_EXCEPTION; - *msr_content = -1ull; + *msr_content = -1ULL; goto out; } diff --git a/xen/arch/x86/hvm/stdvga.c b/xen/arch/x86/hvm/stdvga.c index 798a9a0549..2586891863 100644 --- a/xen/arch/x86/hvm/stdvga.c +++ b/xen/arch/x86/hvm/stdvga.c @@ -305,7 +305,7 @@ static int cf_check stdvga_mem_read( const struct hvm_io_handler *handler, uint64_t addr, uint32_t size, uint64_t *p_data) { - uint64_t data = ~0ul; + uint64_t data = ~0UL; switch ( size ) { diff --git a/xen/arch/x86/include/asm/apicdef.h b/xen/arch/x86/include/asm/apicdef.h index 2440d83c8d..a261436993 100644 --- a/xen/arch/x86/include/asm/apicdef.h +++ b/xen/arch/x86/include/asm/apicdef.h @@ -34,8 +34,8 @@ #define SET_xAPIC_LOGICAL_ID(x) (((x)<<24)) #define APIC_ALL_CPUS 0xFF #define APIC_DFR 0xE0 -#define APIC_DFR_CLUSTER 0x0FFFFFFFul -#define APIC_DFR_FLAT 0xFFFFFFFFul +#define APIC_DFR_CLUSTER 0x0FFFFFFFUL +#define APIC_DFR_FLAT 0xFFFFFFFFUL #define APIC_SPIV 0xF0 #define APIC_SPIV_FOCUS_DISABLED (1<<9) #define APIC_SPIV_APIC_ENABLED (1<<8) diff --git a/xen/arch/x86/include/asm/debugreg.h b/xen/arch/x86/include/asm/debugreg.h index c57914efc6..86aa6d7143 100644 --- a/xen/arch/x86/include/asm/debugreg.h +++ b/xen/arch/x86/include/asm/debugreg.h @@ -21,8 +21,8 @@ #define DR_STEP (0x4000) /* single-step */ #define DR_SWITCH (0x8000) /* task switch */ #define DR_NOT_RTM (0x10000) /* clear: #BP inside RTM region */ -#define DR_STATUS_RESERVED_ZERO (~0xffffeffful) /* Reserved, read as zero */ -#define DR_STATUS_RESERVED_ONE 0xffff0ff0ul /* Reserved, read as one */ +#define DR_STATUS_RESERVED_ZERO (~0xffffefffUL) /* Reserved, read as zero */ +#define DR_STATUS_RESERVED_ONE 0xffff0ff0UL /* Reserved, read as one */ /* Now define a bunch of things for manipulating the control register. The top two bytes of the control register consist of 4 fields of 4 @@ -61,12 +61,12 @@ We can slow the instruction pipeline for instructions coming via the gdt or the ldt if we want to. I am not sure why this is an advantage */ -#define DR_CONTROL_RESERVED_ZERO (~0xffff27fful) /* Reserved, read as zero */ -#define DR_CONTROL_RESERVED_ONE (0x00000400ul) /* Reserved, read as one */ -#define DR_LOCAL_EXACT_ENABLE (0x00000100ul) /* Local exact enable */ -#define DR_GLOBAL_EXACT_ENABLE (0x00000200ul) /* Global exact enable */ -#define DR_RTM_ENABLE (0x00000800ul) /* RTM debugging enable */ -#define DR_GENERAL_DETECT (0x00002000ul) /* General detect enable */ +#define DR_CONTROL_RESERVED_ZERO (~0xffff27ffUL) /* Reserved, read as zero */ +#define DR_CONTROL_RESERVED_ONE (0x00000400UL) /* Reserved, read as one */ +#define DR_LOCAL_EXACT_ENABLE (0x00000100UL) /* Local exact enable */ +#define DR_GLOBAL_EXACT_ENABLE (0x00000200UL) /* Global exact enable */ +#define DR_RTM_ENABLE (0x00000800UL) /* RTM debugging enable */ +#define DR_GENERAL_DETECT (0x00002000UL) /* General detect enable */ #define write_debugreg(reg, val) do { \ unsigned long __val = val; \ diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h index bde7588342..bc312343cd 100644 --- a/xen/arch/x86/include/asm/guest_pt.h +++ b/xen/arch/x86/include/asm/guest_pt.h @@ -32,15 +32,15 @@ gfn_to_paddr(gfn_t gfn) /* Mask covering the reserved bits from superpage alignment. */ #define SUPERPAGE_RSVD(bit) \ - (((1ul << (bit)) - 1) & ~(_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1ul))) + (((1UL << (bit)) - 1) & ~(_PAGE_PSE_PAT | (_PAGE_PSE_PAT - 1UL))) static inline uint32_t fold_pse36(uint64_t val) { - return (val & ~(0x1fful << 13)) | ((val & (0x1fful << 32)) >> (32 - 13)); + return (val & ~(0x1ffUL << 13)) | ((val & (0x1ffUL << 32)) >> (32 - 13)); } static inline uint64_t unfold_pse36(uint32_t val) { - return (val & ~(0x1fful << 13)) | ((val & (0x1fful << 13)) << (32 - 13)); + return (val & ~(0x1ffUL << 13)) | ((val & (0x1ffUL << 13)) << (32 - 13)); } /* Types of the guest's page tables and access functions for them */ @@ -99,10 +99,10 @@ static inline guest_l2e_t guest_l2e_from_gfn(gfn_t gfn, u32 flags) #define GUEST_L2_PAGETABLE_SHIFT 21 #define GUEST_L3_PAGETABLE_SHIFT 30 -#define GUEST_L1_PAGETABLE_RSVD 0x7ff0000000000000ul -#define GUEST_L2_PAGETABLE_RSVD 0x7ff0000000000000ul +#define GUEST_L1_PAGETABLE_RSVD 0x7ff0000000000000UL +#define GUEST_L2_PAGETABLE_RSVD 0x7ff0000000000000UL #define GUEST_L3_PAGETABLE_RSVD \ - (0xfff0000000000000ul | _PAGE_GLOBAL | _PAGE_PSE | _PAGE_DIRTY | \ + (0xfff0000000000000UL | _PAGE_GLOBAL | _PAGE_PSE | _PAGE_DIRTY | \ _PAGE_ACCESSED | _PAGE_USER | _PAGE_RW) #else /* GUEST_PAGING_LEVELS == 4 */ @@ -281,7 +281,7 @@ static always_inline bool guest_pks_enabled(const struct vcpu *v) static always_inline uint64_t guest_rsvd_bits(const struct vcpu *v) { return ((PADDR_MASK & - ~((1ul << v->domain->arch.cpuid->extd.maxphysaddr) - 1)) | + ~((1UL << v->domain->arch.cpuid->extd.maxphysaddr) - 1)) | (guest_nx_enabled(v) ? 0 : put_pte_flags(_PAGE_NX_BIT))); } @@ -301,7 +301,7 @@ static always_inline bool guest_l2e_rsvd_bits(const struct vcpu *v, ((l2e.l2 & _PAGE_PSE) && (l2e.l2 & ((GUEST_PAGING_LEVELS == 2 && guest_can_use_pse36(v->domain)) /* PSE36 tops out at 40 bits of address width. */ - ? (fold_pse36(rsvd_bits | (1ul << 40))) + ? (fold_pse36(rsvd_bits | (1UL << 40))) : SUPERPAGE_RSVD(GUEST_L2_PAGETABLE_SHIFT))))); } diff --git a/xen/arch/x86/include/asm/pv/domain.h b/xen/arch/x86/include/asm/pv/domain.h index db7a40f68e..75a6b9e5c7 100644 --- a/xen/arch/x86/include/asm/pv/domain.h +++ b/xen/arch/x86/include/asm/pv/domain.h @@ -93,7 +93,7 @@ static inline int pv_vcpu_initialise(struct vcpu *v) { return -EOPNOTSUPP; } static inline void pv_domain_destroy(struct domain *d) {} static inline int pv_domain_initialise(struct domain *d) { return -EOPNOTSUPP; } -static inline unsigned long pv_make_cr4(const struct vcpu *v) { return ~0ul; } +static inline unsigned long pv_make_cr4(const struct vcpu *v) { return ~0UL; } static inline uint64_t pv_get_reg(struct vcpu *v, unsigned int reg) { diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index be2b10a391..ad0eafc900 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3057,10 +3057,10 @@ static int _get_page_type(struct page_info *page, unsigned long type, if ( (x & PGT_type_mask) == PGT_writable_page ) rc = iommu_legacy_unmap(d, _dfn(mfn_x(mfn)), - 1ul << PAGE_ORDER_4K); + 1UL << PAGE_ORDER_4K); else rc = iommu_legacy_map(d, _dfn(mfn_x(mfn)), mfn, - 1ul << PAGE_ORDER_4K, + 1UL << PAGE_ORDER_4K, IOMMUF_readable | IOMMUF_writable); if ( unlikely(rc) ) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index ecf126566d..ef55498c1a 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -431,7 +431,7 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val) { bool old_cpuid_faulting = msrs->misc_features_enables.cpuid_faulting; - rsvd = ~0ull; + rsvd = ~0ULL; if ( cp->platform_info.cpuid_faulting ) rsvd &= ~MSR_MISC_FEATURES_CPUID_FAULTING; diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 7656023748..c5c28300b0 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -205,7 +205,7 @@ void __init check_nmi_watchdog(void) * (Intel SDM, section 18.22.2) */ if ( nmi_watchdog == NMI_LOCAL_APIC ) - nmi_hz = max(1ul, cpu_khz >> 20); + nmi_hz = max(1UL, cpu_khz >> 20); return; } diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c index 90bcb25e60..4c01813c4b 100644 --- a/xen/arch/x86/psr.c +++ b/xen/arch/x86/psr.c @@ -289,7 +289,7 @@ static bool cf_check cat_check_cbm(const struct feat_node *feat, uint32_t *val) unsigned long cbm = *val; /* Set bits should only in the range of [0, cbm_len). */ - if ( cbm & (~0ul << cbm_len) ) + if ( cbm & (~0UL << cbm_len) ) return false; /* At least one bit need to be set. */ @@ -360,7 +360,7 @@ static bool cat_init_feature(const struct cpuid_leaf *regs, wrmsrl(MSR_IA32_PSR_L3_MASK(1), cat_default_val(feat->cat.cbm_len)); rdmsrl(MSR_IA32_PSR_L3_QOS_CFG, val); wrmsrl(MSR_IA32_PSR_L3_QOS_CFG, - val | (1ull << PSR_L3_QOS_CDP_ENABLE_BIT)); + val | (1ULL << PSR_L3_QOS_CDP_ENABLE_BIT)); break; } @@ -636,7 +636,7 @@ static void __init init_psr_cmt(unsigned int rmid_max) psr_cmt->features = edx; psr_cmt->rmid_max = min(rmid_max, ebx); - rmid_mask = ~(~0ull << get_count_order(ebx)); + rmid_mask = ~(~0ULL << get_count_order(ebx)); if ( psr_cmt->features & PSR_RESOURCE_TYPE_L3 ) { @@ -738,7 +738,7 @@ static void psr_assoc_init(void) unsigned int cos_max = get_max_cos_max(info); if ( info->feat_init ) - psra->cos_mask = ((1ull << get_count_order(cos_max)) - 1) << + psra->cos_mask = ((1ULL << get_count_order(cos_max)) - 1) << ASSOC_REG_SHIFT; } diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 4081cef200..bc50173620 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -1047,7 +1047,7 @@ static __init void l1tf_calculations(void) * The address mask which the L1D cache uses, which might be wider than * the CPUID-reported maxphysaddr. */ - l1tf_addr_mask = ((1ul << l1d_maxphysaddr) - 1) & PAGE_MASK; + l1tf_addr_mask = ((1UL << l1d_maxphysaddr) - 1) & PAGE_MASK; /* * To be safe, l1tf_safe_maddr must be above the highest cacheable entity @@ -1087,8 +1087,8 @@ static __init void l1tf_calculations(void) * information is in terms of guest physical layout. */ l1tf_safe_maddr = max(l1tf_safe_maddr, ((l1d_maxphysaddr > paddr_bits) - ? (1ul << paddr_bits) - : (3ul << (paddr_bits - 2)))); + ? (1UL << paddr_bits) + : (3UL << (paddr_bits - 2)))); } /* Calculate whether this CPU is vulnerable to MDS. */ diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 60db439af3..15b36e332d 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -1313,7 +1313,7 @@ int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm) { for ( i = spfn; i < epfn; i++ ) if ( iommu_legacy_map(hardware_domain, _dfn(i), _mfn(i), - 1ul << PAGE_ORDER_4K, + 1UL << PAGE_ORDER_4K, IOMMUF_readable | IOMMUF_writable) ) break; if ( i != epfn ) @@ -1321,7 +1321,7 @@ int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm) while (i-- > old_max) /* If statement to satisfy __must_check. */ if ( iommu_legacy_unmap(hardware_domain, _dfn(i), - 1ul << PAGE_ORDER_4K) ) + 1UL << PAGE_ORDER_4K) ) continue; goto destroy_m2p; diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 92496f3795..3062c28219 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -150,7 +150,7 @@ static void setup_xstate_comp(uint16_t *comp_offsets, offset = comp_offsets[2]; for ( i = 2; i < xstate_features; i++ ) { - if ( (1ul << i) & xcomp_bv ) + if ( (1UL << i) & xcomp_bv ) { if ( test_bit(i, &xstate_align) ) offset = ROUNDUP(offset, 64); diff --git a/xen/lib/x86/cpuid.c b/xen/lib/x86/cpuid.c index 07e5501914..2006cbaa1c 100644 --- a/xen/lib/x86/cpuid.c +++ b/xen/lib/x86/cpuid.c @@ -211,7 +211,7 @@ void x86_cpu_policy_fill_native(struct cpu_policy *p) for ( i = 2; i < min_t(unsigned int, 63, ARRAY_SIZE(p->xstate.raw)); ++i ) { - if ( xstates & (1ull << i) ) + if ( xstates & (1ULL << i) ) cpuid_count_leaf(0xd, i, &p->xstate.raw[i]); } } @@ -419,7 +419,7 @@ int x86_cpuid_copy_to_buffer(const struct cpu_policy *p, &(struct cpuid_leaf){ p->hv2_limit }); /* Extended leaves. */ - for ( leaf = 0; leaf <= MIN(p->extd.max_leaf & 0xfffful, + for ( leaf = 0; leaf <= MIN(p->extd.max_leaf & 0xffffUL, ARRAY_SIZE(p->extd.raw) - 1); ++leaf ) COPY_LEAF(0x80000000 | leaf, XEN_CPUID_NO_SUBLEAF, &p->extd.raw[leaf]); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576226.902148 (Exim 4.92) (envelope-from ) id 1qRVYR-0002FD-RF; Thu, 03 Aug 2023 10:27:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576226.902148; Thu, 03 Aug 2023 10:27:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYR-0002F6-O1; Thu, 03 Aug 2023 10:27:39 +0000 Received: by outflank-mailman (input) for mailman id 576226; Thu, 03 Aug 2023 10:27:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYR-0000aV-6q for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:39 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e062244-31e8-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:27:37 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id D8B1D4EE0737; Thu, 3 Aug 2023 12:27:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e062244-31e8-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Simone Ballarin Subject: [XEN PATCH 12/13] xen/common: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:27 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/common/page_alloc.c | 6 +++--- xen/common/rangeset.c | 2 +- xen/common/softirq.c | 8 ++++---- xen/common/vsprintf.c | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index e40473f71e..03b63d0ee7 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2380,7 +2380,7 @@ int assign_pages( if ( unlikely(nr > d->max_pages - tot_pages) ) { gprintk(XENLOG_INFO, "Over-allocation for %pd: %Lu > %u\n", - d, tot_pages + 0ull + nr, d->max_pages); + d, tot_pages + 0ULL + nr, d->max_pages); rc = -E2BIG; goto out; } @@ -2392,7 +2392,7 @@ int assign_pages( { gprintk(XENLOG_INFO, "Excess allocation for %pd: %Lu (%u extra)\n", - d, d->tot_pages + 0ull + nr, d->extra_pages); + d, d->tot_pages + 0ULL + nr, d->extra_pages); if ( pg[0].count_info & PGC_extra ) d->extra_pages -= nr; rc = -E2BIG; @@ -2460,7 +2460,7 @@ struct page_info *alloc_domheap_pages( { unsigned long i; - for ( i = 0; i < (1ul << order); i++ ) + for ( i = 0; i < (1UL << order); i++ ) { ASSERT(!pg[i].count_info); pg[i].count_info = PGC_extra; diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c index a6ef264046..f3baf52ab6 100644 --- a/xen/common/rangeset.c +++ b/xen/common/rangeset.c @@ -393,7 +393,7 @@ static int cf_check merge(unsigned long s, unsigned long e, void *data) int rangeset_merge(struct rangeset *r1, struct rangeset *r2) { - return rangeset_report_ranges(r2, 0, ~0ul, merge, r1); + return rangeset_report_ranges(r2, 0, ~0UL, merge, r1); } int rangeset_add_singleton( diff --git a/xen/common/softirq.c b/xen/common/softirq.c index 063e93cbe3..321d26902d 100644 --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -29,7 +29,7 @@ static void __do_softirq(unsigned long ignore_mask) { unsigned int i, cpu; unsigned long pending; - bool rcu_allowed = !(ignore_mask & (1ul << RCU_SOFTIRQ)); + bool rcu_allowed = !(ignore_mask & (1UL << RCU_SOFTIRQ)); ASSERT(!rcu_allowed || rcu_quiesce_allowed()); @@ -57,12 +57,12 @@ static void __do_softirq(unsigned long ignore_mask) void process_pending_softirqs(void) { /* Do not enter scheduler as it can preempt the calling context. */ - unsigned long ignore_mask = (1ul << SCHEDULE_SOFTIRQ) | - (1ul << SCHED_SLAVE_SOFTIRQ); + unsigned long ignore_mask = (1UL << SCHEDULE_SOFTIRQ) | + (1UL << SCHED_SLAVE_SOFTIRQ); /* Block RCU processing in case of rcu_read_lock() held. */ if ( !rcu_quiesce_allowed() ) - ignore_mask |= 1ul << RCU_SOFTIRQ; + ignore_mask |= 1UL << RCU_SOFTIRQ; ASSERT(!in_irq() && local_irq_is_enabled()); __do_softirq(ignore_mask); diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c index 94c1ba7257..c49631c0a4 100644 --- a/xen/common/vsprintf.c +++ b/xen/common/vsprintf.c @@ -225,7 +225,7 @@ static char *print_bitmap_string(char *str, const char *end, */ for ( i = ROUNDUP(nr_bits, CHUNKSZ) - CHUNKSZ; i >= 0; i -= CHUNKSZ ) { - unsigned int chunkmask = (1ull << chunksz) - 1; + unsigned int chunkmask = (1ULL << chunksz) - 1; unsigned int word = i / BITS_PER_LONG; unsigned int offset = i % BITS_PER_LONG; unsigned long val = (bitmap[word] >> offset) & chunkmask; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:27:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:27:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576227.902158 (Exim 4.92) (envelope-from ) id 1qRVYW-0002fi-2f; Thu, 03 Aug 2023 10:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576227.902158; Thu, 03 Aug 2023 10:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYV-0002fQ-W3; Thu, 03 Aug 2023 10:27:43 +0000 Received: by outflank-mailman (input) for mailman id 576227; Thu, 03 Aug 2023 10:27:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVYU-0000aV-Sk for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:27:42 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6038b78b-31e8-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:27:41 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 8CAAA4EE0740; Thu, 3 Aug 2023 12:27:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6038b78b-31e8-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Simone Ballarin Subject: [XEN PATCH 13/13] xen: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:28 +0200 Message-Id: <5b625185f779b9903463b8abd1aabfe7d5d8e548.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin --- xen/include/xen/bitops.h | 8 ++++---- xen/include/xen/tasklet.h | 4 ++-- xen/include/xen/time.h | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h index e926047932..654f525fb4 100644 --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -186,12 +186,12 @@ static inline unsigned int generic_hweight64(uint64_t w) if ( BITS_PER_LONG < 64 ) return generic_hweight32(w >> 32) + generic_hweight32(w); - w -= (w >> 1) & 0x5555555555555555ul; - w = (w & 0x3333333333333333ul) + ((w >> 2) & 0x3333333333333333ul); - w = (w + (w >> 4)) & 0x0f0f0f0f0f0f0f0ful; + w -= (w >> 1) & 0x5555555555555555UL; + w = (w & 0x3333333333333333UL) + ((w >> 2) & 0x3333333333333333UL); + w = (w + (w >> 4)) & 0x0f0f0f0f0f0f0f0fUL; if ( IS_ENABLED(CONFIG_HAS_FAST_MULTIPLY) ) - return (w * 0x0101010101010101ul) >> 56; + return (w * 0x0101010101010101UL) >> 56; w += w >> 8; w += w >> 16; diff --git a/xen/include/xen/tasklet.h b/xen/include/xen/tasklet.h index ea73171f6e..193acf8f42 100644 --- a/xen/include/xen/tasklet.h +++ b/xen/include/xen/tasklet.h @@ -37,8 +37,8 @@ struct tasklet DECLARE_PER_CPU(unsigned long, tasklet_work_to_do); #define _TASKLET_enqueued 0 /* Tasklet work is enqueued for this CPU. */ #define _TASKLET_scheduled 1 /* Scheduler has scheduled do_tasklet(). */ -#define TASKLET_enqueued (1ul << _TASKLET_enqueued) -#define TASKLET_scheduled (1ul << _TASKLET_scheduled) +#define TASKLET_enqueued (1UL << _TASKLET_enqueued) +#define TASKLET_scheduled (1UL << _TASKLET_scheduled) static inline bool tasklet_work_to_do(unsigned int cpu) { diff --git a/xen/include/xen/time.h b/xen/include/xen/time.h index 9ceaec541f..5aafdda4f3 100644 --- a/xen/include/xen/time.h +++ b/xen/include/xen/time.h @@ -57,9 +57,9 @@ struct tm wallclock_time(uint64_t *ns); #define SECONDS(_s) ((s_time_t)((_s) * 1000000000ULL)) #define MILLISECS(_ms) ((s_time_t)((_ms) * 1000000ULL)) #define MICROSECS(_us) ((s_time_t)((_us) * 1000ULL)) -#define STIME_MAX ((s_time_t)((uint64_t)~0ull>>1)) +#define STIME_MAX ((s_time_t)((uint64_t)~0ULL>>1)) /* Chosen so (NOW() + delta) wont overflow without an uptime of 200 years */ -#define STIME_DELTA_MAX ((s_time_t)((uint64_t)~0ull>>2)) +#define STIME_DELTA_MAX ((s_time_t)((uint64_t)~0ULL>>2)) /* Explicitly OR with 1 just in case version number gets out of sync. */ #define version_update_begin(v) (((v) + 1) | 1) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:29:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:29:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576233.902167 (Exim 4.92) (envelope-from ) id 1qRVaK-0003vp-Fz; Thu, 03 Aug 2023 10:29:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576233.902167; Thu, 03 Aug 2023 10:29:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVaK-0003vi-Cy; Thu, 03 Aug 2023 10:29:36 +0000 Received: by outflank-mailman (input) for mailman id 576233; Thu, 03 Aug 2023 10:29:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVaI-0003v5-Rh for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:29:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20607.outbound.protection.outlook.com [2a01:111:f400:7d00::607]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a32e5ee8-31e8-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 12:29:33 +0200 (CEST) Received: from AS9PR06CA0151.eurprd06.prod.outlook.com (2603:10a6:20b:45c::8) by DB8PR08MB5356.eurprd08.prod.outlook.com (2603:10a6:10:f9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 10:29:22 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45c:cafe::88) by AS9PR06CA0151.outlook.office365.com (2603:10a6:20b:45c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 10:29:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45 via Frontend Transport; Thu, 3 Aug 2023 10:29:21 +0000 Received: ("Tessian outbound ba2f3d95109c:v145"); Thu, 03 Aug 2023 10:29:21 +0000 Received: from 1ef2d0cc2d0d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 962BB63B-1BA6-4B37-A1EB-BC29480D9AC3.1; Thu, 03 Aug 2023 10:28:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1ef2d0cc2d0d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 10:28:27 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 10:28:26 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 10:28:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a32e5ee8-31e8-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9r9HetsJDprQeKfL5CvjTbWMKMTHnuWnREm361MzuU=; b=C6IYVpD2idZzspeF3Z0F3b9fQHnhZQAFQhXtU6aGUhl9cl1NxYZ18b9Hsy4Ck025OwrtfRb80AL1hNQMtARw2HEH9WyV9V5x1KFSiruowRwprN4df0+eUGqbe0WWZ9nN/487fyxyH+uSekXkHmON0Sj/EUhiofR0fJM1JyqWFTo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e8896e8b218cbc21 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lodZzfBkCsdbLmKJi0XtEdXCVsEDdEx8UjV49aN8hg31fHcyvuvcB/3lwcuusThSBNHNkSF74fJwsBaV/la9UEcnJPDSIcQD25Q48LbdypP94Ooif1u0WNATZ2kaPCWSDxkjzsVT0H33zUahyrWbKciEw08q4JtL6jE1byvt6lTcYCCAIFdMK40VGVQ74wEGnFCAiCTnyGfAzDCAYdEki9PH8VaEOswHSeG/o3YocESnM2ttBC/cYIjiDtDsYiDI1Osj0zpOThecai92f+qQoQWRZZzEjwvDKwqhtsvfMvo4h1SSI0WnEFpFvsjP+KV/zEQoCG1UaudXL7hMuGfBjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9r9HetsJDprQeKfL5CvjTbWMKMTHnuWnREm361MzuU=; b=GaJ/5lj8H0X60f6WYY7NallDOoz1Cdebn5v6OJQ1wp4IGDilwG2hYLobTWcG0+g/wdD6bCvy4O5/yP8OaB2veIUEIEF+Cv03ha1ZA5qvj8PkYqmeO37y/fn6orKUoXpp5nKBjH108nGqYExtKFVLfMPDFQECzNd12e92A+/o5rQJ1X1dFo1wUilIBnx621P2NBNbdvybNRJLtCixqqcDhoMrz1NnJAvkLXcsPE/O2dDP0SFxrKKOq3dbHzIeMB4iX9RMx+MyyyD9C5SE/pAbZhjUQDjP197LAcoV0mHjmNxI40gKR5fFChJBY9ypL2b+n0yFHHc0SUU9OG3fdGBM9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9r9HetsJDprQeKfL5CvjTbWMKMTHnuWnREm361MzuU=; b=C6IYVpD2idZzspeF3Z0F3b9fQHnhZQAFQhXtU6aGUhl9cl1NxYZ18b9Hsy4Ck025OwrtfRb80AL1hNQMtARw2HEH9WyV9V5x1KFSiruowRwprN4df0+eUGqbe0WWZ9nN/487fyxyH+uSekXkHmON0Sj/EUhiofR0fJM1JyqWFTo= From: Luca Fancellu To: Federico Serafini CC: Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names Thread-Topic: [XEN PATCH v2] xen/string: add missing parameter names Thread-Index: AQHZxeRL9pSVXV1k9k69k8jE/HqUO6/YXqGA Date: Thu, 3 Aug 2023 10:28:24 +0000 Message-ID: References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> In-Reply-To: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PA4PR08MB6080:EE_|AM7EUR03FT031:EE_|DB8PR08MB5356:EE_ X-MS-Office365-Filtering-Correlation-Id: 0075ddaf-ae46-4694-0d95-08db940c8086 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0LiG+lpIOQw7kKe7PGylGc6IizikbOb9l5ri/zBCLnk0Tyd+bIpGFteA3CSnnopftf76WJEcHV5WrAvqUqsDHQXeEcGGVX4lRtevfi8u/lwqGXs5ZaUmbBOX+K5I3aDKCS/zjcnyziGEbin16DvlyziIyVdorNQQNN+/TXGJ6c+rUMIT/Od55L4TN1wx9dgZsGU9itEZhd2fgZCp2O/cG224MZFREBhRZQBa5Rvxxw6h1lvtWZrstKRuy2RGk4B3Snxpani3wOXFyddMTy/Mlw0VM75j2IoJNHjkckO3BHZwwErVTFmPOphX9UxlEVnCfvvT4KV9gA2GcBkoJY8SPbyb+0wmWuDZhjMOdf+mcckpHkzTm5ldR/ik6bVl8j4NYzzffzJAjEG5LEg7jS+gaolRd6rrGRl6zoVy1gudPtX437FIQT4k/7RAFJl4HsOUCVdwOzjyKTOu5qQPN8HZhNrSyvgbFqxLKNHPAI8XGiFc5SP68ECYkNiA//XBkAWrAAKGDsrfEWtJD/0BopyVGWRfEi6llN/Sz79l0eOdTFvI0rECQSvVx1E8DgJEbagEPr9mdr2vQ6zg9LfebZG3R6ZvPWKiNX4H1SmeQl2SiEhDQYpS/wg5MzVTV8y2vfiRMuCHOUaNUURuAh24jTeVmA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199021)(2616005)(53546011)(6506007)(83380400001)(26005)(186003)(316002)(76116006)(2906002)(91956017)(66946007)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(6916009)(41300700001)(8676002)(8936002)(6486002)(71200400001)(6512007)(54906003)(478600001)(38100700002)(122000001)(33656002)(36756003)(86362001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <71A0FAA146D44A4A8309A86C51282DEC@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c3a4e142-d08c-4622-169f-08db940c5e33 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /nLRkvyb1ay5t3DKzePXrEhLiwyyl6F+FVD/ppyiAauB/ANbmNC3TShbTwpLzRNLgpSXFDu50EyDdw5uQyP/haUKJ/CdX+y22ZrdITdTpg+JrLVNF9tRugXPgpA8PUSKxrr4n+DsfgJrbhwChGf2zC/SikA9HGmt0dhQ5EoPU4KLbg9myh6ZODOQqOIRcW6V9uYblJtOmS+c44GbibArW4WugATyq5/LWXTJLLO/TlJvzXSMe7EpkuOS9Xi+aak+5o+uBCOGG9z5WTDhiovkXJ4UeQHYVUmj+nigXZRcyC7yrWDQDNxYXaIaYzSB1eo95KJrXkNQYlV0szpHzdxalf/CVUq1gcVV/Et1ZMwkwGSlwi+CJyYhNqUjvrbTugXwHsTqLkc7sYvhK8EXyQ2fxZWEuPyuFP6zgrm4II0uctdOiESWaUi+gVcxbAGtD3IFNx8OAJb8HrpbaCv7jl52tr6kdFOi2JBFR06A6hhKV58c67sV0mnEAFy3Zw+wYac784N4HGaPViiH9VmZe9agscUs0hdCf3eM7bnqLFTwugjMx1EOkOaEWZ/J0k0aiiqYldeqkiwafTXV8eQoKS+y0xCYafWubHsopWiuaRnToU8jr4qUPujVTKAnFBaVh6bTPszfUOoFlOnx/CwAOqzG4jtZ+eWp/NxA9wZrwpleuEq3j7GNtKoiouVZvcMQqxtcXIFG+lzmJrG47x5yN0QEDxfpS9IYJCTrXireIALbPMQzLyfhFa6RKC3vITncCKg9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199021)(82310400008)(36840700001)(46966006)(40470700004)(40460700003)(2616005)(53546011)(6506007)(83380400001)(26005)(186003)(336012)(47076005)(36860700001)(316002)(2906002)(70586007)(70206006)(4326008)(5660300002)(6862004)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(40480700001)(356005)(81166007)(33656002)(86362001)(36756003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 10:29:21.8750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0075ddaf-ae46-4694-0d95-08db940c8086 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5356 > On 3 Aug 2023, at 09:26, Federico Serafini wrote: >=20 > Add missing parameter names to address violation of MISRA C:2012 > rule 8.2 ("Function types shall be in prototype form with named > parameters"). >=20 > No functional changes. >=20 > Signed-off-by: Federico Serafini > --- > Changes in v2: > - memset() adjusted. > --- > xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) >=20 > diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h > index b4d2217a96..e91e3112e0 100644 > --- a/xen/include/xen/string.h > +++ b/xen/include/xen/string.h > @@ -12,27 +12,27 @@ > #define strncpy __xen_has_no_strncpy__ > #define strncat __xen_has_no_strncat__ >=20 > -size_t strlcpy(char *, const char *, size_t); > -size_t strlcat(char *, const char *, size_t); > -int strcmp(const char *, const char *); > -int strncmp(const char *, const char *, size_t); > -int strcasecmp(const char *, const char *); > -int strncasecmp(const char *, const char *, size_t); > -char *strchr(const char *, int); > -char *strrchr(const char *, int); > -char *strstr(const char *, const char *); > -size_t strlen(const char *); > -size_t strnlen(const char *, size_t); > -char *strpbrk(const char *, const char *); > -char *strsep(char **, const char *); > -size_t strspn(const char *, const char *); > - > -void *memset(void *, int, size_t); > -void *memcpy(void *, const void *, size_t); > -void *memmove(void *, const void *, size_t); > -int memcmp(const void *, const void *, size_t); > -void *memchr(const void *, int, size_t); > -void *memchr_inv(const void *, int, size_t); > +size_t strlcpy(char *dest, const char *src, size_t size); > +size_t strlcat(char *dest, const char *src, size_t size); > +int strcmp(const char *cs, const char *ct); > +int strncmp(const char *cs, const char *ct, size_t count); > +int strcasecmp(const char *s1, const char *s2); > +int strncasecmp(const char *s1, const char *s2, size_t len); > +char *strchr(const char *s, int c); > +char *strrchr(const char *s, int c); > +char *strstr(const char *s1, const char *s2); > +size_t strlen(const char *s); > +size_t strnlen(const char *s, size_t count); > +char *strpbrk(const char *cs, const char *ct); > +char *strsep(char **s, const char *ct); > +size_t strspn(const char *s, const char *accept); > + > +void *memset(void *s, int c, size_t count); > +void *memcpy(void *dest, const void *src, size_t count); There is a comment in arch/arm/rm32/lib/memcpy.S with this: /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ > +void *memmove(void *dest, const void *src, size_t count); There is a comment in arch/arm/rm32/lib/memmove.S with this: * Prototype: void *memmove(void *dest, const void *src, size_t n); > +int memcmp(const void *cs, const void *ct, size_t count); > +void *memchr(const void *s, int c, size_t n); > +void *memchr_inv(const void *s, int c, size_t n); @Stefano: would it make sense to remove it as part of this patch or maybe n= ot? Apart from that, the patch looks good to me: Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:45:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:45:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576253.902178 (Exim 4.92) (envelope-from ) id 1qRVpC-0006Si-Pe; Thu, 03 Aug 2023 10:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576253.902178; Thu, 03 Aug 2023 10:44:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVpC-0006SN-M1; Thu, 03 Aug 2023 10:44:58 +0000 Received: by outflank-mailman (input) for mailman id 576253; Thu, 03 Aug 2023 10:44:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVpA-0006R6-8b for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:44:56 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c63f1b36-31ea-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:44:53 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691059486980177.53896160741135; Thu, 3 Aug 2023 03:44:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c63f1b36-31ea-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691059489; cv=none; d=zohomail.com; s=zohoarc; b=CqoqPxcMhQKOSPFPL1drpXXXj7+fRTAJ065EQiu+d3/RZWmCBOxKTYxkoNW0znDCFQCB2HU28ZG5sgdO9InvX317KkviZ5E7o/csXC+paN9dRbe4jHgjAF4sALIGdGE6YXN+H3KAlPp4xSQNF/eTCtGPIBp+damKCr5ITyIZ1gk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691059489; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=NI9QzLntlpPNBsuyFhfQihukqMkII5427Tj801yySmU=; b=kEjtLWi8Lbe/Ka4h1xTWx+HbSP9Nk+QG1yXefTfGfhRxiFQvWBs48WYpl8Jmo6JBWanGygIGyu9diKMjggV6clEofmBGBG/xyTJFlcH/magttwCpPBLhohqdeZzyKw2FceNMXlYVYAo1OlaaDhiGtmYh4I2QFw+OJiHci09DYZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691059489; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=NI9QzLntlpPNBsuyFhfQihukqMkII5427Tj801yySmU=; b=XGLVUR7VAywlrnre4hu8LGiM+TSyiMlU32+vC4hs6p+z7cnekY60dFtDQELPZ0Bj a/CRNKLPhdwcC5+3tVvudpmujnFUkWF93hyJEA6hZQizm8CImupluQfbATikoW2ZOQC aGtu9n9FWv1GfQr7vokcj5YnOep085W1Je7YiGx8= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Christopher Clark , Rich Persaud , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Anthony PERARD Subject: [PATCH v2 0/2] Rebranding dom0less to hyperlaunch part 1 Date: Thu, 3 Aug 2023 06:44:36 -0400 Message-Id: <20230803104438.24720-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This is the first series of the proposal put forth on moving to have dom0less folded under and thus rebranded as a part of hyperlaunch. As laid out in the proposal, the series updates the hyperlaunch device tree documentation and applies the general refactoring of FDT parsing to make core logic common. Changes in v2 - removed original function declarations from arch/arm/include/asm/setup.h - corrected the new F: entries in the FDT section of MAINTAINERS - alphabetized the F: entries in the FDT section of MAINTAINERS Daniel P. Smith (2): docs: update hyperlaunch device tree fdt: make fdt handling reusable across arch MAINTAINERS | 17 +- .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++-------- xen/arch/arm/bootfdt.c | 141 +---- xen/arch/arm/domain_build.c | 1 + xen/arch/arm/include/asm/setup.h | 6 - xen/common/Kconfig | 4 + xen/common/Makefile | 3 +- xen/common/fdt.c | 153 +++++ xen/include/xen/device_tree.h | 50 +- xen/include/xen/fdt.h | 79 +++ 10 files changed, 555 insertions(+), 465 deletions(-) create mode 100644 xen/common/fdt.c create mode 100644 xen/include/xen/fdt.h -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:45:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:45:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576254.902188 (Exim 4.92) (envelope-from ) id 1qRVpS-0006ms-6S; Thu, 03 Aug 2023 10:45:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576254.902188; Thu, 03 Aug 2023 10:45:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVpS-0006ml-3D; Thu, 03 Aug 2023 10:45:14 +0000 Received: by outflank-mailman (input) for mailman id 576254; Thu, 03 Aug 2023 10:45:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVpR-0006R6-2m for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:45:13 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0d3c369-31ea-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:45:10 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691059488468459.8456392127623; Thu, 3 Aug 2023 03:44:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0d3c369-31ea-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691059491; cv=none; d=zohomail.com; s=zohoarc; b=fi5lAjasoGhPJ0xY7+ygV9hjj5fHuhf9L+DPwwBa3aBowixgni8c2Pf+ZIAKBEBc6AqncoCxDkX/9xfVH1Z7tE3f8Xi9mkUBamFX3cFLk4SeV77OleH+YDeD30rkugQOOkLTEw4rf2gFYYZHK4KdolfFO48EjnbC2NjO2RrbXo4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691059491; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=EW4AyI36gTHVj3MBWRAetoSpPzDjxbKjm9mKfWizXOo=; b=CKGPhBukzRvx6g6gAB58Wx+ZlTCSp6sBl+jTSgoQ1VrnBGbHHR+yYPvoyFCxJJp1F/3t6l72F90bXUcMLhZJELP1JZFF60Wv1VBE6BL11TvkjHKGw1LKsg1ne0MDkkbZkxE2SJOzq42vQgMyNZJ24m3b2+x2+hUtP8Y5kUq9V+Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691059491; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=EW4AyI36gTHVj3MBWRAetoSpPzDjxbKjm9mKfWizXOo=; b=fVvTEHHmkO6gU+mQHcbeirdwehY3XAMAn+WPEsWkC7a/50e6pWQg0KfP2Hka155e WaTmH106Ia1Ps2E6m9N0ttbmYo3nKp2JAjKUJ+8fhcGRcdV/gL/26aK0b4iq338iQwp WZVzut64+F5ulZebTip4erSy1pwikKUVj3WkuZ5U= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/2] docs: update hyperlaunch device tree Date: Thu, 3 Aug 2023 06:44:37 -0400 Message-Id: <20230803104438.24720-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230803104438.24720-1-dpsmith@apertussolutions.com> References: <20230803104438.24720-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External With on going development of hyperlaunch, changes to the device tree definitions has been necessary. This commit updates the specification for all current changes along with changes expected to be made in finalizing the capability. This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places this documentation under its purview. It also reserves the path `xen/common/domain-builder` for the hyperlaunch domain builder code base. Signed-off-by: Daniel P. Smith --- MAINTAINERS | 9 + .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++-------- 2 files changed, 309 insertions(+), 266 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d8a02a6c19..694412a961 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -332,6 +332,15 @@ M: Nick Rosbrook S: Maintained F: tools/golang +HYPERLAUNCH +M: Daniel P. Smith +M: Christopher Clark +W: https://wiki.xenproject.org/wiki/Hyperlaunch +S: Supported +F: docs/design/launch/hyperlaunch.rst +F: docs/design/launch/hyperlaunch-devicetree.rst +F: xen/common/domain-builder/ + HYPFS M: Juergen Gross S: Supported diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst index b49c98cfbd..0bc719e4ae 100644 --- a/docs/designs/launch/hyperlaunch-devicetree.rst +++ b/docs/designs/launch/hyperlaunch-devicetree.rst @@ -2,10 +2,11 @@ Xen Hyperlaunch Device Tree Bindings ------------------------------------- -The Xen Hyperlaunch device tree adopts the dom0less device tree structure and -extends it to meet the requirements for the Hyperlaunch capability. The primary -difference is the introduction of the ``hypervisor`` node that is under the -``/chosen`` node. The move to a dedicated node was driven by: +The Xen Hyperlaunch device tree is informed by the dom0less device tree +structure with extensions to meet the requirements for the Hyperlaunch +capability. A major depature from the dom0less device tree is the introduction +of the ``hypervisor`` node that is under the ``/chosen`` node. The move to a +dedicated node was driven by: 1. Reduces the need to walk over nodes that are not of interest, e.g. only nodes of interest should be in ``/chosen/hypervisor`` @@ -13,331 +14,364 @@ difference is the introduction of the ``hypervisor`` node that is under the 2. Allows for the domain construction information to easily be sanitized by simple removing the ``/chosen/hypervisor`` node. -Example Configuration ---------------------- - -Below are two example device tree definitions for the hypervisor node. The -first is an example of a multiboot-based configuration for x86 and the second -is a module-based configuration for Arm. - -Multiboot x86 Configuration: -"""""""""""""""""""""""""""" - -:: - - hypervisor { - #address-cells = <1>; - #size-cells = <0>; - compatible = “hypervisor,xen†- - // Configuration container - config { - compatible = "xen,config"; - - module { - compatible = "module,microcode", "multiboot,module"; - mb-index = <1>; - }; - - module { - compatible = "module,xsm-policy", "multiboot,module"; - mb-index = <2>; - }; - }; - - // Boot Domain definition - domain { - compatible = "xen,domain"; - - domid = <0x7FF5>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0x00000001>; - - memory = <0x0 0x20000>; - cpus = <1>; - module { - compatible = "module,kernel", "multiboot,module"; - mb-index = <3>; - }; - - module { - compatible = "module,ramdisk", "multiboot,module"; - mb-index = <4>; - }; - module { - compatible = "module,config", "multiboot,module"; - mb-index = <5>; - }; - - // Classic Dom0 definition - domain { - compatible = "xen,domain"; - - domid = <0>; - - // PERMISSION_NONE (0) - // PERMISSION_CONTROL (1 << 0) - // PERMISSION_HARDWARE (1 << 1) - permissions = <3>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0xC0000006>; - - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ - mode = <5>; /* 64 BIT, PV */ - - // UUID - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; - - cpus = <1>; - memory = <0x0 0x20000>; - security-id = “dom0_t; - - module { - compatible = "module,kernel", "multiboot,module"; - mb-index = <6>; - bootargs = "console=hvc0"; - }; - module { - compatible = "module,ramdisk", "multiboot,module"; - mb-index = <7>; - }; - }; - -The multiboot modules supplied when using the above config would be, in order: +The Hypervisor node +------------------- -* (the above config, compiled) -* CPU microcode -* XSM policy -* kernel for boot domain -* ramdisk for boot domain -* boot domain configuration file -* kernel for the classic dom0 domain -* ramdisk for the classic dom0 domain +The ``hypervisor`` node is a top level container for all information relating +to how the hyperlaunch is to proceed. This includes definitions of the domains +that will be built by hypervisor on start up. The node will be named +``hypervisor`` with a ``compatible`` property to identify which hypervisors +the configuration is intended. The hypervisor node will consist of one or more +config nodes and one or more domain nodes. -Module Arm Configuration: -""""""""""""""""""""""""" +Properties +"""""""""" -:: +compatible + Identifies which hypervisors the configuration is compatible. Required. - hypervisor { - compatible = “hypervisor,xen†+ Format: "hypervisor,", e.g "hypervisor,xen" - // Configuration container - config { - compatible = "xen,config"; +Child Nodes +""""""""""" - module { - compatible = "module,microcodeâ€; - module-addr = <0x0000ff00 0x80>; - }; +* config +* domain - module { - compatible = "module,xsm-policy"; - module-addr = <0x0000ff00 0x80>; +Config Node +----------- - }; - }; +A ``config`` node is for passing configuration data and identifying any boot +modules that is of interest to the hypervisor. For example this would be where +Xen would be informed of microcode or XSM policy locations. Each ``config`` +node will require a unique device-tree compliant name as there may be one or +more ``config`` nodes present in a single dtb file. To identify which +hypervisor the configuration is intended, the required ``compatible`` property +must be present. - // Boot Domain definition - domain { - compatible = "xen,domain"; - - domid = <0x7FF5>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0x00000001>; - - memory = <0x0 0x20000>; - cpus = <1>; - module { - compatible = "module,kernel"; - module-addr = <0x0000ff00 0x80>; - }; +While the config node is not meant to replace the hypervisor commandline, there +may be cases where it is better suited for passing configuration details at +boot time. This additional information may be carried in properties assigned +to a ``config`` node. If there are any boot modules that are intended for the +hypervisor, then a ``module`` child node should be provided to identify the +boot module. - module { - compatible = "module,ramdisk"; - module-addr = <0x0000ff00 0x80>; - }; - module { - compatible = "module,config"; - module-addr = <0x0000ff00 0x80>; - }; +Properties +"""""""""" - // Classic Dom0 definition - domain@0 { - compatible = "xen,domain"; - - domid = <0>; - - // PERMISSION_NONE (0) - // PERMISSION_CONTROL (1 << 0) - // PERMISSION_HARDWARE (1 << 1) - permissions = <3>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) - functions = <0xC0000006>; - - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ - mode = <5>; /* 64 BIT, PV */ - - // UUID - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; - - cpus = <1>; - memory = <0x0 0x20000>; - security-id = “dom0_tâ€; - - module { - compatible = "module,kernel"; - module-addr = <0x0000ff00 0x80>; - bootargs = "console=hvc0"; - }; - module { - compatible = "module,ramdisk"; - module-addr = <0x0000ff00 0x80>; - }; - }; +compatible + Identifies the hypervisor the confiugration is intended. Required. -The modules that would be supplied when using the above config would be: + Format: ",config", e.g "xen,config" -* (the above config, compiled into hardware tree) -* CPU microcode -* XSM policy -* kernel for boot domain -* ramdisk for boot domain -* boot domain configuration file -* kernel for the classic dom0 domain -* ramdisk for the classic dom0 domain +bootargs + This is used to provide the boot params for Xen. -The hypervisor device tree would be compiled into the hardware device tree and -provided to Xen using the standard method currently in use. The remaining -modules would need to be loaded in the respective addresses specified in the -`module-addr` property. + Format: String, e.g. "flask=silo" +Child Nodes +""""""""""" -The Hypervisor node -------------------- +* module -The hypervisor node is a top level container for the domains that will be built -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` -property is used to identify the type of hypervisor node present.. +Domain Node +----------- -compatible - Identifies the type of node. Required. +A ``domain`` node is for describing the construction of a domain. Since there +may be one or more domain nodes, each one requires a unique, DTB compliant name +and a ``compatible`` property to identify as a domain node. -The Config node ---------------- +A ``domain`` node may provide a ``domid`` property which will be used as the +requested domain id for the domain with a value of “0†signifying to use the +next available domain id, which is the default behavior if omitted. It should +be noted that a domain configuration is not able to request a domid of “0â€. +Beyond that, a domain node may have any of the following optional properties. -A config node is for detailing any modules that are of interest to Xen itself. -For example this would be where Xen would be informed of microcode or XSM -policy locations. If the modules are multiboot modules and are able to be -located by index within the module chain, the ``mb-index`` property should be -used to specify the index in the multiboot module chain.. If the module will be -located by physical memory address, then the ``module-addr`` property should be -used to identify the location and size of the module. +Properties +"""""""""" compatible - Identifies the type of node. Required. - -The Domain node ---------------- + Identifies the node as a domain node and for which hypervisor. Required. -A domain node is for describing the construction of a domain. It may provide a -domid property which will be used as the requested domain id for the domain -with a value of “0†signifying to use the next available domain id, which is -the default behavior if omitted. A domain configuration is not able to request -a domid of “0â€. After that a domain node may have any of the following -parameters, - -compatible - Identifies the type of node. Required. + Format: ",domain", e.g "xen,domain" domid - Identifies the domid requested to assign to the domain. Required. + Identifies the domid requested to assign to the domain. -permissions + Format: Integer, e.g <0> + +role This sets what Discretionary Access Control permissions a domain is assigned. Optional, default is none. -functions - This identifies what system functions a domain will fulfill. + Format: Bitfield, e.g <3> or <0x00000003> + + ROLE_NONE (0) + ROLE_UNBOUNDED_DOMAIN (1U<<0) + ROLE_CONTROL_DOMAIN (1U<<1) + ROLE_HARDWARE_DOMAIN (1U<<2) + ROLE_XENSTORE_DOMAIN (1U<<3) + +capability + This identifies what system capabilities a domain may have beyond the role it + was assigned. Optional, the default is none. -.. note:: The `functions` bits that have been selected to indicate - ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits - (30, 31) such that should these features ever be fully retired, the flags may - be dropped without leaving a gap in the flag set. + Format: Bitfield, e.g <3221225487> or <0xC0000007> + + CAP_NONE (0) + CAP_CONSOLE_IO (1U<<0) mode The mode the domain will be executed under. Required. + Format: Bitfield, e.g <5> or <0x00000005> + + MODE_PARAVIRTUALIZED (1 << 0) PV | PVH/HVM + MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH + MODE_LONG (1 << 2) 64 BIT | 32 BIT + domain-uuid A globally unique identifier for the domain. Optional, the default is NULL. + Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] + cpus The number of vCPUs to be assigned to the domain. Optional, the default is “1â€. + Format: Integer, e.g <0> + memory - The amount of memory to assign to the domain, in KBs. + The amount of memory to assign to the domain, in KBs. This field uses a DTB + Reg which contains a start and size. For memory allocation start may or may + not have significance but size will always be used for the amount of memory Required. + Format: String min: | max: | , e.g. "256M" + security-id The security identity to be assigned to the domain when XSM is the access control mechanism being used. Optional, - the default is “domu_tâ€. + the default is “system_u:system_r:domU_tâ€. + + Format: string, e.g. "system_u:system_r:domU_t" + +Child Nodes +""""""""""" + +* module + +Module node +----------- -The Module node ---------------- +This node describes a boot module loaded by the boot loader. A ``module`` node +will often appear repeatedly and will require a unique and DTB compliant name +for each instance. The compatible property is required to identify that the +node is a ``module`` node, the type of boot module, and what it represents. -This node describes a boot module loaded by the boot loader. The required -compatible property follows the format: module, where type can be -“kernelâ€, “ramdiskâ€, “device-treeâ€, “microcodeâ€, “xsm-policy†or “configâ€. In -the case the module is a multiboot module, the additional property string -“multiboot,module†may be present. One of two properties is required and -identifies how to locate the module. They are the mb-index, used for multiboot -modules, and the module-addr for memory address based location. +Depending on the type of boot module, the ``module`` node will require either a +``module-index`` or ``module-addr`` property must be present. They provide the +boot module specific way of locating the boot module in memory. + +Properties +"""""""""" compatible This identifies what the module is and thus what the hypervisor should use the module for during domain construction. Required. -mb-index - This identifies the index for this module in the multiboot module chain. + Format: "module,"[, "module,"] + module type: kernel, ramdisk, device-tree, microcode, xsm-policy, + config + + locating type: index, addr + +module-index + This identifies the index for this module when in a module chain. Required for multiboot environments. + Format: Integer, e.g. <0> + module-addr This identifies where in memory this module is located. Required for non-multiboot environments. + Format: DTB Reg , e.g. <0x0 0x20000> + bootargs This is used to provide the boot params to kernel modules. + Format: String, e.g. "ro quiet" + .. note:: The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain. + +Example Configuration +--------------------- + +Below are two example device tree definitions for the hypervisor node. The +first is an example of a multiboot-based configuration for x86 and the second +is a module-based configuration for Arm. + +Multiboot x86 Configuration: +"""""""""""""""""""""""""""" + +:: + + /dts-v1/; + + / { + chosen { + hypervisor { + compatible = "hypervisor,xen", "xen,x86"; + + dom0 { + compatible = "xen,domain"; + + domid = <0>; + + role = <9>; + mode = <12>; + + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 13 F0 8C]; + + cpus = <1>; + memory = "1024M"; + + kernel { + compatible = "module,kernel", "module,index"; + module-index = <1>; + }; + + initrd { + compatible = "module,ramdisk", "module,index"; + module-index = <2>; + }; + }; + + dom1 { + compatible = "xen,domain"; + domid = <1>; + role = <0>; + capability = <1>; + mode = <12>; + domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 54 1A 74]; + cpus = <1>; + memory = "1024M"; + + kernel { + compatible = "module,kernel", "module,index"; + module-index = <3>; + bootargs = "console=hvc0 earlyprintk=xen root=/dev/ram0 rw"; + }; + + initrd { + compatible = "module,ramdisk", "module,index"; + module-index = <4>; + }; + }; + }; + }; + }; + + + +The multiboot modules supplied when using the above config would be, in order: + +* (the above config, compiled) +* kernel for PVH unbounded domain +* ramdisk for PVH unbounded domain +* kernel for PVH guest domain +* ramdisk for PVH guest domain + +Module Arm Configuration: +""""""""""""""""""""""""" + +:: + + /dts-v1/; + + / { + chosen { + hypervisor { + compatible = “hypervisor,xen†+ + // Configuration container + config { + compatible = "xen,config"; + + module { + compatible = "module,xsm-policy"; + module-addr = <0x0000ff00 0x80>; + + }; + }; + + // Unbounded Domain definition + dom0 { + compatible = "xen,domain"; + + domid = <0>; + + role = <9>; + + mode = <12>; /* 64 BIT, PVH */ + + memory = <0x0 0x20000>; + cpus = <1>; + module { + compatible = "module,kernel"; + module-addr = <0x0000ff00 0x80>; + }; + + module { + compatible = "module,ramdisk"; + module-addr = <0x0000ff00 0x80>; + }; + + // Guest definition + dom1 { + compatible = "xen,domain"; + + domid = <0>; + + role = <0>; + capability = <1>; + + mode = <12>; /* 64 BIT, PVH */ + + // UUID + domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 54 1A 74]; + + cpus = <1>; + memory = <0x0 0x20000>; + security-id = “dom0_tâ€; + + module { + compatible = "module,kernel"; + module-addr = <0x0000ff00 0x80>; + bootargs = "console=hvc0"; + }; + module { + compatible = "module,ramdisk"; + module-addr = <0x0000ff00 0x80>; + }; + }; + }; + }; + }; + +The modules that would be supplied when using the above config would be: + +* (the above config, compiled into hardware tree) +* XSM policy +* kernel for unbounded domain +* ramdisk for unbounded domain +* kernel for guest domain +* ramdisk for guest domain + +The hypervisor device tree would be compiled into the hardware device tree and +provided to Xen using the standard method currently in use. The remaining +modules would need to be loaded in the respective addresses specified in the +`module-addr` property. -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 10:45:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 10:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576257.902198 (Exim 4.92) (envelope-from ) id 1qRVpn-0007SA-Ga; Thu, 03 Aug 2023 10:45:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576257.902198; Thu, 03 Aug 2023 10:45:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVpn-0007S0-DV; Thu, 03 Aug 2023 10:45:35 +0000 Received: by outflank-mailman (input) for mailman id 576257; Thu, 03 Aug 2023 10:45:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVpm-0006R6-FV for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:45:34 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dddc5d67-31ea-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:45:32 +0200 (CEST) Delivered-To: dpsmith@apertussolutions.com Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691059489859266.14813489756693; Thu, 3 Aug 2023 03:44:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dddc5d67-31ea-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691059492; cv=none; d=zohomail.com; s=zohoarc; b=aqV+odTA/piZryJ1RNlX8srNIenVVyn7kqmZEo2Ou5ffwXNUMRJWxnlaFi4IcM4dmfZUPXnZAgxkZgDfi9TKKhdv+b7NqzKe2OeBoiHXvKc391mxHiDAgV5AA3BONVE1meTDzZI2UOkCXkojmVhsD67dsq4V2C+ylc8UGpnVNjc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691059492; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=J7499yaTk92ZTF+Y3RPSxthIKYwu2L2+YjjgPAOMoF8=; b=hWYuCKTNnNXnVPC7VrVhK6JG0gIWCTyLYS1eGw/+mflqBVQ/gqHyS4xvbANk3VpTWFmY7d2pquluVNmcxRJvjDQaY4QyJoOtWDdKKliyCF3X5GPNJBZA13QHDPyUqn7fP7ZsARvNnt+12kvDnEMzkjhbNF6WhB1Rj/YbnSyWjO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691059492; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=J7499yaTk92ZTF+Y3RPSxthIKYwu2L2+YjjgPAOMoF8=; b=aa7Bv6AvRpBeDjO4+OBL9CRK16n/miBWKuWn+MaRMzEpk1ByoYd5SCTdmpDD8L9Z raU+LLrQ37FgN+z/qiB3aP7U/uBlbzC64/EyO4LICu0YhAKKrAvqDtfJRsRhlfVPUIQ vjoqhtLagSuBWggDRFUPAHiNrrZHGBgf6ZryfWfA= From: "Daniel P. Smith" To: Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Date: Thu, 3 Aug 2023 06:44:38 -0400 Message-Id: <20230803104438.24720-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230803104438.24720-1-dpsmith@apertussolutions.com> References: <20230803104438.24720-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch. Signed-off-by: Daniel P. Smith --- MAINTAINERS | 8 +- xen/arch/arm/bootfdt.c | 141 +--------------------------- xen/arch/arm/domain_build.c | 1 + xen/arch/arm/include/asm/setup.h | 6 -- xen/common/Kconfig | 4 + xen/common/Makefile | 3 +- xen/common/fdt.c | 153 +++++++++++++++++++++++++++++++ xen/include/xen/device_tree.h | 50 +--------- xen/include/xen/fdt.h | 79 ++++++++++++++++ 9 files changed, 246 insertions(+), 199 deletions(-) create mode 100644 xen/common/fdt.c create mode 100644 xen/include/xen/fdt.h diff --git a/MAINTAINERS b/MAINTAINERS index 694412a961..ad684a2148 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -299,11 +299,13 @@ DEVICE TREE M: Stefano Stabellini M: Julien Grall S: Supported -F: xen/common/libfdt/ F: xen/common/device_tree.c -F: xen/include/xen/libfdt/ -F: xen/include/xen/device_tree.h +F: xen/common/fdt.c +F: xen/common/libfdt/ F: xen/drivers/passthrough/device_tree.c +F: xen/include/xen/device_tree.h +F: xen/include/xen/fdt.h +F: xen/include/xen/libfdt/ ECLAIR R: Simone Ballarin diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 2673ad17a1..cdf4f17789 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -12,79 +12,11 @@ #include #include #include +#include #include #include #include -static bool __init device_tree_node_matches(const void *fdt, int node, - const char *match) -{ - const char *name; - size_t match_len; - - name = fdt_get_name(fdt, node, NULL); - match_len = strlen(match); - - /* Match both "match" and "match@..." patterns but not - "match-foo". */ - return strncmp(name, match, match_len) == 0 - && (name[match_len] == '@' || name[match_len] == '\0'); -} - -static bool __init device_tree_node_compatible(const void *fdt, int node, - const char *match) -{ - int len, l; - const void *prop; - - prop = fdt_getprop(fdt, node, "compatible", &len); - if ( prop == NULL ) - return false; - - while ( len > 0 ) { - if ( !dt_compat_cmp(prop, match) ) - return true; - l = strlen(prop) + 1; - prop += l; - len -= l; - } - - return false; -} - -void __init device_tree_get_reg(const __be32 **cell, uint32_t address_cells, - uint32_t size_cells, paddr_t *start, - paddr_t *size) -{ - uint64_t dt_start, dt_size; - - /* - * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit. - * Thus, there is an implicit cast from uint64_t to paddr_t. - */ - dt_start = dt_next_cell(address_cells, cell); - dt_size = dt_next_cell(size_cells, cell); - - if ( dt_start != (paddr_t)dt_start ) - { - printk("Physical address greater than max width supported\n"); - WARN(); - } - - if ( dt_size != (paddr_t)dt_size ) - { - printk("Physical size greater than max width supported\n"); - WARN(); - } - - /* - * Xen will truncate the address/size if it is greater than the maximum - * supported width and it will give an appropriate warning. - */ - *start = dt_start; - *size = dt_size; -} - static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, @@ -135,77 +67,6 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, return 0; } -u32 __init device_tree_get_u32(const void *fdt, int node, - const char *prop_name, u32 dflt) -{ - const struct fdt_property *prop; - - prop = fdt_get_property(fdt, node, prop_name, NULL); - if ( !prop || prop->len < sizeof(u32) ) - return dflt; - - return fdt32_to_cpu(*(uint32_t*)prop->data); -} - -/** - * device_tree_for_each_node - iterate over all device tree sub-nodes - * @fdt: flat device tree. - * @node: parent node to start the search from - * @func: function to call for each sub-node. - * @data: data to pass to @func. - * - * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored. - * - * Returns 0 if all nodes were iterated over successfully. If @func - * returns a value different from 0, that value is returned immediately. - */ -int __init device_tree_for_each_node(const void *fdt, int node, - device_tree_node_func func, - void *data) -{ - /* - * We only care about relative depth increments, assume depth of - * node is 0 for simplicity. - */ - int depth = 0; - const int first_node = node; - u32 address_cells[DEVICE_TREE_MAX_DEPTH]; - u32 size_cells[DEVICE_TREE_MAX_DEPTH]; - int ret; - - do { - const char *name = fdt_get_name(fdt, node, NULL); - u32 as, ss; - - if ( depth >= DEVICE_TREE_MAX_DEPTH ) - { - printk("Warning: device tree node `%s' is nested too deep\n", - name); - continue; - } - - as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT; - ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT; - - address_cells[depth] = device_tree_get_u32(fdt, node, - "#address-cells", as); - size_cells[depth] = device_tree_get_u32(fdt, node, - "#size-cells", ss); - - /* skip the first node */ - if ( node != first_node ) - { - ret = func(fdt, node, name, depth, as, ss, data); - if ( ret != 0 ) - return ret; - } - - node = fdt_next_node(fdt, node, &depth); - } while ( node >= 0 && depth > 0 ); - - return 0; -} - static int __init process_memory_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 39b4ee03a5..7bd6c009d1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 19dc637d55..ae2bfcc7e6 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -159,12 +159,6 @@ const char *boot_module_kind_as_string(bootmodule_kind kind); extern uint32_t hyp_traps_vector[]; void init_traps(void); -void device_tree_get_reg(const __be32 **cell, uint32_t address_cells, - uint32_t size_cells, paddr_t *start, paddr_t *size); - -u32 device_tree_get_u32(const void *fdt, int node, - const char *prop_name, u32 dflt); - int map_range_to_domain(const struct dt_device_node *dev, uint64_t addr, uint64_t len, void *data); diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0d248ab941..e2fdb3cbc3 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -38,8 +38,12 @@ config HAS_ALTERNATIVE config HAS_COMPAT bool +config CORE_DEVICE_TREE + bool + config HAS_DEVICE_TREE bool + select CORE_DEVICE_TREE config HAS_EX_TABLE bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 46049eac35..fd3769e1c6 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -11,6 +11,7 @@ obj-y += domain.o obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o +obj-$(CONFIG_CORE_DEVICE_TREE) += fdt.o obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += guestcopy.o @@ -75,7 +76,7 @@ obj-y += sched/ obj-$(CONFIG_UBSAN) += ubsan/ obj-$(CONFIG_NEEDS_LIBELF) += libelf/ -obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ +obj-$(CONFIG_CORE_DEVICE_TREE) += libfdt/ CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(objtree)/)$(KCONFIG_CONFIG) $(obj)/config.gz: $(CONF_FILE) diff --git a/xen/common/fdt.c b/xen/common/fdt.c new file mode 100644 index 0000000000..8d7acaaa43 --- /dev/null +++ b/xen/common/fdt.c @@ -0,0 +1,153 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012-2014 Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ +#include +#include +#include +#include +#include + +bool __init device_tree_node_matches( + const void *fdt, int node, const char *match) +{ + const char *name; + size_t match_len; + + name = fdt_get_name(fdt, node, NULL); + match_len = strlen(match); + + /* Match both "match" and "match@..." patterns but not + "match-foo". */ + return strncmp(name, match, match_len) == 0 + && (name[match_len] == '@' || name[match_len] == '\0'); +} + +bool __init device_tree_node_compatible( + const void *fdt, int node, const char *match) +{ + int len, l; + const void *prop; + + prop = fdt_getprop(fdt, node, "compatible", &len); + if ( prop == NULL ) + return false; + + while ( len > 0 ) { + if ( !dt_compat_cmp(prop, match) ) + return true; + l = strlen(prop) + 1; + prop += l; + len -= l; + } + + return false; +} + +void __init device_tree_get_reg( + const __be32 **cell, uint32_t address_cells, uint32_t size_cells, + paddr_t *start, paddr_t *size) +{ + uint64_t dt_start, dt_size; + + /* + * dt_next_cell will return uint64_t whereas paddr_t may not be 64-bit. + * Thus, there is an implicit cast from uint64_t to paddr_t. + */ + dt_start = dt_next_cell(address_cells, cell); + dt_size = dt_next_cell(size_cells, cell); + + if ( dt_start != (paddr_t)dt_start ) + { + printk("Physical address greater than max width supported\n"); + WARN(); + } + + if ( dt_size != (paddr_t)dt_size ) + { + printk("Physical size greater than max width supported\n"); + WARN(); + } + + /* + * Xen will truncate the address/size if it is greater than the maximum + * supported width and it will give an appropriate warning. + */ + *start = dt_start; + *size = dt_size; +} + +u32 __init device_tree_get_u32( + const void *fdt, int node, const char *prop_name, u32 dflt) +{ + const struct fdt_property *prop; + + prop = fdt_get_property(fdt, node, prop_name, NULL); + if ( !prop || prop->len < sizeof(u32) ) + return dflt; + + return fdt32_to_cpu(*(uint32_t*)prop->data); +} + +/** + * device_tree_for_each_node - iterate over all device tree sub-nodes + * @fdt: flat device tree. + * @node: parent node to start the search from + * @func: function to call for each sub-node. + * @data: data to pass to @func. + * + * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored. + * + * Returns 0 if all nodes were iterated over successfully. If @func + * returns a value different from 0, that value is returned immediately. + */ +int __init device_tree_for_each_node( + const void *fdt, int node, device_tree_node_func func, void *data) +{ + /* + * We only care about relative depth increments, assume depth of + * node is 0 for simplicity. + */ + int depth = 0; + const int first_node = node; + u32 address_cells[DEVICE_TREE_MAX_DEPTH]; + u32 size_cells[DEVICE_TREE_MAX_DEPTH]; + int ret; + + do { + const char *name = fdt_get_name(fdt, node, NULL); + u32 as, ss; + + if ( depth >= DEVICE_TREE_MAX_DEPTH ) + { + printk("Warning: device tree node `%s' is nested too deep\n", + name); + continue; + } + + as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT; + ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT; + + address_cells[depth] = device_tree_get_u32(fdt, node, + "#address-cells", as); + size_cells[depth] = device_tree_get_u32(fdt, node, + "#size-cells", ss); + + /* skip the first node */ + if ( node != first_node ) + { + ret = func(fdt, node, name, depth, as, ss, data); + if ( ret != 0 ) + return ret; + } + + node = fdt_next_node(fdt, node, &depth); + } while ( node >= 0 && depth > 0 ); + + return 0; +} diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 1d79e23b28..82db38b140 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -14,13 +14,12 @@ #include #include #include +#include #include #include #include #include -#define DEVICE_TREE_MAX_DEPTH 16 - /* * Struct used for matching a device */ @@ -159,17 +158,8 @@ struct dt_raw_irq { u32 specifier[DT_MAX_IRQ_SPEC]; }; -typedef int (*device_tree_node_func)(const void *fdt, - int node, const char *name, int depth, - u32 address_cells, u32 size_cells, - void *data); - extern const void *device_tree_flattened; -int device_tree_for_each_node(const void *fdt, int node, - device_tree_node_func func, - void *data); - /** * dt_unflatten_host_device_tree - Unflatten the host device tree * @@ -214,14 +204,6 @@ extern const struct dt_device_node *dt_interrupt_controller; struct dt_device_node * dt_find_interrupt_controller(const struct dt_device_match *matches); -#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) -#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) -#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) - -/* Default #address and #size cells */ -#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 -#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 - #define dt_for_each_property_node(dn, pp) \ for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) @@ -231,16 +213,6 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); #define dt_for_each_child_node(dt, dn) \ for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling ) -/* Helper to read a big number; size is in cells (not bytes) */ -static inline u64 dt_read_number(const __be32 *cell, int size) -{ - u64 r = 0; - - while ( size-- ) - r = (r << 32) | be32_to_cpu(*(cell++)); - return r; -} - /* Wrapper for dt_read_number() to return paddr_t (instead of uint64_t) */ static inline paddr_t dt_read_paddr(const __be32 *cell, int size) { @@ -268,26 +240,6 @@ static inline paddr_t dt_read_paddr(const __be32 *cell, int size) return r; } -/* Helper to convert a number of cells to bytes */ -static inline int dt_cells_to_size(int size) -{ - return (size * sizeof (u32)); -} - -/* Helper to convert a number of bytes to cells, rounds down */ -static inline int dt_size_to_cells(int bytes) -{ - return (bytes / sizeof(u32)); -} - -static inline u64 dt_next_cell(int s, const __be32 **cellp) -{ - const __be32 *p = *cellp; - - *cellp = p + s; - return dt_read_number(p, s); -} - static inline const char *dt_node_full_name(const struct dt_device_node *np) { return (np && np->full_name) ? np->full_name : ""; diff --git a/xen/include/xen/fdt.h b/xen/include/xen/fdt.h new file mode 100644 index 0000000000..00ae6a5c8b --- /dev/null +++ b/xen/include/xen/fdt.h @@ -0,0 +1,79 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012 Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ +#ifndef __XEN_FDT_H__ +#define __XEN_FDT_H__ + +#include +#include +#include + +#define DEVICE_TREE_MAX_DEPTH 16 + +/* Default #address and #size cells */ +#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 +#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 + +#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) +#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) +#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) + +/* Helper to read a big number; size is in cells (not bytes) */ +static inline u64 dt_read_number(const __be32 *cell, int size) +{ + u64 r = 0; + + while ( size-- ) + r = (r << 32) | be32_to_cpu(*(cell++)); + return r; +} + +/* Helper to convert a number of cells to bytes */ +static inline int dt_cells_to_size(int size) +{ + return (size * sizeof (u32)); +} + +/* Helper to convert a number of bytes to cells, rounds down */ +static inline int dt_size_to_cells(int bytes) +{ + return (bytes / sizeof(u32)); +} + +static inline u64 dt_next_cell(int s, const __be32 **cellp) +{ + const __be32 *p = *cellp; + + *cellp = p + s; + return dt_read_number(p, s); +} + + +bool device_tree_node_matches( + const void *fdt, int node, const char *match); + +bool device_tree_node_compatible( + const void *fdt, int node, const char *match); + +void device_tree_get_reg( + const __be32 **cell, u32 address_cells, u32 size_cells, u64 *start, + u64 *size); + +u32 device_tree_get_u32( + const void *fdt, int node, const char *prop_name, u32 dflt); + +typedef int (*device_tree_node_func)( + const void *fdt, int node, const char *name, int depth, u32 address_cells, + u32 size_cells, void *data); + +int device_tree_for_each_node( + const void *fdt, int node, device_tree_node_func func, void *data); + + +#endif /* __XEN_FDT_H__ */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 11:45:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 11:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576267.902208 (Exim 4.92) (envelope-from ) id 1qRWla-0005h3-Om; Thu, 03 Aug 2023 11:45:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576267.902208; Thu, 03 Aug 2023 11:45:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWla-0005gw-KF; Thu, 03 Aug 2023 11:45:18 +0000 Received: by outflank-mailman (input) for mailman id 576267; Thu, 03 Aug 2023 11:45:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWlZ-0005gq-4K for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 11:45:17 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20630.outbound.protection.outlook.com [2a01:111:f400:7e88::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34f57335-31f3-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 13:45:14 +0200 (CEST) Received: from MW4PR04CA0143.namprd04.prod.outlook.com (2603:10b6:303:84::28) by PH0PR12MB8822.namprd12.prod.outlook.com (2603:10b6:510:28d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 11:45:10 +0000 Received: from CO1NAM11FT097.eop-nam11.prod.protection.outlook.com (2603:10b6:303:84:cafe::94) by MW4PR04CA0143.outlook.office365.com (2603:10b6:303:84::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 3 Aug 2023 11:45:10 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT097.mail.protection.outlook.com (10.13.175.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.39 via Frontend Transport; Thu, 3 Aug 2023 11:45:09 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 06:45:08 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 06:45:08 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 06:45:06 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34f57335-31f3-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ecLJks8nZLCKArJCOHq2ujcIQLhnw+8cFrvryAwSr/B/gKbpVrTQzv5xmcPfO14G/B93c/9D688ravyY1ryO1PedAfeiRIZ9inviJTbA0u37F7rxuvMpqkh5mhtt84G6l1LKmVNFa8forqSq+S5M9XNkrTO+xHQowQWXWZu/j0iaBfD1V7p9PPVKOZ21kraypZrnZKT5Ys6KnTS8kf3u9LDZxxNwBXs4d6D16RJkRlZndLJeIZuDZlFi1F3dAGDSg/fzeYPbnpIIpzAjfgQnAlbHV2cVeDeHsTiNpZzx9xjtSAIPHZFLMYCfuZL94Kvb2+kht2pUUEswzlB1D2fShw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4jFaJzUg551tZWmkn3AOVmjvfu748N+LQ5EQgCqAtsQ=; b=VBiWt1ahoJEM9R6HA2U0OcuXSwdIhDNAiwMhoXnvs0Vf/jXhUPFqLDxTNXn68lUE3c/c0wStmxm0O6M0OWlbYNsAgw1t+8eZJPUkGj1rLcemzdGRycY7lHyqX7nMng8G5O9aa5Fdj6GtQruk8qWg421/SXOwIZu7p+f6SXlxV/TWu1568h0aUFYseGK3DcVDwahS2nvmsvGwQeuM9XbNHUXZjkZkCTkWOtAw+nBDtu42qE1EmgkRVPCVxEwmxzNRGE1i/0xnJdHBKB8W363ulqM1yR0wJbFU34NDQxSdpTV4hiaD/VxgRCPmYYjpfNuCa4TEkuV/fpDj0i6wo7lIJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4jFaJzUg551tZWmkn3AOVmjvfu748N+LQ5EQgCqAtsQ=; b=kvLCQS2dlamNBpnwx1kg15fpOK/ziLcUHGO+e8PTsC9tY7i0t8i7g/H1HlbYoESUnOUGNwV8deG1j84fCxs9RNbLsTFxdX0oAEL8Bg597nKRma0dLISNAbceZEtRZyqWGpG7RmG5fQAaB/kxP7bWB2u4BaV9Xb5Mr2ahVF2xuKM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 3 Aug 2023 13:45:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: "Daniel P. Smith" , CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> From: Michal Orzel In-Reply-To: <20230803104438.24720-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT097:EE_|PH0PR12MB8822:EE_ X-MS-Office365-Filtering-Correlation-Id: d2de6af3-6218-44b8-c458-08db9417174e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4H0DW4atyqqC7Hk65CXdQVC4pWCo3fEZ0CVLlQUJ23wRPjUfqtxwytwjnoiKtpNEceE0Up14Faf9QgwQ5uEohXt8PL3VSX0tGhp05FCmbaPUzjpHm/Lha5NPUwumvep87k11d1txv3RtUscbzUaE+7u2PQW5ioK9tBDFW9d0tfMbWwxZayjpMvw3Ih4H1EWYi8p8dGrIbxHYaeNfxE9/R2ig5C6B7FeHYiWQfFTgQtuS/c3S3J1QpNfCCZrNZ5CNakDcSP8ynBImqV2DonQtUQWBgRCm3sNuLVSyYxQqwywXu58W+HqLyQS4mkoeNhuYVy11W8vbSt2tS3z7sCWcaNqyH93e7MMZj+fMasRojVxNCwChYN8x152wxzBjVs9LgRfeLyHOTAIujMkOPnm1fCllh+kcUyOUuMNx9IytE8P6/+/hTx5yywujqB+e2nLOX6XRTPUB1eJW0uFFgYmnl/rJwX2zyBYZ/33kNOGSSz6osm9o/hUqhzpcNg7DYRUGyFNh+bcubQSg9cMdtTkFTWlHl2pMZ5YBE5WqL/FOaOVH9R7tTaufa5HA1XqQuPRnPX7kOlpsH2X03WiOBy7F6bbdGvn1LT+lsp5PfUWTLpRLbfQnVI20UFYxiwvETlY0kfc3H8obuu0mecGUPFOMEiCOHv+SiTnQhtfyIJEsl8Jc6cCW7wUGMovAhLFhnVdhZ63VYWMP77Fgj+PZkY71SQ5AGA8OM4Bf0DsQ7NG11pMIsLYCKMGl/pCdoMAdyJPeK+x6JTZTlCjDzUbJFFdKTlo0hm6bodSEknlp3cEJjys= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(82310400008)(451199021)(40470700004)(46966006)(36840700001)(40460700003)(426003)(2616005)(336012)(53546011)(83380400001)(26005)(186003)(47076005)(41300700001)(36860700001)(16576012)(30864003)(70586007)(2906002)(70206006)(4326008)(5660300002)(316002)(44832011)(8676002)(8936002)(15650500001)(966005)(478600001)(54906003)(110136005)(40480700001)(356005)(81166007)(31696002)(86362001)(36756003)(31686004)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 11:45:09.7535 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2de6af3-6218-44b8-c458-08db9417174e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT097.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8822 Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: > > > With on going development of hyperlaunch, changes to the device tree definitions > has been necessary. This commit updates the specification for all current changes > along with changes expected to be made in finalizing the capability. > > This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places > this documentation under its purview. It also reserves the path > `xen/common/domain-builder` for the hyperlaunch domain builder code base. > > Signed-off-by: Daniel P. Smith > --- > MAINTAINERS | 9 + > .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++-------- > 2 files changed, 309 insertions(+), 266 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d8a02a6c19..694412a961 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -332,6 +332,15 @@ M: Nick Rosbrook > S: Maintained > F: tools/golang > > +HYPERLAUNCH > +M: Daniel P. Smith > +M: Christopher Clark > +W: https://wiki.xenproject.org/wiki/Hyperlaunch > +S: Supported > +F: docs/design/launch/hyperlaunch.rst > +F: docs/design/launch/hyperlaunch-devicetree.rst > +F: xen/common/domain-builder/ > + > HYPFS > M: Juergen Gross > S: Supported > diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst > index b49c98cfbd..0bc719e4ae 100644 > --- a/docs/designs/launch/hyperlaunch-devicetree.rst > +++ b/docs/designs/launch/hyperlaunch-devicetree.rst > @@ -2,10 +2,11 @@ > Xen Hyperlaunch Device Tree Bindings > ------------------------------------- > > -The Xen Hyperlaunch device tree adopts the dom0less device tree structure and > -extends it to meet the requirements for the Hyperlaunch capability. The primary > -difference is the introduction of the ``hypervisor`` node that is under the > -``/chosen`` node. The move to a dedicated node was driven by: > +The Xen Hyperlaunch device tree is informed by the dom0less device tree > +structure with extensions to meet the requirements for the Hyperlaunch > +capability. A major depature from the dom0less device tree is the introduction > +of the ``hypervisor`` node that is under the ``/chosen`` node. The move to a > +dedicated node was driven by: > > 1. Reduces the need to walk over nodes that are not of interest, e.g. only > nodes of interest should be in ``/chosen/hypervisor`` > @@ -13,331 +14,364 @@ difference is the introduction of the ``hypervisor`` node that is under the > 2. Allows for the domain construction information to easily be sanitized by > simple removing the ``/chosen/hypervisor`` node. > > -Example Configuration > ---------------------- > - > -Below are two example device tree definitions for the hypervisor node. The > -first is an example of a multiboot-based configuration for x86 and the second > -is a module-based configuration for Arm. > - > -Multiboot x86 Configuration: > -"""""""""""""""""""""""""""" > - > -:: > - > - hypervisor { > - #address-cells = <1>; > - #size-cells = <0>; > - compatible = “hypervisor,xen†> - > - // Configuration container > - config { > - compatible = "xen,config"; > - > - module { > - compatible = "module,microcode", "multiboot,module"; > - mb-index = <1>; > - }; > - > - module { > - compatible = "module,xsm-policy", "multiboot,module"; > - mb-index = <2>; > - }; > - }; > - > - // Boot Domain definition > - domain { > - compatible = "xen,domain"; > - > - domid = <0x7FF5>; > - > - // FUNCTION_NONE (0) > - // FUNCTION_BOOT (1 << 0) > - // FUNCTION_CRASH (1 << 1) > - // FUNCTION_CONSOLE (1 << 2) > - // FUNCTION_XENSTORE (1 << 30) > - // FUNCTION_LEGACY_DOM0 (1 << 31) > - functions = <0x00000001>; > - > - memory = <0x0 0x20000>; > - cpus = <1>; > - module { > - compatible = "module,kernel", "multiboot,module"; > - mb-index = <3>; > - }; > - > - module { > - compatible = "module,ramdisk", "multiboot,module"; > - mb-index = <4>; > - }; > - module { > - compatible = "module,config", "multiboot,module"; > - mb-index = <5>; > - }; > - > - // Classic Dom0 definition > - domain { > - compatible = "xen,domain"; > - > - domid = <0>; > - > - // PERMISSION_NONE (0) > - // PERMISSION_CONTROL (1 << 0) > - // PERMISSION_HARDWARE (1 << 1) > - permissions = <3>; > - > - // FUNCTION_NONE (0) > - // FUNCTION_BOOT (1 << 0) > - // FUNCTION_CRASH (1 << 1) > - // FUNCTION_CONSOLE (1 << 2) > - // FUNCTION_XENSTORE (1 << 30) > - // FUNCTION_LEGACY_DOM0 (1 << 31) > - functions = <0xC0000006>; > - > - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ > - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ > - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ > - mode = <5>; /* 64 BIT, PV */ > - > - // UUID > - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; > - > - cpus = <1>; > - memory = <0x0 0x20000>; > - security-id = “dom0_t; > - > - module { > - compatible = "module,kernel", "multiboot,module"; > - mb-index = <6>; > - bootargs = "console=hvc0"; > - }; > - module { > - compatible = "module,ramdisk", "multiboot,module"; > - mb-index = <7>; > - }; > - }; > - > -The multiboot modules supplied when using the above config would be, in order: > +The Hypervisor node > +------------------- > > -* (the above config, compiled) > -* CPU microcode > -* XSM policy > -* kernel for boot domain > -* ramdisk for boot domain > -* boot domain configuration file > -* kernel for the classic dom0 domain > -* ramdisk for the classic dom0 domain > +The ``hypervisor`` node is a top level container for all information relating > +to how the hyperlaunch is to proceed. This includes definitions of the domains > +that will be built by hypervisor on start up. The node will be named > +``hypervisor`` with a ``compatible`` property to identify which hypervisors > +the configuration is intended. The hypervisor node will consist of one or more > +config nodes and one or more domain nodes. > > -Module Arm Configuration: > -""""""""""""""""""""""""" > +Properties > +"""""""""" > > -:: > +compatible > + Identifies which hypervisors the configuration is compatible. Required. > > - hypervisor { > - compatible = “hypervisor,xen†> + Format: "hypervisor,", e.g "hypervisor,xen" > > - // Configuration container > - config { > - compatible = "xen,config"; > +Child Nodes > +""""""""""" > > - module { > - compatible = "module,microcodeâ€; > - module-addr = <0x0000ff00 0x80>; > - }; > +* config > +* domain > > - module { > - compatible = "module,xsm-policy"; > - module-addr = <0x0000ff00 0x80>; > +Config Node > +----------- > > - }; > - }; > +A ``config`` node is for passing configuration data and identifying any boot > +modules that is of interest to the hypervisor. For example this would be where > +Xen would be informed of microcode or XSM policy locations. Each ``config`` > +node will require a unique device-tree compliant name as there may be one or > +more ``config`` nodes present in a single dtb file. To identify which > +hypervisor the configuration is intended, the required ``compatible`` property > +must be present. > > - // Boot Domain definition > - domain { > - compatible = "xen,domain"; > - > - domid = <0x7FF5>; > - > - // FUNCTION_NONE (0) > - // FUNCTION_BOOT (1 << 0) > - // FUNCTION_CRASH (1 << 1) > - // FUNCTION_CONSOLE (1 << 2) > - // FUNCTION_XENSTORE (1 << 30) > - // FUNCTION_LEGACY_DOM0 (1 << 31) > - functions = <0x00000001>; > - > - memory = <0x0 0x20000>; > - cpus = <1>; > - module { > - compatible = "module,kernel"; > - module-addr = <0x0000ff00 0x80>; > - }; > +While the config node is not meant to replace the hypervisor commandline, there > +may be cases where it is better suited for passing configuration details at > +boot time. This additional information may be carried in properties assigned > +to a ``config`` node. If there are any boot modules that are intended for the > +hypervisor, then a ``module`` child node should be provided to identify the > +boot module. > > - module { > - compatible = "module,ramdisk"; > - module-addr = <0x0000ff00 0x80>; > - }; > - module { > - compatible = "module,config"; > - module-addr = <0x0000ff00 0x80>; > - }; > +Properties > +"""""""""" > > - // Classic Dom0 definition > - domain@0 { > - compatible = "xen,domain"; > - > - domid = <0>; > - > - // PERMISSION_NONE (0) > - // PERMISSION_CONTROL (1 << 0) > - // PERMISSION_HARDWARE (1 << 1) > - permissions = <3>; > - > - // FUNCTION_NONE (0) > - // FUNCTION_BOOT (1 << 0) > - // FUNCTION_CRASH (1 << 1) > - // FUNCTION_CONSOLE (1 << 2) > - // FUNCTION_XENSTORE (1 << 30) > - // FUNCTION_LEGACY_DOM0 (1 << 31) > - functions = <0xC0000006>; > - > - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ > - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ > - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ > - mode = <5>; /* 64 BIT, PV */ > - > - // UUID > - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; > - > - cpus = <1>; > - memory = <0x0 0x20000>; > - security-id = “dom0_tâ€; > - > - module { > - compatible = "module,kernel"; > - module-addr = <0x0000ff00 0x80>; > - bootargs = "console=hvc0"; > - }; > - module { > - compatible = "module,ramdisk"; > - module-addr = <0x0000ff00 0x80>; > - }; > - }; > +compatible > + Identifies the hypervisor the confiugration is intended. Required. > > -The modules that would be supplied when using the above config would be: > + Format: ",config", e.g "xen,config" > > -* (the above config, compiled into hardware tree) > -* CPU microcode > -* XSM policy > -* kernel for boot domain > -* ramdisk for boot domain > -* boot domain configuration file > -* kernel for the classic dom0 domain > -* ramdisk for the classic dom0 domain > +bootargs > + This is used to provide the boot params for Xen. > > -The hypervisor device tree would be compiled into the hardware device tree and > -provided to Xen using the standard method currently in use. The remaining > -modules would need to be loaded in the respective addresses specified in the > -`module-addr` property. > + Format: String, e.g. "flask=silo" > > +Child Nodes > +""""""""""" > > -The Hypervisor node > -------------------- > +* module > > -The hypervisor node is a top level container for the domains that will be built > -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` > -property is used to identify the type of hypervisor node present.. > +Domain Node > +----------- > > -compatible > - Identifies the type of node. Required. > +A ``domain`` node is for describing the construction of a domain. Since there > +may be one or more domain nodes, each one requires a unique, DTB compliant name > +and a ``compatible`` property to identify as a domain node. > > -The Config node > ---------------- > +A ``domain`` node may provide a ``domid`` property which will be used as the > +requested domain id for the domain with a value of “0†signifying to use the > +next available domain id, which is the default behavior if omitted. It should > +be noted that a domain configuration is not able to request a domid of “0â€. > +Beyond that, a domain node may have any of the following optional properties. > > -A config node is for detailing any modules that are of interest to Xen itself. > -For example this would be where Xen would be informed of microcode or XSM > -policy locations. If the modules are multiboot modules and are able to be > -located by index within the module chain, the ``mb-index`` property should be > -used to specify the index in the multiboot module chain.. If the module will be > -located by physical memory address, then the ``module-addr`` property should be > -used to identify the location and size of the module. > +Properties > +"""""""""" > > compatible > - Identifies the type of node. Required. > - > -The Domain node > ---------------- > + Identifies the node as a domain node and for which hypervisor. Required. > > -A domain node is for describing the construction of a domain. It may provide a > -domid property which will be used as the requested domain id for the domain > -with a value of “0†signifying to use the next available domain id, which is > -the default behavior if omitted. A domain configuration is not able to request > -a domid of “0â€. After that a domain node may have any of the following > -parameters, > - > -compatible > - Identifies the type of node. Required. > + Format: ",domain", e.g "xen,domain" > > domid > - Identifies the domid requested to assign to the domain. Required. > + Identifies the domid requested to assign to the domain. > > -permissions > + Format: Integer, e.g <0> > + > +role > This sets what Discretionary Access Control permissions > a domain is assigned. Optional, default is none. > > -functions > - This identifies what system functions a domain will fulfill. > + Format: Bitfield, e.g <3> or <0x00000003> > + > + ROLE_NONE (0) > + ROLE_UNBOUNDED_DOMAIN (1U<<0) > + ROLE_CONTROL_DOMAIN (1U<<1) > + ROLE_HARDWARE_DOMAIN (1U<<2) > + ROLE_XENSTORE_DOMAIN (1U<<3) > + > +capability > + This identifies what system capabilities a domain may have beyond the role it > + was assigned. > Optional, the default is none. > > -.. note:: The `functions` bits that have been selected to indicate > - ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits > - (30, 31) such that should these features ever be fully retired, the flags may > - be dropped without leaving a gap in the flag set. > + Format: Bitfield, e.g <3221225487> or <0xC0000007> > + > + CAP_NONE (0) > + CAP_CONSOLE_IO (1U<<0) > > mode > The mode the domain will be executed under. Required. > > + Format: Bitfield, e.g <5> or <0x00000005> > + > + MODE_PARAVIRTUALIZED (1 << 0) PV | PVH/HVM > + MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH > + MODE_LONG (1 << 2) 64 BIT | 32 BIT > + > domain-uuid > A globally unique identifier for the domain. Optional, > the default is NULL. > > + Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] > + > cpus > The number of vCPUs to be assigned to the domain. Optional, > the default is “1â€. > > + Format: Integer, e.g <0> > + > memory > - The amount of memory to assign to the domain, in KBs. > + The amount of memory to assign to the domain, in KBs. This field uses a DTB > + Reg which contains a start and size. For memory allocation start may or may > + not have significance but size will always be used for the amount of memory > Required. > > + Format: String min: | max: | , e.g. "256M" There is a mismatch between the description and above format: - KB vs MB - string vs reg format - the x86 example uses string and Arm uses reg format > + > security-id > The security identity to be assigned to the domain when XSM > is the access control mechanism being used. Optional, > - the default is “domu_tâ€. > + the default is “system_u:system_r:domU_tâ€. > + > + Format: string, e.g. "system_u:system_r:domU_t" This is specifying full label (as expected) whereas the examples use only type > + > +Child Nodes > +""""""""""" > + > +* module > + > +Module node > +----------- > > -The Module node > ---------------- > +This node describes a boot module loaded by the boot loader. A ``module`` node > +will often appear repeatedly and will require a unique and DTB compliant name > +for each instance. The compatible property is required to identify that the > +node is a ``module`` node, the type of boot module, and what it represents. > > -This node describes a boot module loaded by the boot loader. The required > -compatible property follows the format: module, where type can be > -“kernelâ€, “ramdiskâ€, “device-treeâ€, “microcodeâ€, “xsm-policy†or “configâ€. In > -the case the module is a multiboot module, the additional property string > -“multiboot,module†may be present. One of two properties is required and > -identifies how to locate the module. They are the mb-index, used for multiboot > -modules, and the module-addr for memory address based location. > +Depending on the type of boot module, the ``module`` node will require either a > +``module-index`` or ``module-addr`` property must be present. They provide the > +boot module specific way of locating the boot module in memory. > + > +Properties > +"""""""""" > > compatible > This identifies what the module is and thus what the hypervisor > should use the module for during domain construction. Required. > > -mb-index > - This identifies the index for this module in the multiboot module chain. > + Format: "module,"[, "module,"] > + module type: kernel, ramdisk, device-tree, microcode, xsm-policy, > + config > + > + locating type: index, addr > + > +module-index > + This identifies the index for this module when in a module chain. > Required for multiboot environments. > > + Format: Integer, e.g. <0> > + > module-addr > This identifies where in memory this module is located. Required for > non-multiboot environments. > > + Format: DTB Reg , e.g. <0x0 0x20000> I guess the number of cells for start and size will be taken from #address-celss and #size-cells defined either in /chosen or a config/domain node? Also, what is the plan for the existing dom0less dt properties? Will they need to be moved to new /hypervisor node or we will have to parse both /chosen and /hypervisor nodes? ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 03 11:46:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 11:46:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576269.902218 (Exim 4.92) (envelope-from ) id 1qRWmL-0006Bz-1w; Thu, 03 Aug 2023 11:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576269.902218; Thu, 03 Aug 2023 11:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWmK-0006Bs-Ve; Thu, 03 Aug 2023 11:46:04 +0000 Received: by outflank-mailman (input) for mailman id 576269; Thu, 03 Aug 2023 11:46:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWmK-0006Bk-8k for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 11:46:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWmJ-0004sS-0D; Thu, 03 Aug 2023 11:46:03 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRWmI-0002Wq-Pr; Thu, 03 Aug 2023 11:46:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=K/7UeQonLHoBscJp+e7PzRWE6gJnQ00GyYTSin8KOh0=; b=qarq0bVoQOGk0QzSg33fz5sZ99 +fP2gVk9gfzxHefcGVMgIMcXgpcWloV6kOsACRVbqDxoRkAzL2XBAZO0T/QsEg0TbOMthoHPCC5Of 6NOIxCTfeMSNiN49aggtMyMbw7iHbRV8JmDnF06M5b006hyGtqGPTHz0CrxFBgmWYhbQ=; Message-ID: Date: Thu, 3 Aug 2023 12:46:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names Content-Language: en-GB To: Luca Fancellu , Federico Serafini Cc: Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 03/08/2023 11:28, Luca Fancellu wrote: >> On 3 Aug 2023, at 09:26, Federico Serafini wrote: >> >> Add missing parameter names to address violation of MISRA C:2012 >> rule 8.2 ("Function types shall be in prototype form with named >> parameters"). >> >> No functional changes. >> >> Signed-off-by: Federico Serafini >> --- >> Changes in v2: >> - memset() adjusted. >> --- >> xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- >> 1 file changed, 21 insertions(+), 21 deletions(-) >> >> diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h >> index b4d2217a96..e91e3112e0 100644 >> --- a/xen/include/xen/string.h >> +++ b/xen/include/xen/string.h >> @@ -12,27 +12,27 @@ >> #define strncpy __xen_has_no_strncpy__ >> #define strncat __xen_has_no_strncat__ >> >> -size_t strlcpy(char *, const char *, size_t); >> -size_t strlcat(char *, const char *, size_t); >> -int strcmp(const char *, const char *); >> -int strncmp(const char *, const char *, size_t); >> -int strcasecmp(const char *, const char *); >> -int strncasecmp(const char *, const char *, size_t); >> -char *strchr(const char *, int); >> -char *strrchr(const char *, int); >> -char *strstr(const char *, const char *); >> -size_t strlen(const char *); >> -size_t strnlen(const char *, size_t); >> -char *strpbrk(const char *, const char *); >> -char *strsep(char **, const char *); >> -size_t strspn(const char *, const char *); >> - >> -void *memset(void *, int, size_t); >> -void *memcpy(void *, const void *, size_t); >> -void *memmove(void *, const void *, size_t); >> -int memcmp(const void *, const void *, size_t); >> -void *memchr(const void *, int, size_t); >> -void *memchr_inv(const void *, int, size_t); >> +size_t strlcpy(char *dest, const char *src, size_t size); >> +size_t strlcat(char *dest, const char *src, size_t size); >> +int strcmp(const char *cs, const char *ct); >> +int strncmp(const char *cs, const char *ct, size_t count); >> +int strcasecmp(const char *s1, const char *s2); >> +int strncasecmp(const char *s1, const char *s2, size_t len); >> +char *strchr(const char *s, int c); >> +char *strrchr(const char *s, int c); >> +char *strstr(const char *s1, const char *s2); >> +size_t strlen(const char *s); >> +size_t strnlen(const char *s, size_t count); >> +char *strpbrk(const char *cs, const char *ct); >> +char *strsep(char **s, const char *ct); >> +size_t strspn(const char *s, const char *accept); >> + >> +void *memset(void *s, int c, size_t count); >> +void *memcpy(void *dest, const void *src, size_t count); > > There is a comment in arch/arm/rm32/lib/memcpy.S with this: > /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ > >> +void *memmove(void *dest, const void *src, size_t count); > > There is a comment in arch/arm/rm32/lib/memmove.S with this: > * Prototype: void *memmove(void *dest, const void *src, size_t n); > >> +int memcmp(const void *cs, const void *ct, size_t count); >> +void *memchr(const void *s, int c, size_t n); >> +void *memchr_inv(const void *s, int c, size_t n); > > @Stefano: would it make sense to remove it as part of this patch or maybe not? They are a verbatim copy of the Linux code. So I would rather no touch it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 11:47:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 11:47:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576274.902228 (Exim 4.92) (envelope-from ) id 1qRWnU-0006pE-Hr; Thu, 03 Aug 2023 11:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576274.902228; Thu, 03 Aug 2023 11:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWnU-0006p7-Ek; Thu, 03 Aug 2023 11:47:16 +0000 Received: by outflank-mailman (input) for mailman id 576274; Thu, 03 Aug 2023 11:47:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWnT-0006ox-Dm for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 11:47:15 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2041.outbound.protection.outlook.com [40.107.7.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7d4bf67e-31f3-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 13:47:14 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VE1PR04MB7214.eurprd04.prod.outlook.com (2603:10a6:800:1a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 11:46:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 11:46:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d4bf67e-31f3-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z0EbneWhDqO8Y3Ja3Z0VNLIpnOD5Yp/gUHt9lbI5+EI6tJS6bnO55IyugVFrCtevPDNYOYV0FrIBg6/3+ZbIgH9bJur2WvBZtvMleSfh/O8alaultkuHk8SG0wZqmsUSFwV4lPh2+KfqEkI/fmcFk0QcM+Yhe5Ndm3hPmFXfyLfFi39olOVt8PDtxESbBGvlYoQiWLxCl7g/WrBCQmT/1YVHFG+MdwRVCfhFx6V8OnCG1Eg1oNJjGhaepHnmVXCQhDMIVp/7tHbtslKxKhMHvJjj52UPbC5GljTpfFUqpWd3c7+hUblkxQ9h256XnGhC1So7bbOx8tz8p9au2U89CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NYY449ATC3SaIKZ4g81JfOqzjstBdmRXd8vP3FsgYLU=; b=NnQ3d+wswwprSlqJV2Zs7JUKxUY+4BXwxqSW9qmf9bNhPEnT+gxzoVYWNzKVn1qmtNnCVGoEqaH3OlvVYPxIMWBSyA9Rk7Tc0XtWuNos7U5OY7rdmFjTab2dUIGz3NLm7cA2ArKbeRmZ3+jt3vIBtROuLg3TEadA/Tvj2XvJA2A2DpY8+ujWF9RBSCQ7iznI/1Qr2YfhO4a36QoW5gWRk1lCdnNIjVHSWEceBEqsinP3UgRgqMseYz/16W76Lmgxr9LPJncj9pwFUxf/UoHhG1RqMrORlaGEr/vJ4phTJjxXJlCIQMhP3Q/RObmrH3/PTMDSAQxF/afo5JkMrjTerA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NYY449ATC3SaIKZ4g81JfOqzjstBdmRXd8vP3FsgYLU=; b=Y/5fT8QYc84lhWZ3vhv/jvvncQad6Fvx6ZP5P/pJXWMo3FpzDMoeQdyakutZ4hJPk8cO03cNbnmywup37WsexABoRmtAyerC4yQxIPXlKFPv9xiIch/13105jtblekXdTk1Z7qAViG+KCnvx37RFJBJn1doQYMCXt3QCWmUEeLD7jS72pyolj1j/3letKi0SG28mx8OLq+gkw7bk8u3Rza44y6aB8VyOn979GvG4cVuF/JsJrOyEEZOE/p4zOF/+24hOoxJbM84HnXrtQ2Y0aU9DTjbVxKb1EIr4qGOb7S07BwNIELrJIQA66GFnoorRWKSARpqmaa//d3k3KkPo/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <97527049-e3ac-9d8e-806c-2204ed7f68dd@suse.com> Date: Thu, 3 Aug 2023 13:46:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Ping: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}() Content-Language: en-US To: Paul Durrant Cc: "xen-devel@lists.xenproject.org" , Nicola Vetrini , Stefano Stabellini References: <32e33a0b-d572-ea7f-b1a8-3263711582e5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VE1PR04MB7214:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d941830-8c41-479c-8e23-08db94174fa4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n6K7uTpl9UPLOZaF/mUX0kNNOXGa35VpVNstLNJb0t/Ef/iYnD6MfPmaleuXhC1k2hipKtXKEbcLECEkvQi+FfZp4V8euWHTz8X7zoNIiaaCBrzx0xc4f1ZypbUbSeeTQSGgJEU4BwIOwvWfW4HpBq0o5YjeWLVoyXxkt1l7DSXPzCMFMlfW1L8LL+97ZnnMqJ0UkxUcKOpkFDIXL+MQzvDNg15ruEadgICHR0zav0qFmAH7yRzmNnT7m9CCLJ58EShyztGkq3jUZxHMjY0WQLsGZOw1PwZwioygKcb+1qSx5zWvXs2S581Dx1lEdY9I/H0yV22/gJkjs3pcU8ld0TqkH4jmApA0pEusz3dG6gCa1C6D0a+jf19a93OZM/9qh+4B9Y1SjeGwQewgbnZ2qYBLJEMfYWzwkuCjChOx91lGArsSQqMyT37qXK8LLcTb+1OSCqGwhT48dTUlr335GZSapy2RvDb4ndPJVlEX4ileHedQ8u+jVd3wfQq2CSwcPPgQEoX2lsx10apm+51Jp086t26FA/oQD3+mgMJtno/mkvPmSoZjwxL6wF3a5OYkzPOwiecJCvRVDWHyVL3FdUmr+rjHyQRmxByeem2xuhSKUmYStHE1dmc0Dn6kyRuEMTn2NcVqBTH9W1OvDEqQwA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(36756003)(31696002)(86362001)(31686004)(54906003)(478600001)(38100700002)(2616005)(6506007)(186003)(26005)(53546011)(8676002)(8936002)(41300700001)(6512007)(6486002)(6916009)(316002)(4744005)(66476007)(66556008)(5660300002)(4326008)(66946007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkdocHVJeWo3ZU9YTzBtM25vc2wrUitHdXNxMUU2SVViVnBaYXl2ZkdjNGhI?= =?utf-8?B?MEQwUENHc2lFY0h1eVRVVnNCU0hZdEFaTThpY01FVXlnOHNjWUorY1dFdjhw?= =?utf-8?B?NTVSdmVOUUhoTms4VWJveEtNdGthdXZHeFQxeWQyakkyb2Q4S2dyOWE3WjB3?= =?utf-8?B?Rlh1KzRLQmR1U1p1ZEZpZ0xIUStPaVdxbDcvVFo3YnVqNEUxcmdPejFwdDVy?= =?utf-8?B?SXA4Rkl2aDBOam9JbzhLMHdwQ2hVVUxuaU5IVk9ucEVRdXdwUGdveFg0c1Jy?= =?utf-8?B?SkFrYitFRzVieGZaam5sa2tlOEhmZjFWaTNKNG1PWjZyUG5NTEs0djJDOFFn?= =?utf-8?B?ZEdEWlEydUhmdjNFMStiSVpzZDRUMElINS9lQU91QmhQRW54aUFHajNqVll5?= =?utf-8?B?QzllRE5RYXhtcnBXbGtqNUlpdldBa2dXdWlNT0NOS0NqVDRaRUFtZ0lZU1J3?= =?utf-8?B?MjJ0SkxEbnN6NzRiTlRUU2xJM1VkUlVueVh0S2JGQTZKbzEvNit2d2t6Q0pT?= =?utf-8?B?b1JpNE91N20rVlNBb2kwRFFPckduZjhRdlBKUmlqN0dNTG5tbDA5amJsanNm?= =?utf-8?B?MmhlMURQT3E3YmEzeVl6T0dYSnh6MjE3SStNdDlUUU9rTVd0dkllOGN6aTky?= =?utf-8?B?eXZlNUNCVXhlaXUxcGFreitXK3NuSmwwblZ0dktLanlPVXBmdUZ5TTVSR1kx?= =?utf-8?B?YVdmK1Nidm9KQS9uaEx6MDJ0RmxIY0RXN25nS1pRM0hTdnVCZldVL0kyY1NN?= =?utf-8?B?TmJLckJiaG42Mnh5d2U2QU1hU3EvcldCalZoWGZNVkdwZC8vWHRxeU5CMUp5?= =?utf-8?B?SEl3UDd2UzZ4WitvZGJEa2IyZitDM3hoSU1vV213ZnREWGdvcFJzY3Q2VDJP?= =?utf-8?B?WDZvbzd0WndWQXI5b1UvR3VKZTBNbDZHaTMzYmcwZ2tLTFdXaEp2RXNxSjQ0?= =?utf-8?B?aEdGdS9PTURndWF0SnlqU0xNcHhoU0xwaXpmenRRN0s2ZDlmRFd3QzlGSWVu?= =?utf-8?B?d05Ca1AyY0RtOXIyc3U3K2dlNmdDdUlsRmxRckdlWTdYd2RVM1JHUDU2ai8r?= =?utf-8?B?SHhzMWlCNDJha0ZMUjdWSVFUWUE2TUl0K2I1TEt2dmNmTFRRSWl4eFdOVDdv?= =?utf-8?B?S0tsbUl0elJxRDhkeG8ydnhOR3BqTkVUMXRUNU5VQjMyWE5LbmRhalA3cWxq?= =?utf-8?B?QlozdnNVOWVoWmwvMlc1RklTcjN1TjJ3cm9BMThtMTV4cSt4dzVVMjJ5dytE?= =?utf-8?B?bWlTTlNOTmc4bWsvTkF3QVpBNExvdEs0THJocDJpcEwzcDc2eDVxUjMyOU83?= =?utf-8?B?KzVXcEtwTjhBazJGRlNVdWtVTUNxUWlPbkhYNWQzVGZDcmpoOGZpdmF3Q29U?= =?utf-8?B?WlptcktDb21wazZZNFRsK2tLdU40UWFhblg0NnBLNTk1MFE0RjQ3VkgrbjNl?= =?utf-8?B?VG4wb1FGdG5BelJsQ05FL3JSVWN3TGRGTGh3bE5Ob3A2MGZScGpmb2FEZXRK?= =?utf-8?B?b2g2RjdKOUEvcm5yRFkvNlE3dWkvWVE5cjZpdjZweDErM1Q0RHVyeEZteUNF?= =?utf-8?B?alJ3VjZORHpZQnZVU1ZKQmNKK01HN09GNGQxaXAvQURCNHovVU5zY0IvSysz?= =?utf-8?B?TTZmdHJpV1JGeE16UWd2TEdzYi9kMHhoT3F1TElNRHh1MkVIU09FbTBhZWdp?= =?utf-8?B?aGpZZ0ZBWTJLSEYxMjcxOUd6cVRvRjdyVllQYmtNY25KN0FaVHRsTHp5dnFY?= =?utf-8?B?QVpJN1ZHT1lsUUVBc2xSazZyN1d4R01ydHBkZGZJMXcwYUs2NEZwOU5RVFgw?= =?utf-8?B?eUVxaERjM2hZL3R1b3pnYTZGM1dFeEFwSnlsU0VjUWUzaTEwQ1BFOWs1SVg4?= =?utf-8?B?OXhCV21aZ2wrME5CaFlZUFNTb3pSNFduL1dSYUZxcXQyN3E2TmNYNE5mTmIv?= =?utf-8?B?TU5PdG05bFR3TXN1TXNSd1kxYlMwT2dMTE9Db3haYzIvblZZelI5VndyY1pQ?= =?utf-8?B?YS83WXdBQjZpaW9vVnBNb3BTSHBnOVl0Y0MyeWFwTTNvUWV0Mmw4ZHNNSStB?= =?utf-8?B?S3BqNXRFZ0tIWXg3aUNPZElsWTNHK0o0dDYvTW4zVFpCczVycWUvNjNDdWxK?= =?utf-8?Q?N1CIcngQHv8vS6v/lNiMtDB03?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d941830-8c41-479c-8e23-08db94174fa4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 11:46:44.6777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pv6HHaU6OtmmzwqG8zhvCRPRQPmkpyP8xiCwC+OP+bHg98AuM+SKct0OhweudPdlvEnzYzM8abyI0uY+g0Mjcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7214 On 27.07.2023 20:41, Stefano Stabellini wrote: > On Thu, 27 Jul 2023, Jan Beulich wrote: >> In the latter case the variable altogether is then unused and hence gets >> dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly >> introduced both assignments in 57a57465daaf ("x86/HVM: use available >> linear->phys translations in REP MOVS/STOS handling"), likely as a >> result of some re-work on the patch. >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Stefano Stabellini Paul - any chance of an ack? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 11:53:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 11:53:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576280.902238 (Exim 4.92) (envelope-from ) id 1qRWtR-0008Lc-7j; Thu, 03 Aug 2023 11:53:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576280.902238; Thu, 03 Aug 2023 11:53:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWtR-0008LV-3u; Thu, 03 Aug 2023 11:53:25 +0000 Received: by outflank-mailman (input) for mailman id 576280; Thu, 03 Aug 2023 11:53:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWtP-0008LP-Qt for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 11:53:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061e.outbound.protection.outlook.com [2a01:111:f400:7e1a::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 574d587a-31f4-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 13:53:20 +0200 (CEST) Received: from DB7PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:10:36::35) by AS8PR08MB9020.eurprd08.prod.outlook.com (2603:10a6:20b:5c0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 11:53:17 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::b9) by DB7PR05CA0022.outlook.office365.com (2603:10a6:10:36::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 11:53:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Thu, 3 Aug 2023 11:53:16 +0000 Received: ("Tessian outbound d7adc65d10b4:v145"); Thu, 03 Aug 2023 11:53:16 +0000 Received: from e434bc8d1354.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2B5327BC-9E21-44B9-BD14-C39F036650B0.1; Thu, 03 Aug 2023 11:52:39 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e434bc8d1354.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 11:52:39 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS8PR08MB6133.eurprd08.prod.outlook.com (2603:10a6:20b:298::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 11:52:34 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 11:52:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 574d587a-31f4-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOgLIG2ymWt56P5HO3TD91hHwe6zt9JbXfvELR5x7gg=; b=6h/tgrMRY1qtZaNmaReyIq8sezZruk6VW8zOpjIbPtk7ntBdo4nrYUE/duj6YhS6d3dMPlapSXhdqzEdJnpnrJWE0WGGyCQrL6VKCYlQWh6HdEm0/pscXOMtdGiQB6AXtgzxXShknpmTONGgp8uXlMfG9iqUO4WTSLxU5PmKFgw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 12ca26ff7673410d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtQ1qgFMZy4l3pIJITyJaUAIEI5Wu2M0l9gWOODnTCPI0prIe+JXiBo/cwKzAP7pmQQDukLE3VheK4CjtTyQP5ID22ObHLlZwPWbbyoLh0NZUwpc5onlI2EX/X8PuQCx+WY5Ov3NfOK0OChmaHYCeVRnG7tHbpYixXGWRAJxlhv5kmgopsfwGzEok1IMfOatE5mVkpFnvIMPMECzgAI3OZnNo7AbQsVK/J/U/M4GGHfKIFT+yqonc0dHMLgkSKAm7d2DBXFHJ55XYy7UUS2zrWOn9xEB1SmI2D5XSQYF3sd48gQm8rYa2CXUVjTw7ZB5KdYAK9MPhsZgRj7ccw/DLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wOgLIG2ymWt56P5HO3TD91hHwe6zt9JbXfvELR5x7gg=; b=NsuJ1qcCW0kdK0PTO8z9sXB21AsepAIAN+DrJgGWlpOy9N7mD75Vgt04fZA10Nn1sAOp3oMuNQcnZRWg17l3idi0uWbxD5RITjp3+e0mO9w1e+IVC7ScVX4LDtrQRs5qmzEedfmtqRF9gTRvnB6Fnj0M3ZhklDoEIMYsVNsneKgnCfsTvVhAkYXyT0KkhLncNcR3qReRmCbcX9rxpJwvaoXdzU/SrEY1wZOQR75zZepUPgOyq0Kl5eh3m3roGeDiNWzlwQ+LCWe8SzJ4GFk3bhO2UjB4ARGrS+p57wyJ6LuUAWFsXFXSsev2XyAUKGwS2HAXWdckz38nEfVFbN1thg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wOgLIG2ymWt56P5HO3TD91hHwe6zt9JbXfvELR5x7gg=; b=6h/tgrMRY1qtZaNmaReyIq8sezZruk6VW8zOpjIbPtk7ntBdo4nrYUE/duj6YhS6d3dMPlapSXhdqzEdJnpnrJWE0WGGyCQrL6VKCYlQWh6HdEm0/pscXOMtdGiQB6AXtgzxXShknpmTONGgp8uXlMfG9iqUO4WTSLxU5PmKFgw= From: Luca Fancellu To: Julien Grall CC: Federico Serafini , Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names Thread-Topic: [XEN PATCH v2] xen/string: add missing parameter names Thread-Index: AQHZxeRL9pSVXV1k9k69k8jE/HqUO6/YXqGAgAAVuwCAAAHJgA== Date: Thu, 3 Aug 2023 11:52:34 +0000 Message-ID: <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS8PR08MB6133:EE_|DBAEUR03FT028:EE_|AS8PR08MB9020:EE_ X-MS-Office365-Filtering-Correlation-Id: d8238770-2e36-41d3-b35d-08db9418399e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OMtRxY3PmtFUk8x/26LsMcgkJMSM3w7wU497EfmkogEalaW0BYSyFh/xrT9nUSrlgkbLdFiageES36a6XI/4H2VRO1JymDbHePWt2sIkrcSXRNsV7/dowh8/nhj+uHl2+xalvY8WZrhxQM1ABXsVrhf88qVEeaID5baaHTgaogaNfnYH8VqUeTwVNY5HN6vjpDkgNR7XvRsei4k4U3Vscq2OBOjR6sFB1lGVcmmv4nDcqUhrBLwJu9UWvS2wT9j0riMeQ61aNe4qC9wtM1Awrw3JMk0UK7AQ2DjvI8jL1tq6oylJlHneXnfbxpmAewjJYVreIlnMa41rt+itDXhcwQBQiMWui4ElgiED+xtNZozwhwVRnsg459/yG+eCG6lqNxIpWgVvzgyoU/nKnPWk/BNd87Yujvv/AZjser+q1V3sHAv+V4VA4goyInzIH1TCuiv9AadU/joJxXD8EKhjH70KD2e6SkfigpclHZC0VR0al4vfgkS96GEFI6THS2RXZS0rR6neaGxcMjZbmtPoibikdEC1nXlfFKVvpiZuOqwP+rN3UtNwAM608bELgIr4bxJNl2/e2Tx9k7KVHKZsxoLKVRLvO51uRmL4KsHsWYI7Jx22EoOWVaJZwuu5Gclaj2Hc9uzepzw3lUqUUSqQtQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(39860400002)(396003)(346002)(451199021)(2616005)(53546011)(83380400001)(6506007)(26005)(186003)(41300700001)(2906002)(91956017)(66946007)(76116006)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(6916009)(316002)(8676002)(8936002)(6486002)(71200400001)(6512007)(478600001)(54906003)(38100700002)(122000001)(33656002)(86362001)(36756003)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6133 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b977345-9476-4407-1f31-08db94182024 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bfOdzeNqtgx1YVnG8JSdp3wbYKMvAhZKLv5QwCe/JyzGaKlVX17XIq7Z56HkuvX/oujWb6Y0kaLqpDvP57EH0EW2q1TYhtFLaekbqZFPzTkl2SrRt5pFkC5Non71T4itUav+wdaaAvU9ZWs+8dEFO8A4SCnLW0+GK2/5JfvQMakHGvWcpvhieE7TGZuPI9M/SpBVozrkmyvEIBVvK4Cp+RLrDDF2WYvjR9jS6/l4PDRZJPoeogFrZRPjDGFE4bT1kNRccEjy7KnC62EKAFeXAdSJqBb5Gmv6fMqfvFJ2cUIyHutb3UJHxz8SftFMaiH9WkkdEP3havmWEy9iUxvP026hgBTiqnc5TNrGUVibDxrdopqE2rT8J4oxO9P7wsPf/F20gDe5dluHIUwZL+syuT9RUcOpGzgrj/UjUd+gjfPior2T4waAGAADZN8nUmNqUjaBPST91wZ3tkiiC9sARs4eANPk7uMFC/YGnLcLiZCTKGiiWQpU1cVCy+Hljm5VpCMbKU/r6a6Kxm7e8urbg0EOuuDr2YGRivovUOE/M0BLO4Z/C7v4EtFu1h4cr2ktIcOA2U1NUBaXoV7SXbYHp2gNJk+P1WUPpPzirSGoQdEKU4WjOUMhp9fZGT97pbr/wDuznC/mieslY/QpNy7BKhfNFD9qhmYDR3axJJNoqxfn2HOjgVFxx0W4TNjpk408V/e8bkzlZ5hezgO0jIXtb9NB8861EptZXLtG8rDGOAEHonqHOfIqhdCogfIMIHAx X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199021)(82310400008)(46966006)(40470700004)(36840700001)(36756003)(86362001)(33656002)(82740400003)(40460700003)(40480700001)(54906003)(478600001)(356005)(81166007)(47076005)(2616005)(6506007)(336012)(186003)(26005)(83380400001)(53546011)(8676002)(8936002)(6862004)(41300700001)(6512007)(6486002)(316002)(36860700001)(5660300002)(4326008)(70586007)(2906002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 11:53:16.9572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8238770-2e36-41d3-b35d-08db9418399e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9020 DQoNCj4gT24gMyBBdWcgMjAyMywgYXQgMTI6NDYsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+IHdyb3RlOg0KPiANCj4gSGkgTHVjYSwNCj4gDQo+IE9uIDAzLzA4LzIwMjMgMTE6MjgsIEx1 Y2EgRmFuY2VsbHUgd3JvdGU6DQo+Pj4gT24gMyBBdWcgMjAyMywgYXQgMDk6MjYsIEZlZGVyaWNv IFNlcmFmaW5pIDxmZWRlcmljby5zZXJhZmluaUBidWdzZW5nLmNvbT4gd3JvdGU6DQo+Pj4gDQo+ Pj4gQWRkIG1pc3NpbmcgcGFyYW1ldGVyIG5hbWVzIHRvIGFkZHJlc3MgdmlvbGF0aW9uIG9mIE1J U1JBIEM6MjAxMg0KPj4+IHJ1bGUgOC4yICgiRnVuY3Rpb24gdHlwZXMgc2hhbGwgYmUgaW4gcHJv dG90eXBlIGZvcm0gd2l0aCBuYW1lZA0KPj4+IHBhcmFtZXRlcnMiKS4NCj4+PiANCj4+PiBObyBm dW5jdGlvbmFsIGNoYW5nZXMuDQo+Pj4gDQo+Pj4gU2lnbmVkLW9mZi1ieTogRmVkZXJpY28gU2Vy YWZpbmkgPGZlZGVyaWNvLnNlcmFmaW5pQGJ1Z3NlbmcuY29tPg0KPj4+IC0tLQ0KPj4+IENoYW5n ZXMgaW4gdjI6DQo+Pj4gIC0gbWVtc2V0KCkgYWRqdXN0ZWQuDQo+Pj4gLS0tDQo+Pj4geGVuL2lu Y2x1ZGUveGVuL3N0cmluZy5oIHwgNDIgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tLQ0KPj4+IDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlv bnMoLSkNCj4+PiANCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3N0cmluZy5oIGIv eGVuL2luY2x1ZGUveGVuL3N0cmluZy5oDQo+Pj4gaW5kZXggYjRkMjIxN2E5Ni4uZTkxZTMxMTJl MCAxMDA2NDQNCj4+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vc3RyaW5nLmgNCj4+PiArKysgYi94 ZW4vaW5jbHVkZS94ZW4vc3RyaW5nLmgNCj4+PiBAQCAtMTIsMjcgKzEyLDI3IEBADQo+Pj4gI2Rl ZmluZSBzdHJuY3B5IF9feGVuX2hhc19ub19zdHJuY3B5X18NCj4+PiAjZGVmaW5lIHN0cm5jYXQg X194ZW5faGFzX25vX3N0cm5jYXRfXw0KPj4+IA0KPj4+IC1zaXplX3Qgc3RybGNweShjaGFyICos IGNvbnN0IGNoYXIgKiwgc2l6ZV90KTsNCj4+PiAtc2l6ZV90IHN0cmxjYXQoY2hhciAqLCBjb25z dCBjaGFyICosIHNpemVfdCk7DQo+Pj4gLWludCBzdHJjbXAoY29uc3QgY2hhciAqLCBjb25zdCBj aGFyICopOw0KPj4+IC1pbnQgc3RybmNtcChjb25zdCBjaGFyICosIGNvbnN0IGNoYXIgKiwgc2l6 ZV90KTsNCj4+PiAtaW50IHN0cmNhc2VjbXAoY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICopOw0K Pj4+IC1pbnQgc3RybmNhc2VjbXAoY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICosIHNpemVfdCk7 DQo+Pj4gLWNoYXIgKnN0cmNocihjb25zdCBjaGFyICosIGludCk7DQo+Pj4gLWNoYXIgKnN0cnJj aHIoY29uc3QgY2hhciAqLCBpbnQpOw0KPj4+IC1jaGFyICpzdHJzdHIoY29uc3QgY2hhciAqLCBj b25zdCBjaGFyICopOw0KPj4+IC1zaXplX3Qgc3RybGVuKGNvbnN0IGNoYXIgKik7DQo+Pj4gLXNp emVfdCBzdHJubGVuKGNvbnN0IGNoYXIgKiwgc2l6ZV90KTsNCj4+PiAtY2hhciAqc3RycGJyayhj b25zdCBjaGFyICosIGNvbnN0IGNoYXIgKik7DQo+Pj4gLWNoYXIgKnN0cnNlcChjaGFyICoqLCBj b25zdCBjaGFyICopOw0KPj4+IC1zaXplX3Qgc3Ryc3BuKGNvbnN0IGNoYXIgKiwgY29uc3QgY2hh ciAqKTsNCj4+PiAtDQo+Pj4gLXZvaWQgKm1lbXNldCh2b2lkICosIGludCwgc2l6ZV90KTsNCj4+ PiAtdm9pZCAqbWVtY3B5KHZvaWQgKiwgY29uc3Qgdm9pZCAqLCBzaXplX3QpOw0KPj4+IC12b2lk ICptZW1tb3ZlKHZvaWQgKiwgY29uc3Qgdm9pZCAqLCBzaXplX3QpOw0KPj4+IC1pbnQgbWVtY21w KGNvbnN0IHZvaWQgKiwgY29uc3Qgdm9pZCAqLCBzaXplX3QpOw0KPj4+IC12b2lkICptZW1jaHIo Y29uc3Qgdm9pZCAqLCBpbnQsIHNpemVfdCk7DQo+Pj4gLXZvaWQgKm1lbWNocl9pbnYoY29uc3Qg dm9pZCAqLCBpbnQsIHNpemVfdCk7DQo+Pj4gK3NpemVfdCBzdHJsY3B5KGNoYXIgKmRlc3QsIGNv bnN0IGNoYXIgKnNyYywgc2l6ZV90IHNpemUpOw0KPj4+ICtzaXplX3Qgc3RybGNhdChjaGFyICpk ZXN0LCBjb25zdCBjaGFyICpzcmMsIHNpemVfdCBzaXplKTsNCj4+PiAraW50IHN0cmNtcChjb25z dCBjaGFyICpjcywgY29uc3QgY2hhciAqY3QpOw0KPj4+ICtpbnQgc3RybmNtcChjb25zdCBjaGFy ICpjcywgY29uc3QgY2hhciAqY3QsIHNpemVfdCBjb3VudCk7DQo+Pj4gK2ludCBzdHJjYXNlY21w KGNvbnN0IGNoYXIgKnMxLCBjb25zdCBjaGFyICpzMik7DQo+Pj4gK2ludCBzdHJuY2FzZWNtcChj b25zdCBjaGFyICpzMSwgY29uc3QgY2hhciAqczIsIHNpemVfdCBsZW4pOw0KPj4+ICtjaGFyICpz dHJjaHIoY29uc3QgY2hhciAqcywgaW50IGMpOw0KPj4+ICtjaGFyICpzdHJyY2hyKGNvbnN0IGNo YXIgKnMsIGludCBjKTsNCj4+PiArY2hhciAqc3Ryc3RyKGNvbnN0IGNoYXIgKnMxLCBjb25zdCBj aGFyICpzMik7DQo+Pj4gK3NpemVfdCBzdHJsZW4oY29uc3QgY2hhciAqcyk7DQo+Pj4gK3NpemVf dCBzdHJubGVuKGNvbnN0IGNoYXIgKnMsIHNpemVfdCBjb3VudCk7DQo+Pj4gK2NoYXIgKnN0cnBi cmsoY29uc3QgY2hhciAqY3MsIGNvbnN0IGNoYXIgKmN0KTsNCj4+PiArY2hhciAqc3Ryc2VwKGNo YXIgKipzLCBjb25zdCBjaGFyICpjdCk7DQo+Pj4gK3NpemVfdCBzdHJzcG4oY29uc3QgY2hhciAq cywgY29uc3QgY2hhciAqYWNjZXB0KTsNCj4+PiArDQo+Pj4gK3ZvaWQgKm1lbXNldCh2b2lkICpz LCBpbnQgYywgc2l6ZV90IGNvdW50KTsNCj4+PiArdm9pZCAqbWVtY3B5KHZvaWQgKmRlc3QsIGNv bnN0IHZvaWQgKnNyYywgc2l6ZV90IGNvdW50KTsNCj4+IFRoZXJlIGlzIGEgY29tbWVudCBpbiBh cmNoL2FybS9ybTMyL2xpYi9tZW1jcHkuUyB3aXRoIHRoaXM6DQo+PiAvKiBQcm90b3R5cGU6IHZv aWQgKm1lbWNweSh2b2lkICpkZXN0LCBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBuKTsgKi8NCj4+ PiArdm9pZCAqbWVtbW92ZSh2b2lkICpkZXN0LCBjb25zdCB2b2lkICpzcmMsIHNpemVfdCBjb3Vu dCk7DQo+PiBUaGVyZSBpcyBhIGNvbW1lbnQgaW4gYXJjaC9hcm0vcm0zMi9saWIvbWVtbW92ZS5T IHdpdGggdGhpczoNCj4+ICAqIFByb3RvdHlwZTogdm9pZCAqbWVtbW92ZSh2b2lkICpkZXN0LCBj b25zdCB2b2lkICpzcmMsIHNpemVfdCBuKTsNCj4+PiAraW50IG1lbWNtcChjb25zdCB2b2lkICpj cywgY29uc3Qgdm9pZCAqY3QsIHNpemVfdCBjb3VudCk7DQo+Pj4gK3ZvaWQgKm1lbWNocihjb25z dCB2b2lkICpzLCBpbnQgYywgc2l6ZV90IG4pOw0KPj4+ICt2b2lkICptZW1jaHJfaW52KGNvbnN0 IHZvaWQgKnMsIGludCBjLCBzaXplX3Qgbik7DQo+PiBAU3RlZmFubzogd291bGQgaXQgbWFrZSBz ZW5zZSB0byByZW1vdmUgaXQgYXMgcGFydCBvZiB0aGlzIHBhdGNoIG9yIG1heWJlIG5vdD8NCj4g DQo+IFRoZXkgYXJlIGEgdmVyYmF0aW0gY29weSBvZiB0aGUgTGludXggY29kZS4gU28gSSB3b3Vs ZCByYXRoZXIgbm8gdG91Y2ggaXQuDQoNCk9oIEkgc2VlISBUaGFuayB5b3UgZm9yIHBvaW50aW5n IHRoYXQgb3V0LCB0aGVuIEnigJltIHdvbmRlcmluZyBpZiBpdOKAmXMgdGhlcmUgYSByZWFzb24g d2h5IHdlDQphcmUgdXNpbmcg4oCYY291bnTigJkgaW5zdGVhZCBvZiDigJlu4oCZIGFzIHRoaXJk IHBhcmFtZXRlciBuYW1lLCBJIGtub3cgU3RlZmFubyBzdWdnZXN0ZWQgdGhhdCwgc28NCkl04oCZ cyBqdXN0IGEgY3VyaW9zaXR5LiBNYXliZSBpdOKAmXMgZm9yIGNsYXJpdHk/DQoNCj4gDQo+IENo ZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Thu Aug 03 11:56:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 11:56:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576283.902247 (Exim 4.92) (envelope-from ) id 1qRWwG-0000W1-LX; Thu, 03 Aug 2023 11:56:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576283.902247; Thu, 03 Aug 2023 11:56:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWwG-0000Vu-Ir; Thu, 03 Aug 2023 11:56:20 +0000 Received: by outflank-mailman (input) for mailman id 576283; Thu, 03 Aug 2023 11:56:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWwE-0000Vi-Es for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 11:56:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf24156b-31f4-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 13:56:15 +0200 (CEST) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Aug 2023 07:56:01 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5184.namprd03.prod.outlook.com (2603:10b6:208:1e2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 11:55:59 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Thu, 3 Aug 2023 11:55:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf24156b-31f4-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691063775; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=COUk0Wgz7yZkgzhePNL+B049hzOO43HXB1QDuVGj2f0=; b=Tdt2IfWl3oMBTFiEVFXtDrs0xkEufEsxhBQFOQGlJ+lNZHEoOHEQYWSb trhiXu8HGq5SApLiE4WGjSZD8fcxXCAJ9Cz0r0FbAwe1IKWG2jvDNi9I+ EFTlFg6aR2QoQn6pqjRAuYVvq9AULPd0Rw3Toj2GWMG40OdUy3bBMt8tZ k=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 121015384 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:M3F5aqtCS59gVOVXYD/t9whCvufnVM1fMUV32f8akzHdYApBsoF/q tZmKTqCbqzbNGbwftkjPY3jpBxQ6sDQmIdrSFdoq31mRiMW+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5A+GzCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwASICT07cjfmK2ezicfkvrPo7DMvxFdZK0p1g5Wmx4fcOZ7nmGv2PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60aIC9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTir6Yz3QbDmgT/DjUVXkWc/NKlg3SFUt54d 2YbxCkpj6oLoRnDot7VGkfQTGS/ljoBUNMWPeQ84wyJzrf86hycQGMDS1ZpasEitcIwbSwn0 BmOhdyBLTJivLCPSHmasKyZtzq8OC4UBWUfajQJSwRD6N7myKkjgxSKQtt9HaqditzuBSq20 z2MtDI5hbgYkYgMzarT1VvAhSmxooTISAEd7BjYRW+j4UVyY4vNT46i5EXf7P1ABJ2EVVTHt 38B8+CF9/wHB5yJkC2LQc0OEauv6vLDNyfT6XZwG7Ex+jLr/GSsFb28+xl7LUZtd8MbIzngZ RaLvRsLvccJeny3caVwfoS9TdwwyrTtHsjkUfaSacdSZp92d0mM+yQGiVOs4l0BWXMEyckXU ap3u+72ZZrGIcyLFAaLeto= IronPort-HdrOrdr: A9a23:/Jk3Qa9G0dYNgi65NJxuk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7 X-Talos-CUID: 9a23:RocEgmHisFpVPWZ+qmJO5kE1RJ8vaUHEki7rMwySN35JSqe8HAo= X-Talos-MUID: =?us-ascii?q?9a23=3A0SIdxwyNSBTjXfdKZgoxskA6vdyaqKelFmdQuok?= =?us-ascii?q?PgfKNOQssETijjzOVQLZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,252,1684814400"; d="scan'208";a="121015384" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XsvMCY5SIHM9kRkrVHufaNaxaSHc5y3NTbSOqMG/FpQr29+ftHELf1SDbcLEEa3/CdPYmcwZLIss1jOZqXNf1CARgY04BpeOzkROA90v+kyD2xfhUtEM3dBDR2Y7GcDd1bRbgoDNBMw/UW4yIF3jtpZsj/LMfAdpgyB6c0ctuIFMJ7/7b9EqInSUJAqEBWxRtAZkcVzyevln/Yx1pe+uasjR3Ls9BItUbqaqu+Dh8WrP68QLftAsP32Wq+k0M8zeoAdq7nVpd/xy74WCceUpLzVdv4LLojYIX8A0TIkUzmqpXL2yv8OdAMYbBCnmSLn9k1tMqmi3B7Rxv/Z4tDRiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1x4RnheK6/LhYWF9bzfgUkWB/nfyA/xAppqOshrii+8=; b=oYrWF6vj4fpCy3yCgnhEamJ8FDrSu0xuL8ef1yrDk9RsGn+7NneCvfOT6fBoaW/eJ3dATNPhDq8hhvlnC7kwLUi/YfSO8uijqKCJSTdOhKoV2AQ9OKwkgUEa7d4lezKKppO+Kj/oprlyqo079/bW0n1D1sEpDUYrONT072YWIKNGmp9PzyhA5b46J7S/WyxfagSTOpKo40XfxaeL7fmxSkKNJyo8ysPwAFbIkmWpwIxT7k7a9mt/mEefiec+uhI7aTTzVnHq1N3aB3oUFK+hNMiDYYipTdWCefNEMcXf6n6fdCWh6v0+uJb6EQEYYApYSL0C0ez6NxFBRNlbbM+Rrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1x4RnheK6/LhYWF9bzfgUkWB/nfyA/xAppqOshrii+8=; b=AU+Uu167AeUjc3360T/fI1+x3PL/UpHodUDiweEGWj+M7cakfV0Ddrig1Sss6XNFfWMsVXkyk88EpWhiXGSdALfNtkQGBMxs56XQY20oG/A0UWvFekThcoG3hsV4WZWkmPmdKjkdoIQr6mZEXGZwFblBDQQkHfGnBoQHx3yYOcg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 3 Aug 2023 12:55:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names Content-Language: en-GB To: Luca Fancellu , Julien Grall Cc: Federico Serafini , Xen-devel , "consulting@bugseng.com" , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> In-Reply-To: <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0286.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5184:EE_ X-MS-Office365-Filtering-Correlation-Id: c8dd07c4-cfb7-43c1-0c28-08db941899a4 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +bSYhj3Ii3aGNWCa0e5PurHE2GxDzr8mmdt8s1/Ch+SLaJwZs2VpOwHWRZmDXgqP3xJDgWPtuCDIEqPxUMgUGUS5MLsSNa2yovqDkEVbykYc+AASnoUp3vy12qxDRYx3Yb+432rJ5lpMdSnYPvGBWMMEplpmwmr+KCmD3SuL8hsBxFZhomsAl1qrslIjB89St3gDTvfJYdocOgbj0BwgkRrjxAXHdPVB6IN7x5ZkKaBWK6Uv8PGiPTKtoqRwIj3niaZTN0pITFtoURhSOqnSGTgBD3D+GJ/tFG4KaBVCTS3t7L4oEWXKhxxAlAOS9lr29pyDSm9RGfwjmjRrW2z3XsYv4rVknbnrXJKKQz0doaW4tNZw9DST/FJoaTJEtxGcaTi+G1vHM/WjbOECT/CxqLYsd53UHAkgA6l54yBSsJAI21ZCYpODjLPvb8pSWZoJz3dVvnogqZlKzwj/OBxNOujfme1K999y08xXkCAXZPtvsL1jw7ddoI7TfllazcqWM4+15JxrMjqYSUyhMEPKK1X7gi+NqAfDmJSvXJI9nTo7zEiAX23FYcoXG01sr68PkZYXZhz/aMHEpd20z2faTzyp+EioBL0yB5pyeN41Tb75in9/g5+1Bk/jFNBdU4km5vGTYblUoCB7ftqVBwvPhw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(451199021)(86362001)(36756003)(31696002)(31686004)(54906003)(478600001)(110136005)(38100700002)(82960400001)(2616005)(6506007)(186003)(26005)(83380400001)(53546011)(8676002)(8936002)(6666004)(41300700001)(6512007)(6486002)(316002)(66476007)(66556008)(5660300002)(4326008)(66946007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEY3YTdsQURpdzUxWHc3VWVIbFEwYjFMVWo5U1JtUDRyV3UvaldXeW5LZUQ3?= =?utf-8?B?dnBRRzZMcTRobnBEN1hobXBNclNON2V3WnQ0azVtTDVYR0tobGNIaWhTWUpl?= =?utf-8?B?M0hpcm9GNUxXSFdsNHZ1bFdEelg1UjRQZXRFQzhzRTFzOE5zcVV0ZDNEN1pn?= =?utf-8?B?cjdrOTFWbjh0NGFjS29DNHRlZTBKWko5MTFrMlNqemZaeXNpQjR2dHdCVWI4?= =?utf-8?B?MDBnSkZnN2pBbVFkK2VTMk42dUM4TTdDT1VpRUV5T0NnaWxlVlJXMVJmbUhL?= =?utf-8?B?bmZ1ekRUZmE5K0VrVmQ4cjNYT0tGRmJ5cDltSm5lZVduMzdyUFV5OU5iNHVK?= =?utf-8?B?M1JCYlpESTdURU1VdjdTK1BDbDlka1lYa2FYQWZGVEhqNCtvbzFicGJzOXhw?= =?utf-8?B?WHlmTGRVNTd1S1BNUFFUcHBCWkZDeDVzMGFVN1BLaVNBWUxVeSsxVnBHNUhX?= =?utf-8?B?b2JyUlNaQi91WmpCV3NRU0VJbG1sSXdqMjNyUkRETUxTV0o1SEpxZ1JCR05q?= =?utf-8?B?N0M2bms2L3hWMVQ4eXhIYmxUc3pPcjNQRVNkRmlMNlNUdnVvYVhpMis1ZTh1?= =?utf-8?B?S1RlbnkzQUVaVEltYnRMOEI2L0h2WkFMdkRkeUdGcVEzRnZRV1BuTUloSlBK?= =?utf-8?B?VVUvRGRhWjhSMjZoMGMvc1ozdWFsTVVlVnBtTEdzS1JCaVAvTVVXeWhLNVdR?= =?utf-8?B?SWtkYkE0R0hwUlQwTXFqdlRWUTI2WEs1Qk8wWCtlRVJwM05HclhNWEErMysz?= =?utf-8?B?NHlNNHRIVVJqRzVGRFVKT045YytvQitKRFpESlNhczR4YWFlUUFvbmJZWnRN?= =?utf-8?B?WWxrdVNlak9rejVvdUZ1SEMySzBvemFycys5M0N2cFp3RzFCNGJqaWJhNUVh?= =?utf-8?B?THF0dytwVER2UTdIbHJCVlIrcHVSSHBFNW1zamlKK01HMUEyTHNhS2xXRzlX?= =?utf-8?B?UUpZWTFLaGdYV2VRSHlHSFNoMDNvaVo1MC9EUnN1bzYxRDNiM3pQT3R5SEVD?= =?utf-8?B?RHhRekFoS0o1RkdOaXZXb1dmVkh5MUZIMVdaWmxIc21JVkYrMDZzQzRBa0x4?= =?utf-8?B?eWdTR3VQc3owZTRiNXdXV05idVE2bTFNNC9RSnQ3YnB0NlNzRTdYOFFJM0JO?= =?utf-8?B?d09ERkwzT0ZvdmJ1blEyeGVPREVaZWg0a1N0SHBvSUcydzBPRVMrdS8rY0lZ?= =?utf-8?B?Qy9KUHB4a21LeStOaUsvb1FEU25lUGQ4N3JQMFAwdGJTZGpuSlVqNzJrbWFS?= =?utf-8?B?UWQ4aDljNlF3eFcyMXhlSHBIcEVvMW5QVWN1MVlHWHNCaUc2Si8yZTQ1RTlx?= =?utf-8?B?NXc4bHFiRTRGbWU5QWZ5Q2lOaGRCQTQxTFdrVktlMmVqVThMQW9yTWd2eDFz?= =?utf-8?B?YzFCVG1hbFNHTGNnOExIMnk4VVQreHNqM1pkdUV4Q1hBV3VXSHlqUlpCSGtE?= =?utf-8?B?cms4U3RaaDJsTnpKdS81ZTZSWnJVU0YxeE95QnlSc1ArZVpNcXFoTXg5dllm?= =?utf-8?B?Q3h2RU9OQTllQStHODFlKytaTElyUGJNazdHWE9rUWl2SWQvMmtwV0ZVQWkv?= =?utf-8?B?QWFSQWZ6eXEzb0prdXczeFYveTVVSzh2MmUwOVRsQVR5SVBJRHYzQnQ2VlVO?= =?utf-8?B?ZnFxcisxWUtPa0swcC9RVGloTU9tR3ZWZFFQVjM2d2FTS2Q3NjgxRmxKd3Jm?= =?utf-8?B?azNWM1JFdVBWMitrWXhQZFE5dTVjM2Fub2dQSmdWZGFtak1VaTh4MXoyS3JR?= =?utf-8?B?TmtuTXc2UXRaT1pZTjFEbStxOFRESndjRE5zRlBhbzhpYkNhUDd5SnFjZnNj?= =?utf-8?B?Y2g0cWFpNXIrd3RtNE5TWlpFZGhrc3dxc2paSHFZSGZ4UlhhRms4LzRoS2FR?= =?utf-8?B?WWkwK0Y3N0lpUFMyOUNxQW52ZW9qam5taTJNTEhTclUwZ3VpejBxbXF5SG1s?= =?utf-8?B?M095SEJ5Q0cwQzVxeWlVV0l6YXhaWTdvaHQ4OElCQVppNlZ3NXB1bCtKNEph?= =?utf-8?B?bXRiTU5aZlArOE5nYTJOV2QvYVpEMWk5Yk9zR2tRSDVnTTE3M1k1UjFmTVN2?= =?utf-8?B?NS9vMGc5K0U1TDZTV1p2NTZBYTNRdUVFR3FNaCtGdzh3Q3RNdm5rWmFtM0R5?= =?utf-8?B?d1FQMHJFNlo4WWI2VzQwU1JKZE4yR2VEZDIxbEZBMERnbjVwK3JENGdxTnYv?= =?utf-8?B?cFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jb8JrgwiS1m6pFPui+LN/ZrwukpGo544w0AtaKR90Hh+V9M/sIxWSFRnW476oi4lzEPOmZByLXgE2sGbT4sLAs7QWzYxsPVUqZletZldvazVucHy+mUG+Ib7XcAfgB5iuVBNMwKOHpHjb020byj1Xm9ph/kvb2QAZ9MzBCb1EVI/0oBYzT/0/NifzGvWuuPwMgANLFQOWrtu7yhn1RHK60Zz30vXrgiKQiWZExTMmlTf/AQYOuJCT6YlwjlKrjDDuU8rdKQ8OR+A0niZr79HL1ONRS48XG1C+MQff4L9GOv1LWC73tsU4q79nW8FebRyD4V04UfWYxgeAdGzQxUMpyHBJ5Ys4s+ukQ0NxhyGE8FMUzDHYjC1eY8veyHo+zB1rXEATLJjY/6DppfeQ7EowfUzH9toOZdIYe/XPGG846FhHBF420oGn9dh8rVmBBO5i8E05aA679MWoE/C+OudkdqCEt5ngwKc2VH08YJGC9y6C0RCC+3ok+xcJNTlLwK75pv+MJ/BksndvfWCn0J4dmPkYtq1ZLQ6jrx8Hq1COYPq5e6XF73P0VaaCBYaZu4FBTxHCKJgHfFRsGuweXCp6DQ+MhIfGD8JnnV0pmSNbWC17dhVK5b/AQlqr0v3wCjo+iAepmC7ds+Hv8x0yoqnVm3Iyh74fE9IGa7WP9lAMsrBtMM4Gpqd7RkrzTNIFoi0nKi9827DVTi1Uzqhxubpkfv5rwEIiJTiycXdRdYsgPbj32aba4B9K5S9/pv3VbNbZQSghNdq7QIE1nFAWfhKed3VtU04IGGvP5eIPxk8EfnZ6va8Ma/HhbO4OAPLsHBYrIHHy+qLxTMZSgOIQHj/X+DeNtT9qZmWm1Dcv6Y6ZuGQRXwjB50QzL+4wl0i7Zg0TSG/VoFU+XsWWq7awVGF0w== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8dd07c4-cfb7-43c1-0c28-08db941899a4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 11:55:58.3982 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8piwnMoxqrt26yyQk4SzqkTUr19dS1Zd87Ih9HG2uiqHvNMjmq1/PgjUICdzhDOcJNd4XotsXLw9jRHdFylg4sQYTIoCGQLJJCDDovgKigY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5184 On 03/08/2023 12:52 pm, Luca Fancellu wrote: > >> On 3 Aug 2023, at 12:46, Julien Grall wrote: >> >> Hi Luca, >> >> On 03/08/2023 11:28, Luca Fancellu wrote: >>>> On 3 Aug 2023, at 09:26, Federico Serafini wrote: >>>> >>>> Add missing parameter names to address violation of MISRA C:2012 >>>> rule 8.2 ("Function types shall be in prototype form with named >>>> parameters"). >>>> >>>> No functional changes. >>>> >>>> Signed-off-by: Federico Serafini >>>> --- >>>> Changes in v2: >>>> - memset() adjusted. >>>> --- >>>> xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- >>>> 1 file changed, 21 insertions(+), 21 deletions(-) >>>> >>>> diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h >>>> index b4d2217a96..e91e3112e0 100644 >>>> --- a/xen/include/xen/string.h >>>> +++ b/xen/include/xen/string.h >>>> @@ -12,27 +12,27 @@ >>>> #define strncpy __xen_has_no_strncpy__ >>>> #define strncat __xen_has_no_strncat__ >>>> >>>> -size_t strlcpy(char *, const char *, size_t); >>>> -size_t strlcat(char *, const char *, size_t); >>>> -int strcmp(const char *, const char *); >>>> -int strncmp(const char *, const char *, size_t); >>>> -int strcasecmp(const char *, const char *); >>>> -int strncasecmp(const char *, const char *, size_t); >>>> -char *strchr(const char *, int); >>>> -char *strrchr(const char *, int); >>>> -char *strstr(const char *, const char *); >>>> -size_t strlen(const char *); >>>> -size_t strnlen(const char *, size_t); >>>> -char *strpbrk(const char *, const char *); >>>> -char *strsep(char **, const char *); >>>> -size_t strspn(const char *, const char *); >>>> - >>>> -void *memset(void *, int, size_t); >>>> -void *memcpy(void *, const void *, size_t); >>>> -void *memmove(void *, const void *, size_t); >>>> -int memcmp(const void *, const void *, size_t); >>>> -void *memchr(const void *, int, size_t); >>>> -void *memchr_inv(const void *, int, size_t); >>>> +size_t strlcpy(char *dest, const char *src, size_t size); >>>> +size_t strlcat(char *dest, const char *src, size_t size); >>>> +int strcmp(const char *cs, const char *ct); >>>> +int strncmp(const char *cs, const char *ct, size_t count); >>>> +int strcasecmp(const char *s1, const char *s2); >>>> +int strncasecmp(const char *s1, const char *s2, size_t len); >>>> +char *strchr(const char *s, int c); >>>> +char *strrchr(const char *s, int c); >>>> +char *strstr(const char *s1, const char *s2); >>>> +size_t strlen(const char *s); >>>> +size_t strnlen(const char *s, size_t count); >>>> +char *strpbrk(const char *cs, const char *ct); >>>> +char *strsep(char **s, const char *ct); >>>> +size_t strspn(const char *s, const char *accept); >>>> + >>>> +void *memset(void *s, int c, size_t count); >>>> +void *memcpy(void *dest, const void *src, size_t count); >>> There is a comment in arch/arm/rm32/lib/memcpy.S with this: >>> /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ >>>> +void *memmove(void *dest, const void *src, size_t count); >>> There is a comment in arch/arm/rm32/lib/memmove.S with this: >>> * Prototype: void *memmove(void *dest, const void *src, size_t n); >>>> +int memcmp(const void *cs, const void *ct, size_t count); >>>> +void *memchr(const void *s, int c, size_t n); >>>> +void *memchr_inv(const void *s, int c, size_t n); >>> @Stefano: would it make sense to remove it as part of this patch or maybe not? >> They are a verbatim copy of the Linux code. So I would rather no touch it. > Oh I see! Thank you for pointing that out, then I’m wondering if it’s there a reason why we > are using ‘count’ instead of ’n’ as third parameter name, I know Stefano suggested that, so > It’s just a curiosity. Maybe it’s for clarity? 'n' is what the parameter is called in the C spec. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 03 11:57:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 11:57:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576288.902257 (Exim 4.92) (envelope-from ) id 1qRWxO-000182-45; Thu, 03 Aug 2023 11:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576288.902257; Thu, 03 Aug 2023 11:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWxO-00017v-1P; Thu, 03 Aug 2023 11:57:30 +0000 Received: by outflank-mailman (input) for mailman id 576288; Thu, 03 Aug 2023 11:57:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWxM-00017n-TS for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 11:57:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRWxL-0005Em-MC; Thu, 03 Aug 2023 11:57:27 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRWxL-0002ti-Fi; Thu, 03 Aug 2023 11:57:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jUjfhjRzz9jAmM6SBtqFHcoXBJ2qBpxuPqhdpJlDr8o=; b=OPd5Hu1uSyOmUjk8EKZH7tEe0L +8CaiFCnUhHE0WyYfq5G0UFsnxANOok1Mx4htJuVbdEgdoGtfeAqIJvqHyIPI9E+LtrGwcAnl1UE2 oGl36wvOnzVKUAtZMhPndevro0V8EPJwqqY64m5hEJnKimAuRRr3t5XkLzvdFDLvmq28=; Message-ID: <1e2d06ab-ad3a-4e5a-ac78-d20bad28bb20@xen.org> Date: Thu, 3 Aug 2023 12:57:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names Content-Language: en-GB To: Luca Fancellu Cc: Federico Serafini , Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> From: Julien Grall In-Reply-To: <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 03/08/2023 12:52, Luca Fancellu wrote: >> On 3 Aug 2023, at 12:46, Julien Grall wrote: >> >> Hi Luca, >> >> On 03/08/2023 11:28, Luca Fancellu wrote: >>>> On 3 Aug 2023, at 09:26, Federico Serafini wrote: >>>> >>>> Add missing parameter names to address violation of MISRA C:2012 >>>> rule 8.2 ("Function types shall be in prototype form with named >>>> parameters"). >>>> >>>> No functional changes. >>>> >>>> Signed-off-by: Federico Serafini >>>> --- >>>> Changes in v2: >>>> - memset() adjusted. >>>> --- >>>> xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- >>>> 1 file changed, 21 insertions(+), 21 deletions(-) >>>> >>>> diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h >>>> index b4d2217a96..e91e3112e0 100644 >>>> --- a/xen/include/xen/string.h >>>> +++ b/xen/include/xen/string.h >>>> @@ -12,27 +12,27 @@ >>>> #define strncpy __xen_has_no_strncpy__ >>>> #define strncat __xen_has_no_strncat__ >>>> >>>> -size_t strlcpy(char *, const char *, size_t); >>>> -size_t strlcat(char *, const char *, size_t); >>>> -int strcmp(const char *, const char *); >>>> -int strncmp(const char *, const char *, size_t); >>>> -int strcasecmp(const char *, const char *); >>>> -int strncasecmp(const char *, const char *, size_t); >>>> -char *strchr(const char *, int); >>>> -char *strrchr(const char *, int); >>>> -char *strstr(const char *, const char *); >>>> -size_t strlen(const char *); >>>> -size_t strnlen(const char *, size_t); >>>> -char *strpbrk(const char *, const char *); >>>> -char *strsep(char **, const char *); >>>> -size_t strspn(const char *, const char *); >>>> - >>>> -void *memset(void *, int, size_t); >>>> -void *memcpy(void *, const void *, size_t); >>>> -void *memmove(void *, const void *, size_t); >>>> -int memcmp(const void *, const void *, size_t); >>>> -void *memchr(const void *, int, size_t); >>>> -void *memchr_inv(const void *, int, size_t); >>>> +size_t strlcpy(char *dest, const char *src, size_t size); >>>> +size_t strlcat(char *dest, const char *src, size_t size); >>>> +int strcmp(const char *cs, const char *ct); >>>> +int strncmp(const char *cs, const char *ct, size_t count); >>>> +int strcasecmp(const char *s1, const char *s2); >>>> +int strncasecmp(const char *s1, const char *s2, size_t len); >>>> +char *strchr(const char *s, int c); >>>> +char *strrchr(const char *s, int c); >>>> +char *strstr(const char *s1, const char *s2); >>>> +size_t strlen(const char *s); >>>> +size_t strnlen(const char *s, size_t count); >>>> +char *strpbrk(const char *cs, const char *ct); >>>> +char *strsep(char **s, const char *ct); >>>> +size_t strspn(const char *s, const char *accept); >>>> + >>>> +void *memset(void *s, int c, size_t count); >>>> +void *memcpy(void *dest, const void *src, size_t count); >>> There is a comment in arch/arm/rm32/lib/memcpy.S with this: >>> /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ >>>> +void *memmove(void *dest, const void *src, size_t count); >>> There is a comment in arch/arm/rm32/lib/memmove.S with this: >>> * Prototype: void *memmove(void *dest, const void *src, size_t n); >>>> +int memcmp(const void *cs, const void *ct, size_t count); >>>> +void *memchr(const void *s, int c, size_t n); >>>> +void *memchr_inv(const void *s, int c, size_t n); >>> @Stefano: would it make sense to remove it as part of this patch or maybe not? >> >> They are a verbatim copy of the Linux code. So I would rather no touch it. > > Oh I see! Thank you for pointing that out, then I’m wondering if it’s there a reason why we > are using ‘count’ instead of ’n’ as third parameter name, I know Stefano suggested that, so > It’s just a curiosity. Maybe it’s for clarity? I guess because the generic implementation of memset (see xen/lib/memset.c) is using 'count' rather than 'n'. Given what Andrew said, I would say we should rename the parameter to 'n'. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576304.902278 (Exim 4.92) (envelope-from ) id 1qRX58-00037r-GF; Thu, 03 Aug 2023 12:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576304.902278; Thu, 03 Aug 2023 12:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX58-00037k-Cl; Thu, 03 Aug 2023 12:05:30 +0000 Received: by outflank-mailman (input) for mailman id 576304; Thu, 03 Aug 2023 12:05:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX56-0002sc-D0 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:28 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 080a0305-31f6-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 14:05:26 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fe216edaf7so2512093e87.0 for ; Thu, 03 Aug 2023 05:05:26 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 080a0305-31f6-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064325; x=1691669125; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EMex7KAok8kJ3fYDsnZYNrb6j4rgrDMOCX/LkNSGack=; b=oKHyysyJy6wfxFmYBZqHe723s/tEjI0XJyms8bL2CcRzoJ/oh7Aeb00IMF9/LIZ6YT DIKLkjbc/ppHtGgzXmc5wISbu9P79n0AbaHclrnOO6cjoyxmSltOGML2pk3kuOL+vySH 0H3E278eN59PX0Qy7vEYStNVWwUUH9OMVzKZVBbbH1EApbHo8dehl9CCitfsIN1tZ47/ 3VYS5S92PHNqBWXHsu432QME5s7Vl8XFxXLtnD+A8pF+AmXhJRsErzyL/kRqrDjmQsuH JnmyAAg4K88eQGfPAR6ZZUqmI+SFsGrkmrVO+UPJ7bgGMblhsKbabd+2CjZobTNpv+P/ NHaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064325; x=1691669125; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EMex7KAok8kJ3fYDsnZYNrb6j4rgrDMOCX/LkNSGack=; b=Pn9HM4BQgY1opPCs2iCoAX/k6fiRsye9ovR5N9ct3rIPmy2tAazPBM0FcBQncYRS86 xLaow9wRhMXTzgb1PYzw11xRGmNI3SawVNqlcGuVNX4CRxy+rKfVSed23+8Sxc1KbqsC kArdW7IaEhVjAUMcKYeQhTblWhfYuov0eMQGSG9oR7CVm/ci6G6iTdvyYJecBE8eUsDO jC43R/IOa7mtg6IltQTIaJaYeiSLZIGEIv5RalwjQxUZCISigYNBvwq8oVPgWrHeTKpZ 9Z+/IrRXfVjJb07qxBM9GUm7X0iGdALyr6xVXBFVCMGd0+CA9aaHt9R4ART7wTSJHzRo 4s4A== X-Gm-Message-State: ABy/qLYANt+q2XMnfzNRHC567ocO5A9Us7qjqRVxqWpZvaP4CrIG+NWb 14Emk6GmXaTqa04okM/1GTlloFKBDbE= X-Google-Smtp-Source: APBJJlHmIBGtGsUqFlzSiGadFsBF/jw2fizwPFT8rf5AF+V/B47QKdC/GnZj4w7iQbfuuyX3B0vvnA== X-Received: by 2002:a05:6512:e83:b0:4fe:3291:6b50 with SMTP id bi3-20020a0565120e8300b004fe32916b50mr3287761lfb.7.1691064325111; Thu, 03 Aug 2023 05:05:25 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 0/6] RISCV basic exception handling implementation Date: Thu, 3 Aug 2023 15:05:16 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series is based on: xen/riscv: introduce identity mapping [1] which haven't been merged yet. The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi" instruction if an exception can not be handled. To verify that exception handling works well it was implemented macros from such as BUG/WARN/run_in_exception/assert_failed. The implementation of macros is used "ebreak" instruction and set up bug frame tables for each type of macros. Also it was implemented register save/restore to return and continue work after WARN/run_in_exception. Not all functionality of the macros was implemented as some of them require hard-panic the system which is not available now. Instead of hard-panic 'wfi' instruction is used but it should be definitely changed in the neareset future. It wasn't implemented show_execution_state() and stack trace discovering as it's not necessary now. [1] https://lore.kernel.org/xen-devel/cover.1690899325.git.oleksii.kurochko@gmail.com/ --- Changes in V7: - Update the depenency ( mentioned in the cover letter message ) of the current patch series. - clean up comments. - code style fixes. - move definition of cast_to_bug_frame() from patch 4 to 5. --- Changes in V6: - Update the cover letter message: the patch set is based on MMU patch series. - Introduce new patch with temporary printk functionality. ( it will be removed when Xen common code will be ready ) - Change early_printk() to printk(). - Remove usage of LINK_TO_LOAD() due to the MMU being enabled first. - Add additional explanatory comments. - Remove patch "xen/riscv: initialize boot_info structure" from the patch series. --- Changes in V5: - Rebase on top of [1] and [2] - Add new patch which introduces stub for to keep Xen compilable as in the patch [xen/riscv: introduce decode_cause() stuff] is used header which requires . - Remove from riscv/traps/c as nothing would require inclusion. - decode_reserved_interrupt_cause(), decode_interrupt_cause(), decode_cause, do_unexpected_trap() were made as static they are expected to be used only in traps.c - Remove "#include " from as there is no any need in it anymore - Update macros GET_INSN_LENGTH: remove UL and 'unsigned int len;' from it - Remove " include " from risc/setup.c. it is not needed in the current version of the patch - change an argument type from vaddr_t to uint32_t for is_valid_bugaddr and introduce read_instr() to read instruction properly as the length of qinstruction can be either 32 or 16 bits. - Code style fixes - update the comments before do_bug_frame() in riscv/trap.c - [[PATCH v4 5/5] automation: modify RISC-V smoke test ] was dropped as it was provided more simple solution by Andrew. CI: Simplify RISCV smoke testing - Refactor is_valid_bugaddr() function. - 2 new patches ([PATCH v5 {1-2}/7]) were introduced, the goal of which is to recalculate addresses used in traps.c, which can be linker time relative. It is needed as we don't have enabled MMU yet. --- Changes in V4: - Rebase the patch series on top of new version of [introduce generic implementation of macros from bug.h] patch series. - Update the cover letter message as 'Early printk' was merged and the current one patch series is based only on [introduce generic implementation of macros from bug.h] which hasn't been commited yet. - The following patches of the patch series were merged to staging: [PATCH v3 01/14] xen/riscv: change ISA to r64G [PATCH v3 02/14] xen/riscv: add header [PATCH v3 03/14] xen/riscv: add header [PATCH v3 05/14] xen/riscv: introduce empty [PATCH v3 06/14] xen/riscv: introduce empty [PATCH v3 07/14] xen/riscv: introduce exception context [PATCH v3 08/14] xen/riscv: introduce exception handlers implementation [PATCH v3 10/14] xen/riscv: mask all interrupts - Fix addressed comments in xen-devel mailing list. --- Changes in V3: - Change the name of config RISCV_ISA_RV64IMA to RISCV_ISA_RV64G as instructions from Zicsr and Zifencei extensions aren't part of I extension any more. - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] - Update commit messages --- Changes in V2: - take the latest riscv_encoding.h from OpenSBI, update it with Xen related changes, and update the commit message with "Origin:" tag and the commit message itself. - add "Origin:" tag to the commit messag of the patch [xen/riscv: add header]. - Remove the patch [xen/riscv: add early_printk_hnum() function] as the functionality provided by the patch isn't used now. - Refactor prcoess.h: move structure offset defines to asm-offsets.c, change register_t to unsigned long. - Refactor entry.S to use offsets defined in asm-offsets.C - Rename {__,}handle_exception to handle_trap() and do_trap() to be more consistent with RISC-V spec. - Merge the pathc which introduces do_unexpected_trap() with the patch [xen/riscv: introduce exception handlers implementation]. - Rename setup_trap_handler() to trap_init() and update correspondingly the patches in the patch series. - Refactor bug.h, remove bug_instr_t type from it. - Refactor decode_trap_cause() function to be more optimization-friendly. - Add two new empty headers: and as they are needed to include which provides ARRAY_SIZE and other macros. - Code style fixes. --- Oleksii Kurochko (6): xen/riscv: introduce temporary printk stuff xen/riscv: introduce dummy xen/riscv: introduce decode_cause() stuff xen/riscv: introduce trap_init() xen/riscv: introduce an implementation of macros from xen/riscv: test basic handling stuff xen/arch/riscv/early_printk.c | 168 ++++++++++++++++++++++ xen/arch/riscv/include/asm/bug.h | 37 +++++ xen/arch/riscv/include/asm/traps.h | 1 + xen/arch/riscv/setup.c | 20 +++ xen/arch/riscv/traps.c | 224 ++++++++++++++++++++++++++++- xen/arch/riscv/xen.lds.S | 10 ++ 6 files changed, 459 insertions(+), 1 deletion(-) create mode 100644 xen/arch/riscv/include/asm/bug.h -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576306.902290 (Exim 4.92) (envelope-from ) id 1qRX59-0003JY-5I; Thu, 03 Aug 2023 12:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576306.902290; Thu, 03 Aug 2023 12:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX58-0003I4-VK; Thu, 03 Aug 2023 12:05:30 +0000 Received: by outflank-mailman (input) for mailman id 576306; Thu, 03 Aug 2023 12:05:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX57-0002sb-BB for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:29 +0000 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [2a00:1450:4864:20::12e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0996ed66-31f6-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 14:05:28 +0200 (CEST) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fe28e4671dso1586007e87.0 for ; Thu, 03 Aug 2023 05:05:28 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0996ed66-31f6-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064328; x=1691669128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EXuF1AtcaFIuqh3RnuzjKGdWBJliPJb+moN2Ah/LYz8=; b=gRt8bvU/HD2PsiCRodzS3I+Wd6vdyLIiKQ6TVGm0bEIXxGG/YxYsgpadjNhjJFOHZc boEcOY8/NMbjRv9OB3eOWkZKhJqR745V4uG2e1gF/zcas7vS3B7rDMzjFgAxL3ZHte/A 7uquNO9uO4p6HiEwGAoCbd/W/vIPXgNn24ofvgvyIPCUrO1quJwWzv6DnjO5LhL9kJj8 TWN+jPlzEcQJjI/Pt9fDkR3m4By3xjDcD2TOExycv5qSsbU3jS2/UphfWu5Sg+pDaheV Y23fPNM55yuLmMC2PsUSd7Y8DRR/JJ/KLsQU3myo7bjQ6rv5j2EGOgvnxxz/L0VYGj/2 69TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064328; x=1691669128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EXuF1AtcaFIuqh3RnuzjKGdWBJliPJb+moN2Ah/LYz8=; b=XZDJotmPe95E1m7X177znlv36qoCeatTRWekwe4BUNxWpAuMRtv7ql9m0RFfPF03Re 2NmU7pJvVTIKjqZtDzUNvNShugsBUVcjN+gidYVkkyTbdaWtwPp83PE1bcvLTsRp0iVH Hc47DwRtbPPWo0Gys9Agj7KyRgFS4Y76unxmCgzzWkAIftucESg5PAmf1RL+vt+S9MuG XC4Z9KByepRD7KUIXgv0jM20B3MEFovMSIKRtAEoRCZUgpq8maID3WyDWeVt5DrV9Vfe VJ505zxuwxFIY5i6I+2REIPBWef1j77OLU9ZjY8dpRDYUQgWQRDhxTw0Z7JDOiOAym+B e0ZQ== X-Gm-Message-State: ABy/qLZwUEmlKa8t1lTfsv8R1eW2A6HCd6KRKptfDjbtfQnMahwKEjyh 727pqh01mYLI3wJFxepFo/QeMO6fpIk= X-Google-Smtp-Source: APBJJlEYKsvurp295A8fafMIlO/Ww5a4Tb9xWwALkTdp3vT1IkXrzdcwiuV8Q5VT2RegS9LqjAY/fQ== X-Received: by 2002:a19:ab09:0:b0:4fe:1ecf:8ab4 with SMTP id u9-20020a19ab09000000b004fe1ecf8ab4mr6014686lfe.18.1691064328125; Thu, 03 Aug 2023 05:05:28 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 4/6] xen/riscv: introduce trap_init() Date: Thu, 3 Aug 2023 15:05:20 +0300 Message-ID: <921ea81d2571ce3103336cd2bf6619b8a8a6751c.1691063432.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V7: - #define cast_to_bug_frame(addr) ((const struct bug_frame *)(addr)). - remove unnecessary comments in trap_init() function. --- Changes in V6: - trap_init() is now called after enabling the MMU. - Add additional explanatory comments. --- Changes in V5: - Nothing changed --- Changes in V4: - Nothing changed --- Changes in V3: - Nothing changed --- Changes in V2: - Rename setup_trap_handler() to trap_init(). - Add Reviewed-by to the commit message. --- xen/arch/riscv/include/asm/traps.h | 1 + xen/arch/riscv/setup.c | 3 +++ xen/arch/riscv/traps.c | 12 ++++++++++++ 3 files changed, 16 insertions(+) diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h index 3fef318478..c30118e095 100644 --- a/xen/arch/riscv/include/asm/traps.h +++ b/xen/arch/riscv/include/asm/traps.h @@ -9,6 +9,7 @@ void do_trap(struct cpu_user_regs *cpu_regs); void handle_trap(void); +void trap_init(void); #endif /* __ASSEMBLY__ */ diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index 6593f601c1..abdd1669c6 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -5,6 +5,7 @@ #include #include +#include /* Xen stack for bringing up the first CPU. */ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] @@ -15,6 +16,8 @@ void __init noreturn start_xen(unsigned long bootcpu_id, { remove_identity_mapping(); + trap_init(); + early_printk("Hello from C env\n"); early_printk("All set up\n"); diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index ea1012e83e..3e08ec44f7 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -12,6 +12,18 @@ #include #include +/* + * Initialize the trap handling. + * + * The function is called after MMU is enabled. + */ +void trap_init(void) +{ + unsigned long addr = (unsigned long)&handle_trap; + + csr_write(CSR_STVEC, addr); +} + static const char *decode_trap_cause(unsigned long cause) { static const char *const trap_causes[] = { -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576307.902299 (Exim 4.92) (envelope-from ) id 1qRX59-0003Vs-R0; Thu, 03 Aug 2023 12:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576307.902299; Thu, 03 Aug 2023 12:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX59-0003SP-HE; Thu, 03 Aug 2023 12:05:31 +0000 Received: by outflank-mailman (input) for mailman id 576307; Thu, 03 Aug 2023 12:05:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX57-0002sb-Qy for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:29 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0976e245-31f6-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 14:05:29 +0200 (CEST) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4fe463420fbso1494136e87.3 for ; Thu, 03 Aug 2023 05:05:29 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0976e245-31f6-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064328; x=1691669128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=STtKrHA1Sag04TDET++CsZtqnaGprv3A+LtpFHsKLZ0=; b=Z0jMj2MbtzzeO2TkiK5IxBi2JLOcWaT3c8iXqSjMnwrOGXZUxChrwf3fJ6Njq9NcVg dRPhoo+l+mJa19wEcxQjU64qTTKCIR8LjyxLYOZpuGEcBwcxJzLogBH7tZhR+fBHizdW FmLkSwomBCgO9l7RqQcN9+WlhoMFMj5mHy7ib5Iit0e2JMzv+CF/muG6vYSt5ZE3ibcU 9spL5V5yElrnhTAlTr0VY2VWfPSYWwt4eke7C56tgnVY8AAAZGF7zM2wXeeQyI2JQu+F hOBIUvJQ8pJHT4KgzwFIu7+j7mGfJ99g2UPQXBYwfo2oRIuL53pJDx6g6jQbq/Yup80D Vv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064328; x=1691669128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=STtKrHA1Sag04TDET++CsZtqnaGprv3A+LtpFHsKLZ0=; b=FHhHILzsQ6yrf0ogRkFl8Z9kMFVZziWB08aFbDB6BZH5TXUyyCNiRIU+ChW2K1no6p fEEyT4ZZC2BGejUVujmMfuaS9u3x6rkeTagQ2QTsXP+yLi0WbigKdu+WJzgQ3npB4vgH CPt5NonHCBcZnfjWW9AJY1ZqFmIa7ygSqMX18X5nVxEFDlAyRcBmWMz36NE5tB57j5/L 4/wt6llg3wY9mOPyp+zGKARqCiWR3KWhHVAlAdcbREK7jQyIXOJEQZGw0bTIn4bbDi7L SstIhBHiZgRvfNmXL1WxVgJYyZJBRryH8Nbn7HwLGewA6ugEUNcttFScY83gQxObwY70 3c/g== X-Gm-Message-State: ABy/qLbY8Wz8RklVU0kExmBABzt4ZV5j+VPwZdtpa4tnVTOgzFrpCRL/ 92wbOolBDu6L3oycsO8sfT9Xo1dkfgA= X-Google-Smtp-Source: APBJJlHvs7TfwdJjxWn0f+qWGjUj7YUnxmhAGYG0gOXVrOItVzjirQEsu0ZTFkM/slG5jIGyujl5Gg== X-Received: by 2002:a05:6512:4003:b0:4f8:7055:6f7e with SMTP id br3-20020a056512400300b004f870556f7emr6298170lfb.44.1691064327475; Thu, 03 Aug 2023 05:05:27 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 3/6] xen/riscv: introduce decode_cause() stuff Date: Thu, 3 Aug 2023 15:05:19 +0300 Message-ID: <25e8e5c5826199ad6f91fb5106472917765d8260.1691063432.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko --- Changes in V7: - Nothing changed. Only rebase. --- Changes in V6: - Remove usage of LINK_TO_LOAD() due to the MMU being enabled first. - Change early_printk() to printk() --- Changes in V5: - Remove from riscv/traps/c as nothing would require inclusion. - decode_reserved_interrupt_cause(), decode_interrupt_cause(), decode_cause, do_unexpected_trap() were made as static they are expected to be used only in traps.c - use LINK_TO_LOAD() for addresses which can be linker time relative. --- Changes in V4: - fix string in decode_reserved_interrupt_cause() --- Changes in V3: - Nothing changed --- Changes in V2: - Make decode_trap_cause() more optimization friendly. - Merge the pathc which introduces do_unexpected_trap() to the current one. --- xen/arch/riscv/traps.c | 84 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index ccd3593f5a..ea1012e83e 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -4,10 +4,92 @@ * * RISC-V Trap handlers */ + +#include + +#include +#include #include #include -void do_trap(struct cpu_user_regs *cpu_regs) +static const char *decode_trap_cause(unsigned long cause) +{ + static const char *const trap_causes[] = { + [CAUSE_MISALIGNED_FETCH] = "Instruction Address Misaligned", + [CAUSE_FETCH_ACCESS] = "Instruction Access Fault", + [CAUSE_ILLEGAL_INSTRUCTION] = "Illegal Instruction", + [CAUSE_BREAKPOINT] = "Breakpoint", + [CAUSE_MISALIGNED_LOAD] = "Load Address Misaligned", + [CAUSE_LOAD_ACCESS] = "Load Access Fault", + [CAUSE_MISALIGNED_STORE] = "Store/AMO Address Misaligned", + [CAUSE_STORE_ACCESS] = "Store/AMO Access Fault", + [CAUSE_USER_ECALL] = "Environment Call from U-Mode", + [CAUSE_SUPERVISOR_ECALL] = "Environment Call from S-Mode", + [CAUSE_MACHINE_ECALL] = "Environment Call from M-Mode", + [CAUSE_FETCH_PAGE_FAULT] = "Instruction Page Fault", + [CAUSE_LOAD_PAGE_FAULT] = "Load Page Fault", + [CAUSE_STORE_PAGE_FAULT] = "Store/AMO Page Fault", + [CAUSE_FETCH_GUEST_PAGE_FAULT] = "Instruction Guest Page Fault", + [CAUSE_LOAD_GUEST_PAGE_FAULT] = "Load Guest Page Fault", + [CAUSE_VIRTUAL_INST_FAULT] = "Virtualized Instruction Fault", + [CAUSE_STORE_GUEST_PAGE_FAULT] = "Guest Store/AMO Page Fault", + }; + + if ( cause < ARRAY_SIZE(trap_causes) && trap_causes[cause] ) + return trap_causes[cause]; + return "UNKNOWN"; +} + +static const char *decode_reserved_interrupt_cause(unsigned long irq_cause) +{ + switch ( irq_cause ) + { + case IRQ_M_SOFT: + return "M-mode Software Interrupt"; + case IRQ_M_TIMER: + return "M-mode TIMER Interrupt"; + case IRQ_M_EXT: + return "M-mode External Interrupt"; + default: + return "UNKNOWN IRQ type"; + } +} + +static const char *decode_interrupt_cause(unsigned long cause) +{ + unsigned long irq_cause = cause & ~CAUSE_IRQ_FLAG; + + switch ( irq_cause ) + { + case IRQ_S_SOFT: + return "Supervisor Software Interrupt"; + case IRQ_S_TIMER: + return "Supervisor Timer Interrupt"; + case IRQ_S_EXT: + return "Supervisor External Interrupt"; + default: + return decode_reserved_interrupt_cause(irq_cause); + } +} + +static const char *decode_cause(unsigned long cause) +{ + if ( cause & CAUSE_IRQ_FLAG ) + return decode_interrupt_cause(cause); + + return decode_trap_cause(cause); +} + +static void do_unexpected_trap(const struct cpu_user_regs *regs) { + unsigned long cause = csr_read(CSR_SCAUSE); + + printk("Unhandled exception: %s\n", decode_cause(cause)); + die(); } + +void do_trap(struct cpu_user_regs *cpu_regs) +{ + do_unexpected_trap(cpu_regs); +} -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576305.902284 (Exim 4.92) (envelope-from ) id 1qRX58-0003Bp-Q1; Thu, 03 Aug 2023 12:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576305.902284; Thu, 03 Aug 2023 12:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX58-0003B0-Kb; Thu, 03 Aug 2023 12:05:30 +0000 Received: by outflank-mailman (input) for mailman id 576305; Thu, 03 Aug 2023 12:05:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX57-0002sc-36 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:29 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 084ba611-31f6-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 14:05:26 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fe2de785e7so1579671e87.1 for ; Thu, 03 Aug 2023 05:05:26 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 084ba611-31f6-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064326; x=1691669126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xJtJCMw7fy83NnUSxcXJn4fOwoFlzc9n7K+NQt3JNLk=; b=RNWNGd0waEqqsrrlGRF6VMWNTiCqywapKS5vo7BDm/+3b5nQYmkZLLkCFu+QhGUnCI A3mkbvy/dM7C31HgETx5n8dfAM2ieUsPJ75KPDq34gzwYkKpibRifIyqzKh9tbAcC2wb FzLAgrAq0BSwkJAGEgh/krJdAZ53EqRqQfki7kt9+MdkNdyy0jFqbzGJ4PNJPoDCioFV ZWvzf6YQxuqJ+A6s6+uDZFIlrFYSODlraxDAa7vJZGVNttm5r54eJMASsoCKj0uvtbFC 8TxuzXpx7a8n5/aUv94EYHpsxqQDES986incGMJPV9DnoPFDLIwflke/HNChmXsyeM8N know== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064326; x=1691669126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xJtJCMw7fy83NnUSxcXJn4fOwoFlzc9n7K+NQt3JNLk=; b=UXE2H3ruglHdDd2KB9wyZ54dxrHlikIDOBZR4VpyciFgzMaa/Q6cvTQTMJOtSZxiW8 rl0OLkrVGcHRyC05bXf40MWRa299S8/5VekpHIGfQ9Du6QxeFyJ/JKk94W4Dpd6pDagT 68kWtCqygGNRqqmo5m7I1yNHxdemlRjela4Woouy++lOqTfLI23jsHmU3RIAVW929uM5 Z8hBOhrCGwOCZqDxtRHnM/vloCSLDtJaOx9yXZzePNBoP9zAFp2ml/MLWuwHuP7sESGZ lUgfZEioTlmQBWOF4DIXyl02I7NNLjVpXxe0kJ+Oojvvz70Z4llJGXJ0uFi97CSD41gF hAyA== X-Gm-Message-State: ABy/qLa9TdQ2Zh+DrG5UaRgNCdd1+iLzcCbNLdBDctqikXx+15w5wXIT lsCjguoHr/3zVi/Do9f2rGYWZsCvW/I= X-Google-Smtp-Source: APBJJlHetGi4rKmwdsyTXvWMkMyAuaRKX7fJZoGlpHhx8H9/f9PpXxsZXR+gKwxg7MV/tlVe56k1+g== X-Received: by 2002:a05:6512:2009:b0:4f8:6560:6436 with SMTP id a9-20020a056512200900b004f865606436mr6501358lfb.9.1691064325827; Thu, 03 Aug 2023 05:05:25 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 1/6] xen/riscv: introduce temporary printk stuff Date: Thu, 3 Aug 2023 15:05:17 +0300 Message-ID: <4fbdbbb3bf2bf2ebee2709bbb52be02c89a4a55a.1691063432.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introdcuces printk related stuff which should be deleted after Xen common code will be available. Signed-off-by: Oleksii Kurochko --- Changes in V7: - only rebase was done. --- Changes in V6: - the patch was introduced in the current patch series (V6) --- xen/arch/riscv/early_printk.c | 168 ++++++++++++++++++++++++++++++++++ 1 file changed, 168 insertions(+) diff --git a/xen/arch/riscv/early_printk.c b/xen/arch/riscv/early_printk.c index 610c814f54..60742a042d 100644 --- a/xen/arch/riscv/early_printk.c +++ b/xen/arch/riscv/early_printk.c @@ -40,3 +40,171 @@ void early_printk(const char *str) str++; } } + +/* + * The following #if 1 ... #endif should be removed after printk + * and related stuff are ready. + */ +#if 1 + +#include +#include + +/** + * strlen - Find the length of a string + * @s: The string to be sized + */ +size_t (strlen)(const char * s) +{ + const char *sc; + + for (sc = s; *sc != '\0'; ++sc) + /* nothing */; + return sc - s; +} + +/** + * memcpy - Copy one area of memory to another + * @dest: Where to copy to + * @src: Where to copy from + * @count: The size of the area. + * + * You should not use this function to access IO space, use memcpy_toio() + * or memcpy_fromio() instead. + */ +void *(memcpy)(void *dest, const void *src, size_t count) +{ + char *tmp = (char *) dest, *s = (char *) src; + + while (count--) + *tmp++ = *s++; + + return dest; +} + +int vsnprintf(char* str, size_t size, const char* format, va_list args) +{ + size_t i = 0; /* Current position in the output string */ + size_t written = 0; /* Total number of characters written */ + char* dest = str; + + while ( format[i] != '\0' && written < size - 1 ) + { + if ( format[i] == '%' ) + { + i++; + + if ( format[i] == '\0' ) + break; + + if ( format[i] == '%' ) + { + if ( written < size - 1 ) + { + dest[written] = '%'; + written++; + } + i++; + continue; + } + + /* + * Handle format specifiers. + * For simplicity, only %s and %d are implemented here. + */ + + if ( format[i] == 's' ) + { + char* arg = va_arg(args, char*); + size_t arglen = strlen(arg); + + size_t remaining = size - written - 1; + + if ( arglen > remaining ) + arglen = remaining; + + memcpy(dest + written, arg, arglen); + + written += arglen; + i++; + } + else if ( format[i] == 'd' ) + { + int arg = va_arg(args, int); + + /* Convert the integer to string representation */ + char numstr[32]; /* Assumes a maximum of 32 digits */ + int numlen = 0; + int num = arg; + size_t remaining; + + if ( arg < 0 ) + { + if ( written < size - 1 ) + { + dest[written] = '-'; + written++; + } + + num = -arg; + } + + do + { + numstr[numlen] = '0' + num % 10; + num = num / 10; + numlen++; + } while ( num > 0 ); + + /* Reverse the string */ + for (int j = 0; j < numlen / 2; j++) + { + char tmp = numstr[j]; + numstr[j] = numstr[numlen - 1 - j]; + numstr[numlen - 1 - j] = tmp; + } + + remaining = size - written - 1; + + if ( numlen > remaining ) + numlen = remaining; + + memcpy(dest + written, numstr, numlen); + + written += numlen; + i++; + } + } + else + { + if ( written < size - 1 ) + { + dest[written] = format[i]; + written++; + } + i++; + } + } + + if ( size > 0 ) + dest[written] = '\0'; + + return written; +} + +void printk(const char *format, ...) +{ + static char buf[1024]; + + va_list args; + va_start(args, format); + + (void)vsnprintf(buf, sizeof(buf), format, args); + + early_printk(buf); + + va_end(args); +} + +#endif + -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576303.902268 (Exim 4.92) (envelope-from ) id 1qRX57-0002sy-9x; Thu, 03 Aug 2023 12:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576303.902268; Thu, 03 Aug 2023 12:05:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX57-0002sr-5Q; Thu, 03 Aug 2023 12:05:29 +0000 Received: by outflank-mailman (input) for mailman id 576303; Thu, 03 Aug 2023 12:05:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX56-0002sb-6b for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:28 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08974c9d-31f6-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 14:05:27 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe48d0ab0fso1506314e87.1 for ; Thu, 03 Aug 2023 05:05:27 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08974c9d-31f6-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064326; x=1691669126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y+DU3kYIXVYlczgnjPIgAblT5y0PqecHU2rZnswjn2g=; b=QpM/5DX/BO83ao1VktAURaEd5vCgzt+w0XxW1EJmZXBfkcFVuYv39XZXGen2V/W4T0 tGVUo5RgkpDe4TE2w+dlXerXCXb8ZTG60Rf1Xp4Oep2MG4X5l/PLahyMovcjcZlONjtk BqEQgZBg2fzjkK8GQ1QYllV7nixVPOpRM/MzlfMspE00SQIuskK9asiii0eAkBrluog6 Ohy+t7XsnC/3L0iDYVdEbl5hTNsTkbutZ5WMefoIPETJUFK73EMT9MzfACcvEsXFvv9P fgqhkZ3fYsPp2rwIeYJmEYhPShKTe507oRgPGCj+xKE6cJiQrLgvbsyi9ttpjOSMAT6F tNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064326; x=1691669126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+DU3kYIXVYlczgnjPIgAblT5y0PqecHU2rZnswjn2g=; b=cnFHttdE7hRW8E9z7ofdcgBRw9I5oWfs+rFw9T+CQLoVL9s1IeZxK55EvihLDj69+L tV6ba2vusfsuJb1cmIIsNWUZEYvUBeoieRhVdXWgpn1MCoO7+l681xMBwzqoEk/3Zpm9 JuOTlmErvCFbrkHduP1Dk4U57QL3ZvLXTMVcLErBBqnXvU5Ijd5KCFUASjpNjW+aff7g uGiRIstWQB61k4/q7KjYj5PSzpd4q8HKAesaAMI2DSzzyWlDN0YiEfZxAwlKpFk0bpAK ie/bVpEnjVv5G6AFJxwXLFoBXC5K6lwp8jIjbSc+l+I8M/B791Jkoy8PBhhYqgVEgKkI ZU7Q== X-Gm-Message-State: ABy/qLYwxxTuKDyngEqXIYY1BhA2aZY1cNETapvA3vFlFOzw1PGdwvRj 1XWHwQR0L5BMb9as9M3e/7NvnsJ2Qds= X-Google-Smtp-Source: APBJJlEbonaD9/0BAPXd1RpRxUS7o9+LRSnGh1aH+kdhyaTHliEbakbUGPrbaDGLYJumlFmokTiuTQ== X-Received: by 2002:a05:6512:2253:b0:4fe:711:2931 with SMTP id i19-20020a056512225300b004fe07112931mr7480300lfu.22.1691064326389; Thu, 03 Aug 2023 05:05:26 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 2/6] xen/riscv: introduce dummy Date: Thu, 3 Aug 2023 15:05:18 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit will be used in the patch "xen/riscv: introduce decode_cause() stuff" and requires Signed-off-by: Oleksii Kurochko --- Changes in V7: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed. Only rebase. --- Changes in V5: * the patch was introduced in the current patch series (V5) --- xen/arch/riscv/include/asm/bug.h | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 xen/arch/riscv/include/asm/bug.h diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h new file mode 100644 index 0000000000..e8b1e40823 --- /dev/null +++ b/xen/arch/riscv/include/asm/bug.h @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2012 Regents of the University of California + * Copyright (C) 2021-2023 Vates + * + */ +#ifndef _ASM_RISCV_BUG_H +#define _ASM_RISCV_BUG_H + +#endif /* _ASM_RISCV_BUG_H */ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576308.902316 (Exim 4.92) (envelope-from ) id 1qRX5B-00042e-5d; Thu, 03 Aug 2023 12:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576308.902316; Thu, 03 Aug 2023 12:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX5A-000418-Rf; Thu, 03 Aug 2023 12:05:32 +0000 Received: by outflank-mailman (input) for mailman id 576308; Thu, 03 Aug 2023 12:05:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX59-0002sb-M7 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:31 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0af92a90-31f6-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 14:05:31 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fe1c285690so1484750e87.3 for ; Thu, 03 Aug 2023 05:05:31 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0af92a90-31f6-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064330; x=1691669130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VSibP5eTiQgTk20HjOHTiUPAjHnFr8NTK33Zlp/pEgM=; b=W6CAZlzPU+q9DyJ4PxnDSCSGu2OKImYbHfsVDqpgeVcB03n78aqZo+OJFUKhCPpqvA 3SGs0+aJjno9H1WyopozDLnhJxISIFMSaxf5NLJQGEzb1CHm3DRvfh91cn4q4EnPj/3q 3a8Ty1x2z0FR5T7q7R4eXyMRFrgt1P1V6BAZYkNWfIfMb00+HcdlcLNohfNaY8ftV67s 5f5FqWruN5SCnuRSge+9zxNRYLGgHQYSuE2wFv3eZOP/uzY3NBlO7s9B0QGBVll4u7mP NFqXGNaUDBqtsDocKl8aBME+k7rlfkieewXMxj3i5iq1bVXVPJulwavaLh5wgZhIicWm 0VXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064330; x=1691669130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VSibP5eTiQgTk20HjOHTiUPAjHnFr8NTK33Zlp/pEgM=; b=EOC2fxJzBMSbmepzTzArxx+7G03PXK0jH5oK5t2wuCoSqiBY/DSO1a+4rf+8zuFFuQ aA4ell+Ff7PmY5c63LVaPXCdhyocZsweivTg5Bud1cXJ4n9RFf5Uz8R/xvKa6tBidS50 roUiDXwt9lTA81oYvIWTB1XojQsRVGkWVV6VF4j6C54ATEQYrslA9eXR2oHOHhla1XJ7 h++MAQK5BwQDBLnO7DAG1RcrgHY/z++XEm34l+/pOSlJC8IFAe5gfwTOkk1HI/AV9dmH 4IBxlbkWCecZLEo+Jw77YAhplxlxBDPZjTC7ZSQHQMNHXb+UHrUZ4T2LEx9zOr96gPNo chHQ== X-Gm-Message-State: ABy/qLbKmrqzKWkCdOeR8AM/isJExFwj4ZqcEPwPo+PN37X6sJxQEMqx VAzKicEwdV2JJ7hehx2audqx4a88GWg= X-Google-Smtp-Source: APBJJlG4UqEUWpc3dVF03OxtTwW2iHbpqYjBVtCRroEIaKyZdZ+eNxE4rlulDSKQ0g3NphinHlIrvA== X-Received: by 2002:a05:6512:2521:b0:4f7:6775:2a66 with SMTP id be33-20020a056512252100b004f767752a66mr8694805lfb.53.1691064330433; Thu, 03 Aug 2023 05:05:30 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 6/6] xen/riscv: test basic handling stuff Date: Thu, 3 Aug 2023 15:05:22 +0300 Message-ID: <89553c7196a3e01294a17a0ae3946544b1b14e04.1691063432.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V6: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed --- Changes in V5: - Nothing changed --- Changes in V4: - Add Acked-by: Alistair Francis --- Changes in V3: - Nothing changed --- Changes in V2: - Nothing changed --- xen/arch/riscv/setup.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index abdd1669c6..ab83f84e67 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include #include #include @@ -11,6 +12,20 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); +static void test_run_in_exception(struct cpu_user_regs *regs) +{ + early_printk("If you see this message, "); + early_printk("run_in_exception_handler is most likely working\n"); +} + +static void test_macros_from_bug_h(void) +{ + run_in_exception_handler(test_run_in_exception); + WARN(); + early_printk("If you see this message, "); + early_printk("WARN is most likely working\n"); +} + void __init noreturn start_xen(unsigned long bootcpu_id, paddr_t dtb_addr) { @@ -18,6 +33,8 @@ void __init noreturn start_xen(unsigned long bootcpu_id, trap_init(); + test_macros_from_bug_h(); + early_printk("Hello from C env\n"); early_printk("All set up\n"); -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:05:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:05:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576309.902320 (Exim 4.92) (envelope-from ) id 1qRX5B-000461-Cx; Thu, 03 Aug 2023 12:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576309.902320; Thu, 03 Aug 2023 12:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX5B-000455-63; Thu, 03 Aug 2023 12:05:33 +0000 Received: by outflank-mailman (input) for mailman id 576309; Thu, 03 Aug 2023 12:05:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRX59-0002sc-P8 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:05:31 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a391522-31f6-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 14:05:29 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fe0e23a4b1so1554116e87.3 for ; Thu, 03 Aug 2023 05:05:29 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id e22-20020ac25476000000b004fdfefdf4acsm3304557lfn.39.2023.08.03.05.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 05:05:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a391522-31f6-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691064329; x=1691669129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n0T/c4H8PYV8a+tUf8bqa7kNmhfFOIl+4o24A/6F65Y=; b=m802bzewGsdutyqXiwNNiqsYfn3M4z9y5xCanYDSAoA3f8ePVkg/q+T3QSz1krZJbW jjE8Xme9E05+k17DEBsRkiMxZZykmstizUoamdINVEJCYaIYmeHaHYC9ZVoVkasrusoA uf5rdFd9/O+WPvJhaFwBNPQs2EImt+HITbwLhyIKB2WpT/gVrGZpyDy/LQDO4RiHAiPz gov6/EsKwHHrHiJ03r9iFFaks7XPrryTi/ovEt/VWVMnw0jgF22Xz7tTfh9cI5elTtD2 5VfQWJx/V7Y2a1p0RNkqKmTGedc6bUl0Rh/szGEDOmkoLoM9ZDoxeEEKbtVLYPeUx8Ob O8xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691064329; x=1691669129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n0T/c4H8PYV8a+tUf8bqa7kNmhfFOIl+4o24A/6F65Y=; b=iKYl6iSfjwVm7hBvMLRCItxmHJYRF9QbfVImBux0YncG32F06xsVe31eMDWjJ0+vie hXyyXCmiMKFBszlw9D7JtTFL74Gn6Ue2tAKRrX7bcktHsWx0R+FPu0kPMITQ19S+J8YZ 5vks78AEE4lWi+8mD6Y3+vOK2c7JUpddKeVNEpQvltD16Kkwi3IPbqxmk6ySrwVEbxfd IMc/tF4f8KqI+SM0jkAc18/UnVZ4xdAUoEpGX8M8WHWMrQhqXLKiuQzr8pnCDsr4zEkb vZHGjLoYWaFwhKfrP1BAtYLRLBd6R7HRh+fPIvmpAXIG7pN5/7rgtKMG1tWVA0JfeiJ0 EbGg== X-Gm-Message-State: ABy/qLY60VFWowZGvnfR/5SRbw1eD9uO5VITQs4c4IVhsXXyoYxpaUpx KUFFmj77MAhjFD7c+V9N0pZj4SWzuCk= X-Google-Smtp-Source: APBJJlFcG/cnXqx2b/EBsYl3rOroJ1/VDytVVW7Wh4XLH1gBRwg4iEuipD+1UxKgXe6vmMzf+NnUCA== X-Received: by 2002:ac2:5b4e:0:b0:4fe:1f1c:184f with SMTP id i14-20020ac25b4e000000b004fe1f1c184fmr7005761lfp.44.1691064329028; Thu, 03 Aug 2023 05:05:29 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 5/6] xen/riscv: introduce an implementation of macros from Date: Thu, 3 Aug 2023 15:05:21 +0300 Message-ID: <9fdda7716faf412f1e2cdf9a990c98e64c4b21f3.1691063432.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. To be precise, the macros from generic bug implementation () will be used. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. Signed-off-by: Oleksii Kurochko --- Changes in V7: - move to this patch the definition of cast_to_bug_frame() from the previous patch. - update the comment in bug.h. - update the comment above do_bug_frame(). - fix code style. - add comment to read_instr func. - add space for bug_frames in lds.S. --- Changes in V6: - Avoid LINK_TO_LOAD() as bug.h functionality expected to be used after MMU is enabled. - Change early_printk() to printk() --- Changes in V5: - Remove "#include " from as there is no any need in it anymore - Update macros GET_INSN_LENGTH: remove UL and 'unsigned int len;' from it - Remove " include " from risc/setup.c. it is not needed in the current version of the patch - change an argument type from vaddr_t to uint32_t for is_valid_bugaddr and introduce read_instr() to read instruction properly as the length of qinstruction can be either 32 or 16 bits. - Code style fixes - update the comments before do_bug_frame() in riscv/trap.c - Refactor is_valid_bugaddr() function. - introduce macros cast_to_bug_frame(addr) to hide casts. - use LINK_TO_LOAD() for addresses which are linker time relative. --- Changes in V4: - Updates in RISC-V's : * Add explanatory comment about why there is only defined for 32-bits length instructions and 16/32-bits BUG_INSN_{16,32}. * Change 'unsigned long' to 'unsigned int' inside GET_INSN_LENGTH(). * Update declaration of is_valid_bugaddr(): switch return type from int to bool and the argument from 'unsigned int' to 'vaddr'. - Updates in RISC-V's traps.c: * replace /xen and /asm includes * update definition of is_valid_bugaddr():switch return type from int to bool and the argument from 'unsigned int' to 'vaddr'. Code style inside function was updated too. * do_bug_frame() refactoring: * local variables start and bug became 'const struct bug_frame' * bug_frames[] array became 'static const struct bug_frame[] = ...' * remove all casts * remove unneeded comments and add an explanatory comment that the do_bug_frame() will be switched to a generic one. * do_trap() refactoring: * read 16-bits value instead of 32-bits as compressed instruction can be used and it might happen than only 16-bits may be accessible. * code style updates * re-use instr variable instead of re-reading instruction. - Updates in setup.c: * add blank line between xen/ and asm/ includes. --- Changes in V3: - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] --- Changes in V2: - Remove __ in define namings - Update run_in_exception_handler() with register void *fn_ asm(__stringify(BUG_FN_REG)) = (fn); - Remove bug_instr_t type and change it's usage to uint32_t --- xen/arch/riscv/include/asm/bug.h | 27 +++++++ xen/arch/riscv/traps.c | 128 +++++++++++++++++++++++++++++++ xen/arch/riscv/xen.lds.S | 10 +++ 3 files changed, 165 insertions(+) diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/asm/bug.h index e8b1e40823..f5ff96140f 100644 --- a/xen/arch/riscv/include/asm/bug.h +++ b/xen/arch/riscv/include/asm/bug.h @@ -7,4 +7,31 @@ #ifndef _ASM_RISCV_BUG_H #define _ASM_RISCV_BUG_H +#ifndef __ASSEMBLY__ + +#define BUG_INSTR "ebreak" + +/* + * The base instruction set has a fixed length of 32-bit naturally aligned + * instructions. + * + * There are extensions of variable length ( where each instruction can be + * any number of 16-bit parcels in length ). + * + * Compressed ISA is used now where the instruction length is 16 bit and + * 'ebreak' instruction, in this case, can be either 16 or 32 bit ( + * depending on if compressed ISA is used or not ) + */ +#define INSN_LENGTH_MASK _UL(0x3) +#define INSN_LENGTH_32 _UL(0x3) + +#define BUG_INSN_32 _UL(0x00100073) /* ebreak */ +#define BUG_INSN_16 _UL(0x9002) /* c.ebreak */ +#define COMPRESSED_INSN_MASK _UL(0xffff) + +#define GET_INSN_LENGTH(insn) \ + (((insn) & INSN_LENGTH_MASK) == INSN_LENGTH_32 ? 4 : 2) \ + +#endif /* !__ASSEMBLY__ */ + #endif /* _ASM_RISCV_BUG_H */ diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c index 3e08ec44f7..439c098c22 100644 --- a/xen/arch/riscv/traps.c +++ b/xen/arch/riscv/traps.c @@ -5,6 +5,8 @@ * RISC-V Trap handlers */ +#include +#include #include #include @@ -12,6 +14,8 @@ #include #include +#define cast_to_bug_frame(addr) ((const struct bug_frame *)(addr)) + /* * Initialize the trap handling. * @@ -101,7 +105,131 @@ static void do_unexpected_trap(const struct cpu_user_regs *regs) die(); } +void show_execution_state(const struct cpu_user_regs *regs) +{ + printk("implement show_execution_state(regs)\n"); +} + +/* + * TODO: generic do_bug_frame() should be used instead of current + * implementation panic(), printk() and find_text_region() + * (virtual memory?) will be ready/merged + */ +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) +{ + const struct bug_frame *start, *end; + const struct bug_frame *bug = NULL; + unsigned int id = 0; + const char *filename, *predicate; + int lineno; + + static const struct bug_frame *bug_frames[] = { + &__start_bug_frames[0], + &__stop_bug_frames_0[0], + &__stop_bug_frames_1[0], + &__stop_bug_frames_2[0], + &__stop_bug_frames_3[0], + }; + + for ( id = 0; id < BUGFRAME_NR; id++ ) + { + start = cast_to_bug_frame(bug_frames[id]); + end = cast_to_bug_frame(bug_frames[id + 1]); + + while ( start != end ) + { + if ( (vaddr_t)bug_loc(start) == pc ) + { + bug = start; + goto found; + } + + start++; + } + } + + found: + if ( bug == NULL ) + return -ENOENT; + + if ( id == BUGFRAME_run_fn ) + { + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); + + fn(regs); + + goto end; + } + + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ + filename = bug_ptr(bug); + lineno = bug_line(bug); + + switch ( id ) + { + case BUGFRAME_warn: + printk("Xen WARN at %s:%d\n", filename, lineno); + + show_execution_state(regs); + + goto end; + + case BUGFRAME_bug: + printk("Xen BUG at %s:%d\n", filename, lineno); + + show_execution_state(regs); + + printk("change wait_for_interrupt to panic() when common is available\n"); + die(); + + case BUGFRAME_assert: + /* ASSERT: decode the predicate string pointer. */ + predicate = bug_msg(bug); + + printk("Assertion %s failed at %s:%d\n", predicate, filename, lineno); + + show_execution_state(regs); + + printk("change wait_for_interrupt to panic() when common is available\n"); + die(); + } + + return -EINVAL; + + end: + return 0; +} + +static bool is_valid_bugaddr(uint32_t insn) +{ + return insn == BUG_INSN_32 || + (insn & COMPRESSED_INSN_MASK) == BUG_INSN_16; +} + +/* Should be used only in Xen code ? */ +static uint32_t read_instr(unsigned long pc) +{ + uint16_t instr16 = *(uint16_t *)pc; + + if ( GET_INSN_LENGTH(instr16) == 2 ) + return (uint32_t)instr16; + else + return *(uint32_t *)pc; +} + void do_trap(struct cpu_user_regs *cpu_regs) { + register_t pc = cpu_regs->sepc; + uint32_t instr = read_instr(pc); + + if ( is_valid_bugaddr(instr) ) + { + if ( !do_bug_frame(cpu_regs, pc) ) + { + cpu_regs->sepc += GET_INSN_LENGTH(instr); + return; + } + } + do_unexpected_trap(cpu_regs); } diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 3fa7db3bf9..a10e0ad87c 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -45,6 +45,16 @@ SECTIONS . = ALIGN(PAGE_SIZE); .rodata : { _srodata = .; /* Read-only data */ + /* Bug frames table */ + __start_bug_frames = .; + *(.bug_frames.0) + __stop_bug_frames_0 = .; + *(.bug_frames.1) + __stop_bug_frames_1 = .; + *(.bug_frames.2) + __stop_bug_frames_2 = .; + *(.bug_frames.3) + __stop_bug_frames_3 = .; *(.rodata) *(.rodata.*) *(.data.rel.ro) -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:19:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576334.902339 (Exim 4.92) (envelope-from ) id 1qRXIf-0007pb-Oh; Thu, 03 Aug 2023 12:19:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576334.902339; Thu, 03 Aug 2023 12:19:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXIf-0007pU-IY; Thu, 03 Aug 2023 12:19:29 +0000 Received: by outflank-mailman (input) for mailman id 576334; Thu, 03 Aug 2023 12:19:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXId-0007pO-Nh for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:19:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fcdaaee8-31f7-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 14:19:26 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB9957.eurprd04.prod.outlook.com (2603:10a6:102:385::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 12:19:24 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 12:19:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcdaaee8-31f7-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BaYwzBPEX9lr2OJVd1/Arq/DJhrPKi1q/bc/j7ya3lWX9fi6b8ob4z/887Vl8s4Ohv/75OaPIF2dz5pX5G+DtLZulkp8Sav4CANd6O5Cno2Ff7aCT1VvFdlap0cHin7JGLx5uu6msAmhg43iF+pD1xaTlwETDppPrKNDHvA5Tz+uBylZtsurtNOXlMBvpk0GVFlV5MUTo8lc2QZ6NbOCeUXkRwXzwgM+XXRcZaA+cuk8KaehSrBaJldKx4PLGdMoYtEYJbmEFfkvZtBnCsF3xKZq08/Tegk0vIjuf+O9w+77AtqPQB5E0+7WQW+leAxF7jDyZApK7bCg21565pU9Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4dhR017bDjrmKAEZTxdhb12weLlVVl90mgs3HHFP1mQ=; b=cb/K/GwQYZAQo4+8aY9amQ1ASgkqMyMLk9deFJJxlCEplSdqg5h2CfIm1O6uHCchVXuLPJJT7HiDjH6ugzmglCZIK1/USsNGsVOFC1+ITlZ77TEWT2kXVHtUFIoXxwTlVqP22cT7L6QCeIFdww7FIormHBxp1YkUhP3JvB8GGD8WwH1RNEcnk6rTY6OqYHZYPLDyUOZ1D857m3mCWMG5SsGYgZcVkxlELEaEZn6YBM12uSxqhYuSKlP8jFgrLFHJbbkf5VBksTgtjljxmzhH+jD0uoTQ9FYZaac9GsL8kjBuYbNMY9E6U7nA+XNd+eitXbFihhUvdL9CwXIAqSYyEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4dhR017bDjrmKAEZTxdhb12weLlVVl90mgs3HHFP1mQ=; b=AtqngBJpoGB6ggEiJvgtgd7+czBIwgUZCdsnMoRueCzDIzxjexqPelMMz4bsnAywvN909sZ2i5HEPioc8WqW+2bpyxLTgLwTygwhmso7oDWdWUa4T/X+ufjfqUhQ2StkVk6iuusvEJ/bduxpfUJ4k127IP+pti6gMNPxCCF7mbR2C7pUxO6GHfBIbk21xf7aRGuYgbOxtbnJgJjNRf6Y/Lwh1Fvjt+sZnq+vOdBCJG5fN/PtJdby7q5c7drtee/OqNbQFI7NOki3MkCKtmp0dsal9XIaJLOtDCylwp0Ypu6N4QfUheNGhHU67SE79gPksxIYoeHr8RpUL9K/XjxjUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <52a02ef3-80a7-9000-4644-38adbb5a2573@suse.com> Date: Thu, 3 Aug 2023 14:19:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230803104438.24720-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB9957:EE_ X-MS-Office365-Filtering-Correlation-Id: 0773aea1-301c-4a54-e1cb-08db941bdf96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pp7oYPnCZVLhTJfM1bQg6MG0CRlLIrCVH7gf258mfLT/wYXwHpcfhmY+Z4M21r+9gfaVeX2pgChZZff98IsyLCkdRsKYGmpHh7/VSHU4I3GrZMek4J0QkgdWwXrvsgoDHEzz2Az4c7G1avaSfZqSrwR390DbPmexhEsevf43eF4YWyagbtXs8SLbTBcUEWyLnfOUxNhMNqwUxHhIwANaYn3QUAwYz5cburzuVZ8ew29I0TG7btQkTuZy0GbxoqM5//pIpq//r0oiRB+heVZEWLs7B34LOnFtSgTN3UImKutv0BSBRbEZS2OuEsW7xSNf8+HPtbYxc1XXqZbJJDLCeXdtMa2oONJsaHzgGUWnCM33NTMsGHZXZh6stzpPVeSqGz0PB+g89G3QpwdHKQUhFsPRipVDH0DDqXb8FvA/TAVuUX/x6KJkF3yhkIZwxqp8iO6gdqLgReSaVKfvPMrdv4Mih6F01bFsmlAhPtC+8Ea2CahW/VHzE+47XqaBuHdw0D0zUnTNThQs0wsi2ixk/MEJjCl6UxEvoY477YPYNl9wKeGHbkT1uy61ZQZ8hppupIaec4Uj6hIp3Thwh4jig+q6cJoFK2XPT35kcZg8FS77ZIyOeC6f3OmzjwY7hAae X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(366004)(396003)(136003)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(316002)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(41300700001)(8676002)(8936002)(6486002)(6666004)(966005)(6512007)(54906003)(478600001)(38100700002)(36756003)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk95WWljb3U0YzdkWVBkMFZmd3loS2VaM3d3b3BlZVZYMDVwK2FIQkpMUkZG?= =?utf-8?B?QmdmeVNYSGpxV1pyalVPbTdFSW5pTnFGWjJjczU5alI4NG5rYnBPaVlkcTMy?= =?utf-8?B?QUZaYUtaZTc2WnlRU0NLQXdTSFhxMy9TRHdmOCtZOHZkSnlYN0RtcGd5WFVu?= =?utf-8?B?TjRDeE9uMXF6K0RuWmpGeldJMHdaVC9uVWFEaStiQnR3KzVOZDZKNUJJVE9W?= =?utf-8?B?b1pmVW4xTW0wSWRQNDlHaUhwTG9CK1RWOTQ0bHJ2c29DN05sOHF1cytJZ2RR?= =?utf-8?B?RFB5cjVkcnR1dlZROXBjZk55TmNCVXB6K0pRcXJGRW9GOWJ0WG1wNUExcUFV?= =?utf-8?B?T1JjbFoyd0ZNMm43RGMrTFVyWlNlemZmSjc0aUpzalZzZDlnV0hselhpNU43?= =?utf-8?B?ZVBDZEtpQkc0M1FEeTN3Z0R6dmFRdkhoL2pFclZFVDdQcEtHMUw1dEZBNlRS?= =?utf-8?B?aW9UMU9jVWlZUCtTK2xBSExOaGRsWS9GWGhNU0pydFhvaTArb294dld4dFpn?= =?utf-8?B?UVJLRHZKU0s1ajV4dXlJOE5FeWZ0SWxCMnkrR1ZGdGxpU0N0SVhhTjFKc3Vh?= =?utf-8?B?NmFMdkFvMlV6U2VydTRsZjRkVUJ2R1ZCNjh5Uk5jZEUzMnRSNGdCcUFBMHA3?= =?utf-8?B?dm55U0VSYmd5c015MzVnR1N1MFdGZDIrQ25VMHRweENFeVhvNVFITUZGZGZS?= =?utf-8?B?ZTFaSkl6cE9URVh2ZVV1eXJLMXNmcmx6QUNHRzh1aUlXV1hFRWtwVEt0dmVQ?= =?utf-8?B?N3dkSEt3dzhIRGJFTkErYmNHa2VLOC9pMHlqaWNHaWpMbEdROGFNbDhySHFt?= =?utf-8?B?czdFaDNjQTlpUENKZTBRQ3JrT1BFNVlWaUxXRnFXOUtHcUFQYVlvWTBrTkdr?= =?utf-8?B?aXpzZjc0emJNY0Zva2JTOTJ5U1lBZXo0K2ZHMUpJNWJBK2pZNUJ1QjhTS2dE?= =?utf-8?B?MGhMaHpMdGlOcWRST016V2R3N2llUktQR2dtU2piU0VnSG04cmZaejhlbm9i?= =?utf-8?B?NkwvL3I3aTFtLzFDUGYxTlA0WXczb0tOZ1FRUFBPRXF0K1pnc0ZzT3FseEx4?= =?utf-8?B?d0hWb24yRHY1NUdpbHFWMmp1L3dJeWpFWmp5UER3Y2xtcXc3TGR3Mk1Rcks2?= =?utf-8?B?bWZQN1JLZ05RNVRsNVFSRTRYSHZMQTVZSGNFaWhTRWJobWphVHIydXBJT2gz?= =?utf-8?B?K05YdC92MFNFTnhTT1daak5XT2thQk1KYUxjcVpac2w1V2p0blBPNzFLSEEr?= =?utf-8?B?UCtuU1daWllkcjloNUZXVmJVTmNaNUhUM0xRSDh4VWRUVXBHMkI0UmFIY0Vo?= =?utf-8?B?T2pKUnUyTVBBdzRZYVZ3YWdWU3JzSmZIeUVLVXY5Y1hkaUhudEdLZWdndW0x?= =?utf-8?B?bDRaMldJeEg1UXZvc09qR1IxNUdORm9VcCtpVW5yMmhJUkZtUnNVRi8yTCs3?= =?utf-8?B?UTB6Y3VBUG4xUjJjblN6SXJuVm10Q1Z4M0gxcGJFcVo2cXFwdWhGblpjcjhH?= =?utf-8?B?TWJQKzJkOTd3bWRncFRPNkIya3gremlhU3NkdTA2dHFMbENrY0VGaTB4N0xL?= =?utf-8?B?V0UvdTEvOFFYMWRNMFRuWTkwaVovcHVNT1hZSnJGOXhzMWt6WjhxOGNGQ1g5?= =?utf-8?B?OW9ITmNLTGpUTDdZc092WmRuNmxlRUNLMy8zTVJmWGM3d1RicDZVa05iZ3JQ?= =?utf-8?B?VGJaR0szL0lVYzVrSEY2aHpwRSttL0txQXM4RUVPVkNXSjdFRUo0d0U2amZh?= =?utf-8?B?YU5JaUhqNlIyOTd1eDNIdVNTVjhWMHNKdjF1RkVhM1duS1c0TmcwQzViLzhr?= =?utf-8?B?YzhqYVZwYXBpa1M1WUo0WHAxT1RIZzdrMHFGa2hmNFNtUm9Qb1M4cGY2QlVV?= =?utf-8?B?Q0pJd0czcDFNcmJaOWM0aGh3TEN6ZkFlNnIrZUZsNEFMQ1lxYllIYlkrVzlU?= =?utf-8?B?emFBdXdlTlcyaTMvbE9Cb1pBSG90a1d2RVgwUU1zV2tjMk5NWU4vUTJzZzND?= =?utf-8?B?ZVhneFBteW9rd0dLTG95QVpvYlVFL1lKeUZmTk1uanJnckx1bENPSXl6L1hq?= =?utf-8?B?QVpMTkxEem1PbWFxUHQ5ODZMNnZGM05RcDVwM3NpTzZhVVNHMWZDVW9QMnlQ?= =?utf-8?Q?GZx12GroIqw7z6Se4Apy6Qmhb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0773aea1-301c-4a54-e1cb-08db941bdf96 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 12:19:24.0543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y/m4lXhNOKVXyD2Ewa7kkAeThlrPIi2LAhCIqz94EEWa+WocF7GO7ATL+kln/hDWZjVbYFcRy+QZkQFaHfaiDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9957 On 03.08.2023 12:44, Daniel P. Smith wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -332,6 +332,15 @@ M: Nick Rosbrook > S: Maintained > F: tools/golang > > +HYPERLAUNCH > +M: Daniel P. Smith > +M: Christopher Clark > +W: https://wiki.xenproject.org/wiki/Hyperlaunch > +S: Supported > +F: docs/design/launch/hyperlaunch.rst > +F: docs/design/launch/hyperlaunch-devicetree.rst > +F: xen/common/domain-builder/ I would generally suggest that maintainership changes come in a separate patch. Furthermore aiui lots of stuff is going to be moved from elsewhere, and such code may better stay under its original maintainership (unless it was agreed that it would shift). So initially maybe best to name the original maintainers here under M: and add the two of you with R: ? I also don't think it makes sense to include a not-yet-populated path here; who knows what this is going to change to by the time things get committed. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:49:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576339.902348 (Exim 4.92) (envelope-from ) id 1qRXlQ-0002vs-PK; Thu, 03 Aug 2023 12:49:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576339.902348; Thu, 03 Aug 2023 12:49:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXlQ-0002vl-M1; Thu, 03 Aug 2023 12:49:12 +0000 Received: by outflank-mailman (input) for mailman id 576339; Thu, 03 Aug 2023 12:49:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXlP-0002vf-HP for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:49:11 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2061b.outbound.protection.outlook.com [2a01:111:f400:7e83::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22141e1c-31fc-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 14:49:08 +0200 (CEST) Received: from DS7P222CA0022.NAMP222.PROD.OUTLOOK.COM (2603:10b6:8:2e::25) by IA1PR12MB8407.namprd12.prod.outlook.com (2603:10b6:208:3d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Thu, 3 Aug 2023 12:49:04 +0000 Received: from DM6NAM11FT093.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2e:cafe::88) by DS7P222CA0022.outlook.office365.com (2603:10b6:8:2e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 12:49:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT093.mail.protection.outlook.com (10.13.172.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6631.42 via Frontend Transport; Thu, 3 Aug 2023 12:49:03 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 07:49:02 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 07:49:00 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22141e1c-31fc-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lz2O3vqQ72xBoGzKBTXP9Dead3C3oLdQWU3CRHq4ConoE2mAuI+bBlYWKFHuu6MqRY5vtxpO8Y891LONnIUueCy8TZ2CbloXE46ZeL1x9zczIzuGNCS3gTCjy2VZ7nhqLNWWydhu/vnqMWzVDRR8U9ZXFAymkPnnVOf2pKQdDdvbGWqpPHKFik/w28omR58PUgfFrU/TaZZaJ4dBSVyUdQTjs7CSAY+4pZUvrYwSUnsnOl9fUZgcFcgbnyffoqg/ggQ2hZgt7EOTyjvLwJtxFgKBqBvv84Tp8lqrGwjrXJHz6NSYuLqfGid5GXday8n0NTbk3dRwI97K7i2abD33ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xL21f752i8F569qjM8PulemcQ27LQAbMnO8ySg2E1cY=; b=B5rP02huDHr4vPEY+Gt/UEOB+Nn4B3gW6ApmpITp9apLJZUTO78ZiCw8T2K8lmda1gy5lAqLNbemt5zI7YKvR/EcuAPjQZXN5p11fhMpfdDvVLn7UtHun9WqtYekRuFGkOvb4Q1EyPhDf2GjkVoEDLoeU3o7cxFaMyWGp/AuRIw9MCYzxEsOwLYveDMgqregzvxDZ3C3Qs6+ulzJ6iT1fp9CIuxTLnVZvO6NLj32krT34xyJB2qWp3dnwVaz5KZy1boKE0VleHEQZWmeqArNVgbq8GVN83gzNH2Qv0xnI7jwL7JVKF2KWkSjmtJS+aVCxuT+NX4S5UvllLvM2hPNiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xL21f752i8F569qjM8PulemcQ27LQAbMnO8ySg2E1cY=; b=Ff4P7vz3iTCSRidsjZHQVjZX/s5QSgtxGa9Wz8Fx2IWaeBlFmicbtUGekx4SzA8joRDW3zU9oM49ViwsT27yjHesnLTilik+NIRwGasRDrmOWraKQxVl6notHRBD7woH62ufD5JPrf1sXKb0EPX3/kLWSreNqaEPGv6/3x4AdeY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: <476e5c13-2b4f-d115-7237-d5220ec13cf2@amd.com> Date: Thu, 3 Aug 2023 14:48:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: "Daniel P. Smith" , Volodymyr Babchuk , CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> From: Michal Orzel In-Reply-To: <20230803104438.24720-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT093:EE_|IA1PR12MB8407:EE_ X-MS-Office365-Filtering-Correlation-Id: 81d71292-398f-44b3-300e-08db94200457 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GfWSKHmmrh6eg4W6l9lFVluydwox8GnESTJgZ1HjLgmLnatPg+FOwH+kpC9vx9t51slQrXyXp0D0DQoUhHPishKNam3fUXeYIfWBg0BW+JdBSTHfEl96Vd8H2XzWjJjQ3mv9tSTIKrl/xm1K6oqQG8x8YUHFNWTnNO5dM595wiDRalXyB/WuDi2EEnn+48GwJaALAsvTGX8RlN9ZLoxy5LX06FWyTrVa8XT4AvsKgY6BwwkqmpcLL4jnuHYr5g6OyRQa/lg/O4GEFupaQgbAM0AnX1Kc5W2iwVOtc7YdwAowQFf4F0FqL1eh0j7/bhxgOawNQD/hZr0IssICfKgfX+p5yv0oqo/NsTIR34IngS0BVBk0aUXFNdqQTs4PEgUUcZ33lpL1erJBeVIP3jFfXgsJEWg1ruldWmjev0TkqFv6pwf3wdGZw4kvfWIXuprRp3mjoHmKHE1sCB7Ae+SGm4wH7ZQt9Xco7VJ+eWp8NhwbhfDrciwtpXXQKEzybYRFyMOlfoiE01i8csR4CnomOKvHIr64oRbpddOFqwDcaaa7GvdND96VWIgHDnCbwCFYhUacm3XFD1Ppp5RHAJStxH1xFLOjPD0AXsONwLulns8W3DLKQ0KsOf4C17hLsGdVPB5YTIQNH5egIG21lVkMQGoRfTKkmyI2wZuGM1bg0BHVTsqRSYCTv2JAJU68uY0/YOGHyy77iOmtN3X4Bb4VJa8/wZUtSp1/Ld17s2FPBNgWC2Ue7+LAbac+aWDzbePd7mhhTzo/Xj9nDRNDdpfIJSQHFoHuqIU534bAZCLMCnRn121fx8zGkGhRNgg1t9vojt4cDRCgBgJ6wlkHA5j5Vg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199021)(82310400008)(46966006)(36840700001)(40470700004)(40480700001)(186003)(336012)(40460700003)(2616005)(36756003)(316002)(16576012)(81166007)(478600001)(86362001)(54906003)(110136005)(6666004)(70206006)(4326008)(31696002)(82740400003)(70586007)(356005)(53546011)(26005)(41300700001)(8936002)(8676002)(7416002)(426003)(47076005)(31686004)(83380400001)(44832011)(36860700001)(5660300002)(2906002)(2004002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 12:49:03.4963 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 81d71292-398f-44b3-300e-08db94200457 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT093.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8407 Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: > > > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is IIUC, you just try to untangle the code for fdt from dt (unflattened). CORE_DEVICE_TREE is a bit ambiguous in my opinion, so maybe just CONFIG_FDT, especially since you use it to guard libfdt/? > introduced for when the ability of parsing DTB files is needed by a capability > such as hyperlaunch. > > Signed-off-by: Daniel P. Smith > --- > MAINTAINERS | 8 +- > xen/arch/arm/bootfdt.c | 141 +--------------------------- > xen/arch/arm/domain_build.c | 1 + > xen/arch/arm/include/asm/setup.h | 6 -- > xen/common/Kconfig | 4 + > xen/common/Makefile | 3 +- > xen/common/fdt.c | 153 +++++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 50 +--------- > xen/include/xen/fdt.h | 79 ++++++++++++++++ > 9 files changed, 246 insertions(+), 199 deletions(-) > create mode 100644 xen/common/fdt.c > create mode 100644 xen/include/xen/fdt.h > [...] > diff --git a/xen/common/fdt.c b/xen/common/fdt.c > new file mode 100644 > index 0000000000..8d7acaaa43 > --- /dev/null > +++ b/xen/common/fdt.c > @@ -0,0 +1,153 @@ > +/* SPDX missing for a new file > + * Flattened Device Tree > + * > + * Copyright (C) 2012-2014 Citrix Systems, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > +#include > +#include > +#include > +#include > +#include > + > +bool __init device_tree_node_matches( > + const void *fdt, int node, const char *match) FWICS, this code style (that you use for every function in this patch) is rather uncommon in Xen so maybe better to follow the generic style. Also, this would avoid changing the style of functions/prototypes you move. [...] > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index 1d79e23b28..82db38b140 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -14,13 +14,12 @@ > #include > #include > #include > +#include > #include > #include > #include > #include > > -#define DEVICE_TREE_MAX_DEPTH 16 > - > /* > * Struct used for matching a device > */ > @@ -159,17 +158,8 @@ struct dt_raw_irq { > u32 specifier[DT_MAX_IRQ_SPEC]; > }; > > -typedef int (*device_tree_node_func)(const void *fdt, > - int node, const char *name, int depth, > - u32 address_cells, u32 size_cells, > - void *data); > - > extern const void *device_tree_flattened; > > -int device_tree_for_each_node(const void *fdt, int node, > - device_tree_node_func func, > - void *data); > - > /** > * dt_unflatten_host_device_tree - Unflatten the host device tree > * > @@ -214,14 +204,6 @@ extern const struct dt_device_node *dt_interrupt_controller; > struct dt_device_node * > dt_find_interrupt_controller(const struct dt_device_match *matches); > > -#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) > -#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) > -#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) > - > -/* Default #address and #size cells */ > -#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 > -#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 > - > #define dt_for_each_property_node(dn, pp) \ > for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) > > @@ -231,16 +213,6 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); > #define dt_for_each_child_node(dt, dn) \ > for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling ) > > -/* Helper to read a big number; size is in cells (not bytes) */ > -static inline u64 dt_read_number(const __be32 *cell, int size) > -{ > - u64 r = 0; > - > - while ( size-- ) > - r = (r << 32) | be32_to_cpu(*(cell++)); > - return r; > -} > - > /* Wrapper for dt_read_number() to return paddr_t (instead of uint64_t) */ > static inline paddr_t dt_read_paddr(const __be32 *cell, int size) Shouldn't this also go to fdt.h as it is just a wrapper for dt_read_number() you moved? ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:51:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:51:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576342.902358 (Exim 4.92) (envelope-from ) id 1qRXnp-0004Jb-6A; Thu, 03 Aug 2023 12:51:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576342.902358; Thu, 03 Aug 2023 12:51:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXnp-0004JU-2w; Thu, 03 Aug 2023 12:51:41 +0000 Received: by outflank-mailman (input) for mailman id 576342; Thu, 03 Aug 2023 12:51:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXnn-0004JM-BN for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:51:39 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7aefd3bb-31fc-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 14:51:37 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Aug 2023 08:51:31 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6093.namprd03.prod.outlook.com (2603:10b6:5:394::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 12:51:27 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Thu, 3 Aug 2023 12:51:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7aefd3bb-31fc-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691067097; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=adqGrAGCprXngJsaMYxsvJRmFQlWxll518DzORMmq+Q=; b=FnMr6v7mDqUgmg/AEcImhaKtjrc+rqbCB/Y72iHPGsDqJNrl4MlWAp3Z FaASwGK3K/K9dfPWzn9ntWvkL1r3t/hxcrTVVo0ZUq7g8o8awMa9+yyCO 13JkhGJSR+CHOSq3c5innBIZ2MsADi43JLIHK9Yb3i2+V7adC1krj5xEB Q=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 117065075 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:SgTkLKid4bZWQAs1IcwpVwUjX161tREKZh0ujC45NGQN5FlHY01je htvWTuGP/eIMWD9fNsiO9i0oUhSvJGHyt9jSgJo+Sg0Qigb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT7AeFzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQYF3cWVCKipNmv7+q5Utlop8YlNpDSadZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTnrqA32ALOroAVIEMcBHG5m7qWs0OFYNVTO kwPpy5xkpFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLmUIUT9HLsAhrsg1bTcu0 UKF2djuAFRHvLSLRFqH+7yTrDf0PjIaRUcdYQcUQA1D5MPsyKkjgxSKQtt9HaqditzuBSq20 z2MtDI5hbgYkYgMzarTwLzcqzelp5yMRAhl4AzSBzuh9lkgOt/jYJG041/G6/oGNJyeUlSKo HkDnY6Z8fwKCpaO0ieKRY3hAY2U2hpMCxWE6XYHInXr323FF6KLFWyI3AxDGQ== IronPort-HdrOrdr: A9a23:E8+enauQsbxWodBuh8sM23ZW7skDctV00zEX/kB9WHVpm5qj5q STdZUgtSMc5wx7ZJhNo7q90cq7IE80l6Qb3WBLB8bGYOCOggLBEGgF1+bfKlbbdREWmNQw6U /OGZIOb+EZoTJB/KXHCKjTKadD/OW6 X-Talos-CUID: =?us-ascii?q?9a23=3ACVqaxWlXstoH/jr1bYmY3CxFcB3XOX3ii2zqEW6?= =?us-ascii?q?bMn9GEL+NeVux+qV+yvM7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3ASLNk/Q7be0waWcSs8bqZekAbxow26fWECnpOvqw?= =?us-ascii?q?LgPKDOT1wIGqZ0wuOF9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,252,1684814400"; d="scan'208";a="117065075" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nMl8J6+rmgJOM+vwXFvNL/nqhnNxIbosCWwQhzZ/SZuRUaJ/eOrC4mvt8Ko1OO7eIGEp2D+3qUtKxOIaX0uRvJ+Q76vmfp8XrX9xWm/UDOZIAY14WS96/QUl4HppQ2TMvh5Kag6OHSg1nqdrMsZiARByvUZHEtH9T1LQmYfgcuBBYgckyzYYuj2rwR4HvmADvh3PdW6cluFtUlrXniL1xc4zM0IM488U4veKidU9XftkKpgNMwGAMNJ1whz+55nGb8reBiOS6NSs8orHI9eJbB+v1LF16K5UxRzYfGR/cBTPGNTF0xT277dcezowzQyx7Ys7YGUtE0OrBPALSPYVmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yw34/tIROxtCDfAjyyNkLhBW3hDuKbFih0AXS74ocU4=; b=Idu4DWiD7r7BJ5xrijCTobw+0tgvyx10qx+YrqlRWPpPnGK2fxpbUp5zCS8kTQqhOT7s7Gvq9DHbKItjIXdLoIPIbYEfL3Ccu5cEeN0TpF6MU+jlE379jTTYLsohcEpYQDJnxk5xwXDNKDO2LIhcS7Q8anoH1NNYvvB686W2MuEWsRRs1G/pKr+iz+k+u3pyIVUl/+FlRXHoHkuXP056kANkZP18ly5ikpur3o2iDbWnpWLhNfoW8NtePGyx+67IGgb97JjYFQAZWlWpV9yXvhs5fuU8LJgNtgLPPMGAi72dikYNY8MISkGS70Fxc/cGlOOxZg51IbRIp+K+Qqbd9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yw34/tIROxtCDfAjyyNkLhBW3hDuKbFih0AXS74ocU4=; b=B2rvw1WK4OtW3dhtMnjBjpT7jfKjLxId7FkLPZ7XbTN6ASMPM7q5FIJbNdninSDIGltmND0zI5Hbu8O4/5PtEbzFnBTnxFoadCehLKppEddDP+QQrOYg4seq6QGFt+fOm2xqHmS3T1CoRNW03lnGUKgg7dqJ5qiKLxqlPxxoFTk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Thu, 3 Aug 2023 13:51:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] xenctrl_stubs.c: fix NULL dereference Content-Language: en-GB To: Jan Beulich , =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Cc: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= , Christian Lindig , David Scott , Wei Liu , Anthony PERARD , xen-devel@lists.xenproject.org References: <3b6374c44ae7e4afce427a9ea852d8d1ebbb42b3.1689236671.git.edwin.torok@cloud.com> <99d89bce-42ff-f6e5-090b-3b9f8e130e66@suse.com> From: Andrew Cooper In-Reply-To: <99d89bce-42ff-f6e5-090b-3b9f8e130e66@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO3P123CA0024.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:388::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM4PR03MB6093:EE_ X-MS-Office365-Filtering-Correlation-Id: d0050bda-eb27-4438-b192-08db942059c6 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3da4OCLChehWo14Oi6S8MmYDLhhyHXlgg3iWZlpGmay2v2n5PNvE8faQTPF5Mof4gSljMATilRARCM6j5zrET84W+n/qJZosayyi5rcW9hSKs27ztd5jBYukhCshgMEovHUeaagiqdiCUlL3z1S/wWEJw9mrg2wHf6FjUHZ8UHD0L0IWHYWfhmodEH9NvkFle8pphpNCig3v4ZK5HqtKIs+/UgF7j9unkEIebXTAqqEp73Hrf7eL3fjxz3LjXvDrtp7OSJ5Ci9RbPJRTz8j3PuFtjpPJoZPrNERcHqIvBmA2lH2FtVOgEWZ5di9wj07r4hlM6z+4o/+1MwGiL1TigCHivBR2VPd2nCOeUqGQ5BxERmT8xFc0dyhjD+3o54pMQtVq91ks/wHx1XCQIM7jHg866FqW2Rwda7I5CpeYPGpckOSEuro81yxQZ8nQfnOWJPNTfWXzSLaszlgamopn7NiMnC25NCDMu0IS+Y5mnxmYooGYIbAXOOILlrdd8PHfCWV+lfT4srh08PuJG0LEa3PgFzeZEsayeVso3KQEK4ignoaJO99bZ367zsZcYoxotN63LCnIT6XeTsSUhpR/hb5PoWE8eVF+Xlq9VBDW01S2cCC7E0ckBCoIDOKGTURPJ+fehQUH5187pRYG/c35dw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199021)(41300700001)(8936002)(8676002)(53546011)(186003)(6506007)(26005)(86362001)(31696002)(2616005)(38100700002)(82960400001)(316002)(6486002)(6666004)(478600001)(6512007)(110136005)(54906003)(36756003)(66556008)(66476007)(6636002)(4326008)(66946007)(31686004)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXM1Q1pyYTB4anpaK2s2aC9pa041MmJ1WHc0UUdsMG90NE1EcVBLcTJ3ZnJu?= =?utf-8?B?YTNHeTNPNmJWNWhnYTZPMHh2QVJIQVJBS0hEWis5NzM3QzE3aXowc1hjR1lo?= =?utf-8?B?ZS9CV2FEUXNBNUtsenJ5bFJla05Fa0hyNmd4YURLSERianVlTGxIMU9hd2Z6?= =?utf-8?B?ak94NmlOdnVHeEE0S3ZZYWJZTlVxVlRRSGpBMUNqWGhWbXV4WXNPRldXWjEx?= =?utf-8?B?Y1RCdXFycjdTaDE1K2lPMWVIbC92R0V3c28yTEorelYwNkpDOFF4cm11K3Nm?= =?utf-8?B?Y2JJVFZJSnBvRDA1SE41bXJMT1loUnRRSUIzNzN5b0ZDY0lrUXhBaWFYVFpJ?= =?utf-8?B?M1dMaEZnN1RCQVQvMkkvRHR4MkVIZlcrTVI2V3lrbGJUWnV4SW1qSUpwQUZ5?= =?utf-8?B?c2ZtVzVIWGtaYy9Yc0tJODhYdmU4WUIyTEFPSklsL0dzVTU0YU44KzE1d1V6?= =?utf-8?B?UGhRUUdrSFJleGlkOWdhZ1BhUW1hdFVRdE1IUUdXcktCZC9JUVhkcVdlZ2l3?= =?utf-8?B?SGMyKzlNS2kvYkJkQUpDZ0lGVEtjekJBazVxbWFPdmU1bUNabUtvZkswUlk4?= =?utf-8?B?cHd2WlYvSHdwUTlWbjBYTW9tWXZlaE82Kzh1VnBEdG1DVzR3Vk1uU1U1bitM?= =?utf-8?B?dkZ2eUUvelFGTjhOQi9KZUJoeVpUS2k1NnNZT0F1WWloaVYraGg2ME5zWGx3?= =?utf-8?B?TnpZa3Joa2xzUCtvaGNCdmJ2RTZ5STE0REtCUjloZ2pWcG9SYno4TFk4Wkxa?= =?utf-8?B?b0loSVU1aEFRbDRxR1RYL2c5ZFVrcnNBT3Z1R21YTWVvSUdMbHZqNnRXb3Rx?= =?utf-8?B?bUZlVkt2RmdhbjVLbTQ5bFZrVFA5NXRnVEcvMTlyV0FWRzl0L0M1RFI2R2J5?= =?utf-8?B?bkgyVWVTTjNNK3QzZE9JZWM4RW01RUpydE42aFdIQlcrbGx5UmVmd1FYczZy?= =?utf-8?B?ZlJqeU1ZQm8ra3JuYjJIa1lEZ0VzK2h0bVRqcFNKNDFoYjBkWm5pWlVIemti?= =?utf-8?B?TXRiTGkxRi9BREdaNWZDeUNKUXduMXRKV1paZVQ2a25aM3F4R0ZsMFQ4ajlN?= =?utf-8?B?WDlpZTRnbnIvWTBNTzVlRnl4ZVlWaDRqLy8xSk1QYlc5UVZ4UFdqdDBBYmhp?= =?utf-8?B?VVpWdVRGSzdraEp0WDVIUkFOYUJXYnR2Rzk2TWdmeTJxblRTVmd1YnhhT3o4?= =?utf-8?B?N2R0K3VHR0hHa3UxSmZYTHZLQUV6cFhhbHJRd2JRUko5NDlSQ21GZ0FoY0Jm?= =?utf-8?B?dFlKT29KNjJ2T3l4d28yaWV4N1BDbVZ5M2RucjM5OWsra29GK1pTTERpL3Bk?= =?utf-8?B?c0NRQ2c3Q3Y0VkhJdWU3bVRBSmxDSitQUXZhdGRoeUtmWHJYZDA0QXhZK1FJ?= =?utf-8?B?TTV2Tm1ISTlLdUI4QXdoWTFiYUQ0Tkhma1RtbWV4bjVIQU5NYzZsNXNnTm5J?= =?utf-8?B?aE83a21Ka3A5Wk9FYzVsME1TYWJNb2tLRHlXdTZwdDI2YlMrYUF2MnZlV0dJ?= =?utf-8?B?aXpCQ3dDelpYNFFrT1oySit3dWRhZHlPOGhFUWhvcFNPcE9Hcjc0a3NWbTU3?= =?utf-8?B?QlpBVEYzZElGN3lNR2d4dnJ0cWdvMmR1NWhCUStqQmpBR2FDUDluWElnb2xS?= =?utf-8?B?TUplMGdDWXVHNU1ySlI0L0hOYUY5MVhRRTAxd1RORlhyTElneTc3d3ZIU1FT?= =?utf-8?B?SWVJYzFySm5oQ0Qza213UVN5aXpwOWJzSFdyZUVxTlVUSXhmanFJM0d2Y1NW?= =?utf-8?B?aVNoVUNobnI2UEtjQlBhVFRrSjZQcWpDcVlveDM1dFNWdnpSS0d4VUYrSWxQ?= =?utf-8?B?cjhLVnpZWlZLQ01wNlM2ZnB2OElZeGdYaXhWdnpTV250cURjVTJBWXNRYlkz?= =?utf-8?B?VDZ3OUpnZm1TWitSU29iZzdQVVYrMzZQbkFKejBZVm9HdFQrcForTWhRTHZT?= =?utf-8?B?NGMreW0rTE0zanpybXQ3QlFObURxbkhFNjg4dWVCWXNWYlpPaDVlcU43cjJu?= =?utf-8?B?aEd0cHd6c2piNG5NUWsxWUVhYUw5YmJNdUdPSlFNblcyR0RMUHROWUZIcHRy?= =?utf-8?B?aEh1WHFzK2pMT1BzQUFvd3pad0ExRlBPSUFiRUQ3VWR5Q25zems4eDZucnI2?= =?utf-8?B?RDkxeVFPa0p1VUlYOHpzYUo3aWo0M2NUMW5iT2MrK3d2WnZzUVFWTXlTRzdn?= =?utf-8?B?QUE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hoPQnJJ67WjNY4QKBS8JiF79hGnPdmL+c5LXO6EM2BGTNHEe5y13T0N6Wiudy7K+OKhACZi8VZOo+KWa14ZgC9mXCs+QVB9riSVR209i7e0L4X5DVfykxsJygx5yZDdZFOZCYE+QbrEjekh80cHzTMHgIuimdaQXxlIFWz0LkjI5b7pRNmMV3MPurRRQWV/Gx9AomZ9ST1g0k+I3w+4E/4jCfZjOJGXNi/VDqxNRAndbo9I+oLxRBkR2Oe3Gg0eLuL35uMTylALkKLN7FlqENtzaCAssAargEWlsLV5X7AQpnjmqjOUmkaDbuGxWtu6M2IvbV/zQhte4lhGdSQYSWv0u1p6NgXFlEhRStFJecpA+byLoRYMfEbKCg0Qnqg/5xIoW+uAI0tOcTvEvAjYZZBQjv7Ntk6mz5eH8807L1xFOebUBjuE/XpdCBCTB1KdUYIRYqLasLevEYSjn3/nInq6+tlPMu2BgUOuhmoaZI+M/g/J5hsDt0crHKpBzZ9Tb+kToQlSsvoBS7pumJQ1em++nRd01v46jrsK4P2sgN8wrpmXqmza1QGMmpuunvY31R3/9KlFvUgxGLavrt6LNKwhKOhBMGLAas510ExixoSJXQcLIdHGA8z5VpXBGvZ+K/tpCisYDRm5PONFRTlmaeyElU2eElOfHZuPTKv2m2F9pTA8x0U9AwhDtXq20oV9YUBiNqtA8gZLpThXrc8rFyisqU8BY4UEajhT9e1reaEmo1b57LGZt4yKGAQAdcS4rE1r0UJfdOuh/7R6ldR70budh6H8WJ2LRQfyMqnGuTtaQhSFP88o9buRkjcJnG56N5nWqZlQrbRq6DXE4sboh1etCDiqsHp5McLpLyMgaoiIURs3GrhuVLkrmqVP31F0E X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0050bda-eb27-4438-b192-08db942059c6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 12:51:27.2214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: blHg4m2M0BuBj4STHRyA2Dc+amuROE9V0VYwBnwQ0usKGtBW9r9zHdzGyIcVt4nP5rIqT2eSf+mKmFs2ckxR+0F5Aoi4Q/YN5UE6HzpYYf4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6093 On 03/08/2023 11:15 am, Jan Beulich wrote: > On 13.07.2023 10:30, Edwin Török wrote: >> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c >> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c >> @@ -832,7 +832,7 @@ CAMLprim value physinfo_arch_caps(const xc_physinfo_t *info) >> >> tag = 1; /* tag x86 */ >> >> - arch_obj = Tag_cons; >> + arch_obj = Val_emptylist; >> >> #endif >> > Since, aiui, this also affects 4.17, but the patch as is doesn't apply > there, could you please provide a suitable backport of what went onto > the master branch? diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index facb5615776b..7de2ff544428 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -748,7 +748,7 @@ CAMLprim value stub_xc_physinfo(value xch)         Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1));    #if defined(__i386__) || defined(__x86_64__) -       arch_cap_list = Tag_cons; +       arch_cap_list = Val_emptylist;           arch_cap_flags_tag = 1; /* tag x86 */  #else This logic got factored out of stub_xc_physinfo() into the new physinfo_arch_caps() as part of the ARM SVE work in 4.18. ~Andrew From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:57:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:57:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576347.902371 (Exim 4.92) (envelope-from ) id 1qRXt0-0004zr-QL; Thu, 03 Aug 2023 12:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576347.902371; Thu, 03 Aug 2023 12:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXt0-0004zk-NR; Thu, 03 Aug 2023 12:57:02 +0000 Received: by outflank-mailman (input) for mailman id 576347; Thu, 03 Aug 2023 12:57:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXt0-0004ze-28 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 12:57:02 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a890314-31fd-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 14:56:59 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691067412090507.9520434344752; Thu, 3 Aug 2023 05:56:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a890314-31fd-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691067414; cv=none; d=zohomail.com; s=zohoarc; b=KdFwQfA9sqJfTbFOL7ydd5VRfe6vl9ajKNp8mMSJ1PsJw60e6AhGkJdlewcBPkFBTBGHMskmkMScGGlhq8MOZT3u7iBO9PnCoZqpbVDQsF0E/u5LIG+sBv9EZ6QC/bbpG7H7pFH2bGTdqgWf0iLE9a1EWQ1xvWS1qOMirOfSTdg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691067414; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Hk5uuj6GbfvXUbIcemYhrHAe2Y8Su9mvkhSFvHr3MmI=; b=UOPd/sya61Xz9MfC4eciz+QRKnn3vmcnknBMd0C6MiZXe8XBaV+tkP9WsJgeMzgahQHhLD4Fuhr+QTZIRisLETBhEEYXydaBIIpTueBe/G6c8bqz5ZVrPlQQ9WdtivD8CaiXl++jMfPWL6bS8i4bGuvUoOznX/k6dLDztSjNliY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691067414; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Hk5uuj6GbfvXUbIcemYhrHAe2Y8Su9mvkhSFvHr3MmI=; b=l50yqvXK4v5GHFtEqjziUq0Q1mdR+rhdO4rFEVxqdz1bMokUYUlBteXWP8z3TXRB BS+T9/jhcxL9922e0gKKxoxRqr9eeVWw2kzLk5C83m1P5BCJkggMRbcFIVN/idqWZbx Jq/bJFXCOEvCE+TuKNiH1dwlF1pEkMDiUJvsSEE0= Message-ID: Date: Thu, 3 Aug 2023 08:56:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: Jan Beulich Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> From: "Daniel P. Smith" In-Reply-To: <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 07:01, Jan Beulich wrote: > On 01.08.2023 18:06, Daniel P. Smith wrote: >> This patch reworks the console rotation logic to provide a general mechanism to >> incorporate domU in to the rotation. It does so by walking the domain list >> using the XSM console privlege check to determine if the domain is given access. >> >> In reworking the rotation logic, the assumption that the hardware domain is the >> first domain created is removed and is changed to explicitly locate the >> hardware domain at boot. > > I guess I'm unable to identify any "at boot only" code. I'm also > puzzled by this indicating there is a need to do so, when the global > variable "hardware_domain" is available, and you actually use it. As to the "at boot only", there is a switch, which upon closer look I have broken and will now have to fix, that if the 2nd char of the 'conswitch' boot param is 'x', then the console is not supposed to auto switch to "dom0". I was trying to keep the console_rx tracking logic the same, but I have already diverted far from what was there, I might as well rewrite that as well. Doing so would allow the value 0 can actually reflect domain id 0 and not have to continue the off-by-one game played mapping domid from/to console_rx. >> --- a/xen/drivers/char/console.c >> +++ b/xen/drivers/char/console.c >> @@ -473,45 +473,102 @@ static void cf_check dump_console_ring_key(unsigned char key) >> */ >> static unsigned int __read_mostly console_rx = 0; >> >> -#define max_console_rx (max_init_domid + 1) >> +#define CON_RX_DOMID (console_rx - 1) >> >> /* Make sure to rcu_unlock_domain after use */ >> struct domain *console_input_domain(void) >> { >> if ( console_rx == 0 ) >> return NULL; >> - return rcu_lock_domain_by_id(console_rx - 1); >> + return rcu_lock_domain_by_id(CON_RX_DOMID); >> } >> >> static void switch_serial_input(void) >> { >> - unsigned int next_rx = console_rx; >> + struct domain *next, *d = console_input_domain(); > > Looks like "next" cannot be pointer-to-const just because the XSM hooks > still aren't properly const-ified. Oh well. Something I can look at another point as XSM maintainer. >> - /* >> - * Rotate among Xen, dom0 and boot-time created domUs while skipping >> - * switching serial input to non existing domains. >> - */ > > While it would need adjustment, I don't think the comment wants deleting > altogether. Ack. >> - for ( ; ; ) >> + if ( d == NULL ) > > This covers both Xen receiving input and the domain receiving input having > gone away. Originally in the latter case the next sequential (in domid > numbering) domain would be switched to. In the new logic you start over > from the beginning of the domain list. Such a change in behavior (if > deemed acceptable at all, which I'm not convinced of) needs calling out in > the description. No, the intent is to keep the existing behavior. Again, this is a fallout from trying to track by domid with the assumptions that 1. only boot time constructed domains would be given access, 2. those domains where created with sequential domids and 3.) those domains never went away (or if they did, it would result in a dead spot in the rotation). As stated above, just dropping the pretense of tracking by domid will provide a simpler solution and maintain the existing behavior, minus the possibility of having dead spots in the rotation. >> { >> - struct domain *d; >> + if ( hardware_domain ) >> + { >> + console_rx = hardware_domain->domain_id + 1; >> + printk("*** Serial input to DOM%d", CON_RX_DOMID); > > Here and elsewhere - why %d when original code properly used %u? I also > think there are now quite a few too many of these all identical > printk()s. Good question, I did not write the line, it was copy/paste from elsewhere in the file and then continued to replicate from there. >> + goto out; //print switch_code statement & newline > > Leftover development comment? (There's at least one more.) Yes and no, the comment came from elsewhere in the file and early in development it I place it here to later decide if it should stay (and get converted into a compliant comment). I will drop it in the next iteration. >> + } >> + else > > Please avoid "else" after an if() that ends in "return", "goto", or > alike. Really? How would you propose handling common finalization when completion happens during the execution of two branches of the logical purpose of the function? Do you want to see two separate if statements of `if ( condition A )` and `if ( ! condition A )`? >> + { >> + for_each_domain(next) > > What guarantees that the list won't change behind your back? You don't > hold domlist_read_lock here afaict. It might be that you're safe because > that lock is an RCU one and this function is only invoked at init time > or from some form of interrupt handler. But that's far from obvious and > will hence need both properly confirming and stating in a comment. (It > is actually this concern, iirc, which so far had us avoid iterating the > domain list here.) It is better to error on the side of caution instead of assuming this will always be invoked in a safe manner. I will add a read lock for the domain list. >> + { >> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >> + { >> + console_rx = next->domain_id + 1; >> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >> + goto out; //print switch_code statement & newline >> + } >> + } >> >> - if ( next_rx++ >= max_console_rx ) >> + console_rx = 0; >> + printk("*** Serial input to Xen"); >> + goto out; >> + } >> + } >> + >> + for ( next = rcu_dereference(d->next_in_list); next != NULL; >> + next = rcu_dereference(next->next_in_list) ) > > This looks like an open-coded continuation of for_each_domain() - I'm > afraid I'm wary of introducing anything like this. Not exactly, for_each_domain() always starts with beginning of the domain list and walks from that point forward. This open coded version stats at domain d and walks from there to the end of the list. Which is why there is logic below, which uses for_each_domain(), to walk from the beginning of the list until the next domain with console_io or the hardware domain, whichever occurs first. What I did not want to do is potentially waste a lot of cycles doing for_each_domain() with a continue until it reached the current domain and then start checking for the privilege. I could take this and introduce a new macro, for_each_domain_from (or a better name if there are suggestions) and use it here. >> + { >> + if ( hardware_domain && next == hardware_domain ) >> { >> console_rx = 0; >> printk("*** Serial input to Xen"); >> - break; >> + goto out; > > Since you use "goto" anyway, this wants introducing a 2nd label (maybe > "xen"?) ahead of the identical code you add further down (immediately > ahead of the "out" label), to avoid code duplication. Ack. >> } >> >> - d = rcu_lock_domain_by_id(next_rx - 1); >> - if ( d ) >> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >> { >> - rcu_unlock_domain(d); >> - console_rx = next_rx; >> - printk("*** Serial input to DOM%u", next_rx - 1); >> - break; >> + console_rx = next->domain_id + 1; >> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >> + goto out; >> + } >> + } >> + >> + /* >> + * Hit the end of the domain list and instead of assuming that the >> + * hardware domain is the first in the list, get the first domain >> + * in the domain list and then if it is not the hardware domain or >> + * does not have console privilege, iterate the list until we find >> + * the hardware domain or a domain with console privilege. >> + */ >> + if ( next == NULL ) >> + { >> + for_each_domain(next) >> + { >> + if ( hardware_domain && next == hardware_domain ) >> + { >> + console_rx = 0; >> + printk("*** Serial input to Xen"); >> + goto out; >> + } >> + >> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >> + { >> + console_rx = next->domain_id + 1; >> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >> + goto out; >> + } >> } >> } >> >> + /* >> + * If we got here, could not find a domain with console io privilege. >> + * Default to Xen. >> + */ > > "Default to" is a little odd when there are no other options. Fallback to? >> + console_rx = 0; >> + printk("*** Serial input to Xen"); >> + >> +out: > > Labels indented by at least one blank please. Ack. >> @@ -520,12 +577,11 @@ static void switch_serial_input(void) >> >> static void __serial_rx(char c, struct cpu_user_regs *regs) >> { >> - switch ( console_rx ) >> - { >> - case 0: >> + if ( console_rx == 0 ) > > By using CON_RX_DOMID everywhere else you try to carefully avoid and > open-coded assumptions on the precise biasing used there. With this > it would seem to me that here "CON_RX_DOMID > DOMID_MASK" would be > more in line with that model then. Yep and it results in not correctly implementing the commandline parameter behavior. Since I am already doing a domain list walk, instead of having to convert from domids, this really should just be tracked with a domain ref and use the rcu lock to catch if the domain drops at any point. >> return handle_keypress(c, regs); >> >> - case 1: >> + if ( hardware_domain->domain_id == CON_RX_DOMID ) > > No check of hardware_domain against NULL? Missed this one, will fix. >> + { >> /* >> * Deliver input to the hardware domain buffer, unless it is >> * already full. >> @@ -538,31 +594,37 @@ static void __serial_rx(char c, struct cpu_user_regs *regs) >> * getting stuck. >> */ >> send_global_virq(VIRQ_CONSOLE); >> - break; >> - >> -#ifdef CONFIG_SBSA_VUART_CONSOLE >> - default: >> + } >> + else >> { >> - struct domain *d = rcu_lock_domain_by_id(console_rx - 1); >> + struct domain *d = rcu_lock_domain_by_any_id(CON_RX_DOMID); >> >> + if ( d == NULL ) >> + goto unlock_out; >> + >> +#ifdef CONFIG_SBSA_VUART_CONSOLE >> /* >> * If we have a properly initialized vpl011 console for the >> * domain, without a full PV ring to Dom0 (in that case input >> * comes from the PV ring), then send the character to it. >> */ >> - if ( d != NULL && >> - !d->arch.vpl011.backend_in_domain && >> + if ( !d->arch.vpl011.backend_in_domain && >> d->arch.vpl011.backend.xen != NULL ) >> + { >> vpl011_rx_char_xen(d, c); >> - else >> - printk("Cannot send chars to Dom%d: no UART available\n", >> - console_rx - 1); >> + goto unlock_out; >> + } >> +#endif >> + >> + if ( (serial_rx_prod - serial_rx_cons) != SERIAL_RX_SIZE ) >> + serial_rx_ring[SERIAL_RX_MASK(serial_rx_prod++)] = c; > > This is Dom0's buffer; I don't think sharing with DomU-s is correct. I would disagree, it is the hypervisor's buffer that it decides to share with domains it trust. It just so happens that it always trusts the hardware domain. This is why I explicitly changed this to the XSM call, to express that when the system manager, by enabling this privilege on the domain, has decided to trust these domains to have access to the hypervisor's buffer. > You also cannot ... > >> @@ -717,6 +779,8 @@ long do_console_io( >> rc = -E2BIG; >> if ( count > INT_MAX ) >> break; >> + if ( CON_RX_DOMID != current->domain->domain_id ) >> + return 0; >> >> rc = 0; >> while ( (serial_rx_cons != serial_rx_prod) && (rc < count) ) > > ... assume that by the time this hypercall is invoked input focus > hasn't switched. I think there's no way around a per-domain input > buffer, which of course would need setting up only for console-io- > capable domains. Let's explore the exact concern here, the scenarios as far as I can see it is as follows. A person at the serial/console types keys for the current console domain (domA), then enters the console switch sequence, switching to another domain (domB). DomA's CONSOLEIO_read hypercall arrives after the switch and thus is not sent the rx buffer contents. Then domB's CONSOLEIO_read arrives and then because `serial_rx_cons` and `serial_rx_prod` are not the same, domB is sent the bytes that were intended for domA. While a per domain console_io buffer would address this issue, I believe there is a simpler solution that can be extended depending on whether it is acceptable for the undelivered bytes to be dropped or not. Simply upon switching, if serial_rx_cons and serial_rx_prod are set the same, then no bytes will be leaked to domB from domA above. An extra precaution could be taken to zero the serial_rx buffer. If guaranteed delivery is desired, a list of buffer remnants could be drained on hypercall and console switching. IMHO I believe the reality is while there is potential that the scenario could happen, the probability is low. Doing a per domain buffer will always incur the resource overhead even if the event never happens, while the above approach would only incur the resource overhead when the situation occurs. >> @@ -1107,7 +1171,7 @@ void __init console_endboot(void) >> * a useful 'how to switch' message. >> */ >> if ( opt_conswitch[1] == 'x' ) >> - console_rx = max_console_rx; >> + console_rx = 0; > > I can't bring this change in line with the comment ahead of the if(): > Won't this result in switch_serial_input() switching to Dom0? Correct, if there is a Dom0 and it is the hardware domain. As noted, I missed that I broke the behavior this was intended to create. v/r. dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 12:58:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 12:58:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576352.902382 (Exim 4.92) (envelope-from ) id 1qRXu6-0005bs-7X; Thu, 03 Aug 2023 12:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576352.902382; Thu, 03 Aug 2023 12:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXu6-0005bl-4A; Thu, 03 Aug 2023 12:58:10 +0000 Received: by outflank-mailman (input) for mailman id 576352; Thu, 03 Aug 2023 12:58:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXu5-0005bb-1w; Thu, 03 Aug 2023 12:58:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXu5-0006a4-0E; Thu, 03 Aug 2023 12:58:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXu4-0008Sm-Ho; Thu, 03 Aug 2023 12:58:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRXu4-0002Ib-HN; Thu, 03 Aug 2023 12:58:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=utWgtWXkRNKdpIZ2ZrTWRz8ozurjzm+CoOFN/IVcRAM=; b=aIx5ujXhcaha4e4qeBGmkXVq64 cigkK6qUvJanJsoYE5KpdXHbw5mJ25mYk3f7Bg2KuoClVH8Ry3hwrB1aEyH6Jyh+YejMSgYcG8Sik U4NlWmdxzh1eC5K3xc1hV9ATu3azzLJD7NA6cNZWQK+C7UZB946UjX5o4FJD8prDUO2o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 182107: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3e357970c90172526d58e964f8ceaf32b2c69655 X-Osstest-Versions-That: xen=a910e3f2a4d128bc045ac6be374459e73ddf9fde From: osstest service owner Date: Thu, 03 Aug 2023 12:58:08 +0000 flight 182107 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182107/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182094 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182094 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182094 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182094 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182094 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182094 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182094 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182094 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182094 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182094 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182094 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182094 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 3e357970c90172526d58e964f8ceaf32b2c69655 baseline version: xen a910e3f2a4d128bc045ac6be374459e73ddf9fde Last test of basis 182094 2023-07-31 13:07:24 Z 2 days Testing same since 182107 2023-08-02 02:35:16 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Luca Fancellu Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a910e3f2a4..3e357970c9 3e357970c90172526d58e964f8ceaf32b2c69655 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:04:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:04:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576359.902391 (Exim 4.92) (envelope-from ) id 1qRXzz-00077c-Tp; Thu, 03 Aug 2023 13:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576359.902391; Thu, 03 Aug 2023 13:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXzz-00077V-R0; Thu, 03 Aug 2023 13:04:15 +0000 Received: by outflank-mailman (input) for mailman id 576359; Thu, 03 Aug 2023 13:04:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRXzy-00077P-6h for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:04:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0c::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d33015e-31fe-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 15:04:12 +0200 (CEST) Received: from DB9PR01CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::27) by PAWPR08MB10117.eurprd08.prod.outlook.com (2603:10a6:102:361::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 13:04:08 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d8:cafe::db) by DB9PR01CA0022.outlook.office365.com (2603:10a6:10:1d8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 13:04:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Thu, 3 Aug 2023 13:04:07 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Thu, 03 Aug 2023 13:04:07 +0000 Received: from bca4b23c9316.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 741FF735-B5D8-4099-A9A3-2073EE41726F.1; Thu, 03 Aug 2023 13:04:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bca4b23c9316.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 13:04:01 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PAWPR08MB10019.eurprd08.prod.outlook.com (2603:10a6:102:362::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 13:03:59 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 13:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d33015e-31fe-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYabnfGTYSDlSRQTGH+QiW6OL7y+hwSMHNlCer8295U=; b=v/LxC+ADUOFZ6WAv1MC6fRlj32PkmWjno6vahzrjE82SqT28v6RNWdrsKXaV9mjlOR+GB/K2hiOVvWMfl8LICiOuRFs/Q8ohrJED9hdUdg+TvDeKXV7MskS1sjxICn5s4S5jSY28YtD6tKbN9qIaVcRfyagmJ234jz+3W3+GaFE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c636bfc46a2a0c4c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bifWv6gKVpmN9nYafuKx4UEQfbI204FaKWy3IPzUTRJz6sEyYTR7AJa2GYLF/iryY7WAmKkHEPDPi4uNP0Bj+zOcTyIgI32vAIgdNsiZCYDm+NcAawYC6CEemMMI/A/Mv8Svw++nXX9A/oQ6j8AUP36FZ50pRnbNzNg5m0YlYDDK/zPaPdI+bpq8wMgF5kam2VeHZzEIpezzIm4fq3le3vyB16FTXuwlN9n9AU015rVf5/Ao8mnAXBrC/dZb2f7TWS5aBAD/vK90brJwjiY1Y+Mx1SYnZF1DceENO6hUpOPveDsF2U6wW1emdsFOe8fZtzAuMz9Kwqv7h3uTdNu/ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IYabnfGTYSDlSRQTGH+QiW6OL7y+hwSMHNlCer8295U=; b=CFTVh1fa7O3+v2G4OW1WyYpN5QMj0G8mlVqkHcwF3/qvSg8BjJ4OS/wHZvCYNA+pzreLrKaix5QVBSCRTn1CHTOLMPNq1jWG3aSDBO+vFZtRF5btKKT88r0sYufJHZiJkSoNPZJ2WsA3yKdGsWcs0iF60UZfZK2pWHY3AVSatRQ9Q3CqNtg9MHBMsn0W/dmX5AuC5VPhB7eNTkoAkIIrssrowGEHIxcjVuZCK4U/8sxN5/0u7AKOuTf+XSLoaYG45ytGZl7wHAgpalXD1LQVj4I7Jx2BsS6SYHMS9EOyxAq9c8LGIMlD7UIMs4MojI9z8M3gkdZ09/QmFXqKWBMTeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IYabnfGTYSDlSRQTGH+QiW6OL7y+hwSMHNlCer8295U=; b=v/LxC+ADUOFZ6WAv1MC6fRlj32PkmWjno6vahzrjE82SqT28v6RNWdrsKXaV9mjlOR+GB/K2hiOVvWMfl8LICiOuRFs/Q8ohrJED9hdUdg+TvDeKXV7MskS1sjxICn5s4S5jSY28YtD6tKbN9qIaVcRfyagmJ234jz+3W3+GaFE= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/YV3wAgAAz1YA= Date: Thu, 3 Aug 2023 13:03:59 +0000 Message-ID: References: <20230802135350.745251-1-luca.fancellu@arm.com> <9320a2b7-18cd-2766-b115-300755d64932@xen.org> In-Reply-To: <9320a2b7-18cd-2766-b115-300755d64932@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PAWPR08MB10019:EE_|DBAEUR03FT022:EE_|PAWPR08MB10117:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d16cb0e-26d0-4697-ae1b-08db94221f5a x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YyXXwls85j5o8EILzsxUE9hKLMwtZ9W/noC5uVAGAk6phjLGpyErr3PzySpAKiQFfkfxSlzjVXYsh0t6shhxAnmQojCbgyhwgL85zZBtdwQZ0+FfWs7eZ3AcEagwRGGv9K1Vae0YXz6sdgrwf0Swowgt00ik/QjkhwcWpo3t3KTk5xODyIYoFWVqI4j7UxgGt3wnOiA5cg4ZwfyFSsK3YPqYH8YMT+Rt1VxP1AIiytEAySyJojxJ5G2jNWyuyuNXyfS5qEwwUidggrPjnq+Y4fhnB3rUVfyBXFjbl+icySBQ2gTpMEYoqvWaL4GsDsSyy8KGPD7bhXW+SjuzIfT/Uoa6i1hGYoSv3eaTAF7PcDTC1WZeVQrqkZcHJuA9/+WNSfTZlM/7P9CS54e0nig4jKut92NRI1wot1wAUTkNB9549FSnmv1oCX+RYVclkhnpsDue48IF0GPCZFZ7s+2UYZAgjf8q5ZFNNRgZoNDY0SAOTXX64RVPOerTkopn05oQ9MXotq+3Zk4nBdw0/ZEtIWAoqlwo5E5cr24y42k7K2GMhtWnWs5X7z5iA04uT4M0iYBGBQSZ4G82xFw9kb86h/eeJkL50mlKV71OJvGbthAIqzjonAZwxAu4T/Acm91h+swE1mJfkqLwlwOoEnkGSg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199021)(2616005)(6506007)(26005)(186003)(316002)(76116006)(2906002)(91956017)(66946007)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(6916009)(41300700001)(8676002)(8936002)(6486002)(71200400001)(6512007)(54906003)(478600001)(38100700002)(122000001)(33656002)(36756003)(86362001)(38070700005)(66899021)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <983C0E5AEDB8C44D8FA9640A66572CC8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10019 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d6d90a2c-6054-48f3-be86-08db94221a42 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tw5CEVtiULJIN4cBbYO5zSZrwdPZkmNJE1B1Vd9DLBjZLfIvpJH/sQ6Flw2skxYZ3eylBM90KkRes6fKcM01JS2BFvFL+FA4EKWll8+Fwnyjwc/jXnHS0HQ1o/OwRbwmnH6cELmthw2TIiRM2FQCHCujQPnEzu1cTbx3wWumH6FE67zF4nMYA+xBejo3M6TmDT6IyjmW+V4ezAu0WZSD1/dG+qjz0ox7JnqmNYyhk/RDV/wSyzpcYxoY2Kxqw1wuodVsjZ3pGp8JLkjBzyYxfSZ2eIOi+s2n+WV8qznh3f0PbwKnqkGqpUmf2ucYxXj5t9N1Zk09614aiLnRdY82/V0pJqj9vIHWm+y3CJ91XbZn/JmtBTTjI1vLY8TbGrZOeFESPi30u60TwsQsBn1UjDzOCjnGx1c1EsadSjBvCNwkQrY2iSThbryqApgpPyjWyc5ewCb2HyjLAy/ISZ0/HHOu/sQw9ONN+KH1xgPPde1SOc5b+cmQMy+MM9dgnVmUmMAX4RCk5iI3hEEciwQsHcb89AMooJcbsqfoBLQcF/eHUA+OOmUqffKpcQzTt8z11mQ/95m2Vll+yTOrJIqQyAZ/bLxK1vEjRjr/BBFUeIRdCwdWG6FnaexoJliynum93H8IB0DUy6F462wQintXHXeAO+TNIKQ/K/3NHWr8FRHGXxqP4khzmK7+bzl1jKIYAzu2xKHClq6ydZL+/RvxexBj2at1Nd+69AUgsFEAxB4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(82310400008)(451199021)(36840700001)(40470700004)(46966006)(41300700001)(40460700003)(8936002)(8676002)(6862004)(36860700001)(47076005)(6506007)(336012)(186003)(26005)(107886003)(86362001)(2616005)(81166007)(356005)(82740400003)(316002)(40480700001)(54906003)(478600001)(6512007)(6486002)(33656002)(36756003)(4326008)(70586007)(70206006)(2906002)(5660300002)(66899021);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 13:04:07.8736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d16cb0e-26d0-4697-ae1b-08db94221f5a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10117 Hi Julien, >> + >> config GICV3 >> bool "GICv3 driver" >> depends on !NEW_VGIC >> @@ -92,6 +100,11 @@ config HAS_ITS >> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPP= ORTED >> depends on GICV3 && !NEW_VGIC && !ARM_32 >> +config VGICV2 >> + bool "vGICv2 interface for guests" >=20 > This description is a bit misleading as the vGICv2 will also be used for = dom0 in the case of vGICv2. >=20 >> + default y >=20 > Please add a longer help. >=20 >> + depends on (GICV2 || GICV3) && !NEW_VGIC >=20 > In the near future, I don't expect anyone to introduce a new non-GIC of i= nterrupt controller for Arm. But I would expect new version of the GIC. So = I would drop (GICV2 || GICV3). >=20 > Also when !NEW_VGIC is selected, this will make VGICV2 will be unselected= . I was actually expecting the other way around given that new vGIC only of= fer v2 support. >=20 > The rest of the changes LGTM. Thanks a lot for having a look on this patch, you are right the NEW_VGIC is= offering only v2 support at the moment, does this changes captures your Comments? diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 5cdba07df964..1c600b3b8d04 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -110,15 +110,19 @@ config HAS_ITS depends on GICV3 && !NEW_VGIC && !ARM_32 =20 config VGICV2 - bool "vGICv2 interface for guests" + bool "vGICv2 interface for domains" default y - depends on (GICV2 || GICV3) && !NEW_VGIC + help + Provides a virtualised interface for the Generic Interrupt Contro= ller that + can be used by Xen's domains. + If unsure, say Y =20 config HVM def_bool y =20 config NEW_VGIC bool "Use new VGIC implementation" + select VGICV2 ---help--- =20 This is an alternative implementation of the ARM GIC interrupt diff --git a/xen/arch/arm/vgic/Makefile b/xen/arch/arm/vgic/Makefile index 806826948e20..60cbf7f2f94a 100644 --- a/xen/arch/arm/vgic/Makefile +++ b/xen/arch/arm/vgic/Makefile @@ -1,5 +1,5 @@ obj-y +=3D vgic.o -obj-y +=3D vgic-v2.o +obj-$(CONFIG_VGICV2) +=3D vgic-v2.o obj-y +=3D vgic-mmio.o -obj-y +=3D vgic-mmio-v2.o +obj-$(CONFIG_VGICV2) +=3D vgic-mmio-v2.o obj-y +=3D vgic-init.o >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:13:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576364.902402 (Exim 4.92) (envelope-from ) id 1qRY8P-0000FP-RH; Thu, 03 Aug 2023 13:12:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576364.902402; Thu, 03 Aug 2023 13:12:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRY8P-0000FI-Np; Thu, 03 Aug 2023 13:12:57 +0000 Received: by outflank-mailman (input) for mailman id 576364; Thu, 03 Aug 2023 13:12:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRY8O-0000FC-1Y for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:12:56 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 741d7b0e-31ff-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 15:12:54 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691068361302602.0827953807205; Thu, 3 Aug 2023 06:12:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 741d7b0e-31ff-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691068363; cv=none; d=zohomail.com; s=zohoarc; b=KdBsPb/36Bx0f6EAyNk9GAejDbzVKtsrpfId3o9DsKSakDAiXm5iaPRAD3zydRDbmASP0TEiC96RfTIVn12R1QBFxj8TU9SmO2w5UygtJyzXafjUtlwTLBl2tPiE80EoDRd+wjpXVwLeDHqCeWjtwzjbVfftZOskzYHYf+TgOQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691068363; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=p+i+tVUmrsXbTJPh7J2O2HcVZAW1GBPm8/kJrcCQziQ=; b=HmkZojdErOmaW8xbYJKKP6X6BtaE3dQx8oGsIJJWeCitpEzy15wI/RrsrDEY7T/WI9ScJeDbm9AlpNJrzTOOxZvf1JXDMrLUWXM8YHak12EwoFWbGlMFaOfxk7Tw9IGFLux8y7wTKl89AYlIhjVfd0QE6aLeseIOY8JYiymVJk0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691068363; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=p+i+tVUmrsXbTJPh7J2O2HcVZAW1GBPm8/kJrcCQziQ=; b=QZRQZK+9piv1CiQOSJUm2QJ2zYpE37zd78k2Kr3BFRv/47HgBV6nc1SGfYE5tdVc gTXcy1VXwG2W02betM0mkPC7zn9lPXQjfaDCj1FbjaBdNCUo/2aWJVDUUq9pgITk2Fi C0U2v6hlY2RpLXyT9wKLHudxtuw8koe0AmfX0QSk= Message-ID: <98db3f0c-6188-ba1b-7252-ae3e31adbf36@apertussolutions.com> Date: Thu, 3 Aug 2023 09:12:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: Stefano Stabellini , Jan Beulich Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 19:58, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Jan Beulich wrote: >>> - for ( ; ; ) >>> + if ( d == NULL ) >> >> This covers both Xen receiving input and the domain receiving input having >> gone away. Originally in the latter case the next sequential (in domid >> numbering) domain would be switched to. In the new logic you start over >> from the beginning of the domain list. Such a change in behavior (if >> deemed acceptable at all, which I'm not convinced of) needs calling out in >> the description. > > I think it would be best to keep the current behavior as we already > have people using it unless we have strong reasons to change it. I agree and intended to keep the order of switching but I disagree on keeping the complete current behavior. I mean that by the complete current behavior being defined, at least for Arm, as meaning only the domains created at boot. The is_console flag in struct domain is the DAC equivalent to granting the FLASK access XEN__READCONSOLE to a domain, it was just never implemented/used until domoless enable it. An intended consequence of this patch is to ensure any domain granted the privilege, either through the DAC is_console or FLASK XEN__READCONSOLE, is included in the rotation regardless if the domain was created at boot or at runtime. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:14:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:14:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576367.902411 (Exim 4.92) (envelope-from ) id 1qRY9o-0000nO-4e; Thu, 03 Aug 2023 13:14:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576367.902411; Thu, 03 Aug 2023 13:14:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRY9o-0000nH-1W; Thu, 03 Aug 2023 13:14:24 +0000 Received: by outflank-mailman (input) for mailman id 576367; Thu, 03 Aug 2023 13:14:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRY9m-0000n9-P7 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:14:22 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7d7f373-31ff-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 15:14:21 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691068454617635.0981335618633; Thu, 3 Aug 2023 06:14:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7d7f373-31ff-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691068457; cv=none; d=zohomail.com; s=zohoarc; b=Q89MeVFSK8jwhtPdVQ1oDiTvVFk5wAQYSewss5+2mdtjkqUvtbUSTRTRwjqbotQv9N1b6ycmbFOr/xcDzLtdZKAMXDNUYQZLfFSYQFSMKeh1zQ6nr+GfLzJ60FLXUntRLL7AK5K+dUyQuvPLVPTJbiq+5G0gmhR+tSTFiUDTXek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691068457; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hpa3gHQ2YUcIcsojKGTgCk04d0FhFq+N9GgsGAyqK0I=; b=MEJgOtORnusvNfn5amv0ALHqj9tW/X9av8s+JkKKuTAcOOT4HDkkwc6W0wG7S0c2lzAXUCPEHtkWqxP1Xr6rkP2guJmKFCK2kHtVVL1kRioxiz1s1FLk8i2WenpYN69UBuwT9o452WjNeAh7tSb2NDMS/G0twg4/TWsRXpU+j0s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691068457; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=hpa3gHQ2YUcIcsojKGTgCk04d0FhFq+N9GgsGAyqK0I=; b=EXhsZwoho68ZeAJZj20YDTSsCoZvkOJOeiriMfPt/RcUAciEI52ArTWh9uZhZPt7 6x45SE+iyVoRJr5lRA4AqkCug1ezsADZQfbGWzZs74UvQDbjqLr7MKw/R0DWyio6wuy 6m/va2Zz2Kn2npY/Lv45zer/RZtPO0n9blO/Bvcg= Message-ID: <71a942bb-a846-e37c-93e7-eb47cad7b7fa@apertussolutions.com> Date: Thu, 3 Aug 2023 09:14:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Volodymyr Babchuk , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230801161409.25905-1-dpsmith@apertussolutions.com> <20230801161409.25905-3-dpsmith@apertussolutions.com> <7afba030-48f2-baaf-02f9-dae84107a620@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 21:40, Henry Wang wrote: > Hi Daniel, > >> -----Original Message----- >> Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch >>> make: *** [Makefile:183: __sub-make] Error 2 >>> make: Leaving directory '/jenkins/workspace/ais-xenbits- >> xen/layers/xen/xen' >>> >>> The staging itself passed the CI check. Did I miss some context to make >>> this patch works? Could you please provide some hints? Thanks in advance! >> >> Nope you are correct, I now need to go back and look if I sent patches >> out of the wrong branch or if I really did miss cleaning up the original >> declarations in the Arm tree. I fairly confident I made sure gitlab-ci >> passed before I cut the patches for sending, > > I think so, as I saw something related to the Gitlab-CI runners discussion > in IRC yesterday. > >> but since I had three >> different series in flight, I may have gotten jumbled. Apologies for the >> unnecessary churn here. > > No problem at all, I am more than happy to do the test for your > v2 series once it is in the mailing list :)) Great! Thank you! v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:20:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:20:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576372.902422 (Exim 4.92) (envelope-from ) id 1qRYFe-0002IV-OW; Thu, 03 Aug 2023 13:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576372.902422; Thu, 03 Aug 2023 13:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYFe-0002IO-Ll; Thu, 03 Aug 2023 13:20:26 +0000 Received: by outflank-mailman (input) for mailman id 576372; Thu, 03 Aug 2023 13:20:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYFd-0002II-KZ for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:20:25 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0600.outbound.protection.outlook.com [2a01:111:f400:fe1f::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fd4d85f-3200-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 15:20:22 +0200 (CEST) Received: from AM6PR04CA0034.eurprd04.prod.outlook.com (2603:10a6:20b:92::47) by PAXPR08MB6512.eurprd08.prod.outlook.com (2603:10a6:102:15a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 13:20:16 +0000 Received: from AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::eb) by AM6PR04CA0034.outlook.office365.com (2603:10a6:20b:92::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 13:20:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT006.mail.protection.outlook.com (100.127.141.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Thu, 3 Aug 2023 13:20:15 +0000 Received: ("Tessian outbound ba2f3d95109c:v145"); Thu, 03 Aug 2023 13:20:15 +0000 Received: from 4d39f9a696b2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FE1F423C-DA71-4FB6-B999-463B7E1C9A84.1; Thu, 03 Aug 2023 13:19:58 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d39f9a696b2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 13:19:58 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PR3PR08MB5609.eurprd08.prod.outlook.com (2603:10a6:102:81::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 13:19:56 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 13:19:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fd4d85f-3200-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yko7sJmAsPPi1OmFjJV2UWT7nJR71uws+pnhFOs32cY=; b=qclv42IOfnYs3n1ali34BJ986r5SpkhaSAGhFryPNBL6bAYPQTz5otqA1EoIN1zajPyLNV+2Nz+VxEw/usCC41oWl+C3MbYu4tI48lQo+8LCzQ5gDfLqypUUR3sutNwD8oKnuIyIgSGnF1SAfWL3P4PoYN2MVHITu1PQLbcKuuA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 807d66da92d13ce1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYko0bpM/8JPO7Zo2xzS4CIuTuiNDzMRGIAX9yL9t3GyQDXQ7XaoTOVHhMFA0WmpwCsfwqAywJuUfmIBMhPXfY6pmpyZuMWZ0XP/dRFw5k1c6qBrENug83VMsjuhV/uMAwshdOU2S/kpZt3aBatkX9nt1iFQnaB405pDNCj3fN3cbNb4USjfDYpAyK7Au7DI9XEowDI2CAz8afhu6TkwnMH6k15exGosjz7ncTIfh8AYnGg+NeVxozV0CHvsgUud0O+qUpkI1Bw96O13lp7M1svHMufD85ukxd9w/jq31e2ArK+7xHmsAUXBgEjzHGFMtnONDOauXH/r38ERl2SAlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yko7sJmAsPPi1OmFjJV2UWT7nJR71uws+pnhFOs32cY=; b=fIB7skvQuVMrADkKLzSsj5ZhveGNVBxgXZh4VFrRyDpKYu8z3yXqkfrGEzycNho32NwQLOMWl1h3NbZGpgz0k8xfSykrvyzH66a1QTTBjt0lv613qYx9JlFomzEAcpSY/5pY3FZjSRGtbOxeBWVqsxb4kBWKZURG2q0Sxl8pe85uCZ7ZELo9E4+ZOTJ8llQYOuUeiol+spwmg4YV6K6TDFnqEjL7ogLIx1X5PXUu/LiErj35fGUcRfPbNsWdxe5mzm0bcyQ3bXC7/2IKkgEvEAjent+ZY24cxhOI6gSBsCYuQcdhV0NLXAmDGA6bbXdw9kcL4Nr9g2HJlbC8YJgJvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yko7sJmAsPPi1OmFjJV2UWT7nJR71uws+pnhFOs32cY=; b=qclv42IOfnYs3n1ali34BJ986r5SpkhaSAGhFryPNBL6bAYPQTz5otqA1EoIN1zajPyLNV+2Nz+VxEw/usCC41oWl+C3MbYu4tI48lQo+8LCzQ5gDfLqypUUR3sutNwD8oKnuIyIgSGnF1SAfWL3P4PoYN2MVHITu1PQLbcKuuA= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Topic: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Thread-Index: AQHZxUjDKmzjB69oo0mbnCqJ2MJvKa/YV3wAgAAz1YCAAAR1AA== Date: Thu, 3 Aug 2023 13:19:56 +0000 Message-ID: <4F3C5624-A96E-4AB0-87B2-B5F67B8661E2@arm.com> References: <20230802135350.745251-1-luca.fancellu@arm.com> <9320a2b7-18cd-2766-b115-300755d64932@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PR3PR08MB5609:EE_|AM7EUR03FT006:EE_|PAXPR08MB6512:EE_ X-MS-Office365-Filtering-Correlation-Id: d3a0d8cd-e0f2-4672-7798-08db94246024 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IBbBU4tIX8myHPmT5cPD0CcekePGjPqEQJ8iP+bXwueP5tyY8QKF4ZeVzelOsgRg+rOrifLWSJK9qeSkiDzQZVct7bQqOpj9z+AZ5Os1yexr0Tgn20hyDqpOmmrH1mte5MMj6RYvF4ecPlT4YrNCxEQFQHodL51+hxj/wdMH1F6bKRb5g53efhdCk5bYQW28f6eyGIeXBWS3rGY9GB1/vFjA78yqPM9HouCwO0zfm7ctHGiYpHFlSy/+62Ap41jC1xTLFHIPAdLqLEi20TOo/BwDQ0GM6agbVEcYAe7lVuAizB4PNZoBSd6ConbomIAmMer6rRmydfK+zr4UKOb5Ieq2Ro4LJYz4YbYwDJ3uMUQyGnaZZA7cJ+dYs7gujsMtoCrB9sK5OyB112lK5Cf441BQLEPS6KdxTdIrwHAOfG/qRjhtDycTCv/6SbeVr3elZNSJUdHRoZENKSmjTDqGGqTPI/4WqSq2fHsUrHQsTBjAR5s9T4tZ7CxJgPllXZ8GYMSIzwJvFWQew/MDdRdrf4bDMR6NfHtSnzxUIWjBoPT1YIl85Nuni5CQZDVK7CstTEkDleojOOvzkaRPXKqUJU9q/iuKMN5hPfP5AHJL9evHlZKt4eh1XKY1tAoQ+dUO9F+DwYDinV98c4DMr2zsNA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(366004)(376002)(451199021)(2616005)(53546011)(6506007)(26005)(186003)(316002)(76116006)(2906002)(91956017)(66946007)(4326008)(64756008)(66446008)(66476007)(66556008)(5660300002)(6916009)(41300700001)(8676002)(8936002)(6486002)(71200400001)(6512007)(54906003)(478600001)(38100700002)(122000001)(86362001)(33656002)(36756003)(38070700005)(66899021)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1E440CA75D497E4BA154F459819B38B6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5609 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7f3a274e-0b82-4730-88ba-08db942454de X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VMeNzhD+XdzWNYvvI6YlGjt6YhCd5FsriRWhglz8b9iqYm/WUwouuxhIeAYAMmtlyBORkR0kfT7leAjhKSdlJOoDkDAJg01LoqdjUnah9HgjpUf2MHfqA6Hg1HD1K3gJss5s3rmvonjIHrheHDdh2pkqxY6oAK6YEgqWva2lgueazGOh90qAkyxly50J0QGNYaNoXfIMZoOcQBTWqxHOZ/KoQ+ZYToX+8W7R4gKVopHLeSQWtuhfe//CAfO0XphdoCSdIxRj7M/fgW5pMPvwcq0RHVHFJZUIKsVfoJJ3MGZZqyyIHoADs/pGobTqKSJgxER6lrKbqju8SlhfM6SKH86lCvYL0jmodv1w98dNUwsRJ1TdaMZaGc59fUlUYtJ9smvS14XcM0o3n7XEuV2h3uzOyGWXnM9eS6indhUuoIwjayJp1LyHfgCJpSey4xOU/3/u24UjASTE6kROUQ0/R9ol9eNudWGDGjYxiaXUhJZvnSShlJdwbAIsQfLMmt8C0V/yo9EwMQszm/rXpDz0GDf0vuWBBSPRrGXidgGvM77HdktX53W/N8jbbApFPwxw/waZmA4YVnEuqhGAyUCZIawJaWE7OlDyfE82v89ypgJhHOsWYJr7VhY1L410Q8dT25J4NsBVa2PvEFdcIhIE7i6RAIc5jwrL18hSXXT9DVErJj89KgRXUmbQTkGi+Df9M7ATUAMOvjYDwIl8ysKzt9NnoicYoxYTyVf5JfRcLGE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(82310400008)(40470700004)(46966006)(36840700001)(40460700003)(2616005)(107886003)(53546011)(6506007)(26005)(186003)(336012)(47076005)(36860700001)(316002)(2906002)(70586007)(70206006)(4326008)(5660300002)(6862004)(41300700001)(8676002)(8936002)(6486002)(6512007)(54906003)(478600001)(40480700001)(356005)(81166007)(86362001)(33656002)(36756003)(82740400003)(66899021);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 13:20:15.4699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3a0d8cd-e0f2-4672-7798-08db94246024 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6512 DQoNCj4gT24gMyBBdWcgMjAyMywgYXQgMTQ6MDMsIEx1Y2EgRmFuY2VsbHUgPEx1Y2EuRmFuY2Vs bHVAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiBIaSBKdWxpZW4sDQo+IA0KPj4+ICsNCj4+PiBjb25m aWcgR0lDVjMNCj4+PiAgYm9vbCAiR0lDdjMgZHJpdmVyIg0KPj4+ICBkZXBlbmRzIG9uICFORVdf VkdJQw0KPj4+IEBAIC05Miw2ICsxMDAsMTEgQEAgY29uZmlnIEhBU19JVFMNCj4+PiAgICAgICAg IGJvb2wgIkdJQ3YzIElUUyBNU0kgY29udHJvbGxlciBzdXBwb3J0IChVTlNVUFBPUlRFRCkiIGlm IFVOU1VQUE9SVEVEDQo+Pj4gICAgICAgICBkZXBlbmRzIG9uIEdJQ1YzICYmICFORVdfVkdJQyAm JiAhQVJNXzMyDQo+Pj4gK2NvbmZpZyBWR0lDVjINCj4+PiArIGJvb2wgInZHSUN2MiBpbnRlcmZh Y2UgZm9yIGd1ZXN0cyINCj4+IA0KPj4gVGhpcyBkZXNjcmlwdGlvbiBpcyBhIGJpdCBtaXNsZWFk aW5nIGFzIHRoZSB2R0lDdjIgd2lsbCBhbHNvIGJlIHVzZWQgZm9yIGRvbTAgaW4gdGhlIGNhc2Ug b2YgdkdJQ3YyLg0KPj4gDQo+Pj4gKyBkZWZhdWx0IHkNCj4+IA0KPj4gUGxlYXNlIGFkZCBhIGxv bmdlciBoZWxwLg0KPj4gDQo+Pj4gKyBkZXBlbmRzIG9uIChHSUNWMiB8fCBHSUNWMykgJiYgIU5F V19WR0lDDQo+PiANCj4+IEluIHRoZSBuZWFyIGZ1dHVyZSwgSSBkb24ndCBleHBlY3QgYW55b25l IHRvIGludHJvZHVjZSBhIG5ldyBub24tR0lDIG9mIGludGVycnVwdCBjb250cm9sbGVyIGZvciBB cm0uIEJ1dCBJIHdvdWxkIGV4cGVjdCBuZXcgdmVyc2lvbiBvZiB0aGUgR0lDLiBTbyBJIHdvdWxk IGRyb3AgKEdJQ1YyIHx8IEdJQ1YzKS4NCj4+IA0KPj4gQWxzbyB3aGVuICFORVdfVkdJQyBpcyBz ZWxlY3RlZCwgdGhpcyB3aWxsIG1ha2UgVkdJQ1YyIHdpbGwgYmUgdW5zZWxlY3RlZC4gSSB3YXMg YWN0dWFsbHkgZXhwZWN0aW5nIHRoZSBvdGhlciB3YXkgYXJvdW5kIGdpdmVuIHRoYXQgbmV3IHZH SUMgb25seSBvZmZlciB2MiBzdXBwb3J0Lg0KPj4gDQo+PiBUaGUgcmVzdCBvZiB0aGUgY2hhbmdl cyBMR1RNLg0KPiANCj4gVGhhbmtzIGEgbG90IGZvciBoYXZpbmcgYSBsb29rIG9uIHRoaXMgcGF0 Y2gsIHlvdSBhcmUgcmlnaHQgdGhlIE5FV19WR0lDIGlzIG9mZmVyaW5nIG9ubHkgdjIgc3VwcG9y dCBhdCB0aGUgbW9tZW50LCBkb2VzIHRoaXMgY2hhbmdlcyBjYXB0dXJlcyB5b3VyDQo+IENvbW1l bnRzPw0KPiANCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9LY29uZmlnIGIveGVuL2FyY2gv YXJtL0tjb25maWcNCj4gaW5kZXggNWNkYmEwN2RmOTY0Li4xYzYwMGIzYjhkMDQgMTAwNjQ0DQo+ IC0tLSBhL3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9LY29uZmln DQo+IEBAIC0xMTAsMTUgKzExMCwxOSBAQCBjb25maWcgSEFTX0lUUw0KPiAgICAgICAgIGRlcGVu ZHMgb24gR0lDVjMgJiYgIU5FV19WR0lDICYmICFBUk1fMzINCj4gDQo+IGNvbmZpZyBWR0lDVjIN Cj4gLSAgICAgICBib29sICJ2R0lDdjIgaW50ZXJmYWNlIGZvciBndWVzdHMiDQo+ICsgICAgICAg Ym9vbCAidkdJQ3YyIGludGVyZmFjZSBmb3IgZG9tYWlucyINCj4gICAgICAgIGRlZmF1bHQgeQ0K PiAtICAgICAgIGRlcGVuZHMgb24gKEdJQ1YyIHx8IEdJQ1YzKSAmJiAhTkVXX1ZHSUMNCj4gKyAg ICAgICBoZWxwDQo+ICsgICAgICAgICBQcm92aWRlcyBhIHZpcnR1YWxpc2VkIGludGVyZmFjZSBm b3IgdGhlIEdlbmVyaWMgSW50ZXJydXB0IENvbnRyb2xsZXIgdGhhdA0KPiArICAgICAgICAgY2Fu IGJlIHVzZWQgYnkgWGVuJ3MgZG9tYWlucy4NCj4gKyAgICAgICAgIElmIHVuc3VyZSwgc2F5IFkN Cj4gDQo+IGNvbmZpZyBIVk0NCj4gICAgICAgICBkZWZfYm9vbCB5DQo+IA0KPiBjb25maWcgTkVX X1ZHSUMNCj4gICAgICAgIGJvb2wgIlVzZSBuZXcgVkdJQyBpbXBsZW1lbnRhdGlvbiINCj4gKyAg ICAgICBzZWxlY3QgVkdJQ1YyDQoNClNvcnJ5LCBJIG1lYW50IHRvIHVzZSBoZXJlIOKAnHNlbGVj dCBHSUNWMiINCg0KPiAgICAgICAgLS0taGVscC0tLQ0KPiANCj4gICAgICAgIFRoaXMgaXMgYW4g YWx0ZXJuYXRpdmUgaW1wbGVtZW50YXRpb24gb2YgdGhlIEFSTSBHSUMgaW50ZXJydXB0DQo+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdmdpYy9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS92Z2lj L01ha2VmaWxlDQo+IGluZGV4IDgwNjgyNjk0OGUyMC4uNjBjYmY3ZjJmOTRhIDEwMDY0NA0KPiAt LS0gYS94ZW4vYXJjaC9hcm0vdmdpYy9NYWtlZmlsZQ0KPiArKysgYi94ZW4vYXJjaC9hcm0vdmdp Yy9NYWtlZmlsZQ0KPiBAQCAtMSw1ICsxLDUgQEANCj4gb2JqLXkgKz0gdmdpYy5vDQo+IC1vYmot eSArPSB2Z2ljLXYyLm8NCj4gK29iai0kKENPTkZJR19WR0lDVjIpICs9IHZnaWMtdjIubw0KPiBv YmoteSArPSB2Z2ljLW1taW8ubw0KPiAtb2JqLXkgKz0gdmdpYy1tbWlvLXYyLm8NCj4gK29iai0k KENPTkZJR19WR0lDVjIpICs9IHZnaWMtbW1pby12Mi5vDQo+IG9iai15ICs9IHZnaWMtaW5pdC5v DQo+IA0KPiANCj4gDQo+PiANCj4+IENoZWVycywNCj4+IA0KPj4gLS0gDQo+PiBKdWxpZW4gR3Jh bGwNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:23:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:23:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576376.902431 (Exim 4.92) (envelope-from ) id 1qRYIq-0002s6-5h; Thu, 03 Aug 2023 13:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576376.902431; Thu, 03 Aug 2023 13:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYIq-0002rz-30; Thu, 03 Aug 2023 13:23:44 +0000 Received: by outflank-mailman (input) for mailman id 576376; Thu, 03 Aug 2023 13:23:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYIp-0002rt-Fw for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:23:43 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f59c6287-3200-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 15:23:40 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 169106901259642.063268145639086; Thu, 3 Aug 2023 06:23:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f59c6287-3200-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691069015; cv=none; d=zohomail.com; s=zohoarc; b=BiQp6xKBP2N5/sQdi/zRz5pj+IjMcGxsdkvzrctqilXN+h7OgrW+CfaJ12R6xEBUlpSduV70yEs6lzDOZJbhkQ1VhdBtOctWENg70o/sdLvkZ5A2yE8Fis0p8i1qavWxKyfHe7OamaoOOYRZhC3v047h4FubC1a/euDZPHenQ/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691069015; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=J3fJ8+Sv5o5vmk9lGPGuBN12/HbQyJ1QFr9EUpAwrSk=; b=MlavFkGMsdS6Oytr2yOXlo5q47mpd5dmayta6l0/47HC6aW9sqHmanBn4S7nMv5t1udCRR5fpYiTLiJZesADwQCcsiy0JIsPg3p1NwFABxnlJe1LeN/EAyelX/Di8Wfk401qmq/AvZ6AsnqpfNNIAUFIEDZSFU4Cz8eEA2GtIvA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691069015; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=J3fJ8+Sv5o5vmk9lGPGuBN12/HbQyJ1QFr9EUpAwrSk=; b=tqc09EoRCVNnVVEYe4qYXVVlduZpifrxlRSO7ZD5JEw88GgZ1/fpvKekkn4EFPmK KfIaMJQW0qZoNZNhogVmR9U5sBdMrwp4NFHv3X59PLOWYZcBGsqA7V+TnB+ac0U/kLt hRbp6g8wux5cUpa3HLs7UeKlh+2oz025CN9f30L4= Message-ID: <29453e14-27e5-eb2c-daeb-ae9a46fd9e29@apertussolutions.com> Date: Thu, 3 Aug 2023 09:23:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 1/6] dom0: replace explict zero checks Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, xen-devel@dornerworks.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , roberto.bagnara@bugseng.com References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/1/23 20:24, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Daniel P. Smith wrote: >> A legacy concept is that the initial domain will have a domain id of zero. As a >> result there are places where a check that a domain is the inital domain is >> determined by an explicit check that the domid is zero. >> >> This commit seeks to abstract this check into a function call and replace all >> check locations with the function call. >> >> Signed-off-by: Daniel P. Smith > > Thanks for the patch, this is a good cleanup! Thank you for the sentiment as well as giving it a review! >> --- >> xen/common/domain.c | 4 ++-- >> xen/common/sched/arinc653.c | 2 +- >> xen/common/sched/core.c | 4 ++-- >> xen/include/xen/sched.h | 7 +++++++ >> 4 files changed, 12 insertions(+), 5 deletions(-) >> >> diff --git a/xen/common/domain.c b/xen/common/domain.c >> index 304aa04fa6..8fb3c052f5 100644 >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -309,7 +309,7 @@ static int late_hwdom_init(struct domain *d) >> struct domain *dom0; >> int rv; >> >> - if ( d != hardware_domain || d->domain_id == 0 ) >> + if ( d != hardware_domain || is_initial_domain(d) ) >> return 0; >> >> rv = xsm_init_hardware_domain(XSM_HOOK, d); >> @@ -612,7 +612,7 @@ struct domain *domain_create(domid_t domid, >> d->is_privileged = flags & CDF_privileged; >> >> /* Sort out our idea of is_hardware_domain(). */ >> - if ( domid == 0 || domid == hardware_domid ) >> + if ( is_initial_domain(d) || domid == hardware_domid ) >> { >> if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED ) >> panic("The value of hardware_dom must be a valid domain ID\n"); >> diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c >> index a82c0d7314..31e8270af3 100644 >> --- a/xen/common/sched/arinc653.c >> +++ b/xen/common/sched/arinc653.c >> @@ -404,7 +404,7 @@ a653sched_alloc_udata(const struct scheduler *ops, struct sched_unit *unit, >> * Add every one of dom0's units to the schedule, as long as there are >> * slots available. >> */ >> - if ( unit->domain->domain_id == 0 ) >> + if ( is_initial_domain(unit->domain) ) >> { >> entry = sched_priv->num_schedule_entries; >> >> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c >> index 022f548652..210ad30f94 100644 >> --- a/xen/common/sched/core.c >> +++ b/xen/common/sched/core.c >> @@ -585,7 +585,7 @@ int sched_init_vcpu(struct vcpu *v) >> */ >> sched_set_affinity(unit, cpumask_of(0), cpumask_of(0)); >> } >> - else if ( d->domain_id == 0 && opt_dom0_vcpus_pin ) >> + else if ( is_initial_domain(d) && opt_dom0_vcpus_pin ) >> { >> /* >> * If dom0_vcpus_pin is specified, dom0 vCPUs are pinned 1:1 to >> @@ -594,7 +594,7 @@ int sched_init_vcpu(struct vcpu *v) >> sched_set_affinity(unit, cpumask_of(processor), &cpumask_all); >> } >> #ifdef CONFIG_X86 >> - else if ( d->domain_id == 0 ) >> + else if ( is_initial_domain(d) ) >> { >> /* >> * In absence of dom0_vcpus_pin instead, the hard and soft affinity of >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 854f3e32c0..a9276a7bed 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -1058,6 +1058,13 @@ void scheduler_disable(void); >> void watchdog_domain_init(struct domain *d); >> void watchdog_domain_destroy(struct domain *d); >> >> +static always_inline bool is_initial_domain(const struct domain *d) > > I know you used always_inline only because is_hardware_domain just below > also uses it, but I wonder if we need it. I was under the impression that access checks like these could end up in fast paths, so we wanted to coax the compiler into inlining these whenever possible. If others feel it is not needed, I have no objection to moving it to just inline. > Also, Robero, it looks like always_inline is missing from > docs/misra/C-language-toolchain.rst? Or do we plan to get rid of it? > > >> +{ >> + static int init_domain_id = 0; > > I take it is done this way because you plan to make it configurable? As you see in a later patch, it gets changed into an assignable role for the domain. >> + return d->domain_id == init_domain_id; >> +} >> + >> /* >> * Use this check when the following are both true: >> * - Using this feature or interface requires full access to the hardware >> -- >> 2.20.1 >> From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:33:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:33:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576381.902442 (Exim 4.92) (envelope-from ) id 1qRYSW-0004Qv-8b; Thu, 03 Aug 2023 13:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576381.902442; Thu, 03 Aug 2023 13:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYSW-0004Qo-5e; Thu, 03 Aug 2023 13:33:44 +0000 Received: by outflank-mailman (input) for mailman id 576381; Thu, 03 Aug 2023 13:33:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYSV-0004Qi-Eu for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:33:43 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b9c3325-3202-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 15:33:41 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691069615584770.6636556301372; Thu, 3 Aug 2023 06:33:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b9c3325-3202-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691069617; cv=none; d=zohomail.com; s=zohoarc; b=a3h63MK2gqqr7HV5WiKivaBYU2qc1JH8mSkkMRa3GGxpAJrc3mDSJLRWCNLMhu4aDvLIVQZnd09ViDGkdrxurtq4PeZUdgHRmfpcyNk87NvJmLm/2gWz0Ocsa8Lnndw364Qez1mHeP6bysOBTWJpZkC6oTv6w2H/vvcytFKsJAA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691069617; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Ah/XQd/hZBpE0Stgw+77JLFwk+CLLIchBNGJVpobHsw=; b=SA70azil8tnYy79SvP1wvrnL962CXEFnroSL3gVu2Jv0GpMwq+srw7uMZsSttFIh3G8d82Ne7kPc0rahaB3Xcuo5CCRD5JmKHGPW0lnKHUtJxNnAFrt0XGJVfNZCL7liWzV6DiR8Y5032OYjO4Tg/yHLIgLVM6jYb9pbKnddLtc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691069617; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Ah/XQd/hZBpE0Stgw+77JLFwk+CLLIchBNGJVpobHsw=; b=akadWhX6dWJWP+gGzIgjQG/IWLjfTS3QsqISmCJZQAblUybAsFAKx6QmdWVs03qC NBAoqxg2sJOlsNVh55S2JjjraT/dD7DkE1Varmgu11VdaS85k5fw4Y9QHkR/1f9d0Xb cLLnz20jp0UDVG2gfDbvGCbnF7/k/GWmf10k6vh0= Message-ID: <97319344-02d2-4fa4-9325-fbcd74364bdf@apertussolutions.com> Date: Thu, 3 Aug 2023 09:33:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 1/6] dom0: replace explict zero checks Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 03:46, Jan Beulich wrote: > On 01.08.2023 22:20, Daniel P. Smith wrote: >> A legacy concept is that the initial domain will have a domain id of zero. As a >> result there are places where a check that a domain is the inital domain is >> determined by an explicit check that the domid is zero. > > It might help if you at least outlined here why/how this is going to > change. Okay, I will try expanding on this further. >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -1058,6 +1058,13 @@ void scheduler_disable(void); >> void watchdog_domain_init(struct domain *d); >> void watchdog_domain_destroy(struct domain *d); >> >> +static always_inline bool is_initial_domain(const struct domain *d) >> +{ >> + static int init_domain_id = 0; > > This may then also help with the question on why you use a static > variable here. (In any event the type of this variable wants to > be correct; plain int isn't appropriate ... Ah, so this is a dated patch that I brought because of the abstraction it made. The intent in the original series for making it static was in preparation to handle the shim case where init_domid() would have return a non-zero value. So the static can be dropped and changed to domid_t. >> + return d->domain_id == init_domain_id; > > ... for this comparison.) > > Jan v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:36:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:36:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576384.902452 (Exim 4.92) (envelope-from ) id 1qRYV4-00050b-LB; Thu, 03 Aug 2023 13:36:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576384.902452; Thu, 03 Aug 2023 13:36:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYV4-00050U-IP; Thu, 03 Aug 2023 13:36:22 +0000 Received: by outflank-mailman (input) for mailman id 576384; Thu, 03 Aug 2023 13:36:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYV3-00050O-Lz for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:36:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYUx-0007Rw-KE; Thu, 03 Aug 2023 13:36:15 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRYUx-0007VQ-DO; Thu, 03 Aug 2023 13:36:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=M9kx6ktWiLuSAUESx8zDJ4d5/ShxILEjEUccuRaSgU4=; b=FNJCDzZ2NfQ6yOOgKz/pJEhpcR NbSUJ4robBR5lWxtQLrDGGNq0VXfl1a0VazHvqxQ2OPDY8Ie1uLH2SlsDDvFnDMR5RKrOlMoLl8f0 0GI/DBbx0PX+d84GtFD/vAa3+LgwtiVsfqgGcya9OtvGsiSKMns62gQPfxy/sqinM0KU=; Message-ID: Date: Thu, 3 Aug 2023 14:36:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/6] dom0: replace explict zero checks Content-Language: en-GB To: "Daniel P. Smith" , Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> <97319344-02d2-4fa4-9325-fbcd74364bdf@apertussolutions.com> From: Julien Grall In-Reply-To: <97319344-02d2-4fa4-9325-fbcd74364bdf@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Daniel, On 03/08/2023 14:33, Daniel P. Smith wrote: > On 8/2/23 03:46, Jan Beulich wrote: >> On 01.08.2023 22:20, Daniel P. Smith wrote: >>> A legacy concept is that the initial domain will have a domain id of >>> zero. As a >>> result there are places where a check that a domain is the inital >>> domain is >>> determined by an explicit check that the domid is zero. >> >> It might help if you at least outlined here why/how this is going to >> change. > > Okay, I will try expanding on this further. > >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -1058,6 +1058,13 @@ void scheduler_disable(void); >>>   void watchdog_domain_init(struct domain *d); >>>   void watchdog_domain_destroy(struct domain *d); >>> +static always_inline bool is_initial_domain(const struct domain *d) >>> +{ >>> +    static int init_domain_id = 0; >> >> This may then also help with the question on why you use a static >> variable here. (In any event the type of this variable wants to >> be correct; plain int isn't appropriate ... > > Ah, so this is a dated patch that I brought because of the abstraction > it made. The intent in the original series for making it static was in > preparation to handle the shim case where init_domid() would have return > a non-zero value. > > So the static can be dropped and changed to domid_t. Looking at one of the follow-up patch, I see: static always_inline bool is_initial_domain(const struct domain *d) { - static int init_domain_id = 0; - - return d->domain_id == init_domain_id; + return d->role & ROLE_UNBOUNDED_DOMAIN; } So is there any point to have the local variable? IOW, can't this simply be "d->domain_id == 0"? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:44:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:44:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576389.902462 (Exim 4.92) (envelope-from ) id 1qRYdC-0006Wi-H8; Thu, 03 Aug 2023 13:44:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576389.902462; Thu, 03 Aug 2023 13:44:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYdC-0006Wb-EV; Thu, 03 Aug 2023 13:44:46 +0000 Received: by outflank-mailman (input) for mailman id 576389; Thu, 03 Aug 2023 13:44:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYdA-0006WV-Nv for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:44:44 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20620.outbound.protection.outlook.com [2a01:111:f400:fe16::620]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5d62ad1-3203-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 15:44:42 +0200 (CEST) Received: from DUZPR01CA0013.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::6) by AM8PR08MB5633.eurprd08.prod.outlook.com (2603:10a6:20b:1d3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 13:44:39 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3c3:cafe::c6) by DUZPR01CA0013.outlook.office365.com (2603:10a6:10:3c3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43 via Frontend Transport; Thu, 3 Aug 2023 13:44:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Thu, 3 Aug 2023 13:44:39 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Thu, 03 Aug 2023 13:44:39 +0000 Received: from a455a34f525b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BB97611D-1219-4BE0-8D5D-AE92427DD36C.1; Thu, 03 Aug 2023 13:44:32 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a455a34f525b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 13:44:32 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DBBPR08MB6106.eurprd08.prod.outlook.com (2603:10a6:10:202::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 13:44:30 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 13:44:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5d62ad1-3203-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G+8rGRNjKxGdiV+gyhWlFDoq2gCSj/NyKItPF4XCZDg=; b=dc5CZox9LbKxWGE7dVBUmR43WFAkA/9B9bR0wwgL2MOwVKU/NYL367XQNZoah2cFBWNLqz0RfHdhIBQ6XxLzdg6Aed3xCX6/Zz7bbCjdIkmRJQApyj54P121R5Cst1W3oqa+Yw+cLPZc2f6C6UX/CMuVopKIVEDnka6zTHfeOkA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7c9fdae8b09ee7ae X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=keFHdqTiE04cY9q2DgTLNf2s+vjIW/vfUuNNkvl97FAD/iO+GZHGDun/Mj1TYuLwNofQQpYpAd5rbyPb17D0Q2ZgRAUhhSuyaxYEk8UWuSwmNVRWEAxjcmyMcs1Dt3TS4MHPW9BkOLZHXJtqOxKnomppHEqZY+DapRm0cXasg6qnWcXzx5InGJpWuoJbu/nw8j6xiLOEBW9KPmAekZX9bBM/H3iMREvmCfhJmLbrZR2Nxvh0ZMySnx6VKPH89H2cSyHqNzya/JE9gqhE0+U6vUKz77O4qW+5nxX7CXywCYh2dexRIaJmakwUHHn93K6nAlAu95izHqb00CZl2WisGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G+8rGRNjKxGdiV+gyhWlFDoq2gCSj/NyKItPF4XCZDg=; b=Tuypze9y+LAGJ3VXvdrZKbTM0uW6dC3gmn4DeVN3iFCsepcBzFGfU4fOph7xy/SbGaEVEmPztx6/WDmhjj6Td2yet15c2A72+3br7EdvFiSRjrObDj5VO0IzkTth8FXWMJYn9sgvBjHfdC0LQdcrVDCSaHcxK5YJx8uylUGeiWpYiRE4RgMQHhIdGufQKy0d3Ac7I9b3gnSWhDW7M1RasevaMYowZ+ekXDskyp44dcIk1EOGlEmeVS1PbYYGcTRFEqoXM+Dx5drJgq80Fl27jo8/DY/JZwbA8AV2vEmWks35vPlKrjooeJ0d4jj8v68nEr1BxONPZZ4zpLA1TRMUiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G+8rGRNjKxGdiV+gyhWlFDoq2gCSj/NyKItPF4XCZDg=; b=dc5CZox9LbKxWGE7dVBUmR43WFAkA/9B9bR0wwgL2MOwVKU/NYL367XQNZoah2cFBWNLqz0RfHdhIBQ6XxLzdg6Aed3xCX6/Zz7bbCjdIkmRJQApyj54P121R5Cst1W3oqa+Yw+cLPZc2f6C6UX/CMuVopKIVEDnka6zTHfeOkA= From: Luca Fancellu To: Simone Ballarin CC: Xen-devel , "consulting@bugseng.com" , Gianluca Luparini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3 Thread-Topic: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3 Thread-Index: AQHZxfSdOEvKJttXMkm/J+fEFT8536/YlUqA Date: Thu, 3 Aug 2023 13:44:30 +0000 Message-ID: <3B413D0B-A2A8-40FD-A301-D0524B539827@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DBBPR08MB6106:EE_|DBAEUR03FT051:EE_|AM8PR08MB5633:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ecf84e7-c742-4afe-5d37-08db9427c896 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3pwB/scOQK2wHfAJqst7TNdifhVc6AS//oku9IyCs45CzZhwgfbrQ5ciXU7eBg6CcSdpUbO/O4UNlYkqxkHejwFACxI2M3RpFNKctIm10L6xxGnAG6E1pUq9BQpy45nnUi+9PSA9AqCYaZ8NKNIor1WY5w96H91oep+dTxfJCvxyfo8Gs7V3PFMbSQFAKvgVIp700M0ibPdaJLuLO3g3hnx19P02c9xhbg1NaeW5lrw83QS5JsE2nQy6ckUZZpw5+DQiT6UmCFrVWYKo54zMZbqzTGkB1umEyO3MPC1ThpHKvX2yzgYD52hXsO7TVrNNqccLC4/OUECZBB6BRBu+gPmzNCf79WQ0kNT+97cFIJ13mvOCv+xXKIBX2Go/eJRrrrNiET3aN4ms1JcB5QxpwVZ9l4Dz3uqKq/oySUdQCe1TpWWL8501qBIxVPz1/B44qwkauQpCy6gCM+9vejomIFdJCQ1EfXPv41MkAz6n+Tj4OAkjeGnO6KkDWA7kcptsoFQyO7BWahHHB4VZItpZ208I4bvqktlIOKHTJkCXWcbbR2/LFfHsg8dGySm7NuKyqo54l7fK4NHJQCVUlrcz7EAP4zYAzxOTx6Dgbw/1FmNH3dNHR88gCeAEAQ990s1ASZ00Suh5oXfLEqz/HGHbag== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(4744005)(41300700001)(66556008)(66446008)(316002)(2906002)(91956017)(4326008)(76116006)(6916009)(64756008)(66946007)(66476007)(8936002)(8676002)(5660300002)(122000001)(38100700002)(33656002)(26005)(36756003)(53546011)(186003)(38070700005)(6506007)(86362001)(2616005)(6512007)(478600001)(54906003)(71200400001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6106 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4cb018a0-9b6d-4528-03ec-08db9427c342 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vZiv4E9sV0ZqhzXLT73+vKoKaXb+W0BWf+5zTR0S4051Mt90Xm206wo6bxRvfp0BF0dEVduK7/mO9cjERkYAzGxNCaXRXf9rIgEX2uIZIla78tN6vMsO7+wJtOvspZj3gULe+sQ6nGnIsMCCp2hKGTcgEMnmIhFRlIQDd+XVzpFKam8vnYlhMhbxlbdNTIkvMVSIjB4juMIwIHAIQsTI7SiUdj6BbT+CyN0HjGNQm7EuOn1ZBlMWPJ5AaT96mBFUos1seX5m4T5bZeOVkjMecKv712+Ox46b61utCATWoE9+u5Tjr2txO/7H5DwZKwhEm9N8NQcZpuhwjxhCH0AsCI9eE4TKwRID5A+9pDHNVyOH6aaY13iHZsmFOZz9SN77FKcw51b+Sn2syhNH3LHMtV/f7DS/QA0JF1H7pw6pMQmgwric21le6+RzFRzGs2Kqmc4guaGJ65qtAqFeyo9Tp+a/u6V9QWIQbKOjU4W5CymjfLIrdrzw0PqPCjTP6OZBSeaOajp07c4mNZxlu/Iu3GSRz8WDsNg7IbUqQ+cbZAFhtrU5ni4pNlyAG2uIiMJyuz58pAcbVrgtiao2m72ZyO6/vGNJ/JADTgvsgrI8pTpyA923HDlGdNp573GP09PN8PMglyZOfBBA5MIsmuQtk8RVm/aMx4/AJImhEXsAN4Iz5kNUhtcn6YTNCXr6cpxoZXM6vvlVakUasvVBrhDfr24J24POh3zDb4rDopzYVNI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199021)(82310400008)(46966006)(36840700001)(40470700004)(86362001)(36756003)(33656002)(82740400003)(40460700003)(40480700001)(54906003)(478600001)(356005)(81166007)(47076005)(2616005)(6506007)(336012)(186003)(26005)(107886003)(53546011)(8676002)(8936002)(6862004)(41300700001)(6512007)(6486002)(316002)(36860700001)(4744005)(5660300002)(4326008)(70586007)(2906002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 13:44:39.2990 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ecf84e7-c742-4afe-5d37-08db9427c896 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5633 > On 3 Aug 2023, at 11:22, Simone Ballarin wr= ote: >=20 > From: Gianluca Luparini >=20 > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headlin= e > states: > "The lowercase character 'l' shall not be used in a literal suffix". >=20 > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguit= y. > If the "u" suffix is used near "L", use the "U" suffix instead, for consi= stency. >=20 > The changes in this patch are mechanical. >=20 > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin > --- Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Thu Aug 03 13:54:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 13:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576394.902471 (Exim 4.92) (envelope-from ) id 1qRYmr-00084P-DT; Thu, 03 Aug 2023 13:54:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576394.902471; Thu, 03 Aug 2023 13:54:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYmr-00084I-An; Thu, 03 Aug 2023 13:54:45 +0000 Received: by outflank-mailman (input) for mailman id 576394; Thu, 03 Aug 2023 13:54:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYmq-000849-EO for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 13:54:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYmq-0007uk-5T; Thu, 03 Aug 2023 13:54:44 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRYmp-00086T-VY; Thu, 03 Aug 2023 13:54:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IOmaq4fJVMiMgUgxVmaSThvgSoBQuYx4aMyfqBdqNFg=; b=FYYufqnspyNobNmhWMMF0tnp8N 4smcUEITF382BAM9K5yHSVps1xZThXvdbQTwE5eq81NpoQEZSPEquDV/tfvnE/PFQNpFtvrgP+VBh O1Gn8XwPpNcBrTb+sWJZp31RDYV0y5Bju23VjyLRHKjAHNHw8QGdUTBCH54RhUab0CgQ=; Message-ID: <868d3bb2-0d97-4cb5-b7b8-27ac3d0181d5@xen.org> Date: Thu, 3 Aug 2023 14:54:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Content-Language: en-GB To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230802135350.745251-1-luca.fancellu@arm.com> <9320a2b7-18cd-2766-b115-300755d64932@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 14:03, Luca Fancellu wrote: > Hi Julien, Hi, >>> + >>> config GICV3 >>> bool "GICv3 driver" >>> depends on !NEW_VGIC >>> @@ -92,6 +100,11 @@ config HAS_ITS >>> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED >>> depends on GICV3 && !NEW_VGIC && !ARM_32 >>> +config VGICV2 >>> + bool "vGICv2 interface for guests" >> >> This description is a bit misleading as the vGICv2 will also be used for dom0 in the case of vGICv2. >> >>> + default y >> >> Please add a longer help. >> >>> + depends on (GICV2 || GICV3) && !NEW_VGIC >> >> In the near future, I don't expect anyone to introduce a new non-GIC of interrupt controller for Arm. But I would expect new version of the GIC. So I would drop (GICV2 || GICV3). >> >> Also when !NEW_VGIC is selected, this will make VGICV2 will be unselected. I was actually expecting the other way around given that new vGIC only offer v2 support. >> >> The rest of the changes LGTM. > > Thanks a lot for having a look on this patch, you are right the NEW_VGIC is offering only v2 support at the moment, does this changes captures your > Comments? > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 5cdba07df964..1c600b3b8d04 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -110,15 +110,19 @@ config HAS_ITS > depends on GICV3 && !NEW_VGIC && !ARM_32 > > config VGICV2 > - bool "vGICv2 interface for guests" > + bool "vGICv2 interface for domains" > default y > - depends on (GICV2 || GICV3) && !NEW_VGIC > + help > + Provides a virtualised interface for the Generic Interrupt Controller that > + can be used by Xen's domains. How about: Allow Xen to expose a Generic Interrupt Controller version 2 like to Xen domains. This can be configured at the domain creation. This option is mandatory when using GICv2. For GICv3, this allows domain to use GICv2 when the hardware supports it. If unsure say Y. > + If unsure, say Y > > config HVM > def_bool y > > config NEW_VGIC > bool "Use new VGIC implementation" > + select VGICV2 > ---help--- > > This is an alternative implementation of the ARM GIC interrupt > diff --git a/xen/arch/arm/vgic/Makefile b/xen/arch/arm/vgic/Makefile > index 806826948e20..60cbf7f2f94a 100644 > --- a/xen/arch/arm/vgic/Makefile > +++ b/xen/arch/arm/vgic/Makefile > @@ -1,5 +1,5 @@ > obj-y += vgic.o > -obj-y += vgic-v2.o > +obj-$(CONFIG_VGICV2) += vgic-v2.o > obj-y += vgic-mmio.o > -obj-y += vgic-mmio-v2.o > +obj-$(CONFIG_VGICV2) += vgic-mmio-v2.o > obj-y += vgic-init.o > > > >> >> Cheers, >> >> -- >> Julien Grall > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:00:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576398.902482 (Exim 4.92) (envelope-from ) id 1qRYsf-0001Dm-2O; Thu, 03 Aug 2023 14:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576398.902482; Thu, 03 Aug 2023 14:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYse-0001Df-VD; Thu, 03 Aug 2023 14:00:44 +0000 Received: by outflank-mailman (input) for mailman id 576398; Thu, 03 Aug 2023 14:00:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRYsd-0001DZ-W4 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:00:43 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 213ff945-3206-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 16:00:42 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691071236444697.0834525331015; Thu, 3 Aug 2023 07:00:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 213ff945-3206-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691071238; cv=none; d=zohomail.com; s=zohoarc; b=lVUosfmbp5T+CFvz0swdVInTrWLOpyyh8RsmsfQXTjDK1g6R7lckqs+RQ4nNYu5ydb0Iq1rmjajR/YgZIk2BfW46ULqISL8P9ZyGd3XhqTVWg92c9ZG0NS5W9K87GOE7uVJyJR2a4vjw3PNXey2MW+1rcR4HTrJe7pp3dVOoZZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691071238; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=6RXLCicIfGbmHJoG+x3NHNQo7vkNX5Pb+Ok3L72yLyU=; b=oC5vikqO+DO81J+oYvGFXyqq26gVkWclfXyRdm7JFGYAGNNzIhqejZB2sSpXwjMpfiT4ZX9GAhfoQ14Q57nw7/Xuiv0fUEz5kWpA+RSEBNFpU494OSZPe6eRNZ57zHG2IPy1AIwpppd7F1meHw8M/cRguqNcxtKi50XX0PB7GHo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691071238; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=6RXLCicIfGbmHJoG+x3NHNQo7vkNX5Pb+Ok3L72yLyU=; b=h4AGhm6pY65esh2zJVN1RxNLa2dEKUkobVX+ZUDWFOcPnM08vXG5uI6/dc07O34s Vae6X6qJrzKtFH6oMl3jCDixqNkemWECExpaRvbqRIbG0p65Sbe98zayGuClzeTBlFd WuzdaokNy8/mNbjJXdLTXJr9Kwy74yJDsyf9EuLc= Message-ID: Date: Thu, 3 Aug 2023 10:00:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: Stefano Stabellini Cc: Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/1/23 20:54, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Daniel P. Smith wrote: >> The existing concepts such as unbounded domain, ie. all powerful, control >> domain and hardware domain are, effectively, roles the domains provide for the >> system. Currently, these are represented with booleans within `struct domain` >> or global domid variables that are compared against. This patch begins to >> formalize these roles by replacing the `is_control` and `is_console`, along >> with expanding the check against the global `hardware_domain` with a single >> encapsulating role attribute in `struct domain`. >> >> Signed-off-by: Daniel P. Smith > > This is definitely heading in the right direction Thank you, it is good to know there is some agreement here. >> --- >> xen/arch/arm/domain_build.c | 2 ++ >> xen/arch/x86/setup.c | 2 ++ >> xen/common/domain.c | 14 +++++++++++++- >> xen/include/xen/sched.h | 16 +++++++++------- >> xen/include/xsm/dummy.h | 4 ++-- >> xen/xsm/flask/hooks.c | 12 ++++++------ >> 6 files changed, 34 insertions(+), 16 deletions(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 39b4ee03a5..51b4daefe1 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -4201,6 +4201,8 @@ void __init create_dom0(void) >> if ( IS_ERR(dom0) ) >> panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); >> >> + dom0->role |= ROLE_UNBOUNDED_DOMAIN; > > I am not a fan of "UNBOUNDED". Maybe "PRIMARY"? "PRIVILEGED"? "SUPER"? > "ROOT"? > > I also recognize I am not good at naming things so I'll stop here and > let other provide better feedback :-) In first version of hyperlaunch and in the early roles work, I was working to move toward eliminating this concept entirely. The reality is this is a model that has existed for over 20 years and there are those who accept and embrace the model. Introducing the name UNBOUNDED was to at least break the idea that the all powerful domain necessarily is the first/initial domain to run. With hyperlaunch, there are still security-based scenarios where you might want to run a DomB before starting an all privileged domain. I spent quite some time, probably more than I should have, to find a good name that expresses what this role is. Considering a comment below and a comment by Jan, I am starting to think a better way to view it is a domain that assumes all roles in the system. So your suggestions of SUPER or ROOT might be more fitting. I considered ROLE_ALL, but something about it doesn't sit right with me. With that said I welcome the yak shaving of naming to begin. ( ^_^) > Also, do we actually need unbounded given that it gets replaced with > control_domain pretty soon? Yes, because as mentioned above, this is meant to express a domain that has been assigned all roles, for which later the domain may decided to delegate the role to another domain. > I am asking because I think that at least from a safety perspective it > would be a problem to run a domain as "unbounded". In a safety system, > we wouldn't want anything to be unbounded, not even temporarily at boot. > If "unbounded" is removed before running dom0, then of course it is no > problem because actually dom0 never gets to run with "unbounded" set. I think this is were the name UNBOUNDED may have been a bad choice. The UNBOUNDED role is dom0. It is the control domain, the hardware domain, the Xenstore domain, and the crash domain (if that were to be solidified). > (I am currently thinking of solving the privilege issue by using XSM and > removing most privileges from Dom0.) I obviously would be a huge advocate of that approach. ( ^_^) >> if ( alloc_dom0_vcpu0(dom0) == NULL ) >> panic("Error creating domain 0 vcpu0\n"); >> >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >> index 2dbe9857aa..4e20edc3bf 100644 >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const module_t *image, >> if ( IS_ERR(d) ) >> panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); >> >> + d->role |= ROLE_UNBOUNDED_DOMAIN; >> + >> init_dom0_cpuid_policy(d); >> >> if ( alloc_dom0_vcpu0(d) == NULL ) >> diff --git a/xen/common/domain.c b/xen/common/domain.c >> index 8fb3c052f5..0ff1d52e3d 100644 >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) >> setup_io_bitmap(dom0); >> #endif >> >> + /* >> + * "dom0" may have been created under the unbounded role, demote it from >> + * that role, reducing it to the control domain role and any other roles it >> + * may have been given. >> + */ >> + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); >> + dom0->role |= ROLE_CONTROL_DOMAIN; > > I think we need a better definition of the three roles to understand > what this mean. Definition and as highlighted, a better name. >> rcu_unlock_domain(dom0); >> >> iommu_hwdom_init(d); >> @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, >> } >> >> /* Sort out our idea of is_control_domain(). */ >> - d->is_privileged = flags & CDF_privileged; >> + if ( flags & CDF_privileged ) >> + d->role |= ROLE_CONTROL_DOMAIN; >> + else >> + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ >> >> /* Sort out our idea of is_hardware_domain(). */ >> if ( is_initial_domain(d) || domid == hardware_domid ) >> @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, >> >> old_hwdom = hardware_domain; >> hardware_domain = d; >> + d->role |= ROLE_HARDWARE_DOMAIN; >> } >> >> TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index a9276a7bed..695f240326 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -467,8 +467,10 @@ struct domain >> #endif >> /* is node-affinity automatically computed? */ >> bool auto_node_affinity; >> - /* Is this guest fully privileged (aka dom0)? */ >> - bool is_privileged; >> +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) >> +#define ROLE_CONTROL_DOMAIN (1U<<1) >> +#define ROLE_HARDWARE_DOMAIN (1U<<2) > > This is a great step in the right direction but I think at least a short > in-code comment to explain the difference between the three Ack. >> + uint8_t role; >> /* Can this guest access the Xen console? */ >> bool is_console; >> /* Is this guest being debugged by dom0? */ >> @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); >> >> static always_inline bool is_initial_domain(const struct domain *d) >> { >> - static int init_domain_id = 0; >> - >> - return d->domain_id == init_domain_id; >> + return d->role & ROLE_UNBOUNDED_DOMAIN; >> } > > As far as I can tell this is the only functional change in this patch: > given that dom0 loses unbounded soon after boot, the "is_initial_domain" > checks will start to fail? Today, dom0 should not lose any of its roles at boot unless dom0less were to create a hardware domain. Upon reflection, I am thinking this check might want renaming to align with the rename of this role. > We have a few of them in the code and I couldn't rule out that at least > these 3 could happen at runtime: > > xen/common/sched/core.c: else if ( is_initial_domain(d) && opt_dom0_vcpus_pin ) > xen/common/sched/core.c: else if ( is_initial_domain(d) ) > xen/common/sched/arinc653.c: if ( is_initial_domain(unit->domain) ) > > Maybe they need to be changed to control_domain checks? Perhaps, I would want to study them a bit before switching them over. >> /* >> @@ -1076,7 +1076,8 @@ static always_inline bool is_hardware_domain(const struct domain *d) >> if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) >> return false; >> >> - return evaluate_nospec(d == hardware_domain); >> + return evaluate_nospec(((d->role & ROLE_HARDWARE_DOMAIN) || >> + is_initial_domain(d)) && (d == hardware_domain)); >> } >> >> /* This check is for functionality specific to a control domain */ >> @@ -1085,7 +1086,8 @@ static always_inline bool is_control_domain(const struct domain *d) >> if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) >> return false; >> >> - return evaluate_nospec(d->is_privileged); >> + return evaluate_nospec((d->role & ROLE_CONTROL_DOMAIN) || >> + is_initial_domain(d)); >> } >> >> #define VM_ASSIST(d, t) (test_bit(VMASST_TYPE_ ## t, &(d)->vm_assist)) >> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h >> index 8671af1ba4..18f1ddd127 100644 >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h >> @@ -108,7 +108,7 @@ static XSM_INLINE int cf_check xsm_set_system_active(void) >> { >> struct domain *d = current->domain; >> >> - ASSERT(d->is_privileged); >> + ASSERT(d->role & ROLE_CONTROL_DOMAIN); >> >> if ( d->domain_id != DOMID_IDLE ) >> { >> @@ -116,7 +116,7 @@ static XSM_INLINE int cf_check xsm_set_system_active(void) >> return -EPERM; >> } >> >> - d->is_privileged = false; >> + d->role &= ~ROLE_CONTROL_DOMAIN; >> >> return 0; >> } >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >> index 78225f68c1..0a31719f43 100644 >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -193,7 +193,7 @@ static int cf_check flask_domain_alloc_security(struct domain *d) >> default: >> if ( domain_sid(current->domain) == SECINITSID_XENBOOT ) >> { >> - if ( d->is_privileged ) >> + if ( d->role & ROLE_CONTROL_DOMAIN ) >> dsec->sid = SECINITSID_DOM0; >> else if ( pv_shim ) >> dsec->sid = SECINITSID_DOMU; >> @@ -213,7 +213,7 @@ static int cf_check flask_set_system_active(void) >> >> dsec = d->ssid; >> >> - ASSERT(d->is_privileged); >> + ASSERT(d->role & ROLE_CONTROL_DOMAIN); >> ASSERT(dsec->sid == SECINITSID_XENBOOT); >> ASSERT(dsec->self_sid == SECINITSID_XENBOOT); >> >> @@ -224,11 +224,11 @@ static int cf_check flask_set_system_active(void) >> } >> >> /* >> - * While is_privileged has no significant meaning under flask, set to false >> - * as is_privileged is not only used for a privilege check but also as a >> - * type of domain check, specifically if the domain is the control domain. >> + * While domain roles have no significant meaning under flask, mask out >> + * control domain role as it is not only used for a privilege check but >> + * also as a type of domain check. >> */ >> - d->is_privileged = false; >> + d->role &= ~ROLE_CONTROL_DOMAIN; >> >> dsec->self_sid = dsec->sid = SECINITSID_XEN; >> >> -- >> 2.20.1 >> From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:12:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:12:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576403.902491 (Exim 4.92) (envelope-from ) id 1qRZ4B-0002pC-7A; Thu, 03 Aug 2023 14:12:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576403.902491; Thu, 03 Aug 2023 14:12:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ4B-0002p5-4c; Thu, 03 Aug 2023 14:12:39 +0000 Received: by outflank-mailman (input) for mailman id 576403; Thu, 03 Aug 2023 14:12:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ4A-0002oj-9W for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:12:38 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca69b3f1-3207-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 16:12:35 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691071947595388.4374355217228; Thu, 3 Aug 2023 07:12:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca69b3f1-3207-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691071950; cv=none; d=zohomail.com; s=zohoarc; b=Pt6gRMM6IMzhXREFSYSHGzioHoVMqsXCGAvRsTCiwMChVaCD5YdxkOJvqIee7eOLZo7/TQMm6gFhWg6uhnYI7Qnrl7/LHW3g8Y3XDTvATlar3bMeQ3eP2/0KIyuUtbKwTjspTllT0R4FQ3nL1ORzeadsqYQ7daTN6xt+0Mhr2Ss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691071950; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=kgbWUzvjAJOai+vyRMYUHqrwL1+0ZrXPwIxIAWO83No=; b=NTZy37Ykt6EK1Eax3m09lPVLXyxQwnGWyjffNqvxwiE0dEhcrHdfTjxND1oG5khzFMMh3h9q4725IUh38zxBNpsqC4PjW4GOEM7BdWTwmhkK0zjI2k/Hgi9tnHbhXrcSFILho1Yaa13son4jkxuVlbA2K3RwXt4B5xy0tmYjJ2A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691071950; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=kgbWUzvjAJOai+vyRMYUHqrwL1+0ZrXPwIxIAWO83No=; b=Y54hJfE7KMKqqyeUzQlhB44OCuPcn4jNtftdk7gYv5SisU9pwq5GRC+jxQd0Tnjo jZmw6yjSScx+LPRz0cQMPt/3RmNaNHdOJ1ADpVUOA84bBNwZP7VQAJ0rNelsr6PN8+L 14IJUdkbT/7TmGYmuxKlj0gjOv0I+49wIj9rAwso= Message-ID: <40b73f1e-0dad-b6e8-ed21-3aaf1a35029c@apertussolutions.com> Date: Thu, 3 Aug 2023 10:12:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/2/23 03:51, Jan Beulich wrote: > On 01.08.2023 22:20, Daniel P. Smith wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) >> setup_io_bitmap(dom0); >> #endif >> >> + /* >> + * "dom0" may have been created under the unbounded role, demote it from >> + * that role, reducing it to the control domain role and any other roles it >> + * may have been given. >> + */ >> + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); > > This doesn't look to remove anything, when taking into account ... Ugh, you are correct. It was meant to be a bitwise and of dom0-role with a mask that has every bit set except ROLE_UNBOUNDED_DOMAIN and ROLE_HARDWARE_DOMAIN. But being a bonehead, I bitwise and the two roles instead of or-ing them. I agree with your comment below, which will reduce to just masking a bitwise not of ROLE_HARDWARE_DOMAIN. >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -467,8 +467,10 @@ struct domain >> #endif >> /* is node-affinity automatically computed? */ >> bool auto_node_affinity; >> - /* Is this guest fully privileged (aka dom0)? */ >> - bool is_privileged; >> +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) >> +#define ROLE_CONTROL_DOMAIN (1U<<1) >> +#define ROLE_HARDWARE_DOMAIN (1U<<2) > > ... that each of the constants has just a single bit set. Seeing the > & there I was expecting something like > > #define ROLE_UNBOUNDED_DOMAIN (ROLE_CONTROL_DOMAIN | ROLE_HARDWARE_DOMAIN) > > instead. Agree, instead of consuming one the limited number of bits for a role that represents a domain having all roles, just or all the roles together. Then I can reclaim one of the bits of the flag field. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:13:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:13:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576405.902502 (Exim 4.92) (envelope-from ) id 1qRZ4k-0003IR-HU; Thu, 03 Aug 2023 14:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576405.902502; Thu, 03 Aug 2023 14:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ4k-0003IK-Dw; Thu, 03 Aug 2023 14:13:14 +0000 Received: by outflank-mailman (input) for mailman id 576405; Thu, 03 Aug 2023 14:13:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ4i-0003I6-Ht for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:13:12 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df4d5cfe-3207-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 16:13:10 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691071984468195.7324363645455; Thu, 3 Aug 2023 07:13:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df4d5cfe-3207-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691071986; cv=none; d=zohomail.com; s=zohoarc; b=GJfbRKFRS+y/0O+Mj7Mdf8Z65xM2UpksYeqiD1E2Fz2XbSCk1HPPuIuXSf6pSJ+Znxp+FfXvm3tmx5WWmh7lMcLsFChJiyXnKJEnCISXBiR+NY5I+3LzN0IPyx3sRrbaAOWQ7kZpk2c+uG+bhwoZ//NVGedm6Bhgd5g9BirVbTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691071986; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=HXc+4giYhO4aml0XV6KxKu9+fo/2k40iM5wQljtnt8c=; b=auoX3PJFjZ0JKCPWQxrfyRoNBLeL95unHoViE6LSfeHyo113goRAvUriQwxx9gccCA4cl7JML7tgjY9xCfuUGfmUHjdSMpBSYcuxKbF82bxcGNALymr0SfudBCMsWQtNQa2LOt2E9OyXbhj8tMAYaFjNCffI9/JDPKSO6EarCHk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691071986; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=HXc+4giYhO4aml0XV6KxKu9+fo/2k40iM5wQljtnt8c=; b=ptL+HsDmz/DFX3QIijKecTmBfkdB4xWWw6fhgPOgC0IaV0AxgahWWbnc+h3pMh7u KW/NBDhbI8senF6AOIY00N69N01HeW90YMm16q2nA/RBtK8pauCwKwBqYkf5EXmMG7S La8I/pFyuRJUxSu9NekTLlzs470fsPi5A56B7GGw= Message-ID: Date: Thu, 3 Aug 2023 10:13:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 3/6] roles: add a role for xenstore domain Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-4-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/1/23 20:57, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Daniel P. Smith wrote: >> Expand the possible roles for a domain to include a role for the Xenstore >> domain. >> >> Signed-off-by: Daniel P. Smith > > Reviewed-by: Stefano Stabellini Thank you! >> --- >> xen/common/domain.c | 3 +++ >> xen/include/xen/sched.h | 3 ++- >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/xen/common/domain.c b/xen/common/domain.c >> index 0ff1d52e3d..dbf055c559 100644 >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -633,6 +633,9 @@ struct domain *domain_create(domid_t domid, >> d->role |= ROLE_HARDWARE_DOMAIN; >> } >> >> + if ( d->options & XEN_DOMCTL_CDF_xs_domain ) >> + d->role |= ROLE_XENSTORE_DOMAIN; >> + >> TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); >> >> lock_profile_register_struct(LOCKPROF_TYPE_PERDOM, d, domid); >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 695f240326..ec0f9baff6 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -470,6 +470,7 @@ struct domain >> #define ROLE_UNBOUNDED_DOMAIN (1U<<0) >> #define ROLE_CONTROL_DOMAIN (1U<<1) >> #define ROLE_HARDWARE_DOMAIN (1U<<2) >> +#define ROLE_XENSTORE_DOMAIN (1U<<3) >> uint8_t role; >> /* Can this guest access the Xen console? */ >> bool is_console; >> @@ -1165,7 +1166,7 @@ static inline bool is_vcpu_online(const struct vcpu *v) >> >> static inline bool is_xenstore_domain(const struct domain *d) >> { >> - return d->options & XEN_DOMCTL_CDF_xs_domain; >> + return d->role & ROLE_XENSTORE_DOMAIN; >> } >> >> static always_inline bool is_iommu_enabled(const struct domain *d) >> -- >> 2.20.1 >> From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:14:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:14:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576409.902512 (Exim 4.92) (envelope-from ) id 1qRZ5U-0003sM-R7; Thu, 03 Aug 2023 14:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576409.902512; Thu, 03 Aug 2023 14:14:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ5U-0003sF-Nj; Thu, 03 Aug 2023 14:14:00 +0000 Received: by outflank-mailman (input) for mailman id 576409; Thu, 03 Aug 2023 14:14:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ5U-0002oj-0j for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:14:00 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc79d45c-3207-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 16:13:58 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7728.eurprd04.prod.outlook.com (2603:10a6:102:e8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 14:13:40 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 14:13:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc79d45c-3207-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GLXTgIzBsoLcmZt7rW+wu/iPCIyUeJdy8BuJnyx8rmvH7xnlzYrwbaWnrQZbqV+hmRfd3FuJHSm7ivuUdCUyyg85KIBGR6JTT2lkClbyy5WqEeSfWfKyIlZHYsboOMcfjAqOE8f9fLoxAxusIwBwaQNdXeqeUhlgQ9cf2dRY3c/dsb1tzP0LfyxzxPfdZRrgxH3p/ZGAeLFKjWDdfPqW/aC1NXS9sPbky1QCV3zzOkbNbhf0DSIL8SeVccBokh6ER+NZcJvPYhkAscmRz0cJEPVxeyMsfzJOcuu5+xJ9XlTLF2X9BwMxSlALN3ae8dRF4JHVxZ+I3aBaOu9vh56ZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7NsEMr+SmwoWPb2iqiSjroBMiSElrK3/QVNBH7KDaf0=; b=knIDQY27A4an+8ZB8PvR+F4F9e8XPVibeJYXUKWQleIH6zBCEMJyBwVbqk6EbO+/Ict+wE9Y6YoWiFxmmDqKjwvuuXOi8ve0Zfm4eI4xGVNgzfGPyT7qF0YWf0dUdNpw4CtGD+ztY5ZKhZrZYh1Zihkp0ITMjLKnKNWd9ZWvyIVbyRq4VIDBFYNgp1VLKHP7AirwE9jWt32yYDiuvCX+0JVktOkw+KJVvtuHgWboh+mS79CEjVrrN5onGrlkkV1Fww8N5XRf1EbEhL9PX+ucYFptC+K9qkIXTfOAqtHO1l0IQTVrLhdTiAGmSl88G10Ltrp4XqLtLcRoc/debdf8dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7NsEMr+SmwoWPb2iqiSjroBMiSElrK3/QVNBH7KDaf0=; b=LeASbGVGkheh+IMXy0veaOE0hl7qmaUbImKYD5VceKVi16wvAdF8hN/4NX7aOYscCLM8byc+KvNONDOtEOaUgbZqzh76rj5yDeCP/pdjN29p7YpfuwLK0meBZ96772/MRsdT57FJbs0ZGRrsNzgkwYeFEvZCGaNN7S5StJPjWF5BWuWvg+j19PK9wmkt9RhQyPcNImQXGqtzfxqIjSNqmrHfMztqSKnEy2sjSpJou7fFt/usY1YyQve6BV5fhIwq9ZSDlrGjR1FLBMTpLgWEH4tZ62hwev7gdrAgXCe1AqyaKWcJ4gcZcFcnfLliLxcJEdVtiEvAtqx+Gk8+xnyVsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> Date: Thu, 3 Aug 2023 16:13:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross From: Jan Beulich Subject: [PATCH 0/2] libxl: build fixes for recent CPUID work Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7728:EE_ X-MS-Office365-Filtering-Correlation-Id: 148290da-a9a8-43b2-4af0-08db942bd601 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Neru8GpTiXQhTBClxggpEhDKaE87bbaTF3MDW4o+EMTEXyPyoJt0AMy/qio0HdfCaGAd6g/6AnJHOaVKfevrSLpIXO08ldxsLrAXq6GyYRwMarKeadqQuLZ8RxtMvdEH3cmBd781uokWncK1RhTTnsBDaIbGKrxX4VfbgHh+jG5XiHqvtOSpKeXbzkDHGMpnXGfk5y4zUr+RfJJ8D/CbrM2ajBXymHdraIt2keagw6lV6QzdorWTdZEFpuXkF3QvFUBLq4iJSEF2VIC0TuHhD9VomldP4crv/g5x/pARIyOUTJ2unCoF8oHWNzQ1lZSdwVE31TMt8PArchPS6YLcXM2snNuaAKsLRbnOCiwjiAX02fB6e/f4W+lAddTQUzyx0ZS+9AaE85da68r72ONqwFa07hJ4//Dccskn9RIKltZbX1STW0f2hYdcuLmthVhQMgY4SziYABGwZWjeffI2+XUXm8RVuD8F7/dMPgMmHRI/FTsfwveX3tlf6gv1tr7CVfbppyvgku6SJzA/YgEvEwBBZ2eYzGCGPgJx+ZZ6FMvYPFrPXDd106Q4pt7cOpOseZQWUA5lvRptS1Bw6+MwdPNWmZHtxPoH+vMHxVPnzVspCJKN4Q8IQ+ZaG91T+7X0s0YdAfCO/WFaDJYUKFAuBg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(39860400002)(136003)(376002)(366004)(451199021)(558084003)(36756003)(86362001)(31696002)(31686004)(54906003)(478600001)(38100700002)(2616005)(6506007)(186003)(26005)(107886003)(8676002)(8936002)(41300700001)(6512007)(6486002)(6666004)(316002)(66476007)(66556008)(5660300002)(6916009)(2906002)(4326008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTVmTTZ1aVkxdmVvNDVEMURHK0pRQnRrRDRTQ3VZaU01cDc1bDlnOC9JWGh0?= =?utf-8?B?YVVJYVlYUDZLaVhSMzVjOS9pUEEvbExnOWRxanIydXd1WU5kRytZakF0M1Ro?= =?utf-8?B?YXU4MTk5YmJsMjYzTmljTE5SSksrWGhHaVVManlTUDVpL1NJL0luU2dNWCtl?= =?utf-8?B?OHNQWjF5ZHF2Uzl4WmI1eFBMSk5Tc2VDZitMOVVlUDQ1MHpTU2N6a1FJcWd3?= =?utf-8?B?ZXBXNHFaS1RGamtoTTYyZURvbHk2THBUOE1nWGNiWDk2aGtzS0ZmekVGQ0I2?= =?utf-8?B?ek9SdGM4SjlpQkZDOEdVa2JOS3M3Z0dwMEdjSjJ2TCtZREhRSSsxQmxMUHZj?= =?utf-8?B?ZVRzbHNQR254N1hMTkZ1S2w3VzBkcEJYQUZSU29teGNBT09qWkcvUzRhRWlX?= =?utf-8?B?ZnRpTllSYjFmUkc5UjhJcVY5VEdrMjg4REk3bnY1M096REorTXBWMVNKVmt3?= =?utf-8?B?Q0xaaHI1ckcvL1JLY3pYMG9NOXBrcUloV2JnZzhHbjUrZDAySlRSUndUNE45?= =?utf-8?B?N3NiTm9FSS9vOWxTeVRTZ0tvbHAxVUh1V1p0MWlybitjUGpiTGsxM1ZLWG1x?= =?utf-8?B?b3I1UUc4VXBoL2Mrbm1jaU5mQUhuZlBRU3lHdWM4MG9KUE1WazM0NE93a3ZC?= =?utf-8?B?T290dEEyTVBLclNlRVZsNElYR1lYeTV2dlpwRnJGTXIvcktiZ2FTMWp5NWpq?= =?utf-8?B?SFNWMWtQTE5SME5Fb25EVGtRZktRNTFOWUUybjZkSzFqd0Y5elVTbEZWbTdX?= =?utf-8?B?dnZHSndOSjdaNWM3UDRMT0hPWElKQWpxbEVIQW1KYnFCTXI1MUlYK1JRUTA3?= =?utf-8?B?UmZoalp4eHV0ZTR3UDVESFhBNVE3dmEyTkxtS0NleGFRZXdocmhBS3E2bGwv?= =?utf-8?B?dVNXOTlOaXF3VlRXZG9JVWFEUHUvNlVmUWNsTXpmbCtjcUFaZUNhclNRNDIv?= =?utf-8?B?OTNDR2RReDlNQkV5b2VNSTJXRGFRclVPdkFGQ0IxMmtIQnlOUHZVNGNMcHdU?= =?utf-8?B?S2VqRmJoc0JDOHJNKzhoY0hhZ2xMV1p0Vnp4WlJDenlOd0ZGMlJ3V2pDZWxL?= =?utf-8?B?VTRTVjJqWWNBbjNacnRWWmtvK3B0ZWd2OFNEZXJMQjZyNmcxSlUydXJEUytU?= =?utf-8?B?RXZmUVN1OTcwdmx1T1lhUzU5cjFIdklBWmxnci9ZTDZ1eEwvdDk3VlBSK0VS?= =?utf-8?B?dkFRc3hpUlF5S3BtQ2NEaDZ4dVJDSVVFMFRITlMvd1VIVm1FcW9xdm94ZURq?= =?utf-8?B?NzdzZ1lxSnJwMngwOHZMNlpHYXg5WE52VzA3UEVCMjdqT05zeTZ1dFBINXNj?= =?utf-8?B?ZVZ6WE1HeC9xRHVEZFQrK0tHTmxFQ0w2aEJxS2UvcGl5Nk9MNjA2c3pXUlJ4?= =?utf-8?B?SElaSGM2dmJMT0VvREo1MTUyTlBFait5QmZDM2MyOEoyNEVHeDA5dnBQb2tv?= =?utf-8?B?aFVqRmxvUU5MTTdraVJQb1FlV25ZeWgzUzh6aWpmZzU1UkprdXJmbXlOVC9E?= =?utf-8?B?MkJLSnVBSE04M00rZ1cybzZPa1FlVFZJZ0hxQ2lwVi9HSXdYSmNKcllWcUM3?= =?utf-8?B?RXhSdmMyaTNTaXVFaGUydHU3WXYzM013VFV0QldEdHVDRGE3b0FiTVZnbUhu?= =?utf-8?B?QWwvZU5HQkk3OTI2MUZSUk1UTnpGaDRrRWRTNWpKZXZNT1JGYTdURkFJY25k?= =?utf-8?B?VmxQZjl5b252VFBhZFhaWVVpU2lrUVhFY2tKYlpQWHFTcmE3dE40UWhaT1px?= =?utf-8?B?Y3dVZXd3bUdsbkJzQ1kvQTJsSTVSNlBRRHFWZWd4KzZwMmtqZk42SnhkSE9J?= =?utf-8?B?eWJoSEltdjlhZVM2aWVOTjdSVkR5eFc2QU8wU3QzcVIzTjcwK3F5ZFhWdkFR?= =?utf-8?B?R3QxdWswVFNzRGN1blAxUXpNaXIxK01RWFVJZ2xlZlEyTVUxZ2EvdXNOVjJB?= =?utf-8?B?R1Z0ejh5dE1aUEZqd29ZTlVvRmRPR3lPOWhHeC96ZzhVMFFOdlUxWjhlMS90?= =?utf-8?B?bUJjdmZwb1o2QkxFNU13RmhzaUlaTFhjdVFFUVU0eG8wQjR4SkRFR0N0SzlR?= =?utf-8?B?TFZjN1hWWVM0Si9ETklFeUw3ZGE5a1pFODVvMHlNZWkwU2ZPTGpuNXJVdm9K?= =?utf-8?Q?HY1MW3XcONjxJvAdMrsq1cWT7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 148290da-a9a8-43b2-4af0-08db942bd601 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 14:13:39.9713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wmk45oSFtDEwRnSLO8SmAn+rpX6tbUomDENbYFGO7n8sziE4Euep0t+AStUlJkFcGhNV5t/4jUGFD5CVbgi9xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7728 1: avoid shadowing of index() 2: allow building with old gcc again Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:14:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576412.902522 (Exim 4.92) (envelope-from ) id 1qRZ6D-0004Ps-4p; Thu, 03 Aug 2023 14:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576412.902522; Thu, 03 Aug 2023 14:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ6D-0004Pj-1U; Thu, 03 Aug 2023 14:14:45 +0000 Received: by outflank-mailman (input) for mailman id 576412; Thu, 03 Aug 2023 14:14:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ6B-0004PR-TH for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:14:43 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062f.outbound.protection.outlook.com [2a01:111:f400:7eaf::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16b7cebc-3208-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 16:14:42 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7977.eurprd04.prod.outlook.com (2603:10a6:10:1ed::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Thu, 3 Aug 2023 14:14:39 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 14:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16b7cebc-3208-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwNT9JX8K3CRQToDzYxMD9EadIOu/g5BF6Bm0WuNBEdBOcNYyNt2ymIhdB5J37/pIuncLk9dfFTwNtRGakqARelboufr+l8oMtNssJSl8fjL8XJgUCX96A29WnsI+yYi5ngNlesk1MFkkVXVXa55MmbCNfDz9b5B6V7JyKlKGxnt8daWgN4vhj8Xxnvh/kYqzW2kIQdjO6hD3g/39YW0N9TN2XSSl+ELszDb69ruDzLBNDOr2h1OYOEf4nwhNBbG9I/8417vcdNoT1cPFPgouD56AQ4Iba3jZmxqwAJqZncNWr1FYSSu9JwFaJe4jsPbPQqvuw77LbmQdWIMRgXZLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obCL3PCbJvdo09qNGQHUZs/QI2sBpH+PLePc5+Lcf4A=; b=F4pOvQwExrI7HTobvqoASa+gBHzt0fnxcFxySBveCjFr+JmndqGavYVJYr8f5jVja55kEXH8ylDBzJfCrqqfntUGt1A4cwJa8MHxW43b7QvGHn7TgVqTNbi9KS4DdlWvfLaueMY2HT5kz1IYgnAc3RSdac7hPKotaGYlRAPBDo/504XHiwTaG0Mon049KcC/gW5XxcNWU1RqypC0R5oTmcphre2JfqiC2/8OlEpLZ8qKOuR8b8slps6AKFd9DPIAz3/EXm3FXZkVBQyZm5eo0tcqayg7X0SCUpr6u7OWdBZJNyN+K2JQYsnMnq9s1qG7AtpWzH7j+lbLdmpB/YMIkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obCL3PCbJvdo09qNGQHUZs/QI2sBpH+PLePc5+Lcf4A=; b=R126oDAvSMVh8KZRjeu3GFu0f3GNEcUDviUZ3zodrMhdV1/pR80ksv2aKnJlKU7fp/S6sbcdm3DqRw78EoKjjNtn2mE+LjfLH6eYRLbEFhOCcxevlMWDuUShLc5nGAt3+9u5jd3N4olwOG70WDgw4Ki76TLDxI1n9HOsF4XfOx8qdO2TtXkQr8CFdiHmnYIqpa4T5tZEh0BnKNt110gR3u4zNZ4iQnuzFLpSlvAznWjevlcMuLfb+4MwcvIG4o9w7xxAj8xNj3b9DtSktl+1yq23Unqjkj3CzaHnTX0CwHmToN/apG/RMtvr9cSop1waqyMlnrNbWVMdc0NHMtm4pw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <71b20ec7-fcc9-9c24-2cad-fca64e949e44@suse.com> Date: Thu, 3 Aug 2023 16:14:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH 1/2] libxl: avoid shadowing of index() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross References: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> In-Reply-To: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7977:EE_ X-MS-Office365-Filtering-Correlation-Id: e7015116-2dd2-4160-1756-08db942bf96d X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wQx/X7ukQMD7pOoXikMc7NEHJk217CJ2FVTlKxd0dyzde3f0B5weKcD15kWJjMtnMQNYZSnJWU6R9BfKDXRdWmx9/oPFn7HfwsbzY5tR5wojU/85aKfIgjDwN013Q16mBeyTgBmg5uw/ta24eJwCMuwk0LAOVpOj4F5kSB5ZHhU7IbCXOg3xgjJ++rR6OJL+7h5CHMfs5gWG1bXXcxY1dXLFg5jBjRtK4njrZFXf5NaNEXXPSnJqtS1IMmIIifUVaXA6fwItAB+Wl2nSsW1qM2peIuvqrTdlezq6bMH+iVTdwrXf4LG47LkMsEoBYBtXCcJD9lREXjiTE39tyOD0zPVhPFhxy69LjjYKe+qnXveOhOctqo4YqeymgkRnaoYZXEsTelTrghM1Fmrt59gpQhSjzw5LRD0jxMxQigGrwhZxfmRkSpY+SvfVLkuQ2Z7u7BMSRiWcgmFaNfX6FjsjD4GeWWRhC/VX01QqAXnPznESeNW2Wi5An1Nsl7edyBuENHUjEZQqgWK4RBaFFgxcWGTtZkcA2mWajWu4ipy5YDr6alMujla6l1dtcAY951Xm0A7l0hmBDEowJtA5Gy1ownSNXoyzFYr1ubrEeYVjgGjL/ImCUI53m7ffV2RDgSK31P6hRjrdv7PuX9HHNaLPqg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199021)(54906003)(6506007)(107886003)(26005)(478600001)(2616005)(83380400001)(6486002)(36756003)(4326008)(66946007)(186003)(38100700002)(316002)(6916009)(66556008)(41300700001)(66476007)(86362001)(31686004)(6512007)(31696002)(5660300002)(8676002)(8936002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk8yNDBheDVBYVgyNGlyVWlYKzVMTSs2TnBqSGNBa0NtektLanR4cnBDK1hr?= =?utf-8?B?YmJJZkZmQTFCdWFZTkZQdzFlaCt0bVc3QmdNczFVOHYzRldnWFB6ZWZhOGEw?= =?utf-8?B?b0tPNDkxZzIzVlZyb3RiRmZtNG9WUXB5L2N0YmlySW83bG1VSlY4ZzBTYmFU?= =?utf-8?B?dGZSN3Rnbjg0TXdkenpKVUhjbUZ5RDlxVEUxWUpjZW1nTFlpUlRQSVdKMWF6?= =?utf-8?B?Rlo1K3Q5QTNIUWxjSmxaWlBqYlVrcEN6Q2d1Nm10UHM4K0c1YndRREdyQVFp?= =?utf-8?B?TCs4c3l3QWhoaGZpc3FiQzFyRVhVU2FyUE94K0hUOWo1ZERQR2xWVk5JbDF0?= =?utf-8?B?WGFzbTI0cFBzdCtKT3BVVTlXb29ua0F1WlFmZ3ZxcllaNkp5SWN5OG5oaFdE?= =?utf-8?B?TWxESytDR3NTTVdpbWF2aDlSZS9OSXk3ckxrWG9scndnMW1hQ2xzRnZSMk1O?= =?utf-8?B?TkcwWFNrVHRnSkdDYnR2bWozYjFUWk9SWkRwU08vVE94dGIrb0FwWDdlU0Jy?= =?utf-8?B?VC9SYXFBcThNa3NFTGVSSHpVdWhUVXpKa2pjWGhScVRXYmlzQzh0YUlNSTlt?= =?utf-8?B?YjNLSkhLQStKT1FjbnhZQ2FGY1pTTHdEWVg5TVlmWEpzSjFDdzRWa3BTOXhI?= =?utf-8?B?ZkNWR1huak5pa2FvcStqdjlocEUxK0dNMFpmQmE3TmJkRHlSSnhBNDhYNFY4?= =?utf-8?B?NU5sRy9oZi8vYVdyWWpuY0ovZllIKzM5OXY5NHNQVFRqNThQUFZ0TzJHaERy?= =?utf-8?B?QVpZMVlGSDY5VHVETFJmZkI3R1NULzNNaVVEZmZnZGZlZ2FkUVVVTzd3d3Jm?= =?utf-8?B?U3BTNXBlK0l6cnJqRzdrUTYweC92bW9mQitldFVIK21uWWs3UnpLdHlEZTQx?= =?utf-8?B?TXJFZ1dnbUVYMVhDelRJQTRqVGdweTRsaXltSVZVS050aU5HUVdpVmZ5VFhj?= =?utf-8?B?NEt6dzc4Si8vdWgvWXRUQ0ZvdzMxOEIxamZGU05qL0xiOXBxa3ZnVGRtUnBF?= =?utf-8?B?TmRwWG1BOWJsSENPWmlUbm8rOTRDM3hjb2VpQ3crWUxyWVlmZFl2UStDeVk0?= =?utf-8?B?bEVMbndPbS9kcWR3YmttREg2SXJlQVMzUkpSM29HeGFDZElCeUlkZVAxK2du?= =?utf-8?B?MHlHNDNXOXpvenN1bHBRSlpVemN4b2p5d0drRlV6a2NLTjhJdERXcFpNNEl5?= =?utf-8?B?WHdrVkNDU3AyUkVXMEhEeE5XUzJGa1VCVHoyUEUvTnFWZk82WEFXMUdGcHRn?= =?utf-8?B?c2NFZFZ4V0MzbHc5Qkp2WDFSVkljRHB1M1V0WTdsdFZ1cFVEcnB5Nm82c3lh?= =?utf-8?B?RWh3bnh2Y3VETkE3ZTNwT09jV1I5MEVWcTM3MVViUmZEZkVSNHB6UGx0aFda?= =?utf-8?B?ajYvbCthaTI2NnFLcnIzZ2s3YjZlZjd5WmdBUXVhdkNpbExhTmRtZXAydkRp?= =?utf-8?B?bmNSTnp6SU1rNzhvUlY2NTdaOGZHc2Z6WEx5T20xV1ovbE1hdHdxaTB0Nldn?= =?utf-8?B?MTRRVW9VQjcrMmp4cXVvUmxsV0trOC9KbHIrNGZiRDNzbS8yVkpnOURSYjRh?= =?utf-8?B?ODllRTJPaGNxSkVsWlhqWW1GR0JJamx1Ynd4bGtXdEZMRTNaTmRwMnN4bkdM?= =?utf-8?B?bmhPVWoyVWUzSTd0S3o5NzhBOFZ5b1J3Q3RoMGlhRmhjeW9vTUlUSlpmeXhv?= =?utf-8?B?M0dEU0hZOXNPRVBtck9jbEVFdnJpMzM1U0JCYVZJNzFDVXg3MWVjRTRBU241?= =?utf-8?B?dEc0WHF6UjRvYlBWNS9NSmtlcjNSN1RMbHl1YTN3OUlONnZUN295MExJRlZQ?= =?utf-8?B?Z1pHSElMREEvQytDZTRJUW1FNkgveUM3Zzl4aFVaNzZXRDBCS0R2dVZ4RDdF?= =?utf-8?B?TUNKc3FWVnJPaXIvSFo1bTU1Z3ZQdnZ2KytlanNjYzdzTERWZ2lZSU15c2lZ?= =?utf-8?B?azE0QjRocjNhYXhSQ25MT2FtbkNweWl4bXl1clVVTDFmWnRoLytuMDBlc2xL?= =?utf-8?B?cGx6MFhoKzRRai85eHNkUWxHMllFWGsxOEQvRFo3YzdsZ2EzczVjek43Z1Fm?= =?utf-8?B?Q0ZaSHRyQTRSQ3hnSmhRUm1jK2RiMm9DaWx2MXZZbjNrbGR4UjNGNlJhaFN3?= =?utf-8?Q?5jFSnjgvE/iYiub4lE6Q4DRyr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7015116-2dd2-4160-1756-08db942bf96d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 14:14:39.3365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m7/3v/uTBdNZrag3J7Gs528LhElzmteJz76NyCFw6jpSfoTisOAso8cVYreeVzPOnOZTPDJmaV691H3QveI6dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7977 Because of -Wshadow the build otherwise fails with old enough glibc. While there also obey line length limits for msr_add(). Fixes: 6d21cedbaa34 ("libxl: add support for parsing MSR features") Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -157,7 +157,7 @@ static int cpuid_add(libxl_cpuid_policy_ return 0; } -static struct xc_msr *msr_find_match(libxl_cpuid_policy_list *pl, uint32_t index) +static struct xc_msr *msr_find_match(libxl_cpuid_policy_list *pl, uint32_t idx) { unsigned int i = 0; libxl_cpuid_policy_list policy = *pl; @@ -167,14 +167,14 @@ static struct xc_msr *msr_find_match(lib if (policy->msr != NULL) { for (i = 0; policy->msr[i].index != XC_MSR_INPUT_UNUSED; i++) { - if (policy->msr[i].index == index) { + if (policy->msr[i].index == idx) { return &policy->msr[i]; } } } policy->msr = realloc(policy->msr, sizeof(struct xc_msr) * (i + 2)); - policy->msr[i].index = index; + policy->msr[i].index = idx; memset(policy->msr[i].policy, 'x', ARRAY_SIZE(policy->msr[0].policy) - 1); policy->msr[i].policy[ARRAY_SIZE(policy->msr[0].policy) - 1] = '\0'; policy->msr[i + 1].index = XC_MSR_INPUT_UNUSED; @@ -182,10 +182,10 @@ static struct xc_msr *msr_find_match(lib return &policy->msr[i]; } -static int msr_add(libxl_cpuid_policy_list *policy, uint32_t index, unsigned int bit, - const char *val) +static int msr_add(libxl_cpuid_policy_list *policy, uint32_t idx, + unsigned int bit, const char *val) { - struct xc_msr *entry = msr_find_match(policy, index); + struct xc_msr *entry = msr_find_match(policy, idx); /* Only allow options taking a character for MSRs, no values allowed. */ if (strlen(val) != 1) From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:15:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:15:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576416.902533 (Exim 4.92) (envelope-from ) id 1qRZ6r-00052x-ID; Thu, 03 Aug 2023 14:15:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576416.902533; Thu, 03 Aug 2023 14:15:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ6r-00052q-Dk; Thu, 03 Aug 2023 14:15:25 +0000 Received: by outflank-mailman (input) for mailman id 576416; Thu, 03 Aug 2023 14:15:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZ6q-00052g-J1 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:15:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1a::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f317f22-3208-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 16:15:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7977.eurprd04.prod.outlook.com (2603:10a6:10:1ed::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Thu, 3 Aug 2023 14:15:21 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 14:15:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f317f22-3208-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYlbFVuVqu4CUqRNH4M/OO/m8/CyOQ3+xBmCk5+DVAC8W3U1U/HVoXc6UuugRdZQfScu62pv0gy56vsOOiSrztUnBrO8jZRXkfpq+UEEJOsxABCLwcU0plM8H7k+pPvSB/5NRUjCtG4KyZGiuQr/WEK0gVMZQSYTAUpi765RfgdFIab7S6iXhNfux9lJGDHmmGU7JaDPbsjhe7EQVd4XxUOmgR5pMy9LomANFWcQQhz82sbt88ICA0SscvpNygkrGT3ymBMfERSu88KDHIxMX0oJYx5bkzf8q2NaQX5jt0NgOP9DSE2jeZMHSM5SMBJgLt8MJGu2VTRDzggV3sgKcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pW0Q7b7mAbaCsN9ic44XlYuE60szaE3+3cpssf/B9Jw=; b=QTzN53d7Le6uhlStV/QGQCSzuAJU3cAjqTYctgC1IdCRJvoIKDQJDn0wC6VRY3tt4h7sVvhjaC7j+ht0KBCmbLG401/gbbkl1L3hUjnoZLcwfbs5wzGauVuWQLUi33YdixWkIhdnRjSNEUtEDoo9HzfwmZNZZe+wZcaMWNWrPiHUQrWY1PT/lY+ghPKwhrxqzTuSblz43nKskAl0n6zpsB9wab4yfcr1TZanbj1SKw1mm46KvnS8Y9Dd2j2vfykwo4t6vk3n3B/ONgsbt8NZ9ldMMF2Jj0In1VKfcaAYxLjg4gUlTOix0GgFFh02TYHoPh/ro/3KK0wBBKgaCXQ7kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pW0Q7b7mAbaCsN9ic44XlYuE60szaE3+3cpssf/B9Jw=; b=aICgwONFGMdantSZIeV5fBJDuPRAEavYjrmCVm0Syc93dawV/nJhliYZol/tfV8FkhsI1w88OzaazycSt06UVHnDzUVorDT/f0mV0QCiAEdMNChCgbwFQTRAZbVK4ARwyHHb1U+W16zSKGDidEpqMtaVxZAelkuDH5YfcENCohqYtFOqRDFFNqAFUIyPOtLlwF2zgMlHIoLxlToxm8gh9scvjZx8foIsk1WJho0YGjuQK/StWGyNxdMLLrug/G9Kv+s4CDPtWVSrU6ggU8tFp1Pusb97cOC5/hTgf3du7XAhMIgxpnngiyzaN4rM5YETwvY7MU4N4W8YL1Y0ElH2hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <550a2b3d-ed15-6035-623d-8725edb40b2d@suse.com> Date: Thu, 3 Aug 2023 16:15:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH 2/2] libxl: allow building with old gcc again Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross References: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> In-Reply-To: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0204.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7977:EE_ X-MS-Office365-Filtering-Correlation-Id: dccf5f94-90d6-4614-da5d-08db942c126f X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b53N3KypiyzVIIKvaO3W/pOoLO1+hezA1tgpkg56YQZkgxEXJOfVCAq3tOEAHjiobOM2W2iN3bYj3dxtxe85+agKDbXiXjgaOynXzaDDrer/iv91F52DJjBVcgr7kc9D4pN3OxrYlZRZIrV5CrbVb8fqVKEnNkYpCdNo4yakZ8WM7Uiz6W4dirWaLFX0UPW1aOF8wSLZ0fls0tzT7EQ+BgD7Tc6B7MOscGJhy1OI/iPnf21IQqaSBkWc5LZTdnhQjc7ZCGpZXwmfhhFCNMnhY0mJEqBRgbZr/TngfX8JzfFHke+IxGgI/7gTjkfU0gF0Zoau0DvaGFrvdIskQFNhVD6+2m49dR/TXESC0+19DN6daWWkxrgtgmKw+gPz5JZ+D0iCgwqeyrkmTmyTSRqUyNEimPXQ92p4RwAlmvmZzDDX/NdQSVv/d+olWFUduRJRPFYjs44mZr+jZA7e6dkMTMi81MERX5NxOSNnKPA/nHtlQoaINOK2DO4zt9Rw63Y9opUV0LrfTJtVnllJb2qI9NAtfJmGbh65+N5ZzkwO+wI2CqDvsKvMvrq7v6k6+JTxBdCQ+0hNtkWJhA13e4s2BGpE1DJ8Rr2DdFpH3/GdDmh3LHiM6aVigEkYk9nmUwL4D82e8McdFy/NCcc9yqvCHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(136003)(39860400002)(346002)(366004)(451199021)(54906003)(6506007)(107886003)(26005)(478600001)(2616005)(6486002)(36756003)(4326008)(66946007)(186003)(38100700002)(316002)(6916009)(66556008)(41300700001)(66476007)(86362001)(31686004)(6512007)(31696002)(5660300002)(8676002)(8936002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZNTENoL0UzMmdQMlhqOFNGTklsYTR6T2xLdTJNTlZFOFpJS2ZBa3hPYkJH?= =?utf-8?B?QnF1WEVIUGRMVVU2bEUxU3FBbjYwR2hSS1VlOHo1NzI0RXlKcjBtS0d1cEEr?= =?utf-8?B?OXl5emRObWxHWUZDVWpOZ3IwWE5mRDZDSzhwSmNBTnhUNFNYYk9nOHA0Z3J4?= =?utf-8?B?Q1BFTWJ4TnJ6bVRaYzR0dUEzelhnMnYzNm14S3lTUkQybVQ0THpnbXBuRWRJ?= =?utf-8?B?ODRUc1hFREN4ODlpd20zNEtwRmlsbWdnckhSYjJzckwzQzBZQTBrM2h6bHNY?= =?utf-8?B?V0YwU2tRTWVjdG9RQllHSmMxcC9oRk9QSDJmOGlWUGFONm04Ny9penBIeTNG?= =?utf-8?B?ZmF4K0RzNkQxTkhXSmxWeGFOc3E5SXlvNzlmQTZhUkFOY29ZZXQyb2tXQmwv?= =?utf-8?B?d0EyYkV3SHlaUERxOXVhUmlTSGREQUxtL051WlVhaTJMUzUzL0loOHdnNmls?= =?utf-8?B?UXhTSHFaWEVhOWZkZzBwZ2hpOGhyQzJnMkZOTEI5NlcyQnNaTWw2UXVVa3dX?= =?utf-8?B?TUtUaVl2aGxkWTZQR0pEQVhLdXhORDFxSFdPcDRyWHFVVGgwZEhCR2ZJWVRZ?= =?utf-8?B?MHhRZlcvZ3ZacXRJcDJNTjFzcmRGQWV0bGI4RHgxeGZYZEx6L2d6RFcxeFRt?= =?utf-8?B?c1RSVE1rNWJQWE0yMDhjdHN1eEkzV0ZWZnNiRDRYVEkydEp3L2J3L05BeXI3?= =?utf-8?B?N2QrZld6M1dPYmgrcCtKeDEvc2hCT3Y5RFNONm9nZzBhMy9DRzhMN0FjRXhG?= =?utf-8?B?SkJxdCtRYWRNVE5vNlROeHN0VlBqMHNndm5YVmJYWkhMTUpTdndIdDgwL2pn?= =?utf-8?B?VlZ4eUNjOVZydlU0TG9rTWlVZVlydExnZUtsd1c5TW5hWFlaeFJLNFdVOW8r?= =?utf-8?B?emJhY3oxckdtQVpYbFFidWxlTm5ncU13THF3Mkg1a0JueGhMbUNRVmxoOGp4?= =?utf-8?B?US96cEJTcjQvVnZ5TDhnVW5qdkxBNU9rSW9HMzNRbERPODdRRVRCa3VwNGNS?= =?utf-8?B?VWlDNmtMa0pJengvUFVGRjhNbEphU1JPSG5JZjZEN3hKS1R0YitZM1Z1S1ZK?= =?utf-8?B?RWVMWWNSRzd6cEZCelp2K2NWa1k1K1k0K2JaY1FlNG05UDNhMkFueUpra3RW?= =?utf-8?B?MGc1VFBzZW5hd0R4d09PbnVZY2FIM1R2MnBHK2JCSXBvOUl5WTBDMWZIUGlx?= =?utf-8?B?T3BWLzVsYkY5SEp1Z1pVeWVhRmZxdllEMFNobFBqZ214czVXRk90a2JYdCtG?= =?utf-8?B?VzVrVXFhODQrb09pVVV5ZHRHOWRRSEErMkJCaTgySUNsbE5tWVhpMXUzeGZJ?= =?utf-8?B?SC9FbzFsM1hzM05NTnNYV1dwdUEya1hpeXcwZDB0alRTMXVSaHI0cmVWZk5U?= =?utf-8?B?TGdRSVpVamVIMHZiTzgyUWh2eVNHKytHSEwxSUwxS0w0azg2cnA0T1BRL2FQ?= =?utf-8?B?VjFNcWtmM2dPMTkwM28rMHl1eFFVd1AzSkFnQnRkSlpsSnRkYjg4WjA5U0kw?= =?utf-8?B?RG14OGZ2cGwxYllUdEV3R0VxdGllcStMU0ZTak9DUGh1NDVrNHFkSHJ5dUF3?= =?utf-8?B?M01CZ0Q2WExBaWxhaStFWkVmdzk3ckd6aFE3SkFXaGtDL2p2RjFRWWRMRXVa?= =?utf-8?B?Z25JUkhiVXB2TzdMcGJhaldWbVE4VDBnMW1mV1NCKzBObWFYRU1pa0VaNjUz?= =?utf-8?B?UjRYbzNKVGgxYmFLWEY0eEJIeWxQMGRjWEtVdms5Zk12NDNLS25JNTJ0TVN6?= =?utf-8?B?SVp5N2d4c2FsSW0vOThaVTJrNEc2M0hUdUpBRmcyV3FvN012b2RoS1YwUWVw?= =?utf-8?B?Y21yRlNtSzZHdVhCNUZwczhmMlQ4WXpNaHhUTk0zbDVqRWlGeU9LdDZXMUJG?= =?utf-8?B?QVQ4NUg5SGlBYlJvczVaNXVSK3QvNUY5SHJsckg5S2xSVHVDSktKTUt5cEFz?= =?utf-8?B?VGh3d3RnZE5obFgzMlRPbE01VXE4ZTNaQ2REcWRkczJqYlNtMmN6T3YyY0c5?= =?utf-8?B?ZDZ5UUJYN2kwTEllM08zeGU1TlUvVTZvK080SURHQW1zWHJycWVlcHFucFpm?= =?utf-8?B?TVVEb0wrSFNXS1I5Nm9EZE9pNTl4bUprMU1OYkxMekdDYXZDZ1VUNDZVRkNI?= =?utf-8?Q?+oy5LzuqBG1jV9xrOI86K29he?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dccf5f94-90d6-4614-da5d-08db942c126f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 14:15:21.3130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EV+FjhvzJJUKVVvV8Lpra1Qe0K03d7BqNc7GINrr2iwshgW7czoNxyDasuOo6w9gm+tBQMvcp3mvE3U4hPiw3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7977 We can't use initializers of unnamed struct/union members just yet. Fixes: d638fe233cb3 ("libxl: use the cpuid feature names from cpufeatureset.h") Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -316,12 +316,16 @@ int libxl_cpuid_parse_config(libxl_cpuid uint32_t index; unsigned int reg; } msr; - }; + } u; } feature_to_policy[] = { #define CPUID_ENTRY(l, s, r) \ - { .type = FEAT_CPUID, .cpuid.leaf = l, .cpuid.subleaf = s, .cpuid.reg = r } + { .type = FEAT_CPUID, \ + .u = { .cpuid.leaf = l, .cpuid.subleaf = s, .cpuid.reg = r } \ + } #define MSR_ENTRY(i, r) \ - { .type = FEAT_MSR, .msr.index = i, .msr.reg = r } + { .type = FEAT_MSR, \ + .u = { .msr.index = i, .msr.reg = r } \ + } CPUID_ENTRY(0x00000001, NA, CPUID_REG_EDX), CPUID_ENTRY(0x00000001, NA, CPUID_REG_ECX), CPUID_ENTRY(0x80000001, NA, CPUID_REG_EDX), @@ -380,9 +384,9 @@ int libxl_cpuid_parse_config(libxl_cpuid struct cpuid_flags f; f.name = feat->name; - f.leaf = feature_to_policy[feat->bit / 32].cpuid.leaf; - f.subleaf = feature_to_policy[feat->bit / 32].cpuid.subleaf; - f.reg = feature_to_policy[feat->bit / 32].cpuid.reg; + f.leaf = feature_to_policy[feat->bit / 32].u.cpuid.leaf; + f.subleaf = feature_to_policy[feat->bit / 32].u.cpuid.subleaf; + f.reg = feature_to_policy[feat->bit / 32].u.cpuid.reg; f.bit = feat->bit % 32; f.length = 1; @@ -393,10 +397,10 @@ int libxl_cpuid_parse_config(libxl_cpuid { unsigned int bit = feat->bit % 32; - if (feature_to_policy[feat->bit / 32].msr.reg == CPUID_REG_EDX) + if (feature_to_policy[feat->bit / 32].u.msr.reg == CPUID_REG_EDX) bit += 32; - return msr_add(policy, feature_to_policy[feat->bit / 32].msr.index, + return msr_add(policy, feature_to_policy[feat->bit / 32].u.msr.index, bit, val); } } From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:19:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:19:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576424.902541 (Exim 4.92) (envelope-from ) id 1qRZAp-0005iZ-0V; Thu, 03 Aug 2023 14:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576424.902541; Thu, 03 Aug 2023 14:19:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZAo-0005iS-UC; Thu, 03 Aug 2023 14:19:30 +0000 Received: by outflank-mailman (input) for mailman id 576424; Thu, 03 Aug 2023 14:19:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZAn-0005iM-63 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:19:29 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0c78008-3208-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 16:19:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A96A81F74D; Thu, 3 Aug 2023 14:19:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 861A81333C; Thu, 3 Aug 2023 14:19:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id E+wpH263y2RKDAAAMHmgww (envelope-from ); Thu, 03 Aug 2023 14:19:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0c78008-3208-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691072366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9mpiYXcqL7Q2jJPmy9JaK5F66QXRce8GKFt9fsWIXmI=; b=PtjsniYG6rpjipjCcHnN0pg94g02xC3YqT+jEZg8PpzZsDumiU4pIMlxXNgjLkoyLfrD4I wQoPYwJxyZz228VvIeDl1Ua3gG+wEpSJLDT69MOIGsoR2+v2Vd1R4R9Vb5DG9nOwOzZ/6O rz5AvawOrzHYjZYivLeBvqXSBV4j6dk= Message-ID: Date: Thu, 3 Aug 2023 16:19:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] libxenstat/Linux: pass nul-terminated string to strpbrk() Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------PmxH1X2QsX7U6KR0Qb02J1iE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------PmxH1X2QsX7U6KR0Qb02J1iE Content-Type: multipart/mixed; boundary="------------3h6lSz6AUEXhr6RwpHKAdL2n"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu Message-ID: Subject: Re: [PATCH] libxenstat/Linux: pass nul-terminated string to strpbrk() References: In-Reply-To: --------------3h6lSz6AUEXhr6RwpHKAdL2n Content-Type: multipart/mixed; boundary="------------BxMzJ4DwjiQAxwxdlCZjm5Xb" --------------BxMzJ4DwjiQAxwxdlCZjm5Xb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDcuMjMgMTI6NDIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBXaGlsZSB3aGF0ICJ0 bXAiIHBvaW50cyB0byBoYXMgYmVlbiBjbGVhcmVkIGF0IHRoZSBlbmQgb2YgdGhlIGZpcnN0 DQo+IGl0ZXJhdGlvbiBvZiBwYXJzZU5ldERldkxpbmUoKSdzIG1haW4gbG9vcCwgdGhpcyBp cyB0b28gbGF0ZSBmb3IgdGhlDQo+IGZpcnN0IGl0ZXJhdGlvbidzIGludm9jYXRpb24gb2Yg c3RycGJyaygpIChjb3B5aW5nIHRoZSBpbnRlcmZhY2UgbmFtZSkuDQo+IFByb3Blcmx5IG51 bC10ZXJtaW5hdGUgdGhlIHN0cmluZyBhdCBwb3B1bGF0aW9uIHRpbWUgaW5zdGVhZCwgcmVt b3ZpbmcNCj4gdGhlIGxhdGUgY2xlYXJpbmcuDQo+IA0KPiBXaGlsZSB0aGVyZSBhbHNvIGVs aW1pbmF0ZSBhIGNvbmZ1c2luZyAoYmVjYXVzZSBvZiBiZWluZyB3cm9uZykgY29tbWVudDoN Cj4gQSByZWdleCBwYXJzaW5nIGVycm9yIHdvdWxkIGJlIGhhbmRsZWQgb25lIGZ1cnRoZXIg c2NvcGUgb3V0d2FyZHMuIEhlcmUNCj4gd2UncmUgZGVhbGluZyB3aXRoIGZpZWxkIDEgdnMg YW55IG9mIHRoZSBsYXRlciBmaWVsZHMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1 bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0KDQo= --------------BxMzJ4DwjiQAxwxdlCZjm5Xb Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BxMzJ4DwjiQAxwxdlCZjm5Xb-- --------------3h6lSz6AUEXhr6RwpHKAdL2n-- --------------PmxH1X2QsX7U6KR0Qb02J1iE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTLt20FAwAAAAAACgkQsN6d1ii/Ey9I Swf/RZ0OgpakolII39liPJAv/DYr57bxsOD7LKKu9NjHFF5RsNdGNHVFEQ1pwq32y5LQNI7Do4+1 YX2L8/Y4PG+EVQsT4U823a89WiX8sCNACVVekmR1Gd5+gebfF7SbecB9vl6aI+TPYgT+/5ztupIW CQOJ69sU4cWxoQhQwohGPZGVAU4jtKdSNlFJpiD9nuuXO3O5X41VwQwuqMm4pn84xW95RVhy8bbU UMxUQ0963pYTafM2sZQOKX4OdwK74ChcBYaAIOin1StAyBMVBkWbZAUZOMBmJQJVyL/EMwLElmX+ Y6tZw2/N+0AN8Uxtm9Ya6lS3Bn4eBiPbhqbNsyAEgQ== =K7jw -----END PGP SIGNATURE----- --------------PmxH1X2QsX7U6KR0Qb02J1iE-- From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:22:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576427.902552 (Exim 4.92) (envelope-from ) id 1qRZDK-00078x-Dn; Thu, 03 Aug 2023 14:22:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576427.902552; Thu, 03 Aug 2023 14:22:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZDK-00078q-At; Thu, 03 Aug 2023 14:22:06 +0000 Received: by outflank-mailman (input) for mailman id 576427; Thu, 03 Aug 2023 14:22:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZDI-00078k-Vp for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:22:04 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e0d5c87-3209-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 16:22:03 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 32DA14EE0737; Thu, 3 Aug 2023 16:22:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e0d5c87-3209-11ee-b268-6b7b168915f2 MIME-Version: 1.0 Date: Thu, 03 Aug 2023 16:22:03 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn?= =?UTF-8?Q?=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 11:01, Jan Beulich wrote: > On 03.08.2023 04:13, Stefano Stabellini wrote: >> On Wed, 2 Aug 2023, Nicola Vetrini wrote: >>> @@ -1169,8 +1170,6 @@ static void cf_check >>> irq_guest_eoi_timer_fn(void *data) >>> >>> switch ( action->ack_type ) >>> { >>> - cpumask_t *cpu_eoi_map; >> >> It is only used by case ACKTYPE_EOI so it can be moved there (with a >> new >> block): >> >> >> case ACKTYPE_EOI: >> { >> cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); >> cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); >> spin_unlock_irq(&desc->lock); >> on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); >> return; >> } >> } > > This pattern (two closing braces at the same level) is why switch scope > variable declarations were introduced (at least as far as introductions > by me go). If switch scope variables aren't okay (which I continue to > consider questionable), then this stylistic aspect needs sorting first > (if everyone else thinks the above style is okay - with the missing > blank line inserted -, then so be it). > > Jan Actually, they can be deviated because they don't result in wrong code being generated. This, modulo the review comments received, is what most of the code would look like if they weren't, with the biggest pain point being that in many cases the choice is either the pattern with blocks for certain clauses or moving them in the enclosing scope, which may be several hundred lines above. If there's agreement on deviating them, I can drop the patches dealing with switches and do a v2 with just the other modifications. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:33:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:33:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576433.902561 (Exim 4.92) (envelope-from ) id 1qRZNu-0000Kh-CZ; Thu, 03 Aug 2023 14:33:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576433.902561; Thu, 03 Aug 2023 14:33:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZNu-0000Ka-9Y; Thu, 03 Aug 2023 14:33:02 +0000 Received: by outflank-mailman (input) for mailman id 576433; Thu, 03 Aug 2023 14:33:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZNs-0000KR-VT for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:33:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4ff73b6-320a-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 16:32:59 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3AE91218F2; Thu, 3 Aug 2023 14:32:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0867D1333C; Thu, 3 Aug 2023 14:32:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lVYJOJq6y2RBEwAAMHmgww (envelope-from ); Thu, 03 Aug 2023 14:32:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4ff73b6-320a-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691073179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bXPJxjEovYG3jMTipgyUB6iBPTKA9WkxlkLusXF5wew=; b=pdF9E/CUjg4zwoPIJKP7lmm9R2mkY61mEcebQwi2f8/Sx3Tp524nDhabawfqF3u/WSuEyH B6CJ6ENdoEs25k4VH2XeOUXOdvA1dCMYgMYsaYm03sKiHvw8yrAUYRwE1x2d9uhPGWIfC7 no/yfQ6aQ0dGyRmTItG8+jUTjIRXPas= Message-ID: <90f011cd-5c85-0480-2e47-be6f229800f6@suse.com> Date: Thu, 3 Aug 2023 16:32:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 0/2] libxl: build fixes for recent CPUID work Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> From: Juergen Gross In-Reply-To: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Lglzt0XgzXqqI36w0tBsigth" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Lglzt0XgzXqqI36w0tBsigth Content-Type: multipart/mixed; boundary="------------lsSYJsxx6fc0Z7StpvowAp7L"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <90f011cd-5c85-0480-2e47-be6f229800f6@suse.com> Subject: Re: [PATCH 0/2] libxl: build fixes for recent CPUID work References: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> In-Reply-To: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> --------------lsSYJsxx6fc0Z7StpvowAp7L Content-Type: multipart/mixed; boundary="------------aHvNczKhbVNWJLB0y1PCCugf" --------------aHvNczKhbVNWJLB0y1PCCugf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjMgMTY6MTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiAxOiBhdm9pZCBzaGFk b3dpbmcgb2YgaW5kZXgoKQ0KPiAyOiBhbGxvdyBidWlsZGluZyB3aXRoIG9sZCBnY2MgYWdh aW4NCj4gDQo+IEphbg0KDQpGb3IgdGhlIHNlcmllczoNCg0KUmV2aWV3ZWQtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpKdWVyZ2VuDQo= --------------aHvNczKhbVNWJLB0y1PCCugf Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------aHvNczKhbVNWJLB0y1PCCugf-- --------------lsSYJsxx6fc0Z7StpvowAp7L-- --------------Lglzt0XgzXqqI36w0tBsigth Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTLupoFAwAAAAAACgkQsN6d1ii/Ey+Q GAf/ZW0m+eZI0kPDSBFcrQ3TZ8YXge88+wNQhflYrZE+eaIiyPsqPWRGXToHt0SgiqfST0FEfrex iZUzekwtV+7eA70Wy8QPDtZeXl7fd7DKIDNvtaW9VsoogIkwGAmhoCorb/7dSocWf75NooQzgWz3 TNxtT3Tq33prZqXoPdrvCQelSLiUOdNtMbnhIC8l2GhBJw3MsygWqxKKpsWvViDMOKuWIgKjjc7I vOUIbKKTMGm06mfwJ7W/pWcERC3Z4iNZL+bhy5cJ+Lu5xG1cV9OGMSDx6XapKFFdjWZ1d19LUZcc TVM+M/AJSIgYdlqcnHrMKEPfAOMFnVsQS17c5XsFgA== =tpkv -----END PGP SIGNATURE----- --------------Lglzt0XgzXqqI36w0tBsigth-- From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:41:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:41:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576438.902572 (Exim 4.92) (envelope-from ) id 1qRZVb-0001zC-AK; Thu, 03 Aug 2023 14:40:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576438.902572; Thu, 03 Aug 2023 14:40:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZVb-0001z5-67; Thu, 03 Aug 2023 14:40:59 +0000 Received: by outflank-mailman (input) for mailman id 576438; Thu, 03 Aug 2023 14:40:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZVa-0001yz-Bl for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:40:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id c09ac3a8-320b-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 16:40:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4861113E; Thu, 3 Aug 2023 07:41:37 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E56AF3F5A1; Thu, 3 Aug 2023 07:40:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c09ac3a8-320b-11ee-8613-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional Date: Thu, 3 Aug 2023 15:40:35 +0100 Message-Id: <20230803144035.4071610-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that compiles the Generic Interrupt Controller v2 emulation for domains, it is required only when using GICv2 driver, otherwise using the GICv3 driver it is optional and can be deselected if the user doesn't want to offer the v2 emulation to domains or maybe its GICv3 hardware can't offer the GICv2 compatible mode. Signed-off-by: Luca Fancellu --- Changes from RFC: - removed dependency on (GICV2 || GICV3) && !NEW_VGIC from VGICV2 symbol, add help for that following Julien's suggestion and changed "guests" for "domains" in its prompt. Now NEW_VGIC selects GICV2 because it provides only v2 emulation, changed the vgic/Makefile accordingly. Reworded the commit message. --- xen/arch/arm/Kconfig | 19 +++++++++++++++++++ xen/arch/arm/Makefile | 4 ++-- xen/arch/arm/domain_build.c | 4 ++++ xen/arch/arm/gic-v3.c | 4 ++++ xen/arch/arm/vgic.c | 2 ++ xen/arch/arm/vgic/Makefile | 4 ++-- 6 files changed, 33 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index fd57a82dd284..03ec1247ad4c 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -78,6 +78,14 @@ config ARM_EFI UEFI firmware. A UEFI stub is provided to allow Xen to be booted as an EFI application. +config GICV2 + bool "GICv2 driver" + default y + select VGICV2 + help + Driver for the ARM Generic Interrupt Controller v2. + If unsure, say Y + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC @@ -92,11 +100,22 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config VGICV2 + bool "vGICv2 interface for domains" + default y + help + Allow Xen to expose a Generic Interrupt Controller version 2 like to Xen + domains. This can be configured at the domain creation. + This option is mandatory when using GICv2. + For GICv3, this allows domain to use GICv2 when the hardware supports it. + If unsure say Y. + config HVM def_bool y config NEW_VGIC bool "Use new VGIC implementation" + select GICV2 ---help--- This is an alternative implementation of the ARM GIC interrupt diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 7bf07e992046..81c31c36fc3d 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -22,7 +22,7 @@ obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += efi/ obj-y += gic.o -obj-y += gic-v2.o +obj-$(CONFIG_GICV2) += gic-v2.o obj-$(CONFIG_GICV3) += gic-v3.o obj-$(CONFIG_HAS_ITS) += gic-v3-its.o obj-$(CONFIG_HAS_ITS) += gic-v3-lpi.o @@ -57,7 +57,7 @@ obj-$(CONFIG_NEW_VGIC) += vgic/ ifneq ($(CONFIG_NEW_VGIC),y) obj-y += gic-vgic.o obj-y += vgic.o -obj-y += vgic-v2.o +obj-$(CONFIG_VGICV2) += vgic-v2.o obj-$(CONFIG_GICV3) += vgic-v3.o obj-$(CONFIG_HAS_ITS) += vgic-v3-its.o endif diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 39b4ee03a505..b2b609eb0c2d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2775,6 +2775,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, return res; } +#ifdef CONFIG_VGICV2 static int __init make_gicv2_domU_node(struct kernel_info *kinfo) { void *fdt = kinfo->fdt; @@ -2826,6 +2827,7 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo) return res; } +#endif #ifdef CONFIG_GICV3 static int __init make_gicv3_domU_node(struct kernel_info *kinfo) @@ -2901,8 +2903,10 @@ static int __init make_gic_domU_node(struct kernel_info *kinfo) case GIC_V3: return make_gicv3_domU_node(kinfo); #endif +#ifdef CONFIG_VGICV2 case GIC_V2: return make_gicv2_domU_node(kinfo); +#endif default: panic("Unsupported GIC version\n"); } diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 95e4f020febe..d18a3317ccc4 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1334,6 +1334,7 @@ static paddr_t __initdata dbase = INVALID_PADDR; static paddr_t __initdata vbase = INVALID_PADDR, vsize = 0; static paddr_t __initdata cbase = INVALID_PADDR, csize = 0; +#ifdef CONFIG_VGICV2 /* If the GICv3 supports GICv2, initialize it */ static void __init gicv3_init_v2(void) { @@ -1359,6 +1360,9 @@ static void __init gicv3_init_v2(void) vgic_v2_setup_hw(dbase, cbase, csize, vbase, 0); } +#else +static inline void gicv3_init_v2(void) { } +#endif static void __init gicv3_ioremap_distributor(paddr_t dist_paddr) { diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 97d6f6106638..86fa8bc7e894 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -95,10 +95,12 @@ int domain_vgic_register(struct domain *d, int *mmio_count) return -ENODEV; break; #endif +#ifdef CONFIG_VGICV2 case GIC_V2: if ( vgic_v2_init(d, mmio_count) ) return -ENODEV; break; +#endif default: printk(XENLOG_G_ERR "d%d: Unknown vGIC version %u\n", d->domain_id, d->arch.vgic.version); diff --git a/xen/arch/arm/vgic/Makefile b/xen/arch/arm/vgic/Makefile index 806826948e20..60cbf7f2f94a 100644 --- a/xen/arch/arm/vgic/Makefile +++ b/xen/arch/arm/vgic/Makefile @@ -1,5 +1,5 @@ obj-y += vgic.o -obj-y += vgic-v2.o +obj-$(CONFIG_VGICV2) += vgic-v2.o obj-y += vgic-mmio.o -obj-y += vgic-mmio-v2.o +obj-$(CONFIG_VGICV2) += vgic-mmio-v2.o obj-y += vgic-init.o -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:41:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:41:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576441.902582 (Exim 4.92) (envelope-from ) id 1qRZW9-0002TS-I7; Thu, 03 Aug 2023 14:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576441.902582; Thu, 03 Aug 2023 14:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZW9-0002TL-EL; Thu, 03 Aug 2023 14:41:33 +0000 Received: by outflank-mailman (input) for mailman id 576441; Thu, 03 Aug 2023 14:41:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZW8-0002T7-1d; Thu, 03 Aug 2023 14:41:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZW7-0000XK-UW; Thu, 03 Aug 2023 14:41:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZW7-0002e0-K3; Thu, 03 Aug 2023 14:41:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRZW7-00052S-Ji; Thu, 03 Aug 2023 14:41:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kEN7E0A0R9BectnqzN5zkKubAURTbeXuq6ryJY1d0rQ=; b=mslqW90c6TnfQwiCpOq+a7Iiqy GpEpLHFZVPWriLPrJPoug4ok+KdjMvj8Zerdf3yCjw0jE7u8/BIp9Zli9eICCwMkBSf1zEQ5s3oJp 4peSYfgfhtlDBK/Ict9uLtC120HF9z+5PeuKZRz93xcy+3l2cMNN81Hg2sbLHQhy1smA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182163: all pass - PUSHED X-Osstest-Versions-This: ovmf=7672d1cca58228b0cb7f099e8863aa3a44ae45db X-Osstest-Versions-That: ovmf=fa789cc68a85a5781c18c64b9112c779750b2125 From: osstest service owner Date: Thu, 03 Aug 2023 14:41:31 +0000 flight 182163 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182163/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7672d1cca58228b0cb7f099e8863aa3a44ae45db baseline version: ovmf fa789cc68a85a5781c18c64b9112c779750b2125 Last test of basis 182121 2023-08-02 15:40:44 Z 0 days Testing same since 182163 2023-08-03 12:42:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dandan Bi jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fa789cc68a..7672d1cca5 7672d1cca58228b0cb7f099e8863aa3a44ae45db -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:50:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:50:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576449.902591 (Exim 4.92) (envelope-from ) id 1qRZeF-0003CM-C3; Thu, 03 Aug 2023 14:49:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576449.902591; Thu, 03 Aug 2023 14:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZeF-0003CF-9M; Thu, 03 Aug 2023 14:49:55 +0000 Received: by outflank-mailman (input) for mailman id 576449; Thu, 03 Aug 2023 14:49:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZdZ-0003BH-D6 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:49:13 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8e255c9-320c-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 16:49:12 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fe07f0636bso1845244e87.1 for ; Thu, 03 Aug 2023 07:49:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8e255c9-320c-11ee-b268-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691074151; x=1691678951; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=LtTQGZNo5YSjoPnpB3y/JCSf673ZWqc5kxtsocf7clY=; b=EdBWOU/8ZnyKuo8MAcOfcoO/f35LQ2pcQfn87HkvsSbt+A6X2kPFV5gguIZla4W9CB 6r6AUF5fdojgppa5aN2vRBPSte6rxfPsmDR2dzf7kOHhhjeD6xiZtgCZ/Sv0cyICFddu uEcklozGVKGVqg9Suf3dL4JsqPis0k82+TboA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691074151; x=1691678951; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LtTQGZNo5YSjoPnpB3y/JCSf673ZWqc5kxtsocf7clY=; b=OYENOSShAYbWZagWR4xubkGJ0JvlqTjid+Hs9t7NGRnYjvvW79D4sCDUluKedmqpSB msCDyYv/DIwaAFH12Wn5bLvLCp/eA4hZ3cAUeLsVF9BQS1RqaPj5DQXvw76DXBsNjyVh cASExxiCx4AnKV7PxPZVlX1MBJFbB1tr9oQ9ML41fFEZdXbFqNEM7BWY36bKGl1fxNMJ BjZ9QrCBRZXNC3AmUN32ocMsvYZDbusmQPdvZHUFTS34J958RNeAQkfqv1WaPw4po115 /EMNKAcxG/KRmL1nEWYruUA3NqNEQIC/6dB9kjcp29OhRuj2P7Tz7H5Ava1LuiplKz4K rhMQ== X-Gm-Message-State: ABy/qLZo6XRlIMFN0+hqSnYsdVNg610SL7qsIC9B/R83BRwacI+rfEiT HuCG4lkEcY2O+XQEbasLnP4AkQDP1I1f6kudWttvVqHzeSoKnPvMnxwyRIFy9Gf62A== X-Google-Smtp-Source: APBJJlEz825szI+9GBb01xYOoTAD2buEEi9Y2nDZmnt6/Id3lSKe/rHLLYg7Q+b+DnaKtCWKxd8hUU26FA7vTWAFm60= X-Received: by 2002:a19:8c5c:0:b0:4fb:cabd:2a66 with SMTP id i28-20020a198c5c000000b004fbcabd2a66mr7113632lfj.21.1691074151428; Thu, 03 Aug 2023 07:49:11 -0700 (PDT) MIME-Version: 1.0 From: Kelly Choi Date: Thu, 3 Aug 2023 15:48:36 +0100 Message-ID: Subject: Call for agenda items for 03/08/23 Community Call @ 1500 UTC To: undisclosed-recipients:; Content-Type: multipart/alternative; boundary="00000000000015cdb4060205e2d7" Bcc: xen-devel@lists.xenproject.org --00000000000015cdb4060205e2d7 Content-Type: text/plain; charset="UTF-8" Hi all, The proposed agenda is in this link and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document. Note the following administrative conventions for the call: * Unless, agreed in the previous meeting otherwise, the call is on the 1st Thursday of each month at 1600 British Time (either GMT or BST) * I usually send out a meeting reminder a few days before with a provisional agenda * To allow time to switch between meetings, we'll plan on starting the agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate time to sort out technical difficulties &c * If you want to be CC'ed please add or remove yourself from the sign-up-sheet at https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ *George is on PTO this week, so I will be hosting this call with the help from the community. == Dial-in Information == ## Meeting time 16:00 - 17:00 British time Further International meeting times: https://www.timeanddate.com/worldclock/meetingdetails.html?year=2023&month=5&day=4&hour=15&min=0&sec=0&p1=1234&p2=37&p3=224&p4=179 ## Dial in details Web: https://meet.jit.si/XenProjectCommunityCall Dial-in info and pin can be found here: https://meet.jit.si/static/dialInInfo.html?room=XenProjectCommunityCall Many thanks, Kelly Choi Open Source Community Manager, XenServer Cloud Software Group --00000000000015cdb4060205e2d7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi all,

The proposed agenda is in this link a= nd you can edit to add items.=C2=A0 Alternatively, you can reply to this ma= il directly.

Agenda items appreciated a few days before the call:= please put your name besides items if you edit the document.

Not= e the following administrative conventions for the call:
* Unless, agree= d in the previous meeting otherwise, the call is on the 1st Thursday of eac= h month at 1600 British Time (either GMT or BST)
* I usually send out a = meeting reminder a few days before with a provisional agenda

* To= allow time to switch between meetings, we'll plan on starting the agen= da at 16:05 sharp.=C2=A0 Aim to join by 16:03 if possible to allocate time = to sort out technical difficulties &c

* If you want to be CC'= ed please add or remove yourself from the sign-up-sheet at=C2=A0https://cry= ptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

*George i= s on PTO this week, so I will be hosting this call with the help from the c= ommunity.=C2=A0

=3D=3D Dial-in Information =3D=3D
## Meeting time<= br>16:00 - 17:00 British time
Further International meeting times:=C2=A0= https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2= 023&month=3D5&day=3D4&hour=3D15&min=3D0&sec=3D0&p1= =3D1234&p2=3D37&p3=3D224&p4=3D179


## Dial in = details
Web:=C2=A0https://meet.jit.si/XenProjectCommunityCall

Dial-in info an= d pin can be found here:

https://meet.jit.si/static/di= alInInfo.html?room=3DXenProjectCommunityCall

Many thanks,
Kelly Choi

Open Source Community Manager, XenServer
=
Cloud Software Group
--00000000000015cdb4060205e2d7-- From xen-devel-bounces@lists.xenproject.org Thu Aug 03 14:55:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 14:55:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576454.902601 (Exim 4.92) (envelope-from ) id 1qRZj9-0004eI-Ui; Thu, 03 Aug 2023 14:54:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576454.902601; Thu, 03 Aug 2023 14:54:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZj9-0004eB-RL; Thu, 03 Aug 2023 14:54:59 +0000 Received: by outflank-mailman (input) for mailman id 576454; Thu, 03 Aug 2023 14:54:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZj8-0004ca-35 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 14:54:58 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0623.outbound.protection.outlook.com [2a01:111:f400:fe02::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b35c4832-320d-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 16:54:52 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8533.eurprd04.prod.outlook.com (2603:10a6:10:2d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 14:54:50 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 14:54:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b35c4832-320d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LBE6Ojih0w7RL0+3LZ3AXb1RnbSz5/tVm3LTSZ6/axMXXw6nVe3YDlEsFrNrqyOdpJje/fUolfaY7csnJ3zUGkVhwN2BCA22GSNFxkMscKPPGSQ6967FhD59gYxfoJ+A0lYnPr9rd3BNsl3cCZM2pttDj8w8HofiWOqHZnNfNQXpprR8QXtl9kOyamx6PtcsBSY9ojJxe9YwI3PlafOlB+ExJKrmSQZGsuTsV6LAjTIhb6yuON0W7u6tCSgqyZswXwJ9gOk8VpDsvMcZ1vE4+TYHDRhA50euv6C/7ROaFotnZEvXAHyGLJL5Vt4MtrYxqehpz2KicZr42qlcAM/AhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L7bkNJqp3St7fRuY7Bj4G78GKIHC1TqIMBw5kretX/U=; b=BeOwfBRfXGSW0R0klIwMNBg8LJBnr6ddjq7ugjsbh2LCXe3VE8oYEX9cBAVUIvQAkPzK+dyWIaGxA86Rmr7xmrAeVWRgMUQxwveo2Fv6FwoRULLS09PD/8E0EetdJb7zwB/SGQWUX6iA7MO9MF7/Ec6lp2UBfZhBqT8Y6txvuW0QDP7g4SQCdAh0tSEEFt/7WnOFaRmx4RF1C10clL+cJqkmEPiAo2+OmNEiMpehopdxo9ItnZ8+Ct57wEx9TW/qiufrfYeTaR6sPmHhn+rvulXEePRBwbdV2w4cfFQOOtdgxQ8uipHvHk+TV5XM1Kjgg6iEcFq2QJ0ERG7ABk/0Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L7bkNJqp3St7fRuY7Bj4G78GKIHC1TqIMBw5kretX/U=; b=OBLoa30Y+GUcvC8zfqs8A+PG58GEbILFdpoIjoPfmrwH2NVehedOEMRJ50OlsO8RHhdEGDwLX7fPoYV0+MPdahW0x3TvQhjhG4Rqw0s7zTP+yJLsMFVQGi54ZWr5jMgL6ITzzGZ9D/j/AshnlG0sXSdnOmbcg8APpDaE2QnLGhomsj9Bqyj4Msgbl187CmidHId1E80TPecrqG5uk8EloVMVgkDmL0yb8BFOeqIrnzH2KrvixlXWQi38FBn4sIe0l/bJoyyYUBEjq1IjSVuFbQBlxs78NmlsugPFOYUKXe8jeDnBLTGVok7glSoHdF0xEvHrUtQcVpQUTCIwYCUCFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7bbe2f11-981b-5e0f-8bf4-b8d0b4a2ccc9@suse.com> Date: Thu, 3 Aug 2023 16:54:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: Call for agenda items for 03/08/23 Community Call @ 1500 UTC Content-Language: en-US To: Kelly Choi References: Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8533:EE_ X-MS-Office365-Filtering-Correlation-Id: 56e49c69-8539-40b8-ba50-08db94319698 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XCeBqCfZGO1sZxo6utfnBdEMi1jqov6z6I4X0kOwn7WgjNNH0LCw1T4DD/hnmOuq7tD2MMXwW6Qppdtitce7HhBg0Ya+QWkxN43ZfZocQBjBLzWyd+coquiKnGYssX7R50g3OWVExyv2CQc9E+xHg+delXB7KkG6DmI3Oyr58hAJ8cP8a8R9a7aU7bpUkmaZMnVT1/fwlicL0pKx/7gNZyJ3VFtxsGIrJyA60PiJNezZkfOQkxQHXM8Y0re+ILUxoXWRfsQfMM+6QBPwv+kjtkLzyM1jlxvnAknnntCkpoQ3yvP7gGvz70pBC1NbOE+vUy32FtUnDyeVYIAPlrzaVG6WQxmu6Uwj+r72sAkhoB3ja2Cf0psKTJ0uzMLi6xiGZrkLGZWK+BJWhzzx8U3QLTVMDgK1SpaicClO3+CtX4cmnw5yiWRXKN2odfCRCfA0bLzZ54n0f4uNzZFa/+lVM0iqFphNRNjtgXqH2B2vSgZAxLx4zX5QDgWFPrD+Y1NshCN/SFmHqEdsv7uIR2zZT8PJSnyTclA7ud8wGvDf7ZdY8AC2e0CpjSpSBCz7wthDLtGRN6f7rF58W5czlEObDgfRr4NF+1jkshOqQ5hbZec4ObJUJgu4hncwlI2UX/StcvR05pM7sGJLCbtQbD+qpXZpf/QFEYbqDeZ9dYZr8yg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199021)(2906002)(4744005)(2616005)(86362001)(31696002)(38100700002)(36756003)(41300700001)(31686004)(6486002)(6512007)(966005)(66476007)(316002)(6916009)(4326008)(66946007)(66556008)(26005)(6506007)(53546011)(5660300002)(478600001)(186003)(8936002)(8676002)(221023011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTVmc2Y5Vmo5RFA3MkRHdFlFS3o2Tm9weHNSMFZ1cUVYeTRNZ1hPZmFYWmFW?= =?utf-8?B?emtjODFiOUwrY2JkK1c3ZnJxcVdFNnFzSUFaV1BUaFlCdzZCUlFUTkdVVzFk?= =?utf-8?B?MnJhUUkwOVUxelg4WmdEVkpvdXAxcDFKeXlmTjlXRlpjV1VkcGxaLzg0eWFy?= =?utf-8?B?WHZrdzhMUFZxM295ZUsrOGpaUUZCajQ4QlJET29wakx2UXJ4bzhjYllqdEUy?= =?utf-8?B?Zk5UR3FmNGJrdTE4RzdGZHQzNUlsUjhmN3AxeWE4WjM5QTFHbkczNWE2QTc4?= =?utf-8?B?T3pRRFV3R21TWHBqQVovczN0d3hPRDJWYzJVUUlaQlZkVVFWam5tUS9wYk1U?= =?utf-8?B?NTBGNHlWcGxrQm9jMjV2T0R6WmZSd3ZsSW41cFFhUGR2dmdON3ZpZUlnbi84?= =?utf-8?B?OHBndGFZaEhSc2V1ZVNuS3c5elBMMHFIZllKY0JxZCt1R2R2QWVzaHBDOTgr?= =?utf-8?B?U0pIbWpac1J5bWdZQ2dHMWhoZllXeEdvbzFQRG04ZTlyR3RxVFRnTDdPaGRP?= =?utf-8?B?Mnhyb1QzN3FubXhrc21haGtma3k0czFzS0Q1MFNEcEpuT2NUSlozN1lpTzMv?= =?utf-8?B?M0RRSytPL3hQUmNFelJZRGltaHVVclFPaU02VEJXQkZySWsxb084SGU4bytp?= =?utf-8?B?QVhkZmxvRjNLTVpHUjI0WnJwTU1kLzlzdUszWFR1cHJWczNHZm9xb1pEZENx?= =?utf-8?B?Uk9ZOUkyNmhyT1Ewcjl5N0JncnBhU29hRXdybGtXTGg5RXZCVkxOQkVxTWZ0?= =?utf-8?B?Sm1ZQjc3WEh1UnI4SjZ6bFBuU1VZK01DU0hiOHp2bHZxK3Z0ZHlCVVM3UWFV?= =?utf-8?B?bEtLTDN5bDFoNWM5aWhxMmhtYnBmN3c5QXNENmdiTDNkUXFkYlZCbDg2UlRh?= =?utf-8?B?WnVTSzRJbHY2V2NCTVEvSHdiQ3NiSTNRZ3Z2enRQcmxSeFBKSERvd3hIVzRC?= =?utf-8?B?RFhxdVF0enoydThpNE1OK1ZDVTRwNTV2N2VpT1Bxd2VXWHdCQkhKYjRpY0pa?= =?utf-8?B?dmZ2cUxVUW1IRHE1UjBxSzhWUzBRTThtRUxHc2tUa3ZTK1g2K21vUTlXLzYy?= =?utf-8?B?bGNEU01GUDU1Tm1XVTF6WFJGVE5xcG9UVWtScTIzVkRBNW9PRXovL1J4Rzdj?= =?utf-8?B?YVg3Q0kwWHpKV3hwQ01oOU1tdVp6S0lQNmwyODg3S3hUM01PMVZva09WeFBH?= =?utf-8?B?UmF4b3VKckt5bHh1cFk0emdvd3JOVzhHL3FIakYyS1kxV1Z6YVg0ditQbW1H?= =?utf-8?B?amRyd09paTNxSnZOaHMwYVh0dkpUOWZrdmRiSXhPTU9KdE95YkpkSm5ZbGdn?= =?utf-8?B?VHo5TVRDeWppWEI0NjVZY2EwYWlsclJHTjdDeENabEFVY1pWamZaalpoWkk4?= =?utf-8?B?Snc5NTFjMXFlTWU5U2J2aUhsaGJERzZwb1VibGYxMG12S0Vtcks5YzEveERQ?= =?utf-8?B?QWxLa0sxc3o5UHlkOEVGOWhtR2EzRG9Ud3poRFd4M0p0M2dEMllYR1BIWmNB?= =?utf-8?B?Y3dyZGRIWXRHWlU4T3B4RGNNTUkwM0pvZUhpZ0pPUU05YnVZdWloUGk1NU1Z?= =?utf-8?B?NjVqbTJrcEkyNTBZS2lHOCtJSHBIQTJ3dFlIMWtQYjQyMWpzYjdURCtIM0h0?= =?utf-8?B?NldsTWRSbC9oSDFmYmJjZllWTm1mZFArbUlsYng4RnBsRXBLNmJqaTFIYThG?= =?utf-8?B?QkoyRDdNNytNSTljNmhramtkUEEyemZ3M3NGdzdWY2J1MWc5b0VvaURZZ05o?= =?utf-8?B?bDJsWlFoM1ZCTExyU0xCVkd6V1F2YmhHbVRjdWxldHRSYWFNUnpUSmRoYmFF?= =?utf-8?B?V3VwMVZTS3c1MDVvN0Y4aUFqOUlDdjh2VkxtclBNKzA2eHJzYTJrbUhSU3By?= =?utf-8?B?VWltRm0xTDhBc1lvYmRQbFJ0VVVldTlKVElKbmxjeHpuMmY1dDBVZmh3Sk1X?= =?utf-8?B?S0R2L2hqTTVPTmozN0srRGVyN2puMGdSbGJ4OWJ1R0JQZ1hDdEFCV1cweU9S?= =?utf-8?B?bHNMNmRrcVR1a1JXWHlLLzBJV0svYysvdWdydUdkUTlaelIrTENFd0oxSG9F?= =?utf-8?B?T2pFSVBoSHVnLzBYdjdXeTdQdXcwYVZoQW5jZG5KRzIrU3l2M0czVEpFNmpr?= =?utf-8?Q?h5byGTSqMZPykQuNxIDm4mXU/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56e49c69-8539-40b8-ba50-08db94319698 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 14:54:50.6199 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YI/jCWtN3bdeU2iG/kUjVo6s6/Z4PnLNvUUtjDnpEX/cB9LGZqXPAyZ2D/Fs5yn8KcB9jWlAd+3cnGtKPy0aOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8533 On 03.08.2023 16:48, Kelly Choi wrote: > The proposed agenda is in this link > and you can > edit to add items. Alternatively, you can reply to this mail directly. Just to mention it: George has previously pointed at https://cryptpad.fr/pad/#/2/pad/edit/Rk5kDLwcc7CrqFm6O7xq2Jci/ Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:12:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:12:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576459.902612 (Exim 4.92) (envelope-from ) id 1qRZzq-0007A0-Hn; Thu, 03 Aug 2023 15:12:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576459.902612; Thu, 03 Aug 2023 15:12:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZzq-00079t-EQ; Thu, 03 Aug 2023 15:12:14 +0000 Received: by outflank-mailman (input) for mailman id 576459; Thu, 03 Aug 2023 15:12:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRZzp-00079n-TQ for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:12:14 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d16e300-3210-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 17:12:10 +0200 (CEST) Received: from mail-sn1nam02lp2041.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 03 Aug 2023 11:12:00 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB7116.namprd03.prod.outlook.com (2603:10b6:510:297::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:11:58 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Thu, 3 Aug 2023 15:11:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d16e300-3210-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691075530; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=YzrYmWJalqXA0q+sl+9kg/YSXzJcnmqZbIQzHYhqDK4=; b=dJqYAeQWEchh39wa32HQ3UqSZkwZxeQjILpW34UioNptOL2t2PDze+Da pPlxev3Xb6UM52YqEv7GZCaF1tUkz2++LQYdUtGPTuwBb07Nq0o8iNNXE ZplqeX6aO9B8Q6e4Z8bAI0c+zsnuwo/kMQLIA66HOd48/El5CQJ5Ge8o6 U=; X-IronPort-RemoteIP: 104.47.57.41 X-IronPort-MID: 121044182 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:SwqLt6zrZccpb/Wu6Oh6t+cKxyrEfRIJ4+MujC+fZmUNrF6WrkVRz mRJCmmFOa7bMWWjfdB0aIix800Pu5SBzIM2HVNopSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPasT5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVNU5 KYSCDVXVy2gvdmn5Z2faPZIjdt2eaEHPKtH0p1h5RfwKK58BKvlGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjeVkFUZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqhAdpOSOTorJaGhnW39m4VViAudGGp+6P6oUubV85fE Fcbr39GQa8asRbDosPGdx+3unmfpTYHRsFdVeY97WmlyKDZ/gKYDWgsVSNaZZots8pebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsUg8t89Tl5oYpgXryos1LFae0ipjuH2j2y jXS9iwm3e1P1IgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2tYji0bnlePSxfdgw IronPort-HdrOrdr: A9a23:vDXHrqDHVQWOKBrlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-Talos-CUID: 9a23:KJsSX21YY1fRejInI+pOvLxfKNo0KHf9yS3pHmyCMndMZ5m3Vnub5/Yx X-Talos-MUID: =?us-ascii?q?9a23=3A4O1Sig3rFJNzfjFoig2d70NYqDUjx5SsDh4wqbQ?= =?us-ascii?q?8qZPedgd1HjuBjA+sTdpy?= X-IronPort-AV: E=Sophos;i="6.01,252,1684814400"; d="scan'208";a="121044182" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iChGnpII+2p9ajBwW6Kl5LkRgJhnI4AUZBKHexQIkK5oTAZY1atjx+3uZvnQuJp0Seo2DGr+uKeZel6lLhqNX3IuDTg5yu8+E8GOd9Om9EYkoS3GgQVOSggeXNlHE6wmERYYwAWRvYfB4QYqMJGy2IKQpcTdlZah0lF9mAZ9/D5W1tJ8q7Lwv9fKLwUorauOm8e/vSUbeM86CoJ1bYGcMBwdvdaxWvB8J1/YsEGsfdngULAbf7yqvxtFps9Ocnr7Lcb7MBDF1BMHV/HVTMUhJ0DovULIkRfDGrE5/TixJKo21JMS3ryQJtsAPzH5SSMt8NXMpPzGC3md7CbUm/cTsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YzrYmWJalqXA0q+sl+9kg/YSXzJcnmqZbIQzHYhqDK4=; b=X61J8iCYEY1MVbUUOWLpBaEf7KIfv8YCNriybUDUWPnt+Kc0SPL0DbKkKvvgFbJHyKW/D0LqwCPvMAf2M/MyjntVwMVfdEtSqMT85qlfRS1lgoU06CMEWuLuN5AfyyxEwXEn0Hl9lBtO0ynEH4zPm6Gk7WxW3VD7rSne190uKOalHS/BXi+pqCZ1K8qOlQi7CSd+fmsoRsB52yla7kI6nqN5XxuElxT9yFfDG7u9tOEglnT6wbLv3RDbhskXRvMXfOAR3Lghg/xNZ9RuBktrTIEHsFssvTaKI3fuztHnkzd/mHtEyyo4vJUdgPyApUMfyY3TVDfQc8NQOJ+XjHpFHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YzrYmWJalqXA0q+sl+9kg/YSXzJcnmqZbIQzHYhqDK4=; b=WM06JyBn1o3klUuiwHBJ0lAfA8xjFgXnWpCV3UliBbQCx9BrWz6sttJfjfPCJzbhBokhggkVg/6J2UKSjR0Gl73NBHWOm7RIJmJ1/suRiTXc6oN3sD8QXifhuZUTTIT6cRV8XwMKrEoAD73DORcPCU4lVtvqHVlFiD55lWzzwW8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <96b4db3f-bbf8-b04e-da5a-9af894152200@citrix.com> Date: Thu, 3 Aug 2023 16:11:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH 0/2] libxl: build fixes for recent CPUID work Content-Language: en-GB To: Juergen Gross , Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <226f087d-34b1-1a27-4048-f9c6ce3d2d76@suse.com> <90f011cd-5c85-0480-2e47-be6f229800f6@suse.com> In-Reply-To: <90f011cd-5c85-0480-2e47-be6f229800f6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0132.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:193::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB7116:EE_ X-MS-Office365-Filtering-Correlation-Id: 3732bb31-4215-47c4-d839-08db9433faf2 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JSz4kPuWJzUPO19HyzgZziXF8CJDcSPB6d1/fcZ0P4+r7lkjC6eQuDDAnIxRrBpazPHGsmME2G0PBF2cYU0SBUR/xUjlfwWO6QN6bMmogujOBD1L+gzeNj8VorVw6gNFVhkpEy9b/I/dvK3C00/ncwEkSTaoSJYO1rALBeqqKbTvCAejwb/hA8jYOMzC+Ea4Eg/j+uEXeD6tElLQ+yT5bEyLBGP8wrd5jkHKL713ek7tKL3QtmemgSsgjFOyOOv2oEwAnLnX6dXyTE629EPlBt+TmutZ4m7LX/fw7+1aKrAjfSLX+TqSU8lMmF3nCysxALNqN+poFDmB/IxnsFAhNm6KQwOYA2+07nvZH4ls7KNnW7kdSWKxSFpEJ9YC1dybgqS1qxxrB4lmxapikgbCF94zIa7R30nlgHKEux2IXZej4TS0H7xRAa4yahEtFebTF3Fq6gKraUqmx+8CqYEy9xYCcXw4ATelV0yxlexwLLLvX5JgsHw0yOGvxN1Pa+5AyUjIWtYZmtsxO8cEg/zhCSikeDMy/KMpjrL/54b3fvxeYrp4YJ9PIDkY8fP1Nn0cpNqkFx3F9Op1PhhVNt0aNa64BvFVnFv4aO0TwrlC1P95KsQSz715bePIOS/FEAK/d4e2es2lI7lIvSQZHmpgQA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199021)(66476007)(66556008)(54906003)(66946007)(41300700001)(2906002)(316002)(4326008)(8676002)(8936002)(5660300002)(82960400001)(38100700002)(6506007)(26005)(558084003)(186003)(36756003)(53546011)(31696002)(86362001)(2616005)(478600001)(6512007)(110136005)(6486002)(6666004)(107886003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDY0SmtBT2lEN0pqKzFVc0J5MnI2dmQ4UkV2WGF5ZnN1bDhzRjJEaGNDVmNi?= =?utf-8?B?UHI5RmR2R2NHRkFLektiU3RVZFhXQzlSbU1JY3BveG9XcEhHZ1JiWjY4K01h?= =?utf-8?B?TU96SEFnZE1Ic21SNWJNNEhnV0xKYWoxaUk3NzRPVi9seFRUNm11WURBMFNL?= =?utf-8?B?VHljM09WU2Y4OE04eVkxa3llWnUweG5WaDR5b212YTB0YjFKUnJUdVVVSXBl?= =?utf-8?B?QkFrdzRLVXB2ODNpa1dFRE5nbjZNc3g3SmxmU0hkc05TbVl1T1RrektjbUo0?= =?utf-8?B?U0s2T29CbkkwOVdQejg2a0l1MHlkb2lHLzlNMmw1UVZ2c2RWVXQ4cXZPdk0z?= =?utf-8?B?cXJ6VjVIZXBOc3QvWWtGUDVQemFTZmU0Vk9uVmNqeVQ1ODYrNWxDdkNHMDhn?= =?utf-8?B?RTZGcGcwQ3NCNG4rYk4xclFuZ2c1QTJ5Wk52dVNqaEdVZTY1cEVvUHNBMzhO?= =?utf-8?B?eEZoTUxzd3kxY21GeUZDZ1IveEI4QXVuVDBMMjVXTnJELzV2NWVTamxKcHpU?= =?utf-8?B?WWpJck9hdE5lVzRyYkhlNFNwbGRtY05YOW81VmhGc1grMGdKM1Z5MGFYNzVn?= =?utf-8?B?S3EzOERZYjAvVnRkanltSmtnQi9CeFh4Tmg1ajJIS3RVYVdiUklFeHdlL3dS?= =?utf-8?B?dGxZalBaWkhlbHd0enBJdGRNaWh0alRObDI3RGhhM3lzOHFmMklwejlVZTJk?= =?utf-8?B?S2VDUDVjT1J4bkJsa2JvS3ZYYnoxYTVkaEJkRVhjVE9YdUNZUURXN0F2cXA3?= =?utf-8?B?eE5SVTNNbnRtSDluZ1JVUDNVTFdqcFd0ZWJSbXVSWkVDVVd4UlJEbWFpQ3l5?= =?utf-8?B?VkVMelV3eXhjckh5RCtDOGZaTGVjSjZyWnRhZXlYaDUzbHRxcVQ3OVFqWTY2?= =?utf-8?B?YjAxcVVnZDVxOUZPeWJhaUo2NE5xNlNiWjM4N3NNTDFyS1NGQUNGbVdyMVI1?= =?utf-8?B?OUJ0WXRwNzhPcWRaNXV2WGpSbWJUL0xEbjN6dVgwMzVGdnoyQVdPTXVOUm9D?= =?utf-8?B?UkVjYkd0KzkwQzc2WWdiVENWN2JuTGhTa0VZUEg3b0x2eWtBSzhRRExXMXlU?= =?utf-8?B?d05pNStFang0M2hxQkhJV3JUTkROWGpGVXJ5cmVsU2cwTisyNlV6TVZrbDdK?= =?utf-8?B?VkM3RmhxbVZXVWdzZ3g3VG5RK0FTZVJoUk9waUNUZThXZzdiTUtnRWFSN0t5?= =?utf-8?B?U2x2TUtnZE9yWUpsNXNSWHUwaW1HWlg5S2hIUUM5NzJsREhWaDBXUUNxcEZB?= =?utf-8?B?ZjBmRjN1WGJQb0xodmMwT3h3VnBlSVA2Wm1KMkVXOEJDQmNSQW1VaUtrUzcw?= =?utf-8?B?cFFIV2t0U2toank5ZXFSQ2RaVDkxOE1rU2RsSk1QSmViZHJldXJMV1lOTUxx?= =?utf-8?B?MlIzaldkdmZTbDhPbWN4cTN0VGRlM2hVWjBFRVV5clFiYUJHbFp0L1RUOUx4?= =?utf-8?B?MmU1VmZXc3hZN2JMWUQxc09Udm9oOUcwMTM2MkhvWTF6ZExTUEJ6Q0pRYmdP?= =?utf-8?B?QXhWRkVXMGF0MmR0MS9nOVgvMWlxWFE2bUp5QWZmNEF5NWtrUFhad05uNWph?= =?utf-8?B?Z0E4c3VCZU1DWStzSmpNM2VzRE12YitLU1J2NFVxb3gyNC83T2dXZ3crK2lF?= =?utf-8?B?RUVYRnVGV0VjS1c5UzFwUXY3NWJkNFIwKzdyeDNFSlY4aHZtOVc2VzRZT2VZ?= =?utf-8?B?V3hxT3BXQmNaUHFIb2ZPTGhIelYvajJNUU1JcjJ2QVRLQVg0M2J5VDZPcWlr?= =?utf-8?B?amZhMEVOOGYvSjdud256RU94UWQ1U0VBVGU4QkZwd0Y2UkNjbDEwazRaeURh?= =?utf-8?B?RnhkWld0emtFeEFLQ1M4c05OUEZQYzVnZE9WV3lSQWxVbmdRMW9nZlNtZlN4?= =?utf-8?B?aTAxcWc3YXhvUlpLdDkrU1oydlJYWURtK2RqbGVxVm5vWWExaEhaWGl0N3Bh?= =?utf-8?B?UVhueERtbWhsejAzdUZERkxaQVlZRTl0MlFBcnBhNkV4SjdGOHZkeTVlOERP?= =?utf-8?B?S2pKd3pPNEJqSUJPRGk2ZjVnd2lqNFB4SG9LSEh5ekVnbG5NdUpld0N6VHZD?= =?utf-8?B?dzloNzl3OEloUEY5aWM1RktSSmlCRjB2VEhPOG9WMXBkdmxucDRzdlg1Rktv?= =?utf-8?B?Q1NIcDJjNE9yM1NmbklYL2xPZSsyam5aTzhDQUo1NWpsS0FoMXdwWVBiK0xV?= =?utf-8?B?OFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: s+s2Y0naKaC5zsAZo3M3sCtN9uuxpeCOnaB1oJaAgXv01K/Q4lfijXDpBVTMgygUN7Pwzt5R3S0HBHHwfTX4K69HvcXIG5zbUN2MDfqM/jyTXTQ5w/e1wEjJ5PU0zCDoPUW00wetSyVOJGKbtffxXD9ALmPzNKr9CVd+Vy7/H6Xh/5PoG1zvriDqHjTaB8m2rCEFwFYdWJVRkSLaZ6H/mnXyMAmY9mYAczDSQuJ2UaJuVpMM3Fzt6UOHRTwVjlmHZkNv+stkTsyCtG6lDdhUGgg8+Rm1TlisCT6mvC4gGcWATA3Zoou96Eh6d8wsAj0uX9xyMxzYoQ992t4VM9YJenq1ceEMH5UfeVRWCLsCcgV7qcqrC8UEzHEZNs7HG42hH0KsZ2CiuuhZxv/U6VnRl2TCMRjDBODMFRm7w5RU/obWfwO0cu5hCNFgjvH7eoRCLhCdr1bCe7WOpcNhK2rNPWUOm26/Qn/PV3gsSLc9guI5wk/LvQCz+u5XDJYdY/tZKXMJ5Zscv0jHihack5Ag+L9pDu4mb2c7NWrH21RMvs+j1I490zxSN0oIYnMwwRd0uAg6lJzY6sN0In04sXJ44UlctblmiefIRpJSYBT9S7fesewhFlroRCjF4OlKdSWCn2v6xY197eb8FQH9RCG3qAUoY8yQG0XcqW2ZElqLUARbzuhazNJMdFEfgrl74quDcUgHw+hiGkochgZmLdxIY6Ffj1lFchE3oMAj9kYd0NnfGDKrWK+QMUXBfImkGvu0AGvMSCQwDG/Pe9yatDi9hWrGAj2GEFFNb9gLhFs9xhvZ9e5rHXRHxm9KLpjF3o12 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3732bb31-4215-47c4-d839-08db9433faf2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:11:58.2279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K7HARcFFe1gCnq8mz/iRG7CQVTRCE3ZlvMh6TmCC6QmSj8wmWqhiGycjCfDeM5XuktPx8RPXsT+sKkxd41qev0k1L4jpT6gl5b1noevbo3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB7116 On 03/08/2023 3:32 pm, Juergen Gross wrote: > On 03.08.23 16:13, Jan Beulich wrote: >> 1: avoid shadowing of index() >> 2: allow building with old gcc again >> >> Jan > > For the series: > > Reviewed-by: Juergen Gross Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:41:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:41:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576464.902622 (Exim 4.92) (envelope-from ) id 1qRaRu-00028r-PT; Thu, 03 Aug 2023 15:41:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576464.902622; Thu, 03 Aug 2023 15:41:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaRu-00028k-Mq; Thu, 03 Aug 2023 15:41:14 +0000 Received: by outflank-mailman (input) for mailman id 576464; Thu, 03 Aug 2023 15:41:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaRt-00028e-7I for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:41:13 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29fdc1a8-3214-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 17:41:10 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691077265755591.6976092136987; Thu, 3 Aug 2023 08:41:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29fdc1a8-3214-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691077267; cv=none; d=zohomail.com; s=zohoarc; b=JZutway1iudxNiE66wsg4Q5bTV99SBGEiN8GtBL/N2FH8W95a6jYccWtOptuZY/tCIfrdU7rKoFWLreiIn+xT/cxgYJ100Cw4U7FQIRrQeCEPs/9pgL99aas6CmQUJfaI8vgl9iMZgwkNnF0knmPO7urK64OVam8XBjF4BO71Co= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691077267; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=grSgGT4kCmqT7GVHxUlEWkLYR/m3dGzyr4FKWQWQIuk=; b=MNKTRxdH9vH8BdPt3+zf+nTasaCRFS5VbE98S+Fxbpj1O6H1APNgxbVvmrijFvSzZRM+7956+vdZjBhbXbjAyzWofMWb8S/wz3r5OD3Z8XEFwl8/v3jaXjUSBS81Z8gMrDu8UJSylQdj5/k/GEsA22LfYgL7XDh4MKSJu2LnN7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691077267; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=grSgGT4kCmqT7GVHxUlEWkLYR/m3dGzyr4FKWQWQIuk=; b=qNjQfsagMHwkSRLflTTV60RkCE5fCcOSnlyH1n9wyi4vG+PEmlwqUJvNqkfoYZTz JQM1ArHMLG2WCd1PAwD+Kkt9nAZst0WSH3GJnhjyLHj22Bdxy14AIy8J5yEqi+WzNzu qAeQHXMkFW+AU+tHP0+SNf7EmBNGs/l41agNkkq8= Message-ID: <14346689-8276-3c26-91e1-59bc2328518e@apertussolutions.com> Date: Thu, 3 Aug 2023 11:41:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-US To: Stefano Stabellini Cc: Volodymyr Babchuk , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/1/23 21:01, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Daniel P. Smith wrote: >> The field `is_console` suggests that the field represents a state of being or >> posession, not that it reflects the privilege to access the console. In this > ^ possession Thank you for the catch. >> patch the field is renamed to capabilities to encapsulate the capabilities a >> domain has been granted. The first capability being the ability to read/write >> the Xen console. >> >> Signed-off-by: Daniel P. Smith > > Patch looks fine to me aside the two minor nits. I am not sure I > understand 100% the difference between capabilities and roles but I am > OK with the patch. I'd like to hear Julien's feedback on this as well. This might be worth a section in the hypervisor-guide. As mentioned in the cover letter, this was originally proposed as being under XSM. A challenge I ran into is that, depending on your view, the `is_privileged` field and `hardware_domain` global were either abused as a function check and a non-resource privilege check or are just multifaceted variables. This is why the concept of the role was struck upon, it is more intuitive (for me at least) that have a role is something that imparts accesses (privilege checks) and dictates hypervisor behaviors when handling the domain (function checks). This then brings us to an access or behavior that may be inherent to some role(s) but may want to grant on an individually to a guest. A prime example of this is console_io, for which it is inherent that the hardware domain role will have access but may want to grant to a guest without granting it an entire role. This is why I provided for identifying these capabilities so that they may be assigned individually to a domain. While the role/capability is a natural progression from how the hypervisor currently operates. Another approach that could be consider to deliver a similar experience would be to break down every access and function into a capability and then define the standard roles as a conglomeration of certain capabilities. I am open to suggestions here. >> --- >> xen/arch/arm/domain_build.c | 4 +++- >> xen/include/xen/sched.h | 25 +++++++++++++++++++++++-- >> xen/include/xsm/dummy.h | 2 +- >> 3 files changed, 27 insertions(+), 4 deletions(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 51b4daefe1..ad7432b029 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -4076,7 +4076,9 @@ void __init create_domUs(void) >> panic("Error creating domain %s (rc = %ld)\n", >> dt_node_name(node), PTR_ERR(d)); >> >> - d->is_console = true; >> + if ( ! domain_set_cap(d, CAP_CONSOLE_IO) ) > > code style > > >> + printk("failed setting console_io on %pd\n", d); >> + >> dt_device_set_used_by(node, d->domain_id); >> >> rc = construct_domU(d, node); >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index ec0f9baff6..b04fbe0565 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -472,8 +472,8 @@ struct domain >> #define ROLE_HARDWARE_DOMAIN (1U<<2) >> #define ROLE_XENSTORE_DOMAIN (1U<<3) >> uint8_t role; >> - /* Can this guest access the Xen console? */ >> - bool is_console; >> +#define CAP_CONSOLE_IO (1U<<0) >> + uint8_t capabilities; >> /* Is this guest being debugged by dom0? */ >> bool debugger_attached; >> /* >> @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const struct vcpu *v) >> return is_hvm_domain(v->domain); >> } >> >> +static always_inline bool domain_has_cap( >> + const struct domain *d, uint8_t cap) >> +{ >> + return d->capabilities & cap; >> +} >> + >> +static always_inline bool domain_set_cap( >> + struct domain *d, uint8_t cap) >> +{ >> + switch ( cap ) >> + { >> + case CAP_CONSOLE_IO: >> + d->capabilities |= cap; >> + break; >> + default: >> + return false; >> + } >> + >> + return domain_has_cap(d, cap); >> +} >> + >> static always_inline bool hap_enabled(const struct domain *d) >> { >> /* sanitise_domain_config() rejects HAP && !HVM */ >> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h >> index 18f1ddd127..067ff1d111 100644 >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h >> @@ -268,7 +268,7 @@ static XSM_INLINE int cf_check xsm_console_io( >> XSM_DEFAULT_ARG struct domain *d, int cmd) >> { >> XSM_ASSERT_ACTION(XSM_OTHER); >> - if ( d->is_console ) >> + if ( domain_has_cap(d, CAP_CONSOLE_IO) ) >> return xsm_default_action(XSM_HOOK, d, NULL); >> #ifdef CONFIG_VERBOSE_DEBUG >> if ( cmd == CONSOLEIO_write ) >> -- >> 2.20.1 >> From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:42:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:42:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576466.902633 (Exim 4.92) (envelope-from ) id 1qRaSw-0002cI-47; Thu, 03 Aug 2023 15:42:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576466.902633; Thu, 03 Aug 2023 15:42:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaSv-0002cB-Vc; Thu, 03 Aug 2023 15:42:17 +0000 Received: by outflank-mailman (input) for mailman id 576466; Thu, 03 Aug 2023 15:42:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaSu-0002c3-3E for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:42:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51a159d1-3214-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 17:42:14 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB6897.eurprd04.prod.outlook.com (2603:10a6:208:184::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:41:45 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 15:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51a159d1-3214-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ObjJ59AJUxZJaWbPtVMFGIWc7DPSa+pywJfhFgzv+Xza+4HwQo1Viup5ATSWVrASDFa2V87zUfEpDuGE+lnrlZcj+lgofIeB2oavJayUf4MWd8lnDT8pXDuvatGPi/gMwloYMLGsrm8bUCXrk/dr8MuXC9kWYyYq0HddTiNP8sc3d3wq/9KkbKBd3XgBYeQt40s3cqB9+LISnh8vRLnLMN6Gz9mR5xlMYXHavIgrVCb8i5gvamyZ9fTDe9dM01xN/Pd+/cuaei+HX09VK1fxmTDvJ/kJZzft0PUr2mNEVD15caILu1XER0ic88EGpEYPCmq/Fz1BJ3XWEz4ivC3Dzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9P4uoyU/0qNGHpXBbsPek+ERlXRrnBGIV/T9hzgJSIM=; b=U/zauUSQK3hhYo33+yNNx1NNQnAIpf8uXNZao58aDcoqSea6FogIR7qZ6r+yIi10r2nKqHo8ih9dmfCZWscWiuahzNy4dgnzmbqg0naYaJzNKTiEphH84kV/4seLrGO42xezTSpdfhKmaY4L+sxymkFOmiNfPd/EB+tgEULhEEIzSTis6Yy1/BzTpMnK/dKSyeNRd9Sf4dl3SKB/9d2Fs8wxSBVh3Ar3JwQLcFiuiVkdq8GDsDmU/OMeIkmR07ukCRnrF9KiidA9ndQ8e//Jon3RyloVSKXlil0sIgoIKCcqdVcPQPESaUH6nWuRrZlpJgZaINWAG3PA6lDM/u8LxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9P4uoyU/0qNGHpXBbsPek+ERlXRrnBGIV/T9hzgJSIM=; b=l8UMtt8QomW5kspuQaJFjX3mxw0GXUSrtAnKnTxNb4iNzJTuiyG/gIiOZdDWuL9t4ILKTDHle+roeolIjuLQLzN5ESzZsOWVWrMX41JzNgbOLVxzINHTrvDPZRd/7Ka39LvcQ6hR7vDdy1Ul0C3pKc2HSNY2/4B4pSP3iqZIZSyaHFJwSeKkorG833XvMfH7c6wfvj0AjuBbW063w88AuSpjZ65rX/YzF/qnUUh2jG6ACoj26EAREdZbUgpx5lZ/P34BLR4JQKoxh+XiEnjWamzGAHalDU6OlYpCFibJN3dY8bgumg8M4jnX4mElKdJPNSEL3227Kts8uYDD9XdR5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <693596f9-e2b7-41ac-6d3b-5c82fd3474b5@suse.com> Date: Thu, 3 Aug 2023 17:41:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , xen-devel@lists.xenproject.org References: <91b2f2c9e728c1f19f7baab301299d995a074279.1690985045.git.nicola.vetrini@bugseng.com> <0ba36273-33ad-753c-06a5-be117b6658e0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0114.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB6897:EE_ X-MS-Office365-Filtering-Correlation-Id: 4aabf589-6861-48e1-2977-08db9438247d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gzzMkPdPUTUvqnq677Lk/MB2DeCKzJ0yoRu6pKMvYiAGFjwe1lGCV7xTmjc8K5kgv/KFC+76hJxd8hu3gjyHyX3VA5gPPhBvjuitiifsOeiwuyi7Zdehsy0MlQaCie8P2GIIyuveOkuVeBVypVSn5B/SwDkK5Gs78SksdSGNap7pbyP4lr74dTGrU4YBU7a/O7y+Gtl4eGKKrqoFNXkcgGmp2HqBrEgKv9ZIxYgyHDEikHMx2tihaP6uYZgON+nkPkpZi9l9eeVBgPR4KL2aRjVdxfG0ddZA9/EkO5W77qmPLkU2SiSfnfzaOq9kiq+fa4arpaOOs7xxNYoqKY1ePq3JorDz7p0DJdYLlNpJoazVSDS5H6Hhdr0DQ2UnstEqewFf905YkNeyW88gOMbkWESeMPr4PFskqXAZsA8MPZjuDouleDtXozZ8qBn0108+pkXY2JYlx5VGgUzw2yQJ3/wP+xwKdvpR6o/R6Te1lxZ74AWgO33+BVYKIskqwK88lVH3VWybqfVPbIljjZp3mpn+KaG4wIavQHx+VIJ/11sXepHHvL40J7i7lMvf6NdcYz6006hxIhEmXv4OApG1IwWbEAKRR0iz67zLg38+y0sY+HKhK5AfHNhoujJsUaIdB5eWdX5ENq5UaYvRArjlHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(396003)(366004)(39860400002)(376002)(451199021)(66476007)(66556008)(54906003)(66946007)(41300700001)(2906002)(316002)(6916009)(4326008)(8676002)(8936002)(5660300002)(38100700002)(6506007)(26005)(186003)(36756003)(53546011)(31696002)(86362001)(2616005)(478600001)(6512007)(6486002)(7416002)(31686004)(66899021)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUNZaFBMR0huYnlTM0w1MHpTNmRwZWtYa0h4RXZnQ3ZYdTN2L05ZT3RxSDRl?= =?utf-8?B?b3lrV1VhRmh6NFdiYUE0SC8wSm1RUVFCb1hYelB0RWZ0UW1WdDRSUjVJKzU5?= =?utf-8?B?eDFWUGFTRk5KUS9WbmVBcHh5ZDhZM0EzTzdwY2xmWFFHV3IvSzg3N2hRY0ZI?= =?utf-8?B?TTFydy9YV05RdUV4VmVTYkdQL0VqdURIb3JBbC83Mk1JUUN3Q3ZmSDFpN1JY?= =?utf-8?B?WlNOcHZ0blN4TlREM0d1QVNzcVJKcVlQRm9sUjk4SExqWlk3STNWZVorTmQ1?= =?utf-8?B?dnBOVWxveW8yZ3A5MVRudXY1bU5UV1VWalRDY0UyNkJHUVRZRkttZlN0NTY1?= =?utf-8?B?SUtubzJwVHBSOHo2RlcyUzkzdW1qbzBYQUIyWlkzY1k2YzVnTENiWExib0cy?= =?utf-8?B?TjI0WHRoQ29HYUh5YUYwSjBxbEV5UzlzMk50bXQ2VE8rMCtnRU9ldHAvbk51?= =?utf-8?B?S3RXbkdmN29MbHVqcTE1Z1ZVdXU3MGpFWXFyV3RuLzRwcmFLTHZWVFZ2K21u?= =?utf-8?B?VStPNGhTOS82R2w4M2hGN2Exd2ordXpJUEVmOVNPZEpEeDY1M2RrSVFlOTBt?= =?utf-8?B?YzIrd1lpRHJ6MHlTazVsc29najVoN0FyMXZxUyt5SU9VSjRpdVVKbEZzZm9F?= =?utf-8?B?eERVL2hBV0Z1dklxWng0dHJRcXJyemE1SVpzZVdjMmc1Q3NPTUlQUE4rcVN2?= =?utf-8?B?d05Da0gwVFA4R1JidnlNN2Y5eUZ6Tjh6M0ZCVURyUVdLMXh1R0ZzaU16ekY2?= =?utf-8?B?My9HNWM0WElPeW4wQjh2Ty81K0hUdllDdkNtdVNhY0VtWXJ3dVl1S3grVGNV?= =?utf-8?B?Ukx3SWl3VFo1NkFLNXF2eUxUem1lOXJSa0hmbFJzeldOK2MzWHp6N2dwbk5S?= =?utf-8?B?cVNrY1F5elFHMzJqa25ZSEpRWlMvdHpSdVVwY1MwUjIyd0lVTnR0RFN3Tkx6?= =?utf-8?B?Q1QvVDZiTU5EbklJb1I2c29VTnljTGJxQ0JlOUdJQWdCZklwQXlrakpaMC81?= =?utf-8?B?RStxVDVqN29BTVErQTlSSHQ5c2pQSlI2Z2IyMWlWZC9vM2NBekxtZVhRRzJS?= =?utf-8?B?ZmRGVzhxeG9CVkNYcVlQWjdYdzJKQXlpREhmZjgvcjk3VGlEZlA5R1J0MWRQ?= =?utf-8?B?UGJvcTUwL0J6c0VzdGg5SkNzWWdCUTgxMFJOMGxscW1Mei9FVWNlQWFzMTFS?= =?utf-8?B?THJJTmV1akhzNnRFRXNFMmRCYkx2MDFhYVJVU1hLUnZCNnVQbTlVV3V1bzht?= =?utf-8?B?ZGpheDM4aFRJWHQ5VzB0Zzd4WVJTelUyeXN3ZVUvNzMzNEhmcVV1R2c2Lzgy?= =?utf-8?B?WTNYSUlaNjMzNzdDQ0lzVGtmZFBXRERtbXNpSFNSdE5URE1XSFBGQ2ZzK1lm?= =?utf-8?B?dkgxc29VajZDdHRPbCtVMllwTmJlQkxmdGtjelZYZk5kbG9acTVESVROZ2ti?= =?utf-8?B?TjhMZkFUZ05WQjU2TFV4K0tTNTRXOVNJczQydmFRWjNIc2NUWU5wWjRaVk9X?= =?utf-8?B?S2tNRmg1WXpPcVhlZGxzNjB4eWdYSnM0cUhDWkRKQU03cTcybisvTEpKT3dX?= =?utf-8?B?Uzc0YkU2bEZ5eERreFp1UWQzQWd0VURDbXowRWttMThodlRvcmwzTWdocGsy?= =?utf-8?B?VE1KclovcmNEbTNieHgxZDljdzhJeEp6ZHltOTlvenowUW1YaCtYMVBEV2ZS?= =?utf-8?B?S1FsZXlJbkNlWVVBMjNKeTZZakxkRG5BeDNpdFBjQWEyaWhWUFRFa0h5Y05O?= =?utf-8?B?MG1ML0JSa0ZvWXVaUHlHYnB6dDByZVJJbzFtcWREWHI1bTA2ZXNrdVZybjB0?= =?utf-8?B?cE5ZZG5UMklKWjg2dkF2ZkJCbjdqN2g5c05FM05MVVZFVlNUaW9KNk9NMzFU?= =?utf-8?B?K0lPNGEvcVE5Nlp5UVg0akdQMnVhbk9XRVpWZWY2TFdrYlo2QVRoOGFYc3JQ?= =?utf-8?B?OHROVlZzNG85aGEzYzlweXdiYWlvTmpCMHpTOENvSytVSURMU0xMWUFEWnpL?= =?utf-8?B?TXVFVzh5NmlpclJBRkp6Vy9LejdrNDdVWVZvRkhFK0Nob3NpRm9FeE5wQ2Iw?= =?utf-8?B?NXl5Q3dpU3NOangxa0FaTklKSTlJT01LTUY3ZkRJdjhkeC9FN1AwVktQYmww?= =?utf-8?Q?QDActZB9nIy/xrOmQ8ikr5iMe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aabf589-6861-48e1-2977-08db9438247d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:41:45.6011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zjDZHNC4CAthHUXcIsXeuKkVPU78xmux+8jq8Mk4tBHGxu+hxUyS8YfiqpttXJgMN3FlEc8qMEORnWwCpZ4TSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6897 On 03.08.2023 11:30, Nicola Vetrini wrote: > On 03/08/2023 11:20, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> --- a/xen/arch/x86/mm/p2m-pod.c >>> +++ b/xen/arch/x86/mm/p2m-pod.c >>> @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const >>> gfn_t *gfns, unsigned int count >>> } >>> >>> return; >>> + ASSERT_UNREACHABLE(); >>> >>> out_unmap: >>> /* >> >> In the description you say "before", but here you add something _after_ >> "return". What's the deal? > > In this case the unreachable part is that after the label (looking at it > now, I should have > put the assert after the label to make it clear), because earlier all > jumps to > 'out_unmap' are like this: > > ASSERT_UNREACHABLE(); > domain_crash(d); > goto out_unmap; > > As I understood it, this is a defensive coding measure, preventing pages > to remain mapped if, > for some reason the above code actually executes. Am I correct? The comment there says "probably". So the label and following code might be used for another error condition as well. Furthermore both paths presently using "goto out_unmap" already have ASSERT_UNREACHABLE(), so it's hard to see why we would need yet one more. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:52:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:52:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576473.902642 (Exim 4.92) (envelope-from ) id 1qRacb-0004Ft-3h; Thu, 03 Aug 2023 15:52:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576473.902642; Thu, 03 Aug 2023 15:52:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRacb-0004Fm-0Y; Thu, 03 Aug 2023 15:52:17 +0000 Received: by outflank-mailman (input) for mailman id 576473; Thu, 03 Aug 2023 15:52:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRacZ-0004Fg-GV for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:52:15 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b509199b-3215-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 17:52:12 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691077926722381.80389769675753; Thu, 3 Aug 2023 08:52:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b509199b-3215-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691077929; cv=none; d=zohomail.com; s=zohoarc; b=n5M8sqadDbqBUdBJEiWrFCCVrTZKJh/6Myif8ERn3W12V/7HuN2KZ+Hr/6tLyWeX8yyKiYdQSaRk0JDCXZUibAZMufZDTp+u0aN3IdCMtCKwfBX+GUx+OyYgou74O3HYVn8v0SO75wk23TsPiUy1956MUIHfHSFqfooDrL85C20= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691077929; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ahXMxxfMvQJXeEM/uNzmE/KllU0VmrymEtqJirpqvIU=; b=HnAcRxYooYPVtptwdjW3QnXfCiNXQcqdZfYgtGASimtW6DmjuNf2hy4oNlvMcZAKBqEHI0zHb6DXh5/EpJapyrzTyTh53s1DN24hqDhJvLkO03ZpX3hWhacUmaDn/cVCXx8QHk2K8g+QjVxD0vcARqwWPUgmyuQi9hG5ovSwQ+w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691077929; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ahXMxxfMvQJXeEM/uNzmE/KllU0VmrymEtqJirpqvIU=; b=LnuvRrGqhRUPrE6rrzwkZe0Q+tnvrQhyyKeYPX6xG6LZjF4xvqRfMWEpPut/MvCY Zb5FDnruOHGRZrRRiY4+sU5rihvugfWFDJ2FYsHEvg2MjC5S2Q+GkYYmQ2aF00eIioW ZBtsr96QdfYCt6F4hsDKTBbTF2qNYAapONMiFpqs= Message-ID: <2a651c80-7e44-1ff9-bb63-989605960c72@apertussolutions.com> Date: Thu, 3 Aug 2023 11:52:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 6/6] capabilities: convert attach debugger into a capability Content-Language: en-US To: Stefano Stabellini Cc: Wei Liu , xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Jun Nakajima , Kevin Tian References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-7-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/1/23 21:06, Stefano Stabellini wrote: > On Tue, 1 Aug 2023, Daniel P. Smith wrote: >> Expresses the ability to attach a debugger as a capability that a domain can be >> provisioned. >> >> Signed-off-by: Daniel P. Smith >> --- >> xen/arch/x86/hvm/svm/svm.c | 8 ++++---- >> xen/arch/x86/hvm/vmx/realmode.c | 2 +- >> xen/arch/x86/hvm/vmx/vmcs.c | 2 +- >> xen/arch/x86/hvm/vmx/vmx.c | 10 +++++----- >> xen/arch/x86/traps.c | 6 ++++-- >> xen/common/domctl.c | 6 ++++-- >> xen/include/xen/sched.h | 9 ++++++--- >> 7 files changed, 25 insertions(+), 18 deletions(-) >> >> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c >> index 27170213ae..9872804d39 100644 >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -999,7 +999,7 @@ static void noreturn cf_check svm_do_resume(void) >> { >> struct vcpu *v = current; >> struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; >> - bool debug_state = (v->domain->debugger_attached || >> + bool debug_state = (domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) || >> v->domain->arch.monitor.software_breakpoint_enabled || >> v->domain->arch.monitor.debug_exception_enabled); >> bool_t vcpu_guestmode = 0; >> @@ -1335,7 +1335,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) >> } >> /* fall through */ >> case X86_EXC_BP: >> - if ( curr->domain->debugger_attached ) >> + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) >> { >> /* Debug/Int3: Trap to debugger. */ >> domain_pause_for_debugger(); >> @@ -2732,7 +2732,7 @@ void svm_vmexit_handler(void) >> >> case VMEXIT_ICEBP: >> case VMEXIT_EXCEPTION_DB: >> - if ( !v->domain->debugger_attached ) >> + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) >> { >> unsigned int trap_type; >> >> @@ -2769,7 +2769,7 @@ void svm_vmexit_handler(void) >> if ( insn_len == 0 ) >> break; >> >> - if ( v->domain->debugger_attached ) >> + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) >> { >> /* AMD Vol2, 15.11: INT3, INTO, BOUND intercepts do not update RIP. */ >> __update_guest_eip(regs, insn_len); >> diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c >> index ff44ddcfa6..f761026a9d 100644 >> --- a/xen/arch/x86/hvm/vmx/realmode.c >> +++ b/xen/arch/x86/hvm/vmx/realmode.c >> @@ -121,7 +121,7 @@ void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt) >> >> if ( rc == X86EMUL_EXCEPTION ) >> { >> - if ( unlikely(curr->domain->debugger_attached) && >> + if ( unlikely(domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH)) && >> ((hvmemul_ctxt->ctxt.event.vector == X86_EXC_DB) || >> (hvmemul_ctxt->ctxt.event.vector == X86_EXC_BP)) ) >> { >> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c >> index 13719cc923..9474869018 100644 >> --- a/xen/arch/x86/hvm/vmx/vmcs.c >> +++ b/xen/arch/x86/hvm/vmx/vmcs.c >> @@ -1912,7 +1912,7 @@ void cf_check vmx_do_resume(void) >> hvm_asid_flush_vcpu(v); >> } >> >> - debug_state = v->domain->debugger_attached >> + debug_state = domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) >> || v->domain->arch.monitor.software_breakpoint_enabled >> || v->domain->arch.monitor.singlestep_enabled; >> >> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c >> index 7ec44018d4..5069e3cbf3 100644 >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -2041,7 +2041,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) >> break; >> /* fall through */ >> case X86_EXC_BP: >> - if ( curr->domain->debugger_attached ) >> + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) >> { >> /* Debug/Int3: Trap to debugger. */ >> domain_pause_for_debugger(); >> @@ -2121,7 +2121,7 @@ static void cf_check vmx_set_info_guest(struct vcpu *v) >> * immediately vmexit and hence make no progress. >> */ >> __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); >> - if ( v->domain->debugger_attached && >> + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) && >> (v->arch.user_regs.eflags & X86_EFLAGS_TF) && >> (intr_shadow & VMX_INTR_SHADOW_STI) ) >> { >> @@ -4283,7 +4283,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >> } >> } >> >> - if ( !v->domain->debugger_attached ) >> + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) >> { >> unsigned long insn_len = 0; >> int rc; >> @@ -4307,7 +4307,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >> break; >> case X86_EXC_BP: >> HVMTRACE_1D(TRAP, vector); >> - if ( !v->domain->debugger_attached ) >> + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) >> { >> unsigned long insn_len; >> int rc; >> @@ -4647,7 +4647,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) >> HVM_MONITOR_SINGLESTEP_BREAKPOINT, >> 0, 0, 0); >> >> - if ( v->domain->debugger_attached ) >> + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) >> domain_pause_for_debugger(); >> } >> >> diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c >> index 4229bda159..041ced35ea 100644 >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -1214,7 +1214,8 @@ void do_int3(struct cpu_user_regs *regs) >> return; >> } >> >> - if ( guest_kernel_mode(curr, regs) && curr->domain->debugger_attached ) >> + if ( guest_kernel_mode(curr, regs) && >> + domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) >> { >> curr->arch.gdbsx_vcpu_event = X86_EXC_BP; >> domain_pause_for_debugger(); >> @@ -1995,7 +1996,8 @@ void do_debug(struct cpu_user_regs *regs) >> v->arch.dr6 |= (dr6 & ~X86_DR6_DEFAULT); >> v->arch.dr6 &= (dr6 | ~X86_DR6_DEFAULT); >> >> - if ( guest_kernel_mode(v, regs) && v->domain->debugger_attached ) >> + if ( guest_kernel_mode(v, regs) && >> + domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) >> { >> domain_pause_for_debugger(); >> return; >> diff --git a/xen/common/domctl.c b/xen/common/domctl.c >> index 505e29c0dc..895ddf0600 100644 >> --- a/xen/common/domctl.c >> +++ b/xen/common/domctl.c >> @@ -99,7 +99,8 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) >> ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying : 0) | >> (d->is_shut_down ? XEN_DOMINF_shutdown : 0) | >> (d->controller_pause_count > 0 ? XEN_DOMINF_paused : 0) | >> - (d->debugger_attached ? XEN_DOMINF_debugged : 0) | >> + (domain_has_cap(d, CAP_DEBUGGER_ATTACH) ? >> + XEN_DOMINF_debugged : 0) | >> (is_xenstore_domain(d) ? XEN_DOMINF_xs_domain : 0) | >> (is_hvm_domain(d) ? XEN_DOMINF_hvm_guest : 0) | >> d->shutdown_code << XEN_DOMINF_shutdownshift; >> @@ -643,7 +644,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) >> else >> { >> domain_pause(d); >> - d->debugger_attached = !!op->u.setdebugging.enable; >> + if ( !!op->u.setdebugging.enable ) >> + domain_set_cap(d, CAP_DEBUGGER_ATTACH); >> domain_unpause(d); /* causes guest to latch new status */ >> } >> break; >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index ebfe65cd73..47eadb5008 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -474,9 +474,8 @@ struct domain >> uint8_t role; >> #define CAP_CONSOLE_IO (1U<<0) >> #define CAP_DISABLE_CPU_FAULT (1U<<1) >> - uint8_t capabilities; >> - /* Is this guest being debugged by dom0? */ >> - bool debugger_attached; >> +#define CAP_DEBUGGER_ATTACH (1U<<2) >> + uint16_t capabilities; > > No need to switch to uint16_t just yet? I know space is tight in struct domain, wanted to reclaim the freed space into capabilities (or roles). One thing I was considering if enough space could be found is instead replace it all with a pointer to a new struct that held these values. It would allow using heap space and future growth of the structure. As of this patch, it is consuming 5 bytes and would need to find an additional 3 bytes. Is there a willingness to entertain such an approach? >> /* >> * Set to true at the very end of domain creation, when the domain is >> * unpaused for the first time by the systemcontroller. >> @@ -1166,6 +1165,10 @@ static always_inline bool domain_set_cap( >> if ( is_pv_domain(d) && is_control_domain(d) ) >> d->capabilities |= cap; >> break; >> + case CAP_DEBUGGER_ATTACH: >> + if ( !is_control_domain(d) ) >> + d->capabilities |= cap; > > I take it is not possible to attach it to dom0? I am not familiar with > XEN_DOMCTL_setdebugging but the hypercall doesn't seem to have such > restriction. Good question, on first glance I can't see why I added this. Going to walk through it again and see if I can figure out why, otherwise I will drop it. >> + break; >> default: >> return false; >> } >> -- >> 2.20.1 >> From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:57:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576476.902651 (Exim 4.92) (envelope-from ) id 1qRah7-0004qp-L8; Thu, 03 Aug 2023 15:56:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576476.902651; Thu, 03 Aug 2023 15:56:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRah7-0004qi-IO; Thu, 03 Aug 2023 15:56:57 +0000 Received: by outflank-mailman (input) for mailman id 576476; Thu, 03 Aug 2023 15:56:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRah6-0004qa-AD for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:56:56 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0604.outbound.protection.outlook.com [2a01:111:f400:fe02::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e426eb4-3216-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 17:56:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9140.eurprd04.prod.outlook.com (2603:10a6:102:22f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:56:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 15:56:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e426eb4-3216-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hFIbRyhlIZeZmlMX0xhIuNY76qzgsPuI+tRHMT2h9mv1E3GxO1dTGI29iDu5HD5xPxuVPOiXE2wvLvi7E5g0Ho59MS8GDZ77sfTAdqsFHJ81gKHVzu1ONVtsa1dpKwXGyOHYlN1cZqv+RaKfAB4GCqIMK/l0kMxKpGAy0MITNljegwEPjDxEdEJCGq0Xm1Tb4e/teP3eCrYdFEZb6xoOOppu8WCFQGiEAcIrHI8KF8ipVGGDEbh0wsbxPy3HIoWIpoh9fAIAYGr5Bj7Yam35iAo6wcQAZJ8rUR5rd7LMzXa2So88Ly5zGWHLGlH23Nshxq8xSCGLIaQ81gy3bClKLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7z++OH64X4v10TV4JneKLO7NZHCTtV+E1pdVc36zSq4=; b=XsUGyBMupMxLxuzL7yZKVlFvkVj1EySOOXWwTGZcrFtNhwpImgqQkaJW/E6g8uPgbXQbdAhPU1wWLT6QzOrrfyjvOuSYPS79sZMARwj37YIXGAb3Wlnu9p7F5IQDOuGQXENSEDLBOk3giqkN4KT6G/b7eLKtsWgGkBlisXbSY4rB1+bFGUmfVaVTpiVIa2o9Bv1GSc3e4roVaHLBAJ+MqJKVpXpoy+LBS1dAuPR57URHeUXfE4bdgxr/xVrFoe4ywr4BKJclqHx2rqdaUkXbBGCGYTLejPlEFh2SQyt59ewOKiuH4UBx5V7di08GdK0UznGwlkFCrhGD+mzhjAZhtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7z++OH64X4v10TV4JneKLO7NZHCTtV+E1pdVc36zSq4=; b=2tek5Z/BnkSnu/CLQVA4vXnkvP9eVDkE0H+Rfwd+OK1ZhB1fTO0jUxtrTNBvMCWHqTq/TRL32etJvTVwVRrXGaMwz3I1RWysz+EX0EGIbfY0ElNyGUpvesHETvmJdKg/V0pKdoQO8MpOZt5H8WjZEun3wSEcokbvhXYHH8SkBnLjbeq+ZKlj7qF6uLPtItAtXNAImKN6u7FKL18h2NrgM19GHoZ+SZl0lhWdXbSe5EL5dNZUDq1sd8Wqh1beQZsm3+wtE7GgG4H7BcH0MSbMIrVhjvW6unJ7zfalHVHbGDV3InjX4caRVTa1qskcxNh/oI0FNA3eWNyO4EwGQWTVyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01a80d4c-f19b-98ec-805e-e648e752d6b1@suse.com> Date: Thu, 3 Aug 2023 17:56:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: "Daniel P. Smith" Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9140:EE_ X-MS-Office365-Filtering-Correlation-Id: 60e618fc-b1c4-4b9e-1c3e-08db943a3d18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lndacWCb6HXCarskpn9KnziVdPBIv1oGHqbx8zdI2K0v2BeGOi8R39LZtc/QoF61UIiSTnQNgQSs2x6aRADjtCYAhiOciUp/Njzj7/vyVFeP6OFS5XtArimPb+T1clBQFkzybH78dmERzLgm9A/AZrbs1JKujM4638pvw7njW4b/ifIgwFpqUGjs2MFuO4CH4KJNWk9wWoIjSePXmBUkjokrvTyMs2BNyvNPRq9B3tgbQsjj/uHWHr9k01cwi6M0fuQgb62WxbMcdkPQTlz4ihN43aLfRaCbky0d0vbfRTFkkmQlX8OSu8ILfZlYqyrfCIX2TxWAAX31LNwJYjGu2JC3evHqNM3qrfYmz3OWTNCDWImYN/HW0DwJ8QjPsG+mpMGJwMH/0M64qYCh/aXuhJm510EPbTqoK5SJ6QENkbyAqlIDvcZzy5OrugDAdBhZ4eiOXce+6MKPXYYZT7z6ObEoZfx3gM1uunrRfQNuIytu8TxCTQ34HGpcybNZmAiiN0jJjNu5gpARmPB51JXEx0DG2gRgsU0KAjXsoJgawsm9H2UhvdyMKBjjmwQBs8zQYTvWPIS4l05V4fkZd+bbIElJzTPteu0WPZlPKJCpKzfVFeZTZTQc/dxnOPqRz4ANaTOs2Uk0Jnx6rL+onDatSw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199021)(66556008)(41300700001)(6916009)(316002)(2906002)(66946007)(4326008)(66476007)(8936002)(8676002)(5660300002)(26005)(36756003)(53546011)(186003)(6506007)(86362001)(83380400001)(2616005)(31696002)(38100700002)(478600001)(6512007)(54906003)(6486002)(7416002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVgzdzRVVWE0T0NvQUZibnVxc3VxRmVtazRnSWkyeEwzWUJkTjJyMWpVazA2?= =?utf-8?B?bjBMbjd2S0ZnNmpybXg0VitFNU0wUTdNdGdydzF2S3VkTFVyaE5DN2lTU1B0?= =?utf-8?B?YXJvT21yYjdPd2wxS2tUbVBmUVI1Rmc0NjVBMWxSL3dmeXRKME50eUVtU2N3?= =?utf-8?B?T01yYzNIN1VPOXFFcWM4My95Q2hyZUZNVjg1Y0JXMUJTTGtBNkw0clo1Wm5l?= =?utf-8?B?L3dtYnBqVmRKRkpiSmZVdVpnUDAvU2RtWU9GTnJUWjFDVzVxdERza0IwNjlZ?= =?utf-8?B?cHZZdURTRGRkanZLd2hOVWZielFPdjZiQW1IOFhVR2UvV0R3aEhNd080N3A0?= =?utf-8?B?bmhhVE9PVkpnUFJrVmlETndlak5lakc1MHRBUnhuVGlMN0hHWGZyNm5nMHFT?= =?utf-8?B?bUQybGYyQ2ptRGwvQjVlbWtuMkRZQmVGVDQxYUp0ZDJWMXFDMFNZOUNPSDZm?= =?utf-8?B?cDh6V0dOTjhnaVRPZFdSajBKT3hmYytTYTlqKzdUMndhUlU2WThlclhwK2Mv?= =?utf-8?B?T0ZVRGpvR1ZZRkp1dXF5Wjc0WWpEeVF2K0ZVWnNVWWdpQlJHRHhHdEZIN2Z2?= =?utf-8?B?dHZyeHRWZnJLNUFodTJPUGxaNVM5NEtNRkJqemIvZm9LM3RjaW9jYUhNdGZy?= =?utf-8?B?aVdCbDFnOHhXT04rSXB5UFRVS3pyaEI1VERwWmNmWVZSK0E3T0NjL05XUFRw?= =?utf-8?B?Rk9YZFc5ZFpMZ1ZSLyt2M1I0YW1EdHZYaStBUGZoTFF4aGk1aVYzS0RFMkIr?= =?utf-8?B?RGtuUElKTHpCalBhenhnMW9oQ2gzakx1M1VBNk9Nay9PYXA1QTJaOHV3aGZN?= =?utf-8?B?OEV0UVhyYmtYWGp6djZCYjhkYng5RTIyMVdEWitpZWhSd0ZzTDVMV0paZ0t1?= =?utf-8?B?NDdSVHFMSVZDTzEyelJWZmFJeWM1TVdrV2Y3aG5OdnN1N0srbFhQM082MEVl?= =?utf-8?B?WkgyWFNYTC9ZWUVCdkJVdzArNmc4U1lxU3AxK01Ib2REbkZwN0NabkN0MzZr?= =?utf-8?B?Y1ZzNzFjL3g2UWNKYWpxQWZzeDBXMG0xVXJTcTZPanFKL3RpZmVBV1JoM0l5?= =?utf-8?B?RUs1STRwT05xYzlmaU9ORHdhKzQrTWY4SVFmbXo3NzRNT3Zjbkk1dmZzUHB1?= =?utf-8?B?QlpDb1M0VUpnUjlBWFlrbVVFVUE5QUFvd2RsUnk3QXJYSUxFaGsxM2hwSEM5?= =?utf-8?B?K200NFVtZWpZaUUvanhiUjZyY0VaZytML1VySlVUUDFzWjdBTmowTE0zM0xS?= =?utf-8?B?aXJKTTBpZUxPb1UwaUZKQUhnbVJ3NkQyZkdLQ2IySm5VT0o5NVBzSUs4dGRk?= =?utf-8?B?V1VKb2M0NTV6MzBhR3JtQUtqcndEWjAxWnk0Z0RwOURPZnhzZ3JINmVoclBs?= =?utf-8?B?bWZweVJ1NzdUd2taZlI1aEJKS0E2WncwV0l6Q1FwcjBoM3N0a1pXdU9zZ0NI?= =?utf-8?B?SVIxdW5PUUxhMkxJa3FPYnJ4cXlvdTdJSnRjTlVKQWVLVThaM25md0RCQnZx?= =?utf-8?B?cUgzM2JxaWFpZS94RVQ0eWpJZ2QrZEU1NTc3MnQ1NFdWMnU2Yk55VSt3S3lX?= =?utf-8?B?cnhSdDh1NU13enNRS3hjdXFtK05MT3NtLzFFN3k5OEtmVndsTEhWV2d1Nm5h?= =?utf-8?B?OWR6UDlVcEx6S0IzbmVrQ0hqL3h1Y1V5VTFwL2dkbnNrU0pEWDJzdmRMb2ov?= =?utf-8?B?dXc3d0l4SGc4R3NlbGJCanpnYitvbXhseEs1SENjYmRqOWQ1TTVPYUhGRDhE?= =?utf-8?B?M3lCVUVGR2lzYTFDbTdMNTNwcXhUYy9xemlkNS81bTd0azFFQ0k3WUtHNEhT?= =?utf-8?B?eWZ6ZjllSUpaRzlmVFkvcXJyQ2VjcjlyeUhHdUhUaWtMNm5mMGdnandIRkRy?= =?utf-8?B?UWp2UnJ4TitBekJhYWFiY3V2dSsrMzZ5b25wbGl1bktmKzR1WEd6WE0yMjVO?= =?utf-8?B?UHV2cG84NlFxaFlPcXBDMGEyb3VreHZzdTlqMm5Ba3NEcFNuSkVscVhtRnY1?= =?utf-8?B?bUV4UFBGRlR3VmxDVW53NkdoNHVzSlorMmpFTSs4R0tKSWRQYkMwTENzeEtZ?= =?utf-8?B?UHl0Q3lqNkxUYzZKZDF6elQ2cE9ad2NaUEhXdHgrOEFwSHBvWmpLVVpDc3BO?= =?utf-8?Q?5z/a/QSSs7rl7wdce62K/lPy2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60e618fc-b1c4-4b9e-1c3e-08db943a3d18 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:56:45.8037 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z5XYevfJ3S0aw/Y9JU8HVw/ATcAD/qIHbiOkKf9MRwaBdB8oKV67TKTAvsOHPj0Dir/iRhSYuCbZ+xmwbp6t4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9140 On 03.08.2023 14:56, Daniel P. Smith wrote: > On 8/2/23 07:01, Jan Beulich wrote: >> On 01.08.2023 18:06, Daniel P. Smith wrote: >>> + if ( hardware_domain ) >>> + { >>> + console_rx = hardware_domain->domain_id + 1; >>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >> >> Here and elsewhere - why %d when original code properly used %u? I also >> think there are now quite a few too many of these all identical >> printk()s. > > Good question, I did not write the line, it was copy/paste from > elsewhere in the file and then continued to replicate from there. There's exactly one such line right now, using DOM%u. If I'm not mistaken, it's not all that long ago that this was changed, so I would suspect an incomplete rebase. >>> + goto out; //print switch_code statement & newline >> >> Leftover development comment? (There's at least one more.) > > Yes and no, the comment came from elsewhere in the file Did it? > and early in > development it I place it here to later decide if it should stay (and > get converted into a compliant comment). I will drop it in the next > iteration. Thanks. >>> + } >>> + else >> >> Please avoid "else" after an if() that ends in "return", "goto", or >> alike. > > Really? How would you propose handling common finalization when > completion happens during the execution of two branches of the logical > purpose of the function? Do you want to see two separate if statements > of `if ( condition A )` and `if ( ! condition A )`? What would you need the 2nd if() for when the first one ends in "return", "goto", or alike? >>> + { >>> + for_each_domain(next) >> >> What guarantees that the list won't change behind your back? You don't >> hold domlist_read_lock here afaict. It might be that you're safe because >> that lock is an RCU one and this function is only invoked at init time >> or from some form of interrupt handler. But that's far from obvious and >> will hence need both properly confirming and stating in a comment. (It >> is actually this concern, iirc, which so far had us avoid iterating the >> domain list here.) > > It is better to error on the side of caution instead of assuming this > will always be invoked in a safe manner. I will add a read lock for the > domain list. I'm not firm enough in RCU to be certain whether acquiring that lock is permissible here. >>> + { >>> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >>> + { >>> + console_rx = next->domain_id + 1; >>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>> + goto out; //print switch_code statement & newline >>> + } >>> + } >>> >>> - if ( next_rx++ >= max_console_rx ) >>> + console_rx = 0; >>> + printk("*** Serial input to Xen"); >>> + goto out; >>> + } >>> + } >>> + >>> + for ( next = rcu_dereference(d->next_in_list); next != NULL; >>> + next = rcu_dereference(next->next_in_list) ) >> >> This looks like an open-coded continuation of for_each_domain() - I'm >> afraid I'm wary of introducing anything like this. > > Not exactly, for_each_domain() always starts with beginning of the > domain list and walks from that point forward. Right, hence my use of the word "continuation". > This open coded version > stats at domain d and walks from there to the end of the list. Which is > why there is logic below, which uses for_each_domain(), to walk from the > beginning of the list until the next domain with console_io or the > hardware domain, whichever occurs first. > > What I did not want to do is potentially waste a lot of cycles doing > for_each_domain() with a continue until it reached the current domain > and then start checking for the privilege. > > I could take this and introduce a new macro, for_each_domain_from (or a > better name if there are suggestions) and use it here. That's effectively what I would like to be done, yes. >>> + { >>> + if ( hardware_domain && next == hardware_domain ) >>> { >>> console_rx = 0; >>> printk("*** Serial input to Xen"); >>> - break; >>> + goto out; >> >> Since you use "goto" anyway, this wants introducing a 2nd label (maybe >> "xen"?) ahead of the identical code you add further down (immediately >> ahead of the "out" label), to avoid code duplication. > > Ack. > >>> } >>> >>> - d = rcu_lock_domain_by_id(next_rx - 1); >>> - if ( d ) >>> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >>> { >>> - rcu_unlock_domain(d); >>> - console_rx = next_rx; >>> - printk("*** Serial input to DOM%u", next_rx - 1); >>> - break; >>> + console_rx = next->domain_id + 1; >>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>> + goto out; >>> + } >>> + } >>> + >>> + /* >>> + * Hit the end of the domain list and instead of assuming that the >>> + * hardware domain is the first in the list, get the first domain >>> + * in the domain list and then if it is not the hardware domain or >>> + * does not have console privilege, iterate the list until we find >>> + * the hardware domain or a domain with console privilege. >>> + */ >>> + if ( next == NULL ) >>> + { >>> + for_each_domain(next) >>> + { >>> + if ( hardware_domain && next == hardware_domain ) >>> + { >>> + console_rx = 0; >>> + printk("*** Serial input to Xen"); >>> + goto out; >>> + } >>> + >>> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >>> + { >>> + console_rx = next->domain_id + 1; >>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>> + goto out; >>> + } >>> } >>> } >>> >>> + /* >>> + * If we got here, could not find a domain with console io privilege. >>> + * Default to Xen. >>> + */ >> >> "Default to" is a little odd when there are no other options. > > Fallback to? Yes. >>> @@ -538,31 +594,37 @@ static void __serial_rx(char c, struct cpu_user_regs *regs) >>> * getting stuck. >>> */ >>> send_global_virq(VIRQ_CONSOLE); >>> - break; >>> - >>> -#ifdef CONFIG_SBSA_VUART_CONSOLE >>> - default: >>> + } >>> + else >>> { >>> - struct domain *d = rcu_lock_domain_by_id(console_rx - 1); >>> + struct domain *d = rcu_lock_domain_by_any_id(CON_RX_DOMID); >>> >>> + if ( d == NULL ) >>> + goto unlock_out; >>> + >>> +#ifdef CONFIG_SBSA_VUART_CONSOLE >>> /* >>> * If we have a properly initialized vpl011 console for the >>> * domain, without a full PV ring to Dom0 (in that case input >>> * comes from the PV ring), then send the character to it. >>> */ >>> - if ( d != NULL && >>> - !d->arch.vpl011.backend_in_domain && >>> + if ( !d->arch.vpl011.backend_in_domain && >>> d->arch.vpl011.backend.xen != NULL ) >>> + { >>> vpl011_rx_char_xen(d, c); >>> - else >>> - printk("Cannot send chars to Dom%d: no UART available\n", >>> - console_rx - 1); >>> + goto unlock_out; >>> + } >>> +#endif >>> + >>> + if ( (serial_rx_prod - serial_rx_cons) != SERIAL_RX_SIZE ) >>> + serial_rx_ring[SERIAL_RX_MASK(serial_rx_prod++)] = c; >> >> This is Dom0's buffer; I don't think sharing with DomU-s is correct. > > I would disagree, it is the hypervisor's buffer that it decides to share > with domains it trust. It just so happens that it always trusts the > hardware domain. This is why I explicitly changed this to the XSM call, > to express that when the system manager, by enabling this privilege on > the domain, has decided to trust these domains to have access to the > hypervisor's buffer. I don't think such trust can be assumed to allow the domains to see e.g. each others root passwords. >>> @@ -717,6 +779,8 @@ long do_console_io( >>> rc = -E2BIG; >>> if ( count > INT_MAX ) >>> break; >>> + if ( CON_RX_DOMID != current->domain->domain_id ) >>> + return 0; >>> >>> rc = 0; >>> while ( (serial_rx_cons != serial_rx_prod) && (rc < count) ) >> >> ... assume that by the time this hypercall is invoked input focus >> hasn't switched. I think there's no way around a per-domain input >> buffer, which of course would need setting up only for console-io- >> capable domains. > > Let's explore the exact concern here, the scenarios as far as I can see > it is as follows. > > A person at the serial/console types keys for the current console domain > (domA), then enters the console switch sequence, switching to another > domain (domB). DomA's CONSOLEIO_read hypercall arrives after the switch > and thus is not sent the rx buffer contents. Then domB's CONSOLEIO_read > arrives and then because `serial_rx_cons` and `serial_rx_prod` are not > the same, domB is sent the bytes that were intended for domA. > > While a per domain console_io buffer would address this issue, I believe > there is a simpler solution that can be extended depending on whether it > is acceptable for the undelivered bytes to be dropped or not. > > Simply upon switching, if serial_rx_cons and serial_rx_prod are set the > same, then no bytes will be leaked to domB from domA above. An extra > precaution could be taken to zero the serial_rx buffer. If guaranteed > delivery is desired, a list of buffer remnants could be drained on > hypercall and console switching. > > IMHO I believe the reality is while there is potential that the scenario > could happen, the probability is low. Doing a per domain buffer will > always incur the resource overhead even if the event never happens, > while the above approach would only incur the resource overhead when the > situation occurs. Which, afaict, would then result in stuff typed in for one domain being discarded, without there being any indication how much of it was discarded (and hence would need typing again). I don't share the resource concern: If an admin wants multiple domains to take input this way, they can't assume this comes at no price at all. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:58:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:58:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576481.902662 (Exim 4.92) (envelope-from ) id 1qRaig-0005Sh-3O; Thu, 03 Aug 2023 15:58:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576481.902662; Thu, 03 Aug 2023 15:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaig-0005SY-0E; Thu, 03 Aug 2023 15:58:34 +0000 Received: by outflank-mailman (input) for mailman id 576481; Thu, 03 Aug 2023 15:58:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaie-0005SO-KE for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:58:32 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96b613cb-3216-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 17:58:31 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691078305145440.71844765958383; Thu, 3 Aug 2023 08:58:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96b613cb-3216-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691078307; cv=none; d=zohomail.com; s=zohoarc; b=jBTmvow01AHF+vVYEiaumQ4VBM7Xqg3GDhID528w12gJ/KImu2W8xCUcvcGHuM7XrRGxK0/pKVWbEuUG8FjEg+p9S7XIE/64fipd/2OLTfoeZSd6mswvoXWnHCldAo+1OS13SHjNfUpIKvmvEnWi6d4jRzcmexTZlOBty9CIzoU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691078307; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=f/NEKVxmYeOoBO1Aj3ft9iK1B2vxUt4/FmnzD0CucWk=; b=FnpYAiTM2H69prk5J7Qp+1+GH/SOlN4vvH1ZwI/xIJj0UHtJEL/Lx2xxQmZaq6Sll+aDoODiBzeVO18Y8nGQmtXnIRpxPUeXf4PEpBqHKOhTSzDxqhqQe/Qf8IKRrWDvDlxWm8cbujEkFrk+BjjrMdtlejy9nwO8sN1zLk2ZKQQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691078307; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=f/NEKVxmYeOoBO1Aj3ft9iK1B2vxUt4/FmnzD0CucWk=; b=PwmSrlffQ2ISBk11TIAGxzyFxF4l3FagMe/GhcK80t5A0vaD50WU2u5VFZ0l9ZT7 76o6aToz6Bw9+nSfg6udiOcXVvTT53g1jDF33KZsvEhWwWsIYZhaKKoVT9y0/EKMZ8Z XvToCVLrd5EQphqaeyf8mdO+YdSeqxsD9oQPU6tM= Message-ID: Date: Thu, 3 Aug 2023 11:58:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 1/6] dom0: replace explict zero checks Content-Language: en-US To: Julien Grall , Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Nathan Studer , Stewart Hildebrand , Dario Faggioli , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-2-dpsmith@apertussolutions.com> <97319344-02d2-4fa4-9325-fbcd74364bdf@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/3/23 09:36, Julien Grall wrote: > Hi Daniel, Hey Julien, > On 03/08/2023 14:33, Daniel P. Smith wrote: >> On 8/2/23 03:46, Jan Beulich wrote: >>> On 01.08.2023 22:20, Daniel P. Smith wrote: >>>> A legacy concept is that the initial domain will have a domain id of >>>> zero. As a >>>> result there are places where a check that a domain is the inital >>>> domain is >>>> determined by an explicit check that the domid is zero. >>> >>> It might help if you at least outlined here why/how this is going to >>> change. >> >> Okay, I will try expanding on this further. >> >>>> --- a/xen/include/xen/sched.h >>>> +++ b/xen/include/xen/sched.h >>>> @@ -1058,6 +1058,13 @@ void scheduler_disable(void); >>>>   void watchdog_domain_init(struct domain *d); >>>>   void watchdog_domain_destroy(struct domain *d); >>>> +static always_inline bool is_initial_domain(const struct domain *d) >>>> +{ >>>> +    static int init_domain_id = 0; >>> >>> This may then also help with the question on why you use a static >>> variable here. (In any event the type of this variable wants to >>> be correct; plain int isn't appropriate ... >> >> Ah, so this is a dated patch that I brought because of the abstraction >> it made. The intent in the original series for making it static was in >> preparation to handle the shim case where init_domid() would have >> return a non-zero value. >> >> So the static can be dropped and changed to domid_t. > > Looking at one of the follow-up patch, I see: > >  static always_inline bool is_initial_domain(const struct domain *d) >  { > -    static int init_domain_id = 0; > - > -    return d->domain_id == init_domain_id; > +    return d->role & ROLE_UNBOUNDED_DOMAIN; >  } > > So is there any point to have the local variable? IOW, can't this simply > be "d->domain_id == 0"? Nope, you are right. All need for it drops with the static gone. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 15:59:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 15:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576483.902672 (Exim 4.92) (envelope-from ) id 1qRajQ-0005yT-BS; Thu, 03 Aug 2023 15:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576483.902672; Thu, 03 Aug 2023 15:59:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRajQ-0005yM-8o; Thu, 03 Aug 2023 15:59:20 +0000 Received: by outflank-mailman (input) for mailman id 576483; Thu, 03 Aug 2023 15:59:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRajO-0005yA-Tm for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 15:59:18 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0617.outbound.protection.outlook.com [2a01:111:f400:fe02::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b37741ad-3216-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 17:59:18 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9140.eurprd04.prod.outlook.com (2603:10a6:102:22f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 15:59:17 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 15:59:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b37741ad-3216-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VmgmtKrxcuRr/PnScp+m7TsSiaCCjl7U/jIbx2ZwtN7svkQQK0Whs0KPJ88VZMbfKo/YKTzVQ349epPBbKXX45FdaQaqvqgCZdTek7vuBOPSx1ms/2EkxbZhr3Ju/mvksn9nKQrSMmK02sCpNffETfZYgdy7WIGoPondbLOcgCu6JXD14Kg4CDXdkI2oSpk62Br3s3yoXCwQZw0quWwHQAwKorVPfmrk6X4aH/knYhgdb8tkBCBDM9xkcKHZObVGVb+ISOiyKqdwAGWb599Waezs0oz5Bv+UFaQ7A+6J8PfALo2BOzuLyYAbd074PnGPH9foJKsfS6KAhBV5w9WqZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6SrfcUFGcRPjielCLtr1T77oANmGnKGvI417IekLEVQ=; b=LuGGLSxbz9XdIO4zE6JRKCiCWekL2BYNpjhzJ8Fw3+RLBI6hjlewFuHE8ChN5Ty51FC81nDDZszz8XtB67CjieqT5/hEXOcyToUOCSeOTBE6cYDx4TKz944zaLbY3E/uzhlRGKb+hvm7knljluDkao+kcFLrHMHIiZdYWgTAD/bGMjuQ8mCS0AT7ofYDmOGYExvGUP6s7xl/4ZrS6IkzqE/cNX5prxcmnCQVTZA71GEg27BeBWyM7Jum9KTj4IFrElwrAEcdVLFSR+i1eIyTWMY15qMGtaiaF7StCpuP4lDLAjlmB00stF59JowLTCnbPGt0w6yYz6HB+QFGRxyO0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6SrfcUFGcRPjielCLtr1T77oANmGnKGvI417IekLEVQ=; b=EQDJ4J4SadG6QYJsOPHfY3tTTyfMmlTvWZ1VXXAM6rgfSXTbv9iIRYfG9A01sb6FHXNMLNNndrWcrW4avoEt6i7TrEYE6FwO6rd2VvZVdwtLVeGE8kDl8Vl+y1+/V7HzEsmLU9elT6iru1IN9ngFwQBTHRftXJe/WI8+XtjV1fy+Bj3Mh/T/zsnzSZuf/o3nnPIRo4mz8g++eU6yIJyrut9/Wahb3EyEqlnftcjGm59uA+n2cHk8UwHGCqGQSQ4DFCaPJ4e/hgzObNCNKH/8lKc8A9GEMgCL860Hak2prbA1oeoscExrcGhvt6ww4A8zL89w/d2aeEMO6JECyeJpkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 3 Aug 2023 17:59:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 6/6] capabilities: convert attach debugger into a capability Content-Language: en-US To: "Daniel P. Smith" Cc: Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Jun Nakajima , Kevin Tian , Stefano Stabellini References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-7-dpsmith@apertussolutions.com> <2a651c80-7e44-1ff9-bb63-989605960c72@apertussolutions.com> From: Jan Beulich In-Reply-To: <2a651c80-7e44-1ff9-bb63-989605960c72@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9140:EE_ X-MS-Office365-Filtering-Correlation-Id: 51596be4-8036-462c-646a-08db943a9725 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KsEHdBs6PAAsymZDnyLU7J3Y/oXt1Hdg/fYX8n2CkugvJUagGJxALfi8/dHJxE8rCfkbOaIxA3dhyPRqrQ1+z0xDnuQedsJO7Gh6b5F/SG9nJ0MYuyoVNaNNAcF6RwE00HdahfVGrqUy4HKvQcy0NaDZcUICYuOqDwm0C4y6BVAlCeY6QWYhO9p0ZF+Zl7xYLe+t76ATRGXbtJBDqK8K3chOVulemNXC+BE1p8NpdN6x3QztA27zvmZ6hl1p61PDazO+qWro9Q1/DPZOBjJzXvlQ5K6cs3zpvQVmM4BHxzK3OQC04IH0l2X96y26UDymV7kydpAyccYp+iQIQ2px6c16HaKTVFIYAevJ4IIv2R2wLk+zA0jPNAYWecU773yyCIGUlTkwwMF0G+gu2ju96ESBrYHMBtj092UfI5N+e4wQN9cpdM0xlOj7zRPNHcZyarjE3kTBHTu28858oToifZhlhiJou0At+7AGVbygyPX+xlVaA7YA4j7xG0Eg9u+EscZBx4+hSbGSvfDc/0GKaOAOLqi75/UQxODeSZ6JQmxJIYLk+k85J5vjTs+53rbS35c9xQbFDaEmQrhQcWsjOmDs9OZ73eMgeoB40ADUSbONfuU3d485sMGhbF1q8TXRhgNJs0NFEk4TGYhn10Tbuw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199021)(66556008)(41300700001)(6916009)(316002)(2906002)(66946007)(4326008)(66476007)(8936002)(8676002)(5660300002)(26005)(36756003)(53546011)(186003)(6506007)(86362001)(2616005)(31696002)(38100700002)(478600001)(6512007)(54906003)(6486002)(7416002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WitkaGJXcUxCbjhlODMxdGg3Sm5XQ2djNXNJRUFTLzFWYWxmVk1zdDRMd1ZO?= =?utf-8?B?L3RmVXZZZkszMHhFSUgxN2JXTFdGTHlCdkc4eVdRRjZIOHhhU3p5NHJGWVpw?= =?utf-8?B?Z0lxQzI4V0NqUHVKendHWTNNVi9kM01DZmV3ZDg5VituZEVuK0ZUbnZucS9v?= =?utf-8?B?OFdXQ2RzTlZiM08ybmtScXNMRCt0QStlNzlkVEU2aXNNZ3ppK2hEMzNrb2JP?= =?utf-8?B?R0Y0K0VlODJrQUl3MlZmZnVQc0pRUWJad1dWOVJkR203M2RURStnczJMRmVN?= =?utf-8?B?WS9VamdLL0RHcTZmQm8xUXIwM29tV3cyWUVFTEN1ckMwQ1ZKdnRYL055VTh5?= =?utf-8?B?RmhRNXhsQVkwY05TZnBqS3hsNHl0RUFiNHJEVk5NZ2NaVnRoRm8xL215SlpO?= =?utf-8?B?Q1NXVEJ6RmhHVWQrREt3eVdqTXR0aVFSQUVad25kaVpwSG92WWZqcmhIRDdV?= =?utf-8?B?anF5Q2oybFBJcURwTnFpSE9aYmJUbmkwRFlPSjVxWmtHblEzMDlLQkZ6cm1l?= =?utf-8?B?aU9meFI3MmtReko0VE9xWC8xWHg0WHhjcDNCei9iQTNPdldzd01zTlJJTVhU?= =?utf-8?B?NDZZSUNzcEdGQ3FhVmlZdUxVVXhYcHhCbDVWTzVUVHpFMEJpM1BGS0pMSHNi?= =?utf-8?B?Y3pUQkdSMUhhZS96N05mbUJxWXcyNXdJRWJvSlpTZFJnSXRwaVBCaUExeU13?= =?utf-8?B?elNydWl3YjVjazZjNVhuOFZRQWNyU0xXUGJlVXUrRThrYnlyVlVIcDd4VmJl?= =?utf-8?B?cHFuaU5qSnN4Q01PR0FzVW5aTjhRZFgwUVVVYi9VZWhDa3Zwa3JPK1JBQ21x?= =?utf-8?B?MFRRTElLb2s3ME13OWFhZkQ5aXZnaVVwWEN2WVM5ZXpoNHNpZ0o4eHQyRnRF?= =?utf-8?B?TWM5Q2lxUVdEdTdHaXNUbmxFdnltaWVWODZvQXRYRXFwVk1EZ2pFMjZTZEtx?= =?utf-8?B?ZnNVWS9MTndRYkRhOVRhVDJHUWxLNFBQWDJLQzl3cFJNYmFLeU5wS0d6eWk5?= =?utf-8?B?Rlp3R3FMSngyZFNGSWlpdmc2Y0E3WlM5WVM5ZW9QcnlIQ3FrcFJiYTFaZkVo?= =?utf-8?B?bk1zK0RsUEp0V0I5c0N5emsvdVQxWDQ3dmUrUkVtUU05NFMweEZOa0tzRFA4?= =?utf-8?B?RUh6ckxFUDlubCtSWVZDRy9FWG96NUV0K3A0VGdwTmhBVUZvamQ0MjVxOTRJ?= =?utf-8?B?bkpyQytFcVg1WTN6U2QvdWI4cStBeWxrSENZeGRIbW43R2VNMFB2UDVabklF?= =?utf-8?B?VDVUZnhmelZWaWtUL3lUSXo0MWtUdzd6RE1CV3BNMUFWZElnYkJvU2RGV0Fl?= =?utf-8?B?cnpNeGJSYVV6d1F3UGtQMm5qMkFVcTlJL2o4UHRPNWVVWURLQWIrQ2hNNFda?= =?utf-8?B?emNSNC8wQ2QrZHR0cXZCUGd6c2FJeXNuVUprZkVKM1ZSNWVRUjM1OGx3UjNQ?= =?utf-8?B?cnA1UmdHVkg2MW5DbnUyTlU5QjFVL2t3dUlCWFZ6clp4Y0lBZFJGUlZ0bkl0?= =?utf-8?B?NFRlU3lzTDFHL1ROVGJqQlNxRnZHeitzYkJHQ1pDaVViLzNia3Mxc1hvQ0pF?= =?utf-8?B?aHJETnR0bzQxSGVPeGJqbFBxdzhnTlVhUjlaUW5TSG5lYWIzbzQwQjVvNWJN?= =?utf-8?B?RlRTbEVHS0FENU9CdE5wd2dubkhOQzVwek04UFRpZXcvS1ZuM215WWJQdUZn?= =?utf-8?B?eWZlS2puWE9NR3Z5RDBTaW1yWGp4VDRZUWtIM0Q5RDZsSDhvZFVZQmowa0NW?= =?utf-8?B?V2g2ek5CRUswVnBJcDNwL3JlTXBnVkhtT0dveWZTeGZzL2gwTm1HZUdaeEkx?= =?utf-8?B?YTdjZVBJZ2dPeVNjUzRoV01PTVdvMm55MGZ3Z2dSUFJZMklDUUlBOUhobzkv?= =?utf-8?B?S1gzNnhZNmNJVGoxMVZreTRCWXh4SHdFQW1IQWV1SHh5Mnp2ajhrNDNLcHB1?= =?utf-8?B?TFNyRzJNY0x3MVU3T1ZWWkVrTksxWk1ManBZTU85ZlpCM2phZkdKMDhRK0hV?= =?utf-8?B?dWJZYWl6em9HZXM4RFRBclRVN3drV24yWFVmdUVrQ2xoZVlIdzJqNGxLUE5s?= =?utf-8?B?VS91cFRxcFRnaUV4MlF0SFkxOUFpQkQzWkNpdVQya0VBenloNzAySlBFeVYw?= =?utf-8?Q?ZwB8LSbPohJyxmmdsDOVq+B3a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51596be4-8036-462c-646a-08db943a9725 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 15:59:16.8796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DNM8bU1PJuyXST94Ln/u4wtJUu5hmkg873Z2lwaxRfEBIHPjyXgR4X0SXtiAujEFVVXBlss86gOVl2Y39+GhOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9140 On 03.08.2023 17:52, Daniel P. Smith wrote: > On 8/1/23 21:06, Stefano Stabellini wrote: >> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -474,9 +474,8 @@ struct domain >>> uint8_t role; >>> #define CAP_CONSOLE_IO (1U<<0) >>> #define CAP_DISABLE_CPU_FAULT (1U<<1) >>> - uint8_t capabilities; >>> - /* Is this guest being debugged by dom0? */ >>> - bool debugger_attached; >>> +#define CAP_DEBUGGER_ATTACH (1U<<2) >>> + uint16_t capabilities; >> >> No need to switch to uint16_t just yet? > > I know space is tight in struct domain, wanted to reclaim the freed > space into capabilities (or roles). One thing I was considering if > enough space could be found is instead replace it all with a pointer to > a new struct that held these values. It would allow using heap space and > future growth of the structure. As of this patch, it is consuming 5 > bytes and would need to find an additional 3 bytes. Is there a > willingness to entertain such an approach? Usually we do such conversion when data belonging to a subsystem (for lack of a better term) grows big enough, not right away when eventual data size isn't even known yet. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:04:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:04:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576490.902681 (Exim 4.92) (envelope-from ) id 1qRanq-00082J-UT; Thu, 03 Aug 2023 16:03:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576490.902681; Thu, 03 Aug 2023 16:03:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRanq-00082C-RO; Thu, 03 Aug 2023 16:03:54 +0000 Received: by outflank-mailman (input) for mailman id 576490; Thu, 03 Aug 2023 16:03:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRanp-000826-24 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:03:53 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5556c0d9-3217-11ee-b268-6b7b168915f2; Thu, 03 Aug 2023 18:03:50 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691078625504929.2837018516593; Thu, 3 Aug 2023 09:03:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5556c0d9-3217-11ee-b268-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691078626; cv=none; d=zohomail.com; s=zohoarc; b=DS13iNruZ74gob5JuEF9R9LJzhD6wYpKT7t2OgFNe/pQd3Yqr/3uXzF8//twWhKnAhKUVFMT0HGz+Rr9sGrszOeUqrkBh2Rr4pwRxcbcwALjkkyQ3D9aPuqzBkjA+FHD3jdXn/9WCUYY30pTN+DENQeY7rJtF4ro5zhfoesk0A8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691078626; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ae4dbcHbi3OyPMm8c1f1Dt7aSpjgiQa8dQIIotDjUCc=; b=kXK7aLvPRaxySO3cqlzk9ZwN6iU0phOaeJvVQUcW+waoSLl4h30NCYmKQoLyzRvPRnkBmzDzdJ0SMnvv9qmFayc0H6JmJ3dFOJfatYgnO05tu5YsCTisoe3b7VLVnmPWBFrmgTJ+Cb/MsGIvAGm/7hnGEchrCAN4rChMTMGi97s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691078626; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ae4dbcHbi3OyPMm8c1f1Dt7aSpjgiQa8dQIIotDjUCc=; b=ZtptUgi1q5WO92dmAXdxKKYfXz4cLKardfsCQUNLCGFNO/ZKUQs5G1EK3JnXo35C eAh19Q5oxun/tJ/YHxdBG/rZdm0gWLAsUI/1e3GtNQW8FQHmSoAKwkrQtMpwO9bNpMp 4m8zESqhg/U32M099eB9mWA78rxiQYVSpV23VmgE= Message-ID: Date: Thu, 3 Aug 2023 12:03:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC 6/6] capabilities: convert attach debugger into a capability Content-Language: en-US To: Jan Beulich Cc: Wei Liu , xen-devel@lists.xenproject.org, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Jun Nakajima , Kevin Tian , Stefano Stabellini References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-7-dpsmith@apertussolutions.com> <2a651c80-7e44-1ff9-bb63-989605960c72@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 11:59, Jan Beulich wrote: > On 03.08.2023 17:52, Daniel P. Smith wrote: >> On 8/1/23 21:06, Stefano Stabellini wrote: >>> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>>> --- a/xen/include/xen/sched.h >>>> +++ b/xen/include/xen/sched.h >>>> @@ -474,9 +474,8 @@ struct domain >>>> uint8_t role; >>>> #define CAP_CONSOLE_IO (1U<<0) >>>> #define CAP_DISABLE_CPU_FAULT (1U<<1) >>>> - uint8_t capabilities; >>>> - /* Is this guest being debugged by dom0? */ >>>> - bool debugger_attached; >>>> +#define CAP_DEBUGGER_ATTACH (1U<<2) >>>> + uint16_t capabilities; >>> >>> No need to switch to uint16_t just yet? >> >> I know space is tight in struct domain, wanted to reclaim the freed >> space into capabilities (or roles). One thing I was considering if >> enough space could be found is instead replace it all with a pointer to >> a new struct that held these values. It would allow using heap space and >> future growth of the structure. As of this patch, it is consuming 5 >> bytes and would need to find an additional 3 bytes. Is there a >> willingness to entertain such an approach? > > Usually we do such conversion when data belonging to a subsystem (for lack > of a better term) grows big enough, not right away when eventual data size > isn't even known yet. Right and if there is a desire to instead follow the suggestion in my reply to Stefano on patch 4, that approach could be sizeable. Larger than 40 bits/flags, that I am less confident about. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:13:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:13:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576494.902691 (Exim 4.92) (envelope-from ) id 1qRaxG-00017S-Od; Thu, 03 Aug 2023 16:13:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576494.902691; Thu, 03 Aug 2023 16:13:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaxG-00017L-M9; Thu, 03 Aug 2023 16:13:38 +0000 Received: by outflank-mailman (input) for mailman id 576494; Thu, 03 Aug 2023 16:13:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRaxE-00017F-VQ for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:13:36 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b14c09b2-3218-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 18:13:34 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 373GDIOM012990 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 3 Aug 2023 12:13:24 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 373GDINx012989; Thu, 3 Aug 2023 09:13:18 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b14c09b2-3218-11ee-8613-37d641c3527e Date: Thu, 3 Aug 2023 09:13:18 -0700 From: Elliott Mitchell To: Jan Beulich Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing Message-ID: References: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: > > Some of the patches looks to have been posted previously as a 7-patch > series. It would have been nice if therefore this one was marked as > v2, indicating in a revision log what the differences are. It appears > as if at least one out of those 7 earlier patches was dropped (or > maybe assimilated into another one). Indeed. Problem is several tags could potentially have been used. Should I have used all of them simultaneously? Should I have used only some of them? Which subset? Several were mildly adjusted, so it could have been marked "v2". No one responded at all to the previous round, so this could have been marked "RESEND". Yet the refinements and general changes are large enough for the series to be pretty distinct. I didn't know which way to go, so with no idea which option to choose the last one ended up winning out. Perhaps that was wrong yet I've still no feedback on the actual patches. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:31:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576499.902702 (Exim 4.92) (envelope-from ) id 1qRbEp-0003bL-8p; Thu, 03 Aug 2023 16:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576499.902702; Thu, 03 Aug 2023 16:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbEp-0003bE-5S; Thu, 03 Aug 2023 16:31:47 +0000 Received: by outflank-mailman (input) for mailman id 576499; Thu, 03 Aug 2023 16:31:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbEo-0003b8-FD for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:31:46 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a45c96f-321b-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 18:31:43 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691080286751321.3099317106778; Thu, 3 Aug 2023 09:31:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a45c96f-321b-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691080290; cv=none; d=zohomail.com; s=zohoarc; b=WVHNIahXX+GyVajL5NI51z36PbD/JrB3dgqBOfR9tihW2x7FOF7x+QT+CEXEmY6fKzAziwuIHfvR2tgYE9MW9TZOAoSX0mL6pCobcektt5Hjat2oeCAGXuDlCNXPIXn0NibJat286ab+jtXWSvpDjXOEoPUZ/mlz1Jj92tJGGN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691080290; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2IueEmUBVFP14XKk2kgZbf4NNlgHXOu+R/AxWuAEvX0=; b=ickL2eKuJxKLAmnlL71CUzHyu9WuymrOLcllvNA+2SMi6FW4ZjJPVGmIrEOE0E9gEP//WHVGdm8n1Xx0bvRm7sfuTswEXo/FzzvPssOw2iYcZM5yks3pmrj7/jJ9mMwuX1hS+UQ6QIfhdPAKtWR+XyiC/vJpkkAyfCWo4pE+r7s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691080290; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=2IueEmUBVFP14XKk2kgZbf4NNlgHXOu+R/AxWuAEvX0=; b=WN8GP32BpJgKun7AUvqxf/JYxLyX5qCoJfFR5e5oDelX2m7xnGGezRu71UQdh+au +vIOlSCH4MN+tYqiDPP0sG8Wf8eO6bq3kv3Ag+N/WuM9F/yC6P1OuI/M+qKjB2RFFZn B/wqGTzb3bwezcGWN8Lf/32rjNJqfIEmrhCGczf8= Message-ID: Date: Thu, 3 Aug 2023 12:31:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: Jan Beulich Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> <01a80d4c-f19b-98ec-805e-e648e752d6b1@suse.com> From: "Daniel P. Smith" In-Reply-To: <01a80d4c-f19b-98ec-805e-e648e752d6b1@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 11:56, Jan Beulich wrote: > On 03.08.2023 14:56, Daniel P. Smith wrote: >> On 8/2/23 07:01, Jan Beulich wrote: >>> On 01.08.2023 18:06, Daniel P. Smith wrote: >>>> + if ( hardware_domain ) >>>> + { >>>> + console_rx = hardware_domain->domain_id + 1; >>>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>> >>> Here and elsewhere - why %d when original code properly used %u? I also >>> think there are now quite a few too many of these all identical >>> printk()s. >> >> Good question, I did not write the line, it was copy/paste from >> elsewhere in the file and then continued to replicate from there. > > There's exactly one such line right now, using DOM%u. If I'm not > mistaken, it's not all that long ago that this was changed, so I > would suspect an incomplete rebase. > >>>> + goto out; //print switch_code statement & newline >>> >>> Leftover development comment? (There's at least one more.) >> >> Yes and no, the comment came from elsewhere in the file > > Did it? I thought it did. >> and early in >> development it I place it here to later decide if it should stay (and >> get converted into a compliant comment). I will drop it in the next >> iteration. > > Thanks. No problem. >>>> + } >>>> + else >>> >>> Please avoid "else" after an if() that ends in "return", "goto", or >>> alike. >> >> Really? How would you propose handling common finalization when >> completion happens during the execution of two branches of the logical >> purpose of the function? Do you want to see two separate if statements >> of `if ( condition A )` and `if ( ! condition A )`? > > What would you need the 2nd if() for when the first one ends in "return", > "goto", or alike? Good point, not sure why I wasn't thinking this way. >>>> + { >>>> + for_each_domain(next) >>> >>> What guarantees that the list won't change behind your back? You don't >>> hold domlist_read_lock here afaict. It might be that you're safe because >>> that lock is an RCU one and this function is only invoked at init time >>> or from some form of interrupt handler. But that's far from obvious and >>> will hence need both properly confirming and stating in a comment. (It >>> is actually this concern, iirc, which so far had us avoid iterating the >>> domain list here.) >> >> It is better to error on the side of caution instead of assuming this >> will always be invoked in a safe manner. I will add a read lock for the >> domain list. > > I'm not firm enough in RCU to be certain whether acquiring that lock is > permissible here. Same and I took your statements to suggest that I should. >>>> + { >>>> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >>>> + { >>>> + console_rx = next->domain_id + 1; >>>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>>> + goto out; //print switch_code statement & newline >>>> + } >>>> + } >>>> >>>> - if ( next_rx++ >= max_console_rx ) >>>> + console_rx = 0; >>>> + printk("*** Serial input to Xen"); >>>> + goto out; >>>> + } >>>> + } >>>> + >>>> + for ( next = rcu_dereference(d->next_in_list); next != NULL; >>>> + next = rcu_dereference(next->next_in_list) ) >>> >>> This looks like an open-coded continuation of for_each_domain() - I'm >>> afraid I'm wary of introducing anything like this. >> >> Not exactly, for_each_domain() always starts with beginning of the >> domain list and walks from that point forward. > > Right, hence my use of the word "continuation". Ah. okay. >> This open coded version >> stats at domain d and walks from there to the end of the list. Which is >> why there is logic below, which uses for_each_domain(), to walk from the >> beginning of the list until the next domain with console_io or the >> hardware domain, whichever occurs first. >> >> What I did not want to do is potentially waste a lot of cycles doing >> for_each_domain() with a continue until it reached the current domain >> and then start checking for the privilege. >> >> I could take this and introduce a new macro, for_each_domain_from (or a >> better name if there are suggestions) and use it here. > > That's effectively what I would like to be done, yes. Okay, unless you (or anyone else) have another name suggestion, I will add it as the above name. >>>> + { >>>> + if ( hardware_domain && next == hardware_domain ) >>>> { >>>> console_rx = 0; >>>> printk("*** Serial input to Xen"); >>>> - break; >>>> + goto out; >>> >>> Since you use "goto" anyway, this wants introducing a 2nd label (maybe >>> "xen"?) ahead of the identical code you add further down (immediately >>> ahead of the "out" label), to avoid code duplication. >> >> Ack. >> >>>> } >>>> >>>> - d = rcu_lock_domain_by_id(next_rx - 1); >>>> - if ( d ) >>>> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >>>> { >>>> - rcu_unlock_domain(d); >>>> - console_rx = next_rx; >>>> - printk("*** Serial input to DOM%u", next_rx - 1); >>>> - break; >>>> + console_rx = next->domain_id + 1; >>>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>>> + goto out; >>>> + } >>>> + } >>>> + >>>> + /* >>>> + * Hit the end of the domain list and instead of assuming that the >>>> + * hardware domain is the first in the list, get the first domain >>>> + * in the domain list and then if it is not the hardware domain or >>>> + * does not have console privilege, iterate the list until we find >>>> + * the hardware domain or a domain with console privilege. >>>> + */ >>>> + if ( next == NULL ) >>>> + { >>>> + for_each_domain(next) >>>> + { >>>> + if ( hardware_domain && next == hardware_domain ) >>>> + { >>>> + console_rx = 0; >>>> + printk("*** Serial input to Xen"); >>>> + goto out; >>>> + } >>>> + >>>> + if ( xsm_console_io(XSM_OTHER, next, CONSOLEIO_read) == 0 ) >>>> + { >>>> + console_rx = next->domain_id + 1; >>>> + printk("*** Serial input to DOM%d", CON_RX_DOMID); >>>> + goto out; >>>> + } >>>> } >>>> } >>>> >>>> + /* >>>> + * If we got here, could not find a domain with console io privilege. >>>> + * Default to Xen. >>>> + */ >>> >>> "Default to" is a little odd when there are no other options. >> >> Fallback to? > > Yes. Ack. >>>> @@ -538,31 +594,37 @@ static void __serial_rx(char c, struct cpu_user_regs *regs) >>>> * getting stuck. >>>> */ >>>> send_global_virq(VIRQ_CONSOLE); >>>> - break; >>>> - >>>> -#ifdef CONFIG_SBSA_VUART_CONSOLE >>>> - default: >>>> + } >>>> + else >>>> { >>>> - struct domain *d = rcu_lock_domain_by_id(console_rx - 1); >>>> + struct domain *d = rcu_lock_domain_by_any_id(CON_RX_DOMID); >>>> >>>> + if ( d == NULL ) >>>> + goto unlock_out; >>>> + >>>> +#ifdef CONFIG_SBSA_VUART_CONSOLE >>>> /* >>>> * If we have a properly initialized vpl011 console for the >>>> * domain, without a full PV ring to Dom0 (in that case input >>>> * comes from the PV ring), then send the character to it. >>>> */ >>>> - if ( d != NULL && >>>> - !d->arch.vpl011.backend_in_domain && >>>> + if ( !d->arch.vpl011.backend_in_domain && >>>> d->arch.vpl011.backend.xen != NULL ) >>>> + { >>>> vpl011_rx_char_xen(d, c); >>>> - else >>>> - printk("Cannot send chars to Dom%d: no UART available\n", >>>> - console_rx - 1); >>>> + goto unlock_out; >>>> + } >>>> +#endif >>>> + >>>> + if ( (serial_rx_prod - serial_rx_cons) != SERIAL_RX_SIZE ) >>>> + serial_rx_ring[SERIAL_RX_MASK(serial_rx_prod++)] = c; >>> >>> This is Dom0's buffer; I don't think sharing with DomU-s is correct. >> >> I would disagree, it is the hypervisor's buffer that it decides to share >> with domains it trust. It just so happens that it always trusts the >> hardware domain. This is why I explicitly changed this to the XSM call, >> to express that when the system manager, by enabling this privilege on >> the domain, has decided to trust these domains to have access to the >> hypervisor's buffer. > > I don't think such trust can be assumed to allow the domains to see e.g. > each others root passwords. Should or can are two different things, it does not change the fact what the action is being done here. Another aspect here to your "what if" is the question of what really is the likelihood that an admin is going to enter the root password and then send the console switch immediately to another domain via the serial interface on a production system that they made the conscious decision to trust an untrustworthy domain with the a highly trusted privilege of serial/console access. >>>> @@ -717,6 +779,8 @@ long do_console_io( >>>> rc = -E2BIG; >>>> if ( count > INT_MAX ) >>>> break; >>>> + if ( CON_RX_DOMID != current->domain->domain_id ) >>>> + return 0; >>>> >>>> rc = 0; >>>> while ( (serial_rx_cons != serial_rx_prod) && (rc < count) ) >>> >>> ... assume that by the time this hypercall is invoked input focus >>> hasn't switched. I think there's no way around a per-domain input >>> buffer, which of course would need setting up only for console-io- >>> capable domains. >> >> Let's explore the exact concern here, the scenarios as far as I can see >> it is as follows. >> >> A person at the serial/console types keys for the current console domain >> (domA), then enters the console switch sequence, switching to another >> domain (domB). DomA's CONSOLEIO_read hypercall arrives after the switch >> and thus is not sent the rx buffer contents. Then domB's CONSOLEIO_read >> arrives and then because `serial_rx_cons` and `serial_rx_prod` are not >> the same, domB is sent the bytes that were intended for domA. >> >> While a per domain console_io buffer would address this issue, I believe >> there is a simpler solution that can be extended depending on whether it >> is acceptable for the undelivered bytes to be dropped or not. >> >> Simply upon switching, if serial_rx_cons and serial_rx_prod are set the >> same, then no bytes will be leaked to domB from domA above. An extra >> precaution could be taken to zero the serial_rx buffer. If guaranteed >> delivery is desired, a list of buffer remnants could be drained on >> hypercall and console switching. >> >> IMHO I believe the reality is while there is potential that the scenario >> could happen, the probability is low. Doing a per domain buffer will >> always incur the resource overhead even if the event never happens, >> while the above approach would only incur the resource overhead when the >> situation occurs. > > Which, afaict, would then result in stuff typed in for one domain being > discarded, without there being any indication how much of it was discarded > (and hence would need typing again). Again, I find the scenario unlikely but agree that good behavior is not to have a lossy console. That is why I suggested that a simple list (or other representation) of pending buffer fragments can be held for deliver to previous domains. > I don't share the resource concern: If an admin wants multiple domains > to take input this way, they can't assume this comes at no price at all. Except its not just the admins that pay the price. I had already considered a per domain buffer, but realized that this is a more complicated approach requiring code in multiple places within the hypervisor. Whereas I believe the proposal above can exist solely within console.c and will not require having to hook in to domain create/destruction. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:34:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:34:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576503.902711 (Exim 4.92) (envelope-from ) id 1qRbHd-0004DW-RC; Thu, 03 Aug 2023 16:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576503.902711; Thu, 03 Aug 2023 16:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbHd-0004DP-OQ; Thu, 03 Aug 2023 16:34:41 +0000 Received: by outflank-mailman (input) for mailman id 576503; Thu, 03 Aug 2023 16:34:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbHc-0004DH-Ry for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:34:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbHV-0003rn-Iv; Thu, 03 Aug 2023 16:34:33 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRbHV-00074k-AZ; Thu, 03 Aug 2023 16:34:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dvvBXxjniH/IlgE1ej5FHuyiI4F6RPdmj66rQM7XZek=; b=xd7pmytFP9/Dgy0tf8IZUqmY/g +jy1eMy/ld8p6q6ODKP4I8OX1RP5bUaVmWRYrndZ7gXvb10apbXICtqfuFXuhjc47Q1S7a3yMrPkQ C4E2vtom8ofGCyfdhaJCINuuTrfApqslh3+Mv98PHuz/Ys6y61ehhblCak92Mp04h15o=; Message-ID: <8074634d-fd76-43fc-8e0f-4c3a70ea5360@xen.org> Date: Thu, 3 Aug 2023 17:34:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing Content-Language: en-GB To: Elliott Mitchell , Jan Beulich Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Elliott, On 03/08/2023 17:13, Elliott Mitchell wrote: > On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: >> >> Some of the patches looks to have been posted previously as a 7-patch >> series. It would have been nice if therefore this one was marked as >> v2, indicating in a revision log what the differences are. It appears >> as if at least one out of those 7 earlier patches was dropped (or >> maybe assimilated into another one). > > Indeed. Problem is several tags could potentially have been used. > Should I have used all of them simultaneously? Should I have used only > some of them? Which subset? > > Several were mildly adjusted, so it could have been marked "v2". > > No one responded at all to the previous round, so this could have been > marked "RESEND". > > Yet the refinements and general changes are large enough for the series > to be pretty distinct. > > I didn't know which way to go, so with no idea which option to choose the > last one ended up winning out. Perhaps that was wrong yet I've still no > feedback on the actual patches. Not sure if this is related to the lack of answer. But I didn't receive any of your patches via xen-devel (I received your replies). Skimming through the bounce for the xenproject mail server, I noticed a lot of the following: host gmail-smtp-in.l.google.com [142.250.123.26] SMTP error from remote mail server after pipelined end of data: 550-5.7.1 This message is not RFC 5322 compliant. There are multiple Cc headers. 550-5.7.1 To reduce the amount of spam sent to Gmail, this message has been 550-5.7.1 blocked. Please visit 550 5.7.1 https://support.google.com/mail/?p=RfcMessageNonCompliant t7-20020a81e447000000b005839e8b595dsi12027284ywl.554 - gsmtp It might be possible that other mail server are not happy with your e-mails. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:37:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576507.902722 (Exim 4.92) (envelope-from ) id 1qRbKM-0004pe-B6; Thu, 03 Aug 2023 16:37:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576507.902722; Thu, 03 Aug 2023 16:37:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbKM-0004pX-6A; Thu, 03 Aug 2023 16:37:30 +0000 Received: by outflank-mailman (input) for mailman id 576507; Thu, 03 Aug 2023 16:37:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbKK-0004pL-G9 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:37:28 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 079ecf4c-321c-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 18:37:26 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fe45481edfso1267375e9.1 for ; Thu, 03 Aug 2023 09:37:26 -0700 (PDT) Received: from [192.168.23.238] (54-240-197-238.amazon.com. [54.240.197.238]) by smtp.gmail.com with ESMTPSA id e13-20020a05600c218d00b003fe2bea77ccsm310591wme.5.2023.08.03.09.37.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 09:37:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 079ecf4c-321c-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691080646; x=1691685446; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=vL19yjeY0vCMtRBqOHZepEaKWa9q/fOl1WB+ypjiWzo=; b=VswwiWhCpaAA/nAaW58Gl+e9P0fTofSI4xljCW1yc/tyfxUxSqCO/8TnkG9b3s3TQf yVKHWJ7oqE3q8d6zU4HKT30aNuIyOEez7KLgBkJkPgT9Z72abG1FkdMx+9vUq0w/1J7E R9DHrMHfP5ECNJc34nbO2gij2n2T2TY9oE1IT+5HnqG7PKztpgpiD3+45oLzXaeUFdZp D4/lt5VCvKrCiincpz6jiorfjuvzFt2FTEbqaIOGYjUlM7Pouw68jGkXuIQpvHqMGQBl 7bqH7a1JETEAYAY9uIP5I+n+3cCEnAn9HDkpGsm7K5fbbS6/d7FhG4Ysp7/u1avWKHMq oNwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691080646; x=1691685446; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vL19yjeY0vCMtRBqOHZepEaKWa9q/fOl1WB+ypjiWzo=; b=DFcOf42tNUJfXhBL8Z7uF3oGDxqCv9FMSZdcww8YKExMIw1e8pxZ3DYUUQX5tFdIq9 srWm2iv8MKEVzClXlD9RvnMit9oIaeg9nI9rmocCDrRulN7IlTcmYvXiUBxqA+j/iEoU FyOWWexlaJTneTzcWZdy2c9BchaV4L6m7wdizdXfJa1rkdezqrgnkzRJAxM+hUarTC2v at8KrtyTgCKpniOzvpv5umy9yDzOyyfGAtF6m8wt7aae/dyXHsE9/HftzGfLHNEvrOS4 9raZX+2gHE67oGZlvFv+epuMs6dZNUNEUJYqVYp9ANNHQYrKMwhUx0+ER1r3EbF6c4gV Qv0A== X-Gm-Message-State: ABy/qLacxNnOKSqcvj4xDext2zdfVT/CByMWuJcJhi/BJ0hTnbgy0Bpt m0yG+1n/1mls9AXsDhjqXPw= X-Google-Smtp-Source: APBJJlHgqNyyzAgqI3bStyQ5BWKGoNks90Mb5QHinX8EbDmAxrooUb9Hd7VWeuYxH2won5req5en4Q== X-Received: by 2002:a05:600c:219a:b0:3fe:2108:eb8e with SMTP id e26-20020a05600c219a00b003fe2108eb8emr7731597wme.34.1691080645588; Thu, 03 Aug 2023 09:37:25 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 17:37:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Reply-To: paul@xen.org Subject: Re: Ping: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}() Content-Language: en-US To: Jan Beulich , Paul Durrant Cc: "xen-devel@lists.xenproject.org" , Nicola Vetrini , Stefano Stabellini References: <32e33a0b-d572-ea7f-b1a8-3263711582e5@suse.com> <97527049-e3ac-9d8e-806c-2204ed7f68dd@suse.com> From: "Durrant, Paul" In-Reply-To: <97527049-e3ac-9d8e-806c-2204ed7f68dd@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 12:46, Jan Beulich wrote: > On 27.07.2023 20:41, Stefano Stabellini wrote: >> On Thu, 27 Jul 2023, Jan Beulich wrote: >>> In the latter case the variable altogether is then unused and hence gets >>> dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly >>> introduced both assignments in 57a57465daaf ("x86/HVM: use available >>> linear->phys translations in REP MOVS/STOS handling"), likely as a >>> result of some re-work on the patch. >>> >>> Signed-off-by: Jan Beulich >> >> Reviewed-by: Stefano Stabellini > > Paul - any chance of an ack? > Sure. Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:42:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:42:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576512.902731 (Exim 4.92) (envelope-from ) id 1qRbOw-0006I8-Qm; Thu, 03 Aug 2023 16:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576512.902731; Thu, 03 Aug 2023 16:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbOw-0006I1-Nk; Thu, 03 Aug 2023 16:42:14 +0000 Received: by outflank-mailman (input) for mailman id 576512; Thu, 03 Aug 2023 16:42:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbOu-0006Hv-So for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:42:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbOs-0003yv-No; Thu, 03 Aug 2023 16:42:10 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRbOs-0007Qv-FS; Thu, 03 Aug 2023 16:42:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TmH+IFFCzTmmTF0Xjy4CEEm+3JAqwnh7imsQLqX4k3A=; b=L4BbnG0wawUcaO5evzq1r/pm9Z EyWhV8aYSSlfQxBXd0abV9KY//YafzkswVe83x0FqlwZwgBhm/5xItS/qQ2WDloRjE0PLI2dMqrid MTX9KfeKPypD6Lx/v88AWofOjNG9nSJz40UmtoQ7muSOoPo5pUcERro+FXPAWYYvRDr8=; Message-ID: Date: Thu, 3 Aug 2023 17:42:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/x86: Constify the vCPU parameter for expand_xsave_states() Content-Language: en-GB To: Jan Beulich Cc: Julien Grall , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20230802154705.84530-1-julien@xen.org> <376a6586-388b-271c-7667-e63bb1565eef@suse.com> From: Julien Grall In-Reply-To: <376a6586-388b-271c-7667-e63bb1565eef@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 03/08/2023 09:53, Jan Beulich wrote: > On 02.08.2023 17:47, Julien Grall wrote: >> From: Julien Grall >> >> expand_xsave_states() is not meant to modify the vCPU. So the parameter >> can be const. >> >> Signed-off-by: Julien Grall > > Acked-by: Jan Beulich Thanks. I have committed the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:58:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576516.902742 (Exim 4.92) (envelope-from ) id 1qRbeG-0007tl-5Y; Thu, 03 Aug 2023 16:58:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576516.902742; Thu, 03 Aug 2023 16:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbeG-0007te-1Q; Thu, 03 Aug 2023 16:58:04 +0000 Received: by outflank-mailman (input) for mailman id 576516; Thu, 03 Aug 2023 16:58:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbeF-0007tY-2C for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:58:03 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5b64568-321e-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 18:57:59 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691081874405559.5269101632989; Thu, 3 Aug 2023 09:57:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5b64568-321e-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691081875; cv=none; d=zohomail.com; s=zohoarc; b=jqqFM6/EMfOAtUrd5h8u3ybTWClM66RarMeijom0fgf+muYUb2yZ100tQan4qMFvJOSNeVrzj4TeLlvPpa9kmzZxmMeR2+8FCeEpuk2L/kBkM7ikq7Lq5nSRle2z6ysuyql4QLetZIPMhIsjAtcGUHF2TdWfF7C2fJIikDg8LCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691081875; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=g4Ss0M45LZqDBXjGFDnG/1CBGH1BmnZ0+WnJqg4+oiU=; b=DGzCJAJL7TVQTOxXK5dCB9oWvFiS5Okq2q08RRUJw9N0prMIkT5CZCH8ho4QjC1PqAHovj8lx04NP5ZLMEzNLEs3nD71AbZrOZ/7Mplm5Ih9DjqisM/54ZchSnD3DIk7JSryo3hRtaZLbUfp0TndWWGVvJWbrd0khkxwMkoSwq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691081875; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=g4Ss0M45LZqDBXjGFDnG/1CBGH1BmnZ0+WnJqg4+oiU=; b=Xt43XqDNNNyxQTDXbN8WxgvcUidAa01DhWQnZoOV5xSeUyCsEslDKQlVDfnBzWT0 PI9sSVCt9Sta3mpzXnlLPZu1WM5o18NbWW8etc49UrK3NDHXRRUwv2wjHHnF620vOYf S73BAxAbq1L7Awub8mn6FRnb4s3D6kKgIDIMaEsc= Message-ID: <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> Date: Thu, 3 Aug 2023 12:57:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/3/23 07:45, Michal Orzel wrote: > Hi Daniel, > > On 03/08/2023 12:44, Daniel P. Smith wrote: >> >> >> With on going development of hyperlaunch, changes to the device tree definitions >> has been necessary. This commit updates the specification for all current changes >> along with changes expected to be made in finalizing the capability. >> >> This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places >> this documentation under its purview. It also reserves the path >> `xen/common/domain-builder` for the hyperlaunch domain builder code base. >> >> Signed-off-by: Daniel P. Smith >> --- >> MAINTAINERS | 9 + >> .../designs/launch/hyperlaunch-devicetree.rst | 566 ++++++++++-------- >> 2 files changed, 309 insertions(+), 266 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d8a02a6c19..694412a961 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -332,6 +332,15 @@ M: Nick Rosbrook >> S: Maintained >> F: tools/golang >> >> +HYPERLAUNCH >> +M: Daniel P. Smith >> +M: Christopher Clark >> +W: https://wiki.xenproject.org/wiki/Hyperlaunch >> +S: Supported >> +F: docs/design/launch/hyperlaunch.rst >> +F: docs/design/launch/hyperlaunch-devicetree.rst >> +F: xen/common/domain-builder/ >> + >> HYPFS >> M: Juergen Gross >> S: Supported >> diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst >> index b49c98cfbd..0bc719e4ae 100644 >> --- a/docs/designs/launch/hyperlaunch-devicetree.rst >> +++ b/docs/designs/launch/hyperlaunch-devicetree.rst >> @@ -2,10 +2,11 @@ >> Xen Hyperlaunch Device Tree Bindings >> ------------------------------------- >> >> -The Xen Hyperlaunch device tree adopts the dom0less device tree structure and >> -extends it to meet the requirements for the Hyperlaunch capability. The primary >> -difference is the introduction of the ``hypervisor`` node that is under the >> -``/chosen`` node. The move to a dedicated node was driven by: >> +The Xen Hyperlaunch device tree is informed by the dom0less device tree >> +structure with extensions to meet the requirements for the Hyperlaunch >> +capability. A major depature from the dom0less device tree is the introduction >> +of the ``hypervisor`` node that is under the ``/chosen`` node. The move to a >> +dedicated node was driven by: >> >> 1. Reduces the need to walk over nodes that are not of interest, e.g. only >> nodes of interest should be in ``/chosen/hypervisor`` >> @@ -13,331 +14,364 @@ difference is the introduction of the ``hypervisor`` node that is under the >> 2. Allows for the domain construction information to easily be sanitized by >> simple removing the ``/chosen/hypervisor`` node. >> >> -Example Configuration >> ---------------------- >> - >> -Below are two example device tree definitions for the hypervisor node. The >> -first is an example of a multiboot-based configuration for x86 and the second >> -is a module-based configuration for Arm. >> - >> -Multiboot x86 Configuration: >> -"""""""""""""""""""""""""""" >> - >> -:: >> - >> - hypervisor { >> - #address-cells = <1>; >> - #size-cells = <0>; >> - compatible = “hypervisor,xen†>> - >> - // Configuration container >> - config { >> - compatible = "xen,config"; >> - >> - module { >> - compatible = "module,microcode", "multiboot,module"; >> - mb-index = <1>; >> - }; >> - >> - module { >> - compatible = "module,xsm-policy", "multiboot,module"; >> - mb-index = <2>; >> - }; >> - }; >> - >> - // Boot Domain definition >> - domain { >> - compatible = "xen,domain"; >> - >> - domid = <0x7FF5>; >> - >> - // FUNCTION_NONE (0) >> - // FUNCTION_BOOT (1 << 0) >> - // FUNCTION_CRASH (1 << 1) >> - // FUNCTION_CONSOLE (1 << 2) >> - // FUNCTION_XENSTORE (1 << 30) >> - // FUNCTION_LEGACY_DOM0 (1 << 31) >> - functions = <0x00000001>; >> - >> - memory = <0x0 0x20000>; >> - cpus = <1>; >> - module { >> - compatible = "module,kernel", "multiboot,module"; >> - mb-index = <3>; >> - }; >> - >> - module { >> - compatible = "module,ramdisk", "multiboot,module"; >> - mb-index = <4>; >> - }; >> - module { >> - compatible = "module,config", "multiboot,module"; >> - mb-index = <5>; >> - }; >> - >> - // Classic Dom0 definition >> - domain { >> - compatible = "xen,domain"; >> - >> - domid = <0>; >> - >> - // PERMISSION_NONE (0) >> - // PERMISSION_CONTROL (1 << 0) >> - // PERMISSION_HARDWARE (1 << 1) >> - permissions = <3>; >> - >> - // FUNCTION_NONE (0) >> - // FUNCTION_BOOT (1 << 0) >> - // FUNCTION_CRASH (1 << 1) >> - // FUNCTION_CONSOLE (1 << 2) >> - // FUNCTION_XENSTORE (1 << 30) >> - // FUNCTION_LEGACY_DOM0 (1 << 31) >> - functions = <0xC0000006>; >> - >> - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ >> - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ >> - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ >> - mode = <5>; /* 64 BIT, PV */ >> - >> - // UUID >> - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; >> - >> - cpus = <1>; >> - memory = <0x0 0x20000>; >> - security-id = “dom0_t; >> - >> - module { >> - compatible = "module,kernel", "multiboot,module"; >> - mb-index = <6>; >> - bootargs = "console=hvc0"; >> - }; >> - module { >> - compatible = "module,ramdisk", "multiboot,module"; >> - mb-index = <7>; >> - }; >> - }; >> - >> -The multiboot modules supplied when using the above config would be, in order: >> +The Hypervisor node >> +------------------- >> >> -* (the above config, compiled) >> -* CPU microcode >> -* XSM policy >> -* kernel for boot domain >> -* ramdisk for boot domain >> -* boot domain configuration file >> -* kernel for the classic dom0 domain >> -* ramdisk for the classic dom0 domain >> +The ``hypervisor`` node is a top level container for all information relating >> +to how the hyperlaunch is to proceed. This includes definitions of the domains >> +that will be built by hypervisor on start up. The node will be named >> +``hypervisor`` with a ``compatible`` property to identify which hypervisors >> +the configuration is intended. The hypervisor node will consist of one or more >> +config nodes and one or more domain nodes. >> >> -Module Arm Configuration: >> -""""""""""""""""""""""""" >> +Properties >> +"""""""""" >> >> -:: >> +compatible >> + Identifies which hypervisors the configuration is compatible. Required. >> >> - hypervisor { >> - compatible = “hypervisor,xen†>> + Format: "hypervisor,", e.g "hypervisor,xen" >> >> - // Configuration container >> - config { >> - compatible = "xen,config"; >> +Child Nodes >> +""""""""""" >> >> - module { >> - compatible = "module,microcodeâ€; >> - module-addr = <0x0000ff00 0x80>; >> - }; >> +* config >> +* domain >> >> - module { >> - compatible = "module,xsm-policy"; >> - module-addr = <0x0000ff00 0x80>; >> +Config Node >> +----------- >> >> - }; >> - }; >> +A ``config`` node is for passing configuration data and identifying any boot >> +modules that is of interest to the hypervisor. For example this would be where >> +Xen would be informed of microcode or XSM policy locations. Each ``config`` >> +node will require a unique device-tree compliant name as there may be one or >> +more ``config`` nodes present in a single dtb file. To identify which >> +hypervisor the configuration is intended, the required ``compatible`` property >> +must be present. >> >> - // Boot Domain definition >> - domain { >> - compatible = "xen,domain"; >> - >> - domid = <0x7FF5>; >> - >> - // FUNCTION_NONE (0) >> - // FUNCTION_BOOT (1 << 0) >> - // FUNCTION_CRASH (1 << 1) >> - // FUNCTION_CONSOLE (1 << 2) >> - // FUNCTION_XENSTORE (1 << 30) >> - // FUNCTION_LEGACY_DOM0 (1 << 31) >> - functions = <0x00000001>; >> - >> - memory = <0x0 0x20000>; >> - cpus = <1>; >> - module { >> - compatible = "module,kernel"; >> - module-addr = <0x0000ff00 0x80>; >> - }; >> +While the config node is not meant to replace the hypervisor commandline, there >> +may be cases where it is better suited for passing configuration details at >> +boot time. This additional information may be carried in properties assigned >> +to a ``config`` node. If there are any boot modules that are intended for the >> +hypervisor, then a ``module`` child node should be provided to identify the >> +boot module. >> >> - module { >> - compatible = "module,ramdisk"; >> - module-addr = <0x0000ff00 0x80>; >> - }; >> - module { >> - compatible = "module,config"; >> - module-addr = <0x0000ff00 0x80>; >> - }; >> +Properties >> +"""""""""" >> >> - // Classic Dom0 definition >> - domain@0 { >> - compatible = "xen,domain"; >> - >> - domid = <0>; >> - >> - // PERMISSION_NONE (0) >> - // PERMISSION_CONTROL (1 << 0) >> - // PERMISSION_HARDWARE (1 << 1) >> - permissions = <3>; >> - >> - // FUNCTION_NONE (0) >> - // FUNCTION_BOOT (1 << 0) >> - // FUNCTION_CRASH (1 << 1) >> - // FUNCTION_CONSOLE (1 << 2) >> - // FUNCTION_XENSTORE (1 << 30) >> - // FUNCTION_LEGACY_DOM0 (1 << 31) >> - functions = <0xC0000006>; >> - >> - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ >> - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ >> - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ >> - mode = <5>; /* 64 BIT, PV */ >> - >> - // UUID >> - domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; >> - >> - cpus = <1>; >> - memory = <0x0 0x20000>; >> - security-id = “dom0_tâ€; >> - >> - module { >> - compatible = "module,kernel"; >> - module-addr = <0x0000ff00 0x80>; >> - bootargs = "console=hvc0"; >> - }; >> - module { >> - compatible = "module,ramdisk"; >> - module-addr = <0x0000ff00 0x80>; >> - }; >> - }; >> +compatible >> + Identifies the hypervisor the confiugration is intended. Required. >> >> -The modules that would be supplied when using the above config would be: >> + Format: ",config", e.g "xen,config" >> >> -* (the above config, compiled into hardware tree) >> -* CPU microcode >> -* XSM policy >> -* kernel for boot domain >> -* ramdisk for boot domain >> -* boot domain configuration file >> -* kernel for the classic dom0 domain >> -* ramdisk for the classic dom0 domain >> +bootargs >> + This is used to provide the boot params for Xen. >> >> -The hypervisor device tree would be compiled into the hardware device tree and >> -provided to Xen using the standard method currently in use. The remaining >> -modules would need to be loaded in the respective addresses specified in the >> -`module-addr` property. >> + Format: String, e.g. "flask=silo" >> >> +Child Nodes >> +""""""""""" >> >> -The Hypervisor node >> -------------------- >> +* module >> >> -The hypervisor node is a top level container for the domains that will be built >> -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` >> -property is used to identify the type of hypervisor node present.. >> +Domain Node >> +----------- >> >> -compatible >> - Identifies the type of node. Required. >> +A ``domain`` node is for describing the construction of a domain. Since there >> +may be one or more domain nodes, each one requires a unique, DTB compliant name >> +and a ``compatible`` property to identify as a domain node. >> >> -The Config node >> ---------------- >> +A ``domain`` node may provide a ``domid`` property which will be used as the >> +requested domain id for the domain with a value of “0†signifying to use the >> +next available domain id, which is the default behavior if omitted. It should >> +be noted that a domain configuration is not able to request a domid of “0â€. >> +Beyond that, a domain node may have any of the following optional properties. >> >> -A config node is for detailing any modules that are of interest to Xen itself. >> -For example this would be where Xen would be informed of microcode or XSM >> -policy locations. If the modules are multiboot modules and are able to be >> -located by index within the module chain, the ``mb-index`` property should be >> -used to specify the index in the multiboot module chain.. If the module will be >> -located by physical memory address, then the ``module-addr`` property should be >> -used to identify the location and size of the module. >> +Properties >> +"""""""""" >> >> compatible >> - Identifies the type of node. Required. >> - >> -The Domain node >> ---------------- >> + Identifies the node as a domain node and for which hypervisor. Required. >> >> -A domain node is for describing the construction of a domain. It may provide a >> -domid property which will be used as the requested domain id for the domain >> -with a value of “0†signifying to use the next available domain id, which is >> -the default behavior if omitted. A domain configuration is not able to request >> -a domid of “0â€. After that a domain node may have any of the following >> -parameters, >> - >> -compatible >> - Identifies the type of node. Required. >> + Format: ",domain", e.g "xen,domain" >> >> domid >> - Identifies the domid requested to assign to the domain. Required. >> + Identifies the domid requested to assign to the domain. >> >> -permissions >> + Format: Integer, e.g <0> >> + >> +role >> This sets what Discretionary Access Control permissions >> a domain is assigned. Optional, default is none. >> >> -functions >> - This identifies what system functions a domain will fulfill. >> + Format: Bitfield, e.g <3> or <0x00000003> >> + >> + ROLE_NONE (0) >> + ROLE_UNBOUNDED_DOMAIN (1U<<0) >> + ROLE_CONTROL_DOMAIN (1U<<1) >> + ROLE_HARDWARE_DOMAIN (1U<<2) >> + ROLE_XENSTORE_DOMAIN (1U<<3) >> + >> +capability >> + This identifies what system capabilities a domain may have beyond the role it >> + was assigned. >> Optional, the default is none. >> >> -.. note:: The `functions` bits that have been selected to indicate >> - ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits >> - (30, 31) such that should these features ever be fully retired, the flags may >> - be dropped without leaving a gap in the flag set. >> + Format: Bitfield, e.g <3221225487> or <0xC0000007> >> + >> + CAP_NONE (0) >> + CAP_CONSOLE_IO (1U<<0) >> >> mode >> The mode the domain will be executed under. Required. >> >> + Format: Bitfield, e.g <5> or <0x00000005> >> + >> + MODE_PARAVIRTUALIZED (1 << 0) PV | PVH/HVM >> + MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH >> + MODE_LONG (1 << 2) 64 BIT | 32 BIT >> + >> domain-uuid >> A globally unique identifier for the domain. Optional, >> the default is NULL. >> >> + Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] >> + >> cpus >> The number of vCPUs to be assigned to the domain. Optional, >> the default is “1â€. >> >> + Format: Integer, e.g <0> >> + >> memory >> - The amount of memory to assign to the domain, in KBs. >> + The amount of memory to assign to the domain, in KBs. This field uses a DTB >> + Reg which contains a start and size. For memory allocation start may or may >> + not have significance but size will always be used for the amount of memory >> Required. >> >> + Format: String min: | max: | , e.g. "256M" > There is a mismatch between the description and above format: > - KB vs MB > - string vs reg format > - the x86 example uses string and Arm uses reg format Hmmm. I missed this in the hyperlaunch v1 update. In the original design that came from the working group it was going to use a reg as suggest by dom0less. During development of v1, we found it was not rich enough to express how Dom0 could be allocated memory and switched to a string to mirror the dom0 memory hypervisor command line parameter. A question for those involved with dom0less, is what are the opinions about using this form for memory allocation. Is it required/possible to be able to instruct the hypervisor what physical address to use as the start of a domain's memory? >> + >> security-id >> The security identity to be assigned to the domain when XSM >> is the access control mechanism being used. Optional, >> - the default is “domu_tâ€. >> + the default is “system_u:system_r:domU_tâ€. >> + >> + Format: string, e.g. "system_u:system_r:domU_t" > This is specifying full label (as expected) whereas the examples use only type Ack, the examples needs fixing. >> + >> +Child Nodes >> +""""""""""" >> + >> +* module >> + >> +Module node >> +----------- >> >> -The Module node >> ---------------- >> +This node describes a boot module loaded by the boot loader. A ``module`` node >> +will often appear repeatedly and will require a unique and DTB compliant name >> +for each instance. The compatible property is required to identify that the >> +node is a ``module`` node, the type of boot module, and what it represents. >> >> -This node describes a boot module loaded by the boot loader. The required >> -compatible property follows the format: module, where type can be >> -“kernelâ€, “ramdiskâ€, “device-treeâ€, “microcodeâ€, “xsm-policy†or “configâ€. In >> -the case the module is a multiboot module, the additional property string >> -“multiboot,module†may be present. One of two properties is required and >> -identifies how to locate the module. They are the mb-index, used for multiboot >> -modules, and the module-addr for memory address based location. >> +Depending on the type of boot module, the ``module`` node will require either a >> +``module-index`` or ``module-addr`` property must be present. They provide the >> +boot module specific way of locating the boot module in memory. >> + >> +Properties >> +"""""""""" >> >> compatible >> This identifies what the module is and thus what the hypervisor >> should use the module for during domain construction. Required. >> >> -mb-index >> - This identifies the index for this module in the multiboot module chain. >> + Format: "module,"[, "module,"] >> + module type: kernel, ramdisk, device-tree, microcode, xsm-policy, >> + config >> + >> + locating type: index, addr >> + >> +module-index >> + This identifies the index for this module when in a module chain. >> Required for multiboot environments. >> >> + Format: Integer, e.g. <0> >> + >> module-addr >> This identifies where in memory this module is located. Required for >> non-multiboot environments. >> >> + Format: DTB Reg , e.g. <0x0 0x20000> > I guess the number of cells for start and size will be taken from #address-celss and #size-cells > defined either in /chosen or a config/domain node? Correct, in the working group, that is what we were informed was the desired approach. > Also, what is the plan for the existing dom0less dt properties? > Will they need to be moved to new /hypervisor node or we will have to parse both /chosen and /hypervisor nodes? In the proposal I sent to xen-devel in response to Luca's RFC for rebranding dom0less features under hyperlaunch, that is the purpose of this commit. Get this document up to date with what was done in v1 along with what we are planning/working on for hyperlaunch. One could think of this as effectively the API to the capabilities hyperlaunch will provide. Not just how to construct a domain, but what kinds of domains can be constructed by hyperlaunch. Step one of the proposal is to publish a patch upon which we all can iterate over and get to an agreement on a suitable interface for all. The next step would be the introduction of hyperlaunch dom0less compatibility mode, that would see the moving of the parsing logic for the existing dom0less nodes under /xen/common/domain-builder. It would continue to exist there even after hyperlaunch proper is merged and can remain there for backward compatibility until there is a decision to retire the compatibility interface. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 16:59:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 16:59:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576520.902751 (Exim 4.92) (envelope-from ) id 1qRbfz-0008UX-KM; Thu, 03 Aug 2023 16:59:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576520.902751; Thu, 03 Aug 2023 16:59:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbfz-0008UQ-HY; Thu, 03 Aug 2023 16:59:51 +0000 Received: by outflank-mailman (input) for mailman id 576520; Thu, 03 Aug 2023 16:59:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbfx-0008UK-MM for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 16:59:50 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 247670fa-321f-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 18:59:46 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 09:58:37 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 03 Aug 2023 09:58:35 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 09:58:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 09:58:34 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 3 Aug 2023 09:58:34 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by CH3PR11MB7913.namprd11.prod.outlook.com (2603:10b6:610:12e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 16:58:31 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 16:58:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 247670fa-321f-11ee-b269-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691081986; x=1722617986; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2bR+bfeo29GmoggxVSBxVV8jt+ti59iiN8Dhuk5gklw=; b=SGYc0WuB+TNZVuXUpXJHiwXBvs/H7AoDEZPK+cLcJZHyyCM5ecm3dNu3 K8lb8cvf4OUk6z2K3Bmwsm/M3s6oExbaH9ZudLSuL24geUWfTtkjlYYkk uT4OKXbaHPnLD4oD7z7ra/J8QMMSBb3nINCn1IdJH5dUOw2Gat2UCxa9k a7IoSrCvqfj2WQO9E0P7HMOEVAhw+fZJQ5CTf9OypMtMjygFlrlZXVw6s RGUjP7hTZNI523WYFjNap90cFYkKuUBG+C9GFeEy6FGI+cAwanW3HaoOz b12WXEkvjkuLu4vPE6r4eE8pqqbk94u6T1mtHXCDgb9fA781N/cruC59Q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="367397347" X-IronPort-AV: E=Sophos;i="6.01,252,1684825200"; d="scan'208";a="367397347" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="679541479" X-IronPort-AV: E=Sophos;i="6.01,252,1684825200"; d="scan'208";a="679541479" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7enksE22yIgC9mbwkTFdOdlR4eKjKs8QD9VU/KjpybvNsOHd7LcC2nNgMv3jhBzYkPA6GLuNTCLJOLh3fHA8JWqBHAnybaJJCaGrj0R6lpsKl+/F2ehYPcgySdjPlUlA29Af3nikGzcKXc9v7/3RyTvsW5hpxqavjngniVcPxc0Z3O5mtWvTw0ub3OfUBI5dK7QHmtA+U1D677rlpRLA3Kz/1VbUTQGVmC7uktbrK6LB9ffDFdWIyg/tF3/pD8qFHbIj+OIh8cvsXrgj8TcqrrQc+vJ4V32FQtG/CtROyZ2gPXP36vq3rVOeJ7OSDKatb24omqYy4C0yY7WFO0KEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8Z0arXM7cn5WNXFdep3jTI0WR66B1rgi1eh6OtTn6w=; b=IvPkjYFYcY874+PsjpshnI3xfCaNg9rmKy2GN2MeRKcvOLzPsyCsKZXrvCGRZGtjKusCXcd1VjGN5z4r+6jucrG/FRtBbKfrHWCr6s+25DMVoLmvcNJRKBpOXGb9NiETdPip4uREa3O6l9kPUktMj9MmSM9zjhrivJBIC33pWx6Xs5+LI/7uHVlS3rLNoBArh7JQe1Q04C0QTmDioLpTq25LOa1dR+T+AOmoGyZ6E1hQDk3WUORERuKTcHNLB9BLsBJLwAZqb2RVnRoFYOFX0UMNG2BQFy1NdJJYCFbk0UlZY7r5bx2Xuw229NSMR1gDLg2DVS9+n3BFuZnWEbtjcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: "Li, Xin3" , "Christopherson,, Sean" CC: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "kvm@vger.kernel.org" , "xen-devel@lists.xenproject.org" , Jonathan Corbet , "Thomas Gleixner" , Ingo Molnar , "Borislav Petkov" , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Lutomirski, Andy" , Oleg Nesterov , "Luck, Tony" , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , "Cui, Dexuan" , Paolo Bonzini , "Wanpeng Li" , Vitaly Kuznetsov , "Peter Zijlstra" , "Gross, Jurgen" , "Stefano Stabellini" , Oleksandr Tyshchenko , Josh Poimboeuf , "Paul E . McKenney" , Catalin Marinas , Randy Dunlap , "Steven Rostedt" , Kim Phillips , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Liam R . Howlett" , Sebastian Reichel , "Kirill A . Shutemov" , Suren Baghdasaryan , Pawan Gupta , Babu Moger , Jim Mattson , Sandipan Das , Lai Jiangshan , Hans de Goede , "Chatre, Reinette" , Daniel Sneddon , Breno Leitao , Nikunj A Dadhania , Brian Gerst , Sami Tolvanen , "Alexander Potapenko" , Andrew Morton , Arnd Bergmann , "Eric W . Biederman" , Kees Cook , Masami Hiramatsu , Masahiro Yamada , Ze Gao , "Raj, Ashok" , "Jason A . Donenfeld" , "Mark Rutland" , Jacob Pan , Jiapeng Chong , Jane Malalane , "Woodhouse, David" , "Ostrovsky, Boris" , Arnaldo Carvalho de Melo , Yantengsi , Christophe Leroy , Sathvika Vasireddy Subject: RE: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling Thread-Topic: [PATCH RESEND v9 33/36] KVM: VMX: Add VMX_DO_FRED_EVENT_IRQOFF for IRQ/NMI handling Thread-Index: AQHZxFc6Fm9A65hsiUKYksIzWWSQ5K/VzGiAgABBoTCAArbF0A== Date: Thu, 3 Aug 2023 16:58:31 +0000 Message-ID: References: <20230801083553.8468-1-xin3.li@intel.com> <20230801083553.8468-7-xin3.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|CH3PR11MB7913:EE_ x-ms-office365-filtering-correlation-id: 1340e906-affa-4bcd-abbb-08db9442dde2 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZM3l2evIVK4S4X2wwWEz9wOpONWmR1I7RGBz23BuvnVFa3lp4Xq0r3P0iu9nAheAfbjd8MXQ39VbuRzo/CXTp10uEP3eavR/J72iYqucerJ6zt6iIC8PJ1+XhzvGNVyK7u6MavVrU9TEgSqjbbZQNezJ8OGwJG7neikGSU7+mlSxi9hoR5i8RxW/GWTcyYl328UQC8z7m9oGtfEVXaoerRJFktRRmqHpA1Du28JwNrG1vzMhgToR3aXs31g2fw5pkgfIGdIj34IrOhwOxf/5D6H/vK7+kxVCt9SrT6lciPmkYEJmgP/DIPLyE7amCUS5iWyr1Msra6yE6G/Rx/wcCjd/OHB/54t3kNkA++LM10TlRvZVQTb0fFoCoIFPCPSA5Sf53eZ25OhWuy9vkUaLvhmfoq+A/zQktJbzAdmDbUnVKOdh88SqRvDGg0LgfCU/vE5uIe1CCLjqMyWhB+vLh4UBa57mJluve9CtB76BV9fRO1TLHhq70xquwRkSVh7s4QktdeldifQ/RFdKIviCO3akc9McrG65iBkw4WPwpqPn/5cEDrUF5XxjkcPOiQIz+3YW6oMRjBCwwZVbiCohQ3uP+IC1/Mmqlb8/L6B2l+Atn+3yyUfe12pxX+UQqp95 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(376002)(366004)(39860400002)(346002)(451199021)(41300700001)(8936002)(8676002)(83380400001)(186003)(6506007)(26005)(82960400001)(86362001)(38100700002)(122000001)(38070700005)(316002)(71200400001)(478600001)(54906003)(9686003)(7696005)(66556008)(33656002)(110136005)(55016003)(64756008)(66446008)(4326008)(66476007)(66946007)(76116006)(2906002)(7366002)(7406005)(7416002)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fO8D8G6PJfDfa2DVRt831A/mgOTPQYjjZkj10MRsn72LULvaVp7cyN8JtSzv?= =?us-ascii?Q?45v0/JYCj2iW6Ddx2bW2BX9UG/QWaVW/FPd3OvkqhtV+EP7xndAWGtHrqD1H?= =?us-ascii?Q?50MzbLH1/r4QXBcTkjORa6yb8AQSOOYib1j+uprWFtFO7Cj649UMeGfogj5b?= =?us-ascii?Q?k6ME0dVjxMZzHJnS0N3Axj88e9MXmwBYKxXvf3CzLWRH/XOziRs89+Vq3pMW?= =?us-ascii?Q?XVVX2LY18V9W0RevyRJHWTqE6BtsyPptf1MqDEbSFI3GNKJSvWCu3FvXDl9b?= =?us-ascii?Q?Ws5NUFWQtkO7LzkZF68iraPhj2CvgeZ0MMxCUb7c0tb7KEReJb//0QpiK1fJ?= =?us-ascii?Q?2/ViytgsQH+jU/BFcrJ0CV5/XDQ+T6ap5tqxpHFzm62I/pys6bn8VF92lEMf?= =?us-ascii?Q?ekdc/hm1BDDdHIv6OJJhLjRvLEqepSbPskigHwuFABfrDaApbZmg+EpIMyly?= =?us-ascii?Q?jS2pVBJE/DYjCc4zclA07T6Z+x8XANmkAm9hDfnwVesyolWmplUTvxjlCEgk?= =?us-ascii?Q?lAhadzhG2ZBOd7Yzio452XRSexjZ/bLzqPzsttGSvnRKnyM5iqELTonrqGc2?= =?us-ascii?Q?XHRzubs7IvQYhgG6C9+VEFhFm4yqYiTfDYTdo+zK9d7wwQ1bGt5ADl72pArY?= =?us-ascii?Q?IzcrBJtmp7XDSdtbaPxG5s2d8Y/JL91ywBG+CLJ/ToVtS+Jo7BzhsQy3GVbZ?= =?us-ascii?Q?yoU3UL6wWfsBBR+xr2sb/nf5mbW6PeL7/7qR0I9XhA4pgnrW5ezphW1fxRwg?= =?us-ascii?Q?HVV8s6T/h5pvjQ8E9UJuq48VKAr+Yceh6Ggz3ET2Pf72RHi1cwaDr3Aw96ln?= =?us-ascii?Q?X0T/NgpsroVatD5aMgygyAE5rZFkuYDAspzGBGqL3B9zalpnW6Grflw/ybKy?= =?us-ascii?Q?OgUSEaNEggPQbWd30xm9BMDJax5M7gp50Uev1D1QYCGbs16/lFh8wMIxEhW1?= =?us-ascii?Q?a5XqDH2lzZCy2cQ3+co4SCvsPkdIMg3Wnr8j0OHqx7FlyIRHPJSE2mE+WKzj?= =?us-ascii?Q?iQNWNKGyEjxo1ib+NZOLprWZQTfiQ+uWQVMlzx55DPyjkdk0T16DiaBhyQEn?= =?us-ascii?Q?l3qoFlbewzl+2d3Mc1sCLCtGxMgtkJS33hgs1SD28V0fOkuboey4bPPfqecY?= =?us-ascii?Q?mzXI8C8IVwDrGK7HyZhIs7ETXpyS4XqcWNRWWWSryfPAE22fMtUbklTvTWKV?= =?us-ascii?Q?JVPIw42QG4O4XXdji9RBpS1wZalvanTvsuKIEVp64hSz1qPpD3m7HmNIEGxx?= =?us-ascii?Q?Chn0HEm+r5y6amPM+grXXdq/o1y1CV1mQhhUBnkdgO6XqBQjgwQ1S+e2yRm4?= =?us-ascii?Q?7y1jt8yAOttqF00wNscPhWyzpborfU2mo5MN/l+bDU0VybCKjVXQB60qxG8i?= =?us-ascii?Q?TWVBYeosZVNe3euNplABbxRX1Z6wXuRjTMDl1aGsV+BrgdfPwYLncIQ+oM5l?= =?us-ascii?Q?wwmXYZyu147doDVRuoWTuIszer2AX/OdYlq80G9z0X3s9LBDwRtYbj1V+SdA?= =?us-ascii?Q?05eqxpVmFinJcJT2bmhM823hjAqNBIAkLus7eLXckQkDVqRSj5n95zEIT+ol?= =?us-ascii?Q?KfQYuzUPgpIw3flH8uc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1340e906-affa-4bcd-abbb-08db9442dde2 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 16:58:31.4173 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rvadL9VkWw6g5APvNrm1GN3Yrg5AxRdKs5O+sh9uC6LPCEMPy69e7Su8lkjXx/63pkMSS/SlNtfxIPg82G4Etw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7913 X-OriginatorOrg: intel.com > > Jumping way back to providing a wrapper for FRED, if we do that, then > > there's no need to include calling.h, and the weird wrinkle about the > > ERET target kinda goes away too. E.g. provide this in > > arch/x86/entry/entry_64_fred.S > > > > .section .text, "ax" > > > > /* Note, this is instrumentation safe, and returns via RET, not ERETS! > > */ #if IS_ENABLED(CONFIG_KVM_INTEL) > > SYM_CODE_START(fred_irq_entry_from_kvm) > > FRED_ENTER > > call external_interrupt > > FRED_EXIT > > RET > > SYM_CODE_END(fred_irq_entry_from_kvm) > > EXPORT_SYMBOL_GPL(fred_irq_entry_from_kvm); > > #endif > > > > and then the KVM side for this particular chunk is more simply: > > > > lea 1f(%rip), %rax > > push %rax > > push $0 /* FRED error code, 0 for NMI and external > > interrupts */ > > > > \branch_insn \branch_target The call instruction here inserts a return address between the FRED stack frame just created and the GP regs pushed in the FRED wrapper, thus it doesn't work. I only realize it after looking at the stack layout in the Intel Simics emulator. > > 1: > > VMX_DO_EVENT_FRAME_END > > RET > > > Alternatively, the whole thing could be shoved into > > arch/x86/entry/entry_64_fred.S, but at a glance I don't think that > > would be a net positive due to the need to handle IRQs vs. NMIs. But following your idea of "the whole thing could be shoved into ...", plus the patch you posted, I get a patch as the following, which works and gets rid of the 2 warnings of "with modified stack frame". After calling external_interrupt() and POP_REGS, we can also use ERETS, thus to unify the stack adjustment. diff --git a/arch/x86/entry/entry_64_fred.S b/arch/x86/entry/entry_64_fred.= S index de9e2dc70e40..2b638914c6ed 100644 --- a/arch/x86/entry/entry_64_fred.S +++ b/arch/x86/entry/entry_64_fred.S @@ -4,12 +4,87 @@ */ =20 #include +#include #include +#include =20 #include "calling.h" =20 .code64 =20 +#if IS_ENABLED(CONFIG_KVM_INTEL) +.macro FRED_ENTRY_FROM_KVM event_func nmi=3D0 + ENDBR +#ifdef CONFIG_X86_FRED + push %rbp + mov %rsp, %rbp + + /* + * Don't check the FRED stack level, the call stack leading to this + * helper is effectively constant and shallow (relatively speaking). + * + * Emulate the FRED-defined redzone and stack alignment. + */ + sub $(FRED_CONFIG_REDZONE_AMOUNT << 6), %rsp + and $FRED_STACK_FRAME_RSP_MASK, %rsp + + /* + * Start to push a FRED stack frame, which is always 64 bytes: + * + * +--------+-----------------+ + * | Bytes | Usage | + * +--------+-----------------+ + * | 63:56 | Reserved | + * | 55:48 | Event Data | + * | 47:40 | SS + Event Info | + * | 39:32 | RSP | + * | 31:24 | RFLAGS | + * | 23:16 | CS + Aux Info | + * | 15:8 | RIP | + * | 7:0 | Error Code | + * +--------+-----------------+ + */ + push $0 /* Reserved, must be 0 */ + push $0 /* Event data, 0 for IRQ/NMI */ + + shl $32, %rdi /* Event type and vector */ + .if \nmi + bts $FRED_SSX_NMI_BIT, %rdi + .endif + bts $FRED_SSX_64_BIT_MODE_BIT, %rdi + or $__KERNEL_DS, %rdi + push %rdi + push %rbp + pushf + mov $__KERNEL_CS, %rax + push %rax + + /* + * Unlike the IDT event delivery, FRED _always_ pushes an error code + * after pushing the return RIP, thus the CALL instruction CANNOT be + * used here to push the return RIP, otherwise there is no chance to + * push an error code before invoking the IRQ/NMI handler. + * + * Use LEA to get the return RIP and push it, then push an error code. + */ + lea 1f(%rip), %rax + push %rax /* Return RIP */ + push $0 /* Error code, 0 for IRQ/NMI */ + + PUSH_AND_CLEAR_REGS + movq %rsp, %rdi /* %rdi -> pt_regs */ + call \event_func + POP_REGS + ERETS +1: + pop %rbp + RET +#else /* CONFIG_X86_FRED */ + ud2 +#endif /* CONFIG_X86_FRED */ +.endm +#endif /* CONFIG_KVM_INTEL */ + .macro FRED_ENTER UNWIND_HINT_END_OF_STACK ENDBR @@ -22,6 +97,16 @@ POP_REGS .endm =20 + .section .text, "ax" + +/* Note, this is instrumentation safe, and returns via RET */ +#if IS_ENABLED(CONFIG_KVM_INTEL) +SYM_CODE_START(fred_irq_entry_from_kvm) + FRED_ENTRY_FROM_KVM external_interrupt +SYM_CODE_END(fred_irq_entry_from_kvm) +EXPORT_SYMBOL_GPL(fred_irq_entry_from_kvm); +#endif + .section .noinstr.text, "ax" =20 /* @@ -55,3 +140,10 @@ SYM_CODE_START_NOALIGN(fred_entrypoint_kernel) FRED_EXIT ERETS SYM_CODE_END(fred_entrypoint_kernel) + +#if IS_ENABLED(CONFIG_KVM_INTEL) +SYM_CODE_START(fred_nmi_entry_from_kvm) + FRED_ENTRY_FROM_KVM fred_exc_nmi nmi=3D1 +SYM_CODE_END(fred_nmi_entry_from_kvm) +EXPORT_SYMBOL_GPL(fred_nmi_entry_from_kvm); +#endif diff --git a/arch/x86/include/asm/fred.h b/arch/x86/include/asm/fred.h index 3c91f0eae62e..c7288213de14 100644 --- a/arch/x86/include/asm/fred.h +++ b/arch/x86/include/asm/fred.h @@ -122,6 +122,10 @@ DECLARE_FRED_HANDLER(fred_exc_double_fault); extern asmlinkage __visible void fred_entrypoint_user(void); extern asmlinkage __visible void fred_entrypoint_kernel(void); =20 +/* For KVM VMX to handle IRQs in IRQ induced VM exits */ +extern asmlinkage __visible void fred_irq_entry_from_kvm(unsigned int even= t_info); +extern asmlinkage __visible void fred_nmi_entry_from_kvm(unsigned int even= t_info); + #endif /* __ASSEMBLY__ */ =20 #endif /* CONFIG_X86_FRED */ diff --git a/arch/x86/kvm/vmx/vmenter.S b/arch/x86/kvm/vmx/vmenter.S index be275a0410a8..f6f557c6329e 100644 --- a/arch/x86/kvm/vmx/vmenter.S +++ b/arch/x86/kvm/vmx/vmenter.S @@ -40,6 +40,20 @@ push %_ASM_BP mov %_ASM_SP, %_ASM_BP =20 + /* + * Start to push an IDT IRQ/NMI stack frame, which is 40 bytes on + * x86_64 and 24 bytes on x86_32: + * + * +-------+-------------------+ + * | Bytes | Usage | + * +-------+-------------------+ + * | 39:32 | SS (x86_64 only) | + * | 31:24 | RSP (x86_64 only) | + * | 23:16 | RFLAGS | + * | 15:8 | CS | + * | 7:0 | RIP | + * +-------+-------------------+ + */ #ifdef CONFIG_X86_64 /* * Align RSP to a 16-byte boundary (to emulate CPU behavior) before diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index df461f387e20..83c89239fcff 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6961,14 +6961,16 @@ static void handle_external_interrupt_irqoff(struct= kvm_vcpu *vcpu) { u32 intr_info =3D vmx_get_intr_info(vcpu); unsigned int vector =3D intr_info & INTR_INFO_VECTOR_MASK; - gate_desc *desc =3D (gate_desc *)host_idt_base + vector; =20 if (KVM_BUG(!is_external_intr(intr_info), vcpu->kvm, "unexpected VM-Exit interrupt info: 0x%x", intr_info)) return; =20 kvm_before_interrupt(vcpu, KVM_HANDLING_IRQ); - vmx_do_interrupt_irqoff(gate_offset(desc)); + if (cpu_feature_enabled(X86_FEATURE_FRED)) + fred_irq_entry_from_kvm((EVENT_TYPE_HWINT << 16) | vector); + else + vmx_do_interrupt_irqoff(gate_offset((gate_desc *)host_idt_base + vector)= ); kvm_after_interrupt(vcpu); =20 vcpu->arch.at_instruction_boundary =3D true; @@ -7254,7 +7256,10 @@ static noinstr void vmx_vcpu_enter_exit(struct kvm_v= cpu *vcpu, if ((u16)vmx->exit_reason.basic =3D=3D EXIT_REASON_EXCEPTION_NMI && is_nmi(vmx_get_intr_info(vcpu))) { kvm_before_interrupt(vcpu, KVM_HANDLING_NMI); - vmx_do_nmi_irqoff(); + if (cpu_feature_enabled(X86_FEATURE_FRED)) + fred_nmi_entry_from_kvm((EVENT_TYPE_NMI << 16) | NMI_VECTOR); + else + vmx_do_nmi_irqoff(); kvm_after_interrupt(vcpu); } From xen-devel-bounces@lists.xenproject.org Thu Aug 03 17:16:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 17:16:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576531.902765 (Exim 4.92) (envelope-from ) id 1qRbwR-0002cQ-2L; Thu, 03 Aug 2023 17:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576531.902765; Thu, 03 Aug 2023 17:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbwQ-0002cJ-Vn; Thu, 03 Aug 2023 17:16:50 +0000 Received: by outflank-mailman (input) for mailman id 576531; Thu, 03 Aug 2023 17:16:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbwP-0002bQ-Hi for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 17:16:49 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86a68162-3221-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 19:16:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 5D49C82852F1; Thu, 3 Aug 2023 12:16:46 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id IrDwIyeYSX4W; Thu, 3 Aug 2023 12:16:45 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 737FA8285416; Thu, 3 Aug 2023 12:16:45 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EPQiwLxHX71q; Thu, 3 Aug 2023 12:16:45 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 1F12C82852F1; Thu, 3 Aug 2023 12:16:45 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86a68162-3221-11ee-b269-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 737FA8285416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691083005; bh=kOK47EPTNtM3IAKsvYQKRr4Q8E0gVq5NmMdRgtphQa4=; h=Message-ID:Date:MIME-Version:To:From; b=rA5belChoe4thu0NT5lVVisIB89PwzTAkCj4Eb5B2jjfIeoOxwUae7lv1hpwsl6dw EeLWA1YYcY1jS8IdNBMSGlTm7JvrXUcC+VEoHndqj6hk//Td6JTzBNhVtG0Vi4bBKo Pp+is4bVlhVnkwxfkoqVHbS+bCj3DuVnO0QOUTwc= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <31a31730-583e-6a22-48f2-44539202ef2d@raptorengineering.com> Date: Thu, 3 Aug 2023 12:16:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] xen/ppc: Relocate kernel to physical address 0 on boot Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <0802fad2743526da4fe49f0225e14161464f192e.1690582001.git.sanastasio@raptorengineering.com> <3b6b0984-89fb-268e-970a-0c7eb19a4863@suse.com> <428aa0e8-70bb-efb5-2b5a-54229b77c5a3@raptorengineering.com> From: Shawn Anastasio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/23 1:08 AM, Jan Beulich wrote: > On 01.08.2023 01:37, Shawn Anastasio wrote: >> On 7/31/23 10:46 AM, Jan Beulich wrote: >>> On 29.07.2023 00:21, Shawn Anastasio wrote: >>>> + /* If we're at the correct address, skip copy */ >>>> + cmpld %r1, %r12 >>>> + beq .L_correct_address >>> >>> Can this ever be the case, especially with the MMU-off behavior you >>> describe in the comment above? Wouldn't you need to ignore the top >>> four bits in the comparison? >> >> It will always be the case after the code jumps to XEN_VIRT_START after >> the copy takes place. > > Well, of course. > >> I could have it jump past the copy loop entirely, >> but then I'd need to duplicate the TOC setup. > > I don't think I understand this part of your reply: .L_correct_address > _is_ past the copy loop. Sorry, let me elaborate. I meant that I could have the end of the copy loop (the mtctr + btctr preceeding .L_correct_address) jump to (XEN_VIRT_START + .L_correct_address) as opposed to XEN_VIRT_START so that the address comparison you originally commented on wouldn't be hit again. This would mean adding another TOC setup block at .L_correct_address, though, since we'd be skipping over the one at the beginning of the routine and the TOC needs to be reconfigured after the relocation. >>>> + /* Copy bytes until _end */ >>>> + LOAD_REG_ADDR(%r11, _end) >>>> + addi %r1, %r1, -8 >>>> + li %r13, -8 >>>> +.L_copy_xen: >>>> + ldu %r10, 8(%r1) >>>> + stdu %r10, 8(%r13) >>>> + cmpld %r1, %r11 >>>> + blt .L_copy_xen >>>> + >>>> + /* Jump to XEN_VIRT_START */ >>>> + mtctr %r12 >>>> + bctr >>>> +.L_correct_address: >>> >>> Can the two regions potentially overlap? Looking at the ELF header >>> it's not clear to me what guarantees there are that this can't >>> happen. >> >> As I understand it, any bootloader that placed the kernel at a low >> enough address for this to be an issue wouldn't be able to boot Linux or >> FreeBSD, so in practice it's a safe bet that this won't be the case. > > Fair enough then. > > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Thu Aug 03 17:17:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 17:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576533.902777 (Exim 4.92) (envelope-from ) id 1qRbwz-00034d-DN; Thu, 03 Aug 2023 17:17:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576533.902777; Thu, 03 Aug 2023 17:17:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbwz-00034W-97; Thu, 03 Aug 2023 17:17:25 +0000 Received: by outflank-mailman (input) for mailman id 576533; Thu, 03 Aug 2023 17:17:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRbwx-00033Z-NR for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 17:17:23 +0000 Received: from sender3-of-o59.zoho.com (sender3-of-o59.zoho.com [136.143.184.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a175a9b-3221-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 19:17:22 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691083031153710.1109667925965; Thu, 3 Aug 2023 10:17:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a175a9b-3221-11ee-b269-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691083032; cv=none; d=zohomail.com; s=zohoarc; b=gz4cRN/UxO1k9s/AeHLVWvWE7UGRKSMCOvgsJYYJMPiD7a7TPQqI5n4ZTpVu1uU1XvLCHgV+Maty7ymb0pL7PslJP7bgT7gtkYsStEz4mBbxGbwXHhN4aAZLtm1ZEhKWNFZub1aXbDq08EoyTcQUBqphT8Zi1zQeEeAMob03nw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691083032; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=AmEf/+ki1UJIP4coeTooEdy1afIkuTFZimjus8hcjZc=; b=N2X5Yd9Mx4hU2ZaPbKyUtia56cA9xJPr8mpLDByH8dmw3g+t95jn8zLwRzXJL+zJTVCqbVIbfd2xUuNLU+im25EweqVk7cvfgaWOrqDw/BwZIrvEH2t59/sMKH91LY/+wikBVYl6YZdusncEG9AkrxwNlxKjiDtDXT7A9NQDqDE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691083032; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=AmEf/+ki1UJIP4coeTooEdy1afIkuTFZimjus8hcjZc=; b=hmEKx9wCh+NW3rupnWwk4ZGDvlaNQ6mlgDuvxsIekmSYdognA3tBw05jWmLL9VaB ZDtWVvs5/VhnQSu1xzJHTsxUEeI39yGcx6IXCYAa8KrwPnEVmB1M7gfF6YdHW9Lymnl ciUB/qoV/ES2lxQ+coYNqIE/E/gatLg1o02N5qAg= Message-ID: Date: Thu, 3 Aug 2023 13:17:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <52a02ef3-80a7-9000-4644-38adbb5a2573@suse.com> From: "Daniel P. Smith" In-Reply-To: <52a02ef3-80a7-9000-4644-38adbb5a2573@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 08:19, Jan Beulich wrote: > On 03.08.2023 12:44, Daniel P. Smith wrote: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -332,6 +332,15 @@ M: Nick Rosbrook >> S: Maintained >> F: tools/golang >> >> +HYPERLAUNCH >> +M: Daniel P. Smith >> +M: Christopher Clark >> +W: https://wiki.xenproject.org/wiki/Hyperlaunch >> +S: Supported >> +F: docs/design/launch/hyperlaunch.rst >> +F: docs/design/launch/hyperlaunch-devicetree.rst >> +F: xen/common/domain-builder/ > > I would generally suggest that maintainership changes come in a separate > patch. Furthermore aiui lots of stuff is going to be moved from elsewhere, > and such code may better stay under its original maintainership (unless > it was agreed that it would shift). So initially maybe best to name the > original maintainers here under M: and add the two of you with R: ? I can do this as a separate patch and mark it as fix for `d4f3125f1b docs/designs/launch: Hyperlaunch design document` where Christopher and I are the original authors of the only existing files covered under this new MAINTAINERSHIP entry currently. As far as code moving here, the dom0less rebranding proposal called for an additional MAINTAINERS section titled HYPERLAUNCH DOM0LESS COMPATIBILITY that would retain the maintainers (or new ones if Arm wanted to propose others) from the ARM section. The purpose of putting Christopher and I at the top are for several reasons, - The code in v1 was conglomerations of reuses/relocated code and a substantial amount of new code around it. - As mentioned regarding the HYPERLAUNCH DOM0LESS COMPATIBILITY section, there may be paths below HYPERLAUNCH that are owned by others, but ultimately we conceived, designed, and created the capability. So it falls on us to ensure anything done in sub-feature, doesn't break or violate the larger design we sought to achieve while also not letting it fall back on THE REST. > I also don't think it makes sense to include a not-yet-populated path > here; who knows what this is going to change to by the time things get > committed. Well, if my proposed plan is executed as I suggested, hopefully there would be a series very soon that would move the dom0less device tree parsing under that path. Now to be inline with the above and address your concern, as the HYPERLAUNCH DOM0LESS COMPATIBILITY section is added to cover the file(s) the series adds, the HYPERLAUNCH section could then be updated with the top level path. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 17:22:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 17:22:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576541.902786 (Exim 4.92) (envelope-from ) id 1qRc2I-0004hN-6b; Thu, 03 Aug 2023 17:22:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576541.902786; Thu, 03 Aug 2023 17:22:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRc2I-0004hG-1m; Thu, 03 Aug 2023 17:22:54 +0000 Received: by outflank-mailman (input) for mailman id 576541; Thu, 03 Aug 2023 17:22:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRc2G-0004h6-Vj; Thu, 03 Aug 2023 17:22:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRc2G-0004z8-R3; Thu, 03 Aug 2023 17:22:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRc2G-0001gw-BB; Thu, 03 Aug 2023 17:22:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRc2G-0005Jq-Af; Thu, 03 Aug 2023 17:22:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dXnUyBBcOVecn+RAjV02UWsgn95A5LZvR6wsmIlgkLA=; b=pU1OxnFvQr8u1wN5cYBKrI708b pE79GMNleoqOSaWT1uC1TIi9U6sw+4RLqpusgst4dB3vPNmhkUkrcOOxpQCijACgd9Wk3s9dB68T0 agQOhkfnvYwPOjS6gbWnN9PfIzZLvK2hCQmqMdTzO4NlfBPoVW37b+f/0eSz71ezamaw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182114: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=38a6de80b917b2a822cff0e38d83563ab401c890 X-Osstest-Versions-That: qemuu=ccb86f079a9e4d94918086a9df18c1844347aff8 From: osstest service owner Date: Thu, 03 Aug 2023 17:22:52 +0000 flight 182114 qemu-mainline real [real] flight 182169 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182114/ http://logs.test-lab.xenproject.org/osstest/logs/182169/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 7 xen-install fail pass in 182169-retest test-armhf-armhf-xl-vhd 8 xen-boot fail pass in 182169-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 182169 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 182169 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182067 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182067 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182067 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182067 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182067 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182067 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182067 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182067 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 38a6de80b917b2a822cff0e38d83563ab401c890 baseline version: qemuu ccb86f079a9e4d94918086a9df18c1844347aff8 Last test of basis 182067 2023-07-29 02:34:52 Z 5 days Failing since 182096 2023-07-31 15:38:52 Z 3 days 2 attempts Testing same since 182114 2023-08-02 10:38:51 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Anthony PERARD CĂ©dric Le Goater David Woodhouse Gavin Shan Helge Deller Joel Stanley Klaus Jensen Nicholas Piggin Olaf Hering Peter Maydell Richard Henderson Warner Losh jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ccb86f079a..38a6de80b9 38a6de80b917b2a822cff0e38d83563ab401c890 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Aug 03 17:29:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 17:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576547.902795 (Exim 4.92) (envelope-from ) id 1qRc8v-0005LD-Rd; Thu, 03 Aug 2023 17:29:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576547.902795; Thu, 03 Aug 2023 17:29:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRc8v-0005L6-P5; Thu, 03 Aug 2023 17:29:45 +0000 Received: by outflank-mailman (input) for mailman id 576547; Thu, 03 Aug 2023 17:29:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRc8u-0005L0-HG for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 17:29:44 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 530f6042-3223-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 19:29:41 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691083774724241.91618186962626; Thu, 3 Aug 2023 10:29:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 530f6042-3223-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691083776; cv=none; d=zohomail.com; s=zohoarc; b=mrMqGmqY1Toa3lpPDrAw0S2wyoznZsujWLJHpJtEfkWy9m5ZPwN5oJ/S9JcXWacZ73E5kjVWjd5ZChWGp4W8VzY1QDQ3FZAvspoAa42iP7ylLMRRuH4jcuW3AUiY9P+RFxh74VhDBbHU2C4VGca5F3s3PariPewE0AvsHgk0UKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691083776; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GXeUjwwr+A8yvrvDsQGAKvZOE1KzahYN6RE+9FJ12L4=; b=D3fzz4PC4xZFNK380u2gpHeRmIOAsv6+vIDQ45re/1obvHF6MowFFxl63XRLnFvlcgmPt3EKs6kup6WnaQuLlo9QSr9xccerslX++UnNJ7ABtyWDFPtpQk9dwRs+rBARz7yKcXxbiZhSRrlZwBdd6s4Z7OF2uHstOCCUYGoAu2M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691083776; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=GXeUjwwr+A8yvrvDsQGAKvZOE1KzahYN6RE+9FJ12L4=; b=eBOoCQlmqM1QMbMAjcApXLiJTR2vdd8WhaZC8k7b1aezpydhKhfGcpAZRUO+b/ja 7PFYEtr0R29mRIR8W+i8VvpYED9KwBT4ehE+GQ0HguzVJ3xBH0wDXMneJrW/ESvPsIK SkL0OYTavsXKXynBaT4f6qIir40dl73EgdnN5xLU= Message-ID: <956a8409-a02f-41f0-5ddd-051d47907ad9@apertussolutions.com> Date: Thu, 3 Aug 2023 13:29:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Michal Orzel , Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> <476e5c13-2b4f-d115-7237-d5220ec13cf2@amd.com> From: "Daniel P. Smith" In-Reply-To: <476e5c13-2b4f-d115-7237-d5220ec13cf2@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 08:48, Michal Orzel wrote: > Hi Daniel, > > On 03/08/2023 12:44, Daniel P. Smith wrote: >> >> >> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is >> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > IIUC, you just try to untangle the code for fdt from dt (unflattened). CORE_DEVICE_TREE is > a bit ambiguous in my opinion, so maybe just CONFIG_FDT, especially since you use it to guard libfdt/? Untangle is a very good way to phrase it. ( ^_^) Yes, I don't see any reason why CONFIG_FDT could be used instead. >> introduced for when the ability of parsing DTB files is needed by a capability >> such as hyperlaunch. >> >> Signed-off-by: Daniel P. Smith >> --- >> MAINTAINERS | 8 +- >> xen/arch/arm/bootfdt.c | 141 +--------------------------- >> xen/arch/arm/domain_build.c | 1 + >> xen/arch/arm/include/asm/setup.h | 6 -- >> xen/common/Kconfig | 4 + >> xen/common/Makefile | 3 +- >> xen/common/fdt.c | 153 +++++++++++++++++++++++++++++++ >> xen/include/xen/device_tree.h | 50 +--------- >> xen/include/xen/fdt.h | 79 ++++++++++++++++ >> 9 files changed, 246 insertions(+), 199 deletions(-) >> create mode 100644 xen/common/fdt.c >> create mode 100644 xen/include/xen/fdt.h >> > [...] > >> diff --git a/xen/common/fdt.c b/xen/common/fdt.c >> new file mode 100644 >> index 0000000000..8d7acaaa43 >> --- /dev/null >> +++ b/xen/common/fdt.c >> @@ -0,0 +1,153 @@ >> +/* > SPDX missing for a new file Ack. >> + * Flattened Device Tree >> + * >> + * Copyright (C) 2012-2014 Citrix Systems, Inc. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +bool __init device_tree_node_matches( >> + const void *fdt, int node, const char *match) > FWICS, this code style (that you use for every function in this patch) is rather uncommon in Xen so maybe better to follow the generic style. > Also, this would avoid changing the style of functions/prototypes you move. Um, my understanding is that this is the official style for Xen function definitions, unless it has changed due to MISRA, and that anytime a function definition is changed that the style should be corrected to this form. Another coding style change I have been pinged on in the past that I surprised I have not been pinged on for this series is allowing the use of the short hand notation for ints, e.g. u8, u16, and u32. > [...] > >> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h >> index 1d79e23b28..82db38b140 100644 >> --- a/xen/include/xen/device_tree.h >> +++ b/xen/include/xen/device_tree.h >> @@ -14,13 +14,12 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> #include >> >> -#define DEVICE_TREE_MAX_DEPTH 16 >> - >> /* >> * Struct used for matching a device >> */ >> @@ -159,17 +158,8 @@ struct dt_raw_irq { >> u32 specifier[DT_MAX_IRQ_SPEC]; >> }; >> >> -typedef int (*device_tree_node_func)(const void *fdt, >> - int node, const char *name, int depth, >> - u32 address_cells, u32 size_cells, >> - void *data); >> - >> extern const void *device_tree_flattened; >> >> -int device_tree_for_each_node(const void *fdt, int node, >> - device_tree_node_func func, >> - void *data); >> - >> /** >> * dt_unflatten_host_device_tree - Unflatten the host device tree >> * >> @@ -214,14 +204,6 @@ extern const struct dt_device_node *dt_interrupt_controller; >> struct dt_device_node * >> dt_find_interrupt_controller(const struct dt_device_match *matches); >> >> -#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) >> -#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) >> -#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) >> - >> -/* Default #address and #size cells */ >> -#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 >> -#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 >> - >> #define dt_for_each_property_node(dn, pp) \ >> for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) >> >> @@ -231,16 +213,6 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); >> #define dt_for_each_child_node(dt, dn) \ >> for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling ) >> >> -/* Helper to read a big number; size is in cells (not bytes) */ >> -static inline u64 dt_read_number(const __be32 *cell, int size) >> -{ >> - u64 r = 0; >> - >> - while ( size-- ) >> - r = (r << 32) | be32_to_cpu(*(cell++)); >> - return r; >> -} >> - >> /* Wrapper for dt_read_number() to return paddr_t (instead of uint64_t) */ >> static inline paddr_t dt_read_paddr(const __be32 *cell, int size) > Shouldn't this also go to fdt.h as it is just a wrapper for dt_read_number() you moved? This patch came from hyperlaunch v1 series were I only moved what I needed, not necessarily everything that could reasonably be moved. I will gladly incorporate any additional macros, inlines, and functions that is felt is general enough to be included. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 17:45:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 17:45:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576551.902806 (Exim 4.92) (envelope-from ) id 1qRcO9-0007n2-2M; Thu, 03 Aug 2023 17:45:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576551.902806; Thu, 03 Aug 2023 17:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcO8-0007mv-UV; Thu, 03 Aug 2023 17:45:28 +0000 Received: by outflank-mailman (input) for mailman id 576551; Thu, 03 Aug 2023 17:45:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcO8-0007mo-Kt for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 17:45:28 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86cb8ffe-3225-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 19:45:26 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 373HjC50013441 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 3 Aug 2023 13:45:18 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 373HjCPp013440; Thu, 3 Aug 2023 10:45:12 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86cb8ffe-3225-11ee-8613-37d641c3527e Date: Thu, 3 Aug 2023 10:45:12 -0700 From: Elliott Mitchell To: Julien Grall Cc: Jan Beulich , Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing Message-ID: References: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> <8074634d-fd76-43fc-8e0f-4c3a70ea5360@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8074634d-fd76-43fc-8e0f-4c3a70ea5360@xen.org> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com On Thu, Aug 03, 2023 at 05:34:31PM +0100, Julien Grall wrote: > > On 03/08/2023 17:13, Elliott Mitchell wrote: > > > > I didn't know which way to go, so with no idea which option to choose the > > last one ended up winning out. Perhaps that was wrong yet I've still no > > feedback on the actual patches. > > Not sure if this is related to the lack of answer. But I didn't receive > any of your patches via xen-devel (I received your replies). Skimming > through the bounce for the xenproject mail server, I noticed a lot of > the following: > > host gmail-smtp-in.l.google.com [142.250.123.26] > SMTP error from remote mail server after pipelined end of data: > 550-5.7.1 This message is not RFC 5322 compliant. There are > multiple Cc headers. > 550-5.7.1 To reduce the amount of spam sent to Gmail, this message > has been > 550-5.7.1 blocked. Please visit > 550 5.7.1 > https://support.google.com/mail/?p=RfcMessageNonCompliant > t7-20020a81e447000000b005839e8b595dsi12027284ywl.554 - gsmtp That seems to be repotting a bug in `scripts/add_maintainers.pl`. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 17:48:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 17:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576557.902815 (Exim 4.92) (envelope-from ) id 1qRcRE-0008Rn-Hr; Thu, 03 Aug 2023 17:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576557.902815; Thu, 03 Aug 2023 17:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcRE-0008Rg-FL; Thu, 03 Aug 2023 17:48:40 +0000 Received: by outflank-mailman (input) for mailman id 576557; Thu, 03 Aug 2023 17:48:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcRD-0008Ra-6I for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 17:48:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcR9-0005Ru-On; Thu, 03 Aug 2023 17:48:35 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[192.168.22.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRcR9-00073Z-Ha; Thu, 03 Aug 2023 17:48:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=N/IdIBSW66PnSSQRHQYBquFMdTZrRodDkH43DUfQZPo=; b=TL/HMBFJG7Z1M2lVBn4aVt8DTP wVhGgLGjhZFM89oBkoU5X9UMvtBowaekcRCusRlDiKN+2kNkvkfgJXRs3p3ZTnjIm+/KEK2tR+EQS BURe1BBC78eGcpv3IvHAeyJwPGDRp+ZyUkAmaa6ipiJJdSS/vU6hI0VfGsH4x4SWVh6g=; Message-ID: <82914e71-fa96-490c-b584-a90045a71567@xen.org> Date: Thu, 3 Aug 2023 18:48:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing Content-Language: en-GB To: Elliott Mitchell Cc: Jan Beulich , Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> <8074634d-fd76-43fc-8e0f-4c3a70ea5360@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/08/2023 18:45, Elliott Mitchell wrote: > On Thu, Aug 03, 2023 at 05:34:31PM +0100, Julien Grall wrote: >> >> On 03/08/2023 17:13, Elliott Mitchell wrote: >>> >>> I didn't know which way to go, so with no idea which option to choose the >>> last one ended up winning out. Perhaps that was wrong yet I've still no >>> feedback on the actual patches. >> >> Not sure if this is related to the lack of answer. But I didn't receive >> any of your patches via xen-devel (I received your replies). Skimming >> through the bounce for the xenproject mail server, I noticed a lot of >> the following: >> >> host gmail-smtp-in.l.google.com [142.250.123.26] >> SMTP error from remote mail server after pipelined end of data: >> 550-5.7.1 This message is not RFC 5322 compliant. There are >> multiple Cc headers. >> 550-5.7.1 To reduce the amount of spam sent to Gmail, this message >> has been >> 550-5.7.1 blocked. Please visit >> 550 5.7.1 >> https://support.google.com/mail/?p=RfcMessageNonCompliant >> t7-20020a81e447000000b005839e8b595dsi12027284ywl.554 - gsmtp > > That seems to be repotting a bug in `scripts/add_maintainers.pl`. I am curious to know why you think so? I have been using scripts/add_maintainers.pl for quite a while and so far never seen any of my e-mail blocked. My usual runes are: 42sh> scripts/add_maintainers.pl -d . 42sh> git-send-email *.patch What's yours? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 18:07:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 18:07:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576561.902826 (Exim 4.92) (envelope-from ) id 1qRcit-0002XS-1z; Thu, 03 Aug 2023 18:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576561.902826; Thu, 03 Aug 2023 18:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcis-0002XL-VY; Thu, 03 Aug 2023 18:06:54 +0000 Received: by outflank-mailman (input) for mailman id 576561; Thu, 03 Aug 2023 18:06:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRcir-0002XF-So for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 18:06:53 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7e1b::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84f67584-3228-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 20:06:51 +0200 (CEST) Received: from AS9P250CA0020.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::22) by AS8PR08MB8088.eurprd08.prod.outlook.com (2603:10a6:20b:54d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 18:06:40 +0000 Received: from AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:532:cafe::60) by AS9P250CA0020.outlook.office365.com (2603:10a6:20b:532::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20 via Frontend Transport; Thu, 3 Aug 2023 18:06:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT033.mail.protection.outlook.com (100.127.140.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Thu, 3 Aug 2023 18:06:39 +0000 Received: ("Tessian outbound f9124736ff4f:v145"); Thu, 03 Aug 2023 18:06:39 +0000 Received: from 2e2846a2a2f2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4C3B7C74-AF05-451D-9674-82FD4823A748.1; Thu, 03 Aug 2023 18:05:57 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2e2846a2a2f2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 18:05:57 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB9737.eurprd08.prod.outlook.com (2603:10a6:20b:607::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 18:05:53 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 18:05:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84f67584-3228-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0NtMGP5Ni8N6PrPUiOBVIbo4Ed4wZldRchR3+VrtTE=; b=LnAHnzioTRSuoJfVu0jfG4WDc9/Hdt4ti+oIJXvRkbzVT83NIwFojKVp5vWFZC2x9XRTLdn+xQARNBDwv15PWBDw/xfCVMbBT1t8pRXAWhTQ5MyZ0kc8tWclBsapFXZDZ1svjIEaQDKwoV5VDI6TW3xezzjY/NdJ+F1CozIcV30= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 204ea91710035784 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AwqhfP3G9aRsrME8GbCft44S5za4Apnwfd3qqf7aETi+XpYhl9me9grfj4fsLMDzbi4cID4sTft80c7qR0wcxx++kixfIp9jHj/5uI2DDPLjP+iKWfNprkMfgRjgE5iOEImQ/fOM37I88Nd+zKhj28du2VbW9SApeVD1aS+51+mJiiU0wF+DrLdexropt5u+fxdpHdBWljJDmmfzJrANmBZGxISiewKn0gtD0Ut8f84P9XYLCxxkxHtVcLFNnLQ0bWo6HxxoWENUvBGCR/P3GzikimykauYvJNW+RqOMy/+JS4e2WJtADl/2XGzTwCWREV1XYhkRS8xED168a3PNfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E0NtMGP5Ni8N6PrPUiOBVIbo4Ed4wZldRchR3+VrtTE=; b=ZGVv2yjOBsmvKkDhIMcEa7urmMTNMMUqCNCjliQv4hua1xaknrFVEDCCdrpXuk42m33brLXSYtZNyxRUfJ9R47vUm7S91hcV/fLU9nb90b6PcqHiRGgMjU6YvIJD+ayLs5U7JMZkOtdUYMDtvw4mXcRFmbe9gKjEwQ1xeNMfPPtQVyT53vJKlP7FFO0oMikAcF+JVn8WXn4hwtjmwFu6YPuJHuJXbHP/4qzEyW+FpSwfKi0JQ2O/t2/kYQnlnqHWE/+7OFbGIZPbTLwK+tP/6SlK3jKNPG7bAKWzMlIN+JgL7KYsWwEvKnLQrDaLK69ObAzfuagxYoRaGVme6ZDZNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E0NtMGP5Ni8N6PrPUiOBVIbo4Ed4wZldRchR3+VrtTE=; b=LnAHnzioTRSuoJfVu0jfG4WDc9/Hdt4ti+oIJXvRkbzVT83NIwFojKVp5vWFZC2x9XRTLdn+xQARNBDwv15PWBDw/xfCVMbBT1t8pRXAWhTQ5MyZ0kc8tWclBsapFXZDZ1svjIEaQDKwoV5VDI6TW3xezzjY/NdJ+F1CozIcV30= From: Luca Fancellu To: "Daniel P. Smith" CC: Volodymyr Babchuk , Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Thread-Topic: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Thread-Index: AQHZxfetD3iMBVO78kiKHyDm3xOwK6/Y3kwA Date: Thu, 3 Aug 2023 18:05:52 +0000 Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> In-Reply-To: <20230803104438.24720-3-dpsmith@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB9737:EE_|AM7EUR03FT033:EE_|AS8PR08MB8088:EE_ X-MS-Office365-Filtering-Correlation-Id: a387b45c-033a-45e0-ddef-08db944c62b7 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XWC3wZBQLrbJLJ37zhcd5WFCAj/a4zDdzncRJsYDyC6q1vNDGm8H0MzHNu9ImQYdd6qtR+Xg9s+fhts/dS5iCPxJ/WNoETyYTF8Gg8NreioMBprp8eBIyCmZd42KD8/Z+ksCCU8V4EXl1tNr1PVcNR4EnT9TGVgiSmOwS6iWHXrDjqHAPz++WH7/0TNJzyay3MbYxlCq6fIuDmgIAm3x0IuHJzOaIDCEptSulhBALxzO+yNA2dnp0jPiqP3RR8homtMW3/QBE2uUbVQpt1uFqwqJR8PmbZN3QsplZGGZt+CRMugvHSAV4srhxZvaUMM+mFdNWseFdFOiHpm9XbXxnwSM36V/AQ4Ds7PQRwShf9O75r24kSyvOJ/wgFdoQkCF0JfVi2zCgYSThMkk6z7wYlmqWxMJXgzu4NAAl3Kx0rzVW+QnxTrUmv4RHRz9e0vzweO4ndlO1NNUbRl2kQ6RPLcUUrU1/vZ/UanPFAUDGAXH6AKAiMA4jsav2eKeGXQG9ABWiyaBKMOZYo1vGgmjrZAinxMhKndsYJlGBzvnAk4bLCL2+bxcj0jyHMo9HhKSCdfjvXVkLsCRnaieXnvoH7WIY1pZ6wy4u7wQ+tJuom4Kjah7OL/LtiNoo1IL1lSsj2R3rLt1tZINFXAv99UVlwbnGuBVl/R0DxvOcGmBlgk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(396003)(346002)(39860400002)(451199021)(2616005)(6506007)(41300700001)(26005)(186003)(8676002)(8936002)(66556008)(2906002)(91956017)(4326008)(76116006)(64756008)(66946007)(5660300002)(6916009)(316002)(66446008)(66476007)(6486002)(71200400001)(6512007)(478600001)(54906003)(38100700002)(122000001)(33656002)(86362001)(36756003)(38070700005)(2004002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <738C3F0E0AA8A24E8E19EB4F09354148@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9737 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7508740e-ef7b-4d1f-a759-08db944c46bd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1U/z/7Pc3YcfiqBBehOnFP6/GEhSVQc7zK8GY+yRndkrZu1GPXhPVGxy442SxGGWXi6DRdhpJLwXz6pq/xCr5JFLanFL2RyifLwno2tzZNePz+ZAxjCyHem2qL6hMCmp9kWNsPRSIcjtVh+do5eghPjtWw0SqZdB33E4rte+F0deZuL6FslDDM1FbGF7Pb3EsYq6wp45Az8y81Ls9BunSfOekgDfqbg9NBieEMWVPlxZ3sdrTHTZguYQj5claq8gRhqEXqKGmf+Yfe8UZOjDdEa+49pgVgLAOPHrcKrp38arUzKj6LgmzlyUSNQpcJngMHPBycn/0ulgeRcPd9J9K/EbLlL9M9GqDi2BF7JoBt+v7V+/NY79ZYPvne/TtDY7YB+NHy/ym3u+RwFni7zWgGvJqezPQQiVuFd3vQt3eFN7eQJirAyUyPnrN701v0WTyspwXaVmoMmQGOouj6F9gOEs1SECv1e9zjRqyxF8MSGP/YsoHHVUCO/H39opo8EN3iOIMUtukwVRSPeEybdlDsq35zEJXwzTWB2z2kuX2TSVoqE7VtjG/ET7EU+oNZljpoYZ0UgzJs6XhTYrQJWS5JzL5PSmBfrR3bo9d9us3bYYDxQk4gc+ZYakwJSF1itf0orli6rcd4yOeGthajm6qOdKC1JcVdNpeY1K2Wk1yJWoeGRJ88Z2u6lujWmZ9/NuQX+iQW9pvkzSDnokPI3kiQQwq3YysDQ/bPpVgrYAcJnqbt55F5Db8KM975n8kwPr X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199021)(82310400008)(46966006)(40470700004)(36840700001)(36756003)(33656002)(86362001)(82740400003)(40460700003)(40480700001)(54906003)(478600001)(81166007)(356005)(47076005)(2616005)(6506007)(336012)(186003)(26005)(6862004)(41300700001)(8936002)(8676002)(6512007)(6486002)(316002)(36860700001)(70586007)(4326008)(5660300002)(70206006)(2906002)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 18:06:39.7230 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a387b45c-033a-45e0-ddef-08db944c62b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8088 SGkgRGFuaWVsLA0KDQpbLi4uXQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9mZHQuYyBiL3hl bi9jb21tb24vZmR0LmMNCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gaW5kZXggMDAwMDAwMDAw MC4uOGQ3YWNhYWE0Mw0KPiAtLS0gL2Rldi9udWxsDQo+ICsrKyBiL3hlbi9jb21tb24vZmR0LmMN Cj4gQEAgLTAsMCArMSwxNTMgQEANCj4gKy8qDQo+ICsgKiBGbGF0dGVuZWQgRGV2aWNlIFRyZWUN Cj4gKyAqDQo+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTItMjAxNCBDaXRyaXggU3lzdGVtcywgSW5j Lg0KPiArICoNCj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl ZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHZlcnNpb24gMiBhcw0KPiArICogcHVibGlz aGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24uDQo+ICsgKi8NCg0KQ2FuIHlvdSBh ZGQgYW4gZW1wdHkgbGluZSBoZXJlLCBJIHRoaW5rIGl0IGltcHJvdmVzIHJlYWRhYmlsaXR5LCBJ IGtub3cgdGhhdCBzb21lIG90aGVyDQpoZWFkZXJzIGRvbuKAmXQgYWRkIGl0IHVuZm9ydHVuYXRl bHkNCg0KPiArI2luY2x1ZGUgPHhlbi9mZHQuaD4NCj4gKyNpbmNsdWRlIDx4ZW4vaW5pdC5oPg0K PiArI2luY2x1ZGUgPHhlbi9saWIuaD4NCj4gKyNpbmNsdWRlIDx4ZW4vbGliZmR0L2xpYmZkdC5o Pg0KPiArI2luY2x1ZGUgPHhlbi90eXBlcy5oPg0KPiArDQo+ICtib29sIF9faW5pdCBkZXZpY2Vf dHJlZV9ub2RlX21hdGNoZXMoDQo+ICsgICAgY29uc3Qgdm9pZCAqZmR0LCBpbnQgbm9kZSwgY29u c3QgY2hhciAqbWF0Y2gpDQo+ICt7DQpbLi4uXQ0KDQpFbXB0eSBsaW5lDQoNCj4gKyNpZm5kZWYg X19YRU5fRkRUX0hfXw0KPiArI2RlZmluZSBfX1hFTl9GRFRfSF9fDQo+ICsNCj4gKyNpbmNsdWRl IDx4ZW4vaW5pdC5oPg0KPiArI2luY2x1ZGUgPHhlbi9saWJmZHQvbGliZmR0Lmg+DQo+ICsjaW5j bHVkZSA8eGVuL3R5cGVzLmg+DQoNCkZvciB0aGUgbmV3IGZpbGVzLCBhcGFydCBmcm9tIE1pY2hh bOKAmXMgY29tbWVudHMsIGlmIEkgcmVtZW1iZXIgY29ycmVjdGx5IGluIHRoZSBwYXN0IEkgd2Fz IGFza2VkDQp0byBhZGQgdGhlc2UgbGluZXMgdG8gdGhlIGVuZCBvZiB0aGUgZmlsZToNCg0KLyoN CiogTG9jYWwgdmFyaWFibGVzOg0KKiBtb2RlOiBDDQoqIGMtZmlsZS1zdHlsZTogIkJTRCINCiog Yy1iYXNpYy1vZmZzZXQ6IDQNCiogaW5kZW50LXRhYnMtbW9kZTogbmlsDQoqIEVuZDoNCiovDQoN ClJlZ2FyZGluZyB0aGUgY29kaW5nIHN0eWxlLCBJIHRoaW5rIGl04oCZcyBiZXR0ZXIgdG8ga2Vl cCB0aGUgc3R5bGUgeW914oCZdmUgZm91bmQgaW4gdGhlIG9yaWdpbmFsIGZpbGUsDQphbmQgY2hh bmdlIG9ubHkgc29tZSBiaXRzIHdoZW4gdGhlIGNvZGUgaXMgbm90IGZvbGxvd2luZyBpdC4NCg0K SSBrbm93IHRoZXJlIGlzIG5vdGhpbmcgZW5mb3JjaW5nIHBhcmFtZXRlcnMgb24gdGhlIHNhbWUg bGluZSBvZiB0aGUgZnVuY3Rpb24gZGVmaW5pdGlvbiBhdCB0aGUNCm1vbWVudCwgYnV0IGl0IGlz IGhvdyBpdOKAmXMgZG9uZSBmcm9tIHRoZSBvcmlnaW5hbCBmaWxlIHNvIEkgd291bGQgc3RpY2sg d2l0aCBpdC4NCg0KUmVnYXJkaW5nIHRoZSB1MzIvdTY0IHR5cGVzLCBtYXliZSBzaW5jZSB5b3Ug YXJlIG1vdmluZyB0aGUgY29kZSBpdCBjYW4gYmUgdGhlIG9jY2FzaW9uIHRvDQpjb252ZXJ0IHRo ZW0sIGJ1dCBjaGVjayB3aXRoIHRoZSBtYWludGFpbmVyIGJlZm9yZS4NCg0KSeKAmXZlIGFsc28g dGVzdGVkIHRoaXMgc2VyaWUgYW5kIGl0IHdvcmtzIGZpbmUhIEnigJltIG5vdCBsZWF2aW5nIGFu eSB0YWcgYmVjYXVzZSB0aGlzIHBhdGNoIGlzIGdvaW5nIHRvDQpjaGFuZ2UgYW55d2F5Lg0KDQpD aGVlcnMsDQpMdWNhDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Aug 03 18:50:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 18:50:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576565.902836 (Exim 4.92) (envelope-from ) id 1qRdOf-0007av-1u; Thu, 03 Aug 2023 18:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576565.902836; Thu, 03 Aug 2023 18:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdOe-0007aM-Uo; Thu, 03 Aug 2023 18:50:04 +0000 Received: by outflank-mailman (input) for mailman id 576565; Thu, 03 Aug 2023 18:50:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdOd-0007MB-OU; Thu, 03 Aug 2023 18:50:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdOd-00076s-KY; Thu, 03 Aug 2023 18:50:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdOd-000673-2T; Thu, 03 Aug 2023 18:50:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRdOd-0001sU-1s; Thu, 03 Aug 2023 18:50:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0zQsRiBwm25rUemGyatuwdzUlueOGfyvBaJ4r0LAZ6s=; b=dGLayHolBpnwbSPXR9uU38y/ft 3B9b//IzWZZmpy8FN9heWKPmQOElr/O10+5m1AZeEaIWCsz9IyNmCMz0xkhurf2Hm63cfoKwp+zuS z7FFViE1dQfqB9jlUFmaIivvzjlrw0Y6H/LttKS1tomfib+G1cBTx39g86U00Vk407Wg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182170: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 X-Osstest-Versions-That: xen=dfc490a3740bb7d6889939934afadcb58891fbce From: osstest service owner Date: Thu, 03 Aug 2023 18:50:03 +0000 flight 182170 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182170/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 baseline version: xen dfc490a3740bb7d6889939934afadcb58891fbce Last test of basis 182136 2023-08-02 22:00:27 Z 0 days Testing same since 182170 2023-08-03 16:00:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git dfc490a374..1aa5acbbec 1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Aug 03 19:16:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 19:16:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576572.902846 (Exim 4.92) (envelope-from ) id 1qRdoJ-0001z5-3z; Thu, 03 Aug 2023 19:16:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576572.902846; Thu, 03 Aug 2023 19:16:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdoJ-0001yy-1K; Thu, 03 Aug 2023 19:16:35 +0000 Received: by outflank-mailman (input) for mailman id 576572; Thu, 03 Aug 2023 19:16:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdoG-0001ys-Um for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 19:16:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3fb27c51-3232-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 21:16:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2F9F61E4A; Thu, 3 Aug 2023 19:16:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 882EAC433C8; Thu, 3 Aug 2023 19:16:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fb27c51-3232-11ee-b269-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691090188; bh=yOeJu+vJIGCaAC6WsK3aZAvgZavyItDahnlqQtMZVag=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JLXv1feUrrRjs8Dkmk+6L+r7bQJc5z7VR1v5DoJns/1l2di7dmXXkp9QbF/9nArjU olgRg8r9IjC8gBnQUvoGRz/unXZPI62sHObJyQyRAz5SLS6mJKM+VCfEU+im/+aELf Jx4pIgU20LrHUs/i0WUtYsW6Mqgen3AqzyQnplA56t3GlGLfapqTDvbJtYq/0i8AsH 8J5P8EA/IZEha/J63JpN4u1XIkTogi2CLIoEW3xKlZqGnnfQ9I5P/I3ga3d+fYGacM ucNOlOUhHZuo8L79a0vp3ZQnpA2012ML5IMuwdgFACy9OCp6tnIlmhJR9tfhmNePnB LLqfvD+rYGfzg== Date: Thu, 3 Aug 2023 12:16:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Nicola Vetrini Subject: Re: [XEN PATCH 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 In-Reply-To: <9e89a09e-ed5e-5322-2b94-4547d930ac7f@suse.com> Message-ID: References: <9e89a09e-ed5e-5322-2b94-4547d930ac7f@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Jan Beulich wrote: > On 03.08.2023 04:00, Stefano Stabellini wrote: > > On Wed, 2 Aug 2023, Nicola Vetrini wrote: > >> The extern variable 'irq_desc' defined in 'irq.h' is shadowed by > >> local variables in the changed file. To avoid this, the variable is > >> renamed to 'irq_description'. > >> > >> No functional change. > >> > >> Signed-off-by: Nicola Vetrini > > > > Reviewed-by: Stefano Stabellini > > Btw, Stefano, could you please trim context when you reply to patches, > and when you add no other remarks besides offering a tag? > > Thanks, Jan Will do From xen-devel-bounces@lists.xenproject.org Thu Aug 03 19:23:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 19:23:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576575.902856 (Exim 4.92) (envelope-from ) id 1qRduq-0003SY-QK; Thu, 03 Aug 2023 19:23:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576575.902856; Thu, 03 Aug 2023 19:23:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRduq-0003SR-NO; Thu, 03 Aug 2023 19:23:20 +0000 Received: by outflank-mailman (input) for mailman id 576575; Thu, 03 Aug 2023 19:23:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRduo-0003SL-PG for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 19:23:18 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 325e9f33-3233-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 21:23:17 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D998E61E74; Thu, 3 Aug 2023 19:23:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3C7BC433C7; Thu, 3 Aug 2023 19:23:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 325e9f33-3233-11ee-b269-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691090595; bh=z4qx1DqzuV8mewQK3Q52hDDHbYVBzLiY4UAtU22xVTA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aQyvmJDcFC4bcszu2E0BKIsRxkk1ftrB0Jr2lafTgzkVkZIaPoFl9attiIK066Q3I o09E/R5l7zxdqzPLuknLttDyfB5RgfkXsUHv2+C3roZ6pU7l8DtWWg8b8PQ7UzTiTZ 9O0AzHs0fi/MHP1L059i9ZXkpFJpObzVaDpWUTFH+CFtZGxhlHGZKGM2/t8hY3WNzj b1lCXUmxAPjg1Xl41VhHGGbcnFkY5GJIxLKcGnqil/4PUJt9KASi+89QTEM2K6KA0o PTSVhcGIpZUX4H7kv4n7fbZ16749d93Fh/6+CirNnexfIPALo88TcyIf5opoP4aCbk V7SfIqr+DjInQ== Date: Thu, 3 Aug 2023 12:23:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: Jan Beulich , Stefano Stabellini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> Message-ID: References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Nicola Vetrini wrote: > On 03/08/2023 11:01, Jan Beulich wrote: > > On 03.08.2023 04:13, Stefano Stabellini wrote: > > > On Wed, 2 Aug 2023, Nicola Vetrini wrote: > > > > @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void > > > > *data) > > > > > > > > switch ( action->ack_type ) > > > > { > > > > - cpumask_t *cpu_eoi_map; > > > > > > It is only used by case ACKTYPE_EOI so it can be moved there (with a new > > > block): > > > > > > > > > case ACKTYPE_EOI: > > > { > > > cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); > > > cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); > > > spin_unlock_irq(&desc->lock); > > > on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); > > > return; > > > } > > > } > > > > This pattern (two closing braces at the same level) is why switch scope > > variable declarations were introduced (at least as far as introductions > > by me go). If switch scope variables aren't okay (which I continue to > > consider questionable), then this stylistic aspect needs sorting first > > (if everyone else thinks the above style is okay - with the missing > > blank line inserted -, then so be it). > > > > Jan > > Actually, they can be deviated because they don't result in wrong code being > generated. > This, modulo the review comments received, is what most of the code would look > like if > they weren't, with the biggest pain point being that in many cases the choice > is either > the pattern with blocks for certain clauses or moving them in the enclosing > scope, which may > be several hundred lines above. If there's agreement on deviating them, I can > drop the patches > dealing with switches and do a v2 with just the other modifications. I think we should deviate them. Good idea to remove them in v2. From xen-devel-bounces@lists.xenproject.org Thu Aug 03 19:26:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 19:26:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576581.902865 (Exim 4.92) (envelope-from ) id 1qRdyG-00047k-EL; Thu, 03 Aug 2023 19:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576581.902865; Thu, 03 Aug 2023 19:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdyG-00047d-Bl; Thu, 03 Aug 2023 19:26:52 +0000 Received: by outflank-mailman (input) for mailman id 576581; Thu, 03 Aug 2023 19:26:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRdyF-00047X-Gh for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 19:26:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b07a597f-3233-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 21:26:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C26D260C5B; Thu, 3 Aug 2023 19:26:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C80AAC433C8; Thu, 3 Aug 2023 19:26:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b07a597f-3233-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691090807; bh=ah2EhQb8tvf85Ee3ASO1btgn1Wfur/rLCfALJfIjU2U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HzMVsUDxB6LFSXW5SK/huZHYbEaXxfvW/vN5EJdQ38jlVXFt3sHkIS42lsHdJ5+gi k5HDbBc87lA1wTbTLK9s5MZPrwroJlfSi98VIiQhNMgR2mM2xtQ77gL9ieTIiR23HQ Lls1t0RVfO0mDR5UF/GXQRTR6LLlszwH6oxCENSGLg4gZQryM6SANneZhYEI65flHX AhivZcS9i0cL4Aw++i/wFFQ6JQkfbLgkJxKC+V013g3LbKtxGy0cFqC4OyxplcoP+6 kWdXamwTQBlvnCqDlnjKwfF7ZwZWJKXMAn0c3NexFXu8yryT6GBFLYtYHaZiVkScqp JrgeMphwMtJWA== Date: Thu, 3 Aug 2023 12:26:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Luca Fancellu , Federico Serafini , Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names In-Reply-To: <1e2d06ab-ad3a-4e5a-ac78-d20bad28bb20@xen.org> Message-ID: References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> <1e2d06ab-ad3a-4e5a-ac78-d20bad28bb20@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-764670787-1691090807=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-764670787-1691090807=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 3 Aug 2023, Julien Grall wrote: > On 03/08/2023 12:52, Luca Fancellu wrote: > > > On 3 Aug 2023, at 12:46, Julien Grall wrote: > > > > > > Hi Luca, > > > > > > On 03/08/2023 11:28, Luca Fancellu wrote: > > > > > On 3 Aug 2023, at 09:26, Federico Serafini > > > > > wrote: > > > > > > > > > > Add missing parameter names to address violation of MISRA C:2012 > > > > > rule 8.2 ("Function types shall be in prototype form with named > > > > > parameters"). > > > > > > > > > > No functional changes. > > > > > > > > > > Signed-off-by: Federico Serafini > > > > > --- > > > > > Changes in v2: > > > > > - memset() adjusted. > > > > > --- > > > > > xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- > > > > > 1 file changed, 21 insertions(+), 21 deletions(-) > > > > > > > > > > diff --git a/xen/include/xen/string.h b/xen/include/xen/string.h > > > > > index b4d2217a96..e91e3112e0 100644 > > > > > --- a/xen/include/xen/string.h > > > > > +++ b/xen/include/xen/string.h > > > > > @@ -12,27 +12,27 @@ > > > > > #define strncpy __xen_has_no_strncpy__ > > > > > #define strncat __xen_has_no_strncat__ > > > > > > > > > > -size_t strlcpy(char *, const char *, size_t); > > > > > -size_t strlcat(char *, const char *, size_t); > > > > > -int strcmp(const char *, const char *); > > > > > -int strncmp(const char *, const char *, size_t); > > > > > -int strcasecmp(const char *, const char *); > > > > > -int strncasecmp(const char *, const char *, size_t); > > > > > -char *strchr(const char *, int); > > > > > -char *strrchr(const char *, int); > > > > > -char *strstr(const char *, const char *); > > > > > -size_t strlen(const char *); > > > > > -size_t strnlen(const char *, size_t); > > > > > -char *strpbrk(const char *, const char *); > > > > > -char *strsep(char **, const char *); > > > > > -size_t strspn(const char *, const char *); > > > > > - > > > > > -void *memset(void *, int, size_t); > > > > > -void *memcpy(void *, const void *, size_t); > > > > > -void *memmove(void *, const void *, size_t); > > > > > -int memcmp(const void *, const void *, size_t); > > > > > -void *memchr(const void *, int, size_t); > > > > > -void *memchr_inv(const void *, int, size_t); > > > > > +size_t strlcpy(char *dest, const char *src, size_t size); > > > > > +size_t strlcat(char *dest, const char *src, size_t size); > > > > > +int strcmp(const char *cs, const char *ct); > > > > > +int strncmp(const char *cs, const char *ct, size_t count); > > > > > +int strcasecmp(const char *s1, const char *s2); > > > > > +int strncasecmp(const char *s1, const char *s2, size_t len); > > > > > +char *strchr(const char *s, int c); > > > > > +char *strrchr(const char *s, int c); > > > > > +char *strstr(const char *s1, const char *s2); > > > > > +size_t strlen(const char *s); > > > > > +size_t strnlen(const char *s, size_t count); > > > > > +char *strpbrk(const char *cs, const char *ct); > > > > > +char *strsep(char **s, const char *ct); > > > > > +size_t strspn(const char *s, const char *accept); > > > > > + > > > > > +void *memset(void *s, int c, size_t count); > > > > > +void *memcpy(void *dest, const void *src, size_t count); > > > > There is a comment in arch/arm/rm32/lib/memcpy.S with this: > > > > /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ > > > > > +void *memmove(void *dest, const void *src, size_t count); > > > > There is a comment in arch/arm/rm32/lib/memmove.S with this: > > > > * Prototype: void *memmove(void *dest, const void *src, size_t n); > > > > > +int memcmp(const void *cs, const void *ct, size_t count); > > > > > +void *memchr(const void *s, int c, size_t n); > > > > > +void *memchr_inv(const void *s, int c, size_t n); > > > > @Stefano: would it make sense to remove it as part of this patch or > > > > maybe not? > > > > > > They are a verbatim copy of the Linux code. So I would rather no touch it. > > > > Oh I see! Thank you for pointing that out, then I’m wondering if it’s there > > a reason why we > > are using ‘count’ instead of ’n’ as third parameter name, I know Stefano > > suggested that, so > > It’s just a curiosity. Maybe it’s for clarity? > > I guess because the generic implementation of memset (see xen/lib/memset.c) is > using 'count' rather than 'n'. Yep > Given what Andrew said, I would say we should rename the parameter to 'n'. Yes, either way works. I was only trying to be consistent with xen/lib/memset.c. It is also fine to change xen/lib/memset.c instead. --8323329-764670787-1691090807=:2127516-- From xen-devel-bounces@lists.xenproject.org Thu Aug 03 19:31:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 19:31:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576585.902876 (Exim 4.92) (envelope-from ) id 1qRe2D-0005ZZ-UY; Thu, 03 Aug 2023 19:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576585.902876; Thu, 03 Aug 2023 19:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRe2D-0005ZS-Rm; Thu, 03 Aug 2023 19:30:57 +0000 Received: by outflank-mailman (input) for mailman id 576585; Thu, 03 Aug 2023 19:30:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRe2C-0005ZM-J5 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 19:30:56 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42c102f7-3234-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 21:30:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1906C61E4A; Thu, 3 Aug 2023 19:30:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92F0EC433C7; Thu, 3 Aug 2023 19:30:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42c102f7-3234-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691091052; bh=lI+6uQRkufLyRH1Nq8UwjVXw5e13N1CEd6fGUHG3274=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=g+O5MBRK/ZRdQsVdn3WxLDWMcRyOAvhSdicBjea89BUtLn4vj2g61GGNJ/UvhY9gX 5vlAsEo7ekB2TvSteGDmfT97tqFVtfb1Yd+zsw1oMWUnbRhv29qMYvx5Xn1K5cQDnL 1MH518/OJTzQ7nCykl85Y/RYPjQ3Pre8nqzVk9sGdphj6pQYOBnW+Lc+C1pih/wYPA Jrj2/2mgx7cmZJDRwLkNbmgLbqX9tMbbpDd/IclHZ4ph9VnhHnnbVMXN16nFYB+1WG bYax+/cnHAJxudKwEi5GeUqr0MSDuiYwnLejq9F4hQGuXD3Pq0+OhXR2UtaN9hI1JX 4jxxTrHYAQYdg== Date: Thu, 3 Aug 2023 12:30:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Stefano Stabellini , Jan Beulich , Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH] console: generalize the ability for domU access In-Reply-To: <98db3f0c-6188-ba1b-7252-ae3e31adbf36@apertussolutions.com> Message-ID: References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> <98db3f0c-6188-ba1b-7252-ae3e31adbf36@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Daniel P. Smith wrote: > On 8/2/23 19:58, Stefano Stabellini wrote: > > On Wed, 2 Aug 2023, Jan Beulich wrote: > > > > - for ( ; ; ) > > > > + if ( d == NULL ) > > > > > > This covers both Xen receiving input and the domain receiving input having > > > gone away. Originally in the latter case the next sequential (in domid > > > numbering) domain would be switched to. In the new logic you start over > > > from the beginning of the domain list. Such a change in behavior (if > > > deemed acceptable at all, which I'm not convinced of) needs calling out in > > > the description. > > > > I think it would be best to keep the current behavior as we already > > have people using it unless we have strong reasons to change it. > > I agree and intended to keep the order of switching but I disagree on keeping > the complete current behavior. I mean that by the complete current behavior > being defined, at least for Arm, as meaning only the domains created at boot. > The is_console flag in struct domain is the DAC equivalent to granting the > FLASK access XEN__READCONSOLE to a domain, it was just never implemented/used > until domoless enable it. An intended consequence of this patch is to ensure > any domain granted the privilege, either through the DAC is_console or FLASK > XEN__READCONSOLE, is included in the rotation regardless if the domain was > created at boot or at runtime. I think that's fine. Let's say that we have Xen, Dom0, and 2 Dom0less DomUs at boot. The console will start on Dom0 and the rotation would go: Dom0->Dom1->Dom2->Xen->Dom0... If a new domain comes up at runtime with is_console, it would become: Dom0->Dom1->Dom2->Dom3->Xen->Dom0... From xen-devel-bounces@lists.xenproject.org Thu Aug 03 19:42:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 19:42:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576589.902885 (Exim 4.92) (envelope-from ) id 1qReDk-00077u-02; Thu, 03 Aug 2023 19:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576589.902885; Thu, 03 Aug 2023 19:42:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qReDj-00077n-T7; Thu, 03 Aug 2023 19:42:51 +0000 Received: by outflank-mailman (input) for mailman id 576589; Thu, 03 Aug 2023 19:42:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qReDi-00077f-F9 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 19:42:50 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb90aea6-3235-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 21:42:48 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691091754739117.37028717622366; Thu, 3 Aug 2023 12:42:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb90aea6-3235-11ee-b269-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691091755; cv=none; d=zohomail.com; s=zohoarc; b=GE1T+WHsDuXoDxDQ8av1C/yiUKuG2q38YkCj/VeUH1HcOriS96YJUlmj5bSA+1YZ3nL5mfbUWyMJVRx7NtmDO283M05GDw4XEqk/LAnv6c916BMFJjwdL63RIrVAAYpMSqwnL3TunA/XiDbSBheNO842FnFE7BmICM6b/sT1Uak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691091755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2I+Vu5mQ8GuInwyRjafb7KsZvx3azkyTFJ/xC5tSh2w=; b=IM24OgF0X3Qf58rIEkYMk/1d0A+J0jg2vWFBSuaF32FYLlDEJsX1a75Kb7KnCY9t7DQ0ULMycBNe8kJ4TMC5S/vyxZPf83xLKfMAiAzFt/ubbU11cyJ+FNo9uR4SoCYuqEKYhRNg6uPeUI6dtpVx02BxkaAswuNx1Z9A/4Hk0cw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691091755; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=2I+Vu5mQ8GuInwyRjafb7KsZvx3azkyTFJ/xC5tSh2w=; b=mEWUyf/vLxXyaQqpVzpZhiKxskDw5/T7MkvNt+dVMzwxE2ljGN841JL+l2cGuPGV 6MJZnCIrDWSNmP6Im4ENDgPKDaZUF7z9ll0trFLhBF23Yo0juMqxS/j/wIABrbta4G3 QOc2ye/J/NBPN7mj+STxXZPCRrKjDMOe0aqus8ig= Message-ID: <4e5be83a-64f2-7a63-ec61-e992c8a8c1fb@apertussolutions.com> Date: Thu, 3 Aug 2023 15:42:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: Stefano Stabellini Cc: Jan Beulich , Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> <98db3f0c-6188-ba1b-7252-ae3e31adbf36@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 15:30, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Daniel P. Smith wrote: >> On 8/2/23 19:58, Stefano Stabellini wrote: >>> On Wed, 2 Aug 2023, Jan Beulich wrote: >>>>> - for ( ; ; ) >>>>> + if ( d == NULL ) >>>> >>>> This covers both Xen receiving input and the domain receiving input having >>>> gone away. Originally in the latter case the next sequential (in domid >>>> numbering) domain would be switched to. In the new logic you start over >>>> from the beginning of the domain list. Such a change in behavior (if >>>> deemed acceptable at all, which I'm not convinced of) needs calling out in >>>> the description. >>> >>> I think it would be best to keep the current behavior as we already >>> have people using it unless we have strong reasons to change it. >> >> I agree and intended to keep the order of switching but I disagree on keeping >> the complete current behavior. I mean that by the complete current behavior >> being defined, at least for Arm, as meaning only the domains created at boot. >> The is_console flag in struct domain is the DAC equivalent to granting the >> FLASK access XEN__READCONSOLE to a domain, it was just never implemented/used >> until domoless enable it. An intended consequence of this patch is to ensure >> any domain granted the privilege, either through the DAC is_console or FLASK >> XEN__READCONSOLE, is included in the rotation regardless if the domain was >> created at boot or at runtime. > > I think that's fine. > > Let's say that we have Xen, Dom0, and 2 Dom0less DomUs at boot. The > console will start on Dom0 and the rotation would go: > > Dom0->Dom1->Dom2->Xen->Dom0... > > If a new domain comes up at runtime with is_console, it would become: > > Dom0->Dom1->Dom2->Dom3->Xen->Dom0... Correct, that is the sequence I was attempting to achieve, but then I ran into the dom0less CI configuration of booting a system with Xen and a DomU. The above rotation will stay the same less dom0/hwdom, but it did quickly point out that I made an assumption about the hardware domain always being present. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 19:58:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 19:58:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576593.902896 (Exim 4.92) (envelope-from ) id 1qReSK-0000IV-7y; Thu, 03 Aug 2023 19:57:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576593.902896; Thu, 03 Aug 2023 19:57:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qReSK-0000IK-56; Thu, 03 Aug 2023 19:57:56 +0000 Received: by outflank-mailman (input) for mailman id 576593; Thu, 03 Aug 2023 19:57:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qReSI-0000IE-Ej for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 19:57:54 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 061a4166-3238-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 21:57:51 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691092667791199.77173568139017; Thu, 3 Aug 2023 12:57:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 061a4166-3238-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691092669; cv=none; d=zohomail.com; s=zohoarc; b=EDsZzosFgYgJh8PKJJRISsmDyPI4f7p1mAOdIaVUg4FY7Nwy23IUbQxlIL7Tcov4k/uJ4eiU3W4+YWylfXdmU6wLGSE+spMXiWSY+smbPT86UwYjvHZk7Fjqs5knhgLP1UGKQvjUmTYc6OhGxsMKuRDt5rRdCZ08/6yPQQg7cq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691092669; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=jUXgWDeDFZinWlrthFhxXoyj9zP+vaetJ6tzgDwrRuY=; b=VLQH9S+MHabG1B0sEZBx6co3dR+HW2ZwxzG6q1A84C/yI198ZRptDPhYjdjubPfoCJbAGIY44oUrT/cGm4kP5tv+3PGzxFmu194xPAEuh8UfRkPGW+t+lx2EjdbSlYqJ2y2H3cPIjXEoEt74iZuJiFW+/lLXIDsUi5lxbi09IlI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691092669; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=jUXgWDeDFZinWlrthFhxXoyj9zP+vaetJ6tzgDwrRuY=; b=abr9C0m/05aXKQDtnPIr/nACoDUmN4S5NxCtDEcgYmIK7IMBFktLHYDp56/zj4Pf cixjUduqwITAS+ZOe0l1ao4YuNYPegIQTU1ToUcd1h6SN6e3ziC7ZIwhEQVL7pxvpAK 7jAcnidnB6PiMGhMAxNA0QVL5pTBdaqPfBZsSdIM= Message-ID: <8a51be9e-0131-0590-9aea-bbec146ce239@apertussolutions.com> Date: Thu, 3 Aug 2023 15:57:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Luca Fancellu Cc: Volodymyr Babchuk , Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/3/23 14:05, Luca Fancellu wrote: > Hi Daniel, > > [...] >> diff --git a/xen/common/fdt.c b/xen/common/fdt.c >> new file mode 100644 >> index 0000000000..8d7acaaa43 >> --- /dev/null >> +++ b/xen/common/fdt.c >> @@ -0,0 +1,153 @@ >> +/* >> + * Flattened Device Tree >> + * >> + * Copyright (C) 2012-2014 Citrix Systems, Inc. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ > > Can you add an empty line here, I think it improves readability, I know that some other > headers don’t add it unfortunately Yah, that is no problem. >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +bool __init device_tree_node_matches( >> + const void *fdt, int node, const char *match) >> +{ > [...] > > Empty line Ack. >> +#ifndef __XEN_FDT_H__ >> +#define __XEN_FDT_H__ >> + >> +#include >> +#include >> +#include > > For the new files, apart from Michal’s comments, if I remember correctly in the past I was asked > to add these lines to the end of the file: > > /* > * Local variables: > * mode: C > * c-file-style: "BSD" > * c-basic-offset: 4 > * indent-tabs-mode: nil > * End: > */ You are correct, I will get them added. > Regarding the coding style, I think it’s better to keep the style you’ve found in the original file, > and change only some bits when the code is not following it. > > I know there is nothing enforcing parameters on the same line of the function definition at the > moment, but it is how it’s done from the original file so I would stick with it. > > Regarding the u32/u64 types, maybe since you are moving the code it can be the occasion to > convert them, but check with the maintainer before. I can leave the main code as is, but I do think header decl's should be styled correctly as there is no need to have them churn in the future over purely style changes. > I’ve also tested this serie and it works fine! I’m not leaving any tag because this patch is going to > change anyway. No worries, thank you for taking the time to review the series. v/r, dps From xen-devel-bounces@lists.xenproject.org Thu Aug 03 20:20:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 20:20:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576597.902906 (Exim 4.92) (envelope-from ) id 1qRenc-0002rd-0Q; Thu, 03 Aug 2023 20:19:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576597.902906; Thu, 03 Aug 2023 20:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRenb-0002rW-TB; Thu, 03 Aug 2023 20:19:55 +0000 Received: by outflank-mailman (input) for mailman id 576597; Thu, 03 Aug 2023 20:19:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRena-0002rQ-T2 for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 20:19:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1a017a79-323b-11ee-b269-6b7b168915f2; Thu, 03 Aug 2023 22:19:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3EB2E61DC5; Thu, 3 Aug 2023 20:19:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39F36C433C9; Thu, 3 Aug 2023 20:19:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a017a79-323b-11ee-b269-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691093990; bh=EBRDH3RTt6p1VCNkOrlD14ML+NHZpUaq1EDCelSZ6X4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tlJESTrA9Tzt/Edm6O21eU71ELqESLx6dY9aq+AK6+ZR4OQsC88mXFRnE/TYRnvQW FOtyGx/NFQGal+vy54p5gsozvJF7oCIVs+3+MzQOrlTew2A4BYN9Dax0TkvhMNJuSb 198NO01n5SKCPD11223fkUPoTKL1gw8ghKsCXnNhHSmSqtCbKXVomsvh04wkigJmKJ zYSoAyPBbHxK90DEk9abicLx2IIdL4qT27yTlICuz8Qz7PC+/32OIhWH+tkij/4uKz w1xnDqhVyh2owvJS+LuAMuPNVqrUlqdakdEZjOJSyHvEqzsBdre0EL1W4z8XIQ2zrn FMqkauTrCjPIA== Date: Thu, 3 Aug 2023 13:19:47 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Stefano Stabellini , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles In-Reply-To: Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Daniel P. Smith wrote: > On 8/1/23 20:54, Stefano Stabellini wrote: > > On Tue, 1 Aug 2023, Daniel P. Smith wrote: > > > The existing concepts such as unbounded domain, ie. all powerful, control > > > domain and hardware domain are, effectively, roles the domains provide for > > > the > > > system. Currently, these are represented with booleans within `struct > > > domain` > > > or global domid variables that are compared against. This patch begins to > > > formalize these roles by replacing the `is_control` and `is_console`, > > > along > > > with expanding the check against the global `hardware_domain` with a > > > single > > > encapsulating role attribute in `struct domain`. > > > > > > Signed-off-by: Daniel P. Smith > > > > This is definitely heading in the right direction > > Thank you, it is good to know there is some agreement here. > > > > --- > > > xen/arch/arm/domain_build.c | 2 ++ > > > xen/arch/x86/setup.c | 2 ++ > > > xen/common/domain.c | 14 +++++++++++++- > > > xen/include/xen/sched.h | 16 +++++++++------- > > > xen/include/xsm/dummy.h | 4 ++-- > > > xen/xsm/flask/hooks.c | 12 ++++++------ > > > 6 files changed, 34 insertions(+), 16 deletions(-) > > > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > > index 39b4ee03a5..51b4daefe1 100644 > > > --- a/xen/arch/arm/domain_build.c > > > +++ b/xen/arch/arm/domain_build.c > > > @@ -4201,6 +4201,8 @@ void __init create_dom0(void) > > > if ( IS_ERR(dom0) ) > > > panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); > > > + dom0->role |= ROLE_UNBOUNDED_DOMAIN; > > > > I am not a fan of "UNBOUNDED". Maybe "PRIMARY"? "PRIVILEGED"? "SUPER"? > > "ROOT"? > > > > I also recognize I am not good at naming things so I'll stop here and > > let other provide better feedback :-) > > In first version of hyperlaunch and in the early roles work, I was working to > move toward eliminating this concept entirely. The reality is this is a model > that has existed for over 20 years and there are those who accept and embrace > the model. Introducing the name UNBOUNDED was to at least break the idea that > the all powerful domain necessarily is the first/initial domain to run. With > hyperlaunch, there are still security-based scenarios where you might want to > run a DomB before starting an all privileged domain. I spent quite some time, > probably more than I should have, to find a good name that expresses what this > role is. Considering a comment below and a comment by Jan, I am starting to > think a better way to view it is a domain that assumes all roles in the > system. So your suggestions of SUPER or ROOT might be more fitting. I > considered ROLE_ALL, but something about it doesn't sit right with me. With > that said I welcome the yak shaving of naming to begin. ( ^_^) > > > Also, do we actually need unbounded given that it gets replaced with > > control_domain pretty soon? > > Yes, because as mentioned above, this is meant to express a domain that has > been assigned all roles, for which later the domain may decided to delegate > the role to another domain. > > > I am asking because I think that at least from a safety perspective it > > would be a problem to run a domain as "unbounded". In a safety system, > > we wouldn't want anything to be unbounded, not even temporarily at boot. > > If "unbounded" is removed before running dom0, then of course it is no > > problem because actually dom0 never gets to run with "unbounded" set. > > I think this is were the name UNBOUNDED may have been a bad choice. The > UNBOUNDED role is dom0. It is the control domain, the hardware domain, the > Xenstore domain, and the crash domain (if that were to be solidified). > > > (I am currently thinking of solving the privilege issue by using XSM and > > removing most privileges from Dom0.) > > I obviously would be a huge advocate of that approach. ( ^_^) Thanks for the history, that helps. I was asking because I would like to make sure that all the options below are possible and easy to achieve: 1) traditional dom0 + some traditional domUs booted in a dom0less fashion 2) only traditional domUs booted in a dom0less fashion (no dom0 at all) 3) not-godlike-but-still-super dom0 + some traditional domUs booted in a dom0less fashion 4) domB booting This ROLE_ALL domain would be dom0 in 1) and would be domB in 4). In 2), there is no dom0 so there should also be no ROLE_ALL domain. All good so far. In 3), it looked to me that we would be creating a ROLE_ALL domain, then taking away some of the ROLEs. It doesn't sound right? Let's say that we want to have a hardware_domain (in the sense of default recipient of hardware, not necessarily privileged) with dm_ops access, but no domctl access. How would you go about it? Would it be required to go through the ROLE_ALL stage? How does it compare to the way it would work today without this patch applied? Today, does XSM kick in after is_privileged is set, effectively being the same thing as XSM kicking in later and removing some ROLEs after ROLE_ALL is already set? So, basically nothing is changing? > > > if ( alloc_dom0_vcpu0(dom0) == NULL ) > > > panic("Error creating domain 0 vcpu0\n"); > > > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > > > index 2dbe9857aa..4e20edc3bf 100644 > > > --- a/xen/arch/x86/setup.c > > > +++ b/xen/arch/x86/setup.c > > > @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const > > > module_t *image, > > > if ( IS_ERR(d) ) > > > panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); > > > + d->role |= ROLE_UNBOUNDED_DOMAIN; > > > + > > > init_dom0_cpuid_policy(d); > > > if ( alloc_dom0_vcpu0(d) == NULL ) > > > diff --git a/xen/common/domain.c b/xen/common/domain.c > > > index 8fb3c052f5..0ff1d52e3d 100644 > > > --- a/xen/common/domain.c > > > +++ b/xen/common/domain.c > > > @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) > > > setup_io_bitmap(dom0); > > > #endif > > > + /* > > > + * "dom0" may have been created under the unbounded role, demote it > > > from > > > + * that role, reducing it to the control domain role and any other > > > roles it > > > + * may have been given. > > > + */ > > > + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); > > > + dom0->role |= ROLE_CONTROL_DOMAIN; > > > > I think we need a better definition of the three roles to understand > > what this mean. > > Definition and as highlighted, a better name. > > > > rcu_unlock_domain(dom0); > > > iommu_hwdom_init(d); > > > @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, > > > } > > > /* Sort out our idea of is_control_domain(). */ > > > - d->is_privileged = flags & CDF_privileged; > > > + if ( flags & CDF_privileged ) > > > + d->role |= ROLE_CONTROL_DOMAIN; > > > + else > > > + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ > > > /* Sort out our idea of is_hardware_domain(). */ > > > if ( is_initial_domain(d) || domid == hardware_domid ) > > > @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, > > > old_hwdom = hardware_domain; > > > hardware_domain = d; > > > + d->role |= ROLE_HARDWARE_DOMAIN; > > > } > > > TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); > > > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > > > index a9276a7bed..695f240326 100644 > > > --- a/xen/include/xen/sched.h > > > +++ b/xen/include/xen/sched.h > > > @@ -467,8 +467,10 @@ struct domain > > > #endif > > > /* is node-affinity automatically computed? */ > > > bool auto_node_affinity; > > > - /* Is this guest fully privileged (aka dom0)? */ > > > - bool is_privileged; > > > +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) > > > +#define ROLE_CONTROL_DOMAIN (1U<<1) > > > +#define ROLE_HARDWARE_DOMAIN (1U<<2) > > > > This is a great step in the right direction but I think at least a short > > in-code comment to explain the difference between the three > > Ack. > > > > + uint8_t role; > > > /* Can this guest access the Xen console? */ > > > bool is_console; > > > /* Is this guest being debugged by dom0? */ > > > @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); > > > static always_inline bool is_initial_domain(const struct domain *d) > > > { > > > - static int init_domain_id = 0; > > > - > > > - return d->domain_id == init_domain_id; > > > + return d->role & ROLE_UNBOUNDED_DOMAIN; > > > } > > > > As far as I can tell this is the only functional change in this patch: > > given that dom0 loses unbounded soon after boot, the "is_initial_domain" > > checks will start to fail? > > Today, dom0 should not lose any of its roles at boot unless dom0less were to > create a hardware domain. I don't understand this sentence. To me, hardware_domain means "default recipient of hardware devices". It also happens to be traditionally associated with Dom0, so many privilege checks are hardware_domain check, although they should be instead control_domain checks. So if you say "dom0 should not lose any of its roles at boot unless dom0less were to create a hardware domain", I read it as: "dom0 (all powerful) would not lose any of its powers at boot unless we created dom0 (hardware domain, all powerful) with other domUs at boot using dom0less." which I don't understand > Upon reflection, I am thinking this check might want renaming to align with > the rename of this role. > > > We have a few of them in the code and I couldn't rule out that at least > > these 3 could happen at runtime: > > > > xen/common/sched/core.c: else if ( is_initial_domain(d) && > > opt_dom0_vcpus_pin ) > > xen/common/sched/core.c: else if ( is_initial_domain(d) ) > > xen/common/sched/arinc653.c: if ( is_initial_domain(unit->domain) ) > > > > Maybe they need to be changed to control_domain checks? > > Perhaps, I would want to study them a bit before switching them over. +1 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 20:37:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 20:37:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576602.902916 (Exim 4.92) (envelope-from ) id 1qRf4E-0005MV-HD; Thu, 03 Aug 2023 20:37:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576602.902916; Thu, 03 Aug 2023 20:37:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRf4E-0005MO-Dm; Thu, 03 Aug 2023 20:37:06 +0000 Received: by outflank-mailman (input) for mailman id 576602; Thu, 03 Aug 2023 20:37:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRf4D-0005MI-6s for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 20:37:05 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f40c026-323d-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 22:37:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f40c026-323d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691095021; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Qo2z+FkjxDwHPIt1ZvN4XJLzKkB6Iynwj4/otjK3SjQ=; b=FGe2wWDDOQ15hZqamzvae3bZK6XB1/9STd+Ar+24PTtNZwsylEAhTka3 VCfBvx8+Er8hu1yJUcK9wA4Ke5ITASvwlCkAx1pt+K6uh1eaTEYwQyMBx U2RMT9Knr+Le4nULmLDrwvnxcd7gJRkQm8UNacXFeVZK9aPpP0Qi2acJe E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118869900 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:roLjjq7yYmdf+K0AgrqTTAxRtITHchMFZxGqfqrLsTDasY5as4F+v mEZUWjUPa7YZ2Sgetp3b4XkpBkOu5bcyoRqGwNsq3phHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPaAT5weF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 OcBFhI3Yh2/ocG7nrS7QfIzl/hyFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrlD5fydVtxS+oq0v7nKI5AdwzKLsIJzefdniqcB9xx/I9 jyXrjyhav0cHIyG2ASr2G6Iv+/OryelQNlOD5bo1fE/1TV/wURMUUZLBDNXu8KRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3OcpQRQ62 1nPmMnmbRRtrbmURHS15rqS6zSoNkA9D0UPeCsFRgst+MT4rcc4iRenZtRsCqmulfXuBCr9h TuNqUAWgrwJiMcR2qaT/FbZgimtrJzEUg404ArMWmuvqAh+YeaNa5Sz7FnH7d5JNIuDUkSap 38AhtSf6+YVS5qKkUSlQuwLEKu4+vWtPzjVgFopFJ4knxym+2SiZpxX+DFzPgF2dM0AcCXqS EDWsAJVopRUOROXgbRfOtzrTZ5wlO65SIqjD6qPBjZTXnRvXB6c5R9MX0Kd40bOnRYqkaokZ oanIP/5WB72Fp9b5DaxQu4c15oiySY/2X7fSPjH8vi37VaNTCXLEOlYaTNiesh8tfrZ+1uNr 76zIuPQk31ivPvCjj47GGL5BXQDNjAFCJ//sKS7ncbTc1M9SAnN5xI8qI7NmrCJfYwPzo8kH VnnACe0LWbCaYXvc1niV5yaQOqHsWxDhXw6JzcwGl2jxmIuZ42ihI9GKcpuJel4qr0+laAvJ xXgRylnKq0eIgkrBhxHNcWtxGCcXEvDaf2y09qNP2FkIs8Iq/3h8d74ZAr/nBTi/QLu3fbSV 4aIj1uBKbJaHlQKMSojQK73p79HlSRHyb0asoqhCoU7RXgAB6Aze3Os0qFtcpFTQfgBrxPDv zur7d4jjbGli+cIHBPh3Mhoc6/B/zNCI3dn IronPort-HdrOrdr: A9a23:6N+J3aMcfLuFTMBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4= X-Talos-CUID: 9a23:fVn4gGADvaz+UJv6Ezh87XA2IMwoTlv+wSnWI0SjVndVGYTAHA== X-Talos-MUID: 9a23:55QuTAZxnFUv1uBT5yb9uh9IKONR46WcDB4VyskdkJmnOnkl X-IronPort-AV: E=Sophos;i="6.01,253,1684814400"; d="scan'208";a="118869900" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jason Andryuk , "Daniel Smith" , Christopher Clark Subject: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator Date: Thu, 3 Aug 2023 21:36:50 +0100 Message-ID: <20230803203650.1474936-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The opensuse-tumbleweed build jobs currently fail with: /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NULL [-Werror=address] 56 | if (!key->p || !key->q || !key->u) { | ^ In file included from /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17: /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12: note: 'p' declared here 28 | tpm_bn_t p; | ^ This is because all tpm_bn_t's are 1-element arrays (of either a GMP or OpenSSL BIGNUM flavour). The author was probably meaning to do value checks, but that's not what the code does. Adjust it to compile. No functional change. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Juergen Gross CC: Marek Marczykowski-GĂ³recki CC: Jason Andryuk CC: Daniel Smith CC: Christopher Clark While I've confirmed this to fix the build issue: https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/955160430 I'm -1 overall to the change, and would prefer to disable vtpm-stubdom entirely. It's TPM 1.2 only, using decades-old libs, and some stuff in the upstream https://github.com/PeterHuewe/tpm-emulator (which is still abandaonded as of 2018) is just as concerning as the basic error here in rsa_private(). vtpm-stubdom isn't credibly component of a Xen system, and we're wasting loads of CI cycles testing it... --- stubdom/Makefile | 1 + stubdom/vtpm-tpm_bn_t-addr.patch | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 stubdom/vtpm-tpm_bn_t-addr.patch diff --git a/stubdom/Makefile b/stubdom/Makefile index a21e1c3fa3a8..d5fb354e7e37 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -243,6 +243,7 @@ tpm_emulator-$(XEN_TARGET_ARCH): tpm_emulator-$(TPMEMU_VERSION).tar.gz patch -d $@ -p1 < vtpm_extern.patch patch -d $@ -p1 < vtpm-microsecond-duration.patch patch -d $@ -p1 < vtpm-command-duration.patch + patch -d $@ -p1 < vtpm-tpm_bn_t-addr.patch mkdir $@/build cd $@/build; CC=${CC} $(CMAKE) .. -DCMAKE_C_FLAGS:STRING="-std=c99 -DTPM_NO_EXTERN $(TARGET_CPPFLAGS) $(TARGET_CFLAGS) -Wno-declaration-after-statement" touch $@ diff --git a/stubdom/vtpm-tpm_bn_t-addr.patch b/stubdom/vtpm-tpm_bn_t-addr.patch new file mode 100644 index 000000000000..53172ae1c244 --- /dev/null +++ b/stubdom/vtpm-tpm_bn_t-addr.patch @@ -0,0 +1,18 @@ +All tpm_bn_t's are a 1-element array of one form or another, meaning the code +below is tautological and triggers -Werror=address. + +diff -ru tpm_emulator-x86_64.orig/crypto/rsa.c tpm_emulator-x86_64/crypto/rsa.c +--- tpm_emulator-x86_64.orig/crypto/rsa.c 2011-12-20 18:30:06.000000000 +0000 ++++ tpm_emulator-x86_64/crypto/rsa.c 2023-08-03 20:44:17.379166284 +0100 +@@ -53,10 +53,7 @@ + tpm_bn_init2(c, key->size); + tpm_bn_import(p, in_len, 1, in); + +- if (!key->p || !key->q || !key->u) { +- /* c = p ^ d mod n */ +- tpm_bn_powm(c, p, key->d, key->n); +- } else { ++ { + tpm_bn_init2(m1, key->size / 2); + tpm_bn_init2(m2, key->size / 2); + tpm_bn_init2(h, key->size); base-commit: 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Thu Aug 03 20:39:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 20:39:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576605.902925 (Exim 4.92) (envelope-from ) id 1qRf67-0005w2-S2; Thu, 03 Aug 2023 20:39:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576605.902925; Thu, 03 Aug 2023 20:39:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRf67-0005vv-PF; Thu, 03 Aug 2023 20:39:03 +0000 Received: by outflank-mailman (input) for mailman id 576605; Thu, 03 Aug 2023 20:39:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRf66-0005vj-Ce for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 20:39:02 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1a::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c66d36a7-323d-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 22:39:00 +0200 (CEST) Received: from DB8PR06CA0009.eurprd06.prod.outlook.com (2603:10a6:10:100::22) by DB3PR08MB8986.eurprd08.prod.outlook.com (2603:10a6:10:42b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 20:38:46 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::5f) by DB8PR06CA0009.outlook.office365.com (2603:10a6:10:100::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21 via Frontend Transport; Thu, 3 Aug 2023 20:38:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47 via Frontend Transport; Thu, 3 Aug 2023 20:38:45 +0000 Received: ("Tessian outbound f5de790fcf89:v145"); Thu, 03 Aug 2023 20:38:45 +0000 Received: from c926f84c38a8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B88C7538-4AA4-41D3-AECA-6C69ACA10D10.1; Thu, 03 Aug 2023 20:37:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c926f84c38a8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Aug 2023 20:37:44 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PAWPR08MB10257.eurprd08.prod.outlook.com (2603:10a6:102:367::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 20:37:42 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 20:37:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c66d36a7-323d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcgjQduBKAKOmnCmHicghrNByM6XK2eP+K7MyTSqdMY=; b=5KWC2vtp/TSSxqUvC09hLd73bV0FE7tpthwamV4Lywsr54npJk2hBvJrwnnmr6XggV0k2QqHK8rlL93iCEklroycHDc6S8UoRbqUAsyhTUnVcK3F9/u8z9/i0CwMCtQKHK/MYvLkO55GAXVZHxKxRMb1JZYHg7SRBHgaGp9AY+4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ca4d64224fff281f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jcdNyv+N0qIm2d/1e8K99eto+vODSu12mYZDthIbpY4S5xoWSr+5td37sx4iBdKOVg71lctFe/g+Kp+NLnNaeNBfRUMM+JLgGFHPe2UTnCg3/Xj6fGxqj/zhsVziEe5tHkcUqVHj/pIQhoZyUzaKQJ6qgnLk328nedcHYLJljegM41m8bWTXp4zzKMBjKPWalPcXR8MCSOqJCdf94oJBZLRzCCQlqqpYZzr1gY5DiE/r566FlZIKkUJeY1Tt7JJT27gz5kaxRPTQlkLQ/NOsNGy2fQ1wp1RhVXiHZ7U4zTOvSQz5CSmq3pQuBj8mrX2Bb3PXGCuQqFRtZ6DE67NlKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcgjQduBKAKOmnCmHicghrNByM6XK2eP+K7MyTSqdMY=; b=NQxMImSIf1O4E1Ws9Tbr4gXTTP4U9+298Q73CXVlI5n3xIOPTOQAgKv6iOfSnqnqbGtKEcxcM7/PRWZOy9O4izzuUpwCQgzs16SKrNW+le4YzmReIKWV1H/1oJoBr6TGMdjKW5gTvl+9fp3QCJdpyVdPXKTTJAwlmm4HvWffs694BRBDnZsa0eTqhfp0yOne4wmJkRk7izH9QwRuutUpPVqu62YvEuwKfbiyvna5WtjVOjFe0LUV6kOvvqxtGQPN7D1p7PUB9yrG/k4a9f3JbWlzQf5w88HIvaM8DvkAsWddJwYoux0fXWsD3hwlgrG3Ge3LQC3mgkChmOjhNl+jWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcgjQduBKAKOmnCmHicghrNByM6XK2eP+K7MyTSqdMY=; b=5KWC2vtp/TSSxqUvC09hLd73bV0FE7tpthwamV4Lywsr54npJk2hBvJrwnnmr6XggV0k2QqHK8rlL93iCEklroycHDc6S8UoRbqUAsyhTUnVcK3F9/u8z9/i0CwMCtQKHK/MYvLkO55GAXVZHxKxRMb1JZYHg7SRBHgaGp9AY+4= From: Luca Fancellu To: "Daniel P. Smith" CC: Volodymyr Babchuk , Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Thread-Topic: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Thread-Index: AQHZxfetD3iMBVO78kiKHyDm3xOwK6/Y3kwAgAAfToCAAAsagA== Date: Thu, 3 Aug 2023 20:37:40 +0000 Message-ID: <2E1A5918-A475-4055-A5A5-DE0CE30C061A@arm.com> References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> <8a51be9e-0131-0590-9aea-bbec146ce239@apertussolutions.com> In-Reply-To: <8a51be9e-0131-0590-9aea-bbec146ce239@apertussolutions.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PAWPR08MB10257:EE_|DBAEUR03FT055:EE_|DB3PR08MB8986:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ee6900a-d821-4f3a-f7d5-08db9461a231 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: aA5ssTbqylqxvQJnr2wlEMk0X8ajjNtL5ZucjEiYqBUMesvC+pVUacalG9DqoKgp22D4krNgpqzyfEDXrmjMy2xxgfn5onCsnYkZp58rf+BeuYlJ+dxk1XpY4U027EDVC6OZGAxtPIJJg7MOpdXMsD0zenx6PDQdL+Y3KJzRgp5JpukSPr4eXDKfFa4CNo4DPcZoA4/+akLmCdAw/OFCVIllno01jIs6tx1u4QLwQkZeeOa7a39C0hhnjKhiL5JO776mE9NgoNu07ShCLO2rVtN03qOxcWF3cV7XyPvGUd1sKa5XvQ7pMaockCZVRH0hByPeMM590nb/LLY5qLNAN9Zku3mONTrTNvGsDTUUTIjB4iIz+SKeNtg9G3/6zZjissUEsHdWe8zIAPP93w3rZmOchxTluZj32wTrBkK5RVoeZWD/0wCEwSA2Y7NlrvABI6AAzjOHbfsGSa3PGQ1zT7d/6fPv4AEU0wQfUp39qfoA8Cf1um0J7yMvfwOA41gboQ0JxLc7ezYwq9+u0eqnIFVCz4BTO5KTgCZTsNGGpUyctYGU1TUS0m8joXA84wxvFbbxNhNaP9pbVt7WSb/xeU/lvIijOIIYOZ2/N6cz+vnp8er5zh5RG7qGsOVM5RFyit1lFROLpsirSklTBsLaUQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199021)(2616005)(6506007)(186003)(8676002)(26005)(66476007)(2906002)(316002)(66556008)(91956017)(4326008)(66946007)(5660300002)(64756008)(6916009)(76116006)(66446008)(8936002)(41300700001)(6486002)(71200400001)(6512007)(54906003)(478600001)(38100700002)(122000001)(33656002)(36756003)(86362001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10257 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a4f7cd30-7e34-4409-295b-08db94617b37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P6CiFLNBsNqLqF2m4Ikf1N6koK2wbqCsJg9iFqZ2AYpjWaRvraVmSznUftNu/OIF70Tsl3ZsbJjnifAjvnQ5cGsb4tLr8/s5btT3+aVxNs1miS2tysDzSJSdmTEDboNRbGsnfcYUqzyEVkqtfNYHQNV9Tz8gl0hH1ebsTDxeybVMNHsm0vuoJNkQfzzs5VNe6a+hDhnDCVprYvQ3+3z+UUFRWv05tnSKt0wcX+mMqG7d6GtENy2CbPUOnF6hlBICO7yxemDdAujygr+IpheRtWv45S1DKUyMnd2URlDBscLRb8194ANMursMO9nTETb7QLWn3LvcYJXo99tWfhtZyV+8agQEh9rf+x+wgk25kcR7PBMehkWMFl2McNiaM6ZM+SlF5Ek8IlQPUH8XfNY4wQfeR2o1o7EaD+IA3OCPe8VW7fv/3qHp6arwbYGEyGy9eQUI3gCaZT6QcUQVbEkxbw/7bZoAsZoK/71n69M1z8m5L40puUz38OOxL83fAPq+N51Fups+7wNJvVpvp+I5qzUqup5lMqvS0EOXySp4X68q5KBjckfJbtYHAaf1jBu/bLcM0QXMoDnWyG4WSJtGFcBjbztXc/q6vPUxT10gSTSlVRJoRW2elmH6TGaFc2sQjKTC1NvpIYLs22TeKTxwBdRGEIHH/GD5mtNH6yEB9SLQaq6lUroJhzGTMQRVMYz7Mrzv9QitEgyZGOsEExx7t4Awo2RQ8yHO4YnVuRkBbiDw0AQZuWRpH+e6t1K6uktR X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(82310400008)(40470700004)(46966006)(36840700001)(40460700003)(2616005)(6506007)(336012)(186003)(26005)(47076005)(8676002)(316002)(36860700001)(2906002)(4326008)(70206006)(5660300002)(70586007)(41300700001)(6862004)(8936002)(6486002)(6512007)(54906003)(478600001)(40480700001)(356005)(81166007)(33656002)(86362001)(36756003)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 20:38:45.6979 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee6900a-d821-4f3a-f7d5-08db9461a231 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8986 DQo+IA0KPj4gUmVnYXJkaW5nIHRoZSBjb2Rpbmcgc3R5bGUsIEkgdGhpbmsgaXTigJlzIGJldHRl ciB0byBrZWVwIHRoZSBzdHlsZSB5b3XigJl2ZSBmb3VuZCBpbiB0aGUgb3JpZ2luYWwgZmlsZSwN Cj4+IGFuZCBjaGFuZ2Ugb25seSBzb21lIGJpdHMgd2hlbiB0aGUgY29kZSBpcyBub3QgZm9sbG93 aW5nIGl0Lg0KPj4gSSBrbm93IHRoZXJlIGlzIG5vdGhpbmcgZW5mb3JjaW5nIHBhcmFtZXRlcnMg b24gdGhlIHNhbWUgbGluZSBvZiB0aGUgZnVuY3Rpb24gZGVmaW5pdGlvbiBhdCB0aGUNCj4+IG1v bWVudCwgYnV0IGl0IGlzIGhvdyBpdOKAmXMgZG9uZSBmcm9tIHRoZSBvcmlnaW5hbCBmaWxlIHNv IEkgd291bGQgc3RpY2sgd2l0aCBpdC4NCj4+IFJlZ2FyZGluZyB0aGUgdTMyL3U2NCB0eXBlcywg bWF5YmUgc2luY2UgeW91IGFyZSBtb3ZpbmcgdGhlIGNvZGUgaXQgY2FuIGJlIHRoZSBvY2Nhc2lv biB0bw0KPj4gY29udmVydCB0aGVtLCBidXQgY2hlY2sgd2l0aCB0aGUgbWFpbnRhaW5lciBiZWZv cmUuDQo+IA0KPiBJIGNhbiBsZWF2ZSB0aGUgbWFpbiBjb2RlIGFzIGlzLCBidXQgSSBkbyB0aGlu ayBoZWFkZXIgZGVjbCdzIHNob3VsZCBiZSBzdHlsZWQgY29ycmVjdGx5IGFzIHRoZXJlIGlzIG5v IG5lZWQgdG8gaGF2ZSB0aGVtIGNodXJuIGluIHRoZSBmdXR1cmUgb3ZlciBwdXJlbHkgc3R5bGUg Y2hhbmdlcy4NCg0KVWhtLCB3aGVuIHlvdSBzYXkg4oCcc3R5bGVkIGNvcnJlY3RseeKAnSBkbyB5 b3UgbWVhbiBhcyBiZWxvdz8NCg0KDQo+Pj4gK2Jvb2wgX19pbml0IGRldmljZV90cmVlX25vZGVf bWF0Y2hlcygNCj4+PiArICAgIGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUsIGNvbnN0IGNoYXIg Km1hdGNoKQ0KPj4+ICt7DQoNCg0KSWYgdGhhdOKAmXMgdGhlIGNhc2UsIGl0IHNlZW1zIHRvIG1l IHRoYXQgdGhlcmUgaXMgbm90aGluZyBsaWtlIHRoYXQgaW4gdGhlIGNvZGViYXNlLA0KaW4gbXkg d29yayB3aXRoIGNsYW5nLWZvcm1hdCBJ4oCZdmUgY29uZmlndXJlZCBpdCB0byBtYXRjaCBhcyBt dWNoIGFzIEkgY2FuIHRoZQ0KWGVuIHN0eWxlIGFuZCB0aGlzIGZ1bmN0aW9uIHdvdWxkIGJlIGZv cm1hdHRlZCBhcyB0aGUgb2xkIHN0eWxlIHRoYXQgaXQgaGFkLg0KDQpDYW4gSSBhc2sgeW91IHdo ZXJlIGRpZCB5b3UgZmluZCBpbnN0cnVjdGlvbiB0byBzdHlsZSBpbiB0aGF0IHdheT8NCg0K From xen-devel-bounces@lists.xenproject.org Thu Aug 03 20:44:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 20:44:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576610.902936 (Exim 4.92) (envelope-from ) id 1qRfBP-0007Pq-Eo; Thu, 03 Aug 2023 20:44:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576610.902936; Thu, 03 Aug 2023 20:44:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfBP-0007Pj-C2; Thu, 03 Aug 2023 20:44:31 +0000 Received: by outflank-mailman (input) for mailman id 576610; Thu, 03 Aug 2023 20:44:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfBN-0007Pd-GA for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 20:44:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfBN-0001Ki-3V; Thu, 03 Aug 2023 20:44:29 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRfBM-0006iH-U2; Thu, 03 Aug 2023 20:44:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=g18EERidA2PIYHhnRFU+EyAtFmE+N4QvovOuy/VxbOA=; b=TbkrPmOqtrX8Ofsn4wThX275Kf bu3v1asrewWA+KA39R2SIqxED4rTYPROWgW7AQm2Hvt+HwyvfC5yiLmIkzeEUAOfXk+ietS+Xxjow 4G0iKW4F+cpZ0UkkI/2BDeH9iyREsKYUhkYL7m0U4ZTcT+gMblrNqwk3qTbz8VfihZOQ=; Message-ID: Date: Thu, 3 Aug 2023 21:44:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230803144035.4071610-1-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230803144035.4071610-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 03/08/2023 15:40, Luca Fancellu wrote: > Introduce Kconfig GICV2 to be able to compile the GICv2 driver only > when needed, the option is active by default. > > Introduce Kconfig VGICV2 that compiles the Generic Interrupt > Controller v2 emulation for domains, it is required only when using > GICv2 driver, otherwise using the GICv3 driver it is optional and can > be deselected if the user doesn't want to offer the v2 emulation to > domains or maybe its GICv3 hardware can't offer the GICv2 compatible > mode. > > Signed-off-by: Luca Fancellu Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 21:03:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 21:03:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576616.902946 (Exim 4.92) (envelope-from ) id 1qRfTt-0001YA-0x; Thu, 03 Aug 2023 21:03:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576616.902946; Thu, 03 Aug 2023 21:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfTs-0001Y3-UH; Thu, 03 Aug 2023 21:03:36 +0000 Received: by outflank-mailman (input) for mailman id 576616; Thu, 03 Aug 2023 21:03:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfTr-0001Xx-TZ for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 21:03:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfTp-0001po-OV; Thu, 03 Aug 2023 21:03:33 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRfTp-0007Sk-FS; Thu, 03 Aug 2023 21:03:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=7NJgIuBBaorRvBuuZNfLjpOMs0awr/mZgat3dL+uQ/c=; b=AD1caAMM4tVHDRUnYmtP0Heqka IT8BrsiQYq+YVZZaUxIz6+a8nt/rLy/L0PX8JAwu9F0mgumV3m+vvVzWHoWWlHfZUNqwZmALPaa2i ZNpS9BUUUOy8eUH7JTCQu6dwpit4fSe0DbQF2ra/2VfhfCqabpC3+0JIM4C/9y2pmhUg=; Message-ID: <8951f722-6949-b2b5-f6d4-2d515f085cde@xen.org> Date: Thu, 3 Aug 2023 22:03:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: "Daniel P. Smith" , Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> From: Julien Grall Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability In-Reply-To: <20230801202006.20322-5-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 01/08/2023 21:20, Daniel P. Smith wrote: > The field `is_console` suggests that the field represents a state of being or > posession, not that it reflects the privilege to access the console. In this > patch the field is renamed to capabilities to encapsulate the capabilities a > domain has been granted. The first capability being the ability to read/write > the Xen console. > > Signed-off-by: Daniel P. Smith > --- > xen/arch/arm/domain_build.c | 4 +++- > xen/include/xen/sched.h | 25 +++++++++++++++++++++++-- > xen/include/xsm/dummy.h | 2 +- > 3 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 51b4daefe1..ad7432b029 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -4076,7 +4076,9 @@ void __init create_domUs(void) > panic("Error creating domain %s (rc = %ld)\n", > dt_node_name(node), PTR_ERR(d)); > > - d->is_console = true; > + if ( ! domain_set_cap(d, CAP_CONSOLE_IO) ) Coding style: We don't usually add a space after '!'. > + printk("failed setting console_io on %pd\n", d); I find a bit odd that we would continue even if the cap cannot be set. Can you clarify? > + > dt_device_set_used_by(node, d->domain_id); > > rc = construct_domU(d, node); > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index ec0f9baff6..b04fbe0565 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -472,8 +472,8 @@ struct domain > #define ROLE_HARDWARE_DOMAIN (1U<<2) > #define ROLE_XENSTORE_DOMAIN (1U<<3) > uint8_t role; > - /* Can this guest access the Xen console? */ > - bool is_console; > +#define CAP_CONSOLE_IO (1U<<0) Coding style: Space before and after <<. > + uint8_t capabilities; > /* Is this guest being debugged by dom0? */ > bool debugger_attached; > /* > @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const struct vcpu *v) > return is_hvm_domain(v->domain); > } > > +static always_inline bool domain_has_cap( > + const struct domain *d, uint8_t cap) Coding style: We don't usually wrap the arguments this way. See domain_create() for an example. > +{ > + return d->capabilities & cap; > +} > + > +static always_inline bool domain_set_cap( > + struct domain *d, uint8_t cap) Same about the coding style here. Also, do you expect the cap to be set only when the domain is created? If not, would you prevent potentially concurrent update to d->capabilities? > +{ > + switch ( cap ) > + { > + case CAP_CONSOLE_IO: > + d->capabilities |= cap; > + break; > + default: Is this meant to be reached? If not, maybe add ASSERT_UNREACHABLE()? > + return false; > + } > + > + return domain_has_cap(d, cap); > +} > + > static always_inline bool hap_enabled(const struct domain *d) > { > /* sanitise_domain_config() rejects HAP && !HVM */ > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 18f1ddd127..067ff1d111 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -268,7 +268,7 @@ static XSM_INLINE int cf_check xsm_console_io( > XSM_DEFAULT_ARG struct domain *d, int cmd) > { > XSM_ASSERT_ACTION(XSM_OTHER); > - if ( d->is_console ) > + if ( domain_has_cap(d, CAP_CONSOLE_IO) ) > return xsm_default_action(XSM_HOOK, d, NULL); > #ifdef CONFIG_VERBOSE_DEBUG > if ( cmd == CONSOLEIO_write ) Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 21:24:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 21:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576621.902956 (Exim 4.92) (envelope-from ) id 1qRfo0-00045P-O6; Thu, 03 Aug 2023 21:24:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576621.902956; Thu, 03 Aug 2023 21:24:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfo0-00045I-LL; Thu, 03 Aug 2023 21:24:24 +0000 Received: by outflank-mailman (input) for mailman id 576621; Thu, 03 Aug 2023 21:24:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfnz-00045C-DH for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 21:24:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfnw-0002OG-Ki; Thu, 03 Aug 2023 21:24:20 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRfnw-0008FT-Ap; Thu, 03 Aug 2023 21:24:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=b8ACP4rpO5B7yWigDdIUg8+cSQszFkSW9ZgxUJLoQH0=; b=vcF5VNsrNRhz1R51C8SN4Ml8+9 PJlFcNJpcTLEdx/ijQLiRYoM6UAAsloQgprRpFtM2yyxHiSSoZbqbaw1CUvI5GF2vL7trNwRgoqjF HFRlJemGr6hxtnkOzSj6jQRH/6lgsT6S5u/Kd3FAXhDioLm6N6T/PbtBfscu0ulVNNPw=; Message-ID: <423f86e7-10ee-134e-7683-e15f7e2c64ed@xen.org> Date: Thu, 3 Aug 2023 22:24:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability To: "Daniel P. Smith" , Stefano Stabellini Cc: Volodymyr Babchuk , xen-devel@lists.xenproject.org, Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> <14346689-8276-3c26-91e1-59bc2328518e@apertussolutions.com> From: Julien Grall In-Reply-To: <14346689-8276-3c26-91e1-59bc2328518e@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Daniel, On 03/08/2023 16:41, Daniel P. Smith wrote: > On 8/1/23 21:01, Stefano Stabellini wrote: >> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>> patch the field is renamed to capabilities to encapsulate the >>> capabilities a >>> domain has been granted. The first capability being the ability to >>> read/write >>> the Xen console. >>> >>> Signed-off-by: Daniel P. Smith >> >> Patch looks fine to me aside the two minor nits. I am not sure I >> understand 100% the difference between capabilities and roles but I am >> OK with the patch. I'd like to hear Julien's feedback on this as well. > > This might be worth a section in the hypervisor-guide. As mentioned in > the cover letter, this was originally proposed as being under XSM. A > challenge I ran into is that, depending on your view, the > `is_privileged` field and `hardware_domain` global were either abused as > a function check and a non-resource privilege check or are just > multifaceted variables. This is why the concept of the role was struck > upon, it is more intuitive (for me at least) that have a role is > something that imparts accesses (privilege checks) and dictates > hypervisor behaviors when handling the domain (function checks). This > then brings us to an access or behavior that may be inherent to some > role(s) but may want to grant on an individually to a guest. A prime > example of this is console_io, for which it is inherent that the > hardware domain role will have access but may want to grant to a guest > without granting it an entire role. This is why I provided for > identifying these capabilities so that they may be assigned individually > to a domain. Thanks for the explanation. Just to confirm my understanding, what you are suggesting is that for a given role, a domain will at least have the matching capabilities (more could be granted). Is that correct? If so, this wouldn't this mean we can remove d->role and simply use d->capabilities? > > While the role/capability is a natural progression from how the > hypervisor currently operates. Another approach that could be consider > to deliver a similar experience would be to break down every access and > function into a capability and then define the standard roles as a > conglomeration of certain capabilities. At least from the explanation above, I think it would make sense to break down role to multiple capabilities. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 21:31:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 21:31:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576625.902966 (Exim 4.92) (envelope-from ) id 1qRfuQ-0005ZL-DI; Thu, 03 Aug 2023 21:31:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576625.902966; Thu, 03 Aug 2023 21:31:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfuQ-0005ZE-AU; Thu, 03 Aug 2023 21:31:02 +0000 Received: by outflank-mailman (input) for mailman id 576625; Thu, 03 Aug 2023 21:31:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfuO-0005Z4-S6; Thu, 03 Aug 2023 21:31:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfuO-0002Vg-KE; Thu, 03 Aug 2023 21:31:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfuO-0008Lu-6B; Thu, 03 Aug 2023 21:31:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRfuO-0001K2-5j; Thu, 03 Aug 2023 21:31:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gFSPCm9deNIY+l/KDz0AtZoQzdl0i2GcJKJL6jR44WM=; b=p/8FWssJy5tY85aZIZoetM72Vf PYtE8u4xfvYFOQdN1tnBz1yJU+8PendPWcsTJm93ZxsgqPudkqvBL0773Qbw9cO1S7BmeHOBcSYl3 JXvWCS0gEUd5IYyPOcTDH7bT7iajExZ6vxgbEiIAw8WxVTSK62n2ifyeFoxX2OzLzO7Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182168: all pass - PUSHED X-Osstest-Versions-This: ovmf=ef051451367fa5455d75b38c407ca352a43b4849 X-Osstest-Versions-That: ovmf=7672d1cca58228b0cb7f099e8863aa3a44ae45db From: osstest service owner Date: Thu, 03 Aug 2023 21:31:00 +0000 flight 182168 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182168/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ef051451367fa5455d75b38c407ca352a43b4849 baseline version: ovmf 7672d1cca58228b0cb7f099e8863aa3a44ae45db Last test of basis 182163 2023-08-03 12:42:25 Z 0 days Testing same since 182168 2023-08-03 15:12:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Oliver Smith-Denny jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7672d1cca5..ef05145136 ef051451367fa5455d75b38c407ca352a43b4849 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Aug 03 21:36:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 21:36:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576631.902975 (Exim 4.92) (envelope-from ) id 1qRfzO-0006Bc-Vs; Thu, 03 Aug 2023 21:36:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576631.902975; Thu, 03 Aug 2023 21:36:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfzO-0006BV-TB; Thu, 03 Aug 2023 21:36:10 +0000 Received: by outflank-mailman (input) for mailman id 576631; Thu, 03 Aug 2023 21:36:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfzN-0006BP-CM for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 21:36:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRfzM-0002bq-F3; Thu, 03 Aug 2023 21:36:08 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRfzM-0000BX-9e; Thu, 03 Aug 2023 21:36:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=9I4IMIR62JFUSTNFv83Hx7SnUeTpD2dVhBdbjVSIbYA=; b=JmSD+bLu9AyoiOvCUNwkVnl8Me iGauZ9akeEuNCg/fWzs+uq9Daqddvk6mcoiBxxIRT3ooE0K5O5JcTATbnDgCsnsC0x0Sw7ASl7POP GCXRSiFdRleXUM2vpof2xgeOd0ucN1lZbtxxH+aIE620qVtq5h/TcoZTT69vovbtvhCY=; Message-ID: Date: Thu, 3 Aug 2023 22:36:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> From: Julien Grall In-Reply-To: <20230724110247.10520-23-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 24/07/2023 12:02, Juergen Gross wrote: > diff --git a/tools/xenstore/xenstored_watch.c b/tools/xenstore/xenstored_watch.c > index 86cf8322b4..2662a3fa49 100644 > --- a/tools/xenstore/xenstored_watch.c > +++ b/tools/xenstore/xenstored_watch.c > @@ -166,19 +166,12 @@ static int destroy_watch(void *_watch) > static int check_watch_path(struct connection *conn, const void *ctx, > const char **path, bool *relative) > { > - /* Check if valid event. */ > - if (strstarts(*path, "@")) { > - *relative = false; > - if (strlen(*path) > XENSTORE_REL_PATH_MAX) > - goto inval; I can't find an exact matching check in is_valid_nodename(). The call also seems to put more restriction on '@' node. Can you clarify? > - } else { > - *relative = !strstarts(*path, "/"); > - *path = canonicalize(conn, ctx, *path); > - if (!*path) > - return errno; > - if (!is_valid_nodename(conn, *path)) > - goto inval; > - } > + *relative = !strstarts(*path, "/") && !strstarts(*path, "@"); > + *path = canonicalize(conn, ctx, *path); > + if (!*path) > + return errno; > + if (!is_valid_nodename(conn, *path, true)) > + goto inval; > > return 0; > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 21:46:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 21:46:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576635.902985 (Exim 4.92) (envelope-from ) id 1qRg9R-0007hN-T0; Thu, 03 Aug 2023 21:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576635.902985; Thu, 03 Aug 2023 21:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRg9R-0007hG-QT; Thu, 03 Aug 2023 21:46:33 +0000 Received: by outflank-mailman (input) for mailman id 576635; Thu, 03 Aug 2023 21:46:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRg9Q-0007hA-EF for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 21:46:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRg9P-0002lt-6C; Thu, 03 Aug 2023 21:46:31 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRg9O-0000ai-VN; Thu, 03 Aug 2023 21:46:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=UI+XY8c1yZmkOGX+ChwuPScO0M2akPMjAXHhbUROwUg=; b=0ZzXJPzPtI2pi6XZDkmuiD3srk vBWC0lNF6PlaJXl7o/d+z4yO6vkg5yk0qoQpPRN/Qz57bJ/kOFomwDJYhpMMxUFYA+pn0VQ47Busi qyXF06sKSiYjalcnHHxFyZiSmrbTNGFWSxrUnFs6VS2J1tJ6z1T7PDebK5tX4KSNSH0M=; Message-ID: Date: Thu, 3 Aug 2023 22:46:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> From: Julien Grall Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() In-Reply-To: <20230724110247.10520-24-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 24/07/2023 12:02, Juergen Gross wrote: > Today is_valid_nodename() is always called directly after calling > canonicalize(), with the exception of do_unwatch(), where the call > is missing (which is not correct, but results just in a wrong error > reason being returned). While this change makes sense... > > Merge is_valid_nodename() into canonicalize(). While at it merge > valid_chars() into it, too. ... I am not in favor of folding the code is_valid_nodename() and valid_chars() into canonicalize() because the code is now more difficult to read. Also, the keeping the split would allow to free the 'name' in case of an error without adding too much goto in the code. > > Signed-off-by: Juergen Gross > --- > V3: > - new patch > --- > tools/xenstore/xenstored_core.c | 89 ++++++++++++++------------------ > tools/xenstore/xenstored_core.h | 6 +-- > tools/xenstore/xenstored_watch.c | 16 ++---- > 3 files changed, 45 insertions(+), 66 deletions(-) > > diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c > index ea5a1a9cce..ec20bc042d 100644 > --- a/tools/xenstore/xenstored_core.c > +++ b/tools/xenstore/xenstored_core.c > @@ -1210,42 +1210,6 @@ void send_ack(struct connection *conn, enum xsd_sockmsg_type type) > send_reply(conn, type, "OK", sizeof("OK")); > } > > -static bool valid_chars(const char *node) > -{ > - /* Nodes can have lots of crap. */ > - return (strspn(node, > - "ABCDEFGHIJKLMNOPQRSTUVWXYZ" > - "abcdefghijklmnopqrstuvwxyz" > - "0123456789-/_@") == strlen(node)); > -} > - > -bool is_valid_nodename(const struct connection *conn, const char *node, > - bool allow_special) > -{ > - int local_off = 0; > - unsigned int domid; > - > - /* Must start in / or - if special nodes are allowed - in @. */ > - if (!strstarts(node, "/") && (!allow_special || !strstarts(node, "@"))) > - return false; > - > - /* Cannot end in / (unless it's just "/"). */ > - if (strends(node, "/") && !streq(node, "/")) > - return false; > - > - /* No double //. */ > - if (strstr(node, "//")) > - return false; > - > - if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) > - local_off = 0; > - > - if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off)) > - return false; > - > - return valid_chars(node); > -} > - > /* We expect one arg in the input: return NULL otherwise. > * The payload must contain exactly one nul, at the end. > */ > @@ -1279,16 +1243,46 @@ static char *perms_to_strings(const void *ctx, const struct node_perms *perms, > } > > const char *canonicalize(struct connection *conn, const void *ctx, > - const char *node) > + const char *node, bool allow_special) > { > - const char *prefix; > + char *name; > + int local_off = 0; > + unsigned int domid; > > - if (!node || (node[0] == '/') || (node[0] == '@')) > - return node; > - prefix = get_implicit_path(conn); > - if (prefix) > - return talloc_asprintf(ctx, "%s/%s", prefix, node); > - return node; > + errno = EINVAL; > + if (!node) > + return NULL; > + > + if (strspn(node, "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" > + "0123456789-/_@") != strlen(node)) > + return NULL; > + > + if (node[0] == '@' && !allow_special) > + return NULL; > + > + if (node[0] != '/' && node[0] != '@') { > + name = talloc_asprintf(ctx, "%s/%s", get_implicit_path(conn), > + node); This is allocated but not freed on error. I understand this is part of the 'ctxt' and therefore will be free later on. But this means temporary memory will be allocated for longer. So best to clean-up when you can. > + if (!name) > + return NULL; > + } else > + name = (char *)node; Why does name need to be const? > + > + /* Cannot end in / (unless it's just "/"). */ > + if (strends(name, "/") && !streq(name, "/")) > + return NULL; > + > + /* No double //. */ > + if (strstr(name, "//")) > + return NULL; > + > + if (sscanf(name, "/local/domain/%5u/%n", &domid, &local_off) != 1) > + local_off = 0; > + > + if (domain_max_chk(conn, ACC_PATHLEN, strlen(name) - local_off)) > + return NULL; > + > + return name; > } Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 03 22:07:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 22:07:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576639.902996 (Exim 4.92) (envelope-from ) id 1qRgTN-0001n9-Ig; Thu, 03 Aug 2023 22:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576639.902996; Thu, 03 Aug 2023 22:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRgTN-0001n2-FQ; Thu, 03 Aug 2023 22:07:09 +0000 Received: by outflank-mailman (input) for mailman id 576639; Thu, 03 Aug 2023 22:07:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRgTL-0001ms-DE; Thu, 03 Aug 2023 22:07:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRgTL-0003J8-BU; Thu, 03 Aug 2023 22:07:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRgTL-00020S-0A; Thu, 03 Aug 2023 22:07:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRgTK-0008QT-W2; Thu, 03 Aug 2023 22:07:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vAkV7C/winOGfeaSVagYkmgkefwZFsATE6mB7e8XKZc=; b=FmYE1GyWknCibHVI+OVVitjTb9 mknP4OhYuB7xLERHskMeJYhGNNHU4DK/FUPfSE8ODEtgANN+lIGiU+tWxdLfVnCtH2P08dvNkwjvh HWHcGpGcsbma1dArHDUK2XbG3RgLYuXNINgthHgch/eGoWeU3BEi9GGW8vJSevf1VdjM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182172: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a X-Osstest-Versions-That: xen=1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 From: osstest service owner Date: Thu, 03 Aug 2023 22:07:06 +0000 flight 182172 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182172/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a baseline version: xen 1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 Last test of basis 182170 2023-08-03 16:00:27 Z 0 days Testing same since 182172 2023-08-03 19:02:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 1aa5acbbec..092cae024a 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a -> smoke From xen-devel-bounces@lists.xenproject.org Thu Aug 03 23:39:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 23:39:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576647.903006 (Exim 4.92) (envelope-from ) id 1qRhuD-0002yH-RY; Thu, 03 Aug 2023 23:38:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576647.903006; Thu, 03 Aug 2023 23:38:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRhuD-0002yA-Oa; Thu, 03 Aug 2023 23:38:57 +0000 Received: by outflank-mailman (input) for mailman id 576647; Thu, 03 Aug 2023 23:38:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRhuC-0002y4-Nr for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 23:38:56 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e79b14f8-3256-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 01:38:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39A8161ECC; Thu, 3 Aug 2023 23:38:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69D56C433C8; Thu, 3 Aug 2023 23:38:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e79b14f8-3256-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691105931; bh=Gto+zPA7WqoUuOk2iaXFpTJBpEqbnLyFxmcl2hlKzqQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hCxW0wIwqeqN8N9Xy0TdiOvFSCOz5IcsDehPty6TxyG9Frx939mWqOabnoS2vokUi EAPFsQg7Lte+ZVuxu5yBRVWABX+MiPRoPd9JNszMHSdI8rvEZZ+53h51LhrO8NS62C zNVGi9scKSwLi47gIO1iGskHZHyz4zMf8/6xWW8ECa4JqkNJxOIhqduZsrHV48xU3m lPjI/SsE12tdGQytk1n3SivmkOfCQWfV3ePfjjBvWxWa2wB1cQdl+lD6qQYz9ZA/2a wRPfANPNTFyM2QqsN+FpuhDHS7mumJUG9Q/KSvIw6s4EKAa9suFiiGAuh01gHFjr8B z8/fcjkZNv/5w== Date: Thu, 3 Aug 2023 16:38:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > Also, what is the plan for the existing dom0less dt properties? > > Will they need to be moved to new /hypervisor node or we will have to parse > > both /chosen and /hypervisor nodes? > > In the proposal I sent to xen-devel in response to Luca's RFC for rebranding > dom0less features under hyperlaunch, that is the purpose of this commit. Get > this document up to date with what was done in v1 along with what we are > planning/working on for hyperlaunch. One could think of this as effectively > the API to the capabilities hyperlaunch will provide. Not just how to > construct a domain, but what kinds of domains can be constructed by > hyperlaunch. Step one of the proposal is to publish a patch upon which we all > can iterate over and get to an agreement on a suitable interface for all. The > next step would be the introduction of hyperlaunch dom0less compatibility > mode, that would see the moving of the parsing logic for the existing dom0less > nodes under /xen/common/domain-builder. It would continue to exist there even > after hyperlaunch proper is merged and can remain there for backward > compatibility until there is a decision to retire the compatibility interface. I like this plan. The two interfaces are so similar that it is basically one interface with a couple of tiny differences. So I expect we would move the existing dom0less parsing code to common/, add a couple of extensions (such as parsing /hypervisor in addition to /chosen) and use it as it. Later on, after a few years of using /hypervisor instead of /chosen, if nobody is using /chosen anymore, we could retire /chosen completely. But this is just one DT node/property that gets retired (there are a couple of others). I don't imagine we'll have a full new implementation of the DT parsing logic that supersedes the existing implementation of it (especially considering the difficulty of maintaining 2 different parsing logics in the hypervisor for similar interfaces). Same thing for the DT interface documentation. I don't think we need two DT interface docs? We could start with the existing dom0less interface (docs/misc/arm/device-tree/booting.txt), and move it somewhere common like docs/misc/device-tree. Then add any changes or extensions required by other architecture, such as x86 and RISC-V. For sure for x86 we need "module-index". I don't know if anything else is must-have to get it to work on x86 but if there is, we should add those too. From xen-devel-bounces@lists.xenproject.org Thu Aug 03 23:50:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 03 Aug 2023 23:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576652.903015 (Exim 4.92) (envelope-from ) id 1qRi5Q-0005R8-VI; Thu, 03 Aug 2023 23:50:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576652.903015; Thu, 03 Aug 2023 23:50:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRi5Q-0005R1-Sa; Thu, 03 Aug 2023 23:50:32 +0000 Received: by outflank-mailman (input) for mailman id 576652; Thu, 03 Aug 2023 23:50:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRi5Q-0005Qv-8G for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 23:50:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86c60f0d-3258-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 01:50:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E58ED61EFF; Thu, 3 Aug 2023 23:50:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FAB2C433C8; Thu, 3 Aug 2023 23:50:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86c60f0d-3258-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691106628; bh=viWqANyZKHIi6essCCl/Y8s0t4ucXvcaCM8/oC45Vhs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tfQhsp/xS0fz229T7AfTFpXPr0GZTZAzCG0dvNaqFcK3V1qfIqRft61fbS5qqSVDK e96fhi98MPth5eAFou3+umFiu61wt2Yy6/ZcIONChaPSGT4iVbi8lsLEkYG2hOJP/p cnc1/uH1Uz0yAOpi27+tWHmQJG6eGdj7sprQCsdAJfcumd0rlPjXZGmZ9EASaPHcky uOah4p8x4+vMQzNPQdYbbFGMuMi219B7qcjI+GJrr2Ti1KvbzeCaYwN1ne+9mrztFu n0PMETWxc1dsoMfEqbkoMS4ucJn+xMP20NjtToNBjl4JeHx+152eCfFXL4OPQ1IQdE oJrELuTTAYVJA== Date: Thu, 3 Aug 2023 16:50:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1 In-Reply-To: Message-ID: References: <7f8cbd8c8ad64cd3a0d099f31cb4d3fad48aa63b.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: > > Rule 2.1 states: "A project shall not contain unreachable code". > > > > The functions > > - machine_halt > > - maybe_reboot > > - machine_restart > > are not supposed to return, hence the following break statement > > is marked as intentionally unreachable with the ASSERT_UNREACHABLE() > > macro to justify the violation of the rule. > > During the discussion it was mentioned that this won't help with > release builds, where right now ASSERT_UNREACHABLE() expands to > effectively nothing. You want to clarify here how release builds > are to be taken care of, as those are what eventual certification > will be run against. Something along these lines: ASSERT_UNREACHABLE(), not only is used in non-release builds to actually assert and detect errors, but it is also used as a marker to tag unreachable code. In release builds ASSERT_UNREACHABLE() doesn't resolve into an assert, but retains its role of a code marker. Does it work? From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:09:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:09:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576657.903025 (Exim 4.92) (envelope-from ) id 1qRiNl-0007iQ-LH; Fri, 04 Aug 2023 00:09:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576657.903025; Fri, 04 Aug 2023 00:09:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiNl-0007iJ-IG; Fri, 04 Aug 2023 00:09:29 +0000 Received: by outflank-mailman (input) for mailman id 576657; Fri, 04 Aug 2023 00:09:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiNk-0007iC-NX for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:09:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2bab1b06-325b-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:09:26 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D98B61EF2; Fri, 4 Aug 2023 00:09:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0C3C433C8; Fri, 4 Aug 2023 00:09:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bab1b06-325b-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691107763; bh=KsskHdlsOakz1lNpgxVEJJ+yy4KW2vSLGBoEznyVgDU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=f1M24UJdRvENNOAeV1T3ssJE81ggMsECHyHG/oW+BlC6GvGlFRVQ/oM2Pk4f75kDl 80UzLvhv8Kh1xawiJ3cA+PDB1DbOCN0o/g0auuRwIzr9u6hrEux+n48lTf/u5cJ/tq uJl0KTteU9g3i35R1zoo7xmSFu90tOc/k4fMbHxTXWeFpFdBjphx9aNY7KQnU6mFQx W3i42NcHGpOcURALTPvYviDdkXUAwPyufR1kS3RIvYtyX/nECeyUJGRGgHs1ZLsVRf zrRzHMJs6n8LrUUm4MO+71t009Obz3/+Vr5LzkgPc1F0aDuzOYJSeg39zAuYS140ku eIa+SxOicTGxA== Date: Thu, 3 Aug 2023 17:09:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: "Daniel P. Smith" , Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > > Also, what is the plan for the existing dom0less dt properties? > > > Will they need to be moved to new /hypervisor node or we will have to parse > > > both /chosen and /hypervisor nodes? > > > > In the proposal I sent to xen-devel in response to Luca's RFC for rebranding > > dom0less features under hyperlaunch, that is the purpose of this commit. Get > > this document up to date with what was done in v1 along with what we are > > planning/working on for hyperlaunch. One could think of this as effectively > > the API to the capabilities hyperlaunch will provide. Not just how to > > construct a domain, but what kinds of domains can be constructed by > > hyperlaunch. Step one of the proposal is to publish a patch upon which we all > > can iterate over and get to an agreement on a suitable interface for all. The > > next step would be the introduction of hyperlaunch dom0less compatibility > > mode, that would see the moving of the parsing logic for the existing dom0less > > nodes under /xen/common/domain-builder. It would continue to exist there even > > after hyperlaunch proper is merged and can remain there for backward > > compatibility until there is a decision to retire the compatibility interface. > > I like this plan. The two interfaces are so similar that it is basically > one interface with a couple of tiny differences. > > So I expect we would move the existing dom0less parsing code to common/, > add a couple of extensions (such as parsing /hypervisor in addition to > /chosen) and use it as it. > > Later on, after a few years of using /hypervisor instead of /chosen, if > nobody is using /chosen anymore, we could retire /chosen completely. But > this is just one DT node/property that gets retired (there are a couple > of others). I don't imagine we'll have a full new implementation of the > DT parsing logic that supersedes the existing implementation of it > (especially considering the difficulty of maintaining 2 different parsing > logics in the hypervisor for similar interfaces). > > Same thing for the DT interface documentation. I don't think we need two > DT interface docs? We could start with the existing dom0less interface > (docs/misc/arm/device-tree/booting.txt), and move it somewhere common > like docs/misc/device-tree. > > Then add any changes or extensions required by other architecture, such > as x86 and RISC-V. > > For sure for x86 we need "module-index". I don't know if anything else > is must-have to get it to work on x86 but if there is, we should add > those too. For clarity, I think we should definitely have docs/design/launch/hyperlaunch.rst, and maybe we should also have hyperlaunch-devicetree.rst as an overview description and user guide. That's useful. But in terms of official device tree bindings interface description (basically what in Linux would go under Documentation/devicetree/bindings/), I think it would be best to only have a single document. The current one is docs/misc/arm/device-tree/booting.txt. From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:36:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:36:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576661.903035 (Exim 4.92) (envelope-from ) id 1qRinI-0002ig-N7; Fri, 04 Aug 2023 00:35:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576661.903035; Fri, 04 Aug 2023 00:35:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRinI-0002iZ-KQ; Fri, 04 Aug 2023 00:35:52 +0000 Received: by outflank-mailman (input) for mailman id 576661; Fri, 04 Aug 2023 00:35:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRinH-0002iT-7f for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:35:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db82be17-325e-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 02:35:49 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E63861DC7; Fri, 4 Aug 2023 00:35:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D045EC433C8; Fri, 4 Aug 2023 00:35:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db82be17-325e-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691109347; bh=xTOMQxXd2u9RB/JljKi0xPtht7ZUtCp0e47FG1ZhdF0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=RJLISaVgWvv7NIU55pcycVq2cXlGpPXu0h0S3wGPvG3qAInIB8jRPz1WbOwnuvCbK AFAJmr9Zr5i8TCZAdPRG8upte1Tc+EYZzLTzFW4+5WcVdVm+rMF5lrizs2I8lWjea/ +mR4WJ0rvIzcUUxjAmlKzDSpnCJx0QGriVCxwb1j8ZWKDzj5ey5ru/vuqgIVOrMimh C3A6SSHMHE+kuH1OhbKXC0/Siw9drOBSCCpDt7RdWsmxIhKdoS5fZTbNT5HOcNTCFv dfyLsubCJayTmmvLgwEpkVddHFRHhz+fpXqdeGHrGzF+03tnkz2VTytJmzo7CX5KTf nfyIys2K+HHPg== Date: Thu, 3 Aug 2023 17:35:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Jan Beulich , Andrew Cooper , Julien Grall , George Dunlap , Wei Liu Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> Message-ID: References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII I think that's OK for me. My only concern is that we should track the project-wide deviations properly somewhere besides the ECLAIR configuration under xen.git which is ECLAIR specific. So far we used the notes in docs/misra/rules.rst. I don't know if that sufficient, but we could add a note for 8.4: diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 8f0e4d3f25..5977bc9d5e 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -245,7 +245,8 @@ maintainers if you want to suggest a change. - Required - A compatible declaration shall be visible when an object or function with external linkage is defined - - + - No need for declarations when functions are only called from + assembly * - `Rule 8.5 `_ - Required On Thu, 3 Aug 2023, Nicola Vetrini wrote: > The headline of Rule 8.4 is as follows: > "A compatible declaration shall be visible when an object or > function with external linkage is defined". > > Some functions reported in [1][2] are lacking a declaration in the respective > header files; > as remarked on xen-devel's IRC channel, this is ok since they are only called > from asm code (e.g., start_xen). A similar discussion > had taken place in the past (see [3]) and the general consensus was to deviate > these cases. > If that is still the case, a suitable project-wide deviation can be added to > address these violations. > > [1] > https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html > [2] > https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html > [3] https://lore.kernel.org/all/20220705210218.483854-2-burzalodowa@gmail.com/ > > Regards, > > -- > Nicola Vetrini, BSc > Software Engineer, BUGSENG srl (https://bugseng.com) > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:40:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:40:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576665.903046 (Exim 4.92) (envelope-from ) id 1qRiru-0004Al-9S; Fri, 04 Aug 2023 00:40:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576665.903046; Fri, 04 Aug 2023 00:40:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiru-0004Ae-6l; Fri, 04 Aug 2023 00:40:38 +0000 Received: by outflank-mailman (input) for mailman id 576665; Fri, 04 Aug 2023 00:40:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRirs-0004AY-Ht for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:40:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85aaec7f-325f-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 02:40:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B92B261E69; Fri, 4 Aug 2023 00:40:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30D32C433C7; Fri, 4 Aug 2023 00:40:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85aaec7f-325f-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691109633; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ptHtLHezoaXBnNqx1jtxwQq1wyegSfjNrAr4jbJcJVnFQCzLS+jy1mvPBnUfpDsnb w1FdM/2oaJi7FfP2c39SEP7P3xf065X83K6KFfCsbvlaKY1hnULXD/cxzaXM2L7PtS 007i/ADbNAaz7fCag3lyteEBSwNtkm9pZskjbCIoC2abytyI0AVVvB8oMFzyb2VlDu zlFPiHkAB7QRlePxRyDWrT3x2FBioNjSezPq1ExfY0BgvtIQjhfSsj8Jqpt7nXJQmB WbViOBW96ehjeaWVzd1R8/OpMuueK4iaGk2UiaaAWDBR5Bl6EXqoc1q72Vpmo8qzU8 qqQUKrl4A6taA== Date: Thu, 3 Aug 2023 17:40:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper Subject: Re: [XEN PATCH 01/13] AMD/IOMMU: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <2af1f76d2c002dd9f0b01eebf7af516d86bfe91e.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <2af1f76d2c002dd9f0b01eebf7af516d86bfe91e.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:43:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:43:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576668.903055 (Exim 4.92) (envelope-from ) id 1qRiuE-0004j3-L3; Fri, 04 Aug 2023 00:43:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576668.903055; Fri, 04 Aug 2023 00:43:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiuE-0004iw-IO; Fri, 04 Aug 2023 00:43:02 +0000 Received: by outflank-mailman (input) for mailman id 576668; Fri, 04 Aug 2023 00:43:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiuD-0004im-3L for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:43:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db29d1ed-325f-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:42:58 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E92761EF7; Fri, 4 Aug 2023 00:42:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BBAFC433C7; Fri, 4 Aug 2023 00:42:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db29d1ed-325f-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691109776; bh=UdXT2+JAmcKcv7dOtJNeXBI+rNm0c9k8j9eT6RBgY3Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kJ3QqrSHslJGLiwb4kI4SayoF8TMhC7gDLOfxzMoLmmCF5a40iralPryD4G/9N1ll DH+0+xKOJDKwM8fi8fbHZKc9OLmFH8Spvcw60SzdSU2g0NeT1jajTem1I3taHV+P/8 zQClv+xp+6+hCyru1I/Za0fJ7MgNgQXA5xl2VWQDw5ayBvijvoJN8aw2ELWZWvXon+ +dH38jgS9iiGwl7gMAO8b95qt23Em0ba6+z2kN9fZBeZpm5qBMf0ClzKwJx9ICakmb UofvkHsax9ZawhSzf3B4hmy637HOiJnFtQC7HWgIQaR3MubuRE6beTvqaujY6jc3WO x0PJuRFO3ygzw== Date: Thu, 3 Aug 2023 17:42:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/13] x86/svm: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <2779c3b2cbe27d95274a4ab44f6b9c877e59e8bc.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <2779c3b2cbe27d95274a4ab44f6b9c877e59e8bc.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini > --- > xen/arch/x86/hvm/svm/svm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c > index b3845bdca7..01dd592d9b 100644 > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -1077,7 +1077,7 @@ static void svm_guest_osvw_init(struct domain *d) > * Guests should see errata 400 and 415 as fixed (assuming that > * HLT and IO instructions are intercepted). > */ > - svm->osvw.length = min(max(3ul, osvw_length), 64ul); > + svm->osvw.length = min(max(3UL, osvw_length), 64UL); > svm->osvw.status = osvw_status & ~6; > > /* > @@ -1652,7 +1652,7 @@ static void svm_do_nested_pgfault(struct vcpu *v, > else if ( pfec & NPT_PFEC_in_gpt ) > npfec.kind = npfec_kind_in_gpt; > > - ret = hvm_hap_nested_page_fault(gpa, ~0ul, npfec); > + ret = hvm_hap_nested_page_fault(gpa, ~0UL, npfec); > > if ( tb_init_done ) > { > -- > 2.34.1 > > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:44:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576672.903066 (Exim 4.92) (envelope-from ) id 1qRivj-0005Hg-00; Fri, 04 Aug 2023 00:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576672.903066; Fri, 04 Aug 2023 00:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRivi-0005HZ-Se; Fri, 04 Aug 2023 00:44:34 +0000 Received: by outflank-mailman (input) for mailman id 576672; Fri, 04 Aug 2023 00:44:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRivh-0005HR-3D for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:44:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12eed940-3260-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 02:44:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C23B561DC7; Fri, 4 Aug 2023 00:44:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21504C433C8; Fri, 4 Aug 2023 00:44:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12eed940-3260-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691109870; bh=T/Gyp8K+J/T2MSq60L3DlKPnDzhU+5aLg0S52VXWxEk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AUY9U1PoZmUQbGZyjyo4QI+aeaIdXl6poXHZfaZ8sy3RNp5UaL2rhhD/Ie9djkq3D MIpdNlQtrqV5M88ILk/Hdjs9TgcpAkR5xOHstXdEIVvXPtmHkzjIZCgyPdQHerd8Y4 AnWdbSDY15PQ6eLz/a/xYedaPO46zKVZaE0lU3DXvUwtialPLSwnd6GTEhb7rEOkzH lBsK04ODTCPijEKUH7eSpVViAwVJv4eLMLRRKHPthnWAbdNB2Gt0HQUzt2hsO6oGuw EjzaafmHPrB0kYae0cZDeAXT5d68Zy6tsg/a1ZGG+iw7fShGroxzcFn9b7r67/Rzl/ IZGOX0pvLY7vg== Date: Thu, 3 Aug 2023 17:44:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:45:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:45:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576675.903075 (Exim 4.92) (envelope-from ) id 1qRiwd-0005r5-7r; Fri, 04 Aug 2023 00:45:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576675.903075; Fri, 04 Aug 2023 00:45:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiwd-0005qy-5J; Fri, 04 Aug 2023 00:45:31 +0000 Received: by outflank-mailman (input) for mailman id 576675; Fri, 04 Aug 2023 00:45:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiwb-0005oh-QP for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:45:29 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 346cb86a-3260-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:45:28 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0074261DC7; Fri, 4 Aug 2023 00:45:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73609C433C8; Fri, 4 Aug 2023 00:45:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 346cb86a-3260-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691109926; bh=T/Gyp8K+J/T2MSq60L3DlKPnDzhU+5aLg0S52VXWxEk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=myoZ64wH+anhtW07wEvaIpbUIWI5F/mzBsQtE2EOiOZfHSByKh/j1BtwsO4l2V0fX 6KKKC7fTRvwqgyvMHWG0ro8BxfwRGuRJLGiEeoaJH4EwC/jfrwNFgdAX3SSzGdlZgt qnDNiF6jUqoBRbIArLgQBfP2gXICz/u+idOFMkUSyVKJLYQXV7548MapQIZ8jjdGEM POBpUHDCxUF7HcxXlHIvh7VL5pBfU5gAB36P6/2KGHJj0od2CeL0wb05eRmreIpL39 3f06Lgfu1hOfWefdw6Bk2+WJ58kVi5s0R2C8M+4wkrUz1fhUPVkBwBxQwr46cq9M3T /Lut0Fe0EzbYw== Date: Thu, 3 Aug 2023 17:45:24 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [XEN PATCH 04/13] x86/IOMMU: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:46:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:46:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576680.903085 (Exim 4.92) (envelope-from ) id 1qRixF-0006RM-Kn; Fri, 04 Aug 2023 00:46:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576680.903085; Fri, 04 Aug 2023 00:46:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRixF-0006RE-IC; Fri, 04 Aug 2023 00:46:09 +0000 Received: by outflank-mailman (input) for mailman id 576680; Fri, 04 Aug 2023 00:46:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRixE-0005oh-PN for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:46:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4bb1b319-3260-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:46:07 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F305C61DC7; Fri, 4 Aug 2023 00:46:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB213C433C7; Fri, 4 Aug 2023 00:46:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bb1b319-3260-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691109965; bh=T/Gyp8K+J/T2MSq60L3DlKPnDzhU+5aLg0S52VXWxEk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OniK5GsPP4r1v/B+Xaq+PyQ/9FVT341uu39wnaF9irdRTkuDm+ruGnBG9REwLMCIM k2UgO1FbT+O7RRkzfN56SLybqJYCvRv6B00oxoL6+VlBuDUj7xNGF6zSvp1UQdlwxa anu1x6cl9jL7iHGs2TMALa7ySZh7XWJZXwG6JfzIFuQ2xDJX7bLdkaqt4JCh8RS1ej AChg4vgztaSb0XWbKtpLsgSf+kG/tHz7QFm6TerrEWyUvn+HKIQD1QcnEA4jFiqaam Q5fP0oFJ3Qw1GVMLmmDodnWBjiAaHdDvmHEQVVjqFirf+cEnyB/nQ9naAsOOhlQmBA CGagW7zh8dy7w== Date: Thu, 3 Aug 2023 17:46:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant Subject: Re: [XEN PATCH 05/13] xen/ioreq: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <771362e703548e55d4ccc420fa880585a5748c4f.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <771362e703548e55d4ccc420fa880585a5748c4f.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:48:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:48:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576685.903095 (Exim 4.92) (envelope-from ) id 1qRiz8-00075m-15; Fri, 04 Aug 2023 00:48:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576685.903095; Fri, 04 Aug 2023 00:48:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiz7-00075d-Uq; Fri, 04 Aug 2023 00:48:05 +0000 Received: by outflank-mailman (input) for mailman id 576685; Fri, 04 Aug 2023 00:48:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRiz6-00075V-As for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:48:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 903e7fed-3260-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:48:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3FED61EB3; Fri, 4 Aug 2023 00:48:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 682E8C433C7; Fri, 4 Aug 2023 00:47:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 903e7fed-3260-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110080; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XAfB44FZtGHWgzqurllVDo3K6OoWTQj6opwOBRDxYSxGTX+ChqP6lPKNLjxR/eHi3 q76aosi2+qHSt3VTcFl8LPqpbtvlWiauuNcdrSiBu5l1+62SG44jLMMMjv3CiIsfN0 VGMIGRKV2qUbuzD4GSWvZYjwFvNBdf2wYyhmsquwTJcxx7ExLrvWlDlj/zt8wYlmze Q/VbpAIF9p5/T1jL6NnZ8zqNEyErAxlk7BwnIHKZYaZN1bqL3Y3RIH6hWUlis6Kr+a wnxZpuAsDcZH2e81UcWBOqQ+8GGOm0d8bBwZhcFNZKlpOIV7qkfTtNLsbEdBGL6Ety cZ57NX4cJXl1g== Date: Thu, 3 Aug 2023 17:47:58 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu Subject: Re: [XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <7e4ff67a24206177c5a304055f395cc2983bb994.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <7e4ff67a24206177c5a304055f395cc2983bb994.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:49:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:49:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576689.903106 (Exim 4.92) (envelope-from ) id 1qRj04-0007d5-9w; Fri, 04 Aug 2023 00:49:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576689.903106; Fri, 04 Aug 2023 00:49:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj04-0007cy-78; Fri, 04 Aug 2023 00:49:04 +0000 Received: by outflank-mailman (input) for mailman id 576689; Fri, 04 Aug 2023 00:49:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj03-00075V-04 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:49:03 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b36d88d3-3260-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:49:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1736661E69; Fri, 4 Aug 2023 00:49:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF96FC433C8; Fri, 4 Aug 2023 00:48:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b36d88d3-3260-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110139; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=V2+M83k1yhLrIVkst5rr4ON/xfA33kz1fsYAwUXlek0WD14US6CdzboSgkyEUcAbY EVuy+MOZWNV9saQ2MvW9xHLSnl3bUbTunC6nVPOIOm0USQrh0QP8WS91XMoFTM3w5p DnVhM8i8seC8k4FrfVNAP8Iz1uDM1aGG0eVqm1AkUV7Z/soMMgS0RdNBeANy+BrfdX 9WJMrXhOP/z36CJDlZ6ZqXO6SsNEEffYFYSL32iM83fQhh4G7dpz6F/Zvbftxr1lgD Eyzxh3lyflyaKhml7NWNoi3zWYkxoBhEBExIlNpl0hNRcawUrK0c969XP32C+vaaV9 r4mcvhvA+xypA== Date: Thu, 3 Aug 2023 17:48:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [XEN PATCH 07/13] xen/vpci: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <4b97aa8203935ba6e202926add0baf8901af5ee9.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <4b97aa8203935ba6e202926add0baf8901af5ee9.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:50:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:50:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576692.903116 (Exim 4.92) (envelope-from ) id 1qRj1L-0000c9-Ie; Fri, 04 Aug 2023 00:50:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576692.903116; Fri, 04 Aug 2023 00:50:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj1L-0000c2-G4; Fri, 04 Aug 2023 00:50:23 +0000 Received: by outflank-mailman (input) for mailman id 576692; Fri, 04 Aug 2023 00:50:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj1K-0000bt-9H for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:50:22 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e28b9544-3260-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 02:50:20 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2492261DC7; Fri, 4 Aug 2023 00:50:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60300C433C7; Fri, 4 Aug 2023 00:50:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e28b9544-3260-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110218; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=epvsyWFaYKyhSrJliW05Ih4Ai+oFRvPv3p6Qe6nscmzkLlY+C70GFpWIVAMzK4r/T t5g5/5IMc3F3EgE4j3QXipbzYqYLoGgYoh07Lyi1cyXN8DXyUC3dZ3bCJe6Jp2wDZW ERUmXH/AiM/euaGb3ml75z5qbEajU9QLg5u74FbstIVyvRlVhMDEDjmiD+JoTVAF8w Xbd2gAU1uztmNcBV6VssoEHAM/YPcmE838xzrqDuh1MHKYMAoEScYzevVi2y+AEB8Z 9feOhQIbUGDxjJwx1Vjf5uyYFrhqRjylIwj5ODTIUbDkLxTg4ZT9umKhjUdh2BPD00 AWnb1J6NAjZPw== Date: Thu, 3 Aug 2023 17:50:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:52:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576697.903125 (Exim 4.92) (envelope-from ) id 1qRj3Z-0001CE-UJ; Fri, 04 Aug 2023 00:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576697.903125; Fri, 04 Aug 2023 00:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj3Z-0001C7-Rl; Fri, 04 Aug 2023 00:52:41 +0000 Received: by outflank-mailman (input) for mailman id 576697; Fri, 04 Aug 2023 00:52:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj3Y-0001C1-KV for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:52:40 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3572b10e-3261-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 02:52:39 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 28C1761E6E; Fri, 4 Aug 2023 00:52:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64DE2C433C8; Fri, 4 Aug 2023 00:52:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3572b10e-3261-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110357; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ow7avtQkZoOvFTpmNrO2EJqMoB5dEkMcBn2URyWX/IEiR2bDWP+zIMynRgVLlWErs ye5M384NAxsiP3GJQd4AotZFbArQxN3rLQjac5JIcq58Lz22p0iWB85KjRBiNme8Yl 4sVsftGL1kR/09xM2M4ev5Q7sCeNQzCsxzL8RkvuUUmTXrWhxygXvH7qv/CCRmXHEp f9b/iVMGIUM0Kfv7PlOHNiaDFUHf7FGE2Lz/P5xz0XF95G+A2Oc2z9NZ8psPNJ5JUl xPfB8fffF/MkYRcyDEE8i3MvLJ1ag6jnr8ZNHLRYD+DqTQyGBAi0HxuAn3Mafc++1N wG4HQ2KwhYD0A== Date: Thu, 3 Aug 2023 17:52:35 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 09/13] x86/mm: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:54:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:54:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576701.903135 (Exim 4.92) (envelope-from ) id 1qRj5A-0001kL-9Z; Fri, 04 Aug 2023 00:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576701.903135; Fri, 04 Aug 2023 00:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj5A-0001kE-6o; Fri, 04 Aug 2023 00:54:20 +0000 Received: by outflank-mailman (input) for mailman id 576701; Fri, 04 Aug 2023 00:54:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj59-0001k8-Hs for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:54:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 70957153-3261-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 02:54:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 56C7461E6E; Fri, 4 Aug 2023 00:54:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FA6BC433C8; Fri, 4 Aug 2023 00:54:15 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70957153-3261-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110456; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XqHoxIPYc4YiOSoTC11OGMQFXqOryxj5DT7VZoc+jA+56DVknxaxLysIP/4wfUgEu Md8x/yEiF6brFiGBozICG65NaU2rxc4Y7R2AHL3IQDFDqtxt+w819Q8Tq+7TWWxkUD Wj9KQPS2RlorM7rgRLtYSx5/Eriz26vTzo3dPXtuBv6XqXaxwNDAWyO4gsoLmyVwoC hMjVcq+lcMZ1Lr1QVqGHjOxOzZNOsE50SkklD3lJdi0KZftRuqNvU9I8PdqC5HHk6O SwZATPv6epgq/Yj/gpIJXb7cE0TrNo8ei2lWmdGaGG6WJv8el4EorLPbhJKuNnuK6V YAVPCwJAAVJsA== Date: Thu, 3 Aug 2023 17:54:14 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [XEN PATCH 10/13] x86/viridian: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <63f0d6385f302517244604af5536ffebd74ba589.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <63f0d6385f302517244604af5536ffebd74ba589.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 00:59:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 00:59:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576706.903146 (Exim 4.92) (envelope-from ) id 1qRj9p-0002P8-Rs; Fri, 04 Aug 2023 00:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576706.903146; Fri, 04 Aug 2023 00:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj9p-0002P1-Op; Fri, 04 Aug 2023 00:59:09 +0000 Received: by outflank-mailman (input) for mailman id 576706; Fri, 04 Aug 2023 00:59:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRj9o-0002Os-RW for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 00:59:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1cfbcfc7-3262-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 02:59:07 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BA7F61E6E; Fri, 4 Aug 2023 00:59:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F17B2C433C7; Fri, 4 Aug 2023 00:59:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cfbcfc7-3262-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110746; bh=Btq8tZRFhlQCg2lDER3ObYVeMIZwSEBi2OoSzGbb9xE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=RCCpvF2Wrj3Nu8u02wLW+yGh1iRg1CfnSALh+liBJh0IXSvFkGorPg/0SY2IDF2Q0 6jhQR+tonTWNEoP6J3CSKK1Gy5XCkyDkFdys19hPT9HzEJuUSr5CarslL7Us/F3JkA HnFmSkSnMopU04fUUoqNayQtDOdiO35hVGk/VuB/3eR131fKG2zOij223LI43+KWRW xFP0d+8H+GfCup4vFEAJtFkHmbFcFs9qA+f2xbIR73BwIsTWPcuow+FRFQCfxXIxzw 5zloPPLXSI3mxf4p7lW5cPyVKCCdmtbXOA4KeHwzYbyBvvkZ1OGHU9McsvERJiI9J0 sx6t5YTVkDooA== Date: Thu, 3 Aug 2023 17:59:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 11/13] xen/x86: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <40f438ad05338dd86587eb469c7b0614e1d69462.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <40f438ad05338dd86587eb469c7b0614e1d69462.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini But I think I need an eyes exam after reviewing this patch From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:01:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576709.903156 (Exim 4.92) (envelope-from ) id 1qRjBa-0000JX-70; Fri, 04 Aug 2023 01:00:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576709.903156; Fri, 04 Aug 2023 01:00:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjBa-0000IY-3N; Fri, 04 Aug 2023 01:00:58 +0000 Received: by outflank-mailman (input) for mailman id 576709; Fri, 04 Aug 2023 01:00:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjBY-000873-UQ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 01:00:56 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5ca173fe-3262-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 03:00:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4036261E6E; Fri, 4 Aug 2023 01:00:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FB64C433C7; Fri, 4 Aug 2023 01:00:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ca173fe-3262-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110852; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=oCdTSf8x8OpBX90SukM/z2/NrfXWpUWtiUR6G2PQxFBfv8gGp6Adpr+bqQrbUDuvq 494lL2cUhFMy3KatYnsw90Ko/lBprxXN64LOsgw+kdrp1a+T03nsWUsWmWoBvd2Vh2 JUExD81vud6g5BokrU9kUUzchhZZ/HaquRejbxnyF+oMu6XDVsBolLjnkMvr/T3C4J Y+XnXo/ZlF+3X7zmw9Aoa5TRUBXSx6EJ8JrFDCr7Bao+NLZIcIxeQRXNJ3ycsS/5Pc gwpvdnFJbfV2ZUr44ehcTjCOWdFqqry3K0H9sT4CNcd6imWgO55xX3qs3Jpf2UtXdJ SVYaGRNAjPCKA== Date: Thu, 3 Aug 2023 18:00:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH 12/13] xen/common: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:02:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:02:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576713.903165 (Exim 4.92) (envelope-from ) id 1qRjCj-0006Sy-L1; Fri, 04 Aug 2023 01:02:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576713.903165; Fri, 04 Aug 2023 01:02:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjCj-0006Sr-IL; Fri, 04 Aug 2023 01:02:09 +0000 Received: by outflank-mailman (input) for mailman id 576713; Fri, 04 Aug 2023 01:02:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjCh-0006Sh-Io for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 01:02:07 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 879d8829-3262-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 03:02:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F65E61E6E; Fri, 4 Aug 2023 01:02:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C2DEC433C9; Fri, 4 Aug 2023 01:02:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 879d8829-3262-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691110924; bh=EaAQPFoaGOI3ZfSLVu0aZr8HeevyqtL/S0G/iXavdas=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ncu+9R8PdDC1CMhxX2QntplIA/gbl14i6Dl2uuYTZ8s+acRZUD022hlFAEtHO4zGo h3XSUqBvCa0dsY5CynLe8UlKN+XvwPEqR586wSc7/X7wJn7SbUHk8aIbE7PwWc2asR JxG1bLuPLFFf2v4lJZE5kkZVat84pcJNCLc8//Tojm5GWwwrJFgp+DPnLak2vGtDPf ABchkO6zRuTw5jhTjBAOzPe+YxFs4j8CptuUJTecaNUzKlIaUFSVE5SxD2EAgHbHVv DRNW20YNh/cj/i6bjHebyMvmsVBQDRJJAcruiNp5tvTGUopEG4vRgCSg//u/c1782c yrGJVch9u1Rqw== Date: Thu, 3 Aug 2023 18:02:02 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH 13/13] xen: address violations of MISRA C:2012 Rule 7.3 In-Reply-To: <5b625185f779b9903463b8abd1aabfe7d5d8e548.1691053438.git.simone.ballarin@bugseng.com> Message-ID: References: <5b625185f779b9903463b8abd1aabfe7d5d8e548.1691053438.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. > If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. > > The changes in this patch are mechanical. > > Signed-off-by: Gianluca Luparini > Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:10:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576718.903175 (Exim 4.92) (envelope-from ) id 1qRjKk-000816-Fd; Fri, 04 Aug 2023 01:10:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576718.903175; Fri, 04 Aug 2023 01:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjKk-00080z-D3; Fri, 04 Aug 2023 01:10:26 +0000 Received: by outflank-mailman (input) for mailman id 576718; Fri, 04 Aug 2023 01:10:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjKj-00080t-TS for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 01:10:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b058e5ca-3263-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 03:10:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D923661F09; Fri, 4 Aug 2023 01:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 653A4C433C8; Fri, 4 Aug 2023 01:10:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b058e5ca-3263-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691111422; bh=oO0A3Ds5bT3/spXLHUEyqr8Wo0ZUsDh6x1xvfua1OlQ=; h=From:To:Cc:Subject:Date:From; b=jeFh6bLQ/4V3UmryprzFr7RaE7mUBoMoJo/nfqWsJGk/pyINWQihgYPP/IbVc7sOm VggWil7VUm2+4FjLRHKYnMbys0k2UYiWecLQ/IYQhQ+yYT36amhywU/NDqSxsHFb+G OBy3zjz7HiVxiRvedeKTsMdGBfKsUGytLao5ZyNLBGvB/C1rV9RgeRjTI7CjiFbpT/ 5YnYyrRW/smilYTigX3WXcHBm07NAFZf8Irh6OnS/AytbfkplGCHSovUl8MCy9zgk6 iGRO/f9W17BHXy+kH6+oSBQE1Z6HBLIHK2fNK8PqtvAjrnOPekJU248G4/1QbVTtNM +0ZVFjuVvVvwA== From: Stefano Stabellini To: cardoe@cardoe.com Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com, simone.ballarin@bugseng.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: [PATCH] automation: add missing "needs" Date: Thu, 3 Aug 2023 18:10:18 -0700 Message-Id: <20230804011018.2888869-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini The test artifacts export jobs don't need prerequisites, so we should specify "needs" with an empty array for them. That way, they are not going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete before continuing. Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/build.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index f01e2c32bb..af64a53ead 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -268,6 +268,7 @@ .test-jobs-artifact-common: stage: build + needs: [] except: !reference [.test-jobs-common, except] # Arm test artifacts -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:13:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:13:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576742.903254 (Exim 4.92) (envelope-from ) id 1qRjO4-0000uK-Mt; Fri, 04 Aug 2023 01:13:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576742.903254; Fri, 04 Aug 2023 01:13:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjO4-0000uD-JQ; Fri, 04 Aug 2023 01:13:52 +0000 Received: by outflank-mailman (input) for mailman id 576742; Fri, 04 Aug 2023 01:13:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjO2-0000tr-Ng; Fri, 04 Aug 2023 01:13:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjO2-0001oK-LR; Fri, 04 Aug 2023 01:13:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjO2-0001Vf-6S; Fri, 04 Aug 2023 01:13:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRjO2-0004Wy-60; Fri, 04 Aug 2023 01:13:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+yP4fgZgcgrCcK9vOrJm1BGrgTzqDm4TaRt6CmQs+Ac=; b=Bo6No2SIXTnMx50Z0BW7C4lWGt P2jQbrJTfoz+xDSI+j4pid7EV6KO0MSDeXhiabrX/4N5aztoBnMIp+jRFa0I3hpXKMRTfZcj7jkRd G6HH/p3Rl+/mJ/adN2ocZE2l2yNWo4fp/MkQbUJhirwRHi7qIbKWhR1rNzEevTKKzij4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182128: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=51588938e0cd0e02dbc1d6d8c697c577135ff666 X-Osstest-Versions-That: xen=c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c From: osstest service owner Date: Fri, 04 Aug 2023 01:13:50 +0000 flight 182128 xen-unstable real [real] flight 182173 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182128/ http://logs.test-lab.xenproject.org/osstest/logs/182173/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 182173-retest test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail pass in 182173-retest test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 182173-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 182173 like 182097 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 182173 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182097 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182097 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182097 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182097 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182097 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182097 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182097 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 182097 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182097 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182097 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182097 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182097 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 51588938e0cd0e02dbc1d6d8c697c577135ff666 baseline version: xen c0dd53b8cbd1e47e9c89873a9265a7170bdc6b4c Last test of basis 182097 2023-07-31 19:40:22 Z 3 days Testing same since 182128 2023-08-02 18:03:55 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Federico Serafini Jan Beulich Jason Andryuk Nicola Vetrini Peter Hoyes Roger Pau MonnĂ© Shawn Anastasio jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c0dd53b8cb..51588938e0 51588938e0cd0e02dbc1d6d8c697c577135ff666 -> master From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:14:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:14:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576750.903280 (Exim 4.92) (envelope-from ) id 1qRjOi-0001a4-66; Fri, 04 Aug 2023 01:14:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576750.903280; Fri, 04 Aug 2023 01:14:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjOi-0001Zx-2R; Fri, 04 Aug 2023 01:14:32 +0000 Received: by outflank-mailman (input) for mailman id 576750; Fri, 04 Aug 2023 01:14:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjOg-0001Zb-Ru for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 01:14:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42a6ae3b-3264-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 03:14:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF99061EDD; Fri, 4 Aug 2023 01:14:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1AB0C433C7; Fri, 4 Aug 2023 01:14:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42a6ae3b-3264-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691111668; bh=92tN2DfU2nM4pUttl6ojxsNSgRfdxW+Cw6LmxlTiFw4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JY/QtElVycxg8XfAbu6pk8SjpLIdQ2xNiVz1jPWwnFswnMbkXtDv11tgXLiOuRCml 0FcrKsOKweLnYpx6Ozjdfzeo0D1nf8EUVfnJ/i04p1GdWGkaZ1CblTiKVRegNmZw14 R4UJynL+M8UuYTGV5eH6RSGIhenuPGb3G2MW63F92A2ovQQeN+tWLIP7ijutsjgXSk G1Zd5zTJBwvTmoGbeCCvt43FNlsguDDcUueRxzTVHQBCCYaYsJ/lilmpFXM2m70DER 6e4+4ApYbgBaYeto/r8J+JvOhf1kc0TmAPtrh6dPklPNKjXEhNDxcOzSuSN3YejfWz fE/bIHHN8JGMA== Date: Thu, 3 Aug 2023 18:14:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: Nicola Vetrini , Jan Beulich , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: Message-ID: References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 3 Aug 2023, Stefano Stabellini wrote: > > Actually, they can be deviated because they don't result in wrong code being > > generated. > > This, modulo the review comments received, is what most of the code would look > > like if > > they weren't, with the biggest pain point being that in many cases the choice > > is either > > the pattern with blocks for certain clauses or moving them in the enclosing > > scope, which may > > be several hundred lines above. If there's agreement on deviating them, I can > > drop the patches > > dealing with switches and do a v2 with just the other modifications. > > I think we should deviate them. Good idea to remove them in v2. We should add a note about this to docs/misra/rules.rst as well? diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 8f0e4d3f25..e713b0ea99 100644 --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -106,7 +106,8 @@ maintainers if you want to suggest a change. * - `Rule 2.1 `_ - Required - A project shall not contain unreachable code - - + - It is acceptable to declare local variables under a switch + statement block * - `Rule 2.6 `_ - Advisory From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:15:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:15:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576759.903306 (Exim 4.92) (envelope-from ) id 1qRjPu-0002Qt-Q8; Fri, 04 Aug 2023 01:15:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576759.903306; Fri, 04 Aug 2023 01:15:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjPu-0002Qm-M8; Fri, 04 Aug 2023 01:15:46 +0000 Received: by outflank-mailman (input) for mailman id 576759; Fri, 04 Aug 2023 01:15:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjPt-0002QO-Le; Fri, 04 Aug 2023 01:15:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjPt-0001s3-KE; Fri, 04 Aug 2023 01:15:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjPt-0001Z7-7G; Fri, 04 Aug 2023 01:15:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRjPt-0005GQ-6t; Fri, 04 Aug 2023 01:15:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3yHzi2rEmF5HBZlX0ni4+z+PqffbDqMlQOzL4TF9jxc=; b=LAOmkV0GTihYQmDgWFtE6WQ4Vw qGdLovbh0dD3tqPP0EMyf/iY0hwtgprazLnuljufRd6wYcGEFuYTrw4G+iVEfgBY0iRCk136YtMfF AM1Z/CoZsv84ZPKM2t7I7GxsktYcB68aAiU8ePzAplNdDeVx3TUcXgrygN3nEq9fzjiY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 182131: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=99349ba18e726465215a71f28d2146a0a2adb65d X-Osstest-Versions-That: libvirt=a3a8cc0415cc46ffc4d89d60ba3d742a02880a36 From: osstest service owner Date: Fri, 04 Aug 2023 01:15:45 +0000 flight 182131 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182131/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182099 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182099 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182099 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 99349ba18e726465215a71f28d2146a0a2adb65d baseline version: libvirt a3a8cc0415cc46ffc4d89d60ba3d742a02880a36 Last test of basis 182099 2023-08-01 04:20:48 Z 2 days Testing same since 182131 2023-08-02 19:15:02 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jim Fehlig Jiri Denemark Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git a3a8cc0415..99349ba18e 99349ba18e726465215a71f28d2146a0a2adb65d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Aug 04 01:34:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 01:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576767.903316 (Exim 4.92) (envelope-from ) id 1qRjiJ-00051A-ET; Fri, 04 Aug 2023 01:34:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576767.903316; Fri, 04 Aug 2023 01:34:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjiJ-00050s-7t; Fri, 04 Aug 2023 01:34:47 +0000 Received: by outflank-mailman (input) for mailman id 576767; Fri, 04 Aug 2023 01:34:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRjiH-00050V-Rx for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 01:34:45 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1651faea-3267-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 03:34:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B835B61E6F; Fri, 4 Aug 2023 01:34:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8170C433C8; Fri, 4 Aug 2023 01:34:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1651faea-3267-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691112882; bh=49awLqtP5ffAvdFDI7t3AqrjjCHxZIRC4PDakMVh9vg=; h=From:To:Cc:Subject:Date:From; b=NMlZO6P7fOI7Pm2IYOICmvINhgQllAoNvk8e3l7AbS2lXrYRX/mXD1Hir+ppareGW mz5sQpKqzq+bEJ71wwJzrhA7hVRhPlA4weAVvkiPy6LRokUMREKI3XAxubFMqpK4fd YAy4RSDFJEPlLXSX0INjA218ZcUXD9OV68hnx34odvMjia/pScwmOv62zN01FNV9Sy VpGfT1nZVsOWMWI64wftWCF76Xs3VaLh8nUOm7FlxOCPu6KjimM5mm+gCW3W/2ST1C dmg+YSSSlCkLQM/hn7nlpUoWf2eBVxH1detGH+ZpildMPSzN3EcnnqbW5Be62vGrS4 VFAlY1cJtgYUA== From: Stefano Stabellini To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, sstabellini@kernel.org, julien@xen.org, bertrand.marquis@arm.com, roberto.bagnara@bugseng.com, Stefano Stabellini Subject: [PATCH] docs/misra: add always_inline to C-language-toolchain Date: Thu, 3 Aug 2023 18:34:38 -0700 Message-Id: <20230804013438.2894725-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- docs/misra/C-language-toolchain.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/misra/C-language-toolchain.rst b/docs/misra/C-language-toolchain.rst index 785aed1eaf..21b292898c 100644 --- a/docs/misra/C-language-toolchain.rst +++ b/docs/misra/C-language-toolchain.rst @@ -84,6 +84,8 @@ The table columns are as follows: see Sections "6.48 Alternate Keywords" and "6.47.2.1 Volatile" of GCC_MANUAL. __const__, __inline__, __inline: see Section "6.48 Alternate Keywords" of GCC_MANUAL. + always_inline: + see Section "6.45 An Inline Function is As Fast As a Macro" of GCC_MANUAL. typeof, __typeof__: see Section "6.7 Referring to a Type with typeof" of GCC_MANUAL. __alignof__, __alignof: -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 02:38:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 02:38:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576775.903342 (Exim 4.92) (envelope-from ) id 1qRkhe-0003fw-5h; Fri, 04 Aug 2023 02:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576775.903342; Fri, 04 Aug 2023 02:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRkhe-0003fo-0F; Fri, 04 Aug 2023 02:38:10 +0000 Received: by outflank-mailman (input) for mailman id 576775; Fri, 04 Aug 2023 02:38:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRkhd-0003fe-1m; Fri, 04 Aug 2023 02:38:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRkhc-0004BL-UM; Fri, 04 Aug 2023 02:38:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRkhc-0003y8-Gr; Fri, 04 Aug 2023 02:38:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRkhc-0003G0-EQ; Fri, 04 Aug 2023 02:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yPNa4J6Nz6nYQlk9Tv6Ub2fy8/No7gULBOnSN1NIqA0=; b=FZ3uyCBR3Jg/H2MEptTePwQkNU wzuAxTle1orA/Sxulh+mw8fzgUc8AhPBpSg9rYCV/qn/Zo69FLJG1+6VOdQsuQdMMk9MJhGuhK8vr xnxpRe9CkdKY1Wd8Olj4TV+x85mn/O8ZnCSfLAFku2uijnSGe7kL6weENeLkw4CVtZrw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 182166: tolerable trouble: fail/pass/starved - PUSHED X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:hosts-allocate:starved:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:hosts-allocate:starved:nonblocking X-Osstest-Versions-This: xen=ff736d9f2abf9131414d72d0124b3c7739491249 X-Osstest-Versions-That: xen=3e357970c90172526d58e964f8ceaf32b2c69655 From: osstest service owner Date: Fri, 04 Aug 2023 02:38:08 +0000 flight 182166 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182166/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182107 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182107 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182107 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182107 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182107 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182107 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182107 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182107 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182107 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182107 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182107 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182107 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 3 hosts-allocate starved n/a test-arm64-arm64-xl-vhd 3 hosts-allocate starved n/a test-arm64-arm64-libvirt-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit1 3 hosts-allocate starved n/a test-arm64-arm64-xl-thunderx 3 hosts-allocate starved n/a test-arm64-arm64-xl-xsm 3 hosts-allocate starved n/a test-arm64-arm64-xl-credit2 3 hosts-allocate starved n/a version targeted for testing: xen ff736d9f2abf9131414d72d0124b3c7739491249 baseline version: xen 3e357970c90172526d58e964f8ceaf32b2c69655 Last test of basis 182107 2023-08-02 02:35:16 Z 1 days Testing same since 182166 2023-08-03 14:38:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Julien Grall Khem Raj Roger Pau MonnĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl starved test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm starved test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm starved test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 starved test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 starved test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw starved test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx starved test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd starved test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3e357970c9..ff736d9f2a ff736d9f2abf9131414d72d0124b3c7739491249 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 04:11:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 04:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576782.903351 (Exim 4.92) (envelope-from ) id 1qRm9W-0005nH-Q5; Fri, 04 Aug 2023 04:11:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576782.903351; Fri, 04 Aug 2023 04:11:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRm9W-0005nA-Ml; Fri, 04 Aug 2023 04:11:02 +0000 Received: by outflank-mailman (input) for mailman id 576782; Fri, 04 Aug 2023 04:11:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRm9V-0005n4-9N for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 04:11:01 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061b.outbound.protection.outlook.com [2a01:111:f400:fe12::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea1a206c-327c-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 06:10:58 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM9PR08MB5940.eurprd08.prod.outlook.com (2603:10a6:20b:281::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 04:10:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.021; Fri, 4 Aug 2023 04:10:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea1a206c-327c-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUL1Ouf7mHKPGnI7q0BM4bgRGqEPkNaUOoRoxEWQ9F8MVKtuGW7JuJIbiMyRvsHFdQDAP5wFrAvGMDCwoU/eTSs/chVuUKRN0jVo3WGpQsIqSfYC4AbRBGVGBqMVuTCyEerFd8aMxjv8rbPMoKGmLG4IQbPGxzP4G+ISg/E80CSL48o8j7fh2rEVPcmXfWNHfSlJh8FAKPYr7jKv1q4uTCVmL5Vf/s9WSgPS7lxFMQQF/A9E/UijJE4f20K2PHzA2/haec0nxcYaJdBcJbOdfV8/G0e5qFhpjhjGyrsiHasuPdMEmZke03jec19ym3fYstBpK479jjGZAi8jW4M1Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8xqu/UcUCBDBaKDUDCHrvXv0JXe2qen/EqNo7YXWLY=; b=IzuQKL5IsxxilSjyA+qb9T4K0pBDC7hXrQxlGrNQnNwXKeupqYu+WqaoshN5vL7pAiz7p592bUegbQNx39dK6UWL33rzNcyrjg8oyoLuWbZ/3AdXmg3f4udf6WNabDYluCAfqkoqwjvYQ/h452EfstrS+TcNMxFApyttuUhk7Lz2MKd+Ogz+Cny64Bqxis6q5F/bEzd4irdgl471vrBwQ+znSxeOf6nP3jI83G9mEj2IM5Ex7DKmX1aLE2TSpO6oTGrTOnU7ZRrWaAHd8VtKaedBNM5Nx09jnYYYrD5CKJ9JeFPfYMBbl3QcTfwENIciNpedExFYh1ar7WObXJlqLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8xqu/UcUCBDBaKDUDCHrvXv0JXe2qen/EqNo7YXWLY=; b=2eAgeLmtEdkczu3I/bvLFGg9NH149itwyB3Wt3f/FIS5/JukW7L6f4pHNRw+vvnMfr2Nx3NfwoOWxCVaHjrO89K8R1e6u4CR1iYN2Ar9XTs+1rac+5GvJdaJ2FFjW3NJVLIYfHkgDvioB3GGW4wUNPBcM+iW6XFpDjDPQnq5uUw= From: Henry Wang To: "Daniel P. Smith" , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: RE: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Thread-Topic: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Thread-Index: AQHZxfe0sdxLBCk0m0eqfbJm59//E6/ZhneQ Date: Fri, 4 Aug 2023 04:10:54 +0000 Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> In-Reply-To: <20230803104438.24720-3-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9A6AEE420277C5488F584A3AB5447E13.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM9PR08MB5940:EE_ x-ms-office365-filtering-correlation-id: 81cc23de-1256-4002-7446-08db94a0cc63 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8DDRolHa8/AeRYzp7YCFgjYho5fh8ktK2DF5qdzKyD/sQ7UosS5o2tKoZVcM8RVNkcDlIpWbfafaM7So0k84PjEW3t6hodPJMYjvsWF2mVi9wDG8+j9LrbGtiLjRxkvyXLhNqIQPqz/Gb+PEQgVea3fzT7YUAbclI4JRbiQHscvP9oJz8CnWQ083G1WjzpKSQOJgR7Cxr30UJtkWGANnWVJdVCjUe13PRUruospJeM+L17DNKfSByJvVkNZKoolZ1lEwjQ/jwCk+aiC9GSzV6JOjfD+GM+C2WF94WBubJj1hO7n0QQ/7z6QPW17MohZKbkxXi3TQYUrdmNQd3/AVWQC0xCkBs/roXxbHcWvzkVj8EfrKuYvq40HP5b31XXzL6ioO+uZ9BOYNq59fd4rZO0Pbf091/zCRPUUoqjK25VeZKYP5X5xDt9mJjAwP5w019MP3sJgVZZZQxFS4YjT9e/2a8MjYrDQv1zSPZ1FaLrLk3JL5ljQf0PtFufYsTY9IziHXgqSHjHsbu/r27dJc6SCAGEG/mGNy3h9czYagE4Bt8u3VM94F6lsjQ680jgAPSK2v37uPDpqOD77o/uDbXL9u7jyOXQ7jQnvF/IWaDhEFqkvV/gsscFlAt0UTbttH x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199021)(1800799003)(186006)(8676002)(26005)(6506007)(83380400001)(66476007)(2906002)(316002)(76116006)(4326008)(4744005)(66946007)(5660300002)(66446008)(64756008)(66556008)(8936002)(41300700001)(7696005)(71200400001)(52536014)(9686003)(110136005)(478600001)(55016003)(54906003)(38100700002)(122000001)(33656002)(86362001)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RZI/5GiDw10BouSgtexTXZlJxIWhoF+VCFZcqhxYEB0Qu1kcv1I5ydkdsfNm?= =?us-ascii?Q?QzGZgVjgKPzcx36jHUyc0qFbCvDYkmWAhbbdlKYCoeGkVwLETRmJYjjSRD1U?= =?us-ascii?Q?yJb5EprPTZRn3e+KHM/FTNRFEz6HvuB4ggCWwXea+VpmGjsA69pQY/vC5xGV?= =?us-ascii?Q?jlnoG2tT7+HuFogAsb45jZJUx/I8qGfF3o2PGdz9iBN5saU7PxQfLl/eYyUj?= =?us-ascii?Q?jaaQ77UPldi/9uc5cIpb1LwVgCa7QvX7m+gyD4e8y471whYtXkOJBlTGkHAC?= =?us-ascii?Q?dxBoPztZJ+x6ryn3dZ9yJ3UFyVQqUqp9mafNy/kqiQb7O9wBb29EQiEtThCu?= =?us-ascii?Q?QX9negJ2MI/2tX0L+ZveGjcXpsmqNnUD8YYaBrTyFKz638Uc1YUpwBAV9P5d?= =?us-ascii?Q?o3oDuE/oRpvEjWbPYllXBE64ftepfCvz3rWvJ9+C4B4NocFjbWsw2K1s7nKe?= =?us-ascii?Q?2Rk+3ljTD6W1MCXz3tBFSw1GKgZ99vEDwt7KDGdZSSzvcagr07E5uhGsZoWu?= =?us-ascii?Q?p1H9+sHhB4a+NR2368k4scBv1fIm55LnOkReZBpKItL65Iem6J6hUkYdyKwI?= =?us-ascii?Q?BXrnsdXhzSFHnsfrZcf1hV+wyGGwCATmaKt2KU4NQWas5Y36vA879Uxtmc4/?= =?us-ascii?Q?3Sz78THrII89n41jZgjbxBiOjx4cbBBPtt4Y/qQUx3K1d40pWwWq/drzcniW?= =?us-ascii?Q?uBY4PZd1YWSMQrSyEH/hQF+k8M8XryTgGihVsbNKB4rAxteRPm8/Rg7ZMfUF?= =?us-ascii?Q?d4KFOijQeiilbDqJ1c7nrkSn2+uQv+UBOSvUJXhQTGrMB792NyZyWDPE4gUD?= =?us-ascii?Q?o6WyzN0uXuzxPFgCwdOjWcVguVB0shFcj/nKA7GqkqN/9P/i7uNQxJI6uI9S?= =?us-ascii?Q?JYYhwfD2t3Fq5KdUr4rKbSQv3/StdpUsv9a/b4M8taWQ2XyaDEVLVG9Bdb8s?= =?us-ascii?Q?Z3609oTMh/y0OW2cJK/y+yoKJR6EbnFSgaZFROPtydqEcp9wtZBuiYLiBxX2?= =?us-ascii?Q?ZANXlSoTKwBI8c9S/fokAo2Sonj+EFnlMZvpD5OTs2rVR2prCMZHi7uKjj4D?= =?us-ascii?Q?624bN6oVHJySDS4gRXyiom6+6pdCJ/X7/gtHBUDr3IDWRZCkLm1gE2Z6RUTK?= =?us-ascii?Q?/0JPqkrllaP5oPKe6vHR80sd0NqB255rBALW+KWjyvxZHjc7BANLDgRFjhyB?= =?us-ascii?Q?A/1TThNF23h7n87iwcxsNS3BPDx3Cef+V2g7RGmQiJnxrNYHqE+Mu4CkqOEs?= =?us-ascii?Q?uFoGVEod0LsYIiVLfVxXuAfBhdKY4ZiYOflSBqgoEfu1Cm4St63WAvRx/r5C?= =?us-ascii?Q?lx1kogBDNX31RwVhA/p/w9D0RAbfL1EW4+tEdZhOSdvq3PkT1Vbjsqg3bL4x?= =?us-ascii?Q?aPx3zXoJX9eWqvMbiQ8e1Lo3EFXpZJq3YUKgE1MmJuggKz2L9a2ZnesEe+XT?= =?us-ascii?Q?twzlHm59TZZWkOeHqV5JvXL/hP9MxjmvCHxJCYv4X8y+jYe32tkn0yLaUxal?= =?us-ascii?Q?E2+lZnO5DiJCC576cHqm/8PUcUzSIb4vPksDh/4QjsiWqaAIcBQHfaClKqwL?= =?us-ascii?Q?0oZX5L4xpqTCoTOKLDU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81cc23de-1256-4002-7446-08db94a0cc63 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 04:10:54.7460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G2HkTlXQsell1nalLoWvN3j1eqQXyXDm+ksF33rDjcs9zJSW06dxk1vD5o/9JDd+fjMTUKhZHsDlyU6JL2XOCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5940 Hi Daniel, > -----Original Message----- > Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch >=20 > This refactors reusable code from Arm's bootfdt.c and device-tree.h that = is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of parsing DTB files is needed by a capab= ility > such as hyperlaunch. >=20 > Signed-off-by: Daniel P. Smith As said yesterday, I tested this patch and can confirm this patch will not break any of the boards we used for our testing. So Tested-by: Henry Wang (But I saw there are some comments from Michal and Luca about this patch so I think these comments need to be addressed) Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Aug 04 05:21:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 05:21:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576787.903361 (Exim 4.92) (envelope-from ) id 1qRnFI-0005P1-Ps; Fri, 04 Aug 2023 05:21:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576787.903361; Fri, 04 Aug 2023 05:21:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnFI-0005Ou-ND; Fri, 04 Aug 2023 05:21:04 +0000 Received: by outflank-mailman (input) for mailman id 576787; Fri, 04 Aug 2023 05:21:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnFH-0005Ok-Hk; Fri, 04 Aug 2023 05:21:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnFH-0000AB-G0; Fri, 04 Aug 2023 05:21:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnFG-0005Jb-VD; Fri, 04 Aug 2023 05:21:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRnFG-0000ZU-UZ; Fri, 04 Aug 2023 05:21:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=W0CjFcT7JNEJD8kFmhfB1bETWHIkhvztXtVr163h8Ts=; b=zlwC4aYtdMKYmx+zGFfqPe4ruz UgODB2u9BtmBoCNDxObcBcJRxq+yrGaqfQATl/7zIfsifcoC7J05+NbuOwgM9Y3HVzcd+eseGXVQR EvYQPmMMNiEzVo6CzWJMxPZkgTTNihoHKdbrzH1y9M4balDmRdHRN3LC643pbxkPFOEA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182177: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4a6448fd6497ad7952cd0baacec1869f6791de9e X-Osstest-Versions-That: xen=092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a From: osstest service owner Date: Fri, 04 Aug 2023 05:21:02 +0000 flight 182177 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182177/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4a6448fd6497ad7952cd0baacec1869f6791de9e baseline version: xen 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a Last test of basis 182172 2023-08-03 19:02:02 Z 0 days Testing same since 182177 2023-08-04 02:02:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Simone Ballarin Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 092cae024a..4a6448fd64 4a6448fd6497ad7952cd0baacec1869f6791de9e -> smoke From xen-devel-bounces@lists.xenproject.org Fri Aug 04 05:53:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 05:53:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576822.903389 (Exim 4.92) (envelope-from ) id 1qRnkj-0001Wu-Ce; Fri, 04 Aug 2023 05:53:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576822.903389; Fri, 04 Aug 2023 05:53:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnkj-0001Wn-9g; Fri, 04 Aug 2023 05:53:33 +0000 Received: by outflank-mailman (input) for mailman id 576822; Fri, 04 Aug 2023 05:53:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnkh-0001Wh-AJ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 05:53:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20608.outbound.protection.outlook.com [2a01:111:f400:7eaf::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c12cff4-328b-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 07:53:29 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB10073.eurprd04.prod.outlook.com (2603:10a6:800:1dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 05:53:24 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 05:53:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c12cff4-328b-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HBLLS/20mRirAEBG9EDPkq/NdabbcfAO0phaxPSaOXccad7Q0xA4aiSP+FUzXLSfb6mRw28aqUlik6dhVdvTzxRdQBfxCL1bPtB/vR4VRbXGWG7wjuApT14m5qimXkuUDh5047IHefXo/hg4tUriFExqQfqnAtsjJ9Yw9l7Y+OIBKUAS2gjtUls2pe/HEq5k58GLPnB1uL0rb+deUqdJOVpx6ciD4Ulr7AkqFGl+GpQrL1AQAN9bXq0KqCbq2htCNtaD7lcfQRhZ5xJ+L7v97BziJcWxkvZ512L7LDkRf5o/8Hxu9N6bN8zFc6A6Cg7E22c7P1X+XSMxJOsG3iI50g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K28Xp1Ea3H7jAy+erQruHUf+De5WEFjuI4sZ1DTcCww=; b=ZOhpgo1JKBJ/i1rlLgxTX0JdeGc6ahTmLaJXONoZ32P2ZaY5IbbaVp78sNQ0+o4mKIWYJCNRQWtvFh/j1dysStY0D+4PkmykAWkYBNBCWb4QMchmIqmWMgG6bL17aD86FpxRjAa5vA4bSMCLoSMLbsKocLaY628GRMOmj4AztBQcNo8daXltGvgHNRs1DcPL+ZFLK2w771idN4guP92F3GrqzOY0Z8wJZuNS7YpphUOya1x5cY3K0veFK6wzZZdBmmHbopyY360E9KmN8TLQ+PfpadecWPZ9j1l8aoitjtH9JvdF3jjb/xmCulkaK+YZ2NAdtBhsxkQB/ddfwQt7Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K28Xp1Ea3H7jAy+erQruHUf+De5WEFjuI4sZ1DTcCww=; b=HsJn/YF3WS4b0cRRDejZiRko6BsgvMf0wmYLGd8QIAoe2OSndlcgj1mCdPNrMgy7GaAvTE8DM2vedTcdZSBMnf151n6Xm2+Hp6QojJCpNS4PF6XWEkgTLWX8YoUmra6repWKMzZAOzzR6I1kivF32p6WpxYlqYl297mrbVWbTvE2jPWUehIqIHymc+5hQIyQdmDcU2KlnVub1jVjvGztxVfZOdpt8T3abUdI4x/UWwY1w8hL3Duop3VMIdl7LEKht/LIBQGIrJw+9yOHSUNsLiN4FpQD36OcAG+WjDlOG2FeJiyz4McEyLwctxFTLyf+6vGyTtaDjMazVuZywyMiwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 07:53:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing Content-Language: en-US To: Elliott Mitchell Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: <673c6ba4-6d1e-6e51-0da4-fb8996cde4a2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB10073:EE_ X-MS-Office365-Filtering-Correlation-Id: 8af6f497-578c-4401-fc86-08db94af1d69 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GMIGHP4E4I/yZ/QlW5Bg/wZxZxT9flXIMpzqdSPmOcPzEvkwIgbitX3N7z6Te/NE/qtqTp48W+FiuptWpEe38NDrFicqWVymQATe7Z9VkgTdrCUyeZYomUYNly5nZ/Uv3jei45VG36xHDnDv9Sf5aVehi1nZRmCeeQ1F/g9uOp7sx70hDzVYzkbsH1G2u+rucMJE7QlW2b3QcGWZg3z8APL3BLmJuUh5e1DryFAbfZI2L3qZZH90MMd0Z6IC6itHLPlI+5k4EwnTPHsmVzshpAOs24KZybMdfNOFy15yfwcMz9k4qR0i1ffG7dh0mlEaEQGiwBQ8+4xwMNpelGCgkaEsjEbNh1fgYJI/R8tI2E/k2Pc2pdgFRnu95IHfS77+HszLx3aSSI5j87K5NZC/De/p3/9fpMJDawN6I57EE+7NSKAy2LRsQMWK2VNg/o06O8NeFcgULc4QFe79HbUzPrHGM6x1tqcP/hfyM/Xburz0oD4FggVX+Ekd2hpXGl/ofDenqa5oyGlCGWc7zik70nrv4m4zcG2LfSNoukWSaN3Zt4KyU8M3QIKwWGR3DXwpY+eDF54+c8+S9iYgxyH6k843YraIcm4ak88o9FQWVsdadknEiL4oCnovdp6PgE2zhrPnLYlpt3GbdLY3a9JcKw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(39860400002)(366004)(136003)(396003)(451199021)(1800799003)(186006)(2616005)(53546011)(8676002)(26005)(6506007)(66476007)(2906002)(316002)(4326008)(66946007)(5660300002)(66556008)(8936002)(41300700001)(6666004)(6486002)(6512007)(478600001)(54906003)(38100700002)(31696002)(36756003)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnZtbExxMURLNktUZm14RE1tUnJkbldHV3R5Z2JHdlRoQkd0bUs5dWdyZXEy?= =?utf-8?B?WGUwSFhCTTlqNVQ2V0ZqUFpjTzJpYU5DYndTS1VLWUg5N0pOOS9DTE1DTGJD?= =?utf-8?B?Q04wclpYTHFzQ2hOQUkwOExab21IbWpWeko5ZXRyaUUvNi9MbTExVURhNUV3?= =?utf-8?B?QlNhUzZVb3lkNW1hVW1Md3ErYmRsUUY2Zzh0VllwUEdFbjZCc3lFNkVmS3k0?= =?utf-8?B?bktsZkl6L0taY2wzUDNITVlQZEM2cElReVU1b05vQitYNnFhODg5QUNWdDl2?= =?utf-8?B?TmMyK2s3UFJkb2w0VHljcW83bkJ6UUZyS3h0Z3JNWFZtQ2JNTHpmVTlrNk84?= =?utf-8?B?T3hLaEtDaFVVS0JVSkN2b2pIRDlZS2lzK2N1RytGVytQMmI3TG1CTGJQVGdY?= =?utf-8?B?RHBKR3p1eUVhMFBjeFQ0UzB1TGltWlZiL2lLZXFORmU4QlVtNXovSnhNL29S?= =?utf-8?B?bHBkdENEenBKWCtZSkRGQWplVkREZ2pWWlJrY0J3czVoR2NRSk1jVDg4YWYz?= =?utf-8?B?TE9md05FTTZqYnN5eTdtdGliV1pZeEc4MWFBcG0vUTRHQ3VlMnZrRGtISlY4?= =?utf-8?B?WlFJRUxRR0hJa2dtUmRpdWVaUUwrNWpUMnZMZklhTFNSMU9zS3BKUnlna24r?= =?utf-8?B?Zi9nd3JGL2RGV052VlR0M08rck5HcUlPczQwQm5aMWhqNXJCdU0rbG91L3U2?= =?utf-8?B?SHZ6L0Q2UENIMjliampNTnFydnAwZDEyaTg1ajNLaXNxMzFPbzJPc1RrU0xO?= =?utf-8?B?MHdYWHMwVk8vVVd4alMrRGg2R2gvWENMVlpEUHBPVENxRzJPaVBCTWhsWVpt?= =?utf-8?B?QmRyajJSK2swbmxmZjVtbk83TWFnT3VQUEplZXdYb3lqNjZUZXJFSGlKczFJ?= =?utf-8?B?K2lyTlpJd1BPV2dZZ0sveGl5YlBtdC9kY0ZjMElQUTE3b3FtTFRQWkQzZDhX?= =?utf-8?B?aDMxUnlTTzJpRkNRaE01R2FDMDJjWGlNbU5BQW5VdGtqQ1pQZFF1dmhjSWJE?= =?utf-8?B?M0pWMXBRNXRoQXBMcCs1VDRHb3NET2dMK2ZlcHNnNjI3SmNicE9iR1poZG1p?= =?utf-8?B?UnJFdGthQ3k1dTNNeHhpZEZDVlFNbzNVUUgraldGa09yMjdKTjZTZGNibXJC?= =?utf-8?B?eXMxR0NUcGphakovODJHQjZIblg4YWlOUjJlNS94bVBmQUQvdVJnQ1dxRUhR?= =?utf-8?B?V0REcWNtME5MT0NjclhZazE4WVYyRnEzcCsrbmY0TG85NjY3YlhDMU8vRWY5?= =?utf-8?B?TFBtZjgrTUFIUG9ETUFqMlNiR1U3TEdRbWtWakVWaXljWmJodW9lS1N5NVRm?= =?utf-8?B?R2pveVprRjJmcGRSUDM4RnVmS1F5a2padTl0U0NCWjhMOG9DSVVEd1J5MUVx?= =?utf-8?B?YklqNllMem0xaEZRR1JBc1diV3p0QUNkWnRpMnBBMUlVdFhiai90aFkzZVJk?= =?utf-8?B?SGRmTlJJc3FpcXBwNVJ4UWkxRGxjZzBjd0ZPS2Z1QkVNWFNocmFoL3hwQ0wr?= =?utf-8?B?OVEzaDJXVzhnRFVvcUFCR2JnNy9NcEUzVkUzSFdRZHBDeWhKVmJxRHltTzVk?= =?utf-8?B?U1l4MEYrUVc3T2c5bU0wQUZPVzFUYXRjeUFCd1hSOWgxNGhJMmpiV3ZhZHYr?= =?utf-8?B?TjluMnF1VDFVeDRoandmWnRmN0MxZGY2eDAvVEU4WWVKZkhXRGdiV1dDY1BF?= =?utf-8?B?cU9vZzNaT2FGSzFNNmtFQ3lxT2U3d0o4VFdPdUZTQmNYWGhhT1BkRUtvWjFM?= =?utf-8?B?ZXMvdDVrTTZGa0VKQU1GVDdGck9WN3UyNEdQeUJQUmZXS2FCU0I5ZlpiQjFj?= =?utf-8?B?a2Z6TlNkeU4rc0pHL1g0V21wTGl5RFpKclBYTjNCZ0U5c1lnWjVRQkY3cVA0?= =?utf-8?B?UW5tajZpZHY0M3cvR3dPc3RDZy9LdXFMUXhwNnUybnpyQkp5OW5qM1Jncnk0?= =?utf-8?B?TVlMbGMvZ1E3QjEwZWJ1NWEySFJ5clRDWnpDV2R0RGVraFptNDA3RldLeE93?= =?utf-8?B?QmE4YkJxM1c4aDRzVXpsbi9kMkNKN0dnaHBaYWRVV3AyY1NnWHdCS2IyOWdM?= =?utf-8?B?OVB6MSsxQmpxZ1kxUjlqM2dwS3RKU2lPMWFPZnlsK245ZmJoNmZuY0g5Njh0?= =?utf-8?Q?fOCoYYHI48ALwVbNOuftyNfwN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8af6f497-578c-4401-fc86-08db94af1d69 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 05:53:23.8333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bocY0SbTuyEGcz22zlzefh3qCA/CtA0v1zFEvOcU/g3Qp8eeo0XfiuSVVd7mSv81Bgu2gRR2xjgWh7MaC6+ihw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB10073 On 03.08.2023 18:13, Elliott Mitchell wrote: > On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: >> >> Some of the patches looks to have been posted previously as a 7-patch >> series. It would have been nice if therefore this one was marked as >> v2, indicating in a revision log what the differences are. It appears >> as if at least one out of those 7 earlier patches was dropped (or >> maybe assimilated into another one). > > Indeed. Problem is several tags could potentially have been used. > Should I have used all of them simultaneously? Should I have used only > some of them? Which subset? > > Several were mildly adjusted, so it could have been marked "v2". > > No one responded at all to the previous round, so this could have been > marked "RESEND". > > Yet the refinements and general changes are large enough for the series > to be pretty distinct. > > I didn't know which way to go, so with no idea which option to choose the > last one ended up winning out. Perhaps that was wrong yet I've still no > feedback on the actual patches. As, for this series, being just in the role of a committer, without clearly identifying that some earlier patches can now be dropped from the list of things which need monitoring, you're making my (in that regard) supposedly purely mechanical job harder (and presumably every other committer's as well). As to not getting feedback: Your posting (at least the cover letter) dates back to July 19. That's not all that long compared to other series. Plus if you were concerned, you could have pinged the respective maintainers. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 05:58:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 05:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576826.903400 (Exim 4.92) (envelope-from ) id 1qRnpW-0002Bd-VI; Fri, 04 Aug 2023 05:58:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576826.903400; Fri, 04 Aug 2023 05:58:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnpW-0002BW-Qe; Fri, 04 Aug 2023 05:58:30 +0000 Received: by outflank-mailman (input) for mailman id 576826; Fri, 04 Aug 2023 05:58:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnpV-0002BP-Il for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 05:58:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20615.outbound.protection.outlook.com [2a01:111:f400:7e1a::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed9df163-328b-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 07:58:26 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8302.eurprd04.prod.outlook.com (2603:10a6:102:1ca::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Fri, 4 Aug 2023 05:58:23 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 05:58:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed9df163-328b-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfSj3zzos0U0BDsmFMgW155JOtqOPGpEkUI5cVOsRyIbipQjGH9NtBSCkJ03w9J9hf2avhDMZ6HPTP+WWTE+AO6Ivx9UykWdUw8CQg7OuUTUS1DPeptlLKcMhfPUepbOdrh0mAo/90VetAS9LwdHgfPHOv7ykIEoesaO6IKaKG5O6W9OaTWDOqj4VH3a9JF8/AEE4WFnEIgok+SzdhsOztj658zmYJdqOuCPkDuouHkiBKfpZYezqKHROMsMaimy3QkpqoFwe2Jq67PL0mgV60yDJiVhXCnFOPy6Zng/DfGbhwX4orSY0CGKkqSXuf8N3ZCsXLhEfqof6XOC7lbZHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GWGvK5YPHXrng9atAY5AiFGKlI+n927P1PkwtxN6LTc=; b=Q1sdczgXC0zWnNpU48HhBNE+IEjmQ3NmVNLidmtv622lwIK1G6f8v4ELAr+1SQEfnaItcynIemtpLDBZL1voTFtxa/tBw6tJcugA+f6uLAkfUzjhaSqUsH+/4MOBRmCCqJz53vJYx47iPYrVrFemf9ngv3rNPysUDSQWek9OUdCGriEZPARwV622CUT+7ihBoZx79Drnq67eeemgT85/Bm6lFhZCzH9+2SyLvJTvyauhTfXmRkDSln6dUxe8uOnj6nbLz0VxrYEnuT1nkaN9CaPwSJnE82md4BwNMsXEYYAo3ohsOQkaab09BSC6CSKUF8AVgZSHccVTmKmqUnOvYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GWGvK5YPHXrng9atAY5AiFGKlI+n927P1PkwtxN6LTc=; b=oB1QiqmTc9COXV0LgKxgkQRGn995HoAT0gEew0eFjqkM7dS0RsApWhAnXxkAQPTGHyHr21cXWjRxMdOKNxK4zlU7KSiR/0GMBnv2IPYLQQx1eEKnbo1BrvWKP8WRxR1LzligWFVbLWymBsDfuBk7P8/mWObv5WQxx8hhYtJaa+yQBp7ZnI0GwTtp69/FW4rnQbFjKwkudvcxQH2wgR4EH+5aLob52vqaGX44gxbGrh01YQDk5GzER2WSFJCTF0B0pXo7Iw9YD2XF4jXWeLpRwozvM/h7C0W+jdB1vtEmeHdaasi9LPPLp22qd4zApwHJyaubnjUtfnldKIVwoWBVgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2e81cf29-65fd-74fc-db4f-95c453acc327@suse.com> Date: Fri, 4 Aug 2023 07:58:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 From: Jan Beulich Subject: [PATCH v3] x86emul: further correct 64-bit mode zero count repeated string insn handling To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8302:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e7e4dda-d52c-4a67-4aa5-08db94afd02d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dgd6Iwqg21VuaIzpHpEaU5DJQXhejNItHVdtBPOtCNpVF2DrQrGIila4YJ4ccpokTojVfZ8VTOaej0DJBb0vWY7fLv1VRKUy8l8LUx+K7NmM42AbsAwWYcWDiAGbNJ6rHFGHvM8e1+ZHZbCY9PVMvBIuYc6z58JyOGSBf3ob78E0/w+k7p2dAiiuhwvQh1rwt1msFZ3aVXF3kbyAbOiGyVCzqMSq4KiZymC+3P1vjmvCE/rrHAa/+BUDBNf7fvLUX2/g0FQpbkIo/8GhrcubzchH0siPoqvdMA/uUwDgg8cXAOA6x8whwlCrZywXV+tXSvvrRB5OCAUtZZlCJENN0msTi6XwKhi+n+7XUQV1T/YznLNuhAFmMu9QXIFlKb6Tud81mRNSGx9Su9VH5m/l8ZLHvURWgP/bHXyeJ5w4kD14G9vXkE6G304NJv0GkXUvouuGw1QfcAlhz3N5iQD9ssEwNFW0C3k7C2Dbrxdr3oOOi8jrL2NbPAKOQpOOvi7aFu8w9rezKoWfFl2EIOUgmHbPHvE0EdNGPvpaKx7S1kNNLOAqzm16h76kd0IrW3Zy5YhLWELJhnfrrkTau1Dca85PfRKitWtHZHyS38B6wMGu1HxKqFaJVQdxhyfSRR/JqVUeOC5BeziChh9AKlTk5w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(396003)(366004)(376002)(136003)(451199021)(1800799003)(186006)(86362001)(478600001)(2616005)(54906003)(36756003)(6512007)(316002)(26005)(66946007)(66556008)(6916009)(66476007)(38100700002)(6486002)(4326008)(31696002)(6506007)(41300700001)(8936002)(8676002)(31686004)(83380400001)(5660300002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVJacjlCNk95NHlvdFhKT0F3Q0VpcjhKVzhDUFJiRzRoY0pNQ2tpOHl5aTFq?= =?utf-8?B?YlBhbGF0eUt3OFZ4VzlkZXpNeUZVVTJLZHR2S1dndi9mbHZNYmdVTncwRTFh?= =?utf-8?B?RnkyN2htUnNqY3VaNGlFblNoRUxBYUxNeEhjb2IzTzRaUFZLVWZxcUkzVi9u?= =?utf-8?B?Y2tWSUNIV2MveXNEU3A3bE1RZ3lNUFByZFBDaStNSWVrMFlrc08xRisvVDFG?= =?utf-8?B?Y3pkYS92RCtWdVZtWkVzSTBKN2VvMGFucllKQVZsNmdNdFB0ZUpkR00vNlNL?= =?utf-8?B?aStXRkNwNFJ0eU9JSE8xcmJrOUs0bDlZNnlUYWpKMFNDYU94aHFkK0dNcVhS?= =?utf-8?B?QjNPdTdYYngrREZOSkpmWlJhUFNOamt0RDVha1MwNVYyRXhHenE1YXE2a0V1?= =?utf-8?B?WFJwMkNXd3BvY2ovMlZrNGhPTlZzOVM3UklXc2VkbmRpRU5kc3ZBZDRQM3po?= =?utf-8?B?L2NPTW92NnVKRThTSEdwamR6UmlTRnRKWFZQY3Y0WlZFV3hZYW0rYzFBYm4w?= =?utf-8?B?UHh2RG5ycUdiMVQwbGZzWndnaFFiYm5OME90aWppN2dmTnVkMGxYUTlSTnRR?= =?utf-8?B?VGhCMU5kQVdvSkdaMU1zMFdSc1lCRG1FMTgrSThmYnBpakUwS0ZxSFJiN1F1?= =?utf-8?B?dVhtYkVtc3VOQmZZaldqZm1WNW1RMm9vQzhxbFNLSGlRMURDMjdaT1k4L2VU?= =?utf-8?B?Q1BybytTam5qYy9RQnR0NzFsLzNWMnpETWkwcTl0SE8waDBRV3RteFQ5SlNw?= =?utf-8?B?NWo5V0w5L2VMUUNGZGZWWWtHa3RKT1I3dXhQUkFkNGxWL0tDYWlvT3B0VWtB?= =?utf-8?B?aFZBSmFnQ2dja3hTb05qU09vd3BCYVlrdmFKcXV2SGcwN0E4QXdYRmNSNW1t?= =?utf-8?B?RkNOSnFIU3NHaTNZN2lNc2lYbVBiLzNlNXJSYVRST2llTTJTcHc5cmNUUnVD?= =?utf-8?B?VG5yYWtERFlZbmxqaUpuRlF4L1lsRDhmWGxubXZNcFFFTFcxVDVPOGJ4N01o?= =?utf-8?B?RWlFVytLaUtMN2J5dnNkaE1EcDZRVG8zblpaQmYrOXErYXNpM0R5eXhraVFJ?= =?utf-8?B?Zmt6c2gveWlyM2QxY0FwdDRObFhhZWxnWnY5SHlEOC90R1hScjkrVXkzbGdt?= =?utf-8?B?NXd4ZUQ5QS9yUFJyQkRwOFNMR1l4UU5OKzVKeVQ4RTVLTkUyS3I5YnZWdVMr?= =?utf-8?B?N3BFSWIzVGRIRXBHWlg0V3didG5kZDVkOEFBdTBoZXhxMFVXaXFyVXY2Q3F1?= =?utf-8?B?bnZxUUFONzFzVzlvbHdmQmFCNDJlaFlBZkl1TVNDK21TNlhBYzR0UmEvTnNX?= =?utf-8?B?R0pPNkgvTE1wbTM1NlErNGE5d0NMSEQ4RmdrTHJsN1czSTBnbDFkSjBQb296?= =?utf-8?B?L3RZWDQyUG9QWnUvZ2kxNmk5VWo4ZjkvcVFNMnowNHorOXZJYm41YlZoZUk3?= =?utf-8?B?YTVrMlZ2aDJsSGt4dk4wTWhrWGJLeXRETDQ4MEQ0ZThIa1NITXZTcDZ5OUtx?= =?utf-8?B?L1dTRHBBelNRZXFkQ1k2aWNhcGh1NFh4OTliVVBzQ2kzR1pDclBhcUhTK3VR?= =?utf-8?B?Q2djZHpyYitEa09xTXNNODFjOTZqRExiS1BtaGo2Z2Z1UHdWcXFEYWkwYWRL?= =?utf-8?B?b1lNSmJOQk1UWGdmOExnNFIydWpOTm9QUnlmY29ESGdYbzZxU2p5SnM4cWZZ?= =?utf-8?B?U1FFZlRvQUtWVnpBdVVYUjZ3TkRQYTcwV29SQjJlV3pjc3N4TTBkb0VJZ1hK?= =?utf-8?B?QUI5OGdrY0hwTVZxR3RMTmRsNG5lSkxyc1IwdVljUE9ndGNCUCtOOTFZUm1x?= =?utf-8?B?bG1MOTFpU1g5TXNUZ0M5TlZPRnRkbEtZYmdZSXpKaUJwZkVURjZFc1pRaWVJ?= =?utf-8?B?L1NlTnlvOEJWVTFLbXRFRlFsUmZhREdVc1M5ZnRWWncrdW9kL0Y5SmRZMkhM?= =?utf-8?B?cEpYZkF5aFEzYjhVVUo5Tk03NngyNmdGSFI3djRiMThrR09QK2pVckNjazRF?= =?utf-8?B?QzBnNDdRMXo5bnViR3ZaaFFxY2JXOE5rMHNHb0MwWDBySExpMVhqR3dnQklY?= =?utf-8?B?WnZqdUdHQndqbVV4OUR1WHg2b3dVM3FISjc4UXJWWjhBVUhpMU9UUGtub1dU?= =?utf-8?Q?8Zg6Qilev+pqvUSzfFH/yuGE2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e7e4dda-d52c-4a67-4aa5-08db94afd02d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 05:58:23.7231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: buK9IqSUBMKcr3tWQWRHS7rE3v5k4gEa706jTlg/3JsgLUT3mhZbdVb6EMNLd1lzlogAMCwTZwjmIYCU8ZLhPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8302 In an entirely different context I came across Linux commit 428e3d08574b ("KVM: x86: Fix zero iterations REP-string"), which points out that we're still doing things wrong: For one, there's no zero-extension at all on AMD. And then while RCX is zero-extended from 32 bits uniformly for all string instructions on newer hardware, RSI/RDI are only for MOVS and STOS on the systems I have access to. (On an old family 0xf system I've further found that for REP LODS even RCX is not zero-extended.) Fixes: 79e996a89f69 ("x86emul: correct 64-bit mode repeated string insn handling with zero count") Signed-off-by: Jan Beulich --- Partly RFC for none of this being documented anywhere (and it partly being model specific); inquiry pending. If I was asked, I would have claimed to have tested all string insns and for both vendors back at the time. But pretty clearly I didn't, and instead I did derive uniform behavior from just the MOVS and STOS observations on just Intel hardware; I'm sorry for that. --- v3: Re-base. v2: Re-base over re-ordering against previously 2nd patch in a series. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -489,7 +489,7 @@ static inline void put_loop_count( regs->r(cx) = ad_bytes == 4 ? (uint32_t)count : count; } -#define get_rep_prefix(using_si, using_di) ({ \ +#define get_rep_prefix(extend_si, extend_di) ({ \ unsigned long max_reps = 1; \ if ( rep_prefix() ) \ max_reps = get_loop_count(&_regs, ad_bytes); \ @@ -497,14 +497,14 @@ static inline void put_loop_count( { \ /* \ * Skip the instruction if no repetitions are required, but \ - * zero extend involved registers first when using 32-bit \ + * zero extend relevant registers first when using 32-bit \ * addressing in 64-bit mode. \ */ \ - if ( mode_64bit() && ad_bytes == 4 ) \ + if ( !amd_like(ctxt) && mode_64bit() && ad_bytes == 4 ) \ { \ _regs.r(cx) = 0; \ - if ( using_si ) _regs.r(si) = (uint32_t)_regs.r(si); \ - if ( using_di ) _regs.r(di) = (uint32_t)_regs.r(di); \ + if ( extend_si ) _regs.r(si) = (uint32_t)_regs.r(si); \ + if ( extend_di ) _regs.r(di) = (uint32_t)_regs.r(di); \ } \ goto complete_insn; \ } \ @@ -1775,7 +1775,7 @@ x86_emulate( dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes; if ( (rc = ioport_access_check(port, dst.bytes, ctxt, ops)) != 0 ) goto done; - nr_reps = get_rep_prefix(false, true); + nr_reps = get_rep_prefix(false, false); dst.mem.off = truncate_ea_and_reps(_regs.r(di), nr_reps, dst.bytes); dst.mem.seg = x86_seg_es; /* Try the presumably most efficient approach first. */ @@ -1817,7 +1817,7 @@ x86_emulate( dst.bytes = !(b & 1) ? 1 : (op_bytes == 8) ? 4 : op_bytes; if ( (rc = ioport_access_check(port, dst.bytes, ctxt, ops)) != 0 ) goto done; - nr_reps = get_rep_prefix(true, false); + nr_reps = get_rep_prefix(false, false); ea.mem.off = truncate_ea_and_reps(_regs.r(si), nr_reps, dst.bytes); /* Try the presumably most efficient approach first. */ if ( !ops->rep_outs ) @@ -2154,7 +2154,7 @@ x86_emulate( case 0xa6 ... 0xa7: /* cmps */ { unsigned long next_eip = _regs.r(ip); - get_rep_prefix(true, true); + get_rep_prefix(false, false); src.bytes = dst.bytes = (d & ByteOp) ? 1 : op_bytes; if ( (rc = read_ulong(ea.mem.seg, truncate_ea(_regs.r(si)), &dst.val, dst.bytes, ctxt, ops)) || @@ -2196,7 +2196,7 @@ x86_emulate( } case 0xac ... 0xad: /* lods */ - get_rep_prefix(true, false); + get_rep_prefix(false, false); if ( (rc = read_ulong(ea.mem.seg, truncate_ea(_regs.r(si)), &dst.val, dst.bytes, ctxt, ops)) != 0 ) goto done; @@ -2207,7 +2207,7 @@ x86_emulate( case 0xae ... 0xaf: /* scas */ { unsigned long next_eip = _regs.r(ip); - get_rep_prefix(false, true); + get_rep_prefix(false, false); if ( (rc = read_ulong(x86_seg_es, truncate_ea(_regs.r(di)), &dst.val, src.bytes, ctxt, ops)) != 0 ) goto done; From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:00:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576831.903414 (Exim 4.92) (envelope-from ) id 1qRnrB-0003ke-M2; Fri, 04 Aug 2023 06:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576831.903414; Fri, 04 Aug 2023 06:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnrB-0003k0-Gy; Fri, 04 Aug 2023 06:00:13 +0000 Received: by outflank-mailman (input) for mailman id 576831; Fri, 04 Aug 2023 06:00:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnr1-0003E0-QN for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:00:03 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2722b34f-328c-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:00:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8E3CC2186B; Fri, 4 Aug 2023 06:00:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 52AE4133B5; Fri, 4 Aug 2023 06:00:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YNUZEuKTzGRbMQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 06:00:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2722b34f-328c-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691128802; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=H9woQQMc1BuLVL77pkVFJCk3edz6PGqB1F1anOaKa7M=; b=mgtytCg4Ea9KWviQrhfXSYbhCqk3gPGhKKydVEWMNNFUCK1gS9cP6QEgrgaCY758DMcmJ2 uZzgxAXEXDNRas7ImAG56Qbz6GY+XRjDfmqyJNn/IpmA+XjirHc4E9VQeCCJ3u1L3jYSEH KIX5yYa31sgOXawpgO0l8nKXY63x0yY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 0/2] tools: add some more configure options Date: Fri, 4 Aug 2023 07:59:58 +0200 Message-Id: <20230804060000.27710-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add two additional configure options for controlling the build of pygrub and libfsimage. Juergen Gross (2): tools: add configure option for disabling pygrub tools: add configure option for libfsimage config/Tools.mk.in | 2 ++ tools/Makefile | 4 ++-- tools/configure | 54 ++++++++++++++++++++++++++++++++++++++++++++++ tools/configure.ac | 14 ++++++++++++ 4 files changed, 72 insertions(+), 2 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:00:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576830.903409 (Exim 4.92) (envelope-from ) id 1qRnrB-0003iQ-Ct; Fri, 04 Aug 2023 06:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576830.903409; Fri, 04 Aug 2023 06:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnrB-0003iH-A9; Fri, 04 Aug 2023 06:00:13 +0000 Received: by outflank-mailman (input) for mailman id 576830; Fri, 04 Aug 2023 06:00:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnr7-0003E0-Fo for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:00:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ab71d6d-328c-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:00:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5AA821870; Fri, 4 Aug 2023 06:00:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9CDF3133B5; Fri, 4 Aug 2023 06:00:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0dv3JOiTzGRwMQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 06:00:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ab71d6d-328c-11ee-b26a-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691128808; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3lY3SIuVkWF2aYitFeP1w+X45FAECaznTjuW2uDVbFM=; b=tWqmlujgIyMbifW6nkPJCknlhHCYxlY1bE7VXSC1Opgp+ckF2QA5RAB9//kvLkFnY1krmD V6eIJZj8JWchrvjfoTBMxjWQZWJh0bcVkjMubDqIFeok2KP9VAaWyM+qvbKM6Ijac943tF JcR8V4+dMHRz4jIu7EZSyRrF7LvNMns= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 1/2] tools: add configure option for disabling pygrub Date: Fri, 4 Aug 2023 07:59:59 +0200 Message-Id: <20230804060000.27710-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230804060000.27710-1-jgross@suse.com> References: <20230804060000.27710-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a "--disable-pygrub" option for being able to disable the build and installation of pygrub. There are two main reasons to do so: - A main reason to use pygrub is to allow a PV guest to choose its bitness (32- or 64-bit). Pygrub allows that by looking into the boot image and to start the guest in the correct mode depending on the kernel selected. With 32-bit PV guests being deprecated and the possibility to even build a hypervisor without 32-bit PV support, this use case is gone for at least some configurations. - Pygrub is running in dom0 with root privileges. As it is operating on guest controlled data (the boot image) and taking decisions based on this data, there is a possible security issue. Not being possible to use pygrub is thus a step towards more security. Default is still to build and install pygrub. Signed-off-by: Juergen Gross --- config/Tools.mk.in | 1 + tools/Makefile | 2 +- tools/configure | 26 ++++++++++++++++++++++++++ tools/configure.ac | 1 + 4 files changed, 29 insertions(+), 1 deletion(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index b7cc2961d8..432d7496f1 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -48,6 +48,7 @@ CONFIG_QEMU_XEN := @qemu_xen@ CONFIG_QEMUU_EXTRA_ARGS:= @EXTRA_QEMUU_CONFIGURE_ARGS@ CONFIG_LIBNL := @libnl@ CONFIG_GOLANG := @golang@ +CONFIG_PYGRUB := @pygrub@ CONFIG_SYSTEMD := @systemd@ SYSTEMD_CFLAGS := @SYSTEMD_CFLAGS@ diff --git a/tools/Makefile b/tools/Makefile index 1ff90ddfa0..bbd75ebc1a 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -36,7 +36,7 @@ SUBDIRS-$(CONFIG_X86) += debugger SUBDIRS-$(CONFIG_TESTS) += tests SUBDIRS-y += python -SUBDIRS-y += pygrub +SUBDIRS-$(CONFIG_PYGRUB) += pygrub SUBDIRS-$(OCAML_TOOLS) += ocaml ifeq ($(CONFIG_RUMP),y) diff --git a/tools/configure b/tools/configure index 52b4717d01..130e0d9abf 100755 --- a/tools/configure +++ b/tools/configure @@ -707,6 +707,7 @@ AS86 ipxe qemu_traditional LINUX_BACKEND_MODULES +pygrub golang seabios ovmf @@ -811,6 +812,7 @@ enable_xsmpolicy enable_ovmf enable_seabios enable_golang +enable_pygrub with_linux_backend_modules enable_qemu_traditional enable_ipxe @@ -1498,6 +1500,7 @@ Optional Features: --enable-ovmf Enable OVMF (default is DISABLED) --disable-seabios Disable SeaBIOS (default is ENABLED) --disable-golang Disable Go tools (default is ENABLED) + --disable-pygrub Disable pygrub (default is ENABLED) --enable-qemu-traditional Enable qemu traditional device model, (DEFAULT is off) @@ -4287,6 +4290,29 @@ golang=$ax_cv_golang +# Check whether --enable-pygrub was given. +if test "${enable_pygrub+set}" = set; then : + enableval=$enable_pygrub; +fi + + +if test "x$enable_pygrub" = "xno"; then : + + ax_cv_pygrub="n" + +elif test "x$enable_pygrub" = "xyes"; then : + + ax_cv_pygrub="y" + +elif test -z $ax_cv_pygrub; then : + + ax_cv_pygrub="y" + +fi +pygrub=$ax_cv_pygrub + + + # Check whether --with-linux-backend-modules was given. if test "${with_linux_backend_modules+set}" = set; then : diff --git a/tools/configure.ac b/tools/configure.ac index 3cccf41960..9947bcefc6 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -89,6 +89,7 @@ AX_ARG_DEFAULT_ENABLE([xsmpolicy], [Disable XSM policy compilation]) AX_ARG_DEFAULT_DISABLE([ovmf], [Enable OVMF]) AX_ARG_DEFAULT_ENABLE([seabios], [Disable SeaBIOS]) AX_ARG_DEFAULT_ENABLE([golang], [Disable Go tools]) +AX_ARG_DEFAULT_ENABLE([pygrub], [Disable pygrub]) AC_ARG_WITH([linux-backend-modules], AS_HELP_STRING([--with-linux-backend-modules="mod1 mod2"], -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:00:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:00:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576832.903429 (Exim 4.92) (envelope-from ) id 1qRnrG-0004FW-SI; Fri, 04 Aug 2023 06:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576832.903429; Fri, 04 Aug 2023 06:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnrG-0004FP-PG; Fri, 04 Aug 2023 06:00:18 +0000 Received: by outflank-mailman (input) for mailman id 576832; Fri, 04 Aug 2023 06:00:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnrF-0004DM-6L for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:00:17 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e52605d-328c-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 08:00:15 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C926E1F8A3; Fri, 4 Aug 2023 06:00:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1202133B5; Fri, 4 Aug 2023 06:00:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lr/uJe6TzGR8MQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 06:00:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e52605d-328c-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691128814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EzluZzjBGFWytrE7XLiRjbQBObqzhDXzMAFkA/Hykgo=; b=TitJxUkm236pFFRaEFGa6ewz80M0Tq1NoRvoD47zqt+1lKPnokiSyoH+DIwGo14WBlBAKr s9EfqNHRpgUs75VPa8WTz3mitH6K4hsP6AAxmbo9gvXq2w0vkQSAffp8ko4PFcITPmPhbc /NNizLNHdkrQlrCUTZW5nPJ7DLf/Y10= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 2/2] tools: add configure option for libfsimage Date: Fri, 4 Aug 2023 08:00:00 +0200 Message-Id: <20230804060000.27710-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230804060000.27710-1-jgross@suse.com> References: <20230804060000.27710-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The only in-tree user of libfsimage is pygrub. Now that it is possible to disable the build of pygrub, the same should be possible for libfsimage. Add an option for controlling the build of libfsimage. The default is on if pygrub is being built, and off if it isn't. Without pygrub the build of libfsimage can be enabled via --enable-libfsimage. Signed-off-by: Juergen Gross --- config/Tools.mk.in | 1 + tools/Makefile | 2 +- tools/configure | 28 ++++++++++++++++++++++++++++ tools/configure.ac | 13 +++++++++++++ 4 files changed, 43 insertions(+), 1 deletion(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 432d7496f1..b54ab21f96 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -49,6 +49,7 @@ CONFIG_QEMUU_EXTRA_ARGS:= @EXTRA_QEMUU_CONFIGURE_ARGS@ CONFIG_LIBNL := @libnl@ CONFIG_GOLANG := @golang@ CONFIG_PYGRUB := @pygrub@ +CONFIG_LIBFSIMAGE := @libfsimage@ CONFIG_SYSTEMD := @systemd@ SYSTEMD_CFLAGS := @SYSTEMD_CFLAGS@ diff --git a/tools/Makefile b/tools/Makefile index bbd75ebc1a..311a9098d7 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -18,7 +18,7 @@ SUBDIRS-$(CONFIG_X86) += firmware SUBDIRS-y += console SUBDIRS-y += xenmon SUBDIRS-$(XENSTAT_XENTOP) += xentop -SUBDIRS-y += libfsimage +SUBDIRS-$(CONFIG_LIBFSIMAGE) += libfsimage SUBDIRS-$(CONFIG_Linux) += vchan # do not recurse in to a dir we are about to delete diff --git a/tools/configure b/tools/configure index 130e0d9abf..60dca366ca 100755 --- a/tools/configure +++ b/tools/configure @@ -700,6 +700,7 @@ EXTRA_QEMUU_CONFIGURE_ARGS qemu_xen_systemd qemu_xen_path qemu_xen +libfsimage rombios BCC LD86 @@ -818,6 +819,7 @@ enable_qemu_traditional enable_ipxe with_system_ipxe enable_rombios +enable_libfsimage with_system_qemu with_stubdom_qmp_proxy with_system_seabios @@ -1508,6 +1510,8 @@ Optional Features: --with-system-ipxe) --enable-rombios Enable ROMBIOS, (DEFAULT is on if qemu-traditional or ipxe is enabled, otherwise off) + --enable-libfsimage Enable libfsimage, (DEFAULT is on if pygrub is + enabled, otherwise off) --enable-systemd Enable systemd support (default is DISABLED) --enable-9pfs Explicitly enable 9pfs support in QEMU build (default is to defer to QEMU configure default) @@ -4621,6 +4625,30 @@ else fi +# Check whether --enable-libfsimage was given. +if test "${enable_libfsimage+set}" = set; then : + enableval=$enable_libfsimage; +else + + if test "x$enable_pygrub" = "xno"; then : + + enable_libfsimage="no" + +else + + enable_libfsimage="yes" + +fi + +fi + +if test "x$enable_libfsimage" = "xyes"; then : + libfsimage=y +else + libfsimage=n +fi + + # Check whether --with-system-qemu was given. if test "${with_system_qemu+set}" = set; then : diff --git a/tools/configure.ac b/tools/configure.ac index 9947bcefc6..aea24eb982 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -185,6 +185,19 @@ AS_IF([test "x$enable_rombios" = "xyes"], [ ]) AC_SUBST(rombios) +AC_ARG_ENABLE([libfsimage], + AS_HELP_STRING([--enable-libfsimage], + [Enable libfsimage, (DEFAULT is on if pygrub is enabled, + otherwise off)]),,[ + AS_IF([test "x$enable_pygrub" = "xno"], [ + enable_libfsimage="no" + ], [ + enable_libfsimage="yes" + ]) +]) +AS_IF([test "x$enable_libfsimage" = "xyes"], [libfsimage=y], [libfsimage=n]) +AC_SUBST(libfsimage) + AC_ARG_WITH([system-qemu], AS_HELP_STRING([--with-system-qemu@<:@=PATH@:>@], [Use system supplied qemu PATH or qemu (taken from $PATH) as qemu-xen -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:07:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:07:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576842.903439 (Exim 4.92) (envelope-from ) id 1qRnxr-0005Rp-In; Fri, 04 Aug 2023 06:07:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576842.903439; Fri, 04 Aug 2023 06:07:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnxr-0005Ri-G0; Fri, 04 Aug 2023 06:07:07 +0000 Received: by outflank-mailman (input) for mailman id 576842; Fri, 04 Aug 2023 06:07:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnxq-0005Rc-Cl for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:07:06 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060b.outbound.protection.outlook.com [2a01:111:f400:fe13::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 224a9e8f-328d-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 08:07:04 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9277.eurprd04.prod.outlook.com (2603:10a6:102:2b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 06:07:01 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:07:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 224a9e8f-328d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/s+6W0kHDRSmGVoUlJaM32zBLYfTiCmlpDVYgWTXSBIBz9wdg8/QGb5qg2ZHUzGHSuKFbk6A+bQGssvPqJSPwdf77sxDuZynrS3mbr71aqkdM+tC/0F5AyVgmoy8+WjC99QMAJf5Spm0KZdyqsT9VCGY5L/OULpeg16rgJY1WQZr+DcuGJrd6bHk6MARSa8puZWPWywlzJTGSuhwtNziIAnvR+fE3WOJlArb6XWkKuGkPLPW6xFGItXPDFGzKlQx+EAoQwhZvE0HD4fDxeFwN8AMKp4ERtOvK6xTZ+OpEU8+vmUlLFeJeHnvwboiLFWm6D3Mnb5r9RIzpm1aV67Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CXWkm7VfS37UWvnn3hIxvcHzcg4l3UHsgHHUoknNLiQ=; b=nxIc627Dt2ssjN069cSPFhUewrhfM7BT5IOFmPUUGmlLRTdxNH/A/nE5pAWSeBwo2DUWX20cCteassWjk2p0HGR5VIGgpxxVTU/E6FBFqJJ6Ko8XHryIG3NM+ZFABI4j0nCWUmr6pZdaL3O7Odap/pRxFc5yKE9Cn3Hzx3UWu+p71yyk7Yg1pW9OwRx2b6IjnOSRS6PjCzVKWV38IgT0+F70yb6IBEKIQ843n+ibyoOkQ+GE9nKFP5bRGaYtv77BxQuQBj6pIB5+IGElQOJsNmy6z/fx7l7rqMARpwZQPdn3LuMWOM1G+ZB0JsTTx4VK124GGOoIGjOrKHzRZICcVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CXWkm7VfS37UWvnn3hIxvcHzcg4l3UHsgHHUoknNLiQ=; b=NnwwYjXyTe0XmzRzSzeTqI8pWkkAA/qXEBBTxo66GQocLPrAzwk4wow5yYH6RHGKKCCjRhnpE6pTghxNOGIC0QyKWdC55OHsSpkK1O8QYsr2zx3WDQ6zgOxSI3LlA5Vd4IGFgvwN/q9h7E+2Z0CZSrQcncM1sf2JPPpiOBPRK+bpL35+7l6UkSg5812SvUX0YAKr7CHrvJ71kKNijM2X0ZrCw9e2MqEFQmCtRo/ekkGUGOD9dzgFE7U9ZW3bhnB91cwafeT/HfVsGH99Znt1F3ulmTUp+1XWtqoH6hSW9LAS3mLeHK9UOTcI5ir9q1B/U95e9sDpGekf4PPh1wQWpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> Date: Fri, 4 Aug 2023 08:06:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 From: Jan Beulich Subject: [PATCH v2 0/2] fixed width type adjustments To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9277:EE_ X-MS-Office365-Filtering-Correlation-Id: 7828c13e-ecda-4224-2940-08db94b104d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hqYgZnCg+Hn4YyQ749vYI1AEiq101CZVatrHc9QDAJkm/fC6cY3CYHkeIl9caosGD4Du2tsgYA2ixRqzkkxn8gfSfUgdlmZULFdakoVJQ/gaSh7tmwQJAHStBLPb8RsBaCcjXFpt5JMeTwJRkBsLIWIH9mAByx8DAaPwk9EZIJZXjUkIf5aSef0ZU/eVsn2Drm+RRkPyDsmNIHX13IJPctrgcPfI9eG3Gg+ndyfSwegkOOiuB9a/A8LZATzZhziy5A+Rm1YYDW76Wx/KbCSXnEglGNlza00X4BkKgFMeyOPgamCoLcf227asdx9rlbqwNik3T/2hfXB5RBaoO85BqFR5RRq+XtOdD7TUsl/LT8MpS32Qqf3k4h0yC6wLkqHBII8f0dzRZcMESQ/ggQdq9Pba8FPJOv2H0Td+OcjpPBLXGRKQrNBzOcAkDNz0oehW6CO+w8ogO2F0rGbF3SQzskSGQ1aHRc3UEhx+iK+LIJvdZJ8O+JRQQWWSPbZ981iQvDxibs0WCecbJMbfyg+rPeL1KujwCnZVD7BP3oBQHxOG4lPvoOc80qIjAEB7NiSHR3lyYUmbC3P4PaB6e+YUcCLMPmmEBFtW0xmlUvoayqtGxi/W9zbMb72FanKaZJarTCgm81sDZTvLQz8ZLLiSEA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(39860400002)(376002)(346002)(1800799003)(451199021)(186006)(2616005)(8676002)(26005)(6506007)(66476007)(2906002)(316002)(4326008)(66946007)(5660300002)(6916009)(66556008)(8936002)(7416002)(41300700001)(6666004)(6486002)(6512007)(478600001)(54906003)(38100700002)(31696002)(36756003)(558084003)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUZTMnNBUVJxOTRlYU9LTlppdHIvMHlrclk3L0lIcFoyNHl1aENqdFdWbjZJ?= =?utf-8?B?SXYrRk1YK0M0K3hXQUxxY2VUaldpbTJpbFdsbEMydkd3aG1CU2c5VWZLalBZ?= =?utf-8?B?OVZuZGVDcjR3WDhkYTRvMEJlQWhGaXZXK3IwaEVyc21DODZhK1RqeHFDZlVP?= =?utf-8?B?OVZBZm1ieTRVbndFYjkyUnVHTk8rM0YxeGhSY1p5cmppendYMlFXQ0RVVU5k?= =?utf-8?B?b0RaRmVBTVU0V1lQS3V6UTVvTkZNbkFrMkg0S2tpWTBsbFc2bVp1Z1F1elNs?= =?utf-8?B?UXNtb1R4RS9oVVJ1RGpQRkRKRXlVcFhYbkxZbmZaY3ZRUG03Nkk5Rlo5Yk1p?= =?utf-8?B?RkpUellOSFIzakpKRnAyRFdOOWxDV21CdzdnNmJTNW1DWTMxMWJQVFdXWnpz?= =?utf-8?B?K3E5K2pVNG1WanI3N3ZDd2FjdkE1ZSt6UkRsdXhBRUs0Uk9IakgwT2N1em9o?= =?utf-8?B?cnVPc0UvK2tleWZqT0c4a280MlNLeld1aW5ZeXVaMVliU2ZsZWxOaUsveHVC?= =?utf-8?B?aE5PR2VIVkdrOWlxK0RtYmhJZzhsb3FGWEMxSEI4S1A5dnVkSHZ6UnNhTWUx?= =?utf-8?B?QVRMU1AxMndlaEs3bVV1TTQ3Uy83NXZWTDYwalE0NTlud1NSSWZCeGh4SVV0?= =?utf-8?B?TURoN2ZBdXZOYWd2VjN2NnRWYmljSHFyMjZTTFhBd090WHo0Vjh0K3RmYjB0?= =?utf-8?B?bTNxR1IzNGhkL2JuTTNqOXNLMXNKT0RpWk55amwzOUJPakNpcUE3eXFka3hL?= =?utf-8?B?Y1pJTlpOQ1pURXNvZE9SbUptYWRRS1hXTFpycjg1cWhaTkp4dTF4R1Q0WkFD?= =?utf-8?B?enQ5ZUlDMnQxaWhkbSt4cCtXQzZzUmtNM0phVnB3UWdGZUE0RFFIUnhjMDZO?= =?utf-8?B?bWFIRkEvQkZnN3NGSnFadGI2dktTUGtLdklZVjQ4NktMdGhLZXROV1Z5Wm51?= =?utf-8?B?eUxkN2p6YjhRdjh0WjRVUzZtK3lYV3luY3VHQXBHbzhvOGxHTjhMNG9IbjR1?= =?utf-8?B?TG1IOWJOWlBVV3FCVThlVTlJdzJLWTBtcWtIOFNCZ1pCdFFvdkJWNzkxOUp4?= =?utf-8?B?OEtRdnFTN0wxTHRRRkU4ZlgxVXBIenNCQnUxL1Uzc2ZQcG5tVFdzazh6YVlD?= =?utf-8?B?U0oxbUJ6c0ZtRmJTSWVuYTVVdHZDQ3pqZTlFWmVHaDNzMjRXdGFSeFZna1JL?= =?utf-8?B?Zy8wUzBIL0k5ZU1ZelplbERiUzk3TTh1d1ZzOHNQWE0yYzdXV1ZVTnU1VzM5?= =?utf-8?B?anY4ZW4yaDU2Sy9JdFZNZVp5K2tKRXdKdDU0ZEUvNWF0eU5tN25Md1NNRE8v?= =?utf-8?B?RFpaWmRCNEZYcS9UKzRpa3N0SjRCeElrVUh2S3Z0OUhIUUs0T1JwTWp6Wm9P?= =?utf-8?B?bCs5Zi9kdzJyZUoyVU44b2xUY2R0blZpUDNoRVAvaEIxS1lKTXB4QWN2cVM2?= =?utf-8?B?R3JBTXF5c29lNkYrcFhYczM5WjNncFZzb3M2QU5jRE5WaWdiaG1GWURGU2U2?= =?utf-8?B?U3RZcEFJTWNWeWtUK2N5c3RDbWFSbzV0R3VxU0dlTEh0STdLS2xTYm80U1Zu?= =?utf-8?B?czYwQyt5YkRrdjFVMS9QZU5OQnZjaXc3ekxNdDNZRFUwd2hFY2dweTlLRnhY?= =?utf-8?B?L1V4dUVPdDIrVW1JNks4WXEzZ1hrRGtHVDdRcU82VWhOS0VpQWNyQnpHSEJQ?= =?utf-8?B?QklNeXVlcHNNa2QydTlheTlVTUUzdnpvSGJxVjhpOTFJQlUwMlIrS1hqTzN4?= =?utf-8?B?RjBiOWFqKzBwdEs0N3plajhtRWNwblI3elptMUJ3VFpGNjhrNHlUSjdTVHRa?= =?utf-8?B?OGF4eDRvTTdGZ2l3ZGJocXY1OE9JVWc3R2ltQlFYdUpyeERUVFdxZVRZaDUx?= =?utf-8?B?aFJDT1R1NWlQVmxZSGRxOUgwZnJlWFRoOXlJUEV4VElyQjAxTEV1NlJUdXJG?= =?utf-8?B?YjA4SVBoQitZYmpBcUNILy8rM25MMDlaWk5uRU5FTDNsZGpaUW9Lb3ZtbXZ0?= =?utf-8?B?VWVnSDlyTlg1V0ZtdEZMQld3VzZMcENBUWc5TnowQ3A4WWloR240dk5jeTRk?= =?utf-8?B?N0RtY05nTEVwdHlrck1tYlNpck9QU2FMeWVXQnR0N1NFbkdoUkQyMlgwWE9u?= =?utf-8?Q?/QkEysdaV80RZ/E6NxcsP9bni?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7828c13e-ecda-4224-2940-08db94b104d1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:07:01.5807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W9cUFaU/nGzHbVxz3qmQKC3586U9NWrjEF8q9+VUAJVqfFMV3IB6oFuvbxXSdUd0IcXw72LMu+qwQq9DQSV3tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9277 Patch 1 significantly reduced from Andrew's introduction of xen/stdint.h. 1: move Linux-inherited fixed width type decls to common header 2: __u8 is history Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:08:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:08:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576846.903449 (Exim 4.92) (envelope-from ) id 1qRnzC-0005zt-TZ; Fri, 04 Aug 2023 06:08:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576846.903449; Fri, 04 Aug 2023 06:08:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnzC-0005zm-Q8; Fri, 04 Aug 2023 06:08:30 +0000 Received: by outflank-mailman (input) for mailman id 576846; Fri, 04 Aug 2023 06:08:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnzB-0005ze-3k for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:08:29 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061a.outbound.protection.outlook.com [2a01:111:f400:fe13::61a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 541563b6-328d-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:08:28 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9277.eurprd04.prod.outlook.com (2603:10a6:102:2b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 06:08:26 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:08:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 541563b6-328d-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJkieJVClUbZuo7frihDEx3R3KUmhCzBKkL0k9bMRB41nR2Y91ENGmZTdwk3SwqkuioM4C+ZKt3D2r6U2uJanDgDkz9paIPAAS4ZsE0W+6B+W8/yrqrBKug1nzgX1zkW0j3Q7vnPsKW2aNDGKZ+lDzmaLtUuJ/zBoheyUGN3rfheM3Gvo6WCXMoBFAS6s7lo+GYrAJl4wdcN3/BImXl7HY6wREs8KQvhnFHY+MidUXtxivUUMECsJRpVHVktUEuKMmetK1pNU/rs51pg8I1TRCS5cCaeVgF8BkQSUW0V8Ne+6DzTBTcqEctYZIM0YnU3izGo/sE9kAdwh7BqX3sSFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cf6ROw1N7SDrNgirVisezrz+LJOsU87Fio6c0G9uOlc=; b=gxKje1uPdMp8oe+7XZRKFmRbJMzki1IXg+4pffnQ/6brrPMxyXqUuYXJFAv9FOJ8z+MPrHAFLyDV11tcBI6QNi5xtMQ9kQX6ta1TaNqLS9Q6GO3ATy+Iuu6kOup1Q3Aq7BQdMyw9NTquwtepi2JXhJziHqOUptDsjEWJY79VFYG+xPCYj5iTon4B+HwFt3yp02xXc7xEde71RfQ6j40iEipUNZlq9WDuw+wpMHFxN3IwwZ5XhKRxATtGf0N19uwy6i6USU1oSQU7edvNt2lD1esSEzm4xY920cMuY2cmiY6olyhddBpeUFo+Avd7xAGCS6SlA6EmKQMznpsNhpLi0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cf6ROw1N7SDrNgirVisezrz+LJOsU87Fio6c0G9uOlc=; b=2wF2+gAWWDW3lDGsScHjVG0HQ7Vi2xKHrj/xXr4h5EZUJ//0+XrPhsdonaOhfEBFU4ObLV6gvYuDhLUJaVT0O9ZB71c7LdA5Mmhd1tg9tzXlcRaeJpvLsO25y9plztEB1hJcy/PVQmuNekicqV+1UedV7nhRaQ24EffCQkjiUcK6xDy14coXGA46PcadazlT4Czm+97xlkooUKVhWneLwgKHUtoMM0DTcRwW/FmB4MrevW/5QgSn1Z2O2fwciakzboqFvNLQ0hguQOGmxFYqBI70wgRa9gjoIw6ZOk6QSxZ6TtLbvowezTIGS1o5GMaE65b2dp0hJPDorRrabwsIpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 08:08:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> In-Reply-To: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9277:EE_ X-MS-Office365-Filtering-Correlation-Id: 0256e4b0-3583-4741-b550-08db94b13765 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cN2NIV13AO3bVqdgqDW9LFGKx1Y/nGEXzYuaazpOuX9ogF5RD2Y8B1E4A9SQT221SVjpgOMH97iz/Th+eIi8FI+jIgEENc9ZNF0J9Z72SunJ5EkTWdA8BeDti1T0X5QrhQ7PzTkvMCBX/e+1ATxh70M55b/NSt+olkhoHKgQaN/fauFc30YqAC/4FHhz22gzx/Xm2xOd/b05y7W2nKdRw5CFy9lIjvV4xNOynuj1n4GBDI8IzdkZcHp2ZAAqcitTLI+WiQZr0FXI9Zokx+PDeLjgi2aY3Z4H0+4L2PRgFC4X8mfFl/6W/IHvo+Wstwg6pGBbMc/5tddfhP1iuSut2TV1Hw3AC0uf1PjpxiE62vpXSIy0UNPu0ePazRjWJ1uC2z2GMld8gTjk7MG6tOAHC3xqTx/H7TE227Y0x1NtF6cIAWPFkiR8OqzugYzqPpsA08FJZ++oU+Nsa5Oiy/bA6L0qWjQVPhzlbRJ4+RZIIw9+UaYumayqzz5d8mhDWiks3sFi/s545GFL1ij12jRq4F8BRJ4Qa6D5Bhgxf1pNxWFu8f0wUjm8PEcD0XhO2YXPUVjxhNEjLfqdoLqPh4ohe7ArX+3fBf9wX0JixroVVxcQ1RWrZn4336ggn0oKeVv4JloxKkv9yFEjz28doYUxmw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(39860400002)(376002)(346002)(1800799003)(451199021)(186006)(2616005)(8676002)(26005)(6506007)(83380400001)(66476007)(2906002)(316002)(4326008)(66946007)(5660300002)(6916009)(66556008)(8936002)(7416002)(41300700001)(6666004)(6486002)(6512007)(478600001)(54906003)(38100700002)(31696002)(36756003)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXlnL3FIMUpzdlBJVjYzdEpxVmxCQ3pZL2hZSnlvdENKUWkvcXp5MlFBSDNT?= =?utf-8?B?ZDF4cUhMUHRCRyt5NFRQVlp5TUlBeDJ0d0Z3V2x0bzZURzR0Y2JUUWJ2QUhM?= =?utf-8?B?aHhTNGhZT3FRc29aRHBqcWtwMkFQS0hhK2hQVldldHE5d2NBcmJMbTJqM1R6?= =?utf-8?B?UUNzN0d3elhIVm90akdNbmhIZ2Y5KzZkMEZxODBzQk15MU5QRmVTR0hNU282?= =?utf-8?B?WHh6ckdaS0tUT1U5ZStqdnhGSjMvY2JHc084T01NM3ZUQkRIaXE3N01PSnRl?= =?utf-8?B?Sk1QSXVpQnNQRVVzbFQzeEF0U24wRE5GcFIzenFKVWVzbTVaK0VKMGZQQ0Uy?= =?utf-8?B?eE9Ic2ZBalAwUEpiS1hFOVV2YUtzbTU3N3QwdlcyK1VTWDRsMGtYV3pDYmVm?= =?utf-8?B?QVZDUzdYdE5WbytPT2JTalZtVkJlQ3Y3TjdzS29nUzBjYnNReGx1dkZVeUlQ?= =?utf-8?B?QkgvOXNuaENVNmxjN2FQU05KdU9YU25jNEd5aEtOcnc4RllMWHdPb3BxeE91?= =?utf-8?B?dENxcG1VNHFqYURaenF4ajUyeDNBU2l4blYyNUdCK093MGdwVEdJMDRnUGp1?= =?utf-8?B?MG9jTjlUQ0xPbzF1UVNoajlXNjR2T21uNzQ4RDkvaG84MlBsdFFMNWgxT2NI?= =?utf-8?B?NE03WXd0am50cGEwTDRhY1pJVGRRUmdldWhXVWwwc2xEQTdyYzdSckRIY0Y5?= =?utf-8?B?TXdQT0pmRnRsSk5zWUsrZ2VLRHpQNUdGWUhTWkZVOVhUVnNMTlVOWFZXVysx?= =?utf-8?B?WVhUbHUyT2VKVEtsVXpoMWs3N2JkS25uTmVyVmdxemltZ1dOS1lndWdFU0gw?= =?utf-8?B?Y1VjRkcyUjVDWEMybWIzbzFRTzBXMVBVczJFbWZ5WjBhOXhsRk85TWFVQlRU?= =?utf-8?B?MEV6cDdkejhaOVFsSE9UTTRiOXB6aUg4UHZyVU5jMTBjamk4T3hkcGVkMG1J?= =?utf-8?B?NmJmeEkvSWk5L2k2dGVuNmp2TTF2L1IxbzNOT2RmSEhrTU0yb0hkbnU4R09K?= =?utf-8?B?VVZMTnk4MzcvdStCSURsNFAzMXNidE1DamdweFZrazZSVFpUWkZHN2ZRS1Jr?= =?utf-8?B?VFZxVnNDSzBFTjd5QVRtQjNiNXd2N0F5bFNoOW1rNXdXNmdOdjlQOTJweVVp?= =?utf-8?B?Y3hGLzg4a2VTWVpWdWhGeVNRdk5maldoTmdOMlVDVUQ0SVdoR3JJSHhXR3pl?= =?utf-8?B?d1ozQVBMeXNxQ25YM0ZYdFV2Z0srK0NpeERNYmt5RWVLVENSVjRDK2VpRjdp?= =?utf-8?B?em52VUowR0tYL1IzZ3JrMGduRFE5S0ZOa1JGNCtGcmRBN2Y3TURoQm4wK1hp?= =?utf-8?B?bmNubS9lR29nNkU0YzUxanZxSVBncHRPbEV1V3dLUmh4ZmlweVFZdTRCZkor?= =?utf-8?B?UjRKOThoZXE3eXFxeWE2TlVzRk41YlhWeWh6RmFNclMzZjZzaUtVOHR3cU10?= =?utf-8?B?K20zM0RWaEhEVGxWNmhUSGhzeDNFSlVYamZhaDdHc3hjYmo4WUFxY1NaWFhQ?= =?utf-8?B?aEtlOVpwRFVzMktpdU1pS0x5bitFcXJKV2VBRkkyanZjR1A4cUZSbmxxUEJT?= =?utf-8?B?N0J5dmJaUHpHbHhhZ296YWdoZ3hhT1RQZTdWN3lwakRwVm1SM1owbnBCSGt3?= =?utf-8?B?b1hlVzdpT2dmVXM2NDRseHJPRUd3WmlPeEtsc0VpbkFqTFlJdWtaKzZCV3NG?= =?utf-8?B?d0EzQVdOSW5aY0p3MVF2djM0T3RpMkdaTzM1TzJudXdTcnJjdVRFaDNkREpJ?= =?utf-8?B?STloSEN3eHkrV0NrVWVwbkJlVTlPbGJPSTFJbWlma1BiT3NzTjZFalo3RHA1?= =?utf-8?B?SnRhdlZBOFE1T1ZqWWQrRnhOdm1EVXgyRFM3b0VGcGNiQXk4M1ZXUzl0ZGw1?= =?utf-8?B?dHJaTm9JNnc0aENrdWc5WGx0LzQ2WndUOWFSUmV0SGk2bkF3bXVZOVIxRG4w?= =?utf-8?B?bE9FSzF2SWJ4Tml2bktBUVl3Z2ZRbXJpc3FZek9VcHU4UXVLSXJsYzVDQmw0?= =?utf-8?B?UlZkbGVYNHk3Q1BnY1RKMVlzVmROSkRKN3NQRC9FdXdST0pWNUVSTTFMZFE2?= =?utf-8?B?cHZlSXI3WkJndkEvZ2J5UjZRUFNDYW9aQVlzb0xiQzdMNUpwWS81RVVSelZY?= =?utf-8?Q?IWQdniOgnGIy6QLfFKqrAa50u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0256e4b0-3583-4741-b550-08db94b13765 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:08:26.3890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C3L8aJVwy++JCkCzTAcjbl9ITevmNNtfWf1yEpbIn7fhhOKclLze4n6FyqGjxOr/El4xc/k3eU84wJobD3yKRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9277 Have these in one place, for all architectures to use. Also use the C99 types as the "original" ones, and derive the Linux compatible ones (which we're trying to phase out). For __s, seeing that no uses exist anymore, move them to a new Linux compatibility header (as an act of precaution - as said, we don't have any uses of these types right now). In some Flask sources inclusion of asm/byteorder.h needs moving later. No functional change intended. Signed-off-by: Jan Beulich --- v2: This is the residual (extended to PPC) of an earlier larger patch which was partly replaced by introducing xen/stdint.h. --- a/xen/arch/arm/include/asm/types.h +++ b/xen/arch/arm/include/asm/types.h @@ -1,18 +1,7 @@ #ifndef __ARM_TYPES_H__ #define __ARM_TYPES_H__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - #if defined(CONFIG_ARM_32) -typedef signed long long s64; -typedef unsigned long long u64; typedef u32 vaddr_t; #define PRIvaddr PRIx32 #if defined(CONFIG_PHYS_ADDR_T_32) @@ -34,9 +23,9 @@ typedef u64 paddr_t; #endif typedef u32 register_t; #define PRIregister "08x" -#elif defined (CONFIG_ARM_64) -typedef signed long s64; -typedef unsigned long u64; + +#elif defined(CONFIG_ARM_64) + typedef u64 vaddr_t; #define PRIvaddr PRIx64 typedef u64 paddr_t; @@ -44,6 +33,7 @@ typedef u64 paddr_t; #define PRIpaddr "016lx" typedef u64 register_t; #define PRIregister "016lx" + #endif #endif /* __ARM_TYPES_H__ */ --- a/xen/arch/ppc/include/asm/types.h +++ b/xen/arch/ppc/include/asm/types.h @@ -3,17 +3,6 @@ #ifndef _ASM_PPC_TYPES_H #define _ASM_PPC_TYPES_H -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long s64; -typedef unsigned long u64; typedef unsigned long paddr_t; #define INVALID_PADDR (~0UL) #define PRIpaddr "016lx" --- a/xen/arch/riscv/include/asm/types.h +++ b/xen/arch/riscv/include/asm/types.h @@ -3,19 +3,8 @@ #ifndef __RISCV_TYPES_H__ #define __RISCV_TYPES_H__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - #if defined(CONFIG_RISCV_32) -typedef signed long long s64; -typedef unsigned long long u64; typedef u32 vaddr_t; #define PRIvaddr PRIx32 typedef u64 paddr_t; @@ -26,8 +15,6 @@ typedef u32 register_t; #elif defined (CONFIG_RISCV_64) -typedef signed long s64; -typedef unsigned long u64; typedef u64 vaddr_t; #define PRIvaddr PRIx64 typedef u64 paddr_t; --- a/xen/arch/x86/include/asm/types.h +++ b/xen/arch/x86/include/asm/types.h @@ -1,17 +1,6 @@ #ifndef __X86_TYPES_H__ #define __X86_TYPES_H__ -typedef signed char s8; -typedef unsigned char u8; - -typedef signed short s16; -typedef unsigned short u16; - -typedef signed int s32; -typedef unsigned int u32; - -typedef signed long s64; -typedef unsigned long u64; typedef unsigned long paddr_t; #define INVALID_PADDR (~0UL) #define PRIpaddr "016lx" --- /dev/null +++ b/xen/include/xen/linux-compat.h @@ -0,0 +1,19 @@ +/****************************************************************************** + * linux-compat.h + * + * Container for types and other definitions use in Linux (and hence in files + * we "steal" from there), but which shouldn't be used (anymore) in normal Xen + * files. + */ + +#ifndef __XEN_LINUX_COMPAT_H__ +#define __XEN_LINUX_COMPAT_H__ + +#include + +typedef int8_t __s8; +typedef int16_t __s16; +typedef int32_t __s32; +typedef int64_t __s64; + +#endif /* __XEN_LINUX_COMPAT_H__ */ --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -4,6 +4,16 @@ #include #include +/* Linux inherited types which are being phased out */ +typedef int8_t s8; +typedef uint8_t u8, __u8; +typedef int16_t s16; +typedef uint16_t u16, __u16; +typedef int32_t s32; +typedef uint32_t u32, __u32; +typedef int64_t s64; +typedef uint64_t u64, __u64; + #include typedef __SIZE_TYPE__ size_t; @@ -40,15 +50,6 @@ typedef __PTRDIFF_TYPE__ ptrdiff_t; #define LONG_MIN (-LONG_MAX - 1) #define ULONG_MAX (~0UL) -typedef uint8_t __u8; -typedef int8_t __s8; -typedef uint16_t __u16; -typedef int16_t __s16; -typedef uint32_t __u32; -typedef int32_t __s32; -typedef uint64_t __u64; -typedef int64_t __s64; - typedef __u16 __le16; typedef __u16 __be16; typedef __u32 __le32; --- a/xen/xsm/flask/ss/conditional.c +++ b/xen/xsm/flask/ss/conditional.c @@ -9,7 +9,6 @@ /* Ported to Xen 3.0, George Coker, */ -#include #include #include #include @@ -17,6 +16,8 @@ #include #include +#include + #include "security.h" #include "conditional.h" --- a/xen/xsm/flask/ss/ebitmap.c +++ b/xen/xsm/flask/ss/ebitmap.c @@ -10,12 +10,14 @@ /* Ported to Xen 3.0, George Coker, */ -#include #include #include #include #include #include + +#include + #include "ebitmap.h" #include "policydb.h" --- a/xen/xsm/flask/ss/policydb.c +++ b/xen/xsm/flask/ss/policydb.c @@ -22,12 +22,14 @@ /* Ported to Xen 3.0, George Coker, */ -#include #include #include #include #include #include + +#include + #include #include "security.h" From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:09:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576850.903459 (Exim 4.92) (envelope-from ) id 1qRnzm-0006Zl-9M; Fri, 04 Aug 2023 06:09:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576850.903459; Fri, 04 Aug 2023 06:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnzm-0006Ze-6F; Fri, 04 Aug 2023 06:09:06 +0000 Received: by outflank-mailman (input) for mailman id 576850; Fri, 04 Aug 2023 06:09:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRnzl-0005ze-Gw for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:09:05 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0601.outbound.protection.outlook.com [2a01:111:f400:fe0e::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69c19f88-328d-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:09:04 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 06:09:02 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:09:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69c19f88-328d-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DvX/PiIT/n9WMVHXRKgP/fAdTfzLiPzqQnAwg6I2YuRGAsmBCqvaPJkqJ0JffHk/wzV7Uno74L64d6BEpQKU4i7Q8UfUU7v+fYsPY+H/uFA0vpjsnlFQDLc2rkkV/YtoRrIpAOghlcS+LG0kaQF+5ntmfp9/3LuIn8cDFOIB4rdTtlguyyJebYFMh/utAljyGr7ySfNa7mW6QZlYxZuoRyazM+O1t/0bLiC1Tf6+huAM3jThqL4YPPRJk6cBVGb99RGKqd9EpanKyV5mv7O+0V+pycfxC4XS4zWBTouGq4dRBqII0ILSrPtaU0yUGmcCFQq+2TCn7Q1fFymbFW5VgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6kl6RWXn5uemkd7ASmE2X55x5oFAeTzP12gxwiwAjek=; b=cJiXg6n3czBBLkW2iObgOkT9OnaSdxKm7IHEso0Pnkdt7ALp/81m0tDPPm69ZnV8GefOBjh5Ah4A1vwLkSA8dwJCRiFBbL3+Qm1nthus/q7zyfgjDICvqG3pPrwfdZwR7FYlyLRAjZAJUYMjGtDvwNhy0NxjQZoxRiy7GRZHELQhWm9N2RLwjk6su+WHgY8aAHG5+IVICaan8kpmMnLNPuNABdUcscW5QfKmz96Cesik9+81TLYb6dHDJ6Umy615pG0z9004A4eJXlBGLFqEawefaQRShkyUsTv+03orfCIg10NyByOdklE4iaM/93hPa55ueJWKQKWVs/WrK8xmFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6kl6RWXn5uemkd7ASmE2X55x5oFAeTzP12gxwiwAjek=; b=anxPElsUaRztEXyJINxqzMAzz8zGhj96bY8aS9Gcd2B0SvaUJjeqSWy4HJV4bFk94ZEttoa3aFcZZzXOh4RUpwinKVxYb4ALFiu2UvVX+VuIhXBaXsbMksrCEusR00MvdvEaNtJyTxYnfm11Zh2z5WnVP7weII/DalZ9InO/tMLmNjKPzaKsoDaY9mGUohXGMMBKaY43eYdfnCN1OMclaahU034bZXuM6sN3Yu362b1FtXhLckN9qtyAgVeFpt/XYv0c8ZIYdwu8qeCYQxcHYxfyJnk69zjgQmew+yanqzF3p1eHYQzeOFZrppj+MOzDC17G7ZLvEe0scu/uLt8ekQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 08:08:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v2 2/2] common: __u8 is history Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> In-Reply-To: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9067:EE_ X-MS-Office365-Filtering-Correlation-Id: 4547ea30-f847-4196-b5d1-08db94b14c24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IuYf+6Y6kagyl28TrjhEr80LTPWKvhlSJX+S39SjgAWH24WgPdrl8r5KLsfqjfRA8HK/0wmlE3fE38l31bv2CCSh8kr/8HRjH9sxkB1Xe88xcYAvAspnWRbtL50qGUMBZLxcs7NRYFJs5xn095Cw01Oq+v8hK+vcbpD6436CjgpxPsaAt2u1hy1bP5e6n9XOtqpLf9DcCUi7kZW8JSCXVAgI4A4SvoPjaZBnj5+HbgAdGJgw+C25wWBsq1IgAvS7ClLkQfoAFYcnUptmkDtshvyHGrlGkBvuG/4Eq76eX2XJZK/Jys/93Ggq3T5J59XFidvoUV8T0pDJc6W6CILFZZYbmkUHhMdRiJ8/rYa5k5ffQHmS1CkIhC1xHgiqINaSlZdNli/IZuNB01t3/znN/ybEwylnjtRT02B7IwUNTHYrvFENq8g6u6hJ7KJvl0yTu+Fb6KRGtBMZEtlZifHPmYGmpaizybEWUgJ5tVTy81hEGiveM2F+l2Jto5G/JnOXqVRdhlvFYXutFfatNnQkw+zBCTaZcYgAphVgEU3RnG22E/x3D9OPxI7t6a33sxP3Cun0+Ms5PTnEVmieDujyRTf+9QV08ndqOhbJ9aq60/y0k6yFUdvDyGf9nNAD9dzz5m/Y46s25qCcYQoySeQ50A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199021)(1800799003)(186006)(2616005)(83380400001)(26005)(6506007)(8676002)(66556008)(316002)(2906002)(66946007)(5660300002)(66476007)(6916009)(4326008)(7416002)(41300700001)(8936002)(6486002)(6512007)(6666004)(4744005)(54906003)(478600001)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDNJa3hWZzNxWnpNQU43OHgrTjlURUU2YUdZK21PWjlvQmhGZ1VtUC9Fc2Nm?= =?utf-8?B?YVl6eE05VzJXRTluaG91N2ttYzVNOGhvVUpEMU1HSTAxMEZocmdNUERyRW0r?= =?utf-8?B?RG1rbWx0SjN4UFBPYm1sNzRWMEEwaGZYRVVrdEN5MVFNL0h5UG9qazlmSjRJ?= =?utf-8?B?c1Y1YjBVUCtPMitGL29HODIybURDdzRBekhMWXZaNnowT1VSOWZ5SFp2Uita?= =?utf-8?B?QStoNy8weFpDQythYmpJUm5VbUVwUEhkNnc4dTJQclZXTmJBNDFlTzR2ZnZD?= =?utf-8?B?RkIvbmFWWVhFSmJTWXVzbDdIaklpSlQzR0VsWWplcDlyQ3ZjZFlTdXRUU0tv?= =?utf-8?B?K0tTUm9TYVM1RHpVRExRVXhrZUdVczZJVFVDbkFYR0xpWStnazJoR2REeUVK?= =?utf-8?B?c1RsSEJ5ZnBBdjU0VVU4SHpxekZQZ2RuTy9ZYlB5em56ZFlYSlBnbFNST3h4?= =?utf-8?B?Z2lMYjF3Z2FzYU5LbnROdnl5SE9XZ0dxUUVMZzlmSTlCT3FlZml1NHlYMWFv?= =?utf-8?B?SU9TZUpYYU1XZnlwT04wRU81d29xWVpuUDdTZ0RvdlhpWEdqWlpzL2VWS2Vi?= =?utf-8?B?cDFvNHpTZHBlZGZUY1JWZkZUVHJpKzlKYmtUT0FWZWVjcVc0Q2pCZ1FrZXpo?= =?utf-8?B?RzJNdi9TTE1EMzBWMzAxWWE1NTlHWUlrU3lkYXpBVVFnZkhxVHdpNjB4QTJJ?= =?utf-8?B?OGowdUlTeXJRd25hSnpFYTJJUGdiSm1lcDBVS3pKQ3FHSnNDbGc2UXUxSEo1?= =?utf-8?B?eXM2MFJzaEVMbWpvNEtCaWVsMEtZV3EyNWJWRTdkWGxDYWIyYUxKRUVqeTM2?= =?utf-8?B?aEE4WnFlR25IQmp6dlhNSS85NGJ1M2NvaUtQUWswdVJCWDhBdUxmamdqY1Z3?= =?utf-8?B?MDJKYStMWVVoUDZXZEs5eWI5ZDI1YkFpOFdSWHZKWlFrMDVOcjJjM2J2MnhG?= =?utf-8?B?VjJpNVhHWWpRYjQzcmhEWVZlUHNLTjBtSVpQN0kwelpNaXhLdnN6WkIyMWY5?= =?utf-8?B?MWFNUWF4RXZJbnlBSTZFOVhjYlp2b0M2Rzg0SklvaTltdEFzc25ubDNyT0NM?= =?utf-8?B?cGlqZ2lRQnZSa0NNNXF4QXRYQWthdFFhQzFWR3JFQmp2WmtBWUdJakN1bVJP?= =?utf-8?B?a0pyQ1RVb0QvUTc5WHdWaWxwb1ExN0NOOURrekF4T1hsb2RCb296TEJxTmlE?= =?utf-8?B?cCtMa3g4UWtPVFV1UFVUWDNvNFNaS3lkejUrT09OS2JGd1o0Zml0MnNRaWVC?= =?utf-8?B?Tm5JdzIyWUsxSUsrU1FRVHpNY3VTeGRwYUVmSDBOclVjVUZMazQ0NXJidmh6?= =?utf-8?B?Z2c1VEw2VDcrRUxxVDdRYTY2QmpZMjJXTUF1UndCWTFHd0xOUnUvWlZIMGFv?= =?utf-8?B?Q3kwa3plRXIyZ0FUSU5IMGVyK0dUMC9EQmFsWHlGMHpBU3N2VjMrNE9tUHg1?= =?utf-8?B?MnNEblppMmVCbTVESENqRjQ2dnB2TE5vbTgwVnFmbDJCenp1VW40eEU4REZz?= =?utf-8?B?akVrZHdiOGtsb25XakQwVkdTQURDaHNOZ1ZzS3M0WlprbzQ5K3FvTGk4dVBu?= =?utf-8?B?dm40ZDk2R08wMzNDSkNhSFFtN1V6WHN0YXJPeE5BaHNLU0FUZlF5RHVJNlRh?= =?utf-8?B?LzlYNVJ5eTNsTWtkaEUwb0V3YWMzS3RDOWhqWmFxOE45NW1rS2p5Tm9yNUhP?= =?utf-8?B?ZFFjR1pYMEZpMFJGY1dNbXNpZ2lCWjY5dWRzZk1Nenc1V1djWWN6S3A2UGhl?= =?utf-8?B?TUkwOTZjdGt3TUFlbnBFNFRBdFROUEVRRDRKbWEvMm8rMTlrT3Q0QzBldmc1?= =?utf-8?B?d3Y5dDZaMUdoV29aNGdHUTlhVVdrY2VVRE9VZ2k2MDZDTWFHbXBQK3dPWjFo?= =?utf-8?B?VFdIa1o1YzFXWmM5SU53cTlVMmw3Y25GK09zVy9oZ0s0WUxwRkQrU2UzcTZi?= =?utf-8?B?ZjBZcUpLUC94MUxNcDRtcXNlcEFoZzM1eThTTHFYVmVaQUNpWnRyMlNGbXdG?= =?utf-8?B?cEU2RkJoVEtYOFZGSzduMVUvSGs3RGFKNGFHUGt5TEFGM1gxRlFYTG9pS0pu?= =?utf-8?B?USt6ZnFHZ1VTWkNkU0xoSnlyV2NkdVZUQXcrL29Uc0hWNEV2cmRnYUgvUnh4?= =?utf-8?Q?zxeh9yKovNod16W55mDJ4Hd89?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4547ea30-f847-4196-b5d1-08db94b14c24 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:09:01.5550 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bDwcK2szC59YV0gKoJFdEIHEjEdE3JRm/6WGzMtI+CKx+q3pUu0Qw8D7AUgDjkLNa04xwkvG7cTi/hrY71Y+qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9067 With the last uses gone, move the type to linux-compat.h. No functional change intended. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- The primary use of __u{16,32,64} is in the byte-order headers. Iirc there is a series re-working part of that, so I guess before touching the logic there that other series would better land first. --- a/xen/include/xen/linux-compat.h +++ b/xen/include/xen/linux-compat.h @@ -12,6 +12,7 @@ #include typedef int8_t __s8; +typedef uint8_t __u8; typedef int16_t __s16; typedef int32_t __s32; typedef int64_t __s64; --- a/xen/include/xen/types.h +++ b/xen/include/xen/types.h @@ -6,7 +6,7 @@ /* Linux inherited types which are being phased out */ typedef int8_t s8; -typedef uint8_t u8, __u8; +typedef uint8_t u8; typedef int16_t s16; typedef uint16_t u16, __u16; typedef int32_t s32; From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:24:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:24:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576857.903468 (Exim 4.92) (envelope-from ) id 1qRoEp-0000hV-BU; Fri, 04 Aug 2023 06:24:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576857.903468; Fri, 04 Aug 2023 06:24:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoEp-0000hO-8a; Fri, 04 Aug 2023 06:24:39 +0000 Received: by outflank-mailman (input) for mailman id 576857; Fri, 04 Aug 2023 06:24:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoEo-0000hI-36 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:24:38 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062d.outbound.protection.outlook.com [2a01:111:f400:fe0e::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94edce62-328f-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 08:24:35 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9210.eurprd04.prod.outlook.com (2603:10a6:10:2f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Fri, 4 Aug 2023 06:24:34 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:24:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94edce62-328f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IPLVDuk4yMw580TDa+IEiM+SKBpGmJM+LffICCOxReSF38Y3TDFCmjBxg8wHuACcfwUmcB2LhohmEC5nNmtdoLuzsbitSaUiPOG0MJefuz7bp/BRl009wDXJckd7BJ2uN+jBAOmofWmEfYf82WZ7KTVt0/P6wCijabHhi47uA3gWtg8Vg6y+ZwtqKV/rwpPfeVPIRTSGeZa648TTB3M12+OMgMv2es4FVansk/JexfbcdofHlq2xFWYJJMkukoFvHDKbmMYCp1NR9pTCqzWTgD2hbYkitpjvAS7PRhJFTcWQMST86YxrTQNC4LBr5tFmUxdHC7VYxqP5FVyoc0zeZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=khlMCG6Lb9J8bmE3Xh+hVWhqFVltOB8R4ef78zKo+9U=; b=YmejZYI1aXx5x5XI5rfwgMzKt1sGu36SJJTPq+BJhShYi9m1cAQDwP/jNEz6Dr9WpcsXzGbZ8cVKOEYB76l4GSB92ZQvJpgqjUbXlXkpBGCJCDfa4PfCBHA7RJq+51hW8rTaXvkzX2cb+Ow+h5WLSafBR46C8nNO3waTSDt6TQ1Cbh/IXWjHpcfpCl5uUH4k9LguJAMN4jqbtUP5CDLpCp/a75rQXP123pKzZImgmELNVlPgA3Ad0o8EVCKMwpL7wn2cMithp3f+kZFL3/In4GDGhi/CWoC2yrNrGAxxFvWcZ/XUXq5q6g+XdXCwsc+/D5kkIbt60x3gvoSGy52zfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=khlMCG6Lb9J8bmE3Xh+hVWhqFVltOB8R4ef78zKo+9U=; b=H15Va7IhkvQ/rfiJbU655H3XJrkk9qgsfC5WiI106zUpWwYb8ajGk0u9q7sFGWsxxWIcpXLP7oG9Ce2qXdUZ3h2g4L4ivh2ZVj8wf9dPf4113m9Dskk2WKahApA7DgyN/WWP67nNFCKkonk/uaGNP/ZTdueD37GH6t3ssCWxhrHOQrh7xh4pYXyrSLNoxjxadrStzC8gapYccFquI+XSJplgGLh1OWA8AVkjNrSezvHt+LHIqhrYA+FFjdT0/kP5pBeg54T4PVnbrd/Ri80MG58QBra3UckYd3CZzZISZTI2NA8BXOZf6+lruYhXNSYO/hIhjlGsD/Zv3HvJ3P89mg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 08:24:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 From: Jan Beulich Subject: [PATCH v4 0/8] annotate entry points with type and size To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , George Dunlap , Shawn Anastasio References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9210:EE_ X-MS-Office365-Filtering-Correlation-Id: 717811ca-3db6-4843-ff65-08db94b37805 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tDtWKHkcmrI4xBNjhFhf+u4RVSuXxfhCak2aEYt1l0+NWeORRo674QI18u5JUgsMvh4QtXR8bwjfdKHW1xIsSs9h2CW/PHMNmsnFqU3kblSbn7JpXYEHFhrxwQ5Zcax4qTBL6N4c8pQjyg6C3ho/Aa7lcCBVD7aSjPKHHIj4YP2VAyYAlujI1hDIokGd7vUgJLQq6VggUrnLRF/OCwNJW19/onSHr2kYoIZpjVkv3EjCPMpI5rlH/linJCrT4P/SJmCMw4iLYskdem81HOoPFyMxXNXvh/1faoi8jkChjLx0aCHAb/9yFHEJ2e0fxjLJkXC6d5h/dgZWvJw4yt0lYPGSwlSh5VwK8q8nsXAn/lJo4SStvzpF5qkdanHB+7IQSM4GYmAi1haHiMmMns3S57wwoIgT3txiAxAfjo3nbyixAxnEVgjSDz1NKGGgc/t+hjW5Em1IBEZRF6bvdLrRZ4A/8SOVIywMNaICB3JOqkV6Y78HxwEOylJelsrZt5oqf1lgFw0NFtClAWq4L7S9tXo1urTlFiAzlNWryVszdJaUSJVHpiO14zjZtiBcImReKyPSjhhWoX2cOuteR3O/kpNHwDBK0OKvcLw5aq2gAG87Zjfy9HEqFo7LSIQwloX6jEl8PlW8iv7e9el3jNNEYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199021)(186006)(1800799003)(6486002)(6512007)(86362001)(31696002)(6506007)(26005)(2616005)(36756003)(38100700002)(5660300002)(41300700001)(8676002)(8936002)(31686004)(4326008)(6916009)(2906002)(66556008)(66476007)(66946007)(4744005)(316002)(7416002)(478600001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGVNaGpCTkFITkFJZGVlMk83cXpHVnYxSUZwYWdFOWM2NTNFcitaOHpacElQ?= =?utf-8?B?Lzdyb09lQjlWQVNPL1U2a3A1N1pmcmhhd0s2T0xEdHhSY2ZJY0h0akx5M0pj?= =?utf-8?B?cS9wdEtkdnRCVE1GQnlIcHNVeUdtNjRXYWNMYUYzYnMzNkIxNHdXMWVIRElY?= =?utf-8?B?Z2xxWXlUbUhQZURJQmRlL3VOWXh4d01jL09KZmxjdXFXcGM0cTA4YThRVmR4?= =?utf-8?B?UVZheDg4V3hIMW1sNmZOdHhmU0FINUYxSnlmNnVFbHNMRitBUFUxWW9LNkVF?= =?utf-8?B?Wk5LUmxkM1FXU1ZKVkhVaXFnWVZ1Nk0vbmlaNDZZNUgyYVlYNFlFMmlNeHdF?= =?utf-8?B?WUw4MDl1RVp5SWhZUDAzL3VhRFBNQUJFcGFYZjl5VGN1Y3lZMUNQVWVGdVR2?= =?utf-8?B?NE03QVUxdmREeEdPdEx4T3luVzVybGd5Uk8vZC9iQitwTklxQU1hV0xhYzFC?= =?utf-8?B?M3lNN0R3czBpZ1p6TktadmZZazA0T2lSWHhwY004K1g0cVBnVVBiWmVzbFk5?= =?utf-8?B?TEt5Sy9EbXZ0eHdER0hVbXpkdEJzN3UrN0J1UCtEVVJGU2V5eS9yWlpvUUll?= =?utf-8?B?SmM2THdqMVBiSGlWTGxob3BtU1A5QytSOVYraEpUbFo2ZE9EdnJaSmJHcldR?= =?utf-8?B?em95Uy9UQTdZREZRZGhmdERPQlFGcUZpTzkrVkk1OVpSV2ZJVFJLL1I1UENM?= =?utf-8?B?SmV1SGl3bnQzY0lkeEhlZ1BBcHd3ZDRxamgzV29LU25rdS9icldZc3VrcGd5?= =?utf-8?B?VWZTNi9jZ05ENjBEQjAyZXdJNno5c0pBU29Ba0lMaGlDMzdZYXp3WUsra3o5?= =?utf-8?B?TUpZMHZYeEhQSjAreDhnelFSVDlVNmVCcTJCRHpYYmYxblhtOGQ5aDhGV3JS?= =?utf-8?B?TzhuUExDTC90REZxZHU2S2dSK3liaENyYXZlQXA1aldoUDVBSWNBSjVYTno1?= =?utf-8?B?SUNLWVVUdFlNa0dNcTdDZGJHaXJOeDZyeXhiVURYdlZEOGg3WUE2d2l1TmdQ?= =?utf-8?B?MzYwM3JYa0hScTFWSnQ4S2FCU3RSQVAwa2ZoUlFRSld3ak5DZ0podnV0a3ZC?= =?utf-8?B?ZTFucHQ3NVpuZUdMalROVG5yWERGcUJoeUVmeVZNN2MyREpHdjJBK2luUG9C?= =?utf-8?B?dTdWcTNKalJYenhnd0NGb3hPNEtUZStGYWNxdjRha29iT25oMWtSMTJlTllO?= =?utf-8?B?bDVwRjN3YmNHVklaUFRBNEUwMGhBMzhFZDU4czNTek1ZU2ZIYkIvak5SNnFQ?= =?utf-8?B?S21DQXR2QnhMdnhhM1JjbmxjWDEvekMyUjBFY2lqaTR5UUpQMERielpBQ25w?= =?utf-8?B?d01RVVFBZE8vRWhhQ3p0M3g1aWtBcEJudXJGVENXWGppcHhwcGVIM0F4R2Z3?= =?utf-8?B?WmhobXNwV3lBbk14N3hWaDNwczZmekREaStZWkFBcEw1MmZ2S09DemVOY1Jy?= =?utf-8?B?ZU9Oektzd0VCOHRRRmswWkZqSVZHd3U5RGRlc2w0V0ZqNzR1YXQyRTc0S0lS?= =?utf-8?B?MnBJdTRhWC9LbTFZNm5YQmZxcnJKUmYyZ2E4N1p4UEJRNHZ2bEdGcWtvTS9T?= =?utf-8?B?SXlISVFSK0FsNnp1REd0VXFJNWpyZkwvSjUzaXFlTzhHdlBEcXRSZ2ZSNmFW?= =?utf-8?B?VlgvTjVrd1BtdUsxdnlja2U0LzFFWkNWRXpCT1VaZjMzeXpSdWhmdWVvR0to?= =?utf-8?B?K1VOMVZYSzdaVnpJUEovemcrWTZFSGcwdTk5V29DU1NjNFFiK2RvZnFnUGpN?= =?utf-8?B?bFlNQm1CZnk3NXRwcHN1dXUvbnlKNFg3L2J6TG5Wb0phUWlNZnQ2Vm9uNnVP?= =?utf-8?B?cGNZZlY3OUFLcnFCc0JZeWNVRjhJWGE3TEwwS2dsQ2YxcGsrbS9MQlh3bkdk?= =?utf-8?B?aElrZkRuUmxwTFk0ZGdwVzBjclFrM0JHR2J1Rk5zS0FIa2tseGJhOFR2ZWh1?= =?utf-8?B?MUo0VXZpSlg2SUlyQnNVSjB5SFUrclFwbnlLbGFhamF1NThMT0pTUTlDQi80?= =?utf-8?B?MXhyQ0V5NUw3YnRlNENUOTBXWDV5ZmZxWUlKTlVrOUVIYnpOdVR6TVo2Zm9h?= =?utf-8?B?R2ZuQjBVdGl4akcwd25SMEtlZ01XVmw1ckJldkUzVmJRZDZVYk9Ed2R5VUpQ?= =?utf-8?Q?V4Zjpp7u8Y4end3sGYI1gorbQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 717811ca-3db6-4843-ff65-08db94b37805 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:24:33.8861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zLBPb3+ZRYcAaqGcUHXALFmStMibqxLic7oRqpmLpL1Shyj9c6dm2N7GUV9oxH5JKgnSUGjbLFBRLXsuMCYDBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9210 The model introduced in patch 1 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like); PPC and RISC-V are still small enough to switch completely in one go. 1: common: assembly entry point type/size annotations 2: x86: annotate entry points with type and size 3: x86: also mark assembler globals hidden 4: Arm: annotate entry points with type and size 5: RISC-V: annotate entry points with type and size 6: PPC: switch entry point annotations to common model 7: tools/binfile: switch to common annotations model 8: common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:26:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:26:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576860.903479 (Exim 4.92) (envelope-from ) id 1qRoGT-0001Fn-OS; Fri, 04 Aug 2023 06:26:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576860.903479; Fri, 04 Aug 2023 06:26:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoGT-0001Fg-K7; Fri, 04 Aug 2023 06:26:21 +0000 Received: by outflank-mailman (input) for mailman id 576860; Fri, 04 Aug 2023 06:26:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoGS-0001FG-RQ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:26:20 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0623.outbound.protection.outlook.com [2a01:111:f400:fe0e::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d320f1ee-328f-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:26:20 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:26:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:26:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d320f1ee-328f-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIcepoZQLHoAej8AtgDTFQ5gmLSRviAcQHQfoyT31S98lbcGu3RfU6au/SbF4Bf7uehIu+DMKHTsj/BhsaYnZiAmV8eL+qAq8wCz/L5sTkB9qvyYLZtyoD7kvl2YWQTin2jWXcLe+hWiaYRbkc8uu3eFbLRwqxHzIXjU5NkBWE8EP89v4FjXJFJc2dhw5qqA2HRNedkKNw+NItuy9GHML9WG5saWllyJmLPE37FmXoiszVDJa3lc3+TXUp/gGfCdESA/BmsPtDFbOUHieryZqwkUn1yMIxhwHK1yNnz0BzuDZh6qPWkXhcRWvlnZcDixPLRzjihw2pHbjRNGnTntoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Njshz39xQXWzUhA0rIyJzlUroK26ZOgCP1y5HqVWGkc=; b=C2YNExXJc14pTzxKK6yDUvKBjGgWvoXD4j5vDSVQu70W0mGzfCcCpPltY9uxYNZv+HF6il1lFYPyp/bX0TxsGYo04KKPA+hEewtOt5oeAvm0nKClznrGSYT4y+JsPqGu8BhTnOr+vxZfju2mDufzmbDL8nEjH0KP4dAaQU1WMUdm0xb4FfuqkTTb28SQU8Hro0TEIDzEnOVp3NPCoujXU0e8rOU8BtzqBy6oH0jX7XI7cgD03jbQOjyVTRGChW5VkcUU4gw2qBQ6SR6NM7OidH9vXs7LpVat9XHofhgyJLDkXD/Rtxb2XBNSrg8E1iufCPjvQId9uUgLxxVuoihdWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Njshz39xQXWzUhA0rIyJzlUroK26ZOgCP1y5HqVWGkc=; b=f5nWjrvevgLbNrsC1jnrSqI3W78s9oeCwKE+hLBU8Fy0v8W+Rp1hb40gAOxKyxcUKd/+rVYY+GcIUGBtrWNgSL1RqWBbhvww0DRfQPTraFKmAECrpkTYqkbRmGM9jPUaA1Bs0tNRNObRdux60RMEYNZjWQvtwM4bASh+tU+FXgB+ZKMrSnu2XLbztsPSnwGVzdfHQYmTRsMB/QrbNOxBZ5Ai26hI+H6Ep1rIzzVgX7QmHl5I2sxDWCXz5yIYjY69JdSNE2xlskEuwX1p5wa0IMHettJL6YW26a9Vnsba4K7CbnIx3xq/7yfv5vPgoSYQTrFbzb1GDUzT4kvA1I7UlQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ed43968-311e-263b-4dd7-9f8a49a394dc@suse.com> Date: Fri, 4 Aug 2023 08:26:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 1/8] common: assembly entry point type/size annotations Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , Julien Grall , Stefano Stabellini , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 383e3393-971a-43bb-ed4b-08db94b3b62f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AV0XOXT8QOWAFgwYxjNSlQmqEFIG6vcr71PeiqsmZeyoYhzz1/u4jEhZ3xmMsa+FQPPVu1ZnrKvutWR5CRjJQNSIgEEakA/Fc6eQtKXXqskBnEKexv51jYoPPVyhoROWCSj8N8IRtVqzMkA+qT11Q5M2jtjhpO57IRJef0RSrIR+9ixgi3GRcM30lZ34IRRqjspwdoN2daA0U4I+lwishW3v+LPpA1PpCVfl333GMt+xJ4Sf5fqPVWui6psI0VucXjLCUb9DdybyQmoKE/7ZR5gN9CWFVrvpjVYuVxNs+7zUrPhiph3oKcX+3B/o0Gj9lswKNfsAIKdBRPx6QUEz2V7ZEK6UsRhYdhdjJ5V2zRYZYb1DYok4WZH5VmubD/FlpQlPpblzmRXp0j+Y7rCiWctM6lf+JzPQ+idgII+y5ojeMkjicbam0pgyjgr/mu0DX1Q3HbpNz3ze1O48KOVWralpfB2R1ewS53b4zyLUCMtxn8sIKUeMQZ0vzgX8Bxqt7/f5izH5x0P+JnW4RtkCLorTLA73QyG0AtzFDLAwzV3oVFyLuq+O1CWAHOKOPRiUcwrRxnIcfgXA9hoGdR200ww+NjQsmWliqPU9t6Y7QOy+m1NVl0cqj2HN+wJuSkR0jhZ6e7zBmgmhm3MQ94IISw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(966005)(478600001)(31686004)(38100700002)(2906002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDFYZk5MQURlbnh3My9xOTlyeForOWZ4c1ZVUEJSTXNCUDEyaEZyVWlPYzNJ?= =?utf-8?B?blY1OUtpSmJyc1FrZlZNd0Z0RjN5WkdGNDMyQmRQbGhEcjFBVGtIN3pCMTRi?= =?utf-8?B?RlNBZExPK0hKTlMyQWhBSWs3WlZjbWxDMWR5bHZMZzRFV1NJWmFXKzZCUU9h?= =?utf-8?B?d21iRlp2TUpBSVRNcXBLeDNqVmZaMWhkUnVlb1NUMzdtZGtnRDdXR0g2TVlG?= =?utf-8?B?dTlFUUJjdGljb05RTndWdllPRHluTlRrNHhRcDJHWlZ4cU00UTBCa1k1Ullo?= =?utf-8?B?MmpXT0hkN2JSRnNFaE4vb0ZBVkNoYmN6SEttY1I2NUlSUERFa1plc21aL3JZ?= =?utf-8?B?cXBJdUh2OUowTXIweFV4c1VEcExSWFF3Z3F0VjJsRzd5YnI5QUZaL1dib1JH?= =?utf-8?B?K01yNnUvS0VhSUFXM24wazFwUFBma1c1d1pMblFmK0VuM3ZwNFJtT1c3Z0tl?= =?utf-8?B?cUQweU1HYUxDb2ZtU05LclFoVXE2aUtKaTEzR1dISWNCYk1aWlVtSGk2VWZR?= =?utf-8?B?OTZueTNVS2s1Rlo3bVV0TUROcEZjZ3NiZW95VCtqc3ZEUjk4SjI2YVk0cTRs?= =?utf-8?B?SFYxS3dkOTJVUWF2TUt0RXdqZXlyQUZGK3VLeTRRMXZmbEVQMkd5S2xjaVhk?= =?utf-8?B?Wjhkb2ZaTmZjNGtMVU9jTXNKMUFKK2NabVpSSmthRG1Fa1c0RnZ0aTlQNFli?= =?utf-8?B?NVB5NlYyOWYvajVpdC9xSjlUUFZiRmhtWmRXQ295NXRKYjJBVXhSMkNHaW5h?= =?utf-8?B?SHVSS2FWdFNkS3YxUGgvWU5PejIvTnFvMXlESnFwZ2hjY3pmWlY5N3Q5dWdR?= =?utf-8?B?Mm5QSzYreWJkOCtYRGRPeGtYVW8vUVFwSmVxakI4N1pqeVJsYXdCQTI3WVdT?= =?utf-8?B?bXNoazFSSGxjcUFBaEhQNE1PSnJhc3MvK0EwZ3VscmczYm5hUnZpQ2x2ZVZJ?= =?utf-8?B?SWFRNHRWQ2pIeEdJUWVGMmJyK3MrSkllTWdLN3Y3b0VKc1ZkZGYwc1ZsVC9K?= =?utf-8?B?OTZ6aWU0dzQxR2pNMzVlUHdPN0FwQTRQVHc4aUpsWG9BUjF1Q05kQU5sZDcy?= =?utf-8?B?M3U0cVdPcFh2T0EyTnFMbzlBYUVBdFAvSjFud1RzazhBK3NXM1JtaVI2VWJU?= =?utf-8?B?eUwybW9SVWZuZFZDUktKWWo1R0FBTjdIN3N4M3NOS2tqUFR5azZ5U1dOWGlh?= =?utf-8?B?QVdwUnFQaWVhRXFxNE02a1kremgxcFNQLzNNQysxREtWNHAraGtlTFV6Slk0?= =?utf-8?B?ZXBuclJQZU13amhnWXNXS21CbURCK2lCcll0MkZ3dzRxQ0w0RFYwd2JNMllV?= =?utf-8?B?T1RPc2ErZzRiNmNzd3djVWVaemtVNXd2Y1ZaVEpIMjNMcXpnUWNLQkk1S3JW?= =?utf-8?B?d0Zwa0gwUzdhemFxUjBHQnZCNndBWVA0WlZTYVg2YnJ5SUZhSjhscXZsWnJQ?= =?utf-8?B?V3RSUHFSOEdKOW9Rc0F2K2V2Y2JVVTArbXdFMURTSzNoNEt3SkRydGpPTGIw?= =?utf-8?B?ZHY4THdXSE56emdFQTErZUpvdXhXNERuMHo2WjhkV0dWOXB5V0ZGTDZPNHAx?= =?utf-8?B?ZTAxMTluTDgyQnBZWWdRWUJUZEpPanF5NDN0VnY1d01rRHVFcSs0SkpDSFhN?= =?utf-8?B?Rk42RENpZUJjMWFsd1dTVTNYMUR1c3hnVUxLN2dVUmlDOEk2YVRDNzY0RlZx?= =?utf-8?B?aDEyOEUzMlZlVUNTUUlZK1JZTmt1NXRjVktyL2VndGo0aW82Z3ZKd3pPQ3dS?= =?utf-8?B?WGRBTysyazZPRk9WZmgzUDRoYWJ2ZEF5R1oyaDBxMVc5UzNrd2k3UVhPR2ty?= =?utf-8?B?OU56cmRFMjY4K0s3WXg2ays2UVFwaVBTS3FEUGdoZjhYMXA0S0JUZ3BwbExC?= =?utf-8?B?Vis3T1lGTXdvemxiZEVRdytWVm1ocXpoenJndm9XdzdiZmdXRkhIWkx3bGtv?= =?utf-8?B?MitNT3B0NHhZaWtTMGMwQTRzSGtjdVozblVYU3FXVGtibWMzWUdsWndiczdj?= =?utf-8?B?c2kvdXFONEUzMkg5bFlqK3Z2dGJVUUJjSWFMa2cvVnRJdU1RTmJ6S0lxVTNI?= =?utf-8?B?Y0xSekZrdFBlM09lUTdiZktMNWZZN0pJVGN0ZkFKRXk1V01BWnBoazBBTXhj?= =?utf-8?Q?SRPElD4ZypTEuClsxqMXBJXoN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 383e3393-971a-43bb-ed4b-08db94b3b62f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:26:18.0939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JoHYrPZKr9sQW8achC1A8vhLJAM36g92Uej6kWeOlvLlR/OdBzFP1iw7Z5QhH+3KEkM+wzeKAB3X8cqOmlZBAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all architectures to use. Signed-off-by: Jan Beulich [1] https://sourceware.org/git?p=binutils-gdb.git;a=commitdiff;h=591cc9fbbfd6d51131c0f1d4a92e7893edcc7a28 --- v3: New, generalized from earlier x86-only version. LAST() (now LASTARG()) moved to macros.h. --- TBD: What to set CODE_ALIGN to by default? Or should we requires arch-es to define that in all cases? TBD: {CODE,DATA}_ALIGN are byte granular, such that a value of 0 can be specified (in case this has some special meaning on an arch; conceivably it could mean to use some kind of arch default). We may not strictly need that, and hence we could also make these power-of -2 values (using .p2align). Note that we can't use ALIGN() (in place of SYM_ALIGN()) as long as we still have ALIGN. Note further that FUNC()'s etc "algn" parameter is intended to allow for only no or a single argument. If we wanted to also make the fill value customizable per call site, the constructs would need re-doing to some degree. --- /dev/null +++ b/xen/include/xen/linkage.h @@ -0,0 +1,56 @@ +#ifndef __LINKAGE_H__ +#define __LINKAGE_H__ + +#ifdef __ASSEMBLY__ + +#include + +#ifndef CODE_ALIGN +# define CODE_ALIGN ?? +#endif +#ifndef CODE_FILL +# define CODE_FILL ~0 +#endif + +#ifndef DATA_ALIGN +# define DATA_ALIGN 0 +#endif +#ifndef DATA_FILL +# define DATA_FILL ~0 +#endif + +#define SYM_ALIGN(algn...) .balign algn + +#define SYM_L_GLOBAL(name) .globl name +#define SYM_L_WEAK(name) .weak name +#define SYM_L_LOCAL(name) /* nothing */ + +#define SYM_T_FUNC STT_FUNC +#define SYM_T_DATA STT_OBJECT +#define SYM_T_NONE STT_NOTYPE + +#define SYM(name, typ, linkage, algn...) \ + .type name, SYM_T_ ## typ; \ + SYM_L_ ## linkage(name); \ + SYM_ALIGN(algn); \ + name: + +#define END(name) .size name, . - name + +#define FUNC(name, algn...) \ + SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL(name, algn...) \ + SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA(name, algn...) \ + SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) + +#define FUNC_LOCAL(name, algn...) \ + SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define LABEL_LOCAL(name, algn...) \ + SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) +#define DATA_LOCAL(name, algn...) \ + SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) + +#endif /* __ASSEMBLY__ */ + +#endif /* __LINKAGE_H__ */ --- a/xen/include/xen/macros.h +++ b/xen/include/xen/macros.h @@ -15,6 +15,15 @@ #define count_args(args...) \ count_args_(., ## args, 8, 7, 6, 5, 4, 3, 2, 1, 0) +#define ARG1_(x, y...) (x) +#define ARG2_(x, y...) ARG1_(y) +#define ARG3_(x, y...) ARG2_(y) +#define ARG4_(x, y...) ARG3_(y) + +#define ARG__(nr) ARG ## nr ## _ +#define ARG_(nr) ARG__(nr) +#define LASTARG(x, y...) ARG_(count_args(x, ## y))(x, ## y) + /* Indirect macros required for expanded argument pasting. */ #define PASTE_(a, b) a ## b #define PASTE(a, b) PASTE_(a, b) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:27:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:27:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576864.903489 (Exim 4.92) (envelope-from ) id 1qRoH8-0001po-5M; Fri, 04 Aug 2023 06:27:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576864.903489; Fri, 04 Aug 2023 06:27:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoH8-0001ph-1F; Fri, 04 Aug 2023 06:27:02 +0000 Received: by outflank-mailman (input) for mailman id 576864; Fri, 04 Aug 2023 06:27:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoH6-0001p1-Cr for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:27:00 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0618.outbound.protection.outlook.com [2a01:111:f400:fe0e::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea94aab1-328f-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:26:59 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:26:58 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:26:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea94aab1-328f-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkUsSQcGqfGM5ImwGHBLBeaFem9Blj4+3KnJwikvmv9DFAorPeQVi+qZhpCkUEgLVjy4QlaiKihI8JardikT6FJHOTc8fe1Vto9VZOPFYuV9eG927+upS1zvJgwiZB6tqUlP69KOWJmAbHaPSVS2C9+MxZw0H/73r0kxmhvo+ois22/sFDQ9XeJwbSCyYKto0+7zOBaYrFFje/cn5N5ZufU5zhdLUmWzme/9kPhZahVE+1gEwYJoxekeT57DcRNf7USMq4fEPPVmICFh0d1zoo2ZZUotxqLC/mN3ejyY7YLFc+gbp2vN34WLPWlFJKd1dUfmcX6mZ3eBPnM+MT7xuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PoORKJUraSg+XV776ewByjof6hXH/BigXRIqZQuk5oA=; b=MvKG7HwTJnlX0gwUEXMsw5OmylQO6oGaPd3OMIh/alOT6yaqiaFGppCkMrZ/9A0R173sVvGEtw9qGWSUewIoTGkL3pBZG7nqpgcXzl9FnoSvcFTEL5o/Rb8GQH2POTKgdnHbSJdtf3kzoANVnvfrigOoV23NzlEsNHmX59/UGWEd98EpygmyAL6cWR0ilT7/qMDbohvgmEwm1kjUqjrygJSYPhCcV4ehvFG1Nja3oXPwmHetJykLt7ZKfepcllH3mCJc/cALwlttY6mL5KACpVqZPHG1QOGyh0wmLuJOuQMBUNTF+yCGmhFNFE1RIm2eAFsyPiX4XKeLBpfEH016Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PoORKJUraSg+XV776ewByjof6hXH/BigXRIqZQuk5oA=; b=Qoir3ou1Vmj566cXB7U7EZ+EbkW8tCQcM7OteMWQojI4/G0F3gzBIU9qb21SO8DM5bM7CyQhTrRbNdMez2T9pCIUdCXTaCes2MH/Lcco6A8C/Jo8uPd1F7WkiaFo5YRbeSK5wDkTxJLrMXI9IWdWMe8y/M+YxCU5FmY8f6rgNUjRlvG8rFXtKl4izoPyGGf4WW0dN//UEzR5ihFi/nCOWLktzvt8dXfTv8wHdm00ua4YPoIMPaVwnHbyI5XwOYK6UmAttswtfVYH7/nRJZli9d54S93f1KfjhGVrPmYrUUachvgt+XBqC8BUSP0bBWHzf+KDJI4fT/ueq/h+0Mt53w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <41f9f8e9-8eff-5e83-8730-1b7b7854336d@suse.com> Date: Fri, 4 Aug 2023 08:26:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 2/8] x86: annotate entry points with type and size Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0115.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a473e54-1e6c-4192-e1a0-08db94b3cdf0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 78J1Pok1vRUT0bZCDkJluMssb8/BYm7aLj/84RvrdhEqyis4aE31uPDLp2SZ93n8zhX/8m4xbjXEG/Hlgb+JGmu2QEXJwRSYIeymdiRlXFzt2hQiqO6i/+twtLF/2KclCjDZLcfEyTcElB4YA6FCVExUU2jjaowRu9W/hUyN946vzz2VnXA6tV8pHPe1XnVxZKveS4WQ69mrYetUgRxuMKck5AQB1IY/H/4iL7MqQFKpZH7DCbpg4ahiQwG5r2ibIjKtGJ/tMIPK32Llcaxa7V9oJ30O3v0D2oMuGyxoSYIYXtzRBjPHy9zN4m9mcDZv1wfoAaOnI+vrTg45cg+8r5Jak0vUnx1VY9lAjU/Af0H7GW1TD357+sHGpS1G5x/lAVwMBYRnlOSSVrLVO1WArzBISbB6q48YCfrfiExRsKvkWeDyjJRmh/5ldcWJR5PUDBwPFMCkXZdzEhHDC+aoEzdaMYjwedy0t69wANY6cNO0bC7mOeRH8og5O55qy63o9kuFHWqovXFkuqxiGxy5LoUMiP1inCz0P2Ve+iE3gSOLzmB5G1ZABjY02uNr306/5HPNQrwg/xZVLGJFTj5Gm8Wt8RdsitPYwZgRHBo08kH1oRIvXiX89F9RXQFPuGuOVSvdI99stguCqfu+l9grhg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(478600001)(31686004)(38100700002)(30864003)(2906002)(86362001)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NllRZWhTTXlDWDhiNGpkZUJ3a053dmpyRkE2Wkh0cUMwMUp2YnJTWnpxWC8z?= =?utf-8?B?UDNzQ0o1ay9iUDBENXV6WmVKZjBNYWwwMm9YQjhhOUsyZEkrZkFBWTNoWjRP?= =?utf-8?B?eHhYaG1mRXQrT3hQK1FFT09JbEgwVjdsVUxraWlOQW5pZjl3ZDBJVVJhUE5P?= =?utf-8?B?SGJwZEhUSmwrTGF0dXlBcUtyL2RCNmM1RmhvOG9icWpFUXhaTWV0WVRGSHph?= =?utf-8?B?dmVWZ1NOQ3BtalJEaWxOcWFPd3dGNEphQ0Rwck0xdVlRS3pucE1KaWxMdkhW?= =?utf-8?B?ZTRrTEZvdE5DaWxZVVdNaW9HVEFsdmtnRlpZYTBFK2FqYkMxd2M4K00rYmJi?= =?utf-8?B?RnFoemxyMTBuekc1Q2xjZmJWbXQ3QWZxNG5vMDkybmNQT0l6TWdabHdsVDNF?= =?utf-8?B?N1dMNndRRUx6M1RaQVpTZVFaTy9ybWlVWEdZQmI1cXRyOU8vTTBNc3dPL3U3?= =?utf-8?B?NCtTQURqbi82am9UU3VTRndrSTFjUmxzWXJWeDZxRHlHOGludUpVZXNrcHJ2?= =?utf-8?B?ZW5iem5YUUhVa1F3ZU1hemE3eXNmekJOMXdISmpDTDZTSkU5TS9wVXlRaWht?= =?utf-8?B?ZEdMZXZGMzFrelE4ME95bGEyd1F0NnRIcVRiM2JxWVNFUXlaV2ltRTlickEx?= =?utf-8?B?OXZoTGpOSG81TTlxaUVibDU5czFzV2Z5d2lLc3R2S3JhaWZCbk1HL0ZCTkUx?= =?utf-8?B?bTI4WW1RcHpGLy9zWXNya1U3aG83YkVSS1BaVkNGVU0zbCtUNnoyZXhxTG44?= =?utf-8?B?RVE2YWxsVyttY2hFb0FQeEo2azZ2U1hQT0Zwb3FKcVpEYmNKWUJVQXBZVlU2?= =?utf-8?B?bzU2SEJVeXM5akd6UVBxYURLOTFmSW5FaGRKTnRGNDNNdU1JS2dTSXd1ZWw4?= =?utf-8?B?dDd1VEtMVlRTTFJYS1o4R0xVMVByaDBnMFZHN2RaNmhqVHVuM25vOVpCcHFm?= =?utf-8?B?YTJBS3dtaHh1bEl0MERkQitBaXdIaU9oZU9QZFd3VElJUjBaNms4TlhrU2hN?= =?utf-8?B?L1M2YTBXeHpaWm81VjBuMjBNa0RwRjZSQ2srUEt3ZUN4UkVDczNMRHMybTcv?= =?utf-8?B?L3NlUXdneUVCcEhnQlZZMGFoUmpEeStkbUJGVmxvbmNrandiM0dtb1VDRzlw?= =?utf-8?B?OHhZbllHM0ZhVWxNd3VodDdqWmJ6VE1BbUxWeWxvWDVmRFRoYkk3bEd1SXZY?= =?utf-8?B?YWE4S004YzNKY1B3YVdDbWVlSzg2VjA0elYrOVBzS2w0a3NKSDJKaWtOZ2g2?= =?utf-8?B?bEZ5djhEWlNPdmJ0N2I3MTZJVFFFRXZSUnRpZFdQYi9zODV0QzdBdFBnNnl6?= =?utf-8?B?anZLdlhYK3FhcFNaU21WcWNIUHRKdjI5Y1ZjbHZKd3plMXV2TSt0SThzWWN3?= =?utf-8?B?OWJXKzRqUWNkazdtZE9IQkc1UnUwOXJyM2pWKzN6WGN0OUN5V2ljNGNLanox?= =?utf-8?B?b28vS21IcFF0WGdsYytEVTQrdmdVMzhMd3gxc3lvN2NkQzJrODMvQ0g3QlVP?= =?utf-8?B?My9JeEVjK2FqcnZsdmEzWTNXZGhOVmlCeXNtM2FFeXp4TmhhdW80OUZtbnR6?= =?utf-8?B?T25HbXhlajFiUUtFVERBNDI5dGdRdkdZZUtWcVlTNHpkUEkzdFMxTFR6UUlQ?= =?utf-8?B?Y3g5UXR3MytZWXkrTFQwL3RWZndxMkphMkErbDlKSmVXL3RQbUtldi83S3g0?= =?utf-8?B?STR1OHlSMWNUS0xkdE4xQmg0anlIWmtqYm1CN05EVmtla3ViYkJrRTlBMXdN?= =?utf-8?B?bkRGZlVweDQ5bk5GTTQ2MS84aklUZTh1bDRpcm41eWFGY2FXM1pJSVJDZWxq?= =?utf-8?B?WGFtQTdQOW1FVHpKWk1saXRzUktDNW00Vjk1QU9yZlduS0R4ZCt2RGxtNllH?= =?utf-8?B?dUpEdXVDUk0zcGlaUGl1bjRqYWQzcWM1TWxyVEdoa2N0SFZvSnFvZ0VMNnpp?= =?utf-8?B?Wng0WFErTHJRQU4zQlQ1ME9Kc2Z6Zlo3S0VrY1VzZEVoR0ZiVkl1SVFTRTZF?= =?utf-8?B?bVdnMzhWeE5Na1A3a3dSQzVscmpMQXQ2M1E5N2JqNkxHajNnMklJZnlLWjEx?= =?utf-8?B?NURTZWxkcVlqL0ZVK3g3dG5lSS94SGVHRENWaU1iemtFVkRpUFJCK3NmWkx5?= =?utf-8?Q?Nc+UR6OCUWAG43yZbODaC0X9N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a473e54-1e6c-4192-e1a0-08db94b3cdf0 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:26:57.9302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9izG5Q4PInDjAPyZ0+MCUnPPdsZ27WEC2Kiffup4dqv9ow1mslKszH6snaiAqwVAkeTy9LMa7QfX1W7CCnIqcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Use the generic framework in xen/linkage.h. For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints[] alignment is newly arranged for. Except for the added/adjusted alignment padding (including their knock-on effects) no change in generated code/data. Note that the basis for support of weak definitions is added despite them not having any use right now. Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway. Signed-off-by: Jan Beulich --- v4: Correct simd_coprocessor_error's (now entry_XM) END(). Re-base. v3: !PV variant of ret_from_intr is local. Introduction of macros split off to separate patch. Also adjust ASM_INT(). Re-base. v2: Full rework. --- Only two of the assembly files are being converted for now. More could be done right here or as follow-on in separate patches. Note that the FB-label in autogen_stubs() cannot be converted just yet: Such labels cannot be used with .type. We could further diverge from Linux'es model and avoid setting STT_NOTYPE explicitly (that's the type labels get by default anyway). The ASM_INT() redundancy of .global will be eliminated by a subsequent patch. I didn't think that I should make CODE_FILL evaluate to 0xCC right here; IMO that wants to be a separate patch. --- a/xen/arch/x86/include/asm/asm_defns.h +++ b/xen/arch/x86/include/asm/asm_defns.h @@ -13,6 +13,7 @@ #include #ifdef __ASSEMBLY__ +#include #include #ifndef CONFIG_INDIRECT_THUNK .equ CONFIG_INDIRECT_THUNK, 0 @@ -343,10 +344,7 @@ static always_inline void stac(void) .popsection #define ASM_INT(label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, @object + DATA(label, 4) .long (val); END(label) #define ASM_CONSTANT(name, value) \ asm ( ".equ " #name ", %P0; .global " #name \ --- a/xen/arch/x86/include/asm/config.h +++ b/xen/arch/x86/include/asm/config.h @@ -43,7 +43,9 @@ /* Linkage for x86 */ #ifdef __ASSEMBLY__ -#define ALIGN .align 16,0x90 +#define CODE_ALIGN 16 +#define CODE_FILL 0x90 +#define ALIGN .align CODE_ALIGN, CODE_FILL #define ENTRY(name) \ .globl name; \ ALIGN; \ --- a/xen/arch/x86/x86_64/compat/entry.S +++ b/xen/arch/x86/x86_64/compat/entry.S @@ -11,7 +11,7 @@ #include #include -ENTRY(entry_int82) +FUNC(entry_int82) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0 @@ -27,9 +27,10 @@ ENTRY(entry_int82) mov %rsp, %rdi call do_entry_int82 +END(entry_int82) /* %rbx: struct vcpu */ -ENTRY(compat_test_all_events) +FUNC(compat_test_all_events) ASSERT_NOT_IN_ATOMIC cli # tests must not race interrupts /*compat_test_softirqs:*/ @@ -66,24 +67,21 @@ compat_test_guest_events: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_softirqs: +LABEL_LOCAL(compat_process_softirqs) sti call do_softirq jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu, %rdx: struct trap_bounce */ -.Lcompat_process_trapbounce: +LABEL_LOCAL(.Lcompat_process_trapbounce) sti .Lcompat_bounce_exception: call compat_create_bounce_frame jmp compat_test_all_events - ALIGN /* %rbx: struct vcpu */ -compat_process_mce: +LABEL_LOCAL(compat_process_mce) testb $1 << VCPU_TRAP_MCE,VCPU_async_exception_mask(%rbx) jnz .Lcompat_test_guest_nmi sti @@ -97,9 +95,8 @@ compat_process_mce: movb %dl,VCPU_async_exception_mask(%rbx) jmp compat_process_trap - ALIGN /* %rbx: struct vcpu */ -compat_process_nmi: +LABEL_LOCAL(compat_process_nmi) testb $1 << VCPU_TRAP_NMI,VCPU_async_exception_mask(%rbx) jnz compat_test_guest_events sti @@ -116,9 +113,10 @@ compat_process_trap: leaq VCPU_trap_bounce(%rbx),%rdx call compat_create_bounce_frame jmp compat_test_all_events +END(compat_test_all_events) /* %rbx: struct vcpu, interrupts disabled */ -ENTRY(compat_restore_all_guest) +FUNC(compat_restore_all_guest) ASSERT_INTERRUPTS_DISABLED mov $~(X86_EFLAGS_IOPL | X86_EFLAGS_VM), %r11d and UREGS_eflags(%rsp),%r11d @@ -161,9 +159,10 @@ ENTRY(compat_restore_all_guest) RESTORE_ALL adj=8 compat=1 .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +END(compat_restore_all_guest) /* This mustn't modify registers other than %rax. */ -ENTRY(cr4_pv32_restore) +FUNC(cr4_pv32_restore) push %rdx GET_CPUINFO_FIELD(cr4, dx) mov (%rdx), %rax @@ -193,8 +192,9 @@ ENTRY(cr4_pv32_restore) pop %rdx xor %eax, %eax ret +END(cr4_pv32_restore) -ENTRY(compat_syscall) +FUNC(compat_syscall) /* Fix up reported %cs/%ss for compat domains. */ movl $FLAT_COMPAT_USER_SS, UREGS_ss(%rsp) movl $FLAT_COMPAT_USER_CS, UREGS_cs(%rsp) @@ -222,8 +222,9 @@ UNLIKELY_END(compat_syscall_gpf) movw %si,TRAPBOUNCE_cs(%rdx) movb %cl,TRAPBOUNCE_flags(%rdx) jmp .Lcompat_bounce_exception +END(compat_syscall) -ENTRY(compat_sysenter) +FUNC(compat_sysenter) CR4_PV32_RESTORE movq VCPU_trap_ctxt(%rbx),%rcx cmpb $X86_EXC_GP, UREGS_entry_vector(%rsp) @@ -236,17 +237,19 @@ ENTRY(compat_sysenter) movw %ax,TRAPBOUNCE_cs(%rdx) call compat_create_bounce_frame jmp compat_test_all_events +END(compat_sysenter) -ENTRY(compat_int80_direct_trap) +FUNC(compat_int80_direct_trap) CR4_PV32_RESTORE call compat_create_bounce_frame jmp compat_test_all_events +END(compat_int80_direct_trap) /* CREATE A BASIC EXCEPTION FRAME ON GUEST OS (RING-1) STACK: */ /* {[ERRCODE,] EIP, CS, EFLAGS, [ESP, SS]} */ /* %rdx: trap_bounce, %rbx: struct vcpu */ /* On return only %rbx and %rdx are guaranteed non-clobbered. */ -compat_create_bounce_frame: +FUNC_LOCAL(compat_create_bounce_frame) ASSERT_INTERRUPTS_ENABLED mov %fs,%edi ALTERNATIVE "", stac, X86_FEATURE_XEN_SMAP @@ -352,3 +355,4 @@ compat_crash_page_fault: jmp .Lft14 .previous _ASM_EXTABLE(.Lft14, .Lfx14) +END(compat_create_bounce_frame) --- a/xen/arch/x86/x86_64/entry.S +++ b/xen/arch/x86/x86_64/entry.S @@ -24,7 +24,7 @@ #ifdef CONFIG_PV /* %rbx: struct vcpu */ -switch_to_kernel: +FUNC_LOCAL(switch_to_kernel) leaq VCPU_trap_bounce(%rbx),%rdx /* TB_eip = 32-bit syscall ? syscall32_addr : syscall_addr */ @@ -89,24 +89,21 @@ test_guest_events: call create_bounce_frame jmp test_all_events - ALIGN /* %rbx: struct vcpu */ -process_softirqs: +LABEL_LOCAL(process_softirqs) sti call do_softirq jmp test_all_events - ALIGN /* %rbx: struct vcpu, %rdx struct trap_bounce */ -.Lprocess_trapbounce: +LABEL_LOCAL(.Lprocess_trapbounce) sti .Lbounce_exception: call create_bounce_frame jmp test_all_events - ALIGN /* %rbx: struct vcpu */ -process_mce: +LABEL_LOCAL(process_mce) testb $1 << VCPU_TRAP_MCE, VCPU_async_exception_mask(%rbx) jnz .Ltest_guest_nmi sti @@ -120,9 +117,8 @@ process_mce: movb %dl, VCPU_async_exception_mask(%rbx) jmp process_trap - ALIGN /* %rbx: struct vcpu */ -process_nmi: +LABEL_LOCAL(process_nmi) testb $1 << VCPU_TRAP_NMI, VCPU_async_exception_mask(%rbx) jnz test_guest_events sti @@ -139,11 +135,12 @@ process_trap: leaq VCPU_trap_bounce(%rbx), %rdx call create_bounce_frame jmp test_all_events +END(switch_to_kernel) .section .text.entry, "ax", @progbits /* %rbx: struct vcpu, interrupts disabled */ -restore_all_guest: +FUNC_LOCAL(restore_all_guest) ASSERT_INTERRUPTS_DISABLED /* Stash guest SPEC_CTRL value while we can read struct vcpu. */ @@ -220,8 +217,7 @@ restore_all_guest: sysretq 1: sysretl - ALIGN -.Lrestore_rcx_iret_exit_to_guest: +LABEL_LOCAL(.Lrestore_rcx_iret_exit_to_guest) movq 8(%rsp), %rcx # RIP /* No special register assumptions. */ iret_exit_to_guest: @@ -230,6 +226,7 @@ iret_exit_to_guest: addq $8,%rsp .Lft0: iretq _ASM_PRE_EXTABLE(.Lft0, handle_exception) +END(restore_all_guest) /* * When entering SYSCALL from kernel mode: @@ -246,7 +243,7 @@ iret_exit_to_guest: * - Guest %rsp stored in %rax * - Xen stack loaded, pointing at the %ss slot */ -ENTRY(lstar_enter) +FUNC(lstar_enter) #ifdef CONFIG_XEN_SHSTK ALTERNATIVE "", "setssbsy", X86_FEATURE_XEN_SHSTK #endif @@ -281,9 +278,10 @@ ENTRY(lstar_enter) mov %rsp, %rdi call pv_hypercall jmp test_all_events +END(lstar_enter) /* See lstar_enter for entry register state. */ -ENTRY(cstar_enter) +FUNC(cstar_enter) #ifdef CONFIG_XEN_SHSTK ALTERNATIVE "", "setssbsy", X86_FEATURE_XEN_SHSTK #endif @@ -321,8 +319,9 @@ ENTRY(cstar_enter) jne compat_syscall #endif jmp switch_to_kernel +END(cstar_enter) -ENTRY(sysenter_entry) +FUNC(sysenter_entry) ENDBR64 #ifdef CONFIG_XEN_SHSTK ALTERNATIVE "", "setssbsy", X86_FEATURE_XEN_SHSTK @@ -331,7 +330,7 @@ ENTRY(sysenter_entry) pushq $FLAT_USER_SS pushq $0 pushfq -GLOBAL(sysenter_eflags_saved) +LABEL(sysenter_eflags_saved, 0) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $3 /* ring 3 null cs */ pushq $0 /* null rip */ @@ -385,8 +384,9 @@ UNLIKELY_END(sysenter_gpf) jne compat_sysenter #endif jmp .Lbounce_exception +END(sysenter_entry) -ENTRY(int80_direct_trap) +FUNC(int80_direct_trap) ENDBR64 ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP pushq $0 @@ -474,6 +474,7 @@ int80_slow_path: */ GET_STACK_END(14) jmp handle_exception_saved +END(int80_direct_trap) /* create_bounce_frame & helpers don't need to be in .text.entry */ .text @@ -482,7 +483,7 @@ int80_slow_path: /* { RCX, R11, [ERRCODE,] RIP, CS, RFLAGS, RSP, SS } */ /* %rdx: trap_bounce, %rbx: struct vcpu */ /* On return only %rbx and %rdx are guaranteed non-clobbered. */ -create_bounce_frame: +FUNC_LOCAL(create_bounce_frame) ASSERT_INTERRUPTS_ENABLED testb $TF_kernel_mode,VCPU_thread_flags(%rbx) jnz 1f @@ -618,6 +619,7 @@ ENTRY(dom_crash_sync_extable) xorl %edi,%edi jmp asm_domain_crash_synchronous /* Does not return */ .popsection +END(create_bounce_frame) #endif /* CONFIG_PV */ /* --- CODE BELOW THIS LINE (MOSTLY) NOT GUEST RELATED --- */ @@ -626,7 +628,7 @@ ENTRY(dom_crash_sync_extable) /* No special register assumptions. */ #ifdef CONFIG_PV -ENTRY(continue_pv_domain) +FUNC(continue_pv_domain) ENDBR64 call check_wakeup_from_wait ret_from_intr: @@ -641,26 +643,28 @@ ret_from_intr: #else jmp test_all_events #endif +END(continue_pv_domain) #else -ret_from_intr: +FUNC_LOCAL(ret_from_intr, 0) ASSERT_CONTEXT_IS_XEN jmp restore_all_xen +END(ret_from_intr) #endif .section .init.text, "ax", @progbits -ENTRY(early_page_fault) +FUNC(early_page_fault) ENDBR64 movl $X86_EXC_PF, 4(%rsp) SAVE_ALL movq %rsp, %rdi call do_early_page_fault jmp restore_all_xen +END(early_page_fault) .section .text.entry, "ax", @progbits - ALIGN /* No special register assumptions. */ -restore_all_xen: +FUNC_LOCAL(restore_all_xen) /* * Check whether we need to switch to the per-CPU page tables, in * case we return to late PV exit code (from an NMI or #MC). @@ -677,8 +681,9 @@ UNLIKELY_END(exit_cr3) RESTORE_ALL adj=8 iretq +END(restore_all_xen) -ENTRY(common_interrupt) +FUNC(common_interrupt) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL @@ -707,12 +712,14 @@ ENTRY(common_interrupt) mov %r15, STACK_CPUINFO_FIELD(xen_cr3)(%r14) mov %bl, STACK_CPUINFO_FIELD(use_pv_cr3)(%r14) jmp ret_from_intr +END(common_interrupt) -ENTRY(entry_PF) +FUNC(entry_PF) ENDBR64 movl $X86_EXC_PF, 4(%rsp) +END(entry_PF) /* No special register assumptions. */ -GLOBAL(handle_exception) +FUNC(handle_exception, 0) ALTERNATIVE "", clac, X86_FEATURE_XEN_SMAP SAVE_ALL @@ -880,92 +887,108 @@ FATAL_exception_with_ints_disabled: xorl %esi,%esi movq %rsp,%rdi tailcall fatal_trap +END(handle_exception) -ENTRY(entry_DE) +FUNC(entry_DE) ENDBR64 pushq $0 movl $X86_EXC_DE, 4(%rsp) jmp handle_exception +END(entry_DE) -ENTRY(entry_MF) +FUNC(entry_MF) ENDBR64 pushq $0 movl $X86_EXC_MF, 4(%rsp) jmp handle_exception +END(entry_MF) -ENTRY(entry_XM) +FUNC(entry_XM) ENDBR64 pushq $0 movl $X86_EXC_XM, 4(%rsp) jmp handle_exception +END(entry_XM) -ENTRY(entry_NM) +FUNC(entry_NM) ENDBR64 pushq $0 movl $X86_EXC_NM, 4(%rsp) jmp handle_exception +END(entry_NM) -ENTRY(entry_DB) +FUNC(entry_DB) ENDBR64 pushq $0 movl $X86_EXC_DB, 4(%rsp) jmp handle_ist_exception +END(entry_DB) -ENTRY(entry_BP) +FUNC(entry_BP) ENDBR64 pushq $0 movl $X86_EXC_BP, 4(%rsp) jmp handle_exception +END(entry_BP) -ENTRY(entry_OF) +FUNC(entry_OF) ENDBR64 pushq $0 movl $X86_EXC_OF, 4(%rsp) jmp handle_exception +END(entry_OF) -ENTRY(entry_BR) +FUNC(entry_BR) ENDBR64 pushq $0 movl $X86_EXC_BR, 4(%rsp) jmp handle_exception +END(entry_BR) -ENTRY(entry_UD) +FUNC(entry_UD) ENDBR64 pushq $0 movl $X86_EXC_UD, 4(%rsp) jmp handle_exception +END(entry_UD) -ENTRY(entry_TS) +FUNC(entry_TS) ENDBR64 movl $X86_EXC_TS, 4(%rsp) jmp handle_exception +END(entry_TS) -ENTRY(entry_NP) +FUNC(entry_NP) ENDBR64 movl $X86_EXC_NP, 4(%rsp) jmp handle_exception +END(entry_NP) -ENTRY(entry_SS) +FUNC(entry_SS) ENDBR64 movl $X86_EXC_SS, 4(%rsp) jmp handle_exception +END(entry_SS) -ENTRY(entry_GP) +FUNC(entry_GP) ENDBR64 movl $X86_EXC_GP, 4(%rsp) jmp handle_exception +END(entry_GP) -ENTRY(entry_AC) +FUNC(entry_AC) ENDBR64 movl $X86_EXC_AC, 4(%rsp) jmp handle_exception +END(entry_AC) -ENTRY(entry_CP) +FUNC(entry_CP) ENDBR64 movl $X86_EXC_CP, 4(%rsp) jmp handle_exception +END(entry_CP) -ENTRY(entry_DF) +FUNC(entry_DF) ENDBR64 movl $X86_EXC_DF, 4(%rsp) /* Set AC to reduce chance of further SMAP faults */ @@ -988,8 +1011,9 @@ ENTRY(entry_DF) movq %rsp,%rdi tailcall do_double_fault +END(entry_DF) -ENTRY(entry_NMI) +FUNC(entry_NMI) ENDBR64 pushq $0 movl $X86_EXC_NMI, 4(%rsp) @@ -1116,21 +1140,24 @@ handle_ist_exception: ASSERT_CONTEXT_IS_XEN jmp restore_all_xen #endif +END(entry_NMI) -ENTRY(entry_MC) +FUNC(entry_MC) ENDBR64 pushq $0 movl $X86_EXC_MC, 4(%rsp) jmp handle_ist_exception +END(entry_MC) /* No op trap handler. Required for kexec crash path. */ -GLOBAL(trap_nop) +FUNC(trap_nop, 0) ENDBR64 iretq +END(trap_nop) /* Table of automatically generated entry points. One per vector. */ .pushsection .init.rodata, "a", @progbits -GLOBAL(autogen_entrypoints) +DATA(autogen_entrypoints, 8) /* pop into the .init.rodata section and record an entry point. */ .macro entrypoint ent .pushsection .init.rodata, "a", @progbits @@ -1139,7 +1166,7 @@ GLOBAL(autogen_entrypoints) .endm .popsection -autogen_stubs: /* Automatically generated stubs. */ +FUNC_LOCAL(autogen_stubs, 0) /* Automatically generated stubs. */ vec = 0 .rept X86_NR_VECTORS @@ -1183,6 +1210,7 @@ autogen_stubs: /* Automatically generate vec = vec + 1 .endr +END(autogen_stubs) .section .init.rodata, "a", @progbits - .size autogen_entrypoints, . - autogen_entrypoints +END(autogen_entrypoints) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:28:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:28:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576867.903498 (Exim 4.92) (envelope-from ) id 1qRoI8-0002Rk-E7; Fri, 04 Aug 2023 06:28:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576867.903498; Fri, 04 Aug 2023 06:28:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoI8-0002Rb-BV; Fri, 04 Aug 2023 06:28:04 +0000 Received: by outflank-mailman (input) for mailman id 576867; Fri, 04 Aug 2023 06:28:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoI7-0002N8-3y for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:28:03 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0626.outbound.protection.outlook.com [2a01:111:f400:fe0e::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f856222-3290-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 08:28:01 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:27:59 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:27:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f856222-3290-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmXQcmb5VAeeXY7500tmOnrHEZ7BMb0QH1HdJ1bZJBb7B6L1uarMCpYCjdVO1nk7m4qm9B1OH+ySoFy2mQ3Ca+oGaI+/6hIijYtbE/hLMUZNjhyVUYJePIAlLk1uo+OFIZoaBfLf5FEVnESmoYHHkJFWQILM6fMIqqD9aHbKjEdqtVqn7JmOkZEv3EO7vZyNoeQoHY7jZRqZml9XIOjVNVwvB2dEglHWpO30TxmKpRMfbgd5Kol0yh01DlrWM4j8fXHjCj4tH0gGMne4dvgWcw9w9CO6vaxG0Xe+5cvUDo2thZqHuyCzkrSApHfucJBLs3WGzfthwndPm7/KXYHsNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bxqTYAMqHDtwTsaXt5W2izXbr1PoTAZ70AuZ6hPpGqA=; b=Hzeq8KGKWMKgaTZq4tO5BLrEPSwV0dIW3/04kJUAfiVN0ClNJz67iP4Asv4UfjBaRUpuC7NpIKZ7C+bTmcAuKFv5zCUa858worpdhMN+g36GPba88ul/aTDp+/wGcNdXutNFpdcPJHNu0tbLIbD1/r4/wc4HeNjJrQSEoO7lZThbKRFMI+O+u8BHGuEdfV9h6/DCLbScONIcUEKOGIGB9iL7DWDOmw5pI3scE5lAi6c6uA8dgrvF5wIyv7EjyYovPptO0M86a/w+8N0miH2wk/d2FRTC+xG4zKB2paBLwEMjsJdzrhf7IZOjqqgWc9MrJ11jATOQ3b32gfr/HSfAzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bxqTYAMqHDtwTsaXt5W2izXbr1PoTAZ70AuZ6hPpGqA=; b=IdUvyZWUWUnfYBIqNaqq1O8tiAOM5N90Gg0IUpzsuu8NmnD2KNqr79fNMMlGnvaZUCkCci5eIgsjT4yD7DDWUAS0cb+ACjS7j4l92+q2MOBl+1SthyWay32gKkquvsMbDGR6eCNUMCA1KdH84Rsmov/2q+E++4VdTblu1AaMmOaLsZiT4G3gu/nuk//qanBeoccA5ZDCiATEewKyuN3XCPcWwjzJYGcZYItu3dgOekpBS64aJXphwH+ru0IMP5d7pqN8+VF/gUkgnGS95hisFL/8SJ2UoMTbYGpMfhhV/AEr8XzAN2XUYq2h2ybEsy+fepaARJCLDRrdxdFMaKuf5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29f404eb-e5c9-fb1a-e60a-47d4dc77578e@suse.com> Date: Fri, 4 Aug 2023 08:27:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 3/8] x86: also mark assembler globals hidden Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::23) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ced7ace-56d8-41c9-db83-08db94b3f2bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rl4RFUex+Nm08t8dyQ0ELwJIMCxxc4nDVySDnhLQklu2sUUrK3STQYg0wchr7WHWjAR477MYagGiH0Lv04++W50IZJ/GF5sn14sDeqpHel6vrzOwo4FRd/AomnvHvSLMHTYM48WWlxJnh/iiTKzd4rK/D7eI1BYzrLZCYWQlJXmA5XVvGdUGdr8aX2QOeRjZ1jxBJcW1giGLTw4rNWPzdvV8pPbcoFm2tij3mY3rwuOTl8vZ7wUwESp4ke1ZAV24TB756NMCoQDFBgZOF0sq1NHybLFs35nDAIb2vFZ5SPr7Vj6CDg6VcJhzBgqEb5pLRBkYuCQ8CFdz1krtl15Qz9aZv8UPE1Eyb5ih92/o/lfphxpW40sY2JrUnpVSlwNudHRZCvkui5cO7ZzNI6Z4QYxjH7MHcSkawq3fVx7uiqEmXrnTdHLPrYX4BF2Ny8kTCQ0eNpQHBcT9je1PoT3R4HBsX/EGNw5wLa614vWpJgXvj/AxNMhmdpq0hvvtZfHUb/j2awAH/MCy0zqNhmR14HkfULIgByjXOYvWdBQc55RIfwU+zjJSN1pAdGEqZ+pAPEXckQHvYqjqzVxscEzSDJTJfWPN7Fgfo+tD62vXd+dhmHrJ3tJvjLk49Gta1hNScjV3CwPWQd1gRxpBqTmlqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(478600001)(31686004)(38100700002)(2906002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2g1bHErcHUyRGlOa3pkMVVmbTMxSkdqZi9CV2hDaEJhaDhvWXNReGhkbDE3?= =?utf-8?B?YjBCblBBdytvaGZrN3lBZlgrSE00b1RoZDBWSkFwTUMrbktya3BNMVhoaEcx?= =?utf-8?B?QzFYeFd1NlE2ejJGT3doMy9hRVBXWDYvOHBmZ2g4aVBNdlk2UjNBMVhvcktm?= =?utf-8?B?UlowK1dkOEFzNWt3SldWVGNlQnJvbGw4eUJLRmpPNGxaNFUzdGIxK09PS1ZF?= =?utf-8?B?UjRMMmU3VUcxdllzNU1mcE0ydkl5ZkRqZ2o3LzBzWlROWEdNRmpVbE5LYTh3?= =?utf-8?B?ek85VkhDQjBMZ3RJMmhKcjlYaWtQVWphbEtscUxQZTQ3ZDdyODVNM2paMDVa?= =?utf-8?B?MjhUMVFsMDVWaERXS1htWmxVUzJobWpDOWZockpranBMQlVQb3FVaEpkNEpD?= =?utf-8?B?bHFKM1d2R0lYUCtsTFJrQUM2MDJjVHFDSU5qZXVuaWRXUHFRbWtnNU8vM0t6?= =?utf-8?B?VXRTc0VnN3dDa2xCSzNVRXBHL0tsQWV1K2kxQWJtak96VjNTcGhZdkJZODBk?= =?utf-8?B?NUV2QXR6ZXBBbGtqN1RsdVVZL204UVlRRVlCWW1kOEV0VnBEdjR1WHN3TGov?= =?utf-8?B?U1VHYThia0pQZklpOGpaTGlXRGNqOXNlS2ZZbURGN3JWcXluMzVvb292cXdR?= =?utf-8?B?QTJlMnRvdy90Ky9YR0lpRmR3WG1UVmJwMzlUWVR3L21XbDEyMXc5aHAwSncr?= =?utf-8?B?UkZzZmg3ZjJNSkZ2Rmt5SW10U094bnM0SnU5MkRQTGVWK1FjYTVOL01QNjVJ?= =?utf-8?B?THFsYWJQOEZ4emJBSE1XYllyOVhDbUZIN1dsSTZuaXJ0and2R2hMc3VOTE5P?= =?utf-8?B?aGZhYUlraW5XWnNZY21yT2J5V2didXB4Vm9DTUQxVVJzMUVEdnQxeWtneHpY?= =?utf-8?B?TFp1MjVITTNQMnlGY1ZZUVI3aDB1ZGV4MGZaWW9RWjNxbjRtV0UzSGhudCtD?= =?utf-8?B?TllrU3RZTHJkU0t1Zit6RS9zUE1BdklGNjlvYW9vcml3TGdLTjNobTBpSHJJ?= =?utf-8?B?bjZ4c1VudUlTdm5tb0k1V2ZiY1dCQnlCTHJXT3ZhMSszSWZaVkRNc1VsL1Nn?= =?utf-8?B?aStyUDdqTmNkRm9oY28yK1k2MG02UnNpbXBaUHVQaGdhaFp5RlVWenkxWFFp?= =?utf-8?B?Y1RuMHBmclpOUXl4cEVQMzZrSzRaVjJnRkpMaU56dmRDMWR5NEpWUWx4VXBV?= =?utf-8?B?QXZ2ZG1aOVhRWjlFZGFpQWNuN0ZVWHdWUmlmQzBOTjArS3UwSFlDblBUdmtC?= =?utf-8?B?TjE2dW5MMTQ1dk9JbGY3dTJtbjd3RTJ1VXdjWXVwQ3hKTkIxQUh6R3p6ZWla?= =?utf-8?B?OFdsc2N0TTcyTmNnWVcwS3J2NXhOY2tBekN3VFhXcWdVSnpvTy9NUktiVnNF?= =?utf-8?B?bjVqMDNGY094UXVIcGhaemgzRWd3dU5RTlVGM1RqandWczdsSEZDZjdmaFZh?= =?utf-8?B?NGF6Q3JBVFBrUlRkNklqQ043OG11a3FHYkFYZ0R3bnlWYnBJalVuSXhhL2cv?= =?utf-8?B?N01yVTJGQVJIMUtXSXBtZmhKMVRtTUMySFNocHo5bCtwSGNQVlhEM1hHYllx?= =?utf-8?B?SjFBQUpoN05FY0NFMGZJQUJFU25JVFJpc1NaeTRYM0hoejF6MWdQbVpQQ3NR?= =?utf-8?B?Q0x4Y3I0QWJsOEphN2JiWHBEcEhTQXRxYWR2UjN4MzUyOWNiMlRVcDh4Qlpi?= =?utf-8?B?VmhaL1V2b1RyOWtyYU1PNjByeHk0U1FudFZEeURjS3J1aW1saEpyTjBjemk2?= =?utf-8?B?VkRNNDdUUXdqNVp1WG5HRXRzRjVVZkttdnBnTXFMb2JSMHk3b3pZclVKT3ZU?= =?utf-8?B?NTRUYmRpb3VrSktDeTVhbzNkdWgyYWgyWm1mN25HVlduNGlFKy91aFNSWi9h?= =?utf-8?B?d2MzV3R6cEZ4b21lODcvS0FaWnEzVnpBcFBVVnF2SDBvMnVhdE1USTNrZ0xS?= =?utf-8?B?TisxL2Rha1QvTGlMUGdLc1RIT29iS25aeUVZb05rdis3K25MM3ZmZmdPR2Fr?= =?utf-8?B?WUFPVHY5VjhCYm5Md21uc1VLZ2sxMWNXaGxSd2F4bEoySW96bzdYN1MwM0Jr?= =?utf-8?B?RXRZUHlod1lxZldzb0J2eUdNbE4zSjg1eWlLb05USUpGaXE3MG9RTFYzNDh3?= =?utf-8?Q?OVpcZKyLRx+HC4dpf8jxlI+Ro?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ced7ace-56d8-41c9-db83-08db94b3f2bf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:27:59.7027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3D4AWl7BLojvCUKyhf9Z5B67qSTKpxebycLVSTdXNGhweR111Ope2gEOAzgh5GTKyZkisWs3kMeX3wVy3HFewQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Let's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau MonnĂ© --- v3: Re-base over generalization of the annotations. v2: New. --- a/xen/arch/x86/include/asm/config.h +++ b/xen/arch/x86/include/asm/config.h @@ -47,11 +47,11 @@ #define CODE_FILL 0x90 #define ALIGN .align CODE_ALIGN, CODE_FILL #define ENTRY(name) \ - .globl name; \ ALIGN; \ - name: + GLOBAL(name) #define GLOBAL(name) \ .globl name; \ + .hidden name; \ name: #endif --- a/xen/include/xen/linkage.h +++ b/xen/include/xen/linkage.h @@ -21,7 +21,7 @@ #define SYM_ALIGN(algn...) .balign algn -#define SYM_L_GLOBAL(name) .globl name +#define SYM_L_GLOBAL(name) .globl name; .hidden name #define SYM_L_WEAK(name) .weak name #define SYM_L_LOCAL(name) /* nothing */ From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:28:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:28:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576872.903509 (Exim 4.92) (envelope-from ) id 1qRoIu-000333-RZ; Fri, 04 Aug 2023 06:28:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576872.903509; Fri, 04 Aug 2023 06:28:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoIu-00032w-Oq; Fri, 04 Aug 2023 06:28:52 +0000 Received: by outflank-mailman (input) for mailman id 576872; Fri, 04 Aug 2023 06:28:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoIt-0002sK-Uk for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:28:51 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20629.outbound.protection.outlook.com [2a01:111:f400:7e1b::629]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d461186-3290-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:28:51 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:28:49 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:28:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d461186-3290-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DAwIm7t/p59NATT5GUxBa9UY5w0LT4rTpdYOEa53UMmsA2s8IKTmjW0xuwCL3ItYin2skl8nymY+IXDC/ce4h5SdzAuf9n6xWb7nI8JoqlpBEV8k/Sl1Dqj6l6Qv2rowMIhR/b0skKmRnJOw1IP7tdQRE8c3i5cMwiVdN+qwkEpvDToCzmzgOgu9qHGkwOojjJem6tbzTiC/xHRy7jDLNkwTpgi1jgt5xEHSbvlJdC+Cu6cgIxcqftgCIXNf9E+ogGlsxbyqLnx2mMa+6giErBTYFKTAITnVY+HoFjcXCrzdX8gOjtqNydxxcZrkMZ9Gnn3HuoqHRv/HBL+A6L9obg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bblEvpBVoD14a8jtWBS2FnTxPcXC/Rz9Fz+d/NPUWJs=; b=HBQirrIYTFNN5bX/rVpT/Aq/D/U3MkowqWXWtTHJSwgRtz/wa6bYNOtlHVWr7KcoeW1fTHL+Qa3VAxgWbgXLq4xS1OKiKOxwVMKCbudVA4RdzxJ4SsIq4S7+q5O/sRvxj6pdcR2I/arho/tJ4EvO6wizdhnHu/sNUpd3yAB05MdRqOKp5/zkOCcEa4haoAVnud+D8Mo2+9fTOh2soZ4nPzeWiSpHVq/Ea2tOD5xSJgy8P341hLsBjj81RKdPNgf9NPSarCA4ZBY6zKHaeyl3lLquYjVAeH3zqxXu4cj9R7/2f554XeqTr931yU36kZQmDMglfRWYkfaETf4RkgGQNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bblEvpBVoD14a8jtWBS2FnTxPcXC/Rz9Fz+d/NPUWJs=; b=va1cqj3Wc5A9jHdzwb1Ew58MsL/7SPWWxkIgtdU6eAQNnu4yzid0VeU0DKZ892QAlPI21UcAd+kn/E9CI9UzcCkmSU0EvmqA2x0EHGS+OgQjhdXZVIxk+HHTH0z5aCtUwbj298Pv8OV6eAj9tnWN9eit4jcte69bGtyr99dfbVglI8KAeuX7H9+gaziyxb/7YoJnrMaKJEKjyJuCP3b8o8gI9IGt34SWMs/J2dV92NkgYgPqpFENWmpFtEhkMdhgQSkKwiajxNWgYd5yIKk3Yr/BAd1NdZEbdzHcG2BfqHlDTgTb7WYMYW9RIzPoBS7WlN4pWZ6zCH63NzbrwpTbjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 08:28:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 4/8] Arm: annotate entry points with type and size Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: b92fb431-0328-4079-04d1-08db94b41093 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C9KNJo03jiSHm2NtZc41XT+yy7OFz+SSzThnYQYrw3S294auz+cVPllf9k14OQ/O110gNK0JzkVHxEumE0YkEyGW80lJVctPsFoCPidlJ31PvuKGcmtVjXypbvxHMaBx1p8evJy4mIiWKxfc5uT9awUYe9XBXUFZhKY86v3BC/9Ba8dvhucp3hUOC036rJd4Fj+LDuJzacEm3Bafod20SBUyTHYxdTnAshtZVk9Pk97NlL19kA9BMaanBvUocCZWuKKJv4xeVSiuMaTWcNIv03kv9ny6p7embBCTlFFKMMwdjhxlunWB9bd4wldhZ/7frOwZvoadJMWCPg5zW1RGoCb8v41y0bZRsKAWwrW12MH1GE2hmxqKntL0br15nt4AvKOL7xMyMPK5UZ2mzZ9gJHoUSyzkKMignxfBSF1FTdmto4KRYXKpJBAg6s33fVA9OSs4v6xgc8rHHQLGdnO9GT2SiES3t2LW6KTt0YCxv1BbdmEEOWaaC2bu90bv9hRmtvSdmDJ8F8eNkAziVEpwNIHOWSUP1Tv17nyQj1pawL+2BguwDF4oOTqtD9jHamO9MJyLJExx4AiZ7zk/LoKKIH9PpGxFUNM8EL5WaEvZ6L4W4YswCsImD+UYzTwNc0nSGYg2YYp7XXf2t8kDOd9gHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(478600001)(31686004)(38100700002)(2906002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d09RM25UZlRYSTNSZDAwcEVqRHlEdlU0QU8waGt5QnJPdi9pbGN1N1B0WUg4?= =?utf-8?B?bHc2Z0Q2SFY3YVBmcTZGUVZ2NTVrblM5bDNwczBmcnF5SkZiVmNZNzlaZnlz?= =?utf-8?B?QUVmUEg0ZHIyUHMyTjdnZGxoaDlGdjBmVVV6Vy9iSDFySlhiWXlyRWpQTm5k?= =?utf-8?B?WWVIM2pJYXhWNURhWjNQYnVJTjRFVk12ekdFN3diZzdnK2k2aFJlMWp4S3o2?= =?utf-8?B?THUwRk85RjNDSCtKZ2QySW84NjAxN0FtOWhuOTZMNWNxL0RudFBRcHp3d1lL?= =?utf-8?B?aGpuNmQ5akF1MVptM0M1UlRRTlhUVDBxLyt2TzVqa3graVhudmlobG1aWkp1?= =?utf-8?B?N045QzJQNTQzMEh4MTBrcFJvUnlCaXFhcHJBbVFzUVZEaUFWTDZYQWN2OGdD?= =?utf-8?B?TFFsOUlIZW1zWmhQWmRaSVczSzUrTkE2RVRPUjNYbUwycmRvQU1DQmtVMkpK?= =?utf-8?B?bmtTN1ZtbkQ5aGw1RTE3MTdQZHpnTUxkakVqOXY1akxIUUNPb1ZPT0szTVZY?= =?utf-8?B?UUhuMmk5WHhzd1dJdDhmSDhsS3NuVmoyVDErcEtRbzdDQkljT1JmZy9HOFZ4?= =?utf-8?B?UXVsczJ0bmh4NUp6YkdhRTNXRHdHLzA2UllzMWE5UEFsOTUzQ2Y5bklWUnhp?= =?utf-8?B?RElDWTdGRnVVUzl5TVc5TjBOSE96ODNSeEp1V3QxYVJJT0lkVUpsVEJZMGhO?= =?utf-8?B?Uk9ZTk1lZXdhUnprbi82bHlGKzl5R2dIeEFpYmdHS3EwdXMzSjZCcnJ1eUVv?= =?utf-8?B?RDRCR2xKV25mVTlxNmF6NFJ3SGd3dGs4OTN2RmY3b1hNdS91cWM5a3FvaC82?= =?utf-8?B?RmpzTE54K2diNEREUG5WOTA4RHFYdHA0Kzl2SzMvOWI5SjhuZ3ZYUjBIN0pK?= =?utf-8?B?TUtzOGhSVTZWcHFjRFhrSVo2RVVZWVJFem9qeWIvc3p0QmIyMWtaM25qZy9F?= =?utf-8?B?cHZWek9YRU1EbEF2UzdHN25yU1ZlSHBSNlVZRTYzVVAvc3plVFRIN0RSVmxN?= =?utf-8?B?eGRWbTQzSW5PZDdQZXZlQnF0LzVvdkNUSWJHUUdEbHpFdXRCOUpkaFBsNGti?= =?utf-8?B?T1NodTZVVU1GdzRreFZENFBqeVpPa0xFcGRWKy9XdGkreng2bzh1MURrR3Vr?= =?utf-8?B?UEx1dm1xdS9NYWpLdU4weHlNZkljUGRwVHJYK3ZlSk1KMmUyYk1WSFFNdW1Z?= =?utf-8?B?N2VCZlVSRWRJd2NlMTN4akorYmo1QzJ0UzUweHBkSFhva0RIdEdRall6N044?= =?utf-8?B?aE9Qc0FaeThqSTlDSXdKYnV5Y1NBVVJwM2tndG5sWFJ3T05QTUkyR3RQU0Yr?= =?utf-8?B?eE1JVFVFUmk0SERqMFc4VW00L0F1aENJODYvZG56bzlLN1R3c0tNWlRLNHJK?= =?utf-8?B?T0JsYUxBY2pwb1k3b3ZLdzBuTVhPRDZsOXBRVTFrRjRUWHJ6ZEhCN3p4d3hF?= =?utf-8?B?bUl3VVJWQTNJYjRKWEgzYWxOcTVpOG9VUlB0TXpGYmQyd2RrNS9kTjFSUlpG?= =?utf-8?B?Zlh5NGUyMXFUQlFyWWdMaXMzb2pCZERwZ1R2RlVELzVxcU9GTDJpZ0VuRlQ5?= =?utf-8?B?dTc3dDJ5eFFwNmcrVGxYY0VQS3piMHl5ZkJOQ3lEbzlSbks5RHpaYWpDV0ZZ?= =?utf-8?B?OUY4aUU3aHVMNTF4aTcrQzVkZEZpTGJUeG14MXAwOENyclpPaklranZQWURY?= =?utf-8?B?OUZrRC8zamlCenpwMElMZUhkSjg1RnFGbTE1T3Y4ME9FVHM3eGd4Y3ptdkJS?= =?utf-8?B?UUR5OFV4STBqOEFCOExzV2xOM1FjSldBa1FGckR6b1NnY2VOaXhwZnZkOWdP?= =?utf-8?B?ZUdINmtFQ2pUYnROTlJwZHNLRml4RnAyTTlpUFJMZ2l5MVgvYXRZRXpoMzln?= =?utf-8?B?RlpEc04yNGpFbzFBOUN0VWRsWFpOVUZDWUJLV2J3bitMQVp6SDgvdE1sc0to?= =?utf-8?B?L0lIMnhoWVpTVU5ra2RTVzQwOTJBdWcvT1FxZ3NOeENyTUFVWHNDRSsyN1A2?= =?utf-8?B?T3Vod09xNmpPekVmT1NYTUlqSGU0UElvb0l4Wk1RRGd6US9UTHR6bFY5Y3Vw?= =?utf-8?B?V25sUnZVcTlBN0w1cThuVnJYYy84VTIvS3lCdlFObzAzOHh6dVk0VXdmQWR6?= =?utf-8?Q?uhpC8/RkJYPFmwCTMiCnNNtze?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b92fb431-0328-4079-04d1-08db94b41093 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:28:49.7623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7ODH2L1NH/UcFL5Q8/2ygdm4sej1aI6yGeWojn4fVcYJyr8TpZJSqmEkNlRY8Jon7/uEUS+LMjxzM7RzOUJTpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Use the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones. Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway. Signed-off-by: Jan Beulich --- Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches. The ASM_INT() redundancy of .global will be eliminated by a subsequent patch. --- v3: New. --- a/xen/arch/arm/arm32/lib/div64.S +++ b/xen/arch/arm/arm32/lib/div64.S @@ -42,7 +42,7 @@ * Clobbered regs: xl, ip */ -ENTRY(__do_div64) +FUNC(__do_div64) UNWIND(.fnstart) @ Test for easy paths first. @@ -206,4 +206,4 @@ Ldiv0_64: ldr pc, [sp], #8 UNWIND(.fnend) -ENDPROC(__do_div64) +END(__do_div64) --- a/xen/arch/arm/arm64/lib/clear_page.S +++ b/xen/arch/arm/arm64/lib/clear_page.S @@ -22,7 +22,7 @@ * Parameters: * x0 - dest */ -ENTRY(clear_page) +FUNC(clear_page) mrs x1, dczid_el0 and w1, w1, #0xf mov x2, #4 @@ -33,4 +33,4 @@ ENTRY(clear_page) tst x0, #(PAGE_SIZE - 1) b.ne 1b ret -ENDPROC(clear_page) +END(clear_page) --- a/xen/arch/arm/include/asm/asm_defns.h +++ b/xen/arch/arm/include/asm/asm_defns.h @@ -5,6 +5,7 @@ /* NB. Auto-generated from arch/.../asm-offsets.c */ #include #endif +#include #include /* Macros for generic assembly code */ @@ -28,10 +29,7 @@ label: .asciz msg; .popsection #define ASM_INT(label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, %object + DATA(label, 4) .long (val); END(label) #endif /* __ARM_ASM_DEFNS_H__ */ /* --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -53,7 +53,8 @@ /* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define CODE_ALIGN 4 +#define ALIGN .balign CODE_ALIGN #define ENTRY(name) \ .globl name; \ ALIGN; \ @@ -61,8 +62,6 @@ #define GLOBAL(name) \ .globl name; \ name: -#define END(name) \ - .size name, .-name #define ENDPROC(name) \ .type name, %function; \ END(name) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:30:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:30:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576878.903519 (Exim 4.92) (envelope-from ) id 1qRoKC-0004W4-4e; Fri, 04 Aug 2023 06:30:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576878.903519; Fri, 04 Aug 2023 06:30:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoKC-0004Vx-1e; Fri, 04 Aug 2023 06:30:12 +0000 Received: by outflank-mailman (input) for mailman id 576878; Fri, 04 Aug 2023 06:30:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoKB-0004V1-An for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:30:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5beb0a1e-3290-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:30:09 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:29:40 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:29:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5beb0a1e-3290-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hzcTy7tsLGD4M3lihdyD+9F1mHuoPohJar9VPN5V/2LM8NbbJpyEcu/uCegT3N5fLhs86jh32V0AmT7haB4QzjlQRGAH/FGGdVqs3pajuPHC28/4uW7nOKsP19TyPy8Noh2gY/qvzowL/uSDyzGEOpJx9ZdWUpKodfBmZV5SZKMY0PUqPBO6qec8OGcMRBHZ7rMipYNnuDWAvqlwLU4bnkYeObPkPIcayOGivbbDJmKnMnkZw2mkta4O8VB9qJkspnGJkoXtCk8VV7VYu1hFK6E+XKq9l86VLfLpumYcjse4L4Rq4A10ufaZev5sq0h9zGE3ZiZmOIkCInrtWOoBtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qika2Hq3tzyX7MA+htBUWEOe4yA4IGhKPbZp6tX/5Qo=; b=oL5ZjMAkjJouQSAwpTKfuoSgf8uU7/JVTVqRBYs2eZJy0kv8cP4vFJOXubXbPARGScxL8KnJCBvVNt46gfeh77tYXqA2eORZU4eLwi16jhVa72GG+nl6Avrqx70WOoS0Er48jd18F1MxXRTwzelT9JgkshhcSXfeeom4/4sALZhKlaFyqRcFqmVEWKkpqTBcQdVn5Wcb+2gGluo1/RDShphVHRSMypymGakWz9NqlJChqq5qpR9MBQVg9Ychik3VE1gMG39bAnFX5f4u/nAGgy3l+2QjiuICqcRaP85n25OI3Wll+55g5U+2yTnRP0/4QhLPUrG/0LdmxZBY+d6sPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qika2Hq3tzyX7MA+htBUWEOe4yA4IGhKPbZp6tX/5Qo=; b=nh/OP7khS+yhDOGdULDaL7vlZ3PmoKCMyOyipKF6UC6Z2/ox8Zsfyit9gLnOiVU016yDSvJ3gcr5JWTj4Rt7uxhoztnhIxoQRTHdj3ozhBmVEd/Ff0hP/mR2Kg5n4UMRTjShUBo51vISPh8aYrMxbG97KYYyW276Oi39qyeK1+WHsZZ+sUj4EA+I3qGD6zOT1w4xhIx+jyP3wh7zu0z/HPsL2oISTsiKp95e69/SQcdOQwErNxAqRjUjEjutU5dzN3gepCW6IKS8nkr2OVeAyPVW7CFBbToeDhiydGAaCeIweR8sRrGJSoiaZoDNM2hfwOv60mj6eK8PXmfUTp9tMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5caf1f7c-c4ba-9913-dd77-21562af18efe@suse.com> Date: Fri, 4 Aug 2023 08:29:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 5/8] RISC-V: annotate entry points with type and size Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Bobby Eshleman , Alistair Francis , Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 560464bb-e74c-449d-22a9-08db94b42ee2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BlSoTblrw6r7jiz/lHqs5X9CN5YvIDUiMHaka4C4sN1UxsDU2rl+TEeG8tArxA+HDzvFALcx2GrbbdcUKE42phlu2RScVOYlWdDX44tjU21xPOF4P5DL+lh02zKb1bgif8oWAMnxaSik5iWb+mytfrS9ts/Iiz4CGr9i9h8q1m3VIVtDQxTVxLx9UeVGEUP4Hz1ND6rkdICFpieWxqPMc6R8kJE2VnJXFYDILJyRiIjKRZ3sdMktJffmiB9aDUm07EuQ3TO2I5wlilIw+AMhRYFPxn+01+TmAwmo3NDbI3buABP0MHo3Q91rsOewB8dtU2wdm1GcDpqTewtAnB1t12eLiNFNHGRiXJJnLR5MXWQnwzFebt7p6VsCvgmN9PZH3sXRkjHqirvE2q449nO+KQQhLstjNSlQzR2EQMpguBD1kXcSMMnI0OOcs5at+2ZsF7bkWqBKG1yj9BrMcQu1DWD4V75gLOQLmiTMWewxKKTyfaWhHwpqSPP4RxjJyTQoOg5LRkatAcXMa8qdvwT6sHsZJ9sBwYY2MYXLtwBIwW27pCfvUne1+r7fcXmFtJm3gLCOqzqIOLjFU3pvNSicZu301MjDurK6zCQougGBY8Tq28L/yE05WvBndwDJck3p8R2cM/zNta5h23GMyB95lg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(478600001)(31686004)(38100700002)(2906002)(86362001)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qm0way85TWNBN3J3YTlUN3Y4NkRhWVVMN3k5bzBvNGVkUUtXaklIWUdlWjY3?= =?utf-8?B?UVdQNmtkUWo1a05Wemw3K3VHeVVzL08xQXkrVlVLaUJVbEdZTEtJWVhCSEd0?= =?utf-8?B?dGI4eWZDSm5tTjBFcGpYQ1ZUNTdHRG4rYWh4RWpoL2Q2RDFJRXlCc1FqTHZY?= =?utf-8?B?bUI0VjZvVWkyWTZQVzBuK0xuL2NyWU5NVTVXZHhhRVpPdllUZy9vakhjZ2E0?= =?utf-8?B?ZDdpK0RjOVNNcmtRQ0ZDYi9mNnl3eG40ZGh6WW5vTnQvZVJVZ2xQR3JSc1BM?= =?utf-8?B?dWlJTUpPZmJTNlhvMDIzczg2YUJCSldKTTV6VzZrMFNzaXVKT2pPWUZoUWxj?= =?utf-8?B?eU9BYjZLNHNKTzFKZEg2Q2tjK1ZvbWFzRmxyWHZkSHJzVzgvM0ZlSFY3aENU?= =?utf-8?B?YUhZV1ZwaXZGUWYyTE1pSE4yMHppY3I5WUhnc1cxVk5iSEZJellZOEM1ZERK?= =?utf-8?B?ZjlwVVhHajRCMjdybWFuc3ZQQWFBREVEb3dvL1plb2VJd1g2cVBoTUZQTjNk?= =?utf-8?B?UnJPNExtVmR6Z3JDVGNoTGxUV3hqT081ZmtUSWlzWUorV3dKVHlOYnJhN0pF?= =?utf-8?B?Q2MrZmNyaUllYUdJeHRvVExuYnJORkZ3TWRtdGFpTXM4OXd6VW9MbGJDaEVF?= =?utf-8?B?Q3BOd3pRZy9NbG1JVDk3YVhzMHJPUHNQZFRBTFRKcWFzRU8rekhyTzVGRmdh?= =?utf-8?B?RExocVBSTlZpUzRFM0VNazFXYlVYUXovTlczRGlielpkOGdzRjlYNGdBS3BG?= =?utf-8?B?Uzl2RUZMcGJRUnYzRVFaT3lsZXliZm9kNDRjMWdZZjlpZFZFWjh0NENnWm9j?= =?utf-8?B?anJaSlRLWTMrb3k2VnVOUkZUYnNaMWR6amdKQ0hMbEJyYkk3dzc3UkdIeXAv?= =?utf-8?B?Rkp4SDV0cmg5NkxjbVBhU2JQVkR2WGkrSjFnaWJHQ3FBRHQ0cWg4dnVFMUox?= =?utf-8?B?Q2tqS05QOUFsMXp5TnFGTXh2bDlUK0NVY2NZdUF3REFrcDNKd2wvbHp5akNL?= =?utf-8?B?OUZhbTRwc1BSQlNhUVRDREljRzdlcDFtMkFzSUhuaU1ud2ZyK0VMM1N4ejM3?= =?utf-8?B?RzZjbjNqamRmemswUzArOTZONkhNNGl4Tk9lVFNhRm9oSVdoeEJUeStFM3dC?= =?utf-8?B?UURLeExYMllQT1pyQVBHMUU3dnJsWlI5ejh1NFQrWGNQcXVTNVgwSzVpcmF0?= =?utf-8?B?dWRqYnFFd25LS1UrQVJhN2x3Qm15ZWlZdjRGZ2hycUZtL1labTRCZ0QrbG5v?= =?utf-8?B?MXdFZTExeUVzWUxGckMwclNqR1A5OFJ1R01Sc1BiZGtQQUJyTUZzaFp3YW1a?= =?utf-8?B?bDNXa2xDQ2h4WkxrNGxmTkFtekw3ZHVReUJNdVZDNUZTSGRoKzZxeE83ODhx?= =?utf-8?B?N21wVWpyY1hneXUzME9NemEvbnp6bHA1T2hzT24rbm5zOWlwMzg0ZWFSRngv?= =?utf-8?B?QlNjL1dtTlk3MkVZVUlZemNiUklzUDdScDBob1d0MWhCNmI5aXdCU1RmWThE?= =?utf-8?B?ZENKR1lGMkprMkJId1ZPSHl4ZUxWR2VkaVJEVjZuRjNvenQyM0g0d3lXa3Bq?= =?utf-8?B?ZmJxU2FuckkyTWF4Z0dIaEhUMkRsRUN0VGUvbERpRFhVdWhRenJkOWRsSEtj?= =?utf-8?B?NnNoa3B1MzQxNkhGS2JhWnNWTzhPZkQ4aVRMNllxclAwYmErc0RkNWhzQ0R1?= =?utf-8?B?VGh4Y3VMVm8wZC9LUFZxQ2dLbXpRNHMvRFh5TkFDeEpzN01KdjNPM1FEV2ZM?= =?utf-8?B?QXd5NEJOSVQ4VjhwMEkydHZXQWs1MW5Mdk5vVkVDbFNhZVZvTE02amVjMUJC?= =?utf-8?B?dmM0MUYvV0JXdWgwN1NiVmhuRHpKaFRBdHVLTks0Y085WmpRbmtoTGpCKzJw?= =?utf-8?B?T1hkaStJMDVNQkl0ZmJBYUdXR1JzdFZTMit0SW1YdFZHSWlrbHdVSTFicnhX?= =?utf-8?B?TWNiaXdHVHA1Y2RwYnNWdUphakIwYVNZaEZmdFFJQWxZQnJjb1NhRDJSMzVH?= =?utf-8?B?TU1nMk5jK2N1Y2xZY29FSEdWSDIxT0QzaXBGQU52UWp2OGpNN1c0L3RmRGw2?= =?utf-8?B?MnliNng2Nk1VekhqMlV0OFlweG9zNDArenZmWUNRcDRBVmVHQUNyOXVkSGdW?= =?utf-8?Q?DNjAFxFdFJWnppqFnaE4yFC2P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 560464bb-e74c-449d-22a9-08db94b42ee2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:29:40.5791 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4Uczd0JvQQxsZLgVGAJ7veb/9LjLBAtiAqHYaKhecsMGQo0X7lPlnW0r250y4GKDNaDT48svG6bjSrvC1/8p8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size. Signed-off-by: Jan Beulich --- Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any better approach for checking whether a defined macro expands to nothing. --- v4: Also drop #undef-s from linker script. v3: New. --- a/xen/arch/riscv/entry.S +++ b/xen/arch/riscv/entry.S @@ -5,7 +5,7 @@ #include /* WIP: only works while interrupting Xen context */ -ENTRY(handle_trap) +FUNC(handle_trap) /* Exceptions from xen */ save_to_stack: @@ -92,3 +92,4 @@ restore_registers: REG_L sp, CPU_USER_REGS_SP(sp) sret +END(handle_trap) --- a/xen/arch/riscv/include/asm/asm.h +++ b/xen/arch/riscv/include/asm/asm.h @@ -7,6 +7,7 @@ #define _ASM_RISCV_ASM_H #ifdef __ASSEMBLY__ +#include #define __ASM_STR(x) x #else #define __ASM_STR(x) #x --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -69,12 +69,8 @@ /* Linkage for RISCV */ #ifdef __ASSEMBLY__ -#define ALIGN .align 4 - -#define ENTRY(name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 16 +#define CODE_FILL /* empty */ #endif #ifdef CONFIG_RISCV_64 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -8,7 +8,7 @@ * a0 -> hart_id ( bootcpu_id ) * a1 -> dtb_base */ -ENTRY(start) +FUNC(start) /* Mask all interrupts */ csrw CSR_SIE, zero @@ -30,13 +30,14 @@ ENTRY(start) jal reset_stack tail start_xen +END(start) .section .text, "ax", %progbits -ENTRY(reset_stack) +FUNC(reset_stack) la sp, cpu0_boot_stack li t0, STACK_SIZE add sp, sp, t0 ret - +END(reset_stack) --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -1,9 +1,6 @@ #include #include -#undef ENTRY -#undef ALIGN - OUTPUT_ARCH(riscv) ENTRY(start) --- a/xen/include/xen/linkage.h +++ b/xen/include/xen/linkage.h @@ -37,17 +37,28 @@ #define END(name) .size name, . - name +/* + * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in + * which case we also need to get rid of the comma in the .balign directive. + */ +#define count_args_exp(args...) count_args(args) +#if count_args_exp(CODE_FILL) +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn), CODE_FILL +#else +# define DO_CODE_ALIGN(algn...) LASTARG(CODE_ALIGN, ## algn) +#endif + #define FUNC(name, algn...) \ - SYM(name, FUNC, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ - SYM(name, NONE, GLOBAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn)) #define DATA(name, algn...) \ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ - SYM(name, FUNC, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ - SYM(name, NONE, LOCAL, LASTARG(CODE_ALIGN, ## algn), CODE_FILL) + SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn)) #define DATA_LOCAL(name, algn...) \ SYM(name, DATA, LOCAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:30:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:30:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576879.903529 (Exim 4.92) (envelope-from ) id 1qRoKI-0004nG-Bh; Fri, 04 Aug 2023 06:30:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576879.903529; Fri, 04 Aug 2023 06:30:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoKI-0004n9-90; Fri, 04 Aug 2023 06:30:18 +0000 Received: by outflank-mailman (input) for mailman id 576879; Fri, 04 Aug 2023 06:30:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoKG-0004V1-L4 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:30:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5fc27f67-3290-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:30:16 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:30:15 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:30:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fc27f67-3290-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gs04y2bRLoSOIC/O5daECMMYZc7FpA1V1x3wGUo1SAWv+j8Qv043wMdjgf2FGBYMnXhH3wSD9pbA/CI+u4DP1gdEtmr90MTVCrADqKDLaRC80mL68mnkkSLixnghX4cQCI6hqelY5X6L6niq4vTtYcw5J3laJ2/zIvJd3l9HkmOZDg0Hz8jIGtIhS6Q7k65y+V2sIE42ln74k8vmy6+rAQtTmI7u3FU/Mf2mL5BibHmfHwV03JcQUpaoipMH5r9wjNsHM3R3lbqw9fsjzS0kIpiYNpiaqAmntjvrafhg2WISjUQcMS9iFE/98MFrZBVceaLSyxsEM6ziDCQwC2/VVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5BIsX4FSDC0bHsNPv5zyFFrdlOeD6u1F2sVkFP/hDk=; b=GCG6IOxZ/+3H5dB7nFMPA5uJ9Zybi1o3l8J076k3cAVpc9OtnnDAsStoRPd06ePxDQ2LimCwRHWx8vda5XAWSG/HoHv5aAT8UZold+xHpXV+U2USz+AAe+p1h6nOxokaHeRVlD2A4oyO93pIvo9VfeKwhQwPjhlIPRPhVQv/NSUuwxuknNk1RT/pUq3kkH8an4ZDOqFmk5SX4GMPaKyl1Mi0rHL8i1q3KdoxaGPNtEOMVtqwaJi6vH04Jhl+pzHhHVxOdCQgVrd74aZ7qK9oopd3A6zQXQbJ4k8/1W2kHv+lUa3A+HPMIpotn3exIcURSgLTLdT7k3jHo1obXSCqIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R5BIsX4FSDC0bHsNPv5zyFFrdlOeD6u1F2sVkFP/hDk=; b=REvIjxpOiQ9k8mQbOavFaTAXXZ0UJ8797VdaQkxMHxks/8SOYPghJhEQ+XRHwgJd4kzpi1k1QJqE0wLL9X30aNX10CgIAWfHNqwAM62EgHA8WrJyfr1iRKrZ+9xqiNINy8asF0SYWJCeYM1uSBc/xyVJX/CVRMBtZwiQAfcaiSSRmOIlpA3vYOoSTddxQVe3GH/w8exJHpp8W41Vz+T9YWflREFO5lbWeaHZmalysDBqkTtWPPHefiCwaw0CuR1Pmr6aJOb4lciunIY+JvgPLqkxPhNUkCBH5nXSFriSolbPoxhjstLULS0pVnnqH7XsBk3a7QKbCTSBM7PDJrnHeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7f855a0f-602f-910d-8fd9-956b379229f3@suse.com> Date: Fri, 4 Aug 2023 08:30:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 5/8] PPC: switch entry point annotations to common model Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Shawn Anastasio References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0204.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 5586d770-0169-415c-d8a2-08db94b44373 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IY9cps9VzvlNY0zPpJCRsNSwd9y7evuPlYSh5JA5lnm+j3cCcjtgqPFH3G++IenLrEotc5BLNbrzIlbya89WPtjiXhHg2EyPmGRiDeUQ+OYfDHGjUsUmvtG8qdC9lA7cnSSeZ5sTYSPJiC3OYWwUatnxGHZ+uCCzLO2RjMc5Q+C48zRe7G8qoFT181P0+BUPU2DhxeB7qAFTVYym66cwWPUIzLhHqNROzvulL1niXVxSLqfKAzQODOD4AtEing6sVeSLW2TuPER8rlvagpeWemIwP8pJUZtvLdui0GqSzANoGdhLXglEYzk3gwTffzr9zgbsJAP024c8FH0ctSsTuIPQEo0ppew6D3qvUKz9XikJMQFzzL5r4tQQLEM8puMZ7mntm0kTOXnbm1Lsa3ln1HegiY4aVkyNADirZLfD3OSdMqn5rEjFjFzezs9x0CnevpciAP89Xr1GGJMYwkMfWUG233ld/rBTB8pDeceuo+X9HcaNH1FoKxvCUzhG0Y9dMDpkYmHlC43z92+kaOyOCL74PQPm0PwmpQS5e8pj8hE5FY3Zwmf2CVPG/prfpOT/2tL1dDh5EzbeTS+Vx4IobEcVbeklbKSo6KuLYx8HDsWktZcfA2qFRCi65wleZeA3aT9jNe5RzcVk/SNY3a9ecA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(478600001)(31686004)(38100700002)(2906002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?USs1K3ZLajNXNUVPdCtYblJVTjFJd2Y0ZUJnNnVFS1k5TDd5MUxCdEVJWTBx?= =?utf-8?B?VXZ2cFN1bksxdjlNL0VNRHFvSEluQnk2VlRPclNkZnRLb3RkRlFXU1IvQVpH?= =?utf-8?B?QVhrR29KTUVpbXdNbUpIOFNvSExpRVllbzhJMDJoRE9WMTZrNmVzWFVrK2Y5?= =?utf-8?B?aklwS01tQzg4TTBBcTJvWTF2QXFkM1VxRjJ3YjZRdWF3ODJac0s3UzZpVEtM?= =?utf-8?B?V3VibER2a2F1MmVkSHBheHN4YThlMlBWdGFSZHRNQ2dCZ1VhamYwS1VvMGE1?= =?utf-8?B?Ty9kMUxTaWRodEV0bkRjT1ZTZnJHdURncWs1ODFQdFJ4Tkk0Skk1U1h2Q2NR?= =?utf-8?B?TXd4amFCVS9xd0lyd0FxUUFuUGpLK2JqQmUreFVObUR5L29BT3N3cnI4RWli?= =?utf-8?B?NG1LUzZuaXhzK2l5TUVEOGFEaUduWlU1MThOVmhoTkRXRjR4b01kakNnZnNq?= =?utf-8?B?TXc0Ykx0R2FDT2lwRVlwUE1Ed1pSZEZsOXE2NjNGMXVieE9lekRmK0dQVWRH?= =?utf-8?B?RFBOSEZaQ01qMWY3RGFvSG11SCtBUTJoUzQ3RGorS2FBOGFCblgwVDN2L1Aw?= =?utf-8?B?SnN0ZmlnRnBiZmxvUnM2TGZPMENydmZjTE9aVTUza1F3SVZvUzNZeXBpcGVk?= =?utf-8?B?bm1ZdGlYNzJycnltaGlWQlo5bUpCSUtXMmRhck14VjRJcS9ZRUl5d1RTNWo0?= =?utf-8?B?QlNHRzNLVjdIS21SN1dVQjFaR3RpOVU3L29vTERaTm5MM0Q0a2MvWTBTQzBE?= =?utf-8?B?QndacGgzbWY3bVo0b1NWZHI5VjJnZFhNdGtyR3crODNxeUtJUWxmdEtNSFQ4?= =?utf-8?B?V0JreUVpVXpKRk1OU05DS0tJQ3lZanpUbUtpNFZQTG5ENVVwUkhiY3Z1by90?= =?utf-8?B?dUtXZHltWlEzK0YrclNWTmhseU5xTHRmTUcrd2ttL0JVMCtvV1hhdnUvNnlW?= =?utf-8?B?S2lJOTVxUERUa25WdUMxUzduUGtRVjJ2enI0QXA1MC9zaVhkK1NtUkZRY05t?= =?utf-8?B?QnFvYkM5dVFWWndvQ3ZMUysraE5aaGFIRWxMWE1IZkg2bWVBQmpmK2NMR3pS?= =?utf-8?B?WEZNTndxSjdrTGVmWlIwUlZ6dFlhd1NpWm40NDhGT2lGUmxNOW9WREl6ZTV1?= =?utf-8?B?SGRMRWV3b3dzVU0zSEtKTzkvanZRMmFqM2xEZXVqdXVVSW96SS9QTzZxbE1q?= =?utf-8?B?b3MrcnZxY2g4L2xVMXEybktTdWhDVWErUFJ4WkszTEJTa3U1U1NpcklPYUVm?= =?utf-8?B?VkFBMkJDWkFScEVjVWl0dFN2NkVvWTVMZ0NJMkdnZFpJTGp1enNacXRQQ0Yz?= =?utf-8?B?WWh5SHc5MU13alVSb3JoNWs2SVZnU3dnNjhmMVprUHZycjliR3JKVS9GMEo4?= =?utf-8?B?cnFOOC9Obnpjak5ROXVsVUFGdVFzbWh0TEZTTlorcGJDZytMYVdTRkRmaDJ4?= =?utf-8?B?NFBPV3c1SUhwMzcyTEp3WnNPanFLaGRMZE5YSGwyNHdxL3VJalBic1VBaUtF?= =?utf-8?B?UXpNblZOMURsT1h6VllvWW5NMmNHNE9jK0JJcjQzNG43VDNuQ3Nna2swSHBM?= =?utf-8?B?YUVYZkF0TVRSMkRkRFRpTWlsZTVRTGFyZkhaaHBxNTRueHE0Uml5VW5XZG9U?= =?utf-8?B?d2ljWWtvQzhhRzFhTk1kVE10NXJCZHZJOGs3UW01SFY0ekhFMnhubFdLVFFl?= =?utf-8?B?SG1oUE45emlRK0dyVm5PSHBTN1NRanpqNElLVVZGVmcvTHlOaGQ3ZFI4YjZm?= =?utf-8?B?WWNOQTRDc2w3RFZGTjFsbE5YTnNTNXJjM1dPSllvcVoyR2MrdFhhOTZqSzJD?= =?utf-8?B?azNzOGFwdnlaN3NYalNQeUZBVDBtcmIrb1FTb3JtRDBLS1ZrWW50NHNvMnJx?= =?utf-8?B?SmhibXhaMmxkd0VudHEwQXk1d3k1S2VFa0pOeHlnczU1a095TEFuNS9ydmdr?= =?utf-8?B?Q09CS25HcmQrMGZUaEN6RDhLdU4ybGxIMDRWME5YYnduWVpwQThmUlNJM0Vt?= =?utf-8?B?dEptM3FZUFpxbHFtUWdhTDRUU2FzdW0yR1g4ODFyMlZiVTlsWHdVL0E4dmg1?= =?utf-8?B?OGFXWDAxN3RQdlU0UmZnb1NkR1RQems1M0MzV2JzNXZ2UzJvNmFvQ0tQQkJM?= =?utf-8?Q?H4cFnYWbA9K39mdAQX7f+z0Iz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5586d770-0169-415c-d8a2-08db94b44373 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:30:15.0839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 548XGWNPmS4WUxgWjBCr9m2i63ALLZf15s/z9SveaL5saH7UofCEGCCGwy+sX4Zp/X+r5TKBH93+UX/BUqs7KA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbol changes to be a hidden one. Signed-off-by: Jan Beulich --- v4: Also drop #undef-s from linker script. Re-base. v3: New. --- a/xen/arch/ppc/include/asm/asm-defns.h +++ b/xen/arch/ppc/include/asm/asm-defns.h @@ -2,6 +2,8 @@ #ifndef _ASM_PPC_ASM_DEFNS_H #define _ASM_PPC_ASM_DEFNS_H +#include + /* * Load a 64-bit immediate value into the specified GPR. */ --- a/xen/arch/ppc/include/asm/config.h +++ b/xen/arch/ppc/include/asm/config.h @@ -31,12 +31,7 @@ /* Linkage for PPC */ #ifdef __ASSEMBLY__ -#define ALIGN .p2align 2 - -#define ENTRY(name) \ - .globl name; \ - ALIGN; \ - name: +#define CODE_ALIGN 4 #endif #define XEN_VIRT_START _AT(UL, 0xc000000000000000) --- a/xen/arch/ppc/ppc64/head.S +++ b/xen/arch/ppc/ppc64/head.S @@ -5,7 +5,7 @@ .section .text.header, "ax", %progbits -ENTRY(start) +FUNC(start) /* * NOTE: argument registers (r3-r9) must be preserved until the C entrypoint */ @@ -36,6 +36,4 @@ ENTRY(start) /* should never return */ trap - - .size start, . - start - .type start, %function +END(start) --- a/xen/arch/ppc/ppc64/of-call.S +++ b/xen/arch/ppc/ppc64/of-call.S @@ -23,7 +23,7 @@ .section .init.text, "ax", @progbits -ENTRY(enter_of) +FUNC(enter_of) mflr %r0 std %r0, 16(%r1) stdu %r1, -STACK_SWITCH_FRAME_SIZE(%r1) /* Save SP and create stack space */ @@ -78,6 +78,4 @@ ENTRY(enter_of) ld %r0, 16(%r1) mtlr %r0 blr - - .size enter_of, . - enter_of - .type enter_of, %function +END(enter_of) --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -1,9 +1,6 @@ #include #include -#undef ENTRY -#undef ALIGN - OUTPUT_ARCH(powerpc:common64) ENTRY(start) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:31:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:31:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576886.903539 (Exim 4.92) (envelope-from ) id 1qRoKx-0005ch-QO; Fri, 04 Aug 2023 06:30:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576886.903539; Fri, 04 Aug 2023 06:30:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoKx-0005ca-N3; Fri, 04 Aug 2023 06:30:59 +0000 Received: by outflank-mailman (input) for mailman id 576886; Fri, 04 Aug 2023 06:30:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoKw-0005Xp-Hc for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:30:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20603.outbound.protection.outlook.com [2a01:111:f400:7e1b::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77f071ab-3290-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 08:30:56 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:30:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:30:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77f071ab-3290-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHL+forgOo8Jz3YB43ApbkgYBg2Ym6HtSRpB1xb5theZTI7WcXi0EMdMgrJUx/dGE7+ur4P6GWsACnfNszNGZVPFoglqOde7OzTyV2ZRAjSswpOzzTFueaAND2UtSURr2MMf6bW6CKV5PTfEjSE8qBAXTX6OLUBu9DzKGspD34XVkeuVi7fcJqKM9VPkdW9Ruc0fYA9SHJwVyzER5LX01A0dpTnzsyfVhpvDMhAnEh4YYKAtAKWEdb/541T+aKyX0K50sl+nAYjV7bQTJNanazVqKg9cqvKbZ/cTLBUxAwydX5HY5+WW7D2CsfYD8u+Tsmm8uWLlPhXZ5T1KfsMBdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NsniVDfE1jEbPDiRAa4YFhSNPmca1KwD931ycm8eIt0=; b=crTiQ8ONOTkc3IHEJZi28WmOQ3iy3mRe/vlktM8MaycHpqarVU5yN9XXjiSFJCgxrNKSQDuKFaj4KZ6wRBlKQ/qJ4pP36TIF7plZ2pbAulyhF84U9qi+IlaQzExuHq/NpdAbcyn67JmdTVY0RpzDVOLFasukq6MhTqh/1bYnes+1JXiwhr/t/tRQ6OGgG4F7bDxw7zMmX+Wa913bkjfvl8t5fRKoUa/4TK9IMOp+lrEGMq77JUVjAmC+YkKNjZWiYl9gYHgNjfiGOVf0pmnaGxT0ePjCU3g3B0yow6djbuPA5EUZOnjKqTFudLZaQ3BtQKXCWMs1wIvleWwIQBR67w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NsniVDfE1jEbPDiRAa4YFhSNPmca1KwD931ycm8eIt0=; b=gnON6k4R+Bo1aizJX5RqPtvVurC6OWcYFHsKWzkseCB7pRXVqfCAUUH2jN0Ms72Aje3o1DStulE1HnYpbTmgHyeRRZqyBA8xLFoCpd3oE3CoAAtckM8Yq6yYChH+9ia66zyT3zEsAju+TuRzGg86QYaM0YFRurBFcnqK6uu0w3tn8oA5gWqBOeClD9n1FmNVjXufhFl6zcouAKBHm/+Lx+qB+TFywO6auHOmG3g3cYU6DO3NT4qUaJr2fhkfPArFDVwm1CZDmBLLkSZ+T+g3pDBNVxJDWe5Ame7V0+dDEBBDSG2JXaXVOZo1ryiBVRjRup35ZbdvR3dR2slFDA/c6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2315f865-cd41-b0e6-524c-cee57e748ba1@suse.com> Date: Fri, 4 Aug 2023 08:30:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 6/8] tools/binfile: switch to common annotations model Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , George Dunlap References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0161.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 59dd9fa7-a0de-4629-c9fe-08db94b45b53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZBOa+k3szAVW0vsxBeYTgdpoulw0YQT3Wd9B4p3m9kXbf+S5duWzFR3z6uFx13WcBQMksVTJhj/TC9B+osz/biRN8Z6CAlMa50a8c8K3WIrpG6besplM/NECCPt9Le+smvoVcbMaM0Z4mwHMX3T2PGIEJD/RaIFZPp8IKsH7DtPuIW2TChrvbm1M4/x7xjxDRVgW4oi7KW59XGknmq7H7p+P8MXW0lhYuQ/c9mfQjN8JL5yrzVeUTGQIcDRbSmfFIq6n9jLE8ABv/7jltIThjblt+pYBX8zx3s2meU4hGLtX/s2JVKh742K29SLIlv6o8xEplCW+GYKO09ECRnW7ojE3ECr4+diUIA8mZ8SuiieEZscYdUnXf6Cat8zPL0Y5zQMJN7yIlA5oolGF0rQRYDfLomrQrkSBvxZ09NDTEnuCeUC/SZ+7b/5TFWYc8cJW/Br+0yef2p2tA80VI3JVzx7tw5m6RD659i7X2fjlGY9pe1rngjtMfTrUOYs+UAfCA7G5YqJd7X7513oGHA3tZIVLthKjTlhitI6lIM+BzPf4nqYxnJeUZ2iEvgQAtQQWoKgou9pnYu1o0ReKvvm3cpN9/g0ZAlc2MDcmHg4KT4zH+KX6ki1+c68ZfK4aqPSU5+ImLO3w2h2K6aee3+/2Pg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(6506007)(8676002)(8936002)(31696002)(54906003)(6512007)(6486002)(478600001)(31686004)(38100700002)(2906002)(86362001)(4744005)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFlCR01iZGl4MTVUNEVaR2hHc0pVai8zOE5VSEgxcGs2b2xCbVpUOUJCVGQr?= =?utf-8?B?RGlJVlA4dGhFdmU5dXAzYUZ5WXFrQkhpeHlxb2pXNGtsVnVTLzdHZURXZUpj?= =?utf-8?B?MUwrSnhKYm96cisraG9sd3ROUkVHWHFOakc4NU1lRmU0ZmNWamJBSmkzMHUr?= =?utf-8?B?S3FEdzkzWXJtVWJSZUUwY2lEWDVvOFc4T2pERm5FYlBoU1V4Rkp2TmJyREFx?= =?utf-8?B?YWhsUi95NXVQMHU4Rjcxd0JsOWJ6bDNmb20yUUUwUmV0MGZMcFkxTEpwVmEx?= =?utf-8?B?MU40djg4R3l2dFBzNldMWVF4czFKamxMSS9qUXZxUnNoYkFsaHh3MklZMVFY?= =?utf-8?B?R2lESVBmeTRGT0NRdkwvWERlYU1rdHNUdVVFOE95c3U2aWhKdnFIMmxqYW8r?= =?utf-8?B?MWlIVC85aDI5dTBtRlp5b0txTlpDazVNQm1zeUlRWTdLY0lHZURGZWlxdHVS?= =?utf-8?B?eUJ1ZWNkRWRQZ1k3MUlMSHhML1EzcG5GWXFiZnl6bXR1VU1OT0R5NXJrMklK?= =?utf-8?B?UFU3bUpqQVVNWkhOYi8xQzhUY1ByOUViU1FoeDZ4a002VkdWeWc0SGpFc1BD?= =?utf-8?B?bEZ0RHBaaG1FNFh5K3dlRDNockZOQ3NtN1pLNlFMMTFQWGMyTVAxelF2TFY2?= =?utf-8?B?TXBnYVA0bDdZdC9QemgwbXhNRWJISXlxbWVKSWp6dHA0STlUbm9zZ1g1VmRJ?= =?utf-8?B?dGRIU2FUc3J5NEh1bm1UREpXekpKSU13QUV1YTB2VUV3MDIyYmFnUHJHeEJ6?= =?utf-8?B?aVBHdmxkQUhlY2RPWTkwalczeUtwekZSREpBa2Y0WnBXRVpQMzgvWmxGaFBR?= =?utf-8?B?MnVNU0pqa21uOGpUZW54aFB1SHRQeHdTQVcyK2lWdHE0SEtRMW4xK01qeFY4?= =?utf-8?B?WStYUFhOcktxT1ZGbVFndTlYY3ZMVXNjc1JDT2phYUpuZWdvY3NBY2VpTWJV?= =?utf-8?B?UUVVbkVmdW80dk9XQVRDdEhJWERIWDRFRFphV0lpU2RxQXFVcUpocytpTWlv?= =?utf-8?B?TEhqQUwrbzdFcmd3RDRCM041Y0liWDJ3b0lHdWtTQjVWTUN1ZHNGaEZNTmFV?= =?utf-8?B?NHcvUDJXT2Y3aVR4SGl3dnFpRHZqbjdjbXlXNkV0MkkvZlo1NFc2UnlmazZi?= =?utf-8?B?SUxDaS9OZXNTbE5yNWRFWGtCUmRHZm1NRGw4YlZ2OFFHaU1TZzFwa2tvUGpa?= =?utf-8?B?TzFwVGc4dklkUHNuZlo4T3hTSndkM0xacEJmSi90SXJXYVNlUG9FcFlWOUFD?= =?utf-8?B?NmtTTWZNdG92aWllQndPcmVndTQ2ZzJoRW1uZ2w4Yy9rTXVyb2Z3eXlSN3Np?= =?utf-8?B?aE5JdWFmbUs1SEl6NlcrSndrY0JDcnJJRys1a2NUa3AyUXk5ODM1QmFWVmhn?= =?utf-8?B?Q3oyWXE2TjdmcEdXTURtZU4wYy96MXVVWndtTXJNMTFlMG5ydVJTN0NsUTFE?= =?utf-8?B?QTdNakg3RVlNWER5L2txR1ZjQ0s3VktTQ1J5SXQyWndGRmdYR1VHME85T0xi?= =?utf-8?B?NnJwS3RGRFNWK01mWnJIN3lmV0d6YUVjRE1aOGFodU1Rc1BsT0RpanlFckpC?= =?utf-8?B?MlJ4ZUJXdGwvNlplSGkycW9XaDdJZFA2NVJ5Rkk0STBDcS9SQXhuWEFxOHZR?= =?utf-8?B?ZEIxMW5ZNTAveFVuWkpna0Y3Um5EMGF1VUlEbGR2YjJ6UUI5ODlrSzhHTWln?= =?utf-8?B?ZVNjT1NrQUMvMWJoSUlSdmxWZXdaQjdlMGpzaC9UeGJ2ZnY5K0liSnZ4S3Mz?= =?utf-8?B?N2QyLzN5UjM0MDBSS2ljb2IzMXlOS0RzUzREMUhBOW1WMGJLZEtMWHlWeEVX?= =?utf-8?B?RTNocmxZc3dUNzlLL3QvN1pZd1MrTlp3QW9WS25qTTk1Z0pEWmFxanBRYnZj?= =?utf-8?B?cDFBRDF3K3FHOWdYVGZwRFlKZmk0Vi95MXFUV0syakN0QnJydnhVNDl0Q2Jn?= =?utf-8?B?VmhoYnFzUitpNnpvM1BFSGFUeDRqY29yUDNpaHNqamtpTG43Ynh2ZDl5eGZU?= =?utf-8?B?YnFZNDRZcnBzYnFlckJQelorcTZHS1ZIWXNMRERvdEhhZlJObjl0S3lmWmUz?= =?utf-8?B?VTFLRUd3OG5FK3llZUZ2aVloZ2RHd1lSSk9HekxLSzJxVnB6S1R5ZHcrVjc4?= =?utf-8?Q?TC69JRv8Zdtch22N8ciWpvQtE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59dd9fa7-a0de-4629-c9fe-08db94b45b53 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:30:55.1966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mJ3tJZ/j1PebHfYc38cvRsyiVCRR/i+/bgZogqMyL1uX0us4EupZkz/HK3EBhrw4b1dMQkoTX9xo0o0Vo6JOwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Use DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding. Signed-off-by: Jan Beulich --- v3: New. --- a/xen/tools/binfile +++ b/xen/tools/binfile @@ -29,15 +29,10 @@ cat <$target .section $section.rodata, "a", %progbits - .p2align $align - .global $varname -$varname: +DATA($varname, 1 << $align) .incbin "$binsource" .Lend: +END($varname) - .type $varname, %object - .size $varname, .Lend - $varname - - .global ${varname}_size ASM_INT(${varname}_size, .Lend - $varname) EOF From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:32:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:32:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576890.903548 (Exim 4.92) (envelope-from ) id 1qRoMF-0006Ea-3K; Fri, 04 Aug 2023 06:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576890.903548; Fri, 04 Aug 2023 06:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoMF-0006ER-0d; Fri, 04 Aug 2023 06:32:19 +0000 Received: by outflank-mailman (input) for mailman id 576890; Fri, 04 Aug 2023 06:32:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoME-0006EL-O9 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:32:18 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a84a7ed9-3290-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:32:17 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7549.eurprd04.prod.outlook.com (2603:10a6:102:e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 06:31:48 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:31:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a84a7ed9-3290-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BE8IazFiMcKlt9EJxkTDglsHSdtX1En1Utjyrg3afWbPKgs8Rcd93/EIhld5TOWfCIWjbXX7OeK/BVWUv5ZcqqzEy7+TpvHWvqjzukfBdTu7wbv7xSpuq21DS5BJ+M59hwfmSHc7d+XBp/J1yHclJXTuloan5JH6/vr2NUQDUAZJZ6nlw6MAU9fTxsxZkLSlZiKXkAcU7SyPtNttungAWfhVV42CHqWCziLIeFWA+FRk7F9BuZR5HqPRjnYRl5/+owP5yN1Hd0yhMkwah2TKPEBReBfBRQ3uqFmgbwI3cuJM9J1+voGFYZPxckXxZc32HgwCou0a4fhGAx6Z5prFCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8ESduLaN901hoKEazmFjnm9TC717oIo0zL1AjWTDiI=; b=TZMSoqhzDlqo8z2+yG1eVTIeXzqzMpdUDHHGtDDCnIWZDntQrHkQDq6Nle5KI9r2KRPHP1ZOEIw3FZAGn1S/lQDqHQ0Nmlh9M3qblS5D+uH5R/URZKk+i+Ha6ZVVX4FUk135OXqLCz+/N0mFzNSQ3ErcONNwq9wCJlq63N2uQq37jzUUfhGevVSpJgRQ+NYOFdWSOwKMneInKZH/LFIHSoN8XujxqPMN5LKwTC7W/51p+MzrD+Qe5tqQ7FWScQ94bk0vp5YAkCo1/+9ekmVUzXX2003t9oBULppVtEXuNvcQvM1Rk8ndKIHXlGF9h3lgalsGIfJgTE+7jlz0qfkdmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8ESduLaN901hoKEazmFjnm9TC717oIo0zL1AjWTDiI=; b=rl3zp4Y+kxfANDy6gJJaRy2qAPulxXM6RdBSKvC5csSmUqDvJzbARBOkC6klPf65Ptm5RZZNCtUufXzQsNFlfPJX/5UdtfCBtBxiJ6KkhrkP7UxNEtJXkkuCPO4KZCS+BwS8PFMCClalAWAJTlYwHWGml6Ok3k9JIgHx2rwC+r3cyp0+Lfzt6DgODTtTEBUkDb1nb4Ece0hEbtEwbJ64UCFZjK4WodTEFdgeFCd0P/vlxN3oWezQBG7M4sg0YseWCZHFYLdkDByW7hDuzkE8YUz0WqrTocr6mbPodjZ6D1sVvNKFWc7AJLwxENTZAvLZve95FIFREPZvWrWugPGuWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 08:31:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: [PATCH v4 8/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , George Dunlap , Shawn Anastasio References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7549:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b5d8f3f-4935-408d-cb3d-08db94b47ad8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LRTipeec2RrFtz2YmC2S3V75mz6J9IVrn8Cz6aEK2EgsbF1KXjISQJCcd/taM70zyOjMAI076W5ePPMThodJMnGkB1r+EjUSiZZQzy0JZ5Rha2e8ill4++Nm6ZtEWDMm86KY9A5ODu7DsqcVUdQ6zwOO1CBfqha6B+j6Y6jWIVVixJFCDnEveFq4XH8wbO1H7sOC9JOKiIywmmatIORRM2ef+XjfmJ4NYcIAQudDWaS2k3gUbq5jf9fDaposn+z9eLQz83HU7He+wFGmoY6FCsNyty+F1dch/MGxINqyh8ADKezpeoRw+5LkpIEvusv8YBQBVkJeePuF2lVjdG8Z3x0sCztApDX36GZWIm9OUe67AdiuSbUuR+xUab1gU3qmMss5u6jq1exnnkAPQ2GDbTJ3R+Yh5cMy51znEyAuhIWZAbsPINdrnB09hGPuWffWVZVA1woivJ1T5pY6fHf4SWLu2LNIraldcOFz/pPnmQLdkWPcd3x1RGc+Hnx6CTikzJ357sEMVvOYeqRegqQbd2s5FjXsgx8x7vAZmjeuBwECTRrW7MN1+33pEvN1jP0kz1ff15NZXCTltTxWXf1e0/qL2nrcfPW/bfW9nZJv4yZC4sk8sd9ARs2Ma9uQoYtvo5j1p748nLHebn9RROhwYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(1800799003)(186006)(4326008)(6916009)(316002)(2616005)(66946007)(66476007)(66556008)(5660300002)(26005)(41300700001)(7416002)(6506007)(8676002)(8936002)(31696002)(54906003)(6666004)(6512007)(6486002)(478600001)(31686004)(38100700002)(2906002)(86362001)(36756003)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2FLTmNKazJndVBrMXY4MDY3aXQrMmo5N3hITmN5TmowT2xHU25oaGltS0tm?= =?utf-8?B?YjRBRnByNldrWDZWSHB1UHBvVHd6U2xuekdSYXRyNlVZbW9NenFHdWNPdVBH?= =?utf-8?B?ajFzam00ZTI5YTkxb3V1WlFEdm9TdEZ5anRocG9vOEhUVUd0TW02em1MeXd4?= =?utf-8?B?aEFUalFtL0kwbzl1VkhPeEUwMERUU3hHWThxYjVhajlKYnFBaUR1Uzd0Q1Zj?= =?utf-8?B?NzJQbVdPSTBPQ0ZhNEZkOXIzMjhkYUZ0em1DVnEwRGxFdmtKVTZrZlVJZFg2?= =?utf-8?B?K2Y3bkFVN25YWHMyUW1xa1Jid0ZLUDkwZ0hFZkRqK0Yrd3B3N1VrZWNnVXpK?= =?utf-8?B?aUNHa0d4azN6RFJ4Mkg0ZTVhQi8vNWM3Sjc3NXpLNFNmakc1eitZMFpLVTBO?= =?utf-8?B?TUFNaWxOQzl0NHJMZHUvVjJHc2xsSnFiWHhYR0NBeTdxeWI2azdvcTkwL05B?= =?utf-8?B?ZlJWMmIrY0l6VXQrQnJwWmR5TEVDd09lWHpUTEVtYVRjMlp1c2pqQ3ZTWHhW?= =?utf-8?B?NjBMRUhrWlJxdGVzTU83VDJ0VnM2SXR5QlVYUXZJczQ3SDNhQXFtUWlUZ3Bs?= =?utf-8?B?Z0lhVTZtTzhpRmhuRndSN3R2cDl5bHV4dE40Vktydm5WWXI0clg3MDB3N3Av?= =?utf-8?B?V1hwZVBLUHRyQkRXOEIxRVl1b3E3TWpObkVVdW9DdVFwUE1kQ3VlU0ZLRFRD?= =?utf-8?B?bmJlclNMQzFIbUR4RUROam9UTnJkN3VtQWRpempZQnYyQ1dIRGo3bTlzbWNs?= =?utf-8?B?ejZweXQzZnZ0YkFnSWpqeFlHa1NFYVluV2xwdVZKYkc1dmtXcDBBWUZUVDl5?= =?utf-8?B?Vld6M3VXT1hHNEljbHVjMHlRYkt6T1YxbEZsZjcvVzNKUzNjK2N6ZUdESS9v?= =?utf-8?B?YU40eHQySjVXVFN1SDNKaWtUVW1IQWE5ZzBJTnFzbE11ZUlOcUtGMmhCZjRP?= =?utf-8?B?NWl2QVdpbkgyR0trMG5JUUxSN21FWHhRMldrTXQzcGFYS2hTSFl0QUM3SGR1?= =?utf-8?B?VklUU01BUFZpSDYzOUR3cGRFdnBJQVpjTFEvd3lCQitGbUFNeEFBWDc0V1lT?= =?utf-8?B?MzR3NWlPdVI2eWhFSnJ0emloY3ljczJMbVYraytlZmkrVHZQYkpwSGtQZG5S?= =?utf-8?B?cE16UG45M0xDMGpITDF1QmVoWG1ETzlPZkYvSjNDSnNGYUNXbXlOaDBIeFJv?= =?utf-8?B?Zmxsc2RBelVqdk9KZjZyMDNtU1hSbjBZdjI0N1ZkREswQ3kva3RhaGNpYWRM?= =?utf-8?B?cFFReXl1RGREdUxXQTBBa2NkTVFuM0JZeWRXT2cyNW1BQ1pMNmkyWHdpOHBJ?= =?utf-8?B?K3J4a2U3cWRrbk81VmJwcjBKVU5VNWVaMitISUFFcGlFdEFFTTVwb1RURDgy?= =?utf-8?B?Z3lFT3g0K0hRUDRCd28zLzB0ZEFkdGlDeXVqNVh4Qk96c3kyQk0vZlFxNnE2?= =?utf-8?B?UWZ0VjFOUmI1NVVjUmVsVUV1YWVIWFI3OGhGU0NXb1dydm41cTdyREpmZDZS?= =?utf-8?B?dnNlL3lhcmhKcTdGMnFlVFBKMVBnOXJWaVRlL09MeUFYVTZlVVMybDJIcklx?= =?utf-8?B?NkZYUW1oK3RxR3o3RVkyNEV2WVNGSUZ3QlRwL2w5YXB2anNBcCtCWUJ0QXBt?= =?utf-8?B?N01QWHA0Mm8yV3RnT0d6WFdwODRQcXFkK0hIU3E4REFpSnkvNXhrVmVwNENX?= =?utf-8?B?aS8xZU94cDB3T2tjRDM3U2ZJMi80Z21zTVljN0FHYVdwWjNHUFQwS0pCbHkv?= =?utf-8?B?UDFwbHVKWFlCMm54YnhjUW5XSEFEQTZOTkVLSWQzTTQvK0h1TFdQbGNQRHN3?= =?utf-8?B?ai8rbjRkT05KWEFMTFNTM0JGYUZCWFJBS2ZYRWJZMlFwcDVzU2hlV2ovZ1pF?= =?utf-8?B?b3BYSk5LbG9tWlRjWE9iOHllSWRPNTFWMGtlZW5SLzN6RXlTWmEvclZuTVBv?= =?utf-8?B?bGZrTjIwMUx0STh6RXlHejRSdjlLb3E3YzNvZVozTkFtdzQ3bm9sNSswditU?= =?utf-8?B?ckkvU1d0eEcvRjhoVTh6YW5qRkExZmlsbjdETWJDbm5yemR2WUpZUDFML21C?= =?utf-8?B?OUpOc1NQSUdlazBOTk90SkZ2dXlmYTRWY1NHZUQvZG5xeGZjQklSZG5MRVhS?= =?utf-8?Q?E6GMYFG9kdobM9Oae9VA/V3Lp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b5d8f3f-4935-408d-cb3d-08db94b47ad8 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:31:48.0233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F9TZGOuYH95OnhlSGTOwIFYrkRapOM9067qrSi2f29oS+b17cfaF8fOgy2C+31Aa3LjdjWqW+Tvv7MK9Uaim9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7549 Leverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked. Signed-off-by: Jan Beulich --- TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not really wanted side effect of this change is that respective out-of-line code now moves much closer to its original (invoking) code. TBD: Of course something with the same overall effect, but less impactful might do in Config.mk. E.g. $(filter-out -D%,$(3)) instead of $(firstword (3)). Note that we'd need to split DATA() in order to separate r/w and r/o contributions. Further splitting might be needed to also support more advanced attributes (e.g. merge), hence why this isn't done right here. Sadly while a new section's name can be derived from the presently in use, its attributes cannot be. Perhaps the only thing we can do is give DATA() a 2nd mandatory parameter. Then again I guess most data definitions could be moved to C anyway. --- v4: Re-base. v2: Make detection properly fail on old gas (by adjusting cc-option-add-closure). --- a/Config.mk +++ b/Config.mk @@ -102,7 +102,7 @@ cc-option = $(shell if test -z "`echo 'v # Usage: $(call cc-option-add CFLAGS,CC,-march=winchip-c6) cc-option-add = $(eval $(call cc-option-add-closure,$(1),$(2),$(3))) define cc-option-add-closure - ifneq ($$(call cc-option,$$($(2)),$(3),n),n) + ifneq ($$(call cc-option,$$($(2)),$(firstword $(3)),n),n) $(1) += $(3) endif endef --- a/xen/Makefile +++ b/xen/Makefile @@ -407,6 +407,9 @@ AFLAGS += -D__ASSEMBLY__ $(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack) +# Check to see whether the assmbler supports the --sectname-subst option. +$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--sectname-subst -DHAVE_AS_SECTNAME_SUBST) + LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments CFLAGS += $(CFLAGS-y) --- a/xen/arch/arm/xen.lds.S +++ b/xen/arch/arm/xen.lds.S @@ -154,6 +154,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ *(.altinstr_replacement) --- a/xen/arch/ppc/xen.lds.S +++ b/xen/arch/ppc/xen.lds.S @@ -90,6 +90,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -89,6 +89,9 @@ SECTIONS .init.text : { _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif _einittext = .; . = ALIGN(PAGE_SIZE); /* Avoid mapping alt insns executable */ } :text --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -86,6 +86,9 @@ SECTIONS . = ALIGN(PAGE_SIZE); _stextentry = .; *(.text.entry) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.text.entry.*) +#endif . = ALIGN(PAGE_SIZE); _etextentry = .; @@ -214,6 +217,9 @@ SECTIONS #endif _sinittext = .; *(.init.text) +#ifdef CONFIG_CC_SPLIT_SECTIONS + *(.init.text.*) +#endif *(.text.startup) _einittext = .; /* --- a/xen/include/xen/linkage.h +++ b/xen/include/xen/linkage.h @@ -21,6 +21,14 @@ #define SYM_ALIGN(algn...) .balign algn +#if defined(HAVE_AS_SECTNAME_SUBST) && defined(CONFIG_CC_SPLIT_SECTIONS) +# define SYM_PUSH_SECTION(name, attr) \ + .pushsection %S.name, attr, %progbits; \ + .equ .Lsplit_section, 1 +#else +# define SYM_PUSH_SECTION(name, attr) +#endif + #define SYM_L_GLOBAL(name) .globl name; .hidden name #define SYM_L_WEAK(name) .weak name #define SYM_L_LOCAL(name) /* nothing */ @@ -35,7 +43,14 @@ SYM_ALIGN(algn); \ name: -#define END(name) .size name, . - name +#define END(name) \ + .size name, . - name; \ + .ifdef .Lsplit_section; \ + .if .Lsplit_section; \ + .popsection; \ + .equ .Lsplit_section, 0; \ + .endif; \ + .endif /* * CODE_FILL in particular may need to expand to nothing (e.g. for RISC-V), in @@ -49,6 +64,7 @@ #endif #define FUNC(name, algn...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, GLOBAL, DO_CODE_ALIGN(algn)) #define LABEL(name, algn...) \ SYM(name, NONE, GLOBAL, DO_CODE_ALIGN(algn)) @@ -56,6 +72,7 @@ SYM(name, DATA, GLOBAL, LASTARG(DATA_ALIGN, ## algn), DATA_FILL) #define FUNC_LOCAL(name, algn...) \ + SYM_PUSH_SECTION(name, "ax"); \ SYM(name, FUNC, LOCAL, DO_CODE_ALIGN(algn)) #define LABEL_LOCAL(name, algn...) \ SYM(name, NONE, LOCAL, DO_CODE_ALIGN(algn)) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:32:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:32:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576892.903558 (Exim 4.92) (envelope-from ) id 1qRoMg-0006kM-C4; Fri, 04 Aug 2023 06:32:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576892.903558; Fri, 04 Aug 2023 06:32:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoMg-0006kF-96; Fri, 04 Aug 2023 06:32:46 +0000 Received: by outflank-mailman (input) for mailman id 576892; Fri, 04 Aug 2023 06:32:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoMf-0006EL-5j for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:32:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061b.outbound.protection.outlook.com [2a01:111:f400:7e1a::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b82b4042-3290-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:32:44 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9242.eurprd04.prod.outlook.com (2603:10a6:20b:4ca::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.48; Fri, 4 Aug 2023 06:32:42 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:32:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b82b4042-3290-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ausqHzoCmVVOMvAxHlOil+uf59t1vqcGTrHPaCncvU1n/cyQeSMeynLEz/jnpKNOqjIIdJg016Mb40wZGw03z95N4pVWwwk8pHD6X55vZJxpJ4QlmC03R2i2sCCZ+KHof2OxuPsx6VcdPEKTZ3fenVh7uZ0Ds4kRXsLakaE+o7cCy8f6KIbzfon2zls9Gls/EmzoFSfbTYSvPhOHZ62AGRSqtlzzg6TZesxlTILGznKtSO3sxWhdOsZPqcIsx+CsI5cUb2tf6N9fBU71hyYDE+DMeIVaDmWxV2tjmiPT/WctXMIqwnhTutBsIm2VZ0CkzobrjxTUh0nh6Y1+bJxLnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JYd+Ywgcxb1lA7p76Cb3f57FcBHVU4ae7hWXTzcbzcI=; b=NJNWBBQfjY9hbizmc2j8x3xidKkJ7dyI/RmUsxKreDb9ciShBpdbCAHyIhpi9+ski6DxC60G6hmHGALjLBSwj8nxAoCHb9D+eXjLUQbnKc2d9hbVR9HW3OliwnznUI5GVhO73H1mDedvsrgtujhh5RPLcYjwQiXXra9zxKJVRAmdk1hpHBQ/i3KWOW1iAxTVSX3O+/qMaKHW8dPgzjhFlf9Fdo+p8CcqWz4GwPiHusjyC9Jad5DUY+iBU34lgN0BLqhwohwu0sg9RGEyGyqUB2MUf9wEtRWOpX4jjrk65Ee8Jd05rC4wKq93CD81lkN+zMWDJyNWVg5QpeUHOHNtdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JYd+Ywgcxb1lA7p76Cb3f57FcBHVU4ae7hWXTzcbzcI=; b=OXwCqSVf6arXcfZx58JIwM8Zsoxbub/BKASRLMddLmL8LnomtFTlED+TQILUUxJfivM20HBIp9cUYfgn9CEWylA54bmi/7Q8nAXaBNKlBN2fvdiff5YLbJjS7AlrWLL+B91QYf8M0uxaWV6YMVgAwwk7U3bxvvq196E1s+kXsFr4mkq2uGR4K3OJvuWVC9bVn6swmRb5buFkZNuV4KRJprGhBCdGvRgdJOqIfSR3W0sC1XE/AML0kzmIfgxWPD5AOY88muKb0Fkac1W4plJYDyHXqxgCVTM6q3SIZKHHPCUzbqASV54TgWYedtVgbwNtsbrob3F6rt5E06UJB6k+DA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 08:32:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v4 0/8] annotate entry points with type and size Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , George Dunlap , Shawn Anastasio References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9242:EE_ X-MS-Office365-Filtering-Correlation-Id: 1acb9389-e93c-43ac-059f-08db94b49b45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8v/d2sE4EV0s6hbiO7Ar641x1+7C6hjeCzIC28OeRA+OkGY6tbhaTHijS5XOBEmuzszsGfKGwnXqoQ26EgnP2jBE7UiJ3xVfB+CRWia5NnTDpMJqiLeT/iO2QRGMD8AIynq2csi1qLPuKWkZ/sgO6zR4NgAj6FMAlgbZmzKMs0ND/laNZFAXgwM+Mbe4tmidUyY2mfZyRu9uYXUh0li44D+JxrJtGiOa1B8wZjR30FGU1Va+Z/Tgc8yuaAranRPGZBCyB471oIdLYkv9IqNMPVWbl9qBRViqRse6oALEcRcWK+s0Pt2dgwMkXCZZ2YLbhWjA0vv/aSynqNLj+0Ls6vUP4MgEDg4MUmibfI5nT3vKvodEqHoTf4Bu8NiFlxsZBFdoK6YjnobWCZsIbmKwLdzSx4nEubwPMQO9jbEWov8T9MY2ve1Sfy5G4OqsmiEfqxl8ECnPO8yK9uyYfnZDBIIV1H31GPz3Bb/ZrI9JS+1bZ4PsxDXfhzEw9u0o3A8M9o+sj7Ope+yvTaD/6qqaynvgEFUlZhBk3NK5tPwQ4WOnsDGkqCixlm9CDA/nZXrr009UHjPiJNFD47YeghplreJVHRzg2d6wl8wCjAFmYy5s7YdXdeW+85qLw4Lc98kJ/EXT8iHrsBeTaknlKNZaCA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(366004)(136003)(346002)(376002)(451199021)(1800799003)(186006)(316002)(478600001)(2616005)(5660300002)(86362001)(7416002)(83380400001)(2906002)(31696002)(38100700002)(4744005)(36756003)(53546011)(6506007)(26005)(6512007)(41300700001)(6486002)(8936002)(8676002)(6916009)(4326008)(54906003)(66946007)(66556008)(66476007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czVTSlhJWUVpaTEzMkpOSFVSQ2JzL2wwYU5YeHpTVGM2a0dXT0JodWlsRzVQ?= =?utf-8?B?K1RiZWcwM1FrajdwTVZSOEprWFdhUlU2YlhUaUtyc1dFbUc2SGp5KzV4Yklp?= =?utf-8?B?V2FXRnNONTlmL21qVU9Bb2owMmh4Z0lrTE0wMUUxcG02TnQrN3Jld0lySEk1?= =?utf-8?B?L3RzdnJ3MXhlZFgyMEJjbGRETFB2VUNxQm0rSXhUQkNReFlRQ3JyTXZTMFRX?= =?utf-8?B?R1lIV200OG41Y2tPcWlXTmt1dFFjbUROMFBFQkhsR3hhaGUyL1NabkRQZ1lO?= =?utf-8?B?blpQZVZIUThYUElTQXh2Zit0M2kvd3RlUytQeGk0NXBHdkwyZDlZeEUwSGdz?= =?utf-8?B?OGUwdDJhMEgydVdiR2Q0bFJ2bUdweGRvd1ZTNG8wZERKY0lxRnV3Z3RoMm1z?= =?utf-8?B?Z01yZERyWk5nbVVBUEVYdElwbzZsaS9jY2FaV3YrYklSVlhwdUlyQkYxaXM4?= =?utf-8?B?NjRiZ21Ld2h2WThoWE9NcldMV3h6dElIWFJ4THgvQUxGZjNPWGMxQ2hDeW43?= =?utf-8?B?NmJBWDJSS29tLytRU1Y2TGdXWFBTamRRMnAxdHphRS9vMlZGdDQyYVB1NzMv?= =?utf-8?B?T1NVMk5xanJNekFOcWxMb1U5NmllZWovd2h4bnJjcFU4NWdJUUpraDZpd0dF?= =?utf-8?B?KzZOWHlLelAwL1AxVnhHdlBGVDdLQWZLUzhJU1Z2U216WnhCZmxRM0VhdE03?= =?utf-8?B?UnVOdzhlL2JYWGdTeWZlYlQvc2I3NUVBOGQ2cVhhWEJiRDM1a1VHM2JpN2pv?= =?utf-8?B?dkswWXA2dnlFck1HdGtGYXU1NUpseGp3YWlXUUh2OWR6ZjhpaVBpb1VGRXVn?= =?utf-8?B?RW55NmlTbDdDdGJOMnVrakNyYjlYT1FhbzdrY2RKVC9OSHlFeGRRRnNXMWVa?= =?utf-8?B?ZkkxQU1ObXpQYmJ3bjN5T240cVYrZlI0d3B4K3VWTUg5Wkc1N1JmWm9wTnVi?= =?utf-8?B?cENia0ZRV2l5MFAwUFEzOFE5Tyt2SXA0cWlBVURrNFM1bGVGc2M3WWt0cXRY?= =?utf-8?B?NDNERm1LUEttbXNCL1dDWHRIL1lhUnJEODRlZ3Y0eSszYUlKMmlSZWY2aDhE?= =?utf-8?B?eFlKeE04QWQzaWxzUHQyS1pTUS9FSTR2ZE41Z3FXdlI1YzhUTmV1eUhsQ0Nl?= =?utf-8?B?elBuNGxPZmN0OWE0NFMzU3ZJRFEyVGJjRHRPREt2Vmk3ODViVkc2S0VJL1hp?= =?utf-8?B?b1o4Wm00bnFVNDN5UkNRR01SdFRndEVpQkt1c01KM2R6b0pHeU02d2VxbjIv?= =?utf-8?B?blUxcGV1VG9Nenl3T0hlVGw5bVllZUZrK1c0WDJ1WEhXZFp3RXpVWVpEWDc2?= =?utf-8?B?MWJ1am5qTDdEVHMzQlpUcTM5QVFjeTMxSlhWbUdyOG00VXZGNHVMNFRDSmtO?= =?utf-8?B?RWd1WlM3ZWxlVTkySlpXOGZ6ZWRndFkrc2dvNEltY3JvVi9IQVFKV1M0QkVX?= =?utf-8?B?bHFSL2lCbXVvRVRCMUlwS0NITEZ6ZUNydnFDZ212N3ZpMG5OU1p4S1ZmM1FK?= =?utf-8?B?M0xUM1BzUkg1Sm85WUJrWWswSEoxQ2xTNFR5WlMxRXhFenIxVTRlTlRCcVcx?= =?utf-8?B?MUdaV1VaUjdPT1JiK0R5REhrRnlHNERCazZ2aWgrL29lWG5uUHk5OURyd0lu?= =?utf-8?B?bS9rNUVsdDMyZ0xNWldVTW9iUVhtRU1Ta2FPNTNDUE9WYkhVSlBpZUh1ekhy?= =?utf-8?B?aXlPbUJid1h6OU8wb2IyV2Z0YzRIUkhjSEhjM3BYbVVIU2JBdDFtMCtDOEk2?= =?utf-8?B?OGwvUENxeUJmanZrTWVYd3hqMW1sNUdBZDA4NUxwWWZtcGNPdWlUTWpsN21m?= =?utf-8?B?VEN5bEtkOTNWWVRUZ1FtbVNsNU8zUmtwdmlhSUIwN09NZVd0NERob0ZRRFlN?= =?utf-8?B?bm4xSmFPQ0pIdStEQjFPTHllNXhQbE5NN2dQQzJrQ0NtU29iS3QzNEtnV0N1?= =?utf-8?B?ejYxRkxJL2NVNm8yK3pMT1ZhZmY2aVJ4Y3BrbG9jUTIyUi9CTHZ2SnQxU2RC?= =?utf-8?B?NWpLSHprNlJLZmhnVlgrbXVQSDZxaXAwbEdUR25HR3RXRGZmVWtDdmx1SERv?= =?utf-8?B?VmI4ZllwK081NTdsU1doZldYSjFSd2FLb1grL0NDWWRJd2IvMXl4MU9TNzdi?= =?utf-8?Q?/t7EsvpUfuinURuTg8h4IFORT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1acb9389-e93c-43ac-059f-08db94b49b45 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:32:42.4165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KF6w60+3MH7NfOTaaFpiCuoqZoCDJOR06Ki+PTVBTbI9sdEZ1NQ3SzGkyV1S6H2d/5OqOlPPW+lh8mu3tIcopQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9242 On 04.08.2023 08:24, Jan Beulich wrote: > The model introduced in patch 1 is now arch-agnostic, and all arch-es > are being switched at least partly (to at least give examples of how > things will look like); PPC and RISC-V are still small enough to switch > completely in one go. > > 1: common: assembly entry point type/size annotations > 2: x86: annotate entry points with type and size > 3: x86: also mark assembler globals hidden > 4: Arm: annotate entry points with type and size > 5: RISC-V: annotate entry points with type and size > 6: PPC: switch entry point annotations to common model > 7: tools/binfile: switch to common annotations model I'm sorry, I notice I screwed up with the numbering of patches 6 and 7. I hope things are still clear enough. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:35:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576901.903568 (Exim 4.92) (envelope-from ) id 1qRoP1-0007To-Tv; Fri, 04 Aug 2023 06:35:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576901.903568; Fri, 04 Aug 2023 06:35:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoP1-0007Th-R0; Fri, 04 Aug 2023 06:35:11 +0000 Received: by outflank-mailman (input) for mailman id 576901; Fri, 04 Aug 2023 06:35:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoP0-0007TW-TM; Fri, 04 Aug 2023 06:35:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoP0-00021Q-SJ; Fri, 04 Aug 2023 06:35:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoP0-0008CV-Dy; Fri, 04 Aug 2023 06:35:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRoP0-0000Zl-DV; Fri, 04 Aug 2023 06:35:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5PbYwu3sgetDo0FQzUj2s6Pd6GQZfaKxe4ylDAkuMGU=; b=r/uI3E5Sm28HkJ8wF6dBMWfnoo xj0SQe06rhD87IY85GgB4pxAIoIHFk8dtvDXH3kYncQ1xkmamcuIX+m0sULIFvltm/U0khG8H2biw XvFPWNgq9P0UoBosTBO32+woqARMO0rI6bcj91toYTY/FNDRlPhwDPD7E+JITOVSxTR4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182176: all pass - PUSHED X-Osstest-Versions-This: ovmf=01ad4134c3e6339ac53c85fccf62ed10d5b6d662 X-Osstest-Versions-That: ovmf=ef051451367fa5455d75b38c407ca352a43b4849 From: osstest service owner Date: Fri, 04 Aug 2023 06:35:10 +0000 flight 182176 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182176/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 01ad4134c3e6339ac53c85fccf62ed10d5b6d662 baseline version: ovmf ef051451367fa5455d75b38c407ca352a43b4849 Last test of basis 182168 2023-08-03 15:12:09 Z 0 days Testing same since 182176 2023-08-04 01:40:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Hao A Wu likun su jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git ef05145136..01ad4134c3 01ad4134c3e6339ac53c85fccf62ed10d5b6d662 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:43:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:43:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576908.903578 (Exim 4.92) (envelope-from ) id 1qRoWa-0000b4-L5; Fri, 04 Aug 2023 06:43:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576908.903578; Fri, 04 Aug 2023 06:43:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoWa-0000ax-IO; Fri, 04 Aug 2023 06:43:00 +0000 Received: by outflank-mailman (input) for mailman id 576908; Fri, 04 Aug 2023 06:42:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoWZ-0000ar-6p for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:42:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20605.outbound.protection.outlook.com [2a01:111:f400:7e1b::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25612bf2-3292-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 08:42:57 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB6788.eurprd04.prod.outlook.com (2603:10a6:208:18e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Fri, 4 Aug 2023 06:42:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 06:42:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25612bf2-3292-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNpQSb1DKdlGkCwkqyq1os1zxY3MqMRr0PUSZH9onK4vR8L9L5W6ReJU4p6O9Q7jCmQ6BCk7ppAXo4DxO0EZfPE8pVMB3r0M2w/hw9gs6+QlajaytFP/0UhlntJRgc5g5trro8Ma74f2Daa2jS5hldRZNmpSPO4ClHXshwWh3RJvhsYgEoAfXjbAKgJXs3mhQ/1ZFVNIsvS2t3smvcPpi3WfFhG0ePc6EqTjo3Gk7JfJVfV8A0WbR0Wu/CGK4DJWWugCR7XTZuEhvgC2Kn92qVqXjcWFAzxHyu8HSH+owDfvO2fVMRAqXmbuJNX/NNhGGTyN982ROl794DMWKYDnRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MipxFbC5XW6h6ZSCdyA1uHNCMDd+wtvdifl8Nc8zk8o=; b=mdfTz19GaVYXhkiRgmX91VbcHqiQtj3FlJTA+qfYsRe54jSnGX96I58ANGl89Idn89WbDZ+pgn+1ddIr1LZqY3M9W0nzum0BosaZ2NZhZDtwxnZOXdXhjOk8dKwFIhdNbks2pJfj7gGDTm9EuEu+ZzJkXeywVeMtj6oQqO/1Do5r/+gWA6iVE2iN3oK1EYCR8EVafUhnZZn9Sm5bBEJpyMfqD4tjrJ5PyVygh2hZD0g7X4WK47WoxylR/Q/xgys2OjQW+7o4UMmBlxoyVTZ6rIhg3bblZSoiQB4MifxtkA3q28thZ2HCbuXwk5+zH390zYwbzdMgGWUg2WX0hUWoHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MipxFbC5XW6h6ZSCdyA1uHNCMDd+wtvdifl8Nc8zk8o=; b=Wi6fGfz/VSiCOuEEtj/oFyMBLhHgBWhBRczPZQa+Lw5vTms8/jD4PV3q10yb6ClfVpd7bw+BnJRlGPALZe0DIXa00Z4NQQgtHiA+jJFTGKjYf960jL8K0fvSm6EN8vsn2aeQbKQTQWugD/0DaM73GipdTmQwvxQxdp9c/MkfHFz9Ldh5qUGuk6cYyQJzdyHUvieGmaMJ3/LvsGoYgdvIjiEMZN+I7Oy0D8lyjCSo3qOVgUeysLq4mOxw6x/zzDzmw4gHnLPUHHDxLj1Ya1ivz+Zd3sUWyD87XVUe53cDo/ibgKGSqAytHMgzekrrNzwiY/bZH8tLaNkXEmRDbW9ZyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3a6ab847-fd31-60e4-2558-feed71d670dd@suse.com> Date: Fri, 4 Aug 2023 08:42:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Stefano Stabellini Cc: Nicola Vetrini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <7f8cbd8c8ad64cd3a0d099f31cb4d3fad48aa63b.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB6788:EE_ X-MS-Office365-Filtering-Correlation-Id: fcec7eec-f73d-4be8-105e-08db94b60892 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z5DPAWAIcO4j3WOuy5K4LvG0QxKsERPdJ5kd/V4yxyABbz0eDEVqZJydYBr0wkM1on/NmVYLOFTQJ2wLaPqIwXLtWykQbmcilQKHJK2mj7SdWhHNxpznp4NSVOVqoYFf33KKm85LyLkiAg1HHJvsRBu6Kz4Co6ZqGKVp/eOJpZF1HXrocl7Y5kR7sANVhSKkKaZlY7cx5E7XLmvXXmgKM4RM/bv3LjNeJpt/qo4MySDudS0wWlmXMRu4sXxUH4L0sdtFDkPFQmNFtLbiWzLcOQG1rCll2WJ7ZGY8GQ3z36kdTEHJJuA2eECe+po5ryZDTpE42QIkk27pBqjKe9Sj0xbXFtk1bRwhFi4YUDaPX8/jwmJL/f3qMoJ5RrutGENrWmwc3uenAeoOwt9QtYbfG47MiGM9ReXRhoeJqdAOvYn2YT1Q2MLznfO1AIr37DbWNTK74hF2NE1GS1NVzuyI85ZQHVqB7YO80fyt5V1d+nRtUa1APy6CBQHH94E47fsYsDjRINNunZxA2jsmTA2/Wh1o2QlLTLe455GmwdzXDNs3aP5kdKWPxdctp/CLVxlNCz1Rxxetawr9X/J53CbitP++IaSP+ins+ZztSxjcoAdUDReS9zmajZXuGQaEXQt49g2ilyVu1mOoazbUeStWmg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199021)(1800799003)(186006)(31686004)(66556008)(66476007)(66946007)(6916009)(54906003)(4326008)(316002)(478600001)(36756003)(6486002)(6666004)(38100700002)(41300700001)(2906002)(6512007)(8936002)(6506007)(26005)(8676002)(53546011)(5660300002)(31696002)(86362001)(2616005)(7416002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUhnY2lDdkg3VTJhNlpGYkVnSlJ6dko5Smxhc1kzTjJOU2ViUXhTT3JncUJu?= =?utf-8?B?bVFYRlVwK3dZdEN4TnRDWDVrZzZXWjd3dU53ZnI1STUxZW1NcGprdHZRZStR?= =?utf-8?B?dXA2ZmtHa3RjY1lwakRqWlVjS0FndGoybkJhVU1LMVk4S3poNlplUnNwZ3ZI?= =?utf-8?B?UXB1ZDRBdlo0dWR2SFFaQ1VyOTVtU2xjZFIrcHp6ZnR6clFwMGcrYTFQdWdS?= =?utf-8?B?WVIxN3NsNE0veTIzbHMrd1A2L1JlSnNXazdMbURydndGMWVkTXQ1MTd5OE5h?= =?utf-8?B?dFp6amVkU0xpQ21wWTVjR3hwSDB0UDkrOXZQT0VTNVptMzRnSFJqclJWSVFB?= =?utf-8?B?cXdBYWNSd0VQZW5wSjM3MTBiblNQVlpXZEhLeTZBZUEwOXNjSU5TNWFUYldZ?= =?utf-8?B?K1RhcnJQdUQvRnpZZkhVL3NzVHl6S05TVDcrU1d3emRxZkNCSi9qbWM5UnJq?= =?utf-8?B?R3d3czNOQThOK3lTYjdpTVlEU0l6WGVOdm1aeHg5SVNlYmhjdVRQdkw5Wkhu?= =?utf-8?B?UzJodm5GZ1hMcmRpV1VMODAwRkNzdEk0U1BYaGdPaTd0UjltdlkvUHJtWnRQ?= =?utf-8?B?TDREZjJYYkZKNXFGbUxwaGxrUFJwM29uayswYnpLNXArNFozZjl3blAvSFhJ?= =?utf-8?B?Qkh2N1RCeG1FbWt5Tng2aHBuem1ZZ3liSTZMcmNVbWZQSWdHZm1JTzg1Yndv?= =?utf-8?B?RFVSamdlMm9jWUd0U2krbUlMY2kzdGNlS1YrOFd5cXhVSVhJMFFhMHllWm9J?= =?utf-8?B?bjhNUHQ2SDFnVGIvSVVqcGhMcjVhMVRQMlljTW85UTBIbU5mTDJKVnlaK2xy?= =?utf-8?B?OUI0bzVNS3cxMjNFTUl0eFhYNDEwaSs2b0tVOGJPM25GQU1hRFlNQzlqdXdv?= =?utf-8?B?dmlyYVZzQnd2T3J5K2dlVmlnWnBlc3hkM3QrRWxoTlV5YVVzaEIxbFl0Tk5o?= =?utf-8?B?NE1ZdFNnRG9YZXNaQ0FMSDVYNVZwUzdZNmdrcWE3ZHp4ZVQyeXBoczVNQkQ3?= =?utf-8?B?dEYrMHZyUnBXaEI3OFhIK0RFbjJ4RFpVcTBwQnMyQXFkRkZQaURqR3pMdDV0?= =?utf-8?B?a3dIa3ViUHMzNzNqZ2IxOHF3TTQwemJqQ0d6T1Y2UWQ1VDFBdUw3VmdXRTA4?= =?utf-8?B?U2RwOWFJOXlKbDJMV0kyZHgzTkJQak10NzlxM0d3amc0US9tUTU4VHY0K01M?= =?utf-8?B?R1gxZ0FJN3hBODk0YXRoZVNKaFl1anpyWGFpRE85enRvaU5jenNTd2c4WERE?= =?utf-8?B?N21vdFhqYkgzNDRHNVAwdkZsdld6elkxQW9zVDEvdHpVbnl2c1lRKy96L3k4?= =?utf-8?B?VWRlZC9wM2QyaE05dnhzb2JsNW1reTN3dUdPTUtkcURMRHFDZ3RZMHJhcmZr?= =?utf-8?B?WlpwaFdoK2MxY1RaUkNMb0k0ckRXbXZQaTlHajdzRkFtMUdPMjRiQitVWVlp?= =?utf-8?B?QjBCY0VMWjhaM0RmcFNPR3dMeE4yK0lmcTM4NjFYRW9GS0RsWUlqRHpsS1ox?= =?utf-8?B?bCtIdk5aTmtubUVNalBxblNmRThGeFIvQ2RCVk1VSmZMMGJsM2VvNnBtL2FY?= =?utf-8?B?SjlFY0N3OEJFY1RsMUhTb0cvMDhWWTZ3SCtaUDdONWhHYm1OZno1Q2wyZ0tS?= =?utf-8?B?Rlphb3F1SnJMTlROSVRKNGZTVDFZY3VRTEE5cjlKOGd0czNDTkFqUFhyK05C?= =?utf-8?B?d0pGZzB5WUpyYWMwdElWdDJnbEd4S2NTZTdFUThCTHR2WDN2TmlLUTB5VzZo?= =?utf-8?B?VjkwR1dJTGd4KzVrbTBQSCthZXJBak9Wc1djczRPTGdaWXdLamR4SDRieFpy?= =?utf-8?B?Yno3THdCOC85a1hhSFYzZ2laVGdLREg4QmZ5dU9SdEI3TElqRFZYRzJodmZP?= =?utf-8?B?cUMzQkdSc0NCWGRqdVlhWWVWU3ZnTytySFBmbFZOZHJDWDFsaGZDOFpkcUQ2?= =?utf-8?B?VCtNMkw4Ynd0RUJBMWVHUlYwSGpKOCtCQzR6SXd0L2JnbDBaVFJJUlBNUkt6?= =?utf-8?B?QUVwVGdHbzBhNWVlSEJwUElFVFpIcnRIRGZYZkVBckRCMy9xaU1kVXMrZ1R3?= =?utf-8?B?NU1wcjQrbk8vUGNxaUxib1djOFdEcmFDeFRvMUVnUXV3R2NlUGIzQktSRU1L?= =?utf-8?Q?dhkAgJhfpPBygBZqoh76RV/gP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcec7eec-f73d-4be8-105e-08db94b60892 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:42:55.3311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: edPSYE0WXOau9Pi9pg17ZrCBERaTdqwQ3IlMgkW6cepUBHfbX/Vc6OdI2ptyjhp0oGGRlzJB4exg9kio5qJCbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6788 On 04.08.2023 01:50, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> Rule 2.1 states: "A project shall not contain unreachable code". >>> >>> The functions >>> - machine_halt >>> - maybe_reboot >>> - machine_restart >>> are not supposed to return, hence the following break statement >>> is marked as intentionally unreachable with the ASSERT_UNREACHABLE() >>> macro to justify the violation of the rule. >> >> During the discussion it was mentioned that this won't help with >> release builds, where right now ASSERT_UNREACHABLE() expands to >> effectively nothing. You want to clarify here how release builds >> are to be taken care of, as those are what eventual certification >> will be run against. > > Something along these lines: > > ASSERT_UNREACHABLE(), not only is used in non-release builds to actually > assert and detect errors, but it is also used as a marker to tag > unreachable code. In release builds ASSERT_UNREACHABLE() doesn't resolve > into an assert, but retains its role of a code marker. > > Does it work? Well, it states what is happening, but I'm not convinced it satisfies rule 2.1. There's then still code there which isn't reachable, and which a scanner will spot and report. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 06:47:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 06:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576912.903589 (Exim 4.92) (envelope-from ) id 1qRoaz-0001Dl-6S; Fri, 04 Aug 2023 06:47:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576912.903589; Fri, 04 Aug 2023 06:47:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoaz-0001De-3Q; Fri, 04 Aug 2023 06:47:33 +0000 Received: by outflank-mailman (input) for mailman id 576912; Fri, 04 Aug 2023 06:47:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoax-0001DY-8M for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 06:47:31 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20600.outbound.protection.outlook.com [2a01:111:f400:7eae::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c737f687-3292-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 08:47:29 +0200 (CEST) Received: from CYXPR03CA0050.namprd03.prod.outlook.com (2603:10b6:930:d1::15) by MW6PR12MB8707.namprd12.prod.outlook.com (2603:10b6:303:241::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Fri, 4 Aug 2023 06:47:25 +0000 Received: from CY4PEPF0000E9D4.namprd03.prod.outlook.com (2603:10b6:930:d1:cafe::50) by CYXPR03CA0050.outlook.office365.com (2603:10b6:930:d1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21 via Frontend Transport; Fri, 4 Aug 2023 06:47:25 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D4.mail.protection.outlook.com (10.167.241.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Fri, 4 Aug 2023 06:47:25 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 01:47:24 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 23:47:24 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Fri, 4 Aug 2023 01:47:23 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c737f687-3292-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItjTyImhefCfRO+Zt571kaiaAQQk3fITBpasw/WykhgCojAQ2ji/O9Mla1NeOUa6nu8NYxhxWeuMyyZmmeqM0MNy3N536pJlOCvizjLPE0Fmu7aJc+YZm8nVcXj0qM7coqNy+jAoFwSW+jGToYao/dLtlYipz7KCuV7o3fflr3yw7+DBwPpQeWaA1fJPdVE7KRWANxZGCldVlyEjddvvAQjCqqmRngkRDovt9yvw3po2GNNz9uOjP7eyqK3A0fC6jxm16HOBx41cpVroIJ3xIQ6gCZshA/6VXHoMaqg81WeS7hyLaw2/co94dt3UZKUADCx/ajmPW543SdEX9OlAwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tk07luqyc19Gb4QVPiE8g/+iyvi63Oe8nAIjXx8Mp0A=; b=TlLgWTqkhqExtKSP8+Oo1S3spAOGMGuJ4jl3jbhtLRjUMGvAKS0N5KOqLZld+O5pIk7gMrTZ0uBYCKOb73ick0+0MZn1haCFVy0GELVuJFCvy9CDEkPWIDPwI67yUNhtu5aVA7l5BqrCOxPiOCAfxfuhDDlMcRUuhfvU89c3zEo49YY8Cmy4TjrmzUmfe6Mm+qyJMMuS+8p0PmZNvDz0VuF5dbO8zOTcx0R2EV2DaDFzuyZF87bO30mFThon6tePcVkkMIjLZZBPt2UCxIETT8FYVtjKMEQgxSJB6UnsRT5fYDd9zOS+7SyGnQeHw03pzSi79Bgcjbc1gzp4P2OUKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tk07luqyc19Gb4QVPiE8g/+iyvi63Oe8nAIjXx8Mp0A=; b=Vqg7XSm4j18n9gbvrz3hupVVb3EiyYzcgvEBGTqLXdbAWVleJYBTiJy/n2v4f+g4mPnmvcg6qDghemCK548LC2gzJx5HD6ONER+Ufcn9De2kA71aSOR5JlBmqATi60dEaj6sRlCPS+xPKSmrgSV1SxDkIzPIjxG/kUv+JWzUecM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <0300d94b-33dc-6ec7-11c0-3a926ea7c92e@amd.com> Date: Fri, 4 Aug 2023 08:47:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional To: Luca Fancellu , CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , "Volodymyr Babchuk" References: <20230803144035.4071610-1-luca.fancellu@arm.com> Content-Language: en-US From: Michal Orzel In-Reply-To: <20230803144035.4071610-1-luca.fancellu@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D4:EE_|MW6PR12MB8707:EE_ X-MS-Office365-Filtering-Correlation-Id: 6705fbde-56e4-410f-2cbe-08db94b6a98d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7nrRwV7lNvSVfmeijOy+DT7Jd2jfZOkcsUYg0N9SaEV9C+jinq5ykdHeH8m4DjXNfR8WzM8SJEs2QbwwW9ChNgQoUI6Qzf4uXcSAX3h5yfEx17FLQpaeR3ObSiTyN/7v/jG41wq1NpRonVzw1jPod9oVBObpcA0c3ApcSv3exF7LQcGbuAi54w1qSFuZkeDDKFQ76OKhDYDWReY4ok2oj6lcc7v45oZlg2gKOcsL3yGVjalYdBq0pNZGy6/FMkBT1ha2YnF7wB64aoPcfvEvrBpgWvjYkVgTF4rSa5VXVRvQMsyvfVhtpd3h7E3TqWlEoEXgep2B43gqFSFe0gUWYV6p01sXFBQNvPultKwbEK0Lpncxeq8WsyCiNYH9BZfsYUYacqXqLKD83TcfxU1kGnlGw9xhirKAPW+nCf2xB9hMEGO6Vn2v8CBCd7Jvth23Mwgh9yWKGezh4M70UDBmQ6NFf+lF9knLchx7yjxZx++24Fm/jPFiJIiamFi7R1qda7xDHkaZzeM/HGfOuMI8XWgWuncHe5csNam9aohcUESQvLmge8ULEjLwdui8DwMKDbyNuKCU7v8l8HILP+gP2BS2bRm4Eknrv9p2chH/osza0pb92J9YXjorMdEA0eeLwcwt18cJfxxoVvQJ1wkd25PVj9+idkU+nMhfpkhqwllkYu5sTPK4XLlmwIkV3lBRdi/9IcUY5yfnRVq7zUWwiRHsag2GhWrKsRchPD3ydzvMzevxR3wrjpcgwN3xR4BuBbf0bNeeL7+Lfe9MujqtmlrnPwlJafL+jAJfEdYY8KtOrwhRIzwTrPB++CV20fD7 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199021)(1800799003)(186006)(82310400008)(40470700004)(46966006)(36840700001)(31686004)(2616005)(426003)(8676002)(8936002)(47076005)(44832011)(4744005)(2906002)(31696002)(86362001)(5660300002)(36860700001)(70206006)(70586007)(36756003)(41300700001)(66899021)(16576012)(356005)(4326008)(40460700003)(81166007)(53546011)(316002)(336012)(26005)(478600001)(110136005)(40480700001)(6666004)(82740400003)(54906003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 06:47:25.1679 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6705fbde-56e4-410f-2cbe-08db94b6a98d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8707 On 03/08/2023 16:40, Luca Fancellu wrote: > > > Introduce Kconfig GICV2 to be able to compile the GICv2 driver only > when needed, the option is active by default. > > Introduce Kconfig VGICV2 that compiles the Generic Interrupt > Controller v2 emulation for domains, it is required only when using > GICv2 driver, otherwise using the GICv3 driver it is optional and can > be deselected if the user doesn't want to offer the v2 emulation to > domains or maybe its GICv3 hardware can't offer the GICv2 compatible > mode. > > Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:07:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:07:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576916.903599 (Exim 4.92) (envelope-from ) id 1qRotr-0003oC-QI; Fri, 04 Aug 2023 07:07:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576916.903599; Fri, 04 Aug 2023 07:07:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRotr-0003o5-Nd; Fri, 04 Aug 2023 07:07:03 +0000 Received: by outflank-mailman (input) for mailman id 576916; Fri, 04 Aug 2023 07:07:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRotp-0003nz-MQ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:07:01 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062d.outbound.protection.outlook.com [2a01:111:f400:7e8a::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 819bb245-3295-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 09:07:00 +0200 (CEST) Received: from SN7P220CA0010.NAMP220.PROD.OUTLOOK.COM (2603:10b6:806:123::15) by SN7PR12MB8771.namprd12.prod.outlook.com (2603:10b6:806:32a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 07:06:56 +0000 Received: from SN1PEPF000252A1.namprd05.prod.outlook.com (2603:10b6:806:123:cafe::65) by SN7P220CA0010.outlook.office365.com (2603:10b6:806:123::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Fri, 4 Aug 2023 07:06:56 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF000252A1.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Fri, 4 Aug 2023 07:06:56 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 02:06:55 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 00:06:55 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Fri, 4 Aug 2023 02:06:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 819bb245-3295-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eqh+4qcNyMAVPeMXeLDSjZ0djKRQipYX55/KGwb0Hc60t8vdCvjAlL1LLxKGmPj4r4BeMGgLYA7SdQQOperYqRoUUajcdMbH2Hj7PC2vp9np6GHcPY/9i2jQeKnuKBmxfqwPpF0DQnQVPIDBer9e5Wd08A+GHzmYp/rZKoV89YcNaMM3PRhNfWGnqI59mmGawslh03B9qKUJDzsz+Wp7uaNgJGgxw2q1qQxb7cT5hiv8EDr0vC0rWzrviWaFoUnABZQ5YFaH37hdyIrHPMpNU5F6sZ+cZKhTiOv3j+myndMO0ieEcBCvC39BfLOUYoN8plHjElhL+Bo6Nd8ylmOmug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rkze//lRjPx1EWbTulYsy736B+B6W8ahIeAajZdiYxA=; b=jDha9KlckQ1ob2ZXcSKGxMxRTyosrYWFIa66B+Wy3xVNr1QusycATJy+FBvwOEIp6qUMbKXYLTGAKNkHDKq4zef3gN9fG7HOfvvwnMQ/fWaLybRPRuG+pYO00Vi7zKQqRXjsCG/cQdbAPN6O1ljthfmzIGbC1dhbp/xWpi3ydFPOXC1aXYaUZ3+BG9HkLjmW0Tc/T6tnDHhmTwMGVDgDoSZiXl1tEvnFSmvvodoCMLHRaF1HljlknpwyvLEADPkBGMQDixfcBjlM06GYuj6XA5jpR+4sZ8YqwbUtm3nXXvDS5sJAeci5mJJvShX/YoKXuJzFnnK7Ut6wcN3b2ScK3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rkze//lRjPx1EWbTulYsy736B+B6W8ahIeAajZdiYxA=; b=fO2bPtIUYzu2AZgcSRY5gQA0nR1HEaB0Hjx7bgy+wxzKlBU0nH6KSYbZz/HHipa/F8NKYarIlcC53jGWiKzVfqunPWEY6LywB5MLE+iLEnqSM2PFoiMh09aF4R0l7mmv4nDjmvcvRVhYUq6xgBuqrEU1GWl8/cwKK7nr382mgGI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: <2a72cbf1-a9d7-6edf-37f6-5197c9d40452@amd.com> Date: Fri, 4 Aug 2023 09:06:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: "Daniel P. Smith" , CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> From: Michal Orzel In-Reply-To: <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A1:EE_|SN7PR12MB8771:EE_ X-MS-Office365-Filtering-Correlation-Id: 2943bf56-6807-4896-e705-08db94b963d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L3Zl/lnuL7F9pZRQK7G/896U3nUuBXcxHIXSBbgrIdCyW+QM+0zmYluZPmCU23IjCG4ipKi91CnquDNuEEKI4E7KbCAxgZcjWZBlzF6ZD8Hf2K0aVMiX7sMqLVCGcH9XXB5j6L92jCgZyAyvSxmSmlbeq2K7yqYK1PM6DoZDoQOnhjjN9zZ86qtWpmFM9hZ6T/1az3moEe8Mgy7JhBWfrieYAJOPwFMaaA3GMAn7AnoHoz4eX1kPYilzaItdNU8e36qqokRHBfrbngm+YOawf6PX2Vpn2Uqc/HiUn2gG/S4ytXKI0ZUg9UYrTSTTVL6T+EEB9J7TRiP9eKwimgn6a0/1XikC75XZ17guYEA834xSYAtkrd1a7s0Rj1Ja/AEphgIsDToW5F8k5mIXe6c2t8mtLH8XlsNhDBb3UYE7pwAvq3kCxc7AnrOZxP2otsGOx+ov3JH7jdfx6B2VWdFLbl9OYNAMSdfx4GpG9we93A2+Zgm89tmbkE2k/DZxtFkEw33noQUz1qoH/W3GjfPxStsUHyd6MwiFwGj607rPpmSEqR91WYzZtEj9YAgjf2ACmxf5mQrN0tYBfpeCK2jEzRmbCizSfBGmr+9U4jmE6QIm7dURJInL97c9SuFwJXtiWeW6ZwG3sOB1FCh9Vh4OAMSIxUJdlL3gwAZ+FFjjp1WC8+lbXObUYYVCgvbBuAg4tPY9OZqaYy/Ae73yV4xHGVREnHkB2hOXqNcOq10+hY99huZi2Qv/Ursuteo7glAqXG+h+20s53PsGOF+yXFB9jLOKnfCN4zdrtUj0GXJZV9LKHos+8gwPBUQJcm14EAn X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(82310400008)(451199021)(1800799003)(186006)(40470700004)(46966006)(36840700001)(82740400003)(40460700003)(2616005)(53546011)(8676002)(26005)(83380400001)(336012)(47076005)(2906002)(36860700001)(316002)(4326008)(70586007)(5660300002)(426003)(70206006)(44832011)(8936002)(41300700001)(16576012)(15650500001)(110136005)(478600001)(40480700001)(54906003)(356005)(81166007)(31696002)(36756003)(86362001)(31686004)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:06:56.6993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2943bf56-6807-4896-e705-08db94b963d1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8771 Hi Daniel, On 03/08/2023 18:57, Daniel P. Smith wrote: > > > On 8/3/23 07:45, Michal Orzel wrote: >> Hi Daniel, >> >> On 03/08/2023 12:44, Daniel P. Smith wrote: >>> >>> >>> With on going development of hyperlaunch, changes to the device tree definitions >>> has been necessary. This commit updates the specification for all current changes >>> along with changes expected to be made in finalizing the capability. >>> >>> This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places >>> this documentation under its purview. It also reserves the path >>> `xen/common/domain-builder` for the hyperlaunch domain builder code base. >>> >>> Signed-off-by: Daniel P. Smith [...] >>> + >>> memory >>> - The amount of memory to assign to the domain, in KBs. >>> + The amount of memory to assign to the domain, in KBs. This field uses a DTB >>> + Reg which contains a start and size. For memory allocation start may or may >>> + not have significance but size will always be used for the amount of memory >>> Required. >>> >>> + Format: String min: | max: | , e.g. "256M" >> There is a mismatch between the description and above format: >> - KB vs MB >> - string vs reg format >> - the x86 example uses string and Arm uses reg format > > Hmmm. I missed this in the hyperlaunch v1 update. In the original design > that came from the working group it was going to use a reg as suggest by > dom0less. During development of v1, we found it was not rich enough to > express how Dom0 could be allocated memory and switched to a string to > mirror the dom0 memory hypervisor command line parameter. On Arm, dom0_mem cmdline parameter is used to specify only size (no min,max) > > A question for those involved with dom0less, is what are the opinions > about using this form for memory allocation. Is it required/possible to > be able to instruct the hypervisor what physical address to use as the > start of a domain's memory? "memory" dt property is used to specify just amount of memory for domain in KBs using reg format. It is not used to specify the static memory region (with start and size). For that, we have another property called "xen,static-mem". Therefore, it would be possible to switch memory to string but it would not be compatible with the current use anymore. ~Michal From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:07:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:07:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576917.903609 (Exim 4.92) (envelope-from ) id 1qRoty-00044Z-6M; Fri, 04 Aug 2023 07:07:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576917.903609; Fri, 04 Aug 2023 07:07:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRoty-00044S-3e; Fri, 04 Aug 2023 07:07:10 +0000 Received: by outflank-mailman (input) for mailman id 576917; Fri, 04 Aug 2023 07:07:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRotx-0003nz-DE for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:07:09 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 865b33c9-3295-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 09:07:08 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8684.eurprd04.prod.outlook.com (2603:10a6:20b:43f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 07:06:39 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 07:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 865b33c9-3295-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7jkVNfy+4US+nK4LWnvkjiyUsYsIJHdh9caaygz2IGhuWrGUR6vN5yKQN+LcWOeXaGlBox9ce9NnTZak7NpvOr1mI61pCShUUmzNlT1Z+fN83+ftUdZiH/LGd03R4ngWx7v8ssh1clXT4061Lbade7cOaQG/SFItBMHmwM1vUesdEYauGtm00/jHLApFrZ19hugCS3spWnapUNxuOjyh/2Fg2P0vIJA9nfkNunLDOqI0FAXa63qqBp2o324fSxjl27WtdkaFpdyCJH1l/WCMfCLzoizULuHLwqVxrA93e+TD9WIBAMPrOUTJLmMaMC9+Iz1k3zlXplrZzFOXKwNrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JfNCjNqvwJcHjKXYrq8LaYLXSHZkrzWwQQDZYgtVdUE=; b=FhQSab2Ag4Nu8JwWPbrg2jyxvTQb1FGjfM0FN6u+rXIy/XrOR//WFV/ZaVntuDmowPA3I+oakUc46//HbhgonLq3WTILWOtdeyA3uP482+7bxMi3E3A86Q0k4EwNoLWUuaGp6rpC5JAX3WepVQzCWXIiqRA00YXk4uwrNlO400I3eMyEoCaq8WnZ/miNiGWrzdBXGm6JHm23xiUBAEl/HLIuNvbtl8w2pVQ6zq5KkZ+bWD7oBiHU60hkhYDszs6ctGA9LqjwDqxVvrqMcmBB+P3PvKkI8rj3aMjx6/CgPx1OXlVUdljbOT7bmcYbcCar3oRCv7TaLZBX6zJbPKxmpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JfNCjNqvwJcHjKXYrq8LaYLXSHZkrzWwQQDZYgtVdUE=; b=kR1KVOiH+DlHn0lf28p2oF8EUUDKkH7doG/JxL6kz7VQKS2f7gLdqe2vREVL58uuKqKl28S5PXfsIfcb2TZFTM6i7i+yqsrKQPD41nWiZp+uKplJz6dI6Q/UFa59ch9dNhRBI+01+m4jMq8BRG0UgtmtM/NY+BYCV37BY33+WSHK12u86VqnbM4tQvesb630NShfTqvEa9+8/RyBO4PSPrQyL0iaAFBdQxZFxyqOixSo4sIQhAj+qIRGXY6ysjjkC/jEY8k60knsYdBnB09XJZQ4f4lSGcDhJjMR4Df29EASuMmSBV8+VmLlF+HPG3MyVvN1bbwcSDqoz4DhF1KEyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8672f79a-3e44-1cc3-b448-9ee4a4ed9090@suse.com> Date: Fri, 4 Aug 2023 09:06:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> From: Jan Beulich In-Reply-To: <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8684:EE_ X-MS-Office365-Filtering-Correlation-Id: dcecc94f-cdf5-4808-fe3c-08db94b95936 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rN96SaNeadZgInREF69IvrVSdLTiny8EsKy9IF9ecYumatZ3t/umrhkyiBZRQM79S7VrPt1Rj9gBvaIrnjleVOZqsbqCVuCXD/DU7tMFsHYaiLEg9lxm2AkogZMwSLJQ2fr+/LqsSjiaf/2hqSaWFXs8DcrYOKpFH/kw6x3iuwdPbg0z4b2N/luspRd8b1sgMNwk8v60LYugYcypvl/ioUwpC878eZ8syD2WP5mgIQ4j4fI4qd3RleEGsZ+Zw3Meljama44R0Z9rrBd4Mm1ciiMNoJ7sWgEqhRk0LPEzghlIxB6ixt7Nkx2ZqgCLTlPMLq5+vp4DhgBlCY5KXmTA7ZwzTV2gXEvqFuLexSAr4CSR29++zDGy2YE/Xuuxpc/OpgojsuyI5DBw71E17rchQ/lG4//j/AB7EuM4FBQ2zvG0DBLIkzik04vXvJjbOo+CNM7W1cHGQ22ECpssXJi1Tw6gUHBcNOIPnEWhUfKmcFXEjoDzZW7AXMSRI2t0whQ/aa9QeuqOFCERFbem5xyf7Ydh40L+ydTxVjAjKB4EutmZ0irV5KC+pGBcaZMp7ai0YfoP9keZeY2/zYuycCq5M1V6eUj/fQGvkXIsfV0y4h6RZggCkOpYoNGjPXdzZBL4jLMCbDtRSO93lDqA91WCGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199021)(1800799003)(186006)(2616005)(83380400001)(53546011)(26005)(6506007)(8676002)(66556008)(316002)(2906002)(66946007)(5660300002)(66476007)(4326008)(7416002)(41300700001)(8936002)(6486002)(6512007)(6666004)(54906003)(478600001)(110136005)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDQ5Y01WYjE5aVlJcmYwZExFYUZ3S3p1UlNlbTIzTlhMRnNvalpuREZLZHdu?= =?utf-8?B?THUvM2VNcDlVeHd3ZXJiVThvYmZMdzdDM2NiamZWZy9DeFI2NzFWbUEycXpj?= =?utf-8?B?SHgyNW9GNzY0c2NHNXovUUFVYkJkM3ZQRFI3K1ZBdmRqdzBJNllFZlBFc0Zo?= =?utf-8?B?REZraGpTSTFGRVlZMDBsaDFlMFdyNWk2dlZQYXZoVCtFYXFJdGdTVk5zNkdW?= =?utf-8?B?SXN6Z3JkaVRTMFdnUDZJVFNlTXNqWUxCcTBFeURRRlVmMG5XVHZtOHl3cEFI?= =?utf-8?B?akNHYUlNVDFjUHVjRkR4RThOMjFrbE5ra2d5ZHcyQlJFODdHMnRjcGNTSFpT?= =?utf-8?B?ZHBERGk3Zi90a3Rya2E5Q1l5eTgyakF1TVdNTnBvUi9uRGFDc2hTamk4NEEz?= =?utf-8?B?VFpjZzVjVmhOMTA1amJKa2pKMUUzT2VSWWpnMlZ5ZzY2TWhZbDdrZ1REM0lF?= =?utf-8?B?cXhydzB2SHFNYmhFemxRbkY1R0dleGI1L0x6NDk2d1FpYXB3SkZKd0o5cmpG?= =?utf-8?B?OEZaZ29FMWpsTGxtTjhvQ2U1UGtSQlJUdFl0akc3Q3d2MldUdkIycEFGRGN3?= =?utf-8?B?d0dnUnJiTlBVU2Ria3gxb0JMR3lzTHJVTFdwZkZpSlFFblI4cERYZ2RyeUJy?= =?utf-8?B?L1AxQVM1RzNCem11dkRGNVd6QkxYeTAxNmQwWFlnQVo1eVRpdGpuVXRDK0N1?= =?utf-8?B?WE0xdnR0M3RoeTBoYVNNbUVXdkxrRHpTWVRjQnErMitIL0JXTDNxbkUxZ2FF?= =?utf-8?B?dHFxZjlLZmFVbk0zT2tpMHk3K2pmcVBEMzFHQ1ZZYUN4aDdvaGdTWnJXckxt?= =?utf-8?B?MFpkcjVPY2RoYzlpTS9VazVHbDJhQUxUa3NpQ3dCQ2dXUGloczlTc3E1S0o5?= =?utf-8?B?Y3F2YXNpS2ZXTE9OSEJlRkVkUDI3WFZabE1pUUJxOGwzK3FrL2YxWEhxUkJp?= =?utf-8?B?T1dnM1dJaGpUdVJoS3NGSW9nRnFuM2plaUliZ1RSWE45Q2xoWVgwdVBSSjhu?= =?utf-8?B?cDFMRW5iREI4K3RHdmdFR01seWEwQUxiYy9YRU9MeVRuOENoc2J1K2FFZ1Vx?= =?utf-8?B?Q2o5R1ExMkRTYWR3ZTJEc2RKNWl1d1dVVDVWQ010K0RHYUx1N1ExWXE0aTlk?= =?utf-8?B?UzhMN1ROenpVZnhaN2YxZmltN1RJclVPQkNEdTEzZHlFaHdMa082Y0RpNDBv?= =?utf-8?B?Ti9HdDdNYmtPallzZ3B2Um14QUlkdkpDRElvNDFFQTBIbXRxdVB3M0YzdU4r?= =?utf-8?B?Z1RsWW9HTkRISTJSR1YyM2h0cDZ5bmI0QThuVFNqN1ZtMGxlQnJKRzlZZXpQ?= =?utf-8?B?T0xvZnRreml1eG1HRVJyVTZ4a05TSnJkV2pzWHYzam5nTUhJVllMY1RvdG9S?= =?utf-8?B?T1hEbWZzL1FBbnhINHhSMWYvaWY2SDhybU9oanY2QVc2T0ZrcERaSUUwWmIx?= =?utf-8?B?d0xYK1pVamlXa283OW42YlpsY1FMNzFnenI5TVVQNVE2YVBVeWVSK3RBaEZX?= =?utf-8?B?bjRaYXR4WlNpSG5wbk1MNHM2Q0cwK0RoTVFNQWVZbDVDNDVHUTRnN2VKQTRk?= =?utf-8?B?M2ZVYU9ZNmRYUS8veldSQktqNGd4RU01VUJVdTJOQnNFcWhMdTBzeGpNYVlk?= =?utf-8?B?Q0pkaTVycmNrdGFGZFErMzROaTN1d0hrUjd3M0V6NDBTZmZvcTVFZklyYkEz?= =?utf-8?B?SXUvMzJwTHZjaFB4Uzl1TmV3SEdoUWxFWFU5eVI1c1J6by9oWmt6LzV4WEZq?= =?utf-8?B?WENPWUd2SFlzSUl6aW82NlgwTlV6SXNLNTZDT0R1OGEwNDZaRjZyV29ibXdI?= =?utf-8?B?VTNqdW5PUTVhUVpDYVBVdy84L3luYXdWSS9VZ01RVFpGbDZlNWdTMWlmTmNM?= =?utf-8?B?QnZZVFZMN3VjSUhOb0ttZ2pKTC9VNUV1enVEZTFkQzEyUDJxSTV1WitiMitk?= =?utf-8?B?ZEs4TkVpNnlKT3lPR0ZCNUdrZFBhSU85amtNNWZNQ25udXFTN1Zwek5ScktZ?= =?utf-8?B?VFkzejZjbDlSenpxWERhRVRmbnJObGJONExFMDlDeUVMR3ZoOTFVRit2emgw?= =?utf-8?B?T3ZTaStsVXpySzhiRWYvc3NZK3BBL2RxUmgwVVB3cFhjVTk0T0Z5YnltOTVs?= =?utf-8?Q?1oqK2SIT/B1+3VX82LFgVpeL1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcecc94f-cdf5-4808-fe3c-08db94b95936 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:06:39.2035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hS0ZEiNATKFgdt30ZlgCyqywdmpnij/P1id2LHsQPJBj+wAbzIdtGeq9eGpGFFyOTTO9YbWWzCEgSTHHJlfGdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8684 On 03.08.2023 16:22, Nicola Vetrini wrote: > On 03/08/2023 11:01, Jan Beulich wrote: >> On 03.08.2023 04:13, Stefano Stabellini wrote: >>> On Wed, 2 Aug 2023, Nicola Vetrini wrote: >>>> @@ -1169,8 +1170,6 @@ static void cf_check >>>> irq_guest_eoi_timer_fn(void *data) >>>> >>>> switch ( action->ack_type ) >>>> { >>>> - cpumask_t *cpu_eoi_map; >>> >>> It is only used by case ACKTYPE_EOI so it can be moved there (with a >>> new >>> block): >>> >>> >>> case ACKTYPE_EOI: >>> { >>> cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); >>> cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); >>> spin_unlock_irq(&desc->lock); >>> on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); >>> return; >>> } >>> } >> >> This pattern (two closing braces at the same level) is why switch scope >> variable declarations were introduced (at least as far as introductions >> by me go). If switch scope variables aren't okay (which I continue to >> consider questionable), then this stylistic aspect needs sorting first >> (if everyone else thinks the above style is okay - with the missing >> blank line inserted -, then so be it). > > Actually, they can be deviated because they don't result in wrong code > being generated. Only later I recalled Andrew's intention to possibly make use of -ftrivial-auto-var-init. While, unlike I think he said, such declared variables aren't getting in the way of this (neither gcc nor clang warn about them), they also don't benefit from it (i.e. they'll be left uninitialized despite the command line option saying otherwise). IOW I think further consideration is going to be needed here. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:12:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:12:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576925.903618 (Exim 4.92) (envelope-from ) id 1qRozH-0005v2-Pp; Fri, 04 Aug 2023 07:12:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576925.903618; Fri, 04 Aug 2023 07:12:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRozH-0005uv-N4; Fri, 04 Aug 2023 07:12:39 +0000 Received: by outflank-mailman (input) for mailman id 576925; Fri, 04 Aug 2023 07:12:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRozG-0005up-RC for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:12:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a5e9e27-3296-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 09:12:37 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 934424EE0737; Fri, 4 Aug 2023 09:12:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a5e9e27-3296-11ee-b26a-6b7b168915f2 MIME-Version: 1.0 Date: Fri, 04 Aug 2023 09:12:36 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn?= =?UTF-8?Q?=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 01/11] x86/efi: move variable declaration to address MISRA C:2012 Rule 2.1 In-Reply-To: <3af75576-4a34-ab0e-3c1a-20a143e993e8@suse.com> References: <3af75576-4a34-ab0e-3c1a-20a143e993e8@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 10:57, Jan Beulich wrote: > On 03.08.2023 04:08, Stefano Stabellini wrote: >> On Wed, 2 Aug 2023, Nicola Vetrini wrote: >>> The variable declaration is moved where it's actually used, rather >>> than being declared in the switch before any clause, thus being >>> classified as unreachable code. >>> >>> No functional changes. >>> >>> Signed-off-by: Nicola Vetrini >>> --- >>> xen/arch/x86/efi/efi-boot.h | 5 ++--- >>> 1 file changed, 2 insertions(+), 3 deletions(-) >>> >>> diff --git a/xen/arch/x86/efi/efi-boot.h >>> b/xen/arch/x86/efi/efi-boot.h >>> index 92f4cfe8bd..b00441b1a2 100644 >>> --- a/xen/arch/x86/efi/efi-boot.h >>> +++ b/xen/arch/x86/efi/efi-boot.h >>> @@ -390,8 +390,6 @@ static void __init efi_arch_edd(void) >>> { >>> switch ( DevicePathType(devp.DevPath) ) >>> { >>> - const u8 *p; >>> - >>> case ACPI_DEVICE_PATH: >>> if ( state != root || boot_edd_info_nr > >>> EDD_INFO_MAX ) >>> break; >>> @@ -463,7 +461,8 @@ static void __init efi_arch_edd(void) >>> params->device_path_info_length = >>> sizeof(struct edd_device_params) - >>> offsetof(struct edd_device_params, key); >>> - for ( p = (const u8 *)¶ms->key; p < >>> ¶ms->checksum; ++p ) >>> + for ( const u8 *p = (const u8 *)¶ms->key; >>> + p < ¶ms->checksum; ++p ) >> >> In Xen we don't mix declaration and code. So the following is not >> something we use: >> >> for (int i = 0; i < 10; i++) > > You're aware that we gained a couple of such uses already? I also think > that when we discussed this we said this style could be at least > okay-ish (until formalized in ./CODING_STYLE). > > What I'm unhappy with here is the retaining of u8, when it could easily > become uint8_t at this occasion. > > Jan Sure -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:24:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:24:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576930.903630 (Exim 4.92) (envelope-from ) id 1qRpA8-0007VV-Qo; Fri, 04 Aug 2023 07:23:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576930.903630; Fri, 04 Aug 2023 07:23:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpA8-0007VO-MA; Fri, 04 Aug 2023 07:23:52 +0000 Received: by outflank-mailman (input) for mailman id 576930; Fri, 04 Aug 2023 07:23:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpA7-0007VI-GM for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:23:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0619.outbound.protection.outlook.com [2a01:111:f400:fe0c::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dab46995-3297-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 09:23:49 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8777.eurprd04.prod.outlook.com (2603:10a6:20b:408::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 07:23:46 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 07:23:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dab46995-3297-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apSjc5Ei0lOGj6XJyieqPtzjCcAsf5T5VIY9SiR80XtRQ/mMYZEpEKzZh3Rz8/Fz6SBcDus8OgPaP3QH3mu9YMRyfDIclxdVDevTq1CBy2LWVbhZG6XiGWXXub3Z6gbSlJ2wFlVFTboAyAM1gYGMP0xt7gLE8qxHrT9kzYjnUth/Xs/i9ix8uIpdXHtXz7ResOBuhV1+Qqwt2AYB/hFd3AzRzT+WRW8/hG9XXrYPis/CZJAMWSsZwKdqxOXF87yCvc2m7SwEpFycFhjVAMToxn1IphMYLAlIHQNDNCnCuNRFiJhFPkOX9de/ceehWwXLT3IKEa66hU2qHbOI7AAqUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+o42d1VH0SFcRv35iYgNrFh//GjvXBLjsTkyv2Bq2aM=; b=OogiZfXETcJnCIsxs5eyFBoRCJsibeLyY1/x91iybgu99sz2GbK4XYhmadOjre1Goj6tPkTy1xy6qg121QqCMjUPOYztY1xut7uVCCVY10PLvCs8rWMvJIXhmEaTj4dP/B8vNqunS/Eo940yegOafbEaleHhY4axs/78aVi/6MDSErgKr0uWPcIRFSEO6mJit4VgNvDjx/GBN9P6mlEuLkdN7ELSql872lw3rBzy235NVbhTnMF33uckCO0BVolB7Z3iTnywtAxZ679jIHNU/FU/OaBQtTXN+e1t/Uylt4U3ldg2C/Dl/voSDUhTKHIMlUuvrh6p69E0vXxT5S4HVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+o42d1VH0SFcRv35iYgNrFh//GjvXBLjsTkyv2Bq2aM=; b=qM6lP1Wa2pjRekE5PpkkNuuLbPlXC6+vrl6oqGcIj1Ogazcn8XPqeyGH1DdpUzGAL6NS6lgF9cXel31XsSZ1ur3rMk3hitHQ9oLDnUn09bouLxhQYCXxL/W5HNW3m+WpsCEzLOKtiv/hdRWkGsLykNDWomwbarQbWx3Z4+IrNrUlgmjwi1pj1nnI/zCrYzIN37HtL8lp9a4c8I+6qbOuGx80AqI7kGctROfBE7qDyPtuH/cBEu3UNQa4rW3h2oVIZIMGmpmA+hER3WGjAlKF3+EOZlmnUCo0ClJXpMNLdfCdCD6gmtYx6u0gZopBxsQ0/nld5xeXepMiYG2/3feo4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 09:23:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Jason Andryuk , Daniel Smith , Christopher Clark , Xen-devel References: <20230803203650.1474936-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230803203650.1474936-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8777:EE_ X-MS-Office365-Filtering-Correlation-Id: cc35f364-d1ed-4b31-0541-08db94bbbd6e X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +23f/aqqS+40gzDchdvjIhcDMoHk1Xx9kSmZ8AmO/vQ9I5HGIeIbJQg9lPL717CA4Hmg6nfk2jIk1tzdmfZw53E2J9hi03hopYDQy2rO8Qmc4dxJdRJSJxOg2o9nrX9CjxacbvgiqM2PbVnFt6E372W+SD4zJ9XPJNfSmKLT0fexYEAHQj3Y/NdBjPASCyqUOOp32WOt8psxUOLNzOgiAHeNMTg8zM+qVLmVo+m1Ipkfsan7FaoSiOidXaBfJMQ7STGjP3rEyhOeFzqgpONJ3TQLxp5LGpMIt3hF/K5S053WGMaAwj92kLS1D31WR9TLpdUEnv1bTNOOVYYz9r6NqN84VFe9gjpNPsht2qLre4NUtLQwIKkBKXSYSchufZx9QUWVyQv/85lVjvdK/2ChegnQ/xa/un0nbgIAYuabB3XQJvv6yJRjAgep6Z7WAangB+PHeAbCZ8azU2UTAuckcdK1RMYizH9IoiSQdiJP+bDLkDkV64yQUy1BgJF1fX2tR703ZgeXyLIpfDgUiI4Ma66x4IgCXU9AQ5EnMilsEgbMyLPDOljS5hUJAuoun/zQPfUaCs1OJn4KYmT8eePKYj4c9Bney1R6t7gZBOIfkE//QppsF05Uzq+ez5n2+rk/MENybva4riVti108VSVLGBBCsbv/m1KFOjh9G4sxnJrh5ouyukrbDuShMdrRHKUc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(366004)(376002)(39860400002)(346002)(1800799003)(186006)(451199021)(2906002)(83380400001)(2616005)(66574015)(86362001)(31696002)(36756003)(38100700002)(41300700001)(6666004)(31686004)(6486002)(54906003)(966005)(6512007)(316002)(66476007)(6916009)(4326008)(66946007)(66556008)(26005)(6506007)(53546011)(5660300002)(478600001)(7416002)(8936002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emIyd1diRDZ2ZUR3WllEVitGU1hBK0IrbjZwU0NGaUJOMlcyVDBZOWY0V25R?= =?utf-8?B?c3k0aEhiWG40NklCOTVOLy9DS2pCak4yZC8yLzFPYm5sKzVla29zQUdNcTVl?= =?utf-8?B?Q0lHVFgyd21LMCtmQnlBei9WVlVKWENqM0dxWkxmTjVHYkZwTEtzbjBTTUNK?= =?utf-8?B?bDA4WkFhaHNuRVRFT0xmcm5KUnFKb29pZzBvRmUvWGRWdXEydEJISTZiNFd0?= =?utf-8?B?UXZldkxUSzBUSWRua0Y3OXV5MGdaUU5mYmlJbit3Z08rTXB3VU9qak5OWWFU?= =?utf-8?B?VUhkUGFITjhlUVZpZGhvc1JLZys5TGswWjJKV0hoMXJJRzBMcCs0NEJTR0tw?= =?utf-8?B?aXJmZVFVbndYNmtCWFcvbWRLWGZkK2NOMm01MTRqT0lob0VyNUx6TFV2NEEr?= =?utf-8?B?S3BpOVRLTE9VZVh1SlBjUWdTaHd6eHJoV05rODM5V29NOHZOa1d1Sy9yMy8x?= =?utf-8?B?enZwVFUwQU1UM0tIWDR0cnBua2h2L3BFdHp5QkZPdkJxck1QOXplTlUyYXN3?= =?utf-8?B?cFpVZC90Qnl1aXUrK20zbWRhUzF0NzdRNW1JN3JEZGRTRktUOFdrdTE5SVB5?= =?utf-8?B?aDdTRzRLVFFhcmk3V2dVczl3SmtITGVJK24yVWNwMW9yeFNqUnRnUHlvc0h6?= =?utf-8?B?d2psTCtsLzVIcWVRYlRWQk5NVSs3Y0U1RWowN0cwMXlkZGIyZ0RHQXhwNkNi?= =?utf-8?B?MnBQWVExVEU1L2lyM1dyTjVmb2s1bDhDektpZDZwMEtPRXhpQUJHNVZjMFps?= =?utf-8?B?MUZlNVlCMGhDZTE5WGFJNTVTQVFCS1hQUHNMY1FuaG50WDZpYWppMStLakZs?= =?utf-8?B?QUs4SGp1RmhSQzlSMGYzS2xxVzJjQ3VsbEFoZmxOZ09XdWFZbC9XUmVWbE4z?= =?utf-8?B?MDVQMUxRVG03dGVZRUpKNWFFNDlTcDZoVkRrcWJBd05UeHV5c080bGozd2kx?= =?utf-8?B?Y2hBYzh3RHUwRFozeUhvSEpLWlhJK1lSMmI2blljQ3cwRVdzYVQ1RENJMW9B?= =?utf-8?B?dWJvL05xeE90WllnaE9UdHdHMVNxbjFSYi9DVitCQ1YxM0kyaE95R0JtV2hs?= =?utf-8?B?Q2lKRThIZmN5S0FwRWZkYkNRa1c2aXJnTFVXbTduaG5XalhwaWQyaDRxU05D?= =?utf-8?B?T21UV2xaSkdyOVR6NDlEamFib0pDOWRodnU1T1FiSGl2OWFNc0RuZDNZOWFk?= =?utf-8?B?Z1k1MThKVnZ4dVQ4UW5UQk9OZUZ1djZCeFp5UzRrN2VUUG4rZ1JNK1ovYlcx?= =?utf-8?B?WnRFVStkNDBWenVBK1V3bW9mV1NBU2FmUytReStnZkw1bjEwdmcxRWpiY3Ft?= =?utf-8?B?NUZoREMxSTJXNWg1N3VuMHdOM2d4QWsrZ3VoeHRxRTdvSDRBWkFiQXpVS1Zu?= =?utf-8?B?N05RVTBWclQ1eXBiMUtJTEdUNzJHZkZ1WlkrS1QxeG8rN1R2L3FkallaWGVZ?= =?utf-8?B?MkNZTWh4dlUyRzJqaHBDc29QNDJFN1IwZ3RuZ3BnTVRiT2FYY3kyTmtvQkVJ?= =?utf-8?B?OUI3OE8vNGhYVzlXYnBTU3lGbmVuUXdTWXFESysrRzRyaGI2ZnJEMnA3eHFy?= =?utf-8?B?YkN3MnlEN1JrR0N6VElRRDZoQkFoOXJLeVp1T1ZHRVZITlMvUFJPOUhrR0tE?= =?utf-8?B?QmlqV3RzTmx5QkU3ZE5kMlF3YWErSTYxYnN6TVNLeUZ6WTlGZ3N2Q2pSVXZn?= =?utf-8?B?VmpQTHg4RlBiTTZtQ253MjNPb1UxVDlUZllFcFhWYm1hcWJoYnpPMlZaMXJ6?= =?utf-8?B?dU5MaEVrODl3YjdEU3QycWtkVzdUaVFEbFFyenM2eFpYRFdhS0JhSTIyMG51?= =?utf-8?B?cUxVNi9XSWRFSmVMaDBZWW85NUE1aVRSWEhIUHJKdnZrMVJUbzVuNzZHSzk2?= =?utf-8?B?VjV6WXNMYm1JMzk2SnRVU3hPSEZiMjZhUWxzbW9wbUgvWGsybVczdkJnamRW?= =?utf-8?B?TkFpS3g1SDFReWlyOXdWbENLbEFRTGFqQzVrL1BjbXh4dGwva1d3MmNmeFlk?= =?utf-8?B?QW9ydDhjSmN6a2UyNmJWUWY5SEVoOWMxcXJGTXdvSDJZTk1DcG5RczQvSmVQ?= =?utf-8?B?eXpUMlhTRUljb1dLRTJFSHl2MDVqV0RiZFdUU1dzSmpiOE1NZVZXWlB6SzVa?= =?utf-8?Q?oqz+aXtjyy3G8SLxbxcAIe+oS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc35f364-d1ed-4b31-0541-08db94bbbd6e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:23:46.2123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E/VeZu1lhtQ9wgCl7L9LJBsCdfSJaG79mgExC46FZhJdzdR5MAI2ur52S+3EQx6G9VTZ0s9vGtxD0YPV7kavQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8777 On 03.08.2023 22:36, Andrew Cooper wrote: > The opensuse-tumbleweed build jobs currently fail with: > > /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': > /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NULL [-Werror=address] > 56 | if (!key->p || !key->q || !key->u) { > | ^ > In file included from /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17: > /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12: note: 'p' declared here > 28 | tpm_bn_t p; > | ^ > > This is because all tpm_bn_t's are 1-element arrays (of either a GMP or > OpenSSL BIGNUM flavour). The author was probably meaning to do value checks, > but that's not what the code does. Looking at the code, I'm not sure about this. There could as well have been the intention to allow pointers there, then permitting them to be left at NULL. Who knows where that code came from originally. > Adjust it to compile. No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: George Dunlap > CC: Jan Beulich > CC: Stefano Stabellini > CC: Wei Liu > CC: Julien Grall > CC: Juergen Gross > CC: Marek Marczykowski-GĂ³recki > CC: Jason Andryuk > CC: Daniel Smith > CC: Christopher Clark > > While I've confirmed this to fix the build issue: > > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/955160430 > > I'm -1 overall to the change, and would prefer to disable vtpm-stubdom > entirely. > > It's TPM 1.2 only, using decades-old libs, and some stuff in the upstream > https://github.com/PeterHuewe/tpm-emulator (which is still abandaonded as of > 2018) is just as concerning as the basic error here in rsa_private(). > > vtpm-stubdom isn't credibly component of a Xen system, and we're wasting loads > of CI cycles testing it... Question is whether people might be using it, and I'm afraid that's a question we can't answer. Would it be an alternative to disable vtpm in this container's stubdom configure invocation? Obviously as other containers have their compilers updated, the same issue may surface there then ... Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:25:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:25:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576933.903638 (Exim 4.92) (envelope-from ) id 1qRpBt-00084H-4h; Fri, 04 Aug 2023 07:25:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576933.903638; Fri, 04 Aug 2023 07:25:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpBt-00084A-1g; Fri, 04 Aug 2023 07:25:41 +0000 Received: by outflank-mailman (input) for mailman id 576933; Fri, 04 Aug 2023 07:25:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpBr-000844-N5 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:25:39 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2061a.outbound.protection.outlook.com [2a01:111:f400:7e8a::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1aafa230-3298-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 09:25:37 +0200 (CEST) Received: from CYXPR03CA0026.namprd03.prod.outlook.com (2603:10b6:930:d2::11) by IA1PR12MB7541.namprd12.prod.outlook.com (2603:10b6:208:42f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 07:25:32 +0000 Received: from CY4PEPF0000EE35.namprd05.prod.outlook.com (2603:10b6:930:d2:cafe::73) by CYXPR03CA0026.outlook.office365.com (2603:10b6:930:d2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21 via Frontend Transport; Fri, 4 Aug 2023 07:25:31 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EE35.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Fri, 4 Aug 2023 07:25:31 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 02:25:30 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 02:25:30 -0500 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Fri, 4 Aug 2023 02:25:29 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aafa230-3298-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VcybARHiuQaG6UnvvnF6PA1DuOr4UrWc/paMINd41ubtTllen7rPJ2yrkHvyH0XzNkl/4huOJvA2o3fBX/MqVmQUUXLkqIkHVf4Gl3DUo7bITD1fxE43ESAFi5jIXaCT08tU9ME+50tYPo7D+OQBwBG+4eTZ3yoewpcaEt6WkzRNEe5D28biHEoLUxzAiZ17TthOy7632TGIz7SqKy6qi7+EZILdCo+tHK+OqPR2hLsHieMsotaBIv3aRk3qxiUGoLQ8NHQVhY7tstoimUk0SDY4t7caHAvDrx5A14RvuHrYVPF7qUCN5njA+A3FL4OhVn9rayG5vvjDcB0tnRpvBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AKPSK1lqQOIFIWEEzp1G0NWYivJnxa4llFHfkl7Hosk=; b=YyX8w23kk3Koy7UXmq5kfZSXEL4riVz3Un0bGYOhIVeuPG/6rnUeSk71ARbu0c5njzfqokosLQlbd9TrqpmLWghHtgae8jQyBtDGObShObdbyldiY8C7pE4KttopjkCKL8vQbDtLddK+46L8s2PKXqYxYNfKWgiIWuAU7Yfk5TUVovsedABwNSWBB+/dFQufobCabbjwWpD5VwXEXJGieTs6wATeYMGL7hbpN0eNw7GJNyq/I30X64dDyvaz8WWOsjuTp2aTBWoGz8l5gJrkuTAfXidf5XvAqxR7zLV2BIIUyO0HupOO2B2+WDyjOBmaeeSSTSPF1UGGPzWeT4yWtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AKPSK1lqQOIFIWEEzp1G0NWYivJnxa4llFHfkl7Hosk=; b=3YFa05QivOgNTSGGc/yc2Qn+JZg0/mWRK1g2n6NrKr/vh2tTQcSQ9ZPO3vbS/ghZ2JRNGrlamIx1MNsWgT3w/qpuTe4HqN+UdXHEuP/fxY+XemfzkVHJ56+XsODAQD+xplj+eCiGYJdq7lqrJrgRIAUJM/tTpyuCTvqSU0mmJpc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Fri, 4 Aug 2023 09:25:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] automation: add missing "needs" Content-Language: en-US To: Stefano Stabellini , CC: , , , Stefano Stabellini References: <20230804011018.2888869-1-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20230804011018.2888869-1-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE35:EE_|IA1PR12MB7541:EE_ X-MS-Office365-Filtering-Correlation-Id: 364fec6e-dd03-49ed-0085-08db94bbfc56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f6Xz/vj41JDuLR+RQELblUqLBlGYg/F9qLMxXq64nkjs18N7qiYnRurmrsdLJSlhovK1BgJbkOVZ/MNQAMYUGAW5cOgt2AnIs6BAy8zZBoFv5EapQBMD/zPN6B8Gyyr5LyBp0PFehSR+vuF+vDNtbfOn82aW6bwNgeEUWK31ZMHPjoe9OoIyGnbVTi7/PVIvNZVcH1feOPejzcjt/ko6kAbRmJlLTtPc9nlfZYuQYICy5oCITlivnf1Hof8qbCTBbHUZvMxoOGtlSq/wA9q809BqEFveu25fMauQLO9IPlhk4ofR9st4NO2BOpgc3f6TNr1gw2KuvfATTnqudlJ80fsO+S04pSvhhjNTV01MI0d6XlOMeRLL41pbRXjhMtJNgZ949fgmGHy5JF2osBjUlWhpTGXPfyfuP1mlPtdMLaZNI/65b2idHDRGk/jinqJRihIMMUvXrRb6VFAsZSGubVShdtuzmjIUQRNRNsGPDlzsoIR+wUfdW0kedavfRLKSARSWrm37BqRG7lR9P5JT1AioyMn69MGD9f3NDoBlD5c2E/7PkVLIHxp6DkRpWMRCqC5k0tbqJ0n8zRnp4Z3tr0D1eQmy6GDMSspjrggD3rGtepcx6xg0i2xBnvp93eFYzbXHRTyXEB9E15D+tjWYKEZ4fy6LCEggFjKI5RjQowE9OjETmc6FmwVJp2kDJ+/ga9Hf8sBrJ/fi2m6smZacrOemaHvJ3KnxIli23KOHqD7KJs8vqB6GQt2nFmdd8d6J2WRH93GOFs4Eb3Z2SbCuwgtnGXUwyY3DK0opvLW/NUpo0EhXUdIxmGzfR4DqaRfQ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199021)(1800799003)(186006)(82310400008)(46966006)(36840700001)(40470700004)(40460700003)(2616005)(426003)(336012)(53546011)(26005)(47076005)(8676002)(36860700001)(316002)(16576012)(2906002)(70206006)(5660300002)(70586007)(4326008)(44832011)(41300700001)(8936002)(6666004)(4744005)(54906003)(478600001)(110136005)(40480700001)(356005)(81166007)(31696002)(86362001)(36756003)(31686004)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:25:31.5253 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 364fec6e-dd03-49ed-0085-08db94bbfc56 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE35.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7541 On 04/08/2023 03:10, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > The test artifacts export jobs don't need prerequisites, so we should > specify "needs" with an empty array for them. That way, they are not > going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete > before continuing. > > Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel Looking at the whole pipeline, I can see that now only ECLAIR jobs do not specify needs. Shouldn't we also add "needs: []" for them? ~Michal From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:38:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:38:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576939.903649 (Exim 4.92) (envelope-from ) id 1qRpNm-0001Mb-AT; Fri, 04 Aug 2023 07:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576939.903649; Fri, 04 Aug 2023 07:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpNm-0001MU-7K; Fri, 04 Aug 2023 07:37:58 +0000 Received: by outflank-mailman (input) for mailman id 576939; Fri, 04 Aug 2023 07:37:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpNl-0001MO-Kh for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:37:57 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062b.outbound.protection.outlook.com [2a01:111:f400:fe0e::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d34cd56c-3299-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 09:37:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9716.eurprd04.prod.outlook.com (2603:10a6:20b:4fa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Fri, 4 Aug 2023 07:37:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 07:37:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d34cd56c-3299-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hoAJHKhaU3AiAoa7RHhCWXHxC5nd4OA8FCd6yZG1b1pSnSz2/CVrvOVh7OxVJhDB1+xWocA5Je490ckfwRaZvknrXVd1s6vJJjA68dUryvMjKQhiQ26MtjkmFEmzZmwhFT1dd/4h/8CBhOLB82qDqpKgkZdA0/0wz2CyAX0YHIZhHB/LiooQe/9g11+4bfzj4swwDMmqNH9rEmqxXbPIXcZGum5hA8TtkKMNF1vXKl3o4KyETbPsQmm2DDJKjDgiHI6iRvAutDR8K9VLBwKgmWfTbaMi6amSXdwfMwVXwJnRMlRL5ccL/S2eecs1nlxtx+lOe6zEQr6eDYNDpEHkRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t4xkYOHi2k/b79+KE7YivMJrRoGNugFKVWE7D78cG/M=; b=RCeV+TmSt7iD/Ud6o6ubm/V5LmTk0J2k78BTPBqG9UbsZf5525tStZC+Kp/oYVpVZY0RRDn3wnnQZbTLQyPt8LQUuuT4F4WbroaN18CsLXDWsHCktc/AL+WNkwMxo7FY919S2MCj1V26ARE7n2/TVrs5cTxxYpJgQLLctRRNNE4d+mXICX/70iJaj3r1H5prvA3hsfJbnMvmDnQl0G89lmFk30PDddlHdSZpIRBEyayyvPAeaqxXVjAdlvsysO7Z1qPg/dPrfZx+phlIKyH6SBRJHrsyGRg6nDy0TL9MBpbaMCbPboe9Qe5GHCvpOLpMr46Cxogzm9lKfxUNMC6HbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4xkYOHi2k/b79+KE7YivMJrRoGNugFKVWE7D78cG/M=; b=Fokrea92m2P8zqujZ2WyfgKQXjcjTU7uZRI9ZJEfPrmysLrKgRn6FS5Q6YgdkptJEDL+KF5boJFnJ7roXrwJh4dc8q/iKEdK5cTmBeHjS+vfSm43sR3cNMoNIM5DmLH7nWQRvdTPGzfOlvxVRMFxMOMpIvFKUVYlIKNxBtgRfspiPe6Lad3AebFDi2VQOT0sFcqI+oeTW27gU4J4T65dG8dXajtVgfmS4C24S10gm04pzgLnqIpXwBHdrFq+Jws52/y3Hx7sgwk986BGjLvcQlrqCLIWSOjJasqoIOq9rS2JCQq+mbRskzN9daeWWIOV720e00yr1VYaNw7brjvcFw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 4 Aug 2023 09:37:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] docs/misra: add always_inline to C-language-toolchain Content-Language: en-US To: Stefano Stabellini Cc: andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, bertrand.marquis@arm.com, roberto.bagnara@bugseng.com, Stefano Stabellini , xen-devel@lists.xenproject.org References: <20230804013438.2894725-1-sstabellini@kernel.org> From: Jan Beulich In-Reply-To: <20230804013438.2894725-1-sstabellini@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0065.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9716:EE_ X-MS-Office365-Filtering-Correlation-Id: 66692514-9822-4e3c-02c8-08db94bdb5ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u7nUns87Z8BoJc1RjeJ5B47ZZy06ixc/3ItNgujhxFwUtg+Fvhr64gZU//h/WIrOp7zJHtyXK7xoK/pS8QbMF8/4yPIpA1wuP5TzmpunQyxsEzJXgapvAZutQvfZUxI8NtGawJcdx9ymTc35aOOvtQShhox8Xe92v+N8lJfLoLj2iEKCa0y/scYOQsK72GUl6ZqR6e4sNvnznuVw0jZ5eTxWMHh9eKt4MJ3HyVHoP8mnNr6qX/BoJT3KTrwfo4Lvw14q+cG++z76+QYuk+DqFz1i5Bk4xFEtRVGGzfiBFkG5W9gm0nETq9ACg01NH2+IAQDeB0fS62GL7oVbqJnMTOXAu9nFmCHa08O5tVxrxOBqdQhjNvxkrukI2SAr9RB2Gu/XwoFuAalXVJLN74lKHe5O+ZxKV2DY1NElRPbTWGHeXQ4d5yUDuv6uORQN+CFgwT4S2ahTqjvVbITD5nfxfN4RSC4Cop4NZVUQSRdFM1kLMcrSjnzXksSzdZiQ/kC9UMKay15nvgaYCBeZuoitpz8UfqqG2/k89jVoDg40AhPMRVOUUpxcB/uo88+8uXoT5vejWw4i5ka9pwyBFKulR12bgE8Jvw652spZam5fyk27ZOIGXmXg0oIFR+oNCBWDA8gtEC9bwcTxxF7Kudqv6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(376002)(39860400002)(396003)(366004)(186006)(451199021)(1800799003)(66476007)(66946007)(66556008)(4326008)(6916009)(2906002)(38100700002)(2616005)(53546011)(6506007)(86362001)(6512007)(31696002)(26005)(478600001)(36756003)(6486002)(6666004)(8936002)(8676002)(5660300002)(41300700001)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODh2N1MxcUpYMVh0TXpGUHVHdXQvSE9aRjFMMU5ETGZjTVZvakpvK1dVQldo?= =?utf-8?B?am5hUXh6dkZqL0p1Z0tubDhId01CMXpQWGV5VjRNcVFxVXREd0pESHk3YnVQ?= =?utf-8?B?SEVYQkRJcFJWVmVvRVcrNTBLWXdzZkE3YUc3VllUTTRFMUNrdXNyUVdVM0k0?= =?utf-8?B?ai9QdlhkUkY0SXp4TkNYVzhsaGxjc0I1RmJZUnJrdXpVWUk4UDZuSythYUt6?= =?utf-8?B?bUQzS0MwQ1pOOXBBaDExTElHMVd6Tm1jOHVQcnhWeFJZbjk0S3VzMTFwQldN?= =?utf-8?B?ZHpHRHU3YXRhakt1K29nSFRNWTZXZms2L2JscExJR0VqNjV5bmVxcmVTcjR4?= =?utf-8?B?c3JIdjk4NjFzaDhGZFplbWV0ekRmNHVKMWJtNWkzYUhsbVNJT1pqaFJ5SC82?= =?utf-8?B?Q0lKM1VWUFd3KytCN1RzVjlxR3pwVEhXNzN5ejcrZTBFR3pKbFN1c1pnWjBE?= =?utf-8?B?bDNLOFlGZmo5YmVOUDVmUTdYY0h1NjFTOUpxdXpWSjc4UXRjZWdEODdiNGlC?= =?utf-8?B?MDlUM2cwVVB5SzIvZFFLdTRpOHhxeGZqa3hCam4vTEpNeTlLZlhmZWZpWDVx?= =?utf-8?B?aWY2RzRLaGlDMDVEV21KWTVuUDI3Y2RtWDRBMUdySzNWWUMrTmxaWVhCc3Ji?= =?utf-8?B?bEdzcUlJRFFjYWpsdFZPY1NEaXVrNWlmNnc4V0NKMDRMZjhyZUtGL3lySm41?= =?utf-8?B?L2JRTy9scjROTWpKR21mRGJnaHlsUUs4OE03dXFuUDFoOTYxQjErTVhzSktv?= =?utf-8?B?TjFYNGJBTEZBNy9zVEc5RGhCUENISXljMWdqcGtzMFNsbktlcnB6YXIwTmlz?= =?utf-8?B?emlrTDZ1Y0dCUWQ5NG80N0srb2U3WTJmZ2hkOFJsS01tVGlvTTgyb0ZPS2Fy?= =?utf-8?B?MEF0UnUyZVRZTzk4Vk90VGRGbEpZdHEzUWQwZ0kyNzRqR0lzNW83WjdFeEJp?= =?utf-8?B?TnJXcm1TZjB4bzZqUXdrMmY1cnVDbjVMSTJ4elJXOTVodDZYKzhBOGQ1bTJO?= =?utf-8?B?MkswZmhBRzJ4TjFNMDFuRkNvV1prSVZPNHJBR1RWOU1vSTdLZ09lL1BOb1Jt?= =?utf-8?B?Uk1XbEFiNnNVQ3VJNXFEYjVxR2dYdThEMTlrdWFYcnZlVmdUNGFiYVdHS1Jh?= =?utf-8?B?YnMxSURlRW1rOGJqaFBKSmFVcTZMQXJlTzVRcDBMNXdpZ3E5WTBwcE1nZkpD?= =?utf-8?B?OTcyYVJtTkFOMldzTlAvelFvZVptNDI0N0hnWXY1ajJlRy8vQjQ0VTYyZEJq?= =?utf-8?B?QjhzQlZWM2t3c3dzL29OM1RmeHVkMTFNa0VTYmxqVFpWaWtQa05zQm5mTVVh?= =?utf-8?B?cDFGWGVaTktuYkZDSmxrekhGK3hka0ZXL1MyWElTUnJMN05zM2U4UW5VbXo3?= =?utf-8?B?bDB3a2JMWmY3Yi9CanFzdXhaWnYxSS9HT3pJbFo0QWZNUG9xbU9wNUpJRy9Y?= =?utf-8?B?YWE0N1E4SVM3R1BSWFlyN3pPUmp5emh4R3c1elhNdFA1VGlpUFYwRG9neG54?= =?utf-8?B?VlI4QXFKQ2lqc2taWXJQK3RZMHRxcFJUclpUZVZYdXRvWktsdUZKR1lKWnY1?= =?utf-8?B?K0RuYXJUTXpnbHFvTkZUcFFmellMZE1VQkNhZlVVdkNFUm45RWV4eit4eHhi?= =?utf-8?B?YVNCZW1HNmlTcWQ4OFZuUTFleUdWSlZGelZsanNEZDVVUExLL2F0RlFrelZS?= =?utf-8?B?TkRpakdTTm9qLzJCU05sRURIZlg3L2g0M2lMZHV5UjJOUXV6OTZKMUpqcGIr?= =?utf-8?B?NXFra3pNcmI3bnN1VDkzTE5UdmZoZzErS0xmb3lTcnduSVJadUN4WXBLbGNa?= =?utf-8?B?NUxwVVhtamZRQ244Ty9LQXdtZHQzQkxmSGVCNXI2SW01S2pJN2dyQ3NGcnZS?= =?utf-8?B?aDhiSDdsL3FDSDBlVVhLM3pFd1hLTDVPblhyNnptSzc5Z2FHL1lzeWp2ZU9t?= =?utf-8?B?NHRGVVMxZzVwa1ZybjY4MmFDWWxmaWxQdmVXelZRM0ticnA5cXZSYi90bWNU?= =?utf-8?B?bXVwd2hKSUVKRW9ydUI4bHpqSUhDcFVVaVpzaG50TEZLeFJNQ1puYnVVdkRJ?= =?utf-8?B?UkM0VG9BTTkxMlo0bXowR1NPS3dqbTB5WVVWdERNVXRCaVFyMTJwQ2d6V0Qx?= =?utf-8?Q?K2hRD+7sA8TL53h992dBStfsg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66692514-9822-4e3c-02c8-08db94bdb5ab X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:37:52.3611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ppBZbqtWNX05DpAxSrJG7uPWu9bWo/5IZ4WVh4j5KsD7Vd0Bra6CtNE6zhQa6KwtTa3oAI3zYYhnkFKc/OzIfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9716 On 04.08.2023 03:34, Stefano Stabellini wrote: > --- a/docs/misra/C-language-toolchain.rst > +++ b/docs/misra/C-language-toolchain.rst > @@ -84,6 +84,8 @@ The table columns are as follows: > see Sections "6.48 Alternate Keywords" and "6.47.2.1 Volatile" of GCC_MANUAL. > __const__, __inline__, __inline: > see Section "6.48 Alternate Keywords" of GCC_MANUAL. > + always_inline: > + see Section "6.45 An Inline Function is As Fast As a Macro" of GCC_MANUAL. > typeof, __typeof__: > see Section "6.7 Referring to a Type with typeof" of GCC_MANUAL. > __alignof__, __alignof: This is the "Non-standard tokens" section. What you add is a macro of our own. In its expansion we don't use the similarly named attribute in this very spelling, but with underscores prefixed and suffixed to it. If we mean to enumerate __attribute__(()) identifier tokens here as well, then I think we should add all of them that we use. But that's going to be an ever expanding list. In any event I don't think such an addition can come with an empty description. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:50:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:50:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576943.903659 (Exim 4.92) (envelope-from ) id 1qRpZR-0002w7-Bv; Fri, 04 Aug 2023 07:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576943.903659; Fri, 04 Aug 2023 07:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpZR-0002w0-8i; Fri, 04 Aug 2023 07:50:01 +0000 Received: by outflank-mailman (input) for mailman id 576943; Fri, 04 Aug 2023 07:50:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpZQ-0002vu-8X for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:50:00 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0622.outbound.protection.outlook.com [2a01:111:f400:fe1f::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8285ab8f-329b-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 09:49:59 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PR3PR04MB7244.eurprd04.prod.outlook.com (2603:10a6:102:8e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Fri, 4 Aug 2023 07:49:56 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 07:49:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8285ab8f-329b-11ee-b26a-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A//hTqTS05Uf9mDHd8lfOgmr+xNEhNXhVuejcvsPaytZb4iBwSdy7TO93Gp3XwCjHwaEahtsFx5B2f9qZcEx/Iawnrnt6hlL2ZABwC8MMYWjbmGaIS0oy+2tvZJE9xwdMM5WxBCvwh0p+zbyFjL2nW8Z+JyJYV5/pbuf9614RdYLe8j/9dlEmABxyrZ1gdrDxi5lrNVCmLCnNWNSZPYFyXF0DoSxgHbRPrlnpjKjMUOB3W5QD/U0cd+ZJOUMu0SrtmJNZGaHc1ZKkZPkUq4/fqe/fFkTK8kyuVToTaUNuZMJHShqEUQyWlepvE4IMD7IvlJPED5RJ1pkPe/d6HO6lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pK8Vhq387biROCAprJ3LZiRopB/zy2Jlz6LEwBX6jI0=; b=hrplvX8R/BfPxx62uXBYLugDBezfbRdrlwVkWRqrdCJBdEdmozPnrT6/fcHLvk8MheZv41rDD6aSn7Pl2BuUXN2CUoy5mD+zdrUvhfyyxEdLm0BiDa35diQ488ZKFy4nqcBp5/MOnRGce6I3dSNV5cV5vhr22aUWq4ZPq+SUidDTFw6r8ldLphhWVjO9zPEvJdxwaJ+82fPl3qhmgiPRqVyp4Hlxmh32eL1EisTQhMWWO4BZ3Dkhf9Jrn0LnSNPUMlcALJ++iLQdq6YySIND8YSWePh+O74686DSUw5y3de+bM/1h/j56SOwR8tiiKAQpt6U+Nxe8l2c9nqt5l023Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pK8Vhq387biROCAprJ3LZiRopB/zy2Jlz6LEwBX6jI0=; b=FJ1u4+GFAmVvFDVTbm5pAYjLmks3zpcniO2ToFxRGdBgFU44wTtedSgF19DuluJzLqK1gFm8lPF8kRa8jRorWmY2Puvia9aXpsfcdpKwc/dFc3XPZ+XmOrc9wuj0ntS7Jgmgm2z5+D4yYTDGwJ81qC7H3/pEjyU9w10UHi7bj7/TaZFHciigdwTjmrwqvFTpPxBg4UkRd+zdislEhYTH/clZp/5ib/9KEhaGeeIFaMpk7nccsvNqFzzAT3bvOhhNCt5q2xK+anwy1Goc/AhN4hE3J3eI7acMvH4MmL3BTH1EMRcQrQdWEhgqTc7uY0m/qxaeuri3Ou//KPEAoB5Ieg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2ded224f-0b8b-90fe-367a-91762d1f25d5@suse.com> Date: Fri, 4 Aug 2023 09:49:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: "Daniel P. Smith" Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> <01a80d4c-f19b-98ec-805e-e648e752d6b1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0241.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PR3PR04MB7244:EE_ X-MS-Office365-Filtering-Correlation-Id: a43d3003-1292-49e3-1da6-08db94bf650b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ea7pMgCjE2NCXlzxnS/6iH3WFvLNA9picOII2rmtW/r5/01vAFsMtVBx0CTGwbJ+LEClTf3NSQxii8xsEiXYuK/MnZDgpSyeeWe5aqMBzX9pAxzCxtIa1tLsOESfTPDy9GUhdWHQJarqypJ1gAgxIgEbZ+1vtYi+vgmJJliNCLbY4RVGUR71vuz10VU76S16KM3cGXyRSHPeZuT4sxuruWSSlEQZSnAgodRbPHucQhRRV9L9X3cE7ay4jLBa4L1OAxPvcXmfU98BbrnhZOu2fz+CzqrcaLWYulVQDoe1lUbHdHtClHdZ8xWMPe2fT1IIGG6028cXmbOnC4aSzHbhiOjXGR/HW3ABka8tWeVK4r9RJ/GhoBquCoUhvRVG6YSxcqrCbRnYtaJmzts/UMwpS5sYjw5UdVZkEytxqotVxJDyaebEZmsDldVRNjgjzCkIilmErJHxeYJ0phU1d8aHLgeGz9jwigopauAzd8m56ah1UIEbtQMwzHnPxrx/SCvETSA84ryWnqa4L99uDSWZ9FaOiZnkq9nMQS3lUtpiQ/hms/3tCxL1htwpfwFgFnHT34Kr5fya4ITu8xBgS2MndokFhZJgQKtl0vaIUOJ02pAh1ob5j35IesfX4NJw4y9ZjXyTF9dFy+jU2kmJF9O0mg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(376002)(39860400002)(396003)(366004)(186006)(451199021)(1800799003)(66476007)(66946007)(66556008)(4326008)(6916009)(2906002)(38100700002)(2616005)(53546011)(6506007)(7416002)(83380400001)(54906003)(86362001)(6512007)(31696002)(26005)(478600001)(36756003)(6486002)(6666004)(8936002)(8676002)(5660300002)(41300700001)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEl2ZGJWSWdGa2U0QWI1VlM5THZYN1p5bjdMVlgyZ0IzUUxXOWtRelZyRXhI?= =?utf-8?B?SmZKU24zOTI5aGJTRkdqUDJGUDFheW01SFowSXVITlpuVTRPdXFaWDd3NHdF?= =?utf-8?B?bWYvcG5pd29oU2FOdnJTSUkyR0dZbW5KbTdxVG1JTFk2OUpMam9iTnpJQ1E2?= =?utf-8?B?VDRYUHZqT1FzQVFhaVVGR1pyL0RLKzQ1V2RoWTZERmsxS01RbHhZRkhmbkJO?= =?utf-8?B?ZE5yU0FnckRiQ3RIVXByTlphM0NnVnc2cWJUdkVHbXZLUmlXZGhuSEVscTZa?= =?utf-8?B?UFVLUnFiS3JpNFZjRkxwbTJmRzBlRWxiMmVoblRrM0NVSUtxRk14TWJjdWlm?= =?utf-8?B?T3ZiTkNacjZkZjJjSTc0R3Z3MlZPSms5TXZwL2l6QTJVcld4ZGxXaEZhV0hl?= =?utf-8?B?bjB4RUxpZC9lY2NlUG5qeFczTlduTDNUZ2tDdWVuS2lsQi96Rkl6bVJMMFZv?= =?utf-8?B?Y2VEcFBDUVFKdklyZGx5UjVIZnBaVkFaNFRNcXR4QVhUSUc2RUlKWGVsOU4r?= =?utf-8?B?OStEVFJ0a1pWV2RaZnNDRTZLYXZhVzZKV2tCTnRUbjhkUXlnU0tYbVkwbmFY?= =?utf-8?B?ZkFiNmprRjdoL1E1S0thMnZDcGlReDdHdEhEemt3SWdHcU9kdGRNV0xKK1JT?= =?utf-8?B?VW52ZW9TdE54S1ZTVmIva01VNk5oQW9wWHpnVk93S01oRVBUUEZ2V3VsYXpF?= =?utf-8?B?dDdXMEpZL2JodjdOYks4Y3NlTFFTUnllRWorY3NSZkx0ZHBBcTNhd0ZHdTEx?= =?utf-8?B?c0ZGZ2F2U2wxaG1vTzErb1JlTHRFQmdqK3dFb2NiVkl5V3dESmE5Znp6eUNs?= =?utf-8?B?VWZ5QmNRZU9HT2JkUm96ekFsc3REeEE4bnNISk5Sd2ZIQUpKZEpaWTRLaWl5?= =?utf-8?B?WlJOeWYySkFUNXNQUUdsZ3Z0bjMzeWFTc1Y2RkIvNnZEdXYvWi9yaGpjM2Vq?= =?utf-8?B?L2ZrVFMvM0twOWNxVC94ZTFIK3YwNjVMd1pYUWZEQkJCa1pwRXloOG92K2ZP?= =?utf-8?B?cklKNnpuaFVWbWV6R0JrbDlMUGdGMkVuZGdlZFF4cXhUUWNOeXlJOWdMdTQ5?= =?utf-8?B?ZG1ra2hPOUdaL2RvVlFvU0VENnN1RkgvRWE0TGQwakJsbkZHNTBqbFRSWGE1?= =?utf-8?B?Vy8xSTVuY2x2R1NUNjRkSXkrNkZGT3FuVysvMmp3aGFmc1ErMlEyU3pnTVcr?= =?utf-8?B?eTN4T3E5QWwwZXF4S2RaZ296WGVyZU8zSDJoajRRM3FscEZkKzlCaVp3NVNp?= =?utf-8?B?Sm1sd0FvNnR4UkFZWXZ6Z2hhaTlmUS9TYWdEc1psMkl5V2YwamMwc1EzVElH?= =?utf-8?B?N2hOWThtTkF2Ky9VZVhCSUUyWlo0Z1BzdmhZWms4RHJYSU04MUpBTEt6cFBr?= =?utf-8?B?cjZxaUozcTNyRW8xRUcrTy81TzlISjJaRW1yT2RPdHlBL0pJUW1wVlMrdTRU?= =?utf-8?B?ZUNaN3NrdzVTaWg2WWdGYThwdnNGRmhJTkVpQ1ZvcVNvRTNKNTV3Z1V0Sllu?= =?utf-8?B?TEZpeVVSNkRKRWFJSjdjbnk0YitxZlNDVUZRMkVwRUc5dFF5V3JsK2hwNStO?= =?utf-8?B?aDFBSlhySS91UWpMSUI1VWRQTTZ4V3p6Z3pmaXpEQmdHYTFZbXNVdkVMTkwr?= =?utf-8?B?YXM4Y3NZVkV5OTdPT3pFRGUvM2VIS1NYVGxyNnRma1FyRE9FdFlWd3lLakYx?= =?utf-8?B?MzhQdWdCeTZKNlBycXdhaG0yUTZRR0ZtWmx6dkU1WDlvQkl0eEo0RW1RS2Iz?= =?utf-8?B?UXdnT0xld3JycTVacDFQdXFNWXNKOGxoNjN0Z2FUem5hQUVSV0c0RFkyNmdY?= =?utf-8?B?WVoyOG5BMjZ4c1NERllVWmlZWjhoczQ0NmZ3bGwvcVRBekoxbTJpNDVrWVkw?= =?utf-8?B?ZjVGNGg5VE9RUjRHNzJHUkw1eGFlYW9ZWlU3VlJxVG9GSEo0eUJBa3ZTRmRy?= =?utf-8?B?NWJzSS95WXdHM1NvV2ZBbWNMS09uSW0xVExlUzJVTUdOTjZKdk44UXVRYkMx?= =?utf-8?B?eUVncEZZOVhrVmVMRk94SUdNY3UvdnJ6bDR3NXBoYnlRNHBESlBWT0xERkZB?= =?utf-8?B?VHVsQW9uQlhMeElnUXV3YTRHQlUxUzFQMS9BSVZSeEYvWE5TdGh0amwrdXVQ?= =?utf-8?Q?j71LrMM8qGAB4b8b3p/s47LAZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a43d3003-1292-49e3-1da6-08db94bf650b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:49:55.9338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0XxomRD1fGud9DSoQhXw1juIoYztd1vgaiB4PBSZ4mjq5jQjvBauFHa0ipuCQfUHiK2km/fWScdwBazJwcbBiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7244 On 03.08.2023 18:31, Daniel P. Smith wrote: > On 8/3/23 11:56, Jan Beulich wrote: >> On 03.08.2023 14:56, Daniel P. Smith wrote: >>> On 8/2/23 07:01, Jan Beulich wrote: >>>> On 01.08.2023 18:06, Daniel P. Smith wrote: >>>>> + { >>>>> + for_each_domain(next) >>>> >>>> What guarantees that the list won't change behind your back? You don't >>>> hold domlist_read_lock here afaict. It might be that you're safe because >>>> that lock is an RCU one and this function is only invoked at init time >>>> or from some form of interrupt handler. But that's far from obvious and >>>> will hence need both properly confirming and stating in a comment. (It >>>> is actually this concern, iirc, which so far had us avoid iterating the >>>> domain list here.) >>> >>> It is better to error on the side of caution instead of assuming this >>> will always be invoked in a safe manner. I will add a read lock for the >>> domain list. >> >> I'm not firm enough in RCU to be certain whether acquiring that lock is >> permissible here. > > Same and I took your statements to suggest that I should. Actually I wasn't paying close enough attention here: The code already uses rcu_lock_domain_by_id(), which acquires domlist_read_lock. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 07:55:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 07:55:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576946.903669 (Exim 4.92) (envelope-from ) id 1qRped-0004OU-TU; Fri, 04 Aug 2023 07:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576946.903669; Fri, 04 Aug 2023 07:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRped-0004ON-Qu; Fri, 04 Aug 2023 07:55:23 +0000 Received: by outflank-mailman (input) for mailman id 576946; Fri, 04 Aug 2023 07:55:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpec-0004OH-Td for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 07:55:22 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 43026afa-329c-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 09:55:21 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id D71CA4EE0737; Fri, 4 Aug 2023 09:55:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43026afa-329c-11ee-b26a-6b7b168915f2 Message-ID: <49fc793e-d0a3-7d9b-b501-d7a72dd9c736@bugseng.com> Date: Fri, 4 Aug 2023 09:55:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names To: Stefano Stabellini , Julien Grall Cc: Luca Fancellu , Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> <1e2d06ab-ad3a-4e5a-ac78-d20bad28bb20@xen.org> Content-Language: en-US, it From: Federico Serafini Organization: BUGSENG srl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/08/23 21:26, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Julien Grall wrote: >> On 03/08/2023 12:52, Luca Fancellu wrote: >>>> On 3 Aug 2023, at 12:46, Julien Grall wrote: >>>> >>>> Hi Luca, >>>> >>>> On 03/08/2023 11:28, Luca Fancellu wrote: >>>>>> On 3 Aug 2023, at 09:26, Federico Serafini >>>>>> wrote: >>>>>> >>>>>> Add missing parameter names to address violation of MISRA C:2012 >>>>>> rule 8.2 ("Function types shall be in prototype form with named >>>>>> parameters"). >>>>>> >>>>>> No functional changes. >>>>>> >>>>>> Signed-off-by: Federico Serafini >>>>>> --- >>>>>> Changes in v2: >>>>>> - memset() adjusted. >>>>>> --- >>>>>> xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- >>>>>> 1 file changed, 21 insertions(+), 21 deletions(-) >>>>>> >>>>>> +void *memset(void *s, int c, size_t count); >>>>>> +void *memcpy(void *dest, const void *src, size_t count); >>>>> There is a comment in arch/arm/rm32/lib/memcpy.S with this: >>>>> /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ >>>>>> +void *memmove(void *dest, const void *src, size_t count); >>>>> There is a comment in arch/arm/rm32/lib/memmove.S with this: >>>>> * Prototype: void *memmove(void *dest, const void *src, size_t n); >>>>>> +int memcmp(const void *cs, const void *ct, size_t count); >>>>>> +void *memchr(const void *s, int c, size_t n); >>>>>> +void *memchr_inv(const void *s, int c, size_t n); >>>>> @Stefano: would it make sense to remove it as part of this patch or >>>>> maybe not? >>>> >>>> They are a verbatim copy of the Linux code. So I would rather no touch it. >>> >>> Oh I see! Thank you for pointing that out, then I’m wondering if it’s there >>> a reason why we >>> are using ‘count’ instead of ’n’ as third parameter name, I know Stefano >>> suggested that, so >>> It’s just a curiosity. Maybe it’s for clarity? >> >> I guess because the generic implementation of memset (see xen/lib/memset.c) is >> using 'count' rather than 'n'. > > Yep > > >> Given what Andrew said, I would say we should rename the parameter to 'n'. > > Yes, either way works. I was only trying to be consistent with > xen/lib/memset.c. It is also fine to change xen/lib/memset.c instead. If you want to be consistent compared to the C99 Standard, then other parameter names need to be changed, for example all the `cs` and `ct` should become `s1` and `s2`, respectively. The same goes for `dest` and `src`. If you agree, I can propose a v3 that takes care of that. -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:00:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:00:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576957.903679 (Exim 4.92) (envelope-from ) id 1qRpjX-0006LU-Vq; Fri, 04 Aug 2023 08:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576957.903679; Fri, 04 Aug 2023 08:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpjX-0006LN-Sy; Fri, 04 Aug 2023 08:00:27 +0000 Received: by outflank-mailman (input) for mailman id 576957; Fri, 04 Aug 2023 08:00:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpjV-0006IU-VB for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:00:25 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2072.outbound.protection.outlook.com [40.107.13.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6ec0d1d-329c-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 10:00:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB9768.eurprd04.prod.outlook.com (2603:10a6:102:381::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 07:59:54 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 07:59:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6ec0d1d-329c-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRap6Gi6gERzyP80a0wc6QLEd9hnZyuEFCKlrh3AA9X0GO3u8gE0qLIZS9SrVKjQN86qno5kcv9XVE6+tbR2EEKjvQzDlm5G6CrL4iAbKQV/ZPpWmblfqIFmw0PB6A+AiTNUSR72+3/Iru19P78JVOMIKboIB+ieiGfNjwfRdKFUmiQpSgmyNVltOYuY9NVEqVw+OKVdSUu6LnKT5OV0456ckUGCpFCQdCyf6lA/gOytNddP4PKaUN+tig+pxKJEcXIjU5JY2OTcJqFQAKMBXu1n3dp4Du/PMDts3rZQa58/mvK2kbdZX+A9K6uIgVBqt9CmRDqsE+RJINQ9KGxHbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jg6HVn7meBYbQ4DOJLd/KhIV5BbPWOw/1QsnOWVKGoU=; b=XrCfjDvehkn22Q3t4sUVSmdVUrfT56oQxdZVQYhr944ODwhrH4rZqhmAaQe33UICE0zRoB41F11RiZCbVvOVdzHX3kIJnUe9l2LBKE7xW8PAH4CjP8Gl81lHnbwD4azV56yQRaWDrG1TgLFqfEIddjt3CmbtdPNzB0cUPNobrGFzgCUmegvr7th2P7Ae8qW/bOJGfnxPwExAoXnnxFqkhlhVQhE3AeaQQm/BrYRAhA8eYaWrQmegtH98oofutl1bHp4Q24lp3psT+UuRGu2vcF3QZH7pFOJvWwHvhNqirZUJ4KevJoXYC4EPKvNZrvoJ3tRTcA0937L2rh1i3yrNFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jg6HVn7meBYbQ4DOJLd/KhIV5BbPWOw/1QsnOWVKGoU=; b=sJ87tt4tP+eTV33rl4usYCpSJas0TxMCXNmj24FMVD7jCEm+OwpvbFWPv3uVOQOStHDMbskvIv02brmzRqka5WD7jTsu554YuNmqbg+LIwsa31NJioghVEz/3sbfnC52kJtOrg2wBroHvgrLys9IJj6lTlyFNAy5AI0KvRuGWh9O+RGd/tnK8zxRbbq0m4j199E4oGF5Yv5MnN5dHfdEU5Yd1uEZfBdDFfx+cpSFXiBoWv4fzpl/AbVyoXvFlubDBe6Ofl63yFZ97CxULt+VBcbwhIUiH33Ls+D/VK98pFEvwDIyV9oe7ilElNIqfgeGvJCa+PPS0EenHjAXh3xNjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <82f93d14-fd6e-417c-a970-645fd0719d3a@suse.com> Date: Fri, 4 Aug 2023 09:59:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names Content-Language: en-US To: Federico Serafini , Stefano Stabellini , Julien Grall Cc: Luca Fancellu , Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Wei Liu References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> <1e2d06ab-ad3a-4e5a-ac78-d20bad28bb20@xen.org> <49fc793e-d0a3-7d9b-b501-d7a72dd9c736@bugseng.com> From: Jan Beulich In-Reply-To: <49fc793e-d0a3-7d9b-b501-d7a72dd9c736@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0153.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB9768:EE_ X-MS-Office365-Filtering-Correlation-Id: 0be34a50-2115-4396-c794-08db94c0c9b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xLBp3p0bQ7ulutZi9SrFEwRNTECXAbjlcnEvFuXr5XQzP0T/gBq5rJr/ae9Ut5eP5Y58yart1FugV4iUY0g5hwTDUKXoFrHxgaaX99salRqNdLR+uREBADheEThXOMbHZKlzj2RSNSJ5THmVDsxWLsuQwQ3SxeDic45GBYplv58ePFu2qcStHCmnqLefa3CDhToAA5QoKZaeuMDp0hrS9jHvkxvmH44SE+DBDQ6v/ZNW9DVcmyl6I5p9nsjGr8Ov7NU/W9PRGtcaHHhx7zj66EGEhHYVYYfQjcFHHj8O1LkoWZaF0JIoBOdOF8xF8NglDgNAVr+XuG3jkAagjlDPEqNBrjSQOyObGbK7AhLZOfm4Fuy2eVbnw/88jrjJHM2sYy5HWECgGuOo1rL3pWnxEEYQMZo8NEPjAY3y59xhmH/kl8r+tMEyg7O8oYcwNQrUw5a1TvT+X3iqNpaJpkANjb2f0G8R5/utvv6n3i8EfvdoliIjaV1wYq8i0VUdAMlmi2fL99+/PSAiUDc2Mulw7MOnmv6jk49EEG/5YdLI+8OISvntzUT2RJkmKTDbg6IR4KA1akVzQ3zTKg3JZ1Jh+jkYuKPtW4ju1f7wyrlr3H5mabjOgAM4PNzwJsPpzhvxTZdJ8sJrPkXypDC/qG5h6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(396003)(346002)(376002)(451199021)(1800799003)(186006)(41300700001)(8936002)(8676002)(83380400001)(53546011)(26005)(6506007)(38100700002)(2616005)(31696002)(86362001)(316002)(110136005)(478600001)(6486002)(6512007)(54906003)(66556008)(66476007)(36756003)(4326008)(6666004)(31686004)(2906002)(5660300002)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bW1hM0dkOTNSWmNxZWp1dFBGYmM1TFhPblk2UWFERk12Mmd3L3RMaGk5TEVM?= =?utf-8?B?Y1lLdzRJSGxwQXdGSTVlRjFPOE1hN2FYZTZDNzUxTDM1RWpmeDNpaFRybytS?= =?utf-8?B?ZlhHc1NmbTdmZDBPUGNQakJwR3dacUc2L0xuU3IrN1VDV3hrSXlmMHlubWhD?= =?utf-8?B?UURDd29mSkFzaXZTUHdDejBKRTU5WE1uTHdZT1lEMG0vRkdHQlorakdKTHoy?= =?utf-8?B?SXIzTDNwUzhJM21iTVJXeHFpdHJ1cURycGxCL20wM3k0emtWcTdMNGlQSkNE?= =?utf-8?B?M2tMcVdtYURURTNjZXZqQTdGKzJEVmJuWGVOTm1sMXg5MmxHdlE3S3JlUjU3?= =?utf-8?B?TFh1Q2ttaDBsRldaRWd0dW4wQmh4S0V2b3A1eDExeTdzcG5qNkZpaUU1dzlz?= =?utf-8?B?MWkyL0RjNmdRQ0EzUVlmaFR1OGFFYWdPNk5hcFR3VGlPeS9oeXNOcjZ1YVBO?= =?utf-8?B?Tk9nYTFNaFIxM3lzKzBwV0RQZ1Zob2JrazBFai93d2VtK0VYbTlmK2lhMys2?= =?utf-8?B?eWVibm9zcCt2K1RZVmZNZFZZaFdtYjROMlpGb2VFNmlTZElVVHkreHp2amVU?= =?utf-8?B?K3hiaCs4SmFFNWp6MGw2dmVRR2hqNGZYNy9qb0xpZFJkQzdBWktkbmJBRm91?= =?utf-8?B?UWZIbGE3RGpYMDlZWWRTOG5QUW9WNm45ZEs2YXp0NFp1SnVPMlNFczZQQnE0?= =?utf-8?B?T05wWVVyeCszVFZiRDFHR1BLVlFINGZIc1dtdGdjZnB1OGNLUlNDQ1p6TWtK?= =?utf-8?B?dExETzdDY2VWd05Iak9DZVdXWSt1TGlxMWJHbGFqYzlQVmJxMlJNZ1c2YVpE?= =?utf-8?B?b2FKYkFVTms1c0RjSm9XSFdCYlVMVERYcC90dmdLcldyWXV1ZkZLRGEyLzBl?= =?utf-8?B?SEQ4RU5JdEtVRk5COXRiV28zQTY3elVQVDc4ajdrYW5mUEhyK0dDcnNMWitn?= =?utf-8?B?dE9KZ1FUSk5zMkJaKzIya0VqSHFMcTVvOTdFbUZQbEtMMmFEZ3lnanZJMlRG?= =?utf-8?B?T3JqU0pmR2VZYUhsNzdNRWU2bExTQnlTRCt2NEsvMnIyV0VZV29nVDg1VXBL?= =?utf-8?B?N2VQRGxYUDhjL2lSRTRxZkhRZmpYcHcrSlExUmRKMWJydUdnWjBJWldzMzJR?= =?utf-8?B?bEtwTzIrMkFIUHRCa3dLVGFpRTR5alBWMzhRYVA2MWpSZEw1ZjFYcjZaS3Fu?= =?utf-8?B?cjF3NkJUMlB6cFJkdzBXZ2UwUFJEaFU4Sm8rdnhIRm1mNkRtT2twcEYyczBX?= =?utf-8?B?ZjkzdWozc1hDRGRmSTNSY2R4MnNnVGdFaUU1SDc2RTVBMnhKY2hYRGxjNTFo?= =?utf-8?B?REI5aDRpRUEyRnBOajh4Si9pVlhjVTZ0OHdNTmJtVjBKWWxlQWVsZ0hLZDFv?= =?utf-8?B?WVpBNGdlVUVIaU1LTFpOK3ZETXNmY3F4dElFeFREME9kNkVlR25vNVhBLzJV?= =?utf-8?B?Y2NsWkIxVHFiT0RVdDN4L3F4eHZQWkhqVTBnOGVvZDh6eEVBMWF2UVBFQ0NV?= =?utf-8?B?WXpacXphNSs3WGQyZG5qUnVVZDRvckJ0OTNhWEt2cS9EeWtxT2pyY1p6NmdL?= =?utf-8?B?cFlTeFZyLzVHcThMQ0czWDRkTm51Slk5ZUVjTGRQaS90Z1BjbVUvZEY5cXpq?= =?utf-8?B?UUh5cGRsTDBxdVppaHNVZ0tXRHRsZnArU2hDcVRTV2hpcW1CS25QUmdMYzFs?= =?utf-8?B?Qmw3UmlDSzJwc2ZUU2c5RVVxL09VSW9taE8vRWd6MFRqVmJuRitzanVyZFdV?= =?utf-8?B?OGh4bFYzNDl6OWs4VkJHdC93Z0ZUaW1UV3c0NGs2dzQwcVYzdm9RN0dUOC80?= =?utf-8?B?YWRsZWJnRmRSSGpvWlA2cmFKRkY0dDdjZWxCNmRXaGcva0QrV0c1cTZNT0JQ?= =?utf-8?B?Nzk5bkRYV2pGM3hYVk5HMDFtNHhtRHFNckgvc3JnUlk1RzdhV0hLNExvczZH?= =?utf-8?B?SVhjT2ZzdDZKSmEvOTd4Zkg4TlE2eUU2bEVsY3FlQ1ArbElQemlSMzM4SkxL?= =?utf-8?B?aTN2WGNSL2hsaTAwYjJ4azU0M1VYK3VrVHcxb1dNNWZBdGtRT2VyUEhXQ2Z6?= =?utf-8?B?VmN5K3h1WjdOUk4rUVBzOGZoWjRkbnlQaXNPYjJsalliUUNRSldEWDc3NEFs?= =?utf-8?Q?kkCAzujaofr7PBb+H9eT3LISJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0be34a50-2115-4396-c794-08db94c0c9b8 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 07:59:54.3415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dcx6I8v/KEeMTPhXkejnw2gynvGfataK2ebnvgrYhSrUMf676EUR9GQmIzfDcBWdsbH5C/wwV4BEsujr3QmxCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9768 On 04.08.2023 09:55, Federico Serafini wrote: > On 03/08/23 21:26, Stefano Stabellini wrote: >> On Thu, 3 Aug 2023, Julien Grall wrote: >>> On 03/08/2023 12:52, Luca Fancellu wrote: >>>>> On 3 Aug 2023, at 12:46, Julien Grall wrote: >>>>> >>>>> Hi Luca, >>>>> >>>>> On 03/08/2023 11:28, Luca Fancellu wrote: >>>>>>> On 3 Aug 2023, at 09:26, Federico Serafini >>>>>>> wrote: >>>>>>> >>>>>>> Add missing parameter names to address violation of MISRA C:2012 >>>>>>> rule 8.2 ("Function types shall be in prototype form with named >>>>>>> parameters"). >>>>>>> >>>>>>> No functional changes. >>>>>>> >>>>>>> Signed-off-by: Federico Serafini >>>>>>> --- >>>>>>> Changes in v2: >>>>>>> - memset() adjusted. >>>>>>> --- >>>>>>> xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- >>>>>>> 1 file changed, 21 insertions(+), 21 deletions(-) >>>>>>> >>>>>>> +void *memset(void *s, int c, size_t count); >>>>>>> +void *memcpy(void *dest, const void *src, size_t count); >>>>>> There is a comment in arch/arm/rm32/lib/memcpy.S with this: >>>>>> /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ >>>>>>> +void *memmove(void *dest, const void *src, size_t count); >>>>>> There is a comment in arch/arm/rm32/lib/memmove.S with this: >>>>>> * Prototype: void *memmove(void *dest, const void *src, size_t n); >>>>>>> +int memcmp(const void *cs, const void *ct, size_t count); >>>>>>> +void *memchr(const void *s, int c, size_t n); >>>>>>> +void *memchr_inv(const void *s, int c, size_t n); >>>>>> @Stefano: would it make sense to remove it as part of this patch or >>>>>> maybe not? >>>>> >>>>> They are a verbatim copy of the Linux code. So I would rather no touch it. >>>> >>>> Oh I see! Thank you for pointing that out, then I’m wondering if it’s there >>>> a reason why we >>>> are using ‘count’ instead of ’n’ as third parameter name, I know Stefano >>>> suggested that, so >>>> It’s just a curiosity. Maybe it’s for clarity? >>> >>> I guess because the generic implementation of memset (see xen/lib/memset.c) is >>> using 'count' rather than 'n'. >> >> Yep >> >> >>> Given what Andrew said, I would say we should rename the parameter to 'n'. >> >> Yes, either way works. I was only trying to be consistent with >> xen/lib/memset.c. It is also fine to change xen/lib/memset.c instead. > > If you want to be consistent compared to the C99 Standard, > then other parameter names need to be changed, for example all the `cs` > and `ct` should become `s1` and `s2`, respectively. > The same goes for `dest` and `src`. > If you agree, I can propose a v3 that takes care of that. Personally I'd prefer if we could limit code churn. Functions that need touching anyway can certainly be brought in line with names the standard uses (albeit I don't see a strong need for this). But function which won't otherwise be touched could easily be left alone. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:03:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576961.903688 (Exim 4.92) (envelope-from ) id 1qRpmw-00075I-IW; Fri, 04 Aug 2023 08:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576961.903688; Fri, 04 Aug 2023 08:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmw-00075B-F5; Fri, 04 Aug 2023 08:03:58 +0000 Received: by outflank-mailman (input) for mailman id 576961; Fri, 04 Aug 2023 08:03:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmv-000750-5n for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:03:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75c2d89f-329d-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 10:03:56 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 26A614EE0737; Fri, 4 Aug 2023 10:03:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75c2d89f-329d-11ee-b26a-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: [XEN PATCH v2 0/4] x86: address some violations of MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 10:03:32 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some variables are renamed or deleted in this series to avoid shadowing, which violates MISRA C:2012 Rule 5.3, whose headline is: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". --- Changes in v2: - Addressed comments on patches 1 and 2. Patches 3 and 4 are unchanged. Nicola Vetrini (4): x86/mce: address MISRA C:2012 Rule 5.3 x86/mtrr: address MISRA C:2012 Rule 5.3 x86/irq: rename variable to address MISRA C:2012 Rule 5.3 x86/setup: address MISRA C:2012 Rule 5.3 xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- xen/arch/x86/cpu/mcheck/barrier.h | 14 +++++++------- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/hvm/mtrr.c | 32 +++++++++++++++---------------- xen/arch/x86/include/asm/irq.h | 2 +- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/io_apic.c | 10 +++++----- xen/arch/x86/irq.c | 12 ++++++------ xen/arch/x86/msi.c | 4 ++-- xen/arch/x86/setup.c | 3 +-- xen/include/xen/irq.h | 2 +- 11 files changed, 45 insertions(+), 46 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:03:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576962.903694 (Exim 4.92) (envelope-from ) id 1qRpmw-00078G-R1; Fri, 04 Aug 2023 08:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576962.903694; Fri, 04 Aug 2023 08:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmw-00077W-Lj; Fri, 04 Aug 2023 08:03:58 +0000 Received: by outflank-mailman (input) for mailman id 576962; Fri, 04 Aug 2023 08:03:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmv-000750-Ug for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:03:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 762567e2-329d-11ee-b26a-6b7b168915f2; Fri, 04 Aug 2023 10:03:57 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 1396E4EE0740; Fri, 4 Aug 2023 10:03:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 762567e2-329d-11ee-b26a-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 1/4] x86/mce: address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 10:03:33 +0200 Message-Id: <8a11baf39c140af9d5694298e5f1f0bf59ac0621.1691135862.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Suitable mechanical renames are made to avoid shadowing the function identifier 'wait' declared in 'xen/include/xen/wait.h', thus addressing violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The parameter name 'bar' is added as well to comply with MISRA C:2012 Rules 8.2 and 8.3. Signed-off-by: Nicola Vetrini --- Changes in v2: - Added parameter name 'bar' where missing. - Amended commit message. --- xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- xen/arch/x86/cpu/mcheck/barrier.h | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/barrier.c b/xen/arch/x86/cpu/mcheck/barrier.c index a7e5b19a44..51a1d37a76 100644 --- a/xen/arch/x86/cpu/mcheck/barrier.c +++ b/xen/arch/x86/cpu/mcheck/barrier.c @@ -16,11 +16,11 @@ void mce_barrier_dec(struct mce_softirq_barrier *bar) atomic_dec(&bar->val); } -void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait) { int gen; - if ( !wait ) + if ( !do_wait ) return; atomic_inc(&bar->ingen); gen = atomic_read(&bar->outgen); @@ -34,11 +34,11 @@ void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) } } -void mce_barrier_exit(struct mce_softirq_barrier *bar, bool wait) +void mce_barrier_exit(struct mce_softirq_barrier *bar, bool do_wait) { int gen; - if ( !wait ) + if ( !do_wait ) return; atomic_inc(&bar->outgen); gen = atomic_read(&bar->ingen); diff --git a/xen/arch/x86/cpu/mcheck/barrier.h b/xen/arch/x86/cpu/mcheck/barrier.h index c4d52b6192..7ec483226f 100644 --- a/xen/arch/x86/cpu/mcheck/barrier.h +++ b/xen/arch/x86/cpu/mcheck/barrier.h @@ -20,7 +20,7 @@ struct mce_softirq_barrier { /* * Initialize a barrier. Just set it to 0. */ -void mce_barrier_init(struct mce_softirq_barrier *); +void mce_barrier_init(struct mce_softirq_barrier *bar); /* * This function will need to be used when offlining a CPU in the @@ -29,17 +29,17 @@ void mce_barrier_init(struct mce_softirq_barrier *); * Decrement a barrier only. Needed for cases where the CPU * in question can't do it itself (e.g. it is being offlined). */ -void mce_barrier_dec(struct mce_softirq_barrier *); +void mce_barrier_dec(struct mce_softirq_barrier *bar); /* - * If @wait is false, mce_barrier_enter/exit() will return immediately + * If @do_wait is false, mce_barrier_enter/exit() will return immediately * without touching the barrier. It's used when handling a * non-broadcasting MCE (e.g. MCE on some old Intel CPU, MCE on AMD * CPU and LMCE on Intel Skylake-server CPU) which is received on only * one CPU and thus does not invoke mce_barrier_enter/exit() calls on * all CPUs. * - * If @wait is true, mce_barrier_enter/exit() will handle the given + * If @do_wait is true, mce_barrier_enter/exit() will handle the given * barrier as below. * * Increment the generation number and the value. The generation number @@ -53,9 +53,9 @@ void mce_barrier_dec(struct mce_softirq_barrier *); * These barrier functions should always be paired, so that the * counter value will reach 0 again after all CPUs have exited. */ -void mce_barrier_enter(struct mce_softirq_barrier *, bool wait); -void mce_barrier_exit(struct mce_softirq_barrier *, bool wait); +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait); +void mce_barrier_exit(struct mce_softirq_barrier *bar, bool do_wait); -void mce_barrier(struct mce_softirq_barrier *); +void mce_barrier(struct mce_softirq_barrier *bar); #endif /* _MCHECK_BARRIER_H */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:04:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:04:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576963.903709 (Exim 4.92) (envelope-from ) id 1qRpmz-0007aW-0D; Fri, 04 Aug 2023 08:04:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576963.903709; Fri, 04 Aug 2023 08:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmy-0007aJ-T9; Fri, 04 Aug 2023 08:04:00 +0000 Received: by outflank-mailman (input) for mailman id 576963; Fri, 04 Aug 2023 08:03:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmx-0007Qe-Mb for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:03:59 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7696f1ed-329d-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 10:03:57 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D93834EE0741; Fri, 4 Aug 2023 10:03:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7696f1ed-329d-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 10:03:34 +0200 Message-Id: <2f7380396ee146132738dd5c6b2a80d62a8035d5.1691135862.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename variables to avoid shadowing and thus address MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". The shadowing happens between the struct declaration 'mtrr_state' in 'xen/arch/x86/include/asm/mtrr.h' and local variable names. The latter are renamed to 'm', which is used elsewhere in 'xen/arch/x86/hvm/mtrr.c' for the same purpose. No functional changes. Signed-off-by: Nicola Vetrini --- Changes in v2: - Renamed 'mtrr' local variables to 'm'. - Added references in the commit message. --- xen/arch/x86/hvm/mtrr.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c index 29f3fb1607..7f486358b1 100644 --- a/xen/arch/x86/hvm/mtrr.c +++ b/xen/arch/x86/hvm/mtrr.c @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, uint64_t gfn_start, static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) { - const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr; + const struct mtrr_state *m = &v->arch.hvm.mtrr; struct hvm_hw_mtrr hw_mtrr = { - .msr_mtrr_def_type = mtrr_state->def_type | - MASK_INSR(mtrr_state->fixed_enabled, + .msr_mtrr_def_type = m->def_type | + MASK_INSR(m->fixed_enabled, MTRRdefType_FE) | - MASK_INSR(mtrr_state->enabled, MTRRdefType_E), - .msr_mtrr_cap = mtrr_state->mtrr_cap, + MASK_INSR(m->enabled, MTRRdefType_E), + .msr_mtrr_cap = m->mtrr_cap, }; unsigned int i; @@ -710,14 +710,14 @@ static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) { - hw_mtrr.msr_mtrr_var[i * 2] = mtrr_state->var_ranges->base; - hw_mtrr.msr_mtrr_var[i * 2 + 1] = mtrr_state->var_ranges->mask; + hw_mtrr.msr_mtrr_var[i * 2] = m->var_ranges->base; + hw_mtrr.msr_mtrr_var[i * 2 + 1] = m->var_ranges->mask; } BUILD_BUG_ON(sizeof(hw_mtrr.msr_mtrr_fixed) != - sizeof(mtrr_state->fixed_ranges)); + sizeof(m->fixed_ranges)); - memcpy(hw_mtrr.msr_mtrr_fixed, mtrr_state->fixed_ranges, + memcpy(hw_mtrr.msr_mtrr_fixed, m->fixed_ranges, sizeof(hw_mtrr.msr_mtrr_fixed)); return hvm_save_entry(MTRR, v->vcpu_id, h, &hw_mtrr); @@ -727,7 +727,7 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) { unsigned int vcpuid, i; struct vcpu *v; - struct mtrr_state *mtrr_state; + struct mtrr_state *m; struct hvm_hw_mtrr hw_mtrr; vcpuid = hvm_load_instance(h); @@ -749,26 +749,26 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) return -EINVAL; } - mtrr_state = &v->arch.hvm.mtrr; + m = &v->arch.hvm.mtrr; hvm_set_guest_pat(v, hw_mtrr.msr_pat_cr); - mtrr_state->mtrr_cap = hw_mtrr.msr_mtrr_cap; + m->mtrr_cap = hw_mtrr.msr_mtrr_cap; for ( i = 0; i < NUM_FIXED_MSR; i++ ) - mtrr_fix_range_msr_set(d, mtrr_state, i, hw_mtrr.msr_mtrr_fixed[i]); + mtrr_fix_range_msr_set(d, m, i, hw_mtrr.msr_mtrr_fixed[i]); for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) { - mtrr_var_range_msr_set(d, mtrr_state, + mtrr_var_range_msr_set(d, m, MSR_IA32_MTRR_PHYSBASE(i), hw_mtrr.msr_mtrr_var[i * 2]); - mtrr_var_range_msr_set(d, mtrr_state, + mtrr_var_range_msr_set(d, m, MSR_IA32_MTRR_PHYSMASK(i), hw_mtrr.msr_mtrr_var[i * 2 + 1]); } - mtrr_def_type_msr_set(d, mtrr_state, hw_mtrr.msr_mtrr_def_type); + mtrr_def_type_msr_set(d, m, hw_mtrr.msr_mtrr_def_type); return 0; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:04:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:04:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576964.903719 (Exim 4.92) (envelope-from ) id 1qRpn0-0007r7-81; Fri, 04 Aug 2023 08:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576964.903719; Fri, 04 Aug 2023 08:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpn0-0007qy-54; Fri, 04 Aug 2023 08:04:02 +0000 Received: by outflank-mailman (input) for mailman id 576964; Fri, 04 Aug 2023 08:04:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmy-0007Qe-Dc for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:04:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7729fcc9-329d-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 10:03:58 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 9E6BB4EE0742; Fri, 4 Aug 2023 10:03:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7729fcc9-329d-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: [XEN PATCH v2 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 10:03:35 +0200 Message-Id: <987ebd142ebd69ed062d74f7eb69c23759c51636.1691135862.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The extern variable 'irq_desc' defined in 'irq.h' is shadowed by local variables in the changed file. To avoid this, the variable is renamed to 'irq_description'. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/include/asm/irq.h | 2 +- xen/arch/x86/io_apic.c | 10 +++++----- xen/arch/x86/irq.c | 12 ++++++------ xen/arch/x86/msi.c | 4 ++-- xen/include/xen/irq.h | 2 +- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 2180abeb33..ca5bb96388 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -474,7 +474,7 @@ void hvm_migrate_pirq(struct hvm_pirq_dpci *pirq_dpci, const struct vcpu *v) if ( !desc ) return; - ASSERT(MSI_IRQ(desc - irq_desc)); + ASSERT(MSI_IRQ(desc - irq_descriptor)); irq_set_affinity(desc, cpumask_of(v->processor)); spin_unlock_irq(&desc->lock); } diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h index ad907fc97f..f6df977170 100644 --- a/xen/arch/x86/include/asm/irq.h +++ b/xen/arch/x86/include/asm/irq.h @@ -172,7 +172,7 @@ int assign_irq_vector(int irq, const cpumask_t *mask); void cf_check irq_complete_move(struct irq_desc *desc); -extern struct irq_desc *irq_desc; +extern struct irq_desc *irq_descriptor; void lock_vector_lock(void); void unlock_vector_lock(void); diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index b3afef8933..b59d6cfb9e 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -990,9 +990,9 @@ static inline void ioapic_register_intr(int irq, unsigned long trigger) { if ((trigger == IOAPIC_AUTO && IO_APIC_irq_trigger(irq)) || trigger == IOAPIC_LEVEL) - irq_desc[irq].handler = &ioapic_level_type; + irq_descriptor[irq].handler = &ioapic_level_type; else - irq_desc[irq].handler = &ioapic_edge_type; + irq_descriptor[irq].handler = &ioapic_edge_type; } static void __init setup_IO_APIC_irqs(void) @@ -1098,7 +1098,7 @@ static void __init setup_ExtINT_IRQ0_pin(unsigned int apic, unsigned int pin, in * The timer IRQ doesn't have to know that behind the * scene we have a 8259A-master in AEOI mode ... */ - irq_desc[0].handler = &ioapic_edge_type; + irq_descriptor[0].handler = &ioapic_edge_type; /* * Add it to the IO-APIC irq-routing table: @@ -1912,7 +1912,7 @@ static void __init check_timer(void) if ((ret = bind_irq_vector(0, vector, &cpumask_all))) printk(KERN_ERR"..IRQ0 is not set correctly with ioapic!!!, err:%d\n", ret); - irq_desc[0].status &= ~IRQ_DISABLED; + irq_descriptor[0].status &= ~IRQ_DISABLED; /* * Subtle, code in do_timer_interrupt() expects an AEOI @@ -2009,7 +2009,7 @@ static void __init check_timer(void) printk(KERN_INFO "...trying to set up timer as Virtual Wire IRQ..."); disable_8259A_irq(irq_to_desc(0)); - irq_desc[0].handler = &lapic_irq_type; + irq_descriptor[0].handler = &lapic_irq_type; apic_write(APIC_LVT0, APIC_DM_FIXED | vector); /* Fixed mode */ enable_8259A_irq(irq_to_desc(0)); diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 6abfd81621..ed95896bce 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -45,7 +45,7 @@ integer_param("irq-max-guests", irq_max_guests); vmask_t global_used_vector_map; -struct irq_desc __read_mostly *irq_desc = NULL; +struct irq_desc __read_mostly *irq_descriptor = NULL; static DECLARE_BITMAP(used_vectors, X86_NR_VECTORS); @@ -424,9 +424,9 @@ int __init init_irq_data(void) for ( vector = 0; vector < X86_NR_VECTORS; ++vector ) this_cpu(vector_irq)[vector] = INT_MIN; - irq_desc = xzalloc_array(struct irq_desc, nr_irqs); - - if ( !irq_desc ) + irq_descriptor = xzalloc_array(struct irq_desc, nr_irqs); + + if ( !irq_descriptor ) return -ENOMEM; for ( irq = 0; irq < nr_irqs_gsi; irq++ ) @@ -1133,7 +1133,7 @@ static void cf_check set_eoi_ready(void *data); static void cf_check irq_guest_eoi_timer_fn(void *data) { struct irq_desc *desc = data; - unsigned int i, irq = desc - irq_desc; + unsigned int i, irq = desc - irq_descriptor; irq_guest_action_t *action; spin_lock_irq(&desc->lock); @@ -1382,7 +1382,7 @@ static void __set_eoi_ready(const struct irq_desc *desc) struct pending_eoi *peoi = this_cpu(pending_eoi); int irq, sp; - irq = desc - irq_desc; + irq = desc - irq_descriptor; if ( !action || action->in_flight || !cpumask_test_and_clear_cpu(smp_processor_id(), diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index d0bf63df1d..35d417c63a 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -1322,7 +1322,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) unsigned int i = 0, nr = 1; irq = entry->irq; - desc = &irq_desc[irq]; + desc = &irq_descriptor[irq]; spin_lock_irqsave(&desc->lock, flags); @@ -1377,7 +1377,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) break; spin_unlock_irqrestore(&desc->lock, flags); - desc = &irq_desc[entry[++i].irq]; + desc = &irq_descriptor[entry[++i].irq]; spin_lock_irqsave(&desc->lock, flags); if ( desc->msi_desc != entry + i ) goto bogus; diff --git a/xen/include/xen/irq.h b/xen/include/xen/irq.h index 9747e818f7..56a3aa6a29 100644 --- a/xen/include/xen/irq.h +++ b/xen/include/xen/irq.h @@ -107,7 +107,7 @@ typedef struct irq_desc { } __cacheline_aligned irq_desc_t; #ifndef irq_to_desc -#define irq_to_desc(irq) (&irq_desc[irq]) +#define irq_to_desc(irq) (&irq_descriptor[irq]) #endif int init_one_irq_desc(struct irq_desc *desc); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:04:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:04:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576965.903729 (Exim 4.92) (envelope-from ) id 1qRpn1-000881-G0; Fri, 04 Aug 2023 08:04:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576965.903729; Fri, 04 Aug 2023 08:04:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpn1-00087m-Cu; Fri, 04 Aug 2023 08:04:03 +0000 Received: by outflank-mailman (input) for mailman id 576965; Fri, 04 Aug 2023 08:04:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRpmz-0007Qe-CG for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:04:01 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77a23a7f-329d-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 10:03:59 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 987F14EE0743; Fri, 4 Aug 2023 10:03:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77a23a7f-329d-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 4/4] x86/setup: address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 10:03:36 +0200 Message-Id: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The parameters renamed in the function declaration caused shadowing with the homonymous variable in 'xen/common/efi/boot.c'. Renaming them also addresses Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". The local variable 'mask' is removed because it shadows the homonymous variable defined in an outer scope, with no change to the semantics. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/setup.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 51fce66607..b0e6a39e23 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -33,7 +33,7 @@ static inline void vesa_init(void) {}; int construct_dom0( struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, + const module_t *image, unsigned long image_headroom, module_t *initrd, const char *cmdline); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2dbe9857aa..80ae973d64 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1577,8 +1577,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) s = map_s; if ( s < map_e ) { - uint64_t mask = (1UL << L2_PAGETABLE_SHIFT) - 1; - + mask = (1UL << L2_PAGETABLE_SHIFT) - 1; map_s = (s + mask) & ~mask; map_e &= ~mask; init_boot_pages(map_s, map_e); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:26:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:26:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576988.903738 (Exim 4.92) (envelope-from ) id 1qRq8T-0003RY-8O; Fri, 04 Aug 2023 08:26:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576988.903738; Fri, 04 Aug 2023 08:26:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRq8T-0003RR-5I; Fri, 04 Aug 2023 08:26:13 +0000 Received: by outflank-mailman (input) for mailman id 576988; Fri, 04 Aug 2023 08:26:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRq8S-0003RL-1i for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 08:26:12 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e5063d2-32a0-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 10:26:07 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 01:26:04 -0700 Received: from unknown (HELO fred..) ([172.25.112.68]) by orsmga003.jf.intel.com with ESMTP; 04 Aug 2023 01:26:04 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e5063d2-32a0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691137567; x=1722673567; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Q4YNu7fWoBQ4f21T/mVB+om7AomaDQ0aezAlCW+9t4o=; b=kJfJ1NxXXivQEXnURKsfXzpXZGDypM0l+UMPUFmxFYuGxLHhPOrLPia3 RM//Yb/BU+g3Qe1pJJHX16ssw0Z1oJ644UQjZ6lnz6gXqtSLIoaOgLI+B 9/9aGxX/4RJGmajU7wRrIxr1JgdV6CJgnQDrsJ9BFc8lsMIums55zQaM3 7CO7432mKxhKqccaiFZ1niaR98aolGIqLfxR2w/zhsvJbkHDAqIshKFei 5rtEpbbP97P8siCssofHck9keYLjop9RnA31a4r+T8VQtNUjj71e0VcoU 0Wprwsya/FSrDM/6Mmt86lbMDn3EkGu8WI+JuCwJSO/zi5TvO8wA+6NTT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="367561991" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="367561991" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="679843568" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="679843568" From: Xin Li To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Peter Zijlstra , Juergen Gross , Boris Ostrovsky Subject: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Date: Fri, 4 Aug 2023 00:57:34 -0700 Message-Id: <20230804075734.8372-1-xin3.li@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IDT event delivery of X86_TRAP_DF, X86_TRAP_TS, X86_TRAP_NP, X86_TRAP_SS, X86_TRAP_GP, X86_TRAP_AC and X86_TRAP_CP pushes an error code into the orig_ax member of the pt_regs structure, and the error code is passed as the second argument of their C-handlers, although the pt_regs structure is already passed as the first argument. The asm entry code of such faults does the following movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ to set the orig_ax member to -1 just before calling the C-handler. In addition, the IRQ entry code uses the second error code argument as its IRQ vector, as the IRQ asm entry code pushes its IRQ vector into the orig_ax member. The commit d99015b1abbad ("x86: move entry_64.S register saving out of the macros") introduced the changes to set orig_ax to -1, but I can't see why it's required. Our tests on x86_64 and x86_32 seem fine if orig_ax is left unchanged instead of set to -1. It's probably cleaner and simpler to remove the second argument from such C-handlers while leave orig_ax unchanged to pass the error code inside the first argument. This patch allows FRED to use IDT exception and IRQ handlers with no or minimal changes. The DECLARE_IDTENTRY_*_ERRORCODE macros still need to be kept to emit the ASM stubs, which do NOT need to push -1 as an error code placement. As a result, their corresponding DEFINE_IDTENTRY_*_ERRORCODE macros are kept, although they simply mapped to their no _ERRORCODE suffix versions. I haven't checked Xen implications with this change, i.e., does Xen hypervisor need to adjust how it passes arguments to PV guests? Signed-off-by: Xin Li --- arch/x86/entry/common.c | 2 +- arch/x86/entry/entry_32.S | 7 -- arch/x86/entry/entry_64.S | 22 ++----- arch/x86/include/asm/idtentry.h | 108 ++++++++++--------------------- arch/x86/include/asm/irq_stack.h | 43 ++---------- arch/x86/kernel/apic/apic.c | 2 +- arch/x86/kernel/doublefault_32.c | 2 +- arch/x86/kernel/irq.c | 1 + arch/x86/kernel/sev.c | 10 +-- arch/x86/kernel/traps.c | 14 ++-- arch/x86/mm/fault.c | 6 +- arch/x86/xen/enlighten_pv.c | 2 +- 12 files changed, 69 insertions(+), 150 deletions(-) diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c index 6c2826417b33..83d31cd82a65 100644 --- a/arch/x86/entry/common.c +++ b/arch/x86/entry/common.c @@ -305,7 +305,7 @@ __visible noinstr void xen_pv_evtchn_do_upcall(struct pt_regs *regs) bool inhcall; instrumentation_begin(); - run_sysvec_on_irqstack_cond(__xen_pv_evtchn_do_upcall, regs); + run_irq_on_irqstack_cond(__xen_pv_evtchn_do_upcall, regs); inhcall = get_and_clear_inhcall(); if (inhcall && !WARN_ON_ONCE(state.exit_rcu)) { diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S index 6e6af42e044a..41345b0d9bb8 100644 --- a/arch/x86/entry/entry_32.S +++ b/arch/x86/entry/entry_32.S @@ -642,8 +642,6 @@ SYM_CODE_START_LOCAL(asm_\cfunc) SAVE_ALL switch_stacks=1 ENCODE_FRAME_POINTER movl %esp, %eax - movl PT_ORIG_EAX(%esp), %edx /* get the vector from stack */ - movl $-1, PT_ORIG_EAX(%esp) /* no syscall to restart */ call \cfunc jmp handle_exception_return SYM_CODE_END(asm_\cfunc) @@ -1036,11 +1034,6 @@ SYM_CODE_START_LOCAL_NOALIGN(handle_exception) ENCODE_FRAME_POINTER movl PT_GS(%esp), %edi # get the function address - - /* fixup orig %eax */ - movl PT_ORIG_EAX(%esp), %edx # get the error code - movl $-1, PT_ORIG_EAX(%esp) # no syscall to restart - movl %esp, %eax # pt_regs pointer CALL_NOSPEC edi diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index 43606de22511..ddfa0e7b8485 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -337,9 +337,8 @@ SYM_CODE_END(xen_error_entry) /** * idtentry_body - Macro to emit code calling the C function * @cfunc: C function to be called - * @has_error_code: Hardware pushed error code on stack */ -.macro idtentry_body cfunc has_error_code:req +.macro idtentry_body cfunc /* * Call error_entry() and switch to the task stack if from userspace. @@ -356,12 +355,6 @@ SYM_CODE_END(xen_error_entry) UNWIND_HINT_REGS movq %rsp, %rdi /* pt_regs pointer into 1st argument*/ - - .if \has_error_code == 1 - movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ - movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ - .endif - call \cfunc /* For some configurations \cfunc ends up being a noreturn. */ @@ -412,7 +405,7 @@ SYM_CODE_START(\asmsym) .Lfrom_usermode_no_gap_\@: .endif - idtentry_body \cfunc \has_error_code + idtentry_body \cfunc _ASM_NOKPROBE(\asmsym) SYM_CODE_END(\asmsym) @@ -485,7 +478,7 @@ SYM_CODE_START(\asmsym) /* Switch to the regular task stack and use the noist entry point */ .Lfrom_usermode_switch_stack_\@: - idtentry_body noist_\cfunc, has_error_code=0 + idtentry_body noist_\cfunc _ASM_NOKPROBE(\asmsym) SYM_CODE_END(\asmsym) @@ -548,12 +541,7 @@ SYM_CODE_START(\asmsym) ENCODE_FRAME_POINTER UNWIND_HINT_REGS - /* Update pt_regs */ - movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ - movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ - movq %rsp, %rdi /* pt_regs pointer */ - call kernel_\cfunc /* @@ -565,7 +553,7 @@ SYM_CODE_START(\asmsym) /* Switch to the regular task stack */ .Lfrom_usermode_switch_stack_\@: - idtentry_body user_\cfunc, has_error_code=1 + idtentry_body user_\cfunc _ASM_NOKPROBE(\asmsym) SYM_CODE_END(\asmsym) @@ -589,8 +577,6 @@ SYM_CODE_START(\asmsym) UNWIND_HINT_REGS movq %rsp, %rdi /* pt_regs pointer into first argument */ - movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ - movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ call \cfunc /* For some configurations \cfunc ends up being a noreturn. */ diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h index b241af4ce9b4..7e0e9f8bc8ab 100644 --- a/arch/x86/include/asm/idtentry.h +++ b/arch/x86/include/asm/idtentry.h @@ -15,7 +15,7 @@ /** * DECLARE_IDTENTRY - Declare functions for simple IDT entry points - * No error code pushed by hardware + * An error code may be pushed by hardware * @vector: Vector number (ignored for C) * @func: Function name of the entry point * @@ -76,42 +76,25 @@ static __always_inline void __##func(struct pt_regs *regs) * - The XEN PV trap entry point: xen_##func (maybe unused) * - The C handler called from the ASM entry point * - * Same as DECLARE_IDTENTRY, but has an extra error_code argument for the - * C-handler. + * Same as DECLARE_IDTENTRY(), but required for emitting the ASM stubs, which + * do NOT need to push -1 as an error code placement. */ #define DECLARE_IDTENTRY_ERRORCODE(vector, func) \ - asmlinkage void asm_##func(void); \ - asmlinkage void xen_asm_##func(void); \ - __visible void func(struct pt_regs *regs, unsigned long error_code) + DECLARE_IDTENTRY(vector, func) /** * DEFINE_IDTENTRY_ERRORCODE - Emit code for simple IDT entry points * Error code pushed by hardware * @func: Function name of the entry point * - * Same as DEFINE_IDTENTRY, but has an extra error_code argument + * Same as DEFINE_IDTENTRY(). */ #define DEFINE_IDTENTRY_ERRORCODE(func) \ -static __always_inline void __##func(struct pt_regs *regs, \ - unsigned long error_code); \ - \ -__visible noinstr void func(struct pt_regs *regs, \ - unsigned long error_code) \ -{ \ - irqentry_state_t state = irqentry_enter(regs); \ - \ - instrumentation_begin(); \ - __##func (regs, error_code); \ - instrumentation_end(); \ - irqentry_exit(regs, state); \ -} \ - \ -static __always_inline void __##func(struct pt_regs *regs, \ - unsigned long error_code) + DEFINE_IDTENTRY(func) /** * DECLARE_IDTENTRY_RAW - Declare functions for raw IDT entry points - * No error code pushed by hardware + * An error code may be pushed by hardware * @vector: Vector number (ignored for C) * @func: Function name of the entry point * @@ -135,7 +118,7 @@ static __always_inline void __##func(struct pt_regs *regs, \ * is required before the enter/exit() helpers are invoked. */ #define DEFINE_IDTENTRY_RAW(func) \ -__visible noinstr void func(struct pt_regs *regs) + __visible noinstr void func(struct pt_regs *regs) /** * DECLARE_IDTENTRY_RAW_ERRORCODE - Declare functions for raw IDT entry points @@ -143,7 +126,8 @@ __visible noinstr void func(struct pt_regs *regs) * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Maps to DECLARE_IDTENTRY_ERRORCODE() + * Maps to DECLARE_IDTENTRY_ERRORCODE() for emitting the ASM stubs, which + * do NOT need to push -1 as an error code placement */ #define DECLARE_IDTENTRY_RAW_ERRORCODE(vector, func) \ DECLARE_IDTENTRY_ERRORCODE(vector, func) @@ -157,13 +141,10 @@ __visible noinstr void func(struct pt_regs *regs) * The macro is written so it acts as function definition. Append the * body with a pair of curly brackets. * - * Contrary to DEFINE_IDTENTRY_ERRORCODE() this does not invoke the - * irqentry_enter/exit() helpers before and after the body invocation. This - * needs to be done in the body itself if applicable. Use if extra work - * is required before the enter/exit() helpers are invoked. + * Same as DEFINE_IDTENTRY_RAW(). */ #define DEFINE_IDTENTRY_RAW_ERRORCODE(func) \ -__visible noinstr void func(struct pt_regs *regs, unsigned long error_code) + DEFINE_IDTENTRY_RAW(func) /** * DECLARE_IDTENTRY_IRQ - Declare functions for device interrupt IDT entry @@ -171,40 +152,37 @@ __visible noinstr void func(struct pt_regs *regs, unsigned long error_code) * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Maps to DECLARE_IDTENTRY_ERRORCODE() + * Maps to DECLARE_IDTENTRY(). */ #define DECLARE_IDTENTRY_IRQ(vector, func) \ - DECLARE_IDTENTRY_ERRORCODE(vector, func) + DECLARE_IDTENTRY(vector, func) /** * DEFINE_IDTENTRY_IRQ - Emit code for device interrupt IDT entry points * @func: Function name of the entry point * - * The vector number is pushed by the low level entry stub and handed - * to the function as error_code argument which needs to be truncated - * to an u8 because the push is sign extending. + * The vector number is pushed by the low level entry stub into the orig_ax + * member of the pt_regs structure passed as the only argument. * * irq_enter/exit_rcu() are invoked before the function body and the * KVM L1D flush request is set. Stack switching to the interrupt stack * has to be done in the function body if necessary. */ #define DEFINE_IDTENTRY_IRQ(func) \ -static void __##func(struct pt_regs *regs, u32 vector); \ +static void __##func(struct pt_regs *regs); \ \ -__visible noinstr void func(struct pt_regs *regs, \ - unsigned long error_code) \ +__visible noinstr void func(struct pt_regs *regs) \ { \ irqentry_state_t state = irqentry_enter(regs); \ - u32 vector = (u32)(u8)error_code; \ \ instrumentation_begin(); \ kvm_set_cpu_l1tf_flush_l1d(); \ - run_irq_on_irqstack_cond(__##func, regs, vector); \ + run_irq_on_irqstack_cond(__##func, regs); \ instrumentation_end(); \ irqentry_exit(regs, state); \ } \ \ -static noinline void __##func(struct pt_regs *regs, u32 vector) +static noinline void __##func(struct pt_regs *regs) /** * DECLARE_IDTENTRY_SYSVEC - Declare functions for system vector entry points @@ -225,26 +203,10 @@ static noinline void __##func(struct pt_regs *regs, u32 vector) * DEFINE_IDTENTRY_SYSVEC - Emit code for system vector IDT entry points * @func: Function name of the entry point * - * irqentry_enter/exit() and irq_enter/exit_rcu() are invoked before the - * function body. KVM L1D flush request is set. - * - * Runs the function on the interrupt stack if the entry hit kernel mode + * Maps to DEFINE_IDTENTRY_IRQ(). */ #define DEFINE_IDTENTRY_SYSVEC(func) \ -static void __##func(struct pt_regs *regs); \ - \ -__visible noinstr void func(struct pt_regs *regs) \ -{ \ - irqentry_state_t state = irqentry_enter(regs); \ - \ - instrumentation_begin(); \ - kvm_set_cpu_l1tf_flush_l1d(); \ - run_sysvec_on_irqstack_cond(__##func, regs); \ - instrumentation_end(); \ - irqentry_exit(regs, state); \ -} \ - \ -static noinline void __##func(struct pt_regs *regs) + DEFINE_IDTENTRY_IRQ(func) /** * DEFINE_IDTENTRY_SYSVEC_SIMPLE - Emit code for simple system vector IDT @@ -297,8 +259,8 @@ static __always_inline void __##func(struct pt_regs *regs) * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Maps to DECLARE_IDTENTRY_RAW, but declares also the NOIST C handler - * which is called from the ASM entry point on user mode entry + * Maps to DECLARE_IDTENTRY_RAW(), but declares also the NOIST C handler + * which is called from the ASM entry point on user mode entry. */ #define DECLARE_IDTENTRY_IST(vector, func) \ DECLARE_IDTENTRY_RAW(vector, func); \ @@ -309,19 +271,19 @@ static __always_inline void __##func(struct pt_regs *regs) * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Maps to DECLARE_IDTENTRY_RAW_ERRORCODE, but declares also the + * Maps to DECLARE_IDTENTRY_RAW_ERRORCODE(), but declares also the * safe_stack C handler. */ #define DECLARE_IDTENTRY_VC(vector, func) \ DECLARE_IDTENTRY_RAW_ERRORCODE(vector, func); \ - __visible noinstr void kernel_##func(struct pt_regs *regs, unsigned long error_code); \ - __visible noinstr void user_##func(struct pt_regs *regs, unsigned long error_code) + __visible noinstr void kernel_##func(struct pt_regs *regs); \ + __visible noinstr void user_##func(struct pt_regs *regs) /** * DEFINE_IDTENTRY_IST - Emit code for IST entry points * @func: Function name of the entry point * - * Maps to DEFINE_IDTENTRY_RAW + * Maps to DEFINE_IDTENTRY_RAW(). */ #define DEFINE_IDTENTRY_IST(func) \ DEFINE_IDTENTRY_RAW(func) @@ -342,7 +304,7 @@ static __always_inline void __##func(struct pt_regs *regs) * @vector: Vector number (ignored for C) * @func: Function name of the entry point * - * Maps to DECLARE_IDTENTRY_RAW_ERRORCODE + * Maps to DECLARE_IDTENTRY_RAW_ERRORCODE(). */ #define DECLARE_IDTENTRY_DF(vector, func) \ DECLARE_IDTENTRY_RAW_ERRORCODE(vector, func) @@ -351,7 +313,7 @@ static __always_inline void __##func(struct pt_regs *regs) * DEFINE_IDTENTRY_DF - Emit code for double fault * @func: Function name of the entry point * - * Maps to DEFINE_IDTENTRY_RAW_ERRORCODE + * Maps to DEFINE_IDTENTRY_RAW_ERRORCODE(). */ #define DEFINE_IDTENTRY_DF(func) \ DEFINE_IDTENTRY_RAW_ERRORCODE(func) @@ -361,9 +323,9 @@ static __always_inline void __##func(struct pt_regs *regs) when raised from kernel mode * @func: Function name of the entry point * - * Maps to DEFINE_IDTENTRY_RAW_ERRORCODE + * Maps to DEFINE_IDTENTRY_RAW_ERRORCODE(). */ -#define DEFINE_IDTENTRY_VC_KERNEL(func) \ +#define DEFINE_IDTENTRY_VC_KERNEL(func) \ DEFINE_IDTENTRY_RAW_ERRORCODE(kernel_##func) /** @@ -371,9 +333,9 @@ static __always_inline void __##func(struct pt_regs *regs) when raised from user mode * @func: Function name of the entry point * - * Maps to DEFINE_IDTENTRY_RAW_ERRORCODE + * Maps to DEFINE_IDTENTRY_RAW_ERRORCODE(). */ -#define DEFINE_IDTENTRY_VC_USER(func) \ +#define DEFINE_IDTENTRY_VC_USER(func) \ DEFINE_IDTENTRY_RAW_ERRORCODE(user_##func) #else /* CONFIG_X86_64 */ @@ -390,7 +352,6 @@ static __always_inline void __##func(struct pt_regs *regs) #define DECLARE_IDTENTRY_DF(vector, func) \ asmlinkage void asm_##func(void); \ __visible void func(struct pt_regs *regs, \ - unsigned long error_code, \ unsigned long address) /** @@ -402,7 +363,6 @@ static __always_inline void __##func(struct pt_regs *regs) */ #define DEFINE_IDTENTRY_DF(func) \ __visible noinstr void func(struct pt_regs *regs, \ - unsigned long error_code, \ unsigned long address) #endif /* !CONFIG_X86_64 */ diff --git a/arch/x86/include/asm/irq_stack.h b/arch/x86/include/asm/irq_stack.h index 798183867d78..d04186267e26 100644 --- a/arch/x86/include/asm/irq_stack.h +++ b/arch/x86/include/asm/irq_stack.h @@ -153,7 +153,7 @@ } /* - * Function call sequence for __call_on_irqstack() for system vectors. + * Function call sequence for __call_on_irqstack() for IRQs. * * Note that irq_enter_rcu() and irq_exit_rcu() do not use the input * mechanism because these functions are global and cannot be optimized out @@ -166,41 +166,20 @@ * call to idtentry_exit() anyway, it's likely that it does not cause extra * effort for this asm magic. */ -#define ASM_CALL_SYSVEC \ +#define ASM_CALL_IRQ \ "call irq_enter_rcu \n" \ ASM_CALL_ARG1 \ "call irq_exit_rcu \n" -#define SYSVEC_CONSTRAINTS , [arg1] "r" (regs) +#define IRQ_CONSTRAINTS , [arg1] "r" (regs) -#define run_sysvec_on_irqstack_cond(func, regs) \ +#define run_irq_on_irqstack_cond(func, regs) \ { \ assert_function_type(func, void (*)(struct pt_regs *)); \ assert_arg_type(regs, struct pt_regs *); \ \ - call_on_irqstack_cond(func, regs, ASM_CALL_SYSVEC, \ - SYSVEC_CONSTRAINTS, regs); \ -} - -/* - * As in ASM_CALL_SYSVEC above the clobbers force the compiler to store - * @regs and @vector in callee saved registers. - */ -#define ASM_CALL_IRQ \ - "call irq_enter_rcu \n" \ - ASM_CALL_ARG2 \ - "call irq_exit_rcu \n" - -#define IRQ_CONSTRAINTS , [arg1] "r" (regs), [arg2] "r" ((unsigned long)vector) - -#define run_irq_on_irqstack_cond(func, regs, vector) \ -{ \ - assert_function_type(func, void (*)(struct pt_regs *, u32)); \ - assert_arg_type(regs, struct pt_regs *); \ - assert_arg_type(vector, u32); \ - \ call_on_irqstack_cond(func, regs, ASM_CALL_IRQ, \ - IRQ_CONSTRAINTS, regs, vector); \ + IRQ_CONSTRAINTS, regs); \ } #ifdef CONFIG_SOFTIRQ_ON_OWN_STACK @@ -220,22 +199,14 @@ #endif #else /* CONFIG_X86_64 */ -/* System vector handlers always run on the stack they interrupted. */ -#define run_sysvec_on_irqstack_cond(func, regs) \ +/* always run on the stack they interrupted. */ +#define run_irq_on_irqstack_cond(func, regs) \ { \ irq_enter_rcu(); \ func(regs); \ irq_exit_rcu(); \ } -/* Switches to the irq stack within func() */ -#define run_irq_on_irqstack_cond(func, regs, vector) \ -{ \ - irq_enter_rcu(); \ - func(regs, vector); \ - irq_exit_rcu(); \ -} - #endif /* !CONFIG_X86_64 */ #endif diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index af49e24b46a4..af3170239b2e 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -2230,7 +2230,7 @@ static noinline void handle_spurious_interrupt(u8 vector) */ DEFINE_IDTENTRY_IRQ(spurious_interrupt) { - handle_spurious_interrupt(vector); + handle_spurious_interrupt((u32)(u8)regs->orig_ax); } DEFINE_IDTENTRY_SYSVEC(sysvec_spurious_apic_interrupt) diff --git a/arch/x86/kernel/doublefault_32.c b/arch/x86/kernel/doublefault_32.c index 6eaf9a6bc02f..f2d635290034 100644 --- a/arch/x86/kernel/doublefault_32.c +++ b/arch/x86/kernel/doublefault_32.c @@ -70,7 +70,7 @@ asmlinkage noinstr void __noreturn doublefault_shim(void) regs.cx = TSS(cx); regs.bx = TSS(bx); - exc_double_fault(®s, 0, cr2); + exc_double_fault(®s, cr2); /* * x86_32 does not save the original CR3 anywhere on a task switch. diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 9f668d2f3d11..be1d8aeabdde 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -246,6 +246,7 @@ static __always_inline void handle_irq(struct irq_desc *desc, */ DEFINE_IDTENTRY_IRQ(common_interrupt) { + u32 vector = (u32)(u8)regs->orig_ax; struct pt_regs *old_regs = set_irq_regs(regs); struct irq_desc *desc; diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index 1ee7bed453de..34432c1c52ee 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -1773,24 +1773,23 @@ static enum es_result vc_handle_exitcode(struct es_em_ctxt *ctxt, static __always_inline void vc_forward_exception(struct es_em_ctxt *ctxt) { - long error_code = ctxt->fi.error_code; int trapnr = ctxt->fi.vector; ctxt->regs->orig_ax = ctxt->fi.error_code; switch (trapnr) { case X86_TRAP_GP: - exc_general_protection(ctxt->regs, error_code); + exc_general_protection(ctxt->regs); break; case X86_TRAP_UD: exc_invalid_op(ctxt->regs); break; case X86_TRAP_PF: write_cr2(ctxt->fi.cr2); - exc_page_fault(ctxt->regs, error_code); + exc_page_fault(ctxt->regs); break; case X86_TRAP_AC: - exc_alignment_check(ctxt->regs, error_code); + exc_alignment_check(ctxt->regs); break; default: pr_emerg("Unsupported exception in #VC instruction emulation - can't continue\n"); @@ -1885,6 +1884,7 @@ static __always_inline bool vc_is_db(unsigned long error_code) */ DEFINE_IDTENTRY_VC_KERNEL(exc_vmm_communication) { + unsigned long error_code = regs->orig_ax; irqentry_state_t irq_state; /* @@ -1937,6 +1937,8 @@ DEFINE_IDTENTRY_VC_KERNEL(exc_vmm_communication) */ DEFINE_IDTENTRY_VC_USER(exc_vmm_communication) { + unsigned long error_code = regs->orig_ax; + /* * Handle #DB before calling into !noinstr code to avoid recursive #DB. */ diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 4a817d20ce3b..26d023560d03 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -233,6 +233,8 @@ enum cp_error_code { DEFINE_IDTENTRY_ERRORCODE(exc_control_protection) { + unsigned long error_code = regs->orig_ax; + if (!cpu_feature_enabled(X86_FEATURE_IBT)) { pr_err("Unexpected #CP\n"); BUG(); @@ -360,24 +362,25 @@ DEFINE_IDTENTRY(exc_coproc_segment_overrun) DEFINE_IDTENTRY_ERRORCODE(exc_invalid_tss) { - do_error_trap(regs, error_code, "invalid TSS", X86_TRAP_TS, SIGSEGV, + do_error_trap(regs, regs->orig_ax, "invalid TSS", X86_TRAP_TS, SIGSEGV, 0, NULL); } DEFINE_IDTENTRY_ERRORCODE(exc_segment_not_present) { - do_error_trap(regs, error_code, "segment not present", X86_TRAP_NP, + do_error_trap(regs, regs->orig_ax, "segment not present", X86_TRAP_NP, SIGBUS, 0, NULL); } DEFINE_IDTENTRY_ERRORCODE(exc_stack_segment) { - do_error_trap(regs, error_code, "stack segment", X86_TRAP_SS, SIGBUS, + do_error_trap(regs, regs->orig_ax, "stack segment", X86_TRAP_SS, SIGBUS, 0, NULL); } DEFINE_IDTENTRY_ERRORCODE(exc_alignment_check) { + unsigned long error_code = regs->orig_ax; char *str = "alignment check"; if (notify_die(DIE_TRAP, str, regs, error_code, X86_TRAP_AC, SIGBUS) == NOTIFY_STOP) @@ -436,6 +439,7 @@ __visible void __noreturn handle_stack_overflow(struct pt_regs *regs, */ DEFINE_IDTENTRY_DF(exc_double_fault) { + unsigned long error_code = regs->orig_ax; static const char str[] = "double fault"; struct task_struct *tsk = current; @@ -728,6 +732,7 @@ static void gp_user_force_sig_segv(struct pt_regs *regs, int trapnr, DEFINE_IDTENTRY_ERRORCODE(exc_general_protection) { + unsigned long error_code = regs->orig_ax; char desc[sizeof(GPFSTR) + 50 + 2*sizeof(unsigned long) + 1] = GPFSTR; enum kernel_gp_hint hint = GP_NO_HINT; unsigned long gp_addr; @@ -1254,7 +1259,8 @@ DEFINE_IDTENTRY(exc_simd_coprocessor_error) if (IS_ENABLED(CONFIG_X86_INVD_BUG)) { /* AMD 486 bug: INVD in CPL 0 raises #XF instead of #GP */ if (!static_cpu_has(X86_FEATURE_XMM)) { - __exc_general_protection(regs, 0); + regs->orig_ax = 0; + __exc_general_protection(regs); return; } } diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index e8711b2cafaf..c821ea389194 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c @@ -1471,9 +1471,9 @@ trace_page_fault_entries(struct pt_regs *regs, unsigned long error_code, } static __always_inline void -handle_page_fault(struct pt_regs *regs, unsigned long error_code, - unsigned long address) +handle_page_fault(struct pt_regs *regs, unsigned long address) { + unsigned long error_code = regs->orig_ax; trace_page_fault_entries(regs, error_code, address); if (unlikely(kmmio_fault(regs, address))) @@ -1539,7 +1539,7 @@ DEFINE_IDTENTRY_RAW_ERRORCODE(exc_page_fault) state = irqentry_enter(regs); instrumentation_begin(); - handle_page_fault(regs, error_code, address); + handle_page_fault(regs, address); instrumentation_end(); irqentry_exit(regs, state); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 93b658248d01..929d56acd033 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -614,7 +614,7 @@ DEFINE_IDTENTRY_RAW(xenpv_exc_nmi) DEFINE_IDTENTRY_RAW_ERRORCODE(xenpv_exc_double_fault) { /* On Xen PV, DF doesn't use IST. The C part is the same as native. */ - exc_double_fault(regs, error_code); + exc_double_fault(regs); } DEFINE_IDTENTRY_RAW(xenpv_exc_debug) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 08:56:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 08:56:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576993.903749 (Exim 4.92) (envelope-from ) id 1qRqbJ-0006zZ-Lg; Fri, 04 Aug 2023 08:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576993.903749; Fri, 04 Aug 2023 08:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqbJ-0006zS-Hi; Fri, 04 Aug 2023 08:56:01 +0000 Received: by outflank-mailman (input) for mailman id 576993; Fri, 04 Aug 2023 08:56:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqbI-0006zI-RX; Fri, 04 Aug 2023 08:56:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqbI-0005jR-Ne; Fri, 04 Aug 2023 08:56:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqbI-000633-5E; Fri, 04 Aug 2023 08:56:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRqbI-0000eN-4r; Fri, 04 Aug 2023 08:56:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P2PBGBnBXowxWyvx0omohco/W7SZ624YGgAt4kyPGXw=; b=bgo1nMaKsw+NwzBpnMkQy+edOz Q6ABX0u6Dv375UUBPVpcQLqc9rl7beBrhsm5VyKAB3bGWvX0+6nXCkhGpnLeuYTIQIKauFR3Cx7FS NRWJup1CjscrzO973tIKLLTJxm2PZgVp+YOrMDPPdPMUqGsUieJYbJAe0WtxKrghT5lU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182138: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b954598a47ba07034aab9af8ddd485bdc3d5b16 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Fri, 04 Aug 2023 08:56:00 +0000 flight 182138 linux-linus real [real] flight 182178 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182138/ http://logs.test-lab.xenproject.org/osstest/logs/182178/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 8 xen-boot fail in 182178 pass in 182138 test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 182178-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail pass in 182178-retest test-amd64-amd64-xl-qemut-ws16-amd64 18 guest-localmigrate/x10 fail pass in 182178-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 182178-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail in 182178 like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 4b954598a47ba07034aab9af8ddd485bdc3d5b16 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 109 days Failing since 180281 2023-04-17 06:24:36 Z 109 days 198 attempts Testing same since 182138 2023-08-02 22:48:54 Z 1 days 1 attempts ------------------------------------------------------------ 3878 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 651608 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:03:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:03:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.576999.903759 (Exim 4.92) (envelope-from ) id 1qRqiG-0008Uf-CH; Fri, 04 Aug 2023 09:03:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576999.903759; Fri, 04 Aug 2023 09:03:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqiG-0008UY-9V; Fri, 04 Aug 2023 09:03:12 +0000 Received: by outflank-mailman (input) for mailman id 576999; Fri, 04 Aug 2023 09:03:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqiF-0008US-49 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:03:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqiE-0005sO-3B; Fri, 04 Aug 2023 09:03:10 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRqiD-0004g7-Qw; Fri, 04 Aug 2023 09:03:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+dhv7Xz6G0hkrYUySzHtu1LHHXk+PnYz26B7+9SAGWc=; b=LWhL/Wom9fUevXyJP728xdOzPA x0z8Zk48naKY19QBX+/K9pE+yzRyRkiuDtj2XfofyHVKTWAfwHtwTdyRFAGZhPk34PwpzCDD4qbXI 5TUo/oINoNMmiYS7Lyjk28q8BckhM1LGPdUaWLwjfQbZmIPrDONnTJIFA4gan0Gq2b8M=; Message-ID: <3ddab6ee-54fc-49a0-8f14-79ca258d04af@xen.org> Date: Fri, 4 Aug 2023 10:03:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-GB To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20230803104438.24720-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Daniel, On 03/08/2023 11:44, Daniel P. Smith wrote: > +compatible > + Identifies which hypervisors the configuration is compatible. Required. > > - hypervisor { > - compatible = “hypervisor,xen†> + Format: "hypervisor,", e.g "hypervisor,xen" I read "e.g" as "for example". You don't explicitely say which compatible will be supported by Xen, so one could write "hypervisor,foo" and expect to work. Also, it is not fully clear why you need both the hypervisor and each domain node to have a compatible with the hypervisor name in it. [...] > +compatible > + Identifies the hypervisor the confiugration is intended. Required. Also typo: s/confiugration/configuration/ > > -The modules that would be supplied when using the above config would be: > + Format: ",config", e.g "xen,config" > > -* (the above config, compiled into hardware tree) > -* CPU microcode > -* XSM policy > -* kernel for boot domain > -* ramdisk for boot domain > -* boot domain configuration file > -* kernel for the classic dom0 domain > -* ramdisk for the classic dom0 domain > +bootargs > + This is used to provide the boot params for Xen. How is this different from the command line parameter chosen? And if you want to keep both, what is the expected priority if a user provides both? > > -The hypervisor device tree would be compiled into the hardware device tree and > -provided to Xen using the standard method currently in use. The remaining > -modules would need to be loaded in the respective addresses specified in the > -`module-addr` property. > + Format: String, e.g. "flask=silo" > > +Child Nodes > +""""""""""" > > -The Hypervisor node > -------------------- > +* module > > -The hypervisor node is a top level container for the domains that will be built > -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` > -property is used to identify the type of hypervisor node present.. > +Domain Node > +----------- > > -compatible > - Identifies the type of node. Required. > +A ``domain`` node is for describing the construction of a domain. Since there > +may be one or more domain nodes, each one requires a unique, DTB compliant name > +and a ``compatible`` property to identify as a domain node. > > -The Config node > ---------------- > +A ``domain`` node may provide a ``domid`` property which will be used as the > +requested domain id for the domain with a value of “0†signifying to use the > +next available domain id, which is the default behavior if omitted. It should > +be noted that a domain configuration is not able to request a domid of “0†Why do you need this restriction? And more importantly how would you describe dom0 in hyperlaunch? > +Beyond that, a domain node may have any of the following optional properties. > > -A config node is for detailing any modules that are of interest to Xen itself. > -For example this would be where Xen would be informed of microcode or XSM > -policy locations. If the modules are multiboot modules and are able to be > -located by index within the module chain, the ``mb-index`` property should be > -used to specify the index in the multiboot module chain.. If the module will be > -located by physical memory address, then the ``module-addr`` property should be > -used to identify the location and size of the module. > +Properties > +"""""""""" > > compatible > - Identifies the type of node. Required. > - > -The Domain node > ---------------- > + Identifies the node as a domain node and for which hypervisor. Required. > > -A domain node is for describing the construction of a domain. It may provide a > -domid property which will be used as the requested domain id for the domain > -with a value of “0†signifying to use the next available domain id, which is > -the default behavior if omitted. A domain configuration is not able to request > -a domid of “0â€. After that a domain node may have any of the following > -parameters, > - > -compatible > - Identifies the type of node. Required. > + Format: ",domain", e.g "xen,domain" > > domid > - Identifies the domid requested to assign to the domain. Required. > + Identifies the domid requested to assign to the domain. > > -permissions > + Format: Integer, e.g <0> > + > +role > This sets what Discretionary Access Control permissions > a domain is assigned. Optional, default is none. > > -functions > - This identifies what system functions a domain will fulfill. > + Format: Bitfield, e.g <3> or <0x00000003> > + > + ROLE_NONE (0) > + ROLE_UNBOUNDED_DOMAIN (1U<<0) > + ROLE_CONTROL_DOMAIN (1U<<1) > + ROLE_HARDWARE_DOMAIN (1U<<2) > + ROLE_XENSTORE_DOMAIN (1U<<3) Please describe what each roles are meant for. > + > +capability > + This identifies what system capabilities a domain may have beyond the role it > + was assigned. > Optional, the default is none. > > -.. note:: The `functions` bits that have been selected to indicate > - ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits > - (30, 31) such that should these features ever be fully retired, the flags may > - be dropped without leaving a gap in the flag set. > + Format: Bitfield, e.g <3221225487> or <0xC0000007> I thik we should favor the hexadecimal version because this will be somewhat easier to read. Also, the Device-Tree values work in term of 32-bit cell. Also, how do you plan to handle the case where you have more than 32 capabilities? > + > + CAP_NONE (0) > + CAP_CONSOLE_IO (1U<<0) Please describe the capabilities. > > mode > The mode the domain will be executed under. Required. > > + Format: Bitfield, e.g <5> or <0x00000005> > + > + MODE_PARAVIRTUALIZED (1 << 0) PV | PVH/HVM > + MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH > + MODE_LONG (1 << 2) 64 BIT | 32 BIT > + > domain-uuid > A globally unique identifier for the domain. Optional, > the default is NULL. > > + Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] > + > cpus > The number of vCPUs to be assigned to the domain. Optional, > the default is “1â€. > > + Format: Integer, e.g <0> This is odd to suggest to give '0' as an example. Wouldn't Xen throw an error if a user provide it? > + > memory > - The amount of memory to assign to the domain, in KBs. > + The amount of memory to assign to the domain, in KBs. This field uses a DTB > + Reg which contains a start and size. For memory allocation start may or may > + not have significance but size will always be used for the amount of memory > Required. The description doesn't match... > > + Format: String min: | max: | , e.g. "256M" ... the format. But strings are difficult to parse. If you want to provide 3 different values (possibly optional), then it would be best to have 3 different properties. I will continue to review the rest later. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:05:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:05:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577002.903769 (Exim 4.92) (envelope-from ) id 1qRqkr-0000ei-Pv; Fri, 04 Aug 2023 09:05:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577002.903769; Fri, 04 Aug 2023 09:05:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqkr-0000eb-Mr; Fri, 04 Aug 2023 09:05:53 +0000 Received: by outflank-mailman (input) for mailman id 577002; Fri, 04 Aug 2023 09:05:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqkq-0000eV-Po for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:05:52 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c1d1c3e-32a6-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:05:51 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id A9A974EE0737; Fri, 4 Aug 2023 11:05:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c1d1c3e-32a6-11ee-b26b-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [XEN PATCH] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Fri, 4 Aug 2023 11:05:41 +0200 Message-Id: <7f4d7be410aecaab6e356947bb79e703037f4101.1691139867.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional changes. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/mm.h | 20 ++++++++++---------- xen/arch/x86/mm.c | 33 ++++++++++++++++++--------------- xen/include/xen/mm.h | 2 +- 3 files changed, 29 insertions(+), 26 deletions(-) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index db29e3e205..1e2d8c1a65 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -408,7 +408,7 @@ void put_page_type(struct page_info *page); int get_page_type(struct page_info *page, unsigned long type); int put_page_type_preemptible(struct page_info *page); int get_page_type_preemptible(struct page_info *page, unsigned long type); -int put_old_guest_table(struct vcpu *); +int put_old_guest_table(struct vcpu *v); int get_page_from_l1e( l1_pgentry_t l1e, struct domain *l1e_owner, struct domain *pg_owner); void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner); @@ -559,7 +559,7 @@ void audit_domains(void); void make_cr3(struct vcpu *v, mfn_t mfn); void update_cr3(struct vcpu *v); -int vcpu_destroy_pagetables(struct vcpu *); +int vcpu_destroy_pagetables(struct vcpu *v); void *do_page_walk(struct vcpu *v, unsigned long addr); /* Allocator functions for Xen pagetables. */ @@ -574,20 +574,20 @@ int __sync_local_execstate(void); /* Arch-specific portion of memory_op hypercall. */ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); -int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void)); -int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void)); +int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); +int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); #define NIL(type) ((type *)-sizeof(type)) #define IS_NIL(ptr) (!((uintptr_t)(ptr) + sizeof(*(ptr)))) -int create_perdomain_mapping(struct domain *, unsigned long va, - unsigned int nr, l1_pgentry_t **, - struct page_info **); -void destroy_perdomain_mapping(struct domain *, unsigned long va, +int create_perdomain_mapping(struct domain *d, unsigned long va, + unsigned int nr, l1_pgentry_t **pl1tab, + struct page_info **ppg); +void destroy_perdomain_mapping(struct domain *d, unsigned long va, unsigned int nr); -void free_perdomain_mappings(struct domain *); +void free_perdomain_mappings(struct domain *d); -void __iomem *ioremap_wc(paddr_t, size_t); +void __iomem *ioremap_wc(paddr_t pa, size_t len); extern int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm); diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index be2b10a391..e1d9b94007 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5591,7 +5591,7 @@ int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) * * It is an error to call with present flags over an unpopulated range. */ -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) { bool locking = system_state > SYS_STATE_boot; l3_pgentry_t *pl3e = NULL; @@ -5604,7 +5604,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) /* Set of valid PTE bits which may be altered. */ #define FLAGS_MASK (_PAGE_NX|_PAGE_DIRTY|_PAGE_ACCESSED|_PAGE_RW|_PAGE_PRESENT) - nf &= FLAGS_MASK; + flags &= FLAGS_MASK; ASSERT(IS_ALIGNED(s, PAGE_SIZE)); ASSERT(IS_ALIGNED(e, PAGE_SIZE)); @@ -5628,7 +5628,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) if ( !(l3e_get_flags(*pl3e) & _PAGE_PRESENT) ) { /* Confirm the caller isn't trying to create new mappings. */ - ASSERT(!(nf & _PAGE_PRESENT)); + ASSERT(!(flags & _PAGE_PRESENT)); v += 1UL << L3_PAGETABLE_SHIFT; v &= ~((1UL << L3_PAGETABLE_SHIFT) - 1); @@ -5645,9 +5645,10 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) ((e - v) >= (1UL << L3_PAGETABLE_SHIFT)) ) { /* PAGE1GB: whole superpage is modified. */ - l3_pgentry_t nl3e = !(nf & _PAGE_PRESENT) ? l3e_empty() + l3_pgentry_t nl3e = !(flags & _PAGE_PRESENT) ? l3e_empty() : l3e_from_pfn(l3e_get_pfn(*pl3e), - (l3e_get_flags(*pl3e) & ~FLAGS_MASK) | nf); + (l3e_get_flags(*pl3e) & ~FLAGS_MASK) | + flags); l3e_write_atomic(pl3e, nl3e); v += 1UL << L3_PAGETABLE_SHIFT; @@ -5691,7 +5692,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) if ( !(l2e_get_flags(*pl2e) & _PAGE_PRESENT) ) { /* Confirm the caller isn't trying to create new mappings. */ - ASSERT(!(nf & _PAGE_PRESENT)); + ASSERT(!(flags & _PAGE_PRESENT)); v += 1UL << L2_PAGETABLE_SHIFT; v &= ~((1UL << L2_PAGETABLE_SHIFT) - 1); @@ -5704,9 +5705,10 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) ((e-v) >= (1UL << L2_PAGETABLE_SHIFT)) ) { /* PSE: whole superpage is modified. */ - l2_pgentry_t nl2e = !(nf & _PAGE_PRESENT) ? l2e_empty() + l2_pgentry_t nl2e = !(flags & _PAGE_PRESENT) ? l2e_empty() : l2e_from_pfn(l2e_get_pfn(*pl2e), - (l2e_get_flags(*pl2e) & ~FLAGS_MASK) | nf); + (l2e_get_flags(*pl2e) & ~FLAGS_MASK) | + flags); l2e_write_atomic(pl2e, nl2e); v += 1UL << L2_PAGETABLE_SHIFT; @@ -5756,11 +5758,11 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) /* Confirm the caller isn't trying to create new mappings. */ if ( !(l1e_get_flags(*pl1e) & _PAGE_PRESENT) ) - ASSERT(!(nf & _PAGE_PRESENT)); + ASSERT(!(flags & _PAGE_PRESENT)); - nl1e = !(nf & _PAGE_PRESENT) ? l1e_empty() + nl1e = !(flags & _PAGE_PRESENT) ? l1e_empty() : l1e_from_pfn(l1e_get_pfn(*pl1e), - (l1e_get_flags(*pl1e) & ~FLAGS_MASK) | nf); + (l1e_get_flags(*pl1e) & ~FLAGS_MASK) | flags); l1e_write_atomic(pl1e, nl1e); UNMAP_DOMAIN_PAGE(pl1e); @@ -5770,7 +5772,8 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) * If we are not destroying mappings, or not done with the L2E, * skip the empty&free check. */ - if ( (nf & _PAGE_PRESENT) || ((v != e) && (l1_table_offset(v) != 0)) ) + if ( (flags & _PAGE_PRESENT) || + ((v != e) && (l1_table_offset(v) != 0)) ) continue; if ( locking ) spin_lock(&map_pgdir_lock); @@ -5817,7 +5820,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) * If we are not destroying mappings, or not done with the L3E, * skip the empty&free check. */ - if ( (nf & _PAGE_PRESENT) || + if ( (flags & _PAGE_PRESENT) || ((v != e) && (l2_table_offset(v) + l1_table_offset(v) != 0)) ) continue; if ( locking ) @@ -5892,14 +5895,14 @@ int destroy_xen_mappings(unsigned long s, unsigned long e) * a problem. */ void init_or_livepatch modify_xen_mappings_lite( - unsigned long s, unsigned long e, unsigned int _nf) + unsigned long s, unsigned long e, unsigned int flags) { unsigned long v = s, fm, nf; /* Set of valid PTE bits which may be altered. */ #define FLAGS_MASK (_PAGE_NX|_PAGE_DIRTY|_PAGE_ACCESSED|_PAGE_RW|_PAGE_PRESENT) fm = put_pte_flags(FLAGS_MASK); - nf = put_pte_flags(_nf & FLAGS_MASK); + nf = put_pte_flags(flags & FLAGS_MASK); #undef FLAGS_MASK ASSERT(nf & _PAGE_PRESENT); diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 962ef216fd..4ed5fc4230 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -549,7 +549,7 @@ union add_to_physmap_extra { int xenmem_add_to_physmap_one(struct domain *d, unsigned int space, union add_to_physmap_extra extra, - unsigned long idx, gfn_t gfn); + unsigned long idx, gfn_t gpfn); int xenmem_add_to_physmap(struct domain *d, struct xen_add_to_physmap *xatp, unsigned int start); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:17:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577009.903779 (Exim 4.92) (envelope-from ) id 1qRqvm-0002En-Ue; Fri, 04 Aug 2023 09:17:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577009.903779; Fri, 04 Aug 2023 09:17:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqvm-0002Eg-Rq; Fri, 04 Aug 2023 09:17:10 +0000 Received: by outflank-mailman (input) for mailman id 577009; Fri, 04 Aug 2023 09:17:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqvl-0002Ea-8c for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:17:09 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af6d25a1-32a7-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:17:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D406C1F8AC; Fri, 4 Aug 2023 09:17:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC26113904; Fri, 4 Aug 2023 09:17:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AgVSKBLCzGTSEQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 09:17:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af6d25a1-32a7-11ee-b26b-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691140626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wuhFyyBsmhqFJy/tFrhyQ9oLDM6hdh5JtrRuEZ1uje0=; b=mEYLpPJ2ahCtlDBYyAFozRQj0oed6CNe1Z3143kmq9YXEsDtDLysKfvvy5R4UFSXn6S9p4 QdEYRWawcGsXGLJhPEaLedE+p/dYGzLJxnnDD/mR4BeUFDga24G5hSbJMpUzOCrcs/cA1p z1cQkxYOzqRHfFsCXXIJ6yPL2mMA7Rc= Message-ID: <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> Date: Fri, 4 Aug 2023 11:17:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mnyo4W0MMQmYmayX1fHAIwPt" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mnyo4W0MMQmYmayX1fHAIwPt Content-Type: multipart/mixed; boundary="------------PzyW7ymNkITIEblOCoSW18N2"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> In-Reply-To: --------------PzyW7ymNkITIEblOCoSW18N2 Content-Type: multipart/mixed; boundary="------------E5aInlkZvtzM3zKWrZJCmhhX" --------------E5aInlkZvtzM3zKWrZJCmhhX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjMgMjM6MzYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAyNC8wNy8yMDIzIDEyOjAyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gZGlmZiAtLWdp dCBhL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jIGIvdG9vbHMveGVuc3RvcmUv eGVuc3RvcmVkX3dhdGNoLmMNCj4+IGluZGV4IDg2Y2Y4MzIyYjQuLjI2NjJhM2ZhNDkgMTAw NjQ0DQo+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYw0KPj4gKysr IGIvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX3dhdGNoLmMNCj4+IEBAIC0xNjYsMTkgKzE2 NiwxMiBAQCBzdGF0aWMgaW50IGRlc3Ryb3lfd2F0Y2godm9pZCAqX3dhdGNoKQ0KPj4gwqAg c3RhdGljIGludCBjaGVja193YXRjaF9wYXRoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBj b25zdCB2b2lkICpjdHgsDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGNvbnN0IGNoYXIgKipwYXRoLCBib29sICpyZWxhdGl2ZSkNCj4+IMKgIHsNCj4+IC3CoMKg wqAgLyogQ2hlY2sgaWYgdmFsaWQgZXZlbnQuICovDQo+PiAtwqDCoMKgIGlmIChzdHJzdGFy dHMoKnBhdGgsICJAIikpIHsNCj4+IC3CoMKgwqDCoMKgwqDCoCAqcmVsYXRpdmUgPSBmYWxz ZTsNCj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAoc3RybGVuKCpwYXRoKSA+IFhFTlNUT1JFX1JF TF9QQVRIX01BWCkNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gaW52YWw7DQo+ IA0KPiBJIGNhbid0IGZpbmQgYW4gZXhhY3QgbWF0Y2hpbmcgY2hlY2sgaW4gaXNfdmFsaWRf bm9kZW5hbWUoKS4gVGhlIGNhbGwgYWxzbyBzZWVtcyANCj4gdG8gcHV0IG1vcmUgcmVzdHJp Y3Rpb24gb24gJ0AnIG5vZGUuIENhbiB5b3UgY2xhcmlmeT8NCg0KVGhlIGNhbGwgb2YgZG9t YWluX21heF9jaGsoKSBpbiBpc192YWxpZF9ub2RlbmFtZSgpIHdpbGwgY2hlY2sgdGhlIGxl bmd0aA0Kb2YgdGhlIG5vZGUgbmFtZSAoYXQgbGVhc3QgZm9yIHVucHJpdmlsZWdlZCBjYWxs ZXJzLCB3aGljaCBpcyB0aGUgaW1wb3J0YW50DQpjYXNlKS4NCg0KVGhlIGFkZGl0aW9uYWwg cmVzdHJpY3Rpb25zIGZvciBzcGVjaWFsIG5vZGVzIGFyZToNCg0KLSB0aGV5IGNhbid0IGVu ZCB3aXRoICIvIg0KLSB0aGV5IGNhbid0IGNvbnRhaW4gIi8vIg0KLSB0aGV5IGNhbid0IGNv bnRhaW4gY2hhcmFjdGVycyBvdGhlciB0aGFuIHRoZSBvbmVzIGFsbG93ZWQgZm9yIG5vcm1h bCBub2Rlcw0KDQpOb25lIG9mIHRob3NlIHJlc3RyaWN0aW9ucyBhcmUgcHJvYmxlbWF0aWMu IEkgY2FuIGFkZCBzb21ldGhpbmcgdG8gdGhlDQpjb21taXQgbWVzc2FnZSBpZiB5b3Ugd2Fu dC4NCg0KDQpKdWVyZ2VuDQo= --------------E5aInlkZvtzM3zKWrZJCmhhX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E5aInlkZvtzM3zKWrZJCmhhX-- --------------PzyW7ymNkITIEblOCoSW18N2-- --------------mnyo4W0MMQmYmayX1fHAIwPt Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTMwhIFAwAAAAAACgkQsN6d1ii/Ey/9 cAf+KxAjqy/7vQNR7PeYHTD6iUxLkyuEZyIHLg8Jd7bVyzd9pU0zpDhDt/40l4sF1NyjEpEoHLKl qIHtSkFdi+roRi80050AlhnBY0/cdu2cLFNc0iemoq1Hl724NMPpVjUvMW3+GN02Fn8Rd+oEGyuq aOnBroycbchsTR9fZxMJ3/TH7wWiZzkcP0/C3+226PzFj2wusJ8nTiw4IHx2kZQBuplfhXwYH9sz ayQ8fi5SjRjEco1hZubR0YOcL5tDAOoTkvRufqNrhj3kyt4kEvIBIzO3N0MORGSzbuG9VcBvpp6Q OnZSoAD0DRElNC4DcyY8bdzkuEEIk57FocpuqW+tBw== =CoUR -----END PGP SIGNATURE----- --------------mnyo4W0MMQmYmayX1fHAIwPt-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:21:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:21:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577013.903789 (Exim 4.92) (envelope-from ) id 1qRqzy-0003ge-Gp; Fri, 04 Aug 2023 09:21:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577013.903789; Fri, 04 Aug 2023 09:21:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqzy-0003gX-D3; Fri, 04 Aug 2023 09:21:30 +0000 Received: by outflank-mailman (input) for mailman id 577013; Fri, 04 Aug 2023 09:21:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqzx-0003gR-6Q for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:21:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRqzw-0006LR-BE; Fri, 04 Aug 2023 09:21:28 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRqzw-0005Le-5H; Fri, 04 Aug 2023 09:21:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=r61StbouY/C8r/7hrH1QcobJYI1Q2gBAA4aCPWNc/p8=; b=oN/4IkcclgFRBGMC2yr2BfUQae yFBgl51xcNNkYCb8dHpNMA40NYwWNDBwvWjiH85DcpshVKb6fI/klyad1JjpZ7k8TzBSUqyxaKcjT MNhGv9Ux3fbVk7vrCOlDTCKpUcq9ECPy354Pqdmmcq9p/ii6rmQt4PWLCy7/CAgo/UIo=; Message-ID: Date: Fri, 4 Aug 2023 10:21:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> From: Julien Grall In-Reply-To: <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/08/2023 10:17, Juergen Gross wrote: > On 03.08.23 23:36, Julien Grall wrote: >> Hi, >> >> On 24/07/2023 12:02, Juergen Gross wrote: >>> diff --git a/tools/xenstore/xenstored_watch.c >>> b/tools/xenstore/xenstored_watch.c >>> index 86cf8322b4..2662a3fa49 100644 >>> --- a/tools/xenstore/xenstored_watch.c >>> +++ b/tools/xenstore/xenstored_watch.c >>> @@ -166,19 +166,12 @@ static int destroy_watch(void *_watch) >>>   static int check_watch_path(struct connection *conn, const void *ctx, >>>                   const char **path, bool *relative) >>>   { >>> -    /* Check if valid event. */ >>> -    if (strstarts(*path, "@")) { >>> -        *relative = false; >>> -        if (strlen(*path) > XENSTORE_REL_PATH_MAX) >>> -            goto inval; >> >> I can't find an exact matching check in is_valid_nodename(). The call >> also seems to put more restriction on '@' node. Can you clarify? > > The call of domain_max_chk() in is_valid_nodename() will check the length > of the node name (at least for unprivileged callers, which is the important > case). Right, but from my understanding, this may not check against XENSTORE_REL_PATH_MAX but whatever limit the user set. This is a change of behavior that you ought to be explained. > > The additional restrictions for special nodes are: > > - they can't end with "/" > - they can't contain "//" > - they can't contain characters other than the ones allowed for normal > nodes > > None of those restrictions are problematic. I can add something to the > commit message if you want. Yes please. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:22:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:22:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577016.903799 (Exim 4.92) (envelope-from ) id 1qRr13-0004Dp-P4; Fri, 04 Aug 2023 09:22:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577016.903799; Fri, 04 Aug 2023 09:22:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRr13-0004Di-MM; Fri, 04 Aug 2023 09:22:37 +0000 Received: by outflank-mailman (input) for mailman id 577016; Fri, 04 Aug 2023 09:22:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRr12-0004Dc-WA for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:22:36 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72583f47-32a8-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 11:22:35 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 4FDC64EE0737; Fri, 4 Aug 2023 11:22:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72583f47-32a8-11ee-8613-37d641c3527e Message-ID: Date: Fri, 4 Aug 2023 11:22:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [XEN PATCH] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-US, it To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini References: <7f4d7be410aecaab6e356947bb79e703037f4101.1691139867.git.federico.serafini@bugseng.com> From: Federico Serafini Organization: BUGSENG srl In-Reply-To: <7f4d7be410aecaab6e356947bb79e703037f4101.1691139867.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/08/23 11:05, Federico Serafini wrote: > Give a name to unnamed parameters to address violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter names used in function > declarations and the ones used in the corresponding function > definitions, thus addressing violations of MISRA C:2012 Rule 8.3 > ("All declarations of an object or function shall use the same names > and type qualifiers"). > > No functional changes. > > Signed-off-by: Federico Serafini > --- > xen/arch/x86/include/asm/mm.h | 20 ++++++++++---------- > xen/arch/x86/mm.c | 33 ++++++++++++++++++--------------- > xen/include/xen/mm.h | 2 +- > 3 files changed, 29 insertions(+), 26 deletions(-) > > > int xenmem_add_to_physmap_one(struct domain *d, unsigned int space, > union add_to_physmap_extra extra, > - unsigned long idx, gfn_t gfn); > + unsigned long idx, gfn_t gpfn); I am seeing now that this will cause a violation in the arm code, I will propose a v2. -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:30:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577022.903809 (Exim 4.92) (envelope-from ) id 1qRr8B-0004vE-Gg; Fri, 04 Aug 2023 09:29:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577022.903809; Fri, 04 Aug 2023 09:29:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRr8B-0004v5-DF; Fri, 04 Aug 2023 09:29:59 +0000 Received: by outflank-mailman (input) for mailman id 577022; Fri, 04 Aug 2023 09:29:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRr89-0004tW-OL for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:29:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 775605bf-32a9-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 11:29:54 +0200 (CEST) Received: from mail-bn7nam10lp2106.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.106]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Aug 2023 05:29:43 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5800.namprd03.prod.outlook.com (2603:10b6:510:31::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Fri, 4 Aug 2023 09:29:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Fri, 4 Aug 2023 09:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 775605bf-32a9-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691141394; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=SRCvVe+S1DPLW95R0TrJ8z0SlTUu7EDvGqbeb2O13go=; b=IqiRx1Y4DNMMIJ5zeSaXoybDJToWvq0eEQMiuK3TEtBuGzxWmcy56/Z8 ek0CDGsoiptEM1mV5on6tE4o0L6+4Pe7X+UneQkvqC45Jdpqxeh5LrZlg jyIL+/0O58QIV4Gc+F0bbAgD0GYshqC+s1s2nqRSXAYQwSlpZCyTVLZ8g M=; X-IronPort-RemoteIP: 104.47.70.106 X-IronPort-MID: 118512424 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hFpuyKIIXSOBH9D7FE+Rh5UlxSXFcZb7ZxGr2PjKsXjdYENS0TIEz WVKUG/QbPaCZWGhKohxPIWz80MBvsWDmNVnHAZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5WAj5t7 PI5eAlcVTmhjdyIxY+WQ7RF05FLwMnDZOvzu1lG5BSAVbMMZ8+GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VvpTGLkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqrBdtISOfknhJsqG+v92lQWTMRbkGm/eWzpRWkeNcBO 1NBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rHP/w+TC2wATzhAQN8rrsk7QXotz FDht8ztLSxitvuSU3313rWJqTK/PwAFIGlEYjULJSMH7MPku5oblQ/UQ5BoF6vdptj8AzT52 T2JhCk4mbQIjMQP2rm7/FbImDalrN7CSQtdzgfeWG6//x56TIGgbo2sr1Pc6J5oIJ6CS1idv FANg8WE8P0VFpaJiTCMR+MWWrqu4p6tOz3GgEVzGIEh+i7r5DioeYlK4xlxIU5oNoAPfjqBS F/ev0Zd6YFeOFOubLRreMShBsIy16/iGN/5EPfOYbJzjoNZcQaG+GRkYxGW1mW0yEw0y/hnZ 9GcbNqmCmscBeJ/1j2qSuwB0LgtgCcj2WfUQpO9xBOiuVaDWEOopX4+GAPmRogEAGms8W05L /432xO29ihi IronPort-HdrOrdr: A9a23:HNYX7qyQBqvv5rB1ylSVKrPxMegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67SdC9qADnhPlICO4qTMqftWjdyRGVxeRZgbcKrAeQeBEWmtQtsJ uINpIOc+EYbmIK8/oSgjPZLz9I+rDunsGVbKXlvg9QpGlRGt5dBmxCe2Km+yNNNW977NYCZf ihDp0tnUvdRZ1bVLXyOpFDNNKz1eHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lMzQi5C2rAr9E nCikjc6r+4u/+25xfA3yuLhq4m1OfJ+59mPoihm8IVIjLjhkKBY5lgYaSLuHQYsfyi81Ejlf jLulMFM95o433cU2mpqV/G2hXm0hwp93j+oGXozEfLkIjcfnYXGsBBjYVWfl/w7Fchhsh11O Zu03iCv5RaIBvclGCljuK4HS1Cpw6Rmz4PgOQTh3tQXc83b6JQl5UW+AdwHI0bFCz3xYg7GK 1FDd3a5txRbVSGBkqp9VVH8ZiJZDAeDx2GSk8Ntoi81CVXpmlwyw8iyMkWjh47heUAYqgBw9 6BHrVjlblIQMNTR7l6Hv09Tcy+DXGIaQ7QMUqJSG6XVJ0vCjbokdra8b817OaldNgj150pgq nMV1teqCobZ1/uM8uTx5dGmyq9AVlVZQ6diP222qIJ/4EVHNHQQGm+oREV4oWdSswkc47ms6 3ZAuMQPxfhRVGebbqhkTeOHaW6EkNuI/H9iuxLKm5mnfi7WrECltarBso7d4CdWAoMayfYPk YpegTVCYFp0n2LM0WI9SQ5HUmdNXDCwQ== X-Talos-CUID: =?us-ascii?q?9a23=3AN7clmmvot2y8dkSU4h5Xt0BA6IsEcSL+1Xnxc3b?= =?us-ascii?q?pMk9LQoOrTGK98f5Nxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AlMKx8w8BwLS46xU0iI1qOD2Qf/VU0qHtWW4Kqo8?= =?us-ascii?q?b59WOGndqGDLDnCviFw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,254,1684814400"; d="scan'208";a="118512424" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XCHC5+ByiMpkKPCPNOADNI5soEaEh4hU41dWHd+xfeyTKnL4M2psJVRAG71uzu3hSqCEKzEi16RlpmJFzOnkuSPQT+JflKw1PFdMUUI6mQpXkMhk3TPaDNxuhIipgI5X3Ip6fuoHfMubOaEeaSU1JdBcvrlmXkAE/vCS5tZeuaBPyd9qV6FYlQ8DqwkpLgJKfhpY8WRgAU/9pbYTf+O94ebd2vaNzjWndLMh80Y4uyRcKo4VRg9McJ8JKuA9GGghx1ilCfUkr6qG1R6h40Ll83sgRg+GVXoFHrlDEnF2KcpVhf1O4t7uy3yiGSc/Yh2H0+v1h9lQGcB1WIOItH1tbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H+qOK9cx+4ZjG6NCincp5adHyETuhf+yKMXpcOoYjUg=; b=lO+7utAJod30CXYvHdp0m6erJaVS+H82mFoO9UiDTzN0pDYZx2kkFibwiW73ofz5PnRodrTBxXIfU4AMIfeMxVZMaI82dXKIyyoEjMRyhwsFFAWF12zC3jHFKeXlBGj2MZAThqH8BnkjLCvC5bnFwWfgAty8Y6jAuFQK2S4R+CFUK5DJ7P+CWeYbPV5+e9mWAe4uVKbbvCURF5FoUMp4DBkY8U89AUGoyJx8x7Ej8yaUToXP2chMfqLdSJFB7KlZf3TP+d+peg7snUCYFRWH0sxncacKAUYNpHghopoT1ctjkUqGaay8qAJiZrt1GYlCQNKDudULXY7UDBq51A9Snw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+qOK9cx+4ZjG6NCincp5adHyETuhf+yKMXpcOoYjUg=; b=GlDpgPEoBgAU2c3MJvtb1+JNctN9WAGCFTSNCQ9IjAbzPcQoQ2uZAI6WZtUqy2WWCP5JLtPo3OH8jd6SLcQw6btcqtXLkIJvaflLgzQVsJUm52GeAxkWWF2OCNtgR+NG5VFIrnIipPjDW2oYJvhLpDJMIvqcSrBlviObzvex4KU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <722dfba8-a768-55c1-29bb-2d8525282b4b@citrix.com> Date: Fri, 4 Aug 2023 10:29:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator Content-Language: en-GB To: Jan Beulich Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Jason Andryuk , Daniel Smith , Christopher Clark , Xen-devel References: <20230803203650.1474936-1-andrew.cooper3@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0494.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH0PR03MB5800:EE_ X-MS-Office365-Filtering-Correlation-Id: f492d36f-6406-4ade-a4d7-08db94cd542f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3maSrMXhyW6llioz8B0nAN9xFQkpgGDWWB5jMP7Uab3FohIT+866GSqj3wDU2x9uvOoj/0RPVYwr1EHFdZMq1zVCq9Zhif+7YIxZoK66Ck22df0bNfj5dwHbIHM1IM9rbBGW+8rx0TzHnY568+iqYwoMpSXUYuF22gkaXNvIQTtOMaCb/4YjP3FT1yCu/jxpAHx7Q8OCsemfmkr5/o/pSgJje6AGEJNmcuYbjv0UEmmNgYD+QzuBc8/AJQKVNesst8veHjM4/cWLXZ9GgdaDgNmbVJmuls6bGrox3J+j+1AaM5aTiT6dg/O6w8A95IgVPsYFSLajY6qCkyRONo3TmumYZxgHsG6Fh5qhJJxJf0oOEfQTHkzSP1CMhJTwhhMdtsggRBAFOclLIW5k3VQVHd53zbxKN9GJ/yvaQvlAxI2/PRrOIOF5xV9wS4aayR9RBMp/fvjz2XS4+aki4ih23bEL30DgZH5zIE0voRdzBlZVu9kxpsuBidGt3cybVq4qB/y7n5DGhh8wbuFffcoqDbVSDkBXTrJJdgMhBbuCMLqkFN80OuKLbf324/92Ug5/6Egu4h4QrtFTIh3lyR+Ivix8QnU2GGQ1IbAOpMV/k5Itd/RVOXXzsf1BE72N31y2KbUoJwvbK0zWnZ3pzKxwux3ZlmE0o5YgLWkRtSCpaz2LNqxIC3Spv9HMwoh2g320 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(136003)(39860400002)(396003)(346002)(186006)(1800799003)(451199021)(86362001)(36756003)(31696002)(31686004)(66574015)(478600001)(54906003)(38100700002)(82960400001)(8676002)(2616005)(83380400001)(26005)(6506007)(53546011)(6512007)(6666004)(7416002)(41300700001)(8936002)(6486002)(966005)(316002)(66556008)(2906002)(66476007)(4326008)(6916009)(5660300002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzhtTlp6WjMvcG5XYjdIejFhR2tqQ2F6YmpGcW5XZXpVTzloRWJjZXpZVU0w?= =?utf-8?B?YjRGNnNLclp1NCtUQzdrVzNCWVkvbFFqM1BpcVE4R0RsaTBFZmdBSU04Qi9w?= =?utf-8?B?VksxVEpGVzlLUVlkOXpOUXpXMnd6YU56dk5hZDZuOTRabGRjNTFmNkl6dGNB?= =?utf-8?B?UHozeGphTnJvem5Ub3Z3L2ZYVGQwVUpST2ZsSC9OdndSU3J4MlpqV1NPRHV0?= =?utf-8?B?aWhFclhPN0lHdlVGTXF1TDFVQ3Q1dUVaSUJIbStmaGpaTGtOR3RVeDNNRkFr?= =?utf-8?B?SlYxRjJHRFh3RGxyMm42UDdIR3o3NkIvcm13TFdJYk1MUXZXREthOCtTVVN3?= =?utf-8?B?enNqcFV6dXBGREMvQ3R6WVQ5R0N6WldrQ2wwSko2SHk3dC81MFZ4TG5tSU96?= =?utf-8?B?ODNZU05tQmtwN3YrTUc4ME96VFYwRVYvRk0rUGpsS2JVb0JidG5JMDZVanBn?= =?utf-8?B?cTFHeHU0VTZQRkdXWXczZFJqYnlRNjMvOUVZOE1odjBpQVBDQ2NhNGpoamZ6?= =?utf-8?B?Smo0NEw0WEtYSzFyOUllK2VQYXZXSjd0WlE4RUV1TStrUjV6dUp2ejVQNmVZ?= =?utf-8?B?MDN6QU82OVpWZTZJQ09hcFJCM3l3SVQ1a284UGZ0UTFGQjZSTEFBY1YrdGc0?= =?utf-8?B?eFNjQThIZ0MxZTB3TThjY3JrUDQ3TjkwNVdNOXdkNGo3Q25nUDRWZUlyL2Q0?= =?utf-8?B?bFBxRFVNYU5LZERlNm1CejNmVHVmVDhCZENGQWl5bGtMdklFdmd3a0lvVURI?= =?utf-8?B?L2dkSXhKTldzcUM2K0JKRjI3ODgwVWFQU2MyUkN3VjdSSEpSR21rdUM0MnA3?= =?utf-8?B?Rmt5cTI0UklCRWhucmhjeFVzRFh3VjdSSDNzR2lrUXRxdUNEU0JqMEw2MTlU?= =?utf-8?B?bHRhazhCamcyQzBwbng1RFdlYis3cFJ1VzQ2ZElGUlcyMndwT3MwYldZcVk4?= =?utf-8?B?RERtbExhZnNHTS9BM08vVHlNMVpQeE1PS3hIeFI4WE5ZNTZBWkpkYXZ0NTBK?= =?utf-8?B?emxpVzNSaUQrcGtaRjZGQTFOVU1LMFhQRGluSEc2ZUJBc2ovZHA4Qnk2NHpL?= =?utf-8?B?WjJrNjJwVG1NWnZqWU0wWmlMVDhhNzFjcFJOWDRoVC83eE9ZcFNYVXZHdjF3?= =?utf-8?B?RW1GdHN3ekZFVmM0ci9vWUlUUDA0dlI0OGs0c1d4YVllbGFMSDNURzRxNXFm?= =?utf-8?B?K1lYQ3dQTVRuVjl6QUlLZ1JiZUJlY3o4TVlha21XRmxoMnVrSlFqN3dsc0lH?= =?utf-8?B?TGVGcWx6dzdkT1NZazNOc0JWVEtydUZUWE1vL3RIcXlJbGRVMkVpSEh6T2Jy?= =?utf-8?B?ZXRMK21ESWVQWXVHY0ptc3RXV1pLdVFrV1BHVVp3MTI3UmJ1SEZ6eTEyMm90?= =?utf-8?B?eGdOdmhnZFd3VGlGUFR0Wlo0RDZCUEM5UVA4NWR6QlpTM2toYzluaURKR21m?= =?utf-8?B?VmI5b2hUamtqMnZIbmgvTFQ3TGVIQ0dJY2h1Q3hmRmMzN0pmM0VEOGZYa1hE?= =?utf-8?B?ak5YS3d2MGRJMVF3ZzJTMHB4dVZGTGtoeU5KWC8vTlJ1T1JrbTVTQ0NzcGxi?= =?utf-8?B?QTNPM1ZEd3ViVExIcjJkV2pJMUR1TUdVV1c5QlpHS09VSVB2UktzQ2hkNTVq?= =?utf-8?B?cHRpMVpNV0hZeXR6REorczhsdTlzdkYyNGxKNUtCTDR3VTNabjdDcmcydWIx?= =?utf-8?B?cjE5ajlmbE9xY1RmdmRNdkhpTVljNTJnTitQdGROaGNOZDBiVjV4ZVRvMG9J?= =?utf-8?B?ZHBvOEZnNlkzUkExcEVrakROYk1EV3l4cWlqUzA0amhMMWV3Z25aN1ZUbDUx?= =?utf-8?B?dHR5L2x0Y3pjWUp2MThqRk9Od2c4WkxheC8zdDlEdkN2ekRZSkNlUk8rMjh5?= =?utf-8?B?TDlzdHdybjVTSCtSaGFYeU4raU54Uk9YTG1WcUZpZTFLRUZ1ajhFWFFsU3JN?= =?utf-8?B?dWk4OHI5MG5BMEE4K2x1TG0xM0xvRHZHaXJSbXd6MHJpaGFKL3FBSGV0MERu?= =?utf-8?B?OEJycU5WYUZnKytYR3RtWEo5U1FkbTZ5QXpLcHh1eDV6Zjk1MGluNTBWaWQ5?= =?utf-8?B?WHVpMzFzOFczcG9vMEtyczlXdWZwVVc3akRYb1kxa3h3TzlZWHNaNUJOOFdv?= =?utf-8?B?RlF4cGhBOVZYV0JQZWVPSE5JZlVINnpZTklKakFOaHcxTzd6OHQ2a0VFckZZ?= =?utf-8?B?NVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Q0ZWWFBYMko3Y0IyR0xGeVh3eE5TVXFCUjQ1MUVzNnhKMWUrS1B0Y0daRXBr?= =?utf-8?B?N0pWc2k2UkRYa2h1SzY0Z0JyNlRUMXMxa2hQd0ZrdWphOU1jYXcrWEpPeHRK?= =?utf-8?B?OWQzbHQ0SkJWbGRzZDdXbk1jWDZxWFY5OEdCM0xXOG1NanA5Q25PTTl2L2Jx?= =?utf-8?B?UVIzSFhLWWJjSXJWNkRMYUNncWFvbGRyK2xHU1RlMDBvTjdQT3M2M3FoeldJ?= =?utf-8?B?c3lJa2V6V0ZZdVVFTy9nM1BiNFJ2NTlHWEFEUWhORnlqWkpEMkljTTJ1b0hr?= =?utf-8?B?bHNjN0E1SmZzRlQwSm1jekR4QVlYS2dmUTJHUGFHRUpQcWFINkVXMGwzU2xl?= =?utf-8?B?Zmp3dUhRMHM1UnNKdVl0aHgrS1Z5ejIwOFh4TzgrQklhWFdTV2FTV2cwMHBR?= =?utf-8?B?R0lhOG05TVMwK0w0eUprWVVjcDB2Q1NNbHVTMDViMThUSFhWZFNQa0t3a3dP?= =?utf-8?B?bWVKcWhIbUtFZW5zUStSQ1lPVkFiUi9UdGR3ZmZJT1FDVzdhUmFjNXVGNFpL?= =?utf-8?B?d3ZoMEpEWk93eGlSZEh5Mmo2QWxFeVdEVGZLUUgyTFo2OGpVN2xUZU5pY3Nn?= =?utf-8?B?dkNpL1JnK3RIbFhFeGVESmM1clpRNHZtQk1zMmEzWDJWNkRjcGtlazdCVTRp?= =?utf-8?B?bkdyUTRTWHhwUEFHZTZUL2RLejJnVnQ2bno1RmR0N1FqMWlMT2g4bXc0eFB3?= =?utf-8?B?b3MrNnh6R0oxQUJidE9NZzlVWkRJdFlvanZqNHZZcnNHQThySTBlS1E3RXc4?= =?utf-8?B?TXJKdFc0UWNkVWxoNXh3SStwYStOcS9DVzZuNkgxUDFTbWlYQjl0VTd1VXVI?= =?utf-8?B?dHFVQ3FBMXN2Q2dBSnZVcDdySXRVc3FqMEkvS2N5SG90citFOWw1RG1ldW9Q?= =?utf-8?B?S2Fjd09qSHVJd213U2kwQkdVZmQ0VStnMTlvd0gvaGg3UlphbTc1cHRkZnpZ?= =?utf-8?B?Y3FPMWEwKzdjWmJHNzZsbFBYY25Md3VmSTRJbTByNVhSdndwdVV3b2RYZm5P?= =?utf-8?B?S2IxTURIeHdsK1o4TWxPVzJYNHRmTnA2Vk9jcFNiTE9oNWFrMXZKbTEySnZM?= =?utf-8?B?N2tyamhjSjhxemhtREZxTXVkbUJRVWtDa3paSUJwd0hXNGhqelVaeFREWGx0?= =?utf-8?B?UFVxVlJjd1ZqT0RHdTZrdXRKZ3RjNjkwbFpwV3BIWXFINEVkR0U3VXNVaFU0?= =?utf-8?B?V0d0NDR5alE5L2doQlprYlM4TFpYQ094V1J6cDBXeFcwZUZub2hXTXVML0hM?= =?utf-8?B?emFmMVF0NzNWbE9NUFB4L1JtSjVLdmlNRVdVYWR2T01jTi9BRnpMQlVEcjly?= =?utf-8?Q?PVCuDdW2YRHPD7XAIKYZT2mbW7Ir0ILP5b?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f492d36f-6406-4ade-a4d7-08db94cd542f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 09:29:40.8439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sz4nwb0J3qAI2HKXCSlXyJmxA9L7y9JkcMPRmE2h1mtyRyIH3NPmNG9n2O2uK5uT3ZO/xcDCOT8xdgxkkXELxEcJEZUM21suzi2ZnwXWShs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5800 On 04/08/2023 8:23 am, Jan Beulich wrote: > On 03.08.2023 22:36, Andrew Cooper wrote: >> The opensuse-tumbleweed build jobs currently fail with: >> >> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': >> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NULL [-Werror=address] >> 56 | if (!key->p || !key->q || !key->u) { >> | ^ >> In file included from /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17: >> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12: note: 'p' declared here >> 28 | tpm_bn_t p; >> | ^ >> >> This is because all tpm_bn_t's are 1-element arrays (of either a GMP or >> OpenSSL BIGNUM flavour). The author was probably meaning to do value checks, >> but that's not what the code does. > Looking at the code, I'm not sure about this. There could as well have been > the intention to allow pointers there, then permitting them to be left at > NULL. Who knows where that code came from originally. Do you agree that the patch is no function change, or are you saying that you think I got some of my analysis wrong? > >> Adjust it to compile. No functional change. >> >> Signed-off-by: Andrew Cooper >> --- >> CC: George Dunlap >> CC: Jan Beulich >> CC: Stefano Stabellini >> CC: Wei Liu >> CC: Julien Grall >> CC: Juergen Gross >> CC: Marek Marczykowski-GĂ³recki >> CC: Jason Andryuk >> CC: Daniel Smith >> CC: Christopher Clark >> >> While I've confirmed this to fix the build issue: >> >> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/955160430 >> >> I'm -1 overall to the change, and would prefer to disable vtpm-stubdom >> entirely. >> >> It's TPM 1.2 only, using decades-old libs, and some stuff in the upstream >> https://github.com/PeterHuewe/tpm-emulator (which is still abandaonded as of >> 2018) is just as concerning as the basic error here in rsa_private(). >> >> vtpm-stubdom isn't credibly component of a Xen system, and we're wasting loads >> of CI cycles testing it... > Question is whether people might be using it, and I'm afraid that's a > question we can't answer. Would it be an alternative to disable vtpm in > this container's stubdom configure invocation? Obviously as other > containers have their compilers updated, the same issue may surface > there then ... Well that's why I CC'd some of the usual suspects, but all I'm suggesting (for now) is that we turn it off by default. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:34:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:34:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577027.903818 (Exim 4.92) (envelope-from ) id 1qRrCj-0006O8-53; Fri, 04 Aug 2023 09:34:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577027.903818; Fri, 04 Aug 2023 09:34:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrCj-0006O1-2F; Fri, 04 Aug 2023 09:34:41 +0000 Received: by outflank-mailman (input) for mailman id 577027; Fri, 04 Aug 2023 09:34:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrCh-0006Nv-Cv for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:34:39 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20c596b0-32aa-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 11:34:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C2CFA1F8AE; Fri, 4 Aug 2023 09:34:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E6D213904; Fri, 4 Aug 2023 09:34:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KMNKJSzGzGSlGgAAMHmgww (envelope-from ); Fri, 04 Aug 2023 09:34:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20c596b0-32aa-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691141676; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A82bLYqaz93UDvSrWKnOK89kLHiJz3SDvPNd6oqJhkE=; b=H3wh3pQXiChcTRJeSC/yDJxLqbos6gFPCJwO/EIyysjOLARGrqnUxYAD0sevi9P/ZRjwpF 1JlgPCK5HuA2Q154Q7xlvDuDx88aWAeaJ4ixc5r+jSMhZxgXQrpNN5VEQikgjsoQxbY1Hc twqeN+Jzh4lW0QJwTARVhjy+JdIL+NE= Message-ID: Date: Fri, 4 Aug 2023 11:34:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------wBl4XspPGxdVBxCVMQxYoWXl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------wBl4XspPGxdVBxCVMQxYoWXl Content-Type: multipart/mixed; boundary="------------8s0ihwnIigIEkLv0llY3wiHr"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> In-Reply-To: --------------8s0ihwnIigIEkLv0llY3wiHr Content-Type: multipart/mixed; boundary="------------OgudeLWwb2kPZEqUPTdWYkY3" --------------OgudeLWwb2kPZEqUPTdWYkY3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjMgMTE6MjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAwNC8wOC8yMDIzIDEwOjE3LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDMuMDgu MjMgMjM6MzYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSwNCj4+Pg0KPj4+IE9uIDI0 LzA3LzIwMjMgMTI6MDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+IGRpZmYgLS1naXQg YS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYyANCj4+Pj4gYi90b29scy94ZW5z dG9yZS94ZW5zdG9yZWRfd2F0Y2guYw0KPj4+PiBpbmRleCA4NmNmODMyMmI0Li4yNjYyYTNm YTQ5IDEwMDY0NA0KPj4+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2gu Yw0KPj4+PiArKysgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYw0KPj4+PiBA QCAtMTY2LDE5ICsxNjYsMTIgQEAgc3RhdGljIGludCBkZXN0cm95X3dhdGNoKHZvaWQgKl93 YXRjaCkNCj4+Pj4gwqAgc3RhdGljIGludCBjaGVja193YXRjaF9wYXRoKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsDQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgY29uc3QgY2hhciAqKnBhdGgsIGJvb2wgKnJlbGF0aXZlKQ0K Pj4+PiDCoCB7DQo+Pj4+IC3CoMKgwqAgLyogQ2hlY2sgaWYgdmFsaWQgZXZlbnQuICovDQo+ Pj4+IC3CoMKgwqAgaWYgKHN0cnN0YXJ0cygqcGF0aCwgIkAiKSkgew0KPj4+PiAtwqDCoMKg wqDCoMKgwqAgKnJlbGF0aXZlID0gZmFsc2U7DQo+Pj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAo c3RybGVuKCpwYXRoKSA+IFhFTlNUT1JFX1JFTF9QQVRIX01BWCkNCj4+Pj4gLcKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgZ290byBpbnZhbDsNCj4+Pg0KPj4+IEkgY2FuJ3QgZmluZCBhbiBl eGFjdCBtYXRjaGluZyBjaGVjayBpbiBpc192YWxpZF9ub2RlbmFtZSgpLiBUaGUgY2FsbCBh bHNvIA0KPj4+IHNlZW1zIHRvIHB1dCBtb3JlIHJlc3RyaWN0aW9uIG9uICdAJyBub2RlLiBD YW4geW91IGNsYXJpZnk/DQo+Pg0KPj4gVGhlIGNhbGwgb2YgZG9tYWluX21heF9jaGsoKSBp biBpc192YWxpZF9ub2RlbmFtZSgpIHdpbGwgY2hlY2sgdGhlIGxlbmd0aA0KPj4gb2YgdGhl IG5vZGUgbmFtZSAoYXQgbGVhc3QgZm9yIHVucHJpdmlsZWdlZCBjYWxsZXJzLCB3aGljaCBp cyB0aGUgaW1wb3J0YW50DQo+PiBjYXNlKS4NCj4gDQo+IFJpZ2h0LCBidXQgZnJvbSBteSB1 bmRlcnN0YW5kaW5nLCB0aGlzIG1heSBub3QgY2hlY2sgYWdhaW5zdCANCj4gWEVOU1RPUkVf UkVMX1BBVEhfTUFYIGJ1dCB3aGF0ZXZlciBsaW1pdCB0aGUgdXNlciBzZXQuDQoNClllcywg YW5kIHRoYXQncyB3aGF0IHNob3VsZCBiZSB0ZXN0ZWQsIHJpZ2h0PyBJIGRvbid0IHNlZSB3 aHkgc3BlY2lhbCBub2Rlcw0Kc2hvdWxkIG5vdCBhZGhlcmUgdG8gdGhlIHNhbWUgbGltaXRz IGFzIG90aGVyIG5vZGVzLiBJbiBjYXNlIGFuIHVucHJpdmlsZWdlZA0KdXNlciBzaG91bGQg aGF2ZSBhY2Nlc3MgdG8gc3BlY2lhbCBub2RlcywgdGhlIGxpbWl0cyBzaG91bGRuJ3QgaGlu ZGVyIHRoZQ0KdXNlciB0byBhY2Nlc3MgdGhvc2Ugbm9kZXMgKHNldHRpbmcgYSBsaW1pdCBi ZWxvdyAxNSB3b3VsZCBiZSByaWRpY3Vsb3VzDQphbnl3YXksIGFuZCB0aGF0IGlzIHRoZSBs ZW5ndGggb2YgbG9uZ2VzdCBzcGVjaWFsIG5vZGUgbmFtZSB0b2RheSkuDQoNCj4gVGhpcyBp cyBhIGNoYW5nZSBvZiBiZWhhdmlvciB0aGF0IHlvdSBvdWdodCB0byBiZSBleHBsYWluZWQu DQo+IA0KPj4NCj4+IFRoZSBhZGRpdGlvbmFsIHJlc3RyaWN0aW9ucyBmb3Igc3BlY2lhbCBu b2RlcyBhcmU6DQo+Pg0KPj4gLSB0aGV5IGNhbid0IGVuZCB3aXRoICIvIg0KPj4gLSB0aGV5 IGNhbid0IGNvbnRhaW4gIi8vIg0KPj4gLSB0aGV5IGNhbid0IGNvbnRhaW4gY2hhcmFjdGVy cyBvdGhlciB0aGFuIHRoZSBvbmVzIGFsbG93ZWQgZm9yIG5vcm1hbCBub2Rlcw0KPj4NCj4+ IE5vbmUgb2YgdGhvc2UgcmVzdHJpY3Rpb25zIGFyZSBwcm9ibGVtYXRpYy4gSSBjYW4gYWRk IHNvbWV0aGluZyB0byB0aGUNCj4+IGNvbW1pdCBtZXNzYWdlIGlmIHlvdSB3YW50Lg0KPiAN Cj4gWWVzIHBsZWFzZS4NCg0KSnVlcmdlbg0KDQo= --------------OgudeLWwb2kPZEqUPTdWYkY3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------OgudeLWwb2kPZEqUPTdWYkY3-- --------------8s0ihwnIigIEkLv0llY3wiHr-- --------------wBl4XspPGxdVBxCVMQxYoWXl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTMxiwFAwAAAAAACgkQsN6d1ii/Ey+P Jgf+I9lnIFNC6LtcamtZDQjCtMnCo/A1rLm9c6w6MahURiCfIgJPTWK34Yct5tUh8R3Lm3zRKiJc v951iUKNufkJGvPuosp0hCJnXrWpJ0/oTT/Sh8LPGUjCxlIq4nfOE443sot9HHQ02xQIuesPUAjz 6/TbIUNge2adDhu50I33JOBLjE1Uz6fgGKK2CmauOj6PO1eAFYFsE2SAr8uJPqIdnF3QszKGReU4 fZTDeK0euZC2ZVmLpZDkU3c1FrhPs4ZS4Ob/wCNPV7M3NA4sJaR++BVip3+aRVOmFC25aDKSvtS1 KxMMRoLHLvO9NV9QW4un2+sbRAaLOma60EgdyJmfzg== =FYC/ -----END PGP SIGNATURE----- --------------wBl4XspPGxdVBxCVMQxYoWXl-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:35:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:35:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577029.903828 (Exim 4.92) (envelope-from ) id 1qRrDE-0006vi-D5; Fri, 04 Aug 2023 09:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577029.903828; Fri, 04 Aug 2023 09:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrDE-0006vb-AY; Fri, 04 Aug 2023 09:35:12 +0000 Received: by outflank-mailman (input) for mailman id 577029; Fri, 04 Aug 2023 09:35:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrDC-0006Nv-5a for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:35:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33418d94-32aa-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 11:35:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 02A6121850; Fri, 4 Aug 2023 09:35:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CA9A613904; Fri, 4 Aug 2023 09:35:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fhTQL0vGzGTiGgAAMHmgww (envelope-from ); Fri, 04 Aug 2023 09:35:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33418d94-32aa-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691141708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w7LLnOp8LCthZbY696Byjs4KFF/n5P3CrUO7UZIttrU=; b=Gp/pROm+/dKAhCOylqHdW9J8GJ2JgVIZ9b+e+ymcIKHXQRBooV1vHDk+flluSRebowQCAU Den/CEnvaV9FQwSx6co5HoVaE2pUpEeVYCRiowb71LFpZIIpoadipdmdTFzlvVpdZgMzHp cUU+sv3ygol6jN7Smu2KuM+jh3TdKlA= Message-ID: <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> Date: Fri, 4 Aug 2023 11:35:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------MSBXNsa07h0I5Zi0x2e2rg42" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------MSBXNsa07h0I5Zi0x2e2rg42 Content-Type: multipart/mixed; boundary="------------GqtWKLDOehE7LWmdWF8ZYshW"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> In-Reply-To: --------------GqtWKLDOehE7LWmdWF8ZYshW Content-Type: multipart/mixed; boundary="------------lovGiV5xcwSCiRO9WbGhT5zC" --------------lovGiV5xcwSCiRO9WbGhT5zC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMuMDguMjMgMjM6NDYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAyNC8wNy8yMDIzIDEyOjAyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gVG9kYXkgaXNf dmFsaWRfbm9kZW5hbWUoKSBpcyBhbHdheXMgY2FsbGVkIGRpcmVjdGx5IGFmdGVyIGNhbGxp bmcNCj4+IGNhbm9uaWNhbGl6ZSgpLCB3aXRoIHRoZSBleGNlcHRpb24gb2YgZG9fdW53YXRj aCgpLCB3aGVyZSB0aGUgY2FsbA0KPj4gaXMgbWlzc2luZyAod2hpY2ggaXMgbm90IGNvcnJl Y3QsIGJ1dCByZXN1bHRzIGp1c3QgaW4gYSB3cm9uZyBlcnJvcg0KPj4gcmVhc29uIGJlaW5n IHJldHVybmVkKS4NCj4gDQo+IFdoaWxlIHRoaXMgY2hhbmdlIG1ha2VzIHNlbnNlLi4uDQo+ IA0KPj4NCj4+IE1lcmdlIGlzX3ZhbGlkX25vZGVuYW1lKCkgaW50byBjYW5vbmljYWxpemUo KS4gV2hpbGUgYXQgaXQgbWVyZ2UNCj4+IHZhbGlkX2NoYXJzKCkgaW50byBpdCwgdG9vLg0K PiANCj4gLi4uIEkgYW0gbm90IGluIGZhdm9yIG9mIGZvbGRpbmcgdGhlIGNvZGUgaXNfdmFs aWRfbm9kZW5hbWUoKSBhbmQgdmFsaWRfY2hhcnMoKSANCj4gaW50byBjYW5vbmljYWxpemUo KSBiZWNhdXNlIHRoZSBjb2RlIGlzIG5vdyBtb3JlIGRpZmZpY3VsdCB0byByZWFkLiBBbHNv LCB0aGUgDQo+IGtlZXBpbmcgdGhlIHNwbGl0IHdvdWxkIGFsbG93IHRvIGZyZWUgdGhlICdu YW1lJyBpbiBjYXNlIG9mIGFuIGVycm9yIHdpdGhvdXQgDQo+IGFkZGluZyB0b28gbXVjaCBn b3RvIGluIHRoZSBjb2RlLg0KDQpJIGRvbid0IHRoaW5rIHdlIGNhbiBlYXNpbHkgZnJlZSBu YW1lIGluIGFuIGVycm9yIGNhc2UsIGF0IHRoYXQgd291bGQgcmVxdWlyZQ0KdG8ga2VlcCBr bm93bGVkZ2UgdGhhdCBuYW1lIHdhcyBqdXN0IGFsbG9jYXRlZCBpbiB0aGUgbm9uLWNhbm9u aWNhbCBjYXNlLg0KDQo+IA0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gVjM6DQo+PiAtIG5ldyBwYXRjaA0KPj4g LS0tDQo+PiDCoCB0b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfY29yZS5jwqAgfCA4OSArKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVu c3RvcmVkX2NvcmUuaMKgIHzCoCA2ICstLQ0KPj4gwqAgdG9vbHMveGVuc3RvcmUveGVuc3Rv cmVkX3dhdGNoLmMgfCAxNiArKy0tLS0NCj4+IMKgIDMgZmlsZXMgY2hhbmdlZCwgNDUgaW5z ZXJ0aW9ucygrKSwgNjYgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF9jb3JlLmMgYi90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRf Y29yZS5jDQo+PiBpbmRleCBlYTVhMWE5Y2NlLi5lYzIwYmMwNDJkIDEwMDY0NA0KPj4gLS0t IGEvdG9vbHMveGVuc3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4gKysrIGIvdG9vbHMveGVu c3RvcmUveGVuc3RvcmVkX2NvcmUuYw0KPj4gQEAgLTEyMTAsNDIgKzEyMTAsNiBAQCB2b2lk IHNlbmRfYWNrKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBlbnVtIA0KPj4geHNkX3NvY2tt c2dfdHlwZSB0eXBlKQ0KPj4gwqDCoMKgwqDCoCBzZW5kX3JlcGx5KGNvbm4sIHR5cGUsICJP SyIsIHNpemVvZigiT0siKSk7DQo+PiDCoCB9DQo+PiAtc3RhdGljIGJvb2wgdmFsaWRfY2hh cnMoY29uc3QgY2hhciAqbm9kZSkNCj4+IC17DQo+PiAtwqDCoMKgIC8qIE5vZGVzIGNhbiBo YXZlIGxvdHMgb2YgY3JhcC4gKi8NCj4+IC3CoMKgwqAgcmV0dXJuIChzdHJzcG4obm9kZSwN Cj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICJBQkNERUZHSElKS0xNTk9QUVJT VFVWV1hZWiINCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICJhYmNkZWZnaGlq a2xtbm9wcXJzdHV2d3h5eiINCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIw MTIzNDU2Nzg5LS9fQCIpID09IHN0cmxlbihub2RlKSk7DQo+PiAtfQ0KPj4gLQ0KPj4gLWJv b2wgaXNfdmFsaWRfbm9kZW5hbWUoY29uc3Qgc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNv bnN0IGNoYXIgKm5vZGUsDQo+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBib29s IGFsbG93X3NwZWNpYWwpDQo+PiAtew0KPj4gLcKgwqDCoCBpbnQgbG9jYWxfb2ZmID0gMDsN Cj4+IC3CoMKgwqAgdW5zaWduZWQgaW50IGRvbWlkOw0KPj4gLQ0KPj4gLcKgwqDCoCAvKiBN dXN0IHN0YXJ0IGluIC8gb3IgLSBpZiBzcGVjaWFsIG5vZGVzIGFyZSBhbGxvd2VkIC0gaW4g QC4gKi8NCj4+IC3CoMKgwqAgaWYgKCFzdHJzdGFydHMobm9kZSwgIi8iKSAmJiAoIWFsbG93 X3NwZWNpYWwgfHwgIXN0cnN0YXJ0cyhub2RlLCAiQCIpKSkNCj4+IC3CoMKgwqDCoMKgwqDC oCByZXR1cm4gZmFsc2U7DQo+PiAtDQo+PiAtwqDCoMKgIC8qIENhbm5vdCBlbmQgaW4gLyAo dW5sZXNzIGl0J3MganVzdCAiLyIpLiAqLw0KPj4gLcKgwqDCoCBpZiAoc3RyZW5kcyhub2Rl LCAiLyIpICYmICFzdHJlcShub2RlLCAiLyIpKQ0KPj4gLcKgwqDCoMKgwqDCoMKgIHJldHVy biBmYWxzZTsNCj4+IC0NCj4+IC3CoMKgwqAgLyogTm8gZG91YmxlIC8vLiAqLw0KPj4gLcKg wqDCoCBpZiAoc3Ryc3RyKG5vZGUsICIvLyIpKQ0KPj4gLcKgwqDCoMKgwqDCoMKgIHJldHVy biBmYWxzZTsNCj4+IC0NCj4+IC3CoMKgwqAgaWYgKHNzY2FuZihub2RlLCAiL2xvY2FsL2Rv bWFpbi8lNXUvJW4iLCAmZG9taWQsICZsb2NhbF9vZmYpICE9IDEpDQo+PiAtwqDCoMKgwqDC oMKgwqAgbG9jYWxfb2ZmID0gMDsNCj4+IC0NCj4+IC3CoMKgwqAgaWYgKGRvbWFpbl9tYXhf Y2hrKGNvbm4sIEFDQ19QQVRITEVOLCBzdHJsZW4obm9kZSkgLSBsb2NhbF9vZmYpKQ0KPj4g LcKgwqDCoMKgwqDCoMKgIHJldHVybiBmYWxzZTsNCj4+IC0NCj4+IC3CoMKgwqAgcmV0dXJu IHZhbGlkX2NoYXJzKG5vZGUpOw0KPj4gLX0NCj4+IC0NCj4+IMKgIC8qIFdlIGV4cGVjdCBv bmUgYXJnIGluIHRoZSBpbnB1dDogcmV0dXJuIE5VTEwgb3RoZXJ3aXNlLg0KPj4gwqDCoCAq IFRoZSBwYXlsb2FkIG11c3QgY29udGFpbiBleGFjdGx5IG9uZSBudWwsIGF0IHRoZSBlbmQu DQo+PiDCoMKgICovDQo+PiBAQCAtMTI3OSwxNiArMTI0Myw0NiBAQCBzdGF0aWMgY2hhciAq cGVybXNfdG9fc3RyaW5ncyhjb25zdCB2b2lkICpjdHgsIGNvbnN0IA0KPj4gc3RydWN0IG5v ZGVfcGVybXMgKnBlcm1zLA0KPj4gwqAgfQ0KPj4gwqAgY29uc3QgY2hhciAqY2Fub25pY2Fs aXplKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsDQo+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IGNoYXIgKm5vZGUpDQo+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIGNvbnN0IGNoYXIgKm5vZGUsIGJvb2wgYWxsb3dfc3BlY2lhbCkN Cj4+IMKgIHsNCj4+IC3CoMKgwqAgY29uc3QgY2hhciAqcHJlZml4Ow0KPj4gK8KgwqDCoCBj aGFyICpuYW1lOw0KPj4gK8KgwqDCoCBpbnQgbG9jYWxfb2ZmID0gMDsNCj4+ICvCoMKgwqAg dW5zaWduZWQgaW50IGRvbWlkOw0KPj4gLcKgwqDCoCBpZiAoIW5vZGUgfHwgKG5vZGVbMF0g PT0gJy8nKSB8fCAobm9kZVswXSA9PSAnQCcpKQ0KPj4gLcKgwqDCoMKgwqDCoMKgIHJldHVy biBub2RlOw0KPj4gLcKgwqDCoCBwcmVmaXggPSBnZXRfaW1wbGljaXRfcGF0aChjb25uKTsN Cj4+IC3CoMKgwqAgaWYgKHByZWZpeCkNCj4+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gdGFs bG9jX2FzcHJpbnRmKGN0eCwgIiVzLyVzIiwgcHJlZml4LCBub2RlKTsNCj4+IC3CoMKgwqAg cmV0dXJuIG5vZGU7DQo+PiArwqDCoMKgIGVycm5vID0gRUlOVkFMOw0KPj4gK8KgwqDCoCBp ZiAoIW5vZGUpDQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5VTEw7DQo+PiArDQo+PiAr wqDCoMKgIGlmIChzdHJzcG4obm9kZSwgIkFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaYWJj ZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXoiDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICIwMTIzNDU2Nzg5LS9fQCIpICE9IHN0cmxlbihub2RlKSkNCj4+ICvCoMKgwqDCoMKgwqDC oCByZXR1cm4gTlVMTDsNCj4+ICsNCj4+ICvCoMKgwqAgaWYgKG5vZGVbMF0gPT0gJ0AnICYm ICFhbGxvd19zcGVjaWFsKQ0KPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxMOw0KPj4g Kw0KPj4gK8KgwqDCoCBpZiAobm9kZVswXSAhPSAnLycgJiYgbm9kZVswXSAhPSAnQCcpIHsN Cj4+ICvCoMKgwqDCoMKgwqDCoCBuYW1lID0gdGFsbG9jX2FzcHJpbnRmKGN0eCwgIiVzLyVz IiwgZ2V0X2ltcGxpY2l0X3BhdGgoY29ubiksDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9kZSk7DQo+IA0KPiBUaGlzIGlzIGFsbG9jYXRl ZCBidXQgbm90IGZyZWVkIG9uIGVycm9yLiBJIHVuZGVyc3RhbmQgdGhpcyBpcyBwYXJ0IG9m IHRoZSANCj4gJ2N0eHQnIGFuZCB0aGVyZWZvcmUgd2lsbCBiZSBmcmVlIGxhdGVyIG9uLiBC dXQgdGhpcyBtZWFucyB0ZW1wb3JhcnkgbWVtb3J5IHdpbGwgDQo+IGJlIGFsbG9jYXRlZCBm b3IgbG9uZ2VyLiBTbyBiZXN0IHRvIGNsZWFuLXVwIHdoZW4geW91IGNhbi4NCg0KUmVhbGx5 Pw0KDQpJdCBpcyBwb3NzaWJsZSwgb2YgY291cnNlLCBidXQgaXQgaXMgYWRkaW5nIG1vcmUg Y29kZSBjaHVybi4gUmVtZW1iZXIgdGhhdA0KIm5hbWUiIGlzIGFsbG9jYXRlZCBvbmx5IGlu IGNhc2Ugb2YgYSByZWxhdGl2ZSBwYXRoLCBzbyBmcmVlaW5nIGl0IG5lZWRzDQp0byBiZSBj b25kaXRpb25hbCwgdG9vICh5ZXMsIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHZpYSBjb21wYXJp bmcgbmFtZSB0byBub2RlKS4NCg0KSW4gY2FzZSB5b3Ugd2FudCBtZSB0byBnbyB0aGlzIHJv dXRlLCBJIGNhbiByZWFycmFuZ2UgdGhlIGNvZGUgaW4gb3JkZXIgdG8NCmF2b2lkIG11bHRp cGxlIGVycm9yIGV4aXRzIGJ5IGhhdmluZyBvbmx5IG9uZSBsYXJnZSBpZiAoKSB0ZXN0aW5n IGZvciBhbGwNCnBvc3NpYmxlIHZpb2xhdGlvbnMuDQoNCj4gDQo+PiArwqDCoMKgwqDCoMKg wqAgaWYgKCFuYW1lKQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIE5VTEw7 DQo+PiArwqDCoMKgIH0gZWxzZQ0KPj4gK8KgwqDCoMKgwqDCoMKgIG5hbWUgPSAoY2hhciAq KW5vZGU7DQo+IA0KPiBXaHkgZG9lcyBuYW1lIG5lZWQgdG8gYmUgY29uc3Q/DQoNCkkgdGhp bmsgdGhlIHF1ZXN0aW9uIHdhcyBwb3NlZCBpbiBhIHdyb25nIHdheS4gOi0pDQoNCkknbGwg Y2hhbmdlIG5hbWUgdG8gYmUgY29uc3QgY2hhciAqLg0KDQoNCkp1ZXJnZW4NCg0K --------------lovGiV5xcwSCiRO9WbGhT5zC Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------lovGiV5xcwSCiRO9WbGhT5zC-- --------------GqtWKLDOehE7LWmdWF8ZYshW-- --------------MSBXNsa07h0I5Zi0x2e2rg42 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTMxksFAwAAAAAACgkQsN6d1ii/Ey/K rwf/YVlysIoK7vmG25Q4w5hor18SofMcxfmWcHGB/uikDke82b56ZnvvUQ1t50LeZBIpfrJBqXlT Z0aw9yaVCjpDa3HMTttx17UpiCqiKIoOVR/mJv2WIwmUWgLU4uK9ZQCwPHogiSH5DJI/eqYudggr EkdOM2Yq8Cpzl2xc1cBGYIY9ee6j7TfdvkWpCSy9CUvWylEt81+dcduR8i1G5kWoM1Dl4j8YE25v EBjtpO7wjAH4X/ExBImw4tLF/zI14pkMNGo65uB6ourwC7N0IcG7w7mbXUzHqQB/U4bvqMx716Mc LMP0Wx35Ip6rV/2WLdzG5eQGfIIfKiB3PzRDDpc7ww== =mtdd -----END PGP SIGNATURE----- --------------MSBXNsa07h0I5Zi0x2e2rg42-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:38:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:38:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577035.903839 (Exim 4.92) (envelope-from ) id 1qRrGd-0007aV-UC; Fri, 04 Aug 2023 09:38:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577035.903839; Fri, 04 Aug 2023 09:38:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrGd-0007aO-QU; Fri, 04 Aug 2023 09:38:43 +0000 Received: by outflank-mailman (input) for mailman id 577035; Fri, 04 Aug 2023 09:38:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrGd-0007aI-AQ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:38:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2c867a7-32aa-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:38:42 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 5F7C54EE0737; Fri, 4 Aug 2023 11:38:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2c867a7-32aa-11ee-b26b-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Fri, 4 Aug 2023 11:38:35 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional changes. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/mm.h | 20 ++++++++++---------- xen/arch/x86/mm.c | 33 ++++++++++++++++++--------------- 2 files changed, 28 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index db29e3e205..1e2d8c1a65 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -408,7 +408,7 @@ void put_page_type(struct page_info *page); int get_page_type(struct page_info *page, unsigned long type); int put_page_type_preemptible(struct page_info *page); int get_page_type_preemptible(struct page_info *page, unsigned long type); -int put_old_guest_table(struct vcpu *); +int put_old_guest_table(struct vcpu *v); int get_page_from_l1e( l1_pgentry_t l1e, struct domain *l1e_owner, struct domain *pg_owner); void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner); @@ -559,7 +559,7 @@ void audit_domains(void); void make_cr3(struct vcpu *v, mfn_t mfn); void update_cr3(struct vcpu *v); -int vcpu_destroy_pagetables(struct vcpu *); +int vcpu_destroy_pagetables(struct vcpu *v); void *do_page_walk(struct vcpu *v, unsigned long addr); /* Allocator functions for Xen pagetables. */ @@ -574,20 +574,20 @@ int __sync_local_execstate(void); /* Arch-specific portion of memory_op hypercall. */ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); -int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void)); -int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void)); +int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); +int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); #define NIL(type) ((type *)-sizeof(type)) #define IS_NIL(ptr) (!((uintptr_t)(ptr) + sizeof(*(ptr)))) -int create_perdomain_mapping(struct domain *, unsigned long va, - unsigned int nr, l1_pgentry_t **, - struct page_info **); -void destroy_perdomain_mapping(struct domain *, unsigned long va, +int create_perdomain_mapping(struct domain *d, unsigned long va, + unsigned int nr, l1_pgentry_t **pl1tab, + struct page_info **ppg); +void destroy_perdomain_mapping(struct domain *d, unsigned long va, unsigned int nr); -void free_perdomain_mappings(struct domain *); +void free_perdomain_mappings(struct domain *d); -void __iomem *ioremap_wc(paddr_t, size_t); +void __iomem *ioremap_wc(paddr_t pa, size_t len); extern int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm); diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index be2b10a391..e1d9b94007 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -5591,7 +5591,7 @@ int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) * * It is an error to call with present flags over an unpopulated range. */ -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) { bool locking = system_state > SYS_STATE_boot; l3_pgentry_t *pl3e = NULL; @@ -5604,7 +5604,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) /* Set of valid PTE bits which may be altered. */ #define FLAGS_MASK (_PAGE_NX|_PAGE_DIRTY|_PAGE_ACCESSED|_PAGE_RW|_PAGE_PRESENT) - nf &= FLAGS_MASK; + flags &= FLAGS_MASK; ASSERT(IS_ALIGNED(s, PAGE_SIZE)); ASSERT(IS_ALIGNED(e, PAGE_SIZE)); @@ -5628,7 +5628,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) if ( !(l3e_get_flags(*pl3e) & _PAGE_PRESENT) ) { /* Confirm the caller isn't trying to create new mappings. */ - ASSERT(!(nf & _PAGE_PRESENT)); + ASSERT(!(flags & _PAGE_PRESENT)); v += 1UL << L3_PAGETABLE_SHIFT; v &= ~((1UL << L3_PAGETABLE_SHIFT) - 1); @@ -5645,9 +5645,10 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) ((e - v) >= (1UL << L3_PAGETABLE_SHIFT)) ) { /* PAGE1GB: whole superpage is modified. */ - l3_pgentry_t nl3e = !(nf & _PAGE_PRESENT) ? l3e_empty() + l3_pgentry_t nl3e = !(flags & _PAGE_PRESENT) ? l3e_empty() : l3e_from_pfn(l3e_get_pfn(*pl3e), - (l3e_get_flags(*pl3e) & ~FLAGS_MASK) | nf); + (l3e_get_flags(*pl3e) & ~FLAGS_MASK) | + flags); l3e_write_atomic(pl3e, nl3e); v += 1UL << L3_PAGETABLE_SHIFT; @@ -5691,7 +5692,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) if ( !(l2e_get_flags(*pl2e) & _PAGE_PRESENT) ) { /* Confirm the caller isn't trying to create new mappings. */ - ASSERT(!(nf & _PAGE_PRESENT)); + ASSERT(!(flags & _PAGE_PRESENT)); v += 1UL << L2_PAGETABLE_SHIFT; v &= ~((1UL << L2_PAGETABLE_SHIFT) - 1); @@ -5704,9 +5705,10 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) ((e-v) >= (1UL << L2_PAGETABLE_SHIFT)) ) { /* PSE: whole superpage is modified. */ - l2_pgentry_t nl2e = !(nf & _PAGE_PRESENT) ? l2e_empty() + l2_pgentry_t nl2e = !(flags & _PAGE_PRESENT) ? l2e_empty() : l2e_from_pfn(l2e_get_pfn(*pl2e), - (l2e_get_flags(*pl2e) & ~FLAGS_MASK) | nf); + (l2e_get_flags(*pl2e) & ~FLAGS_MASK) | + flags); l2e_write_atomic(pl2e, nl2e); v += 1UL << L2_PAGETABLE_SHIFT; @@ -5756,11 +5758,11 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) /* Confirm the caller isn't trying to create new mappings. */ if ( !(l1e_get_flags(*pl1e) & _PAGE_PRESENT) ) - ASSERT(!(nf & _PAGE_PRESENT)); + ASSERT(!(flags & _PAGE_PRESENT)); - nl1e = !(nf & _PAGE_PRESENT) ? l1e_empty() + nl1e = !(flags & _PAGE_PRESENT) ? l1e_empty() : l1e_from_pfn(l1e_get_pfn(*pl1e), - (l1e_get_flags(*pl1e) & ~FLAGS_MASK) | nf); + (l1e_get_flags(*pl1e) & ~FLAGS_MASK) | flags); l1e_write_atomic(pl1e, nl1e); UNMAP_DOMAIN_PAGE(pl1e); @@ -5770,7 +5772,8 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) * If we are not destroying mappings, or not done with the L2E, * skip the empty&free check. */ - if ( (nf & _PAGE_PRESENT) || ((v != e) && (l1_table_offset(v) != 0)) ) + if ( (flags & _PAGE_PRESENT) || + ((v != e) && (l1_table_offset(v) != 0)) ) continue; if ( locking ) spin_lock(&map_pgdir_lock); @@ -5817,7 +5820,7 @@ int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) * If we are not destroying mappings, or not done with the L3E, * skip the empty&free check. */ - if ( (nf & _PAGE_PRESENT) || + if ( (flags & _PAGE_PRESENT) || ((v != e) && (l2_table_offset(v) + l1_table_offset(v) != 0)) ) continue; if ( locking ) @@ -5892,14 +5895,14 @@ int destroy_xen_mappings(unsigned long s, unsigned long e) * a problem. */ void init_or_livepatch modify_xen_mappings_lite( - unsigned long s, unsigned long e, unsigned int _nf) + unsigned long s, unsigned long e, unsigned int flags) { unsigned long v = s, fm, nf; /* Set of valid PTE bits which may be altered. */ #define FLAGS_MASK (_PAGE_NX|_PAGE_DIRTY|_PAGE_ACCESSED|_PAGE_RW|_PAGE_PRESENT) fm = put_pte_flags(FLAGS_MASK); - nf = put_pte_flags(_nf & FLAGS_MASK); + nf = put_pte_flags(flags & FLAGS_MASK); #undef FLAGS_MASK ASSERT(nf & _PAGE_PRESENT); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:44:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:44:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577041.903849 (Exim 4.92) (envelope-from ) id 1qRrMM-0000fj-NW; Fri, 04 Aug 2023 09:44:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577041.903849; Fri, 04 Aug 2023 09:44:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrMM-0000fc-Kp; Fri, 04 Aug 2023 09:44:38 +0000 Received: by outflank-mailman (input) for mailman id 577041; Fri, 04 Aug 2023 09:44:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrML-0000fV-K0 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:44:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrMK-0006ka-GS; Fri, 04 Aug 2023 09:44:36 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRrMK-0006ak-AC; Fri, 04 Aug 2023 09:44:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=NCJ1b1+wHISTkZB52wYXr5NBVE0+9hyIcRHv9sK+iKQ=; b=kFZwfE0if/mnqhU4ya97A2ECax disjQKlufw2z/Xr8SzRvrEovfJb4d1zNZ4F4YhCe1Ns9OfO6u8V9JO5R1w6h7fpv/cBZwGw5+yvnY cpQVGL+PrlpcPEqM2CAy6BqyxGEkDmEfJx/Jm0g5A4HkTx3YWGMpwo6NqYKoZZUpNM64=; Message-ID: Date: Fri, 4 Aug 2023 10:44:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/08/2023 10:34, Juergen Gross wrote: > On 04.08.23 11:21, Julien Grall wrote: >> Hi, >> >> On 04/08/2023 10:17, Juergen Gross wrote: >>> On 03.08.23 23:36, Julien Grall wrote: >>>> Hi, >>>> >>>> On 24/07/2023 12:02, Juergen Gross wrote: >>>>> diff --git a/tools/xenstore/xenstored_watch.c >>>>> b/tools/xenstore/xenstored_watch.c >>>>> index 86cf8322b4..2662a3fa49 100644 >>>>> --- a/tools/xenstore/xenstored_watch.c >>>>> +++ b/tools/xenstore/xenstored_watch.c >>>>> @@ -166,19 +166,12 @@ static int destroy_watch(void *_watch) >>>>>   static int check_watch_path(struct connection *conn, const void >>>>> *ctx, >>>>>                   const char **path, bool *relative) >>>>>   { >>>>> -    /* Check if valid event. */ >>>>> -    if (strstarts(*path, "@")) { >>>>> -        *relative = false; >>>>> -        if (strlen(*path) > XENSTORE_REL_PATH_MAX) >>>>> -            goto inval; >>>> >>>> I can't find an exact matching check in is_valid_nodename(). The >>>> call also seems to put more restriction on '@' node. Can you clarify? >>> >>> The call of domain_max_chk() in is_valid_nodename() will check the >>> length >>> of the node name (at least for unprivileged callers, which is the >>> important >>> case). >> >> Right, but from my understanding, this may not check against >> XENSTORE_REL_PATH_MAX but whatever limit the user set. > > Yes, and that's what should be tested, right? I don't see why special nodes > should not adhere to the same limits as other nodes. In case an > unprivileged > user should have access to special nodes, the limits shouldn't hinder the > user to access those nodes (setting a limit below 15 would be ridiculous > anyway, and that is the length of longest special node name today). I don't mind you want to test against a different value. My point is more that you didn't mention that the limit will be changed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:47:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:47:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577044.903859 (Exim 4.92) (envelope-from ) id 1qRrOl-0001Gn-4D; Fri, 04 Aug 2023 09:47:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577044.903859; Fri, 04 Aug 2023 09:47:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrOl-0001Gg-16; Fri, 04 Aug 2023 09:47:07 +0000 Received: by outflank-mailman (input) for mailman id 577044; Fri, 04 Aug 2023 09:47:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrOj-0001GZ-JU for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:47:05 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id de4f5510-32ab-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:47:04 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 40B994EE0737; Fri, 4 Aug 2023 11:47:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de4f5510-32ab-11ee-b26b-6b7b168915f2 MIME-Version: 1.0 Date: Fri, 04 Aug 2023 11:47:04 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Jan Beulich , Andrew Cooper , Julien Grall , George Dunlap , Wei Liu Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <00fb1a58849ec08534465df2f8ca2284@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/08/2023 02:35, Stefano Stabellini wrote: > I think that's OK for me. My only concern is that we should track the > project-wide deviations properly somewhere besides the ECLAIR > configuration under xen.git which is ECLAIR specific. So far we used > the > notes in docs/misra/rules.rst. I don't know if that sufficient, but we > could add a note for 8.4: > > diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst > index 8f0e4d3f25..5977bc9d5e 100644 > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -245,7 +245,8 @@ maintainers if you want to suggest a change. > - Required > - A compatible declaration shall be visible when an object or > function with external linkage is defined > - - > + - No need for declarations when functions are only called from > + assembly > > * - `Rule 8.5 > `_ > - Required > > > On Thu, 3 Aug 2023, Nicola Vetrini wrote: >> The headline of Rule 8.4 is as follows: >> "A compatible declaration shall be visible when an object or >> function with external linkage is defined". >> >> Some functions reported in [1][2] are lacking a declaration in the >> respective >> header files; >> as remarked on xen-devel's IRC channel, this is ok since they are only >> called >> from asm code (e.g., start_xen). A similar discussion >> had taken place in the past (see [3]) and the general consensus was to >> deviate >> these cases. >> If that is still the case, a suitable project-wide deviation can be >> added to >> address these violations. >> >> [1] >> https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html >> [2] >> https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/210/PROJECT.ecd;/by_service/MC3R1.R8.4.html >> [3] >> https://lore.kernel.org/all/20220705210218.483854-2-burzalodowa@gmail.com/ >> Upon further examination, I identified the following patterns: 1. Functions defined in .c called only from asm code (e.g., the already mentioned __start_xen) 2. Functions/variables declared in a .h, defined in a .c that does not include the .h with the declaration (e.g., 'fill_console_start_info' is defined in 'xen/drivers/vga.c', declared in 'xen/include/xen/console.h' which is not visible when compiling the .c). 3. Variables that are either extern or not, such as 'acpi_gbl_FADT' in 'xen/include/acpi/acglobal.h', depending on DEFINE_ACPI_GLOBALS Below are the proposed resolution strategies: 1. I would advise to add the declaration in the relative .h, to support automatic consistency checks with the implementation and a quick reference when touching the asm. 2. To comply with the rule, the header with the declaration should be included. Also note that there are some corner cases, such as 'get_sec', which is used in 'cper.h' without including 'time.h' (which should gain a declaration for it). 3. One possible resolution pattern is including 'acglobal.h' twice (either directly or indirectly trough acpi.h, if the latter does not cause other issues) like so: (assuming DEFINE_ACPI_GLOBALS is undefined here) #include "acglobal.h" #define DEFINE_ACPI_GLOBALS #include "acglobal.h" this way, the rule is followed properly, though it's not the prettiest pattern and also clashes with the objectives of D4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"), but then a motivated exception is allowed there. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:47:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:47:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577049.903869 (Exim 4.92) (envelope-from ) id 1qRrPa-0001pl-E8; Fri, 04 Aug 2023 09:47:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577049.903869; Fri, 04 Aug 2023 09:47:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrPa-0001pe-BC; Fri, 04 Aug 2023 09:47:58 +0000 Received: by outflank-mailman (input) for mailman id 577049; Fri, 04 Aug 2023 09:47:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrPY-0001GZ-TG for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:47:56 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb9378ea-32ab-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:47:55 +0200 (CEST) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Aug 2023 05:47:50 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6484.namprd03.prod.outlook.com (2603:10b6:806:1c3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 09:47:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Fri, 4 Aug 2023 09:47:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb9378ea-32ab-11ee-b26b-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691142475; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=LlozT63uJQfEEKd2bN/UL5TpghzcwSID1/2QYhUx/EM=; b=GTMyPqZ2IVIjDXrpUczrDlBpEIY1S9WgXApB7ZKMmfVO1PaMqx45R8tp bVquRCLwjCthd9cuiewHH6tejHAqpaKq2vyg1vOr2jlimzupBsu3jEhw/ Ed1AJh/M2uRekP7dn9YqB2TqWvdVMlYzAZ2hOFQRklBpTQiScKYy8cQWn o=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 121140978 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Xr6hH6+vzBnkYqHdNu2RDrUDWn+TJUtcMsCJ2f8bNWPcYEJGY0x3z TQcCDuEa/iONmCnLYojYdvj8kwF7ZGGyYVrTAJppXg8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks21BjOkGlA5AdmNagX5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklj7 v07LRQMVSqpoLqR/oiVddNqn9gseZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUuiNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdhLTeHgp6E66LGV7nQJEjokBAu3mtuG2hShV4xwM 04f6gN7+MDe82TuFLERRSaQrnOIswQdUN0WCOAg4Q+MzKv86RuWHWUCQXhKb9lOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqbigCVhYB/9jlr6k5kx3UQ9BsVqWyi7XdGzv93 jSLpygWnKgIgIgA0KDT1U/DqyKhoN7OVAFd2+nMdmes7wc8aIv7YYWtsALf9awZc97fSUSdt n8ZncTY9PoJEZyGiC2KRqMKAa2t4PGGdjbbhDaDAqUcythkwFb7Fag43d20DB4B3hosEdMxX HLuhA== IronPort-HdrOrdr: A9a23:JhlGR6rm8rbQmxH7LLN9GjgaV5ooeYIsimQD101hICG9E/bo9P xG+c5x6faaslwssQ4b6Le90cW7LU80jKQFhbX5Xo3DYOCFggaVxehZhOPfK1eKIVyaygc678 hdmsNFaeEYY2IVsS6WizPIceod/A== X-Talos-CUID: 9a23:z+s4NGFm5Bys2RmoqmJK7083H+QkSUf36y/3HXWWNlxvUaGaHAo= X-Talos-MUID: 9a23:mHmtHwaEFRLbMeBTryX2owMzZMtTwZv+Ul8Bz7oeucKUHHkl X-IronPort-AV: E=Sophos;i="6.01,254,1684814400"; d="scan'208";a="121140978" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqg8IsBbSeyCIjOiZV5aNqnkXAlfz08ZHHZB+rSBGFP0jT1JBZ+w++wgGOXQ9Mu/t5ydidvFgROBEW94SyMquqcGHOMRhmEkLPyVHbTiJBNxneRGmjOuZSe+CUhbSs/pHoADNX27G2l76TBS3KEhbB776zoYUeHX7p2LwWbL5anIe20vCDTd/4/Nt1VqN/BdEvLluLIn59b2ZeqqzMk4tf9aUTfYk5oOhWGWyuhPUqHUfllkS5L2XxsbfxEkVTycAXdI2l3OeRwOQaXO9mDXvA7b8FHNJS5qkYI3Rz2Fwf6Oay2b9DYlPwnMVY7Gdi1qo1ymlE5kNZ11D7L4/aiiaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m42IxxKuaIjFxMFD8EVIAdcRbjt+Je7k+U+X6RhFZRI=; b=e7VQ9v251Y914KzdekwRqZMrbvnsz6K+zJzyEHt+CVGPFdbssXPsSZsIMqJKWQLu+XSOO4XqpVf9EzGoudLoRWz7PBiiI/OERED4qbLrohIxMwg4kxCW1AHJKtc96jCW0q6hMYXbaCp5NAajkyHw0/D/Xa6xJECx9FjROmRugWwtTeWl9Co6DQeRQiUWYo3YOFpbuYHktM2mrcu68tSd2zJ74+RJQZIEFxJeOonuxAGTA/oRcIqFH3isqwqW8LhQd0t93MltbWf2zw659rfQdsUO+JG1ho/7IlbiKGbdsykxxwiHu2zi5Sf982xtM4Nh30EgMzhZZVa/ITzNSsqNOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m42IxxKuaIjFxMFD8EVIAdcRbjt+Je7k+U+X6RhFZRI=; b=AmiwZORx3/xEJPbCQ0kGqG8Jx00pLBXKL8Gw8cXxo95UYF4e+TDCr6RYSM5kVPevTP2s/mMOyc/vZhrR2JXaz6WQUZCAte6zP4U7eGNHnuF5g/X1i4OS0bvNFR8sDsd5vEsb3JQJ4dzZ2J5W3BqBuXXyJGbVEhc+SQ2dVluIIG8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 4 Aug 2023 10:47:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [XEN PATCH v2] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-GB To: Federico Serafini , xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0302.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6484:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e9c2978-0576-450a-c2fd-08db94cfdb9f X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +No06SbrqzhBTdUWeWCp3o3Kxgt/PALLykDX1QSc1egWa2hNHYbZa6yczfKACr84KUARFui5okrXOUzWPIXrtY5S2LiNQs4Y/CNjuvg6vI7ZxGdCVQxBFlaLFn7TLlm4HDm+b0ptwSAgO1iThYMjYUf9Ulvo/yflJeXQtgJ6y0SANnIMhbcdyDbNp8C29eB9j3zX5AhRNDQpNBnh5cX9BqLwnL7L3pfJ0OiAtgEoQ6sWqKQguJ6cm6yyYCqrQ/l+EkuS0kbM25DOjXsYH3O58dxWFCeBEt8hfTK3DUZO0qi+FRIf3FHmt4kF8PlBVfxeo4uwuGt3HAtdiWtgKO1DXmvHNXZjzthMJhJQw0MWd36A34xpjS4XqXQfYf6X6cRBUnB0fDDOXbcGhd471PUxP3sMrBB62Ny+NFrkB8VSbhWCDxf9Cpgf34gZ6ronwPsCHNo6rDO6+OtSBJg1TMcLtwoIqAPqXhNreF+mHO4I3R/S3f219LS3ZsS6Ac4rk1kImVQew8lCaSkCVlL6fVhi+zlEng7aVWKjS1g90E97UOnU342JoF8KJExGsghD9ziAPBM8OojlwiQt4unhzPs1cx0mHFUuHCufbsgtEkI0SU9fOEIUcfd4uBOoCKq2GCXL4NEY+cgnOLJ6ps9KgNsyFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(39860400002)(376002)(396003)(346002)(1800799003)(186006)(451199021)(86362001)(4744005)(2906002)(8936002)(8676002)(31696002)(36756003)(31686004)(6506007)(26005)(53546011)(2616005)(6512007)(6666004)(6486002)(478600001)(54906003)(316002)(41300700001)(5660300002)(4326008)(66556008)(38100700002)(82960400001)(66946007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0JhRnJMM0VvVTk3cFVYLzYwSjJYaWhrWnEzb0U2c1p5aXgyRHpnenNVeWxF?= =?utf-8?B?Yk1oMG95Wjk4bFVUYTFvMnBoSFZuNHV1TzBnMnVUb3pMUWhPK3ZsUW5VN2x1?= =?utf-8?B?ZGh5azNtUmRNekV3RjF5dndtSXIwSTdJdnV0eHNCYWQycWNrMmUvSkF2MVpq?= =?utf-8?B?U0pQSWVha2ZaNVVQSG94TjJUMm1mK2Z2d0ZyOVh0c21ISUtyRytmVlBQVCtl?= =?utf-8?B?dVlZeC85V1d2SHFFUHBPeldSM0VxUXk3a0d3Q3ljODJ1U2V5OWVoV3JyQlN0?= =?utf-8?B?b0FMVm1jN2VFcmhCQW04bzJZZVNEOHJLUk8wYlJOdGpGU3BGajdBZ2M5VW1V?= =?utf-8?B?c0NzRTlzWUEyaldoeERjQ21vdWo3Z0xScHlSWVFWcFNiRTdLVW84UDY2Nitk?= =?utf-8?B?Y1Y0bUlhQWxodVIzZi81aTVVNEZRNkQvaEI5S1c2djUrN3cwQnQ4K2FLQnRD?= =?utf-8?B?bWNaTW9KSjhqTTNId3d1WG1wRXZvSUtMZ3htdlZXUVNPdnNkNkY5VW9raStR?= =?utf-8?B?UDVuK0s5NTdCRmhoa3RvVnpwbkh4Ymh1ckZnelVMVzd1OVE2NEtDS1crWS9F?= =?utf-8?B?MnZzVnYwNHIwSzkzK3djVUIxWGJsZGxYbFdlY3NURDJaaWRLK3RXekR1WUtC?= =?utf-8?B?YVNaUmNsQmxQeUtKYitwSTd3VjNUbDNTT0RsSWxieFc0WHFIUHpoRmxMNW11?= =?utf-8?B?cUZQa0o3U3RWUXFWb2lWdDZwQzEzbGg3V0VxUEEvMEJydFErNjF0OVVkMk5B?= =?utf-8?B?Z1huNnNXQVRSNjNyVVlpWjRKU2hObkZ3RzBDY2RJRmVVbjFLbHpxY2FaajI5?= =?utf-8?B?czRWZ2JSdmovc2NUdUliQlc3dGRDN29Sc1BJRXBjSTc1UWUranJrY0ZBS05Q?= =?utf-8?B?ZE85TFlqSXR5RlY4TnVnc2VYUXdBSi9jLzJLZzJMNC9uK1phTitNdEVMOG9a?= =?utf-8?B?VzQzaXlWYmdGcjlVa1FRTy9lcGEvWkVkYTc3clp6NHlYRFVFdkNTRjNIOVFK?= =?utf-8?B?Tm5iUUlIY1hXbnpRbDBFMVFETWI5ZjVvTUtCODNrUmFrdHE5ZEloUThFTlQy?= =?utf-8?B?TkhHNmF2dlJXUnlVaE5BWlk4SDg0emRvUGtkZGk0aVZaeWVrUWFnVFl2ZlVp?= =?utf-8?B?OUQwZ0lzNklKcUpRSzZqYUpQTTd6SUJuTTJ3TWJNQTVQTzNlUkEyb1M3NGQr?= =?utf-8?B?S0RvaC9XOEc4cHpQMVcrOWlOWGg0OGNBSm50bCtXVEo4dmttV243TzJuYjQ4?= =?utf-8?B?dEJoMXllQnk5cEJLc3B0SExDbmkzQVJGcXgrSDl0a3JXbUhieWliK3A5alNV?= =?utf-8?B?QittZG9tbTFwUkdkT3ZSdWY4bksrbmxOTE5wVkVvM3J3VTY1aFBTVytmSmpJ?= =?utf-8?B?a1Fnb0tzWlJSUzZoeXE4Z0lJOEk4aFZlcXI1MjJXeXFpWXpWQ0s1Y2JkcFRq?= =?utf-8?B?OStoOUFKZTlaVWE3UUJIa2ZTL2cwT1N1T1pnL0Qzenh6dUd4a0ZIZndTcVJB?= =?utf-8?B?ZGtRbmVkbDBucGQxVldkYU5TMGJqTW5oYVFYbzg4MWg5a3IvTEcyT2REVzdI?= =?utf-8?B?NUNwRTkxUHBuNXh3SFNEVUdZL0RwNkRPQUlCSndEMUtnRjR5eFhXVzVEYkdq?= =?utf-8?B?anVTZjFmN0VVOHlMNmRmR2YxUFFmNkNsVmtSZm8xZlBVN3lJNW5KaDRFR0kz?= =?utf-8?B?ZUVkVGNicW1BYi9jY3prb0lIUGplU00rY0xld0htS0Z0YmMyRXVvTFZUL3BL?= =?utf-8?B?TXJsVjNrQ0ducmdvMVlXbUw5TENnbXgwam9RSU1qblNMV1JvdEdLalNiZlI5?= =?utf-8?B?OFFYbEEwWU9yWU1YOUQzSUNYdTA0QkFFYmVZMlZNbkZPS3RtMUc1KytYSFRJ?= =?utf-8?B?Y2IvcVhOQ2M0WitxRUlUaFYreUROcW1RU0Z4RTZvQm5MTnhhUnBBVXVTQmdC?= =?utf-8?B?Nmk0cGhZZnB4MTd4SWFoYmlqY0lVaWxFNjFkYmRLNFNUNzNqbk5YUng4K0py?= =?utf-8?B?VEZ1T2k0YVh3Y0ozOFpkdm5iR2pGTkVpSkZnQ21LNjR6bVA2WU9adTlZWFNs?= =?utf-8?B?YlFkZUhvSjlNTEVRc1dZV0prYkxXQmYvZ3dETTFNZkFCUFFhWWlvRENkNzk1?= =?utf-8?B?VWhPem5vdlNPRVVCYW9iOXBocnZkVmk0YTBSdUZUUWU0ZjM1aHVCVmR2NzMv?= =?utf-8?B?ZWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zuxVGJ1RY1BTok9GNVD4EUnWbz0lXwm/wwIkOXnInKkxXkQuHG5xsl2iA5JRcJGbzeUP7J+9A/qxhIp35Q88rp0JnXWa3BiH4nX+tB+hHSSCWNos/4O8fKyB9BqF7aFs90B3vuyviRgY7cJ3YT4oCPwc/PifyWmOiXKf/f7xu5g2eqmGXNKAfD0FpEVibmt4dgM/9AGGgTqUR73WYEWKlYim2TgiZWXZBQOtPscHYUXCrlAYP9vlRTBwblciv9PfbWIxPa5M2scfzm9N+DKo5rSEIE704CsD5E4roXToCssU7SQ2OAu8UJ0HigVOzMBNogXwVveAIxW8AU8yF16raLAZCMBzp7+BuWo0F9WqQq2r0dFmGwtaGjJNMfUAuvVOIoXC42nrjxgzWTuxucZtC7UcGOTrg/yImPchi58tZneWlosdfD+xPKXd5uKeYr0ollXU7i9ArrAcvfD4YtuPpRGep8s5mSWlzikRFDxamW9cPmLodnkXziQ0iv/tb0fx8PDjFn50pquSX07oJef2P9qdn+R/p87iK8w0LktyHtZwR+YcRLDTAlozSJWOCRtk9eiuOKMho7rbTLgf2CGvcu00zrEkUfqlXTkFzUFvh0GqZXgKk9jrAqDTshwYf0APnO6t/eUE0jCE4F0ad5gyh2HkTO7yOSo6v7SFTAqxBPGH6rwtZa9e1Zp0fhemzVacuGdNR+mRc3dprbHJR7ad6x60PRr916Am4VQT/Cwv1Xhidi2LVAYVGxSuSrxIX4MlYRA52WiLtKRa/CPd2K96n1NMr7nOVKEaqinxLaKm4Ih/OIYPGUP9eUauquRNhH+Jb/RAKpScCHyuwGTyVRvqRjTE5CYGNkFFAW57B9VvyJU= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9c2978-0576-450a-c2fd-08db94cfdb9f X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 09:47:46.9309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /DWgX2AytCP4KKc/FW8y4oyguPBX59XOMTm04gxPCNCE0nCqOYM8rZCf21mCgzym9hX/a3SSjgX1X8uW2wjDxqAAJZvIW1INSPx8XXajrMI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6484 On 04/08/2023 10:38 am, Federico Serafini wrote: > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index be2b10a391..e1d9b94007 100644 > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5591,7 +5591,7 @@ int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) > * > * It is an error to call with present flags over an unpopulated range. > */ > -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) > +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) I think both of these examples want to stay as nf (new flags).  Flags on its own is ambiguous in context, and nf is a common shorthand in our pagetable code. And it will make the patch rather shorter. ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:50:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:50:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577054.903879 (Exim 4.92) (envelope-from ) id 1qRrSB-0003HI-RZ; Fri, 04 Aug 2023 09:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577054.903879; Fri, 04 Aug 2023 09:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrSB-0003HB-Og; Fri, 04 Aug 2023 09:50:39 +0000 Received: by outflank-mailman (input) for mailman id 577054; Fri, 04 Aug 2023 09:50:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrSA-0003Gv-Ek for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:50:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d17331c-32ac-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:50:37 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 1DA324EE0737; Fri, 4 Aug 2023 11:50:37 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d17331c-32ac-11ee-b26b-6b7b168915f2 MIME-Version: 1.0 Date: Fri, 04 Aug 2023 11:50:37 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn?= =?UTF-8?Q?=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: <8672f79a-3e44-1cc3-b448-9ee4a4ed9090@suse.com> References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> <8672f79a-3e44-1cc3-b448-9ee4a4ed9090@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >>> >>> This pattern (two closing braces at the same level) is why switch >>> scope >>> variable declarations were introduced (at least as far as >>> introductions >>> by me go). If switch scope variables aren't okay (which I continue to >>> consider questionable), then this stylistic aspect needs sorting >>> first >>> (if everyone else thinks the above style is okay - with the missing >>> blank line inserted -, then so be it). >> >> Actually, they can be deviated because they don't result in wrong code >> being generated. > > Only later I recalled Andrew's intention to possibly make use of > -ftrivial-auto-var-init. While, unlike I think he said, such declared > variables aren't getting in the way of this (neither gcc nor clang > warn about them), they also don't benefit from it (i.e. they'll be > left uninitialized despite the command line option saying otherwise). > IOW I think further consideration is going to be needed here. > > Jan Well, in that case I'm happy if I can contribute in some way to the discussion, but perhaps this is best sorted out in a separate discussion, so that later I can send a v2 reflecting the decision(s). -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 09:56:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 09:56:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577060.903889 (Exim 4.92) (envelope-from ) id 1qRrXr-0003tZ-FC; Fri, 04 Aug 2023 09:56:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577060.903889; Fri, 04 Aug 2023 09:56:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrXr-0003tS-Bn; Fri, 04 Aug 2023 09:56:31 +0000 Received: by outflank-mailman (input) for mailman id 577060; Fri, 04 Aug 2023 09:56:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrXq-0003tM-6M for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 09:56:30 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e432841-32ad-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 11:56:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E62F21F749; Fri, 4 Aug 2023 09:56:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C1B2A13904; Fri, 4 Aug 2023 09:56:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Mw+OLUvLzGRLJQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 09:56:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e432841-32ad-11ee-b26b-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691142987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NaB9noiwagUgfzbRquK80gEgFMYKlT0Y/GRF52rBjt4=; b=bESbR+1PKJ8uN3wbBGrJ5AvYt39As6VlM1PtyLmXRH3slGRTxYriptwFI/FG77PqNuPjVj iuimkdsHgC3kqy6ZXe2F/KJcN4tZ/p/2Z29RWpQBVjC0JteincInykUj/FyjqJB7YCtoxB BiezFX/XK7L8VIztmosTR/MOrtAqorI= Message-ID: Date: Fri, 4 Aug 2023 11:56:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Cbiz03jD6Hj0LQFMzwWwNVG2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Cbiz03jD6Hj0LQFMzwWwNVG2 Content-Type: multipart/mixed; boundary="------------v6AYWH5mYGRmekxjR7CvjFmH"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: Subject: Re: [PATCH v3 22/25] tools/xenstore: merge get_spec_node() into get_node_canonicalized() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-23-jgross@suse.com> <014c1c12-ffba-97fa-d07a-ca2e82179c70@suse.com> In-Reply-To: --------------v6AYWH5mYGRmekxjR7CvjFmH Content-Type: multipart/mixed; boundary="------------I0R8q0RsAQsxLLT7nennnGoH" --------------I0R8q0RsAQsxLLT7nennnGoH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjMgMTE6NDQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gDQo+IA0KPiBPbiAw NC8wOC8yMDIzIDEwOjM0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDQuMDguMjMg MTE6MjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSwNCj4+Pg0KPj4+IE9uIDA0LzA4 LzIwMjMgMTA6MTcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+IE9uIDAzLjA4LjIzIDIz OjM2LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+PiBIaSwNCj4+Pj4+DQo+Pj4+PiBPbiAy NC8wNy8yMDIzIDEyOjAyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4+Pj4+IGRpZmYgLS1n aXQgYS90b29scy94ZW5zdG9yZS94ZW5zdG9yZWRfd2F0Y2guYyANCj4+Pj4+PiBiL3Rvb2xz L3hlbnN0b3JlL3hlbnN0b3JlZF93YXRjaC5jDQo+Pj4+Pj4gaW5kZXggODZjZjgzMjJiNC4u MjY2MmEzZmE0OSAxMDA2NDQNCj4+Pj4+PiAtLS0gYS90b29scy94ZW5zdG9yZS94ZW5zdG9y ZWRfd2F0Y2guYw0KPj4+Pj4+ICsrKyBiL3Rvb2xzL3hlbnN0b3JlL3hlbnN0b3JlZF93YXRj aC5jDQo+Pj4+Pj4gQEAgLTE2NiwxOSArMTY2LDEyIEBAIHN0YXRpYyBpbnQgZGVzdHJveV93 YXRjaCh2b2lkICpfd2F0Y2gpDQo+Pj4+Pj4gwqAgc3RhdGljIGludCBjaGVja193YXRjaF9w YXRoKHN0cnVjdCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsDQo+Pj4+Pj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb25zdCBjaGFyICoqcGF0aCwg Ym9vbCAqcmVsYXRpdmUpDQo+Pj4+Pj4gwqAgew0KPj4+Pj4+IC3CoMKgwqAgLyogQ2hlY2sg aWYgdmFsaWQgZXZlbnQuICovDQo+Pj4+Pj4gLcKgwqDCoCBpZiAoc3Ryc3RhcnRzKCpwYXRo LCAiQCIpKSB7DQo+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgICpyZWxhdGl2ZSA9IGZhbHNlOw0K Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBpZiAoc3RybGVuKCpwYXRoKSA+IFhFTlNUT1JFX1JF TF9QQVRIX01BWCkNCj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnb3RvIGludmFs Ow0KPj4+Pj4NCj4+Pj4+IEkgY2FuJ3QgZmluZCBhbiBleGFjdCBtYXRjaGluZyBjaGVjayBp biBpc192YWxpZF9ub2RlbmFtZSgpLiBUaGUgY2FsbCBhbHNvIA0KPj4+Pj4gc2VlbXMgdG8g cHV0IG1vcmUgcmVzdHJpY3Rpb24gb24gJ0AnIG5vZGUuIENhbiB5b3UgY2xhcmlmeT8NCj4+ Pj4NCj4+Pj4gVGhlIGNhbGwgb2YgZG9tYWluX21heF9jaGsoKSBpbiBpc192YWxpZF9ub2Rl bmFtZSgpIHdpbGwgY2hlY2sgdGhlIGxlbmd0aA0KPj4+PiBvZiB0aGUgbm9kZSBuYW1lIChh dCBsZWFzdCBmb3IgdW5wcml2aWxlZ2VkIGNhbGxlcnMsIHdoaWNoIGlzIHRoZSBpbXBvcnRh bnQNCj4+Pj4gY2FzZSkuDQo+Pj4NCj4+PiBSaWdodCwgYnV0IGZyb20gbXkgdW5kZXJzdGFu ZGluZywgdGhpcyBtYXkgbm90IGNoZWNrIGFnYWluc3QgDQo+Pj4gWEVOU1RPUkVfUkVMX1BB VEhfTUFYIGJ1dCB3aGF0ZXZlciBsaW1pdCB0aGUgdXNlciBzZXQuDQo+Pg0KPj4gWWVzLCBh bmQgdGhhdCdzIHdoYXQgc2hvdWxkIGJlIHRlc3RlZCwgcmlnaHQ/IEkgZG9uJ3Qgc2VlIHdo eSBzcGVjaWFsIG5vZGVzDQo+PiBzaG91bGQgbm90IGFkaGVyZSB0byB0aGUgc2FtZSBsaW1p dHMgYXMgb3RoZXIgbm9kZXMuIEluIGNhc2UgYW4gdW5wcml2aWxlZ2VkDQo+PiB1c2VyIHNo b3VsZCBoYXZlIGFjY2VzcyB0byBzcGVjaWFsIG5vZGVzLCB0aGUgbGltaXRzIHNob3VsZG4n dCBoaW5kZXIgdGhlDQo+PiB1c2VyIHRvIGFjY2VzcyB0aG9zZSBub2RlcyAoc2V0dGluZyBh IGxpbWl0IGJlbG93IDE1IHdvdWxkIGJlIHJpZGljdWxvdXMNCj4+IGFueXdheSwgYW5kIHRo YXQgaXMgdGhlIGxlbmd0aCBvZiBsb25nZXN0IHNwZWNpYWwgbm9kZSBuYW1lIHRvZGF5KS4N Cj4gSSBkb24ndCBtaW5kIHlvdSB3YW50IHRvIHRlc3QgYWdhaW5zdCBhIGRpZmZlcmVudCB2 YWx1ZS4gTXkgcG9pbnQgaXMgbW9yZSB0aGF0IA0KPiB5b3UgZGlkbid0IG1lbnRpb24gdGhh dCB0aGUgbGltaXQgd2lsbCBiZSBjaGFuZ2VkLg0KDQpXaWxsIG1lbnRpb24gaXQuDQoNCg0K SnVlcmdlbg0KDQo= --------------I0R8q0RsAQsxLLT7nennnGoH Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------I0R8q0RsAQsxLLT7nennnGoH-- --------------v6AYWH5mYGRmekxjR7CvjFmH-- --------------Cbiz03jD6Hj0LQFMzwWwNVG2 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTMy0sFAwAAAAAACgkQsN6d1ii/Ey9N igf/VG8EzcLU/u9FlsxFX+vVVHmUD5bcN+FlXinxxBofRLaoJCGQBqpp6ZhW8UgRsUCRh2XPpnjh FFupCjjuLfMciWe/6Cf9xbdWoWITCG2tbtPaL4CkQtl1kKgPKZo6Q5KjWhfHolRK85S1j6jJ82u1 ERRxthmIVnO9v1XIn2nXj04dhvWm9b7JOVkwiqUe7S3X+7UBwvflPzhRhlY6YSI9VjTBoWqkz+WV d1+IDExr519iemqnvEffvLIwiAVbESxRPcEB7Z7IvYnJV/yjOs9OT/YMi65aYvTKXNt35CQP9ar5 VH2oNVhcrSrL1V+OkDqip/fjpydDnFlNh5aJjLJMRg== =EiEA -----END PGP SIGNATURE----- --------------Cbiz03jD6Hj0LQFMzwWwNVG2-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:00:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:00:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577065.903899 (Exim 4.92) (envelope-from ) id 1qRrbb-0005Tj-4d; Fri, 04 Aug 2023 10:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577065.903899; Fri, 04 Aug 2023 10:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrbb-0005Tc-0i; Fri, 04 Aug 2023 10:00:23 +0000 Received: by outflank-mailman (input) for mailman id 577065; Fri, 04 Aug 2023 10:00:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrbZ-0005TW-EL for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:00:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrbY-0007Gr-O0; Fri, 04 Aug 2023 10:00:20 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRrbY-0007Gi-GN; Fri, 04 Aug 2023 10:00:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=AUdSYoW/av4g7UYR5WlJMgpsOl6GS4o3nE3JsCZ1kXo=; b=wbwSTmDgiQG0f2IcN4nHhic7A5 Q8eFriT8GR62CMXHb4dFgXz+lxn+4qIgBsJ8hFukaYxc+iuh2HYemvBPc7Ts4O95L5th5ePCD+YRz 8HZT8OgPLCDFqH6CIBzmTEj/Dn4WGnhXEy6auBGPKyr+TNVeUEAxQBbqV9TByLPeajzk=; Message-ID: Date: Fri, 4 Aug 2023 11:00:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> From: Julien Grall In-Reply-To: <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/08/2023 10:35, Juergen Gross wrote: > On 03.08.23 23:46, Julien Grall wrote: >> Hi, >> >> On 24/07/2023 12:02, Juergen Gross wrote: >>> Today is_valid_nodename() is always called directly after calling >>> canonicalize(), with the exception of do_unwatch(), where the call >>> is missing (which is not correct, but results just in a wrong error >>> reason being returned). >> >> While this change makes sense... >> >>> >>> Merge is_valid_nodename() into canonicalize(). While at it merge >>> valid_chars() into it, too. >> >> ... I am not in favor of folding the code is_valid_nodename() and >> valid_chars() into canonicalize() because the code is now more >> difficult to read. Also, the keeping the split would allow to free the >> 'name' in case of an error without adding too much goto in the code. > > I don't think we can easily free name in an error case, at that would > require > to keep knowledge that name was just allocated in the non-canonical case. How about this: const char *canonicalize(struct connection *conn, const void *ctx, const char *node, bool allow_special) { const char *prefix; const char *name; if (!node) return NULL; if (node[0] == '@' && !allow_special) return NULL; if (!node || (node[0] == '/') || (node[0] == '@')) return node; prefix = get_implicit_path(conn); if (prefix) { name = talloc_asprintf(ctx, "%s/%s", prefix, node); if (name) return NULL; } else name = node; if (!is_valid_nodename(conn, node, allow_special)) { /* Release the memory if 'name' was allocated by us */ if ( name != node ) talloc_free(name); return NULL; } return name; } And before you ask, I don't see the benefits to partially validate the name before allocating. Hence why I suggest to keep is_valid_nodename() as this keep the function small. >>> Signed-off-by: Juergen Gross >>> --- >>> V3: >>> - new patch >>> --- >>>   tools/xenstore/xenstored_core.c  | 89 ++++++++++++++------------------ >>>   tools/xenstore/xenstored_core.h  |  6 +-- >>>   tools/xenstore/xenstored_watch.c | 16 ++---- >>>   3 files changed, 45 insertions(+), 66 deletions(-) >>> >>> diff --git a/tools/xenstore/xenstored_core.c >>> b/tools/xenstore/xenstored_core.c >>> index ea5a1a9cce..ec20bc042d 100644 >>> --- a/tools/xenstore/xenstored_core.c >>> +++ b/tools/xenstore/xenstored_core.c >>> @@ -1210,42 +1210,6 @@ void send_ack(struct connection *conn, enum >>> xsd_sockmsg_type type) >>>       send_reply(conn, type, "OK", sizeof("OK")); >>>   } >>> -static bool valid_chars(const char *node) >>> -{ >>> -    /* Nodes can have lots of crap. */ >>> -    return (strspn(node, >>> -               "ABCDEFGHIJKLMNOPQRSTUVWXYZ" >>> -               "abcdefghijklmnopqrstuvwxyz" >>> -               "0123456789-/_@") == strlen(node)); >>> -} >>> - >>> -bool is_valid_nodename(const struct connection *conn, const char *node, >>> -               bool allow_special) >>> -{ >>> -    int local_off = 0; >>> -    unsigned int domid; >>> - >>> -    /* Must start in / or - if special nodes are allowed - in @. */ >>> -    if (!strstarts(node, "/") && (!allow_special || !strstarts(node, >>> "@"))) >>> -        return false; >>> - >>> -    /* Cannot end in / (unless it's just "/"). */ >>> -    if (strends(node, "/") && !streq(node, "/")) >>> -        return false; >>> - >>> -    /* No double //. */ >>> -    if (strstr(node, "//")) >>> -        return false; >>> - >>> -    if (sscanf(node, "/local/domain/%5u/%n", &domid, &local_off) != 1) >>> -        local_off = 0; >>> - >>> -    if (domain_max_chk(conn, ACC_PATHLEN, strlen(node) - local_off)) >>> -        return false; >>> - >>> -    return valid_chars(node); >>> -} >>> - >>>   /* We expect one arg in the input: return NULL otherwise. >>>    * The payload must contain exactly one nul, at the end. >>>    */ >>> @@ -1279,16 +1243,46 @@ static char *perms_to_strings(const void >>> *ctx, const struct node_perms *perms, >>>   } >>>   const char *canonicalize(struct connection *conn, const void *ctx, >>> -             const char *node) >>> +             const char *node, bool allow_special) >>>   { >>> -    const char *prefix; >>> +    char *name; >>> +    int local_off = 0; >>> +    unsigned int domid; >>> -    if (!node || (node[0] == '/') || (node[0] == '@')) >>> -        return node; >>> -    prefix = get_implicit_path(conn); >>> -    if (prefix) >>> -        return talloc_asprintf(ctx, "%s/%s", prefix, node); >>> -    return node; >>> +    errno = EINVAL; >>> +    if (!node) >>> +        return NULL; >>> + >>> +    if (strspn(node, >>> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" >>> +             "0123456789-/_@") != strlen(node)) >>> +        return NULL; >>> + >>> +    if (node[0] == '@' && !allow_special) >>> +        return NULL; >>> + >>> +    if (node[0] != '/' && node[0] != '@') { >>> +        name = talloc_asprintf(ctx, "%s/%s", get_implicit_path(conn), >>> +                       node); >> >> This is allocated but not freed on error. I understand this is part of >> the 'ctxt' and therefore will be free later on. But this means >> temporary memory will be allocated for longer. So best to clean-up >> when you can. > > Really? Let me reply with a different question. Why should we keep the memory allocated longer than necessary? > > It is possible, of course, but it is adding more code churn. Remember that > "name" is allocated only in case of a relative path, so freeing it needs > to be conditional, too (yes, it would be possible via comparing name to > node). See above, a proposal. > > In case you want me to go this route, I can rearrange the code in order to > avoid multiple error exits by having only one large if () testing for all > possible violations. > >> >>> +        if (!name) >>> +            return NULL; >>> +    } else >>> +        name = (char *)node; >> >> Why does name need to be const? > > I think the question was posed in a wrong way. :-) Whoops yes. > > I'll change name to be const char *. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:14:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577069.903909 (Exim 4.92) (envelope-from ) id 1qRroc-00072q-8L; Fri, 04 Aug 2023 10:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577069.903909; Fri, 04 Aug 2023 10:13:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRroc-00072j-5i; Fri, 04 Aug 2023 10:13:50 +0000 Received: by outflank-mailman (input) for mailman id 577069; Fri, 04 Aug 2023 10:13:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRroY-00072d-U4 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:13:48 +0000 Received: from casper.infradead.org (casper.infradead.org [2001:8b0:10b:1236::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95a5c82e-32af-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 12:13:44 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRroA-009Hn5-6s; Fri, 04 Aug 2023 10:13:22 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 400A730020C; Fri, 4 Aug 2023 12:13:21 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1F03F2107C447; Fri, 4 Aug 2023 12:13:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95a5c82e-32af-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GYK9+OGfxviHr18NI+B7bkONaqcCERrPUSZDWZMRPEQ=; b=Si4qEE3c+HJrS2LkWUpXkEpwIY z2QG84d95tw+UddPI6rUzadRriq2PDZYJ6XXgw1x4zVAysI26DpGR+v731iLeXUZpRG2lgIbPY72I 85Z6xFBogTIWFnZfNZ3S5QtL+ki4RcsOQiafmnH+Ad4fikMc2BFW263jmaF+Yq1RI6wmtI2QFGM9e ynZc/AAqQWPF0jP6VORFQ68/nqLS5sz5Lw9voBgJBLLNR9+ghPabvhaxhVI/lrVi2pG/Art4rrfjP Ipm/2XkF12gk117ch8cTn0cq83XETEzdbxKMmrQET7kTOkjlN6SKIYhgKMGA8v/MhBhxLtLPW2cf8 KqI33mSw==; Date: Fri, 4 Aug 2023 12:13:21 +0200 From: Peter Zijlstra To: Xin Li Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Juergen Gross , Boris Ostrovsky Subject: Re: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Message-ID: <20230804101321.GH214207@hirez.programming.kicks-ass.net> References: <20230804075734.8372-1-xin3.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804075734.8372-1-xin3.li@intel.com> On Fri, Aug 04, 2023 at 12:57:34AM -0700, Xin Li wrote: > The IDT event delivery of X86_TRAP_DF, X86_TRAP_TS, X86_TRAP_NP, > X86_TRAP_SS, X86_TRAP_GP, X86_TRAP_AC and X86_TRAP_CP pushes an error > code into the orig_ax member of the pt_regs structure, and the error > code is passed as the second argument of their C-handlers, although > the pt_regs structure is already passed as the first argument. > > The asm entry code of such faults does the following > > movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ > movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ > > to set the orig_ax member to -1 just before calling the C-handler. > > In addition, the IRQ entry code uses the second error code argument > as its IRQ vector, as the IRQ asm entry code pushes its IRQ vector > into the orig_ax member. > > The commit d99015b1abbad ("x86: move entry_64.S register saving out of > the macros") introduced the changes to set orig_ax to -1, but I can't > see why it's required. Our tests on x86_64 and x86_32 seem fine if > orig_ax is left unchanged instead of set to -1. That means that SYSCALL_NUM(regs) get to be garbage; or something like that. From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:18:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:18:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577073.903918 (Exim 4.92) (envelope-from ) id 1qRrsi-0007fN-On; Fri, 04 Aug 2023 10:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577073.903918; Fri, 04 Aug 2023 10:18:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrsi-0007fG-Lm; Fri, 04 Aug 2023 10:18:04 +0000 Received: by outflank-mailman (input) for mailman id 577073; Fri, 04 Aug 2023 10:18:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRrsh-0007f8-70 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:18:03 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30bdba83-32b0-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 12:18:01 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 969371F8AE; Fri, 4 Aug 2023 10:18:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6196D13904; Fri, 4 Aug 2023 10:18:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0rxoFVjQzGTHLwAAMHmgww (envelope-from ); Fri, 04 Aug 2023 10:18:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30bdba83-32b0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691144280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=di3ivyrNeyF0VS8VuVBxnfkN9kNd9gXCabW2V/BS6vk=; b=DPKBM4gsD2irqRO4LOnMDBIQUh26cGBzZesUd4i+b09aCjRXL/bRkOI/RkK940MSJ8XvrA BNIH8f95XJxhL6vYGBlqSD/tPvNe9XrXNokFaKVqqejgr+ALMOL+79S+jtaDgjpyKdOt/0 qFIJ++Mujr53OVDsIEFdAI1hTBuFXrM= Message-ID: <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> Date: Fri, 4 Aug 2023 12:17:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> From: Juergen Gross Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------7eGtJhfWD2eV7lNNV2nDPntC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------7eGtJhfWD2eV7lNNV2nDPntC Content-Type: multipart/mixed; boundary="------------LxLvMJZ1H0p7ahM0kf3VUuVy"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> In-Reply-To: --------------LxLvMJZ1H0p7ahM0kf3VUuVy Content-Type: multipart/mixed; boundary="------------VKt5a6eOm5Zv9WEb3rzgJgOh" --------------VKt5a6eOm5Zv9WEb3rzgJgOh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjMgMTI6MDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGksDQo+IA0KPiBP biAwNC8wOC8yMDIzIDEwOjM1LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMDMuMDgu MjMgMjM6NDYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBIaSwNCj4+Pg0KPj4+IE9uIDI0 LzA3LzIwMjMgMTI6MDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+IFRvZGF5IGlzX3Zh bGlkX25vZGVuYW1lKCkgaXMgYWx3YXlzIGNhbGxlZCBkaXJlY3RseSBhZnRlciBjYWxsaW5n DQo+Pj4+IGNhbm9uaWNhbGl6ZSgpLCB3aXRoIHRoZSBleGNlcHRpb24gb2YgZG9fdW53YXRj aCgpLCB3aGVyZSB0aGUgY2FsbA0KPj4+PiBpcyBtaXNzaW5nICh3aGljaCBpcyBub3QgY29y cmVjdCwgYnV0IHJlc3VsdHMganVzdCBpbiBhIHdyb25nIGVycm9yDQo+Pj4+IHJlYXNvbiBi ZWluZyByZXR1cm5lZCkuDQo+Pj4NCj4+PiBXaGlsZSB0aGlzIGNoYW5nZSBtYWtlcyBzZW5z ZS4uLg0KPj4+DQo+Pj4+DQo+Pj4+IE1lcmdlIGlzX3ZhbGlkX25vZGVuYW1lKCkgaW50byBj YW5vbmljYWxpemUoKS4gV2hpbGUgYXQgaXQgbWVyZ2UNCj4+Pj4gdmFsaWRfY2hhcnMoKSBp bnRvIGl0LCB0b28uDQo+Pj4NCj4+PiAuLi4gSSBhbSBub3QgaW4gZmF2b3Igb2YgZm9sZGlu ZyB0aGUgY29kZSBpc192YWxpZF9ub2RlbmFtZSgpIGFuZCANCj4+PiB2YWxpZF9jaGFycygp IGludG8gY2Fub25pY2FsaXplKCkgYmVjYXVzZSB0aGUgY29kZSBpcyBub3cgbW9yZSBkaWZm aWN1bHQgdG8gDQo+Pj4gcmVhZC4gQWxzbywgdGhlIGtlZXBpbmcgdGhlIHNwbGl0IHdvdWxk IGFsbG93IHRvIGZyZWUgdGhlICduYW1lJyBpbiBjYXNlIG9mIA0KPj4+IGFuIGVycm9yIHdp dGhvdXQgYWRkaW5nIHRvbyBtdWNoIGdvdG8gaW4gdGhlIGNvZGUuDQo+Pg0KPj4gSSBkb24n dCB0aGluayB3ZSBjYW4gZWFzaWx5IGZyZWUgbmFtZSBpbiBhbiBlcnJvciBjYXNlLCBhdCB0 aGF0IHdvdWxkIHJlcXVpcmUNCj4+IHRvIGtlZXAga25vd2xlZGdlIHRoYXQgbmFtZSB3YXMg anVzdCBhbGxvY2F0ZWQgaW4gdGhlIG5vbi1jYW5vbmljYWwgY2FzZS4NCj4gDQo+IEhvdyBh Ym91dCB0aGlzOg0KPiANCj4gY29uc3QgY2hhciAqY2Fub25pY2FsaXplKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsDQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29uc3QgY2hhciAqbm9kZSwgYm9vbCBh bGxvd19zcGVjaWFsKQ0KPiB7DQo+ICDCoMKgwqDCoMKgwqDCoCBjb25zdCBjaGFyICpwcmVm aXg7DQo+ICDCoMKgwqDCoMKgwqDCoCBjb25zdCBjaGFyICpuYW1lOw0KPiANCj4gIMKgwqDC oMKgwqDCoMKgIGlmICghbm9kZSkNCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCByZXR1cm4gTlVMTDsNCj4gDQo+ICDCoMKgwqDCoMKgwqDCoCBpZiAobm9kZVswXSA9PSAn QCcgJiYgIWFsbG93X3NwZWNpYWwpDQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgcmV0dXJuIE5VTEw7DQo+IA0KPiAgwqDCoMKgwqDCoMKgwqAgaWYgKCFub2RlIHx8IChu b2RlWzBdID09ICcvJykgfHwgKG5vZGVbMF0gPT0gJ0AnKSkNCj4gIMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gbm9kZTsNCj4gIMKgwqDCoMKgwqDCoMKgIHByZWZp eCA9IGdldF9pbXBsaWNpdF9wYXRoKGNvbm4pOw0KPiAgwqDCoMKgwqDCoMKgwqAgaWYgKHBy ZWZpeCkgew0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5hbWUgPSB0YWxs b2NfYXNwcmludGYoY3R4LCAiJXMvJXMiLCBwcmVmaXgsIG5vZGUpOw0KPiAgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChuYW1lKQ0KPiAgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gTlVMTDsNCj4gIMKgwqDCoMKg wqDCoMKgIH0gZWxzZQ0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5hbWUg PSBub2RlOw0KPiANCj4gIMKgwqDCoMKgwqDCoMKgIGlmICghaXNfdmFsaWRfbm9kZW5hbWUo Y29ubiwgbm9kZSwgYWxsb3dfc3BlY2lhbCkpIHsNCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAvKiBSZWxlYXNlIHRoZSBtZW1vcnkgaWYgJ25hbWUnIHdhcyBhbGxvY2F0 ZWQgYnkgdXMgKi8NCj4gIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIG5h bWUgIT0gbm9kZSApDQo+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHRhbGxvY19mcmVlKG5hbWUpOw0KPiAgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiBOVUxMOw0KPiAgwqDCoMKgwqDCoMKgwqAgfQ0KPiANCj4gIMKg wqDCoMKgwqDCoMKgIHJldHVybiBuYW1lOw0KPiB9DQo+IA0KPiBBbmQgYmVmb3JlIHlvdSBh c2ssIEkgZG9uJ3Qgc2VlIHRoZSBiZW5lZml0cyB0byBwYXJ0aWFsbHkgdmFsaWRhdGUgdGhl IG5hbWUgDQo+IGJlZm9yZSBhbGxvY2F0aW5nLiBIZW5jZSB3aHkgSSBzdWdnZXN0IHRvIGtl ZXAgaXNfdmFsaWRfbm9kZW5hbWUoKSBhcyB0aGlzIGtlZXAgDQo+IHRoZSBmdW5jdGlvbiBz bWFsbC4NCg0KUGFydGlhbGx5IHZhbGlkYXRpbmcgYmVmb3JlIGRvaW5nIHRoZSBhbGxvY2F0 aW9uIGlzIGEgYmVuZWZpdCBhcyBpdCBkb2Vzbid0DQpzcGVuZCBjeWNsZXMgb24gdmFsaWRh dGluZyB0aGUga25vd24gZ29vZCBwcmVmaXguDQoNCkFkZGl0aW9uYWxseSB5b3VyIGV4YW1w bGUgd29uJ3QgdmFsaWRhdGUgYW4gYWJzb2x1dGUgcGF0aG5hbWUgYXQgYWxsLg0KDQpXaGF0 IGFib3V0IHRoaXMgdmFyaWFudDoNCg0KY29uc3QgY2hhciAqY2Fub25pY2FsaXplKHN0cnVj dCBjb25uZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsDQogICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbnN0IGNoYXIgKm5vZGUsIGJvb2wgYWxsb3dfc3BlY2lhbCkNCnsNCiAg ICAgICAgIGNvbnN0IGNoYXIgKm5hbWU7DQogICAgICAgICBpbnQgbG9jYWxfb2ZmID0gMDsN CiAgICAgICAgIHVuc2lnbmVkIGludCBkb21pZDsNCg0KICAgICAgICAgLyoNCiAgICAgICAg ICAqIEludmFsaWQgaWYgYW55IG9mOg0KICAgICAgICAgICogLSBubyBub2RlIGF0IGFsbA0K ICAgICAgICAgICogLSBpbGxlZ2FsIGNoYXJhY3RlciBpbiBub2RlDQogICAgICAgICAgKiAt IHN0YXJ0cyB3aXRoICdAJyBidXQgbm8gc3BlY2lhbCBub2RlIGFsbG93ZWQNCiAgICAgICAg ICAqLw0KICAgICAgICAgZXJybm8gPSBFSU5WQUw7DQogICAgICAgICBpZiAoIW5vZGUgfHwN CiAgICAgICAgICAgICBzdHJzcG4obm9kZSwgIkFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFla YWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXoiDQogICAgICAgICAgICAgICAgICAgICAgICAg ICIwMTIzNDU2Nzg5LS9fQCIpICE9IHN0cmxlbihub2RlKSB8fA0KICAgICAgICAgICAgIChu b2RlWzBdID09ICdAJyAmJiAhYWxsb3dfc3BlY2lhbCkpDQogICAgICAgICAgICAgICAgIHJl dHVybiBOVUxMOw0KDQogICAgICAgICBpZiAobm9kZVswXSAhPSAnLycgJiYgbm9kZVswXSAh PSAnQCcpIHsNCiAgICAgICAgICAgICAgICAgbmFtZSA9IHRhbGxvY19hc3ByaW50ZihjdHgs ICIlcy8lcyIsIGdldF9pbXBsaWNpdF9wYXRoKGNvbm4pLA0KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG5vZGUpOw0KICAgICAgICAgICAgICAgICBpZiAoIW5h bWUpDQogICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7DQogICAgICAgICB9 IGVsc2UNCiAgICAgICAgICAgICAgICAgbmFtZSA9IG5vZGU7DQoNCiAgICAgICAgIGlmIChz c2NhbmYobmFtZSwgIi9sb2NhbC9kb21haW4vJTV1LyVuIiwgJmRvbWlkLCAmbG9jYWxfb2Zm KSAhPSAxKQ0KICAgICAgICAgICAgICAgICBsb2NhbF9vZmYgPSAwOw0KDQogICAgICAgICAv Kg0KICAgICAgICAgICogT25seSB2YWxpZCBpZjoNCiAgICAgICAgICAqIC0gZG9lc24ndCBl bmQgaW4gLyAodW5sZXNzIGl0J3MganVzdCAiLyIpDQogICAgICAgICAgKiAtIG5vIGRvdWJs ZSAvLw0KICAgICAgICAgICogLSBub3QgdmlvbGF0aW5nIG1heCBhbGxvd2VkIHBhdGggbGVu Z3RoDQogICAgICAgICAgKi8NCiAgICAgICAgIGlmICghKHN0cmVuZHMobmFtZSwgIi8iKSAm JiAhc3RyZXEobmFtZSwgIi8iKSkgJiYNCiAgICAgICAgICAgICAhc3Ryc3RyKG5hbWUsICIv LyIpICYmDQogICAgICAgICAgICAgIWRvbWFpbl9tYXhfY2hrKGNvbm4sIEFDQ19QQVRITEVO LCBzdHJsZW4obmFtZSkgLSBsb2NhbF9vZmYpKQ0KICAgICAgICAgICAgICAgICByZXR1cm4g bmFtZTsNCg0KICAgICAgICAgLyogUmVsZWFzZSB0aGUgbWVtb3J5IGlmICduYW1lJyB3YXMg YWxsb2NhdGVkIGJ5IHVzLiAqLw0KICAgICAgICAgaWYgKG5hbWUgIT0gbm9kZSkNCiAgICAg ICAgICAgICAgICAgdGFsbG9jX2ZyZWUobmFtZSk7DQogICAgICAgICByZXR1cm4gTlVMTDsN Cn0NCg0KDQpKdWVyZ2VuDQo= --------------VKt5a6eOm5Zv9WEb3rzgJgOh Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------VKt5a6eOm5Zv9WEb3rzgJgOh-- --------------LxLvMJZ1H0p7ahM0kf3VUuVy-- --------------7eGtJhfWD2eV7lNNV2nDPntC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTM0FcFAwAAAAAACgkQsN6d1ii/Ey+d lQf8DN4dsSrsVaUssLuGXXukxw6DVPvUs4mEGILtFequmwW4mrA74eUezFtof87AOY8xc3pSqABA 4JdCutZ8iPRkZ8i+Bc4lEFRxRTXsi+/e3bKf1R5xF3fZhabUcaBGT0uVgXnsOpt+RIZLAaEmJ6fq XeT5bsvB+gv94gOhlNoDLS4v2fLxJ0sFFfahn5rBAGXAKPteB+zKLl3nl/LI0Z8qLGv6+VJVpquM xSQjylPzrVl/RqLQkUutK+sl9tf7JBC0QS58b+gRC64opwHCcKIRo4cN+ODgN36v/4VWnMSUhaGy Io2hmsFjd0FDOUeZl2ISVCL/7pi3/N91D4Dy1zoSvQ== =Mr4I -----END PGP SIGNATURE----- --------------7eGtJhfWD2eV7lNNV2nDPntC-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:25:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:25:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577078.903928 (Exim 4.92) (envelope-from ) id 1qRs0F-0000jH-Ga; Fri, 04 Aug 2023 10:25:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577078.903928; Fri, 04 Aug 2023 10:25:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs0F-0000jA-Dv; Fri, 04 Aug 2023 10:25:51 +0000 Received: by outflank-mailman (input) for mailman id 577078; Fri, 04 Aug 2023 10:25:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs0E-0000j4-Rw for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:25:50 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4657534a-32b1-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 12:25:48 +0200 (CEST) Received: from mail-bn7nam10lp2103.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.103]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Aug 2023 06:25:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5930.namprd03.prod.outlook.com (2603:10b6:806:111::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 10:25:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::9410:217b:251f:2a98%4]) with mapi id 15.20.6631.043; Fri, 4 Aug 2023 10:25:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4657534a-32b1-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691144748; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=asdRHLg9E03BV0goCJes0z0YYo3VDOKNf3DeHTfVyu8=; b=J9WqEgw1Gm2tjxuzRHiUxbmIen7dnByR9FwAoGR52kf69tjexEXy72fK nsM13vp6gugPhyZVT9KXPuL14hexXFXwWqBG+ldjt8ReTAi98dan7IPGb Nkp1NaX4RAEAoIjLM7FNzhRl6W8Mb8iilBV6B4TneH/A3dCB9DGcw9C4L A=; X-IronPort-RemoteIP: 104.47.70.103 X-IronPort-MID: 118931483 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Vvh8yql9LkdbPAZUFjh/WL7o5gz6JkRdPkR7XQ2eYbSJt1+Wr1Gzt xIYXG2Fa/6DZWDze9B3YY+1oExUuMXTzdFgS1Q9+Hw0FiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgb5AOGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 dUYdyAXLSCFvvvs0be4F81zmIcIFNa+aevzulk4pd3YJdAPZMmbBo/suppf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVk1Q3ieC2WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTe3prac20Ab7Kmo7DTYoUQK0kNaF1U/jff9cF 2Uu9wwXsv1nnKCsZpynN/Gim1aUvxhHHd5RO+w89AyJjKHT5m6xAmkCUy4Ea9E8ssIybSIl2 0XPnN7zAzFr9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIaxk8HyMTL92 TaHqG45nbp7pdIE07WT+VHBni62oZ7IXkg5623/W2Oj4QRRfoOpZ4W0r1Pc6J5oJp6xR12As X5U3cSThMgCBI+A0iyERv4AGpmt5vCYIHvdh0JiG98q8DHF027zI6hT7St4KUMvNdwLERfpe Eb7qxJN44UVN3yvBYdvbp68EdYCzK7uD93pW/nYKN1UbfBZdgCd+zp1TVWNxG2rm08p+Yk1P o2aaoCrFmoADrp8zyueQP0U2rsmgCs5wAvuqYvTyh2m1f+UYiGTQLJcaF+WNLlht+WDvRnf9 MtZO42S0RJDXebiYy7Rt4kOMVQNKnt9DpfzwyBKStO+zsNdMDlJI5fsLXkJIuSJQ4w9ej/0w 0yA IronPort-HdrOrdr: A9a23:EqKUSK/rMsot89Ppk8duk+Gydb1zdoMgy1knxilNoNJuA66lfu SV7YwmPHjP+UossRAb6Km90cy7LU80mqQV3WAuB8bvYOCLgguVxcRZnPDfK9OJIVy3ygZyvZ 0QOZSWIueAe2STtK7BkUKF+zxJ+qjLzEnQv5aW854Pd3ANV0gD1XYcNu/BKDwAeOAuP/NQf/ DwiParvwDQBkj/LP7LYUXtcNKz6OEj/6iWBCLuaSRXizWmsRPtzqLmGB6F2RokXypI2qpKyx m5r+Q5jp/Txs1SRXfnphvuB489oqqa9vJzQPaUgswiIj/wigCuDb4RKYGqjXQOuemq3l0ji7 D30mcdFvU20WrYelevrQLqwBSI6kdc11bSjWWAiX/Uu8b+Xz5SMbsxuatpNiHB404Xptt7y6 5832WF3qAncy8pF0nGiOT1aw== X-Talos-CUID: 9a23:vxvFCGEMaxxcV9s+qmJO9BEEAIMVdETElmbVIBKcFngqY4WKHAo= X-Talos-MUID: 9a23:vjExfQtSanRevblMcc2ngRpcMJ5n0ouSV0FQt7gFh+C+OApJJGLI X-IronPort-AV: E=Sophos;i="6.01,254,1684814400"; d="scan'208";a="118931483" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y5oOcpmufWTYNaSvVcYX9X6aw+WpHWr6onFKuTGj0hvp/GE/wp1yaauEyIPaXgqBUvw3RqhL9rHVEx2jTOARJGOCY9CCEqrrhVI8v/k+S1y8fRVlfKS5rf0SBtlHf44am11smnw0gutvDWty0qDvdqVs/SdCE9GE918CjFsNNvQhaIrrLph1o+O4sj5koph6HojhDT3mqgf3+DpS2INirzx5281Nx/lOidFmg3lWO64318WbWsbw1U43W/85jyTjNs0n/e/46fvY3mklsnDYp5wypNYqtWz8VKJm60WR7jfzhlddLS3l9l3KrCb7tGYpicZMYSUUUOlQ1/s/csyrdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=asdRHLg9E03BV0goCJes0z0YYo3VDOKNf3DeHTfVyu8=; b=V935yzrLbPEkztoH+R1GZhfdkbpQ5lQrRjY4UFM8KcWO+7Qh89Uhr6s7D51F+ei3Rbw820YJ1QW3v8qQtQtq/x9p7Z4hUWcK6fCdyayOzImg2JPHT3+/77cRyfaK2zIHPCSuMM7fveUhi9HiEzjhYC7Y14dbWFno7ppF9co4brrY3zWemzQFoDTJNSEIgoBvFjPodGI7wxczz/3W/KXa6mjH3kGivd+sGYxDrRVPW9n5MVy+WtH4R/SUOc6FzLdABHmzLUFHDkL0mJHi2pghq2LCGG8JTOi9joaQabMJoVve+e/6j1MLFx+2AGC7StMgxRG2Jfbz5N4ofmDEW+oNOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=asdRHLg9E03BV0goCJes0z0YYo3VDOKNf3DeHTfVyu8=; b=JPFAGyvL0dxSepAjWFhC5WJOfAdLarLPtLd0bZRkfmG1E68JzlFV0tZ8q4qauCbaSFsFQLCNHLO9ORERylKHsgA0eiLi5wzv3zZCvdUa8ZIt21IHNgFoAIKPE7IKiWpGnjdllbhEhz9VPT08GT0fDJvOW8cSJH1yBJDIRdZUR/E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Fri, 4 Aug 2023 11:25:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Content-Language: en-GB To: Xin Li , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Peter Zijlstra , Juergen Gross , Boris Ostrovsky References: <20230804075734.8372-1-xin3.li@intel.com> From: Andrew Cooper In-Reply-To: <20230804075734.8372-1-xin3.li@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0161.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA2PR03MB5930:EE_ X-MS-Office365-Filtering-Correlation-Id: 51c5db4a-7190-4d06-9414-08db94d527ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UCnx/9T0tESYbj50B2cLLzDR2fsdpHWRt/RMHiIGpDvxKAgkjDQU5zr0szEj1Yv+VUVf+3j60QUk+NWj+gWNOiMtB343H18/Ky94h+DdWJBirNCi4krv5kCUGZlfyAMEe1Yu7qeKHaG+oDCUdp6D/HhOTJzcaryvKJbdfNE7YDj4lJWE/kvy2KHSspd460RlHVh8lx2qzcnO9QJESSiZQTix1lJfjuGSyJi7dUmY5CJro6kbxtFuUs3XwvycFnNwys43D83NaKIXJOVQZfdqiCu3H7UcLdZJAIMSR1rTo59AunpG3Zf0mhCIT6/Bmkj3QQ5wWo4XsUTcSStbPTGLQo4mmkY+ZR+m8aMDkbGK//2R/17mWfM531UZLk5VxQ7FQa9ai2vBRr+QnG1Fpz5af2RVdKtWUyPT+uTfWxvqDELDU4P3jgkHAtM2De4iV9v1rr9kBea6qVv7CcGZUuxbvBE4i/uVkoxh8GTBqOtAZ8i2Y3RTwWVKLzuUoQ7jfqGzehVlyzasGvFDqzkhLyCXR89fwlrVF/coiuRrcygQt2TPsaNHTrr75ff2WvQa2/yNFNkjP7jEs8x4Dj9l1lY+XRZ5d+0ushcCJHNU9jp86KJaeWps9g0x56pLeeKacFxmGWX5xjQMxN3qq978K5hyVyPpQwx/U8Ow2xZCO0OQXUE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(1800799003)(186006)(451199021)(2616005)(53546011)(8676002)(26005)(6506007)(4326008)(2906002)(66476007)(316002)(4744005)(66946007)(5660300002)(66556008)(7416002)(8936002)(41300700001)(6666004)(6486002)(6512007)(478600001)(54906003)(82960400001)(38100700002)(31696002)(36756003)(86362001)(31686004)(26583001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGV2VjJ6Z2gwYW56b0dqTWdDQTRNQThPSGM4QUlHTzQyV1RHNEUwbDJYclRS?= =?utf-8?B?di9MTFZPMW9Eb08zZ0Y2TEZEdDBWM2xtSzhFb1FhdGVISy8wL0swL2VpbDU4?= =?utf-8?B?WUJsZUZYdVBCWXk0UFFlMndqTkRhcXNZZklZY0ZlT05RVGpMN2FHdHlsV3Ix?= =?utf-8?B?azlSK0dPS0VPai9LN3NDenpieGxkQThUWCtUdS9wOU56QkIwQ0M0ckgrZHpX?= =?utf-8?B?NGFMMnNYWjZ3dmlYaXVOV25wWExGUnMwSG1YeTNRYUN0TGlXeTYzUVRzVERL?= =?utf-8?B?Q3QyYnVnYm0yb0ZDczBBaWN2MDRxTjFNaG9qdEJtY2pzUi8vSWFxbEl0NEJU?= =?utf-8?B?Sy9rVU5ETktUcGU2dXg5ZS90VGtCRDc2Mys5Q29QckwySUJtT2xlQ3YrZzhl?= =?utf-8?B?SmdDSGw3NndMTlFncmh3R1NNbGQvdDdsQmtLcndPaExjNWdLRVdIYStPcmFD?= =?utf-8?B?WWRFZW45ZG9xcW1ueWZqc0pPd3lESXNYbnVGa0JObFRnRldNbWkraEpnb2Z3?= =?utf-8?B?cXVqc29RencrbnhQb0NYRnhlMm8xMGVaNE9TMkZNSWxQMjFKRFVoRzZmQU9p?= =?utf-8?B?THdmOUU1UmRxVzdxdkFRM0hwZ1FoNlREeVBURktsMXRxVklDdDFRemhIY1JT?= =?utf-8?B?aDhUWm0xUFRHNmpNVEJyZUM5dmZLc0VxWnZPRjRjQUlxSFRqbm1HUHIwella?= =?utf-8?B?cWsrSHh6UUNMUEQwbVhUOXVZcWVFTTQ2Tys1NFI2eHB4YWpMNE9CYUo3OWhY?= =?utf-8?B?VWxiRnBNaWdkaCtOSDZ6Vi9UVUJ2RjN2blFKVExCQmdoMnpkSVBScUFKSHdQ?= =?utf-8?B?eUl0aXJBR3VMelRhSDJITlBabVhYQmNCTFRtT3FKWEtOelZRS1YyeTVFdDhF?= =?utf-8?B?bElLekVVQnFqNTN3T3VXZHN4UHdCYVlUQlN6NmhybHhxMU5JdndQUGd6UG5r?= =?utf-8?B?ZjY1SmQzUXhjc3k4dThlbzFkTUpUTHBkS2xaZFFOZHV5VU05djRBQ3AraEZ1?= =?utf-8?B?Ym5EOGJNNUVvbzdyMmdaVEJSMUxlMVEyWFFTRTdneWJCUDlOWG5QY2RUUWZX?= =?utf-8?B?SEZBb0FKRS9qTThVa05scEpTZjdPQ1J3cDlCd3RDWERPV3FXQVgvNFU5OW9v?= =?utf-8?B?SEVvckRnRkJmYkI5Q0c0YmpNd1cvVDh0c0prVXJjSFBRL3QwV0JLY2FQSWFw?= =?utf-8?B?SzNod3Y0V2RmTTZtejBHWTRXWFI1SnJwU2Vad3NUdG5SMlh6bjQycUN3Nldj?= =?utf-8?B?aU84SjlCbHVYZFpDUjBlOGRESEI3cW9KaEQrS0ZYSUY3bjFlRXdwVjVpZGh4?= =?utf-8?B?OHdqQ0Jvc29laENEbHJmTFdCYnNCSU13c29aVGt5SWxrMVlSZ1BBbE5WdlNa?= =?utf-8?B?OU5OenVwbG94ZExnUWRlZVdRSlI5bFloRHduK1NnYTMzOW9NLzlsOTVYaXhV?= =?utf-8?B?R3ZSRm16TkVEajdDWTU3emJhMEcwR0VqcjlaK09pY2NsWTlaM290dEIrODBI?= =?utf-8?B?MjNyZko1QTc4Rjd3cXBQelBTY3lOUmFTSnk1MUNDdnc2T1NQemppZllBS2hN?= =?utf-8?B?dVZEUWQ0eDFYTUd1eWsvMnhGMmp6Yy90dGt5Qno0NWpGa0FGS0RaLzE3cmtX?= =?utf-8?B?VXhzZ0o3UXdEWmh5WUdDUlFIQmJoMHAvT3RJODFka20wRU94Q0JsMStiNjZn?= =?utf-8?B?MEU0WTNRSlJlQW9QTStHM0ZQYkJmMVhURlJVNDdkdkVkSndDa0d0N2NWT3A0?= =?utf-8?B?NGtiOG5uT3VWODZvWjNNSHlXTTRCQi8ydFU2dWp3YnllS00vUFlrK2lJUllm?= =?utf-8?B?TmJEWlJPVTlJOVJ2d05oaTFxQzltTFF3b1ZDcHl3ZnVXbWJVSlZyNkZ6ZTZC?= =?utf-8?B?NTRHQmgzOCs3WGhHblgyNjh1c0xVeVppbHpDaFY4RGF1VWlNTFhTdFlpUmRY?= =?utf-8?B?MlBFTHY4WkxZNmJrNVc2RjhidnBQY0lZSWQxWXZmdzB6c0ViN0dsYTFXV3hP?= =?utf-8?B?RHNPRjNLTktCTzh5L3lzQkZQUVpPSGFjZjBaZjl6VHVuM2swa0dqWnJqQnVT?= =?utf-8?B?Q1JKd2pWb0tDYlNzY1NaQWkyb0ZrR1RMVzMvOW5MTklRajNSRHc0cHZ2VHZR?= =?utf-8?B?U3hWWTMrVDBQbHppcTJ5OUh1ZzhzNE9HM2lUYmxJNHpvTG1yQ0RMdXlrVFVi?= =?utf-8?B?NEE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RmxCaUZ5TmNKa1JaSXUvNnhzWFgzc2dIaG1CL0czbmtreHFjYWcvSW1aVTJy?= =?utf-8?B?eDhoOFdPd1RBdTFVTGxXcGE2TTlaR2VNMko0UFZncDUwam5IU1FRUFRHaHBW?= =?utf-8?B?UlZqaFFNUkV5amhOUWNOU1lpS04wUFgwTmxtdWhwZHorZ1lJZUZ6ck50dG1w?= =?utf-8?B?WjR1OTJHZG1UQlBZRjgzUmp4aG1yaW9FZzZuTDZhY3JGdWZMcytoNkkraUxD?= =?utf-8?B?emdURXUrdHd4WHpMUkt6MG9mcDdUcDlkUlE2dHBvUHlsWkoxS0VzTTNRUmFM?= =?utf-8?B?eHlOL3YxdEtjNDhtVXU3YXFqRmdkd0Z0c1QzNEk2YSsrek5uQythWjhJVXhN?= =?utf-8?B?WXljYWNySXpGelZmUHZWTUw1R0lTeWxpamk2a3EyR3B2Zy95MkJPQ1BJU1lj?= =?utf-8?B?THZFQnlkUStBcXNXd1Y5Q1RJUzVNbE00WHNoY1M3ZXdkVEgwRFJXVlpONlFp?= =?utf-8?B?b0lqVDZJZkIrRjJGdVY3cTNRbE1CeGxxOXExMmRsdyt0bTFiZUlHb3dKU1RE?= =?utf-8?B?b3ZTUWo2aWVpUEw3a1lmb0ZRN3UyY2JaSHNHRGtZYWVGZTRqNGcwV0JJbUZ2?= =?utf-8?B?YzhNajZEeS83cFM0Qy9nRVlWaDRvNm9yd3BrdCtuT0RaODAxN1JSbUVLeFNX?= =?utf-8?B?Si8wRWlLWitJaDJiQWZxb2t6N3dxaVVyZC9NRS9tRkpQODluV2hGSXFLcEhJ?= =?utf-8?B?cU8vamJyR05naUZVRjMrdzUyZFNEYlRGazM5Q0dEelhDM0FaNzM3M0Z3QW5k?= =?utf-8?B?b1UwMCtDTlBJOGNBRnJpT3BaNnBHTUVSZ29jeHpONHBWdFZxcWlKUitwZFFQ?= =?utf-8?B?dGRBekVsOWNCR0FjeFhjVE9iVkE0TGpOZVhiRVlRQlpib1dtWmFGUVdKdHJj?= =?utf-8?B?bFAzcFAwT3NlZHhLSEV3ZU0yRFhKVmxsNUtoMFEzQzlJN0JjZVByL3IzZ1pI?= =?utf-8?B?NGZHWHhxSy9KUE1DaGE3UnpTT2V1MFRwY0R3ZzBLN1prNzIwU2hTUW1odmhu?= =?utf-8?B?SFhYRXdUUTZUY0x4eWQyUUFLbVc3R2dybWgzOENyeUU2NWJScmtXUjBYUENs?= =?utf-8?B?WVNDZFlkd1VtcFJQdzFZSnV5QmhxbHRoRzFycXFDTzlvOE56dmVoLytNR1pY?= =?utf-8?B?dlpmMW5mSS9RaHhaSnc2aEQ4WGZVWmIxM1QxbERQTXJETGhRV21HUU5NRHJu?= =?utf-8?B?VFoway9tSW5ldEpFdkkrOTJiRkpJb1Bvb2xxUzZSWktLOExtcHRRT0R2SmdC?= =?utf-8?B?M2dRSGxOUmlNbFVqcDJjYTZzNU44WUorRTc0TG1DanN2SVRUVVBpSkc2bW1j?= =?utf-8?B?U1J5VERncmltMy9jd3djZGV6djAxRVpXVnFnMG51VkpNeit3MUdBc3Fwa015?= =?utf-8?B?RUZSS3IxMk5hbWkvVHpZWVhnRXFnVktObEtuZm0yOE9Lamlyc2Fwa2ZOSkQx?= =?utf-8?B?aWgxWU5MVEU0V2RIK1VwTTlkNjBjUzVtcXcza0NkbWd6TW8xQW5iUzJWTVUx?= =?utf-8?Q?mmUgOx1HaoXdDSvDDpbzPoRIftz?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51c5db4a-7190-4d06-9414-08db94d527ba X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 10:25:42.2165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BF7lCuqTeZPlvyP9pId2nuylIZctqXii9duR/H/f7A0SUvXEZ8oqXUlwged9gKxdeg0uxXwlW6n/G5Vs4UffK11SjMGdc/xj4aUdLt/AR1Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5930 On 04/08/2023 8:57 am, Xin Li wrote: > I haven't checked Xen implications with this change, i.e., does Xen > hypervisor need to adjust how it passes arguments to PV guests? This is an internal detail of how Linux handles data on it's stacks, isn't it? The Xen code in Linux will need adjustment to match, but this is not a hypervisor ABI (which obviously can't and won't change). ~Andrew From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:29:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:29:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577083.903938 (Exim 4.92) (envelope-from ) id 1qRs3a-0001O0-2m; Fri, 04 Aug 2023 10:29:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577083.903938; Fri, 04 Aug 2023 10:29:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs3a-0001Nt-03; Fri, 04 Aug 2023 10:29:18 +0000 Received: by outflank-mailman (input) for mailman id 577083; Fri, 04 Aug 2023 10:29:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs3Y-0001Nl-H6 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:29:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c27ba174-32b1-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 12:29:15 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 596214EE0737; Fri, 4 Aug 2023 12:29:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c27ba174-32b1-11ee-b26b-6b7b168915f2 Message-ID: <3c642d70-1b1a-5b09-fb34-127172f96118@bugseng.com> Date: Fri, 4 Aug 2023 12:29:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [XEN PATCH v2] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-US, it To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall References: From: Federico Serafini Organization: BUGSENG srl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/08/23 11:47, Andrew Cooper wrote: > On 04/08/2023 10:38 am, Federico Serafini wrote: >> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c >> index be2b10a391..e1d9b94007 100644 >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -5591,7 +5591,7 @@ int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns) >> * >> * It is an error to call with present flags over an unpopulated range. >> */ >> -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int nf) >> +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int flags) > > I think both of these examples want to stay as nf (new flags).  Flags on > its own is ambiguous in context, and nf is a common shorthand in our > pagetable code. > > And it will make the patch rather shorter. > > ~Andrew The arm code has its own implementation of modify_xen_mappings() which uses `flags`. I put Stefano and Julien in CC, so that if everyone likes `nf` I can propagate the change. -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:33:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:33:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577088.903949 (Exim 4.92) (envelope-from ) id 1qRs7U-0002oR-I3; Fri, 04 Aug 2023 10:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577088.903949; Fri, 04 Aug 2023 10:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs7U-0002oK-FW; Fri, 04 Aug 2023 10:33:20 +0000 Received: by outflank-mailman (input) for mailman id 577088; Fri, 04 Aug 2023 10:33:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs7S-0002oE-L5 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:33:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs7R-0007zJ-MG; Fri, 04 Aug 2023 10:33:17 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRs7R-00006G-Fs; Fri, 04 Aug 2023 10:33:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=i5i3A0jW9drB3euuJ61j+0z5/5MW6KwEZ/0NENb6JkM=; b=Iz2GQ0CrK+47yFKEig/WYl5Wy2 USAUWqIX/UNw/Ja++/Z4F9lGBj3BKX7Z9zbCkAQgHvMV5qhoYOMSA1ipgQqtnypfg+vdFzNv0mRXy j6p9NpN6eXi9167b82S1jp2mSlS+QsSbKLr6ym7HOOdxXrk2fTHY+limQV8mA7WV73B8=; Message-ID: <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> Date: Fri, 4 Aug 2023 11:33:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> From: Julien Grall In-Reply-To: <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 04/08/2023 11:17, Juergen Gross wrote: > On 04.08.23 12:00, Julien Grall wrote: >> Hi, >> >> On 04/08/2023 10:35, Juergen Gross wrote: >>> On 03.08.23 23:46, Julien Grall wrote: >>>> Hi, >>>> >>>> On 24/07/2023 12:02, Juergen Gross wrote: >>>>> Today is_valid_nodename() is always called directly after calling >>>>> canonicalize(), with the exception of do_unwatch(), where the call >>>>> is missing (which is not correct, but results just in a wrong error >>>>> reason being returned). >>>> >>>> While this change makes sense... >>>> >>>>> >>>>> Merge is_valid_nodename() into canonicalize(). While at it merge >>>>> valid_chars() into it, too. >>>> >>>> ... I am not in favor of folding the code is_valid_nodename() and >>>> valid_chars() into canonicalize() because the code is now more >>>> difficult to read. Also, the keeping the split would allow to free >>>> the 'name' in case of an error without adding too much goto in the >>>> code. >>> >>> I don't think we can easily free name in an error case, at that would >>> require >>> to keep knowledge that name was just allocated in the non-canonical >>> case. >> >> How about this: >> >> const char *canonicalize(struct connection *conn, const void *ctx, >>                           const char *node, bool allow_special) >> { >>          const char *prefix; >>          const char *name; >> >>          if (!node) >>                  return NULL; >> >>          if (node[0] == '@' && !allow_special) >>                  return NULL; >> >>          if (!node || (node[0] == '/') || (node[0] == '@')) >>                  return node; >>          prefix = get_implicit_path(conn); >>          if (prefix) { >>                  name = talloc_asprintf(ctx, "%s/%s", prefix, node); >>                  if (name) >>                          return NULL; >>          } else >>                  name = node; >> >>          if (!is_valid_nodename(conn, node, allow_special)) { >>                  /* Release the memory if 'name' was allocated by us */ >>                  if ( name != node ) >>                          talloc_free(name); >>                  return NULL; >>          } >> >>          return name; >> } >> >> And before you ask, I don't see the benefits to partially validate the >> name before allocating. Hence why I suggest to keep >> is_valid_nodename() as this keep the function small. > > Partially validating before doing the allocation is a benefit as it doesn't > spend cycles on validating the known good prefix. Which is pretty much a drop in the ocean in the context of Xenstored :). In reality most of the validation can be done before the allocation with a bit of work. > > Additionally your example won't validate an absolute pathname at all. That's an error in the logic. This can be sorted out. > > What about this variant: I still don't see the value of folding is_valid_node_name(). But if the other agrees with you then... > > const char *canonicalize(struct connection *conn, const void *ctx, >                          const char *node, bool allow_special) > { >         const char *name; >         int local_off = 0; >         unsigned int domid; > >         /* >          * Invalid if any of: >          * - no node at all >          * - illegal character in node >          * - starts with '@' but no special node allowed >          */ >         errno = EINVAL; >         if (!node || >             strspn(node, > "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" >                          "0123456789-/_@") != strlen(node) || ... I would rather keep calling valid_chars() here. The rest looks fine even though this is definitely not my preference. >             (node[0] == '@' && !allow_special)) >                 return NULL; > >         if (node[0] != '/' && node[0] != '@') { >                 name = talloc_asprintf(ctx, "%s/%s", > get_implicit_path(conn), >                                        node); >                 if (!name) >                         return NULL; >         } else >                 name = node; > >         if (sscanf(name, "/local/domain/%5u/%n", &domid, &local_off) != 1) >                 local_off = 0; > >         /* >          * Only valid if: >          * - doesn't end in / (unless it's just "/") >          * - no double // >          * - not violating max allowed path length >          */ >         if (!(strends(name, "/") && !streq(name, "/")) && >             !strstr(name, "//") && >             !domain_max_chk(conn, ACC_PATHLEN, strlen(name) - local_off)) >                 return name; > >         /* Release the memory if 'name' was allocated by us. */ >         if (name != node) >                 talloc_free(name); >         return NULL; > } Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:35:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:35:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577091.903959 (Exim 4.92) (envelope-from ) id 1qRs9X-0003Nk-Tx; Fri, 04 Aug 2023 10:35:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577091.903959; Fri, 04 Aug 2023 10:35:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs9X-0003Nd-Qm; Fri, 04 Aug 2023 10:35:27 +0000 Received: by outflank-mailman (input) for mailman id 577091; Fri, 04 Aug 2023 10:35:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRs9W-0003NU-9q for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:35:26 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f280a3b-32b2-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 12:35:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D339C1F8AC; Fri, 4 Aug 2023 10:35:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 72C45133B5; Fri, 4 Aug 2023 10:35:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3leVGmzUzGSKOAAAMHmgww (envelope-from ); Fri, 04 Aug 2023 10:35:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f280a3b-32b2-11ee-b26b-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691145324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dOrns3aHmALo5VEFClwKv4k5zfS2WAJjPptWmdcbyC4=; b=nJUBH/vfKgOAOX/DrcQxg/3LON8/S2QVTGUFTNj5TmMPsot0C2MVuZQ9oOIwVO6fXvdBWP P3WvqOKjRaXncnPnz0rjg252GKsyKWyMXKSIW9Xodd03iKD0nnpLnnBvD1REeSAZPY1+Vj m4AdwaH0KjPfGUS9OmT4o+uKILaY7rc= Message-ID: Date: Fri, 4 Aug 2023 12:35:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Andrew Cooper , Xin Li , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Peter Zijlstra , Boris Ostrovsky References: <20230804075734.8372-1-xin3.li@intel.com> From: Juergen Gross Subject: Re: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RIwth9b5TBuxUuYcpfetUToe" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RIwth9b5TBuxUuYcpfetUToe Content-Type: multipart/mixed; boundary="------------YNwf55S3kJowPLPrhqJxF54y"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Xin Li , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Peter Zijlstra , Boris Ostrovsky Message-ID: Subject: Re: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code References: <20230804075734.8372-1-xin3.li@intel.com> In-Reply-To: --------------YNwf55S3kJowPLPrhqJxF54y Content-Type: multipart/mixed; boundary="------------FpShGNDVei6igLcFbXS9kvzt" --------------FpShGNDVei6igLcFbXS9kvzt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjMgMTI6MjUsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA0LzA4LzIw MjMgODo1NyBhbSwgWGluIExpIHdyb3RlOg0KPj4gSSBoYXZlbid0IGNoZWNrZWQgWGVuIGlt cGxpY2F0aW9ucyB3aXRoIHRoaXMgY2hhbmdlLCBpLmUuLCBkb2VzIFhlbg0KPj4gaHlwZXJ2 aXNvciBuZWVkIHRvIGFkanVzdCBob3cgaXQgcGFzc2VzIGFyZ3VtZW50cyB0byBQViBndWVz dHM/DQo+IA0KPiBUaGlzIGlzIGFuIGludGVybmFsIGRldGFpbCBvZiBob3cgTGludXggaGFu ZGxlcyBkYXRhIG9uIGl0J3Mgc3RhY2tzLA0KPiBpc24ndCBpdD8NCj4gDQo+IFRoZSBYZW4g Y29kZSBpbiBMaW51eCB3aWxsIG5lZWQgYWRqdXN0bWVudCB0byBtYXRjaCwgYnV0IHRoaXMg aXMgbm90IGENCj4gaHlwZXJ2aXNvciBBQkkgKHdoaWNoIG9idmlvdXNseSBjYW4ndCBhbmQg d29uJ3QgY2hhbmdlKS4NCg0KVGhlIG9ubHkgYWRhcHRpb24gb2YgWGVuIGNvZGUgd2lsbCBu ZWVkIHRvIGhhcHBlbiBmb3IgdGhlIG9ubHkgdXNlIG9mDQpERUZJTkVfSURURU5UUllfUkFX X0VSUk9SQ09ERSgpIHRoZXJlLCBhbmQgdGhpcyB5b3UgaGF2ZSBjb3ZlcmVkIGluIHlvdXIN CnBhdGNoIGFscmVhZHkuDQoNCg0KSnVlcmdlbg0KDQo= --------------FpShGNDVei6igLcFbXS9kvzt Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------FpShGNDVei6igLcFbXS9kvzt-- --------------YNwf55S3kJowPLPrhqJxF54y-- --------------RIwth9b5TBuxUuYcpfetUToe Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTM1GsFAwAAAAAACgkQsN6d1ii/Ey98 xQf/eHKCtZfr2yrcxk/rSFLFayb4L8I2VDcv5ljxLHvPEsCm8nzjl/H3tOqNecMOjI1ezu16HS9m xVE6gTW2KDa17ZVxjXsuJlTpiaHhe13bXyJ957jDIW0gfEvbB342HmfFKeUe+8wSNvERvtPfXorE B9cPpNrQsn1Be8G2QWHtMNNrWtsMvLp+IjyQzIH2G8DRx30nd/rJT3YX3lrNOekp1Tj3V4IuX6e7 DUYHW0EUklkXexzsQfCzyznT63ZwWkydOS0UPXn4IfTKYTY3WIxqnZPkn5fjGZXGsd279avPYUYe G5NbUK4Dhj6mrxyFsQITsf+0ZR/REp/7CRUjaRHvgw== =HCZR -----END PGP SIGNATURE----- --------------RIwth9b5TBuxUuYcpfetUToe-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:48:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577096.903969 (Exim 4.92) (envelope-from ) id 1qRsLy-0004xn-1v; Fri, 04 Aug 2023 10:48:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577096.903969; Fri, 04 Aug 2023 10:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRsLx-0004xg-VF; Fri, 04 Aug 2023 10:48:17 +0000 Received: by outflank-mailman (input) for mailman id 577096; Fri, 04 Aug 2023 10:48:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRsLx-0004xa-AJ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:48:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRsLw-0008F4-L4; Fri, 04 Aug 2023 10:48:16 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRsLw-0000jf-Ed; Fri, 04 Aug 2023 10:48:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=54NkfgdlCAe4IBkP3+xatAn/Ck3HRr4zZ5qA60Udh9c=; b=aogGuu+z39Rw/JW857l4zF+05z R7flRj2VKYK10gLbb2WeHzN9rQ4V2bRkAB2CJumB4YHLs0GQbSqIkOAD7Kd1bQ1Ll1EateDwgV7gj UXs0h/bOwVSnZ2gMqXxiAKnpmgtipjFTWvHdVGgbBzab/gEHF2p2VkCvb6jNn9EHA1nY=; Message-ID: <58d49a0e-d6e0-43fa-9fa6-22965862a2e2@xen.org> Date: Fri, 4 Aug 2023 11:48:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v2] x86/mm: address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-GB To: Federico Serafini , Andrew Cooper , xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Jan Beulich References: <3c642d70-1b1a-5b09-fb34-127172f96118@bugseng.com> From: Julien Grall In-Reply-To: <3c642d70-1b1a-5b09-fb34-127172f96118@bugseng.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Federico, On 04/08/2023 11:29, Federico Serafini wrote: > On 04/08/23 11:47, Andrew Cooper wrote: >> On 04/08/2023 10:38 am, Federico Serafini wrote: >>> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c >>> index be2b10a391..e1d9b94007 100644 >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -5591,7 +5591,7 @@ int __init populate_pt_range(unsigned long >>> virt, unsigned long nr_mfns) >>>    * >>>    * It is an error to call with present flags over an unpopulated >>> range. >>>    */ >>> -int modify_xen_mappings(unsigned long s, unsigned long e, unsigned >>> int nf) >>> +int modify_xen_mappings(unsigned long s, unsigned long e, unsigned >>> int flags) >> >> I think both of these examples want to stay as nf (new flags).  Flags on >> its own is ambiguous in context, and nf is a common shorthand in our >> pagetable code. I guess you mean x86 code? I agree that 'flags' is ambiguous but... >> >> And it will make the patch rather shorter. >> >> ~Andrew > > The arm code has its own implementation of modify_xen_mappings() > which uses `flags`. > I put Stefano and Julien in CC, so that if everyone likes `nf` I can > propagate the change. ... I would not say I like the name 'nf'. I would prefer 'new_flags'. Anyway, unlike arm, the x86 version of modify_xen_mappings() is quite large. So I would be OK to switch the Arm code to use 'nf' (only in modify_xen_mappings()) for the sake of avoid too much code churn. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 10:56:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 10:56:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577100.903979 (Exim 4.92) (envelope-from ) id 1qRsTp-0006S5-QP; Fri, 04 Aug 2023 10:56:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577100.903979; Fri, 04 Aug 2023 10:56:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRsTp-0006Ry-Nh; Fri, 04 Aug 2023 10:56:25 +0000 Received: by outflank-mailman (input) for mailman id 577100; Fri, 04 Aug 2023 10:56:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRsTp-0006Rs-2S for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 10:56:25 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c9d7087-32b5-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 12:56:22 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id BDD174EE0737; Fri, 4 Aug 2023 12:56:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c9d7087-32b5-11ee-8613-37d641c3527e From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH] x86/processor: drop bool_t from mcheck_init() parameter Date: Fri, 4 Aug 2023 12:56:15 +0200 Message-Id: <26b30382b1b3daffb829ceb34d39c14185e9e147.1691146541.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop bool_t to make the function declaration consistent with the corresponding definition. This addresses a violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 0989748be6..ae43ba5dc9 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -415,7 +415,7 @@ void noreturn fatal_trap(const struct cpu_user_regs *regs, bool_t show_remote); extern void mtrr_ap_init(void); extern void mtrr_bp_init(void); -void mcheck_init(struct cpuinfo_x86 *c, bool_t bsp); +void mcheck_init(struct cpuinfo_x86 *c, bool bsp); void do_nmi(const struct cpu_user_regs *regs); void do_machine_check(const struct cpu_user_regs *regs); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 11:36:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 11:36:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577106.903988 (Exim 4.92) (envelope-from ) id 1qRt6b-0002Uk-R1; Fri, 04 Aug 2023 11:36:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577106.903988; Fri, 04 Aug 2023 11:36:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRt6b-0002Ud-O4; Fri, 04 Aug 2023 11:36:29 +0000 Received: by outflank-mailman (input) for mailman id 577106; Fri, 04 Aug 2023 11:36:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRt6a-0002UX-JI for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 11:36:28 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0625.outbound.protection.outlook.com [2a01:111:f400:fe0e::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2575518e-32bb-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 13:36:26 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM7PR04MB7080.eurprd04.prod.outlook.com (2603:10a6:20b:11b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 11:36:23 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 11:36:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2575518e-32bb-11ee-b26b-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvVLZxD/lP36qNJrPkTgikBncJ+6uZBfdTHgav/2hUXoZdMJx7f6irDAQvr/sKKgczm1f3yQY7pj8eJAza1zwMZluPO6od2iH0k91B8WySuLPDYHhVCWCXH2O4AGD9ehEQpU97ZwtTC7YjMX5WrOrQSfAgc6PaqSIe2LTEd/xEJz0Pz48b98xGt21zfENNPsddSgUBr9d9n1PFvWsrfoepjVccJMWMkHGePMWiVbfK7JoPsSl5ML7Jlpi36XQYeM6Kp8JLk1F5qAFozRFFlXT9P7dxcmAwdOHFGMa245LA0IPeUBsGAbzLNAyBlnrOjn1MKok8XoWPbGVYJBTk8RMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HV54gh0Z4zJqoYvIH9ELbPuFlkJX6szzPHSkoj+N1V8=; b=Q8w3x2oAlAbB/UcNEkz4XOkTIs8NlnXLyPrdzlrjXLaYMMuLiPaO7gmMBDdzDHlKjC9KoYdRIYQzkitQcq2jLfLkbQ5mNLQ79xwk+dKgP0wl249xUKMGXkfPQ88ibUywpEtQVNCG04sCIDhVJwsUOjldX7EzBdaelIFIZjBRBRpDkYCLoxaS1dc1JR22XA5BVN1f2qSFO09wu7LV9i6FOS9yaPCGOd3JWvFMmGlKk1/hPjX1YfCdCv1pbuhw+weRT4OxZ8LjTvq2E80jA9c3QyPt7NcjTCwjjKxrxikdsXzWjqtchHy4bFGiRLPHw6ci0xP4KRib6Ei6X2d1rDJN1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HV54gh0Z4zJqoYvIH9ELbPuFlkJX6szzPHSkoj+N1V8=; b=XsT+YLTcXn95sj0pRr8mwZVw5OSa2rN614ON1L3w1Vs/WoWDMbqdfu0n9ta4cPKVTTZ2wivXrxFUrWEo0RY6pcCx4pCWlhJABGBHk+JIdQhO8wL6wwHq5VFH4QUvChCm51VxU5DlqzcH/RzFtd9lnrIS9xp4jh9tUUgoWXH8K1IJOA8y9RUHNxNriZKfUyUQk6B3loNLS8VS1pAZKZQ/EkSZ5ze/o+M+IBxVr8Z1SCcfqPrMNWQo1Nw1e9TyYuQMqrkO7mP0dLQIPZ4dybUJ3GIwdJLkisiT2szzF6PTrVm05nsLq1dhZLwckIwGLGlkHeQoBVFa/Ko8NoCvhkTP3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <464d71e4-9047-0461-afdc-8df8b8f569fb@suse.com> Date: Fri, 4 Aug 2023 13:36:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Jason Andryuk , Daniel Smith , Christopher Clark , Xen-devel References: <20230803203650.1474936-1-andrew.cooper3@citrix.com> <722dfba8-a768-55c1-29bb-2d8525282b4b@citrix.com> From: Jan Beulich In-Reply-To: <722dfba8-a768-55c1-29bb-2d8525282b4b@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM7PR04MB7080:EE_ X-MS-Office365-Filtering-Correlation-Id: f145ff9c-e976-4d65-d7bf-08db94df078b X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +ePjwY4U12tyhAofPxuuYm6rVetwWW5MC0DllNtqX2LH+iHZXWX6Bnh+uEJxoZO//jvjR7s8Q26qJ517SuVXSMhvG5eylDNEx9zK1RaNyfO9hJ3TH/J9KjgJYASq1ey5rWuohNo8CJoGtdHIrkYWcTR3KfVt5p4l2EoyT0Qu4ujZx1CdmoBSMx54hrTjm4GYfBO2Pz8xq6gFmRG4XGC811kxkRSYoMVVC9mB7iuyI08pzT+aa7sYTj82ELrGu8QsKwV+POF9hq9HuLZxF3dNTyHDyrqGDjy+jZ/v/6TvzFnA9/CyfOLTUzkadmpKPJVylFa6ldbhUNG8C2prEAjhdkOGoQrRGKYr9iXu7nWnfygV8eP/8FesUCxy/TqSLqUHvFL2YHAFX+KxCoAgkSMYG9Z7mLNuKPPJY15p/H+Hwlrrj7QF5NsyPmTc7bWiUOwbFS8lf+0vftZen7dTkVabyXX4YM8XAaaL0Xzme4QukPiXp9uA+7YvdrlSko8Ber4F4g/7iZZTmRz9Mx/cA5YO2KbZU/aOjlxuyQEzpXAEOPNh4Fe5snIUxLxlosXcTnLPKJqyybTvlmyUZjXWJhlq0Hf8oxoQgIloK3sQGeQc2JPzy58KKGBObrWmFqMGyxDg5nsKXle/r8x3ZtS+KT9jxw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199021)(1800799003)(186006)(2616005)(53546011)(26005)(6506007)(8676002)(316002)(66556008)(2906002)(5660300002)(66946007)(66476007)(6916009)(4326008)(7416002)(41300700001)(8936002)(6486002)(6512007)(54906003)(478600001)(38100700002)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzJuV0VPZTkrbWRQQXpkWUtDRXRvZEpRc3VQRmRxSUM0ZzlrUUZ2OHB5ankv?= =?utf-8?B?WVNTTHZFUis4UEx6TGFLMytRRGd1Q2dDNWpXa3ZYQzdLbC9vTy9uT1hsMDl6?= =?utf-8?B?R1NUWHBUYi9LVTY2dnMrRy93Umt3UHZzcUYzN1E5SXhNbmtOc2xZaFJ0cXBI?= =?utf-8?B?WTZydWpYdEZ2R1pNcEhONjVaamlnNWpnRm5pTzEwektmWFlmUGZJYmsrOHI2?= =?utf-8?B?WjU0VDEyMkFTd3pOMXg2L2tOcmhOR04vcklFSzF6dm1sNVhORldid2c2cWd5?= =?utf-8?B?RlhHQkZWWGxCNHQ1ZU1PQXRFZEhweFR2TVFaTkRIbHhSUFBPYWhadlE5SGsw?= =?utf-8?B?OTFjWS9UZjgyRUJ2Z2dSVGtNV3RRQmxiMkRIT3IwYVhZcVJoVjRmbGo0VWN0?= =?utf-8?B?Z3Btc2hESzkyUmJOVDBBU3RjRFBBME53ZkY0SURKR2lwU1YzQThqRzR3Y2Jh?= =?utf-8?B?aWxxU0FaQW50c3YzY1poQ01aN1E2TERTVHBQOHJuSXJKcFA1NkNEbFoyNGZP?= =?utf-8?B?K0NscU5WRVBSOVhjSmFOWHV4cU0xNEwwc3lPbnQrTTRPUWRhMFdpTDk4V2xr?= =?utf-8?B?bGNiV0JWZjBQVDZldHVONVc1dFVTU1hUSzhWeGk1K3N4T1ZmakJpSkxQTmFZ?= =?utf-8?B?OGtGMStzZDFxVzdxRHhnVjZTSzNNMDJEN2RXMGpPU0FvUWlXSFIrUnNaNVh1?= =?utf-8?B?WGtJeTFoSnpmb0NraEtDUXp6QUl5TEdrUlFDY05aSnlrV2FpQVRoSUlSaUFk?= =?utf-8?B?TFZiMzIrUE56VDZjclh1NDNwUEpjRDF3eWk1bVFvMGlVVEdGKzRsWk5LM0xz?= =?utf-8?B?dUhpK1ZZUlRPeC9Sd0pqT1EzRDNEL3hXblhaS3pLdWYrTVNrRlNoMmFXN1Vo?= =?utf-8?B?WHNWU3llQzFFcWd6amFNcEZRajI1WC9ib0Y5QzBlYjhsTHFaK1FnUkg3Smpa?= =?utf-8?B?S2kweE8vMWcyNmp4ZDBVanUwYzlrK1dYSFB2QmZOejBMNHpEUVhONFBvWkg1?= =?utf-8?B?bzh3dVIvNTNYeGdydzBoYzA2TEp3d1RjZ1M5SGpaUlRrM2JBZ3RDSThGQm1H?= =?utf-8?B?R2NBM3FPSnUyTVJDQzI2QmFYTkNKdnVKUlV5ZjIzQ0hLQU55Q1c4Y1hRZFRx?= =?utf-8?B?WkN5aTFXM3FBS21KUEV2OHdrQUZBdDFoVGI3TWxyT3kzL3lqRzRRWEs3NURn?= =?utf-8?B?WWFaNVJNTStzYjdQeXM2RTZKYUZDY2Z0N1ByeTFaOU5CQlVmUTFBY3FNSDND?= =?utf-8?B?cXRKcCtMc3VwYjNnbVhTLzNWOG5tLzJGKy9CczBNQVB0V3pCSTJJcStnZjUx?= =?utf-8?B?NFRyUHZuOXpoRTAvakh2NXcyeUR4aG95bEE1VnF5eTNPd3ZKYUloSUNFUWFZ?= =?utf-8?B?WlpvekxUeDI1SXlTY0hKbDc5R1Rxc3FNUDA2bUpyNWVVb1N1SUU0dWRpUEpn?= =?utf-8?B?dHZYSm1MWm1UdVF6MnF5OTg3Uk1mekV6eE5GZEZvakliYmxPWk9MdytnYlZl?= =?utf-8?B?M0FQNzQ0aTJrU1I0ZnhZNG85ZU82bjNBUHZkTjVUaGZkK1JyVXMyaCtmbVkw?= =?utf-8?B?N2VFSGozMmU2SCtVT1U0TkhmbDJuTVUvWEU0MTkyclo0Y2VCN3crNEdhYkdO?= =?utf-8?B?Mk9VVXR4M1ptaXJuZ2x6WDlyVllxencveEQvRkZxeHBhd3JGVTUyZjZ6NFl3?= =?utf-8?B?T0NoTE81OHZXeXk2dzJCamZrY2Y5a0dpS29HZ2VNRGVjbDlIclV2OC9Vd3li?= =?utf-8?B?eFFYbXZXblBPK2hBWVVoUm83NVJpbHFhVElZeEp5cEZUa1Y0YURON0FVTjZP?= =?utf-8?B?c0VSdkFTZDg0Y1NwTXNXSjV1YzNpNjZrUGVvb3k5WGQ2UTF1TUlaYUIxS1Ar?= =?utf-8?B?b0d3VnZLdUlvd3lBUUZzOFRJbzhNNWQ4TTRFc1FqSHBabmJHTEp0SEZ0b1I1?= =?utf-8?B?Y1AzV3h6VytuWEpvamo5VWIvNWFlWGFvU0xpMUp5T2RnUWFTdW4zUG5nU1pz?= =?utf-8?B?aEtXQ0JVZ3cyNFhZMUpBeU15NHJxNjl4TjM3eFhWaXhPWVNxeWdPbEg0eVpz?= =?utf-8?B?Sis2ZlViYjdiTXl1RHdKN3FHbHRoRGZvSkFSWnFkU29XWHcvdWlnd2JJVnB2?= =?utf-8?Q?tp1TUMDWVW3NBrYKW5aHq/Ahd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f145ff9c-e976-4d65-d7bf-08db94df078b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 11:36:22.9427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9vrtKESVd8AsrN7AA6Jrbstg1dHD7cLQIeyCReaabjLy+nSJSNxB0SsgqYdkLxfsY2P/nPeh/sQBJTzWlke1IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7080 On 04.08.2023 11:29, Andrew Cooper wrote: > On 04/08/2023 8:23 am, Jan Beulich wrote: >> On 03.08.2023 22:36, Andrew Cooper wrote: >>> The opensuse-tumbleweed build jobs currently fail with: >>> >>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': >>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NULL [-Werror=address] >>> 56 | if (!key->p || !key->q || !key->u) { >>> | ^ >>> In file included from /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17: >>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12: note: 'p' declared here >>> 28 | tpm_bn_t p; >>> | ^ >>> >>> This is because all tpm_bn_t's are 1-element arrays (of either a GMP or >>> OpenSSL BIGNUM flavour). The author was probably meaning to do value checks, >>> but that's not what the code does. >> Looking at the code, I'm not sure about this. There could as well have been >> the intention to allow pointers there, then permitting them to be left at >> NULL. Who knows where that code came from originally. > > Do you agree that the patch is no function change, or are you saying > that you think I got some of my analysis wrong? Oh, I'm sorry for the potentially ambiguous reply: I agree there's no functional change. I'm merely not sure about your guessing of value checks being meant. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 11:39:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 11:39:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577110.903999 (Exim 4.92) (envelope-from ) id 1qRt9n-000384-DF; Fri, 04 Aug 2023 11:39:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577110.903999; Fri, 04 Aug 2023 11:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRt9n-00037x-AP; Fri, 04 Aug 2023 11:39:47 +0000 Received: by outflank-mailman (input) for mailman id 577110; Fri, 04 Aug 2023 11:39:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRt9l-00037p-Cf for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 11:39:45 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20619.outbound.protection.outlook.com [2a01:111:f400:7eaf::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a9cad57-32bb-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 13:39:43 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9552.eurprd04.prod.outlook.com (2603:10a6:20b:4fb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 11:39:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 11:39:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a9cad57-32bb-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqcapm3KGkpf64TDOmb0PdRfdKBMDX4bBP3TAQDNu9+Y5EC2DxAmqDb78HgsYkQw7UYFSnRhh4VR4ODbm3DFRw5qYo6uyjqlwC9jDqxdI/ToLi12SF4FS6x9jKpGgYPtj/SMlMBUFVH8QydfkpfpLrAABf1GZ7vf47O90tjmdKapF9N2S6faT2zWp2H8xAjN+brEh/rlJhG1VCit4CV5rdcvkrZLLU8DkvmMfdZ7VPNfRs1gMOnBg/Ym7b7vDbrWVdic1xY+CuOZcQ6HrJp987axrGOy2lFst6wG3RLKc6tSSxADjD+KFOA/gWuNGvBlpCPNok5f/o/9jUQLko54xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lN9SFW9g/Qx3UKEHTnyDh2ynuN5d2QJ+aszhumNIb/U=; b=FDVrdUsmsJZqsOK39cxaUD2E1HZIW/eksYW7KW+UpBM5xYGzz/nlqXz7Yc19FyMCNl+RNTjPzYUShhojnx6hzkJXVpyTs7yKWVd7vkqZst84Ucgc1rzQX6Y0DFZetKz3AzA5A0LlRzCahF5GRm6sA4dEoKzuwBdwCbRd/v0PS43HKNJDxOeS18REp9M5Xd8e+qIoAIZQH8Z7YlG9dqXEw4PxPBnamh/nUpsFoNno+Sz6kS20zAp25Mefp7ATLiBfEYotYAlONySjmbcGCQQquOFGx5spn1d9P+IXUbHcxOYEhSM65Ki9QoN4kxm7eNB5UA2JJEpw6qn/CjbysMiZNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lN9SFW9g/Qx3UKEHTnyDh2ynuN5d2QJ+aszhumNIb/U=; b=oTZkJ6j1mjOp3cRWXLhEBe6Jtup4Xe5LAkCbm2y1TeFU2RYQClaNdUrwWK8+QEiIH0eqShD565Z/xqLqf43HEJaVjK9esvsPVVD1hog05acQLXgyc8HO6KKcJMuWSmD8sebFkBS36V2xUvlXBgKRIXbWMrL6rea5mArzFV54H+r5u1u02wqDf2i9/4nAhieZ5+H1jnaa2Y1RGGkXyc01A0NvBwvRpi2tZYP92dyLgwIgNzBJUoMBNM/CkWdDfDhd3hF6df2fJWebNa/I5iM3WMqeQiVXjtWGSTOFU3HJuPh8s6mdyU4x0RLJefHNK7WdTQTrx6OTCzRiZu0zhte8IQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <95a6d085-cbb9-ecb6-134d-6e4d994bfd35@suse.com> Date: Fri, 4 Aug 2023 13:39:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: Address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> From: Jan Beulich In-Reply-To: <00fb1a58849ec08534465df2f8ca2284@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9552:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d445304-cdc5-47ba-4a4d-08db94df7db3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hkU3JijJATfzjY5AHubQDMM26MPhGlwxWFxAttNsAiiIFCQZY6IyGMEydZeLG75vSPuSpzXW/9PNywxS2Z3epq4UYiaH5kFmKo5dsJ3RB/+oCVZQYeGQ35ck1wLB6eIPAPVNRY3TUodrIDzTWaiAvcGJccjqFsqjMWuBAnyOEZsV6Zzr/8WHiVJ6a9mdAYcpdGywxtkVHs7Y007HTGLHD+l3JMjnCZ41WfxD9DPyU5ZgtWoY7HlFEFieq1gMwpyp0/XtLfWLpAjOnePtJUbrj6w1H2VEV0Cxnv6VAaT8fDLvf1HxKz0lnk1dNneG9HktpcmWcpvsYKbBb86panRitY/o8MUFJNwdZzGLJcJdc2COyDEkLYnMpPtz9EF2o9/kZnnfV3BME4oaP8nK4iaWw39/RWqBGoDdkQafboS8uTCaIxRkoytNO3azzAdml9y58uUzWytf1JhZE8Xkl1NF7EG8JO6E0RohNbZtWpVr6wQJiloUcehnZxtAW73RWAh/UEfctjokNncPWheUFESTpXA06lb8yg/btZRnjnGtxSqs7jDf3x2wM2heqJKvVOpAKh4GMv7e38R+z/v2aFdbEZc1B6SxZPV2vaYAHCYNT3mBgVgtTMwcTul6LZimGt3PoR+u8a6C6CCCkmqcbnHGUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(376002)(39860400002)(136003)(366004)(1800799003)(186006)(451199021)(86362001)(31696002)(36756003)(31686004)(54906003)(478600001)(38100700002)(6512007)(83380400001)(2616005)(6506007)(26005)(53546011)(6666004)(6486002)(8676002)(8936002)(41300700001)(6916009)(4326008)(66476007)(316002)(7416002)(5660300002)(66556008)(66946007)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEJKVXVCV1RWQnhjTlFYb0MzVWZYSlY1cTNvM1JVaGE0ZFlVL1NHVXdPZ0xj?= =?utf-8?B?RmVIeDl2Wi9zY085WE9nR1FibWxLWWMwUlZFcithVzFhNGdNOEc1bEMvbkJn?= =?utf-8?B?Nk1uWlNPU0s1K3BOUFJhMUFEZGZTQzJGNk5ZTEFNVzhMMUI3MEo5eUU4Rnhy?= =?utf-8?B?eXdlMWJJQTNUcUo2ZkVhRmkwNHJyVWhJdmlqT25jaDVNek9QOS93M3dDOWtP?= =?utf-8?B?ZW1ISU5kRW9EMEJOSzNraCtMN21XaVNSUzhXQ3VOZ3Y5TGZ2dUtmT1oyS1hH?= =?utf-8?B?d1VldHpMNVdMYTFibmNMS1UvamswZGlqdllnWnhFWjluOXVnczJ2bDB5dDlP?= =?utf-8?B?RmNmT3NqUi83UXhPdE5qV2NDcjl1NUh6d3dTS0RydmIrSnNRaFc0NVNaKzNW?= =?utf-8?B?N3hmNFRjMWRVZ0ZtRXhkSFF1a3NjV05HYThQeDRoekFrMW9lMHRDMmNhd3Yx?= =?utf-8?B?cVRMRlQxUzhXcG5NVmgxWTNZZ2F5bUZWTkpSRVA2dGwzazNHRzZMRFc4NUx3?= =?utf-8?B?TDZQS3B3R3lHbE5yckVxemRjb3A4RURSRkg5ZU9pbll0Sk9xbXo0MnhVZmZi?= =?utf-8?B?dXlYZGE4aUZKZjF2OXliQ1NVSElJSy9iN0d6L2FKQXkvVjd5dDBhR3RIN2x4?= =?utf-8?B?eW82VlM4bjZDZXRhSzBIK0h4MWV2akJmVFhyRGpJSnliOGoxbU00RUZCRzZi?= =?utf-8?B?YndzM0dnUm8venlMZFBpQWplQzZKZ0c2NGxnZCtUV3lRRWpyYXRYTVV5QWxl?= =?utf-8?B?OVUvNk5PcUJwUFFxZGZOZzU1M2hTQXppREhWVHhkWEVKYnNvYWlpVWZXMmtX?= =?utf-8?B?OXVrbmlQWkxGTUFzSzFEZFhpVEdaY2JYcUpYYit5b3QyNXNZdklsL2V0Q2lD?= =?utf-8?B?SGJ2Z0IwM1h4L0hJYjA1SHBPc0g2TE9vYk5hVjJXaVQyTDIydzZqVDlhcnhn?= =?utf-8?B?dkg5dmY4K2pYTjJFQjZXUG1BazNJYklqRldtaE1mZFQ2ZFVyZVBManVJZGo3?= =?utf-8?B?aytLQUI3OE4rK24vTFYrSExYckdWRnFPL2l2OGYrMmJGUWtrRE1DT0dLdUpm?= =?utf-8?B?NGk2eXlhdVhiL1EyYUN3cy93dk9YT3U3Rkw0Y2c1bC9qKzJIL2llT21UeTdr?= =?utf-8?B?cmpBZ0FXVDh1TGlEQ3JBREpzakR2L0VwbHJIYXMvMm04WUFBck1mdkh6a0hU?= =?utf-8?B?MFkrQVBhUEpya0tBalFmQUs2LzZCTnZrTk9jRU54SGJEYmhadGxMVlZtRVJw?= =?utf-8?B?KzB1TDRIVHhSTXVmYlNLcC9GWk5ONUpSR3hIUU1QOVVHWlFFenc3MVN3ajVE?= =?utf-8?B?WExjREw5Y0JBVFRiWmxyT1FoZXA5MnhkbVY1WFRHQ0R4bkFHMmE3U3U0Q2Qy?= =?utf-8?B?bVErTjhHS1A3VjU0ZTVCYlo3TGZ1TWxCVmVha3dpMGFPeEZmVUVCOXBod1JH?= =?utf-8?B?WmNYNEc3V3hEWnZFVnJaemVXcXdGL2Jtc1NqU3FHZzYzWGdUN0FrdlMrdUF0?= =?utf-8?B?aEordzVCSk9vNzlyR0IvOFU1RUxkVHhjNDlxMGQyTUJ2U2pmR1YwbWEza05y?= =?utf-8?B?SXZlem5MNEdUZWhKVUplWVVpMzdnQi81QkV5eVVQbUQ2TithT0tKZWFwZ3pF?= =?utf-8?B?VFN6VzFjYUJBdUNqMFl0KzFOcGVuSC9uekF6aTdINTBWSForMUpCVFJCZUdU?= =?utf-8?B?OTc1aU83Y3NzOEUycE9zczZGN2RSR0U5NU9FSHhvWnRETWZUUGdFa1hnLzl6?= =?utf-8?B?aGFMUCtGd1NNN3ErSHRaaUEzU051aXM2NXVwUXI0dHNodTlyV3Rhc1grYVdM?= =?utf-8?B?MjlBWU1maVROMCtQa1kzREhnQll0bkRTN1V4UFBKUEJuMkNhUFU5NFk2ZlNW?= =?utf-8?B?ZkFyVDBmSDdHQkowMnlZQkRFZDVVT0VZVHhWT3I2WnR6c3piajNDVytPRGF5?= =?utf-8?B?dmk1cTVVVldGZ0toRnN4YlFWOVM3TUk2UWFzdHRrRFg1a3Rjd3VoL0V4ZVZW?= =?utf-8?B?U01CVlRHanFXY2p0YldOYmtGSm5UczNoZElZajA4aS90b1FrU2twUFNWbWo4?= =?utf-8?B?ZmhXUEIrcnJHYVNaZWx1bzU5YWFKS2ZyR0tTcGJxaFl5NkxMcDVGd005eXdD?= =?utf-8?Q?A6eXmQiJkVfLp0y8qpN641NJ0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d445304-cdc5-47ba-4a4d-08db94df7db3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2023 11:39:41.1465 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rA7e90Jg8f9smvweWKUFC8+h06TePyCrs2VSa198sfYV/KqVkt6QTVnABMWnej254XbT4nQoJLH7zBBx3/Q2XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9552 On 04.08.2023 11:47, Nicola Vetrini wrote: > Upon further examination, I identified the following patterns: > > 1. Functions defined in .c called only from asm code (e.g., the already > mentioned __start_xen) > 2. Functions/variables declared in a .h, defined in a .c that does not > include the .h with the declaration > (e.g., 'fill_console_start_info' is defined in 'xen/drivers/vga.c', > declared in 'xen/include/xen/console.h' which is not visible when > compiling the .c). > 3. Variables that are either extern or not, such as 'acpi_gbl_FADT' in > 'xen/include/acpi/acglobal.h', depending on > DEFINE_ACPI_GLOBALS > > Below are the proposed resolution strategies: > > 1. I would advise to add the declaration in the relative .h, to support > automatic consistency checks with the > implementation and a quick reference when touching the asm. That'll need discussing first. > 2. To comply with the rule, the header with the declaration should be > included. Also note that there are some > corner cases, such as 'get_sec', which is used in 'cper.h' without > including 'time.h' (which should gain a > declaration for it). This one of course wants fixing wherever found. > 3. One possible resolution pattern is including 'acglobal.h' twice > (either directly or indirectly trough acpi.h, if > the latter does not cause other issues) like so: > > (assuming DEFINE_ACPI_GLOBALS is undefined here) > #include "acglobal.h" > #define DEFINE_ACPI_GLOBALS > #include "acglobal.h" > > this way, the rule is followed properly, though it's not the prettiest > pattern and also clashes with the objectives > of D4.10 ("Precautions shall be taken in order to prevent the contents > of a header file being included > more than once"), but then a motivated exception is allowed there. Not really sure about this one. Jan From xen-devel-bounces@lists.xenproject.org Fri Aug 04 11:44:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 11:44:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577115.904008 (Exim 4.92) (envelope-from ) id 1qRtEc-0004Zc-Vy; Fri, 04 Aug 2023 11:44:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577115.904008; Fri, 04 Aug 2023 11:44:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRtEc-0004ZV-TF; Fri, 04 Aug 2023 11:44:46 +0000 Received: by outflank-mailman (input) for mailman id 577115; Fri, 04 Aug 2023 11:44:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRtEb-0004ZP-Pu for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 11:44:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4e1e9bc9-32bc-11ee-b26b-6b7b168915f2; Fri, 04 Aug 2023 13:44:44 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 9FE4D4EE0737; Fri, 4 Aug 2023 13:44:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e1e9bc9-32bc-11ee-b26b-6b7b168915f2 Message-ID: <916de98d-95c5-988e-2fe2-6d8cfaf7c90e@bugseng.com> Date: Fri, 4 Aug 2023 13:44:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [XEN PATCH] x86/processor: drop bool_t from mcheck_init() parameter Content-Language: en-US, it To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <26b30382b1b3daffb829ceb34d39c14185e9e147.1691146541.git.federico.serafini@bugseng.com> From: Federico Serafini Organization: BUGSENG srl In-Reply-To: <26b30382b1b3daffb829ceb34d39c14185e9e147.1691146541.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/08/23 12:56, Federico Serafini wrote: > Drop bool_t to make the function declaration consistent with the > corresponding definition. > This addresses a violation of MISRA C:2012 Rule 8.3 ("All declarations > of an object or function shall use the same names and type qualifiers"). > > No functional change. > > Signed-off-by: Federico Serafini > --- > xen/arch/x86/include/asm/processor.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h > index 0989748be6..ae43ba5dc9 100644 > --- a/xen/arch/x86/include/asm/processor.h > +++ b/xen/arch/x86/include/asm/processor.h > @@ -415,7 +415,7 @@ void noreturn fatal_trap(const struct cpu_user_regs *regs, bool_t show_remote); > extern void mtrr_ap_init(void); > extern void mtrr_bp_init(void); > > -void mcheck_init(struct cpuinfo_x86 *c, bool_t bsp); > +void mcheck_init(struct cpuinfo_x86 *c, bool bsp); > > void do_nmi(const struct cpu_user_regs *regs); > void do_machine_check(const struct cpu_user_regs *regs); I can do better and drop bool_t from the entire file. I will do it in a v2. -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 12:05:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 12:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577130.904018 (Exim 4.92) (envelope-from ) id 1qRtYm-0007OV-Og; Fri, 04 Aug 2023 12:05:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577130.904018; Fri, 04 Aug 2023 12:05:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRtYm-0007OO-Lx; Fri, 04 Aug 2023 12:05:36 +0000 Received: by outflank-mailman (input) for mailman id 577130; Fri, 04 Aug 2023 12:05:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRtYl-0007OI-MO for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 12:05:35 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 369ce50f-32bf-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 14:05:33 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EB3B62186B; Fri, 4 Aug 2023 12:05:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C10A513904; Fri, 4 Aug 2023 12:05:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MqdELYzpzGQ2aAAAMHmgww (envelope-from ); Fri, 04 Aug 2023 12:05:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 369ce50f-32bf-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691150732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ki4eE8KIJGI7HsBWhntynRPipCidvB8DSebuHEtMRdc=; b=TnMEI2zK1EtgKbVg9MlMVT8fdfAz5+3JVSs3CT60CGFTfjBhhR19aTOMsvvNw7bxUnAzcc zYLVtroEGlbjXWAVVqKzjhjbDFdooVfQvkWNJJRboB7IPANs3T89EKoOgvHbKBxoIGjLNa 4c5NKtJxbhQHXaL9+4w1YUGyudOoV34= Message-ID: <8f9a76fc-283a-e3f3-d19f-04401389a7de@suse.com> Date: Fri, 4 Aug 2023 14:05:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> From: Juergen Gross Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() In-Reply-To: <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------qJ7UYErQpPpJ0NC64ye50hJo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------qJ7UYErQpPpJ0NC64ye50hJo Content-Type: multipart/mixed; boundary="------------6fMLqb9HaWUIBj2asiWGeC08"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <8f9a76fc-283a-e3f3-d19f-04401389a7de@suse.com> Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> In-Reply-To: <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> --------------6fMLqb9HaWUIBj2asiWGeC08 Content-Type: multipart/mixed; boundary="------------rhPx0TzYaFyAMCT9HPkaQvWR" --------------rhPx0TzYaFyAMCT9HPkaQvWR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjMgMTI6MzMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA0LzA4LzIwMjMgMTE6MTcsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAwNC4wOC4yMyAxMjowMCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+IEhpLA0KPj4+DQo+ Pj4gT24gMDQvMDgvMjAyMyAxMDozNSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+Pj4gT24g MDMuMDguMjMgMjM6NDYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+IEhpLA0KPj4+Pj4N Cj4+Pj4+IE9uIDI0LzA3LzIwMjMgMTI6MDIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+Pj4+ Pj4gVG9kYXkgaXNfdmFsaWRfbm9kZW5hbWUoKSBpcyBhbHdheXMgY2FsbGVkIGRpcmVjdGx5 IGFmdGVyIGNhbGxpbmcNCj4+Pj4+PiBjYW5vbmljYWxpemUoKSwgd2l0aCB0aGUgZXhjZXB0 aW9uIG9mIGRvX3Vud2F0Y2goKSwgd2hlcmUgdGhlIGNhbGwNCj4+Pj4+PiBpcyBtaXNzaW5n ICh3aGljaCBpcyBub3QgY29ycmVjdCwgYnV0IHJlc3VsdHMganVzdCBpbiBhIHdyb25nIGVy cm9yDQo+Pj4+Pj4gcmVhc29uIGJlaW5nIHJldHVybmVkKS4NCj4+Pj4+DQo+Pj4+PiBXaGls ZSB0aGlzIGNoYW5nZSBtYWtlcyBzZW5zZS4uLg0KPj4+Pj4NCj4+Pj4+Pg0KPj4+Pj4+IE1l cmdlIGlzX3ZhbGlkX25vZGVuYW1lKCkgaW50byBjYW5vbmljYWxpemUoKS4gV2hpbGUgYXQg aXQgbWVyZ2UNCj4+Pj4+PiB2YWxpZF9jaGFycygpIGludG8gaXQsIHRvby4NCj4+Pj4+DQo+ Pj4+PiAuLi4gSSBhbSBub3QgaW4gZmF2b3Igb2YgZm9sZGluZyB0aGUgY29kZSBpc192YWxp ZF9ub2RlbmFtZSgpIGFuZCANCj4+Pj4+IHZhbGlkX2NoYXJzKCkgaW50byBjYW5vbmljYWxp emUoKSBiZWNhdXNlIHRoZSBjb2RlIGlzIG5vdyBtb3JlIGRpZmZpY3VsdCB0byANCj4+Pj4+ IHJlYWQuIEFsc28sIHRoZSBrZWVwaW5nIHRoZSBzcGxpdCB3b3VsZCBhbGxvdyB0byBmcmVl IHRoZSAnbmFtZScgaW4gY2FzZSBvZiANCj4+Pj4+IGFuIGVycm9yIHdpdGhvdXQgYWRkaW5n IHRvbyBtdWNoIGdvdG8gaW4gdGhlIGNvZGUuDQo+Pj4+DQo+Pj4+IEkgZG9uJ3QgdGhpbmsg d2UgY2FuIGVhc2lseSBmcmVlIG5hbWUgaW4gYW4gZXJyb3IgY2FzZSwgYXQgdGhhdCB3b3Vs ZCByZXF1aXJlDQo+Pj4+IHRvIGtlZXAga25vd2xlZGdlIHRoYXQgbmFtZSB3YXMganVzdCBh bGxvY2F0ZWQgaW4gdGhlIG5vbi1jYW5vbmljYWwgY2FzZS4NCj4+Pg0KPj4+IEhvdyBhYm91 dCB0aGlzOg0KPj4+DQo+Pj4gY29uc3QgY2hhciAqY2Fub25pY2FsaXplKHN0cnVjdCBjb25u ZWN0aW9uICpjb25uLCBjb25zdCB2b2lkICpjdHgsDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29uc3QgY2hhciAqbm9kZSwgYm9v bCBhbGxvd19zcGVjaWFsKQ0KPj4+IHsNCj4+PiDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IGNo YXIgKnByZWZpeDsNCj4+PiDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IGNoYXIgKm5hbWU7DQo+ Pj4NCj4+PiDCoMKgwqDCoMKgwqDCoMKgIGlmICghbm9kZSkNCj4+PiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gTlVMTDsNCj4+Pg0KPj4+IMKgwqDCoMKgwqDC oMKgwqAgaWYgKG5vZGVbMF0gPT0gJ0AnICYmICFhbGxvd19zcGVjaWFsKQ0KPj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxMOw0KPj4+DQo+Pj4gwqDC oMKgwqDCoMKgwqDCoCBpZiAoIW5vZGUgfHwgKG5vZGVbMF0gPT0gJy8nKSB8fCAobm9kZVsw XSA9PSAnQCcpKQ0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVy biBub2RlOw0KPj4+IMKgwqDCoMKgwqDCoMKgwqAgcHJlZml4ID0gZ2V0X2ltcGxpY2l0X3Bh dGgoY29ubik7DQo+Pj4gwqDCoMKgwqDCoMKgwqDCoCBpZiAocHJlZml4KSB7DQo+Pj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbmFtZSA9IHRhbGxvY19hc3ByaW50Zihj dHgsICIlcy8lcyIsIHByZWZpeCwgbm9kZSk7DQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgaWYgKG5hbWUpDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxMOw0KPj4+IMKgwqDCoMKgwqDCoMKg wqAgfSBlbHNlDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbmFtZSA9 IG5vZGU7DQo+Pj4NCj4+PiDCoMKgwqDCoMKgwqDCoMKgIGlmICghaXNfdmFsaWRfbm9kZW5h bWUoY29ubiwgbm9kZSwgYWxsb3dfc3BlY2lhbCkpIHsNCj4+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAvKiBSZWxlYXNlIHRoZSBtZW1vcnkgaWYgJ25hbWUnIHdhcyBh bGxvY2F0ZWQgYnkgdXMgKi8NCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBpZiAoIG5hbWUgIT0gbm9kZSApDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRhbGxvY19mcmVlKG5hbWUpOw0KPj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxMOw0KPj4+IMKgwqDCoMKgwqDC oMKgwqAgfQ0KPj4+DQo+Pj4gwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gbmFtZTsNCj4+PiB9 DQo+Pj4NCj4+PiBBbmQgYmVmb3JlIHlvdSBhc2ssIEkgZG9uJ3Qgc2VlIHRoZSBiZW5lZml0 cyB0byBwYXJ0aWFsbHkgdmFsaWRhdGUgdGhlIG5hbWUgDQo+Pj4gYmVmb3JlIGFsbG9jYXRp bmcuIEhlbmNlIHdoeSBJIHN1Z2dlc3QgdG8ga2VlcCBpc192YWxpZF9ub2RlbmFtZSgpIGFz IHRoaXMgDQo+Pj4ga2VlcCB0aGUgZnVuY3Rpb24gc21hbGwuDQo+Pg0KPj4gUGFydGlhbGx5 IHZhbGlkYXRpbmcgYmVmb3JlIGRvaW5nIHRoZSBhbGxvY2F0aW9uIGlzIGEgYmVuZWZpdCBh cyBpdCBkb2Vzbid0DQo+PiBzcGVuZCBjeWNsZXMgb24gdmFsaWRhdGluZyB0aGUga25vd24g Z29vZCBwcmVmaXguDQo+IA0KPiBXaGljaCBpcyBwcmV0dHkgbXVjaCBhIGRyb3AgaW4gdGhl IG9jZWFuIGluIHRoZSBjb250ZXh0IG9mIFhlbnN0b3JlZCA6KS4gSW4gDQo+IHJlYWxpdHkg bW9zdCBvZiB0aGUgdmFsaWRhdGlvbiBjYW4gYmUgZG9uZSBiZWZvcmUgdGhlIGFsbG9jYXRp b24gd2l0aCBhIGJpdCBvZiANCj4gd29yay4NCg0KWWVzLCBidXQgdGhpcyB3b3VsZCBuZWVk IGEgbW9yZSBjb21wbGljYXRlZCBsb2dpYyByZWxhdGVkIHRvIHRoZSBoYW5kbGluZw0Kb2Yg bG9jYWxfb2ZmLiBJIHRob3VnaHQgYWJvdXQgdGhhdCwgYnV0IGRpZG4ndCB3YW50IHRvIG1h a2UgdGhlIHBhdGNoIG1vcmUNCmNvbXBsaWNhdGVkLg0KDQpBbmQgcmVnYXJkaW5nIHBlcmZv cm1hbmNlIC0geWVzLCBpdCB3aWxsIGJlIG1pbmltYWwsIGJ1dCBpdCB3YXMgcmF0aGVyIGxv dw0KaGFuZ2luZyBmcnVpdC4NCg0KPj4gQWRkaXRpb25hbGx5IHlvdXIgZXhhbXBsZSB3b24n dCB2YWxpZGF0ZSBhbiBhYnNvbHV0ZSBwYXRobmFtZSBhdCBhbGwuDQo+IA0KPiBUaGF0J3Mg YW4gZXJyb3IgaW4gdGhlIGxvZ2ljLiBUaGlzIGNhbiBiZSBzb3J0ZWQgb3V0Lg0KPiANCj4+ DQo+PiBXaGF0IGFib3V0IHRoaXMgdmFyaWFudDoNCj4gDQo+IEkgc3RpbGwgZG9uJ3Qgc2Vl IHRoZSB2YWx1ZSBvZiBmb2xkaW5nIGlzX3ZhbGlkX25vZGVfbmFtZSgpLiBCdXQgaWYgdGhl IG90aGVyIA0KPiBhZ3JlZXMgd2l0aCB5b3UgdGhlbi4uLg0KDQpJIGRpZG4ndCBzZWUgdGhl IHZhbHVlIG9mIGtlZXBpbmcgdGhlbSBhcGFydCwgYXMgdGhlIG9ubHkgY2FsbGVyIG9mDQpp c192YWxpZF9ub2RlX25hbWUoKSB3b3VsZCBiZSBjYW5vbmljYWxpemUoKSBhZnRlciB0aGlz IHBhdGNoLiA6LSkNCg0KPiANCj4+DQo+PiBjb25zdCBjaGFyICpjYW5vbmljYWxpemUoc3Ry dWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0eCwNCj4+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IGNoYXIgKm5v ZGUsIGJvb2wgYWxsb3dfc3BlY2lhbCkNCj4+IHsNCj4+IMKgwqDCoMKgwqDCoMKgwqAgY29u c3QgY2hhciAqbmFtZTsNCj4+IMKgwqDCoMKgwqDCoMKgwqAgaW50IGxvY2FsX29mZiA9IDA7 DQo+PiDCoMKgwqDCoMKgwqDCoMKgIHVuc2lnbmVkIGludCBkb21pZDsNCj4+DQo+PiDCoMKg wqDCoMKgwqDCoMKgIC8qDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgKiBJbnZhbGlkIGlmIGFu eSBvZjoNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCAqIC0gbm8gbm9kZSBhdCBhbGwNCj4+IMKg wqDCoMKgwqDCoMKgwqDCoCAqIC0gaWxsZWdhbCBjaGFyYWN0ZXIgaW4gbm9kZQ0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgICogLSBzdGFydHMgd2l0aCAnQCcgYnV0IG5vIHNwZWNpYWwgbm9k ZSBhbGxvd2VkDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgKi8NCj4+IMKgwqDCoMKgwqDCoMKg wqAgZXJybm8gPSBFSU5WQUw7DQo+PiDCoMKgwqDCoMKgwqDCoMKgIGlmICghbm9kZSB8fA0K Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnNwbihub2RlLCAiQUJDREVGR0hJSktM TU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5eiINCj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIwMTIzNDU2Nzg5 LS9fQCIpICE9IHN0cmxlbihub2RlKSB8fA0KPiANCj4gLi4uIEkgd291bGQgcmF0aGVyIGtl ZXAgY2FsbGluZyB2YWxpZF9jaGFycygpIGhlcmUuIFRoZSByZXN0IGxvb2tzIGZpbmUgZXZl biANCj4gdGhvdWdoIHRoaXMgaXMgZGVmaW5pdGVseSBub3QgbXkgcHJlZmVyZW5jZS4NCg0K SSBjYW4gZG8gdGhhdCwgZXZlbiBpZiBJIGRvbid0IHNlZSB0aGUgcmVhbCB2YWx1ZSB3aXRo IHRoZSBjb21tZW50IGFib3ZlIHRoZSBpZi4NCg0KDQpKdWVyZ2VuDQo= --------------rhPx0TzYaFyAMCT9HPkaQvWR Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------rhPx0TzYaFyAMCT9HPkaQvWR-- --------------6fMLqb9HaWUIBj2asiWGeC08-- --------------qJ7UYErQpPpJ0NC64ye50hJo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTM6YwFAwAAAAAACgkQsN6d1ii/Ey8G OwgAjKxR3TMtLnmXXylq1ltnZmfH762kDM2YzO96504/ImdvXFGJ0MVF6szFSwVEDd3ukKRpCfnB tqfsusvj8raAAKKiVSerTdkpg6Ah4GHznqpFlhyrnXlYpTFQj76z/K0K74wSvOISvwckbFtFXNrs TWnNXS10D4vOyBXndXM/SmTGdbiY7KOjVUp7l5hxPviN7Ef57qdbZIgCdBQgKfJcaDY/RndAfVFv Aq5U3xH1Fu6faKURR4S/mEf7sV+rNj44bACiMIspKOoT+TrN7x5oWwUGNK5Lcfi9zKbtBskpv2++ dlQJYbhY26JyXem/RV1Rd0knxOeJgEE6a1eGv6JT6w== =dQJY -----END PGP SIGNATURE----- --------------qJ7UYErQpPpJ0NC64ye50hJo-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 12:25:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 12:25:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577136.904029 (Exim 4.92) (envelope-from ) id 1qRts2-0001Rv-BP; Fri, 04 Aug 2023 12:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577136.904029; Fri, 04 Aug 2023 12:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRts2-0001Ro-7q; Fri, 04 Aug 2023 12:25:30 +0000 Received: by outflank-mailman (input) for mailman id 577136; Fri, 04 Aug 2023 12:25:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRts0-0001Rd-G5; Fri, 04 Aug 2023 12:25:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRts0-0002lR-CA; Fri, 04 Aug 2023 12:25:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRtrz-0005xW-Th; Fri, 04 Aug 2023 12:25:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRtrz-0007vQ-TF; Fri, 04 Aug 2023 12:25:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T0bC3z+eKvtzEVewTjtM3Dsn01A5HbGHdByCHy/Uo70=; b=7HO7wqwANMpe9np+DGgSX5OK5V H/EBvaj/nkE/pxlIhkO/zRn7mK/+mlMU7KUP6z2zQ7c6SV7mY9ijjmjsOJKheSIXPoHi5ewSO04ku Gjktvuqp4AYejZ3iA5bI4xDLDRW+CVmniaDsg5NjPmiDkHHQlw6NV6CXwc8hshwEXGFs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 182175: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-pvops:kernel-build:fail:regression libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=1ca3c339a119242b4a511fc9cf7b561a77d2301e X-Osstest-Versions-That: libvirt=99349ba18e726465215a71f28d2146a0a2adb65d From: osstest service owner Date: Fri, 04 Aug 2023 12:25:27 +0000 flight 182175 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182175/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 182131 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182131 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182131 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182131 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 1ca3c339a119242b4a511fc9cf7b561a77d2301e baseline version: libvirt 99349ba18e726465215a71f28d2146a0a2adb65d Last test of basis 182131 2023-08-02 19:15:02 Z 1 days Testing same since 182175 2023-08-04 01:18:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Laine Stump Michal Privoznik jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 1ca3c339a119242b4a511fc9cf7b561a77d2301e Author: Michal Privoznik Date: Thu Aug 3 10:25:43 2023 +0200 lib: Prefer sizeof(variable) instead of sizeof(type) in memset If one of previous commits taught us something, it's that: sizeof(variable) and sizeof(type) are not the same. Especially because for live enough code the type might change (e.g. as we use autoptr more). And since we don't get any warnings when an incorrect length is passed to memset() it is easy to mess up. But with sizeof(variable) instead, it's not as easy. Therefore, switch to using memset(variable, 0, sizeof(*variable)), or its alternatives, depending on level of pointers. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 4f159d426921bb81375fe5404ff88aab9437972a Author: Michal Privoznik Date: Thu Aug 3 11:48:30 2023 +0200 lib: Finish using struct zero initializer manually There are some cases left after previous commit which were not picked up by coccinelle. Mostly, becuase the spatch was not generic enough. We are left with cases like: two variables declared on one line, a variable declared in #ifdef-s (there are notoriously difficult for coccinelle), arrays, macro definitions, etc. Finish what coccinelle started, by hand. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit b20a5e9a4d847b06030b07a5387da22df0005011 Author: Michal Privoznik Date: Wed Aug 2 10:09:52 2023 +0200 lib: use struct zero initializer instead of memset This is a more concise approach and guarantees there is no time window where the struct is uninitialized. Generated using the following semantic patch: @@ type T; identifier X; @@ - T X; + T X = { 0 }; ... when exists ( - memset(&X, 0, sizeof(X)); | - memset(&X, 0, sizeof(T)); ) Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 7ce0fbccf1df61e7dfd86d1cbb863f82c36c494c Author: Michal Privoznik Date: Thu Aug 3 09:45:14 2023 +0200 virnetdaemon.c: Use struct zero initializer instead of memset Ideally, these would be fixed by coccinelle (see next commit), but because of various reasons they aren't. Fix them manually. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 3b95df9edaf5c1ab0aaa30727729f7fcc9122ddb Author: Michal Privoznik Date: Thu Aug 3 11:48:57 2023 +0200 virnetclient: Update comment about memset() Instead of suggesting to zero structs out using memset() we should suggest initializing structs with zero initializer. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 3d7faaf71213d5dc004a0f0c9df2e729e7cf1d0e Author: Michal Privoznik Date: Thu Aug 3 10:43:13 2023 +0200 virnetlink: Drop unused variable from virNetlinkCommand() The fds variable inside of virNetlinkCommand() is not used really. It's passed to memset() (hence compilers do not complain), but that's about it. Drop it. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit ea5352334af4ce9151e826db7a0dc3f02a211b6c Author: Michal Privoznik Date: Thu Aug 3 10:30:12 2023 +0200 virfirewalld: Drop useless memset() in virFirewallDApplyRule() This is a residue of v6.8.0-rc1~100. The error variable inside of virFirewallDApplyRule() is already initialized to NULL. There's no need to memset() it to zero again. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 258fc73cf051419d19947059a98f1d6a2d1d4910 Author: Michal Privoznik Date: Thu Aug 3 09:39:03 2023 +0200 remote_driver: Drop explicit memset(&sargs) in remoteAuthSASL() Inside of remoteAuthSASL() the sargs variable is already initialized to zero during declaration. There's no need to memset() it again as it's unused in between it's declaration and said memset(). Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 5aba19868732e86e610d84e11d8adcbd1046d5b9 Author: Michal Privoznik Date: Thu Aug 3 08:52:57 2023 +0200 qemu: Don't reuse variable in processSerialChangedEvent() When a VSERPORT_CHANGE event is processed, we firstly do a little detour and try to detect whether the event is coming from guest agent. If so, we notify threads that are currently talking to the agent about this fact. Then we proceed with usual event processing (BeginJob(), update domain def, emit event, and so on). In both cases we use the same @dev variable to refer to domain device. While this works, it will make writing semantic patch unnecessary harder (see next commit(s)). Therefore, introduce a separate variable for the detour code. Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 039b16e41ed1648646c4b35947428ba1b56d8e2a Author: Michal Privoznik Date: Wed Aug 2 15:30:04 2023 +0200 Decrease scope of some variables There are couple of variables that are declared at function beginning but then used solely within a block (either for() loop or if() statement). And just before their use they are zeroed explicitly using memset(). Decrease their scope, use struct zero initializer and drop explicit memset(). Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 6b4ce69251373379d63b539050ab94c579fd1616 Author: Michal Privoznik Date: Wed Aug 2 15:42:31 2023 +0200 virt-aa-helper: Use struct zero initializer instead of memset This is similar to the previous commit, except this is for a different type (vahControl) and also fixes the case where _ctl is passed not initialized to vah_error() (via ctl pointer so that's probably why compilers don't complain). Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit 33b794898364be55f19eaf9a834cd095b75e1b71 Author: Michal Privoznik Date: Wed Aug 2 14:57:44 2023 +0200 tools: Fix vshControl declaration and initialization Both virsh and virt-admin have vshControl typed variables and also pointers to these variables. In both cases these are declared on a single line. Do the following: 1) break declaration into two lines, 2) use struct zero initializer for vshControl and virshControl/vshAdmControl structs, 3) drop explicit memset(.., 0, ...) ; Signed-off-by: Michal Privoznik Reviewed-by: Claudio Fontana commit a8262cb331db0f1a706edbadffc2cd5b01e44be6 Author: Laine Stump Date: Thu Jul 13 11:51:28 2023 -0400 qemu: don't add --mac-addr option to passt commandline When I implemented passt support in libvirt, I saw the --mac-addr option on the passt commandline, immediately assumed that this was used for setting the guest interface's mac address somewhere within passt, and read no further. As a result, "--mac-addr" is always added to the passt commandline, specifying the setting from in the guest's interface config. But as pointed out in this bugzilla comment: https://bugzilla.redhat.com/2184967#c8 That is *not at all* what passt's --mac-addr option does. Instead, it is used to force the *remote* mac address for incoming traffic to a specific value. So setting --mac-addr results in all traffic on the interface having the same (the guest's) mac address for both source and destination in all traffic. Surprisingly, this still works, so nobody noticed it during testing. The proper thing is to not specify any mac address to passt - the remote MAC addresses can and should remain untouched, and the local MAC address will end up being known to passt just by the guest sending out packets with that MAC address. Reported-by: Laszlo Ersek Signed-off-by: Laine Stump Reviewed-by: Laszlo Ersek Reviewed-by: Stefano Brivio From xen-devel-bounces@lists.xenproject.org Fri Aug 04 12:27:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 12:27:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577142.904038 (Exim 4.92) (envelope-from ) id 1qRttd-00023X-Qw; Fri, 04 Aug 2023 12:27:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577142.904038; Fri, 04 Aug 2023 12:27:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRttd-00023Q-OI; Fri, 04 Aug 2023 12:27:09 +0000 Received: by outflank-mailman (input) for mailman id 577142; Fri, 04 Aug 2023 12:27:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRttc-00023G-Bl for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 12:27:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRttb-0002nB-PP; Fri, 04 Aug 2023 12:27:07 +0000 Received: from 54-240-197-228.amazon.com ([54.240.197.228] helo=[10.95.104.46]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qRttb-0004nn-HM; Fri, 04 Aug 2023 12:27:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=XOlcaVRyMiJvAljp6aYw/EwvW+Rr9YJoKjiaaKp/Mec=; b=ER/7KbR7vw7ye/v/NCPSgTlLI4 fI9ZS0eX9WXOfpqHDxh4y9PDATMq2XTuqjjMZALXrPtn2kOylpLoKVUY1A5LIm2qDi38A3xw07mcr KxfjuaYeBu22X2eDSEmNIru0yDSTr8RvSRNq+3fXltAZUk3IvJSiy+7rWA7ylXTm/XDc=; Message-ID: Date: Fri, 4 Aug 2023 13:27:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> <8f9a76fc-283a-e3f3-d19f-04401389a7de@suse.com> From: Julien Grall In-Reply-To: <8f9a76fc-283a-e3f3-d19f-04401389a7de@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 04/08/2023 13:05, Juergen Gross wrote: > On 04.08.23 12:33, Julien Grall wrote: >>> const char *canonicalize(struct connection *conn, const void *ctx, >>>                           const char *node, bool allow_special) >>> { >>>          const char *name; >>>          int local_off = 0; >>>          unsigned int domid; >>> >>>          /* >>>           * Invalid if any of: >>>           * - no node at all >>>           * - illegal character in node >>>           * - starts with '@' but no special node allowed >>>           */ >>>          errno = EINVAL; >>>          if (!node || >>>              strspn(node, >>> "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" >>>                           "0123456789-/_@") != strlen(node) || >> >> ... I would rather keep calling valid_chars() here. The rest looks >> fine even though this is definitely not my preference. > > I can do that, even if I don't see the real value with the comment above > the if. How about writing Xenstored in a single function then? After all with comments it should be easy to read, right? :) There are a few difficulty with the current approach. There are: * a large function call that needs to be split over two lines * multiple || which also need to split over multiple lines. * No parentheses over strspn(....) != strlen(node) Maybe you can parse/understand this 'if' very quickly. But I can't and this is just slowing down review and increasing the risk of introducing bugs. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 04 12:44:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 12:44:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577148.904052 (Exim 4.92) (envelope-from ) id 1qRu9w-0004h8-As; Fri, 04 Aug 2023 12:44:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577148.904052; Fri, 04 Aug 2023 12:44:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRu9w-0004h1-85; Fri, 04 Aug 2023 12:44:00 +0000 Received: by outflank-mailman (input) for mailman id 577148; Fri, 04 Aug 2023 12:43:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRu9v-0004gv-0c for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 12:43:59 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 93e0edcc-32c4-11ee-b26c-6b7b168915f2; Fri, 04 Aug 2023 14:43:57 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E63341F749; Fri, 4 Aug 2023 12:43:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B3089133B5; Fri, 4 Aug 2023 12:43:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uS66KYzyzGSsfQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 12:43:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93e0edcc-32c4-11ee-b26c-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691153036; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qfW6QB5yZXFZ2212VgUiVr7JUPgrxG7dwhv7QI16/jU=; b=bF+GpmGzeOpa1INu/9i8O4aDNpoTA1/vcATw89Z6/ELa7cEGcUH8LO8379tsx9+8J9n1MV gir7mue+uvG2KeknRzEDblH5RO+y8imZ2wYRP9rBbOlqoHpDwHJoVc4Vz5i/MJyykvciTJ HXH8TrH1g3/wEGGyksIUEtOoXbrj5Bo= Message-ID: <0deb1b5f-86e7-cfe8-46cc-27c6d2bad6a8@suse.com> Date: Fri, 4 Aug 2023 14:43:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> <8f9a76fc-283a-e3f3-d19f-04401389a7de@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------IFu6k4ljD8mJsMUVJHKk5Gl5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IFu6k4ljD8mJsMUVJHKk5Gl5 Content-Type: multipart/mixed; boundary="------------Eaqx0aNR0RTA2WKVtRlJrWkP"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <0deb1b5f-86e7-cfe8-46cc-27c6d2bad6a8@suse.com> Subject: Re: [PATCH v3 23/25] tools/xenstore: merge is_valid_nodename() into canonicalize() References: <20230724110247.10520-1-jgross@suse.com> <20230724110247.10520-24-jgross@suse.com> <99a76ceb-df27-3a37-296b-9fcf1671472e@suse.com> <6193da26-c348-dcd2-b3ef-7b75ce4da376@suse.com> <8e7d18a0-0130-4ae5-adac-cfc122d6fb16@xen.org> <8f9a76fc-283a-e3f3-d19f-04401389a7de@suse.com> In-Reply-To: --------------Eaqx0aNR0RTA2WKVtRlJrWkP Content-Type: multipart/mixed; boundary="------------tmV0RKt0tzrAOxmtqDCEIBog" --------------tmV0RKt0tzrAOxmtqDCEIBog Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDguMjMgMTQ6MjcsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA0LzA4LzIwMjMgMTM6MDUsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAwNC4wOC4yMyAxMjozMywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPj4+PiBjb25zdCBjaGFy ICpjYW5vbmljYWxpemUoc3RydWN0IGNvbm5lY3Rpb24gKmNvbm4sIGNvbnN0IHZvaWQgKmN0 eCwNCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgY29uc3QgY2hhciAqbm9kZSwgYm9vbCBhbGxvd19zcGVjaWFsKQ0KPj4+PiB7DQo+ Pj4+IMKgwqDCoMKgwqDCoMKgwqAgY29uc3QgY2hhciAqbmFtZTsNCj4+Pj4gwqDCoMKgwqDC oMKgwqDCoCBpbnQgbG9jYWxfb2ZmID0gMDsNCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCB1bnNp Z25lZCBpbnQgZG9taWQ7DQo+Pj4+DQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqAgLyoNCj4+Pj4g wqDCoMKgwqDCoMKgwqDCoMKgICogSW52YWxpZCBpZiBhbnkgb2Y6DQo+Pj4+IMKgwqDCoMKg wqDCoMKgwqDCoCAqIC0gbm8gbm9kZSBhdCBhbGwNCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg ICogLSBpbGxlZ2FsIGNoYXJhY3RlciBpbiBub2RlDQo+Pj4+IMKgwqDCoMKgwqDCoMKgwqDC oCAqIC0gc3RhcnRzIHdpdGggJ0AnIGJ1dCBubyBzcGVjaWFsIG5vZGUgYWxsb3dlZA0KPj4+ PiDCoMKgwqDCoMKgwqDCoMKgwqAgKi8NCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCBlcnJubyA9 IEVJTlZBTDsNCj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCBpZiAoIW5vZGUgfHwNCj4+Pj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnNwbihub2RlLCANCj4+Pj4gIkFCQ0RFRkdISUpL TE1OT1BRUlNUVVZXWFlaYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXoiDQo+Pj4+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICIwMTIzNDU2 Nzg5LS9fQCIpICE9IHN0cmxlbihub2RlKSB8fA0KPj4+DQo+Pj4gLi4uIEkgd291bGQgcmF0 aGVyIGtlZXAgY2FsbGluZyB2YWxpZF9jaGFycygpIGhlcmUuIFRoZSByZXN0IGxvb2tzIGZp bmUgZXZlbiANCj4+PiB0aG91Z2ggdGhpcyBpcyBkZWZpbml0ZWx5IG5vdCBteSBwcmVmZXJl bmNlLg0KPj4NCj4+IEkgY2FuIGRvIHRoYXQsIGV2ZW4gaWYgSSBkb24ndCBzZWUgdGhlIHJl YWwgdmFsdWUgd2l0aCB0aGUgY29tbWVudCBhYm92ZSB0aGUgaWYuDQo+IA0KPiBIb3cgYWJv dXQgd3JpdGluZyBYZW5zdG9yZWQgaW4gYSBzaW5nbGUgZnVuY3Rpb24gdGhlbj8gQWZ0ZXIg YWxsIHdpdGggY29tbWVudHMgDQo+IGl0IHNob3VsZCBiZSBlYXN5IHRvIHJlYWQsIHJpZ2h0 PyA6KQ0KDQpZZWFoLCByaWdodC4NCg0KTWlnaHQgY29tZSB3aXRoIHRoZSBkb3duc2lkZSBv ZiBhIGxpdHRsZSBiaXQgb2YgY29kZSBkdXBsaWNhdGlvbi4gOy0pDQoNCj4gDQo+IFRoZXJl IGFyZSBhIGZldyBkaWZmaWN1bHR5IHdpdGggdGhlIGN1cnJlbnQgYXBwcm9hY2guIFRoZXJl IGFyZToNCj4gIMKgICogYSBsYXJnZSBmdW5jdGlvbiBjYWxsIHRoYXQgbmVlZHMgdG8gYmUg c3BsaXQgb3ZlciB0d28gbGluZXMNCj4gIMKgICogbXVsdGlwbGUgfHwgd2hpY2ggYWxzbyBu ZWVkIHRvIHNwbGl0IG92ZXIgbXVsdGlwbGUgbGluZXMuDQo+ICDCoCAqIE5vIHBhcmVudGhl c2VzIG92ZXIgc3Ryc3BuKC4uLi4pICE9IHN0cmxlbihub2RlKQ0KPiANCj4gTWF5YmUgeW91 IGNhbiBwYXJzZS91bmRlcnN0YW5kIHRoaXMgJ2lmJyB2ZXJ5IHF1aWNrbHkuIEJ1dCBJIGNh bid0IGFuZCB0aGlzIGlzIA0KPiBqdXN0IHNsb3dpbmcgZG93biByZXZpZXcgYW5kIGluY3Jl YXNpbmcgdGhlIHJpc2sgb2YgaW50cm9kdWNpbmcgYnVncy4NCg0KT2theSwgYXMgc2FpZCBh Ym92ZTogSSBjYW4gZG8gdGhhdC4NCg0KDQpKdWVyZ2VuDQo= --------------tmV0RKt0tzrAOxmtqDCEIBog Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------tmV0RKt0tzrAOxmtqDCEIBog-- --------------Eaqx0aNR0RTA2WKVtRlJrWkP-- --------------IFu6k4ljD8mJsMUVJHKk5Gl5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTM8owFAwAAAAAACgkQsN6d1ii/Ey+Z Bgf/ZDNcEpJglkRia3GBqq4fhgft1+Q/yp19qfqNoloc4+riNuy5RQSWPZDWVM2Fnyz50AdN6s0X J/HWlZXcX2Lg3DzMMu4YxDqjtdL/klsUkJLzfK4zYxU+9LyAoNPm90ym0c7QxuVzexk765Kz46GE L3bBmvWsNgl4ct8tXQeeszkDGmVXRmmVKuQ9woRic55+RVgYKqTIIRwNNdkqqrvxRk1O79ZsYR+j ElJHmF4L83vRH2CiZOklfOPpb/my99EgtkyG5qUx/z3cWKaIYQz2uNugBn7HCuoTyJQwS19SCb0r ZkclE4BWZmD4W84NbW7Jb+JwmxXU9cVA7eGEVNA4Dg== =U0OI -----END PGP SIGNATURE----- --------------IFu6k4ljD8mJsMUVJHKk5Gl5-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 13:42:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 13:42:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577152.904062 (Exim 4.92) (envelope-from ) id 1qRv4n-0002kB-KJ; Fri, 04 Aug 2023 13:42:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577152.904062; Fri, 04 Aug 2023 13:42:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRv4n-0002k4-Hc; Fri, 04 Aug 2023 13:42:45 +0000 Received: by outflank-mailman (input) for mailman id 577152; Fri, 04 Aug 2023 13:42:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRv4m-0002jy-Cq for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 13:42:44 +0000 Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [2607:f8b0:4864:20::92f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8055340-32cc-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 15:42:41 +0200 (CEST) Received: by mail-ua1-x92f.google.com with SMTP id a1e0cc1a2514c-78a5384a5daso651984241.0 for ; Fri, 04 Aug 2023 06:42:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8055340-32cc-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691156560; x=1691761360; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DwEj/mlrbmIXZppAE8WYSFPJa4shWw2a/7DL7GnW/jA=; b=JJQEtocgJB0UjcEAvLjOvw/6ayaB65lksDrJX5a8cw6fhpIyW/Gp6O5QuQhkNZMO4n OLowa7V/Yn0p/hASs9aHqNPrPIKqOnb0XdXrLno8pK8tdahtCMrlaUQLvZiKsVM953RI ycB2OAEdpv4WX1+fbMNI22X7GUBcwuJea26v6huFhPxXepgrjCuSSQZ+e9MZgXUf70DM q3ffGLL5S/VRw8zsJzsn4WpbnioMBNqdDVSj90zJMUBevOeBFI28tYVIYGxE4MG5CHIz 6hDNyUArMrph/ABRlqILVgYuOPIbIN1B7EchwPY/N5RgfVF9ivCw4JafPhpF5FlBSRJ3 TY7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691156560; x=1691761360; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DwEj/mlrbmIXZppAE8WYSFPJa4shWw2a/7DL7GnW/jA=; b=K7e7nA76KbRNrOdGlz5VCs0IgOROI+xRak1LwJdIu/Fw1zVXiqc7zxLUeWcM7HjOuF L58hJYkX/RaNGkxmqRmCX+0BBAWpKUshZCAkO6gg7IVCqtK3anjAHBQBPRbRcibdkphQ UoFerPQZTys5nm+2CmszqPXr/Tl6S08n/Ip77ehM5h7aJvV6j6UMBkbCxWzcQDGSPSHC uVcVG/PTXKUjhVkNxCYuuXqQMIiJRNTUTVq5WROlBGzf8z1DDJsV1L6J34TcaY1iIcz+ oxsSFDkFh1Z+qpn9lsxiPTXxDe/B78LDdAS/VLZ95YIp8nU4HGONReM410nMXb39u96l 9IzA== X-Gm-Message-State: AOJu0YxsWz4Hoqiubwiij33eI2LlrZyZmbPkIsctjXT19Eb6Ura5Dgtw TBIHrv9Nzzngl8mLRjwtr2mkHLoYqclMFJ6sW9I= X-Google-Smtp-Source: AGHT+IFWpdx3bBRjAQUXw1az+MdUxSqeOAujvWGIHD88avtlgkc6Emn9SaqoputYXvBRK23oTtlr58ccajred7O0K5A= X-Received: by 2002:a1f:bdd1:0:b0:471:8787:2c6c with SMTP id n200-20020a1fbdd1000000b0047187872c6cmr660867vkf.6.1691156560039; Fri, 04 Aug 2023 06:42:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alistair Francis Date: Fri, 4 Aug 2023 09:42:13 -0400 Message-ID: Subject: Re: [PATCH v7 2/6] xen/riscv: introduce dummy To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 3, 2023 at 8:05=E2=80=AFAM Oleksii Kurochko wrote: > > will be used in the patch "xen/riscv: introduce > decode_cause() stuff" and requires > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V7: > - Nothing changed. Only rebase. > --- > Changes in V6: > - Nothing changed. Only rebase. > --- > Changes in V5: > * the patch was introduced in the current patch series (V5) > --- > xen/arch/riscv/include/asm/bug.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > create mode 100644 xen/arch/riscv/include/asm/bug.h > > diff --git a/xen/arch/riscv/include/asm/bug.h b/xen/arch/riscv/include/as= m/bug.h > new file mode 100644 > index 0000000000..e8b1e40823 > --- /dev/null > +++ b/xen/arch/riscv/include/asm/bug.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2012 Regents of the University of California > + * Copyright (C) 2021-2023 Vates > + * > + */ > +#ifndef _ASM_RISCV_BUG_H > +#define _ASM_RISCV_BUG_H > + > +#endif /* _ASM_RISCV_BUG_H */ > -- > 2.41.0 > > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 13:46:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 13:46:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577155.904071 (Exim 4.92) (envelope-from ) id 1qRv89-0003LM-3g; Fri, 04 Aug 2023 13:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577155.904071; Fri, 04 Aug 2023 13:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRv89-0003LF-0z; Fri, 04 Aug 2023 13:46:13 +0000 Received: by outflank-mailman (input) for mailman id 577155; Fri, 04 Aug 2023 13:46:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRv88-0003L9-35 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 13:46:12 +0000 Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [2607:f8b0:4864:20::e34]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 448676d5-32cd-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 15:46:10 +0200 (CEST) Received: by mail-vs1-xe34.google.com with SMTP id ada2fe7eead31-447be69ae43so710811137.0 for ; Fri, 04 Aug 2023 06:46:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 448676d5-32cd-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691156769; x=1691761569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hi4eaJ2vpzaX+Spz9WGK8TZDFcHCvCNIhMhjxeulaI8=; b=cLZeFLi4JMupkNax5zgWZHcjretVbeLE0i9fM5rezo1B0tS/9j5KNK4fjA26XO+5Pf M5hhQN49P0FU3EI1L846YSuD5OdGxO/UO4LqQVuT5NgaLvA2vT+5Hnc2n3wPc5QNwEsU oMAl3L5urEHLmk4lkbJTzve33sI683DePMl4t71fyov/CmJFHWVtXhryOMWNMu8+y0L1 ncZorZFRNZ5VU9mHdZmf/qyR2iPf3yhQmGsZsmz6S8z6OIqGRdkYZAqPA3Ane+z2aRK3 FUCrTS/HnDJI1WHhwHtopYxp+3LvSmM5eJ9dcl61/zEz1E6pfloDcs92Wnok4Civ5RPz 77yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691156769; x=1691761569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hi4eaJ2vpzaX+Spz9WGK8TZDFcHCvCNIhMhjxeulaI8=; b=c/N0KxQrFR87dMqTEBDH2C0Mu1a+sbdKeeb005gvZETFzMGUwOZOBgtUyedoK6RXZo umMMD6Gm+qx48BD3WkVoCBTSCc6MeiOh4pdS0kKAh8suJdHh1IkM00ts0AfgUDKk/GR9 mY2jVUSnFMJWEGis3b9sc0N2mhidQDClwIZSaaTUWjZ9p08+dNwnnJ+wd59yMaskQAdX ot5gbqYWI4xvtXCifwoCvlTC2WCTR4w3BCN4Vep/JIj9ah6vYzDQujFC1sejk5rIAiwZ 08/vhGlzHuj171fqBsA9YK99KSmi4p43JUMD9j8YIM/e7ruKUaEAX8JuC9uCuQn5xhYR 2Ayg== X-Gm-Message-State: AOJu0YyG/AoL7bbdtYLs8StdZ4i5gmYDvwmy+nyd3yRRTfst7e6adLbj N6nx3a+k4kGhbRCmUmhAqruwAltV4MzZtpS8FSo= X-Google-Smtp-Source: AGHT+IGOrwkfCEq4jEUT41SaWRtQUdfYUEPzt65drdneh6zWr8ZwRx6zevCbps4SG3roK8JS3t2BeZ+YLa9KtWQZ+J8= X-Received: by 2002:a67:f95a:0:b0:443:78dd:447 with SMTP id u26-20020a67f95a000000b0044378dd0447mr689109vsq.3.1691156768698; Fri, 04 Aug 2023 06:46:08 -0700 (PDT) MIME-Version: 1.0 References: <25e8e5c5826199ad6f91fb5106472917765d8260.1691063432.git.oleksii.kurochko@gmail.com> In-Reply-To: <25e8e5c5826199ad6f91fb5106472917765d8260.1691063432.git.oleksii.kurochko@gmail.com> From: Alistair Francis Date: Fri, 4 Aug 2023 09:45:42 -0400 Message-ID: Subject: Re: [PATCH v7 3/6] xen/riscv: introduce decode_cause() stuff To: Oleksii Kurochko Cc: xen-devel@lists.xenproject.org, Jan Beulich , Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 3, 2023 at 8:05=E2=80=AFAM Oleksii Kurochko wrote: > > The patch introduces stuff needed to decode a reason of an > exception. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V7: > - Nothing changed. Only rebase. > --- > Changes in V6: > - Remove usage of LINK_TO_LOAD() due to the MMU being enabled first. > - Change early_printk() to printk() > --- > Changes in V5: > - Remove from riscv/traps/c as nothing would require > inclusion. > - decode_reserved_interrupt_cause(), decode_interrupt_cause(), decode_c= ause, do_unexpected_trap() > were made as static they are expected to be used only in traps.c > - use LINK_TO_LOAD() for addresses which can be linker time relative. > --- > Changes in V4: > - fix string in decode_reserved_interrupt_cause() > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Make decode_trap_cause() more optimization friendly. > - Merge the pathc which introduces do_unexpected_trap() to the current = one. > --- > xen/arch/riscv/traps.c | 84 +++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 83 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c > index ccd3593f5a..ea1012e83e 100644 > --- a/xen/arch/riscv/traps.c > +++ b/xen/arch/riscv/traps.c > @@ -4,10 +4,92 @@ > * > * RISC-V Trap handlers > */ > + > +#include > + > +#include > +#include > #include > #include > > -void do_trap(struct cpu_user_regs *cpu_regs) > +static const char *decode_trap_cause(unsigned long cause) > +{ > + static const char *const trap_causes[] =3D { > + [CAUSE_MISALIGNED_FETCH] =3D "Instruction Address Misaligned", > + [CAUSE_FETCH_ACCESS] =3D "Instruction Access Fault", > + [CAUSE_ILLEGAL_INSTRUCTION] =3D "Illegal Instruction", > + [CAUSE_BREAKPOINT] =3D "Breakpoint", > + [CAUSE_MISALIGNED_LOAD] =3D "Load Address Misaligned", > + [CAUSE_LOAD_ACCESS] =3D "Load Access Fault", > + [CAUSE_MISALIGNED_STORE] =3D "Store/AMO Address Misaligned", > + [CAUSE_STORE_ACCESS] =3D "Store/AMO Access Fault", > + [CAUSE_USER_ECALL] =3D "Environment Call from U-Mode", > + [CAUSE_SUPERVISOR_ECALL] =3D "Environment Call from S-Mode", > + [CAUSE_MACHINE_ECALL] =3D "Environment Call from M-Mode", > + [CAUSE_FETCH_PAGE_FAULT] =3D "Instruction Page Fault", > + [CAUSE_LOAD_PAGE_FAULT] =3D "Load Page Fault", > + [CAUSE_STORE_PAGE_FAULT] =3D "Store/AMO Page Fault", > + [CAUSE_FETCH_GUEST_PAGE_FAULT] =3D "Instruction Guest Page Fault= ", > + [CAUSE_LOAD_GUEST_PAGE_FAULT] =3D "Load Guest Page Fault", > + [CAUSE_VIRTUAL_INST_FAULT] =3D "Virtualized Instruction Fault", > + [CAUSE_STORE_GUEST_PAGE_FAULT] =3D "Guest Store/AMO Page Fault", > + }; > + > + if ( cause < ARRAY_SIZE(trap_causes) && trap_causes[cause] ) > + return trap_causes[cause]; > + return "UNKNOWN"; > +} > + > +static const char *decode_reserved_interrupt_cause(unsigned long irq_cau= se) > +{ > + switch ( irq_cause ) > + { > + case IRQ_M_SOFT: > + return "M-mode Software Interrupt"; > + case IRQ_M_TIMER: > + return "M-mode TIMER Interrupt"; TIMER doesn't need to be all caps, otherwise: Acked-by: Alistair Francis Alistair > + case IRQ_M_EXT: > + return "M-mode External Interrupt"; > + default: > + return "UNKNOWN IRQ type"; > + } > +} > + > +static const char *decode_interrupt_cause(unsigned long cause) > +{ > + unsigned long irq_cause =3D cause & ~CAUSE_IRQ_FLAG; > + > + switch ( irq_cause ) > + { > + case IRQ_S_SOFT: > + return "Supervisor Software Interrupt"; > + case IRQ_S_TIMER: > + return "Supervisor Timer Interrupt"; > + case IRQ_S_EXT: > + return "Supervisor External Interrupt"; > + default: > + return decode_reserved_interrupt_cause(irq_cause); > + } > +} > + > +static const char *decode_cause(unsigned long cause) > +{ > + if ( cause & CAUSE_IRQ_FLAG ) > + return decode_interrupt_cause(cause); > + > + return decode_trap_cause(cause); > +} > + > +static void do_unexpected_trap(const struct cpu_user_regs *regs) > { > + unsigned long cause =3D csr_read(CSR_SCAUSE); > + > + printk("Unhandled exception: %s\n", decode_cause(cause)); > + > die(); > } > + > +void do_trap(struct cpu_user_regs *cpu_regs) > +{ > + do_unexpected_trap(cpu_regs); > +} > -- > 2.41.0 > > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 14:00:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 14:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577164.904098 (Exim 4.92) (envelope-from ) id 1qRvM7-00061R-D9; Fri, 04 Aug 2023 14:00:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577164.904098; Fri, 04 Aug 2023 14:00:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvM7-00061K-AR; Fri, 04 Aug 2023 14:00:39 +0000 Received: by outflank-mailman (input) for mailman id 577164; Fri, 04 Aug 2023 14:00:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvM6-000613-Ck for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 14:00:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48d1a911-32cf-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 16:00:35 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 5F6254EE0737; Fri, 4 Aug 2023 16:00:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48d1a911-32cf-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Fri, 04 Aug 2023 16:00:35 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Jan Beulich , Andrew Cooper , Julien Grall , George Dunlap , Wei Liu Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: <00fb1a58849ec08534465df2f8ca2284@bugseng.com> References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit > > Upon further examination, I identified the following patterns: > > 1. Functions defined in .c called only from asm code (e.g., the > already mentioned __start_xen) > 2. Functions/variables declared in a .h, defined in a .c that does not > include the .h with the declaration > (e.g., 'fill_console_start_info' is defined in 'xen/drivers/vga.c', > declared in 'xen/include/xen/console.h' which is not visible when > compiling the .c). > 3. Variables that are either extern or not, such as 'acpi_gbl_FADT' in > 'xen/include/acpi/acglobal.h', depending on > DEFINE_ACPI_GLOBALS > > Below are the proposed resolution strategies: > > 1. I would advise to add the declaration in the relative .h, to > support automatic consistency checks with the > implementation and a quick reference when touching the asm. > 2. To comply with the rule, the header with the declaration should be > included. Also note that there are some > corner cases, such as 'get_sec', which is used in 'cper.h' without > including 'time.h' (which should gain a > declaration for it). > 3. One possible resolution pattern is including 'acglobal.h' twice > (either directly or indirectly trough acpi.h, if > the latter does not cause other issues) like so: > > (assuming DEFINE_ACPI_GLOBALS is undefined here) > #include "acglobal.h" > #define DEFINE_ACPI_GLOBALS > #include "acglobal.h" > > this way, the rule is followed properly, though it's not the > prettiest pattern and also clashes with the objectives > of D4.10 ("Precautions shall be taken in order to prevent the > contents of a header file being included > more than once"), but then a motivated exception is allowed there. One further question is whether functions under 'xen/common/coverage/gcov_base.c' should gain a declaration in 'gcov.h' or not, as they exist just for the purpose of being referenced by autogenerated profiling code. I see no reason why they shouldn't, but they can also be safely deviated, since they are not called by Xen code. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 14:04:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 14:04:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577169.904112 (Exim 4.92) (envelope-from ) id 1qRvQE-0006jk-3X; Fri, 04 Aug 2023 14:04:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577169.904112; Fri, 04 Aug 2023 14:04:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvQE-0006jY-0m; Fri, 04 Aug 2023 14:04:54 +0000 Received: by outflank-mailman (input) for mailman id 577169; Fri, 04 Aug 2023 14:04:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvQC-0006jM-3Y; Fri, 04 Aug 2023 14:04:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvQC-0004yv-1K; Fri, 04 Aug 2023 14:04:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvQB-0000VD-Fy; Fri, 04 Aug 2023 14:04:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRvQB-00045u-FX; Fri, 04 Aug 2023 14:04:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vg7K8+2jOWjGKQSGosTYiiL2EYCYj0YPls0KhB0DXRw=; b=RNY5Ed9lJYXx22DwpmVhA/EBRH 2jVbutK2Zsw0eqA4EmuIyStt52kLuDiCyZ8Cw8CiCc6CbyBrkgfIMXTE9hW9XkM3fWVN5rgWno6lm zFEvOzzGcFZMWYnu8jmCU3yV5xqi7Oht14Q0Kq2RG6+lhlGsyfqIFrlWPQmJu3VOX3tA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 182167: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-4.17-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.17-testing:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug xen-4.17-testing:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug xen-4.17-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0a62b16489958715c20a2f6177a11a8ca3c4f7f3 X-Osstest-Versions-That: xen=3d0aa6f23d54a4d3c608010c58c1147a1500d865 From: osstest service owner Date: Fri, 04 Aug 2023 14:04:51 +0000 flight 182167 xen-4.17-testing real [real] flight 182180 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182167/ http://logs.test-lab.xenproject.org/osstest/logs/182180/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 182180-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 182180-retest test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 182180-retest test-armhf-armhf-xl-vhd 13 guest-start fail pass in 182180-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 182180 like 182120 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 182180 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 182180 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 182180 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182120 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182120 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182120 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182120 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182120 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182120 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182120 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182120 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182120 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182120 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182120 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 0a62b16489958715c20a2f6177a11a8ca3c4f7f3 baseline version: xen 3d0aa6f23d54a4d3c608010c58c1147a1500d865 Last test of basis 182120 2023-08-02 15:11:47 Z 1 days Testing same since 182167 2023-08-03 14:38:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Christian Lindig Edwin Török Jan Beulich Juergen Gross Julien Grall Khem Raj Roger Pau MonnĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3d0aa6f23d..0a62b16489 0a62b16489958715c20a2f6177a11a8ca3c4f7f3 -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 14:09:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 14:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577176.904121 (Exim 4.92) (envelope-from ) id 1qRvUJ-0007OA-JR; Fri, 04 Aug 2023 14:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577176.904121; Fri, 04 Aug 2023 14:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvUJ-0007O3-Gp; Fri, 04 Aug 2023 14:09:07 +0000 Received: by outflank-mailman (input) for mailman id 577176; Fri, 04 Aug 2023 14:09:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvUI-0007Nx-4F for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 14:09:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77e71c1b-32d0-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 16:09:04 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id B27DB4EE0737; Fri, 4 Aug 2023 16:09:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77e71c1b-32d0-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Fri, 04 Aug 2023 16:09:03 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: <95a6d085-cbb9-ecb6-134d-6e4d994bfd35@suse.com> References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> <95a6d085-cbb9-ecb6-134d-6e4d994bfd35@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >> 3. Variables that are either extern or not, such as 'acpi_gbl_FADT' in >> 'xen/include/acpi/acglobal.h', depending on >> DEFINE_ACPI_GLOBALS >> >> Below are the proposed resolution strategies: > >> 3. One possible resolution pattern is including 'acglobal.h' twice >> (either directly or indirectly trough acpi.h, if >> the latter does not cause other issues) like so: >> >> (assuming DEFINE_ACPI_GLOBALS is undefined here) >> #include "acglobal.h" >> #define DEFINE_ACPI_GLOBALS >> #include "acglobal.h" >> >> this way, the rule is followed properly, though it's not the >> prettiest >> pattern and also clashes with the objectives >> of D4.10 ("Precautions shall be taken in order to prevent the >> contents >> of a header file being included >> more than once"), but then a motivated exception is allowed there. > > Not really sure about this one. > > Jan If you can tell me more about why that header is defined the way it is (i.e. why it's used twice with DEFINE_ACPI_GLOBALS #defined and the other times without), maybe we can come up with better alternatives. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 14:12:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 14:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577183.904131 (Exim 4.92) (envelope-from ) id 1qRvXH-0000Ny-1Z; Fri, 04 Aug 2023 14:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577183.904131; Fri, 04 Aug 2023 14:12:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvXG-0000Nr-VC; Fri, 04 Aug 2023 14:12:10 +0000 Received: by outflank-mailman (input) for mailman id 577183; Fri, 04 Aug 2023 14:12:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRvXF-0000Nl-K6 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 14:12:09 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5139f66-32d0-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 16:12:07 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id CFB8D4EE0737; Fri, 4 Aug 2023 16:12:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5139f66-32d0-11ee-8613-37d641c3527e From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder Subject: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t Date: Fri, 4 Aug 2023 16:11:59 +0200 Message-Id: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between object and function declarations thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). Replace the occurrences of bool_t with bool. No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/common.c | 6 +++--- xen/arch/x86/include/asm/processor.h | 16 ++++++++-------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index cfcdaace12..5f29148416 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -26,11 +26,11 @@ bool __read_mostly opt_dom0_cpuid_faulting = true; -bool_t opt_arat = 1; +bool opt_arat = 1; boolean_param("arat", opt_arat); /* pku: Flag to enable Memory Protection Keys (default on). */ -static bool_t opt_pku = 1; +static bool opt_pku = 1; boolean_param("pku", opt_pku); unsigned int opt_cpuid_mask_ecx = ~0u; @@ -208,7 +208,7 @@ void ctxt_switch_levelling(const struct vcpu *next) alternative_vcall(ctxt_switch_masking, next); } -bool_t opt_cpu_info; +bool opt_cpu_info; boolean_param("cpuinfo", opt_cpu_info); int get_model_name(struct cpuinfo_x86 *c) diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h index 0989748be6..8d1909f73d 100644 --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -96,7 +96,7 @@ extern bool probe_cpuid_faulting(void); extern void ctxt_switch_levelling(const struct vcpu *next); extern void (*ctxt_switch_masking)(const struct vcpu *next); -extern bool_t opt_cpu_info; +extern bool opt_cpu_info; extern u32 trampoline_efer; extern u64 trampoline_misc_enable_off; @@ -109,17 +109,17 @@ extern unsigned int vaddr_bits; extern const struct x86_cpu_id *x86_match_cpu(const struct x86_cpu_id table[]); -extern void identify_cpu(struct cpuinfo_x86 *); -extern void setup_clear_cpu_cap(unsigned int); -extern void setup_force_cpu_cap(unsigned int); -extern bool is_forced_cpu_cap(unsigned int); +extern void identify_cpu(struct cpuinfo_x86 *c); +extern void setup_clear_cpu_cap(unsigned int cap); +extern void setup_force_cpu_cap(unsigned int cap); +extern bool is_forced_cpu_cap(unsigned int cap); extern void print_cpu_info(unsigned int cpu); extern void init_intel_cacheinfo(struct cpuinfo_x86 *c); #define cpu_to_core(_cpu) (cpu_data[_cpu].cpu_core_id) #define cpu_to_socket(_cpu) (cpu_data[_cpu].phys_proc_id) -unsigned int apicid_to_socket(unsigned int); +unsigned int apicid_to_socket(unsigned int apicid); static inline int cpu_nr_siblings(unsigned int cpu) { @@ -410,12 +410,12 @@ void show_registers(const struct cpu_user_regs *regs); #define dump_execution_state() \ run_in_exception_handler(show_execution_state_nonconst) void show_page_walk(unsigned long addr); -void noreturn fatal_trap(const struct cpu_user_regs *regs, bool_t show_remote); +void noreturn fatal_trap(const struct cpu_user_regs *regs, bool show_remote); extern void mtrr_ap_init(void); extern void mtrr_bp_init(void); -void mcheck_init(struct cpuinfo_x86 *c, bool_t bsp); +void mcheck_init(struct cpuinfo_x86 *c, bool bsp); void do_nmi(const struct cpu_user_regs *regs); void do_machine_check(const struct cpu_user_regs *regs); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577192.904161 (Exim 4.92) (envelope-from ) id 1qRwis-0008Gj-Nv; Fri, 04 Aug 2023 15:28:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577192.904161; Fri, 04 Aug 2023 15:28:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwis-0008Ee-Da; Fri, 04 Aug 2023 15:28:14 +0000 Received: by outflank-mailman (input) for mailman id 577192; Fri, 04 Aug 2023 15:28:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwir-00080a-0c for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85a05acc-32db-11ee-b26d-6b7b168915f2; Fri, 04 Aug 2023 17:28:11 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id C05BB4EE0742; Fri, 4 Aug 2023 17:28:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85a05acc-32db-11ee-b26d-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. Date: Fri, 4 Aug 2023 17:27:46 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable 'msec' shadows the local variable in 'ehci_dbgp_bios_handoff', but to prevent any future clashes, the one in the macro gains a suffix. No functional change. Signed-off-by: Nicola Vetrini --- Unless that file should remain as-is, because it's clearly taken from linux, but this does not prevent future name clashes with msec. --- xen/include/xen/delay.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h index 9d70ef035f..f2d9270e83 100644 --- a/xen/include/xen/delay.h +++ b/xen/include/xen/delay.h @@ -5,6 +5,6 @@ #include #define mdelay(n) (\ - {unsigned long msec=(n); while (msec--) udelay(1000);}) + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) #endif /* defined(_LINUX_DELAY_H) */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577190.904148 (Exim 4.92) (envelope-from ) id 1qRwis-00084T-2I; Fri, 04 Aug 2023 15:28:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577190.904148; Fri, 04 Aug 2023 15:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwir-000841-RG; Fri, 04 Aug 2023 15:28:13 +0000 Received: by outflank-mailman (input) for mailman id 577190; Fri, 04 Aug 2023 15:28:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwiq-00080Z-CJ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8479d03b-32db-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 17:28:09 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D589A4EE0740; Fri, 4 Aug 2023 17:28:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8479d03b-32db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 17:27:44 +0200 Message-Id: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable declared in the header file 'xen/arch/x86/include/asm/e820.h' is shadowed by many function parameters, so it is renamed to avoid these violations. No functional changes. Signed-off-by: Nicola Vetrini --- This patch is similar to other renames done on previous patches, and the preferred strategy there was to rename the global variable. This one has more occurrences that are spread in various files, but the general pattern is the same. --- xen/arch/x86/dom0_build.c | 10 ++-- xen/arch/x86/e820.c | 66 ++++++++++++------------ xen/arch/x86/guest/xen/xen.c | 4 +- xen/arch/x86/hvm/dom0_build.c | 6 +-- xen/arch/x86/include/asm/e820.h | 2 +- xen/arch/x86/mm.c | 49 +++++++++--------- xen/arch/x86/numa.c | 8 +-- xen/arch/x86/setup.c | 22 ++++---- xen/arch/x86/srat.c | 6 +-- xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- 11 files changed, 89 insertions(+), 88 deletions(-) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 8b1fcc6471..bfb6400376 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -534,13 +534,13 @@ int __init dom0_setup_permissions(struct domain *d) } /* Remove access to E820_UNUSABLE I/O regions above 1MB. */ - for ( i = 0; i < e820.nr_map; i++ ) + for ( i = 0; i < e820_map.nr_map; i++ ) { unsigned long sfn, efn; - sfn = max_t(unsigned long, paddr_to_pfn(e820.map[i].addr), 0x100ul); - efn = paddr_to_pfn(e820.map[i].addr + e820.map[i].size - 1); - if ( (e820.map[i].type == E820_UNUSABLE) && - (e820.map[i].size != 0) && + sfn = max_t(unsigned long, paddr_to_pfn(e820_map.map[i].addr), 0x100ul); + efn = paddr_to_pfn(e820_map.map[i].addr + e820_map.map[i].size - 1); + if ( (e820_map.map[i].type == E820_UNUSABLE) && + (e820_map.map[i].size != 0) && (sfn <= efn) ) rc |= iomem_deny_access(d, sfn, efn); } diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c index 0b89935510..4425011c01 100644 --- a/xen/arch/x86/e820.c +++ b/xen/arch/x86/e820.c @@ -34,7 +34,7 @@ boolean_param("e820-mtrr-clip", e820_mtrr_clip); static bool __initdata e820_verbose; boolean_param("e820-verbose", e820_verbose); -struct e820map e820; +struct e820map e820_map; struct e820map __initdata e820_raw; /* @@ -47,8 +47,8 @@ int __init e820_all_mapped(u64 start, u64 end, unsigned type) { unsigned int i; - for (i = 0; i < e820.nr_map; i++) { - struct e820entry *ei = &e820.map[i]; + for (i = 0; i < e820_map.nr_map; i++) { + struct e820entry *ei = &e820_map.map[i]; if (type && ei->type != type) continue; @@ -75,17 +75,17 @@ int __init e820_all_mapped(u64 start, u64 end, unsigned type) static void __init add_memory_region(unsigned long long start, unsigned long long size, int type) { - unsigned int x = e820.nr_map; + unsigned int x = e820_map.nr_map; - if (x == ARRAY_SIZE(e820.map)) { + if (x == ARRAY_SIZE(e820_map.map)) { printk(KERN_ERR "Ooops! Too many entries in the memory map!\n"); return; } - e820.map[x].addr = start; - e820.map[x].size = size; - e820.map[x].type = type; - e820.nr_map++; + e820_map.map[x].addr = start; + e820_map.map[x].size = size; + e820_map.map[x].type = type; + e820_map.nr_map++; } void __init print_e820_memory_map(const struct e820entry *map, @@ -347,13 +347,13 @@ static unsigned long __init find_max_pfn(void) unsigned int i; unsigned long max_pfn = 0; - for (i = 0; i < e820.nr_map; i++) { + for (i = 0; i < e820_map.nr_map; i++) { unsigned long start, end; /* RAM? */ - if (e820.map[i].type != E820_RAM) + if (e820_map.map[i].type != E820_RAM) continue; - start = PFN_UP(e820.map[i].addr); - end = PFN_DOWN(e820.map[i].addr + e820.map[i].size); + start = PFN_UP(e820_map.map[i].addr); + end = PFN_DOWN(e820_map.map[i].addr + e820_map.map[i].size); if (start >= end) continue; if (end > max_pfn) @@ -372,21 +372,21 @@ static void __init clip_to_limit(uint64_t limit, const char *warnmsg) for ( ; ; ) { /* Find a RAM region needing clipping. */ - for ( i = 0; i < e820.nr_map; i++ ) - if ( (e820.map[i].type == E820_RAM) && - ((e820.map[i].addr + e820.map[i].size) > limit) ) + for ( i = 0; i < e820_map.nr_map; i++ ) + if ( (e820_map.map[i].type == E820_RAM) && + ((e820_map.map[i].addr + e820_map.map[i].size) > limit) ) break; /* If none found, we are done. */ - if ( i == e820.nr_map ) - break; + if ( i == e820_map.nr_map ) + break; old_limit = max_t( - uint64_t, old_limit, e820.map[i].addr + e820.map[i].size); + uint64_t, old_limit, e820_map.map[i].addr + e820_map.map[i].size); /* We try to convert clipped RAM areas to E820_UNUSABLE. */ - if ( e820_change_range_type(&e820, max(e820.map[i].addr, limit), - e820.map[i].addr + e820.map[i].size, + if ( e820_change_range_type(&e820_map, max(e820_map.map[i].addr, limit), + e820_map.map[i].addr + e820_map.map[i].size, E820_RAM, E820_UNUSABLE) ) continue; @@ -394,15 +394,15 @@ static void __init clip_to_limit(uint64_t limit, const char *warnmsg) * If the type change fails (e.g., not space in table) then we clip or * delete the region as appropriate. */ - if ( e820.map[i].addr < limit ) + if ( e820_map.map[i].addr < limit ) { - e820.map[i].size = limit - e820.map[i].addr; + e820_map.map[i].size = limit - e820_map.map[i].addr; } else { - memmove(&e820.map[i], &e820.map[i+1], - (e820.nr_map - i - 1) * sizeof(struct e820entry)); - e820.nr_map--; + memmove(&e820_map.map[i], &e820_map.map[i+1], + (e820_map.nr_map - i - 1) * sizeof(struct e820entry)); + e820_map.nr_map--; } } @@ -497,7 +497,7 @@ static void __init reserve_dmi_region(void) if ( !what ) break; if ( ((base + len) > base) && - reserve_e820_ram(&e820, base, base + len) ) + reserve_e820_ram(&e820_map, base, base + len) ) printk("WARNING: %s table located in E820 RAM %"PRIpaddr"-%"PRIpaddr". Fixed.\n", what, base, base + len); } @@ -517,12 +517,12 @@ static void __init machine_specific_memory_setup(struct e820map *raw) if ( opt_availmem ) { - for ( i = size = 0; (i < e820.nr_map) && (size <= opt_availmem); i++ ) - if ( e820.map[i].type == E820_RAM ) - size += e820.map[i].size; + for ( i = size = 0; (i < e820_map.nr_map) && (size <= opt_availmem); i++ ) + if ( e820_map.map[i].type == E820_RAM ) + size += e820_map.map[i].size; if ( size > opt_availmem ) clip_to_limit( - e820.map[i-1].addr + e820.map[i-1].size - (size-opt_availmem), + e820_map.map[i-1].addr + e820_map.map[i-1].size - (size-opt_availmem), NULL); } @@ -694,10 +694,10 @@ unsigned long __init init_e820(const char *str, struct e820map *raw) machine_specific_memory_setup(raw); if ( cpu_has_hypervisor ) - hypervisor_e820_fixup(&e820); + hypervisor_e820_fixup(&e820_map); printk("%s RAM map:\n", str); - print_e820_memory_map(e820.map, e820.nr_map); + print_e820_memory_map(e820_map.map, e820_map.nr_map); return find_max_pfn(); } diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index f93dfc89f7..3ec828b98d 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -147,9 +147,9 @@ static void __init init_memmap(void) PFN_DOWN(GB(4) - 1))) ) panic("unable to add RAM to in-use PFN rangeset\n"); - for ( i = 0; i < e820.nr_map; i++ ) + for ( i = 0; i < e820_map.nr_map; i++ ) { - struct e820entry *e = &e820.map[i]; + struct e820entry *e = &e820_map.map[i]; if ( rangeset_add_range(mem, PFN_DOWN(e->addr), PFN_UP(e->addr + e->size - 1)) ) diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index bc0e290db6..98203f7a52 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -333,13 +333,13 @@ static __init void pvh_setup_e820(struct domain *d, unsigned long nr_pages) * Add an extra entry in case we have to split a RAM entry into a RAM and a * UNUSABLE one in order to truncate it. */ - d->arch.e820 = xzalloc_array(struct e820entry, e820.nr_map + 1); + d->arch.e820 = xzalloc_array(struct e820entry, e820_map.nr_map + 1); if ( !d->arch.e820 ) panic("Unable to allocate memory for Dom0 e820 map\n"); entry_guest = d->arch.e820; /* Clamp e820 memory map to match the memory assigned to Dom0 */ - for ( i = 0, entry = e820.map; i < e820.nr_map; i++, entry++ ) + for ( i = 0, entry = e820_map.map; i < e820_map.nr_map; i++, entry++ ) { *entry_guest = *entry; @@ -392,7 +392,7 @@ static __init void pvh_setup_e820(struct domain *d, unsigned long nr_pages) next: d->arch.nr_e820++; entry_guest++; - ASSERT(d->arch.nr_e820 <= e820.nr_map + 1); + ASSERT(d->arch.nr_e820 <= e820_map.nr_map + 1); } ASSERT(cur_pages == nr_pages); } diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e820.h index 213d5b5dd2..0865825f7d 100644 --- a/xen/arch/x86/include/asm/e820.h +++ b/xen/arch/x86/include/asm/e820.h @@ -34,7 +34,7 @@ extern int e820_add_range( extern unsigned long init_e820(const char *str, struct e820map *raw); extern void print_e820_memory_map(const struct e820entry *map, unsigned int entries); -extern struct e820map e820; +extern struct e820map e820_map; extern struct e820map e820_raw; /* These symbols live in the boot trampoline. */ diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index be2b10a391..6920ac939f 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -295,12 +295,12 @@ void __init arch_init_memory(void) /* Any areas not specified as RAM by the e820 map are considered I/O. */ for ( i = 0, pfn = 0; pfn < max_page; i++ ) { - while ( (i < e820.nr_map) && - (e820.map[i].type != E820_RAM) && - (e820.map[i].type != E820_UNUSABLE) ) + while ( (i < e820_map.nr_map) && + (e820_map.map[i].type != E820_RAM) && + (e820_map.map[i].type != E820_UNUSABLE) ) i++; - if ( i >= e820.nr_map ) + if ( i >= e820_map.nr_map ) { /* No more RAM regions: mark as I/O right to end of memory map. */ rstart_pfn = rend_pfn = max_page; @@ -309,9 +309,10 @@ void __init arch_init_memory(void) { /* Mark as I/O just up as far as next RAM region. */ rstart_pfn = min_t(unsigned long, max_page, - PFN_UP(e820.map[i].addr)); + PFN_UP(e820_map.map[i].addr)); rend_pfn = max_t(unsigned long, rstart_pfn, - PFN_DOWN(e820.map[i].addr + e820.map[i].size)); + PFN_DOWN(e820_map.map[i].addr + + e820_map.map[i].size)); } /* @@ -387,9 +388,9 @@ int page_is_ram_type(unsigned long mfn, unsigned long mem_type) uint64_t maddr = pfn_to_paddr(mfn); int i; - for ( i = 0; i < e820.nr_map; i++ ) + for ( i = 0; i < e820_map.nr_map; i++ ) { - switch ( e820.map[i].type ) + switch ( e820_map.map[i].type ) { case E820_RAM: if ( mem_type & RAM_TYPE_CONVENTIONAL ) @@ -414,8 +415,8 @@ int page_is_ram_type(unsigned long mfn, unsigned long mem_type) } /* Test the range. */ - if ( (e820.map[i].addr <= maddr) && - ((e820.map[i].addr + e820.map[i].size) >= (maddr + PAGE_SIZE)) ) + if ( (e820_map.map[i].addr <= maddr) && + ((e820_map.map[i].addr + e820_map.map[i].size) >= (maddr + PAGE_SIZE)) ) return 1; } @@ -427,17 +428,17 @@ unsigned int page_get_ram_type(mfn_t mfn) uint64_t last = 0, maddr = mfn_to_maddr(mfn); unsigned int i, type = 0; - for ( i = 0; i < e820.nr_map; - last = e820.map[i].addr + e820.map[i].size, i++ ) + for ( i = 0; i < e820_map.nr_map; + last = e820_map.map[i].addr + e820_map.map[i].size, i++ ) { - if ( (maddr + PAGE_SIZE) > last && maddr < e820.map[i].addr ) + if ( (maddr + PAGE_SIZE) > last && maddr < e820_map.map[i].addr ) type |= RAM_TYPE_UNKNOWN; - if ( (maddr + PAGE_SIZE) <= e820.map[i].addr || - maddr >= (e820.map[i].addr + e820.map[i].size) ) + if ( (maddr + PAGE_SIZE) <= e820_map.map[i].addr || + maddr >= (e820_map.map[i].addr + e820_map.map[i].size) ) continue; - switch ( e820.map[i].type ) + switch ( e820_map.map[i].type ) { case E820_RAM: type |= RAM_TYPE_CONVENTIONAL; @@ -778,9 +779,9 @@ bool is_memory_hole(mfn_t start, mfn_t end) unsigned long e = mfn_x(end); unsigned int i; - for ( i = 0; i < e820.nr_map; i++ ) + for ( i = 0; i < e820_map.nr_map; i++ ) { - const struct e820entry *entry = &e820.map[i]; + const struct e820entry *entry = &e820_map.map[i]; if ( !entry->size ) continue; @@ -4763,16 +4764,16 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) store = !guest_handle_is_null(ctxt.map.buffer); - if ( store && ctxt.map.nr_entries < e820.nr_map + 1 ) + if ( store && ctxt.map.nr_entries < e820_map.nr_map + 1 ) return -EINVAL; buffer = guest_handle_cast(ctxt.map.buffer, e820entry_t); if ( store && !guest_handle_okay(buffer, ctxt.map.nr_entries) ) return -EFAULT; - for ( i = 0, ctxt.n = 0, ctxt.s = 0; i < e820.nr_map; ++i, ++ctxt.n ) + for ( i = 0, ctxt.n = 0, ctxt.s = 0; i < e820_map.nr_map; ++i, ++ctxt.n ) { - unsigned long s = PFN_DOWN(e820.map[i].addr); + unsigned long s = PFN_DOWN(e820_map.map[i].addr); if ( s > ctxt.s ) { @@ -4786,12 +4787,12 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) } if ( store ) { - if ( ctxt.map.nr_entries <= ctxt.n + (e820.nr_map - i) ) + if ( ctxt.map.nr_entries <= ctxt.n + (e820_map.nr_map - i) ) return -EINVAL; - if ( __copy_to_guest_offset(buffer, ctxt.n, e820.map + i, 1) ) + if ( __copy_to_guest_offset(buffer, ctxt.n, e820_map.map + i, 1) ) return -EFAULT; } - ctxt.s = PFN_UP(e820.map[i].addr + e820.map[i].size); + ctxt.s = PFN_UP(e820_map.map[i].addr + e820_map.map[i].size); } if ( ctxt.s ) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 4b0b297c7e..76827f5f32 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -102,14 +102,14 @@ unsigned int __init arch_get_dma_bitsize(void) int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) { - if ( idx >= e820.nr_map ) + if ( idx >= e820_map.nr_map ) return -ENOENT; - if ( e820.map[idx].type != E820_RAM ) + if ( e820_map.map[idx].type != E820_RAM ) return -ENODATA; - *start = e820.map[idx].addr; - *end = *start + e820.map[idx].size; + *start = e820_map.map[idx].addr; + *end = *start + e820_map.map[idx].size; return 0; } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 80ae973d64..9c6003e374 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1163,7 +1163,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) } else if ( efi_enabled(EFI_BOOT) ) memmap_type = "EFI"; - else if ( (e820_raw.nr_map = + else if ( (e820_raw.nr_map = copy_bios_e820(e820_raw.map, ARRAY_SIZE(e820_raw.map))) != 0 ) { @@ -1300,13 +1300,13 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Create a temporary copy of the E820 map. */ - memcpy(&boot_e820, &e820, sizeof(e820)); + memcpy(&boot_e820, &e820_map, sizeof(e820_map)); /* Early kexec reservation (explicit static start address). */ nr_pages = 0; - for ( i = 0; i < e820.nr_map; i++ ) - if ( e820.map[i].type == E820_RAM ) - nr_pages += e820.map[i].size >> PAGE_SHIFT; + for ( i = 0; i < e820_map.nr_map; i++ ) + if ( e820_map.map[i].type == E820_RAM ) + nr_pages += e820_map.map[i].size >> PAGE_SHIFT; set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); kexec_reserve_area(&boot_e820); @@ -1631,7 +1631,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned long e = min(s + PFN_UP(kexec_crash_area.size), PFN_UP(__pa(HYPERVISOR_VIRT_END - 1))); - if ( e > s ) + if ( e > s ) map_pages_to_xen((unsigned long)__va(kexec_crash_area.start), _mfn(s), e - s, PAGE_HYPERVISOR); } @@ -1677,9 +1677,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) PAGE_HYPERVISOR_RO); nr_pages = 0; - for ( i = 0; i < e820.nr_map; i++ ) - if ( e820.map[i].type == E820_RAM ) - nr_pages += e820.map[i].size >> PAGE_SHIFT; + for ( i = 0; i < e820_map.nr_map; i++ ) + if ( e820_map.map[i].type == E820_RAM ) + nr_pages += e820_map.map[i].size >> PAGE_SHIFT; printk("System RAM: %luMB (%lukB)\n", nr_pages >> (20 - PAGE_SHIFT), nr_pages << (PAGE_SHIFT - 10)); @@ -1771,7 +1771,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, new_tlbflush_clock_period); - if ( opt_watchdog ) + if ( opt_watchdog ) nmi_watchdog = NMI_LOCAL_APIC; find_smp_config(); @@ -1983,7 +1983,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) do_initcalls(); - if ( opt_watchdog ) + if ( opt_watchdog ) watchdog_setup(); if ( !tboot_protect_mem_regions() ) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 3f70338e6e..bbd04978ae 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -301,11 +301,11 @@ void __init srat_parse_regions(paddr_t addr) acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY, srat_parse_region, 0); - for (mask = srat_region_mask, i = 0; mask && i < e820.nr_map; i++) { - if (e820.map[i].type != E820_RAM) + for (mask = srat_region_mask, i = 0; mask && i < e820_map.nr_map; i++) { + if (e820_map.map[i].type != E820_RAM) continue; - if (~mask & pdx_region_mask(e820.map[i].addr, e820.map[i].size)) + if (~mask & pdx_region_mask(e820_map.map[i].addr, e820_map.map[i].size)) mask = 0; } diff --git a/xen/arch/x86/x86_64/mmconf-fam10h.c b/xen/arch/x86/x86_64/mmconf-fam10h.c index a834ab3149..bbebf9219f 100644 --- a/xen/arch/x86/x86_64/mmconf-fam10h.c +++ b/xen/arch/x86/x86_64/mmconf-fam10h.c @@ -135,7 +135,7 @@ static void __init get_fam10h_pci_mmconf_base(void) return; out: - if (e820_add_range(&e820, start, start + SIZE, E820_RESERVED)) + if (e820_add_range(&e820_map, start, start + SIZE, E820_RESERVED)) fam10h_pci_mmconf_base = start; } diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index 3b577c9b39..7ad9e12b8a 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -418,7 +418,7 @@ static int __init parse_ivmd_block(const struct acpi_ivrs_memory *ivmd_block) if ( type == RAM_TYPE_UNKNOWN ) { - if ( e820_add_range(&e820, addr, addr + PAGE_SIZE, + if ( e820_add_range(&e820_map, addr, addr + PAGE_SIZE, E820_RESERVED) ) continue; AMD_IOMMU_ERROR("IVMD: page at %lx couldn't be reserved\n", -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577195.904203 (Exim 4.92) (envelope-from ) id 1qRwiv-00012h-Mf; Fri, 04 Aug 2023 15:28:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577195.904203; Fri, 04 Aug 2023 15:28:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwiv-00010p-FN; Fri, 04 Aug 2023 15:28:17 +0000 Received: by outflank-mailman (input) for mailman id 577195; Fri, 04 Aug 2023 15:28:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwit-00080Z-Vc for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:15 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 872664d2-32db-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 17:28:14 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 7446F4EE0745; Fri, 4 Aug 2023 17:28:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 872664d2-32db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 6/6] x86: refactor macros in 'xen-mca.h' to address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 17:27:49 +0200 Message-Id: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macros defined 'xen/include/public/arch-x86/xen-mca.h' have needless underscore prefixes for parameter names and variable names that cause shadowing with e.g. the variable 'i' in function 'mce_action'. Therefore, the renaming aims to resolve present shadowing issues and lessen the probability of future ones. No functional change. Signed-off-by: Nicola Vetrini --- The spirit of this patch is similar to this one [1] made by Jan that arose from a violation of this rule. [1] https://gitlab.com/xen-project/xen/-/commit/c0579c65f6bef794cd449fbc946feacccf485f2e --- xen/include/public/arch-x86/xen-mca.h | 38 +++++++++++++-------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xen/include/public/arch-x86/xen-mca.h b/xen/include/public/arch-x86/xen-mca.h index b897536ec5..55b999ab21 100644 --- a/xen/include/public/arch-x86/xen-mca.h +++ b/xen/include/public/arch-x86/xen-mca.h @@ -280,39 +280,39 @@ DEFINE_XEN_GUEST_HANDLE(xen_mc_logical_cpu_t); /* Prototype: * uint32_t x86_mcinfo_nentries(struct mc_info *mi); */ -#define x86_mcinfo_nentries(_mi) \ - (_mi)->mi_nentries +#define x86_mcinfo_nentries(mi) \ + (mi)->mi_nentries /* Prototype: * struct mcinfo_common *x86_mcinfo_first(struct mc_info *mi); */ -#define x86_mcinfo_first(_mi) \ - ((struct mcinfo_common *)(_mi)->mi_data) +#define x86_mcinfo_first(mi) \ + ((struct mcinfo_common *)(mi)->mi_data) /* Prototype: * struct mcinfo_common *x86_mcinfo_next(struct mcinfo_common *mic); */ -#define x86_mcinfo_next(_mic) \ - ((struct mcinfo_common *)((uint8_t *)(_mic) + (_mic)->size)) +#define x86_mcinfo_next(mic) \ + ((struct mcinfo_common *)((uint8_t *)(mic) + (mic)->size)) /* Prototype: - * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t type); + * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t mc_type); */ -#define x86_mcinfo_lookup(_ret, _mi, _type) \ +#define x86_mcinfo_lookup(ret, mi, mc_type) \ do { \ - uint32_t found, i; \ - struct mcinfo_common *_mic; \ + uint32_t found_, i_; \ + struct mcinfo_common *mic_; \ \ - found = 0; \ - (_ret) = NULL; \ - if (_mi == NULL) break; \ - _mic = x86_mcinfo_first(_mi); \ - for (i = 0; i < x86_mcinfo_nentries(_mi); i++) { \ - if (_mic->type == (_type)) { \ - found = 1; \ + found_ = 0; \ + (ret) = NULL; \ + if (mi == NULL) break; \ + mic_ = x86_mcinfo_first(mi); \ + for (i_ = 0; i_ < x86_mcinfo_nentries(mi); i_++) { \ + if (mic_->type == (mc_type)) { \ + found_ = 1; \ break; \ } \ - _mic = x86_mcinfo_next(_mic); \ + mic_ = x86_mcinfo_next(mic_); \ } \ - (_ret) = found ? _mic : NULL; \ + (ret) = found_ ? mic_ : NULL; \ } while (0) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577189.904141 (Exim 4.92) (envelope-from ) id 1qRwir-000812-Lp; Fri, 04 Aug 2023 15:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577189.904141; Fri, 04 Aug 2023 15:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwir-00080v-J5; Fri, 04 Aug 2023 15:28:13 +0000 Received: by outflank-mailman (input) for mailman id 577189; Fri, 04 Aug 2023 15:28:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwiq-00080Z-5M for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 841a11cc-32db-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 17:28:09 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D61F84EE0737; Fri, 4 Aug 2023 17:28:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 841a11cc-32db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: [XEN PATCH 0/6] xen: address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 17:27:43 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series addresses shadowing issues to resolve violations of Rule 5.3, whose headline states: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". To do this, suitable renames are made. In some cases global objects are modified, while other modifications concern local variables, possibly lessening the probability of future clashes from occurring, by suffixing variables in some macros. No functional change. Nicola Vetrini (6): x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 libelf: address MISRA C:2012 Rule 5.3 xen/delay: address MISRA C:2012 Rule 5.3. x86/include: address MISRA C:2012 Rule 5.3. x86/xstate: address MISRA C:2012 Rule 5.3 x86: refactor macros in 'xen-mca.h' to address MISRA C:2012 Rule 5.3 xen/arch/x86/dom0_build.c | 10 ++-- xen/arch/x86/e820.c | 66 ++++++++++++------------ xen/arch/x86/guest/xen/xen.c | 4 +- xen/arch/x86/hvm/dom0_build.c | 6 +-- xen/arch/x86/include/asm/e820.h | 2 +- xen/arch/x86/include/asm/mpspec.h | 2 +- xen/arch/x86/mm.c | 49 +++++++++--------- xen/arch/x86/numa.c | 8 +-- xen/arch/x86/setup.c | 22 ++++---- xen/arch/x86/srat.c | 6 +-- xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- xen/arch/x86/xstate.c | 30 +++++------ xen/common/libelf/libelf-tools.c | 24 ++++----- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- xen/include/public/arch-x86/xen-mca.h | 38 +++++++------- xen/include/xen/delay.h | 2 +- 16 files changed, 137 insertions(+), 136 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577191.904155 (Exim 4.92) (envelope-from ) id 1qRwis-0008Aw-Bc; Fri, 04 Aug 2023 15:28:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577191.904155; Fri, 04 Aug 2023 15:28:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwis-00089g-3f; Fri, 04 Aug 2023 15:28:14 +0000 Received: by outflank-mailman (input) for mailman id 577191; Fri, 04 Aug 2023 15:28:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwiq-00080a-Pm for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8517a4f9-32db-11ee-b26d-6b7b168915f2; Fri, 04 Aug 2023 17:28:11 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id C39364EE0741; Fri, 4 Aug 2023 17:28:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8517a4f9-32db-11ee-b26d-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 2/6] libelf: address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 17:27:45 +0200 Message-Id: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h' shadow the variables in the modified function, hence violating Rule 5.3. Therefore, the rename takes care of the shadowing. No functional changes. Signed-off-by: Nicola Vetrini --- xen/common/libelf/libelf-tools.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/common/libelf/libelf-tools.c b/xen/common/libelf/libelf-tools.c index a9edb6a8dc..f0d5da1abf 100644 --- a/xen/common/libelf/libelf-tools.c +++ b/xen/common/libelf/libelf-tools.c @@ -91,10 +91,10 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base, { elf_ptrval ptrval = base + moreoffset; bool need_swap = elf_swap(elf); - const uint8_t *u8; - const uint16_t *u16; - const uint32_t *u32; - const uint64_t *u64; + const uint8_t *uint8; + const uint16_t *uint16; + const uint32_t *uint32; + const uint64_t *uint64; if ( !elf_access_ok(elf, ptrval, size) ) return 0; @@ -102,17 +102,17 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base, switch ( size ) { case 1: - u8 = (const void*)ptrval; - return *u8; + uint8 = (const void*)ptrval; + return *uint8; case 2: - u16 = (const void*)ptrval; - return need_swap ? bswap_16(*u16) : *u16; + uint16 = (const void*)ptrval; + return need_swap ? bswap_16(*uint16) : *uint16; case 4: - u32 = (const void*)ptrval; - return need_swap ? bswap_32(*u32) : *u32; + uint32 = (const void*)ptrval; + return need_swap ? bswap_32(*uint32) : *uint32; case 8: - u64 = (const void*)ptrval; - return need_swap ? bswap_64(*u64) : *u64; + uint64 = (const void*)ptrval; + return need_swap ? bswap_64(*uint64) : *uint64; default: return 0; } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577194.904187 (Exim 4.92) (envelope-from ) id 1qRwiu-0000aN-Ck; Fri, 04 Aug 2023 15:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577194.904187; Fri, 04 Aug 2023 15:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwiu-0000YN-4z; Fri, 04 Aug 2023 15:28:16 +0000 Received: by outflank-mailman (input) for mailman id 577194; Fri, 04 Aug 2023 15:28:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwis-00080Z-Ap for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:14 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 863935ce-32db-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 17:28:12 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D99AB4EE0743; Fri, 4 Aug 2023 17:28:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 863935ce-32db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 4/6] x86/include: address MISRA C:2012 Rule 5.3. Date: Fri, 4 Aug 2023 17:27:47 +0200 Message-Id: <40823fbaa9e0a9b026e5ff3b01af9d83583889fd.1691162261.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit s/mpc_default_type/mpc_default in 'xen/arch/x86/include/asm/mpspec.h' to avoid clashing with function parameter names in 'mpparse.c'. No functional changes. Signed-off-by: Nicola Vetrini --- Even though the global variable does not seem to be used anywhere and is perhaps better to remove it entirely. --- xen/arch/x86/include/asm/mpspec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h index 1246eece0b..cc96ee63bd 100644 --- a/xen/arch/x86/include/asm/mpspec.h +++ b/xen/arch/x86/include/asm/mpspec.h @@ -15,7 +15,7 @@ extern void get_smp_config (void); extern unsigned char apic_version [MAX_APICS]; extern int mp_irq_entries; extern struct mpc_config_intsrc mp_irqs [MAX_IRQ_SOURCES]; -extern int mpc_default_type; +extern int mpc_default; extern unsigned long mp_lapic_addr; extern bool pic_mode; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:28:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:28:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577193.904182 (Exim 4.92) (envelope-from ) id 1qRwiu-0000WS-1k; Fri, 04 Aug 2023 15:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577193.904182; Fri, 04 Aug 2023 15:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwit-0000WF-U1; Fri, 04 Aug 2023 15:28:15 +0000 Received: by outflank-mailman (input) for mailman id 577193; Fri, 04 Aug 2023 15:28:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwis-00080a-36 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:28:14 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86b2be7b-32db-11ee-b26d-6b7b168915f2; Fri, 04 Aug 2023 17:28:13 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id A877E4EE0744; Fri, 4 Aug 2023 17:28:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86b2be7b-32db-11ee-b26d-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 5/6] x86/xstate: address MISRA C:2012 Rule 5.3 Date: Fri, 4 Aug 2023 17:27:48 +0200 Message-Id: <1ea70e5f8293fdca2bb69ec75f532722136e52a5.1691162261.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename the local variables to avoid clashing with function 'xstate' defined below, but declared in the corresponding header file. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/x86/xstate.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 3d566252ea..180455b26d 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -174,10 +174,10 @@ static void setup_xstate_comp(uint16_t *comp_offsets, */ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) { - const struct xsave_struct *xsave = v->arch.xsave_area; + const struct xsave_struct *xsave_area = v->arch.xsave_area; const void *src; uint16_t comp_offsets[sizeof(xfeature_mask)*8]; - u64 xstate_bv = xsave->xsave_hdr.xstate_bv; + u64 xstate_bv = xsave_area->xsave_hdr.xstate_bv; u64 valid; /* Check there is state to serialise (i.e. at least an XSAVE_HDR) */ @@ -185,19 +185,19 @@ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) /* Check there is the correct room to decompress into. */ BUG_ON(size != xstate_ctxt_size(v->arch.xcr0_accum)); - if ( !(xsave->xsave_hdr.xcomp_bv & XSTATE_COMPACTION_ENABLED) ) + if ( !(xsave_area->xsave_hdr.xcomp_bv & XSTATE_COMPACTION_ENABLED) ) { - memcpy(dest, xsave, size); + memcpy(dest, xsave_area, size); return; } - ASSERT(xsave_area_compressed(xsave)); - setup_xstate_comp(comp_offsets, xsave->xsave_hdr.xcomp_bv); + ASSERT(xsave_area_compressed(xsave_area)); + setup_xstate_comp(comp_offsets, xsave_area->xsave_hdr.xcomp_bv); /* * Copy legacy XSAVE area and XSAVE hdr area. */ - memcpy(dest, xsave, XSTATE_AREA_MIN_SIZE); + memcpy(dest, xsave_area, XSTATE_AREA_MIN_SIZE); memset(dest + XSTATE_AREA_MIN_SIZE, 0, size - XSTATE_AREA_MIN_SIZE); ((struct xsave_struct *)dest)->xsave_hdr.xcomp_bv = 0; @@ -206,7 +206,7 @@ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) * Copy each region from the possibly compacted offset to the * non-compacted offset. */ - src = xsave; + src = xsave_area; valid = xstate_bv & ~XSTATE_FP_SSE; while ( valid ) { @@ -239,7 +239,7 @@ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) */ void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size) { - struct xsave_struct *xsave = v->arch.xsave_area; + struct xsave_struct *xsave_area = v->arch.xsave_area; void *dest; uint16_t comp_offsets[sizeof(xfeature_mask)*8]; u64 xstate_bv, valid; @@ -252,7 +252,7 @@ void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size) if ( !(v->arch.xcr0_accum & XSTATE_XSAVES_ONLY) ) { - memcpy(xsave, src, size); + memcpy(xsave_area, src, size); return; } @@ -260,19 +260,19 @@ void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size) * Copy legacy XSAVE area, to avoid complications with CPUID * leaves 0 and 1 in the loop below. */ - memcpy(xsave, src, FXSAVE_SIZE); + memcpy(xsave_area, src, FXSAVE_SIZE); /* Set XSTATE_BV and XCOMP_BV. */ - xsave->xsave_hdr.xstate_bv = xstate_bv; - xsave->xsave_hdr.xcomp_bv = v->arch.xcr0_accum | XSTATE_COMPACTION_ENABLED; + xsave_area->xsave_hdr.xstate_bv = xstate_bv; + xsave_area->xsave_hdr.xcomp_bv = v->arch.xcr0_accum | XSTATE_COMPACTION_ENABLED; - setup_xstate_comp(comp_offsets, xsave->xsave_hdr.xcomp_bv); + setup_xstate_comp(comp_offsets, xsave_area->xsave_hdr.xcomp_bv); /* * Copy each region from the non-compacted offset to the * possibly compacted offset. */ - dest = xsave; + dest = xsave_area; valid = xstate_bv & ~XSTATE_FP_SSE; while ( valid ) { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 04 15:38:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 15:38:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577225.904212 (Exim 4.92) (envelope-from ) id 1qRwsP-0004Uj-JO; Fri, 04 Aug 2023 15:38:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577225.904212; Fri, 04 Aug 2023 15:38:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwsP-0004Uc-Fv; Fri, 04 Aug 2023 15:38:05 +0000 Received: by outflank-mailman (input) for mailman id 577225; Fri, 04 Aug 2023 15:38:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRwsO-0004UW-98 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 15:38:04 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5ac15be-32dc-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 17:38:02 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 0235D4EE0737; Fri, 4 Aug 2023 17:38:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5ac15be-32dc-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Fri, 04 Aug 2023 17:38:01 +0200 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 6/6] x86: refactor macros in 'xen-mca.h' to address MISRA C:2012 Rule 5.3 In-Reply-To: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> References: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit > - _mic = x86_mcinfo_next(_mic); \ > + mic_ = x86_mcinfo_next(mic_); \ > } \ > - (_ret) = found ? _mic : NULL; \ > + (ret) = found_ ? mic_ : NULL; \ > } while (0) > > > -- > 2.34.1 Stray blanks here, sorry. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 16:17:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 16:17:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577230.904222 (Exim 4.92) (envelope-from ) id 1qRxUS-00014g-Fn; Fri, 04 Aug 2023 16:17:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577230.904222; Fri, 04 Aug 2023 16:17:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxUS-00014Z-DA; Fri, 04 Aug 2023 16:17:24 +0000 Received: by outflank-mailman (input) for mailman id 577230; Fri, 04 Aug 2023 16:17:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxUR-00014P-34; Fri, 04 Aug 2023 16:17:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxUQ-0008Jm-VL; Fri, 04 Aug 2023 16:17:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxUQ-00043C-Ge; Fri, 04 Aug 2023 16:17:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRxUQ-0002iE-G8; Fri, 04 Aug 2023 16:17:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=laVUtdiIThJ0etkjNZYrtc50AHypv9NkrlJJ3itiy80=; b=kut+SEaL5CW7oYe5dTWmG73Srq ldQjFd4KfolwBbBjsD0Fo+sEHKdDtPxJ8okcLk8G6GHz6R6Bniz7n2XD+hDXCiEYSe7Bu5ZaW93xZ ISTm3ou30nQs8vu6RP+JmbcbY27cT8Ei7XxUZm61ZmNI3CTZul2qLRmhVzJkTsyW1Iys=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182171: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c167c80b463768e04a22fbe37ba6c53a4a08e41e X-Osstest-Versions-That: qemuu=38a6de80b917b2a822cff0e38d83563ab401c890 From: osstest service owner Date: Fri, 04 Aug 2023 16:17:22 +0000 flight 182171 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182171/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182114 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182114 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182114 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182114 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182114 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182114 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182114 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182114 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu c167c80b463768e04a22fbe37ba6c53a4a08e41e baseline version: qemuu 38a6de80b917b2a822cff0e38d83563ab401c890 Last test of basis 182114 2023-08-02 10:38:51 Z 2 days Testing same since 182171 2023-08-03 17:26:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Daniel P. BerrangĂ© David Woodhouse Hyman Huang(黄勇) Keith Packard Marc-Andre Lureau Marc-AndrĂ© Lureau Markus Armbruster Peter Maydell Peter Xu Philippe Mathieu-DaudĂ© Richard Henderson Stefan Weil Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 38a6de80b9..c167c80b46 c167c80b463768e04a22fbe37ba6c53a4a08e41e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Aug 04 16:18:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 16:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577233.904231 (Exim 4.92) (envelope-from ) id 1qRxVB-0001at-Sr; Fri, 04 Aug 2023 16:18:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577233.904231; Fri, 04 Aug 2023 16:18:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxVB-0001am-QE; Fri, 04 Aug 2023 16:18:09 +0000 Received: by outflank-mailman (input) for mailman id 577233; Fri, 04 Aug 2023 16:18:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxVA-0001Yw-Ue; Fri, 04 Aug 2023 16:18:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxVA-0008KW-Tk; Fri, 04 Aug 2023 16:18:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRxVA-000448-L2; Fri, 04 Aug 2023 16:18:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qRxVA-0003Gp-KY; Fri, 04 Aug 2023 16:18:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hc4gWUUX0+ihCFrSMSmg+LJhWyQIBCAfevyV8UZ24fM=; b=EHkPdS6IE4gpkuybOl5VUMjxx2 QoO+tRGdU105XgDP18XI+QAmNShvZXyBBsAXVDjUhRN0PIqk/fFGA4U8Xpo8Fz2a0FeYaG/6ss5xF xVvWXgFyyfs2y/2xEVrCI4P6+yU/solLnemthhK3wD+nq0tWXAA+GPu59uisfMYgHW08=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182184: all pass - PUSHED X-Osstest-Versions-This: ovmf=2d8c17a9b61ad298986daffe5373026c3b88c741 X-Osstest-Versions-That: ovmf=01ad4134c3e6339ac53c85fccf62ed10d5b6d662 From: osstest service owner Date: Fri, 04 Aug 2023 16:18:08 +0000 flight 182184 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182184/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2d8c17a9b61ad298986daffe5373026c3b88c741 baseline version: ovmf 01ad4134c3e6339ac53c85fccf62ed10d5b6d662 Last test of basis 182176 2023-08-04 01:40:49 Z 0 days Testing same since 182184 2023-08-04 14:44:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Oliver Steffen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 01ad4134c3..2d8c17a9b6 2d8c17a9b61ad298986daffe5373026c3b88c741 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Aug 04 17:20:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 17:20:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577247.904242 (Exim 4.92) (envelope-from ) id 1qRyT3-0008BJ-5Y; Fri, 04 Aug 2023 17:20:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577247.904242; Fri, 04 Aug 2023 17:20:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRyT3-0008BC-1v; Fri, 04 Aug 2023 17:20:01 +0000 Received: by outflank-mailman (input) for mailman id 577247; Fri, 04 Aug 2023 17:19:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRyT1-00089b-DG for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 17:19:59 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1eea161b-32eb-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 19:19:53 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 10:19:49 -0700 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 04 Aug 2023 10:19:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 10:19:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 4 Aug 2023 10:19:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 4 Aug 2023 10:19:49 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by SA2PR11MB4986.namprd11.prod.outlook.com (2603:10b6:806:114::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Fri, 4 Aug 2023 17:19:45 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 17:19:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1eea161b-32eb-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691169593; x=1722705593; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xVasWhZGvr4Oc2XQI54Al45p83D2/CvBY9/HLZe60Pk=; b=Vi2ERNlfCuEX4liiUweqP8uIPgu5SKq6V6Qaq+9N5hmqmZuBlCzoAY31 3G2ZDltwjJVJ2fw0DnfNnZCZzk+J8D+wwl2gBwZPknzDahVZnqwPfdsrt vv46eF49ru5D/A6T9fmqN+KTsmHS0zb0fo46KC0c1HyZkUfQjswCVTnww 32NQkPRxwCg4XPMbooWtonoz42KbGaRy4awl2pjoFcpAzBrs1Qk93wFRR 23EAStdGQIk0XZtzGlz8axdOa4dQB0lGnYa7O623NBi4Njn2hCxCzh2fF ISSuxdKXwSwU+c1IG5FRx73Cg3QC7terHjl50Gv3WPCGJflpGCBRvT7zd w==; X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="456581000" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="456581000" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="844155984" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="844155984" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLB4ig2KOeJefJjIFM+ZP8qbBZS6EWDgS9l3x6fCtCkVLaq91kJmtiQh0/Syl3x2Ob5KfMaIGCMve5aWjQwmZRX3eGB62IXPGcGFYShl1rE5cXQyg2s9d0OhCnNKcgMilY7uMSRqqUHUxXmLkwcQAg1YNTjax49fNEQd+5P+RfW+Wxj3yGZBYp3v9OrZws23eGn0FUWEmwwtLUlyFiWm8FRfruPy7Tvee5l7/EhjPAv+94HsxNM9oqUG70JRrrxFk/DFImcmNibRai8haLLxNsmRogus765JDUOnbbJjDUoXLg7n/oTMGHadafIEJYUrqqoIrjxZsw2y0suVWVFxlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xVasWhZGvr4Oc2XQI54Al45p83D2/CvBY9/HLZe60Pk=; b=D++4ErjwSBUiVYNTy8BDsH37IOlzPsqdOZgxnLyUJ0B3o3LEKi6pyk/o42qReCd9eXhtzM6bsPVziqFWaRde5kiDdUO7IINpSwgOo7NIO27GnQmrF83hg4VMJoCOjE48WjtBwUAW2dQFHl6nQqjMlknRB3gXgOPCA6kitceCoAw3/OUbLpqjfPu54tvhndwc6Ku4cXDPcdc2oKj2SOCCp4TNfrkB38GkyYPVEu/7J4BmCtWzgPbOszOhqyL6ixN7FqiDJ4oN2hSxvZgS858muPxUJtRnCr/N8zVignc6Pal4dLVjaI+bX4as7JRk72jKGEz/iU49yaoOs3ljbYbeCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: "andrew.cooper3@citrix.com" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" CC: "Lutomirski, Andy" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Peter Zijlstra , "Gross, Jurgen" , "Ostrovsky, Boris" Subject: RE: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Thread-Topic: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Thread-Index: AQHZxq1luoPee3LE20qWOZPEmJublq/Z7qYAgABzAbA= Date: Fri, 4 Aug 2023 17:19:45 +0000 Message-ID: References: <20230804075734.8372-1-xin3.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|SA2PR11MB4986:EE_ x-ms-office365-filtering-correlation-id: 64911bf5-23cf-4ebb-63ae-08db950eff77 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Oo0yUJGDlLh4fxAzBSVmUJTL58GOLjzLxXz2xgkpEZ2VFkVbqWpSLQzjCpk31Ynsne8C1EGuqKYE62aY4eZ7vEOieyKtQQTEQBqLHjJYN8RJQYH9rOQO690MPq4bTk46m7Xz6gjaGFZakfLnym8gW8+ybQZeHJbYV1LKwVq2ysfkR7Q+ag+QlNZvvdFixr92HIvrjLUL/IXblBiRH29FwHs7MMa4g1GnJV3H8xBKoF/iGniRBuV8zX/gblbGvBnm3cK4deMHJJBWbmcv4W0d19e8QnC70CCpxCvKW88Q2EpZ3V3Kq4BD+UYf/Y4QIkE0pYBgC+P9wW13eIGDNb5eqQCZV4+gjBdg9e72xGKvTMsvbuV69xJvQVlJyscXMZIntgyVwPx6emPGbbKXhk5NBj4NWRITyNRuTedtNQTCEcSmk22i3meGxNT6padlY8MJHxBmfAfCDtwRcN59zfAbfUOwO83bsUwD2XSoh6Q92X9jTGlX/xCQaWwFuWU7Z4QFpo/TIMdeyMgJnF7SsCVcae0ATChpU57oPc2qE6oJopZ7+PIiM2yMeMip7aBHHvfEJBFvwksdjNUR6PcYyJGoLwHkchQ0bG37G5vtCK5aQK5oYvSXb48M24zjru5EjKehtrK98yccsPXFr4CIRrdJMg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(366004)(396003)(39860400002)(186006)(451199021)(1800799003)(52536014)(66476007)(66946007)(66446008)(66556008)(64756008)(4326008)(76116006)(2906002)(38100700002)(122000001)(53546011)(82960400001)(38070700005)(6506007)(7416002)(83380400001)(54906003)(110136005)(55016003)(86362001)(9686003)(26005)(478600001)(7696005)(71200400001)(33656002)(4744005)(8936002)(8676002)(5660300002)(41300700001)(316002)(26583001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OHcwYWhnMWZKRUdBT2F5MnMyalBBQk1ZZjRRVno3M2JGWFJ3M3h1dlBOMVZl?= =?utf-8?B?QTZCUHlTUmZJSjdMTGZHZXVobXZyRGsrSjd3cDhQVGh4L0JzSTdTMzFnSmVE?= =?utf-8?B?VnNLN2xBeFRORlBDZHNvTGxLbHRwdUxmK2dTMkVERFNIUFJJZEVjQ2tva0F6?= =?utf-8?B?Tk9sdHJ4NkEzT3JPOE01d0sxYjFaZG5PdGFLT1hPdE56YzIySWhYVDh5WmVn?= =?utf-8?B?SVBtNm1JNmI4U1p3MnhWTzlidHF2ditMN3k3bGMxV2UrSmNtUTdDbG0xaklP?= =?utf-8?B?SndOVzFKSUxQeXNEeU1DVjBlMlpzZk1jOVdXVTZPTTZuQnpxTlFaSG9kRTFw?= =?utf-8?B?UmdSbUlEaDZrdzZRTHdESVZNOUdWQU5WNlluc3FIVTM1TFNHVGxicW1pRVZI?= =?utf-8?B?NStmVUYzN1d4ZXpJa1pWT0loRU91SHlmOXphTUF4Wm1OS2NmNGdrZnRZVlJ3?= =?utf-8?B?OEtLK21Oc29mb2drVDZTeEV1SU90OTY4dVhPSDhXajZWZFR5M2k4clRNM3h1?= =?utf-8?B?OUl4NjN2bStIQmRQenE1ZkgzZXVpUC9UMmNwdlBvb3hpRWVkSHFXblVKc2J0?= =?utf-8?B?bk41RkZHVVp3ZVlBZ1pMSDVwcHMvbDNMY3lJd3ExUVJuM2JveGszVG1hb0h1?= =?utf-8?B?N0ZzNVdwMnlrTmlzaEdhWUNPaCtFOUxhVWU5QmJFbURYQWtYbU03bHpzRTJn?= =?utf-8?B?V0QrbzcyUEZFMG5kT2dXNWNXdEt6MlFzV0c2ekVhTTExNTRRSktRUStlanBa?= =?utf-8?B?L2JwOTJRc3UzNWR5clhmdzJUR3VvVlU4SjFRRFMyQ0NiNXY5ekFnaGpGSFox?= =?utf-8?B?YnVsek5McFlURzc4YmhERGJWdWZIZlNVU2pDNndYeHZhODRtaVRYRmRyaU1k?= =?utf-8?B?ZjNiSVEweEJzNlpDZU5DTU04M3JYYnVTSCsrNlRXbW1wZzVUc1hoWXQ1aU1C?= =?utf-8?B?Z25aU3ZHdUFISmtrejFiSmNXVkZoU0xsbElSeWtmRGlrWk5PR01pWnNTcWRG?= =?utf-8?B?QmE3bmJIZVQ2cjUycjc4bGZPa3NlbG4rK3ptUUU2OEJCNzdqMHBTbEwyR1Mr?= =?utf-8?B?T0hXODVOSDhLaG1BRDZsUHhORmhCMXl2THVmS0huTGQybEhuSXJkM0N1ME9h?= =?utf-8?B?VkV6WGJ4dUl5c29YdGh0eHg5Q3A2cko0YmtiMEhIeVYwWGtwWFlNQTYreHVH?= =?utf-8?B?RXEwSHpZRzNIRUFYMVIxZ2Zja3ZNaGFPRUc4MEsyTzVDK3QxQ1c2VERNenFu?= =?utf-8?B?Wlc0MzJkQmpYczV0Rklndm82anptT2lOTW5YTHVqUlpHcEtWTHB2cHlldTFx?= =?utf-8?B?VU03c2ZKOUMzdkNDRUhDWjRSWGRlaVE4Si91VWRvaDI3Yks3SFpHbCswTXEx?= =?utf-8?B?SEhCUVZRNzZabFVTRkc2M04xdmcvbVJQWTRJcXJjT2ZtOUNjbXIxS0FTeWNM?= =?utf-8?B?QTJsZkdJTnVtb3NRZVJNODEwQ1U5UjB4TzVGMHFOQ0x4TVNHYVVXeGJSVUtX?= =?utf-8?B?MHM4R3pTVWFTeXFNQ1QzLzBuWTBZSy9UamRQV2VXWlNUYU1lM3JHRXFDNEZQ?= =?utf-8?B?bTZlU2lrTUhETXlMZGdJWjRnVy9DS0IwOTZPek1YNlV6VkdWWEZyeTlPaDd1?= =?utf-8?B?K2NrY0NYZjA2eEhQelpGYm1nQ0tiaUN0U1ptZUV3Qkp0NVA3cWF5Y0d5ZXd0?= =?utf-8?B?OFJPeS81Zy9iY09RdmFEdlFaYWpFeGtVTWlDU245S1JicmVMdGFOUXREQ2RL?= =?utf-8?B?WXlyNllZMVJSVWc4SFBIc09uRDJrSllvVWl5K1JKbUIvajcrUXdDcUR1Z1VJ?= =?utf-8?B?ak5WS0VaNE1CRGdQSmFUbDVzZ3AyTWZHYm9jdVVSaS9xY1VJTURQSXB0NmFN?= =?utf-8?B?ZlV0NjhjY1IzVTYyeTlOR1YwWnFvZ3dKS3ZwdkJMdlVzQStBOTRIdHU1c216?= =?utf-8?B?T0VrdG1Oa1VybVNhUmtjMmU2cjd0bmdERmIxbnViV3pmM01sQmExb0hVeE5K?= =?utf-8?B?ZkgzWmRTdGlnc3o0MGd3RVkvSUMvTzJkeG0vREYwZ1Q3aFpNREpSenlaSGtv?= =?utf-8?B?SjMxOXozM3pyQWlNMTl6aldHcG1OZDZRWDQxMDg1YmVDNzQ3bDNsM0VuR1lR?= =?utf-8?Q?/XTs=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64911bf5-23cf-4ebb-63ae-08db950eff77 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 17:19:45.0560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X3D7n1YypSfNH8m9F3m0E0GqZfuWymLo7JF8dB25I8WyvbIJkeke9qabmwLuM+FNG6cVzoPI/E0sYVhViLCmMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4986 X-OriginatorOrg: intel.com PiBPbiAwNC8wOC8yMDIzIDg6NTcgYW0sIFhpbiBMaSB3cm90ZToNCj4gPiBJIGhhdmVuJ3QgY2hl Y2tlZCBYZW4gaW1wbGljYXRpb25zIHdpdGggdGhpcyBjaGFuZ2UsIGkuZS4sIGRvZXMgWGVuDQo+ ID4gaHlwZXJ2aXNvciBuZWVkIHRvIGFkanVzdCBob3cgaXQgcGFzc2VzIGFyZ3VtZW50cyB0byBQ ViBndWVzdHM/DQo+IA0KPiBUaGlzIGlzIGFuIGludGVybmFsIGRldGFpbCBvZiBob3cgTGludXgg aGFuZGxlcyBkYXRhIG9uIGl0J3Mgc3RhY2tzLCBpc24ndCBpdD8NCg0KWWVzLCBpdCBpcyBjb21w bGV0ZWx5IGludGVybmFsIHRvIExpbnV4Lg0KDQo+IFRoZSBYZW4gY29kZSBpbiBMaW51eCB3aWxs IG5lZWQgYWRqdXN0bWVudCB0byBtYXRjaCwgYnV0IHRoaXMgaXMgbm90IGEgaHlwZXJ2aXNvcg0K PiBBQkkgKHdoaWNoIG9idmlvdXNseSBjYW4ndCBhbmQgd29uJ3QgY2hhbmdlKS4NCg0KWW91J3Jl IHJpZ2h0ISBUaGFua3MgZm9yIGNvbmZpcm1pbmchDQo= From xen-devel-bounces@lists.xenproject.org Fri Aug 04 17:20:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 17:20:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577249.904252 (Exim 4.92) (envelope-from ) id 1qRyTh-00011L-GK; Fri, 04 Aug 2023 17:20:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577249.904252; Fri, 04 Aug 2023 17:20:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRyTh-00011C-Bz; Fri, 04 Aug 2023 17:20:41 +0000 Received: by outflank-mailman (input) for mailman id 577249; Fri, 04 Aug 2023 17:20:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRyTg-000112-OY for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 17:20:40 +0000 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39bd3b2a-32eb-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 19:20:38 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 10:20:34 -0700 Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 04 Aug 2023 10:20:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 10:20:32 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 4 Aug 2023 10:20:32 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 4 Aug 2023 10:20:32 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by SA2PR11MB4986.namprd11.prod.outlook.com (2603:10b6:806:114::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Fri, 4 Aug 2023 17:20:30 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 17:20:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39bd3b2a-32eb-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691169638; x=1722705638; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IjHAJ29LzkUr/EPACGQvTn9oVa5bkwKqcPgt8qC/ADA=; b=HgAbrQi6s+IFaJDn7gXtAZYBWoo9Rbho+F/2DT7mW30ryyTLSeFOarpe qPf+3+tZeMa+wu7ZynyAdcLEf+o1CB2ru7FXSr/cnCmbvAN43kX6yo4+m 5PMjlYK4CNQJcyXAgDH5hpJiIfJJg8kk6cJtbHdpmOzc0eZ3z9Huvxw74 tWZrYIxwiuHWv3CivNTL8g0JSJbXGWC8O9YFyq1mzspctKqk1E0MZEEXm CgoCf+Z2eeOcC401ugK24DszrkeD9oxA4xWyRwqHdz1gPDE/+HKTaB6RI +86WQG6V3UgBQ/bovV55l6aYAjQMoq7J0pFiEMm/pWSq+AUWNmirI9Ozu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="372947705" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="372947705" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="820205770" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="820205770" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1xscz92d4OHjgCheY55C+XBxMIIo7m+4jmsx+0VErHuydYPfmclzKGnZa9xliiWp0nLmdD1HSMRVMdIAWNMcL8z6zrvhTc3oH/wmPMGkXg0hYiqHLGuulX3B37eTNU44m2OE0kfnZYxxrGc8G0iQPDsX8WawqRYdz09BC/BJ6E4GQ2sbJvdJMzLDSN8GzGcvWEyxBIXoLyppwz7EFbgZ6+LPNZ4Dx9CTiCwCTdGAANOOM6V2KGPfeEY/dlojikvnjyODh2YlBxo33a2HJrVi7a1s2mYYvsJSWIyDfVSiceMtLjEpEkijE+VUKpTukdHqfg1XHHNRESfdBqHZtOBuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IjHAJ29LzkUr/EPACGQvTn9oVa5bkwKqcPgt8qC/ADA=; b=YpY9ZFYAcyQok3uxnR5Lf4tUMGmoz/bqiyJC7SHrpohY7Ywh5Yg92ub5Ibhib4wpKIpjVH719btZ6sXsSQl05HKOgrPUevXaVP+NMVn042JiV16ubcqezYjHGelCiuqwFuz2O6ZoSdoLJydrEPBoyoYRf38PWeaRPoXdvIIliTlVXLRQB7Ju4HWyBRjQwwd7Lvt8tQpCR1L5BFKFxmkPqDQEm/ggeRup1LKyZ/EEu32DYytr9obaN/JBI4UfYb71oVAra5HKMbuKwZtCOEBg2OqT2Noi/VHVyUXQ3ParRfs+5c9kKZckYaEedNRHlbohBmDt9oRBanJBKifir9V/5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: "Gross, Jurgen" , "andrew.cooper3@citrix.com" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" CC: "Lutomirski, Andy" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Peter Zijlstra , "Ostrovsky, Boris" Subject: RE: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Thread-Topic: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Thread-Index: AQHZxq1luoPee3LE20qWOZPEmJublq/Z7qYAgAACvoCAAHECsA== Date: Fri, 4 Aug 2023 17:20:30 +0000 Message-ID: References: <20230804075734.8372-1-xin3.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|SA2PR11MB4986:EE_ x-ms-office365-filtering-correlation-id: bfb7b4c9-fc07-48d5-44a3-08db950f1a84 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OaSUP1frTjL0uWSE077R5p3DaPC89IZlxLGWh/pjBInWpLFoGIne1OYavYf3Nt9ptYAYqoAcGrKTSppqXYGi15oaBo+8VzPVW8Of9RFzptPVU+byiiXfO0KBePOGeNzweQOTYFe6Rqhq03nfOwFDMPzhA15AtAeHCxuEGGczVcxzuMO2peyh4sbbUEkcgckp2n6g7vux0cil5u2uOQ0CrM5uuy5tlhWUsYsKBGaKonf+9SGTQmicyf8kdKEln8IHkb7EdLcKwFWBoFfjH31vFepopojXrZVWc3GLR+Q22aEwqV8RdGIzRBpYbB4ddDZ3xu2vv9bpj+neOEii862xSFnbPN3C9JTzQGTCNsbc81cGHU/MCZ7x0SOljTjUe89HZ9llJkrhUOerjbfq6fPJM4B64M/9U8T7N9UeaHyHaexjYWSb6TDCgIEqhPrSZ6q7HHKgEQGeVYSJ6HIZRQcG2jbuBTX7V2CIezhzLCjV+8tiezM3YJS/vcbuKU7aV1eQsfDx3K4ClrrFdW9T3CHKV4Jcun0oGOTNsQH9yF3BB9rKPqNZD2y2PkecjTGQWYfAfirjPYnUBLzFDTSckjuQ1i9th3Yvete6BYPXtNRLSQiv65Bj1oXvjFMm3xNiNj1q7j/AHZHj6C9pf+WlyNcHlA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(366004)(396003)(39860400002)(186006)(451199021)(1800799003)(52536014)(66476007)(66946007)(66446008)(66556008)(64756008)(4326008)(76116006)(2906002)(38100700002)(122000001)(53546011)(82960400001)(38070700005)(6506007)(7416002)(83380400001)(54906003)(110136005)(55016003)(86362001)(9686003)(26005)(478600001)(7696005)(71200400001)(33656002)(4744005)(8936002)(8676002)(5660300002)(41300700001)(316002)(26583001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VEFKaTJTbXlGbGlQQ0pGamN6d0k4c0dzdlVrVHhPSTJvckg1RXVZbEdFaXJx?= =?utf-8?B?YWZVc25QSUV1ZWNUa3lFaEJaV2NhNjgwSk5SMThCVUdRV1JTd0lrd2pjcTRr?= =?utf-8?B?djg0MXdycklxWUJkL1ZZOXB5WUNsUEI1ejIyVUpWS1dqeHgwTmlMKzlXa2dw?= =?utf-8?B?Rk1XUHZkcDVzaklQTm9TSXZlOHpKMmVjR0xueFBkWC9jZGpQUVJzdDBhaUtP?= =?utf-8?B?WkNpUXkvT0VjVUJlcUFQZVRwNDQ1VTBRRC9haFEvZXJiVnIzV1FMT3k4bHQz?= =?utf-8?B?ZVdhT0djaHZFNkJpV2tuZGFHdUxvTVBVU0ZqTWcwN2pLSFdXcUFLL2dMR0E0?= =?utf-8?B?dkdmdVN5QmYxUVdTUlVVeGlOcDVtbmZxRVpxalhscy9IOTZrOWJWSk5zakNi?= =?utf-8?B?SXk2dVRrMHRaa09xcm42YjlZWDdIbWxnNG5oV09MY2VwYTZ0ZzM0QjlpRUdw?= =?utf-8?B?TTlkV3lMK0c2bkk1VERmODROcUF5cjRHM3Fnczk1T2tOdjdlNVFWME9UWGVR?= =?utf-8?B?VWpCUUdSSTRXUEFZbkVwQlNUVldyL01nQ0N4bjNlWTcxZ0pXdHV5ZGFENStH?= =?utf-8?B?SzVFUnpxaGsza0hhOTBUYS9BQ2JwRCtoVWMwUHFuNlhXRWEzUmw2eVBNRHZT?= =?utf-8?B?a1VOVjJaV3hyUmo4cVlYNU9VTjA3T3lzdDJaWjhOMjlMY1RRaTVzcmwzYmN4?= =?utf-8?B?eS94dlU3aXhDY1MzNFJQL3k2dFI1QlFhSDVsN1lWSERvUmhucnM3YUZ0cTNH?= =?utf-8?B?U0Jkb0lLUVBKQkxLNXhka1l3M2NheWVsd05LYXVpUXp0RmdXSUE5L3RUYUFI?= =?utf-8?B?SDFrbEpFYW93NnRzL3RzclJHdVcwWTZkcjVWS3JUOE81d1BVRUFCUXNCTHdC?= =?utf-8?B?SzU4OGVMbnVCNkFqRi80dHZXc2E0SHo4R2JoM0pyN2tTaDBtR05PRk9CL2VN?= =?utf-8?B?OGNMbTErd1VoOGh3MEhqNXUrM3NTbnEzUkZuK09TdFhGUDAvSkxtd09MNGtt?= =?utf-8?B?ZkZseUk0MXQwQml2ZUM2MStsNzFXVm5xU3l1MDUwR25WNGFsdkhUc0JDMGVE?= =?utf-8?B?TEc1MFZ1ZVdhbHNNWnlMRERWc0NpU0xyREdvN0N3RVd1UFNBQVUyd2wySEg5?= =?utf-8?B?RWZEK05QK3ovWkdpK2Q2ZThZZWJDeG50UXh3Q1llTjdzSnhzcFl2UFVMMmE4?= =?utf-8?B?NUNpVUsyT3p5R0NJZ1IzbEwrWGZndFd5MWNXOGdZSDhDMkx3MGoyMlFPNXhp?= =?utf-8?B?aXIwWms4WXFqUTNRMnN3MlZ5RW85bWZNNlZPN0t3bXBRLzMyZGx3ajJwaVA3?= =?utf-8?B?Znp4aWdWZkt5c2NCQjNGNXhVbnFBTEtPbnlYdlJUQmNtaGkvN2h6RHZadjVL?= =?utf-8?B?anRkV0o5YVNuQmRTQWNzVGoxK2lvTHI4QkV1OS8yY1dFcFJwbmxubnFNRWwv?= =?utf-8?B?NGlZaTUwcGFHWTNHa0swMDQ4NlYrTEJ6UUUrQ0dSSVNIc2UyMUhQSnFScmpL?= =?utf-8?B?UllPQWF2Mjh0L1ZMcWRVTkhLSDVsai9vRFFOdk4zY2dORFZlZ2RiL1RPRWl2?= =?utf-8?B?NUp5RnJoeUl5c0ZLLzRKbkkrMHdvUGxzYkRoRDBONDU5Zyt1bDRnRVJzNXpF?= =?utf-8?B?T0orV0wzWWtLWXhucDJlK05xRjRBUXVPTkF1YWx0ZGdlMGVLYnpnYjFVY2V4?= =?utf-8?B?ZnJiVkwzbitSc2d2TlJIQUV2L3Z3ZWwxczlXRnRsNXdrMklYUTUzZ3F5cSs3?= =?utf-8?B?RmNXd0ZVU0h1aVRzelg1R2VGOXZ3eFBBL29vVVYrUFE3aGwxNExSdDdrQ1dz?= =?utf-8?B?OTJadHdDU2xONy92dUxuWFFrK0h4K0M1QXhpYi9zanE4V0lYNS8zbURZWGpm?= =?utf-8?B?c29OTHBGd0VQU1pDU2oyU0NDdDF0Q2ltUnNabEk1Tm9LQXkvTCtBOFVuR0FO?= =?utf-8?B?NTNLN3dQR1B6USs2ckhLUVlpWUJnVG9YbW9XU1pnNVc2UTBqMU52RVF1WERG?= =?utf-8?B?SE1weEFNRTlOK25GbCtNTlZKS25PSHBubXdJNXJzZE5pYytiL2pGTHJJaWhK?= =?utf-8?B?Z2huSXNwY3JwU3gzWTI1S2lZMWpYVHB1d0M4SERIZitZYm1OSDNxY2JjNlMz?= =?utf-8?Q?zTow=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfb7b4c9-fc07-48d5-44a3-08db950f1a84 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 17:20:30.4965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nJZJjGHAS+ppHFPGzfIIwH/3WVJizyUBeUIW6NYRyshuVuZbjfbkFdZTzsRxHCSqBG5iZeuf0bFOrSk0hCwSwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4986 X-OriginatorOrg: intel.com PiA+IE9uIDA0LzA4LzIwMjMgODo1NyBhbSwgWGluIExpIHdyb3RlOg0KPiA+PiBJIGhhdmVuJ3Qg Y2hlY2tlZCBYZW4gaW1wbGljYXRpb25zIHdpdGggdGhpcyBjaGFuZ2UsIGkuZS4sIGRvZXMgWGVu DQo+ID4+IGh5cGVydmlzb3IgbmVlZCB0byBhZGp1c3QgaG93IGl0IHBhc3NlcyBhcmd1bWVudHMg dG8gUFYgZ3Vlc3RzPw0KPiA+DQo+ID4gVGhpcyBpcyBhbiBpbnRlcm5hbCBkZXRhaWwgb2YgaG93 IExpbnV4IGhhbmRsZXMgZGF0YSBvbiBpdCdzIHN0YWNrcywNCj4gPiBpc24ndCBpdD8NCj4gPg0K PiA+IFRoZSBYZW4gY29kZSBpbiBMaW51eCB3aWxsIG5lZWQgYWRqdXN0bWVudCB0byBtYXRjaCwg YnV0IHRoaXMgaXMgbm90IGENCj4gPiBoeXBlcnZpc29yIEFCSSAod2hpY2ggb2J2aW91c2x5IGNh bid0IGFuZCB3b24ndCBjaGFuZ2UpLg0KPiANCj4gVGhlIG9ubHkgYWRhcHRpb24gb2YgWGVuIGNv ZGUgd2lsbCBuZWVkIHRvIGhhcHBlbiBmb3IgdGhlIG9ubHkgdXNlIG9mDQo+IERFRklORV9JRFRF TlRSWV9SQVdfRVJST1JDT0RFKCkgdGhlcmUsIGFuZCB0aGlzIHlvdSBoYXZlIGNvdmVyZWQgaW4g eW91cg0KPiBwYXRjaCBhbHJlYWR5Lg0KDQpUaGFua3MgZm9yIGNoZWNraW5nIGl0IGZvciBtZS4N Cg== From xen-devel-bounces@lists.xenproject.org Fri Aug 04 17:35:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 17:35:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577255.904261 (Exim 4.92) (envelope-from ) id 1qRyi0-0002iv-M5; Fri, 04 Aug 2023 17:35:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577255.904261; Fri, 04 Aug 2023 17:35:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRyi0-0002io-JP; Fri, 04 Aug 2023 17:35:28 +0000 Received: by outflank-mailman (input) for mailman id 577255; Fri, 04 Aug 2023 17:35:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRyhz-0002ih-3c for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 17:35:27 +0000 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 462e1ea8-32ed-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 19:35:22 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 10:35:15 -0700 Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 04 Aug 2023 10:35:15 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 4 Aug 2023 10:35:14 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 4 Aug 2023 10:35:14 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 4 Aug 2023 10:35:14 -0700 Received: from SA1PR11MB6734.namprd11.prod.outlook.com (2603:10b6:806:25d::22) by SA1PR11MB6943.namprd11.prod.outlook.com (2603:10b6:806:2bc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Fri, 4 Aug 2023 17:35:11 +0000 Received: from SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04]) by SA1PR11MB6734.namprd11.prod.outlook.com ([fe80::50e4:2cb8:4529:af04%7]) with mapi id 15.20.6631.046; Fri, 4 Aug 2023 17:35:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 462e1ea8-32ed-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691170522; x=1722706522; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/uZ89Tm2pcJTvf82DkqKJVHi0tE0E6MJFP5FJFfukpc=; b=ZsSIuNzU53OEUbHaZ8kYk49qpiP9gVlwqO5jew1MEqooObt7LTnoNcC/ SqfrKL/MGRjC7lNForpNkMl9kEVLiXZLrP+oNgaPEWbe4arrtX0KmZE2L ymX6h5nG6ZVzm3SNoUBTCwnlmEzae1K08IpeV0eyOm6u8fsHgJYbZbaBh ESd5xj7h6MRWkhazdJ4Do4XDzL4SYRKMRsR80bahp+gooUageyTQMqYGy a3Jlo+f3RhH9meubWd1EzyriNAHIu6TD0e1jphjbvw1LuiLa/DupmhRiT 3IRXCGm6TgkgTgMR+VMD9w9hA+vsHMSPZrYXoNg7ZjUuVnAcYuV2ogw7Q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="372950494" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="372950494" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="800140755" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="800140755" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMcz8Um5w3krvSYNtfw/RXzY59g7nTdCVvQxy0+0Zsys0Y7kjmgQs746LsZFpDM9kz56YeC79neKxUQkTbYNck2WFipGZhLaOKgieaR2FEFIho6fhPA3TZBUWI3shtzAMUW2XqKfqCEuW3PEDe7en4LB9mYyKkawi7HSwkM2l3sscB4dN3IuW2yt71UGw3ZR119UUjJm1iEoLXi3PVozqgGltP8NUn7WT70W/QwZTvPL+b7qImomrkfBH8AOseee2DdQDESE7kNxZam7fJH7j96mMB6ibEgSGqqdW7KVHEiv8Mezl5WA3B3Q0E3I+41RjMMIgy5Zckrddrzy25UJow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ubv7enYxLzTXmgjsMDcuRLrQdCBhlZzE3KL1OOJZcw4=; b=G6e0aL1DtQHWOvwCJIeyi24pDTCd/GTFDlsjYvKtlTlzIl4bZPR2fVht/umQtvwWAVcBv2DeYJvreuQcRMK9OKXhinnxJzLzffLPzdoJz9SDyrqzOJjBIy4Rk5s/+ui419DXDNmMiuwlmYJV3nPOlNk19wWhv0/d2rDYy/PIn3/C+yzekTWgJVcSf8JxwZJv/3TOld4AgizgGUAM31XhPSF5WnWL8k6bf7nYuetKm1zAQaVRG2cbI/8+vBlycZjKUNFHTT9xcmqqpmN2HXXkERZLcQY+eyVT9+P/vho0PR6ZCFMxREBQ5plmGw/0n2q2T3WH53lXghLzhgUAeUZdYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Li, Xin3" To: Peter Zijlstra CC: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Lutomirski, Andy" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Gross, Jurgen" , "Ostrovsky, Boris" Subject: RE: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Thread-Topic: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Thread-Index: AQHZxq1luoPee3LE20qWOZPEmJublq/Z6zyAgAB3ZVA= Date: Fri, 4 Aug 2023 17:35:11 +0000 Message-ID: References: <20230804075734.8372-1-xin3.li@intel.com> <20230804101321.GH214207@hirez.programming.kicks-ass.net> In-Reply-To: <20230804101321.GH214207@hirez.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB6734:EE_|SA1PR11MB6943:EE_ x-ms-office365-filtering-correlation-id: 96d1cd66-62fc-4813-6e5f-08db9511277a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wNvIdG/iB7rV7TsItBndME52X3qHqS7HXIsSX5JEaOQrgBTJF4cRNguoXrguNm4PnRwapGVsDBANf04K5wSj5Tw0MgV9bRwoJ6gbkaGYxGHbeg6Uxw2OAmz5bHJ6aSCFaTDKqZPy90QC/CzRjP7kEDu/g5QBeX16qUuH1zhL6HG2VSuk4P/sbE9WPcLJLiNpXJshiGrDIrmZRMrxfKt4867gRmNtv8JWSnToMG74cs8vPO+eDLtoKR0NVRLrIhc/17MX6ZDd9PLqz0F8OCf47nlSC8EuujG/TneEdfSoPE6OfvuTE2FixNeaYzPt06oU6JrjiUff6HdUKkk4p0klr1XGhaeJhUoyFajuJf6tJjh27GXY44faEMaO4Ctfaq1hytjBSHUVnK7zKlcnZ0HPI3e7YLb2KJQoMHB1PNDNtojbiMquJ8Fi/431rE2qoxXuMER0D8/u2HbJlJJk7O0fv6XoLsH2TrbtgdT3QCgvIidJszcQvKW70ETQ+4I+9KQFkOv+Op5xKzB9Uvil4t5+PJX/iBw8UWR+3SyasX9GqfFxTNcRgnwgiknWE/fftWCDEP2Q20GMn6XGLssXIibDbwvJGpgAmhHYqOSqjAMgQLIQioLeXdudQdpSDuPud9XzUnHIde2saWmFaAnwnzuv5Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB6734.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(376002)(396003)(366004)(451199021)(1800799003)(186006)(6506007)(26005)(8936002)(41300700001)(6916009)(2906002)(76116006)(5660300002)(66946007)(66446008)(66556008)(66476007)(4326008)(316002)(52536014)(64756008)(8676002)(7696005)(71200400001)(7416002)(9686003)(478600001)(54906003)(122000001)(38100700002)(55016003)(82960400001)(33656002)(86362001)(38070700005)(26583001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KwPsvvqJE/yjGL6oYxYxvYK70dJM3vfF8TS5+yo5alHwMpsJvX3iAbYXzFwU?= =?us-ascii?Q?KdMJoNOydubX3XPBVStaT6vZ20EVa6efvDQoId9fzc6NQEzeHfoKS2YtbiWc?= =?us-ascii?Q?YgZRmxwmE1+uZDfRbpPt5x4rPA9Feg/3EdmYxQgklulCP7AtUQDwz904Hwe1?= =?us-ascii?Q?kMiuRr1uA/lY4BJIZ700UnhKcSjzwh85NV2VOok3+kPsuF1514pystHUXa3Y?= =?us-ascii?Q?+t3ZT4Q80pogDSxQRcZx3CuvpRGxgTltmVCWYuVHEbdgqYnta+vrMLfSZLXF?= =?us-ascii?Q?pKUtCpQS+r3YjCuFlB2fV0eeD4rgB9dGJyLvkhK+D69bDInqSSStjNKBv+cz?= =?us-ascii?Q?b12Lgu7b0JhtTGzeceN0DBdpjabtLlSEkGQ/RiuE+Ofi56n6IXoXAr57vsuv?= =?us-ascii?Q?ax0BbyQINygOvPgmBPJ3L7jBStMg13Ej1g+K7YaX1/+xhCmiOAVRSPjZFnW0?= =?us-ascii?Q?DHzFOge3mXfhFUt3dYuBrqLAlqJqP/rKj1UZyFY1P7ED+SLL4wfo8oa1tqV2?= =?us-ascii?Q?sqBUyb6+w5o1RdCVDs6XLwoSFT932lY+WEa5AjaXLu7akUtK7xVRFuVMyu3F?= =?us-ascii?Q?KTRbIM0tFgKrd+ru2kXchCdgN/g5LOv8teTX2eCv6iRerKIZ0qYraqipAKBd?= =?us-ascii?Q?nSrb6igptDquMnG7ZgIsJWxbmc8kkBjVP9ruLzl9QcHgJlm37iwN5ANB6eeo?= =?us-ascii?Q?5mbjnvbxDd9U610gy0VO2Iq/944NbEyBemYUcCc785yVXFMh0G8knMvA5XZa?= =?us-ascii?Q?aG1bcfNEfnDUhcZiIsBaOMnX+kWMGx+0Eq0GoOqySj4WKERlNOa3ODMRueyS?= =?us-ascii?Q?lUbwcAAqNGDyw1ixi8p4Zv14myjmaU8XjQbw8snmYRvbo6WVkMsU+zxTawsP?= =?us-ascii?Q?cY/z2l5v+XilTNqtoP7mIlaF/xiYEdCZ+4THmIAtLBUJ6f89h+w41/WbLEyF?= =?us-ascii?Q?KE/1GXRGKQkBvIysQnd+RcAjr1MxKFd17T5VJn9G8tjo4N704fhXzE+hOGiu?= =?us-ascii?Q?h0ZTEpRVyXFOq78NtNPh1cm+y/N3QqS0SYL1R5aNTf2Wz/krGo6WjF11wQxH?= =?us-ascii?Q?TBreVpN/+rIGYx8q+szEcQyvnwqebHh6v6qL2EjAc4bDZkmZvI8Kfa64MTVM?= =?us-ascii?Q?d6WUheRxjojHbawJH65JI5jxssOwze+CUtJCzuCsO9A5bmvMHVSzI1oSRmcs?= =?us-ascii?Q?g/UjtDlSelRpAik5oNxBEDlriWkEqs2LwjDMjAfWyo5+UOQdxA/rX7eun0mh?= =?us-ascii?Q?1+0TLRRviPpTFI/dBW9Fzd5yuHza3MIDmQ/jZyvffkiW5fLUJhdxm8ny11lZ?= =?us-ascii?Q?1mrvhCXYfZmzg0bTFS9PVozEdNouhZtsKRIM2ovmTaz3GMa0UPjwWXnkw8M+?= =?us-ascii?Q?+HcGj6xmewbzU2mAu9c10rh+HMk1qqmMQjkgjgjqC/+kp//KljijDwVkJcoG?= =?us-ascii?Q?yruB3BD0L1qkW3czcvQDYCAVieaEnM8IMPuF40ZebchvUa8Czf5AZpKOqqI7?= =?us-ascii?Q?OWQxGP7ON55TL8lqqj+HFX3KjclH/8TPpzmD6HfvohZlNGNPHp5ljDS5yCiQ?= =?us-ascii?Q?2zOnEUQ8mUGctXD97cI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96d1cd66-62fc-4813-6e5f-08db9511277a X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2023 17:35:11.1752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EMTATcikUJ4zLGXp5lfiDx8Lqihoa+4aJ7DHvW+i/k+1tnu+vLhDiUaksF813HXxXNEHGXLFUH6eZgAcKtQv+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6943 X-OriginatorOrg: intel.com > > The IDT event delivery of X86_TRAP_DF, X86_TRAP_TS, X86_TRAP_NP, > > X86_TRAP_SS, X86_TRAP_GP, X86_TRAP_AC and X86_TRAP_CP pushes an error > > code into the orig_ax member of the pt_regs structure, and the error > > code is passed as the second argument of their C-handlers, although > > the pt_regs structure is already passed as the first argument. > > > > The asm entry code of such faults does the following > > > > movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ > > movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ > > > > to set the orig_ax member to -1 just before calling the C-handler. > > > > In addition, the IRQ entry code uses the second error code argument as > > its IRQ vector, as the IRQ asm entry code pushes its IRQ vector into > > the orig_ax member. > > > > The commit d99015b1abbad ("x86: move entry_64.S register saving out of > > the macros") introduced the changes to set orig_ax to -1, but I can't > > see why it's required. Our tests on x86_64 and x86_32 seem fine if > > orig_ax is left unchanged instead of set to -1. >=20 > That means that SYSCALL_NUM(regs) get to be garbage; or something like th= at. I find SYSCALL_NUM(regs) in tools/testing/selftests/seccomp/seccomp_bpf.c, but nothing obvious to me. I think it's clear that once exceptions and IRQs are handled, the original context will be fully recovered in a normal case. Is it related to preemption after such a event? I must have missed something; can you please elaborate it? From xen-devel-bounces@lists.xenproject.org Fri Aug 04 19:02:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 19:02:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577289.904288 (Exim 4.92) (envelope-from ) id 1qS03s-0004gq-D2; Fri, 04 Aug 2023 19:02:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577289.904288; Fri, 04 Aug 2023 19:02:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS03s-0004gj-AQ; Fri, 04 Aug 2023 19:02:08 +0000 Received: by outflank-mailman (input) for mailman id 577289; Fri, 04 Aug 2023 19:02:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS03p-0004gd-Aq for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 19:02:06 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65acac0f-32f9-11ee-b270-6b7b168915f2; Fri, 04 Aug 2023 21:02:03 +0200 (CEST) Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qS037-000YFD-23; Fri, 04 Aug 2023 19:01:22 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 991C330007E; Fri, 4 Aug 2023 21:01:20 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7A46721FA7AFF; Fri, 4 Aug 2023 21:01:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65acac0f-32f9-11ee-b270-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qVJ80sMcFC+VhDcYrAkI2SgTfMYHIJ7m/A06T6Wu06Q=; b=hfKY/spEx8pQzuYmLSdq9dv+ju EYFl2ED+zOu6Mv2khT5qlOwja516BIIBhqMT3r/zi9lu6hIsIuoUw0bMw9HjPvKUqrfV3uMAvnG1f h//f5x7xEABRlxHBwLGdCly3AewzeXENjeUblyU2y5wR72h6zRh6TTHV9QUOS4dxuGUTP7XtB6rYF 8fkqXYfhcnQ0sZpGPcbt50Et/9WXTzGTSUOGp6srdNJQqx9taX0rm9HxRZzhEIGKHdFsyiZqwvQKY GbiXAbKL+HTKGvUNNuShKatS7IwrlDoy0NGqZjXaRH927d7WFo7U0oM1j8GX2hWmlIk17X+h6wZB6 Cdhp5gOA==; Date: Fri, 4 Aug 2023 21:01:20 +0200 From: Peter Zijlstra To: "Li, Xin3" Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Lutomirski, Andy" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Gross, Jurgen" , "Ostrovsky, Boris" Subject: Re: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code Message-ID: <20230804190120.GP212435@hirez.programming.kicks-ass.net> References: <20230804075734.8372-1-xin3.li@intel.com> <20230804101321.GH214207@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 04, 2023 at 05:35:11PM +0000, Li, Xin3 wrote: > > > The IDT event delivery of X86_TRAP_DF, X86_TRAP_TS, X86_TRAP_NP, > > > X86_TRAP_SS, X86_TRAP_GP, X86_TRAP_AC and X86_TRAP_CP pushes an error > > > code into the orig_ax member of the pt_regs structure, and the error > > > code is passed as the second argument of their C-handlers, although > > > the pt_regs structure is already passed as the first argument. > > > > > > The asm entry code of such faults does the following > > > > > > movq ORIG_RAX(%rsp), %rsi /* get error code into 2nd argument*/ > > > movq $-1, ORIG_RAX(%rsp) /* no syscall to restart */ > > > > > > to set the orig_ax member to -1 just before calling the C-handler. > > > > > > In addition, the IRQ entry code uses the second error code argument as > > > its IRQ vector, as the IRQ asm entry code pushes its IRQ vector into > > > the orig_ax member. > > > > > > The commit d99015b1abbad ("x86: move entry_64.S register saving out of > > > the macros") introduced the changes to set orig_ax to -1, but I can't > > > see why it's required. Our tests on x86_64 and x86_32 seem fine if > > > orig_ax is left unchanged instead of set to -1. > > > > That means that SYSCALL_NUM(regs) get to be garbage; or something like that. > > I find SYSCALL_NUM(regs) in tools/testing/selftests/seccomp/seccomp_bpf.c, > but nothing obvious to me. > > I think it's clear that once exceptions and IRQs are handled, the original > context will be fully recovered in a normal case. > > Is it related to preemption after such a event? > > I must have missed something; can you please elaborate it? arch/x86/include/asm/syscall.h syscall_get_nr() syscall_rollback() From xen-devel-bounces@lists.xenproject.org Fri Aug 04 19:19:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 19:19:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577294.904299 (Exim 4.92) (envelope-from ) id 1qS0Kc-0006Ia-PA; Fri, 04 Aug 2023 19:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577294.904299; Fri, 04 Aug 2023 19:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS0Kc-0006IT-MV; Fri, 04 Aug 2023 19:19:26 +0000 Received: by outflank-mailman (input) for mailman id 577294; Fri, 04 Aug 2023 19:19:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS0Kb-0006IN-0E for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 19:19:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0b0a1c1-32fb-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 21:19:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8805620F9; Fri, 4 Aug 2023 19:19:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25950C433C7; Fri, 4 Aug 2023 19:19:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0b0a1c1-32fb-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691176760; bh=apUVt5yHL5/JjzyZ1TVPnIPul2cJTe3/wdu6vBwZRDY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=s4zUD85T/SQ/hK/Fuer+JmtdB5L7KTyljYWxK4UX4KDKry53SCZV38Ju+2W1oLOQx 2hdIoKj1qjHWBM0En+rjgTBRIE2QeXpVXuPc3dRIy+AQoOLDbtXNT1QbJyeeY53aHI 0Wl3hPBlmWvpKnE1i/FZbCFFR8zPiS8mqI9tpO+sF7mcDhiWH7C5jV+/UK5Uffhdc3 SYZnrEbSqp4ZAaS4xq7thAvueJE8yzD3PnXMQbN6XMGOs+pxRmMJfV6xaTj7WFYJJl L6EiHsgOukLqwHsLv7RjxvnpXlJJ7GeiKmtEZ0XbdobO6A+t1ucRhW+gpFqL9a4Uf2 rhzzsdgtf6Gdw== Date: Fri, 4 Aug 2023 12:19:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: Stefano Stabellini , cardoe@cardoe.com, andrew.cooper3@citrix.com, simone.ballarin@bugseng.com, xen-devel@lists.xenproject.org, Stefano Stabellini Subject: Re: [PATCH] automation: add missing "needs" In-Reply-To: Message-ID: References: <20230804011018.2888869-1-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 3 Aug 2023, Michal Orzel wrote: > On 04/08/2023 03:10, Stefano Stabellini wrote: > > > > > > From: Stefano Stabellini > > > > The test artifacts export jobs don't need prerequisites, so we should > > specify "needs" with an empty array for them. That way, they are not > > going to fruitlessly wait for previous jobs (ECLAIR jobs) to complete > > before continuing. > > > > Signed-off-by: Stefano Stabellini > Reviewed-by: Michal Orzel Thanks! > Looking at the whole pipeline, I can see that now only ECLAIR jobs do not specify needs. > Shouldn't we also add "needs: []" for them? Yes it could be good for consistency and future-proofness, but technically it is not required now because the ECLAIR jobs come first. From xen-devel-bounces@lists.xenproject.org Fri Aug 04 19:24:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 19:24:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577298.904309 (Exim 4.92) (envelope-from ) id 1qS0PT-0007md-Aq; Fri, 04 Aug 2023 19:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577298.904309; Fri, 04 Aug 2023 19:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS0PT-0007mW-80; Fri, 04 Aug 2023 19:24:27 +0000 Received: by outflank-mailman (input) for mailman id 577298; Fri, 04 Aug 2023 19:24:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS0PR-0007mQ-Ob for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 19:24:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 839ecebe-32fc-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 21:24:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB44E620B2; Fri, 4 Aug 2023 19:24:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17BFEC433C7; Fri, 4 Aug 2023 19:24:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839ecebe-32fc-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691177060; bh=1scds7z8WNp0wU1Ynx2S061QaMbUsIDz+VM1EtTlCcc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=kapeWdutUvjKza/FRgrvXs/aJDpt+nsdUzZh5B2hfDCByE+JkSRIXt3TS/q6H5PAs 2hvYn9Q/xZeoAzoipru2vB6YJR9OGOnMMEV4UQeKAe41Q8cmSl9pbdrFfQ0ZXLYvq+ 7EcOs4WUjgdgr2VDXiB1MpQErZLffjle/R/mptQk8EyPqJS1/B1GylgTcnf0+LDTnY bxlHZKybsY9txmKtl1ZWhFNH67YitV8DanwuQufUvOwOFgCi6aVfC4QsMzLwnzF81C GF7LUJz9KWp0RYAEhzgcmCOryocmolYEmsa5s5xJjgSr822E6wmk1AXjTO4VKyKgar gi/Xdd7+Bp1wA== Date: Fri, 4 Aug 2023 12:24:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Federico Serafini , Stefano Stabellini , Julien Grall , Luca Fancellu , Xen-devel , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [XEN PATCH v2] xen/string: add missing parameter names In-Reply-To: <82f93d14-fd6e-417c-a970-645fd0719d3a@suse.com> Message-ID: References: <16c5362b740ed66100b55b528881cb26c1430f15.1691050900.git.federico.serafini@bugseng.com> <4FE67D84-A5AC-4EA1-BCF4-212E4B916BD2@arm.com> <1e2d06ab-ad3a-4e5a-ac78-d20bad28bb20@xen.org> <49fc793e-d0a3-7d9b-b501-d7a72dd9c736@bugseng.com> <82f93d14-fd6e-417c-a970-645fd0719d3a@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-779768781-1691177060=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-779768781-1691177060=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 4 Aug 2023, Jan Beulich wrote: > On 04.08.2023 09:55, Federico Serafini wrote: > > On 03/08/23 21:26, Stefano Stabellini wrote: > >> On Thu, 3 Aug 2023, Julien Grall wrote: > >>> On 03/08/2023 12:52, Luca Fancellu wrote: > >>>>> On 3 Aug 2023, at 12:46, Julien Grall wrote: > >>>>> > >>>>> Hi Luca, > >>>>> > >>>>> On 03/08/2023 11:28, Luca Fancellu wrote: > >>>>>>> On 3 Aug 2023, at 09:26, Federico Serafini > >>>>>>> wrote: > >>>>>>> > >>>>>>> Add missing parameter names to address violation of MISRA C:2012 > >>>>>>> rule 8.2 ("Function types shall be in prototype form with named > >>>>>>> parameters"). > >>>>>>> > >>>>>>> No functional changes. > >>>>>>> > >>>>>>> Signed-off-by: Federico Serafini > >>>>>>> --- > >>>>>>> Changes in v2: > >>>>>>> - memset() adjusted. > >>>>>>> --- > >>>>>>> xen/include/xen/string.h | 42 ++++++++++++++++++++-------------------- > >>>>>>> 1 file changed, 21 insertions(+), 21 deletions(-) > >>>>>>> > >>>>>>> +void *memset(void *s, int c, size_t count); > >>>>>>> +void *memcpy(void *dest, const void *src, size_t count); > >>>>>> There is a comment in arch/arm/rm32/lib/memcpy.S with this: > >>>>>> /* Prototype: void *memcpy(void *dest, const void *src, size_t n); */ > >>>>>>> +void *memmove(void *dest, const void *src, size_t count); > >>>>>> There is a comment in arch/arm/rm32/lib/memmove.S with this: > >>>>>> * Prototype: void *memmove(void *dest, const void *src, size_t n); > >>>>>>> +int memcmp(const void *cs, const void *ct, size_t count); > >>>>>>> +void *memchr(const void *s, int c, size_t n); > >>>>>>> +void *memchr_inv(const void *s, int c, size_t n); > >>>>>> @Stefano: would it make sense to remove it as part of this patch or > >>>>>> maybe not? > >>>>> > >>>>> They are a verbatim copy of the Linux code. So I would rather no touch it. > >>>> > >>>> Oh I see! Thank you for pointing that out, then I’m wondering if it’s there > >>>> a reason why we > >>>> are using ‘count’ instead of ’n’ as third parameter name, I know Stefano > >>>> suggested that, so > >>>> It’s just a curiosity. Maybe it’s for clarity? > >>> > >>> I guess because the generic implementation of memset (see xen/lib/memset.c) is > >>> using 'count' rather than 'n'. > >> > >> Yep > >> > >> > >>> Given what Andrew said, I would say we should rename the parameter to 'n'. > >> > >> Yes, either way works. I was only trying to be consistent with > >> xen/lib/memset.c. It is also fine to change xen/lib/memset.c instead. > > > > If you want to be consistent compared to the C99 Standard, > > then other parameter names need to be changed, for example all the `cs` > > and `ct` should become `s1` and `s2`, respectively. > > The same goes for `dest` and `src`. > > If you agree, I can propose a v3 that takes care of that. > > Personally I'd prefer if we could limit code churn. Functions that need > touching anyway can certainly be brought in line with names the standard > uses (albeit I don't see a strong need for this). But function which > won't otherwise be touched could easily be left alone. +1 --8323329-779768781-1691177060=:2127516-- From xen-devel-bounces@lists.xenproject.org Fri Aug 04 19:29:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 19:29:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577302.904318 (Exim 4.92) (envelope-from ) id 1qS0Ug-0008QZ-Sm; Fri, 04 Aug 2023 19:29:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577302.904318; Fri, 04 Aug 2023 19:29:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS0Ug-0008QS-Po; Fri, 04 Aug 2023 19:29:50 +0000 Received: by outflank-mailman (input) for mailman id 577302; Fri, 04 Aug 2023 19:29:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS0Uf-0008QJ-7A for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 19:29:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 453391c4-32fd-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 21:29:47 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15197620F9; Fri, 4 Aug 2023 19:29:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C5EC433C7; Fri, 4 Aug 2023 19:29:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 453391c4-32fd-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691177385; bh=CTBpVm4g/vfOsKl1JRh9HFCJ7Vgsh5L+DgB4rAP/jUw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AlpLzj6AR0q2oesQZ4mGGa0d0Ysq4oWOv+37r2KW846tWzNIiVLKk70c+gIEgwx0D T4fDleDfohMlwwDsk4g9LVaAJXo3bpsQ5ECSoI3xaSZOLngr8xrJ9eWcpoO4Kn7pgq Oq4rNH1P/bkvUXXp3Sa3iCZBS0uHIDqLn39TIMRDeTRkm2IvxYypP10yy6SmHa+bXd 7myNuIHzhnkoH9xXHUwRho4H5pj0Vy8iKq4Hb4fqgZtsEXOHQilpViBq3z8UZPO33X ZPTvQT1h8SU1DMXHxl76cOKJaW2RHlD2dVkWADTd9LDIEUs4YPCXxEED+P5QlAwLQr qfjUzKHBAMmDA== Date: Fri, 4 Aug 2023 12:29:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , andrew.cooper3@citrix.com, roger.pau@citrix.com, julien@xen.org, bertrand.marquis@arm.com, roberto.bagnara@bugseng.com, Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] docs/misra: add always_inline to C-language-toolchain In-Reply-To: Message-ID: References: <20230804013438.2894725-1-sstabellini@kernel.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Jan Beulich wrote: > On 04.08.2023 03:34, Stefano Stabellini wrote: > > --- a/docs/misra/C-language-toolchain.rst > > +++ b/docs/misra/C-language-toolchain.rst > > @@ -84,6 +84,8 @@ The table columns are as follows: > > see Sections "6.48 Alternate Keywords" and "6.47.2.1 Volatile" of GCC_MANUAL. > > __const__, __inline__, __inline: > > see Section "6.48 Alternate Keywords" of GCC_MANUAL. > > + always_inline: > > + see Section "6.45 An Inline Function is As Fast As a Macro" of GCC_MANUAL. > > typeof, __typeof__: > > see Section "6.7 Referring to a Type with typeof" of GCC_MANUAL. > > __alignof__, __alignof: > > This is the "Non-standard tokens" section. What you add is a macro of our > own. In its expansion we don't use the similarly named attribute in this > very spelling, but with underscores prefixed and suffixed to it. > > If we mean to enumerate __attribute__(()) identifier tokens here as well, > then I think we should add all of them that we use. But that's going to > be an ever expanding list. Ah! Now it makes sense. I missed this: #define always_inline __inline__ __attribute__ ((__always_inline__)) That is why it wasn't already listed in the document: we didn't list all the __attribute__(()) and this is just one of them. They are clearly marked extensions so there is no strict need to list them also here. I'll drop the patch. From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:27:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:27:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577306.904330 (Exim 4.92) (envelope-from ) id 1qS1Nv-0006Wf-6L; Fri, 04 Aug 2023 20:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577306.904330; Fri, 04 Aug 2023 20:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1Nv-0006WY-1L; Fri, 04 Aug 2023 20:26:55 +0000 Received: by outflank-mailman (input) for mailman id 577306; Fri, 04 Aug 2023 20:26:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1Nt-0006WS-T9 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:26:53 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d4aa4c8-3305-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 22:26:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DE4C61EC4; Fri, 4 Aug 2023 20:26:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5027FC433C8; Fri, 4 Aug 2023 20:26:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d4aa4c8-3305-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691180807; bh=tY5F1rqf7Bai+fG9/a2nIFX2WFWPSML1zoaLAFl7wBY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lWZZmazf4M3la8pYdqaZMOKxDIhd0xR07znF42rsdBnwn5ApP8HyvJjt9dQx7YYl8 OfEAVbSWBFHXaegBZhpM126QZxkt5/5cs4O6iocBPHXxkAGg+gnIlsx9pNRTDAyRt2 5pdECFmm6kc/x0onEFNlWto3IYAcXq7geQC0T2AJt+yNVUK2255aqF/94d7L98doRl W54TdFDs2cktYc0Q+pRxi1/PkqcA0+8ICB5iVFgsdUGcdk0SCfpShLnyODkmNnlZfb W42MDV74wvHAhy2+DJownbuVlh377wK6MATsfE/NeatTLkMudyfOC/XT//xuxvHhWf X+qVXrDEiWaKA== Date: Fri, 4 Aug 2023 13:26:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , Stefano Stabellini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 In-Reply-To: <8672f79a-3e44-1cc3-b448-9ee4a4ed9090@suse.com> Message-ID: References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> <8672f79a-3e44-1cc3-b448-9ee4a4ed9090@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Jan Beulich wrote: > On 03.08.2023 16:22, Nicola Vetrini wrote: > > On 03/08/2023 11:01, Jan Beulich wrote: > >> On 03.08.2023 04:13, Stefano Stabellini wrote: > >>> On Wed, 2 Aug 2023, Nicola Vetrini wrote: > >>>> @@ -1169,8 +1170,6 @@ static void cf_check > >>>> irq_guest_eoi_timer_fn(void *data) > >>>> > >>>> switch ( action->ack_type ) > >>>> { > >>>> - cpumask_t *cpu_eoi_map; > >>> > >>> It is only used by case ACKTYPE_EOI so it can be moved there (with a > >>> new > >>> block): > >>> > >>> > >>> case ACKTYPE_EOI: > >>> { > >>> cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); > >>> cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); > >>> spin_unlock_irq(&desc->lock); > >>> on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); > >>> return; > >>> } > >>> } > >> > >> This pattern (two closing braces at the same level) is why switch scope > >> variable declarations were introduced (at least as far as introductions > >> by me go). If switch scope variables aren't okay (which I continue to > >> consider questionable), then this stylistic aspect needs sorting first > >> (if everyone else thinks the above style is okay - with the missing > >> blank line inserted -, then so be it). > > > > Actually, they can be deviated because they don't result in wrong code > > being generated. > > Only later I recalled Andrew's intention to possibly make use of > -ftrivial-auto-var-init. While, unlike I think he said, such declared > variables aren't getting in the way of this (neither gcc nor clang > warn about them), they also don't benefit from it (i.e. they'll be > left uninitialized despite the command line option saying otherwise). > IOW I think further consideration is going to be needed here. Let me get this right. Are you saying that if we enable -ftrivial-auto-var-init, due to a compiler limitation, variables declared as follow: switch(var) { int a; char b; case ... do not benefit from -ftrivial-auto-var-init ? So if we moved the variable declarations elsewhere, in one of the two following ways: 1) int a; int b; switch(var) { 2) switch(var) { case 1: { int a; int b; Then -ftrivial-auto-var-init would take effect? If so, I think it is worth a discussion on what to do there. But either way right now I think it is fine to take the switch-related patches out of this series. From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:41:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577311.904338 (Exim 4.92) (envelope-from ) id 1qS1be-0000YX-Az; Fri, 04 Aug 2023 20:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577311.904338; Fri, 04 Aug 2023 20:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1be-0000YQ-8I; Fri, 04 Aug 2023 20:41:06 +0000 Received: by outflank-mailman (input) for mailman id 577311; Fri, 04 Aug 2023 20:41:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1bc-0000YK-VZ for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:41:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 394c9368-3307-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 22:41:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C5B77620A7; Fri, 4 Aug 2023 20:41:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A3DEC433C8; Fri, 4 Aug 2023 20:40:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 394c9368-3307-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691181660; bh=Q2MFQONWqVMXPNZghgIWxXFH2+6xxlzM8Y2/O5b+18M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=gY9xMlOar7UfdCABbNoKCLWMeB2QO7HhCDx+Zu1/ycT+Ti9/smjVTt1o0Mjhi8k3N 7mx/FpMtdI3jG80LYDjG/0MP9EmG59NWxYc60UBspDC6tKph3/NhhliTy+g3JPXM8I Ab0OH0YV1ujyewo41H/hnMjrppao0195Q1f6ev/XVne4CB4vUEQ7wlrIgKF1Em+F3W VCa13T2qOJJpKWEpf2GVS+lIfdJZ2moivFpt7cCJwMAk8YFWdEiSvsR8Tf1QeNWOfP Opr1z/eT2ykoAi9nHXXqIYouqSnTGKQ72Mu+8fEtb/QAb12lBMd+MR5StUboQF1Q/W TrIT7sK3unLXw== Date: Fri, 4 Aug 2023 13:40:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: <95a6d085-cbb9-ecb6-134d-6e4d994bfd35@suse.com> Message-ID: References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> <95a6d085-cbb9-ecb6-134d-6e4d994bfd35@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Jan Beulich wrote: > On 04.08.2023 11:47, Nicola Vetrini wrote: > > Upon further examination, I identified the following patterns: > > > > 1. Functions defined in .c called only from asm code (e.g., the already > > mentioned __start_xen) > > 2. Functions/variables declared in a .h, defined in a .c that does not > > include the .h with the declaration > > (e.g., 'fill_console_start_info' is defined in 'xen/drivers/vga.c', > > declared in 'xen/include/xen/console.h' which is not visible when > > compiling the .c). > > 3. Variables that are either extern or not, such as 'acpi_gbl_FADT' in > > 'xen/include/acpi/acglobal.h', depending on > > DEFINE_ACPI_GLOBALS > > > > Below are the proposed resolution strategies: > > > > 1. I would advise to add the declaration in the relative .h, to support > > automatic consistency checks with the > > implementation and a quick reference when touching the asm. > > That'll need discussing first. My take is that it would be nicer if they were declared in .h files. It would also be useful for ourselves as documentation/reference. So I would be OK accepting patches like that. But at the same time I don't see it as a must-have requirement for safety (the .h declaration would not be actually used). > > 2. To comply with the rule, the header with the declaration should be > > included. Also note that there are some > > corner cases, such as 'get_sec', which is used in 'cper.h' without > > including 'time.h' (which should gain a > > declaration for it). > > This one of course wants fixing wherever found. +1 > > 3. One possible resolution pattern is including 'acglobal.h' twice > > (either directly or indirectly trough acpi.h, if > > the latter does not cause other issues) like so: > > > > (assuming DEFINE_ACPI_GLOBALS is undefined here) > > #include "acglobal.h" > > #define DEFINE_ACPI_GLOBALS > > #include "acglobal.h" > > > > this way, the rule is followed properly, though it's not the prettiest > > pattern and also clashes with the objectives > > of D4.10 ("Precautions shall be taken in order to prevent the contents > > of a header file being included > > more than once"), but then a motivated exception is allowed there. > > Not really sure about this one. I would leave these alone because it was clearly done on purpose "to simplify maintenance of the code" as the in-code comment claims. Also this is very old code, probably inherited from somewhere else and never changed. From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:43:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:43:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577315.904349 (Exim 4.92) (envelope-from ) id 1qS1dx-0001Av-Sd; Fri, 04 Aug 2023 20:43:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577315.904349; Fri, 04 Aug 2023 20:43:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1dx-0001Ao-Pj; Fri, 04 Aug 2023 20:43:29 +0000 Received: by outflank-mailman (input) for mailman id 577315; Fri, 04 Aug 2023 20:43:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1dw-0001Ag-5c for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:43:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8eee71aa-3307-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 22:43:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9080A620A7; Fri, 4 Aug 2023 20:43:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 959EDC433C7; Fri, 4 Aug 2023 20:43:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8eee71aa-3307-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691181804; bh=KKwcx5LNbFIDE+0Rb0D9JxK1rWrcq+pB7mVcltQdYz4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UM0pz+a93+cn2ggbBTLlwPcVOwD4kkRx0PYZ97mdRZqIcobOpSINCsAcekiml8OS+ pXWmMpQm0qm88hPzI3lawo96TPpJhV332B45e+edYG17TZ9v7ccnLaYJUjo/f89mLm JC74fn6F/X/WdMcTMoKliwk1h9oXYjQCWP5Z1cfDHayuc11DaiYWPojjvh9ZWGKVG6 Yun8jiV7430CF0E5gSxTf+Iw1WUrVJSU/Cys6x1roxT+Ov8ZLyVBpLd2T0sdzlj0ax bLwhy2Ho1/atzYCxEFMITX/8fQTRTSvh8okXHuU/QFdR/V2v78d+W93muV+UyHpJHa ltcOEliseA8Ew== Date: Fri, 4 Aug 2023 13:43:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH v2 1/4] x86/mce: address MISRA C:2012 Rule 5.3 In-Reply-To: <8a11baf39c140af9d5694298e5f1f0bf59ac0621.1691135862.git.nicola.vetrini@bugseng.com> Message-ID: References: <8a11baf39c140af9d5694298e5f1f0bf59ac0621.1691135862.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > Suitable mechanical renames are made to avoid shadowing > the function identifier 'wait' declared in 'xen/include/xen/wait.h', > thus addressing violations of MISRA C:2012 Rule 5.3: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope" > > The parameter name 'bar' is added as well to comply with MISRA C:2012 > Rules 8.2 and 8.3. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Added parameter name 'bar' where missing. > - Amended commit message. > --- > xen/arch/x86/cpu/mcheck/barrier.c | 8 ++++---- > xen/arch/x86/cpu/mcheck/barrier.h | 14 +++++++------- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/xen/arch/x86/cpu/mcheck/barrier.c b/xen/arch/x86/cpu/mcheck/barrier.c > index a7e5b19a44..51a1d37a76 100644 > --- a/xen/arch/x86/cpu/mcheck/barrier.c > +++ b/xen/arch/x86/cpu/mcheck/barrier.c > @@ -16,11 +16,11 @@ void mce_barrier_dec(struct mce_softirq_barrier *bar) > atomic_dec(&bar->val); > } > > -void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) > +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait) > { > int gen; > > - if ( !wait ) > + if ( !do_wait ) > return; > atomic_inc(&bar->ingen); > gen = atomic_read(&bar->outgen); > @@ -34,11 +34,11 @@ void mce_barrier_enter(struct mce_softirq_barrier *bar, bool wait) > } > } > > -void mce_barrier_exit(struct mce_softirq_barrier *bar, bool wait) > +void mce_barrier_exit(struct mce_softirq_barrier *bar, bool do_wait) > { > int gen; > > - if ( !wait ) > + if ( !do_wait ) > return; > atomic_inc(&bar->outgen); > gen = atomic_read(&bar->ingen); > diff --git a/xen/arch/x86/cpu/mcheck/barrier.h b/xen/arch/x86/cpu/mcheck/barrier.h > index c4d52b6192..7ec483226f 100644 > --- a/xen/arch/x86/cpu/mcheck/barrier.h > +++ b/xen/arch/x86/cpu/mcheck/barrier.h > @@ -20,7 +20,7 @@ struct mce_softirq_barrier { > /* > * Initialize a barrier. Just set it to 0. > */ > -void mce_barrier_init(struct mce_softirq_barrier *); > +void mce_barrier_init(struct mce_softirq_barrier *bar); > > /* > * This function will need to be used when offlining a CPU in the > @@ -29,17 +29,17 @@ void mce_barrier_init(struct mce_softirq_barrier *); > * Decrement a barrier only. Needed for cases where the CPU > * in question can't do it itself (e.g. it is being offlined). > */ > -void mce_barrier_dec(struct mce_softirq_barrier *); > +void mce_barrier_dec(struct mce_softirq_barrier *bar); > > /* > - * If @wait is false, mce_barrier_enter/exit() will return immediately > + * If @do_wait is false, mce_barrier_enter/exit() will return immediately > * without touching the barrier. It's used when handling a > * non-broadcasting MCE (e.g. MCE on some old Intel CPU, MCE on AMD > * CPU and LMCE on Intel Skylake-server CPU) which is received on only > * one CPU and thus does not invoke mce_barrier_enter/exit() calls on > * all CPUs. > * > - * If @wait is true, mce_barrier_enter/exit() will handle the given > + * If @do_wait is true, mce_barrier_enter/exit() will handle the given > * barrier as below. > * > * Increment the generation number and the value. The generation number > @@ -53,9 +53,9 @@ void mce_barrier_dec(struct mce_softirq_barrier *); > * These barrier functions should always be paired, so that the > * counter value will reach 0 again after all CPUs have exited. > */ > -void mce_barrier_enter(struct mce_softirq_barrier *, bool wait); > -void mce_barrier_exit(struct mce_softirq_barrier *, bool wait); > +void mce_barrier_enter(struct mce_softirq_barrier *bar, bool do_wait); > +void mce_barrier_exit(struct mce_softirq_barrier *bar, bool do_wait); > > -void mce_barrier(struct mce_softirq_barrier *); > +void mce_barrier(struct mce_softirq_barrier *bar); > > #endif /* _MCHECK_BARRIER_H */ > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:45:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:45:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577319.904359 (Exim 4.92) (envelope-from ) id 1qS1gH-0001m0-9w; Fri, 04 Aug 2023 20:45:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577319.904359; Fri, 04 Aug 2023 20:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1gH-0001lt-5b; Fri, 04 Aug 2023 20:45:53 +0000 Received: by outflank-mailman (input) for mailman id 577319; Fri, 04 Aug 2023 20:45:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1gF-0001ln-Jq for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:45:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e50848c6-3307-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 22:45:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39D5C61E90; Fri, 4 Aug 2023 20:45:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40D85C433C8; Fri, 4 Aug 2023 20:45:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e50848c6-3307-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691181948; bh=+B/cxpITPOCEy1KjrEmOfqt/IHipkg6GLaww23vslLc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=u7KFIr3QY8uRJS07RwtgiZwFyMfNwHlMov4G+IAiT4vADUkS0KTahGYSdlZ40pCQo ZZNZPQn4g0lJ9pOBTARidyKS39/4FP0XYXgg5OPBdtQe7PJDrbMGkZGL8Gt2lYmNBI 8y0KVSmyKM1UONq1cOakvZ8pMK1bu3QI/YVWTDMLq6hEipquDPDAwh6AvSzl9HEEkw DudUhmEzn7hkNsysd02nS42FGg5oKnElNUaDFl+HCqjOzSaU2K9kfjCauLyvbPemk1 Hw4v5QsERDIf7Bz42QzRxuoCq9C28RrBRc4JjU8ds/PanUTjaN93AQTWVn5LmezAlm E8EPXHw+mRUuQ== Date: Fri, 4 Aug 2023 13:45:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH v2 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 In-Reply-To: <2f7380396ee146132738dd5c6b2a80d62a8035d5.1691135862.git.nicola.vetrini@bugseng.com> Message-ID: References: <2f7380396ee146132738dd5c6b2a80d62a8035d5.1691135862.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > Rename variables to avoid shadowing and thus address > MISRA C:2012 Rule 5.3: > "An identifier declared in an inner scope shall not hide an > identifier declared in an outer scope". > > The shadowing happens between the struct declaration 'mtrr_state' in > 'xen/arch/x86/include/asm/mtrr.h' and local variable names. > The latter are renamed to 'm', which is used elsewhere in > 'xen/arch/x86/hvm/mtrr.c' for the same purpose. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Renamed 'mtrr' local variables to 'm'. > - Added references in the commit message. > --- > xen/arch/x86/hvm/mtrr.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/x86/hvm/mtrr.c b/xen/arch/x86/hvm/mtrr.c > index 29f3fb1607..7f486358b1 100644 > --- a/xen/arch/x86/hvm/mtrr.c > +++ b/xen/arch/x86/hvm/mtrr.c > @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, uint64_t gfn_start, > > static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) > { > - const struct mtrr_state *mtrr_state = &v->arch.hvm.mtrr; > + const struct mtrr_state *m = &v->arch.hvm.mtrr; > struct hvm_hw_mtrr hw_mtrr = { > - .msr_mtrr_def_type = mtrr_state->def_type | > - MASK_INSR(mtrr_state->fixed_enabled, > + .msr_mtrr_def_type = m->def_type | > + MASK_INSR(m->fixed_enabled, > MTRRdefType_FE) | > - MASK_INSR(mtrr_state->enabled, MTRRdefType_E), > - .msr_mtrr_cap = mtrr_state->mtrr_cap, > + MASK_INSR(m->enabled, MTRRdefType_E), > + .msr_mtrr_cap = m->mtrr_cap, > }; > unsigned int i; > > @@ -710,14 +710,14 @@ static int cf_check hvm_save_mtrr_msr(struct vcpu *v, hvm_domain_context_t *h) > > for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) > { > - hw_mtrr.msr_mtrr_var[i * 2] = mtrr_state->var_ranges->base; > - hw_mtrr.msr_mtrr_var[i * 2 + 1] = mtrr_state->var_ranges->mask; > + hw_mtrr.msr_mtrr_var[i * 2] = m->var_ranges->base; > + hw_mtrr.msr_mtrr_var[i * 2 + 1] = m->var_ranges->mask; > } > > BUILD_BUG_ON(sizeof(hw_mtrr.msr_mtrr_fixed) != > - sizeof(mtrr_state->fixed_ranges)); > + sizeof(m->fixed_ranges)); > > - memcpy(hw_mtrr.msr_mtrr_fixed, mtrr_state->fixed_ranges, > + memcpy(hw_mtrr.msr_mtrr_fixed, m->fixed_ranges, > sizeof(hw_mtrr.msr_mtrr_fixed)); > > return hvm_save_entry(MTRR, v->vcpu_id, h, &hw_mtrr); > @@ -727,7 +727,7 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) > { > unsigned int vcpuid, i; > struct vcpu *v; > - struct mtrr_state *mtrr_state; > + struct mtrr_state *m; > struct hvm_hw_mtrr hw_mtrr; > > vcpuid = hvm_load_instance(h); > @@ -749,26 +749,26 @@ static int cf_check hvm_load_mtrr_msr(struct domain *d, hvm_domain_context_t *h) > return -EINVAL; > } > > - mtrr_state = &v->arch.hvm.mtrr; > + m = &v->arch.hvm.mtrr; > > hvm_set_guest_pat(v, hw_mtrr.msr_pat_cr); > > - mtrr_state->mtrr_cap = hw_mtrr.msr_mtrr_cap; > + m->mtrr_cap = hw_mtrr.msr_mtrr_cap; > > for ( i = 0; i < NUM_FIXED_MSR; i++ ) > - mtrr_fix_range_msr_set(d, mtrr_state, i, hw_mtrr.msr_mtrr_fixed[i]); > + mtrr_fix_range_msr_set(d, m, i, hw_mtrr.msr_mtrr_fixed[i]); > > for ( i = 0; i < MASK_EXTR(hw_mtrr.msr_mtrr_cap, MTRRcap_VCNT); i++ ) > { > - mtrr_var_range_msr_set(d, mtrr_state, > + mtrr_var_range_msr_set(d, m, > MSR_IA32_MTRR_PHYSBASE(i), > hw_mtrr.msr_mtrr_var[i * 2]); > - mtrr_var_range_msr_set(d, mtrr_state, > + mtrr_var_range_msr_set(d, m, > MSR_IA32_MTRR_PHYSMASK(i), > hw_mtrr.msr_mtrr_var[i * 2 + 1]); > } > > - mtrr_def_type_msr_set(d, mtrr_state, hw_mtrr.msr_mtrr_def_type); > + mtrr_def_type_msr_set(d, m, hw_mtrr.msr_mtrr_def_type); > > return 0; > } > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:47:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:47:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577323.904368 (Exim 4.92) (envelope-from ) id 1qS1hw-0002Lj-Ir; Fri, 04 Aug 2023 20:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577323.904368; Fri, 04 Aug 2023 20:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1hw-0002Lc-GE; Fri, 04 Aug 2023 20:47:36 +0000 Received: by outflank-mailman (input) for mailman id 577323; Fri, 04 Aug 2023 20:47:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1hv-0002LW-BK for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:47:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22730670-3308-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 22:47:33 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E51461CB6; Fri, 4 Aug 2023 20:47:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0EE9C433C7; Fri, 4 Aug 2023 20:47:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22730670-3308-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691182051; bh=g/VgDHj32LXpUfFXYAnLTMFnaw6k10DQKllvZH82HKg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=GQhAGR0vyfLBsKuJjJqiJzE4iPGxyreG0iVIW/FPZtqnCPrRYDk6EeLxNbgjdneOx KxvHnWMXbGhsYbgIEjLviMLlE+3ZoLp3jgjMPPL2qqpQISL9lwMiub6JY4RWmOsccB EKbYh7ckQRSheK/5C1Io4OnA9LSsdP3MQ8lLCbQitzQAkZhDn3OR1K6+QRQb/XsD8x p3mddX302ZjyW7arF3BR3dsoU6zDFiSXLDCQNpnY3IxJn4iFaKxnRI9qeqA8tjsljG CboH03lvsYZ4keXLpSkXZKccprVOitugFE5AZDkNoLlJX2iG+Zta5Co19a5Hm4CU8V snm5yxvtCufdQ== Date: Fri, 4 Aug 2023 13:47:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: Re: [XEN PATCH v2 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 In-Reply-To: <987ebd142ebd69ed062d74f7eb69c23759c51636.1691135862.git.nicola.vetrini@bugseng.com> Message-ID: References: <987ebd142ebd69ed062d74f7eb69c23759c51636.1691135862.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > The extern variable 'irq_desc' defined in 'irq.h' is shadowed by > local variables in the changed file. To avoid this, the variable is > renamed to 'irq_description'. > > No functional change. > > Signed-off-by: Nicola Vetrini You missed me reviewed tag from the previous version: Reviewed-by: Stefano Stabellini Also Jan, sorry I am already losing my new habit of trimming my replies :-) From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:49:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:49:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577327.904379 (Exim 4.92) (envelope-from ) id 1qS1jJ-0002uV-VW; Fri, 04 Aug 2023 20:49:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577327.904379; Fri, 04 Aug 2023 20:49:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1jJ-0002uO-RT; Fri, 04 Aug 2023 20:49:01 +0000 Received: by outflank-mailman (input) for mailman id 577327; Fri, 04 Aug 2023 20:49:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1jI-0002uG-FY for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:49:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5519c98b-3308-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 22:48:58 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C19D620AE; Fri, 4 Aug 2023 20:48:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16ED9C433C7; Fri, 4 Aug 2023 20:48:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5519c98b-3308-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691182136; bh=71knx/FwEiKGHrHIwzyEgucFHxOXHAsUN2J5FL1SK9o=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=hqLzG/NyAmEHLhQE2jNHQjUnyRYbbmYklA0S44j/laRGBJXGwcAMjGfretYhQCER1 CF+gXzLGmHH2AgiiS6/uocztMtQxfmH31fl+4DrAMiRm85wn4pMqfwo0w/RCEaclWb LZg0L27YSlqiuQDCyFp0DQ/dF6RanQt3ilvcTNJenpOMpM6UPwffLBFuzTubo8BinM pt/KGVcbnJpcCnKpD+TLVyA0/8KskzH+JHbjE3gjbtJyyjZITD+vVE/vqNqZGFyQCd vzXHebBcDUgpuGsmaHFR053sIM0TKuoI8j901HdfrVbdxo6910ccNU/npzj0EiTK0F 9jT0mn7PF26EQ== Date: Fri, 4 Aug 2023 13:48:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH v2 4/4] x86/setup: address MISRA C:2012 Rule 5.3 In-Reply-To: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> Message-ID: References: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > The parameters renamed in the function declaration caused shadowing > with the homonymous variable in 'xen/common/efi/boot.c'. Renaming > them also addresses Rule 8.3: > "All declarations of an object or function shall use the same names > and type qualifiers". > > The local variable 'mask' is removed because it shadows the homonymous > variable defined in an outer scope, with no change to the semantics. > > No functional changes. > > Signed-off-by: Nicola Vetrini Same here From xen-devel-bounces@lists.xenproject.org Fri Aug 04 20:53:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 20:53:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577331.904388 (Exim 4.92) (envelope-from ) id 1qS1nm-0004Lu-FQ; Fri, 04 Aug 2023 20:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577331.904388; Fri, 04 Aug 2023 20:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1nm-0004Ln-CT; Fri, 04 Aug 2023 20:53:38 +0000 Received: by outflank-mailman (input) for mailman id 577331; Fri, 04 Aug 2023 20:53:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS1nl-0004Lh-2T for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 20:53:37 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fa7e1c5d-3308-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 22:53:35 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B62B6620D0; Fri, 4 Aug 2023 20:53:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5161C433C7; Fri, 4 Aug 2023 20:53:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa7e1c5d-3308-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691182414; bh=HoZei8B2R8a954IClspujnbBZ8uQoJ9HV9nW8Z0GorI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cs3QZWeKyzoKCDh8eLdlrRWuBNl8pk1Qs9MKlyKgSa9uY787YMbMhIdwcI+pArC3/ NdoN48bIA8xcouEQn9B18s9IbWlQSeZKiqxjGCsrYe+N5iLN4JO9dhZqU5r5OsoBDh niFWLcR8CVxhdj9IKrYXoKk2ygHAvfYip796V1sKQ2dtuLbkZgJZDrOSJAV3Eu4Eyl Q9pUo4oZxG45OdM0PIy50BA/guRePs5uRp0cIJzwWutA2oVhypYyyNjYRN9KfUH3SJ w3e9hV+hYHb3Aj0jEWi42D5hu5MG/QpX/uK4GWv6EzMfRmEO+Lr3TIWSJsq2BKjwFs O/JGZdhoQmmRA== Date: Fri, 4 Aug 2023 13:53:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Federico Serafini cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder Subject: Re: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t In-Reply-To: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> Message-ID: References: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Federico Serafini wrote: > Give a name to unnamed parameters to address violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between object and function declarations thus > addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an > object or function shall use the same names and type qualifiers"). > Replace the occurrences of bool_t with bool. > > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:20:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:20:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577337.904399 (Exim 4.92) (envelope-from ) id 1qS2DI-00074K-HX; Fri, 04 Aug 2023 21:20:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577337.904399; Fri, 04 Aug 2023 21:20:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2DI-00074D-Ec; Fri, 04 Aug 2023 21:20:00 +0000 Received: by outflank-mailman (input) for mailman id 577337; Fri, 04 Aug 2023 21:19:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2DG-000734-Rm for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:19:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a80c6d19-330c-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 23:19:55 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 26CAA62039; Fri, 4 Aug 2023 21:19:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED5FEC433C7; Fri, 4 Aug 2023 21:19:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a80c6d19-330c-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691183993; bh=MjH+DgMHp7Kz20cod7LEVtviJLOzWuuJbcDcC5kF8PA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AG46CrKNwHHdZGOGkWXZ5ojdUjdTacGHR6YetlOmiUHbc1Ur+A5++N7+rw0wPVbRv Vm+kSIPLEZtwakUGH6bWBKvuPm9S3EoxGHc0NSyqNpT/wCH8pe1qrhFn4USTgbqxyf 2JgSz06bFCO8cWiwWfPCEOybGxhnIILJcIvWudPJZcz4wi5G7s9/1nnmljHkhXb+IA WjBtAPe9ULJBQhhJ967E8rxzRwW9iD3zjqp0cbgItPnLLr8Yv/s+1oWmbtwXMlbH1I 4C9edrXG266C+Y7uqY8DO9GfsgEy0v3MHMq8gmCPRmB8DX4F0kk2rZ9ytnXzG5DpV0 NpOF5MOkOysow== Date: Fri, 4 Aug 2023 14:19:50 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> Message-ID: References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > The variable declared in the header file 'xen/arch/x86/include/asm/e820.h' > is shadowed by many function parameters, so it is renamed to avoid these > violations. > > No functional changes. > > Signed-off-by: Nicola Vetrini > --- > This patch is similar to other renames done on previous patches, and the > preferred strategy there was to rename the global variable. This one > has more occurrences that are spread in various files, but > the general pattern is the same. > --- > xen/arch/x86/dom0_build.c | 10 ++-- > xen/arch/x86/e820.c | 66 ++++++++++++------------ > xen/arch/x86/guest/xen/xen.c | 4 +- > xen/arch/x86/hvm/dom0_build.c | 6 +-- > xen/arch/x86/include/asm/e820.h | 2 +- > xen/arch/x86/mm.c | 49 +++++++++--------- > xen/arch/x86/numa.c | 8 +-- > xen/arch/x86/setup.c | 22 ++++---- > xen/arch/x86/srat.c | 6 +-- > xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- > xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- There are missing changes to xen/arch/x86/tboot.c There a few stray changes below. Everything else is correct. > 11 files changed, 89 insertions(+), 88 deletions(-) > > diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c > index 8b1fcc6471..bfb6400376 100644 > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -534,13 +534,13 @@ int __init dom0_setup_permissions(struct domain *d) > } > > /* Remove access to E820_UNUSABLE I/O regions above 1MB. */ > - for ( i = 0; i < e820.nr_map; i++ ) > + for ( i = 0; i < e820_map.nr_map; i++ ) > { > unsigned long sfn, efn; > - sfn = max_t(unsigned long, paddr_to_pfn(e820.map[i].addr), 0x100ul); > - efn = paddr_to_pfn(e820.map[i].addr + e820.map[i].size - 1); > - if ( (e820.map[i].type == E820_UNUSABLE) && > - (e820.map[i].size != 0) && > + sfn = max_t(unsigned long, paddr_to_pfn(e820_map.map[i].addr), 0x100ul); > + efn = paddr_to_pfn(e820_map.map[i].addr + e820_map.map[i].size - 1); > + if ( (e820_map.map[i].type == E820_UNUSABLE) && > + (e820_map.map[i].size != 0) && > (sfn <= efn) ) > rc |= iomem_deny_access(d, sfn, efn); > } > diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c > index 0b89935510..4425011c01 100644 > --- a/xen/arch/x86/e820.c > +++ b/xen/arch/x86/e820.c > @@ -34,7 +34,7 @@ boolean_param("e820-mtrr-clip", e820_mtrr_clip); > static bool __initdata e820_verbose; > boolean_param("e820-verbose", e820_verbose); > > -struct e820map e820; > +struct e820map e820_map; > struct e820map __initdata e820_raw; > > /* > @@ -47,8 +47,8 @@ int __init e820_all_mapped(u64 start, u64 end, unsigned type) > { > unsigned int i; > > - for (i = 0; i < e820.nr_map; i++) { > - struct e820entry *ei = &e820.map[i]; > + for (i = 0; i < e820_map.nr_map; i++) { > + struct e820entry *ei = &e820_map.map[i]; > > if (type && ei->type != type) > continue; > @@ -75,17 +75,17 @@ int __init e820_all_mapped(u64 start, u64 end, unsigned type) > static void __init add_memory_region(unsigned long long start, > unsigned long long size, int type) > { > - unsigned int x = e820.nr_map; > + unsigned int x = e820_map.nr_map; > > - if (x == ARRAY_SIZE(e820.map)) { > + if (x == ARRAY_SIZE(e820_map.map)) { > printk(KERN_ERR "Ooops! Too many entries in the memory map!\n"); > return; > } > > - e820.map[x].addr = start; > - e820.map[x].size = size; > - e820.map[x].type = type; > - e820.nr_map++; > + e820_map.map[x].addr = start; > + e820_map.map[x].size = size; > + e820_map.map[x].type = type; > + e820_map.nr_map++; > } > > void __init print_e820_memory_map(const struct e820entry *map, > @@ -347,13 +347,13 @@ static unsigned long __init find_max_pfn(void) > unsigned int i; > unsigned long max_pfn = 0; > > - for (i = 0; i < e820.nr_map; i++) { > + for (i = 0; i < e820_map.nr_map; i++) { > unsigned long start, end; > /* RAM? */ > - if (e820.map[i].type != E820_RAM) > + if (e820_map.map[i].type != E820_RAM) > continue; > - start = PFN_UP(e820.map[i].addr); > - end = PFN_DOWN(e820.map[i].addr + e820.map[i].size); > + start = PFN_UP(e820_map.map[i].addr); > + end = PFN_DOWN(e820_map.map[i].addr + e820_map.map[i].size); > if (start >= end) > continue; > if (end > max_pfn) > @@ -372,21 +372,21 @@ static void __init clip_to_limit(uint64_t limit, const char *warnmsg) > for ( ; ; ) > { > /* Find a RAM region needing clipping. */ > - for ( i = 0; i < e820.nr_map; i++ ) > - if ( (e820.map[i].type == E820_RAM) && > - ((e820.map[i].addr + e820.map[i].size) > limit) ) > + for ( i = 0; i < e820_map.nr_map; i++ ) > + if ( (e820_map.map[i].type == E820_RAM) && > + ((e820_map.map[i].addr + e820_map.map[i].size) > limit) ) > break; > > /* If none found, we are done. */ > - if ( i == e820.nr_map ) > - break; > + if ( i == e820_map.nr_map ) > + break; > > old_limit = max_t( > - uint64_t, old_limit, e820.map[i].addr + e820.map[i].size); > + uint64_t, old_limit, e820_map.map[i].addr + e820_map.map[i].size); > > /* We try to convert clipped RAM areas to E820_UNUSABLE. */ > - if ( e820_change_range_type(&e820, max(e820.map[i].addr, limit), > - e820.map[i].addr + e820.map[i].size, > + if ( e820_change_range_type(&e820_map, max(e820_map.map[i].addr, limit), > + e820_map.map[i].addr + e820_map.map[i].size, > E820_RAM, E820_UNUSABLE) ) > continue; > > @@ -394,15 +394,15 @@ static void __init clip_to_limit(uint64_t limit, const char *warnmsg) > * If the type change fails (e.g., not space in table) then we clip or > * delete the region as appropriate. > */ > - if ( e820.map[i].addr < limit ) > + if ( e820_map.map[i].addr < limit ) > { > - e820.map[i].size = limit - e820.map[i].addr; > + e820_map.map[i].size = limit - e820_map.map[i].addr; > } > else > { > - memmove(&e820.map[i], &e820.map[i+1], > - (e820.nr_map - i - 1) * sizeof(struct e820entry)); > - e820.nr_map--; > + memmove(&e820_map.map[i], &e820_map.map[i+1], > + (e820_map.nr_map - i - 1) * sizeof(struct e820entry)); > + e820_map.nr_map--; > } > } > > @@ -497,7 +497,7 @@ static void __init reserve_dmi_region(void) > if ( !what ) > break; > if ( ((base + len) > base) && > - reserve_e820_ram(&e820, base, base + len) ) > + reserve_e820_ram(&e820_map, base, base + len) ) > printk("WARNING: %s table located in E820 RAM %"PRIpaddr"-%"PRIpaddr". Fixed.\n", > what, base, base + len); > } > @@ -517,12 +517,12 @@ static void __init machine_specific_memory_setup(struct e820map *raw) > > if ( opt_availmem ) > { > - for ( i = size = 0; (i < e820.nr_map) && (size <= opt_availmem); i++ ) > - if ( e820.map[i].type == E820_RAM ) > - size += e820.map[i].size; > + for ( i = size = 0; (i < e820_map.nr_map) && (size <= opt_availmem); i++ ) > + if ( e820_map.map[i].type == E820_RAM ) > + size += e820_map.map[i].size; > if ( size > opt_availmem ) > clip_to_limit( > - e820.map[i-1].addr + e820.map[i-1].size - (size-opt_availmem), > + e820_map.map[i-1].addr + e820_map.map[i-1].size - (size-opt_availmem), > NULL); > } > > @@ -694,10 +694,10 @@ unsigned long __init init_e820(const char *str, struct e820map *raw) > machine_specific_memory_setup(raw); > > if ( cpu_has_hypervisor ) > - hypervisor_e820_fixup(&e820); > + hypervisor_e820_fixup(&e820_map); > > printk("%s RAM map:\n", str); > - print_e820_memory_map(e820.map, e820.nr_map); > + print_e820_memory_map(e820_map.map, e820_map.nr_map); > > return find_max_pfn(); > } > diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c > index f93dfc89f7..3ec828b98d 100644 > --- a/xen/arch/x86/guest/xen/xen.c > +++ b/xen/arch/x86/guest/xen/xen.c > @@ -147,9 +147,9 @@ static void __init init_memmap(void) > PFN_DOWN(GB(4) - 1))) ) > panic("unable to add RAM to in-use PFN rangeset\n"); > > - for ( i = 0; i < e820.nr_map; i++ ) > + for ( i = 0; i < e820_map.nr_map; i++ ) > { > - struct e820entry *e = &e820.map[i]; > + struct e820entry *e = &e820_map.map[i]; > > if ( rangeset_add_range(mem, PFN_DOWN(e->addr), > PFN_UP(e->addr + e->size - 1)) ) > diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c > index bc0e290db6..98203f7a52 100644 > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -333,13 +333,13 @@ static __init void pvh_setup_e820(struct domain *d, unsigned long nr_pages) > * Add an extra entry in case we have to split a RAM entry into a RAM and a > * UNUSABLE one in order to truncate it. > */ > - d->arch.e820 = xzalloc_array(struct e820entry, e820.nr_map + 1); > + d->arch.e820 = xzalloc_array(struct e820entry, e820_map.nr_map + 1); > if ( !d->arch.e820 ) > panic("Unable to allocate memory for Dom0 e820 map\n"); > entry_guest = d->arch.e820; > > /* Clamp e820 memory map to match the memory assigned to Dom0 */ > - for ( i = 0, entry = e820.map; i < e820.nr_map; i++, entry++ ) > + for ( i = 0, entry = e820_map.map; i < e820_map.nr_map; i++, entry++ ) > { > *entry_guest = *entry; > > @@ -392,7 +392,7 @@ static __init void pvh_setup_e820(struct domain *d, unsigned long nr_pages) > next: > d->arch.nr_e820++; > entry_guest++; > - ASSERT(d->arch.nr_e820 <= e820.nr_map + 1); > + ASSERT(d->arch.nr_e820 <= e820_map.nr_map + 1); > } > ASSERT(cur_pages == nr_pages); > } > diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e820.h > index 213d5b5dd2..0865825f7d 100644 > --- a/xen/arch/x86/include/asm/e820.h > +++ b/xen/arch/x86/include/asm/e820.h > @@ -34,7 +34,7 @@ extern int e820_add_range( > extern unsigned long init_e820(const char *str, struct e820map *raw); > extern void print_e820_memory_map(const struct e820entry *map, > unsigned int entries); > -extern struct e820map e820; > +extern struct e820map e820_map; > extern struct e820map e820_raw; > > /* These symbols live in the boot trampoline. */ > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index be2b10a391..6920ac939f 100644 > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -295,12 +295,12 @@ void __init arch_init_memory(void) > /* Any areas not specified as RAM by the e820 map are considered I/O. */ > for ( i = 0, pfn = 0; pfn < max_page; i++ ) > { > - while ( (i < e820.nr_map) && > - (e820.map[i].type != E820_RAM) && > - (e820.map[i].type != E820_UNUSABLE) ) > + while ( (i < e820_map.nr_map) && > + (e820_map.map[i].type != E820_RAM) && > + (e820_map.map[i].type != E820_UNUSABLE) ) > i++; > > - if ( i >= e820.nr_map ) > + if ( i >= e820_map.nr_map ) > { > /* No more RAM regions: mark as I/O right to end of memory map. */ > rstart_pfn = rend_pfn = max_page; > @@ -309,9 +309,10 @@ void __init arch_init_memory(void) > { > /* Mark as I/O just up as far as next RAM region. */ > rstart_pfn = min_t(unsigned long, max_page, > - PFN_UP(e820.map[i].addr)); > + PFN_UP(e820_map.map[i].addr)); > rend_pfn = max_t(unsigned long, rstart_pfn, > - PFN_DOWN(e820.map[i].addr + e820.map[i].size)); > + PFN_DOWN(e820_map.map[i].addr > + + e820_map.map[i].size)); > } > > /* > @@ -387,9 +388,9 @@ int page_is_ram_type(unsigned long mfn, unsigned long mem_type) > uint64_t maddr = pfn_to_paddr(mfn); > int i; > > - for ( i = 0; i < e820.nr_map; i++ ) > + for ( i = 0; i < e820_map.nr_map; i++ ) > { > - switch ( e820.map[i].type ) > + switch ( e820_map.map[i].type ) > { > case E820_RAM: > if ( mem_type & RAM_TYPE_CONVENTIONAL ) > @@ -414,8 +415,8 @@ int page_is_ram_type(unsigned long mfn, unsigned long mem_type) > } > > /* Test the range. */ > - if ( (e820.map[i].addr <= maddr) && > - ((e820.map[i].addr + e820.map[i].size) >= (maddr + PAGE_SIZE)) ) > + if ( (e820_map.map[i].addr <= maddr) && > + ((e820_map.map[i].addr + e820_map.map[i].size) >= (maddr + PAGE_SIZE)) ) > return 1; > } > > @@ -427,17 +428,17 @@ unsigned int page_get_ram_type(mfn_t mfn) > uint64_t last = 0, maddr = mfn_to_maddr(mfn); > unsigned int i, type = 0; > > - for ( i = 0; i < e820.nr_map; > - last = e820.map[i].addr + e820.map[i].size, i++ ) > + for ( i = 0; i < e820_map.nr_map; > + last = e820_map.map[i].addr + e820_map.map[i].size, i++ ) > { > - if ( (maddr + PAGE_SIZE) > last && maddr < e820.map[i].addr ) > + if ( (maddr + PAGE_SIZE) > last && maddr < e820_map.map[i].addr ) > type |= RAM_TYPE_UNKNOWN; > > - if ( (maddr + PAGE_SIZE) <= e820.map[i].addr || > - maddr >= (e820.map[i].addr + e820.map[i].size) ) > + if ( (maddr + PAGE_SIZE) <= e820_map.map[i].addr || > + maddr >= (e820_map.map[i].addr + e820_map.map[i].size) ) > continue; > > - switch ( e820.map[i].type ) > + switch ( e820_map.map[i].type ) > { > case E820_RAM: > type |= RAM_TYPE_CONVENTIONAL; > @@ -778,9 +779,9 @@ bool is_memory_hole(mfn_t start, mfn_t end) > unsigned long e = mfn_x(end); > unsigned int i; > > - for ( i = 0; i < e820.nr_map; i++ ) > + for ( i = 0; i < e820_map.nr_map; i++ ) > { > - const struct e820entry *entry = &e820.map[i]; > + const struct e820entry *entry = &e820_map.map[i]; > > if ( !entry->size ) > continue; > @@ -4763,16 +4764,16 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > > store = !guest_handle_is_null(ctxt.map.buffer); > > - if ( store && ctxt.map.nr_entries < e820.nr_map + 1 ) > + if ( store && ctxt.map.nr_entries < e820_map.nr_map + 1 ) > return -EINVAL; > > buffer = guest_handle_cast(ctxt.map.buffer, e820entry_t); > if ( store && !guest_handle_okay(buffer, ctxt.map.nr_entries) ) > return -EFAULT; > > - for ( i = 0, ctxt.n = 0, ctxt.s = 0; i < e820.nr_map; ++i, ++ctxt.n ) > + for ( i = 0, ctxt.n = 0, ctxt.s = 0; i < e820_map.nr_map; ++i, ++ctxt.n ) > { > - unsigned long s = PFN_DOWN(e820.map[i].addr); > + unsigned long s = PFN_DOWN(e820_map.map[i].addr); > > if ( s > ctxt.s ) > { > @@ -4786,12 +4787,12 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > } > if ( store ) > { > - if ( ctxt.map.nr_entries <= ctxt.n + (e820.nr_map - i) ) > + if ( ctxt.map.nr_entries <= ctxt.n + (e820_map.nr_map - i) ) > return -EINVAL; > - if ( __copy_to_guest_offset(buffer, ctxt.n, e820.map + i, 1) ) > + if ( __copy_to_guest_offset(buffer, ctxt.n, e820_map.map + i, 1) ) > return -EFAULT; > } > - ctxt.s = PFN_UP(e820.map[i].addr + e820.map[i].size); > + ctxt.s = PFN_UP(e820_map.map[i].addr + e820_map.map[i].size); > } > > if ( ctxt.s ) > diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c > index 4b0b297c7e..76827f5f32 100644 > --- a/xen/arch/x86/numa.c > +++ b/xen/arch/x86/numa.c > @@ -102,14 +102,14 @@ unsigned int __init arch_get_dma_bitsize(void) > > int __init arch_get_ram_range(unsigned int idx, paddr_t *start, paddr_t *end) > { > - if ( idx >= e820.nr_map ) > + if ( idx >= e820_map.nr_map ) > return -ENOENT; > > - if ( e820.map[idx].type != E820_RAM ) > + if ( e820_map.map[idx].type != E820_RAM ) > return -ENODATA; > > - *start = e820.map[idx].addr; > - *end = *start + e820.map[idx].size; > + *start = e820_map.map[idx].addr; > + *end = *start + e820_map.map[idx].size; > > return 0; > } > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index 80ae973d64..9c6003e374 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1163,7 +1163,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > } > else if ( efi_enabled(EFI_BOOT) ) > memmap_type = "EFI"; > - else if ( (e820_raw.nr_map = > + else if ( (e820_raw.nr_map = stray change > copy_bios_e820(e820_raw.map, > ARRAY_SIZE(e820_raw.map))) != 0 ) > { > @@ -1300,13 +1300,13 @@ void __init noreturn __start_xen(unsigned long mbi_p) > } > > /* Create a temporary copy of the E820 map. */ > - memcpy(&boot_e820, &e820, sizeof(e820)); > + memcpy(&boot_e820, &e820_map, sizeof(e820_map)); > > /* Early kexec reservation (explicit static start address). */ > nr_pages = 0; > - for ( i = 0; i < e820.nr_map; i++ ) > - if ( e820.map[i].type == E820_RAM ) > - nr_pages += e820.map[i].size >> PAGE_SHIFT; > + for ( i = 0; i < e820_map.nr_map; i++ ) > + if ( e820_map.map[i].type == E820_RAM ) > + nr_pages += e820_map.map[i].size >> PAGE_SHIFT; > set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); > kexec_reserve_area(&boot_e820); > > @@ -1631,7 +1631,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > unsigned long e = min(s + PFN_UP(kexec_crash_area.size), > PFN_UP(__pa(HYPERVISOR_VIRT_END - 1))); > > - if ( e > s ) > + if ( e > s ) stray change > map_pages_to_xen((unsigned long)__va(kexec_crash_area.start), > _mfn(s), e - s, PAGE_HYPERVISOR); > } > @@ -1677,9 +1677,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) > PAGE_HYPERVISOR_RO); > > nr_pages = 0; > - for ( i = 0; i < e820.nr_map; i++ ) > - if ( e820.map[i].type == E820_RAM ) > - nr_pages += e820.map[i].size >> PAGE_SHIFT; > + for ( i = 0; i < e820_map.nr_map; i++ ) > + if ( e820_map.map[i].type == E820_RAM ) > + nr_pages += e820_map.map[i].size >> PAGE_SHIFT; > printk("System RAM: %luMB (%lukB)\n", > nr_pages >> (20 - PAGE_SHIFT), > nr_pages << (PAGE_SHIFT - 10)); > @@ -1771,7 +1771,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, new_tlbflush_clock_period); > > - if ( opt_watchdog ) > + if ( opt_watchdog ) > nmi_watchdog = NMI_LOCAL_APIC; stray change > find_smp_config(); > @@ -1983,7 +1983,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > do_initcalls(); > > - if ( opt_watchdog ) > + if ( opt_watchdog ) > watchdog_setup(); stray change > if ( !tboot_protect_mem_regions() ) > diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c > index 3f70338e6e..bbd04978ae 100644 > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -301,11 +301,11 @@ void __init srat_parse_regions(paddr_t addr) > acpi_table_parse_srat(ACPI_SRAT_TYPE_MEMORY_AFFINITY, > srat_parse_region, 0); > > - for (mask = srat_region_mask, i = 0; mask && i < e820.nr_map; i++) { > - if (e820.map[i].type != E820_RAM) > + for (mask = srat_region_mask, i = 0; mask && i < e820_map.nr_map; i++) { > + if (e820_map.map[i].type != E820_RAM) > continue; > > - if (~mask & pdx_region_mask(e820.map[i].addr, e820.map[i].size)) > + if (~mask & pdx_region_mask(e820_map.map[i].addr, e820_map.map[i].size)) > mask = 0; > } > > diff --git a/xen/arch/x86/x86_64/mmconf-fam10h.c b/xen/arch/x86/x86_64/mmconf-fam10h.c > index a834ab3149..bbebf9219f 100644 > --- a/xen/arch/x86/x86_64/mmconf-fam10h.c > +++ b/xen/arch/x86/x86_64/mmconf-fam10h.c > @@ -135,7 +135,7 @@ static void __init get_fam10h_pci_mmconf_base(void) > return; > > out: > - if (e820_add_range(&e820, start, start + SIZE, E820_RESERVED)) > + if (e820_add_range(&e820_map, start, start + SIZE, E820_RESERVED)) > fam10h_pci_mmconf_base = start; > } > > diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c > index 3b577c9b39..7ad9e12b8a 100644 > --- a/xen/drivers/passthrough/amd/iommu_acpi.c > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c > @@ -418,7 +418,7 @@ static int __init parse_ivmd_block(const struct acpi_ivrs_memory *ivmd_block) > > if ( type == RAM_TYPE_UNKNOWN ) > { > - if ( e820_add_range(&e820, addr, addr + PAGE_SIZE, > + if ( e820_add_range(&e820_map, addr, addr + PAGE_SIZE, > E820_RESERVED) ) > continue; > AMD_IOMMU_ERROR("IVMD: page at %lx couldn't be reserved\n", > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:21:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:21:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577340.904409 (Exim 4.92) (envelope-from ) id 1qS2F6-0008Ue-2g; Fri, 04 Aug 2023 21:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577340.904409; Fri, 04 Aug 2023 21:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2F5-0008UX-V9; Fri, 04 Aug 2023 21:21:51 +0000 Received: by outflank-mailman (input) for mailman id 577340; Fri, 04 Aug 2023 21:21:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2F5-0008UP-F8 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:21:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec62e42a-330c-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 23:21:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 061086207D; Fri, 4 Aug 2023 21:21:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF9DEC433C8; Fri, 4 Aug 2023 21:21:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec62e42a-330c-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691184108; bh=KW+dAYsFmYRZpNCBqS8+Nd7VsnDq5S5U4dE0t27GoeM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ji7I91/qztWqbmX3JduBu6a8pN80q4HgdYWWR++/dYjem4TJpL6cAglwVutKsZ/cO 5MQDFOP+9Qxfpboj400PsnGoi3YxB0uP9j5/iBGkjaDmvns7e7hGIvnVmNpu6n1b6q IoMqu/Wn5DYcOvbN7ZuoF6eigIFza/fFFlkg5rr3F0EVvj3KtyUPHgpgb+flROxETJ xtwc/g1T5EMfIN0wWc/39oaInm88+l9HNr0Bq3gI7Mc8qkDMwlPjY5CxdVUQuMjvYj YcgvdSn+4VxgBsK8jhKU3R01EhDLekl3nmvGOXAnD+jYiV3BSEMsoSu/JGymJ03hj+ 8cT1O7h/O0P0g== Date: Fri, 4 Aug 2023 14:21:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 2/6] libelf: address MISRA C:2012 Rule 5.3 In-Reply-To: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> Message-ID: References: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h' > shadow the variables in the modified function, hence violating Rule 5.3. > Therefore, the rename takes care of the shadowing. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini > --- > xen/common/libelf/libelf-tools.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/xen/common/libelf/libelf-tools.c b/xen/common/libelf/libelf-tools.c > index a9edb6a8dc..f0d5da1abf 100644 > --- a/xen/common/libelf/libelf-tools.c > +++ b/xen/common/libelf/libelf-tools.c > @@ -91,10 +91,10 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base, > { > elf_ptrval ptrval = base + moreoffset; > bool need_swap = elf_swap(elf); > - const uint8_t *u8; > - const uint16_t *u16; > - const uint32_t *u32; > - const uint64_t *u64; > + const uint8_t *uint8; > + const uint16_t *uint16; > + const uint32_t *uint32; > + const uint64_t *uint64; > > if ( !elf_access_ok(elf, ptrval, size) ) > return 0; > @@ -102,17 +102,17 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base, > switch ( size ) > { > case 1: > - u8 = (const void*)ptrval; > - return *u8; > + uint8 = (const void*)ptrval; > + return *uint8; > case 2: > - u16 = (const void*)ptrval; > - return need_swap ? bswap_16(*u16) : *u16; > + uint16 = (const void*)ptrval; > + return need_swap ? bswap_16(*uint16) : *uint16; > case 4: > - u32 = (const void*)ptrval; > - return need_swap ? bswap_32(*u32) : *u32; > + uint32 = (const void*)ptrval; > + return need_swap ? bswap_32(*uint32) : *uint32; > case 8: > - u64 = (const void*)ptrval; > - return need_swap ? bswap_64(*u64) : *u64; > + uint64 = (const void*)ptrval; > + return need_swap ? bswap_64(*uint64) : *uint64; > default: > return 0; > } > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:23:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:23:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577343.904418 (Exim 4.92) (envelope-from ) id 1qS2Gf-0000dt-CF; Fri, 04 Aug 2023 21:23:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577343.904418; Fri, 04 Aug 2023 21:23:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Gf-0000dm-9g; Fri, 04 Aug 2023 21:23:29 +0000 Received: by outflank-mailman (input) for mailman id 577343; Fri, 04 Aug 2023 21:23:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Ge-0000dc-Oc for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:23:28 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25fcf4a0-330d-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 23:23:26 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AED59620AE; Fri, 4 Aug 2023 21:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C72AC433C8; Fri, 4 Aug 2023 21:23:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25fcf4a0-330d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691184205; bh=UdKLTfqblCjD85IT+yl6LbHf1z3bNJwVbW7ktIu2UA0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=izkCYWBT42tIibcusdX0lK374FJVVxnUxwHd+5On6qBatNTLqdqSMQN7AMSauA2FC pnlEeEToduxeBXAeaeNgRUu1z00XH5lKR5Up3nJ+nxE0dQ0uoSLrpVP1y+Q2Dw6Gwt eFVvKy4XdCoN8nwSMjHqJtYIXkxwYpbAHQFYVg+y4ixRiVKy0yrevwHJCOA8PdYm/j /bYpz3K9y92iZ2dtup2tjNMd/B6qYo4V7sR/360InkLpxbsuxBGjgtnDb0AVr6Imlg 6n0zrlNzAArEpUbKYS1zhYjAyWaPqw6zRJ8jTdoHOkH5onLhENt+GTY5MaZdy446P7 6RmCIW7y4aHbg== Date: Fri, 4 Aug 2023 14:23:22 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > The variable 'msec' shadows the local variable in > 'ehci_dbgp_bios_handoff', but to prevent any future clashes, the one in > the macro gains a suffix. > > No functional change. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:24:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577348.904429 (Exim 4.92) (envelope-from ) id 1qS2Hy-0001Ck-N4; Fri, 04 Aug 2023 21:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577348.904429; Fri, 04 Aug 2023 21:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Hy-0001Cd-JJ; Fri, 04 Aug 2023 21:24:50 +0000 Received: by outflank-mailman (input) for mailman id 577348; Fri, 04 Aug 2023 21:24:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Hx-0001CX-J4 for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:24:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56c27a8a-330d-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 23:24:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8AC40620AE; Fri, 4 Aug 2023 21:24:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 849BAC433C7; Fri, 4 Aug 2023 21:24:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56c27a8a-330d-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691184287; bh=3jc8Tl1pBILA3Kk15KkbYw1ZW5lrkn+/IBolYaQsCZo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=eNU5IF4X4xfMDqPI6FRs4eKig48aCUGtHprrR8Ez1FfHYBdW2ECjVffj50I8ivjZw iwfCKi7OGOshKAqh1/bsaHElDHlczOLYpPSqPNQxFIbdd/o4Jp/kGSbaNhtlOUloD9 bqAo18SvhAwnvSMGkMF4us3kXzK7sunwpxD1NEYYQlBt6dT0PsLMhJOx9DY4klI7sr BHhE65pFlsy0NlwPcqzFM+7b3zCHI46DlGYnfC/7tmtQDciwvHi7ZVCsl16RtRmQDT Dj0G2RFt99Ytqz3EjtKWCf4HteluKoMG8lYpu+ji7Ibx0m3EQnQ1VhVb3AWaIrAJIr zVJKlEem4fU8g== Date: Fri, 4 Aug 2023 14:24:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 4/6] x86/include: address MISRA C:2012 Rule 5.3. In-Reply-To: <40823fbaa9e0a9b026e5ff3b01af9d83583889fd.1691162261.git.nicola.vetrini@bugseng.com> Message-ID: References: <40823fbaa9e0a9b026e5ff3b01af9d83583889fd.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > s/mpc_default_type/mpc_default in 'xen/arch/x86/include/asm/mpspec.h' > to avoid clashing with function parameter names in 'mpparse.c'. > > No functional changes. > > Signed-off-by: Nicola Vetrini > --- > Even though the global variable does not seem to be used anywhere and is > perhaps better to remove it entirely. Please remove it > --- > xen/arch/x86/include/asm/mpspec.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h > index 1246eece0b..cc96ee63bd 100644 > --- a/xen/arch/x86/include/asm/mpspec.h > +++ b/xen/arch/x86/include/asm/mpspec.h > @@ -15,7 +15,7 @@ extern void get_smp_config (void); > extern unsigned char apic_version [MAX_APICS]; > extern int mp_irq_entries; > extern struct mpc_config_intsrc mp_irqs [MAX_IRQ_SOURCES]; > -extern int mpc_default_type; > +extern int mpc_default; > extern unsigned long mp_lapic_addr; > extern bool pic_mode; > > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:27:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:27:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577352.904438 (Exim 4.92) (envelope-from ) id 1qS2Jz-0001oZ-26; Fri, 04 Aug 2023 21:26:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577352.904438; Fri, 04 Aug 2023 21:26:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Jy-0001oS-VS; Fri, 04 Aug 2023 21:26:54 +0000 Received: by outflank-mailman (input) for mailman id 577352; Fri, 04 Aug 2023 21:26:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Jx-0001oM-3w for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:26:53 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9fa6038d-330d-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 23:26:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F64662117; Fri, 4 Aug 2023 21:26:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8708BC433C8; Fri, 4 Aug 2023 21:26:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fa6038d-330d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691184408; bh=nFwmOqD17s+/h0puhgViKWCxH+gDjmT1UKWq/VvIl7M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=L20NbbGhz7rdTNiTW7Ngt+zhACtWMMu4w+pgTg3qKNXsYqanWt7X/mE4fLAcVK3pE 19ruBu+zNaKhCSz0CCVBIQH3I1I2ay1Ons4GG4mgkbn7ZCDNThIFh34PMBOQGHSYUz HFhLAFj4mxFKH4n++Qf9bEVU20SbrA/UE5Dguo1tHsDyCTGL4S4QZURtFn1CG3rUgK SuWU3GT14qnUHimgn2oWJQRiU/V67udpcRKxdFSwLQ4y4Bi7dusTDFL32XsXA4ULY5 /heeCE7a0zNoMCd1PC0smssWVgNwNlgqqECwkwWIv12GwBs/sEN9cV1xX2Uo0J5Xdy umfg32m6MvW5Q== Date: Fri, 4 Aug 2023 14:26:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 5/6] x86/xstate: address MISRA C:2012 Rule 5.3 In-Reply-To: <1ea70e5f8293fdca2bb69ec75f532722136e52a5.1691162261.git.nicola.vetrini@bugseng.com> Message-ID: References: <1ea70e5f8293fdca2bb69ec75f532722136e52a5.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > Rename the local variables to avoid clashing with function 'xstate' > defined below, but declared in the corresponding header file. > > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:30:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577357.904449 (Exim 4.92) (envelope-from ) id 1qS2NH-0003H6-HE; Fri, 04 Aug 2023 21:30:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577357.904449; Fri, 04 Aug 2023 21:30:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2NH-0003Gz-EM; Fri, 04 Aug 2023 21:30:19 +0000 Received: by outflank-mailman (input) for mailman id 577357; Fri, 04 Aug 2023 21:30:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2NF-0003Gr-OX for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:30:17 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 191dc224-330e-11ee-8613-37d641c3527e; Fri, 04 Aug 2023 23:30:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 77681620DC; Fri, 4 Aug 2023 21:30:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EF8CC433C8; Fri, 4 Aug 2023 21:30:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 191dc224-330e-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691184612; bh=jE1feFZVsHIUi2jn8BB5TK5WmyVgoA8N7R50JfUrPfY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Q6XF5hlexnTSOJkXIov9xhowr3sjHUb8cX8tWYopB/qZctEtkbTZ44EXVfdxiU8jc fh0EP1+Z5aiNiL5XA+uy8pzI/5dLTxfvRv6MtOkNMWdwBiq5FIKkY6aaNR9TP+wY9v nq9aLB8aVPpBirl4iiYW8jHYIWxnLEo1U+oecFyQX8qA0dHAyTzrROaOerCUfHtcOd 2rPKtl3/yjS1Ztv0i9XxQEeU42vlFtQlfzFyBGfJf3pgfYjMikwwenc0qliMsqlIMi pRz9UwnUv9gof/7mfh906NRQrUFHv6oX8LcbII52lWMgfz9IApBk5H4We577JDQgrR c+ycrR3j9z7Dg== Date: Fri, 4 Aug 2023 14:30:10 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Nicola Vetrini cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 6/6] x86: refactor macros in 'xen-mca.h' to address MISRA C:2012 Rule 5.3 In-Reply-To: Message-ID: References: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 4 Aug 2023, Nicola Vetrini wrote: > > - _mic = x86_mcinfo_next(_mic); \ > > + mic_ = x86_mcinfo_next(mic_); \ > > } \ > > - (_ret) = found ? _mic : NULL; \ > > + (ret) = found_ ? mic_ : NULL; \ > > } while (0) > > > > > > -- > > 2.34.1 > > Stray blanks here, sorry. Aside from the stray blanks: Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 04 21:39:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 21:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577362.904459 (Exim 4.92) (envelope-from ) id 1qS2Vn-0003x9-CP; Fri, 04 Aug 2023 21:39:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577362.904459; Fri, 04 Aug 2023 21:39:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Vn-0003x2-8U; Fri, 04 Aug 2023 21:39:07 +0000 Received: by outflank-mailman (input) for mailman id 577362; Fri, 04 Aug 2023 21:39:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS2Vm-0003ww-WC for xen-devel@lists.xenproject.org; Fri, 04 Aug 2023 21:39:07 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 556ce9be-330f-11ee-b271-6b7b168915f2; Fri, 04 Aug 2023 23:39:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF99F62117; Fri, 4 Aug 2023 21:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D645C433C8; Fri, 4 Aug 2023 21:39:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 556ce9be-330f-11ee-b271-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691185143; bh=GvitZrETfuQTQcjj77blBRLxc8mSkNWAcqIOxy8tSGk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DTWK0Q1biByoVWr7BsZ8uhoR0SCFpuY6s2B+Ojd4urwkuqCR4Z5eVQhrcly8dwYAR G5OcVGvrFM93fN+wyRu3UmzEM8Bo1b4jOdpN0d47Z85CzgO3wXIjeF+l+1wLLyER4a LGxmCx14T+ByxmIWKnXJllVTjWoi+vIBbgN4VrlIX5HFHrdJQJ5OGOPjBX2RtLAy/7 CIIrQEYs2ErGO/ZM3RDXl6XhpS1U2NqZmQweDhjqTUWtoPPfuvu/OrdFX4NKhS9oqZ hQSF+Jms63aeaDuh1kc8MXa3jaB4vsaM2CKb8K0J2xfiEPCE8/+QdUURRqckNMtcXV abR2D1l9cq9rQ== Date: Fri, 4 Aug 2023 14:39:01 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: tamas@tklengyel.com cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Alexandru Isaila , Petre Pircalabu , federico.serafini@bugseng.com, sstabellini@kernel.org Subject: Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration In-Reply-To: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com> Message-ID: References: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Tamas, May I have your ack on this change? On Thu, 27 Jul 2023, Federico Serafini wrote: > Change parameter name in monitor_domctl() declaration for > consistency with the corresponding definition. > This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations > of an object or function shall use the same names and type qualifiers". > > No functional changes. > > Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini > --- > xen/include/xen/monitor.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h > index 6b17a93071..713d54f7c1 100644 > --- a/xen/include/xen/monitor.h > +++ b/xen/include/xen/monitor.h > @@ -27,7 +27,7 @@ > struct domain; > struct xen_domctl_monitor_op; > > -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op); > +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop); > void monitor_guest_request(void); > > int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req); > -- > 2.34.1 > > From xen-devel-bounces@lists.xenproject.org Fri Aug 04 22:29:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 04 Aug 2023 22:29:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577369.904471 (Exim 4.92) (envelope-from ) id 1qS3IG-00011c-M7; Fri, 04 Aug 2023 22:29:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577369.904471; Fri, 04 Aug 2023 22:29:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS3IG-00011V-JL; Fri, 04 Aug 2023 22:29:12 +0000 Received: by outflank-mailman (input) for mailman id 577369; Fri, 04 Aug 2023 22:29:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS3IE-00011J-Kz; Fri, 04 Aug 2023 22:29:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS3IE-0008SY-Gt; Fri, 04 Aug 2023 22:29:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS3IE-00007U-3l; Fri, 04 Aug 2023 22:29:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qS3IE-0007rI-1W; Fri, 04 Aug 2023 22:29:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jiYv/zXEarmXpIyGCuGZ9vZlBNrHA5jU49ckT5SIMKY=; b=KpFsX07g+T62IraWIeFw1sICnz vOmxlYa4wAL1SXoKfpRTnTEikWStPd6QO/8YDFsYgEKSpAooP6nWYz+0SxPKcBozlFRoj4eS8om6P 4WEj8AkWLWboUwUIaTeaHFUCJ7eVG3QWffZmgtGZbDhFxCLtOoLueM7/NTo4rw2zNN30=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182174: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a X-Osstest-Versions-That: xen=51588938e0cd0e02dbc1d6d8c697c577135ff666 From: osstest service owner Date: Fri, 04 Aug 2023 22:29:10 +0000 flight 182174 xen-unstable real [real] flight 182186 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182174/ http://logs.test-lab.xenproject.org/osstest/logs/182186/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 182128 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 182186-retest test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail pass in 182186-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 182128 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182128 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a baseline version: xen 51588938e0cd0e02dbc1d6d8c697c577135ff666 Last test of basis 182128 2023-08-02 18:03:55 Z 2 days Testing same since 182174 2023-08-04 01:17:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Khem Raj Nicola Vetrini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a Author: Julien Grall Date: Wed Aug 2 16:47:05 2023 +0100 xen/x86: Constify the vCPU parameter for expand_xsave_states() expand_xsave_states() is not meant to modify the vCPU. So the parameter can be const. Signed-off-by: Julien Grall Acked-by: Jan Beulich commit 1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 Author: Jan Beulich Date: Thu Aug 3 17:35:39 2023 +0200 libxl: allow building with old gcc again We can't use initializers of unnamed struct/union members just yet. Fixes: d638fe233cb3 ("libxl: use the cpuid feature names from cpufeatureset.h") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Acked-by: Andrew Cooper commit 4f6afde88be3e8960eb311d16ac41d44ab71ed10 Author: Jan Beulich Date: Thu Aug 3 17:35:26 2023 +0200 libxl: avoid shadowing of index() Because of -Wshadow the build otherwise fails with old enough glibc. While there also obey line length limits for msr_add(). Fixes: 6d21cedbaa34 ("libxl: add support for parsing MSR features") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Acked-by: Andrew Cooper commit dfc490a3740bb7d6889939934afadcb58891fbce Author: Khem Raj Date: Tue Aug 1 10:49:30 2023 -0700 arm: Avoid using solaris syntax for .section directive Assembler from binutils 2.41 will rejects ([1], [2]) the following syntax .section "name", #alloc for any other any target other than ELF SPARC. This means we can't use it in the Arm code. So switch to the GNU syntax .section name [, "flags"[, @type]] [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 [2] https://sourceware.org/binutils/docs-2.41/as.html#Section Signed-off-by: Khem Raj Reviewed-by: Michal Orzel [jgrall: Reword commit message] Acked-by: Julien Grall commit da55d9dc919752e092e591a74ab54c2f7d5adfab Author: Andrew Cooper Date: Wed Aug 2 13:44:30 2023 +0100 x86/gen-cpuid: Avoid violations of Misra rule 1.3 Add the script to the X86 section in ./MAINTAINERS. Structures or unions without any named members aren't liked by Misra (nor the C standard). Avoid emitting such for leaves without any known bits. The placeholders are affected similarly, but are only visible to MISRA in the middle of a patch series adding a new leaf. The absence of a name was intentional as these defines need to not duplicate names. As that's not deemed acceptable any more, move placeholder processing into the main loop and append the the word number to generate unique names. $ diff cpuid-autogen-{before,after}.h @@ -1034,7 +1034,7 @@ bool intel_psfd:1, ipred_ctrl:1, rrsba_ctrl:1, ddp_ctrl:1, ... #define CPUID_BITFIELD_14 \$ - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... + uint32_t _placeholder_14 #define CPUID_BITFIELD_15 \$ bool :1, :1, :1, :1, avx_vnni_int8:1, avx_ne_convert:1, :1, ... @@ -1043,19 +1043,19 @@ bool rdcl_no:1, eibrs:1, rsba:1, skip_l1dfl:1, intel_ssb_no:1, ... #define CPUID_BITFIELD_17 \$ - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... + uint32_t _placeholder_17 #define CPUID_BITFIELD_18 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_18 #define CPUID_BITFIELD_19 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_19 #define CPUID_BITFIELD_20 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_20 #define CPUID_BITFIELD_21 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_21 #endif /* __XEN_X86__FEATURESET_DATA__ */ No functional change. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 73aea9ada87f804f6b56efda13aead3b950f8657 Author: Andrew Cooper Date: Fri Jul 28 20:27:01 2023 +0100 x86: Delete str() This is used in an assertion only, which is somewhat dubious to begin with and isn't expected to surivive the x86-S work (where TR is expected to become become be a NUL selector). Delete it now. This avoids many cases where as a global symbol, it shadows local string variables. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Tested-by: Nicola Vetrini commit abe93fc8aafaecabb2ffbad1b29f049ca02ab8cb Author: Andrew Cooper Date: Fri Feb 17 14:10:58 2023 +0000 x86/entry: Rename the exception entrypoints This makes the names match the architectural short names that we use elsewhere. This avoids 'debug' in particular from being a global symbol shadowed by many local parameter names. Remove the DECLARE_TRAP_HANDLER{,_CONST}() infrastructure. Only NMI/#MC are referenced externally (and NMI will cease to be soon, as part of adding FRED support). Move the entrypoint declarations into the respective traps.c where they're used, rather than keeping them visible across ~all of Xen. Drop the long-stale comment at the top of init_idt_traps(). It's mostly discussing a 32bit Xen, and bogus otherwise as it's impossible to use trap gates correctly for these purposes. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Tested-by: Nicola Vetrini commit 26638cd9efaea4fea3322914efc2611981e001fe Author: Andrew Cooper Date: Fri Feb 17 23:06:37 2023 +0000 x86/traps: Move do_general_protection() earlier ... in order to clean up the declarations without needing to forward declare it for handle_gdt_ldt_mapping_fault() No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Aug 05 00:45:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 00:45:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577380.904490 (Exim 4.92) (envelope-from ) id 1qS5QG-0000cK-Uf; Sat, 05 Aug 2023 00:45:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577380.904490; Sat, 05 Aug 2023 00:45:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS5QG-0000cD-Rr; Sat, 05 Aug 2023 00:45:36 +0000 Received: by outflank-mailman (input) for mailman id 577380; Sat, 05 Aug 2023 00:45:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS5QF-0000c7-Px for xen-devel@lists.xenproject.org; Sat, 05 Aug 2023 00:45:35 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20600.outbound.protection.outlook.com [2a01:111:f400:7e1b::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62817c2d-3329-11ee-b273-6b7b168915f2; Sat, 05 Aug 2023 02:45:34 +0200 (CEST) Received: from PA4PR04MB9487.eurprd04.prod.outlook.com (2603:10a6:102:27c::19) by PAXPR04MB8766.eurprd04.prod.outlook.com (2603:10a6:102:20d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.22; Sat, 5 Aug 2023 00:45:31 +0000 Received: from PA4PR04MB9487.eurprd04.prod.outlook.com ([fe80::88a3:6384:ff03:fe99]) by PA4PR04MB9487.eurprd04.prod.outlook.com ([fe80::88a3:6384:ff03:fe99%3]) with mapi id 15.20.6652.022; Sat, 5 Aug 2023 00:45:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62817c2d-3329-11ee-b273-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=METKH4gGztuzDBlIXwzbE2q51AFfcallV7LTNxZDuYqEJvFSDWNdSyBlcXk3DaCSxGUtnoOAKrKKj6ibLvQ9/fMSeCbx4RcGZF6G64JciqpkpUkozdlbmBJbTodq2PPUf3lM6oYfsnOE9Fa0FAp/VuIeHcAPyNk3b3rB60Ldj4+nUP2FO+j8dzC3+bs36RYJd3kdd453GsChJJ9zeJ+VCB9aeRYbzojjmMIRbjk9m51RRNrP87q94VQqf7heaiJ5XRxGRnwQDPcret2Tp2qlrX+4btuGrMjTjrumSOYlWEtnVTkCaEcG+oM42SX7GQLmk+fZSmRQ3wDVcXlEStrsXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zio1McbN4iYMuQrjGhQ8+83QINdgWRMixhCYYFsE2iI=; b=FeJOiV3QRXovkUwwJraaG7xZG4HPpmtBGe96WXLwMWVQHnpIz7r8RJJ7b7oH1gIeu7fXpIWWnzTXejtzS6PzNgiwxXJpQMh7ZsASL3UbtgdTQiUxvcqD9EfPyhnG8epVbLxcipYf9hX1qBHX7IzSzOwJ8kJ6mWKYtZc+Tsdk23RaiIvtEpYMnbduCmEmvc1CNXNcATy/JAqmzr+yHvYG+youirOS2anlJarCt0iBNapSfKxH/YBiVSsunTHaxlSgHuRsoGQdCaiVNnnP9PEGa3amihpFg+exgi00ycIzKupLqCP6FR8WSoe9bTZGB108KQsvFIvDW/VKSMdn/+Z0hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zio1McbN4iYMuQrjGhQ8+83QINdgWRMixhCYYFsE2iI=; b=0tVqf+yrNuWBQqp0NhqTdRNU50dScPSTccyGpL9ZjoQctMtKgvInv9aK+Imxg8WtL/dacsDbToMLpk7xFRTy10HvUPt8Lx7Xb/u/TijTwuSKsMMH6iGHeVUkrqvObZu2jkuX2uLltDic7GXnDNkkHsS+UyqVxZyd0xAhfOjWU2Y/VjimpxeXShUgV/7AUJDDrPap8cqS5w7bezCzvfKeCKH+Kgkd4z1La6jaNGgnNTAtHeyfe+x2PfoTAx54kXdObFcdcefmO7o7d+ak5lUbtZQsIvG3gDdnrnM49JtPC2rEVxM+IVFMBhKhe52hvYwdKDjZhNcrA9qAmVkdutomTQ== From: Dario Faggioli To: "sstabellini@kernel.org" , "george.dunlap@cloud.com" , "george.dunlap@citrix.com" CC: Jan Beulich , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "wl@xen.org" , "nicola.vetrini@bugseng.com" , "consulting@bugseng.com" , "ayan.kumar.halder@amd.com" , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" , "julien@xen.org" Subject: Re: ack needed [XEN PATCH v3] xen/sched: mechanical renaming to address MISRA C:2012 Rule 5.3 Thread-Topic: ack needed [XEN PATCH v3] xen/sched: mechanical renaming to address MISRA C:2012 Rule 5.3 Thread-Index: AQHZwVAxe/bY3KKiHEuQMuUyHr1XI6/P0d4AgASauwCABn0JgA== Date: Sat, 5 Aug 2023 00:45:30 +0000 Message-ID: <188b4b7611364397ba0f0cf9406bd4ef9ad9cf30.camel@suse.com> References: <12a21bfd59d85c7b8619631edac93d79d7225c60.1690547599.git.nicola.vetrini@bugseng.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Evolution 3.48.4 (by Flathub.org) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR04MB9487:EE_|PAXPR04MB8766:EE_ x-ms-office365-filtering-correlation-id: 3c1608f3-390f-433f-3b72-08db954d44ec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C3HMcaLD4+b82tLrCypesx/frRtpnMaGzQ1b14OfkSzgfIQ6oR/qqU7i00cqJlNFjbYz9Wg4z04b4AeWU4h30j8snKGNxKxpbDLgSMA9DxjfGgd6J/O2605fl1CQevK6cYPNWyYjooFn5qurK4iyGaw4x/bt34dEUC/4s+8hVOcTZXk5jcDaEAKoB66X8KiscVAL7pvptQvBwJyqswCdb3v0VXu0m+UQdOShXezXCXqEy/qU8XXwMN6Av6G8Sl1kUbB3PB5AdCfRZFPKI8dioD3hLi0AJTzyPsi720X/uYUM9Qi28bbz8TCJ1zQCa3kQbGgov3MaOi+bXlOa2I9MuGxZi356vSKU9aP99J/2Wa/1LM6tmEEj4PM+uVYsRID6mr5taNtAt2KiFXYnyJqAOW6/051MhY62CCdlv8UOVLK7+W8J6tuVNXNNkrLfTS1MLv21qsCrilxlcTNZLvXECtzPvvZwxgal/Zr2u1Ft4GpYdA/5sQHVqnpHdCV+pINMeBWCRGrWZJXyRGsKBcWtfzpHkLUoP5jeaDFL9ndxURnauTb2QchwfakWqfc5k1CVrE2EUpU+6A6n4mHouqWDzbJ1oim031N0Br8notzkq9Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9487.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(376002)(346002)(366004)(39860400002)(1800799003)(451199021)(186006)(8676002)(38070700005)(5660300002)(8936002)(4744005)(7416002)(66476007)(66556008)(66446008)(64756008)(316002)(41300700001)(4326008)(26005)(86362001)(6506007)(2906002)(54906003)(110136005)(122000001)(478600001)(38100700002)(6512007)(6486002)(966005)(91956017)(66946007)(76116006)(71200400001)(36756003)(99936003)(2616005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UjB3QXZ0L1ZRUzlXQ3VQNE42bDZXUjg3S2M4OGsvNlZ4K1NQSHgyaDdCdGYv?= =?utf-8?B?L0FmQUwwQ2F0eFcvMUpKQ1ZiNEdhTHF2c21oNnNsQXQxSXkxQW5IaGoyVmNr?= =?utf-8?B?Yy9JUW04QXYxbEJlNW8zRHgyMEJrc3l6TlJxTmFsdWRzeXBlejJzT1BzUFZU?= =?utf-8?B?TEVDWE12b1Y1V2NlQnBQS2w0alBzd1ZWVVU4L2V2Q01WaWo4bEQyWndKcG82?= =?utf-8?B?WjcrNVJDRmFiZXMyUkpDK0RZUnNSUklsL0hjZmJHUjVXYVdzSnk5UTl3Q3Ns?= =?utf-8?B?QVB3Q3RKaE1RT3BRZllmZzl0TnJRVGFOUThOY0w5TWJXOC9vRk5IS3ZrYnYv?= =?utf-8?B?S2NlY3hCSmFITFNVOVJBMll4T1VTNnBvTW93SzJMR1F0SEx4aTQvNllMYmdG?= =?utf-8?B?bDZCazluaFY5RHVtNXRqSExrOE9Bd1lOSUhDUERJQ09KNThKdEQ1NGxPOVRz?= =?utf-8?B?UWdiQVZoZzdtNUtSblV1T0Y0TXRKS3NYbHMyRjcxQXJ3SnI4Y1J0bVNCYVZE?= =?utf-8?B?NWp6RWJlTkRsZTcyYnFNV29FeDdrV1NOZDVqTGtpVUd0RUs0SHFPVHJncGRT?= =?utf-8?B?UDBzQTJsM2J4Tm8yOGgzSkJFUWZCRkwxTHpPZU42b1Y4Zm5xdHFadFhsQ0dV?= =?utf-8?B?ZGJkOTMyUHJ5YTd3MmU5Y0J1WFFiNzNwQUVGOGJwQ05OcnBqUlZiK1gzVVpt?= =?utf-8?B?NU1pcWY0OUt1ZkpkZ2FGWTNZSzhSSnZHeTQ5RG1QUkFwTE8vNCtMdm5OUkNI?= =?utf-8?B?cHQ5NkE1WStET1NoYXNVUmZpZDlYc1BaKzVSQzFKZXlDclhNV0FqWVBKaXJ2?= =?utf-8?B?cmRRbGpkd2hIT2YrOG05dVpoZ0xuaGRXMmJRZDBsTWtjQTRUWWxOK2xTa2w1?= =?utf-8?B?dEVrRGhYM1lubWVtSEFraHFjaVR4OHliOUZsVUU4MGhZZE9qTW9lWm1vU1Zr?= =?utf-8?B?TXNtaitPUUJQT2dldS9zTW1YeFJPc3dMYWI2enZrZ2NncTIrdUtOWGFqdmdE?= =?utf-8?B?b2xOTXZteFk1bWl2OG9TdWZzaWJvRXp3akFjZFdhZWRyNXNxL1VXTWdxWDdP?= =?utf-8?B?T3Mrc1Y1bGpiSDFTalZLZy9HcC9YSVhKaVF4YktTR09qYTNvNHFCUlJhTmpH?= =?utf-8?B?dnZIbTY0SjVBVzI0RFJPUVRBZXNaa1J5NlY1M1VldkswQjFWa0FWbVR3YmlD?= =?utf-8?B?VVpYZHN1RW9TVC90MkMwNXcwTDd4cVNaYXA5T1ZpT2lQZlVQWCtTeUs3Vy9u?= =?utf-8?B?eE5RVEU5Y0VDWHBGekhKVnlSSVd1WnozNHNCSlRYMm80Z3F0MjA5SXQyVFFJ?= =?utf-8?B?WFo2eU9kRENPbDhMdzlMcHRpdzZzL0ZCbW5sT3RoM0NXZFpwdzdVc255MFBJ?= =?utf-8?B?TVVRc2d3Wjh4WG54c1NVMDExUHlqYWMrS3QyZXRndlpCTGcvMkN5RTFmVnVl?= =?utf-8?B?aGVjaTZPcTlPV1l4UHhkTGpjN1k0Y1RFTklndzgrSFpCY0F1RS9HOHl3TXR6?= =?utf-8?B?MFAzVjM3UDhKME45cGlBUko2eW9qNjd2dVBrbkc5WVhZU3YrWHRKR0FZT2Zz?= =?utf-8?B?QWp6QzdQc2FyYUNVdUlsRllYZ2RRUU1sWUpwZG4zZllIOW9nWGFzeFloK2R4?= =?utf-8?B?OHAwK09EU1BUTGR5NzVpVEFrazYxWUdXWjFFbCs2eTQzZjFXREJxaVNQR2RC?= =?utf-8?B?TDQralFHeDRoSkNzdVFSNWE3Qkp1aFBCSExBV1hGbzVueWxQeGZQMHljSmli?= =?utf-8?B?eVlQbFNub1JyV3BudGFKdjIrUG1TYllXbHRIUGEzS0pYRzhCRytXZWRJSi94?= =?utf-8?B?eVExbDc5U2VFejZveVJvNlEweUxXaHdlalBScVNxQjdqa0I1MnFQbWNlNjUr?= =?utf-8?B?ZmEyYVNDTHRVbHZydEZ6OEpZbDFYNm9GRkd1SmtBTWRJV2N5bE8xcDRuSnJi?= =?utf-8?B?dTVhSVJoYXBQSjR4N0VSb2lOblRnVVFNNVMzVjYxMG10cWxIWmN2MW0yUFZi?= =?utf-8?B?M0RhT3BjL2tRM1AydXR3ZStwSzVyQXJIVXhNc3JKL05VSFExNHBUU2tHUGpj?= =?utf-8?B?UEVpMDRHVWd0bHVvc0VRZG54Q2VGUUtBVE16V0k3ZWlZL2tURnBsdjhZeEx0?= =?utf-8?Q?T0DS1wnB5uZUJTLP47XbuvBiL?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QIyvlgfvdOhGq2L9HZ27" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9487.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c1608f3-390f-433f-3b72-08db954d44ec X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2023 00:45:30.4074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +GEThrEQS7RpZxtKgDVkXJYtHzDTGJrQucU+zLOHHUxWuBFG8JHnhFW6y9NTt+YrYdB27+8BCssWpXHcmzOoWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8766 --=-QIyvlgfvdOhGq2L9HZ27 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-07-31 at 14:40 -0700, Stefano Stabellini wrote: > George, Dario, >=20 > Please ack >=20 Looks good to me. Acked-by: Dario Faggioli Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-QIyvlgfvdOhGq2L9HZ27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmTNm6kACgkQFkJ4iaW4 c+7C4hAAmbfp3o6m7pMSe4gduvCpm8tUoTPaI+TPqNis17eNO2w/GlEoS9Rxpjjq 9SkEwmLFNJ8rSPm7oa1foJ41m5BNt+S5etnNbd0unJPVXkazHZtnwOhE2oH3l1Nn fge4juk3Abnwd63JZzlC4wCvMSfAWn5YP5vvp0sPmIYOsB4wjGeF69nI9RqTlGeW AnN5nK3uKVjh+BWxzKhLpU6xd/0kZ4SpAw3sglfINgggg8C6JwOSyfgJXG9VgYgK M75KhbgPBuD4YY6ihJeVRLAplBSvdkqzisjf6lmp2KeCFjQhUsVH76SK/mk27BwO AH6ACWLxF/SG3lNsQzrBpb/G6kM1XhbQG/YQJwtmxVROBkux5ye5BRXSPURAc6Gm v9eTi/kFu2WpNtR/e1pTa5z0NNZdseWLz4+W8LVOi6n92pkpXfNalds2H9esreUV q/0l8DM22UcRICDEyn1jV/JGhRW8RlY2ouocccivzdgJxcRJYoKTCgCu2+1eE2kg 2u54GRaiGaj4tHNYT5OAGtMhWd35RjFUjbUz+8UtN8av0YEJOVMB/oRbwzC2fqsm MCqJs/kISEDVJFZhAnLHtZNGs8asz6/8F/zt5klFzWthdGf9yOPzQ8CIeXSPENpQ MuV4DNLIOAYq/piOPow3OtG1QUAEozitn64oCXjhd1jhBIMy6tw= =c+qT -----END PGP SIGNATURE----- --=-QIyvlgfvdOhGq2L9HZ27-- From xen-devel-bounces@lists.xenproject.org Sat Aug 05 00:47:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 00:47:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577383.904501 (Exim 4.92) (envelope-from ) id 1qS5SB-00019m-B4; Sat, 05 Aug 2023 00:47:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577383.904501; Sat, 05 Aug 2023 00:47:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS5SB-00019f-6g; Sat, 05 Aug 2023 00:47:35 +0000 Received: by outflank-mailman (input) for mailman id 577383; Sat, 05 Aug 2023 00:47:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS5S9-00019V-W8 for xen-devel@lists.xenproject.org; Sat, 05 Aug 2023 00:47:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1b::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a8afb243-3329-11ee-8613-37d641c3527e; Sat, 05 Aug 2023 02:47:31 +0200 (CEST) Received: from PA4PR04MB9487.eurprd04.prod.outlook.com (2603:10a6:102:27c::19) by PAXPR04MB8766.eurprd04.prod.outlook.com (2603:10a6:102:20d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.22; Sat, 5 Aug 2023 00:47:29 +0000 Received: from PA4PR04MB9487.eurprd04.prod.outlook.com ([fe80::88a3:6384:ff03:fe99]) by PA4PR04MB9487.eurprd04.prod.outlook.com ([fe80::88a3:6384:ff03:fe99%3]) with mapi id 15.20.6652.022; Sat, 5 Aug 2023 00:47:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8afb243-3329-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mez3sUVmjJD3FH71QrFU4arTgJVOown5JJcczk+2AEH3DdcxvDhegWjFWvivO4WcgmGf1LvVNk6Thvyo54mY9DKISZjSg7z9gqJFS4c6TYkZ8XpLqA6iEyWHY3EqstxQvJi3mZQR7Oe165LVaqhff7o6FUKwbW9DQbC3ucGaTFw2+35loaEnv0dM0PyBiYMsmZshq/hUamfFfO4K393fS+6TD1DwVNo1fUn58EnhjrXMuCFjA5AtDGi1EXR0sFj/xZnhLJxbQWO2ULqo4vkOt0bqBMNKe7RKXp65ad8bBmoVbqTZXPJGv9YxtZNoHpKtZ2JWdZp3aPsExCWLBwqKWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHKH1iA1i06D2UfjBIcSDKgRCsJYPHX8MXaxpn0OQ/E=; b=MK5NH5cdacK4hKI2N+LlSMwvx0VOUb5vFF+bnZ8Joal4BnlV69fkPBVQJbWBz3rR2MbZCPRBCJEHFAHM0PELhbqKNHxpbG8XcwqHA/E51jgvvz2QGclE0DLeSOxpPChI9xv10YN/emEwh1JubYs1v0SRpH6MvxkiXZxXCqqTF6X3bOGeZ4Jf6TpSHrvMCLCMbXtIhEh6v6W1uMnRG8EK9xqRwEwWF6DemPgvUcCSAeYPoQZW5hb5KWUVOSgg0due4LCbLJ519+z5mMDLGD1Mrtno7nBm4pFExBKNKYPdjrCnLuGKq3jDnHghy79Wu84hoRbtK+k5DOVxcvTR5goqVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHKH1iA1i06D2UfjBIcSDKgRCsJYPHX8MXaxpn0OQ/E=; b=dmEwenPQE3qyEunUjCgzYpUW3z2kd9FUJ6s+QVU6z93XbxLRybuLuSScKSBO+6QjHCP38wtnAxPkQCpU183WpmKucAVdUijGapNpv0PKKgSYOi41UJaokLAwvk3ZMYPNJX0fQ3wdgzQ0i1FBWvEJ5AyxPmZZXdGm7wlXFSiqA6MtWerPgS+Bdy6+frzQ1sTvYmXgvQ9wXY6jJkFVN5YTsGPkCv2J58P4+IuWmpGod5qEp2eozVOlvQhDR91P5GoJztZLsoQt8d2Zn/sDF9Pm6Hmivx06l4zIElUZzTdSKCaHuz6kxKVzXxXa+ydZr5Q/bEjvAargzDjTRwUXlzIb7w== From: Dario Faggioli To: "sstabellini@kernel.org" , "federico.serafini@bugseng.com" CC: "julien@xen.org" , "wl@xen.org" , "consulting@bugseng.com" , Jan Beulich , "george.dunlap@citrix.com" , "xen-devel@lists.xenproject.org" , "andrew.cooper3@citrix.com" Subject: Re: [XEN PATCH] xen/sched: address violations of MISRA C:2012 Rules 8.2 and 8.3 Thread-Topic: [XEN PATCH] xen/sched: address violations of MISRA C:2012 Rules 8.2 and 8.3 Thread-Index: AQHZw6cMDaRGuf0brk+fvTV6KSueEa/UY5qAgAaB6AA= Date: Sat, 5 Aug 2023 00:47:29 +0000 Message-ID: References: <072d163857101f4cdaf61b6336b2d8f2e65d7360.1690800014.git.federico.serafini@bugseng.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: user-agent: Evolution 3.48.4 (by Flathub.org) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR04MB9487:EE_|PAXPR04MB8766:EE_ x-ms-office365-filtering-correlation-id: 3f157902-2050-4098-52df-08db954d8be3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mwKcEc/NpI/RXxrrj/rUVpOSaBUrGn0FhHhyGIg95lLJM2ncjU1M/8/JANAlzwkIgVW3F0aUvoVBXE5lUdWyq2cAnCXNIsK9hNMLRgyl7zy2qZW9ghZWyS+Lx3p+C2hHBvE4PrXyVxt7k1tYd8BeMBy28P+LaITWuRRZHwKertB/xUswzFWuC8EEANzEocujvUMNbYcbeleClpJ42z1Z+iWLnm+T2jrnzN7xsSKwQ01sWBFbC4CmZW8OqPVZ4PQXm0geAOIT0FzK9hIZpiX37el1yZfrtDxMkxpgLSVbWtnlHq2m4l5q0JKKRmOZcXjEXlXQluzku0yo48kOxYszW+hqQmHyBoXxRfCMT57uKpMPVUCxYeRWPxX+QWsIhlHfAmkoTHTw5AcaVnqL8PTsFIP3NPdj3cI22DtRpYcfsV6Xovey3ndfeW/TJ2/vIpREuXliHxMzVBWTIkI0iRZwGOGKGydgmx5+wZIjreGwseXtqSyqu84vogesXpZjrO96QlIz3aFppLBePxvseIlcazjb2US0OZPQIJwX2lwN/8T8hsrAmF9AIFbo8l4I80c42y21nYoBTJJeO2tCxf+rAB1Pc7G4XSEkiNHGI+j9GLM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB9487.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(376002)(396003)(136003)(366004)(186006)(451199021)(1800799003)(2616005)(71200400001)(76116006)(91956017)(66946007)(99936003)(36756003)(26005)(86362001)(6506007)(4326008)(41300700001)(2906002)(4744005)(8676002)(38070700005)(5660300002)(8936002)(66476007)(66556008)(66446008)(64756008)(316002)(6512007)(38100700002)(6486002)(966005)(54906003)(122000001)(478600001)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K00ydGZaanJ3Ulp0a09oYmtPa0l5STdzdk8vUEdveTlaU2MxTkh3d3Boelc4?= =?utf-8?B?WmVFOTYvUlhnWE9uWlJZaGRZb2k3ZmhRZ1Nyb3oyRTdZRXJVSGtwNnJpTkwv?= =?utf-8?B?N1VHelkvdHlFUnpQNEIvaWFlN0Z4MWNZb0xFVHRFWlFpdDczc0t4dWNwNVZJ?= =?utf-8?B?dmdxbkNGSXNpTVpGS21hR0d0SUJPUlN6UnUxNm5NL1lDSkdqZEJvNzV3TkFn?= =?utf-8?B?eUNYSmxhcGMyZEI5eG1uWldyODdaYVgySXRtNVEwK0w3UkxUcXc2Vy9TNkdh?= =?utf-8?B?RjdqUHF1QWR6MENxbFFLOUkzZnRvQWtJcGNkWXJnYWUwT3lOWXJJV1lRMTlj?= =?utf-8?B?Q2kxUTdGekVEUGhsbjVvblJaTmJ0ME5hVVN5UlV0RzAvYnVjY2xZSlJFMGlp?= =?utf-8?B?cFpLUXYvcHg4TXVTcUdUeG5mSGE3VUZyUmNxZmdIa0xZM2xFbll2VURVRW5r?= =?utf-8?B?dW00ek9Xc3J1VDFDV0djSnBaYVBHM1ZqRFl6UmZ5VG1jZjA1UURpTmkzZFhz?= =?utf-8?B?RW1STzNrWUp3RE9vQjBPMmtGckJheTlZb05XNHFOT3hWVlJuaGxoT1VFeTVB?= =?utf-8?B?Z0VWOGZXdG9NbENNRXZVYkVHN3Zpd0V2Z3p2bU5kNEZsaFRxUW9zdnhJNkpj?= =?utf-8?B?STVZb1Z1R2phazFpRWZPMkFobDEvZkdTc3ZlbTdLRW1jdDBrTDZhNFVxQmdm?= =?utf-8?B?TVp5ZTNTL3JZaFJPaG1CMmVLWkVkeUJCQzQ1cTg0dDFlK1JQR21wTkJsTkFu?= =?utf-8?B?UnNIN2k5eFJCYittWXFPL2tWTVJKSmdMenNReEN0UzZHY0hSNFgwZ0ppQ2Nj?= =?utf-8?B?VU55OXVQUlQ0T3Z4NlJMWnBqYVZtbGg3ejVncEhwOWxqcFJwUzF6c1hoRU1q?= =?utf-8?B?NE1oVnVpazJ5QldVeWo2S1hnc1VXdlVBaytnYlpERkVQbno4Smowa1cybWg1?= =?utf-8?B?OUZwMXZPekZWZllDc0JvZ21mNXZwdVJoVEtrTTAwQlpFMGZOcTBSazNvcUFL?= =?utf-8?B?OFRjdHZzeEIwYWs0QVJPRTJqRHVXN215dE96SlFMVWJwM2s5T2hlU00yUlpE?= =?utf-8?B?MkoyWStZR1RjMnVnK3N1K0hvOE92RXorZWw1NU9FVzdDQUNPRExDTDZQZE5m?= =?utf-8?B?SzRXNzVzdFMzK2NjcE1XVGJiaTg3U0gzWnVXNWdKN1duaC9EdE1pKzcrVjVj?= =?utf-8?B?bEZjUnRYUU9uOFNDbWduWDkwZ1JDbjROMEw3aDZiYUhSbXVwT3ZTajVUTGtO?= =?utf-8?B?bUlRVUlPZGMrTGoyWGliSnZxendLdzEvOEpZU1ZRa2hHbS9mRUcrSEkvYzhx?= =?utf-8?B?NFBzbTd6TWMydTdoRktDdkhLUEFkalRoOHU3bnlmdStvclFFY1NEaG5KUkVl?= =?utf-8?B?anBSS0VuaS8wTXhyM0hMdXA4cTNJMGF3WUxOZkhIaTYwbElIbDFXUnJyVDhL?= =?utf-8?B?NzBibVNOa1pTZ3VRTUJiZExsQVZmNksrWnpaaS9aUis1c2s4MGhZUk1GTlBv?= =?utf-8?B?M1FwL2ZlV05CWTZpeFcwc3VVNHZySExyc3IyV2s3UlJHU0p1OW5tNFcvNWF2?= =?utf-8?B?b3F5TzdpVEczcGtJZ0dhazljWE5wN3l0d0FBQ3dZZ0p5bnhaQ2ViVFZYL1BG?= =?utf-8?B?cXlkYUVGU2N0NFZsWFhLeEE3OWtKelpaMk9xeGs0NS9KMmUwQ2FXaEVNS3Uy?= =?utf-8?B?ZENJdVFiZnMvNjZEN2I0UHhhWm9wZG44eFVtRnBjR3ZkNkZ6d2ZnbVdnK3VP?= =?utf-8?B?RFFaYjZ1SjJ1MklNRGVON0Z6VllDU2dtdGZTd1ZHa1lHQ1huZHJDakN5eU44?= =?utf-8?B?Ri8wcUdZc0kyQ29raWFjWnRXQm5na2ZIZEdzR3VXN25LK3lMTk5qNjFqNWc3?= =?utf-8?B?Sm9zS2wzR1VkeHF3dDRzclJBa1JzOFVnZVdBSGREdGw4QTRnWnc3Qk9tVFhx?= =?utf-8?B?MmpjcEVFYzBaU051UC9QLzBILzc4Sk1MMEtqY2xMbXQ2MXRQRXk0QkY2N2dy?= =?utf-8?B?QjRud2I3bDFhU2dUQ1BoVkxSYTdoZ2w1NG9SRjlGQ0tERUw3TnpMMmVHd0I3?= =?utf-8?B?ZnRrbmswUW5aSmMxOWpMODRSdVUxWEdGRVZDblJtZStTU1hmZldoYURlTU9F?= =?utf-8?Q?55p+SurC6yIYe0orOECxWQgt8?= Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-XiJgakgFxx9P1vBaZNdG" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9487.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f157902-2050-4098-52df-08db954d8be3 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2023 00:47:29.4792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rxpTBcLUtucU1oSb27VrBWDfLuSLyYQDMXEC8V/8JYQ3Ue1K70q6pltV2S1N/coV0vz0OtxnpKs3BZPBxBeysA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8766 --=-XiJgakgFxx9P1vBaZNdG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-07-31 at 14:24 -0700, Stefano Stabellini wrote: > On Mon, 31 Jul 2023, Federico Serafini wrote: > > Give a name to unnamed parameters to address violations of > > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form > > with > > named parameters"). > > Keep consistency between parameter names and types used in function > > declarations and the ones used in the corresponding function > > definitions, thus addressing violations of MISRA C:2012 Rule 8.3 > > ("All declarations of an object or function shall use the same > > names > > and type qualifiers"). > >=20 > > No functional changes. > >=20 > > Signed-off-by: Federico Serafini >=20 > Reviewed-by: Stefano Stabellini >=20 Acked-by: Dario Faggioli Thanks and Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-XiJgakgFxx9P1vBaZNdG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmTNnCAACgkQFkJ4iaW4 c+6ythAAvae6nh/Q/Myys+mIY58VDW3lPQp1UdXVADxcNoKjIzBVV7JKrni9uMfI xD13+agt5t9qP8mLnoR9rmgCcIdoclp8Z0WnjK4rFG7k/X/Rdj49/PuxM57nKHGG 2rhbqwqo7XdyvoJ4rmAJrT8o1DdYfdrB3skyR06eSOZEkvNYl/1NKsDenQNRpH0Y ZUUIGFIqokv1jjN2CS4ef9JTRqT1K2QRXluuWE82cMpcKjlISVDQhkJtFr0NV3wY yqSIZYDtsScDJ//W0QEvl6FWvOLEuH+x758YFsYk69DoACc/EQuKmOmGxmX50ckT GTPHGCk3lpIKAzq8bnE35AM8qL6yjOVFQEp2v7eWBPlYw1OOMiXZ8J0IwwAkcKa7 dn2qFr/8SizxSEKO7mH88pxKtrkzO8WXQKbctyC9nfYzizOT3exQEu2H1DobhF+l ZJ4nmrPD0SI6IS5T8vept9ys1sMnq+Ylj0NcZf9V7W8oXDuqLzNQPfs2Te+hIKtH kX/PfqzGSNY8GYoYv/CDnkbRWIUh6FGzmpyXPCbqakiYmT+bTKNRShk4EYFZYy5w mztRNeD8hhpQF4jndcLQ2vDIPBcZhIgIB/295hk4vasNKJC4JwB6W+NoG2hP7+AY uuCiDxZHcMeEhV7AWph3myZT98AxPVQqydAsrtEDswim1vxs25g= =KF8F -----END PGP SIGNATURE----- --=-XiJgakgFxx9P1vBaZNdG-- From xen-devel-bounces@lists.xenproject.org Sat Aug 05 02:22:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 02:22:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577389.904514 (Exim 4.92) (envelope-from ) id 1qS6w8-0005R8-Ua; Sat, 05 Aug 2023 02:22:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577389.904514; Sat, 05 Aug 2023 02:22:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS6w8-0005Qm-O4; Sat, 05 Aug 2023 02:22:36 +0000 Received: by outflank-mailman (input) for mailman id 577389; Sat, 05 Aug 2023 02:22:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS6w6-0005Qc-Vp; Sat, 05 Aug 2023 02:22:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS6w6-0008Fr-UL; Sat, 05 Aug 2023 02:22:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS6w6-0003m4-Hw; Sat, 05 Aug 2023 02:22:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qS6w6-000576-HR; Sat, 05 Aug 2023 02:22:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=u/4WZQQLL/sgEmhY2I5IbjkcOklGrVUBw9toUqTqnFU=; b=lKbltn0TC6VVpCWatL/5nkSkiY H0ysT4h0hLXbQC6ctGyTuwskeOuv9/YLtIlYguRFjhBbhBki/csr0BO8fXL20JDFfqs5m3tk91R3o SnTcVUzGPtV2s7evQL1Wyd8R7a604lrQwA8dzoYgvbo8y52ivgymdCuK+lUSyrc4at/I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182189: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e55146071de9257d70bd157047700071d0007622 X-Osstest-Versions-That: xen=4a6448fd6497ad7952cd0baacec1869f6791de9e From: osstest service owner Date: Sat, 05 Aug 2023 02:22:34 +0000 flight 182189 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182189/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e55146071de9257d70bd157047700071d0007622 baseline version: xen 4a6448fd6497ad7952cd0baacec1869f6791de9e Last test of basis 182177 2023-08-04 02:02:01 Z 1 days Testing same since 182189 2023-08-04 23:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4a6448fd64..e55146071d e55146071de9257d70bd157047700071d0007622 -> smoke From xen-devel-bounces@lists.xenproject.org Sat Aug 05 04:27:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 04:27:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577396.904523 (Exim 4.92) (envelope-from ) id 1qS8sQ-00018v-I7; Sat, 05 Aug 2023 04:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577396.904523; Sat, 05 Aug 2023 04:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS8sQ-00018o-Ew; Sat, 05 Aug 2023 04:26:54 +0000 Received: by outflank-mailman (input) for mailman id 577396; Sat, 05 Aug 2023 04:26:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS8sO-00018e-Fo; Sat, 05 Aug 2023 04:26:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS8sO-0002tg-Bg; Sat, 05 Aug 2023 04:26:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qS8sN-0008RJ-TN; Sat, 05 Aug 2023 04:26:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qS8sN-0001E9-So; Sat, 05 Aug 2023 04:26:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=frvnaTq2Jw07Yx/jjOFkceZmOhyce8asiVn/vbP8jmE=; b=qcfPPffLmdGYIIv3nNBb2kjpCR 1wWDamJxkHe3nszJVBp8CbHY+0mXPhzrxlYAaari6d+sGxP95l/lNq2ORNn1r5PseWl0sAbVAXsz0 I7vHfZBzpn3TrKFC2+VgwaSyeOBU1ropOv5QhjA/IVHGRrODtEAeD0tH6vBsTHkR9oa8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 182181: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=3a45a4d78c820c79e664ccfcba0153e5336a5c59 X-Osstest-Versions-That: libvirt=99349ba18e726465215a71f28d2146a0a2adb65d From: osstest service owner Date: Sat, 05 Aug 2023 04:26:51 +0000 flight 182181 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182181/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182131 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182131 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182131 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 3a45a4d78c820c79e664ccfcba0153e5336a5c59 baseline version: libvirt 99349ba18e726465215a71f28d2146a0a2adb65d Last test of basis 182131 2023-08-02 19:15:02 Z 2 days Failing since 182175 2023-08-04 01:18:07 Z 1 days 2 attempts Testing same since 182181 2023-08-04 12:27:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Laine Stump Michal Privoznik Peter Krempa jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 99349ba18e..3a45a4d78c 3a45a4d78c820c79e664ccfcba0153e5336a5c59 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Aug 05 05:43:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 05:43:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577405.904534 (Exim 4.92) (envelope-from ) id 1qSA43-0001Qi-2Z; Sat, 05 Aug 2023 05:42:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577405.904534; Sat, 05 Aug 2023 05:42:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSA42-0001Qb-VO; Sat, 05 Aug 2023 05:42:58 +0000 Received: by outflank-mailman (input) for mailman id 577405; Sat, 05 Aug 2023 05:42:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSA41-0001QQ-2K; Sat, 05 Aug 2023 05:42:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSA40-0004m0-UV; Sat, 05 Aug 2023 05:42:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSA40-0002rp-Cd; Sat, 05 Aug 2023 05:42:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSA40-0000jw-C6; Sat, 05 Aug 2023 05:42:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gqy1Lz8qxJmhBD/EH7uyKmLtKe6ovp+aRd3zMiNUMvw=; b=pc5fbJtZBorkZNpwTRN+V5tsRe Y4nGF/CgBmLAHbGi88ac96gdbo7ob5d3b1gokhwQcY5gbw6KMuLyOZpz+aHXavkK44uYvGvlYEiRf ye2cDZyzWcnlgNEOUFR04v6vF3DsNrt4ynqjilrjqAb2z+0IKkEQV9qrt8HSsiiOHLzQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182179: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-saverestore:fail:heisenbug linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c1a515d3c0270628df8ae5f5118ba859b85464a2 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sat, 05 Aug 2023 05:42:56 +0000 flight 182179 linux-linus real [real] flight 182191 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182179/ http://logs.test-lab.xenproject.org/osstest/logs/182191/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 17 guest-saverestore fail pass in 182191-retest test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 182191-retest test-amd64-amd64-pygrub 8 xen-boot fail pass in 182191-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux c1a515d3c0270628df8ae5f5118ba859b85464a2 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 110 days Failing since 180281 2023-04-17 06:24:36 Z 109 days 199 attempts Testing same since 182179 2023-08-04 08:59:01 Z 0 days 1 attempts ------------------------------------------------------------ 3900 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 656225 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Aug 05 09:19:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 09:19:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577463.904544 (Exim 4.92) (envelope-from ) id 1qSDRb-0006S7-AZ; Sat, 05 Aug 2023 09:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577463.904544; Sat, 05 Aug 2023 09:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSDRb-0006S0-77; Sat, 05 Aug 2023 09:19:31 +0000 Received: by outflank-mailman (input) for mailman id 577463; Sat, 05 Aug 2023 09:19:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSDRa-0006Rq-1k; Sat, 05 Aug 2023 09:19:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSDRZ-0001wj-TL; Sat, 05 Aug 2023 09:19:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSDRZ-0003Eh-IP; Sat, 05 Aug 2023 09:19:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSDRZ-0002dD-Hs; Sat, 05 Aug 2023 09:19:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XeFJF3h3+gZOxisjk3VxeFGjHHEl8jOKWv4Q2O7uR0o=; b=UoC9aW6oACNrz+ZgCoBxF15FZH bsnORnbEGVTSz10wQoOdxYEYDxeMC1XjBxof35SlSxakaXoxsIhJhsNGWeD61nzwtkNTC6vf9xv6p JW9zePuGmrJGC/pYm8W+4d3EQhuNPh6huB/IswA3az0D3Py6WcXeU5Pm8cqWvDG7eX0s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182185: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=c26d005e62f4fd177dae0cd70c24cb96761edebc X-Osstest-Versions-That: qemuu=c167c80b463768e04a22fbe37ba6c53a4a08e41e From: osstest service owner Date: Sat, 05 Aug 2023 09:19:29 +0000 flight 182185 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182185/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182171 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182171 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182171 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182171 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182171 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182171 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182171 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182171 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu c26d005e62f4fd177dae0cd70c24cb96761edebc baseline version: qemuu c167c80b463768e04a22fbe37ba6c53a4a08e41e Last test of basis 182171 2023-08-03 17:26:55 Z 1 days Testing same since 182185 2023-08-04 16:19:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: David Edmondson Eric Auger Fiona Ebner Hanna Czenczek Helge Deller Igor Mammedov Li Feng Michael S. Tsirkin Milan Zamazal Peter Maydell Richard Henderson Stefan Hajnoczi Stefano Garzarella Thomas Huth Yuri Benditovich zhenwei pi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git c167c80b46..c26d005e62 c26d005e62f4fd177dae0cd70c24cb96761edebc -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Aug 05 18:45:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 18:45:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577602.904553 (Exim 4.92) (envelope-from ) id 1qSMHD-0004ud-PY; Sat, 05 Aug 2023 18:45:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577602.904553; Sat, 05 Aug 2023 18:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMHD-0004uW-Mi; Sat, 05 Aug 2023 18:45:23 +0000 Received: by outflank-mailman (input) for mailman id 577602; Sat, 05 Aug 2023 18:45:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMHD-0004uM-6W; Sat, 05 Aug 2023 18:45:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMHC-0006fM-T5; Sat, 05 Aug 2023 18:45:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMHC-0007OO-B7; Sat, 05 Aug 2023 18:45:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSMHC-0007NO-Ad; Sat, 05 Aug 2023 18:45:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XwBmgd3CALBdO0wankkDhZToSgw+OAqTYP8FO9yQr/Q=; b=18CWLcV9OiD+LCpjnNU6k9JCFK YCM+ZIPleWNfnOUybNpeJPdCGByf0QVZbdvmc4z99X38ut70hAKw5opVubE3abhxsb+0FNI01SGs/ QuOuJ4ayfBlL6Jb77Xdm1QbcAHI+rUbC9EYANkpzxPJH3uVtWW/c1YKY/CaM8rBht8dc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182187: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:regression xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4a6448fd6497ad7952cd0baacec1869f6791de9e X-Osstest-Versions-That: xen=51588938e0cd0e02dbc1d6d8c697c577135ff666 From: osstest service owner Date: Sat, 05 Aug 2023 18:45:22 +0000 flight 182187 xen-unstable real [real] flight 182195 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182187/ http://logs.test-lab.xenproject.org/osstest/logs/182195/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail REGR. vs. 182128 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 182128 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182128 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182128 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 4a6448fd6497ad7952cd0baacec1869f6791de9e baseline version: xen 51588938e0cd0e02dbc1d6d8c697c577135ff666 Last test of basis 182128 2023-08-02 18:03:55 Z 3 days Failing since 182174 2023-08-04 01:17:26 Z 1 days 2 attempts Testing same since 182187 2023-08-04 22:33:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Khem Raj Nicola Vetrini Simone Ballarin Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 4a6448fd6497ad7952cd0baacec1869f6791de9e Author: Simone Ballarin Date: Tue Aug 1 11:57:04 2023 +0200 automation/eclair: avoid failure in case of missing merge point In the context of an auto pull request, when a common merge point is not found the integration will continue the analysis without failing. Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini commit 0d3d7eb82f4d6dca0b07359868ade1b3fc313a13 Author: Simone Ballarin Date: Tue Aug 1 11:57:03 2023 +0200 automation/eclair: add scheduled pipelines This patch introduces six new ECLAIR jobs that run only when triggered by a GitLab scheduled pipeline. Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini commit 5499c75c21a7f5fd2832c0107ab8b5936fc2b466 Author: Simone Ballarin Date: Tue Aug 1 11:57:02 2023 +0200 automation/eclair: add direct link to reports This patch adds direct links to the analysis findings in the console log. Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini commit 4d687adc8c77b5299d9aa5ece3d9bdcc538fdc16 Author: Simone Ballarin Date: Tue Aug 1 11:57:01 2023 +0200 automation/eclair: add support for tag pipelines The ECLAIR jobs fail when triggered by tag pipelines (e.g. xen-project/patchew/xen). This patch extends the integration to support such pipelines. Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini commit 092cae024ab6cd9bd5788eb6ca3ae1a05e796c0a Author: Julien Grall Date: Wed Aug 2 16:47:05 2023 +0100 xen/x86: Constify the vCPU parameter for expand_xsave_states() expand_xsave_states() is not meant to modify the vCPU. So the parameter can be const. Signed-off-by: Julien Grall Acked-by: Jan Beulich commit 1aa5acbbec3f37bf38d78fa96d210053f8e8efd5 Author: Jan Beulich Date: Thu Aug 3 17:35:39 2023 +0200 libxl: allow building with old gcc again We can't use initializers of unnamed struct/union members just yet. Fixes: d638fe233cb3 ("libxl: use the cpuid feature names from cpufeatureset.h") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Acked-by: Andrew Cooper commit 4f6afde88be3e8960eb311d16ac41d44ab71ed10 Author: Jan Beulich Date: Thu Aug 3 17:35:26 2023 +0200 libxl: avoid shadowing of index() Because of -Wshadow the build otherwise fails with old enough glibc. While there also obey line length limits for msr_add(). Fixes: 6d21cedbaa34 ("libxl: add support for parsing MSR features") Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Acked-by: Andrew Cooper commit dfc490a3740bb7d6889939934afadcb58891fbce Author: Khem Raj Date: Tue Aug 1 10:49:30 2023 -0700 arm: Avoid using solaris syntax for .section directive Assembler from binutils 2.41 will rejects ([1], [2]) the following syntax .section "name", #alloc for any other any target other than ELF SPARC. This means we can't use it in the Arm code. So switch to the GNU syntax .section name [, "flags"[, @type]] [1] https://sourceware.org/bugzilla/show_bug.cgi?id=11601 [2] https://sourceware.org/binutils/docs-2.41/as.html#Section Signed-off-by: Khem Raj Reviewed-by: Michal Orzel [jgrall: Reword commit message] Acked-by: Julien Grall commit da55d9dc919752e092e591a74ab54c2f7d5adfab Author: Andrew Cooper Date: Wed Aug 2 13:44:30 2023 +0100 x86/gen-cpuid: Avoid violations of Misra rule 1.3 Add the script to the X86 section in ./MAINTAINERS. Structures or unions without any named members aren't liked by Misra (nor the C standard). Avoid emitting such for leaves without any known bits. The placeholders are affected similarly, but are only visible to MISRA in the middle of a patch series adding a new leaf. The absence of a name was intentional as these defines need to not duplicate names. As that's not deemed acceptable any more, move placeholder processing into the main loop and append the the word number to generate unique names. $ diff cpuid-autogen-{before,after}.h @@ -1034,7 +1034,7 @@ bool intel_psfd:1, ipred_ctrl:1, rrsba_ctrl:1, ddp_ctrl:1, ... #define CPUID_BITFIELD_14 \$ - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... + uint32_t _placeholder_14 #define CPUID_BITFIELD_15 \$ bool :1, :1, :1, :1, avx_vnni_int8:1, avx_ne_convert:1, :1, ... @@ -1043,19 +1043,19 @@ bool rdcl_no:1, eibrs:1, rsba:1, skip_l1dfl:1, intel_ssb_no:1, ... #define CPUID_BITFIELD_17 \$ - bool :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, :1, ... + uint32_t _placeholder_17 #define CPUID_BITFIELD_18 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_18 #define CPUID_BITFIELD_19 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_19 #define CPUID_BITFIELD_20 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_20 #define CPUID_BITFIELD_21 \$ - uint32_t :32 /* placeholder */ + uint32_t _placeholder_21 #endif /* __XEN_X86__FEATURESET_DATA__ */ No functional change. Signed-off-by: Jan Beulich Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich commit 73aea9ada87f804f6b56efda13aead3b950f8657 Author: Andrew Cooper Date: Fri Jul 28 20:27:01 2023 +0100 x86: Delete str() This is used in an assertion only, which is somewhat dubious to begin with and isn't expected to surivive the x86-S work (where TR is expected to become become be a NUL selector). Delete it now. This avoids many cases where as a global symbol, it shadows local string variables. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Tested-by: Nicola Vetrini commit abe93fc8aafaecabb2ffbad1b29f049ca02ab8cb Author: Andrew Cooper Date: Fri Feb 17 14:10:58 2023 +0000 x86/entry: Rename the exception entrypoints This makes the names match the architectural short names that we use elsewhere. This avoids 'debug' in particular from being a global symbol shadowed by many local parameter names. Remove the DECLARE_TRAP_HANDLER{,_CONST}() infrastructure. Only NMI/#MC are referenced externally (and NMI will cease to be soon, as part of adding FRED support). Move the entrypoint declarations into the respective traps.c where they're used, rather than keeping them visible across ~all of Xen. Drop the long-stale comment at the top of init_idt_traps(). It's mostly discussing a 32bit Xen, and bogus otherwise as it's impossible to use trap gates correctly for these purposes. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Tested-by: Nicola Vetrini commit 26638cd9efaea4fea3322914efc2611981e001fe Author: Andrew Cooper Date: Fri Feb 17 23:06:37 2023 +0000 x86/traps: Move do_general_protection() earlier ... in order to clean up the declarations without needing to forward declare it for handle_gdt_ldt_mapping_fault() No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Aug 05 18:47:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 18:47:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577607.904564 (Exim 4.92) (envelope-from ) id 1qSMJV-0005TV-6f; Sat, 05 Aug 2023 18:47:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577607.904564; Sat, 05 Aug 2023 18:47:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMJV-0005TO-46; Sat, 05 Aug 2023 18:47:45 +0000 Received: by outflank-mailman (input) for mailman id 577607; Sat, 05 Aug 2023 18:47:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMJT-0005TC-Hm; Sat, 05 Aug 2023 18:47:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMJT-0006hn-EN; Sat, 05 Aug 2023 18:47:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSMJS-0007RU-V9; Sat, 05 Aug 2023 18:47:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSMJS-00084w-Ui; Sat, 05 Aug 2023 18:47:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iqhWvb1AHITQyLRvu/M5lG8fZAV9vx8d+BgPTZBZhAc=; b=F7VQnpXVR77Qar5exJp1DSNhg3 PeZ4kcNzrzibbk+qaArTlRyGAXr4SFtZpCXvxaltvihd/XuKmTbDElU2Ccb/5lKD/djTkeRR3KrDR Xbiy7tPiXslzK3ff3P/iMW/tjzi8EYLTltGOGzPmVfGr+XflkBa3nM+Xg50GCzsTBMns=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 182192: tolerable FAIL - PUSHED X-Osstest-Failures: libvirt:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=3d2f3fb72b4c1d636822606ef8b1df29ae4a2be6 X-Osstest-Versions-That: libvirt=3a45a4d78c820c79e664ccfcba0153e5336a5c59 From: osstest service owner Date: Sat, 05 Aug 2023 18:47:42 +0000 flight 182192 libvirt real [real] flight 182196 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182192/ http://logs.test-lab.xenproject.org/osstest/logs/182196/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 182196-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182181 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182181 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182181 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 3d2f3fb72b4c1d636822606ef8b1df29ae4a2be6 baseline version: libvirt 3a45a4d78c820c79e664ccfcba0153e5336a5c59 Last test of basis 182181 2023-08-04 12:27:34 Z 1 days Testing same since 182192 2023-08-05 04:27:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. BerrangĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 3a45a4d78c..3d2f3fb72b 3d2f3fb72b4c1d636822606ef8b1df29ae4a2be6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Aug 05 21:03:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 05 Aug 2023 21:03:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577625.904583 (Exim 4.92) (envelope-from ) id 1qSOQV-0003G8-SQ; Sat, 05 Aug 2023 21:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577625.904583; Sat, 05 Aug 2023 21:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSOQV-0003G1-Pp; Sat, 05 Aug 2023 21:03:07 +0000 Received: by outflank-mailman (input) for mailman id 577625; Sat, 05 Aug 2023 21:03:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSOQT-0003Fu-MR for xen-devel@lists.xenproject.org; Sat, 05 Aug 2023 21:03:05 +0000 Received: from galois.linutronix.de (galois.linutronix.de [2a0a:51c0:0:12e:550::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 761ea207-33d3-11ee-8613-37d641c3527e; Sat, 05 Aug 2023 23:03:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 761ea207-33d3-11ee-8613-37d641c3527e From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691269380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSbKeXLBsgKqGj/TwqTJ9+PojQPLuVRP6JDwmEEGuoE=; b=G1L7HlLWpNbkQsJ5hzO4fWWiZ+FtA0lxn/PDsGsygDHKd82Z1Dlrc+/V4zug84FWYwNTBe /MysUkkx5IjU9x62KFTC8slW5q048LdNDfzZMBpZeqJSQy/30me7wEOUXlVjdPRelQbtal PO6QKSTMLwFh1ZFT3SgL5IaxVVsyZYXcDeEnOPSs4sdPvE0UEVxtoBueWh4tk9uHJSamI+ i5R7rN+6OmoKEx9+5sfv1irx9EVO+J6UgKEYv/QSZ6F+D6Pqc9F5j/CSbBB3bfKsrm+o38 IuwmqsyUupUM8g7ufi9tYo9fYSwRTi7bhGAE78K3uoeRUpbdCG8xwWbO1DDugQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691269380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSbKeXLBsgKqGj/TwqTJ9+PojQPLuVRP6JDwmEEGuoE=; b=tJDGqJG9ZGL0jQfrmZogiEnjYq0oxLwLymgfLwSzBNsVGW5UDfDiT9E9gA4oG6BZEn37Qr KJ2/cN0ZZLuWxOCA== To: Peter Zijlstra , "Li, Xin3" Cc: "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "Lutomirski, Andy" , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , "Gross, Jurgen" , "Ostrovsky, Boris" Subject: Re: [RFC PATCH 1/1] x86/traps: Get rid of exception handlers' second argument error code In-Reply-To: <20230804190120.GP212435@hirez.programming.kicks-ass.net> References: <20230804075734.8372-1-xin3.li@intel.com> <20230804101321.GH214207@hirez.programming.kicks-ass.net> <20230804190120.GP212435@hirez.programming.kicks-ass.net> Date: Sat, 05 Aug 2023 23:02:59 +0200 Message-ID: <87o7jlmccc.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain On Fri, Aug 04 2023 at 21:01, Peter Zijlstra wrote: > On Fri, Aug 04, 2023 at 05:35:11PM +0000, Li, Xin3 wrote: >> > > The commit d99015b1abbad ("x86: move entry_64.S register saving out of >> > > the macros") introduced the changes to set orig_ax to -1, but I can't >> > > see why it's required. Our tests on x86_64 and x86_32 seem fine if >> > > orig_ax is left unchanged instead of set to -1. >> > >> > That means that SYSCALL_NUM(regs) get to be garbage; or something like that. >> >> I find SYSCALL_NUM(regs) in tools/testing/selftests/seccomp/seccomp_bpf.c, >> but nothing obvious to me. >> >> I think it's clear that once exceptions and IRQs are handled, the original >> context will be fully recovered in a normal case. >> >> Is it related to preemption after such a event? >> >> I must have missed something; can you please elaborate it? > > arch/x86/include/asm/syscall.h > > syscall_get_nr() syscall_rollback() Specifically it breaks signal handling. See arch_do_signal_or_restart() and handle_signal(). So, no. This cannot be changed nilly willy especially not because orig_ax is part of the UABI. Even if it would work, this patch is completely unreviewable. There are smarter ways to make such a change in digestable chunks. I also looked at the latest FRED series and that's broken vs. orig_ax in the same way. Aside of it the series is not applying to any tree I'm aware of. It fails because its based on a tree which has IRQ_MOVE_CLEANUP_VECTOR removed, but that's nowhere in mainline or tip. This is not the way it works, really. Back to the problem at hand. I'm absolutely not understanding why this all is so complicated. FRED pushs the error code or 0 (in case there is no error code) right into orig_ax. That's where the ERET[US] frame starts. ERT[US] do not care at all about the error code location, they skip it by adding 8 to RSP. So the obvious thing to do is: fred_entry_from_xxxx(struct pt_regs *regs) { unsigned long error_code = regs->orig_ax; regs->orig_ax = -1; dispatch_1st_level(regs->type, regs, error_code); } Now the dispatching code in your series looks nice and shiny with all those tables, but in practice it's not so shiny at all. For one this code forces indirect calls even in places where there are no indirect calls required. But what's worse it causes you to make everything uniform one way or the other and adding all this dispatch_table_##func muck, which is fully duplicated code for absolutely zero reason. That's error prone and a maintainence mess. The vast majority of exceptions, interrupts whatever is not special at all neither on FRED nor on IDT. The ones which need special treatment are those which store additional information in the stack frame and these are the exception - not the rule. And those require special treatment anyway whether you make the rest look uniform or not. IOW, your approach of making everything uniform is completely wrong. There is a reason why some system vectors are not using DEFINE_IDTENTRY_SYSVEC(). Particularly the RESCHEDULE_VECTOR. This has been performance optimized with a lot of effort and no, we are not going to sacrifice that just because it makes it sooo simple for FRED. This is not about simplicity. This is about sane and maintainable code which preserves the carefully optimized code paths which are hotpath no matter whether there is IDT or FRED. I'm going to reply on your last failed resend attempt after creating a sane mail thread out of the mess you created (including the insanely large and inappropriate cc list). Thanks, tglx From xen-devel-bounces@lists.xenproject.org Sun Aug 06 00:44:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 00:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577647.904597 (Exim 4.92) (envelope-from ) id 1qSRsh-0000W2-T6; Sun, 06 Aug 2023 00:44:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577647.904597; Sun, 06 Aug 2023 00:44:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSRsh-0000Vv-O0; Sun, 06 Aug 2023 00:44:27 +0000 Received: by outflank-mailman (input) for mailman id 577647; Sun, 06 Aug 2023 00:44:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSRsg-0000Vl-Q6; Sun, 06 Aug 2023 00:44:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSRsg-00075M-Kv; Sun, 06 Aug 2023 00:44:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSRsg-0007pW-88; Sun, 06 Aug 2023 00:44:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSRsg-0006iu-7c; Sun, 06 Aug 2023 00:44:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bN0HCJU7IrvRLL92njW0apXSO68lc4GxCgnuiu9kdZQ=; b=kvQum3tBmc7WGefA6wLO4AC8B8 4w9Db4P/iC3PHLuL062yicTU0XLpD2p0psYy566zy0/7iOBvuPWXZvUG3qBtYVB320Io1kBiU94Pt /855XAlB1MNBZwiP/0MNMf2wjdCO4PWESau/havELTGL8cKaQOIU3G6q9ChOA0uEdi0M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182193: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=024ff300db33968c133435a146d51ac22db27374 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 06 Aug 2023 00:44:26 +0000 flight 182193 linux-linus real [real] flight 182200 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182193/ http://logs.test-lab.xenproject.org/osstest/logs/182200/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 182200-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 182200-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 024ff300db33968c133435a146d51ac22db27374 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 111 days Failing since 180281 2023-04-17 06:24:36 Z 110 days 200 attempts Testing same since 182193 2023-08-05 05:46:14 Z 0 days 1 attempts ------------------------------------------------------------ 3906 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 657521 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 06 01:36:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 01:36:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577657.904605 (Exim 4.92) (envelope-from ) id 1qSSh1-0007z8-GC; Sun, 06 Aug 2023 01:36:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577657.904605; Sun, 06 Aug 2023 01:36:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSSh1-0007z1-DT; Sun, 06 Aug 2023 01:36:27 +0000 Received: by outflank-mailman (input) for mailman id 577657; Sun, 06 Aug 2023 01:36:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSSgz-0007yr-ME; Sun, 06 Aug 2023 01:36:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSSgz-0001tI-EB; Sun, 06 Aug 2023 01:36:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSSgy-0001Nx-SY; Sun, 06 Aug 2023 01:36:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSSgy-0006Ud-S9; Sun, 06 Aug 2023 01:36:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L8bVfV2OjCA5AiDztMAFAGnk1l2HrlL2s5obEPB6AQI=; b=0HjUsPQdxdHGNgxawTOXWQU2AJ lgjmAkLEKsTuFrSmYXcqDYokwnYZX9bDu+yJJuGxs8eyg5Z+OPgyKFKtijbwuMJzOT3Sg5WJqy7M6 b1pQAjRQHbG24tkIebsFlFq10xZp0Q/UdQPPumkwfW+Mizgp/Go/2Z1c+LwHXoGORtV8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182194: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=71934cf6bf878f82dac3fceb7d06d293ec3f6f8f X-Osstest-Versions-That: qemuu=c26d005e62f4fd177dae0cd70c24cb96761edebc From: osstest service owner Date: Sun, 06 Aug 2023 01:36:24 +0000 flight 182194 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182194/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182185 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182185 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182185 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182185 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182185 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182185 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182185 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182185 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 71934cf6bf878f82dac3fceb7d06d293ec3f6f8f baseline version: qemuu c26d005e62f4fd177dae0cd70c24cb96761edebc Last test of basis 182185 2023-08-04 16:19:48 Z 1 days Testing same since 182194 2023-08-05 09:23:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: BALATON Zoltan Daniel Henrique Barboza Nicholas Piggin Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git c26d005e62..71934cf6bf 71934cf6bf878f82dac3fceb7d06d293ec3f6f8f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Aug 06 08:07:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 08:07:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577671.904616 (Exim 4.92) (envelope-from ) id 1qSYmh-0005zL-JY; Sun, 06 Aug 2023 08:06:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577671.904616; Sun, 06 Aug 2023 08:06:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSYmh-0005zE-FA; Sun, 06 Aug 2023 08:06:43 +0000 Received: by outflank-mailman (input) for mailman id 577671; Sun, 06 Aug 2023 08:06:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSYmf-0005z4-Sr; Sun, 06 Aug 2023 08:06:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSYmf-00040d-KQ; Sun, 06 Aug 2023 08:06:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSYmf-0002Lm-32; Sun, 06 Aug 2023 08:06:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSYmf-0006mJ-2L; Sun, 06 Aug 2023 08:06:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YAbI8yu2jVSROZ1F+noceCfFz/prZGiLOjRmQC0+T+Q=; b=WjrLn61Oe2Ge2j9Be5V4HPT/Ps ergsLBSkQFg69/2oudqNvCYYm1BiWTVr4AYOOy2DusXnm3QHxC/tx6FEW0s0YMEe/x0zCmeWG0g8Y 6TdfjfU0vdk87BdO+4O31ldLvnpkzvI1O4KM/dTVYXmhIYZZ+Y2qHY7gZw21E5EEIB88=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182197: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e55146071de9257d70bd157047700071d0007622 X-Osstest-Versions-That: xen=51588938e0cd0e02dbc1d6d8c697c577135ff666 From: osstest service owner Date: Sun, 06 Aug 2023 08:06:41 +0000 flight 182197 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182197/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 182128 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182128 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182128 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182128 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182128 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182128 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182128 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e55146071de9257d70bd157047700071d0007622 baseline version: xen 51588938e0cd0e02dbc1d6d8c697c577135ff666 Last test of basis 182128 2023-08-02 18:03:55 Z 3 days Failing since 182174 2023-08-04 01:17:26 Z 2 days 3 attempts Testing same since 182197 2023-08-05 18:49:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Khem Raj Nicola Vetrini Simone Ballarin Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 51588938e0..e55146071d e55146071de9257d70bd157047700071d0007622 -> master From xen-devel-bounces@lists.xenproject.org Sun Aug 06 14:12:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 14:12:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577698.904679 (Exim 4.92) (envelope-from ) id 1qSeUT-0001wd-2O; Sun, 06 Aug 2023 14:12:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577698.904679; Sun, 06 Aug 2023 14:12:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSeUS-0001wW-Tv; Sun, 06 Aug 2023 14:12:16 +0000 Received: by outflank-mailman (input) for mailman id 577698; Sun, 06 Aug 2023 14:12:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSeUQ-0001wF-OX for xen-devel@lists.xenproject.org; Sun, 06 Aug 2023 14:12:15 +0000 Received: from out203-205-251-36.mail.qq.com (out203-205-251-36.mail.qq.com [203.205.251.36]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38244dc3-3463-11ee-b27b-6b7b168915f2; Sun, 06 Aug 2023 16:12:08 +0200 (CEST) Received: from localhost.localdomain ([220.243.131.5]) by newxmesmtplogicsvrszb6-0.qq.com (NewEsmtp) with SMTP id 2EBA0A76; Sun, 06 Aug 2023 22:11:43 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38244dc3-3463-11ee-b27b-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1691331106; bh=km0RHk7GmUg0c0pMnKkJEFCFmmqVKFM2uZzWPDD58UM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=r1uoeu8OFUIirpjYtibP0RoDY//Wc4ran7LRz1TIxdsFQ+w4QRVXtDjX5yPVAgBPT 05T4B+L9rx0tuY542RUcTMnP+mgZuS7yKdBj0It4YHYILvDC5w2gX9Ux17bfwRenv6 +ennMMlpxj7NiQ231ZLStYMMDGS7pnksmX50+mO4= X-QQ-mid: xmsmtpt1691331103t1e48yjzc Message-ID: X-QQ-XMAILINFO: M7dxyDFn9MPmJaJLhUnyC7r5FWNexqHHySU8S2U4Z7TPYOtNOAKnKcJ9dqZOwd lgAnZ2tVgPLE7IZeQYWLsjZgw6vdLOGkWm/5COii/VEHBMEhlToKLGIvKiVz9qzykkavo+DlZsqf 0guPTcuiezm0skj2HvDkrOWVSCUbsIAdwo29bBeRdhxDaqpmRzJLYk3KGvvi4p2dVhQo0O+SrYtM GGFd1z8X/XFkGQ8fcEzy6mztNnzuHY/YA/ylJJOPgikPvkNZduk526PT007LaFUcvxlnu22ruHxn s7DOScOEumy/OILPnLg8G/BXADN/CzrGtbDIASJzRx72jYi3LAcdtPHNVQwLhf15nYH1peB3lqzR 2GbNn7yGXt52iSOu9gPqmdMvclk2j8tqGR3PtKWUEnlD86b+KYqWWG9ADWkMsbniRKdf2eHrhIFV zoaT4lk5/tnVDH2HVkyYN2FlXE87zsjqxp5tdRFyiAwydw1+msoK8dK9o1UzhjAY7eUumByYP6/W rwl8KSUiDg3gft8ovg1ngKEh2+ZvO3nJgwBU/K1PULjXkWM9pFVYIVFILLNmwFGh04/Kcy7k7TSt mI/Eceh8Uuf16c8xpcnNKD4zzJuSQJBZ4DAe97OeL1i9bjJAwbVC+YI7S5Z/8u0yePYlQRXoKbu4 d+tyAA8XcpS5/HNsylZdjSb5OXuyLfp9r986nkqbN1Fn4Y9wuCPcJMsqAZaMoBegotNCI2jPL62U hzHqpLV19IUU/nCdPopPCxpGW0/gtN1VFiBeSoOySsLCEJZiIFogDAFPbAQNpz4rc8gWfBtZJXwd tlaH3tpWZywC3qFWT4irI7DwFR1AJCDfZ/6JiQ8qkV9k4qKLHanjh9ARH/G3ukHRtZyoa9gU8HkX r4TCLL53xLqYyNKG/pk42+1GxTa2Rseh7xgVv/1ZQRjpyW3lurm/7lfqy+VWWUyAZisHhvcl2J9g gZH/5whqS/chq8ZRf+vUBKPTlpZfJs553a43LFOa4= X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= From: Zhang Shurong To: Greg KH Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control() Date: Sun, 06 Aug 2023 22:11:43 +0800 X-OQ-MSGID: <5974189.lOV4Wx5bFT@localhost.localdomain> In-Reply-To: <4825193.GXAFRqVoOG@localhost.localdomain> References: <2023062628-shame-ebook-56f2@gregkh> <4825193.GXAFRqVoOG@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" =E5=9C=A8 2023=E5=B9=B47=E6=9C=881=E6=97=A5=E6=98=9F=E6=9C=9F=E5=85=AD CST = =E4=B8=8B=E5=8D=8811:51:43=EF=BC=8CZhang Shurong =E5=86=99=E9=81=93=EF=BC=9A > =E5=9C=A8 2023=E5=B9=B46=E6=9C=8826=E6=97=A5=E6=98=9F=E6=9C=9F=E4=B8=80 C= ST =E4=B8=8B=E5=8D=881:52:02=EF=BC=8C=E6=82=A8=E5=86=99=E9=81=93=EF=BC=9A >=20 > > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > > --- a/drivers/usb/host/xen-hcd.c > > > > +++ b/drivers/usb/host/xen-hcd.c > > > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *h= cd, > > > > __u16 typeReq, __u16 wValue,> > > > > >=20 > > > > info->ports[wIndex - 1].c_connection =3D >=20 > false; >=20 > > > > fallthrough; > > > > =09 > > > > default: > > > > + if (wValue >=3D 32) > > > > + goto error; > > > >=20 > > > > info->ports[wIndex - 1].status &=3D ~(1 >=20 > << wValue); >=20 > > > Even 31 is out of bounds (as in: UB) as long as it's 1 here rather > > > than 1u. > >=20 > > Why isn't the caller fixed so this type of value could never be passed > > to the hub_control callback? > >=20 > > thanks, > >=20 > > greg k-h >=20 > Although I'm not knowledgeable about the USB subsystem, I've observed that > not all driver code that implements hub_control callback performs a shift > operation on wValue, and not all shift operations among them cause > problems. Therefore, I've decided to fix this issue within each driver > itself. >=20 > For example, in r8a66597_hub_control, it will first check whether wValue = is > valid (always < 31) before the shift operation. In case of an invalid > number, the code would execute the error branch instead of the shift > operation. >=20 > switch (wValue) { > case USB_PORT_FEAT_ENABLE: > rh->port &=3D ~USB_PORT_STAT_POWER; > break; > case USB_PORT_FEAT_SUSPEND: > break; > case USB_PORT_FEAT_POWER: > r8a66597_port_power(r8a66597, port, 0); > break; > case USB_PORT_FEAT_C_ENABLE: > case USB_PORT_FEAT_C_SUSPEND: > case USB_PORT_FEAT_C_CONNECTION: > case USB_PORT_FEAT_C_OVER_CURRENT: > case USB_PORT_FEAT_C_RESET: > break; > default: > goto error; > } > rh->port &=3D ~(1 << wValue); Hi there. I apologize for reaching out once more. I'm feeling a bit puzzled= =20 about what my next step should be. I'm unsure whether I should rewrite this= =20 patch or attempt to address the issue at the caller level. From xen-devel-bounces@lists.xenproject.org Sun Aug 06 14:27:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 14:27:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577704.904687 (Exim 4.92) (envelope-from ) id 1qSejI-0003mV-95; Sun, 06 Aug 2023 14:27:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577704.904687; Sun, 06 Aug 2023 14:27:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSejI-0003mO-6I; Sun, 06 Aug 2023 14:27:36 +0000 Received: by outflank-mailman (input) for mailman id 577704; Sun, 06 Aug 2023 14:27:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSejG-0003mI-TJ for xen-devel@lists.xenproject.org; Sun, 06 Aug 2023 14:27:34 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60b89fba-3465-11ee-8613-37d641c3527e; Sun, 06 Aug 2023 16:27:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C9DA6117D; Sun, 6 Aug 2023 14:27:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD045C433C8; Sun, 6 Aug 2023 14:27:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60b89fba-3465-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691332050; bh=k7Wz5My+7y3gVES1fFNpSuU/X31s8HmopFxP7aidXy4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hOhrseXDh8smzJLqzn5JMnrQ1JlOrcR/7m0rx32YCV/jfEvBxLxJLP26t1eKCCm3R ap5kt7nu01tatM0i4du1IW4yIO5zzSbWCbw/P3AeRJFfoWY6xllJF11Oww2hvBdgX4 MpqQ8p53clg9JYy89ix1047wMe9DLCjm4wX+hQWs= Date: Sun, 6 Aug 2023 16:27:27 +0200 From: Greg KH To: Zhang Shurong Cc: jgross@suse.com, xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control() Message-ID: <2023080659-turban-exemption-1196@gregkh> References: <2023062628-shame-ebook-56f2@gregkh> <4825193.GXAFRqVoOG@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > 在 2023å¹´7月1日星期六 CST 下åˆ11:51:43，Zhang Shurong 写é“ï¼ > > 在 2023å¹´6月26日星期一 CST 下åˆ1:52:02，您写é“ï¼ > > > > > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > > > --- a/drivers/usb/host/xen-hcd.c > > > > > +++ b/drivers/usb/host/xen-hcd.c > > > > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *hcd, > > > > > __u16 typeReq, __u16 wValue,> > > > > > > > > > > > info->ports[wIndex - 1].c_connection = > > > > false; > > > > > > > fallthrough; > > > > > > > > > > default: > > > > > + if (wValue >= 32) > > > > > + goto error; > > > > > > > > > > info->ports[wIndex - 1].status &= ~(1 > > > > << wValue); > > > > > > Even 31 is out of bounds (as in: UB) as long as it's 1 here rather > > > > than 1u. > > > > > > Why isn't the caller fixed so this type of value could never be passed > > > to the hub_control callback? > > > > > > thanks, > > > > > > greg k-h > > > > Although I'm not knowledgeable about the USB subsystem, I've observed that > > not all driver code that implements hub_control callback performs a shift > > operation on wValue, and not all shift operations among them cause > > problems. Therefore, I've decided to fix this issue within each driver > > itself. > > > > For example, in r8a66597_hub_control, it will first check whether wValue is > > valid (always < 31) before the shift operation. In case of an invalid > > number, the code would execute the error branch instead of the shift > > operation. > > > > switch (wValue) { > > case USB_PORT_FEAT_ENABLE: > > rh->port &= ~USB_PORT_STAT_POWER; > > break; > > case USB_PORT_FEAT_SUSPEND: > > break; > > case USB_PORT_FEAT_POWER: > > r8a66597_port_power(r8a66597, port, 0); > > break; > > case USB_PORT_FEAT_C_ENABLE: > > case USB_PORT_FEAT_C_SUSPEND: > > case USB_PORT_FEAT_C_CONNECTION: > > case USB_PORT_FEAT_C_OVER_CURRENT: > > case USB_PORT_FEAT_C_RESET: > > break; > > default: > > goto error; > > } > > rh->port &= ~(1 << wValue); > > Hi there. I apologize for reaching out once more. I'm feeling a bit puzzled > about what my next step should be. I'm unsure whether I should rewrite this > patch or attempt to address the issue at the caller level. Try addressing it at the caller level first please. If that somehow does not work, then we will take a patch series that fixes all of the host controller drivers at once. thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Sun Aug 06 15:16:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 15:16:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577710.904699 (Exim 4.92) (envelope-from ) id 1qSfU9-0000ms-SC; Sun, 06 Aug 2023 15:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577710.904699; Sun, 06 Aug 2023 15:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSfU9-0000ml-Ne; Sun, 06 Aug 2023 15:16:01 +0000 Received: by outflank-mailman (input) for mailman id 577710; Sun, 06 Aug 2023 15:16:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSfU8-0000mf-Pn for xen-devel@lists.xenproject.org; Sun, 06 Aug 2023 15:16:00 +0000 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by se1-gles-flk1.inumbo.com (Halon) with SMTP id 226247e7-346c-11ee-8613-37d641c3527e; Sun, 06 Aug 2023 17:15:54 +0200 (CEST) Received: (qmail 96132 invoked by uid 1000); 6 Aug 2023 11:15:51 -0400 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 226247e7-346c-11ee-8613-37d641c3527e Date: Sun, 6 Aug 2023 11:15:51 -0400 From: Alan Stern To: Greg KH Cc: Zhang Shurong , jgross@suse.com, xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control() Message-ID: <3481a644-1648-4fa9-86eb-2a0b86b8f47a@rowland.harvard.edu> References: <2023062628-shame-ebook-56f2@gregkh> <4825193.GXAFRqVoOG@localhost.localdomain> <2023080659-turban-exemption-1196@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023080659-turban-exemption-1196@gregkh> On Sun, Aug 06, 2023 at 04:27:27PM +0200, Greg KH wrote: > On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > > 在 2023å¹´7月1日星期六 CST 下åˆ11:51:43，Zhang Shurong 写é“ï¼ > > > 在 2023å¹´6月26日星期一 CST 下åˆ1:52:02，您写é“ï¼ > > > > > > > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > > > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > > > > --- a/drivers/usb/host/xen-hcd.c > > > > > > +++ b/drivers/usb/host/xen-hcd.c > > > > > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *hcd, > > > > > > __u16 typeReq, __u16 wValue,> > > > > > > > > > > > > > info->ports[wIndex - 1].c_connection = > > > > > > false; > > > > > > > > > fallthrough; > > > > > > > > > > > > default: > > > > > > + if (wValue >= 32) > > > > > > + goto error; > > > > > > > > > > > > info->ports[wIndex - 1].status &= ~(1 > > > > > > << wValue); > > > > > > > > Even 31 is out of bounds (as in: UB) as long as it's 1 here rather > > > > > than 1u. > > > > > > > > Why isn't the caller fixed so this type of value could never be passed > > > > to the hub_control callback? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Although I'm not knowledgeable about the USB subsystem, I've observed that > > > not all driver code that implements hub_control callback performs a shift > > > operation on wValue, and not all shift operations among them cause > > > problems. Therefore, I've decided to fix this issue within each driver > > > itself. > > > > > > For example, in r8a66597_hub_control, it will first check whether wValue is > > > valid (always < 31) before the shift operation. In case of an invalid > > > number, the code would execute the error branch instead of the shift > > > operation. > > > > > > switch (wValue) { > > > case USB_PORT_FEAT_ENABLE: > > > rh->port &= ~USB_PORT_STAT_POWER; > > > break; > > > case USB_PORT_FEAT_SUSPEND: > > > break; > > > case USB_PORT_FEAT_POWER: > > > r8a66597_port_power(r8a66597, port, 0); > > > break; > > > case USB_PORT_FEAT_C_ENABLE: > > > case USB_PORT_FEAT_C_SUSPEND: > > > case USB_PORT_FEAT_C_CONNECTION: > > > case USB_PORT_FEAT_C_OVER_CURRENT: > > > case USB_PORT_FEAT_C_RESET: > > > break; > > > default: > > > goto error; > > > } > > > rh->port &= ~(1 << wValue); > > > > Hi there. I apologize for reaching out once more. I'm feeling a bit puzzled > > about what my next step should be. I'm unsure whether I should rewrite this > > patch or attempt to address the issue at the caller level. > > Try addressing it at the caller level first please. If that somehow > does not work, then we will take a patch series that fixes all of the > host controller drivers at once. It's not feasible to fix all the callers, because the calls can come from userspace via usbfs. Alan Stern From xen-devel-bounces@lists.xenproject.org Sun Aug 06 15:22:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 15:22:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577716.904708 (Exim 4.92) (envelope-from ) id 1qSfan-0002GL-HW; Sun, 06 Aug 2023 15:22:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577716.904708; Sun, 06 Aug 2023 15:22:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSfan-0002GE-Ee; Sun, 06 Aug 2023 15:22:53 +0000 Received: by outflank-mailman (input) for mailman id 577716; Sun, 06 Aug 2023 15:22:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSfal-0002G4-Ta; Sun, 06 Aug 2023 15:22:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSfal-0005jC-OI; Sun, 06 Aug 2023 15:22:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSfal-00033u-3N; Sun, 06 Aug 2023 15:22:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSfal-00040z-2n; Sun, 06 Aug 2023 15:22:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I7ySZD7Gq2T6NT6GOTQUHiVagUA5XG3mOihuutJBuPI=; b=xI7gAFVzCnBA1YYLF/bkBXPq2N PJJUHkUrkhy7nJYkHUgAKR1SVa05E9P14SUc+XSMHshSH7vliIrKB1NrNw+2XeWmr8gcYRCqDMIJI wUxXIMElwAdsxxAwPvLDgcroJtfx+m6lYvDZr/drLgFsXyX6nEjhupniCJrJZ5l9g2Xo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182201: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f6a691685962637e53371788fe2a72b171aedc68 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Sun, 06 Aug 2023 15:22:51 +0000 flight 182201 linux-linus real [real] flight 182204 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182201/ http://logs.test-lab.xenproject.org/osstest/logs/182204/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-xl 18 guest-start/debian.repeat fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux f6a691685962637e53371788fe2a72b171aedc68 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 111 days Failing since 180281 2023-04-17 06:24:36 Z 111 days 201 attempts Testing same since 182201 2023-08-06 01:13:03 Z 0 days 1 attempts ------------------------------------------------------------ 3908 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 658041 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Aug 06 17:26:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 17:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577724.904718 (Exim 4.92) (envelope-from ) id 1qShWZ-0007XL-Gh; Sun, 06 Aug 2023 17:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577724.904718; Sun, 06 Aug 2023 17:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qShWZ-0007XD-AE; Sun, 06 Aug 2023 17:26:39 +0000 Received: by outflank-mailman (input) for mailman id 577724; Sun, 06 Aug 2023 17:26:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qShWY-0007X3-G6; Sun, 06 Aug 2023 17:26:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qShWY-0000Zt-5t; Sun, 06 Aug 2023 17:26:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qShWX-0007zm-Nr; Sun, 06 Aug 2023 17:26:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qShWX-0003ta-NR; Sun, 06 Aug 2023 17:26:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NILFMc8orFLeILnOzhcCXAv2DwKcxZmJWaOwBodFmzw=; b=3M15HAO/VBO5H+OFscoIDVGmCV N0ntkU/VkgpmJHqHSUiL7aK9jxzi+ZFWuZy5zPlYIpDc+bePSoj800hY1FDoeuNzRnLfbgyd15hih df4H/1b1B8ICUCYXzCtRWeg6Ei3wXEgXCbGf6DV1BcrFQuj3bMfLwgZG9CmW8Q/A5e28=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182202: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=6db03ccc7f4ca33c99debaac290066f4500a2dfb X-Osstest-Versions-That: qemuu=71934cf6bf878f82dac3fceb7d06d293ec3f6f8f From: osstest service owner Date: Sun, 06 Aug 2023 17:26:37 +0000 flight 182202 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182202/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182194 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182194 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182194 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182194 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182194 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182194 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182194 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182194 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 6db03ccc7f4ca33c99debaac290066f4500a2dfb baseline version: qemuu 71934cf6bf878f82dac3fceb7d06d293ec3f6f8f Last test of basis 182194 2023-08-05 09:23:27 Z 1 days Testing same since 182202 2023-08-06 01:59:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Matt Borgerson Paolo Bonzini Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 71934cf6bf..6db03ccc7f 6db03ccc7f4ca33c99debaac290066f4500a2dfb -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Aug 06 18:56:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 06 Aug 2023 18:56:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577731.904728 (Exim 4.92) (envelope-from ) id 1qSivD-0000DD-QQ; Sun, 06 Aug 2023 18:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577731.904728; Sun, 06 Aug 2023 18:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSivD-0000D6-NP; Sun, 06 Aug 2023 18:56:11 +0000 Received: by outflank-mailman (input) for mailman id 577731; Sun, 06 Aug 2023 18:56:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSivB-0000Cw-U6; Sun, 06 Aug 2023 18:56:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSivB-0002ac-Eg; Sun, 06 Aug 2023 18:56:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSivA-0002wT-VC; Sun, 06 Aug 2023 18:56:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSivA-0001sF-Ui; Sun, 06 Aug 2023 18:56:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+s1m4Ai0MiPlY4ctem8GLCabzD50QYZBWhPrY66ASDY=; b=lYsbgzZBiy3mrETiRDtdLji7X/ 3nSWQQBpoFYxxTl3Omt2ODSDsvX8o2TDssVTjtGzF1wU9zWEe4kkKi269nBhtPNvH0BhLm5xjtOJ+ mY0R6NvY2Sb19vnRbAJ3NlKoVFoubvpynaAUMoOf/pElRWh9kXPRGQY0sN4f3r3fPSKQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182203: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64:xen-build:fail:regression xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e55146071de9257d70bd157047700071d0007622 X-Osstest-Versions-That: xen=e55146071de9257d70bd157047700071d0007622 From: osstest service owner Date: Sun, 06 Aug 2023 18:56:08 +0000 flight 182203 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182203/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail REGR. vs. 182197 Tests which did not succeed, but are not blocking: build-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182197 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182197 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182197 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182197 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182197 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182197 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182197 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182197 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182197 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182197 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182197 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182197 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e55146071de9257d70bd157047700071d0007622 baseline version: xen e55146071de9257d70bd157047700071d0007622 Last test of basis 182203 2023-08-06 08:11:01 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 fail build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Aug 07 01:10:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 01:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577745.904741 (Exim 4.92) (envelope-from ) id 1qSolW-0007ro-Nt; Mon, 07 Aug 2023 01:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577745.904741; Mon, 07 Aug 2023 01:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSolW-0007rh-Ka; Mon, 07 Aug 2023 01:10:34 +0000 Received: by outflank-mailman (input) for mailman id 577745; Mon, 07 Aug 2023 01:10:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSolV-0007rX-Ct; Mon, 07 Aug 2023 01:10:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSolU-000594-Ta; Mon, 07 Aug 2023 01:10:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSolU-0003Ps-EX; Mon, 07 Aug 2023 01:10:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSolU-0000A4-E9; Mon, 07 Aug 2023 01:10:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=om0k0CVJgzkweGfo5G3Io5sy60FIrlRrUZ0IsyAvKvI=; b=xEizFjAs+vWQ0qNAzp/2nOKv2z hRkzB/4wvliymzDUle9gRYfmRNe29dtbk3kj7mjtwsZE3VplJUY7dg7H0DEHZTSZ8qbdiJIvJtmCF z80pv8Z03Ks/c2GsugKCuBLHs77Cey/EPaVtOnBvS8odMZDN57IS7a3Q38P87Hgmlt9w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182205: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f0ab9f34e59e0c01a1c31142e0b336245367fd86 X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 07 Aug 2023 01:10:32 +0000 flight 182205 linux-linus real [real] flight 182207 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182205/ http://logs.test-lab.xenproject.org/osstest/logs/182207/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail pass in 182207-retest test-amd64-amd64-xl-qemut-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 182207-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux f0ab9f34e59e0c01a1c31142e0b336245367fd86 baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 112 days Failing since 180281 2023-04-17 06:24:36 Z 111 days 202 attempts Testing same since 182205 2023-08-06 15:25:42 Z 0 days 1 attempts ------------------------------------------------------------ 3911 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 658205 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 01:25:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 01:25:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577752.904751 (Exim 4.92) (envelope-from ) id 1qSozr-00010y-0J; Mon, 07 Aug 2023 01:25:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577752.904751; Mon, 07 Aug 2023 01:25:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSozq-00010r-TT; Mon, 07 Aug 2023 01:25:22 +0000 Received: by outflank-mailman (input) for mailman id 577752; Mon, 07 Aug 2023 01:25:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSozo-00010l-R9 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 01:25:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43f85dae-34c1-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 03:25:17 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB9250.eurprd08.prod.outlook.com (2603:10a6:10:419::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 01:24:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 01:24:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43f85dae-34c1-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZKvyOC58XQDs0LTpWiivs7BI1mHoW6Y8mt8Mm4KVTHrYh7tQabMk2aUyrND2A3LkAyxcOtoF2kyBy5+epbsq54Z5fuS6V2m0fQ3yxtlJ+OPRSXYJiSaBEiTz8Hr6C3cd3TsxAxf21m9obRTjPwLGgIPTUz5znQErSJwlQW5tuTHs3Qm3HR8UM5yquDKj+8UIjZwhJe8c/Ke42todkDWRncVxnNbx6+EUFbKB2GbQgTAxuVLWAyFCa9bKjrzh078hplH/eBqh9nI9b2xM9I91tGokvDQwhBVuvVxDJpJi2GPG/Cd46tubNusgvDXLb44DrbborcifgGQcFxI9zR6aXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kGr4/CenZPJh4RmpNvj50HIldEWy/K/CGryRf+NrvgA=; b=WbLKefqSO/Oe1S1OCs0cbONs6j0ZOLGCk2F42ELWk85WuaVNuDGIZY6MUlVdhCJjUhT0zkuXZz0qnHOZ9j8vcBljCfYFHPlPwvTTpdqCcaWjp0f0mT9OiVbm/W++8g61gBLr7leOpY5ebkduSRrbYz/ZH8g/0GnEvF+A//UAvJXoo9TR6cX24RVdsuc5Pg/MokUMprK62FjD22XdZeAyEfH+IDLNRbg+fzJPiMmA29CZaAqP8mpjzlLTIKrzlqZA/2PQVv7+kabAJiByhe36PYjUXMSU//nqwmPpTfC5Q70PVXtBwM84HHEPcdYf8Ts7HWUmEnNwbzWqJqVoBgYEBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kGr4/CenZPJh4RmpNvj50HIldEWy/K/CGryRf+NrvgA=; b=JNH9hSPNDUdqLdms+eJEvwsZeIZ5uB02y+aeryLwDNd9kYeNHeOCmAHiHj7E/hNvGVocDn7ffD/dHf5oSmNVF4JaZ+995gWX+VyN/iCvEP6B8f+GHaLNBkdmHMBL+uNQQdr4UNysahrVri8sL2ZBU11bbg6SYYhBJBGPHMEf7z4= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: "community.manager@xenproject.org" , Andrew Cooper , Jan Beulich , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Julien Grall , "sstabellini@kernel.org" , Bertrand Marquis Subject: Xen 4.18 release: Reminder about last posting date Thread-Topic: Xen 4.18 release: Reminder about last posting date Thread-Index: AdnGpQJJnpHQXjHHQ2KSH/TFd+8Fbg== Date: Mon, 7 Aug 2023 01:24:46 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6C11B5EC6797274CB7A445AD076849D7.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DU0PR08MB9250:EE_ x-ms-office365-filtering-correlation-id: 1c24dc4f-d6b2-4d82-5259-08db96e515f3 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: otxbBgooWT6mOHQ/3/4z19kGv3nPb5a+pi3sWpZOyo14OFIRJtqbjjdy6uFXfUgYamZO99SroZCU2PmB02jI8vAwBTJhArzuhmR8+FOZuhBY3iTHMTcuPu/uGS0Gun5KQzU0cVtOwHgYWoJgPFr6ysZL0bY9O4WdIhXUJMecdJo0ik6E+0fW3ZLnQO4hmQM4SIkQYlyaiLYcSdkznxfm+ktAyJ9TZi9bsnLYg98/KL/n04Y83vKet7hWHX8UxhuX9kG3f5YbISytQUsRvQu86ZdvNAAF9dk6vQfk2H4KwQS5Ixn3J8RPcRHvrJHUG6lMOUoPR31kQTSnluH2Mm3Q6TMIbPYPJyfrhmMphLlbum9lW9r0LsjXntBryVDVBvhAOZNk0fBwL+AmIvBSbH562tY5v/7YBt47PGo6XeFRTCVCANaN64XTXeYnPBBcJH+eXCBv5ndffQ2a5Zm2Q6IQwoLMbd8E2Tm9aqPEdJ8JBb5gPx3HD6kgEVfD0COzPmRL2fffsuqvPGVuMekNeyxskv0292rbJuMpjlcTLSg++m/eYcIPU8xM2o6yGhRoIvQKPwWo4PBWl+rKxodq4zwe8GGAW/7zq4Ne7YzqpIHThrT/UlLO3FMtuycONUI9N3AMjwWhS7etfqF5Au5fdrK4xw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(186006)(1800799003)(451199021)(83380400001)(55016003)(54906003)(2906002)(6916009)(4326008)(5660300002)(8936002)(316002)(4744005)(38070700005)(52536014)(8676002)(76116006)(66946007)(64756008)(66446008)(66476007)(66556008)(38100700002)(86362001)(966005)(33656002)(478600001)(122000001)(71200400001)(9686003)(7696005)(41300700001)(6506007)(45080400002)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Vo6p5DnxMo60luVG+jm7r0x2h9/kStUhMJAP/fUJhTqhUBM0TQz6Sm6cvG?= =?iso-8859-1?Q?Tlq5FuJ8Z7PWc7u1Qeq+UTWoFbgi9IYxDT98Axq6aJLzd1BgrrdFYRdYPU?= =?iso-8859-1?Q?Zex8o00nJUm3wOQ4hvqL66gS2OeOt27vSRtv/iisTrxvdxLQaFc3J+TEn0?= =?iso-8859-1?Q?044ETo+NIPjXf6akrm8dcmTxUUiPgObdOO97L4y97nFSX/pJplPo3a5c6i?= =?iso-8859-1?Q?UnVV7vwY4Z0R9EROA+RbxnIUTLXoxn5PpP+aelcwDMnjLlwv4Gbyj5BqxY?= =?iso-8859-1?Q?ag2uRcX2vuvJuHbuUbHy7ixqaE/gdQe2q4QHCegJuS/0kpJjMwnxrJOb5x?= =?iso-8859-1?Q?JbwgW5Wa2k202VCf78TznAv4MIN2cL7T37iUKbBJjmVo6mxNKxOP8C8RAz?= =?iso-8859-1?Q?uj5PX4mOCNyPFyFxuyin//HxL8lQUoO4YZoObAc+NArak46r5JB6GdHFts?= =?iso-8859-1?Q?4WRTe0GqvbsJDsawsUE9vwINojr51xCdBRdEWOOQoy05G36apFwQv51Hao?= =?iso-8859-1?Q?kLPWor6AmdUIeCsGNWysgyD3iyjVYoiEcPhBHRQk8Xm+1mN9OlrhEOT/9S?= =?iso-8859-1?Q?S5CR8ieD30ZLBNhFMJtTPtXj86uTbCJzWBbUAAdPd0O9UsW6pbVHj8JGZG?= =?iso-8859-1?Q?k1KZR3sYDTlCVv9ndAAfLxKAGZqlsvLlyBHbYickMPeydbKuTLRqhza88r?= =?iso-8859-1?Q?/UdZY15OKGN0wIK/fkrDkdd8uM8mW3W324iU5gGcsCnuT2zG8UUNea6pw5?= =?iso-8859-1?Q?Z4w8qynu5pVl3GWLooKX29wMt3xefiwnJc6qnTkvSHlCNe/wqoLb8JRDuu?= =?iso-8859-1?Q?yqYL9NOiNW5U44heVrFQ3XsBO3pg3seUvRT/66f1AK9O42n0Mep5mXcdn7?= =?iso-8859-1?Q?p6bYhd8as7okrIA3SowdWYF40eh8BTTLJONeqRX6H55BUgtyR66Of4CeoE?= =?iso-8859-1?Q?5rg2kSbC8JFuSucVhJkBvUyxeX0N+8nQQ9zH3+VsGn1umfcgLCzd/6tydW?= =?iso-8859-1?Q?1b0N9nZ3TYaiDMkOXHrEQxhfaVroMX9naZZxgpTYXCsQ/Y2+bQttAwK4s8?= =?iso-8859-1?Q?LAA00Ul0hyxp9GgBtRKcOYaM3MyGFPBNJCMNeqlBSPJwjEfVkTqs7kOgBJ?= =?iso-8859-1?Q?+sc+Qce5ktCbuFcHfUa4xtw0nok9R270wOi3NoSabq6sx+fWxYXldVRTI0?= =?iso-8859-1?Q?ESg+1oSIZQ947nyvg8REArJPPXtgP8EOJeAVc/hwqrNOHnqQVoedD0ituv?= =?iso-8859-1?Q?xgFrtlsdCGoz5JWRdyfXcol+6v2ywgWqXKolgWFFmMndnr20Vw21gC4znH?= =?iso-8859-1?Q?/52oW5bxdtRiYC6jpyUzhQb/mp1Y44LZ2G6zJBHCEy2OCk9f71jCw4gfD+?= =?iso-8859-1?Q?HOl3+qPGQfBMUTXgdyD11O+gr2RO2RDXme3wEsZ7jz06BLKSINvlehUeed?= =?iso-8859-1?Q?1R7zzh38BRgA4n0x57FDX1HSEWrtcmsYhAy8Rl8JwwILfoqVORIWn2Mhr8?= =?iso-8859-1?Q?WfjAcyzvxGJhMru1G9oq0p7LDRbvnVZBuupS4mGkbXKgfZ7zkwwLqEIFYB?= =?iso-8859-1?Q?R3Nc2SG4P1/WFiJdlZkUyPLx5938H92pvecuJfEKybd5PbOcZ441J+gK51?= =?iso-8859-1?Q?lkC97t5YDlS4XAXOij/MLwWOir1M9SAxLI?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c24dc4f-d6b2-4d82-5259-08db96e515f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 01:24:46.2581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M4Hzt027otQ+MG/yVBVr66jsIsF1lMOi9cPeFXcz8vqRen3QBtpa0GKr8Lva0/aRlLMA2CiHOwkCGaMJldRrGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9250 Hi everyone, Following the release schedule discussion in in April, I am sending this em= ail to remind that according to the release schedule [1], August 11 (this Frida= y) will be the last posting date, when patches adding new features are expecte= d to be posted to the mailing list by this date. Also, note that we currently have 1 release blocker [2] which might need some attention. [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB59260= 9@AS8PR08MB7991.eurprd08.prod.outlook.com/ [2] https://gitlab.com/xen-project/xen/-/issues/114 Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Mon Aug 07 07:14:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 07:14:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577759.904761 (Exim 4.92) (envelope-from ) id 1qSuRQ-0003dY-UV; Mon, 07 Aug 2023 07:14:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577759.904761; Mon, 07 Aug 2023 07:14:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuRQ-0003dR-Rv; Mon, 07 Aug 2023 07:14:12 +0000 Received: by outflank-mailman (input) for mailman id 577759; Mon, 07 Aug 2023 07:14:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuRP-0003dJ-GY for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 07:14:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff506f1a-34f1-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 09:14:07 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 984014EE0737; Mon, 7 Aug 2023 09:14:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff506f1a-34f1-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 09:14:06 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/08/2023 23:19, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> The variable declared in the header file >> 'xen/arch/x86/include/asm/e820.h' >> is shadowed by many function parameters, so it is renamed to avoid >> these >> violations. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> This patch is similar to other renames done on previous patches, and >> the >> preferred strategy there was to rename the global variable. This one >> has more occurrences that are spread in various files, but >> the general pattern is the same. >> --- >> xen/arch/x86/dom0_build.c | 10 ++-- >> xen/arch/x86/e820.c | 66 >> ++++++++++++------------ >> xen/arch/x86/guest/xen/xen.c | 4 +- >> xen/arch/x86/hvm/dom0_build.c | 6 +-- >> xen/arch/x86/include/asm/e820.h | 2 +- >> xen/arch/x86/mm.c | 49 +++++++++--------- >> xen/arch/x86/numa.c | 8 +-- >> xen/arch/x86/setup.c | 22 ++++---- >> xen/arch/x86/srat.c | 6 +-- >> xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- >> xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- > > There are missing changes to xen/arch/x86/tboot.c > Thanks, I'll replace them. > There a few stray changes below. > > Everything else is correct. > > >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >> index 80ae973d64..9c6003e374 100644 >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -1163,7 +1163,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> } >> else if ( efi_enabled(EFI_BOOT) ) >> memmap_type = "EFI"; >> - else if ( (e820_raw.nr_map = >> + else if ( (e820_raw.nr_map = > > stray change > > >> >> @@ -1631,7 +1631,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> unsigned long e = min(s + PFN_UP(kexec_crash_area.size), >> PFN_UP(__pa(HYPERVISOR_VIRT_END - 1))); >> >> - if ( e > s ) >> + if ( e > s ) > > stray change > > >> @@ -1771,7 +1771,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> >> open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, >> new_tlbflush_clock_period); >> >> - if ( opt_watchdog ) >> + if ( opt_watchdog ) >> nmi_watchdog = NMI_LOCAL_APIC; > > stray change > > >> find_smp_config(); >> @@ -1983,7 +1983,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> >> do_initcalls(); >> >> - if ( opt_watchdog ) >> + if ( opt_watchdog ) >> watchdog_setup(); > > stray change > > I looked at those, and there were trailing blanks on those lines, which apparently got trimmed when renaming the variable. I think these changes are ok (though maybe they should be mentioned in the commit message). -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 07:16:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 07:16:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577765.904771 (Exim 4.92) (envelope-from ) id 1qSuTj-0004Gd-Cj; Mon, 07 Aug 2023 07:16:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577765.904771; Mon, 07 Aug 2023 07:16:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuTj-0004GW-A4; Mon, 07 Aug 2023 07:16:35 +0000 Received: by outflank-mailman (input) for mailman id 577765; Mon, 07 Aug 2023 07:16:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuTi-0004Fe-5I for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 07:16:34 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56a51532-34f2-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 09:16:33 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 68DF74EE0737; Mon, 7 Aug 2023 09:16:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56a51532-34f2-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 09:16:33 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH 4/6] x86/include: address MISRA C:2012 Rule 5.3. In-Reply-To: References: <40823fbaa9e0a9b026e5ff3b01af9d83583889fd.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/08/2023 23:24, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> s/mpc_default_type/mpc_default in 'xen/arch/x86/include/asm/mpspec.h' >> to avoid clashing with function parameter names in 'mpparse.c'. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> Even though the global variable does not seem to be used anywhere and >> is >> perhaps better to remove it entirely. > > Please remove it > Noted. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 07:18:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 07:18:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577770.904781 (Exim 4.92) (envelope-from ) id 1qSuVt-0004vE-Oj; Mon, 07 Aug 2023 07:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577770.904781; Mon, 07 Aug 2023 07:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuVt-0004v7-LE; Mon, 07 Aug 2023 07:18:49 +0000 Received: by outflank-mailman (input) for mailman id 577770; Mon, 07 Aug 2023 07:18:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuVs-0004uz-H4 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 07:18:48 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a68b9b2f-34f2-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 09:18:47 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 7565F4EE0737; Mon, 7 Aug 2023 09:18:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a68b9b2f-34f2-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 09:18:47 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: Re: [XEN PATCH v2 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 In-Reply-To: References: <987ebd142ebd69ed062d74f7eb69c23759c51636.1691135862.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/08/2023 22:47, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> The extern variable 'irq_desc' defined in 'irq.h' is shadowed by >> local variables in the changed file. To avoid this, the variable is >> renamed to 'irq_description'. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini > > You missed me reviewed tag from the previous version: > Reviewed-by: Stefano Stabellini You're right, sorry. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 07:18:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 07:18:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577771.904792 (Exim 4.92) (envelope-from ) id 1qSuW3-0005Dd-1O; Mon, 07 Aug 2023 07:18:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577771.904792; Mon, 07 Aug 2023 07:18:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuW2-0005DW-SM; Mon, 07 Aug 2023 07:18:58 +0000 Received: by outflank-mailman (input) for mailman id 577771; Mon, 07 Aug 2023 07:18:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuW1-0004uz-8x for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 07:18:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0616.outbound.protection.outlook.com [2a01:111:f400:fe0c::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab9c42da-34f2-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 09:18:56 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9667.eurprd04.prod.outlook.com (2603:10a6:102:242::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 07:18:54 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 07:18:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab9c42da-34f2-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IlRUP86vlvHRs4mqMOmLzuRLCtQ4X+7xAWgYSIOA3uxPhNFD5GpE8FYg2ckSr+3m5Ji4SlZEMCP7iqE9FG0dw8ENtiISQelu7rFMPXimLfPXAaOXAaevH7RtvwZQgFrIORIqLPktzkf2jeJ/PoGemp9z7D0zl662uNKlrXRO6aNVpTU7KpArIsK3Gfys2BYIwWarRmm/oLjV9Iz+QuHfzQs383XGkBECXEMLorW6axC/9jgRo6ohc9/mJSrkPxcmbmw06PGER96EPhSYGOkoiCSAff6//OQnvV+m7u1Y0KDQiAc/wsQOPmCfCSv2qvrzXfjKqSeR5js4yH7NMjpaRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p8KXkDDb9QotkUfJGJhCzIzECK3RfULau+L7tJYIzXk=; b=aXWqIlVLlszkn/3+4599+WvOByecjrE1TkWazhk7Yi1noumse/xDDX/lBBEbGHVDH75fVGMA8t3JeHMYwrE9QBOEghHIeHhtF8thQMn8kQYvwLVS55Ybf59RgDi4f9dfJfaMBvyR18pe+CkR6B5VJgQ5pMjtgmTizVbcU4j0uzC7TEcp6PEkgxYtd3gvSjuRDbOWYRTgG9GQBjEXjViWE1uLc4uWNLoCOBvFBb0OoNexxRwNhVP4maiqfaV6/d0LkjO2b0gFSFpA6dAHMxKFemvutGvaap/ZERyLw9wl8A/40mKdTGnB7zso+Dq2SpOapGDPIJyJR0gagf5YjdtS7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p8KXkDDb9QotkUfJGJhCzIzECK3RfULau+L7tJYIzXk=; b=gosAww/DqkWnb1RLG63qUK0poRiGLUkqE17cp3B22Z2sEHffmpswylxfc7rsBtE0k0CJcjtl0qGUmop9niRWWhiZJvUe0Ul3EV+byJj23L6PRpbXrcodqXmrV+f/H9v5VdkQwnZhgEXUpA7Z+Vab2Vq7wmsLGwY0JYsK/jOcu8NSVAlYNfQ540Sm+j+GYa7hCAQ+x0GctO6SfQM3+NzMctFtDHE0mTwaWSdLEFp9uU9yvZDRF+4XhoJoKmlXqQTm8SvJOgZmdhkVUxsSO/l5SS0NXKqLIa55zScjnJvB0AYd48iZV6uZKIR2Jb0bIq1q++816Nk1Q8Hamw9+KZI+6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 09:18:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Stefano Stabellini Cc: Nicola Vetrini , xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <204bf3ffcdda04d6d6cf072c42b78720e1e85b4d.1690985045.git.nicola.vetrini@bugseng.com> <6a5260299c5822abfbd74749ebea8f8f@bugseng.com> <8672f79a-3e44-1cc3-b448-9ee4a4ed9090@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9667:EE_ X-MS-Office365-Filtering-Correlation-Id: a8bb50f3-77ad-4bde-c77f-08db97168e5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: drZaDt6VrnruMb2XZxYiAbbPPUD1to+556gaxB0DD2oAoEhQ6lPkYBTfH/4LwxBDsnXHH4YY6NdTquv85q55Ia4SJkDZrZlsJTbbRO16jPkElXiaCV152oPuz+31MnQyhgTYLIXENzo+Bu09tThZWJyx0ndHm5hYEmeSqQXqFcXlcpOqr4by+bi67S2/TmFa5R2VoHamahtFfTnWKes3nVb4xMgh5a/LO/OZky50JWzldylXKN9YELD0vGMJm9pdrUlLxOd1d/JlsDIx80AvjNqx0KhSxERGXg5wI6hSipQVa8tmtedm6z51PtP0fqqzKq5ULqpyHvcoddQTqFhxDFuonP65uOdTMn4err8PAWeae6pS0ZHTVMZVyjeuqBX5iG9IzgI32NwRbFik3Ufs9Kh6TEIBlBUtOLIoDQiDUP7/SZexDAFGTvxFNrXwiuS/E7lv6M1p6qcn8qaJk8T/bACvPf5Vr4vOJSyQN8uyYkChAhzNKh/htkIO1QAxqjNnDzO74l7G7VYqyAS25+SbZna+H1B+9AKC6zIE2XOFEQT3nZymZM5eUtnm/4PUPg7FieHHlvO10ML1ljn3/IGIjv95qAsju2Vp2zqKPiir7hK487fACupSYpFs5KTa6hTCOx2pZpl7YW12BmLpGbgokw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199021)(1800799003)(186006)(2616005)(6486002)(478600001)(31696002)(86362001)(6512007)(26005)(36756003)(6506007)(53546011)(41300700001)(8936002)(5660300002)(316002)(8676002)(7416002)(54906003)(2906002)(4326008)(6916009)(66946007)(66556008)(66476007)(38100700002)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGVTbWVDeFpmbVl5K2MyaE9PSG0vV25pUVhqZTJ0MmhOVFMrVkJMV0JRUjRM?= =?utf-8?B?WDVtNGhDanM5bXd4WjB0dFRhSEpKanM1dTAxRldERklJdm1DcHZXdGNKTnJk?= =?utf-8?B?NWhCY2pSZHpVbjhGQUgxOWNxYzk3cWhjbHM4bVNWQkFOcG1jdWdDblBoaXJQ?= =?utf-8?B?Yk5RdGxoZWdOWmdadnloOWdDc0FMWDIvYXNOSDZIVnd5UFBRRWpqNVFCRHlo?= =?utf-8?B?WG5mY0g1a2MrelgyNlcxaWNzYlhrSDgySFZOTGZaNnJZTms4dmFJdkl1cjdm?= =?utf-8?B?WXFSeG9sdVZQdHU2cGkyOEcySkl6QmszVC9JWFBxTEVUTlROallGNDZ0clR4?= =?utf-8?B?OHZMS0dNUmFZaDJGUWVCNmU0ZXkvSUNzZk80c0FEY1JvYlZmb0J6eGdVRFc5?= =?utf-8?B?UGNpVk9VM2lDcGw0Q1lwQkh6WHNVaVNCa1BESGR2QUJ1WHF2UHRzeGhpaUEw?= =?utf-8?B?blhZRlNCanhDNFFNZzJtcDRvNEQzR0NrZDZ0NWREOG51TjZDdmhlWXV6bDJQ?= =?utf-8?B?TS9lMzd6WEx4VG9JZmR5VzBzU2pZZWVyNFdLb1lEb3J0S01DbUYweEtuYTJW?= =?utf-8?B?NlR3dy82U0lsaXliNzBMaXJVK2pKWGx0dEVuai85N1VEODdlR0ZHRU1tc0wz?= =?utf-8?B?cHBsME1kQjU5bjB3eGNGWVhnQnpmTXVlM3piRWlGZkFZNEVrRVYwUzBhWGJ0?= =?utf-8?B?WktVUngwZlRWdUhhcTJWb2FrZ1N4Z3B5ZzlTWGtYd21XM1pxeWs5MEE3SWVE?= =?utf-8?B?VWZrbS9jL3FvTkF6KzA4dGRISTBRaHlFek9TdEVEN0hkR2c4SFdRQk9KZnBK?= =?utf-8?B?SElhTnRidWdwd1JEY0xLeDBya0k5NkE4L1dOM1cvemZGRnEzQ21YT3ZETkJG?= =?utf-8?B?VDlMVXFuSGFDY0s1S2M3ZlJqYjZzbVVqcnhYZndWVDVJWEJoa05DL1BsSnBG?= =?utf-8?B?Q3JIbVgyb094c2x1OWVWVUpKc2dFN1NtTUx2QnMwT2lDbTNOUW5BcTkxNmxr?= =?utf-8?B?SWNxZks1TkFvVURXU3FYVVgxUkpCNkg5T0ZrcVh4OHZIdlNJZnpta29lSzg3?= =?utf-8?B?ODhZM0dFOHdyOFlMdlFjTVI1S3BHMkk2TzlGNUlPRTJ4ellZQlJJUGJSdGNG?= =?utf-8?B?Z2ZHOStWYTQ0a1pIdHZoQmRRSkdzUGppQ3BJSFI5S2FpbEgrNUxpajJ4T1pB?= =?utf-8?B?ci9rYUlMODRIRkhFS3ZkYWxLQ3pucHNpMk1UVkdnS20rYzc1cU9IMVpKMWI3?= =?utf-8?B?dFNMbTlXOHliT3R6aFJLOHRKT1ZOLzRlVlRvK1FtQnp1bHBjcHQwSlI3VnpP?= =?utf-8?B?eSswVnZFeUZRekZpT0xYV1ZNVEdDblR3TjN3d3dqM0JER1lDNDVRcUdWUjFu?= =?utf-8?B?aDdMc3QrblFES01BRVFXU0tveElpUWJSOUY2dlIvcDludzdYM29ObHlJRXk5?= =?utf-8?B?bEZhUGkxREtqYmswZEY0UUZhRUxyR2pWdDdMd29VZ3RraWtsMHZpQnRrSTV5?= =?utf-8?B?QXc0RTVUNHNGSDlYWmdTUE90eDA2TVFxZHNxa1ZYTGtSVFNlYW55cCtXeExQ?= =?utf-8?B?cnhvTytDcmNWbXZrWmRqaE1BbzN1a3dabm5hZFl2Y205NmZEcENoSnBlbXll?= =?utf-8?B?S2w1UnhUVU5GMGN2TDlkZytCU3BmTksxZ0UzeHdrV0xQbWF4SDdYaFltSkEv?= =?utf-8?B?cjlPWUVSSzUzSVhaUTk5Rmd6aWNOc085WmpQNWtnVlpFeHFrZmc3VHBSaWlJ?= =?utf-8?B?dkZWTXRGWG9UVXRxUTM2MFAvaVowd3BMUXRzNTVPUDZWN2NET0JtNTBGeUFp?= =?utf-8?B?cWgxdWRLa1JERHVqcGc4b3ZjS0ZKV1RzWE02aW8rd1E4R0Rnd3E0UzQ4bVQ1?= =?utf-8?B?UjVHUTdoblFhdldidHJ0YjhKSHhNcStQN1FFZVNZSVdYeE9LakF1T0ZvTWNn?= =?utf-8?B?T3JpSFA3Vm9HSHB4cXRlL2dDTzFFa245TVJneEVVbkgvdFFrRTl6WGcyNzRz?= =?utf-8?B?OVd3TjFIM3c4d1pjLzBkNW8yNEJaTitjMkl2U3diR2FJN1F0VEhvcG9oZmxO?= =?utf-8?B?Y2JqSTZ5Z0tzcGdNTWFwRjE5UGtKdHpnYWZhNGYwZGp5NndUd0Z6aGZwZElF?= =?utf-8?Q?Zyb6uAidJbsQqNb6Ub0ZxAFAE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8bb50f3-77ad-4bde-c77f-08db97168e5e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 07:18:53.7679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i/2+w8ROR0tUAK0ccW2hEE8d66RPepe0/n8SeSF0ZTkYKRVKkGN1+mr0uJv1VJQEcLYBiEsnotLcSMS7j3BnoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9667 On 04.08.2023 22:26, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Jan Beulich wrote: >> On 03.08.2023 16:22, Nicola Vetrini wrote: >>> On 03/08/2023 11:01, Jan Beulich wrote: >>>> On 03.08.2023 04:13, Stefano Stabellini wrote: >>>>> On Wed, 2 Aug 2023, Nicola Vetrini wrote: >>>>>> @@ -1169,8 +1170,6 @@ static void cf_check >>>>>> irq_guest_eoi_timer_fn(void *data) >>>>>> >>>>>> switch ( action->ack_type ) >>>>>> { >>>>>> - cpumask_t *cpu_eoi_map; >>>>> >>>>> It is only used by case ACKTYPE_EOI so it can be moved there (with a >>>>> new >>>>> block): >>>>> >>>>> >>>>> case ACKTYPE_EOI: >>>>> { >>>>> cpumask_t *cpu_eoi_map = this_cpu(scratch_cpumask); >>>>> cpumask_copy(cpu_eoi_map, action->cpu_eoi_map); >>>>> spin_unlock_irq(&desc->lock); >>>>> on_selected_cpus(cpu_eoi_map, set_eoi_ready, desc, 0); >>>>> return; >>>>> } >>>>> } >>>> >>>> This pattern (two closing braces at the same level) is why switch scope >>>> variable declarations were introduced (at least as far as introductions >>>> by me go). If switch scope variables aren't okay (which I continue to >>>> consider questionable), then this stylistic aspect needs sorting first >>>> (if everyone else thinks the above style is okay - with the missing >>>> blank line inserted -, then so be it). >>> >>> Actually, they can be deviated because they don't result in wrong code >>> being generated. >> >> Only later I recalled Andrew's intention to possibly make use of >> -ftrivial-auto-var-init. While, unlike I think he said, such declared >> variables aren't getting in the way of this (neither gcc nor clang >> warn about them), they also don't benefit from it (i.e. they'll be >> left uninitialized despite the command line option saying otherwise). >> IOW I think further consideration is going to be needed here. > > Let me get this right. Are you saying that if we enable > -ftrivial-auto-var-init, due to a compiler limitation, variables > declared as follow: > > switch(var) { > int a; > char b; > > case ... > > do not benefit from -ftrivial-auto-var-init ? Yes, that's my observation with both compilers. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 07:27:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 07:27:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577783.904800 (Exim 4.92) (envelope-from ) id 1qSudi-0006ze-PZ; Mon, 07 Aug 2023 07:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577783.904800; Mon, 07 Aug 2023 07:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSudi-0006zX-MW; Mon, 07 Aug 2023 07:26:54 +0000 Received: by outflank-mailman (input) for mailman id 577783; Mon, 07 Aug 2023 07:26:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSudh-0006zR-Mv for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 07:26:53 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20613.outbound.protection.outlook.com [2a01:111:f400:fe16::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c76ee96c-34f3-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 09:26:52 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8331.eurprd04.prod.outlook.com (2603:10a6:10:244::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 07:26:50 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 07:26:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c76ee96c-34f3-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JCG3DgBb66QOLEioPB41q4iDcn2BD077fliNyj2Idh7FQaKONL+8R+KbWUj1ISVbf0YeG+B1HgZoOY0tugRBOGdojzKMcfesOq0LjdK5WhTucO9lPjigxTrzti5TWYO3RpDIKjdxiBhkDnrJOa56xijlAATRLxaYw7CFfdy1NEVqkhV24M6Ui/Mke16wCUbaX1eb9VgHC6oR+Wo4k36UAdSFvhlXyPEQSirEuWElMRMSWqZZMOzJPavJQR5ox19NJoiH6+mqmZWPPVzF+0LQC0aDJR1ETHKb1c8sseokZO+aQSq2rsH+l/Lz9KLEBut+xts4tn3na9NJUFuigWwITw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJu3C6ooQ2gGorMkv0ItusmU0mDmCTJKQYDF5xjDWOQ=; b=AMUreFfjVA17v7YqrAZemDnNIE8FkJl7nWSMXObAYaKSA7Aqx3ZUCwTQq1gxtXt/Oo+AvfxVZN6Lukh4KorceEmNAK8zo9ZlbTk+15a0WJc9gdfliHQzYAtlU4A9thGsGy07v1zwzUOGu6oROz3l92bCKyQ+zZ+RwSBHCVmf0muA3x2q27CVFmeO/5dxZSa3Q1iDH9MgIIbZ9hSWwSEROrCw59Xg8i4Z6fPvBbeIOS5elGeb/KDMtl1JKVc+8VFPgd7RTBnTjB3U9y/EwyC2NcbheyMoOoCUQKJUwvgSL5BxIC4KvzLb1QWoMlJ/nH9BSvNju5xljrOWlyLCQYjFWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dJu3C6ooQ2gGorMkv0ItusmU0mDmCTJKQYDF5xjDWOQ=; b=SRHBAYsu3JeOPYWstDlydJKMQ/HMtA/0r/rfH2nES+xBpx8hRo8/HvgWnR0+IpASeBySl0ZkazR+eDnN8cQ1FAVsh5s/YkXs8ta2BpAhGi0r4b9PUfwv9XlhiY6uqec4x5rIyCUDTlLN4m70xMr8SiRxPeuxwS4n2qjWUV4+M2VuWeMZhXtIymxQs8u1d7m7vDpXpVYbRwIMbuZR0NUZ8JVmX7v/CCsALUQG1iFXAoKod3AKZWgO5nWrtCLHaS/n7zdavF0QH4HrcORkRAZgHKIyeEGIKgXu9WU/4/SRezWiIgJdAJLpf1Gb3wnGfBsj0t+CnPl+YCHYEi1Pt+wkvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <57c5737f-a963-8cfc-5ec0-6b68bf9a5579@suse.com> Date: Mon, 7 Aug 2023 09:26:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: Address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> <95a6d085-cbb9-ecb6-134d-6e4d994bfd35@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8331:EE_ X-MS-Office365-Filtering-Correlation-Id: b5cf8c56-4db5-48fe-ac57-08db9717aa2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m5/pv2y+lS2s0IHA6Kfmkd8DDZ1nYVYbf/Ls1T1nIzPjaeFl0GPs03h2NXZUlTo1F8EyZEuTmqQr/SM96zLnzwltjtmOrK6UVn4qblrdB6P0yMJAJhG8oYX+tOHvECaHIdIJVRsHeSTIwvicOhdquKktTALtdutqRsdW/8YU+GakX5K+S6kjSzg49l0R5KympxARwqfTWUMzLovduDMRjQ/ATcvp96VvuWFFK8f4eiiDYCysgC6gmJyr6wKSAZWlSIHOnkj8gMJsJ7+ZZXWAfVArOA+9s1BF0riRG3jxhsblvPOjP5oR+WaPjnUt1sqHfXiN3Z4pCosFKbcHfs/gRsxbG4t3teCTeLGfcqV9k4R0Tw4Q2kIcHdFGAD0OP5aYsAu+5Aoq7EzMcfCWH3xKGzNqnzJnRJbTSc7sbMovqeA3I53Bh9QQC8HATInyIk7hHpJlxEK+xGtakjjj0mamJAiVTCv+7VBHYKmHfePwcTT4JeHiSVd3zHtmgHXfDMS/M9jUF6c7BpdDAWw45lUJS1I6+I9av6fM3becTz2RBCiM5F+dtwR75Kcwp+XmtUQv4yxvmr1NlOr+sqF9D4+iHLetCbWgtNRxtZ3GaqtPNniaWAzYmkJY/+AFmviL63OXP0myzaJ6HwSp1sT6FttNUg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(1800799003)(186006)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(83380400001)(7416002)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(31696002)(6506007)(53546011)(54906003)(38100700002)(6486002)(66556008)(66476007)(66946007)(6666004)(478600001)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkMybGRxSHA5UmhodGFSWk9Tc1Zrb0VsdjdtTFdZTG4zeVIvY0tYN205eFE2?= =?utf-8?B?enNmcmVkZFB3ZWVmS04ycjczMTgrbWNxa0M2Q0xDMmJMQ29xQjRpL2tmSWs3?= =?utf-8?B?Z0VkOE9EL21laUg3SUxkVEdiN2Vad0hkSTdQTVBBMDRLZzU1cjI0cWhrdUgy?= =?utf-8?B?WVhGeURVSlF3eklYREM3UzdzeDlpQXg2RmhINnlpSjhtSUUrc1dmNzQzdjNm?= =?utf-8?B?anZRcWZEdHFDMllqdEd5cHpWdVpmZlErakUvTUFZaGxqMTJBdEs0dHl0R1gz?= =?utf-8?B?cGZCNEFpL1l5U2NLMi81VHozTWF4UWZvYUFaYkcyc2tvMjF0L3R2Y2NiMlox?= =?utf-8?B?NUFFUGowMTVqcnNpQ0JjOC95RU11RTRUeDVoaEx1RlR2MitNVktnWUV1YUFp?= =?utf-8?B?ajRuNm1NUFNIUTNTN0ZHMTNBQTU5L1lqeHFZNW12SUlMaU1aekdTTmJGYlUv?= =?utf-8?B?dHJpSkU5YmZVbEIvMDBtWkNGOFBqUVBod1d3RTlTSWIrWXRQUzgrNmFEZEpH?= =?utf-8?B?QzlGLzRiK3Z2MGNuUVdINmVCUmhmdHZ6M24yczlvRDFSMGhPUHVRckZxbzJL?= =?utf-8?B?SXQ2WUM1Ry83c3ZLMmhuY0hSUUphUFJGY0o2bnZuL1FkNVE3YWZQamNTamda?= =?utf-8?B?YXlWUmYyMXBHRndEM0cvT2FMSjRsYmR1UkE1MWZDUlVYM3RhdUY3Q0ZCOEhW?= =?utf-8?B?YnJ4a21pQVZPUnN3d2ZnNG1QOUsyU1BQRFp3a2VVZ1lHZGY0eWEweVJDdHZl?= =?utf-8?B?MEJLMVVsbGppTHNUelBlZVdDYVEwN0ZMV2txN2J5aDZGczJlY0U1TGRQblY4?= =?utf-8?B?NE9UTXRPbmwrdk4xbXZBNG9HblJOQnQxeWZIS09Sb2xrRHMxTGlUWGNoZmd1?= =?utf-8?B?RFFiUE5jaVU5ODBwb3NodjlveUZ1cUZMWmZsQzQrcWRhR01OTU50OC80SHVp?= =?utf-8?B?ZmlUSm1zOXBYYUE0Um4yYm5zZmhDcC9xeHA2ZHdXWFl4N1lMMm9uM1Mrd0JM?= =?utf-8?B?U09kaWR3UURldmdrUDV4R1N5bncycjFET3JnY1B1dURlTmlLelA4Y240MmlY?= =?utf-8?B?OHJLbnduNVMzNGlmUmU3TzB5TlVZclhWMUtiaW1zRU54T1ZWZjVWc3R4SFMr?= =?utf-8?B?cndTV3lzTG5OSW9VWUc5d1MyVThyakxXVjk1S2hxWEhuRDltcytrbm1sb2lD?= =?utf-8?B?SFNjY3R0RmNFSXl6ZHJzYSswYVB0Z1ExZEpvZGdhRTY2Z2JVbkxMM2E3SlZi?= =?utf-8?B?SmM2ZHNDdGloZ08rWmptZVhIWGpZODNSa3I1dHJVWkhvKzhncTdWR0hEVUVY?= =?utf-8?B?TDJHRmpUQURORHdyajU1b2F2S3R2bkVvUDVvU3ZPeE8zNU9ydjNpNnh3d0Vu?= =?utf-8?B?THdZMDliWno0bktSazVZQjVIdENONjJ2TkZ2RkdzUnNJUVovczlQMVllNjgy?= =?utf-8?B?bXkzNCtVQjNLUmgzaTRCU1Z2SWVVeFEzanN0QmlnNmw2Tko1dmF2a010ZUVw?= =?utf-8?B?c0pWTjRkWWdBVVhJWkxvZHVxamlFYzhESjRBNGNIU2ZLWEZ1bHp2bEZ1ZGtN?= =?utf-8?B?d3lKbGY2MDJ4aHJBZnBDd1ZYVmR1VDJrSmhsRlV3aDFJQk1WMTZhWUhBeWZs?= =?utf-8?B?R241WDVHcXIxNmhnQmM0TUJwNFNCSTBqNlI0ajVpTGE1aW9kYmpQbXkyMUxx?= =?utf-8?B?RzZIV3ZrNmZLbVVSellMQi9jL3hqaGdSQ0FtTlZpakFKUFNUcVhZZzViWDQy?= =?utf-8?B?ck1VSHVuVzdOdFFlVlY4MGpGbkVDbG4rMnNxcjR3VmhabjJDRHN1WWkxYzc1?= =?utf-8?B?RnFoUmVrME0vWHVLNkxja1RmUURwY1IyUlNUSExKeW8rcGZ3QjZKY2JoYXJs?= =?utf-8?B?ZzRnaXFtWHFOdDFMbUcvK0dXc1J5MytibFNCTVBYVG5XNzJoOTdaWjE4UnBy?= =?utf-8?B?UVRYZW9hbjU1WnBORGlhRDNWR1JjVFN0ejVwUDVSNEtrZ29WVklJaTAxY0FW?= =?utf-8?B?SzFWWEU2SktoekZ6aVhydm4xZDBOV3JrYjdJYjlLbDZRRjJ5R1M2cWhLcU5t?= =?utf-8?B?eGVwSU44Q0xxc1ZKZTB3N3lZTTljWEFmSGs3UzBBU0h6S2JlakdLaFVvRHFn?= =?utf-8?Q?8CxGS1t/qgogzqIyjyLhrSHub?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5cf8c56-4db5-48fe-ac57-08db9717aa2f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 07:26:49.9462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WBIRWmvjIfHHzOrRT6+vVaZCH35TeM7rmS/9YRXHaMlta//sFkbUKcNUwXS29eeL+2eZb57++O3FlHo3MYW5IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8331 On 04.08.2023 16:09, Nicola Vetrini wrote: >>> 3. One possible resolution pattern is including 'acglobal.h' twice >>> (either directly or indirectly trough acpi.h, if >>> the latter does not cause other issues) like so: >>> >>> (assuming DEFINE_ACPI_GLOBALS is undefined here) >>> #include "acglobal.h" >>> #define DEFINE_ACPI_GLOBALS >>> #include "acglobal.h" >>> >>> this way, the rule is followed properly, though it's not the >>> prettiest >>> pattern and also clashes with the objectives >>> of D4.10 ("Precautions shall be taken in order to prevent the >>> contents >>> of a header file being included >>> more than once"), but then a motivated exception is allowed there. >> >> Not really sure about this one. > > If you can tell me more about why that header is defined the way it is > (i.e. why it's used twice with > DEFINE_ACPI_GLOBALS #defined and the other times without), maybe we can > come up > with better alternatives. The "Why?" question can only be answered by the ACPICA folks who originally made it like this. Linux inherited the file from there, and we inherited it from Linux. See also Stefano's reply on the matter. My guess is that the goal was to have just a single place that needs changing (besides consumer sites, where changes may or may not be necessary) if the type of a variable needs to be adjusted. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 07:34:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 07:34:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577788.904811 (Exim 4.92) (envelope-from ) id 1qSukv-0008Uu-HW; Mon, 07 Aug 2023 07:34:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577788.904811; Mon, 07 Aug 2023 07:34:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSukv-0008Un-EJ; Mon, 07 Aug 2023 07:34:21 +0000 Received: by outflank-mailman (input) for mailman id 577788; Mon, 07 Aug 2023 07:34:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSuku-0008Uh-8O for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 07:34:20 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on061c.outbound.protection.outlook.com [2a01:111:f400:fe0c::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d185a95e-34f4-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 09:34:19 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB9464.eurprd04.prod.outlook.com (2603:10a6:102:2ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 07:34:15 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 07:34:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d185a95e-34f4-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VsQO651MKgjCBmtPXIjCAaxMiWuU02jD3AzXC6cPkSlMae2ZwukLWD2DJJ1NNYxaE8P3eAJuJ0cy5idGfMlw8VYZ8wmYSwJo7MdY3cd1BFJ3dpQSwyZsIouAZkRyyaLkOGhTFuMA9yg8UEyAYre1iE3s61zgD1TUijTGVYTihRdHuVTMjkwCLyPBNyap5ykDSmzxiEjXe6/457fsWMH8WSVZpp297lA/Q3+SaMjShlvOztZ1Pa2WPGfl1rWEGemgBRv+ranRqdEawByplxq9x+IzFylFbDWTFFlCsZarfGOceZJ8WJTJeq1ljG8cqzc8Y57BTDbu3RPRs2ntP2jnxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iP3s02LxCbJoWD/kuK4cxD5RNSIhOTrDuWuGo6t7H2U=; b=EMtwnX06x5uue+LWTbvzKrB8Uua4U6YKym/+u4eYGqBMjyCmQB4G4TCWRUcJy0voB/yFJvWwXV6Lisw0Usjo+mpTtM4PSSRlTKmtZcETJOuWptK0AI8pSvzYDExlt6txz9kR4h9Hk6kPTphTv5Md+C8wnSZfC2eL+l5loWUCDxzy6l9rR5OpH3O1zBXBF780MliZh7zwMt+f9LRj6fniH5xii94qosbASimXTcGwMiXMR4iBlD5uCMKMx2cedt3WO9piKWIj/Occu18GB/WKGANWAdEkwy7rd+p7wA48cOiDE/L9+Sggqg0o4IP7cKAxU67t36muO0SV9/KgPWeYHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iP3s02LxCbJoWD/kuK4cxD5RNSIhOTrDuWuGo6t7H2U=; b=06XHms1jbJRjbzr4fEBK4oNS08gINq4+jwvXM83VmFyYS4lyC5KR5E15pM1dyQYZruJ1ci0D9K2mEmi2v2NDhUBnYqo28GXum8OzqmbrxAb2fOPLlDsjXcha0FiblK0re1Jk9Y/NMUDOVaYIUqC4NID77+tHAGnUr+m9KqhUBfOzRLR5t1okp+HeHLDuxK4cuLIZ8VEIWN2UALUKRxL4cgpUncaZCK9temtj8ISxFf937iqNYx5yrBWfge3KNJcAfyYhjFD+dTMTr7zDr+wDy/qFndFIymEwNzx+naa19GoWgbiwU7+JCU+Ejy1k/tUNcZgWntFcZlRANdZwntalYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 09:34:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: Address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB9464:EE_ X-MS-Office365-Filtering-Correlation-Id: d83fe74c-c106-49e7-7439-08db9718b33f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MwRNBYX7zSphKj/GdOtsQltzngMduFWDQCt9Q0yTlC7pKeGSiDE2I5V/Sx74snKyiR0bJiYAAI/nMO0dDsL/oaLVSDq3Qx2fdWTQk+6vtWaK8jnLgu6OxieR4F488gJWFpwHIljVk7E6nsiRrsHp0dNHbViTWuNBIYai73qKuD5sOw+4nohWDsNCd/aonNmsVyiG6UUhO9eHf8JsIpjEH6K5AYyl2r3LU3CCuI2ld05gaPNMU20mXisJ8kda0gKWz3+CzAqBLubD091q8vienIMaId2pIiW+0jw7Og3UnsE9NA7fN6WiIbDbEE4oXlGSBY9bH7lHRZubSKpBNfFHyKc2QTdMXySh3l3i1m67QenrlSoOQ/0dxNvtdX+mZfVsP4KxZglHiQmHTHFMrgcdVxUhDG/I9NnnM9souybd6GI4jY8a6/z6IyWXHSD8c5E1C6KM1mvSu69+LFnCHP2WbveUC5R5900M1KNcNYJbmtEZ5SDRU36XFGggQYIQ8zI2jFXU1ZdYc8NAPmYg1PbPk4w7p8wMIuTrmdZ2fwayWthEXWZov+7pCajSjgKZOgTOk+lIev5IxgILFwmEhCnJuBvggSZmVjEcrVqiO6NAjZoSM/lxOp7WCE7MLWdSELs7Y3k30qWQ9QDkumyBWlP1bA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(39860400002)(396003)(136003)(346002)(186006)(1800799003)(451199021)(7416002)(36756003)(66556008)(66946007)(6916009)(66476007)(4326008)(2906002)(478600001)(31686004)(8676002)(8936002)(31696002)(5660300002)(41300700001)(316002)(54906003)(86362001)(6486002)(38100700002)(6512007)(53546011)(6506007)(2616005)(26005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnVvMmhMZ0ZBS2lucTJOaC95NFNDeTdIS2JwRFNldEFNbzBkamQwZ2dmYjB6?= =?utf-8?B?ZnMwbEo5M09ZcFkrckNreUU1TVZHT2NjeDQyQVJsaFVrV2hkTk1RNy9URito?= =?utf-8?B?ZUZlVitWcTF5clROdUl0QW51OFRYTlc1TWFQQVFlZ1JrUWlQRjlKbzJHaXZy?= =?utf-8?B?Vm1oUzhCYk9nMWppMEZrbkY5cC9EZ251dEVWaXE3UWtVL2JyQzRObXUvV3p4?= =?utf-8?B?ejIrYzgreGtmOWtzRTR5NkZtRU84d3BXaFcxNUtERmJiZmZnRllJUFVtVGEr?= =?utf-8?B?NkxSRFlLem10TUExVVJGZ2ZYcU9XcWZ0dklGTzBEbTMrVE9NSVFYZ2dUOWV1?= =?utf-8?B?VGtiMEtDbUVxMERybkZ5TVBOemMvN3lpdXlYNzBkOTVPWldid1JlTFo5NDBz?= =?utf-8?B?MHVabUtSMnk1UHQ1dDZwVUVuOVJtQlZ2aTBGc21paTc0ODlvUEtrbUtMOVdB?= =?utf-8?B?YVR1bXdqMjlJOWVJa0xVZy9jdXgwMUdQaGg3OVZqa2tOZW1kUEJUcktQMGxh?= =?utf-8?B?TDVYK2ZXcStzOHR6Zm11amdWS2ZZWmdDemlGRjZ4Zlpad1VsWllDd3B4UXpi?= =?utf-8?B?OXNUS01ZYmIzT0pYdWRQSS9VcnRkOGxYbUdHTnhCWStuMEtCdHFSY2R5NmIr?= =?utf-8?B?ZXROY0lYYm9YV2ZNVzRUL0JDcGdOQ3drVU5uTC9hMHcwc2lwV3g1ZFlRWkZI?= =?utf-8?B?R3owRTlYNEJnd3ZTb3RsNUtTTTBiSmYrd1ZxeDc0SWUxbFNIcnA2Y3hyUXNU?= =?utf-8?B?L2Q3QnRsaGhCalNuc0Q3RWpjemJ0SlRER0JHVzdMck1FaGFxaDZBcHBjYzZN?= =?utf-8?B?L3VjR1FHTlUxY2FjSldheTkwRS9NZ3FYOEc2Z1ZKaVBCU1pXdVg2OFl3Z1Fu?= =?utf-8?B?NXA5dm1SZ1k3MEVJYUpuM2h5OEE2eUVvMGdOck9DKzJXYlpmcjhWemJZVjFF?= =?utf-8?B?KzJUS1RLaUVxQ2JBZ3dQbVh1VitYS2JKenk0OXV6WE42UVpxMnNLb0s4WmdX?= =?utf-8?B?aVNpa21hc2ZzN1ZpWFFOa2RCaCtzQXl4QXhpdDJCS1oveFBKZDlMSEhGZlJs?= =?utf-8?B?YjVTOXpVSUJzMjhROHhJMTg3dEtwcUZVUXYvcXFRSGVjZ0pTSzBqNTFDTUVo?= =?utf-8?B?U1g1M0k2c3Y0TnE0REJYTVZDVnYrcE5LdW9hbmdDbGw3bVpNcDQ4NHZIY3Zv?= =?utf-8?B?VzBmanNWWGVLT0tCU2YycldmNWU5V2thRFZNUVBjRWFnTWFiWXd4QUE4QXpi?= =?utf-8?B?ZVJZNzBoQlpyclRnQ3ljOXFkVTNaQTBSY0pzYUp1Yk91SnpGVWVDVU44QmVB?= =?utf-8?B?QmdKS21BRy9CUmxkZE5Pakx5S0tVNitQR0RXQ0VSUmcxN3F6L1Z4bi9mamI2?= =?utf-8?B?SzRodVV0a3JxNGVNZktRUHY5NlQyVSs0V28zSi9SbldTVXBTWEVHVWpPWjNs?= =?utf-8?B?MkxBUzNxWGxzQzBwZUgwSzNEbVo1OVhaOTRXM0RnMEVBWndKaEdiRmZBRkpy?= =?utf-8?B?QUI2anc2dk1MWVZ0RU1xNnpycUlPd08zTGFsbThPNDJLTXRGcmYrOVI2bEdx?= =?utf-8?B?ZjBKK3lnME1yL0kwSDhLc243Y29ITXVQUkhacWpZQzFlbWtWaXVmK0cyNXlK?= =?utf-8?B?R2FsbGhLNk9VMTdLUGJsdVRzTkhONXhBTUxKV1FweGo3WGxPT0pHMUlDbkZq?= =?utf-8?B?SFZzM0s2cTU0TkZZdVgrWE85VnN5MTV1UGx5dGYrV09RK2tZVFBNZ1ZqZVpr?= =?utf-8?B?elgvNGs4c00vVDUyZVdaSk5sVHpIK3hHcjFoTWtSZzBYYUdJY0g0VWQ1RzZI?= =?utf-8?B?VzRyZUdSRGVrUnlkTWluUnhaa0xrMzdDMmtvZjA3RTNhU0pORmxhSzhVODVP?= =?utf-8?B?OHNVWmQwcDBUdEQwYys0QWJ3K3MrTVdING1Ya1R6cTMyU3FwTjJJZHN0SWMr?= =?utf-8?B?RE1WNVpQdm40M0xVU3o3SXhISU44RHZqNDZxZVhaelZPMm1JMEdsa1dhNzZj?= =?utf-8?B?UE1pa080NGJIUUFKcmpBUGo3VUpMTHY2cDJRdGcyaXRwUXQrenUwbXhEYlV0?= =?utf-8?B?T2dwc2F4RzZJZ3ZmM3M2NEJDZkJQSVNIbWxoQmNSejNJY3dCT0FwT3hsd2RJ?= =?utf-8?Q?yIgtahkzpl8NYEXPd7XkZ08hH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d83fe74c-c106-49e7-7439-08db9718b33f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 07:34:14.6395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e+iigotxt3yYTc7yVWp+PceQyJ3JM/nAcd8q1pvXaC6CX0bolq0FT5DGIkUuc1zdpZ2NUmDqfif7RwB1kXwXwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9464 On 04.08.2023 16:00, Nicola Vetrini wrote: >> >> Upon further examination, I identified the following patterns: >> >> 1. Functions defined in .c called only from asm code (e.g., the >> already mentioned __start_xen) >> 2. Functions/variables declared in a .h, defined in a .c that does not >> include the .h with the declaration >> (e.g., 'fill_console_start_info' is defined in 'xen/drivers/vga.c', >> declared in 'xen/include/xen/console.h' which is not visible when >> compiling the .c). >> 3. Variables that are either extern or not, such as 'acpi_gbl_FADT' in >> 'xen/include/acpi/acglobal.h', depending on >> DEFINE_ACPI_GLOBALS >> >> Below are the proposed resolution strategies: >> >> 1. I would advise to add the declaration in the relative .h, to >> support automatic consistency checks with the >> implementation and a quick reference when touching the asm. >> 2. To comply with the rule, the header with the declaration should be >> included. Also note that there are some >> corner cases, such as 'get_sec', which is used in 'cper.h' without >> including 'time.h' (which should gain a >> declaration for it). >> 3. One possible resolution pattern is including 'acglobal.h' twice >> (either directly or indirectly trough acpi.h, if >> the latter does not cause other issues) like so: >> >> (assuming DEFINE_ACPI_GLOBALS is undefined here) >> #include "acglobal.h" >> #define DEFINE_ACPI_GLOBALS >> #include "acglobal.h" >> >> this way, the rule is followed properly, though it's not the >> prettiest pattern and also clashes with the objectives >> of D4.10 ("Precautions shall be taken in order to prevent the >> contents of a header file being included >> more than once"), but then a motivated exception is allowed there. > > One further question is whether functions under > 'xen/common/coverage/gcov_base.c' should gain > a declaration in 'gcov.h' or not, as they exist just for the purpose of > being referenced > by autogenerated profiling code. I see no reason why they shouldn't, but > they can also be safely deviated, > since they are not called by Xen code. Imo it should be the compiler to provide a prototype for these (much like it does for builtins), thus ensuring that an implementation actually matches the compiler's expectations. Yet afaics it doesn't. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:09:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:09:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577799.904820 (Exim 4.92) (envelope-from ) id 1qSvIx-0004GC-PV; Mon, 07 Aug 2023 08:09:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577799.904820; Mon, 07 Aug 2023 08:09:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvIx-0004G5-Mm; Mon, 07 Aug 2023 08:09:31 +0000 Received: by outflank-mailman (input) for mailman id 577799; Mon, 07 Aug 2023 08:09:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvIw-0004Fz-JU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:09:30 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060f.outbound.protection.outlook.com [2a01:111:f400:7eaf::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bac74d8b-34f9-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 10:09:28 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBAPR04MB7205.eurprd04.prod.outlook.com (2603:10a6:10:1b3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 08:09:26 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:09:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bac74d8b-34f9-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGEx9Z/ALLfB1M2ziu4d7RsCpnPsIA8iVee0iRRghoPNE5KHNKO3mUfzERpqcLECkh4AKziFQphF046/i+iDvCqAbr0M0cCnuaLPsQ6T6PAUHKGQSHMzTTN/It5GCmxoNNKzNAO/wmHQCia73zpVglKyMOm7y7WbOZ7YEQq1lxmVd3EvbMETLzk4sbaA8IzmjmfzsvKnZ1PsvxeMLkLOu+ScqMy79zbzS6MKQPBZC9MhyH2r+2BQjbmyWBepXHSl+7IbqC50aPPRXZoIxk8zIFYSZJSMUsCdJv7hOgq6m1P6SrU3jUmwBeED15ud4TSJB26oMI/9uGfB/9gfwNbgVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3MwbzB67oxEI7ogaF4SvdyY/jTHqGNrSN6zBwjin06s=; b=kh0knZ+9LVwN23jsPuBozjOGPbhjkxanl2G5/Pok/QJKkKSSJiqckt4CpbmFuMC6oSOgBbdy+jlkGPLncfs3xCB35DH/Ah8pkBMOiVedW51oc3lIPxWqhVtlCD+hrGODL4wsb+XHz427i9VrSp5IzelKipRWaB8SnApjSjwXM+L4AhDorfljNrwh0CQGAWhgTR9sUPQWW4e4o0X4U6mUeAMqrNs+Hqe4fzGeyxhF5lIt+idxCw4eWmZ1vVuFm7Qwru8WrWVeErHdxBFPFALcfaJadA65s594SMMdfaCMe//AAb3NkOxBFQbaKSXElWUq9EIUed/SEY+rdqk9AKw3NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MwbzB67oxEI7ogaF4SvdyY/jTHqGNrSN6zBwjin06s=; b=V/ia+n3JLYkMm9nsB3KarqYuDbQ8b0sh8zxYGq4nKxs0dpjlYLCuoKOFok8JOERFy3J7lakdFfXBhyetTiR1ZVxMy1dn9LUKRRTzRVs+Lj+xy/HwExgzVm3jUhz9Kpc8qAiKQiJyN2VXF1zMAkF2264STUc22YRea5k+hSyH0h27xhFIQW5F4XMjz0KJfd4zsi/t9E4whD8xse6ftJ/YYTtYJVzhdEBvfB0DRAQe6mUtX+6Xey/gI3VSpijd4hGl4VOKwZlg95hcgRP6Ala1Z+NoNBZkgXmIVlVztl3Ut6z1v+nmlKthzbk3mcd5uVoX/tVQSS0rq7MHGAH3/NCZaw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> Date: Mon, 7 Aug 2023 10:09:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBAPR04MB7205:EE_ X-MS-Office365-Filtering-Correlation-Id: a5222520-9eb9-42e3-65de-08db971d9dea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: azi5ZJxi/grSOJZ5XpNTogpU8w/uYD71IDv1w6d/txVcgOBCJUNVGUvJj8ixZeoyjDMxUc76OuSfMCehPMNbNp+Ar0Jp2xyAMP2F0373PG3h2cynrwINc6ybDFij5J+tUtIwlNTRUZ7YglU1SKBqF45/bYyfJxfTjyvs/vLwq0eyjEhGhYCpmPASO5Tf0ZRmDMquHgqc1lM2/Jj2lkQ2AVjEA6xBcCABo637J9SukWDY64gOVcPwBP058DdlOr4cTcI8z1xtLsc4MGn7LN3tXqs2EDc55u9Ik4fbmqriYR++YjVOk9QPeJO1/ab80NSA2nDGH0PVYAttV1MQizWHxFzPZwNv2hSawZRpCVkd45GUxnA0uxyibHVImWP1tQRQGuWK0xwLSAjFxi18uWMFjALfAM75gusox7ntbmQ94JjYEAiCiXOvOkqobUwVoo8xCJGortnwcfPconsau84dAs9hX2+/lek1Gmp1en6WIDRLuffB3rB5HEbKKlhiTnAt0mDRfYSafYgs1bx0cnJASMhYU7wvuMWbz5mkcTXgU1SvJ5bhq0HFzwSRpMNs4w40+tnwbB66f0eROEi5NGR2ddJ5HsgcQ+pOBGZQlIAZPrI7f5Jy4J76QSqppLTfwQIxJLOO1sqvw2h29unDH2VuVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(366004)(376002)(346002)(136003)(396003)(1800799003)(186006)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(7416002)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(31696002)(6506007)(53546011)(54906003)(38100700002)(6486002)(66556008)(66476007)(66946007)(478600001)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sy9BbkVJSmdPWG5lSHIwUnVLcUN6WmY2WVBwS3drQkdBVXA4bUFuUSt2OXhB?= =?utf-8?B?V0t1amQyUTN1T1ZScU12YStPenFPVXJEY2ZCQW9ScWFpa3N2Z1pqWk9mNjlX?= =?utf-8?B?U01WM1NWOUlRTHFvWHBFblF5ZnBXWTdvVXJuQ2xQRTBYYmdON2llZG8xSEtX?= =?utf-8?B?LzJ6WGhGNG9hYlczTFhqMHArNXpkTXhEdmVCaDZsVWRNQldZNnZRR21HTFd0?= =?utf-8?B?ZEZKQktCek93L3VKWGVlT09FcWVUQzFwRW5IZXd0Q0hSdkhQRXlqQmphU2Qw?= =?utf-8?B?R051Vzl3c0R5WDBLOHJGc0c1TVlpU1pVeHMwcHByOWZBTC9oZmtWR05IcnlB?= =?utf-8?B?R3BEQzkwZmxyUEhmWDE5RkZPdUZhTlFQeFJLNlhHRTdCS0lCcjBaTnZ5UWUr?= =?utf-8?B?b0hDcXZoQ2JQd1EyVnc2czFhbEdHbXhPOVo1cFRWNlRPRUowa2E3d0ZpTUU5?= =?utf-8?B?V01MeDlUNHBFelE3YU9Gc3UrMm9aWXFlem1MdlBnSkZ2dGpMU28vOHBwYVBj?= =?utf-8?B?VU54YWZ0RkY1K1VRRVcyRUpIK3BsSUxGL0RSc1BLMG1VcFNBMFFEcUkvNVc4?= =?utf-8?B?anlpMTBPd1NJVzkwTUFVdW92MHhuSFpBaW82R1pWNFJkRnJzKzFkSVNheHlG?= =?utf-8?B?U3Y0SFZoVnlmejl6VHRnUUxSTktGcENTME1lYjZPcVBWN1U1Y2o4cFhVeDhV?= =?utf-8?B?R0libUwyakwyQjlEZGFkOE1qNnUvL1ZKb0p0NzFUYnBBUTJYVTNncWIvSm8z?= =?utf-8?B?Wmo4MXg4L2FHWG9RZVVsWm5CMVc3Rkg4U2JkUnJ0dDJhS0w2M1IxZmMxR1l4?= =?utf-8?B?UDZtNjlXcmNhckZmMkR4VU5GZFJYdDB6Y09PUzZTczFUK3dWaWhoTUhxaURu?= =?utf-8?B?ZEFCMGdUbmdZaitzWFlpY3dEUVFRR0k0eGZHZWVhemVzc01IZWhrTUU4VjNB?= =?utf-8?B?WHVqZTN0TlByblZvejN0eXBMSm9YNkxKY2JpNVgrMHBNMHdhUFEyYVo1MUQ1?= =?utf-8?B?ZTgxcUFGaU9zNzBHdzdSWXlBc2FGaU5lajY5ZHVxZmd3UmlJRHdDcnRaOHZw?= =?utf-8?B?TjJBbU9WQm9wZk1rQVhGbmNxclhva0JQZHU4WW1QSGM5UXgxcnV6R3ZJUVBN?= =?utf-8?B?bTdndjVGbW4xdU1JWVdUSXpBWllvK0pUVWxoVUlmaC9QRnZoUDlKVGtkN1Bv?= =?utf-8?B?R2dTQjZobFZsQ1FWZzdDRytiNHRVSGQ0Z3NLRkxGbVBjdmlzQkVzNHhCR2tX?= =?utf-8?B?TlgvTC9mRHNlc2lXSnVEbTRZMHkwWmF0NXhRNHZGSUlLYzBMWDRvckNqakNx?= =?utf-8?B?L1VsKzBwYUZ5c2twa2JiMHNBdkZkUWNYdHllK3h5OFZKUXlpcnF5OFdtWTY4?= =?utf-8?B?RUJCTWdBSXRFeUZUZXc3YlloZXdYS1RZSzhFZnBTWjlMbCtIcEZOWEpOaE1N?= =?utf-8?B?cEpsQ0RqaWx5QkNRcU1TbytYY2w3M0xjVFphVTJDTmMxMjV4bEQ0aVMxbmZi?= =?utf-8?B?ZzMvRlIxN3ptMThmYmVMK0FRU3U5OEhlbzRDNzdydWgzeDBCcHUyMXBXKzR0?= =?utf-8?B?V2IvZkp5T0xLUW9TcDZnYXo0OHJFQkhqcmlSRE5FaHJ1SVRVSHNhSDJhSzVN?= =?utf-8?B?RlovdWtVU1l4QnRFQjhnYU1pcU9FNFJmSjA3bjBMbk1ZZ1dlazQ0V09nRGtY?= =?utf-8?B?NElGZFBodmUvWXBkRWtuNGZXZkZMRkZIdHhiMzNJZzQ4aWI2MzU0cS8wc2pG?= =?utf-8?B?YTJlYndPLzBQd1RMSmxMaUxHa1RDV0tGWFJZU0F6aWg3RC9ncFhkUnVMQWlS?= =?utf-8?B?L3AvaUJkNzBXbkorRmpLSVlJMUk2cnVGN3BNWDJBTUlaSUpiN0JWbHUxaDc5?= =?utf-8?B?b0NSQkhxbmNyT3d2WE1FTXB2aitIbUZ0YklWT0svWkVpWlJGYXdrY3hROE5z?= =?utf-8?B?VjlrT1BmNTh5TnFsS3hSQ3ljdHJ5dFpXOGNyb2dhWndSclNKQXl4U25KVmFk?= =?utf-8?B?Q0dpcmdTc1RnRWhVMy9qMmpycHZNOU9iYVNXcHZoTGkrRjBJRHMxYVp1Tk1u?= =?utf-8?B?d0R2Wm5nMkRvUko2ZmhNMXNqemp6K3B4UkFPQVVTVFNPSk00ckF0QTVTcEpD?= =?utf-8?Q?TBO7ef4JkfiisB/bZwzBkNPb7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5222520-9eb9-42e3-65de-08db971d9dea X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:09:26.4088 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Zv3XhbGOfOXLAZCGEz9PgoS1J0b06/CmjWKvHeebhtmcwvvLWtk6PcoLMrCLCNPqudIKDYEq9yrTxvt1E6S0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7205 On 04.08.2023 17:27, Nicola Vetrini wrote: > The variable declared in the header file 'xen/arch/x86/include/asm/e820.h' > is shadowed by many function parameters, so it is renamed to avoid these > violations. > > No functional changes. > > Signed-off-by: Nicola Vetrini > --- > This patch is similar to other renames done on previous patches, and the > preferred strategy there was to rename the global variable. This one > has more occurrences that are spread in various files, but > the general pattern is the same. Still I think it would be better done the other way around, and perhaps in more than a single patch. It looks like "many == 3", i.e. - e820_add_range(), which is only ever called with "e820" as its argument, and hence the parameter could be dropped, - e820_change_range_type(), which is in the same situation, and - reserve_e820_ram(), which wants its parameter renamed. Alternatively, if we really were to change the name of the global, we'd want to take a more complete approach: Right now we have e820_raw[], boot_e820[], and e820[]. We'd want them to follow a uniform naming scheme then (e820_ first or _e820 last), with the other part of the name suitably describing the purpose (which "map" doesn't do). Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:11:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:11:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577802.904831 (Exim 4.92) (envelope-from ) id 1qSvKs-0005et-5P; Mon, 07 Aug 2023 08:11:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577802.904831; Mon, 07 Aug 2023 08:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvKs-0005em-1s; Mon, 07 Aug 2023 08:11:30 +0000 Received: by outflank-mailman (input) for mailman id 577802; Mon, 07 Aug 2023 08:11:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvKr-0005ee-9W for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:11:29 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20607.outbound.protection.outlook.com [2a01:111:f400:fe13::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01cd54f1-34fa-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 10:11:27 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8955.eurprd04.prod.outlook.com (2603:10a6:20b:40a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.22; Mon, 7 Aug 2023 08:11:25 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:11:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01cd54f1-34fa-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQJ/RJ7IU6Wvx3gsyoy9QrvCqaXMOW9sCPT0LU3ZjVXJsQuGANNz2zS91Q4VNg+xoL4rJHRgJCk+aNb2vlzDrSe9+zhB6jn0mJ7lD0PptTPZsjmFwMpjpa/WvYzEyLn1dnw+GeeRXKhMKKftdRQ+stFIpnrCPND7MJqdAQ4hVPu/QioGBxTRuNAVjJ1sBp6NCmR2hB+WvdPitD0kDLEjnzJQZMgbpGWy3Mdpa3O3RFrOa7gb8e3dDpmVQKOUIA696zhQCoX8dMm2TwcIL5yJ0AlEpFDa5OmUt98nMysk79K1uodVTU+o72+xfNT2aHo8DKrIdPDDS6rbZK6/qTqdAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS4p0fmMuNYoG9ZS2V8EHvpZLTx0RCAzwjtOr9xWwjA=; b=SVUgdZTi7APWsCMCjDtSGevxxUNRcrFy6BGvd94++PddUKl8INkX8UKN1L8MG9E2o/d5vqnP3r7UxoBmdlddRSLHmnXGFn/q076P6aWNCs+QyOErvO56Jt7J3pyfh0T10N+vBfEq/+0rurHoIq65AqFYIQaSHq46+6wJBFa49OJ4SNkC6VXj00OAo15EmUDTUURRSApFy/fkp5GGA19O/foTITRyOODuth7K+93s8w0VBvLQa8Beo9cohVP1v6s8ZAHTsdAmwrxHBAES34vRqW1/WfZ76d/zDsgCh3ls/977ygM6aeubDj5wLm57wgPne9qt4IMBETVbHLAw4BvOlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS4p0fmMuNYoG9ZS2V8EHvpZLTx0RCAzwjtOr9xWwjA=; b=RoRLc/sidzBEb/ubq9t5Yb0pC1QjL4JShfJsO4iScgnkGA6QvedGlBjBaIbDLftoNtsGFcCkJj2PDqWwagMe0XgoLwa7UMfSfL3wKtbMugnEE2sdlUSl6Fm0O86grI9iT4z9I8u/UB5oPYMITekeF488gNFDqTYgy27L8o3hdqmBYYR5k4iMZH2q4ESkoVVnMlIvcwAJ5LMni3hvENW+cxMapcnTBmORDmsSnslFzO2WN7TZQlZxkHjfGZJlmjZSNh2lcRcegxY9m+kllkfvU9VBz6g4zkhxDcSaLyt//KpkYUitLtzFN28paoRVF++HlM8n6zzQZWhP1Brg37Eu6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 10:11:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 2/6] libelf: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8955:EE_ X-MS-Office365-Filtering-Correlation-Id: 90d83ed1-abc2-4790-2afe-08db971de4d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q00twlkIWTH9VJD+Qrr7nH2KzOTEpzzMZiE9BJKfkdq2F10wtnw2a66fxp6I1Orohgic3ZT3BFXRVt4xMw2ff0xcFgc6R290NmVJaYzAaVBEHqBktRi6QdptN5LxDbJMyTKBrEpmgV3+owROB4fuy/XwCmU+BW8Zc++JtKNdnvPflJUR5vxis5Cn48HghgU68uD8L67qnRHZFf3O8lKXsCpNVwEqyS6hLdQrxA4/wq3cusXBRejLNFHT6UuWjVXwoFSHdX62ntsNR1Yk58Gx9kX1GpSWyRAceutanvmwEdTE+tUxMxNLRbEVA0djgiR+t+YYX+kIq8LXpPjRDC9VIrrLPA3/qeYzdmWxuBSmICZELma+SCEQ8JhUyKpHoqrhcdJw1Gv+zkrG/LOnoh6n5Ma/raBslDcj5Zp2JhFzZarwxPi0MyJCUwbGBZMJGxIlIaXZ3gHx4VUCvl8hdNziSGwSFtbuG9dZIQ08cXY9gMQppWwOxs9A/PlkASSLeH2Q4eZUoc/EPaVnO5B2GparICJXT1Q6Z42UPTdtRyKyaRPvS21bTSUaiOht/ehXX7yO/p+qp0ges7rEHwobpzt6x7RCBLVpUmB1Bvm3gx5b08nMQ/ubkI3TCZ5EPtigR0P4050k730fdur8uSmkmSPqmw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(376002)(346002)(39860400002)(186006)(451199021)(1800799003)(6486002)(6512007)(31696002)(86362001)(26005)(6506007)(36756003)(2616005)(83380400001)(53546011)(38100700002)(66946007)(66556008)(66476007)(6916009)(4326008)(2906002)(316002)(5660300002)(7416002)(41300700001)(31686004)(8936002)(8676002)(478600001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zk05dkpaVWxtQUd6Q0RTb0VEZmc2YUUxMllPajBDVlJXQkY2ZzArSzhQQ3Uz?= =?utf-8?B?eXJYb29mMW5XMXFuVG5NWXl5VzB4bmIwT2lMcTFEZytvNzRBYk5GYkhiVmdL?= =?utf-8?B?SXZvM0ZiUHlZNUlkN1kxL3VUcnJ5NjVqUkJqOWhzL1B1VlJGclQ0bzNzRVpB?= =?utf-8?B?U01WcnBCS1RtRnRySmExYTZZS3E2U0Nocjk2L0dzVUQyaURZdm5ya0Z4Szll?= =?utf-8?B?SVJzQ21HVGd3L3VxREpqWGl5Umppcm85cFhEV25PTjEzSnY3T2JhSEljK0V5?= =?utf-8?B?T2ZiaEUvZHB0M1RaUHk2eGNBckIvZENlWEdYTEliNXJydjRKUzBlck8wWG9s?= =?utf-8?B?ejhUdndUZFJXMmt0WThUdSsrSVBCdVlWdGFyKzc4TThvd0NKSGxxb0JLaU5V?= =?utf-8?B?OGtYdU9Uc1VaTWowT0l6aTRFajl2Z0xQeHI1V01idHJrSHpEcFVYT0pzdlF6?= =?utf-8?B?WTFWTXJpZDFhZGxWN0x5TzFjS3VTRGVoSG5maGJrV1d6OEloODhEOHBFRTFJ?= =?utf-8?B?VTNqSjJ1OHgvWWEvUW1TdnB1MlQySWU2a2ZtaFltM2pNdFNmWDc3NXEzMGEx?= =?utf-8?B?QnJmNVMxUCtNODNiNUoyYnB6RTA4c0N6MitFclUrN1lWaEtXRHNHbEVQMmVE?= =?utf-8?B?OGl3V3hXQ2czKzEyOFE4dDQ0TzNJZk1TOWZEa29pRkM0blFzWU15Z0JtS3l1?= =?utf-8?B?K09CSWIvd1BIWndRczY0ZzBHL3NoNmx5aDNVQjJkUmRUeUt6VW1IZXA1azhy?= =?utf-8?B?eWdQQm10OERBRGJJYllqVkd2MGtlc1k3YnY4UVpWc01nVldQNUJaWHErVlBO?= =?utf-8?B?Y2p0L3ZqWExDUFVJZmlvREFiaG5vWDRYWVZpdVZJNS92eWlRNy8vR1E0TkVy?= =?utf-8?B?c2lNU0ZFRGdIY1FITzArVWR2STZlM21LWDRTaHEvblgxSnl4L2ZCM1JuZElv?= =?utf-8?B?aFRROUNLempqampLVHJoVk4xVWF3Q3MyV1Y0eXlUYXUrZWoyanhWM2dLbHJs?= =?utf-8?B?NUxWSEwzeUdPZzFvZE1tMVc5SWgrK0JnUzhLaGlyc3NwZU8za0tneDBqT2Y2?= =?utf-8?B?UDJUZFJEN0FXZ28wT3h6bnFrb2l2cTdjQlFaVHRXSHhxUVNZdHJCNGRENTBQ?= =?utf-8?B?d1lRRGFuWE15OTg4T2lTd0ZhQTdvZE9aTG9mdk1sREFZdFI1MU1zeXI3ODZv?= =?utf-8?B?Vk1oNllwd3d6ejhIeFN6OFk0M2M0bTN3bTVZUG9kbEQ3REpVdS90SzBQNnZI?= =?utf-8?B?citEWXpmQTBQNTkzRVYwNVFTallyTTMrMlJhTTl4TklZRVlnRkFla3RRd1Br?= =?utf-8?B?Nm9lQmJ6ZUFrYXdUZDdlN29wa0tsTGtWNnJBc1g4ZFRLNEtkT0dXQnVQL0Vh?= =?utf-8?B?cGdHQitzRmhoQko0OUR5MWplcmFhWFU3UmJwODI3VFNnUnpMUGloajZoU1VS?= =?utf-8?B?YVFKV3F5NzNxd0tSOEhha3MyNVU4OGNRUU9tTU1JSFl0WHRrQjVVeDZRSTVY?= =?utf-8?B?d2FLYm5jeGhRRzlWVG1ZNnRycnk2RWZlb3RXN3VBTFZvNGk0aDAxM3U3d2pu?= =?utf-8?B?c0xrQTVIMmw5YTdCTWtYbm5kYWk4T3d1MnN6eWJCK1RxUmNETmFlNkx0Vy83?= =?utf-8?B?b2RBRU9XMUdCMnVsbVVSL3c1Q2h1bzJaYjZFaHdBeXRpUTdmZUgyQlJsWXRa?= =?utf-8?B?OUx1OVh1QmdHeXNRZTNJR0tiK3BhNXBpaWRaaXJLZFJ0eDFtMHVrcDNmNkJn?= =?utf-8?B?ZDg1OU5pYklDUlRjVHh4UHdNK3pKZkdIVHI3MUNUZE1aYWdLV0FHc3MvQjB4?= =?utf-8?B?cWpZTTNoR3AyTGVrMjBVOG1uMmM0RXFLb1lyN05rdW9tdm5KcFp2THhRUkJU?= =?utf-8?B?NlpKb1AydVY2ZFFJK2JTdG8zMmFZZDJVSytORHVoZFZsRU1tWVl5Yk4xNHRZ?= =?utf-8?B?dUY3ZGV3Z1l6Q0J3NjFod3lxY0NtSHdvNjY3MzNBNDlsRVNRalc3U0IyVzhm?= =?utf-8?B?YWEwUjJjeENjNjFITmM4V2kyOW4wam5YN3JtdW9EN2VCdGRDeFAxK1pvZjhJ?= =?utf-8?B?Qm5mV0t2K1hOV0QwMTF3NkREQUVUYWltWlgwd1ZOOTZvTCtUSWRsdU1jOUhD?= =?utf-8?Q?1lfCJme+184yO1QGeCLTHTl5D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90d83ed1-abc2-4790-2afe-08db971de4d5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:11:25.3309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: spgOrMO/WPe+GQbSb54JMjgIWXEmGyOo2KPoheFyT2u2cfqzTZWcUiwmQ+/d/v5u/9Thi18IeZIF1Fm/1PVwlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8955 On 04.08.2023 17:27, Nicola Vetrini wrote: > The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h' > shadow the variables in the modified function, hence violating Rule 5.3. > Therefore, the rename takes care of the shadowing. > > No functional changes. > > Signed-off-by: Nicola Vetrini > --- > xen/common/libelf/libelf-tools.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/xen/common/libelf/libelf-tools.c b/xen/common/libelf/libelf-tools.c > index a9edb6a8dc..f0d5da1abf 100644 > --- a/xen/common/libelf/libelf-tools.c > +++ b/xen/common/libelf/libelf-tools.c > @@ -91,10 +91,10 @@ uint64_t elf_access_unsigned(struct elf_binary * elf, elf_ptrval base, > { > elf_ptrval ptrval = base + moreoffset; > bool need_swap = elf_swap(elf); > - const uint8_t *u8; > - const uint16_t *u16; > - const uint32_t *u32; > - const uint64_t *u64; > + const uint8_t *uint8; > + const uint16_t *uint16; > + const uint32_t *uint32; > + const uint64_t *uint64; While the chosen names won't collide with stdint.h's, I still consider them odd. These all being pointers, why not simply pu as names? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:13:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:13:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577807.904841 (Exim 4.92) (envelope-from ) id 1qSvMd-0006EC-Fm; Mon, 07 Aug 2023 08:13:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577807.904841; Mon, 07 Aug 2023 08:13:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvMd-0006E5-Co; Mon, 07 Aug 2023 08:13:19 +0000 Received: by outflank-mailman (input) for mailman id 577807; Mon, 07 Aug 2023 08:13:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvMb-0006Dt-Sd for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:13:17 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 429376b6-34fa-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 10:13:16 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 90B414EE0737; Mon, 7 Aug 2023 10:13:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 429376b6-34fa-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 10:13:15 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 In-Reply-To: References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <4c5b5091ecae8b1314ba67825f4a959d@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2023 11:17, Jan Beulich wrote: > On 02.08.2023 16:38, Nicola Vetrini wrote: >> --- a/xen/common/sched/core.c >> +++ b/xen/common/sched/core.c >> @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int >> cpu) >> /* fallthrough */ >> case TASKLET_enqueued|TASKLET_scheduled: >> return true; >> + ASSERT_UNREACHABLE(); >> break; > > What use is "break" after "return"? IOW rather than adding code here, > imo a line wants removing. > > Jan The "return false" after the switch would still be unreachable. The reasoning behind preserving the break is mainly MISRA Rule 16.3: "An unconditional break statement shall terminate every switch-clause", which has not yet been considered for adoption, but might be in future discussions, leading to putting back the break here. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:14:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:14:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577813.904851 (Exim 4.92) (envelope-from ) id 1qSvNo-0006nP-Qc; Mon, 07 Aug 2023 08:14:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577813.904851; Mon, 07 Aug 2023 08:14:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvNo-0006nI-Nl; Mon, 07 Aug 2023 08:14:32 +0000 Received: by outflank-mailman (input) for mailman id 577813; Mon, 07 Aug 2023 08:14:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvNn-0006nA-Fr for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:14:31 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20609.outbound.protection.outlook.com [2a01:111:f400:fe1a::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e90dfc2-34fa-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 10:14:30 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8785.eurprd04.prod.outlook.com (2603:10a6:20b:42c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Mon, 7 Aug 2023 08:14:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:14:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e90dfc2-34fa-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SzntF4Q7LSkhShJrZ5k0sSsVOiZt7jlFelfE5pTS3C4MdSgXbBMycx1C/aylAcuQAL0PrgI9QtLavQw+yl0A0RuY48K22V1KGwVBw6ApZXwYAJ2fPQ+j7isB6OCUT51xvO60OfYw5IcufI5I2L8jRYgttEsqGo9n72yZOkFJAJ3sLi4UTKyvjVH7UDGNc0EbElADP5fLrU24BvzvHTUJZbciM035syUrTdxsYQgKhsXK4P56EdXrslpykpbmkl/h2pR5ZZUrYQfcWasD1XExGvaKnGFi05ICTzfA4ysu9Srcb5zUdq/+C1Lu/UyWEMBpyLnD3tjxiQE9BZERHyy4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tp4Wqs3WIyB0xU2HZc0LdtEmJywyEhfHFm4QfbYQrUs=; b=HQasCcBnwJrPm6vbRrKbFb822i3yl8bFsp6kiJQe0rffVjkjF1DnWEVY0+r2lTON7+WezDNgFaSSWVN8F/RjZ7aBii1nmhAi+PImlpYTBBxbmEQuiyecgy1ZJJHAZGHE543Cb2txTjwmBooXUe/f6c1QlarHe6e8EqdiJqupR4VLy1aXTcm8ckOJ8wn0BbDx/xWIcfQ/13VqBJevNk2JzFCS72nC6NxTThaMKpsKu6BB2lvYagdWq457AcDncIiRZEfQ1PZ5THhT5/dhRcFnC91+5WKRscBlxCl+CzRk3lw/Y/tkekOd3ktHy2IdgFd3PO4+FqTyl/PIXlJcqHviGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tp4Wqs3WIyB0xU2HZc0LdtEmJywyEhfHFm4QfbYQrUs=; b=457JQoUCDPXHTmVPaH+FHBzGKxgBdtoYVuZuuXLdbRK+aJek7kXKkcD9+LJGwASUikKfFvRIlK2IkWnapxgCypflhKHh5ZU3ozgqtNpnV6V45hpqYjazQhrD33BDVMAxs0YS4CTjvTAVUZnBjkbKUjM/HUWYNBRZydTQc2678PhHXDqRHhMC+NsbWT+/CAneVo2YQtHvFbfYGH5og6hlVxJLmbHht2gtUlDwM9Q94La/Clsjy7a9vA3niFpz1/I7+RgJ21Qdum0a9PZ5XjjZ/LVJsgKqntC22ShIxenMDPdkF7AfvfHEfhFux37N6ZHRwJiCCiU5Bi5HKflth/ZpyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 10:14:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0077.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8785:EE_ X-MS-Office365-Filtering-Correlation-Id: b5c06f85-5abc-4718-2aa4-08db971e516a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MNDnyqzuogqibqiUCoDue/7lrfWXr6bQKWE5jlzYtZntcKghlQirdg0d9UKs71ArHJrNtMr+7GFqTN2xx6q/aUE1mOCugB+uLK41mJNKSXjavJgnS80AnSa57o4HKCcfdeV/pS2t6A0keuzRS8GEfAlnt7WfVf7ek+6iNVfQCtJVPcUFDHR5nCHs0qVaqSwu6nVteDp/KO7Sy75y5OrKZ0uwhgj2oNTRNS+Lv/8T2SXANn/zUSWMZsqSb7+k/S/uJLDItFjTtw9dexO3oWi4HVImGBDRG8JMWQpF8gL3hWzpFGDVqQM4K1oVq7A65URbUPZaf8qV1CoF4SQOpN47UATCy8ABq5UJICNsHyhoQA2TsfBprJlqeoil2B6MPCnkKk8RrqS/JRUY9GmHCME1XLXNUCeNKhqFks7Dkqhsx1yRFiOltI6SAnADwcrfZbV11aWNKCH0PRkBAyIviIWHG3vT5m21Ce+PBfCLpaHvl3udmEnyiQ4v7Dg2ygfXmdXy2gQdSNwzDqY51ur+gnvywPcwKwqVVHfqAytLwTtsSdSksgxpP+SnVB2Ox5czQcxIBS7aIQO86xxnPaIDNakFXVlU8Q8z1102849RuY6riOHZ6iUqHZKAzc53hsLBsnMDOC6xoaM4y10QYD93WlWciQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(396003)(346002)(366004)(186006)(451199021)(1800799003)(6486002)(6512007)(86362001)(26005)(6506007)(36756003)(2616005)(53546011)(38100700002)(31696002)(66556008)(4744005)(66946007)(66476007)(4326008)(6916009)(2906002)(316002)(5660300002)(7416002)(41300700001)(31686004)(8936002)(8676002)(478600001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aElld0NXaEQvQVR3Vk9pc1VYM29CZkxIczNjS054cEViYVlJbW5kMm5ITjF4?= =?utf-8?B?SFl3ell1YUdvYlFSVkhmaVorK29EdVZYYnNSMFZrUnRRSk5yL1IwM0JkRnVS?= =?utf-8?B?SExoNzlwbW96M0w2OEtlMTM0aXVtYTlGR09JRVM5MG9EUkpiU2VlVm1sNTZr?= =?utf-8?B?dVFobCtXQWdhYUZMbWpFKzFtYnIzZkVQbFBJMDZJeXVnMW5vVWpYcGZlcGZr?= =?utf-8?B?TzFkeklyR2owMEp6STVCNytrdFg3Q2NrTnZFNUROWFEwL1dvRElnci9iYjI1?= =?utf-8?B?T29iVTJaZjRvR1dkd1lkZmpMZjFDam10WFc4Y3k1UGFCQUVueDd5UmlKU2pS?= =?utf-8?B?cUY3ZXloYnlMRHZTZHd6dkpKL1p4UnZwZTF3bkVyV0FqdWpRSGtKTlpJc0t6?= =?utf-8?B?RXA0Q2F1c09OMFladmEyTVN0TTlZSFdBNW5lNjVDVVFyZ2VrOFQ0SDhsTGJ5?= =?utf-8?B?UTdOMmdwcHUxTEt4T2pZVzMxaVhiY1lvcTBlbGZKNndPS3lnckFacFkrSi8z?= =?utf-8?B?cEROZkFZZXk4YkI0UkNYUGIwaUt0eTQvZm0yU3hXK3JMcytOVHBPclF1OGg3?= =?utf-8?B?eWVtbXBKaTFvUTJvNTlsTFZLSW5MUm1jc01DSlN6MGVhditFZEJLb0Fmc1Zj?= =?utf-8?B?ZFQ3NnBIeDV4STJDTTU0UHJhWHR6ei9OUHNhL0h3SXFFcHo5NkJQbm4rS3BN?= =?utf-8?B?eVd4M3o4QUUwUzE4OTE0R1NScWR1QU5ZNTd1Q0JTZnJ5Q3FDb09EcHExMWJD?= =?utf-8?B?N2Fsb095U0lCYXM5ekVqbVFZSXZIdzNKSG45MzV5d0ZXdEZwTXUzbTdteEtJ?= =?utf-8?B?dzA3c3h3Z0VkRnlJSmFWN0VBL0FoeHNSaVpsa0lGZHFXU05Xb0R4MUVwTkRy?= =?utf-8?B?N2Y1UWd3Q084Z3E2Z2p2Z3pqelNyMk1rNEg2V2k1RUppdCs5ZEMrZW1pY09j?= =?utf-8?B?dXJpODE3YlNKdFlSTVI0emhkSTNuV0ZVczhwTVROQ3hwRkdHS1MyS3ZOSGEy?= =?utf-8?B?bllHcFNYMHJlM1prd2tlMDdPLzM3MjJzUzZnc1h2NVhteDcxeUM0Vm1iZDB2?= =?utf-8?B?LzljQTU5QWdDYWo0OE9XOHhXcXkrdVlvZkdCcVZEWDFrYi94elVSVStGdGlM?= =?utf-8?B?Q0NpaTNJRVhVeHBNbUx3NVVUOS8vN3l5QUVORk9XVS9mbVZTTFMxcFFBVmQ3?= =?utf-8?B?WG0xK2NNSDQ3WlFiL2dKWkJrV1BjV2pVOTNIcVoxYW1WVFpSYzlnRVJBcHU0?= =?utf-8?B?ZUNVZzhnNFpYcEdUaFFRZndaSUhCeTlsNHJ0L2pRQ2U1NHBBM1RaZElHdkJp?= =?utf-8?B?Y3hkbEQxOTV4Rzk5Vjd6dHAzWk84VG5HQTlBWGxjY29pYTBGR0dVSXRjcEtP?= =?utf-8?B?cVczbVV6UkVyK1hmcDdJR0pWMGY1cmQvOVhJeUtBQW1vNGFYeFdyMk5PNEUv?= =?utf-8?B?dGE4TEpoQUlocERpWnM0U3hQVjREOGlTN3pJUytWRjRFVlhxRVJPd0htWUJn?= =?utf-8?B?ZWloQU5oWmFlSHZhMGhGNXE5SStPd0RxT2dsY1JWcmk5bkhnY0piSWZQRjlU?= =?utf-8?B?K0ZjRXorL2x3SlU2c29GQXB1UlhKSDcxYjZ6aWJZN0J6Y1VodkFMUVlCVDRq?= =?utf-8?B?ampaNks5S3AwTWRpQWFKYUp4Z1NBRzFERldsMGI0cExpNTFvZzRNRDJSbnRk?= =?utf-8?B?eVRBb1o1dXgzbE9FNHJ5KzFiYW1iMlR3WjgzNGxSUEFqSWloU3hkRHlaZFUr?= =?utf-8?B?V2ZOVHdsc252MkZMUTdYcEtxd0pLbEU2ZTBwTWgyeWd5QnZJZVhHVURrajVh?= =?utf-8?B?S3B3N1gyK1VLQ1phY3U2MEVXWVkzR3NoSFV0MEt5a2EvTlR1alU4Z3NLNm5o?= =?utf-8?B?dmxySTczaWdBRVF3MWxWOW83ZFlXNzkvN1lyL3VDSTdyU0RramxROHlRVEFF?= =?utf-8?B?d2NMamZzRTRibEZJSjdRQ0p4RU9DdFROaGJZUVMwRTNEa09hRFVwVVh1Ullj?= =?utf-8?B?ckNRS0VDb3l3eXJpamREMms2R1Q0clRCdHVWS1J5NDJGNTM1Ym42UEc0UGpL?= =?utf-8?B?cmJKZ205eEx4a0h6SGZaVGwzT1ZuYlA3VmhWeW5DTmpnUGlQQXBIM1l4QUdO?= =?utf-8?Q?Y/MIam/RfJj8cPANtCv7GOCmc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5c06f85-5abc-4718-2aa4-08db971e516a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:14:27.5066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Civki7e4TVoKINHGmCYP5aO0qNIalpX9BAyeDecRJYODI2JaZKRLEQNt2PiNxSUWXn+nJYm2Y4sT+Z9Ehs+hkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8785 On 04.08.2023 17:27, Nicola Vetrini wrote: > --- a/xen/include/xen/delay.h > +++ b/xen/include/xen/delay.h > @@ -5,6 +5,6 @@ > > #include > #define mdelay(n) (\ > - {unsigned long msec=(n); while (msec--) udelay(1000);}) > + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) As elsewhere, please also adjust style while touching the line, at least as far as the obviously wrong case goes: #define mdelay(n) (\ {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) Even better would be #define mdelay(n) ({ \ unsigned long msec_ = (n); while (msec_--) udelay(1000); \ }) or some such. I can take care of this while committing. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:18:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:18:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577820.904861 (Exim 4.92) (envelope-from ) id 1qSvRi-0007VJ-Fb; Mon, 07 Aug 2023 08:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577820.904861; Mon, 07 Aug 2023 08:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvRi-0007VC-D0; Mon, 07 Aug 2023 08:18:34 +0000 Received: by outflank-mailman (input) for mailman id 577820; Mon, 07 Aug 2023 08:18:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvRh-0007V6-Cv for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:18:33 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcd93e83-34fa-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 10:18:30 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 300E83200916; Mon, 7 Aug 2023 04:18:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 07 Aug 2023 04:18:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 04:18:21 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcd93e83-34fa-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691396305; x=1691482705; bh=5/hljCKSvUJ3VllZTNOb3/xNIGkRmB7g1+x qcia2/2w=; b=1rofZGUTVtqbSrxzKEX4Ajz3azTADUqzGZGOVkVYTn6rlffB/c+ 8FmLbxBqnqsGRJW5uWKTP/c08xcoRAB+3xkQ0mi32ymVqxo5EkXX//aC55/b6P2g +ymf9UkPh9nigVID5mTZa4EcoTubQ9vXepJpcLbpWcNtf+x3IVH2QIUBrVOzKk0z +TkcKGq/UGylyv4ZKUA+Wyec8LbgKhgn84tUPlBJxWkhUsYlAO0ZSfyOXaQ5OCMn wEgi+NYd+KFGGPvRRD5iZP4lDhjCil9ve5YhuExNgi37UQNYE+YD6OpLqSFW4CIW cyJutbXf5S4/2p/6B8wV0KR8Szh1KOSMohw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691396305; x=1691482705; bh=5/hljCKSvUJ3V llZTNOb3/xNIGkRmB7g1+xqcia2/2w=; b=OlDJZWmXWnO9mZfFfxJJSI1/lgTj6 wnZn9b1xGXJ817na15D55C9HQs3qq8s5nA7N+L90j+i4IhvpfmuxhhhsqGl56uYz 2F9kqHi3xtYiVzReFtDwwuKrohPw2A4eVgqT1R+SmoBadem49LL8kRY+T2+Rk1BN pDkEmtSQBDO7MoQYyOKBaAhkt9AtXN4MNRTsRLjbctSVnk6OI4y+0FNILgXceLq7 rNMwNuKvE7fnJLkqD1mn8ExjGZ4kk+dahOG+gMDyjTblU9RZofE/S/d66OWOhD+k ad2BwjLqPn3Zm3f0UWpK4TxCZLwbLtvxWLhFzZmUaCBEExyYyFB8cQgUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epkfffggfuvfevfhfhjggtsehgtderredttdejnecuhfhrohhmpefuihhmohhnucfirghi shgvrhcuoehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cuggftrfgrthhtvghrnhepfedtfeduledtvefhheekfefhuedthfffudegteffvdfgheef kefhteegvdeugffgnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsihhmohhnsehinhhvihhs ihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: Date: Mon, 7 Aug 2023 10:18:07 +0200 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information To: Anthony Liguori , xen-devel@lists.xenproject.org Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> Content-Language: en-US From: Simon Gaiser In-Reply-To: <1515356919-922-5-git-send-email-aliguori@amzn.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------K60iXJNiRjuGkv39nsa0Jww3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------K60iXJNiRjuGkv39nsa0Jww3 Content-Type: multipart/mixed; boundary="------------c6eAEZRrut7lNYqVrbtZtGs0"; protected-headers="v1" From: Simon Gaiser To: Anthony Liguori , xen-devel@lists.xenproject.org Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> In-Reply-To: <1515356919-922-5-git-send-email-aliguori@amzn.com> --------------c6eAEZRrut7lNYqVrbtZtGs0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Anthony Liguori: > From: Jan H. Sch=C3=B6nherr >=20 > Intel says for CPUID leaf 0Bh: >=20 > "Software must not use EBX[15:0] to enumerate processor > topology of the system. This value in this field > (EBX[15:0]) is only intended for display/diagnostic > purposes. The actual number of logical processors > available to BIOS/OS/Applications may be different from > the value of EBX[15:0], depending on software and platform > hardware configurations." >=20 > And yet, we're using them to derive the number cores in a package > and the number of siblings in a core. >=20 > Derive the number of siblings and cores from EAX instead, which is > intended for that. >=20 > Signed-off-by: Jan H. Sch=C3=B6nherr > --- > xen/arch/x86/cpu/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c > index e9588b3..22f392f 100644 > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -479,8 +479,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c= ) > initial_apicid =3D edx; > =20 > /* Populate HT related information from sub-leaf level 0 */ > - core_level_siblings =3D c->x86_num_siblings =3D LEVEL_MAX_SIBLINGS(eb= x); > core_plus_mask_width =3D ht_mask_width =3D BITS_SHIFT_NEXT_LEVEL(eax)= ; > + core_level_siblings =3D c->x86_num_siblings =3D 1 << ht_mask_width; > =20 > sub_index =3D 1; > do { > @@ -488,8 +488,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c= ) > =20 > /* Check for the Core type in the implemented sub leaves */ > if ( LEAFB_SUBTYPE(ecx) =3D=3D CORE_TYPE ) { > - core_level_siblings =3D LEVEL_MAX_SIBLINGS(ebx); > core_plus_mask_width =3D BITS_SHIFT_NEXT_LEVEL(eax); > + core_level_siblings =3D 1 << core_plus_mask_width; On the i5-1135G7 (4 cores with each 2 threads) I'm currently testing on I noticed that this changes leads to core_level_siblings =3D=3D 16 and therefore x86_max_cores =3D=3D 8. If read from ebx like before this chang= e and what Linux is still doing [1] it reads core_level_siblings =3D=3D 8 (= as expected?). What's the expected semantic here? If it's to derive the actual number of siblings (and therefore cores) in a package as the commit message suggest, the new code can't work even ignoring the example from my test system. It will always produce powers of 2, so can't get it right on a system with, say, 6 cores. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/t= ree/arch/x86/kernel/cpu/topology.c?h=3Dv6.4#n126 > break; > } > =20 --------------c6eAEZRrut7lNYqVrbtZtGs0-- --------------K60iXJNiRjuGkv39nsa0Jww3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTQqMIACgkQkO9xfO/x ly+ssw//ex0IWjfRJNtizzKhsjf9gNU1DunP8Yof5DAL9mXkqW4o/JXCuo9MgAu2 2R3WpobqxDbqrzAo+R6sDzGlCLxp1UdFL/UbdXkzULqAmWM1wlXSc6OBK4Kfgvv4 w02DnU0C5SAHLW07t/ygjrHykBs/r0/XwaMEFkSogD1ioHmW61GHoJMidRAicmFE k/4FgJwQ9BOBt/Uk/IU+pLBvAoUBvOW3KUgJz1AXmPKo5js3sz/rUGDmhypmI6q0 V+MKUHio0wpCGUEN0ZgnjzUtu5TkLrL7Qc1ijFPDHYbtKyELexxfpL++hIMXHDMy +YfuFygwLbk/1D5DeZNLZqyvD2LI2G8uGqh0CBc7HXdViu8aZbgUZLEx6Ql8HY3L ms3Cjo1/wtrO/IPyey1tjKE2BQdpPeAfQX3lZ4IdRJhBMbSf8LvSJdYcuUXldt3/ WkK5Txh/BidNNdgYvIa2Mi2FyyufuCfeQzlY9pnyYq0JK0UAKcbb9uo2bUCNKoCl S5iDFGgddlR402hBou4s5lhj5D/LV2ZpdVRL0dlv5DE5kGxDcmaSM7zjHoZ0+/Cd anxRLXENFLq0bqrc2WFLxHZkfO5nRKCH/gSkuTB3IIonTy04I4HgxvKVbqWPts3t sQ29tGR4P3PVemFKg8BkEZZtLTj3quGT0jX6w+lMzW7j9JAX4qs= =TscL -----END PGP SIGNATURE----- --------------K60iXJNiRjuGkv39nsa0Jww3-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:23:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577827.904871 (Exim 4.92) (envelope-from ) id 1qSvWR-0000Vw-2I; Mon, 07 Aug 2023 08:23:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577827.904871; Mon, 07 Aug 2023 08:23:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvWQ-0000Vp-Ve; Mon, 07 Aug 2023 08:23:26 +0000 Received: by outflank-mailman (input) for mailman id 577827; Mon, 07 Aug 2023 08:23:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvWQ-0000Vh-Dg for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:23:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0626.outbound.protection.outlook.com [2a01:111:f400:fe0e::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad1860f7-34fb-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 10:23:24 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB7104.eurprd04.prod.outlook.com (2603:10a6:800:126::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 08:23:22 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:23:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad1860f7-34fb-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEmaT4TTIK0Mfo586HrMGDe88Rrf9Z3hNoISBrvLb5PdOpoOfWnkCJNacf2fjoVWy2NZp78bLA3lafIbqjG78zbKrKzNjnw3UDVztz9W6LleMDHpDLwznN/xa69R7Gyh5NfgWaTrq9A7fTigyMmtnvFpspD5GBt5GjenS6zgWTnRm8PqAYfQTITmXSTQTdXExrMSMW8NlxRiqPWGjvt5X14VltDaPCfADpjMrzPUiDmE0Om9yLqqpR3VI8nRJVhqLKEjE+7dTd/ZVR6Xb/qCgbXe2aLSUfoyCxJ4Oi7fCmRrXMrvvqSB+6//uHfePUzV5w1aztWHzfuVj1rmprloyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ftNqEZHQAKAYL98A+V7QlXNmwwmyKY0cQXST6QNRhg=; b=Sc1Wob8ymz6u+h9UpgB8in1EPtaWgM3eiJMAuU4CjE6NJkFoYSRZABdU98oCoh+zZO98q5LrJvMm7RG9UobdBSgHdbVnndVOThuoDoGqHFmqc83ln10ja3yRtMT1+AYaj0PjE+FBiTj9bfqkNA1oQq0+KFlgsO6gW04SwVibcsvYTuEpXnpTJ9K+bKY7ZfPeLEYnktqRnhLaLMVcl207f7dnU2ag/ve681+0QJSSEAROd6RHHNG7hghRI+VeHRyWqDVpsDhwEdmDSNQ2f1a+j9DxmN/PX4igsQ+ZHXRmWBghX2SCgTks4HNXNz4fSmPZ7AxIAyZk8eLRQq7uulJtUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ftNqEZHQAKAYL98A+V7QlXNmwwmyKY0cQXST6QNRhg=; b=eKzf8gQWax1al4TC3xf1zmCs/+T3DtHJYC0hfNpxyNDAjvBKesfFCtST6Sm94BSDGJ+iRp+15xHUXGalDhL9AWubKz53tsk+Pe0f/xWnpy/V3wM78NBDhXcUNY86oFidqarJmM7bys5vEGr/dJYGaepUEhwspzZd+G5yiuL/7grVHhMqDX4UIcBi7+Ueqnv4Va4QPh6gwD/3Mr9uM3klEgvX14xvINhvhAmiaKHBdt2Fky/83SB69p5DDFnx2CX1QHax9Qk0jVzcpV8hj9J19d+FBkaNKuvs4nkBWv2vF+RChygUMMeOkn0lDPQkZervhuGYENVK3/6quZOf5eVBsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <82438990-cb32-a2fc-273f-151818834c4d@suse.com> Date: Mon, 7 Aug 2023 10:23:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 5/6] x86/xstate: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <1ea70e5f8293fdca2bb69ec75f532722136e52a5.1691162261.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <1ea70e5f8293fdca2bb69ec75f532722136e52a5.1691162261.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB7104:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ea96b41-59a3-4109-139d-08db971f902d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iOXtXntk2ktrY2bg61KvgdnH2QRuTVSxWvWDI6HzfsrH7tPqx3LcvT2VIv/ti2+hCnfzB4+F0l+Zkj7pZWTdCMstlJenZqxaC3eiNIwJHJN2gdhz+kBARgNnbi0BVEeyoIyGQZwkFmtzYRm1yydA+7iRqcC6ezkHdkE/FLC6SVtIaKh504/Zxs2BlGbHDPqG9h7VgbTWQ4IVtj4Q+L+byGinbrSvt3fD9K38MY5bz+G9ZvHVmcnuGPdgiErjEpShUtV3uYhzpbS3Gtmyqn/5wLRixflLZdr8svs11AmX+G4nbkclVPm+xkzXwLAkqdF4mJBlnV7ATguyv05oiU6ww+LC6It75kR6LPhTPIXOgQQrDI3wNqbVdd+OFBWJ0/qxSSIhqNekDRLQGaAanzRh7fwhEM5ymELAw1tiPa88HbhFiwb5Md8s0wyvWoOppm82BKds+nRbyR2Al/3+oUhd4qI8rn1cEDPoZk4z2tFMXWywbXq1Fe6rip5VVOhhFq9ePA+rHOGhMTXKMXRk4kvuaoow3NLhcZtS8B/QKOcxz/Eseeqletr/Su1wxc3NdyvcF2+Y2sYn9tKe8FPs8H2kXAr+hg7hkUuZsObLJF4PDrzZ4XWbmZDFaGdkMmbhZ3iRy/IQcBx7gigzJb423kbc6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(366004)(346002)(39850400004)(396003)(186006)(1800799003)(451199021)(31686004)(2616005)(54906003)(2906002)(6916009)(4326008)(316002)(4744005)(5660300002)(8936002)(8676002)(7416002)(66946007)(66476007)(66556008)(38100700002)(86362001)(6512007)(478600001)(31696002)(6486002)(41300700001)(36756003)(6506007)(26005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTAzMDIydUxPMkJ3VDkzM29vcDJSZkxCUXI1Sk5ZTUU0SnZYZDlMNXFMTDVh?= =?utf-8?B?U1FqQ3FKcHBnQVRicytTVVcwZFY3QjNTSzBRK3lhazNZSzBMM3ZnU1cweDUx?= =?utf-8?B?VHlpSS9JeGl2amR6UHdHZTY0aWFXeXc1MmJxVlJUNXFzSGFCMW5jM28wVUxI?= =?utf-8?B?OEM2MjBtMTBqWmRZOXd5VnoxZlgzb1NPcnJFZi9ldG9od3gxN04xOEZMenVL?= =?utf-8?B?R3luOGpJZWIyZHRCSlJGMkJnM0hKVkhUeFVkUFo5TUJSZEE2RFpCTGpNRFEv?= =?utf-8?B?RGY4eEE1R0U2RXM0b0dCM2x4S0RnQjBYVFc1NmlwcmR4WVNqbXdZRjFTaWRa?= =?utf-8?B?Sk9ySWlQekoyenRhdXl6eGMwSy9kMDNDS2ZBYUlXaVQzT3lPcXhWV1hDQVhi?= =?utf-8?B?anNNZktEYzRLMm1EMjAwb3pjYi9qbU1ESFpjUkRCeEtDdTg5R1NlT0Z5Zkhr?= =?utf-8?B?OEpPRXUrM1F0NjBrL21TZGJ1NGlFTUdhV1N1eFpXMWNUTEtjUDkzbTZXK3Nx?= =?utf-8?B?R09lMkk0bFFkakRVVWJJYTVFN2ZDbmVKMmZaRGEyb3NDbHhsU0NnOEcxS2hY?= =?utf-8?B?QTdYZmxJNS9RcnZHblFmZ2dNOHQwbW9jeUJZN09JcUxFazB0VUVkMEZXU095?= =?utf-8?B?b3JRWjZIcTlNWnM3bjFhY21qM0NTMWoxNjZXNTh2TUFURG1Eb3R2ZDRZNURm?= =?utf-8?B?M2dpdGFuRUM5elVsZEpkcG1NSFd6K0I2UTV4YUFaTU1ZUmNuS3VRYmVTZytG?= =?utf-8?B?S3ZNUHdTVjhIK3poUGtIc1N2c3kwc08vVExvQnhrdmtjeHljNTJENTZyOVhN?= =?utf-8?B?ZUk4eUUrdjNaWEJucVhibDlvVGgzSWFSRngzd0cvYnJ3R2wyZ2ltOVhUSG1v?= =?utf-8?B?c1p5bWM1RmJDUFByNGU4eXp0Z2RMM2ZVejR1YWJyT2xYSHlubTNLak9GVk9a?= =?utf-8?B?dWI3QTF1dlhNQklkbHczSklWbEYwRit5MnM2L1B4YTJMU0dOU29ucVM3ODg1?= =?utf-8?B?NHlsUFhIUEFXeG5mbGtuUlRJN2N6cUpybTFTaXBFOTBrNEc4aHJ4RlFnN294?= =?utf-8?B?WUpjY0Evb1hKYUtkWEtYWTZWQmVMOU5jUVF3OXFmZEVnTjlYM2FtcjN1WHly?= =?utf-8?B?WDZSc0RHVUxVUUozNGlIN2JrVmEzOVZKNUdWak5OTXNSTitVQ2NQU3FFOVRs?= =?utf-8?B?a0RvQktUWG9ncm56c0lxcnJiNHVIQ2REaG4zcVM4dGFMSkFYd3Z0N2JZVkJh?= =?utf-8?B?VmVNY2RyWlc2L3hPcmUrMHEzdml0ZEF6VkVKd0JuWUM4OEdpWVA0YUdPek5O?= =?utf-8?B?bVR2ZmRqc2xMTUtHYkhSQmhYeVZ3UFZKclZqTVRKNndHNWxuR3BoU0VDR0p2?= =?utf-8?B?c1I5M3Z2MkVlbFd4THVrSE9xdHR0N1I5RTFNRm91Sjh0dkJ3a1R5d0VyOStS?= =?utf-8?B?ZnFLZXJMS2o2RmZCRlhJTWJ5RFY1Ry8zZTBwUFl0Y082ZTZ5OTZTV1FPT04v?= =?utf-8?B?RzZEeUtJdFhpRVBJTFluZXJlVkk4OWlFMkZOVEtDMWxsMHk1NWgzNGFNeTMz?= =?utf-8?B?OEk4R1U4RVNKb1dzWlFveFFlaHo2aDN6TTZFWXE3bHNsWlkrUlJqT1VxYlEw?= =?utf-8?B?aEt5VmovcHN2bmpzZTRQRWx6YW5nOVFRYzRHK1VkcTRtSXVVZG4wdzBNRFpy?= =?utf-8?B?Y0VNcXZRdU9pZlJ2RG00VkhsMlZyN1RPK0RUK2Rkd2hzNDVORDdHRk5QL0wy?= =?utf-8?B?NE9MdE9VY2thRWZMeTRlVSt5M1hOZ05TRGF1QnhPaGVwSGVXVG9FbUdGaWVx?= =?utf-8?B?ZE5uY1BXQWtxYTFST05HVi9CZkdNUytQNWJGZ2NFc3Q5RjYyMXdoODBsRmxP?= =?utf-8?B?ZzZ1N2lLNGMreFVtOGJkVW9OdXY4L2pDazZwanZHSFVmcGRrTWU0SHUyNGtE?= =?utf-8?B?bXlOdkdxTW01eUpCUVg0THNLUXRpLzh6OFgweGpMMG5CY0FsdlVEZFRCcWhw?= =?utf-8?B?NkZnMHJlaUp2ZGZJbk9GTVpjaEtJdlBvbjdUMzZlejJyNkZGRTdyNFdBNDdj?= =?utf-8?B?amZDUEkxTllCUlQ0VzFlcTBPekZEemt3ekFLZXhVeWtVd05kYUliWmtGVnBR?= =?utf-8?Q?oH9+f4577MgHxjcgAR3+uoAIU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ea96b41-59a3-4109-139d-08db971f902d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:23:22.3203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VQuD35ZJcWAy4fdf1p/aMlUhEM7znPUIfOCQo73Af2jeMDOgurYgnJbksGipfxutvmnDrJ//OssiH49G/tha8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7104 On 04.08.2023 17:27, Nicola Vetrini wrote: > Rename the local variables to avoid clashing with function 'xstate' > defined below, but declared in the corresponding header file. Hmm, there are two functions with such a local variable, but you don't change those. You change "xsave" instead. The new name you use you took from older functions afaict; newer ones use "xstate" (and use of this name is extended in pending patches), so preferably we would follow that naming model (and eventually rename all "xsave_area" as well). Also - does "below" really matter and hence warrant the "but"? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:31:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:31:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577832.904881 (Exim 4.92) (envelope-from ) id 1qSvdx-00021F-RK; Mon, 07 Aug 2023 08:31:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577832.904881; Mon, 07 Aug 2023 08:31:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvdx-000218-Nx; Mon, 07 Aug 2023 08:31:13 +0000 Received: by outflank-mailman (input) for mailman id 577832; Mon, 07 Aug 2023 08:31:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvdw-000212-6T for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:31:12 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20623.outbound.protection.outlook.com [2a01:111:f400:7eaf::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c13fc92e-34fc-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 10:31:09 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9929.eurprd04.prod.outlook.com (2603:10a6:800:1dc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 08:31:05 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:31:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c13fc92e-34fc-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WCn+5t2wdcsAY1LLOenfGZiaG/wQX/mDFfudlolduC+Fvm6OzqQO3lh4tBHMcPDVoEOWeypvzQPDGm0UkVtBCC577lhUViyDo1LyFA3szhPjXx/E84seu3QnjM+sOVTQOmUrP4piu3c+OcMhAIK9FQ3ABeeHuvxrGc4cnoT6O/V9MSOLDY3YNQYq5IvxnHAc0C/5gO02K9EBjrKoXf2f3a+4cjfxo7kOmdCWKrxRUFS8qMvl+Zs+6qA9YwzjsFt2YhTgz9asX4Q9rXn2sD3hGVuVu+h2ZgCFsfSuIctBkFBi1kWMIgcoV+/IvCtK7MJAVxpU0+Lstvjbg9JD7vl0bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sulIWApr+vlwF7fTQnl9a3uBjMHOZlcD0zz7tG6//KM=; b=KUsAdHhROrRDgdj8+RVlWJI9lXCFGcQVbJTJtc/4tXFkWrivUtkwSKLsINzNRSMkug/OHWaqFud0cGw90NVR88FXgA3Ych2xsWu586qzjw+j9Sq5952LrLSuLE2WX71EH95TsueGv9v/IiGIsLQvItNbC9w/IyyyFvQrbCVXwwq1oD9ZESaZfKO5AybEZR18k9FOaY/BeuSQozVix561E0hpSgz2zlqBOvBBvvwM2h2lkls70T981U1KYSAQoVKCAYJwU1+0GmrZ0moMTjdYypyY85i4fvGY3iWyhcSdcFsolVK3IY/RPxC3WjsrAIr+cM/SzMwooreOutFXkXdduw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sulIWApr+vlwF7fTQnl9a3uBjMHOZlcD0zz7tG6//KM=; b=Ky2Pxb7/Pgr7AB9ZYzmS/R13Z8EtyBmDr2GIZg6T7A1CoPZmOqz28jSJezQADFAY61O1OLPXTW/lMzn+gD/heforIpsBCOeLOyWN+Hb9u9XdLVJZMbbWPXq4qK2SEU5QNrSD/tOPVEwQKbebTBh4uoE1/Pdw7XNh3d9R1L60PqOuafMalI2MB7A/rtO0sPtx+8lSxZVI0v6YXElUVwJIIeT28fWNyqqKGwn7vKzBQFKbrQ6q3TTU96N2ocQXcXUa7cj1XWvkoxXsEDHKFd3oD4MUgkDahISs5YR9Vy8lkvb1Q7MZJKcq/bjuJe+haaVAwID4kOKSEvZ+VMPM6g88HQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 10:31:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 6/6] x86: refactor macros in 'xen-mca.h' to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9929:EE_ X-MS-Office365-Filtering-Correlation-Id: 05832750-b731-4b17-e25f-08db9720a434 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eYX2x0F5wxrdCqtEVsNEzMIQaV5gMvUtmzZgGx/S1z9ncVfB5RojP2oxK7GU1UBwmCo5gn18lsSN+ZFyfUemMdB9VwCup79nsF5G8jvbG05Q2szpU4zrMxNUjQ93W2CNzl6B0mMHnFjt+uKKfMfX1FUD6zEzGRz4N9zlH656wCt9wdDxYt9Kcvhy4faTnAdKvGwqCeJ8tRGehusnfZ6GS6HJj06EE6DQkfHQJ6Gb4vd3oaiu6I80AoTwttcc9OM5t8uau4PnTSuadX/rT037QaYEkw91yfIpGlAGdIX/bsx049E47n2wqSwzNap//LwzBreEdDocgwKpQ7uJA8LPnq57v2iDz/DAOm7vOQiAWUNJLNoUQr3TVn9krI3QQHbk8tV8s3X5Dyh9Dr6Em+PvnSQR3/6gBwwMaIpYbws+mONRU/Xadee2tXRDOn4us/VDseFK8HzLNUVkIVh3tKMOBydBya8nCRUmGP8bn218ZjU84Rbgw01w0isvZcbIsmbNdTs4+eb0Aoq8A+EYnZlj8jLu9qvoLOPGDXjrxa9yvxR33XcBsFHnPEoiZ+oP/9ZA6+fSoiwHw/6+vob426g8dxEhKanez2ed6UWHy1fezqZIdl1UqbFww/nGrmPVurRtc/0Kf0MPCRYJ6XiYCkOsiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(366004)(396003)(346002)(376002)(136003)(451199021)(1800799003)(186006)(2906002)(36756003)(5660300002)(2616005)(54906003)(38100700002)(6486002)(66476007)(66556008)(6916009)(66946007)(6512007)(4326008)(316002)(31686004)(66899021)(41300700001)(86362001)(31696002)(8936002)(8676002)(26005)(7416002)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWluYzh5ZEFMTmFuVk95TUdpSFVYckZ6ZTRUKytZRTZHT1FrM3lnRDdjTHl6?= =?utf-8?B?TjNIRnNmTUVMOVpqanFUOHhZT3J6Wk1RNzJ2anBPUXFzTG1qcmFRYkw5ajU3?= =?utf-8?B?bmZ4SnZyMGVtTHo5Sm4rUElIdllSTWVQMmptOWtKcHFoYXFWdUI5eTE0Z0o0?= =?utf-8?B?bkthNFJyVXhTYnF2ei9XQVVBL2dFa3h2TVFqOEFETzZjZ2s3M0s1d2RIZlhh?= =?utf-8?B?NVdTNU5ZWVNtUldvam1GdFZYbStrZkNlclFrOVBXQjAzcUhVUTQ4S3Z2d0Rz?= =?utf-8?B?ZHNnMDBEMXRBNG1STGVLbzV1VFhrWU81UENTSGlNczNzWEUrZXJmTTRCZXRU?= =?utf-8?B?UDJmcTlzampoZ0dZVW5pRUJwZktJZGVtemQ5elFTWndNZmNDdTJXSGh3SzJz?= =?utf-8?B?WUFaZkdyTThjSEt1ZjZXY0pEVjA2T1BCeEdTdG5vMC9mWGFxOEtKUmM1U0V1?= =?utf-8?B?a3pSYWsyY2lEdnJhaGM4YUJmcDNKeVVTM0psYXBYaTFPNVp0UkExQ21pRUZR?= =?utf-8?B?bGVhK2E0QlVqNGE0QWRxNGg4Y2FtZnR0ZVpKWHh1bUZvZGxCWjRIa01TUGZs?= =?utf-8?B?QThtSmgwNDBCRnY3TDFmR0hGN3JNL2RtdGNibi82L3g2VUdmWDV2OG9lK3Ft?= =?utf-8?B?UjF5eW5hZ2IzUmJkUzNsUHduZUZWVFUxb0hIcWtPejdJcWdCaWtRekJudDJK?= =?utf-8?B?S2pzREZ5bmQ1VWR6QzJFM25IOC9PTzYyZmhRY1FkcUVkZ2tZQUhSbEZNT0I4?= =?utf-8?B?NXJwWFN2RVlSRGQ0K0x6Vi9hNDZXQVN4QUtJa0F2UGdwWWUwSkFRcTNreVZp?= =?utf-8?B?RC9hZWJvQlY3K0VNeUVLYjFna0l6amRoSGZ3Wk9HcFcrNlEzajRnc3orRmQy?= =?utf-8?B?Z3R4VVl1Z2svMnBzdlhnc2hKTWM5a0QvOTBRY3Z3KzYrTGxOdWwxVmxaeTRK?= =?utf-8?B?Z3IvM1IzWVEwQ0ZrZVMzbVhyT2Y3Tkp1cURHczk2bEtCTGRMMVpxczFFTnJt?= =?utf-8?B?TURrQWJTSjY3aUdLZlltNEpSWFhKSTZLYk5oVTl5QWhOMHNxb21Rb0VqSEpV?= =?utf-8?B?OUlvMEZWSFJlTVowZDNVV2RUSm91V2V6U0lPQzYyTStzaXIwV2h1M3IvdU16?= =?utf-8?B?T2dzTVUrZFhpVGhDY3V1bEltM1JiWS9yT3pIVnJmZHY2dURFUXJsY0s1ZTc4?= =?utf-8?B?bGQyZ1ZPM1FzNmNxTm53WGZKQmc4UnJoZmdRZ3RiaUNYa3pqUStoQ1pham5a?= =?utf-8?B?bUF1bHduaEVGNzNGeFFRSWxvV0MyZngvNHlrakVjSjB3QlFub25DUUxKNGl4?= =?utf-8?B?Zzc1VHdhejVZSG80N2lscGdXWEgvam1BU0VRRmdBU0IzTkg0VzMrb2RjaTNF?= =?utf-8?B?N2xDaE40SGpuS2s5V0J6VnplbmNyZnFRREk5QThETFk4NXdGS1FhMlkxbzJy?= =?utf-8?B?dTVrcFQ1OHpvWGg0ZWdSOEQ4bmQxeXhuTE8rRXZzZGJadzNpbk4vai9QdHhP?= =?utf-8?B?TFgvV1dCWE94TjN4NkNrRzErL2pabllPWkZWRTgvSkt2N0svbWFGY1haQkhr?= =?utf-8?B?QXplbDd3QXc4QnZWNVJuaTl2dGVzN3dQUktsWFJlQWtXbHFEa3Vmd1loYzU4?= =?utf-8?B?aCtZYlVtY2FpRUd0cUNWUWVHUnpCckNaR1VMdmZPSllTeVNqTG1EZVU0dko4?= =?utf-8?B?emdQQU5VUnJUTEp0WmZYd2N6TURQV2FHd2FZQ2lQeGNrWGJXNWtvR1ZVWVpH?= =?utf-8?B?SzdjcmhhSXdEY3FUS2xhRVBTQjF3NzAyWjhCUFJ1bHRBQkpQRXVsVXlOTFA1?= =?utf-8?B?Z2xzeGFkcXRuSDh5WDNNV0FOL3VFSzdGaUhHbnlYVDkzS1BsbzV1MXhRNk5Z?= =?utf-8?B?TXdmbDhQVkxxZnlQMi9SaDhsWFhiTXVKdDlqb3YzKzdESnNrTkU5aEIxdXEr?= =?utf-8?B?dFZibjBqM0diWlZxOWxOT3RFM3lVd1A2UzJ4d3RKYWVIOXVPVHJlTVhxQXVO?= =?utf-8?B?bWJVUGVTTnJhYVZDVHZJenAyVmRHRWQ5dTJTNk9FTU9JYzZwTXYyRVI1WDRU?= =?utf-8?B?WEFnMGtnTW5ETC9MMnNwMVY3UG1VbEhHa3NmOERyQ29wMkVUSVNXWXBaRFFa?= =?utf-8?Q?M5N8cnOX2l7pla0kHsqBfBhoM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05832750-b731-4b17-e25f-08db9720a434 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:31:05.4753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VG+yByL+JzN/1Gv7zehQTzueDzmyVjUILj3Y6BsiOQPX91igY+cjc2Xd68R9fAwf5HwC+a2sGipop/yB0Nz1ig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9929 On 04.08.2023 17:27, Nicola Vetrini wrote: > The macros defined 'xen/include/public/arch-x86/xen-mca.h' have needless > underscore prefixes for parameter names and variable names that cause > shadowing with e.g. the variable 'i' in function 'mce_action'. > Therefore, the renaming aims to resolve present shadowing issues and > lessen the probability of future ones. > > No functional change. > > Signed-off-by: Nicola Vetrini I'm okay with the code adjustments here, but I'm afraid I don't follow the description: How is shadowing of "i" connected to the use of leading underscores in macro parameter names? I think you need to separate the two aspects in the wording. > --- a/xen/include/public/arch-x86/xen-mca.h > +++ b/xen/include/public/arch-x86/xen-mca.h > @@ -280,39 +280,39 @@ DEFINE_XEN_GUEST_HANDLE(xen_mc_logical_cpu_t); > /* Prototype: > * uint32_t x86_mcinfo_nentries(struct mc_info *mi); > */ > -#define x86_mcinfo_nentries(_mi) \ > - (_mi)->mi_nentries > +#define x86_mcinfo_nentries(mi) \ > + (mi)->mi_nentries Isn't there another rule demanding parenthization of the whole construct? If so, adding the then-missing parentheses right here would be quite desirable. (Personally I'm happy about them not being there on suffix expressions, as kind of an exception to the general rule.) > /* Prototype: > * struct mcinfo_common *x86_mcinfo_first(struct mc_info *mi); > */ > -#define x86_mcinfo_first(_mi) \ > - ((struct mcinfo_common *)(_mi)->mi_data) > +#define x86_mcinfo_first(mi) \ > + ((struct mcinfo_common *)(mi)->mi_data) > /* Prototype: > * struct mcinfo_common *x86_mcinfo_next(struct mcinfo_common *mic); > */ > -#define x86_mcinfo_next(_mic) \ > - ((struct mcinfo_common *)((uint8_t *)(_mic) + (_mic)->size)) > +#define x86_mcinfo_next(mic) \ > + ((struct mcinfo_common *)((uint8_t *)(mic) + (mic)->size)) > > /* Prototype: > - * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t type); > + * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t mc_type); > */ > -#define x86_mcinfo_lookup(_ret, _mi, _type) \ > +#define x86_mcinfo_lookup(ret, mi, mc_type) \ > do { \ > - uint32_t found, i; \ > - struct mcinfo_common *_mic; \ > + uint32_t found_, i_; \ > + struct mcinfo_common *mic_; \ > \ > - found = 0; \ > - (_ret) = NULL; \ > - if (_mi == NULL) break; \ > - _mic = x86_mcinfo_first(_mi); \ > - for (i = 0; i < x86_mcinfo_nentries(_mi); i++) { \ > - if (_mic->type == (_type)) { \ > - found = 1; \ > + found_ = 0; \ > + (ret) = NULL; \ > + if (mi == NULL) break; \ The lack of parentheses here definitely wants dealing with right away. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:40:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:40:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577838.904891 (Exim 4.92) (envelope-from ) id 1qSvmL-0002kD-Pa; Mon, 07 Aug 2023 08:39:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577838.904891; Mon, 07 Aug 2023 08:39:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvmL-0002k6-LS; Mon, 07 Aug 2023 08:39:53 +0000 Received: by outflank-mailman (input) for mailman id 577838; Mon, 07 Aug 2023 08:39:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvmJ-0002k0-IS for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:39:51 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on061c.outbound.protection.outlook.com [2a01:111:f400:fe02::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8be070c-34fd-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 10:39:50 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GVXPR04MB9757.eurprd04.prod.outlook.com (2603:10a6:150:115::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 08:39:47 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:39:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8be070c-34fd-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n8sX5dJS+8hSYFNu+XjJihwHzTwsxP6PX2i9vobsi+3BbWoSbY481VtvEf10SqqlNL5fG4isgzCrTyqfwn+P6wlcFiCsZyYx82Ub4oeQnmt0IBl3Q+VX0V1WR+z371oOd11zY9qjTSEzeLVFD8J+R09N8siYD3iIXFrktynBgPf02LQ8rP6OPC8OhFVxB3E+RA4LOyB4yagpgWvWRS9uWl8G1HlkGW8Xt9LnpAu+4PuRk4OfCDWQyjFvhUd7EKKFRCoDHQNHpbzOO1ppLtlhdndpbhaY+abdrDAxPjbFjydZFy7ZLVIp3LoL9EOETLaB76J4tfPn05UaUGfHrqkDtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2BetuNzSp2Y+3FGO/V6r0vGB3agsN6xV6iitkX9zLS0=; b=SNVjSR2hatfA1shlhFG6Qv4VcRI0ZsVJB+xJkwJE6lWseJpvNAD2WLo30ZMigxZZTvOeG0eW3rfvGPxdEnV0zrqYpIMjzZtkNXRp7z0Ho2+jTmKQyS+5jqHA/1o+GXtgTYig66rfQnWNAq3WxAQaZ7tpBjhcnqJQzpy/2OWgDGBTCP48mUCGkJOg5V/9mUSizZebtGMDH/ITxn3Q5pihUubqyHA0CFjr/x5hpHZQJ2W2uY+iJbAdVjCEoZ6/V8ssacxn492j0IOWITOUVFaPh7UZxzBkUllK2P071nMclbVow2oOq+dTo4cIFLPe20S8Ch5Q1vS14PCYATgodXSM0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2BetuNzSp2Y+3FGO/V6r0vGB3agsN6xV6iitkX9zLS0=; b=ga8xq67HI6D70+LVvlWze4U4b89lflYnxVN96pNXTJA6vrlSS38d20UIuwGMwrEjmQ+LI7dHh83Xq6cD0Rq6WHeERSXF2Igw+agof0v0zWQSN4v4c50fLO2sppgr8F2Q6wAZHGbO+KXH7ZcaqY1sjKf8XVqcB4MPwd3dNZ5wFUm9eSiioJpDF1+uGWxv0Pk1ETkM1yIQSy/giW58wWdxccHNsBf4/WS4Yybcqn7xXX1exdrm357RBVIVqfKGQYjCjWo8WaWNQd1fiJxTdDzMrggriR3n5IhwaFGovQpOwumRfBUQMZaFuJm6rrFQD2McW41B/qFB/NVs5h9nFawFqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 10:39:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information Content-Language: en-US To: Simon Gaiser Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Liguori , xen-devel@lists.xenproject.org References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GVXPR04MB9757:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e33042d-3e0a-429b-b8f6-08db9721db65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WFO5m9RLcSkW6jbsucfa0Mia98wWzkz/JR2Q+uPW0wsMWjLVFKF4Dg2THYK641nj7kPvsnL/EDPTo8/knNMI1FZIiAVG9HvGTWQi/9gK4wveTcnpY56bmvpur+gyN4RI78v+UDTkDqDTWHpLJ8IRJR7DS9tddSGb1tmsSA5qmgEjlWln692c1wkRLbn/tQ444VQ+jlM/YD6vXsFgI5UaPwCUiKZEvt953mKsALOKqHdA6fNmSCJnWZusW5rkdS/NF6tg+dF7IpmATISNk59H5O8cNP0VupP2Lj7XR0Mrv8U6vZGcWIgWECyMAr8qhIy5Tdvf47MXVIjJRHH6VouPGFEWmlXlZBo/T/6e3zxjP5CtgOvAX2BAXL4Z+SnRnHvvt5esqlCdgkNu5ffJ4gohWJfYDp/Eweo5OKMsXj6pnq0fpxBYjcQqIN97oObMgsM8lN0vrZe5MPCYZNnAAM1vZhCC2Hyt6/rohwhk6pjKavczIqo+OhGOgut9Ttx5OmWnevFcMxv0lw/3FmYi2WJwwjom2QUomg6oRaW0U238pe8813Qer+r6PfhzMasHKOXcaKJ4atns57HRPqDOkF8V6zzz6XYaQrvc8DWAvouPUmJfab8MQklm4nK4DLTv3ACAxrvTBvenSR/g16Cy7tQ01Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(396003)(366004)(346002)(136003)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(478600001)(53546011)(6506007)(8676002)(8936002)(26005)(7416002)(38100700002)(6486002)(66574015)(2616005)(5660300002)(83380400001)(36756003)(2906002)(54906003)(31686004)(316002)(66556008)(66476007)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXdjNkVCZDZGOG1rUVJSMHlrYTIrNlA1bzNEMkVQOEZEZGNpMXE4QlFQV3l5?= =?utf-8?B?ZThyMjVRd0pvaDNpOWJ0YWl5aDdLYkpNVDJHNG85QTgxNWlnYnFER1N0bDgr?= =?utf-8?B?bk1wdmIzTTVVampJUThneU9FcXdtcHd1WC9WeWdSNkV2cTFhUGs5R01hdVVF?= =?utf-8?B?NEdvU1pWQ0VzOWFVUUk0dndZSURmaVJlRFhyM3k1ZGdVbFdGdG9zdSs5eEsv?= =?utf-8?B?Z2M1WTFiN3FObEhmL0FnUFg3N2xYWkxPbUFmcXl1cE9VOEVSamJiMlJZSDZQ?= =?utf-8?B?NmNxaHRvRGltR3E3R0h2M2pLczhVMzczcFB6TUh1SkVTczFwckxKTXpVSFJW?= =?utf-8?B?VWtwYzZHeWhCT3BRY0t1Tm1jRDRVSE9WbytVb2E1a2pJRUFTTTJsNjdmUHdk?= =?utf-8?B?NnVKRjg2YzE1UkEzQkhEbnoxaVNiMmx1Y3FCMGtSSUh6TDF3RERrZzBCcU1K?= =?utf-8?B?R3Y2YmtlQ1lVTHVGN2s5QUllS1ZzS3I4VFdaamF6N1J2UVhZMGZrVG5IUkJl?= =?utf-8?B?MnorWCsxai8vUUJEOFZFYzN0SUZCaGtJSGtZdVh0NlNZTzR4UXVzeUJjblAx?= =?utf-8?B?T2NRUmhBa012TWFtUXRidkhyRlE1MmpOZjlMdG11MXllSjFnK05iVWR4WTcz?= =?utf-8?B?N0xvZC8zWmdNMXNabkN0ODRMbmZhUzBjaGFXeGFSb2xrVnJhMHdIRlA0MllF?= =?utf-8?B?MmMwbzkvSnhFbTNzTU5UVzVkNDJwWVMvL3NTN3ZjSTd6SWcyTlVIcUs4bzY1?= =?utf-8?B?aTVvWWFRSVBCRldtSFIzbjdWdjhDQ0VJS0k0ZEwyd2ZYSGUvN2t4N1VIRUNq?= =?utf-8?B?TjI5NVJ1SkVCazFLTGZPWkR1SE5RNGFPeWMzOGlwK1pYclJTSi9BQ3NMNXND?= =?utf-8?B?Vmg1OWUvNkM5SE5xdnFLSVN1WXR4S0JkaUtJa0xsdHZRdWs1S2RXNmxKcXhj?= =?utf-8?B?Zk43U1Bva2JBVjI0Vm1hYzlBZDBJUStMUkkzcVpoRHZaYlVxMjdpL0JOUTgv?= =?utf-8?B?OVAyUGdNY25YcDRsZ2ZCczFxaXJud3BzRkwyZUliKzQwWGdpdUxIVEVZRkE5?= =?utf-8?B?MnVaT1V4ZHQ4MXlEc1g0QXh0Yk9scHBPNVQzcDhHek5hejE3ZEt5ei9VTWVF?= =?utf-8?B?OUZsM1RDNzNIVGRwemx1QzR1Smp2d3RYbWJZNTNXR01rY1ZzVEsxelUyMkJQ?= =?utf-8?B?VFJhWlQweG1BZlNVZFNEeXQ5ZHMzaGVScnB1Y29TVHdFVjNtdVpQVGZHbjJZ?= =?utf-8?B?a0p6ajlUMkVVaDh1M2hiMWJHdWluWHBOTXRCdW5NQ2dvTXhXR0dUVTJXOVpU?= =?utf-8?B?d3ZRWFlCckluZGJQeVM1dmxwaUFVcHZQVjEyam50RTluRlpXdzZWM3ZwN0tT?= =?utf-8?B?NlZ5QmtCU3hvRDRoN1NKK3NEWFY4bTFISWlvRTllUVQxeVQ3eTNKSit3SXNo?= =?utf-8?B?bUlqWkRwOEJVQ0lXL245MENoNzZUSmdYdXBVaDlVaHNCUE53MTVCOUc2L1BG?= =?utf-8?B?bzltLzVxZFU0WU8xcGZ2azhrWVhxNk1FU1BxRFVpbk9VRFhOU1FzcVBvVFVY?= =?utf-8?B?TVJmRyszSlROZDFsUGJ6c3FWeXZKWGpYa1lPNVFUOWFackJzdE9hYmt0MUFq?= =?utf-8?B?amI2aVlIZCtVcGJTaUZibi92a3BBcVo0Wjhta1F3VFdhVzVJOVlrNS9tclMz?= =?utf-8?B?dXhqLzZmYVV0VHRPVkJIeUN6ang0a0R1V2JnbkNzYy9vMUdWZk5ibGt5NVE5?= =?utf-8?B?UmZzay9LL2gvWkxVTFNZakRNTmZaQnJkaVlrL3VRZ0ZLQjVFanRNQVAyOUhq?= =?utf-8?B?K1VqMzFmYkJpODg2Z0M1TGY5Vkk0czZpVDhLck1SVEluL3huYlVJSG9XVGNq?= =?utf-8?B?Y3RIVmZvdHJLeVVhT2loWmpmZ2ZWM2Y0VkNWV2JYNnlScGVOSjI1a3IxdDVV?= =?utf-8?B?bHNqMGlLc2doSFFVblFQSk9WSGJtbEJCaW1BNG14clFkM0llVTcrSkY3eWZl?= =?utf-8?B?SXRKWVhKMEJaVjZRTzZVcGZvbmROR1dWR1M5ZEdtVEY3Ylhub1VPMUZTRGNu?= =?utf-8?B?aHB2dEYyeWY1RmROQlpvdUVjMUd6ZzRzL3RUMmxSQkE4a2tZZUw1NTJ1Sjlr?= =?utf-8?Q?Z2knaOOvJ8HlSFkguF/SutYUV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e33042d-3e0a-429b-b8f6-08db9721db65 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:39:47.4949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8o4X40QGnbdCPORf5HDZ/WhaNxbFXCrO7Wo4nxjNQFtNsaSD6iIf5jY9VDQVrrSjnbHXKcAY4loTcZ/0mmrOzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9757 On 07.08.2023 10:18, Simon Gaiser wrote: > Anthony Liguori: >> From: Jan H. Schönherr >> >> Intel says for CPUID leaf 0Bh: >> >> "Software must not use EBX[15:0] to enumerate processor >> topology of the system. This value in this field >> (EBX[15:0]) is only intended for display/diagnostic >> purposes. The actual number of logical processors >> available to BIOS/OS/Applications may be different from >> the value of EBX[15:0], depending on software and platform >> hardware configurations." >> >> And yet, we're using them to derive the number cores in a package >> and the number of siblings in a core. >> >> Derive the number of siblings and cores from EAX instead, which is >> intended for that. >> >> Signed-off-by: Jan H. Schönherr >> --- >> xen/arch/x86/cpu/common.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >> index e9588b3..22f392f 100644 >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -479,8 +479,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c) >> initial_apicid = edx; >> >> /* Populate HT related information from sub-leaf level 0 */ >> - core_level_siblings = c->x86_num_siblings = LEVEL_MAX_SIBLINGS(ebx); >> core_plus_mask_width = ht_mask_width = BITS_SHIFT_NEXT_LEVEL(eax); >> + core_level_siblings = c->x86_num_siblings = 1 << ht_mask_width; >> >> sub_index = 1; >> do { >> @@ -488,8 +488,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c) >> >> /* Check for the Core type in the implemented sub leaves */ >> if ( LEAFB_SUBTYPE(ecx) == CORE_TYPE ) { >> - core_level_siblings = LEVEL_MAX_SIBLINGS(ebx); >> core_plus_mask_width = BITS_SHIFT_NEXT_LEVEL(eax); >> + core_level_siblings = 1 << core_plus_mask_width; > > > On the i5-1135G7 (4 cores with each 2 threads) I'm currently testing on > I noticed that this changes leads to core_level_siblings == 16 and > therefore x86_max_cores == 8. If read from ebx like before this change > and what Linux is still doing [1] it reads core_level_siblings == 8 (as > expected?). > > What's the expected semantic here? If it's to derive the actual number > of siblings (and therefore cores) in a package as the commit message > suggest, the new code can't work even ignoring the example from my test > system. It will always produce powers of 2, so can't get it right on a > system with, say, 6 cores. The only use of the variable in question is in this statement: c->x86_max_cores = (core_level_siblings / c->x86_num_siblings); Note the "max" in the name. This is how many _could_ be there, not how many _are_ there, aiui. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:44:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577843.904902 (Exim 4.92) (envelope-from ) id 1qSvqy-0004B0-DR; Mon, 07 Aug 2023 08:44:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577843.904902; Mon, 07 Aug 2023 08:44:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvqy-0004At-7x; Mon, 07 Aug 2023 08:44:40 +0000 Received: by outflank-mailman (input) for mailman id 577843; Mon, 07 Aug 2023 08:44:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvqx-0004An-HK for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:44:39 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060e.outbound.protection.outlook.com [2a01:111:f400:fe16::60e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a47cd7bb-34fe-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 10:44:38 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8197.eurprd04.prod.outlook.com (2603:10a6:20b:3fd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 08:44:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:44:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a47cd7bb-34fe-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UIFPR2QqIEEutfCvVVCHV8pERwpT43xiyOMiiq290T1csfXdhPKROBQEjg6C/zxGFMlv3BAOPS3sk0UP0D1mqPc5xRr75FliDL/Rp0TfbOqy/blAt7ASor4Ade6WSzIFIsdwhQtPyyYT8OFFXCCAVUMsAbPCgxxEdaa8ktmz/YOT3OUktCoNGB/TUKv95wpptGC9mqoyNL8UBuL3JisaQ9jAoNjyXN5nLhVDjgo3d4Rbe0rGnQZqYQczQHa2RUbVC4gd7oh9fc3yRNdmlKMrrsy3CB03LhSxvsEwr+vhjmaDVMfZPZ0M7OjKeYXuf42QEVauwN415kXf8EbTsrQLwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qoSFqZUl37POL6Jmc8YM33HSyUXquFBuoSRoCHzIMJc=; b=SmFVe0qpaLIjOEmRILRGMz79ViXepN/V++vhSDKhSttowDtuHUM3H2/mgFHKMsufWzrl81f+69Sqn8jWh7ANTKS16PMQdb09u+A11uvz4frFWhAkX0TtIA2hYycY6FcjG2aQoorKjtPJeMaqRJp3K+W36S5dYhyjgi/KPeHEGlSQ5tZNvlld8SYmRgdPVZMpyUiNGXagzLdv6CWCTeASxgsoJZ5Bs1uJ9aosqMxXwxYoH30BL6dUZs7dGVnTOp+BHqJTH++MGSxReVlwJQV+SXRMA+7xp0DBZdHdQjhzTOzsJRXDu7yWl+BMxl9bk00SVgLupVs/A/mNKeucqXitrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qoSFqZUl37POL6Jmc8YM33HSyUXquFBuoSRoCHzIMJc=; b=oRSflo1DjOJRtiERHF8ssecCDC4UczDE/VRsdx1XZV9EanIVptMMJ/e26NAlPmElP5yatuBDnfkg18TzS3p9TH6l28iVO1DN4sxI+4pwhytNns8+wl2B9SZMOJXvpboAlQDMTv8Hkoy1XToHFkkaQDMXBb52oc0Jmooy4BN3hvymHhzgYOqeH/kFHQuhqu+k3h79kkvXgB1knW/6gOjhJ/pXPSr+Gon0zHrfo9VjBcA0bglQApqzySxsmTbxqGWzkqQFAfyQWO2s8Ek81XzzLGjpDgGNGj8yd5wQd7vttsXxskoEuDm+nXrHNK+LED4SEEN3IG2WSctZeknYwfP5zA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <41d5d8aa-c936-2024-b738-2df5242513ec@suse.com> Date: Mon, 7 Aug 2023 10:44:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8197:EE_ X-MS-Office365-Filtering-Correlation-Id: f924a01b-198d-4bf2-dee4-08db97228749 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bcdEW+5+TfrGzsPR1XATNH++Vl9hSoJZNnYg1PXE4CjMKFA3Eq6NSh7j5Ism3EeAnF+bB9amDFCbXsAsvEG4pk1e4TVt02FLtxBCUJjE5m+8Qypuccf5UUJiBmJyFnzOUOUEiNy+QoYJNF9gNHd2uYIeAvDqZp242uaIwA3jbBMKAe6JlIlTbK1Byw6lWcSGAYMuJ8ZJh2LtJqggRuA8ueShgDEZOqOaZKbxUV4cuu2BRE81+KDi61gH3g5y6IhMZ8+YidxTelVi7vFoDCTEsBMlHPy7MMSrs7qNRQTBGs9/vccImnQer9CoxaKutjBi771UCBZZ8aIhu6DtUwi+2SYLzUL+o+9cPRfgQ+gPutNoNkYHXq4OA3N69eq7RFbqjBruUhXcLFCgHfMEKxzCyfKd21yQtyi4KnCzCxsIqKeTDL4lFYUIBqkESY0SYzHf8HzOqdzVHzv1QuTfxk/DI99WXo2eV800+EgnZp6JrJtHtOndX2+FDjhA2GWyQPC4gWLFe3YouHMz4lqh7+TX6py8qjKG7CoeqL9dwpHcLFuqfb4onDnoLfDy0/fwAPeRHHLneDdUUtzDCTHpweoSX+cwEQu02URxrG25MbTL1HlFxrLzESyQIBE3kq+kZwMz66nJTROK7Pe1QaK022lpdw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(136003)(396003)(366004)(186006)(1800799003)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(7416002)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(31696002)(6506007)(53546011)(54906003)(38100700002)(478600001)(6486002)(66476007)(66556008)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkNVbG1VMDNUM0RvYzFEVWZwT1kva3ZTR3ZEQ3g0UmkzUHZFTzkvTXdiM0U4?= =?utf-8?B?SjIwQ0FLWmtYUFlDWWkvbVk4UDYxTnNFZDlRQTBnQURGVVJGdTIwcGY2Z2x6?= =?utf-8?B?WHp0bDk0QVNVY0JLSkI3amxrdnlDYnBlcnhFeXBOeXZtbTZyaWNWYWJZVG9h?= =?utf-8?B?SFZLYWxzTEYwWW04S3pFN3ZwYUU0S2ZlSTJPNVdiN3ZFcFZRbEhKR3JGQXdh?= =?utf-8?B?RWtxeUlPQzNBc2NkSy9kakNXSE9RR1ZnMVlEV1F5NHBKQ3hLVmNCUTZHMFZP?= =?utf-8?B?NjNhY1hXdWl2THREbWorZzI5MFh2c0dSTlMzSWxYRjdvVUdlQWNsekY3a09I?= =?utf-8?B?YjRidVFYWGkxeTI3OWR1cSt6Zzg1c2VzZktIbnVEMUtGVU5yN3luN0UwalNF?= =?utf-8?B?OEFGRSt1THVaL1pML3VxdENHWEVzbVprUHZZYVRWd1RRS09OZ2VKaDV5S25n?= =?utf-8?B?ckdlTWRrZ0ZTN054Sit2QktRbjZyOTB6V0VpNmxJUERvbmJEZWtKTjNYd1hk?= =?utf-8?B?Smh1QklWSEN5YURVNDdOdEdaQ0pWWUNBRy92TzNnYmRGZHlzVjZNZWVTVFV1?= =?utf-8?B?NFhaQlFWVk9XQWtwTTBsb2dRQUlXdjNpenhha0xDNHB1TUQxWVJ0SURIa0xO?= =?utf-8?B?cnhONXFMMEVBTzN6SUM5QVp2QTZNRzNHVHMwSVBqZ2JEZFpSZm5idDhINVAv?= =?utf-8?B?ZHFtN0QyL2Nwd2pPbWRvNUx0cmw3TXcrSDlGdCt5ZGJzZUttWHc4Tms4OEY1?= =?utf-8?B?em1UdWhOWUo1aUxheElpbGticEgwMHIzMWVVYlU1eGpkc29ETjRiYUdxZ241?= =?utf-8?B?NFlsaFcxSXo1V3lLZXl5WUdkTDlLUkZhWmRRZzNVbk9rUkNPUkh3MXZpNWtW?= =?utf-8?B?WWNxQmFzMDJFRzcxZExxNFptbzdGU3BmSk5oR2kxcHcxZHRzcVN2bnFRTFlG?= =?utf-8?B?QlRuMDVKcW5uSk5jUUpTSVQraHpPeHpqQjJBRnpXZDFGTVMvNGVDQXhFMEdm?= =?utf-8?B?emsyTTVDdjlHMjVFV2JybytpWHlUNFlLZ2V6bGg4NWxBdUQvd1dNMUZDMEMz?= =?utf-8?B?ZTMzNzV5bTRwUDlvcEd4WE12R0xtVTNyVTNsdWNiZVR5MG5Td0paS2NDNDNL?= =?utf-8?B?MEUzMVNXNnBnSENBVnRtNGhhdmgwTHEwcDlWcVlzc1ZXVzI2Zm1yNURBbG1S?= =?utf-8?B?c2JXbDl2cjRKeDVraXp3WkU5VGdoWk5BTnB5OGJQVFZBbUxZZWZQdXU0NXZF?= =?utf-8?B?Qk1mUnVzZjgrdEwyVm9xRE9oVmxrSXBSWXkyS1ZBMGFGZ3EvUll1bzkwNkFm?= =?utf-8?B?S0tmR050RC9MNmVINElLWmxhYUUrRGtVaFZqWjAwYUluM2hpR0pSUm8vREhm?= =?utf-8?B?L29qMXFUNW9yWnNzY0tLcFdiSmhYREhDREpvdFYyUmIvL0tMcFJBK1hMd0sr?= =?utf-8?B?QnYrVW1BVUZtTjNoYUpoeVVDc21YTmpjTjFqLzRadlo0eGRONVJXTGtXdUwz?= =?utf-8?B?Ky8zaHoxMG0zV3k4Mnh1UkU0dVlRNDZTdjN3azdxNmFzQXpGM2Q2emhmS1J1?= =?utf-8?B?RGRnT2cxYVVBRlJUc0lFdEl2YVY0WEJ4MGVrS1d6NlRHb05HVFNjaHpIQXls?= =?utf-8?B?NW9UaUdXdkcyeUdHSUxPRFNUd1dndDIvQ2NmMGg2em5TVWdJQTIrdEFZUThC?= =?utf-8?B?OUJEMlVUcWpTb3dSMDZlYVZnNysrWWFUU2YvMzF6MTRaUEQzVWVoRlRvRi9i?= =?utf-8?B?aVlpbWdXS1lrRkFoTFdDaDJaQ3NCLzVlMTFtQThVV3k2U3c3clF4R0FUb0dx?= =?utf-8?B?U2hmNVBEMnh5VVBQUmcyZDVvMXFyY2h3dC9iSjR3UmZaMDhmWW9qWjVMUHhB?= =?utf-8?B?VnJBeHMxSWVuTTdTS3VNc3BRTUV2U2tJZDI5NVBONnpMeUFiUHk2ZHBsTGFW?= =?utf-8?B?OFZIcGpQdXBYUGdJK1BTMWxDOXhHKzBBS3Y3TCtaTE5rZEdFaGRJeGNUTHhy?= =?utf-8?B?V3FnM3E2TUpCRis4dzVPcDVYb3g5M3RtL0R6a2NkTVhiNlR4YTBJeFptclVa?= =?utf-8?B?dW5lTElHZlBLUTBlMnJTNG14VVdmY0VUbTV3L1RET0xYU0MzRnNpWjJjbGR2?= =?utf-8?Q?kHS2kSFIca1illgl0zqqse20B?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f924a01b-198d-4bf2-dee4-08db97228749 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:44:35.8844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: in7XfwW2D8s8DUkmS1uZ+OJZ6QyISAl8ykVgfDMbzEySfIOfn0irKK2FK7eajnjAyQgKNY8sM13cJ65/fSyR8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8197 On 04.08.2023 16:11, Federico Serafini wrote: > Give a name to unnamed parameters to address violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between object and function declarations thus > addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an > object or function shall use the same names and type qualifiers"). > Replace the occurrences of bool_t with bool. Hmm, I read the title as a promise that bool_t would be gone from the code base (which I couldn't really believe). Perhaps "... by replacing bool_t uses"? > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -26,11 +26,11 @@ > > bool __read_mostly opt_dom0_cpuid_faulting = true; > > -bool_t opt_arat = 1; > +bool opt_arat = 1; > boolean_param("arat", opt_arat); > > /* pku: Flag to enable Memory Protection Keys (default on). */ > -static bool_t opt_pku = 1; > +static bool opt_pku = 1; > boolean_param("pku", opt_pku); In both cases this also wants switching to "true". Happy to make that adjustment while committing (together with whatever adjustment to the title you'd prefer), at which point: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:50:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577848.904910 (Exim 4.92) (envelope-from ) id 1qSvwr-0005g3-Vt; Mon, 07 Aug 2023 08:50:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577848.904910; Mon, 07 Aug 2023 08:50:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvwr-0005fw-T2; Mon, 07 Aug 2023 08:50:45 +0000 Received: by outflank-mailman (input) for mailman id 577848; Mon, 07 Aug 2023 08:50:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSvwq-0005fq-LL for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:50:44 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060f.outbound.protection.outlook.com [2a01:111:f400:fe16::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7e1594f4-34ff-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 10:50:43 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB7893.eurprd04.prod.outlook.com (2603:10a6:20b:2ab::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 08:50:40 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 08:50:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e1594f4-34ff-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WnBYKO04nSaRNyukKv1hlGfmO5rNHF4aPTgebARiTSptoSDErd52tBHdyoWjyw11J0PO46l/8/KeHJIi7280a2BHIuyaIBlnomlq3FFIBhwTuTjifsC1hynSBTMToGyRcREUifRj810dUw3p2PrjyNLuYX3FzIeeVgkkLYE6dua2VvIvJ1ZkpVEiECOsdhbCsrSE/59CxL4VUa5kvpoaoKK1IFRO8xpRfs2UyVafxYkSoavRP7TGSvqOpsNIou36+3dwS7ioHwfIyCs1jHq3fiTKMkSQVflLJRWeKxiFujV4hS+1vjIju1BQUY45B6EEmZA2h1AEhgp2W7971S/2ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aYwG75RdvN5ed9YDpfIalpoJSJXCbFx7UtoQRKyDjOQ=; b=OTqhXw1Drvm87/DeV9ZnOMHUes68UT8CwtTwcqvpEq2Mi14zgDuOxT0OepRT921XLe7nGNI41Zdb5PYQ+tvWWt0ge8fylCez8pEuKnsVD3PS1CbMSnOY14OTwmD/glcJcLH8/qFrvSLLQaj0vxW3BCFO6EIVaL1ITxOf/Ci+TmLx05qm6DABxJ8ummOC7HVnnhDBu0NkCyIhtwWI8qMMCnOZUv9X1pz2BcpuVDfMR223qVjlkvIc68uwuu3nxAxaod32y/3w0rzikA7h2vLPqWB0yMQoJ+mrm44UY7pHXRHDJRh5tWuDbSKZ9KPv87yPYnrOYojQ0jY/3HNz3o9vsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aYwG75RdvN5ed9YDpfIalpoJSJXCbFx7UtoQRKyDjOQ=; b=KvG+Brsp/7NSVgjlUafxiVJ62fwDM1zibRK+OcOZG+SE6ZbtYeftKoYvEwBo7U4pqIqq0PjyUz/pYa2yorWx2vGc8VciUL1BSt9Y2Od/VZ1T3nklJE+5cG+PMKCbH5pWK7GC/n8C+gF6dYq0SO9N0QF9uSoeBNUgTwKVauW8XiRwfA3T9LdezvmKitQIQ9E8XadOXgBtSeUEPdXClt3V2iCJgcV/eLCQPCZjakl+wRT1u5mtw+fN95002bwj6QmkbfvmWFypCAPlNcb+wxKkcaMPLekZqRaWCfLHaAdJxSjT5HkVNE35usdDdvD3E0ZZc8kXSGP3fqOocspB1mi5zQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <90aad07d-9445-5916-fd3f-eeb08280de59@suse.com> Date: Mon, 7 Aug 2023 10:50:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> <4c5b5091ecae8b1314ba67825f4a959d@bugseng.com> From: Jan Beulich In-Reply-To: <4c5b5091ecae8b1314ba67825f4a959d@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB7893:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e7adb2f-0591-4c7a-a577-08db9723605e X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Addp3JacsJdiwDmrknhNkaviWKZbDVawVJBro/l3gLfu4z+BVkDrlDVxxa8IM7UXdEXlBsJPsWD1krF+J+cZvjzHnxnEOoJB7Log6AwauXnTyOU7DhILSYR79trSDZp0SXw/spuvrMYXtttKpipSyWTVqhvG8kwngpKh9wtnFlOzZ/bnXvjAY+c/8fsUBkUZ74dA6I2UOrWyo7bKEcRARNNCLHmA4RZFHETZmob5WRAZePufuYvWKUlUeqFpbxbdcmdmeU4eW2GNeRYUAQo2dlph6TadCwJ/2xJqRzu1PYvUJLcPOzehkQMwwcf4qxurAcSevvsA1hGrTtYvM4TnYUry0+4N6Z+vfnLkkpejIECvCJmVMeQvpSR1DHZgmYu/jijvc6IR/llisD4a9u7skkLSv5KjXSw6JEf1uWcSTwIWaLnvKX33KlU3SNmEXM1sn4UhUPPPhatkjrsD+FRdPpAQi6Q8dDi56YwEf3qnaVXjc518zge7cew/GRdvYgvQIPb91YutWr73Oo8ZrXW5IhC9juslheG7Gevx/GgClVjbtsPs69ybGYF546yjPWRYV5xFjVTPuUehePgqVn13/1ATLLz9UReIFdmlxdn1FaLihYtnMlltZeUMJBTfMAH/GxL0RNlD3kkrFzdF6IZjdA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(136003)(376002)(346002)(39860400002)(186006)(451199021)(1800799003)(8676002)(8936002)(54906003)(478600001)(5660300002)(41300700001)(31686004)(6916009)(4326008)(316002)(38100700002)(66476007)(66556008)(66946007)(6506007)(53546011)(26005)(2906002)(4744005)(36756003)(31696002)(86362001)(6486002)(6512007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWFrNDVJZzVwUmVhUmlkN0lUZFV5QW00OU5LRDl6ZTBMV3JEZHV0a0VZemQ3?= =?utf-8?B?K1k3MjZ4SmNaRjRiN1FEa1hoNTR6QTAyYjRCdGl3bVdyRU45N04zS1ZZcEdO?= =?utf-8?B?K0VzalEzRUM3Z2NPWmI1K1Q4TFZTZ0NSWXZuWXpjN3dqOUcrcW5TQU1FSHpq?= =?utf-8?B?Z1d3VDhSQkkxV1NEQ1pOL3VtWWNiK0I5Tk5CRnlwVFY0R3YwRzMwU3NqTlph?= =?utf-8?B?Ti9aNVVmRmtic3l4N1M4VkFDSXZzcU54Q0VXdElxaFJtTFdEaW5CZGozQmlx?= =?utf-8?B?UGt3NkdXRW5haDZseGZLd0FMSWp6UzRoQXpTa2Q2TDUwQ2NmQzlNSkVud2Z6?= =?utf-8?B?WnNKaCtUclN6d1Rva3FBaERUY014QWZ6K1ZqKzRuWWV0cGFqWTBsNUxKQzly?= =?utf-8?B?eTlmc0xleVkxT2VHdWI3K092anNLWnUvSzgzRGJHMnZMRW1Xa3JOVXUwMFlh?= =?utf-8?B?OFIxRTdERW1ZT0dTVGRrTFJhRUNLQ3VqU244YWNBZTlkaXNtT3dNMDE1Qzhl?= =?utf-8?B?UW52VlVMVDhQL1pJelRIdU9jNE5oL290aDJkbkRxdUlRTEI5aFBqQVFJTW1z?= =?utf-8?B?cFg5ellBTy8zVU80eGJuVDhzNzJWYXdxNTJqSWo1dmZxK3NhSzN0OHg4VlJH?= =?utf-8?B?cytGb0xURGRENHFlMHU2TzRmZ3ZmSVpOSU0zclZzSGp5bzNNSHpWMERGTEpY?= =?utf-8?B?TmFxTEorOHU5dEJtVjhpaC9kSXNrRUplaHBFV2NON2pBZVE4bWgyOUV2TENZ?= =?utf-8?B?MEtLUEVJZC9uRldreFhnNmcxOFBGQ2tpZ1NOSC9TU3ByNFVINXNsK2d2SEFR?= =?utf-8?B?aHZWWUtwelhZWTY4dytlZjVyQURoeWhkSHdSRVp4OVppSDQ1ckZnYXVHM3Z4?= =?utf-8?B?YUdUZ0pKaFdCSE16SVVrdGNhcktEdkFhaUVHSG9jNUtha0FxL0lNN25heDE0?= =?utf-8?B?a05rMUlNQ1VyZ0M1NFhlQU8zTXFkMkZiUlZEaFNSeEk2SHdlZDE3a2UrbURI?= =?utf-8?B?UmFKMDJ0aWVHQ1J4MjhDVXRZT3dPdHFJZzFsUWQ2YnA4VDhnMm1lelIxUHIx?= =?utf-8?B?ckpQWFBkWkxvV25MTE9RWE5OT1hySVRmTEF6VnpaTmJrSnVEZGJFU2o5UjZl?= =?utf-8?B?ai9RWStYNWlKMzRjbFBFdloybDVadFhPRmkxd3hmWjVjalU3RGV3Uklkbmw5?= =?utf-8?B?SFIrQmpoVmtuZ0tyQkVHNE9nOTE1dFcwSlJYZ0xXNnp1eUVyTm8xN2JORi92?= =?utf-8?B?bjFaekc2c3BqOUExb1pzT2lRMHU1bFM1QkRlR3laSWg4NndNb1JKZERsdzZ4?= =?utf-8?B?d2F1UW5NRHlscmJhU29Ydm91ZVBZUHVYa1RoN2x6U0FlVk8yN0VDT2c2aE4z?= =?utf-8?B?NnlBa0YxUFEwMlk5NHBzQSsvd2V4dk5zODg3TVNtcUNaNUZlTEZ5eEkrRUIz?= =?utf-8?B?eVpraUU5SUdZTkZoNGVydkFPY0kzd3pmZjNZdXVFVmZKWmsva29FZ3ZNRWJY?= =?utf-8?B?M0h2UlBRTk16b1pYMzVXTnFMR3kyUmVBUm95eGd2VzlZeEtERkdoRWROZGZ2?= =?utf-8?B?UndQeW0xTm9nYXFTdlZQQzRjbzdyZytzMWlQOWJubW9Xb3J5NW9EcHdZVVcv?= =?utf-8?B?T2lQTEJKN0NDMmxabVo1S2dIUVhFNlBFQkZjWUszUU9WVXk0TXM0VmIzMytQ?= =?utf-8?B?WTBXWS9aVkR0aU1rUlZLK283MVp3KzZDRTdMcW9kT2VlbllsV2h5MlJLelFL?= =?utf-8?B?N1U2dm9ybTNTNVBMczQyMWk5aHRHQnRoWGtqMisyVVZQTHoyNVVGUDNoa0Ur?= =?utf-8?B?TlI4eHRQd1VkRzYzWmhOOW1EbXlxSjVxeTVvV09hNTQ2anJXclVJQUx1MTk1?= =?utf-8?B?dzdrcnF5cTluQU8vUjlGWStHQUI5WUd2aUp3ZE96UmJodFYrWjJncXNEUEpR?= =?utf-8?B?R1NEeTAwQVU0MlVNRStOZ3lRSzBIU1VaemN1YzdLWmdUek1acm5BY2ZVblJ5?= =?utf-8?B?eU5BM0hkbVVWQVFVM05CTWMxeXlBRDIzOFBPYzV2UFJmSW12bVEwcWphSk56?= =?utf-8?B?ZnlGK3k0cktyZ3lUakdsbnFzaHBheGJ6NXBnOFBPUmxhV1FBcFh0ZEhlTnpV?= =?utf-8?Q?oprD8my2da3pgX0Iaw3YYivHE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e7adb2f-0591-4c7a-a577-08db9723605e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 08:50:40.1070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H6Zjsvjj+IVMlqLtmqqEXU+ic0HrEDKm/3c62C9qT7+kRFqzpuyVqGl/NN0+k6p7fJYVQZLR6tx4Pxi7KLTjUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7893 On 07.08.2023 10:13, Nicola Vetrini wrote: > On 03/08/2023 11:17, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> --- a/xen/common/sched/core.c >>> +++ b/xen/common/sched/core.c >>> @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int >>> cpu) >>> /* fallthrough */ >>> case TASKLET_enqueued|TASKLET_scheduled: >>> return true; >>> + ASSERT_UNREACHABLE(); >>> break; >> >> What use is "break" after "return"? IOW rather than adding code here, >> imo a line wants removing. > > The "return false" after the switch would still be unreachable. The > reasoning behind preserving the break > is mainly MISRA Rule 16.3: "An unconditional break statement shall > terminate every switch-clause", which has > not yet been considered for adoption, but might be in future > discussions, leading to putting back the break here. Well, adding such bogus "break"s is going to face my opposition, and it is in direct conflict with the "no unreachable code" rule here. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 08:59:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 08:59:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577854.904920 (Exim 4.92) (envelope-from ) id 1qSw5b-0006Ov-UW; Mon, 07 Aug 2023 08:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577854.904920; Mon, 07 Aug 2023 08:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw5b-0006Oo-Rz; Mon, 07 Aug 2023 08:59:47 +0000 Received: by outflank-mailman (input) for mailman id 577854; Mon, 07 Aug 2023 08:59:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw5a-0006Oi-Dd for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 08:59:46 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0d139a1-3500-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 10:59:44 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 4FACB4EE0737; Mon, 7 Aug 2023 10:59:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0d139a1-3500-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 10:59:44 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <838a53b9ef4a8d258feceabb4c811534@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:09, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> The variable declared in the header file >> 'xen/arch/x86/include/asm/e820.h' >> is shadowed by many function parameters, so it is renamed to avoid >> these >> violations. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> This patch is similar to other renames done on previous patches, and >> the >> preferred strategy there was to rename the global variable. This one >> has more occurrences that are spread in various files, but >> the general pattern is the same. > > Still I think it would be better done the other way around, and perhaps > in > more than a single patch. It looks like "many == 3", i.e. > - e820_add_range(), which is only ever called with "e820" as its > argument, > and hence the parameter could be dropped, > - e820_change_range_type(), which is in the same situation, and > - reserve_e820_ram(), which wants its parameter renamed. > Alternatively, if we really were to change the name of the global, we'd > want to take a more complete approach: Right now we have e820_raw[], > boot_e820[], and e820[]. We'd want them to follow a uniform naming > scheme > then (e820_ first or _e820 last), with the other part of the name > suitably > describing the purpose (which "map" doesn't do). > > Jan Besides the one you listed, there are these other occurrences: - xen/arch/x86/mm.c:4678 in 'arch_memory_op' as local variable 'struct e820entry' - xen/arch/x86/include/asm/guest/hypervisor.h:55 in 'hypervisor_e820_fixup' - xen/arch/x86/include/asm/pv/shim.h:88 in 'pv_shim_fixup' - xen/arch/x86/setup.c:689 in 'kexec_reserve_area' We can take the first approach you suggested (which was my original attempt, but then upon feedback on other patches I reworked this patch before submitting). My doubt about it was that it would introduce a naming inconsistency with other e820-related objects/types. Anyway, if e820_map is not a good name, could e820_arr be it? -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:01:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:01:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577860.904930 (Exim 4.92) (envelope-from ) id 1qSw76-0007pw-8Y; Mon, 07 Aug 2023 09:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577860.904930; Mon, 07 Aug 2023 09:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw76-0007pp-5c; Mon, 07 Aug 2023 09:01:20 +0000 Received: by outflank-mailman (input) for mailman id 577860; Mon, 07 Aug 2023 09:01:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw74-0007ph-GU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:01:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw6z-0001Dc-Lw; Mon, 07 Aug 2023 09:01:13 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qSw6z-00055e-Ez; Mon, 07 Aug 2023 09:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=tvpAgZpWu0drG7uizeyAn3qShsucxpZN45X6EvbFQns=; b=ue8JL1dIdYcUVFlNXuss+xO4pb ULKPyNxSOOYFWHjWkKOgfZHpiQn2EfGDzf3wSSjTabwCUbQ6UT5Z49Hx753hZzdiId/WvcxFWDivY rQbwb54rBitfTuwheRI4mi6HhrkbEeXbWBwPBKDr0z5eQdBO+O8yRugRfzWxcfbbNw9Q=; Message-ID: <486ba9e1-2bf0-4446-9ac4-33a256f8d51e@xen.org> Date: Mon, 7 Aug 2023 10:01:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-GB To: Jan Beulich , Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 07/08/2023 09:14, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> --- a/xen/include/xen/delay.h >> +++ b/xen/include/xen/delay.h >> @@ -5,6 +5,6 @@ >> >> #include >> #define mdelay(n) (\ >> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >> + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) > > As elsewhere, please also adjust style while touching the line, at > least as far as the obviously wrong case goes: > > #define mdelay(n) (\ > {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) > > Even better would be > > #define mdelay(n) ({ \ > unsigned long msec_ = (n); while (msec_--) udelay(1000); \ > }) If you are touching the style, about converting to a staging inline and also splitting the line in multiple one? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:01:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:01:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577863.904941 (Exim 4.92) (envelope-from ) id 1qSw7d-0008KD-IO; Mon, 07 Aug 2023 09:01:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577863.904941; Mon, 07 Aug 2023 09:01:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw7d-0008K6-FS; Mon, 07 Aug 2023 09:01:53 +0000 Received: by outflank-mailman (input) for mailman id 577863; Mon, 07 Aug 2023 09:01:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw7b-0008Jm-DI for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:01:51 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1a::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b98743d-3501-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:01:50 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9381.eurprd04.prod.outlook.com (2603:10a6:20b:4db::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 09:01:48 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 09:01:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b98743d-3501-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBfzJIgihq0s3nG7bvywxziL/6NYrRTVESamOp87u6g97u5wsRUgRefmY4i6iq7s0mK0hWKUm3HkvXT6OWbfobfJ0mqsyrW77PuiNeqlSWtuvKWg2he0iwflw38fdnI2c5LHbNin5OQi7dI3VaGzxKNUtsWkNWC01QvUYJ9PVIZ1fhYCihthISpzNUrOsixFCreiYY2FkIg7e20ByzBV26pwYC829DMZCNNDUawhCHJmnrSRpsXOlxX5KjPy/3Gv419j0YwfRldQ/i7w+zWF9qozYHCHkIrScjy4Bds38A1EO+b8fFGbntfCLI/gIeMhf16IisGzLTeGoyFZRRV4Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Oscl5ZzZsMm0gGBcy8VQGN//tUTIYOVL1oLK6kQsqc=; b=l5Mnyb/Ep+6+1dJMvzNQb5mPo+9Mil7BlvwpVmLY7+0TwAn8M3+Wh7IFzxwrmZdnu9WKtT/963gB2UxPJoZNypYOFSOhlR9ABsNxGoHZw57UDBoR6KO6HGj+TNVwmqVpu8UDJYc+4TxZfcQgoUgNR6GDDNv/moyINZSqegMGdFeyuEc2wMChOB2wUpI3RxBZsV9HTwSG7cKqweaBT9TrZ6rUTbmKxfhjlD0N2t0YyjNe00DxQGawpZ4Afzanjfq9+/MApTw6E8S0TWJDrjUdNFFjFAfkUhIs23LPaSaEsIVIoxK8c1MMbJdNUX3DkRRnzqeD5/hmTsaMWVJJathKgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Oscl5ZzZsMm0gGBcy8VQGN//tUTIYOVL1oLK6kQsqc=; b=hFGN3/5pozk5fdOYPd66WoP29l4yPaATItBooZZ2xke2vFLhcDynS4Q52NaQWa1dwb4V1d2haFOPJC3AwjmjEWvhk2kM485N7cKc98e5oJDq95a5c5dqiQ5nqEvYWKSiwZaevKUOeMgHaw6sw99StxT1XSQ9CqPvSDESWFOTQZx6766WlBodH+XbBuB52qhIAVJfa7MOWO3BDyCyQ0NG1QmfQ3D9cJuS5qQgcCP9I5chtRcbViaPKFPiSmtTLUv8cW0gQG9mSll01RAz7xNjTb89WA6Yw+5T1v2dL9G7gYIAYWy1If7/fO5Y1+4oybTm+sfGPRxAxV/c/Rq8eIaiMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 11:01:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v7 2/6] xen/riscv: introduce dummy Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9381:EE_ X-MS-Office365-Filtering-Correlation-Id: 710a6136-ef37-42e2-05ab-08db9724eeec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Bm9AMimLSJg4PTYGXRH0kehVRc/317DmLjcdTfs0ZIBllQV0TVpqmh66SXfEyWAwF8RljHBj7wW2vSVbyzS2JlYoAuaUwRgjBAMbLL32xx5rls0sTZyOVadyjku07mIw+edvIUySw7KEFifLijXehLBN/LR5FewBsr44TIIF4nJFDvjAQAOAvMlnsZM4DoU3bWaEDv8jlngZJSXaCAr5uLCCn5uFyEaEs1NhD7GEid3HrGisaKvA56q/iYeqc6eo9t47RaleJ0aQzjdknZM0cP5tdaTJpvQbo3vSqDcdIvz5de6QSOtIIFzCScIaSNP8jDwRI2mBe/gV3kHtrPtehxXV6GBc4JTmmbQZWnHK7qAKZinegsJ9QnSVajZvEeGzPzQUAvoQERF8mpO4aKxfFciIbtMA3ipu6mFTqL7BIwHAgo9CjQqstFu1hevdfSy5PYBbjZe3SYKGTgBc46c1HZRJLaj210xwlGyh0MabI2J+07KZnTaMD2NqSVtqcnnaEoQ6IglE/KHxGlSos1dfVvPPyeKIwSJDuB6XFyZS2J2ljvu+lr8Irtttw7AACZbVer83iOa2OwcL2BSG+jjcQ6CTemm3Fdx5VY8qrdGSzZbG7dABixqLwKJ2ov4tdzrVOc9Xiv4HKC8gVux705rYw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199021)(1800799003)(186006)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(4744005)(31696002)(4326008)(6916009)(2906002)(66946007)(66556008)(66476007)(41300700001)(8936002)(8676002)(316002)(478600001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGc0ck8xcVFieG5Qdzd0VTdwME8rYis2Ni91WUx3TDRzTXRNcVV2V2pycGlD?= =?utf-8?B?dXBnUkR1ZHN3S0lVdjN0Uis2TGRjRUsrY2hvZWg4L0pDcTl1aE5qOHRWMlNu?= =?utf-8?B?bXBxbWFiMDlkeTVVeEFTMXRvOFdFblRQcE4rY2Z6WVRrSXppV1dMOXRFRnBJ?= =?utf-8?B?dEx1NGc1L082NlFWQWdOS0UyUTZ1VDVtUVIycmpsNVVTVHBiNkNZWEFKZ1RN?= =?utf-8?B?MUhiT3RoQ3RydlNxOXNSazZ4THlqMUxzWFNDd3laS1k3SUluM2tmclZBVUdp?= =?utf-8?B?NG1vQUcvazNPYkg3QkM3M21qMDNDU1plQVo4SERGaytUVi9mQU5pYW5TRFF5?= =?utf-8?B?Zlh1MFVYYjlma1I1dmJVbVg4MnQ2MVhMaHdCbmpjTlhzTUZDRHdjdGlnSU5o?= =?utf-8?B?ZVl3eFRJejBqTVZ0VzcxRkt3ZTBiLzJLZlVoamt4Qmh5Z2dPMHh3TlZzQUd3?= =?utf-8?B?NE9RQnhFaEZNbVJveVhJTnBENnQvS1pwaUI5YmNwTTluYit6amx5Ykl3Qms3?= =?utf-8?B?Zmc4Uk9WenVia25Ca3pXSXV6eGM3YVpUMlZSVHdROWVvWm9uZTd1WExUTC9r?= =?utf-8?B?VlpGVUs0RkNvWSt1ZVhValU3OTl1NzdWMlVUZUZJVGFvSGVrRm10VlhPTjRO?= =?utf-8?B?UmRnbjdIa1FQb0V6dzdzOGFwc3dqUzNDczQyQ1N2V01GSlpxZUZsKzc2b1dF?= =?utf-8?B?c3ZONkdYeldDVDdqOFB5N1BDa0dyQ0pFMmtXTE8reitXcWtWbFE3RGJCYjF6?= =?utf-8?B?VGJDMGc3a2tzSytvS1NXQmV4RUhobU5TQjh0NG50dmxGa3lob0JFRWdFV05v?= =?utf-8?B?QWNsNHI0Y0hWM1hzcFIzZTJTWUxzWjk2LzB5RnM1SVptR05YNUpVeTZoMXNn?= =?utf-8?B?clBqbGdMb2VKTEdLVkJYT28vQ2RZaElJZUR5d2l0ZHJaRUFWdlc5U1hvWHlj?= =?utf-8?B?SVVFY3diVU5NQ1p1T0Y3ZDVkOGswekhNakk1RjE5TDBnNVp3T3lMVm04c01i?= =?utf-8?B?RlE2Y3FRQmcvVUdVNTYzVFNvbmxZT1B6NFZ5V1NuY1lSU3FrSkMxVythL1hp?= =?utf-8?B?MEdsK2NYQjVTb0JnVml1M2Y3dVR3Qm1ZUTN3alR0cXhzL3BZVW5MZVpoRzNl?= =?utf-8?B?M3luUDJmd1o3NGlQQUZVdVlXVkZIdW40b3pKb0dKYkNvMS9oc05vZEJYRXNr?= =?utf-8?B?c0Y0ZzY2Y2h6ZzRhTnFuTkJFMkVUdmhlWnJrcXhhRFZmTFk0eWk0aUQ4MkRF?= =?utf-8?B?V3NsVE90THNTNUp1aEVlL3JWWGpvYTRuNUJsU3liY2ptM0ZQME9DQSs1ck9j?= =?utf-8?B?eXJQa0EwRUsrNUk5ZExPSENCYndvQkROb3g3dlFOUmxxcm45T0ZJazZqUEdJ?= =?utf-8?B?MU5HWWkzaENZR2pqZjJFNm9rbTZuT1EyWGtSM1dQODhqeFlhZG96VWVDUUpk?= =?utf-8?B?RkF6eEZURWhFQnlwcks2a2NBeUlyYWNQK1ZhTnFPZ3F4T3NxVFlKUDl4QTVu?= =?utf-8?B?cHd2VVFyOUFvNitQNGxGSW9pWEhYZnJRRmRkS0dtTGtGNHd0MTYzb0hpRkZw?= =?utf-8?B?OHp3bzZoRkxQbm9kZXRyRVNjNjdEVEFwU1BkOGFVN1ByQ3ZObnBBcVh2QTdO?= =?utf-8?B?RzNBWllZY1dmWFhQVERqT3orVUxzcXkxd25lWklrckVpbWM1VThOS3A2WFU3?= =?utf-8?B?R3gxTENPazF4VTVLVm9hK1B4VXpOQlN0SXZGdGFadUtBeEJhamN3d1V6aUp1?= =?utf-8?B?QVRIbGJKTnQ0dktnUHByZlF3R1NEVFg4emQ2NDVLQkZKTkk1NUpxakdtalNy?= =?utf-8?B?YVQrNTBaT3p1SlRjUlFmdElVd2p1Nzhyd1JuRHg5ZGltbjdRMjdUOFl3Uk9J?= =?utf-8?B?QlUrcDY4YWNodzhJLzI2dy9UVlE2d3hXNjJyaVJsbWNaYTgzcnV4MXVjZDRH?= =?utf-8?B?SFd4UGhEaVdzTUhTV2paY25zTFV0TEZiYjlGVUxQeStzcDVmcFhUQlhWaTgv?= =?utf-8?B?dnpuUlAxWVNoVStveC9QSkkxVi9RZjRZOHBzek5jOENKcjB1eG5xWEVtWnpq?= =?utf-8?B?WjRIWXVuTW1NeFF4SFJuUTJmUHZsNmoySjZnb3N6d0tVTjRDYTFiTGhNSEN2?= =?utf-8?Q?UZWVBR9LWlpmzCp8dWk6Ovzyn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 710a6136-ef37-42e2-05ab-08db9724eeec X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:01:48.7158 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ippd7hd9JY5DOE2dQ3T1uqCVMfdhAgdpfQFAYb7lx/w1N/+8S/FhSfNwdWQFlT3AQUW7b6cqYr0V4+ZmUm9UaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9381 On 03.08.2023 14:05, Oleksii Kurochko wrote: > will be used in the patch "xen/riscv: introduce > decode_cause() stuff" and requires While as it stands the description is accurate, I don't think that later patch has a need to include xen/lib.h anymore. xen/macros.h will do, I think. Also please don't write descriptions in terms of "patches" or more generally future "commits". Their titles may change, they may disappear altogether, etc. Finding such a description later will end up confusing. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:03:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:03:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577869.904951 (Exim 4.92) (envelope-from ) id 1qSw8p-0000Ue-SV; Mon, 07 Aug 2023 09:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577869.904951; Mon, 07 Aug 2023 09:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw8p-0000UX-Pe; Mon, 07 Aug 2023 09:03:07 +0000 Received: by outflank-mailman (input) for mailman id 577869; Mon, 07 Aug 2023 09:03:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw8o-0000UO-JR for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:03:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 38a5eda8-3501-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:03:05 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 2B7334EE0737; Mon, 7 Aug 2023 11:03:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38a5eda8-3501-11ee-b27d-6b7b168915f2 Message-ID: <3abb05c9-93b8-3a0c-3a57-4d8fd89bfc14@bugseng.com> Date: Mon, 7 Aug 2023 11:03:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t Content-Language: en-US, it To: Jan Beulich Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> <41d5d8aa-c936-2024-b738-2df5242513ec@suse.com> From: Federico Serafini Organization: BUGSENG srl In-Reply-To: <41d5d8aa-c936-2024-b738-2df5242513ec@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/08/23 10:44, Jan Beulich wrote: > On 04.08.2023 16:11, Federico Serafini wrote: >> Give a name to unnamed parameters to address violations of >> MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with >> named parameters"). >> Keep consistency between object and function declarations thus >> addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an >> object or function shall use the same names and type qualifiers"). >> Replace the occurrences of bool_t with bool. > > Hmm, I read the title as a promise that bool_t would be gone from the > code base (which I couldn't really believe). Perhaps "... by replacing > bool_t uses"? Sounds good to me. -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:03:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:03:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577874.904960 (Exim 4.92) (envelope-from ) id 1qSw9R-00012J-3y; Mon, 07 Aug 2023 09:03:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577874.904960; Mon, 07 Aug 2023 09:03:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw9R-00012C-1Q; Mon, 07 Aug 2023 09:03:45 +0000 Received: by outflank-mailman (input) for mailman id 577874; Mon, 07 Aug 2023 09:03:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSw9Q-0000UO-5x for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:03:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f3b9ee5-3501-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:03:43 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 7250D4EE0737; Mon, 7 Aug 2023 11:03:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f3b9ee5-3501-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 11:03:43 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 2/6] libelf: address MISRA C:2012 Rule 5.3 In-Reply-To: References: <55624244c42297da7da954009ba0559c47fc245e.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <9deeb76dcce04de11d8085f5835bad7b@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:11, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h' >> shadow the variables in the modified function, hence violating Rule >> 5.3. >> Therefore, the rename takes care of the shadowing. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/common/libelf/libelf-tools.c | 24 ++++++++++++------------ >> 1 file changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/xen/common/libelf/libelf-tools.c >> b/xen/common/libelf/libelf-tools.c >> index a9edb6a8dc..f0d5da1abf 100644 >> --- a/xen/common/libelf/libelf-tools.c >> +++ b/xen/common/libelf/libelf-tools.c >> @@ -91,10 +91,10 @@ uint64_t elf_access_unsigned(struct elf_binary * >> elf, elf_ptrval base, >> { >> elf_ptrval ptrval = base + moreoffset; >> bool need_swap = elf_swap(elf); >> - const uint8_t *u8; >> - const uint16_t *u16; >> - const uint32_t *u32; >> - const uint64_t *u64; >> + const uint8_t *uint8; >> + const uint16_t *uint16; >> + const uint32_t *uint32; >> + const uint64_t *uint64; > > While the chosen names won't collide with stdint.h's, I still consider > them odd. These all being pointers, why not simply pu as names? > > Jan lgtm. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:10:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:10:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577883.904971 (Exim 4.92) (envelope-from ) id 1qSwFr-0002bU-RW; Mon, 07 Aug 2023 09:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577883.904971; Mon, 07 Aug 2023 09:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwFr-0002bN-Oa; Mon, 07 Aug 2023 09:10:23 +0000 Received: by outflank-mailman (input) for mailman id 577883; Mon, 07 Aug 2023 09:10:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwFq-0002bH-DY for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:10:22 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060b.outbound.protection.outlook.com [2a01:111:f400:fe1f::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ba2d21a-3502-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 11:10:20 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8991.eurprd04.prod.outlook.com (2603:10a6:102:20e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 09:10:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 09:10:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ba2d21a-3502-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqydhE+CMnm8Fd6FOG68yjeLpfRiVBiENtXpCZkYYU79PM5tfZDaola3gGrHL8SNf6jtWAmbHk0ijoqK50Rq4y5NwhHYMfxP8zPikwKafkk21BpCW/8B4nmZa6azvoCQxyhzkUAuLXlF1qqALq6OHQD06Ym5pdIDOsItGhBlDzHtvmLD3qs1FNexeXWtTIEL85uAu1dEcg+qDM/ga8wGdQGfMQFFBB9NJZKvRyI+2Z9LDwlD1HE6xr1pMOO+nEGgDvXN69a4ql/J9rSkivngds8neg5ROyu76xkEZopv/3c3zFhWoctB1wwIGqaVRp7xRT3JnTC0Srx/hwUIAqM4Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0iULD9PC1B4z/uqDN24cZIQpu5EoEqPNqEs47fA33AE=; b=E6aVrCSae04D5C7iyTypXzH/328765PhfliwKiZAxl+hjqy7IEUBuPqIrJoqs6auu8+0JymCmkAP8QAuCVINvpWiJrvsgdgvu1Ht8gKDU0m/J7HOtD32d5yiYImo+4sNdFPKQJ4tKppfJ2+6Xdke6SVdJew+8cRDUTO/ggop+Hod7ArQ8RiqoIYbk0wHUnkAFPm/mcA52CNGauPqISqtHl3HmgiiJCfjHXDYQAsgS9Fz0BHDStmvIGhCODbl1l1PZOxlqnHpCmFoZje/njZxbGx0K/rxXlafqimDF1BnqRKdoSKrxLaEN72wxqQW4kY6gZ9UbSojnn+/4F2JDo1MRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0iULD9PC1B4z/uqDN24cZIQpu5EoEqPNqEs47fA33AE=; b=BDeua6S+58JcfPxhCAlFfVMaTsRKNNNxThLsmVMH4jnMBpo1z8bCyc+dun7EWs2NjB8yg83tRMUnIf2+aQ9Xo2G0mDFMqeeYMfN9G9McJFng3Sb/ODt1c+x1er619zmrEOjEGat78d+ZozdUFOClv7qAqlDyYdKKQnH9/MhAgITppaVvc9dRZfnh+Q6Y2MsYk6JREum7sMJadnpaYkrefOcIpbROdACkt1izO/+G/e0a4rkn3LKeLLf6iQoHVsNPHmedeXy/BbEnDoo8WHM4K00172lHFFYFL9M9rITD4UMhVfjryhHHgdbtrRwRD3pS4ipDUc3PgFWVctYchxZNxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> Date: Mon, 7 Aug 2023 11:10:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> From: Jan Beulich In-Reply-To: <838a53b9ef4a8d258feceabb4c811534@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8991:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a9fe7bf-3e9f-44ec-0945-08db97261e78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xpkXOJTNigV41y/DdOWh4SOKkoexKuib+YWHihp/B3eVS5fKBxtzQL4Pupy/w3Y64QZUp9WgB1zhJaISe92CpyZcnfM259IH4lA5zOoQ+JpiIT4NXQCH1V3IIxtQ8wpjYw7E/6y0YKIDuCfCR3xr0In7vpKoU2Npn81TzWqXMfN2DBvp3mZTzcEaCa1bbWRmA92Yuj3plUMPA9A+ioDBf7NEX+JGJc/OmBgv+JRazH/C/ctKBohGNeSxzIkdMpMbcyEQ7CzQ9ysVzW/cy9uohBIEkwQ3FD6HDK/97Eqpla4OruJSBsiTcK1WxO7AC84cTuMNoT7D6mo74a5FTBcfE610gfyAJGWO5vHD+UBXk1WTo4UeFQqDHZ2pXpgi5ulYqyMTpbC6wcZTyWfj36lr9kayFaFSN0trqZgGdNqUOiYqSGFPv7Eft8Kl1WdUuhsWC6d47XFU73XtgJVXKh9ykQe6dR0BAaTKOBFkXojdDD00LV+SE7LATax2tI9577lWEbvX1kv39qqwCs4l0nc2LZjFWzPiGGA9hsVWXOIces6DDbQZ69JKOTAzFZr23j1Ci2frDisTPegPMSq9zaoEbn50G3oAUAz2sb1pZ+8gT4lXXQ4hsHAkZCbxV4DKwlINsDJ/DxU1PgdK7fGWHm6OgA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199021)(1800799003)(186006)(2906002)(36756003)(5660300002)(2616005)(54906003)(38100700002)(6486002)(66476007)(66556008)(6916009)(66946007)(6512007)(4326008)(316002)(31686004)(41300700001)(31696002)(86362001)(8676002)(8936002)(26005)(7416002)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUs3UDFrNGpVRXkrVGRiMFBnR1U2SVBIQ29sT2hTVjdoRzd1ZldFOVpXU0xs?= =?utf-8?B?U0I5NGJUeVY5a0lPQUczRzJ3L0dnK1MySGl0RUxMb0VGRGxnKyt2R2hweFRh?= =?utf-8?B?SHVxc2ovOWppdVVwWmtCeEJaclRDd0hMbi9zbHJqWG10K24vMEZLVzRBVUdn?= =?utf-8?B?OWJ6QXY5Q3c4MEVXazhYOE1IZzRZbDJLc2FxalBLUy9neG93dVRtck96VGFM?= =?utf-8?B?NGY0dnBaOWU3WUNuMTJPMGhDbHBlakRKSlAxWjJKU3VhRkpmTHVaU0RMc1Nl?= =?utf-8?B?WVFKNW5BUVJXSTBTR25kRWVCQnhnM3dSb0NzWnhOS0M3ZkNwQVZzMTRjRWNQ?= =?utf-8?B?endPanJwaWV5aUZnS0VHdDI1WGd4OXF4VmpOS09DTE5saHo1M3dCNWVoL2dM?= =?utf-8?B?R1hFN3ZhdkZRUis1UHdVaEJvMzZleUR4M2I5L0ovWHVaS0xJRVRHOVZsZkVN?= =?utf-8?B?ZXJpU2pWSmhJdkZEU2dENGZyL042ZVlSTXY2VHlaL3pYSk9lNzlrVFZrcy9q?= =?utf-8?B?WjRCNjBCcmNxRGNTd1dxZmpzS0dWN1ZINkZlRzdXRkFub3NOYjQwZVBBczNk?= =?utf-8?B?RURiVEZGMHJMbnp5aitGT2x5TGI2cjRjenh1MnpqMjI0YzAwNHJqZ2d5cG5L?= =?utf-8?B?enNIUG5hSlZUUHk2ckVmSmszcVpiWVp2MnZMay9wZW04Z3F2WDVjb1lCSTNG?= =?utf-8?B?b0VVYlJkSXNXZ2RYWlYvQ3k0K00yeEpiRXJLZkNHUnQ0UGprZHZnODBLV0lZ?= =?utf-8?B?ZjZKY3dqL09TcVUxRmsrOVUvaFJJNEVLa0lZdlhFa0xXd0FtMWgyZmlPWWc0?= =?utf-8?B?Ym1lT1dBZGdPK0VoeldUSThyVUNxNlU2Y25TR1oxSU9zcmcvM1hXU0w1TEli?= =?utf-8?B?NGpQTzZpZ3N5VGpibnVXdzBlVVcwT0p6TC9zMXRGWUNnYnZTL1Nrcm1WR2cx?= =?utf-8?B?eEl4R2Exb2R4dUxCNThtRUFseElYVUROYlkzclRPT0dxRysreUsrYXViNHMz?= =?utf-8?B?ckprZExCRnluRFFCd085Ky9sTmprMzJCdHFkWE52aGRuTjdOaHE0SklEZWhh?= =?utf-8?B?K2Y3RXkvRFh1SlZVcythWTFaSGp2bFIraGhYelM3NERLcmtpdjhjN0NFbExP?= =?utf-8?B?eFhNaThSQXZpVHdlN0ZoQ3R1a0NFM1RlMitPUW1lRGZ1TUhnbWdmaUhmSkFx?= =?utf-8?B?ek1RWDU0WlQwK1JuUnNpOFBGOE9BNzlxRDN4VGl0SzNNZjlBdDhPWTdKY0pH?= =?utf-8?B?TTUxRHAwMDdFOXdqejlGMXhqcCtWUExnSWd3cVgrTk5kOTUzYzgxS0FiaFNI?= =?utf-8?B?K3cyN1ZxWk1CNzQyUms0Szl2M2tOVTJqQzNMQWRpM2RWY1J1WXMrQU53NHdN?= =?utf-8?B?dDZSTjJ6WnRaYUpoUWtGL3J3ZXlRbHU0MURYVnRzOG4vbnJlNzRaU2NOekZJ?= =?utf-8?B?SVVRa2F2VEUyaWJZU09PRjh3a3VUSWNWbXhvV1ZXNXRRNXgxTFMycnJLYXpO?= =?utf-8?B?MjBqcnF3bnJlaWM4WEJwTVQrZHN3dE1yKzBZTEhCV1BxZi9OeVFpcVg0QzJt?= =?utf-8?B?MjlGK0pPQVYra1luSG5XNkdhalo1cHZQTlpUR21uOFg4N0lEbnVwZFFFUlAr?= =?utf-8?B?ZmtyUlI4SExweUJsS3p1dnNpazA5R1dZQnZEejNWbG5EclZoVEJkeDFNRmFw?= =?utf-8?B?a1lLdnVCaTdrVjNsS2k0eHFZQ2tjYVBqU3BxVHoySUYzZUxTR0tESXphcTZ4?= =?utf-8?B?VWVuSnltWTJ5TkxaZjVsYUIvaHNxM3lZbVVFd1paTjNDSXlKZHkrOGV3ZmRG?= =?utf-8?B?TWR3cFRHZmZ4dU1aRW5KMlhRdUtpaG51Snc3Z0N3dVJQQVllaFc0eWRzQjFv?= =?utf-8?B?ZE9NMlp5RG4vTmpQaWYzTG83UXJjYWRacHlEMktqUERXVTR5ZURUVVlkYzNy?= =?utf-8?B?VzN4WFRndVBpNVh4aUZUNmdIRzdueTJzQmRNa0pmbkk4VGErZU04ZjNEcTVO?= =?utf-8?B?bzUyc2hPank0Z3M1Tzg4M0JDRFFJQ2N4NkN6NFF6MVBCakxoWGZ3bm8vbVdw?= =?utf-8?B?VzhhZmFDWExGS3hFNkx6aXlIQ1Zid3dSaG9JRlFEeXlzN2VQTitmZ01xdTZm?= =?utf-8?Q?MmnNTVsdGBhRndaCWeSNPLqjf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a9fe7bf-3e9f-44ec-0945-08db97261e78 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:10:17.9879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cm6nXsMbApXrUyql+IeFwdlme86aYh2zp3UiNiu2eVym433VWRVn7JaCYUQnES35pMV5baesM6Z3Udqul8/D+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8991 On 07.08.2023 10:59, Nicola Vetrini wrote: > On 07/08/2023 10:09, Jan Beulich wrote: >> On 04.08.2023 17:27, Nicola Vetrini wrote: >>> The variable declared in the header file >>> 'xen/arch/x86/include/asm/e820.h' >>> is shadowed by many function parameters, so it is renamed to avoid >>> these >>> violations. >>> >>> No functional changes. >>> >>> Signed-off-by: Nicola Vetrini >>> --- >>> This patch is similar to other renames done on previous patches, and >>> the >>> preferred strategy there was to rename the global variable. This one >>> has more occurrences that are spread in various files, but >>> the general pattern is the same. >> >> Still I think it would be better done the other way around, and perhaps >> in >> more than a single patch. It looks like "many == 3", i.e. >> - e820_add_range(), which is only ever called with "e820" as its >> argument, >> and hence the parameter could be dropped, >> - e820_change_range_type(), which is in the same situation, and >> - reserve_e820_ram(), which wants its parameter renamed. >> Alternatively, if we really were to change the name of the global, we'd >> want to take a more complete approach: Right now we have e820_raw[], >> boot_e820[], and e820[]. We'd want them to follow a uniform naming >> scheme >> then (e820_ first or _e820 last), with the other part of the name >> suitably >> describing the purpose (which "map" doesn't do). > > Besides the one you listed, there are these other occurrences: > - xen/arch/x86/mm.c:4678 in 'arch_memory_op' as local variable 'struct > e820entry' This probably wants renaming; my suggestion would be just "e" here. > - xen/arch/x86/include/asm/guest/hypervisor.h:55 in > 'hypervisor_e820_fixup' > - xen/arch/x86/include/asm/pv/shim.h:88 in 'pv_shim_fixup' These can likely again have their parameters dropped, for it only ever being the "e820" global which is passed. (Really I think in such cases the names being the same should be permitted.) > - xen/arch/x86/setup.c:689 in 'kexec_reserve_area' This surely can quite sensibly have boot_e820 use moved into the function itself. > We can take the first approach you suggested (which was my original > attempt, but then upon feedback on other > patches I reworked this patch before submitting). My doubt about it was > that it would introduce a naming > inconsistency with other e820-related objects/types. Anyway, if e820_map > is not a good name, could e820_arr be it? But how does "arr" describe the purpose? I would have suggested a name, but none I can think of (e820_real, e820_final) I'd be really happy with. Just e820 is pretty likely the best name we can have here. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:16:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:16:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577889.904981 (Exim 4.92) (envelope-from ) id 1qSwL5-0003HL-Jy; Mon, 07 Aug 2023 09:15:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577889.904981; Mon, 07 Aug 2023 09:15:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwL5-0003HE-H1; Mon, 07 Aug 2023 09:15:47 +0000 Received: by outflank-mailman (input) for mailman id 577889; Mon, 07 Aug 2023 09:15:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwL4-0003H8-8M for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:15:46 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20628.outbound.protection.outlook.com [2a01:111:f400:fe1a::628]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc423868-3502-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:15:43 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB7081.eurprd04.prod.outlook.com (2603:10a6:10:fe::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 09:15:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 09:15:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc423868-3502-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nk0nFrDQCRDnC24AI2gRFoECFwGzx6UZ4QBARx6HmBZGWQpKWXEGSzlvvaiEJWSx2hOJSxQ6N8GqiTqMe/626w8ys5+qrpZJ6XHgsy44mxOyXSu28rKNJtmxD4+JtprvIvJa49MLTVp0HXRnQN/g2RIHXRFPBRSZUY5f4+yVZFfg8EDZrquDUuy3hplEqtKwGe5l/zTuTQ3v3K/V+Bd6yBU5jsfPmkRGV63u2zYju61TRqOpi04OMGMLidMmy9qVW1fgoEmxsAIrToiVrKmNvCpLhiRxnVce4oStRHFys7r1haBMl3AjST0r6yaG9nCRkT0X4aLo6ijqz42d/W7ffA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4h6z3WyN3wa+yY6xiHVHLFx4QglzfI4KodSAg0zofwQ=; b=lL9FQ7P8ILenxGOkgybY1zxonAiJ1EviKs469bOjKMxFwFH0OB9agtw6lKHxdMQaA8bOObtImww2wlA5NlavFCn/GO8+YzZcN2HCdVqszcGbFkfS8u8augeNqcMVVysqjOyhRKDezLZNkYS5Ry9DDjD9erjtDNn3AAMyyGvzX21+b+dlNg+z/H6vbNF+RLOFG/ssnIHwn6zOHxsCjg0w/mY50cKv5/e19YHLh4gUedjPcDvDb6Txgb4yAz7GJruakE/3PFVF6Yy7Uh19Mcmm5/hhS6HDp0YNbJ1IfBquSAwgA0471jQiNv+JXdjTzTZ/4BbE3a1ldMYAVjee/GFZDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4h6z3WyN3wa+yY6xiHVHLFx4QglzfI4KodSAg0zofwQ=; b=Dg9JRtK2xA7ktHrtCFSJkcI/bnwu7/vKqQXv0HGEY86GzdlyiSUub63pPCf2YamM29nkDN0E26WVvEqB/QBNJWOiDxNte0kamDysdLEVmbmgkIEu+JvxZxJxyNxLEWK27uVUnXp+OBkORVz5b0JatGaCmowCLIAhq7qBv+pltPxJfW4OKbn2BQPD+LDBLf6uP0Fh2Ybzn8BTZb9fwcO6jYDUq8tK7Na+sNNXk4eR9UbymlRRY/ItFrwWSpgItFFS5XpMhHFsa003BLNAteenkAB2PV7Ne5e/fMQV3P2TokdFlgPcbnF3Yu2DzhrNho/kh+LD8urtlCsteihKsuQ2cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9918b8ef-0629-d8fb-3c58-6b20b56b1a93@suse.com> Date: Mon, 7 Aug 2023 11:15:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-US To: Julien Grall , Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <486ba9e1-2bf0-4446-9ac4-33a256f8d51e@xen.org> From: Jan Beulich In-Reply-To: <486ba9e1-2bf0-4446-9ac4-33a256f8d51e@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0160.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB7081:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ddb34b2-61c5-42ff-578d-08db9726df0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XFRGcAizW3DEjtd8vhIyubjQtVH6Rlg8M5+LkfJXFw8weR54NwJMNMov2d+2bSFGvfd8/HYPiJpK8MsyONO4D1ik53qTk5++ZqOjmet3KEmTRJ+gL7+YJoPVHxME8J/HOnIo43sWSQ5TC90F5mLa33pDeG8NNvYMNG+dZbU8AopMe0pu4Jx2OMdfPBW0Kp+bgC5w16Weu1P3qvErBIPOUXrkgG4ObEhrBb2qyXFQ0uhWCrVY4T7jwBzi2rJ281vw3/nOUC9i4IqXBOQqRgVwEnVVx2mdLRFVzxKpHygo7se03Jz69TQcMyfWc0ZA37vTQJtY/v2D0cwjskrUvPTWaF7/AfQ95vGuQHpOKwa1Q9RzGPjnizSds7/qnBSl2b24CTSLtJnvVLrDxJXne2l1A6UCy43C/0FUkNwa52U27az2y6x7rYk9vLIYDxAVzGo6tbtjExRiXZYp41qNGKp5A3hy8LQjPpkcHn0Hk+y3Bh2qf7tFVIa1lYsRveqJ8RoQYfQdTANn6gqAT0a9O8/FMb9EECOJxM91DfV0PVbbqHmcmxywwJ5bevWkG2oH2Vau3S3zXZ7YuOVJRaed4LVY2dPsho/HVYofNrgwb7EMAz4hXYS0bKZsYvEwi77boNkOOv6rpuCxL1LCi7XLZauLyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(86362001)(478600001)(54906003)(110136005)(38100700002)(66946007)(6486002)(66476007)(66556008)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(4744005)(2906002)(7416002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnBDMi9yQUVhMHJHaUVCSlg0UmZPeU1uZUpGdFlIWlFtb0R2Uy9GQlBkZ3hl?= =?utf-8?B?YTMybFY4UXMxaWFkOHg5R2xvMmxLRU9sOWw1c2hoR0Y4V0xEdFVkdlBEOElL?= =?utf-8?B?VkMrK0VxK0JqNmNnVUxub2VuU0hyanZLRDFRQkRsTUdrMHV4SnF5QnMrbU1D?= =?utf-8?B?TURDUXdKc3hmSUJhMzBpczJ6YWkxeEZzSW4zS1VOeXgxRHRaV21Iem1WdFo1?= =?utf-8?B?d0V5VmtsNGxKTjdSaU1CQm16cUU3a0k3Q1NFUnVyVGVVQlBzV2E1TjJVemJt?= =?utf-8?B?UFBEQlhBMStaRnREaHR0cHdud2dHckhtbHdRMG1xU2VxNytrbWJwMUtIbVpv?= =?utf-8?B?YVNYT3phNWpYc2MrZExjcHFhdm55aHhZNDlGd1BwQkM0dnpxekZ3S0s5bUQx?= =?utf-8?B?N25JdUtUYjU2TEdHM0xNR25DNXdYVjJ5NUhoQWs4YXVpNDdJSUZQWVArRHQw?= =?utf-8?B?L01XVlhncnNaZ1B6UjdlcmRVUEp4UEdRT0V3R1VTR09EMEN0TDVFK045RWtE?= =?utf-8?B?ZndlOGhQTkxYMEw2L2loTEk1UmpoQnpiSk5TbW80elRZWmg2QzZRRkxIbWtP?= =?utf-8?B?RnZBR0dZb0h3SG9GemJSdlJzWTRVL0JteDFPendEbEkxWkx2MTJJdFRET3hY?= =?utf-8?B?dENiVitEMkhyOUNWRWg2ajJIVmtpVmxkRkZ0MDlNN3dEK3kxdjhudTNjWG1t?= =?utf-8?B?WDBxZTRuU0VoTUJvcE9zZjBacXpOenFZTTFmK1dyUmg4ZGhRV0xWcHphUUFV?= =?utf-8?B?UjhQOFp6eml0Qk9zWG5leCtDYklTTzk1TnBOUWRXZ1YwbTZMeUJTQ2QzV3hy?= =?utf-8?B?Mjl6Yk5LcnAzSzl6K3FMZWsrbFJoZHVUUXgvMi9PNGxVYlFTZUJKSGppWkpu?= =?utf-8?B?S3FVRUlaaHJ2YjAxb3MzeTllQjcySGpuV1lqQS9BSUhSZjFHUVk3Z2tuSjNX?= =?utf-8?B?bUplY0xhY3NKTWFRUTEwRllJSmR2L3pnQ1BhaGJmd3NyZXc5ZlprZGtqb0lq?= =?utf-8?B?ek9jWWJ6cEZHOXA1M280QU5YS21aUUZyYmR2NTdhWDFmOXRSU3M2MnpwM2Ji?= =?utf-8?B?cWZNOUJoc0xIc0U4cDc3N0JKNERhMWdwS1YxdUdWNUNVdVNvbkc2TVhCZnBM?= =?utf-8?B?VmtWc3lTMGhjNjdObGU0dlRKdXZrR0djS3J5UTVlbVVqUFZlSFFwY04xcVUv?= =?utf-8?B?dC9SUUlNeEdYTXM1bEhtVk5vUzlxREx2SmN4S25iTUZRUTVvV01EN2dWdjd0?= =?utf-8?B?U2FvL3ArRFhPYi95cDZubTBmS3UrbW1abHkzczUrM3RIbThaQmZ3YjVXbmsr?= =?utf-8?B?SDJFcEFjdkphT2djMWJZejJDck1JbngrcjA5T1dsUXQ2QnJxNDZtUWpqb2Rw?= =?utf-8?B?ei9SQ1RkQldZY0VMdk9YWHdYL3hWNXV4Uk9Ed1hTTXpqbVRkb2xtTXFjNnRa?= =?utf-8?B?ZmpqV2JXQXhzN2t3b2tqNy9hNnJHaG9wWDBXUjZwZjNFWG43U2xzTkx0dGhi?= =?utf-8?B?Y2duMlpGdkdUaDdxWHJNTURoNDBaZGF1MFhpMUxNYmRFcW0vT0ltVjZPdlRF?= =?utf-8?B?cVdSQmZTRTIzU2Q2NFpFZTNXNWRuYjZOdkZ6Slpvd1g5dDJCdXQvdEI2SDZJ?= =?utf-8?B?Ym1yOUNDT1VQZnNqQkRrQm03TVVZWngwOHJqT3lHa3VzQjRkV2tiOUNGWlI5?= =?utf-8?B?RC9yNWJYRnVPM2REdFFSZzUwdEZlaXVnM2o3U2pHTHVqWXhjTlRkWG9iZVcw?= =?utf-8?B?eEtOS0puRkJQcjVjamQxcTZqY3dhRm9DYWsrcEhrc1lGbEhlR0xrMDFYOERh?= =?utf-8?B?WE01WG84Ti94anYrTVNWV3hJY1U3eXRyRFZHZVVpVVpEM01VRjhCZ1Y3NVhQ?= =?utf-8?B?bWtEbHdlYXd0b0V2UElQeW14WmdzazRXTVVCR0tCeFFadEM1dXJCTFVTYzIz?= =?utf-8?B?TDk2c1BKSS8xcktKSE5uVHRjYmVjZ0JIZDY0TmlEdHVmbDdGSWNBVGsrRVpu?= =?utf-8?B?S3ZDbEloOVd3K0R1Q05FVmRZbGR3Ty9nNHhhWEVSeG9SMk1tb1hpQmVxcTdC?= =?utf-8?B?dHQxMlAwUEFyc1pwVWZwL2ZDbFZoYXY3ZjJMR29BcWdjWWQwNVJzWXYxY1Ez?= =?utf-8?Q?SLPiQktNWZpsJfevmZJqayEIP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ddb34b2-61c5-42ff-578d-08db9726df0a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:15:41.0669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6cj0hJzXgIDaV/HzeYzgmEitdDBmGTgT03TaNB7dgTqhc1VUD68uDoUS9FMZV6YeQA+ljgSm/Zg+rB0/OFmutQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7081 On 07.08.2023 11:01, Julien Grall wrote: > On 07/08/2023 09:14, Jan Beulich wrote: >> On 04.08.2023 17:27, Nicola Vetrini wrote: >>> --- a/xen/include/xen/delay.h >>> +++ b/xen/include/xen/delay.h >>> @@ -5,6 +5,6 @@ >>> >>> #include >>> #define mdelay(n) (\ >>> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >>> + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) >> >> As elsewhere, please also adjust style while touching the line, at >> least as far as the obviously wrong case goes: >> >> #define mdelay(n) (\ >> {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) >> >> Even better would be >> >> #define mdelay(n) ({ \ >> unsigned long msec_ = (n); while (msec_--) udelay(1000); \ >> }) > > If you are touching the style, about converting to a staging inline and > also splitting the line in multiple one? I'd be happy about this being done, but I wouldn't want to go as far with on-commit adjustments. Nicola, are you up to doing so in v2? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:19:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:19:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577894.904990 (Exim 4.92) (envelope-from ) id 1qSwOt-0003uh-3l; Mon, 07 Aug 2023 09:19:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577894.904990; Mon, 07 Aug 2023 09:19:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwOt-0003ua-1C; Mon, 07 Aug 2023 09:19:43 +0000 Received: by outflank-mailman (input) for mailman id 577894; Mon, 07 Aug 2023 09:19:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwOr-0003uU-S4 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:19:42 +0000 Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 893ae4f1-3503-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:19:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 893ae4f1-3503-11ee-b27d-6b7b168915f2 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1691399978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=s/zPaS9Z5FLXbNNBcGX5RsYNKU80L6L1pU+cuGQC75s=; b=0Co9hz0/oJEiK/ZGH5xWX1TtqD/N4t54kEoeMNL+adKYgg8HzSahcuynNMEB2GwGqCCIiP aHf5jJYvzrHVTSBsE9KwqEwkF2MjdW3+KFZmr1Bi/+5rHDTXrmwGx8fHMbKVd1SjCXhBuw AiGLI8x09fIUb4pjuAM5n/4xCeKhTCSu8c8i8nseqtoPJdKInNDo7W5mjWCN5gUKAkDT8v TryXxDsHI0bUhRJGaKjjFz7g7xbR6wfEM1dlsAMqwgJvg4RiMo+YXWy2aQ89YXEElKWI2n jsNFhepV8IJ62fhI94dQsEPJ1+USAMEfIoM5lsMLLFlmQFzZaemNfvUuhzVlJg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1691399978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=s/zPaS9Z5FLXbNNBcGX5RsYNKU80L6L1pU+cuGQC75s=; b=zulpOQEHSPTDDri5elyM+eEkPFHigOFF3+RZX6aKSCfaaxAiIlefgpsGOQ5y+g/lJmBdWV v+FcBS/Eqri69EBQ== To: Juergen Gross Cc: LKML , Andrew Cooper , Jan Beulich , xen-devel@lists.xenproject.org, "Paul E. McKenney" , x86@kernel.org Subject: [BUG] XEN/PV dom0 time management Date: Mon, 07 Aug 2023 11:19:38 +0200 Message-ID: <87a5v3us45.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Hi! Something in XEN/PV time management seems to be seriously broken: timekeeping watchdog on CPU9: Marking clocksource 'tsc' as unstable because the skew is too large: [ 152.557154] clocksource: 'xen' wd_nsec: 511979417 wd_now: 24e4d7625e wd_last: 24c65332c5 mask: ffffffffffffffff [ 152.566197] clocksource: 'tsc' cs_nsec: 512468734 cs_now: 9a306c9b808c cs_last: 9a302c9e30ba mask: ffffffffffffffff [ 152.572319] clocksource: Clocksource 'tsc' skewed 489317 ns (0 ms) over watchdog 'xen' interval of 511979417 ns (511 ms) [ 152.578067] clocksource: 'tsc' is current clocksource. [ 152.581023] tsc: Marking TSC unstable due to clocksource watchdog [ 152.583751] clocksource: Checking clocksource tsc synchronization from CPU 5 to CPUs 0,3,8,10,12,15. [ 152.590860] clocksource: CPUs 8 ahead of CPU 5 for clocksource tsc. [ 152.597196] clocksource: CPU 5 check durations 14197ns - 124761ns for clocksource tsc. [ 152.602675] clocksource: Switched to clocksource xen This is fully reproducible with variations of the failure report in the following setup: - VM running on KVM on a SKLX machine - Debian bookworm install with XEN 4.17 - Happens with the off the shelf debian 6.1 kernel and with current upstream (6.5-rc4) Why am I convinced that this is a XENPV issue? Simply because the same kernels booted w/o XEN on the same VM and the same hardware do not have any issue with using TSC as clocksource. The TSC on that machine is stable and fully synchronized. The clocksource watchdog uses kvm-clock to monitor TSC and it never had any complaints. But with XEN underneath its a matter of minutes after boot to happen. I tried to make sense out of it, but ran out of steam and patience, so I decided to report this to the XEN wizards. Thanks, tglx From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:20:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:20:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577897.905000 (Exim 4.92) (envelope-from ) id 1qSwPY-0005GE-Bs; Mon, 07 Aug 2023 09:20:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577897.905000; Mon, 07 Aug 2023 09:20:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwPY-0005G7-95; Mon, 07 Aug 2023 09:20:24 +0000 Received: by outflank-mailman (input) for mailman id 577897; Mon, 07 Aug 2023 09:20:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwPX-0005Fz-4i for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:20:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a24c3c73-3503-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:20:22 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id AA3C34EE0737; Mon, 7 Aug 2023 11:20:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a24c3c73-3503-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 11:20:21 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 5/6] x86/xstate: address MISRA C:2012 Rule 5.3 In-Reply-To: <82438990-cb32-a2fc-273f-151818834c4d@suse.com> References: <1ea70e5f8293fdca2bb69ec75f532722136e52a5.1691162261.git.nicola.vetrini@bugseng.com> <82438990-cb32-a2fc-273f-151818834c4d@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <4ce6f80a5749dff1aee4ba7458f1139d@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:23, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> Rename the local variables to avoid clashing with function 'xstate' >> defined below, but declared in the corresponding header file. > > Hmm, there are two functions with such a local variable, but you don't > change those. You change "xsave" instead. The new name you use you took > from older functions afaict; newer ones use "xstate" (and use of this > name is extended in pending patches), so preferably we would follow > that naming model (and eventually rename all "xsave_area" as well). > > Also - does "below" really matter and hence warrant the "but"? > > Jan I made a typo in the commit message. Indeed 'xsave' here is the culprit. I think 'xstate' is ok for a rename, as it does not shadow anything afaict. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:23:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:23:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577905.905010 (Exim 4.92) (envelope-from ) id 1qSwSg-0005uN-RF; Mon, 07 Aug 2023 09:23:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577905.905010; Mon, 07 Aug 2023 09:23:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwSg-0005uG-ON; Mon, 07 Aug 2023 09:23:38 +0000 Received: by outflank-mailman (input) for mailman id 577905; Mon, 07 Aug 2023 09:23:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwSf-0005tu-TC for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:23:37 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 15c44cfd-3504-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 11:23:35 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 18FE24EE0737; Mon, 7 Aug 2023 11:23:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15c44cfd-3504-11ee-8613-37d641c3527e From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder Subject: [XEN PATCH] x86/mce: Address violations of MISRA C:2012 Rules 8.2 and 8.3 Date: Mon, 7 Aug 2023 11:23:28 +0200 Message-Id: <1506ba7675065ee0cc3c84b05c2f8f963cbf64e6.1691399401.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter types used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/mcheck/mce.h | 28 ++++++++++++++++------------ 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index c2173cfc78..57e1eb221e 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -44,7 +44,7 @@ DEFINE_PER_CPU_READ_MOSTLY(struct mca_banks *, no_cmci_banks); DEFINE_PER_CPU_READ_MOSTLY(struct mca_banks *, mce_clear_banks); static void intpose_init(void); -static void mcinfo_clear(struct mc_info *); +static void mcinfo_clear(struct mc_info *mi); struct mca_banks *mca_allbanks; #define SEG_PL(segsel) ((segsel) & 0x3) diff --git a/xen/arch/x86/cpu/mcheck/mce.h b/xen/arch/x86/cpu/mcheck/mce.h index d40cee531a..b6fc9c3617 100644 --- a/xen/arch/x86/cpu/mcheck/mce.h +++ b/xen/arch/x86/cpu/mcheck/mce.h @@ -58,12 +58,14 @@ bool mce_available(const struct cpuinfo_x86 *c); unsigned int mce_firstbank(struct cpuinfo_x86 *c); /* Helper functions used for collecting error telemetry */ void noreturn mc_panic(const char *s); -void x86_mc_get_cpu_info(unsigned, uint32_t *, uint16_t *, uint16_t *, - uint32_t *, uint32_t *, uint32_t *, uint32_t *); +void x86_mc_get_cpu_info(unsigned cpu, uint32_t *chipid, uint16_t *coreid, + uint16_t *threadid, uint32_t *apicid, + unsigned *ncores, unsigned *ncores_active, + unsigned *nthreads); /* Register a handler for machine check exceptions. */ typedef void (*x86_mce_vector_t)(const struct cpu_user_regs *regs); -extern void x86_mce_vector_register(x86_mce_vector_t); +extern void x86_mce_vector_register(x86_mce_vector_t hdlr); /* * Common generic MCE handler that implementations may nominate @@ -73,12 +75,12 @@ void cf_check mcheck_cmn_handler(const struct cpu_user_regs *regs); /* Register a handler for judging whether mce is recoverable. */ typedef bool (*mce_recoverable_t)(uint64_t status); -extern void mce_recoverable_register(mce_recoverable_t); +extern void mce_recoverable_register(mce_recoverable_t cbfunc); /* Read an MSR, checking for an interposed value first */ -extern struct intpose_ent *intpose_lookup(unsigned int, uint64_t, - uint64_t *); -extern bool intpose_inval(unsigned int, uint64_t); +extern struct intpose_ent *intpose_lookup(unsigned int cpu_nr, uint64_t msr, + uint64_t *valp); +extern bool intpose_inval(unsigned int cpu_nr, uint64_t msr); static inline uint64_t mca_rdmsr(unsigned int msr) { @@ -128,10 +130,12 @@ DECLARE_PER_CPU(struct mca_banks *, mce_clear_banks); extern bool cmci_support; extern bool is_mc_panic; extern bool mce_broadcast; -extern void mcheck_mca_clearbanks(struct mca_banks *); +extern void mcheck_mca_clearbanks(struct mca_banks *bankmask); -extern mctelem_cookie_t mcheck_mca_logout(enum mca_source, struct mca_banks *, - struct mca_summary *, struct mca_banks *); +extern mctelem_cookie_t mcheck_mca_logout(enum mca_source who, + struct mca_banks *bankmask, + struct mca_summary *sp, + struct mca_banks *clear_bank); /* * Register callbacks to be made during bank telemetry logout. @@ -142,7 +146,7 @@ extern mctelem_cookie_t mcheck_mca_logout(enum mca_source, struct mca_banks *, /* Register a handler for judging whether the bank need to be cleared */ typedef bool (*mce_need_clearbank_t)(enum mca_source who, u64 status); -extern void mce_need_clearbank_register(mce_need_clearbank_t); +extern void mce_need_clearbank_register(mce_need_clearbank_t cbfunc); /* * Register a callback to collect additional information (typically non- @@ -155,7 +159,7 @@ extern void mce_need_clearbank_register(mce_need_clearbank_t); */ typedef struct mcinfo_extended *(*x86_mce_callback_t) (struct mc_info *, uint16_t, uint64_t); -extern void x86_mce_callback_register(x86_mce_callback_t); +extern void x86_mce_callback_register(x86_mce_callback_t cbfunc); void *x86_mcinfo_reserve(struct mc_info *mi, unsigned int size, unsigned int type); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:23:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:23:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577908.905021 (Exim 4.92) (envelope-from ) id 1qSwT1-0006LS-3n; Mon, 07 Aug 2023 09:23:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577908.905021; Mon, 07 Aug 2023 09:23:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwT1-0006LJ-0X; Mon, 07 Aug 2023 09:23:59 +0000 Received: by outflank-mailman (input) for mailman id 577908; Mon, 07 Aug 2023 09:23:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwSz-0005tu-WE for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:23:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2220a417-3504-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 11:23:56 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 467444EE0737; Mon, 7 Aug 2023 11:23:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2220a417-3504-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 11:23:56 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Julien Grall , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. In-Reply-To: <9918b8ef-0629-d8fb-3c58-6b20b56b1a93@suse.com> References: <486ba9e1-2bf0-4446-9ac4-33a256f8d51e@xen.org> <9918b8ef-0629-d8fb-3c58-6b20b56b1a93@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <43b45003191044cbae170404f6f4ba46@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 11:15, Jan Beulich wrote: > On 07.08.2023 11:01, Julien Grall wrote: >> On 07/08/2023 09:14, Jan Beulich wrote: >>> On 04.08.2023 17:27, Nicola Vetrini wrote: >>>> --- a/xen/include/xen/delay.h >>>> +++ b/xen/include/xen/delay.h >>>> @@ -5,6 +5,6 @@ >>>> >>>> #include >>>> #define mdelay(n) (\ >>>> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >>>> + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) >>> >>> As elsewhere, please also adjust style while touching the line, at >>> least as far as the obviously wrong case goes: >>> >>> #define mdelay(n) (\ >>> {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) >>> >>> Even better would be >>> >>> #define mdelay(n) ({ \ >>> unsigned long msec_ = (n); while (msec_--) udelay(1000); \ >>> }) >> >> If you are touching the style, about converting to a staging inline >> and >> also splitting the line in multiple one? > > I'd be happy about this being done, but I wouldn't want to go as far > with > on-commit adjustments. Nicola, are you up to doing so in v2? > > Jan I'm afraid I don't understand what "staging inline" refers to. Other than that, sure thing. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:32:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577920.905031 (Exim 4.92) (envelope-from ) id 1qSwbC-00081n-Tf; Mon, 07 Aug 2023 09:32:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577920.905031; Mon, 07 Aug 2023 09:32:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwbC-00081g-Pn; Mon, 07 Aug 2023 09:32:26 +0000 Received: by outflank-mailman (input) for mailman id 577920; Mon, 07 Aug 2023 09:32:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwbB-00081a-ID for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:32:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20625.outbound.protection.outlook.com [2a01:111:f400:7e1a::625]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5013e978-3505-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 11:32:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8999.eurprd04.prod.outlook.com (2603:10a6:10:2e2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 09:32:20 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 09:32:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5013e978-3505-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdonu+AllvND4dz/fTMCTmUtjLTwjSQcssJrHFCeYn4vW6R6RCham6sj7zXhIO3TkxV07cJyuhyg1njVmb+1rvyqHLvYN+DYBjE1fxk2t+HIHyKSWoEKbEZm92ZXUxLOUpnxzm8rkdYQLMKwwUL1H/TmoqlYRrTk4Zi2WmCl1s/3DLSNkcl3Wvda6rccpEJlSx52rUIhSMZdW0uSz6yEtWXhj1mUjISyI+kajL9fvSK6HMaqKrUeY2OmgGsUrrNGgU4pSFoCyg+iI3cV87doFUboOkOxm5CS/VYAJ2lAZyN35SB+Xwu0b/eCje/96nhueebZY1uMaccLfFtTpTwU7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HTXauQIP0NXVPNkQRgWkSezlcKBCrt1mjr7HHbye92E=; b=ZYk3gTTc7YAgASIQQTneJZUCuRBFsoSm8HzEWuRjI6YkCHfN9CqyVDsKdvDNbhPjnG5ICydPPRy/lR0C0oEdyi0GOn4787RBnRbWnggdYa7J/05HGC86ORDiA+zz1fpNv8I/Q2qxtPY25VZyxh9GijT8T0jwyablcm0kARa/eSMObbELdtrFOqtB02jX+bf3pcpYuUEhrxKgQzK3bPC2NiVGcszW338GwaHwcp2AsnAq8AwicEg69NqKmUNIQf8axZoaVght6IQDi847On3Oq5jcw6HatL437T1XZ9G/Zcik0cJIaB/vuYdf2ymiskrV0lj6aoBbjdAlXlbEMSOLrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTXauQIP0NXVPNkQRgWkSezlcKBCrt1mjr7HHbye92E=; b=uHyF0V8cNaooIdZbCuymSKjLYEtHa/cB7JE8X5pK34j5nVgZIHXThpXlk6XKGDSAyo1Z5TZO6NKjOsfouyRXsCrBXPaJqYC28r59LBdDH+122rmXX97GMDj6yisKJ4tx7lCUykfSiirLy9ynpRUawz0IMtfeF+xViflM/hVo5TMi+zfb/gav04q4eUNgpLjncgCWQC5zA9QKw1mLlHzHCCXbZ3bGxirjdg/UokoK60MoHRuvhjnVMKCShhMVqWGy6xtU8uQ1gYaJ9/b12BiT+5nuh3M/x2V3l02++/JZ8ONIHpdlwE482cpDL+9Xa7EdIwQNraHg26RNiP3TlW3cnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 11:32:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-US To: Nicola Vetrini Cc: Julien Grall , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <486ba9e1-2bf0-4446-9ac4-33a256f8d51e@xen.org> <9918b8ef-0629-d8fb-3c58-6b20b56b1a93@suse.com> <43b45003191044cbae170404f6f4ba46@bugseng.com> From: Jan Beulich In-Reply-To: <43b45003191044cbae170404f6f4ba46@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8999:EE_ X-MS-Office365-Filtering-Correlation-Id: 17f7377a-4b41-45f4-5777-08db972932d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GLpXHd+xx1dMJ31dPkdJuI9mp4VgRKFA0KknzB/HS5gxDShPpXvarDXbtbaxXgtTr09gxWbsle2Hb7V+H4YEjfM8sRfDqIBQvnQIWP36QJ93nz4Jp1FjFJDuXwnyGaBG5g8Ba40goc6rL9iM+yd0vJ3wQIKB6Iv+GwES+ZGyHT5vo3j1OtKy6acmRyLAZV1RVkJ+nNkLOtanvLR5gknXt3cglks5XtPOXuWaALp6S7BRcOtKPSDQpfMrSRm3ubiG4Uz5IZfvYJI5t5D5EYAu00j1EfOGxfHRLg2bebqDQu3LJ+OaJyAjr+UwDuzH0qIEG0I8SW5xFKYiU8BX8Xf+N/fY4DWVVAXx9LNhm8xg5cCOnUwk/rzNe9X9eE3Lc+TjY674v3dflqwdky/ShBgJX4diuNNnJR+PvECj884j39qkVppfgcCjv/XXmUUq1Hd6/bBcCx6/VQG+n42mYqBi9pxaUvHyiLVE32Suidfuu1R7PlMQLhkGqPvAe5s/+JtJawfGfB684AqcZmRvCMkJk7qKBJwY8BtjZGy5KyRhMUogKCBKKIHIHSWvU9gqEbgLK6VvFxSc5Br/4sbTUi02HCIVhSlyrUFs1BIaaovR5NUP5o8qgqpA0dW8pIB15fCC5LT2gxlm+Yis1AYBBe0Jhg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(39850400004)(136003)(346002)(186006)(1800799003)(451199021)(2616005)(478600001)(31686004)(6486002)(6512007)(53546011)(26005)(6506007)(41300700001)(66946007)(66556008)(66476007)(8936002)(8676002)(316002)(31696002)(4326008)(2906002)(6916009)(36756003)(54906003)(38100700002)(86362001)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmRKZDhWVlNNZHc4VzlwQ0tQQ1hMMTNWdGc3OFNjQ3VnSDU4SjZBa3lmWllu?= =?utf-8?B?Rmk5eTFJSlk0dmJ3L0cydHhLQXptbkJUWXB6MTFKeG1EbFFPZ0N3Y2EyTXFp?= =?utf-8?B?N3h6d2M1UDlRengzY2VsODQ1cHdiUEtpVElzQW9OZUNWS1FSR1ppaFp3ejZC?= =?utf-8?B?LzViS3ZhZkVHdUplTW1jbnIzWmdhVmRXcjBOMk5QMXVqTWpoS0Jya3dJSjFV?= =?utf-8?B?U0tPWTVhYzdzVUFnelpHbnNJWStZbmNrSXZJQXZQcGd5MGJrWGowS253YjJK?= =?utf-8?B?YmE5Q3JqaWRsUFRXNXpubU05U01jT3ZOTXpKajI1bUZGRUloY3BjRkxJbTVV?= =?utf-8?B?TVJoTFBBVTBGVXpDWW40MHEvSTVIbFpINUYyTWIyWVNtWndKTk1ia2hLcFFT?= =?utf-8?B?WHd1eUdXRWt1cS9wb1libE50dks4M0lnaktxS2dnMXNpbjdnbmh0VDRLWmVw?= =?utf-8?B?QnJkcWlkdjVUZkI3L3A3N3ZFcG5rNUVVcXVXampDdkdBSktma2JLUDBlVStR?= =?utf-8?B?cEpyNWhXNGNDeG1jLzB2YVFLeEE2VHllT2xvYXJrbHZnN0tyVENpTm5zT1Q5?= =?utf-8?B?c056WWdHems2RWg5Tm92MWxobmhEVXZhcHQwdkNQdmptUG5CUTRhZVo2ajZF?= =?utf-8?B?UnhySXJ0cytGdWxsTVJsMFdEWVc5NEdIalFNbVVDWUd1R3Q2Ymg0cDVoU1lV?= =?utf-8?B?QW5rcWpJU3JySUNtVWkveVBPSmlOdXpoWjc4TjltbWtpdE5aaEJvTVZORmNR?= =?utf-8?B?cVBIM3JrakhUaERSbXU0ZkRRb0NpaGRKcGNXZEJ6Vk9tTzc5N2xrc0s4TURs?= =?utf-8?B?Rk1JRkdVeEtkQlV5b0lXRkk0eEdybENFKzBjWkRKV0Z5YzNpUGpoZXVNdGhy?= =?utf-8?B?Mko4cktNd05INVNoN2lBb2c3NVYzUjdQbWVydUxQTkpTUzd3K3lBejhnQlVP?= =?utf-8?B?U0Z5RE1xSXlXNlRiMkpyK09kZXlwejBzUkxVRjNubXJlZVJmSlBiWXJmeHpH?= =?utf-8?B?ZytuNkI5TlVYMkdlRlltTDhFMy9XWDBoTVpGZ3BUaGRhQXo4MHNQenlCbmNC?= =?utf-8?B?TG1NSmR0TzQ5aXhWYzZWd0VEVnBscVVCdzc4anFUbzN1TlZULzVRL08yQTd5?= =?utf-8?B?b2IrTmZqUlI4MDN6UllhdEZEYkFPK3J2UDdDRy95dFdWbXU3dzd4dUkyRE1U?= =?utf-8?B?S09ycmdwRlpBLzE5YWdUZjkvT3VQUjhUZzh5V3NZc2hpKytOdmFHU3RRTnZx?= =?utf-8?B?b0xhaFJDM3lzL1dNcmNubkhrdTBPckllZ3BSWVJ6bjNlUzErTmdPaGg2ZHht?= =?utf-8?B?VndIVnFnSWZzcUozWStyS0pWdGpjNklFWC9TZ2FET3V4TnJzQWExdXdseWo5?= =?utf-8?B?OGZNWnk1bDlpNEUxYzRtVjhzSzJEUnJHRitBeTJidXQ3SjAwSEVEalkzcmtS?= =?utf-8?B?cEM4TXRNRXdaNVZIaUlWK3ZMbEJuM0JONTdiUmZsc2h2Nm51STRlNTRwL1VV?= =?utf-8?B?S0JkeUR5L1F6alUzVVJMaU1BTTc5UDB2Q1VoRTNiSW1yaEJNczdZNEk3VStu?= =?utf-8?B?eTROMTBlSzNxK2FBQVU1Nmp1ZEkrWG1PSEpmK2lVRXU1aEtLNE5lRS9mZjM1?= =?utf-8?B?dDd6TVd5bmpsamZEbnh1VlppbURkYzlLaDZXQ3h4aTg0R0RFSDFjRTZ2TmJn?= =?utf-8?B?bi9QRWJkdzFmMk5WR0tpYnVvRW4zbEpMM05mV2VvelpDNkpIalBBakVHZlYv?= =?utf-8?B?UHdvRDlRNHh1SG5GNzlVK3c1dHFuVFNwVEdhTmhhdVA3czFZeU5zREEzR0FY?= =?utf-8?B?R1ZBRzYzT2hRYnRtd1pvTVQ1L1NZMU5MeGU4OHFqZWRTRU4zTXNDVGxEZHRF?= =?utf-8?B?enFsUC9PZEkzVnZNNFA5RVlUejRUYUNBVEIybWQ3bjhubmJBK2E5UExCSXRT?= =?utf-8?B?RTlaOGZhbkpYNEVyQ2lXaGxUMVVjQ0JHQWtFOG9vWXZsalR4MHNZYk52VTRN?= =?utf-8?B?eUZZWVVQOWtkQ2JudkoyMnZvMzNMNmN3UU9IbGRBcC9iVzFCVlpBQmF1MjJm?= =?utf-8?B?SGhCR3JyTXROaElCdkNsZE10anhKUDNBYWdEdkN6ZlBFUS8vZzNtb1YvQTd5?= =?utf-8?Q?XPTyiyq+3EM92+iDxlSiraHjG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17f7377a-4b41-45f4-5777-08db972932d4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:32:20.6639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8GzEiulYh9Ep9+gk/ttx1dpeiDpIHuOYa0Q8HvtB9qvT8On5L8jQLmygNdaNPeI9k3XRfkH7zNtH9xyHWZzBSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8999 On 07.08.2023 11:23, Nicola Vetrini wrote: > On 07/08/2023 11:15, Jan Beulich wrote: >> On 07.08.2023 11:01, Julien Grall wrote: >>> On 07/08/2023 09:14, Jan Beulich wrote: >>>> On 04.08.2023 17:27, Nicola Vetrini wrote: >>>>> --- a/xen/include/xen/delay.h >>>>> +++ b/xen/include/xen/delay.h >>>>> @@ -5,6 +5,6 @@ >>>>> >>>>> #include >>>>> #define mdelay(n) (\ >>>>> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >>>>> + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) >>>> >>>> As elsewhere, please also adjust style while touching the line, at >>>> least as far as the obviously wrong case goes: >>>> >>>> #define mdelay(n) (\ >>>> {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) >>>> >>>> Even better would be >>>> >>>> #define mdelay(n) ({ \ >>>> unsigned long msec_ = (n); while (msec_--) udelay(1000); \ >>>> }) >>> >>> If you are touching the style, about converting to a staging inline >>> and >>> also splitting the line in multiple one? >> >> I'd be happy about this being done, but I wouldn't want to go as far >> with >> on-commit adjustments. Nicola, are you up to doing so in v2? > > I'm afraid I don't understand what "staging inline" refers to. Other > than that, sure thing. Surely Julien meant static inline. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:33:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577924.905040 (Exim 4.92) (envelope-from ) id 1qSwbt-00009Y-9T; Mon, 07 Aug 2023 09:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577924.905040; Mon, 07 Aug 2023 09:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwbt-00009Q-6p; Mon, 07 Aug 2023 09:33:09 +0000 Received: by outflank-mailman (input) for mailman id 577924; Mon, 07 Aug 2023 09:33:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwbs-00009C-59 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:33:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwbm-0001xU-DL; Mon, 07 Aug 2023 09:33:02 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qSwbm-0006Ox-6w; Mon, 07 Aug 2023 09:33:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=omEr1iYUr4vxM2Stm6PLywNfi8KGWlt9WzXGW/9TApY=; b=tSGxraNnpep/eloVAYx8APm7af csEDH57k2lIwMuiOLPdCygfDXE2LJFE13pw/16waN7H+Ad9CGWSyPD+Xv9erlzviyBo9G8ePmqzU4 RP8hedtmgDSboNs3+tvB+ag7TDU8S7ch3rjANxOhVZryKk+/UlqyyeL6PTlEXFYzX1+Q=; Message-ID: <06397554-a0a3-43b5-82d6-e570d2c5c081@xen.org> Date: Mon, 7 Aug 2023 10:33:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH 3/6] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-GB To: Jan Beulich , Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <486ba9e1-2bf0-4446-9ac4-33a256f8d51e@xen.org> <9918b8ef-0629-d8fb-3c58-6b20b56b1a93@suse.com> <43b45003191044cbae170404f6f4ba46@bugseng.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:32, Jan Beulich wrote: > On 07.08.2023 11:23, Nicola Vetrini wrote: >> On 07/08/2023 11:15, Jan Beulich wrote: >>> On 07.08.2023 11:01, Julien Grall wrote: >>>> On 07/08/2023 09:14, Jan Beulich wrote: >>>>> On 04.08.2023 17:27, Nicola Vetrini wrote: >>>>>> --- a/xen/include/xen/delay.h >>>>>> +++ b/xen/include/xen/delay.h >>>>>> @@ -5,6 +5,6 @@ >>>>>> >>>>>> #include >>>>>> #define mdelay(n) (\ >>>>>> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >>>>>> + {unsigned long msec_=(n); while (msec_--) udelay(1000);}) >>>>> >>>>> As elsewhere, please also adjust style while touching the line, at >>>>> least as far as the obviously wrong case goes: >>>>> >>>>> #define mdelay(n) (\ >>>>> {unsigned long msec_ = (n); while (msec_--) udelay(1000);}) >>>>> >>>>> Even better would be >>>>> >>>>> #define mdelay(n) ({ \ >>>>> unsigned long msec_ = (n); while (msec_--) udelay(1000); \ >>>>> }) >>>> >>>> If you are touching the style, about converting to a staging inline >>>> and >>>> also splitting the line in multiple one? >>> >>> I'd be happy about this being done, but I wouldn't want to go as far >>> with >>> on-commit adjustments. Nicola, are you up to doing so in v2? >> >> I'm afraid I don't understand what "staging inline" refers to. Other >> than that, sure thing. > > Surely Julien meant static inline. Yes. That was a typo. Sorry for that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:37:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:37:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577931.905050 (Exim 4.92) (envelope-from ) id 1qSwgL-0000st-QS; Mon, 07 Aug 2023 09:37:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577931.905050; Mon, 07 Aug 2023 09:37:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwgL-0000sm-Ng; Mon, 07 Aug 2023 09:37:45 +0000 Received: by outflank-mailman (input) for mailman id 577931; Mon, 07 Aug 2023 09:37:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwgK-0000sg-KE for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:37:44 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0600.outbound.protection.outlook.com [2a01:111:f400:fe0e::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f1afea7-3506-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:37:43 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VE1PR04MB7390.eurprd04.prod.outlook.com (2603:10a6:800:1aa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 09:37:40 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 09:37:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f1afea7-3506-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hvk03PJeY9/ZjAIGvb9ny+u8UoYqFZXZo/Z6q6y+pCA+CH13kAZyIFkt4CUJahlPfk+R/wXF9VlHurhWggBIKPshiYrfPNse+OpTJXvTq2sE6TY/E1+akuOX9fGyEv9/AroiIdaztQTqINU91drYQyL0XCebeCaGLkVwikxNSa5ostvzZTY6ayTySq0UcwUrXKWvdKI/fZ7m5W5FX67MXsGw0Fn5HBCwJ5SCydpBtixkbO6ylJdmsWpSnfLQ8nh+7ABRA5q7a47kBYyZrY0DSDeptChmN2jO7DQVfvMiMS6duGyN0dNl8YjBZ29blCfnuk1/1x+FEhV4gR2J13bBdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UAju/AGE2GUSoIQ1i7AYhQoyBPXYjqks3hDukTUZrBs=; b=cRad9Bn7hn5umaUQQlDe3cBf3BDrzkg6qwhNo2y43PjW5Mst9nOuhgtv0iGXEq2TAeQ3jJ4RIV26T/GNzOkvL5/IkJB/zDGFGU46efn043JrcFHLQTazrL42g7G/7cnVRqQDAZThOzL6WMGepMByaWGe9sWtBhbRSYMUzlENLYx6F2hqZfc/Eawo19tBeVwbRgwF6Z/R1k482nZhh2HL162LH6N61FS6I3t49YxWbx9fGfaT4nZssjOF92wl08QZR2nZri1D0WtEyIMSqGq3OgYs0l+S9u2AD36hJ0RMqa8gG22SH92V7p//UTYe3jr+5VGi66rMtGM6lf+4HIrRyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UAju/AGE2GUSoIQ1i7AYhQoyBPXYjqks3hDukTUZrBs=; b=JjcGaryzuWyCDC4g9QYOUGiw6aGvmp4PyesAFMxf6/kXjtlhHE9HDCTDTZ+vJuvfQMHqZ5kzImgXXjeS+GhkWScLg1Q2wnri+ac0d9WlzaXnJHvG73rGtAUxjJ0Xdb7yaWby4VHgC2RFbrQzxts2Dzg2ZcoBHDsU54X2TJp28IpW8NILxHbsMfJVB0D6PoRzjEfTqaYD2niFGlw/0485XIfun2BBYQfuV6ZrNJR8NH/4wPP3u1zyIGocVlLhofdOImwi5xN2VraJkSsI0Fcp6aeTIXKXNPbVsf3UXrZRas34yEIODxlBf0tOUZ1b6KWUPM33jMKJBBhoweeLAREf4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 11:37:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86/mce: Address violations of MISRA C:2012 Rules 8.2 and 8.3 Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder , xen-devel@lists.xenproject.org References: <1506ba7675065ee0cc3c84b05c2f8f963cbf64e6.1691399401.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <1506ba7675065ee0cc3c84b05c2f8f963cbf64e6.1691399401.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VE1PR04MB7390:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d5cbedd-8cc9-4f27-720b-08db9729f16d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9743qxCp4UZn+PUZrKG8leeFP1/YPh0AnXHJ18QSE/O0vZX6LjfULox4m6070j1/H/ICg70HWwTpt2IivWk0KSuFZSKqJg8L4KXhLAbtKmDu7LwTkJtORCVbL0pBwrHoHa7DaXMDQQ7T87mkL7yuJpEb/oAxU3bMUMDcOi0esnycDwYukdonAcOZWk3EmmpzdT8w3Jxrucftiiukbq1SEpMr6qEUSUSiAdX8RuLMF0TDv7hIqDVfRR7vknrFakh9RWRYAhdVYLTDJTh76u+dOb8E2YvTlFmmP6r3vHYjbqoY/50TiUDKy143eh62bu+dQkZj1KZ1nbacgMKaC7dkGgMJRriJT2YMBjuTufeYlIBEZT2R1lX+lG4K6y37yFhVdFgFzK1n53eDopzWDs+8R1ltP8zLytWGmGhKdqZrr+ou8hAXaxOUn+I22xyxlMnFQea0bAa7I+tJkK3oZon9GjLnizeNumFP4YOVvmgHRDXUp51/cA0NJKsg53tqTlvRAQ+v3e4aiaOVa1yaGJzDlX1EkfkxLLJLJgP/27N1opXNYUMFVCOX5nbuJkqp6zUBb4h3Hdgodlmdk5aRHICepinsqc3WOyeNugcj0yg67w4v52bU3wqSQwRKZ0onBFgtF+YZoug0uSqLTiVr2H6l6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(136003)(39850400004)(366004)(346002)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(53546011)(478600001)(6506007)(26005)(8936002)(8676002)(7416002)(38100700002)(6486002)(2616005)(4744005)(5660300002)(36756003)(2906002)(54906003)(31686004)(316002)(66556008)(66476007)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mi8yMy9HZHhYZUY5bnphWXVleW1CWExsSHJ1T1o2WWJWdHpwbEs3K2RyUEhC?= =?utf-8?B?dDJBSWNrWHYyTGJIbXdSVGxSTXJvSUhVbXJtRjNjc0UyU1d6NWVyNUVValhH?= =?utf-8?B?ckxMZGxJYTVQNmE2L1F1djlReDVPeXppd3VMVmg5dkdINGtMVnBYRE9qazJq?= =?utf-8?B?aGFja2Qwc2FYY2hBN3VYTVJyd0F3enZtVFdIeWF3NEJzK01oTG92eVlkZE5w?= =?utf-8?B?NE5ZVGgzUVNhYS80dzJYVjJVMlVoNlNGd0xkWm96YnBmWmM0bGd2Y2VEUXNW?= =?utf-8?B?TTdieGhzc3FHT0JPTVNlYU9JM0RwV2w0YXdVUWNvYmpMakRTMmRtZmhDWkk4?= =?utf-8?B?akNqVXVVZEdvK0swYjVwT1lXVklkeEpLNUFMcWpEZ21WL2hETjRxazc1OGVj?= =?utf-8?B?OWxsWG9yOGhoMmg2NitaZ0xhYjhVb3ZuRjhaRzlDYTFJc1M5VW1kcnpnVjlJ?= =?utf-8?B?NzFmdWZ6c0FVeVhiSWVqY3o4WDRDOFkyR1RqZ1NtUmtYYytNbHZFSlRHenVs?= =?utf-8?B?UTJmUXRqb3VNVm5VdFVkR3pZMFcyNStxNm5QeDAvdUh5bEg1U1pUYktlL09l?= =?utf-8?B?YXpUdklqTUhVcXJtaG9PMk50aWtHMFVMSDYweE82djkwRnhYVXdVVmpRT2RE?= =?utf-8?B?a2lnanNDbk1aWHlZbjlGeGZhY3ErcTJYUGQ4TnlnR1pYUGJ6cmFpc2ozQXd4?= =?utf-8?B?TW1YYlN3dXlPSjkxODc4K1NCY2NPcm0vZVpBcWlHVjhMemIzTDdFR3d3Y1Uz?= =?utf-8?B?UTlOeitCVUhwNU5SbU51N05EdU0vNldzRENOK3hOYmp5R1dGNU13aUFMaDdO?= =?utf-8?B?Zy9xd3JUako5LzFvaXJYWXlPcEtFQUgwSTU2K1pwTWZObGZ0eGRxM2pvdHVj?= =?utf-8?B?MklEZVJ3bWM0MkE3SzdIcEszYnBOM0VOYVI4V1ArNkNtTGpnOUhVWFZJaExX?= =?utf-8?B?VGJhWTYyaVhmYnNGS1R0TFJpMU5HMGdKT0M4UmZONG1vb3g1Z3VFWm9PTTl1?= =?utf-8?B?N21SQS9tY3JJUEtsUk9pRWtXWEtHa21wZFdvenhvcHovbE55c21OQ01nQUp2?= =?utf-8?B?QVl2OGY5WG4wMHVFTXdwYnBVaG1rRm12MUVOSG4xaHlKNXFmMTRiM21USUxm?= =?utf-8?B?YStoOWwwMG1XMlBFNHQxdTFEU1NoU1NHcXRINGhQS2dKc3lKRU94RWhOR0t6?= =?utf-8?B?TjR0V2gxcUt3OTBSYk51OXRrcEZlbTJNZ3dySStQYkNDQ3RGV3lPWnFNMXVK?= =?utf-8?B?aHFRTHRsd1NoVENtcWh4WTVSSTF3WnRMVkV6bDZpVFZRaWVtRTdOQ2xWSytE?= =?utf-8?B?SWE5ME9iZ1NsMnZ3NnBCOEpuZ1ZTQ0J0VE8zZUJ1N3o0RWs0aGVpN1pHeEdh?= =?utf-8?B?bnlBWXZUb3VhY01LU0M2cWEvTWdCVEYxQWRZWXA1b2lyano5TWF2R282QVlv?= =?utf-8?B?ZElXaDVvNDVMWnBIUkR4aksvOWU3aDlaZHNJeU84b29xbTU3RWlwNTZZZitj?= =?utf-8?B?a1lKNkFlM0V5VWtlK0Q3Vk8xcWpmRmt4ZWY1Nkd3MkVXSjgzVW12R0dMNnZZ?= =?utf-8?B?amZEYVlQTTBZbkNCUkNXZ3ZacVRZRmdqakNwaUhUOG1RYWVLSnYyRk9xL1JJ?= =?utf-8?B?TGZOb2c5NDErUmhBTjlURHl0Z0tYRW91Q09MT29TT3lVSWZjQ3o4Mkt6Mml1?= =?utf-8?B?alZCdHBZTUI4anV5Nm9QOUxKQjN2OFFPK0RXM2F2eDZHMDFzYzJUNDlyc0xC?= =?utf-8?B?YzhwNjV6eExvVmUwR3lkcVhHem14M2dLTFFDS1hJSEVSeW5HL3RHc3NTM2M2?= =?utf-8?B?NENla0s0Y3R5WVdPemYyL01QRTNBVFpYWVc0Sm8xVzM1Q29YNDRUVXJOMjZZ?= =?utf-8?B?VSs5ZDRvcnFFQlJiMlF2TEJYWG9uUkwwaHI0UWphUk1EaHo0L2RmV1ZPMWds?= =?utf-8?B?VW1oOEcyVFNjZURFZEFoWFBDZWpSMi9aZmhDOVRGU2ZWVXZQdFpzM05SVlhu?= =?utf-8?B?VXZESXRZZjdGVmZJczB1UFQ5WEYrcnR5RWlsWDVUYWM1OENTcTAzRjQ1ZGlR?= =?utf-8?B?cGpuZU5BemExVCs5Qkx1VGlKNVVZR0RLYjFlU0ZsVGR6RlA4VmxoMTQ5TG0r?= =?utf-8?Q?XZtsqyfjnFtRtSSj7cxGmRxnJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d5cbedd-8cc9-4f27-720b-08db9729f16d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:37:40.3919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jnF+tUL5X+N62FgBOOuPzCl8gj9wSGeU8OBKR6JoMf4M/IWvnqb+8LQMxsQmJA951bDh1dAx1t0Q476hRMqn0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7390 On 07.08.2023 11:23, Federico Serafini wrote: > Give a name to unnamed parameters to address violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between parameter types used in function > declarations and the ones used in the corresponding function > definitions, thus addressing violations of MISRA C:2012 Rule 8.3 > ("All declarations of an object or function shall use the same names > and type qualifiers"). > > No functional change. > > Signed-off-by: Federico Serafini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:40:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:40:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577935.905060 (Exim 4.92) (envelope-from ) id 1qSwip-0002Iy-7J; Mon, 07 Aug 2023 09:40:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577935.905060; Mon, 07 Aug 2023 09:40:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwip-0002Ir-4M; Mon, 07 Aug 2023 09:40:19 +0000 Received: by outflank-mailman (input) for mailman id 577935; Mon, 07 Aug 2023 09:40:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwin-0002Ij-GS for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:40:17 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 679d72dc-3506-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:40:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 431FF3200583; Mon, 7 Aug 2023 05:40:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 07 Aug 2023 05:40:10 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 05:40:07 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 679d72dc-3506-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691401209; x=1691487609; bh=CQofn4kIIMGyS3oRnZGe7L+ew6Ute4sCDJJ Fql2/Wzo=; b=VoQvsoUsTgoYMIcsh1iIBzf9FfYI7JymX5ew1jXBGtJGRkgzp8+ BzR5ji4sK+cscLabQPEW9W0Bfzsoa8f8TRAExLhnHA0L6z1UCKDhOIl/Xg206cAK afofzpilWyFdoDcdaz6XIhLgsDiGH+8icS2uSeehCGgl3y6DN1PQGRhAeGiIGkhH N6A4I4cz1e6ScUrXS81ZA+Z48a3AEs9F8ZoXpBs8kZVhiBAk3wm9Kq77pTM2gejm 0kptXcV+GWxqqJ3efFihK17LeHIfSGHpKPM3rYQ0DSqMXOR+xMajLSvhlg5mPRDD J5Nlu9lyjhsi20U1+7MLo1YrLFbuLUEW33Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691401209; x=1691487609; bh=CQofn4kIIMGyS 3oRnZGe7L+ew6Ute4sCDJJFql2/Wzo=; b=bLP2urWte1cys9qMwAxSC/kFcKFAV NlwqlsP+9BROhFDF+k4ZTxEXmrv8GiQma3zZCD9BGraox8+yJ0svJeE8B1NN2J/c jgIIyEgEZZAtnNITJgPgoFLwshGQj1Esjf0MzC2UrjjIX+InbS3pv1EpCUESEQQg PZ7z8fj2U2iYxdL5P0XJ9aC6LD2rTFj1WlsyjSKI6EIeJfTF3i3LxJorWTJGUsfV rx7kGSclO964m0LEFLve+bAfRDK87vGyWjtMiC8YpsAUjXQVsuxpwdo/7joWT7s7 niK7WnWsFoNgiN35JvU8iYgKVr6jLuEXH3PRol4vz1n6JHfPnXqEZt0Bw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuihhmohhnucfi rghishgvrhcuoehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh eqnecuggftrfgrthhtvghrnhepueevheegtdefgeefuddvfeduueduffffffejveeugeef udefiedugedugeevudfgnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsihhmohhnsehinhhv ihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail From: Simon Gaiser To: xen-devel@lists.xenproject.org Cc: Simon Gaiser , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Date: Mon, 7 Aug 2023 11:38:25 +0200 Message-Id: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It seems some firmwares put dummy entries in the ACPI MADT table for non existing processors. On my NUC11TNHi5 those have the invalid APIC ID 0xff. Linux already has code to handle those cases both in acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the same check to Xen. Note that on some older (2nd gen Core i) laptop of mine I also saw dummy entries with a valid APIC ID. Linux would still ignore those because they have !ACPI_MADT_ENABLED && !ACPI_MADT_ONLINE_CAPABLE. But in Xen this check is only active for madt_revision >= 5. But since this version check seems to be intentionally I leave that alone. Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f3bf1dbe64b62a2058dd1944c00990df203e8e7a # [1] Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=10daf10ab154e31237a8c07242be3063fb6a9bf4 # [2] Signed-off-by: Simon Gaiser --- xen/arch/x86/acpi/boot.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c index 54b72d716b..4a62822fa9 100644 --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end) if (BAD_MADT_ENTRY(processor, end)) return -EINVAL; + /* Ignore entries with invalid apicid */ + if (processor->local_apic_id == 0xffffffff) + return 0; + /* Don't register processors that cannot be onlined. */ if (madt_revision >= 5 && !(processor->lapic_flags & ACPI_MADT_ENABLED) && !(processor->lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) return 0; - if ((processor->lapic_flags & ACPI_MADT_ENABLED) || - processor->local_apic_id != 0xffffffff || opt_cpu_info) { + if ((processor->lapic_flags & ACPI_MADT_ENABLED) || opt_cpu_info) { acpi_table_print_madt_entry(header); log = true; } @@ -143,14 +146,17 @@ acpi_parse_lapic(struct acpi_subtable_header * header, const unsigned long end) if (BAD_MADT_ENTRY(processor, end)) return -EINVAL; + /* Ignore entries with invalid apicid */ + if (processor->id == 0xff) + return 0; + /* Don't register processors that cannot be onlined. */ if (madt_revision >= 5 && !(processor->lapic_flags & ACPI_MADT_ENABLED) && !(processor->lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) return 0; - if ((processor->lapic_flags & ACPI_MADT_ENABLED) || - processor->id != 0xff || opt_cpu_info) + if ((processor->lapic_flags & ACPI_MADT_ENABLED) || opt_cpu_info) acpi_table_print_madt_entry(header); /* Record local apic id only when enabled */ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:47:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:47:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577942.905070 (Exim 4.92) (envelope-from ) id 1qSwpn-0002zy-U2; Mon, 07 Aug 2023 09:47:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577942.905070; Mon, 07 Aug 2023 09:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwpn-0002zr-R0; Mon, 07 Aug 2023 09:47:31 +0000 Received: by outflank-mailman (input) for mailman id 577942; Mon, 07 Aug 2023 09:47:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSwpm-0002zc-EO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:47:30 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bb0d336-3507-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:47:29 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id A42DF320090F; Mon, 7 Aug 2023 05:47:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 07 Aug 2023 05:47:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 05:47:24 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bb0d336-3507-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691401646; x=1691488046; bh=oyiuSl6ubAxDMpNDLfcH1Iyv9puo3tY1ocC wH/6+1ao=; b=awSgKozHJ8gpF9Ml+ivW1Gc6X9hJIUDhyG/pPTgN9nKuvgwNYdE EmHSolBZVYIa8NdYQuE1PEFsLrAdJVaywVYayNdgBt+GFRdpqM/xXi/cry/ts8LT dmEiuYz3z9zEm7oZ9PWnjppjqeNSHTBNMXiFEH/bI2mGtpKFFpCNJ4E2c5Ur/VU3 ZcJTXLWTPmxb6OfTdS8P7LlDYnw5LficKbBX5Oi9+9DOf+x1VCI9RcriH/0t1lQx XYNA5zWSSZbfrPpystFaE9WRQKHu9OHttfQHArYtThRGDULtgjwbgY6MtUcsuoVf H0YYZ+T7XQ5SFQ7CXqhq4Gm88wC37q+ecBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691401646; x=1691488046; bh=oyiuSl6ubAxDM pNDLfcH1Iyv9puo3tY1ocCwH/6+1ao=; b=12Cw/hnCNLV0rCBbhAG9xsSnstNac KyChLLEDIQZu8q5ZL70Y0ebtHA4jeZd2ZvtBalDi4s0cqHmY4OE5fyFnCcvcWVfq 6uWW+s3MA8mgP7Zmjp8BqSRcj7oPnS6tgUCdnGybaCw/fk/2EQjQ5SVfwAn+TATl mscQXWLFonCXE3IZIXtVraMnXhKp8pHaB3DXvA98VFbDRYTk7RGKQ2T7XzgdUCpT fKFr+Pbwmlh3wFkLb1LGDZ9UwXpbVci/ExjlmFP33scM9oS5kT28ODX+a3jF1zL2 R8Hnbxa13nKFbNshSw9cx15YmcndL5BMa7GP+xS9sD/AedmniNxwLzHag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeekueffiedtgeffleeglefhledtfefgiedtveeiffeg hffgledtveehhfdugfetveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <16d5ea81-b12d-df4c-bbbb-0d9cdc2df8f0@invisiblethingslab.com> Date: Mon, 7 Aug 2023 11:47:12 +0200 MIME-Version: 1.0 Subject: Re: [XEN PATCH v2] x86/hpet: Disable legacy replacement mode after IRQ test Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <8757d4b8-7765-e50f-73d2-34c7c34acaa5@suse.com> From: Simon Gaiser In-Reply-To: <8757d4b8-7765-e50f-73d2-34c7c34acaa5@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------FqNyTuaOB7wvgh5boHzi1Prp" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------FqNyTuaOB7wvgh5boHzi1Prp Content-Type: multipart/mixed; boundary="------------bzYp4zvEK8XxHai1001cssK7"; protected-headers="v1" From: Simon Gaiser To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org Message-ID: <16d5ea81-b12d-df4c-bbbb-0d9cdc2df8f0@invisiblethingslab.com> Subject: Re: [XEN PATCH v2] x86/hpet: Disable legacy replacement mode after IRQ test References: <8757d4b8-7765-e50f-73d2-34c7c34acaa5@suse.com> In-Reply-To: <8757d4b8-7765-e50f-73d2-34c7c34acaa5@suse.com> --------------bzYp4zvEK8XxHai1001cssK7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jan Beulich: > On 31.07.2023 12:32, Simon Gaiser wrote: >> --- a/xen/arch/x86/io_apic.c >> +++ b/xen/arch/x86/io_apic.c >> @@ -1967,6 +1967,8 @@ static void __init check_timer(void) >> =20 >> if ( timer_irq_works() ) >> { >> + printk(XENLOG_INFO "IRQ test with HPET Legacy Replace= ment Mode worked. Disabling it again.\n"); >> + hpet_disable_legacy_replacement_mode(); >> local_irq_restore(flags); >> return; >> } >=20 > I'm not sure of the value of the log message. Furthermore, considering > plans to make XENLOG_INFO visible by default in release builds, when > not purely a debugging message. I'm curious what other x86 maintainers > think ... As far as I can see nobody has so far voiced an opinion. How about you tell me the level and message you would prefer and I send a new version of the patch with it. Simon --------------bzYp4zvEK8XxHai1001cssK7-- --------------FqNyTuaOB7wvgh5boHzi1Prp Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTQvaIACgkQkO9xfO/x ly9Dxg//Tj8yrK7W8agNBrnli7aYzzXSQCczKzZwwSVAzl9Aszchm4zBwDuOil0H LgnRkZSMr+4GtynGUANcentVO2CDymlChTmf72l2u39xlYuyP3SxUyJpo4BrD9Pt ExEkGgz3ELJf0nnawInhomL6v6I/m8zDKVsNZllRL9UvOykPchB9VUNMzQlj2oi/ vdO2BOldbZ+OyUbeG3SWXgNNG9gQm1h0OT6oCpNwY/LxmUJ1fAiKEu+i6MDeF37R mUsdlLX9pH+bXm16CVN8vJKXT06pwtBNh1gYizBl+9iHtN3b+FMPtpH4ecrxJiHB yAnzfwPKbEbrFxD+76ENa0y6JtdqqaCJ5aC0m75nNzqBt/wec5pfJSpM+uDJod+P qrNiFyhodp65DdttD2XHvoL6xLWKobquElyPtqZSzRtLkJKw/vHd3Al4/th5Ic0d 6o7/7ThRqxnPnHLX1muocg/vQVOBv1h+BI13HKUEapM5346W0h66o3RXz0MzJhHk 6/45d5t7WQ1wgtYrEGBsQa00Q8Wy4Ahqi91qk7U9NYKXBe9D+vGHVgsuOm9hvZEF Ea7w/eiS1IoAO5YcBHO5oU42ilCF1nl6gIkvONpOoJVh594tQG6U06PGp+bgdvWs H5KuAgYwcjGH0qja5RusdeN3ykFhBaseLc0KRUUj9IRV6TrlPqU= =qSzw -----END PGP SIGNATURE----- --------------FqNyTuaOB7wvgh5boHzi1Prp-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:59:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577950.905091 (Exim 4.92) (envelope-from ) id 1qSx1J-0004sX-8d; Mon, 07 Aug 2023 09:59:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577950.905091; Mon, 07 Aug 2023 09:59:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx1J-0004sQ-5x; Mon, 07 Aug 2023 09:59:25 +0000 Received: by outflank-mailman (input) for mailman id 577950; Mon, 07 Aug 2023 09:59:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx1I-0004s1-IZ for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:59:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060f.outbound.protection.outlook.com [2a01:111:f400:7e1a::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15b30b57-3509-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 11:59:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8831.eurprd04.prod.outlook.com (2603:10a6:102:20e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 09:59:20 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 09:59:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15b30b57-3509-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BsUB3c+QvrNE2qKQS3ceNVeBVEGIhTieTN3B+GmxNwdzVbeaujMrPpqQm6jAnot+8UMOKkMzTbAxneKtzdYsqaSL0j7ywZIEEjm1Y+rd9ukLrP2l8pKI3t5x8ss+hJiZuTwF9b/aNIdAkG+gZVSW9I6RKh5w+61SOhFN1c+tXbEnFNRiFTQJzv4Or/F6rBLMPwnCwnlCj47Pxa5XAiDJzkY61cbPVGz0NX9hqGgvXXmRrHq/Y4Qj5DYI4o+wwGrEKXJW9kAd7iXq+C+o7awjDCAjL1kC4DY8zEowKFzGZk/WjCo7yqCVpFrqRj6KiEFFo6gKOhisUgeV7K9tKbaNOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PYk04VqF6SMS20j6DS9Kk5uPePKrMrEqgZXcw7Zbbz8=; b=BIUPH1yuzZapqFZpp+C4bfgFtnlOWa7XnZ7TpZ4s98I4iENZU/+y/a1XYUjg8Pl0+RAj1c9THLvr1NLquhzxbFkJn4lYjM4pTRV8ORsa+izO1piUJQSYbtOvz1vXzKSK9mnAjZhpm93OkoxQQrBqnwwzgldvB4RbX16YwXgzNuzvAXwtFz4oLKiN7ztS659h+4fciCFBxCm6SCAIKU0Obd+dk8EmAcvTCtBUl2Vru5RzrA4hWjU8Zy2FarR5S3n1l9GNKDorOjxi6RvrcC6PkomLENAJDZZhvoPcgoaXjGzXO6g2m/T0bL5WJqNuxcP4/LdAfMn5IKznSi/IzsnM/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PYk04VqF6SMS20j6DS9Kk5uPePKrMrEqgZXcw7Zbbz8=; b=Ws6YXCnkCexI7hQYwsYfC8JsfjzrSZGsTJtn6upNJ0ShljotzMktYcvTJXf4gaP6vRDQ8a1suJASMFH9/MC1slYS5NxMn+jVrhDkNkT4k8qcxNyDB9NEo8LaV0/BssPwafQp0fSbFZF2Yyp7bqpckBrdyHGgTIqjjuuwwnfZU7kfTOvzPNfNeVXbr1mmGgmnr7+hBZ/lhRTywpwl3aV+SMW5UV/dwehQUv0y+jJEp8EqIfjWo2kanb9uki1+aMlhiXAGFrGSZoaWvWBXMMqU/9auZq1DqORQ1Jt1Ha+cfteKBgmRvnLJqsCrnIRheDBs9im3tFbrvFXXyoiiiR3G8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7313b0fe-140c-f17b-a2ec-8b5a943eb0a9@suse.com> Date: Mon, 7 Aug 2023 11:59:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2] x86/hpet: Disable legacy replacement mode after IRQ test Content-Language: en-US To: Simon Gaiser Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <8757d4b8-7765-e50f-73d2-34c7c34acaa5@suse.com> <16d5ea81-b12d-df4c-bbbb-0d9cdc2df8f0@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <16d5ea81-b12d-df4c-bbbb-0d9cdc2df8f0@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8831:EE_ X-MS-Office365-Filtering-Correlation-Id: 13be70cb-4252-410f-aa0c-08db972cf812 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s3xuj7SV79liwdzYxFPZ6HUvFyedJb8dWUoOsQBFGUSkQyffrkR5jBwpjL2DQqnH/fBCHX/YPMiEpxcDHfSl5dBbae+6oeJjt5hBwt78CoOtOindSbpxiP2KrjsS73vbj+Z3YD5y2TlJ0xGJHA6EsrAkVAVpAeUdJKNZnGCqZ3T7lPgCp9w1jIP+CIAWEV7DPcPLJZKk5XbFmp6yhcSgTg9MFw7/UZPQZ9VMOrcp3IDZYsyEQNlVMYDr+q5brjRxiZf6Bj9t+d82qiny07dtW/PCiNfSkdhoT2ZVLs3cV2YTBZyZy3IiuMmK5/c9wsdywSY69/uMXdPPvRiAlRLvFOIMub5ECudZ07+r8WLbsXgjgZXGXX8soviyLkHgHbATYgsm+QIHFM1sB14K1o2q6qnVTr9yLWRnx3pbx6EJF897DsUbHDyayoGpK0ZDLGsO6FRe0tFcHIzyokD6nHWKuWTPqfVKT+TvcXOh6eY+n0HOeGKpJaJ0i+OM6jrY5eJPkzng3KFA6d27uqteYrtxbzXhN7l1fDvAO43FPdzuIZrrB6Y9fdWiOt+DCK2YfTq65L73jTV9uh80To6QYYHk/j0selE4/Ew6UHdy8lSaXp9gDfClhXfn/jh2VhoD5BdxxuKohRGH52hKmDwkZjZk2w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(396003)(366004)(346002)(136003)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(478600001)(53546011)(6506007)(8676002)(8936002)(26005)(38100700002)(6486002)(2616005)(4744005)(5660300002)(83380400001)(36756003)(2906002)(54906003)(31686004)(316002)(66556008)(66476007)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDNiKzhyN0RDUU9zVU04OFJGeGNjbVU0RFYvTW11ek05UDdwMjV4QlFrWUdl?= =?utf-8?B?OUVyWGlsSTNaRloyT0lrY2ZDOHB2T3p1TVRNN2dsT25CMUE3aythaVFKR2Fa?= =?utf-8?B?VTNaTldBZTNJWGNJSVl0VHFUZnc3SXFKMVRiODBpcU9zYzNxMk5wcmJyOTlz?= =?utf-8?B?MEE0dUZXWVljSzF1SUU3ZWN1K3o4TmxnbmFCM2s3bWpaTU9nN3pTbldyTEN0?= =?utf-8?B?dFVLbVMxY1ErV0xpUERZS0wyRDNyZnRNUEp2TWtFdWozYmVickZJRUtBV3gr?= =?utf-8?B?RlBuR09WRTIvMVRRTWhNaFcxditubmZ5eW4vN0k3QjdzLzdmVlNrcUMzYm43?= =?utf-8?B?bWxONXlMUDBTMzV4aE1LYlRRaHFwblloN01ZRGJFOWRGS1lIU25mZCs2bGFj?= =?utf-8?B?NXRvdU0weFNsNmRaWlNvRXYyZE16UzBrdkhlY1dSRXk2MldUOTU5cFdWMytT?= =?utf-8?B?V0hyK3pEeW5tdWNPK3FLYTFZVkxZdk9idHY4UDZYcFpFTTY1S1JCUitERktx?= =?utf-8?B?M3p4aEdIY1g3N2Vwd1JYSnB1ZUVKdWY5UU03aklMNXBYZ0lCdzJJRXlHMWoy?= =?utf-8?B?WUc3UytZajlLeTdzNm1qYjZjemNsWWN2LzVvWm5vTFJKS2hXR3RtWnBGQnlZ?= =?utf-8?B?SDEvUjR1WkRqZS9kaFd2blJUdlBOSGZKY3lRYy92aTRXRXFCL29UdHF0SFBs?= =?utf-8?B?SjU1azBHWDZZNU1iOEJGN2tQS1I5T3d2SEFnL09tR0VFUWFCMjZzMzJjbzZl?= =?utf-8?B?QUhwWUJtOW9OT2ZWZUhDM3NGdXJJaWkxRHUwSjdqMlR0Rk5PbExWWUNQQzl2?= =?utf-8?B?TVJnS0hIZk11K2s5eWdqYW1VY3RyY1BKc2huVG13Q1hrRlRwWVNqNVA4bitZ?= =?utf-8?B?M0lxM1gvdWdGb3RMZEZ3emVUd1liM3VuckxoVjBrNS9zM3drTGQ5QzJMdWZx?= =?utf-8?B?cXhPb1FVeTNveEVmb3VkWU9kUkJDVFpVUXcwV1pEMTYyaHo3TUdUT2tWbTFD?= =?utf-8?B?WXZ5NGJLSExQVTh0eW1CWW5FTVlNdG9tVVZBcXE5ekt5Y0owd1NpVXpnSXFD?= =?utf-8?B?ZGtwRkZPMU5RVTdYWHBRUDMwQ2RodnJqbDB0a2hWbXZsSzJtUGpHWU1UVXdE?= =?utf-8?B?RlRmL0xsa1NSUFFjZGw1VXQ1YWF3dVdIMWtYT1FlWktmNVVIS3FIZXdPdnNZ?= =?utf-8?B?S0NJV2w1U2JyOXhVbHNoRjcya1NwQndPb2tmbVYyV0Q0ZUhSYWtJYWpETDlo?= =?utf-8?B?SktZY2QyeTN3TjV2azFDWmxCTVF1YzFVRmFyTlhzdzNOOUl5TVZ4Q2FsdTBq?= =?utf-8?B?ZENRbHAzd3hUTmM3NVBrZlRLQ1Z5V0lPZmg2UWNQb29CVlNOZmdZcHE0Lzdl?= =?utf-8?B?dkVOM3A4Y3p6N2ZqNFdoT1A2eUgrenZ5aGM2Um9DN2JGbFJHMU5pZHgyNkJz?= =?utf-8?B?T05OSVJncXlRVjZwT0tvQ1ZNSmFMQTl2dFF3WnM1d3p6OHJCU3lDRjR0czk4?= =?utf-8?B?QndxYjRlRFkrczJaN290Nlh1ZjBSUktBcFFoTy9LUHpsdk05ZW52cVpJNERh?= =?utf-8?B?SXpPc0dOaURaemdyMytSQjJtR3JKcXMwWkR6S01IcEUyOE1tR25KbEprc0hN?= =?utf-8?B?aWpraVVwYk5QQTR3SDZaUG1hSUNZWUZpUjhNdjFqMHhxVXRtc2tZN2ZzdkR1?= =?utf-8?B?YjNXUXhrYkhkaStDY1JxbGJjWVZSQW1zQTZOLzRJSnVnVnd3WmExOHZteGxy?= =?utf-8?B?TndweDRQUXdaUmFCRVdWMVdhZUNlTVpLa1VCN0NEa2Vkb3F5QndlbklQQmZX?= =?utf-8?B?R3l5VlBaU2xpbUJuVnlqQmtuaytWZ3I1dXE0aFlzWGxZSU9kTHpoZTVPRmw0?= =?utf-8?B?eUl6U21uUTRYUFkzM21SelU5Z1hITnFTekVnQjBveXpZaUpnTHNuSUI2b0xT?= =?utf-8?B?REZhUlZKRWFpTkQydmZod1MwV0RVNS9DOXJnS2dtSGo5SXBYa0sxVVpDRG9D?= =?utf-8?B?azlVMzdxUjdOZ05UcHBsT3lLWVNjbUtjVk9ybFlwdUZyQ05kWWU4eCtZWTZC?= =?utf-8?B?cXo0aUdyMHNYYndzWlhpdWgydndONEx0UmM5TVhsNW5wd05TNzBKMDdLeHVo?= =?utf-8?Q?MqfwayiSjHKuETWLptW7e58hy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13be70cb-4252-410f-aa0c-08db972cf812 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 09:59:20.0516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dy9x7S4nju5ubNzJbpDJbP6N7H8gTSdwBn/0iERzMApR5oQKTXzD9DK6/AzE4w71cOGMDUTZZnXIc3FOywA6/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8831 On 07.08.2023 11:47, Simon Gaiser wrote: > Jan Beulich: >> On 31.07.2023 12:32, Simon Gaiser wrote: >>> --- a/xen/arch/x86/io_apic.c >>> +++ b/xen/arch/x86/io_apic.c >>> @@ -1967,6 +1967,8 @@ static void __init check_timer(void) >>> >>> if ( timer_irq_works() ) >>> { >>> + printk(XENLOG_INFO "IRQ test with HPET Legacy Replacement Mode worked. Disabling it again.\n"); >>> + hpet_disable_legacy_replacement_mode(); >>> local_irq_restore(flags); >>> return; >>> } >> >> I'm not sure of the value of the log message. Furthermore, considering >> plans to make XENLOG_INFO visible by default in release builds, when >> not purely a debugging message. I'm curious what other x86 maintainers >> think ... > > As far as I can see nobody has so far voiced an opinion. How about you > tell me the level and message you would prefer and I send a new version > of the patch with it. XENLOG_DEBUG or even dprintk(). Also note that generally we avoid full stops in log messages. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 09:59:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 09:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577949.905081 (Exim 4.92) (envelope-from ) id 1qSx1F-0004cy-1x; Mon, 07 Aug 2023 09:59:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577949.905081; Mon, 07 Aug 2023 09:59:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx1E-0004cr-VQ; Mon, 07 Aug 2023 09:59:20 +0000 Received: by outflank-mailman (input) for mailman id 577949; Mon, 07 Aug 2023 09:59:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx1E-0004cl-7M for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 09:59:20 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11ce40e8-3509-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 11:59:17 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6EE3B320092E; Mon, 7 Aug 2023 05:59:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 07 Aug 2023 05:59:15 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 05:59:11 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11ce40e8-3509-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691402353; x=1691488753; bh=NnJHsNHV4OfsrSbJcrxixDSVctE5Vm1FZDV XQonRK28=; b=IYZSjhevKZ39mQ5YchWxKBlYvjz7kYLK5zX4FfKNbd8l7ZR1Gy7 QRTnjPkTR46sVXUwg92DNaR1or3MhxNkLovS6J3e/0EL2l3944O2WcbMXpE05AtQ aNsJNilWZZ5+V5z2sJZPUv7DW6WYccwQjysHf9o+4iKrXrJyWFfmNcSKdyMREpeH ploW+KPPFQRskYde8Xwj/FJpcnEjlyKgfjCtHq3116bjFLxXYWKbbh+/dFL8UI/p sfaINnLc5+NSWUPXZI59Hq8ZAFcs8Zkx1PvEWI3QirEJhSvSVKLonZ1vPD++su+P vSHXwGgzCC780j0d0ZE89togH7JudZqzFJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691402353; x=1691488753; bh=NnJHsNHV4Ofsr SbJcrxixDSVctE5Vm1FZDVXQonRK28=; b=Aj3BZ5wbQYvBfg1O4InTRenouxvBd jK61yrF4KSCnoLfUu4cxfvuMbBcT2fIsGo3Om/TExg/Dm6rm0PsQ1Zt7HTXe9yI1 A8CUWmgfo0DCcb/r1ymzcgCnoGomZJJzHtN4uAZDdoQe+Pj1TZffsMUEmkzyysLK 5h1omZXG7HreA0p7bWCb9L/b2/D5tEiKzamzNR88tsjvKyBcMLHHCuwB+h7mmWzA h/VJz77nLLuGCdwcp126o3JUNqr08nyby+MArdzDsGO4ZxBb/EWXkAXb1bum7OKm U1yZxfmSJgBgHuRv2vkaW4Q4g04JtvNMqs5ot+ufz0IfKHWuKhHyJk2RQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeekueffiedtgeffleeglefhledtfefgiedtveeiffeg hffgledtveehhfdugfetveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: Date: Mon, 7 Aug 2023 11:58:57 +0200 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information Content-Language: en-US To: Jan Beulich Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Liguori , xen-devel@lists.xenproject.org References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> From: Simon Gaiser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------suLZkn5eJE6TTbWMj8Dz7Q7b" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------suLZkn5eJE6TTbWMj8Dz7Q7b Content-Type: multipart/mixed; boundary="------------mpW42AXmdBj07vPFTjgkt9Mo"; protected-headers="v1" From: Simon Gaiser To: Jan Beulich Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Liguori , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> In-Reply-To: --------------mpW42AXmdBj07vPFTjgkt9Mo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jan Beulich: > On 07.08.2023 10:18, Simon Gaiser wrote: >> Anthony Liguori: >>> From: Jan H. Sch=C3=B6nherr >>> >>> Intel says for CPUID leaf 0Bh: >>> >>> "Software must not use EBX[15:0] to enumerate processor >>> topology of the system. This value in this field >>> (EBX[15:0]) is only intended for display/diagnostic >>> purposes. The actual number of logical processors >>> available to BIOS/OS/Applications may be different from >>> the value of EBX[15:0], depending on software and platform >>> hardware configurations." >>> >>> And yet, we're using them to derive the number cores in a package >>> and the number of siblings in a core. >>> >>> Derive the number of siblings and cores from EAX instead, which is >>> intended for that. >>> >>> Signed-off-by: Jan H. Sch=C3=B6nherr >>> --- >>> xen/arch/x86/cpu/common.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >>> index e9588b3..22f392f 100644 >>> --- a/xen/arch/x86/cpu/common.c >>> +++ b/xen/arch/x86/cpu/common.c >>> @@ -479,8 +479,8 @@ void detect_extended_topology(struct cpuinfo_x86 = *c) >>> initial_apicid =3D edx; >>> =20 >>> /* Populate HT related information from sub-leaf level 0 */ >>> - core_level_siblings =3D c->x86_num_siblings =3D LEVEL_MAX_SIBLING= S(ebx); >>> core_plus_mask_width =3D ht_mask_width =3D BITS_SHIFT_NEXT_LEVEL(= eax); >>> + core_level_siblings =3D c->x86_num_siblings =3D 1 << ht_mask_widt= h; >>> =20 >>> sub_index =3D 1; >>> do { >>> @@ -488,8 +488,8 @@ void detect_extended_topology(struct cpuinfo_x86 = *c) >>> =20 >>> /* Check for the Core type in the implemented sub leaves = */ >>> if ( LEAFB_SUBTYPE(ecx) =3D=3D CORE_TYPE ) { >>> - core_level_siblings =3D LEVEL_MAX_SIBLINGS(ebx); >>> core_plus_mask_width =3D BITS_SHIFT_NEXT_LEVEL(ea= x); >>> + core_level_siblings =3D 1 << core_plus_mask_width= ; >> >> >> On the i5-1135G7 (4 cores with each 2 threads) I'm currently testing o= n >> I noticed that this changes leads to core_level_siblings =3D=3D 16 and= >> therefore x86_max_cores =3D=3D 8. If read from ebx like before this ch= ange >> and what Linux is still doing [1] it reads core_level_siblings =3D=3D = 8 (as >> expected?). >> >> What's the expected semantic here? If it's to derive the actual number= >> of siblings (and therefore cores) in a package as the commit message >> suggest, the new code can't work even ignoring the example from my tes= t >> system. It will always produce powers of 2, so can't get it right on a= >> system with, say, 6 cores. >=20 > The only use of the variable in question is in this statement: >=20 > c->x86_max_cores =3D (core_level_siblings / c->x86_num_siblings);= >=20 > Note the "max" in the name. This is how many _could_ be there, not how > many _are_ there, aiui. I'm indeed not quite sure on the intended semantic, hence the question (although it's not clear to me what case that "could" would cover here). It doesn't have to be identical but Linux says for it's version of the variable: The number of cores in a package. This information is retrieved via CPUID. And if I look at it's usage in set_nr_sockets in Xen: nr_sockets =3D last_physid(phys_cpu_present_map) / boot_cpu_data.x86_max_cores / boot_cpu_data.x86_num_siblings + 1; It seems to be also be used in this meaning. At least on my test system I get last_physid =3D=3D 7 (as I would have expected for 8 logical cpus).= So dividing this by the 4 (number of cores) and 2 (threads per core) is what I think was intended here. Simon --------------mpW42AXmdBj07vPFTjgkt9Mo-- --------------suLZkn5eJE6TTbWMj8Dz7Q7b Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTQwGMACgkQkO9xfO/x ly910g//btGBpAMajhFtMxVqr9mciThE8/H86UuVN9Dw9EgaMexo12ulQLLoj0E6 mZTA1oJ/Yi560VJwCGhKOG3PMFh8XnFCGw8zLYYYsHhnrWaPknx7t3tC9ZsHBUA9 zx8gdCZGM9AsnwVL3Sv1nwAVwCqHHiA8+5BcOLzgBMc9MbV3NLOrrQNTagI96KWP njyZs9a7r6+5yGwUD4ypHmu4yC6Qj2FBhMcG8xuAcxV0VMYz9imq4lcVEF0qL4BA nsqtMHGGh6S3AUJ6zt+k9kVpVIhPkOH/c4NsP7j1tsE6nMd5Uoc0MvqRhsIygYpd 6+wHTnnXUPtvxpBY5TKYt1N01zKZmP3dJiyRhgUs9uAwNQ/kWdSOXFSRlD4AFIl/ Oj1RtLLdSQMp5Lzwu7w0cTEkYfVk5zD66Ku7R4SdkJz3n9P0a8EXy/4iX41cMGem MrMjIdp0BvLs9W2APz6wQ6QQa56dQ7zuSCQ8mxAnZagm2bRd5Jc6jhT5om8V4K8s YQX5+vNUQvM/ILwFNfUSci0KAnklRE3YcIG0oUZFE03EfW5/KZZ3yiS9JZZvBqsV O5SU8rfkBUN8rd73JcRqDoly5ypLsuyHs+HMUx5azk7vIglk6EO9nPUqs7cUUVui 0gim1f1HLhS2xeN23iD1ALWzmeUSAcp76vOuF1csLOQTYglgnJw= =9E1i -----END PGP SIGNATURE----- --------------suLZkn5eJE6TTbWMj8Dz7Q7b-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:01:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:01:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577958.905101 (Exim 4.92) (envelope-from ) id 1qSx34-0006dR-KY; Mon, 07 Aug 2023 10:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577958.905101; Mon, 07 Aug 2023 10:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx34-0006dK-Ht; Mon, 07 Aug 2023 10:01:14 +0000 Received: by outflank-mailman (input) for mailman id 577958; Mon, 07 Aug 2023 10:01:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx33-0006dC-FD for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:01:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 562deceb-3509-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 12:01:11 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id EC1DA4EE0737; Mon, 7 Aug 2023 12:01:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 562deceb-3509-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 12:01:10 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 6/6] x86: refactor macros in 'xen-mca.h' to address MISRA C:2012 Rule 5.3 In-Reply-To: References: <9d89a58ef016d96da7c3f329fb367f99d169cae6.1691162261.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <1f286a7219521052198c9cdadf400fda@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:31, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> The macros defined 'xen/include/public/arch-x86/xen-mca.h' have >> needless >> underscore prefixes for parameter names and variable names that cause >> shadowing with e.g. the variable 'i' in function 'mce_action'. >> Therefore, the renaming aims to resolve present shadowing issues and >> lessen the probability of future ones. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini > > I'm okay with the code adjustments here, but I'm afraid I don't follow > the description: How is shadowing of "i" connected to the use of > leading underscores in macro parameter names? I think you need to > separate the two aspects in the wording. > The shadowing remark is tied to the second part of the sentence, but I'll try to make that clearer in v2. >> --- a/xen/include/public/arch-x86/xen-mca.h >> +++ b/xen/include/public/arch-x86/xen-mca.h >> @@ -280,39 +280,39 @@ DEFINE_XEN_GUEST_HANDLE(xen_mc_logical_cpu_t); >> /* Prototype: >> * uint32_t x86_mcinfo_nentries(struct mc_info *mi); >> */ >> -#define x86_mcinfo_nentries(_mi) \ >> - (_mi)->mi_nentries >> +#define x86_mcinfo_nentries(mi) \ >> + (mi)->mi_nentries > > Isn't there another rule demanding parenthization of the whole > construct? If so, adding the then-missing parentheses right here would > be quite desirable. (Personally I'm happy about them not being there on > suffix expressions, as kind of an exception to the general rule.) > If you're referring to Rule 20.7 then it does not require the whole expression to be enclosed in parentheses, as it's concerned with macro parameters (their full expansion must parenthesize arguments at some point, to prevent wrong evaluations due to operator precedence). >> - if (_mi == NULL) break; \ >> - _mic = x86_mcinfo_first(_mi); \ >> - for (i = 0; i < x86_mcinfo_nentries(_mi); i++) { \ >> - if (_mic->type == (_type)) { \ >> - found = 1; \ >> + found_ = 0; \ >> + (ret) = NULL; \ >> + if (mi == NULL) break; \ > > The lack of parentheses here definitely wants dealing with right away. > > Jan Good catch -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:01:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:01:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577961.905111 (Exim 4.92) (envelope-from ) id 1qSx3W-00077E-UI; Mon, 07 Aug 2023 10:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577961.905111; Mon, 07 Aug 2023 10:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx3W-000777-QJ; Mon, 07 Aug 2023 10:01:42 +0000 Received: by outflank-mailman (input) for mailman id 577961; Mon, 07 Aug 2023 10:01:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx3U-0006w0-W9 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:01:41 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 660a27c2-3509-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 12:01:39 +0200 (CEST) Received: from mail-dm6nam11lp2173.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 06:01:31 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5373.namprd03.prod.outlook.com (2603:10b6:208:19f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 10:01:29 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 10:01:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 660a27c2-3509-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691402499; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=WOuAeoJ6YIbTezNJulDubATjKQvv0w33xCWZEUkTM4A=; b=Ejm8aJXqbEdMMNGZw/+CFyVDfC9rcmuinaq7AdQW2kkfuoeskuVegOxH pDiQOacpWKy7PXkqWs/79m7WjVoOE/U07ku8jjWK5Ja5KuHAFAXqNwQbD cCgnTTibGiY6ArVFw+iuiGo6Yk+aB0Xei4kA1FVoqA1C32rnjJf+b0nKm Y=; X-IronPort-RemoteIP: 104.47.57.173 X-IronPort-MID: 121351095 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A0yNSKvl2qYJNIYX2cWYKTMSRefnVLRfMUV32f8akzHdYApBsoF/q tZmKWyGMv/cNmv3edx/Ydizp0sCsZDcy4BlHgc6rn0xFnhD+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5A+GySFOZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwcmk0Piim1vOKwKOWbq53t956IczFI9ZK0p1g5Wmx4fcOZ7nmGvyPyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/60b4G9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTir6U32QXCmwT/DjUcSXyG/9qlk3eBBeNHL 2tK3HFyl689oRnDot7VGkfQTGS/lgUdXt1WO+w89gCWy6DQ7hqZB24LVTpIYpots8pebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsTwEI/t3iq4EblQ/UQ5BoF6vdpsLxMSH9x XaNtidWr7Aal8sCzai41VHBnTO3p5LNQxI15wPYRWas5EVyY4vNWmCzwV3S7PIFIIPHSFCE5 SEAg5LHs7tICoyRniuQRulLBKuu+/uOLDzbhxhoAoUl8DOuvXWkeOi8/Q1DGaugCe5cEReBX aMZkVo5CEN7VJdyUZJKXg== IronPort-HdrOrdr: A9a23:V8tKraCDoGFJ42XlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-Talos-CUID: 9a23:4wMrY26IhrMXYtt1mNssrhctSvgAI2zhzGb9BwijOHwwRbi7VgrF X-Talos-MUID: 9a23:bhAykAtoYNjaZeoZyM2nji1FCZlL/72XNx48iZEh5e/faRZ3NGLI X-IronPort-AV: E=Sophos;i="6.01,261,1684814400"; d="scan'208";a="121351095" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P3DWacrXDcdaygw0eRBcQurR0Ar6xaOP0V5KiQpSW6TM6/qMU8lAwcZGgX2STUSvvP2O0azHjCHDOB35ZKKMpo06yc91E0jzPnmXoa0TbhcXPGXVRFBsEnEmH+mF7UurFT+kmCTSQITJ3UHls4hUQDWx9G5NbM7CvEOyDBsBMARwHinJfIqoSq2K+nYr87f3RS603Q8mhxyDonpl6VL4CkA9ppjZkZcbTuggNG7hR+OxI630aPFcvXDUujMHaQXeHsPvAvQKxbCIcq5OHwgrv4XWtkS1i0glxCxE9FXD/rmabZ0eiJ8wfKZLBIIJgyN915m7mjF1FXvE2nPDtOP5+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e10eSy39/Azale1Jz+5xNO8QXko76iTOBQhrrYFt31I=; b=iF4bFeKyfwrDpjLJdei8Kz7zCz633Fs5+cZOKyq48bjeLoy3aQSpjQlNmOgFHX7PrxgQnzDgOx71DYpfxxGdJ0R8KLWZ6M8riDkiCNLX7mTYkjYttfI0zkfdbEIJIv2+S8dwpJW5Qqw2F5i920zAUjmgRTdbCV7ON3DXzveeKrt8YbQp/LnDi8zvryBTYMVej83E3m+bl8X+cXxFXQKbUKFfYmORyTLi1lsnP9rcx6BCFvht9NIcRRslc+zeQOqsFrMZGLoiWFlztYRwA+jCWtnUQ3hcZsSlURht93s7J4XioIZ+7z+kWWkaWNBmKpU/t5uhZVhN1XOVo8LVc6ymXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e10eSy39/Azale1Jz+5xNO8QXko76iTOBQhrrYFt31I=; b=X2CivVSHjRF4sdmFCkgVkzxXvAvfNweQ+JwmRnvOCqMfIvQ5XW+kdLnjyt1q45WC+U1f5mrdsKpkYIGYgzvy6AQq02GRj8Tn0/dUciiU6Kw9hmMOheeK5zJiKrQt5ziUmJ+7EHXu9xxkv03xBHB1wpDiqYVxSln8yc6SdcW6Ol8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 7 Aug 2023 11:01:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-GB To: Simon Gaiser , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> In-Reply-To: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0340.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5373:EE_ X-MS-Office365-Filtering-Correlation-Id: 870f6993-478c-4ab3-a0f5-08db972d4497 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r1G4+Qq939jNS6KjN1n4IRTRGosd6/2b0upfArBjCwzA9swREgKeRN44Iu13r4rhR8D0yZBOveSi5MzS+qcJbN0eMF/aHtw1wqO4m1N+eD9hpc1jPwsTbLOAfb+OfFsMiA78fBr/JTbdOUo7kspERhtSL+tDIyEBisT4OSVHupv/w07XxcEao+c3X2URnS6R1dJIKsvIcKTTjKwM1Ttqbs2HL81IvEspoZ9SfRTAPGiOph8RV0IBAAskcOloWmIsyv7txtb97lWYjFG37+H/gASKI4MpiWJm+q2C+FdYhWgmDU95bTuLSEXNhIEVfI1blXoTpSrAcF3NTMsOjmwF8xbWsMqZ2R9+FTCg2Z8s9XSTYUYTTkR6v8+Q/IesIbtg6xJbF690eiF4x9EM+0ekkavV7zpUlcoXQ03sAuWIzmT+FVPvBI7T/a8ovdCUt4SrmGrvNxsOSTp7RAtbVbsuxzUrir+mJnrz4+V3y1vVL7KHXQCj1o6/+7BQ7zKaTnWtFfbbDo1hAgxH2sDG9qeOBleN7VpqxCeEKARgfCAUWeDccqgDywAmbN0MNFc+mzEPzyYyCOU27pyOVNJywdhijCE2ht3ij0E/g3Axmooo+wkj9+jzHsFweOInW2FRrcgFOgMQdUQWs458DaJlptRP2w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(2616005)(36756003)(966005)(6512007)(4326008)(316002)(86362001)(478600001)(54906003)(38100700002)(6666004)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(82960400001)(41300700001)(26005)(8676002)(8936002)(2906002)(83380400001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGZSUzJTZzE3U1JHR2FTRlJZVmVlNWcxeTRUL2k4d25PcEUrOEpiWVliVnE0?= =?utf-8?B?bjd6WWlRRUJSZjVScGF3MVdGSnJ4elZ4K2NtT2RReHhSaGtaYlRFZThPRjQ5?= =?utf-8?B?WVMxRlZna1pSbGhwRnpXbFV1S1N4eXNjMDNYRzJwblhCbkVtbUpzM0sxM2VC?= =?utf-8?B?TzNBMlpsaG9CQTdXMkNnem1ncFdKWkZQb0EvVkN2SXBXRTloWDhKSUZlZUli?= =?utf-8?B?T2o3TVcwOHQ3eWcra2xXQ0poYk5TWE1nNEhwVTZvKytFNUFDRmY4bkhDT2hR?= =?utf-8?B?Yk1aWEdLdzRCODFUaTB3N0FWWER0Z082QmxEWXZIOCtIUHJzTDNGVFVMdmgz?= =?utf-8?B?MFp1L0dEU290UkdwYUY1YUVtZWtQaVdLd0NFZFp4czFObFF5QzgyVlpoOWU2?= =?utf-8?B?SGUvVTY1ek9CMmN3ekI5eXZuVW9tV1p1R1JEeWFKSGtUaFA0dUhpRm41bnJO?= =?utf-8?B?WHNvTjQrOGtpN1V6VXR0QkVZdTVGSUx3cXlvNFpUUTVjcEIxd0RUVGg3UWQ5?= =?utf-8?B?SEFTWEhUdHc3Z1lTeXc2M2ZwOVdmRStQMlFLVGlscHE4WGZnZUJDblZRaXZG?= =?utf-8?B?a21rZXVZdU9Tb1dOQTFYRmd3UlhWdDdYZkpmd0wzbS82STloYjQ1aW9lTEZr?= =?utf-8?B?QUx5eUNnTnhWalI1bWtqNzNWVmFuQ0U3TTVBRUFhR1l2UjNWdDZNbWFRVC9t?= =?utf-8?B?MGNibG8yelJHUXFBOWpqR0s3MWpvTGRNdnNXOHJndDBWdjJqT1BlUkdlWGdD?= =?utf-8?B?bkI3S0g3bUFtSC9lcWpVc2tUYkVqM0ZrTlZuSjE0dmpIQW1KVFduYnRVTkZM?= =?utf-8?B?UW9yMjRISW8yZXJOSFBFRUpuOENnYmFscWY3emZaaW1lM1Y2T2ZDZ1BMb0RO?= =?utf-8?B?L2duWmxObDJXLzNtUStIVDNQMkpUZk1xVWszdUhVM0dEdUovaE9NcjBHNmU4?= =?utf-8?B?b2dmRzRqajJ4ZzBLdmZWaXptci90OTdqZVJtZkJxek9iUm14ZnVEdGJ1am1J?= =?utf-8?B?YTdyVjU3akFveGFXSVFCTE92WFc1VUN3MTNleUw1WmFwYXhwVjQ3bGJZbW1S?= =?utf-8?B?WmlUKy8zUkZTRHN0TndGMkJEMm56WDZuQkdYUkZyZ2FueXFWR3Q0azB2UzBz?= =?utf-8?B?RDlxU0dLZjRVazl3UlVyK1dyVEtPbEtmTlhiK1lERVlXdnY3OUNlYjBlcmZT?= =?utf-8?B?ZDRaSXdlZmpOeFFuZmplQkpJOUVhTEN1ZFo3S1UxL0dhM1cyY0VTbFVnMGZ1?= =?utf-8?B?ejBzMVAvdDJ4SndqNGpVZnB3TEhCN3E5eWxscSs0VVMxVkpOUUNXMWRFNGVl?= =?utf-8?B?VzREa2hZQlluczBZSXdNTXNFVFlZZy9lc1RwSS9Ja2lIQjh4UXRyblROSko4?= =?utf-8?B?Kzd5M0x4S096ZlZoeGhDcHFHMFhXQm1OQzF2L3RyODB3VlAyYVgwdmdjbU9k?= =?utf-8?B?OWdlaVVHS0QvamU4VGovYzJmYS9uOU1aRVBwTlFXL3Q3QmRzOEhkN0tJVHR0?= =?utf-8?B?d3BEelNzLzVzS3pBU2lGaElQUytrK0NUUlo4ZWhIV0VyV0dlcTdJOWtseEJv?= =?utf-8?B?VFYwNDI2dHhEclVrUmRwcmdDWG42dktEV0piUGpzbjZjR0R2QUFRTnp2dDl0?= =?utf-8?B?dWJNSVR2MlFpbkU5Sk93QWdYTGh5ZmxRVnlYajY0aVFncnhoekRweUZqdzQv?= =?utf-8?B?dWRYMEV0RCtDa3hYNWRwRXR2YzJwMHRxclNXbkhPZ2NwL3lZNmR3bnAvSFhF?= =?utf-8?B?YUVlR1M1elJKcHNwQ2hXYmZ1ZmVJZDczYmtmTEUvc1R1WmkrSXF3ZWFRM1Vq?= =?utf-8?B?VEwvN3VMNHg0ZzRkajJsSDArdjRVVkh6dG1SNi82b0RzWk1SWk9YSUdNTVVP?= =?utf-8?B?cTkwN2ZidzFxQWNMUVNNdkQ1cEM5Q2Z3Y05mWXQ5YWNXR29Ob1FiaGdEcmtD?= =?utf-8?B?SjhHZVB0cFZRMXE3d0MyQmFBVjErTFdXb1E3RER2dTZodzgwaGhmVnNXTU5i?= =?utf-8?B?bGo3dFJyS3podzVsRmhpbzV1VGd5UzIzR29MUUdJNWViMUJWdEJvVkRsQkxD?= =?utf-8?B?QkNoaVl0Q0lROWU3enQ3SFdtcEFVZHoxcmFzZHYyVzNVSmI0aUNlbnFCU2lP?= =?utf-8?B?RUhOMk1tYmw0RGdtYWFDZ010dDF2Nk5QVXEwajNSTFFGVjhnOE5WTGZiMHZz?= =?utf-8?B?MkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oQdFGtUGJGBZ1XD9iW7IK2zL0ugW6Mh7fw9tiLjtw/BtGCxKLSH2x+zKO9PsBDlKEqesRxZNFEEzy72X5iOnor+SOyUZlAUgjnq2Zyj1FIy3gtCwILrHQ2ONB3pf3NxxPfRaxzs0QDVuK+pmLVWAe+N8Gv3jF8UIXq7tycVHsOlGmMS5t3eR39H3OnEDkY1wCBModV/oaC3I7y2pktH43E/zAJpae72r9FvGlPb3pFM43DVH0wn5WhqMsO0Su+th8U6XFpOGAr/kI8uG0/+tUJmLepovIAFOrnLkqQZ8idDU6+OnnZqiwc+1Db+ReGE8ttrtEQNOe2RFsAdcRC+VIJ4kTobD3EhaVoImOEbB66/E52mJr6Jkd6Dbb8U7qHjJ99zvdmNHOZ7o/u0QkZJ7p9EmTxvjQ+rTROmZYxcvH2fGlHyKCZT+UGYDyY4auXXKYs8QIaeM8mxfokSioy2xevVRGnbqUobIQA2MNRq82udFi5GGQiYN/F0xbYrL2gy4pZQIHUe8bP4bGtR+AmHR9L1TlUYRAl/Uag7Cr8OmzXp+pChRseTb1I8HHAUcRH8ME2/HqDPx02fuSk5oVl291BSrfKlsHgZpEnq+AqQnHb6aePNF6+rJw6JLa0+ruG+7uqcgWsszrDJLd6hrI2d4vqvX870EDG80IUsD7zG2KQcAzYIK9YWPJ9Se3beKgs7RJuSvLh7WB2fuLtjldUbXE586+gXkWslmzclRiEfxMy7Z6NSnH8AhPe03kVntsbidcbQWbNBZQh8mJTv+XkCnunPGup+LqstMYAu3r/GRrLnAOGqovtnHjIxw0DRLIFfwlZ3BskdgoUcXRE8kmI5NuSNbTBfKQEFf8DjhVf6Y9D8Tw4XqtBrR/cYvBU+gs8cu X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 870f6993-478c-4ab3-a0f5-08db972d4497 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 10:01:28.6689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZBO8osWYzpZvbrRdPtcGqubqoOI56cWouFFbpUBKxrX//8L/RLiO5Pex2YP5dGRfg5x+2V9DS8pTX0Tva1v1ykZRIB0NuY+MaOFmFn6xFug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5373 On 07/08/2023 10:38 am, Simon Gaiser wrote: > It seems some firmwares put dummy entries in the ACPI MADT table for non > existing processors. On my NUC11TNHi5 those have the invalid APIC ID > 0xff. Linux already has code to handle those cases both in > acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the > same check to Xen. > > Note that on some older (2nd gen Core i) laptop of mine I also saw dummy > entries with a valid APIC ID. Linux would still ignore those because > they have !ACPI_MADT_ENABLED && !ACPI_MADT_ONLINE_CAPABLE. But in Xen > this check is only active for madt_revision >= 5. But since this version > check seems to be intentionally I leave that alone. I recall there being a discussion over this, ultimately with the version check being removed.  IIRC it was a defacto standard used for a long time prior to actually getting written into the ACPI spec, so does exist in practice in older MADTs. Otherwise LGTM.  I'd suggest dropping this paragraph as it's not related to the change.  It will also help if we do decide to follow up and drop the MADT version check. > > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f3bf1dbe64b62a2058dd1944c00990df203e8e7a # [1] > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=10daf10ab154e31237a8c07242be3063fb6a9bf4 # [2] https://git.kernel.org/torvalds/c/$SHA Somewhat less verbose. https://korg.docs.kernel.org/git-url-shorteners.html > Signed-off-by: Simon Gaiser > --- > xen/arch/x86/acpi/boot.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c > index 54b72d716b..4a62822fa9 100644 > --- a/xen/arch/x86/acpi/boot.c > +++ b/xen/arch/x86/acpi/boot.c > @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end) > if (BAD_MADT_ENTRY(processor, end)) > return -EINVAL; > > + /* Ignore entries with invalid apicid */ x2apic ID. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:04:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577972.905120 (Exim 4.92) (envelope-from ) id 1qSx6Z-0007ry-F4; Mon, 07 Aug 2023 10:04:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577972.905120; Mon, 07 Aug 2023 10:04:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx6Z-0007rr-CX; Mon, 07 Aug 2023 10:04:51 +0000 Received: by outflank-mailman (input) for mailman id 577972; Mon, 07 Aug 2023 10:04:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx6X-0007rl-KC for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:04:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20617.outbound.protection.outlook.com [2a01:111:f400:7e1b::617]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7a40692-3509-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 12:04:48 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GVXPR04MB9904.eurprd04.prod.outlook.com (2603:10a6:150:119::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 10:04:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 10:04:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7a40692-3509-11ee-b27d-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRG7fQYESY5XBw28X194BAEB5GIMEQIC55tVb8FQezjpN0fUMJ+2FH/s9TxgMmoTnvcSx9+fjPwCtIeYubpZxO7/v8UWzvbZ2gFfFnPO2MOY/t59FDPiy+aTlDOJXiVHXwPlgmLWwaqYhVlENfNL09lRiVgryhCwEYwNlUzUGr3GtwVvQe3w6ax9KIQPq9odaxQcUno2r2J//Z4bqnKeDEj/cxn3oZLfoRlWl8PuDZIYzqIMoBbT8oMryhVjvEHHyIGaRKarzyGrdFFtlKtUTVtAeJjeOJs8wxTqnspeNUXfgY5EUs/wR0YmLpC57WH0bxW7I6TDQdy9I7vzxUscow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AImSG46M5dVWVzPvxVp4rfrueGK4YHQjTUB4hPPXSU4=; b=mQ4VJItZLfItvrO2eMiWKtlLGsTbfupQCy8EAqmNzovwshUGeEyDw1fJtguBHe8nYIyx+k/rVmSHXyaQQ785KrogVbHbyUWAaPKKtd2tXAgvM4EE3cvUWBVPlkFPbscOkvbKbb7842JFS2ytE4QkLZfkbgoSioOhV/mPfb5GJ9vKTp7S119uhGoSRJJhceXABfTQ/x8RLRXhlniRC8ES6ZdLm7SNE8G9DAkhGlSVmrOZnKSwVHjnF1TYq20pe3XSCWuIaT/SR+Fgk7OGyGUymZkqM1f8lwOXNtYnzx0XjI8Ld1NVYIdDHV1pZWNikffWQb/W6j2akbYNJRv5vp2jRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AImSG46M5dVWVzPvxVp4rfrueGK4YHQjTUB4hPPXSU4=; b=UsOOWWSAeG3kAWol0THJnWXtYLEeDWRCHoHv+f4atYU1akS1QS0Z7yASrTAoPQ0tlIGYZ80WbG/wCmfFm8dcVRH3Z/XZEd1m3r+qaZf9UA/1eXf2O0/m6bIgrM1CWUuoPOfrcd+gL39ky7UyQC5sgpL6DVaKDtiTDUzRSLJrGgOsQ4E7sFsbnyF90XGxTywW/Z0C/hZWKI9azpWWCLGzEo7mpAi7ZJ/O2oFlrKfbwmsOvHnklZGqwAk3Eo95Me+7DTz1e9rbLo5LDo8+rS6sPyYmyFvPzZ78U16CknJBz8MjxtyJVHGwA5hu2c7sgl5gcXzEXhbjdxwSHA42ThtzqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5fedd7c0-862e-d7c6-431d-6478ae1960b9@suse.com> Date: Mon, 7 Aug 2023 12:04:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information Content-Language: en-US To: Simon Gaiser Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Liguori , xen-devel@lists.xenproject.org References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0188.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GVXPR04MB9904:EE_ X-MS-Office365-Filtering-Correlation-Id: fb72bac9-0802-4d31-8e25-08db972db93d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lJVzL77aZ9vWv3PjvtUGjldqI9IV1zblpKQXUUI4iZylkpW4P6WPqDdhiGf9VDvPRPYKWp+nFLqo3GzLpspOBqyLeBxPJS/d/QAsXrKoHBzQf5d6qT30x028qKwfZWNQT6wyK7SXdzdpBsauOup3sEJZcBB2m7tv2NPxi0ef8LM4X3ANcN0esRv+Azj/kMnQEaB67vnj+Ur2C4wr40eQFv0UAK90aCUyO8/VaPotVOFBuAtwXzwNhOr3P3MekiYjyiUqBHzpAtu8Oj85oCXkIFf4LZi6gEztXgNbNjMeMI8vkecc1Z6OZDb7jKjCPjlDkkXKmmw3nCrC5DwY9ZWl3YizAFjwdsaqh1IzJwdgW/JwSYcQ0wSTV+2pw6uz+iGcttHeRezCCBYZqLibwh7YryjPFZOLKujClUeqb2TVaW/48VXTV9bociy5UIpubati26HWVrVcrQqYAZL6xN2x3hZ5NyQPcymsSh52HnzFCC27fmYNnRCi2H2DLj5/3CuFPj6icJUOH+0DRqS/KviVFTUFOuinC3eBfqHPQqYYQYAb4brFecq5ilZuSkbp8MfLCWvLw1LyUxflipsxfCq1mx0A32XNFee7SbFSwpAD/S/uzvJFUceMkjAHRdIGLOIflQZQ5bBmTvZV1aPIR8gBRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(86362001)(6916009)(478600001)(54906003)(38100700002)(66946007)(6666004)(6486002)(66476007)(66556008)(31696002)(53546011)(6506007)(41300700001)(26005)(66574015)(8676002)(8936002)(2906002)(83380400001)(7416002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHluQ2RrUjhvcTZpVURRU1NYbEx2cDQvRi9zQ1pwK0lIR041ZzkxWjI4M2w4?= =?utf-8?B?ZmRMcFVrTWlneHlPemtGa25wYldUZVFWd25ndlN2UnU2MkZDQlhVSDEvQm01?= =?utf-8?B?MVdUUVNGclQwOVdiMDZjMnc5cEhqcFpBKzlnNTU2WG9LQ0YxVFZxOThBU0c2?= =?utf-8?B?akJBa1lCMXVQYUhJZmtOaEk4Y3dYaTdBYll1eVJkVXF0WXJHRmxrVWoxSXlS?= =?utf-8?B?TWhOcHhRamE3OHgyY1lEUjRRR2NVeGFGM0pkSDJmZmdMNmZUNHArSkcxb0tr?= =?utf-8?B?bnRmbnNMOGJVVU5xd09DSWxBdGdaa2RkZVVZS3Z0dk5aK2ZiUFowekpOVFpq?= =?utf-8?B?T0hWZ2x4c0M1S2JNZlAxdEhGZTJjUTFpcFh2L0V3S1hnM1EwMlNudWRRZWN1?= =?utf-8?B?Sk5JKzZFZXpjMFFRRHNVbjZxd0FxckJJak93R3J3eHpNaloyUmRldTVGendT?= =?utf-8?B?RHE3KzkwU1JrckRiWGV3N3RCTnBVbzRjNWR6R2lRb1hvZS9USnZ4WmdmVm9w?= =?utf-8?B?emFvVUxSK21ZMFVzZ2cxdUpyV0NRSThZTVZrVnlkTTF1NXhZelRjbDQzTHVl?= =?utf-8?B?ODV3TkJNMzZ2YnlHaVJzc01YbVVxUVdKRkxUNktYN29BbUxYOE05RnR6anNM?= =?utf-8?B?RkE1UUxOeTVYbFVUc2NuRDg4YmN5dFY4NWtMK2YyVnB5M1plaWtMOThHTkRB?= =?utf-8?B?SkwzSlpaS3JwbElZVlVIM0Q4OUl2cjRpUmZHYzBEUUhPS2RnblhSa1k4Tzly?= =?utf-8?B?bVpWZWIrZHBGSmJGMGZiaDlubWRZU2lBcTVKTmh3UEEwY1VUYng4amRFVit6?= =?utf-8?B?UXp0RDlIaXR2QktmMWprTlZlUy80QWFmUXBZNmttQWVkU0t2c1g2SGZiVnZV?= =?utf-8?B?ZFlWSzhKckZDNHA3dFA2czdSN0NTVEt4UGlZV1VLNFhidkw2ZmQ4dVdZTXRT?= =?utf-8?B?Ykl1QW1na2ZVY1BsYTFTT1FEdkUzWTBOWHZwUGV3YmNXN3Z2VWlLTEphcDBm?= =?utf-8?B?ZHh6MkxmMlFLWCtRQnhoYU0ySlZ2a21DWnFacjJUT2JSVUlFRC9WSFl2QjBs?= =?utf-8?B?NmE2bFlHeGc1OEtRRStmTGhQV21heDBheXNJV0ZwelQ4dmtzTmtoOUZOalhT?= =?utf-8?B?ZDFTaE5ib284eVYwMFlaM0VGandxaEpzbUthNzF4cm9mdGlXeEs2TzZvN0NE?= =?utf-8?B?K1lMemZXck1udHFWeHZBVEVqYUx3OGxqdTQ2OVpSWjBiSCs5NGJHUWZIWG9n?= =?utf-8?B?cGk4OVFuVHFwUGNrVTN5RGZZQVFlZkhHUEVkSnUvWnZMRHZEN3pxc25yM3Y1?= =?utf-8?B?WXV4TFcrVDUrRVp6UEpxWGFQZWJIMzV6aGdNT0EyRnQrcGFYcnpQcDZkSk1r?= =?utf-8?B?K2NSVW95WlBTai9QY05JMzB1NHk0SVl3QW9XK2ZMSEMvVE1BMlQ1eGJzNS9I?= =?utf-8?B?Y1MwdkhCOG0xdHcydExUejRzdWFGZTFZR3RPOVNOYXh0UFljTm5maEJHcHE3?= =?utf-8?B?OEQrRGZSM0g0ZTJoTGJzNWR4Tjc3SXN0R1c4ZnlSZk1kRnh4ZUFDbVdHT1Z1?= =?utf-8?B?ZndwNmxRVi9HWklQNFlkSWNrS0dOUlYrczE5MEN5YTh6cVNvUXllU3J0UDRT?= =?utf-8?B?NmxwNGVHbXNXWkY4NzFVRXc5MDdDUEVvUzl3MjNzdVVGcnFNcWxtY016eUo4?= =?utf-8?B?VjIwSnZ2Zzc5M1N5ZSt1eExJSlMzUDMrWkR6TGhPZnFRRzNxS1d2UE1tSUpx?= =?utf-8?B?bTlIVmlQU1FQNllJNHdMZDQ1ZFZCTkQ2REtUd0lKZHBQTlZNbE05NW5EeTlB?= =?utf-8?B?MmZxa2pUb0NGVTdTSWVlYUR3MytndldRMmNBaHFNN08xei93WHdObWdvd3ZE?= =?utf-8?B?M0NicWRFVlJhWWRjYkhLaVRjQUV5czJlL3J0aGdTQzhNYlI5S2xZczlQTjRa?= =?utf-8?B?UDREbkhJU3FzZmJzSWQvak9iMjJGeHl2OW5Ib1ZNQ2tObVFUMldqYjU4LzdR?= =?utf-8?B?V1dRMGtPYlloYkdzNUxCbzJvVWVmVEZyb2FKUWk4WmFGNHZYQVlIeHk0MVVI?= =?utf-8?B?emsrUGFGbFdpdzFWOUxEeDIzWmMrWG9EUGR6YmdKcThNOW1iVmNRaW43dUpT?= =?utf-8?Q?iip4L6xBdxWNDCZ3LXMh+Bj+K?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb72bac9-0802-4d31-8e25-08db972db93d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 10:04:44.1456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eAeNEsgZyoeGHTtBO6NBBuWvhcnSx00fZXigbMK6jsDGXBbVkNgKqwjX2ebDfI3xjjlJ3EEiVarUcXB2TRTizQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9904 On 07.08.2023 11:58, Simon Gaiser wrote: > Jan Beulich: >> On 07.08.2023 10:18, Simon Gaiser wrote: >>> Anthony Liguori: >>>> From: Jan H. Schönherr >>>> >>>> Intel says for CPUID leaf 0Bh: >>>> >>>> "Software must not use EBX[15:0] to enumerate processor >>>> topology of the system. This value in this field >>>> (EBX[15:0]) is only intended for display/diagnostic >>>> purposes. The actual number of logical processors >>>> available to BIOS/OS/Applications may be different from >>>> the value of EBX[15:0], depending on software and platform >>>> hardware configurations." >>>> >>>> And yet, we're using them to derive the number cores in a package >>>> and the number of siblings in a core. >>>> >>>> Derive the number of siblings and cores from EAX instead, which is >>>> intended for that. >>>> >>>> Signed-off-by: Jan H. Schönherr >>>> --- >>>> xen/arch/x86/cpu/common.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >>>> index e9588b3..22f392f 100644 >>>> --- a/xen/arch/x86/cpu/common.c >>>> +++ b/xen/arch/x86/cpu/common.c >>>> @@ -479,8 +479,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c) >>>> initial_apicid = edx; >>>> >>>> /* Populate HT related information from sub-leaf level 0 */ >>>> - core_level_siblings = c->x86_num_siblings = LEVEL_MAX_SIBLINGS(ebx); >>>> core_plus_mask_width = ht_mask_width = BITS_SHIFT_NEXT_LEVEL(eax); >>>> + core_level_siblings = c->x86_num_siblings = 1 << ht_mask_width; >>>> >>>> sub_index = 1; >>>> do { >>>> @@ -488,8 +488,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c) >>>> >>>> /* Check for the Core type in the implemented sub leaves */ >>>> if ( LEAFB_SUBTYPE(ecx) == CORE_TYPE ) { >>>> - core_level_siblings = LEVEL_MAX_SIBLINGS(ebx); >>>> core_plus_mask_width = BITS_SHIFT_NEXT_LEVEL(eax); >>>> + core_level_siblings = 1 << core_plus_mask_width; >>> >>> >>> On the i5-1135G7 (4 cores with each 2 threads) I'm currently testing on >>> I noticed that this changes leads to core_level_siblings == 16 and >>> therefore x86_max_cores == 8. If read from ebx like before this change >>> and what Linux is still doing [1] it reads core_level_siblings == 8 (as >>> expected?). >>> >>> What's the expected semantic here? If it's to derive the actual number >>> of siblings (and therefore cores) in a package as the commit message >>> suggest, the new code can't work even ignoring the example from my test >>> system. It will always produce powers of 2, so can't get it right on a >>> system with, say, 6 cores. >> >> The only use of the variable in question is in this statement: >> >> c->x86_max_cores = (core_level_siblings / c->x86_num_siblings); >> >> Note the "max" in the name. This is how many _could_ be there, not how >> many _are_ there, aiui. > > I'm indeed not quite sure on the intended semantic, hence the question > (although it's not clear to me what case that "could" would cover here). "Could" covers for a number of reasons why APIC IDs may not be contiguous. Consider a 6-code system: The APIC IDs need to cover for at least 8 there. > It doesn't have to be identical but Linux says for it's version of the > variable: > > The number of cores in a package. This information is retrieved via > CPUID. > > And if I look at it's usage in set_nr_sockets in Xen: > > nr_sockets = last_physid(phys_cpu_present_map) > / boot_cpu_data.x86_max_cores > / boot_cpu_data.x86_num_siblings + 1; This validly uses the field in the "max" sense, not in the "actual" one. > It seems to be also be used in this meaning. At least on my test system > I get last_physid == 7 (as I would have expected for 8 logical cpus). So > dividing this by the 4 (number of cores) and 2 (threads per core) is > what I think was intended here. Would you mind providing raw data from your system: Both the raw CPUID output for the leaf/leaves of interest here and the APIC IDs of all threads? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:06:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:06:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577976.905131 (Exim 4.92) (envelope-from ) id 1qSx83-0008Qm-Qx; Mon, 07 Aug 2023 10:06:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577976.905131; Mon, 07 Aug 2023 10:06:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx83-0008Qf-Nc; Mon, 07 Aug 2023 10:06:23 +0000 Received: by outflank-mailman (input) for mailman id 577976; Mon, 07 Aug 2023 10:06:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSx83-0008QZ-45 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:06:23 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0dbdab10-350a-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 12:06:20 +0200 (CEST) Received: from mail-mw2nam10lp2105.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.105]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 06:06:17 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5373.namprd03.prod.outlook.com (2603:10b6:208:19f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 10:06:15 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 10:06:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0dbdab10-350a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691402780; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=W+DEUMy/+zVWnbBSCdxkpH06J8q7LflxKMggumUMdpM=; b=fKOMvQzmpr4GramjFpV6XuilObkgtzVeO1wQxLRhnR3p520Vh316ZqVv xQqtBenASs9msIx8p/kDKeJukkQ1n+6t3K1EPcLLY695vEN7w+75k8j4b rto9DXoRGH9bVUW7gGfnVpE94kXIv4LWlIan2CDqDXA0VFbydCBdcDp9L A=; X-IronPort-RemoteIP: 104.47.55.105 X-IronPort-MID: 118584614 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:37v0EKoeosql6muRwoCsuGKZx1ReBmL6ZBIvgKrLsJaIsI4StFCzt garIBmPO6yKYmSmftkladmz9h9T7ZCDmNQ1TwU5rCxgRH9B9ZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOzydNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXADEEaAGprP6k/IO+YNdT3vgBIvX3O6pK7xmMzRmBZRonabbqZvySoPpnhnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeWraYKIEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6430AHNnzB75Bs+TEf4oKiVsVCCZddjD 2ES+g90gI0p3Rn+JjX6d1jiyJKehTYHWt9XFcU77h+M0ave5wuFBmkCQSVFYdZgv8gzLRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBsZQkP7sTnoYozpgnSVdslG6mw5vXqHRngz jbMqzIx750WhNQO3r+2/njGhSytvZnDSgMp5gTRUXmh5wk/b4mgD7FE8nDe5PdEaYOGFF+Iu SFcn9DEtbhTS5aQiCaKXeMBWqmz4OqIOyHdhlgpGIQ98zOq+DioeoU4DCxCGXqF+/0sIVfBC HI/cysIjHOPFBNGtZNKXr8= IronPort-HdrOrdr: A9a23:In3Xa6HGiWxckGW3pLqERceALOsnbusQ8zAXPo5KKCC9Ffbo8f xG/c5rsiMc7Qx6ZJhOo7290cW7LU80sKQFgrX409+ZLXXbUSiTXfxfBbKL+UyeJ8SGzJ8i6U 4DSchD4azLfDxHZJ3BkXCF+r8bqbHtzEnrv5a9854Kd25XgspbnmJE42igfHGebTM2dKYRJd 6z5tdnuzHlQngedMK9b0N1JdTrlpnklI/GfRVDPBIs6BCPgTS0gYSKaCSw71MxUy5v3bxnym TOkxX46qK/99m3xwTRzXW71eUkpPLRjvVCGe2RgYwuJjLghh3AXvUYZ5SOsCopoOam9VYtl8 OkmWZRA/hO X-Talos-CUID: =?us-ascii?q?9a23=3A2GQ49Gk9RHuuwvJX9G+CqxaEpk7XOXzUymb6CFO?= =?us-ascii?q?qNVdsYoOqEWOy9p94lOM7zg=3D=3D?= X-Talos-MUID: 9a23:5ZqnpwTFHB8GMgOCRXT1mHJjZetT/ZiQDXwpvJMGnpOpEDdZbmI= X-IronPort-AV: E=Sophos;i="6.01,261,1684814400"; d="scan'208";a="118584614" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPCiNR8Tn0D0D+9WSXr3AmbBD0b2lMWf9aZwt3gBo5YcYSUV9I91eDNCS2Fo089eM+I2cJ4x9lyyGTebsERKEIVVjZPPDeVIzWp3GwErpMGFB1q9o2w0vhedNQmz+2CVCemKsIoGvIjY0EYP2IKbysJ8Ek8fhkZQXOxv3SDCF5gZT5PxbJylhaca/k8KRfGDjs3+ymEB+rbJYwUGc48I9qhthYoUcRSi7CiQUgBDcn1XKf1nq9rTpiwjOH5g3xR9v4WCePysPKHWJqHjNqWNFba0/YH66ptjozBLvVZnmS3Eclw82Xzv3NwX/26HcwKiaqgICIr9d+HprYbJg9swxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Y8nVWJdUc/lyHm/tgeOSEdjT7RtdH9eMDYPuqSa3rE=; b=kasr89fgBSzQyHpKIsQhLuqt1+6U9wvUQlXWKMhWudNyLwHYsfOdTwaInZzsKrtmakGuhgAEp8nedGwXQcOUskTCTNyJcQPlP8WHutakh7CGw3tjltYSy912hgwK+T+lUi5xsQOHQfVf2VStPeRjh5tTeC3AYpVs5pclS5uHzqLbfbSIafJh3ccFkaZHoSSOxYVH3Bh3HyUQ14mFIo8cRHQqFagh68SndpPCAX8861A3SSMzWnLTK/hfobQsA6y19KA2GbZtBlXkF7g8vg6+TKRKpJi3+RSGPvQpAjUd4DVo5iguoFC+B3SbmD5gMwVxcpRtgmDpF5LSyah1wUtmiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Y8nVWJdUc/lyHm/tgeOSEdjT7RtdH9eMDYPuqSa3rE=; b=pX9psLePvylfnLfxiOpsb9/O650Ev8UgJdCUA/FF0ynlACiL0LjdX7ZsPcQ01xgFhDfWdJL+j33FBDV1f2T5cOhBLYIvCGG9ZdoZOu7tW1sLm9YRof2TfNG49Tuh4TEFExXK+wJOLfhfh9WqUntS+s/mmOi0Kqo3iOMrYpeSugw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Mon, 7 Aug 2023 11:06:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-GB From: Andrew Cooper To: Simon Gaiser , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0048.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5373:EE_ X-MS-Office365-Filtering-Correlation-Id: cc926c3a-9735-4992-4b1b-08db972def48 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tmzru0sk305pZeRVnMtMXuZBXkgxf0nDh2lLSnFfPt54mIONBa8eikQr5xE+FzYEHBMt+X+gvlO7e8TfTdZgxF3xL2x3BIpfqthTmrseoOAwssuLJG/jX9dCoEh9MhjgA+eeEPAx0Ekfgy6+RxYBWnCKLEdYso5ciipSaXQo4xl3rdhaqvsOCcD5vkinFJ2+iM1o51ZIcyqRoqaOkrJlqG+YtSv5GGYcnq7GkEFooZQSZU79E9KeHPwre0N/dcBhRkXWmX5lwALCm7vgXmnkIqtu86xG/SZvK7VXCsCUagodzc0kpTwwt7+nR305WiWsdCqPPoiv7HFF9AWGW6Wwpwcy0pAzxcmq292mTlW3JY/NDWcWcJ40XIINGjXrSdqd4psTaT5nKM/sH8n4Q4Gip2EdXQnpWv8OjIt+aoPXRpvFEfr3y17AxUjPa9XJtTf/2RhkWg/gjGAvObpJmphEE1gjpO3lKdjNgIYRP2y8txJLJWAPbBx0CM6Htn4VnEwv4hKClma7R2cYQrDrE4r4YOZOHE+5eALIMYHpFYq264sTGZySrEL3Dt9MlTymSTK+gVkaCt4eSRthisoZmZHCH8DWjgnP/Ea6pur5UHDX0LlZmwBqd/BqlmbmPNq6z1k7uPGLjgq8Uz8YtCi1gl20sg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(2616005)(36756003)(966005)(6512007)(4326008)(316002)(86362001)(478600001)(54906003)(38100700002)(6666004)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(82960400001)(41300700001)(26005)(8676002)(8936002)(2906002)(83380400001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEJNUnowb3oyVk1BZDVIbFBuRGFHaWcrVjhSdWhickJsbHFCaEpLK1ZqOWhC?= =?utf-8?B?Tld5aWIyV211TVdnQ2R2NnlkUjNEOE1VZEFGSGdyVnJpcExPUlB2TEpmZ0hr?= =?utf-8?B?b2xUVmpTb2dURE9sUGozdVRXSFZGQTY4c2FpSmZXdUh0L3JCUjRsTFlZczR6?= =?utf-8?B?M3dHRUVnY1kwVXhYODNVMmNJdGJtajBBM1NPdHVFWXJ0eFlJQ0Z0NTlHZEhV?= =?utf-8?B?T0pDSnFkZzlvMzZPbUh2TUt2M1lkd21uUXJKZDVUTHVnMzQ1N3ZlM3JPclN6?= =?utf-8?B?L2ZZSXcxRXE1R3JYRmtHdDNlWlVUWTJCVnJsai9WM1dtWTd6S3NCSUtwbFJC?= =?utf-8?B?bFNOS0pnRGtKZEQwYnppR29McVJzMEpzVmh3UUMycDcwanNFUTZCRnFIL2Jt?= =?utf-8?B?NjFVY1pXYk9PayszR3U5WDhOV3djbllFbjlRb2RVb0N1U1N3MmpMVTZSa3BN?= =?utf-8?B?MmVrTXdrWUdNVStiaHdvWlVLSDZzSlJtbE9IejZiWlpXRStOSUp0bjJyZjFL?= =?utf-8?B?clBMckxrelNGOFRRc3RtVm1ScVZrZklzYkFKczdNSXk4bmQvY0ZVYUppUk42?= =?utf-8?B?cjRmRU9iQUJBeUpic0l4WEVsb1Z5YXJ4MEhpbGM0ZEtlV3RUYS9UWDVXZmY1?= =?utf-8?B?LzgreXY2S045NHpWTTNtNHpnL0ZkRGxwSW95NlhUc3VDMjEzT09tbWpGK01j?= =?utf-8?B?U25jNkxLZFR4MjJpTDFyZC92ZDcwTUp5cVhLbDBqS2FLVGc3aG90QlRPc0xi?= =?utf-8?B?NStwZ1Rtb0FIbjZoN21vWnEyempBV2JEUG1ZMnJsbkhxZjFlQzlPV0tMRWJG?= =?utf-8?B?djArS2tYVGFYNWlhVGN5dDhHQ096VmRkQmRoOHNiZ0pkMmVLeEY3dmdtbWUy?= =?utf-8?B?WGxBbWxsOEZCRDRSM3NxekVoVEYvU1NySWVUR2xCcy9xcEhhZE1DeHVEL0Rp?= =?utf-8?B?SFRQK2JGYlQxWEtuYVlkZDdpOUlBekVjL0xlN0xVNzhoR1l1U0dtMzdLVU5S?= =?utf-8?B?UHhLM0JqUmFKeVVnMkdNbGRPbUNvVWk4RUtmMHRMY0FjRndtek5EVEZoVDRB?= =?utf-8?B?di9SMERtQlcvdGtEemdJNzVlSlAvRE11T0VrSWNqcG1adjlFTW1ZUWhON211?= =?utf-8?B?aFloNzRnOGdBR3Y4Si96WDA1dzBnUElRQ0s3QWZEWk54TmNXU2tOQWVGc1Nh?= =?utf-8?B?bFlXZjREWFh4NFZobmYyenlPQmpMOERlektrTUtENitxdzgvOC9hZ0pVZHZw?= =?utf-8?B?YWJNaGhVL2JhQUU3cEpnVkpMSk4rZjAxREZKZVVobmhZd2lXd21xOE50TC9h?= =?utf-8?B?K2xObDRjZVBDOU4zbWx0ZncwVWJ5bUgwaXNILzdOcmhLMWoraDNaYWdzcEpK?= =?utf-8?B?OHBMR3VmcVVDT29hNWR2VGRiaEEybzcybzRFRzRKTi9YSFJKVGRMRi9xUWlF?= =?utf-8?B?aGxyTGcwL29BQVFRaHhuR1VjVUlTTzlEMzBUWjlNelNYaGNnQVFFczVyK0ho?= =?utf-8?B?UURBbUo4WS9pdnQ3bkFSMUtGWUtoMVVRb2x3QVNqZGU1aS90TVFSVFJwVkdZ?= =?utf-8?B?UnA0TEtFa1g3b2JFVU92WHFhcTJaSUlQalROTStNVW9YRlVSY0wycml5cUhl?= =?utf-8?B?Z1B2cHJzSWRidWhhY3dGZmFXdEt3MDBhWHMvdFUrbVMxQkNyMDRPb3JXWFkx?= =?utf-8?B?aTQ3OU9INGRQdzJRMkI0QmVwV2ZNMVk5OVVvVXZHbklYbmdUeWljc3l3R2M4?= =?utf-8?B?ZDQ5TCtONlRFOEhWSWZtZjN3WkpnYUF5ZFVHTVVybklVRDl3QjRQRTBHMXJp?= =?utf-8?B?bTlPQ1NlZkVBT1c0SmZWSy90UW9sQUZGc0J6R2JueFY2L0pSOXRhaDJSTE9V?= =?utf-8?B?c1JJYm5LOUxST0VBZjFQZGxuQ3VNNzg0WWdib2czVjlvKzB2YjlnMHNqNjFB?= =?utf-8?B?aEhMdlVKU2p2ZGI0TGFsWk54RXd4V0V3cmFGVlhhWXlJQ0NuNXNPdHVCUW9U?= =?utf-8?B?bGVPNXdobjRhNWIvUWNoSnl5WnlGY3ZjZzR4Z0xybGYra0pxd3JrTnJMdkR4?= =?utf-8?B?bXlFTnU2dVh1ZUFBeVViemN0NDRZZ1ZESlhqSTQ3RlJuYVYveXluSDlQTmZY?= =?utf-8?B?YVhtNkpiNy9JTzV6UytMNUFYMmIwQXR6d2pJSE03b29BM0lmQ2JHTGg3bXpE?= =?utf-8?B?N1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eCg877mIBYUfAJMsVLy2FBYSrpHOeDH274MqF4XqBn5vmm58JNbRqXK8CMzdpyOQR5vmJKOxtsPeEnCfU7V77JwLGyOT9WCYHKxdK5b+l7999dgMK9Tz3iOQAZeiAX4VNfd41+0scDu2RVFxSCMPcHmTxcjT6LOISRKlrG5xbnjPo56SlC11fJxMRGl9Qyr1d9h1CATAoWO0Q4t+l+qB0wHOJhDix9peA9Yfk8x6GLqFjZjmNqSmCQZtCZ+Qur5nT04MZLaJEcYJ5tKAF87oUN+3jj74ZMOJaU0sXjpLxa1QZBO6IsNXXKZPEQxZNiqwbctC7HjP/2Saaba3yOS0z995ygROwsxB+NpXI2shMuPr2eRFrHVzTLcHIRlVT8WSohQQvcU1PWwFH8fzMXEMkCSP9tsRhkJCG/HLQ+Kql2KBXAZ9Suk6a+LoQqQyfoCDKfAH/bjPWKdRQIVb9gVjHCr7g4QpwsIXtDWUJPDzSIK1sXn0HOlODP+1AC2dlzRqroB7veiKibewkdsgJmQeZ+F5TzU/aKeCB/IvqbZCCmmh18B/kf6DuNesxwj1Z/OVbu+yXfN2QmRlVIdqy/ZqGORBU38ymrKM8dgUEkqYxuJjMRUBFyyFmeK6aqZj9u2WEE3aX13JiVwr/a1zt5VOHl1AsXcnZ/cYaBzGojHMJDNjTW2ntuF30PrfVkhUECLj2Ljkg1fkhKHAUKuJkudMMkRXc51RGsH6oIn9xo8JEp6r2HM7xYvxDwLEN3R4ZMV7hPRpC6yI2/uMYec1qeFd6HHzNn2f+yxkhvbFl/vNsCqRBTaRzgrM1bLxt8Fxs69wboeAe5IhSJL4yQTCNf1RA0rhAaC936OG7CYGO4kmrCmYV37hi0mGPo28PpaSIAHd X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc926c3a-9735-4992-4b1b-08db972def48 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 10:06:14.9245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oE1MCyzq1QtP1+VMjn5ckFyLxeEqtHqLVJ7ljjhhoJUk7A1SQPUtKtZXQ9IVWsncOlQ2S8+FVQdZXwDmiySkNtYiB5RdbU1/c62evGvmo0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5373 On 07/08/2023 11:01 am, Andrew Cooper wrote: > On 07/08/2023 10:38 am, Simon Gaiser wrote: >> It seems some firmwares put dummy entries in the ACPI MADT table for non >> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >> 0xff. Linux already has code to handle those cases both in >> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >> same check to Xen. >> >> Note that on some older (2nd gen Core i) laptop of mine I also saw dummy >> entries with a valid APIC ID. Linux would still ignore those because >> they have !ACPI_MADT_ENABLED && !ACPI_MADT_ONLINE_CAPABLE. But in Xen >> this check is only active for madt_revision >= 5. But since this version >> check seems to be intentionally I leave that alone. > I recall there being a discussion over this, ultimately with the version > check being removed.  IIRC it was a defacto standard used for a long > time prior to actually getting written into the ACPI spec, so does exist > in practice in older MADTs. > > Otherwise LGTM.  I'd suggest dropping this paragraph as it's not related > to the change.  It will also help if we do decide to follow up and drop > the MADT version check. > >> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f3bf1dbe64b62a2058dd1944c00990df203e8e7a # [1] >> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=10daf10ab154e31237a8c07242be3063fb6a9bf4 # [2] > https://git.kernel.org/torvalds/c/$SHA > > Somewhat less verbose. https://korg.docs.kernel.org/git-url-shorteners.html > >> Signed-off-by: Simon Gaiser >> --- >> xen/arch/x86/acpi/boot.c | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c >> index 54b72d716b..4a62822fa9 100644 >> --- a/xen/arch/x86/acpi/boot.c >> +++ b/xen/arch/x86/acpi/boot.c >> @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end) >> if (BAD_MADT_ENTRY(processor, end)) >> return -EINVAL; >> >> + /* Ignore entries with invalid apicid */ > x2apic ID. Oh, and I forgot to say.  I'm happy to fix all of this up on commit if you're happy. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:10:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:10:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577982.905141 (Exim 4.92) (envelope-from ) id 1qSxBy-0001V2-BL; Mon, 07 Aug 2023 10:10:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577982.905141; Mon, 07 Aug 2023 10:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxBy-0001Uv-7m; Mon, 07 Aug 2023 10:10:26 +0000 Received: by outflank-mailman (input) for mailman id 577982; Mon, 07 Aug 2023 10:10:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxBx-0001Up-11 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:10:25 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e7efde7-350a-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 12:10:23 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 06:10:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB5994.namprd03.prod.outlook.com (2603:10b6:408:133::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 10:10:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 10:10:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e7efde7-350a-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691403023; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=dxlPdX+hZUzoq/CyBw+dkz4W4owffyn2sdl5MoWepFI=; b=djkm2OSfP8eRcnBGsHOvjN33SRx/beDzp3tktsP0DMAOcnjaNrL0VXH0 8UZpOXu3Gt1w5K9/Nh6VvjG5VsKQ7k9jVGrg98K99yA/W/ipZyBqmw+zk rDDuej0/Qox8if0qc70Gdi2jWwqXG9Ep/87kh5MJ5CdvyEIwwGQXNl0I8 4=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 119135241 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LCZko6i36lCfX/9xb4yTKfiAX1619hEKZh0ujC45NGQN5FlHY01je htvXmrUOP2JMGChLY1/YISwp0gE6MfWyddkQAI9/io0Fykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT7AeAzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tREBQgARS6tp9mc74mhZrBjmuUiB/H0adZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGybLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTpr6U32gHKroAVID4YRGOqrqWasGSdVt5PK Fcv/wlt6pFnoSRHSfG4BXVUukWspR8ZXNx4Eusk6RqMwK7Z/waYAGcfSjdLLtchsaceTDgr2 UKOhdLBDDl9tvueTnf13qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adjdTvEDH1z jyipS03lbIVy8IGv4255lvHhD+qprDASwcn4QORUm/NxgZie6asYoW67l6d5vFFRK6cR0OEt WIJmOCf6v4PFpCHkCGRQOQLE6qt7vzDOzrZ6WODBLEk/jWpvnKmI4ZZ5WgnIF8za5lYPzj0f EXUpAVdoodJO2enZrN2ZIT3DNk2ya/nFpLuUfW8gsdyX6WdvTSvpElGDXN8FUi0+KTwucnT4 aumTPs= IronPort-HdrOrdr: A9a23:5NijJKu0jQn+k777rUAKDa5w7skCM4Mji2hC6mlwRA09TyX4rb HaoB1/73SbtN9/YhEdcK+7SdW9qB/nlKKdgrNhTotKIjOW2ldARbsKheHfKlbbak7DH4BmpM Jdm6MXMqyOMbAT5/yX3OHSeexO/DFJmprEuc7ui05ICSVWQ+VY6QF9YzzrYHGfhmN9dOQE/F 733Ls2m9JkE05nH/hTfUN1O9TrlpnwjZf7ZhxDLwc/gTP+9A+A2frBCh2F2RVbeC9OxLpKyx m5ryXJop+7tu29yFv632vehq4m/+fJ+594HcmRjcpQDCvqhh3AXvUGZ5Sy+Aotpf2p6hIRsP SkmWZZA+1Dr0nJe32zo1/W1xL+3C0I43vvoGXo+kfLkIjCXTcnDMgEuo5DaBve7CMbzatB7J 4= X-Talos-CUID: =?us-ascii?q?9a23=3AWUS7Wml/ZKpsgrWrZxq0nITI7uzXOSHw9Hr7HWG?= =?us-ascii?q?YMkxGc6e5EFCM2aJPq9U7zg=3D=3D?= X-Talos-MUID: 9a23:S6ZPOgr6UpiAAWNardsezxJsJf957PiNMmounJkWuNK/MA8zfA7I2Q== X-IronPort-AV: E=Sophos;i="6.01,261,1684814400"; d="scan'208";a="119135241" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MB4ot9rplJORzk290+lPZRlU2uTz3tcGzPP3CNjkmeVQ0GzTFMynOlTiD2ULMHg6Ox9mXcJSjKCdSmuJLbnJKMCeFn0ELBPL8DwZ2Gl8e+VE6DPaIbcrgafDLYQP70BE7tnph/JWAAyQ39EqFaq1rMHEc2Y748WEUFJZGZP5h9Q7Fkty391ArGfduf8Zh+gr/7peHEPHS/DGCyoNxeAsIr3ygjkFvX21C/OMSkwHPc8hXrjC1Dv5KiEmLYI7Y9aYQuBKBtxSA1xpIPpygEIF7stzWdpxsPc0nAaIJ1ueNXPuSCLKYVbZv7SmyB7tKmtJLihSlsohfGZmXDzboLSA0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=knZR3xja8bAEDmIUgLm4qlqxCYSBqGV8z2tSXrBwD+4=; b=AVfC7KHPg45HXRsXOrAg5JxnqO3/v52Qq5rm5DVcDhC3fhCD1mqk4sL6MQV5sKRQ7lo9TpUW3wbsQDhwrVrKE54DHelI4JGH1u3KsBd5ACKOlUzSaGnrVDtd8s6/6J/QmB8MuziPPcurHYjBwr6GXTZl/abWrdhzkoCiggfzWuNf8DvUbPNZBzbHNYW5py4ejw8VnsbL6caq1NvyzxCd9ke92KSY0PlsTZGVbIjE4CeIhZwK2rMQQ3u3ZlUAh2ZfdzSat93kVcgV6u7B0QiE973PfezEfe7PPNOg9Cp1ZoW4pMw4N5FvZREqsqjpoDL3eQ+Ct5H5JF6VxZL8cX2+Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=knZR3xja8bAEDmIUgLm4qlqxCYSBqGV8z2tSXrBwD+4=; b=DFoSmi6q8aRb107v+JjTkoqhZiF3JZb8Rb2g+2J23pEAic1yndCQ12P7BWC7RNE2rtKoYq+dOKFkZYqyhBLKjDj9s3XnNo+UL0QmY2MxMledVgsMHjYFPsAVJ/188vnmXIt4bzUgWI5bb2lx2SWdllnvVDxSstEtrQM1R/5Fr/Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <874de0fb-b3ca-3651-42db-75656838f2f2@citrix.com> Date: Mon, 7 Aug 2023 11:10:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information Content-Language: en-GB To: Simon Gaiser , Anthony Liguori , xen-devel@lists.xenproject.org Cc: Wei Liu , KarimAllah Ahmed , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0405.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB5994:EE_ X-MS-Office365-Filtering-Correlation-Id: dd55767c-5ba5-4834-1f26-08db972e7fe8 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6hqc56oWg1pDeU27HJSh0fA0hQ0ZYPJrgFKOixoZcf+paRKMfSxSH43/U5f9oFL/fEyScCMPL+PqsqPqbsrSTyMDcolfaLBdbtjWALXAT0WW/8nO2QF0F5y4KTLH9ibHBFn5ShbX7aGQRx4jbdtJfpjUA9Y9AKtxkTSwsHC8e1TGdflUxm4so2QzA+rmDWOhwG5ovOX4gmN6ZxtbgIhgC18pbeLOtKFbZoUDBJUg6ijMXMiWgAWFxZowAPhfdsAur/qHtyjLPF8NyrE4ct/x10QmXxr7oLBueM60ofumDUiarPPQI56HLBxRymMdYXufcJGPJYvPdkgD7+IuNyTwvLY5olKHn6XrZ0sJHEXY052km8UQ6YAhdrmgTHxB8CKfO8RE8xBmgtNMyfzikD9zXHkmadbmz4sVhL/n0rw8inuJror062NWjWEfP/DkVpmgaLdyDJ57yk/S0b/9DigkYFjWKG0bubdA2Ee+95+1PHN+Mi8s91oemr3ZWP73jyWvYJ/CtoLboUKb2l0NElpPt3gPPaigexXPWAT1IHtua7QZduiQrrf47kkBtjlNOYYYgUyxTvtLZiDdFFwkdpCE7sFAGYoSqpiy1BeLOu7aALdOFHZs1LhmSsmMLK7Z01XRWnidDFXKjrDWT0rjO+siug== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(376002)(366004)(136003)(451199021)(186006)(1800799003)(2616005)(36756003)(966005)(6512007)(4326008)(316002)(86362001)(478600001)(54906003)(110136005)(38100700002)(66946007)(6666004)(6486002)(66476007)(66556008)(31696002)(53546011)(82960400001)(6506007)(41300700001)(26005)(66574015)(8676002)(8936002)(2906002)(83380400001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEZjMS9SbnlBSmpqV0Zta09mbmpUL01lV2RTZHlPdFVub05GTUNaSjJxbktD?= =?utf-8?B?OS9jeXdyRjZ5bEp4WmVka2hzaGlhSVlqRkV1bGsrMzl4L083SVRyYnA3dGpu?= =?utf-8?B?OERZOEFPRHVFZXJvRzc3NllVcGU4N2dMQ1JXNVRNSXE1c0RBTmlNYWtLTHhw?= =?utf-8?B?ZjhIK1ZSZVlJU2x5eE80OFh4am9FblRvRWlKY1BUTm8xS25vQndaS2lEdFJ4?= =?utf-8?B?YjVQbnA0akszNU5TWmtPNkZRWGJydHhXUklybmEyUVRVL2o3eDlzWjVnZ1M1?= =?utf-8?B?L3hUV2RtYW5QRm1VQVRDWmRGTVVnQzdmcHdUdHgrQUpKMFZGa2ZVNDR5ZmFa?= =?utf-8?B?Ky8wbmhBYk1NbUY0K2ttcmgweEhHbG0wU3pVZnppLzJFUkdOcFF6bm00NGtj?= =?utf-8?B?Sk9IVnJpQVZRcWUzU0tUSW11L3hHemxESW0rRkt1L1JCNVdqR0dmczRhMEcv?= =?utf-8?B?RTBwbWNCQnE2VjcwMUxDK0Vsc0o4VFI1ZlIrNkpDZHo1VlRCRjdmQ1RGRHZU?= =?utf-8?B?ajdzQjFZaUtER0w4WllFVVBwZnJNUmt5bVIrTHorQUdqY0FzUmluZFdIQW1H?= =?utf-8?B?RUZoSVVYSUU2RDQ2a1VQZ1R1K2Q0allzbXNLc2ExTEJYZFR6Q3hSMTBjM2d3?= =?utf-8?B?dkxacGRzVGZobnI3L2NNUXN0TG9oQmdPaTc1T3NETXdaRTlvcFhhVGVNdGJQ?= =?utf-8?B?NEVEZWp1OWZ0Ykd6QzR2aEZHMkJhaFFqQXFkOFh5Qlh6QkZ6TUhWNXJpVEVj?= =?utf-8?B?QXo4Nk8wc2dZdEtRdU1yaDFnVnNaeXF5K3hUamJxU25zNXdwcUpHM2E2d3J1?= =?utf-8?B?TnRROCtSR202N1YyNWlDdVlWeU9wbC9FRTlTMWVFbjJoM3FPRUlWQ2E4Ni9O?= =?utf-8?B?K3dZTzJ6ZjFGYmkycTFSTEhyUm82RVBwQ3lBSmx3U3FKZktiL0g2b0UzcEtu?= =?utf-8?B?aWtwNUNmRVpvdkxLdHVFamV5M0NGL2pZM0FRY2lHM0QxNjNYVWc3MTd4SFZE?= =?utf-8?B?UnBQN3dHbzNaRlZ6SnppQjZ1OEx2SjhTQzdsQ1NET2RSc1FQbDVWTWphVFlI?= =?utf-8?B?emhRN0VuRUdCTUdiUzR4VGJ3eHlpb0RSMHVJVUt0TGlWcitPZ0FnWHhTQS93?= =?utf-8?B?cWQ5TU5vaFNNNjJFQ0RNUjNXWmdJUjBocllCem1mdkduOEx3eUhNZU05cFV1?= =?utf-8?B?TFJLWDdPZTRNTmtYNXFMR1hZbGpKQnZLNy83a1YwejA0dVBTdVpwbGhMZ3ZW?= =?utf-8?B?a3htZ2Q3V3YyMG4yR2YwUDZBc2ZCZGVaRStVMW9Cb3N4TDErdGNPUmNBK3FN?= =?utf-8?B?ODh2c1JkK216WEtKL0lzSDhOWmxYWlRIdmRCbk5DSmgrOXFlVldEREVPVjVn?= =?utf-8?B?dGUyaGdYUnorQlpSVGtUSlNhWDZuM0hwUHZhN1cxWXhJT08wUmZULzBRZWpV?= =?utf-8?B?dHM3ekc3NzhrRS92ek4zRXFFYVBhUVhDNUdoQUV4T203V0NvU1Q0WDI5Z1lt?= =?utf-8?B?SzZiQWRiR2ZkUWdsZ0hTY0hHYUNoSi9GY3FwOW1hMTFkMWFTL29YdVowb0kw?= =?utf-8?B?U3VGUlR5cENmUjluTkNySWJYVGZKUTNNUGhRaUtwVm9DUGxrV0hseXhPdUMz?= =?utf-8?B?NTFEc0I2dTN5YUVBU1FpU2tlOUVrWW44Q3FGcW9wdDNiZDJYNWZ0b0NnYjh6?= =?utf-8?B?NmQ4NG9YSnFHYlVIVHpnNUlKcjZCN0UyZ0txL1dNZjBKeG9JZFpxVmFWbDBT?= =?utf-8?B?a1UrMlRJSnZ3ekNLYVB4MXcrOHJVa0ZlTENBZHNSSE5xbC9rRFVSaVg1YUtw?= =?utf-8?B?YWcxWlBLcnY5SGFuZmRNR1pyaHZtdGUxbzEyWmdsQ1hUVzhVaUl5ejMxV0Fa?= =?utf-8?B?UDBzU2FCanZjT0NzemQ3WmxLZ0VMdWVkVTJSQzNGS05vTi90R1Fxb1NxZkgz?= =?utf-8?B?ZDRwNTVFdDZvUzVHeVJ1d20weXVmazVIQmNnZ3ZCMjkrcXpLRXVBQ3MrU2Z1?= =?utf-8?B?VXpDRmN4UWtOdmFBRjB4eUxvUlJnV2ZLalJjb3ZSMkFRMGFZNXNuUVJhZFkv?= =?utf-8?B?amwvVndxY0VCSWhUWFQyeVcyRzRFSFpTdVVTOVZIWFQ5UFU0WFdnaGVKc3RG?= =?utf-8?B?TG0rSmFVaVlDQ2E1N2U3eHdzbVgwby83MVJtcWxPMEdrV3E4Ti9kQTBTcnZK?= =?utf-8?B?VkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vkgub4cOixtS3V4O68gPbwy/4puM5v4M+guTJMoc772nu3GTjm3twDTJVxplXgz8a67j/ZJiaJVqkIdzIpRLtpTCFKfstm3mWi6pKJ4wVy1RBGRMYgVbpY8XDN0ppMA6z+1bbk2aVUuidBAToFNdrZuUiQY0O5tPibK+ME5iGjfJyx4WE+Ydyqv8Z/pZ9qsoMq0FeRvF+Nf3KyUiwbsLlv2GNsF9OkBt1fYaCrie9L5aRuk88QVKo2JQxhD12zcQgiEPyims3YjjoO+Z57yzyleGdWTYGbVbPF5c1i0HzKHGOaaG/g4u4GhhFJgw+yPvvseg5G4k76Kckm+OSx7mn1cEeBldoWqvDPJp/G+bzE0kwgkC49rYh1ELGXiq1plz51oozLhk3S1JbzkFN7aXQ7Dg5Genay6qGl6eFy1i4f0jOeARpvuHLaASpi1sk/Y0F3XW7Mg3nbEP6/1uVvjD5VS3DQBB0P6uqFLdNvZcjgyy8bSBcdyrp9YCBwGnBlL1pPTbYg2ZUpLzR9U7PEHTeeLYwejuzU5t23uHe/B1ClU02/9/lK6CBhx/0ZfJby8bJ6R4yz2lrbS07bMih2KbeqatBbBXZhJySYvKRZuo4+sZRqfMP3NFnFchuwQmiJuRobKU6pYTeXA9cBSzm0j+1uCo7R9Mz3XoMYfBCGd9gnYrX/bG09di1EnaoAeCaSc9LkkzYrMCZSfngyhVgcZ6Zazb5D3xVhRICjylNKO/hrSUF9WpX94iAXv5AcZgfXjYSMAWHaMfmw+M+9OMWsrLtgSqONKojiLPgJhxFAG512rdjchKTxbs0s8d2ZVn4Yl2O0q7SqLeBnXPE2Slr6aGiEE42RDcGSAgx3j/nUgBF2Ia/muhde0DZeR99iLNmdQ6GuCRQO6Ayb0Tu0uYcGBf6ESZaZfXNDzCyKgzHCJoB+s= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd55767c-5ba5-4834-1f26-08db972e7fe8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 10:10:17.4388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZGdpjweQeW45AG8BEDLn4TI6Ms5ujw/c5cUKCq6qzclbdPDjNNtwep4LgqO7ntO5XERn3uXyjpCsLy21SRoelgRW7p+DMIuoLEzr6FrUwg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5994 On 07/08/2023 9:18 am, Simon Gaiser wrote: > Anthony Liguori: >> From: Jan H. Schönherr >> >> Intel says for CPUID leaf 0Bh: >> >> "Software must not use EBX[15:0] to enumerate processor >> topology of the system. This value in this field >> (EBX[15:0]) is only intended for display/diagnostic >> purposes. The actual number of logical processors >> available to BIOS/OS/Applications may be different from >> the value of EBX[15:0], depending on software and platform >> hardware configurations." >> >> And yet, we're using them to derive the number cores in a package >> and the number of siblings in a core. >> >> Derive the number of siblings and cores from EAX instead, which is >> intended for that. >> >> Signed-off-by: Jan H. Schönherr >> --- >> xen/arch/x86/cpu/common.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >> index e9588b3..22f392f 100644 >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -479,8 +479,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c) >> initial_apicid = edx; >> >> /* Populate HT related information from sub-leaf level 0 */ >> - core_level_siblings = c->x86_num_siblings = LEVEL_MAX_SIBLINGS(ebx); >> core_plus_mask_width = ht_mask_width = BITS_SHIFT_NEXT_LEVEL(eax); >> + core_level_siblings = c->x86_num_siblings = 1 << ht_mask_width; >> >> sub_index = 1; >> do { >> @@ -488,8 +488,8 @@ void detect_extended_topology(struct cpuinfo_x86 *c) >> >> /* Check for the Core type in the implemented sub leaves */ >> if ( LEAFB_SUBTYPE(ecx) == CORE_TYPE ) { >> - core_level_siblings = LEVEL_MAX_SIBLINGS(ebx); >> core_plus_mask_width = BITS_SHIFT_NEXT_LEVEL(eax); >> + core_level_siblings = 1 << core_plus_mask_width; > > On the i5-1135G7 (4 cores with each 2 threads) I'm currently testing on > I noticed that this changes leads to core_level_siblings == 16 and > therefore x86_max_cores == 8. If read from ebx like before this change > and what Linux is still doing [1] it reads core_level_siblings == 8 (as > expected?). > > What's the expected semantic here? If it's to derive the actual number > of siblings (and therefore cores) in a package as the commit message > suggest, the new code can't work even ignoring the example from my test > system. It will always produce powers of 2, so can't get it right on a > system with, say, 6 cores. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/kernel/cpu/topology.c?h=v6.4#n126 Topology is broken in many subtle ways, including bits Xen inherited from Linux. As it happens, Thomas is working on the Linux side right now, and it's been quite an effort... https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git/log/?h=x86/topo-full In some copious free time I'll be ste^W borrowing this.  It comes with a negative diffstat too. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:13:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577987.905150 (Exim 4.92) (envelope-from ) id 1qSxEy-000287-SE; Mon, 07 Aug 2023 10:13:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577987.905150; Mon, 07 Aug 2023 10:13:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxEy-000280-PM; Mon, 07 Aug 2023 10:13:32 +0000 Received: by outflank-mailman (input) for mailman id 577987; Mon, 07 Aug 2023 10:13:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxEx-00027u-PZ for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:13:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060a.outbound.protection.outlook.com [2a01:111:f400:7eaf::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e2800eb-350b-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 12:13:29 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBAPR04MB7304.eurprd04.prod.outlook.com (2603:10a6:10:1ab::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 10:13:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 10:13:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e2800eb-350b-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J2WVDbHpNT9nPkkerPnwGeepGx49zwJv3qm7vdhHAmokvUuAxKmXXKMDS0cSvrMASfMLBXAifMGk0K0Pj/Rw6POU1v8RuuzOsMaw6Bmfb5teuaYNySH4k0cV7oJ2iwC+desrcn+r57MAIAwZqk0Fbmd8Hd2UX6tFz4IZVq7QxhbH8QRWfV/JScJKmZIBG3uYQ2sL53YQB47PrbuSamR0AscS7YheNH/h1J9UN2Lmd2KZH+zOfB6ZcTgFdsppbisWVEmXFekIyGWAti6YH0Y1jz2RtM52F555c8EApjTiZk5Z00FmkWZTxjUB+BqbiucUuaCPCkIYU3/Ro7ThIoaI3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1TL3SuqiL/U8QplvnRFiosj3Muf1Pmyzyij/ftdbvSw=; b=L8naNky6YqL9QZFxzgvwVdfqQklCn4I/k/TTSVoiZoJTWz8VXY5lvIS+Qy+i1oIeLNv1q9Gd0+cowvGu7aGtNkFo9SElHVjaZEmmzo6RydpbP/aVomg8yZ/OsaD9pPZJWlSwnWIDWWx8Obrf3DHk4Bj/zXKo9Whyc9mY8Wsjj9gW6weKQht03sDVLXptdg2CNWjluHnL4DaRYwjwmHsBbIiJk1NcX1Al4pL1N9hTcfihOiCzvDH6h1hLw4S71jSWOIYL2fFC15W2yHokqPZQjn0JFm6btmrjC8ZlDqCbGQO2XTVNBD/UrMrIKu/G/x/oFsJFsRf8xEzQroqW4tuwvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1TL3SuqiL/U8QplvnRFiosj3Muf1Pmyzyij/ftdbvSw=; b=iDx7yy+xrrQuDgW0UyC4xdS00Ryfm+R97s/7EPrVEYTCtDt89cEIr+TRZklGNrt4/18DcoBIzrUiGm2PKIx758rlyYnrTFSFulABl68HbxeOF25BgbiIMe9Yu3XJ/nSOS3qkzzho0qp4QLWksAZcVpvyafGC7f36IMBOKqxi4WJCxtHwMahdZUovkfcFDCXcBSCfCjUCqE1vx3dOaeO7yxP2X2k77hgV7G1/PIfuXRsHzP/Kzl3jCNrT9pqQzv24h8WTMuC6BZFQoamBOqEh5iGKIqVkstRX2sqgLjmQtj+kXW/jlQSgSxejJu+hh8R8N1VUU9tVxZIXVGMLYwsxDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> Date: Mon, 7 Aug 2023 12:13:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Simon Gaiser Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0023.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBAPR04MB7304:EE_ X-MS-Office365-Filtering-Correlation-Id: c0bdb0da-1217-4baf-05b3-08db972ef10c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hqFhU2MYNQDbLA7JiirX0bGulapNMLSLcXiDHw1BRtPQ955BYMQ4s/ejmnkhFhD/Z8r+DXRvISYrSDtuDqurYfwCtditIDHZqgkshINhxf/ayir66bOhJU9Fl0LbvvpS5zWzl5Pgc/jpGGO+Dq++Ns1mAx6ru/Z2pNzQCzEI3Aa+iZrygGN6g485//hOhwKpb4DOIaSY6Hz6UosmGP6NV48YGagTJrng28UwkntSbBV7225DgooidHzubEZ2Kd/+hnHOT2Anrux77F96zu4S/HeJkq9f61fKDHF0EyNiPMKprnLmbTYREa4P9gJECZiWaG5qC0uleSeHhF5wleSP9sn4mhmQqbJj/9MWw5ynysP9mnqevE2MrGG4B8E0n8LneDA+zIjX1Wdk22c/G93E5UMACJhn+mEUjPSfuPkGUth5+3ntr+WBQPHkdzVksSaugA+HlHHLg3f1PC23WQRHMlY5fA+ju4PAkf+TOFF4p1XGCvC03If4iIXJzCNr04eQWST3w1je5rAHJzGJZaBwHIg4rVuukPJljgtYi1+hf+K0FrFkGkfSBue/tuxdEPBdLqIoD65t2AiXusu1ySsqQWcL0eNPiLy7TrtfVWqS6iygXx2Uwe2Z/OKcFz4uxLSV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(376002)(366004)(39850400004)(136003)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(86362001)(6916009)(478600001)(54906003)(38100700002)(66946007)(6486002)(66476007)(66556008)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(84970400001)(8936002)(66899021)(2906002)(83380400001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1liKzFwU1lYb3V0eWRnaTB1enJNL2xqSEQvOHhUa1RPbG1EeDBwQU4vMnVE?= =?utf-8?B?bGNIbVIzcEp2MHVoeVg5MjY5cVJIK2tMUFMwc2RnTzJ6Ym1RYTJEQ2dsSzUw?= =?utf-8?B?T3pqWDBibHhrdGhYcWFtMmxkL3JvQTNxcTVlNTY0c0RmQnpZVWs0YkNTSzJ0?= =?utf-8?B?ZTJyUkRTekNEcHFmMjZFSnkrbGdYZGZNV3lZY2Z4bXA2RW9NTmQ1MTVMVDFR?= =?utf-8?B?RzNBU1k2YmQ1Ym5FOWN0MjZqb2t3Wk9MWU53a1ZPYk53T2E4TlNjcjJCUVNw?= =?utf-8?B?U2liTW12ZnM4U3daMHlBSFE5ZTVVckRSNm1MWHdwaVg2RDd6TWhhSnBJZVNs?= =?utf-8?B?NjRhL3JoQ3JTZlg2eG9GajV1QXM4ZzNoSmc1RjJoZWh3NUNIZFN1UzZtb3ZT?= =?utf-8?B?U2F6Uk9NRFhUa21BSm82YmU1ejgvejdKTEpscEJXbmxQUitFRGU2YjVaTklv?= =?utf-8?B?aGVDZkpXeXpQUTVpS25xOGo5WkZhR1diWW04RGVxSnZxdzVCYXBBS1I0bG80?= =?utf-8?B?Yk00cWdVRFdmeXJwK3VoUnpUR1llakticzA4SEw3c3YyOUx6UGprdzB0WHIz?= =?utf-8?B?YlJONmtuYSt3WGxMa3NEQkNGb1hNcjVPM0g5MS9QdDF5Ykk5SWJjWm5kNnN2?= =?utf-8?B?dHdONzVmNWVUUXB5bkc5V3QyRGJ3ejZBc0RnWjNxQnBOSEdqTDRNWkdRTXB3?= =?utf-8?B?b05CN0xPK1dxanlpbmFnSmxtWDBxYTNwSW5Nclh0OWVXbHp1azJVMlR0MlVQ?= =?utf-8?B?L1pRbHo2MW8vbXl3NmY2MlVkRmNNc09OZ3o1OWZGM2d1UFduUXpocDhVN0J6?= =?utf-8?B?ZkxFUlA3WVllWWw5ZTE4SlZJYWZWN1AzZnhtNWgrRStMaFAvWVRzZm9LUUhh?= =?utf-8?B?cjVpakxRWUtuZlBsWldnSUdoQkpnMjhUck9PUGJpMm9PWmt4SXhJcElkeFhS?= =?utf-8?B?eVJybjlQYTVlOFJ1QjlaU2UweXJmNEorODA0TFUreWZpbStpRjVTWCtiSUhz?= =?utf-8?B?VmI5eWRHMlF3Nm9PSXpHWmhJQ25zNlNXZFlTb0h2MVRNV0wrNURCS2FYOTkz?= =?utf-8?B?b3htb2VNM25DK3gvMkZMdUc3SzlPS0hNTEd1a1JDQVV1aWFvdWhyTzJaY1V3?= =?utf-8?B?ZUFOeU9EUDJrd0xtZXEyNDVoY25sODJvNkY3T2w1L2lwSFB4TUNHWDNQNzdw?= =?utf-8?B?NUM4ck84Yy9pM05iZEl5WTFqbWEvVXZJTmlhbHp4R0VwWGcrQXF5NDZRYUY5?= =?utf-8?B?dzRRK3dTdStsTUQyNElwWG5iMkpCaGk4SFpZTDN3QkhERmk5bGovVS9FVmNN?= =?utf-8?B?UldSZyt1Tko2SUN1KzBHZ3llbjlDaVBLaUVVWUZxbDdFZDBDTll6M3Y1amVo?= =?utf-8?B?dVQ1ZzM0dXNjQlpYTkRaYWpvYVNIWkJKblZPZjFBZWJualljZEZ0L0REc1Bl?= =?utf-8?B?a1MxSmRielMwaDIzSUF5b01vVGxTNWNwZHZDY3h3NktHcFhGTnRUaExFOEMz?= =?utf-8?B?UVJRRGlsbWRCWUhmZG9ObGs0SU85bjZGbE1BZU9NekV5Mmg2YWtPV2krd0FT?= =?utf-8?B?VDUvUVVzSHJ5SDRlR0h1Q0tQakk3c0pPNEZ6cGhqS3E4Vkp2MGQ3bnY2bUpQ?= =?utf-8?B?OEplMkRENWVVY1BIYklBbVU0SDJRTkM0a1dHbWl0ZGd3SjNaK0hqZkRsR3hh?= =?utf-8?B?UUZiS0JwRVdCcVA2K1hKeUsxVG1VOTNvU2FDTGdIVjR5YWNWdTIyY0VVdlEv?= =?utf-8?B?Z1BTb0c4eWJGQnEwU1BYWFRtMkRzRWVITVJQdkhpWHAwTzA2T3JPbzlKTnJ2?= =?utf-8?B?Mi8wVkNUVkx6MjY5MmFpUXE4d2R2UUE1dDdhYk1CWlJ5dkJiMS84OWR5dytQ?= =?utf-8?B?VkJtVVl3QUJmOTQrcFhxVmFrVi9Mak5OUXk3emwxWUF2WU5zY3R1NmZzVW9O?= =?utf-8?B?VCtzZHhPa0xPajUvVURXcXdOTmp5dU9QZTkyUEtkcGV6RlExNGlTQTRtYktp?= =?utf-8?B?WklxeEJIdHFoY3p6elIrRldYUC8wTENuM2RSZkNtazF6QVB0VWg2QWtWYWxU?= =?utf-8?B?MWIzYUZyS0pnMzRQczFDY3M3YWtkd1BWTC84QnBZQzQ2UFB3b3RDNElnTnJL?= =?utf-8?Q?on7OaUrO2M5oZHhKsr50AInRV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0bdb0da-1217-4baf-05b3-08db972ef10c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 10:13:27.2390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FxxihD3MgxaDbOgIYcUQoiMkdPErX/d1WRNyE2lVuaAY627L6napp5nD/Iijx94zgp0V55gAQlHeq6bIrZErtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7304 On 07.08.2023 11:38, Simon Gaiser wrote: > It seems some firmwares put dummy entries in the ACPI MADT table for non > existing processors. On my NUC11TNHi5 those have the invalid APIC ID > 0xff. Linux already has code to handle those cases both in > acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the > same check to Xen. I'm afraid it doesn't become clear to me what problem you're trying to solve. > --- a/xen/arch/x86/acpi/boot.c > +++ b/xen/arch/x86/acpi/boot.c > @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end) > if (BAD_MADT_ENTRY(processor, end)) > return -EINVAL; > > + /* Ignore entries with invalid apicid */ > + if (processor->local_apic_id == 0xffffffff) > + return 0; > + > /* Don't register processors that cannot be onlined. */ > if (madt_revision >= 5 && > !(processor->lapic_flags & ACPI_MADT_ENABLED) && > !(processor->lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) > return 0; > > - if ((processor->lapic_flags & ACPI_MADT_ENABLED) || > - processor->local_apic_id != 0xffffffff || opt_cpu_info) { > + if ((processor->lapic_flags & ACPI_MADT_ENABLED) || opt_cpu_info) { > acpi_table_print_madt_entry(header); > log = true; > } In particular you're now suppressing log messages which may be relevant. The one issue that I'm aware of (and that I use a local hack to deal with; see bottom) is excess verbosity. Jan --- unstable.orig/xen/arch/x86/mpparse.c +++ unstable/xen/arch/x86/mpparse.c @@ -809,8 +809,13 @@ int mp_register_lapic(u32 id, bool enabl }; if (MAX_APICS <= id) { - printk(KERN_WARNING "Processor #%d invalid (max %d)\n", - id, MAX_APICS); + static u32 max_warn = -1; + + if (id <= max_warn) { + printk(KERN_WARNING "Processor #%d invalid (max %d)\n", + id, MAX_APICS); + max_warn = id - 1; + } return -EINVAL; } From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:14:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:14:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.577992.905161 (Exim 4.92) (envelope-from ) id 1qSxGL-0002gH-6l; Mon, 07 Aug 2023 10:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 577992.905161; Mon, 07 Aug 2023 10:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxGL-0002gA-3i; Mon, 07 Aug 2023 10:14:57 +0000 Received: by outflank-mailman (input) for mailman id 577992; Mon, 07 Aug 2023 10:14:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxGJ-0002fy-W9; Mon, 07 Aug 2023 10:14:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxGJ-00031r-Jx; Mon, 07 Aug 2023 10:14:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxGJ-0005jj-5M; Mon, 07 Aug 2023 10:14:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qSxGJ-0006KE-4p; Mon, 07 Aug 2023 10:14:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6Cf7Me0QQDe5SxbTy5CWwUscKUkAX1F5czHnNWmhnew=; b=E0HXTNiflOOqMjw9Yh2cl/HDiw 7G72WjhX+IBE0EiD/+/zVQ39MhajdsyLpyqWnlUNV5Z0sdAJLmcf6Zsj2QxbHU6lKZaE2zj2uOnyA hpr7sgHXC04hTOPIFb34b34Kb0CG7JK/qBkhyGULwOT8DkC9HjN/ScZag96zKCq66zP4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182208: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9400601a689a128c25fa9c21e932562e0eeb7a26 X-Osstest-Versions-That: qemuu=6db03ccc7f4ca33c99debaac290066f4500a2dfb From: osstest service owner Date: Mon, 07 Aug 2023 10:14:55 +0000 flight 182208 qemu-mainline real [real] flight 182211 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182208/ http://logs.test-lab.xenproject.org/osstest/logs/182211/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 182211-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182202 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182202 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182202 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182202 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182202 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182202 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182202 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182202 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 9400601a689a128c25fa9c21e932562e0eeb7a26 baseline version: qemuu 6db03ccc7f4ca33c99debaac290066f4500a2dfb Last test of basis 182202 2023-08-06 01:59:56 Z 1 days Testing same since 182208 2023-08-07 01:39:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Daniel Henrique Barboza Dmitriy Solovev Helge Deller Ilya Leoshkevich Matheus Tavares Bernardino Mikhail Tyutin Nathan Egge Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 6db03ccc7f..9400601a68 9400601a689a128c25fa9c21e932562e0eeb7a26 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:17:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:17:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578001.905171 (Exim 4.92) (envelope-from ) id 1qSxJ5-0003PH-QB; Mon, 07 Aug 2023 10:17:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578001.905171; Mon, 07 Aug 2023 10:17:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxJ5-0003PA-NR; Mon, 07 Aug 2023 10:17:47 +0000 Received: by outflank-mailman (input) for mailman id 578001; Mon, 07 Aug 2023 10:17:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxJ4-0003P4-6U for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:17:46 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a539c8c7-350b-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 12:17:43 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 47E543200923; Mon, 7 Aug 2023 06:17:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 07 Aug 2023 06:17:41 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 06:17:39 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a539c8c7-350b-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691403460; x=1691489860; bh=lF5FFi9qv4L715tY6xYh8C7OAp6/fQDjMng GRYfiSD4=; b=FYEvczzNpFQZJNX8oM4xUWjy65FIFUROgtlyUKPxVgaRuTF5LjV M1FZRRMf+BICfM2Zf04fi7/2mJHcm/VWnMQihetg6qJrqg9lzvw09GqRiww72Urz OlDw6NWgWvFvjePbqpqZ0pa13sK0Z954WMnPA3t0TrFA0e1I1UoiFvg6d2NeeXJd bUwVCtuYixYrM5bqE2j7fv16HaohNUvkf4kJ9X4YlhgTu7vpKYWNuRwFPY4f1kF8 Wazj3fBwbomezBRXdjS9zaYHLuumb8C3skfiEvsh5iKI3SLii6DJVevYYpHklRyw 7hPR7n4dsV3LesHZcU+ZoAvRYJQz9BTXwXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691403460; x=1691489860; bh=lF5FFi9qv4L71 5tY6xYh8C7OAp6/fQDjMngGRYfiSD4=; b=bfiTZUvNzSIfZXrUX+/JDbfZZ5n9U Riq7DlSOT4wjjhlgdRhTHZmKkYAaAB3ovPwCnoIx9/nnxCtc4nkvLlTkSe8sB+RP 7/hBWFS0/ipOAbLNBpuTbLYW42CIA1A8p5omyexdA2AzOFOBKz9mZk5ofozyTxew cH4yNYTtZQkxBX7vcc0vLSgYs8WXmdQ1ArRVkthgLxE/mPZefdO5BcTJbVbuWfKu Kc7z1r5oPsU1oxxGIPE9rskJp35HuN/pAaKX/lTQhD9pellSQZk6DBgwLMAmP2Ex 70Fvj7f2LQYrOkJfkMLtbgz9dCYLif0PZM+Jho404PNtr7rdR94Z+N+yw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeeftdefudeltdevhfehkeefhfeutdfhffdugeetffdv gfehfeekhfetgedvuefggfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhimhhonhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <06e706fe-4338-876e-8888-a43542c43661@invisiblethingslab.com> Date: Mon, 7 Aug 2023 12:17:27 +0200 MIME-Version: 1.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> From: Simon Gaiser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ef8mOtNBNQLW0oZoN7Aq8nUc" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ef8mOtNBNQLW0oZoN7Aq8nUc Content-Type: multipart/mixed; boundary="------------168yFGGLT072wOQwBV1gDYF9"; protected-headers="v1" From: Simon Gaiser To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: <06e706fe-4338-876e-8888-a43542c43661@invisiblethingslab.com> Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> In-Reply-To: --------------168yFGGLT072wOQwBV1gDYF9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Andrew Cooper: > On 07/08/2023 11:01 am, Andrew Cooper wrote: >> On 07/08/2023 10:38 am, Simon Gaiser wrote: >>> It seems some firmwares put dummy entries in the ACPI MADT table for = non >>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>> 0xff. Linux already has code to handle those cases both in >>> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >>> same check to Xen. >>> >>> Note that on some older (2nd gen Core i) laptop of mine I also saw du= mmy >>> entries with a valid APIC ID. Linux would still ignore those because >>> they have !ACPI_MADT_ENABLED && !ACPI_MADT_ONLINE_CAPABLE. But in Xen= >>> this check is only active for madt_revision >=3D 5. But since this ve= rsion >>> check seems to be intentionally I leave that alone. >> I recall there being a discussion over this, ultimately with the versi= on >> check being removed. IIRC it was a defacto standard used for a long >> time prior to actually getting written into the ACPI spec, so does exi= st >> in practice in older MADTs. >> >> Otherwise LGTM. I'd suggest dropping this paragraph as it's not relat= ed >> to the change. It will also help if we do decide to follow up and dro= p >> the MADT version check. It's in so far related as that I know this doesn't cover all cases I actually wanted to address and I want to mention this. But I can see why you might not want to have this in this commit message. Feel free to drop. >>> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.= git/commit/?id=3Df3bf1dbe64b62a2058dd1944c00990df203e8e7a # [1] >>> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.= git/commit/?id=3D10daf10ab154e31237a8c07242be3063fb6a9bf4 # [2] >> https://git.kernel.org/torvalds/c/$SHA >> >> Somewhat less verbose. https://korg.docs.kernel.org/git-url-shorteners= =2Ehtml Ah, handy. >>> Signed-off-by: Simon Gaiser >>> --- >>> xen/arch/x86/acpi/boot.c | 14 ++++++++++---- >>> 1 file changed, 10 insertions(+), 4 deletions(-) >>> >>> diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c >>> index 54b72d716b..4a62822fa9 100644 >>> --- a/xen/arch/x86/acpi/boot.c >>> +++ b/xen/arch/x86/acpi/boot.c >>> @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *he= ader, const unsigned long end) >>> if (BAD_MADT_ENTRY(processor, end)) >>> return -EINVAL; >>> =20 >>> + /* Ignore entries with invalid apicid */ >> x2apic ID. >=20 > Oh, and I forgot to say. I'm happy to fix all of this up on commit if > you're happy. Sure, go ahead. Thanks! --------------168yFGGLT072wOQwBV1gDYF9-- --------------ef8mOtNBNQLW0oZoN7Aq8nUc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTQxLkACgkQkO9xfO/x ly8+GhAAxj+qBeew0LYZ+KhFN/1TP7V9Vp8HQxEy/HTbM1V8mSmL0g4zTUzXySAN HsN4i+AL9lXsMacxsVhvkD8rNQGRDlRBYSh+iRSb0X8bHFyjAq8+ozv/b7sy8Fj1 zrMyFQe1pvvKCHg8Zh9dGngKIYJhjISExkqwF0JlBEZ66jriOgna7tiy4Xag/awX mU0eqWEF+9zaDqKS+V/a/nE02+zcW8P8w0YskHlOZEfyulCf7tpAH0SNUMrOdBOM Or6kJ1MO6aFx3eOk5NRizRjHxHk9wWGksbT0mKNH7HpdyYE/Uk0eXR40z+4nb4Ky p3timasA0vI43ZSryVQjiRxI+VRvVVV6Gqi7rDWKgZjv3a4kdsf6ZGEEiM/bNIvx OB0R6lNPYk1tzz51wLTypVuz4yDYC2CzFZ2DwlDfbhlDM4SBL8aXxYQCuq86T9HY lAbPlfKfh2XLLK0AsTwG2LTf9UkUS72j1hQGQkiQvx7czT3Q7kLQsHPqB1H1zyWO rSEfI9gl6/5eAPSrrn+DqQoognAb/m/PJB3GgigG5zQlNhNCk0pCo2vyWoEHtuCe xkBBMgzV7JacwYk/W3aKrdX4hzdlLRb0guikoNzi935k3ZNYnuyt2BpYQw9U9RBe TLX2uak7Eg3LIghZcWMYxLf+LhuL9xpyaB+eV/VRzAFj3d3YKHc= =gNX7 -----END PGP SIGNATURE----- --------------ef8mOtNBNQLW0oZoN7Aq8nUc-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 10:40:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 10:40:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578007.905180 (Exim 4.92) (envelope-from ) id 1qSxf7-0006q0-Ke; Mon, 07 Aug 2023 10:40:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578007.905180; Mon, 07 Aug 2023 10:40:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxf7-0006pt-Hq; Mon, 07 Aug 2023 10:40:33 +0000 Received: by outflank-mailman (input) for mailman id 578007; Mon, 07 Aug 2023 10:40:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSxf6-0006pn-Ug for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 10:40:32 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4cfb23c-350e-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 12:40:31 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id CCA1C4EE0737; Mon, 7 Aug 2023 12:40:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4cfb23c-350e-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 12:40:30 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Xen-devel , Stefano Stabellini , Michal Orzel , xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Andrew Cooper , Julien Grall , George Dunlap , Wei Liu , Stefano Stabellini Subject: Re: Address MISRA C:2012 Rule 8.4 In-Reply-To: References: <786d24b044bfa503a73a36d2a01eae8c@bugseng.com> <00fb1a58849ec08534465df2f8ca2284@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <2c9becb505cc0ebc528ad02ab8ebbe6e@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >> One further question is whether functions under >> 'xen/common/coverage/gcov_base.c' should gain >> a declaration in 'gcov.h' or not, as they exist just for the purpose >> of >> being referenced >> by autogenerated profiling code. I see no reason why they shouldn't, >> but >> they can also be safely deviated, >> since they are not called by Xen code. > > Imo it should be the compiler to provide a prototype for these (much > like it does for builtins), thus ensuring that an implementation > actually matches the compiler's expectations. Yet afaics it doesn't. > > Jan Then it's perhaps best to deviate them. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:10:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578013.905190 (Exim 4.92) (envelope-from ) id 1qSy7f-0001bU-RE; Mon, 07 Aug 2023 11:10:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578013.905190; Mon, 07 Aug 2023 11:10:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy7f-0001bA-OX; Mon, 07 Aug 2023 11:10:03 +0000 Received: by outflank-mailman (input) for mailman id 578013; Mon, 07 Aug 2023 11:10:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy7d-00018O-M7 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:10:02 +0000 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [2607:f8b0:4864:20::1033]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f194993e-3512-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:09:58 +0200 (CEST) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-268f6ba57b5so623663a91.1 for ; Mon, 07 Aug 2023 04:09:58 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:09:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f194993e-3512-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406597; x=1692011397; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IUFroX+K29vocKlwNJzs/neGWgohuFaGhfTkMV8vShc=; b=VgaeXhz1xsi1DvY0mdHG5w6GDNOVQV4G915G2okvAB9QZ0UmJ9gvIJ6asoYIB210RG Ey93kt9KOPOZ3l4nhlHXgtdSy6FjYflv77vSCILUklupME+r3C8zNVLYXpLlDcRqUM0e lfUAl5POG7wx94wNJAfUoDsPXulpyHktrCbv8gD1x/O2p9qeRsFSiX6gwTwjM13k8Ul9 /rnH/O+MrYpDiSizTF8aNQeTO7XJ0dle1SDOCfUCACCM/+nHgHo/Meo1/jTJjDUt3SZw 15CpfTIt4xPVx9oBnNw2YwnlJP6BsajGK0nqKNQy5sLb5tHNDmV00nrqq2mUlfhGa7do /28Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406597; x=1692011397; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IUFroX+K29vocKlwNJzs/neGWgohuFaGhfTkMV8vShc=; b=ORW4sfIV2NlG5HDdLUaH/R1/qLEQeOKRiC00C9QnXYBCrlGpziqKKZ4x4whRYJ0n8a 98PZ57Gm3SZphXleP6AXcvv0cmCIuWC8OQztIsbOIg/qkOlVYHCwDPD+fn5GjhUgHR2N Q8NokqFJsHpKPflG0o4duu3CTd7WoMQWusH7645lhrh4KqU6fpr5Xy7A7zSxlqdrEVk3 sSmmRE0WQ4vN5lL6yClIwUmJ7n8k/bq4MtKwjsbUF3H7f8oCbNBMUwebShClAxgZ8aYJ LUsh6ya2WCHq0+BkOUU9fDiOOK42mapolH5/o0ehGAzemC7WETjDDasaQM9XC4pB6EDa b2VQ== X-Gm-Message-State: AOJu0YzpbC8ZnAV8MWZLKD9jx+2cIy5EnpW0kb0DFckgxwdhdBcZEGhq prxSsdO5dN4CO20txvdDJ3t25A== X-Google-Smtp-Source: AGHT+IE6Hkf3zCZO4yTHBCI4U2PxahDBEY93d/z4hx9RjtxF2e4b3lAVTQiaQWVBs1sivCsjN/GRXg== X-Received: by 2002:a17:90a:6701:b0:269:32c7:24dc with SMTP id n1-20020a17090a670100b0026932c724dcmr6023585pjj.0.1691406596583; Mon, 07 Aug 2023 04:09:56 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 00/48] use refcount+RCU method to implement lockless slab shrink Date: Mon, 7 Aug 2023 19:08:48 +0800 Message-Id: <20230807110936.21819-1-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, 1. Background ============= We used to implement the lockless slab shrink with SRCU [1], but then kernel test robot reported -88.8% regression in stress-ng.ramfs.ops_per_sec test case [2], so we reverted it [3]. This patch series aims to re-implement the lockless slab shrink using the refcount+RCU method proposed by Dave Chinner [4]. [1]. https://lore.kernel.org/lkml/20230313112819.38938-1-zhengqi.arch@bytedance.com/ [2]. https://lore.kernel.org/lkml/202305230837.db2c233f-yujie.liu@intel.com/ [3]. https://lore.kernel.org/all/20230609081518.3039120-1-qi.zheng@linux.dev/ [4]. https://lore.kernel.org/lkml/ZIJhou1d55d4H1s0@dread.disaster.area/ 2. Implementation ================= Currently, the shrinker instances can be divided into the following three types: a) global shrinker instance statically defined in the kernel, such as workingset_shadow_shrinker. b) global shrinker instance statically defined in the kernel modules, such as mmu_shrinker in x86. c) shrinker instance embedded in other structures. For case a, the memory of shrinker instance is never freed. For case b, the memory of shrinker instance will be freed after synchronize_rcu() when the module is unloaded. For case c, the memory of shrinker instance will be freed along with the structure it is embedded in. In preparation for implementing lockless slab shrink, we need to dynamically allocate those shrinker instances in case c, then the memory can be dynamically freed alone by calling kfree_rcu(). This patchset adds the following new APIs for dynamically allocating shrinker, and add a private_data field to struct shrinker to record and get the original embedded structure. 1. shrinker_alloc() 2. shrinker_register() 3. shrinker_free() In order to simplify shrinker-related APIs and make shrinker more independent of other kernel mechanisms, this patchset uses the above APIs to convert all shrinkers (including case a and b) to dynamically allocated, and then remove all existing APIs. This will also have another advantage mentioned by Dave Chinner: ``` The other advantage of this is that it will break all the existing out of tree code and third party modules using the old API and will no longer work with a kernel using lockless slab shrinkers. They need to break (both at the source and binary levels) to stop bad things from happening due to using uncoverted shrinkers in the new setup. ``` Then we free the shrinker by calling call_rcu(), and use rcu_read_{lock,unlock}() to ensure that the shrinker instance is valid. And the shrinker::refcount mechanism ensures that the shrinker instance will not be run again after unregistration. So the structure that records the pointer of shrinker instance can be safely freed without waiting for the RCU read-side critical section. In this way, while we implement the lockless slab shrink, we don't need to be blocked in unregister_shrinker() to wait RCU read-side critical section. PATCH 1: fix memory leak in binder_init() PATCH 2: move some shrinker-related function declarations to mm/internal.h PATCH 3: move shrinker-related code into a separate file PATCH 4: remove redundant shrinker_rwsem in debugfs operations PATCH 5: add infrastructure for dynamically allocating shrinker PATCH 6 ~ 23: dynamically allocate the shrinker instances in case a and b PATCH 24 ~ 42: dynamically allocate the shrinker instances in case c PATCH 43: remove old APIs PATCH 44: introduce pool_shrink_rwsem to implement private synchronize_shrinkers() PATCH 45: add a secondary array for shrinker_info::{map, nr_deferred} PATCH 46 ~ 47: implement the lockless slab shrink PATCH 48 ~ 49: convert shrinker_rwsem to mutex 3. Testing ========== 3.1 slab shrink stress test --------------------------- We can reproduce the down_read_trylock() hotspot through the following script: ``` DIR="/root/shrinker/memcg/mnt" do_create() { mkdir -p /sys/fs/cgroup/memory/test echo 4G > /sys/fs/cgroup/memory/test/memory.limit_in_bytes for i in `seq 0 $1`; do mkdir -p /sys/fs/cgroup/memory/test/$i; echo $$ > /sys/fs/cgroup/memory/test/$i/cgroup.procs; mkdir -p $DIR/$i; done } do_mount() { for i in `seq $1 $2`; do mount -t tmpfs $i $DIR/$i; done } do_touch() { for i in `seq $1 $2`; do echo $$ > /sys/fs/cgroup/memory/test/$i/cgroup.procs; dd if=/dev/zero of=$DIR/$i/file$i bs=1M count=1 & done } case "$1" in touch) do_touch $2 $3 ;; test) do_create 4000 do_mount 0 4000 do_touch 0 3000 ;; *) exit 1 ;; esac ``` Save the above script, then run test and touch commands. Then we can use the following perf command to view hotspots: perf top -U -F 999 1) Before applying this patchset: 40.44% [kernel] [k] down_read_trylock 17.59% [kernel] [k] up_read 13.64% [kernel] [k] pv_native_safe_halt 11.90% [kernel] [k] shrink_slab 8.21% [kernel] [k] idr_find 2.71% [kernel] [k] _find_next_bit 1.36% [kernel] [k] shrink_node 0.81% [kernel] [k] shrink_lruvec 0.80% [kernel] [k] __radix_tree_lookup 0.50% [kernel] [k] do_shrink_slab 0.21% [kernel] [k] list_lru_count_one 0.16% [kernel] [k] mem_cgroup_iter 2) After applying this patchset: 60.17% [kernel] [k] shrink_slab 20.42% [kernel] [k] pv_native_safe_halt 3.03% [kernel] [k] do_shrink_slab 2.73% [kernel] [k] shrink_node 2.27% [kernel] [k] shrink_lruvec 2.00% [kernel] [k] __rcu_read_unlock 1.92% [kernel] [k] mem_cgroup_iter 0.98% [kernel] [k] __rcu_read_lock 0.91% [kernel] [k] osq_lock 0.63% [kernel] [k] mem_cgroup_calculate_protection 0.55% [kernel] [k] shrinker_put 0.46% [kernel] [k] list_lru_count_one We can see that the first perf hotspot becomes shrink_slab, which is what we expect. 3.2 registeration and unregisteration stress test ------------------------------------------------- Run the command below to test: stress-ng --timeout 60 --times --verify --metrics-brief --ramfs 9 & 1) Before applying this patchset: setting to a 60 second run per stressor dispatching hogs: 9 ramfs stressor bogo ops real time usr time sys time bogo ops/s bogo ops/s (secs) (secs) (secs) (real time) (usr+sys time) ramfs 735238 60.00 12.37 363.70 12253.05 1955.08 for a 60.01s run time: 1440.27s available CPU time 12.36s user time ( 0.86%) 363.70s system time ( 25.25%) 376.06s total time ( 26.11%) load average: 10.79 4.47 1.69 passed: 9: ramfs (9) failed: 0 skipped: 0 successful run completed in 60.01s (1 min, 0.01 secs) 2) After applying this patchset: setting to a 60 second run per stressor dispatching hogs: 9 ramfs stressor bogo ops real time usr time sys time bogo ops/s bogo ops/s (secs) (secs) (secs) (real time) (usr+sys time) ramfs 746698 60.00 12.45 376.16 12444.02 1921.47 for a 60.01s run time: 1440.28s available CPU time 12.44s user time ( 0.86%) 376.16s system time ( 26.12%) 388.60s total time ( 26.98%) load average: 9.01 3.85 1.49 passed: 9: ramfs (9) failed: 0 skipped: 0 successful run completed in 60.01s (1 min, 0.01 secs) We can see that the ops/s has hardly changed. This series is based on next-20230807. Comments and suggestions are welcome. Thanks, Qi Changelog in v3 -> v4: - [PATCH v3 01/49] has been merged, so discard it. - fix wrong return value in patch v3 15\16\22\27\28\29\34\40. (pointed by Damien Le Moal) - fix uninitialized variable in [PATCH v3 04/49] (pointed by Simon Horman) - fix typo in [PATCH v3 05/49] (pointed by Simon Horman) - rebase onto the next-20230807. Changelog in v2 -> v3: - add the patch that [PATCH v3 07/49] depends on - move some shrinker-related function declarations to mm/internal.h (suggested by Muchun Song) - combine shrinker_free_non_registered() and shrinker_unregister() into shrinker_free() (suggested by Dave Chinner) - add missing __init and fix return value in bch_btree_cache_alloc() (pointed by Muchun Song) - remove unnecessary WARN_ON() (pointed by Steven Price) - go back to use completion to implement lockless slab shrink (pointed by Dave Chinner) - collect Acked-bys and Reviewed-bys - rebase onto the next-20230726. Changelog in v1 -> v2: - implement the new APIs and convert all shrinkers to use it. (suggested by Dave Chinner) - fix UAF in PATCH [05/29] (pointed by Steven Price) - add a secondary array for shrinker_info::{map, nr_deferred} - re-implement the lockless slab shrink (Since unifying the processing of global and memcg slab shrink needs to modify the startup sequence (As I mentioned in https://lore.kernel.org/lkml/38b14080-4ce5-d300-8a0a-c630bca6806b@bytedance.com/), I finally choose to process them separately.) - collect Acked-bys Qi Zheng (48): mm: move some shrinker-related function declarations to mm/internal.h mm: vmscan: move shrinker-related code into a separate file mm: shrinker: remove redundant shrinker_rwsem in debugfs operations mm: shrinker: add infrastructure for dynamically allocating shrinker kvm: mmu: dynamically allocate the x86-mmu shrinker binder: dynamically allocate the android-binder shrinker drm/ttm: dynamically allocate the drm-ttm_pool shrinker xenbus/backend: dynamically allocate the xen-backend shrinker erofs: dynamically allocate the erofs-shrinker f2fs: dynamically allocate the f2fs-shrinker gfs2: dynamically allocate the gfs2-glock shrinker gfs2: dynamically allocate the gfs2-qd shrinker NFSv4.2: dynamically allocate the nfs-xattr shrinkers nfs: dynamically allocate the nfs-acl shrinker nfsd: dynamically allocate the nfsd-filecache shrinker quota: dynamically allocate the dquota-cache shrinker ubifs: dynamically allocate the ubifs-slab shrinker rcu: dynamically allocate the rcu-lazy shrinker rcu: dynamically allocate the rcu-kfree shrinker mm: thp: dynamically allocate the thp-related shrinkers sunrpc: dynamically allocate the sunrpc_cred shrinker mm: workingset: dynamically allocate the mm-shadow shrinker drm/i915: dynamically allocate the i915_gem_mm shrinker drm/msm: dynamically allocate the drm-msm_gem shrinker drm/panfrost: dynamically allocate the drm-panfrost shrinker dm: dynamically allocate the dm-bufio shrinker dm zoned: dynamically allocate the dm-zoned-meta shrinker md/raid5: dynamically allocate the md-raid5 shrinker bcache: dynamically allocate the md-bcache shrinker vmw_balloon: dynamically allocate the vmw-balloon shrinker virtio_balloon: dynamically allocate the virtio-balloon shrinker mbcache: dynamically allocate the mbcache shrinker ext4: dynamically allocate the ext4-es shrinker jbd2,ext4: dynamically allocate the jbd2-journal shrinker nfsd: dynamically allocate the nfsd-client shrinker nfsd: dynamically allocate the nfsd-reply shrinker xfs: dynamically allocate the xfs-buf shrinker xfs: dynamically allocate the xfs-inodegc shrinker xfs: dynamically allocate the xfs-qm shrinker zsmalloc: dynamically allocate the mm-zspool shrinker fs: super: dynamically allocate the s_shrink mm: shrinker: remove old APIs drm/ttm: introduce pool_shrink_rwsem mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} mm: shrinker: make global slab shrink lockless mm: shrinker: make memcg slab shrink lockless mm: shrinker: hold write lock to reparent shrinker nr_deferred mm: shrinker: convert shrinker_rwsem to mutex arch/x86/kvm/mmu/mmu.c | 18 +- drivers/android/binder_alloc.c | 31 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 30 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/msm/msm_drv.c | 4 +- drivers/gpu/drm/msm/msm_drv.h | 4 +- drivers/gpu/drm/msm/msm_gem_shrinker.c | 34 +- drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 6 +- drivers/gpu/drm/panfrost/panfrost_gem.h | 2 +- .../gpu/drm/panfrost/panfrost_gem_shrinker.c | 30 +- drivers/gpu/drm/ttm/ttm_pool.c | 38 +- drivers/md/bcache/bcache.h | 2 +- drivers/md/bcache/btree.c | 27 +- drivers/md/bcache/sysfs.c | 3 +- drivers/md/dm-bufio.c | 28 +- drivers/md/dm-cache-metadata.c | 2 +- drivers/md/dm-zoned-metadata.c | 29 +- drivers/md/raid5.c | 26 +- drivers/md/raid5.h | 2 +- drivers/misc/vmw_balloon.c | 38 +- drivers/virtio/virtio_balloon.c | 25 +- drivers/xen/xenbus/xenbus_probe_backend.c | 18 +- fs/btrfs/super.c | 2 +- fs/erofs/utils.c | 20 +- fs/ext4/ext4.h | 2 +- fs/ext4/extents_status.c | 24 +- fs/f2fs/super.c | 32 +- fs/gfs2/glock.c | 20 +- fs/gfs2/main.c | 6 +- fs/gfs2/quota.c | 26 +- fs/gfs2/quota.h | 3 +- fs/jbd2/journal.c | 27 +- fs/kernfs/mount.c | 2 +- fs/mbcache.c | 23 +- fs/nfs/nfs42xattr.c | 87 +- fs/nfs/super.c | 22 +- fs/nfsd/filecache.c | 23 +- fs/nfsd/netns.h | 4 +- fs/nfsd/nfs4state.c | 20 +- fs/nfsd/nfscache.c | 31 +- fs/proc/root.c | 2 +- fs/quota/dquot.c | 18 +- fs/super.c | 36 +- fs/ubifs/super.c | 22 +- fs/xfs/xfs_buf.c | 25 +- fs/xfs/xfs_buf.h | 2 +- fs/xfs/xfs_icache.c | 26 +- fs/xfs/xfs_mount.c | 4 +- fs/xfs/xfs_mount.h | 2 +- fs/xfs/xfs_qm.c | 28 +- fs/xfs/xfs_qm.h | 2 +- include/linux/fs.h | 2 +- include/linux/jbd2.h | 2 +- include/linux/memcontrol.h | 12 +- include/linux/shrinker.h | 67 +- kernel/rcu/tree.c | 22 +- kernel/rcu/tree_nocb.h | 20 +- mm/Makefile | 4 +- mm/huge_memory.c | 69 +- mm/internal.h | 41 + mm/shrinker.c | 770 ++++++++++++++++++ mm/shrinker_debug.c | 47 +- mm/vmscan.c | 701 ---------------- mm/workingset.c | 27 +- mm/zsmalloc.c | 28 +- net/sunrpc/auth.c | 21 +- 67 files changed, 1540 insertions(+), 1235 deletions(-) create mode 100644 mm/shrinker.c -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:10:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578014.905201 (Exim 4.92) (envelope-from ) id 1qSy7p-0002FK-8r; Mon, 07 Aug 2023 11:10:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578014.905201; Mon, 07 Aug 2023 11:10:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy7p-0002FD-5y; Mon, 07 Aug 2023 11:10:13 +0000 Received: by outflank-mailman (input) for mailman id 578014; Mon, 07 Aug 2023 11:10:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy7o-0002Ee-38 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:10:12 +0000 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [2607:f8b0:4864:20::1029]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8c77de7-3512-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:10:10 +0200 (CEST) Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2690803a368so590054a91.1 for ; Mon, 07 Aug 2023 04:10:10 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:10:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8c77de7-3512-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406609; x=1692011409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r8W8qq2Uz0spC2GoySlMERPhgmOL8aWRmiOXTDM010g=; b=LtcpivNSr/5U6x0m/uiyeqUuM2dtsqsVmyslCvnMZ+TbsDLmyfYCok7TOqfFwU4aou suPwxQHD97VI0Q62GW+ZYHDc8tjkHAC6Y2CfDY4CzUPMlkJryxFMZeRg2u77WPUScUma /UWc/sCeR8W9qQ3wk0oPqkWmTEZmPd4YXzSaovoOZwWfn9s/VibhxnVRbQAxTTT4rsLS 7EPkGC2ZgyKx21jg/v6bd406CHIloRAPbtMcp+52o9Mv0AXgKZgqXOlA0BowU0u6XLn9 g3j+asxGnqU4OhqCycxU0aToYArdbvRqg5AMoRMXcXqSNLhcPxtT3QmhYn/OoV2pniV3 od0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406609; x=1692011409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r8W8qq2Uz0spC2GoySlMERPhgmOL8aWRmiOXTDM010g=; b=S2I3w1povedOlfN2pGB6y9u5Ab1z94K9OZP+L6uwDQ2Qumy3fZ0HDX/5dXVi9grpiY b1+LvmcPP56f9VZMAASYRSTerookynH0iFykTAbFSld436ETpvnssZ7UN+qLo3/Wa4et sP3UltFjPTjuhgYZWGnktZbJQJ8xflGehDovKTfaFyES8Cs2od5McIJVIyDvnrPKFSlN jXjTU5wO3L1HKARtfS2u7mw3mQa5ip8SwiJg51ubof2R8bM7P+CM6+DS8gna8CDR4yTY GJrx8V6fPwamFmMGBFDn+iyrM83MHcrktMRAFeljUBiGmOlLu6wMqZDwKzFU50UHlkOx VPtg== X-Gm-Message-State: ABy/qLbHt5pNehbVoAvvSYBDnTuw8PoxBuVUjRMWvYsE8Vbf86v4xqwd xvjbGzszmOmMK6RHOoC62lIF0Q== X-Google-Smtp-Source: APBJJlH4Xq2ZH2mKI5CfuqTuY77FQCtuH4PGEB2vg3tzfU2CpFxEqGweFj8X5L0soAOYNhp1I46kQg== X-Received: by 2002:a17:90a:4104:b0:25c:1ad3:a4a1 with SMTP id u4-20020a17090a410400b0025c1ad3a4a1mr24586808pjf.1.1691406608964; Mon, 07 Aug 2023 04:10:08 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 01/48] mm: move some shrinker-related function declarations to mm/internal.h Date: Mon, 7 Aug 2023 19:08:49 +0800 Message-Id: <20230807110936.21819-2-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following functions are only used inside the mm subsystem, so it's better to move their declarations to the mm/internal.h file. 1. shrinker_debugfs_add() 2. shrinker_debugfs_detach() 3. shrinker_debugfs_remove() Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 19 ------------------- mm/internal.h | 28 ++++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 19 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 224293b2dd06..8dc15aa37410 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -106,28 +106,9 @@ extern void free_prealloced_shrinker(struct shrinker *shrinker); extern void synchronize_shrinkers(void); #ifdef CONFIG_SHRINKER_DEBUG -extern int shrinker_debugfs_add(struct shrinker *shrinker); -extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, - int *debugfs_id); -extern void shrinker_debugfs_remove(struct dentry *debugfs_entry, - int debugfs_id); extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...); #else /* CONFIG_SHRINKER_DEBUG */ -static inline int shrinker_debugfs_add(struct shrinker *shrinker) -{ - return 0; -} -static inline struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, - int *debugfs_id) -{ - *debugfs_id = -1; - return NULL; -} -static inline void shrinker_debugfs_remove(struct dentry *debugfs_entry, - int debugfs_id) -{ -} static inline __printf(2, 3) int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) { diff --git a/mm/internal.h b/mm/internal.h index 154da4f0d557..6f21926393af 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1143,4 +1143,32 @@ struct vma_prepare { struct vm_area_struct *remove; struct vm_area_struct *remove2; }; + +/* + * shrinker related functions + */ + +#ifdef CONFIG_SHRINKER_DEBUG +extern int shrinker_debugfs_add(struct shrinker *shrinker); +extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, + int *debugfs_id); +extern void shrinker_debugfs_remove(struct dentry *debugfs_entry, + int debugfs_id); +#else /* CONFIG_SHRINKER_DEBUG */ +static inline int shrinker_debugfs_add(struct shrinker *shrinker) +{ + return 0; +} +static inline struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, + int *debugfs_id) +{ + *debugfs_id = -1; + return NULL; +} +static inline void shrinker_debugfs_remove(struct dentry *debugfs_entry, + int debugfs_id) +{ +} +#endif /* CONFIG_SHRINKER_DEBUG */ + #endif /* __MM_INTERNAL_H */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:10:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:10:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578016.905211 (Exim 4.92) (envelope-from ) id 1qSy82-0002ei-IO; Mon, 07 Aug 2023 11:10:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578016.905211; Mon, 07 Aug 2023 11:10:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy82-0002eb-E6; Mon, 07 Aug 2023 11:10:26 +0000 Received: by outflank-mailman (input) for mailman id 578016; Mon, 07 Aug 2023 11:10:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy81-0002Ee-Ni for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:10:25 +0000 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [2607:f8b0:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00d35d50-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:10:23 +0200 (CEST) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6872c60b572so994474b3a.1 for ; Mon, 07 Aug 2023 04:10:23 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:10:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00d35d50-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406622; x=1692011422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GEi4MYuk0OEYflth0Mb1DlFyZuiRlqXPhzGhOI28yow=; b=BEvTj+xwW+T88pT01ic9HCjfMsNsUtdxPovUDtMtpNRFgKOF7OPKZlfnwvdpMrZsO1 yoJN3VDoQT6bqGjHEFD+GOFUbTFyPWQ9AmgWQHHMtUKtDFwB2AaCD8h8ed/2/nFlj6R/ H6RbchdxL8KOcvrs5+S0zZOQ7z5kmO5+1Ob9A43qfRUa8zWOsgqkDlWkIZ6Nce8P3hyT 6WUFOueyKbkU0/JQe7kyXIgtpN16Nt1532HkzF1M6pOxV7CrOQJaiVOX1MvieAVDT9mZ 7Wp39SMBYWooErXp+bNrum847BTmBIxZLX39IVOZTRIPZyaqqeRkUBu+bq48TNvJ2qgU oNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406622; x=1692011422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GEi4MYuk0OEYflth0Mb1DlFyZuiRlqXPhzGhOI28yow=; b=eWHXi/1de5Cys+71Wditc9zYXARLXXqCHbcI6k88ewkwy/3AGq9dcduU9U8qmx1JQi komjzi/h4O3xXznXVAvD+J3k1JaqYdMPU5EVZUTwGIDi3SjZ+bMuuZXRUO7jUwjf8azM js4eCDgEMv9DyFfWhGI/gRK9K/iFF+9lrooZ9QHs26TL0BjK+OGzoCD0x+sodiN7bFC+ E4tnSPsAatd/IWq/aLqNEsJwyIZ56nWahB2CRST1sBFqpz/7h6LwS4h0wbT1nlN0SZJf xSW9nRBYJYkdmRmLqZ5fu7OPsBo4ZChr1yMlj5sILFJYfdFYrGRYzUZq9OBbDVOnG+J0 UGTw== X-Gm-Message-State: ABy/qLY6eOMC5/uVrAa7wsNxD0R0PHjAwIBcIV9tDxNSUS+EoyOQbcUz WHDkelVS4n+aMF3hKTrSgG+YTA== X-Google-Smtp-Source: APBJJlH6EApx+wddxarWw2nzmVwQ6n81Kim8/orhAtf/liUQAlYr06Fft6gh/8UZFDYZK5CJyxwGZw== X-Received: by 2002:a17:903:22c6:b0:1b8:2ba0:c9a8 with SMTP id y6-20020a17090322c600b001b82ba0c9a8mr33072978plg.2.1691406622170; Mon, 07 Aug 2023 04:10:22 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 02/48] mm: vmscan: move shrinker-related code into a separate file Date: Mon, 7 Aug 2023 19:08:50 +0800 Message-Id: <20230807110936.21819-3-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mm/vmscan.c file is too large, so separate the shrinker-related code from it into a separate file. No functional changes. Signed-off-by: Qi Zheng --- mm/Makefile | 4 +- mm/internal.h | 2 + mm/shrinker.c | 709 ++++++++++++++++++++++++++++++++++++++++++++++++++ mm/vmscan.c | 701 ------------------------------------------------- 4 files changed, 713 insertions(+), 703 deletions(-) create mode 100644 mm/shrinker.c diff --git a/mm/Makefile b/mm/Makefile index ec65984e2ade..33873c8aedb3 100644 --- a/mm/Makefile +++ b/mm/Makefile @@ -48,8 +48,8 @@ endif obj-y := filemap.o mempool.o oom_kill.o fadvise.o \ maccess.o page-writeback.o folio-compat.o \ - readahead.o swap.o truncate.o vmscan.o shmem.o \ - util.o mmzone.o vmstat.o backing-dev.o \ + readahead.o swap.o truncate.o vmscan.o shrinker.o \ + shmem.o util.o mmzone.o vmstat.o backing-dev.o \ mm_init.o percpu.o slab_common.o \ compaction.o show_mem.o shmem_quota.o\ interval_tree.o list_lru.o workingset.o \ diff --git a/mm/internal.h b/mm/internal.h index 6f21926393af..b98c29f0a471 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1147,6 +1147,8 @@ struct vma_prepare { /* * shrinker related functions */ +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, + int priority); #ifdef CONFIG_SHRINKER_DEBUG extern int shrinker_debugfs_add(struct shrinker *shrinker); diff --git a/mm/shrinker.c b/mm/shrinker.c new file mode 100644 index 000000000000..043c87ccfab4 --- /dev/null +++ b/mm/shrinker.c @@ -0,0 +1,709 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include +#include + +#include "internal.h" + +LIST_HEAD(shrinker_list); +DECLARE_RWSEM(shrinker_rwsem); + +#ifdef CONFIG_MEMCG +static int shrinker_nr_max; + +/* The shrinker_info is expanded in a batch of BITS_PER_LONG */ +static inline int shrinker_map_size(int nr_items) +{ + return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); +} + +static inline int shrinker_defer_size(int nr_items) +{ + return (round_up(nr_items, BITS_PER_LONG) * sizeof(atomic_long_t)); +} + +void free_shrinker_info(struct mem_cgroup *memcg) +{ + struct mem_cgroup_per_node *pn; + struct shrinker_info *info; + int nid; + + for_each_node(nid) { + pn = memcg->nodeinfo[nid]; + info = rcu_dereference_protected(pn->shrinker_info, true); + kvfree(info); + rcu_assign_pointer(pn->shrinker_info, NULL); + } +} + +int alloc_shrinker_info(struct mem_cgroup *memcg) +{ + struct shrinker_info *info; + int nid, size, ret = 0; + int map_size, defer_size = 0; + + down_write(&shrinker_rwsem); + map_size = shrinker_map_size(shrinker_nr_max); + defer_size = shrinker_defer_size(shrinker_nr_max); + size = map_size + defer_size; + for_each_node(nid) { + info = kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); + if (!info) { + free_shrinker_info(memcg); + ret = -ENOMEM; + break; + } + info->nr_deferred = (atomic_long_t *)(info + 1); + info->map = (void *)info->nr_deferred + defer_size; + info->map_nr_max = shrinker_nr_max; + rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); + } + up_write(&shrinker_rwsem); + + return ret; +} + +static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, + int nid) +{ + return rcu_dereference_protected(memcg->nodeinfo[nid]->shrinker_info, + lockdep_is_held(&shrinker_rwsem)); +} + +static int expand_one_shrinker_info(struct mem_cgroup *memcg, + int map_size, int defer_size, + int old_map_size, int old_defer_size, + int new_nr_max) +{ + struct shrinker_info *new, *old; + struct mem_cgroup_per_node *pn; + int nid; + int size = map_size + defer_size; + + for_each_node(nid) { + pn = memcg->nodeinfo[nid]; + old = shrinker_info_protected(memcg, nid); + /* Not yet online memcg */ + if (!old) + return 0; + + /* Already expanded this shrinker_info */ + if (new_nr_max <= old->map_nr_max) + continue; + + new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); + if (!new) + return -ENOMEM; + + new->nr_deferred = (atomic_long_t *)(new + 1); + new->map = (void *)new->nr_deferred + defer_size; + new->map_nr_max = new_nr_max; + + /* map: set all old bits, clear all new bits */ + memset(new->map, (int)0xff, old_map_size); + memset((void *)new->map + old_map_size, 0, map_size - old_map_size); + /* nr_deferred: copy old values, clear all new values */ + memcpy(new->nr_deferred, old->nr_deferred, old_defer_size); + memset((void *)new->nr_deferred + old_defer_size, 0, + defer_size - old_defer_size); + + rcu_assign_pointer(pn->shrinker_info, new); + kvfree_rcu(old, rcu); + } + + return 0; +} + +static int expand_shrinker_info(int new_id) +{ + int ret = 0; + int new_nr_max = round_up(new_id + 1, BITS_PER_LONG); + int map_size, defer_size = 0; + int old_map_size, old_defer_size = 0; + struct mem_cgroup *memcg; + + if (!root_mem_cgroup) + goto out; + + lockdep_assert_held(&shrinker_rwsem); + + map_size = shrinker_map_size(new_nr_max); + defer_size = shrinker_defer_size(new_nr_max); + old_map_size = shrinker_map_size(shrinker_nr_max); + old_defer_size = shrinker_defer_size(shrinker_nr_max); + + memcg = mem_cgroup_iter(NULL, NULL, NULL); + do { + ret = expand_one_shrinker_info(memcg, map_size, defer_size, + old_map_size, old_defer_size, + new_nr_max); + if (ret) { + mem_cgroup_iter_break(NULL, memcg); + goto out; + } + } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); +out: + if (!ret) + shrinker_nr_max = new_nr_max; + + return ret; +} + +void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) +{ + if (shrinker_id >= 0 && memcg && !mem_cgroup_is_root(memcg)) { + struct shrinker_info *info; + + rcu_read_lock(); + info = rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); + if (!WARN_ON_ONCE(shrinker_id >= info->map_nr_max)) { + /* Pairs with smp mb in shrink_slab() */ + smp_mb__before_atomic(); + set_bit(shrinker_id, info->map); + } + rcu_read_unlock(); + } +} + +static DEFINE_IDR(shrinker_idr); + +static int prealloc_memcg_shrinker(struct shrinker *shrinker) +{ + int id, ret = -ENOMEM; + + if (mem_cgroup_disabled()) + return -ENOSYS; + + down_write(&shrinker_rwsem); + /* This may call shrinker, so it must use down_read_trylock() */ + id = idr_alloc(&shrinker_idr, shrinker, 0, 0, GFP_KERNEL); + if (id < 0) + goto unlock; + + if (id >= shrinker_nr_max) { + if (expand_shrinker_info(id)) { + idr_remove(&shrinker_idr, id); + goto unlock; + } + } + shrinker->id = id; + ret = 0; +unlock: + up_write(&shrinker_rwsem); + return ret; +} + +static void unregister_memcg_shrinker(struct shrinker *shrinker) +{ + int id = shrinker->id; + + BUG_ON(id < 0); + + lockdep_assert_held(&shrinker_rwsem); + + idr_remove(&shrinker_idr, id); +} + +static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, + struct mem_cgroup *memcg) +{ + struct shrinker_info *info; + + info = shrinker_info_protected(memcg, nid); + return atomic_long_xchg(&info->nr_deferred[shrinker->id], 0); +} + +static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, + struct mem_cgroup *memcg) +{ + struct shrinker_info *info; + + info = shrinker_info_protected(memcg, nid); + return atomic_long_add_return(nr, &info->nr_deferred[shrinker->id]); +} + +void reparent_shrinker_deferred(struct mem_cgroup *memcg) +{ + int i, nid; + long nr; + struct mem_cgroup *parent; + struct shrinker_info *child_info, *parent_info; + + parent = parent_mem_cgroup(memcg); + if (!parent) + parent = root_mem_cgroup; + + /* Prevent from concurrent shrinker_info expand */ + down_read(&shrinker_rwsem); + for_each_node(nid) { + child_info = shrinker_info_protected(memcg, nid); + parent_info = shrinker_info_protected(parent, nid); + for (i = 0; i < child_info->map_nr_max; i++) { + nr = atomic_long_read(&child_info->nr_deferred[i]); + atomic_long_add(nr, &parent_info->nr_deferred[i]); + } + } + up_read(&shrinker_rwsem); +} +#else +static int prealloc_memcg_shrinker(struct shrinker *shrinker) +{ + return -ENOSYS; +} + +static void unregister_memcg_shrinker(struct shrinker *shrinker) +{ +} + +static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, + struct mem_cgroup *memcg) +{ + return 0; +} + +static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, + struct mem_cgroup *memcg) +{ + return 0; +} +#endif /* CONFIG_MEMCG */ + +static long xchg_nr_deferred(struct shrinker *shrinker, + struct shrink_control *sc) +{ + int nid = sc->nid; + + if (!(shrinker->flags & SHRINKER_NUMA_AWARE)) + nid = 0; + + if (sc->memcg && + (shrinker->flags & SHRINKER_MEMCG_AWARE)) + return xchg_nr_deferred_memcg(nid, shrinker, + sc->memcg); + + return atomic_long_xchg(&shrinker->nr_deferred[nid], 0); +} + + +static long add_nr_deferred(long nr, struct shrinker *shrinker, + struct shrink_control *sc) +{ + int nid = sc->nid; + + if (!(shrinker->flags & SHRINKER_NUMA_AWARE)) + nid = 0; + + if (sc->memcg && + (shrinker->flags & SHRINKER_MEMCG_AWARE)) + return add_nr_deferred_memcg(nr, nid, shrinker, + sc->memcg); + + return atomic_long_add_return(nr, &shrinker->nr_deferred[nid]); +} + +#define SHRINK_BATCH 128 + +static unsigned long do_shrink_slab(struct shrink_control *shrinkctl, + struct shrinker *shrinker, int priority) +{ + unsigned long freed = 0; + unsigned long long delta; + long total_scan; + long freeable; + long nr; + long new_nr; + long batch_size = shrinker->batch ? shrinker->batch + : SHRINK_BATCH; + long scanned = 0, next_deferred; + + freeable = shrinker->count_objects(shrinker, shrinkctl); + if (freeable == 0 || freeable == SHRINK_EMPTY) + return freeable; + + /* + * copy the current shrinker scan count into a local variable + * and zero it so that other concurrent shrinker invocations + * don't also do this scanning work. + */ + nr = xchg_nr_deferred(shrinker, shrinkctl); + + if (shrinker->seeks) { + delta = freeable >> priority; + delta *= 4; + do_div(delta, shrinker->seeks); + } else { + /* + * These objects don't require any IO to create. Trim + * them aggressively under memory pressure to keep + * them from causing refetches in the IO caches. + */ + delta = freeable / 2; + } + + total_scan = nr >> priority; + total_scan += delta; + total_scan = min(total_scan, (2 * freeable)); + + trace_mm_shrink_slab_start(shrinker, shrinkctl, nr, + freeable, delta, total_scan, priority); + + /* + * Normally, we should not scan less than batch_size objects in one + * pass to avoid too frequent shrinker calls, but if the slab has less + * than batch_size objects in total and we are really tight on memory, + * we will try to reclaim all available objects, otherwise we can end + * up failing allocations although there are plenty of reclaimable + * objects spread over several slabs with usage less than the + * batch_size. + * + * We detect the "tight on memory" situations by looking at the total + * number of objects we want to scan (total_scan). If it is greater + * than the total number of objects on slab (freeable), we must be + * scanning at high prio and therefore should try to reclaim as much as + * possible. + */ + while (total_scan >= batch_size || + total_scan >= freeable) { + unsigned long ret; + unsigned long nr_to_scan = min(batch_size, total_scan); + + shrinkctl->nr_to_scan = nr_to_scan; + shrinkctl->nr_scanned = nr_to_scan; + ret = shrinker->scan_objects(shrinker, shrinkctl); + if (ret == SHRINK_STOP) + break; + freed += ret; + + count_vm_events(SLABS_SCANNED, shrinkctl->nr_scanned); + total_scan -= shrinkctl->nr_scanned; + scanned += shrinkctl->nr_scanned; + + cond_resched(); + } + + /* + * The deferred work is increased by any new work (delta) that wasn't + * done, decreased by old deferred work that was done now. + * + * And it is capped to two times of the freeable items. + */ + next_deferred = max_t(long, (nr + delta - scanned), 0); + next_deferred = min(next_deferred, (2 * freeable)); + + /* + * move the unused scan count back into the shrinker in a + * manner that handles concurrent updates. + */ + new_nr = add_nr_deferred(next_deferred, shrinker, shrinkctl); + + trace_mm_shrink_slab_end(shrinker, shrinkctl->nid, freed, nr, new_nr, total_scan); + return freed; +} + +#ifdef CONFIG_MEMCG +static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, + struct mem_cgroup *memcg, int priority) +{ + struct shrinker_info *info; + unsigned long ret, freed = 0; + int i; + + if (!mem_cgroup_online(memcg)) + return 0; + + if (!down_read_trylock(&shrinker_rwsem)) + return 0; + + info = shrinker_info_protected(memcg, nid); + if (unlikely(!info)) + goto unlock; + + for_each_set_bit(i, info->map, info->map_nr_max) { + struct shrink_control sc = { + .gfp_mask = gfp_mask, + .nid = nid, + .memcg = memcg, + }; + struct shrinker *shrinker; + + shrinker = idr_find(&shrinker_idr, i); + if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { + if (!shrinker) + clear_bit(i, info->map); + continue; + } + + /* Call non-slab shrinkers even though kmem is disabled */ + if (!memcg_kmem_online() && + !(shrinker->flags & SHRINKER_NONSLAB)) + continue; + + ret = do_shrink_slab(&sc, shrinker, priority); + if (ret == SHRINK_EMPTY) { + clear_bit(i, info->map); + /* + * After the shrinker reported that it had no objects to + * free, but before we cleared the corresponding bit in + * the memcg shrinker map, a new object might have been + * added. To make sure, we have the bit set in this + * case, we invoke the shrinker one more time and reset + * the bit if it reports that it is not empty anymore. + * The memory barrier here pairs with the barrier in + * set_shrinker_bit(): + * + * list_lru_add() shrink_slab_memcg() + * list_add_tail() clear_bit() + * + * set_bit() do_shrink_slab() + */ + smp_mb__after_atomic(); + ret = do_shrink_slab(&sc, shrinker, priority); + if (ret == SHRINK_EMPTY) + ret = 0; + else + set_shrinker_bit(memcg, nid, i); + } + freed += ret; + + if (rwsem_is_contended(&shrinker_rwsem)) { + freed = freed ? : 1; + break; + } + } +unlock: + up_read(&shrinker_rwsem); + return freed; +} +#else /* !CONFIG_MEMCG */ +static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, + struct mem_cgroup *memcg, int priority) +{ + return 0; +} +#endif /* CONFIG_MEMCG */ + +/** + * shrink_slab - shrink slab caches + * @gfp_mask: allocation context + * @nid: node whose slab caches to target + * @memcg: memory cgroup whose slab caches to target + * @priority: the reclaim priority + * + * Call the shrink functions to age shrinkable caches. + * + * @nid is passed along to shrinkers with SHRINKER_NUMA_AWARE set, + * unaware shrinkers will receive a node id of 0 instead. + * + * @memcg specifies the memory cgroup to target. Unaware shrinkers + * are called only if it is the root cgroup. + * + * @priority is sc->priority, we take the number of objects and >> by priority + * in order to get the scan target. + * + * Returns the number of reclaimed slab objects. + */ +unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, + int priority) +{ + unsigned long ret, freed = 0; + struct shrinker *shrinker; + + /* + * The root memcg might be allocated even though memcg is disabled + * via "cgroup_disable=memory" boot parameter. This could make + * mem_cgroup_is_root() return false, then just run memcg slab + * shrink, but skip global shrink. This may result in premature + * oom. + */ + if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) + return shrink_slab_memcg(gfp_mask, nid, memcg, priority); + + if (!down_read_trylock(&shrinker_rwsem)) + goto out; + + list_for_each_entry(shrinker, &shrinker_list, list) { + struct shrink_control sc = { + .gfp_mask = gfp_mask, + .nid = nid, + .memcg = memcg, + }; + + ret = do_shrink_slab(&sc, shrinker, priority); + if (ret == SHRINK_EMPTY) + ret = 0; + freed += ret; + /* + * Bail out if someone want to register a new shrinker to + * prevent the registration from being stalled for long periods + * by parallel ongoing shrinking. + */ + if (rwsem_is_contended(&shrinker_rwsem)) { + freed = freed ? : 1; + break; + } + } + + up_read(&shrinker_rwsem); +out: + cond_resched(); + return freed; +} + +/* + * Add a shrinker callback to be called from the vm. + */ +static int __prealloc_shrinker(struct shrinker *shrinker) +{ + unsigned int size; + int err; + + if (shrinker->flags & SHRINKER_MEMCG_AWARE) { + err = prealloc_memcg_shrinker(shrinker); + if (err != -ENOSYS) + return err; + + shrinker->flags &= ~SHRINKER_MEMCG_AWARE; + } + + size = sizeof(*shrinker->nr_deferred); + if (shrinker->flags & SHRINKER_NUMA_AWARE) + size *= nr_node_ids; + + shrinker->nr_deferred = kzalloc(size, GFP_KERNEL); + if (!shrinker->nr_deferred) + return -ENOMEM; + + return 0; +} + +#ifdef CONFIG_SHRINKER_DEBUG +int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...) +{ + va_list ap; + int err; + + va_start(ap, fmt); + shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); + va_end(ap); + if (!shrinker->name) + return -ENOMEM; + + err = __prealloc_shrinker(shrinker); + if (err) { + kfree_const(shrinker->name); + shrinker->name = NULL; + } + + return err; +} +#else +int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...) +{ + return __prealloc_shrinker(shrinker); +} +#endif + +void free_prealloced_shrinker(struct shrinker *shrinker) +{ +#ifdef CONFIG_SHRINKER_DEBUG + kfree_const(shrinker->name); + shrinker->name = NULL; +#endif + if (shrinker->flags & SHRINKER_MEMCG_AWARE) { + down_write(&shrinker_rwsem); + unregister_memcg_shrinker(shrinker); + up_write(&shrinker_rwsem); + return; + } + + kfree(shrinker->nr_deferred); + shrinker->nr_deferred = NULL; +} + +void register_shrinker_prepared(struct shrinker *shrinker) +{ + down_write(&shrinker_rwsem); + list_add_tail(&shrinker->list, &shrinker_list); + shrinker->flags |= SHRINKER_REGISTERED; + shrinker_debugfs_add(shrinker); + up_write(&shrinker_rwsem); +} + +static int __register_shrinker(struct shrinker *shrinker) +{ + int err = __prealloc_shrinker(shrinker); + + if (err) + return err; + register_shrinker_prepared(shrinker); + return 0; +} + +#ifdef CONFIG_SHRINKER_DEBUG +int register_shrinker(struct shrinker *shrinker, const char *fmt, ...) +{ + va_list ap; + int err; + + va_start(ap, fmt); + shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); + va_end(ap); + if (!shrinker->name) + return -ENOMEM; + + err = __register_shrinker(shrinker); + if (err) { + kfree_const(shrinker->name); + shrinker->name = NULL; + } + return err; +} +#else +int register_shrinker(struct shrinker *shrinker, const char *fmt, ...) +{ + return __register_shrinker(shrinker); +} +#endif +EXPORT_SYMBOL(register_shrinker); + +/* + * Remove one + */ +void unregister_shrinker(struct shrinker *shrinker) +{ + struct dentry *debugfs_entry; + int debugfs_id; + + if (!(shrinker->flags & SHRINKER_REGISTERED)) + return; + + down_write(&shrinker_rwsem); + list_del(&shrinker->list); + shrinker->flags &= ~SHRINKER_REGISTERED; + if (shrinker->flags & SHRINKER_MEMCG_AWARE) + unregister_memcg_shrinker(shrinker); + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); + up_write(&shrinker_rwsem); + + shrinker_debugfs_remove(debugfs_entry, debugfs_id); + + kfree(shrinker->nr_deferred); + shrinker->nr_deferred = NULL; +} +EXPORT_SYMBOL(unregister_shrinker); + +/** + * synchronize_shrinkers - Wait for all running shrinkers to complete. + * + * This is equivalent to calling unregister_shrink() and register_shrinker(), + * but atomically and with less overhead. This is useful to guarantee that all + * shrinker invocations have seen an update, before freeing memory, similar to + * rcu. + */ +void synchronize_shrinkers(void) +{ + down_write(&shrinker_rwsem); + up_write(&shrinker_rwsem); +} +EXPORT_SYMBOL(synchronize_shrinkers); diff --git a/mm/vmscan.c b/mm/vmscan.c index 80e9a222e522..0a0f4c2fd519 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -35,7 +35,6 @@ #include #include #include -#include #include #include #include @@ -188,246 +187,7 @@ struct scan_control { */ int vm_swappiness = 60; -LIST_HEAD(shrinker_list); -DECLARE_RWSEM(shrinker_rwsem); - #ifdef CONFIG_MEMCG -static int shrinker_nr_max; - -/* The shrinker_info is expanded in a batch of BITS_PER_LONG */ -static inline int shrinker_map_size(int nr_items) -{ - return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); -} - -static inline int shrinker_defer_size(int nr_items) -{ - return (round_up(nr_items, BITS_PER_LONG) * sizeof(atomic_long_t)); -} - -static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, - int nid) -{ - return rcu_dereference_protected(memcg->nodeinfo[nid]->shrinker_info, - lockdep_is_held(&shrinker_rwsem)); -} - -static int expand_one_shrinker_info(struct mem_cgroup *memcg, - int map_size, int defer_size, - int old_map_size, int old_defer_size, - int new_nr_max) -{ - struct shrinker_info *new, *old; - struct mem_cgroup_per_node *pn; - int nid; - int size = map_size + defer_size; - - for_each_node(nid) { - pn = memcg->nodeinfo[nid]; - old = shrinker_info_protected(memcg, nid); - /* Not yet online memcg */ - if (!old) - return 0; - - /* Already expanded this shrinker_info */ - if (new_nr_max <= old->map_nr_max) - continue; - - new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); - if (!new) - return -ENOMEM; - - new->nr_deferred = (atomic_long_t *)(new + 1); - new->map = (void *)new->nr_deferred + defer_size; - new->map_nr_max = new_nr_max; - - /* map: set all old bits, clear all new bits */ - memset(new->map, (int)0xff, old_map_size); - memset((void *)new->map + old_map_size, 0, map_size - old_map_size); - /* nr_deferred: copy old values, clear all new values */ - memcpy(new->nr_deferred, old->nr_deferred, old_defer_size); - memset((void *)new->nr_deferred + old_defer_size, 0, - defer_size - old_defer_size); - - rcu_assign_pointer(pn->shrinker_info, new); - kvfree_rcu(old, rcu); - } - - return 0; -} - -void free_shrinker_info(struct mem_cgroup *memcg) -{ - struct mem_cgroup_per_node *pn; - struct shrinker_info *info; - int nid; - - for_each_node(nid) { - pn = memcg->nodeinfo[nid]; - info = rcu_dereference_protected(pn->shrinker_info, true); - kvfree(info); - rcu_assign_pointer(pn->shrinker_info, NULL); - } -} - -int alloc_shrinker_info(struct mem_cgroup *memcg) -{ - struct shrinker_info *info; - int nid, size, ret = 0; - int map_size, defer_size = 0; - - down_write(&shrinker_rwsem); - map_size = shrinker_map_size(shrinker_nr_max); - defer_size = shrinker_defer_size(shrinker_nr_max); - size = map_size + defer_size; - for_each_node(nid) { - info = kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); - if (!info) { - free_shrinker_info(memcg); - ret = -ENOMEM; - break; - } - info->nr_deferred = (atomic_long_t *)(info + 1); - info->map = (void *)info->nr_deferred + defer_size; - info->map_nr_max = shrinker_nr_max; - rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); - } - up_write(&shrinker_rwsem); - - return ret; -} - -static int expand_shrinker_info(int new_id) -{ - int ret = 0; - int new_nr_max = round_up(new_id + 1, BITS_PER_LONG); - int map_size, defer_size = 0; - int old_map_size, old_defer_size = 0; - struct mem_cgroup *memcg; - - if (!root_mem_cgroup) - goto out; - - lockdep_assert_held(&shrinker_rwsem); - - map_size = shrinker_map_size(new_nr_max); - defer_size = shrinker_defer_size(new_nr_max); - old_map_size = shrinker_map_size(shrinker_nr_max); - old_defer_size = shrinker_defer_size(shrinker_nr_max); - - memcg = mem_cgroup_iter(NULL, NULL, NULL); - do { - ret = expand_one_shrinker_info(memcg, map_size, defer_size, - old_map_size, old_defer_size, - new_nr_max); - if (ret) { - mem_cgroup_iter_break(NULL, memcg); - goto out; - } - } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); -out: - if (!ret) - shrinker_nr_max = new_nr_max; - - return ret; -} - -void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) -{ - if (shrinker_id >= 0 && memcg && !mem_cgroup_is_root(memcg)) { - struct shrinker_info *info; - - rcu_read_lock(); - info = rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); - if (!WARN_ON_ONCE(shrinker_id >= info->map_nr_max)) { - /* Pairs with smp mb in shrink_slab() */ - smp_mb__before_atomic(); - set_bit(shrinker_id, info->map); - } - rcu_read_unlock(); - } -} - -static DEFINE_IDR(shrinker_idr); - -static int prealloc_memcg_shrinker(struct shrinker *shrinker) -{ - int id, ret = -ENOMEM; - - if (mem_cgroup_disabled()) - return -ENOSYS; - - down_write(&shrinker_rwsem); - /* This may call shrinker, so it must use down_read_trylock() */ - id = idr_alloc(&shrinker_idr, shrinker, 0, 0, GFP_KERNEL); - if (id < 0) - goto unlock; - - if (id >= shrinker_nr_max) { - if (expand_shrinker_info(id)) { - idr_remove(&shrinker_idr, id); - goto unlock; - } - } - shrinker->id = id; - ret = 0; -unlock: - up_write(&shrinker_rwsem); - return ret; -} - -static void unregister_memcg_shrinker(struct shrinker *shrinker) -{ - int id = shrinker->id; - - BUG_ON(id < 0); - - lockdep_assert_held(&shrinker_rwsem); - - idr_remove(&shrinker_idr, id); -} - -static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, - struct mem_cgroup *memcg) -{ - struct shrinker_info *info; - - info = shrinker_info_protected(memcg, nid); - return atomic_long_xchg(&info->nr_deferred[shrinker->id], 0); -} - -static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, - struct mem_cgroup *memcg) -{ - struct shrinker_info *info; - - info = shrinker_info_protected(memcg, nid); - return atomic_long_add_return(nr, &info->nr_deferred[shrinker->id]); -} - -void reparent_shrinker_deferred(struct mem_cgroup *memcg) -{ - int i, nid; - long nr; - struct mem_cgroup *parent; - struct shrinker_info *child_info, *parent_info; - - parent = parent_mem_cgroup(memcg); - if (!parent) - parent = root_mem_cgroup; - - /* Prevent from concurrent shrinker_info expand */ - down_read(&shrinker_rwsem); - for_each_node(nid) { - child_info = shrinker_info_protected(memcg, nid); - parent_info = shrinker_info_protected(parent, nid); - for (i = 0; i < child_info->map_nr_max; i++) { - nr = atomic_long_read(&child_info->nr_deferred[i]); - atomic_long_add(nr, &parent_info->nr_deferred[i]); - } - } - up_read(&shrinker_rwsem); -} /* Returns true for reclaim through cgroup limits or cgroup interfaces. */ static bool cgroup_reclaim(struct scan_control *sc) @@ -468,27 +228,6 @@ static bool writeback_throttling_sane(struct scan_control *sc) return false; } #else -static int prealloc_memcg_shrinker(struct shrinker *shrinker) -{ - return -ENOSYS; -} - -static void unregister_memcg_shrinker(struct shrinker *shrinker) -{ -} - -static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, - struct mem_cgroup *memcg) -{ - return 0; -} - -static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, - struct mem_cgroup *memcg) -{ - return 0; -} - static bool cgroup_reclaim(struct scan_control *sc) { return false; @@ -557,39 +296,6 @@ static void flush_reclaim_state(struct scan_control *sc) } } -static long xchg_nr_deferred(struct shrinker *shrinker, - struct shrink_control *sc) -{ - int nid = sc->nid; - - if (!(shrinker->flags & SHRINKER_NUMA_AWARE)) - nid = 0; - - if (sc->memcg && - (shrinker->flags & SHRINKER_MEMCG_AWARE)) - return xchg_nr_deferred_memcg(nid, shrinker, - sc->memcg); - - return atomic_long_xchg(&shrinker->nr_deferred[nid], 0); -} - - -static long add_nr_deferred(long nr, struct shrinker *shrinker, - struct shrink_control *sc) -{ - int nid = sc->nid; - - if (!(shrinker->flags & SHRINKER_NUMA_AWARE)) - nid = 0; - - if (sc->memcg && - (shrinker->flags & SHRINKER_MEMCG_AWARE)) - return add_nr_deferred_memcg(nr, nid, shrinker, - sc->memcg); - - return atomic_long_add_return(nr, &shrinker->nr_deferred[nid]); -} - static bool can_demote(int nid, struct scan_control *sc) { if (!numa_demotion_enabled) @@ -671,413 +377,6 @@ static unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, return size; } -/* - * Add a shrinker callback to be called from the vm. - */ -static int __prealloc_shrinker(struct shrinker *shrinker) -{ - unsigned int size; - int err; - - if (shrinker->flags & SHRINKER_MEMCG_AWARE) { - err = prealloc_memcg_shrinker(shrinker); - if (err != -ENOSYS) - return err; - - shrinker->flags &= ~SHRINKER_MEMCG_AWARE; - } - - size = sizeof(*shrinker->nr_deferred); - if (shrinker->flags & SHRINKER_NUMA_AWARE) - size *= nr_node_ids; - - shrinker->nr_deferred = kzalloc(size, GFP_KERNEL); - if (!shrinker->nr_deferred) - return -ENOMEM; - - return 0; -} - -#ifdef CONFIG_SHRINKER_DEBUG -int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - va_list ap; - int err; - - va_start(ap, fmt); - shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); - va_end(ap); - if (!shrinker->name) - return -ENOMEM; - - err = __prealloc_shrinker(shrinker); - if (err) { - kfree_const(shrinker->name); - shrinker->name = NULL; - } - - return err; -} -#else -int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - return __prealloc_shrinker(shrinker); -} -#endif - -void free_prealloced_shrinker(struct shrinker *shrinker) -{ -#ifdef CONFIG_SHRINKER_DEBUG - kfree_const(shrinker->name); - shrinker->name = NULL; -#endif - if (shrinker->flags & SHRINKER_MEMCG_AWARE) { - down_write(&shrinker_rwsem); - unregister_memcg_shrinker(shrinker); - up_write(&shrinker_rwsem); - return; - } - - kfree(shrinker->nr_deferred); - shrinker->nr_deferred = NULL; -} - -void register_shrinker_prepared(struct shrinker *shrinker) -{ - down_write(&shrinker_rwsem); - list_add_tail(&shrinker->list, &shrinker_list); - shrinker->flags |= SHRINKER_REGISTERED; - shrinker_debugfs_add(shrinker); - up_write(&shrinker_rwsem); -} - -static int __register_shrinker(struct shrinker *shrinker) -{ - int err = __prealloc_shrinker(shrinker); - - if (err) - return err; - register_shrinker_prepared(shrinker); - return 0; -} - -#ifdef CONFIG_SHRINKER_DEBUG -int register_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - va_list ap; - int err; - - va_start(ap, fmt); - shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); - va_end(ap); - if (!shrinker->name) - return -ENOMEM; - - err = __register_shrinker(shrinker); - if (err) { - kfree_const(shrinker->name); - shrinker->name = NULL; - } - return err; -} -#else -int register_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - return __register_shrinker(shrinker); -} -#endif -EXPORT_SYMBOL(register_shrinker); - -/* - * Remove one - */ -void unregister_shrinker(struct shrinker *shrinker) -{ - struct dentry *debugfs_entry; - int debugfs_id; - - if (!(shrinker->flags & SHRINKER_REGISTERED)) - return; - - down_write(&shrinker_rwsem); - list_del(&shrinker->list); - shrinker->flags &= ~SHRINKER_REGISTERED; - if (shrinker->flags & SHRINKER_MEMCG_AWARE) - unregister_memcg_shrinker(shrinker); - debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); - up_write(&shrinker_rwsem); - - shrinker_debugfs_remove(debugfs_entry, debugfs_id); - - kfree(shrinker->nr_deferred); - shrinker->nr_deferred = NULL; -} -EXPORT_SYMBOL(unregister_shrinker); - -/** - * synchronize_shrinkers - Wait for all running shrinkers to complete. - * - * This is equivalent to calling unregister_shrink() and register_shrinker(), - * but atomically and with less overhead. This is useful to guarantee that all - * shrinker invocations have seen an update, before freeing memory, similar to - * rcu. - */ -void synchronize_shrinkers(void) -{ - down_write(&shrinker_rwsem); - up_write(&shrinker_rwsem); -} -EXPORT_SYMBOL(synchronize_shrinkers); - -#define SHRINK_BATCH 128 - -static unsigned long do_shrink_slab(struct shrink_control *shrinkctl, - struct shrinker *shrinker, int priority) -{ - unsigned long freed = 0; - unsigned long long delta; - long total_scan; - long freeable; - long nr; - long new_nr; - long batch_size = shrinker->batch ? shrinker->batch - : SHRINK_BATCH; - long scanned = 0, next_deferred; - - freeable = shrinker->count_objects(shrinker, shrinkctl); - if (freeable == 0 || freeable == SHRINK_EMPTY) - return freeable; - - /* - * copy the current shrinker scan count into a local variable - * and zero it so that other concurrent shrinker invocations - * don't also do this scanning work. - */ - nr = xchg_nr_deferred(shrinker, shrinkctl); - - if (shrinker->seeks) { - delta = freeable >> priority; - delta *= 4; - do_div(delta, shrinker->seeks); - } else { - /* - * These objects don't require any IO to create. Trim - * them aggressively under memory pressure to keep - * them from causing refetches in the IO caches. - */ - delta = freeable / 2; - } - - total_scan = nr >> priority; - total_scan += delta; - total_scan = min(total_scan, (2 * freeable)); - - trace_mm_shrink_slab_start(shrinker, shrinkctl, nr, - freeable, delta, total_scan, priority); - - /* - * Normally, we should not scan less than batch_size objects in one - * pass to avoid too frequent shrinker calls, but if the slab has less - * than batch_size objects in total and we are really tight on memory, - * we will try to reclaim all available objects, otherwise we can end - * up failing allocations although there are plenty of reclaimable - * objects spread over several slabs with usage less than the - * batch_size. - * - * We detect the "tight on memory" situations by looking at the total - * number of objects we want to scan (total_scan). If it is greater - * than the total number of objects on slab (freeable), we must be - * scanning at high prio and therefore should try to reclaim as much as - * possible. - */ - while (total_scan >= batch_size || - total_scan >= freeable) { - unsigned long ret; - unsigned long nr_to_scan = min(batch_size, total_scan); - - shrinkctl->nr_to_scan = nr_to_scan; - shrinkctl->nr_scanned = nr_to_scan; - ret = shrinker->scan_objects(shrinker, shrinkctl); - if (ret == SHRINK_STOP) - break; - freed += ret; - - count_vm_events(SLABS_SCANNED, shrinkctl->nr_scanned); - total_scan -= shrinkctl->nr_scanned; - scanned += shrinkctl->nr_scanned; - - cond_resched(); - } - - /* - * The deferred work is increased by any new work (delta) that wasn't - * done, decreased by old deferred work that was done now. - * - * And it is capped to two times of the freeable items. - */ - next_deferred = max_t(long, (nr + delta - scanned), 0); - next_deferred = min(next_deferred, (2 * freeable)); - - /* - * move the unused scan count back into the shrinker in a - * manner that handles concurrent updates. - */ - new_nr = add_nr_deferred(next_deferred, shrinker, shrinkctl); - - trace_mm_shrink_slab_end(shrinker, shrinkctl->nid, freed, nr, new_nr, total_scan); - return freed; -} - -#ifdef CONFIG_MEMCG -static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, - struct mem_cgroup *memcg, int priority) -{ - struct shrinker_info *info; - unsigned long ret, freed = 0; - int i; - - if (!mem_cgroup_online(memcg)) - return 0; - - if (!down_read_trylock(&shrinker_rwsem)) - return 0; - - info = shrinker_info_protected(memcg, nid); - if (unlikely(!info)) - goto unlock; - - for_each_set_bit(i, info->map, info->map_nr_max) { - struct shrink_control sc = { - .gfp_mask = gfp_mask, - .nid = nid, - .memcg = memcg, - }; - struct shrinker *shrinker; - - shrinker = idr_find(&shrinker_idr, i); - if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { - if (!shrinker) - clear_bit(i, info->map); - continue; - } - - /* Call non-slab shrinkers even though kmem is disabled */ - if (!memcg_kmem_online() && - !(shrinker->flags & SHRINKER_NONSLAB)) - continue; - - ret = do_shrink_slab(&sc, shrinker, priority); - if (ret == SHRINK_EMPTY) { - clear_bit(i, info->map); - /* - * After the shrinker reported that it had no objects to - * free, but before we cleared the corresponding bit in - * the memcg shrinker map, a new object might have been - * added. To make sure, we have the bit set in this - * case, we invoke the shrinker one more time and reset - * the bit if it reports that it is not empty anymore. - * The memory barrier here pairs with the barrier in - * set_shrinker_bit(): - * - * list_lru_add() shrink_slab_memcg() - * list_add_tail() clear_bit() - * - * set_bit() do_shrink_slab() - */ - smp_mb__after_atomic(); - ret = do_shrink_slab(&sc, shrinker, priority); - if (ret == SHRINK_EMPTY) - ret = 0; - else - set_shrinker_bit(memcg, nid, i); - } - freed += ret; - - if (rwsem_is_contended(&shrinker_rwsem)) { - freed = freed ? : 1; - break; - } - } -unlock: - up_read(&shrinker_rwsem); - return freed; -} -#else /* CONFIG_MEMCG */ -static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, - struct mem_cgroup *memcg, int priority) -{ - return 0; -} -#endif /* CONFIG_MEMCG */ - -/** - * shrink_slab - shrink slab caches - * @gfp_mask: allocation context - * @nid: node whose slab caches to target - * @memcg: memory cgroup whose slab caches to target - * @priority: the reclaim priority - * - * Call the shrink functions to age shrinkable caches. - * - * @nid is passed along to shrinkers with SHRINKER_NUMA_AWARE set, - * unaware shrinkers will receive a node id of 0 instead. - * - * @memcg specifies the memory cgroup to target. Unaware shrinkers - * are called only if it is the root cgroup. - * - * @priority is sc->priority, we take the number of objects and >> by priority - * in order to get the scan target. - * - * Returns the number of reclaimed slab objects. - */ -static unsigned long shrink_slab(gfp_t gfp_mask, int nid, - struct mem_cgroup *memcg, - int priority) -{ - unsigned long ret, freed = 0; - struct shrinker *shrinker; - - /* - * The root memcg might be allocated even though memcg is disabled - * via "cgroup_disable=memory" boot parameter. This could make - * mem_cgroup_is_root() return false, then just run memcg slab - * shrink, but skip global shrink. This may result in premature - * oom. - */ - if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) - return shrink_slab_memcg(gfp_mask, nid, memcg, priority); - - if (!down_read_trylock(&shrinker_rwsem)) - goto out; - - list_for_each_entry(shrinker, &shrinker_list, list) { - struct shrink_control sc = { - .gfp_mask = gfp_mask, - .nid = nid, - .memcg = memcg, - }; - - ret = do_shrink_slab(&sc, shrinker, priority); - if (ret == SHRINK_EMPTY) - ret = 0; - freed += ret; - /* - * Bail out if someone want to register a new shrinker to - * prevent the registration from being stalled for long periods - * by parallel ongoing shrinking. - */ - if (rwsem_is_contended(&shrinker_rwsem)) { - freed = freed ? : 1; - break; - } - } - - up_read(&shrinker_rwsem); -out: - cond_resched(); - return freed; -} - static unsigned long drop_slab_node(int nid) { unsigned long freed = 0; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:10:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:10:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578021.905221 (Exim 4.92) (envelope-from ) id 1qSy8F-0003D4-Um; Mon, 07 Aug 2023 11:10:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578021.905221; Mon, 07 Aug 2023 11:10:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8F-0003Ct-RF; Mon, 07 Aug 2023 11:10:39 +0000 Received: by outflank-mailman (input) for mailman id 578021; Mon, 07 Aug 2023 11:10:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8E-00018O-FO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:10:38 +0000 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [2607:f8b0:4864:20::1032]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08795e1e-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:10:36 +0200 (CEST) Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-265c94064b8so592316a91.0 for ; Mon, 07 Aug 2023 04:10:36 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:10:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08795e1e-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406635; x=1692011435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v13l7IPlOPgFsnMxGKXfyNRR5BVZeBzBNEaAsOIHoYU=; b=kCYTaRcfjrYSEt8G3Tw1f1acTO5J6yxn7oF0SsGLa85MduwVEgH5omvSEO969tp3LA wpvSUu2A7//qJL2ilMqNB9PtHKQAFVNRC9oXX6TEGsUMhNv4mOxpl2C1YAZnVZpulCYe yLDYKwIJ4bAvkX2QuqtJJDYUJRh6vr19t7PfH+lhQ++ji8JDwdveN3FzqnpipfKLqAIG dvafeOsYb5J4XciY9gtlA1gSl238AIRfFhWaOJMr5WdeT5BLHH+Cl6s3+MJ/6Htxm+Cq sbYQtf3+i0mELZ2fQ4kGZP1NFS47ge8l8Znqj7GoIxgmAjgbPULzYpOui4TUq64XmvYi qgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406635; x=1692011435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v13l7IPlOPgFsnMxGKXfyNRR5BVZeBzBNEaAsOIHoYU=; b=BQr7jKZ1IDWxVHHkDPJp24To0eBRjmyJugf5n8WMP2T4jq2NDeB7CVqaoQJYjSGkiE skMxVqkSwLkpEe3bvbU+XnbzcgtLJH3xs8p9ITIPQDpFwOYdkc9T2gpqvLOBl2ceIthG 3mFtonx1L1SMynR/XBlhjLCu24rCkMWCOdKsniiTwNWl3Ns2NrvybBra6tKtyjKuA/UN +7OJr7ncvzqPlv3nvrctJn9EJm5fqEi1Atiz8Bmm2kAbKgCwI5qzniWvA0SZ6iE6jYzC jR5Bwc5cu/dk5DPP8i7jh4Mqwl64OUEpRWqTL521uRx82Lk5fASAEyTQynYkgGP+g8lO Keww== X-Gm-Message-State: AOJu0YwjNX2krhjp5i17Vr/LRKf6t1qzLbXpWyEoxIYaLrLx29Jwae9G /D/PbTf+1S3RTkP/gORw6X7/Fw== X-Google-Smtp-Source: AGHT+IFtRmyHpiiF2qszY30g7vYVkD2mnACy5d4vfrtyjmwLjyswWFf77Xamslud93nGDOipc3oAlA== X-Received: by 2002:a17:90a:69c4:b0:269:34a6:d4ca with SMTP id s62-20020a17090a69c400b0026934a6d4camr6363728pjj.0.1691406635181; Mon, 07 Aug 2023 04:10:35 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 03/48] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations Date: Mon, 7 Aug 2023 19:08:51 +0800 Message-Id: <20230807110936.21819-4-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The debugfs_remove_recursive() will wait for debugfs_file_put() to return, so the shrinker will not be freed when doing debugfs operations (such as shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there is no need to hold shrinker_rwsem during debugfs operations. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- mm/shrinker_debug.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c index 3ab53fad8876..61702bdc1af4 100644 --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -49,17 +49,12 @@ static int shrinker_debugfs_count_show(struct seq_file *m, void *v) struct mem_cgroup *memcg; unsigned long total; bool memcg_aware; - int ret, nid; + int ret = 0, nid; count_per_node = kcalloc(nr_node_ids, sizeof(unsigned long), GFP_KERNEL); if (!count_per_node) return -ENOMEM; - ret = down_read_killable(&shrinker_rwsem); - if (ret) { - kfree(count_per_node); - return ret; - } rcu_read_lock(); memcg_aware = shrinker->flags & SHRINKER_MEMCG_AWARE; @@ -92,7 +87,6 @@ static int shrinker_debugfs_count_show(struct seq_file *m, void *v) } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); rcu_read_unlock(); - up_read(&shrinker_rwsem); kfree(count_per_node); return ret; @@ -117,7 +111,6 @@ static ssize_t shrinker_debugfs_scan_write(struct file *file, struct mem_cgroup *memcg = NULL; int nid; char kbuf[72]; - ssize_t ret; read_len = size < (sizeof(kbuf) - 1) ? size : (sizeof(kbuf) - 1); if (copy_from_user(kbuf, buf, read_len)) @@ -146,12 +139,6 @@ static ssize_t shrinker_debugfs_scan_write(struct file *file, return -EINVAL; } - ret = down_read_killable(&shrinker_rwsem); - if (ret) { - mem_cgroup_put(memcg); - return ret; - } - sc.nid = nid; sc.memcg = memcg; sc.nr_to_scan = nr_to_scan; @@ -159,7 +146,6 @@ static ssize_t shrinker_debugfs_scan_write(struct file *file, shrinker->scan_objects(shrinker, &sc); - up_read(&shrinker_rwsem); mem_cgroup_put(memcg); return size; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:10:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:10:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578024.905230 (Exim 4.92) (envelope-from ) id 1qSy8S-0003lu-5p; Mon, 07 Aug 2023 11:10:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578024.905230; Mon, 07 Aug 2023 11:10:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8S-0003ll-3B; Mon, 07 Aug 2023 11:10:52 +0000 Received: by outflank-mailman (input) for mailman id 578024; Mon, 07 Aug 2023 11:10:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8Q-00018O-UP for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:10:50 +0000 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [2607:f8b0:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0fd787bf-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:10:49 +0200 (CEST) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bb91c20602so9340965ad.0 for ; Mon, 07 Aug 2023 04:10:49 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:10:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fd787bf-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406647; x=1692011447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0+ir4b8RJjPS6OIbAMeQuS4120VPLjqRz3YtsLadct8=; b=XqSgm7kBpeCnE2gk/ybefyIcAxePmTjaifDT0pHnXDcb/Nc/UeCuy/rdgy4xRowAkQ aP4dUp/hrUWHR/4zWDCrbxFRixmFOlV8pnAOQyS1AwDBmMy6PTOmr3iG0yKzCbxujje0 t73ctUmXR29afAKI5JNarlJvM1vvoPYY3cx3UcuU87ePLchKbMsLak0/Jvs9wqFUCDZe F5bgU4otH0OCdVxWD0sXM2a1eraAUukOoDwvlCcB8mzgk3iB2I7g5XjW4+48PuHaFgCc uOLaUcpy4QuZWt68WuxcqsF9z/vzQ2XOsuEa2jtvaGJ4t8kUtmd0Q7Uf/YTK0wRowRTP E2tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406647; x=1692011447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0+ir4b8RJjPS6OIbAMeQuS4120VPLjqRz3YtsLadct8=; b=i8mZs1gz7ZmCxLXvogoNIVcg8Z03aVRXerGbvv8Xas/PBV3GGsR+ZvRvWOTcIwYhct afDTKlU75GjVIpS3GggQyWiOtxU8earZlFGe5VY4cbYUUb13VYeiVa7WjIjm15bOS2u9 baujNu1QiMbn6T9X6U6/5yiioFIafFK8hO8V7EwjBWc83h8WeRFKNF1yeCQPDLTNQ0rx r/d8o9PbWi5JDt3aQftnoMy0mWlFD0OgYId7xvMjaN50GyqO8k6Xy3jQZV2HaY+sdiNz PRcppTufJSNEzHHmONJOeXymdStQfzGTv+k9IxNQyVbCPzwln11GhYwzQmSgthTH9MAm T2/w== X-Gm-Message-State: ABy/qLY/afL3U2dnDHK9CV1J+SQWnrFoMZPAVieJpNn5PwI2kgq4YTwx kE92eX/+6zR1Q85J7ENA3P8RDg== X-Google-Smtp-Source: APBJJlHuLqAtKowl4cccNcqjA9V94U7s0kNn49/V0/tk7bu/NPlYiQpbpDIicm2vAutfhjwO22jVoA== X-Received: by 2002:a17:902:f54d:b0:1b8:9fc4:2733 with SMTP id h13-20020a170902f54d00b001b89fc42733mr32837074plf.3.1691406647588; Mon, 07 Aug 2023 04:10:47 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 04/48] mm: shrinker: add infrastructure for dynamically allocating shrinker Date: Mon, 7 Aug 2023 19:08:52 +0800 Message-Id: <20230807110936.21819-5-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, the shrinker instances can be divided into the following three types: a) global shrinker instance statically defined in the kernel, such as workingset_shadow_shrinker. b) global shrinker instance statically defined in the kernel modules, such as mmu_shrinker in x86. c) shrinker instance embedded in other structures. For case a, the memory of shrinker instance is never freed. For case b, the memory of shrinker instance will be freed after synchronize_rcu() when the module is unloaded. For case c, the memory of shrinker instance will be freed along with the structure it is embedded in. In preparation for implementing lockless slab shrink, we need to dynamically allocate those shrinker instances in case c, then the memory can be dynamically freed alone by calling kfree_rcu(). So this commit adds the following new APIs for dynamically allocating shrinker, and add a private_data field to struct shrinker to record and get the original embedded structure. 1. shrinker_alloc() Used to allocate shrinker instance itself and related memory, it will return a pointer to the shrinker instance on success and NULL on failure. 2. shrinker_register() Used to register the shrinker instance, which is same as the current register_shrinker_prepared(). 3. shrinker_free() Used to unregister (if needed) and free the shrinker instance. In order to simplify shrinker-related APIs and make shrinker more independent of other kernel mechanisms, subsequent submissions will use the above API to convert all shrinkers (including case a and b) to dynamically allocated, and then remove all existing APIs. This will also have another advantage mentioned by Dave Chinner: ``` The other advantage of this is that it will break all the existing out of tree code and third party modules using the old API and will no longer work with a kernel using lockless slab shrinkers. They need to break (both at the source and binary levels) to stop bad things from happening due to using unconverted shrinkers in the new setup. ``` Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 7 +++ mm/internal.h | 11 +++++ mm/shrinker.c | 101 +++++++++++++++++++++++++++++++++++++++ mm/shrinker_debug.c | 17 ++++++- 4 files changed, 134 insertions(+), 2 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 8dc15aa37410..cc23ff0aee20 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -70,6 +70,8 @@ struct shrinker { int seeks; /* seeks to recreate an obj */ unsigned flags; + void *private_data; + /* These are for internal use */ struct list_head list; #ifdef CONFIG_MEMCG @@ -95,6 +97,11 @@ struct shrinker { * non-MEMCG_AWARE shrinker should not have this flag set. */ #define SHRINKER_NONSLAB (1 << 3) +#define SHRINKER_ALLOCATED (1 << 4) + +struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); +void shrinker_register(struct shrinker *shrinker); +void shrinker_free(struct shrinker *shrinker); extern int __printf(2, 3) prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...); diff --git a/mm/internal.h b/mm/internal.h index b98c29f0a471..7b882b903b82 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1152,6 +1152,9 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, #ifdef CONFIG_SHRINKER_DEBUG extern int shrinker_debugfs_add(struct shrinker *shrinker); +extern int shrinker_debugfs_name_alloc(struct shrinker *shrinker, + const char *fmt, va_list ap); +extern void shrinker_debugfs_name_free(struct shrinker *shrinker); extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, int *debugfs_id); extern void shrinker_debugfs_remove(struct dentry *debugfs_entry, @@ -1161,6 +1164,14 @@ static inline int shrinker_debugfs_add(struct shrinker *shrinker) { return 0; } +static inline int shrinker_debugfs_name_alloc(struct shrinker *shrinker, + const char *fmt, va_list ap) +{ + return 0; +} +static inline void shrinker_debugfs_name_free(struct shrinker *shrinker) +{ +} static inline struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, int *debugfs_id) { diff --git a/mm/shrinker.c b/mm/shrinker.c index 043c87ccfab4..43a375f954f3 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -550,6 +550,107 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, return freed; } +struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...) +{ + struct shrinker *shrinker; + unsigned int size; + va_list ap; + int err; + + shrinker = kzalloc(sizeof(struct shrinker), GFP_KERNEL); + if (!shrinker) + return NULL; + + va_start(ap, fmt); + err = shrinker_debugfs_name_alloc(shrinker, fmt, ap); + va_end(ap); + if (err) + goto err_name; + + shrinker->flags = flags | SHRINKER_ALLOCATED; + + if (flags & SHRINKER_MEMCG_AWARE) { + err = prealloc_memcg_shrinker(shrinker); + if (err == -ENOSYS) + shrinker->flags &= ~SHRINKER_MEMCG_AWARE; + else if (err == 0) + goto done; + else + goto err_flags; + } + + /* + * The nr_deferred is available on per memcg level for memcg aware + * shrinkers, so only allocate nr_deferred in the following cases: + * - non memcg aware shrinkers + * - !CONFIG_MEMCG + * - memcg is disabled by kernel command line + */ + size = sizeof(*shrinker->nr_deferred); + if (flags & SHRINKER_NUMA_AWARE) + size *= nr_node_ids; + + shrinker->nr_deferred = kzalloc(size, GFP_KERNEL); + if (!shrinker->nr_deferred) + goto err_flags; + +done: + return shrinker; + +err_flags: + shrinker_debugfs_name_free(shrinker); +err_name: + kfree(shrinker); + return NULL; +} +EXPORT_SYMBOL_GPL(shrinker_alloc); + +void shrinker_register(struct shrinker *shrinker) +{ + if (unlikely(!(shrinker->flags & SHRINKER_ALLOCATED))) { + pr_warn("Must use shrinker_alloc() to dynamically allocate the shrinker"); + return; + } + + down_write(&shrinker_rwsem); + list_add_tail(&shrinker->list, &shrinker_list); + shrinker->flags |= SHRINKER_REGISTERED; + shrinker_debugfs_add(shrinker); + up_write(&shrinker_rwsem); +} +EXPORT_SYMBOL_GPL(shrinker_register); + +void shrinker_free(struct shrinker *shrinker) +{ + struct dentry *debugfs_entry = NULL; + int debugfs_id; + + if (!shrinker) + return; + + down_write(&shrinker_rwsem); + if (shrinker->flags & SHRINKER_REGISTERED) { + list_del(&shrinker->list); + debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); + shrinker->flags &= ~SHRINKER_REGISTERED; + } else { + shrinker_debugfs_name_free(shrinker); + } + + if (shrinker->flags & SHRINKER_MEMCG_AWARE) + unregister_memcg_shrinker(shrinker); + up_write(&shrinker_rwsem); + + if (debugfs_entry) + shrinker_debugfs_remove(debugfs_entry, debugfs_id); + + kfree(shrinker->nr_deferred); + shrinker->nr_deferred = NULL; + + kfree(shrinker); +} +EXPORT_SYMBOL_GPL(shrinker_free); + /* * Add a shrinker callback to be called from the vm. */ diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c index 61702bdc1af4..aa2027075ed9 100644 --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -191,6 +191,20 @@ int shrinker_debugfs_add(struct shrinker *shrinker) return 0; } +int shrinker_debugfs_name_alloc(struct shrinker *shrinker, const char *fmt, + va_list ap) +{ + shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); + + return shrinker->name ? 0 : -ENOMEM; +} + +void shrinker_debugfs_name_free(struct shrinker *shrinker) +{ + kfree_const(shrinker->name); + shrinker->name = NULL; +} + int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) { struct dentry *entry; @@ -239,8 +253,7 @@ struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, lockdep_assert_held(&shrinker_rwsem); - kfree_const(shrinker->name); - shrinker->name = NULL; + shrinker_debugfs_name_free(shrinker); *debugfs_id = entry ? shrinker->debugfs_id : -1; shrinker->debugfs_entry = NULL; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:11:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:11:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578026.905241 (Exim 4.92) (envelope-from ) id 1qSy8g-0004LF-Ee; Mon, 07 Aug 2023 11:11:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578026.905241; Mon, 07 Aug 2023 11:11:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8g-0004L1-Be; Mon, 07 Aug 2023 11:11:06 +0000 Received: by outflank-mailman (input) for mailman id 578026; Mon, 07 Aug 2023 11:11:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8f-00018O-1L for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:11:05 +0000 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [2607:f8b0:4864:20::1030]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1774fe72-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:11:01 +0200 (CEST) Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-265c94064b8so592413a91.0 for ; Mon, 07 Aug 2023 04:11:01 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:10:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1774fe72-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406660; x=1692011460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gw0136sZs5r00/aJ54ocs9PBikYP7lRbXpwQPAfPTOc=; b=Gyvrq2nfyAR2gtiKV5zvL8Xhj+SCDDvYcDtn1XMvCOK2WxV+VSYbUnzAoQjYyvGt5+ PHTlpGahxelrDvlDYfQpwR6LaV4hFOqIXHRHdsrciNy+7qVINos9dShQ72ovzklZpuaN tBKHGkUe3hFlhdPUgFyU1ktgofOKrrDExvQw3WHpY26rCW0nNqj3a0s5WCQXQ9Bd9I93 TEwgyMogZ1mPzKBfTbunK1McubgsswcAT76vheTTNvE/WuA1UFNnV1+1CWE/ou902ykn 9hSF0PrzcrYBFpqGd0qLFTJvVM4g/FWHVeqzvA2yGx34iIfgBZSGKt0JN+J335S8BL/2 72/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406660; x=1692011460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gw0136sZs5r00/aJ54ocs9PBikYP7lRbXpwQPAfPTOc=; b=Wm//9xgmP+ZQeNfDMQ3RZIauog80cq6kYO8X8LSsWdJ16AT02R26e2uONE/PuhgR7k IjgDQvpOkgpie19SoUVEOilWSsSAwW6sD6UB4uAQHqle37O/qyyHYBNkl1DgaUkkDg4G O14JOZygEemvOGsV5ArS5jZ9S7KRARaoYru++nnQ5wjF/IscbXpZ2mmS0xU1zMQ44Jkj LO4J1ngZMRAAqi2aGsnU8zt0TkJJf/bWKoTqqpq5mKKUBn2vuwVczV5+2btEAGJhxWfl OV/2K9fFHsHxb2dGHc3wZy6Yvu7G4oYGww0DEIdzLzLadEGmyTb82mfcpC0tTyX1rd+3 eZng== X-Gm-Message-State: ABy/qLZIP8cvakR0yqS7BL3Ty11j2qmeRJpx0R2WKrbqpFD8TFF2QVim YefcboIhofzexBcvtYusEItzpQ== X-Google-Smtp-Source: APBJJlEPLwCkyM2NxjgH9xwMvzhNNiNlagu6lRBAbkDAEcDSA5oH2sSREkdo5fvCbnVAS1DDWMCKvg== X-Received: by 2002:a17:90a:4104:b0:25c:1ad3:a4a1 with SMTP id u4-20020a17090a410400b0025c1ad3a4a1mr24588690pjf.1.1691406660379; Mon, 07 Aug 2023 04:11:00 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 05/48] kvm: mmu: dynamically allocate the x86-mmu shrinker Date: Mon, 7 Aug 2023 19:08:53 +0800 Message-Id: <20230807110936.21819-6-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the x86-mmu shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- arch/x86/kvm/mmu/mmu.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 9e4cd8b4a202..0386d5ec97b0 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -6804,11 +6804,7 @@ static unsigned long mmu_shrink_count(struct shrinker *shrink, return percpu_counter_read_positive(&kvm_total_used_mmu_pages); } -static struct shrinker mmu_shrinker = { - .count_objects = mmu_shrink_count, - .scan_objects = mmu_shrink_scan, - .seeks = DEFAULT_SEEKS * 10, -}; +static struct shrinker *mmu_shrinker; static void mmu_destroy_caches(void) { @@ -6941,10 +6937,16 @@ int kvm_mmu_vendor_module_init(void) if (percpu_counter_init(&kvm_total_used_mmu_pages, 0, GFP_KERNEL)) goto out; - ret = register_shrinker(&mmu_shrinker, "x86-mmu"); - if (ret) + mmu_shrinker = shrinker_alloc(0, "x86-mmu"); + if (!mmu_shrinker) goto out_shrinker; + mmu_shrinker->count_objects = mmu_shrink_count; + mmu_shrinker->scan_objects = mmu_shrink_scan; + mmu_shrinker->seeks = DEFAULT_SEEKS * 10; + + shrinker_register(mmu_shrinker); + return 0; out_shrinker: @@ -6966,7 +6968,7 @@ void kvm_mmu_vendor_module_exit(void) { mmu_destroy_caches(); percpu_counter_destroy(&kvm_total_used_mmu_pages); - unregister_shrinker(&mmu_shrinker); + shrinker_free(mmu_shrinker); } /* -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:11:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:11:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578032.905250 (Exim 4.92) (envelope-from ) id 1qSy8q-0004px-ON; Mon, 07 Aug 2023 11:11:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578032.905250; Mon, 07 Aug 2023 11:11:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8q-0004pp-LZ; Mon, 07 Aug 2023 11:11:16 +0000 Received: by outflank-mailman (input) for mailman id 578032; Mon, 07 Aug 2023 11:11:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy8p-0002Ee-5f for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:11:15 +0000 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [2607:f8b0:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f15c7de-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:11:14 +0200 (CEST) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-55b5a37acb6so361726a12.0 for ; Mon, 07 Aug 2023 04:11:14 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:11:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f15c7de-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406673; x=1692011473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YQ2nJ797AaeiRC4tEbuFSwr/qroaEGD64TBkJX9gwcc=; b=ln47b2De8WoaconN/yovNFIYkpyrSlbHjJ7O30AuN0v3fhaptV8Rv8p/uTgMw5ewUp ZG1baXWX3w4cWqVDXIBOemS0oLj2+PNkaGXC2OZVpKMXphkVdxVMTs/lnTAL5HQl/5sY XaAH/gxR2iJTsD9i1SGvIVeauJ8ohBUlyO6fZCAIfCsaCSqlNBgSWC3X4OcCTxOF8D8P aJ3rhIbrBRQ4RScgXu8Juii6sq5YNvbJw6x09Ixyfaq7t74WXRGryvfs7JEz6b0jZFwc ahGUwsb8fn5Z7b9T7/r6r1MmeGyYyDblu8RFgBNHHb0eaf9aJCBTyNjHYvmNxb3vGqrU A9hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406673; x=1692011473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YQ2nJ797AaeiRC4tEbuFSwr/qroaEGD64TBkJX9gwcc=; b=M0ZiYOwDXC+xMfiI3/AdM+JNwS2KIJvSXGSyd84mZ+ZAZR6pA0l/tqtjSb1ZGxjiIX 8CeoBb/aaG4hU1Wq8DocHW3vqnhvsbb0qFi5eCjPI5zlKpcopyiiOPf5Ov2qZww4uEZ3 FRtrywCOLP8/p1AMl1653HQ/3rqb/v2wg0H6mF/J03gLPs389DenxTfaXorlaebkSPe3 5xT5YOUwxfbzeifg8eAxKy1MsL/pl5zldHW87whDuP2I9BR4sW6F6WrsnJIZIxTFFWws T8F+avXyysnHFF5KOOy9yZ7+M7IWJ0GT7VbnkIwDj0xn7A3qUNkxbPPll1bfrP/E8SLP VDcg== X-Gm-Message-State: ABy/qLYYGz1UeYzt7o54ETlyEANcTPR/oLu4Y5QcJyd4GBbi/T/tf7bw 5hoV8o+Vt7DCoES4zm3URdtNaw== X-Google-Smtp-Source: APBJJlHrBtuiCQCJiVcJQ0g2xFi5uTTiYi1uZvqZ47NJp4VxlVmrIr4dlBS1TaGO2GoKAlBNE4DJvw== X-Received: by 2002:a17:90a:53a3:b0:268:437:7bd9 with SMTP id y32-20020a17090a53a300b0026804377bd9mr23468663pjh.3.1691406672888; Mon, 07 Aug 2023 04:11:12 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 06/48] binder: dynamically allocate the android-binder shrinker Date: Mon, 7 Aug 2023 19:08:54 +0800 Message-Id: <20230807110936.21819-7-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the android-binder shrinker. Signed-off-by: Qi Zheng --- drivers/android/binder_alloc.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c index e3db8297095a..62675cedd38e 100644 --- a/drivers/android/binder_alloc.c +++ b/drivers/android/binder_alloc.c @@ -1053,11 +1053,7 @@ binder_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) NULL, sc->nr_to_scan); } -static struct shrinker binder_shrinker = { - .count_objects = binder_shrink_count, - .scan_objects = binder_shrink_scan, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *binder_shrinker; /** * binder_alloc_init() - called by binder_open() for per-proc initialization @@ -1077,19 +1073,30 @@ void binder_alloc_init(struct binder_alloc *alloc) int binder_alloc_shrinker_init(void) { - int ret = list_lru_init(&binder_alloc_lru); + int ret; - if (ret == 0) { - ret = register_shrinker(&binder_shrinker, "android-binder"); - if (ret) - list_lru_destroy(&binder_alloc_lru); + ret = list_lru_init(&binder_alloc_lru); + if (ret) + return ret; + + binder_shrinker = shrinker_alloc(0, "android-binder"); + if (!binder_shrinker) { + list_lru_destroy(&binder_alloc_lru); + return -ENOMEM; } - return ret; + + binder_shrinker->count_objects = binder_shrink_count; + binder_shrinker->scan_objects = binder_shrink_scan; + binder_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(binder_shrinker); + + return 0; } void binder_alloc_shrinker_exit(void) { - unregister_shrinker(&binder_shrinker); + shrinker_free(binder_shrinker); list_lru_destroy(&binder_alloc_lru); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:14:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:14:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578047.905260 (Exim 4.92) (envelope-from ) id 1qSyBm-00061F-AC; Mon, 07 Aug 2023 11:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578047.905260; Mon, 07 Aug 2023 11:14:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyBm-000618-7g; Mon, 07 Aug 2023 11:14:18 +0000 Received: by outflank-mailman (input) for mailman id 578047; Mon, 07 Aug 2023 11:14:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyBl-000610-GT for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:14:17 +0000 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [2607:f8b0:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ae30831-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:14:15 +0200 (CEST) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6878db91494so757977b3a.0 for ; Mon, 07 Aug 2023 04:14:15 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:14:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ae30831-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406854; x=1692011654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UfFRGPeE2ZLo8C9JFiR7wWvNCzDdrS4O9P7I0rwozQE=; b=ONEUI0IfFZms4FG9PetOl8bvKenOqN1nU77N5Qte1+jcUcBw58bz7f+hU+R7TeYF+V lh6zqoEeFSpZcpg8mRig+kmjWUt6kfXbSu+9NeAXYfo3N+VsjNhMLOsuKkNQEOPAjcDK uUyV00OaSrfiIXIqqcl52eWZs37Xm/4rryCSVvHnIArrw8ERrhcN4eSxoW+GqcL8/yIb KwF9HiN5U8S+9tgj6CAiBWcQ9gvQLYdhSLPDQ8D4Yya1PGPZvz8SVg49P9ivLovoYGLT Rib8AROfQ3COlCK0yM55x9RlvasI2HVvqoY8nt3eQf4jmVmec6kkSrsQ1MGHdEx91QwE bHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406854; x=1692011654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UfFRGPeE2ZLo8C9JFiR7wWvNCzDdrS4O9P7I0rwozQE=; b=JEkOE53/3jJvmTePmE03e73y4yGVLdaQOMemUAaWIMs6wk17hvUXp+kmFAOc93eGOF 0t+/0Cdg12XOs7NyDXze21igkTBoBETK+XkEVDb65IYs2dy8N/HVpxPt3CoXFEmUrdd4 p5myAw76cXtTxNGasR8yh4j1yoz89rBQ6XsEikASPZe7D3FkoyP5WGLm4BveYlXTAzrc iZ4jj5a+P+gJ82ND55br1KMyreA8+uREcFFb53ZppawAnRRnZBbZA2RFHukKpFP0c91w TfLQo0nOH8uByLkfU9OYRpktp6pPOPQ4btZfbtSsXIdynHddhpeoXZFU3CUByhVNYlZC RWwA== X-Gm-Message-State: ABy/qLZA3QnUGpj+/ViLjyTdZGr1t4QZbTJt4ayBV/6Wk8vEOW46pv1N Ho4Nxyo1UoItiEweSMSYYm2Zew== X-Google-Smtp-Source: APBJJlFKEuLPG6rXvjHQ/xhYlF3mJA1G+qTCCufEjWmHi053bG2lxjJC7FtDeUsrnl72QxE+YEuj1g== X-Received: by 2002:a17:902:d503:b0:1bb:83ec:832 with SMTP id b3-20020a170902d50300b001bb83ec0832mr32625772plg.2.1691406854020; Mon, 07 Aug 2023 04:14:14 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 20/48] mm: thp: dynamically allocate the thp-related shrinkers Date: Mon, 7 Aug 2023 19:09:08 +0800 Message-Id: <20230807110936.21819-21-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the thp-zero and thp-deferred_split shrinkers. Signed-off-by: Qi Zheng --- mm/huge_memory.c | 69 +++++++++++++++++++++++++++++++----------------- 1 file changed, 45 insertions(+), 24 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 947001a7cd42..5d0c7a0b651c 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -65,7 +65,11 @@ unsigned long transparent_hugepage_flags __read_mostly = (1<count_objects = shrink_huge_zero_page_count; + huge_zero_page_shrinker->scan_objects = shrink_huge_zero_page_scan; + huge_zero_page_shrinker->seeks = DEFAULT_SEEKS; + shrinker_register(huge_zero_page_shrinker); + + deferred_split_shrinker->count_objects = deferred_split_count; + deferred_split_shrinker->scan_objects = deferred_split_scan; + deferred_split_shrinker->seeks = DEFAULT_SEEKS; + shrinker_register(deferred_split_shrinker); + + return 0; +} + +static void __init thp_shrinker_exit(void) +{ + shrinker_free(huge_zero_page_shrinker); + shrinker_free(deferred_split_shrinker); +} + static int __init hugepage_init(void) { int err; @@ -482,12 +516,9 @@ static int __init hugepage_init(void) if (err) goto err_slab; - err = register_shrinker(&huge_zero_page_shrinker, "thp-zero"); - if (err) - goto err_hzp_shrinker; - err = register_shrinker(&deferred_split_shrinker, "thp-deferred_split"); + err = thp_shrinker_init(); if (err) - goto err_split_shrinker; + goto err_shrinker; /* * By default disable transparent hugepages on smaller systems, @@ -505,10 +536,8 @@ static int __init hugepage_init(void) return 0; err_khugepaged: - unregister_shrinker(&deferred_split_shrinker); -err_split_shrinker: - unregister_shrinker(&huge_zero_page_shrinker); -err_hzp_shrinker: + thp_shrinker_exit(); +err_shrinker: khugepaged_destroy(); err_slab: hugepage_exit_sysfs(hugepage_kobj); @@ -2834,7 +2863,7 @@ void deferred_split_folio(struct folio *folio) #ifdef CONFIG_MEMCG if (memcg) set_shrinker_bit(memcg, folio_nid(folio), - deferred_split_shrinker.id); + deferred_split_shrinker->id); #endif } spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); @@ -2908,14 +2937,6 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, return split; } -static struct shrinker deferred_split_shrinker = { - .count_objects = deferred_split_count, - .scan_objects = deferred_split_scan, - .seeks = DEFAULT_SEEKS, - .flags = SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE | - SHRINKER_NONSLAB, -}; - #ifdef CONFIG_DEBUG_FS static void split_huge_pages_all(void) { -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:14:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:14:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578048.905270 (Exim 4.92) (envelope-from ) id 1qSyBz-0006MP-Hf; Mon, 07 Aug 2023 11:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578048.905270; Mon, 07 Aug 2023 11:14:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyBz-0006ME-F8; Mon, 07 Aug 2023 11:14:31 +0000 Received: by outflank-mailman (input) for mailman id 578048; Mon, 07 Aug 2023 11:14:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyBx-000610-Vx for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:14:29 +0000 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [2607:f8b0:4864:20::1036]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9293b0d0-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:14:28 +0200 (CEST) Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2690803a368so590612a91.1 for ; Mon, 07 Aug 2023 04:14:28 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:14:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9293b0d0-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406867; x=1692011667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=igblsYgdIrcTAL0swCZj529c9jjsKo5CwfFS1Qcng2s=; b=E/hLPt4J9XwFdy6Q/ScFkKAboS35nT/aVetijUs1uOyzpCdXJrzvux0WuTkbJahYDU HJ4RnOFgFoSV4vIvUSABYCFS8MT8O5BBdFRn/e0d22QvpkBHCvD7k0jL91l8VKqh/AnF pNO49bmGYrjFLlyM+it2E7+BjcoRQ4qvC4Z3zAnwRx4Mtu2gDzO6KjINZG5u37W7YPwR rd9mA5oeLZ1tw0ARUeeWuqEeVLZXyyZpLkD+mkbNh9jB2r9y+xHrPRtEaxpg/6wzvL2p pP/svPPe0egiR6EyNxAsA97H1SimGEidDNnScRjB0NSGHk7qAYW8vH7pvvrUaRXF4mmo 0r3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406867; x=1692011667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igblsYgdIrcTAL0swCZj529c9jjsKo5CwfFS1Qcng2s=; b=SG1iYr5DToFf2UekpJKlS+aeMnNLA5c23LJI+7tclLiUebUfSX5RubMWhYTvgnxCR4 myVbOtIuByKwhwUZ7KkcwmwpyUgSrcj9Rod7vD+Z+L3qQVZcPtqRVb9nymGyFO/r8xC7 RyxdBxEwEJ6s96UQMnvNIEEks4Wj11JzwQsW9lk06+P8Hsq6uY/77yN/l/8Ab3EZ1P8C SzivgY743hR91IGeJxL1UNSU18t3F6udDc22kAbiOl9q453RZZFTjQdRGq35LgtK0Lus UN6ER0+o4C9rCSnr7kLx3mWNx62NQrMf3pRDpzHXwkRwUUVUgtoh68lcOKjqzq3nxGN2 H2bA== X-Gm-Message-State: ABy/qLa2dZ2QbSnl53V9CACBKgJCMAWuenCA52kiRbfnaM1wjmfAR8xV ozSfswKlO7/SPpWt40prC6ty2A== X-Google-Smtp-Source: APBJJlGEDKqK4nyUWs8xE2EOJL+ODt25deDnA1/u8sHRAURqC7uD6bjxMDwwed+SXn6y84Un7sE7wA== X-Received: by 2002:a17:90a:1090:b0:268:126c:8a8b with SMTP id c16-20020a17090a109000b00268126c8a8bmr24570134pja.3.1691406867003; Mon, 07 Aug 2023 04:14:27 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 21/48] sunrpc: dynamically allocate the sunrpc_cred shrinker Date: Mon, 7 Aug 2023 19:09:09 +0800 Message-Id: <20230807110936.21819-22-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the sunrpc_cred shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- net/sunrpc/auth.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c index 2f16f9d17966..0cc52e39f859 100644 --- a/net/sunrpc/auth.c +++ b/net/sunrpc/auth.c @@ -861,11 +861,7 @@ rpcauth_uptodatecred(struct rpc_task *task) test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) != 0; } -static struct shrinker rpc_cred_shrinker = { - .count_objects = rpcauth_cache_shrink_count, - .scan_objects = rpcauth_cache_shrink_scan, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *rpc_cred_shrinker; int __init rpcauth_init_module(void) { @@ -874,9 +870,18 @@ int __init rpcauth_init_module(void) err = rpc_init_authunix(); if (err < 0) goto out1; - err = register_shrinker(&rpc_cred_shrinker, "sunrpc_cred"); - if (err < 0) + rpc_cred_shrinker = shrinker_alloc(0, "sunrpc_cred"); + if (!rpc_cred_shrinker) { + err = -ENOMEM; goto out2; + } + + rpc_cred_shrinker->count_objects = rpcauth_cache_shrink_count; + rpc_cred_shrinker->scan_objects = rpcauth_cache_shrink_scan; + rpc_cred_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(rpc_cred_shrinker); + return 0; out2: rpc_destroy_authunix(); @@ -887,5 +892,5 @@ int __init rpcauth_init_module(void) void rpcauth_remove_module(void) { rpc_destroy_authunix(); - unregister_shrinker(&rpc_cred_shrinker); + shrinker_free(rpc_cred_shrinker); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:14:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:14:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578051.905281 (Exim 4.92) (envelope-from ) id 1qSyCC-0006v5-Qq; Mon, 07 Aug 2023 11:14:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578051.905281; Mon, 07 Aug 2023 11:14:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCC-0006uy-No; Mon, 07 Aug 2023 11:14:44 +0000 Received: by outflank-mailman (input) for mailman id 578051; Mon, 07 Aug 2023 11:14:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCA-000610-U3 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:14:42 +0000 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [2607:f8b0:4864:20::1031]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a4731bb-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:14:41 +0200 (CEST) Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-26890669c8eso931997a91.1 for ; Mon, 07 Aug 2023 04:14:41 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:14:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a4731bb-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406880; x=1692011680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uDu/4z0sff3MNLq2Hem41DvJLtW9HR7Ht2OY0+o3IBw=; b=B1CW4rX5HR96iE4C61mcE8Vf6RLeUtYXgDxnwBceT7ft1IC5S++icQmFIFvrt4cG/L 0c/u6FKIvYpbVXU295bMslZ7j2rgVaXwSjJRaIMLa4dIqq6HefzeIHqMKw0/Lo0rsfaU nsC5mn0wc4B6AcTwpHE7UQo4S/4ZAugQvuMvQEsWqhRZLmPoe9oa0Q7yCYFnuuapzCun SWccc4DpmmmlhTogFq9P0LyJEl3ZRZ2cm803+AIasPp033eu68uxaCfAoKnHA+NQuDMw Rtim+7y0rt6vcYQJO+qKgz5xgBY8yFO2AMQKXPDTy0z1fvoO5gByJOuvIrJQUEDpduII rIFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406880; x=1692011680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uDu/4z0sff3MNLq2Hem41DvJLtW9HR7Ht2OY0+o3IBw=; b=EEqiq5e7Ya5Gi+mSDo0bvI5hKlxJh32GJ/x5OcFl66hUsG2Ul3fP0+QEoFwPhP3p+G 7Cp1S6x5cKoyIcKFXGiHWAC+w6o7WroU3tqZIp1nCZOK9TgDqhTymhYEtfVjQ4VOumvp k1nDlvsu+u/4hvfU6lE9pzJls1hWz1uUsCBFoToHNDrptkbvfZd7tebQIYsOMVcTzb4q Qm+8EvpCdz7ftGOZ2XhsNd8qgZhH7iT3aknLOCWxk04jDTpFo5DLlB0BKtaJQ/ePGgHk UFM98WMWQ7mBRoXqAtjRYzvStqesIVNncW33KYddZNYc5r5oswY1/0ZgsbOGcxgkkatF axJA== X-Gm-Message-State: ABy/qLYop+8SwGjMzBWNMbFNpmYA4XD8U6NowAfI0aoE3FJ3HYoukqNJ gHwNzaZinqzdPXerNwlprSxGtA== X-Google-Smtp-Source: APBJJlE+JUQU2KnCMqxKRhVbnyE7g/MjXwiwJL23ihCwbN9GtK/yS0Snkx/m2fq2fyEzRCC+VQ52VA== X-Received: by 2002:a17:90a:1f83:b0:268:3dc6:f0c5 with SMTP id x3-20020a17090a1f8300b002683dc6f0c5mr25034377pja.0.1691406879873; Mon, 07 Aug 2023 04:14:39 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 22/48] mm: workingset: dynamically allocate the mm-shadow shrinker Date: Mon, 7 Aug 2023 19:09:10 +0800 Message-Id: <20230807110936.21819-23-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the mm-shadow shrinker. Signed-off-by: Qi Zheng --- mm/workingset.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/mm/workingset.c b/mm/workingset.c index da58a26d0d4d..3c53138903a7 100644 --- a/mm/workingset.c +++ b/mm/workingset.c @@ -763,13 +763,6 @@ static unsigned long scan_shadow_nodes(struct shrinker *shrinker, NULL); } -static struct shrinker workingset_shadow_shrinker = { - .count_objects = count_shadow_nodes, - .scan_objects = scan_shadow_nodes, - .seeks = 0, /* ->count reports only fully expendable nodes */ - .flags = SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE, -}; - /* * Our list_lru->lock is IRQ-safe as it nests inside the IRQ-safe * i_pages lock. @@ -778,9 +771,10 @@ static struct lock_class_key shadow_nodes_key; static int __init workingset_init(void) { + struct shrinker *workingset_shadow_shrinker; unsigned int timestamp_bits; unsigned int max_order; - int ret; + int ret = -ENOMEM; BUILD_BUG_ON(BITS_PER_LONG < EVICTION_SHIFT); /* @@ -797,17 +791,24 @@ static int __init workingset_init(void) pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n", timestamp_bits, max_order, bucket_order); - ret = prealloc_shrinker(&workingset_shadow_shrinker, "mm-shadow"); - if (ret) + workingset_shadow_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE | + SHRINKER_MEMCG_AWARE, + "mm-shadow"); + if (!workingset_shadow_shrinker) goto err; + ret = __list_lru_init(&shadow_nodes, true, &shadow_nodes_key, - &workingset_shadow_shrinker); + workingset_shadow_shrinker); if (ret) goto err_list_lru; - register_shrinker_prepared(&workingset_shadow_shrinker); + + workingset_shadow_shrinker->count_objects = count_shadow_nodes; + workingset_shadow_shrinker->scan_objects = scan_shadow_nodes; + + shrinker_register(workingset_shadow_shrinker); return 0; err_list_lru: - free_prealloced_shrinker(&workingset_shadow_shrinker); + shrinker_free(workingset_shadow_shrinker); err: return ret; } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:14:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:14:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578055.905291 (Exim 4.92) (envelope-from ) id 1qSyCO-0007LN-3d; Mon, 07 Aug 2023 11:14:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578055.905291; Mon, 07 Aug 2023 11:14:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCO-0007LG-0c; Mon, 07 Aug 2023 11:14:56 +0000 Received: by outflank-mailman (input) for mailman id 578055; Mon, 07 Aug 2023 11:14:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCM-0006s9-Ho for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:14:54 +0000 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [2607:f8b0:4864:20::102f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1d39ee2-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:14:54 +0200 (CEST) Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-26890669c8eso932040a91.1 for ; Mon, 07 Aug 2023 04:14:53 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:14:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1d39ee2-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406892; x=1692011692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=41xmtjHXWdMgLIKiQIRlxv7trVO9ZOyoGRN9dVMIVRc=; b=cGZjKVIao4X1FE56kj8UAePkqWwhSzpoTbmrNAzfkmDpF5Xo4+OZiBUKSePxV9R+oc G1IRJ+7A7isb1SWVoDvsvP7l1acqUKxcQyd+kXEYl5Mu0ooyN6hulkaLMfilFtlIEGla KkeKIkL2nH6oGSLP/+1vanRLPdOnR/fS9enRnBTg7aqB7pi9sxUPyWaMbNSM9pXnXQt9 F+c8OaDe/t6AXuSYKYbMSCyXVTJsX7WpDTPUxY7FQSwi2t5FHO1P7yp1d3ZwE/GiUbMl ZFX6hlQGpFpm61JBWLj396znt7v4WHHVqgWWYpv/xKPpAaGWrpTBuQAyZLcxUgv1USuO WJbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406892; x=1692011692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=41xmtjHXWdMgLIKiQIRlxv7trVO9ZOyoGRN9dVMIVRc=; b=g3ecOa+Bg4Bfds7qk3g88qzqNTHbCBLzawLZPb09KM0scKZRGohVCsMteoEyD9LePm 3mBa2JoWn08NG4ch5FND/eHIh3YxQVeY1Erqy2n7sdMMSBM6vlUHrnqjSNl6oBgxNzCS Kv/Ij1Vsp94KL2m65NWHraZrVA/KJTqhoaThda1He0xkr8Hn3DIg/M0zXIUcRyEcaJTE pJkUbgJKT3/f2pgYj+PDMJINQjyxZn9x6W002K4vBsqbYQrfeowetO8v6WJmLRr2uZhR m7MMrCbRRzcOXpu7td+dKLsIIwhjm+T1aD0uCc6QiUzROuOaIh2CEnIwiJ9NW9cRR6I3 Z4DA== X-Gm-Message-State: AOJu0YzxaNRsWbvAis0mFIVFGOqNJ9IVHIWRUFbx/bQHm/TrHb9SRa0a HALtLlDtXwlBNnAx+rzpQsKzxA== X-Google-Smtp-Source: AGHT+IHGYi4H3eJU6+xZDF9BksA4+I5hA9Bl5pPgRuSaTGIaReiVuXjmY2IFcPrIIfpO+IdhjanDJQ== X-Received: by 2002:a17:90a:9c3:b0:269:41cf:7212 with SMTP id 61-20020a17090a09c300b0026941cf7212mr4963504pjo.4.1691406892562; Mon, 07 Aug 2023 04:14:52 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 23/48] drm/i915: dynamically allocate the i915_gem_mm shrinker Date: Mon, 7 Aug 2023 19:09:11 +0800 Message-Id: <20230807110936.21819-24-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the i915_gem_mm shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct drm_i915_private. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 30 +++++++++++--------- drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c index 214763942aa2..4504eb4f31d5 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_shrinker.c @@ -284,8 +284,7 @@ unsigned long i915_gem_shrink_all(struct drm_i915_private *i915) static unsigned long i915_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) { - struct drm_i915_private *i915 = - container_of(shrinker, struct drm_i915_private, mm.shrinker); + struct drm_i915_private *i915 = shrinker->private_data; unsigned long num_objects; unsigned long count; @@ -302,8 +301,8 @@ i915_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) if (num_objects) { unsigned long avg = 2 * count / num_objects; - i915->mm.shrinker.batch = - max((i915->mm.shrinker.batch + avg) >> 1, + i915->mm.shrinker->batch = + max((i915->mm.shrinker->batch + avg) >> 1, 128ul /* default SHRINK_BATCH */); } @@ -313,8 +312,7 @@ i915_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) static unsigned long i915_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) { - struct drm_i915_private *i915 = - container_of(shrinker, struct drm_i915_private, mm.shrinker); + struct drm_i915_private *i915 = shrinker->private_data; unsigned long freed; sc->nr_scanned = 0; @@ -422,12 +420,18 @@ i915_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr void i915_gem_driver_register__shrinker(struct drm_i915_private *i915) { - i915->mm.shrinker.scan_objects = i915_gem_shrinker_scan; - i915->mm.shrinker.count_objects = i915_gem_shrinker_count; - i915->mm.shrinker.seeks = DEFAULT_SEEKS; - i915->mm.shrinker.batch = 4096; - drm_WARN_ON(&i915->drm, register_shrinker(&i915->mm.shrinker, - "drm-i915_gem")); + i915->mm.shrinker = shrinker_alloc(0, "drm-i915_gem"); + if (!i915->mm.shrinker) { + drm_WARN_ON(&i915->drm, 1); + } else { + i915->mm.shrinker->scan_objects = i915_gem_shrinker_scan; + i915->mm.shrinker->count_objects = i915_gem_shrinker_count; + i915->mm.shrinker->seeks = DEFAULT_SEEKS; + i915->mm.shrinker->batch = 4096; + i915->mm.shrinker->private_data = i915; + + shrinker_register(i915->mm.shrinker); + } i915->mm.oom_notifier.notifier_call = i915_gem_shrinker_oom; drm_WARN_ON(&i915->drm, register_oom_notifier(&i915->mm.oom_notifier)); @@ -443,7 +447,7 @@ void i915_gem_driver_unregister__shrinker(struct drm_i915_private *i915) unregister_vmap_purge_notifier(&i915->mm.vmap_notifier)); drm_WARN_ON(&i915->drm, unregister_oom_notifier(&i915->mm.oom_notifier)); - unregister_shrinker(&i915->mm.shrinker); + shrinker_free(i915->mm.shrinker); } void i915_gem_shrinker_taints_mutex(struct drm_i915_private *i915, diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 682ef2b5c7d5..389e8bf140d7 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -163,7 +163,7 @@ struct i915_gem_mm { struct notifier_block oom_notifier; struct notifier_block vmap_notifier; - struct shrinker shrinker; + struct shrinker *shrinker; #ifdef CONFIG_MMU_NOTIFIER /** -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:15:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:15:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578058.905301 (Exim 4.92) (envelope-from ) id 1qSyCb-0007vE-FT; Mon, 07 Aug 2023 11:15:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578058.905301; Mon, 07 Aug 2023 11:15:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCb-0007v1-Cm; Mon, 07 Aug 2023 11:15:09 +0000 Received: by outflank-mailman (input) for mailman id 578058; Mon, 07 Aug 2023 11:15:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCa-000610-FU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:15:08 +0000 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [2607:f8b0:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a97c9df0-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:15:06 +0200 (CEST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-56462258cdeso526285a12.1 for ; Mon, 07 Aug 2023 04:15:06 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:15:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a97c9df0-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406905; x=1692011705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tu9w5C30y8MI/napZavPwFZ6nIJBEFlaB1CCEG9BfCw=; b=a1z4YhZHvqFoPORrF+lPhY3j/XjC+TmNlvpRZtfYsAqK97Oj+7/3ynKuNED1mH7m1Z 6e06VRzbid9nZWrrMcucwcQQbl3wWoXnyMdc8ZAlXCmo2cCjWRY3iHx4TeC9QHkfs0aM d8RS7FugZHSZy2lCqTJeQn9s7jGIX4/E3wPsaz9+SXihbEJvHaKoo3rxKtwLTkFE7bEU BQoGy+vR8UkI3yNn8zdn5buykCB5rpkHr/BUOTCuwQKNihZsP/3d1GH/pY3/5pZuhseK T4uD+LwrMEDhqbcy3e5z3ztow6Tvzy0xPmsoxdy/BtYqGaCEBDHXu6qpNBRWJ+H1UeBT R1aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406905; x=1692011705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tu9w5C30y8MI/napZavPwFZ6nIJBEFlaB1CCEG9BfCw=; b=WkpDkMG96Q/YcFsoG/aIAEae0ifUnyacVQWVyFA4Kovk810FkK1VF5GyPJyDxteDe0 wWwsemTSFb8Uy2oghRpSK7JnyTR3zxHaJXbNfqr1RXhtxpv6fQS8BZZyecypj56uuvgF oetUS1o1bkgrANCxyGwMcFxyxgKcSZWcEBIfx9BdHOoOVR7anGl01V9mp6GCiBehJjML BGBrxgOmFgf10dIL2hWaZPJdYUIVsR+/2886x6dxGkQQh1BwAyykzIuI5yVU/cCw9bNT WvsB6+3j6gSZF4+x+1rEjQlYoznhHBImFXnarP9pORCnCBGyOwJCxjEFnrh9DN6ZOqOG rO9Q== X-Gm-Message-State: AOJu0YyyCSx/FC6AHhO89GD4cLA5sDD9mSPaTNOw3Sd6qnMxd1wWLEVf U1QUL6y2Qz3ZlXK/xhGGrB74sQ== X-Google-Smtp-Source: AGHT+IEpCcigBA86rq7g8CBmKfvn4KajAK33DI3WvO1RysFov39NnZyAmCT+CDGKi31ZOdqYdEGlDQ== X-Received: by 2002:a17:90a:c8d:b0:268:196f:9656 with SMTP id v13-20020a17090a0c8d00b00268196f9656mr12996964pja.1.1691406905372; Mon, 07 Aug 2023 04:15:05 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 24/48] drm/msm: dynamically allocate the drm-msm_gem shrinker Date: Mon, 7 Aug 2023 19:09:12 +0800 Message-Id: <20230807110936.21819-25-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the drm-msm_gem shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct msm_drm_private. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/gpu/drm/msm/msm_drv.c | 4 ++- drivers/gpu/drm/msm/msm_drv.h | 4 +-- drivers/gpu/drm/msm/msm_gem_shrinker.c | 34 ++++++++++++++++---------- 3 files changed, 26 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 4bd028fa7500..7f20249d6071 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -462,7 +462,9 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) if (ret) goto err_msm_uninit; - msm_gem_shrinker_init(ddev); + ret = msm_gem_shrinker_init(ddev); + if (ret) + goto err_msm_uninit; if (priv->kms_init) { ret = priv->kms_init(ddev); diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 02fd6c7d0bb7..e2fc56f161b5 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm/msm_drv.h @@ -221,7 +221,7 @@ struct msm_drm_private { } vram; struct notifier_block vmap_notifier; - struct shrinker shrinker; + struct shrinker *shrinker; struct drm_atomic_state *pm_state; @@ -283,7 +283,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, unsigned long msm_gem_shrinker_shrink(struct drm_device *dev, unsigned long nr_to_scan); #endif -void msm_gem_shrinker_init(struct drm_device *dev); +int msm_gem_shrinker_init(struct drm_device *dev); void msm_gem_shrinker_cleanup(struct drm_device *dev); struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj); diff --git a/drivers/gpu/drm/msm/msm_gem_shrinker.c b/drivers/gpu/drm/msm/msm_gem_shrinker.c index f38296ad8743..20699993e4f8 100644 --- a/drivers/gpu/drm/msm/msm_gem_shrinker.c +++ b/drivers/gpu/drm/msm/msm_gem_shrinker.c @@ -34,8 +34,7 @@ static bool can_block(struct shrink_control *sc) static unsigned long msm_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) { - struct msm_drm_private *priv = - container_of(shrinker, struct msm_drm_private, shrinker); + struct msm_drm_private *priv = shrinker->private_data; unsigned count = priv->lru.dontneed.count; if (can_swap()) @@ -100,8 +99,7 @@ active_evict(struct drm_gem_object *obj) static unsigned long msm_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) { - struct msm_drm_private *priv = - container_of(shrinker, struct msm_drm_private, shrinker); + struct msm_drm_private *priv = shrinker->private_data; struct { struct drm_gem_lru *lru; bool (*shrink)(struct drm_gem_object *obj); @@ -148,10 +146,11 @@ msm_gem_shrinker_shrink(struct drm_device *dev, unsigned long nr_to_scan) struct shrink_control sc = { .nr_to_scan = nr_to_scan, }; - int ret; + unsigned long ret = SHRINK_STOP; fs_reclaim_acquire(GFP_KERNEL); - ret = msm_gem_shrinker_scan(&priv->shrinker, &sc); + if (priv->shrinker) + ret = msm_gem_shrinker_scan(priv->shrinker, &sc); fs_reclaim_release(GFP_KERNEL); return ret; @@ -210,16 +209,25 @@ msm_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr) * * This function registers and sets up the msm shrinker. */ -void msm_gem_shrinker_init(struct drm_device *dev) +int msm_gem_shrinker_init(struct drm_device *dev) { struct msm_drm_private *priv = dev->dev_private; - priv->shrinker.count_objects = msm_gem_shrinker_count; - priv->shrinker.scan_objects = msm_gem_shrinker_scan; - priv->shrinker.seeks = DEFAULT_SEEKS; - WARN_ON(register_shrinker(&priv->shrinker, "drm-msm_gem")); + + priv->shrinker = shrinker_alloc(0, "drm-msm_gem"); + if (!priv->shrinker) + return -ENOMEM; + + priv->shrinker->count_objects = msm_gem_shrinker_count; + priv->shrinker->scan_objects = msm_gem_shrinker_scan; + priv->shrinker->seeks = DEFAULT_SEEKS; + priv->shrinker->private_data = priv; + + shrinker_register(priv->shrinker); priv->vmap_notifier.notifier_call = msm_gem_shrinker_vmap; WARN_ON(register_vmap_purge_notifier(&priv->vmap_notifier)); + + return 0; } /** @@ -232,8 +240,8 @@ void msm_gem_shrinker_cleanup(struct drm_device *dev) { struct msm_drm_private *priv = dev->dev_private; - if (priv->shrinker.nr_deferred) { + if (priv->shrinker) { WARN_ON(unregister_vmap_purge_notifier(&priv->vmap_notifier)); - unregister_shrinker(&priv->shrinker); + shrinker_free(priv->shrinker); } } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:15:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:15:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578063.905311 (Exim 4.92) (envelope-from ) id 1qSyCo-0008UR-PR; Mon, 07 Aug 2023 11:15:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578063.905311; Mon, 07 Aug 2023 11:15:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCo-0008UK-LM; Mon, 07 Aug 2023 11:15:22 +0000 Received: by outflank-mailman (input) for mailman id 578063; Mon, 07 Aug 2023 11:15:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCn-000610-3E for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:15:21 +0000 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [2607:f8b0:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0fdcf57-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:15:19 +0200 (CEST) Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-55badd6d6feso571905a12.1 for ; Mon, 07 Aug 2023 04:15:19 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:15:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0fdcf57-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406918; x=1692011718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vjqO/ZPr/Go39gpx6DVg0WzFepitwPif37hI1XuxbyE=; b=i8fsgLYWfev5scmfQYKpSFDJ9pzF+PwGn1FsDwGvtD1uFjg7eJ0d7Lsv78NIi06CDx vr0tOnonxOw6QKks8GGMVje1yI76Id9YacgwWM/6zDy0zFFyPsap+I+zda83U2carxpx Z18IYbpo7Gm3FdJaGS0K3SM5Q8cb/i1IMPI0QPzFO825A0m0YY6BspmFZAUe5JxSz0YP bkwll+VM7Pw+rOWsuxKvkfM7f/Go/LNsWkdpeQ1rn3o0A1sl0I4JTJinRVhwLnue8wfE xB3XG0FiQERqOk0h4Z7caYUSG1dAOTxeZU3n+iczoygP+1WmuYIouocYZOnqbY8VXZy5 2Thg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406918; x=1692011718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vjqO/ZPr/Go39gpx6DVg0WzFepitwPif37hI1XuxbyE=; b=EE/G0rhnUNVy91fxCBGqZxiwv47uHKkhHXfX5sEChPSmFFbowjL5zFlhnrunlf/lmY 2X3uPB/VnvD/xknsInLaZU3QsQs0UvIrZkKj2YNIk82/NYNOBMQUz8VSXz/TBTsuSjJp v9V7QZKfd1DRoMx6N6AexqkBfeP1OAThoGrQLp62I/IMPW2h10L3aEJCE+JhUGDHEipe IqTB6rxmIIDr1AMoXa7pjhZp4ydiis9IgeCqe2AwMkE8Krj1huuofZl/tM/WB36Q/NuQ OjRw/Xp4wqU/7/xTSnmmVfunzlcMZcgrQL5ridWCUN3XD9mVlSg6RTx9dUfnQSREQusj WS2Q== X-Gm-Message-State: ABy/qLbCEM5h8Qs7wWwp7oe4q7jocA7MUlCIMowoZnS1bsmb0e1cTKJd kTevUIG0KQBh8PMK7iXqr2ygfA== X-Google-Smtp-Source: APBJJlGmDPkOqvUzYBlbH7T7lkG5BB9heuLk9VUuk/u1AhmT0DHlhAEqotepcvwe4m42tykQjmW6CA== X-Received: by 2002:a17:90a:4104:b0:25c:1ad3:a4a1 with SMTP id u4-20020a17090a410400b0025c1ad3a4a1mr24597319pjf.1.1691406917979; Mon, 07 Aug 2023 04:15:17 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 25/48] drm/panfrost: dynamically allocate the drm-panfrost shrinker Date: Mon, 7 Aug 2023 19:09:13 +0800 Message-Id: <20230807110936.21819-26-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the drm-panfrost shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct panfrost_device. Signed-off-by: Qi Zheng Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 6 +++- drivers/gpu/drm/panfrost/panfrost_gem.h | 2 +- .../gpu/drm/panfrost/panfrost_gem_shrinker.c | 30 +++++++++++-------- 4 files changed, 25 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h index b0126b9fbadc..e667e5689353 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -118,7 +118,7 @@ struct panfrost_device { struct mutex shrinker_lock; struct list_head shrinker_list; - struct shrinker shrinker; + struct shrinker *shrinker; struct panfrost_devfreq pfdevfreq; }; diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index a2ab99698ca8..e1d0e3a23757 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -601,10 +601,14 @@ static int panfrost_probe(struct platform_device *pdev) if (err < 0) goto err_out1; - panfrost_gem_shrinker_init(ddev); + err = panfrost_gem_shrinker_init(ddev); + if (err) + goto err_out2; return 0; +err_out2: + drm_dev_unregister(ddev); err_out1: pm_runtime_disable(pfdev->dev); panfrost_device_fini(pfdev); diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.h b/drivers/gpu/drm/panfrost/panfrost_gem.h index ad2877eeeccd..863d2ec8d4f0 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem.h +++ b/drivers/gpu/drm/panfrost/panfrost_gem.h @@ -81,7 +81,7 @@ panfrost_gem_mapping_get(struct panfrost_gem_object *bo, void panfrost_gem_mapping_put(struct panfrost_gem_mapping *mapping); void panfrost_gem_teardown_mappings_locked(struct panfrost_gem_object *bo); -void panfrost_gem_shrinker_init(struct drm_device *dev); +int panfrost_gem_shrinker_init(struct drm_device *dev); void panfrost_gem_shrinker_cleanup(struct drm_device *dev); #endif /* __PANFROST_GEM_H__ */ diff --git a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c index 6a71a2555f85..3dfe2b7ccdd9 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c +++ b/drivers/gpu/drm/panfrost/panfrost_gem_shrinker.c @@ -18,8 +18,7 @@ static unsigned long panfrost_gem_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) { - struct panfrost_device *pfdev = - container_of(shrinker, struct panfrost_device, shrinker); + struct panfrost_device *pfdev = shrinker->private_data; struct drm_gem_shmem_object *shmem; unsigned long count = 0; @@ -65,8 +64,7 @@ static bool panfrost_gem_purge(struct drm_gem_object *obj) static unsigned long panfrost_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) { - struct panfrost_device *pfdev = - container_of(shrinker, struct panfrost_device, shrinker); + struct panfrost_device *pfdev = shrinker->private_data; struct drm_gem_shmem_object *shmem, *tmp; unsigned long freed = 0; @@ -97,13 +95,22 @@ panfrost_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) * * This function registers and sets up the panfrost shrinker. */ -void panfrost_gem_shrinker_init(struct drm_device *dev) +int panfrost_gem_shrinker_init(struct drm_device *dev) { struct panfrost_device *pfdev = dev->dev_private; - pfdev->shrinker.count_objects = panfrost_gem_shrinker_count; - pfdev->shrinker.scan_objects = panfrost_gem_shrinker_scan; - pfdev->shrinker.seeks = DEFAULT_SEEKS; - WARN_ON(register_shrinker(&pfdev->shrinker, "drm-panfrost")); + + pfdev->shrinker = shrinker_alloc(0, "drm-panfrost"); + if (!pfdev->shrinker) + return -ENOMEM; + + pfdev->shrinker->count_objects = panfrost_gem_shrinker_count; + pfdev->shrinker->scan_objects = panfrost_gem_shrinker_scan; + pfdev->shrinker->seeks = DEFAULT_SEEKS; + pfdev->shrinker->private_data = pfdev; + + shrinker_register(pfdev->shrinker); + + return 0; } /** @@ -116,7 +123,6 @@ void panfrost_gem_shrinker_cleanup(struct drm_device *dev) { struct panfrost_device *pfdev = dev->dev_private; - if (pfdev->shrinker.nr_deferred) { - unregister_shrinker(&pfdev->shrinker); - } + if (pfdev->shrinker) + shrinker_free(pfdev->shrinker); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:15:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:15:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578067.905321 (Exim 4.92) (envelope-from ) id 1qSyD0-0000Yj-25; Mon, 07 Aug 2023 11:15:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578067.905321; Mon, 07 Aug 2023 11:15:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCz-0000YT-UR; Mon, 07 Aug 2023 11:15:33 +0000 Received: by outflank-mailman (input) for mailman id 578067; Mon, 07 Aug 2023 11:15:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyCy-0006s9-Eh for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:15:32 +0000 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [2607:f8b0:4864:20::d35]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b8862dfb-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:15:31 +0200 (CEST) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-760dff4b701so48560539f.0 for ; Mon, 07 Aug 2023 04:15:31 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:15:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8862dfb-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406930; x=1692011730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Rfav5Nxe+GtybemfHCRLQWJ1Wm1Jr8phC3oTaQ6f/s=; b=RhTNRytlTa20t4Y4eQDAbFdSU2B3iJZ1UGQvbDrNgMxM2lZyl06oD16eY7UnwOu7/z lhfBO1aEb+iaxXm7zjPBY7hPV/HGsazWxYGeChIQ5BZqNHrYc42N83Qpez7ydwipu9EJ dl8ebrZJyA2dXTCWIRLJ5KrUEadehbntFp8yZr0t1mcATZxSPZjFq4Ii0bOe708GiDDw sbmlI1kieYrCzo2Qbsl1zLM+PYAlt09SHmpbPtNn98Tc607U0WsJTYx77KWhrtfG5gTM J9JKFlnKyLN5gCahSDRWLwC9lXHkDS1fNn6g8aIOpZaiEnR0eJG9fj8gxoamq0eWdy8p EjpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406930; x=1692011730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Rfav5Nxe+GtybemfHCRLQWJ1Wm1Jr8phC3oTaQ6f/s=; b=CtOqtqkSFEd0W2WM8ot5iNufYcHVs2y07VikikEzx2/fIeFLvE2Re941tPO5pyguTO J4FzsStpv18ORtzb91Px+BC6j5blEnNBlSrN3Jfmud+rPICiRhhgqcLhM48PMlnA1DJx x2DI0sn3dNH7lgbDoA4QpkxhgDc5llua/EKAZb//hJ6rEomQHxc4nT9LX8QOM30ZNjL2 rGdhqbExCgnlogZE1ldbzYN5CSD2M/oUF2YPtwU/W33qs6No2dYkqCBtRaa9MA/PrO26 PGE2nt4hxuh0dcMAezxH+AYGU1wgWJEXzysM0IUvq/6aYS8yme0HL9um9ey+zac63FJh LAaQ== X-Gm-Message-State: AOJu0YxGAQJdPtrsjhgNnrD7Sd5dSsR3bS43B3jCRnlgpMrGIWzNK4St TNubOHFFpj5ImY53AEcnQUfCEw== X-Google-Smtp-Source: AGHT+IFWvaKty2qg3Zp4xukmaRzjC+XhBT002dXZP422OqSqCh0qrR2HTT2eLu1rJ18Y9R5+7t84vA== X-Received: by 2002:a92:6408:0:b0:349:5c87:e712 with SMTP id y8-20020a926408000000b003495c87e712mr5356429ilb.1.1691406930655; Mon, 07 Aug 2023 04:15:30 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 26/48] dm: dynamically allocate the dm-bufio shrinker Date: Mon, 7 Aug 2023 19:09:14 +0800 Message-Id: <20230807110936.21819-27-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the dm-bufio shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct dm_bufio_client. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/md/dm-bufio.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index bc309e41d074..62eb27639c9b 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -963,7 +963,7 @@ struct dm_bufio_client { sector_t start; - struct shrinker shrinker; + struct shrinker *shrinker; struct work_struct shrink_work; atomic_long_t need_shrink; @@ -2368,7 +2368,7 @@ static unsigned long dm_bufio_shrink_scan(struct shrinker *shrink, struct shrink { struct dm_bufio_client *c; - c = container_of(shrink, struct dm_bufio_client, shrinker); + c = shrink->private_data; atomic_long_add(sc->nr_to_scan, &c->need_shrink); queue_work(dm_bufio_wq, &c->shrink_work); @@ -2377,7 +2377,7 @@ static unsigned long dm_bufio_shrink_scan(struct shrinker *shrink, struct shrink static unsigned long dm_bufio_shrink_count(struct shrinker *shrink, struct shrink_control *sc) { - struct dm_bufio_client *c = container_of(shrink, struct dm_bufio_client, shrinker); + struct dm_bufio_client *c = shrink->private_data; unsigned long count = cache_total(&c->cache); unsigned long retain_target = get_retain_buffers(c); unsigned long queued_for_cleanup = atomic_long_read(&c->need_shrink); @@ -2490,14 +2490,20 @@ struct dm_bufio_client *dm_bufio_client_create(struct block_device *bdev, unsign INIT_WORK(&c->shrink_work, shrink_work); atomic_long_set(&c->need_shrink, 0); - c->shrinker.count_objects = dm_bufio_shrink_count; - c->shrinker.scan_objects = dm_bufio_shrink_scan; - c->shrinker.seeks = 1; - c->shrinker.batch = 0; - r = register_shrinker(&c->shrinker, "dm-bufio:(%u:%u)", - MAJOR(bdev->bd_dev), MINOR(bdev->bd_dev)); - if (r) + c->shrinker = shrinker_alloc(0, "dm-bufio:(%u:%u)", + MAJOR(bdev->bd_dev), MINOR(bdev->bd_dev)); + if (!c->shrinker) { + r = -ENOMEM; goto bad; + } + + c->shrinker->count_objects = dm_bufio_shrink_count; + c->shrinker->scan_objects = dm_bufio_shrink_scan; + c->shrinker->seeks = 1; + c->shrinker->batch = 0; + c->shrinker->private_data = c; + + shrinker_register(c->shrinker); mutex_lock(&dm_bufio_clients_lock); dm_bufio_client_count++; @@ -2537,7 +2543,7 @@ void dm_bufio_client_destroy(struct dm_bufio_client *c) drop_buffers(c); - unregister_shrinker(&c->shrinker); + shrinker_free(c->shrinker); flush_work(&c->shrink_work); mutex_lock(&dm_bufio_clients_lock); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:15:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:15:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578072.905331 (Exim 4.92) (envelope-from ) id 1qSyDE-0001A3-9a; Mon, 07 Aug 2023 11:15:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578072.905331; Mon, 07 Aug 2023 11:15:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyDE-00019u-6d; Mon, 07 Aug 2023 11:15:48 +0000 Received: by outflank-mailman (input) for mailman id 578072; Mon, 07 Aug 2023 11:15:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyDC-000610-Hv for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:15:46 +0000 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [2607:f8b0:4864:20::1036]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c03400fe-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:15:45 +0200 (CEST) Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-268663fb09cso631555a91.0 for ; Mon, 07 Aug 2023 04:15:44 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:15:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c03400fe-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406943; x=1692011743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qDCHIUUJzhdUAQEb2C7RW/Dwv8wB1L4nNlzD+13VK1U=; b=BoRgxmNUDtxzbmTK8+NbyH+07KYCd+Dr+oKPPa6V2FtEa17D0GvDQxjGlpnMkhmfxh v95DV47NbKABEXmmquIWadBnc0OBxkEOLW5WkwOTzTf/BxgV/A3wBC3uAtz5110v+hzE Ab8A6lWD76Mq+5DiKmh8yjejLb6xJUC09A5jGZ8oJIUHv3JYqq06sjhL7prumjkiRo3O qB570Dus+/9+aUH0B/0q8kHN6EW2eaOwjl0xOlzT2kA7NW6hf0e/OVGGbp1TjXoLyoWq aNUKJyMjC1sbPHUX4hmJJ6cJvGihC8n4kqK2Irls4fBt7l8WiF7MHJ0n9oTLuTvoH1vN CZ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406943; x=1692011743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qDCHIUUJzhdUAQEb2C7RW/Dwv8wB1L4nNlzD+13VK1U=; b=jr/Q9sNyQxT8KIPuaN6TW6uu1MMsFisS4+TUobW/9cI2Mg2yj3uKE3H0NYviwBDtf2 Zhs7faOcGGh9K3pCLcpn6ONPtFJeOnowt0QSfNX0c17aL7xxnY3DE69ijXzsh8W1dc/d B29lI2341vYIjmUBUv1DDopg9MDNkM/F55FrMKYdgY9krsBkJyhjz3Lzl+cZjuhZIUAf dnnTlJk9g2wA5+qjqPAKCj8yCFNbXrQmA6/cAnLEjM9R4ZLrOBKr4jFVmhGLPQfFNcYQ AU7SXXLYACV6SxD/XovjxcqnAh4CqNIcJT1PQ0fQHj9CNz5I7iDAIkzabDRQpLSEXKHe 2HDQ== X-Gm-Message-State: ABy/qLaQfNbesHR4zbNQ6KHkLPPlZIEpvRq86QMbppWmjkLlJtdO5ciH Thon+2+aP/sbmP+Rvk7eVeO2iw== X-Google-Smtp-Source: APBJJlEUCHWWWNXSTNLHQrmZRIrp+biqETFoyppqOsbwjUrAqcyZvOjgkWFuVkSEp/5UbdP5i9KhZA== X-Received: by 2002:a17:90a:6c97:b0:263:730b:f568 with SMTP id y23-20020a17090a6c9700b00263730bf568mr23067993pjj.3.1691406943426; Mon, 07 Aug 2023 04:15:43 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 27/48] dm zoned: dynamically allocate the dm-zoned-meta shrinker Date: Mon, 7 Aug 2023 19:09:15 +0800 Message-Id: <20230807110936.21819-28-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the dm-zoned-meta shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct dmz_metadata. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/md/dm-zoned-metadata.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 9d3cca8e3dc9..bbb0e69a7908 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b/drivers/md/dm-zoned-metadata.c @@ -187,7 +187,7 @@ struct dmz_metadata { struct rb_root mblk_rbtree; struct list_head mblk_lru_list; struct list_head mblk_dirty_list; - struct shrinker mblk_shrinker; + struct shrinker *mblk_shrinker; /* Zone allocation management */ struct mutex map_lock; @@ -615,7 +615,7 @@ static unsigned long dmz_shrink_mblock_cache(struct dmz_metadata *zmd, static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; return atomic_read(&zmd->nr_mblks); } @@ -626,7 +626,7 @@ static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); + struct dmz_metadata *zmd = shrink->private_data; unsigned long count; spin_lock(&zmd->mblk_lock); @@ -2936,19 +2936,24 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; zmd->max_nr_mblks = zmd->min_nr_mblks + 512; - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; /* Metadata cache shrinker */ - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", - MAJOR(dev->bdev->bd_dev), - MINOR(dev->bdev->bd_dev)); - if (ret) { - dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); + zmd->mblk_shrinker = shrinker_alloc(0, "dm-zoned-meta:(%u:%u)", + MAJOR(dev->bdev->bd_dev), + MINOR(dev->bdev->bd_dev)); + if (!zmd->mblk_shrinker) { + ret = -ENOMEM; + dmz_zmd_err(zmd, "Allocate metadata cache shrinker failed"); goto err; } + zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; + zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; + zmd->mblk_shrinker->seeks = DEFAULT_SEEKS; + zmd->mblk_shrinker->private_data = zmd; + + shrinker_register(zmd->mblk_shrinker); + dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); for (i = 0; i < zmd->nr_devs; i++) dmz_print_dev(zmd, i); @@ -2995,7 +3000,7 @@ int dmz_ctr_metadata(struct dmz_dev *dev, int num_dev, */ void dmz_dtr_metadata(struct dmz_metadata *zmd) { - unregister_shrinker(&zmd->mblk_shrinker); + shrinker_free(zmd->mblk_shrinker); dmz_cleanup_metadata(zmd); kfree(zmd); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:16:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:16:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578075.905341 (Exim 4.92) (envelope-from ) id 1qSyEF-00024n-Q7; Mon, 07 Aug 2023 11:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578075.905341; Mon, 07 Aug 2023 11:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEF-00024g-MB; Mon, 07 Aug 2023 11:16:51 +0000 Received: by outflank-mailman (input) for mailman id 578075; Mon, 07 Aug 2023 11:16:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEE-00024S-Nh for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:16:50 +0000 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [2607:f8b0:4864:20::1029]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6398775-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:16:48 +0200 (CEST) Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-265c94064b8so593089a91.0 for ; Mon, 07 Aug 2023 04:16:48 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:16:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6398775-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407007; x=1692011807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xVRvDV5EwClRaurogoo7jeCmWiPiam6NNimoVigpYsU=; b=ZpUxkeIDSk5DebcqgtNkjC2VJVRAtk53SZcSRGK4pcR9GN/+oNusiQFLHhuL5+fDtw 7acmwH5I9QFGztB582Oi6rcT7wKm21cMdk1CbKhqvY9Cmn9xfrqO2dNVGGjerHD5cIRA JQtjfGPdI2ZqgIP1F2QTrXkDr1QXGVfPleR0HQt933rEeM4xbQBZZP8jkCpRscjQOmu/ 9ghKZGvMUY+k4JEeKO1r8tlLUiIWng6Gl6oS+MWXEsfNz6xEM3RIsZmLQbyECe49vE1Q 39HHbQOTTkWnAgiDXPq6I3IGqNg8FapL1nhN+TNChCmLrlL9RKqe8AW+z81Q9HVEEwQe Rdpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407007; x=1692011807; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xVRvDV5EwClRaurogoo7jeCmWiPiam6NNimoVigpYsU=; b=i7tUhh4TNKK0oM/cW0nkeVCBWn2iIF1cqHofSmUS+FjaaSjrZPMT1vcbAdnYFm8SHR qbq01mGJdMtADtF/1dD0h4CPYdm4f53laIsoRicXoixMLG15j3/jqKzkCxlsi0w0ZCrD Q50p5IzBvXP9bDchDLOU7AjXhDSv9R9R6jwQ1NTTAjRglF5/lvJbRmRKVQEggKS73SES EyhmUPyHtWAhqnfmBIZVZoSkOnYWgLgmLS8JhNBDekwAo8dmeyM+uvNItk0qr67mOmJg vvJk6ds1LeGsbI1QJhLGl9CN/7NgOTfW2/2nXYPrM8FZeRIuTGb/Hh8SjJJtV9zxMHk2 sqrw== X-Gm-Message-State: ABy/qLaTEHJdhzVikkTFIJCPt79b6tQusPH3Axvsc+G0b3anTaQTZUxR L1gwoIMv3aSZIOioqDVQH8rriw== X-Google-Smtp-Source: APBJJlGBV531Fc0h3gGTcYh+GrDchiBvn4r3DyO1GlE79UVq2Tiyx2gaPN4S9h+mnuBR5bsUMtGvYQ== X-Received: by 2002:a17:90a:ac2:b0:268:f977:848c with SMTP id r2-20020a17090a0ac200b00268f977848cmr15219032pje.2.1691407007341; Mon, 07 Aug 2023 04:16:47 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 32/48] mbcache: dynamically allocate the mbcache shrinker Date: Mon, 7 Aug 2023 19:09:20 +0800 Message-Id: <20230807110936.21819-33-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the mbcache shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct mb_cache. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/mbcache.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/fs/mbcache.c b/fs/mbcache.c index 2a4b8b549e93..0d1e24e9a5e3 100644 --- a/fs/mbcache.c +++ b/fs/mbcache.c @@ -37,7 +37,7 @@ struct mb_cache { struct list_head c_list; /* Number of entries in cache */ unsigned long c_entry_count; - struct shrinker c_shrink; + struct shrinker *c_shrink; /* Work for shrinking when the cache has too many entries */ struct work_struct c_shrink_work; }; @@ -293,8 +293,7 @@ EXPORT_SYMBOL(mb_cache_entry_touch); static unsigned long mb_cache_count(struct shrinker *shrink, struct shrink_control *sc) { - struct mb_cache *cache = container_of(shrink, struct mb_cache, - c_shrink); + struct mb_cache *cache = shrink->private_data; return cache->c_entry_count; } @@ -333,8 +332,7 @@ static unsigned long mb_cache_shrink(struct mb_cache *cache, static unsigned long mb_cache_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct mb_cache *cache = container_of(shrink, struct mb_cache, - c_shrink); + struct mb_cache *cache = shrink->private_data; return mb_cache_shrink(cache, sc->nr_to_scan); } @@ -377,15 +375,20 @@ struct mb_cache *mb_cache_create(int bucket_bits) for (i = 0; i < bucket_count; i++) INIT_HLIST_BL_HEAD(&cache->c_hash[i]); - cache->c_shrink.count_objects = mb_cache_count; - cache->c_shrink.scan_objects = mb_cache_scan; - cache->c_shrink.seeks = DEFAULT_SEEKS; - if (register_shrinker(&cache->c_shrink, "mbcache-shrinker")) { + cache->c_shrink = shrinker_alloc(0, "mbcache-shrinker"); + if (!cache->c_shrink) { kfree(cache->c_hash); kfree(cache); goto err_out; } + cache->c_shrink->count_objects = mb_cache_count; + cache->c_shrink->scan_objects = mb_cache_scan; + cache->c_shrink->seeks = DEFAULT_SEEKS; + cache->c_shrink->private_data = cache; + + shrinker_register(cache->c_shrink); + INIT_WORK(&cache->c_shrink_work, mb_cache_shrink_worker); return cache; @@ -406,7 +409,7 @@ void mb_cache_destroy(struct mb_cache *cache) { struct mb_cache_entry *entry, *next; - unregister_shrinker(&cache->c_shrink); + shrinker_free(cache->c_shrink); /* * We don't bother with any locking. Cache must not be used at this -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578079.905351 (Exim 4.92) (envelope-from ) id 1qSyEl-0002dI-3B; Mon, 07 Aug 2023 11:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578079.905351; Mon, 07 Aug 2023 11:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEk-0002dB-Uc; Mon, 07 Aug 2023 11:17:22 +0000 Received: by outflank-mailman (input) for mailman id 578079; Mon, 07 Aug 2023 11:17:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyDb-0006s9-2r for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:16:11 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf743b57-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:16:10 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-26890669c8eso932191a91.1 for ; Mon, 07 Aug 2023 04:16:10 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:16:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf743b57-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406969; x=1692011769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v2xQZfHf5bNVsT7uWSGQWuu07PHxrGT3T56hFvtqSrg=; b=PhZgEytbdr8CvNBxueya8LJEBJpXwGWT4buounuwMzZgdINLVWVhWlDlK5qgc2p2kt RnCQbjUwWxqdm7J4M7EGc1Ch17V+zcgd4r1Zi/3vO2292nZ9ssUadxFIe0dzINz36EEw HVRix2YnCwrYzOYArOpD9yWwDi1L0lwbZbmCgyeiLVpEO0l9z3l7+yQI3NnEvQZkBYSV kAWt+c/pFJSgV6aTUUqi7ips5HoQ3TEpyq/Sxi9XAc6jQa+5WRv9fo1CMPIL4wKkfI5R cCEylx4Q4qJCTb4YKG/AnxQtLRIB707mPePFz8XepMv7bUxA9w4l0/+xaTDhOuBgbM/U hPfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406969; x=1692011769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v2xQZfHf5bNVsT7uWSGQWuu07PHxrGT3T56hFvtqSrg=; b=ddmClkqAwXJXXJ/jcg6UlIU8x9XkvZXC5du0HI8FpcwuvXsgWd0xZWJQDuxvlKyQ9H 7sbJeVnF8D2qrAH0AqwVZQc7kZ9lGSdOirRIhS6px9YnQdWvqVycBZ0RjWU1MX0dq+ai RQX0Mr1dg3COnN77eVZxbw2o+r/S/r72gFKChY4h1niNM4GnvY/y3OJO6tN/KdNPxFHf VunCyQLIzuIn0k1VLsQp8BSsZm+DhAeh/lH/PqjuR2MKC+CSp+Zp7axeTgozU3F/ex+3 aYQvmBstenT2wM93M4u9qdzj9jDekDYtGZdNJElWOh+jh1/T5YeMRvCbjLjm6Vh9M9ir b+Vw== X-Gm-Message-State: AOJu0Yzdu4rO72+IxXgHkNsKfWE/5i5a/9PGCaZKCI0/oQib71ZrOvDe m9WHlcaiytHm92Bu4o2eYlwMiA== X-Google-Smtp-Source: AGHT+IFlvQWL2g4YOY+ZhMNeAWWdQSS9yshpdy35E0gAyloBC4LB48Br4CdI402F04hX0eeuRkMt6Q== X-Received: by 2002:a17:90a:c8d:b0:268:196f:9656 with SMTP id v13-20020a17090a0c8d00b00268196f9656mr12999255pja.1.1691406969055; Mon, 07 Aug 2023 04:16:09 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 29/48] bcache: dynamically allocate the md-bcache shrinker Date: Mon, 7 Aug 2023 19:09:17 +0800 Message-Id: <20230807110936.21819-30-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the md-bcache shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct cache_set. Signed-off-by: Qi Zheng --- drivers/md/bcache/bcache.h | 2 +- drivers/md/bcache/btree.c | 27 ++++++++++++++++----------- drivers/md/bcache/sysfs.c | 3 ++- 3 files changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h index 5a79bb3c272f..c622bc50f81b 100644 --- a/drivers/md/bcache/bcache.h +++ b/drivers/md/bcache/bcache.h @@ -541,7 +541,7 @@ struct cache_set { struct bio_set bio_split; /* For the btree cache */ - struct shrinker shrink; + struct shrinker *shrink; /* For the btree cache and anything allocation related */ struct mutex bucket_lock; diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index fd121a61f17c..ae5cbb55861f 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -667,7 +667,7 @@ static int mca_reap(struct btree *b, unsigned int min_order, bool flush) static unsigned long bch_mca_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct cache_set *c = container_of(shrink, struct cache_set, shrink); + struct cache_set *c = shrink->private_data; struct btree *b, *t; unsigned long i, nr = sc->nr_to_scan; unsigned long freed = 0; @@ -734,7 +734,7 @@ static unsigned long bch_mca_scan(struct shrinker *shrink, static unsigned long bch_mca_count(struct shrinker *shrink, struct shrink_control *sc) { - struct cache_set *c = container_of(shrink, struct cache_set, shrink); + struct cache_set *c = shrink->private_data; if (c->shrinker_disabled) return 0; @@ -752,8 +752,8 @@ void bch_btree_cache_free(struct cache_set *c) closure_init_stack(&cl); - if (c->shrink.list.next) - unregister_shrinker(&c->shrink); + if (c->shrink) + shrinker_free(c->shrink); mutex_lock(&c->bucket_lock); @@ -828,14 +828,19 @@ int bch_btree_cache_alloc(struct cache_set *c) c->verify_data = NULL; #endif - c->shrink.count_objects = bch_mca_count; - c->shrink.scan_objects = bch_mca_scan; - c->shrink.seeks = 4; - c->shrink.batch = c->btree_pages * 2; + c->shrink = shrinker_alloc(0, "md-bcache:%pU", c->set_uuid); + if (!c->shrink) { + pr_warn("bcache: %s: could not allocate shrinker\n", __func__); + return 0; + } + + c->shrink->count_objects = bch_mca_count; + c->shrink->scan_objects = bch_mca_scan; + c->shrink->seeks = 4; + c->shrink->batch = c->btree_pages * 2; + c->shrink->private_data = c; - if (register_shrinker(&c->shrink, "md-bcache:%pU", c->set_uuid)) - pr_warn("bcache: %s: could not register shrinker\n", - __func__); + shrinker_register(c->shrink); return 0; } diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 0e2c1880f60b..45d8af755de6 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -866,7 +866,8 @@ STORE(__bch_cache_set) sc.gfp_mask = GFP_KERNEL; sc.nr_to_scan = strtoul_or_return(buf); - c->shrink.scan_objects(&c->shrink, &sc); + if (c->shrink) + c->shrink->scan_objects(c->shrink, &sc); } sysfs_strtoul_clamp(congested_read_threshold_us, -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578080.905356 (Exim 4.92) (envelope-from ) id 1qSyEl-0002gy-Bh; Mon, 07 Aug 2023 11:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578080.905356; Mon, 07 Aug 2023 11:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEl-0002f9-6O; Mon, 07 Aug 2023 11:17:23 +0000 Received: by outflank-mailman (input) for mailman id 578080; Mon, 07 Aug 2023 11:17:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyBX-0002Ee-9B for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:14:03 +0000 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [2607:f8b0:4864:20::534]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 834e3ed1-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:14:02 +0200 (CEST) Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-55b5a37acb6so362204a12.0 for ; Mon, 07 Aug 2023 04:14:02 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:14:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 834e3ed1-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406841; x=1692011641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a0ijFA9s9bGVMHT4vLgTYS12L8yx2Rc7o6TjM9ZoJx8=; b=j23yTPIuNE+5ql7c6DjTIXWDr8oKTSMtsFBsjjClL+S91jhwZsCcQpsRFgnSFEePMC wDGERQ9BkTMGtvLZ5zfdg/UY3HTRyGts+YmZTXabmNDPI0OPAQAqDfrw+jtLBHzydYmo a162rquUe53dODAJSpyuVfvHf3Ov/M30E8XZRIYttEwAxKqQFIS0/ih88OAzPNYyRzzl 3HkOwk/otVmt9H2o9TgGnt1eeNwmmBoINVdlSrRso11GlktIoEp92Q8ZBNulwW/JkpbE xeEGYB8AYsoVpHQBF7XcqQ5QT7dfjGJtE4RXA0EdlD1H8/kYwDQ1OkZhdkl3HITdo9Iq hOkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406841; x=1692011641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a0ijFA9s9bGVMHT4vLgTYS12L8yx2Rc7o6TjM9ZoJx8=; b=a9+2UBveKVbOmBjpxuHqt7LHvskr50YmPUsi0OflXynnbDEvlPJWKDIo26tcLhFMdC swlu2hujAoijYDzGt46YCreGi2mNiO8xAaa6wzIp/agVnwNVbE64KJFJsWxIG0Fkkhc2 PHFo1dMxSOG/53ljwhaOnj8PrmLsvx20oqvy7Zk7mhRkYRPE6r9x+pN4n+vGMRqx0HXJ VOXyXkapmtMW9CGwE+3ZTjLdnwxMgAPrLqF8NSF4WR1+UwyOjddWmcCN3wlIr4aQh/D+ Z8dvyZtMT6+u/BJJS/a7MyScT2E3KcRb+m9iu6qTE6uQ9DYjrrkpyuruI+CX6IEshd5J OzvA== X-Gm-Message-State: AOJu0YzAG5RHtm/HZZ6vKkcj8IotM3skjCPzv8fcKLIgEAos/BapVp27 U3cjMAz0lbYOeISiW+imYLIaXQ== X-Google-Smtp-Source: AGHT+IELWLhV4Bj40lkko/D2F7gtSRcHKPclt9k8JlXsq8dyT7OdoG/0VZRRAUzfMJnehzLNwTS/oA== X-Received: by 2002:a17:90a:2909:b0:269:5bf7:d79c with SMTP id g9-20020a17090a290900b002695bf7d79cmr2214416pjd.1.1691406841328; Mon, 07 Aug 2023 04:14:01 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 19/48] rcu: dynamically allocate the rcu-kfree shrinker Date: Mon, 7 Aug 2023 19:09:07 +0800 Message-Id: <20230807110936.21819-20-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the rcu-kfree shrinker. Signed-off-by: Qi Zheng --- kernel/rcu/tree.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 7c79480bfaa0..3b20fc46c514 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3449,13 +3449,6 @@ kfree_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) return freed == 0 ? SHRINK_STOP : freed; } -static struct shrinker kfree_rcu_shrinker = { - .count_objects = kfree_rcu_shrink_count, - .scan_objects = kfree_rcu_shrink_scan, - .batch = 0, - .seeks = DEFAULT_SEEKS, -}; - void __init kfree_rcu_scheduler_running(void) { int cpu; @@ -4931,6 +4924,7 @@ static void __init kfree_rcu_batch_init(void) { int cpu; int i, j; + struct shrinker *kfree_rcu_shrinker; /* Clamp it to [0:100] seconds interval. */ if (rcu_delay_page_cache_fill_msec < 0 || @@ -4962,8 +4956,18 @@ static void __init kfree_rcu_batch_init(void) INIT_DELAYED_WORK(&krcp->page_cache_work, fill_page_cache_func); krcp->initialized = true; } - if (register_shrinker(&kfree_rcu_shrinker, "rcu-kfree")) - pr_err("Failed to register kfree_rcu() shrinker!\n"); + + kfree_rcu_shrinker = shrinker_alloc(0, "rcu-kfree"); + if (!kfree_rcu_shrinker) { + pr_err("Failed to allocate kfree_rcu() shrinker!\n"); + return; + } + + kfree_rcu_shrinker->count_objects = kfree_rcu_shrink_count; + kfree_rcu_shrinker->scan_objects = kfree_rcu_shrink_scan; + kfree_rcu_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(kfree_rcu_shrinker); } void __init rcu_init(void) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578081.905362 (Exim 4.92) (envelope-from ) id 1qSyEl-0002lb-OY; Mon, 07 Aug 2023 11:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578081.905362; Mon, 07 Aug 2023 11:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEl-0002kD-FZ; Mon, 07 Aug 2023 11:17:23 +0000 Received: by outflank-mailman (input) for mailman id 578081; Mon, 07 Aug 2023 11:17:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyAX-00018O-Mw for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:13:01 +0000 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [2607:f8b0:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5de99339-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:13:00 +0200 (CEST) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bc4dc65aa7so5891685ad.0 for ; Mon, 07 Aug 2023 04:13:00 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:12:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5de99339-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406778; x=1692011578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iXZOOFmuwv6/pQ9jzhgVENlSQpZ5agnqrhquB4Bsoao=; b=g3KOL41mxVnCoIlh87RyEsDJeaXpKCIwoVRjVxhTYPV9ovyT4HRH6y73TA0C1Q2AYh C+3L3G8pIHBsXVWnvOx0AYLweEtefCIlRKKK8q0sPYgt+7jxn0bL+VsW/sqLMELcQU4/ RSW5M4MR9/5lWavNFyTrMZwhNOCIGcyf5LN7etoWY5j2p6K+9KrJUCEBYyshFVPRQ9qE 9NhNeOSkMhfop8u2oBI3A6CKgZEogh2PPWGLFqTsvR6J0EWD/e9GH+/ajfKoDwPmRCfa I4bJZTgzaT9SOC+CveLtEvd/OempVrgFf6BTSlV6Y7dsnz5tzmtW7m2tX5rTM+xAbpCn YMzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406778; x=1692011578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iXZOOFmuwv6/pQ9jzhgVENlSQpZ5agnqrhquB4Bsoao=; b=dw6YQIzrCTJiOTRFwg1LDsSLdtqI0zcKt04rN7wHe53xMNYo581D9WfbuOI2QV2+zw b5kXufSN7/sJg2fs5CjZ4nCFca01eZyZ+5wSYmOlvyua+utSNxNvM+t9e+liBVCfe5iF y4Lan68pZ+tugHwZvrKs85vGn6UtY/GALTnPntTIG58sZmu7oUqTDCxHSco0fixYSbzN A1P62aHyeAh3XbJleBpy1ktUo2aHDQVyKuo3ViXw2GibysoJER8bA7zOzTNMVE1v4Wvr nkqaBMtr8mEWdzFBNWHi3NSXOAqtzxmQPNcQs+WscLFapZzg/HLPkrpJX4xo6QkSy1iF JfyQ== X-Gm-Message-State: ABy/qLZWbJREVdmN75KlkU5ibgJ+8HY6l7o/AS2wfmiqFcu4QopGYV13 34M/UFeThjTsGWL/tuWQ4uf8pg== X-Google-Smtp-Source: APBJJlFDSvCAq9gTdHkFF7Bzn2YL0W/qaEPzJ7AdGJ/zjCXgG1JFMDLiaFr2l43qqes0mOglkhZu9g== X-Received: by 2002:a17:902:f688:b0:1bb:d7d4:e2b with SMTP id l8-20020a170902f68800b001bbd7d40e2bmr33138766plg.0.1691406778592; Mon, 07 Aug 2023 04:12:58 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 14/48] nfs: dynamically allocate the nfs-acl shrinker Date: Mon, 7 Aug 2023 19:09:02 +0800 Message-Id: <20230807110936.21819-15-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the nfs-acl shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/nfs/super.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 2284f749d892..1b5cd0444dda 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -129,11 +129,7 @@ static void nfs_ssc_unregister_ops(void) } #endif /* CONFIG_NFS_V4_2 */ -static struct shrinker acl_shrinker = { - .count_objects = nfs_access_cache_count, - .scan_objects = nfs_access_cache_scan, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *acl_shrinker; /* * Register the NFS filesystems @@ -153,9 +149,19 @@ int __init register_nfs_fs(void) ret = nfs_register_sysctl(); if (ret < 0) goto error_2; - ret = register_shrinker(&acl_shrinker, "nfs-acl"); - if (ret < 0) + + acl_shrinker = shrinker_alloc(0, "nfs-acl"); + if (!acl_shrinker) { + ret = -ENOMEM; goto error_3; + } + + acl_shrinker->count_objects = nfs_access_cache_count; + acl_shrinker->scan_objects = nfs_access_cache_scan; + acl_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(acl_shrinker); + #ifdef CONFIG_NFS_V4_2 nfs_ssc_register_ops(); #endif @@ -175,7 +181,7 @@ int __init register_nfs_fs(void) */ void __exit unregister_nfs_fs(void) { - unregister_shrinker(&acl_shrinker); + shrinker_free(acl_shrinker); nfs_unregister_sysctl(); unregister_nfs4_fs(); #ifdef CONFIG_NFS_V4_2 -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578083.905379 (Exim 4.92) (envelope-from ) id 1qSyEn-0003Gy-1Y; Mon, 07 Aug 2023 11:17:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578083.905379; Mon, 07 Aug 2023 11:17:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEm-0003Gj-Nw; Mon, 07 Aug 2023 11:17:24 +0000 Received: by outflank-mailman (input) for mailman id 578083; Mon, 07 Aug 2023 11:17:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEc-0006s9-Rc for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:17:14 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f577d7a0-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:17:14 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-265c94064b8so593165a91.0 for ; Mon, 07 Aug 2023 04:17:14 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:17:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f577d7a0-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407033; x=1692011833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=48waxWZGd1WUnLYaDrTSxvJywKXLcopaiUkWgt7j5Rg=; b=IF5FMf6vfUKWXKquwpCQEDXlMw21VPTq0vQh30bzDQAe43NcnPpm7+3Lc8a3CIJRpA 3D5+DTGp/GVVz7K0qnRkJHp3ElWCuX/V5mJLE2CMMPVLrH696jMkWhUZV5knoMheDkE7 LNxcBFVMjsAliYNw3/qsjltVAMCexO3SFZuMneEunxblALcqU49wFlwUCGkH4chcrTm+ Mu+nFly5hda7TWhSn6s/LaVQ5cZernQQxFJBPj8H2QEyQDfBEaIAKgcH8kpChkzLsY8n h49b3nM+GUF7t0uuu7NHoFu5rdBXy5wqqQ2n0YE+hiJT0Y6kOYKfZmJPFvsrDsGv9xrG NHZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407033; x=1692011833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=48waxWZGd1WUnLYaDrTSxvJywKXLcopaiUkWgt7j5Rg=; b=IOkLFO6DP6V+f6FDWY17VhrK70pujN2TI2xS4gL2GV2/BuYROdkkzH8nkXcofomKWr YS9aWF2Z54yWqzNuq/l14ORo1cHvGI3UGsL3y0E2rOYXRQiKJEhfnz1Bwm6PSNHIiEV2 eBEjdqvHQ/gYzkzQVWX8ANm2V95RT+JX4p+K24q1a7Sft8a1ZUevkob6mz87Tk2Q1Abl 94xyaM52MCbGX7XVeQgTX0SGkGGKwvAJkrIzdZ6Bj7o+6Nf3p5T4QsFKLjPOvDEwm+aL 1VYmXhWSzZZOFvRoy77GcwI1l9A+mNUK2y+q2d2y1RJAEJk1+8jEYjPq7Q/aBD7lLHJG Ho0g== X-Gm-Message-State: ABy/qLbvvgUEl07B5GRpxaBjTvfgdMFY3U7WpePaEv3UQszqjUPfXa15 eDD7GZwsdRTRfkvI9FZry+OCIQ== X-Google-Smtp-Source: APBJJlHbn14CvO5TR8loNSEkHloCg3xrbjPIwtza5v7TtzUnsc09AI3fvHMVCyYd3DTpdbD1pcNBzw== X-Received: by 2002:a17:90a:4104:b0:25c:1ad3:a4a1 with SMTP id u4-20020a17090a410400b0025c1ad3a4a1mr24600948pjf.1.1691407032801; Mon, 07 Aug 2023 04:17:12 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 34/48] jbd2,ext4: dynamically allocate the jbd2-journal shrinker Date: Mon, 7 Aug 2023 19:09:22 +0800 Message-Id: <20230807110936.21819-35-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the jbd2-journal shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct journal_s. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/jbd2/journal.c | 27 +++++++++++++++++---------- include/linux/jbd2.h | 2 +- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 1b5a45ab62b0..4c421da03fee 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -1298,7 +1298,7 @@ static int jbd2_min_tag_size(void) static unsigned long jbd2_journal_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) { - journal_t *journal = container_of(shrink, journal_t, j_shrinker); + journal_t *journal = shrink->private_data; unsigned long nr_to_scan = sc->nr_to_scan; unsigned long nr_shrunk; unsigned long count; @@ -1324,7 +1324,7 @@ static unsigned long jbd2_journal_shrink_scan(struct shrinker *shrink, static unsigned long jbd2_journal_shrink_count(struct shrinker *shrink, struct shrink_control *sc) { - journal_t *journal = container_of(shrink, journal_t, j_shrinker); + journal_t *journal = shrink->private_data; unsigned long count; count = percpu_counter_read_positive(&journal->j_checkpoint_jh_count); @@ -1412,19 +1412,26 @@ static journal_t *journal_init_common(struct block_device *bdev, journal->j_superblock = (journal_superblock_t *)bh->b_data; journal->j_shrink_transaction = NULL; - journal->j_shrinker.scan_objects = jbd2_journal_shrink_scan; - journal->j_shrinker.count_objects = jbd2_journal_shrink_count; - journal->j_shrinker.seeks = DEFAULT_SEEKS; - journal->j_shrinker.batch = journal->j_max_transaction_buffers; if (percpu_counter_init(&journal->j_checkpoint_jh_count, 0, GFP_KERNEL)) goto err_cleanup; - if (register_shrinker(&journal->j_shrinker, "jbd2-journal:(%u:%u)", - MAJOR(bdev->bd_dev), MINOR(bdev->bd_dev))) { + journal->j_shrinker = shrinker_alloc(0, "jbd2-journal:(%u:%u)", + MAJOR(bdev->bd_dev), + MINOR(bdev->bd_dev)); + if (!journal->j_shrinker) { percpu_counter_destroy(&journal->j_checkpoint_jh_count); goto err_cleanup; } + + journal->j_shrinker->scan_objects = jbd2_journal_shrink_scan; + journal->j_shrinker->count_objects = jbd2_journal_shrink_count; + journal->j_shrinker->seeks = DEFAULT_SEEKS; + journal->j_shrinker->batch = journal->j_max_transaction_buffers; + journal->j_shrinker->private_data = journal; + + shrinker_register(journal->j_shrinker); + return journal; err_cleanup: @@ -2187,9 +2194,9 @@ int jbd2_journal_destroy(journal_t *journal) brelse(journal->j_sb_buffer); } - if (journal->j_shrinker.flags & SHRINKER_REGISTERED) { + if (journal->j_shrinker) { percpu_counter_destroy(&journal->j_checkpoint_jh_count); - unregister_shrinker(&journal->j_shrinker); + shrinker_free(journal->j_shrinker); } if (journal->j_proc_entry) jbd2_stats_proc_exit(journal); diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index 44c298aa58d4..beb4c4586320 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -891,7 +891,7 @@ struct journal_s * Journal head shrinker, reclaim buffer's journal head which * has been written back. */ - struct shrinker j_shrinker; + struct shrinker *j_shrinker; /** * @j_checkpoint_jh_count: -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578084.905386 (Exim 4.92) (envelope-from ) id 1qSyEn-0003RY-KJ; Mon, 07 Aug 2023 11:17:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578084.905386; Mon, 07 Aug 2023 11:17:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEn-0003QK-Bc; Mon, 07 Aug 2023 11:17:25 +0000 Received: by outflank-mailman (input) for mailman id 578084; Mon, 07 Aug 2023 11:17:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy9F-00018O-Mu for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:11:41 +0000 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [2607:f8b0:4864:20::52c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e354f43-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:11:40 +0200 (CEST) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-56462258cdeso525477a12.1 for ; Mon, 07 Aug 2023 04:11:40 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:11:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e354f43-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406698; x=1692011498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bO4yc6b0222dRNj48HoFyPuU9QjRVolFKKVhhMGpLKw=; b=V+0c3qPhJ3OvHdRK0zt0jjicV8eIk4mcEJBfZa3lpQkwu54lWNVPIEieS4PtRydxoC SOQosWaNmtA5ijvBvBTHzjmbD0d0j9BAeGMmaW/jH6uvD6Ej2n/njXM3uIqGlzrBkh1f 4pNHqPhVUKAnLp7tAzH1vcGObvmfuMOiL8NrO6wDjhRhzYUa1svLTbbXU3r4juxNC7M+ zvZ3SM7T/9w0Je9dQGJ4Z6qlkuAYn1bir+6JxlC1Qr6arztdDyFiMoqBolNxM3VBbd9i jsX4xXrnwmvTP/fkwCWNcOiK6G4rP96fjoeNSyiOnE04LmSKfInS+5dfsRm42DUoM8bY LffQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406698; x=1692011498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bO4yc6b0222dRNj48HoFyPuU9QjRVolFKKVhhMGpLKw=; b=S+gtDzgJi9RgbxzZGhKRxqLqjsfs8yQMh0ZwZmwBs4FXnoD6OEyspDLy3JfFogwx5D 7x4u2l7cxr3mmWiHbtsPdkFpnSFHRukbEmC9m2qsk24GWDtmPlOcwHGoeKByZCS5Dqzz RG6LAiVD1S9UqAfu3vwpEm6bkj82uoGfHeZ15LHxKO68fTH5xlBZcQJVpFSyY/cfziPA PI/Aa6Kd+BL76M9ScYuVUJR2lEC1F9tQIdbXr3vdBbR5Gx7lYH+PMvuEP9WEpRvFQ4kW nsJyb/f4NJ/RSN/BWoL91bfoWeRdvZ0ph5HXgn1otk3sEj9+PIAGkIXYs3o5aMW9C73J XGLw== X-Gm-Message-State: ABy/qLaORUOrMFs+5YyEM+yRQV/97CI6GcOp/f1jT/PXb7RMxy4JVbrZ j2RbGJZaLI3fSWkkSxFW799vvg== X-Google-Smtp-Source: APBJJlHTPEiI4d70NxX2nHst3XkAfiDRggXx1NmGRpA10Zf8iDezZWW8ih32EzxQIqpHPiYHvUOM5w== X-Received: by 2002:a17:90a:1f83:b0:268:3dc6:f0c5 with SMTP id x3-20020a17090a1f8300b002683dc6f0c5mr25027705pja.0.1691406698603; Mon, 07 Aug 2023 04:11:38 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 08/48] xenbus/backend: dynamically allocate the xen-backend shrinker Date: Mon, 7 Aug 2023 19:08:56 +0800 Message-Id: <20230807110936.21819-9-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the xen-backend shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/xen/xenbus/xenbus_probe_backend.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_probe_backend.c b/drivers/xen/xenbus/xenbus_probe_backend.c index da96c260e26b..929c41a5ccee 100644 --- a/drivers/xen/xenbus/xenbus_probe_backend.c +++ b/drivers/xen/xenbus/xenbus_probe_backend.c @@ -284,13 +284,9 @@ static unsigned long backend_shrink_memory_count(struct shrinker *shrinker, return 0; } -static struct shrinker backend_memory_shrinker = { - .count_objects = backend_shrink_memory_count, - .seeks = DEFAULT_SEEKS, -}; - static int __init xenbus_probe_backend_init(void) { + struct shrinker *backend_memory_shrinker; static struct notifier_block xenstore_notifier = { .notifier_call = backend_probe_and_watch }; @@ -305,8 +301,16 @@ static int __init xenbus_probe_backend_init(void) register_xenstore_notifier(&xenstore_notifier); - if (register_shrinker(&backend_memory_shrinker, "xen-backend")) - pr_warn("shrinker registration failed\n"); + backend_memory_shrinker = shrinker_alloc(0, "xen-backend"); + if (!backend_memory_shrinker) { + pr_warn("shrinker allocation failed\n"); + return 0; + } + + backend_memory_shrinker->count_objects = backend_shrink_memory_count; + backend_memory_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(backend_memory_shrinker); return 0; } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578085.905392 (Exim 4.92) (envelope-from ) id 1qSyEo-0003Zk-4n; Mon, 07 Aug 2023 11:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578085.905392; Mon, 07 Aug 2023 11:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEn-0003Wo-RS; Mon, 07 Aug 2023 11:17:25 +0000 Received: by outflank-mailman (input) for mailman id 578085; Mon, 07 Aug 2023 11:17:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyAI-0002Ee-Me for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:12:46 +0000 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [2607:f8b0:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5595243c-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:12:46 +0200 (CEST) Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-5643140aa5fso525574a12.0 for ; Mon, 07 Aug 2023 04:12:46 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.12.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:12:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5595243c-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406764; x=1692011564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XXAG7UeexodYStcT1Y2gz+/6q+0E2xrK+D1h2eKApUE=; b=aL2IlnUybxJBSaUyx5/2hb4H2bp/OBgBmpkvxoB1jU+rSMlmYgotW9aghIyS5IGFTu jFnKPHdHImGCYC2E/ABE0MKtaUZM35JefrItnSynMzWwfh9y6Muq0ow4RXH7tUjQQfcP Mb/jNbJTqI64OH5TZAbe/9B64ipZHwjSbqJcPzS81ONTFfdvn1WQf8A1oxt4tY2+xFm3 qLJTVdHdHHLy/H07ztqOBHi1YT6PCSLEiwm3BmVRH+v8KbcNGmsDXIWIkoSvX1jpUSeE +aIaBM9zmcPun7sjvVC0D+UUovECfFdX/YnWZ3U8UI2BqXU1g5ckeiBNnyvyn5q9jj5E E1iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406764; x=1692011564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XXAG7UeexodYStcT1Y2gz+/6q+0E2xrK+D1h2eKApUE=; b=dQX6705DPjzunt2g8qxVj7STH4MWJ7ls415nxeRKx8p210z0y+IqwQXU/9S+uBunX1 Szov0NEy5Fz930rg0d0/SXMjnsMPsfJ0y68zzgiOicS4zOkw0Tjok+Paxe3SeZCQFDw6 YTgnl4fNoPk7dNg5M804wL6IKZ1t5O9/5JCcD0xG6Cp9T7q9PND3RzOwLhxYWUy8D66t Jhm+JcMk8Fmcv1/ZOhrpjN6XqOBSXkYcx2trWCFZZmJHuzH2q71QDopw1uBkKuZcV0Vf HepziZr+93F8ikMPxTkxXWzbZsisVv9LFSNhc84OZT7FV7KFTBB92JbpoxjP4LOuI1fY Qilg== X-Gm-Message-State: AOJu0YwleglX/Jg1EOVM/rUIbaWj1l+unhJvBG7kJjlADpAIYOFHX68F nGcqRldgPuhzpM/A9y5CqO8gFA== X-Google-Smtp-Source: AGHT+IE0EldDhRUbVC2QQ5qQQy0UrFFq3L83zUgt+LShkd8AG+beTExy84fPX5FeRRz/rZ+raVP35g== X-Received: by 2002:a17:90a:9c3:b0:269:41cf:7212 with SMTP id 61-20020a17090a09c300b0026941cf7212mr4959141pjo.4.1691406764622; Mon, 07 Aug 2023 04:12:44 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 13/48] NFSv4.2: dynamically allocate the nfs-xattr shrinkers Date: Mon, 7 Aug 2023 19:09:01 +0800 Message-Id: <20230807110936.21819-14-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the nfs-xattr shrinkers. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/nfs/nfs42xattr.c | 87 +++++++++++++++++++++++---------------------- 1 file changed, 44 insertions(+), 43 deletions(-) diff --git a/fs/nfs/nfs42xattr.c b/fs/nfs/nfs42xattr.c index 911f634ba3da..2ad66a8922f4 100644 --- a/fs/nfs/nfs42xattr.c +++ b/fs/nfs/nfs42xattr.c @@ -796,28 +796,9 @@ static unsigned long nfs4_xattr_cache_scan(struct shrinker *shrink, static unsigned long nfs4_xattr_entry_scan(struct shrinker *shrink, struct shrink_control *sc); -static struct shrinker nfs4_xattr_cache_shrinker = { - .count_objects = nfs4_xattr_cache_count, - .scan_objects = nfs4_xattr_cache_scan, - .seeks = DEFAULT_SEEKS, - .flags = SHRINKER_MEMCG_AWARE, -}; - -static struct shrinker nfs4_xattr_entry_shrinker = { - .count_objects = nfs4_xattr_entry_count, - .scan_objects = nfs4_xattr_entry_scan, - .seeks = DEFAULT_SEEKS, - .batch = 512, - .flags = SHRINKER_MEMCG_AWARE, -}; - -static struct shrinker nfs4_xattr_large_entry_shrinker = { - .count_objects = nfs4_xattr_entry_count, - .scan_objects = nfs4_xattr_entry_scan, - .seeks = 1, - .batch = 512, - .flags = SHRINKER_MEMCG_AWARE, -}; +static struct shrinker *nfs4_xattr_cache_shrinker; +static struct shrinker *nfs4_xattr_entry_shrinker; +static struct shrinker *nfs4_xattr_large_entry_shrinker; static enum lru_status cache_lru_isolate(struct list_head *item, @@ -943,7 +924,7 @@ nfs4_xattr_entry_scan(struct shrinker *shrink, struct shrink_control *sc) struct nfs4_xattr_entry *entry; struct list_lru *lru; - lru = (shrink == &nfs4_xattr_large_entry_shrinker) ? + lru = (shrink == nfs4_xattr_large_entry_shrinker) ? &nfs4_xattr_large_entry_lru : &nfs4_xattr_entry_lru; freed = list_lru_shrink_walk(lru, sc, entry_lru_isolate, &dispose); @@ -971,7 +952,7 @@ nfs4_xattr_entry_count(struct shrinker *shrink, struct shrink_control *sc) unsigned long count; struct list_lru *lru; - lru = (shrink == &nfs4_xattr_large_entry_shrinker) ? + lru = (shrink == nfs4_xattr_large_entry_shrinker) ? &nfs4_xattr_large_entry_lru : &nfs4_xattr_entry_lru; count = list_lru_shrink_count(lru, sc); @@ -991,18 +972,34 @@ static void nfs4_xattr_cache_init_once(void *p) INIT_LIST_HEAD(&cache->dispose); } -static int nfs4_xattr_shrinker_init(struct shrinker *shrinker, - struct list_lru *lru, const char *name) +typedef unsigned long (*count_objects_cb)(struct shrinker *s, + struct shrink_control *sc); +typedef unsigned long (*scan_objects_cb)(struct shrinker *s, + struct shrink_control *sc); + +static int __init nfs4_xattr_shrinker_init(struct shrinker **shrinker, + struct list_lru *lru, const char *name, + count_objects_cb count, + scan_objects_cb scan, long batch, int seeks) { - int ret = 0; + int ret; - ret = register_shrinker(shrinker, name); - if (ret) + *shrinker = shrinker_alloc(SHRINKER_MEMCG_AWARE, name); + if (!*shrinker) + return -ENOMEM; + + ret = list_lru_init_memcg(lru, *shrinker); + if (ret) { + shrinker_free(*shrinker); return ret; + } - ret = list_lru_init_memcg(lru, shrinker); - if (ret) - unregister_shrinker(shrinker); + (*shrinker)->count_objects = count; + (*shrinker)->scan_objects = scan; + (*shrinker)->batch = batch; + (*shrinker)->seeks = seeks; + + shrinker_register(*shrinker); return ret; } @@ -1010,7 +1007,7 @@ static int nfs4_xattr_shrinker_init(struct shrinker *shrinker, static void nfs4_xattr_shrinker_destroy(struct shrinker *shrinker, struct list_lru *lru) { - unregister_shrinker(shrinker); + shrinker_free(shrinker); list_lru_destroy(lru); } @@ -1026,27 +1023,31 @@ int __init nfs4_xattr_cache_init(void) return -ENOMEM; ret = nfs4_xattr_shrinker_init(&nfs4_xattr_cache_shrinker, - &nfs4_xattr_cache_lru, - "nfs-xattr_cache"); + &nfs4_xattr_cache_lru, "nfs-xattr_cache", + nfs4_xattr_cache_count, + nfs4_xattr_cache_scan, 0, DEFAULT_SEEKS); if (ret) goto out1; ret = nfs4_xattr_shrinker_init(&nfs4_xattr_entry_shrinker, - &nfs4_xattr_entry_lru, - "nfs-xattr_entry"); + &nfs4_xattr_entry_lru, "nfs-xattr_entry", + nfs4_xattr_entry_count, + nfs4_xattr_entry_scan, 512, DEFAULT_SEEKS); if (ret) goto out2; ret = nfs4_xattr_shrinker_init(&nfs4_xattr_large_entry_shrinker, &nfs4_xattr_large_entry_lru, - "nfs-xattr_large_entry"); + "nfs-xattr_large_entry", + nfs4_xattr_entry_count, + nfs4_xattr_entry_scan, 512, 1); if (!ret) return 0; - nfs4_xattr_shrinker_destroy(&nfs4_xattr_entry_shrinker, + nfs4_xattr_shrinker_destroy(nfs4_xattr_entry_shrinker, &nfs4_xattr_entry_lru); out2: - nfs4_xattr_shrinker_destroy(&nfs4_xattr_cache_shrinker, + nfs4_xattr_shrinker_destroy(nfs4_xattr_cache_shrinker, &nfs4_xattr_cache_lru); out1: kmem_cache_destroy(nfs4_xattr_cache_cachep); @@ -1056,11 +1057,11 @@ int __init nfs4_xattr_cache_init(void) void nfs4_xattr_cache_exit(void) { - nfs4_xattr_shrinker_destroy(&nfs4_xattr_large_entry_shrinker, + nfs4_xattr_shrinker_destroy(nfs4_xattr_large_entry_shrinker, &nfs4_xattr_large_entry_lru); - nfs4_xattr_shrinker_destroy(&nfs4_xattr_entry_shrinker, + nfs4_xattr_shrinker_destroy(nfs4_xattr_entry_shrinker, &nfs4_xattr_entry_lru); - nfs4_xattr_shrinker_destroy(&nfs4_xattr_cache_shrinker, + nfs4_xattr_shrinker_destroy(nfs4_xattr_cache_shrinker, &nfs4_xattr_cache_lru); kmem_cache_destroy(nfs4_xattr_cache_cachep); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578087.905400 (Exim 4.92) (envelope-from ) id 1qSyEo-0003kc-N2; Mon, 07 Aug 2023 11:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578087.905400; Mon, 07 Aug 2023 11:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEo-0003g0-AV; Mon, 07 Aug 2023 11:17:26 +0000 Received: by outflank-mailman (input) for mailman id 578087; Mon, 07 Aug 2023 11:17:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyBK-0002Ee-V3 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:13:50 +0000 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [2607:f8b0:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7becbc7e-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:13:50 +0200 (CEST) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-55b78bf0423so391759a12.0 for ; Mon, 07 Aug 2023 04:13:50 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:13:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7becbc7e-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406829; x=1692011629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GSWsN00ewH1CUxuL2on0amogNZtYjpfZMPk3tXk1MLc=; b=dRL5OTw58GKSKLSEPIkOk3RNFcmmAqsiLvwXwuCsQ6898crZQ//U31N7J6aETctBqp +yNfSzW4P67hr/Q5en6KlpeaCzhuSArK09Uv1s7rX7JtU6KCmHd6Mqm/4AQ65zu5m5Io c0AgOv8G8SDnrmCDqGvw9U9rsdHywgcFHequBwptONEnrpN+7djJ7c1au1NclddO4RuF fGkbwSFA8neTzyjHzVx+h2JTuM9t2Q0O3KvbIWMUOl7gxPC5QUE4BflF3xVEC1ALf5VX oJ+rwFdIWe78RvMraM76IWcwrhx+7xBzgx3bdbJKVCqu0ytQTpll1s2Np/nEdRD5cowd HYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406829; x=1692011629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GSWsN00ewH1CUxuL2on0amogNZtYjpfZMPk3tXk1MLc=; b=bJMUGyQwZhvvuDyqQyVET4Uug+0iJLBjuXzQpvlxLLaQWAnWvmFnjIe3t4Tg/urD72 EU3X9Wke6qcIyVxszCcqE9fLqsQfMYseSNdfEOcVdPb346UUqDuLIBLLyt+UPgMpbylQ mkAfNKwa7/JUipeS3HmFY3c1xdMCF/gI2tp7yJtXPAxog5eVaVdYSag6DDCkM0yewH9w TBZOgH0Vuwitb/tvEN+cNhG7vAPW+w5cc7+sT/26LbpLyD0DSZB4UwiXb4V92+8oVprQ 9zvwP3/FuH7oelz6DfLT/p9cvqjpw/L+FSbyquEp3tPJWqpR1sdBDj9PKblFyiAIDv3H uEHg== X-Gm-Message-State: ABy/qLZAfeAEhMtUr2z1abXqLJNPqbSzePI5ARJ4/Wih/QrjXugEWnO0 JPg67pO5Pt9gB+9VYafXc8SupQ== X-Google-Smtp-Source: APBJJlEEwhe0wjgrc7nxC5j9G5K3ZI0sWgwDykpBRAx7nLtKV2LZNd6jgA89VvGSaryf9LAeIFxakg== X-Received: by 2002:a17:90a:901:b0:268:3a31:3e4d with SMTP id n1-20020a17090a090100b002683a313e4dmr23070871pjn.2.1691406828996; Mon, 07 Aug 2023 04:13:48 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 18/48] rcu: dynamically allocate the rcu-lazy shrinker Date: Mon, 7 Aug 2023 19:09:06 +0800 Message-Id: <20230807110936.21819-19-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the rcu-lazy shrinker. Signed-off-by: Qi Zheng --- kernel/rcu/tree_nocb.h | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 5598212d1f27..e1c59c33738a 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -1396,13 +1396,6 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) return count ? count : SHRINK_STOP; } - -static struct shrinker lazy_rcu_shrinker = { - .count_objects = lazy_rcu_shrink_count, - .scan_objects = lazy_rcu_shrink_scan, - .batch = 0, - .seeks = DEFAULT_SEEKS, -}; #endif // #ifdef CONFIG_RCU_LAZY void __init rcu_init_nohz(void) @@ -1410,6 +1403,7 @@ void __init rcu_init_nohz(void) int cpu; struct rcu_data *rdp; const struct cpumask *cpumask = NULL; + struct shrinker * __maybe_unused lazy_rcu_shrinker; #if defined(CONFIG_NO_HZ_FULL) if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)) @@ -1436,8 +1430,16 @@ void __init rcu_init_nohz(void) return; #ifdef CONFIG_RCU_LAZY - if (register_shrinker(&lazy_rcu_shrinker, "rcu-lazy")) - pr_err("Failed to register lazy_rcu shrinker!\n"); + lazy_rcu_shrinker = shrinker_alloc(0, "rcu-lazy"); + if (!lazy_rcu_shrinker) { + pr_err("Failed to allocate lazy_rcu shrinker!\n"); + } else { + lazy_rcu_shrinker->count_objects = lazy_rcu_shrink_count; + lazy_rcu_shrinker->scan_objects = lazy_rcu_shrink_scan; + lazy_rcu_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(lazy_rcu_shrinker); + } #endif // #ifdef CONFIG_RCU_LAZY if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) { -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578088.905413 (Exim 4.92) (envelope-from ) id 1qSyEq-0004Dv-4Q; Mon, 07 Aug 2023 11:17:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578088.905413; Mon, 07 Aug 2023 11:17:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEp-0004C9-Sz; Mon, 07 Aug 2023 11:17:27 +0000 Received: by outflank-mailman (input) for mailman id 578088; Mon, 07 Aug 2023 11:17:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyB8-0002Ee-OW for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:13:38 +0000 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [2607:f8b0:4864:20::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 749e73d5-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:13:38 +0200 (CEST) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1bc76cdf0cbso595335ad.1 for ; Mon, 07 Aug 2023 04:13:38 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:13:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 749e73d5-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406816; x=1692011616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=et7oKjMo2RpAm9eGe6PO8KzXkO6yMET8jj6KuxhxE1o=; b=LikGQLIJYBMaIhLRv2oXwUZ1S5/lUocFnmTR+FYR6Ek9DrdoATbLs4CDlynPte0jm9 +o4McGrgBARlkb75OrdIWJKTn+TAsEnotraDhrP3rtl6y6q5edkiQAwqNgCpWHEQGLxu GHvaWLUFDnTHEHQY8B66ZCvfeUOtDRooCdq2e8FvhkYGE0+2kW031xfZ/1GeTTnnyACe erVR01yoMD1wcFa+90Rr7nUgrj+jHy2UHL/0KieWzuXqT/QJWuskjH4/gIAZtbTfNj8h rLHAUVp+wWaVi0Nz3/+zkqLaFK0QZUGbmHkke0Mu+daDajI/xmbze4i5ZAJyYAfaC1ge umJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406816; x=1692011616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=et7oKjMo2RpAm9eGe6PO8KzXkO6yMET8jj6KuxhxE1o=; b=bbls2+I+i31HLCrym91HF8qetfuWEIq9Fx2x2EGUbiHpZideXIJsBnJKknHOi+6BA8 vRS5KBqh2isbNar5all8w4t+6V5o+jSLeBuHZHw3xGKIpYtahe2h98+9kS52JQUiJSyq nVp3xCQlQeBX9SYjCCNlQjeIAvwW2fhaW9KJJbukGZA0QeCche1cs0n/uWsrFvqxenjS c1120HAsF0jXzpUPELrBTVPMcGqQThTns30Bj2flqpceLiurjfpUXmBQeg5K82FMPKoC K1+KMMA0DDkUcvadcDSYP4HcXnd8ynKRBsNw99k7Dxl7lF9ceZWHs9p/AJXM3XGD8U/I BEHg== X-Gm-Message-State: ABy/qLbzx8eUf/R4ZXlrXMid8ZQTRLMlgZDT7pK6uPn9sAOgRv9NQFN8 2E3Cw5FaGSzlPgVAoYwgT9Tl5A== X-Google-Smtp-Source: APBJJlF9QaWRkA2HFZAXDPGIksSZq6NqNIS7MDluuBXjMUyGz8OacRKwa0/I1dCKrdRRT8VidP2X/g== X-Received: by 2002:a17:902:ea04:b0:1b8:a27d:f591 with SMTP id s4-20020a170902ea0400b001b8a27df591mr32781910plg.5.1691406816716; Mon, 07 Aug 2023 04:13:36 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 17/48] ubifs: dynamically allocate the ubifs-slab shrinker Date: Mon, 7 Aug 2023 19:09:05 +0800 Message-Id: <20230807110936.21819-18-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the ubifs-slab shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/ubifs/super.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index b08fb28d16b5..c690782388a8 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -54,11 +54,7 @@ module_param_cb(default_version, &ubifs_default_version_ops, &ubifs_default_vers static struct kmem_cache *ubifs_inode_slab; /* UBIFS TNC shrinker description */ -static struct shrinker ubifs_shrinker_info = { - .scan_objects = ubifs_shrink_scan, - .count_objects = ubifs_shrink_count, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *ubifs_shrinker_info; /** * validate_inode - validate inode. @@ -2373,7 +2369,7 @@ static void inode_slab_ctor(void *obj) static int __init ubifs_init(void) { - int err; + int err = -ENOMEM; BUILD_BUG_ON(sizeof(struct ubifs_ch) != 24); @@ -2439,10 +2435,16 @@ static int __init ubifs_init(void) if (!ubifs_inode_slab) return -ENOMEM; - err = register_shrinker(&ubifs_shrinker_info, "ubifs-slab"); - if (err) + ubifs_shrinker_info = shrinker_alloc(0, "ubifs-slab"); + if (!ubifs_shrinker_info) goto out_slab; + ubifs_shrinker_info->count_objects = ubifs_shrink_count; + ubifs_shrinker_info->scan_objects = ubifs_shrink_scan; + ubifs_shrinker_info->seeks = DEFAULT_SEEKS; + + shrinker_register(ubifs_shrinker_info); + err = ubifs_compressors_init(); if (err) goto out_shrinker; @@ -2467,7 +2469,7 @@ static int __init ubifs_init(void) dbg_debugfs_exit(); ubifs_compressors_exit(); out_shrinker: - unregister_shrinker(&ubifs_shrinker_info); + shrinker_free(ubifs_shrinker_info); out_slab: kmem_cache_destroy(ubifs_inode_slab); return err; @@ -2483,7 +2485,7 @@ static void __exit ubifs_exit(void) dbg_debugfs_exit(); ubifs_sysfs_exit(); ubifs_compressors_exit(); - unregister_shrinker(&ubifs_shrinker_info); + shrinker_free(ubifs_shrinker_info); /* * Make sure all delayed rcu free inodes are flushed before we -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578090.905431 (Exim 4.92) (envelope-from ) id 1qSyEw-0005CH-VN; Mon, 07 Aug 2023 11:17:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578090.905431; Mon, 07 Aug 2023 11:17:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEw-0005Bt-Nm; Mon, 07 Aug 2023 11:17:34 +0000 Received: by outflank-mailman (input) for mailman id 578090; Mon, 07 Aug 2023 11:17:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyDO-0006s9-H3 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:15:58 +0000 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [2607:f8b0:4864:20::1033]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7faa358-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:15:58 +0200 (CEST) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2684e225a6cso660974a91.1 for ; Mon, 07 Aug 2023 04:15:57 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:15:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7faa358-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406956; x=1692011756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x1yZWn5jqhhXD5GlPCwn7Rqy/lqVgw4fKiPcfLbuAyw=; b=AcIjUBUrPWg0UzvX5wfFusVN+dKafMdFSH2GRzDH1OvYCulGxI33IbPnGkf00jzcfm 4A2gtuaaMbbtp6GdbHcVvPsXNRG1dmOn4MOltHcp0lO1ZvH61PsHri+EHSBurlaP3++Q 4Ay4mp+CERsWHNo0m/mtiLtHugH42cl3pUwAYaJdXbMqhQOvO09TYlTgMkhLAJn4/X6x i3g9KcsL+Xka9qDqamdAs09xw8L3SMlDoJ+EPUs9bBOqEWf8CI1XS8GEbt6nh07SwXhK J3x/B99DfdJVBmu0rw2+YUXatA5oQZwE4RwMladVYflBE1HvjLGyTI12ejp5Woqr/FOF LWLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406956; x=1692011756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x1yZWn5jqhhXD5GlPCwn7Rqy/lqVgw4fKiPcfLbuAyw=; b=fHMuOLLF5QKRDZJMkN9pEmQd5u/Oiz0CDM3SQ+3FuIPmXEQqN/ODMr6BM8NkzMRjRC IJWyoStlqxLdOFaacAyPJj7Ucv5Q+7FHPAQRZDaEW7O0puPELW2v7bbcXNYmRHUcWeLE UUUTqus9hC2cfZ+xnOwMtbGvDG/OfPpjCvflo0W2TTDMJGrN93C78kImrxBpS2UW7XKQ TG8X5KHzvXVhmQeoOmq6kWhhuLqrM/KkCk54V3E+iNmgzSFnYt+aBpAQzlLfN+Buoy5Q u+7ATAfQKx0y1VH2a+V06Qda8TZrmRfY/v/tvLaWBBn/Uac5V+YO5rvJF6dBuIgBbK6e eDtw== X-Gm-Message-State: AOJu0YxQcIR7SJR3bFFPvurLYwc12YvpoGptx3qGt9h9j72qbARLeudc nq1fvtWPmcHUIfxhH2uruxeL3w== X-Google-Smtp-Source: AGHT+IFmiFe8iRG7X1ND7nrFgfyiRFI3F00Omyk3P1Mi12alvC2oRACqfoDpuN1VIlTmyfJiX72rxw== X-Received: by 2002:a17:90a:2909:b0:269:5bf7:d79c with SMTP id g9-20020a17090a290900b002695bf7d79cmr2218056pjd.1.1691406956537; Mon, 07 Aug 2023 04:15:56 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 28/48] md/raid5: dynamically allocate the md-raid5 shrinker Date: Mon, 7 Aug 2023 19:09:16 +0800 Message-Id: <20230807110936.21819-29-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the md-raid5 shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct r5conf. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/md/raid5.c | 26 +++++++++++++++----------- drivers/md/raid5.h | 2 +- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 32a87193bad7..e284c2f7dbe4 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -7401,7 +7401,7 @@ static void free_conf(struct r5conf *conf) log_exit(conf); - unregister_shrinker(&conf->shrinker); + shrinker_free(conf->shrinker); free_thread_groups(conf); shrink_stripes(conf); raid5_free_percpu(conf); @@ -7449,7 +7449,7 @@ static int raid5_alloc_percpu(struct r5conf *conf) static unsigned long raid5_cache_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct r5conf *conf = container_of(shrink, struct r5conf, shrinker); + struct r5conf *conf = shrink->private_data; unsigned long ret = SHRINK_STOP; if (mutex_trylock(&conf->cache_size_mutex)) { @@ -7470,7 +7470,7 @@ static unsigned long raid5_cache_scan(struct shrinker *shrink, static unsigned long raid5_cache_count(struct shrinker *shrink, struct shrink_control *sc) { - struct r5conf *conf = container_of(shrink, struct r5conf, shrinker); + struct r5conf *conf = shrink->private_data; if (conf->max_nr_stripes < conf->min_nr_stripes) /* unlikely, but not impossible */ @@ -7705,18 +7705,22 @@ static struct r5conf *setup_conf(struct mddev *mddev) * it reduces the queue depth and so can hurt throughput. * So set it rather large, scaled by number of devices. */ - conf->shrinker.seeks = DEFAULT_SEEKS * conf->raid_disks * 4; - conf->shrinker.scan_objects = raid5_cache_scan; - conf->shrinker.count_objects = raid5_cache_count; - conf->shrinker.batch = 128; - conf->shrinker.flags = 0; - ret = register_shrinker(&conf->shrinker, "md-raid5:%s", mdname(mddev)); - if (ret) { - pr_warn("md/raid:%s: couldn't register shrinker.\n", + conf->shrinker = shrinker_alloc(0, "md-raid5:%s", mdname(mddev)); + if (!conf->shrinker) { + ret = -ENOMEM; + pr_warn("md/raid:%s: couldn't allocate shrinker.\n", mdname(mddev)); goto abort; } + conf->shrinker->seeks = DEFAULT_SEEKS * conf->raid_disks * 4; + conf->shrinker->scan_objects = raid5_cache_scan; + conf->shrinker->count_objects = raid5_cache_count; + conf->shrinker->batch = 128; + conf->shrinker->private_data = conf; + + shrinker_register(conf->shrinker); + sprintf(pers_name, "raid%d", mddev->new_level); rcu_assign_pointer(conf->thread, md_register_thread(raid5d, mddev, pers_name)); diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h index 97a795979a35..22bea20eccbd 100644 --- a/drivers/md/raid5.h +++ b/drivers/md/raid5.h @@ -670,7 +670,7 @@ struct r5conf { wait_queue_head_t wait_for_stripe; wait_queue_head_t wait_for_overlap; unsigned long cache_state; - struct shrinker shrinker; + struct shrinker *shrinker; int pool_size; /* number of disks in stripeheads in pool */ spinlock_t device_lock; struct disk_info *disks; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578092.905434 (Exim 4.92) (envelope-from ) id 1qSyEx-0005IR-FR; Mon, 07 Aug 2023 11:17:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578092.905434; Mon, 07 Aug 2023 11:17:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEx-0005FN-4U; Mon, 07 Aug 2023 11:17:35 +0000 Received: by outflank-mailman (input) for mailman id 578092; Mon, 07 Aug 2023 11:17:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyDn-0006s9-M8 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:16:23 +0000 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [2607:f8b0:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d70680d7-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:16:23 +0200 (CEST) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5643140aa5fso526450a12.0 for ; Mon, 07 Aug 2023 04:16:23 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:16:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d70680d7-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406982; x=1692011782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2n4eBW/y496rw0R30jGqgr9PaTd+TyGx4MFgxeJTY98=; b=FnWDWj5rwzmfFGLsv5BbODxTKmQBAUJaoO/xwiU3xtz9tOZ2AwDnatjsq2ab3ilYeJ iWF7FCg8OfJEY1lx/DDczF41LpfDlE6nRRduQxYHOyP9X3uK7n/ZO9q7VAhZSG3xs95Q OqWz/XghzU3SfaeMxwONvmK/HIjBzGEUASf2JFKX93u1G15t5fAwcHUsocilVhQXHkyU J1tWV2QNpc4U36fDDO4ejlIhucfEnNm2u0Wt3z4T4cfN7wJRCQagqckfUu/vztdG0xlS Buj0JJnUwu7QR/DBMG2ve3ld5n35BuwOJKjICt4m1cvU7hXO7dkM+KrhCZs3CTAs8/64 gYbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406982; x=1692011782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2n4eBW/y496rw0R30jGqgr9PaTd+TyGx4MFgxeJTY98=; b=igIZy/9V3b34YvgWjnSj6z4EwxK4KdTd70zHOPx3DW9KtoRq9pbwVExLgwS84WFdL/ Gkw6lIFGerii6CqTdbAjRlh0uR1xW97INZmWXRj0Xh/NDIS2AxeoEOqhfCudZIA08R9x Y8ivEd59a/tZZlhy1j44smSgQLF0T3WQZFN4/fpUibAZJ7sFNMYDWpPNkWK7CrJqRNlU ngAAFv9sOmXSQNx0CWGMLtyCK/7tcRlAVzlyCE7m+BxJtIrExRL4FEhdWkKw6JnCY6ZF fbDx4Ed82R2FWNQ2lLrLX4eXN/X+1pS5k4Yxk+TZVF0NKnx0hwns8sAhl1KEVBRyvrvG fTXQ== X-Gm-Message-State: ABy/qLZr6tYxGC/HyLgvZoZIsiX6IUNBCrE2w1Bx8Ax+Z1wuHTHcKOBb OhIWKyjwHB3DEfC4/YJTczv4tg== X-Google-Smtp-Source: APBJJlGfZoIKy5dlf67l9aDnuNmoWN294jSLFWBRn8Nrl68gwCTSSg7v4NaF4AAHW/6J0zEJitKJCg== X-Received: by 2002:a17:90a:1f83:b0:268:3dc6:f0c5 with SMTP id x3-20020a17090a1f8300b002683dc6f0c5mr25038018pja.0.1691406981820; Mon, 07 Aug 2023 04:16:21 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 30/48] vmw_balloon: dynamically allocate the vmw-balloon shrinker Date: Mon, 7 Aug 2023 19:09:18 +0800 Message-Id: <20230807110936.21819-31-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the vmw-balloon shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct vmballoon. And we can simply exit vmballoon_init() when registering the shrinker fails. So the shrinker_registered indication is redundant, just remove it. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/misc/vmw_balloon.c | 38 ++++++++++++-------------------------- 1 file changed, 12 insertions(+), 26 deletions(-) diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c index 9ce9b9e0e9b6..ac2cdb6cdf74 100644 --- a/drivers/misc/vmw_balloon.c +++ b/drivers/misc/vmw_balloon.c @@ -380,16 +380,7 @@ struct vmballoon { /** * @shrinker: shrinker interface that is used to avoid over-inflation. */ - struct shrinker shrinker; - - /** - * @shrinker_registered: whether the shrinker was registered. - * - * The shrinker interface does not handle gracefully the removal of - * shrinker that was not registered before. This indication allows to - * simplify the unregistration process. - */ - bool shrinker_registered; + struct shrinker *shrinker; }; static struct vmballoon balloon; @@ -1568,29 +1559,27 @@ static unsigned long vmballoon_shrinker_count(struct shrinker *shrinker, static void vmballoon_unregister_shrinker(struct vmballoon *b) { - if (b->shrinker_registered) - unregister_shrinker(&b->shrinker); - b->shrinker_registered = false; + shrinker_free(b->shrinker); } static int vmballoon_register_shrinker(struct vmballoon *b) { - int r; - /* Do nothing if the shrinker is not enabled */ if (!vmwballoon_shrinker_enable) return 0; - b->shrinker.scan_objects = vmballoon_shrinker_scan; - b->shrinker.count_objects = vmballoon_shrinker_count; - b->shrinker.seeks = DEFAULT_SEEKS; + b->shrinker = shrinker_alloc(0, "vmw-balloon"); + if (!b->shrinker) + return -ENOMEM; - r = register_shrinker(&b->shrinker, "vmw-balloon"); + b->shrinker->scan_objects = vmballoon_shrinker_scan; + b->shrinker->count_objects = vmballoon_shrinker_count; + b->shrinker->seeks = DEFAULT_SEEKS; + b->shrinker->private_data = b; - if (r == 0) - b->shrinker_registered = true; + shrinker_register(b->shrinker); - return r; + return 0; } /* @@ -1883,7 +1872,7 @@ static int __init vmballoon_init(void) error = vmballoon_register_shrinker(&balloon); if (error) - goto fail; + return error; /* * Initialization of compaction must be done after the call to @@ -1905,9 +1894,6 @@ static int __init vmballoon_init(void) vmballoon_debugfs_init(&balloon); return 0; -fail: - vmballoon_unregister_shrinker(&balloon); - return error; } /* -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578094.905445 (Exim 4.92) (envelope-from ) id 1qSyEz-0005hk-A4; Mon, 07 Aug 2023 11:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578094.905445; Mon, 07 Aug 2023 11:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEy-0005fZ-Lc; Mon, 07 Aug 2023 11:17:36 +0000 Received: by outflank-mailman (input) for mailman id 578094; Mon, 07 Aug 2023 11:17:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy9q-0002Ee-4k for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:12:18 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44c6a4fd-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:12:17 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 9C0FD4EE0737; Mon, 7 Aug 2023 13:12:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44c6a4fd-3513-11ee-b27d-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 13:12:16 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <871a501fb76cff724ed1c2b09277e2a3@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >> Besides the one you listed, there are these other occurrences: >> - xen/arch/x86/mm.c:4678 in 'arch_memory_op' as local variable 'struct >> e820entry' > > This probably wants renaming; my suggestion would be just "e" here. Ok > >> - xen/arch/x86/include/asm/guest/hypervisor.h:55 in >> 'hypervisor_e820_fixup' >> - xen/arch/x86/include/asm/pv/shim.h:88 in 'pv_shim_fixup' > > These can likely again have their parameters dropped, for it only > ever being the "e820" global which is passed. (Really I think in such > cases the names being the same should be permitted.) > >> - xen/arch/x86/setup.c:689 in 'kexec_reserve_area' > > This surely can quite sensibly have boot_e820 use moved into the > function itself. > Ok, although your suggestion of breaking these renames/deletions in more than one patch may not be applicable, as 'kexec_reserve_area' calls 'reserve_e820_ram', which in turn calls 'e820_change_range_type'. Similarly, the call stack containing 'e820_add_range' includes other calls to the modified functions, so effectively it's best to drop the parameter everywhere all at once to prevent accidental mistakes. >> We can take the first approach you suggested (which was my original >> attempt, but then upon feedback on other >> patches I reworked this patch before submitting). My doubt about it >> was >> that it would introduce a naming >> inconsistency with other e820-related objects/types. Anyway, if >> e820_map >> is not a good name, could e820_arr be it? > > But how does "arr" describe the purpose? I would have suggested a name, > but none I can think of (e820_real, e820_final) I'd be really happy > with. > Just e820 is pretty likely the best name we can have here. > Ok, so perhaps the best way is using the strategy above, although I'm curious why in other places this was not the preferred alternative (as the global may be dropped or the callers may use a e820map other than the global one, but here I recognize my lack of knowledge on the internals of Xen). -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578097.905450 (Exim 4.92) (envelope-from ) id 1qSyF0-0005tc-22; Mon, 07 Aug 2023 11:17:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578097.905450; Mon, 07 Aug 2023 11:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEz-0005qJ-DL; Mon, 07 Aug 2023 11:17:37 +0000 Received: by outflank-mailman (input) for mailman id 578097; Mon, 07 Aug 2023 11:17:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy93-00018O-Kb for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:11:29 +0000 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [2607:f8b0:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 269c7b10-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:11:27 +0200 (CEST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5643140aa5fso525175a12.0 for ; Mon, 07 Aug 2023 04:11:27 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:11:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 269c7b10-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406686; x=1692011486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ppdDbzxLfV7T8uyJ0+LWzuRMVQS50F9BO9dGotbDPbU=; b=MlLUTFwBYj7txqomyX5RsQbZ0tuOTesyUPZa0imDy/CbzwI18VWLrI273BHEpiy/59 rQ1jtyDjjrm0A2fn5g0PDon6y1ODu6aNGJCylYpk7eBz5aCl8EYDqiryatgBLfE6j6wl z5DQPgedGrLwi+nxG0CDlruIcPgTiyaIMd4jUriznEP5tOm9lhp6XNenm09AU0AYyYPz hP8xB6m5xmZ4JEVQ0Bc2ouPU+2lWMJulVYbharTYlD2LjNPOhOgz1BVr9kOg3WfUC2R8 kqamQX4BkmNd+ktmJD6D1JNyz78v+ezzbXueyJ3khYdsrERbOdoO7diXy9Rr3O+Hss94 NCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406686; x=1692011486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ppdDbzxLfV7T8uyJ0+LWzuRMVQS50F9BO9dGotbDPbU=; b=SI6bTKXSY/NOnScqSQgI8k+zsVbPSbPRXtMJgd+Y+TyJhJDEJ6WIg7P3RVirgWj+Ia Lpe3Sux/EZT54k7JV7sSy1/97xQcpJpCRiKoTVAIis7+/DGkhU+IgPnmqktwsglFTOSB Kdj1ttXlxJucfYfzS2HDF2apiYgm3lFDYBEr6hiHcMJ+Uqt2h98/ZVOxfJQiys4H84M7 ScNAgB5ON3luFkYeb6f61rIkhHgtnPkPBdrpyXKsL8TZzG+8yXDI8FEmXqZLY5bdOsMT 4AYGhmONNJ0kKfsLU1fqvGzVz9Z5uvgnvxuGhOpG8WowZN8BpqmHqgO8nABxgIuLSWsQ o73A== X-Gm-Message-State: AOJu0YwKI3m4/kZPmtA6wQsB4Hvt4b9xsmg4cbl8RBGjakNSinIhxpAj Vmp0KgIHsDwgFSm7rcIro1WOUQ== X-Google-Smtp-Source: AGHT+IF4N48rqO+yuBXOFXn//EzxG9zSjzgF29ivUv9kLYfrFhE3z4laIyd5mkV4h78zNK2JaBG8Rw== X-Received: by 2002:a17:90a:9c3:b0:269:41cf:7212 with SMTP id 61-20020a17090a09c300b0026941cf7212mr4956295pjo.4.1691406685878; Mon, 07 Aug 2023 04:11:25 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 07/48] drm/ttm: dynamically allocate the drm-ttm_pool shrinker Date: Mon, 7 Aug 2023 19:08:55 +0800 Message-Id: <20230807110936.21819-8-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the drm-ttm_pool shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/gpu/drm/ttm/ttm_pool.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index cddb9151d20f..c9c9618c0dce 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -73,7 +73,7 @@ static struct ttm_pool_type global_dma32_uncached[MAX_ORDER + 1]; static spinlock_t shrinker_lock; static struct list_head shrinker_list; -static struct shrinker mm_shrinker; +static struct shrinker *mm_shrinker; /* Allocate pages of size 1 << order with the given gfp_flags */ static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags, @@ -734,8 +734,8 @@ static int ttm_pool_debugfs_shrink_show(struct seq_file *m, void *data) struct shrink_control sc = { .gfp_mask = GFP_NOFS }; fs_reclaim_acquire(GFP_KERNEL); - seq_printf(m, "%lu/%lu\n", ttm_pool_shrinker_count(&mm_shrinker, &sc), - ttm_pool_shrinker_scan(&mm_shrinker, &sc)); + seq_printf(m, "%lu/%lu\n", ttm_pool_shrinker_count(mm_shrinker, &sc), + ttm_pool_shrinker_scan(mm_shrinker, &sc)); fs_reclaim_release(GFP_KERNEL); return 0; @@ -779,10 +779,17 @@ int ttm_pool_mgr_init(unsigned long num_pages) &ttm_pool_debugfs_shrink_fops); #endif - mm_shrinker.count_objects = ttm_pool_shrinker_count; - mm_shrinker.scan_objects = ttm_pool_shrinker_scan; - mm_shrinker.seeks = 1; - return register_shrinker(&mm_shrinker, "drm-ttm_pool"); + mm_shrinker = shrinker_alloc(0, "drm-ttm_pool"); + if (!mm_shrinker) + return -ENOMEM; + + mm_shrinker->count_objects = ttm_pool_shrinker_count; + mm_shrinker->scan_objects = ttm_pool_shrinker_scan; + mm_shrinker->seeks = 1; + + shrinker_register(mm_shrinker); + + return 0; } /** @@ -802,6 +809,6 @@ void ttm_pool_mgr_fini(void) ttm_pool_type_fini(&global_dma32_uncached[i]); } - unregister_shrinker(&mm_shrinker); + shrinker_free(mm_shrinker); WARN_ON(!list_empty(&shrinker_list)); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578100.905458 (Exim 4.92) (envelope-from ) id 1qSyF1-0006Q7-ON; Mon, 07 Aug 2023 11:17:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578100.905458; Mon, 07 Aug 2023 11:17:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyF1-0006M5-Bg; Mon, 07 Aug 2023 11:17:39 +0000 Received: by outflank-mailman (input) for mailman id 578100; Mon, 07 Aug 2023 11:17:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEP-0006s9-Rb for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:17:01 +0000 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [2607:f8b0:4864:20::1033]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edc6e71d-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:17:01 +0200 (CEST) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-268f6ba57b5so625221a91.1 for ; Mon, 07 Aug 2023 04:17:01 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:16:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edc6e71d-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407020; x=1692011820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EIUP2Z+Njo4a1BEj4icZmHsMWaHOvZz2gypuwwXx0Do=; b=l3d3GmRdHVbykswjvj36xLNJU/HkRN0qQPtaCG+8C7U8JyCsrS7Omd1smNfjTVHq8n mmfknLuVWKPue6MQRQdYpG2Cap7GHxCVjCjmXm7SqhyxnTlXTIqiD6Dq4SurElV0d5A7 yjtafWW6aQouIDt5nRUMTSVpj6O1jVRczCF6pjoLUl7iIEpS61wXJNKr8xLD++xEk/hK PFaJuConQXPH9DxAW8LM6Qo0CoTe6tjYe9zN1tPP9wJtycShcCxIvBgENM+8mu3gxPqB pNPWVQXnsLY4dcbOjU72J1n4zmuXrZ5CIb4eDvQ0qGFRUeSI2BGNFxZSx5CdqcSToBir CZSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407020; x=1692011820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EIUP2Z+Njo4a1BEj4icZmHsMWaHOvZz2gypuwwXx0Do=; b=KrSHxsdXAYOtqOrxrk+i4YzFNBuFcX15GLbUkuK2METtXquKEnboPOL3Tith3/8M5+ DB3KdVE+6bq2LE+OeeWffQrQcg0sSSI+ehCXmjH1w+Zhgxq2zXsrZXq+ASK4tIF5SXiR H0D3Qkz9TXQAu0CtDB8U9OOWGRMOF5cZ3g/JOFeJw3fK1xEjCLUQgljUXeluVFscIxsJ EkWe+9BVszZkc3N6VQhPmNWHOqBkq+aAe4DDgBBiRSjfPXPpDlJFllzdB9CP3WenvrK9 Da8IS+JyG0iJgPgvzfACrNcbnedy06iFnPaMVdjR9VMjouyEzwzLTAmqb/8nY0zaiS/y FxTg== X-Gm-Message-State: AOJu0Yzkn3DMMkFMzgpXSR3Wn9IK5MqxugYd73WRLIH/PskwrTbJwNXD lVa5Xd8w96zeV495mWBnM2HzyQ== X-Google-Smtp-Source: AGHT+IGL/1gBIk2C+QwkMNr6hEGRZG4q+xpVeUoXNA4D2kibZqrKnrVjY0bqX283iYX9eWQrJAN/xA== X-Received: by 2002:a17:90a:6701:b0:269:32c7:24dc with SMTP id n1-20020a17090a670100b0026932c724dcmr6036278pjj.0.1691407020016; Mon, 07 Aug 2023 04:17:00 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 33/48] ext4: dynamically allocate the ext4-es shrinker Date: Mon, 7 Aug 2023 19:09:21 +0800 Message-Id: <20230807110936.21819-34-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the ext4-es shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct ext4_sb_info. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/ext4/ext4.h | 2 +- fs/ext4/extents_status.c | 24 ++++++++++++++---------- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 481491e892df..48baf03eb1a6 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -1657,7 +1657,7 @@ struct ext4_sb_info { __u32 s_csum_seed; /* Reclaim extents from extent status tree */ - struct shrinker s_es_shrinker; + struct shrinker *s_es_shrinker; struct list_head s_es_list; /* List of inodes with reclaimable extents */ long s_es_nr_inode; struct ext4_es_stats s_es_stats; diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c index 9b5b8951afb4..0532a81a7669 100644 --- a/fs/ext4/extents_status.c +++ b/fs/ext4/extents_status.c @@ -1596,7 +1596,7 @@ static unsigned long ext4_es_count(struct shrinker *shrink, unsigned long nr; struct ext4_sb_info *sbi; - sbi = container_of(shrink, struct ext4_sb_info, s_es_shrinker); + sbi = shrink->private_data; nr = percpu_counter_read_positive(&sbi->s_es_stats.es_stats_shk_cnt); trace_ext4_es_shrink_count(sbi->s_sb, sc->nr_to_scan, nr); return nr; @@ -1605,8 +1605,7 @@ static unsigned long ext4_es_count(struct shrinker *shrink, static unsigned long ext4_es_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct ext4_sb_info *sbi = container_of(shrink, - struct ext4_sb_info, s_es_shrinker); + struct ext4_sb_info *sbi = shrink->private_data; int nr_to_scan = sc->nr_to_scan; int ret, nr_shrunk; @@ -1690,13 +1689,18 @@ int ext4_es_register_shrinker(struct ext4_sb_info *sbi) if (err) goto err3; - sbi->s_es_shrinker.scan_objects = ext4_es_scan; - sbi->s_es_shrinker.count_objects = ext4_es_count; - sbi->s_es_shrinker.seeks = DEFAULT_SEEKS; - err = register_shrinker(&sbi->s_es_shrinker, "ext4-es:%s", - sbi->s_sb->s_id); - if (err) + sbi->s_es_shrinker = shrinker_alloc(0, "ext4-es:%s", sbi->s_sb->s_id); + if (!sbi->s_es_shrinker) { + err = -ENOMEM; goto err4; + } + + sbi->s_es_shrinker->scan_objects = ext4_es_scan; + sbi->s_es_shrinker->count_objects = ext4_es_count; + sbi->s_es_shrinker->seeks = DEFAULT_SEEKS; + sbi->s_es_shrinker->private_data = sbi; + + shrinker_register(sbi->s_es_shrinker); return 0; err4: @@ -1716,7 +1720,7 @@ void ext4_es_unregister_shrinker(struct ext4_sb_info *sbi) percpu_counter_destroy(&sbi->s_es_stats.es_stats_cache_misses); percpu_counter_destroy(&sbi->s_es_stats.es_stats_all_cnt); percpu_counter_destroy(&sbi->s_es_stats.es_stats_shk_cnt); - unregister_shrinker(&sbi->s_es_shrinker); + shrinker_free(sbi->s_es_shrinker); } /* -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578109.905475 (Exim 4.92) (envelope-from ) id 1qSyF4-0007A8-3y; Mon, 07 Aug 2023 11:17:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578109.905475; Mon, 07 Aug 2023 11:17:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyF3-000763-QN; Mon, 07 Aug 2023 11:17:41 +0000 Received: by outflank-mailman (input) for mailman id 578109; Mon, 07 Aug 2023 11:17:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyE0-0006s9-O5 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:16:36 +0000 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [2607:f8b0:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id deb4e289-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:16:36 +0200 (CEST) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-55b78bf0423so392203a12.0 for ; Mon, 07 Aug 2023 04:16:36 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:16:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: deb4e289-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406994; x=1692011794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nhs5C6wYTK112tB0Y3rKeCsMBEmGx3fQoCnqZ3HCCLA=; b=VutXoqIYPXtXpdtpLBT8bT2urW1s48myud5I+McDwEBCa9rsQtPimBr+YUFUzsT97Y MjfZoj9VTU5fQdJYfMy4Yv9+fpoIS3NFbuatZ84CQCYl8H9eWSOHmEJiwCeaGu2opion jdT+b5LnvY412zroG7MGUq7fLqOt080kwGO2vU4AXzRlkef5xzEfjXjzk3KbTMiuBQm9 X5miROMvoH95e1ANj7PpglZT3M6nqFHwr/l7jXhn2TxbPNm1IYfgnlH3CAsHhpdGLp2V N9EQiXy6+755vxTQtpjB+rXzevwen4FSNuxTXEorqPqLUTQJulIk6PKsXEt+umpl0/zu QYGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406994; x=1692011794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nhs5C6wYTK112tB0Y3rKeCsMBEmGx3fQoCnqZ3HCCLA=; b=Im9PaWfpSdoqbNePxzzUI0Rww9X8kyUFvZPxnsPGmyi0JRJ82SlWFaHJ4VWxkHf5Nw K3FFcakNN1SkVP9vdbj7mazFBYIQTSkrqHaCWOA391eYQmS26h3bhB+qRomkc5uRlWey WA3xjpa7OBfMbiEsYyafquhHYOl8YjP0KkiWkN0cqdNyF4aJSmGTEbKcUVqr68NA9rJh pQDZf9bsruIpF7praq/5ozMLe1KEIcx0Q3XoFVXxc2SuUplbeuQ7DPjMzo06vdOYtgrN YRn8rNdJgKZCiu1SeaUfpvFjV/Rg/sbAiIwbz/B1fSgmxmyEfHunFf9zTjY6Iekoshod tj4A== X-Gm-Message-State: AOJu0YwarmQNnqUaBkB0av0WECvmQZMGf/sns0jN2XEGtNsG61OST8/x eYFMIELf5sGOFv7YReKlMtjQKQ== X-Google-Smtp-Source: AGHT+IF623rMYCfdnVm3rDQUM9QMv5wRA4teIiBc32f8XUPEVkH5VguN8eCSFu0xAaU5upe3gsVL9w== X-Received: by 2002:a17:90a:6701:b0:269:32c7:24dc with SMTP id n1-20020a17090a670100b0026932c724dcmr6035493pjj.0.1691406994765; Mon, 07 Aug 2023 04:16:34 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 31/48] virtio_balloon: dynamically allocate the virtio-balloon shrinker Date: Mon, 7 Aug 2023 19:09:19 +0800 Message-Id: <20230807110936.21819-32-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the virtio-balloon shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct virtio_balloon. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/virtio/virtio_balloon.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 5b15936a5214..82e6087073a9 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -111,7 +111,7 @@ struct virtio_balloon { struct virtio_balloon_stat stats[VIRTIO_BALLOON_S_NR]; /* Shrinker to return free pages - VIRTIO_BALLOON_F_FREE_PAGE_HINT */ - struct shrinker shrinker; + struct shrinker *shrinker; /* OOM notifier to deflate on OOM - VIRTIO_BALLOON_F_DEFLATE_ON_OOM */ struct notifier_block oom_nb; @@ -816,8 +816,7 @@ static unsigned long shrink_free_pages(struct virtio_balloon *vb, static unsigned long virtio_balloon_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) { - struct virtio_balloon *vb = container_of(shrinker, - struct virtio_balloon, shrinker); + struct virtio_balloon *vb = shrinker->private_data; return shrink_free_pages(vb, sc->nr_to_scan); } @@ -825,8 +824,7 @@ static unsigned long virtio_balloon_shrinker_scan(struct shrinker *shrinker, static unsigned long virtio_balloon_shrinker_count(struct shrinker *shrinker, struct shrink_control *sc) { - struct virtio_balloon *vb = container_of(shrinker, - struct virtio_balloon, shrinker); + struct virtio_balloon *vb = shrinker->private_data; return vb->num_free_page_blocks * VIRTIO_BALLOON_HINT_BLOCK_PAGES; } @@ -847,16 +845,23 @@ static int virtio_balloon_oom_notify(struct notifier_block *nb, static void virtio_balloon_unregister_shrinker(struct virtio_balloon *vb) { - unregister_shrinker(&vb->shrinker); + shrinker_free(vb->shrinker); } static int virtio_balloon_register_shrinker(struct virtio_balloon *vb) { - vb->shrinker.scan_objects = virtio_balloon_shrinker_scan; - vb->shrinker.count_objects = virtio_balloon_shrinker_count; - vb->shrinker.seeks = DEFAULT_SEEKS; + vb->shrinker = shrinker_alloc(0, "virtio-balloon"); + if (!vb->shrinker) + return -ENOMEM; - return register_shrinker(&vb->shrinker, "virtio-balloon"); + vb->shrinker->scan_objects = virtio_balloon_shrinker_scan; + vb->shrinker->count_objects = virtio_balloon_shrinker_count; + vb->shrinker->seeks = DEFAULT_SEEKS; + vb->shrinker->private_data = vb; + + shrinker_register(vb->shrinker); + + return 0; } static int virtballoon_probe(struct virtio_device *vdev) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578110.905484 (Exim 4.92) (envelope-from ) id 1qSyF5-0007el-OT; Mon, 07 Aug 2023 11:17:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578110.905484; Mon, 07 Aug 2023 11:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyF5-0007bV-Ba; Mon, 07 Aug 2023 11:17:43 +0000 Received: by outflank-mailman (input) for mailman id 578110; Mon, 07 Aug 2023 11:17:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy9f-00018O-Oq for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:12:07 +0000 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [2607:f8b0:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3dcef371-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:12:06 +0200 (CEST) Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-51f64817809so360179a12.1 for ; Mon, 07 Aug 2023 04:12:06 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:12:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dcef371-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406725; x=1692011525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2qNGhCyBYRkIC+KqhUj1bienmPbnCoyI88yux10rL0c=; b=Xc/b9RVeZGabBZRzbFnLG60A3XcuysnQbX8QDB63xQh9Qsy33GgzK9r54ssZ8BRYsv Zo1icyrpegHwV8KMFlNuxd6Vv7rJh2g9STB5A/Cyu6q4WM+YLxsvvmbNVVdkSntCluNl It/PLVMY+sHjh9niVg4dAEeIOr6EcMWhtMnuFdCY7H6/MC8Iz/ZfTZnLr8OJnSIA36e9 mmNGX7xKmI8VWlsJYDncO9Zq/rF2h1OiOCACwI0xXgbsWIREHFfM5CkS8NCDLLHpFGlK JETB4OwnLh2lGmaSIFNM9gd2qMpLx0zP9hut1e08UtN8MQU5ZK62c3ni+xnuk2sIAfG7 kkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406725; x=1692011525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qNGhCyBYRkIC+KqhUj1bienmPbnCoyI88yux10rL0c=; b=YMo1eJ9SMEzIJ7BEkyzArMn+vUvbwXj+M6tZ3e7k90fETgiIyQSie7e97e1dRWre2L fXzR7qRV8V/dvyByC7ob06405Rs+CoexN4aIz+8CSoeOrGZtmUPoI9pYznkMuiOLBlN/ h3u/HeLMw7/mrp0+qTlgxQYpy1U/EcFT/ayZuK0M7lJXC+i7QOYwsFUe7vBjzbLEY2IH SQDJW6kFlABKVyf4ujEaiEjt5OX/UujBkfLvmPVpAfb9Y3Le6Wnr8XGGiGWP0AKY45IA x58vgKZ5ibjEbfQDjVI8x/uwu8XOQ4UaIS301droPpNM1veoXnf7bbDqU+Ey+MNCNGYc hAsw== X-Gm-Message-State: AOJu0YzLpa9ndPtzosCTZVQEkDaYhlUVcTMae3axIqjObLDmkHwHlcGn MtNvR6/J/7jhJ8U2IQky91OIew== X-Google-Smtp-Source: AGHT+IH0i+Trkswf5ZN/Zo/hyk0nSAkeHBCb5cnTJePkF3I+vCqNyDS8fjeM0LPIBtSn2h3E1rmPDQ== X-Received: by 2002:a17:90a:2909:b0:269:5bf7:d79c with SMTP id g9-20020a17090a290900b002695bf7d79cmr2210453pjd.1.1691406724771; Mon, 07 Aug 2023 04:12:04 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 10/48] f2fs: dynamically allocate the f2fs-shrinker Date: Mon, 7 Aug 2023 19:08:58 +0800 Message-Id: <20230807110936.21819-11-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the f2fs-shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/f2fs/super.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index aa1f9a3a8037..9092310582aa 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -83,11 +83,27 @@ void f2fs_build_fault_attr(struct f2fs_sb_info *sbi, unsigned int rate, #endif /* f2fs-wide shrinker description */ -static struct shrinker f2fs_shrinker_info = { - .scan_objects = f2fs_shrink_scan, - .count_objects = f2fs_shrink_count, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *f2fs_shrinker_info; + +static int __init f2fs_init_shrinker(void) +{ + f2fs_shrinker_info = shrinker_alloc(0, "f2fs-shrinker"); + if (!f2fs_shrinker_info) + return -ENOMEM; + + f2fs_shrinker_info->count_objects = f2fs_shrink_count; + f2fs_shrinker_info->scan_objects = f2fs_shrink_scan; + f2fs_shrinker_info->seeks = DEFAULT_SEEKS; + + shrinker_register(f2fs_shrinker_info); + + return 0; +} + +static void f2fs_exit_shrinker(void) +{ + shrinker_free(f2fs_shrinker_info); +} enum { Opt_gc_background, @@ -4940,7 +4956,7 @@ static int __init init_f2fs_fs(void) err = f2fs_init_sysfs(); if (err) goto free_garbage_collection_cache; - err = register_shrinker(&f2fs_shrinker_info, "f2fs-shrinker"); + err = f2fs_init_shrinker(); if (err) goto free_sysfs; err = register_filesystem(&f2fs_fs_type); @@ -4985,7 +5001,7 @@ static int __init init_f2fs_fs(void) f2fs_destroy_root_stats(); unregister_filesystem(&f2fs_fs_type); free_shrinker: - unregister_shrinker(&f2fs_shrinker_info); + f2fs_exit_shrinker(); free_sysfs: f2fs_exit_sysfs(); free_garbage_collection_cache: @@ -5017,7 +5033,7 @@ static void __exit exit_f2fs_fs(void) f2fs_destroy_post_read_processing(); f2fs_destroy_root_stats(); unregister_filesystem(&f2fs_fs_type); - unregister_shrinker(&f2fs_shrinker_info); + f2fs_exit_shrinker(); f2fs_exit_sysfs(); f2fs_destroy_garbage_collection_cache(); f2fs_destroy_extent_cache(); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578116.905498 (Exim 4.92) (envelope-from ) id 1qSyF9-00006D-Bd; Mon, 07 Aug 2023 11:17:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578116.905498; Mon, 07 Aug 2023 11:17:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyF9-0008W6-17; Mon, 07 Aug 2023 11:17:47 +0000 Received: by outflank-mailman (input) for mailman id 578116; Mon, 07 Aug 2023 11:17:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy9T-00018O-8u for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:11:55 +0000 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [2607:f8b0:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3658959a-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:11:53 +0200 (CEST) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1bba9539a23so9296655ad.1 for ; Mon, 07 Aug 2023 04:11:53 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:11:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3658959a-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406712; x=1692011512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubpyp4SIhGXjO6/VTKiZvWjlRzyN8ANvKHVN5xSGnIw=; b=G6tJn+16QVti2qtu2hqYljseIE/XGpe1Yhsul4LFU6R/aCDAM7lceOlES83Z0B/Pue 2irlih/PCzGRhADqlmxdT4ZmTPg/rDw2XT4QeZKx/Tui9xhVWAtyJogqiocaYi2mPJVJ JfsH0RSoKbpVavaYBWWtyo/mJh8W+H0WFTE4SVefHn6UoqHLIS8l90Z//i2iVib88cLh SO8x9HJ9eijOF2Obr6A8OaZNG3N0xetNtsejNB5r0CVLeObeV8ZzJa8r4m2G8/H610tO JRFiieD8eIQL4G+uzuFBv5AMDY6TbkMqFwB+fegzuV4xQGReerwz1d1NP8JNZHZ17Zsd g+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406712; x=1692011512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubpyp4SIhGXjO6/VTKiZvWjlRzyN8ANvKHVN5xSGnIw=; b=ADOMiGOztu18Bes1lAIdYFV2nDWoRzI2F6b+ugOzUrvjuV4OtyVI+KN/qiVYZZLKEq d6l9aXCYqbCBDMs+COSw3gs/TW5I0SGdmkq01kY2iDZf6hTU7KObzldcbQZJaD17r9sG 8zmcjJ4LszgAGHc5coDdIPe7I8i943xtKCCzSPJcGzVfb++JsBgSF1TcZmUshxw3fqJe 0GvMj5OZ8bfiawP/G6UBrQeDTaXiq8rHY3CR7Aly5UNnKWvevywJWLdiVGDQMGn2QMXC k0H8kj2h8bOGzKR/uuYWWf6lso9QA9RVGmHHIPMeTz5sfVaVt6t1SriU+2QnJXG3ZHt8 aEcg== X-Gm-Message-State: ABy/qLapRxa4AfqvHitebMftOEwpOAdulAmdymM44ukMxV39Wz/9FOBZ UnG9OiptPj/NWCjtLR5jvnldRA== X-Google-Smtp-Source: APBJJlGAdl0ewhYUg6UhJdRJKXIwq0U3XoR/AJshcbF16xE0A4mgQC4Umc8PgwnpC/Hq6tl8ikCZEw== X-Received: by 2002:a17:902:ea04:b0:1b8:17e8:547e with SMTP id s4-20020a170902ea0400b001b817e8547emr32460173plg.1.1691406712196; Mon, 07 Aug 2023 04:11:52 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 09/48] erofs: dynamically allocate the erofs-shrinker Date: Mon, 7 Aug 2023 19:08:57 +0800 Message-Id: <20230807110936.21819-10-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the erofs-shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/erofs/utils.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/fs/erofs/utils.c b/fs/erofs/utils.c index cc6fb9e98899..6e1a828e6ca3 100644 --- a/fs/erofs/utils.c +++ b/fs/erofs/utils.c @@ -270,19 +270,25 @@ static unsigned long erofs_shrink_scan(struct shrinker *shrink, return freed; } -static struct shrinker erofs_shrinker_info = { - .scan_objects = erofs_shrink_scan, - .count_objects = erofs_shrink_count, - .seeks = DEFAULT_SEEKS, -}; +static struct shrinker *erofs_shrinker_info; int __init erofs_init_shrinker(void) { - return register_shrinker(&erofs_shrinker_info, "erofs-shrinker"); + erofs_shrinker_info = shrinker_alloc(0, "erofs-shrinker"); + if (!erofs_shrinker_info) + return -ENOMEM; + + erofs_shrinker_info->count_objects = erofs_shrink_count; + erofs_shrinker_info->scan_objects = erofs_shrink_scan; + erofs_shrinker_info->seeks = DEFAULT_SEEKS; + + shrinker_register(erofs_shrinker_info); + + return 0; } void erofs_exit_shrinker(void) { - unregister_shrinker(&erofs_shrinker_info); + shrinker_free(erofs_shrinker_info); } #endif /* !CONFIG_EROFS_FS_ZIP */ -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578118.905504 (Exim 4.92) (envelope-from ) id 1qSyFA-0000FU-A1; Mon, 07 Aug 2023 11:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578118.905504; Mon, 07 Aug 2023 11:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyF9-0000CR-RB; Mon, 07 Aug 2023 11:17:47 +0000 Received: by outflank-mailman (input) for mailman id 578118; Mon, 07 Aug 2023 11:17:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyAj-0002Ee-4h for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:13:13 +0000 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [2607:f8b0:4864:20::52a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6567a3f8-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:13:12 +0200 (CEST) Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-51f64817809so360317a12.1 for ; Mon, 07 Aug 2023 04:13:12 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:13:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6567a3f8-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406791; x=1692011591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=urGrhHBCGKwKuhIkQmOHRuysXuy1mToQA+AaHWoY6PY=; b=gvEcin7S0wJ5rW0wtj9WnWp/4gO3FOqyEc5Qy3KVjjCOMIdl063r7goatTKMU5K63u IABDDkTZbyMiPq/rwoG72XrgfLWlV6/YJwymkZtRfBVcrDOzJOk+V88T6EEEXGW6nfh0 le0xVwnZY7As0nXjZy+hSjIWRCXvYGRHiEKZrDZnQb7QflVpjM7uq/81aSxj3traKDGt VXa/baYLLxxBhWBawSSBHT4dMsZ/NRoyUnn0XTD8JWz4/O0ULe9Suh4wohOUxiotc5cA +kJEwQbIJfS1Vrk1T3/Loi8TKjO+pow/TrGBcBE2xp4OSLxBFU0bCUPycoGAdA8SsoOk yeOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406791; x=1692011591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=urGrhHBCGKwKuhIkQmOHRuysXuy1mToQA+AaHWoY6PY=; b=RXUFXd7NwT2/evqnMyQEMgGHNkZjUnvwOFbWFEJn1owNtp/RxAQXXWAY5WOebYQ2oW 3yDFydkYV4+f0I2irfQ7dfGYWWd/mx3cfMyYEtkkNztYpVqfDW9TR1KG/O0OVN/eRCqf Lhm8jCwsdNPjjdbKPLKq0GgFyRGYkZX/0be+q2HlQdOizcGZ44yQpz08pjdzhYfU+9J0 GpziJoxSjr42YYLSt3Z1lGa/HmZIp7ZcNtEyMrPybfzWNmIxiFH7984o6L/4bHtbn22x L2yLkqIUc28xLoPN3M6tTmCA6Dm/ilP5z2Q5C01sflULTR2MJqEZV1Beg/w47+yPJPiG PkKg== X-Gm-Message-State: ABy/qLYlWKW8uG9ND+nWs6W8szU9K7ZfqWbZwPHOyL3/s8kd6WK1+rhR Ho4ElCBZPGlbQ6GUA6/tgHpi5g== X-Google-Smtp-Source: APBJJlGG9fl/KZM7Wu/aB3nA3qPBXzAgCls0ii/X4UboFM2rQSd7zbDq190u8vBbdPOZ8QFUsdy1lw== X-Received: by 2002:a17:90a:faf:b0:268:abc:83d5 with SMTP id 44-20020a17090a0faf00b002680abc83d5mr23478200pjz.4.1691406791204; Mon, 07 Aug 2023 04:13:11 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 15/48] nfsd: dynamically allocate the nfsd-filecache shrinker Date: Mon, 7 Aug 2023 19:09:03 +0800 Message-Id: <20230807110936.21819-16-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the nfsd-filecache shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/nfsd/filecache.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index ee9c923192e0..9c62b4502539 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -521,11 +521,7 @@ nfsd_file_lru_scan(struct shrinker *s, struct shrink_control *sc) return ret; } -static struct shrinker nfsd_file_shrinker = { - .scan_objects = nfsd_file_lru_scan, - .count_objects = nfsd_file_lru_count, - .seeks = 1, -}; +static struct shrinker *nfsd_file_shrinker; /** * nfsd_file_cond_queue - conditionally unhash and queue a nfsd_file @@ -746,12 +742,19 @@ nfsd_file_cache_init(void) goto out_err; } - ret = register_shrinker(&nfsd_file_shrinker, "nfsd-filecache"); - if (ret) { - pr_err("nfsd: failed to register nfsd_file_shrinker: %d\n", ret); + nfsd_file_shrinker = shrinker_alloc(0, "nfsd-filecache"); + if (!nfsd_file_shrinker) { + ret = -ENOMEM; + pr_err("nfsd: failed to allocate nfsd_file_shrinker\n"); goto out_lru; } + nfsd_file_shrinker->count_objects = nfsd_file_lru_count; + nfsd_file_shrinker->scan_objects = nfsd_file_lru_scan; + nfsd_file_shrinker->seeks = 1; + + shrinker_register(nfsd_file_shrinker); + ret = lease_register_notifier(&nfsd_file_lease_notifier); if (ret) { pr_err("nfsd: unable to register lease notifier: %d\n", ret); @@ -774,7 +777,7 @@ nfsd_file_cache_init(void) out_notifier: lease_unregister_notifier(&nfsd_file_lease_notifier); out_shrinker: - unregister_shrinker(&nfsd_file_shrinker); + shrinker_free(nfsd_file_shrinker); out_lru: list_lru_destroy(&nfsd_file_lru); out_err: @@ -891,7 +894,7 @@ nfsd_file_cache_shutdown(void) return; lease_unregister_notifier(&nfsd_file_lease_notifier); - unregister_shrinker(&nfsd_file_shrinker); + shrinker_free(nfsd_file_shrinker); /* * make sure all callers of nfsd_file_lru_cb are done before * calling nfsd_file_cache_purge -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578120.905511 (Exim 4.92) (envelope-from ) id 1qSyFB-0000Sm-EJ; Mon, 07 Aug 2023 11:17:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578120.905511; Mon, 07 Aug 2023 11:17:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFA-0000P0-Ns; Mon, 07 Aug 2023 11:17:48 +0000 Received: by outflank-mailman (input) for mailman id 578120; Mon, 07 Aug 2023 11:17:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyA6-00018O-Lt for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:12:34 +0000 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [2607:f8b0:4864:20::1034]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dcd8f9b-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:12:33 +0200 (CEST) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-268663fb09cso630947a91.0 for ; Mon, 07 Aug 2023 04:12:33 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:12:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dcd8f9b-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406751; x=1692011551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y2Zq84YPu5W9umXtWflPPzaPyFOqe/t1tbhlrQuOI+E=; b=Y3Gw/8I9wjDIixxDLIQ9R5eAEihH4V5EOGMa/tEQP2UVJcVR6XKMsoq0kNQA9Anemf f07XdP3K3VTdRiql0M+klRK3bCLbXjjp+xplnI9SAQQIK1LQ+ZTQ4iN7KAzzTyuvBW+2 22vOneIjM2lcCre/t1Mc8DL07qt3h0LYO3V6dBXrNJ+ZsacS8/3b5gEWrOt6ylq3sp75 +tN/NsYby1EhnscHKGVaTQLZ5Bd9+GL+XZMM1MIKbWLpVeAc6COrlmvCwmGvjTVu68WR OgVgTRpqhZcRZgjQYAuUYTgXANtTE72/EYkbNkp+iXkkiBUoh7hJkggb0sVF4vx/kVZQ USbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406751; x=1692011551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y2Zq84YPu5W9umXtWflPPzaPyFOqe/t1tbhlrQuOI+E=; b=UNCaGt1tbgCSN8noWjPZxBQ9o/r4oiuVeFKIyhIXMCZfGIDmo7QfEA8Nk825pBIKUz lli3TSq5E71VfUQrkY0ebbkceLfTEmsxxVeGACBXukLJDoBijUXFTmwHueiMtDcZgiu0 ZffDZluilqsPXE8NXcJ27ePxiMRwlf4OKOZvwKpWkDr0QS4XnRwTO+wbTjWAffusNO7d FXfP3Rq8+AFi25eJVYBea+4+MBYK7ajmji7gHDCBN3I9jKamioIUFkh+7e832raTOfMb rDDcYuK+Xzac38mM+cJDF+yJCm0JNDjfZiIGMufvEHvvUoPtr5VTXoXzhPdJfx/TbyXE Wq2Q== X-Gm-Message-State: ABy/qLY1t1rjJ6wXGPouvfxqfHQcyQSYsxFyzcg/wJXvwhjscAzojZRh L5ELANJSjHJGRw156r1n0F0nNA== X-Google-Smtp-Source: APBJJlFA47zqmiKwpfw7q81pKFEqmAkA29wiqRNlMoLoIZqzioc4qMsA62pUfPaD7HBA/F0aUxQzvA== X-Received: by 2002:a17:90a:6c97:b0:263:730b:f568 with SMTP id y23-20020a17090a6c9700b00263730bf568mr23062652pjj.3.1691406750926; Mon, 07 Aug 2023 04:12:30 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 12/48] gfs2: dynamically allocate the gfs2-qd shrinker Date: Mon, 7 Aug 2023 19:09:00 +0800 Message-Id: <20230807110936.21819-13-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the gfs2-qd shrinker. Signed-off-by: Qi Zheng --- fs/gfs2/main.c | 6 +++--- fs/gfs2/quota.c | 26 ++++++++++++++++++++------ fs/gfs2/quota.h | 3 ++- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c index afcb32854f14..e47b1cc79f59 100644 --- a/fs/gfs2/main.c +++ b/fs/gfs2/main.c @@ -147,7 +147,7 @@ static int __init init_gfs2_fs(void) if (!gfs2_trans_cachep) goto fail_cachep8; - error = register_shrinker(&gfs2_qd_shrinker, "gfs2-qd"); + error = gfs2_qd_shrinker_init(); if (error) goto fail_shrinker; @@ -196,7 +196,7 @@ static int __init init_gfs2_fs(void) fail_wq2: destroy_workqueue(gfs_recovery_wq); fail_wq1: - unregister_shrinker(&gfs2_qd_shrinker); + gfs2_qd_shrinker_exit(); fail_shrinker: kmem_cache_destroy(gfs2_trans_cachep); fail_cachep8: @@ -229,7 +229,7 @@ static int __init init_gfs2_fs(void) static void __exit exit_gfs2_fs(void) { - unregister_shrinker(&gfs2_qd_shrinker); + gfs2_qd_shrinker_exit(); gfs2_glock_exit(); gfs2_unregister_debugfs(); unregister_filesystem(&gfs2_fs_type); diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 632806c5ed67..d1e4d8ab8fa1 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -186,13 +186,27 @@ static unsigned long gfs2_qd_shrink_count(struct shrinker *shrink, return vfs_pressure_ratio(list_lru_shrink_count(&gfs2_qd_lru, sc)); } -struct shrinker gfs2_qd_shrinker = { - .count_objects = gfs2_qd_shrink_count, - .scan_objects = gfs2_qd_shrink_scan, - .seeks = DEFAULT_SEEKS, - .flags = SHRINKER_NUMA_AWARE, -}; +static struct shrinker *gfs2_qd_shrinker; + +int __init gfs2_qd_shrinker_init(void) +{ + gfs2_qd_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "gfs2-qd"); + if (!gfs2_qd_shrinker) + return -ENOMEM; + + gfs2_qd_shrinker->count_objects = gfs2_qd_shrink_count; + gfs2_qd_shrinker->scan_objects = gfs2_qd_shrink_scan; + gfs2_qd_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(gfs2_qd_shrinker); + return 0; +} + +void gfs2_qd_shrinker_exit(void) +{ + shrinker_free(gfs2_qd_shrinker); +} static u64 qd2index(struct gfs2_quota_data *qd) { diff --git a/fs/gfs2/quota.h b/fs/gfs2/quota.h index 21ada332d555..f0d54dcbbc75 100644 --- a/fs/gfs2/quota.h +++ b/fs/gfs2/quota.h @@ -59,7 +59,8 @@ static inline int gfs2_quota_lock_check(struct gfs2_inode *ip, } extern const struct quotactl_ops gfs2_quotactl_ops; -extern struct shrinker gfs2_qd_shrinker; +int __init gfs2_qd_shrinker_init(void); +void gfs2_qd_shrinker_exit(void); extern struct list_lru gfs2_qd_lru; extern void __init gfs2_quota_hash_init(void); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578123.905527 (Exim 4.92) (envelope-from ) id 1qSyFE-0001E5-2K; Mon, 07 Aug 2023 11:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578123.905527; Mon, 07 Aug 2023 11:17:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFD-0001Bk-Hg; Mon, 07 Aug 2023 11:17:51 +0000 Received: by outflank-mailman (input) for mailman id 578123; Mon, 07 Aug 2023 11:17:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSy9s-00018O-M4 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:12:20 +0000 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [2607:f8b0:4864:20::102e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 457eec2a-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:12:19 +0200 (CEST) Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2684e225a6cso660486a91.1 for ; Mon, 07 Aug 2023 04:12:19 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:12:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 457eec2a-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406737; x=1692011537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XAY9+N2BbVQBjCT3MmFWkPxUR/2vf6o4m+CtMBoAzag=; b=Owhbp+vjTX9LgSb8kQ7MIhVXGKwDLhR+Ce+1Ax0621Bs9MrN8XWMe5+Ejw9lnwM3Ap IYUW911/vhmnbFJp/stmhIc489u8MPAzdlnhNeoJi8rBqpYOKUrjixaEdD0XprSya4Vj PDunDNjaDu16T3tMnzjFT3t7h/oKuuaUvjmMy7sBXTr5KsxElViOqZ7/5M9dmikw8+EO wMQGbexE8DINXXSrzaCt4DliIlnjdofAsiKIz1t/gb0CaZI+4t4MLa+CBQGQ2Bhdx8d2 /xQiP0jkFYD6YIUPc+4v26SX8VshwmbMbumt9peptq8jkLOVQze1kYBLFAMAnfkePzJe dicw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406737; x=1692011537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XAY9+N2BbVQBjCT3MmFWkPxUR/2vf6o4m+CtMBoAzag=; b=dJaLlLrmXgWOUZI5bd6mabvqQSDi5zxAoOIY5DmkmvxjladkBniJR1KpF80CQN4gVn W6Dh23XWa6Rxzqd44GMGQwJR1GQl2+L8Iiy6Azkvda//mScE4IgKhMzudVtkXkG2GIoR Ikl/D17VoOWT4fsS6gkisHziocfSMUXxu3+EQBm5tzrieUIfVvAV54SpIGt3swIF/jOB HrVRhv7hsRzczSw/Mm1UMrnVQngh228tx0wS5/QBSfmy4ncTj2fDf1JW/IMaUR4VDOyS H4dABN+e73ZmkxncHOUCV3YoAGFYANAeKnPpvAiHaM2YcCLUW/puvoVKZOwBC6URhiN2 RL8A== X-Gm-Message-State: ABy/qLYzkXcU4SUXxNNK7QPBmfLoLKf1g4gD6FBZXn4eK33atezC/J0e 9IIb21uOD6cv2Sg0I2DsmKi28g== X-Google-Smtp-Source: APBJJlGzkEm3Uqt9ffvJXbz1uvSm9jYeOQTwgnDKGaV/IZVLtdfAA6YtivYmWFIriEmVEE/lzsK+Ow== X-Received: by 2002:a17:90a:faf:b0:268:abc:83d5 with SMTP id 44-20020a17090a0faf00b002680abc83d5mr23476433pjz.4.1691406737630; Mon, 07 Aug 2023 04:12:17 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 11/48] gfs2: dynamically allocate the gfs2-glock shrinker Date: Mon, 7 Aug 2023 19:08:59 +0800 Message-Id: <20230807110936.21819-12-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the gfs2-glock shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/gfs2/glock.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 1438e7465e30..8d582ba7514f 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -2046,11 +2046,7 @@ static unsigned long gfs2_glock_shrink_count(struct shrinker *shrink, return vfs_pressure_ratio(atomic_read(&lru_count)); } -static struct shrinker glock_shrinker = { - .seeks = DEFAULT_SEEKS, - .count_objects = gfs2_glock_shrink_count, - .scan_objects = gfs2_glock_shrink_scan, -}; +static struct shrinker *glock_shrinker; /** * glock_hash_walk - Call a function for glock in a hash bucket @@ -2472,13 +2468,19 @@ int __init gfs2_glock_init(void) return -ENOMEM; } - ret = register_shrinker(&glock_shrinker, "gfs2-glock"); - if (ret) { + glock_shrinker = shrinker_alloc(0, "gfs2-glock"); + if (!glock_shrinker) { destroy_workqueue(glock_workqueue); rhashtable_destroy(&gl_hash_table); - return ret; + return -ENOMEM; } + glock_shrinker->count_objects = gfs2_glock_shrink_count; + glock_shrinker->scan_objects = gfs2_glock_shrink_scan; + glock_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(glock_shrinker); + for (i = 0; i < GLOCK_WAIT_TABLE_SIZE; i++) init_waitqueue_head(glock_wait_table + i); @@ -2487,7 +2489,7 @@ int __init gfs2_glock_init(void) void gfs2_glock_exit(void) { - unregister_shrinker(&glock_shrinker); + shrinker_free(glock_shrinker); rhashtable_destroy(&gl_hash_table); destroy_workqueue(glock_workqueue); } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:17:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578121.905520 (Exim 4.92) (envelope-from ) id 1qSyFC-0000kr-OV; Mon, 07 Aug 2023 11:17:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578121.905520; Mon, 07 Aug 2023 11:17:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFB-0000fh-TK; Mon, 07 Aug 2023 11:17:49 +0000 Received: by outflank-mailman (input) for mailman id 578121; Mon, 07 Aug 2023 11:17:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyAw-00018O-Mz for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:13:26 +0000 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [2607:f8b0:4864:20::d2e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6cfbef2d-3513-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:13:25 +0200 (CEST) Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-790b9d7d643so44487739f.1 for ; Mon, 07 Aug 2023 04:13:25 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:13:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cfbef2d-3513-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691406804; x=1692011604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4VJlLpDqVGiuvI83ez+3bl7yR5bVuWalBgtTU2vfBLE=; b=i2oZ2Se5RaRdFd0q9t3NqBTv/dUkxD/p2SyHpAjMjg/XHGqyx1ejwAfepurqt3olXd 4JrDoh1Y9dLDoFntnleeQjfq8XZjg4nTjOSD4Duga+gvfwhzkhg3QVfdrOJlicPQaYUD v5DwTanMH6RhkvK4rWOetuDFETnSCGxcV41PCfrrWGGU2b+vPg8IYLTIauqtUI6qQnyf JDKJFxqA5C/eh/Oo8gwkHqwPIIO1pJg4e68ItW2uJIdbbavFER6b/PwVILGTxzeWrF6b lEtQmpfrwSnO090W7cEUPihusqog8pTCjc32QMYuqZWzqkk8YiBOx308Pfsd+2Yt04OK T2NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691406804; x=1692011604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4VJlLpDqVGiuvI83ez+3bl7yR5bVuWalBgtTU2vfBLE=; b=CUnagC+IRunxI2I+HWCzEVGaZSYwKqtSxXMk8im0u2rFHCPdhY6JheJr2nC+tOGBI5 efPqCsH5oio4qUsHDG7mxgk5A7/y/fXhioCGNOO85zB/JBq9qX5APfJ9aYDH4cWa47t3 WxJQvZbmhJadS25MyJFXaXMYj24ZOqk9XhjEpo17/qQLPihm+Zuhn3nzS0FOIe6EDj+a CGBIAPnRtyHUv6vkn4x3WUNrGNQQ8J0FLqigRFDFHq9EMuGn0b2rLPDw4UgUYMgl2sjp usK4dannFYg6re5yv8VSYqfeUzHDORaUx8Hekhbf+OFcrgT1xvPoN8Pbmcas3Env0JOc 0oSQ== X-Gm-Message-State: ABy/qLYZse8gTekHOX8ovMuUEZfnGlD8yFygrts/pO3R1ha1DCoO0Wu4 OxH9i2oXsqE/6t0nnHTQRIXTxQ== X-Google-Smtp-Source: APBJJlG6KxjpSP18cuDMGPLwCal+2Q6XOYkRmOlR+93TSEU+QOz0TNU1VRvfHZPrdEq648UTFq+gsw== X-Received: by 2002:a92:d944:0:b0:349:3c78:fd14 with SMTP id l4-20020a92d944000000b003493c78fd14mr13499018ilq.1.1691406803912; Mon, 07 Aug 2023 04:13:23 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 16/48] quota: dynamically allocate the dquota-cache shrinker Date: Mon, 7 Aug 2023 19:09:04 +0800 Message-Id: <20230807110936.21819-17-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use new APIs to dynamically allocate the dquota-cache shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/quota/dquot.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 9e72bfe8bbad..c303cffdf433 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -791,12 +791,6 @@ dqcache_shrink_count(struct shrinker *shrink, struct shrink_control *sc) percpu_counter_read_positive(&dqstats.counter[DQST_FREE_DQUOTS])); } -static struct shrinker dqcache_shrinker = { - .count_objects = dqcache_shrink_count, - .scan_objects = dqcache_shrink_scan, - .seeks = DEFAULT_SEEKS, -}; - /* * Safely release dquot and put reference to dquot. */ @@ -2956,6 +2950,7 @@ static int __init dquot_init(void) { int i, ret; unsigned long nr_hash, order; + struct shrinker *dqcache_shrinker; printk(KERN_NOTICE "VFS: Disk quotas %s\n", __DQUOT_VERSION__); @@ -2990,8 +2985,15 @@ static int __init dquot_init(void) pr_info("VFS: Dquot-cache hash table entries: %ld (order %ld," " %ld bytes)\n", nr_hash, order, (PAGE_SIZE << order)); - if (register_shrinker(&dqcache_shrinker, "dquota-cache")) - panic("Cannot register dquot shrinker"); + dqcache_shrinker = shrinker_alloc(0, "dquota-cache"); + if (!dqcache_shrinker) + panic("Cannot allocate dquot shrinker"); + + dqcache_shrinker->count_objects = dqcache_shrink_count; + dqcache_shrinker->scan_objects = dqcache_shrink_scan; + dqcache_shrinker->seeks = DEFAULT_SEEKS; + + shrinker_register(dqcache_shrinker); return 0; } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:18:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:18:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578139.905551 (Exim 4.92) (envelope-from ) id 1qSyFU-000458-8r; Mon, 07 Aug 2023 11:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578139.905551; Mon, 07 Aug 2023 11:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFU-00044r-4m; Mon, 07 Aug 2023 11:18:08 +0000 Received: by outflank-mailman (input) for mailman id 578139; Mon, 07 Aug 2023 11:18:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFT-0003uh-8f for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:18:07 +0000 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [2607:f8b0:4864:20::1033]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 14127c17-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:18:05 +0200 (CEST) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2690803a368so591336a91.1 for ; Mon, 07 Aug 2023 04:18:05 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:18:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14127c17-3514-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407084; x=1692011884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vAE6p5mA5n3yxm+4IPfXfMLc8MGv4J5wg3qHubren08=; b=J9sRUnLVr/1gRDCZ8z/wUaEuDmB5tyJkvTgo3ljho94pxMvUbNxIs6BrAr5OvjDeBd NlwSsbr2CKM03GvossTeyaJQF+TsD29ATXSWWvjw7Kcrs+m5LHvK9yHheRdx6ItlS6Ki yb6ebrPqrWzCUCYAOoHHLe8DTcWnRGuK8IbRkKFIstk7vHG8sx3yXUkwwQ7Mu6THuK5U s7cxqSXTHpGPngOLWfQooqg5Gbhqn2y84s5NSz7JvKiqnrRjOpTq1zeDW5zGBhCfHp8b AvjxYc2lq/KA07E2LvbgtvS8QM8QXYSNfper7Sm+pyp3P6HdBQtVhRokTkSwmgm01BsE Ay4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407084; x=1692011884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vAE6p5mA5n3yxm+4IPfXfMLc8MGv4J5wg3qHubren08=; b=lXfchn7SMlQdL8z3pIbysKLrnE8lsMtjGjXZS6PDnf6it1EnbkWepJc1/DVMdM8r9d 13Bgkkcva2ipb5VQNmH9Gq1MqVz+dvtVn+duwih5+YjBnfpQ6znY5ef1Ybycq1mEkeCo XfxT4vnP7tSaanCD3yWdvalRreZiW54l4L1HzRcb4MZQyGuTB03mG2GmmeVWTUATUF5K xEPFjWgeDWxNCzuXXL8v6gsp+HK1u/AlMkvRQy9FGlmYsjl8Ndn1Hojb8RwGMuZaOjxc W9W3Qt998l9azrYuic/2UOcIukZ2zVcA2duhO8t5AnMaWJvLFS+9MPxbIsyHpaAKRcbW 1OfA== X-Gm-Message-State: AOJu0Yzy/mw9gq1ZG8+Zbs7hgp26SRnRoI97xRbfTZZswbWhpPsF9CTX c0bNdAFKplZCJjo4jdimjyRlgw== X-Google-Smtp-Source: AGHT+IEh5Yyc2UkocOBP861I39wck8cTfExcJN4mGltuRpL51+0K+Rth+2UxJEat5gVmOs+WZ1XBzA== X-Received: by 2002:a17:90a:648:b0:269:60ed:d493 with SMTP id q8-20020a17090a064800b0026960edd493mr1826843pje.4.1691407084214; Mon, 07 Aug 2023 04:18:04 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 38/48] xfs: dynamically allocate the xfs-inodegc shrinker Date: Mon, 7 Aug 2023 19:09:26 +0800 Message-Id: <20230807110936.21819-39-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the xfs-inodegc shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct xfs_mount. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/xfs/xfs_icache.c | 26 +++++++++++++++----------- fs/xfs/xfs_mount.c | 4 ++-- fs/xfs/xfs_mount.h | 2 +- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c index 453890942d9f..751c380afd5a 100644 --- a/fs/xfs/xfs_icache.c +++ b/fs/xfs/xfs_icache.c @@ -2225,8 +2225,7 @@ xfs_inodegc_shrinker_count( struct shrinker *shrink, struct shrink_control *sc) { - struct xfs_mount *mp = container_of(shrink, struct xfs_mount, - m_inodegc_shrinker); + struct xfs_mount *mp = shrink->private_data; struct xfs_inodegc *gc; int cpu; @@ -2247,8 +2246,7 @@ xfs_inodegc_shrinker_scan( struct shrinker *shrink, struct shrink_control *sc) { - struct xfs_mount *mp = container_of(shrink, struct xfs_mount, - m_inodegc_shrinker); + struct xfs_mount *mp = shrink->private_data; struct xfs_inodegc *gc; int cpu; bool no_items = true; @@ -2284,13 +2282,19 @@ int xfs_inodegc_register_shrinker( struct xfs_mount *mp) { - struct shrinker *shrink = &mp->m_inodegc_shrinker; + mp->m_inodegc_shrinker = shrinker_alloc(SHRINKER_NONSLAB, + "xfs-inodegc:%s", + mp->m_super->s_id); + if (!mp->m_inodegc_shrinker) + return -ENOMEM; + + mp->m_inodegc_shrinker->count_objects = xfs_inodegc_shrinker_count; + mp->m_inodegc_shrinker->scan_objects = xfs_inodegc_shrinker_scan; + mp->m_inodegc_shrinker->seeks = 0; + mp->m_inodegc_shrinker->batch = XFS_INODEGC_SHRINKER_BATCH; + mp->m_inodegc_shrinker->private_data = mp; - shrink->count_objects = xfs_inodegc_shrinker_count; - shrink->scan_objects = xfs_inodegc_shrinker_scan; - shrink->seeks = 0; - shrink->flags = SHRINKER_NONSLAB; - shrink->batch = XFS_INODEGC_SHRINKER_BATCH; + shrinker_register(mp->m_inodegc_shrinker); - return register_shrinker(shrink, "xfs-inodegc:%s", mp->m_super->s_id); + return 0; } diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index fb87ffb48f7f..640d09891a4e 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c @@ -1018,7 +1018,7 @@ xfs_mountfs( out_log_dealloc: xfs_log_mount_cancel(mp); out_inodegc_shrinker: - unregister_shrinker(&mp->m_inodegc_shrinker); + shrinker_free(mp->m_inodegc_shrinker); out_fail_wait: if (mp->m_logdev_targp && mp->m_logdev_targp != mp->m_ddev_targp) xfs_buftarg_drain(mp->m_logdev_targp); @@ -1100,7 +1100,7 @@ xfs_unmountfs( #if defined(DEBUG) xfs_errortag_clearall(mp); #endif - unregister_shrinker(&mp->m_inodegc_shrinker); + shrinker_free(mp->m_inodegc_shrinker); xfs_free_perag(mp); xfs_errortag_del(mp); diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index e2866e7fa60c..562c294ca08e 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h @@ -217,7 +217,7 @@ typedef struct xfs_mount { atomic_t m_agirotor; /* last ag dir inode alloced */ /* Memory shrinker to throttle and reprioritize inodegc */ - struct shrinker m_inodegc_shrinker; + struct shrinker *m_inodegc_shrinker; /* * Workqueue item so that we can coalesce multiple inode flush attempts * into a single flush. -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:20:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:20:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578160.905561 (Exim 4.92) (envelope-from ) id 1qSyHa-000722-NB; Mon, 07 Aug 2023 11:20:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578160.905561; Mon, 07 Aug 2023 11:20:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyHa-00071v-Jj; Mon, 07 Aug 2023 11:20:18 +0000 Received: by outflank-mailman (input) for mailman id 578160; Mon, 07 Aug 2023 11:20:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyHY-00071g-Mu for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:20:16 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60e4793f-3514-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 13:20:14 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2690803a368so591675a91.1 for ; Mon, 07 Aug 2023 04:20:14 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:20:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60e4793f-3514-11ee-b27e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407213; x=1692012013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+T9zoPssix7N9qfaGNa68znQHEAFyeYciCKXdVaHQFo=; b=AEtfoTIxkqzl025wvf9yyl8OvVpV1orZ+7ADsAn8FRdyaHqyneHFGuyJ9jSB6bZbnq 2fmUw9pixcoPu0uENFLV6yEHDyHzbx9PEa4/1QReRkJ9Vdrtq4t36sOjNjHyywd/DJSd tcNSBkDsm06qXT7HTJrbLcS8z4Stb96uz/ah29ckB60DgcXFm35Nrt3Aq6Gzw7rdETno 9DoEQihV9/klwV9kg7jDjWFfkJeTbrOGsUsJTU6XthyBDJ62ZHYmlNs7Ps0ai9BdMXBM XSVKEoVI2ousbfFpSnJdwsS47J/fbQRy8WPmYTGdWXjklXq1QHXWKCVy/72epw0hglU+ Vytw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407213; x=1692012013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+T9zoPssix7N9qfaGNa68znQHEAFyeYciCKXdVaHQFo=; b=WJMwiymc2L6lW+B2icz/4INTFpDBEQAZBvKn8OgOcWqxM3bAOc44pgT3854AdUStqD 2bW506OKETTdwS/hVEn9V5mFw2DAqHZHXHmtgDoEr40fpepaoSpZAZ8J/JZvgAPurVQd IKUBZmTlrEuLdK7s1DOGZXV6+m7bukkBLhI0+UyJuGqbRSfK/qDgns+Yk86Swxl/o0D1 vlcNX3Hx+vqGtlhxJ5sLRYsxMJ/Lqdl4rs4ovcfdfkXgwwmDrABSVsUaeWpAAlJN48Ls 6rK12DnJOdSj7qvAGYqxI1QCtIbTSt0REuabzgz9KT8F32/b49rllUxEn5kWs3XgHy6I YylA== X-Gm-Message-State: AOJu0YzwKTRi+XMPdU2UT4VJcsZpQo3kYYb+9yOZ34ByRIIzN3tXwSnh 0uWSR13Gjsf37mP3bW1iDk783A== X-Google-Smtp-Source: AGHT+IF0evmdLrDlsDTr5Y4TU4NmdZynXgLSKug5uHjkOo8cedCVYEqxJp+s7Xi+ZKGxMcrB3jNS6g== X-Received: by 2002:a17:90a:648:b0:269:60ed:d493 with SMTP id q8-20020a17090a064800b0026960edd493mr1830877pje.4.1691407213020; Mon, 07 Aug 2023 04:20:13 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 48/48] mm: shrinker: convert shrinker_rwsem to mutex Date: Mon, 7 Aug 2023 19:09:36 +0800 Message-Id: <20230807110936.21819-49-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Now there are no readers of shrinker_rwsem, so we can simply replace it with mutex lock. Signed-off-by: Qi Zheng --- drivers/md/dm-cache-metadata.c | 2 +- fs/super.c | 2 +- mm/shrinker.c | 28 ++++++++++++++-------------- mm/shrinker_debug.c | 14 +++++++------- 4 files changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c index acffed750e3e..9e0c69958587 100644 --- a/drivers/md/dm-cache-metadata.c +++ b/drivers/md/dm-cache-metadata.c @@ -1828,7 +1828,7 @@ int dm_cache_metadata_abort(struct dm_cache_metadata *cmd) * Replacement block manager (new_bm) is created and old_bm destroyed outside of * cmd root_lock to avoid ABBA deadlock that would result (due to life-cycle of * shrinker associated with the block manager's bufio client vs cmd root_lock). - * - must take shrinker_rwsem without holding cmd->root_lock + * - must take shrinker_mutex without holding cmd->root_lock */ new_bm = dm_block_manager_create(cmd->bdev, DM_CACHE_METADATA_BLOCK_SIZE << SECTOR_SHIFT, CACHE_MAX_CONCURRENT_LOCKS); diff --git a/fs/super.c b/fs/super.c index a28193045345..60c2d290c754 100644 --- a/fs/super.c +++ b/fs/super.c @@ -54,7 +54,7 @@ static char *sb_writers_name[SB_FREEZE_LEVELS] = { * One thing we have to be careful of with a per-sb shrinker is that we don't * drop the last active reference to the superblock from within the shrinker. * If that happens we could trigger unregistering the shrinker from within the - * shrinker path and that leads to deadlock on the shrinker_rwsem. Hence we + * shrinker path and that leads to deadlock on the shrinker_mutex. Hence we * take a passive reference to the superblock to avoid this from occurring. */ static unsigned long super_cache_scan(struct shrinker *shrink, diff --git a/mm/shrinker.c b/mm/shrinker.c index a12dede5d21f..3d44a335ef3c 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -8,7 +8,7 @@ #include "internal.h" LIST_HEAD(shrinker_list); -DECLARE_RWSEM(shrinker_rwsem); +DEFINE_MUTEX(shrinker_mutex); #ifdef CONFIG_MEMCG static int shrinker_nr_max; @@ -80,7 +80,7 @@ int alloc_shrinker_info(struct mem_cgroup *memcg) int nid, ret = 0; int array_size = 0; - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); array_size = shrinker_unit_size(shrinker_nr_max); for_each_node(nid) { info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); @@ -91,7 +91,7 @@ int alloc_shrinker_info(struct mem_cgroup *memcg) goto err; rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); } - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); return ret; @@ -104,7 +104,7 @@ static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, int nid) { return rcu_dereference_protected(memcg->nodeinfo[nid]->shrinker_info, - lockdep_is_held(&shrinker_rwsem)); + lockdep_is_held(&shrinker_mutex)); } static struct shrinker_info *shrinker_info_rcu(struct mem_cgroup *memcg, @@ -161,7 +161,7 @@ static int expand_shrinker_info(int new_id) if (!root_mem_cgroup) goto out; - lockdep_assert_held(&shrinker_rwsem); + lockdep_assert_held(&shrinker_mutex); new_size = shrinker_unit_size(new_nr_max); old_size = shrinker_unit_size(shrinker_nr_max); @@ -224,7 +224,7 @@ static int shrinker_memcg_alloc(struct shrinker *shrinker) if (mem_cgroup_disabled()) return -ENOSYS; - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); id = idr_alloc(&shrinker_idr, shrinker, 0, 0, GFP_KERNEL); if (id < 0) goto unlock; @@ -238,7 +238,7 @@ static int shrinker_memcg_alloc(struct shrinker *shrinker) shrinker->id = id; ret = 0; unlock: - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); return ret; } @@ -248,7 +248,7 @@ static void shrinker_memcg_remove(struct shrinker *shrinker) BUG_ON(id < 0); - lockdep_assert_held(&shrinker_rwsem); + lockdep_assert_held(&shrinker_mutex); idr_remove(&shrinker_idr, id); } @@ -299,7 +299,7 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) parent = root_mem_cgroup; /* Prevent from concurrent shrinker_info expand */ - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); for_each_node(nid) { child_info = shrinker_info_protected(memcg, nid); parent_info = shrinker_info_protected(parent, nid); @@ -312,7 +312,7 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) } } } - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); } #else static int shrinker_memcg_alloc(struct shrinker *shrinker) @@ -708,11 +708,11 @@ void shrinker_register(struct shrinker *shrinker) return; } - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); list_add_tail_rcu(&shrinker->list, &shrinker_list); shrinker->flags |= SHRINKER_REGISTERED; shrinker_debugfs_add(shrinker); - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); init_completion(&shrinker->done); /* @@ -745,7 +745,7 @@ void shrinker_free(struct shrinker *shrinker) wait_for_completion(&shrinker->done); } - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); if (shrinker->flags & SHRINKER_REGISTERED) { /* * Lookups on the shrinker are over and will fail in the future, @@ -760,7 +760,7 @@ void shrinker_free(struct shrinker *shrinker) if (shrinker->flags & SHRINKER_MEMCG_AWARE) shrinker_memcg_remove(shrinker); - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); if (debugfs_entry) shrinker_debugfs_remove(debugfs_entry, debugfs_id); diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c index aa2027075ed9..b698ca9e309e 100644 --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -7,7 +7,7 @@ #include /* defined in vmscan.c */ -extern struct rw_semaphore shrinker_rwsem; +extern struct mutex shrinker_mutex; extern struct list_head shrinker_list; static DEFINE_IDA(shrinker_debugfs_ida); @@ -163,7 +163,7 @@ int shrinker_debugfs_add(struct shrinker *shrinker) char buf[128]; int id; - lockdep_assert_held(&shrinker_rwsem); + lockdep_assert_held(&shrinker_mutex); /* debugfs isn't initialized yet, add debugfs entries later. */ if (!shrinker_debugfs_root) @@ -220,7 +220,7 @@ int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) if (!new) return -ENOMEM; - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); old = shrinker->name; shrinker->name = new; @@ -238,7 +238,7 @@ int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) shrinker->debugfs_entry = entry; } - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); kfree_const(old); @@ -251,7 +251,7 @@ struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, { struct dentry *entry = shrinker->debugfs_entry; - lockdep_assert_held(&shrinker_rwsem); + lockdep_assert_held(&shrinker_mutex); shrinker_debugfs_name_free(shrinker); @@ -279,14 +279,14 @@ static int __init shrinker_debugfs_init(void) shrinker_debugfs_root = dentry; /* Create debugfs entries for shrinkers registered at boot */ - down_write(&shrinker_rwsem); + mutex_lock(&shrinker_mutex); list_for_each_entry(shrinker, &shrinker_list, list) if (!shrinker->debugfs_entry) { ret = shrinker_debugfs_add(shrinker); if (ret) break; } - up_write(&shrinker_rwsem); + mutex_unlock(&shrinker_mutex); return ret; } -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:24:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:24:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578174.905570 (Exim 4.92) (envelope-from ) id 1qSyLE-0007gZ-9S; Mon, 07 Aug 2023 11:24:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578174.905570; Mon, 07 Aug 2023 11:24:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyLE-0007gS-6r; Mon, 07 Aug 2023 11:24:04 +0000 Received: by outflank-mailman (input) for mailman id 578174; Mon, 07 Aug 2023 11:24:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyLD-0007gM-Kl for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:24:03 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060e.outbound.protection.outlook.com [2a01:111:f400:7e8a::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e6bacaad-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:24:01 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DM6PR12MB4862.namprd12.prod.outlook.com (2603:10b6:5:1b7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 11:23:55 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 11:23:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6bacaad-3514-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vyn+ugfKva6Ol2VbfD7KopPEChSkzbj0vCUv2sS6sNmi2UJaOqjvvXEaGWxnz3RT1T1Cr02fQLmv6iqreZ1JBaM5O5LZQTwLBnng0e64dmLCStVBsxZHw6y6epA32XLAeHMihj4xnEWAGYDY+GwXjZCJ9VN3g17HDDnXfX9hkOdpTwlGo44i6ghO+WPNrPMjR236xkcQPDpZ2VNnN4S6BPG8KnI4gtDnj3CGrn+Ftw5hZ/NO+8Jst/dJ2oyZEq6O20antqcChtdjaEeMJlM0AMElvnlAS793FDoGksIyPeEI8dyYf0YVbgYN398fW1f0TbVKLohbkZI+dwQ0OAmdpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bvOt5/tl3yC/oNNRETEh24zwDsRxp4LDd3mEtXQlZgI=; b=T5sRqE/8wwOBTM9+rya6YsJf3OnaLz4EJ4KDApL0xI7mTkgAjRJqZhuJvDS2nnJCYH8N87VOtRCQ489HIW2bIzfO5L3rz16vwj5Ki0z4z/+/BWYy/iigf0zUSUr6SPzUXoeU4Nt5A4q39T7f2sAHYY8eorxzifJ+QYMgNTqsg8vEIIrKnfj7XPc5com3wzUaLh3F3Xi9jNxIE+HKep8Cx/CTvHPY32aEygfJmSoYK+Y38d4boH2lzSWg49hFUucTOXtDjq3+qUBWrzvMiW4eHjXrsIpll8tuZj/ZGGyWSSUB39tRyJHkmgQ38YfRxMoehOIA2nRZK+M8doeZlmtOwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bvOt5/tl3yC/oNNRETEh24zwDsRxp4LDd3mEtXQlZgI=; b=FqIDyHo1zlqMCUmyai1kw+R449lSfbEgps1Ndc2hu4uOPSBhRvhbJQH5X3Fnji5K9vwmgZfezt3nxJP1EmQ0SWzbOscHnBT+MIDC15BGzYha0A0I4CATB50UiDy4xVw++3sFCJN44hXY1UqJagIW/IRqi6O3bZj53Oqwbg0Uom0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> Date: Mon, 7 Aug 2023 12:23:47 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm To: Henry Wang , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230801034419.2047541-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0472.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::28) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DM6PR12MB4862:EE_ X-MS-Office365-Filtering-Correlation-Id: 8766813a-b5f0-49db-76bb-08db9738c903 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VForp5SiL38FF1PvA5dObd9eCYgABmA/tjJqUKoRjpt06Ue3Rw630lOTGSF3BiO2vd4mHwhJUF3p1CH61hq5FCqqlRP3loNt6Y0QW9seJ4hcM3bUKwELVt+xMwkQKz/Vjr6IG2+XpwErhlE6kIcX/CN4n6dc/APMpAs0OyWufYUhS/OFU0bUJ2eYOwALQi3X8HrhrktsNHNsXsEVFZB9QupofkY1e0rGqPRmeQ33rvmJHE06a8Gy0KqINlXdKCmEH39TkzQbbRl9M1bzzgbwlq1KS6wksX2RXpvWyluSHShijXlukPgft7vy6aPnjtuhzgWWm+ZE4G0wWWyBjQXJngX4cE2kHUerbT2Z/jm39tZb4Zo0ZDHCtjne/qHh/SyO+WH9AocY0fcix1T84xpESvF6xB+x51gT78SNowdEcduYWMK8aU2SCNTh2Dcu5Kr+jZe4aLx17H5IPhb5kWvoUvZpuBqF8SlBDwShswj8d8wvIqByNYc+bjfA6Jwzo7WowU4atjThw2g/UPVMx1FWoT1nYVmabQNPl8Du2/zuZoUmcHF7yODPUtil0UNCrMk1f2ug6pnqhkoanBS0NYq0h3+O3sdPwJxCCIKBA0XhtZbz4y/WLrAJ83emOHc8bbjfcuw7dwOfmIX13cFFTDQURg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(478600001)(54906003)(38100700002)(6666004)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(2906002)(83380400001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmtzaVFaTWpSZGZzS2hvTVByRndtS1R0ekJ6NjE4WCtTOWJZdmJ5WHlHN1F1?= =?utf-8?B?VFloYkhmcDFwRkc2YXZ2UGw1ZXRBVjVEZXVLMTZEK1Y2Z0RpRFJrSGt0eHRN?= =?utf-8?B?bk1wMWFINlhjZXBJR2lrL2ZZQmhFeUk1M1g3cCtKbngzSlN2KzdTYS9zZGpU?= =?utf-8?B?U3pWeW5ibXZuSTJkT2lrV1NnUEw3WmFhNnV5ZFFWQ0FhMnJoYVMyQS90bEdQ?= =?utf-8?B?WW1SaEkwOEhOWWlTLy96N2swQ3l2YUlvSFJSM2U4VXRlTmRNb0hQTlJiZnhw?= =?utf-8?B?WERKdkZMQVFpanA2VitiK2lDYWJzd2tnRHN0QjZoNmRyUDdUN0xzcG5aUFFk?= =?utf-8?B?TGI3Uzc2R2ZlaWd5N3VFL1pub09uM1FIWWJRc3BQRWZNZHRWMWYzTXRaTmJX?= =?utf-8?B?WjZYR1JGRXlaTVkzTDRJLzNkSEl3NXBHS2p2ZmlDMUF4REtrdGFXcXh1OWFP?= =?utf-8?B?YWl3ZzlWZkNNVkxaMnU3ZFBHeVUvMjcyeTJscGwwU25oMm1mc0gwaUpWR1FC?= =?utf-8?B?SFBLMGk0V01DSFhlRTZ6dXk4ZkV3aGFiUnR2WWJKM24yNzNHM2J4UTFtenR0?= =?utf-8?B?RlhVU28vQU5SRWFPWlFPVTdjOXRjZ0IzUXQzZE55NnkzelNtTWVpZVRqZmJj?= =?utf-8?B?cG56YU9pVFNrMzBLdDdGS1M0cGpVemovbmV1VVVUZFlBSDkwY05yaGJnOFdl?= =?utf-8?B?cTR2Y25hYjRBcGJzWXVZRDlHTjBRekZsUWNKdUpNNSt1WlRVZ2J2ZDNvVW1P?= =?utf-8?B?LzFDdWVBUE9EWTR6TTBvNW5NbjZmVksvM0N1SWNUUnAzSm94RVltRDlPeTJ1?= =?utf-8?B?Z0V3dUpYQVRPUVR1Mk9kSEVaL0RncU0vTm1ZdlRMRU0rVlR0QVlIcWtsYWxn?= =?utf-8?B?MTRsRzhoUytrTG82NzAybVdKY3BXSllpbms4OWRiRlBjZzk1K3J2N3FVb0Q0?= =?utf-8?B?aURkdlZDRzlZQThsOFdzY09OUTJRY2dvNUhlMGVIVW5TSnF4VHRqVU1oTEVw?= =?utf-8?B?c0J2ZklkWWwyNFNPaWNuY1luL3RnZnJLai9BK2UzUyswMXJiRmEySXFSajFB?= =?utf-8?B?L3ZyRFBwRFV2MkpnR3Q2RXB2UjFIbmE2NEUzN3ZYZFdWdHFzZm13NE9JMVd5?= =?utf-8?B?aE9BQlRQeVJXYUlzNjUxR1l6Q2NTdk04Y2hVeFVnVlRCZGw4ZEFlTUp3dHpl?= =?utf-8?B?SnZjdDBpeG5pSW9MMXdRdXkxY2pPZnl4SkcxR1VaSXVjaGxCTnRVNWRjeVZQ?= =?utf-8?B?YTk4RmVkRnNCSmhBQ0tCYzBGbGtsOExWOEV1YWhmMWs4YnJOeHVrQmNZM2ZL?= =?utf-8?B?REI1bkZmUWx5alk0NWV5RUNFTlFHbTNFMG55eHg4WFgxai92TXZTK0FwU3Zi?= =?utf-8?B?b1F3L3p2YTBBbWNyQ2luQjBkdi9XM1FIem93Y2syOFdLRE9QTStNSmlBWW5r?= =?utf-8?B?QTNuRW9laVl5Q090TGUzd2t1VmhKcFRYam1sN3o4cUJmZno3NUU5ajZIU2pE?= =?utf-8?B?bHF5WXpnNHVQbVQ4bFp2S05KSW5FMTJqbDRHTzZVVllINENqRXlEUWMzWWw5?= =?utf-8?B?cDJJSWxKaHJnU1VJR1BSWWFRYlgzdXRSVHRuOEdUaGJUcHp6NzN0K0t1VUlH?= =?utf-8?B?Sm5BVmNCM3FHb0tBL0pIUEtBN0hiQk5LZDUwTDBSVGR6WS83S1A2SEVLaWZD?= =?utf-8?B?OWVPeWpLclorL2Z2Wm1BZFVJbWdTWStHbUdBOUJRVnk4K2taUTlHYWhBRWRt?= =?utf-8?B?YXNSWGZTZTdNbDgwMDNMOVBEQlpjYzQwNWhCTWJ2YXdEVUNqbFI0VkY3UlhK?= =?utf-8?B?NE5VWExPY2dmVWZtQkFTcVAvNUJqRW1FK0NaUDZ0MVlRSXhqVHdIRDBoaE95?= =?utf-8?B?V1ZBem5Qd1MwZ3BXajBWWDdJTVlLbUgyeGtEcmIxTTk0b3pTa0dNU0NFK1BM?= =?utf-8?B?eUQxQklhVHhJNGVVWTkyZHlOUC9ReURqYmIzVnJxQUNRY3hxMXFtOVdjN3lD?= =?utf-8?B?UEg1c2NybVRsWTVaS3BYeTV1cUZNdExZaXUrR2dZSG51MWZQSVJyRHJsVkRT?= =?utf-8?B?ZDZtcGtaUktabmYxcXRCZ1B4bHVjRWZZVGRUOXd4YzR4YlBvbWxwb0FJYjRt?= =?utf-8?Q?paj2/jwK+uMs41JFqGv4qInQo?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8766813a-b5f0-49db-76bb-08db9738c903 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 11:23:55.2558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K7R5tIoPRb+IRwelSVHurPqHXbn4Z8haDCfRSUr3BfhJ7/B7idSGbsh1W/vhZkgaP04fU1SL4VNARmHw0CnpoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4862 Hi Henry, On 01/08/2023 04:44, Henry Wang wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > From: Wei Chen > > At the moment, on MMU system, enable_mmu() will return to an > address in the 1:1 mapping, then each path is responsible to > switch to virtual runtime mapping. Then remove_identity_mapping() > is called on the boot CPU to remove all 1:1 mapping. > > Since remove_identity_mapping() is not necessary on Non-MMU system, > and we also avoid creating empty function for Non-MMU system, trying > to keep only one codeflow in arm64/head.S, we move path switch and > remove_identity_mapping() in enable_mmu() on MMU system. > > As the remove_identity_mapping should only be called for the boot > CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and > enable_secondary_cpu_mm() for secondary CPUs in this patch. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > Signed-off-by: Henry Wang With two comments Reviewed-by: Ayan Kumar Halder Tested-by: Ayan Kumar Halder > --- > v4: > - Clarify remove_identity_mapping() is called on boot CPU and keep > the function/proc format consistent in commit msg. > - Drop inaccurate (due to the refactor) in-code comment. > - Rename enable_{boot,runtime}_mmu to enable_{boot,secondary}_cpu_mm. > - Reword the in-code comment on top of enable_{boot,secondary}_cpu_mm. > - Call "fail" for unreachable code. > v3: > - new patch > --- > xen/arch/arm/arm64/head.S | 89 ++++++++++++++++++++++++++++++--------- > 1 file changed, 70 insertions(+), 19 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 31cdb54d74..2af9f974d5 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -313,21 +313,11 @@ real_start_efi: > > bl check_cpu_mode > bl cpu_init > - bl create_page_tables > - load_paddr x0, boot_pgtable > - bl enable_mmu > > - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > - ldr x0, =primary_switched > - br x0 > + ldr lr, =primary_switched > + b enable_boot_cpu_mm > + > primary_switched: > - /* > - * The 1:1 map may clash with other parts of the Xen virtual memory > - * layout. As it is not used anymore, remove it completely to > - * avoid having to worry about replacing existing mapping > - * afterwards. > - */ > - bl remove_identity_mapping > bl setup_fixmap > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > @@ -372,13 +362,10 @@ GLOBAL(init_secondary) > #endif > bl check_cpu_mode > bl cpu_init > - load_paddr x0, init_ttbr > - ldr x0, [x0] > - bl enable_mmu > > - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > - ldr x0, =secondary_switched > - br x0 > + ldr lr, =secondary_switched > + b enable_secondary_cpu_mm > + > secondary_switched: > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > @@ -737,6 +724,70 @@ enable_mmu: > ret > ENDPROC(enable_mmu) > > +/* > + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. > + * The function will return to the virtual address provided in LR (e.g. the > + * runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +enable_secondary_cpu_mm: I will prefer "enable_secondary_cpu_mmu" as it is MMU specific. And ... > + mov x5, lr > + > + load_paddr x0, init_ttbr > + ldr x0, [x0] > + > + bl enable_mmu > + mov lr, x5 > + > + /* return to secondary_switched */ > + ret > +ENDPROC(enable_secondary_cpu_mm) > + > +/* > + * Enable mm (turn on the data cache and the MMU) for the boot CPU. > + * The function will return to the virtual address provided in LR (e.g. the > + * runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +enable_boot_cpu_mm: prefer "enable_boot_cpu_mmu" as it is MMU specific as well. - Ayan > + mov x5, lr > + > + bl create_page_tables > + load_paddr x0, boot_pgtable > + > + bl enable_mmu > + mov lr, x5 > + > + /* > + * The MMU is turned on and we are in the 1:1 mapping. Switch > + * to the runtime mapping. > + */ > + ldr x0, =1f > + br x0 > +1: > + /* > + * The 1:1 map may clash with other parts of the Xen virtual memory > + * layout. As it is not used anymore, remove it completely to > + * avoid having to worry about replacing existing mapping > + * afterwards. Function will return to primary_switched. > + */ > + b remove_identity_mapping > + > + /* > + * Below is supposed to be unreachable code, as "ret" in > + * remove_identity_mapping will use the return address in LR in advance. > + */ > + b fail > +ENDPROC(enable_boot_cpu_mm) > + > /* > * Remove the 1:1 map from the page-tables. It is not easy to keep track > * where the 1:1 map was mapped, so we will look for the top-level entry > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578187.905591 (Exim 4.92) (envelope-from ) id 1qSyOW-00007e-0j; Mon, 07 Aug 2023 11:27:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578187.905591; Mon, 07 Aug 2023 11:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOV-00007X-Tg; Mon, 07 Aug 2023 11:27:27 +0000 Received: by outflank-mailman (input) for mailman id 578187; Mon, 07 Aug 2023 11:27:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyGv-0003uh-Te for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:19:37 +0000 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [2607:f8b0:4864:20::d30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a0df1bd-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:19:36 +0200 (CEST) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-790dcf48546so32863139f.0 for ; Mon, 07 Aug 2023 04:19:36 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:19:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a0df1bd-3514-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407175; x=1692011975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VvZzKGLWBPnU/YifQKDl8Wb9pt+zZKHS88YiwcrJMO0=; b=SsVeEy7gwtNzgRLX3Qao2jYE1354yjZBdHrMaMz2XqDOvdbs41vLXJnddUX7FwP0Qx hSxH4iCCuXgVTr2NPnCMWLevPuwCt7LGzr4+TdjZlq4Gl2oVZgjQ80i5jSaavOwgn6QQ +nWVM5qqld5fZH2+ndWf7n2/Ma+aJb4WkOxejaU0XvqKX5vqDu25nIk8n1U32mnTDZgh PkjRGyPGbDKhTCsbJSFCDCkrBYmJRSx+6Z+gu0duks49czJ2bXnjSlvfCZzOJmwtfJCD wbrCVDMtyTbzTIuZroq7DUtUcyce8ZMbc3QUuctGqLseQtbL1sL9WjN8CX6fRRrU5uhk 0bSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407175; x=1692011975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VvZzKGLWBPnU/YifQKDl8Wb9pt+zZKHS88YiwcrJMO0=; b=UE0LMVw6dr5vjIjoGXjPhzNsqg3SuNv2tPY3lugeY+osvBTx7vpaJYHXEcXyvFgL5e 2e5nWyWE39FmtQF/k0FxC/EWRJ0FG3YLa3JRr3vspf6zxgUwq+9ei3D4W+EGtyI9iKy2 vzarJAY4y8spaJdcNOfzId7LDHKC/Ta2zi23p+MjPP2J3Iv3/K+Oxq8eh/PnKm0yT/pZ pOuoOZxKVseZL0npUvvXHyBzW6mG5vX6Qvs39XWMLpssJfbYiX/qBCoFJCfZnjeSPtMy jsnESDaqw1Hw8UmbUhZHaWEokiUd4tQl4uNsKWoijP4RlDc5Cw1GonNTdGma9ravFrtu K6Zg== X-Gm-Message-State: ABy/qLZXTj8nVFav5nHrRQTMVNKZPzaEqnOacUXeBSqUbsFKGRTNwykB gSlxryRnX1FhzK9bvooxbpN1Pg== X-Google-Smtp-Source: APBJJlG/XxZB6sKzQ/QKN1+d/Y+m2Z7kNpKSUjYzz7Oa2LvDnuz3c5eyzNfvhPPV8k8oKjwIpKOiLg== X-Received: by 2002:a6b:c30f:0:b0:783:6e76:6bc7 with SMTP id t15-20020a6bc30f000000b007836e766bc7mr26415608iof.2.1691407174771; Mon, 07 Aug 2023 04:19:34 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless Date: Mon, 7 Aug 2023 19:09:33 +0800 Message-Id: <20230807110936.21819-46-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The shrinker_rwsem is a global read-write lock in shrinkers subsystem, which protects most operations such as slab shrink, registration and unregistration of shrinkers, etc. This can easily cause problems in the following cases. 1) When the memory pressure is high and there are many filesystems mounted or unmounted at the same time, slab shrink will be affected (down_read_trylock() failed). Such as the real workload mentioned by Kirill Tkhai: ``` One of the real workloads from my experience is start of an overcommitted node containing many starting containers after node crash (or many resuming containers after reboot for kernel update). In these cases memory pressure is huge, and the node goes round in long reclaim. ``` 2) If a shrinker is blocked (such as the case mentioned in [1]) and a writer comes in (such as mount a fs), then this writer will be blocked and cause all subsequent shrinker-related operations to be blocked. Even if there is no competitor when shrinking slab, there may still be a problem. The down_read_trylock() may become a perf hotspot with frequent calls to shrink_slab(). Because of the poor multicore scalability of atomic operations, this can lead to a significant drop in IPC (instructions per cycle). We used to implement the lockless slab shrink with SRCU [2], but then kernel test robot reported -88.8% regression in stress-ng.ramfs.ops_per_sec test case [3], so we reverted it [4]. This commit uses the refcount+RCU method [5] proposed by Dave Chinner to re-implement the lockless global slab shrink. The memcg slab shrink is handled in the subsequent patch. For now, all shrinker instances are converted to dynamically allocated and will be freed by call_rcu(). So we can use rcu_read_{lock,unlock}() to ensure that the shrinker instance is valid. And the shrinker instance will not be run again after unregistration. So the structure that records the pointer of shrinker instance can be safely freed without waiting for the RCU read-side critical section. In this way, while we implement the lockless slab shrink, we don't need to be blocked in unregister_shrinker(). The following are the test results: stress-ng --timeout 60 --times --verify --metrics-brief --ramfs 9 & 1) Before applying this patchset: setting to a 60 second run per stressor dispatching hogs: 9 ramfs stressor bogo ops real time usr time sys time bogo ops/s bogo ops/s (secs) (secs) (secs) (real time) (usr+sys time) ramfs 735238 60.00 12.37 363.70 12253.05 1955.08 for a 60.01s run time: 1440.27s available CPU time 12.36s user time ( 0.86%) 363.70s system time ( 25.25%) 376.06s total time ( 26.11%) load average: 10.79 4.47 1.69 passed: 9: ramfs (9) failed: 0 skipped: 0 successful run completed in 60.01s (1 min, 0.01 secs) 2) After applying this patchset: setting to a 60 second run per stressor dispatching hogs: 9 ramfs stressor bogo ops real time usr time sys time bogo ops/s bogo ops/s (secs) (secs) (secs) (real time) (usr+sys time) ramfs 746698 60.00 12.45 376.16 12444.02 1921.47 for a 60.01s run time: 1440.28s available CPU time 12.44s user time ( 0.86%) 376.16s system time ( 26.12%) 388.60s total time ( 26.98%) load average: 9.01 3.85 1.49 passed: 9: ramfs (9) failed: 0 skipped: 0 successful run completed in 60.01s (1 min, 0.01 secs) We can see that the ops/s has hardly changed. [1]. https://lore.kernel.org/lkml/20191129214541.3110-1-ptikhomirov@virtuozzo.com/ [2]. https://lore.kernel.org/lkml/20230313112819.38938-1-zhengqi.arch@bytedance.com/ [3]. https://lore.kernel.org/lkml/202305230837.db2c233f-yujie.liu@intel.com/ [4]. https://lore.kernel.org/all/20230609081518.3039120-1-qi.zheng@linux.dev/ [5]. https://lore.kernel.org/lkml/ZIJhou1d55d4H1s0@dread.disaster.area/ Signed-off-by: Qi Zheng --- include/linux/shrinker.h | 17 ++++++++++ mm/shrinker.c | 70 +++++++++++++++++++++++++++++----------- 2 files changed, 68 insertions(+), 19 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index eb342994675a..f06225f18531 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -4,6 +4,8 @@ #include #include +#include +#include #define SHRINKER_UNIT_BITS BITS_PER_LONG @@ -87,6 +89,10 @@ struct shrinker { int seeks; /* seeks to recreate an obj */ unsigned flags; + refcount_t refcount; + struct completion done; + struct rcu_head rcu; + void *private_data; /* These are for internal use */ @@ -120,6 +126,17 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); void shrinker_register(struct shrinker *shrinker); void shrinker_free(struct shrinker *shrinker); +static inline bool shrinker_try_get(struct shrinker *shrinker) +{ + return refcount_inc_not_zero(&shrinker->refcount); +} + +static inline void shrinker_put(struct shrinker *shrinker) +{ + if (refcount_dec_and_test(&shrinker->refcount)) + complete(&shrinker->done); +} + #ifdef CONFIG_SHRINKER_DEBUG extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...); diff --git a/mm/shrinker.c b/mm/shrinker.c index 1911c06b8af5..d318f5621862 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -2,6 +2,7 @@ #include #include #include +#include #include #include "internal.h" @@ -577,33 +578,42 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) return shrink_slab_memcg(gfp_mask, nid, memcg, priority); - if (!down_read_trylock(&shrinker_rwsem)) - goto out; - - list_for_each_entry(shrinker, &shrinker_list, list) { + rcu_read_lock(); + list_for_each_entry_rcu(shrinker, &shrinker_list, list) { struct shrink_control sc = { .gfp_mask = gfp_mask, .nid = nid, .memcg = memcg, }; + if (!shrinker_try_get(shrinker)) + continue; + + /* + * We can safely unlock the RCU lock here since we already + * hold the refcount of the shrinker. + */ + rcu_read_unlock(); + ret = do_shrink_slab(&sc, shrinker, priority); if (ret == SHRINK_EMPTY) ret = 0; freed += ret; + /* - * Bail out if someone want to register a new shrinker to - * prevent the registration from being stalled for long periods - * by parallel ongoing shrinking. + * This shrinker may be deleted from shrinker_list and freed + * after the shrinker_put() below, but this shrinker is still + * used for the next traversal. So it is necessary to hold the + * RCU lock first to prevent this shrinker from being freed, + * which also ensures that the next shrinker that is traversed + * will not be freed (even if it is deleted from shrinker_list + * at the same time). */ - if (rwsem_is_contended(&shrinker_rwsem)) { - freed = freed ? : 1; - break; - } + rcu_read_lock(); + shrinker_put(shrinker); } - up_read(&shrinker_rwsem); -out: + rcu_read_unlock(); cond_resched(); return freed; } @@ -671,13 +681,29 @@ void shrinker_register(struct shrinker *shrinker) } down_write(&shrinker_rwsem); - list_add_tail(&shrinker->list, &shrinker_list); + list_add_tail_rcu(&shrinker->list, &shrinker_list); shrinker->flags |= SHRINKER_REGISTERED; shrinker_debugfs_add(shrinker); up_write(&shrinker_rwsem); + + init_completion(&shrinker->done); + /* + * Now the shrinker is fully set up, take the first reference to it to + * indicate that lookup operations are now allowed to use it via + * shrinker_try_get(). + */ + refcount_set(&shrinker->refcount, 1); } EXPORT_SYMBOL_GPL(shrinker_register); +static void shrinker_free_rcu_cb(struct rcu_head *head) +{ + struct shrinker *shrinker = container_of(head, struct shrinker, rcu); + + kfree(shrinker->nr_deferred); + kfree(shrinker); +} + void shrinker_free(struct shrinker *shrinker) { struct dentry *debugfs_entry = NULL; @@ -686,9 +712,18 @@ void shrinker_free(struct shrinker *shrinker) if (!shrinker) return; + if (shrinker->flags & SHRINKER_REGISTERED) { + shrinker_put(shrinker); + wait_for_completion(&shrinker->done); + } + down_write(&shrinker_rwsem); if (shrinker->flags & SHRINKER_REGISTERED) { - list_del(&shrinker->list); + /* + * Lookups on the shrinker are over and will fail in the future, + * so we can now remove it from the lists and free it. + */ + list_del_rcu(&shrinker->list); debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); shrinker->flags &= ~SHRINKER_REGISTERED; } else { @@ -702,9 +737,6 @@ void shrinker_free(struct shrinker *shrinker) if (debugfs_entry) shrinker_debugfs_remove(debugfs_entry, debugfs_id); - kfree(shrinker->nr_deferred); - shrinker->nr_deferred = NULL; - - kfree(shrinker); + call_rcu(&shrinker->rcu, shrinker_free_rcu_cb); } EXPORT_SYMBOL_GPL(shrinker_free); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578184.905580 (Exim 4.92) (envelope-from ) id 1qSyOS-0008Iv-OZ; Mon, 07 Aug 2023 11:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578184.905580; Mon, 07 Aug 2023 11:27:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOS-0008Io-M0; Mon, 07 Aug 2023 11:27:24 +0000 Received: by outflank-mailman (input) for mailman id 578184; Mon, 07 Aug 2023 11:27:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFG-0006s9-29 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:17:54 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c9457e8-3514-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:17:53 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1bc4dc65aa7so5900955ad.0 for ; Mon, 07 Aug 2023 04:17:53 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:17:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c9457e8-3514-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407071; x=1692011871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jaqVlo27zysQOw4inLaa7RWYi61naAqQm5GJ5upJpN4=; b=STte4jf7FhwqVhw4SDsuIf9ArKOz7aaezU9GQvpwx72Qohuw9VAsNSdsTliApCOiZv hZglRc835HN169D4rPdYFdfBD3Qzmlb6nb7pOyd5sRW5/Q53h6lgQrbmmsvusnFxieMS 3gEtEAPOYNwIuSKOCZt36UxF2L3eT/vOSqmUXX+knGy5r/m2K69NUUZ1EZhY9Qhw5qzB 8KZjkXC6v5RjXBHEQfQqjwk13t5nh8R+eLAxTypf0xdr6jeYUU8V2GMJD0vc04NJ7YiJ wDeEObjpas42qIWcxQ3ypCHSoS50Jk57/3cVZMKwNJGNUHm8wBkxvAyimm97ZuR/Kr/P R5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407071; x=1692011871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jaqVlo27zysQOw4inLaa7RWYi61naAqQm5GJ5upJpN4=; b=j1kvgqn73W+/kpDKrsEOVNzAcGuUF30GWBQfh1CwsSHDnFgTsOGw2b7i0ssSL6/5Hr PiPubRAwh1tMpGUtjww0/SESX9L5sbx2fHEpjGP9QMMg/hXGdYYVPMbeCmkot1x2m+Pg m19wPEbMvT3m1uC6Vn/GCwe974lRHYl/77krRrTNqJLRCDQwsLdj6VwmWduQ5rKdjomy En/5wu+yOGXLyO92QIGQG3BtkUtT0zcQCQUNovB7jpczBaNT+0FYPNu6pUtQJQ7/1f6t TU1XZcnQWILzKnSxc6OKprHFONUDLUtbAFl7kHb9Kyx/NCoCHtnGoCTdkZH9fi7Hv0bO jkjg== X-Gm-Message-State: AOJu0YyimUu+ntBoe9PTt44VUKV4DCCzrx9soBMsPU1g79GMkUWE5QsF XFICQx02Vrl7yPzgWvr0ZwkEZw== X-Google-Smtp-Source: AGHT+IHBSjfm4qMxfKY1o30DsQrf62j+YLyyzQgOSjZX7MvZKQZkongUtrzUOFN5xrnWaoCKIehpOA== X-Received: by 2002:a17:90a:9c3:b0:269:41cf:7212 with SMTP id 61-20020a17090a09c300b0026941cf7212mr4969668pjo.4.1691407071669; Mon, 07 Aug 2023 04:17:51 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 37/48] xfs: dynamically allocate the xfs-buf shrinker Date: Mon, 7 Aug 2023 19:09:25 +0800 Message-Id: <20230807110936.21819-38-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the xfs-buf shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct xfs_buftarg. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/xfs/xfs_buf.c | 25 ++++++++++++++----------- fs/xfs/xfs_buf.h | 2 +- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 15d1e5a7c2d3..715730fc91cb 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1906,8 +1906,7 @@ xfs_buftarg_shrink_scan( struct shrinker *shrink, struct shrink_control *sc) { - struct xfs_buftarg *btp = container_of(shrink, - struct xfs_buftarg, bt_shrinker); + struct xfs_buftarg *btp = shrink->private_data; LIST_HEAD(dispose); unsigned long freed; @@ -1929,8 +1928,7 @@ xfs_buftarg_shrink_count( struct shrinker *shrink, struct shrink_control *sc) { - struct xfs_buftarg *btp = container_of(shrink, - struct xfs_buftarg, bt_shrinker); + struct xfs_buftarg *btp = shrink->private_data; return list_lru_shrink_count(&btp->bt_lru, sc); } @@ -1938,7 +1936,7 @@ void xfs_free_buftarg( struct xfs_buftarg *btp) { - unregister_shrinker(&btp->bt_shrinker); + shrinker_free(btp->bt_shrinker); ASSERT(percpu_counter_sum(&btp->bt_io_count) == 0); percpu_counter_destroy(&btp->bt_io_count); list_lru_destroy(&btp->bt_lru); @@ -2021,13 +2019,18 @@ xfs_alloc_buftarg( if (percpu_counter_init(&btp->bt_io_count, 0, GFP_KERNEL)) goto error_lru; - btp->bt_shrinker.count_objects = xfs_buftarg_shrink_count; - btp->bt_shrinker.scan_objects = xfs_buftarg_shrink_scan; - btp->bt_shrinker.seeks = DEFAULT_SEEKS; - btp->bt_shrinker.flags = SHRINKER_NUMA_AWARE; - if (register_shrinker(&btp->bt_shrinker, "xfs-buf:%s", - mp->m_super->s_id)) + btp->bt_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "xfs-buf:%s", + mp->m_super->s_id); + if (!btp->bt_shrinker) goto error_pcpu; + + btp->bt_shrinker->count_objects = xfs_buftarg_shrink_count; + btp->bt_shrinker->scan_objects = xfs_buftarg_shrink_scan; + btp->bt_shrinker->seeks = DEFAULT_SEEKS; + btp->bt_shrinker->private_data = btp; + + shrinker_register(btp->bt_shrinker); + return btp; error_pcpu: diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h index 549c60942208..4e6969a675f7 100644 --- a/fs/xfs/xfs_buf.h +++ b/fs/xfs/xfs_buf.h @@ -102,7 +102,7 @@ typedef struct xfs_buftarg { size_t bt_logical_sectormask; /* LRU control structures */ - struct shrinker bt_shrinker; + struct shrinker *bt_shrinker; struct list_lru bt_lru; struct percpu_counter bt_io_count; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578190.905602 (Exim 4.92) (envelope-from ) id 1qSyOY-0000Q7-Gl; Mon, 07 Aug 2023 11:27:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578190.905602; Mon, 07 Aug 2023 11:27:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOY-0000Pz-B0; Mon, 07 Aug 2023 11:27:30 +0000 Received: by outflank-mailman (input) for mailman id 578190; Mon, 07 Aug 2023 11:27:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyGV-0003uh-JH for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:19:11 +0000 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [2607:f8b0:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3a6c241b-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:19:10 +0200 (CEST) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bc76cdf0cbso606115ad.1 for ; Mon, 07 Aug 2023 04:19:09 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:19:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3a6c241b-3514-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407148; x=1692011948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dp1PQp+5gTkm4DG/kxrQVAZ0rB7KyI/rGW6TiEnUaUw=; b=Te7kg9d2kQW6gac9UP89KtIVcLTfWDu6srH7dtxrmXTL4ErpAX/pJkQtXd7hg2HtRV b8geFLLbM8+wRhZIYuLjJhyOfyGHnlddPjbSoTi8+7JUn0itl8DrGEf9FkegNhDgT4QU +aRhY4yC93Sy/uol3bSwIULh/giMXKgqvscX8PDfZ03M6CNIZOjJqm4ZovfIFxg7FXvq HemaZ47NKkfhG9oH07mD8LDQiWRUxbmI+sshlvUeh5qK7EeOWS/jAB9AyDVCuXh9Krsn cGXM1IoaSAiEJffIAN7TmuDV3qm2xRt9nfiAYhQ3/VTYWFSG3zxU2XV/jGXOIaUTjpLr zeJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407148; x=1692011948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dp1PQp+5gTkm4DG/kxrQVAZ0rB7KyI/rGW6TiEnUaUw=; b=GryOYNnvpbg4tWza8txk5RxmWI8uw5DxxNdnBozqTMPE5Pwm+Vt66kyspJPhUlvZBh qZKmJCQPjq6RQkbMGHp4ZX4EaeE9WsSvOA++R4mB5UdBebsFCcMOjVbCWLNjtdpWtYps 8N/pSTXW9JBd/aOkw6yOlHpB7bCijwNTF2vHV9rGesTOltnHDRre6SBizrmi0qgUtS9J OnwTA99alCdzH+XM+Zv+nMI1tsoS/J55TZwRv+ilUSySU2jVNg73U2z0oVMaWAN8B7NM OpshWypNIAGM8627Re88CZND8X9jYfqpyl9kCnE+n/5PxudvpaowHMnGan26Ax05jE4R BMBg== X-Gm-Message-State: ABy/qLbMAOt0/sYoGiL7HbkqW+gHOWcfCgRjjilkActx9bNdwTz3UBh3 T+KfaiWbitiT3+qmNYbDd1yA9g== X-Google-Smtp-Source: APBJJlGWGDf3ZP6TvEF/B95Km+XRmBUarTmlKp42txasQQnYUyfeo2SyrhxLvRA3BfrSE4M4+QRzMg== X-Received: by 2002:a17:902:dace:b0:1b8:17e8:5472 with SMTP id q14-20020a170902dace00b001b817e85472mr32807567plx.1.1691407148534; Mon, 07 Aug 2023 04:19:08 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 43/48] drm/ttm: introduce pool_shrink_rwsem Date: Mon, 7 Aug 2023 19:09:31 +0800 Message-Id: <20230807110936.21819-44-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, the synchronize_shrinkers() is only used by TTM pool. It only requires that no shrinkers run in parallel. After we use RCU+refcount method to implement the lockless slab shrink, we can not use shrinker_rwsem or synchronize_rcu() to guarantee that all shrinker invocations have seen an update before freeing memory. So we introduce a new pool_shrink_rwsem to implement a private synchronize_shrinkers(), so as to achieve the same purpose. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- drivers/gpu/drm/ttm/ttm_pool.c | 15 +++++++++++++++ include/linux/shrinker.h | 2 -- mm/shrinker.c | 15 --------------- 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index c9c9618c0dce..38b4c280725c 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -74,6 +74,7 @@ static struct ttm_pool_type global_dma32_uncached[MAX_ORDER + 1]; static spinlock_t shrinker_lock; static struct list_head shrinker_list; static struct shrinker *mm_shrinker; +static DECLARE_RWSEM(pool_shrink_rwsem); /* Allocate pages of size 1 << order with the given gfp_flags */ static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags, @@ -317,6 +318,7 @@ static unsigned int ttm_pool_shrink(void) unsigned int num_pages; struct page *p; + down_read(&pool_shrink_rwsem); spin_lock(&shrinker_lock); pt = list_first_entry(&shrinker_list, typeof(*pt), shrinker_list); list_move_tail(&pt->shrinker_list, &shrinker_list); @@ -329,6 +331,7 @@ static unsigned int ttm_pool_shrink(void) } else { num_pages = 0; } + up_read(&pool_shrink_rwsem); return num_pages; } @@ -572,6 +575,18 @@ void ttm_pool_init(struct ttm_pool *pool, struct device *dev, } EXPORT_SYMBOL(ttm_pool_init); +/** + * synchronize_shrinkers - Wait for all running shrinkers to complete. + * + * This is useful to guarantee that all shrinker invocations have seen an + * update, before freeing memory, similar to rcu. + */ +static void synchronize_shrinkers(void) +{ + down_write(&pool_shrink_rwsem); + up_write(&pool_shrink_rwsem); +} + /** * ttm_pool_fini - Cleanup a pool * diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index c55c07c3f0cb..025c8070dd86 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -103,8 +103,6 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); void shrinker_register(struct shrinker *shrinker); void shrinker_free(struct shrinker *shrinker); -extern void synchronize_shrinkers(void); - #ifdef CONFIG_SHRINKER_DEBUG extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...); diff --git a/mm/shrinker.c b/mm/shrinker.c index 3ab301ff122d..a27779ed3798 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -650,18 +650,3 @@ void shrinker_free(struct shrinker *shrinker) kfree(shrinker); } EXPORT_SYMBOL_GPL(shrinker_free); - -/** - * synchronize_shrinkers - Wait for all running shrinkers to complete. - * - * This is equivalent to calling unregister_shrink() and register_shrinker(), - * but atomically and with less overhead. This is useful to guarantee that all - * shrinker invocations have seen an update, before freeing memory, similar to - * rcu. - */ -void synchronize_shrinkers(void) -{ - down_write(&shrinker_rwsem); - up_write(&shrinker_rwsem); -} -EXPORT_SYMBOL(synchronize_shrinkers); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578194.905611 (Exim 4.92) (envelope-from ) id 1qSyOb-0000ky-NO; Mon, 07 Aug 2023 11:27:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578194.905611; Mon, 07 Aug 2023 11:27:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOb-0000kn-JH; Mon, 07 Aug 2023 11:27:33 +0000 Received: by outflank-mailman (input) for mailman id 578194; Mon, 07 Aug 2023 11:27:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFe-0006s9-MU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:18:18 +0000 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [2607:f8b0:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b8dc30e-3514-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:18:18 +0200 (CEST) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-55b78bf0423so392504a12.0 for ; Mon, 07 Aug 2023 04:18:18 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:18:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b8dc30e-3514-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407097; x=1692011897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NbTnBXz1rftevvtnrJnbyUTbBXZHNhmRyJT9VBuSKEk=; b=I0fRADtMeQ7ZYN4lawqOYqpZyATzMma8+JI7v8Zk4meeIAhlCUAEE4oant9GMpCU9c e1/RDTnNhNkcs7YzYpKhdN1XDfh3C1CzV0J+KZ3/D4mlZFUuIdDCGJV9GUewRdITND6b 4GYUs3S5ZWDZ5Jh0dvaqr1VDHgapHBN1S1ychIZWiQ7oRwFoKrrtIpw0qxts3s8CAjGr ydAlHOG9qMq4ZFwUnfssYxxr3X8fPLTZ5CluqYa54YAa1ITLLjbOydQ2pku3tDphziTJ CgtcI6R1bGyzpwkNzZouq5zSQbcmQPiHyBeMkjagL4bEVNYZ8WMV4Nik0kWzaqHzYD2e Au8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407097; x=1692011897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NbTnBXz1rftevvtnrJnbyUTbBXZHNhmRyJT9VBuSKEk=; b=GGGGDq0ihFT2mVLKGW8HCfX33sYgowhfIX0elL+OJ5bgIrkp11rqPxw6SMCMEZPdnX AKyIn2iRMVH4Bdo83daZpgPolsYQAtOOPTP3csDD8PbYlybSRPHpjxz8oo8JAeryNHn7 Z5V2EzxN/snvMQhPHrs+nvYUsaRpAcYkWuRvAomifgRdcccOzNKd3SLDgDpbX4cbnaln gYIV05A4YgDYtf6lm0SlSfcmJkKONmVc9TfzKG2dOANrnw9p4gPXEzLF/0ar6uiT6v1p vCBEpGGzCMyPzgSdooLL/4ZdtOtPuXQXqKDUmoRcisLybcl5eNYkHMpKlSHYBN/k+gbt S47w== X-Gm-Message-State: ABy/qLYw6CImWFEe3XkPZSB9njWg56LfkydJK/3TT3dW7Vy+S8U25mrW 1fIFUp4cPJnLSCIsJq5utX4vTA== X-Google-Smtp-Source: APBJJlHEA3k+axkYWIvy1nHuTMRTEcDAAx3CbSXEmipYg83y/9axHDl54yrvmY4ExsXdwismqiSLfg== X-Received: by 2002:a17:90a:901:b0:268:3a31:3e4d with SMTP id n1-20020a17090a090100b002683a313e4dmr23078546pjn.2.1691407096844; Mon, 07 Aug 2023 04:18:16 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 39/48] xfs: dynamically allocate the xfs-qm shrinker Date: Mon, 7 Aug 2023 19:09:27 +0800 Message-Id: <20230807110936.21819-40-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the xfs-qm shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct xfs_quotainfo. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/xfs/xfs_qm.c | 28 +++++++++++++++------------- fs/xfs/xfs_qm.h | 2 +- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c index 6abcc34fafd8..15ba23f11271 100644 --- a/fs/xfs/xfs_qm.c +++ b/fs/xfs/xfs_qm.c @@ -504,8 +504,7 @@ xfs_qm_shrink_scan( struct shrinker *shrink, struct shrink_control *sc) { - struct xfs_quotainfo *qi = container_of(shrink, - struct xfs_quotainfo, qi_shrinker); + struct xfs_quotainfo *qi = shrink->private_data; struct xfs_qm_isolate isol; unsigned long freed; int error; @@ -539,8 +538,7 @@ xfs_qm_shrink_count( struct shrinker *shrink, struct shrink_control *sc) { - struct xfs_quotainfo *qi = container_of(shrink, - struct xfs_quotainfo, qi_shrinker); + struct xfs_quotainfo *qi = shrink->private_data; return list_lru_shrink_count(&qi->qi_lru, sc); } @@ -680,15 +678,19 @@ xfs_qm_init_quotainfo( if (XFS_IS_PQUOTA_ON(mp)) xfs_qm_set_defquota(mp, XFS_DQTYPE_PROJ, qinf); - qinf->qi_shrinker.count_objects = xfs_qm_shrink_count; - qinf->qi_shrinker.scan_objects = xfs_qm_shrink_scan; - qinf->qi_shrinker.seeks = DEFAULT_SEEKS; - qinf->qi_shrinker.flags = SHRINKER_NUMA_AWARE; - - error = register_shrinker(&qinf->qi_shrinker, "xfs-qm:%s", - mp->m_super->s_id); - if (error) + qinf->qi_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "xfs-qm:%s", + mp->m_super->s_id); + if (!qinf->qi_shrinker) { + error = -ENOMEM; goto out_free_inos; + } + + qinf->qi_shrinker->count_objects = xfs_qm_shrink_count; + qinf->qi_shrinker->scan_objects = xfs_qm_shrink_scan; + qinf->qi_shrinker->seeks = DEFAULT_SEEKS; + qinf->qi_shrinker->private_data = qinf; + + shrinker_register(qinf->qi_shrinker); return 0; @@ -718,7 +720,7 @@ xfs_qm_destroy_quotainfo( qi = mp->m_quotainfo; ASSERT(qi != NULL); - unregister_shrinker(&qi->qi_shrinker); + shrinker_free(qi->qi_shrinker); list_lru_destroy(&qi->qi_lru); xfs_qm_destroy_quotainos(qi); mutex_destroy(&qi->qi_tree_lock); diff --git a/fs/xfs/xfs_qm.h b/fs/xfs/xfs_qm.h index 9683f0457d19..d5c9fc4ba591 100644 --- a/fs/xfs/xfs_qm.h +++ b/fs/xfs/xfs_qm.h @@ -63,7 +63,7 @@ struct xfs_quotainfo { struct xfs_def_quota qi_usr_default; struct xfs_def_quota qi_grp_default; struct xfs_def_quota qi_prj_default; - struct shrinker qi_shrinker; + struct shrinker *qi_shrinker; /* Minimum and maximum quota expiration timestamp values. */ time64_t qi_expiry_min; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578199.905621 (Exim 4.92) (envelope-from ) id 1qSyOg-0001BU-VM; Mon, 07 Aug 2023 11:27:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578199.905621; Mon, 07 Aug 2023 11:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOg-0001BH-SZ; Mon, 07 Aug 2023 11:27:38 +0000 Received: by outflank-mailman (input) for mailman id 578199; Mon, 07 Aug 2023 11:27:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyGH-0006s9-IR for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:18:57 +0000 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [2607:f8b0:4864:20::102a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 32b647a8-3514-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:18:57 +0200 (CEST) Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-2680edb9767so931405a91.0 for ; Mon, 07 Aug 2023 04:18:56 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:18:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32b647a8-3514-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407135; x=1692011935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G6s8y0Dka4KE4srOwy3I0FSAaIGrcYmvE6JrVZfCpDs=; b=F7XshDjIR6gshLCWKrdL8cyHybumA0/QTbPgZKuavvkyWifyhyd8BPMZmPX4yYKyuR FqCSmklkv54KgX1wnfbIyihDlZ+e496yGoiYQIhi+0ixsCUryfshptm9G6dp+SRnN5FZ 14VdUNX9Rmk7l5AkZvhyOA8ndezzsKV7UULQBi3lhNzHrS31pQni36O5M2aWjlsy7K8I o85BeLJKM7bNO8S7mlfBATfdEP7ozNpVuz6OBa+5fivR91DGlVYeJ7lIDECv66TYSV5p 4CyX1RUktrUPPn4ZHlIEu6EqOTTTT5xmI9T+Qsmwod8lVyyIBYN72T68dyXuYMVy1bdZ 5S4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407135; x=1692011935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G6s8y0Dka4KE4srOwy3I0FSAaIGrcYmvE6JrVZfCpDs=; b=TfVOqukYjxPWQ54BVDbr9fjrFP9nw+x7Xgjv9CPmVOZz5mu1ljhqNO8AsfGtH+y0Yt 5XIx7iuLv8aUpRPS/nz/re+MAPwwkrG9oWBm9aQEbJbQ7g/mmzTFSdik5/wDRj+m0AMJ K3J4pHKFRU4nY0u1eJfrgtv+0HQgsTsWQnkDrFbV3mNG8DYQgsaSbDdcLyeXw+ZafBuQ iwvkWjMxO19yoxJXjxyggpmoQ3/2LWG2GnHICRPsaodEHqslxKRhiqmskVdCcpLyleN+ 9/8Zfv/WBDiqQ7qFgzty6efjXnMxQof2v6vEcJPoLCfBovHNu/h+iyHLbT5C+7Ng4N8v tTow== X-Gm-Message-State: ABy/qLZzx4u6Lg4OAAzlGvchd8XEkferV8vdtK8v7M8h20iSIiYGFcOO If0RaBzpJxRopx9K0LDdgCyAhw== X-Google-Smtp-Source: APBJJlENzs/96m+S7UnwJhfsSEKfLFwoWHJhRek0zeax/GsXgLjOrIeuu6U5nntKJfSobDso4iAXPQ== X-Received: by 2002:a17:90a:1f83:b0:268:3dc6:f0c5 with SMTP id x3-20020a17090a1f8300b002683dc6f0c5mr25042984pja.0.1691407135598; Mon, 07 Aug 2023 04:18:55 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 42/48] mm: shrinker: remove old APIs Date: Mon, 7 Aug 2023 19:09:30 +0800 Message-Id: <20230807110936.21819-43-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Now no users are using the old APIs, just remove them. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- include/linux/shrinker.h | 7 -- mm/shrinker.c | 143 --------------------------------------- 2 files changed, 150 deletions(-) diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index cc23ff0aee20..c55c07c3f0cb 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -103,13 +103,6 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); void shrinker_register(struct shrinker *shrinker); void shrinker_free(struct shrinker *shrinker); -extern int __printf(2, 3) prealloc_shrinker(struct shrinker *shrinker, - const char *fmt, ...); -extern void register_shrinker_prepared(struct shrinker *shrinker); -extern int __printf(2, 3) register_shrinker(struct shrinker *shrinker, - const char *fmt, ...); -extern void unregister_shrinker(struct shrinker *shrinker); -extern void free_prealloced_shrinker(struct shrinker *shrinker); extern void synchronize_shrinkers(void); #ifdef CONFIG_SHRINKER_DEBUG diff --git a/mm/shrinker.c b/mm/shrinker.c index 43a375f954f3..3ab301ff122d 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -651,149 +651,6 @@ void shrinker_free(struct shrinker *shrinker) } EXPORT_SYMBOL_GPL(shrinker_free); -/* - * Add a shrinker callback to be called from the vm. - */ -static int __prealloc_shrinker(struct shrinker *shrinker) -{ - unsigned int size; - int err; - - if (shrinker->flags & SHRINKER_MEMCG_AWARE) { - err = prealloc_memcg_shrinker(shrinker); - if (err != -ENOSYS) - return err; - - shrinker->flags &= ~SHRINKER_MEMCG_AWARE; - } - - size = sizeof(*shrinker->nr_deferred); - if (shrinker->flags & SHRINKER_NUMA_AWARE) - size *= nr_node_ids; - - shrinker->nr_deferred = kzalloc(size, GFP_KERNEL); - if (!shrinker->nr_deferred) - return -ENOMEM; - - return 0; -} - -#ifdef CONFIG_SHRINKER_DEBUG -int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - va_list ap; - int err; - - va_start(ap, fmt); - shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); - va_end(ap); - if (!shrinker->name) - return -ENOMEM; - - err = __prealloc_shrinker(shrinker); - if (err) { - kfree_const(shrinker->name); - shrinker->name = NULL; - } - - return err; -} -#else -int prealloc_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - return __prealloc_shrinker(shrinker); -} -#endif - -void free_prealloced_shrinker(struct shrinker *shrinker) -{ -#ifdef CONFIG_SHRINKER_DEBUG - kfree_const(shrinker->name); - shrinker->name = NULL; -#endif - if (shrinker->flags & SHRINKER_MEMCG_AWARE) { - down_write(&shrinker_rwsem); - unregister_memcg_shrinker(shrinker); - up_write(&shrinker_rwsem); - return; - } - - kfree(shrinker->nr_deferred); - shrinker->nr_deferred = NULL; -} - -void register_shrinker_prepared(struct shrinker *shrinker) -{ - down_write(&shrinker_rwsem); - list_add_tail(&shrinker->list, &shrinker_list); - shrinker->flags |= SHRINKER_REGISTERED; - shrinker_debugfs_add(shrinker); - up_write(&shrinker_rwsem); -} - -static int __register_shrinker(struct shrinker *shrinker) -{ - int err = __prealloc_shrinker(shrinker); - - if (err) - return err; - register_shrinker_prepared(shrinker); - return 0; -} - -#ifdef CONFIG_SHRINKER_DEBUG -int register_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - va_list ap; - int err; - - va_start(ap, fmt); - shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); - va_end(ap); - if (!shrinker->name) - return -ENOMEM; - - err = __register_shrinker(shrinker); - if (err) { - kfree_const(shrinker->name); - shrinker->name = NULL; - } - return err; -} -#else -int register_shrinker(struct shrinker *shrinker, const char *fmt, ...) -{ - return __register_shrinker(shrinker); -} -#endif -EXPORT_SYMBOL(register_shrinker); - -/* - * Remove one - */ -void unregister_shrinker(struct shrinker *shrinker) -{ - struct dentry *debugfs_entry; - int debugfs_id; - - if (!(shrinker->flags & SHRINKER_REGISTERED)) - return; - - down_write(&shrinker_rwsem); - list_del(&shrinker->list); - shrinker->flags &= ~SHRINKER_REGISTERED; - if (shrinker->flags & SHRINKER_MEMCG_AWARE) - unregister_memcg_shrinker(shrinker); - debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); - up_write(&shrinker_rwsem); - - shrinker_debugfs_remove(debugfs_entry, debugfs_id); - - kfree(shrinker->nr_deferred); - shrinker->nr_deferred = NULL; -} -EXPORT_SYMBOL(unregister_shrinker); - /** * synchronize_shrinkers - Wait for all running shrinkers to complete. * -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578200.905631 (Exim 4.92) (envelope-from ) id 1qSyOj-0001Xc-Aj; Mon, 07 Aug 2023 11:27:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578200.905631; Mon, 07 Aug 2023 11:27:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOj-0001XK-4D; Mon, 07 Aug 2023 11:27:41 +0000 Received: by outflank-mailman (input) for mailman id 578200; Mon, 07 Aug 2023 11:27:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyH8-0003uh-IS for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:19:50 +0000 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [2607:f8b0:4864:20::102b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 517fee21-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:19:48 +0200 (CEST) Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-265c94064b8so593535a91.0 for ; Mon, 07 Aug 2023 04:19:48 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:19:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 517fee21-3514-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407187; x=1692011987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kfKKsEp61SZUnTy00HUcIO/dAXsDrrCBrc1q4f5gA2g=; b=O8pmKc9mkUPcwQn3K6b4vfxrIY3urK+/nlSQG6IQu3i18+IpYULExI3wKEZ/xymknF +6oCCfFy6i2a+FxBuWdzORrib00J2OMl9nk96M99T35Rfc4jeDAhNe99hGl5QvCM8eUE R++VmLiOwJ6rpxA/HEOBJYNzpyPX4zl9hoqj3WQaK+cPExCggyj0/ZBw0z6oFSY7C91n 2YVhcwVUTJYlZTyzWc8hxnW2XvaNGOtz3UCGr0ovpjlwcNhR4geKecrxjuux2WrpYp3y 4o91QPRwP3cp6mR8m2un4L62pLlrYSmXBb+57ubwaC0hesJSLB153WlFgONAQW4tHigo DeMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407187; x=1692011987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kfKKsEp61SZUnTy00HUcIO/dAXsDrrCBrc1q4f5gA2g=; b=TCN//pwjuWDnBv90TUNEs0bhRtc7s9FnVv/oHoFgbIPedHewlrOkfjuUJTiEMvaHbi LggwCMSo//7FPTbuKxkxHX4WQuvxO9snig6YwZrM/mMBcKlFe3v4TJBicTQfC8SbRsaw /tAXwWTC0s9+rW6P23aIMuWSqVJa37PV3GQm31rpnmDDZgbABmWYk4w3AjJFkNRadvUZ fcNFRBS3boshSqD3R5CCCYOKxe2uHcDNUggyBK8Otsb2qEwIHqpDPssNjZVF8XZHgSOY yPljpjNX+F1rLg5wfo+5oxZblrxKP6OcrWyvPNtr/dtob3+zYE3cLX4wGmnLYL34OV55 l3jA== X-Gm-Message-State: ABy/qLap3eP3JiqQYjoIPq5qVnQSkh7aeBv49ODGxsrhduheAzhFy3u3 wtkJS0maD5wVvE4o1rsrEmo+9A== X-Google-Smtp-Source: APBJJlGG6pz8UXODUVvMLzBj3hYH8JYeumw11e9YZ9plh8RnP0KuzfFyuRP+T7CTu9v0n/nCJMsqhQ== X-Received: by 2002:a17:90a:1090:b0:268:126c:8a8b with SMTP id c16-20020a17090a109000b00268126c8a8bmr24580285pja.3.1691407187287; Mon, 07 Aug 2023 04:19:47 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 46/48] mm: shrinker: make memcg slab shrink lockless Date: Mon, 7 Aug 2023 19:09:34 +0800 Message-Id: <20230807110936.21819-47-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Like global slab shrink, this commit also uses refcount+RCU method to make memcg slab shrink lockless. Use the following script to do slab shrink stress test: ``` DIR="/root/shrinker/memcg/mnt" do_create() { mkdir -p /sys/fs/cgroup/memory/test echo 4G > /sys/fs/cgroup/memory/test/memory.limit_in_bytes for i in `seq 0 $1`; do mkdir -p /sys/fs/cgroup/memory/test/$i; echo $$ > /sys/fs/cgroup/memory/test/$i/cgroup.procs; mkdir -p $DIR/$i; done } do_mount() { for i in `seq $1 $2`; do mount -t tmpfs $i $DIR/$i; done } do_touch() { for i in `seq $1 $2`; do echo $$ > /sys/fs/cgroup/memory/test/$i/cgroup.procs; dd if=/dev/zero of=$DIR/$i/file$i bs=1M count=1 & done } case "$1" in touch) do_touch $2 $3 ;; test) do_create 4000 do_mount 0 4000 do_touch 0 3000 ;; *) exit 1 ;; esac ``` Save the above script, then run test and touch commands. Then we can use the following perf command to view hotspots: perf top -U -F 999 1) Before applying this patchset: 40.44% [kernel] [k] down_read_trylock 17.59% [kernel] [k] up_read 13.64% [kernel] [k] pv_native_safe_halt 11.90% [kernel] [k] shrink_slab 8.21% [kernel] [k] idr_find 2.71% [kernel] [k] _find_next_bit 1.36% [kernel] [k] shrink_node 0.81% [kernel] [k] shrink_lruvec 0.80% [kernel] [k] __radix_tree_lookup 0.50% [kernel] [k] do_shrink_slab 0.21% [kernel] [k] list_lru_count_one 0.16% [kernel] [k] mem_cgroup_iter 2) After applying this patchset: 60.17% [kernel] [k] shrink_slab 20.42% [kernel] [k] pv_native_safe_halt 3.03% [kernel] [k] do_shrink_slab 2.73% [kernel] [k] shrink_node 2.27% [kernel] [k] shrink_lruvec 2.00% [kernel] [k] __rcu_read_unlock 1.92% [kernel] [k] mem_cgroup_iter 0.98% [kernel] [k] __rcu_read_lock 0.91% [kernel] [k] osq_lock 0.63% [kernel] [k] mem_cgroup_calculate_protection 0.55% [kernel] [k] shrinker_put 0.46% [kernel] [k] list_lru_count_one We can see that the first perf hotspot becomes shrink_slab, which is what we expect. Signed-off-by: Qi Zheng --- mm/shrinker.c | 80 ++++++++++++++++++++++++++++++++++----------------- 1 file changed, 54 insertions(+), 26 deletions(-) diff --git a/mm/shrinker.c b/mm/shrinker.c index d318f5621862..fee6f62904fb 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -107,6 +107,12 @@ static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, lockdep_is_held(&shrinker_rwsem)); } +static struct shrinker_info *shrinker_info_rcu(struct mem_cgroup *memcg, + int nid) +{ + return rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); +} + static int expand_one_shrinker_info(struct mem_cgroup *memcg, int new_size, int old_size, int new_nr_max) { @@ -198,7 +204,7 @@ void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) struct shrinker_info_unit *unit; rcu_read_lock(); - info = rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); + info = shrinker_info_rcu(memcg, nid); unit = info->unit[shriner_id_to_index(shrinker_id)]; if (!WARN_ON_ONCE(shrinker_id >= info->map_nr_max)) { /* Pairs with smp mb in shrink_slab() */ @@ -211,7 +217,7 @@ void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) static DEFINE_IDR(shrinker_idr); -static int prealloc_memcg_shrinker(struct shrinker *shrinker) +static int shrinker_memcg_alloc(struct shrinker *shrinker) { int id, ret = -ENOMEM; @@ -219,7 +225,6 @@ static int prealloc_memcg_shrinker(struct shrinker *shrinker) return -ENOSYS; down_write(&shrinker_rwsem); - /* This may call shrinker, so it must use down_read_trylock() */ id = idr_alloc(&shrinker_idr, shrinker, 0, 0, GFP_KERNEL); if (id < 0) goto unlock; @@ -237,7 +242,7 @@ static int prealloc_memcg_shrinker(struct shrinker *shrinker) return ret; } -static void unregister_memcg_shrinker(struct shrinker *shrinker) +static void shrinker_memcg_remove(struct shrinker *shrinker) { int id = shrinker->id; @@ -253,10 +258,15 @@ static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, { struct shrinker_info *info; struct shrinker_info_unit *unit; + long nr_deferred; - info = shrinker_info_protected(memcg, nid); + rcu_read_lock(); + info = shrinker_info_rcu(memcg, nid); unit = info->unit[shriner_id_to_index(shrinker->id)]; - return atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); + nr_deferred = atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); + rcu_read_unlock(); + + return nr_deferred; } static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, @@ -264,10 +274,16 @@ static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, { struct shrinker_info *info; struct shrinker_info_unit *unit; + long nr_deferred; - info = shrinker_info_protected(memcg, nid); + rcu_read_lock(); + info = shrinker_info_rcu(memcg, nid); unit = info->unit[shriner_id_to_index(shrinker->id)]; - return atomic_long_add_return(nr, &unit->nr_deferred[shriner_id_to_offset(shrinker->id)]); + nr_deferred = + atomic_long_add_return(nr, &unit->nr_deferred[shriner_id_to_offset(shrinker->id)]); + rcu_read_unlock(); + + return nr_deferred; } void reparent_shrinker_deferred(struct mem_cgroup *memcg) @@ -299,12 +315,12 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) up_read(&shrinker_rwsem); } #else -static int prealloc_memcg_shrinker(struct shrinker *shrinker) +static int shrinker_memcg_alloc(struct shrinker *shrinker) { return -ENOSYS; } -static void unregister_memcg_shrinker(struct shrinker *shrinker) +static void shrinker_memcg_remove(struct shrinker *shrinker) { } @@ -464,18 +480,23 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, if (!mem_cgroup_online(memcg)) return 0; - if (!down_read_trylock(&shrinker_rwsem)) - return 0; - - info = shrinker_info_protected(memcg, nid); +again: + rcu_read_lock(); + info = shrinker_info_rcu(memcg, nid); if (unlikely(!info)) goto unlock; - for (; index < shriner_id_to_index(info->map_nr_max); index++) { + if (index < shriner_id_to_index(info->map_nr_max)) { struct shrinker_info_unit *unit; unit = info->unit[index]; + /* + * The shrinker_info_unit will not be freed, so we can + * safely release the RCU lock here. + */ + rcu_read_unlock(); + for_each_set_bit(offset, unit->map, SHRINKER_UNIT_BITS) { struct shrink_control sc = { .gfp_mask = gfp_mask, @@ -485,12 +506,14 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, struct shrinker *shrinker; int shrinker_id = calc_shrinker_id(index, offset); + rcu_read_lock(); shrinker = idr_find(&shrinker_idr, shrinker_id); - if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { - if (!shrinker) - clear_bit(offset, unit->map); + if (unlikely(!shrinker || !shrinker_try_get(shrinker))) { + clear_bit(offset, unit->map); + rcu_read_unlock(); continue; } + rcu_read_unlock(); /* Call non-slab shrinkers even though kmem is disabled */ if (!memcg_kmem_online() && @@ -523,15 +546,20 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, set_shrinker_bit(memcg, nid, shrinker_id); } freed += ret; - - if (rwsem_is_contended(&shrinker_rwsem)) { - freed = freed ? : 1; - goto unlock; - } + shrinker_put(shrinker); } + + /* + * We have already exited the read-side of rcu critical section + * before calling do_shrink_slab(), the shrinker_info may be + * released in expand_one_shrinker_info(), so reacquire the + * shrinker_info. + */ + index++; + goto again; } unlock: - up_read(&shrinker_rwsem); + rcu_read_unlock(); return freed; } #else /* !CONFIG_MEMCG */ @@ -638,7 +666,7 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...) shrinker->flags = flags | SHRINKER_ALLOCATED; if (flags & SHRINKER_MEMCG_AWARE) { - err = prealloc_memcg_shrinker(shrinker); + err = shrinker_memcg_alloc(shrinker); if (err == -ENOSYS) shrinker->flags &= ~SHRINKER_MEMCG_AWARE; else if (err == 0) @@ -731,7 +759,7 @@ void shrinker_free(struct shrinker *shrinker) } if (shrinker->flags & SHRINKER_MEMCG_AWARE) - unregister_memcg_shrinker(shrinker); + shrinker_memcg_remove(shrinker); up_write(&shrinker_rwsem); if (debugfs_entry) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578201.905641 (Exim 4.92) (envelope-from ) id 1qSyOm-00024Q-PQ; Mon, 07 Aug 2023 11:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578201.905641; Mon, 07 Aug 2023 11:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOm-00024B-Le; Mon, 07 Aug 2023 11:27:44 +0000 Received: by outflank-mailman (input) for mailman id 578201; Mon, 07 Aug 2023 11:27:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyEq-0006s9-17 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:17:28 +0000 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [2607:f8b0:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd484779-3513-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:17:27 +0200 (CEST) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-55b5a37acb6so362679a12.0 for ; Mon, 07 Aug 2023 04:17:27 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:17:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd484779-3513-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407046; x=1692011846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v5vYJ8kE3O6JXdLxdEEyUgUMjz4KJqSKKSB151wqkNo=; b=SddB5W7TBGS4uOBB54oAwQadrL7fhf6DQuFGu8VJel4YD8JvtkF5mhOckA/6vdi9nq hlVTmdr/Kx1D4xlpvO2OSKYXB5RvVMiR6sESxeeh8/ktD09qDCXXwpDE4WqRU8hY11FY G6KR4LUZZolsNcExYWQgBloqrZSLljdTAa93b1m2N036gRwi9BwogxNRXUsItZlswdeV RttwDZcFyg1S8l+4ePFxtqYFv2AYsGXbvb/zq8emVyERgALeuEVi3b9ZjwWVeQ9iauxk xcZs9+wDP4Bgr5Tw0/5OxVGHY2k5SYNUfTOTk9l9GbDIx4PuLA8GEzMw0rmzVwGr35V7 B6uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407046; x=1692011846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v5vYJ8kE3O6JXdLxdEEyUgUMjz4KJqSKKSB151wqkNo=; b=aqrltFF/tdLNYFuL4MG2Nkt9RG2bbpGrIy0b/jR2db7xHovuGDMeejsUPOw54ge5yR rpu9EsmCjPyOQ+nqJtYz0xGV4SZ8fwVOYZIsujRnCOUrtI+hmR1XVjSAQ5ZpltzI70iu 96rwb5jk30nzKHkm7if/fSiBT68SHKp6ybvFFQc03ljZXls+evqJu8v5WC+QpB32Q3Z+ LZjkpwjyA9XQ98HAmc+VfqtigarIV738AUaiHoRRuqYdvr3aaL+M68jlc0YS+tjeO5I4 uJioYxIEHbjyN5Y63g30JmGtzDI/4Dxr2SahGXHluFh+H81dY/QjYayPxYMzMR6jYBNn urKA== X-Gm-Message-State: ABy/qLYMZA4esmacX5lwF1cVGCLre79RYKxU8MPlX6c8c+wMgJoGD+36 VeTCUQvgdh71nTKMxCFAScwiBQ== X-Google-Smtp-Source: APBJJlFyAF6s6JefOZNl/scuUGwKU5q0BmH7yK6Qf+JZ3E1mrAS2lh5NuGQm2RRGuEVfms4+14afyQ== X-Received: by 2002:a17:90a:3f08:b0:268:1e3b:14c9 with SMTP id l8-20020a17090a3f0800b002681e3b14c9mr23486908pjc.2.1691407045970; Mon, 07 Aug 2023 04:17:25 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Chuck Lever , Jeff Layton Subject: [PATCH v4 35/48] nfsd: dynamically allocate the nfsd-client shrinker Date: Mon, 7 Aug 2023 19:09:23 +0800 Message-Id: <20230807110936.21819-36-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the nfsd-client shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct nfsd_net. Signed-off-by: Qi Zheng Acked-by: Chuck Lever Acked-by: Jeff Layton --- fs/nfsd/netns.h | 2 +- fs/nfsd/nfs4state.c | 20 ++++++++++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h index ec49b200b797..f669444d5336 100644 --- a/fs/nfsd/netns.h +++ b/fs/nfsd/netns.h @@ -195,7 +195,7 @@ struct nfsd_net { int nfs4_max_clients; atomic_t nfsd_courtesy_clients; - struct shrinker nfsd_client_shrinker; + struct shrinker *nfsd_client_shrinker; struct work_struct nfsd_shrinker_work; }; diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 8534693eb6a4..9e401db8a6d2 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -4400,8 +4400,7 @@ static unsigned long nfsd4_state_shrinker_count(struct shrinker *shrink, struct shrink_control *sc) { int count; - struct nfsd_net *nn = container_of(shrink, - struct nfsd_net, nfsd_client_shrinker); + struct nfsd_net *nn = shrink->private_data; count = atomic_read(&nn->nfsd_courtesy_clients); if (!count) @@ -8149,12 +8148,17 @@ static int nfs4_state_create_net(struct net *net) INIT_WORK(&nn->nfsd_shrinker_work, nfsd4_state_shrinker_worker); get_net(net); - nn->nfsd_client_shrinker.scan_objects = nfsd4_state_shrinker_scan; - nn->nfsd_client_shrinker.count_objects = nfsd4_state_shrinker_count; - nn->nfsd_client_shrinker.seeks = DEFAULT_SEEKS; - - if (register_shrinker(&nn->nfsd_client_shrinker, "nfsd-client")) + nn->nfsd_client_shrinker = shrinker_alloc(0, "nfsd-client"); + if (!nn->nfsd_client_shrinker) goto err_shrinker; + + nn->nfsd_client_shrinker->scan_objects = nfsd4_state_shrinker_scan; + nn->nfsd_client_shrinker->count_objects = nfsd4_state_shrinker_count; + nn->nfsd_client_shrinker->seeks = DEFAULT_SEEKS; + nn->nfsd_client_shrinker->private_data = nn; + + shrinker_register(nn->nfsd_client_shrinker); + return 0; err_shrinker: @@ -8252,7 +8256,7 @@ nfs4_state_shutdown_net(struct net *net) struct list_head *pos, *next, reaplist; struct nfsd_net *nn = net_generic(net, nfsd_net_id); - unregister_shrinker(&nn->nfsd_client_shrinker); + shrinker_free(nn->nfsd_client_shrinker); cancel_work(&nn->nfsd_shrinker_work); cancel_delayed_work_sync(&nn->laundromat_work); locks_end_grace(&nn->nfsd4_manager); -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578217.905651 (Exim 4.92) (envelope-from ) id 1qSyOu-0002tD-4f; Mon, 07 Aug 2023 11:27:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578217.905651; Mon, 07 Aug 2023 11:27:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOu-0002t3-0U; Mon, 07 Aug 2023 11:27:52 +0000 Received: by outflank-mailman (input) for mailman id 578217; Mon, 07 Aug 2023 11:27:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyHM-0003uh-2G for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:20:04 +0000 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [2607:f8b0:4864:20::1035]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 591a764c-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:20:01 +0200 (CEST) Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2680edb9767so931611a91.0 for ; Mon, 07 Aug 2023 04:20:01 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:19:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 591a764c-3514-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407200; x=1692012000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X5ij/O+E/bk/tTzX9mgxwiCynzBHcXx4EKtI9EsHayo=; b=i3OLYIqgHrVEAaoeqhN7xu/7U1C+reDkv4O93uYT3wVXPD8PclsjVNwGlC6uACGJON 5G7yHqhhbIuKFoghA6ZSicHcXMJKMfCogQ8szn+vWtZn4EOKB8vbAdIc7rpijTp0cbxa Z/AamO41rUovV3Rd5mToLS3fdUn/gIbndWW5fXdkD//uV9WpRp/5E2yE1kJcYdxc2q43 2kKg85HGCsKzT23sBdglbe/LKtHC4WUeFtaNvdRNowxvHAXGs/cRyz4+kFuB/ka63yH8 5vv+ldmlZuknYjC0UrMsohE+IjtZuT+2tIf1cSRO1giyAMKM5zLXRshImNoV+3DwaEWW qy8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407200; x=1692012000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X5ij/O+E/bk/tTzX9mgxwiCynzBHcXx4EKtI9EsHayo=; b=jvkh+Hc1Brc29n5mxG5FbHZK6Ixkr5s1gdKGwAQUoyQ8HJPEZhSo3B9bCekSyM66DJ fr+RFo7h1jj9+2dg4poQwQNTl2AbMfzZxYAZimgVt8yaBpG3xzY5YdV/6IzkOLyhk4ya QcPY5H9nArGohxEREwhbMpcv4HXkYOE2wYzcLsbhFp2DZNdQ7l4DS8gj8en9uCgoKCFt 86zy20JRanowyEwRXcFAVG4I9LfcMuLtVp3hmyuAwdwIonlloXMZeBnC0F/tR5eNkwrJ 2ack5d1btgzTJh5zyCUfgrDKo74pjG69j98a+PiBQrZZ1hcAa57XO0OKodSw/eMd//OB XICQ== X-Gm-Message-State: AOJu0YxeIKxzU09bBVvzRcCfF8Niuz3gCmwR+I7enEvaDFN7XU6v+yOY Msp6QhlbwSxaOVIx8xk5WIEBp1g2lPmLOEFNh6E= X-Google-Smtp-Source: AGHT+IH1iUQIXRu8fJbzxUHSh+kWmc44BJdJFh0ZxZy41KSEiq7lusFAb/6JfkXEPdg45Q03TKbByg== X-Received: by 2002:a17:90a:9c3:b0:269:41cf:7212 with SMTP id 61-20020a17090a09c300b0026941cf7212mr4973775pjo.4.1691407200010; Mon, 07 Aug 2023 04:20:00 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng Subject: [PATCH v4 47/48] mm: shrinker: hold write lock to reparent shrinker nr_deferred Date: Mon, 7 Aug 2023 19:09:35 +0800 Message-Id: <20230807110936.21819-48-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For now, reparent_shrinker_deferred() is the only holder of read lock of shrinker_rwsem. And it already holds the global cgroup_mutex, so it will not be called in parallel. Therefore, in order to convert shrinker_rwsem to shrinker_mutex later, here we change to hold the write lock of shrinker_rwsem to reparent. Signed-off-by: Qi Zheng --- mm/shrinker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/shrinker.c b/mm/shrinker.c index fee6f62904fb..a12dede5d21f 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -299,7 +299,7 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) parent = root_mem_cgroup; /* Prevent from concurrent shrinker_info expand */ - down_read(&shrinker_rwsem); + down_write(&shrinker_rwsem); for_each_node(nid) { child_info = shrinker_info_protected(memcg, nid); parent_info = shrinker_info_protected(parent, nid); @@ -312,7 +312,7 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) } } } - up_read(&shrinker_rwsem); + up_write(&shrinker_rwsem); } #else static int shrinker_memcg_alloc(struct shrinker *shrinker) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:27:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:27:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578222.905661 (Exim 4.92) (envelope-from ) id 1qSyOx-0003PU-C7; Mon, 07 Aug 2023 11:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578222.905661; Mon, 07 Aug 2023 11:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyOx-0003PK-8b; Mon, 07 Aug 2023 11:27:55 +0000 Received: by outflank-mailman (input) for mailman id 578222; Mon, 07 Aug 2023 11:27:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyG6-0003uh-5T for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:18:46 +0000 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [2607:f8b0:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b2bbfce-3514-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:18:44 +0200 (CEST) Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-51f64817809so361036a12.1 for ; Mon, 07 Aug 2023 04:18:44 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:18:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b2bbfce-3514-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407123; x=1692011923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AnO+VrCD4LojLy+8kmnCjGg0ZRt7Zy9NIxA02Cs4pZw=; b=PfEVKvTzBWRKzDZcOs/Fep65btb/5j6s3WDHceANi3UdyfyE1ZYJjj/ojCsgHi3Vd1 UnyiA9UJ+WO0skTyzkklbevZFVt0QM5P026zpV9irULg/dt9elBIaT9aO85mKj85kzSK 8BL7WAzqEgJCUSOrld3eSg+Xi6Bj/nVLlSU4qlnz3r3ovJoXr2T2o0DtWh8ePmCGKfhu 8HAbYH+dcq7rqiPTVsEp3knKk+0ZUdZ34RURzik4J4PgZDJhHLpdrzH5JSXxHECtRx3a erZSmwbY1m1zt8qE5RzbmfCM7KzyvNBKjG86UwibulZ8+wpz72tXfP+ENX4A3BoRP40M UhJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407123; x=1692011923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AnO+VrCD4LojLy+8kmnCjGg0ZRt7Zy9NIxA02Cs4pZw=; b=Dhgf83zjvevLfRglW4SKsH7E20mc6DK+36XiCSOHT1lSV+e9hH5v54zY0CfNcXThzg +wfJgJ5v3dBp0yJFnzyQiQXsYjkNMIF1jg6FuHDfUbvOq6NFZiL5A+mBxo0W+kE0ZAd8 rF6qS05q5dZIgm6s+UAu+gEUUwWcp7MIYEssw/KKVg4VdUBPfB3G5GghQLEbltcDSDHZ koZRKX4AssDMYnX3eoup239Fjvyj/iTYsc2zwKvEm4kSW8HA+zovzSA0U5YtZCiwKwYR 8X9bgje2UT7PuTjyiftBujcDIoDFHXIZDC0F0EZU5ttmcSQtQEI2p58TDg4AwNZ0RNsm GK0w== X-Gm-Message-State: ABy/qLaz4knzC8ViBwYZdegeii1TfBb57TwG7A0W38RH4Agvh7X5prF0 1yeMSNPr2VxbASZc1WN3NhWEjA== X-Google-Smtp-Source: APBJJlGN7o+mPwW+D250kL/E75whSiIFGnI9vIACxkViJa+uI/EkAzzWgkZZOw/GfOlqJQ+tGCA4bg== X-Received: by 2002:a17:90a:3f08:b0:268:1e3b:14c9 with SMTP id l8-20020a17090a3f0800b002681e3b14c9mr23489214pjc.2.1691407122942; Mon, 07 Aug 2023 04:18:42 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 41/48] fs: super: dynamically allocate the s_shrink Date: Mon, 7 Aug 2023 19:09:29 +0800 Message-Id: <20230807110936.21819-42-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the s_shrink, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct super_block. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- fs/btrfs/super.c | 2 +- fs/kernfs/mount.c | 2 +- fs/proc/root.c | 2 +- fs/super.c | 34 +++++++++++++++++++--------------- include/linux/fs.h | 2 +- 5 files changed, 23 insertions(+), 19 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 5ca07b41b4cd..c6980fc6fe02 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -1514,7 +1514,7 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type, snprintf(s->s_id, sizeof(s->s_id), "%pg", fs_devices->latest_dev->bdev); - shrinker_debugfs_rename(&s->s_shrink, "sb-%s:%s", fs_type->name, + shrinker_debugfs_rename(s->s_shrink, "sb-%s:%s", fs_type->name, s->s_id); fs_info->bdev_holder = s; error = btrfs_fill_super(s, fs_devices, data); diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c index c4bf26142eec..79b96e74a8a0 100644 --- a/fs/kernfs/mount.c +++ b/fs/kernfs/mount.c @@ -265,7 +265,7 @@ static int kernfs_fill_super(struct super_block *sb, struct kernfs_fs_context *k sb->s_time_gran = 1; /* sysfs dentries and inodes don't require IO to create */ - sb->s_shrink.seeks = 0; + sb->s_shrink->seeks = 0; /* get root inode, initialize and unlock it */ down_read(&kf_root->kernfs_rwsem); diff --git a/fs/proc/root.c b/fs/proc/root.c index 9191248f2dac..b55dbc70287b 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c @@ -188,7 +188,7 @@ static int proc_fill_super(struct super_block *s, struct fs_context *fc) s->s_stack_depth = FILESYSTEM_MAX_STACK_DEPTH; /* procfs dentries and inodes don't require IO to create */ - s->s_shrink.seeks = 0; + s->s_shrink->seeks = 0; pde_get(&proc_root); root_inode = proc_get_inode(s, &proc_root); diff --git a/fs/super.c b/fs/super.c index 2354bcab6fff..a28193045345 100644 --- a/fs/super.c +++ b/fs/super.c @@ -67,7 +67,7 @@ static unsigned long super_cache_scan(struct shrinker *shrink, long dentries; long inodes; - sb = container_of(shrink, struct super_block, s_shrink); + sb = shrink->private_data; /* * Deadlock avoidance. We may hold various FS locks, and we don't want @@ -120,7 +120,7 @@ static unsigned long super_cache_count(struct shrinker *shrink, struct super_block *sb; long total_objects = 0; - sb = container_of(shrink, struct super_block, s_shrink); + sb = shrink->private_data; /* * We don't call trylock_super() here as it is a scalability bottleneck, @@ -182,7 +182,7 @@ static void destroy_unused_super(struct super_block *s) security_sb_free(s); put_user_ns(s->s_user_ns); kfree(s->s_subtype); - free_prealloced_shrinker(&s->s_shrink); + shrinker_free(s->s_shrink); /* no delays needed */ destroy_super_work(&s->destroy_work); } @@ -259,16 +259,20 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags, s->s_time_min = TIME64_MIN; s->s_time_max = TIME64_MAX; - s->s_shrink.seeks = DEFAULT_SEEKS; - s->s_shrink.scan_objects = super_cache_scan; - s->s_shrink.count_objects = super_cache_count; - s->s_shrink.batch = 1024; - s->s_shrink.flags = SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE; - if (prealloc_shrinker(&s->s_shrink, "sb-%s", type->name)) + s->s_shrink = shrinker_alloc(SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE, + "sb-%s", type->name); + if (!s->s_shrink) goto fail; - if (list_lru_init_memcg(&s->s_dentry_lru, &s->s_shrink)) + + s->s_shrink->seeks = DEFAULT_SEEKS; + s->s_shrink->scan_objects = super_cache_scan; + s->s_shrink->count_objects = super_cache_count; + s->s_shrink->batch = 1024; + s->s_shrink->private_data = s; + + if (list_lru_init_memcg(&s->s_dentry_lru, s->s_shrink)) goto fail; - if (list_lru_init_memcg(&s->s_inode_lru, &s->s_shrink)) + if (list_lru_init_memcg(&s->s_inode_lru, s->s_shrink)) goto fail; return s; @@ -326,7 +330,7 @@ void deactivate_locked_super(struct super_block *s) { struct file_system_type *fs = s->s_type; if (atomic_dec_and_test(&s->s_active)) { - unregister_shrinker(&s->s_shrink); + shrinker_free(s->s_shrink); fs->kill_sb(s); /* @@ -610,7 +614,7 @@ struct super_block *sget_fc(struct fs_context *fc, hlist_add_head(&s->s_instances, &s->s_type->fs_supers); spin_unlock(&sb_lock); get_filesystem(s->s_type); - register_shrinker_prepared(&s->s_shrink); + shrinker_register(s->s_shrink); return s; share_extant_sb: @@ -693,7 +697,7 @@ struct super_block *sget(struct file_system_type *type, hlist_add_head(&s->s_instances, &type->fs_supers); spin_unlock(&sb_lock); get_filesystem(type); - register_shrinker_prepared(&s->s_shrink); + shrinker_register(s->s_shrink); return s; } EXPORT_SYMBOL(sget); @@ -1312,7 +1316,7 @@ int setup_bdev_super(struct super_block *sb, int sb_flags, mutex_unlock(&bdev->bd_fsfreeze_mutex); snprintf(sb->s_id, sizeof(sb->s_id), "%pg", bdev); - shrinker_debugfs_rename(&sb->s_shrink, "sb-%s:%s", sb->s_type->name, + shrinker_debugfs_rename(sb->s_shrink, "sb-%s:%s", sb->s_type->name, sb->s_id); sb_set_blocksize(sb, block_size(bdev)); return 0; diff --git a/include/linux/fs.h b/include/linux/fs.h index 9515d3688f71..1464afd41164 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1263,7 +1263,7 @@ struct super_block { const struct dentry_operations *s_d_op; /* default d_op for dentries */ - struct shrinker s_shrink; /* per-sb shrinker handle */ + struct shrinker *s_shrink; /* per-sb shrinker handle */ /* Number of inodes with nlink == 0 but still referenced */ atomic_long_t s_remove_count; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:28:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:28:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578232.905671 (Exim 4.92) (envelope-from ) id 1qSyP2-0003xt-Nf; Mon, 07 Aug 2023 11:28:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578232.905671; Mon, 07 Aug 2023 11:28:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyP2-0003xh-JT; Mon, 07 Aug 2023 11:28:00 +0000 Received: by outflank-mailman (input) for mailman id 578232; Mon, 07 Aug 2023 11:27:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyGi-0006s9-7a for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:19:24 +0000 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [2607:f8b0:4864:20::102a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4259b6f0-3514-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:19:23 +0200 (CEST) Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-268f6ba57b5so625658a91.1 for ; Mon, 07 Aug 2023 04:19:23 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:19:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4259b6f0-3514-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407162; x=1692011962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BzKzY0EneoO0UlcJt4xJM2Sa0N5zE3blYFeUn1CwPvs=; b=MbCTfulzQY8dcLMV7HUHZRkhp3R/ALHm/oybkLiEqSrlkrAL5AMkdjufi+qbbnlWzq EwOScEMFKT9DjlO/FYIYHMtQq2tg1SmdFY2OX8CdMMfBbKmXJY114QpKxGPF0i15Oq8D +QZTUaNL6+5L3yXNniaSpwyckXVIsRgL4m06kBthWlP5xd4q7OECI5FeIwXi87e+H4c/ GUueoXTkms0i44pnefrN2CLy0SrJ5TW2S78B6UOaIOz/bQbdtDd+1wdG+NZVHpYstsoy +lnW4zf/cx/QjFol8gTUnT8cVUpimeAwTwTHHi/YAESl2hNrNHChT1CjEcEW9U23Nr7T gLNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407162; x=1692011962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BzKzY0EneoO0UlcJt4xJM2Sa0N5zE3blYFeUn1CwPvs=; b=l+lVhb4hHsrNiBGnckqOMrKNxvrHFUii0/yNvPBLaYNH76gR/GaiymL9culzec0rDa 0h998vgmBUWxzioFT3X0zrG7D6m45zs3DkXSe2GtbFy0L+2KlgylivfDEnsXheF4KGCW lomb4Rc2C20iYPrbK5Yi1XK99tWri4US+BK5iSBc2AYPlJsz9fv4gub5NHcnfiwPnJCH yuEIPbmqeQW2AJYt/S6CkoYuBL+twQsYETOO7NgxE+/5hXu6bFqH5IapuWghUZwfvIbV bTLcH9ErlpwOzYqt0GPI6XGbW70A3LaxR9e5SfV+RBtjw38k3UiGD9PTrIzXEUY74Fcx 6zcA== X-Gm-Message-State: ABy/qLZinp4mGNQMjiDW7taYNy8DnFo4iCHMqGebSQE38pm5ox4YfGLv aCPyOzAh6Ob2WRcZf/w9Irt1cw== X-Google-Smtp-Source: APBJJlGnB4Vyj5FGeoXczgSMBfjSqXYaN0nHE2UQ92aOKZGOd+EBKMKhZPi2ZgbvTuAEcRBjftj7zw== X-Received: by 2002:a17:90a:6c97:b0:263:730b:f568 with SMTP id y23-20020a17090a6c9700b00263730bf568mr23074339pjj.3.1691407161746; Mon, 07 Aug 2023 04:19:21 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 44/48] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} Date: Mon, 7 Aug 2023 19:09:32 +0800 Message-Id: <20230807110936.21819-45-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, we maintain two linear arrays per node per memcg, which are shrinker_info::map and shrinker_info::nr_deferred. And we need to resize them when the shrinker_nr_max is exceeded, that is, allocate a new array, and then copy the old array to the new array, and finally free the old array by RCU. For shrinker_info::map, we do set_bit() under the RCU lock, so we may set the value into the old map which is about to be freed. This may cause the value set to be lost. The current solution is not to copy the old map when resizing, but to set all the corresponding bits in the new map to 1. This solves the data loss problem, but bring the overhead of more pointless loops while doing memcg slab shrink. For shrinker_info::nr_deferred, we will only modify it under the read lock of shrinker_rwsem, so it will not run concurrently with the resizing. But after we make memcg slab shrink lockless, there will be the same data loss problem as shrinker_info::map, and we can't work around it like the map. For such resizable arrays, the most straightforward idea is to change it to xarray, like we did for list_lru [1]. We need to do xa_store() in the list_lru_add()-->set_shrinker_bit(), but this will cause memory allocation, and the list_lru_add() doesn't accept failure. A possible solution is to pre-allocate, but the location of pre-allocation is not well determined. Therefore, this commit chooses to introduce a secondary array for shrinker_info::{map, nr_deferred}, so that we only need to copy this secondary array every time the size is resized. Then even if we get the old secondary array under the RCU lock, the found map and nr_deferred are also true, so no data is lost. [1]. https://lore.kernel.org/all/20220228122126.37293-13-songmuchun@bytedance.com/ Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- include/linux/memcontrol.h | 12 +- include/linux/shrinker.h | 17 +++ mm/shrinker.c | 250 +++++++++++++++++++++++-------------- 3 files changed, 172 insertions(+), 107 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 11810a2cfd2d..b49515bb6fbd 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -21,6 +21,7 @@ #include #include #include +#include struct mem_cgroup; struct obj_cgroup; @@ -88,17 +89,6 @@ struct mem_cgroup_reclaim_iter { unsigned int generation; }; -/* - * Bitmap and deferred work of shrinker::id corresponding to memcg-aware - * shrinkers, which have elements charged to this memcg. - */ -struct shrinker_info { - struct rcu_head rcu; - atomic_long_t *nr_deferred; - unsigned long *map; - int map_nr_max; -}; - struct lruvec_stats_percpu { /* Local (CPU and cgroup) state */ long state[NR_VM_NODE_STAT_ITEMS]; diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index 025c8070dd86..eb342994675a 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -5,6 +5,23 @@ #include #include +#define SHRINKER_UNIT_BITS BITS_PER_LONG + +/* + * Bitmap and deferred work of shrinker::id corresponding to memcg-aware + * shrinkers, which have elements charged to the memcg. + */ +struct shrinker_info_unit { + atomic_long_t nr_deferred[SHRINKER_UNIT_BITS]; + DECLARE_BITMAP(map, SHRINKER_UNIT_BITS); +}; + +struct shrinker_info { + struct rcu_head rcu; + int map_nr_max; + struct shrinker_info_unit *unit[]; +}; + /* * This struct is used to pass information from page reclaim to the shrinkers. * We consolidate the values for easier extension later. diff --git a/mm/shrinker.c b/mm/shrinker.c index a27779ed3798..1911c06b8af5 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -12,15 +12,50 @@ DECLARE_RWSEM(shrinker_rwsem); #ifdef CONFIG_MEMCG static int shrinker_nr_max; -/* The shrinker_info is expanded in a batch of BITS_PER_LONG */ -static inline int shrinker_map_size(int nr_items) +static inline int shrinker_unit_size(int nr_items) { - return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); + return (DIV_ROUND_UP(nr_items, SHRINKER_UNIT_BITS) * sizeof(struct shrinker_info_unit *)); } -static inline int shrinker_defer_size(int nr_items) +static inline void shrinker_unit_free(struct shrinker_info *info, int start) { - return (round_up(nr_items, BITS_PER_LONG) * sizeof(atomic_long_t)); + struct shrinker_info_unit **unit; + int nr, i; + + if (!info) + return; + + unit = info->unit; + nr = DIV_ROUND_UP(info->map_nr_max, SHRINKER_UNIT_BITS); + + for (i = start; i < nr; i++) { + if (!unit[i]) + break; + + kvfree(unit[i]); + unit[i] = NULL; + } +} + +static inline int shrinker_unit_alloc(struct shrinker_info *new, + struct shrinker_info *old, int nid) +{ + struct shrinker_info_unit *unit; + int nr = DIV_ROUND_UP(new->map_nr_max, SHRINKER_UNIT_BITS); + int start = old ? DIV_ROUND_UP(old->map_nr_max, SHRINKER_UNIT_BITS) : 0; + int i; + + for (i = start; i < nr; i++) { + unit = kvzalloc_node(sizeof(*unit), GFP_KERNEL, nid); + if (!unit) { + shrinker_unit_free(new, start); + return -ENOMEM; + } + + new->unit[i] = unit; + } + + return 0; } void free_shrinker_info(struct mem_cgroup *memcg) @@ -32,6 +67,7 @@ void free_shrinker_info(struct mem_cgroup *memcg) for_each_node(nid) { pn = memcg->nodeinfo[nid]; info = rcu_dereference_protected(pn->shrinker_info, true); + shrinker_unit_free(info, 0); kvfree(info); rcu_assign_pointer(pn->shrinker_info, NULL); } @@ -40,28 +76,27 @@ void free_shrinker_info(struct mem_cgroup *memcg) int alloc_shrinker_info(struct mem_cgroup *memcg) { struct shrinker_info *info; - int nid, size, ret = 0; - int map_size, defer_size = 0; + int nid, ret = 0; + int array_size = 0; down_write(&shrinker_rwsem); - map_size = shrinker_map_size(shrinker_nr_max); - defer_size = shrinker_defer_size(shrinker_nr_max); - size = map_size + defer_size; + array_size = shrinker_unit_size(shrinker_nr_max); for_each_node(nid) { - info = kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); - if (!info) { - free_shrinker_info(memcg); - ret = -ENOMEM; - break; - } - info->nr_deferred = (atomic_long_t *)(info + 1); - info->map = (void *)info->nr_deferred + defer_size; + info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); + if (!info) + goto err; info->map_nr_max = shrinker_nr_max; + if (shrinker_unit_alloc(info, NULL, nid)) + goto err; rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); } up_write(&shrinker_rwsem); return ret; + +err: + free_shrinker_info(memcg); + return -ENOMEM; } static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, @@ -71,15 +106,12 @@ static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, lockdep_is_held(&shrinker_rwsem)); } -static int expand_one_shrinker_info(struct mem_cgroup *memcg, - int map_size, int defer_size, - int old_map_size, int old_defer_size, - int new_nr_max) +static int expand_one_shrinker_info(struct mem_cgroup *memcg, int new_size, + int old_size, int new_nr_max) { struct shrinker_info *new, *old; struct mem_cgroup_per_node *pn; int nid; - int size = map_size + defer_size; for_each_node(nid) { pn = memcg->nodeinfo[nid]; @@ -92,21 +124,18 @@ static int expand_one_shrinker_info(struct mem_cgroup *memcg, if (new_nr_max <= old->map_nr_max) continue; - new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); + new = kvmalloc_node(sizeof(*new) + new_size, GFP_KERNEL, nid); if (!new) return -ENOMEM; - new->nr_deferred = (atomic_long_t *)(new + 1); - new->map = (void *)new->nr_deferred + defer_size; new->map_nr_max = new_nr_max; - /* map: set all old bits, clear all new bits */ - memset(new->map, (int)0xff, old_map_size); - memset((void *)new->map + old_map_size, 0, map_size - old_map_size); - /* nr_deferred: copy old values, clear all new values */ - memcpy(new->nr_deferred, old->nr_deferred, old_defer_size); - memset((void *)new->nr_deferred + old_defer_size, 0, - defer_size - old_defer_size); + /* copy old values, allocate all new values */ + memcpy(new->unit, old->unit, old_size); + if (shrinker_unit_alloc(new, old, nid)) { + kvfree(new); + return -ENOMEM; + } rcu_assign_pointer(pn->shrinker_info, new); kvfree_rcu(old, rcu); @@ -118,9 +147,8 @@ static int expand_one_shrinker_info(struct mem_cgroup *memcg, static int expand_shrinker_info(int new_id) { int ret = 0; - int new_nr_max = round_up(new_id + 1, BITS_PER_LONG); - int map_size, defer_size = 0; - int old_map_size, old_defer_size = 0; + int new_nr_max = round_up(new_id + 1, SHRINKER_UNIT_BITS); + int new_size, old_size = 0; struct mem_cgroup *memcg; if (!root_mem_cgroup) @@ -128,15 +156,12 @@ static int expand_shrinker_info(int new_id) lockdep_assert_held(&shrinker_rwsem); - map_size = shrinker_map_size(new_nr_max); - defer_size = shrinker_defer_size(new_nr_max); - old_map_size = shrinker_map_size(shrinker_nr_max); - old_defer_size = shrinker_defer_size(shrinker_nr_max); + new_size = shrinker_unit_size(new_nr_max); + old_size = shrinker_unit_size(shrinker_nr_max); memcg = mem_cgroup_iter(NULL, NULL, NULL); do { - ret = expand_one_shrinker_info(memcg, map_size, defer_size, - old_map_size, old_defer_size, + ret = expand_one_shrinker_info(memcg, new_size, old_size, new_nr_max); if (ret) { mem_cgroup_iter_break(NULL, memcg); @@ -150,17 +175,34 @@ static int expand_shrinker_info(int new_id) return ret; } +static inline int shriner_id_to_index(int shrinker_id) +{ + return shrinker_id / SHRINKER_UNIT_BITS; +} + +static inline int shriner_id_to_offset(int shrinker_id) +{ + return shrinker_id % SHRINKER_UNIT_BITS; +} + +static inline int calc_shrinker_id(int index, int offset) +{ + return index * SHRINKER_UNIT_BITS + offset; +} + void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) { if (shrinker_id >= 0 && memcg && !mem_cgroup_is_root(memcg)) { struct shrinker_info *info; + struct shrinker_info_unit *unit; rcu_read_lock(); info = rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); + unit = info->unit[shriner_id_to_index(shrinker_id)]; if (!WARN_ON_ONCE(shrinker_id >= info->map_nr_max)) { /* Pairs with smp mb in shrink_slab() */ smp_mb__before_atomic(); - set_bit(shrinker_id, info->map); + set_bit(shriner_id_to_offset(shrinker_id), unit->map); } rcu_read_unlock(); } @@ -209,26 +251,31 @@ static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, struct mem_cgroup *memcg) { struct shrinker_info *info; + struct shrinker_info_unit *unit; info = shrinker_info_protected(memcg, nid); - return atomic_long_xchg(&info->nr_deferred[shrinker->id], 0); + unit = info->unit[shriner_id_to_index(shrinker->id)]; + return atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); } static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, struct mem_cgroup *memcg) { struct shrinker_info *info; + struct shrinker_info_unit *unit; info = shrinker_info_protected(memcg, nid); - return atomic_long_add_return(nr, &info->nr_deferred[shrinker->id]); + unit = info->unit[shriner_id_to_index(shrinker->id)]; + return atomic_long_add_return(nr, &unit->nr_deferred[shriner_id_to_offset(shrinker->id)]); } void reparent_shrinker_deferred(struct mem_cgroup *memcg) { - int i, nid; + int nid, index, offset; long nr; struct mem_cgroup *parent; struct shrinker_info *child_info, *parent_info; + struct shrinker_info_unit *child_unit, *parent_unit; parent = parent_mem_cgroup(memcg); if (!parent) @@ -239,9 +286,13 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) for_each_node(nid) { child_info = shrinker_info_protected(memcg, nid); parent_info = shrinker_info_protected(parent, nid); - for (i = 0; i < child_info->map_nr_max; i++) { - nr = atomic_long_read(&child_info->nr_deferred[i]); - atomic_long_add(nr, &parent_info->nr_deferred[i]); + for (index = 0; index < shriner_id_to_index(child_info->map_nr_max); index++) { + child_unit = child_info->unit[index]; + parent_unit = parent_info->unit[index]; + for (offset = 0; offset < SHRINKER_UNIT_BITS; offset++) { + nr = atomic_long_read(&child_unit->nr_deferred[offset]); + atomic_long_add(nr, &parent_unit->nr_deferred[offset]); + } } } up_read(&shrinker_rwsem); @@ -407,7 +458,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, { struct shrinker_info *info; unsigned long ret, freed = 0; - int i; + int offset, index = 0; if (!mem_cgroup_online(memcg)) return 0; @@ -419,56 +470,63 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, if (unlikely(!info)) goto unlock; - for_each_set_bit(i, info->map, info->map_nr_max) { - struct shrink_control sc = { - .gfp_mask = gfp_mask, - .nid = nid, - .memcg = memcg, - }; - struct shrinker *shrinker; + for (; index < shriner_id_to_index(info->map_nr_max); index++) { + struct shrinker_info_unit *unit; - shrinker = idr_find(&shrinker_idr, i); - if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { - if (!shrinker) - clear_bit(i, info->map); - continue; - } + unit = info->unit[index]; - /* Call non-slab shrinkers even though kmem is disabled */ - if (!memcg_kmem_online() && - !(shrinker->flags & SHRINKER_NONSLAB)) - continue; + for_each_set_bit(offset, unit->map, SHRINKER_UNIT_BITS) { + struct shrink_control sc = { + .gfp_mask = gfp_mask, + .nid = nid, + .memcg = memcg, + }; + struct shrinker *shrinker; + int shrinker_id = calc_shrinker_id(index, offset); - ret = do_shrink_slab(&sc, shrinker, priority); - if (ret == SHRINK_EMPTY) { - clear_bit(i, info->map); - /* - * After the shrinker reported that it had no objects to - * free, but before we cleared the corresponding bit in - * the memcg shrinker map, a new object might have been - * added. To make sure, we have the bit set in this - * case, we invoke the shrinker one more time and reset - * the bit if it reports that it is not empty anymore. - * The memory barrier here pairs with the barrier in - * set_shrinker_bit(): - * - * list_lru_add() shrink_slab_memcg() - * list_add_tail() clear_bit() - * - * set_bit() do_shrink_slab() - */ - smp_mb__after_atomic(); - ret = do_shrink_slab(&sc, shrinker, priority); - if (ret == SHRINK_EMPTY) - ret = 0; - else - set_shrinker_bit(memcg, nid, i); - } - freed += ret; + shrinker = idr_find(&shrinker_idr, shrinker_id); + if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { + if (!shrinker) + clear_bit(offset, unit->map); + continue; + } - if (rwsem_is_contended(&shrinker_rwsem)) { - freed = freed ? : 1; - break; + /* Call non-slab shrinkers even though kmem is disabled */ + if (!memcg_kmem_online() && + !(shrinker->flags & SHRINKER_NONSLAB)) + continue; + + ret = do_shrink_slab(&sc, shrinker, priority); + if (ret == SHRINK_EMPTY) { + clear_bit(offset, unit->map); + /* + * After the shrinker reported that it had no objects to + * free, but before we cleared the corresponding bit in + * the memcg shrinker map, a new object might have been + * added. To make sure, we have the bit set in this + * case, we invoke the shrinker one more time and reset + * the bit if it reports that it is not empty anymore. + * The memory barrier here pairs with the barrier in + * set_shrinker_bit(): + * + * list_lru_add() shrink_slab_memcg() + * list_add_tail() clear_bit() + * + * set_bit() do_shrink_slab() + */ + smp_mb__after_atomic(); + ret = do_shrink_slab(&sc, shrinker, priority); + if (ret == SHRINK_EMPTY) + ret = 0; + else + set_shrinker_bit(memcg, nid, shrinker_id); + } + freed += ret; + + if (rwsem_is_contended(&shrinker_rwsem)) { + freed = freed ? : 1; + goto unlock; + } } } unlock: -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:28:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:28:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578250.905681 (Exim 4.92) (envelope-from ) id 1qSyPE-0004xg-5Y; Mon, 07 Aug 2023 11:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578250.905681; Mon, 07 Aug 2023 11:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyPE-0004xS-2e; Mon, 07 Aug 2023 11:28:12 +0000 Received: by outflank-mailman (input) for mailman id 578250; Mon, 07 Aug 2023 11:28:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyF3-0006s9-6W for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:17:41 +0000 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [2607:f8b0:4864:20::d30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04ddda3e-3514-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:17:39 +0200 (CEST) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-790b9d7d643so44590439f.1 for ; Mon, 07 Aug 2023 04:17:39 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:17:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04ddda3e-3514-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407059; x=1692011859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f+7Rjo519K3FhaZ9jqPWNUITMom2L2BqSXFVMuCYJXE=; b=ip0wYuQW2+/exFbWgV8xiqSMo5oTQ+OAdV6N1Ar0LEuRT0eIq620KDbMvERQspVuIX AL+wevZXKdon9YRPQjclhoX9H3SrxByFFe9jR5690ffz3lESe4Q0ZFhT9ousgzw0xt/w 5RRxxYEFUQ/KP/U5y/hPXXWHBw2c8mi1xHmKIZ7mZeQKJVTuYBj/qteoNFG9SyZ1tjUE RbAUg65PVJJ+WhDtWwqZYb434jDUE36PynN0DkYIbM09s/1BNwwPxkk2HM9wFLeNzyaL lqpAqgXw+Mhtz5SgHNy0c1hVzxk4Y6rOc9m8zwrbUN+lDejRoW7+lKGMq2jSF6Ub2+cH D5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407059; x=1692011859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f+7Rjo519K3FhaZ9jqPWNUITMom2L2BqSXFVMuCYJXE=; b=IYFh/VSQ6/cidi+jf0nhzcTQeI9y1xQJfbAW9BcAUDcSOkIdtobxG0CfFsHy1kJXHr 3eMZfXoQtKHOrYeZlWLYIxG++ZNTVvcCct+4ueAqx5KRjo7Lb/ZQ+c4KmVHorodkZHRH 2/imh+ld2G+k90TuXvxLiM2GkPyhcKrUv77O5MFlwTfIfgvv1wT1Ee9bYe9OqAmm51tK q8JqhBrlGxJn2UeD2gy2P6vEQNR2MTgSKlsk3OzTQeCZI6OlBYPLbAoIS6YBHeG+KCp+ ZcmUQQ5ESptvvSlJGh6duNvAGGY6anO8mwECMc15CcV0EAbPO6sA8dWtcjHg9yTVn4X0 /2Ww== X-Gm-Message-State: ABy/qLbG5FbxkgtHmmPOgWlvKkNjH7lETMXfttqTSQF/XSbIZYfyulWc iqb52F/EXWZX57kIDnntw3MehQ== X-Google-Smtp-Source: APBJJlEqWtJMEzUOeETqs91YS6OhZnccr6gvE839NK54utINPmY3rqSAbE5saT2wFNMSrRFNpkUXNA== X-Received: by 2002:a05:6e02:8ef:b0:349:1d60:7250 with SMTP id n15-20020a056e0208ef00b003491d607250mr23020165ilt.0.1691407058833; Mon, 07 Aug 2023 04:17:38 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Chuck Lever , Jeff Layton Subject: [PATCH v4 36/48] nfsd: dynamically allocate the nfsd-reply shrinker Date: Mon, 7 Aug 2023 19:09:24 +0800 Message-Id: <20230807110936.21819-37-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the nfsd-reply shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct nfsd_net. Signed-off-by: Qi Zheng Acked-by: Chuck Lever Acked-by: Jeff Layton --- fs/nfsd/netns.h | 2 +- fs/nfsd/nfscache.c | 31 ++++++++++++++++--------------- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h index f669444d5336..ab303a8b77d5 100644 --- a/fs/nfsd/netns.h +++ b/fs/nfsd/netns.h @@ -177,7 +177,7 @@ struct nfsd_net { /* size of cache when we saw the longest hash chain */ unsigned int longest_chain_cachesize; - struct shrinker nfsd_reply_cache_shrinker; + struct shrinker *nfsd_reply_cache_shrinker; /* tracking server-to-server copy mounts */ spinlock_t nfsd_ssc_lock; diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c index 80621a709510..fd56a52aa5fb 100644 --- a/fs/nfsd/nfscache.c +++ b/fs/nfsd/nfscache.c @@ -201,26 +201,29 @@ int nfsd_reply_cache_init(struct nfsd_net *nn) { unsigned int hashsize; unsigned int i; - int status = 0; nn->max_drc_entries = nfsd_cache_size_limit(); atomic_set(&nn->num_drc_entries, 0); hashsize = nfsd_hashsize(nn->max_drc_entries); nn->maskbits = ilog2(hashsize); - nn->nfsd_reply_cache_shrinker.scan_objects = nfsd_reply_cache_scan; - nn->nfsd_reply_cache_shrinker.count_objects = nfsd_reply_cache_count; - nn->nfsd_reply_cache_shrinker.seeks = 1; - status = register_shrinker(&nn->nfsd_reply_cache_shrinker, - "nfsd-reply:%s", nn->nfsd_name); - if (status) - return status; - nn->drc_hashtbl = kvzalloc(array_size(hashsize, sizeof(*nn->drc_hashtbl)), GFP_KERNEL); if (!nn->drc_hashtbl) + return -ENOMEM; + + nn->nfsd_reply_cache_shrinker = shrinker_alloc(0, "nfsd-reply:%s", + nn->nfsd_name); + if (!nn->nfsd_reply_cache_shrinker) goto out_shrinker; + nn->nfsd_reply_cache_shrinker->scan_objects = nfsd_reply_cache_scan; + nn->nfsd_reply_cache_shrinker->count_objects = nfsd_reply_cache_count; + nn->nfsd_reply_cache_shrinker->seeks = 1; + nn->nfsd_reply_cache_shrinker->private_data = nn; + + shrinker_register(nn->nfsd_reply_cache_shrinker); + for (i = 0; i < hashsize; i++) { INIT_LIST_HEAD(&nn->drc_hashtbl[i].lru_head); spin_lock_init(&nn->drc_hashtbl[i].cache_lock); @@ -229,7 +232,7 @@ int nfsd_reply_cache_init(struct nfsd_net *nn) return 0; out_shrinker: - unregister_shrinker(&nn->nfsd_reply_cache_shrinker); + kvfree(nn->drc_hashtbl); printk(KERN_ERR "nfsd: failed to allocate reply cache\n"); return -ENOMEM; } @@ -239,7 +242,7 @@ void nfsd_reply_cache_shutdown(struct nfsd_net *nn) struct nfsd_cacherep *rp; unsigned int i; - unregister_shrinker(&nn->nfsd_reply_cache_shrinker); + shrinker_free(nn->nfsd_reply_cache_shrinker); for (i = 0; i < nn->drc_hashsize; i++) { struct list_head *head = &nn->drc_hashtbl[i].lru_head; @@ -323,8 +326,7 @@ nfsd_prune_bucket_locked(struct nfsd_net *nn, struct nfsd_drc_bucket *b, static unsigned long nfsd_reply_cache_count(struct shrinker *shrink, struct shrink_control *sc) { - struct nfsd_net *nn = container_of(shrink, - struct nfsd_net, nfsd_reply_cache_shrinker); + struct nfsd_net *nn = shrink->private_data; return atomic_read(&nn->num_drc_entries); } @@ -343,8 +345,7 @@ nfsd_reply_cache_count(struct shrinker *shrink, struct shrink_control *sc) static unsigned long nfsd_reply_cache_scan(struct shrinker *shrink, struct shrink_control *sc) { - struct nfsd_net *nn = container_of(shrink, - struct nfsd_net, nfsd_reply_cache_shrinker); + struct nfsd_net *nn = shrink->private_data; unsigned long freed = 0; LIST_HEAD(dispose); unsigned int i; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:28:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:28:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578252.905687 (Exim 4.92) (envelope-from ) id 1qSyPE-00051U-Ho; Mon, 07 Aug 2023 11:28:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578252.905687; Mon, 07 Aug 2023 11:28:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyPE-00051C-Ba; Mon, 07 Aug 2023 11:28:12 +0000 Received: by outflank-mailman (input) for mailman id 578252; Mon, 07 Aug 2023 11:28:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyFr-0006s9-SW for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:18:31 +0000 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [2607:f8b0:4864:20::102d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23680a48-3514-11ee-b27d-6b7b168915f2; Mon, 07 Aug 2023 13:18:31 +0200 (CEST) Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-268663fb09cso631971a91.0 for ; Mon, 07 Aug 2023 04:18:31 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id y13-20020a17090aca8d00b0025be7b69d73sm5861191pjt.12.2023.08.07.04.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 04:18:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23680a48-3514-11ee-b27d-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691407110; x=1692011910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WPvD0YF4yF0E/V3NMttF7YVdRMfLZcl9Qmy2whUD9jE=; b=Zyx6A0EStcsVwcUtmlmHBj8SZuYfnooxelT8QMOYXSAyp4FCbwtu0BbNt7l+P/wBJj 3uKMQnjNsG7kojYgy7WxPCZCDaFjHA3Lkyvej9QWnqL7VojGrNrN9hCPJG63fZ7FoTcQ O0E54wIoRR4I2PoVCGsys6mtB59u+SgFkM0Y7fE6r6JpnE869MmShYbt1p4JfBRV0wIx 7GkvLsY4v9shjjU3+1o+arkgzF82WBo8NnslYR1Cfid19C5zIsiC0KJHBzW/oF+sMC5M xApENfMLb6T9Hu0suHBowRs4nuIaRY0OBNI6a9JHKGzdE5XR+fVrCSwS1eOLCHlN+w0k LsQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691407110; x=1692011910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WPvD0YF4yF0E/V3NMttF7YVdRMfLZcl9Qmy2whUD9jE=; b=EtLJeyewUjyz7bdR7JlKa4eCs4DIU6KDxoj8/owT4Ox2PaMjPt+lIUk2U/o98aJfND ix8HlPjorjlg8lqG8dbiVa/3rpeq1+xt+CTPaUbYO2L3Qq6qykXROUFYuacjaDA8vX9z nwFlACHD1BKAgKMNSB6Ga27j8dWCn1rZLoztE1FtXyE9/actL0vlH3xyA2hwqKKKQCgM vH7OuOQ7Fez8r6oSILkogQcSQfkuWSHY/ZIvJHmPpttrJTNlEFrGKzv819RFxiJjc5Y4 fgPCnhJ5x1bJOYljZn7GsK9snekWO0RvUDdcIoa21S3CWebXc/2BIrjJOCNBxrwv3HE1 vP9Q== X-Gm-Message-State: ABy/qLbv1dlh9SFmbe/oCBTCMO+QfJrPPATKlmBkbvNa7gPEP9F+jM06 qh6rNndfvaMAFrSIPDKfIG+Bxw== X-Google-Smtp-Source: APBJJlFnoOazdp9TvNa1Sdutczsv0h+KjLn+q+TQByEK163E+9f/k1cC7rmChP+7R75WsTDRsF4HxQ== X-Received: by 2002:a17:90a:901:b0:268:3a31:3e4d with SMTP id n1-20020a17090a090100b002683a313e4dmr23078917pjn.2.1691407109946; Mon, 07 Aug 2023 04:18:29 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v4 40/48] zsmalloc: dynamically allocate the mm-zspool shrinker Date: Mon, 7 Aug 2023 19:09:28 +0800 Message-Id: <20230807110936.21819-41-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230807110936.21819-1-zhengqi.arch@bytedance.com> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the mm-zspool shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the struct zs_pool. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- mm/zsmalloc.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index b58f957429f0..1909234bb345 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -229,7 +229,7 @@ struct zs_pool { struct zs_pool_stats stats; /* Compact classes */ - struct shrinker shrinker; + struct shrinker *shrinker; #ifdef CONFIG_ZSMALLOC_STAT struct dentry *stat_dentry; @@ -2086,8 +2086,7 @@ static unsigned long zs_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) { unsigned long pages_freed; - struct zs_pool *pool = container_of(shrinker, struct zs_pool, - shrinker); + struct zs_pool *pool = shrinker->private_data; /* * Compact classes and calculate compaction delta. @@ -2105,8 +2104,7 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker, int i; struct size_class *class; unsigned long pages_to_free = 0; - struct zs_pool *pool = container_of(shrinker, struct zs_pool, - shrinker); + struct zs_pool *pool = shrinker->private_data; for (i = ZS_SIZE_CLASSES - 1; i >= 0; i--) { class = pool->size_class[i]; @@ -2121,18 +2119,24 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker, static void zs_unregister_shrinker(struct zs_pool *pool) { - unregister_shrinker(&pool->shrinker); + shrinker_free(pool->shrinker); } static int zs_register_shrinker(struct zs_pool *pool) { - pool->shrinker.scan_objects = zs_shrinker_scan; - pool->shrinker.count_objects = zs_shrinker_count; - pool->shrinker.batch = 0; - pool->shrinker.seeks = DEFAULT_SEEKS; + pool->shrinker = shrinker_alloc(0, "mm-zspool:%s", pool->name); + if (!pool->shrinker) + return -ENOMEM; + + pool->shrinker->scan_objects = zs_shrinker_scan; + pool->shrinker->count_objects = zs_shrinker_count; + pool->shrinker->batch = 0; + pool->shrinker->seeks = DEFAULT_SEEKS; + pool->shrinker->private_data = pool; - return register_shrinker(&pool->shrinker, "mm-zspool:%s", - pool->name); + shrinker_register(pool->shrinker); + + return 0; } static int calculate_zspage_chain_size(int class_size) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:31:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578273.905700 (Exim 4.92) (envelope-from ) id 1qSySj-0007ld-2f; Mon, 07 Aug 2023 11:31:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578273.905700; Mon, 07 Aug 2023 11:31:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSySi-0007lW-WF; Mon, 07 Aug 2023 11:31:49 +0000 Received: by outflank-mailman (input) for mailman id 578273; Mon, 07 Aug 2023 11:31:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSySh-0007lO-Pd for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:31:47 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc634c14-3515-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 13:31:45 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EF6EB3200805; Mon, 7 Aug 2023 07:31:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 07 Aug 2023 07:31:43 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 07:31:39 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc634c14-3515-11ee-b27e-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691407902; x=1691494302; bh=EQktl1UmnPQWszn8MIvvHFMFVHPf0iSLyrT r85I0YoQ=; b=gJA1d9lmVVFeiMPgC3M3B5lphOg/DRKSgYnM//6j3gqxPH39PIv 2tznLZm1Q10X5OiPgWKslNMQONwpcaBR0KriMTPyWAQHtxQl2qt0SnBQ5nEv4YVn Y5rR0OMpK0cnMWtg1dGH/8i3nVpSNqIjApVYPvsPj4sLqGu0QDd5+H1UsFxLrUlL sMmd283ZlCL9SS4cYeNmtQSwq+vyelIhmWN1zcO43BamgXcs+HgC7PvZsltwmi6Y xIVGNBk/KGZde20rxjnPMGHKLuTlrCkAnbV6tk2BCMmMIuhUPy0cGltSSdPR5wd8 vCA3pXfNWCALJ2SzEqc1teVb0AAvMODZxJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691407902; x=1691494302; bh=EQktl1UmnPQWs zn8MIvvHFMFVHPf0iSLyrTr85I0YoQ=; b=Sn7IUvYWJ1YpoVCYY7jMHDcq/RqMv Ea/hvsvLBD+5aXhNz8KvpvkcTo2LdOHIUEsnGeIwlWuOHg7ysJM14wFIe2muZL4K 5v4hyM3RZMoQPr73izqEt1RTt6febNtPWhojBPAr4E7huv32Oi4mGj4tdRQPe+tI hwCMV6mI9QZF7+SaLi9yOIpQSjlNLAG+8MxCwQhku9YpuDl8+Q/om3DyEHGoel6t 4jhg3Je79Kx8wo0AqTh5O1vw6GJ2fyKnxa3d1BCTf6AzGtuTPRmC7qo9VdtGU3ld avhxtsqtBbATo8IUhySMHCJ84Ga6cRDix3YzJT4QnqWOs66/CgRUHWigA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuihhmohhnucfi rghishgvrhcuoehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh eqnecuggftrfgrthhtvghrnhepueevheegtdefgeefuddvfeduueduffffffejveeugeef udefiedugedugeevudfgnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsihhmohhnsehinhhv ihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail From: Simon Gaiser To: xen-devel@lists.xenproject.org Cc: Simon Gaiser , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [XEN PATCH v3] x86/hpet: Disable legacy replacement mode after IRQ test Date: Mon, 7 Aug 2023 13:31:17 +0200 Message-Id: <20230807113117.1277-1-simon@invisiblethingslab.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As far as I understand the HPET legacy mode is not required after the timer IRQ test. For previous discussion see [1] and [2]. Keeping it enabled prevents reaching deeper C-states on some systems and thereby also S0ix residency. So disable it after the timer IRQ test worked. Note that this code path is only reached when opt_hpet_legacy_replacement < 0, so explicit user choice is still honored. Link: https://lore.kernel.org/xen-devel/cb408368-077d-edb5-b4ad-f80086db48c1@invisiblethingslab.com/ # [1] Link: https://lore.kernel.org/xen-devel/20230718122603.2002-1-simon@invisiblethingslab.com/ # [2] Signed-off-by: Simon Gaiser --- [ Resending v3, now with a unique Message-ID, sorry. ] Changes in v3: - Edit log message and downgrade it to XENLOG_DEBUG. Changes in v2: - Always disable legacy mode after test, not only when ARAT is available. See [3] for reasoning. [3]: https://lore.kernel.org/xen-devel/ac77ecba-6804-1d16-60dc-f184e5d31dcb@invisiblethingslab.com/ --- xen/arch/x86/io_apic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 041233b9b7..b4b4cd5939 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1967,6 +1967,8 @@ static void __init check_timer(void) if ( timer_irq_works() ) { + printk(XENLOG_DEBUG "IRQ test with HPET Legacy Replacement Mode worked - disabling it again\n"); + hpet_disable_legacy_replacement_mode(); local_irq_restore(flags); return; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:35:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578280.905711 (Exim 4.92) (envelope-from ) id 1qSyW1-0008My-HU; Mon, 07 Aug 2023 11:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578280.905711; Mon, 07 Aug 2023 11:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyW1-0008Mr-Dv; Mon, 07 Aug 2023 11:35:13 +0000 Received: by outflank-mailman (input) for mailman id 578280; Mon, 07 Aug 2023 11:35:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyVz-0008Ml-He for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:35:11 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2061b.outbound.protection.outlook.com [2a01:111:f400:7eaf::61b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 757a7637-3516-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:35:07 +0200 (CEST) Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS2PR08MB9342.eurprd08.prod.outlook.com (2603:10a6:20b:599::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 11:35:03 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 11:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 757a7637-3516-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZU0oHg7W/QhaqWt1x+7uBaTNP0dGAbbjnJYD+Tei9qAdy75x1n1Nl1K22CQfEy8js92Q7AK3gq0MAqAUQoc/tY0V7HrKFU7AU9qYWGQEMvJ6g6XP39KitF4Q5vanYyh6oevBWfLvA2EKDZP/faqX3v38oSP+BD1yxbj5BbegKCG+CyqiDqfUeJTzTrI/ZUEV1Nl7mQUAxKgrYgpHKNkjgAMc2CEj0Lmeqp46CS2PsFEkGbLFuEt1DoecIcIxuNWoXhbapbXXpsN3sszPFoFIzOYxmdnIOABoHw5wG7nThu/8jbxJI2twy9c0MlCwql8V8RKr1ZJzm3SitzTaPXyC7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g9Xh2J+G7yaEExzXYEPJ4NEpZIPbtKmtGktwx/+Ubao=; b=SXnuxvq2pGvWXk0dP4pDVhirtr2PSjp4h4WNuGjxei51ezoxMJFx/FVra9umCiOgJBK6ENfTdKvBsu/xZcrxcVx7+UydJeyw91QuG3Lvk/db6KeFYKn94gf7XOCLXUZZiL1+/ccM4q2WTxW0otLE8bjdqLrguAd7Lkf7Y0onWSeONKB2ek56fkAAf0x59LUH4AVZ/5sekS49vVQ5WlCtAZdRNgcVBFQaM6fr4wSAwVOmDeoDdNygVNjYGsyEZIRfWhqBvq6Jb6GxACncpcU/w6mlS8YH19VfUG05TO3b7hasQl2MN57zIVdGJ/inRVOssKPesABQ3mVTI8qdd33Dzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g9Xh2J+G7yaEExzXYEPJ4NEpZIPbtKmtGktwx/+Ubao=; b=DnRaXWeFlciqdWuCJ61a6YdNxdV0lrC0BFdZ9paJcYdotB/AOzTOuzDRbUbpiRAYCqCp2DZWepSneCQcA4iHW10SmYVX2tDRyWJXcnS+Dt0F0BeaHDLp2XOWSt7OCYJjYXbIwpj1GJRlSrSCMZBrWOdAICFnif8eevaYyJ9CSdU= From: Henry Wang To: Ayan Kumar Halder , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Thread-Topic: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Thread-Index: AQHZxCqBtZIUxf7FmUaIEyO8EPs3TK/euu6AgAABikA= Date: Mon, 7 Aug 2023 11:35:03 +0000 Message-ID: References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> In-Reply-To: <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 2732F28F699DCF42ACF7F0FD3714C47A.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS2PR08MB9342:EE_ x-ms-office365-filtering-correlation-id: 8dcce9de-8988-487e-1bb3-08db973a5758 nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +af4QVeV2GtkEuEKrwOwWxSG3wlMuq6k94f0IszX9x88tXrrPsGGTz8sxo7FQMnn9Ced1e7EqUQ1FK9fo9WH2gSNOJH5W3HWapmzlGPg8C+fMOjaZaGB+Wmgyc9QYxNflj9AmnZzdjm8ZXejSEcfGNs8soHsSuGqmNA82kxtvG0RS+KP+B6aFVhku6m40lzxVZFQQrC0dne6hcAi71MVIkkIm8aQ588MHL06ce5UNWHbbbPsndVKDbm59XWkmlC/Drd3sNh/Fggtv/ZHwCdlO6y75KNw/LN5AYYvOmw1SbLfSNPccWI8kQGJV8uc4eevqEkVsGPoYOmM2LMofkTejUtVSDE7HE6nJvZjtPyf50XwxtPjAr2HX/B6JzZnhLp5BhumUqvp387izfsaUvyDbJOVOo2NGQpZRWZB1FLmpFoj0vUQpfdKoOax+ALgUsbmWG+5yNxP18Vj0uK4f5S3ww0/tesTeSMlkmHB9oNQMKfTMi7j5i+QFSVeWlzRHiOmi/1RoD7Um7K+8Yi4kasKclwcAJfV0ax/rLqCXaXfsqR5/yqpQs6WxhKJp+w7J1vS/Y8HrfXS1RGX1XgOJeiZwhYxPIUodWFdORqMin+29qs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(451199021)(186006)(1800799003)(86362001)(41300700001)(52536014)(478600001)(6506007)(8676002)(8936002)(26005)(38100700002)(7696005)(5660300002)(83380400001)(2906002)(110136005)(54906003)(71200400001)(38070700005)(55016003)(316002)(966005)(66556008)(66446008)(122000001)(66476007)(64756008)(76116006)(66946007)(4326008)(9686003)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z09ZampHRk1qWUZ3VzgweEV0K0NFUVNCc0lOQ2xYR29SWkhGb1pFTm1DaXhF?= =?utf-8?B?OSswc2UyU1dyeSswSlNtbkdSbnRBV0Z4UGF1T0I4ejJHQ0p6aFFhelZNdkRr?= =?utf-8?B?SEM4TVBwbzBHSGxFNGc5UnJLOUFpOWVKaG1MQ3p0ZHIvUE5XaFoyUXdtZ25u?= =?utf-8?B?dldtVFZ0Tnh5OE5CVEx0bHhISmQ2dWoxZDhCQUZoRnFJWWxSZmNmN2FSQk1t?= =?utf-8?B?VmthcXpyKzlWOGZUc05IUEovUERodVA5b0s4NG1tWGh4dzVsK3BycGdja2hL?= =?utf-8?B?Y0hubC83cXBaaFNGTWUvVysxM1BXUGp0Z0hXOTZKSER0VU1jRHBhQlBMdzhn?= =?utf-8?B?ajRzWXgwKzVzUVFvMVUrdlpsWXpnM0FCaTM3NFRXMzgwRFV1bytFZy9zb2I4?= =?utf-8?B?eDZieTIraWJTMkt2c0dJK1RXbUZBdllTNEtHRVdDeVBYdkR0SUdqaWJRN0Mx?= =?utf-8?B?aVlnZjNISjIyVzkvb05SdlFOcmpOb1BNTUV5RkE4dEd6UG1CQ2dKK1hVckVC?= =?utf-8?B?Mkt0L2Q3V2Jha2NiZmdDM1kwNkRZSmhjNi9qT3lVK1pzR0RaUzRGNFdRQnls?= =?utf-8?B?SWRRMjlTRmNOaENiaG1rSFVobjhiZ3hrcHBWeHFwWnZMSm1UZXEwV1BqbHNr?= =?utf-8?B?cUgvL2xBS3B0ZGc0UGJKRkEvbjNCQ2tIWWJ1RFE0SG9nY0VoQUJBOXZHdldU?= =?utf-8?B?NUdWdXVudUxvQnlHVmFzWDBMeFltQU5ZaDQvODZBTWxHV1pHSVljNE5wcWRs?= =?utf-8?B?Qit3RGoyajVWZU9QQlJQT2cxY0FyQ0J6U24xZGRTTm1ha2Z1a0lYcXVjY3cx?= =?utf-8?B?VWp0NFNrcEJpekFUendENWFXS3R1UndjYjZUN2tENjFLL2ZodjRoT1g1b3Nr?= =?utf-8?B?M0VqbDlXUXM3ZGhMMmdsaXJhYkZiK0FpK3JkaTE3TWlvQ2t0Qml0VnBwNUtl?= =?utf-8?B?Y3VHRHlpT2IvS3FERXBWMndjMVVYVVRjTlVmRzhIZkc5SUpHS2psaitiQzN4?= =?utf-8?B?S3UzZVk4TjVlbEZtVHM0a3drL1ErNXUyZ0tIQmFjTkprNk41Y05vd2gwS2pE?= =?utf-8?B?dU9vOXh1d2RZYjQ5Yyt1MHBMLzIxLzNybk5JdDR6YmkvNWJCR2cyK2prK1JS?= =?utf-8?B?V3RzNVJnZ2xDRnJYZDJoZHJaQmovTEFmYUlOZXA4aGVtMy9zUmRiQVBYblFk?= =?utf-8?B?cWNUN2ZxVEpUSUE3a1I4WjNHRWhwT0Y4bVNVaGZ4MVMxdk9xeEdRUEJ0V0p0?= =?utf-8?B?NllKSDl3M2FNWEJPWTNCV2pFTStlbFNYYUJ2UzlhM3J3enRiV3JjQnczbzhw?= =?utf-8?B?cXlUYW8yMG9CaUQ2OVV4eDBYd2s3TkNnaGMzbTdpK3lDRlUxRGJ1T29Dc1VI?= =?utf-8?B?aGxsc0RPVytFTnRDVktESkRUU3NqTWtzRW9nMXJKRVlGckpmemFMUWlCNUtp?= =?utf-8?B?R1hEcHdBeURLZHVtcDlobWVEcjA1dnZDRHllOEtFQzhIN2JzR2tBOUFDRTcy?= =?utf-8?B?bkpYZU5JVnFpVXk1WTZNeVpKMVViZDBDNHhoZi9lbGwwVE1wVGkwYzBFeTZi?= =?utf-8?B?ZEd4eWVyZmExRkdOYkJ5Nmd2N2RoUnA0WUZ5aCtLYW1UMi9rT0ovYlVJQklR?= =?utf-8?B?SjRZeWN0YmRhN3ZHQVJsTFFaUkh0SVRySGZVUlRCa2dHallsTGdrSm1DQWwx?= =?utf-8?B?cmN6emQxNEFBVHo5aC84ZCt3Sm5YN291Y2pEelAwRlBLdlVES2RCZ2VNdmVG?= =?utf-8?B?dFVSTW1qaU5pV2FlYTY2YzFYTFo5dzZKdnI5Qy9KbWkzTWVoK0ZYdnE5eG5D?= =?utf-8?B?bWRhVFZqZU1ZVnBqVEZadUR4UElXVVBTZFp5L0NMMkdHUGZYOHZGZkNPTkxJ?= =?utf-8?B?VWxlbmoxVmZPVkVnZ1lvUW9JQ0tUMDJZNkpqOU9mWlpUTFJDaW01a091VHY3?= =?utf-8?B?TkVIQ05QbTJFV2NLRFE3dGs2SFpwV1JZK2oySEltZEg1Qnh0UjhyMTV6dlV1?= =?utf-8?B?aFBoUWhwbUMwOTNkMEloZmh3R1A3bVYrOE42RXpMZmtWL1RwUWxhbTI4U0Zh?= =?utf-8?B?eC9kTDZ2eHBjamZWWVZJbkdieDF3bzRlWnM3enBYQnR1RzlqcjRaOTkzRUVJ?= =?utf-8?Q?Xpxu35DYNIlGcwt9PlDc9pOJn?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR08MB7991.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dcce9de-8988-487e-1bb3-08db973a5758 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 11:35:03.2116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AxOg62nQBz2WvbUn9Qc1gjJbXBGoDJfWPJWC2UWS/WuF0DqCO/Zqhdgjm6g+OBm9ikArwkDhT7sFvQ8gP3RrpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9342 SGkgQXlhbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLSANCj4gSGkgSGVucnksDQo+ IA0KPiA+IEF0IHRoZSBtb21lbnQsIG9uIE1NVSBzeXN0ZW0sIGVuYWJsZV9tbXUoKSB3aWxsIHJl dHVybiB0byBhbg0KPiA+IGFkZHJlc3MgaW4gdGhlIDE6MSBtYXBwaW5nLCB0aGVuIGVhY2ggcGF0 aCBpcyByZXNwb25zaWJsZSB0bw0KPiA+IHN3aXRjaCB0byB2aXJ0dWFsIHJ1bnRpbWUgbWFwcGlu Zy4gVGhlbiByZW1vdmVfaWRlbnRpdHlfbWFwcGluZygpDQo+ID4gaXMgY2FsbGVkIG9uIHRoZSBi b290IENQVSB0byByZW1vdmUgYWxsIDE6MSBtYXBwaW5nLg0KPiA+DQo+ID4gU2luY2UgcmVtb3Zl X2lkZW50aXR5X21hcHBpbmcoKSBpcyBub3QgbmVjZXNzYXJ5IG9uIE5vbi1NTVUgc3lzdGVtLA0K PiA+IGFuZCB3ZSBhbHNvIGF2b2lkIGNyZWF0aW5nIGVtcHR5IGZ1bmN0aW9uIGZvciBOb24tTU1V IHN5c3RlbSwgdHJ5aW5nDQo+ID4gdG8ga2VlcCBvbmx5IG9uZSBjb2RlZmxvdyBpbiBhcm02NC9o ZWFkLlMsIHdlIG1vdmUgcGF0aCBzd2l0Y2ggYW5kDQo+ID4gcmVtb3ZlX2lkZW50aXR5X21hcHBp bmcoKSBpbiBlbmFibGVfbW11KCkgb24gTU1VIHN5c3RlbS4NCj4gPg0KPiA+IEFzIHRoZSByZW1v dmVfaWRlbnRpdHlfbWFwcGluZyBzaG91bGQgb25seSBiZSBjYWxsZWQgZm9yIHRoZSBib290DQo+ ID4gQ1BVIG9ubHksIHNvIHdlIGludHJvZHVjZSBlbmFibGVfYm9vdF9jcHVfbW0oKSBmb3IgYm9v dCBDUFUgYW5kDQo+ID4gZW5hYmxlX3NlY29uZGFyeV9jcHVfbW0oKSBmb3Igc2Vjb25kYXJ5IENQ VXMgaW4gdGhpcyBwYXRjaC4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWku Y2hlbkBhcm0uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVu Z0Bhcm0uY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt LmNvbT4NCj4gDQo+IFdpdGggdHdvIGNvbW1lbnRzDQo+IA0KPiBSZXZpZXdlZC1ieTogQXlhbiBL dW1hciBIYWxkZXIgPGF5YW4ua3VtYXIuaGFsZGVyQGFtZC5jb20+DQo+IA0KPiBUZXN0ZWQtYnk6 IEF5YW4gS3VtYXIgSGFsZGVyIDxheWFuLmt1bWFyLmhhbGRlckBhbWQuY29tPg0KDQpUaGFua3Ms IGFuZC4uLg0KDQo+IA0KPiA+ICsvKg0KPiA+ICsgKiBFbmFibGUgbW0gKHR1cm4gb24gdGhlIGRh dGEgY2FjaGUgYW5kIHRoZSBNTVUpIGZvciBzZWNvbmRhcnkgQ1BVcy4NCj4gPiArICogVGhlIGZ1 bmN0aW9uIHdpbGwgcmV0dXJuIHRvIHRoZSB2aXJ0dWFsIGFkZHJlc3MgcHJvdmlkZWQgaW4gTFIg KGUuZy4gdGhlDQo+ID4gKyAqIHJ1bnRpbWUgbWFwcGluZykuDQo+ID4gKyAqDQo+ID4gKyAqIElu cHV0czoNCj4gPiArICogICBsciA6IFZpcnR1YWwgYWRkcmVzcyB0byByZXR1cm4gdG8uDQo+ID4g KyAqDQo+ID4gKyAqIENsb2JiZXJzIHgwIC0geDUNCj4gPiArICovDQo+ID4gK2VuYWJsZV9zZWNv bmRhcnlfY3B1X21tOg0KPiBJIHdpbGwgcHJlZmVyICJlbmFibGVfc2Vjb25kYXJ5X2NwdV9tbXUi IGFzIGl0IGlzIE1NVSBzcGVjaWZpYy4gQW5kIC4uLg0KDQouLi5hY3R1YWxseSB0aGlzIGFzIHdl bGwgYXMuLi4NCg0KPiA+ICsvKg0KPiA+ICsgKiBFbmFibGUgbW0gKHR1cm4gb24gdGhlIGRhdGEg Y2FjaGUgYW5kIHRoZSBNTVUpIGZvciB0aGUgYm9vdCBDUFUuDQo+ID4gKyAqIFRoZSBmdW5jdGlv biB3aWxsIHJldHVybiB0byB0aGUgdmlydHVhbCBhZGRyZXNzIHByb3ZpZGVkIGluIExSIChlLmcu IHRoZQ0KPiA+ICsgKiBydW50aW1lIG1hcHBpbmcpLg0KPiA+ICsgKg0KPiA+ICsgKiBJbnB1dHM6 DQo+ID4gKyAqICAgbHIgOiBWaXJ0dWFsIGFkZHJlc3MgdG8gcmV0dXJuIHRvLg0KPiA+ICsgKg0K PiA+ICsgKiBDbG9iYmVycyB4MCAtIHg1DQo+ID4gKyAqLw0KPiA+ICtlbmFibGVfYm9vdF9jcHVf bW06DQo+IA0KPiBwcmVmZXIgImVuYWJsZV9ib290X2NwdV9tbXUiIGFzIGl0IGlzIE1NVSBzcGVj aWZpYyBhcyB3ZWxsLg0KDQouLi50aGlzLCBhcmUgdGhlIG5hbWUgc3VnZ2VzdGVkIGJ5IEp1bGll biBpbiBbMV0sIHNvIHByb2JhYmx5IEkgd2lsbCBzdGljaw0KdG8gdGhlc2UgbmFtZXMsIHVubGVz cyBoZSB3b3VsZCBwcmVmZXIgdGhlIHByb3Bvc2VkIG5hbWVzLiBJIHdvdWxkDQpwZXJzb25hbGx5 IHByZWZlciB0aGUgbmFtZXMgdGhhdCBKdWxpZW4gc3VnZ2VzdGVkIHRvbywgYmVjYXVzZSBmcm9t DQp0aGUgY29tbWVudHMgYWJvdmUgdGhlc2UgdHdvIGZ1bmN0aW9ucywgdGhlc2UgZnVuY3Rpb25z IG5vdCBvbmx5DQplbmFibGUgdGhlIE1NVSwgYnV0IGFsc28gdHVybiBvbiB0aGUgZC1jYWNoZSwg aGVuY2UgYSBtb3JlIGdlbmVyaWMNCm5hbWUgKHVzaW5nICJtbSIpLCBpcyBtb3JlIGFwcHJvcHJp YXRlIGhlcmUgSSBndWVzcy4NCg0KWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZl bC9jMTBiYzI1NC1hZDc5LWRhZGEtZDVmYi05ZWU2MTk5MzRmZmJAeGVuLm9yZy8NCg0KS2luZCBy ZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gLSBBeWFuDQo= From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:39:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:39:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578296.905721 (Exim 4.92) (envelope-from ) id 1qSyaB-0000qC-8F; Mon, 07 Aug 2023 11:39:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578296.905721; Mon, 07 Aug 2023 11:39:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyaB-0000q5-57; Mon, 07 Aug 2023 11:39:31 +0000 Received: by outflank-mailman (input) for mailman id 578296; Mon, 07 Aug 2023 11:39:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyPu-00024C-KR for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:28:54 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94f2039a-3515-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:28:52 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id BA0DC3200948; Mon, 7 Aug 2023 07:28:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 07 Aug 2023 07:28:49 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 07:28:44 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94f2039a-3515-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691407728; x=1691494128; bh=V1p5A9ACqsnl2tgeoDxtsmzUi6y8s5WkawP sN/O3EGU=; b=pRpj3enyACb/haiSdwNnxdJ+CfbcUP2+lhuc2IGeMNLynwF0DPc SGtCvuZpUEST2aW4JF6Q+/aP+ol6dwSdKcV3OddWPfBKvWsgYl16oY4zxLEUwUec Pcs654y3N21UOJzNnTUUHEy2oRC6MTO6m7JpK/OOeH0vk5lbLC2o+roSVq7VmnUK jtTxJD309QKNk1CvJzKfe7ksl1oK5mixaLbFMCkL6Ulq+tGpq47ncz+YehE+qzR+ YOQtqNafgFKKc8PHoZ4kKKNQVCa0UF+x7hL7EqvXdbs9id/hyLiy6jKX+jrfJLuK PQEJ3EGVS75PF/p5saqjFbhSfJr14JIFXIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691407728; x=1691494128; bh=V1p5A9ACqsnl2 tgeoDxtsmzUi6y8s5WkawPsN/O3EGU=; b=naXg0GIwmibCTbs1OcPrEs16htIJc kY0qVYxANqvGVM3+Mi9AbdDJDu1ojzOEo8d+rBtfxHxoerJxhdWYSrnzNrTTVk36 FDjUi3lWaSfGceEQqwZ8axIEzXZw5pca/w3LsabJjYa9EA6mR4tafPgRk9Y8JXGX pkm9hPKohSezAseRAMCFiKFiC6jFod9dorqd78GAZs5mnsiLuaBVNBKZe7fpTUFB zNiahTPagtgSKOM2AicojV8oHwgmBq+ZJglhsx/pbCQvQskSdP0ECJ0Ofm2RJP6W HwSAC4IJKMi4Ypvs0226t7PS2w8U6xHi1lUbcPspwyDrbvcWy37/FGCsg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuihhmohhnucfi rghishgvrhcuoehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh eqnecuggftrfgrthhtvghrnhepueevheegtdefgeefuddvfeduueduffffffejveeugeef udefiedugedugeevudfgnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsihhmohhnsehinhhv ihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail From: Simon Gaiser To: xen-devel@lists.xenproject.org Cc: Simon Gaiser , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Subject: [XEN PATCH v3] x86/hpet: Disable legacy replacement mode after IRQ test Date: Mon, 7 Aug 2023 13:28:22 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As far as I understand the HPET legacy mode is not required after the timer IRQ test. For previous discussion see [1] and [2]. Keeping it enabled prevents reaching deeper C-states on some systems and thereby also S0ix residency. So disable it after the timer IRQ test worked. Note that this code path is only reached when opt_hpet_legacy_replacement < 0, so explicit user choice is still honored. Link: https://lore.kernel.org/xen-devel/cb408368-077d-edb5-b4ad-f80086db48c1@invisiblethingslab.com/ # [1] Link: https://lore.kernel.org/xen-devel/20230718122603.2002-1-simon@invisiblethingslab.com/ # [2] Signed-off-by: Simon Gaiser --- Changes in v3: - Edit log message and downgrade it to XENLOG_DEBUG. Changes in v2: - Always disable legacy mode after test, not only when ARAT is available. See [3] for reasoning. [3]: https://lore.kernel.org/xen-devel/ac77ecba-6804-1d16-60dc-f184e5d31dcb@invisiblethingslab.com/ --- xen/arch/x86/io_apic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 041233b9b7..b4b4cd5939 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1967,6 +1967,8 @@ static void __init check_timer(void) if ( timer_irq_works() ) { + printk(XENLOG_DEBUG "IRQ test with HPET Legacy Replacement Mode worked - disabling it again\n"); + hpet_disable_legacy_replacement_mode(); local_irq_restore(flags); return; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:43:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:43:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578303.905732 (Exim 4.92) (envelope-from ) id 1qSyeB-0002Gm-Py; Mon, 07 Aug 2023 11:43:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578303.905732; Mon, 07 Aug 2023 11:43:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyeB-0002Gf-LL; Mon, 07 Aug 2023 11:43:39 +0000 Received: by outflank-mailman (input) for mailman id 578303; Mon, 07 Aug 2023 11:43:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyeA-0002GZ-2B for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:43:38 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on20601.outbound.protection.outlook.com [2a01:111:f400:7ea9::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4ed8060-3517-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 13:43:36 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by DS0PR12MB9424.namprd12.prod.outlook.com (2603:10b6:8:1b4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 11:43:29 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 11:43:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4ed8060-3517-11ee-b27e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHJexwoFqvydswbM/fv8aCGmg1tRTiWwi8RanMUf3lrsfd77ZbLqL06nDI4ZDB2cKKjJ3rs/76PU7JEH5i9RwNzoymE7OxuR3b+kq5qstMHCH+qgr29cOkfYIEkeI5jStKmdE5V0FB7PUCwDwycX/m1Ot3SnBXBZ0f6jWBRGxI2d6EcPh1vCv78fWd4o4o82yAgY1fmHtI6EW2GJ0gFYxqibSqRCDNDKPlJt71eTs2wSbmnwQ2CQlpJWVygYrtWG4qyCm9v6UuxHm/kHkmsJ9D3fFnEsMxSXunPyLoljANWHz5e6w36CUWiYdzHvKlHodCZzmIZVPBZ4QyO/MLwmFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bw1okKu3nBH6WxItlWol5D5VupEkzRThDOrgmot4L/4=; b=KV6Fvst94EaN8d1SeRnxEThrsFMKhEPku6R8neJGBvzR0V5AcrvrecgGWfxICl2AYTE50Sl+mgmZdPXokujweS8/01BBIoWo5VClg98IMRyXPA3HaTKVGOobKDTLwr7ckSMiGb+oHGCyXQ7FhJR7/zgTm/IbTCAVHq1BZGg1NuLUviEoYFQeLI7s2RnPzxWPtpYMWPjC0wgEynn1Awk91UrQs+2bPh0vfoYH8dSkNfMIcc4TP/elj++mUktLtj8Kpczj/5NCuFTKOx/U3Q3UlR69ybypnqnfw/vlusXPZmlLXaixhiJvkelu28VY4Oo9BJNG090aPdl95uxu03K+lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bw1okKu3nBH6WxItlWol5D5VupEkzRThDOrgmot4L/4=; b=5ObRrhAf8uOdKqXWtKzBbU3ua+KU7ehfOPGH4QIUN/AIFSC6MKFH+TNhrPSkfiex2u9WanH2JeOEFXWZt+88i7MkGc+354S28ric0kti8cs3zANfCtqrKKTADWcZ2u5p8cuJfUCsgFzhVhDgWZ9LbKqXjrI0xoOPiAqj4kBpm9g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <1366a5b1-4bf4-20d6-73a7-ad1735ab8c10@amd.com> Date: Mon, 7 Aug 2023 12:43:24 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> From: Ayan Kumar Halder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::21) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|DS0PR12MB9424:EE_ X-MS-Office365-Filtering-Correlation-Id: 85a018b9-fdc3-48e1-6d7a-08db973b862a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A4viv9/dyX6zzMXaDwL9gJOrghBEY7P+fBa0uEpBhqNsmiuye38U+hL5/eGbbLghzOwe8+AwqAtqmEHEO9vy9AUP4Nfcv9kDPIr1R2wyAYSNEv49CwuKr6D+HAJWJDA8Y6FSoxG+AvJqQPIbBs9gp0rHu8r3nzK+zoZ4uTdrT9Y/ZLAKNU+dHpvnub++FsOfVTzS9zWXR06LplMUflt0pHVtqVjq5x5rT2ny8JmOe0LUEODv93WfjLYXiAh900ASuWwkYFlAQ+MO2/mpDwxbkx6u8bNIhca0eR59GpD9nNKrcCgbulT1D6SyoNVgyqvcXweAwGDJKKLU9xjsXVv2pD8l9ZnOhnasexQxaX+MGX40Q4/0IEfPbCpOFTOQdzC1wQZxymEB02NpdYMHwFr/WyGWR5UvK2VBZqUkCLGla2RvUJnhD44Ki8vsFO3RjcaiDrXj2eGr4Us43Qflg9DWRbjEXtgFJtPQhedcMwZe57zp2CiHylylzHWE5mmhaAvQoa65ZcExi/glfpMWxoL7kQ1RaV2V153+cwn2oICblnIieTbJy5OB1Irv0fj0ra4z1e8PUSrBJD/t3meNFN+K3Umq45RBJ+jmOIP5yttj1xEnWo50PBmsENmzGBNQzTwLazleYuSTMQjOgNs1T+BG9g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(39860400002)(376002)(136003)(1800799003)(186006)(451199021)(83380400001)(31686004)(2616005)(54906003)(110136005)(2906002)(4326008)(5660300002)(8936002)(316002)(8676002)(66946007)(66556008)(66476007)(38100700002)(966005)(6512007)(478600001)(31696002)(6666004)(6486002)(41300700001)(36756003)(6506007)(26005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czZpQytjc0xyVzZoQmtlbnN1MmdJdTlwck5tdS9LS2lsUkpsbFE4SGorMVFU?= =?utf-8?B?WHZJY0R0MWtoa1k2MkJPTElrOHlBVm12dTc3djlNek1oTXkrWDdqMEYycWlS?= =?utf-8?B?QnExYUNOYkZuY012NERxMmtjQnY5akh4eHRncFI4Zk5XQ1Z1RFFSSmkzTHdE?= =?utf-8?B?cGFoMVJKNEc2ZmFucnhIeUpKd0pFZWMvL054bW90VHA4czZuSmx4a0hMcG00?= =?utf-8?B?YjFzWHAvaGhzZnA5WGw1SUhUOG1BS09uMW90VHJPVFFnTnpYS0Vlc0dSQ21M?= =?utf-8?B?NG4yYlF5LzdSZWpOMG1RcG1HU25wc0lMMXM0aWRzYkFBdmR4VXp6cFZHUUov?= =?utf-8?B?d0U5Z3BHVVRVQ0NGWG9XNC8zaUJFWG5uWWFRbTVnMm1wSVM3NjNZZkNOMDBh?= =?utf-8?B?N1VXUmt1RW9scGlvQjNhMEVVV1U0UnQxbFc1S0RrRktlTXRTd0p3eHFvVlNa?= =?utf-8?B?dDJXQTNiRDNwTzh3aXBOOWVrMHg2S3VUWElDR0NxVUVFeGlHeURMelVnRVBo?= =?utf-8?B?aldPOHczZXlzT1gvQzI0WXVDZHdCRzNWNnJnYkUvT3h2YWp2amd1cFpPbHdT?= =?utf-8?B?UGJidUpjZHVNdTkvVHZLSnd0TUZrSkxTR0txZ3JraENwcVRYaGpKOGpVSXp2?= =?utf-8?B?ZlpMK2NvbGk4OWFtNmlvbkF6TVZpU0dyYURwaDJ2a1dpQXpRMWRLOEhLaXZ2?= =?utf-8?B?QmRjS3dpMklHOS9PeDFnTklOTjNFMHUrVkErSWgvbnJQTHRZNVMyMG9ZNWdJ?= =?utf-8?B?d0dtbWpEYzBQdGk1a09penJoTUdBQUlHakFRYWlWa0l1L21PSERKcHZ6VEFD?= =?utf-8?B?dVNCVGZQa2xQN0VJRU00UW9yVXVtQ1U2M3h6VVNJMWErNXBCTzU3dk1xTG1y?= =?utf-8?B?N0NjSjVZcDRDSmRQUzE0YjAzWlU2dlNEOFJhZ3JpdHB2bEkxMFFUL0VkN0hh?= =?utf-8?B?WkFjZEovU3pDWWJBMUQ5aVdMa1Y0Z0hyOEtVL2llM0F4RVlXWk9MQks1dmxP?= =?utf-8?B?SlB0VGNldHpiV0duZ3IxeW9DRFcvWkkxd2x6VnBRMVdtZXo2VmsyaklKVVRu?= =?utf-8?B?YU5VdjFvRE80MFhhWjFHdGNsTDJLNFRveTBaY1ptenpUZEtzYkJkNkpFY1Vu?= =?utf-8?B?ci9kMTg4QmQvVFl0WFN0Y0JTbmdyRXNLRVpLdStKRFVDWEdrTE1OUXpyVFlH?= =?utf-8?B?d21GOVF2cGN3M0ZOTzhjRnE4Zm1JMzRXdVdPRktGY2RhRUVQSXJlNitmbVYy?= =?utf-8?B?ZVVnQ2JaV2VvSXUrakJjYzRPRkxkc0YyTUR0aFlDRDJqZjhaMHVqcWJzdnVV?= =?utf-8?B?WVB2SU5UcVRGa0l5RVJGcE5ZN1lQMk4yM3F0N2UyNk80V0VFVldaRHR4QUU3?= =?utf-8?B?RzMzeG1Rb05hU29KZTZ1eDdDOTB0UzRXNWdhWWdNRnIxQldOV29WUEdCclZq?= =?utf-8?B?aURiMVh5cXdaSm1sQlIyb1NtQlk5WVJjRGxVN0x6WDFYcU5Dc0tKSXRnTGNy?= =?utf-8?B?OXNwVnlnUWY4YkFkQVBNZG90QytrOUpmMGIvdDVrbkJlOHdXbTI1QkM3Y1R5?= =?utf-8?B?UGw3cTNPYy8vT1dNMlh4UE4ySzc4THlwWVFtZGp3ZzMrdjExcVN3WEdBdld4?= =?utf-8?B?SkpneXZwRmVMaTZZVXBOMEhla3phRGJ2M0hKaC9KYURMaGpYUFJzR0FoRk0r?= =?utf-8?B?SksxaWN5MjAvYlZheERHM2FYbnYrNEhaWVhCeHlpcUNBdE93TUJtT3hxaFJo?= =?utf-8?B?VmRySmxQSG1ycVBkWjR4dVFKSVl6ME41elZ3VHFOVEFHL3o2czBnWmlkRUR4?= =?utf-8?B?MjV5UCtGK05tRFRja0lZOElJYXFseGJtMGQrTk9kNHZxR2dsdzZOMG9GY01N?= =?utf-8?B?ajAvbm10NHhoWnd6eCtId1U0UUh3cHplQi9OYTAwYWxubXgrUVRWY1lKOFl6?= =?utf-8?B?Qnd1d3NhQnU5aXZEYURRVC9oZU4xZlJRaDF1UWZxQVdHeEZ3cCtYTktsUGtX?= =?utf-8?B?WVNoRklkTW9lU0o0bERGU1hESVRmbTB1RmNLMjJISkxvVkhwV0tuL2lIOEh1?= =?utf-8?B?S0dBM1NqZU9WbWJ4TE9IQm5TaWVvcHJZeVlJeE9RRmZtc1lvZ00vQ2s0K01G?= =?utf-8?Q?DGJViCVxiUwGB9vOppcWYHu9B?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85a018b9-fdc3-48e1-6d7a-08db973b862a X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 11:43:31.9712 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7GCW1+OpzSAf743qE3y+N/DSKIC3pbiPZG/oOeoVZEN8Dz/T3PPEuCqKPdOufVYFKiC4PzdSOp6sKec2vTX0Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9424 On 07/08/2023 12:35, Henry Wang wrote: > Hi Ayan, > >> -----Original Message----- >> Hi Henry, >> >>> At the moment, on MMU system, enable_mmu() will return to an >>> address in the 1:1 mapping, then each path is responsible to >>> switch to virtual runtime mapping. Then remove_identity_mapping() >>> is called on the boot CPU to remove all 1:1 mapping. >>> >>> Since remove_identity_mapping() is not necessary on Non-MMU system, >>> and we also avoid creating empty function for Non-MMU system, trying >>> to keep only one codeflow in arm64/head.S, we move path switch and >>> remove_identity_mapping() in enable_mmu() on MMU system. >>> >>> As the remove_identity_mapping should only be called for the boot >>> CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and >>> enable_secondary_cpu_mm() for secondary CPUs in this patch. >>> >>> Signed-off-by: Wei Chen >>> Signed-off-by: Penny Zheng >>> Signed-off-by: Henry Wang >> With two comments >> >> Reviewed-by: Ayan Kumar Halder >> >> Tested-by: Ayan Kumar Halder > Thanks, and... > >>> +/* >>> + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. >>> + * The function will return to the virtual address provided in LR (e.g. the >>> + * runtime mapping). >>> + * >>> + * Inputs: >>> + * lr : Virtual address to return to. >>> + * >>> + * Clobbers x0 - x5 >>> + */ >>> +enable_secondary_cpu_mm: >> I will prefer "enable_secondary_cpu_mmu" as it is MMU specific. And ... > ...actually this as well as... > >>> +/* >>> + * Enable mm (turn on the data cache and the MMU) for the boot CPU. >>> + * The function will return to the virtual address provided in LR (e.g. the >>> + * runtime mapping). >>> + * >>> + * Inputs: >>> + * lr : Virtual address to return to. >>> + * >>> + * Clobbers x0 - x5 >>> + */ >>> +enable_boot_cpu_mm: >> prefer "enable_boot_cpu_mmu" as it is MMU specific as well. > ...this, are the name suggested by Julien in [1], so probably I will stick > to these names, unless he would prefer the proposed names. I would > personally prefer the names that Julien suggested too, because from > the comments above these two functions, these functions not only > enable the MMU, but also turn on the d-cache, hence a more generic > name (using "mm"), is more appropriate here I guess. > > [1] https://lore.kernel.org/xen-devel/c10bc254-ad79-dada-d5fb-9ee619934ffb@xen.org/ This is fine. My concern is minor. If this file is going to contain MPU specific logic as well in future, then suffixing a *_mmu might help to distinguish the two. - Ayan > > Kind regards, > Henry > >> - Ayan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:43:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578304.905741 (Exim 4.92) (envelope-from ) id 1qSyeP-0002Z8-00; Mon, 07 Aug 2023 11:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578304.905741; Mon, 07 Aug 2023 11:43:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyeO-0002Z1-TH; Mon, 07 Aug 2023 11:43:52 +0000 Received: by outflank-mailman (input) for mailman id 578304; Mon, 07 Aug 2023 11:43:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyeN-0002YK-Jm for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:43:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyeN-0005HA-3P; Mon, 07 Aug 2023 11:43:51 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qSyeM-00044z-Qk; Mon, 07 Aug 2023 11:43:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=N0tLBPm3rHVOypWUD918M6DeqCdBgaaafpUssnEENr8=; b=WKFeOsRCY9Z4jQUpmGV3QPtJAd iTa+V4+pqljdHOfZ5ftkK96ou7DKMeUHM5hkIa0yytNCodCQxItnJ0m30w2X1/68fbQwLk4GtrZl4 cdgx7aY4QOCS0r3HgWsfiKCl1vIl0WLfq4iYrfPGcj+fohqlvrNPa4nV2XZGUsQTx2Pk=; Message-ID: <88fff832-af85-497e-9608-612c8a351d9b@xen.org> Date: Mon, 7 Aug 2023 12:43:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Content-Language: en-GB To: Henry Wang , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 12:35, Henry Wang wrote: > Hi Ayan, Hi Henry, >> -----Original Message----- >> Hi Henry, >> >>> At the moment, on MMU system, enable_mmu() will return to an >>> address in the 1:1 mapping, then each path is responsible to >>> switch to virtual runtime mapping. Then remove_identity_mapping() >>> is called on the boot CPU to remove all 1:1 mapping. >>> >>> Since remove_identity_mapping() is not necessary on Non-MMU system, >>> and we also avoid creating empty function for Non-MMU system, trying >>> to keep only one codeflow in arm64/head.S, we move path switch and >>> remove_identity_mapping() in enable_mmu() on MMU system. >>> >>> As the remove_identity_mapping should only be called for the boot >>> CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and >>> enable_secondary_cpu_mm() for secondary CPUs in this patch. >>> >>> Signed-off-by: Wei Chen >>> Signed-off-by: Penny Zheng >>> Signed-off-by: Henry Wang >> >> With two comments >> >> Reviewed-by: Ayan Kumar Halder >> >> Tested-by: Ayan Kumar Halder > > Thanks, and... > >> >>> +/* >>> + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. >>> + * The function will return to the virtual address provided in LR (e.g. the >>> + * runtime mapping). >>> + * >>> + * Inputs: >>> + * lr : Virtual address to return to. >>> + * >>> + * Clobbers x0 - x5 >>> + */ >>> +enable_secondary_cpu_mm: >> I will prefer "enable_secondary_cpu_mmu" as it is MMU specific. And ... > > ...actually this as well as... > >>> +/* >>> + * Enable mm (turn on the data cache and the MMU) for the boot CPU. >>> + * The function will return to the virtual address provided in LR (e.g. the >>> + * runtime mapping). >>> + * >>> + * Inputs: >>> + * lr : Virtual address to return to. >>> + * >>> + * Clobbers x0 - x5 >>> + */ >>> +enable_boot_cpu_mm: >> >> prefer "enable_boot_cpu_mmu" as it is MMU specific as well. > > ...this, are the name suggested by Julien in [1], so probably I will stick > to these names, unless he would prefer the proposed names. I would > personally prefer the names that Julien suggested too, because from > the comments above these two functions, these functions not only > enable the MMU, but also turn on the d-cache, hence a more generic > name (using "mm"), is more appropriate here I guess. I have suggested those name because the two functions are meant to abstract the implementation between MPU and MMU (see [2] for the MPU). If we prefix them with *_mmu now, they will have to be renamed later on and will just introduce unnecessary churn. > > [1] https://lore.kernel.org/xen-devel/c10bc254-ad79-dada-d5fb-9ee619934ffb@xen.org/ [2] https://gitlab.com/xen-project/people/henryw/xen/-/blob/mpu_v4/xen/arch/arm/arm64/mpu/head.S?ref_type=heads#L205 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:47:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578315.905751 (Exim 4.92) (envelope-from ) id 1qSyiB-0003YF-GB; Mon, 07 Aug 2023 11:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578315.905751; Mon, 07 Aug 2023 11:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyiB-0003Y8-Cf; Mon, 07 Aug 2023 11:47:47 +0000 Received: by outflank-mailman (input) for mailman id 578315; Mon, 07 Aug 2023 11:47:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyi9-0003Y2-Pd for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:47:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyi9-0005Mg-Gi; Mon, 07 Aug 2023 11:47:45 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qSyi9-0004Il-Bs; Mon, 07 Aug 2023 11:47:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=J3YGwlWLBbLcoSqg5oy/mescIf9TcQI21NQRvHRfuJA=; b=d+oN+Q2jZ8TWPNawGIJ3MWc+Fi 1ThWJObHtbr9rx9V9uJORa22q+68SSbRT7fHZIHiRtf7UOBreiAbJ0nBio7LGeNxAn9wQCodTDnL9 hEOTRuKcs5b4mo8lkRt8gV9nNakC8w935sj6033M3ZPE0sNkXRAzNsp1wrtyqpHdWAD8=; Message-ID: <4dadcb55-1c94-4b57-a7fd-32460f4d9604@xen.org> Date: Mon, 7 Aug 2023 12:47:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Content-Language: en-GB To: Ayan Kumar Halder , Henry Wang , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> <1366a5b1-4bf4-20d6-73a7-ad1735ab8c10@amd.com> From: Julien Grall In-Reply-To: <1366a5b1-4bf4-20d6-73a7-ad1735ab8c10@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/08/2023 12:43, Ayan Kumar Halder wrote: > > On 07/08/2023 12:35, Henry Wang wrote: >> Hi Ayan, >> >>> -----Original Message----- >>> Hi Henry, >>> >>>> At the moment, on MMU system, enable_mmu() will return to an >>>> address in the 1:1 mapping, then each path is responsible to >>>> switch to virtual runtime mapping. Then remove_identity_mapping() >>>> is called on the boot CPU to remove all 1:1 mapping. >>>> >>>> Since remove_identity_mapping() is not necessary on Non-MMU system, >>>> and we also avoid creating empty function for Non-MMU system, trying >>>> to keep only one codeflow in arm64/head.S, we move path switch and >>>> remove_identity_mapping() in enable_mmu() on MMU system. >>>> >>>> As the remove_identity_mapping should only be called for the boot >>>> CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and >>>> enable_secondary_cpu_mm() for secondary CPUs in this patch. >>>> >>>> Signed-off-by: Wei Chen >>>> Signed-off-by: Penny Zheng >>>> Signed-off-by: Henry Wang >>> With two comments >>> >>> Reviewed-by: Ayan Kumar Halder >>> >>> Tested-by: Ayan Kumar Halder >> Thanks, and... >> >>>> +/* >>>> + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. >>>> + * The function will return to the virtual address provided in LR >>>> (e.g. the >>>> + * runtime mapping). >>>> + * >>>> + * Inputs: >>>> + *   lr : Virtual address to return to. >>>> + * >>>> + * Clobbers x0 - x5 >>>> + */ >>>> +enable_secondary_cpu_mm: >>> I will prefer "enable_secondary_cpu_mmu" as it is MMU specific. And ... >> ...actually this as well as... >> >>>> +/* >>>> + * Enable mm (turn on the data cache and the MMU) for the boot CPU. >>>> + * The function will return to the virtual address provided in LR >>>> (e.g. the >>>> + * runtime mapping). >>>> + * >>>> + * Inputs: >>>> + *   lr : Virtual address to return to. >>>> + * >>>> + * Clobbers x0 - x5 >>>> + */ >>>> +enable_boot_cpu_mm: >>> prefer "enable_boot_cpu_mmu" as it is MMU specific as well. >> ...this, are the name suggested by Julien in [1], so probably I will >> stick >> to these names, unless he would prefer the proposed names. I would >> personally prefer the names that Julien suggested too, because from >> the comments above these two functions, these functions not only >> enable the MMU, but also turn on the d-cache, hence a more generic >> name (using "mm"), is more appropriate here I guess. >> >> [1] >> https://lore.kernel.org/xen-devel/c10bc254-ad79-dada-d5fb-9ee619934ffb@xen.org/ > > This is fine. My concern is minor. > > If this file is going to contain MPU specific logic as well in future, > then suffixing a *_mmu might help to distinguish the two. For this series, it is quite important to look at the end result. In this case, the MMU logic will be moved in its own file. enable_boot_cpu_mm() and enable_second_cpu_mm() will be implemented differently between the MMU and MPU to avoid #ifdeferay in head.S. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 07 11:56:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 11:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578322.905761 (Exim 4.92) (envelope-from ) id 1qSyqK-00056Z-FC; Mon, 07 Aug 2023 11:56:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578322.905761; Mon, 07 Aug 2023 11:56:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyqK-00056S-Bc; Mon, 07 Aug 2023 11:56:12 +0000 Received: by outflank-mailman (input) for mailman id 578322; Mon, 07 Aug 2023 11:56:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSyqJ-00056M-CI for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 11:56:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1a::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6294ba9c-3519-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 13:56:04 +0200 (CEST) Received: from AM6P192CA0029.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::42) by AS8PR08MB10142.eurprd08.prod.outlook.com (2603:10a6:20b:633::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 11:56:01 +0000 Received: from AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::46) by AM6P192CA0029.outlook.office365.com (2603:10a6:209:83::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26 via Frontend Transport; Mon, 7 Aug 2023 11:56:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT040.mail.protection.outlook.com (100.127.140.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.15 via Frontend Transport; Mon, 7 Aug 2023 11:56:01 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Mon, 07 Aug 2023 11:56:00 +0000 Received: from 13288bc356b7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FCBEE955-F3E4-4ED2-B2B3-575A6929C577.1; Mon, 07 Aug 2023 11:54:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 13288bc356b7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Aug 2023 11:54:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB8385.eurprd08.prod.outlook.com (2603:10a6:10:3da::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 11:54:24 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 11:54:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6294ba9c-3519-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T1X5C/qh14GlZuXhXyVYEqvM8mfJnjsB9yJtw/H8xng=; b=pwiOdH6BmhZ+RPkjWZNx8POlyP7qjEIqjvFi9z2VHR9i8dWXwyUh0xn3r+kajQrspvj+ATc51Hi2XYHOnrfesUsZNAKskjLaIcknYhilOHlYMx9HcC4nNOSdNXxII1cfHLbCJW9Au61awwBntVD8JU5wYEuiEsvXByiq2MyntPU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 78c20b38bbf0466a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WYNwLyVmuzpHjnzudCEU3mBNaY/F5sCvCJQ9MD2Vbz33rUtuVvnwRLw0BiGJeksONhyLakpPV64ZaldB6NMqAds946vya3JIrY0IQ67HDZhcp460pRhOcIC/qchgKky55YKi6sBZ+RSqVImsTMavsxkhjihXS70vPalBwDHewYYoeBhtPeZCeJPz2EPQ45ZTDKPH3eGAbBCpT2OnXDr+JuB2FcdiRr3tnWcTHg9z2217IKO5Nu/USWS98LgHp/50Kn5U3EQ0x2ZbKdZ807hITE1U9seu9HO3nzKd9o2MlJUc+4sqcmPqpi9uRyB+qRglNNHKObcJvmqsrgi0erSl6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T1X5C/qh14GlZuXhXyVYEqvM8mfJnjsB9yJtw/H8xng=; b=oa8Pm44Qcc3AwoTUa2DK7b7B8knHkeFdgNbWyd5mg/zZNRFJeQ0hpWrClsyQpcEFzVOmqB7c7L/ZgEcoM5mHCm7EyrqQlX50lfWianVu0rDW/ZaqHcDngRFYqsDhCyqO+4wFmhcyxsFt17/0iMXNDePn4ggwfEXW3BGgEhWj31nkGBXkoJ/rFTb8iI+vq/yIn0xB8VQsgjVGf6Wvs0aKndJtSj8Mhos22MZmzpzeA4QYvFdo9nXwqklikJTXedMkwnU/xjTVYqiEg73jDYE3ZxmgKUw8ODt6hOXrbpnkZ++xi+ocj11xCt3zE6j3rSG3kPQ06BOiW6CevOlMJqnrvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T1X5C/qh14GlZuXhXyVYEqvM8mfJnjsB9yJtw/H8xng=; b=pwiOdH6BmhZ+RPkjWZNx8POlyP7qjEIqjvFi9z2VHR9i8dWXwyUh0xn3r+kajQrspvj+ATc51Hi2XYHOnrfesUsZNAKskjLaIcknYhilOHlYMx9HcC4nNOSdNXxII1cfHLbCJW9Au61awwBntVD8JU5wYEuiEsvXByiq2MyntPU= From: Henry Wang To: Julien Grall , Ayan Kumar Halder , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: RE: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Thread-Topic: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Thread-Index: AQHZxCqBtZIUxf7FmUaIEyO8EPs3TK/euu6AgAABikCAAAQOAIAAAf9g Date: Mon, 7 Aug 2023 11:54:24 +0000 Message-ID: References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> <88fff832-af85-497e-9608-612c8a351d9b@xen.org> In-Reply-To: <88fff832-af85-497e-9608-612c8a351d9b@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C2DD655B15D18844B94CD4DA615C0D6C.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB8385:EE_|AM7EUR03FT040:EE_|AS8PR08MB10142:EE_ X-MS-Office365-Filtering-Correlation-Id: 69d73824-d949-4c3c-b72a-08db973d4525 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cRyQkPjVK3LVECw/25omadT9jFb0+VyzMTZvt3xEjjxXS1igt+DU1Mfp4nViBTuJbphXPpILlTw3qntAQyXDmM7ve1xl23L82VsR0e2xgMsYNgQoLXMUyBgq9f/bZRqln+EogBvamHZqEfyeaYZa7j5cpmTdqP5lUMSMrUAOk8R6JQRsvkjajOmtpqtPBz669QqwTchCvMDN2b3aEiwK1rzUS0FFlyQMe9hWBxsSazcsHYMEO8VzmfBPoQbExpaRwE67PaXffx4ES0xS12yatyl8PdGkK0d6uSvp6o57rA6JhmwXMvlOYslAdHY5dQB6KeTzYAvQqp+8NosZ73UBjjaVQKZrHCNGaA96cyeiVIdCJP02Y8Y8CKM0bAhn1D+9YK/tp7zEaZfGgXindIFjQggwxJS43/Jtl3tdwlezO0LIQKCD0h7s5PuOKLL0rV6KQTWLDN9XNHNa1nzBsaexruvbCjlaIBQTdXPM9xWh5gX4MGjBB3Kj4Chv6hWphpM5k+TiCyNfQkHRYrYtLtqHWKN2Cmz8dzWP7XHuyYnuVe3Zy7Vtc3/hO5MC/Q/79BjNQqBjBaGOb32RagV8fpGpWX1b9oLd+FigJ5rQ5hZbRRZd/RwZ2ZlDG9SkrH4y4ASCwZVoBgp+jS5kJmcH06iVwg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(55016003)(966005)(9686003)(4326008)(316002)(86362001)(478600001)(122000001)(54906003)(110136005)(38100700002)(76116006)(71200400001)(66946007)(66446008)(64756008)(66556008)(66476007)(33656002)(7696005)(6506007)(41300700001)(26005)(52536014)(38070700005)(8676002)(8936002)(2906002)(83380400001)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8385 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ba047f0-8927-48e9-52e0-08db973d0b64 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JzPVbPtqPpn+UIMuo8DCEVom9PZYcwN5TUu3Ir7uj3CtZKGFAJvEz2OQnMNTVKS1MXgQ6a6tjg5RtZ62VxbG/0uLC7cCFYfNAgyo5WqUgkGJE+b5TvNF3pON20UbIp6+9Uv9BlVOSV8Pjjq3XBcqCbWhUW+Fq8AYsoZevmXVYAuSUdEoPMG/nr+E/+uLdmH7uo/Lig/w2hg0A4IciHz242JIMn0WmY9CLB+X6FEDFYykdLf1MJHhNUBLgqppRBwSdjTWN0U8ymTLvR0yzbRm9loiyJnoClPbQczUn7l3EDzhjedKEC/giSn0EZh2EzZh+Kx7Th5PAVOfQjNmqMQWhr7PwCHUJrVRE/oigxt7YzyzStJDigeFzQZBBMIQH0Zz/a0C75jIPm0Up8wgbfAfeJSyr7Xn6O/qlK5XZY+cTCdz3b7Pd2HlN9UJ/ZU1ZvnslaShGfmRaYxITETgUkJKISVucxpwJpJjgXg29vcA1ZF5yQ5USHgbYwB+hg+X2f5pqhSRdRhW7Utg7zvdfDKl++kFcv1t4YOrZypsVWr06yiK8uHaBlLq+jH+xJRS7fKpimG58HScRCoaqm08AkH2TFe8xqLA9FpVBREYBaLyFrwy02Uzj5pzcv9BiQd4O1MX8YEWaC6hFfAF113llbX7/ljHikZXY1Nwvir2+pSM96n+CSh4u40JCiSJz1BEqXhUwi8KxuFebraZQj5KCFTlF9H3WtHenz9Ls0hJav2pYZ1phi9AqOwtUp/aUoue2DyAPTgsmVfv+2MK3n7HOhjEYQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(346002)(136003)(82310400008)(451199021)(186006)(1800799003)(46966006)(40470700004)(36840700001)(86362001)(40480700001)(41300700001)(336012)(52536014)(478600001)(40460700003)(6506007)(8676002)(8936002)(26005)(7696005)(5660300002)(47076005)(83380400001)(2906002)(110136005)(54906003)(36860700001)(55016003)(316002)(356005)(966005)(70206006)(70586007)(81166007)(4326008)(82740400003)(9686003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 11:56:01.1330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69d73824-d949-4c3c-b72a-08db973d4525 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10142 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggdjQgMDEvMTNdIHhlbi9hcm02NDogaGVhZC5TOiBJbnRyb2R1Y2UNCj4gZW5hYmxl X3tib290LHNlY29uZGFyeX1fY3B1X21tDQo+ID4+IHByZWZlciAiZW5hYmxlX2Jvb3RfY3B1X21t dSIgYXMgaXQgaXMgTU1VIHNwZWNpZmljIGFzIHdlbGwuDQo+ID4NCj4gPiAuLi50aGlzLCBhcmUg dGhlIG5hbWUgc3VnZ2VzdGVkIGJ5IEp1bGllbiBpbiBbMV0sIHNvIHByb2JhYmx5IEkgd2lsbCBz dGljaw0KPiA+IHRvIHRoZXNlIG5hbWVzLCB1bmxlc3MgaGUgd291bGQgcHJlZmVyIHRoZSBwcm9w b3NlZCBuYW1lcy4gSSB3b3VsZA0KPiA+IHBlcnNvbmFsbHkgcHJlZmVyIHRoZSBuYW1lcyB0aGF0 IEp1bGllbiBzdWdnZXN0ZWQgdG9vLCBiZWNhdXNlIGZyb20NCj4gPiB0aGUgY29tbWVudHMgYWJv dmUgdGhlc2UgdHdvIGZ1bmN0aW9ucywgdGhlc2UgZnVuY3Rpb25zIG5vdCBvbmx5DQo+ID4gZW5h YmxlIHRoZSBNTVUsIGJ1dCBhbHNvIHR1cm4gb24gdGhlIGQtY2FjaGUsIGhlbmNlIGEgbW9yZSBn ZW5lcmljDQo+ID4gbmFtZSAodXNpbmcgIm1tIiksIGlzIG1vcmUgYXBwcm9wcmlhdGUgaGVyZSBJ IGd1ZXNzLg0KPiANCj4gSSBoYXZlIHN1Z2dlc3RlZCB0aG9zZSBuYW1lIGJlY2F1c2UgdGhlIHR3 byBmdW5jdGlvbnMgYXJlIG1lYW50IHRvDQo+IGFic3RyYWN0IHRoZSBpbXBsZW1lbnRhdGlvbiBi ZXR3ZWVuIE1QVSBhbmQgTU1VIChzZWUgWzJdIGZvciB0aGUgTVBVKS4NCj4gDQo+IElmIHdlIHBy ZWZpeCB0aGVtIHdpdGggKl9tbXUgbm93LCB0aGV5IHdpbGwgaGF2ZSB0byBiZSByZW5hbWVkIGxh dGVyIG9uDQo+IGFuZCB3aWxsIGp1c3QgaW50cm9kdWNlIHVubmVjZXNzYXJ5IGNodXJuLg0KDQpF eGFjdGx5LCBJIGZ1bGx5IGFncmVlIHdpdGggeW91LiBJZiB3ZSBjYW4gZG8gYWxsIHRoZSByZW5h bWluZyBpbiBvbmUgc2hvdCB0byBmaXQNCmJvdGggTU1VIGFuZCBNUFUsIHdlIHNob3VsZCBkZWZp bml0ZWx5IGdvIGZvciBpdC4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gPg0KPiA+ IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvYzEwYmMyNTQtYWQ3OS1kYWRh LWQ1ZmItDQo+IDllZTYxOTkzNGZmYkB4ZW4ub3JnLw0KPiANCj4gWzJdDQo+IGh0dHBzOi8vZ2l0 bGFiLmNvbS94ZW4tcHJvamVjdC9wZW9wbGUvaGVucnl3L3hlbi8tDQo+IC9ibG9iL21wdV92NC94 ZW4vYXJjaC9hcm0vYXJtNjQvbXB1L2hlYWQuUz9yZWZfdHlwZT1oZWFkcyNMMjA1DQo+IA0KPiAt LQ0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:02:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:02:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578329.905770 (Exim 4.92) (envelope-from ) id 1qSywk-0006lI-7g; Mon, 07 Aug 2023 12:02:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578329.905770; Mon, 07 Aug 2023 12:02:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSywk-0006lB-58; Mon, 07 Aug 2023 12:02:50 +0000 Received: by outflank-mailman (input) for mailman id 578329; Mon, 07 Aug 2023 12:02:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSywi-0006l5-Ft for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:02:48 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2045.outbound.protection.outlook.com [40.107.13.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52c4c4c8-351a-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 14:02:47 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8193.eurprd04.prod.outlook.com (2603:10a6:20b:3ea::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 12:02:17 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 12:02:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52c4c4c8-351a-11ee-b27e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E/N7n9vBOa0yPJcz6aJbjKIAf3/FC+gHYbtJNralmUR0gKigyefLVlLEqp/mu8vYvS+hrgnqEEgosFANoLrdWVLqhcQE3sE/1uoYnnQqQd49F0CEunIr5HUKyQQG4m8Hwvz9o/ug8HfX5AY8/gv8BPp3p6kwgn0FkhQFNT1jCwlOl0R3CuUaHHVnhxGbAu9oYF2+XAaFEsAHHp4E5BC2xLCuipnwJvFfAR8SHaNJ020gBoX8GLeOV5Gx9DhYpv4fred1JsYOP+BGXkwGpavrRrUqitM+GnfPsIGHAvWase5DnU/wL9K40+RpoSN5HuHJ2XoP/vyrXk5iC5LW2k+3Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GrBKQz4pbcL7Gop5ewv1uH0dkcqoCwmO18JiTdgjQXs=; b=G+/oyCwcQFeE/Aw4EGQknIa1ZXefp9zbzazHJjsjBWHAQu9S6wF2PK1ELH2/KYT0FjEEBx0WX5ehxyuHe4z8P6F2pDFFyIx05eYMX5DYSXyNYSa9E9g3V1dw5vmO2sCMIuMcWzfDNCjjS+juPZr6rsl1AQ27c005l6MGV2vMVsn3Ueo6Kq7W5u6SaaD+JZhL6lwUwva/IMYq4t/2KTl51bsTihzZdYiaelVJg5IwJgZdZbdAVwoVY2vL4luuQ+gP2C5xVFDa8keaEeZrz1/lstlt73sCVISkhJIs5mVyUWPI1JJVBKkCDpiemGVvf3gOCt1JuUKJ1sqL/VyeGD9dEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GrBKQz4pbcL7Gop5ewv1uH0dkcqoCwmO18JiTdgjQXs=; b=37kjOQhEbj9LMlUhpGUBJonC+EtXdw4eScddTAaOKPVBqB6n9WgikjJsDha1IGHOm1fcbo662dZlTRrs0dnRjJ4i74dCjPRtILUoKkHDHDjJ9Ojqf6Ij7XuqjDbEG1o3jLwVYtCOV0UHVORaXlRp6u5pTT7uT383cbhZ+stJxg9kEF92KkkUk3KpgHzOcT+I78q2UuOT7FG/eQUOry0KiTFa0x3lWEt5HMnDT2OVdZleg62BNybmWMVmO5n1Ct+DiypIQWxbnd/G1lKbvhZ5iIGBqA9o91whPh3fdy1ArMXtU3TUYPhsIOo62Szok8Dvoxd0VQpLF4+Si1SeXtOZDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <42d0bbd8-5f90-15aa-017e-e48581a28e48@suse.com> Date: Mon, 7 Aug 2023 14:02:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> <871a501fb76cff724ed1c2b09277e2a3@bugseng.com> From: Jan Beulich In-Reply-To: <871a501fb76cff724ed1c2b09277e2a3@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8193:EE_ X-MS-Office365-Filtering-Correlation-Id: bf509fb4-7e02-473e-0c12-08db973e252d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mj/wBhr5cSi8+UNDFF0P8RRXENf9atbDPffQfXMqlwr+AFw/gpcmhRVoqjebtqQyDONt9aF3L33ScehzlxBDOf4FsiUQ+YhZuQ+pWzIKA7/ALWuSnpe57gNgepwp9w1nxSl3Wihdl+kW4YUrBtwgCnZpWmzXgxzdaor2MddULaNcJyEhLvA5zIT60RxuAihWcT+0ETIGJJEx6oI6BE2qaUhbuxTjuSYAXVQVb/kCpFDyRChAxFC9gIcq2IgmsrLcMluFAUayLWfA0Z2QkeouAy3jBSY8QpsPybKwwC36dnyNx7/wEkbk+y+chtkTm46f+bKJoGqWwauk6KOaxlYFkkH0fRuDCmXLeawELApy+rC3Ol8TZ4amZ0xBRNeHlspspgJslW4aunG96OFcF0v4qACMF49wzBjjvCw8gMWUJB+1Nxoq0bfChpIqCOrmw0YROtUdXClh9x/9i+kzkvLGaS3Mr5ef7VU6o6wXb5t1uqjsz3o2HWSk3WIlYtpn+pKI3MQveoB04+50XE2ofrk8fwx715HgeZW/HEJQwbtaLCNxQ70vokVwblEDpbUcv9ymK1bXHO8fiUvaKoN9GxdTwEMoLp/JWkd8qLfajTkImxix1Qm3oecW/oWxvTyxW8xzYxWmlrxKX/wNDkpbm3MmyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(346002)(136003)(396003)(366004)(186006)(1800799003)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(83380400001)(7416002)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(31696002)(6506007)(53546011)(54906003)(38100700002)(6486002)(66476007)(66556008)(478600001)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXhkeEs3ZHlNbWVHN1pnV29IWXM1NWVxbzVUcmdQcHFua3ZXbjlWYzhYTFJO?= =?utf-8?B?V2xYRVFabzhKUkk1ZDFKdlhmVFpZTThBSDh3Q095THkxWXZDSmRpdk1lQWlr?= =?utf-8?B?YUdwVElEV0w1OE9zUkE2R3YwTThFeVlKY1JVa3BwNE5iRXJhTmEzMEtsd2Fj?= =?utf-8?B?cFFGTEd4TGhObG5YcXdPSXNSUzVxVHBReDUwTUV3bkpieW9pd0FyN25uNzh4?= =?utf-8?B?Q3dkQWp3b3RvYnhVSk8yV1B1Wkx2aU94WW5YZXEvZkxDeG5TbzVPM3Z0UmVo?= =?utf-8?B?Y2w0RHdLaURZWW93OTkyc0twQkRzVWwrRUNJM1FlMXpkM0JWTkFQRDlqVUdq?= =?utf-8?B?a1lXbkdhSHNKbGt5L2hNVXdXQVdUZnk3OU5xRWQ5Y0svRnRGR2l6Qjhpckc3?= =?utf-8?B?VUJGTzNVd0tPZlptdHVkM3kxcXFTblpmQk9UOUdPdzVCV21vekNocWRPQ0cv?= =?utf-8?B?V3pXRCt5KzlEQktyWUhFelFhMThsSEtsSEM3T1JVN1lKRzY0VzJERmhVZkU5?= =?utf-8?B?d1ZxcTJmeFhMVVpVYlFEMjlkOENZTEljTFhTMjA3c3U1VkUvR1Q1aTlDY3M4?= =?utf-8?B?MWI5Tys2WFcvQUlldTN6c3NZUHFaU1d0VzExN2VTMzJJbzFjSzhMVjNqYW5J?= =?utf-8?B?ZmtrR1RVa2RvWXNDSTZCRlVtM3pUelo0K2R4dnJMeC84SVBBcUcvWjNlTHQz?= =?utf-8?B?NGlCd1VDNHFZcllSZWhUSmprMnI2Ym8rOWNjc3dYWXFGR09FYVU0ZmVoODk0?= =?utf-8?B?UWlDOVh3UXMycVlKS0w1NTlOZXZGSTI3V2RwekJ3d29BR0ZINS9VbWdSVGtk?= =?utf-8?B?OUxEek13czNxc3Nuc0ltVnlSb3FQWEpkQXU0VllDeWlZdlZDTVhYMmE4azVl?= =?utf-8?B?cXBLbHRsU0hOQzJRSGF5dmpyVWxCejlQbThoNG5NRXRTajU2bVFjcW1ZUzRS?= =?utf-8?B?TGpHQ1lnYkx5eTJGcU5wOHphU1kzV3hVNHBtVnU2WTQ1WGg4MWkzbTJGQ3ZV?= =?utf-8?B?S0NYL1pvN0xsK1hldk1GRGMvWTN6dkFTa0ZybkNjK2pWNFVtYVZiSjVoYnBt?= =?utf-8?B?SGVGNmZrenVQZU5JZWthVkpoc2tEQ1dQb3gweXBIQWhVSkQ5My9lTWtuaUJG?= =?utf-8?B?QUtiR1JtaUVsVDRjamp3VUh6Ui93cUxQR2lzWE5GeitjcmZpYkxLbVp2em0w?= =?utf-8?B?U3ZucHBMSUdsejZ2V3JoeEtNSFVERWdVTHA5NVZ2dU5VSVdpY3dWS0hKdzdj?= =?utf-8?B?OFBFZHEvM0lNd1h2ckRRaEJTMUpMaEVDL3B3OE5tdU1DR01MUTZOV3YrQXRG?= =?utf-8?B?enpRQmI1TFNOSGZSQUQvdVFnWlNOd2lHMGZQaUk5cGdjU2M0S094blF4NnV3?= =?utf-8?B?b2hLTFdOLzIrOTVQU0lRdDM2UHJrQzNkdCt6eXFCeFo4TEhNMXVIblFoa09X?= =?utf-8?B?TURQSU4vMGVZanF5N0hIY3hueXEyZ0h0TVUvSldQU0ZzN0dFQkhMMHJmbit1?= =?utf-8?B?RTRqb2V4MHNERkNBOElLRjlGRGxDeFRjb2d3RmtMYmNTQlJuVE9jZU8rbWUr?= =?utf-8?B?MUNScHE3SlpiT2VvbW8xbm9CVDEwZTNZdXo2NmlhdUZQK3V0TTYxU3ZqeGZ3?= =?utf-8?B?UHhyUlVOUTRHdnZVVndTWDU4c3dFWnRRVy9DWEtKUGdxVDZ2SFFESitEMnJZ?= =?utf-8?B?OHYyejM0eDdKcldYZEdDSytMM3ZKU21GNEhtWXk1K1o0SXJLdjhvN1ViYm1a?= =?utf-8?B?a3E5cW15S3grV3FlU2lFeC9LNXF4MXZFYkdoekZ0c1JHeG9iZ0VwekxoSUNO?= =?utf-8?B?cncyNWkrbTRWQnV2ckR3bThpaWdyNkU0VzFmRFV2Ym4vMUlyVUZKZUhpMEd1?= =?utf-8?B?SmVmc1J0TFZSUnVrNFI1SzBMb2JqQmx5SHdTT2N4anNreEYwUjhFRGhKR09T?= =?utf-8?B?TXdtTFl2Z1B1U1ZNVGNqWjNsa1JYdEJhNUZkT1l5MXRCWnVnRmNDRjRVNWtE?= =?utf-8?B?OWVnbC9kTWVXTmhjK2ZlWWZXdDZVd3pKOUI4bjVJK05YTmlWM3NlMGNKeThI?= =?utf-8?B?a2twaWpKd2h6SXYxRkl6cWpLTWFBK1RzazNiSCt6aHEwUCsraW1sV2ZSSmtR?= =?utf-8?Q?RQ1hZikUDFFPR/0zA+qEt9cSI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf509fb4-7e02-473e-0c12-08db973e252d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:02:17.2195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZSlyDHXF8jJJNRVSjRJhMepb3J/58yJwvm0ampZGvIpEladgntrZSvD/ekpPfqdlcXPci9uOVBpDkD0kNtYEQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8193 On 07.08.2023 13:12, Nicola Vetrini wrote: > >>> Besides the one you listed, there are these other occurrences: >>> - xen/arch/x86/mm.c:4678 in 'arch_memory_op' as local variable 'struct >>> e820entry' >> >> This probably wants renaming; my suggestion would be just "e" here. > > Ok > >> >>> - xen/arch/x86/include/asm/guest/hypervisor.h:55 in >>> 'hypervisor_e820_fixup' >>> - xen/arch/x86/include/asm/pv/shim.h:88 in 'pv_shim_fixup' >> >> These can likely again have their parameters dropped, for it only >> ever being the "e820" global which is passed. (Really I think in such >> cases the names being the same should be permitted.) >> >>> - xen/arch/x86/setup.c:689 in 'kexec_reserve_area' >> >> This surely can quite sensibly have boot_e820 use moved into the >> function itself. >> > > Ok, although your suggestion of breaking these renames/deletions in more > than one patch may not be applicable, > as 'kexec_reserve_area' calls 'reserve_e820_ram', which in turn calls > 'e820_change_range_type'. > Similarly, the call stack containing 'e820_add_range' includes other > calls to the modified functions, so > effectively it's best to drop the parameter everywhere all at once to > prevent accidental mistakes. Well, this still allows splitting parameter removal changes from parameter renaming ones. >>> We can take the first approach you suggested (which was my original >>> attempt, but then upon feedback on other >>> patches I reworked this patch before submitting). My doubt about it >>> was >>> that it would introduce a naming >>> inconsistency with other e820-related objects/types. Anyway, if >>> e820_map >>> is not a good name, could e820_arr be it? >> >> But how does "arr" describe the purpose? I would have suggested a name, >> but none I can think of (e820_real, e820_final) I'd be really happy >> with. >> Just e820 is pretty likely the best name we can have here. > > Ok, so perhaps the best way is using the strategy above, although I'm > curious why in other places this > was not the preferred alternative (as the global may be dropped or the > callers may use a e820map other > than the global one, but here I recognize my lack of knowledge on the > internals of Xen). Other x86 maintainers may voice a different opinion. My take is that since we've now lived with the set of functions we have for quite a long time, problematic changes like ones you outline are not very likely to appear. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:32:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578335.905781 (Exim 4.92) (envelope-from ) id 1qSzOw-00025F-GM; Mon, 07 Aug 2023 12:31:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578335.905781; Mon, 07 Aug 2023 12:31:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzOw-000258-DU; Mon, 07 Aug 2023 12:31:58 +0000 Received: by outflank-mailman (input) for mailman id 578335; Mon, 07 Aug 2023 12:31:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzOu-000252-Rq for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:31:56 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 630392d6-351e-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 14:31:53 +0200 (CEST) Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 08:31:50 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH7PR03MB7438.namprd03.prod.outlook.com (2603:10b6:510:2ef::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 12:31:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 12:31:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 630392d6-351e-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691411513; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=LP8wyWrP4TFzd4iy6/8U99CvGxFEkXDV7f7kaAenj2Q=; b=ISPMVf8rswJxrPm739SJz4MsGP1t0OM0W4WVOeqZp78Bipk81JMQWWwj HITcu9Wjji/6Jm3OmyG2TEVrk7ogw7GCP9BIQHUWhiW7UepujcZQbhtee 1OMYIkkDcly6k9iY/fHNDCaEdjHV2Yk9OuY4HX266mS6+D6qEu2jV5234 k=; X-IronPort-RemoteIP: 104.47.56.170 X-IronPort-MID: 119148616 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uU0twqwQxlW9Bc1op9l6t+dwxirEfRIJ4+MujC+fZmUNrF6WrkVRn DFMWmnTb6mCZzfwfN4kPIjlpkIG7cfXn9dmSAZk/iAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPa8T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUV+0 s03cysGVA/Zm9Ko8pafWOdxiP12eaEHPKtH0p1h5RfwKK9/BLvkGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVlVMpuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAdNLSO3mr6ACbFu7+FQuTxcYWhyBvqOFikXmddMAA WkL9X97xUQ13AnxJjXnZDW2rXKJpB8XXJxLHvcz5gCLy4Le/gmCC24LCDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcJYikfUA8Z4t/siIsugQnCSNklG6mw5vX3Ezztx zGBrAAlmq4ey8UM0s2T4lTvkz+q4J/TQWYd/R7LV2io6gd4Yo+NZIGy71Xfq/FaI+6xS1iKv HEA3c+E/u0KJZiImGqGR+BlNKGk4feMdifVjl9mE5Ai8CmF8nuvO4tX5VlWLVZgNIAHZDrge gnTsAdd6YV7NX6mK6RwZuqM598CyKHhEZHuUanSZ98XO5xpLlbYpGdpeFKa2H3rnA40i6YjN JyHcMGqS3EHFaBgyznwTOAYuVM2+h0DKarobciT53yaPXC2PxZ5lZ9t3IOyU90E IronPort-HdrOrdr: A9a23:GzLACa8eOQ2NZvKi2dhuk+EKdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVcqKRcdcLW7VJVoLkmskaKdjbNhX4tKPzOW21dATrsSlLcKqgeIc0KRltK1vZ 0QC5SWY+eAamSS4/yKhTVQJ+xQu+VvvZrY9tv2/jNId0VHeqtg5wB2BkKyFVB3fhBPAd4cGI CH7sRKijK8cTBPB/7Lc0UtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfMJ8H TDkSb++qK/2svLuCP05iv21dB7idHhwtxMCIiljdUUECzljkKSaIFoS9S5zU4ISLXE0jcXue iJhy1lE9V46nvXcG3wiwDqwRPc3DEn7GKn4UOEgFP4yPaJDg4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn93d7VTBtn/3DE6kbKqdRjwkC3bLFuIYO57LZvin+9Ka1wax4SPbpXWN WHD6nnlYlrmB2hHjzkV1JUsaCRt0QIb2q7q3c5y7aoOhht7QFEJhgjtbwidzE7heYAd6U= X-Talos-CUID: 9a23:j6BjY21oyUvbbs5s3BYbDrxfPvACQ1KG13zqPBWkOXhbbJmHR0KewfYx X-Talos-MUID: =?us-ascii?q?9a23=3AEjT+4A5O1Vk9MRCAtJ7t7A9nxoxW25npAk4C1q8?= =?us-ascii?q?Z4fWEPnReOmi3qSu4F9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,262,1684814400"; d="scan'208";a="119148616" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvbz0KS/YxkCDAlvhsrIALRiQqEfaBGNJLUt+bMNyDFzVl6dJkPuGUy1Ueku7E9t4iKIYQ1pAzHkreT7fm5VoIl2OPK5w6PJptRSLFS7HomHToXIyowp+G3Q/dCLVk/Ay7zIk7pPMyj1NU0kxBA4tKBJO5HFhzAwQso0h5vHI0TepOl8oTClp7eWsmIZt+Ar0l9YgJ4rYxBhzjY45AI6gdsH8Vw6cedOiADOyDxWRAUvufXpq1txTqH+DVGcxYCr8mtkyrZ6VhiIdscC2nSws1sq6bc02ay5qKAstqEE+XZOgyr9/fYOKGXWp7Njnl5/pRuLQN/2OZMU4gCaXbM+fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G7p/gEpThY1ch+U/eJJhsdFuuB+Q1peLfyB3S+sdRIw=; b=kjWyRVLQYu3TXoPzedhjonlvCaZ11SqpbYL7Uvg8dikm1Prj3uDnV1379SxhLm541M1dghF1sb98YOGCXQATb8mYODhd1Ey4fKg0oadW2YYyOyobaULvgLyf0qOLvOtGPgKwEQcA5Jdc1In/EcFxDY7rK4qpHNtMv4dXWct2wAbymwRe1TFmdneWJz0m30UvtKHJIJbt9Ryevl8JuxlGdemtEIPeFsEMTzNy8E0vdqAbIN+VtlMOP2AtM7o5ZJ2UpmRsCtvRZEyLr9tExN0vlz9Ur5V/qQawH1JDh5668ggjqZJ1OPufyiPXgN1QRMaRHKtdJ/1nLY+64GQko3B/sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G7p/gEpThY1ch+U/eJJhsdFuuB+Q1peLfyB3S+sdRIw=; b=WneqvsVTgsT8xFYZioYC5pwsDfiw95Bljez3Mwx4HuKAVojOxNObxr+SDJ88qg2IG6pq9KwdnV0njGD7gTxsizy9zzCfOQyftR+zBZTb+aksIg1CmhRSBhGO6LKskSQ9ZfYNuY9yQkCt/dpnPH0md+twC+QEkSfaKBhzPeOA3X8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <64ec2572-348a-2c6f-d354-2747659e4666@citrix.com> Date: Mon, 7 Aug 2023 13:31:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: [BUGGY] Re: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t Content-Language: en-GB To: Federico Serafini , xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder References: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> In-Reply-To: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0157.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|PH7PR03MB7438:EE_ X-MS-Office365-Filtering-Correlation-Id: f96a6771-e4cb-4f87-dca0-08db97423fa5 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N+DzVbkBvlLWkCdyoDDeYVi028VXbcJ01W0Ts0CRK5dwTIrW9ly74y3xFJsau7qiCnjNHngyvMjzvSqgU1Km/8ol2WZxCsgiUEqtcW76qbOZXmrfsHCgA9FkZ2FSSFxF0x1K/QGoTbw1EbT7dApY188F7DB9lvI+j/QpPZB0ncLmEYwroBtxs5h36ak4EIoeOl31x7EibRt7YHVFB+gIT/kmaOGKzQ4uOpxruVimR9c4H41tB4FvVux1PKAIl1MxZ9CS8P8OPHhCNUlyz7kS6xhBaUdUaLo56bIzpk1fumKVH/Vpcl8V6yTbwY7vNa80U0Pl+cfvkNGV5s3r5qBQgHgWUyM5C7eiHKReEcDVrcXMrkuvduOoGbO4c/ZwfrxjvSK1M6h/4NgtfTkEa8m3wJdju87dkZAntaBs/ipyyA3JRvKNicuBAlT2Dyxo4GQWuvcSW9HoufVNWxdGUJFZ28b7zDmwj0kgzk8OUy7e3yZN7LTKVq6XBPUt1dQEJLEu9cpGZ+F+tYEdq569sAYpFmI9x0ixGGG55DXIAQujJXIYw53VS1gfZPruRca+zXzivTqvH6G5tHYvy5+E+2eYNEe7IKY+pBH1sGeRa2MGmBjUU8Z4xcCDUEQL1/Q/EubtZR+fdqghBAY0F7IMkyx9kA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(86362001)(478600001)(54906003)(38100700002)(6666004)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(82960400001)(41300700001)(26005)(8676002)(8936002)(66899021)(2906002)(83380400001)(7416002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGlIVHB6dDYweWJYTlRCRHBJeEZFYTc1djR2aVRROTdpVC9MRys1WHE3Wk45?= =?utf-8?B?RHJuL2plSkRPQnV0TnBWN1VvR1dRSmVEM3BYdGRML0pBSTcxbDd6WTdIMm1x?= =?utf-8?B?alFYaEtsWGRLanp0Mk9nRllldG02RE1JRjVjWGR3bnplaW5GdUltcHBhZitT?= =?utf-8?B?b0sxRGFmYUFvRWJ3QVUyNkNSbUpTd00xM3ErTVA3TzdERXNVU1NKTk1jb2Rl?= =?utf-8?B?VGRlT1J0akl1Qnc4TTJ3ZnNyR3RvTEhEdDlQOUpGalAvQTFKb1hrWHJ3S0o4?= =?utf-8?B?bm9KRDdRWGFPdjhOa2xYVkpyWnhaY1JHb2pwZlMveGlYdkhvTm9HNFRxaHdo?= =?utf-8?B?TWlGU25CU3lBay8vZ1R3K01aaGlxRVJyejdYSGdTbnJKUjczaVI0b3labFpK?= =?utf-8?B?M0tKN3lxeGYrOE42elIvZGx0akRLMlJtYTc2TXh6eVV1bTE0Y21ybnNaYTRt?= =?utf-8?B?MlkxeTZNMVJqcEpqYmh2ekYvOEZYK3RlampIaUsyS1lObFNqK1BnMXUwTXBH?= =?utf-8?B?aHg3UFVKVjc5cnlQWE1XaFl4MVluSmxGNi9mTWRFZFlCY0dHa2ZiK3duMi9V?= =?utf-8?B?OVBxdUJGTDJLRm9ld3hKRTlJZTBNMnhYSzVzOHArZFNFVFkxMzNDR3Nwc2h4?= =?utf-8?B?SnQ3YVBTRHhURFJWZjBBUHU3Q3FENGI0UXlQNDNhd0NLc0NtZHFKR2d3REFN?= =?utf-8?B?ekNqZGIrYmJiQi8yR1pSTEpwMWtobnpwY3luOFA3bVpOcnUxak92b2pKM1hy?= =?utf-8?B?SkdGS0pWODBPSWtCYTh3aHV1MVVlWVdLZUhLRHhyV054aForSHd5ME5OS0F2?= =?utf-8?B?L1BjMUxzMnZUa29rNjI3eWxWNSs4eEVRQnp2VkgxMVozeVZEMzA5aE5SdEh2?= =?utf-8?B?ZVBoWVJ6WXNJZWcvOE1RZkZZWVBPTi9DUHB0Y0hzR1dPMGlJWEdmUGQ3TFFW?= =?utf-8?B?c2M3VkxjMXR3UlV1U3RjVHgvWmlyRm5Na09MbXFqVEk1ejZiU09LTm5sRWRU?= =?utf-8?B?VHVOalBiYVVzNzlVTkpJcCtLMlUxVWZUVkIxVm5vbzhjMjRyVTBmbW1TcDQz?= =?utf-8?B?Q2tlVWQ2cGE2U1N4NGU2dWxmRUVzdHNLMGZZcjFnU282eVJQMnpTN3cvQW5z?= =?utf-8?B?TUxJaHZPeVpadGVvbHE0dXpsZ05lSkVuVmZ0WHRTN1dVcm8vWEluZVNTT2dl?= =?utf-8?B?TEJHNTdUVGplcUxkdVFFNWp4OXprNEhvcFpFb284QU0xbkZrQmlLUHFlVkJx?= =?utf-8?B?NkpHV3UvMUJiWHpkenRnMU9ab08vVXRGWmxLQW0waXlhU1ZPNG55dHpYVlJi?= =?utf-8?B?d1ZBbkNKc0F0L2wzdkFSVktnYm9mSmNPbVlXQlhqak9LNnZFQ3hRN05nTGxK?= =?utf-8?B?aTVENEpmRDlXWFVhR1lzcG9DOE1SNmhQMWU0WWVlUUF1UDY4a1JPWUtSOVJv?= =?utf-8?B?QU84cUNjemZhU01EcnZjM2htbDhER3ExT0tqSVlwbnR6dEl3YXBzVjkrNVhR?= =?utf-8?B?OFY0OXMvWEZ3aWFDdjZ5RmVzQVdVdHQzd2xSd2JIUkI2YWtnVzhXSzVOdnZB?= =?utf-8?B?WFVuWXE0M3VXSEw0T0dtUVZJSFg5UmtDNzVNU2hTd000NXhVYkgzbkR5YWEw?= =?utf-8?B?YlhPODMzcFZJNEF0OWtoalRvNFRTa0pFcC9XWG4wSE5CVXdyV204ZmlCTG85?= =?utf-8?B?OHNDZ2xkWWhTanNKM1VjVndoam9FdVVpRUlTdHBBZGJpeUhDeC9aQktEN1RG?= =?utf-8?B?QWhRSkRFcFZEcGFDUDNrODVJMUl5RHE0OXd6VjU4dWpyUGxGVks3ZnBOV3Bz?= =?utf-8?B?cnZYV2hRV2REMkNoakVDTm96NmxGWllOdzRiOUJIUzFLNTRBaENIQ1I2Y1BS?= =?utf-8?B?TVFKNWxHRUtvRzdLUWVQT2FJcnJvL1cwYXhaNVd4bWZTRTdyMzlkbXNEWkxp?= =?utf-8?B?WklwbEFWWjZ5OTlqK05BNnVzMGJsWVlaU3J2Zkk4aVg2T1pHQlVWV1hSL3JH?= =?utf-8?B?Vm00UzB4ZkNBYWlJRVpGVWRIc0tETmxDdG9wdjJzeXpOZGxvQUtKWmQvK0NB?= =?utf-8?B?QlNKTG9IeFpVZ2pSM1FGTXMrdXpOUEZBTlh3WFZhWFNJMG5xV0dmeDlYRlFs?= =?utf-8?B?ZDl5SGcxVDFuYWNOQktxTTU5OHB3L3NGSC9aZDR1MFJVeUNwbGd0NFFBWnRI?= =?utf-8?B?K3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: JfzVagdXjrHA+6iVSLWbP2RtVvVnowkbhcR1HjPMvHgWXcy3tzHhJR9lxOjjOjXjsFeglE/WqXWL804BtiomeEg51NdNALsrlQeo0tTzJN15nPwGtX6YG2uRn76deFGYR4j1PHW/IxUlSQG4aQumk5q+dT+j5qs3UpfoOnVGyd2Xz3P8dgZgZBRVW1nY47G4xonqFcPvE0Oi8CtoVFDtgOp0ytsCYgO6fMrmNmA4V8peq3KdRqFSLBx4FCwivrRe2Ki3hZ+EvzxVR/d0JhtcL1FzNr6dfq6VVnLFd4Ip3YVI4V8vwGGzqp6RrLsWcE3q09HFSSShfPKN7WfSJ6oYy8bfP4/YnQVvvjsaqI6nJHV9izAxg4uQ1XHDSSspO5RlSZ6x/yp4xySg8h/sdyLXyNct8cBLV+zkKtp5tuGpDleRilf0gn/T86wfbaoBZYs2zHFZNN0Z239/Advqvk4ycuogfFQc/uSOrOyUbDze8ppUL7ocXz7tUXBPgTdQCMLBPQiHu5mKYWxNX6ncfk6NBCfhqgeU2SYMydGZcjSp6g0EP6KXAdvUM27NreKz2yUdpi3jPNHyfEn+P6I6FQ62HhRCCLCJN4Wd7VLM6x1u2IFDsnrB4M3Qipa/7MW0uyLEX22EmZ69cY/zmxGdntqOo5Z+8lZuYE35LuCNVxWOyRhgPRZwF+rSl1dINHhH0HblL8MTDuD2Zojc8gGuo5+QCoemZSIVXvPWblUm66eNlhAzkzctLTje3fRqXwZsepE4hjSDZyfrJRjzxNKnIfRw9coVlcMU9AvgHzdhD76TObzXNPpJ+5LRHxVDuBhHiSTA7WP6Jc4n4IlxdExRO2fenDJed6VXth9kLzNpwIPs/H6SzgkMhDea6sFVPF6fKKHdoZCWWGy778OW9mBpmfSBWw== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f96a6771-e4cb-4f87-dca0-08db97423fa5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:31:39.7506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OpV09CZb7Z3RoxxvL+oddpGmw046M2izzS6Rc7/w4hw7sDWjl8+oIFNqQOgojLtK/F/KTIK/Mikik93c0tAz9apcmsR9G2UH7OsRKAkULC8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR03MB7438 On 04/08/2023 3:11 pm, Federico Serafini wrote: > Give a name to unnamed parameters to address violations of > MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with > named parameters"). > Keep consistency between object and function declarations thus > addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an > object or function shall use the same names and type qualifiers"). > Replace the occurrences of bool_t with bool. > > No functional change. > > Signed-off-by: Federico Serafini > --- > xen/arch/x86/cpu/common.c | 6 +++--- > xen/arch/x86/include/asm/processor.h | 16 ++++++++-------- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c > index cfcdaace12..5f29148416 100644 > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -26,11 +26,11 @@ > > bool __read_mostly opt_dom0_cpuid_faulting = true; > > -bool_t opt_arat = 1; > +bool opt_arat = 1; > boolean_param("arat", opt_arat); I see this has been committed, but you do realise you've created a new violation of 8.3 by failing to change the declaration of opt_arat to be bool ? Please everyone be more careful.  There is an enormous amount of MISRA churn, and it's hard enough to deal with this when the patches are correct. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:40:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578341.905790 (Exim 4.92) (envelope-from ) id 1qSzWd-0002od-8o; Mon, 07 Aug 2023 12:39:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578341.905790; Mon, 07 Aug 2023 12:39:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzWd-0002oW-5m; Mon, 07 Aug 2023 12:39:55 +0000 Received: by outflank-mailman (input) for mailman id 578341; Mon, 07 Aug 2023 12:39:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzWb-0002oQ-HK for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:39:53 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e143cf6-351f-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 14:39:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9C4115C00CA; Mon, 7 Aug 2023 08:39:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 07 Aug 2023 08:39:46 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 08:39:43 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e143cf6-351f-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691411986; x=1691498386; bh=xbrcN9ni6V/ifhXltJx9M+NEPI6gpxZebc6 Dm84OTzY=; b=j0C1hsa8ZzeFo55dSHDvnbO5jIKhf+l24UMjDlDJ7PTwRkXMn0S QwAbrJm03KqUmxPXezMgkK8b2gAhRFgZw26fiKOKwvWfskmksJWMETVcsXqXzaxj yEtvVSukT4Jd/Po1peBO3trw6J9oavv1sv7vY5rDiIA1Cmhuq3zFekNGZXRV5QSW Eef5Z8Qd/e5WOfRtl1vyElMVAtnW2NIKhje8DtUwnIBzNXCq4rK9Cs+VQgaVO+WO OrsGDFgXnEmvM7OEAGu6gve8ulu5Xg2oBRmUU+DDH4ypGdIoUeeTrCnAs27BPb71 eSfVj/jKNPVTQGjpPd1p3EpkUBeWBoEk4hw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691411986; x=1691498386; bh=xbrcN9ni6V/if hXltJx9M+NEPI6gpxZebc6Dm84OTzY=; b=KoNIZHOsnnXtiX0Hs2uhpCzM1+iIF 6GY6LkOBcVN4SkAO3FacHJ7T/TGm4Dg3cyX4+2il4iFLjBO11sG6aYg0iNdd6K3n SXVOU1PK0V8cQ54qlY1BAJinjKx84Xq8iDiFR5jNVqzEpnDY61F2/atxUwlCKLaY r5WNfbaJOgqGwM0MXCKSfI+mmKum4bEcLZo548QyIcUGlkQpZkcWQo6J6Lo3jGgI vXPz71WUAV+Q/0Cn+MtgdD2vvYpVavkXRwke/6KF51XQIjqFZ4edjSoyCbIc4Aka w7RYLJF2QE0puQZDa7icu5MHdLczKC+2NNKFBd5u3NqXgVYVh0nHuIJrg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeeftdefudeltdevhfehkeefhfeutdfhffdugeetffdv gfehfeekhfetgedvuefggfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhimhhonhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <0882e0bd-b1c6-91c9-1ccc-d96e012e4f9a@invisiblethingslab.com> Date: Mon, 7 Aug 2023 14:39:28 +0200 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information To: Jan Beulich Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Liguori , xen-devel@lists.xenproject.org References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> <5fedd7c0-862e-d7c6-431d-6478ae1960b9@suse.com> Content-Language: en-US From: Simon Gaiser In-Reply-To: <5fedd7c0-862e-d7c6-431d-6478ae1960b9@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------REdQ0Uf83wSfWFMIfXj0tc00" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------REdQ0Uf83wSfWFMIfXj0tc00 Content-Type: multipart/mixed; boundary="------------p7HEWvjRNGVEGKLy0KR00SiA"; protected-headers="v1" From: Simon Gaiser To: Jan Beulich Cc: Wei Liu , KarimAllah Ahmed , Andrew Cooper , =?UTF-8?Q?Jan_H=2e_Sch=c3=b6nherr?= , Matt Wilson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Anthony Liguori , xen-devel@lists.xenproject.org Message-ID: <0882e0bd-b1c6-91c9-1ccc-d96e012e4f9a@invisiblethingslab.com> Subject: Re: [Xen-devel] [PATCH v2 04/23] x86: Don't use potentially incorrect CPUID values for topology information References: <1515356919-922-1-git-send-email-aliguori@amzn.com> <1515356919-922-5-git-send-email-aliguori@amzn.com> <5fedd7c0-862e-d7c6-431d-6478ae1960b9@suse.com> In-Reply-To: <5fedd7c0-862e-d7c6-431d-6478ae1960b9@suse.com> --------------p7HEWvjRNGVEGKLy0KR00SiA Content-Type: multipart/mixed; boundary="------------Y0Bpwe3jpar1IaqWoKfUGww7" --------------Y0Bpwe3jpar1IaqWoKfUGww7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jan Beulich: > On 07.08.2023 11:58, Simon Gaiser wrote: >> Jan Beulich: >>> On 07.08.2023 10:18, Simon Gaiser wrote: >>>> Anthony Liguori: >>>>> From: Jan H. Sch=C3=B6nherr >>>>> >>>>> Intel says for CPUID leaf 0Bh: >>>>> >>>>> "Software must not use EBX[15:0] to enumerate processor >>>>> topology of the system. This value in this field >>>>> (EBX[15:0]) is only intended for display/diagnostic >>>>> purposes. The actual number of logical processors >>>>> available to BIOS/OS/Applications may be different from >>>>> the value of EBX[15:0], depending on software and platform >>>>> hardware configurations." >>>>> >>>>> And yet, we're using them to derive the number cores in a package >>>>> and the number of siblings in a core. >>>>> >>>>> Derive the number of siblings and cores from EAX instead, which is >>>>> intended for that. >>>>> >>>>> Signed-off-by: Jan H. Sch=C3=B6nherr >>>>> --- >>>>> xen/arch/x86/cpu/common.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >>>>> index e9588b3..22f392f 100644 >>>>> --- a/xen/arch/x86/cpu/common.c >>>>> +++ b/xen/arch/x86/cpu/common.c >>>>> @@ -479,8 +479,8 @@ void detect_extended_topology(struct cpuinfo_x8= 6 *c) >>>>> initial_apicid =3D edx; >>>>> =20 >>>>> /* Populate HT related information from sub-leaf level 0 */ >>>>> - core_level_siblings =3D c->x86_num_siblings =3D LEVEL_MAX_SIBLI= NGS(ebx); >>>>> core_plus_mask_width =3D ht_mask_width =3D BITS_SHIFT_NEXT_LEVE= L(eax); >>>>> + core_level_siblings =3D c->x86_num_siblings =3D 1 << ht_mask_wi= dth; >>>>> =20 >>>>> sub_index =3D 1; >>>>> do { >>>>> @@ -488,8 +488,8 @@ void detect_extended_topology(struct cpuinfo_x8= 6 *c) >>>>> =20 >>>>> /* Check for the Core type in the implemented sub leave= s */ >>>>> if ( LEAFB_SUBTYPE(ecx) =3D=3D CORE_TYPE ) { >>>>> - core_level_siblings =3D LEVEL_MAX_SIBLINGS(ebx)= ; >>>>> core_plus_mask_width =3D BITS_SHIFT_NEXT_LEVEL(= eax); >>>>> + core_level_siblings =3D 1 << core_plus_mask_wid= th; >>>> >>>> >>>> On the i5-1135G7 (4 cores with each 2 threads) I'm currently testing= on >>>> I noticed that this changes leads to core_level_siblings =3D=3D 16 a= nd >>>> therefore x86_max_cores =3D=3D 8. If read from ebx like before this = change >>>> and what Linux is still doing [1] it reads core_level_siblings =3D=3D= 8 (as >>>> expected?). >>>> >>>> What's the expected semantic here? If it's to derive the actual numb= er >>>> of siblings (and therefore cores) in a package as the commit message= >>>> suggest, the new code can't work even ignoring the example from my t= est >>>> system. It will always produce powers of 2, so can't get it right on= a >>>> system with, say, 6 cores. >>> >>> The only use of the variable in question is in this statement: >>> >>> c->x86_max_cores =3D (core_level_siblings / c->x86_num_siblings= ); >>> >>> Note the "max" in the name. This is how many _could_ be there, not ho= w >>> many _are_ there, aiui. >> >> I'm indeed not quite sure on the intended semantic, hence the question= >> (although it's not clear to me what case that "could" would cover here= ). >=20 > "Could" covers for a number of reasons why APIC IDs may not be contiguo= us. > Consider a 6-code system: The APIC IDs need to cover for at least 8 the= re. >=20 >> It doesn't have to be identical but Linux says for it's version of the= >> variable: >> >> The number of cores in a package. This information is retrieved vi= a >> CPUID. >> >> And if I look at it's usage in set_nr_sockets in Xen: >> >> nr_sockets =3D last_physid(phys_cpu_present_map) >> / boot_cpu_data.x86_max_cores >> / boot_cpu_data.x86_num_siblings + 1; >=20 > This validly uses the field in the "max" sense, not in the "actual" one= =2E I see, both cases cover APIC IDs not just numbers of logical CPUs. Thanks for the explanation and the pointer from Andrew in his response. I just had noticed the, to me, unexpected value, while debugging something. But based on this explanation things are actually working as intended here. (The actual problem I was looking for it turned out to be [1].) [1]: https://lore.kernel.org/xen-devel/7f158a54548456daba9f2e105d099d2e5e= 2c2f38.1691399031.git.simon@invisiblethingslab.com/ >> It seems to be also be used in this meaning. At least on my test syste= m >> I get last_physid =3D=3D 7 (as I would have expected for 8 logical cpu= s). So >> dividing this by the 4 (number of cores) and 2 (threads per core) is >> what I think was intended here. >=20 > Would you mind providing raw data from your system: Both the raw CPUID > output for the leaf/leaves of interest here and the APIC IDs of all > threads? Sure: =46rom attached patch: (XEN) dbg smp_processor_id() =3D 0 (XEN) dbg get_apic_id() =3D 0 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0 (XEN) dbg smp_processor_id() =3D 1 (XEN) dbg get_apic_id() =3D 1 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x1 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x1 (XEN) dbg smp_processor_id() =3D 2 (XEN) dbg get_apic_id() =3D 2 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x2 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x2 (XEN) dbg smp_processor_id() =3D 3 (XEN) dbg get_apic_id() =3D 3 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x3 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x3 (XEN) dbg smp_processor_id() =3D 4 (XEN) dbg get_apic_id() =3D 4 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x4 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x4 (XEN) dbg smp_processor_id() =3D 5 (XEN) dbg get_apic_id() =3D 5 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x5 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x5 (XEN) dbg smp_processor_id() =3D 6 (XEN) dbg get_apic_id() =3D 6 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x6 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x6 (XEN) dbg smp_processor_id() =3D 7 (XEN) dbg get_apic_id() =3D 7 (XEN) dbg cpuid_count(0xb, SMT_LEVEL) =3D 0x1, 0x2, 0x100, 0x7 (XEN) dbg cpuid_count(0xb, 0x1) =3D 0x4, 0x8, 0x201, 0x7 =46rom the MADT table: [02Ch 0044 1] Subtable Type : 00 [Processor Local APIC] [02Dh 0045 1] Length : 08 [02Eh 0046 1] Processor ID : 00 [02Fh 0047 1] Local Apic ID : 00 [030h 0048 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [034h 0052 1] Subtable Type : 00 [Processor Local APIC] [035h 0053 1] Length : 08 [036h 0054 1] Processor ID : 01 [037h 0055 1] Local Apic ID : 02 [038h 0056 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [03Ch 0060 1] Subtable Type : 00 [Processor Local APIC] [03Dh 0061 1] Length : 08 [03Eh 0062 1] Processor ID : 02 [03Fh 0063 1] Local Apic ID : 04 [040h 0064 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [044h 0068 1] Subtable Type : 00 [Processor Local APIC] [045h 0069 1] Length : 08 [046h 0070 1] Processor ID : 03 [047h 0071 1] Local Apic ID : 06 [048h 0072 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [04Ch 0076 1] Subtable Type : 00 [Processor Local APIC] [04Dh 0077 1] Length : 08 [04Eh 0078 1] Processor ID : 04 [04Fh 0079 1] Local Apic ID : 01 [050h 0080 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [054h 0084 1] Subtable Type : 00 [Processor Local APIC] [055h 0085 1] Length : 08 [056h 0086 1] Processor ID : 05 [057h 0087 1] Local Apic ID : 03 [058h 0088 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [05Ch 0092 1] Subtable Type : 00 [Processor Local APIC] [05Dh 0093 1] Length : 08 [05Eh 0094 1] Processor ID : 06 [05Fh 0095 1] Local Apic ID : 05 [060h 0096 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [064h 0100 1] Subtable Type : 00 [Processor Local APIC] [065h 0101 1] Length : 08 [066h 0102 1] Processor ID : 07 [067h 0103 1] Local Apic ID : 07 [068h 0104 4] Flags (decoded below) : 00000001 Processor Enabled : 1 Runtime Online Capable : 0 [06Ch 0108 1] Subtable Type : 00 [Processor Local APIC] [06Dh 0109 1] Length : 08 [06Eh 0110 1] Processor ID : 08 [06Fh 0111 1] Local Apic ID : FF [070h 0112 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [074h 0116 1] Subtable Type : 00 [Processor Local APIC] [075h 0117 1] Length : 08 [076h 0118 1] Processor ID : 09 [077h 0119 1] Local Apic ID : FF [078h 0120 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [07Ch 0124 1] Subtable Type : 00 [Processor Local APIC] [07Dh 0125 1] Length : 08 [07Eh 0126 1] Processor ID : 0A [07Fh 0127 1] Local Apic ID : FF [080h 0128 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [084h 0132 1] Subtable Type : 00 [Processor Local APIC] [085h 0133 1] Length : 08 [086h 0134 1] Processor ID : 0B [087h 0135 1] Local Apic ID : FF [088h 0136 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [08Ch 0140 1] Subtable Type : 00 [Processor Local APIC] [08Dh 0141 1] Length : 08 [08Eh 0142 1] Processor ID : 0C [08Fh 0143 1] Local Apic ID : FF [090h 0144 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [094h 0148 1] Subtable Type : 00 [Processor Local APIC] [095h 0149 1] Length : 08 [096h 0150 1] Processor ID : 0D [097h 0151 1] Local Apic ID : FF [098h 0152 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [09Ch 0156 1] Subtable Type : 00 [Processor Local APIC] [09Dh 0157 1] Length : 08 [09Eh 0158 1] Processor ID : 0E [09Fh 0159 1] Local Apic ID : FF [0A0h 0160 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 [0A4h 0164 1] Subtable Type : 00 [Processor Local APIC] [0A5h 0165 1] Length : 08 [0A6h 0166 1] Processor ID : 0F [0A7h 0167 1] Local Apic ID : FF [0A8h 0168 4] Flags (decoded below) : 00000000 Processor Enabled : 0 Runtime Online Capable : 0 If you wanted something else or need more, just let me know. Simon --------------Y0Bpwe3jpar1IaqWoKfUGww7 Content-Type: text/x-patch; charset=UTF-8; name="detect_extended_topology-dbg.patch" Content-Disposition: attachment; filename="detect_extended_topology-dbg.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUvY29tbW9uLmMgYi94ZW4vYXJjaC94ODYv Y3B1L2NvbW1vbi5jCmluZGV4IGNmY2RhYWNlMTIuLjhhMzVhNWFmZmUgMTAwNjQ0Ci0tLSBh L3hlbi9hcmNoL3g4Ni9jcHUvY29tbW9uLmMKKysrIGIveGVuL2FyY2gveDg2L2NwdS9jb21t b24uYwpAQCAtNjI0LDcgKzYyNCwxMSBAQCBib29sIGRldGVjdF9leHRlbmRlZF90b3BvbG9n eShzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAJaWYgKCBjLT5jcHVpZF9sZXZlbCA8IDB4YiAp CiAJCXJldHVybiBmYWxzZTsKIAorCXByaW50aygiZGJnIHNtcF9wcm9jZXNzb3JfaWQoKSA9 ICV1XG4iLCBzbXBfcHJvY2Vzc29yX2lkKCkpOworCXByaW50aygiZGJnIGdldF9hcGljX2lk KCkgPSAldVxuIiwgZ2V0X2FwaWNfaWQoKSk7CisKIAljcHVpZF9jb3VudCgweGIsIFNNVF9M RVZFTCwgJmVheCwgJmVieCwgJmVjeCwgJmVkeCk7CisJcHJpbnRrKCJkYmcgY3B1aWRfY291 bnQoMHhiLCBTTVRfTEVWRUwpID0gJSN4LCAlI3gsICUjeCwgJSN4XG4iLCBlYXgsIGVieCwg ZWN4LCBlZHgpOwogCiAJLyogQ2hlY2sgaWYgdGhlIGNwdWlkIGxlYWYgMHhiIGlzIGFjdHVh bGx5IGltcGxlbWVudGVkICovCiAJaWYgKCBlYnggPT0gMCB8fCAoTEVBRkJfU1VCVFlQRShl Y3gpICE9IFNNVF9UWVBFKSApCkBAIC02NDEsNiArNjQ1LDcgQEAgYm9vbCBkZXRlY3RfZXh0 ZW5kZWRfdG9wb2xvZ3koc3RydWN0IGNwdWluZm9feDg2ICpjKQogCXN1Yl9pbmRleCA9IDE7 CiAJZG8gewogCQljcHVpZF9jb3VudCgweGIsIHN1Yl9pbmRleCwgJmVheCwgJmVieCwgJmVj eCwgJmVkeCk7CisJCXByaW50aygiZGJnIGNwdWlkX2NvdW50KDB4YiwgJSN4KSA9ICUjeCwg JSN4LCAlI3gsICUjeFxuIiwgc3ViX2luZGV4LCBlYXgsIGVieCwgZWN4LCBlZHgpOwogCiAJ CS8qIENoZWNrIGZvciB0aGUgQ29yZSB0eXBlIGluIHRoZSBpbXBsZW1lbnRlZCBzdWIgbGVh dmVzICovCiAJCWlmICggTEVBRkJfU1VCVFlQRShlY3gpID09IENPUkVfVFlQRSApIHsK --------------Y0Bpwe3jpar1IaqWoKfUGww7-- --------------p7HEWvjRNGVEGKLy0KR00SiA-- --------------REdQ0Uf83wSfWFMIfXj0tc00 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTQ5gIACgkQkO9xfO/x ly8GLw/+L6gzs2QJTuthxUS/32txoUHkgKJrZQRh9ZUsHrPVFNYjedTGJ42XlxIe Heh+82JuN3PM3xgAxwJPwnYY7AvPunn0L/CZJ/r8wT/hwRozm9UePuqYbLnAbovp u9s5mdCTK54fr3/6qPFd3JqUcQ/RsjwxMgLVu6VxKAUGs+ZhjqOw6EHTlgAKblP8 KUm9Hh6T4TmAJJOlwDYU48OCZtPs9WTEL05R5kFBLDx1CpHvnIEooyD7owulj/eI AJg2BDswLu+gatVHmlgRY3a/XtTFYPwq4Mm7u1ABtev8CKSeJc7nIwruvTxdTd8B FhbWvWaMSBJRsb0AGk/kghiaqO0YNFxXIPqiXqRhDqvxAeFHTTH/B2dKqIb1XB1k xGgdm+thhrw+m0SzC7D8JT8gmN/IV2krtwOmrnjOa5PFeJ8cKSouSN9zEO7UdCjK M6ot0jzBU7SOWQMmZ5mVVC2qQSURZ+t9OqUCYjjQmCpszSzwD++b6kezKXQ2M4lF 4JDfazzC71s7BCy3/h6eQ4aFd4soC5VaEeocDyPyoj7KIkctYgH9XER7lmviH2kT m4ouiB+oXvr4IUeq1ZTUOHnGuNZ0TSUu6j0qro9B16wWQBGPJ0OYXEhelOBGD/mY NHCA3P/2lsG2L/C7OXeLqefkjUdE8yjXMAlfisaE+NozkKAJ9G0= =cmOS -----END PGP SIGNATURE----- --------------REdQ0Uf83wSfWFMIfXj0tc00-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:41:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:41:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578348.905801 (Exim 4.92) (envelope-from ) id 1qSzYC-0004GS-P8; Mon, 07 Aug 2023 12:41:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578348.905801; Mon, 07 Aug 2023 12:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzYC-0004GJ-MK; Mon, 07 Aug 2023 12:41:32 +0000 Received: by outflank-mailman (input) for mailman id 578348; Mon, 07 Aug 2023 12:41:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzYB-0004GB-7a for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:41:31 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20602.outbound.protection.outlook.com [2a01:111:f400:7e89::602]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9b5b17e-351f-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 14:41:28 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CYXPR12MB9319.namprd12.prod.outlook.com (2603:10b6:930:e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug 2023 12:41:21 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 12:41:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9b5b17e-351f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YvJHcgKgSJO7iqUWJxQAprIpYpxAbVgQ3W8u1ZDrZwoLXu0WcKnY7s6FGwJmwr0Yb/IXEVWXryyp9JuFd0pNc/6/zPVtBP/9D6tAps4nNT29ue9mZb5vOkgmxRQUMqI9n+J6KYw1kDRVYS2ZtxstqJz4X4GESWSkHJ0ymw0nVC9LLDKCrlj1eB7RNumbGB4vxSw3W8+i+8UiLjKNG2C1CZYcSL3pzRtoDXHWOGLgSCs899132P7WduItF9gpcfn9CzoIpgQIicIyaJdgKBml8qOtuKlFI7nK3tG27Q11cSiqEyWievQF/BScnNMmVikmvBWOJPNc2vrw7nLPUaicJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02CKm/SnpetlFdMVq5ZRrNDcvVOyMucAFhXy8uL9PIQ=; b=SiidKtFBA08WylCniIKv/hwlZld51GFl68WG7CU8e3fGtmBAO5kMoGa9oIQcdzyRX0VNJm/gHzMKZ/V93BZ0HbaKxNBeIARXf5GFWUr3j0a/054oyjs/TvAXaK0/YCsWxqPbuFEJNdsiq/ou0QIk/UTCy6ihyXrf+N9ty+yuqRThMuUmz1PivaPizPG4PY1uqgqS9/2TZFhvEOom0LeSm0PsijXt617so39HiZ7dTWbDcL50wBoyu0bIh2FtpuqyVCKLoEIFe5GqLJ7MbBjkA6vsEdwcLj5r8ojco+gkjUKGEzS0IPFJcYc+Z+puAyVTfcFjLTc8I7STJEXjJ2XdOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02CKm/SnpetlFdMVq5ZRrNDcvVOyMucAFhXy8uL9PIQ=; b=w46P5mosIAQTIyGdeqB40F1iOJ8771TG+Us7DYMYELd9nRWVb4V+mTxKV89TuHJqPQ4X9d1ifo1CwOJ0LxAxF4bqdn9S4cb1F3/d/Z1m2JxGYai7MJXDcfKYStzvAcNq/kgqS15T/FOvr0Qwtb87Bm7/9t5ZMxAYbEwDNsWtEOI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <292660bf-0f12-28d0-c7bd-2b870ed143e3@amd.com> Date: Mon, 7 Aug 2023 13:41:16 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm To: Julien Grall , Henry Wang , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> <79de42d1-35db-79b1-da2a-f08a72fa53d7@amd.com> <1366a5b1-4bf4-20d6-73a7-ad1735ab8c10@amd.com> <4dadcb55-1c94-4b57-a7fd-32460f4d9604@xen.org> From: Ayan Kumar Halder In-Reply-To: <4dadcb55-1c94-4b57-a7fd-32460f4d9604@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PA7P264CA0328.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:39a::21) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CYXPR12MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 145c4517-8ec6-47ac-d109-08db97439baa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WQXDGrP3JoKv97UYhzSSUCgbACzKYQF7TYN818QFP1BkOHILFycrMqyAC2JvRAhJbiWBI7yUJGm3YgWk3ekLtg5u5GphNMnlEfdvwFpkTpJNcl//Z8bcUfEgIwR6piPJMkUZdDSeg6U4Ckl3HoElMoGvXIz+ncNoCzIFSdhwV6blAGvu59PzJQjX5eODY84SNrXETCuMM1Tib9ItPtDByw3AUROas4dTWkt52mNzwpdRnBEpSeaCugKSYWaSBa1d3y5JsaOv1mkbEDCpkXjhreuv9zTc5pWRe5jCsF2A/Xd14TvzXPzEEeFV+OYdMFbnVUYIUITTErMIA9DAGBGd3h962qXL0nRsW9MenQeQtlxjQiiTyiQ9xlOY+yqsNA07NUmYNyoqM+Qmos7LHBTlr18KHgKxZGjR9er6S3+02LEADpcOwt9XI3USDgI//FwVrzw9u6gUon76qEMV916da96wElSKw2Giyvj543SCkoHmvXpMFiYNP+h6DIuzB29sCcC2kturzvj7a23VXVR6R3CWF9lw8vh6CB94GZyIzxozxBc+3W6rwzkJxrvic593T0dTTNW5AtRROSj8AQfB+rl+dr3rY/bMHKX11Yr7X2xz7QTaFEWQyWG1Shaz01zo1BLQiHU+tOI7v2nzsNjvwA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(451199021)(1800799003)(186006)(2616005)(6486002)(6666004)(6512007)(966005)(478600001)(31696002)(26005)(36756003)(6506007)(53546011)(41300700001)(316002)(5660300002)(8936002)(8676002)(54906003)(110136005)(38100700002)(4326008)(2906002)(66476007)(66556008)(66946007)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnNCc2daRXVPazNlYlZraFNkQVBwYUxNZFhUMWxUcCs5TFZFTUt1aXE4RlNw?= =?utf-8?B?TWhxRjVIQ0RPQllHNEtkM3ZtU1VhanJrallLNXJEZTFVd3hmcXhUUit2TWRE?= =?utf-8?B?QVZGWEJ6NFkrb1hsYitScnh3OVA0bHpWT0Jyei9xUUJYR2QwL1RCR0E5TXV4?= =?utf-8?B?S2J1eUlHMHZuVkVFOVFOQnZLdXBwZUI3QkdaWHRDME5UMkJ5bGVkNWhYTGQx?= =?utf-8?B?Qm9MaGJ4K25rUDRYNjNCQTUrek11QS9KZ21SMytJSDl3OUVwbi9ORjZiUktq?= =?utf-8?B?MHE5UVVidVZCOElTWUNMSTlONjl4NjI2RjBwV0VJZDFDc1RkRzJCZWJkbjJ0?= =?utf-8?B?bE0rTnlrbW1VUGNhMDF0VkJNWUk2bGZzdHN6YUZxa21ERzU5QlJ4RnlwY0xJ?= =?utf-8?B?cFVkQ0pwZFNwcEErRXRJZC8zclBLVVFVVnFld2NYNXo0RXdmUzdSajlGcjlY?= =?utf-8?B?cytTMVQzUFk0eDRuT0ZKTUwxakhZNVNNTnd5Nmo4YTkwbCsxKzMySTZIbFJ6?= =?utf-8?B?Q08wM2MyK2FKTUJ6Mk1Pd1ZjaXNEL0NxT01qUDQ3R2NyZS8vRkMrMzdWa1Rx?= =?utf-8?B?YlZCc3M4MFBFWlpKNXZ3OEV5bktuaWtMeEh2ZXBuUi9rS3o3SXRwT2ZYSm5h?= =?utf-8?B?Y0xRTFc1ejBZUmhzQXJDTmN0UW4wWkpyeVd1QmNIVGhQTFBidGpxbzcyRTFC?= =?utf-8?B?VlpEWHo4dThFTThVNDBaUHh4TW5vTmpGUmlWMzd5SExZTm5wc0J4OUlYWTcr?= =?utf-8?B?WnRvei93bytHNnNvS2p2UWFOeFZUdFJDeTZjbGZpRTd1SUp2UGpPZ2luV1lZ?= =?utf-8?B?aWVseThwUmc1cElwdFFZa2ZxNGgxS3N2dm5vUnZLa2kyYTlocDg2bDh0K1JB?= =?utf-8?B?U2FEMUN1TVRFSk9nSkFoWVhlZFNJNUNXbXFxVXBvUVNyNGEyRXJ2NnZDdVIv?= =?utf-8?B?SEcyWWhLWTN4dlRtbVdndU0wVWs1aUZ4T1BmQ2ZJZlpKdHUvbVR1MExZcGxk?= =?utf-8?B?dHIyVld6TUJLY3MrN0didTVhYXNscTgwc09vcXB5N0RtQkR1ZytYZ0ExQnJ0?= =?utf-8?B?cUFqVDF2azR4Nm9JU3RSNVVRQ3JsWDlhZ0RERm5CUVRwRlhJOFNHVitQakFv?= =?utf-8?B?cDBGNExNaURWOUNpR0VrNjZhZVlrU0pCSjJ1OEcvcE9YbkNJQ1BPM0NyNDNM?= =?utf-8?B?YWZFdjA2TnhKdCtaS1lLcUFzL2FrK3JGZnBOTHlWSUwyMjgyUWh5RTFMQlA4?= =?utf-8?B?eUJXN2ZPcDVBbXNvNHFoNC9HZDBDUnBCaEJsNlp5am5VZENiTU12YUhVdTdC?= =?utf-8?B?NXRiWUlOU25TOGpkN3VGUkxPUjNHM1hMRVpmTkdNcnJMUTNieTJjVkI0bjB6?= =?utf-8?B?T2pVTFV6RXA1M1luaU5MeVAxTklNM3R2Z2FVYmEwZ0RiZDVxZVRlVFNWSHJO?= =?utf-8?B?Nm0rL2lZY3l4b2RGK3RDcml2UzZ4SWFqNTJPeUtLajRjYXMvVmZhdXlxcWdU?= =?utf-8?B?M1ErSndvOCs0aFltV2tkekhlT0ZhMkdJUVpvN1B0Qk5QdldMcXV5bmF4VHdB?= =?utf-8?B?Qy95aCtmRkgxTTVNMEFINFVON0w1V0dNM3dzcmV1UHNtVTdKSGZLKzBUdEw0?= =?utf-8?B?NTltbHRRL1RzSmxMSG81bVpuL29ScjF6MGlzVkM3dVAxVWJ4M1FCTEtHZ2Rl?= =?utf-8?B?amRBdjhEclZDdmp3QUg2SThNOVM3VHlCQ0FsOFRUekRzWkRld0VpTXErTGIx?= =?utf-8?B?bmF2VFpSbUVBY0x1ajdFZWJGRUVNc1NYYzFYQnNSbmFHYzR6SEw2Sm1uMkw4?= =?utf-8?B?bVZYbWlKMklFZGRtTkYrYTJlWTd6MDlYakpRT09TbURWTzZCVlJUa3ppeEh5?= =?utf-8?B?ZFhqbU5GYVVsZktaVThlM096cmpkYWJiWGRFaStkSWtPUnI5S2VjdkVRbTd0?= =?utf-8?B?QS9FZkk4dmNrWW54MmNZa3dIWTh3RkQvcHZCYWxKY1ZXZzRHUm5IbytEVFpz?= =?utf-8?B?MDhRSTRMNzlBb3Z0djY3UGthRHMwdk9KaEdmUTg4dFJYQ0htcGQ1ZWUwMVE5?= =?utf-8?B?SDY1TU8zTEZBK3BMa2xXbkNHUExrcmxoSmJVVk0vVHhaSXVtYlBDUllMblVr?= =?utf-8?Q?eqvBPBSzJjs9kpdXibMucWzE+?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 145c4517-8ec6-47ac-d109-08db97439baa X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:41:23.5942 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y5CE38ibifqbNUKeYKfmUWQcPr8wPFRC76uOAqh8ZqagoBXBFmIY1kLGslwTrwUhf9BHnBWYTJJgBT712Rw76Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9319 Hi Julien/Henry, Thanks for the explanation. On 07/08/2023 12:47, Julien Grall wrote: > > > On 07/08/2023 12:43, Ayan Kumar Halder wrote: >> >> On 07/08/2023 12:35, Henry Wang wrote: >>> Hi Ayan, >>> >>>> -----Original Message----- >>>> Hi Henry, >>>> >>>>> At the moment, on MMU system, enable_mmu() will return to an >>>>> address in the 1:1 mapping, then each path is responsible to >>>>> switch to virtual runtime mapping. Then remove_identity_mapping() >>>>> is called on the boot CPU to remove all 1:1 mapping. >>>>> >>>>> Since remove_identity_mapping() is not necessary on Non-MMU system, >>>>> and we also avoid creating empty function for Non-MMU system, trying >>>>> to keep only one codeflow in arm64/head.S, we move path switch and >>>>> remove_identity_mapping() in enable_mmu() on MMU system. >>>>> >>>>> As the remove_identity_mapping should only be called for the boot >>>>> CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and >>>>> enable_secondary_cpu_mm() for secondary CPUs in this patch. >>>>> >>>>> Signed-off-by: Wei Chen >>>>> Signed-off-by: Penny Zheng >>>>> Signed-off-by: Henry Wang >>>> With two comments >>>> >>>> Reviewed-by: Ayan Kumar Halder >>>> >>>> Tested-by: Ayan Kumar Halder >>> Thanks, and... >>> >>>>> +/* >>>>> + * Enable mm (turn on the data cache and the MMU) for secondary >>>>> CPUs. >>>>> + * The function will return to the virtual address provided in LR >>>>> (e.g. the >>>>> + * runtime mapping). >>>>> + * >>>>> + * Inputs: >>>>> + *   lr : Virtual address to return to. >>>>> + * >>>>> + * Clobbers x0 - x5 >>>>> + */ >>>>> +enable_secondary_cpu_mm: >>>> I will prefer "enable_secondary_cpu_mmu" as it is MMU specific. And >>>> ... >>> ...actually this as well as... >>> >>>>> +/* >>>>> + * Enable mm (turn on the data cache and the MMU) for the boot CPU. >>>>> + * The function will return to the virtual address provided in LR >>>>> (e.g. the >>>>> + * runtime mapping). >>>>> + * >>>>> + * Inputs: >>>>> + *   lr : Virtual address to return to. >>>>> + * >>>>> + * Clobbers x0 - x5 >>>>> + */ >>>>> +enable_boot_cpu_mm: >>>> prefer "enable_boot_cpu_mmu" as it is MMU specific as well. >>> ...this, are the name suggested by Julien in [1], so probably I will >>> stick >>> to these names, unless he would prefer the proposed names. I would >>> personally prefer the names that Julien suggested too, because from >>> the comments above these two functions, these functions not only >>> enable the MMU, but also turn on the d-cache, hence a more generic >>> name (using "mm"), is more appropriate here I guess. >>> >>> [1] >>> https://lore.kernel.org/xen-devel/c10bc254-ad79-dada-d5fb-9ee619934ffb@xen.org/ >> >> This is fine. My concern is minor. >> >> If this file is going to contain MPU specific logic as well in >> future, then suffixing a *_mmu might help to distinguish the two. > > For this series, it is quite important to look at the end result. In > this case, the MMU logic will be moved in its own file. > enable_boot_cpu_mm() and enable_second_cpu_mm() will be implemented > differently between the MMU and MPU to avoid #ifdeferay in head.S. Makes sense. I am happy with it. - Ayan > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:44:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:44:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578355.905811 (Exim 4.92) (envelope-from ) id 1qSzas-0004sD-6u; Mon, 07 Aug 2023 12:44:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578355.905811; Mon, 07 Aug 2023 12:44:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzas-0004s6-4C; Mon, 07 Aug 2023 12:44:18 +0000 Received: by outflank-mailman (input) for mailman id 578355; Mon, 07 Aug 2023 12:44:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzaq-0004rp-CJ for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:44:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1de9e286-3520-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 14:44:15 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 93B954EE0737; Mon, 7 Aug 2023 14:44:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1de9e286-3520-11ee-b27e-6b7b168915f2 Message-ID: <52e93c6b-376d-7f31-e319-c90de4588b6a@bugseng.com> Date: Mon, 7 Aug 2023 14:44:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [BUGGY] Re: [XEN PATCH] x86: Address violations of MISRA C:2012 and drop bool_t Content-Language: en-US, it To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Michal Orzel , Xenia Ragiadakou , Ayan Kumar Halder References: <2cd78bd0d39b36fe73e87cd1011658a54c2c729d.1691158092.git.federico.serafini@bugseng.com> <64ec2572-348a-2c6f-d354-2747659e4666@citrix.com> From: Federico Serafini Organization: BUGSENG srl In-Reply-To: <64ec2572-348a-2c6f-d354-2747659e4666@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/08/23 14:31, Andrew Cooper wrote: > On 04/08/2023 3:11 pm, Federico Serafini wrote: >> Give a name to unnamed parameters to address violations of >> MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with >> named parameters"). >> Keep consistency between object and function declarations thus >> addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an >> object or function shall use the same names and type qualifiers"). >> Replace the occurrences of bool_t with bool. >> >> No functional change. >> >> Signed-off-by: Federico Serafini >> --- >> xen/arch/x86/cpu/common.c | 6 +++--- >> xen/arch/x86/include/asm/processor.h | 16 ++++++++-------- >> 2 files changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c >> index cfcdaace12..5f29148416 100644 >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -26,11 +26,11 @@ >> >> bool __read_mostly opt_dom0_cpuid_faulting = true; >> >> -bool_t opt_arat = 1; >> +bool opt_arat = 1; >> boolean_param("arat", opt_arat); > > I see this has been committed, but you do realise you've created a new > violation of 8.3 by failing to change the declaration of opt_arat to be > bool ? > > Please everyone be more careful.  There is an enormous amount of MISRA > churn, and it's hard enough to deal with this when the patches are correct. > > ~Andrew I'm sorry, I noticed too late. I will submit a patch to address the new violations. -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:44:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:44:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578358.905821 (Exim 4.92) (envelope-from ) id 1qSzbC-0005JC-Ee; Mon, 07 Aug 2023 12:44:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578358.905821; Mon, 07 Aug 2023 12:44:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzbC-0005J5-BY; Mon, 07 Aug 2023 12:44:38 +0000 Received: by outflank-mailman (input) for mailman id 578358; Mon, 07 Aug 2023 12:44:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzbB-0004rp-0n for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:44:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20601.outbound.protection.outlook.com [2a01:111:f400:7e1b::601]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a2da328-3520-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 14:44:36 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8606.eurprd04.prod.outlook.com (2603:10a6:102:219::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 12:44:33 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 12:44:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a2da328-3520-11ee-b27e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNJnj7wyJtGM2Osd7XA4FzhNENXaOhbZeD7OPMgC5aHcy6ryHqgv5ONFKtHiBGSL6tUH2awXKP1XlunkHiqrHUfGLnf60Fc1lxTSx99TlFJKezPp6h1AjH7pYdZTalwDMLydq7ilSTQb7O29Z2LglP3cVwqizh5lubQKWwXIjFX2oD8p50SA7/A59jQDN5a0sB4CRRaKWzBfz5xjK/7OgpWxk+Q4sFlN7mFQtO8gGL2y2zkDVXwVIVfVwFBoEVZUms71K7mmfXCHwnJZiNjnpgBBNKRprRYDxHmUaOCIYmvoQIe3OxPFCR4OKJhrdn9lVVlDFUJBCccdv2THTGjUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3kMC6kOdnqVsG/Dilzf0A/0ussROHfjFtc2W89H0nh4=; b=c72LsioPg+QxTGBkqh6F8rxy+d2ahTAx5JCkkV+haTir6rhgrKFLNIYi6GVs8meqMJo72mxP6y5+dDTe0oIbVbt+uL+3TS8QwKYrKjXzn2xjLnI0rzMtdqqF/NmBYQa0OWewR6t0/j1lGQjKlTYE17O5GeBPvngPbvNrIg4YQNr8W76yRwmQE1ouYqFeZK0VLs3MlGo8JBCscKo3Bz3yY7YySfn891DovS1waZG1VgIX97O3+qAqzaDG4BVxPf34mp0GFwC9OxY7gJ1l6TvAhKnZ0poVzjmCbohJbc8+HFVxrc3GAQEyqL8QMuIMWg3dPpKocUcLGUzYPQtlUbgwtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kMC6kOdnqVsG/Dilzf0A/0ussROHfjFtc2W89H0nh4=; b=UBrbH5pDNLwF7Iz8KCDTNhuj953hxWhxO0LXkOhTin9kTUtOBTgM2U8wiUcaz8dr9B5P9GhJYw4LbLgja8M5WHouEx+IlczaXHjM7NaTWT6VSv8ouFu93Uzfypb8pxOnC84JrFq4N9d2zwEFnYL/Ny03FXA+rUFBwOBj9SwuDI1c3tQnVBWZ15JXu9fzLkEMzwGdF83QEybsIaMeI9jaD0MFW/vLiDE3Yik27VfA4edfQKVPC+4hYttbZSbR95zKJCAO6aqfei/AjZds9HiJlkDeeG3+8SsnJZ9TVGNX7AmftuldZ9IUDAoa/JGAu4q0xpldd0os+Juh9/utFs7D7A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f2772b3-ea3f-7f7b-1a28-7f288c9da7dd@suse.com> Date: Mon, 7 Aug 2023 14:44:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 1/4] x86/mce: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini References: <8a11baf39c140af9d5694298e5f1f0bf59ac0621.1691135862.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8606:EE_ X-MS-Office365-Filtering-Correlation-Id: 195a2520-ca91-4d6b-4622-08db97440cf3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sV1L+w5wjsLorIsKImM/z93sjgGOBt8HM9UcV1QXa7OfUwhD5+01FUuhocHtVkXUePMTS+ByshT7RBcT8D2TVoqVRYGq2INDj6gRDYtEj2U31k6Qy+WK/ZxK62r0Qs6R0QZ9LNdrrOICRyZT9cOvtQOX35ulPSeEDWUg99Rqu5FTfZ9+sVhGw01dzh6pr891DUe5d9emLag6fYKSVEd153eup21p5FNMz7WedJvtrgCkBzsK5I6JeaQwNj/6LOqilFLXg+cFelVkT4YvVolDjEFWxfjD5ZpuRTkSy7ckq6k668OpDuHiMrt6fssTQ/p1GzUw0kirzjbrJiYTqfsQZJa3zlGcY+IoHi+YiFSLNtCP01q5zilqLxodPzAEmW2pU/UsJVDmIleOdAusq+g4ShXrqpMi+xk4sUJwDrh2TATHtlI7BKjCNn/yeQ7tGBjlF4ugpY4ebITVHwttuxSAxhQHWiL049WmXmAG0UsHFtniKQvAJT/HFFC3+VJSMweAtc/Fa9Q8WmgF8EjqrIxfyO0pfVc3J0yAfwlYFHqCvcXx0JSAPgObUVFxdOAe+NE0KGnx4sk4lkdIViQ/OUJdJTM1avWgs7xdspCZa9Gwj5yjWswo3S/SWL1VS3t9GiqL2LS7H80jd/gvCOdoXnJZOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199021)(1800799003)(186006)(2616005)(6486002)(6512007)(478600001)(86362001)(31696002)(26005)(36756003)(6506007)(53546011)(41300700001)(316002)(4744005)(8936002)(5660300002)(8676002)(7416002)(54906003)(4326008)(2906002)(6916009)(66946007)(66556008)(66476007)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2Y3Ry9yQnlTMjBqWituR2FaQUVJQ0N2MDdCVXg5c25UTFdZQ1BoSzg3QjFZ?= =?utf-8?B?aThNTHQzS1lzMzFhRWpOTXZrb0Q4K0g4NU9pUFNkVjQ2cXlndUZsQXdqcGVF?= =?utf-8?B?SGU4d3NOcGdWQm4rL2x3VStZdUVqOWNzZWxrWEViTXhMZVJlVEtoNFY4MWxp?= =?utf-8?B?TG85eEpvNHpnSGlJUWttU2dqS2N1RU9uSlptaVBEVWNBNmpRcFpFWUxFWWJS?= =?utf-8?B?YjlWUXJCaWJTaUhVY2IzZkFXLzdDK1BIM1d4bkR3SVpGQUxlakNNU1RuV0F1?= =?utf-8?B?SkdpV1d2bkpNSW9HNUhYUU5uNmFpeUpsU0VFaEhDZkkxRTZ6cHRlSGFqdkc3?= =?utf-8?B?ZG9vN2I5YmhYWElIdFBOd3ROWFFJMUYvVlpqY0FaUE1qZXR1eTh3RktSMjF2?= =?utf-8?B?WWdZUHg4WU9lSW01UGtTeG53MlVoajM2TCtuVWYzNDRnS3N1NTVxVWtRendN?= =?utf-8?B?c3IrcEpldkI4REFKWmZoZERYM3hLMnM5dDNWc3I1TFNEVC9uQVRUZXI3d3NV?= =?utf-8?B?ak8vN0pEczd1d1dtZDkzZHJhdUZtZ1ZZcnRWUUM1WEtMUzRsRy9IZTE1WnVS?= =?utf-8?B?ekRTUzZvMHo5NTlzajBZMDVnT1FRMEgrRG1ZMGJ2MXRkMm5uMXpUZi9QVDNz?= =?utf-8?B?UGM1cEdzeGhtMWNFRCtFYTlEblNOYzY0Qk9kSEVud2M1VUZwVHZYRmJkWWYv?= =?utf-8?B?dVNIcnRlSnoxVFlDZ2JoNGlldnR6N1Q5ZTNOaXZ5a0xVaWdoR1lhajNadVJo?= =?utf-8?B?YnBaVVpoUzdySWRBTUFsZjA5cHVSNVBuNjBPS0ZxYmQ2MTd6U3ZVYkFvem5w?= =?utf-8?B?VmpQZ2owZmFHRng3bDV0UEpCM2g3SmRIY3daNWRDUjRJOU5PRGhHSWZiUXQw?= =?utf-8?B?UmVHU2FUZklKeTFvaVVIcmh6UDU5aEtrNTN5WndnNHk4T3RzTGxyd2FScDQ2?= =?utf-8?B?YWZBdmlyRmw1UlhCZldrUXpZNmF1NDg0Ny9zQUQwd2QyakdKUjhueEFIdzha?= =?utf-8?B?eTEyeVR5aEFVK0xQd08rNFVuUW1JR3Urd3FFbjdqL1Z6QlJlQVI3a3BTSENu?= =?utf-8?B?UUJOS2dZdjdsVWRhMzMwb0JiTG94cElaN2grdGMrZ1pQNTFvd041Qy9zRVZC?= =?utf-8?B?WW15ellsNnBxMmJmZ21TTmRxYmdhSUZkcmFoeUd5WnhkNUlBSE04UXpxa2pC?= =?utf-8?B?eEprM2VpK0RlNUFnOUNTTEdrSmJ0ZG93a2ZsNEtLQWZ6dmNUbjhXWk01SWVn?= =?utf-8?B?bnFsbVJiekpKYWJtcUtYN2ZBNzQvck9sR3NSRGdOc0RweWg3N2JDZXFrVklI?= =?utf-8?B?azNiNkN2ek9QK3VjWmV2by9wemxIZU12V2JpYzRvTUcxcElOSmh1bExIbXdH?= =?utf-8?B?SFJXckV4QXhub2xkb1AwS1loQkZIWk4vSEYzM3RaUmFrVjBXTzNza2tTOEE3?= =?utf-8?B?T3c3dG94RWdzcC9Ec1AwdmNJYVgrYTFYem1CcjVYQ0pKcHBZU2hpTEZFRnRn?= =?utf-8?B?RDdrWjF5Vk9yOXNxNVRnWlkxOFA1bG5WVitvR0RNZVZ3WUhUVEVrWmpZTWd6?= =?utf-8?B?MkxybXdEWWtuSlpYYThvalkrbEIxTnhuanpETTg0eU5KVDBVT3hyOHpkcVMw?= =?utf-8?B?akJlVGsxVitKbkJJeTJ4WVFJVEhTQ2I3Qmh0TEtpa2RlUnhSRXdVa0NtUnhu?= =?utf-8?B?cEtPdDA0YTQvdVplUVBXL0ZSdFB5czNiNlJ0SHAzdkpuQ25LTXllTkk1WGZ3?= =?utf-8?B?K0V1ZXZsNzVYWXB1RGFTN3dDUU1nd1dQQ1BJUzVLNnJ4U05OczAzREVaYjlT?= =?utf-8?B?bUlZQWs1bG1ROWtFV2p0aTJ1VDJTaXk2dDlvajJUWFp2ek5ycC9SdFVXMU1V?= =?utf-8?B?L29KdzE0NTRKalZOQ0JsRWxFRVBTSmVmeEtiaW9rcVJLMzlLVW1OYzRmS1Fm?= =?utf-8?B?WndmajMvT1pnT1ZOWDlNZ2lEa3pKS1dWV0Uyb1lIanFLV0diUnNJcjByaXZn?= =?utf-8?B?Vyt0VFpVeWcxY29xRlZndVBoeTdvY0ErZUFDMEM0R1ZDNjBTbHV0Y0pWb1Bv?= =?utf-8?B?OHU1OEd5d1dXaVFzUmNpMDMrTEl0K0ZEWTI0RktHSkpscDR6bVZyYStaakhu?= =?utf-8?Q?w4FF0kflzzCNGJWzFLPHQlqS2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 195a2520-ca91-4d6b-4622-08db97440cf3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:44:33.4816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zJn0P6RqQL6/VknQuFyG4Ljji5uwJfY0lY+ZvOQfXrrTj2am3JO8VMs+TvX8YoD98vtPM2mw8NtyhsSHzo8BqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8606 On 04.08.2023 22:43, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> Suitable mechanical renames are made to avoid shadowing >> the function identifier 'wait' declared in 'xen/include/xen/wait.h', >> thus addressing violations of MISRA C:2012 Rule 5.3: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope" >> >> The parameter name 'bar' is added as well to comply with MISRA C:2012 >> Rules 8.2 and 8.3. >> >> Signed-off-by: Nicola Vetrini > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:48:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578367.905830 (Exim 4.92) (envelope-from ) id 1qSzex-00067O-Tk; Mon, 07 Aug 2023 12:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578367.905830; Mon, 07 Aug 2023 12:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzex-00067H-R8; Mon, 07 Aug 2023 12:48:31 +0000 Received: by outflank-mailman (input) for mailman id 578367; Mon, 07 Aug 2023 12:48:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzew-00067B-Fj for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:48:30 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061c.outbound.protection.outlook.com [2a01:111:f400:7d00::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b54507f3-3520-11ee-b27e-6b7b168915f2; Mon, 07 Aug 2023 14:48:29 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9338.eurprd04.prod.outlook.com (2603:10a6:20b:4e6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 12:48:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 12:48:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b54507f3-3520-11ee-b27e-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIBhfmGmEU0rIcnUEGdrKg7dhDX/78PznGGKqxie5dfk9dET5rXmLvLabt+TbEePUGsUR2Ig1iLxCFBkwu1eXWDw76TDeuaR78kzpWi5D6iTquQ/fHtFOsIX5xnj42HFJw11L89JeCzi610Ni7RdYk/T0xL9+s7O4mpT9UD61AO3uK+E8DHosKWgv1H4t7pjmvJ6uu0RaZ/svdCK0xcTA+BwcZ4N7kPZfBNCv0H7x0iVA+BleqeRH+NUaBwEz/pR4unTeKIfh1eQAi67wwarzOEN4oJDIqWC2BgRRNKK+jNUilGjZxMpY4dZf+Eop5v1oj3SLEPHYwn/Y62bDNFYKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqR8kmPEt5MhrMoM3F7CxcM0ZcMpf7kT7H/gmtH+LgQ=; b=ZMKCG6iToE+ZxSIXHZ2zkKJKivizWquXuYVwsmBMgTW/ljs2OZqIILE1D+wIii+o+A6Q0mm9YvdrsZRiFNj6nmUrZ0q3l+v/yVloa1GWVF1BpfzDrq1b2cgYYaw4eFAzSPweeDni/HsbfN117E9gk1N4q3ZnL0tqsK3S1TPubfrP0vuI+MgPU6nmBCjQOTrihFjLOzatZRu1SoenFxXdCstbwXgT5+OGcV9F2EyqWFzYDIPGqAJjBY3fwnwqmBlYXOKswTfMl2o8SZJ+uzMoC8lLF7k/Rc3wIhKhY4ZWZnOOeljAQkDrawJW+qHP7USXXwSzXyi/OKRC76REUfWOfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dqR8kmPEt5MhrMoM3F7CxcM0ZcMpf7kT7H/gmtH+LgQ=; b=do0V5Rz0BDaaumhFmMNwi0cp7TmtlbRx73ATF/KuGDRIfgeXlcYAnQphLDstCa6dSafLa6c7BaJxBro97aZMjTG7+Onep8+8CDigiDhKvgKuey0u37enKZDiKZwT1jjPHA2MeCte4K6STCSOyPUm9OVprKEkd95CC2Jy8gBqRkMGnKMOJZU4ZGXRX4a7kVvDOIpNNHaXv9ZnORsvqcV7VOPLdkeR73GaEcbmOUWizgVcPIlSVE7oqXJi4VpKrqMCGzFJ0T31Ksct0qxTL0cXRyT8bIduoFgbY0cA7e9oIxpsg+y/t9OZTPHklhwbOlxqqYw7gpZ3xPSGVTpQK/7Ttw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <17069ab9-03ff-9f7b-6480-d50e1349e16a@suse.com> Date: Mon, 7 Aug 2023 14:48:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini References: <2f7380396ee146132738dd5c6b2a80d62a8035d5.1691135862.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9338:EE_ X-MS-Office365-Filtering-Correlation-Id: 05488938-ba6c-49c5-bec4-08db97449855 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XupZlijlHHRatPAVw5/7/mLzQZ2B+6yYKzFUzftJ9B+kbJUVZvHtqXF7XjXX3vGnpumHqVOaJUk3GB7maI2/SwAtt6EtESd6DA4d8Df6JlIfecImyrWhIzTY8uUC6YyNp2mDM/hpp+AFQ4YBaczcFBezVmz6pazCzb71ldKLB8lMsDGz4RB7c9TwvP+2e6ncmGNiQgFw+gnjNwc64DsrUMgczgdlXJaIQZD1nTpzgJJBmSeaIH05HrKbKf7WBIbnXDuCuuLKkRgKC9BMaW+ipOWATPWi1PtkLqZwGqSyr+n+R+ZF+kf2g+pHMFruLwFSAdjvnBoWVLNmimhPifF+DAawkxf01CLykEOVm53iHRGaJAK0pgpXe52ZZK4OoFdbZf590oxtwPRA5eu+Llxq4cv0EtKvTd0LUiyTzDakgRt4VBNRY7j7+lVY4oshcLghOLec6hJN0mJbxb1ngw7/Aznc/tsQbaKHmYveO1eQ/Nm8bXFxPQVOo/2MoF2Nf0nSaP5jE4z5JI2z1zDB/xRvYhO1jAgU849mKkSkAoKDc57vcbwcFhdgombCGt3VNhYrbgs+wI+vx74qBidVq62buJqfMkGTLTPBQL85CjLIsU4Z5EMZ2ZfrXPeOKUceQpbpt4k7wdAsKPcDw4yCiz83kg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(1800799003)(186006)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(7416002)(86362001)(31696002)(4744005)(4326008)(2906002)(6916009)(66556008)(66476007)(41300700001)(66946007)(8676002)(316002)(8936002)(478600001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1ZQb3Z5aSt0aEtQc1IyMU5MTjNJWUFodE1SZWR5aGswdEdzWm5nSjF3UEtL?= =?utf-8?B?K3FEUUd3UTJaRVFydzNlWExQUUZWUWlCWTJyaFhKRjJHWGVCUWpybWJuaDE1?= =?utf-8?B?bW9yNXZVZDVCRmZRK0grQkV6NUl4ajZzdVZZR056cy9GNjIvOG5US1lFQjNm?= =?utf-8?B?QjN1QVl2dWRqMHBHcThXZjllTWNPSHkyRGxFTjRzcW9ZS0NjS1lsRENqQTll?= =?utf-8?B?V2JjVFFzbldDa1E3ZllTYU1MbFk5QzRPc2tZTXRHblNHNGRJT3J4cmh0V1Y2?= =?utf-8?B?aW4yTHVzay9WK0J6cEUwcHlWUWQyVU9UV0QxWlRkc2MvSEVPQmYzN0pOY2F3?= =?utf-8?B?UWpENGFlVXkyR1YwMzZYUWVBeXlQVHZNSDVNZEt2VmlidzBoQzU0bkpIZWxE?= =?utf-8?B?QVQ3U2FOQ01WQ2pNT0ZaNmR0ejlKV0NjdmV1a2FkWFRndDhQVTBVeC9wL1Bq?= =?utf-8?B?VHA5S1F2WTJsaUg3OUIxT0ZvOTdXQVNrTEc4QVVSdksxdkVtYnpML1lxTDVX?= =?utf-8?B?QklqK2o2Vy85dHlRNWFXaXpHeWlzV0oxWDJ0Mlh6K29JeGdnT2tJcVgwWWNj?= =?utf-8?B?dWN0RE1lQ29yL2FFR1FhY1ZoZTJCV0R5Qjdkb2RxdFoxMEVNM0paeDV1Z3Nw?= =?utf-8?B?V0p1VU9xVFZ3WTZLZnB4bDYxY3pVMWNHeWFRYnJMQ3RJdEZVOU56WkJYajVR?= =?utf-8?B?OXJ2MVo1VkF6aTdQM1BKdENvekhLeThDUjRkY2ZXNHVyKzcxcno3NXkrRjhW?= =?utf-8?B?QTVwTzZrVDlMaVJOcjhIRytOU2pKNkUzVDhjejI0ZmRkaFBLbU0vYWVlK1ND?= =?utf-8?B?RVQ0ejkxWGtNS2Uvc3F4dGo4WW9EUEo2M1M4TXRGdUEyYWFjRkhDTDk1bk5D?= =?utf-8?B?MXlRKzA1UXI3dFZUa0UrMmJKYmJSRjVkNjBtWGs5T0xoaytIUXZxMkpnbmNq?= =?utf-8?B?dFgzVlVTL09DNitEYjE5Tk1VRUFmNjBBRThmYXJWdXhIdHd6Z2wzWTVUZGJw?= =?utf-8?B?WGVSQldYRUI2Sll6RjlMQTIxZno0eHVOK3UyQzM5MGNrSkRyVUFKZTZ5RERt?= =?utf-8?B?S3FzVm01QWRpWTFrZjNlSkpRZTJSV2RXakY4ME9BcGdDVjlJTEZ3bjZmbkpp?= =?utf-8?B?Z254TnpVbTlPejJiNjBrNTVNWmIzSUUwcFdNTUR3dWgvdjd5UWovTE16SGtr?= =?utf-8?B?K0JwL1VpbFk5MlAwNWNYeW5iQ3l1N0pDWUxXRWd5c2ZkeXVnMEZOUEdSb3pz?= =?utf-8?B?bkhaQ0dJNTBManB5TXA5RUJtMm1oc2JoQ3dBY2lFZVdVY0dvSGd4MUVKczZ6?= =?utf-8?B?NHAwTGd3M21QTDVOSUhjQnNOc2JBZm9EcXdVbXhOdGZTNzh3UThOKzJtRTZR?= =?utf-8?B?UzhNZm5wN21OWEREYW1YVkNVM0R2ZHNhdENaRnpxd2pUT3Y2YmUzNWozZGNy?= =?utf-8?B?RFZ4eDBSSE1sd25qUFFOQ2FSU3JIMzlaLzZoUnhlbjVPczNZV1A4YzF1a3I0?= =?utf-8?B?dVVRQWFNS21PRDhUY3dOb09UWmUyaStFeE9LZHNCYjUxWU9tNFJmYVYyRVpK?= =?utf-8?B?NWw4bmdWZGdOTXZZYkM5UERpMm1zVzZBYk42d0pPZnYxZEZxOTFQNEFFOEVh?= =?utf-8?B?ZFV5UHBEVk5FRmdMeHRISzBwZHhYL0VRZ2M1dVZnVzNGRWxLbnUzMDAzYjJN?= =?utf-8?B?V1ZiSXROVnBkUVhCNkN6MS82aWFteHloTkpIcEJmby9XajVTaWVuQzZKMXI4?= =?utf-8?B?ZmdoblEyUG5qVTVsVGZ3Q0FoZDB6MUJONlRyd3pFYWtsa2xGT2tsK0FkbGk5?= =?utf-8?B?K0JGbTNJZ3NsL241STVoRmNXUm1rZS91UTNvNXdzandFVFIyS0k0cjNBU2po?= =?utf-8?B?WVBua3ZhVnZWVE4rYmYvRWdSSVFPWXBzMUZDeEhkRVJENTg1UE9idXRVd3g5?= =?utf-8?B?WkpYdjJaTkNublhCa3BtM0hYaUdhVThFY1kzZndSck9YWXpMWnZENWNTODlE?= =?utf-8?B?ZkVwbHpkTVF5RmdJSk1rVlBCb3hjNCtWeUFUNWFudGtxVHNXNU8rTWU0RGFv?= =?utf-8?B?S2hWUHFZZTlONnVJblRXK2IxMDErMkIrbHpTSGNXNEpSb0FkSXhCcFQzV0Ns?= =?utf-8?Q?HnGi97+uGBW1rxpPcEaP/3KH1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05488938-ba6c-49c5-bec4-08db97449855 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:48:27.3446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4w+lPASI0fllJbIxLEisikwEaNUOL4Rk8NmYCo1POascy2sQOgXKBmtUfE9q7ghj4Ldmtd/jW030W2z0UF3Rrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9338 On 04.08.2023 22:45, Stefano Stabellini wrote: > On Fri, 4 Aug 2023, Nicola Vetrini wrote: >> Rename variables to avoid shadowing and thus address >> MISRA C:2012 Rule 5.3: >> "An identifier declared in an inner scope shall not hide an >> identifier declared in an outer scope". >> >> The shadowing happens between the struct declaration 'mtrr_state' in >> 'xen/arch/x86/include/asm/mtrr.h' and local variable names. Let's try to be precise: The issue isn't with the struct declaration, but with the declaration of the global variable of that name a few lines later. Afaict - please clarify. >> The latter are renamed to 'm', which is used elsewhere in >> 'xen/arch/x86/hvm/mtrr.c' for the same purpose. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini > > Reviewed-by: Stefano Stabellini With - as necessary - a suitable adjustment to the description: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:55:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578376.905850 (Exim 4.92) (envelope-from ) id 1qSzlh-0007vs-Tu; Mon, 07 Aug 2023 12:55:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578376.905850; Mon, 07 Aug 2023 12:55:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzlh-0007vl-R4; Mon, 07 Aug 2023 12:55:29 +0000 Received: by outflank-mailman (input) for mailman id 578376; Mon, 07 Aug 2023 12:55:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzlg-0007fq-6j for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:55:28 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20602.outbound.protection.outlook.com [2a01:111:f400:fe16::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae8342ca-3521-11ee-b27f-6b7b168915f2; Mon, 07 Aug 2023 14:55:27 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9338.eurprd04.prod.outlook.com (2603:10a6:20b:4e6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 12:55:25 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 12:55:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae8342ca-3521-11ee-b27f-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dp/mVhC4pjUiEL2c/qt60WwX5Yi0+BxHThRDxiGs9v+5MjwGH5R/OrUUiCSID23vaCogNWOMavGsCSqCgRPOWPM1xYzdKfwSGAoh6KEaUsywpFHm9K/tBwg5KjX8IM+O47tFMWuqfB4b9/AV1PKWWxtTgSldIHzxcxJqLW8vMxBdWhVs+LYocWKmNl/SZvEffr+rpZyTdOS9ns2UIm6zHD/U+IbRZ1nJXXb7jGMPrIJUXuLiZpPKH9ObgJU1X60h9cR3mXPvLLnFpAOkbZBrPgHuE7foogMSid1PfyiS4PDouPIq6Vgvv5JPY8JfO3MxdwHLBSKpg3ZDZcUYgXXNBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=714EprljTvlE97Mb6c7roih6QuC6/NDH9mWbJEMKvWM=; b=QKsOQEvv0e9G7s/07JsFAKGbrBf366nR9dFFxzCNYAKHK+Dio2hhjJgVTqnYKMkgPP3LMp4JLw0ljjJcsWoBwDe1nuENEhAygLb0tRyRFJxBhcfA8IFIa1qPZMYl2D4Dvsm0u/8h0Hobx2O1EaAmKiXt12jT+vJ9ca8iLFbMRZOxVfNFYl1/G70hyMWDn6lI3/4oft6A9WF6eD8PRHNNZ48HyRMswz4vqinot8382NqTmdS5uJ1YtFF4MXwgQVRYB+4AXc9ROklj0rKylXlwWk8CcHhrBErqmLZgJxCZIepixnygZ3GT2WAqv2gUoMtb+IUS592lhirTfRx8Zc3wmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=714EprljTvlE97Mb6c7roih6QuC6/NDH9mWbJEMKvWM=; b=tvIE5hfjy+93teI9b3E6XISYnO69tLYfP5pw2oe+v2/HmAPRMqAvwL6/fzeLgofGAH9r1n/NjCf811N8+RPGPTbqq56ko8ZuMAibtFGor12sxwz1O7sSmHmZCVCLdzsKoZRWZchLUktk/xQ3mVwwHh6aOGF6qLtpIFhMtEvDl2VY+GfMuBi1y5GIG3Ug4eAZ0WZrYV4l2BVYRRo7VbD7WrGdO0zMLWLrW0fVPlgRW7KiyBlGpeKGG2wdjSrDhH0p6ei6x+btUmFB+nwBIaKLkbBMwZQE1L3B+8JXy+abhereUZESOVY5anyClL0MnHGUb3dz1wqDp2nSLgrIOdsXQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <19928768-b24d-3e40-937d-9460e7f06a9f@suse.com> Date: Mon, 7 Aug 2023 14:55:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , xen-devel@lists.xenproject.org References: <987ebd142ebd69ed062d74f7eb69c23759c51636.1691135862.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <987ebd142ebd69ed062d74f7eb69c23759c51636.1691135862.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9338:EE_ X-MS-Office365-Filtering-Correlation-Id: d09f74fc-bdce-4ad5-eb0d-08db974591a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bl63A/PA09EcAyz4cpgukivElEZ7vIVx3D3ztX+MR6qnRGCfmuA4OChClbRgsxe07tGTFlrzyIKkqjEhaKcVhHqKHC//WbszuJHLOP/Qzw2wk695b0O+uGXGeOdQhF6MXMybisU/cZpywmyD8A8aJO2XXgIft/jnO4B3yFVJB4P/vRLXjbMUzl6M0x/2t99jP7wAGPFEXfTLEO1Xl6EnRXo7Ed8WHV+2l1bjTEngpw/vWFG4Si4kc6Zl6w4MEFYKTPCdwFHrLbtVim9x7F24Le2X9oFdH26saxVJzf0MHNKXc+SNsGB6flq0YIOZhwXzAx9YOdAoQpE2dpjMZRuHif6oq/xMK1gVbS0vXRDeRqwZXWVfqu4tEvHGgWpwvZ4v7GFwmWxpmgKBbXTjRU/xu/6oQ5PFj3HQgwsyPtVQpKSbJIkf5Sd/jJldktHfOKIH8EUxOxW9SLPNdMuURSwaY93LouB7v0d3owGpGvImanoDhUvgEzAUmeCo30DQO7nonmZJ7NrIhAbIuz1FfqOzKsPY5bzbhkWMhvkiZGUuQBbiWRA+vdGA4ZkctbL8aksm9nY/SAoVr+8Ck/x2XfPfZMdv47pM4YfrXfHK/xYsAp7R/0x6ohOX7E4NehLsmTwlVXeLtqpKeUF3lERdDkaNaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(1800799003)(186006)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(7416002)(86362001)(31696002)(4326008)(2906002)(6916009)(66556008)(66476007)(41300700001)(66946007)(8676002)(316002)(8936002)(478600001)(2616005)(6486002)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVpkQys0WGxVRmtGOFFTZHAremdTTG5uSTNkbWhLY0VMakxJNzAyNmpnNFpJ?= =?utf-8?B?TVdxVFBWb3BjaFVwQkdYMzZLNm5HWXplRk9zbkZqdldCTER4bVpxa0tuem0v?= =?utf-8?B?WEh1anAwbXhmWGF2RkRGbEFNSzBNVzQxaXBidllXd2lwcmhUUEVPU3NCUUQ5?= =?utf-8?B?ZjVzVzNidHYyK3B5T0EycjFBbGN2ZVdXbkpaTWRIa3hLNG8xMHRjL2lXcUx3?= =?utf-8?B?bnZhVkJqa0IyQWdkKzQzeTNQMHZCYVBwbzlnVWpFdlpmb2x5WTBFVWhMamZ3?= =?utf-8?B?UkN4aWNJWkJucEVTcmtJWEVVRlU0QzZDWE5ORE83SHRLNFlLbmwxSnhoWm5p?= =?utf-8?B?OFllWVVGSU8xVTgzT3dCY1lvTVRKT3BrWS91WVJRQ1h1ZXMyRWlQN0Vybkl2?= =?utf-8?B?ZnRTVENkdUhEQ29nUEw2bnpvTVRDY1lUSjF2QzRtQ1VWWEVVQUdFSGxTOUxI?= =?utf-8?B?MVptRER6Z0t6TnM5eWZxUG02ekZGVE1zakhjM0FLb2I2dFNabEdYQjBlN2tX?= =?utf-8?B?VEFMcGZPVVJKM3JSTVpqYVVHYUxUK3BUSU5sSGhua251UnZYZkxBSFJnYStj?= =?utf-8?B?Z3Ard1N6dkJrT0tQdkxiUjhvUEp5Wk1YZEpQT0lONGpVYWZJckZmUWxXSkhP?= =?utf-8?B?YnIrMFBZZXdCMkN3Q2d3VDJrVjBkeURIaDJ6aDlrM29qLzZkU0NjSEdJRHEx?= =?utf-8?B?NjBQU3M5Qmh5OEgrR05BUW91VlJDeHVocEd6RkcvOU5HQUhCdE5vNW9rVlFz?= =?utf-8?B?K1NQU1JhRmtDaFRTanBHaFc4Y0xEc1hOOGFTRW1wNjVTZHN3S04raUZRMmlH?= =?utf-8?B?dm04bmE1QnZaU1R2NWlVSG9pSE5rQis3NUVYTGpWY2tCMlFTdyt5dFBHRTBJ?= =?utf-8?B?bVhocngzT1pXMHhuM3FLTVVnQUhla1o2RUd6QjZYc3o0Mnp4d1RpWDczZjFy?= =?utf-8?B?Z0ZwRnBRSnR6bGVUcWhqTWIwaXVEaGtobHp6Z2cwNHpyRnFDNlIrb0duYU5K?= =?utf-8?B?Z3ZwdkJpL3IwREFJaGdET3VRTGtWMzI3TmtoZmZaY2NZWXZZTXR0REtuenh0?= =?utf-8?B?SDNzaks4a3FXQUVoTUlGMjFUVlhBaC9MS3NQSTN5NVJMaUpBVkIyb09uRGE4?= =?utf-8?B?c0pNM2JrUTJQVWVFZkVCM28yZE9zWUdnVHp0azl1eDR6WkJadHBiQ2ptVTB5?= =?utf-8?B?Z2FxMm5sbEg1SHFxRjNGbXJTQVR2c1piYjUvbGtHRjJqTkhMTGpEWTQ5TXlk?= =?utf-8?B?MVJxTkx4ZkxLU3RQZEYxaU9SWmRBQjhZNXV6NkgrVGI0NVlTRnMrMWdrbUtl?= =?utf-8?B?cEl0MHZGOGMrS0thUFUwVmpGeVpsNUQ0anJBZlRDNHUzZUZVd0FJOFZNNFFx?= =?utf-8?B?MlJpcXA3UXJkOVpiSkJlV2twWXZBeUYvZmx3c2JlcTUwZUs1VmdLbGcvNHI4?= =?utf-8?B?NU5LNkRzbFFTbHVZUnJ0ZXhTaWtCUUhhNjAwSW9NUThkS1QyTVRlWUVzdDRJ?= =?utf-8?B?S0lPazRnSEc0UGUyTW8xVUNySnRZdTM4TE5ObVNnT3VUaE1rRHVmWEtWWlZ0?= =?utf-8?B?dldXL2RZVUpzdXRvTDRwSFRQNGFwMUcrZENlNnBld3B6VFc4Q2tvYmFzeERj?= =?utf-8?B?Rm8rWmxUaUdQNTFsbkRLdXlvaDRMUlJRUVRnT2VjalFlbVVlZzFISHFoMWVG?= =?utf-8?B?T0htY0Y1MTBQdHBHRnBGbkdUK2FXWWc1NE5FRnFyS3d4TjN4YmFKdDNRKy9p?= =?utf-8?B?eEtoTXVmOGlnTk9DRmVEL29MaVlWYzhseVp2YTE5MmlHTDY5dW9YRVdmeUZ6?= =?utf-8?B?ZHBpS1VQL1VSRWJKUXFIaDJCT1ZJVStXQ1FNV2ZmRzFQY0xEVld5THlFaHZK?= =?utf-8?B?c2NURTc2eW1CdW5TaFZDeUxIekxzUWdyWHlwL0tyNnNoV2QrRXM5MElEVUkz?= =?utf-8?B?ai9xcW5VbkdhMlNPZ1I3SzNiQ3BmM28xWXpwWkE4ckxFL3BRcEtBYURMUG1s?= =?utf-8?B?Q0VWVmE1ay91ekhrb2ZaNFp6dWNxMC9aV05qZzV5VEs0cHV4T0tJOFNZbzFM?= =?utf-8?B?SDFwWFdOWTl0TVFnMWpYbEF3R2t4ejh3SG44WTB5dmowVUhtM2pHWnZtbFRy?= =?utf-8?Q?st9XxKg/v7QgfuqSd/S8/y++u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d09f74fc-bdce-4ad5-eb0d-08db974591a1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 12:55:25.5815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6OysXwvVhbMCEar9ZnouS7fhp6LBukYf7o7ZhtcKT1pSbNEvHwBJrT6p5nmkFGzf4+bF52K6JT9fkpnMZsr73g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9338 On 04.08.2023 10:03, Nicola Vetrini wrote: > The extern variable 'irq_desc' defined in 'irq.h' is shadowed by > local variables in the changed file. To avoid this, the variable is > renamed to 'irq_description'. > > No functional change. > > Signed-off-by: Nicola Vetrini > --- > xen/arch/x86/hvm/hvm.c | 2 +- > xen/arch/x86/include/asm/irq.h | 2 +- > xen/arch/x86/io_apic.c | 10 +++++----- > xen/arch/x86/irq.c | 12 ++++++------ > xen/arch/x86/msi.c | 4 ++-- > xen/include/xen/irq.h | 2 +- > 6 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 2180abeb33..ca5bb96388 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -474,7 +474,7 @@ void hvm_migrate_pirq(struct hvm_pirq_dpci *pirq_dpci, const struct vcpu *v) > > if ( !desc ) > return; > - ASSERT(MSI_IRQ(desc - irq_desc)); > + ASSERT(MSI_IRQ(desc - irq_descriptor)); > irq_set_affinity(desc, cpumask_of(v->processor)); > spin_unlock_irq(&desc->lock); > } > diff --git a/xen/arch/x86/include/asm/irq.h b/xen/arch/x86/include/asm/irq.h > index ad907fc97f..f6df977170 100644 > --- a/xen/arch/x86/include/asm/irq.h > +++ b/xen/arch/x86/include/asm/irq.h > @@ -172,7 +172,7 @@ int assign_irq_vector(int irq, const cpumask_t *mask); > > void cf_check irq_complete_move(struct irq_desc *desc); > > -extern struct irq_desc *irq_desc; > +extern struct irq_desc *irq_descriptor; In Arm code you'll find static irq_desc_t irq_desc[NR_IRQS]; It's static there right now, yes, but we don't want to introduce arch differences here. Therefore the global wants leaving alone, and "desc" wants using where function parameters collide. (Arm uses either "desc" or "irqd" everywhere afaics.) Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 12:55:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 12:55:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578375.905841 (Exim 4.92) (envelope-from ) id 1qSzlb-0007g3-Mt; Mon, 07 Aug 2023 12:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578375.905841; Mon, 07 Aug 2023 12:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzlb-0007fw-KN; Mon, 07 Aug 2023 12:55:23 +0000 Received: by outflank-mailman (input) for mailman id 578375; Mon, 07 Aug 2023 12:55:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzla-0007fq-O6 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 12:55:22 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a95b6fe6-3521-11ee-b27f-6b7b168915f2; Mon, 07 Aug 2023 14:55:20 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 470965C00FD; Mon, 7 Aug 2023 08:55:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Aug 2023 08:55:18 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 08:55:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a95b6fe6-3521-11ee-b27f-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691412918; x=1691499318; bh=LgWoJWa6DXZKfZ0hLk5ZMf1RQyRN75OdScV RO3aOCTE=; b=aNtPYSb3yopTaCktF8VCYp8h/q8zZoGJ9iXpS+8uXBQTxI6Zbly 1Jbw7DDOaIQSv/505drGiDyLhTZaDV7H4uXioLdTwTwP5ewe1AVTcAwfGnNBeFDP qjNeZRBVc144zZC307uhkBqXOBngqtC/IG+NLL/RxBG8SIMPaZDlkea0+QBh62do BsdTK354zL+zElrcd+sxQlxxth/cRU+N86Mlq1EI+d2FQynbAGbT/AJvHgdg43Nx ngzsuz9uAEPHgDFysKGwcwd0qPZMUHq1fyXmftR4d7Iw6LapIdA0ixmtIq7/MqTP mvwMLoTlqrSPpVxBwfH9m1X6wdi4FZjNd8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691412918; x=1691499318; bh=LgWoJWa6DXZKf Z0hLk5ZMf1RQyRN75OdScVRO3aOCTE=; b=eoHVU3elWaYsiRpQiyf+tBBcGFSuy 035/KeyOKJ6VoNYygDwXvtZ9E38qwlm9JyE40Lyehnrln8FLOieh/oMKF76Lq0Fc mp0WiIrX7CDl+H8jhd4HAzegWFpRfz938M7gpmUtFCiV17xdr7da2vd8g/EEbhBL Fu6vuvESUypbEnjPJM1ePwwBV93Ej9J3QByRSaA3Up55VXiBnEe5SyxVOkGrqnhy yMKqbarihLw6pJKxNfxfFTnJEDmq9OS4avVaevBSu69u51uHwCwmtk6zl7KVO7mY qihOVaU6frPCSOfWr3pFs05tIUPvbCNyl+Ecy4K3ZD6wY9MPnhsjpTbuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeekueffiedtgeffleeglefhledtfefgiedtveeiffeg hffgledtveehhfdugfetveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtgho mh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> Date: Mon, 7 Aug 2023 14:55:01 +0200 MIME-Version: 1.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> From: Simon Gaiser In-Reply-To: <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------BB4oHImKZJOc4Owo0BGCP5bb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------BB4oHImKZJOc4Owo0BGCP5bb Content-Type: multipart/mixed; boundary="------------rHN26FGsWBurFzrDYQkb1Gdw"; protected-headers="v1" From: Simon Gaiser To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org Message-ID: <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> In-Reply-To: <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> --------------rHN26FGsWBurFzrDYQkb1Gdw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jan Beulich: > On 07.08.2023 11:38, Simon Gaiser wrote: >> It seems some firmwares put dummy entries in the ACPI MADT table for n= on >> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >> 0xff. Linux already has code to handle those cases both in >> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >> same check to Xen. >=20 > I'm afraid it doesn't become clear to me what problem you're trying to > solve. I want Xen to not think there are possible CPUs that actually never can be there. Without ignoring those dummy entries Xen thinks my NUC has 2 sockets and that there are 8 logical CPUs that are currently disabled but could be hotplugged. I'm moderately sure that soldering in another CPU is not supported, even less so at runtime ;] >> --- a/xen/arch/x86/acpi/boot.c >> +++ b/xen/arch/x86/acpi/boot.c >> @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *hea= der, const unsigned long end) >> if (BAD_MADT_ENTRY(processor, end)) >> return -EINVAL; >> =20 >> + /* Ignore entries with invalid apicid */ >> + if (processor->local_apic_id =3D=3D 0xffffffff) >> + return 0; >> + >> /* Don't register processors that cannot be onlined. */ >> if (madt_revision >=3D 5 && >> !(processor->lapic_flags & ACPI_MADT_ENABLED) && >> !(processor->lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) >> return 0; >> =20 >> - if ((processor->lapic_flags & ACPI_MADT_ENABLED) || >> - processor->local_apic_id !=3D 0xffffffff || opt_cpu_info) { >> + if ((processor->lapic_flags & ACPI_MADT_ENABLED) || opt_cpu_info) { >> acpi_table_print_madt_entry(header); >> log =3D true; >> } >=20 > In particular you're now suppressing log messages which may be relevant= =2E I intentionally mirrored the behavior of the check directly below. Unlike the the version in Linux the existing code didn't log ignored entries. So I did the same for the entries with an invalid ID. > The one issue that I'm aware of (and that I use a local hack to deal > with; see bottom) is excess verbosity. >=20 > Jan >=20 > --- unstable.orig/xen/arch/x86/mpparse.c > +++ unstable/xen/arch/x86/mpparse.c > @@ -809,8 +809,13 @@ int mp_register_lapic(u32 id, bool enabl > }; > =09 > if (MAX_APICS <=3D id) { > - printk(KERN_WARNING "Processor #%d invalid (max %d)\n", > - id, MAX_APICS); > + static u32 max_warn =3D -1; > + > + if (id <=3D max_warn) { > + printk(KERN_WARNING "Processor #%d invalid (max %d)\n", > + id, MAX_APICS); > + max_warn =3D id - 1; > + } > return -EINVAL; > } > =20 --------------rHN26FGsWBurFzrDYQkb1Gdw-- --------------BB4oHImKZJOc4Owo0BGCP5bb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTQ6acACgkQkO9xfO/x ly9Q/RAAy3oKVGf3/ubS9NcmyzMrbssJ7eT2C9voXCECuVB+778CTwJc0eWKNnSb BHzMVBtVtci0UsvYpSKW4Q9RrDiu+6YPzjQs073tN4XsczxIX+dfx+08W2bvLrTf cz4auBtrCPKD9Y0b81JviMK+SzUDDH8WF1A0wfApWp3GFZP9D7SifJG6t+f8HaFP F4zNo0JThdDxsGzB9VDlWR0L5qZDMKUV4xZhSg2ihOMBXiLgp4S3fwOv2JHkVjK+ E4Z6mEjqiAsDQg+FSg7I/CBf4SiYFET1TZoEjBEsmEVrmvP5fO80kyB6D+kO5i9X i4416BraJ04zTsaPilnL7YA5lau3g/rvvQD+m2BBl50qOBbD89vNPOY5uSUv94G4 kgfQWLNn6dFIb27s4oH1kSGS6G/PxPUevaZXc+uQO+cPHVZWHQJcljsSnUUEgDDp 8+lRRsabHzVMohSkuJY570q6oW2VBH6edefnSYGCKHgUBsAKGQamVnVusQIDRj4v 5TH3NpcnKY+Y/m9c4JZ8OLJZjKzTpKARbQhWBwrAqnjnsBRKB3GigakLCvwA96Tr balhrGHM2xJFhfbQJEqYj0DZqOEHckkr0QvbKcb/fmSFz7qyB8ZHnQe6rDtrTqxy IIAGOpSvh+suYv9gcHe9FLR/Lb9XHv3p0pnHxjZAUNlznUpjPIQ= =1Mke -----END PGP SIGNATURE----- --------------BB4oHImKZJOc4Owo0BGCP5bb-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:06:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578388.905861 (Exim 4.92) (envelope-from ) id 1qSzvo-0001Ps-Tf; Mon, 07 Aug 2023 13:05:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578388.905861; Mon, 07 Aug 2023 13:05:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzvo-0001Pl-Q1; Mon, 07 Aug 2023 13:05:56 +0000 Received: by outflank-mailman (input) for mailman id 578388; Mon, 07 Aug 2023 13:05:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qSzvn-0001Pf-Gj for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:05:55 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2060c.outbound.protection.outlook.com [2a01:111:f400:fe1b::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23798a7a-3523-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:05:53 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB6897.eurprd04.prod.outlook.com (2603:10a6:208:184::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:05:51 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:05:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23798a7a-3523-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WfHc6HxbYrVL+TcGDMnR1+BpJQ12D7q8wfDMRwNjFSxck841DTPtzkMxkLR0ziVwfiFS08N+Kt98kQ4FXQYDbTx3K5TiqKxp5y1N4rTkQxPDoD4csB3KgpWIGAkw2R60+FgCxwo0EbeXkvkGxNqNIi4U4Iy8I8m6sxZbycg2n8bB+aCzRnhypzIGu7VZsHDUyS85ZGizqcT6TasXE380xcNSMH8tEa4t69kMLBrf78klUesa6u0L/ctC7+aod5jtfJ3F+eqUBSMgxbNEiLtr1YytNQW+fBbmxjUJKjla6cMLxzTPsp9O4uPIZ9I9DXLCyM/RdeVgHMBy5yzm6csxpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A8uigQ/CapaG709BkamdJgc4DzMxFOjlVJzxKZz1Wtw=; b=kMh3MvoT4qEpqVeOQaymcfjpxRKQ0PzU3ziEnomoeKgVkEM/UuqWKyZU5xn34FV1J/P+PnReRPmrOppvxWqUEWRhkH+jYzbRXLxALiz2cwB1t3Tz/RcGl5e23IetFT/OHU5CGapo0ccZ2NcrfcaIPZ9dPO73zAvIBJHW1rKvxNmRGoCFFanWZ+p7VyqmUfnn0JehHcsbnSaQiU5BmLIn09brvYwL6nyAtVuNlpcSmqMqEa2zdWMV/qFRIfrsd3ssNMYuxNQTk1iy8AYbsWnvXsDNdWmzdF82b8bFUHwIi+ZFPJ+pJOdefKj/hV2odni38KzBbL8sYUXTa0v6qM2ZIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A8uigQ/CapaG709BkamdJgc4DzMxFOjlVJzxKZz1Wtw=; b=doJFq2fzFy3V/L9O1Di0ZwZPCmrfO/1AjRkcLTq8r1ur6DMNlRilpFuVWM6vn/D1J3PhTA1pKnt00H+S9CI/rUKgs8pW9EZxVaM7/kIHklMDA1IFGP0MB0vXcatsyQZJr9M5omUCf1gf+vJyvdnEyns1F3RIObDG33OZYhq7TuMx7S6s0sTuwjnS35ee5+LuxxaxY7RGdt2+32g29mXLUScAxvXhW4xafMB4OWLNS/AIPz1Sbj/OphXk3aaKf6VXCFw/puDZZhI0qIreTX/XHPbb+ApWFe8QfMqRrO6fuOJw+VQ9b0HbVMOVLfr68cnVBtVv5SQugYwA2xoryEQ74Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55099faa-206a-b7ae-8ef1-64d1dc344c4c@suse.com> Date: Mon, 7 Aug 2023 15:05:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 4/4] x86/setup: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB6897:EE_ X-MS-Office365-Filtering-Correlation-Id: 12a71e21-8bc1-494a-3404-08db97470669 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 08UhjZPN014K9BDLGo5Mz/h2ZKSGL6ymwVF4lEb8Bm9YwrL1hmzUUceUcaodxyI7cRutSqJNzCVVGwX4Zt+9l8NhfnlNoS6Sj2l4wQn3l7wBpTaBw1hU5OU+WKxikcN86o6BLXI7oTD+8MX4rYroqc27zbaTV2lmKZDo90cwsz8ynehK5z7y2dnws0vLnkf1+D+GKSV+6zsjFLXcgaOiLoOC6hqZvPo6i+c+q+vATj+HSajal2S3/aQIDT4RkOXMaJiIHO8XZHx6XDq/bsDWRdATGKFV0jvtX+ZshFRUgZ7LAF/uErtZYSu8ixGDoI6R9UZ6ReeqUpooaWEDd2vY4bzxeleeIYm/CgWKyueYzSfiH9cNar2tjZu6OQ9ZTYjpHVXtlyV7g4bEW7JUe3+7ZpX5EFYfpo1cwu8nBNQKmY3aZ05z6WTEtOgp6Ecc5qAYp2zpROKmWJuV5DG/YxObpIQMp7THLdc7PTHwXR/sHRq+0DcDoZyqnuvFYicCcmwMStIBwmZuYHKUbs4OiXrqaIZjZ/6ri7IvGbOJ0wFgoK8Xtd+XD0sqL7Y4uQaMz2YsQE2Ci1KrJms/TvMdzR404Ew5spcZsx58DO6LGWkbqGS1McYCSP61DHXJbPpu4DzmjVTq0L/nGrahIJJh11+U3w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199021)(1800799003)(186006)(83380400001)(2906002)(36756003)(5660300002)(2616005)(54906003)(38100700002)(6486002)(66476007)(66556008)(6916009)(66946007)(6512007)(4326008)(316002)(31686004)(41300700001)(86362001)(31696002)(8936002)(8676002)(26005)(7416002)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVE2ZXFmVUJydk1hc2NqU0tVeEFaUTBJbWZPMlhXWWphdnpaNXlJNU9HanRa?= =?utf-8?B?N2d5L25wQ0lObzQ4QmJQeGhtd01QRkdNU1pUUFFKc3gzVFVmLzE3ZGpNVzdk?= =?utf-8?B?enhXclkvUTg4SEZqUFFQOEs2elA2VWZmODRoZjVTS0xLZWNWVlo3Slp2NjdD?= =?utf-8?B?U1BkR1pVY2NtYmtVSUkvdEtSSGFuMEFTSmQ5VGtuRkE0M0hIWk01WVdmVWhk?= =?utf-8?B?WURJRldMUDB4TzZkcC8vNkxJZFBCNUl6MXc5Rjd5TUNBa3EvV25IUVkxa29Y?= =?utf-8?B?VENBZDJWL1NEbHYvWkNyVEx6YzZ0cjhOOHBiaVl0dHdpZWpKbHpTdTZvNDNO?= =?utf-8?B?eXJWNkRmZUM0V3lDaU1wc0FVN3VIdTZqeXBpUXh5WFk0YU5MMkt1M0I0YjMv?= =?utf-8?B?a3RHb1VLQUV4KzRGSjcwVHdTSmx6cGkwL1A5cENwanpDMUh3QkhxYWxCRG4r?= =?utf-8?B?TTVkMWFPV3FtS2VEZkQzUU5BVkIrVlV6UHlmeXRvMjg0NElsdElkTVd5ZlpV?= =?utf-8?B?bU1GRXFNbXpaWjNsY2ZnVUhVZGtqU28yaFRPYnVCMDk5ZnE3cGJ0dFVjbkxT?= =?utf-8?B?WnRQcGJXQmxPMmVrSlgwaC9lQm0rNXlDYWdwdEt6d25ERE9scndUZlFRRmhP?= =?utf-8?B?RlpJZWdXVXBoYVFGcU9Sa3YxZjNSSG1uUG1YUm13MW5XUVZXK3k5TkRSdVZo?= =?utf-8?B?OStPWnBSMnJ0TXo1N3BFZTVLRXNxK25DMUFNWlMwWGRNR01XMHlNNnBXZUlj?= =?utf-8?B?QlBlMFNkNThNSFVVSGVrVEVqSmlhZEVCZDN0K2NBSERFNWEwRFBRYmJrWVVs?= =?utf-8?B?MkZIT1Q5bUFPd2p1QjhyT2trdGdBM05INmtORk1EajFkZ2N1NGF2TVBFampN?= =?utf-8?B?SnltejJiYjlBcjhleFlBT1ZYTEU2TVExZG56ZFE1S2Q1TkZaV0VPVE01RGZM?= =?utf-8?B?UW1WeFRoM2xnNWszaE5HNXZuSjZRcXJVTGRBNXlESElwWHBLVURGa1FrSHJv?= =?utf-8?B?UFh2dTVEQys5aENaZ29RY01wTnRoYmovbTIrRllvcEYzOGZyNmZzMWxCZG5V?= =?utf-8?B?Ry93UXpyUG1LNXJGSUlXMnM3b0I3WkdsaG9jMHVIZWk3RU5LQWpiZXhFRzV1?= =?utf-8?B?R0lOUlZCM0ZGcHZQb0hjbmpwbjNaUGpOUkRzWGc2TWUwVmR5S0xCbkhUclp3?= =?utf-8?B?RDAyb0ZJNFVnTzlORWJJeHZ5akY5VkJxV0pXdGlmUDl3cEF0OHhTSW4vVU5W?= =?utf-8?B?ODNBQlhqNEFrR0VJS3ZaUkVhMWpGeTg2a1p3UVpwMlRBM2F0bDFIVEVJTkZn?= =?utf-8?B?Wkt6dFZmUGE1djBnaEhSNFpudTArYVRBUjVwejhkemRLS0NCaERwZHNPNlVJ?= =?utf-8?B?UTNSVVA0amVTOWRlNko4MWZNYXR1Smp2Nk14K0tOSDc4ODRBVHhYb0ZPRmJJ?= =?utf-8?B?Rmh4WjY3dHBFRkEvS1RURDdrUktjZnNybUtiMWVpcFdZQkdlNUtiZnlLVllV?= =?utf-8?B?VGVENzlQT0RVTjd5QVREOWxYUDlJQjU2NlRNVm9xSGJnVEtoeHdCWURkRmdv?= =?utf-8?B?OGQ1L3dJSkovb0wxZWdoVG9yYmhLU0M5UTJwK25XdDRNZ3FDQlJNaFZZRnBQ?= =?utf-8?B?T0lxdGdmQkRSbElPYVBWRmtaME9DQ1VNbVhMUER2NS90aGMzMFNGeDdOTEU5?= =?utf-8?B?c0pEVUVUL3EzTUhvV3FuS3dTZ3pSM3lJMkdTYnVmanBxRWpMV2hwRWtQK2F4?= =?utf-8?B?cWtYQlhwMnhKUWpXOWphTFJpQ0RUMzRKRDlUZXcrYnI2SkRiWElodUlLM2tQ?= =?utf-8?B?anpoU0tHdzZ2UEdXOTRmL05qTUVlWmM4RzM5SVdmS0dnUVg1cVJxbkxZUHZG?= =?utf-8?B?M29FTGxHbDIveG9kb0VKZWd0NlhONmFYYnRqWFZQUUZEUGVBQzY5b2d3aGl3?= =?utf-8?B?Ukc0RmJMY0wzV3lxRDEzZlBTNmlKTUdtL0gyRTFJRGlwYm9pNkFyaktCUXh1?= =?utf-8?B?Q2FkR1JuZWZmSm1uQWsrTE1nSUZrTHBWTEVWR0FlRUEzRmhkZXFROXcvQ1cv?= =?utf-8?B?YUczUkQ0SFo1SFNsUXhyMkVOcnRTYlN0a1A1a1c2M3ZTNWpyeWN5eE1BemhU?= =?utf-8?Q?dhJFWfb/igU9E0ytKCqREOmZN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12a71e21-8bc1-494a-3404-08db97470669 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:05:51.0412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UbR9t0qfr/BNld6oqREFSC1klTzVudKa4IDZndzjIJoiji2nIj4WlyIqPIc+H3BjpP/fT+lmTidaZHjHH/5gyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6897 On 04.08.2023 10:03, Nicola Vetrini wrote: > The parameters renamed in the function declaration caused shadowing > with the homonymous variable in 'xen/common/efi/boot.c'. Renaming > them also addresses Rule 8.3: > "All declarations of an object or function shall use the same names > and type qualifiers". Can you explain to me how shadowing can happen in a declaration? I would focus on 8.3 here, and only mention the other name collision. > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1577,8 +1577,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > s = map_s; > if ( s < map_e ) > { > - uint64_t mask = (1UL << L2_PAGETABLE_SHIFT) - 1; > - > + mask = (1UL << L2_PAGETABLE_SHIFT) - 1; > map_s = (s + mask) & ~mask; > map_e &= ~mask; > init_boot_pages(map_s, map_e); Re-using the outer scope variable is a little risky, don't you agree? It just so happens that below here there's no further use requiring the earlier value (PAGE_SIZE - 1). This isn't to say I'm opposed, but it certainly needs evaluating with this in mind (mentioning of which in the description would have demonstrated that you did consider this aspect). Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:17:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:17:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578397.905871 (Exim 4.92) (envelope-from ) id 1qT06w-0003AF-4F; Mon, 07 Aug 2023 13:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578397.905871; Mon, 07 Aug 2023 13:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT06v-0003A8-WE; Mon, 07 Aug 2023 13:17:26 +0000 Received: by outflank-mailman (input) for mailman id 578397; Mon, 07 Aug 2023 13:17:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT06v-0003A2-BL for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:17:25 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20631.outbound.protection.outlook.com [2a01:111:f400:fe12::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be8f740e-3524-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:17:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9100.eurprd04.prod.outlook.com (2603:10a6:10:2f3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 13:17:21 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:17:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be8f740e-3524-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYg+aHr8kYlWRO64YP4JH8Job/4szQcM2Im00spGlCHsWqu1AM9IS48gD7PZP6MNL3G5/K0r5Q+mifVm8KDMcJMiYUsvYYT6+GsfUUSWTiPnCMg/j0oYU5om+xYRTLjeyzUkxs6mG1kDTUtZsl3nDNabZIgqDW2/dKM0vDZpveLwzSEeY2/Gqsr9DCBaPmiF1aWeq/y0ZAH+6MaxgtAdkBaujoHGK5bf5ki6f4oFQO3IuBICgge2Suub9GApK2+58caznsw9wTTRFn+NBUHUyGZe9hjwsNBOI8a/EaAFxDWKCFEZtTvH6pVUBlCgIYNJ1PgTypvrgmU5vJrU0jxQvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T/SCxTU+aK2lFTFgepLV71s72ZZnKyo6fCuV6V7d+4Q=; b=ZF783xnS6UMck/laOXDYH5s5J38e/kb1Zp571/kmBreiTuPCEuE1IwyfOailJB+rasu0ccBleO36iosTm4W5r6BdTaxRCzPn8Fl3bSNDdsrVJFY7jAOYU6Bcp0NlRXBBQvtHZ8NAGavLpmZD3OfLyZOoQUmrDCQ/j1/mGLBtti+N/xZYKF9s+1D6IjldAx18lhjqEy8Z6Z3eWd0IVJVAysyAGORu8zj9yFZRxJqwVjVIQpO7K8d8kaiTTCYiot4TtKU1/VqRswYgDaNJRhlR3IKUouMvnjgv26rQkyAe0HTirAKFvNB3Qskp5v8dJNyKFHHo48AEA78FlONztc2xlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T/SCxTU+aK2lFTFgepLV71s72ZZnKyo6fCuV6V7d+4Q=; b=RfBoUfGe02q2Y4dZp4hE0ClTGB7lcMqGf6FyuQ6bUEGCJkQP/5F3td5gt/zW0di8mtmX++L9jVO+QFAPT4LJUMI6dgMrDItE7n0nDcQCuNmHZNBmtQNiK1Ynivplx8LotGXn9KuY7jGkVlUtN7/wHEgFHR/56FkJaqx+pfGpaUr+YUJR64cqC0GldZ/esFHEWL4ghZ0DOwCSUVi6oV5zD9kB1/zXIweeYYsLV8vYVEBZ7SIswTQHuMwsrwvCg1e+qVmQPMSH2UBWJjaFsl6hIgyb5JY4X2FyRLPTgz5n4i1TNQjRoB45HQY0k6xKByVtFEEvTDdgJXIRp8uxd81KCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 15:17:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Simon Gaiser Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9100:EE_ X-MS-Office365-Filtering-Correlation-Id: bd1554d1-3bbb-42f3-0e50-08db9748a19e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kroh1qSMPknClRd9c8xDjPKVL2Y2SGv2JHxjhjBWyicWZiDkQASnsnW2atUn3RMzND9jWK4UUR0imZdBoRp8VTIDI/Fq3wdQPgtCxNpGrM2mTqZwM5m8+HflTx5tteGdGp0PbE1Q5VavpZABJT16F8JCLO9tcMYFlBkCB5aHq5jAov9/Go9Lv5sO95r1ZlwEVg0uH7IdbQ3Lw1u7/9JfmE/4mQ97mawy6mAgqSk76/u5k5bkiHj4fRAaNPJIhKXXdFtqVMNhH18hJr+jBFA5QNbFLOqew7eV6sSFHoI80ZvCS8/a1zHwq0Zu7A1/33+/wdqnyvT7BCDm4oZPmoPWI8xFRqoT1p8VLkGFNz3QFmLIKi9/Ha/4OVxMKoIMG1vbBYa5c5aIXyTbo8ZlJVFTo270NvQ5TPzVIAsUcw7k3eppiP6n1gCc5P5oQJ5zjJpMtWhtzU0IOCbDAB9+GPV88xlh/C3wzwZ7TPafNZveGG32f2iIA2a36doJhPHZfmW7przGOynBf2wuAXVDMQlnmfHj+4O0ljSk3o+0NyxES6B3Uvp2Un4JG0Tbq8bAGJKiFcakbNpda4Ud5vcvRiViqUpS/rIX4TfJEKCXBoaTzeXtd/cOrdbN3wftu3KBxZx5xt8f/J9Qupkagedf3FozIQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39850400004)(346002)(396003)(376002)(136003)(451199021)(186006)(1800799003)(2906002)(83380400001)(36756003)(5660300002)(2616005)(54906003)(6666004)(38100700002)(6486002)(66476007)(66556008)(6916009)(66946007)(6512007)(4326008)(316002)(31686004)(41300700001)(86362001)(31696002)(8936002)(8676002)(26005)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjIzU3E0K21HakJrbVZiZWtoSW12bnRYWWgvdDJPbnJNTGU4MktvZzFiaCtX?= =?utf-8?B?RnNjTklKblJ3Q3ViY3pwYVNvbjdJc3d2TUhYNFZ1VkQ3amJTN0tYYVJCVDcw?= =?utf-8?B?bFp4WjYrRzIvZmxpWU5mM01iU0JTWGd1M2N5OTVvRlluQzdhS2V4dksrYVJK?= =?utf-8?B?SlRkcFlZTk1vdjRLWG1qSGEwbFUrS0lMa2o4UjAxRUJuRER4UGJhMXpJdG9z?= =?utf-8?B?d1dFVTdWUzNsM0hxcTkzTFZSbzdaODd5d3hWRFF5UGtqZm0rS0crcWUrQTJO?= =?utf-8?B?SnFyek0xK2JTenVPR2NzN0xXdk15R1JqTHdLc2hUYlc4WnZrem1KMnJjTG1v?= =?utf-8?B?dVdhVGM3SnVYREhKTFNqU1NZcG9sZUI4b1Fja3BWYkVPVnJnODFoODh3Z0hs?= =?utf-8?B?S093bVBrTXZnNEQvK1F4NW5FZHJEY2pMZmprZEh4cXV1dlU4aUhkUjUyT3ht?= =?utf-8?B?eXBXeGg0Q0VtVktjMnp6WkN2c0lRTjFWTEIvY3lNQ2k3TjNobVFCZGRZdnRK?= =?utf-8?B?Um9WMkpGRG11RDdqTFFhdEZRbjU5ZkVlVHpGMWtWRnhqMWhSNWJrMW84MENm?= =?utf-8?B?YTRyUzNHQU5Hdk9aVG43bDlMeUFLTFIzNWxkb1ViRzVRS0JNa21Xck03NEZD?= =?utf-8?B?M0JWaklUc040NHArWjJJSEVZMmZaL21zMFVtYmdEaldacEZ0Uk1wVjVrenFR?= =?utf-8?B?cWV1QVJXTVM5NmhzYVArOU5nUnhFMXUwSTFCVks1YWRpMnpJdmZ1b2E1Z1pl?= =?utf-8?B?a0hvbE1oUFQvd2NYUmpkUTRCeFRDYVVVWCs4WWFob1UwZWx6elRrQmVSK0Y0?= =?utf-8?B?cUpxbEw0SjJyQi91TWMvOTV1ZXYwaXQ5VkovRDZySGptbFpRU3ZMQzZXU1Nl?= =?utf-8?B?WWRBbHNjN2htblFSUm1YVXpNb3VsU2JWcVZMWnVPTFZOVnRyVk5WTlh3Q1ZL?= =?utf-8?B?aDl4UUpXK2tUQ0lZZU1GSTE3UE1XVTRKWTFMblgxZkF1Qy91NExVQTdqOUpw?= =?utf-8?B?T3MwYzhlWkpYSFBoZ3NEWTdTOWY4Q2F0bmJnemorQ2c0NGRpaE5LdzJqMlh3?= =?utf-8?B?allzVWZsNkk0bFM5Z1NKMUNMdkdXU2U1RmNhblpnWSt4SjJkWFREbEFHNUVM?= =?utf-8?B?c3AzL2NtVGg3UmVmZmFHak05amc0MDgxR2FRNnN3NGM2S0trRlNKNm82WFZS?= =?utf-8?B?RnNYeTRHa1lhdTNzK0UybktqYyt2ZS91cStVWEdHTXBQdkxmQUM4cTFjRVpC?= =?utf-8?B?d2NZVTQzRlk0VWxhRFdOVFMvUE1BSExrL1FKU0Nobm1STGdzNy82VmhNNmh2?= =?utf-8?B?cTNDVXFTWWVlQnJFZ2dsRnJnZkU3VlhSYVJkR1N2dytpSVpadDVaZ0poUjNV?= =?utf-8?B?UTlVbWlxQlRvaUxsVm8yUjZvTHlJNnY4bXNldnU2ei9XVjJLUEQ3N3k0WEdS?= =?utf-8?B?TFpxL0dqOHpqNXVISHd1d3h2UEErNiswWTBHeElXVzdFazhVZG5EVjg2M3l0?= =?utf-8?B?KzBvSkNlbDN4NFhGT0x4WXZnL2ZVWS82Mk5MNlFMaTQzbTVqbjNVNXpIR2Fk?= =?utf-8?B?L0pvNzh5Wnc5SW9uMUFJTjE4SGVmM0l0Q3ZVc2ZDaXhYdFZJQXFDNEt3UkhZ?= =?utf-8?B?ZkF5R1llREdOdzR1Y2pvSGpKK21uWVc5UndKUklCUWdmK0txcFhDa1VSOTZ2?= =?utf-8?B?U0JIMU1sNXVYQWhaOEpISjdxZDk3VmtQWStkdkZJZzV5Y091SWVrOUd5M20w?= =?utf-8?B?UlcyOFQwRGRGUXRvalF4ZXRsZlAza1ZGdGhtcncrQ2xIUmVibzY1NlcxSVlY?= =?utf-8?B?SjRETkZ5TFlOZGVraXhUeFJsR25PVFAwd05nN2RHcjBiOUFqSm5UdWdsaGRL?= =?utf-8?B?b3ZudFdUZTBEcmd0c0tpU2F5K3NzVVdLNjdpbjAreEh3RmI1TWR5ZnI3Wi9j?= =?utf-8?B?WEYyNDhaeUViY3ZIV1RIalpNOGExcFNoLzlyemRSTytRbkFaK2FZN2hvcytz?= =?utf-8?B?b0Q2RDhFRGo5cWRlckRoY2UzM0tPbDROYnJuMVY1Y29lb2hnbFFJVkhKVzNn?= =?utf-8?B?S2d5UEpHemwyU0pmWlFXaEpOR3A1Z0phcjluejlZbHhDc1owckN5bmRxdlp3?= =?utf-8?Q?laDPazdBo+Mkr7nIMBW5dX00R?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd1554d1-3bbb-42f3-0e50-08db9748a19e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:17:20.9302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B34ypUbo9rKxuq4597T9Z8Ryxf7mLqUf0lyNEV/lAvSfx6YsXg5u7liCRQlFyPm/v2zSExpv1N9+hod4qCcI4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9100 On 07.08.2023 14:55, Simon Gaiser wrote: > Jan Beulich: >> On 07.08.2023 11:38, Simon Gaiser wrote: >>> It seems some firmwares put dummy entries in the ACPI MADT table for non >>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>> 0xff. Linux already has code to handle those cases both in >>> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >>> same check to Xen. >> >> I'm afraid it doesn't become clear to me what problem you're trying to >> solve. > > I want Xen to not think there are possible CPUs that actually never can > be there. Did you try using "maxcpus=" on the command line? If that doesn't work well enough (perhaps because of causing undesirable log messages), maybe we need some way to say "no CPU hotplug" on the command line. > Without ignoring those dummy entries Xen thinks my NUC has 2 sockets and > that there are 8 logical CPUs that are currently disabled but could be > hotplugged. Yet it's exactly this which ACPI is telling us here (with some vagueness, which isn't easy to get around; see below). > I'm moderately sure that soldering in another CPU is not supported, even > less so at runtime ;] On your system. What about others, which are hotplug-capable? >>> --- a/xen/arch/x86/acpi/boot.c >>> +++ b/xen/arch/x86/acpi/boot.c >>> @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *header, const unsigned long end) >>> if (BAD_MADT_ENTRY(processor, end)) >>> return -EINVAL; >>> >>> + /* Ignore entries with invalid apicid */ >>> + if (processor->local_apic_id == 0xffffffff) >>> + return 0; >>> + >>> /* Don't register processors that cannot be onlined. */ >>> if (madt_revision >= 5 && >>> !(processor->lapic_flags & ACPI_MADT_ENABLED) && >>> !(processor->lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) >>> return 0; >>> >>> - if ((processor->lapic_flags & ACPI_MADT_ENABLED) || >>> - processor->local_apic_id != 0xffffffff || opt_cpu_info) { >>> + if ((processor->lapic_flags & ACPI_MADT_ENABLED) || opt_cpu_info) { >>> acpi_table_print_madt_entry(header); >>> log = true; >>> } >> >> In particular you're now suppressing log messages which may be relevant. > > I intentionally mirrored the behavior of the check directly below. > Unlike the the version in Linux the existing code didn't log ignored > entries. So I did the same for the entries with an invalid ID. I'm afraid I can't bring in line the check you add early in the function with what is "directly below" [here]. I'm only inferring the "here" from the placement of your reply. Maybe instead you meant the rev >= 5 one, in which case I'm afraid the two are too different to compare: That rev >= 5 one tells us that the entry isn't going to be hotpluggable. The APIC ID check you add makes no such guarantees. That's why the new flag was actually added in v5. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578400.905880 (Exim 4.92) (envelope-from ) id 1qT07Y-0003fE-DP; Mon, 07 Aug 2023 13:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578400.905880; Mon, 07 Aug 2023 13:18:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT07Y-0003f7-AZ; Mon, 07 Aug 2023 13:18:04 +0000 Received: by outflank-mailman (input) for mailman id 578400; Mon, 07 Aug 2023 13:18:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT07X-0003f1-Gy for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:18:03 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061d.outbound.protection.outlook.com [2a01:111:f400:fe5b::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d4de8776-3524-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:18:01 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by LV8PR12MB9449.namprd12.prod.outlook.com (2603:10b6:408:204::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:17:57 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:17:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4de8776-3524-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SyB8Odyutmt1zWUMzkwMoGMMH9ZicfPxzqKzl7mQ2iA2GN1LeSqBJYXVpdfCR4e9TcF4nGqC5jAH94PxLFEjH5Cm8EJcpZFKQ1WOEDbVrl0ojjbtFx056oWpLYBlEipOn7yPPRCNu+CoSIfsEdDZx8owJ69CeUa2LJn//K47+NnKUoSDHIAahHuHeYPI7VumQDYrWpDrMB+uM4GRWHGz5P9tNUC0kNd+V6YcSaTEvdkAthGYKwktFeXqJM/qpkH8/c4nKP+jkt1jxLRAJdU0ICCm2E4f9AKPQn+/FnVMmjgUzXSmFefKDaYHFx/LuSR8efCb4jzLMSUsnL0ymAcRSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQjljf0GrI0GEV5K85/Ec4Yt7l2YjEXQ+Dx6GkfqNxY=; b=hmeTWojeXPc3ic4UBllxeua2yCqe2MnNdQIJpZlIc/spvMRzRZIFJkMGAoS98pHhwh8GVpyV8mRcZUjbFRV/Ivqm40Nr4JqVVAKaTbZJvWZ3dfhd2qjTn7e5PECeBGBgwrp2F+JLwwdQDzAQn9rZwDTGmgqakQJUVk0jEc+SHblHk80NvApaDC+iRD0XLIMES2MG47qTgNOhZIdmQjccPZsKcHIEbol/18e/C1D3UryQttOv44DdOPvZy5lZvYJ7KIwKJzkPqpq8ca+y3g2ywvB/oeksRRm+qX2g051IC3DUX2zsw6bhVolIgztkJqhiqjX0ezQ70IY1IMnwii6nYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQjljf0GrI0GEV5K85/Ec4Yt7l2YjEXQ+Dx6GkfqNxY=; b=g7AO/XiP3d0oxY2vzpJO29JkHFsf49tOOEZSgMT7MHCmsv/WNKvEfWzy5WrjawsTs082fO4H4l3I3pMCNMwhVM+OWJHCHNqQ3iImfjeE5wDn2gqvb8RX5XmmPROm+IshaygdZv5agxrNEmTVEk/H7evX60t0IXcVLL5A96Sfbvc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Mon, 7 Aug 2023 14:17:50 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Julien Grall References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-3-Henry.Wang@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230801034419.2047541-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0348.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::24) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|LV8PR12MB9449:EE_ X-MS-Office365-Filtering-Correlation-Id: 1507a9bb-febf-4e84-062d-08db9748b741 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t/H2lqS1q7ZujHPmFbCz3GgRSvaeQDKQe0qaukueGQzeIVaJPHuPBst/QPZP0trS6Q+o2IGjF7n8ANRV5eip7Cr+JY3wkLANt1CGqP1WbegCh/DDNkUGLyy88H8fkQOLoRO6N29FY6k8IS34sH+Hxr3SX4jnpAYI8kAY3sJ7fSqX+uopwizxzPe5Tdks3/lgT9MIdc0AQy/Qf62v1IeGlEZr5zyqhudcqBLogG0ij1zQhhppbgOHclqwvfGQeWqaIBeF67LuRG9dsmFhzRPzY2xUw/sR8j9JZGTXKHIA6gR83QavGUjDebOAwuWevdnssu8kjPId+jnXocXi/yf4yjlculdBne12yFPNXVJQc6G3Vn8Lq5APSvGgCVri6I39Sn8/hTaYaHbf1JZDQdGLnc3oxZxy/NAMyAw73rvZrhKyTGjjKwHziPSSzUpcCTnAoUzP2MfnIoyQeCew8g4nTTvVi8IEIVQHu1JPc1SIepFll+118b0+Fgq8QdlczsCVd4YCL3GNnkQGyof1DuJsKPNFKJODRcinZd0elZs2P4qlgmPpDM1eEi0JA66gQkJETcK3h6VLKF46PawASihPorszFNG69+J0MPjzmymCih1PTBV+XMJkIBPUo5ZRmNd/Y0CreKdEBUC4Mr8uxD8zwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199021)(1800799003)(186006)(2616005)(6486002)(6666004)(478600001)(31696002)(6512007)(26005)(36756003)(6506007)(53546011)(41300700001)(8936002)(5660300002)(316002)(8676002)(54906003)(2906002)(4326008)(66946007)(66556008)(66476007)(38100700002)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eURNUjRiQTkwcWpGTWJvazhtN3BQV2tFZTljTE5tUjBqaGtyanRiZlBvMFA1?= =?utf-8?B?cWZHbVdUbHFMMHMxWHhjS1FWakpsbWszeGVQUEduaGxUclQ3Mi85eURjODcw?= =?utf-8?B?SDBhMGErVDM0V2taM0VtRk8vR1BhOFRHNC9oWGNaTm1PaDhYdkROVUF6blQ0?= =?utf-8?B?SnZQekdkSFRrekI1Vjh5YjBpNFh0eVpYTXFWa283S09Bc0VOMTBTeS96d1Rr?= =?utf-8?B?VjEyWmthbjlTNldNZXV2NjNXbVVKRFFHb3V6dDhQcG45L0RUWlRPSVA1RndI?= =?utf-8?B?VGRVM3hxQ2FQZFcyVEh2YSt1YVdrcGRocnFvbEppY0FQOGZ2RDlIZS9MU2xZ?= =?utf-8?B?THM3aVJYY2dwQm1VWXRET1UyaU9UUmIyNnBhZ1NnclNZUENaS1BYcUlCRXp1?= =?utf-8?B?aEJQeWl6SVpQS01vNzdmQWNxcnhhK0pscDRoM2t4V1ZnYmQ5eVd0ZS9hd2E4?= =?utf-8?B?VEExRlVYRElacDlkdlh4cnJZWXZmY3htNUpjRnVURXlxc2p5N2h5ZFR5dWww?= =?utf-8?B?YVZjSGFxc0JVVmp0bjBCZlpYQXFBYmlySHhIUlF2ZjJpL1BDMk9JRldGeGtl?= =?utf-8?B?UXMyUFZsUyt2akhUeVRidXM5VG44UDZHOGJIRGo0Z28vSzM4NmlGZVdOY25x?= =?utf-8?B?ZHVOSnAxd0xFK3ZwNkE0UWVWcjg1SjZuNTZhdHZRWmQwcHpNUXJpYzBVN0Va?= =?utf-8?B?UlZ4Y0pBdFlKRnNxOGplM3BPVTJXd1k3Q0xPVkVKK3k1SGFZOWpmNW1YWmYr?= =?utf-8?B?QUdwTjA5MDdQTkUxMDl3SUEwOXFrcWFZRG5teDZ4VnVNQ0dVREhWSjNXU1hC?= =?utf-8?B?NEUyUzhlUHpPRzlXZkptR2lYZ1hjNVZlTExNRkkyN2ZXa3JQeWZnVXlvT0FH?= =?utf-8?B?b0kxcE91R01HNXl4RmQ5STBhQXN6clRtZ2RxQlNDTFBmWnlYV0dVRmNicFhW?= =?utf-8?B?T0taMHp1Tml6VVIwbmZVeWU1RmVGWUFaemlIYW9rZk53TWQ1QTRVdW16UVda?= =?utf-8?B?Znc4TW5YWkJpSXdhTU1EamsxNFJJK202WUlkMTRWcDVVRkxoeFFtS29CM1I2?= =?utf-8?B?QW50enF3aDY5Y2xWQWhmN2tOTEx1MDJFU29hRU5hYWFub2JudnBaTGhuVnB4?= =?utf-8?B?eFJIbjk5WXdvL1c0TFpVanFTNVQ0Y3lOTktZQ2ZINEpaNU51aWhCS3luaDdW?= =?utf-8?B?ditMV3VsalByT1FWRDZzWkFaSVJEWWJNM3hGMnFydndFWm85SEZNY2hNNkxG?= =?utf-8?B?T1VoTnNhNnR1Y1ZsQkJINldWL3Nxc0wza0drSWtQaVZRZ3hNY1QxczFxZHRF?= =?utf-8?B?a29wRXFjbGpjeGdLT1BYSkllc21wVzF6d251aUt4Nk9PQ2VKaU9aRHpzTkZ6?= =?utf-8?B?b2ZqUW4vZmw4NWNaNlpFeFU5ZTJaT0txeDkyK2V4dDJBQ2tuR3pnK3AwT2V4?= =?utf-8?B?R0x4KzgvM0FBZVY2bjBIa2h3K2p2eHBWeTZuQUFJV0ZoVUhIVGJlbHM4cWpX?= =?utf-8?B?eHJBZ1FhdmR2eFIrZTB4eFc2OThpZTZoRXY5WlN2RS9uaWZ1QTMyaFBjS1lh?= =?utf-8?B?ZmlDZjZRbHJ2cjZHZEZ4TlJrcEpPZk5BK2d3Q1FmdURpSnpOcWluQkRKNWdK?= =?utf-8?B?SXAyVVBVeVdXRWQ3eGdwVm9GNldyRGRldUZaa09iT3BIL1BBajV6VTB0N2dG?= =?utf-8?B?cEs2dCtOQVo1eEpPUTlXZHIyNkxKTnJvUjlqeDkrQmtaOFVQZVg1M2hKdDNX?= =?utf-8?B?K1RTdmZjcW1aOHFHZFpyQkwrZHhaU1E2QXNqN0g0dnZvWEhOWUtaM2NGVTZR?= =?utf-8?B?YlB2bjZoSkQ1WWFEVFYyM2dUdWRJTE1pYUppTGZoMnBoR2RtVElmMnVZTkpK?= =?utf-8?B?QlVrbHhKdTl5bHZxZWVTYUtVcmdOSGNYQWlvcnJrOWRzT1JEeXRiMW5aMUFG?= =?utf-8?B?czJyOXI0OWUwNkc5Y2piZjJJRDhPcktDWkovSk5ZUlVIZmJubVg0ZGRqM29Z?= =?utf-8?B?WnkzNllPaG5XanRUbzhkSjlRRHovRkVZck9Yd2tWNWRvaXRyZVpnd2VZMmVv?= =?utf-8?B?ejR2b1dkeUlkSEppUUd0YmcrSGdYTGpBdDIvalA0Y1dVd003Mmd0YzcxSWho?= =?utf-8?Q?zjICOfVN8Z9dTQElMjvQHiurn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1507a9bb-febf-4e84-062d-08db9748b741 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:17:57.3163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jgzCLpULLIyWlu72Lxo7SpPkezYwjEqba77ALeRoCjM2PkoGJ6FciQ0MUZKzzYmGAFPtOIJuQ0RvB/YpIC2eHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9449 Hi Henry, On 01/08/2023 04:44, Henry Wang wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > There are two types of memory system architectures available for > Arm-based systems, namely the Virtual Memory System Architecture (VMSA) > and the Protected Memory System Architecture (PMSA). According to > ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that > controls address translation, access permissions, and memory attribute > determination and checking, for memory accesses made by the PE. And > refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection > scheme where an Memory Protection Unit (MPU) manages instruction and > data access. Currently, Xen only suuports VMSA. > > As a preparation of the Xen MPU (PMSA) support. Introduce a Kconfig > choice under the "Architecture Features" menu for user to choose the > memory system architecture for the system. Since currently only VMSA > is supported, only add the bool CONFIG_HAS_MMU to keep consistent with > the default behavior. User can choose either VMSA or PMSA but not both > in the future after PMSA/MPU is supported in Xen. > > Suggested-by: Julien Grall > Signed-off-by: Henry Wang The patch looks good, but it does not cleanly apply b4 mbox 20230801034419.2047541-3-Henry.Wang@arm.com git am ./20230801034419.2047541-3-Henry.Wang@arm.com.mbx Applying: xen/arm: Introduce 'choice' for memory system architecture error: xen/arch/arm/Kconfig: does not match index Patch failed at 0001 xen/arm: Introduce 'choice' for memory system architecture - Ayan > --- > v4: > - Completely rework "[v3,06/52] xen/arm: introduce CONFIG_HAS_MMU" > --- > xen/arch/arm/Kconfig | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index fd57a82dd2..0e38e9ba17 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -59,6 +59,20 @@ config PADDR_BITS > default 40 if ARM_PA_BITS_40 > default 48 if ARM_64 > > +choice > + prompt "Memory system architecture" > + default HAS_MMU > + help > + User can choose the memory system architecture. > + A Virtual Memory System Architecture (VMSA) provides a Memory Management > + Unit (MMU) that controls address translation, access permissions, and > + memory attribute determination and checking, for memory accesses made by > + the PE. > + > +config HAS_MMU > + bool "MMU for a VMSA system" > +endchoice > + > source "arch/Kconfig" > > config ACPI > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:19:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578407.905890 (Exim 4.92) (envelope-from ) id 1qT08S-0004Ec-Lx; Mon, 07 Aug 2023 13:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578407.905890; Mon, 07 Aug 2023 13:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT08S-0004EV-JM; Mon, 07 Aug 2023 13:19:00 +0000 Received: by outflank-mailman (input) for mailman id 578407; Mon, 07 Aug 2023 13:18:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT08R-0003YZ-8Y for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:18:59 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7903bb7-3524-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 15:18:58 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 169184EE0737; Mon, 7 Aug 2023 15:18:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7903bb7-3524-11ee-b280-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 15:18:58 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2 4/4] x86/setup: address MISRA C:2012 Rule 5.3 In-Reply-To: <55099faa-206a-b7ae-8ef1-64d1dc344c4c@suse.com> References: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> <55099faa-206a-b7ae-8ef1-64d1dc344c4c@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 15:05, Jan Beulich wrote: > On 04.08.2023 10:03, Nicola Vetrini wrote: >> The parameters renamed in the function declaration caused shadowing >> with the homonymous variable in 'xen/common/efi/boot.c'. Renaming >> them also addresses Rule 8.3: >> "All declarations of an object or function shall use the same names >> and type qualifiers". > > Can you explain to me how shadowing can happen in a declaration? I > would focus on 8.3 here, and only mention the other name collision. There's "static struct file __initdata kernel;" in xen/common/efi/boot.c, which is visible when the function is declared. Since renaming these parameter names would have been addressed by Federico for R8.3 anyway, my intention was to address them both. > >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -1577,8 +1577,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> s = map_s; >> if ( s < map_e ) >> { >> - uint64_t mask = (1UL << L2_PAGETABLE_SHIFT) - 1; >> - >> + mask = (1UL << L2_PAGETABLE_SHIFT) - 1; >> map_s = (s + mask) & ~mask; >> map_e &= ~mask; >> init_boot_pages(map_s, map_e); > > Re-using the outer scope variable is a little risky, don't you agree? > It just so happens that below here there's no further use requiring > the earlier value (PAGE_SIZE - 1). This isn't to say I'm opposed, but > it certainly needs evaluating with this in mind (mentioning of which > in the description would have demonstrated that you did consider this > aspect). > > Jan I guess I should have mentioned it -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:21:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578415.905901 (Exim 4.92) (envelope-from ) id 1qT0B4-0005i3-3G; Mon, 07 Aug 2023 13:21:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578415.905901; Mon, 07 Aug 2023 13:21:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0B4-0005hw-0J; Mon, 07 Aug 2023 13:21:42 +0000 Received: by outflank-mailman (input) for mailman id 578415; Mon, 07 Aug 2023 13:21:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0B2-0005ha-JG for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:21:40 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55d3585d-3525-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:21:38 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 09:21:35 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6562.namprd03.prod.outlook.com (2603:10b6:806:1c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:21:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 13:21:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55d3585d-3525-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691414498; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=mMi6LU0PhvDU5U2ndnsFScM6mtJb3RWTKZHASzxOpaY=; b=Ir3PXnn8T0I432bMyykkG4cZtsrt0d0RLmpyRwj6vmnyOO3DUasSFHEm d7OVHa14aPlxdZe578wGa1M1eq4H33KNtsVKoE6wSiE3WnnnYvsvQAjzo eZMhiqOT9jA1nhRShTee9kfHrnkKYcVjq6H9G0LIETy1Q1s2Zo7q1+DpF g=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 118602308 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:z5wKEqyLNaMEbSWpVk16t+cOxyrEfRIJ4+MujC+fZmUNrF6WrkVUn 2oZUG+DPPbea2OjLdF0OYvj8EoBvpPUmN5qSwY5qyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPa8T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KURN+ No6FAsUVCzAhO3ny+vkQ/BIt8t2eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQtuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAdJMTOfjrq4CbFu7z1ciUkc8C0GHuuDjjnenYPdBA E0q5X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqN+7HRoT6sNCw9KW4ZeTRCXQYD+8Pkoow4klTIVNkLLUKuptj8GDW1z zXUqiE73u0XlZRSj/n9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcvlePClKAnVIIyU2g== IronPort-HdrOrdr: A9a23:VUWJla0lpLM/NWRukjSiZAqjBa9xeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtj4fZquz+8T3WB3B8beYOCGghrTEGgG1+ffKlLbak7DH4JmpM Jdmu1FeabN5DtB/LjHCWuDc+rIqePvmM7IuQ6d9QYUcegDUdAe0+4TMHf+LqQZfnghOXN0Lu v/2iIRzADQBUj/I/7LTkXsGIP41q/2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbfyJTzawk+W 3llRW8wqm4qfm0xjLVymeWtv1t6Zfc4+oGIPbJptkeKz3qhArtTIN9W4eatDRwjPCz5E0smN zspQ5lG8ho8Xvecky8vBOo8Qj91zQF7WPk1Daj8DbeiP28YAh/J9tKhIpffBecw008vOtk2K YO+26CrZJYAT7JgSy4vrHzJltXv3vxhUBnvf8YjnRZX4dbQLhNrbYH9EcQNJsbBir15K0uDe ErJsDB4/R9d0+cchnizyJS6e3pek52MgaNQ0AEtMDQ+z9KnEphx09d/8AblmdozuNLd7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeE6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSSAtAzWu4NjDqVCy/jBrOKBC1zGdLluqbrvnxwnOLyZZx 7pU6gmRMMKLgPVaPJ0NkPFKt9vwEIlIb4oU+YAKiOzS/3wW/3XX8zgAYDuzenWYH8Zc1K6JE c/dx7OA+gFxnyXexbD8W3ssjXWCwPCwa4= X-Talos-CUID: 9a23:0RRe6W9E//k2FqNC7oWVv2sXF+YHTkbE9kuTIEDpAj82QaSxeFDFrQ== X-Talos-MUID: 9a23:wKaRwwkTlWD3kOTIBIrsdnprD/YyuY7wEnwWiM8CgtC/EDJbOgmC2WE= X-IronPort-AV: E=Sophos;i="6.01,262,1684814400"; d="scan'208";a="118602308" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MON3IxxoAS1ajR3iKRckyouIR46ne9G6xi+eEAjD4AsLgN9RsFVbdGp+Gn0MbbP8vLea9xJOptFiNAnchOz7DLi76kKYjFpKDkywyZ3he6uQh6v/PExARssptFWuaMKaF4t/8kiq901QZcjOYD4ejzRnQ6QYLLwRcrMlbtt7uCFGIIyNI6X31oN01q82zV1m8i2uL/OvFS0GFt9EsKssaVmu6AW1V09+oQZwZKejylEoBLKl8AMo/aQTNeULHXSQM4kElUQaQWi9bzHE21Yx5dLTYOpcVgogv3Rv0q1mVAOlg+NRuffskPKxw94fe4vFvEc3d6zDrgtGbWZMA/nEag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wbwdwUYbSmncgELkjSuam2FjUmRyNBwN5M+qmKUJ+9w=; b=dQbeWjnq0VafQa5sLmwGDjie366oRh+LWyjjNLlsKCBsqhjF2S2CLXPyv+iw69sBv3HZ/NoecO87jekE9YBP2FPF3Yo2NczMTP5x7PyDU4UoZT7dI/ApXYSpGYT5o3HMaL6P1r3Ij5FWjhgPBJ7Dwd/3/KNpoKoPCYiBNRv1EIX9cf9ozI1rZidS4SV2LWJPvAUNTI4lOKFTMHbw7+3oIi656IY1vQvhIlVF1ItNESmMEPuS6NhyeTU69ymP+2mvF0Zr3pFhSBEiWTBbfoiKf/u139u7/Jg66UH+DdPjxelCeGrfgvERee3NtrDgiVIWCYPvn+sghhVNam6HiMFr8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wbwdwUYbSmncgELkjSuam2FjUmRyNBwN5M+qmKUJ+9w=; b=qTOqjEjt+mv34qpYP7A4/4quweTqhlGjv2ysZJiEMYVRF6bwAzWa+MCVJlYhU5DWviPdsGKcAMgwLNMpMTI3S4idD5lb8rtL68p+/06LP9uqKtI05uw4rNYdCQS4IuPK4KuIJ8O6EUlj8uRi779MERA5ggUggiDadVvlKTO34vA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <6a22f4d7-e0f6-67f5-ba44-af0a07523c4e@citrix.com> Date: Mon, 7 Aug 2023 14:21:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] x86: Drop opt_pku entirely Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Henry Wang , Xen-devel References: <20230620174704.3907275-1-andrew.cooper3@citrix.com> <3daf5b51-cf5f-b9c7-b02e-0db5b48aa03f@suse.com> In-Reply-To: <3daf5b51-cf5f-b9c7-b02e-0db5b48aa03f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0133.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA1PR03MB6562:EE_ X-MS-Office365-Filtering-Correlation-Id: 96f695e0-61b8-42e7-2478-08db97493687 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9d64nLsu7V2po0dEnZPCbLW787hkT/N+NGmB1YPWHYv5jq5uuaHlDuNYVhfFRpM8iRkLn8a6RnABzGBuUrG1w5a7aQZW7N92Bt/p2FdX4jCxM1Bg+CioOCqiffL1MLms2bSJFj8q6oMYs3U6LC9nIAC3/18/+N48QH41Htpiq612y/0kz4JmQ77vTbHJaMaxsKmDstZeue8SxuJ4VWOJI1ki1rkJ9rkXp8nFUySjJey1GyoavbyKTxkikYhkb8whD0jzWBe88bR0xMJJK5+3bIFaPnuK/DqhAK6S1kqsJ5m6AoqKpU+VRvQtUUoef6oZztTpr0JLMWl3yIMk0Mkqf4qaO8NW9uEbEpeEwRp3BttQ3Cbw0GGAA/XK64Lg7SjYffn+ZEm5RU40DlwqJGimzw3dq7iiLPoy9OGw7bSsNVV/oFajTvxSaueZmasu8NOmB4vqRY3QRuU6uT4SS5bkihiRoy3XCzJC+0nLHTqQG2XdhYqoWz6sGtJvMOQWW/HaEmZ84t5X7t4klT/QGpQe55HiNm7pkeVIJXs7XlcpStfe7Cs1Pu9LfDclmRgrR+8SybimFR+hI1VxNpej9+YUk2zVD+4lJmMaGWKvmWOjKFaq1UsXpUnhR1J0csNF24lJ+0E3neolTmd1EjkJxe6gkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(451199021)(1800799003)(186006)(2906002)(36756003)(83380400001)(5660300002)(2616005)(54906003)(6666004)(38100700002)(6486002)(66476007)(66556008)(6916009)(66946007)(6512007)(82960400001)(4326008)(316002)(31686004)(41300700001)(86362001)(31696002)(8936002)(26005)(8676002)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1VhNC9Sa3VDSkNVbkRqNXNDY1NzekFZZU1zeVpYZE1QWW9CQWZUQXkxLzFl?= =?utf-8?B?NSt1Vk5FZGFVN1hkdmdNN21VTTZRYXVtQ3hQdHRrSE9LQlhVUXh2UjRYN1Bh?= =?utf-8?B?ZUJ3K2ZYY1U4d3hVQ1RXUFIrSHZpZGZGcjE1VVZQSE53UkJFbVg1TURpZ1hI?= =?utf-8?B?TUc0Skp2elRyNklya2QvOW5Fd3ZlSk04NUdyUGlUL0dSWU5GbWQrZ01FNFdl?= =?utf-8?B?dS9ldGpZOTRHWllyUXhFTEUwSDJsMDlyNExIOTk4VlViOTBiY2N5LzBZZFRS?= =?utf-8?B?cUZIWWt3VWN2SWlXL1F1c2E5THRNaWlwQXdSM3RFS0xPcXZxcmpub3A0OXZh?= =?utf-8?B?a1JYM2ZpZ0xiN0dhR2pKVEs4U01Bd2RWSEpFMHl1K2VpZ0kzMmE0cWpxQVlt?= =?utf-8?B?K3BJOWs1b1g2ak5YZ05FR1d4SWF3aWdyRm55cUZ1dy9nMTErbzNsWnJ3bjlS?= =?utf-8?B?T05KaFF1UlEyWnhtVjRPaXNmY0s5OC9kUERBZFNXQjVwR1dzaE5JTnBGQVdG?= =?utf-8?B?WWVLU0N0dWtCNkt6OTdvZHRLNlRVS3RMQzVnMWdKSDFZNVJUMG03eEo2YzJq?= =?utf-8?B?Z3ZoQ3Zsa1cyOFgvZzE4TnM5bFNHM1h5SFZhbFBPRjJtS21RcWRpaXNlcW5R?= =?utf-8?B?NXFZcGk2cmtnV2xwd1doakU4emJuNER3eUdFc0JucVBkaHJMUEdGZlJQeFFo?= =?utf-8?B?UDRoaGZCWjEyWDJWaW96dUw3ZmpvdGo0VU5hcjFmUEg1MlpUdmw4ZjBWamdL?= =?utf-8?B?Z3dFYWxZeGhCUE1XUG1FaEJQOHJ0aFhFL0NtZzNhQk15cTJVRzRYVWozcnZz?= =?utf-8?B?SmhqVi9kNktXSzBMdlJ0THNXU0tVTzlNbWtPYm5jdkhSWktrRE5iOGpzaUdX?= =?utf-8?B?ZFdZZ2dUY2duRmtQalJKZlllWVUwR1NaL250bkd4dGY2U3JBUnRrNTVyTXU4?= =?utf-8?B?azhzaEdqYkRVc1lkWTYzaUtsNjV2ZmFWdW1YNCtUN3BuVDd5T0QyL3VZWHp4?= =?utf-8?B?SEszUnVJMDhRM3dMVnNIQTJrdXRnQ29HbnBQKzFuaUQwZHZtNmRDNWcxVXQ1?= =?utf-8?B?NnlueWtXZm5wZ2dLWTAyR2hlQjg0QnN0QTd1eXM5bVIyenV6elVIYzZhcEJO?= =?utf-8?B?VzNYMGdzVFBDSWFtdVIwcy9zcDEycCtzRlcxVDFoU3JmQWJKQ2Q0NzJVd1Q2?= =?utf-8?B?NUFTUHl5QUNEaGN5TTZ4ZUQzRlVybFYvZ0R5S0VvRWppQmpRSmpNT0RoelRj?= =?utf-8?B?TnpwdzV6RnZZL3hHVEUyeXF1YWtGODZ0OTlUcHcxMEFreGRDWjBJaWpKeWtt?= =?utf-8?B?V3hqdnNwdkJYelU5K0FFL1lZR3pnRUdkVlBwNXVobEFZbUhpQnBkcDhBaXRh?= =?utf-8?B?WUx6ZHlycHpUYnJZenBwZVMvK0Z2T25yaGdMRXJGOVZtdWlZbEQwL0lsZWFT?= =?utf-8?B?UndnSS9TTzFRV3RoK2dicWZEdm5YZUdXUDRnbDl1blQzTnN0OWNldm8vUFJa?= =?utf-8?B?dXVJL3c0VzMrNkhOZ1luVHBOOXp3R21weDNXRzRPbWQveFRZbFdodXdFRG5Q?= =?utf-8?B?WkdnRkgvY1dKZXkrUzlCOWVtdDVyYklQYlVhbDkwbTNRdFZJWEpOOXNFOElu?= =?utf-8?B?Y1R4YmFBcmx6ZkFNUXpXQmpEdEc3Zm5HQjM3RVM5bzJoaVFvVmlZV1dMTU5l?= =?utf-8?B?SEVXTmhlWXFDVWpwSUJBNE1MSU1VOENqak1VV25jRUNYM1ViTmxGTGNaaGha?= =?utf-8?B?TTRHYkFub2xqN0ZEbVhVUVpVZ3VVcG5KNFdoVFFBajdUREFETC9WU2t1VDF4?= =?utf-8?B?SytsMGVWaVE1ektXcysxOXNtdi9wbEsrbGRtbFdHTS9SVmhnemcrdGNVcFlK?= =?utf-8?B?aVU4anNndHVybUQ5N3pZVTAya2I3dmFDYU5XS011d3kwZjJWeVZsYnZ1T0lj?= =?utf-8?B?cjdDRHc5RFROdTRoUmFIME1YVHArbVhlb21kMEt1VlVWUlZua3N1b1Y3amNZ?= =?utf-8?B?dXRpYzl0M21SbE5NbS8xNnhYYWFqWm9aRVJjZHZTVDllVkF0U083YVlMUWJQ?= =?utf-8?B?RXNab1FMZkd2MC91RUUvSExwUDFHTGVGTDFXZGJWM3JNWWlyYzY0SWF0b21z?= =?utf-8?B?LzE1cHV3aHdzckpnRHdQcTlBK1lOUlMyd2g0WjNibjZGMFY0OXJmdHdwRGw3?= =?utf-8?B?c1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IwhUVz9MJMfTQ0sZ2A3GQP7JxwNOYP/f/UWMiLy11a66ent199cWPeymzTdBrya5AhLMWeX3x+6Rk03JXEbNsnAMNljvFhgmTOs4zw0TgshEMwvtg8xv3Pjv15cIynHqfyHbr6s4oll2QGrhbN4etdsD8VFSVt4AtUhkeOv5O9rYhJhve7V7mAY277mzoAVVYTJkPCt+ijIWwb4+YWw4p59FDgaze2C5OUf/By8GMuBzmC1/Uhqp38RWMCQyxIhcjGlc02sXPlMqN8DI6/oam2nbfd1zNSaxxNeoFyIYYybLORQD2tlQE6J8zebplmj/cZmr+53EuwmZvv09oD6mDxpSOov1TSIx8Bap6GYWDP6sJnC3qHShD0cVvrWu67kc5i/kqhsZ8nwQ3b3v0kCFY5brUC4+SoqqyZfvonudmf8zIymT910pZK86bwy+Cf5YxCr9eGSraix4w6RjsdHildn9atH/xMUCvp/M7r3nz/edggUQJWZTUd+O97ssdzmWOXvFwZ7XpM8D2UH8R1vF2EPF0KtdLWAkAp29yWbf1KQKz1em8/7WIyfwk0D2Ay3ZV+rkp4otMtbqBd+4YSp2suHnMtfdbtSKOAs96LHfgzmwUhQMzFDvB5cAs20Hhajo9pAlYPh+ffZjfi9BTOd4dg9tH/a803XQfR2wn7wmaMJuEX1WKhVtkiZNL5/mSvrGQUyhN2eeiay3DNSKB9tYsHZaMKQnjmhtJXffZpixfv7YAAuPguJ33nHzQcUleP7cNSmc2R/DD5OEEfXiDD2X6ccsPKbJEZQyzkTHE0LyuBU4CYTTGUHrmT1ShDytVSxVYdVWyXDri84D23oDqatQNg== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96f695e0-61b8-42e7-2478-08db97493687 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:21:31.4512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLRTApKzHjj9aAHoAAzjDeWfIz89LBCBp3nfZ3g0ZzDGoaVEHEjMTHvTtZW+yDhPqFbAMPAuPqgZHLNGA3klR7VmyQOu9pyqJMSumU2r1Bk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6562 On 21/06/2023 8:37 am, Jan Beulich wrote: > On 20.06.2023 19:47, Andrew Cooper wrote: >> --- a/CHANGELOG.md >> +++ b/CHANGELOG.md >> @@ -25,6 +25,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >> - Add support for AVX512-FP16 on x86. >> - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech Preview) >> >> +### Removed >> + - On x86, the "pku" command line option has been removed. It has never >> + behaved precisely as described, and redundant with "cpuid=no-pku". > Nit: Missing "was"? Fixed > >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -1950,16 +1950,6 @@ for all of them (`true`), only for those subject to XPTI (`xpti`) or for >> those not subject to XPTI (`no-xpti`). The feature is used only in case >> INVPCID is supported and not disabled via `invpcid=false`. >> >> -### pku (x86) >> -> `= ` >> - >> -> Default: `true` >> - >> -Flag to enable Memory Protection Keys. >> - >> -The protection-key feature provides an additional mechanism by which IA-32e >> -paging controls access to usermode addresses. >> - >> ### ple_gap >> > `= ` > Elsewhere you said that we kind of imply that only the explicitly named > sub-options of cpuid= are supported. If that's the case (which could do > with saying more explicitly), you will want to add "pku" there in order > to not regress what is (deemed) supported. I disagree.  I can say it was equivalent to X without X being an explicitly supported option. PKU shouldn't be adjusted by either of these options; it should be controlled in the VM config file (if at all).  I'm unwilling to make any suggestion that this is supported. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:23:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578421.905911 (Exim 4.92) (envelope-from ) id 1qT0CU-0006J7-HM; Mon, 07 Aug 2023 13:23:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578421.905911; Mon, 07 Aug 2023 13:23:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0CU-0006J0-DS; Mon, 07 Aug 2023 13:23:10 +0000 Received: by outflank-mailman (input) for mailman id 578421; Mon, 07 Aug 2023 13:23:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0CT-0006Iu-1k for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:23:09 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on20631.outbound.protection.outlook.com [2a01:111:f400:7eb2::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b6821a6-3525-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 15:23:07 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by SA1PR12MB6969.namprd12.prod.outlook.com (2603:10b6:806:24c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:22:59 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::4541:2a3d:737d:b194%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:23:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b6821a6-3525-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jrwEdPKTuEWfYehSKQdUXa9JyNH6WCN2ArDj0jlIS4anz6nY3czwvAhDvOB17zYm5ldAXmaH+NYWSjIOuMOZ4BGfmpOt8Pcbf0xs73hmIGpYAlM/etM4GIlzYSrDRjYpAPEbusR63lSB0cHAMdvDZ5qNtpWQYnyJnq5RVPhke/h2c7P/DyEhjGHAELe/3FqK4cC4K5aPQdTgvI3P3OBTBr8R2wPcB7mj1Pi1uFu5b6/liRZ82tB8KrK/KWhKhOiDZsdnx7f1q0lLLuUh9h2LNgEt0p3GTH5VQySIj/9vCjvL3hsqtbQvlnwhjxY7CZgQJLy6bfiZ9LNY8ejmncPdrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m5U2DaR2mLr8BtOdeke40BhnOPacsz+xThXxLeg48kg=; b=dqZDh6PH2sY0yKgEBwYXhgudYTDAzpbawPtuBIUCXxFVTXi03ABvxrARyoQPH47HLn3Wr7ncbGcJ8PJW2dfwjD2R/nZ/vA7fBWtQne1+3mhNVhb39x3E6xP5/5EESYcYm8IVL1B8ExZjsx3uSCRLXeLh0ezcJRRPOqyQ8F5aHiXtOhzUgDGwPc131KKEkpYQHk6duhbbowdazpDatEh7Q12gIQdMpZKmk11rVYPLfQvfjDFmYuF2lLR90lJXEq0FMElA6ly14Zs2Kh258GgXO5gbvB4XlKOb4ltdQbZEcMfPM2A/uoJlTCnaIi6cRaayUdddgGSt+68LozsXdxxZfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m5U2DaR2mLr8BtOdeke40BhnOPacsz+xThXxLeg48kg=; b=nAIFvbPqc2l7QgG6z784H4LYaQPYuLeLxASrqH/rAeRptQ17Ba9m/jh2Cmmd/r+rZnokIRiSRI+qxEIibIUpvWPXgAncReApMWt54pEWFxt6ryY4rE0r7GbCzw0oRCoy9Lrhvdb+lPw4ZK4JU+7EByPtelUROnIAU7G6oFsjn/0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: <24eba373-edc8-e2dd-5d5f-34c7f0865d5f@amd.com> Date: Mon, 7 Aug 2023 14:22:55 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S To: Henry Wang , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-4-Henry.Wang@arm.com> From: Ayan Kumar Halder In-Reply-To: <20230801034419.2047541-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0005.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:338::10) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|SA1PR12MB6969:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cabf411-b2e1-4879-59ff-08db97496cf8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ki7fQ6A3aXWz3idyg2Owlx2UlIVDWTCmOUVpSEESyog5EeMd/QdVMnQ0arldhcfupuD5EGUo15iF649+C+tdN88Xh4f3CE6e6KHGgS9eczE4eBX9i3/CVnkQoIM4hLAe10tJO+cVaeuillN/qc135j2FJNTYxI89HfNuBe64h3832BBU6vjtkPRgbPRdI0ME1lPoX48SjheQA/g/Fqdpxe8zkCKQtAyZ39vJ+8lxtebthgjoBuC8B3PP3cSUtV3Tkuag45NVqqXeVDLAcht6uDG0pLFx7sB9cH1eKQhZjbnzkh6qI+WzTI3HPWjOND2IeNen+3mhUwFdvEvOXxjNPbBmcjct06C/LAk7Gu7olKivgK/YqPHlM3iNUIQ7t3IUJcYbzpGoTF3lSKKqGhgi7Ym+mxeBJHCsp3adulNJWdXxGGs0JPxlRhR+sjBg6RSnBU2UajlQuyvoJxs0AnJHa80nxIO57Nh6sVlrwXZVGyRgd3lh1ED7XRiWAEg0RIwB9+0FFiJ9rhhlHo+vYbhdCPlgkT53hI73mnuugYaI+k/uy+35u4mM3mKuQWqx8H4ZYu6+hQGlOINxWsP+auvdk2zwUW7sUhO8gbCSMXdeeB20Vvu1lz76YXOCrNHyB8nmGG36UPdKa2xA6G+g/5esVg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199021)(1800799003)(186006)(36756003)(2906002)(83380400001)(5660300002)(2616005)(54906003)(6666004)(38100700002)(6486002)(66476007)(66556008)(66946007)(6512007)(4326008)(316002)(31686004)(41300700001)(31696002)(8676002)(8936002)(26005)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHJ0OHl5QVloczlNYkhNY2pZNG1ZTzJNcFZZbFlqU0hHTUpqRC9uVDZ0NkVB?= =?utf-8?B?MU03Z3FBWk0vQ2RzcmlhVHliRW94Um5MelFTaTBNZW1GWkUwd1Ztc0dUWWRG?= =?utf-8?B?WlpkRzh0YXZsek5zbXdocGVlRzJNeHlSbmg3UWhXT1VCYTZ5V2NmZmlESUJQ?= =?utf-8?B?bWRpc0IramtUVDk1bnF6QnVITU43OUNidE5Yd2VWV2xtR3BwSCs5MlRpQ0Yy?= =?utf-8?B?NWRWdjh3VmR1ZW9DZFVnVy9ZOWRiVkFER0c4TFFYRUJKRnRaMGR0UExTTklj?= =?utf-8?B?RkZwaGlEbjAzdEtSUjc2OGF5S2NCVjQyUWlkTEphSzF5Y2N5ZTJ4QjhvelUx?= =?utf-8?B?ZUFUdUdDRUkzWWV4YmgvWTEzbTBCeWVWVGptaE5PZ2NCcXpSWGY1dFo3R0I0?= =?utf-8?B?Y0ltNnFjR3NOcTVNa3l0U1NHMVM4RXQ4RzFWV0NGRjRmd1psb3NQaFVzWCtK?= =?utf-8?B?TFNpTjRNbFFsRFNkY3BrdmRKRjlaOXl0RTZZZTE0ZWtUcjJrd3NLTGZsTzNE?= =?utf-8?B?VHkyc1k3WDRubnN6RG44eUhXTGNHQ3hDWEhId3pieEUwTXY4Tyt6ZTR0eWRi?= =?utf-8?B?cytJVGdVMFRGOTh1UGFJSlBCL3dIUHBaaklCQXROUGJIRVg3UWhKZld4U0Uv?= =?utf-8?B?ZGZlVjZabDNlQVVjR1RTS1NNNm1odlM0andkRDNqY3dyeUNrSGt3aGw3R2gr?= =?utf-8?B?NG8wUlErb2QwZGZtQ1R4WWtyS2lpZ2Q2akNuVE90NlJFRUVENGErVTNlWUNI?= =?utf-8?B?Z1BreHdiSVhldDVSaFZwaTVLbmEvNUtjeXdmOUVFbXNwdHRxdFJzZVFwS1pP?= =?utf-8?B?QnhqLytYVC9uQ2loWmFvbi9RbzBmWWh6TThBWUV6VjZSeTRmdEUxTUlGSDBj?= =?utf-8?B?MzdOWEloSVJUNUt0SENLdS83YW9tRVF5c1lURU5tWFVhNTJuc2szbEZrK1Q2?= =?utf-8?B?SmpjZWNWL1dibEF6RWlRMGdrTTRlMkZveHlxRXpkR1c0dGhETklKekdkU1o2?= =?utf-8?B?dkFCNTdiclJ4eWdOaVhpdE1Ga2Jsd25tUnBkM3FqM2EyMVhoVExOTzVWc3NL?= =?utf-8?B?bDlGbmppQlhzY2xGMGVTRHBKdzQvQm5qYTBhRy9kRlJLNEpEZUFFSFBxZzdC?= =?utf-8?B?ZURUTVlqdzY2bWQ5N2RSeUl4L2syTU04UXBoSjJFRmdMQmoxeVFvSnFScWJh?= =?utf-8?B?dU4zUEh1WXVBZ0V6cDVWZlJzOHpZZGlBV3hYOXhQcll5WFNjY1RzbWRwbSth?= =?utf-8?B?dWdkVGVrc21IZi9XUHlnTnJWTzRISWloUVY2SzREV2pYaXN6R05qVlpSVytW?= =?utf-8?B?Q2x3U2dZWENEcDJFQWwrNmVCZ1pyZUphMS9yWU02a3Q1eVZudzZPQ2Vzd1lz?= =?utf-8?B?TDBIVVBsSzhIRm9MdWVuenp0RUtSY3NuZDZvTkJINzZrMkJiN3JqdGM5ejBs?= =?utf-8?B?enRsUFREdmtXdjZDRnBnbmFSaDNwU3ZUL014WFBMUjB4RFFSemU0dDMyalZM?= =?utf-8?B?c2dTMFpDczNScXBVQmlpUTM3VVFYMFlCaFJlNUpPbjhwcGl4b2drdWtqYjg1?= =?utf-8?B?TThIWTd2VEJ5cWFsZnhoY1RpU05WUlRvazZsY0tpOGVzdGh6Q2NXL2tnSXgx?= =?utf-8?B?RXB5UkdJRVU0U3NVcUhKNGJ1VWQvNmt4bklXUjRYbXZCVGkxY25kS0tOYTBl?= =?utf-8?B?d1ZmK05IcE9CTkNYN1dUSEk3cUI2aWRVUFZlaE50TnRIMEVndWJNMXpTRnBy?= =?utf-8?B?RzhXWW9QU2Rna2Q5TWorTFZ6MGtQVCsvanNSSSs0S3g0TXlaV04wWldnQzBE?= =?utf-8?B?Tmo2cEpTSENaLzhZZzllbmtzbXlncFdPL0J1aXQ0d3F3ZGx1ZkdDTWxLTVky?= =?utf-8?B?d0VVSUt1eTNvU2FyQXBEN3puUFhlQk81dG1XMjFtRldlV0UybzBOcjRyajky?= =?utf-8?B?TGJLdWtnN2hhbVVRREpKWDE3WnBwMVg4bjJDM25Dc0xWQWQraERTdkxDbDNl?= =?utf-8?B?L0ovMkExTVRTaVYrOE92bmlndkFvaUp3Q1l0dUdPcjhZeFdpd0lwQ3M3RDZO?= =?utf-8?B?eTJJbU50NzhvT1lMK29hR1BTS2drV0FrS0txa2tzVTNzUDBuYmZrRWNyaFEy?= =?utf-8?Q?NO++M3zy37jLQlEqrKDLGo/SZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cabf411-b2e1-4879-59ff-08db97496cf8 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:23:02.2081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aEFjBDZGDpRRMifjiNuMK0VQNwfRC5sIhRe8vv7jrixMXDqYsVrAC038j6oMebdc/rB6JVnffWcdk7WNr03x0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6969 On 01/08/2023 04:44, Henry Wang wrote: > CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. > > > From: Wei Chen > > We want to reuse head.S for MPU systems, but there are some > code are implemented for MMU systems only. We will move such > code to another MMU specific file. But before that we will > do some indentations fix in this patch to make them be easier > for reviewing: > 1. Fix the indentations and incorrect style of code comments. > 2. Fix the indentations for .text.header section. > 3. Rename puts() to asm_puts() for global export > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > Signed-off-by: Henry Wang Reviewed-by: Ayan Kumar Halder > --- > v4: > - Rebase to pick the adr -> adr_l change in PRINT(_s). > - Correct in-code comment for asm_puts() and add a note to > mention that asm_puts() should be only called from assembly. > - Drop redundant puts (now asm_puts) under CONFIG_EARLY_PRINTK. > v3: > - fix commit message > - Rename puts() to asm_puts() for global export > v2: > - New patch. > --- > xen/arch/arm/arm64/head.S | 46 ++++++++++++++++++++------------------- > 1 file changed, 24 insertions(+), 22 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 2af9f974d5..b29bffce5b 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -94,7 +94,7 @@ > #define PRINT(_s) \ > mov x3, lr ; \ > adr_l x0, 98f ; \ > - bl puts ; \ > + bl asm_puts ; \ > mov lr, x3 ; \ > RODATA_STR(98, _s) > > @@ -136,21 +136,21 @@ > add \xb, \xb, x20 > .endm > > - .section .text.header, "ax", %progbits > - /*.aarch64*/ > +.section .text.header, "ax", %progbits > +/*.aarch64*/ > > - /* > - * Kernel startup entry point. > - * --------------------------- > - * > - * The requirements are: > - * MMU = off, D-cache = off, I-cache = on or off, > - * x0 = physical address to the FDT blob. > - * > - * This must be the very first address in the loaded image. > - * It should be linked at XEN_VIRT_START, and loaded at any > - * 4K-aligned address. > - */ > +/* > + * Kernel startup entry point. > + * --------------------------- > + * > + * The requirements are: > + * MMU = off, D-cache = off, I-cache = on or off, > + * x0 = physical address to the FDT blob. > + * > + * This must be the very first address in the loaded image. > + * It should be linked at XEN_VIRT_START, and loaded at any > + * 4K-aligned address. > + */ > > GLOBAL(start) > /* > @@ -535,7 +535,7 @@ ENDPROC(cpu_init) > * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd > * level table (i.e page granularity) is supported. > * > - * ptbl: table symbol where the entry will be created > + * ptbl: table symbol where the entry will be created > * virt: virtual address > * phys: physical address (should be page aligned) > * tmp1: scratch register > @@ -970,19 +970,22 @@ init_uart: > ret > ENDPROC(init_uart) > > -/* Print early debug messages. > +/* > + * Print early debug messages. > + * Note: This function is only supposed to be called from assembly. > * x0: Nul-terminated string to print. > * x23: Early UART base address > - * Clobbers x0-x1 */ > -puts: > + * Clobbers x0-x1 > + */ > +ENTRY(asm_puts) > early_uart_ready x23, 1 > ldrb w1, [x0], #1 /* Load next char */ > cbz w1, 1f /* Exit on nul */ > early_uart_transmit x23, w1 > - b puts > + b asm_puts > 1: > ret > -ENDPROC(puts) > +ENDPROC(asm_puts) > > /* > * Print a 64-bit number in hex. > @@ -1012,7 +1015,6 @@ hex: .ascii "0123456789abcdef" > > ENTRY(early_puts) > init_uart: > -puts: > putn: ret > > #endif /* !CONFIG_EARLY_PRINTK */ > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:29:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:29:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578429.905920 (Exim 4.92) (envelope-from ) id 1qT0IX-00074D-55; Mon, 07 Aug 2023 13:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578429.905920; Mon, 07 Aug 2023 13:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0IX-000746-2T; Mon, 07 Aug 2023 13:29:25 +0000 Received: by outflank-mailman (input) for mailman id 578429; Mon, 07 Aug 2023 13:29:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0IW-00073y-1a for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:29:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060c.outbound.protection.outlook.com [2a01:111:f400:7e1a::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bd8c72d-3526-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 15:29:23 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8941.eurprd04.prod.outlook.com (2603:10a6:102:20c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:29:20 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:29:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bd8c72d-3526-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Flju2MdSF03fpBkJTuEOnCGflUg81yF+uM3bx+rH5FXPPOA90lR8D07hTRZml4pPOqtJVh2wcu1CzufxDa4RQpTrMEEAvkFwcp7SlQ0ATB68Ye4Wf6N9MYHfMI+kBygdsESG+k0H+GyzZGHak8AoWUl7I14LJ9lC/3EDAnnytQyiwYDb7sqNzzgjrTuqXlxGkpnhxb3WH8AA6hX3WESKETMiN0heRnrnUzhXZan/XcoSBphp8dqYit5csbYR8rzd0k5W1o0mrL8sCWymG3GP3pD6rN1cxWI6tzB/iB8WA2M/F9hi2cYYzyx6FNsBcDeSDGe8jN1HXtiTWm27ZKzq6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h4HW7BqjobAEvFwiwH3Z+boBfDXBy9EiSDKFqrki6tM=; b=QcFfXy6hYZT0mRM2bf2vGA7DdRJ5HncStsF7HXBbKrX67Mvt73Zp6kIDygHSIi8h2gI7wxDN/ImDTP5zOcxzJkbGLzjUOZtYAYgtHP/zrEb0QEzhT/xYDn6tpKDDi3ARuZGQguGk+zhl2uAkMPzINTXXGUazbyV6Ma/xTBuGEF3MSpGn9czRPaeaoQZNVyguFfKTT8UOSPUlQh9F0uiXUU3KBnSfnXXKTb2ewnUA26em4j3p0gUrOs6YGT70vdymyTt45aVuW+leVwiLJTPd20ACzvhVXnJgwcLWr+rsl+UkWtkNSi4gCEG+cAXoZ0FzTNG7ueJPN1GyaWd4dQuTWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h4HW7BqjobAEvFwiwH3Z+boBfDXBy9EiSDKFqrki6tM=; b=jHAhbgjW/OZ9WXiKABOwKSL8Dhetbgz+2FK5HDMeTLT6+Ae2kmq64Qavdznv3MU9b6LutOq47G3BOT91vnzKa5l00I0cw4WPQVmCmISUsUhvsUNNNCb4eC3d4nUGlx33dIejMP0PE1XYz85qnLHFkzlWgGptmAp1PvdAW5mdKuBv6DxdRGKCY/vd3ypJ/e3Jxxa4ssgXxaU+GoYVbEqdhsidDI76uii0UV5Nhse6YYZGtRY56HFpQfxhSH0eMGv+J6J4rQRL5j1ELXzrXOm+0qDmTI4N2ZMEeUVBRDSv3jsHwKYATQZH7styDMgGYZYbNDRbxHWKsQzRe4eaOnb9wg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8098e465-d25c-7fe4-dd97-2f44a689c9a6@suse.com> Date: Mon, 7 Aug 2023 15:29:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v7 5/6] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii Kurochko Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <9fdda7716faf412f1e2cdf9a990c98e64c4b21f3.1691063432.git.oleksii.kurochko@gmail.com> From: Jan Beulich In-Reply-To: <9fdda7716faf412f1e2cdf9a990c98e64c4b21f3.1691063432.git.oleksii.kurochko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8941:EE_ X-MS-Office365-Filtering-Correlation-Id: cdc516e1-fea4-4327-2dea-08db974a4ea3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wZtnhY84ZNZavxTwMnVWRhlBBa9SKDAfAkXLNNqGZB9SFXaeziUWejgzmqb4GeNBXSUTTmL3l9BvAFJcL1YJPYF3VxQfWvflRU56TK9g+/aEoLjkXsyHkH8AT4Sxi2zELezvtUBjm24jnaXlnIHX05mh4u/IngGshCVSN/904DQxn4OYDwN1OSgyXLxM89WG9FIz/vjG+Q/rTssecPL1u46SElFq/u8Pb4wJW+cmEoE/1JmUQrhcEryvVdb42vPCLmmc77ujM9ckPpg+lvA3BHRNu6ioQE99GatmZ2TzM3hMooKYi4Z8CAvEpg2sTSXKy20ljVmGBKcykAed1IDA+4xyuVblynPpVJ7nRJBFWde6gLkrqM68KZxWpil1rl1DBbP1t68CIlB/dxNKVORfFpJR9y5JSEtXcrC/F6m4A69qeBHP6b8I6MsbAdMm/3a3dtYWESO8I155XRcAdkIDv0dEu8xxGhoizrQgUUMJgYeoZvBbV6rTmLsANlMPwoOd/tliadFVf2hLcE+8i9hAL7HKvVKzG6FCqJY1vjYZ2jIO4wykPAUvQXMxA5FBz7Ys/uV0DzL1449DZ7zIt+4B8JlHK+iQ9aMzg4copNTI5FZLiMpk0xciHIlPVl49lRU5Dl836xSEft+DR6KoChs1aw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(39860400002)(366004)(136003)(346002)(451199021)(1800799003)(186006)(41300700001)(38100700002)(6512007)(6486002)(6506007)(53546011)(2616005)(26005)(316002)(54906003)(86362001)(31696002)(478600001)(2906002)(66476007)(6916009)(4326008)(66946007)(36756003)(66556008)(31686004)(8676002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFZOZlNDU1Y4K2RBL2VVbEI1ZmlORHRtczgwY0xCaVFHb3BYNDM5R0FSMW5T?= =?utf-8?B?K0pRKzR5U1Nva3YrVzFMb3VYelg1bDhWajAycDBKcUVONFdMaWl5dkpiS3Zp?= =?utf-8?B?aVJOV0JPcVhpd1FrNU1QakgybHlzUTYyYmh0bmJRODlLelJZKzRxQ3M0dVJR?= =?utf-8?B?QnpYTDZSR0hJREo3UVFBRURZTFkvM3lNcURlN0hyaHMrZU1Vb0tTd1V0V3J5?= =?utf-8?B?aStoQlAzK05xZjZINEUwQVliZHg3TU9xQTBqeFo2MzBTRUtxaHdZaHpnc3lJ?= =?utf-8?B?VkdtdWNtZkdmeFJPeVFGSUtKRXFId09JTzlBUUZhVDRHUDEwdGlLVFVhTVA5?= =?utf-8?B?MVFXTThiRmRiZWFhNVZQNGRGY092c2N3ajlLenJrZzBmS1d2VURkOHArbnZF?= =?utf-8?B?ME1oMWxySXcxUzFUUGN5OGxHV2RCR3FBelNrbmgvS0wza3pUS01PMXYwTTZ4?= =?utf-8?B?UVNUNVUyeTAyMVVuenozZkplRjdPaUM3d2lFUGY5TjFsRW9jNE9ib2pvUWtK?= =?utf-8?B?czZ0UDdUeloxeVJoSzlxZDhqNEQzT2FZZHEwSTNWb3h0MDJUNDJBSDV5dkRW?= =?utf-8?B?OFVmcWh5bDRBd0MrZ2w1K1djSmdqdnhzS1l3czFFZm1UTWJkYUZqbEhwcDRn?= =?utf-8?B?bzB3cnlCQ21TcGpjUWN6RlIzTW9jQVJTcmhIZU8rU3htNnF4Z210UUFRdlRC?= =?utf-8?B?bmU4V0paNnNVQWpZRDAzcEUvRlk3WXpBZWJ5bzdzVUM1UENaWGwxaWFyT0dh?= =?utf-8?B?Vmc3UHNndnNGdUd3MWsrS0hBRkxtcDRsdmYzR0l0S3BuYlpXK1VQVVNFbmd5?= =?utf-8?B?MG5HN2I0d2tPMzZPNDZlTDlNUDhmOXhSSTFpaWdRbTFVSnMzYk56UmYvQXNq?= =?utf-8?B?R2RSMFIyZDNiTXBaTDlHTUtVdXlZdEQ0RWJXcStIRUR0V09lTmtpbFI0cFhp?= =?utf-8?B?b2ZOUXY0eGpIMlRrbTNPZUxVbkN2ZFNkK3BNY1FlNDJZMXdQdW5vM1NkeldJ?= =?utf-8?B?cmpPUmorOU1BdGxqbXdaS2FaWUl1OWpzRGUzbjZ1L1YvTnJzakRlVnpJYlNY?= =?utf-8?B?N3ZNeUhjUmgwL0t4Y3lYSUpjTTVPZ3dqZVdZMXBaMHM2VVFBNFVveitibmlD?= =?utf-8?B?WkJiVlN2ZmluVDd5SDJ4VW5XQTZvOERGN2x4bU80Qkx2cUpybkwyd25XdEc2?= =?utf-8?B?N0hMMFIyNnhaNGhrQlN5UUhVM3NkdmhhWFlkOFJsNGprdnhhalNUQ05NQnNG?= =?utf-8?B?ajRvN0ZweUhCeDI2b3prbFNIb1MxT3BWRzM3YmQwT1MxNjBXamVaZkdWaHo4?= =?utf-8?B?NUgwRUFuMGRtTmNnQzk0ZVZONnBXQzFSUHIrYXZaeTBKY2FlbU5LUzM0KzFi?= =?utf-8?B?Rmd1amJ6ZkZ2SURaSURzQzVWWkNqWnB2NGpERVB0QTJHS3dKWDFuOVNWVk9L?= =?utf-8?B?NHVmL2NjdVBaaFpTclRBUWVkeVl5dUJGWHFOR2VxZnZHZGk5QjNVZ2dsKzM4?= =?utf-8?B?YUJGMUVSczhYN2VQUzEyYlVJRGdjVnpCeXdTWXhrWDJ6eDJTQVVwM09PaUwz?= =?utf-8?B?U09sWmpMR0I5S0ZjUUc4R2Y1YUprNUpIaUxYRHdvaU9EMVIvSVlMZ3drRXhB?= =?utf-8?B?U1JIRUdkckRCTmdUdDdheHFqajJnT1VuZ3J4bk1aeW9TbnhjYi9NZENRcFFO?= =?utf-8?B?WXRmcFl1Z3V2V0QxT08zdGxsVDJvOXUrand5N3VJdHdxaWo4R0xncjd6bjdN?= =?utf-8?B?cjQvOHdkR2dKclJsOXIybHp6emVaZzFzWk9Kd25Fc20rMFN4S2ZFV3VoVE5l?= =?utf-8?B?bkVCWUprZVNzSnJ4S043VTBXOVlvd0NGandSWm9ENk1GeXo2c3FSUFNHbThX?= =?utf-8?B?dnVTTFdGdU1xdEt0OHhWTmJXOTFNSjRoS0Urc0ZNTjU2aG5iUTZnek9FRmdw?= =?utf-8?B?djhycWpydWFqTEwxU0FySVZCTXF0cGlYNUFHbTh1bDU0dXpoQ21hZzkxWWpn?= =?utf-8?B?ZzVPYkZNWlYvT0krbWczWk5zU0YveFRsRXY0M2wzWHB5Vm10RGZNYWc0bGdM?= =?utf-8?B?bFRON1lsME9hU3ZqUUQyMCtYeWJyZ0xpUVA1a2o0dmpZUEZxZGdMSTErSHJS?= =?utf-8?Q?i2j5snJNhCIFqNHK4hn0yexl0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdc516e1-fea4-4327-2dea-08db974a4ea3 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:29:20.6916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k7gy3QZYLqQsCZ9TqHBnasIIh69x1xlATo8e6sHV5rLuGOVf5Z3xIB71U5oMDjP5VqmF/l856f+QbLYkGcCJfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8941 On 03.08.2023 14:05, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/traps.c > +++ b/xen/arch/riscv/traps.c > @@ -5,6 +5,8 @@ > * RISC-V Trap handlers > */ > > +#include > +#include > #include > > #include > @@ -12,6 +14,8 @@ > #include > #include > > +#define cast_to_bug_frame(addr) ((const struct bug_frame *)(addr)) > + > /* > * Initialize the trap handling. > * > @@ -101,7 +105,131 @@ static void do_unexpected_trap(const struct cpu_user_regs *regs) > die(); > } > > +void show_execution_state(const struct cpu_user_regs *regs) > +{ > + printk("implement show_execution_state(regs)\n"); > +} > + > +/* > + * TODO: generic do_bug_frame() should be used instead of current > + * implementation panic(), printk() and find_text_region() > + * (virtual memory?) will be ready/merged > + */ > +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) > +{ > + const struct bug_frame *start, *end; > + const struct bug_frame *bug = NULL; > + unsigned int id = 0; Pointless initializer. > + const char *filename, *predicate; > + int lineno; > + > + static const struct bug_frame *bug_frames[] = { You likely want another const here. > + &__start_bug_frames[0], > + &__stop_bug_frames_0[0], > + &__stop_bug_frames_1[0], > + &__stop_bug_frames_2[0], > + &__stop_bug_frames_3[0], > + }; > + > + for ( id = 0; id < BUGFRAME_NR; id++ ) > + { > + start = cast_to_bug_frame(bug_frames[id]); > + end = cast_to_bug_frame(bug_frames[id + 1]); Why these casts (and then even hidden in a macro)? The array elements look to already be of appropriate type. > + while ( start != end ) > + { > + if ( (vaddr_t)bug_loc(start) == pc ) > + { > + bug = start; > + goto found; > + } > + > + start++; > + } > + } > + > + found: > + if ( bug == NULL ) > + return -ENOENT; > + > + if ( id == BUGFRAME_run_fn ) > + { > + void (*fn)(const struct cpu_user_regs *) = bug_ptr(bug); > + > + fn(regs); > + > + goto end; > + } > + > + /* WARN, BUG or ASSERT: decode the filename pointer and line number. */ > + filename = bug_ptr(bug); > + lineno = bug_line(bug); > + > + switch ( id ) > + { > + case BUGFRAME_warn: > + printk("Xen WARN at %s:%d\n", filename, lineno); > + > + show_execution_state(regs); > + > + goto end; > + > + case BUGFRAME_bug: > + printk("Xen BUG at %s:%d\n", filename, lineno); > + > + show_execution_state(regs); > + > + printk("change wait_for_interrupt to panic() when common is available\n"); > + die(); > + > + case BUGFRAME_assert: > + /* ASSERT: decode the predicate string pointer. */ > + predicate = bug_msg(bug); > + > + printk("Assertion %s failed at %s:%d\n", predicate, filename, lineno); > + > + show_execution_state(regs); > + > + printk("change wait_for_interrupt to panic() when common is available\n"); > + die(); > + } > + > + return -EINVAL; > + > + end: > + return 0; > +} > + > +static bool is_valid_bugaddr(uint32_t insn) > +{ > + return insn == BUG_INSN_32 || > + (insn & COMPRESSED_INSN_MASK) == BUG_INSN_16; > +} Why "addr" in the name when this takes an insn as argument? > +/* Should be used only in Xen code ? */ What is this question about? With ... > +static uint32_t read_instr(unsigned long pc) > +{ > + uint16_t instr16 = *(uint16_t *)pc; > + > + if ( GET_INSN_LENGTH(instr16) == 2 ) > + return (uint32_t)instr16; (I don't think this cast is needed.) > + else > + return *(uint32_t *)pc; > +} ... there still being a double read here, do you perhaps mean to make a statement (that this code isn't safe to use on guest code)? > void do_trap(struct cpu_user_regs *cpu_regs) > { > + register_t pc = cpu_regs->sepc; > + uint32_t instr = read_instr(pc); > + > + if ( is_valid_bugaddr(instr) ) > + { > + if ( !do_bug_frame(cpu_regs, pc) ) > + { > + cpu_regs->sepc += GET_INSN_LENGTH(instr); > + return; > + } > + } > + > do_unexpected_trap(cpu_regs); > } From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:35:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:35:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578435.905931 (Exim 4.92) (envelope-from ) id 1qT0Nr-00004x-Ob; Mon, 07 Aug 2023 13:34:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578435.905931; Mon, 07 Aug 2023 13:34:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0Nr-0008WU-LG; Mon, 07 Aug 2023 13:34:55 +0000 Received: by outflank-mailman (input) for mailman id 578435; Mon, 07 Aug 2023 13:34:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0Nq-0008WO-98 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:34:54 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20616.outbound.protection.outlook.com [2a01:111:f400:7eaf::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2fb393b0-3527-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 15:34:52 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8430.eurprd04.prod.outlook.com (2603:10a6:10:24f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:34:50 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:34:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fb393b0-3527-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HaRD8f9dvnihAT1d5wB0L3W/5S6n0x9kFVuKr8SlOlya24vyGtMqM7OT32tD/YxVEqLYjxnyYMQpCvc3WHmW+9OHRED5H/NDnV7BrtJFY3TJP1yYWSqWXfAtGlwl5/4JR7/8zDhswsX3CHNj30aueY7ar64/P6Iiohgy1nafA1r6sXw+1ZiWNjal5Q1APsZw6pceNxkmxJDLiYpOHYMv1392X+4kW5jLnPOQy0bIwamwrzEG5rLfRN1mvKyu5JrBmAJdmkG8+3p58SVgqfCBuKFocl4NG8eTF/03NukvTlC/mTOWQ+ZyWVrMtdSqZEBjM+SRrDIfLZxHoeaUuTeBZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tuR/yXzgObQkOkfjqMqrl7fUw83LDbISQvnngw+mSLg=; b=kwkpcuRzKZR+QHiAK39uX9xRrU9f2OSMCRne4ggG3szQ1+nZjmx1wEaBTAI7qb0xQcxhXfvSMF5FFbr+Raj7DyEFmDXcqYeV3y7rRFeEoFV/TG6cAkuF01fWQ5pm7nQVjo673drx2NG5Cgs0Y7SWkosN5ZKQrZFEkdPgO871tZewGXogufuyhOaCSzgZZxt2iTBXoCh9OPOmSFR4Qnog7AjCcIZNRRSIrTMh9DBiv0Ks/OodNraQQy7LL0nBTsUXYFPORF8jRn6h3DZazXNva8SV/SxLr5MS8slxTFj1+PNC/+tmX54H1x4wmUQEahu4Uhz5y4cAb6H84IsoDZJ+Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuR/yXzgObQkOkfjqMqrl7fUw83LDbISQvnngw+mSLg=; b=Hvni0r5UBgnK9lBPLOnmYZcdIPLLnDTwi7IdY+P6I10ixa6C28ElntYeakWsueKDqtgnT0mpAuc2sJDMEUwksvEli/FVZAxeIjSErr8vNgXfzT2ZoZdqVFwrvAxOg22ONFfelKRo1wIMk9rIOtzyF3hgOqlZ7SYpUj8065Wu3HWGpR0TrYCypfd2PsKfflIcfQfcbS0RMECmtAlAjIVs7Wq05ehIvbyrUouA8kGLIsEhjZMr79ps6ISSJxIVAzn8w+q78kO0Fvp823NyT77EcvpiQiW6I7bt6sM3akgaBIMG0TZT4/KH5KeBmsKWutaDefzgeCJv1Q914a/LiyA6zQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <04e7a7a4-8926-9e5b-c872-caba8d43d563@suse.com> Date: Mon, 7 Aug 2023 15:34:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] x86: Drop opt_pku entirely Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Henry Wang , Xen-devel References: <20230620174704.3907275-1-andrew.cooper3@citrix.com> <3daf5b51-cf5f-b9c7-b02e-0db5b48aa03f@suse.com> <6a22f4d7-e0f6-67f5-ba44-af0a07523c4e@citrix.com> From: Jan Beulich In-Reply-To: <6a22f4d7-e0f6-67f5-ba44-af0a07523c4e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8430:EE_ X-MS-Office365-Filtering-Correlation-Id: 39886cf3-8446-4af0-ebe4-08db974b12e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yyii2OTmfXEfBI3MKKjK/XessFAVJKaRrzNrfgBOScyaUt8E39oMJNkznosmtWmn1OJ6OXk+VcnVwiYufAamLzJ3fU0fkWUGwuWotCu/UNc3PFdlPHVRNBLT+8tmWyTETjzYlhBjDM6M+AtswNO1gCsUY3dp+pbM4DA0WtSXstcHMKqRe0Pn0dBDOuWPit0gDl7NU7GmucpgYhp07exMvnOD+VLxaQ1sILTyvgz/+yWdjwou+EKUaHwKjLRRpkVXeof0JrReShQ9yfGeNgwwEy68fnvKj5UDSjNtQ+gYEV+8GW9rR3P/4WBHuxjAeF6r7tum2Zc45MydCLuOOYXCfrKH5bDjdi9jm6wshnJaOxiSzQvkt8vQQ2zYbqpT/fuqGuDKcvtljMDSGdw6xmYpTZPvGN3xYBF1/h30yAYMTcQbCwLjKIpwDu4Jbk0ULAxihwaz8q4w50YCyVE3CCSbCA8goLzdRHmWOlIBGfXhqpdv9YGgTZjjPtkfyysLwQbUyoRq8QpiupS/dUvMGImVDQy5Qy8q56bQ9d/uAWCCXMs0WjImMn3Hn1Qfs+FnG+C5L1q8N4AaH+AfiRdbwmhvs5232fukJAhCvRWF7bYW9Zk7v0bnYGbqL2+H2GnyyXt++vqPOOArEiwXuhXe/rxL0g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(39860400002)(366004)(396003)(1800799003)(186006)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(83380400001)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(478600001)(31696002)(6506007)(53546011)(54906003)(38100700002)(6486002)(66476007)(66556008)(6666004)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0hoNk1IRUtGSVVkK3VkZVdGcDNzaWtTS3cwdmxWQ2N3UEl3ZGVMYjdzUXZs?= =?utf-8?B?V0lmWUNqTXF5VTMxdnR6VHNNdnZzSHBaK2dHRmFuSjRrSENqWThZOHhyUUpa?= =?utf-8?B?UEhhWWxLYVF4YzBkRXFsZVI0bm11VEpqbFN2RG02UnpkektTemNvY3ZhNnhR?= =?utf-8?B?TGlKS1BheDUvVUVmREJlZFJNQzVCdmtjb2JaZlhEVmJ3Tk90RGhld2FXbkIx?= =?utf-8?B?UzZZQXFXZ3hnV2FyampueEVqOFFLbnN0WUJ3WU51UlQ3ZmJoUjM3c1NEN1Ez?= =?utf-8?B?dU9jdHg0c0srVFJVSkVXVVJIaDVEMjVwa2tUa0NCRWd5T3ViRkpJd2JJT0h2?= =?utf-8?B?eGJUZm1CNjFLenFBdy9raDVOeG1SQURSNEtQZW5zMWFpMmZFODFXb1ZMQnBa?= =?utf-8?B?dGR3SHhzdGZDVUFDVTBqMG8yOXBpUkZnZzF3OFd4RzdYb1RVQmZYWkg3TER6?= =?utf-8?B?SEpoUHB6Mm1yWk5mdHU1M1FSZzZhcXVoR2w4NU93clFFRzVIa3VhcDNyODRn?= =?utf-8?B?UncyZG91NTBlWHRzQUVsc2p6c0VTeWVkQzkyR0JKTStJU3RYbzg1Z3A4czhM?= =?utf-8?B?Y0Ewc08vak1VMEYwdG5TV0lSRmFDNmlZU1dha1ZBY3hCckxId3ZsYTVmK1o2?= =?utf-8?B?cTFSS2Z2enVHdHBGQmNHTEtldnZzNHdSZFlZenpHa2xIZ25ZK0t0SWFOcW5M?= =?utf-8?B?b0VvL2llcmxneU1OaXVOWXdLKzFUOGZaeFZ2TUR3OTdsRHk2b3VZZ1ZyWFNF?= =?utf-8?B?WlFXSGhYVHBEd0lJMGg4NytsSTlMRkJhQWQvc1ZoeGdVVFF1TS9ncGNTekQz?= =?utf-8?B?QmRhZ3ZjUnV3b3dlQzlybFFlWHBIeGNQMmZlN3BZV1ZDOGJleHBKL0R1NE9x?= =?utf-8?B?MkwvSG01bDl4cHBrSE12YzRaeXh1eDJqNXZUelRiK0hJU3AyYnZYRkl0OUZi?= =?utf-8?B?OURKb2pQMkJBUWdwdDNIM3VWUlNnV3ZQRHhYUEY1WDJENWxjVlFsUkZ0MWJH?= =?utf-8?B?WEhZTzJac1d5UWRMQXBnV2p6bzRuSi8zRC9MYUgyL0VsUmhFN1ZjRk5YQWpq?= =?utf-8?B?Q2RBRUQzWkcyM09WNmlpdnBYeWtVU3JxYmZBMWRvcEdBb0VNdy8xRURHMUZx?= =?utf-8?B?a2NRVUxKZ0wyVTdVWmYyNFFXMVZMZndSa2hhY0FVSkZjVG5KRVhYcnNRYWFu?= =?utf-8?B?MTJiYS9LdVdiRlE2OE9teU42VmhoSDBIS2tUTGFKQi9aOWF2ZVlTeDVrai8x?= =?utf-8?B?a3pJbkFPa1ZQRDZ4Vkk4TXdIY05RK3oyTUh3UTVsYUgxbXRMclBKbnhhVUNp?= =?utf-8?B?c0U2cnBqaTNlU0YzS2lheHJBTmJVbVBsakZYaXloN3U1VWxJVnVoam5hWGx5?= =?utf-8?B?SktNVVBvalFXeWJwMVZEUy9JUjRPODFYVnZlQlBkWml6OTFWcUVNN1pUcWg4?= =?utf-8?B?YStodUVuY08zYnJqNlZNZGJYVWVFSEFSMzBncVJva3JKNkt2T0VaV0FXRlpY?= =?utf-8?B?ZTlmblBWVE1TVlFQMFE1SnBJRWFDOStkemRxV3BFaU5qTFNDSFJ3Z05NVFVk?= =?utf-8?B?RVFzbVNIUmFTN2Fady9YYnVpZ0pnNmNDUy94dnA0WGdsbW80b0Y1RXlPNDI4?= =?utf-8?B?N3dSUWdoVDRsazFDTUVQUlE0SytpWkFsUVhBY2k4NlJIZTY3a21sSGJGc3FL?= =?utf-8?B?bFRuUGczK1lQcDh2U0MyeU1BaFdLY3VmUmMvbU51UG5zTkV2dHlYUVk0NXhL?= =?utf-8?B?eFBtbm1rWVpuRllBQk5ONktLVUZFcnZvQ2dDZHFWTmkzd1VVNUt0SjE5NnpY?= =?utf-8?B?M2QrT0E2MEhFVFgxOVo3TVZGZXZ4aEFwWEtNdGNCT3hrM3FTY1hlY1ZQMjl3?= =?utf-8?B?Y3Q2VnF5R1dkOHpObldhcGJNTXQxSXlVVFZvK2NyV0RlN0o5YStTamNaOERS?= =?utf-8?B?SkM2RHUxemUxLytUbmpPWTg5YUpGdk5oK2pXR01Zc3hRb21XdVpRZEtHQS9N?= =?utf-8?B?VnVNbmI1QndWVDloc25NNXVqdVQ4TGFiWEMxMjJrVkNMZkNEU0IraEpzRWZl?= =?utf-8?B?elZobXMxM0UzYllkVjRkaFp4M1RWSXpjNkZ4Y0lzdXR5bVg2SHY3ME5RVldS?= =?utf-8?Q?yL+BjDrm5fbEytCS58TUBQUJ6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39886cf3-8446-4af0-ebe4-08db974b12e7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:34:49.9845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NKXzs0Sv7QWw9o6T1r0uMC2O7aodLvKPPug4gySWFsf7yR0lo07HEIx6jdKkwcvb7oZ4X+WgHv0IFKqzul2Qww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8430 On 07.08.2023 15:21, Andrew Cooper wrote: > On 21/06/2023 8:37 am, Jan Beulich wrote: >> On 20.06.2023 19:47, Andrew Cooper wrote: >>> --- a/CHANGELOG.md >>> +++ b/CHANGELOG.md >>> @@ -25,6 +25,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>> - Add support for AVX512-FP16 on x86. >>> - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech Preview) >>> >>> +### Removed >>> + - On x86, the "pku" command line option has been removed. It has never >>> + behaved precisely as described, and redundant with "cpuid=no-pku". >> Nit: Missing "was"? > > Fixed > >> >>> --- a/docs/misc/xen-command-line.pandoc >>> +++ b/docs/misc/xen-command-line.pandoc >>> @@ -1950,16 +1950,6 @@ for all of them (`true`), only for those subject to XPTI (`xpti`) or for >>> those not subject to XPTI (`no-xpti`). The feature is used only in case >>> INVPCID is supported and not disabled via `invpcid=false`. >>> >>> -### pku (x86) >>> -> `= ` >>> - >>> -> Default: `true` >>> - >>> -Flag to enable Memory Protection Keys. >>> - >>> -The protection-key feature provides an additional mechanism by which IA-32e >>> -paging controls access to usermode addresses. >>> - >>> ### ple_gap >>> > `= ` >> Elsewhere you said that we kind of imply that only the explicitly named >> sub-options of cpuid= are supported. If that's the case (which could do >> with saying more explicitly), you will want to add "pku" there in order >> to not regress what is (deemed) supported. > > I disagree.  I can say it was equivalent to X without X being an > explicitly supported option. > > PKU shouldn't be adjusted by either of these options; it should be > controlled in the VM config file (if at all).  I'm unwilling to make any > suggestion that this is supported. Hmm, so you're suggesting "pku=" use was unsupported, too? If so, perhaps worth adding the word "unsupported" to the CHANGELOG.md entry. At which point I'm fine with no adjustment to cpuid= doc. And then also Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:41:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:41:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578442.905941 (Exim 4.92) (envelope-from ) id 1qT0UR-0001i7-Hk; Mon, 07 Aug 2023 13:41:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578442.905941; Mon, 07 Aug 2023 13:41:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0UR-0001i0-F4; Mon, 07 Aug 2023 13:41:43 +0000 Received: by outflank-mailman (input) for mailman id 578442; Mon, 07 Aug 2023 13:41:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0UQ-0001hu-Gf for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:41:42 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on20616.outbound.protection.outlook.com [2a01:111:f400:7e83::616]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 23482e17-3528-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 15:41:41 +0200 (CEST) Received: from CY5PR15CA0179.namprd15.prod.outlook.com (2603:10b6:930:81::27) by MN0PR12MB6128.namprd12.prod.outlook.com (2603:10b6:208:3c4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:41:33 +0000 Received: from CY4PEPF0000E9D5.namprd05.prod.outlook.com (2603:10b6:930:81:cafe::a) by CY5PR15CA0179.outlook.office365.com (2603:10b6:930:81::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Mon, 7 Aug 2023 13:41:35 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000E9D5.mail.protection.outlook.com (10.167.241.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Mon, 7 Aug 2023 13:41:35 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 08:41:34 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 06:41:34 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Mon, 7 Aug 2023 08:41:33 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23482e17-3528-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n1QjybxcGP+Yfj5WNvnyZCiPFOrMFWMrM2BpDROf5P+VsdyCJm8KwMAVM7A9G2ZOZqHO0qsdTBvqHVR6k+UJJul9QId4x4zwVmrTgDXHVBlr5sn+IMB4sH01961kEieOH9jBddMD3uuYFSA2BE/0ZpMny9Uk7g1zoi82eyb39krVLT/1i+8F6W0W1RkHxWob4d+8HlXP2RcnJouYhPDaW3fIT0yNC0968wUq+8vF2hkBJDCfV3Su0Qo+01b54QvnhZTD+gTdCRkFqrgEkAiDcrN++UE7sCKVqyDO942j5Vmcu/9yaS24Apmbjxd3P6zb+dP7aVmOc2TVgjzvONsjMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/3uu11JQaiojEo/DtcwB3/CLv1cRTFZuFWDUyFuXyn0=; b=l7VHCpo7q1WDBcdMY0T7LpOSclKLhwEDmZkYGLg3tERXqzOODViIvO+6h8Xn6vtTMqbS+rm70ycnvPespSENHn33B6mmCib+qzTkrTZjW9AK4fE0jDgfCS5SMffj7qAwij+aj4f9AQjbhMd+WGbCTstHM/K+W+8D9zVNfmDEEf9KKNPwFAHHrvLp41QOSMJqwp2e5N437KGqRHZ4cOK1Z86VBFMqlQsS9xWwVeNs11+h3BqHNUiHMW2mgpRM4B8yAsY6Z58Jpnoh3Jep3DBuTwivMKMR+imtftGDQEI1Qm4ISg8ETv3IktWs+gnRBp/dmqbTjYBqhKJluef/9Sj/cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/3uu11JQaiojEo/DtcwB3/CLv1cRTFZuFWDUyFuXyn0=; b=hsVyiWi3mX5RJHiyC7Anf4Ezzsh8Dlf+Ud1bRgaXjM9c/Ri4sO4TPRo/y8KHKdjY8jn/QZEi2x44icaLlnKNr/A25GoUItLXP+GvJY6TiS5lPZ1XhNCZq5P/O6Tw7LEZKJEA1PAjgnOkUdCbVURS+3kdop/tx2uNfeOBuuDx16k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini , Simone Ballarin Subject: [PATCH] automation: Advertise that ECLAIR jobs do not need prerequisites Date: Mon, 7 Aug 2023 15:41:22 +0200 Message-ID: <20230807134122.10878-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D5:EE_|MN0PR12MB6128:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ec2a4f4-9e16-4504-900f-08db974c049b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lk05EqxiIpr2k6rIaHkCNCiMRFhSnUH/w2vPiYIEpHOi3HtUjow/bqig+g33aTzS8xydCUw2qdMWslV3DWciUb5y16Lxagmd77s5Iq6vGM9mO2bn70wJIHHFI9A0RXIgGlBGwzLWgSRLHlGqKsh27ljntFoJ0lI4MJZ1HzjuT/vznNzPELxIEcahTAN4HF82mibU2Qx6Voa1qcaQTktJaohhnZcUTsj9vv4LIQDmVq+8HWciLydbeCjofpyo/o1dCQ4fYWRZJM92ZeggRYHpF2/c/vo0CHtO6N2nRQUaW6yH+Jlo5d1EIVjFkuCgTOOLvoDHnoYs56/pz/gfyt4kgK3BmI1avokI860MgW8jWfhHjj9FZP0m5RMtLRn1TfngRD6xWwNNOeC2Ri2fv0egwQaIYlh9QqvXbyYGNDU/teriqyvgkBiam4rVj0OqEEFTTFNLZ8yQGzXunSeT8F1pUyXpcV1WWwptnWZpsxnRQiXTrf5lugMgFptLOfsJhz5aejG45kGhrw7mv6dVchG0FDSP8EeJ9KfRavWoJE+Tnbj7p2oioeYsa/jEQvs7F3dsBSLz8wXksLPaTxE/n5fS79RD+8KdOrSCNtNWBViRsOZPnZcgQlg5KpjA0u6ATZTqVS9aRkVS3nf1JDq7sEOEnTkqCGakW/tlYGFIIlsPyONd80uwkWFSdOuaYjDP74II5JnemRrtTTdqdBZ9EMKLQ6dEXE6iOtlaVkj5od19hFKCfI6TGkKgmQ0AHRh2RdxLcWyY062aCVs/Qf+RwzXXSw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199021)(82310400008)(186006)(1800799003)(40470700004)(46966006)(36840700001)(82740400003)(478600001)(40480700001)(356005)(81166007)(54906003)(426003)(2616005)(40460700003)(86362001)(1076003)(26005)(36756003)(6666004)(336012)(6916009)(4326008)(47076005)(2906002)(70206006)(70586007)(44832011)(36860700001)(5660300002)(8676002)(8936002)(316002)(41300700001)(4744005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:41:35.2575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ec2a4f4-9e16-4504-900f-08db974c049b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6128 While not required today (ECLAIR jobs come first), add "needs: []" for future-proofing and consistency with other jobs in the pipeline. Signed-off-by: Michal Orzel --- automation/gitlab-ci/analyze.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml index 3325ef9d9a44..4aa4abe2ee18 100644 --- a/automation/gitlab-ci/analyze.yaml +++ b/automation/gitlab-ci/analyze.yaml @@ -18,6 +18,7 @@ - '*.log' reports: codequality: gl-code-quality-report.json + needs: [] eclair-x86_64: extends: .eclair-analysis -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:42:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:42:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578444.905951 (Exim 4.92) (envelope-from ) id 1qT0Uw-0002CM-RB; Mon, 07 Aug 2023 13:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578444.905951; Mon, 07 Aug 2023 13:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0Uw-0002CF-NC; Mon, 07 Aug 2023 13:42:14 +0000 Received: by outflank-mailman (input) for mailman id 578444; Mon, 07 Aug 2023 13:42:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0Uu-00027u-P8 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:42:12 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0605.outbound.protection.outlook.com [2a01:111:f400:fe02::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 339906d2-3528-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:42:08 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7648.eurprd04.prod.outlook.com (2603:10a6:102:e4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:42:05 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:42:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 339906d2-3528-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQqMqH3WB5GLOpvUpDIS1xGVYaPTyNP2vdRbvQiJQlFMoMA2IgKnJ4KBo6A5MxP7n1K1Czw2k5GCF+iK8ih4jiEyf8jHRMyJtfT/oGcmlA1FrJ42u3o0+e3urY/DkmhQeFD5AjHC3AQ4r4asOEjSjkQioCl2adg8bv0GUgEpde3Dcq0vPxciC5KsrXmh4xRMQenpNn0EhdUnKGwyr/fqZ6gLSGoedGyja1Zl8L7RTm/LgMIq9bpmX5LIgQuZ9JbvnJax8zGw/GvtBThfb4vwtVHSG+AW0nz9Qu+M4oVJITQaZH1EoRrA/TGoogKudv/FcUid31C1N7bGFCf/MYv+uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oDCpqA2DMQEWGDHwlOIUA5l2DQrdOo/HLKMJr9lzSas=; b=dfYZfDYjaKWEQTqhM6TUz+LAj8iKaHpf87d0ya5/Tnh2BUgocu9DiMi2ym+UgUORUiV+qFBXu8B3KUfUc9PHYg9Aj5Y0GxGPyx6/hY5BKFnLDRQsgQg0OLPYY1D9i9UsubbXDYRAli17Avee4jvWhYjL8zj1a/rBNw0NOnQmwtembAIVVcdajpDDTSENe2vVnz0sQewoDR8ymh4sXUhQ8YxmttrYTOxqV0qtBujIRSJRwf2jOxY4YYtKZvc2K2mc6tyy+blYGfuaCpR5Viwxxuv5UDSOwKmYHFwlF5dFYrdL66H5aL9URawv3RpVKt6a6bfGdT5LoOsfFcgV8g4Pzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDCpqA2DMQEWGDHwlOIUA5l2DQrdOo/HLKMJr9lzSas=; b=PpJPZVdWZQdwWHviCbd7hipjpmY88UdnbwglR/N7d834C7tMtbR9uS4HKrRCGZfSLbi6sHU6CBq6YlDxeCmxNY+lTHqlcz4BolLj2tzigbWzNtE7BevHyIGGYk28s1IIt/5bEsAyuhYKRc2+hWXDDngPwBl+HbVtDUIOP1tOkNmYA7bbatPqf/Vn/V0rAv1vjYwri4S6grdpQCzONkH+sgoWBl2G52PBKFaN2van/wS5hPU/ehw3U9fBgCO5GBx6cyvNqlyqytgLNORjTAooRtlgJGXAdCcw2w+n5DKmp3bVt8itpPhjVFh58HhZSsQmPNssVAKoUQm7eUApzyjl3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <66d0ea64-0363-db7b-b4e2-5e404bff28d2@suse.com> Date: Mon, 7 Aug 2023 15:42:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 4/4] x86/setup: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> <55099faa-206a-b7ae-8ef1-64d1dc344c4c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0117.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7648:EE_ X-MS-Office365-Filtering-Correlation-Id: f4fb3e41-c7ae-4038-45eb-08db974c169d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i5tXZAoV2Q61eh16ki3Ep/qov8blpk7ua5P9LcgohQAiyufVIzv0tLScTHHFHFQ4XldPqRaqr+ZXkHtBkcA+pTioyS6UqCelkOnqhgbMukqZ4ZDIYjo6m74cpFUMidkkiP9Ma2DCoKB782VVigVpeIU1JW0o3X+s2vAxoONLqQR0QK4LCsMZisX2xsiBzbYbHV4tS3wb4Avh4wSBAy/CgKU7mloRuiWQErsW4BOuZscCnQDJuvpjlpIRH+t2nls/KUgRwc415G0koUSf3C6Wqjp2OVMWdFMt2nithQJU92NwDdHUyhIzmta0ekpm93V21iKGGPPVVKEhzErHi8CTktxIl6sPA+qmG237SKLQrAiJ4I5VR9YSTJCMoao5JgdenfDorAPnQWEPJ3R4tmb02ioLGPjUB+gHR0oo3Z5UnedE79INWXg4CrYOb5W+ef5zUuaNZMfoZYMkOsB2b8ZeywVEh1vyaLmfqGLFVAcgHHkQSdLB0K/GxCptnJPSIO07cGA63aGWAQbZjaGsDw4i9XnGw00HSTORGvNYEgN6ov7Qx2hah1aIYfvZl6buX9s+uZ4x5mCD+QkJRxXvKWiAhtGq0Rb6R28QFkR6tG7kQgVAi/TNHDhBCjjPnig24XQhiKNnsXw6uPrE3bqReBCrPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(186006)(1800799003)(86362001)(31696002)(66899021)(41300700001)(478600001)(53546011)(6506007)(8676002)(8936002)(26005)(7416002)(38100700002)(6486002)(2616005)(5660300002)(2906002)(36756003)(54906003)(31686004)(316002)(66556008)(66476007)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rlo2bEZEaUxaUnkvalFlL1Bkb0VjZHFlZGpwYksySFhDZzNScDQ5WHJMREtS?= =?utf-8?B?dno1RUtKQTNScjRvWkFvSUpOVmxwRkxVTFpSRlA0dlFaK1FxQnRXZWtuV1NR?= =?utf-8?B?MHZxRkRneVdpbU5OeGFTNnVuN2M4Y3JoWGpseUFJbXpLUDRVTm9OMVk5cHcr?= =?utf-8?B?ZXdXYUVCa2JvME53MGhvUG1TUVA4WDFkU2FBbGlJcXVwa0FzUStvakNtcXlF?= =?utf-8?B?OGlYZVJUNnFHMFlqOGxjODd0TlQyanV6YVVuaFlFK0tGNGJYNU8yQW9zQU81?= =?utf-8?B?UzBVWnVDUEkySFRXMUszM1JCcjBKc0tacDlVdThqRTZ1Sk1PZXZ2ZGlyUmVa?= =?utf-8?B?V3V1am5uMHJuaFhTVjNVVitWTXRoR0tpc2dHWkZDQVhnNG9lOHc0bVM0Rzg0?= =?utf-8?B?Y1FrbzI0cy9vR1JnQ0x2cVBXSURJNS8yVzBCc29SMHV4UkdzSmxzNTBnbG5k?= =?utf-8?B?bDFwTFU1ZmozMjBxdVQ1TEVzTWdaTTUwQzg1RDFVd2xyenpMeGpHYzByamd6?= =?utf-8?B?dytHTGlPSTl1VDVHeE51WGd5dDQ0S1JhckxGdVFqTTBDSkdUZU85S2pwWElB?= =?utf-8?B?b01ZaXlVY2dwU1N3RWRxdHFySUl0cUFJb3dEdDVQQjZWbHFpYWQrd0FML2Zv?= =?utf-8?B?MlFwdjdBWE1RbGxjU3FZOS9YWlZET3ZjR21OWjBWd0J5NzVHNE5KeGI4d1hI?= =?utf-8?B?MzlGWTFwaFA2T3N3K3ZXVkhVR0RxYzFzZ2h3b3BqYWZlQ3M4V2Z0L04zTXBQ?= =?utf-8?B?Qy9qdlFqRkVqZmxXaktVeWhSZ2JJOUdtNG9qVGlxUkJqeElpODJ0cldnMm5p?= =?utf-8?B?SVFZeWhQQU9qNXNlckVzOUJhM09DbGJ6ZWpPS0tmMlZkOVpqeUYwd3gzd2tk?= =?utf-8?B?bDMwaUJEWUpJS00wR3RmQkc0MG1OWkdHeVd1V1NkelMrZncyM3VaNzBVV2ly?= =?utf-8?B?L3l4VVdpZnFwa2g4dTRpUjB2dnluNVk5N1k3RVkvRDdxY2h3UFRkSnRrVE5K?= =?utf-8?B?dkZvQm9LdDhBa2FLR1ZOelZhcWFpNmVjb2hGUjNETWNtNnJiczdpdWVMaFRL?= =?utf-8?B?NmxDWjRmY3crQXNvTS9RcXg5MEJDZzdISllYU0U2WENMditORHp2eW83WVN4?= =?utf-8?B?QmRxcGV2RG5UaTdKTE5TYWxHT3kzMlJla0Y1U3VFWFU2ZXFIVHFIRXVRMVhN?= =?utf-8?B?enFsMkdTbk16OEVQNG1aUVpQWTZ5TkFFcXNvN1FHRVRabFMySzJGdDU5cnIv?= =?utf-8?B?SjVWbHhwOFZSUUUwRElGOHJxOUhPeVVBSHF4Y1ZPb1p6QktNUlJFME9RK1lZ?= =?utf-8?B?UzgrcTZYQXYrWkFSRkYrZmNlUCtnVUpxV0E5dk04QWFaQlN2enZhVURxVytC?= =?utf-8?B?TDhRMEF3OWhhY3k3SWVxaVgrMGdUc1dHd3g2YnpEVTkvY2ZoTkhVQktVVHky?= =?utf-8?B?UHV6VDc3dlNPYXRrdUVOQ3JDZ1RVSmNuVHZoY3d2WDNVSFQvdkFpUlpPOExy?= =?utf-8?B?WXgza2IwTm8zU3F2WHhxZjRKamIvQTZTVTcxYThsUWZKUVM0WXZ0SFFmRTgv?= =?utf-8?B?K1Y0ZU5LdEN1aE5VTTdETGNjYjIxR3BLRkYzcWdNR2pGMEJLUFRYRXQ0cks5?= =?utf-8?B?ejY5Q2ErWFBTKzBJTVZDVFlGQ0RiZ3NlVGlTOFdMRS9CM1BnK3VkNTRoemto?= =?utf-8?B?cW4vUnBWMXVsbGNpeTRxUC9TWGo2bHZKd2c0TmFrSHpybFFiSnFkaURqdk5j?= =?utf-8?B?THZ1bUVzMFY2R0tJVFIvNVhGV2Jyd2huSXl6NThzNW04N01tRzFHVWNqWmF6?= =?utf-8?B?aVdzWS95T09KSTdLNkI3U0dyZGVHd0U4Qi92MmhjTXVOQTUzOFNOdUp5NUR2?= =?utf-8?B?Z3F2V0UrM0Y0VFZkSjk3a2ZaVnBLRWtScDVyR1kzTjZZZlJBa1RPeVBpUHE0?= =?utf-8?B?VTBGMEg2ZDBwUGNCWG9CTFdEWVdQS2ZvVEdhNTRqdjhES1FUbmtRb1FxZkFi?= =?utf-8?B?ZEF4eEJ2OVkyVWtNSnRza1VpdVVvbVV2anRjZk9GSSt4SHcwZDdlZmk2OHBi?= =?utf-8?B?VHJsVEFqRmxoN0x3TENzYUhITC92cTZTa3M4Y0F5d3RTcjJXcDBvODkvNnFY?= =?utf-8?Q?QszjlahgFpHgPt7e9OpjDkxCd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4fb3e41-c7ae-4038-45eb-08db974c169d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:42:05.7260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cBiAk/IXWxLnawQGiAh/AofJs8BnB0GzATOYfaGMeKGgtcyQvsv7T4lPRmr/aD3WopN58/iD7sS6cA1zquCvAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7648 On 07.08.2023 15:18, Nicola Vetrini wrote: > On 07/08/2023 15:05, Jan Beulich wrote: >> On 04.08.2023 10:03, Nicola Vetrini wrote: >>> The parameters renamed in the function declaration caused shadowing >>> with the homonymous variable in 'xen/common/efi/boot.c'. Renaming >>> them also addresses Rule 8.3: >>> "All declarations of an object or function shall use the same names >>> and type qualifiers". >> >> Can you explain to me how shadowing can happen in a declaration? I >> would focus on 8.3 here, and only mention the other name collision. > > There's "static struct file __initdata kernel;" in > xen/common/efi/boot.c, which > is visible when the function is declared. Since renaming these parameter > names would > have been addressed by Federico for R8.3 anyway, my intention was to > address them both. I understand what you say, but your reply doesn't answer my question. Just to emphasize the important aspect: I could see the shadowing aspect if the _definition_ of construct_dom0() used "kernel". But I'm asking about declarations (the one here as well as in general): I can't see how any shadowing can occur without there being any code in the position of using any such variable / parameter. IOW if Eclair spits out 5.3 violations on declarations, I'm inclined to think it's wrong. (Because of 8.3 a violation there would then need dealing with anyway, but _only_ because of 8.3, if the definition is already okay.) Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:45:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:45:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578454.905960 (Exim 4.92) (envelope-from ) id 1qT0YS-0002rn-Ac; Mon, 07 Aug 2023 13:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578454.905960; Mon, 07 Aug 2023 13:45:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0YS-0002rg-7p; Mon, 07 Aug 2023 13:45:52 +0000 Received: by outflank-mailman (input) for mailman id 578454; Mon, 07 Aug 2023 13:45:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0YQ-0002ra-D4 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:45:50 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5f89aed-3528-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:45:47 +0200 (CEST) Received: from mail-dm6nam10lp2104.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.104]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 09:45:42 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5026.namprd03.prod.outlook.com (2603:10b6:408:d6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug 2023 13:45:38 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 13:45:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5f89aed-3528-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691415947; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=03YFklj6Mi3U22d1eUiP+as3AS0eNIXY1D4H+ZisMsA=; b=W4FC5EhXdbsD+uRfhTVJjWtrtypnRYxMGRvvG6Mk1azjyntT+aX4V+8Z mSfO5s+xFFkIGt8DZKO3E8fNNjtlvazmsALIR8OKuO3+aUT9cDJqd3kLH EAIxMKXWquYHQBsTnxMiB+re60LH1b31KVmWb5T+UAQWaooFU1ae/jfJK g=; X-IronPort-RemoteIP: 104.47.58.104 X-IronPort-MID: 118604915 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:A/Km7KkpBdI+jOuObNGbxJTo5gy5J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXUWCEafjeZmujKNskPYy/oBgF6MWEz99qHgFt+yE1RiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgb5ACGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eYgAxk9SxGjvdmz34yXZLl3qs99KPC+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieCxWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTe3mrqI72QD7Kmo7MjRNb163+/mA03GXX8BuK 0UUxAc3ov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceZTEsz E7PoNrvChRmqrjTQnWYnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPoC1ggbwW1JYPz//ipQyBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHbQKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:Le1WkKkTMJH+4bbbWUwOGSX/d6zpDfMxiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msjKKdkrNhWotKOzOWxVdATbsSl7cKpgeNJ8SQzJ8/6U 4NSdkaNDS0NykAsS+Y2njHLz9D+rm6GcmT7I+xrkuFDzsaE52Ihz0JdTpzeXcGIDWua6BJcq Z0qvA3xQZJLh8sH7iG7zQ+LqD+T5qhruOVXTc2QzocrCWehzKh77D3VzCewxclSjtKhZsy7G TflAT9x6O799W20AXV2WP/54lf3IKJ8KoOOOW8zuwubhn8gAehY4psH5WEoTAOuemqrHo6jd XWpB8kHsJrr1fcZHu8rxfB0xTplBwu93jh41mFhmaLm721eBsKT+56wa5JeBrQ7EQt+Pl6za Jwxmqc875aFwnJkijR78XBE0gCrDv/nVMS1cooy1BPW4oXb7Fc6aQZ4UNuCZ8FWAb38pouHu VCBNzVoNxWbVSZRXbEuXQH+q3mYl0DWjO9BmQSsM2c1DZb2Fh/0ksj3cQa2kwN8ZosIqM0kN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOMl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wt9ihn3ek6hlTAfsuvDcXaI2pe1/dI4s9vTPEzYs zDe66/WJTYXCzT8YUg5XyLZ3AdEwhZbCQvgKdJZ7u/mLO7FmTUjJ2qTB/yHsuaLd92YBK3Pl IzGB7OGe5n0meHHlfFvTm5YQKZRqW4x+M+LJTn X-Talos-CUID: 9a23:obPbMG6EjqztXi5r2Nss7nY/M/AAc13n93LPHWOWWX1FQ+ORcArF X-Talos-MUID: =?us-ascii?q?9a23=3AYaPbpQyTxJr7QEzcpw25DmtkmFaaqJ6HU3oInc8?= =?us-ascii?q?GgpC7HChiCjeUjAqaW4Byfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,262,1684814400"; d="scan'208";a="118604915" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n0c2DjAj5CZt13GgTyS2VXcDvnHWQlsAdQol4i11qOhucJrbQkKVfpbva7Uz1ImQUE2MNoJRcMZdzvmCNMY0lbK+u4DVBRbGdKmTEoH4O0ynSP/WN93jHeEvBtighlA0kozdlQA2rXZkO9/NyUJij+DXelAdy80Fd7N4RJfl880kaF6HD1J4mr0IAbVF07LNTQvnoaya4b1aovCGHLONoGCvPzB3f/OhV9I2sylp8G5fD58Z+NommTXH78hYF+47dIZQep4mqRlWO14WJ8MscXRf+RUv4sEUC/oOjQXzKk5AigBBpM8l+UF0ULHeDo2fBud2p6XHzSdXjSshLNQHOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXXnkgZttQSW3pq00KkdBdU/MEjO96Uage0DISgZQOs=; b=YLBKioT09kwWSGozCYT9wom5MR9wECHsvuZuO50XN16qwkYdTRuY+5kxKhw9UlaBEOa9/YP1XHn0qDS17m1bBNl5yqQQNChkPCpxCK/bziVGlvt6XFodGW/WUSf1ZvAtM1+tMd2wRMmXVDPf/meUJCIbzkeE8YDgnYEtbCKAyHtGe5sDogEPMomkanLx/axCsLuQX4VzeW/kT/RLwotOQ+PxKVHn0pqcjLKs8b0KeSZHPOeZh/atEXZnqyEkAVlZMb9f4gRtvn/CW/IK+SMiTvVDwdGm7WYRo/FYKCRjl0ooqy1LE8Zoy0MzU+cM1MEIN7PjjW49MwRDAO9o3cIUZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iXXnkgZttQSW3pq00KkdBdU/MEjO96Uage0DISgZQOs=; b=P/Di6KoijY5Qn3WsqdSk7aHxGDJFA970+KmAQCDcAcSzzIphGGbq2KBYKG1UiLoaef0XugDikZ8skkVoX6NU7wWGbDJt6S5TawNc/ka54SIzarEuu09Kb+J/aGosWGSLFy+NS746zrGITSmS1ma3ZODlOxIiFUD+Mlsks63oAB8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3a0223c9-53b9-7cab-6ea3-dd5a6e02119d@citrix.com> Date: Mon, 7 Aug 2023 14:45:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] x86: Drop opt_pku entirely Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Henry Wang , Xen-devel References: <20230620174704.3907275-1-andrew.cooper3@citrix.com> <3daf5b51-cf5f-b9c7-b02e-0db5b48aa03f@suse.com> <6a22f4d7-e0f6-67f5-ba44-af0a07523c4e@citrix.com> <04e7a7a4-8926-9e5b-c872-caba8d43d563@suse.com> In-Reply-To: <04e7a7a4-8926-9e5b-c872-caba8d43d563@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LNXP265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN8PR03MB5026:EE_ X-MS-Office365-Filtering-Correlation-Id: a6e7827a-7ffc-45a6-c959-08db974c9579 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bGG7kZy+xoPz99T7t6q2QTA7kgBCuTZuo6QkV3IfqDIc6eRSKK9JxFjt2gjoqcdxVD4O8ydZ1l45wBqQCjJ1fMY3pS6jnl1J7QnLvD5YFpauIadADaDYMPWmpn3AdPJXeBqpfZKKnPqP5c+R152jfpQvyDleS7Jl1kWiKLOOc5mMvROM/GufmKGNEDqzOs+MIv+4W/F9KZT3jLesuhOfItj2Ll1/utJnMVk/ZpnT8+EJbXoDK99K0/GeM9A0kuHghGhjG1MjqNvdKmXGzS0zo71zv4vC/dFGSyO0yfJd1ECrYmp/eXI4eZ4x6rRkYrxoS5eRai7mgWkDNESTz/1OY2IHckxcNJA8xbw0uge+pBKa/sIto0psvw1kSVWB4dldWM1GuVKLLRyQMYDl+Bsa5gJ6FxNp+i9c0fWdDZbkDSgBTO2VM/iAY0ANzWkbaACZPfkFtpNgxEhEdiFJNayz1h9Kl/KwVwKaEQ+dRj729OW5i7TPm/HhL7UbfImXrile0ddZDV0FCWJOxrYWwIhNSiSiaKXS8nrtLlQsVJbsMdy4rgGtRELqDU6+piMAqIhSIqbJvlO9H22g7ZjhlmeOh3q9MX8OOKrcbhttV+ZEYHOydxTQ3kszpYTbt3hOZo+p3jmyRx/Vsi8PuRsbh066/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(366004)(396003)(136003)(186006)(1800799003)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(83380400001)(8936002)(8676002)(2616005)(478600001)(6916009)(86362001)(316002)(82960400001)(31696002)(6506007)(53546011)(38100700002)(54906003)(6486002)(66476007)(66556008)(6666004)(66946007)(4326008)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHNhVnhDa1RUM1Bsa2xmRkRlUXhVL3Q4MUtwY2luWXhNVURRODF1Mit5aFZT?= =?utf-8?B?NHBqUUlva0ZBd3hhRTZzbmlUQ2FzYzI1U0FqQUcwZkZGS2FIdGxmYW5ZcDBx?= =?utf-8?B?QUJKblBUd055ZjhPZU00ZWZNMDE2ZGptMXpoMlRZY29ETU0rSHdBY0lZNFhT?= =?utf-8?B?bkdOblVFOUNlayt0NGJ5WDNpK0p1WTI5dy9qZTZzeDliajg1RkRCZWZsTmFj?= =?utf-8?B?QnErdXNmd0RXcTIyQUNhNU9mWlNsU3RURDFvbUw3QThZQTF3S1dUSWh3VjlO?= =?utf-8?B?UFNUbDIxQnN3cDB5bTExYW16OFo5K09KeDBqMCtWZ3Q3SWorWitOUTR1clJT?= =?utf-8?B?TnhpTFo4SGtmbEMyaHNDZ1JVUHNXUW5NSXJuWW1FcGNHSXB6ZCtvQ2ZhVURN?= =?utf-8?B?ck96a0hGRVRPbm1PcUhEbmd1ZGs0Y0dFMHhKSTFOSW9QdmpUOVpnME5oNHFr?= =?utf-8?B?VUtGZWR2dFJ5TjlxMjM3T0FJSlJCRUpJL2NJVWtGTllHT1BoNFNaTzd0c3gx?= =?utf-8?B?bHJwcDUrMkMwSmpwVTJDb25BZWtqTTNEYVJxNkplWUhiYm9SOHMxc1hkRFVX?= =?utf-8?B?RkVxbVNzVmZUNTlYWTVOMGNSalhybnFRT1VoNVUycmh6RGhkem1ZNnVETUNF?= =?utf-8?B?UlhtQnJZMktyZy94ZURUQTY1S21Jem41SjFEbFlidE0wL0phWWZsWWtNZmJr?= =?utf-8?B?blNmK1JCcUhiejVoMFppZDJnTlZ4QUNxaU1ublZWSG9MUWR0VG1IV1k3U0Ny?= =?utf-8?B?MXdyZHpZMThVbFROVmF5emdqckU0dzhOQzFRbVc1amVUTHFhaEVZeE9yWS8r?= =?utf-8?B?a3RKb1FwVWJRelpsdkV4ZEJ4VHhTR1Q0a0JJVkluUjd0a0RReS9Sc212KzFF?= =?utf-8?B?SEJTdldhOGFqb1F3WHR6dHk4VXF3ZGdHbmRXNzMyNWVlN3JqZmJDSXNLM3Nh?= =?utf-8?B?bUo1RFlGemY4aFcrNXJWaTFFamR4anQrTmViTE9xMDZaZG1qWjNiME5oQm81?= =?utf-8?B?QjFwYUwyVTBlcEwzYUJnOTZGNUFVMUZkNDdNa244VHpuWlRUNlpCdm0zRmRa?= =?utf-8?B?QUtaTWV4ZXRUVXZFK0Z2b1lteitrb2w3SC9zdzV2K3ZqKy9NdDR2R1F2RFlB?= =?utf-8?B?Tmt1WkM2Z0RPZk8ydUpEUTlkY3VCR1N0TXBDem9FWE1HQUVZMTZicnJlRTVi?= =?utf-8?B?TDNZYVhHamx2RmJRNDZxOTdiMjRwaDJRdmZuTlB3QjN0VUZ6VWNicTBtYmxP?= =?utf-8?B?RnpmeEp6TFZMeWVoYUJjNVhXOWJ3ZlhBcG1vWjVKR2xieG8rRFV1Y3FwU1NP?= =?utf-8?B?R3orcXBNYWlocVUwWEZ0dndkRytXSHVHSzB2dHgzNWlwWU82am9NQm9JMEN0?= =?utf-8?B?VUpFV2RrRTdwYWNsaytrL2VmejVqcVNMK25iMEUxSjJkejhmeU5uOWxGZXJP?= =?utf-8?B?YnVvY0FDMGpNMmxKWEpaWkJaVkZLY1kxYmlWbGIrTnk4TmZLMDhCSTlLd3Jt?= =?utf-8?B?YzkzSzBBZ1pOd1JJSGJmSkZBUEpweEFnMEFpMWVOMWlDbVM2Ym1McktBdS9h?= =?utf-8?B?M1ZJWWdsYkQyT2FBWlIrSkprYjdVZ1RZNEF6NkwrN3dMb3hzK2x3bWJ1UDk1?= =?utf-8?B?U2dvbllBU1FYV0JZRlp6NVErNmZIdlVyYmVnaWtDOW1FZmJiTGwxS2h1aFpz?= =?utf-8?B?aXNna0VjbGFvVHZ1VnJEditkbjBiUlhkMnR5QWN1bXhZUHlJbTYxd2ZMYjBz?= =?utf-8?B?U2N1ZUFiUVRnOGhZK0lLM1I5amlrNEY0QTJ3RXVzbGp0NmlrdDRTNXJ4L3Iv?= =?utf-8?B?N2srMnhVNmpvd2JqQUNyN3JUdHJmcjRXNk8yT2x1V3Y5YXo3VXpRV3pGa1M5?= =?utf-8?B?b09XYmxMNWNaUU0xY1hUUGVSVjBPMndaMVpjRVovV3crTU1IK2pCclpyK2pw?= =?utf-8?B?V09pVEV1c2plK1FDamc5bFhGWUozeHdsU1BmS0l5b0JPK09PUmxMTXh2V1F6?= =?utf-8?B?TVBQWG5IWTNsRHVQajJFcUJwcktkSllaU3BvQVh4d3VBc3FIcERBKzFCTGJ2?= =?utf-8?B?RXJOMlZtTTYybGNZOHBRRlFzSGFuaWlKK0RTWDdHR3VnUkN4NEgzbHd0Y1Rp?= =?utf-8?B?bWxldFFaQ2V6STN6NDZnOVdmZmJ1V0F1YnFlcGZ0YUxIWW5oWGNGYk16NUgz?= =?utf-8?B?Mnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: MeN07R+p4pAQSFteqz6XQRBlpgRwF+7OMzla/doWZBwf1rmBwCa0Dwalnj3USIQsbrTCUfLQLa/9jHjXi/TH3IMoNSi5NoibVmqJ6cCxDtOT9UYyKwQg+m81LU/TnzaMaBVUUi+Tdg2SqGh6FXPTZjdQWlDo1O54OKXJEuurhXfkai/a/YNEqC69RH514Xt8BCDMz/Cixsss3DkV/m3mCso0TB6oYZINuzTv+06MtjtGwfWscNrUx//3O9vYm+uztYVvsPmgEJZm4wm8QeHE3C8ZjaCXlTM2oQFqhML/G4vW9mhd/Sd+7Aa/86KeeHkMDCj05ywzTPS+nbBqHG25ox4hKYrk/Tob3omRZv4xAnsmcX+dcFs271J45LJDrtzrum23aDobXkMlrHUdWDHyocALSofNwuSukggbDodfRUpj5/MluI37WbP3f6CH7+dt9jQJCDqzeVNprqBnk74iHGLyeusOCIj4gedjnYCrZoA+7cA4CffGkFPMcpePLmhxllMXHBvUxC0jB0nlcd8T2ocyp5tEfjmKglxJmElUmjFFt032gPYCGbsWB9PVl6jd/MTWNn+SpXoW3K/7fj8c0nS1rX4nJYo0tk02B++SHs8CGdSpUq37wP4FEiAzXDdQyXtc0Mqr0mBFB+OYkuJKVL6qA2uetWZ7QY6ROsFYcCTh853oCiu9sq6ZcjaR8Vyrpoe9gU6QCujLzh+70+c3e0gSlgPe29Xrng4Ls8SCz3MKRLAuUsdOmrRCce8Z+Bfdr2vMhgUct1uOHbPBlsngczWNSrWnHtTJox0wzWhmQoxeDRYz3KJYht8f2dJlttuiFTLDJQUZ1yb7pLc8WGgWAQ== X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6e7827a-7ffc-45a6-c959-08db974c9579 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:45:38.6612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PseCvN4vYcEIlHyJiwTT4CW/b0/wH3NQZyailoCbow5cpiN3LcdcNc+spGNbF1MzV2hjnCtKXkyXr786/oO9NNEngXuR/Qp+SIDFONzkKNk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5026 On 07/08/2023 2:34 pm, Jan Beulich wrote: > On 07.08.2023 15:21, Andrew Cooper wrote: >> On 21/06/2023 8:37 am, Jan Beulich wrote: >>> On 20.06.2023 19:47, Andrew Cooper wrote: >>>> --- a/docs/misc/xen-command-line.pandoc >>>> +++ b/docs/misc/xen-command-line.pandoc >>>> @@ -1950,16 +1950,6 @@ for all of them (`true`), only for those subject to XPTI (`xpti`) or for >>>> those not subject to XPTI (`no-xpti`). The feature is used only in case >>>> INVPCID is supported and not disabled via `invpcid=false`. >>>> >>>> -### pku (x86) >>>> -> `= ` >>>> - >>>> -> Default: `true` >>>> - >>>> -Flag to enable Memory Protection Keys. >>>> - >>>> -The protection-key feature provides an additional mechanism by which IA-32e >>>> -paging controls access to usermode addresses. >>>> - >>>> ### ple_gap >>>> > `= ` >>> Elsewhere you said that we kind of imply that only the explicitly named >>> sub-options of cpuid= are supported. If that's the case (which could do >>> with saying more explicitly), you will want to add "pku" there in order >>> to not regress what is (deemed) supported. >> I disagree.  I can say it was equivalent to X without X being an >> explicitly supported option. >> >> PKU shouldn't be adjusted by either of these options; it should be >> controlled in the VM config file (if at all).  I'm unwilling to make any >> suggestion that this is supported. > Hmm, so you're suggesting "pku=" use was unsupported, too? If so, perhaps > worth adding the word "unsupported" to the CHANGELOG.md entry. Well - it's just hiding a feature so nothing (interesting) is going to break.  But it also isn't an option that anyone ought to have been using. > At which > point I'm fine with no adjustment to cpuid= doc. And then also > Acked-by: Jan Beulich Thanks.  I'll tweak. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:45:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:45:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578455.905971 (Exim 4.92) (envelope-from ) id 1qT0YV-00038I-MI; Mon, 07 Aug 2023 13:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578455.905971; Mon, 07 Aug 2023 13:45:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0YV-00038B-J7; Mon, 07 Aug 2023 13:45:55 +0000 Received: by outflank-mailman (input) for mailman id 578455; Mon, 07 Aug 2023 13:45:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0YV-00037l-0B for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:45:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0YU-0008E3-I3; Mon, 07 Aug 2023 13:45:54 +0000 Received: from [54.239.6.189] (helo=[192.168.12.178]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qT0YU-00017W-Bj; Mon, 07 Aug 2023 13:45:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=NsiXcLbhtBqUYUJLtE6UTIICCBzMcUPY8ousQ7D2gbI=; b=afSOqzES+nuYH9mvwJMua04zls ubIdPZI1ojRiVCXOgXjo//ZjMK3z1fJjrXazx585zKWSj3M+BNG1WhV7Dwt9mfwYKazegD5Oi5z9V 2oCqbTpfae1Q+qFak+SRHs62cW/Kb2j7RxtN35fdLYPs7u6K28b/BHAfS+MH/DvSXOVg=; Message-ID: <0b74b4a8-29a9-491a-9961-43487d95b1eb@xen.org> Date: Mon, 7 Aug 2023 14:45:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] arm/mm: Document the differences between arm32 and arm64 directmaps Content-Language: en-GB From: Julien Grall To: Alejandro Vallejo , Xen-devel Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-2-alejandro.vallejo@cloud.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/07/2023 10:05, Julien Grall wrote: > On 28/07/2023 08:58, Alejandro Vallejo wrote: >> arm32 merely covers the XENHEAP, whereas arm64 currently covers >> anything in >> the frame table. These comments highlight why arm32 doesn't need to >> account for PDX >> compression in its __va() implementation while arm64 does. >> >> Signed-off-by: Alejandro Vallejo > > Reviewed-by: Julien Grall I have committed the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 07 13:53:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 13:53:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578467.905980 (Exim 4.92) (envelope-from ) id 1qT0fu-00051Y-Ee; Mon, 07 Aug 2023 13:53:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578467.905980; Mon, 07 Aug 2023 13:53:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0fu-00051R-Bl; Mon, 07 Aug 2023 13:53:34 +0000 Received: by outflank-mailman (input) for mailman id 578467; Mon, 07 Aug 2023 13:53:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0ft-00051L-7x for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 13:53:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1b::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca5b2f8a-3529-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 15:53:30 +0200 (CEST) Received: from AM6P191CA0067.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::44) by DB3PR08MB9058.eurprd08.prod.outlook.com (2603:10a6:10:430::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Mon, 7 Aug 2023 13:53:28 +0000 Received: from AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::ab) by AM6P191CA0067.outlook.office365.com (2603:10a6:209:7f::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26 via Frontend Transport; Mon, 7 Aug 2023 13:53:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT047.mail.protection.outlook.com (100.127.140.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.15 via Frontend Transport; Mon, 7 Aug 2023 13:53:27 +0000 Received: ("Tessian outbound f1e964b3a9be:v145"); Mon, 07 Aug 2023 13:53:26 +0000 Received: from 35c2b4c0cdd9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D3D2EBF2-C9E4-4D35-B701-216097463F2E.1; Mon, 07 Aug 2023 13:52:57 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35c2b4c0cdd9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Aug 2023 13:52:57 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PAXPR08MB6336.eurprd08.prod.outlook.com (2603:10a6:102:158::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 13:52:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 13:52:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca5b2f8a-3529-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ptWFYO0ZIsWUELtRyAPn9T7YAWUQGbKkLItJePrUfLU=; b=x1yW/1Kvq48a66mD4RDXob2giZ6vYVcF/4ah+C9fOEb16t9VHuHb3KAWu63z4EIdSE64RxSb46YCzAeL3YAdbK/5yFbC3/kOflaGkt6pT93UMZ126vK9d1JBsEt239pp1VHsydLFCHYCvN5a0etRdKHs5aV6F8ih9cRyIO8ElnI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 488fbd9322a799b2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHETnV7kTTLzkR1hIkqlq34v5njh8U7kbVDA7dcWJdETE9jLbjUVDDltOGkjWunYdRRuamOUZPY1aOuU6vXxmoru2Az7FD4kOb/r43g8H9uycVgXm8NbCciMJAp65sdL5intj5M82V5m241qM8+h0D3fgGM7Jj949E/LaCus2C2G+NEXUDvZdzc6tD3CiAKfJ7wmv5vsdyb1AR/w30BBbEkHGWVRTdxiM8rtpWm2b/L6LyUmuMXbjcqIOsfsat3oLEkj6g5ddoOpVnvFvq95QbwZEgwArLMEYtsQHmKCnqNjDHzta3dUBFXoXua87jbodB3Bt9XIs7zCUsjqbE5fkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ptWFYO0ZIsWUELtRyAPn9T7YAWUQGbKkLItJePrUfLU=; b=M1MzhZFAoGcnyAziExBu6p0F5UvdR0lOZaU+zxRlEOyhhg8VkgD+zW/HsOKMriuK/6dY9Df3neNAD2keGcikwuwu7iF2RUfb2Qq5s7ZNYVop6GH11AaB3QT1S8tGUJb11x7EnPz5NG5eHzSHdneRN1zmaD1A8mYbHsNs8o8R0RI0P/K2Dv2bqh554QfHzEmVrOFS4Af4EMCy1FgGW7t2YK4QpdsqGYLxPJ0yXe3koRugPNkXpE7/IUtR7RbIMGR2/yUCcveS5QnazWVHTXTuOCKsA1S8GYP6paScylTuKxIRf14vjpYEfdLTa1MYqYH8od2jppJkPAuEf0kanp3/lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ptWFYO0ZIsWUELtRyAPn9T7YAWUQGbKkLItJePrUfLU=; b=x1yW/1Kvq48a66mD4RDXob2giZ6vYVcF/4ah+C9fOEb16t9VHuHb3KAWu63z4EIdSE64RxSb46YCzAeL3YAdbK/5yFbC3/kOflaGkt6pT93UMZ126vK9d1JBsEt239pp1VHsydLFCHYCvN5a0etRdKHs5aV6F8ih9cRyIO8ElnI= From: Henry Wang To: Andrew Cooper , Jan Beulich CC: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , Xen-devel Subject: Re: [PATCH] x86: Drop opt_pku entirely Thread-Topic: [PATCH] x86: Drop opt_pku entirely Thread-Index: AQHZo59KU7pYKh8tuU6jUNQk0iLChq+U30GAgEo9oACAAAO9gIAAAwEAgAAAjXg= Date: Mon, 7 Aug 2023 13:52:55 +0000 Message-ID: References: <20230620174704.3907275-1-andrew.cooper3@citrix.com> <3daf5b51-cf5f-b9c7-b02e-0db5b48aa03f@suse.com> <6a22f4d7-e0f6-67f5-ba44-af0a07523c4e@citrix.com> <04e7a7a4-8926-9e5b-c872-caba8d43d563@suse.com> <3a0223c9-53b9-7cab-6ea3-dd5a6e02119d@citrix.com> In-Reply-To: <3a0223c9-53b9-7cab-6ea3-dd5a6e02119d@citrix.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PAXPR08MB6336:EE_|AM7EUR03FT047:EE_|DB3PR08MB9058:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a813dac-3e37-4f5d-51e7-08db974dacea x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FvkCx/CQGYWQ3P9II0lKGOhTkI/WVvAqK88+1Y71rPVYE0v9bt5I0E5R191LuPqZfbx/gfdrioywiWqFKSbNrjZtQyYP8hN1OXIV+urmW6H1w4zI5Lp48+ULQorgF5I0gHNJt3Ko48OyEMLhyPOjprxNlpjq8ho8DSFrFz44WnctFNpWKVGcGsvEeeZF1B8/dXkPm5Lkh39bSQQqQIyzUEPfNDwM9t2UA1IhwhElt4lLz4xps10Oy4sVpHDcyp8BmWaIFSrJEXYLPCvClZAuP4QHNlkNl+IpvIj6uT3iLbH/SjL6l1vM0IygeHwX67gF+tXsM9QElwG/WkD+gYsLmzrS8/3RJwRA6t5mTK4BwSNH0iCLwxB8EVyhxyv2Emj9Ut2VJGFu2LzuLOUnCWAdQZPKQxG+R2li3pZlhgx3e3CpBefK4UnVLMtMsExk7ph+emGU5l7c92RkbwQKrswYNiWcfGDp1BFaii9oWMHGGf4/e18s3dTQIeuxdltX8MNigklND4xY65FGG8ae/jRMS/Ow+PS/DY+P+8oO+qqgmsNFSBhzfOTzbo8mhKcUxhqELnIsQN/o9PhUXA13rejdgEUDbHhOclncF8C3Uted+qzT84F+3d1ZM506/W0O12Dv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(376002)(346002)(136003)(396003)(39860400002)(1800799003)(186006)(451199021)(52536014)(38070700005)(41300700001)(26005)(2906002)(5660300002)(8676002)(4744005)(8936002)(55016003)(122000001)(86362001)(316002)(33656002)(6506007)(7696005)(76116006)(54906003)(110136005)(38100700002)(66556008)(64756008)(66446008)(66476007)(71200400001)(66946007)(478600001)(9686003)(4326008);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_AS8PR08MB7991C0D40E5CB6C8FA7600D0920CAAS8PR08MB7991eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6336 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 408b2086-bf12-40e3-29fd-08db974d99db X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sg5u0IrHIJxcVEr9WzWMxJrZPukkzBwuTOnTdy8cyYBxa984XBOai7cdb+1VcSxdjjSxxmD3yAhTuEzzMUtwpWATPjVZQhD5e0df21B9WamT4IpyQrg5FiV9CGvOATf/+8Jgjk+GP6lZO5pxE4TYwemVIT2ooPdDyeXIZ6ad3iBV3NMkZukzgbkvhbGcAXZ1sxvOD3KhQDlpzJuCqW4bm4H0LpO/IUxp5SA0by5wiY6pWf/nHlT9xmDFPYYMD/ScILmQo2Q4xD081borZmDHX42alVZmXhurfwqT7yeO7/zJvb/dBQ4ZIbXOS4fDzGHDup2QZhvWfjJNWca4LMuSbSWJiy3rJSbPi6C5K2UVIGeq9WGl7rz0GFQcO3GZdvrZUdBiiOjTeH9bLsR6X25tfwZEvmQZ1IAQWj1uYRtZroebpOuiUmBLIvs9Gd02fPzv1sNbRFBREFBTukgEjNGazqqWBAFni2TXrybZyltdODvBs1PSy7Ehix+nzI6EdkodxfieGk6KfGEn7QMtztFRwn0CzAOe4EQW9BB8k84HADxZv5v5drF8XpmNyEvR3amkhZM+tatctrbPYGXsZu3ciwYj7bRoHFwLpGLWbYaO4P8V3lZvreEqhMrM14NguMYQj/H/H97CHAxCymifeoW3Orlp1QSONnLYtNDQR4WwMxbBNr/sF7zWJ1MuPe7fvsfretNQojqeakN2JrQ0iNu35cbmJO2wE/p+YJv0MgywB8H/DcqyXNBcWn1ZPpYr06OE X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(396003)(39850400004)(1800799003)(451199021)(186006)(82310400008)(46966006)(40470700004)(36840700001)(82740400003)(40460700003)(26005)(47076005)(8676002)(6506007)(316002)(36860700001)(70206006)(2906002)(4326008)(5660300002)(70586007)(8936002)(41300700001)(52536014)(9686003)(7696005)(110136005)(478600001)(40480700001)(55016003)(54906003)(356005)(81166007)(33656002)(86362001)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 13:53:27.1745 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a813dac-3e37-4f5d-51e7-08db974dacea X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB9058 --_000_AS8PR08MB7991C0D40E5CB6C8FA7600D0920CAAS8PR08MB7991eurp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > Re: [PATCH] x86: Drop opt_pku entirely Hi Andrew and Jan, Sorry for the possible format issue. >> At which >> point I'm fine with no adjustment to cpuid=3D doc. And then also >> Acked-by: Jan Beulich > > Thanks. I'll tweak. Acked-by: Henry Wang #CHANGELOG Kind regards, Henry > ~Andrew --_000_AS8PR08MB7991C0D40E5CB6C8FA7600D0920CAAS8PR08MB7991eurp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> Re: [PATCH] x86: Drop opt_pku entirely
Hi= Andrew and Jan,
So= rry for the possible format issue.

>>  At which
>> point I'm fine with no adjustment to cpuid=3D doc. And then also >> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> Thanks.  I'll tweak.

Acked-by: Henry Wang <Henry.Wang@arm.com> #CHANGELOG

Kind regards,
Henry

> ~Andrew
--_000_AS8PR08MB7991C0D40E5CB6C8FA7600D0920CAAS8PR08MB7991eurp_-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:01:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:01:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578479.905995 (Exim 4.92) (envelope-from ) id 1qT0ng-0006tB-AN; Mon, 07 Aug 2023 14:01:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578479.905995; Mon, 07 Aug 2023 14:01:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0ng-0006t4-7J; Mon, 07 Aug 2023 14:01:36 +0000 Received: by outflank-mailman (input) for mailman id 578479; Mon, 07 Aug 2023 14:01:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0nf-0006st-0n; Mon, 07 Aug 2023 14:01:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0ne-0000IF-Nh; Mon, 07 Aug 2023 14:01:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0ne-0003tt-9j; Mon, 07 Aug 2023 14:01:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qT0ne-0006xE-9I; Mon, 07 Aug 2023 14:01:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dCQuKAe1ADwMf477QHW8ezG4mxGwP7/HCRAjTmtEjrw=; b=UUq+Jfq1dbCLpip2ufZkOJaUuG ehXKIBuf4fsTF2Ltj+teUZ8gvyXU21k6n5KIawzhB/8NXabPkNrekKVYl2WaGhbhhyNODmTwQbgxx WjIkmqIlIS1OHIOA2qfkEbsOc2/aUteQgxuJWdO+p2R4/H8Tctc3vIwG2aixlVfszHu8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182212: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d63ea6c46b89bffb99647871c788c236a8286646 X-Osstest-Versions-That: xen=e55146071de9257d70bd157047700071d0007622 From: osstest service owner Date: Mon, 07 Aug 2023 14:01:34 +0000 flight 182212 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182212/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen d63ea6c46b89bffb99647871c788c236a8286646 baseline version: xen e55146071de9257d70bd157047700071d0007622 Last test of basis 182189 2023-08-04 23:00:26 Z 2 days Testing same since 182212 2023-08-07 10:00:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dario Faggioli Federico Serafini Gianluca Luparini Gianluca Luparini Jan Beulich Nicola Vetrini Simone Ballarin jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e55146071d..d63ea6c46b d63ea6c46b89bffb99647871c788c236a8286646 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:04:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578488.906006 (Exim 4.92) (envelope-from ) id 1qT0qX-0007Sq-OT; Mon, 07 Aug 2023 14:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578488.906006; Mon, 07 Aug 2023 14:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0qX-0007Sj-Lm; Mon, 07 Aug 2023 14:04:33 +0000 Received: by outflank-mailman (input) for mailman id 578488; Mon, 07 Aug 2023 14:04:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0qW-0007SZ-DO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:04:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 533fc0c7-352b-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:04:30 +0200 (CEST) Received: from mail-mw2nam04lp2177.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 10:04:27 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ2PR03MB7112.namprd03.prod.outlook.com (2603:10b6:a03:4f7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:04:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 14:04:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 533fc0c7-352b-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691417070; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=VmU4k6SzTOG6clx1I/wtoQArWZ7X1lPWZ71QxHnBZKs=; b=cUoOeSeDtdecTgYQM8GCytSFtxlGSdC5nLnO0W0HbprlR4nDPqZs5Cqp qEleQY4EraZmOwLD8DC/SJIjolaHC+J2c5Uq2XGtOfTTgukxNR8kKV37z JPWaJi45OpZ6kPt1Mq1HaRxn/p4mCX3irOjiaVsOlUJnlk5ZXfaXrRC+l Y=; X-IronPort-RemoteIP: 104.47.73.177 X-IronPort-MID: 118607559 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:u/jusauedXKDOyMi+dfHtrPPxOfnVKhfMUV32f8akzHdYApBsoF/q tZmKW/UbvmLYmTxftl2PYqwp0IO6sXWnNBiSFBlpH80Hn8a+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5A+GyCFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwJBQzUQ68q7yK6eznRtVOjZ0RLZLBBdZK0p1g5Wmx4fcOZ7nmG/mPwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0oui/60b4W9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOThpqAy3wDOlwT/DjUNexyjpqWzgHS4fPxTN BI65xt/kYE9oRnDot7VGkfQTGS/lhwWVsdUEuY6wBqQ0aeS6AGcbkAfTztGbvQnstE3Xj0g0 lKVn9LvCidrubfTQnWYnp+LqRuiNC5TKnUNDQcBRBEA6sPuo6kyiAzOVddpFKOpjtzzFir0y jrMpy87750DgMhO26il8FTvhzO3uoOPXgMz/h/QXG+u8kV+foHNT5Cn7Ujz6fdGMZqDSV+Ar D4IlqCjAPsmCJiMkGmIX78LFbTxu/KdamSD3hhoAoUr8Cmr9zi7Z4dM7TpiJUBvdMEZZTvuZ 0yVsgRUjHNOAEaXgWZMS9rZI6wXIWLIT7wJiti8ggJyX6VM IronPort-HdrOrdr: A9a23:bsODKaMGq0D6j8BcTuOjsMiBIKoaSvp037BL7TEVdfUxSKb0qy nAppgmPHPP5wr5IUtQ/uxoW5PwI080l6QU3WB5B97LYOCBggWVxepZnOjfKlPbehEWwdQtsZ uII5IUNDQpNykBsS8h2njBLz/8+qjgzEl1v5ak856yd3AWV0kOhz0JczqmLg== X-Talos-CUID: =?us-ascii?q?9a23=3ACkQNxWrHqL1drx/ZxKgnwIfmUcwBTELD81uOH2b?= =?us-ascii?q?mVWpVarbMe17L0poxxg=3D=3D?= X-Talos-MUID: 9a23:Gs58UAgHUsurHj20GxmsTcMpL+kv+6PyAko3l7Iot9baGzFBagu0g2Hi X-IronPort-AV: E=Sophos;i="6.01,262,1684814400"; d="scan'208";a="118607559" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAI932hAROOaEtTrY4GBo+HDdzNhfw64cEESOKaS2jul2tE2eQuNan186tM4+Sbmba0WspkkL0l4vt90WZMLp15KTzIIGLgeNekYDDyi3hcG6KEne2XZkXNl3jiRKTQhojRm8Q/dKCBP0cCWI4RlGFerjZGofNbMH88ryvbZFlvsNcrejNYt+gOklkjZk1Gup5ftNM2+nRk9I382zFIm9gJD7FBN2t7/b5rws9CmoRrdb844UacfX6QOs0tMlTypRE/lq18+tRyF4Qs+jzJuwYa6+JWDDR7bWy+GDrvLeF2/kPi87LBm8zrkgWrLj1M5ueV/KMzHSbNuIzMCUxMhpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VmU4k6SzTOG6clx1I/wtoQArWZ7X1lPWZ71QxHnBZKs=; b=Zg51fvtngLJ10lGMfC2XP/uN2YwEHHTbi5O98cu5gBHBquCsVgbDQvBmvZhmkNY5TH6BP4FA7Epv793UlMJ+jeZOrm58S4HaNdBdnT6DxW/NdTZgxvF2VgLM21KcGHK70T5sYM3o5BrxhQUsu3PPgzlCw0k3wvHJq1iQaBBpoT66DB6bRXJi7e1JZJV54nTFbTr1FG0+ra2RwMHzCE5p+0L1e1XnN7igLj1GKP/xeLV9aI+3dTUFaIP9Fc98Y1DBkULrCCuxB0SH2dXB5ldknhzm6PmFgh5EiFajD9RxBezgDliVtg5qVPRlyufRXHbCinQqudlK6Ffqrg8RyVJ3Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VmU4k6SzTOG6clx1I/wtoQArWZ7X1lPWZ71QxHnBZKs=; b=F09jqx97iciI8XHq/iwi5iLMRIreixySodryCt3BAhJBHlpJSSD0eG8evbt0jaJtxCxx6NtJOB/VL758LeKq1+lH3ESnbfTTeXoktS37y1valWoLgVH7uuRRqupb6Hn+dhIPu0GiqS/MoW8f6SvUu7LMmMZZX3yA6vSgcrGumpQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <298af911-f4f0-165d-c493-90407d649945@citrix.com> Date: Mon, 7 Aug 2023 15:04:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-GB To: Jan Beulich , Simon Gaiser Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, Thomas Gleixner References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::10) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SJ2PR03MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: eb24a44a-58fb-4fb6-cfa5-08db974f3543 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ew0rJqn3BrmFBWveJXF79T5cv56goLNqUGnCfmBxJkMsq3o4dRoAf1dEXGq9UvcPc/ZGoA2ssJrNwxwnngrNV1bvsgOZh4QEoHwe36D3FyLjoPOdwALBs6UI9BQaGiTCyfHGx2M3+whSiWaor+xeictLz0uihuJ8oGUwN0d5SMYWqCC7MRKVUL7iI679Pq/OBaJrobcz8OG5VRV5546GwoSl08TjmXdX/5xUVuutnFN4YoV6qgVBzy6YIZcjt9mbiSyqa46D7igoF8zdMndyJdR6fzfpO6tMFXkXE96ieeuI1ExcCVZNIqPRgkzXJKFRy5Op5N1woXTqJGV/vG1sPrtU2vesV2wddFr0aIHc68ZRlLzl3dAHJsYife3lw6OH/NiY5okaKeZZHmGnKdZOJ36koYiJv/2yvW1tDddxgrnqvHkKzyJtaQvj4qhiOfRaI4flzgkQzVVBu04aCaOrxM/bTcfDMlm5hrRBsHe6HjfPF26PE+z5dmq8sEqt8Z243RMgYPjTd4UTDEjN3j16PnOqZ5pZqpshIDG8ooO7o3nIvrPXoa5JGWAeKJMkLwP9uWFP/4TLzOzzCwNRssS+N+PzjeZCeP6PvgyHbiDs3J9HNj80osW8Wj8BlKt2BjzCDgpzXTaa+1RXXB/VJT9B0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(1800799003)(186006)(451199021)(4326008)(316002)(38100700002)(66476007)(66556008)(66946007)(6512007)(6666004)(82960400001)(6486002)(2616005)(83380400001)(36756003)(26005)(53546011)(6506007)(86362001)(2906002)(31696002)(54906003)(478600001)(110136005)(8936002)(8676002)(41300700001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clVrOUdSUFlRdEg5OFJWcXBCMVJuSmg1R2ZxSEdKTjNCMFlGOHQ2cmtSMTVQ?= =?utf-8?B?aXBsU2p5SGdXSUNZcjF4ZklhK2dMZTRIZDFrYTYwclRKaDN6RDM4aFdSVnlk?= =?utf-8?B?ZU1lTXQ0RXRCMVVMVUhPaDFCVk9nWmNDOGlweVVhV2x3NEhQd0ozL1ZnS2dL?= =?utf-8?B?b2I4cnJnMmp4c3VJMkdaNTBXUVBuZnZReDhHdkNvTVZGRnJmL05MYThUVWhs?= =?utf-8?B?dTlTYTZmaFk2SEVJMDgyNS9xNHZDZ2N1N3hGclorM0NTQVdJZXF0cWJDcGMv?= =?utf-8?B?QkpiM21PS25oTWYwYms3SXhMczZYNnJpMDdtSC9kVk5wbWFZZ2JpVjNGenFx?= =?utf-8?B?cVdCTTJSQ1p0dDEzVCs1MXZieXc3YmpPRGxRbWliL3ZLRThvM0gvQTJiQ1Uw?= =?utf-8?B?TUZ6VjVjOHNmNklSRmZIdVdwWFJ3VVlhdi92c2REa1k4QzB1VDM1RjEvS3Jp?= =?utf-8?B?YldCVmd4Ym0yRkJtOVRVL0w2OWloSjQ4STI4K3JEc2pENWdraDI4WmhxN1RQ?= =?utf-8?B?Q2FVSzNjK3MyY3pMUmtqQlpCNWFqV3c0Um1aaVY2TEZpZzBhQkttTy92bTI2?= =?utf-8?B?NXo4RmRweFN0aC9DQ1BIdytPSGQ0d0tvNzV3emJUVGloUUIzMVR2aDJidG5q?= =?utf-8?B?UVhYMjZUYmdOalJlSzROM3BXSkhhckQxS3owOWxPNlI5ZUY0SEUzQTI0TEth?= =?utf-8?B?am1ZdkNPaUdBNzh6RUhNTmt6VnlBTFNrdnEvbGxXWHJwdXNLeStId01PUE9Y?= =?utf-8?B?bWdTTktBOW5jTWwwUUJ5K0dsK2h5dks4L1hQQnZKVi9naXRXVlh6TGRLK05T?= =?utf-8?B?WTV6NjZxOWdPOFAxcWcydmlwQTlXZWZOekYybE5VMnhKSHpnbFZxdThpWW1O?= =?utf-8?B?dkFNVEt1eXRjb01IQzcxZWNPQ0kwbUZ6ejhyamRsNkh2VWJyeVpkS2Nzd3Zk?= =?utf-8?B?Wm4wMjY3MHhLcFlBSFFselBhMWxRTHdoQnBsd1pFZnR6aGE4ZjhMRnFIRjNm?= =?utf-8?B?aXl2NlVVcjF6bjB4L1diWEwwZ0pYcDVmQjVZRmxDNVNlQXZja0pYSlBSRUFU?= =?utf-8?B?RisrbFFiVWRrRmdCU2pFVkpuWUJBVU41V2h6UCswM2RYK1Z6NXppVjJGSURW?= =?utf-8?B?UmR1YlEwdWVxTnhPQ0ZaL2RLc1BpOUMxTkt2bVJGeDR5Mk9MQjlZb29iNENI?= =?utf-8?B?Y3c3akRGRWdPNEJQRTlhbFYxS3E2dTlaazlzU0ZrTEc3MWUxNjNQcGNkdlA4?= =?utf-8?B?bUtHMEdKdFQ4NDJwaVBSaXRiTi9OaUt3SVlrYXJCaFJteW9mMGQybEl2Ym1S?= =?utf-8?B?dlMrNkZtYzhtRGpOaldSTzRselRnOFZ5NUVFMmJSS054djQ1b3l5T2QyQkNu?= =?utf-8?B?OG9kNVdHbVZ3Q0lKRTdER0psSENZWGRaN0huZ0lLVmFpOTgwNFN5NGlycXZa?= =?utf-8?B?K1o3RGpmallwd1EycHgrRzdmTnFJL1lmbDVLTEZ4YTlHSzlmRHVpMjdQdzdh?= =?utf-8?B?NDBjY3h1cHhISkNFbjRhUWQza1ZCSEZvZkZqSjJnSC94VUViejQ1SnNTcEpx?= =?utf-8?B?WU12U1ZjekRqdWgwOGJYMUYyOUpEKzVzdnNpTldRbWZpNUIzQnAwdjFEdy9J?= =?utf-8?B?dnJCZVBQanVWRFZETkx1K0hxbW1oRWdkTjkrci9UMmh3MXF6Smx0RlJCdFR5?= =?utf-8?B?Rm10OFB1R1dUVmNKVkZhQjRQOHdBYnl1dG1zRnBnQjE1blhYWlQ2cjhjMjJW?= =?utf-8?B?QXFDU1duT3JJRWF6M2VUOGl4WERpMlFwMEFrNlhzbXdpTVhQMnNkVTZmc3ZG?= =?utf-8?B?aVRiQXlRRTRoOEoweWUxNm1LdXptNlBwa3QrQzAzb0RTSEZXbE56QmsxQUg5?= =?utf-8?B?NnZzNmQzUjc0TFYveWJINlFxVjZtdHVPdXlWdDZDSXUvb01mRGRGcEdMQnJD?= =?utf-8?B?NXJ3ZzBFK3VUbTZIeFVaampSaVdHcDZJUzNBdDA0NS96Um44RmdveEUwNDA2?= =?utf-8?B?clplcWdUVmZNUGxmZGlwUGFoUjJ3QmtrVVQ3TS80dDR6Q003cHRHTzFpeHVW?= =?utf-8?B?aDEzWXdkMXJuVXE5akpnaFpwTGRqRnJTemh1SElHeTRxWmFRVmV1MW9YOTdx?= =?utf-8?B?Z2Z5V2MwNkVxWC9KMC9uRUNlVGVHV3hWRDJDeGlEeXhQTzNob21iM0E3Y25O?= =?utf-8?B?L3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ruSp93B2LwWDGfNkEx8Nm112DNjWPgk2inXeDLiwGXLGYAynoeZfApf34RalBZ2qmkZy6av3O3L+qurUVvwZLx8GuQTb3fQUXMvRiGMYP/rQoX5JYuWbV+k+vIxelMjsdWvSjdNeM0J9UEbJ1nQlums7CQNcuMaSXuNIfT4O1cwxKskp4rYA8n+axs9mgqv+MPPjlEI8mxdhNuZ18w2k88H6PyVpBQRnshTxsYhIN4WqC8MftsfBqQ4lqnOl2XI/EiMAOg6rGEJSPT3N5AJrsPvNiqqivsswbVXf6pPxkjZKoc9exUFRLqxVak1QtlSjWeUnRG7et6Qgcvx0Q9PJNlAfKLnZ4lJ7bi0Fmk1AIwDnY+qqf7AcoPCcqxqCzfrYewA714/Ofnp20qjPsT7q8ZX3T2O9VRv127jaVTMUibWsOyx8Is7NzGBlUInw+fAPjynj3Fks5UIWZnrRZ65mNBBS7ou2ml/YDA2nIqJ7S/kMoLqrydpzMNVm3/t8R6OgaueK63qe3jX2mHFadadhBMkd41/PchJml48NKcy+0TK64lN/g7LYR07M/hGOZT247U1CUKearWgZhPP7StP7jCYdZjTZ1If8vebh1QqczIfDKzc5hbrg+6M0OgMl1nzudN6spanr0gQrm+4nfpkW9A5SKFHNNIvhutFMxleaLGiuMFFPXSK8EawTl8zLm9kyh2QOIYurnfC1oUxlCpvMzY5x7ImtZXVzGyHaHvOu1Erzo77YJ+PMG7ZL6JRhDuympDWvh912b3O/Pn03XolACzgrvt+G/nl9sgWGF4dWaXehlsDHI1tEBkp1/OhD8JZNzV9jsK/qkq4h4TIvvgBZWg0Rb2O2EjMFlHVxsi2wdgc/sBWg4Es6DQdgbgO/9yyouFNjs7anz46uBeHAjagYNPfJ80lsyU+3GPyYMsJmrFA= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb24a44a-58fb-4fb6-cfa5-08db974f3543 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:04:25.8501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /qvMfZblmvMEuGdIZybgmJpYXkZn/xn3RbXsr0yPaZR0NfMvHSdQQSOjP/eM384x78a+Gy3edPXRq8TxvWlTpXAlYxdpNYaK+fUUWYpjzs4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR03MB7112 On 07/08/2023 2:17 pm, Jan Beulich wrote: > On 07.08.2023 14:55, Simon Gaiser wrote: >> Jan Beulich: >>> On 07.08.2023 11:38, Simon Gaiser wrote: >>>> It seems some firmwares put dummy entries in the ACPI MADT table for non >>>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>>> 0xff. Linux already has code to handle those cases both in >>>> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >>>> same check to Xen. >>> I'm afraid it doesn't become clear to me what problem you're trying to >>> solve. >> I want Xen to not think there are possible CPUs that actually never can >> be there. > Did you try using "maxcpus=" on the command line? If that doesn't work > well enough (perhaps because of causing undesirable log messages), maybe > we need some way to say "no CPU hotplug" on the command line. The ACPI tables are broken, and Xen's parsing of them is wrong. And irrespective - it's unreasonable to have users work around bugs in Xen by adding more command line. > >> Without ignoring those dummy entries Xen thinks my NUC has 2 sockets and >> that there are 8 logical CPUs that are currently disabled but could be >> hotplugged. > Yet it's exactly this which ACPI is telling us here (with some vagueness, > which isn't easy to get around; see below). > >> I'm moderately sure that soldering in another CPU is not supported, even >> less so at runtime ;] > On your system. What about others, which are hotplug-capable? It is required that all APIC ID are stated *ahead of time*. Entries with 0xFF and 0xFFFFFFFF at boot are entirely invalid. Furthermore, given debugging that I just did with Thomas, it's very clear that noone has tried really hotplugging CPUs under Xen.  The layering violation is rather hilarious to watch. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:07:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:07:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578494.906015 (Exim 4.92) (envelope-from ) id 1qT0sq-00086Z-A5; Mon, 07 Aug 2023 14:06:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578494.906015; Mon, 07 Aug 2023 14:06:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0sq-00086S-7Y; Mon, 07 Aug 2023 14:06:56 +0000 Received: by outflank-mailman (input) for mailman id 578494; Mon, 07 Aug 2023 14:06:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0sp-00086M-FY for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:06:55 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8a77e74-352b-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:06:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8a77e74-352b-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691417214; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Lcj39dcakHvuWWa2TgBrCqBP6PmhlerS0mSmRoIchL4=; b=MpOnl7r41C/OkgaNnox+8SfHvbb7hhz5oxxY2Zmk+m1vEHm9Ca9buZIY HjZyBx2yk2zDXPz0oMRUFq2qT70VpYIGHX/0a5V2FyIJiq809gZ8Ci57H P4iNQlpifszf0xvUc256clBXuszvuUjjlM83nlpKYr3WdpM+X7yxscH53 I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 121376940 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:4PFKZq29JY4ErNrM8/bD5fVxkn2cJEfYwER7XKvMYLTBsI5bp2NRx 2MZWzvSPf/cZGqnf9siaNzk90wGsJbcytNrTQtrpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8XuDgNyo4GlD5gxmOqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfKGcJ/ KBGBmk2SxWJuuzt6byDTNNziZF2RCXrFNt3VnBIyDjYCbAtQIzZQrWM7thdtNsyrpkQR7CEP ZNfMGcxKk2aOHWjOX9OYH46tO6umnn4dSwesF+PrLA7y2PS0BZwwP7mN9+9ltmiHJ8MxRnG9 z6el4j/KggUHu649mHCzk/22sbfrBv5QrMdKpTto5aGh3XMnzdOWXX6T2CTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYeUddNF+wx6CmW17HZpQ2eAwAsUTppeNEg8sgsSlQC1 FCTmMjyLSdyq7DTQnWYnop4thvrZ3JTdzVbI3ZZE01cuYKLTJwPYgznZ9AkGfLroITOPDT6/ j7RhSYGgY8Mgptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5 SVfxZDChAwbJcvV/BFhVtnhC11ACxytFDTHyWBiEJA6n9hG0y7yJNsAiN2SyaoADyrlRdMLS BWI0e+yzMUJVJdPUUOQS9zZNijS5fK8fekJr9iNBja0XrB/dRWc4AZlblOK0mbmnSAEyP9uY MzHL5bwUytDU8yLKQZaoM9Hi9cWKt0WnzuPFfgXMTz4uVZhWJJlYehcawbfBgzIxKiFvB/U4 75i2ziikn1ivBnFSnCPq+Y7dAlaRUXX8Liq86S7gMbfeFs5cIzgYteNqY4cl3tNw/gIzruVr iHiMqKaoXKm7UD6xcyxQigLQNvSsVxX9xrX4QRE0Y6U5kUe IronPort-HdrOrdr: A9a23:iMl2s6rLPp6dR6Ujn1YNWxQaV5oNeYIsimQD101hICG9JPbo7f xGuM5rrCMc7wxhPk3I+OrwX5VoJEm3yXcb2/hzAV7PZmnbUQiTXeVfBOnZsl/d8nbFh5ZgPM 5bGsAUNDSaNykesS+V2miFOudl6MWb9rulnOLPpk0dNj2CqJsN0+66MGum+4FNKzWuzKBWKK ah X-Talos-CUID: =?us-ascii?q?9a23=3AiYhwNGmsIorK3s8NsPLF1HrRgZ7XOVTbi36MfWH?= =?us-ascii?q?hMkNsQoCbEnaewKVejMU7zg=3D=3D?= X-Talos-MUID: 9a23:T1e3qgba97pjq+BTrjHGthZdb4BU3v7yIVA8qZccisa6HHkl X-IronPort-AV: E=Sophos;i="6.01,262,1684814400"; d="scan'208";a="121376940" From: Anthony PERARD To: CC: Anthony PERARD , Jan Beulich , Wei Liu , Juergen Gross Subject: [XEN PATCH] libxl: Use XEN_LIB_DIR to store bootloader from pygrub Date: Mon, 7 Aug 2023 15:06:19 +0100 Message-ID: <20230807140620.47221-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In osstest, the jobs using pygrub on arm64 on the branch linux-linus started to fails with: [Errno 28] No space left on device Error writing temporary copy of ramdisk This is because /var/run is small when dom0 has only 512MB to work with, /var/run is only 40MB. The size of both kernel and ramdisk on this jobs is now about 42MB, so not enough space in /var/run. So, to avoid writing a big binairy in ramfs, we will use /var/lib instead, like we already do when saving the device model state on migration. Reported-by: Jan Beulich Signed-off-by: Anthony PERARD --- tools/libs/light/libxl_bootloader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_bootloader.c b/tools/libs/light/libxl_bootloader.c index 1bc6e51827..108329b4a5 100644 --- a/tools/libs/light/libxl_bootloader.c +++ b/tools/libs/light/libxl_bootloader.c @@ -245,8 +245,8 @@ static void bootloader_cleanup(libxl__egc *egc, libxl__bootloader_state *bl) static void bootloader_setpaths(libxl__gc *gc, libxl__bootloader_state *bl) { uint32_t domid = bl->domid; - bl->outputdir = GCSPRINTF(XEN_RUN_DIR "/bootloader.%"PRIu32".d", domid); - bl->outputpath = GCSPRINTF(XEN_RUN_DIR "/bootloader.%"PRIu32".out", domid); + bl->outputdir = GCSPRINTF(XEN_LIB_DIR "/bootloader.%"PRIu32".d", domid); + bl->outputpath = GCSPRINTF(XEN_LIB_DIR "/bootloader.%"PRIu32".out", domid); } /* Callbacks */ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:10:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:10:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578502.906026 (Exim 4.92) (envelope-from ) id 1qT0vu-0001AD-QB; Mon, 07 Aug 2023 14:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578502.906026; Mon, 07 Aug 2023 14:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0vu-00019n-MT; Mon, 07 Aug 2023 14:10:06 +0000 Received: by outflank-mailman (input) for mailman id 578502; Mon, 07 Aug 2023 14:10:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT0vt-00013e-Qn for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:10:05 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a694a65-352c-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:10:03 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id EECD94EE0737; Mon, 7 Aug 2023 16:10:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a694a65-352c-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 16:10:02 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2 4/4] x86/setup: address MISRA C:2012 Rule 5.3 In-Reply-To: <66d0ea64-0363-db7b-b4e2-5e404bff28d2@suse.com> References: <484a88bb35cdb6e5ec036d40fb2b4e20678fd975.1691135862.git.nicola.vetrini@bugseng.com> <55099faa-206a-b7ae-8ef1-64d1dc344c4c@suse.com> <66d0ea64-0363-db7b-b4e2-5e404bff28d2@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <50fe2600058c0e5224b822ad49db75eb@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 15:42, Jan Beulich wrote: > On 07.08.2023 15:18, Nicola Vetrini wrote: >> On 07/08/2023 15:05, Jan Beulich wrote: >>> On 04.08.2023 10:03, Nicola Vetrini wrote: >>>> The parameters renamed in the function declaration caused shadowing >>>> with the homonymous variable in 'xen/common/efi/boot.c'. Renaming >>>> them also addresses Rule 8.3: >>>> "All declarations of an object or function shall use the same names >>>> and type qualifiers". >>> >>> Can you explain to me how shadowing can happen in a declaration? I >>> would focus on 8.3 here, and only mention the other name collision. >> >> There's "static struct file __initdata kernel;" in >> xen/common/efi/boot.c, which >> is visible when the function is declared. Since renaming these >> parameter >> names would >> have been addressed by Federico for R8.3 anyway, my intention was to >> address them both. > > I understand what you say, but your reply doesn't answer my question. > Just to emphasize the important aspect: I could see the shadowing > aspect if the _definition_ of construct_dom0() used "kernel". But I'm > asking about declarations (the one here as well as in general): I > can't see how any shadowing can occur without there being any code in > the position of using any such variable / parameter. IOW if Eclair > spits out 5.3 violations on declarations, I'm inclined to think it's > wrong. (Because of 8.3 a violation there would then need dealing with > anyway, but _only_ because of 8.3, if the definition is already okay.) > > Jan The declaration itself is a scope and shadowing can happen, as in: int x; void f(int x, int arr[x]); Now, the example is a bit contrived, but the fact that the rule does not list any exception motivates this behaviour. In any case, I'll try to rephrase the commit message to be less ambiguous. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:17:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578509.906036 (Exim 4.92) (envelope-from ) id 1qT12e-0001rB-LJ; Mon, 07 Aug 2023 14:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578509.906036; Mon, 07 Aug 2023 14:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT12e-0001r4-IT; Mon, 07 Aug 2023 14:17:04 +0000 Received: by outflank-mailman (input) for mailman id 578509; Mon, 07 Aug 2023 14:14:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT10a-0001nV-OT for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:14:56 +0000 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [2a00:1450:4864:20::22b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c7c08f84-352c-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:14:55 +0200 (CEST) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b9bb097c1bso70380181fa.0 for ; Mon, 07 Aug 2023 07:14:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7c08f84-352c-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1691417694; x=1692022494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=miXhKIkPE3lmozcU/B+jO2gbohIQfxtvXQrL6JQrLaA=; b=rUbGf+JZcp35dmq7w8slw0nHgKluYcuW30g35dHvkRNE8GAplx/bmohiweQc5R1m+t n8zrOL6x18GLNviLyBdF1SBbwknD+YT0R92Z3r7ozf/LbxR/ZX+oGNC6AweYXTnFy1Td qjM3KL4IzdURsMRiax7oRl3ig1sdRDyJ5+2Ck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691417694; x=1692022494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=miXhKIkPE3lmozcU/B+jO2gbohIQfxtvXQrL6JQrLaA=; b=CP6jlHg3e20+fXL3dQRiTWA/QacVmTeoRotK/6PzTz+epFyaECn/E/giPkUKVUNhAM mVvqZ5gP77YaK2u7qfRy9I8/M1y1A0iNp5IgK/kJY7ZTCJ+5U//z/Fkv5N96RW2uqHkk 14kGteuFMQnOklZ77DnBJXdNxOpulzxIC4iBlY3CJT/JViUfl4fg6DO7znJy/g5PdcEs MQq9yU+Q1fu1w/KU2cbJ8dz2jqQwKLoP+g7tE7shbzjB5ZZgNs2VEl4R6fGHDrIm8vXe xFsQDUZTHfAcmwQmkKF3j5Yffpcgu5eTz+Ov4HB5uSCzSPT7An/O6ftvtmqqx1+gVIGb +BpA== X-Gm-Message-State: AOJu0Yy26obgSDXuBfMpRyox5PgQc8bcQlezfBqR/JRnCE3+cRrs8+/A EIgxrVqiZL4E59nH0Qaf27cdEh47U7DazOLABdH7Sg== X-Google-Smtp-Source: AGHT+IEUzxQ8uhfef4Gwj5w4R2S1a/fG2YmFdaAnrERcAODuTjnUg5MW8ffcyCI3WwFTK01hsv/WyE2OTkrmMwFZBOU= X-Received: by 2002:a2e:9254:0:b0:2b6:dfef:d526 with SMTP id v20-20020a2e9254000000b002b6dfefd526mr6547671ljg.11.1691417693488; Mon, 07 Aug 2023 07:14:53 -0700 (PDT) MIME-Version: 1.0 References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-20-zhengqi.arch@bytedance.com> In-Reply-To: <20230807110936.21819-20-zhengqi.arch@bytedance.com> From: Joel Fernandes Date: Mon, 7 Aug 2023 10:14:48 -0400 Message-ID: Subject: Re: [PATCH v4 19/48] rcu: dynamically allocate the rcu-kfree shrinker To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 7, 2023 at 7:17=E2=80=AFAM Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-kfree shrinker. > > Signed-off-by: Qi Zheng For RCU: Reviewed-by: Joel Fernandes (Google) thanks, - Joel > --- > kernel/rcu/tree.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 7c79480bfaa0..3b20fc46c514 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -3449,13 +3449,6 @@ kfree_rcu_shrink_scan(struct shrinker *shrink, str= uct shrink_control *sc) > return freed =3D=3D 0 ? SHRINK_STOP : freed; > } > > -static struct shrinker kfree_rcu_shrinker =3D { > - .count_objects =3D kfree_rcu_shrink_count, > - .scan_objects =3D kfree_rcu_shrink_scan, > - .batch =3D 0, > - .seeks =3D DEFAULT_SEEKS, > -}; > - > void __init kfree_rcu_scheduler_running(void) > { > int cpu; > @@ -4931,6 +4924,7 @@ static void __init kfree_rcu_batch_init(void) > { > int cpu; > int i, j; > + struct shrinker *kfree_rcu_shrinker; > > /* Clamp it to [0:100] seconds interval. */ > if (rcu_delay_page_cache_fill_msec < 0 || > @@ -4962,8 +4956,18 @@ static void __init kfree_rcu_batch_init(void) > INIT_DELAYED_WORK(&krcp->page_cache_work, fill_page_cache= _func); > krcp->initialized =3D true; > } > - if (register_shrinker(&kfree_rcu_shrinker, "rcu-kfree")) > - pr_err("Failed to register kfree_rcu() shrinker!\n"); > + > + kfree_rcu_shrinker =3D shrinker_alloc(0, "rcu-kfree"); > + if (!kfree_rcu_shrinker) { > + pr_err("Failed to allocate kfree_rcu() shrinker!\n"); > + return; > + } > + > + kfree_rcu_shrinker->count_objects =3D kfree_rcu_shrink_count; > + kfree_rcu_shrinker->scan_objects =3D kfree_rcu_shrink_scan; > + kfree_rcu_shrinker->seeks =3D DEFAULT_SEEKS; > + > + shrinker_register(kfree_rcu_shrinker); > } > > void __init rcu_init(void) > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:17:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578511.906042 (Exim 4.92) (envelope-from ) id 1qT12e-0001uZ-V5; Mon, 07 Aug 2023 14:17:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578511.906042; Mon, 07 Aug 2023 14:17:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT12e-0001tl-Pg; Mon, 07 Aug 2023 14:17:04 +0000 Received: by outflank-mailman (input) for mailman id 578511; Mon, 07 Aug 2023 14:16:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT11n-0001q7-MS for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:16:11 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f46e693b-352c-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:16:09 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b9ba3d6157so73207501fa.3 for ; Mon, 07 Aug 2023 07:16:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f46e693b-352c-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1691417769; x=1692022569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mVE/GJTe1IuiufpABjiYZn1olHI1ifx/I1TivYEBHQg=; b=KDeUHSfDD3L4EI9ZDbXXnOCIgf36k4kTiyHRIIffaGRG3HCFl39GcfvKDi2APyBxt9 uIkOV41JjBWzvcfkl4hWbMoMF6B7yW2N6o4toZetNa+16q9cwIbk8dhp8WLMlbMnqtzs lrCcsJN2ho/fqPCpmMmUqd/p18Lc2P1XhR9Zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691417769; x=1692022569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mVE/GJTe1IuiufpABjiYZn1olHI1ifx/I1TivYEBHQg=; b=Fyz0LdMT+XDtd8qUGL0u1pk3J9VOlmpNgSrVQ40CsOmi6sqNJD8+c8EfpPLHZnUwTp HkMOgh4q+AQqRMTG4LA6IkcabBx1OhssIqYLVYzI7lSlDSFNbXC3llVdZQQA3/X3q0eR sep0363xb1kOlW0v55qLKcr1kTrVnpj06jpxAOAPiffmAl94DFKgj/CZZK7IIEYKakDG o/xVoOUpmJK7DZkMTdGNiVhzpZ4LaXTPkLTgZtiCHGVo7IgGQpetLpqKO2w6UdQRddwA RP8tEUtrNsG0UbcG0gLpwtx/VDGUbthGRjH4olsCJa8sjpOiYfbQIeIyy7Y3rxKD5Dj8 bVEw== X-Gm-Message-State: AOJu0YzM/AGaD0mG8upaxKKPI6maFxjTFTg+b0TlCycA+zKdev1NLpjX 4uWnJpVnaukqXvhxl4neOigkwazQa+koHdxbNJVmvw== X-Google-Smtp-Source: AGHT+IGOrJUhdG+ahMA8bObfIwJouhmkY47ZzUfvTwinDgzhZuBpH+4Q7OaueJuZRAHK8xn8XVlTzjWWvAUYbt+ovvQ= X-Received: by 2002:a2e:b166:0:b0:2b9:dd3b:cf43 with SMTP id a6-20020a2eb166000000b002b9dd3bcf43mr6572529ljm.13.1691417768626; Mon, 07 Aug 2023 07:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-19-zhengqi.arch@bytedance.com> In-Reply-To: <20230807110936.21819-19-zhengqi.arch@bytedance.com> From: Joel Fernandes Date: Mon, 7 Aug 2023 10:16:03 -0400 Message-ID: Subject: Re: [PATCH v4 18/48] rcu: dynamically allocate the rcu-lazy shrinker To: Qi Zheng Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 7, 2023 at 7:36=E2=80=AFAM Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-lazy shrinker. > > Signed-off-by: Qi Zheng For RCU: Reviewed-by: Joel Fernandes (Google) thanks, - Joel > --- > kernel/rcu/tree_nocb.h | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h > index 5598212d1f27..e1c59c33738a 100644 > --- a/kernel/rcu/tree_nocb.h > +++ b/kernel/rcu/tree_nocb.h > @@ -1396,13 +1396,6 @@ lazy_rcu_shrink_scan(struct shrinker *shrink, stru= ct shrink_control *sc) > > return count ? count : SHRINK_STOP; > } > - > -static struct shrinker lazy_rcu_shrinker =3D { > - .count_objects =3D lazy_rcu_shrink_count, > - .scan_objects =3D lazy_rcu_shrink_scan, > - .batch =3D 0, > - .seeks =3D DEFAULT_SEEKS, > -}; > #endif // #ifdef CONFIG_RCU_LAZY > > void __init rcu_init_nohz(void) > @@ -1410,6 +1403,7 @@ void __init rcu_init_nohz(void) > int cpu; > struct rcu_data *rdp; > const struct cpumask *cpumask =3D NULL; > + struct shrinker * __maybe_unused lazy_rcu_shrinker; > > #if defined(CONFIG_NO_HZ_FULL) > if (tick_nohz_full_running && !cpumask_empty(tick_nohz_full_mask)= ) > @@ -1436,8 +1430,16 @@ void __init rcu_init_nohz(void) > return; > > #ifdef CONFIG_RCU_LAZY > - if (register_shrinker(&lazy_rcu_shrinker, "rcu-lazy")) > - pr_err("Failed to register lazy_rcu shrinker!\n"); > + lazy_rcu_shrinker =3D shrinker_alloc(0, "rcu-lazy"); > + if (!lazy_rcu_shrinker) { > + pr_err("Failed to allocate lazy_rcu shrinker!\n"); > + } else { > + lazy_rcu_shrinker->count_objects =3D lazy_rcu_shrink_coun= t; > + lazy_rcu_shrinker->scan_objects =3D lazy_rcu_shrink_scan; > + lazy_rcu_shrinker->seeks =3D DEFAULT_SEEKS; > + > + shrinker_register(lazy_rcu_shrinker); > + } > #endif // #ifdef CONFIG_RCU_LAZY > > if (!cpumask_subset(rcu_nocb_mask, cpu_possible_mask)) { > -- > 2.30.2 > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:18:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:18:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578521.906056 (Exim 4.92) (envelope-from ) id 1qT146-000322-9O; Mon, 07 Aug 2023 14:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578521.906056; Mon, 07 Aug 2023 14:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT146-00031t-6F; Mon, 07 Aug 2023 14:18:34 +0000 Received: by outflank-mailman (input) for mailman id 578521; Mon, 07 Aug 2023 14:18:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT144-00031d-Ay for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:18:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1a::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4893128e-352d-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:18:31 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8841.eurprd04.prod.outlook.com (2603:10a6:20b:408::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:18:28 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:18:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4893128e-352d-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FO0HTaoeFKsJdqLV5yDVJWhE6VCawUUyfUvhDDxsxIUsOhn8SkpFINV+OIa9OC1ZBu5Ib2W/2VVbomBic73idrQ805gv4RANYcPgglQou0hUsVkj3zKzSJBYeZX2UyXwbUpYkR92Sc3CDcldul4lKgmD/FNdwkwanPY5xBzk2djFWJSOAlRDEBu7CDo+JedygGlupIyojYy409Xbha4t8aHH0rZR00ZXHuIH9yEkA/iemYsvSoBwgFu2AfVooD8Qz9pR017Ym3vERm3sqyg7ZkYlRsEdskfF0nqXTJZKh1kcain68y+WekgXVz/23RrfO5m7/5Qtv+3d4puCjKdQ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nKHsxWsoK0lnmkfytgfpihvQurqU3dukBFi9QGrwNqo=; b=gAE+07Dy2yY2IUOk8m4b0bsVawtQbmWjLRvE0SqH4V5/cWZZB2+q3Ss36CQG7HyDnk7A7VA4tlZWw6Xm0GhtqO0Hj4330LMeiRlOS9d7RfMtVicEvxgGdkorUcL3di2VjWFqZ20IrxDe45tZFgJ3H9T6d5nRMJmcWADqHrxwyS+Ftgh5EZEQe2Sy2FNyChT//p2il/pGAHjHoCzXr2iSEANrEUMKiKPrb3UTUhkF++AdFvX+2SIQEidq2EFBpIBAn8ROGuvLn3W4avt+h7KTqoKyNwuSApZKK0atJMFxHwKOdE14UlZRBQkZbYKDmPSwUYQFypgr2Eew2DrsFoz/mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nKHsxWsoK0lnmkfytgfpihvQurqU3dukBFi9QGrwNqo=; b=lxZuN/BUHsSSi1WO31KwyJFtFRH02EMg3KZ9UKTR4d7i2AoBXnSiyb2WLhbXYHDxGaqkME+h4YQYER+6aQiGUYoWyR7cGcdpCCtnSWF7aoSlwxBm/IecvigT3iFM//AnOnvpa0iwFV61RLpRrH5b+kYoGTG4+rLhsB/WnWed7/G4d/ngfjxTs5NbjXMbIgqX4LN6eO4GBeWOPCSEvC5uXE4KyaMYp6Yg58oslPEahTFUx9k2EVOqzoEoRkOdM4DvzRYc9ylB/AkOGN2yHxbwMazybWVcT5WM+2pN+1BTlIqG1PfeURmZvoEWcPgYVIoW7U4GGHJOid7p32nOXHR8gQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 16:18:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org, Thomas Gleixner , Simon Gaiser References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> <298af911-f4f0-165d-c493-90407d649945@citrix.com> From: Jan Beulich In-Reply-To: <298af911-f4f0-165d-c493-90407d649945@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8841:EE_ X-MS-Office365-Filtering-Correlation-Id: f728a14e-3ca1-4311-cb3e-08db97512ba1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1ovWE/vGWYk0MNIdwrYhwpTguI1hjzzodLQKvOHrZDye10v9+d3GnlLayuid8YER9UkAgP1uLw9B5FuYDtcaguyaKhFfrv4VFrCE3Uzg3xT1lpb9VZUc1PSC6W27I4JNRHcVAb+4ZQVPp00iSZOgAinGZ3D5eDDbJAlB0flYMqwpWLHSljNXx9Si98rJphsAfOUSzN4uXuP0ZcNjpRiGobI2MwbAVNbQ3qdPRmfR1vrZ5PHQmFFaxKGZ9Np6OwPv1EwwYaVSXOJZspN275gjjdIqToKM+IabZVnltaYo3h1dy3KIvxoPsFDVbv88ERdSr2j0sqO7huMKjcX8mExQbKQUJ906uF8ZaO6mfvM7yp4p/U2iQ46LgJdD1gjVUlvaIHMxWCoKDAGGqoG8xi+A8su8lqIn9gT77+m6cwiMXuxW9g3DAJ2/HnPgfML+B7LsZLBmU9FWdptVYG8NeKuXN/MTD/610c0P7t2JXOG/RTzGcQQBwzSr02CdbShQRCEeWE2G4krsXspD/JliF/mEMDy3nBeCI/I61B/1qX9tKwBvbHwFvzzQlCukx22uUzWOfPPo2FYz8MFZ2muivXcCBG3TGjpXhnpv2t/JLN9STNOYpPcrm2Y/uh/na3jOHS7s1sgD8yt8Y+JVzS17MAm60Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(136003)(346002)(186006)(1800799003)(451199021)(2616005)(478600001)(31686004)(83380400001)(6486002)(6512007)(53546011)(26005)(6506007)(41300700001)(66946007)(66556008)(66476007)(8936002)(8676002)(316002)(31696002)(4326008)(2906002)(6916009)(36756003)(54906003)(38100700002)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGdnYWNaMzdybmUxZHVpM3FWaG5pd0hGSHN0NjBrc05laDdpbm51R1EwRk1W?= =?utf-8?B?S0JLZCtVdEp4b1JjV0JleHFHSndEcTZrRjN4cVV3UE93N3BpcG5vN2NlRFY2?= =?utf-8?B?Q1ErRHZDL0hibUlSdUpUTHovelN1V3JUOWJRUGhyMVIrNWk5Uzh1eUoydkZ1?= =?utf-8?B?OXpWV2s4ZExmZmgySEpFdFBFTCtGZFVablRjUHVubFdvcGx0OE5TTk5BR3dh?= =?utf-8?B?em5YOG02dXpaVXpMdStoZlErdTZZMURxQ04vdzRRa1R6VDJ3aTZqaWlMWHVL?= =?utf-8?B?SldURmhTV1JMeEtrMjZKcjh6UnV0MEdkaUUyeHk2UDNsMDRqdFVoZEZXcG1O?= =?utf-8?B?UDFVYWFSa3Z2aU9FTVJ1OXZvbXovUmxJTzJZSEpra1RHL1o0MXhxRy80bE1l?= =?utf-8?B?R3U1Q3dKWTNBU3AwcWNyYjlMUjVCQWw4UHdKem84YWE4dDBzNmxWWmNIWWQ4?= =?utf-8?B?TTFYYnkrRnl0TlNIamNpRjJCWkIrSTRHalNMcXpJK01LdkFMWVNHUzR1emZP?= =?utf-8?B?a05EUE1KRGZoTGZEMHNGQXVXU2VRMnpEKy9iVGZpZzFZU0JCQkxvVmc3cytl?= =?utf-8?B?T2JIOHJZUTR3R3FYVkE0dURCczJMeW8zRUJGaGZRVmJRL1MrYzhuS3FacnRV?= =?utf-8?B?K2ZlaGgvTHhBUGlkN0pSVmFiZGExNUp6bDRncldadkRQcGpqUFQzWXF4UFVv?= =?utf-8?B?STJRQTk2dUl2eFJrUnlWcFVYVkxKckdYS2JjeFJUbk83NCtDeXpvV0gzZytx?= =?utf-8?B?VDZvVzJ4c2FWV0pOeThzM1FreEtGdUVZenBGVHdTM2R5ZXdkSllVdW8rK3ds?= =?utf-8?B?bGphM1IrOStlYmRGSDFJdldkYlJNallqTTNxcXRVVzNCeEdtbFdJR214Ulo3?= =?utf-8?B?dFc5dHNCNEhaN2p3QnVGSEJFSHZwdUE1ajFWdjJrcWt6Z0NoZDNxdDgxckJN?= =?utf-8?B?Q0EwdC9lb1VSQmJOajJaMHFPcEEvazVKR3B1ZkVsWkhzemZvVVFVbnJXTWpq?= =?utf-8?B?KzBOclFxcU1uNW1kMEt1bHd3MGNtMC9XaEFHMEYvaTdPWUU1TkRvdGxNdm5z?= =?utf-8?B?eU1WSnZhY0FkVkh2MTUyUUtlTkFCVGJScE5JSC9yaEhBd2JUZ1JzT1VBT0hS?= =?utf-8?B?aXIvVTRiRy9JbzQ5Mmh6TUd3V0lURXdrUnNwd3BwQitoNmpKYVkwYWlQWiti?= =?utf-8?B?YnJTRHVKUFBSY3NYKzZhN0Z5WXNQOFFVUXhvazZ3cDRNTE5TUGxjV0lqd2Vr?= =?utf-8?B?S25sN1k5Z1paQmloRE02UXJGa3N0ZVN6UFJ1dlZHK0UwTG1aZTBneHd1UmFE?= =?utf-8?B?dXoxZTh3WGZxbUQ2VWNuQmZEVHZ0YXU2RTN2MG5ORHpqYUpMeGh4OTBuajBV?= =?utf-8?B?dldiQ0UxNzFiZG52ZWxlQUxVK0RHZkZVVXAyL2tyUTdVdnUzdlpOOUs1RWRG?= =?utf-8?B?UWlYQkNUYmlvdlFCczZpckZabXdsdEtFUUZEWWlMNTVEUUpnN0RxMy9WZzAr?= =?utf-8?B?QmtYMHFtWExCa0xxQ0V0Mmx5MFRRME0wK3pKcXV5M05nR3FUVHpxZzVSYklX?= =?utf-8?B?S0ZZUmNYaVF3UWprTnBFN2J2U1JLMzZpclloTWtDZEl5T2hybmpuUStQbW9D?= =?utf-8?B?SnQ4eFMvWkg4R3VxTkNLcHF4OVlOL3BDN1hyRGpscGdocHdVaHdlK3FJdjUw?= =?utf-8?B?enBWYnV0c2ZMWVNGbEtWR0gwdlhDL0xGZXdpaE5pOURuVUVEeW9xYms3djZ4?= =?utf-8?B?alNiSDRuRW1WcjFhdnltU0tpVUJDLzNJRXgvYllXd1RVNTFsanRHa3JDMkxI?= =?utf-8?B?dkVaeFpQdmFQNUZLbC9LNWE1Y1FMNnE3MmppZjd5NWZpblB6Tm5PVGI3cmt0?= =?utf-8?B?NnFzZ1ZZSXFWQ3oxWmt3dEhDTzFYNm5PcEVvM3JqekVNS0lsYVBJdVF6dVl6?= =?utf-8?B?Z3JpK1NudWxZRXJhaGl6K2NMMmRYQm03QmhRQTRlK0RrNDRYMmpwbFFqV3pC?= =?utf-8?B?LzgzUDRzRE5DM1ozN0g4UXRFUHlQRDBYVmdhcXhjU1JrN2diQnAxanJ2bGZK?= =?utf-8?B?bkh3aEt6d1VsTWZrcTRhQlBFWUlYZzJCMHNReGRUSEc4WjJ1Z0FGNnQ3RlJP?= =?utf-8?Q?dbDrX5GgCh/tKPnGCu4shyoUW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f728a14e-3ca1-4311-cb3e-08db97512ba1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:18:28.4434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2eYkbPeSmfh7n/NtWSeQDvEYkgYmiAOlDKDSBJ/tOSXxcWmnlNjuVnw7UBCp0gyeyw7hYKg6RRX1G4nux4SX8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8841 On 07.08.2023 16:04, Andrew Cooper wrote: > On 07/08/2023 2:17 pm, Jan Beulich wrote: >> On 07.08.2023 14:55, Simon Gaiser wrote: >>> Jan Beulich: >>>> On 07.08.2023 11:38, Simon Gaiser wrote: >>>>> It seems some firmwares put dummy entries in the ACPI MADT table for non >>>>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >>>>> 0xff. Linux already has code to handle those cases both in >>>>> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >>>>> same check to Xen. >>>> I'm afraid it doesn't become clear to me what problem you're trying to >>>> solve. >>> I want Xen to not think there are possible CPUs that actually never can >>> be there. >> Did you try using "maxcpus=" on the command line? If that doesn't work >> well enough (perhaps because of causing undesirable log messages), maybe >> we need some way to say "no CPU hotplug" on the command line. > > The ACPI tables are broken, and Xen's parsing of them is wrong. > > And irrespective - it's unreasonable to have users work around bugs in > Xen by adding more command line. Well, considering how rare CPU hotplug appears to be, such a new option could default to "no hotplug". >>> Without ignoring those dummy entries Xen thinks my NUC has 2 sockets and >>> that there are 8 logical CPUs that are currently disabled but could be >>> hotplugged. >> Yet it's exactly this which ACPI is telling us here (with some vagueness, >> which isn't easy to get around; see below). >> >>> I'm moderately sure that soldering in another CPU is not supported, even >>> less so at runtime ;] >> On your system. What about others, which are hotplug-capable? > > It is required that all APIC ID are stated *ahead of time*. Would you mind pointing me at where this is stated? Aiui MADT entries can be modified dynamically (we do so ourselves in the DSDT we supply HVM guests with), and as I further understand this may be required also for the APIC ID fields because firmware may not know how APIC IDs are to be arranged for a new socket before being populated (by perhaps a not entirely identical CPU, and this may not even need to be mixed steppings). Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:22:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:22:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578530.906066 (Exim 4.92) (envelope-from ) id 1qT17Z-0004Ys-Qy; Mon, 07 Aug 2023 14:22:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578530.906066; Mon, 07 Aug 2023 14:22:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT17Z-0004Yl-OJ; Mon, 07 Aug 2023 14:22:09 +0000 Received: by outflank-mailman (input) for mailman id 578530; Mon, 07 Aug 2023 14:22:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT17Y-0004Yf-Mg for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:22:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7d00::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c96dad11-352d-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:22:06 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:22:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:22:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c96dad11-352d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hpu/oM2MO/1mHgGLIPOWBzCu4gweLIUCR16di918gmvcXX7N+PbHUmJO8arxfyTEk/cbRcqY3aop+akUFr02aI0XPYnhgDhyw5L2SMWAFXLV8UKOtmxfrIhIDhHVWyrHgDX/c401JH6W3w/DzD/HyKZpRBb5PZcCnpaprLo4riZq7/WgKU1pTeLXfGkgHqY+WYKlPJsKlSY+T0n4/XTi+sfOX+bjDQavGIwPo8HjF600r6tFZ/6mx82Y7iUakgXNZEI4dpmRnGVeKl/JRxF4J9q/PIrV8LKOYJBd0ceZ0Yp7u1uAeTd0WowDqVs+3xWxDVwjhpM2y/ADJgiJv5dl7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g03/+5n82cWsivO2bzntOum8YMFLFr1mwYPXGPWHrtw=; b=TKyzGmYKQMxcUU9/+15CrYnVwMymwct4VscKPgprepKLq65E/laK7B9XId8uaGkoEW6C66tuiIzQNJFL6HgONP7rusVwJIvo8ahbGyKDs25+b9WaW8+9CDDtWVpqw6rMZ9x6b2ixQMrL+xzsTPj2GCii4p05BdUd+SFlZ7hHnQ4Dv8yMVdsgpLymUQVwa7rS1AC0YktC5/o592LsG/V56H3567sCs1t0ifmhO5e0hs7kxLjl9C/0wew6vKQF0nrYDjKbJN91AhCsLx0bkwljifHCl3GqJeZvqs4ViGF4jt8LIlOqqvy/81jPvWbVt4GMNm6tFB8Xyp4KlXi2HuKArw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g03/+5n82cWsivO2bzntOum8YMFLFr1mwYPXGPWHrtw=; b=UiAQ+rQTiv3G/5CznajYmQqUEApC2oZ2+rPWAF276iHkD0MYWVxWZ7rWwrP3ayxYuSQqg1AejAFHaEsq19SyyIIfIMSI8AbIcLHC8iOuJDQclsixqADbHbTsGjcbQzaK6QoCPb66xIBI0utU3Ll+2us8yalUENdp84TzUfwE37YJ0kRE4tbaGYr1OF/6aMwNYcvdx6h589WENNOHfSerJFK13DTVIXFQqks3TYTXqKsRo2HiEWhKAftI2BD3wpztHPN9vd+WHtCpbl72ae6MKCKZdfvK3WcS0fkzlsC8uWdjp+NN5ZmbmK+IUHnW4wCeATLqQ2tL0OPgq24yT/tXaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <264a97c5-d25f-1c2c-9336-4b5744331a6c@suse.com> Date: Mon, 7 Aug 2023 16:22:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 01/13] AMD/IOMMU: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , Stefano Stabellini References: <2af1f76d2c002dd9f0b01eebf7af516d86bfe91e.1691053438.git.simone.ballarin@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8824:EE_ X-MS-Office365-Filtering-Correlation-Id: b3d91cde-94f7-41ae-4e46-08db9751ac26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ky7FnBrGhLbxj2kVRsPB4xKJ28vE3w1tXhKR9HPNP9WaG8ZDaNCbaswQra0flaaXmAGpkuZOqT1eoVfJrW/Xllkd3tLZGPNppuFey/Kw2DFSbnm7zkr1/BwsZeFTD7Sq2aN7nL1KZyP9S7c6NwGlyHlCJu/UCSbGXpARA1No4bIPSKYYUibFKpoVNWDyUDjsB5pEwYWSJk+NqeA4wBuqhTq4pzyIkkdOT17HhGRuY95l8fB4ZygxaVWQKvnYczlYMOfeWlsyFpyDwB3+G8pR1HBxvOCQhmhMB9RY6h0g0hOFtSvtKSrkUG2Bh8iXZ9tkHez41S2rYoMOSqlqK035OSAgqMEo5QdRVp6THY+72cEMBPebxng1oZ96qzy0yo/I8WrfH3mzE2LyUaXHLk70bnzMalRpmaF1YSkH15XmNJIeVTEpQ/95PjhJlIGnagm5JXX85crR3bBX+Dmrb5blU1htwBKEvUvXTtmoxkIxXlDB+d8jYwc/i0JdlzofYZhH75WJtRbJ6fzeAivxhdg+X8T2fPmhrWbloAeyVSCgJCmQv7RxrYHrPL6Euxy+07wPHublauaCexoV0asnJVFIAi2RHU9c90EJclIRBm/eRW3IXzwPZ5Ght9UDgP+ucHRvaaBpQtV8n9TNWSaPBhjdZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(6916009)(86362001)(478600001)(54906003)(38100700002)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(4744005)(2906002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a01IaU84Y3lNRHcwTjBvMjBmeks3cGtmb1I5OTNkbkI2U1FhbGZKaEh4WjIr?= =?utf-8?B?QkMxenVNdkRiTXkzdTlkZXZzejJ6aXVxMytvc25KZi9HRERiY0RFcSt1THhy?= =?utf-8?B?QVdiM0NJb2gyejMvREtVMGlnNll2WkdhK000SmgrRkZNOTM4YlB5TFNqMDN0?= =?utf-8?B?Vm9hOExCbzU2NVU4UDRpUWVMTElRZ04raE1YbVloZCt6UUtoalhxYWViOXFP?= =?utf-8?B?NzZVZk0vZFRVTC9wUVZXdDFZdFpKZnpSb0lnT1R0Mk5yWlZiUkdDVmExV0cz?= =?utf-8?B?eEc5ZVE4TWVKM0I0enN0d0x3UUhyMUJ3MEtHcXF1YlErcFJtMjJaY2ozSXRD?= =?utf-8?B?M1dZUGEyTFJCUnF4SUl0RjJmRGZmekxKTVpOamNoSERLNEJSbG5kOG1DdmxT?= =?utf-8?B?Y3FTNHpKT2NlRmRRWUFNYVRvamNuaVVvTGJodVlqcVRRcXdtU0hzQUZKQUJs?= =?utf-8?B?SGhIU0tTTmZRcExLN01SY1dyZFFpS2ZqK3dpSmNXNzZHL3pDS3l4djJOSmFM?= =?utf-8?B?ai93RDQ4aXhBL0pON09XWHhkTFJ6QnRyQlVkcDEvSUtrV2JvK3JrcEZsblRP?= =?utf-8?B?T1BRMm9PV201Mk1Yc0JPTWdMaWFJYmp2RS9FL0RjU21Pb2w4RlpYMlRIeHhn?= =?utf-8?B?ME9WS1hZK2JNTEw1bmVBNW5iUHlqSWxrU0c3Z2s2SHJLcUlWU29jdEd4OUF0?= =?utf-8?B?YksvcnZoSjlQblVBSUJWY2tmdng5Zk1mMThaZ0JOTkg1YmRXTU42T3JRY3lp?= =?utf-8?B?YVZpN3ovYWp1TFJlb252ZkY5Y0swZ083bmxsOGh6M3RYTTZ6NnhLaVJQMndC?= =?utf-8?B?blNWeUN6bTZwTlYzTkI2TTlBK25FV1NXRlBsWGJQNENvNE1naVgvYlJSbFM1?= =?utf-8?B?R3BlcDQyTnpHM1ZmalErMHNGc2Y4WmhPYU51K0Y4MElxelV6ZmdFQVBGZzJq?= =?utf-8?B?Y3FIQTUydXBUQ1IzeUZnUDVocVJLMUlkQThwakZ0c2hsQklWV1BRUUtTWHhX?= =?utf-8?B?MlZLWUVTYjNidUExdXgzeEJjZGQ5dGllWmVqRG1qWXlROGg1Q2N2ZGNDd0Ju?= =?utf-8?B?OHRnaFJzclJFR1RDV2txRDhkKzVLS1p3T2hJdGdMbzB3dHJnOHVUWFdFYS8w?= =?utf-8?B?NG9HQTgwWHFCV1Z3TjdPSTUwQzRDOWE5WW80UlJYT2F6WUx6aTdvR0swME5L?= =?utf-8?B?Smk0dW5WSkJEZUZaVCtNajBTc1ZSaEpvWm81OW9xQlBOZDdVOFBiMkNsSXMz?= =?utf-8?B?aG9xNXhjaVdRWkhwYWhWUXE1QTN2U1NWMGdTME1GVWxidEllR216QjJZRkp3?= =?utf-8?B?cE5TeU9RZ1M0ZmdvUFVYOGxscUloUlFzQjJkNldKcTlnY2JNeFFkdVRhRWhV?= =?utf-8?B?aTZNUkV2VE1sU1BuRG9qQ3FJZHdPbVA0ZksrTnFoc01UWU1MRGFPdmdna3Ix?= =?utf-8?B?Z1pNVHdla2ZoVFV2aEh4MWZTYnc2M1JaYlZFZ3hxQUdkMW5nTm9SazBIRU5Q?= =?utf-8?B?MGxTU0VaMjFYWGFXVUd0OE1zRUpBUkxMTEw0cU1kUXRENENOVGtGcDhkWUFV?= =?utf-8?B?UUNNUU5hOGgxUEhqeVhNS0tOdFJQMVEvSEtaVXJ4cWdKRk9yYUVXcGpDbVJ4?= =?utf-8?B?clpLaDRMbmNUckRtbHRoK1V4Mm1CSXlwQXBvbEVWNytQTlVCYU9MZHR1aUVI?= =?utf-8?B?bmdUZUhjd0FnOVl6UW1VNGZmUlVxZ2w3ZXluZ3V0ZTFSUHJSVU5uUk03ZGJ0?= =?utf-8?B?cTg3MENvMm1QMjF5QnRwSG9EaWJ6dHovdWw2c3h1TlVQcmVwc3JsYU5xS3hV?= =?utf-8?B?cENIaFd6QWN3dzBnQlVTYTE4OFIvYW1lejZyTHJrL3VtOEJrVWUwTkZOcEFt?= =?utf-8?B?L3phV0xyYlRCZ3c0V24vYVJEUXVHRDRIemx5Vm1TMG9IclNMZW1QemhtSjNC?= =?utf-8?B?ZmM3ZDRHd0NYNkVvZGFvQWtRSkYzbEsybkNXd0tFbzlqMUhzRWRBUVFEbEI0?= =?utf-8?B?bmMxeFc2NEx2dUpPbkJJSmpEY1ZXTFhYV2dlamg5SEp6TmZNNVdpaG4vSUdE?= =?utf-8?B?ejRiT01UWjNOcHhkaVhScmlGKzJpT0dUZmtXbnZwUHNiL0VtWVQ3RzU4SFl4?= =?utf-8?Q?oIktEcz5VV4d1yo1ELNxH2cqL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3d91cde-94f7-41ae-4e46-08db9751ac26 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:22:04.1094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MkBHoeVN/1ZbVNB7lxSZWNKSDyu+eyKi033GWIrZkxVCMBJlt09VWFNqEgE+JF+Zv5+lchRJtjJbKtBZKbXobQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824 On 04.08.2023 02:40, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >> >> The changes in this patch are mechanical. >> >> Signed-off-by: Gianluca Luparini >> Signed-off-by: Simone Ballarin > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:22:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578534.906075 (Exim 4.92) (envelope-from ) id 1qT183-000542-4i; Mon, 07 Aug 2023 14:22:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578534.906075; Mon, 07 Aug 2023 14:22:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT183-00053v-27; Mon, 07 Aug 2023 14:22:39 +0000 Received: by outflank-mailman (input) for mailman id 578534; Mon, 07 Aug 2023 14:22:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT182-00053Z-BY for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:22:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7d00::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dbdc0ec9-352d-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:22:37 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:22:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:22:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbdc0ec9-352d-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HZ8Y8H45FO3xMAqoBAQ1XNha897aK/O0xvXejXdarK18NrmsCk40/+pLi8dEOlLYrx3aWsGIdIdQ3pDUEzVscaIyp63vMGljMnidyDTPQKjW+r2GgrcIu91H8LX6H7U5n5iVHA5ARGWREbhUdHB/Gu2bj0gNHU9HvFLaWphWXUE9axR7sgqwk9ge23G4Q4H4RO+zFetfkmoipk8skYsH6SP1y+qOdHZy1Az/kp8ukvXu7V8b7dzZNbvYQxaF+J8JPB4N4iWbdWMlr6+Pqb94S26KAhlOVLj/TOkac5Du75El+elJx67hFk3QJZtWlO1yQx2eYBEg3yXiwu14jpgxng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDlRfR4t0qica/Jj6xFprBqfVxFTz9UTLu70O+sA72M=; b=CCubH/tCxwy/+guABVb1Xq3l/hV7RV8s8g6rWQ4roMccyMkZMqh77dnU7BwJ7oEDIzSToXpqZFsTQ89w/M/pbJVeJLU4EZrww1LBdfG/AcprKGsrtFaI0IjCEsW3DTnGZCfR9nhZkNbFouQtnDWE1/cmPTf+vqz/BVK6OGKlXuA5BkkxnPD3bhan+Z34GjECapL2iYm11dqKAjKNbyS/kUUQ3J3TvpB5ds8fET6Xa6ffjpRsA6XviAnwJ6xWM8D0Aa341SI1YLOeE2tATv8RqZQHX+B/JLSvXuKVkBmyXUxgrJsw7MuHVwvw2ty5chOzExxrMIEngVnUixVzUAn8WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDlRfR4t0qica/Jj6xFprBqfVxFTz9UTLu70O+sA72M=; b=a3emV82FGh2NiIyXTd+h0+PuTN3Fea6/w37FbulLjtjVnsL/ti+vLRCjUSyJMpIC01sE7VdbQPPxNNMup0Fzy/wqQfW+hSuZoS2OtYtBS2P6koSk7r3vsxp6Io5G8KGdEgD1s+KVBAi3RxUN3kBLjZhPcUH73plqnySfPpMUwx9pMUqA7HYk19eWILIg5lAVC+fLcxGU2vzhGWAyPlD7SkIni6ne9BvFarhnmWuu1z84t+UAxXqPQyWotOYAT+iL4Jud/psoxScKRpbGRzCGMMznBjhlgtLwRZOpOTKW6xOH2HC7USjh03imcE+6zOKGhlVD8K4VLrf32dwKeVIDQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f93413a-4752-c053-863e-43552f92b28c@suse.com> Date: Mon, 7 Aug 2023 16:22:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 02/13] x86/svm: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini References: <2779c3b2cbe27d95274a4ab44f6b9c877e59e8bc.1691053438.git.simone.ballarin@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8824:EE_ X-MS-Office365-Filtering-Correlation-Id: 43ebd6dd-8b30-45e4-9e87-08db9751bf1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5E8E1oQcLnHWl4+okfbhYEb8POVcmlgMWlfU4XaVHgVaetN7StZZGsYujdmL6+bv/EDJzwh5K08LmCdt9dqVFZzrhz874unC5808e6UNNIUnA7WwsTjsfu3Sp631ys9HqvUQzpxT819u+Kyz7URPzU2HALphcQPIvyP/G1c4CExqch5ooNkL8/+hiftJ+eLx6Oq5IiRKQSKfXKUKYtjkPRJLRyeDaqbnIBsk8lNrfmMN4a3EI9wYxehWSxskIiNXs/SE7RYYJddVda8BykkqnW+75PWoPenznJ9oVCpKv4v+2tENSWW/Ow81wIRncmzhEvuxTTBW7a2zq9rRPqZKYF3hVj1oEprLrEMjN9WHXRR+zOSJvFpAWoBLJrZNTU3JqIHE2MlkzQ+WqFzBdWD8O1/fPswdsTy8aVp24fAhlhj+x9pXdTQAUztuMmCB6Ze2nzWmKy3JDiOtfEabVJYyyXPjSI6jvxEXv5BGAD6BEtMvRXIKJYpVFcw6ZmYhH9/y47WeYwA1iua6mrzTnQ5rPl8UNFHXs/9D6yTR4TrW9qxk98YC7lgWm0rrnRx2rXMK0oRsvlLYOLzQfCEH4ervCn1NNvQhSO2qAw+DthKZiUg1IFmmrInQ/L92a+EgHZAn5sKRBSdwSuGkWc2lb9pUFg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(6916009)(86362001)(478600001)(54906003)(38100700002)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(4744005)(2906002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUJOUk5Za3RRN3hoWUs0Q3ZCd0pXcHRMditSbTdpd1d1bXZFaEw0WmVXRHFo?= =?utf-8?B?dUszRm5XSXhRZDVucFc3SDh6Y3JZTHlrT2I5TFRrb2h0ci9rR3BLMm1mY1Za?= =?utf-8?B?QlJKZTVaOUFZTThPT2t0blNIbWxNeEprSlpXTnRXamUxYXFRK1l3WlVUU2N0?= =?utf-8?B?bktoellDT282ZVE3MmFrb1oyZjhEeGlGdE9JT1k2c0R6RjZLS21McnduUHdY?= =?utf-8?B?K3VOY0NNS0dQUFVUUmlYWmYyOG80MU1LS0xDdTJNUWtkcE9yVnpxRzYwVGMw?= =?utf-8?B?YnZXMTZQaWxHdHp2VnBkcnhROWY0RHh2dVFwQW9aVmgyQmpEQjJJeFpNOWlx?= =?utf-8?B?NWlqTlR0N2l1QTJkV05QRC8ydEVubHEvV01zTlMvOTJUMDZxMjBHcUUveWxn?= =?utf-8?B?bitnNzN0RVBPRXk4VWFIbWVEdUFtVEVyYjFQdzZ5dnVlbmxTQXhuTE5uZ0h4?= =?utf-8?B?TmNYRG1sWVAzNUVkeWt5dFJ6OTZOaVFsb1l5MjJ1Ny9jY0lyOHJlaVFORDY2?= =?utf-8?B?TTE2VkNzSlBSNmFvekRodHdyZk1FMnZwSEFndThKRnR4R1h5TGtuWXNIdnRq?= =?utf-8?B?U0R0bTg2dXVhNkdDeFpOR2hsNGtFWkdGUFY0a1luUVFOYXpPVFJXRVNIdDcy?= =?utf-8?B?UGg0RWhkM2JlTHZsK21BOHBmZEU3U2ZUSXlXeTZWNCtmeW8yS2VoK0VTb0tt?= =?utf-8?B?TEtQd25ZUXh6Sk45UW9jZ1B5RmpHSk9wVkdQaWJNRWZldXdqcGQvbVFVWEVK?= =?utf-8?B?c2VrWi91c3FMRVFLbXNTNGNmbmhEM0gvMU1KUzJWdE1iQWp5L2JRTHh0REdB?= =?utf-8?B?RmU2UFp3OTdkVWlHaElrV3ZZVkhtcURMZndMMWorMkNXSUpVNnNGZWtIMXBm?= =?utf-8?B?Z0tpVFNyZW1SNzR6d083S0FUQTBqdUZleHVRY0ZDdlBLNEFuZFd6ZXV2dzJU?= =?utf-8?B?L010dnFpTnQ5aThrNHdrdGw3bnFvZ1JhL29SN09ZV1JEYkxMNVZJbHlXWGth?= =?utf-8?B?UkhYYmU1MEtpeXRINmMyVDRwL0tZQzlIVENyV1pTOERkd2VvTVBrek8wUzEy?= =?utf-8?B?VTR4MlRnWXJZWGJNNG1US1Zqdmo3VEpOeld3UHpJaUFZM2RVMHBOMzFrV3JS?= =?utf-8?B?WmZqempVNll5V1dIeTArcFFkOUFsMU5Pa2RIUEJ6d2JaVVNSMFNnN3R1L2tw?= =?utf-8?B?cW16WVFCcnhkd1ZCcE9ZY0ZtVUlIa2lyMytDdGMzeGVVNnZ2cXR1ZlJsbng2?= =?utf-8?B?MXVlTmlCQXRmdEt1Z2JHYmVlcXVtZzkzdVN2bDNlQVpuQTV5azFkQitpV2ZM?= =?utf-8?B?WTN1L1BNYlpLKzNMRVNzbVRSQmtDRTd6bzdrVUc5L3E3VXFwQW9mZUJjdWZK?= =?utf-8?B?WGpsOCtUdFd2ajdQVEw1Q3ZDL3Z1T08yTzEzY3ZXckRuUnNURjhVU3VQMDBU?= =?utf-8?B?Z2liVVBoZmllVXlMZ2pqMlVkYWJrdGFyZEZybDkyQU1FNXVMWE5rTzJjcm9J?= =?utf-8?B?cU1xY3NHZ2hXVTUzeGZlSE9mUVVQYk56M1YzMjZBK0Q5ZGFqWTJOMXJJNEFn?= =?utf-8?B?bTc2NzRuekhZR0V6RkhDSFNDbnZZL3RENFF6NUxicExDOGZOTHNWNjFmZzh5?= =?utf-8?B?Y1g1Ti9FQzZlRmJZb0tlMlRnOUxIVzd5a0kxUmZocUZtQlJENTlITkJuTEhv?= =?utf-8?B?ZXhuRnZJWTFINktxdFJHUDlqYXlWaEorUHFhdmREWUJ5UHY0Z1kwY09yb3M5?= =?utf-8?B?VlMwbTdMR2F6WWJlOTEwdVVOb0xUZnYraTRtS3ZxWjkwZHMwZUFFTis1bVlB?= =?utf-8?B?TFhZdVdNQlViS0g0c3lXM3k3ZThTb3ZZODBLemRZUnVhVlYxMldrS0FMdW5s?= =?utf-8?B?bVFITGRhRkQ4dDVhazF6MVBIVG5TTEJEUmlIZmxGQkZKWGJuQWl2VllRNWkz?= =?utf-8?B?c0E2K1FqbHJHUVUxK29Mbk1RbFRwcEw3d004SlJac0pORDVvWUNVS2d2Smdv?= =?utf-8?B?cm43YXMyQ2xDajYwOTZDRnhYZHJCMXhJTzY1WUFiVVFOTWh1KzBUYXNZV3R5?= =?utf-8?B?OE9uM0lXRVg1cmJhY1pZOHdiM3JhNSt5REIyeWR2d0FvUjdJZmJWdU1LTFB5?= =?utf-8?Q?jJTWjV9lMmANkjSQpfINAW/yM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43ebd6dd-8b30-45e4-9e87-08db9751bf1b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:22:35.8805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pAu/LLAiqmfiHBCz4v4Waf1Nl0s6ApOnTXe5OBK7yVT9LMrT+OnOCzQgLPXZfx1JPpo6ba5FT9jnRtvTrG7+9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824 On 04.08.2023 02:42, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >> >> The changes in this patch are mechanical. >> >> Signed-off-by: Gianluca Luparini >> Signed-off-by: Simone Ballarin > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:23:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:23:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578540.906086 (Exim 4.92) (envelope-from ) id 1qT18t-0005dA-EZ; Mon, 07 Aug 2023 14:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578540.906086; Mon, 07 Aug 2023 14:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT18t-0005d3-BC; Mon, 07 Aug 2023 14:23:31 +0000 Received: by outflank-mailman (input) for mailman id 578540; Mon, 07 Aug 2023 14:23:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT18s-0004Yf-FU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:23:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062a.outbound.protection.outlook.com [2a01:111:f400:fe0e::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa26334a-352d-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:23:28 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8824.eurprd04.prod.outlook.com (2603:10a6:10:2e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:23:26 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:23:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa26334a-352d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPGO/U7DCfxzGQWEvpKfdkQQPs5aXdBDA8qtX6VKEUTzjz5iihamchD0Walj6UTMm4Mp8LJ9qfYJALNoFnnXGjuXUM+ohHg7V682UHxYeI7jSsC8pMhJ8yPngjrj2g11tdNk9YZlb/tt/gqbnBbMuqWVg89hWoWCSiXOwl4jBxYRJXp0INAFr4HDySYfunk7uJeE+1sWaHz1Erof0fZaaEDWxqSg96ctKDPHMOnAW1d6V+1l1zIfxh1lFK9Q67u/k7hCiIiREHhAZt521+F3TJ4QBtXWEHanEsj9TOhx6tQ819CFzssyqBnxCGS8U10Pqgc/agCZ4eiE2LJl1SX43g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bi96kP+sbkDN6qlYvnPoiux1MtkQDCwocjDaI8mNUdE=; b=YrY2fO+DUQH+qlD0NEwnPi6NckVNHbWaJO+KTu2XAcVZYVEzWD7m7axOztxQB3pvNZmJq02wbPz1yPgH1LLN56fQ4vYfkMZrLsKhmnbyQeKYnxmcAuXc4eK35MrCBvbRg+0k1y0XRtnbKQ3WSyktl+TOBd674iznqyZu/DV7DNOWqfNjyd+avftwJZkpnvsGklPK28eKZ7kTOKvBe7yBPUozL0BjG/3sEOluFBlut1RLZ3W2D+QR840lRLkPhyBr7pEoGL8GLNHFb4xGnuJSSrCqIMQMztYFLXmNXl0XBmwADkEUgWgigDojcv5k1TQKrsWajEyMi2OzsWIXUCXUgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bi96kP+sbkDN6qlYvnPoiux1MtkQDCwocjDaI8mNUdE=; b=p/BV17e2+oWb4SlIb0m2Y1b/YHc4hFbVtUB5Nly2IjSfomJHJgvD5XPJjjkE7MC97+kgkWJACgTeOm/mZZo39wRGz+jEzSuO/vj2A8dYtlqPP5v6zSKMyqD+vkQKXzBzozSJhKRyEpanpYd57gFX2n4z9HvLnEdJXVOeOkj5ysgp3EbxtJkTM40ACDG7PbLURJrvH0SeF2C8vqj94naalrdUvEAceJqjmHWAmLK84nTOFls9v6FwjJItcNZ2S+3j3LH6eMCzjeDyOEAjD0OqMHC+7qkTvTesoyC5rWVDhYOq7BibktK+FumPsioUfZGYTTtoRsuwKr1Hu0yW+Xgf6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5d2791bc-4f84-5143-2c17-55586e424da9@suse.com> Date: Mon, 7 Aug 2023 16:23:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 04/13] x86/IOMMU: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0180.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8824:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ffa08fd-d872-4998-cb67-08db9751dd7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CcA4hgImqimBGYUSp43z3h33nVcagLvQGM/L1qTw3tMLWHf/r33I5Zj/eKv5HCIGsPgt6nA9i/bKrAka24UlCYHLtllQ4gRzsKjEkxJNR0f+PIHPPDElMeQ4H2nb9kOiQorBDsXbsOQhh7x4Zw0xmaQqKpOgJkXN+lN9TpIuaxL3DNmjaZxowSr/sbCzYARVhY+XgD0yP6DxopIFZopt6FlXyREQ4eeYhJfeK7rFfBNttTYepC74VGAmY8KbuiBr6ZyvDtjN24uOjapgvamce7xUcumuHJlpDrJBFsYDYKluTcZUXfVZ2kn1eVtPdJoDHE4DrZi9X2TGwrwsWCx1WdqP6UB9P3R2dl66yQQBWei/dHYIU7Dl2toDS/YlL3T1MxBE+B6YTLVSgh0LGEl14dd+PXc3FuShGYpvFyM9KAayAS5m1n1D34HIvKtbfCJ/lYJz/b9pjAE8aeeKaVhVhaiI/kv9OHM7V3fK+TR5KF465XjHM1n+FfPWBE8695Xg5CryqxZkuL8xUdQjz46C26e20Jx0OxVDjXO5DeeNNGoN4iujGjjTATNVOjdJS+81MkXixd+rhkDsainWur10T9bOuhywlBHNxJLh2S/5g0BsWdhYy4QxsNAOxcRiYhD+eEQuaByTAE9v7lLIqxHd+A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(136003)(346002)(39860400002)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(6916009)(86362001)(478600001)(54906003)(38100700002)(66946007)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(4744005)(2906002)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjA5cCtCV1ZYb3czaHpYbnlhbDBBVTdTOElvUDNlRWdyZTFRakIxbmd5RlFn?= =?utf-8?B?QnFod0V6WjFMNTdiNDFoMmRDRHV2SzBnWGVoT2swbHFaQmltcVlQRTB2d2tM?= =?utf-8?B?MkxUWDhPUFg0dzZmVnplNHhOTW1aK0NaWVdOUzFBZGVFc0N0MFR5YlpDM0Rx?= =?utf-8?B?Y2RzMlVsV0FnYXdOV2c1RWI1R05nY1FDOWJCbFVyRTV3cGpid1R6UjkrM0ZG?= =?utf-8?B?ekczZlVEUUdFdlNXRGsrKzFuZ1NOanJsdmxwNmhtbXgwZHhubnFrY3FYWXI0?= =?utf-8?B?ZSsxZlIwaGUraVVKTEZxSkYrb2NCckdqYmY2K0IrVnRIR3FqbGVxY2JzSmE0?= =?utf-8?B?aHNpMm1DM0pXNjJqSFB6ZmFBRE1pSHI3amhKbGZVcUNBd091bU9nS3JSNzF1?= =?utf-8?B?YnNFano3dVROam9wakI5NS9PQkkwb1BtSnpmendQZGFTQmt6RVF6RlYwZmxL?= =?utf-8?B?S2h0Zjk1UXJVWUlDOWc3V1VNbXZZNCtQOGg2OHo2ejdpcEVGWld2Mml6VGlG?= =?utf-8?B?UisrYVVoME9Zc2RMN09OZVAwZzNaWVRuZkUzTmhPLzBnSkhMaHYwOFAzbG02?= =?utf-8?B?S2ZKeXN2dXhiZEJmTWdtZGZWTmJ3TDY5MUN2UExlR0VjQkdTdGVWVnVnYldi?= =?utf-8?B?WllzbFd2VDNXUGhVb0JRTDYrOUI4ODMxeUp0VXVObFJUUkhZNUFTNzlpY3Bn?= =?utf-8?B?R1BrZDEwZStxK1YyQVdtdnkvVU5JUmg0QTczbnhRREJia1k5RDVPMk9WZmNl?= =?utf-8?B?UGozSUN3bjJWKzRXaTF5UWd4RDlhZkhiaDJ0NWFqNm4rbEpFekw5Rk5QaGVZ?= =?utf-8?B?citWMk5WRzVvVWU2dnJBL0ZxOUlsckd1ZFZjWmdIbVc5UWliVUNhd3ZQb3Ri?= =?utf-8?B?eW5NNitOckY2VTNmc0lSTXA3Zm5CQmY4d3pqcURvMk1YNVYrSXRsWXl1VzRB?= =?utf-8?B?QUExczRwVU9BejNEOW9iVnhOZmt4UVB2MmZtQlIwZ3ZmOEtudEMyYnZFQ0c4?= =?utf-8?B?MVNvR1NNYTFJWWdNaTgzOGJPdjdjVDhZSEFoUWFOQlVwb0ovK1NHRjlMcjlh?= =?utf-8?B?V2ZqZEhTU1J1ZHNjV3JyeERybytrWW5McXBIV1VTV1ZJcGdYSW5zejRiVUM4?= =?utf-8?B?eUwydGNvRHdEazdDL0s2WElqYVY4dWlzVVFUNDZja2FwWldmZ0xjWmR6YW1L?= =?utf-8?B?NU16MlRGT0lXclplWHlvTEFtZWdZb0pQNUtCWnU4VTlRV0FDNndlZmc1Y0Vw?= =?utf-8?B?eGlNaHFBMkQwcmwxSStjcllFLzJNRmZ6TUpQNXZWM0ZpcXdqcXVYMWdzVU1N?= =?utf-8?B?bkpHUXIvcHR6OHA3S3BWRENBT05jeW1rWXBoT1c0RFZsRGoxblhueGw5Q2hK?= =?utf-8?B?QnU5c0NmWXJqakRJMGlSVUdWaktZN2ZxWjlLdUFGTWFZTjlxREhYTVZsK1JH?= =?utf-8?B?Mmt0QzhuYTFkTHJzT2QySkxmNnZjbC9EV2RFa1NvMnV5WVhnZVpYeDMwM2dF?= =?utf-8?B?TkUyODgyNlNkUnErUi9aWUFFL3ZpWjh4WHRiRXdwQjRvUmttVGRacE1udnh4?= =?utf-8?B?a3dvZUIwQ1c5UEF2c3NqY0tWTDNyVFczMm1NMHU0NEo1cytWcCt4R1NLSjdF?= =?utf-8?B?QzlncVVtMjFvRWs4OHVPQnBUNHB1a2hMTWUva0kvZmdNb1BSU3JDMUM0WTE1?= =?utf-8?B?b3FaQ1VLaDZYSXE5cGJYQUs4QWNmMWFkOUlSSWlydEdVYzdFOURsT0FOU3d6?= =?utf-8?B?L2M0MVZyVFdMbHJYRy9tRittdUdUYitPblcxaE4xK2ZobVlpL1NucVVHZnV6?= =?utf-8?B?WWczOXlKYkg5bmVNTUd2RitMVWMraC8zcXRuTWpDdzhPV1BzYUprR0NzbitT?= =?utf-8?B?UjVSRVFhUDJkL0Q2L0xsdlFqcWdTTVVrUWFwSW04N0NQYmpkN0FnUnNYNXhy?= =?utf-8?B?amlndGxXMEFpZk9rUk5FRVdvSFhKNmplbXNMYnBlSkJKY0dmaUluV0o1WHpm?= =?utf-8?B?aVR2YzZMamFnQzBDbHRvTmRVODFRUnRnYnAxVmJGVHB2M0pTR0puVGYySDh5?= =?utf-8?B?NmFpZjhxM2tPS1QwZUZJMXh0STc5dWtDeGgvVytCbUZVbVM1azdHTjZjWWI5?= =?utf-8?Q?vWdFd/oYBMxzq9RRplotGAtW9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ffa08fd-d872-4998-cb67-08db9751dd7d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:23:26.8345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AzwsnWSqiFo5K/1+must17yHziER5WgxBMhma9D3TfgRkagdZ1Oq7uFlZnDSjA7ZMaXD9D5ltfDG7g2MtGIgtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8824 On 04.08.2023 02:45, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >> >> The changes in this patch are mechanical. >> >> Signed-off-by: Gianluca Luparini >> Signed-off-by: Simone Ballarin > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:24:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:24:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578546.906096 (Exim 4.92) (envelope-from ) id 1qT19q-0006GF-Qe; Mon, 07 Aug 2023 14:24:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578546.906096; Mon, 07 Aug 2023 14:24:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT19q-0006G8-Nt; Mon, 07 Aug 2023 14:24:30 +0000 Received: by outflank-mailman (input) for mailman id 578546; Mon, 07 Aug 2023 14:24:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT19p-0006Fh-F4 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:24:29 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e03de12-352e-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:24:28 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8539.eurprd04.prod.outlook.com (2603:10a6:20b:436::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:24:26 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:24:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e03de12-352e-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbyqkvswKnoDUqzWnT/sumGeFr4CVpKZL2RkGKts7lDZvY5Bp9BLkwpV8wb1O1BCNvUwDhNpYFxGlKrsGvPh8nL6FkZfLlpzfjajQHhuGSqBvZ9fYs/6QNQHs4W1cDLBsVolKO5yTStJWYavmHFrjAOw8nAuCQ8NIb51Kg3DPLpYi7sGGQrfMm3qC/VPID2e/397k1CDDA1IapvmyDB1JoJ/NPHruzZCauIOLjM61/4ce8+UeY0DXNjbmEZaLAwk9lYQJHK1DaF6X5KOKA/sy2MhsL4Xr5bRSaCKqDeXAv4crZa6bjPYKwdjDXnhTya9B+uLUrHSzQdU60LGtQrdbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8s7gRyVrlY4vsjeMo+M0/WXO6g2vfdu2H0vWGZButmw=; b=VPXkF5BtUaYZeBpqWzp7J+Lob+FOjl06bzOehhChbSKJZCna02ixHiSXz26a7MWuUgeUwVNrivxk0P/jQptiQaaYjFtk7rvaf0kHwQvXTeR8jcbMHV3kGbtLKn1wJCMTeHBaTFnLEZcm09KjvxH+bHuUSktMLKfvNsQQyzZuo9SHGeJjkVOCxveBA/fHwiCv7FTES+D5PcBoxljsWtdD0dYWQq8NXUH4qMpVGumEmf4vKGS2PS0Dv8fufLPm+657UYQdYeGffYEjgoMiPi2AgI+t7hdodETbmmtBzl8YJtiZSyCkIRXh2rRQCCe+Rdw51xLMEBv6c5z+DAAM1TbwmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8s7gRyVrlY4vsjeMo+M0/WXO6g2vfdu2H0vWGZButmw=; b=brEwTwcVDGuX+CP1bHxD8A3y1u5oIUjJDne+qrmjohENOGa0VUrS1Qz1i/84l5VgSbuIfbtGXH/sjvMCMqZFknHvHs+uU8jzeK0+a0W+gUPex2+aOYQiju6w2UK+0BjODCLny3ZpxtatFImimsrX8wW1/gGobypXbHk4U2M3QpUKN5BLjZ9qLacGEqBicmMyC/99uJYhnFWUxTHKAjf6FCIVXGbXPI8PPWixsdHzqRG2moNQLXHtW3FDTQZb6Ib03Uba2DTr5OnulL6F+zwh+zUkBnjMSnIIYTmkXnYRtHaMCkTw06jp7cimkRMeHGRTki43PRtYj+whAXhlxa+ZLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 16:24:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8539:EE_ X-MS-Office365-Filtering-Correlation-Id: c98aa827-0a1e-4bff-a85e-08db975200dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JputIuBYLa+oNtPu5fHn6K+G7AkHqjPHzdKeaLs+Q9MsQunCqtrM4VCNyrxmbZznNb9wAmWH/TZrYKy1rYa5RCo91BVfWYJ5SqZHY78LpeUieO8pjRfqsvb1jejRE9rSKVb7cd3eys5YaMqrO+V0o41KQS5c2rZEZE1nJ9qrpdx8hT+a2qwpLWiJZvCBLkaP73IbzSzoas9yaJZknqLbykbs31WFNxXZvLsARPNoC57HGSzKzrkBh7GPFO2nWStzCSwVKdAx9BSfgzc36WPPKSI1xE5drZes4i1A32U2P5IcoNZnKB1oWZ8jXD6q8PMwrE2tozkkqNGo0A22IJivYY6QPs2IEJ8ZVwpvmn66DiTF6yatQKLmIFmvyXinoLSIrLWQovebTss+I3/XxWQKC5AB2xxbfvptcD6gVOGyQi5jCqWTHu65WPynjLlsg+p2UOvaK1fapWqHgr7+LtvVfwTCBergMvQ9nVqL2FPQ+IsqipePrfpDsgu24eSgDODh667CzRqpzUpOOZupiRwV7jRTNUUzi94u9ap0pualFqXGypo9JpXQYfykY2V+aeUAp2Q1oOWRN00TlpwqY3jUUw7NzYkoAJF82vPQcNoE42/7mEUqa0NxTp6Bhfdwyls93/cfdsEsjqzKEZ2AAyq/VQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(1800799003)(186006)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(31696002)(4744005)(4326008)(2906002)(6916009)(66556008)(66476007)(41300700001)(66946007)(8676002)(316002)(8936002)(478600001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmlLMzNtYVJaUzRCS0JDTVNTZCtMN1BUZG05N3RyVVZYZVZqK1hlNUJzZmds?= =?utf-8?B?M3dHVWd2TnZ4M2Q3U1dYenFzbkJoZ05iSWM4Vk8zWCtQY0VYeld0NVdjL1JK?= =?utf-8?B?SXdWT2NvNExONDNaOWhOYUlwSGRXMEE0d0QxQ3QvTnlWdGVHbkpwUDYwV1Iz?= =?utf-8?B?UkRLTy9vT25OTWwvZS92TVVkUlloVFhCSEkzOUVuVlRJanFQa0hOQ0RidVFG?= =?utf-8?B?WmJNQXZWN0FsSVArWlU0Yy9nV0FCeDNYNDkvN3ZFQ0t0TmVzZzMwYklZZTVU?= =?utf-8?B?RmM2clp6ZGxvTDBmTEp4aWYrMXhEMFowcnpudnlFNTRtd1RVYTZGMkg0V3VK?= =?utf-8?B?R2VlaDlpc3plbWRyNTkwMktCOHFLMFE1a1M2SXhOS0IvNzJDQjhYL2E1YktN?= =?utf-8?B?cFF6c3puV2tFeUVuNnVqdlhjenU4TENKelVjZkF5Tm1tUVp4cWxCQUNhelZR?= =?utf-8?B?MDZkTGlqRmV3bUVzVlFKT0FBYUcrSW1aTkVZT2NleUFFMUlSZk9DaWhsRnI1?= =?utf-8?B?dUxDZkcvekg2ZUxyakh2RnQ5bWh1OEh6VjRlaENtUjRRVW5KWWJkYWdNNWdn?= =?utf-8?B?WEtEc3dzTTN6RnZKcnR2REJpZ2tldU5vZmYvZXF6dkltUzFmUXJrOUExaWJD?= =?utf-8?B?YkhzSjBaK2t3MTVkYVRMT2ZRRXp6TGhadFBGanhRTkdrZEVGYU5ITm00N01r?= =?utf-8?B?NTBDTlI1dUE0UWNvVlRjZFJXWmVMS0YrajgvZzdIek14SFNGUE8ydU90K3VW?= =?utf-8?B?TmZBVzdraEZodU1VRk1WdERMNVpIbWpJQ1R5eWVxcnR1VlJ1VmxJUnUrblJa?= =?utf-8?B?eUY4VTczTjF6cmVPcHRBZ3V3ZzYrRlBtR084b2tleDg2UktQVXRkU1dFOUpS?= =?utf-8?B?aTUvQTFPZGh2QThuUmpoN1RRK0FLejVoNVJOV0FoY2ZXbVJkZ0V3dDJMc08r?= =?utf-8?B?KzFmbm51OUdRTFRMQmRDRFl0NzlIUW13RnpNdXJGV1E1ZlJtVlViWWVrNzhr?= =?utf-8?B?dFpDYi9mSkFLazcxeURSVmIyYnlKUGlLNW9ZdEtEeHhDcDNtYS8wR0llRjlL?= =?utf-8?B?VlZPWmNVeDlObzgrQXZ3ekoxdHI4TEkvWE9BQmppWlQ5TzNLSkxVN3VNSFRz?= =?utf-8?B?TU9HMWQwLytnVTV5VjBWb2ppWDBnVjNBallaNCt2eU1IaGUyaGdBQWhRcUNF?= =?utf-8?B?SHhDWnp4Q0FGMHlobVBrRmIvZm0wOXc1OUVLd2Y3V1pYTzBzSGlMV2JROXFP?= =?utf-8?B?K05nZDBkSzBEdng5MUxqZHNLUkc4OHgzeVJ2d1NsclR3TUhJOTYrenRYbGlx?= =?utf-8?B?SFdrZE1POElJcXJLRUxUZzF1eG8xZnEvSUdMUUpSc2x2bXE3UkpzSHg3Y2s4?= =?utf-8?B?ZlN0dFpaRGNsbGFkRWJnWld6MUd4UDd4Q2Fra01pb1ZkQnNRV3FkQWVmekkv?= =?utf-8?B?R2V2Mm1Fc1RxOTlJWXJDMkpTd1NjU3ZtSjN0SXg2dmMzVHdybDR0QTRCMnVL?= =?utf-8?B?MFBPSGNqZ2xaQWdFVklNZ3VPQ0JQVlN1RUZRVlczL1p5NG96N0hLODBVNXEr?= =?utf-8?B?eDA1TWRveTNtZGRtTTdMcEdHWTJGdHdrR0g2Y2VzWFpnT2p3ZXJtdHNaNEMy?= =?utf-8?B?MHpnVjQ1WEVxbSszd3Q4TFRPV2ZZS2tTOTBhdlBicW90Y3M3cmVNKy9uTTk3?= =?utf-8?B?a0lnL3lKYm1MTXowRkxxSjBjUlk1cTRYSlhTdWxJNTJiNlg4NGRBU1JhWHlx?= =?utf-8?B?Tmx6WUVQejJjZ0tPVWs5NUUzam1RcC9RNWVRR01pQmd2WHIrQjBDZkgzWXJE?= =?utf-8?B?ZG1iSFVITXhpZVZhU0Z5Q3lFZ1QvNDh6dGlCT1VGeU00QkJJOUNPYy8zQWRS?= =?utf-8?B?Qzhtd0lhZVFVaDlEZmNNN3F3ajZsdHNya1k3cmRVSXFMbmVBWVFaNW9OT3Zj?= =?utf-8?B?alhYVVJCdExQZGk4azliUlg0T1hjU1hXQ0dZWnYwN1lwcVRvZnJTWUhIeC9C?= =?utf-8?B?WkYrcS90MVlJUTh5eHNnNFV1MnhjZ2poNmJkcEczWW51M0RhalpybFdHYlNq?= =?utf-8?B?enRmNVpFTnVSd3dNaXdXZVNOQ0xmZGtiZkZTTW5yaTNvaDB2aWxHZ1NSdzFF?= =?utf-8?Q?idOtWRTwsEnjeGz2cS05uP1zP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c98aa827-0a1e-4bff-a85e-08db975200dd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:24:26.2029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3abpDvEer+NFK5Bk6DqlxgR4c4AZvvhLZZY+a+ozBQTfSe5d8E7VOPqT4ciAaObZPf60AFc6BXUkytweqHNkrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8539 On 04.08.2023 02:50, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >> >> The changes in this patch are mechanical. >> >> Signed-off-by: Gianluca Luparini >> Signed-off-by: Simone Ballarin > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:25:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:25:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578553.906105 (Exim 4.92) (envelope-from ) id 1qT1BH-0006tO-4l; Mon, 07 Aug 2023 14:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578553.906105; Mon, 07 Aug 2023 14:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1BH-0006tH-27; Mon, 07 Aug 2023 14:25:59 +0000 Received: by outflank-mailman (input) for mailman id 578553; Mon, 07 Aug 2023 14:25:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1BF-0006tB-Ds for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:25:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7e1b::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51bd8641-352e-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:25:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8539.eurprd04.prod.outlook.com (2603:10a6:20b:436::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:25:54 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:25:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51bd8641-352e-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gP9+joZXbrzJgAqEuKf0Xo9g4QttSoErOds4xs8vgx5MKlDhBHaQutnZqZy7C3jXyXXdEUuclfjFqvXfLxAQMcdLpgwhEbvLrSrBOHEkHF492ytM8a1r1P3mPnyVu+QvdwwQ9CyZ1g9J7Vllyag4Y5ymJYqaYJlme7wLNti0wyfw6uaECOmsiXNFqDB5JSabFnbFd8NtJjZKEuS8DqCgGGrcXbftwwRaN6sz7WvexQHXgd2uw90lzlVWDPN3QBAAw5YxIAn12QljG80AWp+vjtrQHfUlWesGiEqqB7Gw5rcd9SFksBcLN7KoKDlK+FSKvVG33rix0bhWwgvVLKjCrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=viu3A6uCd+gRMrLoACs3r11I80PqDQpbRn+Gb84+NIk=; b=KcZH/0R69JDNO70PvFZBN2C9qSJIyK/cJlOcQffNA6tUXdOwodv0/YuGLszsvDUf8QVD101TfOqHe9T60HKsj16ryLB+Bgg1CzybZJryvFFSbqXMxJPwgMOH15XsL95+fIxkHur9V43V3TkUriBC9ffkZ0543Ut87oSqYnOTWOsSwgKefF0mMw6uOBTBFvp/P9pXz3DuIOiluvm+NMsOiNiGfZ/uBlDsOgAMz/aEREtZOQe4uIpwKJVswkFRZG5wIMq2OGMbcFjnlWgCjp/YX7tZbG56aFyYsv/otSb+D0n6+0Z7H/oEPtpxjJOvh/XEdl1XXtbgcNs8z/l9DsX3qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=viu3A6uCd+gRMrLoACs3r11I80PqDQpbRn+Gb84+NIk=; b=i/yps21496ru9TcmLWD+aDjSiPZpJ137VPAq66zVdMldkTHQx2To9mEtDD1RgZYhv8gt3xi6M1jz9GhhBLMhOZjwwes8PX/sWyRGbInb1m8da6UVAqnSLvoFzbFvkaWTa0ioGiZaqUgiy45yHKvumewkmsyUIWx7jbEaThmreXyolIjE4oBfV7/QzHBHT7VqDTUnifxEC+8e19XML/lF6V9dsBSoPPiRhDot7m8vXB62VGBGzmWlfYenAhmwWdlIHXpwRbQrjb1HkKnC+8fwGwnWaQyiwWLHDuwFmDRanHvyiNcd4MiXayodftWd8SE+zyNVhOyc45s9o/dQwpNNbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <074a567d-5c34-83d9-2832-d9161d6b6254@suse.com> Date: Mon, 7 Aug 2023 16:25:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US From: Jan Beulich To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0224.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8539:EE_ X-MS-Office365-Filtering-Correlation-Id: f9a94581-f7a9-47d5-a3fd-08db9752352d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TILx1vTVnPCZ3Twol2d598Pc6IRev+RByZllQGDOWdSC1cZDDg0jv3xmMSfnZjyGj/slBgWyTFIuzid3qtoRvI2k+M3esIWCMWNwq7/uG/dRz1vwGu9iyHjNu65iQdUmf6baGlQwaQvFcpwT5agiP0n1vtpbb3Z14F5Ko37ev7p2ZcHYEza64oD0bv6WERNYI/B1seZULXJJuYlYB6vaGmLG+oqZXEvHIQrrdEdQd8c3KAdAn4Gi5l/djME3d7AOfl2Ikzw3YesbSteG00CRCHqesq47bqbVpx1sXpqJ3U1cJxjuJOrojzOA8BfD64itLq9hCPzStFA0lWXLtGSG5sdNL/3SGiyr7yaGcenDSrah/AbTNI8ygTTBQ5tNMB/DU0dtyOf4LyLW80JoGRYdO+Vjg/6Q/gdYBJSPuau+GD/OEQQJyZ5SPmXEU/FY8244UmT73+unzjMREs6A1SXgFzXNl4Mhs05EMfdD6GVs2+shc4v8FmHw5y/OxdcID1Ho37w2KMdk0iASVYml+j1rds35UblunWcqPYkke8IeIJHiAEGx2HJqbALSqmxyLCfqXzg23SHIj9tSnd+vI/lDxrw8cOp4KhEICBusiM/B/PtI5rWtCUTJcH9JhKhxvgpngIqiqn/Mbdtd0St4oLYlZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(1800799003)(186006)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(31696002)(4744005)(4326008)(2906002)(6916009)(66556008)(66476007)(41300700001)(66946007)(8676002)(316002)(8936002)(6666004)(478600001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGFNMUlkdFVEbDdrWEVEZHNCL3orL1NzcER6MjlmN1IrNGMvSmNIWmZyekFN?= =?utf-8?B?UHhwRW9TazFrWWgvYTIwUVJGMlVGWnJGeHRZcytWdkhwRWJRamJWbzVGQWhk?= =?utf-8?B?ZU1xZ3NWS1IxL0FuZ1FlbXhwazZHajkvQUE4ZDh5NUZrTlhWN2NoSW1CV1Zs?= =?utf-8?B?YXl1TzV4aDNwTzU2RXp5dWhLWDJqL0pmN2pURDAyNEdSMkdDTndFaW5CUS9E?= =?utf-8?B?bndROWxKZnlHVnJuWXZ6N0VyRC9UWkM0V3pmd2JCYzFtUmMvTWlQcXRLSlFW?= =?utf-8?B?U0x4WUpyMHVBQis2WTJNdXZoU1hyZXc1Q3BHbUNWWjRqMGRVSmU2VnVyaWhT?= =?utf-8?B?a21RT1FHNml3MHljMmFjSnR2NjRmcUF2c0lqb0JqVjJYOFZBK3lLS2wvOGFV?= =?utf-8?B?R3AzRndlckdnUFVYdldTWEw4YUdnZjRyS3MxSEhSNmx4Um5ES2psZ2toSEpN?= =?utf-8?B?cXIzdDg2VFowMEJJYTU2Y1puOHkrOEl5NkRmMUl1cnp4dmR5TXh4cmNjWGZq?= =?utf-8?B?Q29Lb3NycFRzbmgxRys1eDFyaGNaUnY4a2FIazNucDY2Zis1OG1hTWVvUUNL?= =?utf-8?B?TENHOHVoWlFzdlEySGRkMWJ6MllGSW1NQUtqdkwvMyt1azFwclJWeHpkb3FB?= =?utf-8?B?bjlNSTEwdnhhdzJqbzZBMXRXTmFvQXo3a1lKb3VhYlJZekJxamVqaDNmZzVC?= =?utf-8?B?MmxUSFlmUlRuUnJ6Q0xmcmNjbGdQc1JGZFIxUUhYek54TVZPekwzWkRWTkpu?= =?utf-8?B?VUxSQzZXR2pxUlBSVzgyUDc2MkRhN0hkSFY1TVBzbFo1c3hMMEEyRytEbDBp?= =?utf-8?B?L2V0VEUzY2I0bFdBekdVeGw1bFI0YU15ZXVzR2x2THNmQTd6N0MyK3V2V3dn?= =?utf-8?B?SEt5SUpnRGsxUE1meTQ1YXI0RHFtb2dLc1R5bEY4cHJnb2wwWlV1QTNBNC8y?= =?utf-8?B?NjNsS1l1MS9qa2RsYVoyUE5uZFNWSzlrb09HQ2RCcGE4a2lmRGlzMWV1cEk2?= =?utf-8?B?MGJkRWN6bHQvRkx5TE13a2UzczVoTTNhemk3a09hYTN4bDJDSUpGVGdSQVMw?= =?utf-8?B?Z1kxSnhuczAxdlp6MG14RG1XVUtJcTZxckxGZkRFVzRycFVPVGdmUWd6NG9x?= =?utf-8?B?YklubDJiWVR2V1pMUmJBdGpGd1o0Nmt2UE05M3JmZm8wZ1d0L2s3NmZ2dWlT?= =?utf-8?B?SGltZDJZbHJMREs0NFBSbllqeHMvK0dqSG5ybmZzSys3Z0V4TjlNOUtPWjBV?= =?utf-8?B?aS9jdXllaGJ0QkxMRGQ4UFNPN0tnMitSVWVSTXFVRDdFTXdIVTBNbjZ2bldD?= =?utf-8?B?dVVtZlhIZmJQY2VGMWF1UXdnbnV5Rjg2WngrM1NEOGIrVU1PcERpaE1DblhT?= =?utf-8?B?Yk81dHB2QU8zRVo4ZUwxSlMvMnZOVThIUzZLbWRlRHFGSmh3L1NzSC8vSlBi?= =?utf-8?B?SGt6SEdZZ1lTQ0tjT3hNZUI3b3ZxTFJZeDhlWmh4Y3k5eHR4VU5UbjBmSUQ0?= =?utf-8?B?WTIzOFoyV2xrNWNPRm1LMC92L2I0T2RyVVk2eWIwMjBNUWg0WVVYK2RrSVZX?= =?utf-8?B?WUgvVFhqZ3BsNzNrQTBzcW13Zk1wQzVZMGRqZHkwZTFaLzhmcmUxRE5nNm5r?= =?utf-8?B?TGh3MU5sZzFlRnhuWU91WHNwS291bzdEcFh0djZXTWppeVM1d0p2eXdzV2cz?= =?utf-8?B?K3BjdWg5amJOd2FUYUliS2Y3Y1I2RFY0KzZZYTU4bURKMCtQOHZsMTNKc1d6?= =?utf-8?B?R0R3VDZPOWpCbWtTUStaays2QmNnZnFHTG9sT25Iby9pVWxiYXFyN1Iydjh2?= =?utf-8?B?L25CS0xqY1FxMVdibE5GTWRZMno1Qm1pbDhVYnluaXQ0RFhEUTIvTVNlTVJD?= =?utf-8?B?bWRNVTQ5bUZ0a1lWdVA2Ums3Vk1zTkVWbVpsTVF6Zjhpa2VabnlVTDdRZTNZ?= =?utf-8?B?NitLZUJHQllKeEtRQW91Rm0vS204eVRlRHRNMjlFTmgrVy9VaGFOM3pxNGNq?= =?utf-8?B?NnMzUEkvem16bzdjaE5abjBXSGs0emlYMmN0THFHYWFqNGRmNGxoYTVsU3Nl?= =?utf-8?B?Q1BSbURXcS9TcWkyR0tYWFA4TzY2N0x6VXVzdFFtM2NJQU9GRUdqaE1waDQ5?= =?utf-8?Q?PxfB9UlW8/Svvm9mbf9E356Tf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9a94581-f7a9-47d5-a3fd-08db9752352d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:25:53.9680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KoFBSI5Mg+jjdMzLBybHf8tVxlJ0XUAAi+Pl+cPnA+dBCsykUx0ozcvYkvldXVSgEK2sxbJfnEcO9qLJLFDnZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8539 On 07.08.2023 16:24, Jan Beulich wrote: > On 04.08.2023 02:50, Stefano Stabellini wrote: >> On Thu, 3 Aug 2023, Simone Ballarin wrote: >>> From: Gianluca Luparini >>> >>> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >>> states: >>> "The lowercase character 'l' shall not be used in a literal suffix". >>> >>> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >>> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >>> >>> The changes in this patch are mechanical. >>> >>> Signed-off-by: Gianluca Luparini >>> Signed-off-by: Simone Ballarin >> >> Reviewed-by: Stefano Stabellini > > Acked-by: Jan Beulich Actually - I'm sorry. I can't ack this. This needs an ack from Paul instead. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:26:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578559.906116 (Exim 4.92) (envelope-from ) id 1qT1CC-0007RG-Dq; Mon, 07 Aug 2023 14:26:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578559.906116; Mon, 07 Aug 2023 14:26:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1CC-0007R9-B4; Mon, 07 Aug 2023 14:26:56 +0000 Received: by outflank-mailman (input) for mailman id 578559; Mon, 07 Aug 2023 14:26:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1CB-0007Ol-7v for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:26:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20618.outbound.protection.outlook.com [2a01:111:f400:7e1b::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 754e469f-352e-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 16:26:54 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8539.eurprd04.prod.outlook.com (2603:10a6:20b:436::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:26:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:26:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 754e469f-352e-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DE4XC/8cIjxiV/GwJwTVnEacRbqaq1MJFwJDoq9hvsV+v100DqBS/lpsUOVQYxjFKZ4ZC+Dvn0E/JEW4xg+oNrhpcHvnmUtcAvhnD0zob6n44yoJQTytidssZYwr6fsy3klg7wD+LY12yPVxQsXJRbJxC5RtOCCwvJNJxlU8+co6/Gp60SZgyF99ouPPyJEbgfh5vvmF/ZOHBVcSSpX/lQkegtjVONr2DaCehaY8ZfEXIcqX+zh9tjctRa4v3a59JF6OgBnOmA6+OYFnsZJPLznMkeGr99FNcG+w63NWEcTnkAsKMtDf9C+0cmMxmA2kNjLt/ed9h8i/LTjK06gBLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sdnpZtp31egot6MdvjKnbtXivBcvxTTU9tvAR241fWM=; b=gq6+edGU809L5XOGlKnGYLtsKif1zAV/pSOE1RxXUH4CURQz1l6fmL/FZ0M89I2Aakhls4h70o8Pby5+1+SIECNq7+nQE2ky5L9b+21AEnn5MaWEHPWR2u621H52WQmwERrUSfJIf1tiXag96vR8VtuRxb7Hodfq8xdmM3igZQ9e9Ovr5288K8KF+yC7JoNTpOJIFMojY4lc2A+9RBNx26iq8mPiOXyT15FU5CC+6N0bq+5AqJ6M9Zmx63IYIGjeVYX6FdoNd36gdnWwWaJ9MgUrcRyJOzEgYqKkrNqYUeFdOhYlcnm+wjBhSqFKnnJ7QwEr7FNtvMovBuIAnFA85w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdnpZtp31egot6MdvjKnbtXivBcvxTTU9tvAR241fWM=; b=35rR9XffCN01SI7KuYC+ElQNKSpgWk5PpMI8yaTLKFGZkX1SSGXfTxvSuHRBGqRIFQZPX51b7BTiSl5pOrYgq6KxqRm/Ugk5LEoJH9vz4Al31TNcRJ5JQdfcHNnnfLV/33lUa0JgQwu0h1+rdiflqFPbnA94h35AwXJjxTZjPTMhCUPJ4X/2F2uLV1E2pak3MBnDpLp4CEjRo1o/nquoAgobK952OyCuCzhPrcJ6qZGFytqVOTVRH/MoKXjZ0nY/PuZNqJIwVuzYpHzYXVmlMuUisEpOxDPJfyJZ3eXsuVEgtaOaz7MZgpCgyvZHm9wwV6nURDTLTO9z/aFfVDtxwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4a61ba3a-1cd9-082f-bb3b-efff69da68d2@suse.com> Date: Mon, 7 Aug 2023 16:26:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 09/13] x86/mm: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US To: Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0225.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8539:EE_ X-MS-Office365-Filtering-Correlation-Id: 4da9c6e9-c527-4a6e-3962-08db975258bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +YAeY3HWXOA93aPPw/8Yib8opnwZS7aNZq/WEQ1O8VZBA5Uzgtnt8qBgdnJdlc4xWNP/afWJbD7VFlNBD2bktayHy7dLLaKJbQok7kb1rmi4/uzSPp8ndt1iyNyFfRvhSnQ/JwuD1m6MPXsMFOm1/iYlyx4bnR0DDI6/b07KMsWrm9O3jIq42MG0XiSGg0U9n0of4jgG0EeZDvsL2ePEmM5eDlITutyvSmC+bA55cnm8mfkxlmjidkEQW0Kx8Cx0SFGuDRb88aMheDSIFnOuzEc7CoQz4MB/f67hKA9hgWVXMadYhwSaRpE4+egb0XX3Flnn4OvKOnFnBKuzw8L0l3KjtRetsFS1tQP+mfPJsIqSKhqHdzS6S/bBqR6SSI/vK9NxC4fVLG/QxP6VncRwO5uFJpq+cIapf1ZZ5pAncW/d/oau+IX+UL+lrlqR+bwIbpycsgg/nSayT6EZWwSb2WyUfoGRSPP0Nx62KNMpMgOmZJKwVrHOEjyXDuSOqJSFbqEPeNdtIxRitY7L/G5/LeRIdtGfr/56e1jMRegfUbTqDYD+BgOCCCyknKiNrWXE5p44XZ5kY5qkHbSeZ3h6vddYLtnsbupJIWsZokCIQIEWRiv5UFqVvhOCSX9Ey+9BeLkcr/bE52keZSxLsqYeSA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(1800799003)(186006)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(31696002)(4744005)(4326008)(2906002)(6916009)(66556008)(66476007)(41300700001)(66946007)(8676002)(316002)(8936002)(478600001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djVxUVI3TjVkcWYyUTk2b0NlWXlSclNhb09lTnpmaDF4TnBxa1hnUDlteVNj?= =?utf-8?B?MkxLVG1JNU9iRXZnTUFYa2VkVy9XM3NkSzdzL3R1U1pvc0xuWDB0MURtaVR4?= =?utf-8?B?dERZamlqa2RwY1Q3YW9tMUFwTmpvOWJJaW5XN2ZrWUtaTjY3QW4yc1BJVUlm?= =?utf-8?B?TXNFY25MVERMZStpQUs0K295Y25qeGs0SUorMktRUU9BRzFyTkFQK3lVYzIz?= =?utf-8?B?UWJubkJxYlhVdWZRdmJubzZSREppK1RxdnRCdVpQaURiOGZKb0ErV04xelA3?= =?utf-8?B?aG13RGdsdlV1clZJYmlteEdUbHV6L29zOUt6azBsQU90emxPRXp6L0hMYmxt?= =?utf-8?B?dEZDVEFyWkJNSUE3UVdEeVZMV3FqVVZyckJESSsxaGFmaEVidlFyRHRFOS9s?= =?utf-8?B?bXRsc0xxVUk3dS9yemRUWFpIeUZwNjhyM3ova1EwL2twMFNWMzl6MGxCWVlX?= =?utf-8?B?aGZ3ODF3NU1NRkN2N251NE5aUXJwYjBvenlFdUxXeWRSbktyaElwajdQSEVk?= =?utf-8?B?TXptMk5BZUNVdElRUk4wbnk2eSs2N1M4aDZwbVdtUmUyMThDSVBvbmMvc2RT?= =?utf-8?B?ZTl4eUJSVEgzdjE4bjhwcVFBanlmUlluUTZZdlhQRjZsU1MzR3RBOHFKQkZk?= =?utf-8?B?L2ZkVkVPV0plTVZ0SjZwYmd2NTFPbS8zN1JCNjZacUJsbVZkRmYwcWNFZktQ?= =?utf-8?B?LzZjYzFUMjVIRmdpU2R4Z0NwWGtNOUoxVHlVQ3dCV0Y0SllQdXNTZkg3QWN0?= =?utf-8?B?YU9WRkZyd2VtVzhCMmtmUnNDaFErTjBZSjMxT2pyTHNEMi8vY2dxYmg0VE9x?= =?utf-8?B?aXRObWxQR3V0Ym5jK2lKdWtYVHJUdlZ5dHQ2TTRYd2pmemhnaHdTZi96bEZG?= =?utf-8?B?ekRETFlBR0k4V3Z2NzZHUEFyWjlNTUtLNy9nNDd0Z3RFdkJaUkR2c0NQL0tX?= =?utf-8?B?eno4MXUyRmh5L2NOWUE1S2pZMzN1RzY0a0lJYzVvOUdPVDRUczI0YWc5S1FY?= =?utf-8?B?Ym13KzVLRHI1b2VlcWpQN1JxR290RTN0VlNyZnZ4WjlMaEZtb0lYMzg3VHAv?= =?utf-8?B?b0tsbzk4cWN2bk8ya0VDK1lMSERGenpLb1k5VmNORmk1dVdSdXJYSEUreVlZ?= =?utf-8?B?S3dGdmVIaGp6M3p1ck5ndWdtTWpENUFuQVBvTEZUblpEVXJZY04ycEFmUklR?= =?utf-8?B?UlpmdFhocTA2Z0RGL1BCdlJLNGtWV1NJU1JhSkd3MVdOR3NlVm13ckRiR2hu?= =?utf-8?B?enBqN3IzVnJQMTY1TXo5TUxJSDBDWHBVcnMzR0NuQXNzOFcrTXJWRFVmcmJw?= =?utf-8?B?Q0xFaWFxN0pueENoamxSU3JBMlVoVzhyTlExc3RJUENiZEpveitHclp6VVpX?= =?utf-8?B?b3BFK1hnc1lmeisyMzZWL2tBeWZlL3M4eTlUa3BmelA0UEZXSGdwT1VpUFl1?= =?utf-8?B?NEtidkFPeXJSVGJ3ZHAzM3RPZEYrUm9WNWxhaGtFaWJqbUxnU1lsL0JqNFNB?= =?utf-8?B?VUVBbWN5NENicEw2MlpUV0NCc0c2cXZtUFkzaHNZK2w3dnhORnhLbGNGam1x?= =?utf-8?B?dTBOcnplNC9rcGNhTGJqSlBaWERvWFRHTFhRd1JpVWJHNnhJYkgzcTZCOE5N?= =?utf-8?B?anJRSUdnb0pWWFpiL2VPVDlTclhCSytOTFRyYXZJVkpDR1FSYXo5UzRabnN0?= =?utf-8?B?YjJFWHBVSzJ1ZENHTjhrazBzRXhaazVvZFJ6akZQaGxlcVFBSmc2NDBDNEdv?= =?utf-8?B?SUROOGhyTmZXb09GbXF5ZWZoN2RzdkorQ2FCQXQvbEJDa0lsK2hNalVZd2lV?= =?utf-8?B?YU5wRlladnk0M3ZObG5qZ2hNbDVmVWd2Q2hTdVloMWQwSnlLL0xYTzh6ZTJn?= =?utf-8?B?b0dTaHhiTHlJZE9mMEJnbXFzb3VoQ2pyd1hnRlVnc2hWa0U2VVlqd3krbWIx?= =?utf-8?B?WGZDdnBObFZJQ3dpOUtjbVd0TE12emFQVDE2RC9oZlkrNktNcFBhRzhHREpK?= =?utf-8?B?SlRZK01BdkhXWG80S21EUDRHcnRFV0RWd0RVQkZRSWZBSTQySUo2QThuUndZ?= =?utf-8?B?alJnV0lSbjNOakVCQXBZK3lET0tZVzB5NHJzNXJOQWpOUU5QZUtiMDBWZVRt?= =?utf-8?Q?lvbyFryxwGg90X/MtGy3CSdlL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4da9c6e9-c527-4a6e-3962-08db975258bd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:26:53.6066 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zuOeOxYqBHmMocdToLekBgpSEiTWdqhRPGyc8KSART6HoQyok+ypPo3OmBavm4f6rTtBfvcjzFvPm+0xwYzFXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8539 On 04.08.2023 02:52, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >> >> The changes in this patch are mechanical. >> >> Signed-off-by: Gianluca Luparini >> Signed-off-by: Simone Ballarin > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:46:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:46:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578568.906126 (Exim 4.92) (envelope-from ) id 1qT1UW-0001jA-3z; Mon, 07 Aug 2023 14:45:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578568.906126; Mon, 07 Aug 2023 14:45:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1UW-0001j3-0m; Mon, 07 Aug 2023 14:45:52 +0000 Received: by outflank-mailman (input) for mailman id 578568; Mon, 07 Aug 2023 14:45:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1UU-0001ix-Jq for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:45:50 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 164a6fc0-3531-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:45:44 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8A3955C0163; Mon, 7 Aug 2023 10:45:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 07 Aug 2023 10:45:43 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 10:45:41 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 164a6fc0-3531-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691419543; x=1691505943; bh=13KAJVRZS0lyDfttFufljOzKUjXfoyee0eD pd8LZa1s=; b=pxbUCzYsTJutG5RFN2n+HoWa4FaBDZ9Oc1j5ToNLWYMMDF9+M0Q 9+EdD8Ry/lEpNKHbNFTG6G3sJE/Bg6n+7LMLW4tjubhXaiNGooXH3c0Dw0FbPl1c DQF+SXv03aBhAO2cRAsGpK/K1amhLcPn+7oNr2CCXMgkOFeqxElnn7Yse0Tr2yBt ZVnqDgNxlG0sfjEEntOsZTX7sfibFh1Mt38UDGnlrYvdcYDACNLA3iNOdAMc/r+z lTJi8dfZvyEtiTGMGsoK+RclnyoNIgeAbL3n6U/ft5vIIKAuKn0nQhfx//9KZiyK rsgr/4wnV9ZPA9gXOR/jbWBITS/Iedhh+Ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691419543; x=1691505943; bh=13KAJVRZS0lyD fttFufljOzKUjXfoyee0eDpd8LZa1s=; b=DVQoH9FgnC25GO0AKlPE/qGe5pzAB 6AarpfQGfFeol+e3fGIeePr0kaqdGvSwfw6OeKZqAgh67acG69Pnbyl+r2i/+GXl gi/UzoDCCuDZiF7mgT+N6lAONu0TCrA9MKx5v0URD0vQ172glmMnMkZhFRilfOtm vbuRu580nmUzeJhmeSYT/lOiMC0immZKqhsnByN54bDMBXVnHrnEbFE4nIlErhgi 0Y7GrL6iX8XR2aGBRPo7ZEiF1VzneFn/FHxQVeEiRHg5jkWdEFGmDRVi3/DojLKE Y8LzsFTOV3dbbEQgWxLzJUHpzwD3aGMO+T5x8+//VsuA5QL+IqQ9RNoIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpedvueekveegkeegtefftdfhgfehjeejgfetkeettddt jeegkeeivdelueevvdegkeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdhuvghfih drohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehsihhmohhnsehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <80bae614-052e-0f90-cf13-0e5e4ed1a5cd@invisiblethingslab.com> Date: Mon, 7 Aug 2023 16:45:27 +0200 MIME-Version: 1.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> From: Simon Gaiser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------dc4774u00hkvArK9z8mfi2to" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------dc4774u00hkvArK9z8mfi2to Content-Type: multipart/mixed; boundary="------------0aWoOdf9NvherbXim0P4ZODl"; protected-headers="v1" From: Simon Gaiser To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Message-ID: <80bae614-052e-0f90-cf13-0e5e4ed1a5cd@invisiblethingslab.com> Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> In-Reply-To: --------------0aWoOdf9NvherbXim0P4ZODl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Andrew Cooper: > On 07/08/2023 10:38 am, Simon Gaiser wrote: >> It seems some firmwares put dummy entries in the ACPI MADT table for n= on >> existing processors. On my NUC11TNHi5 those have the invalid APIC ID >> 0xff. Linux already has code to handle those cases both in >> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the >> same check to Xen. >> >> Note that on some older (2nd gen Core i) laptop of mine I also saw dum= my >> entries with a valid APIC ID. Linux would still ignore those because >> they have !ACPI_MADT_ENABLED && !ACPI_MADT_ONLINE_CAPABLE. But in Xen >> this check is only active for madt_revision >=3D 5. But since this ver= sion >> check seems to be intentionally I leave that alone. >=20 > I recall there being a discussion over this, ultimately with the versio= n > check being removed. IIRC it was a defacto standard used for a long > time prior to actually getting written into the ACPI spec, so does exis= t > in practice in older MADTs. So I noticed that the check in Linux is actually slightly different than I thought. Since [3] it always considers the CPU usable if ACPI_MADT_ENABLED is set. Otherwise it consider it only usable if MADT revision >=3D 5 and ACPI_MADT_ONLINE_CAPABLE is set. So I checked what the ACPI spec says: Up to 6.2 Errata B [6] it only defines ACPI_MADT_ENABLE as: If zero, this processor is unusable, and the operating system support will not attempt to use it. And the bit that later will be ACPI_MADT_ONLINE_CAPABLE is reserved with "Must be zero". 6.3 [7] Then adds ACPI_MADT_ONLINE_CAPABLE and changes the meaning of ACPI_MADT_ENABLE: Enabled If this bit is set the processor is ready for use. If this bit is clear and the Online Capable bit is set, system hardware supports enabling this processor during OS runtime. If this bit is clear and the Online Capable bit is also clear, this processor is unusable, and OSPM shall ignore the contents of the Processor Local APIC Structure. Online Capbable The information conveyed by this bit depends on the value of the Enabled bit. If the Enabled bit is set, this bit is reserved and must be zero. Otherwise, if this this bit is set, system hardware supports enabling this processor during OS runtime. So with confirming firmwares it should be safe change the simply ignore the entry if !ACPI_MADT_ENABLED && !ACPI_MADT_ONLINE_CAPABLE We can also do it like Linux and ignore ACPI_MADT_ONLINE_CAPABLE completely if revision < 5. Note that the revision was already increased to 5 before 6.3. ACPI spec version MADT revision =20 6.2 [4] 4 6.2 Errata A [5] 45 (typo I guess) 6.2 Errata B 5 6.3 5 [3]: https://git.kernel.org/torvalds/c/e2869bd7af608c343988429ceb1c2fe996= 44a01f [4]: http://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf [5]: http://www.uefi.org/sites/default/files/resources/ACPI%206_2_A_Sept2= 9.pdf [6]: https://uefi.org/sites/default/files/resources/ACPI_6_2_B_final_Jan3= 0.pdf [7]: https://uefi.org/sites/default/files/resources/ACPI_6_3_May16.pdf > Otherwise LGTM. I'd suggest dropping this paragraph as it's not relate= d > to the change. It will also help if we do decide to follow up and drop= > the MADT version check. >=20 >> >> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g= it/commit/?id=3Df3bf1dbe64b62a2058dd1944c00990df203e8e7a # [1] >> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g= it/commit/?id=3D10daf10ab154e31237a8c07242be3063fb6a9bf4 # [2] >=20 > https://git.kernel.org/torvalds/c/$SHA >=20 > Somewhat less verbose. https://korg.docs.kernel.org/git-url-shorteners.= html >=20 >> Signed-off-by: Simon Gaiser >> --- >> xen/arch/x86/acpi/boot.c | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c >> index 54b72d716b..4a62822fa9 100644 >> --- a/xen/arch/x86/acpi/boot.c >> +++ b/xen/arch/x86/acpi/boot.c >> @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *hea= der, const unsigned long end) >> if (BAD_MADT_ENTRY(processor, end)) >> return -EINVAL; >> =20 >> + /* Ignore entries with invalid apicid */ >=20 > x2apic ID. >=20 > ~Andrew --------------0aWoOdf9NvherbXim0P4ZODl-- --------------dc4774u00hkvArK9z8mfi2to Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTRA4kACgkQkO9xfO/x ly9ZEhAAjyDibkK4jOB0OTUur0ns+J0qOlmwEKrBvVfpJC3sEHHyUooeJcHxdEzu QmRRNZmXHnTUOTq8Tc1Cm1jm2Hw/1F8QueZlo6S5DVOR6P0zTYtTxqb7bulpZ2f2 vJqidos91zFeofKBdFb99Qg4j2YOONlKEPWSB6b0V2LxNbWk69hMEBdAbapsnZFS mKnwKYiQ//yyPuEMf6kSpJfXob+ZyInOH8UXn28WGyWV3tGgjfc8aXa2H6Qlghhb R0UxXeUvwnp9f5HcZE/GA0euPS+yFtPDGc5i7HcBVn2cDVGXabfj99Fro1kq2faD KmjCg7zxFkv5xVNfXf15LcSaItTn6+xse+xzfyMQwRaGuIbQrYjzeqPe3ZUzi55r 5iSlsADc+/y2H8K7i3KLkR5Hz/tIfmm2ABcmj/rCdbZ9m0EvhXSGXOjPv/Mg9tRy 2kKSElDrkE1jLexQHVBW9+da4sTglWZHAB6sj1Waq0b238zqCedI0SoUGT/3e5tc 0zQLfSv75x4mq/XDSpaPioZ/GCWl8mRdjMAb9vO70Ld/o7UuI14bGBQPj3a6prQ+ 30MnRr0Co70BDc6luwB817yL8NcOFVSSKWwvrminbMCXhupsX60XpJM3I2icxFb4 YDsy6c9+SKL8Ob8kp5uLwiTmqMOhADoKRpu/RM2cMA335YbveIE= =Ag0K -----END PGP SIGNATURE----- --------------dc4774u00hkvArK9z8mfi2to-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:53:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578575.906135 (Exim 4.92) (envelope-from ) id 1qT1cB-0003IO-S5; Mon, 07 Aug 2023 14:53:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578575.906135; Mon, 07 Aug 2023 14:53:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1cB-0003IH-PT; Mon, 07 Aug 2023 14:53:47 +0000 Received: by outflank-mailman (input) for mailman id 578575; Mon, 07 Aug 2023 14:53:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1cA-0003IB-C6 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:53:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0619.outbound.protection.outlook.com [2a01:111:f400:fe0e::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3478dd4c-3532-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:53:44 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8622.eurprd04.prod.outlook.com (2603:10a6:102:219::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 14:53:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:53:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3478dd4c-3532-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UetFXkql8vaSB/0repBN/1hkv2tY2y//HXuoTZ+Hqg0NEsXjgwi4ZxJ+KickBvIakYbBKqg7Pp1TaRjJ5adZ63aziW5m1A6pPfZT5mo2kdISGreGmpPmKARY4tKCfu7sOxLQvE6XVkN2NMxc+Jadqb5NQnhQaIv89uuKTlBO4NOLQC0n2Rv35JY1OR8/JG9gXhA2fi/o+uIGTCwZcCD2gE6WakZeexS5cZW/a6D1dnPGzOLBtPuyvZ6U5Vdgaex2DaJQjZ0evnHMiD8lv8bP++LTdUYoI+8TOE3q3HnDZXUz4IFA1P5IcnE3IBTu/BOBm/HvYtmMjhdc1qOnlE44+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/3GqZMkYaiPIMpUv/+jU5lovX5ftrYTCcTrwCIvzZao=; b=gP5t0JBchPjnFMOlsMfpTfcMOILGzvWX3yxwCvl88jwI6VXLz/yldkOcngwsE8FIHEJyKa7iugz+LFHIq2UNfeabFiI5+54xYcCMiRID8gsm2vo0Pb7wMUYEy7ktgDPKKgrtP1DemByvXi9q4Buy6AsTA1Omw2l1nrmRTQj2cf5gUdlX9Uw3jhwhXcTmh06X5K5kXDQpASJ8Jk7xa7mPt3voIkT7u7LpPNeulUuafF6dKQs3ipUOhQ9IEiWpBqNX1b3lS9SjQkgG0i8qoPMGG8lFo1X+fBROfoMhIOtZk+3c+mMcdVrXV1KbReB/CbocUbo5Z/dDdoLwJglF9MPulA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/3GqZMkYaiPIMpUv/+jU5lovX5ftrYTCcTrwCIvzZao=; b=z/uGS+NaKXw8qpar3dmVIxmAhUdvYI4RR0MvQkf6wwxTT8cav3j/+HkRs9bZwXE9k8N4YNVLsEvLgb9FeRvy1QliB4275uofwNoTq9HgFXeOrsk+Zuz/CEhpKJhcZRD4PAYI+nUpAfHS9gG7yxOT6Vf7nnjAdKGPLzkjbDe1DwGWWjvnYYRwXkp91FmV9NaBEoWU10BmjNCphQ3WN7UYeEir+6gtr3dg+0W4Az/Xh7428j3W9NVw/+b48muZzUJc+zvFNkWSt2IsA7fMLNoWOoz0plqTmdJRh/iEa1RWrUptEA6OpnMBx+4fRDBs9088as6TOgEuldF91d4UUKgfbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3ac671c9-d983-c321-d004-63f8e7f1af1d@suse.com> Date: Mon, 7 Aug 2023 16:53:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 11/13] xen/x86: address violations of MISRA C:2012 Rule 7.3 Content-Language: en-US To: Stefano Stabellini , Simone Ballarin Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Gianluca Luparini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <40f438ad05338dd86587eb469c7b0614e1d69462.1691053438.git.simone.ballarin@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8622:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ccd18c5-5dec-4c07-c4ca-08db97561731 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qrph2RtdTAF3mXn07PmFUOfoZiVl4+XqEXRx+GxAm+0Vw83CGk1CKDd1QwxIEQvj2AbrFl58D0j6apBJlA7FNFJaV5cntZj+BrMzKJuKpkJxJIWwddTIUaP+bZcKDgqNZXVDWFkBrBTXkA1UGcvWi49kXlZCypBYFQ+djsawM2+VeCbp6vaRmWo7SddEVD8pBlQyyBPYJKuuUJq5wiPFTzk/Ca+y88Sj8BH+YYh785epRzsOd44TVMTOWJpIit9XAIBiHuDT6J+pp65iWj99nWkW5kdxUgxjRx7ZT0mL6dBu5wWP9xkWU82AJNMLqcAh/jBX6tNBI+eC0xNdSXijksfe+h+xlunaEABV4OBA5rNBHdiKuP9Lrr8VtqPSnj85IOsalwR/h8mG4XJt0nZYTcFjSmhCc7zsL/ElOAwHAsnxOu9IQmdmYSu2SL/p6zR9zUFESaNH4k2OGb/Qc79xFTE7Ofhxq+lqgsHx/72Tc6r0P2WRaNkwmrUMz/kNdF9KEYpuyconarGiEZcEfKjKdHs2aQSaKNk1wQbsAMJIGwDxEt7+vkqCZbmmTV2srED0kbeKjvknQvkkig96DFai2Q8EQBKOdbKI/3Jpt+Q7ccQPYdmdd2J7gIFQvp0dli+aUm6DRhs+3YCg+DcYZGLbkg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(39860400002)(376002)(136003)(451199021)(1800799003)(186006)(478600001)(38100700002)(54906003)(110136005)(31686004)(2616005)(31696002)(86362001)(6512007)(53546011)(6506007)(26005)(36756003)(6666004)(6486002)(4326008)(66556008)(66946007)(66476007)(2906002)(5660300002)(8676002)(8936002)(316002)(41300700001)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHc2NldCK0F2SlIrb3lpY0d0dHpWZ0krYVpmdWcxdmtTQ2ZzMlIzbUlZR0Y3?= =?utf-8?B?bFNnd2xIMUJYRXZWQVlHVTVqY0lOc0tROCtEZjhkSjBsb1FudGVTOWRkNUto?= =?utf-8?B?ajl4ZS9ONGdzVEN4Q1Bwc2lWczlsMm80RE9COXNZdWZyTFpQN290RXdLdmto?= =?utf-8?B?cFUvVXdDd2hDYnY1ZEJxejVET2ZDZFFEYnUwYVdZb2IzZWVscUc5WEl3V0dp?= =?utf-8?B?emlTTUE0YVpMSmNaMENQTTZiNXIzdUZramg4clhNME40K1hvWHkyRU05SHA1?= =?utf-8?B?bkhVNUJzWk4xaTJLWDVOUWVpRmZadCt3TFlmMWgwcTNNdFhlRVY3RGNKQmZQ?= =?utf-8?B?L2lpeG9nc2JZL3lJbldjQ2lqbUhxdTJTNnZjeCtMUERibTl5eFppQ245NWxa?= =?utf-8?B?dHE3amxnS1VwTDU3SG1hcnBpMkV1RVJwQjBQUU5lVUh4SS9PTjd3azNrSXlL?= =?utf-8?B?UkJSWVZWRkNsSHRYNEd0bXp2VWNvS0dGUnVyR0djSHlKdjFkN0YyZmVqYUYr?= =?utf-8?B?bVpIZXY5VjR3dXhPRC9JVTNTRDQwRlJjdGp1VmNaelZvYkpVWUptYlRZbGtz?= =?utf-8?B?QXdHcFFuc2orRWRwL3dLSk50ak0zVnFlVEk0N0hKMS9LMitOODFFazRXV0hM?= =?utf-8?B?L0JhbC9mZ2ttbWNJbVdwTjFsa3I1d3hTZkNYTGlxQ3BsMExRQTZjb1I1K0g4?= =?utf-8?B?YURDTDRtOWtkd0Jwa1g4RUlzdjVZaGdJN09ObVRmcEVEekhxZDBSdEtOMmI4?= =?utf-8?B?RVVWUEJwM3FaSFVkUEYvbHplZnZnbUxURVlsYlpNMEI2ajZwQlI0VUpiZW1G?= =?utf-8?B?RHhtT080aUxpM1dmM0o5ZVJ1UHRPU3ZzZjA1R1ZxZURqUGw1Vzc4eVRjMzlM?= =?utf-8?B?Vk5sbUtVNXBYbmk5cmZBQ3hReXk5S3JJaUtVb01RYWYva0QyOWZuRkc4ekVn?= =?utf-8?B?ZEpwRGZHbXB6VWYxeXdOcXhjb0R0SWpvVXdUb3FBVElIcnd4VWZUMjk5SExQ?= =?utf-8?B?RHlMUllvVDVtOWQ4YVphRmp0byt0VThEdXNmOTVnRVdCVWVFZmpZMmpBUU1i?= =?utf-8?B?WWhvODk5TC8yeDA4WTBzZmZKVDRSWS9qUXpZMHo2aFBlWEd0bDFjZno2OXZa?= =?utf-8?B?U1hDVWtod2VEUnpoUGlZbXJDeGxDdWt1QTlTR1Q0ODhxQXF5NXBuYmcxMFZh?= =?utf-8?B?cEpBWEFsOTFaQ0pnNTFEc3Z2UVNQMVZNcmVzRmsxK0U5VlB3ZkJ0OFJXcG5y?= =?utf-8?B?dGNjY1dEYUdxbmdiL0NOM2R5a3JkeDhVdG9uWG5EMWdvOFR1bXdNeXNKbWc4?= =?utf-8?B?YW1McWlOZEM1U04yQnhDQUxTbE5qOGh1ZFE3RnVuajBLZ0pZV20rZ3FLQUFv?= =?utf-8?B?MFhWcmZ3QjlVWVIwVzhyN01XLzR2OTBtNm53OUlFLzlPaTlaeDV5YUFnN0Fm?= =?utf-8?B?VjdzOXkvbjVENFpuQWh5eVB6KzQ0elcrcFJ5RmNINkZlaVRKL2x4ZmNDTEg5?= =?utf-8?B?OXRDK3pDNi8rZmJ1RnVTNkhBN1VWYUFZM2R4czZKN3ZNTm9DZGY1TlV1c1Z5?= =?utf-8?B?YVI4QnpIT0w1SlZzdW1kYnpsL3FZampjMEVwdEV3TTYwUDVuYmJiYllGVTVE?= =?utf-8?B?YUFXRFJqcTN3VllNL2tqOWF4d0M3TngrVkNiTFZ6STc2N3hleDlkSUFzMi9p?= =?utf-8?B?bUpYeDI3VVZ4aWdZOTNqb1libWRDNzcyeTFQNDNrQnBnU01qdEdTQkhVbVpu?= =?utf-8?B?Q1ovbG1wZ01aRng5QXdpRFpWaWU5ZldkUk9HVVpnSC9waWpkWEpSUEh2Mm9M?= =?utf-8?B?bk9YWnl1b2pxd1Y0NjBGQnR4cVJFejZZaDVXZ0JSQkgzTk8vVDNKRlpiVTMr?= =?utf-8?B?Y1NBa0xGUEVoMUxCVlBJSEIrSmNzWFZKMndoNjJjWjRZWGhYR2g5aE9jUE1C?= =?utf-8?B?VmRURy9FZzdTMUdIQlErRkNtbHk3VEJOY1RNSjZKcjdrdGRta3dPdEY3b0pz?= =?utf-8?B?VHl1RnRYdy9yL3BKRERkZmkrNjU5Q1RrT0hWZUJIeXh2eGFySjAzendCSW9X?= =?utf-8?B?RnR2MDZvODB1UCtRdFJNNTJTU211Y1FESnc4K0xBMVY4b3BsVGtjK3hSdUs4?= =?utf-8?Q?BP/wIxWcE6jCiKFgB6omKcAWS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ccd18c5-5dec-4c07-c4ca-08db97561731 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:53:41.6621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KfDaCn1YiS+FZ/qrKQNncpRDpcoB1M94gIlnm5U1Wn/mFdgr0wnDF7IkLqebd/wY0LxC3oaif8fcclRGahu9Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8622 On 04.08.2023 02:59, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. >> If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. >> >> The changes in this patch are mechanical. >> >> Signed-off-by: Gianluca Luparini >> Signed-off-by: Simone Ballarin > > > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich > But I think I need an eyes exam after reviewing this patch Thanks for sacrificing your eyes for the good purpose. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:56:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578580.906146 (Exim 4.92) (envelope-from ) id 1qT1eK-0003sP-9U; Mon, 07 Aug 2023 14:56:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578580.906146; Mon, 07 Aug 2023 14:56:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1eK-0003sI-5K; Mon, 07 Aug 2023 14:56:00 +0000 Received: by outflank-mailman (input) for mailman id 578580; Mon, 07 Aug 2023 14:55:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1eI-0003sC-Ra for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:55:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061e.outbound.protection.outlook.com [2a01:111:f400:fe0e::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 835b0b33-3532-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:55:56 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8622.eurprd04.prod.outlook.com (2603:10a6:102:219::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 14:55:54 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:55:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 835b0b33-3532-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FJLJLsVPFpIikUtDG6pMbqUJiEikE1JrqcAQuLouSBUueHHouQi6MJAlqugipgJkTnTXJF+be/hCf24HlqnT0nyIIellnOOBzVAWPJxckWRIW+LSP1UKNNB8pkE1AJrVMXhxLoz1PUzCkGaZhSaYKf3HGUPLJTI/oU6PWqKBNikymMmlEC3Vr0BWy81ziaq6uiRlvJywrOlnlQf7qH768aK+ilcp3Tthg2SI/fUcIb0RyUHLsd00tLHVFp+ocZlRxeSrAcVHhGN5jzJVJC3Pb/0PiEiiSOHUgL1cu4AfODYmM95RzXAUs7GCFtQ0fb27q0Kos5TedEDv92rX6NeApA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cGn/cAoqOUISw54luILiQN/Pji42DpLD5bwIJ0SGs1k=; b=ZxiyJjeKXCgj2Ie73tsCKXhPhIhjq6g+hmE3s3FtHysuj+QsjDfKBt+5P/68b/gcx0KB858+Tl8KpIqxMH1KWn+8fnDjShx7OTMX6y8WvC2v+NhAvOJGsDqibCDuRt0tesYSCgGWNmoqlCgExFkJYh2qxQcMfyx2UeeOraruVpdwR+CnZqrXeaWIiMZPkB/3K8Sa1RFytji2fyWPVjDDa3RJvOGHjvQ5nCjvbG9ETIQQ85GFYtj8CTUbRzmomTiF5OawZJtIi2azHPOJ9RderEJ72lit3OaBIJyWF7vg9MG61iRkJT9sMb5LH5kbXMJWZgw5nDYNmm66T8aqGwftdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cGn/cAoqOUISw54luILiQN/Pji42DpLD5bwIJ0SGs1k=; b=Fh2mm00TN0jqx2C6n+YXivpvxClRhJX2uEHTNQ/H7AcQAsQLdsVCbZhqw45ogsNvqMvzTfU/sOx/KrhDNcJCmIykLVU5m8rE4SvFmpelIJKfm16DWaW/FZGSU0Rt7PoXIQPxfUDOCDZefiTOekktz+pJHO7/nmTQueOcMyuLjtSloMGHjsb8T50XXhdoqEeAzO/afSOF6nkBbSyeoRXSiG0cdkWByO3ciJhhuxpMUUeIv5WMGoP+wbtIH4ROVM+sy83LBDL2ks/vE5aFM4tujk33ee7q1A428p4nMufd5FMJpMrfYWTiaAR7WMj5Eryhjrbn//WH1WWMQ2eI6fr7jg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 16:55:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/4] xen/ppc: Add OPAL API definition header file Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <398ef92c0103fbc70f53b26403fa6596ac73ec0c.1690934409.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <398ef92c0103fbc70f53b26403fa6596ac73ec0c.1690934409.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8622:EE_ X-MS-Office365-Filtering-Correlation-Id: fab3745b-7cf1-4631-c873-08db9756667d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bGUgK4zgI3cWrYj7ZJeq/qpOZBNh+LpTtOtJQXksqBCuSgc2qcAk0EUEM3dNKsdT+KPBvQyI/YJLIHtqsmF8p9X0ysnpZbASjJ67b0oQ3F763Tdm1+xwaldF1okaREwG+gHS8pMiGZnXKdHfR8gtCyT+grZGImKT0/pjDMDn/F+vP9m5SqwFR7jVbmrS+xBbrNe7kQkSIvJ56gfeoXiNiuVOcKifh1DJfvNuI7mws1GE70IRCtzaR16kDOx9ZrH0Va1Wl2BmmB+BiOq2gmMjH76h88r5rF9hDad8AJTpHI0YGsW2HMo5FLj8WEH9SVPsuji0195H5mt5dErHVyfe4ChqV3YTbMCxx4kUjhNgLqcmhuq8ep/VAO+81jKrTAQZFdHBvwMw7+J5fUD5vIY2QELILbFIgrGy0FKrrAxR73wSuRbDKnhL5+wdkOcp5ftIcuXtQ6CPpCUi+RlZsinEMeqOC8kzt4FZDOzNc5A+3KfxQllaTEVwj0yQmX9NlH+qNlhK/orUqw1grtpSGwYFYxK2h8dUo+H4xChuiVyC97R/GVrcN3d4JpQnW56BpDsKcnBRn8UXnFsVHA2ISKVTXnTWl1yXfWs3rk0AFhbrXrIdorMhGjGGwze9QalhNANpsVnN/17oozLnamXDRFbW4w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(39860400002)(376002)(136003)(451199021)(1800799003)(186006)(478600001)(38100700002)(54906003)(31686004)(2616005)(31696002)(86362001)(6512007)(53546011)(6506007)(26005)(36756003)(6486002)(6916009)(4326008)(66556008)(66946007)(66476007)(2906002)(5660300002)(8676002)(8936002)(316002)(41300700001)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnkyYU02WW9hdUJsaStWMnZPK1gvNUk4VlZ0OXZEb3VrUklxZ0VjQ0xVK0dP?= =?utf-8?B?TUZrOEMzMDFRbG9kbTBOM3BvTiszYnh6SXlFSmdhVXJNK2pSU0ZGTnFhKy9I?= =?utf-8?B?ZzFZaW9nNTZRUDhtU05sRlZkbmcreWlUcUlrMk51S1B5OHlycCtYcmI5UTkz?= =?utf-8?B?UGZyVS9sSzFOcEFZUGZmWWpmc1hOK1pZWkovenQyRi9QZ2tRRlJ1dUova1NW?= =?utf-8?B?UTdJYVk1RCtoaFlzMUlzamczdERueG5RNjdhTElMbWlsckFaUE1BandMNCsz?= =?utf-8?B?eFlMeFF6ZUY4QThMek1DVU9HdkVBbE5yaFVnbmdVS3d3eDhSM3lXN3BoLy9Z?= =?utf-8?B?QXVlWXl0K0tmOVNMTEYvMHFESnpCTk44RFdWWXFTVzJ1MkZMekVvbGlxN09O?= =?utf-8?B?bkFGSHAvNDVwNEFldlJvclpoVUE2MWNadVZidStsQ3JzZ0pFRjVkbzAyQVFK?= =?utf-8?B?ZzhPQzgxMEdKTkpXT0lJb0Rub2FnOUJQZ0pyaENPUEwxTWZseEZoNktleFU0?= =?utf-8?B?NmpRTVVDbzMvOCtEVVROVXovdUpRaWs1bnVXVlpkUVRKZDFJUk1kUHdFVGNn?= =?utf-8?B?cEdkL1h2TEQxRVp5eUdtZkFEbmJsTndUdk1VclVtRHNpZmdFa0Vxc2ttRThM?= =?utf-8?B?V3Q5d1F6MHpsdVM3c3RkRy94M2h4S1ozdWpjT0lBbGhjQWNBbU0zQW4yWFVP?= =?utf-8?B?cGFWU0xsWEZOR2ptL3ErQ2dra2IyNW0razRBMG45RWJPMDVmSkhSOFp4NjI4?= =?utf-8?B?WVFMQjRrSUtQSk52clRCSHU3ZEE2Qi9jZHlYRmdsWTV6UUNKbzlVZGtTNCsr?= =?utf-8?B?dzFsMWdQM2FnNDBid2ordzdVbS83MmVHQ0tEM3ZiZW5Oa3JNd0hhSXREWFkr?= =?utf-8?B?NmhscmNraU9mVm44RW9Ya2grMmU1blQxUzhHMW13UTBrci9sNUVxSzNzZXdP?= =?utf-8?B?bys4WnhoNzM2bzJJOWpDSFhUdUZzV09oVGdlUlZuQmZjVklvRXMydFVZMExT?= =?utf-8?B?K0pIRWlmeW9tZmVTRld6bjJNVWFtRXorTnBPeWJhb3J1K1BrbWhrQUtmUC9G?= =?utf-8?B?ak5kUThWeDhqa1o2dU1qZ3pkL01YejlKdnZpaHdUSkM1cVdjNGdKSlg4dWJt?= =?utf-8?B?YWk0aXhhOWRHL3IySFFoM2p0MDFxMlVwQ0JrUDEzMy9sMGVycEhKT201aVpN?= =?utf-8?B?WmFvOEloTVdJb2NvRkJIeEtyTytuQmpYWWU4T3lacCsyK0dsREdZbEtuU0Yx?= =?utf-8?B?T3dBbDlxa1lyeVFoMVRBaHhRZ1lWdk9FQ2Q1dEVUMm1HOHhiNmVLNEd4bVBQ?= =?utf-8?B?ZFJPcHNVNnhtdEo3amtzYjdxTW14TGRiY2I5Y1lJOEVKUklaYSs1N0M2MGt6?= =?utf-8?B?WjlUS0srWlYvNWZ0ZWptcU5IdU11alJQR2s3MjRiME9HYXE3OUR2VzBPQ3cy?= =?utf-8?B?a1hoellrcVFOVG54Z3I5SGZQNUVUenFXa1FVS0I4M3lrWCtHVS9mc3ZpUHl1?= =?utf-8?B?anBCUzh4a3lyd01rbG5WYURpWm9HMVovbzlWNWtmZlk0eFltUjhueUVETklI?= =?utf-8?B?NU5BeForMXNXL1dMWVRSd0o5bno4WUtQQ2JMRmgybUlxVkw0UmZwWGJ1bzJT?= =?utf-8?B?MGxpNEtIZDd1aVpEbFVkMDZiTUIxdzN4TFozV1RqOUFYbldsOWNHWWp0bHZJ?= =?utf-8?B?T2NqQzB2V2o4MUdoQ08rb2xFb1NhSzdXSStGNTVWMVF5cFFrSkxURERzYzQy?= =?utf-8?B?VGQ3VG15QWkzNjlUOGw5ZXZYSkFKWk9rUEFLbGkzby9DZUlpRmkxaHNjL1gw?= =?utf-8?B?K2dhS0RGVnpRVGd5MWlvczMxRlpOeklWa0R4RHFOK0Nwamt1djRSMDVOTVZh?= =?utf-8?B?YlpGOXo2akNSNDloa3oxRGdDalJtZkF3SkN3dTNEZkVkWThwYlVhTVpxRExa?= =?utf-8?B?WTVHSG1UQTNveTFDdHlSVUZ2U0RZZ0Nwa2JtZEdkci9rdU9DMDlpRFNVTTE4?= =?utf-8?B?NkhsTkFObTY0WnlUcldRRW1OY3F4dEU0Qm01eDlGaEcrWDROamE3S3NyUFVG?= =?utf-8?B?MzJKSjJxSlowSzJkNVpVV2hpMjBIYjE1Z2haeGs3YVVmUGVLWkZWQm51RmE0?= =?utf-8?Q?G8zG/Lur0cPpWVQeF02uHuMQT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fab3745b-7cf1-4631-c873-08db9756667d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:55:54.7348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Bk29mMUk+c6LIadDUskiOVnZgj3b1LZrcV4JxRxgFpAHcZRBvvsOmaz5zUL0maWFMDl8mUeLdutS3YQb64XxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8622 On 02.08.2023 02:11, Shawn Anastasio wrote: > OPAL (OpenPower Abstraction Layer) is the interface exposed by firmware > on PowerNV (bare metal) systems. Import Linux's header definining the > API and related information. > > From Linux commit 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc > > Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich Albeit (like perhaps most of PPC) that's probably already an overstatement. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 14:59:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 14:59:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578588.906155 (Exim 4.92) (envelope-from ) id 1qT1i6-0004dI-Tq; Mon, 07 Aug 2023 14:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578588.906155; Mon, 07 Aug 2023 14:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1i6-0004dB-RG; Mon, 07 Aug 2023 14:59:54 +0000 Received: by outflank-mailman (input) for mailman id 578588; Mon, 07 Aug 2023 14:59:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1i5-0004d5-Ix for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 14:59:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20614.outbound.protection.outlook.com [2a01:111:f400:7d00::614]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f5c7442-3533-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 16:59:51 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8554.eurprd04.prod.outlook.com (2603:10a6:20b:435::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 14:59:49 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 14:59:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f5c7442-3533-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqgEj1UJwAmVPmwhFXOsU/5wQIt+KbkQJ/knDLSG8oLsNyUTy6GG9t0Iy+OVWmvIYNDsQOsRepCahOH6Q8+XcKDCHm4ODFX6cvSBYC4YCW6UZ75NJDBg2GF5ly3QoaYeeEwv85rKvjadFP/B6JAeP25lLIB4MxmsMpQi0DPnqhe3fORZW7EcPxL96jlyZmWopJn6YbpM2zyo9CcTPtO4YOURDb8KNWXXbU0YUkbOH06dvZaVMRZ8uMXngAcplAOqPWjhebFx3YTbY9eqvqmsWacYl3BLq6f0YOLvuFUeN5KrRpYs/zTUIlU+AFRfPGfoLbQwJNThk00wR7CakuKMvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjjszNJAg1agTj1Mvzb83fMug2Tcw1mS6kh4T4FWQNQ=; b=K4wGWVXoCu1uEfXNTsea68e4jJyRNKlPHn+CyZg0sbTAVenU1LcarlPUcyAHfnmgDPb0as0shNd7o+tqgWc8AZWGVvcHw7YJ0bzzqXrONH8StBDsAppauZjtp1tS2pGxxxhMRmmc7poTJNHB3TyHsXy0BG0f1UKDauohBXsjSZmPas4T0HSyj52uBSUlFw35kEPnzsdsONPrJWYpLHuf2Q73gJp5dthvEQ2hDutXtRtpId26qb0dSAmSbnxQOyKoixJgGmRtybilSuESgCYHn+wvzmKBpMRSK634Y0otFhWnThK9dTAWjMwG6cgfXt2WgZRPDBEiibcWPSBBijLn3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vjjszNJAg1agTj1Mvzb83fMug2Tcw1mS6kh4T4FWQNQ=; b=UcHcaZk7TogHrkTkcygitPIxnx+2XP6qNBbUJeu+B7mSnZvHeN3Ex0MnyBpuuGjYEtlWC1/IGPHZDryG6joa/i/Twuc/kc+x3/jA/96JrYfYZ5HjP1Pz7ZNZQP4JQ0TgyVcxMC3DN6mSaBpZlVQTfK7qDhryJ0om6/RJohH6uLraY4iQIIXa2A4bZ0ce+94IcEZeXuu3TZ3yEQxLyCiCxyPVien5yqEr28zEoAzIQFQwyFkUV24gk8R+1l/qJAfA4qBnZbTDYSayZ0nJTnAfHy/kwpMTYMQftuHe7+YJmSvk3DyXKsV+oWO02DJ+qQqIfcMoJwNnu1I35/Fmewz/mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 16:59:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/4] xen/ppc: Parse device tree for OPAL node on PowerNV Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <7026e54897e360d935d065c7ec904dc3f6082857.1690934409.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <7026e54897e360d935d065c7ec904dc3f6082857.1690934409.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8554:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bba8ac8-ac12-436a-1fa3-08db9756f29a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ke/fU2/AuACY6eUtKQfqGlkvoux/ux6j6MydlJn5/IFdG4y3EQZfZtOcjkc75F0V362ZFYg3o5Yy9pCWyBKhPKtIuH2zrUKXveqqCpwXxWb3m5g3YYz0s2+9x57MeE+9dH0kKcz5wvl4hapM7TXEMCtTbgTsNT2XHoEPu+Rhz+xwCcuANeiLTWXuvTut9p8Xi5pvM/lBy42ebnoqJi+xjShDHAWwYfwTQCDKumBrOyrlbdhIbKaE+t315BBOruHI/flD+0S/+kxuj/JkShYy96DPNhMTkErYtAb3EyjdIcCRFyoMM+YVcHRJWMCRBicLje2KxJgH2ZJg0mmMIU3zAjOw0mQRYy9znAChC1pgc0PQTOUJ77ECIcny4vZvjj+eahVhb5oC6TxPBqmbawX3GW1wH8sJdupQeFIFTDRow5dpdVKg4xKz4Zu+tAs+YAu72V1XCYQuL3V0U1SsF8RBT4HNgtqsIYLoXV9P5tUx7fRMIsI/lNGVDYJe7o+y6/n8TeMCrr0HRlFse357cm1/Xob1sEWzgrOXvpzlLcRkFxzBjQS86sfOR6lTQf0l9HHTC5WDRPAX/Qg5rB7NoVPLLipwM+XinwLHfIDcQRNtrt8784ZE6D3hO3xwITkO+HtLfUX4qYFnBD47T4K7wgb4FQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(136003)(346002)(186006)(1800799003)(451199021)(2616005)(478600001)(31686004)(83380400001)(6486002)(6512007)(53546011)(26005)(6506007)(41300700001)(66946007)(66556008)(66476007)(8936002)(8676002)(316002)(31696002)(4326008)(2906002)(6916009)(36756003)(54906003)(38100700002)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VldnSVdTbXIwQzh2ZUREUWhiWHh5ZU9GR1dWS0l2bThHaHFETE84anBCMTlC?= =?utf-8?B?aktGc2owQWhCWitNTGVSTDRyb2N2YjVSZ04wb1dXRmhBTnBjK05aTmE4azBm?= =?utf-8?B?NWxidjFkVG9UUEsyeFdkRFFMRmt2LzB1RHJ6REpLRXFrcUV5bzBibmpjZ3hD?= =?utf-8?B?N08rOXc0YzlFYnB0c1pZeTRvUmtZQjU0cTc3ek9KZGt6VTJndnZ2cnZySHZv?= =?utf-8?B?MnNBcmtyclJUcDdyL25HWGhkWkg3Y3c1dmlEMlJIQ2N5cG14UVBOWVZwV3I2?= =?utf-8?B?RHArTnRFaS9ld25lQStyeVBsSTh0WUFvTVdwZFNqSG9EbmJBTFVISlJOb01i?= =?utf-8?B?NnVkaERsS1Mrc1E1VG9BNDZHTzFFM0QwSFdGQUpacnNmQWp2bTlIdTJSdWxr?= =?utf-8?B?N29xaUljQW1CRWJPZURBMEdvNzIxNnVCWksyOXVqdlE4VVF3dzB3dGhtU2Np?= =?utf-8?B?RFVrWGhFVFQzRUJJS2RuMFl1eENPRCtYY0xCc1l1cjhhVkd6VDUvRFh6TWpU?= =?utf-8?B?dEwwaFpPZTBqSTdJVEdzTWdvYzd4UWlqN1ZBbEh3ZHlUQ2dlZ1QxRDdzL3R1?= =?utf-8?B?R0htZjlNVFRjZUhwTUFWWWlKdzdqSXdIRGorMzZzdnFwVnI2VC9wT2dOL3Zu?= =?utf-8?B?OTFFQWtweXdHNWdkSEUvbTE1SWkrZHVFNi9kajhFYlNkYzdla05pb3ByT3VF?= =?utf-8?B?bkR3OVZLOHkydHFtRWhCb0RjbFZhbTIwRVdHem1hTGRCK0FCWGZOYXM3d1dV?= =?utf-8?B?NkZ2OUlzaktHakVLY2ZTbmd5dnFEQlovMC91K3Y5SDJNSXNuTGdkeTdlaDJ3?= =?utf-8?B?dHJvNTdmMndmSWFJWkd0bE9VVnlUa2JlR3V1cXVLSEYyN1QzOWdBeHN6SzU0?= =?utf-8?B?dTdubkQwcHhiSE9pNkYyWi9EQXpRY3NqdDd0cG0vTDE5K25MVmw5UWlTRkli?= =?utf-8?B?QUJ6NlR1Rk1JZ2xwSVB4U0FkaEoxeGc5SjVOWlFabjdKdzNlUjlGemJTVElp?= =?utf-8?B?dXJFdmtJV2hoOHFXQ0E3YlpXQ2EzV2REanhIU1QrNGhMZXlpT2dyUEdXZitq?= =?utf-8?B?eXlYalBkaXB5dXA1Z2M1NXg4VnoyVjlFVHJPZXpmQlZzYit2Y1hkcjhwYzhl?= =?utf-8?B?TkhPWFhVWVdvMVlad3J0cWhIYnJnM3NyRlg3QktiR21OOGwyVm5UUjN4elB0?= =?utf-8?B?MWcvL3hWbklZSXNVUHBPT3B4ZXRTQUlXbDFVNWJXUVR3K3JlMnlFS1JBb2hl?= =?utf-8?B?RWlCS1ZmQTR3VnVuWU1NeHBtZFM1ZmRab3Y1N0liSlhXTzhBVUZXSFB6WjA3?= =?utf-8?B?ZUdiTGZkUUlsc3I5cTAzTnlYMTY2K3dmdzZxK0VKLzhrR1hSeGtxcTZVTzNC?= =?utf-8?B?T1NZTFgwemJkREp5OWlsTWdBTy9STnRobDZ3UWJnRmFWa3g1UGV6NEdGeTVn?= =?utf-8?B?Tm9CVlQxd0RnaUVMVjdSVnNjajNEUmQ4VG1zMHAvV1ZTRVNXcnZBbTdWU3JF?= =?utf-8?B?SExOVHFLVmEvVU9NcWx2Z1JFQU9KYU56WWNDRnJhbzhzQ1B5Uk9kRHBNeW0r?= =?utf-8?B?Zk9XbzV4MDg4QjNQWjUzS1ZoNmNVRStPNVp3a1pUUGRwQk5KamptRndZdTJt?= =?utf-8?B?Vi9zMzE4RGNCVHlOVVZYeDRwMnBNaGh1cVU1N1pTTHRkbmpPVWphNkNUVkM3?= =?utf-8?B?UVdoY2prdnkwNjBtOUZOdU5kdEpCbGNLaUlMQjBmM04xeEZVaGl1Tkl4OHFI?= =?utf-8?B?dVNmWlVyU2JqYlVnanlUMGtJVXorTWwwUXVlTE1YSFBaUm5oa3Q0anhVR1h2?= =?utf-8?B?S24wUWRTVlFyVHZsQlUvWWVZZzJKbzdrc3pKbzZYZlNOZlg3MXFlQ2I0U0xk?= =?utf-8?B?MFpCL1Q3RE9GUklGNzFEcHdkWENhTFBMbkc0WDM3WVVTbWh2bjA1dlBMdGE3?= =?utf-8?B?K1N5V0VMRjlsd0YxQXNyOHdTcExkNUFXbG1PNjhIT1ZZZVFJWCtjWjdmbnp3?= =?utf-8?B?NnJBM2FYSXF1azd3VUZ2NEYxaGxVb1JsSEpMUVRENTRLSGFVd1F2SDMwRUVa?= =?utf-8?B?cFlRZEdoOWdzd3l4THV6Z2VuWnRsdGR6TG5NQk9KU21qOGRzanB1U2hWOTV5?= =?utf-8?Q?ydhg1MwVBcezsLOOZkJt/31Ah?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bba8ac8-ac12-436a-1fa3-08db9756f29a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:59:49.8033 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vZNv6R5Zx3rzMSJCq1Uh6LywkZYManRUkf5OVL/4Yy8REZ/UUK9E2JTU+rq6tcek4mFLNEI0gdfu3d3gjV47lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8554 On 02.08.2023 02:11, Shawn Anastasio wrote: > Communication with firmware boot services on PowerNV requires parsing > the fdt blob passed by the bootloader in order to obtain the firmware > entrypoint. Use Xen's libfdt to do this and store the information > required for firmware calls, to be implemented in a future patch. > > The full xen/common build doesn't yet work, but libfdt and its xen/lib > dependency can be made to build by defining a few stub headers. > > Signed-off-by: Shawn Anastasio Looks all plausible, so with the earlier constraint Acked-by: Jan Beulich Just one nit: > --- a/xen/arch/ppc/setup.c > +++ b/xen/arch/ppc/setup.c > @@ -18,8 +18,13 @@ void __init noreturn start_xen(unsigned long r3, unsigned long r4, > } > else > { > - /* kexec boot: Unimplemented */ > - __builtin_trap(); > + /* > + * kexec boot protocol > + * > + * TODO: This currently assumes an OPAL/PowerNV system, but it's also > + * possible to be kexec'd on an OF system. > + */ > + boot_opal_init((void *) r3); No blank please after a cast specifier. Can surely be taken care of while committing. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:03:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:03:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578594.906166 (Exim 4.92) (envelope-from ) id 1qT1lf-00065P-Cs; Mon, 07 Aug 2023 15:03:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578594.906166; Mon, 07 Aug 2023 15:03:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1lf-00065I-9q; Mon, 07 Aug 2023 15:03:35 +0000 Received: by outflank-mailman (input) for mailman id 578594; Mon, 07 Aug 2023 15:03:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1le-000658-5O for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:03:34 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9371f5f0-3533-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:03:33 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id A82E74EE0737; Mon, 7 Aug 2023 17:03:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9371f5f0-3533-11ee-b280-6b7b168915f2 MIME-Version: 1.0 Date: Mon, 07 Aug 2023 17:03:32 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 10:09, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: >> The variable declared in the header file >> 'xen/arch/x86/include/asm/e820.h' >> is shadowed by many function parameters, so it is renamed to avoid >> these >> violations. >> >> No functional changes. >> >> Signed-off-by: Nicola Vetrini >> --- >> This patch is similar to other renames done on previous patches, and >> the >> preferred strategy there was to rename the global variable. This one >> has more occurrences that are spread in various files, but >> the general pattern is the same. > > Still I think it would be better done the other way around, and perhaps > in > more than a single patch. It looks like "many == 3", i.e. > - e820_add_range(), which is only ever called with "e820" as its > argument, > and hence the parameter could be dropped, > - e820_change_range_type(), which is in the same situation, and > - reserve_e820_ram(), which wants its parameter renamed. This one is defined as return e820_change_range_type(e820, s, e, E820_RAM, E820_RESERVED); so I'm not certain that the parameter can be dropped from that function, because the cascade effect would eliminate the need to have a 'boot_e820' in 'xen/arch/x86/setup.c' afaict and since the comment says /* A temporary copy of the e820 map that we can mess with during bootstrap. */ static struct e820map __initdata boot_e820; I'm not sure it's a good idea to alter this call chain. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:05:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578600.906176 (Exim 4.92) (envelope-from ) id 1qT1nd-0006fH-OZ; Mon, 07 Aug 2023 15:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578600.906176; Mon, 07 Aug 2023 15:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1nd-0006fA-LE; Mon, 07 Aug 2023 15:05:37 +0000 Received: by outflank-mailman (input) for mailman id 578600; Mon, 07 Aug 2023 15:05:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1nc-0006f2-9X for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:05:36 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db4a478d-3533-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 17:05:34 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 132BB5C00BB; Mon, 7 Aug 2023 11:05:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 07 Aug 2023 11:05:33 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Aug 2023 11:05:30 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db4a478d-3533-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1691420733; x=1691507133; bh=x1PjOXBZ8MeWIkWCLhH5M7yKNK3YPDONkXO 9+vqVpf0=; b=ylRidWyz6T2jUDsFyBKPXdIyYldsjMVInGMaBuM77HLj0RxoPxF NQqVxemL2fX2xwbzdZbnXY5scTXwlF7NEOBa5+P/n3GmWyTvt5aUmrVB1jNwCDRo NLFE7/cj1fXgDGcKsALQjTcKSrtqYLCHXJF7/f6ot0gMjrZyRS7/0DopSVElv6sN KXk3kWDL5zlW+DfqcNYXCns36RIvn3CLiRO+nXPKuUnSTv7iNRQhT+edfoAbfylE vHsf3PKvua1C1QJ5uzeW+RAc7RCTh3EQMfq+TJW2Afk7rSEsJrxPlmqgOb5XG8sV hGe10UVXtzN0klarDGwG1hdEJG+feuoOK4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691420733; x=1691507133; bh=x1PjOXBZ8MeWI kWCLhH5M7yKNK3YPDONkXO9+vqVpf0=; b=Ejjl3VU6aM+QEvXRsdGBk6atbuUzh V6p4PWJNzqagtK2F/Yl9ToA1zpuxHReBE+dtLnQXHmqqNO4Jc52pme+Fm/b6dYpz +9SsvdqL31U8BOltlBY7UiNRg2JhYRUxiOk1/fgmAMusUipEtosVgHb+FIGLwyR6 5InWjiCPQEcUFI/SnNbXYVvaOTob64Rir/mg6qypu3gfLRKUL5gY5FbOQTmb/3Cq t/xTD0DVF+y+wLZqr/BiDm2ojBd+/0POxx+XJhuvYZqkdprQmeSUqAZH5bkEFMLV Y0Xm5aXaSgNtE/PQsybxYwux7yovHQEsxRpA4vV9mynrnr2KoSMpQ6pbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledtgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffgguffvvehfhfgjtgesghdtreertddtjeenucfhrhhomhepufhimhhonhcu ifgrihhsvghruceoshhimhhonhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtoh hmqeenucggtffrrghtthgvrhhnpeeftdefudeltdevhfehkeefhfeutdfhffdugeetffdv gfehfeekhfetgedvuefggfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhimhhonhesihhn vhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: idc5945a3:Fastmail Message-ID: <3951c6fe-9912-634f-203c-6ba730cdc047@invisiblethingslab.com> Date: Mon, 7 Aug 2023 17:05:18 +0200 MIME-Version: 1.0 Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> From: Simon Gaiser In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1XX4WipUR17ddjVy1wur38SO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1XX4WipUR17ddjVy1wur38SO Content-Type: multipart/mixed; boundary="------------8PpbNFGZn32ploxgMhDxTmoH"; protected-headers="v1" From: Simon Gaiser To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , xen-devel@lists.xenproject.org Message-ID: <3951c6fe-9912-634f-203c-6ba730cdc047@invisiblethingslab.com> Subject: Re: [XEN PATCH] x86/ACPI: Ignore entries with invalid APIC IDs when parsing MADT References: <7f158a54548456daba9f2e105d099d2e5e2c2f38.1691399031.git.simon@invisiblethingslab.com> <0bd3583c-a55d-9a68-55b1-c383499d46d8@suse.com> <2c97ff5b-03b0-3c17-c7f0-9bc8c9317762@invisiblethingslab.com> In-Reply-To: --------------8PpbNFGZn32ploxgMhDxTmoH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jan Beulich: > On 07.08.2023 14:55, Simon Gaiser wrote: >> Jan Beulich: >>> On 07.08.2023 11:38, Simon Gaiser wrote: >>>> It seems some firmwares put dummy entries in the ACPI MADT table for= non >>>> existing processors. On my NUC11TNHi5 those have the invalid APIC ID= >>>> 0xff. Linux already has code to handle those cases both in >>>> acpi_parse_lapic [1] as well as in acpi_parse_x2apic [2]. So add the= >>>> same check to Xen. >>> >>> I'm afraid it doesn't become clear to me what problem you're trying t= o >>> solve. >> >> I want Xen to not think there are possible CPUs that actually never ca= n >> be there. >=20 > Did you try using "maxcpus=3D" on the command line? If that doesn't wor= k > well enough Yes. Then Xen says, as expected "SMP: Allowing 8 CPUs (0 hotplug CPUs)", but disabled_cpus is still 8 and nr_sockets therefore calculated as 2. > (perhaps because of causing undesirable log messages), I don't mind some verbose log messages. > maybe we need some way to say "no CPU hotplug" on the command line. That indeed might make sense, but I'm not sure this is what I want here, see below. >> Without ignoring those dummy entries Xen thinks my NUC has 2 sockets a= nd >> that there are 8 logical CPUs that are currently disabled but could be= >> hotplugged. >=20 > Yet it's exactly this which ACPI is telling us here (with some vaguenes= s, > which isn't easy to get around; see below). >=20 >> I'm moderately sure that soldering in another CPU is not supported, ev= en >> less so at runtime ;] >=20 > On your system. What about others, which are hotplug-capable? Would those be listed with an invalid APIC ID in their entries? Then I understand your complaint. PS: based on your reply to Andrew, you think that this might be the case.= >>>> --- a/xen/arch/x86/acpi/boot.c >>>> +++ b/xen/arch/x86/acpi/boot.c >>>> @@ -87,14 +87,17 @@ acpi_parse_x2apic(struct acpi_subtable_header *h= eader, const unsigned long end) >>>> if (BAD_MADT_ENTRY(processor, end)) >>>> return -EINVAL; >>>> =20 >>>> + /* Ignore entries with invalid apicid */ >>>> + if (processor->local_apic_id =3D=3D 0xffffffff) >>>> + return 0; >>>> + >>>> /* Don't register processors that cannot be onlined. */ >>>> if (madt_revision >=3D 5 && >>>> !(processor->lapic_flags & ACPI_MADT_ENABLED) && >>>> !(processor->lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) >>>> return 0; >>>> =20 >>>> - if ((processor->lapic_flags & ACPI_MADT_ENABLED) || >>>> - processor->local_apic_id !=3D 0xffffffff || opt_cpu_info) { >>>> + if ((processor->lapic_flags & ACPI_MADT_ENABLED) || opt_cpu_info) = { >>>> acpi_table_print_madt_entry(header); >>>> log =3D true; >>>> } >>> >>> In particular you're now suppressing log messages which may be releva= nt. >> >> I intentionally mirrored the behavior of the check directly below. >> Unlike the the version in Linux the existing code didn't log ignored >> entries. So I did the same for the entries with an invalid ID. >=20 > I'm afraid I can't bring in line the check you add early in the functio= n > with what is "directly below" [here]. I'm only inferring the "here" fro= m > the placement of your reply. Maybe instead you meant the rev >=3D 5 one= , Yes exactly. "directly below" was meant relative to the if I added. > in which case I'm afraid the two are too different to compare: That > rev >=3D 5 one tells us that the entry isn't going to be hotpluggable. = The > APIC ID check you add makes no such guarantees. As mentioned above, if that's the case I see the problem. > That's why the new flag was actually added in v5. See other branch of this thread: https://lore.kernel.org/xen-devel/80bae614-052e-0f90-cf13-0e5e4ed1a5cd@in= visiblethingslab.com/ So we might cover at least my case regardless how invalid APIC IDs should be interpreted. --------------8PpbNFGZn32ploxgMhDxTmoH-- --------------1XX4WipUR17ddjVy1wur38SO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3E8ezGzG3N1CTQ//kO9xfO/xly8FAmTRCDAACgkQkO9xfO/x ly9F/A//V1HnvexE/g4/sZcg7CAIVQJ8XTAHbxqmv7rAhLmuLKSZcGeOYriEYVg/ zZMaL82Ja3bYD7DlVUm5Pxan7McNdPIpldpW+ffbkS1SOCQzFpVhA5wbkDV4Z4jh ulxxO5DQWrOgTrmjqK0jL24SPHgqcsFFvHoQPW5fAMJXEU13Hk7kvOlG9PdiXbst 2/9icgzzN5ANcxGZDFbEY7KOt1VvP7lPqMkZ9As1kdfW7vpeMZD7U2gDGMqyPhxz yIoH/k9s+S2IyTO4J75Dku2kQa3PfnNIcksq/0b0W/LpnQnJhlRocBLTro/frl2R WrA+HLhb54qkMKgQD9AhIvr2GAlmFCBLGN4KjoRYqGDemDr2BxRp6Iq0dnRWIhvu HOcMCjObZfyQOyz8sddof3HTUFX7gh/HyBmhWMUoMXde8INX/UGzcysp9KB1Ieb6 oRcCy2lkb/Ly6AfGU8s7mc6x4DQ4KhR5FbIXfxtdiGX6GDH+xfst95DUYoBO1www aMa4TggRLFcagKBftUJZjqZnZEEqkBEc8U8ac9AWdSsdreE0rS7or3k1bqv63pXN BbgxtQTm03rlxsLp1TqzAEuogrkAj5g90plmA7TCdTTQpVJbAhxahgyxXRgVKYih nKDpqukFZoA59EDiixqr7rINM8ylSgeNp4pFNJii3aHnNOXKIVU= =86/z -----END PGP SIGNATURE----- --------------1XX4WipUR17ddjVy1wur38SO-- From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:05:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:05:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578601.906186 (Exim 4.92) (envelope-from ) id 1qT1nf-0006vR-VW; Mon, 07 Aug 2023 15:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578601.906186; Mon, 07 Aug 2023 15:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1nf-0006vI-Sc; Mon, 07 Aug 2023 15:05:39 +0000 Received: by outflank-mailman (input) for mailman id 578601; Mon, 07 Aug 2023 15:05:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1ne-0006f2-LB for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:05:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2055.outbound.protection.outlook.com [40.107.7.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dd2e6a1d-3533-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 17:05:36 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9355.eurprd04.prod.outlook.com (2603:10a6:10:36b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 15:05:07 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:05:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dd2e6a1d-3533-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XLOpJuZSrPeDdmo7PsXy3rIX6DUynsldbsKsu6f+DLcoYyd8ms38IEpDMtbv9RvtPwzQleE2YT4QdFYLZD+6v4bGmiSriwQv4nmhTjFK1z/NqEJTd41/swNebUa1kAIoyb5mY7dqQafUyU/zfUJEENjjjH76GQkb0M8CtEJUHDDtF1OFe8BuEEC8IvdpOvnahvIFYsa3QgbSw+Y/nTWb7K66bVEwHOKA+LQCM4OqsxIkWfMaGpkD2i7A7a36XH98mL7YWSXmMAzhMJbxOAXHHIqQQlgcCJCOoq3TEvA+1oJfTaDdU0OBcJoTPDm9GJ0ZQ7iZdvi77j0XYX90/bdNtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LCpIa/iskW6jITbUOFS8+hhzk/xiY6ob/s6idhQe1J0=; b=THaRbgwsukvrVu1w7U4OTI5QQDSshP+OsV+Mvjv+vZh2lFZGKNCRmZBqtcH4lCS9KyCBLDuwa0KogjRDwDG0aU0AeBLUbBZ94x3OlNBE+77OhV8YPGy8CxMqsFWU/WhvWULWA4lOSso2uKqF22QgYMWaZlHGVE19KK+1P6qK/v0Rjxcwy0yo8oM6baob/QlaOPP05No6wkY4GsLe1tDNRMM0EkrTdUzB8TM8ykqiJGFCwVN/8R7799ZpyS1n8I/BGpuX4QGFz/fXi2xLp5UzZ6BVKLYMguVichlhZAkjp570YMYTj438G7ojP94Rmo4E2xieYUrT1ow7koMtTaDxLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LCpIa/iskW6jITbUOFS8+hhzk/xiY6ob/s6idhQe1J0=; b=T9e+hzaaXbiRPlgfJvA7yvqXOsmzQ8rrwhNjHcI96TSUjxemshaxYcE2Ogyg3DQBuIV8pmBRoWKz3afjt5sfoI0lixRb7rvBrpUAf88s4g2Ew23HthEsqs4hdI2Ml+fxjsU9Tn/vTIMtn82iX83pi346sYvLXM6UB62A0QwJqUtQSkQfsROK0gv394EOt84bpMxyib00BB5/UHvscDxdH2a46sECbmbMNkfreCr556K8W7m3BVGTFYyaQDd/4whqKSuJ0wgzeNAmhFCnCoouNPYeBAtlhchik8SRp0+MKB4LaOG3EYLrrfu9mG0dkrYwaHUfcsuS0UZPY0Y5oUVUEQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8cf5b42d-a80d-a8de-b564-8b45c97474c4@suse.com> Date: Mon, 7 Aug 2023 17:05:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 4/4] xen/ppc: Implement early serial console on PowerNV Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <3176762c2eb09d01d65a348e296a94cf0356ff46.1690934409.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <3176762c2eb09d01d65a348e296a94cf0356ff46.1690934409.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9355:EE_ X-MS-Office365-Filtering-Correlation-Id: 8371602a-3bc3-47df-a093-08db9757afba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oGs8GnZ1kI0VzI1Wr2wOcrgcz6NoH4vBH5cu81z/U2ZsyvgDIumt/rq0hQfNFz5bMlDNjMNBLcuCxm8gwocA5uMRBPcRg6XGL0rzeU/HbMX4LjrDiPn9P/Ng1hEV7oOmn8K7linXbKrUuBwEdX2o5JCGVLYvPWeTSyzlvBXm5jV7jy657pPqvxzfjni+P7+I9DfSj+WGBBTZsqBywkSuxjT7gVTFmEVW0ygMSUVrSTtthFSxoK3yfrL31eybbiqwWomCL9TgGZIHPMVWEXtEFRjj85NA/6R+XUQuF2mv+vDJt0t5Bfjc3pcjVWb3phS5H1fUbS9B+VO+MJUrqrw8X9kl21mNFwgqtXjM0RUIE1dFyoaOnrGMcRbTyuyIpl30Idxl0IwGgqReJHdV9R6HPHWCXioOHqpvWtfBr7gr/NpZHlrysRPxqlVXc5R+Z2nlUZaELVD+PnMWw1lGp2CiFJ8MITTVClsiM/7v14xovtZHmG9yur1JhGQKTMDz/DTLKYW+09rEjFWzgIUPwE7IQAWAT1pX/i6QWu4UnnrUVrTbtyOC32487YYWCg8+GjQ+RGTbaK4wzqaUm+E+T3BzdVlAFPyXJtPo26zujT146HSGGhFHzh2AQjr4Ceow3Vg/lJP8WQVhGLv8V4ttbctkbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(39860400002)(366004)(396003)(1800799003)(186006)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(478600001)(31696002)(6506007)(53546011)(54906003)(38100700002)(6486002)(66476007)(66556008)(6666004)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUIvZzVXOHpicWJWNzhyMUZ5MGZtNzNnZTV5V2ZNQjFGd2FrSkt1OXBVQzZn?= =?utf-8?B?Um82dWtML3hQcXZZMSsxVzIwZWdBMUNMaGtMM3VFUkI5NlY0bWdLRWVNUFhJ?= =?utf-8?B?TFp5R1VSMzRaQzRtTUpINEI1Znd2Q1IxS0NCaHQrd2JULzJnQm5tdkhDekRS?= =?utf-8?B?UFNiYm1NeEp5bGMwcFU0SzlBekd4WkRXOEpXWko3dkpNZHZJNVJDL3NKM1NT?= =?utf-8?B?bE5BUUNIYkMzRUxiekVMTkkxOEVaQzdnK292ek9OeFVRSjdlLzM4bTlNQmtL?= =?utf-8?B?OXJhREsyM2F6TzlxVDFSKzJoYWUvQkp4eFU5eUZINlRCNXF5ampNS2RvYW1z?= =?utf-8?B?bUQ5bkxQbjk3RGtEU0Z1TUtncTRWdy9NM1U3K2FOWjFrRmV0MkpDYStING1N?= =?utf-8?B?WXFldG93QkVpZEc3WGlRcGh4eklOR29oQnI0ZGRnMGdHWjBYVnVzeXBiZWtr?= =?utf-8?B?ZVVPUWNzZ01WN1dSYlpCUjN2WmI5Z0RrVGI4SjJDYVA5Wld1bmhqakEwRnZU?= =?utf-8?B?bEg3L2draGF5SVVmN2lYVHFTMjB6MU9aclZBWlVjZzBkVmhDbnNEZDB6aXA4?= =?utf-8?B?RUY1STdoREdtenlsejFJTHJpNSt6YzRjaXpYL05WOHY1MjdHMlViNDJXM0JG?= =?utf-8?B?T2VrKzhmUHZicHpMUEVZQnVBeVlBaU1adlJDak5pTTRHSHpLaUhzbXZNcHY5?= =?utf-8?B?UUZvTytJSFRwdUpRZVkxNkptVzI3eVBtdUFUNkZJWEx2YUxCdVluczN3VUo4?= =?utf-8?B?Q05OR05uYll5Nld5dlpqYjcybWlkOU9obXgzeE1mS1ZibDhVZlU5MmRYOXFB?= =?utf-8?B?b2RtcjMvay9FbzdyYjduUkg0RUFJWkZsVXVrdnpia1ZoZWxLK2Z5MWErMlVC?= =?utf-8?B?ZXdWa0FzcGRON05JNG9GVnJndVpnYnZ2YWo0bjJTSlJJd2REVXA0RXNsbDd6?= =?utf-8?B?b2pBQ0YwMWNrTk5WdVExR0ZDZkFxN09GLzBOaTRWNkhzamU1VkExN0NXYkVs?= =?utf-8?B?cURPWXdNa0ljKzhnQ0pkQkMxVm1uS0Q2ZGhDT1pDZGdWZ29UbldDU05oSExx?= =?utf-8?B?cUJGM3U2emhwQWxZTURscHNDRDZ4d2d2NEFZbnV0UnFHLy9pOTluNUR2RGRB?= =?utf-8?B?blFkVllpU1gvclA3bWRpZEQreUVicTdSdjIwV2J3MlZ5M05NeHhSa1lIMW5r?= =?utf-8?B?OTc5MFhDUGhaTS9uVG11ckkrWE43TFNVK1ZyWm1SMGZCN2RlQm5CK0dxem1D?= =?utf-8?B?NzB3aS93WUVZQXZVY1JNUitpRXU1QlJwOGJIM1E0ZEVDd2tBVVNXWkIzZGxM?= =?utf-8?B?UnVITVkybDdSVDV4RGtkNVRoc1JnU3RnaXBSdWJ4WGVNNVRHRU1OVjlydDh1?= =?utf-8?B?WXBHcyt3QUU0RGE5TkdnOGVRTE5MaVQ3d09zKzl3bzRLeVFPZlhUNHNtaGt3?= =?utf-8?B?TFB4N3dHQmdQenI4dVIzWlBuVktkSFhDc2RFcFZzcnI2TW13MVRyYWU0MEdF?= =?utf-8?B?clNuQy9ScGtubkgyWUJ1T1UzZVhFZ2lOaUwraGpSM3V2TU9pVzFXanlpVjdr?= =?utf-8?B?eFlFYll5SGpIY2d0eVAydFdCOFJxbWMzVFdjaTg0c1VUTklDYW5RVlNXd1Jx?= =?utf-8?B?NVFFRlRWZzVURU1PTHlhaVhyU01Ydkhqdm9mandua2pyYUY4Rmp4QldxZXBm?= =?utf-8?B?R2ZsaGt5VkVVNTJMSkh2SDFPaHhTamFiQ1ZJWHd0L0VhamJ3a0JxbW1ydTJk?= =?utf-8?B?ell4WHhqaFR0Ym91WjNETThNaXlCWktLZm51MTBZN3M1UzFzQ1Y0MDVvQ1V5?= =?utf-8?B?SjJRMTNEbWlyT1kwK2x4aS93enRNUGtWVTZ4TDJ1cXhtdFFSWnIwd2ExWTVU?= =?utf-8?B?Z0xDdzAra0VrVzhUK3pPcGgySjJ3UUZjcUl4WGRWUXZVKzR6TUF2aTRmNExN?= =?utf-8?B?VFVmL0k2akRBUm5GUVh4cVZ5cWt1N0ZmL3EzRzJnWjMrMFI4RXJiNllHeDJl?= =?utf-8?B?dTJuNFJWSHk3SmloK01QMTA5VkFheFA1VjNyZ2IxSWVYanhSc3Q1RXRhbjJ6?= =?utf-8?B?VGV5b0R5dkVBUmhnSWI2OUg3WDBiZlFtUGlyTmluMnpROEo3SlU1VHduUERS?= =?utf-8?Q?Yfv/ZZxDnx8BwqYdx7pNEJ27a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8371602a-3bc3-47df-a093-08db9757afba X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:05:07.0505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1bFE3Zo+qbSob9yP1/Ff5Cx2WFwPQ79y895OVkqCLNID9YExKa/WZFidSMfA3mdTGPMnQHLvHEhJu2lUhD4ptw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9355 On 02.08.2023 02:11, Shawn Anastasio wrote: > Implement the OPAL firmware calls required to write to the serial > console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL > firmware interface can be used past early boot and as such the relevant > functions are not marked as __init. > > Signed-off-by: Shawn Anastasio Constraint as before and with two nits Acked-by: Jan Beulich > @@ -20,8 +22,20 @@ > * Load the address of a symbol from the TOC into the specified GPR. > */ > #define LOAD_REG_ADDR(reg,name) \ > - addis reg,%r2,name@toc@ha; \ > - addi reg,reg,name@toc@l > + addis reg, %r2, name@toc@ha; \ > + addi reg, reg, name@toc@l > + > +/* > + * Declare a global assembly function with a proper TOC setup prologue > + */ > +#define _GLOBAL_TOC(name) \ > + .balign 4; \ > + .type name, @function; \ > + .globl name; \ > +name: \ > +0: addis %r2, %r12, (.TOC.-0b)@ha; \ > + addi %r2, %r2, (.TOC.-0b)@l; \ Strictly speaking the - want surrounding by blanks, but I wonder whether to PPC eyes these constructs look more natural without. Please clarify. > --- /dev/null > +++ b/xen/arch/ppc/ppc64/opal-calls.S > @@ -0,0 +1,81 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * Adapted from Linux's arch/powerpc/boot/opal-calls.S > + * > + * Copyright (c) 2016 IBM Corporation. > + * Copyright Raptor Engineering, LLC > + */ > + > +#include > +#include > +#include > + > + .text > + > +#define OPAL_CALL(name, token) \ > + .globl name; \ > +name: \ > + li %r0, token; \ > + b opal_call > + > + _GLOBAL_TOC(opal_call) Any reason for the leading blank here? Where necessary I again think these small items can be taken care of while committing. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:08:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:08:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578613.906195 (Exim 4.92) (envelope-from ) id 1qT1q4-0007xi-FB; Mon, 07 Aug 2023 15:08:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578613.906195; Mon, 07 Aug 2023 15:08:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1q4-0007xb-CS; Mon, 07 Aug 2023 15:08:08 +0000 Received: by outflank-mailman (input) for mailman id 578613; Mon, 07 Aug 2023 15:08:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT1q4-0007xT-11 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:08:08 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 36bf6932-3534-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:08:07 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9355.eurprd04.prod.outlook.com (2603:10a6:10:36b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 15:07:38 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:07:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36bf6932-3534-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCj/hEMBUbZdEcIFLR2gFbHxlA91nkzH94BT2QMc2ILTyVlNG1czcOVTnEchlZYrR71nJ70teOEeMIzkpeKySjq3bCftyLAaByNTTvv61A/7QI8ZlYwD/Z1WyWyGFH4bQKQrMx1iHOsBLdayoeUG41YT1lzl9eslSrwOFK0vSIHT/pWEwWjByNc0pua0cdcyeXTRWZlDcUaf0zpEjv2mAVC06BNXYXez6U3wkwMmnYnQ7j1GlK188WzSSVyGwR6/z0+ocGs1B8gkxLwfsjwMZ84ggJAKrAIOBJYUCy3jMmd05Z12xl5MgE4bpRSmOQjhBJKBy0MQXZYgd1bf0Qj1Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CtkciH7vevl+qXWFJGYHXABbC61JyYKo54rYVn7YO4w=; b=b+evAhIjHv95jHdPo2s1erVk9TUGWvHHS0kuTiB2ndfBSpaCaFAlbbF0XKpF00y+sCyQPXzWv74HDYSfJ9kgJHUXCkbtd+KVk6HELpS8wwsARb/ad0g5jfY8NIT7v5mNeLy8dQdDsHqvE5iK/+nRpCjk83QJu807PuJGWNR5qX4XFO5cLPWjlmGGvWV73RcLTrbaFwebV5V/jASf0WlBa0zwNGQDPI4HEse3f/FNOGKzuf0pE2urgZ7QJbHszB7yTVgl86qIXuu52lOJudtsc5d3HxbX1C55e1+NuJAIj4QSvIoxw4QkUoRv+38gh54ZrxuKv1vNB6geuwScRahx4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CtkciH7vevl+qXWFJGYHXABbC61JyYKo54rYVn7YO4w=; b=LC/UkmU9Bx8Q7n/gofupiyKIr4udBOcWggaVYvt+0a17EhElHjNekYWJqMdGypx20Go9fX0pQVvU9ORXzb2Sa8Ut3PPHz81Jp64l52Z6QAdQ2BHfZbyQKBUndWrbWFND083rDvyFOLMhKvi1M6X5tBHB+hDgaBcUEnInFZBT04HWlLTA6pfE43eNslGeDFhjbw2UrTXD0pAmPC6dT4Kg0/aZhajjJpLA9AA2p7YzvmCi0xzV45nPjiFc7NkBcik25DM+hU87rUrWVp4BYTGeVLwg6QmGB6g96480Uf7NZsOEJvx5fB6fLNfjd+l58W4BKiREyn7MkIJLAq1CdXtFLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9441c47c-a573-767a-f3a1-649f09f6f43b@suse.com> Date: Mon, 7 Aug 2023 17:07:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9355:EE_ X-MS-Office365-Filtering-Correlation-Id: 63c5e3eb-74a0-4f31-25f7-08db975809a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I8guAqG0HB3o/NYrtWQrOP0rEBGx5dnHvRQwXFAETME8VS0hh5OrL+s5WVzeq9LcjCG0XovAj+UYxQmS2I4XUiHqPfJcnmgYhoXhIFzQRmEy8W9EVhnOxosuuHuHKrMpQkLAogxVCZhg3WlYHiX0XWltiC4SJY39LzgkuTXvpNBtJSK9DAKlLV+q3usfWp3L23tz3hgHstyclmuxi5Tih7fJdIf6ZaUJvD5Y8D/Wdw33CfVb4xr09uGtehk0B83z+ZMhO/R43ItHK9dSa+OWze/lkr+wrqDs3mwHqKVcteu84C06anLWADMWxyCN3eYfhpZwy6gZFgy63XlzV88Cs81LmjryvsohiTr/sOIxr2KMAwyGXgnuLTG7diCkbU/FKcButMBfrV8h29/q/1aVWGdzrMcEsG1NxMMhowiMHVD5BlIF0Sb+NKahStdTa/974xspIJhXeDfFh6IKvZK1R4EZQ2iM1+ZfXX0aWCViQohj3souKD8PGIFDFqcztEEjGDkDinyLctG6xVPwPd0j57UsLhf2i1hOgyf/kDDyQ0V/SBLY06SlrTSpUJtjIlVrQu4a++OzBPMiXnOTQHjTihIkIIZaLbW34H3noNRS5/XqYPr9EwKHNzRLA9zdPmh2ly7cOaeThy8/ZedzlORfQw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(39860400002)(366004)(396003)(1800799003)(186006)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(7416002)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(478600001)(31696002)(6506007)(53546011)(54906003)(38100700002)(6486002)(66476007)(66556008)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1poTW5pdktaY0ZqcmJqMHVaNFloVFQ5UVhyWkJMeWFRL1oyZW9rUWdNMUxC?= =?utf-8?B?SnRBWDB2anB6RmVKQ0dEYVlyMmFVRys2czZjVmNkbzkzeWJOdGxHL0JuVDEv?= =?utf-8?B?anFtRTlBaklUZU9oZEZYUjQ2cDN1UGhqK2pYOUs0WjBhQ003bCtSYVZjTHh1?= =?utf-8?B?L0dPSzUvaE5yYitMRGdlSjFuSHFpVEp0Sk1EYWJ5Q2wwVGFicjMvRVZWNmE2?= =?utf-8?B?NkpMR1pUQXJyckw1U2k3cGtyUUZMa0QyOW9SWFE3eEtqYXJ0cWovakgvSDJR?= =?utf-8?B?eDlERnNlMDFKbytleUplckU1MEtnZVI0a2x4d1ZRZzhXZkd4aGNOUHFYN3Ri?= =?utf-8?B?MUVDYnl2YitGL096OXJLMVN3SU5LdzhNRkNvV1QrQnNENU9kczMvZkNVZ2JW?= =?utf-8?B?MS9TTm1ucUp5aWRibWNsZXhFOXBjeU80R2NEWXhMSlpFZlU4RUo2NTFDQ0JB?= =?utf-8?B?UTd3ZHM2WjJid1BqTTVEVTVrM3ErZjBkN1h4aDN4bEtFclZidDdTbGpjN01I?= =?utf-8?B?VVdNRXhnalNFRFNURldXd0kxRDBjbCt0a05Sd0syREh5eWhxTktENkNYQ0tE?= =?utf-8?B?Uy9xWEpqTTBJb1FwV2p5YmRvR2FDa0dJa2tqNjM3eXN5VEUyeHppM2taUU9s?= =?utf-8?B?dXRaeWlYdlF2RFhPZHNQME9sbnBpRVcwZHBnMllSMk5qS1EzMC9jdjhDcEdz?= =?utf-8?B?QXp1eXdzZE1LaEN6RCt2elVZZWVsSnhLamVGcmdTQTNKaGJ6NU1VQ1hTR3d2?= =?utf-8?B?bnlMS3cxZ2tHWDRFL2kwSXFtd1BLWkhCQjMwRjltOWx3VithZ1VSbkI4c3BH?= =?utf-8?B?QmFkd2x3cE5RQ21SVVkyNGVBWWZpSXdCTUllYjhHRnI3b1FYWGRRTzIwcVRQ?= =?utf-8?B?UGRWeTBJeWptY3RFc2ZrUUNLdmd0YkxCbTgvd2k4OWRFbTVrS2VmVG1oeExC?= =?utf-8?B?RGxTQjA0L3RNdUkrVS9tMWV1cEhsMEVlZXlzRXlLeDdHSUt5T1lrTmpvVGtG?= =?utf-8?B?S09ka3M2ekpOV0lqVURTQWJYM0tOdE9QR0JOMVVFYmtJS0diVVdlajl6eC84?= =?utf-8?B?UDI3QmI4MnpNbEVyaDUzYUtON0dUQS9TQkZSKzNvbnhnV0VKRlovTVFEamVy?= =?utf-8?B?V01uOVc5N1JoSVR2eENmMHJCYmZVbXp2Q1c4YnVkakdIdkRXaStxa3JhUDhp?= =?utf-8?B?WnZORnNleWZ6c1hIUlJ6blgzUHAxbjNRcXRsaDVNOUFVbi9mVW1SZkNSei9O?= =?utf-8?B?dWJKWkx5SUJVYzVnR0Q2U0dtQVl6cnFDMitsMHdXMmxyOVFmWVR1OGhjeXIv?= =?utf-8?B?UFNhMk1WQ3BDMEhiaVM3NVoxK3dWNEd4emM1SVRSdnowVEgvRGVqVk8xVHZ3?= =?utf-8?B?M2NQUTZHYmpib2hpQ244SmFpTGJnQlB6U01XM3dZRHZBUGpWK0o5c1J0TitM?= =?utf-8?B?aXEwaENzbjV6SVVLRTJtQXBlVVhRdDdnbWthbUQzRVdxY20xR044Z0lGUERX?= =?utf-8?B?dXg3WFZvam54MUkvNUdlQml0a2pBT0Jka2M0K0RUcDc1M2lyb050Qk5FVjdo?= =?utf-8?B?eTRKTGxvNGMvU2pydVZVaFNUaWcyR3ducUxSVXlpYjlnb2xNbHRVcGNNekVY?= =?utf-8?B?VEs5WVFqWjB3bGp1VVBFR3BDRGhEOFlmWm1UOThUbUErUXZwV2R5OXJDam5z?= =?utf-8?B?VENqOHg2czBpdS9QK2UvbEpIRFcxOFlPR3N3SHU3QWJDTG9Qc1djTnNNMzU5?= =?utf-8?B?T0JPd1kyZWlNYmxQdW8vV2N4TUVtOXkrSG9TY2g4bUhCN0U3SjdLVXIxalBK?= =?utf-8?B?L3VKdlNlMm1sUncveEVrQ0JOTlFjdFpVNUVxQ0FHZi9kM1NnQ2ZuanZwVmJ1?= =?utf-8?B?WGZOQS9HOWkrQVRrYzBXVU5pY2NrOGg0ck5QM1AxbFE2Rk0zN3BjWXIzS1FD?= =?utf-8?B?UURzUiswcGVBYmFNVE9ubmhRUmZyWVN2WkszZU5PazJVbWhHa1pUbUdDc0NX?= =?utf-8?B?eUtCVE1NSm5IbWw2U3JvNXRvMGhXa0NOWWNGVElqTmFlbUErdXVYYU9vcFJi?= =?utf-8?B?R3F4ZDJzWjh2NFhzZWxkWEVhNHU3dUFLOHB4UC9YbVZ1SGhsekdSTEdYUGJK?= =?utf-8?Q?C/jt0yB4iFhTIHvVeWNpy3bOZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63c5e3eb-74a0-4f31-25f7-08db975809a4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:07:37.9036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K6XzMGFca11Id+LqjuJg6erec421krqoA1A9cBsp82amzkOZ/ahjHla0OUakj6eZkPNbohH0RyLtIud4mSj2hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9355 On 07.08.2023 17:03, Nicola Vetrini wrote: > On 07/08/2023 10:09, Jan Beulich wrote: >> On 04.08.2023 17:27, Nicola Vetrini wrote: >>> The variable declared in the header file >>> 'xen/arch/x86/include/asm/e820.h' >>> is shadowed by many function parameters, so it is renamed to avoid >>> these >>> violations. >>> >>> No functional changes. >>> >>> Signed-off-by: Nicola Vetrini >>> --- >>> This patch is similar to other renames done on previous patches, and >>> the >>> preferred strategy there was to rename the global variable. This one >>> has more occurrences that are spread in various files, but >>> the general pattern is the same. >> >> Still I think it would be better done the other way around, and perhaps >> in >> more than a single patch. It looks like "many == 3", i.e. >> - e820_add_range(), which is only ever called with "e820" as its >> argument, >> and hence the parameter could be dropped, >> - e820_change_range_type(), which is in the same situation, and >> - reserve_e820_ram(), which wants its parameter renamed. > > This one is defined as > > return e820_change_range_type(e820, s, e, E820_RAM, E820_RESERVED); > > so I'm not certain that the parameter can be dropped from that function, You're right, it can't. I didn't pay enough attention on the interaction of both. So renaming it is here then as well. Jan > because the cascade effect > would eliminate the need to have a 'boot_e820' in 'xen/arch/x86/setup.c' > afaict and since the comment says > > /* A temporary copy of the e820 map that we can mess with during > bootstrap. */ > static struct e820map __initdata boot_e820; > > I'm not sure it's a good idea to alter this call chain. > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:19:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:19:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578621.906205 (Exim 4.92) (envelope-from ) id 1qT20e-00015n-EH; Mon, 07 Aug 2023 15:19:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578621.906205; Mon, 07 Aug 2023 15:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT20e-00015g-Bd; Mon, 07 Aug 2023 15:19:04 +0000 Received: by outflank-mailman (input) for mailman id 578621; Mon, 07 Aug 2023 15:19:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT20d-00015a-Ab for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:19:03 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20620.outbound.protection.outlook.com [2a01:111:f400:fe1a::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bd0f0fe8-3535-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:19:02 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB8014.eurprd04.prod.outlook.com (2603:10a6:102:c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 15:18:59 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:18:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd0f0fe8-3535-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FH44mVrjxE8g1SyBAyUlOMQOvkc5prJmj7FSKLAIFa3ih609UA8VOWsuMsTMbaBiNDFeYALR3IlsgRjFqi5D+LtZF9aEZf+eGFs/UwkqNyJ4HOjNwhO7qBfQziyI0E+sr6pVZVgbiTgS+H9vD8rxG7tJ3fnl9thXBZeGUcoEHAiTs1y5xBXPoual9W/84Tg6q3FQmDZg0VAtrkUQDOdOVcQdgit8V8TR//VXnEbMPWm+UOFiNK0XX9grpGo1wRW96HhYikbB7hgmyykkZZgytT/QLLX4XXvOdYPJbtK7DDUIkHb9A9AzukYDTrgPGanD8N/hUeYAtgriA5fOjmVNtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tzdCfVim1ytrX1tr5NtU841AKoz9XTJNWGUYa7yphwc=; b=Sk4/P+CVpP4UN3MO25hGGSEvxpZ61ujYOSujffgtoLvwJq+gHhSAhwLGsSo36mYH746g47sDUIK/Agbmejjt2LWeOJHVFYEoKWU9Z3ZAWmhYIzXqyxOZlBfQ/AoZQ6L9zDf3+PG0H3LdCp6leYpVBBnzwUbzJ8cm3XDfJKDuWmduskkXWPTSnXrehtXPambQUWTWrmYkuxjVT1jkFVBnm4g4LPDYb9GKqnyc7A4HT3RJKPQ+9vzZUOj+6vlpl+TEOAksyP+F5KT6gMjtlbsAxPIkEQE5ZnE70+vxmMY5mRM/DlZKo+G/KAx43xo57VJiUY34rppkaro2/PsNi34xVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tzdCfVim1ytrX1tr5NtU841AKoz9XTJNWGUYa7yphwc=; b=4VFzX9fnURz3JFVJq5281xXqMUHPVfHblc0Ijs0RkF5fBpUNJMhgOA5QLaAL2O2Bsxylq2yLH+pUuy9sYNWVOUCw5vrw7Mp8hAIQMGfFdGtLNsV9pbuDZ1AozwGsPLLBreha9z0mI3tYuR5Q54toVtQ9oip7EBY70OhbKpgV22HAsZoJMGDSFl0h2s4wSyv+1sU0RWqSWEkRiP1yiXwDR/nODnizZ/myVJYhUrOwDxe/Sf2yg0UFw0djkRZD3LriBWVSB3xExtnyjQIyg1qRyW1JfKcDuWau+e+BpG0JpzyDDFKgyR/qJCXUNCvt00g7bxz6pdwvpJtTMR6tupumEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> Date: Mon, 7 Aug 2023 17:18:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/4] x86emul: support further AVX extensions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB8014:EE_ X-MS-Office365-Filtering-Correlation-Id: 6999280f-4f4f-4054-dc5c-08db97599fd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XTgcwK/TL64ntH3x5LH4IeMUysqk+3h1WIzP6BKwagpdhH446sr+URA5cQfXOMCUSg/c4bRsaiaPtX0FlhhUKSBAITvMxBBQG0lyjggvf1JfVCtNQoF6RQn1tEPUrg/foupfZ0zHMfqk2cl3Z3dMhfryEytS4KuD7OV1hSfdycV9HRbUgQhNEwvyTRGT7D+HjUFizwh01nUDNIEHO6+5obVH3X8VEGwjUTQB9pJLyzZYq9mlebYNzwcWPAC4I4pFkWjRxXxceq6ZF3NlkWlaPCkkPi+Mhkjq11ysBy6yaSrT9vjmcRbIY0lrqOxsbyUeAMuZ6k0xiaQJ0jo2ORQIU21lQH92Ns5YujV8fwyfFBsgGPxkEC63wX+2lsy++lt3EJZiCGCiBTErqBvM20rotPTBgXuPh8MHJomtErUf997v4FUuHjqxD9UzRqHZXsxmRZF69OJ+c9iPwJejO0O6QjkUt0doLLTVdx4f0LgPPDosgqT0nahyUz7TYZnmvSRfR2Vc8UqbJMoxMZokJc2NHc+8JG7jy0fy3qTlOnjfhpPoN9WsQ1O7j6puAcHBWWc1okQ5z9ynlTk44qU3M01cr8sEnFErA1pCt+Q21BAjcVE5JSJ8H5GRmLmBK5tl2Tv1BdCKK98GT6XK5Y1IPcPwjA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(558084003)(478600001)(6506007)(8936002)(8676002)(26005)(38100700002)(6486002)(2616005)(5660300002)(36756003)(2906002)(83380400001)(54906003)(31686004)(316002)(66476007)(66556008)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEdaSVkvRStFSGRmMnNYZXJCbmhxakNZb2RlODQ4c0RYcGRodWVpNmhuL1pV?= =?utf-8?B?d203UFc5WklkUXA2VGQxbGw3dVZkSER0akdiVTdibjdsZkdqR0FYMldDTXNv?= =?utf-8?B?alFBV0hlcDRCMDg1NGVJRnhrUmczVk4wNk1VWUwwbVREaXNzZjdCNzdRam1G?= =?utf-8?B?VWtTQU0yclFEZTR3dDhFanV6NEYzdlRUUEUxcFEwTGtHTGlvRXhLSG5DKzgz?= =?utf-8?B?S1VtRjAvcloyNDV3T1RkMFFQU3VyYXZkNnlTSWRhcEZkUEZvd2QvSjBFTWt0?= =?utf-8?B?UDU1Z2hLMjFibWVHRXlvV2FUcWZpNTJibERrQ3FBZzRnbkw0cWs4d0xucWpq?= =?utf-8?B?b2NvUlEyNFhGaTdwYkZRS3NtNVhJaGpuaVkvNngxeVl4Z1lMVzlJNUoxeFVQ?= =?utf-8?B?U05hVkZ0cDlIQ3piQUdsRW5ZdEl5dmJSQ0ZaZkl6TW84d2JMaXR1MG5CcWtm?= =?utf-8?B?bStCaTdyekg2azE1enQ1MVV3MUNrNFgyVzBsYThnb2FUZ001aSsrbVM2VzJG?= =?utf-8?B?a3lqSUdYcVNzR3ZFVFdRaXJNa2p0LzIrK1d3YjNMU0ZGc1ZoNVBrUGVHSnlS?= =?utf-8?B?dkdTV1AvTnFpUjNZcE1IZUV3M0JrRkU5dEFaT2RVcHJURENnQk1NYzhjTXcz?= =?utf-8?B?YW42cUZRUm0xdUxjaUZ3eVpPS1ExakpDSXVQbjIvNXJLRnVQekFMMVpGSWpB?= =?utf-8?B?S1FrL1dSWjVVRWI1Sy84aEZBLzJtSnluQ09PVlVsWnF2MVA0MWxnMHdJRENk?= =?utf-8?B?b1BCc3J5UFR0emJVSkgvdEI1ZWxtaXFoWSt0ejFmQkJIQTk0NU1NclZ5Z0lP?= =?utf-8?B?bjBia2pNS1ZOcWdlUVBleWRNV3ptUlgwbEV6dUNzYVdMRm41WnhyQnF5R3pU?= =?utf-8?B?UVpMblBQOTNINENvcWNFVGo3UFpPeXZvcDczT25kaWtPbTgwQW1Yb0pwOHRz?= =?utf-8?B?UWhxbjBQTW9IbjZnN1QyRzhwdytsSXpETlFOQVNqOHQ2SkZCejlkMmV1SHNm?= =?utf-8?B?Y3RjVkEzZ1B1WXpQM0UyWkNyVjdaTThUb0hrYVU5NHFZd2JpREZUeWxRbDRy?= =?utf-8?B?dGx6V2NIUlRNUndRU3RQMmtmVXlkaDdIa3JRN0pSZDVqRFhUd3puVzlZTFZT?= =?utf-8?B?a3hrNUJwWmNOajdiR3RHWkp5MHU0cHJqTVY3b3lzWDRwSGVWZGRsR042czhu?= =?utf-8?B?MDlEZUJnUm9ocnhSWUltK2RyT0dIR29XS3NTYXJydGNzSlFhd0ZvZW1rL2Ez?= =?utf-8?B?SFNsOGxHellieFRsa3Bnc21RbVhnMjNueXI1MC9ZR28xdkorZHcvRUQ3STlv?= =?utf-8?B?akY4WkJGT3VGQS9MWEJhZ2c3UlZjZmQ3eCsvaXpFakFVVVpzenZUT2tVZkYx?= =?utf-8?B?aDV3NXE2ZEFkMkgrVDdQaEd2MVZ2VEVBck5XaFY5MXlIaWtDcHl6TTYvZ0xr?= =?utf-8?B?emVYT1grTGp2dU5LWGw4d1B5R0JOSnNkQ2V2SmVoYmpLQTdRbTZEbE11Tlpt?= =?utf-8?B?M1dqalNhc1lBZXFNd21SR1doWlE5bDFJOUt1ODI2K21HTDBrcG9lek0xUzVI?= =?utf-8?B?V0xKc1plNmhkYmMyRzJPVXE2b2xqMjFtaU1jbHFXOXhFZVZpYVRvNUt0enRQ?= =?utf-8?B?a2k5M09UWGc5MGQ2STRDUWpSMjM2aml5Y0o1WUYyS0gyU0pDK1dZblZYL010?= =?utf-8?B?WFB0alZXQU41MVNFelB3SkZpSGdKaWJtMDIxSis4Y1lRMG9uNXRnYWplUWR1?= =?utf-8?B?bG55TzlqOFBrWm1QenJsL0R4b3lORHlPQndVeHUxejBVb1FTRXhoVXF3WG9C?= =?utf-8?B?VEt4Zms2L2ZjdmJpS1dOcWtneXVudnpBaTVVUVBGdnNHS005c3Y1UnJMa1U1?= =?utf-8?B?bDJKcGpmNm44MjBaVkhELzhoL2s4dllrKzYvcXdQVlI4SmRtdndSYWFBUDNC?= =?utf-8?B?OFdTNkJVZlZDTmtNaWllQ0Z3U2V1cnF2RTJlYUM3aURDUzBsMW9GNUdOTWQz?= =?utf-8?B?Vk45am5nbm5zb1BIV2RzTkg0SHJBRlRWNDFWRDlYaXlGMEJWaXpTREU4Ni9y?= =?utf-8?B?Wko3T05KYnpGME5IZWFOMnBZRkZqTE9sMEtSSWhiMHF4Ni83NGtabW9IK3Iz?= =?utf-8?Q?j0QsAAQ9BklLMFjFucUVtzxe+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6999280f-4f4f-4054-dc5c-08db97599fd1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:18:59.4114 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ht1qF2wA84vONy2EU4VK5Czsd5ouZRo+C9QNmsV+TWkw+N5bCU2aGf1BoCRfSBTukDV4KE05l84k1IUEraVzaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8014 Covers the smaller recently announced extensions, but not AVX10 (and even less so APX). Obviously CPUID aspects are taken care of alongside the actual emulator additions. 1: support AVX-VNNI-INT16 2: support SHA512 3: support SM3 4: support SM4 Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:20:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:20:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578626.906216 (Exim 4.92) (envelope-from ) id 1qT21p-0002UY-OW; Mon, 07 Aug 2023 15:20:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578626.906216; Mon, 07 Aug 2023 15:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT21p-0002UR-Lw; Mon, 07 Aug 2023 15:20:17 +0000 Received: by outflank-mailman (input) for mailman id 578626; Mon, 07 Aug 2023 15:20:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT21o-0002UE-Fw for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:20:16 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060b.outbound.protection.outlook.com [2a01:111:f400:fe1a::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e8e0f949-3535-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:20:15 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB8014.eurprd04.prod.outlook.com (2603:10a6:102:c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 15:20:13 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:20:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8e0f949-3535-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbnsvD/Boyqoq3MKW0QMEt93/cA1fWpa0V7Yua6sC+6fH7k47ArL9aedLuKqZoR7IlhXooSbuXaOXAET+OF7NgLRRaDfsKJ4m+ys7Y3/JbtgxcemzMYLQ6cUXnwt108C+/4Ajg+9N37p5EJJ7bhAbkWQItS+3g50169w12Q+doaqBY/vKkGEkDQitKn832z0ZZ8CMoQyOBpKqdJoHr4COOB/crGvbQREgWCaur7kPWdTzOKlA0231dGIfJ4Mc9mzuo6sVrqJg+eeHPAPtCfJCNBY9aFDm/ixHHK81f7SKmqZ8Ra9ej8Lf/VkBAuYI1w6xCqyLVcRDvlIUZBfLLYHQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UGOOHP5krYVxVKN7ninHexZbAZk3q9DOBXGn5X6bujs=; b=Z3FE96vOcih05YuoHjKx+y0t4yQ2/X5Zehn6DrRHwOB3eD/tQvdJIGEC8GExlHy2gYOF6I/d8HutLN73Z4tGR1pw0MfiLCUErfg5nnMJBIQPsWY0kWNM0itBB1gHsZsQBUMTsxSqUq6JCBlVp9bJh5uxXcVnl9zIo3Gfk8yV83Uw7iTLINriMWotmtL15+wkkDyfiAtjIWhZ7+afEG5uL0Ek36yjCrD51JjygTMRXYDaSkJIOGINbW7wqQq8Usg2uxVxh63CDUMtdU3HAq6mt8WosrmsoQoLtoDNHWHz4+0Zqh7/l3L7rQVGj2Pq576yMDcRVkqvSFsNq6FJ5aRdiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGOOHP5krYVxVKN7ninHexZbAZk3q9DOBXGn5X6bujs=; b=CrIPPxf06n2QGBdKIzCS7nZ6CTcnaaD73TZrNi06NRlNKA8k79uOq/+cG0S+PekIi5BhQU0V2UiDY9KPDm0nlZMVlpdbkqF0u4pjl1ZMuKdPKBmbwELV1epeWvzmJUt1pFeZY+BbCpj8moNXoeu/zYWSMuYRAmN9iVguurqP7Spg37LD62WMIos5W5K1+SvVUEIRam8Ud+n5tIy2S9EdbUPn9Del/UqdIq8pzcLdMuUa94xGoubOJ7XUJ63HGoqUF+v+pgq5VF4CXe9dX1iB74J8nJMGbOSy9gH4IgJTCZbz3cOWIfo65UOvsSkn0hFdNDjy839UBW6psF7s825qXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 17:20:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: [PATCH 1/4] x86emul: support AVX-VNNI-INT16 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> In-Reply-To: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB8014:EE_ X-MS-Office365-Filtering-Correlation-Id: 723d360b-97c5-4a33-54a2-08db9759cbeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bOE5R/VJNuZWazyd+j6sn0HG6R4WeOlm3Lh5LuGo1FLSaKgU+1l66I40dXVSlznKbdw4/+SCRvjuwpKlFLBQfCcTqeaSfyDzZ8kHbiurYn0dNzNpV8Yd0MN9e48YT6x6pUfI4KtOkmQeUbFvuMpuGqaFPsj8CNKxwiaVQIqCJjB3RDyFqmw/5keVt4ZCXajeiCz1esl/Ob3T3gPnEd6JLHdLXveDgUa5hXGdwjglVs1DCtZiJRla4hLHGUekAXJZLAFjwttYloZqhQ9AhwTX8wG3o66g6FR4TTrMKgyjPEjZyppgIkRaBNs9T1I8Q9M0fztQR/izl2faIgrpgvvYzKPJF/zgppxvCytqDBwUFXOPucz4/3qZwBWtzigAR1nmVXAHHcobJB79LrEwmpF1Ylekr0lJ/o2hq6AKIRmrUF5LoRpc4dwuA7nX1p8hUdynzPTak4POxjbbKkpTgUI7OOBSIeEEmzEI6VyEEYCfWJTUsD4l/DLP+wtUiDm9+oXUDgeVvPL/FSw0m39wi6gxwTY7wKCmvDJYvA0G0X0vrvY3TLQJHrDJoKOHTEMBozQbH2kmrDlWtSJuT6CZCVas6amSpZ9pzCuLSPP5YG09vnQvCq02mYJVJVVrZAuQBxdSUxwG5xrI5x0Kt8SoeqKqyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(478600001)(6506007)(8936002)(8676002)(26005)(38100700002)(6486002)(2616005)(5660300002)(36756003)(2906002)(83380400001)(54906003)(31686004)(316002)(66476007)(66556008)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aW1DUTVSTjBGeDdVMTVtaU9GMVo4VFhRbVAzNExyWmM4VlBydXZ4VEJvcldK?= =?utf-8?B?YlRBQ2VqZzdCWlkvYlFjRGlxTCt2cWxXOXI5K2VqVXk3ZWhLTWRjRVFhU1Rk?= =?utf-8?B?eUJBT29rbS9QdU9mKzhvTG5GVHRocUlXVVNKR0FpS09WaWJQZzl2ZVJWQUtB?= =?utf-8?B?aEtKVDlWVWVMVERlalhxb3pORlZaRUlDdEtyNG9mcXZydTJ6NmhQTzJzYzdh?= =?utf-8?B?WTVwMUtmdXRuL1dseld0bjd1QUE4SUtLU1A0SFlYbXo2dUhnRjV5aC8rT3h5?= =?utf-8?B?MFZXajE4emVQYld5bjc1RjBKZzNvektBK2tyWlVMV0xDaWRFUSs4ZERrNktq?= =?utf-8?B?NFJUcGRETUJ6ZTA5NVFNVk1EMzkvSUZKL3dCRWZwSW9FTzh2NGpMSmE1ZDhz?= =?utf-8?B?NnovS2JVQURscnhua3EyVm52SkRjenRPRDZSSkhJVGJ6MW9TN09laTZ3UzNI?= =?utf-8?B?d2VTbncxRWtmY2d2aVF5eWtMVVhYQzkxZU4xWDZuUm1yYnIzaHpDYTVndnJm?= =?utf-8?B?eWtEL2kyTTl2VXN2QnIzOFNVRUxpSW5GRk5FbFNEOXp3Qm5nK3RVMTlZRHpR?= =?utf-8?B?cEtpRVpLNlNEUUlUNGk4d29vVFRYRlI2UmZ3T3VvNkpUbUh1U2E4YVVHM1JE?= =?utf-8?B?R1k1REx6VzBtM3FnbFFYaXY1b21yaFpGemg2bFUrb01KNGxPdnJmSDlYbDB6?= =?utf-8?B?MDA3WkRpTzZ2OVdkNGRRSlVIS3k4ZG1KWjUwNm1DaXlBZDVEZ3h3NDIzd0xs?= =?utf-8?B?cmZ2V1pZVHFDMmpPK1hhMnVVQkJVaHg1Z1pJUnV6T0pYWHVzc0hYemlNY3Zq?= =?utf-8?B?K0NWZ1NuTHN5ckhQY09lZlROQ0tYMDBxR0RoQWhwaTJUbnp6RnVmalNOVnli?= =?utf-8?B?WjVuUm54WHRiR0N6VTh6UTRVNDU3d0FibkRQTXdtWGc0SHdweVZ4ZWxxREJw?= =?utf-8?B?RmpwZ1VoY1VhRWRHbTRNRTRLUmhmdUJxNE4zVUM0eno0VkxjdzcvQkQxTzFi?= =?utf-8?B?ZXRhNVcwMjhreWwzR2Qya1YrOUNyUk5mSXNMSUp1WS9YenEzdmpxT2U5ZGRh?= =?utf-8?B?b04zTG5rLzBJVFdHZC9tRUI1WVpYNFdQZ0pKN0kyeVlPNnNGTU5oNGNNaUQz?= =?utf-8?B?a25tZXRJU2NoRkViTnVQZDdTRE51K1NnOHk5cXhGUEYrbFJnU2c5RTU3TUZk?= =?utf-8?B?VUQ3VWFGaUpwR2d4M3Y0MHo2QWtGNXhWWEp6T0cxbk41eVNuOUlNY0t3Y0ZY?= =?utf-8?B?WEpTZko0NFRCK25ibmhOVXhhMU5Mb2VPa2w1ZEVzelc5ODBPTVNHVXVwZjEx?= =?utf-8?B?eTA3OGpveEtMNC9YU3VHQXIzUXRzbWZ3N0FtMDloc3lZNURhaEhQbzVKbUlQ?= =?utf-8?B?NVdxZUp1RklNc3ZxWnI3elZEVXZKdFVJZEdESHVBcVZxL25VeG50SjN0WFN3?= =?utf-8?B?WE5aYXFVbEdBZ3VJNVlJdGtpc1ZsODdWbXdzREY5YXFVOWJVSXlLMzZ6TTY4?= =?utf-8?B?NWNnYnNCSWZtVTM5YVdESXM4ZXU4Q1FrWTh0emFPSHg2Zkw0V0E2NkJNZWZa?= =?utf-8?B?ekFoR00ydXk2WjBIck03ODBrQXN1K0RXcVUrS0I3UDRmQmQ3T1h2REZ0Y3VR?= =?utf-8?B?bFd4TWhyNkx1L0dBUkRvck1UamwvUDhlRHoxdWhFU1FFVUNHNmZ0ckpsOWRN?= =?utf-8?B?Uzk3Q3pEMWxmdlBsYitURkZyd3hreGNmNXhZQlpQSUFuV0YxbThMOTc5UlRB?= =?utf-8?B?Um1HcXdHcFJSTVhaZ0lrRUs5NmZXcUdiQWxSSUc3Y01WOGhBVHFkK2hzSWxC?= =?utf-8?B?MTl2d0xYb0pwem9tdDJRWll0WS9LVGM0UkI5L0FWR1lwRkVqdkFMWU1rcWt1?= =?utf-8?B?K2pJeTdMWUNRcGRKb0kwcVBSOVAzU3RUY0NCUG8ybEtWWmJXZ2QrejVmZTNt?= =?utf-8?B?V3gzbHdydmVPQ1BIc0d6OGluWDE1OHR1YUZsbDh3d2pNY3ZJRTFPTzBGdjdX?= =?utf-8?B?OGhFU2d0eXlkY2laWmVTc1lyb2dNSG00dzFHb1NWM29GbExLOWYybk94TTRt?= =?utf-8?B?SFhBTlpqZkVLQmJkS0o2ZWdDOWFadVhZeTJyNUt6Nk9nN3BnUWFsU0RUTWc2?= =?utf-8?Q?/DQZ63eeJxm3Ihg86ide34ya0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 723d360b-97c5-4a33-54a2-08db9759cbeb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:20:13.3647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wh4BoECcbDA9mF4aSPXGL+oKUYqP/eeEv4cAGIBdpGIhc0AD+MemHwXmC18ZwKN6R4Bw1z1dykNigylhtxpPvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8014 These are close relatives of the AVX-VNNI and AVX-VNNI-INT8 ISA extensions. Since the insns here and in particular their memory access patterns follow the usual scheme (and especially the word variants of AVX-VNNI), I didn't think it was necessary to add a contrived test specifically for them. Signed-off-by: Jan Beulich --- I'm actually pondering whether to contrive dot_product() for these and the other AVX-VNNI* insns, by additionally performing a horizontal add on the result vectors. Main thing I dislike about it is that everything else in simd_test() would then be re-run for no real purpose. Yet making a new standalone simd-dotp.c also doesn't look very attractive. --- SDE: -arl, -lnl, or -future --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -217,6 +217,8 @@ static const char *const str_7d1[32] = { [ 4] = "avx-vnni-int8", [ 5] = "avx-ne-convert", + [10] = "avx-vnni-int16", + [18] = "cet-sss", }; --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1397,6 +1397,12 @@ static const struct vex { { { 0xbe }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub231p{s,d} */ { { 0xbf }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub231s{s,d} */ { { 0xcf }, 2, T, R, pfx_66, W0, Ln }, /* vgf2p8mulb */ + { { 0xd2 }, 2, T, R, pfx_no, W0, Ln }, /* vpdpwuud */ + { { 0xd2 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwusd */ + { { 0xd2 }, 2, T, R, pfx_f3, W0, Ln }, /* vpdpwsud */ + { { 0xd3 }, 2, T, R, pfx_no, W0, Ln }, /* vpdpwuuds */ + { { 0xd3 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwusds */ + { { 0xd3 }, 2, T, R, pfx_f3, W0, Ln }, /* vpdpwsuds */ { { 0xdb }, 2, T, R, pfx_66, WIG, L0 }, /* vaesimc */ { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenc */ { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -183,6 +183,7 @@ void wrpkru(unsigned int val); #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) #define cpu_has_avx_vnni_int8 (cp.feat.avx_vnni_int8 && xcr0_mask(6)) #define cpu_has_avx_ne_convert (cp.feat.avx_ne_convert && xcr0_mask(6)) +#define cpu_has_avx_vnni_int16 (cp.feat.avx_vnni_int16 && xcr0_mask(6)) #define cpu_has_xgetbv1 (cpu_has_xsave && cp.xstate.xgetbv1) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -183,6 +183,7 @@ static inline bool boot_cpu_has(unsigned /* CPUID level 0x00000007:1.edx */ #define cpu_has_avx_vnni_int8 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT8) #define cpu_has_avx_ne_convert boot_cpu_has(X86_FEATURE_AVX_NE_CONVERT) +#define cpu_has_avx_vnni_int16 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT16) /* MSR_ARCH_CAPS */ #define cpu_has_rdcl_no boot_cpu_has(X86_FEATURE_RDCL_NO) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -435,6 +435,8 @@ static const struct ext0f38_table { [0xcc] = { .simd_size = simd_packed_fp, .two_op = 1, .d8s = d8s_vl }, [0xcd] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0xcf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, + [0xd2] = { .simd_size = simd_other }, + [0xd3] = { .simd_size = simd_other }, [0xd6] = { .simd_size = simd_other, .d8s = d8s_vl }, [0xd7] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, [0xdb] = { .simd_size = simd_packed_int, .two_op = 1 }, --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -593,6 +593,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_avx_ifma() (ctxt->cpuid->feat.avx_ifma) #define vcpu_has_avx_vnni_int8() (ctxt->cpuid->feat.avx_vnni_int8) #define vcpu_has_avx_ne_convert() (ctxt->cpuid->feat.avx_ne_convert) +#define vcpu_has_avx_vnni_int16() (ctxt->cpuid->feat.avx_vnni_int16) #define vcpu_must_have(feat) \ generate_exception_if(!vcpu_has_##feat(), X86_EXC_UD) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6871,6 +6871,17 @@ x86_emulate( elem_bytes = 1; goto avx512f_no_sae; + case X86EMUL_OPC_VEX (0x0f38, 0xd2): /* vpdpwuud [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xd2): /* vpdpwusd [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0xd2): /* vpdpwsud [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX (0x0f38, 0xd3): /* vpdpwuuds [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xd3): /* vpdpwusds [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F3(0x0f38, 0xd3): /* vpdpwsuds [xy]mm/mem,[xy]mm,[xy]mm */ + host_and_vcpu_must_have(avx_vnni_int16); + generate_exception_if(vex.w, X86_EXC_UD); + op_bytes = 16 << vex.l; + goto simd_0f_ymm; + case X86EMUL_OPC_VEX_66(0x0f38, 0xdc): /* vaesenc {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xdd): /* vaesenclast {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xde): /* vaesdec {x,y}mm/mem,{x,y}mm,{x,y}mm */ --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -306,6 +306,7 @@ XEN_CPUFEATURE(MCDT_NO, 13*32 /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32+ 4) /*A AVX-VNNI-INT8 Instructions */ XEN_CPUFEATURE(AVX_NE_CONVERT, 15*32+ 5) /*A AVX-NE-CONVERT Instructions */ +XEN_CPUFEATURE(AVX_VNNI_INT16, 15*32+10) /*A AVX-VNNI-INT16 Instructions */ XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ /* Intel-defined CPU features, MSR_ARCH_CAPS 0x10a.eax, word 16 */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -284,7 +284,8 @@ def crunch_numbers(state): # feature flags. If want to use AVX512, AVX2 must be supported and # enabled. Certain later extensions, acting on 256-bit vectors of # integers, better depend on AVX2 than AVX. - AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA, AVX_VNNI_INT8], + AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA, AVX_VNNI_INT8, + AVX_VNNI_INT16], # AVX512F is taken to mean hardware support for 512bit registers # (which in practice depends on the EVEX prefix to encode) as well From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:20:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578628.906226 (Exim 4.92) (envelope-from ) id 1qT229-0002wy-4H; Mon, 07 Aug 2023 15:20:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578628.906226; Mon, 07 Aug 2023 15:20:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT229-0002wr-1X; Mon, 07 Aug 2023 15:20:37 +0000 Received: by outflank-mailman (input) for mailman id 578628; Mon, 07 Aug 2023 15:20:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT227-0002UE-7Z for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:20:35 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061e.outbound.protection.outlook.com [2a01:111:f400:fe1a::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f43b0c1c-3535-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:20:34 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB8014.eurprd04.prod.outlook.com (2603:10a6:102:c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 15:20:32 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:20:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f43b0c1c-3535-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhRrAuVFGrXQ4ZjiZFwc/9PX+5iUJL9+yyA8u0joia2qzxM43X8yTYJarqjQhjA6C0G1kmKFBuSx9DZz5VuR+lrUC+Ckivt+aGralYd108T71pQk6SdvjGF+inkY4adL9YltuQnb9jpgWhZYKvxbacdPj8aVy6jEQ3QXSFvg4x1il+b7D+u6B8MK3cCxpnHhoxXn+sW27aRwnhZ2jAjhlHrkeT6UR10/siSlOr5rSiaDMsVyx+cpSQYmmJT3H1B/XUusPkjlNR6wCM6zRlRlQutb2dspaVFICOzzTmkYwtjNR5HVL9GP27lCaftHKZ2SQFngRUskSbpkKQy5FCyokw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=chCYjHiB2X502WJCa9ozvQcvLibaEFQQSSLt5qFEcLs=; b=C/FrrOGEZMyqxv+/zC7ofBhI7YNVyUOPQEA6uJdfY2mrVqz4TWNxfiewb8mrPu04Y9GYIvYYpg5/GeHVx1sA1G3TCoyx4SsaUo6yBy64a73vUwV15/23nENbsmEcq04o80CZmjNlBFbDSWfX2KV5HomZ7eWwkFnxqppL1ZhbzGYtouVPiYFYd3J1m4ounylV1vLOCizziZWfNsEUByhlP0Mf18aJsqLdLmDi8wJOHLhkGRSJTpdtFbHhBVfONnfrLjXVwvc1MiTYnbffSNZtuuOyMD7e5rrriQqpUKOzBWEkfZlRwTef7nz7AojS1/DJJY2hu+PG/9gIXmCZ1W0vXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=chCYjHiB2X502WJCa9ozvQcvLibaEFQQSSLt5qFEcLs=; b=Xt2yRSz4PEbXaea7Vt9Rtft/WFqHQ/1sToKrvCFxggX3E79losa3bZ8+XX3Patc3pp5ifEGM72cxe+00YepiEnDBrIHPXtJzaNcUPEbgeYHZ7ttx5lSbAnZ03FSROW4Dq5KioX7N2/13KUEvp5iBMXg9oslVsveKwFhFAXX5A8kEU/yYU6nrMFILiXRDnSMZtfev3ZOtHDEXFYPMQTc4THauNayhfoJv1fbKVsjWwQNKJXfBzTNVv38Y8s5Ek79n9eTfz+PGu+YLvh0G3OaxlpPCCO78RcOJ/JZQ5cK22+efYlkJQQPXPTzjA10xwRwCwdqPKjlRrGS2/CFIttBbTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3a77e584-b6e5-8f1a-d1c7-c4ca0de7b425@suse.com> Date: Mon, 7 Aug 2023 17:20:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: [PATCH 2/4] x86emul: support SHA512 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> In-Reply-To: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB8014:EE_ X-MS-Office365-Filtering-Correlation-Id: 25b5bfb5-30a2-47d9-9550-08db9759d75a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gsgFHMdXv6AUopgztrfhNE8B25nd0dk+wKB+RYRQNmu0Wxzz2c7z7GOViEtR9soEF/QT+iru/JvMRXkQ5bt1xwbQOOFfdy1R4PkB4WQv55e69C8ox9I+i2oU8S1hf91mTUuRPpMKoks4JTKr2Hf89gZML7sV5ZjddUjNvbKcVnenWfXDpx6KpLvj+kqRR5+pTipKL4RT3PyU6g0ew0umq6awuR7W9cbToonZiiChLFG4oXJfcMq9JPj/3W7IJnKMrqH1HGXzx8Xd3f0xvf+qGVwFJ2Y8ZpEr0ZYoZMs8FApbuqPdfXvsz3HkNGaY3n8j8Hx6HXwbaXhXJFj4C6jAeVeftRJ2/S0p2oEqo4UGeRbKSMR7adsFyZT32uM/HDaSqig68nphD631qKsWOm/i5rc2QjxYMHuektOE7Znk8ucUeV6/h3ZOu8seil8IMgSSbcp5G3TNOgEETFqWEE7zoPR5gSxrvtJF5ygosXpTwy/cSw/cvJh3MCzfOCU6Ex16XEC38+r+IdH7ixdcu/T4rJzwztkWUs+qVe1l/Hz5EIceV2far7nxaPy/pAAljOkL4q5aFZNj7H1k20a63R+RjG0D+CwtdIdLunUNnkFurZZAS8W8JxcGrkwsnc2/EkWcwURrWYTmJBHfw8YXrKKH+g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(478600001)(6506007)(8936002)(8676002)(26005)(38100700002)(6486002)(2616005)(5660300002)(36756003)(2906002)(83380400001)(54906003)(31686004)(316002)(66476007)(66556008)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGl6VGNYYjNObm0wbkdaYXp2Y2o3eE5vaTVpdU9HSnpXYkEwNFVXSCt0L0gw?= =?utf-8?B?QkJUaEluY2duZUIyYmlMSFlxSjBNQTIxR3k4emh4T21GQkNmVGZCdFZOQ09a?= =?utf-8?B?dEFGSVNzcFh2MXJRaUllVXUyNmFKTEJ3Z2xoaEU2V21tZEVLd1pqcitVQUJt?= =?utf-8?B?UHpLNlFpMTZvUU1QK244SXRqZll5UjVndHRrSlhvdU1rOGtUSHpPYVF3VTgv?= =?utf-8?B?NHE0d1QvdEtYdzk4MllLUWd6dzJmdnVZMi83dlBCbGZqenNrQU9zR0Zxa25s?= =?utf-8?B?NHdwdEs3MFprMFQ1VEI5VnRURSs5VFNMeDVOdllCL2NlbG5rcE13UFZKMktB?= =?utf-8?B?ZVZHWVllWWJpL1ZuUFZaU1I1UUxYZldIMWt4ckh2b3ZKM2NNeHRSbDRXNDJq?= =?utf-8?B?dDE3N1U0YkErVU1KcmszRzNlWEt5YnU3VmU2WDNNdmlJOTV4dWJqYlhIL0ZO?= =?utf-8?B?azMrY2RxNmxIRnIxbzNhbDZuQVN1TDg2VGxpREgvWCt6eERtajRQMW9nNzcy?= =?utf-8?B?VmRrTlNzVkM3U3VmZ2hHbmkrSlRsSEJrL0lUT2kybFVkVlFocm8zNmR1SGxo?= =?utf-8?B?MW83WHFSRk44VmxaZHljaXR3SVo3NmtOVTVYUUdjRzVuY3dENG5YbW9CYnY1?= =?utf-8?B?NkQ2eXBzZVhnVHV2VjZyRnZPaFBwM0diSmtvZDZpYnRDOHdGaGJQaWlmc0pt?= =?utf-8?B?UVNIeGU3N3Bha0gyakRaMWZKTmJqb2JBbXZoUXNjYkVtRHZKZVJRcDNrcGk5?= =?utf-8?B?UVNzZmYvalMvSm5Ic2k2VmtFZitSMEJNYkc0Wml5a3RwWHo0cUVKNExkZ0Rx?= =?utf-8?B?TjJEZjFER1pPOVc5Y1lEYmo0TkwwalR5NFZscU44Z3JEcVZYLzVRTFNVWDNI?= =?utf-8?B?a2JpWHBGN2twaVRyVnZNWXYzOXBKcnh3Nk1EUWlpWVlHdk5RM1dGa3dkVEJk?= =?utf-8?B?OXQycTZ1REU0RnN2bjZMOStTdGMvbXFKeWtYOFMxaEdKMU9nblgvRHFpYytS?= =?utf-8?B?a013bnVjeFF3MTY0ZDl4ZXE1RTZPNmpmTG9mOXNpVkJKYWZaNHpmWnhCZlVj?= =?utf-8?B?K1RLNTQ2WWRON3J6eXNWWVZESFg1cjdLU2k0aHQ3VkN5bFFocm5pY1hFbmVh?= =?utf-8?B?dGNIWm1HeE01VStJWWxmNHVvcXZoSXhHZEJoZVg4VDc3UVhEY21GUkEydlNo?= =?utf-8?B?YTJVOXJVbzl2STkzOE1jUE05ZWw0b2VQMm81VFVJOEQzTUhBT3ZpKy84S2t3?= =?utf-8?B?KzJvWkpId2xUQkdZWkxoeTRiL1l6a044UVo3ZlpML1E4STF6QlBUaHlVbVkz?= =?utf-8?B?UXRxQS84aTBFUEt5aUtoWmNzQTBkVzNOeHpEUCtKTFlIeklyY3N5aC8wTzZP?= =?utf-8?B?alQyckNUN2V5d1ptZ01KZng2Tjhrdi9sNFJSTWswbG1aaGxld3ViTUpUNVRG?= =?utf-8?B?WVB1S0FLM3RvbTVDVm00YkMybXptKy90WlM4OHNmV0dHL0dLK2FNVzl5SGt4?= =?utf-8?B?dTlWaWZta2tpaUU0R2FRbnJ6WXpOam5ZZ2xWNU5mTytaZHVobEU1T3d3d3Ey?= =?utf-8?B?ek9VTHlZR2tTM0RVQzFTQ1JUMUN5OHM3SjgwWU1mbm9HalM3ZytpYzdFazg4?= =?utf-8?B?VnVWeGV3YVZ5Yi9taXFDQnJCa0NYZTVCWWJFM3VDZFZzZTB5UGo3RVhKOGRM?= =?utf-8?B?ckNKT2YvK0RyYm1FNDFXN0lVbmZadWJnOGk4UDAvZmZkV2J0WGJCUUtCdWtI?= =?utf-8?B?K2JXazIyUy9xcGxlSHN1WjdnV01nSEtieEZmSW5IUlNXVWJyY0pCY1ozY04w?= =?utf-8?B?bEhCNkJmdmZkc0hOR2hXekxFVzYycU5XOHZTMzZiOFQ1WjUvSUdDUkxGcVZH?= =?utf-8?B?VUlheExaZWhZNHU4ZWdrTUVqZXA0NHZ6MzdJV05jZmF4a0hOczVUU1RwRkxR?= =?utf-8?B?b1hJTXlpZnhZQ0pONHZ2UlJ6OEdTaWJ3S0pyZk1tQWc4RnRwc3RoSUFxMDQ4?= =?utf-8?B?SDQrVmQreDNGcXV6TmNaY2FQMDdsT0dVaXhKM2VrVDNPWVlHOFJiZDA2SWpG?= =?utf-8?B?MnZuTC9zek5ib0VMK3VYLzJTZUxFRGg4LzFhZnJmdGcvYjQ3R2ZqNFIvRklh?= =?utf-8?Q?oNKwAnLXVHAXaQrp2XxSuzt1b?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25b5bfb5-30a2-47d9-9550-08db9759d75a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:20:32.5394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kAFsKXT2ZzavNlcgcoShdJIDelcJNNXDLbR46W4K3/eDRx6eYBU+RPYtXO/wqzVvCXR7D/KSDN5UTPPCe5AO6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8014 Since the insns here don't access memory, I didn't think it was necessary to extend our SHA test for them. Signed-off-by: Jan Beulich --- The need to set op_bytes here is a little odd; I'm inclined to move the generate_exception_if(!op_bytes, X86_EXC_UD) at the top of SIMD handling (near the bottom of x86_emulate()) into the "ea.type == OP_MEM" conditional, as it's relevant (used) only there. --- SDE: -arl, -lnl, or -future --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -185,6 +185,8 @@ static const char *const str_7d0[32] = static const char *const str_7a1[32] = { + [ 0] = "sha512", + [ 4] = "avx-vnni", [ 5] = "avx512-bf16", [10] = "fzrm", [11] = "fsrs", --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1396,6 +1396,9 @@ static const struct vex { { { 0xbd }, 2, T, R, pfx_66, Wn, LIG }, /* vnmadd231s{s,d} */ { { 0xbe }, 2, T, R, pfx_66, Wn, Ln }, /* vnmsub231p{s,d} */ { { 0xbf }, 2, T, R, pfx_66, Wn, LIG }, /* vnmsub231s{s,d} */ + { { 0xcb, 0xc0 }, 2, F, N, pfx_f2, W0, L1 }, /* vsha512rnds2 */ + { { 0xcc, 0xc0 }, 2, F, N, pfx_f2, W0, L1 }, /* vsha512msg1 */ + { { 0xcd, 0xc0 }, 2, F, N, pfx_f2, W0, L1 }, /* vsha512msg2 */ { { 0xcf }, 2, T, R, pfx_66, W0, Ln }, /* vgf2p8mulb */ { { 0xd2 }, 2, T, R, pfx_no, W0, Ln }, /* vpdpwuud */ { { 0xd2 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwusd */ --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -178,6 +178,7 @@ void wrpkru(unsigned int val); #define cpu_has_avx512_vp2intersect (cp.feat.avx512_vp2intersect && xcr0_mask(0xe6)) #define cpu_has_serialize cp.feat.serialize #define cpu_has_avx512_fp16 (cp.feat.avx512_fp16 && xcr0_mask(0xe6)) +#define cpu_has_sha512 (cp.feat.sha512 && xcr0_mask(6)) #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -176,6 +176,7 @@ static inline bool boot_cpu_has(unsigned #define cpu_has_arch_caps boot_cpu_has(X86_FEATURE_ARCH_CAPS) /* CPUID level 0x00000007:1.eax */ +#define cpu_has_sha512 boot_cpu_has(X86_FEATURE_SHA512) #define cpu_has_avx_vnni boot_cpu_has(X86_FEATURE_AVX_VNNI) #define cpu_has_avx512_bf16 boot_cpu_has(X86_FEATURE_AVX512_BF16) #define cpu_has_avx_ifma boot_cpu_has(X86_FEATURE_AVX_IFMA) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -916,6 +916,14 @@ decode_0f38(struct x86_emulate_state *s, case X86EMUL_OPC_EVEX_66(0, 0x7c): /* vpbroadcast{d,q} */ break; + case X86EMUL_OPC_VEX_F2(0, 0xcc): /* vsha512msg1 */ + case X86EMUL_OPC_VEX_F2(0, 0xcd): /* vsha512msg2 */ + s->desc |= TwoOp; + /* fallthrough */ + case X86EMUL_OPC_VEX_F2(0, 0xcb): /* vsha512rnds2 */ + s->simd_size = simd_other; + break; + case 0xf0: /* movbe / crc32 */ s->desc |= s->vex.pfx == vex_f2 ? ByteOp : Mov; if ( s->vex.pfx >= vex_f3 ) --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -587,6 +587,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_serialize() (ctxt->cpuid->feat.serialize) #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) #define vcpu_has_avx512_fp16() (ctxt->cpuid->feat.avx512_fp16) +#define vcpu_has_sha512() (ctxt->cpuid->feat.sha512) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6856,6 +6856,14 @@ x86_emulate( host_and_vcpu_must_have(avx512er); goto simd_zmm_scalar_sae; + case X86EMUL_OPC_VEX_F2(0x0f38, 0xcb): /* vsha512rnds2 xmm,ymm,ymm */ + case X86EMUL_OPC_VEX_F2(0x0f38, 0xcc): /* vsha512msg1 xmm,ymm */ + case X86EMUL_OPC_VEX_F2(0x0f38, 0xcd): /* vsha512msg2 ymm,ymm */ + host_and_vcpu_must_have(sha512); + generate_exception_if(ea.type != OP_REG || vex.w || !vex.l, X86_EXC_UD); + op_bytes = 32; + goto simd_0f_ymm; + case X86EMUL_OPC_66(0x0f38, 0xcf): /* gf2p8mulb xmm/m128,xmm */ host_and_vcpu_must_have(gfni); goto simd_0f38_common; --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -276,6 +276,7 @@ XEN_CPUFEATURE(CORE_CAPS, 9*32+30) / XEN_CPUFEATURE(SSBD, 9*32+31) /*A MSR_SPEC_CTRL.SSBD available */ /* Intel-defined CPU features, CPUID level 0x00000007:1.eax, word 10 */ +XEN_CPUFEATURE(SHA512, 10*32+ 0) /*A SHA512 Instructions */ XEN_CPUFEATURE(AVX_VNNI, 10*32+ 4) /*A AVX-VNNI Instructions */ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -285,7 +285,7 @@ def crunch_numbers(state): # enabled. Certain later extensions, acting on 256-bit vectors of # integers, better depend on AVX2 than AVX. AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA, AVX_VNNI_INT8, - AVX_VNNI_INT16], + AVX_VNNI_INT16, SHA512], # AVX512F is taken to mean hardware support for 512bit registers # (which in practice depends on the EVEX prefix to encode) as well From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:20:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:20:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578634.906235 (Exim 4.92) (envelope-from ) id 1qT22T-0003YX-DS; Mon, 07 Aug 2023 15:20:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578634.906235; Mon, 07 Aug 2023 15:20:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT22T-0003YM-Aa; Mon, 07 Aug 2023 15:20:57 +0000 Received: by outflank-mailman (input) for mailman id 578634; Mon, 07 Aug 2023 15:20:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT22R-0002UE-P7 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:20:55 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20625.outbound.protection.outlook.com [2a01:111:f400:fe1a::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 005bc6b8-3536-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:20:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB8014.eurprd04.prod.outlook.com (2603:10a6:102:c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 15:20:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:20:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 005bc6b8-3536-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7EIhWUx9X5MFM82gjzS3N796PCNg2Nx/b7Ir6pVDbp/uVXz5d2Nw6UGZO0VTTmwJAE0K3pqDF+XkzszyuUhVPB4Mp9wu8tx1u6Dom23xSd8xEm+Op40pwzQrtVhhiGUD6DvsLvORXA1BhxLRWIozCsCozEslAvhzOH0wn6qwqp9YUf5SAEwwuXxN1A3C2lDk0HKMstWxk5R3L1SlSg2dVH9Pn5aGNi8C101mqkMHi25G2/ST9CgMmsGY3HECkvZNXnyrqYGWblm6Dkc6I++OnBOUQ5mqxOTn2LdjrqV+2+yVqt0izMgdYvy/XmmPUQWpBaJV4wlwUyDwMYwbp60vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ocRc9efOKOJP+qtfngHzEB0n57W85tzVY14dw9xIXQE=; b=WLiLcxkaw0Ek8Vy4iQDbmagLIhJ3bAWequn+l5sSfOfOQKHZ4EFxf32fzd2KMLrPOs5h67OSlAbGHVEKSwinWNuFaG04pJeSzwNdL2f6sKIzKXC8T1H9HTsD6mkwxo/UtB2ae4otFNGRjxYft8f8uYQQo64zacAadLmvVz7WKaBeG1AjbxzKUo4ylop4Epv8WSp3Wn/mWEWned+jSlWWATeL1ZCIWy1ukhFjEXQvmw9RMI+ND40wa7+/WGHcVo8HNO4z0gy0cKXMwAuif9ZmX/UDyy0/4OQQAPYHefUedbxEM3snewDYYa54WLIJnMP2OUQclfRNyMJWNGQuiE3Y8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ocRc9efOKOJP+qtfngHzEB0n57W85tzVY14dw9xIXQE=; b=I4djyYTaUtunpN6LX87rVaeXayiK0p02oRxc/OwiWRMLH7g/lFIiE5M9pKiuhyqDkhHuoml+cxqEdrii2EX/vecGIwAPc/Dy+2yMgRy/jIjpeMzVfc82R9TukCvePYYLv7J8a+/PlIKmNTl+agZnygRzCJ+FnIwSuEHoPtEbMe76sKdOtkQUHFLT8M/R/lQundREKDZaRNRiSq9EZf+HCNkyT8fC/Zb5JkbjHPvHACv+iBhLNxWPSgRrJ6K0wl/7HsughBVGo4/jn1lMfcmNfNTZ819AKDTK8yycbOFXd66OowrA3UcVbQzzptECqVqKmcIYutrC75TXh/LrNMf+bQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 17:20:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: [PATCH 3/4] x86emul: support SM3 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> In-Reply-To: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB8014:EE_ X-MS-Office365-Filtering-Correlation-Id: bcdb9b20-dd5b-4f0b-dc56-08db9759e358 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EiIDVZZVLe+Ztj5c8zIrt5ANmpysyjb9XP64OcOMR3pmVPzrTJb904jAVGaZRcwGMWVGMCIit6NScqo70ZfNWz94HwQC82FTr0bSLlX81WTXEJBr5R2/kh9+UC4SvlLbS1IdKikt+PgU02w1jhKnRFqQR2K1yrd3oydeuIs+v1Wc6BNc28kKx6P0HnOhfG83wGb9sAP+heCGR4XDywvPvcP+Ge0OQmHWFtGhVMvID7zoXgH7JV5aKDApbgjao4OS6PUlKLXMbok9ktzZPeG8S4DpHMphO4w2CKSERpWbjoRLHuOvjhOndMGg6jq6leS6kMJmrfXWRqxBIG/+wGa5kBq0SRmPbTw5kFx88ONmzo6Kg7zd+b5iuSfZAp6mnSQ5RKRcM96wdg9sLk7fc5wxviqdDZB8RXbepE5dY6SU4KQ78xKV85pS8jF8slrRUCNFFO0itraSNbrlvIJOgjYLd/QJdKOrM2JXwlbhbGiTag7wGX/4X193x0FV48VyTmjgtAaWZpwic/TNiyEGuTq4U5In+QzgoMaHpGfJYI2h4KkQzlE5TWMXr+zBfHtJBgvTzTZKk/YgypUx7WJV5442NWYEz+p7dkem/jZVE7vnfB1jMTsvviSv45TzqMBWBvyYoCSh53TaePekMuEYKTi7zw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(478600001)(6506007)(8936002)(8676002)(26005)(38100700002)(6486002)(2616005)(5660300002)(36756003)(2906002)(83380400001)(54906003)(31686004)(316002)(66476007)(66556008)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnFwQzgrK01CaDRrSFNTR2R3L3E3S0x6ZG1yM3R1ak1hYU1UajJHbS9wVUMz?= =?utf-8?B?M3VHbFk4TEgxODZrbDdTYldFMCt6US91b0E2V0NBUExvc2dQY1dFdEZ2SUJ5?= =?utf-8?B?N3RkV0hicXVTWC9VZGRoaVZFdnhpTUFmSlh3L0Y4STlUUXdlbU1jOUN1aXB0?= =?utf-8?B?YnNESUxCVW5MMTI3MVNlTFI5V0c3dzdoTEZtN3J3RnJ6WlBtekNnaXRUK05I?= =?utf-8?B?dndkdHBTaWl5Z1JIaSt1Q1pmaDN2R005bzQwNWlxWUtZSis4TmU2VWFEamUy?= =?utf-8?B?VytvQUt3dHVYek5KRDBtV2VmTUROT24vd3N2c1dQSEd1alhReGJsMVIweDR2?= =?utf-8?B?a0lEMWlCdDRaK1VwaUphR2lMdGhJMnFqRHI3cEU5VVZIWjNFdHZFSnBqYkFC?= =?utf-8?B?TU51UmJqamxyQ0V6RVlueTUyZWc2VDNSYnRJRjlWTGV5eHZwY1Nsbk5qQXd2?= =?utf-8?B?akxEQmV5bWlMZll6Ull4YUIzYWNOck5Zd21IVUIzNGRVaC9JQ0xLMkFmREht?= =?utf-8?B?ajRic0xmK2JEVUpDajNkQlJZNkVVUWxYMzJJYlBwUFZmMUFSZHArZzdZUkxm?= =?utf-8?B?ZWJ1aWJEMzR0b3Jqd0FneVhjVjFDblAzd1FTY0dQTlZFcE5nbmdkRDd2bVY4?= =?utf-8?B?dDFERmpuNDRRZzhOWVcyZGRtNFpBYU8zRWZjVngvWm9KbFJsTEJrbjVRb3VZ?= =?utf-8?B?OERQTGViT1hRTUtvVXRUUVVYenlFeTJtWEZ2Tytob2tYcmtOKzB3c3FOTlR4?= =?utf-8?B?STJkL1pYTE1Qemk4dXB4KzAwM2Zvemp6MWJBazhVTVVmUU12cDZOTTVIVUhN?= =?utf-8?B?b1pucVZwZDFrcEJNSFFpNnZWcFFWNStEU2ROaGpKRTYvbHRHbWpGQzZ6aGEw?= =?utf-8?B?M1FjQjBDNmlLblJCNC9ZL0FUSzFNWWJ1NkJuSUJCYWpzdld3SmxmajBHanc5?= =?utf-8?B?clNCT216UVdsK2xENlFKN21raEcydEVxUXRmY09TSTVpY2NDK0NDYmtvOWdQ?= =?utf-8?B?OHljeHFLVXNhamVUSXVmL1dmK2JQL2taZUhhMFVVb2VQSjZpOWVNSVpsUEVs?= =?utf-8?B?YXJlMTQvSkdrbit5bnMwQlZQWUFXalk3MVpkRW1DRGlnWVhuYjRpclIzdnY1?= =?utf-8?B?YVBWUFpQUnhvUEg4Q0llQkJBS1lpVTU5TUhwY2Y2RUNaTk93U1RlOTBQb0xC?= =?utf-8?B?Wmh0U3VSOTB6VGQvZWlGcGtDRWN6QzhYTHFjNVA1TnVXUzd5TWt0Rnpsa1Jt?= =?utf-8?B?WjFXV3RyeHVEd0VLVWpOVEtvRGRvc2VLNGNESG54YVZZWnk4SFFDWWQ5OThG?= =?utf-8?B?VjBUQnNUSlNGbmV5TTFwb05UTVp0N0ptcHh3Yk5kckF3RUlRUDJsbFpPVXkr?= =?utf-8?B?bUtZaFcxOFZXRllBU09Vb2szODd2Rk1DN0VzYjFpWnNpUmw2dFpKMXFLU25z?= =?utf-8?B?ZkI5Q3dFK1FzUTQxZHZRMVRMc3VNWkdWYU9GYlUydmsvY2J1OVBJbWRQTVN5?= =?utf-8?B?K0pYL0Q4UEtSS210NER3MVo2T1Vvc3FUZ2RDNXBEMmtXaGhoS1ptZmVsOTZR?= =?utf-8?B?b1BaY1ZTZ0QwcDZLRW90RGUvT1JyVkN6WVV4ZDBJQXB4MHZlSWlRTURtTGlJ?= =?utf-8?B?VkpwdDErcFBGSkRuS0Y3eXZBMVQ3R1ZJaVA2TUhlb0lVZmNkSzMyNGFpVzdm?= =?utf-8?B?eDJ5cTVuTVNoeVA2VWNYSTJmWmRJYS9rV3p4b2liVUhaSkZ1cWZxd21RdlNk?= =?utf-8?B?aFVyUHRMeSs1Nm5PcGFRTEV0dlhmb3lBSHdxL012VG00a2I5SWY3cHRKeGl6?= =?utf-8?B?VzIxU3U5TXE2aThiZlM4dGtOazFJRGh0allyRkxKRFRCdDhLMVNmRHhKYkVG?= =?utf-8?B?UmpaTVM2Zi9JY2hmMmV0ZTFtMUF4WTgyMU9TMFJTRS84ejhVbW9YeUVRTm9u?= =?utf-8?B?TTUzRllxTEFnM3VUZmxOZUd4UEhuclpkTzMzdmF4OGhTZFZOaUlGc2o2eUp2?= =?utf-8?B?Y1lOVnZqeno1QlZKNXFjRkJjV3FvYXNGeDYzQk5pMTI5alNVemhZMjI5eTJG?= =?utf-8?B?MVFDNHBLcFlTNWR1dkNIMWdFRDlQZWJaMEp3TkMwZm1VUlkwenFtcERtbkEv?= =?utf-8?Q?1K1AYYYcLOVTuJd1K2G5206Ru?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcdb9b20-dd5b-4f0b-dc56-08db9759e358 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:20:52.6361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z29IhwEbF31gzUM8zL+QGNNyOnG3/fsyCdaK9wSIFwgm5MfFsP00p8WB7YvoJAdPMoyKGg6eIwoX51VKAyk/AQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8014 Since the insns here and in particular their memory access patterns follow the usual scheme, I didn't think it was necessary to add a contrived test specifically for them. Signed-off-by: Jan Beulich --- SDE: -arl, -lnl, or -future --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -185,7 +185,7 @@ static const char *const str_7d0[32] = static const char *const str_7a1[32] = { - [ 0] = "sha512", + [ 0] = "sha512", [ 1] = "sm3", [ 4] = "avx-vnni", [ 5] = "avx512-bf16", --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1406,6 +1406,8 @@ static const struct vex { { { 0xd3 }, 2, T, R, pfx_no, W0, Ln }, /* vpdpwuuds */ { { 0xd3 }, 2, T, R, pfx_66, W0, Ln }, /* vpdpwusds */ { { 0xd3 }, 2, T, R, pfx_f3, W0, Ln }, /* vpdpwsuds */ + { { 0xda }, 2, T, R, pfx_no, W0, L0 }, /* vsm3msg1 */ + { { 0xda }, 2, T, R, pfx_66, W0, L0 }, /* vsm3msg2 */ { { 0xdb }, 2, T, R, pfx_66, WIG, L0 }, /* vaesimc */ { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenc */ { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ @@ -1490,6 +1492,7 @@ static const struct vex { { { 0x7f }, 3, T, R, pfx_66, Wn, LIG }, /* vfnmsubsd */ { { 0xce }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineqb */ { { 0xcf }, 3, T, R, pfx_66, W1, Ln }, /* vgf2p8affineinvqb */ + { { 0xde }, 3, T, R, pfx_66, W0, L0 }, /* vsm3rnds2 */ { { 0xdf }, 3, T, R, pfx_66, WIG, Ln }, /* vaeskeygenassist */ { { 0xf0 }, 3, T, R, pfx_f2, Wn, L0 }, /* rorx */ }; --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -179,6 +179,7 @@ void wrpkru(unsigned int val); #define cpu_has_serialize cp.feat.serialize #define cpu_has_avx512_fp16 (cp.feat.avx512_fp16 && xcr0_mask(0xe6)) #define cpu_has_sha512 (cp.feat.sha512 && xcr0_mask(6)) +#define cpu_has_sm3 (cp.feat.sm3 && xcr0_mask(6)) #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -177,6 +177,7 @@ static inline bool boot_cpu_has(unsigned /* CPUID level 0x00000007:1.eax */ #define cpu_has_sha512 boot_cpu_has(X86_FEATURE_SHA512) +#define cpu_has_sm3 boot_cpu_has(X86_FEATURE_SM3) #define cpu_has_avx_vnni boot_cpu_has(X86_FEATURE_AVX_VNNI) #define cpu_has_avx512_bf16 boot_cpu_has(X86_FEATURE_AVX512_BF16) #define cpu_has_avx_ifma boot_cpu_has(X86_FEATURE_AVX_IFMA) --- a/xen/arch/x86/x86_emulate/decode.c +++ b/xen/arch/x86/x86_emulate/decode.c @@ -439,6 +439,7 @@ static const struct ext0f38_table { [0xd3] = { .simd_size = simd_other }, [0xd6] = { .simd_size = simd_other, .d8s = d8s_vl }, [0xd7] = { .simd_size = simd_scalar_vexw, .d8s = d8s_dq }, + [0xda] = { .simd_size = simd_other }, [0xdb] = { .simd_size = simd_packed_int, .two_op = 1 }, [0xdc ... 0xdf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, [0xf0] = { .two_op = 1 }, @@ -519,6 +520,7 @@ static const struct ext0f3a_table { [0xc2] = { .simd_size = simd_any_fp, .d8s = d8s_vl }, [0xcc] = { .simd_size = simd_other }, [0xce ... 0xcf] = { .simd_size = simd_packed_int, .d8s = d8s_vl }, + [0xde] = { .simd_size = simd_other }, [0xdf] = { .simd_size = simd_packed_int, .two_op = 1 }, [0xf0] = {}, }; --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -588,6 +588,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_tsxldtrk() (ctxt->cpuid->feat.tsxldtrk) #define vcpu_has_avx512_fp16() (ctxt->cpuid->feat.avx512_fp16) #define vcpu_has_sha512() (ctxt->cpuid->feat.sha512) +#define vcpu_has_sm3() (ctxt->cpuid->feat.sm3) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6890,6 +6890,12 @@ x86_emulate( op_bytes = 16 << vex.l; goto simd_0f_ymm; + case X86EMUL_OPC_VEX (0x0f38, 0xda): /* vsm3msg1 xmm/mem,xmm,xmm */ + case X86EMUL_OPC_VEX_66(0x0f38, 0xda): /* vsm3msg2 xmm/mem,xmm,xmm */ + generate_exception_if(vex.w || vex.l, X86_EXC_UD); + host_and_vcpu_must_have(sm3); + goto simd_0f_ymm; + case X86EMUL_OPC_VEX_66(0x0f38, 0xdc): /* vaesenc {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xdd): /* vaesenclast {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xde): /* vaesdec {x,y}mm/mem,{x,y}mm,{x,y}mm */ @@ -7762,6 +7768,12 @@ x86_emulate( fault_suppression = false; goto avx512f_imm8_no_sae; + case X86EMUL_OPC_VEX_66(0x0f3a, 0xde): /* vsm3rnds2 $imm8,xmm/mem,xmm,xmm */ + host_and_vcpu_must_have(sm3); + generate_exception_if(vex.w || vex.l, X86_EXC_UD); + op_bytes = 16; + goto simd_0f_imm8_ymm; + case X86EMUL_OPC_66(0x0f3a, 0xdf): /* aeskeygenassist $imm8,xmm/m128,xmm */ case X86EMUL_OPC_VEX_66(0x0f3a, 0xdf): /* vaeskeygenassist $imm8,xmm/m128,xmm */ host_and_vcpu_must_have(aesni); --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -277,6 +277,7 @@ XEN_CPUFEATURE(SSBD, 9*32+31) / /* Intel-defined CPU features, CPUID level 0x00000007:1.eax, word 10 */ XEN_CPUFEATURE(SHA512, 10*32+ 0) /*A SHA512 Instructions */ +XEN_CPUFEATURE(SM3, 10*32+ 1) /*A SM3 Instructions */ XEN_CPUFEATURE(AVX_VNNI, 10*32+ 4) /*A AVX-VNNI Instructions */ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -262,7 +262,7 @@ def crunch_numbers(state): # for the XOP prefix). VEX/XOP-encoded GPR instructions, such as # those from the BMI{1,2}, TBM and LWP sets function fine in the # absence of any enabled xstate. - AVX: [FMA, FMA4, F16C, AVX2, XOP, AVX_NE_CONVERT], + AVX: [FMA, FMA4, F16C, AVX2, XOP, AVX_NE_CONVERT, SM3], # This dependency exists solely for the shadow pagetable code. If the # host doesn't have NX support, the shadow pagetable code can't handle From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:21:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578641.906246 (Exim 4.92) (envelope-from ) id 1qT22u-0004By-Qx; Mon, 07 Aug 2023 15:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578641.906246; Mon, 07 Aug 2023 15:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT22u-0004Br-Nm; Mon, 07 Aug 2023 15:21:24 +0000 Received: by outflank-mailman (input) for mailman id 578641; Mon, 07 Aug 2023 15:21:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT22t-0003Ol-Fe for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:21:23 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20603.outbound.protection.outlook.com [2a01:111:f400:fe1a::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10540025-3536-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 17:21:21 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB8014.eurprd04.prod.outlook.com (2603:10a6:102:c7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 15:21:19 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:21:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10540025-3536-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxOFz3syf6hSkSnwsuWllqOeO3420Okc4hkKnIQi7UZr9gGJ2Q6bPME0/m8NRhHKkiDwN/ZTGv4s/lnI/3u27hJBugfqr/4fb6wx1ZFzA2DpqPYLb+C/yRpO4HWTpa+Wa1wx8LXSNnzkPBsy3//gcBDAZ25bJUSiHL9kWpgN/gAUDFjt1w9e9NJhnMrSJiYqeRBgDx2LnwnvZ8UTtEF1Odk1d+L8INAq71689xZBa2+y4vBoduHXp9lI/uGBnDZs6pZUyo3vckl4MTJlB3oF4U9vzDSp2dHVK6lIV2eMi3aOfxuahKtpw9zu4WeDjFsS8GsGfRR/so0QCUcmqnoLyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jhTNq5mY23M6wTZvUr+tr+W7Hwm3yXoZVbgG/A6dibk=; b=VK4Lq2CXDByO1Al2WWJHc4zrsDbTGO3aQuzRNmnNWO67jfaH9V06SYcBO66nqRQueHb3jvSrddhJtwfWxwgGsYVveM4Sl6x0qz7JN0HIINiH1B8J6N1VxExqY9S+GuzJudo8hXmT2cVWH5c3L/2qK8lssdUR58PIowYlUmmffdYJ+CK4B475P/ak8zVZIHnRkdnvn/K5Y0o9+JZJ+gRPJ1aJF1M2EfNDOGuVa//y+G3+QhnosR8GhpKlvAz/ENTzX6hC91xojt5cEJ0bmfkcX/4F/MLG/oyo0QgL7f5WyZRrAMTE2mz3Nzlgjk6bqQ1w9uaT1cX/cNRmEfM+bXTO2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jhTNq5mY23M6wTZvUr+tr+W7Hwm3yXoZVbgG/A6dibk=; b=tV+n5np/D8XBYUMsBRlXFm3hHKsC+x4OiUgIV633vcTGTJf3u2/AVd4uZecwn9iDIVlXEtzPXRMvBXkHN1bwmMURBuHIYl6c1ei+a9JMFs77/sLcWbWH3cunaLRHrN4s8fDu2ylzpCuu+OA7P1Wdoz2L3PE08QbgecqfqittqskIA2uzSbXDKCBYflxEcXzhvl8j5puM1AliNpdhnGvp47pcwUoFhKrsAVyaqwUArEnk77vQ7UWSQ+IIoXmPkyLCquwOgXU2GuFX6bfP35sh32dkQPCpgMWxbsyLFtGDgR8eHJpaQk2wZPWc3V9BACTjN9AZYBBHiY+4N4hyBpyUrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 17:21:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: [PATCH 4/4] x86emul: support SM4 Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> In-Reply-To: <96f70f2f-8712-9f93-34e3-f56deae364a8@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB8014:EE_ X-MS-Office365-Filtering-Correlation-Id: e58b85a0-e3c9-4ff0-9b1e-08db9759f36d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tfNOxMCUMpmUDTGMaO7wSEou8YhMCsikPHTexh9QHK1uVJLoHHo0LgrFoqRM+v2AXlSGqZ6eiP0Gb+7qzQ1u5BumXQsHgEVzAU2/HHiS1EJXRUGp6enRcgCdJemWolgnH3HrZ0evmwOR5pNOpbp2CI9eV5sjjTF004dZ+2eAt0Q3qRpTYCgX/3zxomv6sA9ftSrnHs/v4EQ0J4DZOmbo6wgkorgilsvfs4NNhngFC1Gfi9+rFQhuemtYg/av8bRYyEgUJ1CvW5hzEasGS/MwMPtESn/r78eJsEsP14rJnZmP8WVBg3/bUTdkCQr1r4RsZHZhff6Gr9IOirA2GPa0T6lVDHysYVuT3KtApdTrFdJqFPylAJHcXv095FjD8T39nUv9cRWx/R8UOpvkpr9i58wiRHTDnSjOZAwO/l8GQsb9w5KlTd1RyMopt1cR9mVfAGAV9sqhVP3GTu1MfneDmZVLf74wCg98i5utjcpxkn/kNI7/0WlQRyxviaPOPIa4MZpN3sZkhLW8a1bk47+OvF2zulPVOZg4wEDEOwyqcmxGYK9/N2gBMFQei02NOpnJjaJmU1LT89kfgVMG5ytby9i60Xca8PIQJFKLsH8txercybGaWPZx5nE7gJXEc0LB6t1MtmqDrFoBAQVRYOfuLQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(136003)(39860400002)(366004)(346002)(451199021)(186006)(1800799003)(86362001)(31696002)(41300700001)(478600001)(6506007)(8936002)(8676002)(26005)(38100700002)(6486002)(2616005)(5660300002)(36756003)(2906002)(83380400001)(54906003)(31686004)(316002)(66476007)(66556008)(66946007)(6916009)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFNaZE03U3g0ZlBleS82U0J2a2IzZnJLKzdic2EwajVKWTdkbmpXL29tekRy?= =?utf-8?B?UWtsMUdSOStDaTc4WVIwNUYrUXovZVErR0ZGWGxEd2hxN3c4ZDRMQXk1eXFz?= =?utf-8?B?eGhSZFJxR2tuOTF2Um9hZVNDVDNCcmROK3FLTUsydDdOcTNnZWZVcDlMbld3?= =?utf-8?B?UktJWkJDNkJ2aFAxUGNwSlVrcmJOVHVCckdJTFRCcTByT1FWRSthTWFseWRT?= =?utf-8?B?R3dHOS9YMWVIakhidHBJT3ZvaFhjVlZONitCT3FaMUtTYzlTZzVUQ251NDZp?= =?utf-8?B?UXQxY1JFSlBBbU40dUx5R283NWZCekpCbEhkNkh6eGpqSHMvUzRTLzg3akRO?= =?utf-8?B?SXpTbXk2TTlaMmZTeDdvaGlLSGEzZzdFOU5kSG1jQlhETGN0NmZRMkw4aUZH?= =?utf-8?B?Tjl2YUdlTlRiRC9mTDFSOFpVSld4R1BIeThUcUZsaGQxbnJsd2M3S3NRQVYr?= =?utf-8?B?YnUrbUI0S2FYdk1BajdxS1BCaHorZjJSQXkvWU81YWtsOVJKbUNFRWx4MFJh?= =?utf-8?B?UGJqTkx2YkVGT1dWdWkzM0dQako3d0IxWFY0aUNHY0JLOWw2NjBzS0FqeDB1?= =?utf-8?B?WWFFeUdlNmpQYzhaRkZ2OFdUa1FBeWFuL1ZCbEJVWXBKbEl3dUNaM2FzeS9l?= =?utf-8?B?OFdLQ3RDa0JDdVByd1k4R1I4WGZCcjJlazFwMUJaa1VHdGNEWWg1ckdzZVlD?= =?utf-8?B?cE5Idi9FY1J0aG1GQjJURklPSGhqWHpUbXFsVTZpZUFKT0wwYWhacnBIZk9v?= =?utf-8?B?cGtPdG1Na283M1MzaWlnOFhFc1V3djRvSmNXem0wcnBVZFNBRU9CRHFaVkZj?= =?utf-8?B?WkMySHRkUTlZa1c5akFNS0tyQmFJdXdNMURCSGxURzhuQXRNTEVtL2trWER1?= =?utf-8?B?bXB0Nk1DT2JkMDYxUnpTZzZ6VFAzbXBFckNFalZWL0dqUkZISkNja2VDOS9Q?= =?utf-8?B?K2g0WmZPVjZrSWhrUE5PUTA4cjRVNVc2VFB3NHhGcTJjNnVvU3l4OUVRU01x?= =?utf-8?B?enlQaFEvMEpWOU1wSkFtL2V2bUR1SEliaVdGS2toK3lMTWxlVElUU3k1UzRY?= =?utf-8?B?YVhiR3Z5dGEvWVdqbFBPVS9PVjJ4MzVkM1l2WFZEZVJBd1l5enFneXp3endB?= =?utf-8?B?MDcyZGl2Y0NlR1kzaXA0b01OUG01TVhXZ3FDWjhhc1doY1R0Tkl1ZDVUNjR4?= =?utf-8?B?cHhqY09LVmEvVWRaVm8vQVdNcEh5ZVAyb0JnTUNxK2h1V3Z2QXRrcmV4MDBL?= =?utf-8?B?ekluU1BxWXFYekVhNlBWK3dWbFNxVjNpMmQ5N2QrdEl2enBLWXcrMXNldWxE?= =?utf-8?B?ckFTWkI5NFlHYkJnbXhJZENhN2l2NnF0Qi9uMWdtM0RBQXViVGpyNndldDdF?= =?utf-8?B?OWVTbkl1OW8yY0xiT1MzVnFRdTFMdU9ocGkxUWRyejY4SzdlM0l6K2V4RSs3?= =?utf-8?B?bVNob3dKellRTStZRXpMRUxDR1IwODhXVklYd2JVRitKWmtTNytDWCtJdVBs?= =?utf-8?B?bmlkZFlZODlNM3RtNThOZWlmelRjVzM1bjcrcWE2KzNjdUY0ZVZNODg0WDh0?= =?utf-8?B?OVlwK3JERXo2c255NlJHUWhnOWZsMVNyMjRwb2h3bFZBcFpHWTFncCtQRnYx?= =?utf-8?B?aEpoYjZwaXdNZ0pOMVhJcVBneDhQbmM0QW01V1RQZTNDUGZZYXlHOCtqYWxB?= =?utf-8?B?OThFQUpjZFJQSmtrNm42TVdvcTNhQlVNK3gwUTcxNm52UHZpS24yVHJJTitF?= =?utf-8?B?dFI1UW1RdlFlSy9DOUg3MWlkdCs2UmMwWUZnTTdBNURoN01rdklnMkdCZy8y?= =?utf-8?B?NHBSc2szYVZIOHNnQXp5NXRwVm9OYUJOdkl1Y3Z3OXdIZDJVKzdyM1R1SGVD?= =?utf-8?B?Qy9SOEk2M0Q1SWFMYWNjM2ZkUGtZc0poWStPMWpWT3B0VEtsSEhXV3NYRStO?= =?utf-8?B?TTFRVTE1emMxUXZGcmRLOXNvMWQyYzBXdjMza00wQ2lXTFZTNkRxL1VTazZw?= =?utf-8?B?anRyMitueThxc25VTXhZOXgvbzlLR1RxN29vMzFtSndxVENGQ3Y4WG9WK2V2?= =?utf-8?B?RkhFdTJqTHpNUGZkVlNISm1yTStjejJDSHEvMEM5MkVVMFZYR0FQSkZUZGk4?= =?utf-8?Q?pScVT2jRlOsE5RjhRi6JjF86W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e58b85a0-e3c9-4ff0-9b1e-08db9759f36d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:21:19.6389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E80O/ODRKrtHB0f7XDdOnNXH4+Ba5RQAk0A7vMJUbq0UPjxKgfT7SKsAUQ3DzbEqdk9qFe8cJjI21K/9w0RLGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8014 Since the insns here and in particular their memory access patterns follow the usual scheme, I didn't think it was necessary to add a contrived test specifically for them. Signed-off-by: Jan Beulich --- SDE: -arl, -lnl, or -future --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -186,7 +186,7 @@ static const char *const str_7d0[32] = static const char *const str_7a1[32] = { [ 0] = "sha512", [ 1] = "sm3", - + [ 2] = "sm4", [ 4] = "avx-vnni", [ 5] = "avx512-bf16", [10] = "fzrm", [11] = "fsrs", --- a/tools/tests/x86_emulator/predicates.c +++ b/tools/tests/x86_emulator/predicates.c @@ -1408,6 +1408,8 @@ static const struct vex { { { 0xd3 }, 2, T, R, pfx_f3, W0, Ln }, /* vpdpwsuds */ { { 0xda }, 2, T, R, pfx_no, W0, L0 }, /* vsm3msg1 */ { { 0xda }, 2, T, R, pfx_66, W0, L0 }, /* vsm3msg2 */ + { { 0xda }, 2, T, R, pfx_f3, W0, Ln }, /* vsm4key4 */ + { { 0xda }, 2, T, R, pfx_f2, W0, Ln }, /* vsm4rnds4 */ { { 0xdb }, 2, T, R, pfx_66, WIG, L0 }, /* vaesimc */ { { 0xdc }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenc */ { { 0xdd }, 2, T, R, pfx_66, WIG, Ln }, /* vaesenclast */ --- a/tools/tests/x86_emulator/x86-emulate.h +++ b/tools/tests/x86_emulator/x86-emulate.h @@ -180,6 +180,7 @@ void wrpkru(unsigned int val); #define cpu_has_avx512_fp16 (cp.feat.avx512_fp16 && xcr0_mask(0xe6)) #define cpu_has_sha512 (cp.feat.sha512 && xcr0_mask(6)) #define cpu_has_sm3 (cp.feat.sm3 && xcr0_mask(6)) +#define cpu_has_sm4 (cp.feat.sm4 && xcr0_mask(6)) #define cpu_has_avx_vnni (cp.feat.avx_vnni && xcr0_mask(6)) #define cpu_has_avx512_bf16 (cp.feat.avx512_bf16 && xcr0_mask(0xe6)) #define cpu_has_avx_ifma (cp.feat.avx_ifma && xcr0_mask(6)) --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -178,6 +178,7 @@ static inline bool boot_cpu_has(unsigned /* CPUID level 0x00000007:1.eax */ #define cpu_has_sha512 boot_cpu_has(X86_FEATURE_SHA512) #define cpu_has_sm3 boot_cpu_has(X86_FEATURE_SM3) +#define cpu_has_sm4 boot_cpu_has(X86_FEATURE_SM4) #define cpu_has_avx_vnni boot_cpu_has(X86_FEATURE_AVX_VNNI) #define cpu_has_avx512_bf16 boot_cpu_has(X86_FEATURE_AVX512_BF16) #define cpu_has_avx_ifma boot_cpu_has(X86_FEATURE_AVX_IFMA) --- a/xen/arch/x86/x86_emulate/private.h +++ b/xen/arch/x86/x86_emulate/private.h @@ -589,6 +589,7 @@ amd_like(const struct x86_emulate_ctxt * #define vcpu_has_avx512_fp16() (ctxt->cpuid->feat.avx512_fp16) #define vcpu_has_sha512() (ctxt->cpuid->feat.sha512) #define vcpu_has_sm3() (ctxt->cpuid->feat.sm3) +#define vcpu_has_sm4() (ctxt->cpuid->feat.sm4) #define vcpu_has_avx_vnni() (ctxt->cpuid->feat.avx_vnni) #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16) #define vcpu_has_wrmsrns() (ctxt->cpuid->feat.wrmsrns) --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -6896,6 +6896,13 @@ x86_emulate( host_and_vcpu_must_have(sm3); goto simd_0f_ymm; + case X86EMUL_OPC_VEX_F3(0x0f38, 0xda): /* vsm4key4 [xy]mm/mem,[xy]mm,[xy]mm */ + case X86EMUL_OPC_VEX_F2(0x0f38, 0xda): /* vsm4rnds4 [xy]mm/mem,[xy]mm,[xy]mm */ + host_and_vcpu_must_have(sm4); + generate_exception_if(vex.w, X86_EXC_UD); + op_bytes = 16 << vex.l; + goto simd_0f_ymm; + case X86EMUL_OPC_VEX_66(0x0f38, 0xdc): /* vaesenc {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xdd): /* vaesenclast {x,y}mm/mem,{x,y}mm,{x,y}mm */ case X86EMUL_OPC_VEX_66(0x0f38, 0xde): /* vaesdec {x,y}mm/mem,{x,y}mm,{x,y}mm */ --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -278,6 +278,7 @@ XEN_CPUFEATURE(SSBD, 9*32+31) / /* Intel-defined CPU features, CPUID level 0x00000007:1.eax, word 10 */ XEN_CPUFEATURE(SHA512, 10*32+ 0) /*A SHA512 Instructions */ XEN_CPUFEATURE(SM3, 10*32+ 1) /*A SM3 Instructions */ +XEN_CPUFEATURE(SM4, 10*32+ 2) /*A SM4 Instructions */ XEN_CPUFEATURE(AVX_VNNI, 10*32+ 4) /*A AVX-VNNI Instructions */ XEN_CPUFEATURE(AVX512_BF16, 10*32+ 5) /*A AVX512 BFloat16 Instructions */ XEN_CPUFEATURE(FZRM, 10*32+10) /*A Fast Zero-length REP MOVSB */ --- a/xen/tools/gen-cpuid.py +++ b/xen/tools/gen-cpuid.py @@ -285,7 +285,7 @@ def crunch_numbers(state): # enabled. Certain later extensions, acting on 256-bit vectors of # integers, better depend on AVX2 than AVX. AVX2: [AVX512F, VAES, VPCLMULQDQ, AVX_VNNI, AVX_IFMA, AVX_VNNI_INT8, - AVX_VNNI_INT16, SHA512], + AVX_VNNI_INT16, SHA512, SM4], # AVX512F is taken to mean hardware support for 512bit registers # (which in practice depends on the EVEX prefix to encode) as well From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:22:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:22:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578649.906256 (Exim 4.92) (envelope-from ) id 1qT23r-0004ro-4n; Mon, 07 Aug 2023 15:22:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578649.906256; Mon, 07 Aug 2023 15:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT23r-0004rh-1h; Mon, 07 Aug 2023 15:22:23 +0000 Received: by outflank-mailman (input) for mailman id 578649; Mon, 07 Aug 2023 15:22:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT23p-0004rQ-So for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:22:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32d28311-3536-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 17:22:19 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E97531FE64; Mon, 7 Aug 2023 15:22:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9031713487; Mon, 7 Aug 2023 15:22:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /zcDIioM0WQqUwAAMHmgww (envelope-from ); Mon, 07 Aug 2023 15:22:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32d28311-3536-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691421738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GoN726XQvVM3O4Jmru+mvY7j3YKAGZ0sihu6ZlArcy0=; b=Wf8vbcxp47efBkbpPARn1+tyjp1K9lorjSr6zw+RUXpkkx+j0xlBWJ9rkdEOqOtRtGzpmj uD8r9u5a9VUJhpu4h+I1ovMLnfeBugWTqwj6SC9dbpUGexeKDmpZiY5rwZ8k4P7esevqv1 9h78CD6apzj7JVb1++2c0R0Z6vsTkSU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691421738; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GoN726XQvVM3O4Jmru+mvY7j3YKAGZ0sihu6ZlArcy0=; b=wsLdYZZzxzxpdYpNL5x4TK1cl7YIjiVlFWpaWYUIk0YcmOWEPxN3CihrdAW8Pcs2lZf0+0 FtN529EXC9vkz6Ag== Date: Mon, 07 Aug 2023 17:22:18 +0200 Message-ID: <87pm3yj2s5.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Shevchenko Cc: Mark Brown , alsa-devel@alsa-project.org, Andrey Utkin , Anton Sviridenko , Arnaud Pouliquen , Banajit Goswami , Bluecherry Maintainers , Claudiu Beznea , Ismael Luceno , Lars-Peter Clausen , Mauro Carvalho Chehab , Oleksandr Andrushchenko , Olivier Moysan , Srinivas Kandagatla , linux-media@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t In-Reply-To: References: <20230731154718.31048-1-tiwai@suse.de> <87h6pjj2ui.wl-tiwai@suse.de> <87leeugbxm.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII On Tue, 01 Aug 2023 19:51:39 +0200, Andy Shevchenko wrote: > > On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: > > On Mon, 31 Jul 2023 21:40:20 +0200, > > Mark Brown wrote: > > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote: > > > > Mark Brown wrote: > > > > > > > > It really feels like we ought to rename, or add an alias for, the type > > > > > if we're going to start using it more widely - it's not helping to make > > > > > the code clearer. > > > > > > > That was my very first impression, too, but I changed my mind after > > > > seeing the already used code. An alias might work, either typedef or > > > > define genptr_t or such as sockptr_t. But we'll need to copy the > > > > bunch of helper functions, too... > > > > > > I would predict that if the type becomes more widely used that'll happen > > > eventually and the longer it's left the more work it'll be. > > > > That's true. The question is how more widely it'll be used, then. > > > > Is something like below what you had in mind, too? > > I agree with your proposal (uniptr_t also works for me), but see below. > > ... > > > +#include > > +#include > > But let make the list of the headers right this time. > > It seems to me that > > err.h > minmax.h // maybe not, see a remark at the bottom > string.h > types.h > > are missing. OK, makes sense to add them. > > More below. > > ... > > > + void *p = kmalloc_track_caller(len, GFP_USER | __GFP_NOWARN); > > + > > + if (!p) > > + return ERR_PTR(-ENOMEM); > > This can use cleanup.h. Hm, I don't think it can be replaced with that. There may be more use of cleanup.h, but it's no direct alternative for kmalloc_track_caller()... > > + if (copy_from_uniptr(p, src, len)) { > > + kfree(p); > > + return ERR_PTR(-EFAULT); > > + } > > + return p; > > +} > > + > > +static inline void *memdup_uniptr_nul(uniptr_t src, size_t len) > > +{ > > + char *p = kmalloc_track_caller(len + 1, GFP_KERNEL); > > Ditto. > > > + if (!p) > > + return ERR_PTR(-ENOMEM); > > + if (copy_from_uniptr(p, src, len)) { > > + kfree(p); > > + return ERR_PTR(-EFAULT); > > + } > > + p[len] = '\0'; > > + return p; > > +} > > ... > > > +static inline long strncpy_from_uniptr(char *dst, uniptr_t src, size_t count) > > +{ > > + if (uniptr_is_kernel(src)) { > > + size_t len = min(strnlen(src.kernel, count - 1) + 1, count); > > I didn't get why do we need min()? To check the count == 0 case? > > Wouldn't > > size_t len; > > len = strnlen(src.kernel, count); > if (len == 0) > return 0; > > /* Copy a trailing NUL if found */ > if (len < count) > len++; > > be a good equivalent? A good question. I rather wonder why it can't be simple strncpy(). > > + memcpy(dst, src.kernel, len); > > + return len; > > + } > > + return strncpy_from_user(dst, src.user, count); > > +} > > ... > > > +static inline int check_zeroed_uniptr(uniptr_t src, size_t offset, size_t size) > > +{ > > + if (!uniptr_is_kernel(src)) > > Why not to align all the functions to use same conditional (either always > positive or negative)? A different person, a different taste :) But it's trivial to fix. > > + return check_zeroed_user(src.user + offset, size); > > + return memchr_inv(src.kernel + offset, 0, size) == NULL; > > +} > > ... > > Taking all remarks into account I would rather go with sockptr.h being > untouched for now, just a big > > /* DO NOT USE, it's obsolete, use uniptr.h instead! */ > > to be added. Possibly that's a safer choice. But the biggest question is whether we want a generic type or not. Let's try to ask it first. Interestingly, this file doesn't belong to any subsystem in MAINTAINERS, so I'm not sure who to be Cc'ed. Chirstoph as the original author and net dev, maybe. thanks, Takashi From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:24:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:24:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578658.906266 (Exim 4.92) (envelope-from ) id 1qT25i-0005UI-Gg; Mon, 07 Aug 2023 15:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578658.906266; Mon, 07 Aug 2023 15:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT25i-0005UB-DS; Mon, 07 Aug 2023 15:24:18 +0000 Received: by outflank-mailman (input) for mailman id 578658; Mon, 07 Aug 2023 15:24:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT25g-0005U3-V1 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:24:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77ec7e09-3536-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:24:15 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 80E8F4EE0737; Mon, 7 Aug 2023 17:24:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77ec7e09-3536-11ee-b280-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3 Date: Mon, 7 Aug 2023 17:24:08 +0200 Message-Id: <163937bc59c7a8a5b2f292466090f97b7ec8f623.1691421539.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Keep consistency between object declarations to address a violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional change. Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index 85a67771f7..e3d06278b3 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -7,7 +7,7 @@ struct cpu_dev { extern const struct cpu_dev intel_cpu_dev, amd_cpu_dev, centaur_cpu_dev, shanghai_cpu_dev, hygon_cpu_dev; -extern bool_t opt_arat; +extern bool opt_arat; extern unsigned int opt_cpuid_mask_ecx, opt_cpuid_mask_edx; extern unsigned int opt_cpuid_mask_xsave_eax; extern unsigned int opt_cpuid_mask_ext_ecx, opt_cpuid_mask_ext_edx; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:26:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:26:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578664.906276 (Exim 4.92) (envelope-from ) id 1qT28C-00065g-Tq; Mon, 07 Aug 2023 15:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578664.906276; Mon, 07 Aug 2023 15:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT28C-00065Z-Qs; Mon, 07 Aug 2023 15:26:52 +0000 Received: by outflank-mailman (input) for mailman id 578664; Mon, 07 Aug 2023 15:26:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT28B-00065P-1y for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:26:51 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20604.outbound.protection.outlook.com [2a01:111:f400:fe16::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d386ed33-3536-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 17:26:49 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PR3PR04MB7308.eurprd04.prod.outlook.com (2603:10a6:102:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Mon, 7 Aug 2023 15:26:47 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:26:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d386ed33-3536-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4Tx4je0EZBLvgL0ogTRMdvtVrAQWqgzkYTnuRaeuGkZyD5DXBXDMysPx1vzdJ4PrGuoIa2ThK1BMeMhKWINvPPdOb6Dzkcbq9U+hoiYiIMQ7QKwelqLyQOApzOV2pcOnb4D4sviUIVOuQgm+GwNFOGqLiMsGTiI2jTU7om2nYgwJBqI4/xI99kiDTAEqDzQun9iG7qhzhbevmU0N5FIbT8wwnWi547tHTZ4mTWUQjsqi/hdSI2tJtmo5JhYQXxTwNsqhPndqI7w0FxPiz6kmyRYpprEapxOzEghjJByAcnm3K9L/aCjFnF3TK0XqWptD8MvTJZdOcketew3Vh05pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eM/7S9W+t50LzVxhH4a+l1AKY6Fduweh3gg82cmjdH0=; b=Q3fLu6oUhYR6m/YxabjQ4nYTK5eFuPt4KvEbUzgO8akhJ/YojDPclpHB6jNCnzzBuywq8u1f8BgVxZNhWj7+9J94In7z47AjgAVL32U2OY7LPz+6/qGmM/94O+7izemYOiPB8GVHr9aIC80BAz7Q4h+OeEwh/f0VjT7+s+FY6ZSA0sVgxHl80y7jYonPK6IMozWlFVxspXxVibpfxn6Oq92RJGm7sFDdJdBId7bItBc4jsa93eHb5TkGcDP6jjNYopTk13TDbBsDdwSd6fBLPsdRmM3xCxOp7HSkoX3/dEtgy8v5tOWvq/vl/BjWwcxhdkArM58F5JMeh5THEF93YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eM/7S9W+t50LzVxhH4a+l1AKY6Fduweh3gg82cmjdH0=; b=BM7MDwxtDx1+a7odiUF5rxZHOBLURh4HFHB/JUCmNh2bupbAZ+b6qYdjXDqJnQwCmyUtQn7PARnL+ZjLN0dVCrwZmUot0R8oEMahUSInydO4bhaVyJDGmoqmERpUzHn4vsY0HqxzM/+4OMFX8S4ri5LkSSglWQG6tNZQz4kxTxhrPbJB+n+2ayisjK113DN4I2ch0rt2JJxVN85bb/MU7JD3w8GlGTUNHG3KaKoLjS9RoaNthAxjnUg4yZe+qrQh4SYETzLQbAu6ZTobYDU2nTGnI8Ozu99DVIM3e8paAYrJRYuiTwK92BwKPvQSdGQhacA67b3L1wIlAkc1ESIbWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b95baec-b46c-4862-6d16-b4e6dd38b114@suse.com> Date: Mon, 7 Aug 2023 17:26:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3 Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <163937bc59c7a8a5b2f292466090f97b7ec8f623.1691421539.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <163937bc59c7a8a5b2f292466090f97b7ec8f623.1691421539.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PR3PR04MB7308:EE_ X-MS-Office365-Filtering-Correlation-Id: 8db40283-82ee-4c8d-7099-08db975ab69b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8+Ar4el3ZHJ76Oniq+vlkYLy2ywReLXL1Om3GkWMSSI/9QooGxU7BP+VGQWXvxd6ftzzKJ/xn7OyDqwYN3fiAi4VOESmPztuAzFCB+ppCFgfTB7IWtws2psGNyk7ekWicjBGdG4lWeyWQh5b73ejqGQDz7l0yoPfzi+wWQu4LNNNgoR6B0cJdLYPLNk6MTZ1bTjKxCdI3e3m1psCueE9akiWMfiXBub8A5XDR9fqY9ZRUvZZcOtEVJXOpqVyaq6Tu0A+iQArBMwdH0M99vvWzJXxiZl4mJdqd6q139md6uBO6CyIwuSy151h0lQ6oZcrY8lk6LymFJ4Rz7OW/cEAzRh7jwkku/1BQjbwya3bYGFMcAkGfja+goFAefJzjNf+LIcPNz5ApbpuzevqO7TgtxpfWNyS+nk0cqJ0+eIyrVAE9VS4ecKasxlLWF6BzAfzh5pJ3Ksdy3hi4MmtGiOgfioLKHKhwO0gdIUFGa9wWeNOkiIewrI89K9HMN+KshK7nRVArn6aEyUnWjqNkRwRGRBcltioeJbJxC7L7HgGLGSxI1C6rpe9i4FYPEPH7sP7bOfvKBgZ57xuN4DPcsqKaba/iK1vtSydiyRBEAB/p91kGdLcp+1yN70UVMqG2T1Lvjy5WLY0n4tHNw2O0UeycA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(346002)(39860400002)(376002)(136003)(186006)(1800799003)(451199021)(2616005)(478600001)(31686004)(6486002)(6512007)(53546011)(26005)(6506007)(41300700001)(66556008)(66476007)(66946007)(8936002)(8676002)(316002)(4744005)(31696002)(4326008)(6916009)(2906002)(6666004)(36756003)(54906003)(38100700002)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnNNdk5HWjlGeUE1L2JaaExtaFBlQTVBWERCT2NUS1FBNmpYMElwWnN1VjEx?= =?utf-8?B?QWZXdkdRb3V5ZWRVNmVGUWRwc1JHZi9VakFJZUFTRnRVdDBmOXJzZkJoYTRr?= =?utf-8?B?WUNkMHFsUkdOSmR2aSs2Ym1zem8zaWJtU2Ntbm9NZjM2YkVkREd6endVaFhn?= =?utf-8?B?YjJlekNjWEQ3c3B5b1Z5dEx1WUc5dWtzT3dlcXdmNHpFd1RGQTlrbHA2SDVJ?= =?utf-8?B?RW0yYUVaUS8rK1pKeGRlMEpNZ1JtRlhnWGE2M3k3TXE1ZzNFUmdvTlhoMGRP?= =?utf-8?B?WWRUTmxGQ0t6ajVXQmhEMFg1WHU4NERtbVBZMnRmYWZ5ZXpFZFhDczZOK2s3?= =?utf-8?B?QXhWOGhwcGtQQzhmQzlGa0QxZS9HajBwQ3NSN2NRNHFjRUtlSFAyZC9WYkZn?= =?utf-8?B?UU9hQnhlSGpiZFNGRTlzOXF6VU9kMHplWlpCVUdXVzMvR2F6bnlod0pEYnJM?= =?utf-8?B?MG1sLzVSWTVkdTNvdDJTQmpRZm5wM21KVjRGbStqQ2VaTU4rOWVZVEFIai90?= =?utf-8?B?ZjlsRlh5SmNjdVNtTmhMaGljTXdHZlZMMFYzRlh1MHFIaGVESjAwRlFud2VU?= =?utf-8?B?QktpdGcwRjRkRmo5T3ZHUkNaZnlTc0VRY29jMmQzQlo2NmNEMlRvdlBEUkUz?= =?utf-8?B?ekplYm5kMElxOFIvbXMvUmRrU3RhcjNWcVNPUmI5ZXNpdExRVUUwODFHbmFo?= =?utf-8?B?VHZFdXcxbTExVzd1bDlEczNnalIvMFZzQzFqSzVidGZoTlRHU1o3MkhDK0RD?= =?utf-8?B?S3hTc1VXTFRnRW9GV0Jwd1BESWFrMTE4ZnppYkl3M2RyL3c0aVd3TWJvT3Fl?= =?utf-8?B?L1hsdWFHV1hCYWVEVkxObkgrRkM0Q1pPMXYrdFMvU2JyZVlmOWRYdGRnNFd4?= =?utf-8?B?dEExbDdSRkdHdmx1bFAvRVVYQnZtNWRmdFlidm5FdEEzN25ybWlkRTVLaG8z?= =?utf-8?B?cTFLMlU1V2xYU3Z0bjl3SWJqWStGLzNqVXZNekNQWHNScTVLODQzWmlMOFg1?= =?utf-8?B?Z25VakV5d0ZheXpwOHI3cmM0SkFlaldlWHpoT3JuOGY2clBsY21NeXQrMjV2?= =?utf-8?B?WENlU0dVU2hoUmt6TWZ2MndhVE5YdEdJeHNSWGsvbElVbDQ2WkZ5elRKbFJF?= =?utf-8?B?Z0JrOFp5MjJNSSt2ZTl4Si9qcEJDQ3JuRWozY3NzS3N0eDYvNkdINE0vZ0k5?= =?utf-8?B?ZnVxRzRFOWY2c2hRYk9tR1NzN2h2WjNjaXpySmcyWG5UdERhaTIyZ3VOQ2li?= =?utf-8?B?RnArZ3cyK28vV2xKaUhrdzdqMEwxcVNWbmluWllnd3ZsakNON0N4em1XVTRm?= =?utf-8?B?MERQUmJxMVgxYU1raGxmQTM0a05lQUc1Q2pKUlhNdnVVL3dsK1I4TkdKcThj?= =?utf-8?B?TExwYXhaMjdBbHQydjBuK0YzZG5memt5eUZpYVV1aVV5YmNxbytWbmR5aXRT?= =?utf-8?B?T3dodnJCUGFCWHRkYWxJMFcyMmREczNMaW9hTTNzQ3VrQlB0TGsxcUxKbktJ?= =?utf-8?B?UDFPd2kxOXZMejdHSjNJbmtOZ0tENTJSRkRqOWlFbWQ4QlRRd0kwNE9iVDJB?= =?utf-8?B?cENKbGFGL3VyZU0yU05oTGkvRktkWUNBR3l5bDBrUUp1UCtVdHV4d1lZRlhD?= =?utf-8?B?c3QrUGp0L3hqK05vc2RtVzRicFBWVHMxckUwNmRWMU1wVGdYU0JFUnJ4RmhR?= =?utf-8?B?TWVwNmx5Z0hTTVVSMm92Q1htb2hTQXFIRnV0K2lieEhRYUFJcE1sQVRvU2hB?= =?utf-8?B?amtQYkFtbmkrQVpYWUdlWmZFNzFGYVZ2R0ZVWDhJbzZrbW4rbWtxSXlYUGtV?= =?utf-8?B?T29rdUlnaDlTd045RkdWS01tLzlwblZzV2xqbXlDM2duYlVIcSt1ZnRlN0M1?= =?utf-8?B?NDNaVzVOVkYyKzZCNUVnY2xLTnBxMU1JcWd3Q1dxNEdmeE5IY2FZaWsyejU3?= =?utf-8?B?RzEyZ0Z0ZERBbXUrNlp5RmFDZS9EYk1sMWN3RzA3SHlPcXV1SDJMZElBTGlB?= =?utf-8?B?QWtYRVpQRTdzS2k5SEhHaXMvbGV2OHYwczh6RDR1OWVmcGRMYW9BK3ZJMnRK?= =?utf-8?B?Njg0VTFKVHNKUkhtckxYU0xkSFlucGlEcFJCSncybk0zUXdUMVRHVHpYbk5P?= =?utf-8?Q?t1xy+3yf8eb+ZkbV4zcsiQg/+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8db40283-82ee-4c8d-7099-08db975ab69b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:26:47.0997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NhBrkEhS5p+Bsml4ch5uEABGlr5F/yBYIQENPADCd16LOrAF9TNaHS9i9XeCJpIeQrUzYnn9JlsiT0SnYOhUtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7308 On 07.08.2023 17:24, Federico Serafini wrote: > Keep consistency between object declarations to address a violation > of MISRA C:2012 Rule 8.3 ("All declarations of an object or function > shall use the same names and type qualifiers"). > > No functional change. > > Signed-off-by: Federico Serafini I think this wants both a Reported-by: and a Fixes: tag. The description would likely also better not follow the boilerplate you use elsewhere, but instead describe what has happened and hence why the further change is wanted. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:40:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:40:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578672.906286 (Exim 4.92) (envelope-from ) id 1qT2Ku-0007lP-6Y; Mon, 07 Aug 2023 15:40:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578672.906286; Mon, 07 Aug 2023 15:40:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2Ku-0007lI-3D; Mon, 07 Aug 2023 15:40:00 +0000 Received: by outflank-mailman (input) for mailman id 578672; Mon, 07 Aug 2023 15:39:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2Kt-0007l5-4G for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:39:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20623.outbound.protection.outlook.com [2a01:111:f400:7e1a::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a99ecd9a-3538-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 17:39:58 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8949.eurprd04.prod.outlook.com (2603:10a6:10:2e0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Mon, 7 Aug 2023 15:39:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:39:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a99ecd9a-3538-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n83PtR4euJ/pDChSm8mmzYO7BLj+YLUyWp+vayTnhJmRntmawKgWToC48evGZeAye6mfMMz3njTbpcVDmFCdOS1PPTldopfpyohCyg51i2YRAE8RVPb9z3Vf7402EMn1F9I550d+u1jHG3WcRr1wsb72CRqdGAn329mZcCAdNKYUB8YJ4CftT+1uzrWyVOzS8wXLZTuaWfYLWO48R+0Lfl3aaxGKAu17UwIUacCif0F6B0MTmZSVJSdYBhhq0YCLG8cVsgfkCL9Kw5iSlAwSqT3hdnwe6mq/pySho4/zSO+xEkjXT9l4uFGD3nvRyfO4OQr48iteVLF8xLztTUqJ6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5a0aGsgMCp4OKHVf3eaemHU1LFdujOUFiyGq8ijI+ww=; b=GDVmFR3hkfbhw4YYvca2uq/mxNWA1UJFaEjjjNM7gtlLupcpGmTvZG1QtGjjV7ibxY/BaIU3YySDJ0yh795YvGzXMiiGHncOq8JF1+EHcVfhHqqz2G2DU5oVQO4vgYU69VpigXfrf6UNlYL3AuCO8U02l2U4wo/PKiZ2nTXmuOHopz91z9PkRkxwfYYmWQKwyavrnbuRbVllr/ZqqUI1QDJbA2jW3Cm6s3p4NbdQpk1073HOhhvXuqyO90G4HYbnbYOjyiEMB4TJuTTx5D66RuiEQPzaioEmm2LOJeJ9ycJKTb/T/qezeCHgTYzI11WZ6L1IFK5lG2k33Ru/+Be8cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5a0aGsgMCp4OKHVf3eaemHU1LFdujOUFiyGq8ijI+ww=; b=kYyYgxhbjfd6r2AqUh+b/7C5aFzrMcdL9I+97qg9Pxv+mnkkpM/XqbMtCRHOX7CVoOeN88Kjqa10EcjEyCVaGKkI3/UGzynS9pZzqXhPuyuQmWrp1brikIfqRWu3PUpx4PLGmY3sPdTCVzRmzH+xtzCZmaz2XkJMWQpYTIaJEXdzAqdEFPNyY1zDn1XEx5hvyc5Jwt1vYDTbLj9Lp3yrw19T5Q/Aq4oChMeTYaFDnN6Cojr5JwYh82zRb1Zo9Q6nQH880fGHMLfoYGO04yLo+kkbmd4VKszcBZQRMCp0CrH7IX2k+oPrnoW98ERykTrxQZh74sIJ8ioNJjfxlqNjXw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 7 Aug 2023 17:39:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/9] xen/common: Add missing #includes treewide Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <2c9eb4fc175a1bdd21293f2e2611d8e21991636d.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <2c9eb4fc175a1bdd21293f2e2611d8e21991636d.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::23) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8949:EE_ X-MS-Office365-Filtering-Correlation-Id: 90f23f9e-c930-4264-9bcc-08db975c8ca2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h/GVPe/pLfbUQ6MfsViHwOoFihOuP9KTjJpZe24QdkgQDKlcr030tZKcJAKV38VkKPlFPbB4O918RzWNvnVLcx/HqG6gVhOE5+Cs68D17Z/S920noRpp8PQnVRlgqaelqXeRccnr2nU/nvaDQdM5z3/QD7hE9lRZmptdU2pIMQrjFVMuhuLpuFIEm1va/jdizwBKmhRzvsH5/FGZPfCJkVOWFDkv2Fl7pQrrUQEDmk4QkuFNS8QimzJD6blwVTD1ZToNk72uQBqSbkQd0vc0lfESCeUxbfZK20fPVraL24wZIJNb0NamiQuMIIm/hY898Sli5VaIc74fz7H/GMOShM6f2Mrwu5JDL+RzNXSn/weE1sQYpThva6gxxfBkv4eL/mdrxA3TO9U7kV2t4DTYGkPmNyHn41XVigVRyK2bzKyNrUy0pIeCbyH4tB08TTP/G02KCted3Ty3icJzUOL14ygyNGS8zCdHgInKZu2588YYK+JjADhU3sJLfQIlmDxsNvQUp+Yf/QKlv7MPDP8q2e+YEy5p0CxyK4xiE87Qz2M0EY0cT/JVWRyotvc6SDYPkH+JlXQMU+qdrlppHqgU2ckfIu/Kn/n4eUSb1aYBe+KlGi4shtgM/2iRmsIdiJbm8/d0P4QCcyOZwxp9YBaWWA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(396003)(366004)(39860400002)(186006)(451199021)(1800799003)(66946007)(66476007)(66556008)(4326008)(6916009)(2906002)(53546011)(2616005)(38100700002)(6506007)(54906003)(86362001)(31696002)(6512007)(478600001)(26005)(36756003)(6486002)(8676002)(8936002)(41300700001)(31686004)(316002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGdJTDI0QU1OQVozNDUvbmNpcVFBNEQvYzI4Vjc4bWwvQXZaZGJ0UWFRTnZp?= =?utf-8?B?VkZ5djZMbjNpNUJRU0Fvdzl2c003UW5Ud1plcGdsaWEvZk9NcTZBallVTG02?= =?utf-8?B?SzlMZDk1QVdJbWRTWnB4Y210a2ViYXRuZFFBRUh4dkttKzBNVW1nUlhQeXFT?= =?utf-8?B?U2grbjlnTlFSRGVXMHp3VlowWDIxcklXWERVZE9mR2NQMWJndENlU2RKWGJa?= =?utf-8?B?dWZvbjd1bTVIeXVaTXZxcjRBNzBpb2ZoZGtwY2E4NmxBd3JJYktxUTc4U3N3?= =?utf-8?B?NkRBdXVPWjY1ek1kQXJrMmRGRmJNOEJnUjg3ekpWSy96eDFzK3NTR29Ha3E5?= =?utf-8?B?M1V5NGpKQTE2bDQxVHhScW9XRlBrN0t6OFpsZGM3cE1vZHBheHZVY0xQTU9X?= =?utf-8?B?NU5UczU5NlpYTXFaZElhTzJPY3pEMkhPOEk2cG85Snozb1dCZ2JlZmRIQzdv?= =?utf-8?B?bTU0V2JOaTh3bmVXem9MMEhvUFBsOEJSTVpHWVRSSm9yVWMwUlFtWkM2SVJ5?= =?utf-8?B?RzNKUGJhUkxLZERmazRTbE9wOFdwMkh6MDJWWk9xWEdueWhhOUo5aHorSkhQ?= =?utf-8?B?S1JLM2M2eGRDYlFBQUxQT1ozbWZIN29RRkUvSytjVHhLQm1NdmErbjlVcGQ4?= =?utf-8?B?akxySWQvMzZiQlowdlFxWkhSa3EvS3lJbXZoR0dIcUtRNFlLMlhYeVplUHpa?= =?utf-8?B?YVRML0t2d09FKzhCY1dPL2ZiTGx6V2RGWTI3dGVSZTEvR081TzBHMEc5M0h1?= =?utf-8?B?Wm94a0pUQy9XQVpFK1kzaEltYmhzUGFlem01MU9QdWszMi9jdkFUKzVYcTBE?= =?utf-8?B?c05PaHlvdUJhd2tENUhqYTQ3d2JsK2lXbng3WDJrOWZla2NlQzd5d1hRMm5U?= =?utf-8?B?K2pJcWdRM2dKeGVoZkxXUjFpSDN4aTNWTG1oR2hvelZ6SDNtMlgyZlFsTmdN?= =?utf-8?B?WlRwUTBKVXFVYlIrZ0xTTUhtMmFDQkNKeGxLN1h5bWtQbU4ydk0yeWlpQ0tV?= =?utf-8?B?ZCtvMHRFRzFYM1hyaTdLbUh3dVlYRXE0MzVpZmdJdGNqYjZuQU5MVnpRNWxy?= =?utf-8?B?MHRGdEtHVDljUnBHRGExNWtDSzJMdlJOTXlQa2hsejh5dXN6dGtHQ0JEUzBs?= =?utf-8?B?TmpEdTMzWm0xUTdnVHUwaEVPRGkrMytrMEk4bVlqc1M5djRDYnZTd255bjFB?= =?utf-8?B?MDJsK0RPNDlGM3FDZ2I1MFludDdsb0QrWTFtK3ZzUmJSSGk4ai9Edk9zZTV0?= =?utf-8?B?eXJBOUdOMGU1NnNJeDNMdzdUYUw4eDA0eHpnYm1DM2hWMUdVWnVaaUMyQzZJ?= =?utf-8?B?aThoNGk4RTJNd2p1cUlpOG9aWk9PSjVQSWZVdWQweTZmMFNTVmtxZ0x3OVF2?= =?utf-8?B?TEwyZmtPMi8vQTNaeVdzb0YwMlVZWXA5YlNZM0RmVHkwRFJOLzhOWFdkdVV3?= =?utf-8?B?Tys0Si9kbE1KK1ZvTGdDSExNY29qVUdGZjBTaURpQ2FEd3NZeVJuZFVOUmpk?= =?utf-8?B?V09PUVRabjFONEdVbTFKcnU2Z045bnJPcXhJRk1lakFrdDFXTWVJbVpvSDRQ?= =?utf-8?B?U1AwbW5LWERQL0N1ZDBtZGJpMW83UnF6QXRxOW9VQjdZUnY1SjdocmtvaUlF?= =?utf-8?B?ZStZbUoyTXB1MHhMSnd4TEt6MXdCblRVUS92UFZNVklmL2JvTCs5UDYwSkov?= =?utf-8?B?bm1xeVNCQXhrNzNZaFlrVmZFNUdDODR2ZGVwbXBGbXdLYlB4YUxqM1ZCdlh2?= =?utf-8?B?QkpkQjFJbWlwZkVYT1RPcFpqaFozYWpwTGI5Z090R2Y2d3JzWEt6YVVlbGRa?= =?utf-8?B?TkV4UFVZRWp2WkdObWlzUDRtMkdOMUpVd3RsdnVpdGQ1WXZCY0Q2SnJiUWZh?= =?utf-8?B?NWNKMGgzVFVoYTZEMHFVelpBVnVkTTZ4MHcyQm5Gd3VaeU90bDBKdUVwMFp0?= =?utf-8?B?Y2lsbW1vdSsvL0hIWTA5NjZNcnA2TWo3L3NSejZiVTlPRnhnZUxDWmgvbGF0?= =?utf-8?B?c0YwZ3ZIODlMWXZ1b0x5TkFaa2RYcVBROFRLbkU3R0RNUUlmenFDNVpNWXVx?= =?utf-8?B?YW82d3haV25hbEUvQXdtWnk5U2o4a2piYVFUTkl6a2d4YUllL0lIZjB3NWht?= =?utf-8?Q?O2OIPK9TEwgh/vOwraL823dkX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90f23f9e-c930-4264-9bcc-08db975c8ca2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:39:55.7140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sGawX2cTgMWWu2p6MlJ2iT/nxYTBecKIbNS8h4X45eXlqbPRFnbXf0T9yXXcvi38WhNCyS1SHYporMsciLLfTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8949 On 03.08.2023 01:02, Shawn Anastasio wrote: > A few files treewide depend on defininitions in headers that they > don't include. This works when arch headers end up including the > required headers by chance, but broke on ppc64 with only minimal/stub > arch headers. > > Signed-off-by: Shawn Anastasio I'm okay with the changes in principle, but I'd like to ask a question nevertheless, perhaps also for other REST maintainers (whom you should have Cc-ed, btw) to chime in. > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > #include I realize there are several asm/*.h being included here already. Yet generally I think common .c files would better not include any of them directly; only xen/*.h ones should (and even there one might see possible restrictions on what's "legitimate"). Do you recall what it was that's needed from asm/page.h here ... > --- a/xen/common/xmalloc_tlsf.c > +++ b/xen/common/xmalloc_tlsf.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include ... and here? > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -4,6 +4,7 @@ > > #include > > +#include > #include While following our sorting guidelines, this still looks a little odd. We typically would include public/xen.h first, but then almost all other public headers include it anyway. So I'm inclined to suggest to replace (rather than amend) the existing #include here. Then again I wonder why this include is needed. xen/domain.h is effectively included everywhere, yet I would have hoped public/domctl.h isn't. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:49:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578678.906296 (Exim 4.92) (envelope-from ) id 1qT2U8-0000sN-3s; Mon, 07 Aug 2023 15:49:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578678.906296; Mon, 07 Aug 2023 15:49:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2U8-0000sG-0J; Mon, 07 Aug 2023 15:49:32 +0000 Received: by outflank-mailman (input) for mailman id 578678; Mon, 07 Aug 2023 15:49:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2U6-0000s6-Qv; Mon, 07 Aug 2023 15:49:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2U6-0003BX-J8; Mon, 07 Aug 2023 15:49:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2U6-0006bg-4R; Mon, 07 Aug 2023 15:49:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qT2U6-0002Ab-3x; Mon, 07 Aug 2023 15:49:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iygen/Su8yp1XcFkkVWv6+8Gw3j9pytkUtTD+yVK0WA=; b=f8jyGfTINTOJMYkEtX+qJEN1+t Nbzbu1BW/wuP90aAVf5Zek8QGXDM2FD0GFYwYzse8rTyoonk2VRldvvkAZi+A/IbdomOldmjoMNz8 EAqD89k6/TfxTlnxsIbsw/oEaQdGjf5CYuMoXZaZw3YSpc6cMWFbNMA2xnjDqWuqHrak=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182209: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:host-ping-check-xen:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=52a93d39b17dc7eb98b6aa3edb93943248e03b2f X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 07 Aug 2023 15:49:30 +0000 flight 182209 linux-linus real [real] flight 182217 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182209/ http://logs.test-lab.xenproject.org/osstest/logs/182217/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 182217-retest test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail pass in 182217-retest test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 182217-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 182217-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 10 host-ping-check-xen fail blocked in 180278 test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 52a93d39b17dc7eb98b6aa3edb93943248e03b2f baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 112 days Failing since 180281 2023-04-17 06:24:36 Z 112 days 203 attempts Testing same since 182209 2023-08-07 01:42:54 Z 0 days 1 attempts ------------------------------------------------------------ 3912 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 658349 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 15:51:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 15:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578685.906306 (Exim 4.92) (envelope-from ) id 1qT2WF-0002ID-GX; Mon, 07 Aug 2023 15:51:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578685.906306; Mon, 07 Aug 2023 15:51:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2WF-0002I6-CX; Mon, 07 Aug 2023 15:51:43 +0000 Received: by outflank-mailman (input) for mailman id 578685; Mon, 07 Aug 2023 15:51:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2WE-0002Hi-0m for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 15:51:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0601.outbound.protection.outlook.com [2a01:111:f400:fe0c::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c096440-353a-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 17:51:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9579.eurprd04.prod.outlook.com (2603:10a6:10:306::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Mon, 7 Aug 2023 15:51:37 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 15:51:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c096440-353a-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRy22FFUXgBnKPEnowny5Cyg3alCZ4VfGxZxqFQAqOReWzxuT++H/c2HBYwCjrPVZkpBPXXtBoy/BpPBP0lQN+kGX8sEUBSx4BPLOGelcdwBGoIDlqFBoSMoDY4ViF4rITP/lCLpRBdGqB3bOLasIQl53lkTTxftH2wYGup6Klx8fK3k/L80tOFn5UL8qGaPO0jRQr2H2v4OrLY7Eh8eto17QmtKfurAN9mdjRxqqNjoHJBDfO5oEW0wxEEPJXtmgtIa0xyvUwn2xK/BGrvIzPjURMzp1uTggRZjIwlWJer2CTiqxIsmFCo8AiPio4qbx/ydLHU4MIG43b1pe0Iozw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JZM2aPtkR7BEx4uW72YUYodwBCKkNjvFv4Xb5eFtWpI=; b=cTLBZRvbCjrJjgTS17kpq0f0Unc90bW4Bjcp3dz/FvCN5I7Gj1DL86DIORUSeww19u4ghI6EosgXmKi+lkracZP+V8MT8cYzYN7lZGD/8p7DbJ50s2EB7eox9qekeuNgWRMAe0MJHb8J/LcIswj+22NuHa6SZiYK9hGvf++4Y1dDJrZNkR3Zm4QPk1EiB2YC5EyY/I0d3f8iYoKMla26jsGeeTvt9hb5b9rpdVDOIsG+zZKU8JsFXMWeIY5ETP8sTHymutMif2TcuK6BhxmhGhFpOO/dJjTcu81rei0e39G0zia3I5qaZKA9aHEUQ7qVzaT6KlsuXp+qY8TNyXBNZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JZM2aPtkR7BEx4uW72YUYodwBCKkNjvFv4Xb5eFtWpI=; b=3u0rc/LnZJ98RnwOqyjN/+/8XpSrPrz5unkevIkV9rl7uInQ3MVQ1t6FIsKb7exjNy8QtxAygjCarY697B3Zz7vPF6jjRhxm0wJrzltmIyPWR11cK9zuAI8cACSYFxKOoyZHpV9nbk9Y4mYQ3sYlmlB8gS+GH95c0eBXGZBFy1izvJEIxkcLbo28XiDKFBpk5tBgqlWmMOEHHkIJZlnNnL4XRPQsOJCMZWUpra6NMM2GFKSHninBaq5ayue+HgFP/lXMewFsvTqedZHHHpPtkvytcnIyZoPG4Az0cKSnMXYYbvRfDvJQspk6DU7hZsEOZRUSF+nq5MC6WOIiav5pQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2705d5dd-e74f-4093-aad9-3e54060160f6@suse.com> Date: Mon, 7 Aug 2023 17:51:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/9] xen/ppc: Add public/arch-ppc.h Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <14d8455ca49f69a56e87aad5d4e20cf8f77e55cd.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <14d8455ca49f69a56e87aad5d4e20cf8f77e55cd.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9579:EE_ X-MS-Office365-Filtering-Correlation-Id: 2339f6a0-4568-4d5a-40b0-08db975e2ea1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZVW4/tcQZymBXP71LjG9leduZcKKMPXeZj+hBC5+mSp0LpIG9JA+VX6LlF0PceNWio8IlMupFyvnT2wZRDBKXNPnFRWXSaRzVIfwIJ8kLdxuQ81IwqAI3ncpXlBTEjde07d/UffepvalFjyxmuRpwjzWj9lI6LoZObIhoMOvlWHrFAODRCjFGHXhSHgTu5gp2mbQUgifxy8LKgnmdnhkjqNaWyoVmJYrOovfP2GFhLae/CCTeit1cAqXbGDHP00yvRW/XovE3Y54XUibvtdMThLA+jraaaWTUvJqg7XtC9ccS1a+T//LDc3YG2zv417O37sK6gEBENpd+JxaFLUEQOkAGMgMK9dxKC1o1LFH+5+H1rGgaSHkGNOAv9wZpnqP3d+RWeHOqQ3ah3xd0yysC94g/qCAFqjtk8BGWpgjxor5UWGxQc2RMWvyofvRHzicyD3LXOJgshbI7v41o1RZn0Qoq/DXA62dK5VPJQjeNgnl8ASWEEmKAYscKvI8uGerxlTQTmr5X2JpR7GsR4XFieiqRlgTALXOiBB7DiGyhPgkn+Nx7Zf2UC7626E2Rp18fGjBiXhwzm3VnRO//23jCxku0THPMFG96HCGBm75DWn0Dp0hKIQ9e2st33swYemgvJcpwXHYj0Sl4VoPxODYRwhN0To9r26p/87q8xOZbR8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(39860400002)(366004)(346002)(376002)(451199021)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(6916009)(86362001)(38100700002)(54906003)(66946007)(478600001)(6486002)(66556008)(66476007)(31696002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(66899021)(2906002)(83380400001)(5660300002)(31686004)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T25tWEUrRmJ5Yyt1V3ArVFlTbjYyZFNlb2d1RGZuQjliK2lXblZQTUdxS2Vl?= =?utf-8?B?alh2VDFHN2NMWXk2WHBwYUpibzE5aysrWWRHQVV5Q1ZNMmNZcmJ5WlVmNjhU?= =?utf-8?B?U09QZGxLV3c5Rmk5MzU5bnNsQWI3REJmUDVhc09kRlJaSlVWNE5Wd0VublBR?= =?utf-8?B?WFhFOHNqWXR1ZVZ0YklRaFVCeUd1cjZTSkh6Ty9idHg4eEY1b3lKQlpub0tN?= =?utf-8?B?RllpOGczOHRZaS9WSlVNeTBMK2tvWkxWbFNmUFVvaXhlOTU4TGlsOFF5T2po?= =?utf-8?B?TFlzVFRXblJhbkd2SWY5eWFVcjJxa2JZU1NrY2lJSEVyZVBqQ0J1cUcvbm5F?= =?utf-8?B?Vks5N2toM0c3YmJJRXdPeFZZY0ZYcHF4MzNqM2JUMjRUMGcyUmNYem56VnpY?= =?utf-8?B?V2U5VlgzL1BFMENhUVJuQkZrZTZlMUhpN09XV0R1RXV2REZwYnlUWGUyVEhx?= =?utf-8?B?M3F3cUNHZGFtVHV4RmthQWZlVStoTEpCbnpqMGNxdU1rWnZqSnhwRGQxaTlv?= =?utf-8?B?VVQzU2NWTTZyaHAzVXRlOXV4T3dZVFIrYWFJdStJcWIvbUJ5QS9IMzQzM2FX?= =?utf-8?B?a25BcDFqZlJoRlJESWpqbkJLb3pOUHFlaUhOTktQdEg0WG4yazc2TUhEUXpZ?= =?utf-8?B?U2NUaDRSN0dtV3VFVStXQURsbFhZTktRSjhSM3RkRlVHNlRIYmpOZ3BubWlo?= =?utf-8?B?Z0lRK2FJSWhaOEFXZHJWQ3dwRzhVTDZQb0RMek4yYzBDYmFJN1Q1d2FWRW1q?= =?utf-8?B?c2h0dmY1Y0F5MllEWDhyNmtEMUp5V0ZTTUdvV25zdFlnMDZ2NXpUWEFQMmQ4?= =?utf-8?B?cytrQ3RUaXg4eTdXSXNlcFI2cWJPaTVrazdOQVM5ODUwc2lITUVhS2tVbkxz?= =?utf-8?B?eExFZy93aTB0T1RsTnIvd1ByUjNvbkNIVzhkbmdwRUo0djdIV0hETGRxSjMx?= =?utf-8?B?Z3F0dDRMOUdjNHRNbnl0Q2J5WFRkeG0xNmlXOTljWkIrQ1lUZHJzUVY4Y254?= =?utf-8?B?dWJoVUFkM081MG9sV3R0dWx0M0FjQXhaSUVzRjI1VWllSmFUNU53d1FnWUli?= =?utf-8?B?YW0yYk9od2d5eE40N3dDMjd2WkplSUs1NXNTTkEwYk5jMFVOUzh0TmVVTk9K?= =?utf-8?B?RDNtUFhMNjJ0R0RLeEY4MERRc2ttZTVjWTArZ2MrS2hjOFZOaE9PWVJKenU1?= =?utf-8?B?SjBLUGxaeSt5M2RZWjNVVUh6c2NSS3JoWGp1VGYwbFNHM1dpSk01L3V3YStL?= =?utf-8?B?YWZMWHpkRUI4aVVrZmVpb1VWMytVNkVyRXdVdWdnam5scmM0OG9nT3d5Tlhu?= =?utf-8?B?VlJjM2QydmVRZEZ3UTFORTZFc0p6QVRjMWNHNExrUlRzS0lTZzdiNnpLNWxy?= =?utf-8?B?YzdVWVNmWUJpSkZidFVHL2JNRTdFUnFYYU5BbWh1RkNqNzBYM0drYWpxcHEr?= =?utf-8?B?WkRXVEQ0QS9JWHY4NWRGS09jckZRUVIzUFlpZlk1YmJHL1djbEtjVkErK1Zh?= =?utf-8?B?b0hIeHJTa3Qxbi9GVHBVNmtyZk56TjRDWGcrNXpJN2k0NWJHdkRtYXk4cmtu?= =?utf-8?B?YkRBSTM0QzFkR2lGV1pFSzRLdmFOa3kwVWptYk1kQ2RJRWNOaTE2SmNZK2c4?= =?utf-8?B?QXFaT25nbXVUQ0RjUXJyamJYUUZZand0YnFGbWc4bGZYcnBBZ1N3VWdPQXh0?= =?utf-8?B?UGx6cnlSZDgvS1N6VmxBOUhYUjFVVmg5eGpRaU1HZmNvb0o2dUtRMjIyOUpj?= =?utf-8?B?dkZ3b0dQTUR2WlJoWm9heUhpeEx0SlZsMjFwQ25RbDZoUmRUN1hCenFvbVRF?= =?utf-8?B?enRpZ1lzTm8reW5CWDlsYUFNYm1XSG8rMGZJUkVCTFJuOFJuenNaMUlaaVJO?= =?utf-8?B?c3k1aVVFVzVpNGhzZ0JLWE0wT1NQMGcxeGVpdEtRZVo4cGZmSXdUczA5QWcy?= =?utf-8?B?VFM1L3RpYmVNTWJMTFZ5MzZkTEhpOWUyd3RuVy93M3hxMkpXK3ZjSDZUODNC?= =?utf-8?B?b2lldXJqRWlYRWRlQXkzWFRBaXgwSzN5YmZVR245eTJVZjk4TXBNL1RwN2dT?= =?utf-8?B?dFZ3ZHlkQXRIREl0UDhBNWM1V1EyMVBCV0JQMUlXTk95eGtGRnFRWW13cCtC?= =?utf-8?Q?OtciGJ2G3Bf/mNn8BRGC9o8gb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2339f6a0-4568-4d5a-40b0-08db975e2ea1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 15:51:36.9401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C8ksfYEEJfu06bU/1HRb1x+u+ho6KPPCm0f39bq88iuL+wOPhD1GLLQNg2IBUAXweJ8mUp5LcTOO4Cc7jJ7MzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9579 On 03.08.2023 01:02, Shawn Anastasio wrote: > Signed-off-by: Shawn Anastasio > --- > xen/include/public/arch-ppc.h | 140 ++++++++++++++++++++++++++++++++++ > 1 file changed, 140 insertions(+) > create mode 100644 xen/include/public/arch-ppc.h > > diff --git a/xen/include/public/arch-ppc.h b/xen/include/public/arch-ppc.h > new file mode 100644 > index 0000000000..0eb7ce4208 > --- /dev/null > +++ b/xen/include/public/arch-ppc.h > @@ -0,0 +1,140 @@ > +/* > + * Permission is hereby granted, free of charge, to any person obtaining a copy > + * of this software and associated documentation files (the "Software"), to > + * deal in the Software without restriction, including without limitation the > + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be included in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE > + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > + * DEALINGS IN THE SOFTWARE. Any reason for a spelled out license rather than an SPDX header? > + * Copyright (C) IBM Corp. 2005, 2006 > + * Copyright (C) Raptor Engineering, LLC 2023 > + * > + * Authors: Hollis Blanchard > + * Timothy Pearson > + */ > + > +#ifndef __XEN_PUBLIC_ARCH_PPC64_H__ > +#define __XEN_PUBLIC_ARCH_PPC64_H__ The 64 wants dropping here, considering the name of the header. > +#define int64_aligned_t int64_t __attribute__((aligned(8))) > +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) I understand arch-arm.h has it this way too, but in public headers I think we're better off using __aligned__ (in the example here). > +#ifndef __ASSEMBLY__ > +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ > + typedef union { type *p; unsigned long q; } \ > + __guest_handle_ ## name; \ > + typedef union { type *p; uint64_aligned_t q; } \ > + __guest_handle_64_ ## name > + > +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ > + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ > + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) > +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) > +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name > +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) > +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name > +#define set_xen_guest_handle_raw(hnd, val) \ > + do { \ > + __typeof__(&(hnd)) _sxghr_tmp = &(hnd); \ In new code, can you please avoid underscore-prefixed macro locals, which violate name space rules set forth by the standard? We appear to be adopting underscore-suffixed naming for such locals. > + _sxghr_tmp->q = 0; \ > + _sxghr_tmp->p = val; \ "val" need parenthesizing here. > + } while ( 0 ) > +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) > + > +#ifdef __XEN_TOOLS__ > +#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0) > +#endif > + > +typedef uint64_t xen_pfn_t; > +#define PRI_xen_pfn PRIx64 > +#define PRIu_xen_pfn PRIu64 > + > +/* > + * Maximum number of virtual CPUs in legacy multi-processor guests. > + * Only one. All other VCPUS must use VCPUOP_register_vcpu_info. > + */ > +#define XEN_LEGACY_MAX_VCPUS 1 > + > +typedef uint64_t xen_ulong_t; > +#define PRI_xen_ulong PRIx64 > +#endif > + > +/* > + * Pointers and other address fields inside interface structures are padded to > + * 64 bits. This means that field alignments aren't different between 32- and > + * 64-bit architectures. > + */ > +/* NB. Multi-level macro ensures __LINE__ is expanded before concatenation. */ > +#define __MEMORY_PADDING(_X) > +#define _MEMORY_PADDING(_X) __MEMORY_PADDING(_X) > +#define MEMORY_PADDING _MEMORY_PADDING(__LINE__) This doesn't parallel anything in other architectures afaics, and it is also not used anywhere in this header. What is this about? If it needs to stay, it'll need properly moving into XEN_* namespace. > +/* And the trap vector is... */ > +#define TRAP_INSTR "li 0,-1; sc" /* XXX just "sc"? */ Same question / remark here. > +#ifndef __ASSEMBLY__ > + > +#define XENCOMM_INLINE_FLAG (1UL << 63) Is this an indication that you mean to revive xencomm.h? > +typedef uint64_t xen_ulong_t; > + > +/* User-accessible registers: nost of these need to be saved/restored > + * for every nested Xen invocation. */ Nit: comment style (and s/nost/most/). > +struct vcpu_guest_core_regs > +{ > + uint64_t gprs[32]; > + uint64_t lr; > + uint64_t ctr; > + uint64_t srr0; > + uint64_t srr1; > + uint64_t pc; > + uint64_t msr; > + uint64_t fpscr; /* XXX Is this necessary */ > + uint64_t xer; > + uint64_t hid4; /* debug only */ > + uint64_t dar; /* debug only */ > + uint32_t dsisr; /* debug only */ > + uint32_t cr; > + uint32_t __pad; /* good spot for another 32bit reg */ > + uint32_t entry_vector; > +}; > +typedef struct vcpu_guest_core_regs vcpu_guest_core_regs_t; > + > +typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ /* XXX timebase */ > + > +/* ONLY used to communicate with dom0! See also struct exec_domain. */ > +struct vcpu_guest_context { > + vcpu_guest_core_regs_t user_regs; /* User-level CPU registers */ > + uint64_t sdr1; /* Pagetable base */ > + /* XXX etc */ > +}; > +typedef struct vcpu_guest_context vcpu_guest_context_t; > +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); > + > +struct arch_shared_info { > + uint64_t boot_timebase; > +}; > + > +struct arch_vcpu_info { > +}; > + > +struct xen_arch_domainconfig { > +}; > + > +typedef struct xen_pmu_arch { uint8_t dummy; } xen_pmu_arch_t; > + > +/* Support for multi-processor guests. */ > +#endif Stray comment? Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:00:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:00:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578693.906316 (Exim 4.92) (envelope-from ) id 1qT2ec-0004Kj-Cc; Mon, 07 Aug 2023 16:00:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578693.906316; Mon, 07 Aug 2023 16:00:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2ec-0004Kc-9h; Mon, 07 Aug 2023 16:00:22 +0000 Received: by outflank-mailman (input) for mailman id 578693; Mon, 07 Aug 2023 16:00:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2eb-0004KV-32 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:00:21 +0000 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7fdd769e-353b-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 18:00:17 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 09:00:15 -0700 Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 07 Aug 2023 09:00:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT2eN-000sgs-2E; Mon, 07 Aug 2023 19:00:07 +0300 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fdd769e-353b-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691424018; x=1722960018; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z/4FddksZRjYPF/sctXV9wacx6/6dUIpgpIazoNeWKI=; b=WQJD0bOhtubuBXTQrK+yzSqlFx6anRM1eRTs5PjqaJBwUiZw4x1eNaxO dKwsQrnS8FO6PfpqKn9I3zeQekLYC/NHiJr7bIbSTh1MgeVEC1KAJ9ICj TPC2tP3eCStAQSAI01fviqbwNO02cOrhCMOTKBRrkQ0C4udw4akSbxxa+ afqBhujIyIXV1l/FwcMGAKi3Fv1mvW69JGqn871BSWgv/BywccFec5G+L HQD6mgpBBsnFYGeY1iZFWs+KZyzTuVulSP5uTheu/F91Rrl14uBYIY3Dg mmghH3KmlL24wRtLAsDgcAwyvCG+g5BtephfHxgd7V6TM6RfnzSxTTSRu g==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="401553720" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="401553720" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="977491938" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="977491938" Date: Mon, 7 Aug 2023 19:00:07 +0300 From: Andy Shevchenko To: Takashi Iwai Cc: Mark Brown , alsa-devel@alsa-project.org, Andrey Utkin , Anton Sviridenko , Arnaud Pouliquen , Banajit Goswami , Bluecherry Maintainers , Claudiu Beznea , Ismael Luceno , Lars-Peter Clausen , Mauro Carvalho Chehab , Oleksandr Andrushchenko , Olivier Moysan , Srinivas Kandagatla , linux-media@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Message-ID: References: <20230731154718.31048-1-tiwai@suse.de> <87h6pjj2ui.wl-tiwai@suse.de> <87leeugbxm.wl-tiwai@suse.de> <87pm3yj2s5.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pm3yj2s5.wl-tiwai@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Aug 07, 2023 at 05:22:18PM +0200, Takashi Iwai wrote: > On Tue, 01 Aug 2023 19:51:39 +0200, Andy Shevchenko wrote: > > On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote: ... > I rather wonder why it can't be simple strncpy(). This is obvious. To avoid compiler warning about 0 (possible) truncation. ... > > Taking all remarks into account I would rather go with sockptr.h being > > untouched for now, just a big > > > > /* DO NOT USE, it's obsolete, use uniptr.h instead! */ > > > > to be added. > > Possibly that's a safer choice. But the biggest question is whether > we want a generic type or not. Let's try to ask it first. > > Interestingly, this file doesn't belong to any subsystem in > MAINTAINERS, so I'm not sure who to be Cc'ed. Chirstoph as the > original author and net dev, maybe. Yes, but actually it's fine to just copy and change sockptr.h to say "that's blablabla for net subsystem" (maybe this is implied by the name?). In that case we just introduce our copy and can do whatever modifications we want (see previous reply). -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:06:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:06:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578699.906325 (Exim 4.92) (envelope-from ) id 1qT2kL-00057G-0p; Mon, 07 Aug 2023 16:06:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578699.906325; Mon, 07 Aug 2023 16:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2kK-000579-UW; Mon, 07 Aug 2023 16:06:16 +0000 Received: by outflank-mailman (input) for mailman id 578699; Mon, 07 Aug 2023 16:06:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2kJ-000573-LF for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:06:15 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 546f3f79-353c-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 18:06:12 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fe5eb84d43so6743725e9.3 for ; Mon, 07 Aug 2023 09:06:13 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id n20-20020a7bcbd4000000b003fe557829ccsm6630963wmi.28.2023.08.07.09.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 09:06:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 546f3f79-353c-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691424372; x=1692029172; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=PP9dYf284idr19PF7QLRc3SDpLEBWw6WZPJUbbBvNJQ=; b=EzC0yItmecwznpscBiheWkNwdjmzS5Auqj4VmLindz0GZ1x0yv8HnCFUo9qjdjv1ne L/ElDHoifE9n7OB+hzwxr2no6wDgnn0xJUPaGpzex9ZySvOqf6JbLEMDWv5u157xcigt B2Ca6CbdHHNHuoPpfB+mhMFhaGQWbn2lH3RB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691424372; x=1692029172; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PP9dYf284idr19PF7QLRc3SDpLEBWw6WZPJUbbBvNJQ=; b=AVpPv1+dXaVm30tk5Zy4k7N6/wJtuWhaN8koqOJbUhf2JKC/Nvuu7+SXdFjSA7VlgE lTBypWDmNBwY8bjf4uZ3tCQGlDAgkKZPzwcuUwhNWZt722FJCsfvf6mlzr+HAHVTHbmr PvomhmjjqW1JBKWTgKfpzClVkgXcRHDmCGYwpvWqXmQhGOytMc0SQv+IAzOEkPX4e0vp hICWX6jrcR8+oIL7HVfvqYankGSwadeBcH0Mnt8sKO86IxTPLCPzlYMTtSAzhltyrdWG c1a7bgVkzlpgpaTKUGhmi8+GC8swOx0C745lYnccMrX3xIuA5XB2UxsSXYzw2tB16fl4 Y+dg== X-Gm-Message-State: AOJu0YyWxLoaAyWGeWUQ3kMICFG/clRU5wxTkXZCFYEFXdVRkDllLD8y K9C1jXboyQnxUYD6uLItAbc8Lg== X-Google-Smtp-Source: AGHT+IFX6NQTwsiSqc6FDKMBUPAQgmy/jX9JdTf+My0E70BNtWEzICSYxS942Xw9iN4oLJ55RmtcpQ== X-Received: by 2002:a1c:7511:0:b0:3fe:2bb1:11ba with SMTP id o17-20020a1c7511000000b003fe2bb111bamr7977474wmc.27.1691424372555; Mon, 07 Aug 2023 09:06:12 -0700 (PDT) Message-ID: <64d11674.7b0a0220.ec9d0.7073@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 7 Aug 2023 17:06:10 +0100 From: Alejandro Vallejo To: Jan Beulich Cc: Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Xen-devel Subject: Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-6-alejandro.vallejo@cloud.com> <9f0b7ab4-090f-21ea-2cf8-6ecdc7c02225@citrix.com> <3470bc26-3cbc-e0de-53ae-203449493b51@citrix.com> <06a3f79e-4345-7a4b-be57-728a8b01befd@suse.com> <67b5c363-a653-3f5c-ea3a-f52bfac3dc49@citrix.com> <75a70fa0-ab40-e2b0-685d-db752c943a7d@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75a70fa0-ab40-e2b0-685d-db752c943a7d@suse.com> Hi, A few days have passed. May I suggest taking a step back? On Tue, Aug 01, 2023 at 09:57:57AM +0200, Jan Beulich wrote: > On 31.07.2023 19:38, Andrew Cooper wrote: > > There's one system which never made its way into production, > > support-for-which in the no-op case is causing a 10% perf hit in at > > least one metric, 17% in another. > > > > ... and your seriously arguing that we should continue to take this perf > > hit? > > Have I asked anywhere to keep this enabled by default? Have I been the > one to first propose a way to reduce this overhead? > > > It is very likely that said machine(s) aren't even powered on these > > days, and even if it is on, the vendor can take the overhead of turning > > PDX compression on until such time as they make a production system. > > > > Furthermore, it is unrealistic to think that such a machine will ever > > make its way into production.  Linux has never PDX compression, and > > by-and-large if it doesn't run Linux, you can't sell it in the first place. > > I'm sure you recall that Linux has much more VA space for its directmap, > so aiui there simply was no immediate need there. > > > It is utterly unreasonable to be carrying this overhead in the first > > place.  PDX compression *should not* have been committed on-by-default > > in the first place.  (Yes, I know there was no Kconfig back then, and > > the review process was non-existent, but someone really should have said > > no). > > Are you suggesting no code should be committed supporting new hardware, > ahead of that hardware going public? > > > It is equally unreasonable to offer people (under Expert or not) an > > ability to shoot themselves in the foot like this. > > Shoot themselves in the foot? If you enable EXPERT, you better know > what you're doing. > > >>>   Indeed, Julien's > >>>> quick metric shows how much performance we waste by having it enabled. > >>> Further to this, bloat-o-meter says net -30k of code and there are > >>> plenty of fastpaths getting a several cacheline reduction from this. > >> A similar reduction was achieved > > > > Really?  You think that replacing the innermost shift and masking with > > an alternative that has a shorter instruction sequence gets you the same > > net reduction in code? > > > > I do not find that claim credible. > > Did you ever seriously look at those patches? > > >> by the BMI2-alt-patching series I > >> had put together, yet you weren't willing to come to consensus on > >> it. > > > > You have AMD machines, and your patch was alleged to be a performance > > improvement.  So the fact you didn't spot the problems with PEXT/PDEP on > > all AMD hardware prior to Fam19h suggests there was insufficient testing > > for an alleged performance improvement. > > > > The patch you posted: > > > > 1) Added extra complexity via alternatives, and > > 2) Reduced performance on AMD systems prior to Fam19h. > > > > in an area of code which useless on all shipping x86 systems. > > > > You literally micro-anti-optimised a no-op path to a more expensive (on > > one vendor at least) no-op path, claiming it to be a performance > > improvement. > > You appear to forget the patch patching to MOV instructions ("x86: use > MOV for PFN/PDX conversion when possible"). Are you saying MOV has > performance problems on any CPU? > > Jan I think we can all agree that (a) the _current_ pdx code implies taking a perf hit and (b) that we can't just remove PDX compression because it's in current use in certain systems. The contentious points seem to be strictly in the status it should hold by default and the means to reduce the perf hit when it's on. For the status: I think it's clear it must remain at least on ARM. I believe Jan argued about the choice of default in terms of "when" to turn it off, rather than "if". Seeing that... > On 18.07.2023 9:33, Jan Beulich wrote: > I disagree with this choice of default for x86. To avoid surprising > downstreams, this should at best be a two-step process: Keep the > default as Y right now, and switch to N a couple of releases later. ... so I think a more productive discussion is following up on that, looking at the "why", "when", "how" and "risks-involved" rather than going in circles (more on this at the end of the email). Now, for the perf hit reduction: An alt-patching series can probably make it very close to the perf win of this patch as long as it transforms the conversion hunks into no-ops when there's no hole. I looked into the 2018 patch, and I don't think it tried to go that far (afaics it's purpose is to inline the compression parameters into the code stream). I highly suspect it would still noticiably underperform compared to this one, but I admit it's guesswork and I'd be happy to be proven wrong through benchmarks. Regardless that's a lot more complexity than I was willing to tackle here seeing that it's use is limited on x86. Compiling-out and alt-patching compression are not necessarily incompatible with each other though. It would, in fact, do wonders for ARM, where the exact same binary might have to run on separate processors with different memory map configurations. I do think someone ought to do it in the long run as a performance improvement for that port (if only because alt-patching is arch-specific), but I really struggle to justify the dev effort of writing, benchmarking, testing and maintining all that infrastructure when there's no (known) machine I can buy to test it on. Summary: * While alt-patching is an attractive alternative this series doesn't do that and in the spirit of keeping things simple I'd really rather keep it that way. Does this sound reasonable? * For the topic of when to disable compression by default on x86, I genuinely think now's as good a time as any. If we were to do it in 2 steps any project downstream may very well not notice until 2 releases down the line, at which point they simply must turn compression back on, which is what they would have to do now anyway. * For the topic of allowing or not the option to be selectable, I think it would be a mistake to preclude it because while we don't know of physical memory maps with big holes on (publicly available) x86, Xen may be itself virtualized with arbitrary memory maps. Unlikely and far fetched as it is, it's IMO worth being at least cautious about. Gating the feature on EXPERT=y and adding a big warning should be good enough to avoid foot-shootouts. Thanks, Alejandro From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:11:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:11:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578705.906335 (Exim 4.92) (envelope-from ) id 1qT2pC-0006at-JU; Mon, 07 Aug 2023 16:11:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578705.906335; Mon, 07 Aug 2023 16:11:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2pC-0006am-Gz; Mon, 07 Aug 2023 16:11:18 +0000 Received: by outflank-mailman (input) for mailman id 578705; Mon, 07 Aug 2023 16:11:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2pB-0006ag-FM for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:11:17 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 077e640e-353d-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 18:11:14 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 5A9358285869; Mon, 7 Aug 2023 11:11:12 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pYCinvAMIQ1S; Mon, 7 Aug 2023 11:11:11 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 69F8E8285885; Mon, 7 Aug 2023 11:11:11 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yZ_eAsO6-xEJ; Mon, 7 Aug 2023 11:11:11 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id DE94D8285869; Mon, 7 Aug 2023 11:11:10 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 077e640e-353d-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 69F8E8285885 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691424671; bh=0cRbmjHmU3vpRBmIhesDOLeQ7IvDLovh8+UtZ5ei1MA=; h=Message-ID:Date:MIME-Version:To:From; b=bZMSz66/lCl7cQaJnvlSVMYir8u3lMpZFdlln4522UTw5Xf8mSrDouU9NOpNr6Esc uqHGT+r9pe3oZPUnV4ouIbzeVl0n0/D1hSxX+Mw07RfSvPGgp5pGs91HIhRZgsa14N AXdvFlMaTC00I0RtdanLhSASKa0cxaUcp2chkFGU= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <7c4468be-a487-6497-f207-0d3c4e942d99@raptorengineering.com> Date: Mon, 7 Aug 2023 11:11:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/4] xen/ppc: Implement early serial console on PowerNV Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <3176762c2eb09d01d65a348e296a94cf0356ff46.1690934409.git.sanastasio@raptorengineering.com> <8cf5b42d-a80d-a8de-b564-8b45c97474c4@suse.com> From: Shawn Anastasio In-Reply-To: <8cf5b42d-a80d-a8de-b564-8b45c97474c4@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/7/23 10:05 AM, Jan Beulich wrote: > On 02.08.2023 02:11, Shawn Anastasio wrote: >> Implement the OPAL firmware calls required to write to the serial >> console on PowerNV systems. Unlike pseries/Open Firmware, the OPAL >> firmware interface can be used past early boot and as such the relevant >> functions are not marked as __init. >> >> Signed-off-by: Shawn Anastasio > > Constraint as before and with two nits > Acked-by: Jan Beulich > >> @@ -20,8 +22,20 @@ >> * Load the address of a symbol from the TOC into the specified GPR. >> */ >> #define LOAD_REG_ADDR(reg,name) \ >> - addis reg,%r2,name@toc@ha; \ >> - addi reg,reg,name@toc@l >> + addis reg, %r2, name@toc@ha; \ >> + addi reg, reg, name@toc@l >> + >> +/* >> + * Declare a global assembly function with a proper TOC setup prologue >> + */ >> +#define _GLOBAL_TOC(name) \ >> + .balign 4; \ >> + .type name, @function; \ >> + .globl name; \ >> +name: \ >> +0: addis %r2, %r12, (.TOC.-0b)@ha; \ >> + addi %r2, %r2, (.TOC.-0b)@l; \ > > Strictly speaking the - want surrounding by blanks, but I wonder whether > to PPC eyes these constructs look more natural without. Please clarify. This is admittedly very subjective, but to my eyes the code as-is looks perfectly natural. That said, I wouldn't be opposed to adding spaces if that's what you prefer. >> --- /dev/null >> +++ b/xen/arch/ppc/ppc64/opal-calls.S >> @@ -0,0 +1,81 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * Adapted from Linux's arch/powerpc/boot/opal-calls.S >> + * >> + * Copyright (c) 2016 IBM Corporation. >> + * Copyright Raptor Engineering, LLC >> + */ >> + >> +#include >> +#include >> +#include >> + >> + .text >> + >> +#define OPAL_CALL(name, token) \ >> + .globl name; \ >> +name: \ >> + li %r0, token; \ >> + b opal_call >> + >> + _GLOBAL_TOC(opal_call) > > Any reason for the leading blank here? No -- that was a mistake on my part. > > Where necessary I again think these small items can be taken care of > while committing. Sounds good. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:13:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:13:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578710.906346 (Exim 4.92) (envelope-from ) id 1qT2rW-0007BO-1g; Mon, 07 Aug 2023 16:13:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578710.906346; Mon, 07 Aug 2023 16:13:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2rV-0007BH-TJ; Mon, 07 Aug 2023 16:13:41 +0000 Received: by outflank-mailman (input) for mailman id 578710; Mon, 07 Aug 2023 16:13:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT2rU-0007B5-Co for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:13:40 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2060a.outbound.protection.outlook.com [2a01:111:f400:7eaf::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e5aadd2-353d-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 18:13:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DUZPR04MB9726.eurprd04.prod.outlook.com (2603:10a6:10:4e3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Mon, 7 Aug 2023 16:13:34 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Mon, 7 Aug 2023 16:13:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e5aadd2-353d-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EIGsn4o9IN+nOUoG8xhwQRTEaJkU1z3U2A8q2nX+wR7sPhx8z/qOBPv47lntBimvn6ys7yL//KqrtHxQIvJNtxkcXHxnyXDP4TszY3gCcjAoAiZADKRjb9lANvh1Z+369EhYwjBVH53yYc/5XQLytRJAQMux2R+akLXrl5/YUrzOsH/5Gdon7FI16CvYcR8tm1L55qxY6RWgi1U7i7IpKw6RCF98SS7sdyOHTbNfn9pVeg2oFRVD6ezyuOurPv9fsyNjs8Cn6kGMyvlTSzx/m306UdOBs5dBkdxhStBZxXBhTD83RezIWj8HjwvcEohyxQvxszc3pTzVz1jcxelIDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M9BBDvlTNSHInOuR4isqlN/DZv5qAdgN4AiiOd9csnU=; b=AGnUs6vbVHhgcU8TMab+tATw/X0GPPOt4Jj8kdpcclR/ljWx5zf9zKglA11rraxBh5fxgdQIjY9H9NIMRmwr/M4Qf6x4EhMUL/tNIoF/8R3u50/IyMgym+Gvv3iI2j0atbx6qMK4iMXbab4SX3xSJohRG65Ae/oFyBrt3fdGjJDAi2mAWpmhDwaydH3V9bRdn/SWseyEL0B/Ry1mp8kynGDp/kkhqFjBUXFieNta+w8ZBKUxX5jo5LWlzgbNYcZCUpb5d6QEVumjGwrxEhoKjbYAL61IOS3/4W2D86Xil8QPBbH4jNvgqGo1wu4xCrT2j+m5is+SEju5VLLqAxZnAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M9BBDvlTNSHInOuR4isqlN/DZv5qAdgN4AiiOd9csnU=; b=b8zmMn8Cz9ZLmAIjk3Ppw82mhPVxR4S+I+2KklDQE/ldy3PQQltIEJvLwS4xj4pLbM3X22mV11GZY5q39qMW6cYZ3tw6dgkN9SZa2Ojw4+PM1kmQXl4P0CW66Qy/quwkslfubN637GbeeZfprD4WHOxfVxxbJVfYa8vY+KlQuYZYUIp6pDhfzXiaJtIkICfV/1ZorNQDzMGxqRYBZ1i63HMXcPQy6fNtqQfUiLjzNMTfGGopvhEZuBc/yzNrcax5IqO3YTGUB2dsLUVgSfPsoxorlCWpzdFnsqE9/PmjDAeRl4erbd8E3znZYa8lxhmuQdhFbpBBWsBVO/IXTHZ6gw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5e9380a5-7e33-ea70-6aa5-3ce1906a159c@suse.com> Date: Mon, 7 Aug 2023 18:13:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/9] xen/ppc: Implement atomic.h Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <8035b9659a5930c00802dd36ab52574695d6b419.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <8035b9659a5930c00802dd36ab52574695d6b419.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DUZPR04MB9726:EE_ X-MS-Office365-Filtering-Correlation-Id: ec5ba9ac-5f24-4814-b7a6-08db97613fd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nhYtqt7x+7P+03qFDQhRufMFj+vThEpORdctHCk0USETSKdkUhoqGUlobohpRr1ZV+bxmMBh1ZWsqusZxAiiCoien/AVbghst5I/rW9P8yDTs2/V7LcJ5G+VcPe9O2nLAk295T+ttsoxgGxazxjIJowViO9CFo5p4FrFlxt/TWJoPCeOU5+UU/In9dewtYwegYlU2yYPBbkQsqFsmFPiM6CgcxzASB6EETyZdkdJcKGyEarQWa8HPVaKtfpG1Y3LyNccz9nCw26abmJ1tXJZWY0+LqBknJYwkwybNAnboxzUZTti+eLvIlIWUadXn6PCehDJA+IV3Jgml2wheGtPWEGNF2vsETLWQIcvxmTR71sQ88YzTrX0DdLnVfa/BZM1hjXOsvHma3r8oxN0z8rIQ2mBYJxAYFazs3eCv2nDUuSo3Vxz4SHQ2UekLrXH1f7ZbPyNXESXZQztEe0J01q9rJXefSb98oUwMjVPaJBIq8kbE34WFGXNzl/kNyOYtOr+e/IJ9twwto4H6RdOenWYV0cXuC/sEsHf2VZ+xZeKZ3fFFwvXLnztePkRUM/GfFmipZxs/owNyZmXU/w2cqcdaiIvtXsHLx9bGLpZaOyz1x5AnWOPDWLHDZrjOgxh4Do7ua7jboBiCNMbcUa0KyMOwMm2411YlO3Wx5JHzQDPGPI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199021)(1800799003)(186006)(2906002)(36756003)(83380400001)(5660300002)(2616005)(54906003)(6666004)(38100700002)(6486002)(66476007)(66556008)(6916009)(66946007)(6512007)(4326008)(316002)(31686004)(41300700001)(31696002)(86362001)(8936002)(8676002)(26005)(6506007)(478600001)(53546011)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlVTam5pUTd4LzNWd2pxcTY0b3hORmlMcTZ5RzBYcUhldlpQVy8xeDAvbWc2?= =?utf-8?B?dnNkVzBlR1ZRSzMycm16cTZ2WUFOTzgvK3R6RjV5ejg0MktjVElJTC9ERjB0?= =?utf-8?B?TThXQUFQaWhyYzlFSEx0SlMyYmRYQXRmeFk3cHVMcit6TzhDaGo5WnpJeUpB?= =?utf-8?B?SFVqNjIxcWc5bm5OY1Zub3A1MEFvWmd5Sk1KOUFWMEpRTXBobVA0S0NUUy9s?= =?utf-8?B?VkZDNUdJa2RrUHpGWFFHVzlENGlIQWcwNW12cVpjUjk2OCtnZEdpdlNXUDlv?= =?utf-8?B?YU8vUkw2UjZJNGJUV2xlUjJseGlvd2NxdGdqaWJQY25BRDcvTmYxUElRNVE0?= =?utf-8?B?ZENLRXRGWUU5aUN5bGJ0RVZMTXZleDQzY2VXclVjQlJhTnVyMnY0d1RxcFpl?= =?utf-8?B?RUZ3em1xSk1hbTUyWW9lQ0pTb3gvRUhPSXJwS2ZmVG5QSENMTHNDYTZveVgy?= =?utf-8?B?RmhuMldZejVEZVVyN2Z1bWtIYlh2RWZzWFZUOHI5aElWM211NGl5UWx2ZEpW?= =?utf-8?B?RjRsUHJJREttVTUramFXMWd0bWRkYUxPbXBZa1VMUjE4SUROUkkyY3d4U01m?= =?utf-8?B?a1BndTk3dm1uS1NWZTQ1OHJnUTdQZkVRR2t4d3I5dERGOFdJcFJQSHgzWE9Y?= =?utf-8?B?TmxpZnVKcnRRY1p0RGdsbllpR1cwNzJHMzByRlFmeEtmVDNDMkFVRmtrTUYy?= =?utf-8?B?cWltQ0dZeVNXcnZLRE1ZeHZPN1UzN0dnS1piU3ZEZ3VSdkdtalkySjV4ZkVy?= =?utf-8?B?OWgyRTBDSFlBU1g4dWk3WXR0dHM4a1EvVTJpWXU1Zk5KRjlza2tqakNXL05r?= =?utf-8?B?Q1JLOFNDbEIvSjZlYytvZFNUam03dEIydnZ4bjl5NHBpWEZRL1NqcFFEOFZ2?= =?utf-8?B?elVGUC91WkdQdm5CL3VWTWxpSzFrd2tGZm83cXRQQm4yMjZ3K0lDNWNNYjZi?= =?utf-8?B?TnkrYjFuZ2hyUzBnTjBoM080cDNuVFBvZU1rcHh0WVNjcFBPQm1yeWU1bGJY?= =?utf-8?B?YkNQYXlLK0tvelZ3UDE1WlA4VVJ0NmEzdTFZRmdZNkthVmkwdi9pT3VIdEtn?= =?utf-8?B?elhmTEtSMlZRVTdwK1A4Tzl5Zkk2TWZ1VVVGWHBwWUttbUVYQnRPM00yVkJI?= =?utf-8?B?Mng1SXhVUXd2TGZsckE2UndQZDZrWXBhUk9zdG95QTBMK21QMkd0V0srOWpY?= =?utf-8?B?L3VvMDBBVk41azZpSm04cVZ0NkF0aWs4U0dvUG5zNmZKb3l0Uy92ZjJWOFMy?= =?utf-8?B?VHo1Um9sTDR2aU1YR1A4RUVhVEZLeG5haGtmU1dodjE1YjJRelR5SXRGM2JX?= =?utf-8?B?R3cwb0RHR003SVRlSlNVK0ltQ01IcmprRHZQZldpa3NpRE1od3V2SWM2TzRv?= =?utf-8?B?OCtoK3Z2eGxGWi81T3B3M2ozcFlaRW5WNjZqN0F3NlhGdHNzNE5Tb0sxcm1u?= =?utf-8?B?MDdnQ3Qvek8rbTZPdnMySmlYQWpVRUxTQzlHVXQrS2hUUnM4ZGd1RjlsVVJn?= =?utf-8?B?RldkS1R1UmhEeFFhY1lBNllIa1lRbFh1bWczYmt5anJaTUxDQlFWM0FValJK?= =?utf-8?B?QnM2cWw1SEJkQmxBMzA0R08rWnhpNnp5U3BxTFdxSDhsTTBTMCs4dFJERXRw?= =?utf-8?B?blRTSTBILzdQMnVLWWhDMmIyeDNWWWF4NVVXemtDVzBEV0Nla1FYaWxvYUd4?= =?utf-8?B?T1VCT2hndDFBV0t5RFA2U3VzZUVENFY0MmhMbmoyUXJUS3NVNmV1SFZwU05t?= =?utf-8?B?RWJPQUpZZUQvVjY3dDNCLzJPTk51b29odHFSb2tTWG1BTU5JdGNYSk9VWjV3?= =?utf-8?B?YUQ5ZXJ3SFNVdHNVVVJ3Q1dVNHY3ODd4YklacWdJdk40M0lPMEhDVGhBM0hJ?= =?utf-8?B?KzF1QkVLU3MvTGMrSGZPSlY5ZXJjeXNBaXJ3RmNCOFdhaE5oaW80QnNhdUpq?= =?utf-8?B?R1E3ZWUzajVlL05sRkFLRldGSkYvVVpSZHFvbFdhL2orcHI2TjAvN0lUUThG?= =?utf-8?B?TStHYnNNY0ZPMXNtTzFQcjZlSnhFUWx3THUyMytvOTRvdlJYbkVzZHkyQ1RD?= =?utf-8?B?MndqdGtjL0tEZ0ovWVdRSms0dFlSZVRxUjhPMVpkT3F5bHFPZW5TbHVuNVpC?= =?utf-8?Q?WhpgJp63eLEwiEB8ZDXBjdE1m?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec5ba9ac-5f24-4814-b7a6-08db97613fd5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 16:13:34.3268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JlMQG9yMrTJMHnV5GZTi64P5BcRT8KK3SV1RR6bj4fz4WRgrhDeZ2r39dQiYuCx7N3oFThxInBQinKV8VfJfgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9726 On 03.08.2023 01:02, Shawn Anastasio wrote: > Implement atomic.h for PPC, based off of the original Xen 3.2 > implementation. Since likely that originally came from Linux, did you cross check that Linux hasn't gained any bug fixes in the meantime? Other than this just a couple of nits; I'm not really qualified to review in particular the inline assembly here, I'm afraid. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/atomic.h > @@ -0,0 +1,387 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* > + * PowerPC64 atomic operations > + * > + * Copyright (C) 2001 Paul Mackerras , IBM > + * Copyright (C) 2001 Anton Blanchard , IBM > + * Copyright Raptor Engineering LLC > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version > + * 2 of the License, or (at your option) any later version. > + */ > + > +#ifndef _ASM_PPC64_ATOMIC_H_ > +#define _ASM_PPC64_ATOMIC_H_ To fit the name, no "64" please. > +#include > + > +#include > +#include > + > +static inline int atomic_read(const atomic_t *v) > +{ > + return *(volatile int *)&v->counter; > +} > + > +static inline int _atomic_read(atomic_t v) > +{ > + return v.counter; > +} > + > +static inline void atomic_set(atomic_t *v, int i) > +{ > + v->counter = i; > +} > + > +static inline void _atomic_set(atomic_t *v, int i) > +{ > + v->counter = i; > +} > + > +void __bad_atomic_read(const volatile void *p, void *res); > +void __bad_atomic_size(void); > + > +#define build_atomic_read(name, insn, type) \ > + static inline type name(const volatile type *addr) \ > + { \ > + type ret; \ > + asm volatile ( insn "%U1%X1 %0,%1" : "=r"(ret) : "m<>"(*addr) ); \ As I think I had mentioned before, asm() contraints want a blank between closing quote and opend paren. I.e. like this asm volatile ( insn "%U1%X1 %0,%1" : "=r" (ret) : "m<>" (*addr) ); > +#define read_atomic(p) \ > + ({ \ > + union { \ > + typeof(*(p)) val; \ > + char c[0]; \ > + } x_; \ > + read_atomic_size(p, x_.c, sizeof(*(p))); \ > + x_.val; \ > + }) > + > +#define write_atomic(p, x) \ > + do \ > + { \ > + typeof(*(p)) x_ = (x); \ > + write_atomic_size(p, &x_, sizeof(*(p))); \ > + } while ( 0 ) Up to here you use underscore-suffixed locals, but then ... > +#define add_sized(p, x) \ > + ({ \ > + typeof(*(p)) __x = (x); \ ... you have even two prefixing underscores here. > + switch ( sizeof(*(p)) ) \ > + { \ > + case 1: \ > + add_u8_sized((uint8_t *) (p), __x); \ > + break; \ > + case 2: \ > + add_u16_sized((uint16_t *) (p), __x); \ > + break; \ > + case 4: \ > + add_u32_sized((uint32_t *) (p), __x); \ > + break; \ > + default: \ > + __bad_atomic_size(); \ > + break; \ > + } \ > + }) > + > +static inline void atomic_add(int a, atomic_t *v) > +{ > + int t; > + > + asm volatile ( "1: lwarx %0,0,%3\n" > + "add %0,%2,%0\n" > + "stwcx. %0,0,%3\n" > + "bne- 1b" > + : "=&r"(t), "=m"(v->counter) > + : "r"(a), "r"(&v->counter), "m"(v->counter) : "cc" ); "+m" and then drop the last input? > +static inline int atomic_dec_if_positive(atomic_t *v) > +{ > + int t; > + > + asm volatile(PPC_ATOMIC_ENTRY_BARRIER > + "1: lwarx %0,0,%1 # atomic_dec_if_positive\n" > + "addic. %0,%0,-1\n" > + "blt- 2f\n" > + "stwcx. %0,0,%1\n" > + "bne- 1b\n" > + PPC_ATOMIC_EXIT_BARRIER > + "2:" : "=&r"(t) > + : "r"(&v->counter) : "cc", "memory"); Missing blanks near the parentheses. Would also be nice if the padding blanks actually vertically aligned the operands. > + return t; > +} > + > +static inline atomic_t atomic_compareandswap(atomic_t old, atomic_t new, > + atomic_t *v) > +{ > + atomic_t rc; > + rc.counter = __cmpxchg(&v->counter, old.counter, new.counter, sizeof(int)); > + return rc; > +} > + > +#define arch_cmpxchg(ptr, o, n) \ > + ({ \ > + __typeof__(*(ptr)) _o_ = (o); \ > + __typeof__(*(ptr)) _n_ = (n); \ Problematic leading underscores again. > + (__typeof__(*(ptr))) __cmpxchg((ptr), (unsigned long) _o_, \ > + (unsigned long) _n_, sizeof(*(ptr))); \ > + }) > + > +static inline int atomic_cmpxchg(atomic_t *v, int old, int new) > +{ > + return arch_cmpxchg(&v->counter, old, new); > +} > + > +#define ATOMIC_OP(op, insn, suffix, sign) \ > + static inline void atomic_##op(int a, atomic_t *v) \ > + { \ > + int t; \ > + asm volatile ( "1: lwarx %0,0,%3\n" \ > + insn "%I2" suffix " %0,%0,%2\n" \ > + "stwcx. %0,0,%3 \n" \ > + "bne- 1b\n" \ > + : "=&r"(t), "+m"(v->counter) \ > + : "r" #sign(a), "r"(&v->counter) \ > + : "cc" ); \ > + } > + > +ATOMIC_OP(and, "and", ".", K) > + > +static inline int atomic_sub_and_test(int i, atomic_t *v) > +{ > + return atomic_sub_return(i, v) == 0; > +} > + > +static inline int atomic_inc_and_test(atomic_t *v) > +{ > + return atomic_add_return(1, v) == 0; > +} > + > +static inline int atomic_dec_and_test(atomic_t *v) > +{ > + return atomic_sub_return(1, v) == 0; > +} > + > +static inline int atomic_add_negative(int i, atomic_t *v) > +{ > + return atomic_add_return(i, v) < 0; > +} > + > +static inline int __atomic_add_unless(atomic_t *v, int a, int u) > +{ > + int c, old; > + > + c = atomic_read(v); > + while (c != u && (old = atomic_cmpxchg((v), c, c + a)) != c) Btw, no real need to parenthesize v in cases like this one. Otoh a needs parenthesizing. Jan From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:22:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:22:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578718.906355 (Exim 4.92) (envelope-from ) id 1qT30B-0000MT-1M; Mon, 07 Aug 2023 16:22:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578718.906355; Mon, 07 Aug 2023 16:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT30A-0000MM-UF; Mon, 07 Aug 2023 16:22:38 +0000 Received: by outflank-mailman (input) for mailman id 578718; Mon, 07 Aug 2023 16:22:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT309-0000MG-FB for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:22:37 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9d160c17-353e-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 18:22:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id E79ED8285614; Mon, 7 Aug 2023 11:22:32 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7Rdtpzm9DrP7; Mon, 7 Aug 2023 11:22:32 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id F2E2E8285869; Mon, 7 Aug 2023 11:22:31 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rfmzEZErQy5B; Mon, 7 Aug 2023 11:22:31 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 97FAA8285614; Mon, 7 Aug 2023 11:22:31 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d160c17-353e-11ee-b280-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com F2E2E8285869 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691425352; bh=U2qvdXd5/gE2j6fLA/EynBU+JzMY/KeOwVUZItiPaZA=; h=Message-ID:Date:MIME-Version:To:From; b=lFwHTlEjbiZn/KgYyhdNErvTH/X7A3NRlJKHnuzHAAp65bWa3k85nqJIQol/hxwFR f7HYNM5kjZMxV5ErAr+wMqdQ8+c6+HR9BGIgrCz0UN9IWIcPeJxyuIeViZ1q/rotR3 XwAJQ08Y6/RAv+7r/TqRmVF0RCtMBwSJtktvuNcw= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <62c8859d-8904-ce30-019b-df976378256c@raptorengineering.com> Date: Mon, 7 Aug 2023 11:22:31 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: From: Shawn Anastasio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/2/23 2:16 AM, Jan Beulich wrote: > On 02.08.2023 02:11, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/include/asm/asm-defns.h >> +++ b/xen/arch/ppc/include/asm/asm-defns.h >> @@ -16,6 +16,13 @@ >> lis reg, (val) @h; \ >> ori reg, reg, (val) @l; \ >> >> +/* >> + * Load the address of a symbol from the TOC into the specified GPR. >> + */ >> +#define LOAD_REG_ADDR(reg,name) \ >> + addis reg,%r2,name@toc@ha; \ >> + addi reg,reg,name@toc@l > > Didn't you indicate you'd add blanks after the commas (also) here? > >> --- a/xen/arch/ppc/ppc64/head.S >> +++ b/xen/arch/ppc/ppc64/head.S >> @@ -1,6 +1,7 @@ >> /* SPDX-License-Identifier: GPL-2.0-or-later */ >> >> #include >> +#include >> >> .section .text.header, "ax", %progbits >> >> @@ -11,16 +12,19 @@ ENTRY(start) >> FIXUP_ENDIAN >> >> /* set up the TOC pointer */ >> - LOAD_IMM32(%r2, .TOC.) >> + bcl 20, 31, 1f > > Hard tab slipped in. > > I'm happy to take care of both while committing; then: > Acked-by: Jan Beulich Thanks, Jan. Just to clarify, are there any outstanding comments that I need to address in this series, or are they all able to be handled by you during commit? > Jan - Shawn From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:26:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:26:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578724.906366 (Exim 4.92) (envelope-from ) id 1qT341-0000yj-HP; Mon, 07 Aug 2023 16:26:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578724.906366; Mon, 07 Aug 2023 16:26:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT341-0000yc-EZ; Mon, 07 Aug 2023 16:26:37 +0000 Received: by outflank-mailman (input) for mailman id 578724; Mon, 07 Aug 2023 16:26:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT340-0000yV-7v for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:26:36 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c691d46-353f-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 18:26:34 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3fe4cdb727cso28853975e9.0 for ; Mon, 07 Aug 2023 09:26:34 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id n4-20020a05600c294400b003fc05b89e5bsm11133310wmd.34.2023.08.07.09.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 09:26:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c691d46-353f-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691425593; x=1692030393; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=EKUUe6jb+Vbb+siDjVhEDsYJmexMFcVsomt1hi6nWb0=; b=KztarhwQevvRnwR6xL8VRN5V5NjUCfXfP9wHA1xtm6bduIynv4tHT/M1hYk8VpsUUz 5xCID/x50mYl14bsoX601fW3nXfI6u1MkZgeM9LKrrWMtr/vdBRCw/r/9wJvGVughiNV bbaQRfWk3CcoLrYvhn2gId/Wg4+NaJ+tGbe0U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691425593; x=1692030393; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EKUUe6jb+Vbb+siDjVhEDsYJmexMFcVsomt1hi6nWb0=; b=Tae7jo/oyTvxsaqeNZkTh69iaycPe6/fLIztlNrQpmI3kojXezgQTqB4huzRJ1NAYi rcEApNACPVN5mKkf4tx9M6KYcM5qA6M5rN7ohVibjgv2gq06QngxaTu8UA+YSjpMMNvY jMtEH134WNK0EQVYy1uIp02/NyyVLDtXVxdJq1B4pshvnR2rU/LYUyhlCiciqnBN7dNP W7zbvgksf4PE8I5uLr7XsZKlqx4Ek+4tnNH7FVJq0xOcbEjbb09oDL0CErqCkQdQTKl6 5VH0HVOaTRjkHaJl7TD4X1D23eNAtZjr3m4/vltakaisen5bfbwwQiSh7bPGkSpy0PVw PHNQ== X-Gm-Message-State: AOJu0YzJzn3q5ync0cEjV9XzO99WYhL9A4fF5vDOzhyGvP4iGM87mf3m ZwBFU7dVd4qLHKMzMxYmUkEydg== X-Google-Smtp-Source: AGHT+IFZukGiP8qBs7KGp9gFHntXWyu4NdJeckuiNmydV3RA13Ebaek9HmFOh+ijakcj3EwsY8xiBw== X-Received: by 2002:a1c:7c03:0:b0:3fe:43b4:55c with SMTP id x3-20020a1c7c03000000b003fe43b4055cmr7770688wmc.30.1691425593468; Mon, 07 Aug 2023 09:26:33 -0700 (PDT) Message-ID: <64d11b39.050a0220.2ab40.c2cc@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 7 Aug 2023 17:26:31 +0100 From: Alejandro Vallejo To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Xen-devel Subject: Re: [PATCH v2 2/5] mm: Factor out the pdx compression logic in ma/va converters References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-3-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 31, 2023 at 05:15:19PM +0200, Jan Beulich wrote: > On 28.07.2023 09:59, Alejandro Vallejo wrote: > > --- a/xen/include/xen/pdx.h > > +++ b/xen/include/xen/pdx.h > > @@ -160,6 +160,31 @@ static inline unsigned long pdx_to_pfn(unsigned long pdx) > > #define mfn_to_pdx(mfn) pfn_to_pdx(mfn_x(mfn)) > > #define pdx_to_mfn(pdx) _mfn(pdx_to_pfn(pdx)) > > > > +/** > > + * Computes the offset into the direct map of an maddr > > + * > > + * @param ma Machine address > > + * @return Offset on the direct map where that > > + * machine address can be accessed > > + */ > > +static inline unsigned long maddr_to_directmapoff(uint64_t ma) > > Was there prior agreement to use uint64_t here and ... > > > +{ > > + return ((ma & ma_top_mask) >> pfn_pdx_hole_shift) | > > + (ma & ma_va_bottom_mask); > > +} > > + > > +/** > > + * Computes a machine address given a direct map offset > > + * > > + * @param offset Offset into the direct map > > + * @return Corresponding machine address of that virtual location > > + */ > > +static inline uint64_t directmapoff_to_maddr(unsigned long offset) > > ... here, not paddr_t? The whole file uses uint64_t rather than paddr_t so I added the new code using the existing convention. I can just as well make it paddr_t, it's not a problem. > > Also you use unsigned long for the offset here, but size_t for > maddr_to_directmapoff()'s return value in __maddr_to_virt(). > Would be nice if this was consistent within the patch. That's fair. I can leave it as "unsigned long" (seeing that a previous nit was preferring that type over size_t). > Especially since the names of the helper functions are longish, > I'm afraid I'm not fully convinced of the transformation. In what sense? If it's just naming style I'm happy to consider other names, but taking compression logic out of non-pdx code is essential to removing compiling it out. > But I'm also not meaning to stand in the way, if everyone else wants to > move in that direction. > > Jan Thanks, Alejandro From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:43:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:43:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578730.906376 (Exim 4.92) (envelope-from ) id 1qT3KM-0003XY-RD; Mon, 07 Aug 2023 16:43:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578730.906376; Mon, 07 Aug 2023 16:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3KM-0003XR-O9; Mon, 07 Aug 2023 16:43:30 +0000 Received: by outflank-mailman (input) for mailman id 578730; Mon, 07 Aug 2023 16:43:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3KK-0003XL-Vg for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:43:28 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87d8a7b6-3541-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 18:43:26 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id DE71F4EE0737; Mon, 7 Aug 2023 18:43:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87d8a7b6-3541-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Mon, 07 Aug 2023 18:43:25 +0200 From: Nicola Vetrini To: Jan Beulich Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn?= =?UTF-8?Q?=C3=A9?= , Wei Liu , Stefano Stabellini Subject: Re: [XEN PATCH v2 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3 In-Reply-To: <17069ab9-03ff-9f7b-6480-d50e1349e16a@suse.com> References: <2f7380396ee146132738dd5c6b2a80d62a8035d5.1691135862.git.nicola.vetrini@bugseng.com> <17069ab9-03ff-9f7b-6480-d50e1349e16a@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 14:48, Jan Beulich wrote: > On 04.08.2023 22:45, Stefano Stabellini wrote: >> On Fri, 4 Aug 2023, Nicola Vetrini wrote: >>> Rename variables to avoid shadowing and thus address >>> MISRA C:2012 Rule 5.3: >>> "An identifier declared in an inner scope shall not hide an >>> identifier declared in an outer scope". >>> >>> The shadowing happens between the struct declaration 'mtrr_state' in >>> 'xen/arch/x86/include/asm/mtrr.h' and local variable names. > > Let's try to be precise: The issue isn't with the struct declaration, > but with the declaration of the global variable of that name a few > lines later. Afaict - please clarify. Yes, my wording is wrong. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:51:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578737.906385 (Exim 4.92) (envelope-from ) id 1qT3Rb-00056Y-IN; Mon, 07 Aug 2023 16:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578737.906385; Mon, 07 Aug 2023 16:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3Rb-00056R-Fo; Mon, 07 Aug 2023 16:50:59 +0000 Received: by outflank-mailman (input) for mailman id 578737; Mon, 07 Aug 2023 16:50:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3Ra-00056H-4Y for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:50:58 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 92525037-3542-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 18:50:53 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fe5c0e57d2so9901685e9.0 for ; Mon, 07 Aug 2023 09:50:53 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id k14-20020adfd84e000000b003177e9b2e64sm10978183wrl.90.2023.08.07.09.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 09:50:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92525037-3542-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691427053; x=1692031853; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=LKEm6G/V3XIQ0C2dYNohL+O7aJTA4lRLDP7gzEGgA2Q=; b=QEJDqAL6bDyZGDe82wOJ73Ywp0jMWfSPrMc2KIpwhdE0OZq9KZzrs0WZJzJXPtEPk6 hZ8IuAU8AOVR+oVQtd9VT2f2bWNYWkJcWaS1L/Zmu1uFyXIEeu05f6z2hSI6cj3gbTmx AIZvkLevrcHQx7LMAySlbGXobPfXMRPjqggrQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691427053; x=1692031853; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LKEm6G/V3XIQ0C2dYNohL+O7aJTA4lRLDP7gzEGgA2Q=; b=hdBpYqZzJVx7szRo6lHfKI6uEzYGkzGo1kCSyEyZzRkVLwtSexDqPk4BahaXJm5k9L BwSP7Z2m3b1P2SaUQkSFlFi58fkhGCqUvN3VlYk6u2NEaYtykKOkOHiB9vpoRk09S0MX 9cFWUH5yzz1/BtJxE2PYJv9YRl/wdayp25a9jYi7uArznRlqMjwR8sK8iwxyr6Yvhszq Zv83ThwMXQhgBZfKwtJyyEon47xuDIYl+dhVqFvcs8zdakcrR++DWjLfoGlCMSwm9qgo RbXsiYoCirH+GXq/ejICqALEF+yuAoWFU6S6ELCHacqJej4/QkMDK81TsJHaqQxLaA8A AaSw== X-Gm-Message-State: AOJu0YyQlPtY5OcXpe6jCSbTYuoHsNKkxypmo9Lr1tyI8v/F1+2p9rls f7WK4/xnrukaav4wZKZWH0jcuQ== X-Google-Smtp-Source: AGHT+IFjt2mnEDISgicoju+YH8lirAuvEMaxpaGRNahXNXLJbcJGz2ye/mPyRRAbO7LdE6Wv8TeH4Q== X-Received: by 2002:a05:600c:2119:b0:3fc:1a6:7764 with SMTP id u25-20020a05600c211900b003fc01a67764mr6396663wml.16.1691427052993; Mon, 07 Aug 2023 09:50:52 -0700 (PDT) Message-ID: <64d120ec.df0a0220.84f23.bc02@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 7 Aug 2023 17:50:50 +0100 From: Alejandro Vallejo To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Xen-devel Subject: Re: [PATCH v2 3/5] mm/pdx: Standardize region validation wrt pdx compression References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-4-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 31, 2023 at 05:27:22PM +0200, Jan Beulich wrote: > On 28.07.2023 09:59, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/x86_64/mm.c > > +++ b/xen/arch/x86/x86_64/mm.c > > @@ -1159,6 +1159,9 @@ static int mem_hotadd_check(unsigned long spfn, unsigned long epfn) > > { > > unsigned long s, e, length, sidx, eidx; > > > > + paddr_t mem_base = pfn_to_paddr(spfn); > > + unsigned long mem_npages = epfn - spfn; > > + > > if ( (spfn >= epfn) ) > > return 0; > > While occasionally groups of declarations indeed want separating, the > rule of thumb is that the first blank line after declarations separates > them from statements. I don't see reason here to diverge from this. Ack. > > > @@ -1660,6 +1663,8 @@ static bool __init cf_check rt_range_valid(unsigned long smfn, unsigned long emf > > > > void __init efi_init_memory(void) > > { > > + paddr_t mem_base; > > + unsigned long mem_npages; > > Why in the outermost scope when ... > > > @@ -1732,6 +1737,9 @@ void __init efi_init_memory(void) > > smfn = PFN_DOWN(desc->PhysicalStart); > > emfn = PFN_UP(desc->PhysicalStart + len); > > > > + mem_base = pfn_to_paddr(smfn); > > + mem_npages = emfn - smfn; > > + > > if ( desc->Attribute & EFI_MEMORY_WB ) > > prot |= _PAGE_WB; > > else if ( desc->Attribute & EFI_MEMORY_WT ) > > @@ -1759,8 +1767,7 @@ void __init efi_init_memory(void) > > prot |= _PAGE_NX; > > > > if ( pfn_to_pdx(emfn - 1) < (DIRECTMAP_SIZE >> PAGE_SHIFT) && > > - !(smfn & pfn_hole_mask) && > > - !((smfn ^ (emfn - 1)) & ~pfn_pdx_bottom_mask) ) > > + pdx_is_region_compressible(mem_base, mem_npages)) > > { > > if ( (unsigned long)mfn_to_virt(emfn - 1) >= HYPERVISOR_VIRT_END ) > > prot &= ~_PAGE_GLOBAL; > > ... you use the variables only in an inner one? No good reason. I defaulted to the top of the function because C90 was picky about declaring midway through a scope and I didn't consider going to the top of the scope instead. Ack. > > > --- a/xen/common/pdx.c > > +++ b/xen/common/pdx.c > > @@ -88,7 +88,7 @@ bool __mfn_valid(unsigned long mfn) > > } > > > > /* Sets all bits from the most-significant 1-bit down to the LSB */ > > -static uint64_t __init fill_mask(uint64_t mask) > > +static uint64_t fill_mask(uint64_t mask) > > { > > while (mask & (mask + 1)) > > mask |= mask + 1; > > I see why you want __init dropped here, but the function wasn't written > for "common use" and hence may want improving first when intended for > more frequent (post-init) use as well. It's not so much that I want it rather than I need it. hotadd_mem_check() uses it and it's not part of the init process. That's the only non-init use of it, and it hardly qualifies as "common". IMO, don't matter a whole > Then again I wonder why original > checking all got away without using this function ... > > Jan My guess is that most real systems don't exercise the corner cases, and so the code was just silently broken passing the checks all the time. I could not find an explanation for the OR check in hotadd_mem_check(), so I just attributed it to being a bug introduced out of lack of knowledge of pdx. Thanks, Alejandro From xen-devel-bounces@lists.xenproject.org Mon Aug 07 16:59:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 16:59:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578743.906396 (Exim 4.92) (envelope-from ) id 1qT3ZZ-0005oR-CT; Mon, 07 Aug 2023 16:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578743.906396; Mon, 07 Aug 2023 16:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3ZZ-0005oK-9B; Mon, 07 Aug 2023 16:59:13 +0000 Received: by outflank-mailman (input) for mailman id 578743; Mon, 07 Aug 2023 16:59:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3ZX-0005oE-CO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 16:59:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7f502e2-3543-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 18:59:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7f502e2-3543-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691427548; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nm5R7soTv5fti98FGiCgyddGgN3CHcBysJb401uIthc=; b=VOR+NWkohaCBrSJ4voRDpYFedAdQm5CZFdE2OLFG5IJPlKHbyECV0rQy JCcKN6ZXt0slDrwIMG6PoOShAShVf2W2KMrmWnVJISIFLdrwlQoH1QABB 8ogE7Habf7t9ORkDY2B9djjIWVVNJMmxup654LMjbFqxCNGTvc/KNtYt4 Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118766919 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:8n0036KPdBGWsLaXFE+Rx5UlxSXFcZb7ZxGr2PjKsXjdYENS0zcFz GIaDGHVaPnbYmfzfdh/Oom/oB8HupbRzN8xSQtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRhPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c50H29Pz fg1CgknYzK6mriQ+qugG/Rj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWteGknHTgNRZfr0qYv/Ef6GnP1g1hlrPqNbI5f/TTHJUKwBjJ/ zOuE2LRXEFDDI2+6ii5zWOnmqjhjQSndo4OC+jtnhJtqALKnTFCYPEMbnOrrP/8hkOgVtZ3L 00P5jFovaU07FasTNT2Q1u/unHsljw2VsdUEuY6wBqQ0aeS6AGcbkAbShZRZdpgs9U5LQHGz XfQwYmvX2Y29uTIFzTErOz8QS6O1TY9LnEMZBcAYCk8ydTBmZxpqCjWVYd+H/vg5jHqIg3Yz zePpSk4orwci88Xyqm2lWz6byKQSovhFVBsuFiONo6xxkYgPdP+OdT0gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hP0yT4FWyzyGskTKuMDirjUWGBX aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YgLVTbonEyOxPJhQgBdXTAdollY /+mnTuEVy5GWcyLMhLpLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtaTOzghQCxPrc+m39q o8PX/ZmPj0DCIUSlAGLq99MRb3LRFBnba3LRzt/L7PafFA4Qjt9Wpc8A9oJIuRYokicrc+Ql lnVZ6OS4ACXaaHvQelSVk1eVQ== IronPort-HdrOrdr: A9a23:nKV3vqxJwm67lWMa6hzWKrPwIL1zdoMgy1knxilNoRw8SKKlfq eV7ZMmPH7P+VIssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyHJ8SUzI9gPM lbHJSWcOeAb2RHsQ== X-Talos-CUID: 9a23:JzFMcW4lolG4XEZuodss91AaG/ghX1/k5nryGlLiL1xwU+yIRgrF X-Talos-MUID: 9a23:3/UUJQp1yvgyl4Uq6IMez28ybf85woe8NH8cmolBldmjaQJ8JyjI2Q== X-IronPort-AV: E=Sophos;i="6.01,262,1684814400"; d="scan'208";a="118766919" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen/IOMMU: Switch bool_t to bool Date: Mon, 7 Aug 2023 17:58:30 +0100 Message-ID: <20230807165830.6719-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... as part of cleaning up the types used. Minor style cleanup on some altered lines. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau MonnĂ© CC: Wei Liu --- xen/drivers/passthrough/amd/iommu.h | 4 ++-- xen/drivers/passthrough/amd/iommu_acpi.c | 6 +++--- xen/drivers/passthrough/amd/iommu_init.c | 6 +++--- xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- xen/drivers/passthrough/ats.c | 2 +- xen/drivers/passthrough/ats.h | 2 +- xen/drivers/passthrough/device_tree.c | 4 ++-- xen/drivers/passthrough/iommu.c | 8 ++++---- xen/drivers/passthrough/pci.c | 16 ++++++++-------- xen/drivers/passthrough/vtd/dmar.c | 6 +++--- xen/drivers/passthrough/vtd/extern.h | 6 +++--- xen/drivers/passthrough/vtd/iommu.c | 18 +++++++++--------- xen/drivers/passthrough/vtd/qinval.c | 2 +- xen/drivers/passthrough/vtd/quirks.c | 8 ++++---- xen/drivers/passthrough/vtd/x86/ats.c | 2 +- xen/include/xen/iommu.h | 6 +++--- 16 files changed, 49 insertions(+), 49 deletions(-) diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h index 5429ada58ef5..acbaad30d564 100644 --- a/xen/drivers/passthrough/amd/iommu.h +++ b/xen/drivers/passthrough/amd/iommu.h @@ -174,7 +174,7 @@ struct guest_iommu { struct domain *domain; spinlock_t lock; - bool_t enabled; + bool enabled; struct guest_dev_table dev_table; struct guest_buffer cmd_buffer; @@ -194,7 +194,7 @@ struct guest_iommu { struct guest_iommu_msi msi; }; -extern bool_t iommuv2_enabled; +extern bool iommuv2_enabled; struct acpi_ivrs_hardware; diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index 3b577c9b390c..891c6c6ddde2 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -1063,14 +1063,14 @@ static unsigned int __initdata nr_ivmd; #define to_ivmd_block(hdr) \ container_of(hdr, const struct acpi_ivrs_memory, header) -static inline bool_t is_ivhd_block(u8 type) +static inline bool is_ivhd_block(u8 type) { return (type == ACPI_IVRS_TYPE_HARDWARE || ((amd_iommu_acpi_info & ACPI_IVRS_EFR_SUP) && type == ACPI_IVRS_TYPE_HARDWARE_11H)); } -static inline bool_t is_ivmd_block(u8 type) +static inline bool is_ivmd_block(u8 type) { return (type == ACPI_IVRS_TYPE_MEMORY_ALL || type == ACPI_IVRS_TYPE_MEMORY_ONE || @@ -1102,7 +1102,7 @@ static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) const struct acpi_ivrs_header *ivrs_block; unsigned long length; unsigned int apic, i; - bool_t sb_ioapic = !iommu_intremap; + bool sb_ioapic = !iommu_intremap; int error = 0; BUG_ON(!table); diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index af6713d2fc02..41ec38bb72eb 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -34,7 +34,7 @@ unsigned int __read_mostly ivrs_bdf_entries; u8 __read_mostly ivhd_type; static struct radix_tree_root ivrs_maps; LIST_HEAD_READ_MOSTLY(amd_iommu_head); -bool_t iommuv2_enabled; +bool iommuv2_enabled; bool __ro_after_init amd_iommu_perdev_intremap = true; @@ -737,7 +737,7 @@ static void cf_check iommu_interrupt_handler( tasklet_schedule(&amd_iommu_irq_tasklet); } -static bool_t __init set_iommu_interrupt_handler(struct amd_iommu *iommu) +static bool __init set_iommu_interrupt_handler(struct amd_iommu *iommu) { int irq, ret; @@ -1329,7 +1329,7 @@ static int __init cf_check amd_iommu_setup_device_table( } /* Check whether SP5100 SATA Combined mode is on */ -static bool_t __init amd_sp5100_erratum28(void) +static bool __init amd_sp5100_erratum28(void) { u32 bus, id; u16 vendor_id, dev_id; diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c index 94e37755064b..f7f9f4e5423a 100644 --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -28,7 +28,7 @@ /* dom_io is used as a sentinel for quarantined devices */ #define QUARANTINE_SKIP(d, p) ((d) == dom_io && !(p)->arch.amd.root_table) -static bool_t __read_mostly init_done; +static bool __read_mostly init_done; static const struct iommu_init_ops _iommu_init_ops; diff --git a/xen/drivers/passthrough/ats.c b/xen/drivers/passthrough/ats.c index 7f7b16dc490c..253f5c2e1042 100644 --- a/xen/drivers/passthrough/ats.c +++ b/xen/drivers/passthrough/ats.c @@ -18,7 +18,7 @@ #include #include "ats.h" -bool_t __read_mostly ats_enabled = 0; +bool __read_mostly ats_enabled; boolean_param("ats", ats_enabled); int enable_ats_device(struct pci_dev *pdev, struct list_head *ats_list) diff --git a/xen/drivers/passthrough/ats.h b/xen/drivers/passthrough/ats.h index c202f4ecdd67..baa5f6a6dc04 100644 --- a/xen/drivers/passthrough/ats.h +++ b/xen/drivers/passthrough/ats.h @@ -22,7 +22,7 @@ #define ATS_QUEUE_DEPTH_MASK 0x1f #define ATS_ENABLE (1<<15) -extern bool_t ats_enabled; +extern bool ats_enabled; int enable_ats_device(struct pci_dev *pdev, struct list_head *ats_list); void disable_ats_device(struct pci_dev *pdev); diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 1c32d7b50cce..3c0322c7973d 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -83,9 +83,9 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev) return rc; } -static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) +static bool iommu_dt_device_is_assigned(const struct dt_device_node *dev) { - bool_t assigned = 0; + bool assigned = false; if ( !dt_device_is_protected(dev) ) return 0; diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 7bbe3889a214..f9a9f53dbd44 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -29,7 +29,7 @@ bool __initdata iommu_enable = 1; bool __read_mostly iommu_enabled; bool __read_mostly force_iommu; bool __read_mostly iommu_verbose; -static bool_t __read_mostly iommu_crash_disable; +static bool __read_mostly iommu_crash_disable; #define IOMMU_quarantine_none 0 /* aka false */ #define IOMMU_quarantine_basic 1 /* aka true */ @@ -59,7 +59,7 @@ bool __read_mostly iommu_hap_pt_share = true; bool __read_mostly iommu_debug; -DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb); +DEFINE_PER_CPU(bool, iommu_dont_flush_iotlb); static int __init cf_check parse_iommu_param(const char *s) { @@ -548,7 +548,7 @@ static int __init iommu_quarantine_init(void) int __init iommu_setup(void) { int rc = -ENODEV; - bool_t force_intremap = force_iommu && iommu_intremap; + bool force_intremap = force_iommu && iommu_intremap; if ( iommu_hwdom_strict ) iommu_hwdom_passthrough = false; @@ -672,7 +672,7 @@ int iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt) return iommu_call(ops, get_reserved_device_memory, func, ctxt); } -bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) +bool iommu_has_feature(struct domain *d, enum iommu_feature feature) { return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 33452791a8e0..ed1f689227fa 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -62,7 +62,7 @@ void pcidevs_unlock(void) spin_unlock_recursive(&_pcidevs_lock); } -bool_t pcidevs_locked(void) +bool pcidevs_locked(void) { return !!spin_is_locked(&_pcidevs_lock); } @@ -74,7 +74,7 @@ static inline struct pci_seg *get_pseg(u16 seg) return radix_tree_lookup(&pci_segments, seg); } -bool_t pci_known_segment(u16 seg) +bool pci_known_segment(u16 seg) { return get_pseg(seg) != NULL; } @@ -984,7 +984,7 @@ int find_upstream_bridge(u16 seg, u8 *bus, u8 *devfn, u8 *secbus) return ret; } -bool_t __init pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func) +bool __init pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func) { u32 vendor; @@ -1181,7 +1181,7 @@ static int hest_match_pci(const struct acpi_hest_aer_common *p, p->function == PCI_FUNC(pdev->devfn); } -static bool_t hest_match_type(const struct acpi_hest_header *hest_hdr, +static bool hest_match_type(const struct acpi_hest_header *hest_hdr, const struct pci_dev *pdev) { unsigned int pos = pci_find_cap_offset(pdev->seg, pdev->bus, @@ -1207,10 +1207,10 @@ static bool_t hest_match_type(const struct acpi_hest_header *hest_hdr, struct aer_hest_parse_info { const struct pci_dev *pdev; - bool_t firmware_first; + bool firmware_first; }; -static bool_t hest_source_is_pcie_aer(const struct acpi_hest_header *hest_hdr) +static bool hest_source_is_pcie_aer(const struct acpi_hest_header *hest_hdr) { if ( hest_hdr->type == ACPI_HEST_TYPE_AER_ROOT_PORT || hest_hdr->type == ACPI_HEST_TYPE_AER_ENDPOINT || @@ -1224,7 +1224,7 @@ static int cf_check aer_hest_parse( { struct aer_hest_parse_info *info = data; const struct acpi_hest_aer_common *p; - bool_t ff; + bool ff; if ( !hest_source_is_pcie_aer(hest_hdr) ) return 0; @@ -1254,7 +1254,7 @@ static int cf_check aer_hest_parse( return 0; } -bool_t pcie_aer_get_firmware_first(const struct pci_dev *pdev) +bool pcie_aer_get_firmware_first(const struct pci_dev *pdev) { struct aer_hest_parse_info info = { .pdev = pdev }; diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 4936c20952ec..07772f178fe6 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -149,7 +149,7 @@ struct vtd_iommu *ioapic_to_iommu(unsigned int apic_id) return NULL; } -static bool_t acpi_hpet_device_match( +static bool acpi_hpet_device_match( struct list_head *list, unsigned int hpet_id) { struct acpi_hpet_unit *hpet; @@ -1052,14 +1052,14 @@ void acpi_dmar_zap(void) write_atomic((uint32_t*)&dmar_table->signature[0], sig); } -bool_t platform_supports_intremap(void) +bool platform_supports_intremap(void) { const unsigned int mask = ACPI_DMAR_INTR_REMAP; return (dmar_flags & mask) == ACPI_DMAR_INTR_REMAP; } -bool_t __init platform_supports_x2apic(void) +bool __init platform_supports_x2apic(void) { const unsigned int mask = ACPI_DMAR_INTR_REMAP | ACPI_DMAR_X2APIC_OPT_OUT; diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h index d49e40c5ce7d..667590ee52df 100644 --- a/xen/drivers/passthrough/vtd/extern.h +++ b/xen/drivers/passthrough/vtd/extern.h @@ -26,7 +26,7 @@ #define VTDPREFIX "[VT-D]" struct pci_ats_dev; -extern bool_t rwbf_quirk; +extern bool rwbf_quirk; extern const struct iommu_init_ops intel_iommu_init_ops; void print_iommu_regs(struct acpi_drhd_unit *drhd); @@ -111,7 +111,7 @@ int __must_check me_wifi_quirk(struct domain *domain, uint8_t bus, void pci_vtd_quirk(const struct pci_dev *); void quirk_iommu_caps(struct vtd_iommu *iommu); -bool_t platform_supports_intremap(void); -bool_t platform_supports_x2apic(void); +bool platform_supports_intremap(void); +bool platform_supports_x2apic(void); #endif // _VTD_EXTERN_H_ diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index 0e3062c820f9..d34c98d9c773 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -644,8 +644,8 @@ static int __must_check iommu_flush_iotlb_global(struct vtd_iommu *iommu, } static int __must_check iommu_flush_iotlb_dsi(struct vtd_iommu *iommu, u16 did, - bool_t flush_non_present_entry, - bool_t flush_dev_iotlb) + bool flush_non_present_entry, + bool flush_dev_iotlb) { int status; @@ -663,8 +663,8 @@ static int __must_check iommu_flush_iotlb_dsi(struct vtd_iommu *iommu, u16 did, static int __must_check iommu_flush_iotlb_psi(struct vtd_iommu *iommu, u16 did, u64 addr, unsigned int order, - bool_t flush_non_present_entry, - bool_t flush_dev_iotlb) + bool flush_non_present_entry, + bool flush_dev_iotlb) { int status; @@ -694,7 +694,7 @@ static int __must_check iommu_flush_all(void) { struct acpi_drhd_unit *drhd; struct vtd_iommu *iommu; - bool_t flush_dev_iotlb; + bool flush_dev_iotlb; int rc = 0; flush_local(FLUSH_CACHE); @@ -736,7 +736,7 @@ static int __must_check cf_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, struct domain_iommu *hd = dom_iommu(d); struct acpi_drhd_unit *drhd; struct vtd_iommu *iommu; - bool_t flush_dev_iotlb; + bool flush_dev_iotlb; int iommu_domid; int ret = 0; @@ -1480,7 +1480,7 @@ int domain_context_mapping_one( uint16_t seg = iommu->drhd->segment, prev_did = 0; struct domain *prev_dom = NULL; int rc, ret; - bool_t flush_dev_iotlb; + bool flush_dev_iotlb; if ( QUARANTINE_SKIP(domain, pgd_maddr) ) return 0; @@ -1874,7 +1874,7 @@ int domain_context_unmap_one( struct context_entry *context, *context_entries; u64 maddr; int iommu_domid, rc, ret; - bool_t flush_dev_iotlb; + bool flush_dev_iotlb; ASSERT(pcidevs_locked()); spin_lock(&iommu->lock); @@ -2873,7 +2873,7 @@ static int cf_check intel_iommu_assign_device( if ( rmrr->segment == seg && bdf == PCI_BDF(bus, devfn) && rmrr->scope.devices_cnt > 1 ) { - bool_t relaxed = !!(flag & XEN_DOMCTL_DEV_RDM_RELAXED); + bool relaxed = flag & XEN_DOMCTL_DEV_RDM_RELAXED; printk(XENLOG_GUEST "%s" VTDPREFIX " It's %s to assign %pp" diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c index 4f9ad136b9c5..036f3e850544 100644 --- a/xen/drivers/passthrough/vtd/qinval.c +++ b/xen/drivers/passthrough/vtd/qinval.c @@ -152,7 +152,7 @@ static int __must_check queue_invalidate_iotlb_sync(struct vtd_iommu *iommu, static int __must_check queue_invalidate_wait(struct vtd_iommu *iommu, u8 iflag, u8 sw, u8 fn, - bool_t flush_dev_iotlb) + bool flush_dev_iotlb) { static DEFINE_PER_CPU(uint32_t, poll_slot); unsigned int index; diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index fcc8f73e8b90..5d706a539788 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -56,9 +56,9 @@ static unsigned int snb_igd_timeout; static u32 __read_mostly ioh_id; static u32 __initdata igd_id; -bool_t __read_mostly rwbf_quirk; -static bool_t __read_mostly is_cantiga_b3; -static bool_t __read_mostly is_snb_gfx; +bool __read_mostly rwbf_quirk; +static bool __read_mostly is_cantiga_b3; +static bool __read_mostly is_snb_gfx; static u8 *__read_mostly igd_reg_va; static spinlock_t igd_lock; @@ -498,7 +498,7 @@ void pci_vtd_quirk(const struct pci_dev *pdev) int seg = pdev->seg; int bus = pdev->bus; int pos; - bool_t ff; + bool ff; u32 val, val2; u64 bar; paddr_t pa; diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c index 04d702b1d6b1..9de419775f90 100644 --- a/xen/drivers/passthrough/vtd/x86/ats.c +++ b/xen/drivers/passthrough/vtd/x86/ats.c @@ -119,7 +119,7 @@ int dev_invalidate_iotlb(struct vtd_iommu *iommu, u16 did, list_for_each_entry_safe( pdev, temp, &iommu->ats_devices, ats.list ) { - bool_t sbit; + bool sbit; int rc = 0; switch ( type ) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 110693c59fe8..0e33ff79684b 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -46,7 +46,7 @@ static inline dfn_t dfn_add(dfn_t dfn, unsigned long i) return _dfn(dfn_x(dfn) + i); } -static inline bool_t dfn_eq(dfn_t x, dfn_t y) +static inline bool dfn_eq(dfn_t x, dfn_t y) { return dfn_x(x) == dfn_x(y); } @@ -193,7 +193,7 @@ enum iommu_feature IOMMU_FEAT_count }; -bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature); +bool iommu_has_feature(struct domain *d, enum iommu_feature feature); #ifdef CONFIG_HAS_PCI struct pirq; @@ -409,7 +409,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev); * iommu_iotlb_flush/iommu_iotlb_flush_all will be explicitly called by * the caller. */ -DECLARE_PER_CPU(bool_t, iommu_dont_flush_iotlb); +DECLARE_PER_CPU(bool, iommu_dont_flush_iotlb); extern struct spinlock iommu_pt_cleanup_lock; extern struct page_list_head iommu_pt_cleanup_list; -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 17:02:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 17:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578749.906406 (Exim 4.92) (envelope-from ) id 1qT3cf-0007LH-Uy; Mon, 07 Aug 2023 17:02:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578749.906406; Mon, 07 Aug 2023 17:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3cf-0007LA-SA; Mon, 07 Aug 2023 17:02:25 +0000 Received: by outflank-mailman (input) for mailman id 578749; Mon, 07 Aug 2023 17:02:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3ce-0007L0-RI for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 17:02:24 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d7fb694-3544-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 19:02:23 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id 55C414EE0737; Mon, 7 Aug 2023 19:02:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d7fb694-3544-11ee-b280-6b7b168915f2 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3 Date: Mon, 7 Aug 2023 19:02:05 +0200 Message-Id: <8536f54b708a1b3a906d14a63958c2e6dd0d034e.1691427640.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A missing change to the type in 'opt_arat' declaration introduced a new violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). Change the type to restore the consistency between all declarations of the object and drop a further usage of 'bool_t'. Fixes: 202a341f ("x86: Address violations of MISRA C:2012 by replacing bool_t uses") Reported-by: Andrew Cooper Signed-off-by: Federico Serafini --- xen/arch/x86/cpu/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index 85a67771f7..e3d06278b3 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -7,7 +7,7 @@ struct cpu_dev { extern const struct cpu_dev intel_cpu_dev, amd_cpu_dev, centaur_cpu_dev, shanghai_cpu_dev, hygon_cpu_dev; -extern bool_t opt_arat; +extern bool opt_arat; extern unsigned int opt_cpuid_mask_ecx, opt_cpuid_mask_edx; extern unsigned int opt_cpuid_mask_xsave_eax; extern unsigned int opt_cpuid_mask_ext_ecx, opt_cpuid_mask_ext_edx; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 17:22:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 17:22:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578757.906415 (Exim 4.92) (envelope-from ) id 1qT3wM-0001TK-Ic; Mon, 07 Aug 2023 17:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578757.906415; Mon, 07 Aug 2023 17:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3wM-0001TD-G8; Mon, 07 Aug 2023 17:22:46 +0000 Received: by outflank-mailman (input) for mailman id 578757; Mon, 07 Aug 2023 17:22:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3wK-0001T3-MJ; Mon, 07 Aug 2023 17:22:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3wK-0005mj-CE; Mon, 07 Aug 2023 17:22:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT3wJ-0002of-Us; Mon, 07 Aug 2023 17:22:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qT3wJ-0002xf-UN; Mon, 07 Aug 2023 17:22:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Dn3P1dz/nc1VzAoqzSCIa0byyg1Va2PzA9Y/L4mCWxs=; b=3CwOKQ6wGfU5jEXISQemZIxlNh eMsUCJDt1vjTNXSB7l7CUhWt1BsFTQoXBYfEMVwHxA+2pltfWGaga3YzyMhfTbg6xLBLCquThdQh6 ms95ynZjxJdqtTJ+OhrybqkIpOutmCeOVjRdnWzQ5MPRUkidbz5HCra1xu6hbX4xwXuc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182218: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 X-Osstest-Versions-That: xen=d63ea6c46b89bffb99647871c788c236a8286646 From: osstest service owner Date: Mon, 07 Aug 2023 17:22:43 +0000 flight 182218 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182218/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 baseline version: xen d63ea6c46b89bffb99647871c788c236a8286646 Last test of basis 182212 2023-08-07 10:00:26 Z 0 days Testing same since 182218 2023-08-07 15:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alejandro Vallejo Andrew Cooper Henry Wang Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d63ea6c46b..65f0d6fc80 65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Aug 07 17:48:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 17:48:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578765.906425 (Exim 4.92) (envelope-from ) id 1qT4L5-00044Q-J9; Mon, 07 Aug 2023 17:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578765.906425; Mon, 07 Aug 2023 17:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4L5-00044J-GX; Mon, 07 Aug 2023 17:48:19 +0000 Received: by outflank-mailman (input) for mailman id 578765; Mon, 07 Aug 2023 17:48:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4L3-00044D-RZ for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 17:48:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4L2-0006BZ-0D; Mon, 07 Aug 2023 17:48:16 +0000 Received: from [54.239.6.189] (helo=[192.168.12.178]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qT4L1-0001Hg-PP; Mon, 07 Aug 2023 17:48:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4mhyzpQg4k7lygPAEO6SHdHU7c/LBQh23TewNpjKVWU=; b=VSY0tj/hNdRir45NmYKW44F/m9 U0D0b9xttQjBDw+/rkpRBNhf+2XT8yeOX68tVT+dADdjErUKN02P0J1focSgq/I6AyJMKEQQ6kzx/ ZBGAc7siUlTG3dSlG/qwI33KPYZsDFTpf4D4iLWBZ2RlNG4bik924Aho6mpoYf8dpeIY=; Message-ID: <5bd0894b-6114-48dd-8c7f-2d1fe142c9d8@xen.org> Date: Mon, 7 Aug 2023 18:48:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option Content-Language: en-GB To: Alejandro Vallejo , Xen-devel Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-6-alejandro.vallejo@cloud.com> From: Julien Grall In-Reply-To: <20230728075903.7838-6-alejandro.vallejo@cloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Alex, One more remark in the title. s/HAS// as you renamed the Kconfig. On 28/07/2023 08:59, Alejandro Vallejo wrote: > Adds a new compile-time flag to allow disabling pdx compression and > compiles out compression-related code/data. It also shorts the pdx<->pfn > conversion macros and creates stubs for masking fucntions. > > While at it, removes the old arch-defined CONFIG_HAS_PDX flag, as it was > not removable in practice. > > Signed-off-by: Alejandro Vallejo > --- > v2: > * Merged v1/patch2: Removal of CONFIG_HAS_PDX here (Jan) > --- > xen/arch/arm/Kconfig | 1 - > xen/arch/x86/Kconfig | 1 - > xen/arch/x86/domain.c | 19 +++++++++++++------ > xen/common/Kconfig | 13 ++++++++++--- > xen/common/Makefile | 2 +- > xen/common/pdx.c | 15 +++++++++++---- > xen/include/xen/pdx.h | 37 ++++++++++++++++++++++++++++++++++--- > 7 files changed, 69 insertions(+), 19 deletions(-) > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index 439cc94f33..ea1949fbaa 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -14,7 +14,6 @@ config ARM > select HAS_ALTERNATIVE > select HAS_DEVICE_TREE > select HAS_PASSTHROUGH > - select HAS_PDX > select HAS_PMAP > select HAS_UBSAN > select IOMMU_FORCE_PT_SHARE > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 92f3a627da..30df085d96 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -24,7 +24,6 @@ config X86 > select HAS_PASSTHROUGH > select HAS_PCI > select HAS_PCI_MSI > - select HAS_PDX > select HAS_SCHED_GRANULARITY > select HAS_UBSAN > select HAS_VPCI if HVM > diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c > index 5f66c2ae33..ee2830aad7 100644 > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -458,7 +458,7 @@ void domain_cpu_policy_changed(struct domain *d) > } > } > > -#ifndef CONFIG_BIGMEM > +#if !defined(CONFIG_BIGMEM) && defined(CONFIG_PDX_COMPRESSION) > /* > * The hole may be at or above the 44-bit boundary, so we need to determine > * the total bit count until reaching 32 significant (not squashed out) bits > @@ -485,13 +485,20 @@ static unsigned int __init noinline _domain_struct_bits(void) > struct domain *alloc_domain_struct(void) > { > struct domain *d; > -#ifdef CONFIG_BIGMEM > - const unsigned int bits = 0; > -#else > + > /* > - * We pack the PDX of the domain structure into a 32-bit field within > - * the page_info structure. Hence the MEMF_bits() restriction. > + * Without CONFIG_BIGMEM, we pack the PDX of the domain structure into > + * a 32-bit field within the page_info structure. Hence the MEMF_bits() > + * restriction. With PDX compression in place the number of bits must > + * be calculated at runtime, but it's fixed otherwise. > + * > + * On systems with CONFIG_BIGMEM there's no packing, and so there's no > + * such restriction. > */ > +#if defined(CONFIG_BIGMEM) || !defined(CONFIG_PDX_COMPRESSION) > + const unsigned int bits = IS_ENABLED(CONFIG_BIGMEM) ? 0 : > + 32 + PAGE_SHIFT; > +#else > static unsigned int __read_mostly bits; > > if ( unlikely(!bits) ) > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index dd8d7c3f1c..3a0afd8e83 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -23,6 +23,16 @@ config GRANT_TABLE > > If unsure, say Y. > > +config PDX_COMPRESSION > + bool "PDX (Page inDeX) compression support" > + default ARM > + help > + PDX compression is a technique that allows the hypervisor to > + represent physical addresses in a very space-efficient manner. > + This is very helpful reducing memory wastage in systems with > + memory banks with base addresses far from each other, but carrier > + a performance cost. > + > config ALTERNATIVE_CALL > bool > > @@ -53,9 +63,6 @@ config HAS_IOPORTS > config HAS_KEXEC > bool > > -config HAS_PDX > - bool > - > config HAS_PMAP > bool > > diff --git a/xen/common/Makefile b/xen/common/Makefile > index 46049eac35..0020cafb8a 100644 > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -29,7 +29,7 @@ obj-y += multicall.o > obj-y += notifier.o > obj-$(CONFIG_NUMA) += numa.o > obj-y += page_alloc.o > -obj-$(CONFIG_HAS_PDX) += pdx.o > +obj-y += pdx.o > obj-$(CONFIG_PERF_COUNTERS) += perfc.o > obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o > obj-y += preempt.o > diff --git a/xen/common/pdx.c b/xen/common/pdx.c > index d3d38965bd..a3b1ba9fbb 100644 > --- a/xen/common/pdx.c > +++ b/xen/common/pdx.c > @@ -31,11 +31,15 @@ unsigned long __read_mostly pdx_group_valid[BITS_TO_LONGS( > > bool __mfn_valid(unsigned long mfn) > { > - if ( unlikely(evaluate_nospec(mfn >= max_page)) ) > + bool invalid = mfn >= max_page; > +#ifdef CONFIG_PDX_COMPRESSION > + invalid |= mfn & pfn_hole_mask; > +#endif > + > + if ( unlikely(evaluate_nospec(invalid)) ) > return false; > - return likely(!(mfn & pfn_hole_mask)) && > - likely(test_bit(pfn_to_pdx(mfn) / PDX_GROUP_COUNT, > - pdx_group_valid)); > + > + return test_bit(pfn_to_pdx(mfn) / PDX_GROUP_COUNT, pdx_group_valid); > } > > void set_pdx_range(unsigned long smfn, unsigned long emfn) > @@ -49,6 +53,8 @@ void set_pdx_range(unsigned long smfn, unsigned long emfn) > __set_bit(idx, pdx_group_valid); > } > > +#ifdef CONFIG_PDX_COMPRESSION > + > /* > * Diagram to make sense of the following variables. The masks and shifts > * are done on mfn values in order to convert to/from pdx: > @@ -175,6 +181,7 @@ void __init pfn_pdx_hole_setup(unsigned long mask) > pfn_top_mask = ~(pfn_pdx_bottom_mask | pfn_hole_mask); > ma_top_mask = pfn_top_mask << PAGE_SHIFT; > } > +#endif /* CONFIG_PDX_COMPRESSION */ > > > /* > diff --git a/xen/include/xen/pdx.h b/xen/include/xen/pdx.h > index 5a82b6bde2..dfb475c8dc 100644 > --- a/xen/include/xen/pdx.h > +++ b/xen/include/xen/pdx.h > @@ -67,8 +67,6 @@ > * region involved. > */ > > -#ifdef CONFIG_HAS_PDX > - > extern unsigned long max_pdx; > > #define PDX_GROUP_COUNT ((1 << PDX_GROUP_SHIFT) / \ > @@ -100,6 +98,8 @@ bool __mfn_valid(unsigned long mfn); > #define mfn_to_pdx(mfn) pfn_to_pdx(mfn_x(mfn)) > #define pdx_to_mfn(pdx) _mfn(pdx_to_pfn(pdx)) > > +#ifdef CONFIG_PDX_COMPRESSION > + > extern unsigned long pfn_pdx_bottom_mask, ma_va_bottom_mask; > extern unsigned int pfn_pdx_hole_shift; > extern unsigned long pfn_hole_mask; > @@ -205,8 +205,39 @@ static inline uint64_t directmapoff_to_maddr(unsigned long offset) > * position marks a potentially compressible bit. > */ > void pfn_pdx_hole_setup(unsigned long mask); > +#else /* CONFIG_PDX_COMPRESSION */ > + > +/* Without PDX compression we can skip some computations */ > + > +/* pdx<->pfn == identity */ > +#define pdx_to_pfn(x) (x) > +#define pfn_to_pdx(x) (x) > + > +/* directmap is indexed by by maddr */ > +#define maddr_to_directmapoff(x) (x) > +#define directmapoff_to_maddr(x) (x) > + > +static inline bool pdx_is_region_compressible(unsigned long smfn, > + unsigned long emfn) > +{ > + return true; > +} > + > +static inline uint64_t pdx_init_mask(uint64_t base_addr) > +{ > + return 0; > +} > + > +static inline uint64_t pdx_region_mask(uint64_t base, uint64_t len) > +{ > + return 0; > +} > + > +static inline void pfn_pdx_hole_setup(unsigned long mask) > +{ > +} > > -#endif /* HAS_PDX */ > +#endif /* CONFIG_PDX_COMPRESSION */ > #endif /* __XEN_PDX_H__ */ > > /* -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:13:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578771.906436 (Exim 4.92) (envelope-from ) id 1qT4j9-0007ba-GF; Mon, 07 Aug 2023 18:13:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578771.906436; Mon, 07 Aug 2023 18:13:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4j9-0007bT-Dg; Mon, 07 Aug 2023 18:13:11 +0000 Received: by outflank-mailman (input) for mailman id 578771; Mon, 07 Aug 2023 18:13:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4j7-0007bJ-8F; Mon, 07 Aug 2023 18:13:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4j6-0006p8-TP; Mon, 07 Aug 2023 18:13:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT4j6-0004R8-BS; Mon, 07 Aug 2023 18:13:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qT4j6-00083b-Au; Mon, 07 Aug 2023 18:13:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4Hs/o9J28DZ4/H4IjM3qCv/RKfE3NQ0pinNEz/UnDgw=; b=e8kYTxsUY+TARhe3eYy9HnevcS 8b3eyaJb53QEjQ0/0BOCrgnW4E1xikJbnUXqjcR5/TGVWb5wGco+MplZtCDAjcW8rXjXK+sWWwzqp 1AJ3za4lMVVqecMPPJ0PDol6K9/junw5x70qt0vIuIr5fcTGyebkPvcl5JNq1Lw5rcCg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182210: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64:xen-build:fail:regression xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e55146071de9257d70bd157047700071d0007622 X-Osstest-Versions-That: xen=e55146071de9257d70bd157047700071d0007622 From: osstest service owner Date: Mon, 07 Aug 2023 18:13:08 +0000 flight 182210 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail in 182203 REGR. vs. 182210 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 182203 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 182203 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 182203 n/a build-arm64-libvirt 1 build-check(1) blocked in 182203 n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182203 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182203 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182203 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182203 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182203 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182203 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182203 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182203 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182203 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182203 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182203 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182203 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e55146071de9257d70bd157047700071d0007622 baseline version: xen e55146071de9257d70bd157047700071d0007622 Last test of basis 182210 2023-08-07 01:52:04 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:39:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:39:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578780.906445 (Exim 4.92) (envelope-from ) id 1qT58I-0001t1-ML; Mon, 07 Aug 2023 18:39:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578780.906445; Mon, 07 Aug 2023 18:39:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT58I-0001su-JD; Mon, 07 Aug 2023 18:39:10 +0000 Received: by outflank-mailman (input) for mailman id 578780; Mon, 07 Aug 2023 18:39:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT58G-0001sl-Hr for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:39:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afe086ac-3551-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:39:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C0C5A61D09; Mon, 7 Aug 2023 18:39:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2629C433C8; Mon, 7 Aug 2023 18:39:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afe086ac-3551-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691433544; bh=Qo3e1NbMEIn2vI7uRVrp+8JCSgZhMti47wx/JgLHOAQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rH3kV+GU/mjN2ZmA42MZXz99lRbyLmtQoz3cW8knOvPxe2V/lFwKvwdLfkuZ/Q59J eE4HGa+yHkXqu7ldWPL1hiOBe1To7WWKS2LEulfFUXBxK2fpM1oH3ZsO/DKlHhfh5s +pfnz8ZhfZmEHIjYLabuL0xTSok+sd7G7SJQu3gQG0UFVhnjOKRoDJAco8kW8cQXe6 CmMAxF366g2W6RaUkdBUibNQd4A4+cesbJSG39RnmP9bwDz2K6xV7W7xthOwDMSwB+ QRJsQRJ9G/L2klvvJTJyiHpZGTf6UPQ0+XW74TO4lk9L1R+ROEjvFT8bygFCVv2eys S/1SkDeYf+L6Q== Date: Mon, 7 Aug 2023 11:39:01 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> Message-ID: References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 7 Aug 2023, Jan Beulich wrote: > On 04.08.2023 17:27, Nicola Vetrini wrote: > > The variable declared in the header file 'xen/arch/x86/include/asm/e820.h' > > is shadowed by many function parameters, so it is renamed to avoid these > > violations. > > > > No functional changes. > > > > Signed-off-by: Nicola Vetrini > > --- > > This patch is similar to other renames done on previous patches, and the > > preferred strategy there was to rename the global variable. This one > > has more occurrences that are spread in various files, but > > the general pattern is the same. > > Still I think it would be better done the other way around, and perhaps in > more than a single patch. It looks like "many == 3", i.e. > - e820_add_range(), which is only ever called with "e820" as its argument, > and hence the parameter could be dropped, > - e820_change_range_type(), which is in the same situation, and > - reserve_e820_ram(), which wants its parameter renamed. Let me premise that this is x86 code and I am happy with whatever you prefer. I would like to point out that renaming the global var is a lot safer as a change than renaming the local var. That is because renaming the global, if you forget one invocation it won't compile (now of course it can still happen for an optional feature like tboot, but in general you'll catch everything with a compilation). If you rename the local and you missed a rename, it will change the behavior of the code as it will fall back to the global and compile without issues. So I think it would be best to rename the global when possible. > Alternatively, if we really were to change the name of the global, we'd > want to take a more complete approach: Right now we have e820_raw[], > boot_e820[], and e820[]. We'd want them to follow a uniform naming scheme > then (e820_ first or _e820 last), with the other part of the name suitably > describing the purpose (which "map" doesn't do). I would go with this option From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578786.906456 (Exim 4.92) (envelope-from ) id 1qT5KW-0004Gg-Of; Mon, 07 Aug 2023 18:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578786.906456; Mon, 07 Aug 2023 18:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5KW-0004GZ-Lk; Mon, 07 Aug 2023 18:51:48 +0000 Received: by outflank-mailman (input) for mailman id 578786; Mon, 07 Aug 2023 18:51:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5KW-0004GT-1A for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:51:48 +0000 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [2607:f8b0:4864:20::f32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74b5f192-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:51:45 +0200 (CEST) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-63cfd6e3835so27471146d6.3 for ; Mon, 07 Aug 2023 11:51:45 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:51:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74b5f192-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434304; x=1692039104; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LeiJiP8hRzb2BMnxYpkNxhm2nxMuiEBd9IMbb+dk1EY=; b=Li2JKYXOKgdOwj6nwLZr4m+V0su0AzIBIYrLiwreewD2SiUSElEi4koPgw13/r80gk sXo3ki1XAn2RiKBIS+TpgzcYiFxGqUWlzvMlS8ABT02mLyv3TSlpmzOLeAr5KdGFFXHq jeClxZNHZ/nLmcd3gfVn0jpCYNwvweFRw63LFEiPJ7B/5eff9uFDFJn6oCTL1r2FPkTE hi2TFRxpJew+ykSF2wUJrgdh1OZwcyHttYCxafjMDL88UZxLjCRg2FmcFX+DhCeANhaE WnTDBRP2sCIhab7sT7LYaPsfzZlzhMdPAx8pnFAfz0/he9RRKCjSfFn3MA89RLGwXwZa FsPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434304; x=1692039104; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LeiJiP8hRzb2BMnxYpkNxhm2nxMuiEBd9IMbb+dk1EY=; b=c8eT1vrDoVLvGMUCKHIo8T1vrL2rsunp9Bd4sBp5aXIKkAnj2kWmJ+9KrCOZUXAS0N tBICeMarUG133MMClAlEp1Op3Qy9kCWUJcaVj4JIx5FygdykemSEBeXwwVuVjiyPcHxB gDAyxz5Oc2jBCXxbor1EBxCyjBFgZ5ILn0dLPYShuPO8aPd1/Pw2P4vlCw1YVaUJLSeC +2rr5nQ79ZWt0GZIAfhsdMEC89kcX8MegCIHck7uiOU4gEm6MUPgpuVxSrjH8GXtyx0t 9/sclBRczpDirrYvULsoClbM1fVfVHdtg/pSb6ocguW0yIFRrbWZlvfc1rNk8xmr5oGI +EVA== X-Gm-Message-State: AOJu0Yz3wdn/tqQ7bHdkkuK0RMUkjciY6XurhlNDJaQSGQofemJ8lTha EbMLfRgYeRu+oUn9TmBYlYq92au/dpE= X-Google-Smtp-Source: AGHT+IEDzb0gJ28gI32PY4ftFsSxYdJDCegQ1fHYd3fNQpbRN7Vxi/nCqmQyNKHvL1YDoPaBFRwk+A== X-Received: by 2002:a05:6214:807:b0:63c:f8d2:8b3f with SMTP id df7-20020a056214080700b0063cf8d28b3fmr9138970qvb.44.1691434304071; Mon, 07 Aug 2023 11:51:44 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Anthony PERARD , Juergen Gross , George Dunlap , Julien Grall , Stefano Stabellini , Henry Wang , Community Manager Subject: [PATCH v8 00/15] Intel Hardware P-States (HWP) support Date: Mon, 7 Aug 2023 14:51:04 -0400 Message-ID: <20230807185119.98333-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This patch series adds Hardware-Controlled Performance States (HWP) for Intel processors to Xen. v2 was only partially reviewed, so v3 is mostly a reposting of v2. In v2 & v3, I think I addressed all comments for v1. I kept patch 11 "xenpm: Factor out a non-fatal cpuid_parse variant", with a v2 comment explaining why I keep it. v3 adds "xen/x86: Tweak PDC bits when using HWP". Qubes testing revealed an issue where enabling HWP can crash firwmare code (maybe SMM). This requires a Linux change to get the PDC bits from Xen and pass them to ACPI. Roger has a patch [0] to set the PDC bits. Roger's 3 patch series was tested with "xen/x86: Tweak PDC bits when using HWP" on affected hardware and allowed proper operation. v4: There is a large amount or renaming from HWP/hwp to CPPC/cppc in the series. The driver remains hwp_ prefixed since it is dealing with the hardware interface. The sysctl, xc and xenpm interfaces were renamed to cppc to be the generic ACPI CPPC (Collaborative Processor Performance Control) interface. struct xen_get_cpufreq_para was re-organized in a binary compatible fashion to nest scaling governor options. This allows the cppc support to use uint32_t's for its parameters. HWP is now enabled with a top-level cpufreq=hwp option. It will fallback to cpufreq=xen if hwp is unavailable. This seems like the most user-friendly option. Since the user was trying to specify *some* cpufreq, we should give them the best that we can instead of disabling the functionality. "xenpm: Factor out a non-fatal cpuid_parse variant" was dropped. set-cpufreq-cppc expects either a cpu number or none specified, which implies all. Some patches were re-arrange - "xen/x86: Tweak PDC bits when using HWP" now comes immediately after "cpufreq: Add Hardware P-State (HWP) driver" The implementation of "cpufreq: Allow restricting to internal governors only " changed, so I removed Jan's Ack. v5: HWP is enabled with a toplevel cpufreq=hwp option. There is no fallback by default, but a cpufreq=hwp;xen syntax is now supported. That tries hwp first. If HWP registration is unsuccessful, then xen registration is performed as a fallback. More changes from Jan's feedback. They are typically minor and documented in individual patches. v6: After some discussion, the cpufreq=hwp;xen syntax is retained, with the global applicability of "verbose" mention in docs. Minor tweaks elsewhere as documented in individual patches. v7: Minor tweaks from review feedback - documented in respective patches. Jan previously asked for a toolstack side review / ack of "[PATCH 04/15] xen/sysctl: Nest cpufreq scaling options" v8: Minor tweaks from review feedback - documented in respective patches. Previous cover letter: With HWP, the processor makes its own determinations for frequency selection, though users can set some parameters and preferences. There is also Turbo Boost which dynamically pushes the max frequency if possible. The existing governors don't work with HWP since they select frequencies and HWP doesn't expose those. Therefore a dummy hwp-interal governor is used that doesn't do anything. xenpm get-cpufreq-para is extended to show HWP parameters, and set-cpufreq-cppc is added to set them. A lightly loaded OpenXT laptop showed ~1W power savings according to powertop. A mostly idle Fedora system (dom0 only) showed a more modest power savings. This is for a 10th gen 6-core 1600 MHz base 4900 MHZ max cpu. In the default balance mode, Turbo Boost doesn't exceed 4GHz. Tweaking the energy_perf preference with `xenpm set-cpufreq-para balance ene:64`, I've seen the CPU hit 4.7GHz before throttling down and bouncing around between 4.3 and 4.5 GHz. Curiously the other cores read ~4GHz when turbo boost takes affect. This was done after pinning all dom0 cores, and using taskset to pin to vCPU/pCPU 11 and running a bash tightloop. HWP defaults to disabled and running with the existing HWP configuration - it doesn't reconfigure by default. It can be enabled with cpufreq=hwp. Hardware Duty Cycling (HDC) is another feature to autonomously powerdown things. It defaults to enabled when HWP is enabled, but HDC can be disabled on the command line. cpufreq=xen:hwp,no-hdc I've only tested on 8th gen and 10th gen systems with activity window and energy_perf support. So the pathes for CPUs lacking those features are untested. Fast MSR support was removed in v2. The model specific checking was not done properly, and I don't have hardware to test with. Since writes are expected to be infrequent, I just removed the code. This changes the systcl_pm_op hypercall, so that wants review. Regards, Jason [0] https://lore.kernel.org/xen-devel/20221121102113.41893-3-roger.pau@citrix.com/ Jason Andryuk (15): cpufreq: Allow restricting to internal governors only cpufreq: Add perf_freq to cpuinfo cpufreq: Export intel_feature_detect xen/sysctl: Nest cpufreq scaling options pmstat&xenpm: Re-arrage for cpufreq union cpufreq: Add Hardware P-State (HWP) driver xen/x86: Tweak PDC bits when using HWP xenpm: Change get-cpufreq-para output for hwp cpufreq: Export HWP parameters to userspace as CPPC libxc: Include cppc_para in definitions xenpm: Print HWP/CPPC parameters xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op libxc: Add xc_set_cpufreq_cppc xenpm: Add set-cpufreq-cppc subcommand CHANGELOG: Add Intel HWP entry CHANGELOG.md | 1 + docs/misc/xen-command-line.pandoc | 20 +- tools/include/xenctrl.h | 28 +- tools/libs/ctrl/xc_pm.c | 81 ++- tools/misc/xenpm.c | 392 ++++++++++- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 31 +- xen/arch/x86/acpi/cpufreq/hwp.c | 658 +++++++++++++++++++ xen/arch/x86/acpi/lib.c | 5 + xen/arch/x86/cpu/mcheck/mce_intel.c | 6 + xen/arch/x86/include/asm/cpufeature.h | 12 +- xen/arch/x86/include/asm/msr-index.h | 16 +- xen/drivers/acpi/pmstat.c | 100 +-- xen/drivers/cpufreq/cpufreq.c | 60 +- xen/drivers/cpufreq/cpufreq_misc_governors.c | 9 + xen/drivers/cpufreq/cpufreq_ondemand.c | 3 + xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 22 + xen/include/acpi/pdc_intel.h | 1 + xen/include/public/sysctl.h | 144 +++- 20 files changed, 1471 insertions(+), 120 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578789.906486 (Exim 4.92) (envelope-from ) id 1qT5Kf-000557-L4; Mon, 07 Aug 2023 18:51:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578789.906486; Mon, 07 Aug 2023 18:51:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kf-00054y-IF; Mon, 07 Aug 2023 18:51:57 +0000 Received: by outflank-mailman (input) for mailman id 578789; Mon, 07 Aug 2023 18:51:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kd-0004GT-Im for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:51:55 +0000 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [2607:f8b0:4864:20::f33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 799d13b1-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:51:54 +0200 (CEST) Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-63d23473ed5so27492516d6.1 for ; Mon, 07 Aug 2023 11:51:54 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:51:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 799d13b1-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434312; x=1692039112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6N7tHO/NpGPoNencisuqLlnFkoHrBAPddvPlzfIc1r8=; b=GHeky4+dM2Ufq/m6WeD1ULJqVahBnME1DiWNOJzDfbQD1PUG3us1g1/2H7LH6o6QQg BkOD62dOusGASJtAQOvZQtciJV+jpMFhwOUfcUI67+V+fKxO+SSANhpo5ibeLrmFl4Dp g0kpRNZO9dcRyIpijcDssfa9SiFhHrhHJ85x+UsPINDTllvTdyDKsSYNT4bbPDkMKsPM kisC6aiEFPTxLyU4GMu6H6TyudntoIEq353dFDp67v/04m0pmVKQzKL3LN1l+zi70aux TiTJGKZFPqYfVtxk/j8EOf78rOZFXdifyS0ho/CAm+ll9L/nW0bB/8ra6vkjgPdhDAO+ KBaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434312; x=1692039112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6N7tHO/NpGPoNencisuqLlnFkoHrBAPddvPlzfIc1r8=; b=KmxbmpWW+tjkX1jByVlPgv3xYSatmYJJdjCZCNKZF2gWjytbjyPazmXTyg2JbLMlZp 5DabLxlfKbg66RTCT9TiBHRrZycLnXit586GTPwdSVv9ewIdv0srA/HnYQMHu7n++3f0 fOJB5jp2i4l/WL9sRI+pf6y6aUaZYH7qrJn2Bwgka/lGUbZSL2RZSDGTRJeEdiq0dt7K mbmlxHxcNgZ9cag/t2eIgJgHwXixPziv9ibbJ+GCFF+MlkKKajxWNkPmNbRoNEfvPy/V LEWTnSZKhz3c9dAgVUs5btlWbdBrqRlKiXjmR6pjySPNfzKwlZE5rcmx+kqegik7nv0m w2rg== X-Gm-Message-State: AOJu0YyeN5hXOmX02+lXGFltJj0jD9w7Zc3gFSfpsaF52bvw2T878+pk KvDD43+y9bjLrB2Jgpg3Kpk24e6+lRA= X-Google-Smtp-Source: AGHT+IGqakrWUAr2dflnsyhKPwTjuy2ForGGst/8v7r4iglq0Hh+C70Z74BvEzu6rs7s0s2r73f4oA== X-Received: by 2002:a0c:e494:0:b0:632:15e6:a75e with SMTP id n20-20020a0ce494000000b0063215e6a75emr8976705qvl.46.1691434312492; Mon, 07 Aug 2023 11:51:52 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v8 03/15] cpufreq: Export intel_feature_detect Date: Mon, 7 Aug 2023 14:51:07 -0400 Message-ID: <20230807185119.98333-4-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Export feature_detect as intel_feature_detect so it can be re-used by HWP. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v4: Add Jan's Ack v3: Remove void * cast when calling intel_feature_detect v2: export intel_feature_detect with typed pointer Move intel_feature_detect to acpi/cpufreq/cpufreq.h since the declaration now contains struct cpufreq_policy *. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 8 ++++++-- xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 6c70d04395..f1cc473b4f 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -339,9 +339,8 @@ static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu) return extract_freq(get_cur_val(cpumask_of(cpu)), data); } -static void cf_check feature_detect(void *info) +void intel_feature_detect(struct cpufreq_policy *policy) { - struct cpufreq_policy *policy = info; unsigned int eax; eax = cpuid_eax(6); @@ -353,6 +352,11 @@ static void cf_check feature_detect(void *info) } } +static void cf_check feature_detect(void *info) +{ + intel_feature_detect(info); +} + static unsigned int check_freqs(const cpumask_t *mask, unsigned int freq, struct acpi_cpufreq_data *data) { diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 1f1898d811..482ea5b0de 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -243,4 +243,6 @@ int write_userspace_scaling_setspeed(unsigned int cpu, unsigned int freq); void cpufreq_dbs_timer_suspend(void); void cpufreq_dbs_timer_resume(void); +void intel_feature_detect(struct cpufreq_policy *policy); + #endif /* __XEN_CPUFREQ_PM_H__ */ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578787.906466 (Exim 4.92) (envelope-from ) id 1qT5KZ-0004Vf-0Q; Mon, 07 Aug 2023 18:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578787.906466; Mon, 07 Aug 2023 18:51:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5KY-0004VY-TP; Mon, 07 Aug 2023 18:51:50 +0000 Received: by outflank-mailman (input) for mailman id 578787; Mon, 07 Aug 2023 18:51:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5KY-0004GT-AB for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:51:50 +0000 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [2607:f8b0:4864:20::f32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76796329-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:51:48 +0200 (CEST) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-63cf9eddbc6so27013826d6.0 for ; Mon, 07 Aug 2023 11:51:48 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:51:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76796329-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434307; x=1692039107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vNQhWJqSLtysm6iaINr+s0i3gnrhiDBqgnXkQD6RBcM=; b=V3bDDlxVvi0tsUCmaHrr4kIxZRNDwH5cDbN2sq75I1MZcutfJ0gvNx9gtMtV5mjPyb donPyty3kc0fEgDAjshZsCWmZ4Bil9mwTLggUFolENijiSmEpu/hYwi6wjRkWvYLmSXK Pbhqj74Qb1WTGwu1iQd0Bs+uZd7L/6w/s2vKXL8c6VRfGY73bJUeslXwgHPkC4UP1ZIL faaaVdlIORfr4kckqu4P3g9aXEI/JxtjpbLdynC4dEFAOz2uyEStr2EuCOTA5RJKtxFY Qhgl0MHicM2Txwy5zvgb371xvT5Bqw7VF/BApMGVeQZu6cZDpRsgOeT4Bk0qCsiXWxME xikA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434307; x=1692039107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vNQhWJqSLtysm6iaINr+s0i3gnrhiDBqgnXkQD6RBcM=; b=aegO1ldYkIjzlULGj2F+wNUJsAMLk8nxSlB8nMdTHpOR/0hhWHp9xLu1BJlo2lCQvn oRDG54o7+GdhMvN2XtWHNqk0hXlQkeYBjqIytVvCNHcfPn5uLMOxHElq3ljiyUVbzr9I qlu5Hms789MWhymnSzDxDe5F+HpXrq2t2C3nAr9bJV+H172JkrvfP9/buiBNaiG8VpJW ACZt/ZWVGScQp2kT3+cPo2QW87Jh1yIYgUUOG5zmdONN+R/qJhZzV02zbt9iegssbQq1 8rhrMZDrgg0ac92gjodx4LmpIXB0F0Fm5amsHc3LxzHw5xYWMKggO4qwZE7t800A77io X33g== X-Gm-Message-State: AOJu0Yz0QMW7x17EeKFkOKFmeST4iSCfWHfVVuPPfCaUhRm3Bvina6Dv MV3WA4alIuixwUQeC9zUay9dGkVbxJs= X-Google-Smtp-Source: AGHT+IGl7Y+1vn0bVef3zX0I0/p0lA+FKwyNiCKLG9/u/GHkJkHhIVMiSSz2y/CABd06pOC5Vny+Kw== X-Received: by 2002:a05:6214:e6b:b0:63f:6ec7:9f7 with SMTP id jz11-20020a0562140e6b00b0063f6ec709f7mr9620469qvb.23.1691434307160; Mon, 07 Aug 2023 11:51:47 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich Subject: [PATCH v8 01/15] cpufreq: Allow restricting to internal governors only Date: Mon, 7 Aug 2023 14:51:05 -0400 Message-ID: <20230807185119.98333-2-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For hwp, the standard governors are not usable, and only the internal one is applicable. Add the cpufreq_governor_internal boolean to indicate when an internal governor, like hwp, will be used. This is set during presmp_initcall, and governor registration can be skipped when called during initcall. This way unusable governors are not registered, and only compatible governors are advertised to userspace. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v6: Add Jan's Ack v5: Check cpufreq_governor_internal and skip registration as applicable Remove internal flag v4: Rework to use an internal flag Removed Jan's Ack since the approach is different. v3: Switch to initdata Add Jan Acked-by Commit message s/they/the/ typo Don't register hwp-internal when running non-hwp - Marek v2: Switch to "-internal" Add blank line in header --- xen/drivers/cpufreq/cpufreq.c | 1 + xen/drivers/cpufreq/cpufreq_misc_governors.c | 9 +++++++++ xen/drivers/cpufreq/cpufreq_ondemand.c | 3 +++ xen/include/acpi/cpufreq/cpufreq.h | 2 ++ 4 files changed, 15 insertions(+) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 2321c7dd07..67a58d409b 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -56,6 +56,7 @@ struct cpufreq_dom { }; static LIST_HEAD_READ_MOSTLY(cpufreq_dom_list_head); +bool __initdata cpufreq_governor_internal; struct cpufreq_governor *__read_mostly cpufreq_opt_governor; LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); diff --git a/xen/drivers/cpufreq/cpufreq_misc_governors.c b/xen/drivers/cpufreq/cpufreq_misc_governors.c index f5571f5486..0327fad23b 100644 --- a/xen/drivers/cpufreq/cpufreq_misc_governors.c +++ b/xen/drivers/cpufreq/cpufreq_misc_governors.c @@ -120,6 +120,9 @@ static int __init cf_check cpufreq_gov_userspace_init(void) { unsigned int cpu; + if ( cpufreq_governor_internal ) + return 0; + for_each_online_cpu(cpu) per_cpu(cpu_set_freq, cpu) = userspace_cmdline_freq; register_cpu_notifier(&cpufreq_userspace_cpu_nfb); @@ -162,6 +165,9 @@ struct cpufreq_governor cpufreq_gov_performance = { static int __init cf_check cpufreq_gov_performance_init(void) { + if ( cpufreq_governor_internal ) + return 0; + return cpufreq_register_governor(&cpufreq_gov_performance); } __initcall(cpufreq_gov_performance_init); @@ -201,6 +207,9 @@ struct cpufreq_governor cpufreq_gov_powersave = { static int __init cf_check cpufreq_gov_powersave_init(void) { + if ( cpufreq_governor_internal ) + return 0; + return cpufreq_register_governor(&cpufreq_gov_powersave); } __initcall(cpufreq_gov_powersave_init); diff --git a/xen/drivers/cpufreq/cpufreq_ondemand.c b/xen/drivers/cpufreq/cpufreq_ondemand.c index fbcd14d6c3..06cfc88d30 100644 --- a/xen/drivers/cpufreq/cpufreq_ondemand.c +++ b/xen/drivers/cpufreq/cpufreq_ondemand.c @@ -360,6 +360,9 @@ struct cpufreq_governor cpufreq_gov_dbs = { static int __init cf_check cpufreq_gov_dbs_init(void) { + if ( cpufreq_governor_internal ) + return 0; + return cpufreq_register_governor(&cpufreq_gov_dbs); } __initcall(cpufreq_gov_dbs_init); diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 35dcf21e8f..44fc4c58fc 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -116,6 +116,8 @@ extern struct cpufreq_governor cpufreq_gov_powersave; extern struct list_head cpufreq_governor_list; +extern bool cpufreq_governor_internal; + extern int cpufreq_register_governor(struct cpufreq_governor *governor); extern struct cpufreq_governor *__find_governor(const char *governor); #define CPUFREQ_DEFAULT_GOVERNOR &cpufreq_gov_dbs -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578790.906496 (Exim 4.92) (envelope-from ) id 1qT5Kg-0005LP-V7; Mon, 07 Aug 2023 18:51:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578790.906496; Mon, 07 Aug 2023 18:51:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kg-0005L9-RL; Mon, 07 Aug 2023 18:51:58 +0000 Received: by outflank-mailman (input) for mailman id 578790; Mon, 07 Aug 2023 18:51:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kg-0004lg-6n for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:51:58 +0000 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [2607:f8b0:4864:20::a2b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b7406a7-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:51:57 +0200 (CEST) Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-487442d5e49so485883e0c.2 for ; Mon, 07 Aug 2023 11:51:57 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:51:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b7406a7-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434315; x=1692039115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FlP8mCjQvy+39h7njc8jPJQIVXj0clvvCBaJ9ThAR4E=; b=V+TOtaFMBWDWV6a/gS3v3CLDf7RhwjdgX1K18CoqfTsEPvcOrFn3pDt7C5hNL9GDSG JA5PdYa2aB/7c032kG86/6NMMwsvSZGgQ+1vWoGTiN071xMxA9Sb5XoGo0SDGdvllCYB ncZjtigopOc+aiMWWwjzbGeprk71lT+Hg14e/FtcKVJnGSUQfv7T+vqfaTQRqdWur4Pn O78ra6nL24x+6DigObohZJ1rPfMhh2J6o7xnV4e1ee/17niJoSi+rwDSE4SmnsKs++gj dyK0zGiN03mfUd9hSB4Qi6tp5ezOin3+gvI2nOhTnZ9jowsQY/oHZBGsXq2DuB0pPxI3 JUsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434315; x=1692039115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FlP8mCjQvy+39h7njc8jPJQIVXj0clvvCBaJ9ThAR4E=; b=F9sXhF8O+8oCFkP6z+eN/TXdL90ukj67XM7tkUNtm4CMYaNabvjsNgp4Q1vkx4evY8 oatxaex2BxDo1BpbwGPrIzFiIOuQuJodrNe0oxdE4dmrDorWW7PizbAj9ZnJz8T3ix9N xAVqS19VzL0jQBnu1PW36cTSjJNf1RtbnzFoNJ8X8Ad4lR7zFqOR5SdqiO8cOUJLYpd7 HQdZf2MDulyiXQYp4Ea9OL82cN7ulpsL+qUiw/aFDblM5V0Tpcjd7SwIThTqxazZnJI9 mzlAxHSNQwH/ocgjbbtTb8LxubDQ2732JOrUG5moCucyYn44cRAsOKFX8DzZF4Kpy3o5 pROw== X-Gm-Message-State: AOJu0YyRumdU88gUNmWEC8Pc+4jVA1ftjPy9j2X0nCVhIp76suV1XfR1 jSLiOoNHCBMHz4DppqjH7RgSz02HwmQ= X-Google-Smtp-Source: AGHT+IEHaRR4nFTTcUDmMm0Tal0kvEnQkaJFXt5NiD1DFtILS4ddXasHFdUHsPghHxgzv/S21/+YBA== X-Received: by 2002:a1f:3f03:0:b0:487:16e2:b653 with SMTP id m3-20020a1f3f03000000b0048716e2b653mr4931614vka.13.1691434315620; Mon, 07 Aug 2023 11:51:55 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH v8 04/15] xen/sysctl: Nest cpufreq scaling options Date: Mon, 7 Aug 2023 14:51:08 -0400 Message-ID: <20230807185119.98333-5-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a union and struct so that most of the scaling variables of struct xen_get_cpufreq_para are within in a binary-compatible layout. This allows cppc_para to live in the larger union and use uint32_ts - struct xen_cppc_para will be 10 uint32_t's. The new scaling struct is 3 * uint32_t + 16 bytes CPUFREQ_NAME_LEN + 4 * uint32_t for xen_ondemand = 11 uint32_t. That means the old size is retained, int32_t turbo_enabled doesn't move and it's binary compatible. The out-of-context memcpy() in xc_get_cpufreq_para() now handles the copying of the fields removed there. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v8: Add BUILD_BUG_ON checks for structs xc_get_cpufreq_para & xen_get_cpufreq_para v6: Add Jan's Reviewed-by v5: Expand commit message Change comment to driver/governor --- tools/include/xenctrl.h | 22 ++++++++++-------- tools/libs/ctrl/xc_pm.c | 46 ++++++++++++++++++++++++++++++++----- tools/misc/xenpm.c | 24 +++++++++---------- xen/drivers/acpi/pmstat.c | 27 +++++++++++----------- xen/include/public/sysctl.h | 22 ++++++++++-------- 5 files changed, 92 insertions(+), 49 deletions(-) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index faec1dd824..de03cfb117 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1926,16 +1926,20 @@ struct xc_get_cpufreq_para { uint32_t cpuinfo_cur_freq; uint32_t cpuinfo_max_freq; uint32_t cpuinfo_min_freq; - uint32_t scaling_cur_freq; - - char scaling_governor[CPUFREQ_NAME_LEN]; - uint32_t scaling_max_freq; - uint32_t scaling_min_freq; - - /* for specific governor */ union { - xc_userspace_t userspace; - xc_ondemand_t ondemand; + struct { + uint32_t scaling_cur_freq; + + char scaling_governor[CPUFREQ_NAME_LEN]; + uint32_t scaling_max_freq; + uint32_t scaling_min_freq; + + /* for specific governor */ + union { + xc_userspace_t userspace; + xc_ondemand_t ondemand; + } u; + } s; } u; int32_t turbo_enabled; diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index c3a9864bf7..5ec050982a 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -245,6 +245,45 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, sys_para->freq_num = user_para->freq_num; sys_para->gov_num = user_para->gov_num; + /* Sanity check struct layout */ + BUILD_BUG_ON(sizeof(*user_para) != sizeof(*sys_para)); + BUILD_BUG_ON(offsetof(typeof(*user_para), cpu_num) != + offsetof(typeof(*sys_para), cpu_num)); + BUILD_BUG_ON(offsetof(typeof(*user_para), freq_num) != + offsetof(typeof(*sys_para), freq_num)); + BUILD_BUG_ON(offsetof(typeof(*user_para), gov_num) != + offsetof(typeof(*sys_para), gov_num)); + BUILD_BUG_ON(offsetof(typeof(*user_para), affected_cpus) != + offsetof(typeof(*sys_para), affected_cpus)); + BUILD_BUG_ON(offsetof(typeof(*user_para), scaling_available_frequencies) != + offsetof(typeof(*sys_para), scaling_available_frequencies)); + BUILD_BUG_ON(offsetof(typeof(*user_para), scaling_available_governors) != + offsetof(typeof(*sys_para), scaling_available_governors)); + BUILD_BUG_ON(offsetof(typeof(*user_para), scaling_driver) != + offsetof(typeof(*sys_para), scaling_driver)); + BUILD_BUG_ON(offsetof(typeof(*user_para), cpuinfo_cur_freq) != + offsetof(typeof(*sys_para), cpuinfo_cur_freq)); + BUILD_BUG_ON(offsetof(typeof(*user_para), cpuinfo_max_freq) != + offsetof(typeof(*sys_para), cpuinfo_max_freq)); + BUILD_BUG_ON(offsetof(typeof(*user_para), cpuinfo_min_freq) != + offsetof(typeof(*sys_para), cpuinfo_min_freq)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_cur_freq) != + offsetof(typeof(*sys_para), u.s.scaling_cur_freq)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_governor) != + offsetof(typeof(*sys_para), u.s.scaling_governor)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_max_freq) != + offsetof(typeof(*sys_para), u.s.scaling_max_freq)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_min_freq) != + offsetof(typeof(*sys_para), u.s.scaling_min_freq)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.u.userspace) != + offsetof(typeof(*sys_para), u.s.u.userspace)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.u.ondemand) != + offsetof(typeof(*sys_para), u.s.u.ondemand)); + BUILD_BUG_ON(offsetof(typeof(*user_para), u.cppc_para) != + offsetof(typeof(*sys_para), u.cppc_para)); + BUILD_BUG_ON(offsetof(typeof(*user_para), turbo_enabled) != + offsetof(typeof(*sys_para), turbo_enabled)); + ret = xc_sysctl(xch, &sysctl); if ( ret ) { @@ -265,17 +304,12 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, user_para->cpuinfo_cur_freq = sys_para->cpuinfo_cur_freq; user_para->cpuinfo_max_freq = sys_para->cpuinfo_max_freq; user_para->cpuinfo_min_freq = sys_para->cpuinfo_min_freq; - user_para->scaling_cur_freq = sys_para->scaling_cur_freq; - user_para->scaling_max_freq = sys_para->scaling_max_freq; - user_para->scaling_min_freq = sys_para->scaling_min_freq; user_para->turbo_enabled = sys_para->turbo_enabled; memcpy(user_para->scaling_driver, sys_para->scaling_driver, CPUFREQ_NAME_LEN); - memcpy(user_para->scaling_governor, - sys_para->scaling_governor, CPUFREQ_NAME_LEN); - /* copy to user_para no matter what cpufreq governor */ + /* copy to user_para no matter what cpufreq driver/governor */ BUILD_BUG_ON(sizeof(((struct xc_get_cpufreq_para *)0)->u) != sizeof(((struct xen_get_cpufreq_para *)0)->u)); diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 1bb6187e56..ee8ce5d5f2 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -730,39 +730,39 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf("scaling_avail_gov : %s\n", p_cpufreq->scaling_available_governors); - printf("current_governor : %s\n", p_cpufreq->scaling_governor); - if ( !strncmp(p_cpufreq->scaling_governor, + printf("current_governor : %s\n", p_cpufreq->u.s.scaling_governor); + if ( !strncmp(p_cpufreq->u.s.scaling_governor, "userspace", CPUFREQ_NAME_LEN) ) { printf(" userspace specific :\n"); printf(" scaling_setspeed : %u\n", - p_cpufreq->u.userspace.scaling_setspeed); + p_cpufreq->u.s.u.userspace.scaling_setspeed); } - else if ( !strncmp(p_cpufreq->scaling_governor, + else if ( !strncmp(p_cpufreq->u.s.scaling_governor, "ondemand", CPUFREQ_NAME_LEN) ) { printf(" ondemand specific :\n"); printf(" sampling_rate : max [%u] min [%u] cur [%u]\n", - p_cpufreq->u.ondemand.sampling_rate_max, - p_cpufreq->u.ondemand.sampling_rate_min, - p_cpufreq->u.ondemand.sampling_rate); + p_cpufreq->u.s.u.ondemand.sampling_rate_max, + p_cpufreq->u.s.u.ondemand.sampling_rate_min, + p_cpufreq->u.s.u.ondemand.sampling_rate); printf(" up_threshold : %u\n", - p_cpufreq->u.ondemand.up_threshold); + p_cpufreq->u.s.u.ondemand.up_threshold); } printf("scaling_avail_freq :"); for ( i = 0; i < p_cpufreq->freq_num; i++ ) if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->scaling_cur_freq ) + p_cpufreq->u.s.scaling_cur_freq ) printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); else printf(" %d", p_cpufreq->scaling_available_frequencies[i]); printf("\n"); printf("scaling frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->scaling_max_freq, - p_cpufreq->scaling_min_freq, - p_cpufreq->scaling_cur_freq); + p_cpufreq->u.s.scaling_max_freq, + p_cpufreq->u.s.scaling_min_freq, + p_cpufreq->u.s.scaling_cur_freq); printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index 1bae635101..f5a9ac3f1a 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -258,37 +258,38 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) cpufreq_driver.get ? cpufreq_driver.get(op->cpuid) : policy->cur; op->u.get_para.cpuinfo_max_freq = policy->cpuinfo.max_freq; op->u.get_para.cpuinfo_min_freq = policy->cpuinfo.min_freq; - op->u.get_para.scaling_cur_freq = policy->cur; - op->u.get_para.scaling_max_freq = policy->max; - op->u.get_para.scaling_min_freq = policy->min; + + op->u.get_para.u.s.scaling_cur_freq = policy->cur; + op->u.get_para.u.s.scaling_max_freq = policy->max; + op->u.get_para.u.s.scaling_min_freq = policy->min; if ( cpufreq_driver.name[0] ) - strlcpy(op->u.get_para.scaling_driver, + strlcpy(op->u.get_para.scaling_driver, cpufreq_driver.name, CPUFREQ_NAME_LEN); else strlcpy(op->u.get_para.scaling_driver, "Unknown", CPUFREQ_NAME_LEN); if ( policy->governor->name[0] ) - strlcpy(op->u.get_para.scaling_governor, + strlcpy(op->u.get_para.u.s.scaling_governor, policy->governor->name, CPUFREQ_NAME_LEN); else - strlcpy(op->u.get_para.scaling_governor, "Unknown", CPUFREQ_NAME_LEN); + strlcpy(op->u.get_para.u.s.scaling_governor, "Unknown", CPUFREQ_NAME_LEN); /* governor specific para */ - if ( !strncasecmp(op->u.get_para.scaling_governor, + if ( !strncasecmp(op->u.get_para.u.s.scaling_governor, "userspace", CPUFREQ_NAME_LEN) ) { - op->u.get_para.u.userspace.scaling_setspeed = policy->cur; + op->u.get_para.u.s.u.userspace.scaling_setspeed = policy->cur; } - if ( !strncasecmp(op->u.get_para.scaling_governor, + if ( !strncasecmp(op->u.get_para.u.s.scaling_governor, "ondemand", CPUFREQ_NAME_LEN) ) { ret = get_cpufreq_ondemand_para( - &op->u.get_para.u.ondemand.sampling_rate_max, - &op->u.get_para.u.ondemand.sampling_rate_min, - &op->u.get_para.u.ondemand.sampling_rate, - &op->u.get_para.u.ondemand.up_threshold); + &op->u.get_para.u.s.u.ondemand.sampling_rate_max, + &op->u.get_para.u.s.u.ondemand.sampling_rate_min, + &op->u.get_para.u.s.u.ondemand.sampling_rate, + &op->u.get_para.u.s.u.ondemand.up_threshold); } op->u.get_para.turbo_enabled = cpufreq_get_turbo_status(op->cpuid); diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index fa7147de47..c11c0b1a6c 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -317,16 +317,20 @@ struct xen_get_cpufreq_para { uint32_t cpuinfo_cur_freq; uint32_t cpuinfo_max_freq; uint32_t cpuinfo_min_freq; - uint32_t scaling_cur_freq; - - char scaling_governor[CPUFREQ_NAME_LEN]; - uint32_t scaling_max_freq; - uint32_t scaling_min_freq; - - /* for specific governor */ union { - struct xen_userspace userspace; - struct xen_ondemand ondemand; + struct { + uint32_t scaling_cur_freq; + + char scaling_governor[CPUFREQ_NAME_LEN]; + uint32_t scaling_max_freq; + uint32_t scaling_min_freq; + + /* for specific governor */ + union { + struct xen_userspace userspace; + struct xen_ondemand ondemand; + } u; + } s; } u; int32_t turbo_enabled; -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578791.906506 (Exim 4.92) (envelope-from ) id 1qT5Km-0005ku-62; Mon, 07 Aug 2023 18:52:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578791.906506; Mon, 07 Aug 2023 18:52:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Km-0005ki-2q; Mon, 07 Aug 2023 18:52:04 +0000 Received: by outflank-mailman (input) for mailman id 578791; Mon, 07 Aug 2023 18:52:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kk-0004GT-Sy for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:02 +0000 Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [2607:f8b0:4864:20::c33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7dc665d4-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:52:01 +0200 (CEST) Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-56d263da4f2so3483467eaf.0 for ; Mon, 07 Aug 2023 11:52:01 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:51:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dc665d4-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434319; x=1692039119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u2cTNXN/aOxyn6yZt8JfTgLQyqiVtZjxkKTytYxVIK0=; b=CnO6HWIQbR2lQMKLHNby+LFi1nw8F/zZ2Cko9PIOtiApG8kgSA1mwtVcBWlprnTTgL FMCvYnLECT+RicsiD1/iWZcSoHpDm8QHW5C+UV/oQnrWZJ/scSvvPBfsUc7ckuARC8aQ n6UD331fi7yxBFRtHLWhx6pDumCMgQmN9w35oXbUykpuSnXhchaZmqaih3lGrgtVAwTM 163tTW8+8qyxYYtGhToNwM5C+h4dbqvxpRh3ETgHsNfyRUSz1GWK8dZUfZG3p033O+w8 Id+yhLAPE89HvqR9TfyfqSZQ9uWw5EkBlU+MlWIveNpX2Zx9TIhUgt4xY8rm/NcKzvV2 qOlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434319; x=1692039119; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u2cTNXN/aOxyn6yZt8JfTgLQyqiVtZjxkKTytYxVIK0=; b=Ws9M7CZYvqm97F1irX/c7UMS/K9hgd+M93pVYiPB2oxNE9pbwVnJLR77JjyYNFQJ+n Xp3y/0XhUKDkiDfz4YDgMYWzZK344FNh9Mz6VE5zugwAlaHKC/TAljSn0ABMhbXebl2y TjxsBLs21Yz3azuVOe2JhqZV7OCYtyxhjIj4vlRGvIvV1kZ2Jm6EedbNlGW0Hui6yWok CcqoSS82P6YfBuGuj3NFlFVc1uoOINHUKxXRvWlGWll/9HqoMPb7Hk0LEz9skNLv8Yll qC2/17OkNvUbAfpUDxDIrrFVmEkHSeYw01nA6RTwtT8bTFQyMqYzsmSq7DLsvi1Lf55M /fxQ== X-Gm-Message-State: AOJu0Yw3lkZTRvHIHz0gbQ+eK/SFqkmY9Atg+m3ywwSgpfFRd785Y77U nCha9OhYEEYd6B8fCrKDE9+4ysJizLo= X-Google-Smtp-Source: AGHT+IGB8zoaL8Wl4i2TbXtiQdNma5QYJIb2GwQ3mLZpI+PHYTazgpS7dKL4y2Cd1STr/leJB1hf1A== X-Received: by 2002:a05:6358:8820:b0:135:3e6b:8430 with SMTP id hv32-20020a056358882000b001353e6b8430mr10912871rwb.5.1691434319201; Mon, 07 Aug 2023 11:51:59 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross , Jan Beulich Subject: [PATCH v8 05/15] pmstat&xenpm: Re-arrage for cpufreq union Date: Mon, 7 Aug 2023 14:51:09 -0400 Message-ID: <20230807185119.98333-6-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rearrange code now that xen_sysctl_pm_op's get_para fields has the nested union and struct. In particular, the scaling governor information like scaling_available_governors is inside the union, so it is not always available. Move those fields (op->u.get_para.u.s.u.*) together as well as the common fields (ones outside the union like op->u.get_para.turbo_enabled). With that, gov_num may be 0, so bounce buffer handling needs to be modified. scaling_governor and other fields inside op->u.get_para.u.s.u.* won't be used for hwp, so this will simplify the change when hwp support is introduced and re-indents these lines all together. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich Acked-by: Anthony PERARD --- v8: Add Anthony's Ack v6: Add Jan's Ack v5: Remove some formatting changes Expand commit message --- tools/libs/ctrl/xc_pm.c | 12 ++++++++---- tools/misc/xenpm.c | 3 ++- xen/drivers/acpi/pmstat.c | 24 ++++++++++++------------ 3 files changed, 22 insertions(+), 17 deletions(-) diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index 5ec050982a..3e969b841f 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -221,7 +221,7 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, { if ( (!user_para->affected_cpus) || (!user_para->scaling_available_frequencies) || - (!user_para->scaling_available_governors) ) + (user_para->gov_num && !user_para->scaling_available_governors) ) { errno = EINVAL; return -1; @@ -230,12 +230,15 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, goto unlock_1; if ( xc_hypercall_bounce_pre(xch, scaling_available_frequencies) ) goto unlock_2; - if ( xc_hypercall_bounce_pre(xch, scaling_available_governors) ) + if ( user_para->gov_num && + xc_hypercall_bounce_pre(xch, scaling_available_governors) ) goto unlock_3; set_xen_guest_handle(sys_para->affected_cpus, affected_cpus); set_xen_guest_handle(sys_para->scaling_available_frequencies, scaling_available_frequencies); - set_xen_guest_handle(sys_para->scaling_available_governors, scaling_available_governors); + if ( user_para->gov_num ) + set_xen_guest_handle(sys_para->scaling_available_governors, + scaling_available_governors); } sysctl.cmd = XEN_SYSCTL_pm_op; @@ -317,7 +320,8 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, } unlock_4: - xc_hypercall_bounce_post(xch, scaling_available_governors); + if ( user_para->gov_num ) + xc_hypercall_bounce_post(xch, scaling_available_governors); unlock_3: xc_hypercall_bounce_post(xch, scaling_available_frequencies); unlock_2: diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index ee8ce5d5f2..1c474c3b59 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -811,7 +811,8 @@ static int show_cpufreq_para_by_cpuid(xc_interface *xc_handle, int cpuid) ret = -ENOMEM; goto out; } - if (!(p_cpufreq->scaling_available_governors = + if (p_cpufreq->gov_num && + !(p_cpufreq->scaling_available_governors = malloc(p_cpufreq->gov_num * CPUFREQ_NAME_LEN * sizeof(char)))) { fprintf(stderr, diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index f5a9ac3f1a..d67d99e62f 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -239,6 +239,18 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) if ( ret ) return ret; + op->u.get_para.cpuinfo_cur_freq = + cpufreq_driver.get ? cpufreq_driver.get(op->cpuid) : policy->cur; + op->u.get_para.cpuinfo_max_freq = policy->cpuinfo.max_freq; + op->u.get_para.cpuinfo_min_freq = policy->cpuinfo.min_freq; + op->u.get_para.turbo_enabled = cpufreq_get_turbo_status(op->cpuid); + + if ( cpufreq_driver.name[0] ) + strlcpy(op->u.get_para.scaling_driver, + cpufreq_driver.name, CPUFREQ_NAME_LEN); + else + strlcpy(op->u.get_para.scaling_driver, "Unknown", CPUFREQ_NAME_LEN); + if ( !(scaling_available_governors = xzalloc_array(char, gov_num * CPUFREQ_NAME_LEN)) ) return -ENOMEM; @@ -254,21 +266,10 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) if ( ret ) return ret; - op->u.get_para.cpuinfo_cur_freq = - cpufreq_driver.get ? cpufreq_driver.get(op->cpuid) : policy->cur; - op->u.get_para.cpuinfo_max_freq = policy->cpuinfo.max_freq; - op->u.get_para.cpuinfo_min_freq = policy->cpuinfo.min_freq; - op->u.get_para.u.s.scaling_cur_freq = policy->cur; op->u.get_para.u.s.scaling_max_freq = policy->max; op->u.get_para.u.s.scaling_min_freq = policy->min; - if ( cpufreq_driver.name[0] ) - strlcpy(op->u.get_para.scaling_driver, - cpufreq_driver.name, CPUFREQ_NAME_LEN); - else - strlcpy(op->u.get_para.scaling_driver, "Unknown", CPUFREQ_NAME_LEN); - if ( policy->governor->name[0] ) strlcpy(op->u.get_para.u.s.scaling_governor, policy->governor->name, CPUFREQ_NAME_LEN); @@ -291,7 +292,6 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) &op->u.get_para.u.s.u.ondemand.sampling_rate, &op->u.get_para.u.s.u.ondemand.up_threshold); } - op->u.get_para.turbo_enabled = cpufreq_get_turbo_status(op->cpuid); return ret; } -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578788.906475 (Exim 4.92) (envelope-from ) id 1qT5Kc-0004mj-8k; Mon, 07 Aug 2023 18:51:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578788.906475; Mon, 07 Aug 2023 18:51:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kc-0004ma-5x; Mon, 07 Aug 2023 18:51:54 +0000 Received: by outflank-mailman (input) for mailman id 578788; Mon, 07 Aug 2023 18:51:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kb-0004lg-0s for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:51:53 +0000 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [2607:f8b0:4864:20::729]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7807c4db-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:51:51 +0200 (CEST) Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7658752ce2fso307674185a.1 for ; Mon, 07 Aug 2023 11:51:51 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:51:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7807c4db-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434310; x=1692039110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tj29XCVclI+6QGR1ahwKo+P0a4dIzt4OqPyhJ7hCJ/k=; b=MlsbqQcJyX9jN9lriHM0iDQ7gR5CoydJhp8pi3OdLiGwI71DCySx/z0maO1HF61T83 FpNuso2rFHyFlar631WV906NN1tUBjpxJ0SbSPcSNUga2jI+DOY+Ah5CI4s+gFAhwGPL z/3B1ChBKLay6Eo41f7+XsHNoLpxSWGhvNHMaHPi4rVFHH1qecrz5M2RK2d8MlhmIxXr ijsDkh+bw6EaguEg9c5GSBTQogItxt1YI9o8Ox0whZiczCH1GGSO2IMoSEDXOu5fXREc s3/g/VRmSwrNKl6vQ1IY/wsUTgHlgHDd+ZJpGohCjofBhf3hLo7wtRTomBXrPqXHdfQL ZHTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434310; x=1692039110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tj29XCVclI+6QGR1ahwKo+P0a4dIzt4OqPyhJ7hCJ/k=; b=CffovdcvpOnKxFSj5L5e/F64cxvF2gHh3Byg22CJFyKKCXqki6UqNlIG0NT5qtUn4H FMGBC4/FcF0ToxhwnhjFOI75MPMKL4YqF7i5RxT2xC48hMH6GI6bwFHJBrDhZG2fyolu WUgH5gvepsxjuJKEvcds7K5gzSoAcammJRiC7PsDqAJiBJLGVHWsLHNzW7vK4Xe/5PKG cbx1rADnDRV1HIoI3ttwhQEg5j6vKk/VJFR7rIV6wo5MRcg0qjNy47VVfCx/glFWBmu1 ZhOzrl+wQOhGMqt64MfBYbgRuQnR+jHI22zT2uSvhlN2v3yKwv/hG/+YllMzHF7MVqBY 8rSw== X-Gm-Message-State: AOJu0Yw1y/KOWYI93A2Q57sB9fNCFnjFXBbBmK4BqJrgHdms94qGi9hK NBmw9M3zFh15y69WO5AUAx2/2e1kmlM= X-Google-Smtp-Source: AGHT+IGgGCC4XZiOpihmt9Ail03iR8azEz/pl5MYhM5hiOtjuCf1gBvEFIOfCMwg9A7Dcb2mI3FMoA== X-Received: by 2002:ad4:569a:0:b0:62d:fa7c:6b95 with SMTP id bd26-20020ad4569a000000b0062dfa7c6b95mr8654681qvb.32.1691434309726; Mon, 07 Aug 2023 11:51:49 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v8 02/15] cpufreq: Add perf_freq to cpuinfo Date: Mon, 7 Aug 2023 14:51:06 -0400 Message-ID: <20230807185119.98333-3-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP needs to scale by base frequency. Settings max_freq to base_freq "works" but the code is not obvious, and returning values to userspace is tricky. Add an additonal perf_freq member which is used for scaling aperf/mperf measurements. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v3: Add Jan's Ack I don't like this, but it seems the best way to re-use the common aperf/mperf code. The other option would be to add wrappers that then do the acpi vs. hwp scaling. --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/drivers/cpufreq/utility.c | 1 + xen/include/acpi/cpufreq/cpufreq.h | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 2e0067fbe5..6c70d04395 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -316,7 +316,7 @@ unsigned int get_measured_perf(unsigned int cpu, unsigned int flag) else perf_percent = 0; - return policy->cpuinfo.max_freq * perf_percent / 100; + return policy->cpuinfo.perf_freq * perf_percent / 100; } static unsigned int cf_check get_cur_freq_on_cpu(unsigned int cpu) diff --git a/xen/drivers/cpufreq/utility.c b/xen/drivers/cpufreq/utility.c index 9eb7ecedcd..6831f62851 100644 --- a/xen/drivers/cpufreq/utility.c +++ b/xen/drivers/cpufreq/utility.c @@ -236,6 +236,7 @@ int cpufreq_frequency_table_cpuinfo(struct cpufreq_policy *policy, policy->min = policy->cpuinfo.min_freq = min_freq; policy->max = policy->cpuinfo.max_freq = max_freq; + policy->cpuinfo.perf_freq = max_freq; policy->cpuinfo.second_max_freq = second_max_freq; if (policy->min == ~0) diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 44fc4c58fc..1f1898d811 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -37,6 +37,9 @@ extern struct acpi_cpufreq_data *cpufreq_drv_data[NR_CPUS]; struct cpufreq_cpuinfo { unsigned int max_freq; unsigned int second_max_freq; /* P1 if Turbo Mode is on */ + unsigned int perf_freq; /* Scaling freq for aperf/mpref. + acpi-cpufreq uses max_freq, but HWP uses + base_freq.*/ unsigned int min_freq; unsigned int transition_latency; /* in 10^(-9) s = nanoseconds */ }; -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578795.906516 (Exim 4.92) (envelope-from ) id 1qT5Kr-0006Mi-MF; Mon, 07 Aug 2023 18:52:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578795.906516; Mon, 07 Aug 2023 18:52:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kr-0006MR-Ie; Mon, 07 Aug 2023 18:52:09 +0000 Received: by outflank-mailman (input) for mailman id 578795; Mon, 07 Aug 2023 18:52:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kp-0004GT-Uc for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:08 +0000 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [2607:f8b0:4864:20::72a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80641785-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:52:05 +0200 (CEST) Received: by mail-qk1-x72a.google.com with SMTP id af79cd13be357-766fd5f9536so290435485a.3 for ; Mon, 07 Aug 2023 11:52:05 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80641785-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434323; x=1692039123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gCOuYJf06lhbOIsw/F1/0m49/wq+20s+vXdSNsZE/tM=; b=F1ggc1h5yZl5XIQaGlZN6YoyCsqIh6cNGCed7oczn1Y9oCfoOMNiu2Oa7zMtQDmmaA whxc7xzm9FY7iDnduewdUvkJndU4jGG7+rMMc3p2r07N/ZE4d/grm6tkSNTsJQMiDb1C dnAjFCVv4RCimyeTFRUSGIzmqzGHLCEQkwsCNauLAGWjfScy+RwGoPO8PjldnpWi4OET s4N6TiPNIMVb2sxyK994bMgB5lKfj4YBH4m1Z1rKyMvE7T5WnrQxb6wFZYymhtYDceEp CYlUJdgaOtQbKDsNMKClEwAG+Q3/RfFoJnD1QNOsFzn2Os0frelmM+at/Pe5Q82Mchph ZuLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434323; x=1692039123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gCOuYJf06lhbOIsw/F1/0m49/wq+20s+vXdSNsZE/tM=; b=C/qHG4tCJNsCdop4peokqhSOSQ5eippXbFm6GGgPmN6M+qteiFNeacz3Po5hBKVx7d /r3wXqyXQxJqeRfCvArku7k6zdNtZVZhuT9CmnEO2ap88FkDic9MLq9A2+1kisDKYIKl Ua1sGvKQl2CJMVPprAhiJIDDkEcZ+THdgp90lxLJ0FtG1BWWQH/PWUwSkjmi7pMrbnMv 5na/FZcrjJylE7xN8z8POZvgmNullVDYq8zoIucWe6sizTtgRJykkAlsP6H3MMzWPqfh cXW1SbUJTWnkngosV/r8fRttUvBvuRIckxEA2GmtckQ4cOrwk6HfZMDnJXkofZoU/iAQ gdaQ== X-Gm-Message-State: AOJu0Yytrfqb6Bl8b8K1x/8PC17u6tXiQYDt6CbkmuCLGJDYXr3GiEf1 4eFmWgMHOC8AGFG4+zSYYd3I7Ji1yps= X-Google-Smtp-Source: AGHT+IHujdpFIqe/Uv0K3AdNjlLtHUsARcy+eS9d8Vl1C+iSYTV5Z8hoxyo/QVYU0TVLguIQFurS2g== X-Received: by 2002:a0c:be87:0:b0:636:afa1:345d with SMTP id n7-20020a0cbe87000000b00636afa1345dmr6374537qvi.17.1691434323398; Mon, 07 Aug 2023 11:52:03 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v8 06/15] cpufreq: Add Hardware P-State (HWP) driver Date: Mon, 7 Aug 2023 14:51:10 -0400 Message-ID: <20230807185119.98333-7-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit >From the Intel SDM: "Hardware-Controlled Performance States (HWP), which autonomously selects performance states while utilizing OS supplied performance guidance hints." Enable HWP to run in autonomous mode by poking the correct MSRs. HWP is disabled by default, and cpufreq=hwp enables it. cpufreq= parsing is expanded to allow cpufreq=hwp;xen. This allows trying HWP and falling back to xen if not available. Only hwp and xen are supported for this fallback feature. hdc is a sub-option under hwp (i.e. cpufreq=hwp,hdc=0) as is verbose. There is no interface to configure - xen_sysctl_pm_op/xenpm will be extended to configure in subsequent patches. It will run with the default values, which should be the default 0x80 (out of 0x0-0xff) energy/performance preference. Unscientific powertop measurement of an mostly idle, customized OpenXT install: A 10th gen 6-core laptop showed battery discharge drop from ~9.x to ~7.x watts. A 8th gen 4-core laptop dropped from ~10 to ~9 Power usage depends on many factors, especially display brightness, but this does show a power saving in balanced mode when CPU utilization is low. HWP isn't compatible with an external governor - it doesn't take explicit frequency requests. Therefore a minimal internal governor, hwp, is also added as a placeholder. While adding to the xen-command-line.pandoc entry, un-nest verbose from minfreq. They are independent. With cpufreq=hwp,verbose, HWP prints processor capabilities that are not used by the code, like HW_FEEDBACK. This is done because otherwise there isn't a convenient way to query the information. Xen doesn't use the HWP interrupt, so it is disabled like in the Linux pstate driver. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- We disable on cpuid_level < 0x16. cpuid(0x16) is used to get the cpu frequencies for calculating the APERF/MPERF. Without it, things would still work, but the average cpu frequency output would be wrong. My 8th & 10th gen test systems both report: (XEN) HWP: 1 notify: 1 act_window: 1 energy_perf: 1 pkg_level: 0 peci: 0 (XEN) HWP: Hardware Duty Cycling (HDC) supported (XEN) HWP: HW_FEEDBACK not supported We can't use parse_boolean() since it requires a single name=val string and cpufreq_handle_common_option is provided two strings. Use parse_bool() and manual handle no-hwp. FAST_IA32_HWP_REQUEST was removed in v2. The check in v1 was wrong, it's a model specific feature and the CPUID bit is only available after enabling via the MSR. Support was untested since I don't have hardware with the feature. Writes are expected to be infrequent, so just leave it out. --- v2: Alphabetize headers Re-work driver registration name hwp_drv_data anonymous union "hw" Drop hwp_verbose_cont style cleanups Condense hwp_governor switch hwp_cpufreq_target remove .raw from hwp_req assignment Use typed-pointer in a few functions Pass type to xzalloc Add HWP_ENERGY_PERF_BALANCE/IA32_ENERGY_BIAS_BALANCE defines Add XEN_HWP_GOVERNOR define for "hwp-internal" Capitalize CPUID and MSR defines Change '_' to '-' for energy-perf & act-window Read-modify-write MSRs updates Use FAST_IA32_HWP_REQUEST_MSR_ENABLE define constify pointer in hwp_set_misc_turbo Add space after non-fallthrough break in governor switch Add IA32_ENERGY_BIAS_MASK define Check CPUID_PM_LEAK for energy bias when needed Fail initialization with curr_req = -1 Fold hwp_read_capabilities into hwp_init_msrs Add command line cpufreq=xen:hwp Add command line cpufreq=xen:hdc Use per_cpu for hwp_drv_data pointers Move hwp_energy_perf_bias call into hwp_write_request energy_perf 0 is valid, so hwp_energy_perf_bias cannot be skipped Ensure we don't generate interrupts Remove Fast Write of Uncore MSR Initialize hwp_drv_data from curr_req Use SPDX line instead of license text in hwp.c v3: Add cf_check to cpufreq_gov_hwp_init() - Marek Print cpuid_level with %#x - Marek v4: Use BIT() for CPUID and MSR bits Move __initdata after type Add __ro_after_init to feature_* Remove aperf/mperf comment Move feature_hwp_energy_perf { to newline Remove _IA32_ infix Use unsigned int & bool for bitfields Require energy perf pref (Remove ENERGY_PERF_BIAS support) Initialize activity_window Return errors on wrmsr failure Change command line to: cpufreq=xen:hwp Move hdc into the hwp-specific handle_options Drop feature_hwp_energy_perf, feature_hwp_pkg_level_ctl & feature_hwp_peci Print features before exiting when energy/performance preference isn't available Disable HWP MSR on initialization error Change hwp_ print macros to add prefixes Disable HDC when hdc=0 - (opt_hdc no longer initdata) Mark hwp governor internal and use "hwp" name Add XEN_HWP_DRIVER Use top-level cpufreq=hwp command line option Document that cpufreq=hwp falls back to cpufreq=xen without hardware Add SPDX suffix GPL-2.0-only v5: Use _AC() macro in MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE definition hwp_err arg re-ordering Use XEN_HWP_DRIVER_NAME Use cpufreq.h for all declarations Clear feature_hdc on failure and print a message Use unnamed bitfields instead of reservered Remove asm/io.h include static DEFINE_PER_CPU_READ_MOSTLY(struct hwp_drv_data Remove some empty newlines Align feature_hdc assignment Remove feature_hwp Remove unnecesary return at end of void hwp_init_msrs() BUILD_BUG_ON member variable Reformat a compound if Clear pre_cpu hwp_drv_data before xfree() Only print HWP capabilities for CPU 0 Specify processor models in turbo comment Use arg[1] in setup_cpufreq_option() Remove some log messages Drop double newline Parse verbose as a boolean instead of the custom parsing. Support cpufreq=hwp;xen fallback Call hwp_available() from hwp_register_driver() Move cpufreq_govenor_internal setting to hwp_register_driver v6: docs: mention verbose applies to both. Use cpufreq=hwp;xen,verbose example with verbose at then end. Declare induction i inside for loop Add CPUFREQ_none Only call cpufreq fallback for -ENODEV Brace on newline fixes hdc_set_pkg_hdc_ctl()/hdc_set_pm_ctl1() return boolean Continue without hdc Consolidate hdc if statement Use hwp_req variable for BUILD_BUG_ON Newline between declarations and statement __initdata for cpufreq_xen_opts/cpufreq_xen_cnt Only print HWP_REQUEST when differing from BSP. Remove MSR_PM_ENABLE printing Move hdc_set_pkg_hdc_ctl(), hdc_set_pm_ctl1(), hwp_get_cpu_speeds(), and hwp_init_msrs() to before their sole caller, hwp_cpufreq_cpu_init() Fix cpufreq= parsing without options (set ret=0) Drop stray s NULL check Return -EINVAL from hwp_cmdline_parse() Latch first CPU HWP request and print differences Use strpbrk to split on ',' or ':' for arg in xen/hwp do..while Limit hwp parsing error to just current option with %.*s and (end ?: e) - s docs: Expand and clarify the handling of `verbose` with cpufreq fallbacks. v7: s/##_VA_ARGS/## args/ in macros Add __init to hwp_handle_option Add comment for 0 cpuid freqs Reword intel_feature_detect comment. Fix indent for HDC failure Make first_run static and use for first cpu latching hwp_set_misc_turbo() return -EACCES on error s/end/*end/ in setup_cpufreq_option() v8: Annotate first_run as __read_mostly Add Jan's Reviewed-by --- docs/misc/xen-command-line.pandoc | 20 +- xen/arch/x86/acpi/cpufreq/Makefile | 1 + xen/arch/x86/acpi/cpufreq/cpufreq.c | 21 +- xen/arch/x86/acpi/cpufreq/hwp.c | 524 ++++++++++++++++++++++++++ xen/arch/x86/include/asm/cpufeature.h | 12 +- xen/arch/x86/include/asm/msr-index.h | 15 +- xen/drivers/cpufreq/cpufreq.c | 59 ++- xen/include/acpi/cpufreq/cpufreq.h | 10 + xen/include/public/sysctl.h | 2 + 9 files changed, 649 insertions(+), 15 deletions(-) create mode 100644 xen/arch/x86/acpi/cpufreq/hwp.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index 9d66688bd1..abff141590 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -499,7 +499,7 @@ If set, force use of the performance counters for oprofile, rather than detectin available support. ### cpufreq -> `= none | {{ | xen } [:[powersave|performance|ondemand|userspace][,][,[][,[verbose]]]]} | dom0-kernel` +> `= none | {{ | xen } { [:[powersave|performance|ondemand|userspace][,[]][,[]]] } [,verbose]} | dom0-kernel | hwp[:[][,verbose]]` > Default: `xen` @@ -510,6 +510,24 @@ choice of `dom0-kernel` is deprecated and not supported by all Dom0 kernels. * `` and `` are integers which represent max and min processor frequencies respectively. * `verbose` option can be included as a string or also as `verbose=` + for `xen`. It is a boolean for `hwp`. +* `hwp` selects Hardware-Controlled Performance States (HWP) on supported Intel + hardware. HWP is a Skylake+ feature which provides better CPU power + management. The default is disabled. If `hwp` is selected, but hardware + support is not available, Xen will fallback to cpufreq=xen. +* `` is a boolean to enable Hardware Duty Cycling (HDC). HDC enables the + processor to autonomously force physical package components into idle state. + The default is enabled, but the option only applies when `hwp` is enabled. + +There is also support for `;`-separated fallback options: +`cpufreq=hwp;xen,verbose`. This first tries `hwp` and falls back to `xen` if +unavailable. Note: The `verbose` suboption is handled globally. Setting it +for either the primary or fallback option applies to both irrespective of where +it is specified. + +Note: grub2 requires to escape or quote ';', so `"cpufreq=hwp;xen"` should be +specified within double quotes inside grub.cfg. Refer to the grub2 +documentation for more information. ### cpuid (x86) > `= List of comma separated booleans` diff --git a/xen/arch/x86/acpi/cpufreq/Makefile b/xen/arch/x86/acpi/cpufreq/Makefile index f75da9b9ca..db83aa6b14 100644 --- a/xen/arch/x86/acpi/cpufreq/Makefile +++ b/xen/arch/x86/acpi/cpufreq/Makefile @@ -1,2 +1,3 @@ obj-y += cpufreq.o +obj-y += hwp.o obj-y += powernow.o diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index f1cc473b4f..61b62c370a 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -642,7 +642,26 @@ static int __init cf_check cpufreq_driver_init(void) switch ( boot_cpu_data.x86_vendor ) { case X86_VENDOR_INTEL: - ret = cpufreq_register_driver(&acpi_cpufreq_driver); + ret = -ENOENT; + + for ( unsigned int i = 0; i < cpufreq_xen_cnt; i++ ) + { + switch ( cpufreq_xen_opts[i] ) + { + case CPUFREQ_xen: + ret = cpufreq_register_driver(&acpi_cpufreq_driver); + break; + case CPUFREQ_hwp: + ret = hwp_register_driver(); + break; + case CPUFREQ_none: + ret = 0; + break; + } + + if ( ret != -ENODEV ) + break; + } break; case X86_VENDOR_AMD: diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c new file mode 100644 index 0000000000..932786ccca --- /dev/null +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -0,0 +1,524 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * hwp.c cpufreq driver to run Intel Hardware P-States (HWP) + * + * Copyright (C) 2021 Jason Andryuk + */ + +#include +#include +#include +#include +#include +#include + +static bool __ro_after_init feature_hwp_notification; +static bool __ro_after_init feature_hwp_activity_window; + +static bool __ro_after_init feature_hdc; + +static bool __ro_after_init opt_cpufreq_hdc = true; + +union hwp_request +{ + struct + { + unsigned int min_perf:8; + unsigned int max_perf:8; + unsigned int desired:8; + unsigned int energy_perf:8; + unsigned int activity_window:10; + bool package_control:1; + unsigned int :16; + bool activity_window_valid:1; + bool energy_perf_valid:1; + bool desired_valid:1; + bool max_perf_valid:1; + bool min_perf_valid:1; + }; + uint64_t raw; +}; + +struct hwp_drv_data +{ + union + { + uint64_t hwp_caps; + struct + { + unsigned int highest:8; + unsigned int guaranteed:8; + unsigned int most_efficient:8; + unsigned int lowest:8; + unsigned int :32; + } hw; + }; + union hwp_request curr_req; + int ret; + uint16_t activity_window; + uint8_t minimum; + uint8_t maximum; + uint8_t desired; + uint8_t energy_perf; +}; +static DEFINE_PER_CPU_READ_MOSTLY(struct hwp_drv_data *, hwp_drv_data); + +#define hwp_err(cpu, fmt, args...) \ + printk(XENLOG_ERR "HWP: CPU%u error: " fmt, cpu, ## args) +#define hwp_info(fmt, args...) printk(XENLOG_INFO "HWP: " fmt, ## args) +#define hwp_verbose(fmt, args...) \ +({ \ + if ( cpufreq_verbose ) \ + printk(XENLOG_DEBUG "HWP: " fmt, ## args); \ +}) + +static int cf_check hwp_governor(struct cpufreq_policy *policy, + unsigned int event) +{ + int ret; + + if ( policy == NULL ) + return -EINVAL; + + switch ( event ) + { + case CPUFREQ_GOV_START: + case CPUFREQ_GOV_LIMITS: + ret = 0; + break; + + case CPUFREQ_GOV_STOP: + default: + ret = -EINVAL; + break; + } + + return ret; +} + +static bool __init hwp_handle_option(const char *s, const char *end) +{ + int ret; + + ret = parse_boolean("verbose", s, end); + if ( ret >= 0 ) + { + cpufreq_verbose = ret; + return true; + } + + ret = parse_boolean("hdc", s, end); + if ( ret >= 0 ) + { + opt_cpufreq_hdc = ret; + return true; + } + + return false; +} + +int __init hwp_cmdline_parse(const char *s, const char *e) +{ + do + { + const char *end = strpbrk(s, ",;"); + + if ( !hwp_handle_option(s, end) ) + { + printk(XENLOG_WARNING "cpufreq/hwp: option '%.*s' not recognized\n", + (int)((end ?: e) - s), s); + + return -EINVAL; + } + + s = end ? ++end : end; + } while ( s && s < e ); + + return 0; +} + +static struct cpufreq_governor cpufreq_gov_hwp = +{ + .name = "hwp", + .governor = hwp_governor, +}; + +static int __init cf_check cpufreq_gov_hwp_init(void) +{ + if ( !cpufreq_governor_internal ) + return 0; + + return cpufreq_register_governor(&cpufreq_gov_hwp); +} +__initcall(cpufreq_gov_hwp_init); + +static bool __init hwp_available(void) +{ + unsigned int eax; + + if ( boot_cpu_data.cpuid_level < CPUID_PM_LEAF ) + { + hwp_verbose("cpuid_level (%#x) lacks HWP support\n", + boot_cpu_data.cpuid_level); + + return false; + } + + if ( boot_cpu_data.cpuid_level < 0x16 ) + { + hwp_info("HWP disabled: cpuid_level %#x < 0x16 lacks CPU freq info\n", + boot_cpu_data.cpuid_level); + + return false; + } + + eax = cpuid_eax(CPUID_PM_LEAF); + + hwp_verbose("%d notify: %d act-window: %d energy-perf: %d pkg-level: %d peci: %d\n", + !!(eax & CPUID6_EAX_HWP), + !!(eax & CPUID6_EAX_HWP_NOTIFICATION), + !!(eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW), + !!(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE), + !!(eax & CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST), + !!(eax & CPUID6_EAX_HWP_PECI)); + + if ( !(eax & CPUID6_EAX_HWP) ) + return false; + + if ( !(eax & CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE) ) + { + hwp_verbose("disabled: No energy/performance preference available"); + + return false; + } + + feature_hwp_notification = eax & CPUID6_EAX_HWP_NOTIFICATION; + feature_hwp_activity_window = eax & CPUID6_EAX_HWP_ACTIVITY_WINDOW; + feature_hdc = eax & CPUID6_EAX_HDC; + + hwp_verbose("Hardware Duty Cycling (HDC) %ssupported%s\n", + feature_hdc ? "" : "not ", + feature_hdc ? opt_cpufreq_hdc ? ", enabled" : ", disabled" + : ""); + + hwp_verbose("HW_FEEDBACK %ssupported\n", + (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); + + hwp_info("Using HWP for cpufreq\n"); + + return true; +} + +static int cf_check hwp_cpufreq_verify(struct cpufreq_policy *policy) +{ + struct hwp_drv_data *data = per_cpu(hwp_drv_data, policy->cpu); + + if ( !feature_hwp_activity_window && data->activity_window ) + { + hwp_verbose("HWP activity window not supported\n"); + + return -EINVAL; + } + + return 0; +} + +static void cf_check hwp_write_request(void *info) +{ + const struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = this_cpu(hwp_drv_data); + union hwp_request hwp_req = data->curr_req; + + data->ret = 0; + + BUILD_BUG_ON(sizeof(hwp_req) != sizeof(hwp_req.raw)); + if ( wrmsr_safe(MSR_HWP_REQUEST, hwp_req.raw) ) + { + hwp_verbose("CPU%u: error wrmsr_safe(MSR_HWP_REQUEST, %lx)\n", + policy->cpu, hwp_req.raw); + rdmsr_safe(MSR_HWP_REQUEST, data->curr_req.raw); + data->ret = -EINVAL; + } +} + +static int cf_check hwp_cpufreq_target(struct cpufreq_policy *policy, + unsigned int target_freq, + unsigned int relation) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + /* Zero everything to ensure reserved bits are zero... */ + union hwp_request hwp_req = { .raw = 0 }; + + /* .. and update from there */ + hwp_req.min_perf = data->minimum; + hwp_req.max_perf = data->maximum; + hwp_req.desired = data->desired; + hwp_req.energy_perf = data->energy_perf; + if ( feature_hwp_activity_window ) + hwp_req.activity_window = data->activity_window; + + if ( hwp_req.raw == data->curr_req.raw ) + return 0; + + data->curr_req = hwp_req; + + on_selected_cpus(cpumask_of(cpu), hwp_write_request, policy, 1); + + return data->ret; +} + +static bool hdc_set_pkg_hdc_ctl(unsigned int cpu, bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_PKG_HDC_CTL, msr) ) + { + hwp_err(cpu, "rdmsr_safe(MSR_PKG_HDC_CTL)\n"); + return false; + } + + if ( val ) + msr |= PKG_HDC_CTL_HDC_PKG_ENABLE; + else + msr &= ~PKG_HDC_CTL_HDC_PKG_ENABLE; + + if ( wrmsr_safe(MSR_PKG_HDC_CTL, msr) ) + { + hwp_err(cpu, "wrmsr_safe(MSR_PKG_HDC_CTL): %016lx\n", msr); + return false; + } + + return true; +} + +static bool hdc_set_pm_ctl1(unsigned int cpu, bool val) +{ + uint64_t msr; + + if ( rdmsr_safe(MSR_PM_CTL1, msr) ) + { + hwp_err(cpu, "rdmsr_safe(MSR_PM_CTL1)\n"); + return false; + } + + if ( val ) + msr |= PM_CTL1_HDC_ALLOW_BLOCK; + else + msr &= ~PM_CTL1_HDC_ALLOW_BLOCK; + + if ( wrmsr_safe(MSR_PM_CTL1, msr) ) + { + hwp_err(cpu, "wrmsr_safe(MSR_PM_CTL1): %016lx\n", msr); + return false; + } + + return true; +} + +static void hwp_get_cpu_speeds(struct cpufreq_policy *policy) +{ + uint32_t base_khz, max_khz, bus_khz, edx; + + cpuid(0x16, &base_khz, &max_khz, &bus_khz, &edx); + + /* + * Zero values are acceptable - they are not used for calculations + * and only returned to userspace. + */ + policy->cpuinfo.perf_freq = base_khz * 1000; + policy->cpuinfo.min_freq = base_khz * 1000; + policy->cpuinfo.max_freq = max_khz * 1000; + policy->min = base_khz * 1000; + policy->max = max_khz * 1000; + policy->cur = 0; +} + +static void cf_check hwp_init_msrs(void *info) +{ + struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = this_cpu(hwp_drv_data); + uint64_t val; + + /* + * Package level MSR, but we don't have a good idea of packages here, so + * just do it everytime. + */ + if ( rdmsr_safe(MSR_PM_ENABLE, val) ) + { + hwp_err(policy->cpu, "rdmsr_safe(MSR_PM_ENABLE)\n"); + data->curr_req.raw = -1; + return; + } + + /* Ensure we don't generate interrupts */ + if ( feature_hwp_notification ) + wrmsr_safe(MSR_HWP_INTERRUPT, 0); + + if ( !(val & PM_ENABLE_HWP_ENABLE) ) + { + val |= PM_ENABLE_HWP_ENABLE; + if ( wrmsr_safe(MSR_PM_ENABLE, val) ) + { + hwp_err(policy->cpu, "wrmsr_safe(MSR_PM_ENABLE, %lx)\n", val); + data->curr_req.raw = -1; + return; + } + } + + if ( rdmsr_safe(MSR_HWP_CAPABILITIES, data->hwp_caps) ) + { + hwp_err(policy->cpu, "rdmsr_safe(MSR_HWP_CAPABILITIES)\n"); + goto error; + } + + if ( rdmsr_safe(MSR_HWP_REQUEST, data->curr_req.raw) ) + { + hwp_err(policy->cpu, "rdmsr_safe(MSR_HWP_REQUEST)\n"); + goto error; + } + + /* Check for turbo support. */ + intel_feature_detect(policy); + + if ( feature_hdc && + (!hdc_set_pkg_hdc_ctl(policy->cpu, opt_cpufreq_hdc) || + !hdc_set_pm_ctl1(policy->cpu, opt_cpufreq_hdc)) ) + { + hwp_err(policy->cpu, "Disabling HDC support\n"); + feature_hdc = false; + } + + hwp_get_cpu_speeds(policy); + + return; + + error: + data->curr_req.raw = -1; + val &= ~PM_ENABLE_HWP_ENABLE; + if ( wrmsr_safe(MSR_PM_ENABLE, val) ) + hwp_err(policy->cpu, "wrmsr_safe(MSR_PM_ENABLE, %lx)\n", val); +} + +static int cf_check hwp_cpufreq_cpu_init(struct cpufreq_policy *policy) +{ + static bool __read_mostly first_run = true; + static union hwp_request initial_req; + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data; + + data = xzalloc(struct hwp_drv_data); + if ( !data ) + return -ENOMEM; + + policy->governor = &cpufreq_gov_hwp; + + per_cpu(hwp_drv_data, cpu) = data; + + on_selected_cpus(cpumask_of(cpu), hwp_init_msrs, policy, 1); + + if ( data->curr_req.raw == -1 ) + { + hwp_err(cpu, "Could not initialize HWP properly\n"); + per_cpu(hwp_drv_data, cpu) = NULL; + xfree(data); + return -ENODEV; + } + + data->minimum = data->curr_req.min_perf; + data->maximum = data->curr_req.max_perf; + data->desired = data->curr_req.desired; + data->energy_perf = data->curr_req.energy_perf; + data->activity_window = data->curr_req.activity_window; + + if ( first_run ) + { + hwp_verbose("CPU%u: HWP_CAPABILITIES: %016lx\n", cpu, data->hwp_caps); + initial_req = data->curr_req; + } + + if ( first_run || data->curr_req.raw != initial_req.raw ) + { + hwp_verbose("CPU%u: rdmsr HWP_REQUEST %016lx\n", cpu, + data->curr_req.raw); + first_run = false; + } + + return 0; +} + +static int cf_check hwp_cpufreq_cpu_exit(struct cpufreq_policy *policy) +{ + struct hwp_drv_data *data = per_cpu(hwp_drv_data, policy->cpu); + + per_cpu(hwp_drv_data, policy->cpu) = NULL; + xfree(data); + + return 0; +} + +/* + * The SDM reads like turbo should be disabled with MSR_IA32_PERF_CTL and + * PERF_CTL_TURBO_DISENGAGE, but that does not seem to actually work, at least + * with testing on i7-10810U and i7-8550U. MSR_MISC_ENABLE and + * MISC_ENABLE_TURBO_DISENGAGE is what Linux uses and seems to work. + */ +static void cf_check hwp_set_misc_turbo(void *info) +{ + const struct cpufreq_policy *policy = info; + struct hwp_drv_data *data = per_cpu(hwp_drv_data, policy->cpu); + uint64_t msr; + + data->ret = 0; + + if ( rdmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + { + hwp_verbose("CPU%u: error rdmsr_safe(MSR_IA32_MISC_ENABLE)\n", + policy->cpu); + data->ret = -EACCES; + + return; + } + + if ( policy->turbo == CPUFREQ_TURBO_ENABLED ) + msr &= ~MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + else + msr |= MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE; + + if ( wrmsr_safe(MSR_IA32_MISC_ENABLE, msr) ) + { + hwp_verbose("CPU%u: error wrmsr_safe(MSR_IA32_MISC_ENABLE): %016lx\n", + policy->cpu, msr); + data->ret = -EACCES; + } +} + +static int cf_check hwp_cpufreq_update(int cpuid, struct cpufreq_policy *policy) +{ + on_selected_cpus(cpumask_of(cpuid), hwp_set_misc_turbo, policy, 1); + + return per_cpu(hwp_drv_data, cpuid)->ret; +} + +static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = +{ + .name = XEN_HWP_DRIVER_NAME, + .verify = hwp_cpufreq_verify, + .target = hwp_cpufreq_target, + .init = hwp_cpufreq_cpu_init, + .exit = hwp_cpufreq_cpu_exit, + .update = hwp_cpufreq_update, +}; + +int __init hwp_register_driver(void) +{ + int ret; + + if ( !hwp_available() ) + return -ENODEV; + + ret = cpufreq_register_driver(&hwp_cpufreq_driver); + cpufreq_governor_internal = (ret == 0); + + return ret; +} diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index 64e1dad225..93466441f5 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -52,8 +52,16 @@ static inline bool boot_cpu_has(unsigned int feat) return cpu_has(&boot_cpu_data, feat); } -#define CPUID_PM_LEAF 6 -#define CPUID6_ECX_APERFMPERF_CAPABILITY 0x1 +#define CPUID_PM_LEAF 6 +#define CPUID6_EAX_HWP BIT(7, U) +#define CPUID6_EAX_HWP_NOTIFICATION BIT(8, U) +#define CPUID6_EAX_HWP_ACTIVITY_WINDOW BIT(9, U) +#define CPUID6_EAX_HWP_ENERGY_PERFORMANCE_PREFERENCE BIT(10, U) +#define CPUID6_EAX_HWP_PACKAGE_LEVEL_REQUEST BIT(11, U) +#define CPUID6_EAX_HDC BIT(13, U) +#define CPUID6_EAX_HWP_PECI BIT(16, U) +#define CPUID6_EAX_HW_FEEDBACK BIT(19, U) +#define CPUID6_ECX_APERFMPERF_CAPABILITY BIT(0, U) /* CPUID level 0x00000001.edx */ #define cpu_has_fpu 1 diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 4d41c171d2..2705982d93 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -151,6 +151,13 @@ #define MSR_PKRS 0x000006e1 +#define MSR_PM_ENABLE 0x00000770 +#define PM_ENABLE_HWP_ENABLE BIT(0, ULL) + +#define MSR_HWP_CAPABILITIES 0x00000771 +#define MSR_HWP_INTERRUPT 0x00000773 +#define MSR_HWP_REQUEST 0x00000774 + #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff @@ -165,6 +172,11 @@ #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_PKG_HDC_CTL 0x00000db0 +#define PKG_HDC_CTL_HDC_PKG_ENABLE BIT(0, ULL) +#define MSR_PM_CTL1 0x00000db1 +#define PM_CTL1_HDC_ALLOW_BLOCK BIT(0, ULL) + #define MSR_UARCH_MISC_CTRL 0x00001b01 #define UARCH_CTRL_DOITM (_AC(1, ULL) << 0) @@ -468,7 +480,8 @@ #define MSR_IA32_MISC_ENABLE_MONITOR_ENABLE (1<<18) #define MSR_IA32_MISC_ENABLE_LIMIT_CPUID (1<<22) #define MSR_IA32_MISC_ENABLE_XTPR_DISABLE (1<<23) -#define MSR_IA32_MISC_ENABLE_XD_DISABLE (_AC(1, ULL) << 34) +#define MSR_IA32_MISC_ENABLE_XD_DISABLE (_AC(1, ULL) << 34) +#define MSR_IA32_MISC_ENABLE_TURBO_DISENGAGE (_AC(1, ULL) << 38) #define MSR_IA32_TSC_DEADLINE 0x000006E0 #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0 diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 67a58d409b..81bda5df23 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -63,12 +63,19 @@ LIST_HEAD_READ_MOSTLY(cpufreq_governor_list); /* set xen as default cpufreq */ enum cpufreq_controller cpufreq_controller = FREQCTL_xen; -static int __init cpufreq_cmdline_parse(const char *s); +enum cpufreq_xen_opt __initdata cpufreq_xen_opts[2] = { CPUFREQ_xen, + CPUFREQ_none }; +unsigned int __initdata cpufreq_xen_cnt = 1; + +static int __init cpufreq_cmdline_parse(const char *s, const char *e); static int __init cf_check setup_cpufreq_option(const char *str) { - const char *arg = strpbrk(str, ",:"); + const char *arg = strpbrk(str, ",:;"); int choice; + int ret = -EINVAL; + + cpufreq_xen_cnt = 0; if ( !arg ) arg = strchr(str, '\0'); @@ -89,15 +96,45 @@ static int __init cf_check setup_cpufreq_option(const char *str) return 0; } - if ( choice > 0 || !cmdline_strcmp(str, "xen") ) + do { - xen_processor_pmbits |= XEN_PROCESSOR_PM_PX; - cpufreq_controller = FREQCTL_xen; - if ( *arg && *(arg + 1) ) - return cpufreq_cmdline_parse(arg + 1); - } + const char *end = strchr(str, ';'); + + if ( end == NULL ) + end = strchr(str, '\0'); + + arg = strpbrk(str, ",:"); + if ( !arg || arg > end ) + arg = strchr(str, '\0'); + + if ( cpufreq_xen_cnt == ARRAY_SIZE(cpufreq_xen_opts) ) + return -E2BIG; + + if ( choice > 0 || !cmdline_strcmp(str, "xen") ) + { + xen_processor_pmbits |= XEN_PROCESSOR_PM_PX; + cpufreq_controller = FREQCTL_xen; + cpufreq_xen_opts[cpufreq_xen_cnt++] = CPUFREQ_xen; + ret = 0; + if ( arg[0] && arg[1] ) + ret = cpufreq_cmdline_parse(arg + 1, end); + } + else if ( choice < 0 && !cmdline_strcmp(str, "hwp") ) + { + xen_processor_pmbits |= XEN_PROCESSOR_PM_PX; + cpufreq_controller = FREQCTL_xen; + cpufreq_xen_opts[cpufreq_xen_cnt++] = CPUFREQ_hwp; + ret = 0; + if ( arg[0] && arg[1] ) + ret = hwp_cmdline_parse(arg + 1, end); + } + else + ret = -EINVAL; + + str = *end ? ++end : end; + } while ( choice < 0 && ret == 0 && *str ); - return (choice < 0) ? -EINVAL : 0; + return (choice < 0) ? ret : 0; } custom_param("cpufreq", setup_cpufreq_option); @@ -576,7 +613,7 @@ static int __init cpufreq_handle_common_option(const char *name, const char *val return 0; } -static int __init cpufreq_cmdline_parse(const char *s) +static int __init cpufreq_cmdline_parse(const char *s, const char *e) { static struct cpufreq_governor *__initdata cpufreq_governors[] = { @@ -592,6 +629,8 @@ static int __init cpufreq_cmdline_parse(const char *s) int rc = 0; strlcpy(buf, s, sizeof(buf)); + if (e - s < sizeof(buf)) + buf[e - s] = '\0'; do { char *val, *end = strchr(str, ','); unsigned int i; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 482ea5b0de..cfe975814e 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -24,6 +24,13 @@ DECLARE_PER_CPU(spinlock_t, cpufreq_statistic_lock); extern bool_t cpufreq_verbose; +enum cpufreq_xen_opt { + CPUFREQ_none, + CPUFREQ_xen, + CPUFREQ_hwp, +}; +extern enum cpufreq_xen_opt cpufreq_xen_opts[2]; +extern unsigned int cpufreq_xen_cnt; struct cpufreq_governor; struct acpi_cpufreq_data { @@ -245,4 +252,7 @@ void cpufreq_dbs_timer_resume(void); void intel_feature_detect(struct cpufreq_policy *policy); +int hwp_cmdline_parse(const char *s, const char *e); +int hwp_register_driver(void); + #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index c11c0b1a6c..5a30b16fcf 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -296,6 +296,8 @@ struct xen_ondemand { uint32_t up_threshold; }; +#define XEN_HWP_DRIVER_NAME "hwp" + /* * cpufreq para name of this structure named * same as sysfs file name of native linux -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578797.906522 (Exim 4.92) (envelope-from ) id 1qT5Ks-0006V1-80; Mon, 07 Aug 2023 18:52:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578797.906522; Mon, 07 Aug 2023 18:52:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Ks-0006TE-1r; Mon, 07 Aug 2023 18:52:10 +0000 Received: by outflank-mailman (input) for mailman id 578797; Mon, 07 Aug 2023 18:52:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kr-0004lg-8b for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:09 +0000 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [2607:f8b0:4864:20::936]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 820632c1-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:52:08 +0200 (CEST) Received: by mail-ua1-x936.google.com with SMTP id a1e0cc1a2514c-79969c14964so1276083241.2 for ; Mon, 07 Aug 2023 11:52:08 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 820632c1-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434327; x=1692039127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E7GMVxKHH5c0AlSKBRhOVtwdBCMeAlRn7S7x06padXs=; b=XCmwnixDv+P8jXyZGp6Ful597i+goriPcgErFJPTMtTgxeZqY/Q0Ajs9ohD+8PP82e UeUzo3oLKWCHlTsKFS2PMjJ/34ywunH+ptgjru3/jDG2mZCQO3Wd5jT6KuZ6u4Qd4Huq flh8y1KxcEzQPCm5x6TKp/TU9mqqGYrbCC+LMhDqwn0DipM7uNdUzPsmohFbv4uLHjPM lTGLMVvCWDYtJz5M+Wg4kOtZ3hfmJtdEmCK2AMjFHqDhNGadg1M15tVm4OjWHYIjCqCO dtZFc7RxEhF93+nG0lgCDqH83W5Ff6dOPPUrGJIYOA80vfR16wGlBbNCJZ12iGNaTfFg BAwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434327; x=1692039127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7GMVxKHH5c0AlSKBRhOVtwdBCMeAlRn7S7x06padXs=; b=Pfxq1OqRLd00VtPjpOupPacJ3EvercF0mtfdo+YLz+Nm34ldO7JBE9b3yRwcqsEbdx H9ttQB4maFi5H0TtaYbXR49WZXAD9E0QDfAmVIsgIpy2PW3KN8MDLgwKjGUCrgD6GVnI mW341C2+xqA/VRiIYm5zpZYpsz8DOe/xtMWntEXDwaYQnw4tMSQLjYyQnNhaDCEy98of ODOjV1TaCyLWhQl/frfz3pxQuzuGqnTT7onQwqjJ242erw0Gr86EiO+1ap9Udy1njJjX UuZLvxer8MbYRkBRd3zNagc9nFkXia+tn0KZW9tZa9CychpfzfSxueDEmnPBJcxiovFh BisQ== X-Gm-Message-State: AOJu0YzfYANs2DjuDc9gAZ/1YjNvbxpM6iX11NksJLy2NxEgMoJz8oNB +hy11m9zPkCiGAZ4jRkOTcK8bWTuVCU= X-Google-Smtp-Source: AGHT+IGjSLSy/mXFwup5H0qfBTeFN88TKLtyXudtjOyP2AxytZ1td1acQxQ2Ypp14HMXA6Y+BZ2fYQ== X-Received: by 2002:a67:bd01:0:b0:443:65cb:1364 with SMTP id y1-20020a67bd01000000b0044365cb1364mr4946213vsq.6.1691434326778; Mon, 07 Aug 2023 11:52:06 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v8 07/15] xen/x86: Tweak PDC bits when using HWP Date: Mon, 7 Aug 2023 14:51:11 -0400 Message-ID: <20230807185119.98333-8-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Qubes testing of HWP support had a report of a laptop, Thinkpad X1 Carbon Gen 4 with a Skylake processor, locking up during boot when HWP is enabled. A user found a kernel bug that seems to be the same issue: https://bugzilla.kernel.org/show_bug.cgi?id=110941. That bug was fixed by Linux commit a21211672c9a ("ACPI / processor: Request native thermal interrupt handling via _OSC"). The tl;dr is SMM crashes when it receives thermal interrupts, so Linux calls the ACPI _OSC method to take over interrupt handling. The Linux fix looks at the CPU features to decide whether or not to call _OSC with bit 12 set to take over native interrupt handling. Xen needs some way to communicate HWP to Dom0 for making an equivalent call. Xen exposes modified PDC bits via the platform_op set_pminfo hypercall. Expand that to set bit 12 when HWP is present and in use. Any generated interrupt would be handled by Xen's thermal drive, which clears the status. Bit 12 isn't named in the linux header and is open coded in Linux's usage. Name it ACPI_PDC_CPPC_NATIVE_INTR. This will need a corresponding linux patch to pick up and apply the PDC bits. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v5: Minor fixup for feature_hwp removal Use cpurfreq.h for declaration v4: Added __ro_after_init s/ACPI_PDC_CPPC_NTV_INT/ACPI_PDC_CPPC_NATIVE_INTR/ Remove _IA32_ Fixup for opt_cpufreq_hwp removal Add Jan Reviewed-by v3: New --- xen/arch/x86/acpi/cpufreq/hwp.c | 9 +++++++++ xen/arch/x86/acpi/lib.c | 5 +++++ xen/arch/x86/cpu/mcheck/mce_intel.c | 6 ++++++ xen/arch/x86/include/asm/msr-index.h | 1 + xen/include/acpi/cpufreq/cpufreq.h | 1 + xen/include/acpi/pdc_intel.h | 1 + 6 files changed, 23 insertions(+) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index 932786ccca..9be622f492 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -12,6 +12,8 @@ #include #include +static bool __ro_after_init hwp_in_use; + static bool __ro_after_init feature_hwp_notification; static bool __ro_after_init feature_hwp_activity_window; @@ -152,6 +154,11 @@ static int __init cf_check cpufreq_gov_hwp_init(void) } __initcall(cpufreq_gov_hwp_init); +bool hwp_active(void) +{ + return hwp_in_use; +} + static bool __init hwp_available(void) { unsigned int eax; @@ -204,6 +211,8 @@ static bool __init hwp_available(void) hwp_verbose("HW_FEEDBACK %ssupported\n", (eax & CPUID6_EAX_HW_FEEDBACK) ? "" : "not "); + hwp_in_use = true; + hwp_info("Using HWP for cpufreq\n"); return true; diff --git a/xen/arch/x86/acpi/lib.c b/xen/arch/x86/acpi/lib.c index 43831b92d1..51cb082ca0 100644 --- a/xen/arch/x86/acpi/lib.c +++ b/xen/arch/x86/acpi/lib.c @@ -26,6 +26,8 @@ #include #include +#include + u32 __read_mostly acpi_smi_cmd; u8 __read_mostly acpi_enable_value; u8 __read_mostly acpi_disable_value; @@ -140,5 +142,8 @@ int arch_acpi_set_pdc_bits(u32 acpi_id, u32 *pdc, u32 mask) !(ecx & CPUID5_ECX_INTERRUPT_BREAK)) pdc[2] &= ~(ACPI_PDC_C_C1_FFH | ACPI_PDC_C_C2C3_FFH); + if (hwp_active()) + pdc[2] |= ACPI_PDC_CPPC_NATIVE_INTR; + return 0; } diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c b/xen/arch/x86/cpu/mcheck/mce_intel.c index 2f23f02923..4045c6591d 100644 --- a/xen/arch/x86/cpu/mcheck/mce_intel.c +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c @@ -15,6 +15,9 @@ #include #include #include + +#include + #include "mce.h" #include "x86_mca.h" #include "barrier.h" @@ -64,6 +67,9 @@ static void cf_check intel_thermal_interrupt(struct cpu_user_regs *regs) ack_APIC_irq(); + if ( hwp_active() ) + wrmsr_safe(MSR_HWP_STATUS, 0); + if ( NOW() < per_cpu(next, cpu) ) return; diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 2705982d93..185d3c491e 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -157,6 +157,7 @@ #define MSR_HWP_CAPABILITIES 0x00000771 #define MSR_HWP_INTERRUPT 0x00000773 #define MSR_HWP_REQUEST 0x00000774 +#define MSR_HWP_STATUS 0x00000777 #define MSR_X2APIC_FIRST 0x00000800 #define MSR_X2APIC_LAST 0x000008ff diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index cfe975814e..6737798e25 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -254,5 +254,6 @@ void intel_feature_detect(struct cpufreq_policy *policy); int hwp_cmdline_parse(const char *s, const char *e); int hwp_register_driver(void); +bool hwp_active(void); #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/acpi/pdc_intel.h b/xen/include/acpi/pdc_intel.h index 4fb719d6f5..abaa098b51 100644 --- a/xen/include/acpi/pdc_intel.h +++ b/xen/include/acpi/pdc_intel.h @@ -17,6 +17,7 @@ #define ACPI_PDC_C_C1_FFH (0x0100) #define ACPI_PDC_C_C2C3_FFH (0x0200) #define ACPI_PDC_SMP_P_HWCOORD (0x0800) +#define ACPI_PDC_CPPC_NATIVE_INTR (0x1000) #define ACPI_PDC_EST_CAPABILITY_SMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \ -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578798.906535 (Exim 4.92) (envelope-from ) id 1qT5Kt-0006wZ-Hs; Mon, 07 Aug 2023 18:52:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578798.906535; Mon, 07 Aug 2023 18:52:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kt-0006vR-DJ; Mon, 07 Aug 2023 18:52:11 +0000 Received: by outflank-mailman (input) for mailman id 578798; Mon, 07 Aug 2023 18:52:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Ks-0004lg-E1 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:10 +0000 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [2607:f8b0:4864:20::f2f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 82dba3c6-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:52:09 +0200 (CEST) Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-63cf69f3c22so34293286d6.3 for ; Mon, 07 Aug 2023 11:52:09 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 82dba3c6-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434328; x=1692039128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fPqtnsHma2CfZS2wC9zaYpit9POpmY/2Wfh8kuw75z0=; b=ppenxGwClsnUAAp2/zqhU27AyvhhEJKfOPrRPJy0jaGfC0ksjWfsyADLYijCgL/r3J 84dBKQ3MElDb1Z+cxwaXMZNQVldi8HR3FTnht9+REg13Lol6xbf8sDINWxhfu/vCY3IT e/1eLY1Ef0I1ZeMOJLBNTTbd2Lhg5GevI+BtGz0BOyWjrOaaLlKn6gQpZA3ZucBiOhPb o47GLfaMPUxTun4GTbW9Xh9vsTONXYwr8h0aCZKnv08ENFNjt5PaSPctEOA6iOrRiw6R Lt69seNe7f5DgzeqmaHUcnDhP6fTSk2zofcHlcgBQz2Xxe/fiO5nPETl3NKb3XxEGXJM RTow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434328; x=1692039128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fPqtnsHma2CfZS2wC9zaYpit9POpmY/2Wfh8kuw75z0=; b=UabJVbCVFGnq8GcERK5ppwxVlX0T1SazTfxubLudsGUgh/h59N49Guwv2sQeTHj/jA RuyDx+3ufQylU+lz+1X2lCjWnMcknDf7t8u3u72n74qwTIRTvN37/IIkztsD9H685H8d w9HIwIw+OUPr1MAj7UznEA6Z84Pb90awd+YdMVmWhhIGgOlIQow/f0+2lD7QAwlW6LTU RsJr5U/6ZcEL1pzcSIkfMh1NZMgHr0s1mP1SMUI/ofE9prlrglFQCy/dsS47jkoQ9s+O EtTfnbqgfpuHNx1pYrQ1oaevvGEjCWSD5tRT4SNWRKqZHuD670cmM2GVolsWjKxTW9RA 4aXQ== X-Gm-Message-State: AOJu0YwU/lXJx1MTlAcOMV7YjJdEhq35TU61nZQmyv0WQDvstuau8Jtp azRZGQEpjIsClNKjT82I83G9P1Jc9V0= X-Google-Smtp-Source: AGHT+IEHQ/4/PfxRMgbqK/pM4ZITYqRK+XG5OfVqUINfsLCIhNx8quJd7Iw7hHNL/NJSMP+fVE0CZg== X-Received: by 2002:a0c:ea4f:0:b0:63d:1573:c292 with SMTP id u15-20020a0cea4f000000b0063d1573c292mr9336327qvp.65.1691434328113; Mon, 07 Aug 2023 11:52:08 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Jan Beulich Subject: [PATCH v8 08/15] xenpm: Change get-cpufreq-para output for hwp Date: Mon, 7 Aug 2023 14:51:12 -0400 Message-ID: <20230807185119.98333-9-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When using HWP, some of the returned data is not applicable. In that case, we should just omit it to avoid confusing the user. So switch to printing the base and max frequencies since those are relevant to HWP. Similarly, stop printing the CPU frequencies since those do not apply. The scaling fields are also no longer printed. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich Acked-by: Anthony PERARD --- v8: Use %PRIu32 for added hwp printing Add Anthony's Ack v5: Use XEN_HWP_DRIVER_NAME Add Jan's Ack v4: s/turbo/max/ Check for XEN_HWP_DRIVER driver instead of "-internal" v2: Use full governor name XEN_HWP_GOVERNOR to change output Style fixes --- tools/misc/xenpm.c | 83 +++++++++++++++++++++++++--------------------- 1 file changed, 46 insertions(+), 37 deletions(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 1c474c3b59..3f5b2afcea 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[]) /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { + bool hwp = strcmp(p_cpufreq->scaling_driver, XEN_HWP_DRIVER_NAME) == 0; int i; printf("cpu id : %d\n", cpuid); @@ -720,49 +721,57 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf(" %d", p_cpufreq->affected_cpus[i]); printf("\n"); - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->cpuinfo_max_freq, - p_cpufreq->cpuinfo_min_freq, - p_cpufreq->cpuinfo_cur_freq); + if ( hwp ) + printf("cpuinfo frequency : base [%"PRIu32"] max [%"PRIu32"]\n", + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_max_freq); + else + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->cpuinfo_max_freq, + p_cpufreq->cpuinfo_min_freq, + p_cpufreq->cpuinfo_cur_freq); printf("scaling_driver : %s\n", p_cpufreq->scaling_driver); - printf("scaling_avail_gov : %s\n", - p_cpufreq->scaling_available_governors); - - printf("current_governor : %s\n", p_cpufreq->u.s.scaling_governor); - if ( !strncmp(p_cpufreq->u.s.scaling_governor, - "userspace", CPUFREQ_NAME_LEN) ) - { - printf(" userspace specific :\n"); - printf(" scaling_setspeed : %u\n", - p_cpufreq->u.s.u.userspace.scaling_setspeed); - } - else if ( !strncmp(p_cpufreq->u.s.scaling_governor, - "ondemand", CPUFREQ_NAME_LEN) ) + if ( !hwp ) { - printf(" ondemand specific :\n"); - printf(" sampling_rate : max [%u] min [%u] cur [%u]\n", - p_cpufreq->u.s.u.ondemand.sampling_rate_max, - p_cpufreq->u.s.u.ondemand.sampling_rate_min, - p_cpufreq->u.s.u.ondemand.sampling_rate); - printf(" up_threshold : %u\n", - p_cpufreq->u.s.u.ondemand.up_threshold); - } + printf("scaling_avail_gov : %s\n", + p_cpufreq->scaling_available_governors); - printf("scaling_avail_freq :"); - for ( i = 0; i < p_cpufreq->freq_num; i++ ) - if ( p_cpufreq->scaling_available_frequencies[i] == - p_cpufreq->u.s.scaling_cur_freq ) - printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); - else - printf(" %d", p_cpufreq->scaling_available_frequencies[i]); - printf("\n"); + printf("current_governor : %s\n", p_cpufreq->u.s.scaling_governor); + if ( !strncmp(p_cpufreq->u.s.scaling_governor, + "userspace", CPUFREQ_NAME_LEN) ) + { + printf(" userspace specific :\n"); + printf(" scaling_setspeed : %u\n", + p_cpufreq->u.s.u.userspace.scaling_setspeed); + } + else if ( !strncmp(p_cpufreq->u.s.scaling_governor, + "ondemand", CPUFREQ_NAME_LEN) ) + { + printf(" ondemand specific :\n"); + printf(" sampling_rate : max [%u] min [%u] cur [%u]\n", + p_cpufreq->u.s.u.ondemand.sampling_rate_max, + p_cpufreq->u.s.u.ondemand.sampling_rate_min, + p_cpufreq->u.s.u.ondemand.sampling_rate); + printf(" up_threshold : %u\n", + p_cpufreq->u.s.u.ondemand.up_threshold); + } + + printf("scaling_avail_freq :"); + for ( i = 0; i < p_cpufreq->freq_num; i++ ) + if ( p_cpufreq->scaling_available_frequencies[i] == + p_cpufreq->u.s.scaling_cur_freq ) + printf(" *%d", p_cpufreq->scaling_available_frequencies[i]); + else + printf(" %d", p_cpufreq->scaling_available_frequencies[i]); + printf("\n"); - printf("scaling frequency : max [%u] min [%u] cur [%u]\n", - p_cpufreq->u.s.scaling_max_freq, - p_cpufreq->u.s.scaling_min_freq, - p_cpufreq->u.s.scaling_cur_freq); + printf("scaling frequency : max [%u] min [%u] cur [%u]\n", + p_cpufreq->u.s.scaling_max_freq, + p_cpufreq->u.s.scaling_min_freq, + p_cpufreq->u.s.scaling_cur_freq); + } printf("turbo mode : %s\n", p_cpufreq->turbo_enabled ? "enabled" : "disabled or n/a"); -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578803.906546 (Exim 4.92) (envelope-from ) id 1qT5L0-0007r1-16; Mon, 07 Aug 2023 18:52:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578803.906546; Mon, 07 Aug 2023 18:52:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Kz-0007qs-Sh; Mon, 07 Aug 2023 18:52:17 +0000 Received: by outflank-mailman (input) for mailman id 578803; Mon, 07 Aug 2023 18:52:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Ky-0004GT-PX for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:16 +0000 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [2607:f8b0:4864:20::e2e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85d3ef1f-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:52:14 +0200 (CEST) Received: by mail-vs1-xe2e.google.com with SMTP id ada2fe7eead31-44768737671so1822833137.2 for ; Mon, 07 Aug 2023 11:52:14 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85d3ef1f-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434333; x=1692039133; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ot86e+1Z3pJ5J+fUBDr3w7JqY5k3+M+3EC/DXMV0EvM=; b=HtIYy/U7KTLyuJuV0H1vcXedshvJr13+x/HNwupdbTBHCpML8gX3OMHFXsIW/PTtS/ 71r8eyohhbhfXtkjpSWuM/rD3Uu6x7NmudzsmRffUMne9cLnWypBbo7EaZ9mihPPYiql qS/hInCcESI4Z+zaTubDyaXedBmKwvxVLbSim0ez5TjvaA/5iWj+XtZIds9ojLbSlx/a TF4+Ck9On7KABj7jHECJPYBnF9oKdqcR+/p6xadqJkjEh9GU7yhIWA7r2YifxKRpO0Y2 Css++JFyxQdFJ2d5EPWOSt7bEv/5kNW/RaBraKWVh7LvKigTy2iocUuUykhUxhUjl1KK VCag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434333; x=1692039133; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ot86e+1Z3pJ5J+fUBDr3w7JqY5k3+M+3EC/DXMV0EvM=; b=R9PE7IyGo0MfcOUGlKvXG5M2DoN+Lf49Z2U2D7oJlM5E1Kn+niS/4jbCUoJRnBo4iD ClRDpkcWp3QvGq4QTJOPIqLSshM2cGvh6s33LQZnb3MiI7tebIUtvAEHiXMkKW/j7PKc mbNpToqi0uKkU/+fdcCWEQn+lQg1JEaBY+0IPw/wOIwju1N3eP6Udwg+0aqjlSiWseqO orMUhTdgc+Y15Eo44tpKsmfEZZQIo2ajCKq6whCe/G2TmV3NliGIvajhJLJXYX2veUxW kv91lHOFeTaTSYfmcosNY+EV2Y5ajNVW9C9cn+pQQ6vttQ3sw9MffBD/voUpuejeEn+z MnIA== X-Gm-Message-State: AOJu0YyPgV6Hj3j9OfDfMNctKfv6P04WzPdCqpNUc5kTS0rYAxn7tnDK xo7Wwq6jvGlvnoe3HZmfJM/kfF0kTqI= X-Google-Smtp-Source: AGHT+IFlZmrC0z7Z7KAEa8M2t7i5Eg40Dh/sDSINoUdzFJZ/87yNrSOiWDPU3XaDWRSaoRzdkMr+Qw== X-Received: by 2002:a67:f619:0:b0:443:7e93:641f with SMTP id k25-20020a67f619000000b004437e93641fmr4748864vso.9.1691434332699; Mon, 07 Aug 2023 11:52:12 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 09/15] cpufreq: Export HWP parameters to userspace as CPPC Date: Mon, 7 Aug 2023 14:51:13 -0400 Message-ID: <20230807185119.98333-10-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend xen_get_cpufreq_para to return hwp parameters. HWP is an implementation of ACPI CPPC (Collaborative Processor Performance Control). Use the CPPC name since that might be useful in the future for AMD P-state. We need the features bitmask to indicate fields supported by the actual hardware - this only applies to activity window for the time being. The HWP most_efficient is mapped to CPPC lowest_nonlinear, and guaranteed is mapped to nominal. CPPC has a guaranteed that is optional while nominal is required. ACPI spec says "If this register is not implemented, OSPM assumes guaranteed performance is always equal to nominal performance." Signed-off-by: Jason Andryuk Acked-by: Jan Beulich --- v2: Style fixes Don't bump XEN_SYSCTL_INTERFACE_VERSION Drop cpufreq.h comment divider Expand xen_hwp_para comment Add HWP activity window mantissa/exponent defines Handle union rename Add const to get_hwp_para Remove hw_ prefix from xen_hwp_para members Use XEN_HWP_GOVERNOR Use per_cpu for hwp_drv_data v4: Fixup for opt_cpufreq_hwp/hdc removal get_hwp_para() takes cpu as arg XEN_ prefix HWP_ACT_WINDOW_* Drop HWP_ACT_WINDOW_EXPONENT_SHIFT - shift MASK Remove Energy Bias (0-15) EPP fallback Rename xen_hwp_para to xen_cppc_para s/hwp/cppc/ Use scaling driver to switch output v5: Use XEN_HWP_DRIVER_NAME Use cpufreq.h for declarations Fixup some comments Drop const from unsigned int cpu Drop some unnecessary { } Use strncmp Switch sizeof(char) to sizeof(*scaling_available_governors) Reindent copy_to_guest call Add "HWP: " prefix to sysctl comments for cppc->hwp mapping v6: Drop commit message uint8_t paragraph sysctl.h s/They/They're/ Fix indent and add parens for read_scaling_available_governors() args Add Jan's Ack --- xen/arch/x86/acpi/cpufreq/hwp.c | 23 ++++++++++ xen/drivers/acpi/pmstat.c | 74 ++++++++++++++++-------------- xen/include/acpi/cpufreq/cpufreq.h | 2 + xen/include/public/sysctl.h | 56 ++++++++++++++++++++++ 4 files changed, 121 insertions(+), 34 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index 9be622f492..92fa01b8ea 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -519,6 +519,29 @@ static const struct cpufreq_driver __initconstrel hwp_cpufreq_driver = .update = hwp_cpufreq_update, }; +int get_hwp_para(unsigned int cpu, + struct xen_cppc_para *cppc_para) +{ + const struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + + if ( data == NULL ) + return -ENODATA; + + cppc_para->features = + (feature_hwp_activity_window ? XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW : 0); + cppc_para->lowest = data->hw.lowest; + cppc_para->lowest_nonlinear = data->hw.most_efficient; + cppc_para->nominal = data->hw.guaranteed; + cppc_para->highest = data->hw.highest; + cppc_para->minimum = data->minimum; + cppc_para->maximum = data->maximum; + cppc_para->desired = data->desired; + cppc_para->energy_perf = data->energy_perf; + cppc_para->activity_window = data->activity_window; + + return 0; +} + int __init hwp_register_driver(void) { int ret; diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index d67d99e62f..e4e2df94a7 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -251,46 +251,52 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op) else strlcpy(op->u.get_para.scaling_driver, "Unknown", CPUFREQ_NAME_LEN); - if ( !(scaling_available_governors = - xzalloc_array(char, gov_num * CPUFREQ_NAME_LEN)) ) - return -ENOMEM; - if ( (ret = read_scaling_available_governors(scaling_available_governors, - gov_num * CPUFREQ_NAME_LEN * sizeof(char))) ) + if ( !strncmp(op->u.get_para.scaling_driver, XEN_HWP_DRIVER_NAME, + CPUFREQ_NAME_LEN) ) + ret = get_hwp_para(policy->cpu, &op->u.get_para.u.cppc_para); + else { + if ( !(scaling_available_governors = + xzalloc_array(char, gov_num * CPUFREQ_NAME_LEN)) ) + return -ENOMEM; + if ( (ret = read_scaling_available_governors( + scaling_available_governors, + (gov_num * CPUFREQ_NAME_LEN * + sizeof(*scaling_available_governors)))) ) + { + xfree(scaling_available_governors); + return ret; + } + ret = copy_to_guest(op->u.get_para.scaling_available_governors, + scaling_available_governors, + gov_num * CPUFREQ_NAME_LEN); xfree(scaling_available_governors); - return ret; - } - ret = copy_to_guest(op->u.get_para.scaling_available_governors, - scaling_available_governors, gov_num * CPUFREQ_NAME_LEN); - xfree(scaling_available_governors); - if ( ret ) - return ret; + if ( ret ) + return ret; - op->u.get_para.u.s.scaling_cur_freq = policy->cur; - op->u.get_para.u.s.scaling_max_freq = policy->max; - op->u.get_para.u.s.scaling_min_freq = policy->min; + op->u.get_para.u.s.scaling_cur_freq = policy->cur; + op->u.get_para.u.s.scaling_max_freq = policy->max; + op->u.get_para.u.s.scaling_min_freq = policy->min; - if ( policy->governor->name[0] ) - strlcpy(op->u.get_para.u.s.scaling_governor, - policy->governor->name, CPUFREQ_NAME_LEN); - else - strlcpy(op->u.get_para.u.s.scaling_governor, "Unknown", CPUFREQ_NAME_LEN); + if ( policy->governor->name[0] ) + strlcpy(op->u.get_para.u.s.scaling_governor, + policy->governor->name, CPUFREQ_NAME_LEN); + else + strlcpy(op->u.get_para.u.s.scaling_governor, "Unknown", + CPUFREQ_NAME_LEN); - /* governor specific para */ - if ( !strncasecmp(op->u.get_para.u.s.scaling_governor, - "userspace", CPUFREQ_NAME_LEN) ) - { - op->u.get_para.u.s.u.userspace.scaling_setspeed = policy->cur; - } + /* governor specific para */ + if ( !strncasecmp(op->u.get_para.u.s.scaling_governor, + "userspace", CPUFREQ_NAME_LEN) ) + op->u.get_para.u.s.u.userspace.scaling_setspeed = policy->cur; - if ( !strncasecmp(op->u.get_para.u.s.scaling_governor, - "ondemand", CPUFREQ_NAME_LEN) ) - { - ret = get_cpufreq_ondemand_para( - &op->u.get_para.u.s.u.ondemand.sampling_rate_max, - &op->u.get_para.u.s.u.ondemand.sampling_rate_min, - &op->u.get_para.u.s.u.ondemand.sampling_rate, - &op->u.get_para.u.s.u.ondemand.up_threshold); + if ( !strncasecmp(op->u.get_para.u.s.scaling_governor, + "ondemand", CPUFREQ_NAME_LEN) ) + ret = get_cpufreq_ondemand_para( + &op->u.get_para.u.s.u.ondemand.sampling_rate_max, + &op->u.get_para.u.s.u.ondemand.sampling_rate_min, + &op->u.get_para.u.s.u.ondemand.sampling_rate, + &op->u.get_para.u.s.u.ondemand.up_threshold); } return ret; diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index 6737798e25..f90e9d3a6c 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -255,5 +255,7 @@ void intel_feature_detect(struct cpufreq_policy *policy); int hwp_cmdline_parse(const char *s, const char *e); int hwp_register_driver(void); bool hwp_active(void); +int get_hwp_para(unsigned int cpu, + struct xen_cppc_para *cppc_para); #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 5a30b16fcf..cf27f8f2f9 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -296,6 +296,61 @@ struct xen_ondemand { uint32_t up_threshold; }; +struct xen_cppc_para { + /* OUT */ + /* activity_window supported if set */ +#define XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW (1 << 0) + uint32_t features; /* bit flags for features */ + /* + * See Intel SDM: HWP Performance Range and Dynamic Capabilities + * + * These four are 0-255 hardware-provided values. They're "continuous, + * abstract unit-less, performance" values. Smaller numbers are slower + * and larger ones are faster. + */ + uint32_t lowest; + uint32_t lowest_nonlinear; /* HWP: most_efficient */ + uint32_t nominal; /* HWP: guaranteed */ + uint32_t highest; + /* + * See Intel SDM: IA32_HWP_REQUEST MSR (Address: 774H Logical Processor + * Scope) + * + * These are all hints, and the processor may deviate outside of them. + * Values below are 0-255. + * + * minimum and maximum can be set to the above hardware values to constrain + * operation. The full range 0-255 is accepted and will be clipped by + * hardware. + */ + uint32_t minimum; + uint32_t maximum; + /* + * An explicit performance hint, disabling hardware selection. + * 0 lets the hardware decide. + */ + uint32_t desired; + /* + * Hint to hardware for energy/performance preference. + * 0: Performance + * 128: Balance (Default) + * 255: Powersaving + */ + uint32_t energy_perf; + /* + * Activity Window is a moving history window for the processor's operation + * calculations, controlling responsiveness. Measured in microseconds + * encoded as: + * + * bits 6:0 - 7bit mantissa + * bits 9:7 - 3bit base-10 exponent + * btis 15:10 - Unused - must be 0 + */ +#define XEN_CPPC_ACT_WINDOW_MANTISSA_MASK 0x07f +#define XEN_CPPC_ACT_WINDOW_EXPONENT_MASK 0x380 + uint32_t activity_window; +}; + #define XEN_HWP_DRIVER_NAME "hwp" /* @@ -333,6 +388,7 @@ struct xen_get_cpufreq_para { struct xen_ondemand ondemand; } u; } s; + struct xen_cppc_para cppc_para; } u; int32_t turbo_enabled; -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578805.906556 (Exim 4.92) (envelope-from ) id 1qT5L1-0008Ar-Ee; Mon, 07 Aug 2023 18:52:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578805.906556; Mon, 07 Aug 2023 18:52:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5L1-0008Ae-Bn; Mon, 07 Aug 2023 18:52:19 +0000 Received: by outflank-mailman (input) for mailman id 578805; Mon, 07 Aug 2023 18:52:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5L0-0004GT-Pg for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:18 +0000 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [2607:f8b0:4864:20::f31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 873a5ef7-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:52:16 +0200 (CEST) Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-63d2b7d77bfso33900716d6.3 for ; Mon, 07 Aug 2023 11:52:16 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 873a5ef7-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434335; x=1692039135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8DT7oP40QgonifT7RMQUN+ralNpmx0+TMvzxcNwj95c=; b=o79SYks5IRvTS4g7YFj3Lu/26R982JYey+le3GNqqQ9vr75f+fceIelAaAy0n1d36i rK/yTGhB7hJSpPR3VQxG/o3k9fFPuc1wQmpjhXNnZ09CsNsAPu7VpGvhoT96iPlhvZ3z FMX9BATYxLRLpjtHVyRSkl9cGWiaitofv5EyDzOpSC/1XjZUDlG9kRDl/TGJK150lJA0 7OEvIYAwZAvLXkOFMxd/6vtr6UP9lcwzqCbqo3YoeD3EFRswCQYfnock849n2/+dgVb9 7N51deTZQNkjCEV62PwG5owEBvj/y6aXb/ExKR7SMkvYFGQ4YpDXMFtnOhejB0+ne+Pr 3PAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434335; x=1692039135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8DT7oP40QgonifT7RMQUN+ralNpmx0+TMvzxcNwj95c=; b=fYANuRHKG/ZBSL1w6D3EZxupuKJl4Vo9Oq1ppvBb6X8cwplzHvdvZW7eyXdUCfdhES eFJc976KPP01dsFzE4YINs27jMEkU497VfDzI0hCC0VWPpzEQ1t/IwfpSHpO7rgOCsg1 ap5as4p3XJpe9uDkf2lEFHPJ5x8G3+74ZRsVBo1c10DhobLgPbvWNwYzz4aJNPzLTjOk roZA+4EYG83V2Ld35ejyvzgZoY//Ugfk6VDF1+dF9TEvDcJtYtTXUoc7R8ngsBFrMnEh j7WC6RQPwEHSucX1Uk9SGbiqtqi2Z32JD7bE4Eno9gRwqQt/LcDdkJ5787JYlcyltmZu jTTw== X-Gm-Message-State: AOJu0YyVQojfsuuT/oCOQyAA91swqX84y9I2RHIbHYAttyzcmZcwgHau U6RQKWzcVCw3kDYljYUD0/XyhGVIcJM= X-Google-Smtp-Source: AGHT+IH6T9fI4HBdZOk6EGgyAMl2tDC+osINgoctgIjiNWPu28mxxHWGK9Mo3xSHhjGMkqPBMVY6yw== X-Received: by 2002:a0c:e549:0:b0:63d:4a9b:b29f with SMTP id n9-20020a0ce549000000b0063d4a9bb29fmr10472878qvm.65.1691434335348; Mon, 07 Aug 2023 11:52:15 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v8 10/15] libxc: Include cppc_para in definitions Date: Mon, 7 Aug 2023 14:51:14 -0400 Message-ID: <20230807185119.98333-11-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Expose the cppc_para fields through libxc. Signed-off-by: Jason Andryuk Acked-by: Anthony PERARD --- v4: Rename hwp to cppc Add Anthony's Ack --- tools/include/xenctrl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index de03cfb117..5824394125 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1909,6 +1909,7 @@ int xc_smt_disable(xc_interface *xch); */ typedef struct xen_userspace xc_userspace_t; typedef struct xen_ondemand xc_ondemand_t; +typedef struct xen_cppc_para xc_cppc_para_t; struct xc_get_cpufreq_para { /* IN/OUT variable */ @@ -1940,6 +1941,7 @@ struct xc_get_cpufreq_para { xc_ondemand_t ondemand; } u; } s; + xc_cppc_para_t cppc_para; } u; int32_t turbo_enabled; -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578806.906566 (Exim 4.92) (envelope-from ) id 1qT5L4-0000IT-PV; Mon, 07 Aug 2023 18:52:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578806.906566; Mon, 07 Aug 2023 18:52:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5L4-0000Hw-LH; Mon, 07 Aug 2023 18:52:22 +0000 Received: by outflank-mailman (input) for mailman id 578806; Mon, 07 Aug 2023 18:52:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5L3-0004lg-Fp for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:21 +0000 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [2607:f8b0:4864:20::c30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89533fb3-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:52:20 +0200 (CEST) Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-56ca4d7079aso3310667eaf.0 for ; Mon, 07 Aug 2023 11:52:20 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89533fb3-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434339; x=1692039139; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u8YY0cMbSt93RGcC2b1IS+Yfu6uCEeREtdnIWAGkVWs=; b=GYWW5JX4pXnd3+DLhH12t6E5X7ni1FxzUuRMa1pwAj58O14rcveuPnkf8ddsYil1bg /W7kjcE1lJFd1OexBkUESi9KAaguNkDuL9n7WJ0Qj96karMvJ9LsBCvWGl6E5BhqQSTs g/IbyLBh1RC10mAfYXllHqhvKZOGpSlV10BrHRgh3uwo+YwDsN564CHxhD9u+1w/IZ/L qHVqnZaukjwds/uomKxmmITyBQuPEgyuuDm7mXOieVRIGiS8PWZcSJf1v6wv32CTcfHg /Ts3HpaKR8PNoDtOZd0mxvRj4U+xDPX1mI7ZllF8j0EimHiJjelyBL9Klm7GKPT8WBwA wMzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434339; x=1692039139; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u8YY0cMbSt93RGcC2b1IS+Yfu6uCEeREtdnIWAGkVWs=; b=MxYWnl1oEYYaSFsh8a595kPrgRf5/fm6a4kYR8O5OXcbx/dpwt39eBuY32Ce/3v9Pq GMVCH8BDSKRompoDOhcHWfMdaZlONa6xQX/GjpyHyeF4ZUztE22qDyk/YxtqJnE4hzB6 o4kSCzlJIWyDFpMc3XMz1Hry8U/nkIXxPECVhjwqtduYe4UaDmM04hVQwP0qm6I6J8Mg TaJSn5CspInEOIad3/q7KVPtrV3fysZ2DCQAP5xhTrUI5Fu0dIS3AF+2D5uexG6iHD3K an/4DPzhwFfhJ4OuETFun5T+kiOvuHoqbs2/F8nO7HxcETRK8tjKqggha0tfGp7qNc6h PTWA== X-Gm-Message-State: AOJu0Yzu40o2i6lxsMYjX3xjIbaewr/TLnpXwGeF9I4A0fHHdMo1f4vK tQKtYLg8nxELO77EvB1m2DARTxwXDzk= X-Google-Smtp-Source: AGHT+IEgaCDlSduv/RvPBK6XMI+y0QAxWUnpQ54azRZXBg+BliJoQMDaz8dLyZ2DSoZcqwCXAbZbdQ== X-Received: by 2002:a05:6358:4285:b0:134:eed0:3bc5 with SMTP id s5-20020a056358428500b00134eed03bc5mr7203855rwc.9.1691434338972; Mon, 07 Aug 2023 11:52:18 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Jan Beulich Subject: [PATCH v8 11/15] xenpm: Print HWP/CPPC parameters Date: Mon, 7 Aug 2023 14:51:15 -0400 Message-ID: <20230807185119.98333-12-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Print HWP-specific parameters. Some are always present, but others depend on hardware support. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v2: Style fixes Declare i outside loop Replace repearted hardware/configured limits with spaces Fixup for hw_ removal Use XEN_HWP_GOVERNOR Use HWP_ACT_WINDOW_EXPONENT_* Remove energy_perf hw autonomous - 0 doesn't mean autonomous v4: Return activity_window from calculate_hwp_activity_window Use blanks instead of _ in output Use MASK_EXTR Check XEN_HWP_DRIVER name since governor is no longer returned s/hwp/cppc v5: Add Jan's Reviewed-by v8: Switch from "if ( !hwp )" to "if ( hwp )" and re-org code. Use %PRIu32 instead of %u - this lengthens some strings past 80 chars --- tools/misc/xenpm.c | 68 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 67 insertions(+), 1 deletion(-) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 3f5b2afcea..688529b59d 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -708,6 +708,46 @@ void start_gather_func(int argc, char *argv[]) pause(); } +static unsigned int calculate_activity_window(const xc_cppc_para_t *cppc, + const char **units) +{ + unsigned int mantissa = MASK_EXTR(cppc->activity_window, + XEN_CPPC_ACT_WINDOW_MANTISSA_MASK); + unsigned int exponent = MASK_EXTR(cppc->activity_window, + XEN_CPPC_ACT_WINDOW_EXPONENT_MASK); + unsigned int multiplier = 1; + unsigned int i; + + /* + * SDM only states a 0 register is hardware selected, and doesn't mention + * a 0 mantissa with a non-0 exponent. Only special case a 0 register. + */ + if ( cppc->activity_window == 0 ) + { + *units = "hardware selected"; + + return 0; + } + + if ( exponent >= 6 ) + { + *units = "s"; + exponent -= 6; + } + else if ( exponent >= 3 ) + { + *units = "ms"; + exponent -= 3; + } + else + *units = "us"; + + for ( i = 0; i < exponent; i++ ) + multiplier *= 10; + + return mantissa * multiplier; +} + /* print out parameters about cpu frequency */ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) { @@ -733,7 +773,33 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq) printf("scaling_driver : %s\n", p_cpufreq->scaling_driver); - if ( !hwp ) + if ( hwp ) + { + const xc_cppc_para_t *cppc = &p_cpufreq->u.cppc_para; + + printf("cppc variables :\n"); + printf(" hardware limits : lowest [%"PRIu32"] lowest nonlinear [%"PRIu32"]\n", + cppc->lowest, cppc->lowest_nonlinear); + printf(" : nominal [%"PRIu32"] highest [%"PRIu32"]\n", + cppc->nominal, cppc->highest); + printf(" configured limits : min [%"PRIu32"] max [%"PRIu32"] energy perf [%"PRIu32"]\n", + cppc->minimum, cppc->maximum, cppc->energy_perf); + + if ( cppc->features & XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW ) + { + unsigned int activity_window; + const char *units; + + activity_window = calculate_activity_window(cppc, &units); + printf(" : activity_window [%"PRIu32" %s]\n", + activity_window, units); + } + + printf(" : desired [%"PRIu32"%s]\n", + cppc->desired, + cppc->desired ? "" : " hw autonomous"); + } + else { printf("scaling_avail_gov : %s\n", p_cpufreq->scaling_available_governors); -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:52:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:52:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578812.906576 (Exim 4.92) (envelope-from ) id 1qT5LE-0001PL-21; Mon, 07 Aug 2023 18:52:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578812.906576; Mon, 07 Aug 2023 18:52:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5LD-0001PC-UU; Mon, 07 Aug 2023 18:52:31 +0000 Received: by outflank-mailman (input) for mailman id 578812; Mon, 07 Aug 2023 18:52:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5LC-0004lg-Nm for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:30 +0000 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [2607:f8b0:4864:20::730]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8eea7ef2-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:52:29 +0200 (CEST) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-76cdf055c64so417800685a.3 for ; Mon, 07 Aug 2023 11:52:29 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8eea7ef2-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434348; x=1692039148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vy6l55+rICbbuCBbADGaq7cX5z20EMNlyiZQ4cOI23w=; b=gnpUvo20i1TFYP99cadluOYvaxMNd5nY7wt+HzhGdEQfwgjkzX3n0qokafBMyYnkYC 2MI25xGHI4+fCYKeBHFj3UlNT3t5Kko9a5kEeZwIFE4U4W1QPMv+xE+7Ew216R5LcMbS D7PDx2N1CdPxYqDXi7rvurW4Du/FPSKCyedzSmbEThpKWHYpZUPo1nIKXX4ZnRfa/9W3 go+0A3zypevobOWqNSvY9PF2w/IKOBJD2IY9xq0Fe7UFGF+oYI4V1YbZWvMJ6cB+mmVa YgrWnwvgBzw526ibKsN67rnrt7Eqf4g0yPZdFwnq04Qr9qoCzvZTngxsdLxX7m8s3K1G 9X3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434348; x=1692039148; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vy6l55+rICbbuCBbADGaq7cX5z20EMNlyiZQ4cOI23w=; b=ALQR2l7wpzmW4XgQ1jycutQ0Aa4gnRUfa7YIxDRJXY2peU0o9GuYz2OAWOIq/w7nPP u7Kjaw3raoCTGgRvZO4YgRS2qc5CRAYuFcAFsonHQ0rcJw7W13wkMxNWIRUZLYssrKkr igrJ+7bCSARkQQYbaUpdPR6geDNxWGDNv34AhXYWHiE05t2ajui5Oqlz9clyPTn4IptD K90YdO46pfJCHHG2rYvpSC02EaG3427sm+0pKN2oGUa1fKb//MA/fOwa/54cGD8IzvyN iqu9Yq1hd3qLyqLP1zrqgChFJVqPAItajMoLckNuIOwsm89uIjWYIhx4ysE8LxQpsZxp WDaA== X-Gm-Message-State: AOJu0YxjjnQRT3uCot9p3gRk1A3cP4FacwHqunboYxPZV8PlpF8JnwaG OTdm3NpY3MoaQmkreGHDVg3NTCh5j3I= X-Google-Smtp-Source: AGHT+IE270NkHftGVb6Bp1YfXQBa81JVmCLv3fKo81pPhZF8LWIBeXSP4vpcU+9V5qDfro0337GIoA== X-Received: by 2002:a0c:e3c3:0:b0:636:47a5:4bc5 with SMTP id e3-20020a0ce3c3000000b0063647a54bc5mr9335668qvl.62.1691434348336; Mon, 07 Aug 2023 11:52:28 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Jan Beulich Subject: [PATCH v8 14/15] xenpm: Add set-cpufreq-cppc subcommand Date: Mon, 7 Aug 2023 14:51:18 -0400 Message-ID: <20230807185119.98333-15-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit set-cpufreq-cppc allows setting the Hardware P-State (HWP) parameters. It can be run on all or just a single cpu. There are presets of balance, powersave & performance. Those can be further tweaked by param:val arguments as explained in the usage description. Parameter names are just checked to the first 3 characters to shorten typing. Some options are hardware dependent, and ranges can be found in get-cpufreq-para. Signed-off-by: Jason Andryuk Acked-by: Jan Beulich Acked-by: Anthony PERARD --- v8: Add Anthony's Ack v5: Make i unsigned int Use local max_cpuid instead of max_cpu_nr Add Jan's Ack Check set_params and print a message if activity window wasn't set v4: Remove energy bias 0-15 & 7 references Use MASK_INSR Fixup { placement Drop extra case in parse_activity_window strcmp suffix Expand help text s/hwp/cppc/ Use isdigit() to check cpuid - otherwise run on all CPUs. v2: Compare provided parameter name and not just 3 characters. Use "-" in parameter names Remove hw_ Replace sscanf with strchr & strtoul. Remove toplevel error message with lower level ones. Help text s/127/128/ Help text mention truncation. Avoid some truncation rounding down by adding 5 before division. Help test mention default microseconds Also comment the limit check written to avoid overflow. --- tools/misc/xenpm.c | 244 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 244 insertions(+) diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index 688529b59d..d982482a3f 100644 --- a/tools/misc/xenpm.c +++ b/tools/misc/xenpm.c @@ -16,6 +16,8 @@ */ #define MAX_NR_CPU 512 +#include +#include #include #include #include @@ -67,6 +69,30 @@ void show_help(void) " set-max-cstate |'unlimited' [|'unlimited']\n" " set the C-State limitation ( >= 0) and\n" " optionally the C-sub-state limitation ( >= 0)\n" + " set-cpufreq-cppc [cpuid] [balance|performance|powersave] *\n" + " set Hardware P-State (HWP) parameters\n" + " on CPU or all if omitted.\n" + " optionally a preset of one of:\n" + " balance|performance|powersave\n" + " an optional list of param:val arguments\n" + " minimum:N (0-255)\n" + " maximum:N (0-255)\n" + " get-cpufreq-para lowest/highest\n" + " values are limits for\n" + " minumum/maximum.\n" + " desired:N (0-255)\n" + " set explicit performance target.\n" + " non-zero disables auto-HWP mode.\n" + " energy-perf:N (0-255)\n" + " energy/performance hint\n" + " lower - favor performance\n" + " higher - favor powersave\n" + " 128 - balance\n" + " act-window:N{,m,u}s range 1us-1270s\n" + " window for internal calculations.\n" + " units default to \"us\" if unspecified.\n" + " truncates un-representable values.\n" + " 0 lets the hardware decide.\n" " start [seconds] start collect Cx/Px statistics,\n" " output after CTRL-C or SIGINT or several seconds.\n" " enable-turbo-mode [cpuid] enable Turbo Mode for processors that support it.\n" @@ -1292,6 +1318,223 @@ void disable_turbo_mode(int argc, char *argv[]) errno, strerror(errno)); } +/* + * Parse activity_window:NNN{us,ms,s} and validate range. + * + * Activity window is a 7bit mantissa (0-127) with a 3bit exponent (0-7) base + * 10 in microseconds. So the range is 1 microsecond to 1270 seconds. A value + * of 0 lets the hardware autonomously select the window. + * + * Return 0 on success + * -1 on error + */ +static int parse_activity_window(xc_set_cppc_para_t *set_cppc, unsigned long u, + const char *suffix) +{ + unsigned int exponent = 0; + unsigned int multiplier = 1; + + if ( suffix && suffix[0] ) + { + if ( strcmp(suffix, "s") == 0 ) + { + multiplier = 1000 * 1000; + exponent = 6; + } + else if ( strcmp(suffix, "ms") == 0 ) + { + multiplier = 1000; + exponent = 3; + } + else if ( strcmp(suffix, "us") != 0 ) + { + fprintf(stderr, "invalid activity window units: \"%s\"\n", suffix); + + return -1; + } + } + + /* u * multipler > 1270 * 1000 * 1000 transformed to avoid overflow. */ + if ( u > 1270 * 1000 * 1000 / multiplier ) + { + fprintf(stderr, "activity window is too large\n"); + + return -1; + } + + /* looking for 7 bits of mantissa and 3 bits of exponent */ + while ( u > 127 ) + { + u += 5; /* Round up to mitigate truncation rounding down + e.g. 128 -> 120 vs 128 -> 130. */ + u /= 10; + exponent += 1; + } + + set_cppc->activity_window = + MASK_INSR(exponent, XEN_CPPC_ACT_WINDOW_EXPONENT_MASK) | + MASK_INSR(u, XEN_CPPC_ACT_WINDOW_MANTISSA_MASK); + set_cppc->set_params |= XEN_SYSCTL_CPPC_SET_ACT_WINDOW; + + return 0; +} + +static int parse_cppc_opts(xc_set_cppc_para_t *set_cppc, int *cpuid, + int argc, char *argv[]) +{ + int i = 0; + + if ( argc < 1 ) + { + fprintf(stderr, "Missing arguments\n"); + return -1; + } + + if ( isdigit(argv[i][0]) ) + { + if ( sscanf(argv[i], "%d", cpuid) != 1 || *cpuid < 0 ) + { + fprintf(stderr, "Could not parse cpuid \"%s\"\n", argv[i]); + return -1; + } + + i++; + } + + if ( i == argc ) + { + fprintf(stderr, "Missing arguments\n"); + return -1; + } + + if ( strcasecmp(argv[i], "powersave") == 0 ) + { + set_cppc->set_params = XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE; + i++; + } + else if ( strcasecmp(argv[i], "performance") == 0 ) + { + set_cppc->set_params = XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE; + i++; + } + else if ( strcasecmp(argv[i], "balance") == 0 ) + { + set_cppc->set_params = XEN_SYSCTL_CPPC_SET_PRESET_BALANCE; + i++; + } + + for ( ; i < argc; i++) + { + unsigned long val; + char *param = argv[i]; + char *value; + char *suffix; + int ret; + + value = strchr(param, ':'); + if ( value == NULL ) + { + fprintf(stderr, "\"%s\" is an invalid cppc parameter\n", argv[i]); + return -1; + } + + value[0] = '\0'; + value++; + + errno = 0; + val = strtoul(value, &suffix, 10); + if ( (errno && val == ULONG_MAX) || value == suffix ) + { + fprintf(stderr, "Could not parse number \"%s\"\n", value); + return -1; + } + + if ( strncasecmp(param, "act-window", strlen(param)) == 0 ) + { + ret = parse_activity_window(set_cppc, val, suffix); + if (ret) + return -1; + + continue; + } + + if ( val > 255 ) + { + fprintf(stderr, "\"%s\" value \"%lu\" is out of range\n", param, + val); + return -1; + } + + if ( suffix && suffix[0] ) + { + fprintf(stderr, "Suffix \"%s\" is invalid\n", suffix); + return -1; + } + + if ( strncasecmp(param, "minimum", MAX(2, strlen(param))) == 0 ) + { + set_cppc->minimum = val; + set_cppc->set_params |= XEN_SYSCTL_CPPC_SET_MINIMUM; + } + else if ( strncasecmp(param, "maximum", MAX(2, strlen(param))) == 0 ) + { + set_cppc->maximum = val; + set_cppc->set_params |= XEN_SYSCTL_CPPC_SET_MAXIMUM; + } + else if ( strncasecmp(param, "desired", strlen(param)) == 0 ) + { + set_cppc->desired = val; + set_cppc->set_params |= XEN_SYSCTL_CPPC_SET_DESIRED; + } + else if ( strncasecmp(param, "energy-perf", strlen(param)) == 0 ) + { + set_cppc->energy_perf = val; + set_cppc->set_params |= XEN_SYSCTL_CPPC_SET_ENERGY_PERF; + } + else + { + fprintf(stderr, "\"%s\" is an invalid parameter\n", param); + return -1; + } + } + + if ( set_cppc->set_params == 0 ) + { + fprintf(stderr, "No parameters set in request\n"); + return -1; + } + + return 0; +} + +static void cppc_set_func(int argc, char *argv[]) +{ + xc_set_cppc_para_t set_cppc = {}; + unsigned int max_cpuid = max_cpu_nr; + int cpuid = -1; + unsigned int i = 0; + uint32_t set_params; + + if ( parse_cppc_opts(&set_cppc, &cpuid, argc, argv) ) + exit(EINVAL); + + if ( cpuid != -1 ) + { + i = cpuid; + max_cpuid = i + 1; + } + + set_params = set_cppc.set_params; + for ( ; i < max_cpuid; i++ ) { + if ( xc_set_cpufreq_cppc(xc_handle, i, &set_cppc) ) + fprintf(stderr, "[CPU%d] failed to set cppc params (%d - %s)\n", + i, errno, strerror(errno)); + } + + if ( (set_params ^ set_cppc.set_params) & XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) + printf("Activity window not supported and omitted\n"); +} + struct { const char *name; void (*function)(int argc, char *argv[]); @@ -1302,6 +1545,7 @@ struct { { "get-cpufreq-average", cpufreq_func }, { "start", start_gather_func }, { "get-cpufreq-para", cpufreq_para_func }, + { "set-cpufreq-cppc", cppc_set_func }, { "set-scaling-maxfreq", scaling_max_freq_func }, { "set-scaling-minfreq", scaling_min_freq_func }, { "set-scaling-governor", scaling_governor_func }, -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:56:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578832.906585 (Exim 4.92) (envelope-from ) id 1qT5P7-0003Gs-HR; Mon, 07 Aug 2023 18:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578832.906585; Mon, 07 Aug 2023 18:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5P7-0003Gl-Ec; Mon, 07 Aug 2023 18:56:33 +0000 Received: by outflank-mailman (input) for mailman id 578832; Mon, 07 Aug 2023 18:56:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5P5-0003Gf-PW for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:56:31 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e392714-3554-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:56:29 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-52327d63d7cso3398324a12.1 for ; Mon, 07 Aug 2023 11:56:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e392714-3554-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434589; x=1692039389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KBAYSkzLCeQU+N3yQ6UmmijTTdXBvq5RAPGQuvYAJVQ=; b=ekTJwcTqRdcvkgcDdCu6IOnar5ZQ6RuiIJYdMlC0ZzX2IyHpScUXS1KJzvrQ2cGVhl gRgO035HLBqJuKzRDeeoxxf6MLFynNmO6uE3cmB7bYTNvwMZEp8vBAIOWjJ2F9pB44+a hfAA/5tRM6Z1h2WqbxjlIOYhs27Jyc6fqn3xdkCbYvkDMmvhFV2vMRDtrzKmu8wvF/K4 mcv9Htx7fqVL8O4dqu39/5eEoTJXIqPAgZyWW18PsSl+Bh7/bWS5bp5decakJD5cOQ9d JNAPO+eUhwFv6w3+E+PieXoMfxI30pJU3F7XbVXXQ5SPbOX2TVfLzDjdnRpH/eGweBGO HFew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434589; x=1692039389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBAYSkzLCeQU+N3yQ6UmmijTTdXBvq5RAPGQuvYAJVQ=; b=Cg2n5rMk8FWb1372usG54fArWqYoNeweOx/DALopoMR/Y51N4fLjxIVqXNI8ZavM70 1WQzRJ2FqvCblMAw8cUDudhyk8ghz0of5WdA8dcN27YtMvstLSXXKywhh8m6yfu8klEG 0+4AabKNRQ3mWNbCOOrKnTOe4H2lVF0asPjzmQnTU6UiN3CTfNHaVBor3lIZPeLs4kf+ bL66V575YqsbJCbPuEg4cul3tq83BbLyeKsQAnaO15MfUjStpUY2JdvXCPpBgJjNwC8X KKcVNinXMIaqD5HB+IS7zlTlUH4X/NCaQ46zmqaxsypkI4Uq+ta2XUlP+8gUgQt3KToK VcjA== X-Gm-Message-State: AOJu0Ywsd/AS2frjiWvOCIZYhQ1YjJfzQW5p8y1H2XaClT82wMktioKE cqGtGpPrVmq0HKf3cinDXj19ViB7q+osLXrdsXI= X-Google-Smtp-Source: AGHT+IEDs0k32ZuSaGUJmr5IfF93yZ+0mHlW3Z95dk+4uC50gtq/HfOSUnJPgJNoYz9GjvhFF8AtKWRNqiT6cAkpQLU= X-Received: by 2002:aa7:d488:0:b0:522:1d47:2d81 with SMTP id b8-20020aa7d488000000b005221d472d81mr7813004edr.17.1691434588866; Mon, 07 Aug 2023 11:56:28 -0700 (PDT) MIME-Version: 1.0 References: <20230803203650.1474936-1-andrew.cooper3@citrix.com> <722dfba8-a768-55c1-29bb-2d8525282b4b@citrix.com> <464d71e4-9047-0461-afdc-8df8b8f569fb@suse.com> In-Reply-To: <464d71e4-9047-0461-afdc-8df8b8f569fb@suse.com> From: Jason Andryuk Date: Mon, 7 Aug 2023 14:56:17 -0400 Message-ID: Subject: Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , Daniel Smith , Christopher Clark , Xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 4, 2023 at 7:36=E2=80=AFAM Jan Beulich wrot= e: > > On 04.08.2023 11:29, Andrew Cooper wrote: > > On 04/08/2023 8:23 am, Jan Beulich wrote: > >> On 03.08.2023 22:36, Andrew Cooper wrote: > >>> The opensuse-tumbleweed build jobs currently fail with: > >>> > >>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: I= n function 'rsa_private': > >>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56= :7: error: the comparison will always evaluate as 'true' for the address of= 'p' will never be NULL [-Werror=3Daddress] > >>> 56 | if (!key->p || !key->q || !key->u) { > >>> | ^ > >>> In file included from /builds/xen-project/xen/stubdom/tpm_emulator-= x86_64/crypto/rsa.c:17: > >>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28= :12: note: 'p' declared here > >>> 28 | tpm_bn_t p; > >>> | ^ > >>> > >>> This is because all tpm_bn_t's are 1-element arrays (of either a GMP = or > >>> OpenSSL BIGNUM flavour). The author was probably meaning to do value= checks, > >>> but that's not what the code does. > >> Looking at the code, I'm not sure about this. There could as well have= been > >> the intention to allow pointers there, then permitting them to be left= at > >> NULL. Who knows where that code came from originally. The logic looks to be that if p, q, or u are not present, then perform a regular modular exponentiation. If they are available, then perform an optimized Chinese Remainder Theorem exponentiation. In that light, it's written as if pointers were expected. However, the code history doesn't show pointers for p/q/u. An RSA key can't have 0 for p/q/u, so value checks don't make sense. Hmmm, I suppose a 0 value could make sense to indicate uninitialization. tpm_rsa_import_key() and tpm_rsa_generate_key() set p, q, & u. tpm_rsa_copy_key() copies those over. So it should be okay to use this patch to just always use the CRT path. It would be safer to check for 0 though, I suppose. > > Do you agree that the patch is no function change, or are you saying > > that you think I got some of my analysis wrong? > > Oh, I'm sorry for the potentially ambiguous reply: I agree there's no fun= ctional > change. I'm merely not sure about your guessing of value checks being mea= nt. Agreed - no functional change. Reviewed-by: Jason Andryuk Disabling vtpm is also reasonable given the reasons Andrew outlined. Regards, Jason From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:57:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:57:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578854.906605 (Exim 4.92) (envelope-from ) id 1qT5Q1-00048o-AD; Mon, 07 Aug 2023 18:57:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578854.906605; Mon, 07 Aug 2023 18:57:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Q1-00048f-6q; Mon, 07 Aug 2023 18:57:29 +0000 Received: by outflank-mailman (input) for mailman id 578854; Mon, 07 Aug 2023 18:57:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5LA-0004GT-Qa for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:28 +0000 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [2607:f8b0:4864:20::c32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d4e026d-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:52:27 +0200 (CEST) Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-56d0d7300d9so3379268eaf.1 for ; Mon, 07 Aug 2023 11:52:27 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d4e026d-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434345; x=1692039145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8DQkeW1PaXja4KIHBd9qWOWyZUnQRLS9exqlWjIoM/A=; b=Z2lmti/Wer72P5ai8c80vOFC++zaGGpmeGQt/JShbpznCCh/DpVnKzoQu0RpvB7DiT o8UYN3JEP2SSVz+iWIYySnnruPKXAP4vsHf3Y2xelJkyyCchAoRgxoI14SGy6CIxAHxR aYIvyn95Bq/Ux4hAamu+qIkhBYsGyrRZoEwKGvQczYut5xBvn7XyQjRc6Qa9YaUxD1sA WXV0qqBKmTOZ4xxlBkmd5nASkUm5Id4F/F6RZ8xZM6NGok/KfanKxfIvu5TTTVQjcS6d wQNRgzB/VvdTQ/uO4pjAJ7CcPQ+LtL4uSfRNwfrH/r6rjKOLbu/HF9bYXSnAmp1juDpE IQqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434345; x=1692039145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8DQkeW1PaXja4KIHBd9qWOWyZUnQRLS9exqlWjIoM/A=; b=JGh+IY+28h806/n0svjTEShdashWFvLLIcVUbqWU3M3WviqF11LrCiRVgCFcRJNoCG vs+OrP1v2+23Fu7xtQCjSyaiu4PT0es7EZG6xOpXOyjRA8ZpuqTsSrf8FgoN62BhxEzi nevYPHawya7Y+o6orr7HOsMGBxFnxj5KS0HGw2UGGus47scstePodexGlUqn+U6ld2Gr t2XXR6XIHDsKz4WCYnQ5ISWQ6lLpn9mb08Cz/L6AMZpE//gJVvnbgL9jU6UkYORWp7wk Efxvt320CxEsjudbpXSZ2RHfqH3wZ3q5FRgtpDA0t0mgCCqpQlsRUK3LYdLkmZ5FllnL 9oGw== X-Gm-Message-State: AOJu0YzwQwD1m6l9p+Y/VyPPGQC8nJIYO9BLpNJu7mEJPEXJuYvuN0kK nRZy+QooVJv0WunEz0IZ1lE8eIzFniM= X-Google-Smtp-Source: AGHT+IHLRK6B7CKh9F5LEFpo5z6t/O2jdU4MY1VAnFsvimMK3dDFp/U6+2u8F5o7xaDA3yEoXXxK6w== X-Received: by 2002:a05:6358:99a6:b0:139:833c:53f8 with SMTP id j38-20020a05635899a600b00139833c53f8mr9052643rwb.24.1691434345322; Mon, 07 Aug 2023 11:52:25 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH v8 13/15] libxc: Add xc_set_cpufreq_cppc Date: Mon, 7 Aug 2023 14:51:17 -0400 Message-ID: <20230807185119.98333-14-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add xc_set_cpufreq_cppc to allow calling xen_systctl_pm_op SET_CPUFREQ_CPPC. Signed-off-by: Jason Andryuk Acked-by: Anthony PERARD --- v2: Mark xc_set_hwp_para_t const v4: s/hwp/cppc/ Add Anthony's Ack v5: Remove const and copy back result --- tools/include/xenctrl.h | 4 ++++ tools/libs/ctrl/xc_pm.c | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+) diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index 5824394125..12dca13b69 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -1947,11 +1947,15 @@ struct xc_get_cpufreq_para { int32_t turbo_enabled; }; +typedef struct xen_set_cppc_para xc_set_cppc_para_t; + int xc_get_cpufreq_para(xc_interface *xch, int cpuid, struct xc_get_cpufreq_para *user_para); int xc_set_cpufreq_gov(xc_interface *xch, int cpuid, char *govname); int xc_set_cpufreq_para(xc_interface *xch, int cpuid, int ctrl_type, int ctrl_value); +int xc_set_cpufreq_cppc(xc_interface *xch, int cpuid, + xc_set_cppc_para_t *set_cppc); int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq); int xc_set_sched_opt_smt(xc_interface *xch, uint32_t value); diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c index 3e969b841f..6157f4e3d4 100644 --- a/tools/libs/ctrl/xc_pm.c +++ b/tools/libs/ctrl/xc_pm.c @@ -368,6 +368,29 @@ int xc_set_cpufreq_para(xc_interface *xch, int cpuid, return xc_sysctl(xch, &sysctl); } +int xc_set_cpufreq_cppc(xc_interface *xch, int cpuid, + xc_set_cppc_para_t *set_cppc) +{ + DECLARE_SYSCTL; + int ret; + + if ( !xch ) + { + errno = EINVAL; + return -1; + } + sysctl.cmd = XEN_SYSCTL_pm_op; + sysctl.u.pm_op.cmd = SET_CPUFREQ_CPPC; + sysctl.u.pm_op.cpuid = cpuid; + sysctl.u.pm_op.u.set_cppc = *set_cppc; + + ret = xc_sysctl(xch, &sysctl); + + *set_cppc = sysctl.u.pm_op.u.set_cppc; + + return ret; +} + int xc_get_cpufreq_avgfreq(xc_interface *xch, int cpuid, int *avg_freq) { int ret = 0; -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:57:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:57:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578851.906596 (Exim 4.92) (envelope-from ) id 1qT5Py-0003rl-1g; Mon, 07 Aug 2023 18:57:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578851.906596; Mon, 07 Aug 2023 18:57:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Px-0003re-Ug; Mon, 07 Aug 2023 18:57:25 +0000 Received: by outflank-mailman (input) for mailman id 578851; Mon, 07 Aug 2023 18:57:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5L8-0004GT-NT for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:26 +0000 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [2607:f8b0:4864:20::f29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b6ba4ac-3553-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 20:52:23 +0200 (CEST) Received: by mail-qv1-xf29.google.com with SMTP id 6a1803df08f44-63cf7cce5fbso34440726d6.0 for ; Mon, 07 Aug 2023 11:52:23 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b6ba4ac-3553-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434342; x=1692039142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AOfN7Z9EVFLpJCkggYGDmqtmD+BO0lXy28fP8LpUWIs=; b=MiT8Aw+NG79O5MeG4oXEc4pSKAtjJwI8Nu69a04vUx48j5W1BdyxlNDr79683Vp+HR IXjUu8GoYlSl0vZFFUHw8YGdvVn8pr24sF5deCNZgy/KaU0dvdz1dJUoIq8+uvmZibLm GN33UrjmVbV8okClX7zSeAj/PGF8hHLc6UF+1WvyHMGAYjzjdT8xlMqClrbngtKrAxig siMzvNpiKt9HvV+7MmZ/ZhHTfZi6rBkQKK9oza9huO9dYmcM+6rPbjwFYQ9C/21C3cAl axqXCwEeif/qVJuqHBFXKVorarL36RtpZuODXMwV+ER+HlDWFsBmD1k6/4c1Nb95Z6uq Swcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434342; x=1692039142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AOfN7Z9EVFLpJCkggYGDmqtmD+BO0lXy28fP8LpUWIs=; b=S+V+azszrrEwO2rVMNUXAuXGwVMGHZm/lD4wpJ4qAsCgQmaOUXOXCudqOaAMNzZUHe Z5/NN6fzipFNepJ0583+p9Fs7gLrjT68y6k2vHLH1I7ITWYzwke3Ex0cBaRuMaupzWaC oCLSDjzcOmJ6+a6g+CZPP6bfI6sVk1dGG4xlj6gzTN+EcS4ALzZ2QpsI4F3nyOcwUi2e mPnea6dbXeWjXunR7tYZ6ZBySRD0zML0KgvwqTNRhvgqLbtz2Ab6d2Et4ii20JaSFXRN W+v1jC59m7ImGbailTINrSTNuae0a3JoPpW2i/eAntqUR79SWjqlg1QR/1GFj2KmUYQu hTDQ== X-Gm-Message-State: AOJu0YwXD3R08aYUbt6fUvsAktDxpWoGGOYxyAAQguH5EeHxBqkXsi50 1ZIW/niBfjFW/EwJXHIL+O1NA+V0VIM= X-Google-Smtp-Source: AGHT+IFjjVG/Vb02rgE6PdI73vVmx0JX8EBV/Oopw5OaqGQYQCXg/GCuq/s5EL06eGXNzza5MxwhRg== X-Received: by 2002:a05:6214:15cf:b0:632:207d:b834 with SMTP id p15-20020a05621415cf00b00632207db834mr9586248qvz.58.1691434342145; Mon, 07 Aug 2023 11:52:22 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v8 12/15] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op Date: Mon, 7 Aug 2023 14:51:16 -0400 Message-ID: <20230807185119.98333-13-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add SET_CPUFREQ_HWP xen_sysctl_pm_op to set HWP parameters. The sysctl supports setting multiple values simultaneously as indicated by the set_params bits. This allows atomically applying new HWP configuration via a single wrmsr. XEN_SYSCTL_HWP_SET_PRESET_BALANCE/PERFORMANCE/POWERSAVE provide three common presets. Setting them depends on hardware limits which the hypervisor is already caching. So using them allows skipping a hypercall to query the limits (lowest/highest) to then set those same values. The code is organized to allow a preset to be refined with additional parameters if desired. "most_efficient" and "guaranteed" could be additional presets in the future, but the are not added now. Those levels can change at runtime, but we don't have code in place to monitor and update for those events. Since activity window may not be supported by all hardware, omit writing it when not supported, and return that fact to userspace by updating set_params. CPPC parameter checking disallows setting reserved bytes and ensure values are only non-zero when the corresponding set_params bit is set. There is no range checking (0-255 is allowed) since hardware is documented to clip internally. Signed-off-by: Jason Andryuk Reviewed-by: Jan Beulich --- v7: Fix brace placement Add Jan's R-b v6: Add () around bit test Add U suffix to XEN_SYSCTL_ constants Change -EINVAL returns to -ENOENT/-EOPNOTSUPP Return success for no-op set_hwp_para() v5: Use cpufreq.h for include Add () around bit test Fix Configure typo Drop duplicated energy_perf comment Define XEN_SYSCTL_CPPC_ACT_WINDOW_MASK from *_MANTISSA_MASK and *_EXPONENT_MASK Re-order XEN_SYSCTL_CPPC_SET_* flags to match field and hardware order. Remove const from set_cppc param to update set_params Skip Activity Window if not supported by hardware and clear set_params Make parameter parsing consistent Add an exit path when there are no parameters to write. Expand the header file to cover the IN/OUT set_params. Remove the "desired" lowest/highest checking as hardware clips internally v4: Remove IA32_ENERGY_BIAS support Validate parameters don't exceed 255 Use CPPC/cppc name set_cppc_para() add const set_cppc_para() return hwp_cpufreq_target() Expand sysctl comments v3: Remove cpufreq_governor_internal from set_cpufreq_hwp v2: Update for naming anonymous union Drop hwp_err for invalid input in set_hwp_para() Drop uint16_t cast in XEN_SYSCTL_HWP_SET_PARAM_MASK Drop parens for HWP_SET_PRESET defines Reference activity_window format comment Place SET_CPUFREQ_HWP after SET_CPUFREQ_PARA Add {HWP,IA32}_ENERGY_PERF_MAX_{PERFORMANCE,POWERSAVE} defines Order defines before fields in sysctl.h Use XEN_HWP_GOVERNOR Use per_cpu for hwp_drv_data --- xen/arch/x86/acpi/cpufreq/hwp.c | 102 +++++++++++++++++++++++++++++ xen/drivers/acpi/pmstat.c | 17 +++++ xen/include/acpi/cpufreq/cpufreq.h | 2 + xen/include/public/sysctl.h | 64 ++++++++++++++++++ 4 files changed, 185 insertions(+) diff --git a/xen/arch/x86/acpi/cpufreq/hwp.c b/xen/arch/x86/acpi/cpufreq/hwp.c index 92fa01b8ea..620149243d 100644 --- a/xen/arch/x86/acpi/cpufreq/hwp.c +++ b/xen/arch/x86/acpi/cpufreq/hwp.c @@ -21,6 +21,10 @@ static bool __ro_after_init feature_hdc; static bool __ro_after_init opt_cpufreq_hdc = true; +#define HWP_ENERGY_PERF_MAX_PERFORMANCE 0 +#define HWP_ENERGY_PERF_BALANCE 0x80 +#define HWP_ENERGY_PERF_MAX_POWERSAVE 0xff + union hwp_request { struct @@ -542,6 +546,104 @@ int get_hwp_para(unsigned int cpu, return 0; } +int set_hwp_para(struct cpufreq_policy *policy, + struct xen_set_cppc_para *set_cppc) +{ + unsigned int cpu = policy->cpu; + struct hwp_drv_data *data = per_cpu(hwp_drv_data, cpu); + bool cleared_act_window = false; + + if ( data == NULL ) + return -ENOENT; + + /* Validate all parameters - Disallow reserved bits. */ + if ( set_cppc->minimum > 255 || + set_cppc->maximum > 255 || + set_cppc->desired > 255 || + set_cppc->energy_perf > 255 || + (set_cppc->set_params & ~XEN_SYSCTL_CPPC_SET_PARAM_MASK) || + (set_cppc->activity_window & ~XEN_SYSCTL_CPPC_ACT_WINDOW_MASK) ) + return -EINVAL; + + /* Only allow values if params bit is set. */ + if ( (!(set_cppc->set_params & XEN_SYSCTL_CPPC_SET_DESIRED) && + set_cppc->desired) || + (!(set_cppc->set_params & XEN_SYSCTL_CPPC_SET_MINIMUM) && + set_cppc->minimum) || + (!(set_cppc->set_params & XEN_SYSCTL_CPPC_SET_MAXIMUM) && + set_cppc->maximum) || + (!(set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ENERGY_PERF) && + set_cppc->energy_perf) || + (!(set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ACT_WINDOW) && + set_cppc->activity_window) ) + return -EINVAL; + + /* Clear out activity window if lacking HW supported. */ + if ( (set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ACT_WINDOW) && + !feature_hwp_activity_window ) + { + set_cppc->set_params &= ~XEN_SYSCTL_CPPC_SET_ACT_WINDOW; + cleared_act_window = true; + } + + /* Return if there is nothing to do. */ + if ( set_cppc->set_params == 0 ) + return 0; + + /* Apply presets */ + switch ( set_cppc->set_params & XEN_SYSCTL_CPPC_SET_PRESET_MASK ) + { + case XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE: + data->minimum = data->hw.lowest; + data->maximum = data->hw.lowest; + data->activity_window = 0; + data->energy_perf = HWP_ENERGY_PERF_MAX_POWERSAVE; + data->desired = 0; + break; + + case XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE: + data->minimum = data->hw.highest; + data->maximum = data->hw.highest; + data->activity_window = 0; + data->energy_perf = HWP_ENERGY_PERF_MAX_PERFORMANCE; + data->desired = 0; + break; + + case XEN_SYSCTL_CPPC_SET_PRESET_BALANCE: + data->minimum = data->hw.lowest; + data->maximum = data->hw.highest; + data->activity_window = 0; + data->energy_perf = HWP_ENERGY_PERF_BALANCE; + data->desired = 0; + break; + + case XEN_SYSCTL_CPPC_SET_PRESET_NONE: + break; + + default: + return -EINVAL; + } + + /* Further customize presets if needed */ + if ( set_cppc->set_params & XEN_SYSCTL_CPPC_SET_MINIMUM ) + data->minimum = set_cppc->minimum; + + if ( set_cppc->set_params & XEN_SYSCTL_CPPC_SET_MAXIMUM ) + data->maximum = set_cppc->maximum; + + if ( set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ENERGY_PERF ) + data->energy_perf = set_cppc->energy_perf; + + if ( set_cppc->set_params & XEN_SYSCTL_CPPC_SET_DESIRED ) + data->desired = set_cppc->desired; + + if ( set_cppc->set_params & XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) + data->activity_window = set_cppc->activity_window & + XEN_SYSCTL_CPPC_ACT_WINDOW_MASK; + + return hwp_cpufreq_target(policy, 0, 0); +} + int __init hwp_register_driver(void) { int ret; diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c index e4e2df94a7..85097d463c 100644 --- a/xen/drivers/acpi/pmstat.c +++ b/xen/drivers/acpi/pmstat.c @@ -400,6 +400,19 @@ static int set_cpufreq_para(struct xen_sysctl_pm_op *op) return ret; } +static int set_cpufreq_cppc(struct xen_sysctl_pm_op *op) +{ + struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_policy, op->cpuid); + + if ( !policy || !policy->governor ) + return -ENOENT; + + if ( !hwp_active() ) + return -EOPNOTSUPP; + + return set_hwp_para(policy, &op->u.set_cppc); +} + int do_pm_op(struct xen_sysctl_pm_op *op) { int ret = 0; @@ -472,6 +485,10 @@ int do_pm_op(struct xen_sysctl_pm_op *op) break; } + case SET_CPUFREQ_CPPC: + ret = set_cpufreq_cppc(op); + break; + case GET_CPUFREQ_AVGFREQ: { op->u.get_avgfreq = cpufreq_driver_getavg(op->cpuid, USR_GETAVG); diff --git a/xen/include/acpi/cpufreq/cpufreq.h b/xen/include/acpi/cpufreq/cpufreq.h index f90e9d3a6c..281e3f513d 100644 --- a/xen/include/acpi/cpufreq/cpufreq.h +++ b/xen/include/acpi/cpufreq/cpufreq.h @@ -257,5 +257,7 @@ int hwp_register_driver(void); bool hwp_active(void); int get_hwp_para(unsigned int cpu, struct xen_cppc_para *cppc_para); +int set_hwp_para(struct cpufreq_policy *policy, + struct xen_set_cppc_para *set_cppc); #endif /* __XEN_CPUFREQ_PM_H__ */ diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index cf27f8f2f9..3975050248 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -351,6 +351,68 @@ struct xen_cppc_para { uint32_t activity_window; }; +/* + * Set CPPC values. + * + * Configure the parameters for CPPC. Set bits in set_params control which + * values are applied. If a bit is not set in set_params, the field must be + * zero. + * + * For HWP specifically, values must be limited to 0-255 or within + * XEN_SYSCTL_CPPC_ACT_WINDOW_MASK for activity window. Set bits outside the + * range will be returned as -EINVAL. + * + * Activity Window may not be supported by the hardware. In that case, the + * returned set_params will clear XEN_SYSCTL_CPPC_SET_ACT_WINDOW to indicate + * that it was not applied - though the rest of the values will be applied. + * + * There are a set of presets along with individual fields. Presets are + * applied first, and then individual fields. This allows customizing + * a preset without having to specify every value. + * + * The preset options values are as follows: + * + * preset | minimum | maxium | energy_perf + * ------------+---------+---------+---------------- + * powersave | lowest | lowest | powersave (255) + * ------------+---------+---------+---------------- + * balance | lowest | highest | balance (128) + * ------------+---------+---------+---------------- + * performance | highest | highest | performance (0) + * + * desired and activity_window are set to 0, hardware selected. + */ +struct xen_set_cppc_para { +#define XEN_SYSCTL_CPPC_SET_MINIMUM (1U << 0) +#define XEN_SYSCTL_CPPC_SET_MAXIMUM (1U << 1) +#define XEN_SYSCTL_CPPC_SET_DESIRED (1U << 2) +#define XEN_SYSCTL_CPPC_SET_ENERGY_PERF (1U << 3) +#define XEN_SYSCTL_CPPC_SET_ACT_WINDOW (1U << 4) +#define XEN_SYSCTL_CPPC_SET_PRESET_MASK 0xf0000000U +#define XEN_SYSCTL_CPPC_SET_PRESET_NONE 0x00000000U +#define XEN_SYSCTL_CPPC_SET_PRESET_BALANCE 0x10000000U +#define XEN_SYSCTL_CPPC_SET_PRESET_POWERSAVE 0x20000000U +#define XEN_SYSCTL_CPPC_SET_PRESET_PERFORMANCE 0x30000000U +#define XEN_SYSCTL_CPPC_SET_PARAM_MASK \ + (XEN_SYSCTL_CPPC_SET_PRESET_MASK | \ + XEN_SYSCTL_CPPC_SET_MINIMUM | \ + XEN_SYSCTL_CPPC_SET_MAXIMUM | \ + XEN_SYSCTL_CPPC_SET_DESIRED | \ + XEN_SYSCTL_CPPC_SET_ENERGY_PERF | \ + XEN_SYSCTL_CPPC_SET_ACT_WINDOW ) + /* IN/OUT */ + uint32_t set_params; /* bitflags for valid values */ + /* See comments in struct xen_cppc_para. */ + /* IN */ + uint32_t minimum; + uint32_t maximum; + uint32_t desired; + uint32_t energy_perf; +#define XEN_SYSCTL_CPPC_ACT_WINDOW_MASK (XEN_CPPC_ACT_WINDOW_MANTISSA_MASK | \ + XEN_CPPC_ACT_WINDOW_EXPONENT_MASK) + uint32_t activity_window; +}; + #define XEN_HWP_DRIVER_NAME "hwp" /* @@ -418,6 +480,7 @@ struct xen_sysctl_pm_op { #define SET_CPUFREQ_GOV (CPUFREQ_PARA | 0x02) #define SET_CPUFREQ_PARA (CPUFREQ_PARA | 0x03) #define GET_CPUFREQ_AVGFREQ (CPUFREQ_PARA | 0x04) + #define SET_CPUFREQ_CPPC (CPUFREQ_PARA | 0x05) /* set/reset scheduler power saving option */ #define XEN_SYSCTL_pm_op_set_sched_opt_smt 0x21 @@ -444,6 +507,7 @@ struct xen_sysctl_pm_op { struct xen_get_cpufreq_para get_para; struct xen_set_cpufreq_gov set_gov; struct xen_set_cpufreq_para set_para; + struct xen_set_cppc_para set_cppc; uint64_aligned_t get_avgfreq; uint32_t set_sched_opt_smt; #define XEN_SYSCTL_CX_UNLIMITED 0xffffffffU -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 18:57:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 18:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578867.906616 (Exim 4.92) (envelope-from ) id 1qT5Q3-0004R3-Ii; Mon, 07 Aug 2023 18:57:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578867.906616; Mon, 07 Aug 2023 18:57:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5Q3-0004Qs-Er; Mon, 07 Aug 2023 18:57:31 +0000 Received: by outflank-mailman (input) for mailman id 578867; Mon, 07 Aug 2023 18:57:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5LH-0004lg-T8 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 18:52:35 +0000 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [2607:f8b0:4864:20::f2d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 90970bbb-3553-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 20:52:32 +0200 (CEST) Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-63d0f62705dso31217936d6.0 for ; Mon, 07 Aug 2023 11:52:32 -0700 (PDT) Received: from pm2-ws13.praxislan02.com (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com. [207.172.141.204]) by smtp.gmail.com with ESMTPSA id l3-20020a0ce503000000b00635fcd30ff9sm3077278qvm.40.2023.08.07.11.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 11:52:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90970bbb-3553-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691434351; x=1692039151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=th66OAkyXfCb+8rqcY7T1oi7fcMyAzOkt6nXPnMYefM=; b=U0SJXFmwB0QB3rzVbn18YtO4XaHbkLyqGMzTWNUlvx7WCmGcr9FcXhA4ZFd6qpPtzE C80gMNl5jXBBxFflxh3srBkXQIBe0oWgKbRXehv7ikL5aV2s4otKmk8fDbEillzSa2qj PK1Ah+xrGgEcGp5CzaF8z4VhEVva81qNj4pMRHuzTDG23UinMATTrPzg/rCnD7XJ+v/A p3AoK0eW/zRMhX+obmdScIdCMIFM+w31z3LCjyZye4QybbIDbcW2AjJ4d7hu/P9id7vx 0crKCoyjRvT5/bJ3CGv7U/z2qgn4YhEW51seSS//QZJwhcrVz3giwLp9lwWxdQNHp9OP 3IBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691434351; x=1692039151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=th66OAkyXfCb+8rqcY7T1oi7fcMyAzOkt6nXPnMYefM=; b=SaE4VYI/RLxi3ioqGPENhBA6vxxaxZufNV/41w71G2XVMxWIZmCQqe1VEWfOeWtM1X o4wds0YmEF2S2oNINC6N1MuUFK1ILj3M92h461kCFYfRGmQxMZeRSdYPf7rDraapoU3v mRF2dFyQvlL4f7ejgHwajGnPp7X1y9pv3a7qOX62yi28sBagZjwOcrCezEkKUUMSpl+2 nH3RgVSOxVqb6NsNywjecqqLyIWdMMvwdioXibrMwEYP11v3gufmxQ8/E2afN8GdtgJz CU23T1Kbe5haRqJnnWsXXdizVq58cpdRXntgCP9jy1qnhJN5zTCCTB+RX29DKNDXkEa/ xtZQ== X-Gm-Message-State: AOJu0YxSO42XTK2kMn0TwkDCDePSoXU3jgYqBHqfk57NoOrpLm/lD027 Rj7K7Gg1dVpibwfF038qt7mS9DS+RGU= X-Google-Smtp-Source: AGHT+IH5PcmbQONWX0ET0Fwui98yNSXOY56/kwYGUa5lf37rZkMDqWFNhdyH6inHc/5YenFSgksxIA== X-Received: by 2002:a0c:f24d:0:b0:635:dda5:bb88 with SMTP id z13-20020a0cf24d000000b00635dda5bb88mr9308623qvl.53.1691434351205; Mon, 07 Aug 2023 11:52:31 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Henry Wang , Community Manager Subject: [PATCH v8 15/15] CHANGELOG: Add Intel HWP entry Date: Mon, 7 Aug 2023 14:51:19 -0400 Message-ID: <20230807185119.98333-16-jandryuk@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807185119.98333-1-jandryuk@gmail.com> References: <20230807185119.98333-1-jandryuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Signed-off-by: Jason Andryuk Acked-by: Henry Wang --- v3: Position under existing Added section Add Henry's Ack v2: Add blank line --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e5efcabda..56921db79f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - xl/libxl can customize SMBIOS strings for HVM guests. - Add support for AVX512-FP16 on x86. - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech Preview) + - Add Intel Hardware P-States (HWP) cpufreq driver. ### Removed - On x86, the "pku" command line option has been removed. It has never -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 19:09:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 19:09:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578890.906626 (Exim 4.92) (envelope-from ) id 1qT5bL-0006dI-I3; Mon, 07 Aug 2023 19:09:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578890.906626; Mon, 07 Aug 2023 19:09:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5bL-0006dB-FJ; Mon, 07 Aug 2023 19:09:11 +0000 Received: by outflank-mailman (input) for mailman id 578890; Mon, 07 Aug 2023 19:09:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5bJ-0006d5-Te for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 19:09:09 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1ff387e-3555-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 21:09:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFEE562158; Mon, 7 Aug 2023 19:09:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A8C6C433C8; Mon, 7 Aug 2023 19:09:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1ff387e-3555-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691435346; bh=OONUMkr4pVyrRDkANbDJUrnv0+TbQpEMBqD0Z2FV+QE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=n14AHqm9p1twSr0CYxqj+WcYmP8534oKOR7SiwtESg7WNqZy5+JZfkwyf35wSsOdM 8yY/a9eJiW9mOakR/FWOw4ZS9QLP8SUMFWkJBRdLOJHfGPP+m1Ok8EVEEsKOMKzUNJ OR7hqo7pUF0vPiNRQk8DbF5ItR4DmCVqBvyD0/fZf2NIeh/Ckzs0cOMdFOMBkNsTaN 4UQyJTqoK5PiOxsQAbsrC1le0ORsR8KeCo49VSHhtlD92RQqscR25pFrSY2KRnDz4j RR4H53FIZo+40INvXVk06ekskUFM6dsGiotkJilCm6Ls8l7KWUlgPVHZyMU5oJa6nw //FC+VezkdRYQ== Date: Mon, 7 Aug 2023 12:09:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Michal Orzel cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Simone Ballarin Subject: Re: [PATCH] automation: Advertise that ECLAIR jobs do not need prerequisites In-Reply-To: <20230807134122.10878-1-michal.orzel@amd.com> Message-ID: References: <20230807134122.10878-1-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 7 Aug 2023, Michal Orzel wrote: > While not required today (ECLAIR jobs come first), add "needs: []" for > future-proofing and consistency with other jobs in the pipeline. > > Signed-off-by: Michal Orzel Reviewed-by: Stefano Stabellini > --- > automation/gitlab-ci/analyze.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/automation/gitlab-ci/analyze.yaml b/automation/gitlab-ci/analyze.yaml > index 3325ef9d9a44..4aa4abe2ee18 100644 > --- a/automation/gitlab-ci/analyze.yaml > +++ b/automation/gitlab-ci/analyze.yaml > @@ -18,6 +18,7 @@ > - '*.log' > reports: > codequality: gl-code-quality-report.json > + needs: [] > > eclair-x86_64: > extends: .eclair-analysis > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Aug 07 19:13:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 19:13:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578898.906636 (Exim 4.92) (envelope-from ) id 1qT5fj-00088i-BA; Mon, 07 Aug 2023 19:13:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578898.906636; Mon, 07 Aug 2023 19:13:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5fj-00088a-6E; Mon, 07 Aug 2023 19:13:43 +0000 Received: by outflank-mailman (input) for mailman id 578898; Mon, 07 Aug 2023 19:13:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5fi-000888-AU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 19:13:42 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8423dd5c-3556-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 21:13:40 +0200 (CEST) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-52328e96869so3623949a12.1 for ; Mon, 07 Aug 2023 12:13:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8423dd5c-3556-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691435619; x=1692040419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RXxMEtzIXtzgrrtBXu1NPeueyjZJ8BAJ7BaiSiWCnkU=; b=OHkY0nOSdqh/FIrYL07zgHYHXA4M9yfec4cgL0/ZsTlcubZRB09Xmz7RAsFYTDvSUD AIrFcWGG8A1EHy8UX4+S0MunsXDXkcsZDmvFNO74lORRx0XcQwlvz/pq7DDVy7zEpkD4 gGZ+kTuqRHu3cFAjgMbD1v+PAThmofi0mfUR9jlTq4dvC+/HjsdRiV/D8DGada/tUo3s m8RR103hx0vpw/WaC4KsXMSjfBOj6xKT6omnGTwlyERjSPFFw7y+WQlSYXugwR1InnCZ YDHb7moHW5qR5Ky+PlbDyhErLvnI/8lWqBRjrOTCmK0BTW7NeJcAOBOfGBKLjIABMwjO YkfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691435619; x=1692040419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RXxMEtzIXtzgrrtBXu1NPeueyjZJ8BAJ7BaiSiWCnkU=; b=CzcT+ZHPr9L/F6r0p5skN8Hy8+p4Nfhmv2gohABpk6RVh2zBsNgbDDZw0cKJgVaNjL m1pvv9bWAeYsfOrV3KpcsC3PylDLnz86vsUVb+YMZSY2qd8dQ8SOH+NKPe02/AdmmyKp /2KNvhuQWn0mbQ6IPpLZ9qh3LwmXOUcYMWM68ZYTiErA4knhLUecxiCSTBABGBbpb6Jm ku3AMgZEQUhQZ9SSKRyZno/dEeTsAvXcJznQkWPgB5TMS9PaUu/a+OBcvP7Rxw1L06/e wAz+L569o31PGKHZWBbeICTcOOAIJ0Iy0otsgkzxje6yL+3mrWYQB23Zyex9AvblwjQp N0IQ== X-Gm-Message-State: AOJu0YzqWDloJEP3HTN0ukIlo1AZNdHQz4f3Qipx+6n028ARxLu/j76E 3IsLopM2Rue+sn0vlyJXyZNLMG+t0BMjb3IdOGJWu6Ac X-Google-Smtp-Source: AGHT+IGsJrdTF/VBHdSRUmI4G2FG/S8Tsgk5Kcx9xzUfrGQCqDzRZjKLnlj+b0BYpoyfSrQwCHwCYZlxGCEYBJuP6iM= X-Received: by 2002:aa7:c2c9:0:b0:523:3e4f:1ff8 with SMTP id m9-20020aa7c2c9000000b005233e4f1ff8mr1983673edp.16.1691435619009; Mon, 07 Aug 2023 12:13:39 -0700 (PDT) MIME-Version: 1.0 References: <10ce72fb-4fb7-67de-41ec-7291dbac0038@suse.com> <3c819879-d113-facd-b025-b062e68bb6a1@suse.com> In-Reply-To: <3c819879-d113-facd-b025-b062e68bb6a1@suse.com> From: Jason Andryuk Date: Mon, 7 Aug 2023 15:13:26 -0400 Message-ID: Subject: Re: [PATCH v3 3/5] x86: allow Kconfig control over psABI level To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 26, 2023 at 6:34=E2=80=AFAM Jan Beulich wro= te: > > Newer hardware offers more efficient and/or flexible and/or capable > instructions, some of which we can make good use of in the hypervisor > as well. Allow a basic way (no alternatives patching) of enabling their > use. Of course this means that hypervisors thus built won't work > anymore on older, less capable hardware. > > Since older compilers (apparently gcc10 / clang11 and older) won't > recognize -march=3Dx86-64-v2 etc, also addd fallback logic passing > -mpopcnt and alike explicitly. > > Note that in efi_arch_cpu() the filling of 7c0 and 7d0 are forward- > looking; we only require 7b0, but we need to use cpuid_count() anyway. > > Signed-off-by: Jan Beulich Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Mon Aug 07 19:18:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 19:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578906.906646 (Exim 4.92) (envelope-from ) id 1qT5kW-0000M9-RY; Mon, 07 Aug 2023 19:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578906.906646; Mon, 07 Aug 2023 19:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5kW-0000M2-NR; Mon, 07 Aug 2023 19:18:40 +0000 Received: by outflank-mailman (input) for mailman id 578906; Mon, 07 Aug 2023 19:18:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5kV-0000Lw-PB for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 19:18:39 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35d67885-3557-11ee-8613-37d641c3527e; Mon, 07 Aug 2023 21:18:37 +0200 (CEST) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so5766070a12.2 for ; Mon, 07 Aug 2023 12:18:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35d67885-3557-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691435917; x=1692040717; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EnVVq0gFmpSLJc7Ra4hKzgPMN6I3sQVjfRFG+ziAaNQ=; b=DQLUER5+ML7/Yo2Em24FN3v9IrFyVp9+kNy+QKr3hfyBbFCATqwg2jiQSC44U8Rwbp ohZdcGuPwgfhdIkJaqfhrDmkld31NXLQUqk5qVB6rl7IDKF+YmLmSP9bD5k8Jy8IXnda yRs28Sj2jFziSyuzf7LoKNoMBH7aJLAbH5eNRXGmB9EyC8Bm1GgwXzllomajYw4E6v6O 9iKln5hHxHu2XHMPsQRuFQEiQHDSjeU/rUPS+CKa33w5ks+zvlIfafz0hN1E8Rmx0vXL huehtudTV8TsAQt2iYlHpVhbyGlNSFgqtmZMlYpEpdezSK3gP/bkO86KmkK87QiO7mZl xnyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691435917; x=1692040717; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EnVVq0gFmpSLJc7Ra4hKzgPMN6I3sQVjfRFG+ziAaNQ=; b=HkZ+4mNLrD2lCJXsO8hbsEKf//pqQMOMewc90ElkNYUAn9pBvYYun7zZD5fXJcTrV9 zpRdIJ3OjzuJIVpC/RIIOr94gPVLCG/BkyUk/6SdunMGF0PRWwfKTBqOaRNTgL8e31Rr dMGwMJW24kl2vSTPi9GQc1gqAAGSSakgMFvg/cJIkqGL53DzpcJkXQOSL94EOY60x34J 4jvJ/uJ7egLhCxh6HBEkJIxTcjlTk0iUxiCxnB1YJDZlpyNJjhbp1Hs/9qX3QlMbFk3f TnNoY5UR8tKTADT6kJzYgTLOYsyws+jGSe3XIe94dRxsKyQb46aPSr96+P/TgnT7+MNW 54lQ== X-Gm-Message-State: AOJu0YxPNfg2tNo+hqvZuU2wX/86RQKtK5qWqP7dC4cpNp4FZrXFgO07 PwvJN3zihtbQLnXdEkwenMtwOpBpvJ0pjnZ0KOg= X-Google-Smtp-Source: AGHT+IG+m4XVxDF/Rm2u1rgJr/aS2zRCOZc7kHVJfbVidAgv8rP7YyRISpzYUtQC0FpCnYYhZlYTRHPd/fQ/HHcIjhk= X-Received: by 2002:aa7:d807:0:b0:523:9c4:67ba with SMTP id v7-20020aa7d807000000b0052309c467bamr8027044edq.6.1691435917089; Mon, 07 Aug 2023 12:18:37 -0700 (PDT) MIME-Version: 1.0 References: <20230807140620.47221-1-anthony.perard@citrix.com> In-Reply-To: <20230807140620.47221-1-anthony.perard@citrix.com> From: Jason Andryuk Date: Mon, 7 Aug 2023 15:18:25 -0400 Message-ID: Subject: Re: [XEN PATCH] libxl: Use XEN_LIB_DIR to store bootloader from pygrub To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Jan Beulich , Wei Liu , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 7, 2023 at 10:07=E2=80=AFAM Anthony PERARD wrote: > > In osstest, the jobs using pygrub on arm64 on the branch linux-linus > started to fails with: > [Errno 28] No space left on device > Error writing temporary copy of ramdisk > > This is because /var/run is small when dom0 has only 512MB to work > with, /var/run is only 40MB. The size of both kernel and ramdisk on > this jobs is now about 42MB, so not enough space in /var/run. > > So, to avoid writing a big binairy in ramfs, we will use /var/lib binary > instead, like we already do when saving the device model state on > migration. > > Reported-by: Jan Beulich > Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Mon Aug 07 19:22:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 19:22:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578911.906656 (Exim 4.92) (envelope-from ) id 1qT5np-0001mT-9Y; Mon, 07 Aug 2023 19:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578911.906656; Mon, 07 Aug 2023 19:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5np-0001mM-6F; Mon, 07 Aug 2023 19:22:05 +0000 Received: by outflank-mailman (input) for mailman id 578911; Mon, 07 Aug 2023 19:22:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5no-0001mG-85 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 19:22:04 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b03dd26d-3557-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 21:22:03 +0200 (CEST) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-52307552b03so6756295a12.0 for ; Mon, 07 Aug 2023 12:22:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b03dd26d-3557-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691436122; x=1692040922; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BuCRkyKda8YWgOZqK5+ahsUV1F3t/tbQ+gtgKZ/2cZM=; b=YoXuPmyIUWvzKVGMNJOMvRR2rqwx1pTl4u8VhjYNCtdHhd6isx/cIcT0WycrVkjV3b HP8wMBVaZR3BwjULGAuXLV5uTJ7LkISUxMiUGvzdjFLcYXSoTBxiLaa/HxJqW0IE9wqN ecI14tsJA66jHxzPiEwM4oLOrtfFeYtwc0U6iKJnTV4Ac0ALW+MMsp7+uo1AeRJVTicI 3D6Z64xlbfiprv9PttD81bwyagfAGpydyJuTSJUg3+a7MbEtyvZc3bERZkeDKabktP0K GUCdTxJZ16pKZSRtSYgJwK7QqBoc4tB6R8QUWgCbHKW9HFotixEAgR02xEbTxaeYI5A0 cKkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691436122; x=1692040922; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BuCRkyKda8YWgOZqK5+ahsUV1F3t/tbQ+gtgKZ/2cZM=; b=Mp47MgXeOTH8Tned/4F4DQgy1LBz2av5ltqetVhq0x7RINoOgJdMpLOFjPq89R1oEx WGl7TByiYZrKkEDQ2IQ28DO5yws9Y9UQLXn5r4mUGVrkB+19vRJW9L814/kzbkg/JcoT JNoL+Cb9judbZlQM02IN7JtA3FJH4/3aBenTLwxN3Il7PscC+llV2+v5lN8ffr/3bdIZ 6/4M8gvL4VTBOySbp2yDNqYLfUb+bsDG2hUTo12ikh7H3S90bOn8UAVVVnHyHYuIBySY 2IudVXZiIt8dwCrs8fcAS4Ixg6iSwnNkUAkqZQK1fzN52IWdYk+wW99ISQbzxQf9IcYO PnIA== X-Gm-Message-State: AOJu0YxdM3HmLwd+3HHYkBIZAoNbYXIrtMbtC6fmE2GxZgiST+0zursS wwJYk5CEOuwBXmFBdqBoic1w82jChQ6jC1ogZZo= X-Google-Smtp-Source: AGHT+IFacaM2BJDDKzxw+pVOfKCW4EIimknet/GNgHUe6qHo7FXGBs9SqdY5cBX0gWqIrid577hldRoEEbzQ7NTcQhQ= X-Received: by 2002:aa7:d358:0:b0:51d:f5bd:5a88 with SMTP id m24-20020aa7d358000000b0051df5bd5a88mr8602875edr.38.1691436122534; Mon, 07 Aug 2023 12:22:02 -0700 (PDT) MIME-Version: 1.0 References: <10ce72fb-4fb7-67de-41ec-7291dbac0038@suse.com> <367db8f8-3287-d694-e591-efcffaf9ee99@suse.com> In-Reply-To: <367db8f8-3287-d694-e591-efcffaf9ee99@suse.com> From: Jason Andryuk Date: Mon, 7 Aug 2023 15:21:50 -0400 Message-ID: Subject: Re: [PATCH v3 5/5] x86: short-circuit certain cpu_has_* when x86-64-v{2,3} are in effect To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 26, 2023 at 6:35=E2=80=AFAM Jan Beulich wro= te: > > Certain fallback code can be made subject to DCE this way. Note that > CX16 has no compiler provided manifest constant, so CONFIG_* are used > there instead. Note also that we don't have cpu_has_movbe nor > cpu_has_lzcnt (aka cpu_has_abm). > > Signed-off-by: Jan Beulich Reviewed-by: Jason Andryuk Thanks, Jason From xen-devel-bounces@lists.xenproject.org Mon Aug 07 19:24:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 19:24:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578916.906665 (Exim 4.92) (envelope-from ) id 1qT5qX-0002Ls-LQ; Mon, 07 Aug 2023 19:24:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578916.906665; Mon, 07 Aug 2023 19:24:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5qX-0002Ll-Ir; Mon, 07 Aug 2023 19:24:53 +0000 Received: by outflank-mailman (input) for mailman id 578916; Mon, 07 Aug 2023 19:24:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT5qW-0002Lf-EE for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 19:24:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 139c6502-3558-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 21:24:50 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D1D96216A; Mon, 7 Aug 2023 19:24:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43F89C433C7; Mon, 7 Aug 2023 19:24:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 139c6502-3558-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691436288; bh=ShzSncWkK1q8EFrv8kW0nziCl3BTWaxfOq7SLvNC8Ig=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SSjYMqoCsffrsoGxAQYfHlrN1G9QhvnVUJenCxVfrwgwbwq+5b7sOPvmFdDchGxFh Z28YrElnMcU6Kqbw73o9ViZYSnRW8QCi1L6dwyNAAqnSvQG4P+bOYo+R3viF8vFOli HajyptAYgcWKT4lk3i8b7LI+X1LzkRp1C12D4jw8haZA8OVvF7A4TNdYMEhjRsoJiS r3wXbZ7fV2hvqMud11n0KX/ISy8sMK533iQu9GRgrD1ymu3RN6YTlUwfbTMHf+nNpt NdugpIUheEv5ME4cw9KoO8V/mT1MkIIAuloQ+/EqKOh1XFlQGd0V0MyfGVXjxIT1Ba wqLLOvFK4tJRg== Date: Mon, 7 Aug 2023 12:24:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Henry Wang cc: "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Andrew Cooper , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Julien Grall , "sstabellini@kernel.org" , Bertrand Marquis Subject: Re: Xen 4.18 release: Reminder about last posting date In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 7 Aug 2023, Henry Wang wrote: > Hi everyone, > > Following the release schedule discussion in in April, I am sending this email > to remind that according to the release schedule [1], August 11 (this Friday) > will be the last posting date, when patches adding new features are expected > to be posted to the mailing list by this date. > > Also, note that we currently have 1 release blocker [2] which might need > some attention. > > [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ > [2] https://gitlab.com/xen-project/xen/-/issues/114 We have another release blocker in my option: https://marc.info/?l=xen-devel&m=168312468808977 https://marc.info/?l=xen-devel&m=168312687610283 Andrew, would you OK with making it a release blocker? We already have a tentative fix from Julien. From xen-devel-bounces@lists.xenproject.org Mon Aug 07 20:56:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 20:56:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578952.906692 (Exim 4.92) (envelope-from ) id 1qT7Ge-0004ML-Jw; Mon, 07 Aug 2023 20:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578952.906692; Mon, 07 Aug 2023 20:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT7Ge-0004ME-Ge; Mon, 07 Aug 2023 20:55:56 +0000 Received: by outflank-mailman (input) for mailman id 578952; Mon, 07 Aug 2023 20:55:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT7Gd-0004M8-6K for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 20:55:55 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb21262f-3564-11ee-b280-6b7b168915f2; Mon, 07 Aug 2023 22:55:53 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Aug 2023 16:55:46 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6069.namprd03.prod.outlook.com (2603:10b6:208:309::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug 2023 20:55:37 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 20:55:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb21262f-3564-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691441753; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=00OESeAFg69Kz2rY49e/l18jDbeyyE7Uov/LuG6aTxs=; b=WkffSd7hlrROS5BhObd+cwf+1xeRKemftkOgFWdavp/+QN5W0YSypxKK ifAvXVOtWLfgOhEk180oGOWxJafzlHPMrKfLCcDENDw9wmrpF0e/qIdNi 0wwFo2RAYYLKta7uY4BewVu5e38d38Kj5TFkFMFVUiK9cBswAr2nojynu M=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 118057846 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:EcE4x6NXmIZSKOnvrR0zlsFynXyQoLVcMsEvi/4bfWQNrUp30zQHz WYcCGuOP/uOYWqmKdx3aNy1p0kCv5PcmN8xTAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/vrRC9H5qyo42tI5gNmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0r1XA3BF+ f4nFDwqXxuGi/C57KP4ctA506zPLOGzVG8ekldJ6GiDSNMZG9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+/RxvzW7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prraWzXumB9JOStVU8NY1qn+M33MWLyYMRAukhqWHjmunW99mf hl8Fi0G6PJaGFaQZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8yyaUAHIVCAFIbtMOvdUzAzct0 zehj97vQDBirrCRYXac7auP6yO/PzAPKm0PbjNCShEKi/Hop4Q2kxTOUsclFaezh9L4Axngz jaSti88ir4Py8kR2M2T/1rKnjatrZjhVRMu60PcWWfNxgFkYI+oYaS45F6d6uxPRK6zQ0Odp nECl4675foXEJCWvCWXRaMGG7TB2hqeGDjVgFoqGoZ78T2ooiSnZdoIvGw4I1p1OMEZfzOve FXUpQ5a+J5UOj2tcLNzZIWyTc8tyMAMCOjYaxwdVfIWCrAZSeNN1HgGiZK4t4w1rHURrA== IronPort-HdrOrdr: A9a23:nfSu5KCI6aiYUHHlHemK55DYdb4zR+YMi2TDgXoBMyC9Vvbo7v xG+85rsyMc6QxhP03I/OrrBEDuewK+yXcY2+ks1NSZLW3bUQmTXeNfBNDZskXd8kTFn4Y36U 4KSdkaNDSfNzlHpPe/yBWkFc0t2dyWmZrY/ts2DE0AceipUcxdBstCZTpz23cZeDV7 X-Talos-CUID: =?us-ascii?q?9a23=3AT5d8P2uHCpv434KsOSRkPyp+6It+Un/Mx3vSHHO?= =?us-ascii?q?0LldiTbGHRnOBu5tdxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3A90G++w4gHGv4ORKgaPMDICBhxow3yYaxEV8Itq4?= =?us-ascii?q?cqpmbEnBOPxKEjDmOF9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="118057846" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAHXDKZE1D73IucaJJpV5qLBabtiGs1pAJGEYHqXSdKQpBRtHEwvtXuMafFCJ6JAmU/MoH8tgea55Pw2gZXORQDN5GXOF3Wj8v5ucmp2C09gitzjr8xBEqhv771VLsiMVxt/Jx+ldJcxraUkYyafavI4MmfjR9sDVlT0Nj7JhaB/RhPA/neV3bahc9QRPcgyCzXijkK9FYbl2N7Fj6tcAUY0pYim2BnubI3DVFQAgHlop2trMWwZ3n2dyBhWASP25GNGc00TLUrD5DOihphxrzymtK7U3Pm2gTOS2OF3f7blSMVn+EZQG+7qFAVY7Vs3XUCEm72AVbzVlDCkRoLgMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=00OESeAFg69Kz2rY49e/l18jDbeyyE7Uov/LuG6aTxs=; b=aEVLgItnBA5YTj14RVIqoIDstyTOw3xrwKlZVtyeUxcEBBNQXKZeDH4KpD+jEs5+1tSJMn8FNiRtfCMx3waULq34TTkwyC/vT3gESkhJE7O8iuePUi/KVWWmb4sasRzfsy16RAu2nhwHuyWVSMAP05dQRPb3tyz9ZG3kXj4+gY2vLYHiu5mMhNWowPlua+kG8sAIzzRvo9gxwj0sVMeNu1UoljabZStDBu6s7Ic/G/gdQ9/ElT+v42QBy3himCe1tfelkrKhwOV7WF4EzrcsixHwliZWK8tAnsiM7zJ3ZuA1sNFNMgl7gFgB5KaYl+XDRHuZCmMLMAa5nWtM56nGxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=00OESeAFg69Kz2rY49e/l18jDbeyyE7Uov/LuG6aTxs=; b=swQvHf4ZEXJ7pJwbuRajTSH2fkvuVkFoyvceg7tYFCoc7xPUwz/OtZJ2z6McdkI+tNxN31lcfVkgPtjFsVOkZ5lhwagnQwm7CaY2Qp/EdM8ACc2ZwfmrHhIKurMPQ37wgAix/e6gpeIXe7ansX98Ku3f1ViX9Dd8nzCp416zBSA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <70a225ba-e263-48a8-793d-3f596e89fc41@citrix.com> Date: Mon, 7 Aug 2023 21:55:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: Xen 4.18 release: Reminder about last posting date Content-Language: en-GB To: Stefano Stabellini , Henry Wang Cc: "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Bertrand Marquis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0125.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BL1PR03MB6069:EE_ X-MS-Office365-Filtering-Correlation-Id: 60bdd084-4450-4382-a84c-08db9788a609 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q2eCQr+RmNQtkPfV5EZ/9jLUHhDm9C9saVzW5regoxh6oHIVvzyBOZF8v/pPte6zzOQ8cIMw3eE6FTkbrTJyXwxwzjc4EoGRcvZdn1mf5xMzWuXIvwJrglu7sDD6O2Jb6Aum/iy0CQ6hKTM5VgezSJs02nEgdA9z+pDe1p2AAE0iIXwYFJapjH9GcVCy+2+L0OVTd1Hyn0bR1O2ozhh0WE/ZiJ7nyfuOONyJhNCSlxZy5ALjd7MyQKBNDLsyipEoKzjqXOaa3pZAmtZ2ACcGoWMSZqm2eytHC8CFFQ8Nn/Wqaj5DjFtrq0Y0mJqg+VSOaygg4S3OIxMWTYrCI5HAsQW2ssGAcWDgcFvxf+sTgpds9UnYyeOsNtW2vkbnSnnfEpyfWfTOsoFrI/FaIRZ2vGRRtopdVE+mdX0Dd4iI3bMzlHWkKtAHnX9PoVQCBz2/EWKWdCSk9mpWKB3qk/XD4N/Kqd6ATQXED1q6SltTYr718s2E4pF4Bbys6vFJCL7jJ6BV88nICP6Jw4ciGex595xvOSwE9zv9lwq9C8jtVDjwerqJaQYwWYxKDue9x373p2cSG3+I3PAbqQdqO9SykDjpJ3P8H6hftldmyweE4mUOVGuVd2ahewXmCie/Y+34oWSbhw4OlEv7NABdgTSJCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(186006)(1800799003)(451199021)(2616005)(82960400001)(45080400002)(478600001)(83380400001)(31686004)(6486002)(6512007)(966005)(53546011)(26005)(6506007)(41300700001)(66476007)(66556008)(66946007)(8936002)(316002)(8676002)(4744005)(31696002)(4326008)(2906002)(6666004)(36756003)(110136005)(54906003)(38100700002)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R01ENEJ2WjQ2SFZJUjIydWhzdWJoK2NEc0tGclNtSlZqcDlzZzN5RkVoMXhP?= =?utf-8?B?NjBtUEhCNnlQUzBCYmxqVTUwUXd2UEN4T3UwWCszaDZWcEFsSlFwYVpYUkRQ?= =?utf-8?B?anlwL2V6TkhrdVpqV1p0djdWZnMzcXdDTmNmRWh3bEdBRm5MM25UbnMxRHJN?= =?utf-8?B?bk1vWnVEMEpRajVDWmQxRGJlb3JqKzdDOUhwUWZVWlQyaWc5S2dHSFA0V0VK?= =?utf-8?B?TFJRWlV6OUNlSWJ3bGNIZkNQZ294NWUwRER6RHVKWTFvaU5zMVU0UUVObTNT?= =?utf-8?B?YmZUaHJCTHB0aUdVZGQvM3VyV2hIOGpvN2lHM0pHajhRbS8vWmJVcmhXYWZs?= =?utf-8?B?V215V2RkZnc5MHBPSTJsZzNJckIyWGRxTFhYOTRDd3ZZWXA0WFFhRWdHdTA1?= =?utf-8?B?VTZKVDY3eDNveUEyM1ZWNXdqU2x2SFB6RHovak1RWGdSUVFrM1JMdTdMR28x?= =?utf-8?B?YXI3eU1KWHFmaGNqYXpzR2hreTFvRnM0dEg4S0x5MGxXWTBLbHNjT3Z0bWJK?= =?utf-8?B?RzU3TjNJSXJYTmdic0JTcmsyU3BJd1Z4OG1aYXZqNHI2b3dRV1M5V3ovdU9w?= =?utf-8?B?VUMwQkMxNjdzTmdJMkZHWmYwRTVrdnMrZU9CampWKy9wWFgvWk9iTDQwQzRs?= =?utf-8?B?WWxhYlVvWDVaYWJoTkdaWURNeGJhV3d0d3FhQXBoL2xLb1BnZk10RFEvb1N3?= =?utf-8?B?U21uQ2QvZU55Q0pmZXdQNHBsVTdSNFluWjVhdUtNSG55QzJzd3RsWHJaTnhn?= =?utf-8?B?Uk1SRE5SL2EwTjBUWmxlNWx3QUwralJnalZXUVZ5VmlPM3RRYTZtaUUvK1dO?= =?utf-8?B?MU1zVk5iaGZtU2RhSnlDSURyb0YxRVRqZ21qWjhiMjAwcEhZZnJDeDN6bmU5?= =?utf-8?B?WG1SVGtxaHpYSjFXSFRlaUNxTFFrUzExc3RCaFU2R1ljcTQvM1N0c3ZXenY5?= =?utf-8?B?d1ZQbS9sdUtia245R0NYY2I0Y2lZaTVIdXRSdG5BLzlDZ2w0aHFJdFNiN0ZD?= =?utf-8?B?Q2JLMWtGbjlmT01kejFEQWxaTmcrOUVMTm12am0rOSs2Y3FMclJiZGN0ZkdN?= =?utf-8?B?R3VGb0JXS0FxaXBLUjhVRnBsdEpKbkNScjRUcGQ2d3BUT3RsM1NLbnhMeUJR?= =?utf-8?B?NDBIanU0Z2tDZGxhV21xMXlkb2dYUWFxWk1QR2t2dWZ1bFMvMER1RmRITE85?= =?utf-8?B?eVk3UWlPNEhyZjR5SzhlVlRGcFBjOTBjeDVDMzJudFVGb2ovMFlKSGFvTG1z?= =?utf-8?B?Sjd0Vmw5VXplaGRHdE51bmZQYjY3MytDSGRaMVJmWHlBcW90ZmRBVldqQzZl?= =?utf-8?B?SnJ6bXNGbG03RU92SnhmRVhSempOUnFqTGpsMVkrWUYwb1hDWXJTODRndGxZ?= =?utf-8?B?M0IwcDNxUDhYTVdnTGpGYUhGblhRdTFMZkptQkViVHB6WlF3Zkt6bGVGaHBP?= =?utf-8?B?WjBSUFJJZ3ZtNW14WG9pYkNsdUFIQ2hlV3o3YjRiOHBjRHBwNTY2MXB2SHdP?= =?utf-8?B?dE14Zjh1U0xmYWJpSHN5M2dJVGRqeGdpeHFIQlc3eXFlUVZML3Fmb3NzZXhy?= =?utf-8?B?dVh4bmJ5QnpSY0dYeVJyclNpMkpsSHlQakU4THJxU0d4SWF6M2p4R3FndmJw?= =?utf-8?B?UURaK3VqTTJuVGRraU1zcXJSUUlTaUZKdEllU1dyVEtwaExZSG5kZTVMQTRB?= =?utf-8?B?dUhQaHFrLzhEODNySnpWVVVRdmNrVmEzUWdKYkVxaVVpS1RweHNPM3NadlBK?= =?utf-8?B?cFNBSUZqVFlkbjF2Qis5c0s3eDVadERlS0RQZng4aTdTNlFMa0h0NnIwRm1U?= =?utf-8?B?ODBYM2dudTFoRC94cUNOSkxBWmpvbFdsbWYvOGM5QVdnaFh4eU82VjBhTGM0?= =?utf-8?B?UXI1ZWxoRXlRVm04ZFNqWllDL0VockQwc2ZkNmhGUkFnRVM3c0cwcjRKcnkz?= =?utf-8?B?OWF4Ymsra0k0TjhpbG05SGllclA3eG5sbWpTRnBiMUVSNSthRWRKeDBEbDVo?= =?utf-8?B?dTIzbWlUb1lrTjAvN0FIdzYyZlFIM0I0WDhqRkxjUzhpS1NIbHdwVTQwYVR0?= =?utf-8?B?M2dzVkRVeVpSTURBT3M4V2s2SzJKWWdxeW1XMmpyYjBLNWtvUkVxR01BUDRL?= =?utf-8?B?dHBBaklSSG5sY2VQcWRnWVlJVVkrNnpwNzJKYjJzQnJwTEFwbEtEbWV2Vyti?= =?utf-8?B?a2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: STMBWjxl7covTyo9FuHeWo7BfIoCV4LaTg/DM4WHOe90xt9sh2xbh0coVvp0hABUcvicwJOxUgBGc1rP0bDDe4C+6r9EBmywHX06h8faa+n4VNThR8sliF9SqrYzjK6qDFG/gRpuHt7hv+dvS+IYg4PLf8PwLZS28fMA2Pv9YIs8coKuCuQ3kFJNLuhaRsTpwoaBGf7kbIdikGPmibS8jPB9x5t6+Q045Wr5qjPl5jSnH240JhLupfvglXglzRzZTGFBl8Ty5CdD92bYTVnHFCrJnnu6IwAVzWkmCQGY2b62iPpsJoOEn1iatknvwZS5MJI6d8jgzcTehE0nATmZAeTJHBVR1yeFIXa9U9nBKe+LbvML+QPLlDkiAGbq5n3ieDxCbX0wlRd4N5f3tGoVpCkWU88ii/R5qhFX1QcfmpcCxSZ0/RutrqapaxvFquGHXioS0XduuOKLALnM/qogkUO9G0cS5kBv05tCByT3Df1lhhmH4JGUMxsnLkcUbt/5LHpqxjr65s6ZiuvgHedKGkVSfR5GzgnCpLvEdmzOYHTTx/ynBdxjF0h2YFMQbq6VUkE3f6JFB7QDVlDy0LVEzHZ8NuRfi41Dcn+PuuNqCePcRRve494xSZM2JexbkMp79SppC213iu0lKIruaToMyLtuxvbRsdTEtC0WJqYYG64cYuTbRcAEH/d53MnVfQTjKykbIMoGQHFsDz+VVbBhSf3dMObyHcVn5kweAZPrFHr8OqqW5F6WqXIdzYheRlOFTgQSYLdZOusipXYqgWAeUAATf2/9zkw7myvzJKjm+gTPikVc62lrhQC6xn5I1VwdcpFDV4446SznyHIVi+ICsqEFLcB7Pk2C5ro9kCd8sJhnqQX9xwwexEpjOD7xH33xQEZde7cdeJzFOpBPufvTDlIHqWm17XkrVJ8s67IQHjw= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60bdd084-4450-4382-a84c-08db9788a609 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 20:55:36.4156 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VGFr+SILY4iLN3Czn29/QlD4PaVqblxRiPErpMBN0cTVV/1f0KOKALXBgjxzeekTZppV/IyoIx+u/t9sXXtT7leq/Ts5J57So7FT8QHIk6E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6069 On 07/08/2023 8:24 pm, Stefano Stabellini wrote: > On Mon, 7 Aug 2023, Henry Wang wrote: >> Hi everyone, >> >> Following the release schedule discussion in in April, I am sending this email >> to remind that according to the release schedule [1], August 11 (this Friday) >> will be the last posting date, when patches adding new features are expected >> to be posted to the mailing list by this date. >> >> Also, note that we currently have 1 release blocker [2] which might need >> some attention. >> >> [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ >> [2] https://gitlab.com/xen-project/xen/-/issues/114 > We have another release blocker in my option: > https://marc.info/?l=xen-devel&m=168312468808977 > https://marc.info/?l=xen-devel&m=168312687610283 > > Andrew, would you OK with making it a release blocker? We already have a > tentative fix from Julien. Yes that is a release critical/blocker.  No it's not a fix. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Aug 07 22:19:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 22:19:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578964.906703 (Exim 4.92) (envelope-from ) id 1qT8ZA-0004Ri-LW; Mon, 07 Aug 2023 22:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578964.906703; Mon, 07 Aug 2023 22:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT8ZA-0004Rb-Gs; Mon, 07 Aug 2023 22:19:08 +0000 Received: by outflank-mailman (input) for mailman id 578964; Mon, 07 Aug 2023 22:19:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT8Z9-0004RV-6k for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 22:19:07 +0000 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [2607:f8b0:4864:20::f34]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b71ed87-3570-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 00:19:05 +0200 (CEST) Received: by mail-qv1-xf34.google.com with SMTP id 6a1803df08f44-63cfd68086dso28200326d6.1 for ; Mon, 07 Aug 2023 15:19:05 -0700 (PDT) Received: from kevinnegy-MS-7B85.home (2603-7081-7e3f-df30-ac18-f9bd-4af9-8893.res6.spectrum.com. [2603:7081:7e3f:df30:ac18:f9bd:4af9:8893]) by smtp.gmail.com with ESMTPSA id q4-20020a0c9a44000000b006300e92ea02sm3230906qvd.121.2023.08.07.15.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 15:19:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b71ed87-3570-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=exostellar.io; s=google; t=1691446744; x=1692051544; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B5ddogz6ssKMprKcwC91sbBtEGvoKYSyZ4oIHsEh4mw=; b=cKjCQ7f4JoSJKyQusI8TZiu6fHU9zW8df5m/ibDZJPVZC334HFJDs1v6xqE60+x+DC PK4HfOpskRZaL4RSYrr5ocwi2epEbU5H+DexlwwBVyt7vJnSg2gCYCHg9FUwGP+fW0zH l/L6fKZCJUraHlxYoweP2m31dHrBSQ9zAxlu3tr/yjRCZJDVyiDVQaY5x4qoEyzw2zza zSmrdtXeqFvw7AAavaHJaLx/yj8xvgQ77Bd5XCXmXWq6+ejrEQWDgzIEnKRJo/m1cecQ zLHELV1b+oW670MyO7T+AsgujIUr2R/d1I0SgdcO9UHSZX0g+LKJWvCqIBAuYcuTije1 wjYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691446744; x=1692051544; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B5ddogz6ssKMprKcwC91sbBtEGvoKYSyZ4oIHsEh4mw=; b=bAAzA2Fu1EkaiZwXcpG7j476y1gQti+JcyDZZuVisYG54zwwri0PV7sEBL+AyIygqr LccgVGhNZ5jOgY5xrVz5EUQAoNYLY+9qdS55amzxpGb2LrfOTyHNbQ7WmkA90Tx7G34E wrDtmCsJ2lYCgFuEhpVmRlfb3rS6TuutZY6r3sPE8fos+k1zgw3KDP5MDC8fcTBc5wjQ q1LBmvKuAD7xKDvSm9jz81Z5Iq/VR8lnRPnC1NgrTIFT/lMXqJDKJGn3hSzUavYlChRd 2zmXd51ROfQSIG1idUrxyIs0acgGMImwea8/5wCcP52OgrK9ScwM4P5/h+r66YtpCynh P+VA== X-Gm-Message-State: AOJu0Yx05LySNxQlN8RTS2X76BgV9qObeuRgaVG0/8WFVElOBhHW5Pd7 5piGS4KRLW4x8DOqvEhXgKnKGdhyogu0iX03UPEYLdWx X-Google-Smtp-Source: AGHT+IFAwmFoA8RdUNOlqqGfSxJVgXRlmAojWIbMmWVZLFCbiV6pJYC9V/5ee+kYdfKjeJPA4iXp+g== X-Received: by 2002:a0c:df8f:0:b0:63d:318c:7e0d with SMTP id w15-20020a0cdf8f000000b0063d318c7e0dmr10300369qvl.45.1691446743781; Mon, 07 Aug 2023 15:19:03 -0700 (PDT) From: Kevin Alarcon Negy To: xen-devel@lists.xenproject.org Cc: Kevin Alarcon Negy , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb Date: Mon, 7 Aug 2023 18:16:10 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When building a domain, xc_domain_setmaxmem() is called with target_memkb (memory in domain config file). If a config specifies maxmem > memory, any attempts to increase the domain memory size to its max, outside of xl mem-set or xl mem-max, which already call xc_domain_setmaxmem() properly, will fail. Changed xc_domain_setmaxmem() call inside libxl__build_pre() to use max_memkb. Signed-off-by: Kevin Alarcon Negy --- tools/libs/light/libxl_dom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c index 94fef37401..16aa255aad 100644 --- a/tools/libs/light/libxl_dom.c +++ b/tools/libs/light/libxl_dom.c @@ -355,7 +355,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, return ERROR_FAIL; } - if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + size) < 0) { + if (xc_domain_setmaxmem(ctx->xch, domid, info->max_memkb + size) < 0) { LOGE(ERROR, "Couldn't set max memory"); return ERROR_FAIL; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578974.906738 (Exim 4.92) (envelope-from ) id 1qT9Hy-0001vJ-T1; Mon, 07 Aug 2023 23:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578974.906738; Mon, 07 Aug 2023 23:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hy-0001tv-O0; Mon, 07 Aug 2023 23:05:26 +0000 Received: by outflank-mailman (input) for mailman id 578974; Mon, 07 Aug 2023 23:05:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hy-0001NY-5i for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:26 +0000 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [2607:f8b0:4864:20::b2b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e45ce480-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:25 +0200 (CEST) Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-d18566dc0c1so5693097276.0 for ; Mon, 07 Aug 2023 16:05:25 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e45ce480-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449524; x=1692054324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CHNVeLQ4ERi2aiC2atfDR7Ra/O6uVctCEHn/pbNh+mQ=; b=L1Go0rwXz95r8RKjbEpMnhh6c018jiQRjrFUv0ntz442yZnhpaeW+aHqb02Xo98603 EPNoaJuJCjZc6fdKeFl/4FxJrSloFA7bUFX05fyGjegXA7V7cuLZVOde3eglcKPAc2dh 7JAUmVzhkgUSMtLYpwSzyd8Ca3OvJH/6CC+nMDpgrmjfqgC7q9SKrYP1x1rjn8+euG1c w/F3CAIitPe7XXZVoEz/F21xQq4ZfepD4AFcrR4pjaM61cX8qLF4fMMNmTw3E/GvPxLQ CGZCqn+AGAHhqM6FL6AO+cy3AaHEnYT+L7t2jnss6vAgyAEw9i6+eoE0/wpeJRdeDqZo nMqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449524; x=1692054324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CHNVeLQ4ERi2aiC2atfDR7Ra/O6uVctCEHn/pbNh+mQ=; b=JrprrdjcNyj6wYbTt0BYCsZsRkVytLud9S4nBHNgukE1ICJKsXEyto8IolKA8MKp3K vAHw0J6SMpWyzzkIsEeoKZ3OJ20adK0hJjXxbX8SQyqFKOxd7cXrpn+fBEN6TM7BoAYa +n+raJaQfY3qpUrsxHavxzyjCR6FOPuIqaUxFcr7hR/R63uBpL/XCbBgJ83jrhwK3Jop fI38QxYl9tldBZ1yuTMttG8fNilxgD0zr45FGnnbeIbz+Z5LOgWtl9vyj78po9b6neTb jWjQUd1leIUu0By1n0YFM5Bq+Kmgl/A/gvYSm80CkM5TXIrJuY8AvvYRJJ5iAfwDiuwK MQdA== X-Gm-Message-State: AOJu0Yy3FLtqJB+VCMnIvlYrOeQpa1YZJ1dfbGgIlP4gyi7hz9o5KpLd LkvZ3isax/RkHhh7RbricSg= X-Google-Smtp-Source: AGHT+IF30NcYMYJc6ATZDEFP+FAmEVcusnv37vl/vjImNQWmcJZtPuqM/aGhVMbEV/I/t7ROvZmYcQ== X-Received: by 2002:a25:ca58:0:b0:d15:9cdc:5d0c with SMTP id a85-20020a25ca58000000b00d159cdc5d0cmr11907374ybg.42.1691449524354; Mon, 07 Aug 2023 16:05:24 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" Subject: [PATCH mm-unstable v9 03/31] mm: add utility functions for ptdesc Date: Mon, 7 Aug 2023 16:04:45 -0700 Message-Id: <20230807230513.102486-4-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce utility functions setting the foundation for ptdescs. These will also assist in the splitting out of ptdesc from struct page. Functions that focus on the descriptor are prefixed with ptdesc_* while functions that focus on the pagetable are prefixed with pagetable_*. pagetable_alloc() is defined to allocate new ptdesc pages as compound pages. This is to standardize ptdescs by allowing for one allocation and one free function, in contrast to 2 allocation and 2 free functions. Signed-off-by: Vishal Moola (Oracle) --- include/asm-generic/tlb.h | 11 +++++++ include/linux/mm.h | 61 +++++++++++++++++++++++++++++++++++++++ include/linux/mm_types.h | 12 ++++++++ 3 files changed, 84 insertions(+) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index bc32a2284c56..129a3a759976 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -480,6 +480,17 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) return tlb_remove_page_size(tlb, page, PAGE_SIZE); } +static inline void tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) +{ + tlb_remove_table(tlb, pt); +} + +/* Like tlb_remove_ptdesc, but for page-like page directories. */ +static inline void tlb_remove_page_ptdesc(struct mmu_gather *tlb, struct ptdesc *pt) +{ + tlb_remove_page(tlb, ptdesc_page(pt)); +} + static inline void tlb_change_page_size(struct mmu_gather *tlb, unsigned int page_size) { diff --git a/include/linux/mm.h b/include/linux/mm.h index ec15ebc6def1..54dc176b90ea 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2806,6 +2806,57 @@ static inline pmd_t *pmd_alloc(struct mm_struct *mm, pud_t *pud, unsigned long a } #endif /* CONFIG_MMU */ +static inline struct ptdesc *virt_to_ptdesc(const void *x) +{ + return page_ptdesc(virt_to_page(x)); +} + +static inline void *ptdesc_to_virt(const struct ptdesc *pt) +{ + return page_to_virt(ptdesc_page(pt)); +} + +static inline void *ptdesc_address(const struct ptdesc *pt) +{ + return folio_address(ptdesc_folio(pt)); +} + +static inline bool pagetable_is_reserved(struct ptdesc *pt) +{ + return folio_test_reserved(ptdesc_folio(pt)); +} + +/** + * pagetable_alloc - Allocate pagetables + * @gfp: GFP flags + * @order: desired pagetable order + * + * pagetable_alloc allocates memory for page tables as well as a page table + * descriptor to describe that memory. + * + * Return: The ptdesc describing the allocated page tables. + */ +static inline struct ptdesc *pagetable_alloc(gfp_t gfp, unsigned int order) +{ + struct page *page = alloc_pages(gfp | __GFP_COMP, order); + + return page_ptdesc(page); +} + +/** + * pagetable_free - Free pagetables + * @pt: The page table descriptor + * + * pagetable_free frees the memory of all page tables described by a page + * table descriptor and the memory for the descriptor itself. + */ +static inline void pagetable_free(struct ptdesc *pt) +{ + struct page *page = ptdesc_page(pt); + + __free_pages(page, compound_order(page)); +} + #if USE_SPLIT_PTE_PTLOCKS #if ALLOC_SPLIT_PTLOCKS void __init ptlock_cache_init(void); @@ -2932,6 +2983,11 @@ static inline struct page *pmd_pgtable_page(pmd_t *pmd) return virt_to_page((void *)((unsigned long) pmd & mask)); } +static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) +{ + return page_ptdesc(pmd_pgtable_page(pmd)); +} + static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) { return ptlock_ptr(pmd_pgtable_page(pmd)); @@ -3044,6 +3100,11 @@ static inline void mark_page_reserved(struct page *page) adjust_managed_page_count(page, -1); } +static inline void free_reserved_ptdesc(struct ptdesc *pt) +{ + free_reserved_page(ptdesc_page(pt)); +} + /* * Default method to free all the __init memory into the buddy system. * The freed pages will be poisoned with pattern "poison" if it's within diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index cb47438ae17f..ea34b22b4cbf 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -467,6 +467,18 @@ TABLE_MATCH(memcg_data, pt_memcg_data); #undef TABLE_MATCH static_assert(sizeof(struct ptdesc) <= sizeof(struct page)); +#define ptdesc_page(pt) (_Generic((pt), \ + const struct ptdesc *: (const struct page *)(pt), \ + struct ptdesc *: (struct page *)(pt))) + +#define ptdesc_folio(pt) (_Generic((pt), \ + const struct ptdesc *: (const struct folio *)(pt), \ + struct ptdesc *: (struct folio *)(pt))) + +#define page_ptdesc(p) (_Generic((p), \ + const struct page *: (const struct ptdesc *)(p), \ + struct page *: (struct ptdesc *)(p))) + /* * Used for sizing the vmemmap region on some architectures */ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578972.906718 (Exim 4.92) (envelope-from ) id 1qT9Hw-0001Qn-BP; Mon, 07 Aug 2023 23:05:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578972.906718; Mon, 07 Aug 2023 23:05:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hw-0001QT-7U; Mon, 07 Aug 2023 23:05:24 +0000 Received: by outflank-mailman (input) for mailman id 578972; Mon, 07 Aug 2023 23:05:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hu-0001NY-VM for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:22 +0000 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [2607:f8b0:4864:20::b35]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2036e12-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:21 +0200 (CEST) Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-d075a831636so5455724276.3 for ; Mon, 07 Aug 2023 16:05:21 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2036e12-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449520; x=1692054320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4fjhesd7+rMkDZLOr6Kc4cG8956dLxCQQb+ozfQX3UQ=; b=OAmqT2YppB9CjfKzA6MbkbWQuHnOV3YDebJzEzMnvrYaEBnGvyiGDdIgN+UFddYCO/ oWD9ALjnIUimu69EOXrUSOl0V3EQ3lBA7Y1MYmMc666cwORz5NLJr1mYNrQUbkaEMEWb UevlkxC+fhWM5pG0rXCbCmrqQYjTZk13aOAK39qUeW68Z9nV/2KJzWOSzi4xEeDeVL48 AtQrP4AvQ44B2EZwMOx7Ik4iUJ1TvzBS0XzBfxhLsaCN0UqBFIO7A8RIwj+QqN3o+IuJ Kl4ISRZis5dwTBUexOURKgSzbeO3folaxRuVtH/QGDwOd5SIJ+mmY1APEfvTznAxJRIC w6YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449520; x=1692054320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4fjhesd7+rMkDZLOr6Kc4cG8956dLxCQQb+ozfQX3UQ=; b=OM86jMNyBPa1bJWYlsSeM0NhWNlazXWPAM6GTV/3Fpe1y2/0mZgPWIM0D2FxLmr8A5 5g5nfrX0J7iIjSvo0vISkCQ+MBmNifjI7EGAureMRr1ZkKdYd3bjomoOZ8WtRqqnLP4d y7wzEGsulAomumh4+tvK1npAgXpwAyFubLTCi9SJDRywgBN/uA7D4HOxaKMKYKFs/M+5 9w0alu8Eki6YMKI4AdfaH7dKhSYOnjhqQZ3eqWh39BiVFvzpIhcAPAV5wPBiD3sx/PEV vHT8tQvvN6ffNn7hNERrv93IfByyDVz+ABWjyB02ScYDchBMp/6Z83H+SGTGOoTcfTTt RNNw== X-Gm-Message-State: AOJu0Yx02eKS8u9D4u1RB2gxaYwlZj4qlqGf1KEJsd9QPGjYpvD+Wdsf CFX0eZTBP+bQ9DOSb455JQY= X-Google-Smtp-Source: AGHT+IEx2gi8PNow/7jZZuthXFdwcQBm4qVvrwXdHrr7o3CRr4bjoCnJoA9HiZN+Tg0Khw5JdZ/TIA== X-Received: by 2002:a25:6088:0:b0:d2c:32cb:c631 with SMTP id u130-20020a256088000000b00d2c32cbc631mr5682581ybb.27.1691449520366; Mon, 07 Aug 2023 16:05:20 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 01/31] mm: Add PAGE_TYPE_OP folio functions Date: Mon, 7 Aug 2023 16:04:43 -0700 Message-Id: <20230807230513.102486-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit No folio equivalents for page type operations have been defined, so define them for later folio conversions. Also changes the Page##uname macros to take in const struct page* since we only read the memory here. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/page-flags.h | 30 +++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 92a2063a0a23..9218028caf33 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -908,6 +908,8 @@ static inline bool is_page_hwpoison(struct page *page) #define PageType(page, flag) \ ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) +#define folio_test_type(folio, flag) \ + ((folio->page.page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) static inline int page_type_has_type(unsigned int page_type) { @@ -919,27 +921,41 @@ static inline int page_has_type(struct page *page) return page_type_has_type(page->page_type); } -#define PAGE_TYPE_OPS(uname, lname) \ -static __always_inline int Page##uname(struct page *page) \ +#define PAGE_TYPE_OPS(uname, lname, fname) \ +static __always_inline int Page##uname(const struct page *page) \ { \ return PageType(page, PG_##lname); \ } \ +static __always_inline int folio_test_##fname(const struct folio *folio)\ +{ \ + return folio_test_type(folio, PG_##lname); \ +} \ static __always_inline void __SetPage##uname(struct page *page) \ { \ VM_BUG_ON_PAGE(!PageType(page, 0), page); \ page->page_type &= ~PG_##lname; \ } \ +static __always_inline void __folio_set_##fname(struct folio *folio) \ +{ \ + VM_BUG_ON_FOLIO(!folio_test_type(folio, 0), folio); \ + folio->page.page_type &= ~PG_##lname; \ +} \ static __always_inline void __ClearPage##uname(struct page *page) \ { \ VM_BUG_ON_PAGE(!Page##uname(page), page); \ page->page_type |= PG_##lname; \ -} +} \ +static __always_inline void __folio_clear_##fname(struct folio *folio) \ +{ \ + VM_BUG_ON_FOLIO(!folio_test_##fname(folio), folio); \ + folio->page.page_type |= PG_##lname; \ +} \ /* * PageBuddy() indicates that the page is free and in the buddy system * (see mm/page_alloc.c). */ -PAGE_TYPE_OPS(Buddy, buddy) +PAGE_TYPE_OPS(Buddy, buddy, buddy) /* * PageOffline() indicates that the page is logically offline although the @@ -963,7 +979,7 @@ PAGE_TYPE_OPS(Buddy, buddy) * pages should check PageOffline() and synchronize with such drivers using * page_offline_freeze()/page_offline_thaw(). */ -PAGE_TYPE_OPS(Offline, offline) +PAGE_TYPE_OPS(Offline, offline, offline) extern void page_offline_freeze(void); extern void page_offline_thaw(void); @@ -973,12 +989,12 @@ extern void page_offline_end(void); /* * Marks pages in use as page tables. */ -PAGE_TYPE_OPS(Table, table) +PAGE_TYPE_OPS(Table, table, pgtable) /* * Marks guardpages used with debug_pagealloc. */ -PAGE_TYPE_OPS(Guard, guard) +PAGE_TYPE_OPS(Guard, guard, guard) extern bool is_free_buddy_page(struct page *page); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578971.906713 (Exim 4.92) (envelope-from ) id 1qT9Hw-0001Nl-2g; Mon, 07 Aug 2023 23:05:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578971.906713; Mon, 07 Aug 2023 23:05:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hw-0001Ne-00; Mon, 07 Aug 2023 23:05:24 +0000 Received: by outflank-mailman (input) for mailman id 578971; Mon, 07 Aug 2023 23:05:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hu-0001NS-5L for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:22 +0000 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [2607:f8b0:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e0d6092f-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:19 +0200 (CEST) Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3a3efebcc24so3747928b6e.1 for ; Mon, 07 Aug 2023 16:05:19 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0d6092f-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449518; x=1692054318; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BgGe0Il0C7dlkrriaFCN0meYItalZZUDKy884yxXSME=; b=kkOLGueMrzxHvvdT5O8JIC8nC89W6/6UqoBnx7sB0VLAWpoO0/QHm5tLARAi96zyvU EAiiieHkpJTC9s5qvXPj39j6R2OQuCyqiEOwPTIq50/LHvV7fjReDxpsCX5Ya8M70FRF Bv+KZVFj7Mytss2brk2EH7Z9tHAP9yxEVCzntaEZzdSmQz9vPa1mUTDeJlBFV79lhO4m YdB4aoA79x9pkxJ/XBt7ZG1CR58HGrAi0v/zgewNhzm8aq6TJsefwLnAAAHjOqkPytFk EiZRzEbAgPBMpklpMOtlFM2muNSx1qBww2MBrDwGN8Akv7FqeHgJ4R5d3wn1SAH6io9W CEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449518; x=1692054318; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BgGe0Il0C7dlkrriaFCN0meYItalZZUDKy884yxXSME=; b=W4xx93oF2psIoR2cg5iFDZryoHZIkl+JxNt1G2Jr1KBNTVMIOiNuF0/bc+0uNEntCx FWPLpl80gFEmakcfNYByBN56a7ipgDnDqoW/zQOlgTvsRLABkx4/4pcuPmbrbjjJ+x+c YF+WzT0M2uZdwBLmjQI3ikVX2EBKqxzzBOmpZIlIE7WWetKQxSoSOUMJTm+BU8IKp7RU GhzvNhUxL3qtGUIc8P6mbXeOvMijdH7Yd2rIfoR6XIep2eLMDGi25/kKEE/32AvBptYQ CQ43UdcXTA2xEWOsid6zl+Dz1LkNKF9ykXQl2Ga3GsmwkS3eLbMszz3zKUkm9ac8ltj5 9gXA== X-Gm-Message-State: AOJu0YwLX4CPvUuxXShbpdDV38Fnul8IhowfQY6edqyhczytu20gZ2X2 R+Hg+FO+y1UYaux8RGr7KzM= X-Google-Smtp-Source: AGHT+IHI1CCxgU6LoWPuJYJEyHtYip1YJBCUFIlnO8SlV49xsFZp+VSY6a51skH1ZTqS0RRAJqit6Q== X-Received: by 2002:aca:d12:0:b0:3a1:f237:ec62 with SMTP id 18-20020aca0d12000000b003a1f237ec62mr10346742oin.48.1691449518360; Mon, 07 Aug 2023 16:05:18 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Catalin Marinas , Huacai Chen , Geert Uytterhoeven , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , David Hildenbrand , Claudio Imbrenda , Paul Walmsley , "David S. Miller" , Richard Weinberger , Yoshinori Sato , Dave Hansen , Arnd Bergmann , Christophe Leroy Subject: [PATCH mm-unstable v9 00/31] Split ptdesc from struct page Date: Mon, 7 Aug 2023 16:04:42 -0700 Message-Id: <20230807230513.102486-1-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MM subsystem is trying to shrink struct page. This patchset introduces a memory descriptor for page table tracking - struct ptdesc. This patchset introduces ptdesc, splits ptdesc from struct page, and converts many callers of page table constructor/destructors to use ptdescs. Ptdesc is a foundation to further standardize page tables, and eventually allow for dynamic allocation of page tables independent of struct page. However, the use of pages for page table tracking is quite deeply ingrained and varied across archictectures, so there is still a lot of work to be done before that can happen. This applies cleanly onto the current unstable after dropping v8 of this series. v9: Fix build errors for NOMMU configs - trying to define ptdesc before spinlock_t and struct page were defined. Moved definition of struct ptdesc to include/linux/mm_types.h instead include/linux/pgtable.h Vishal Moola (Oracle) (31): mm: Add PAGE_TYPE_OP folio functions pgtable: create struct ptdesc mm: add utility functions for ptdesc mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc() mm: Convert ptlock_alloc() to use ptdescs mm: Convert ptlock_ptr() to use ptdescs mm: Convert pmd_ptlock_init() to use ptdescs mm: Convert ptlock_init() to use ptdescs mm: Convert pmd_ptlock_free() to use ptdescs mm: Convert ptlock_free() to use ptdescs mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} powerpc: Convert various functions to use ptdescs x86: Convert various functions to use ptdescs s390: Convert various pgalloc functions to use ptdescs mm: remove page table members from struct page pgalloc: Convert various functions to use ptdescs arm: Convert various functions to use ptdescs arm64: Convert various functions to use ptdescs csky: Convert __pte_free_tlb() to use ptdescs hexagon: Convert __pte_free_tlb() to use ptdescs loongarch: Convert various functions to use ptdescs m68k: Convert various functions to use ptdescs mips: Convert various functions to use ptdescs nios2: Convert __pte_free_tlb() to use ptdescs openrisc: Convert __pte_free_tlb() to use ptdescs riscv: Convert alloc_{pmd, pte}_late() to use ptdescs sh: Convert pte_free_tlb() to use ptdescs sparc64: Convert various functions to use ptdescs sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents um: Convert {pmd, pte}_free_tlb() to use ptdescs mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Documentation/mm/split_page_table_lock.rst | 12 +- .../zh_CN/mm/split_page_table_lock.rst | 14 +- arch/arm/include/asm/tlb.h | 12 +- arch/arm/mm/mmu.c | 7 +- arch/arm64/include/asm/tlb.h | 14 +- arch/arm64/mm/mmu.c | 7 +- arch/csky/include/asm/pgalloc.h | 4 +- arch/hexagon/include/asm/pgalloc.h | 8 +- arch/loongarch/include/asm/pgalloc.h | 27 ++-- arch/loongarch/mm/pgtable.c | 7 +- arch/m68k/include/asm/mcf_pgalloc.h | 47 +++--- arch/m68k/include/asm/sun3_pgalloc.h | 8 +- arch/m68k/mm/motorola.c | 4 +- arch/mips/include/asm/pgalloc.h | 32 ++-- arch/mips/mm/pgtable.c | 8 +- arch/nios2/include/asm/pgalloc.h | 8 +- arch/openrisc/include/asm/pgalloc.h | 8 +- arch/powerpc/mm/book3s64/mmu_context.c | 10 +- arch/powerpc/mm/book3s64/pgtable.c | 32 ++-- arch/powerpc/mm/pgtable-frag.c | 58 +++---- arch/riscv/include/asm/pgalloc.h | 8 +- arch/riscv/mm/init.c | 16 +- arch/s390/include/asm/pgalloc.h | 4 +- arch/s390/include/asm/tlb.h | 4 +- arch/s390/mm/pgalloc.c | 128 +++++++-------- arch/sh/include/asm/pgalloc.h | 9 +- arch/sparc/mm/init_64.c | 17 +- arch/sparc/mm/srmmu.c | 5 +- arch/um/include/asm/pgalloc.h | 18 +-- arch/x86/mm/pgtable.c | 47 +++--- arch/x86/xen/mmu_pv.c | 2 +- include/asm-generic/pgalloc.h | 88 +++++----- include/asm-generic/tlb.h | 11 ++ include/linux/mm.h | 151 +++++++++++++----- include/linux/mm_types.h | 97 ++++++++--- include/linux/page-flags.h | 30 +++- mm/memory.c | 8 +- 37 files changed, 585 insertions(+), 385 deletions(-) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578973.906732 (Exim 4.92) (envelope-from ) id 1qT9Hy-0001ri-ID; Mon, 07 Aug 2023 23:05:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578973.906732; Mon, 07 Aug 2023 23:05:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hy-0001rb-FQ; Mon, 07 Aug 2023 23:05:26 +0000 Received: by outflank-mailman (input) for mailman id 578973; Mon, 07 Aug 2023 23:05:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Hx-0001NS-Be for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:25 +0000 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [2607:f8b0:4864:20::112c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e340c95a-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:23 +0200 (CEST) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-586df08bba0so17842717b3.3 for ; Mon, 07 Aug 2023 16:05:23 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e340c95a-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449522; x=1692054322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a34f21esV50lWBersDNDqmppsx1/6ilmHOTavl/xl8o=; b=oFwky5a0u6RDMZneanUwrrMHlk718vp357up6yt/zwnqVYFChL1rvBLlof3lNCzIMa fNsEK2lTF1AVBptjZ1CNiCZUzihavKETKYN9gVvYQI6adZVOr5WVilhYnG1hRIdUadMS rZHYG0cY0MgC9spT/xtrGp0Z9RSAR89ub11+qTFSD/NHXR1SOhgGi5SO3dghfFZLOejg KputLo/y59tBrGZ+oHkk/Miwz+ltthb0+dR9j85/GLscklo1srlDZt2wotLowv37n6A5 LO+9uJnrNQ6hj9u600MpE0S2h1+9c+75UpIga0Og5F4xShPF0bPK2EhAmwZTlcxr2oZQ 4pBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449522; x=1692054322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a34f21esV50lWBersDNDqmppsx1/6ilmHOTavl/xl8o=; b=BgrgicLDaP3T7IRJO5yQ3XGz1Eslst0TMqX+FocUOVyVt19R1tt/TGs06kiMZGvAOG HyY/0kldXMOqje3a2EhLJ5bMyp4C90UPxVqcB95l2FtQ93IWk/J/73Zf7vT53N6vqSKQ cs6+CdQWZWPJBAHEEWhupfg/+gq4LcTe/79ELFqb6mXO8uqvcDa02VmXnPyvwUmeymjp 8LT8ZyTEkaxGt/hS4aSEdfsSKvbJpLLhdT2E1s9o7Q2genLC/Xf+djZheroeZALdYZv3 Qg+KO5YecMKCjjqlkSM5a1xTEWQjEmQFoLnuUCYnMVSdxUNmAMG1zlC2sIJzxxk1tQaY 0vHw== X-Gm-Message-State: AOJu0Yzfzi5G6vKmolH77MpsCV0J9tkDTHD68g3iKUj1U9YQDdt+iMzG gOr5mCxbgTNm+xIfZkfxiL0= X-Google-Smtp-Source: AGHT+IHp9NHIhzlo/URxP7pkQYxSTPvQNJLHOzpXCbXbudXygK+XnGEho5KZf1Qzac+pXhrvkYZIBg== X-Received: by 2002:a25:320c:0:b0:d4b:64ac:a4f7 with SMTP id y12-20020a25320c000000b00d4b64aca4f7mr9519366yby.62.1691449522393; Mon, 07 Aug 2023 16:05:22 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 02/31] pgtable: create struct ptdesc Date: Mon, 7 Aug 2023 16:04:44 -0700 Message-Id: <20230807230513.102486-3-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, page table information is stored within struct page. As part of simplifying struct page, create struct ptdesc for page table information. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm_types.h | 70 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 18c8c3d793b0..cb47438ae17f 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -397,6 +397,76 @@ FOLIO_MATCH(flags, _flags_2); FOLIO_MATCH(compound_head, _head_2); #undef FOLIO_MATCH +/** + * struct ptdesc - Memory descriptor for page tables. + * @__page_flags: Same as page flags. Unused for page tables. + * @pt_rcu_head: For freeing page table pages. + * @pt_list: List of used page tables. Used for s390 and x86. + * @_pt_pad_1: Padding that aliases with page's compound head. + * @pmd_huge_pte: Protected by ptdesc->ptl, used for THPs. + * @__page_mapping: Aliases with page->mapping. Unused for page tables. + * @pt_mm: Used for x86 pgds. + * @pt_frag_refcount: For fragmented page table tracking. Powerpc and s390 only. + * @_pt_pad_2: Padding to ensure proper alignment. + * @ptl: Lock for the page table. + * @__page_type: Same as page->page_type. Unused for page tables. + * @_refcount: Same as page refcount. Used for s390 page tables. + * @pt_memcg_data: Memcg data. Tracked for page tables here. + * + * This struct overlays struct page for now. Do not modify without a good + * understanding of the issues. + */ +struct ptdesc { + unsigned long __page_flags; + + union { + struct rcu_head pt_rcu_head; + struct list_head pt_list; + struct { + unsigned long _pt_pad_1; + pgtable_t pmd_huge_pte; + }; + }; + unsigned long __page_mapping; + + union { + struct mm_struct *pt_mm; + atomic_t pt_frag_refcount; + }; + + union { + unsigned long _pt_pad_2; +#if ALLOC_SPLIT_PTLOCKS + spinlock_t *ptl; +#else + spinlock_t ptl; +#endif + }; + unsigned int __page_type; + atomic_t _refcount; +#ifdef CONFIG_MEMCG + unsigned long pt_memcg_data; +#endif +}; + +#define TABLE_MATCH(pg, pt) \ + static_assert(offsetof(struct page, pg) == offsetof(struct ptdesc, pt)) +TABLE_MATCH(flags, __page_flags); +TABLE_MATCH(compound_head, pt_list); +TABLE_MATCH(compound_head, _pt_pad_1); +TABLE_MATCH(pmd_huge_pte, pmd_huge_pte); +TABLE_MATCH(mapping, __page_mapping); +TABLE_MATCH(pt_mm, pt_mm); +TABLE_MATCH(ptl, ptl); +TABLE_MATCH(rcu_head, pt_rcu_head); +TABLE_MATCH(page_type, __page_type); +TABLE_MATCH(_refcount, _refcount); +#ifdef CONFIG_MEMCG +TABLE_MATCH(memcg_data, pt_memcg_data); +#endif +#undef TABLE_MATCH +static_assert(sizeof(struct ptdesc) <= sizeof(struct page)); + /* * Used for sizing the vmemmap region on some architectures */ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578975.906754 (Exim 4.92) (envelope-from ) id 1qT9I2-0002R0-Dx; Mon, 07 Aug 2023 23:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578975.906754; Mon, 07 Aug 2023 23:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I2-0002Qk-8U; Mon, 07 Aug 2023 23:05:30 +0000 Received: by outflank-mailman (input) for mailman id 578975; Mon, 07 Aug 2023 23:05:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I1-0001NS-5S for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:29 +0000 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [2607:f8b0:4864:20::b33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e59917d4-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:27 +0200 (CEST) Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-d465b3d50efso2113965276.1 for ; Mon, 07 Aug 2023 16:05:27 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e59917d4-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449526; x=1692054326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fEHGQmND3TVCalts2Xn8ptU7qEA2BpyVbaRRrUVwgj4=; b=g0HQFm0Ih+ONj9bbGpN0SAoMFwZH1Hyy1LHhk9Yh2p6W+FyLdnCJ7RPABmEq6UvV+/ I0mwYg/T2n8LaliwXnPTiC9GBqIvZu49Qi1V/N0MmNRCKbxincxnUS9jodhc4yydOwRP aDjCJ2ni1nNWMxe4NQznDsxKIox8DPgLSsmzUNzOiHFpehQua0QatbJlVlVObrSVTwwk ZCujc6+dVnog1ei5Zro9QqEP+ju61k33bEcuj8U0Qr32h8YYXwWu+8Jh8gouVCHVOaNS iYc6V/t51fkGJ7ybJ/9xFdZCGVtXquz95wk1/VRVK/X9HGuHOqtxoDT8S6kl5FuAfQB5 VZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449526; x=1692054326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fEHGQmND3TVCalts2Xn8ptU7qEA2BpyVbaRRrUVwgj4=; b=FgXrCWJp0Y3F9S3eyZ7ljc+3XA1Xu8KkkPqQkw2XF14QoXVHP27U0mlwxBw3ACNY1z 828TDyxcHPSaLKQh1YTJzlapNENpAK0W4vxJK3aWnykvY+Nc0CKD4kx+La3IdW0YPuI3 JUg8fiDHeEsF6xDVh9SL2IOrCW+PENvcVjlX12Ea3v/DQy1hR0Ddiqclo32OGpv9BrVV +nFwRAbVfUr69BWaWqTDtLTe/pg15+bIN0FlnKEtD9jeXB6C4ZvtPcFKianna5La2xhz DxQFno6xdQyBPHPkSXXfsOB602bTRYcgDqel81bbkQ3wQ/h+ClJynxzX4jQm4MSEO/ci NwCA== X-Gm-Message-State: AOJu0YzOkMgZA6bRS0JkxsNq0mKjdXv08OmJgsysiEj8lORN1b11+IAD rgqr6CzYNe8apDJ2bOTZST4= X-Google-Smtp-Source: AGHT+IE5Cb4oRalCjMZQpBv2Qvb3EAIojgwuAgurnfPzGGotvhmzGY7E65P/TqlBpHFwkOco7I+V2Q== X-Received: by 2002:a25:d56:0:b0:c67:77be:9ad9 with SMTP id 83-20020a250d56000000b00c6777be9ad9mr8584839ybn.30.1691449526389; Mon, 07 Aug 2023 16:05:26 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 04/31] mm: Convert pmd_pgtable_page() callers to use pmd_ptdesc() Date: Mon, 7 Aug 2023 16:04:46 -0700 Message-Id: <20230807230513.102486-5-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Converts internal pmd_pgtable_page() callers to use pmd_ptdesc(). This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 54dc176b90ea..f6d14a5fe747 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2990,7 +2990,7 @@ static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) { - return ptlock_ptr(pmd_pgtable_page(pmd)); + return ptlock_ptr(ptdesc_page(pmd_ptdesc(pmd))); } static inline bool pmd_ptlock_init(struct page *page) @@ -3009,7 +3009,7 @@ static inline void pmd_ptlock_free(struct page *page) ptlock_free(page); } -#define pmd_huge_pte(mm, pmd) (pmd_pgtable_page(pmd)->pmd_huge_pte) +#define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) #else -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578976.906763 (Exim 4.92) (envelope-from ) id 1qT9I4-0002ja-Ko; Mon, 07 Aug 2023 23:05:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578976.906763; Mon, 07 Aug 2023 23:05:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I4-0002jR-HC; Mon, 07 Aug 2023 23:05:32 +0000 Received: by outflank-mailman (input) for mailman id 578976; Mon, 07 Aug 2023 23:05:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I2-0001NY-8E for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:30 +0000 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [2607:f8b0:4864:20::232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e6cf0228-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:29 +0200 (CEST) Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3a741f46fadso3760170b6e.0 for ; Mon, 07 Aug 2023 16:05:29 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6cf0228-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449528; x=1692054328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xo55EeeiRtqMJzFppY7LfosEC+4EKSW+Y1wbH/R/zko=; b=Q3CUliICB5ucW5n1+cyfiOVvgvAwhYv3ZRrcZge/C2xN1y7mPAKTaAhnTC4tg457In GS5yV5pdx2fEbQ6Paw0G9gZpAwxLk7uLiA6v3+SIa2nM9cjP9BC4TMrWHjABBg1TkaAc jFqkxuJnd0T58a+3c4oi7Pn3k6jPqHaryISvoGLWFF1pysLGpyRN4pc1ANxWoEwI+30p K69XzaaIceuwI5auke9JvMGfHaTbti7Lrj0CNiE6K9RZ1Cm9I6s2gJdVHKhyUn9Bc8fw XFhL6ezBClgRYA33kHsXSFVngHlISmggGRScePESZQUU6OPVK5MugkAHJIXH8vtrGuLn AiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449528; x=1692054328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xo55EeeiRtqMJzFppY7LfosEC+4EKSW+Y1wbH/R/zko=; b=LRQNeLNnX6fmipgkIfaHKrNrkFWuPpr2RypLV9jnbRGZyHxoqUh3XiR6Lqn5uII2iA zBZmzvabWzThPmWLdoXSLMkNTwWvHxxMXezTigv5q0IK81SUw83NKfj4/o8UhspmgrDn zQLiFB9eob+0Usx+EC6cwPP7g3AdIwuzD14sWl2y9RD8Xr9GzeWNc0LWcRqTgzAgAXLE YxmJRZqUcskCh1KU+SLhDajccgU5OO9x7k9bIYP8q5H0wkY+AljKVMPMPWH4bdqQW0Ys h2b8/3VAQVyXczdhr9GSiCzgyEQ1jXOlhtcbXUkz8bgvQzCiV8qJU2G79TbMKxcAwOee aXjA== X-Gm-Message-State: AOJu0Ywa71KrH2t3TX3nMBQvJnrpU2UiRzhbb+dEEv1QO1una03qHH8u TMk3bXrPSZt/CIFFaIAqsMk= X-Google-Smtp-Source: AGHT+IEuvpqTpP0gccwCdePAresyzfHn008a21Ty6dvsje55NxjSSMn6qMCPG3M+rc/X2+vc3Y/lYA== X-Received: by 2002:a54:4886:0:b0:3a7:238a:143e with SMTP id r6-20020a544886000000b003a7238a143emr10421463oic.2.1691449528538; Mon, 07 Aug 2023 16:05:28 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 05/31] mm: Convert ptlock_alloc() to use ptdescs Date: Mon, 7 Aug 2023 16:04:47 -0700 Message-Id: <20230807230513.102486-6-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 6 +++--- mm/memory.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index f6d14a5fe747..6aea8fb671f1 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2860,7 +2860,7 @@ static inline void pagetable_free(struct ptdesc *pt) #if USE_SPLIT_PTE_PTLOCKS #if ALLOC_SPLIT_PTLOCKS void __init ptlock_cache_init(void); -extern bool ptlock_alloc(struct page *page); +bool ptlock_alloc(struct ptdesc *ptdesc); extern void ptlock_free(struct page *page); static inline spinlock_t *ptlock_ptr(struct page *page) @@ -2872,7 +2872,7 @@ static inline void ptlock_cache_init(void) { } -static inline bool ptlock_alloc(struct page *page) +static inline bool ptlock_alloc(struct ptdesc *ptdesc) { return true; } @@ -2902,7 +2902,7 @@ static inline bool ptlock_init(struct page *page) * slab code uses page->slab_cache, which share storage with page->ptl. */ VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); - if (!ptlock_alloc(page)) + if (!ptlock_alloc(page_ptdesc(page))) return false; spin_lock_init(ptlock_ptr(page)); return true; diff --git a/mm/memory.c b/mm/memory.c index 956aad8aff34..3606ef72ba70 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6134,14 +6134,14 @@ void __init ptlock_cache_init(void) SLAB_PANIC, NULL); } -bool ptlock_alloc(struct page *page) +bool ptlock_alloc(struct ptdesc *ptdesc) { spinlock_t *ptl; ptl = kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); if (!ptl) return false; - page->ptl = ptl; + ptdesc->ptl = ptl; return true; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578977.906773 (Exim 4.92) (envelope-from ) id 1qT9I5-00030Z-TQ; Mon, 07 Aug 2023 23:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578977.906773; Mon, 07 Aug 2023 23:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I5-00030O-Pj; Mon, 07 Aug 2023 23:05:33 +0000 Received: by outflank-mailman (input) for mailman id 578977; Mon, 07 Aug 2023 23:05:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I5-0001NS-9q for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:33 +0000 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [2607:f8b0:4864:20::112f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8055483-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:31 +0200 (CEST) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-586bacac98aso22849667b3.2 for ; Mon, 07 Aug 2023 16:05:31 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8055483-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449530; x=1692054330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nhRFpHY9Gkw1pvDSPH6l3PWFnY0Equ+A7zpvUAn8VQI=; b=i3yG/elNSvAKIQpu+LnaQkf9aWr2RTSDWZ0bD6C1RLjObUv19W0XGp5nQ/WUHqv97k 3F3d9T+x+RGssi2D5sQsk0sbYNBszDeUty4Uz3WYnNNnOAOtum0uoqfNv64CjbJYI2vt 5W+yDKCq8CPlPCKNltLocOrpvWmx0Hi9m5r7qQtJGuYnsVLA+FFqMS9EVAuWM7bu2InG Y2OLsVw1zQ1ypzE/Wu4y0WN08yQxAbeMR9OdyOcp5d10YTszQgqk88e/T18v49VnUb5a Be+cx3DsqCXaxjSPwUg4xCjeVNpaDlwm4eDVW83zp+7fbc6H/u+IOUuZtg+F6GjbM9PA 0MXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449530; x=1692054330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nhRFpHY9Gkw1pvDSPH6l3PWFnY0Equ+A7zpvUAn8VQI=; b=F7EAUAJDnVp7o5Pa7vq9Qo2pX+eYnuRRouFa1kohlZiDWG9wgihj7YPyKRtdFj2CC1 nk9huPM0ogpNYeQJuIhifcM/sBD9k8VZxp/gLFwSJi1U5KzHB0ku1UkoB/KnEp55FCBg keLm4DUK5BuCFzKW8N/Gn4moD043YwrpJHsFGN20YDMCXBptqcWp7AcPdxogyOo8TP1G xfPHNtJuQ5ToEz7dlaPV3uOxHm9VS36blptmhgJpmSJ84jgPNc9meLSU1nXwXkP3bSO1 X5ZBYXMZJxcd8+s/mbAshUnpl0XqJl8NFoaskZXV1sSe8gNWbsnFaoiMQsaCszXF5K1w bDOw== X-Gm-Message-State: AOJu0Yyr1GD2mIpTYDPhzeNXC7NusdYxIDMHXdxfmqwqLWcAR9cwcuG7 4UxmMy3z9w5sTpzsdKO/w4c= X-Google-Smtp-Source: AGHT+IH0ZW2oaxdE5zMBv/D24ibnqwE3DqpI9lmZfRLWAk1KAOJsXcFTPw6pcD+tvJtRgJ78+52WaA== X-Received: by 2002:a25:fc3:0:b0:c21:4bc4:331d with SMTP id 186-20020a250fc3000000b00c214bc4331dmr6829336ybp.43.1691449530544; Mon, 07 Aug 2023 16:05:30 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 06/31] mm: Convert ptlock_ptr() to use ptdescs Date: Mon, 7 Aug 2023 16:04:48 -0700 Message-Id: <20230807230513.102486-7-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/x86/xen/mmu_pv.c | 2 +- include/linux/mm.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index e0a975165de7..8796ec310483 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -667,7 +667,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm) spinlock_t *ptl = NULL; #if USE_SPLIT_PTE_PTLOCKS - ptl = ptlock_ptr(page); + ptl = ptlock_ptr(page_ptdesc(page)); spin_lock_nest_lock(ptl, &mm->page_table_lock); #endif diff --git a/include/linux/mm.h b/include/linux/mm.h index 6aea8fb671f1..bc82a64e5f01 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2863,9 +2863,9 @@ void __init ptlock_cache_init(void); bool ptlock_alloc(struct ptdesc *ptdesc); extern void ptlock_free(struct page *page); -static inline spinlock_t *ptlock_ptr(struct page *page) +static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) { - return page->ptl; + return ptdesc->ptl; } #else /* ALLOC_SPLIT_PTLOCKS */ static inline void ptlock_cache_init(void) @@ -2881,15 +2881,15 @@ static inline void ptlock_free(struct page *page) { } -static inline spinlock_t *ptlock_ptr(struct page *page) +static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) { - return &page->ptl; + return &ptdesc->ptl; } #endif /* ALLOC_SPLIT_PTLOCKS */ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) { - return ptlock_ptr(pmd_page(*pmd)); + return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); } static inline bool ptlock_init(struct page *page) @@ -2904,7 +2904,7 @@ static inline bool ptlock_init(struct page *page) VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); if (!ptlock_alloc(page_ptdesc(page))) return false; - spin_lock_init(ptlock_ptr(page)); + spin_lock_init(ptlock_ptr(page_ptdesc(page))); return true; } @@ -2990,7 +2990,7 @@ static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) { - return ptlock_ptr(ptdesc_page(pmd_ptdesc(pmd))); + return ptlock_ptr(pmd_ptdesc(pmd)); } static inline bool pmd_ptlock_init(struct page *page) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578978.906783 (Exim 4.92) (envelope-from ) id 1qT9I8-0003Kw-9U; Mon, 07 Aug 2023 23:05:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578978.906783; Mon, 07 Aug 2023 23:05:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I8-0003Kj-58; Mon, 07 Aug 2023 23:05:36 +0000 Received: by outflank-mailman (input) for mailman id 578978; Mon, 07 Aug 2023 23:05:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I7-0001NS-AQ for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:35 +0000 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [2607:f8b0:4864:20::b33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e94c9ecc-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:33 +0200 (CEST) Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-d3563cb41e9so4205371276.0 for ; Mon, 07 Aug 2023 16:05:33 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e94c9ecc-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449532; x=1692054332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dV51lKtiOhMWQgAl7GNvRpOxJtkn3o5Ia4Rm5PKGOL0=; b=WW7U9RxJoy+3YY4y3qa+Z9OsxlwmyOU3wMBaX5rDPLFmIEHt/X6v4NdYOpBq8PRkh5 HGAvbPPuVPcaXp+7bIkcS5zKLOts7aoRAq2rmpfhl809GhQ5Z7qhyD2D1O9jUw02JT8D ByQrQ+74LtD1rxejz5iV5Ji3t3biqjBaLILP+cGmcXMABNbKMRqAqcPv+Q5eVbDOwvco pnySxrcubM/hR4SWo6309aJr0ghUYXqxorm9LprpxBDG4pKG7rw8FnMSIxuCIl+L3G3f pQ7sJFVehZ1e4LudKLyLwUTD+K2Hcr+cYbBqgmDPIUau/hEmU0pgvAzvLPGNFfNzyEIP WwxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449532; x=1692054332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dV51lKtiOhMWQgAl7GNvRpOxJtkn3o5Ia4Rm5PKGOL0=; b=abKTO7xtTv/TAci8e+m/adWGyPecJ6aHM0rcMpQfavtvLZL3ES6pQWTwu/1SkHkLbq xL0jGjhGwrAB1p4yy4oOY4RG82GsTHVaE4+kWuULp4IPhPiadHA+MoJqFo9TvDVy3uSO TU/Lk8QLQBApe5fffKkCghCf9Nqghj1fkeOqxv1pC7D/Jr50saM+X5hejhju9PfxRWFN +p9VsOw3jo7y3t/AkW8AC05fHF6kmto/0EzdUQmDNk5bzUn0wW1gwpG62l3zllI+2f0/ wmv924+6NhMoOBXD2fZf713YweBsVFcPjLPxOoO9bnRNqNdNKYVhqCSDcGqnrozVQ0x9 7Zlw== X-Gm-Message-State: AOJu0YwmDhs6EmOtxKr0VbPIJLZEqbeHCBHOCkpJNJXh6ksfLioVnobT DKO+qOovz+VtZtFMl+Gx+qs= X-Google-Smtp-Source: AGHT+IEvrDCY+UE05HZYU4gf4n6Ovk9myxbAlbrTcNmkwiJKi0vLSKG9giGoSfLWvI4ILhQ42gUDlQ== X-Received: by 2002:a25:bd7:0:b0:d14:6e28:69a4 with SMTP id 206-20020a250bd7000000b00d146e2869a4mr9317696ybl.29.1691449532541; Mon, 07 Aug 2023 16:05:32 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 07/31] mm: Convert pmd_ptlock_init() to use ptdescs Date: Mon, 7 Aug 2023 16:04:49 -0700 Message-Id: <20230807230513.102486-8-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index bc82a64e5f01..040982fe9063 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2993,12 +2993,12 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) return ptlock_ptr(pmd_ptdesc(pmd)); } -static inline bool pmd_ptlock_init(struct page *page) +static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE - page->pmd_huge_pte = NULL; + ptdesc->pmd_huge_pte = NULL; #endif - return ptlock_init(page); + return ptlock_init(ptdesc_page(ptdesc)); } static inline void pmd_ptlock_free(struct page *page) @@ -3018,7 +3018,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) return &mm->page_table_lock; } -static inline bool pmd_ptlock_init(struct page *page) { return true; } +static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { return true; } static inline void pmd_ptlock_free(struct page *page) {} #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) @@ -3034,7 +3034,7 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) static inline bool pgtable_pmd_page_ctor(struct page *page) { - if (!pmd_ptlock_init(page)) + if (!pmd_ptlock_init(page_ptdesc(page))) return false; __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578979.906793 (Exim 4.92) (envelope-from ) id 1qT9I9-0003d9-Ko; Mon, 07 Aug 2023 23:05:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578979.906793; Mon, 07 Aug 2023 23:05:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I9-0003bk-FL; Mon, 07 Aug 2023 23:05:37 +0000 Received: by outflank-mailman (input) for mailman id 578979; Mon, 07 Aug 2023 23:05:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9I8-0001NY-59 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:36 +0000 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [2607:f8b0:4864:20::b2b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ea6bfc27-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:35 +0200 (CEST) Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-d16889b3e93so5396096276.0 for ; Mon, 07 Aug 2023 16:05:35 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea6bfc27-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449534; x=1692054334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qSt61pcnVgNBhKAHMe8eO3a6G9ChrNL9Px0NKJkznSI=; b=doFuHRFvbyMJN61tPnMQYXox+6stb50QdP4/3C93sFPuLhCWwxu1z+tfNZJ4b6Wpl+ E3E2D7c/fVsu9NK1PuuCIKOAph+/dD0UwiupTdpLzihtqamhwaXNn1+eSFxg36XE1nAW 9YCYbT+6Netay+dE7igP1FbsCv8QYjddLC3kVasHRyFjUe3vhlHJ5pPzAaFOmunT+EhT TypcY3libiW+1xTSZsvLq3CfCOXA2FWQUiU+MigDUHm3gt0TV6nV3mcKzhVGZgr0Qhni PeipZMs+ho2QZuOrtBA9RQFaTSU/S0o5wnK6eQ2hY8zhXlVshk/VfS/NqhE6JdbcRNTR jImw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449534; x=1692054334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qSt61pcnVgNBhKAHMe8eO3a6G9ChrNL9Px0NKJkznSI=; b=K94Mry71ux0NO8jTUNShcaG6ivygqLQhOgBo+6Dnz4oX74yrVP38Sk1E5AcMvtUyfY 8oxGoYzbiD5ZGrdmB6V+L0OKl0x5n+K4z8dmzanQCpm9mix9TbyLdJNx65qK62UB1gTS OBN8L09WVoX8LnRSomMGAhg3ZxgBpZR0AHyGbSIgVzcgpm1fDr4F0zxLybEuZkTk6ruJ 3xRWhILAOgmPL7YHUqIrW6Ua2WPPNZyTzNOu7lL8xL+2uD1VgzkMfbYXl2b2ybBwCwOm 2+OIbgJ/A/KI/R+3zjdNRAC9b7+a3lYr5rwnO+iOxyRm2AVd3gauCdbCJIE5pmXkBOmn 1ZgA== X-Gm-Message-State: AOJu0Yzpf2dLuV+gMkYRPLgjqWOWBk3j531W01drRzSEi2IshAnG1qVM uBiOk9dQbRKY1hdICZhiLq4= X-Google-Smtp-Source: AGHT+IH78clSYv8jjRwrTCz7hdEyV6ONxxFaBIBEI75jS+XpTOJin8WaSgmj5CyKgW8Moog6FuLvdA== X-Received: by 2002:a25:4c86:0:b0:d0a:d15b:3b0f with SMTP id z128-20020a254c86000000b00d0ad15b3b0fmr10002278yba.33.1691449534448; Mon, 07 Aug 2023 16:05:34 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 08/31] mm: Convert ptlock_init() to use ptdescs Date: Mon, 7 Aug 2023 16:04:50 -0700 Message-Id: <20230807230513.102486-9-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 040982fe9063..13947b17f25e 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2892,7 +2892,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) return ptlock_ptr(page_ptdesc(pmd_page(*pmd))); } -static inline bool ptlock_init(struct page *page) +static inline bool ptlock_init(struct ptdesc *ptdesc) { /* * prep_new_page() initialize page->private (and therefore page->ptl) @@ -2901,10 +2901,10 @@ static inline bool ptlock_init(struct page *page) * It can happen if arch try to use slab for page table allocation: * slab code uses page->slab_cache, which share storage with page->ptl. */ - VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); - if (!ptlock_alloc(page_ptdesc(page))) + VM_BUG_ON_PAGE(*(unsigned long *)&ptdesc->ptl, ptdesc_page(ptdesc)); + if (!ptlock_alloc(ptdesc)) return false; - spin_lock_init(ptlock_ptr(page_ptdesc(page))); + spin_lock_init(ptlock_ptr(ptdesc)); return true; } @@ -2917,13 +2917,13 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) return &mm->page_table_lock; } static inline void ptlock_cache_init(void) {} -static inline bool ptlock_init(struct page *page) { return true; } +static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } static inline void ptlock_free(struct page *page) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ static inline bool pgtable_pte_page_ctor(struct page *page) { - if (!ptlock_init(page)) + if (!ptlock_init(page_ptdesc(page))) return false; __SetPageTable(page); inc_lruvec_page_state(page, NR_PAGETABLE); @@ -2998,7 +2998,7 @@ static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) #ifdef CONFIG_TRANSPARENT_HUGEPAGE ptdesc->pmd_huge_pte = NULL; #endif - return ptlock_init(ptdesc_page(ptdesc)); + return ptlock_init(ptdesc); } static inline void pmd_ptlock_free(struct page *page) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578980.906803 (Exim 4.92) (envelope-from ) id 1qT9IB-000416-6Y; Mon, 07 Aug 2023 23:05:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578980.906803; Mon, 07 Aug 2023 23:05:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IB-000401-2D; Mon, 07 Aug 2023 23:05:39 +0000 Received: by outflank-mailman (input) for mailman id 578980; Mon, 07 Aug 2023 23:05:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IA-0001NY-4o for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:38 +0000 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [2607:f8b0:4864:20::b2e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb8edc84-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:37 +0200 (CEST) Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-d07c535377fso5458594276.1 for ; Mon, 07 Aug 2023 16:05:37 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb8edc84-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449536; x=1692054336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dL6AQetgHURU9peF5jMm+1QPkGPdtGd2X/zb9xq5Tzw=; b=ipvaU8x/4/BvbPbL1JSP5UKyrvOXFJin5b02qnpk0+g2WqZ4eJ+PO+ktIgA+6wNoSm aaVqpEKee+fuDlQKCW2FfgF7SgMBsBqJt3e1nMH+AXWpM2n5M5vJ6ySCVS0SQ6gxdoiI D+Vz3KZ0hmlesWiSA/IngK6t1yMsQcmq6H5TLlpCkzZtF+sAfosr9KpkynHtpBKwq7VS GLoFH093mbAem14YxFU+jWVsiLanVvmYVX25waYX2eZafZZIUXESTosUd2Oq+mhwT6KE DFWO6vdcB84fh2CYUtre/BRV5qGnoLxfl2hREphZC8Q8m4iPBusEVSAtzxRpIAKFC+MO xrMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449536; x=1692054336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dL6AQetgHURU9peF5jMm+1QPkGPdtGd2X/zb9xq5Tzw=; b=a9cYjC2WkM1nHf85f0/h5zCuaBv0wOxWmJu3tltiWeDTRbC/9VezRjiWrlJtEGqxt9 sWmK4PJTnIU9QdDTRkMGMY/uoYIS86rZ1lsnlwsW4lBBQrYHoZ0QoXmN9qZFNOqcCVsl vzxUEKC2r9hdDbAmc4mnq8mt4odg+JJWRbWoPIRfk2apxV4snEVA0FoCYnbmeE/pswrJ xNkV0XM+dIWSy8+ryz5jELWxvfoDy2KQdtJNJTBgIfJ7qO296Cb8qn2uCDmPGSvyYb+Z koz/OZcihSYeMbckLYNBee+9JjJ9z4TQraBMAIRYeWZ2Jmw39mYYRPxV6+BGsZY2fGLX sQ1g== X-Gm-Message-State: AOJu0Yz+41lyz1XUEGTHouCry56ZFWwPCi59CC9iJ0a4mOBf7tHaz8V7 XMyC1ulMyS041cg8tZ11bIM= X-Google-Smtp-Source: AGHT+IEvxj9+7jMT4q6zEzLr5Igqcb/a7jma6HML30e7U0QAJ8Bd3AhAgHjN0UpvuwRaK7JUtc9G0w== X-Received: by 2002:a25:738b:0:b0:d09:7f94:6ea3 with SMTP id o133-20020a25738b000000b00d097f946ea3mr11456718ybc.65.1691449536455; Mon, 07 Aug 2023 16:05:36 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 09/31] mm: Convert pmd_ptlock_free() to use ptdescs Date: Mon, 7 Aug 2023 16:04:51 -0700 Message-Id: <20230807230513.102486-10-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 13947b17f25e..aa6f77c71453 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -3001,12 +3001,12 @@ static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) return ptlock_init(ptdesc); } -static inline void pmd_ptlock_free(struct page *page) +static inline void pmd_ptlock_free(struct ptdesc *ptdesc) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE - VM_BUG_ON_PAGE(page->pmd_huge_pte, page); + VM_BUG_ON_PAGE(ptdesc->pmd_huge_pte, ptdesc_page(ptdesc)); #endif - ptlock_free(page); + ptlock_free(ptdesc_page(ptdesc)); } #define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) @@ -3019,7 +3019,7 @@ static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) } static inline bool pmd_ptlock_init(struct ptdesc *ptdesc) { return true; } -static inline void pmd_ptlock_free(struct page *page) {} +static inline void pmd_ptlock_free(struct ptdesc *ptdesc) {} #define pmd_huge_pte(mm, pmd) ((mm)->pmd_huge_pte) @@ -3043,7 +3043,7 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) static inline void pgtable_pmd_page_dtor(struct page *page) { - pmd_ptlock_free(page); + pmd_ptlock_free(page_ptdesc(page)); __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578982.906813 (Exim 4.92) (envelope-from ) id 1qT9ID-0004SR-G3; Mon, 07 Aug 2023 23:05:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578982.906813; Mon, 07 Aug 2023 23:05:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9ID-0004S6-AQ; Mon, 07 Aug 2023 23:05:41 +0000 Received: by outflank-mailman (input) for mailman id 578982; Mon, 07 Aug 2023 23:05:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IC-0001NY-3W for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:40 +0000 Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [2607:f8b0:4864:20::b33]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ecb60116-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:39 +0200 (CEST) Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-cfcebc33d04so5106379276.2 for ; Mon, 07 Aug 2023 16:05:39 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecb60116-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449538; x=1692054338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rO3hRWVBo6Y9vRkkphMYimV7kP+YdlMpTAZzrYQT330=; b=Xru6G6uiZe/OuMY5nm6nRGhKKZT+cMjFr3ywYmjJVtK6bJQBvGQe4lb67TeNeIpRR1 vU6ROYd5sljoul9DQ182dcYNUtIjSE0g9ryH9BBQnyweF2i9F3a0tNr39lnubSpEzEzx D9dlEQ3L7Z6V9tMyRKOuG3jp1VK2LuxNqNXMsa/r8JF3v1c5M1/VvDBiBALX9JEbGcjF BYD5zunEjYtVpsA/+5S4bzMaVg5Xls19tVXYJS5Y3GWWrR9cQxHo66Iare/M20jic/7P QScGaLnDnqCa6oKmv6Q3fNTRqyTkrnI7S8dkrsktkT3ibHnZIlamT/1RRAzAV+HV4mnX P1Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449538; x=1692054338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rO3hRWVBo6Y9vRkkphMYimV7kP+YdlMpTAZzrYQT330=; b=TlaFGxxMnBx4A6LHj+GrnTqYaq1fqn9gJW0HcY69T54NwwcwdRIRXsmlvDXMwQwKta xV9kI1gWsl6AaBIAsmbmU4bYmXQ3VX0a3AGXob4TBjDA40tPwELoYfXSiEM4+DgiQjkx 4ANd6EHSoXGtLgjeJutM5IWzeHoQoIdj/fTrWXb7nUPemqtF8tQFtxrV5HXmhCB6v0BK WjoAo/uColVVvU4mukfceOLZmR/IB6btYIYgEexkRoh7OInE+thia7FSsHW2nQ1ukXfB 3oaahezIOSF8OoTHqtlT8f8fQrlKRQuO7/VU6fozji+jj2QHdC3PE4I6K3IQ7X81AtBt E6LA== X-Gm-Message-State: AOJu0Yz7/dM8vopuWIXYbWDU000Hivn7Pc9yuvQFb6nkM6QlKXJBQKv2 vX0dTaaMc5d+UKgScUiwQaA= X-Google-Smtp-Source: AGHT+IFQ1sRvJZAfCY+VUYCk9fa9DxUgaBX+22XersqRcqzji4wcHGi6IN2gPixXkKaq4oGn1g4mnw== X-Received: by 2002:a25:8001:0:b0:d0f:ea4b:1dff with SMTP id m1-20020a258001000000b00d0fea4b1dffmr9335056ybk.8.1691449538435; Mon, 07 Aug 2023 16:05:38 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 10/31] mm: Convert ptlock_free() to use ptdescs Date: Mon, 7 Aug 2023 16:04:52 -0700 Message-Id: <20230807230513.102486-11-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +++++----- mm/memory.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index aa6f77c71453..94984d49ab01 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2861,7 +2861,7 @@ static inline void pagetable_free(struct ptdesc *pt) #if ALLOC_SPLIT_PTLOCKS void __init ptlock_cache_init(void); bool ptlock_alloc(struct ptdesc *ptdesc); -extern void ptlock_free(struct page *page); +void ptlock_free(struct ptdesc *ptdesc); static inline spinlock_t *ptlock_ptr(struct ptdesc *ptdesc) { @@ -2877,7 +2877,7 @@ static inline bool ptlock_alloc(struct ptdesc *ptdesc) return true; } -static inline void ptlock_free(struct page *page) +static inline void ptlock_free(struct ptdesc *ptdesc) { } @@ -2918,7 +2918,7 @@ static inline spinlock_t *pte_lockptr(struct mm_struct *mm, pmd_t *pmd) } static inline void ptlock_cache_init(void) {} static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } -static inline void ptlock_free(struct page *page) {} +static inline void ptlock_free(struct ptdesc *ptdesc) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ static inline bool pgtable_pte_page_ctor(struct page *page) @@ -2932,7 +2932,7 @@ static inline bool pgtable_pte_page_ctor(struct page *page) static inline void pgtable_pte_page_dtor(struct page *page) { - ptlock_free(page); + ptlock_free(page_ptdesc(page)); __ClearPageTable(page); dec_lruvec_page_state(page, NR_PAGETABLE); } @@ -3006,7 +3006,7 @@ static inline void pmd_ptlock_free(struct ptdesc *ptdesc) #ifdef CONFIG_TRANSPARENT_HUGEPAGE VM_BUG_ON_PAGE(ptdesc->pmd_huge_pte, ptdesc_page(ptdesc)); #endif - ptlock_free(ptdesc_page(ptdesc)); + ptlock_free(ptdesc); } #define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) diff --git a/mm/memory.c b/mm/memory.c index 3606ef72ba70..d003076b218d 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6145,8 +6145,8 @@ bool ptlock_alloc(struct ptdesc *ptdesc) return true; } -void ptlock_free(struct page *page) +void ptlock_free(struct ptdesc *ptdesc) { - kmem_cache_free(page_ptl_cachep, page->ptl); + kmem_cache_free(page_ptl_cachep, ptdesc->ptl); } #endif -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578984.906823 (Exim 4.92) (envelope-from ) id 1qT9IG-00052f-PY; Mon, 07 Aug 2023 23:05:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578984.906823; Mon, 07 Aug 2023 23:05:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IG-00052K-L2; Mon, 07 Aug 2023 23:05:44 +0000 Received: by outflank-mailman (input) for mailman id 578984; Mon, 07 Aug 2023 23:05:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IF-0001NS-8R for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:43 +0000 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [2607:f8b0:4864:20::b31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id edededa8-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:41 +0200 (CEST) Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-d0728058651so5368050276.1 for ; Mon, 07 Aug 2023 16:05:41 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edededa8-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449540; x=1692054340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XBjJ/e2vPX4j94DTkAO9XQqqbwuOMqryYrtpznFEgGY=; b=aasPlAtm5Pcd0yp6duryP473IaipZJS0bWZ4Z8XEGwFlj43AOqpIIC6FhirKlPve9C F1vUSIrLW1oYFLLrLilYCJzqaLsw1rmRGBb+Z5eKzeBY0HVz8f1HGASCxMQ2qqkeDt1/ NUUsoQwBHF6NBLlkSQcHcy9LC4jgcOdJmOlAy/6h3iyfEMCFdLo7Fk1Bu4KWGLpiNsE1 KzSFxNl6DRl46MY838sL7FF+wIJkc1YVhg5kJdFIQoWHplt5NksftMQPYk7wCakllMw/ EceX3OKTdEGMJ4GdFrkX3TffvwqD7i/AFN0kCIklmMB/JORnudk4URx0r/bcoO+F1Yl1 rD5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449540; x=1692054340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XBjJ/e2vPX4j94DTkAO9XQqqbwuOMqryYrtpznFEgGY=; b=BBZUSTU7W1WR6A6nf449CfUCZjQ4ATR61h5Ryl5wj5XrCR37pZKbbx4Gq7bPcjQ59U N5PcQsFl82X4KSyUi/47oEljgg9fC5fjBAVbIS4sUWDAYifYyUuVKcnD7455Zw8ajUh1 VAz05pSqYPwlD09RgQY2yUzYPFa+UrefltaqRmQL6arUtgCO78aqcA26wm+LcDf8YBSL 93vXFFqOi/XRlNPfnmQk9tou68JLpXs75mTFQDfI4YOqm0E5YLc0XyxtKnzyjSMXnt/V w3YpZwVVURxYlDNf/l31Wo+O9iqywfQMx2XBi03wBuqeHbmFipVeVPnRXAjzfiUkOJz3 kx/Q== X-Gm-Message-State: AOJu0YxP/tpTxkDKwXmlNB9Qr9CG8WwQsUURz0LcT8mfi4gt482nV8st oyi2gSYBLMe+FhuEQI1OdGU= X-Google-Smtp-Source: AGHT+IEw8LfaxYvauKrU5QG8lz4qzDMmMrsNvSvomqfZDfXz4mmURgWJbxHCG9LEh9h57v96do4e4w== X-Received: by 2002:a25:8251:0:b0:cb9:41ad:8938 with SMTP id d17-20020a258251000000b00cb941ad8938mr12329076ybn.3.1691449540449; Mon, 07 Aug 2023 16:05:40 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 11/31] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor} Date: Mon, 7 Aug 2023 16:04:53 -0700 Message-Id: <20230807230513.102486-12-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create pagetable_pte_ctor(), pagetable_pmd_ctor(), pagetable_pte_dtor(), and pagetable_pmd_dtor() and make the original pgtable constructor/destructors wrappers. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 56 ++++++++++++++++++++++++++++++++++------------ 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 94984d49ab01..6310e0c59efe 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2921,20 +2921,34 @@ static inline bool ptlock_init(struct ptdesc *ptdesc) { return true; } static inline void ptlock_free(struct ptdesc *ptdesc) {} #endif /* USE_SPLIT_PTE_PTLOCKS */ -static inline bool pgtable_pte_page_ctor(struct page *page) +static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc) { - if (!ptlock_init(page_ptdesc(page))) + struct folio *folio = ptdesc_folio(ptdesc); + + if (!ptlock_init(ptdesc)) return false; - __SetPageTable(page); - inc_lruvec_page_state(page, NR_PAGETABLE); + __folio_set_pgtable(folio); + lruvec_stat_add_folio(folio, NR_PAGETABLE); return true; } +static inline bool pgtable_pte_page_ctor(struct page *page) +{ + return pagetable_pte_ctor(page_ptdesc(page)); +} + +static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) +{ + struct folio *folio = ptdesc_folio(ptdesc); + + ptlock_free(ptdesc); + __folio_clear_pgtable(folio); + lruvec_stat_sub_folio(folio, NR_PAGETABLE); +} + static inline void pgtable_pte_page_dtor(struct page *page) { - ptlock_free(page_ptdesc(page)); - __ClearPageTable(page); - dec_lruvec_page_state(page, NR_PAGETABLE); + pagetable_pte_dtor(page_ptdesc(page)); } pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp); @@ -3032,20 +3046,34 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd) return ptl; } -static inline bool pgtable_pmd_page_ctor(struct page *page) +static inline bool pagetable_pmd_ctor(struct ptdesc *ptdesc) { - if (!pmd_ptlock_init(page_ptdesc(page))) + struct folio *folio = ptdesc_folio(ptdesc); + + if (!pmd_ptlock_init(ptdesc)) return false; - __SetPageTable(page); - inc_lruvec_page_state(page, NR_PAGETABLE); + __folio_set_pgtable(folio); + lruvec_stat_add_folio(folio, NR_PAGETABLE); return true; } +static inline bool pgtable_pmd_page_ctor(struct page *page) +{ + return pagetable_pmd_ctor(page_ptdesc(page)); +} + +static inline void pagetable_pmd_dtor(struct ptdesc *ptdesc) +{ + struct folio *folio = ptdesc_folio(ptdesc); + + pmd_ptlock_free(ptdesc); + __folio_clear_pgtable(folio); + lruvec_stat_sub_folio(folio, NR_PAGETABLE); +} + static inline void pgtable_pmd_page_dtor(struct page *page) { - pmd_ptlock_free(page_ptdesc(page)); - __ClearPageTable(page); - dec_lruvec_page_state(page, NR_PAGETABLE); + pagetable_pmd_dtor(page_ptdesc(page)); } /* -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578986.906832 (Exim 4.92) (envelope-from ) id 1qT9II-0005PL-7u; Mon, 07 Aug 2023 23:05:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578986.906832; Mon, 07 Aug 2023 23:05:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9II-0005P6-26; Mon, 07 Aug 2023 23:05:46 +0000 Received: by outflank-mailman (input) for mailman id 578986; Mon, 07 Aug 2023 23:05:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IG-0001NY-Ll for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:44 +0000 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [2607:f8b0:4864:20::112d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ef2d821a-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:43 +0200 (CEST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-5844bb9923eso57905667b3.0 for ; Mon, 07 Aug 2023 16:05:43 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef2d821a-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449542; x=1692054342; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e+EvCLSRHEjRMcrqyzlI7nWwK61/1iPQ6CBOQpr2Pw8=; b=rLWnqjmP7sRfTz6wua9GaZP1/2cNvCnICKswTRMyXqBTRclhVFHiAas9xRu3tkibLy LYukTLEi8jX6/fTdkYMDCO0fnSCk16sHemMQ8U4gAHGrsaCCSIeDnfo7DvoQ9Gwt06kp MQCzbSxxIL1LtUE5+14WQYgbc9OVNCm8xO/RCzTEhtXZ96UEc4E8RE98LQSraVgUZ0Fd 6Fmm1G6c9NfTk9/aagcsWCP/kTtnrTjipyvOL5pIzWA4ypsawqK6CLLX9Fl4WFHyAZw8 htPBGGPp0caQCANc0qVpI3FsKnfIB5iUg+Zk2hPevHBBDnF1Z5MJXUMKGZAmqsL9A8b7 0bsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449542; x=1692054342; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e+EvCLSRHEjRMcrqyzlI7nWwK61/1iPQ6CBOQpr2Pw8=; b=EG/wwZatjA22vLqAFrrH3bO1msmzvVF+VfsL/kNN2bk/aJqhtI+a5BZa/sS4XgVzZs Qg2KdXeb0AEvpyIbVLTUJAcU1LDPpjPrctnwkVhHKvT8rcqiL9nLcBbcKZ9DCNkH74FA CTPeglisLdRi7vPinOb2ECZJYreHY3HgzwNKS+9+WoQRFNS3FUEuBqIjJ9bG9P+Fl7A8 LeDvCaPIscOHAwzDlvyxQqyrEdiklvaL+Ny3KnFBHBm+8Sdc+cZTz//T3a7K5F5tkSbW 1P21Xw25n+hWleLJ31pZtedcdfjlL+/bBCs/3sqbVILViSa17tDrAu/J9ycKFTS0bHId 88MQ== X-Gm-Message-State: AOJu0YwHLSiMcNibn55R9UyHT6IBdkoi58YzJ2qjhaX0Piy0zq1sRkOk vpxUDjZ07e3+M90bk9AkWHQ= X-Google-Smtp-Source: AGHT+IHORUBL3sdiWUXupMQ7Z7czVcAhY9T4N3g/NpV+o0AxUxjNA5Mmjsd58yiAAKDk1m0/Oelmjw== X-Received: by 2002:a25:ba84:0:b0:d11:d704:dd7f with SMTP id s4-20020a25ba84000000b00d11d704dd7fmr11892403ybg.32.1691449542531; Mon, 07 Aug 2023 16:05:42 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Christophe Leroy , Mike Rapoport Subject: [PATCH mm-unstable v9 12/31] powerpc: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:04:54 -0700 Message-Id: <20230807230513.102486-13-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/powerpc/mm/book3s64/mmu_context.c | 10 ++--- arch/powerpc/mm/book3s64/pgtable.c | 32 +++++++------- arch/powerpc/mm/pgtable-frag.c | 58 +++++++++++++------------- 3 files changed, 50 insertions(+), 50 deletions(-) diff --git a/arch/powerpc/mm/book3s64/mmu_context.c b/arch/powerpc/mm/book3s64/mmu_context.c index c766e4c26e42..1715b07c630c 100644 --- a/arch/powerpc/mm/book3s64/mmu_context.c +++ b/arch/powerpc/mm/book3s64/mmu_context.c @@ -246,15 +246,15 @@ static void destroy_contexts(mm_context_t *ctx) static void pmd_frag_destroy(void *pmd_frag) { int count; - struct page *page; + struct ptdesc *ptdesc; - page = virt_to_page(pmd_frag); + ptdesc = virt_to_ptdesc(pmd_frag); /* drop all the pending references */ count = ((unsigned long)pmd_frag & ~PAGE_MASK) >> PMD_FRAG_SIZE_SHIFT; /* We allow PTE_FRAG_NR fragments from a PTE page */ - if (atomic_sub_and_test(PMD_FRAG_NR - count, &page->pt_frag_refcount)) { - pgtable_pmd_page_dtor(page); - __free_page(page); + if (atomic_sub_and_test(PMD_FRAG_NR - count, &ptdesc->pt_frag_refcount)) { + pagetable_pmd_dtor(ptdesc); + pagetable_free(ptdesc); } } diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64/pgtable.c index 75b938268b04..1498ccd08367 100644 --- a/arch/powerpc/mm/book3s64/pgtable.c +++ b/arch/powerpc/mm/book3s64/pgtable.c @@ -384,22 +384,22 @@ static pmd_t *get_pmd_from_cache(struct mm_struct *mm) static pmd_t *__alloc_for_pmdcache(struct mm_struct *mm) { void *ret = NULL; - struct page *page; + struct ptdesc *ptdesc; gfp_t gfp = GFP_KERNEL_ACCOUNT | __GFP_ZERO; if (mm == &init_mm) gfp &= ~__GFP_ACCOUNT; - page = alloc_page(gfp); - if (!page) + ptdesc = pagetable_alloc(gfp, 0); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(page)) { - __free_pages(page, 0); + if (!pagetable_pmd_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - atomic_set(&page->pt_frag_refcount, 1); + atomic_set(&ptdesc->pt_frag_refcount, 1); - ret = page_address(page); + ret = ptdesc_address(ptdesc); /* * if we support only one fragment just return the * allocated page. @@ -409,12 +409,12 @@ static pmd_t *__alloc_for_pmdcache(struct mm_struct *mm) spin_lock(&mm->page_table_lock); /* - * If we find pgtable_page set, we return + * If we find ptdesc_page set, we return * the allocated page with single fragment * count. */ if (likely(!mm->context.pmd_frag)) { - atomic_set(&page->pt_frag_refcount, PMD_FRAG_NR); + atomic_set(&ptdesc->pt_frag_refcount, PMD_FRAG_NR); mm->context.pmd_frag = ret + PMD_FRAG_SIZE; } spin_unlock(&mm->page_table_lock); @@ -435,15 +435,15 @@ pmd_t *pmd_fragment_alloc(struct mm_struct *mm, unsigned long vmaddr) void pmd_fragment_free(unsigned long *pmd) { - struct page *page = virt_to_page(pmd); + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); - if (PageReserved(page)) - return free_reserved_page(page); + if (pagetable_is_reserved(ptdesc)) + return free_reserved_ptdesc(ptdesc); - BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0); - if (atomic_dec_and_test(&page->pt_frag_refcount)) { - pgtable_pmd_page_dtor(page); - __free_page(page); + BUG_ON(atomic_read(&ptdesc->pt_frag_refcount) <= 0); + if (atomic_dec_and_test(&ptdesc->pt_frag_refcount)) { + pagetable_pmd_dtor(ptdesc); + pagetable_free(ptdesc); } } diff --git a/arch/powerpc/mm/pgtable-frag.c b/arch/powerpc/mm/pgtable-frag.c index 0c6b68130025..8c31802f97e8 100644 --- a/arch/powerpc/mm/pgtable-frag.c +++ b/arch/powerpc/mm/pgtable-frag.c @@ -18,15 +18,15 @@ void pte_frag_destroy(void *pte_frag) { int count; - struct page *page; + struct ptdesc *ptdesc; - page = virt_to_page(pte_frag); + ptdesc = virt_to_ptdesc(pte_frag); /* drop all the pending references */ count = ((unsigned long)pte_frag & ~PAGE_MASK) >> PTE_FRAG_SIZE_SHIFT; /* We allow PTE_FRAG_NR fragments from a PTE page */ - if (atomic_sub_and_test(PTE_FRAG_NR - count, &page->pt_frag_refcount)) { - pgtable_pte_page_dtor(page); - __free_page(page); + if (atomic_sub_and_test(PTE_FRAG_NR - count, &ptdesc->pt_frag_refcount)) { + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } } @@ -55,25 +55,25 @@ static pte_t *get_pte_from_cache(struct mm_struct *mm) static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel) { void *ret = NULL; - struct page *page; + struct ptdesc *ptdesc; if (!kernel) { - page = alloc_page(PGALLOC_GFP | __GFP_ACCOUNT); - if (!page) + ptdesc = pagetable_alloc(PGALLOC_GFP | __GFP_ACCOUNT, 0); + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!pagetable_pte_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } } else { - page = alloc_page(PGALLOC_GFP); - if (!page) + ptdesc = pagetable_alloc(PGALLOC_GFP, 0); + if (!ptdesc) return NULL; } - atomic_set(&page->pt_frag_refcount, 1); + atomic_set(&ptdesc->pt_frag_refcount, 1); - ret = page_address(page); + ret = ptdesc_address(ptdesc); /* * if we support only one fragment just return the * allocated page. @@ -82,12 +82,12 @@ static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel) return ret; spin_lock(&mm->page_table_lock); /* - * If we find pgtable_page set, we return + * If we find ptdesc_page set, we return * the allocated page with single fragment * count. */ if (likely(!pte_frag_get(&mm->context))) { - atomic_set(&page->pt_frag_refcount, PTE_FRAG_NR); + atomic_set(&ptdesc->pt_frag_refcount, PTE_FRAG_NR); pte_frag_set(&mm->context, ret + PTE_FRAG_SIZE); } spin_unlock(&mm->page_table_lock); @@ -108,28 +108,28 @@ pte_t *pte_fragment_alloc(struct mm_struct *mm, int kernel) static void pte_free_now(struct rcu_head *head) { - struct page *page; + struct ptdesc *ptdesc; - page = container_of(head, struct page, rcu_head); - pgtable_pte_page_dtor(page); - __free_page(page); + ptdesc = container_of(head, struct ptdesc, pt_rcu_head); + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } void pte_fragment_free(unsigned long *table, int kernel) { - struct page *page = virt_to_page(table); + struct ptdesc *ptdesc = virt_to_ptdesc(table); - if (PageReserved(page)) - return free_reserved_page(page); + if (pagetable_is_reserved(ptdesc)) + return free_reserved_ptdesc(ptdesc); - BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0); - if (atomic_dec_and_test(&page->pt_frag_refcount)) { + BUG_ON(atomic_read(&ptdesc->pt_frag_refcount) <= 0); + if (atomic_dec_and_test(&ptdesc->pt_frag_refcount)) { if (kernel) - __free_page(page); - else if (TestClearPageActive(page)) - call_rcu(&page->rcu_head, pte_free_now); + pagetable_free(ptdesc); + else if (folio_test_clear_active(ptdesc_folio(ptdesc))) + call_rcu(&ptdesc->pt_rcu_head, pte_free_now); else - pte_free_now(&page->rcu_head); + pte_free_now(&ptdesc->pt_rcu_head); } } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578992.906843 (Exim 4.92) (envelope-from ) id 1qT9IL-00064S-NR; Mon, 07 Aug 2023 23:05:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578992.906843; Mon, 07 Aug 2023 23:05:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IL-000648-IU; Mon, 07 Aug 2023 23:05:49 +0000 Received: by outflank-mailman (input) for mailman id 578992; Mon, 07 Aug 2023 23:05:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IK-0001NS-Bl for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:48 +0000 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [2607:f8b0:4864:20::c35]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f06633df-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:45 +0200 (CEST) Received: by mail-oo1-xc35.google.com with SMTP id 006d021491bc7-56cd753b31cso2655475eaf.1 for ; Mon, 07 Aug 2023 16:05:45 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f06633df-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449544; x=1692054344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sltDOqqNfHEtvz8jLXUjW/r74sJCuRKUMVTEbSHBWCo=; b=UhBUMZPilOAQo3tCXIAniV7oZUOB/4OUCgf91AGw0VUxPIy18IwE3Hi+xzTQPR3j5J o20MFNZLnYngdlpCV7c18tsU830Io9A8DWdX3VSs8IZGcaz3l+m4OaxP2VVwR45ldftn z2kW31b5xPxYeP3g5UA46i7qsam8HRjTgG7guCbc8HyGEcYktnlbPJA40mgTTCO6Cfp5 i9UcQWRlBkevWdSR2pIJgYC6roUzquc+QXKeembvcRSerjkiIbuoDs27MkJKPDd/Xbpo rTtWQ/L28eqbGOEHbuk8Zg9jgIBeYXnwkb82KyyF5XFV7KZrtQoqdZyN2qkwYGLx08Fy p3Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449544; x=1692054344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sltDOqqNfHEtvz8jLXUjW/r74sJCuRKUMVTEbSHBWCo=; b=HrTpxxPwNrnrvNtKM5lAibSo4ipXaAY8PKXfnjN53q2h/IAop8KcRYvlPnAQ0RdZe8 eNkasI6MTdZ5hnEIxRhcZv/reX2dqagBOkvLfqw/BGgpOHptNeSz/klbQpsOBqXvnxyR aUyY62MJEajRqFBuzNiBPF7TjKrrBsnHzWIAC/Muzo30JU8NA4YUhJw3WRyuIp/xQ4gb BiSc1yBu7PRS0z9iB72orsXpZKpofsksvPnJPJ4S1UGM6SqQirT2yi1hrmrcm4S/dZzM 4Oi1QwKGqOg7UIu9hCcjvmiAvGl4D1UA8Q1y8mBV4rtNG1kPFBr/lcsW2zf8DjKzpUVr nkIA== X-Gm-Message-State: AOJu0YwB+LaC9LFtcR7NpMmbRNAq5TL9IP+FotcrhZ0NybZKiNLe9xD7 /4TL/8e2igu2S5xUAM1a/uU= X-Google-Smtp-Source: AGHT+IHsTvUJyWq2o9mZJc1NQ3FrwP0s/yEHbaA4sDhb4UDEkTpN/SnOXwKPkJpn25/vbSLatpkp3w== X-Received: by 2002:a05:6808:df3:b0:3a4:8140:97e8 with SMTP id g51-20020a0568080df300b003a4814097e8mr8989196oic.14.1691449544486; Mon, 07 Aug 2023 16:05:44 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Dave Hansen Subject: [PATCH mm-unstable v9 13/31] x86: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:04:55 -0700 Message-Id: <20230807230513.102486-14-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/mm/pgtable.c | 47 ++++++++++++++++++++++++++----------------- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index 15a8009a4480..d3a93e8766ee 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -52,7 +52,7 @@ early_param("userpte", setup_userpte); void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) { - pgtable_pte_page_dtor(pte); + pagetable_pte_dtor(page_ptdesc(pte)); paravirt_release_pte(page_to_pfn(pte)); paravirt_tlb_remove_table(tlb, pte); } @@ -60,7 +60,7 @@ void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte) #if CONFIG_PGTABLE_LEVELS > 2 void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd) { - struct page *page = virt_to_page(pmd); + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); paravirt_release_pmd(__pa(pmd) >> PAGE_SHIFT); /* * NOTE! For PAE, any changes to the top page-directory-pointer-table @@ -69,8 +69,8 @@ void ___pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd) #ifdef CONFIG_X86_PAE tlb->need_flush_all = 1; #endif - pgtable_pmd_page_dtor(page); - paravirt_tlb_remove_table(tlb, page); + pagetable_pmd_dtor(ptdesc); + paravirt_tlb_remove_table(tlb, ptdesc_page(ptdesc)); } #if CONFIG_PGTABLE_LEVELS > 3 @@ -92,16 +92,16 @@ void ___p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d) static inline void pgd_list_add(pgd_t *pgd) { - struct page *page = virt_to_page(pgd); + struct ptdesc *ptdesc = virt_to_ptdesc(pgd); - list_add(&page->lru, &pgd_list); + list_add(&ptdesc->pt_list, &pgd_list); } static inline void pgd_list_del(pgd_t *pgd) { - struct page *page = virt_to_page(pgd); + struct ptdesc *ptdesc = virt_to_ptdesc(pgd); - list_del(&page->lru); + list_del(&ptdesc->pt_list); } #define UNSHARED_PTRS_PER_PGD \ @@ -112,12 +112,12 @@ static inline void pgd_list_del(pgd_t *pgd) static void pgd_set_mm(pgd_t *pgd, struct mm_struct *mm) { - virt_to_page(pgd)->pt_mm = mm; + virt_to_ptdesc(pgd)->pt_mm = mm; } struct mm_struct *pgd_page_get_mm(struct page *page) { - return page->pt_mm; + return page_ptdesc(page)->pt_mm; } static void pgd_ctor(struct mm_struct *mm, pgd_t *pgd) @@ -213,11 +213,14 @@ void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd) static void free_pmds(struct mm_struct *mm, pmd_t *pmds[], int count) { int i; + struct ptdesc *ptdesc; for (i = 0; i < count; i++) if (pmds[i]) { - pgtable_pmd_page_dtor(virt_to_page(pmds[i])); - free_page((unsigned long)pmds[i]); + ptdesc = virt_to_ptdesc(pmds[i]); + + pagetable_pmd_dtor(ptdesc); + pagetable_free(ptdesc); mm_dec_nr_pmds(mm); } } @@ -230,18 +233,24 @@ static int preallocate_pmds(struct mm_struct *mm, pmd_t *pmds[], int count) if (mm == &init_mm) gfp &= ~__GFP_ACCOUNT; + gfp &= ~__GFP_HIGHMEM; for (i = 0; i < count; i++) { - pmd_t *pmd = (pmd_t *)__get_free_page(gfp); - if (!pmd) + pmd_t *pmd = NULL; + struct ptdesc *ptdesc = pagetable_alloc(gfp, 0); + + if (!ptdesc) failed = true; - if (pmd && !pgtable_pmd_page_ctor(virt_to_page(pmd))) { - free_page((unsigned long)pmd); - pmd = NULL; + if (ptdesc && !pagetable_pmd_ctor(ptdesc)) { + pagetable_free(ptdesc); + ptdesc = NULL; failed = true; } - if (pmd) + if (ptdesc) { mm_inc_nr_pmds(mm); + pmd = ptdesc_address(ptdesc); + } + pmds[i] = pmd; } @@ -830,7 +839,7 @@ int pud_free_pmd_page(pud_t *pud, unsigned long addr) free_page((unsigned long)pmd_sv); - pgtable_pmd_page_dtor(virt_to_page(pmd)); + pagetable_pmd_dtor(virt_to_ptdesc(pmd)); free_page((unsigned long)pmd); return 1; -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:05:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:05:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.578994.906853 (Exim 4.92) (envelope-from ) id 1qT9IP-0006lX-6f; Mon, 07 Aug 2023 23:05:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 578994.906853; Mon, 07 Aug 2023 23:05:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IO-0006l9-Vq; Mon, 07 Aug 2023 23:05:53 +0000 Received: by outflank-mailman (input) for mailman id 578994; Mon, 07 Aug 2023 23:05:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IN-0001NS-AA for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:51 +0000 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [2607:f8b0:4864:20::b2f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f2c3a583-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:49 +0200 (CEST) Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-d13e0bfbbcfso7271217276.0 for ; Mon, 07 Aug 2023 16:05:49 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2c3a583-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449548; x=1692054348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=djDHSA50q7R+UyBiZfR1OlHjGJmDs73q9nwlLjbVi90=; b=A70KAiN4sx+tlFlhyX9BkgJstVMLVR3VqHlhU0rx7I/q1gK7xadYJiksKbuvoZ1TCU vtYAPdjYMcohI4FUcCDaUSvo3KExkCCd8i4ZAJlLsd7GGEFa35HZ6ueu66zMG9Pjessv IfHL3oLMSZbSj2Xq1C5vYTgwWzjwrMyTCzKH7w07IcqqBjGPHvlKkPkr5yx2TrtnD3V5 vilM5UK235QUkkDj7spFvnAsyD47IB2DFcBmstKvpCiE4ENrGAtmtfggM5j3FhO6Urma yNzpPXlABiRMwP18oUglZegWP3XimvmMFaP4ALUxkyZmGiszwVYNBF+f3K+ck5Grr2Wp NJ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449548; x=1692054348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=djDHSA50q7R+UyBiZfR1OlHjGJmDs73q9nwlLjbVi90=; b=Tom7rIvsB5fLnrS17EfXXXM57RvYiWRw32fNvB6AYie+j057RIu/pFigOoUD+URo+I 9v6OlOx3I+1uqK5YlC33GLEc/+Jjp3k+KNe5njtTWY9mUCJ2sp4rRu4Ec4ZnDtbNThOU Do5RB3ytOSA0kidf5QyeL4ee/Y1F3dWVu9m6GkWErrUcuYroPDLX4n16p0YN5Zvq2ijz 3B3qomUm1SHB3l0apvoiFeOEQ5gvqrtrcHggwC3d23yElIHYp9mmSK5JXzWnA9kHtVEs 2csbTuHxSdksKxyPkyTgDTKk//Mp+amY66Hak11ThIRRI6fyhRwqRIQ3/l5y5qC1ylh4 Nf4A== X-Gm-Message-State: AOJu0YyQfiAVOZyF8PkYFsMUHb60j+v/uNWNBm2YNGUJ0D66h9eMOWnF vAX25Klh8ityc6FgcUZcxP4= X-Google-Smtp-Source: AGHT+IGTzP73V6D5bA3Obfkv2DqAOxUsUVIIigLLB5NQKEC9VyMSvyrKel3HyW7I0Mz7ccDZUXFbIA== X-Received: by 2002:a25:d8c4:0:b0:d05:2616:3363 with SMTP id p187-20020a25d8c4000000b00d0526163363mr9753736ybg.26.1691449548551; Mon, 07 Aug 2023 16:05:48 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 15/31] mm: remove page table members from struct page Date: Mon, 7 Aug 2023 16:04:57 -0700 Message-Id: <20230807230513.102486-16-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The page table members are now split out into their own ptdesc struct. Remove them from struct page. Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) --- include/linux/mm_types.h | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index ea34b22b4cbf..f5ba5b0bc836 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -141,24 +141,6 @@ struct page { struct { /* Tail pages of compound page */ unsigned long compound_head; /* Bit zero is set */ }; - struct { /* Page table pages */ - unsigned long _pt_pad_1; /* compound_head */ - pgtable_t pmd_huge_pte; /* protected by page->ptl */ - /* - * A PTE page table page might be freed by use of - * rcu_head: which overlays those two fields above. - */ - unsigned long _pt_pad_2; /* mapping */ - union { - struct mm_struct *pt_mm; /* x86 pgds only */ - atomic_t pt_frag_refcount; /* powerpc */ - }; -#if ALLOC_SPLIT_PTLOCKS - spinlock_t *ptl; -#else - spinlock_t ptl; -#endif - }; struct { /* ZONE_DEVICE pages */ /** @pgmap: Points to the hosting device page map. */ struct dev_pagemap *pgmap; @@ -454,10 +436,7 @@ struct ptdesc { TABLE_MATCH(flags, __page_flags); TABLE_MATCH(compound_head, pt_list); TABLE_MATCH(compound_head, _pt_pad_1); -TABLE_MATCH(pmd_huge_pte, pmd_huge_pte); TABLE_MATCH(mapping, __page_mapping); -TABLE_MATCH(pt_mm, pt_mm); -TABLE_MATCH(ptl, ptl); TABLE_MATCH(rcu_head, pt_rcu_head); TABLE_MATCH(page_type, __page_type); TABLE_MATCH(_refcount, _refcount); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579021.906863 (Exim 4.92) (envelope-from ) id 1qT9Js-0001Dh-KW; Mon, 07 Aug 2023 23:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579021.906863; Mon, 07 Aug 2023 23:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Js-0001Da-G5; Mon, 07 Aug 2023 23:07:24 +0000 Received: by outflank-mailman (input) for mailman id 579021; Mon, 07 Aug 2023 23:07:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ip-0001NY-UB for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:19 +0000 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [2607:f8b0:4864:20::b2a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00a22b99-3577-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:06:12 +0200 (CEST) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d2b8437d825so5087721276.3 for ; Mon, 07 Aug 2023 16:06:12 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00a22b99-3577-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449572; x=1692054372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NpbBCMkwg1WbsmcEnKHREFultw/IY4tG3Jsqz6w0a8E=; b=nS5J1UYk8f9msjmOJfcwkB8RnOSNZv60DefW2TDIHuOlvS9npGk8oT2LZd+SySl8sv g+gjV1veIOE2SNGvcFOMJ1pPimwLTZ7+pvFQ4bVBKr+eOsPpBFIPNto8klZeZdDlbFxo wkyNcA7u+kweH04q+BG4NvsUNaK7E9zibuZ01wwXmu5qj90Fw+mY1pf3xcSZWMeZa7wK aGRqh9CjWX7iCRUWp+ZrbhBol1e4MCC8JBlzqolLSWyg74wpF8elWEgkI2Vj4oenaGhD isx7MJZrX54CbrhbHsj99pEt0PqmBmGh9HnsD2DaWM5Gm6veS11IW5m9dzOKe44sU/M/ md6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449572; x=1692054372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NpbBCMkwg1WbsmcEnKHREFultw/IY4tG3Jsqz6w0a8E=; b=bWTjElMLWyncexya9L/k5QBL8oWU8j1WdGkgfO5ElP8tNGag21sbAGGS922vgjM60W PuFcTZAvN293y2Z/vX3yVdMMw+xpBkY86qFO7Un9tFs1ReCeFD1ch8FU2YTvaMIvaq// AcMFl4+okdVhS5a7Bqtl1CpvhGu1pguH7oZoP3hfyga7b9RU7SWCVaFJBoYHHrYIzYbB OEswiA9azfs+XqAfdQnIHgoWhgAz50FYd3PQ78HuW2naVH6sAlLJWDryu+F9htytm5R6 3OxsE9iIgZm2vRvmPrkJJKUr1doRjiNPaApVF/qzWfxUuPDrAb4PyvfVr2vO/mrR8c48 RB6w== X-Gm-Message-State: AOJu0YyaQzRJrW+LKNw5FtviXl6qhHVBMzF8tjZMx7nFL/nAMEomhP6P fF2kcX+6S/ehKGIbJ9c5dvE= X-Google-Smtp-Source: AGHT+IHFLqgFAthROKM1yjg8aTn4QAXhjx425iARLy/TVdE1z6PZIG9RjSxWoTmqjhSqLQZr0gTMYg== X-Received: by 2002:a25:d24d:0:b0:d0a:127e:7478 with SMTP id j74-20020a25d24d000000b00d0a127e7478mr9478817ybg.44.1691449571835; Mon, 07 Aug 2023 16:06:11 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Paul Walmsley , Palmer Dabbelt , Mike Rapoport Subject: [PATCH mm-unstable v9 26/31] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs Date: Mon, 7 Aug 2023 16:05:08 -0700 Message-Id: <20230807230513.102486-27-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Acked-by: Palmer Dabbelt Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/riscv/include/asm/pgalloc.h | 8 ++++---- arch/riscv/mm/init.c | 16 ++++++---------- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index 59dc12b5b7e8..d169a4f41a2e 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -153,10 +153,10 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) #endif /* __PAGETABLE_PMD_FOLDED */ -#define __pte_free_tlb(tlb, pte, buf) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +#define __pte_free_tlb(tlb, pte, buf) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte));\ } while (0) #endif /* CONFIG_MMU */ diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 9ce504737d18..430a3d05a841 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -353,12 +353,10 @@ static inline phys_addr_t __init alloc_pte_fixmap(uintptr_t va) static phys_addr_t __init alloc_pte_late(uintptr_t va) { - unsigned long vaddr; - - vaddr = __get_free_page(GFP_KERNEL); - BUG_ON(!vaddr || !pgtable_pte_page_ctor(virt_to_page((void *)vaddr))); + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0); - return __pa(vaddr); + BUG_ON(!ptdesc || !pagetable_pte_ctor(ptdesc)); + return __pa((pte_t *)ptdesc_address(ptdesc)); } static void __init create_pte_mapping(pte_t *ptep, @@ -436,12 +434,10 @@ static phys_addr_t __init alloc_pmd_fixmap(uintptr_t va) static phys_addr_t __init alloc_pmd_late(uintptr_t va) { - unsigned long vaddr; - - vaddr = __get_free_page(GFP_KERNEL); - BUG_ON(!vaddr || !pgtable_pmd_page_ctor(virt_to_page((void *)vaddr))); + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0); - return __pa(vaddr); + BUG_ON(!ptdesc || !pagetable_pmd_ctor(ptdesc)); + return __pa((pmd_t *)ptdesc_address(ptdesc)); } static void __init create_pmd_mapping(pmd_t *pmdp, -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579026.906873 (Exim 4.92) (envelope-from ) id 1qT9Jt-0001U5-SB; Mon, 07 Aug 2023 23:07:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579026.906873; Mon, 07 Aug 2023 23:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Jt-0001Tr-P1; Mon, 07 Aug 2023 23:07:25 +0000 Received: by outflank-mailman (input) for mailman id 579026; Mon, 07 Aug 2023 23:07:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ip-0001NS-6u for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:19 +0000 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [2607:f8b0:4864:20::236]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0356d06e-3577-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:17 +0200 (CEST) Received: by mail-oi1-x236.google.com with SMTP id 5614622812f47-3a74d759be4so3751260b6e.2 for ; Mon, 07 Aug 2023 16:06:17 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0356d06e-3577-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449576; x=1692054376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9BaWlDiv5V7gFuBlQl83W1x9C2ZQPjYd5FMjDEEKLfk=; b=cpy8Xcl19ScHIaEJohMfnXLz1DqejMUY8L9glfoRJKsJ7GTvGcuQsYlnxy1uVil+vX sKLd/jl5n7/nYQY+c94D1q52xLTeGbCjuaSsuOaGb/1E2rdiSHktCUTDo4f7HqbeV+dj TPAGwr0CoWyRhx6mzwQflnUob8s/y/rCKdVhSwURC5eFFFvRnN/tn2Qy2PbiuytULAR6 gF0MKwRWTHX4EnLLnTfGRqqibjjUEq59j99BhXKpF7aj2wSWqBVgMsp2RTnzW+/7J2fC DAIl8+bDSwnR/XjlkNOvluV6Us9KQMDrngkUDG9ywXNDgTmwYNXsy+sDpdm8duXtW4+4 Ov0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449576; x=1692054376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9BaWlDiv5V7gFuBlQl83W1x9C2ZQPjYd5FMjDEEKLfk=; b=Q9VFQpUYK+ajwAm+F/eni6OekKDpuW3P4IgcMQT/NgZuofant0tzsxiSQtvnGAI9OX tn4fSehsmW8J5m2E+0shF+kiyL28E5KXobboOBI5GrOWPpQwLDx/ThqkdBUbKRrHG77g dau+cjsnvFrkAceLPR49LtWSpDT3Hizx/ZPahAdA6RWSQlD2yFXF0e5dAFLjIox5xV+7 aysSt1jirbUkV7YMnOZeHSjSDy1C2uMnV4McZAlaXvjBd51F1QjVTWCvzU5svOp6klAk wOhDY3ua6LuW72URL+Wca4e3w7lzHWI02gKXgnT8sIO/9czwd+dW+kY36eIGHWvEWDNl p8eg== X-Gm-Message-State: AOJu0Yy5brNV/6AkZew2Gb7utv0VAIDY9V9UYpECV4yeZKw1bWk4kSBw kkD6PuEUFPBGLcrgoOpp1Vs= X-Google-Smtp-Source: AGHT+IHyrg/p55954UWSWEFSK4VAgtzO3wGDAXzmBNoLynnb9Xv8FQKgcm7kods1XM481PofrT4NJA== X-Received: by 2002:a05:6808:23d3:b0:3a3:e6eb:9c53 with SMTP id bq19-20020a05680823d300b003a3e6eb9c53mr13630414oib.23.1691449576353; Mon, 07 Aug 2023 16:06:16 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 28/31] sparc64: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:05:10 -0700 Message-Id: <20230807230513.102486-29-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/init_64.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 680ef206565c..f83017992eaa 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2907,14 +2907,15 @@ pte_t *pte_alloc_one_kernel(struct mm_struct *mm) pgtable_t pte_alloc_one(struct mm_struct *mm) { - struct page *page = alloc_page(GFP_KERNEL | __GFP_ZERO); - if (!page) + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL | __GFP_ZERO, 0); + + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!pagetable_pte_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - return (pte_t *) page_address(page); + return ptdesc_address(ptdesc); } void pte_free_kernel(struct mm_struct *mm, pte_t *pte) @@ -2924,10 +2925,10 @@ void pte_free_kernel(struct mm_struct *mm, pte_t *pte) static void __pte_free(pgtable_t pte) { - struct page *page = virt_to_page(pte); + struct ptdesc *ptdesc = virt_to_ptdesc(pte); - pgtable_pte_page_dtor(page); - __free_page(page); + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } void pte_free(struct mm_struct *mm, pgtable_t pte) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579028.906877 (Exim 4.92) (envelope-from ) id 1qT9Ju-0001WW-7V; Mon, 07 Aug 2023 23:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579028.906877; Mon, 07 Aug 2023 23:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ju-0001W8-2A; Mon, 07 Aug 2023 23:07:26 +0000 Received: by outflank-mailman (input) for mailman id 579028; Mon, 07 Aug 2023 23:07:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IX-0001NY-QJ for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:01 +0000 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [2607:f8b0:4864:20::b32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f900bb6b-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:06:00 +0200 (CEST) Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-ccc462deca6so5489249276.0 for ; Mon, 07 Aug 2023 16:06:00 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f900bb6b-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449559; x=1692054359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w5tIdqLMLMEIndKmulGbjbVGcWP2eiFuISuM6iDOZlQ=; b=gXJTXcEvyVT7IoetVDXBwB8IPw8UIwzytrLAqRYME0pNQ9C4uggCnI6RPeBYUmiABc NGa1RjP9x6Az35hUll5l4sYYgp98uBkULFey+10bJthE9R/J1BfMB4fjSuNmCpJ1YXG1 ARmLg59bINaXUvevzM80HySnkL9LRFKwNZ83rXMUa4P0U6g1vYwZDB00ToF81qaBEF1+ SCcl4G/9B02tlTVDHjLxfkMGL5hqppCgW9NlCKGjCO3XjVlW37imlXi2cPPjZHQnQLsK WyhHmorW6P7DI7CdyMJrfi88WQs4xcY1ld9fhabvXIyG+tqrpY5PfVFDlBq81eHbR+r8 HFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449559; x=1692054359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w5tIdqLMLMEIndKmulGbjbVGcWP2eiFuISuM6iDOZlQ=; b=gkD9ekUaNLWPR3V0R10oJGlEqbMJI2Qe7P8Nhm5QO/v7G615w+e17bvT2yIslJXlKf Os1hzWO1hqUW2M9qS/8tBZVoRWh0LHSkgKNEzm7rNTNG9T7IWBIMGzKSPN2rPQ0hIiU/ Vn0LcQgueRBEfQQ6EPvFJdgISXJ1nR4qsY828pVZKXKXrV4wGpMDxiwQlFn66O+3RGra w+v12PzZdPnqsTfF4rFk4VnPxBqZh31GOw7cLIjoGh8t8yL7im0NLpcut+ZaXK09sEnw UR34G2qKT2Fvt0L2Zcw158tWGXR/lDNYcw/4Pfdrf6VYZRobo52enAPTwk+yGz2cyipZ Z/XQ== X-Gm-Message-State: AOJu0YwJ/nhdK1OSskJX0PEFNciCEEF5cMlun6yTOvrdAQyLciR8dok5 lVLc5hHQmgLR8hzzOSmDed4= X-Google-Smtp-Source: AGHT+IHgbeu9fOmMS+FNlr/kvyOX24cSJUZ4nRlF6aWfNWe7W/NjYriU1Zmx+jVELg0QXXl18qiXKg== X-Received: by 2002:a25:4b81:0:b0:d4b:ec36:bb85 with SMTP id y123-20020a254b81000000b00d4bec36bb85mr7290071yba.50.1691449559015; Mon, 07 Aug 2023 16:05:59 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 20/31] hexagon: Convert __pte_free_tlb() to use ptdescs Date: Mon, 7 Aug 2023 16:05:02 -0700 Message-Id: <20230807230513.102486-21-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/hexagon/include/asm/pgalloc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h index f0c47e6a7427..55988625e6fb 100644 --- a/arch/hexagon/include/asm/pgalloc.h +++ b/arch/hexagon/include/asm/pgalloc.h @@ -87,10 +87,10 @@ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, max_kernel_seg = pmdindex; } -#define __pte_free_tlb(tlb, pte, addr) \ -do { \ - pgtable_pte_page_dtor((pte)); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + pagetable_pte_dtor((page_ptdesc(pte))); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579032.906884 (Exim 4.92) (envelope-from ) id 1qT9Ju-0001gI-Qr; Mon, 07 Aug 2023 23:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579032.906884; Mon, 07 Aug 2023 23:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ju-0001eq-LD; Mon, 07 Aug 2023 23:07:26 +0000 Received: by outflank-mailman (input) for mailman id 579032; Mon, 07 Aug 2023 23:07:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Iv-0001NS-KU for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:25 +0000 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [2607:f8b0:4864:20::b2c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 072753b6-3577-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:23 +0200 (CEST) Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-d59da7115bdso264051276.3 for ; Mon, 07 Aug 2023 16:06:23 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 072753b6-3577-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449583; x=1692054383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gIX4EtUZRQHbbGVDBj/rJyP4ZKSCaTL9vvlgteJwLjg=; b=ny/PO9Rzwz4wKD05c8Oj8x01t9rfWUwF+DPBSi6xhAQ1t3uiUBYZ7YUUbf8WtD6fas a2dGGpvFO2SYjUkztwf/JpnNv7QhJL+Goto2OWRpxKnsAjXenC9v6P3rISzqLv6y4LVV 4Qzw+SXgVTszZ9R94kkJTKmg5SvkJhFFe8ZHJiGz98l2xVrWZH/L4O6QNYM4Ix9oN6dK IfbxHi4LcKxjr+5M4cvO0MwysEIi/pmb6eegOI2VGQmX9xJr0pTMWjXflu5Ws+wnG+9V BkJIEDxKgjBTQlry6d49f1/eWCkgGXBEpt1ui7ZKc/08IVlfaQd/C3Y9s9851HPExZOi t/gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449583; x=1692054383; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gIX4EtUZRQHbbGVDBj/rJyP4ZKSCaTL9vvlgteJwLjg=; b=AHpKMVvvRJt5vU6pCMhYSgi3xEOAvewviIqQI07CaqocweBxU2y9cQPT4ZX8rTqbLn 36EJYjgn+sQGWRPY3Dv+preN4MAMRedKDqMxXbQdbUCltPS/pF5xrpsXxdbWeg3Cu3To NZVtUtX8GPp8+WRj9a6UbQ3JGOri6Go98tRGXWXG5QXh1X5RL2QyRb5osGnLmmvTNp5A k6Uz7YEm3RERF3m1F6xQvt/xe+y2O7nV8Redj+jzCC4ZvGPe3zzOz+DUe34P1YvW84T8 g7w5Ar0LavycHIZbWhME8yK5637FgKoDC/qvlAaN/JiblmKNDoHK+SK4pmxbk9YZZ8po g4oQ== X-Gm-Message-State: AOJu0YwJlNfSm3nqEFi/hoY5jXPQE9v4xPj3pycZN+VKgerf0c/YvWMp CgPybTa8WZox+aEWcmKkcGw= X-Google-Smtp-Source: AGHT+IHSz7sLxFa/9tcB1BFEAx77xsw7IyoQHCgeHupxbvTa93/qmodby26m2eSPWXo4FijMYi73DQ== X-Received: by 2002:a25:e708:0:b0:d53:f88a:dc09 with SMTP id e8-20020a25e708000000b00d53f88adc09mr3953501ybh.2.1691449582662; Mon, 07 Aug 2023 16:06:22 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport Subject: [PATCH mm-unstable v9 31/31] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers Date: Mon, 7 Aug 2023 16:05:13 -0700 Message-Id: <20230807230513.102486-32-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These functions are no longer necessary. Remove them and cleanup Documentation referencing them. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- Documentation/mm/split_page_table_lock.rst | 12 +++++------ .../zh_CN/mm/split_page_table_lock.rst | 14 ++++++------- include/linux/mm.h | 20 ------------------- 3 files changed, 13 insertions(+), 33 deletions(-) diff --git a/Documentation/mm/split_page_table_lock.rst b/Documentation/mm/split_page_table_lock.rst index a834fad9de12..e4f6972eb6c0 100644 --- a/Documentation/mm/split_page_table_lock.rst +++ b/Documentation/mm/split_page_table_lock.rst @@ -58,7 +58,7 @@ Support of split page table lock by an architecture =================================================== There's no need in special enabling of PTE split page table lock: everything -required is done by pgtable_pte_page_ctor() and pgtable_pte_page_dtor(), which +required is done by pagetable_pte_ctor() and pagetable_pte_dtor(), which must be called on PTE table allocation / freeing. Make sure the architecture doesn't use slab allocator for page table @@ -68,8 +68,8 @@ This field shares storage with page->ptl. PMD split lock only makes sense if you have more than two page table levels. -PMD split lock enabling requires pgtable_pmd_page_ctor() call on PMD table -allocation and pgtable_pmd_page_dtor() on freeing. +PMD split lock enabling requires pagetable_pmd_ctor() call on PMD table +allocation and pagetable_pmd_dtor() on freeing. Allocation usually happens in pmd_alloc_one(), freeing in pmd_free() and pmd_free_tlb(), but make sure you cover all PMD table allocation / freeing @@ -77,7 +77,7 @@ paths: i.e X86_PAE preallocate few PMDs on pgd_alloc(). With everything in place you can set CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK. -NOTE: pgtable_pte_page_ctor() and pgtable_pmd_page_ctor() can fail -- it must +NOTE: pagetable_pte_ctor() and pagetable_pmd_ctor() can fail -- it must be handled properly. page->ptl @@ -97,7 +97,7 @@ trick: split lock with enabled DEBUG_SPINLOCK or DEBUG_LOCK_ALLOC, but costs one more cache line for indirect access; -The spinlock_t allocated in pgtable_pte_page_ctor() for PTE table and in -pgtable_pmd_page_ctor() for PMD table. +The spinlock_t allocated in pagetable_pte_ctor() for PTE table and in +pagetable_pmd_ctor() for PMD table. Please, never access page->ptl directly -- use appropriate helper. diff --git a/Documentation/translations/zh_CN/mm/split_page_table_lock.rst b/Documentation/translations/zh_CN/mm/split_page_table_lock.rst index 4fb7aa666037..a2c288670a24 100644 --- a/Documentation/translations/zh_CN/mm/split_page_table_lock.rst +++ b/Documentation/translations/zh_CN/mm/split_page_table_lock.rst @@ -56,16 +56,16 @@ Hugetlb特å®ç„è¾…å©å‡½æ•°: æ¶æ„对分页表é”ç„æ”¯æŒ ==================== -没有必è¦ç‰¹åˆ«å¯ç”¨PTE分页表é”ï¼æ‰€æœ‰éœ€è¦ç„东西都由pgtable_pte_page_ctor() -å’Œpgtable_pte_page_dtor()完æˆï¼Œå®ƒä»¬å¿…须在PTE表分é…/é‡æ”¾æ—¶è¢«è°ƒç”¨ă€‚ +没有必è¦ç‰¹åˆ«å¯ç”¨PTE分页表é”ï¼æ‰€æœ‰éœ€è¦ç„东西都由pagetable_pte_ctor() +å’Œpagetable_pte_dtor()完æˆï¼Œå®ƒä»¬å¿…须在PTE表分é…/é‡æ”¾æ—¶è¢«è°ƒç”¨ă€‚ ç¡®ä¿æ¶æ„ä¸ä½¿ç”¨slab分é…器æ¥åˆ†é…页表ï¼slab使用page->slab_cacheæ¥åˆ†é…其页 é¢ă€‚这个区域ä¸page->ptlå…±äº«å­˜å‚¨ă€‚ PMD分页é”åªæœ‰åœ¨ä½ æœ‰ä¸¤ä¸ªä»¥ä¸ç„页表级别时æ‰æœ‰æ„ä¹‰ă€‚ -å¯ç”¨PMD分页é”需è¦åœ¨PMD表分é…时调用pgtable_pmd_page_ctor()，在é‡æ”¾æ—¶è°ƒ -用pgtable_pmd_page_dtor()。 +å¯ç”¨PMD分页é”需è¦åœ¨PMD表分é…时调用pagetable_pmd_ctor()，在é‡æ”¾æ—¶è°ƒ +用pagetable_pmd_dtor()。 分é…é€å¸¸å‘生在pmd_alloc_one()中，é‡æ”¾å‘生在pmd_free()å’Œpmd_free_tlb() 中，但è¦ç¡®ä¿è¦†ç›–所有ç„PMD表分é…/é‡æ”¾è·¯å¾„ï¼å³X86_PAE在pgd_alloc()中预先 @@ -73,7 +73,7 @@ PMD分页é”åªæœ‰åœ¨ä½ æœ‰ä¸¤ä¸ªä»¥ä¸ç„页表级别时æ‰æœ‰æ„ä¹‰ă€‚ 一切就绪å，你å¯ä»¥è®¾ç½®CONFIG_ARCH_ENABLE_SPLIT_PMD_PTLOCK。 -注æ„ï¼pgtable_pte_page_ctor()å’Œpgtable_pmd_page_ctor()å¯èƒ½å¤±è´¥--å¿… +注æ„ï¼pagetable_pte_ctor()å’Œpagetable_pmd_ctor()å¯èƒ½å¤±è´¥--å¿… 须正确处ç†ă€‚ page->ptl @@ -90,7 +90,7 @@ page->ptl用äºè®¿é—®åˆ†å‰²é¡µè¡¨é”，其中'page'是包å«è¯¥è¡¨ç„页é¢struc ç„指针并å¨æ€åˆ†é…å®ƒă€‚è¿™å…许在å¯ç”¨DEBUG_SPINLOCK或DEBUG_LOCK_ALLOCç„ æƒ…å†µä¸‹ä½¿ç”¨åˆ†é¡µé”，但由äºé—´æ¥è®¿é—®è€Œå¤è±äº†ä¸€ä¸ªç¼“å­˜è¡Œă€‚ -PTE表ç„spinlock_t分é…在pgtable_pte_page_ctor()中，PMD表ç„spinlock_t -分é…在pgtable_pmd_page_ctor()中。 +PTE表ç„spinlock_t分é…在pagetable_pte_ctor()中，PMD表ç„spinlock_t +分é…在pagetable_pmd_ctor()中。 请ä¸è¦ç›´æ¥è®¿é—®page->ptl - -使用适当ç„è¾…å©å‡½æ•°ă€‚ diff --git a/include/linux/mm.h b/include/linux/mm.h index 6310e0c59efe..6a95dfed4957 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2932,11 +2932,6 @@ static inline bool pagetable_pte_ctor(struct ptdesc *ptdesc) return true; } -static inline bool pgtable_pte_page_ctor(struct page *page) -{ - return pagetable_pte_ctor(page_ptdesc(page)); -} - static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) { struct folio *folio = ptdesc_folio(ptdesc); @@ -2946,11 +2941,6 @@ static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) lruvec_stat_sub_folio(folio, NR_PAGETABLE); } -static inline void pgtable_pte_page_dtor(struct page *page) -{ - pagetable_pte_dtor(page_ptdesc(page)); -} - pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp); static inline pte_t *pte_offset_map(pmd_t *pmd, unsigned long addr) { @@ -3057,11 +3047,6 @@ static inline bool pagetable_pmd_ctor(struct ptdesc *ptdesc) return true; } -static inline bool pgtable_pmd_page_ctor(struct page *page) -{ - return pagetable_pmd_ctor(page_ptdesc(page)); -} - static inline void pagetable_pmd_dtor(struct ptdesc *ptdesc) { struct folio *folio = ptdesc_folio(ptdesc); @@ -3071,11 +3056,6 @@ static inline void pagetable_pmd_dtor(struct ptdesc *ptdesc) lruvec_stat_sub_folio(folio, NR_PAGETABLE); } -static inline void pgtable_pmd_page_dtor(struct page *page) -{ - pagetable_pmd_dtor(page_ptdesc(page)); -} - /* * No scalability reason to split PUD locks yet, but follow the same pattern * as the PMD locks to make it easier if we decide to. The VM should not be -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579034.906891 (Exim 4.92) (envelope-from ) id 1qT9Jv-0001n5-Dw; Mon, 07 Aug 2023 23:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579034.906891; Mon, 07 Aug 2023 23:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Jv-0001m3-3v; Mon, 07 Aug 2023 23:07:27 +0000 Received: by outflank-mailman (input) for mailman id 579034; Mon, 07 Aug 2023 23:07:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IP-0001NS-Jh for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:53 +0000 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [2607:f8b0:4864:20::b35]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f3ff3a5f-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:51 +0200 (CEST) Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-d35a9d7a5bdso5116753276.0 for ; Mon, 07 Aug 2023 16:05:51 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f3ff3a5f-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449550; x=1692054350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bBkB4loM/Mt006iaxsYk7j8UnaAx8a9/NTd5FkPootg=; b=VY/s2U3lT3eb7t5IpiSg8gZgrV6zdEznmL00awlF+lYtU+Ed+18ZVDdsEO6HtU7Vpy dstrUN4SchMkl2fom9aAptCCOd47DbaRbKQrrssm7FlhTEAcsGfKdLEpxi/zNmVX8fbV m0BaPQ+7+Y3ljNnqxJV89KTzVnBKrAEa7+VtN/uK6yP5RttPNi+e44fLcNeyDJwviR59 fKsVvf58pKEDMlQLmejzlB0KwEwg/f+nuBnJ5WOjDekR3PGb3d8Uh4xNSu90knT7V2KQ ue+Oh5SumW1Q6VzG3Nvx4HCQCUch1OMetRhRQnyZsGJky+dnZgy775ZLVF7RMseL02QV h21w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449550; x=1692054350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bBkB4loM/Mt006iaxsYk7j8UnaAx8a9/NTd5FkPootg=; b=fgwIPjQu9XF0x5A2lMU8flY6FlJ27NIqYWtLdWPZrTuN48lHhfM7KTU/olXCOh2tVL /ti00ENsdsWz4kugwPSJzMhRcUa3E0KYRbjK43DBuFSM5F9IHQ1/l5jc1CglossFlLS8 dYxs5f099iqQew9jtaAjN39bXWpQ9sbAmtIIPByNxMNZrhDXTsV//fQCaXLprSSP+meS Yd8hZSTJoG0b/wo4PgTLsml8nxaCuQhv4bU9eDLn4yl8DKOpBXwEtq4ZBRFfVggpMKa6 s3D2pomoDaNiI5GtpJluH8HettBhUvNjOvBpyGn3xfSrH95Y2X1eZMELCvPev1IlOiiA 26Nw== X-Gm-Message-State: AOJu0YyX8hU14k8H9sC9+9zBBnwOOCRxsBqNTxFlKn5oUlkbcUrP7JgO SxEdsaP2dDmjXWYGXGpDjf8Zlc7w8M2nlA== X-Google-Smtp-Source: AGHT+IF/jyNrncOka/KAbgWZqRRy9OsJr4lD7fBxdAmIgyKSndALMkVGpelnzbmpBefUTJnYvKwx8g== X-Received: by 2002:a25:8001:0:b0:d0f:ea4b:1dff with SMTP id m1-20020a258001000000b00d0fea4b1dffmr9335352ybk.8.1691449550566; Mon, 07 Aug 2023 16:05:50 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" Subject: [PATCH mm-unstable v9 16/31] pgalloc: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:04:58 -0700 Message-Id: <20230807230513.102486-17-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola (Oracle) --- include/asm-generic/pgalloc.h | 88 +++++++++++++++++++++-------------- 1 file changed, 52 insertions(+), 36 deletions(-) diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h index a7cf825befae..c75d4a753849 100644 --- a/include/asm-generic/pgalloc.h +++ b/include/asm-generic/pgalloc.h @@ -8,7 +8,7 @@ #define GFP_PGTABLE_USER (GFP_PGTABLE_KERNEL | __GFP_ACCOUNT) /** - * __pte_alloc_one_kernel - allocate a page for PTE-level kernel page table + * __pte_alloc_one_kernel - allocate memory for a PTE-level kernel page table * @mm: the mm_struct of the current context * * This function is intended for architectures that need @@ -18,12 +18,17 @@ */ static inline pte_t *__pte_alloc_one_kernel(struct mm_struct *mm) { - return (pte_t *)__get_free_page(GFP_PGTABLE_KERNEL); + struct ptdesc *ptdesc = pagetable_alloc(GFP_PGTABLE_KERNEL & + ~__GFP_HIGHMEM, 0); + + if (!ptdesc) + return NULL; + return ptdesc_address(ptdesc); } #ifndef __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL /** - * pte_alloc_one_kernel - allocate a page for PTE-level kernel page table + * pte_alloc_one_kernel - allocate memory for a PTE-level kernel page table * @mm: the mm_struct of the current context * * Return: pointer to the allocated memory or %NULL on error @@ -35,40 +40,40 @@ static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) #endif /** - * pte_free_kernel - free PTE-level kernel page table page + * pte_free_kernel - free PTE-level kernel page table memory * @mm: the mm_struct of the current context * @pte: pointer to the memory containing the page table */ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) { - free_page((unsigned long)pte); + pagetable_free(virt_to_ptdesc(pte)); } /** - * __pte_alloc_one - allocate a page for PTE-level user page table + * __pte_alloc_one - allocate memory for a PTE-level user page table * @mm: the mm_struct of the current context * @gfp: GFP flags to use for the allocation * - * Allocates a page and runs the pgtable_pte_page_ctor(). + * Allocate memory for a page table and ptdesc and runs pagetable_pte_ctor(). * * This function is intended for architectures that need * anything beyond simple page allocation or must have custom GFP flags. * - * Return: `struct page` initialized as page table or %NULL on error + * Return: `struct page` referencing the ptdesc or %NULL on error */ static inline pgtable_t __pte_alloc_one(struct mm_struct *mm, gfp_t gfp) { - struct page *pte; + struct ptdesc *ptdesc; - pte = alloc_page(gfp); - if (!pte) + ptdesc = pagetable_alloc(gfp, 0); + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(pte)) { - __free_page(pte); + if (!pagetable_pte_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - return pte; + return ptdesc_page(ptdesc); } #ifndef __HAVE_ARCH_PTE_ALLOC_ONE @@ -76,9 +81,9 @@ static inline pgtable_t __pte_alloc_one(struct mm_struct *mm, gfp_t gfp) * pte_alloc_one - allocate a page for PTE-level user page table * @mm: the mm_struct of the current context * - * Allocates a page and runs the pgtable_pte_page_ctor(). + * Allocate memory for a page table and ptdesc and runs pagetable_pte_ctor(). * - * Return: `struct page` initialized as page table or %NULL on error + * Return: `struct page` referencing the ptdesc or %NULL on error */ static inline pgtable_t pte_alloc_one(struct mm_struct *mm) { @@ -92,14 +97,16 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm) */ /** - * pte_free - free PTE-level user page table page + * pte_free - free PTE-level user page table memory * @mm: the mm_struct of the current context - * @pte_page: the `struct page` representing the page table + * @pte_page: the `struct page` referencing the ptdesc */ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) { - pgtable_pte_page_dtor(pte_page); - __free_page(pte_page); + struct ptdesc *ptdesc = page_ptdesc(pte_page); + + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } @@ -107,10 +114,11 @@ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) #ifndef __HAVE_ARCH_PMD_ALLOC_ONE /** - * pmd_alloc_one - allocate a page for PMD-level page table + * pmd_alloc_one - allocate memory for a PMD-level page table * @mm: the mm_struct of the current context * - * Allocates a page and runs the pgtable_pmd_page_ctor(). + * Allocate memory for a page table and ptdesc and runs pagetable_pmd_ctor(). + * * Allocations use %GFP_PGTABLE_USER in user context and * %GFP_PGTABLE_KERNEL in kernel context. * @@ -118,28 +126,30 @@ static inline void pte_free(struct mm_struct *mm, struct page *pte_page) */ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long addr) { - struct page *page; + struct ptdesc *ptdesc; gfp_t gfp = GFP_PGTABLE_USER; if (mm == &init_mm) gfp = GFP_PGTABLE_KERNEL; - page = alloc_page(gfp); - if (!page) + ptdesc = pagetable_alloc(gfp, 0); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(page)) { - __free_page(page); + if (!pagetable_pmd_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - return (pmd_t *)page_address(page); + return ptdesc_address(ptdesc); } #endif #ifndef __HAVE_ARCH_PMD_FREE static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) { + struct ptdesc *ptdesc = virt_to_ptdesc(pmd); + BUG_ON((unsigned long)pmd & (PAGE_SIZE-1)); - pgtable_pmd_page_dtor(virt_to_page(pmd)); - free_page((unsigned long)pmd); + pagetable_pmd_dtor(ptdesc); + pagetable_free(ptdesc); } #endif @@ -150,19 +160,25 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) static inline pud_t *__pud_alloc_one(struct mm_struct *mm, unsigned long addr) { gfp_t gfp = GFP_PGTABLE_USER; + struct ptdesc *ptdesc; if (mm == &init_mm) gfp = GFP_PGTABLE_KERNEL; - return (pud_t *)get_zeroed_page(gfp); + gfp &= ~__GFP_HIGHMEM; + + ptdesc = pagetable_alloc(gfp, 0); + if (!ptdesc) + return NULL; + return ptdesc_address(ptdesc); } #ifndef __HAVE_ARCH_PUD_ALLOC_ONE /** - * pud_alloc_one - allocate a page for PUD-level page table + * pud_alloc_one - allocate memory for a PUD-level page table * @mm: the mm_struct of the current context * - * Allocates a page using %GFP_PGTABLE_USER for user context and - * %GFP_PGTABLE_KERNEL for kernel context. + * Allocate memory for a page table using %GFP_PGTABLE_USER for user context + * and %GFP_PGTABLE_KERNEL for kernel context. * * Return: pointer to the allocated memory or %NULL on error */ @@ -175,7 +191,7 @@ static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr) static inline void __pud_free(struct mm_struct *mm, pud_t *pud) { BUG_ON((unsigned long)pud & (PAGE_SIZE-1)); - free_page((unsigned long)pud); + pagetable_free(virt_to_ptdesc(pud)); } #ifndef __HAVE_ARCH_PUD_FREE @@ -190,7 +206,7 @@ static inline void pud_free(struct mm_struct *mm, pud_t *pud) #ifndef __HAVE_ARCH_PGD_FREE static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - free_page((unsigned long)pgd); + pagetable_free(virt_to_ptdesc(pgd)); } #endif -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579039.906914 (Exim 4.92) (envelope-from ) id 1qT9Jx-0002bj-UQ; Mon, 07 Aug 2023 23:07:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579039.906914; Mon, 07 Aug 2023 23:07:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Jx-0002bG-M8; Mon, 07 Aug 2023 23:07:29 +0000 Received: by outflank-mailman (input) for mailman id 579039; Mon, 07 Aug 2023 23:07:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IK-0001NY-NN for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:48 +0000 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [2607:f8b0:4864:20::112c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1a1d806-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:05:47 +0200 (CEST) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-583a8596e2aso47382717b3.1 for ; Mon, 07 Aug 2023 16:05:47 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1a1d806-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449546; x=1692054346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KTxrIV2g+RQp8x48kTjbks2V3Qkjrf9giqtKYKQ6wMQ=; b=bESfOv3fJjl6S2bDdKG26ChK560t/KurCf2BuIVrJugWlIetZAY8dkm3BlRqTb5F9h MmCd+fJD3FYKnm/uPsZqzHHfYqRAfZJ6edPW59b/mfQy9OnVPplxToH74IAxvuQBpZIp niQgR35WlLiV2T1WK1prVa+1DAnr9uCehUPSrpK2bRog9p7trBe4LuQ5wQtTiaXMkeR6 5WiqV9YMt9t6YbF2oMIpXApkWHFh9QOYyGn6c4/FtI6WKINzWjkgGMiBWrQM5L6cS45e +OyFkksfoYTyAHJrwLrJApoTt8RQXAw2BsSDClQbHPobWbdTJ6uW2JVwGx2BjRuJHUGC 6BBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449546; x=1692054346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTxrIV2g+RQp8x48kTjbks2V3Qkjrf9giqtKYKQ6wMQ=; b=V6/HiMwqQC3vC5WmUpx6bwl+mX9Jn2YghF7wSbzVgk2IbejXrTKkVo3HyREwSwsoRR zc06i0I9rx+Po+YHxfPTaid9thgoM2urew6l9WbjC4b2Jy7EYxrxBP3hJmI3d2pxjzNl 7ZmfBX7RTedDg1KOEQV/ZbJnZu7233bWB7WNVNCCBPPBNWJknmv6UmY5D1DHKgsb6lEu A2VPcgTcClVTYpwIfLXUGdkDmlkGQkEfZNsjok4ch6kWOAVowU8zUjxiNOgiR/jO5evw Hx5uQ64cmN7uD+vYsgrZxdvC7uXul2ep7bspxRxcsgkPY/KtDYjzEkBjqGGJHFALTQ7C EUYw== X-Gm-Message-State: AOJu0Yx23XDa17tcgNvP2TUaVBMO81XU3r4PIgomBjLTB7Y5L5qto7L3 BszbsxxrC385NgsqsruyV8s= X-Google-Smtp-Source: AGHT+IEbeU2d+G/u3Omk8ALzIFtGElW92WFOhX86na7K18OIxELxvZjq1aqGQvka/NS+TcgqvjsoPw== X-Received: by 2002:a25:d08:0:b0:d1c:7549:4e8b with SMTP id 8-20020a250d08000000b00d1c75494e8bmr8202835ybn.29.1691449546593; Mon, 07 Aug 2023 16:05:46 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , David Hildenbrand , Claudio Imbrenda , Mike Rapoport Subject: [PATCH mm-unstable v9 14/31] s390: Convert various pgalloc functions to use ptdescs Date: Mon, 7 Aug 2023 16:04:56 -0700 Message-Id: <20230807230513.102486-15-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/s390/include/asm/pgalloc.h | 4 +- arch/s390/include/asm/tlb.h | 4 +- arch/s390/mm/pgalloc.c | 128 ++++++++++++++++---------------- 3 files changed, 69 insertions(+), 67 deletions(-) diff --git a/arch/s390/include/asm/pgalloc.h b/arch/s390/include/asm/pgalloc.h index 89a9d5ef94f8..376b4b23bdaa 100644 --- a/arch/s390/include/asm/pgalloc.h +++ b/arch/s390/include/asm/pgalloc.h @@ -86,7 +86,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long vmaddr) if (!table) return NULL; crst_table_init(table, _SEGMENT_ENTRY_EMPTY); - if (!pgtable_pmd_page_ctor(virt_to_page(table))) { + if (!pagetable_pmd_ctor(virt_to_ptdesc(table))) { crst_table_free(mm, table); return NULL; } @@ -97,7 +97,7 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd) { if (mm_pmd_folded(mm)) return; - pgtable_pmd_page_dtor(virt_to_page(pmd)); + pagetable_pmd_dtor(virt_to_ptdesc(pmd)); crst_table_free(mm, (unsigned long *) pmd); } diff --git a/arch/s390/include/asm/tlb.h b/arch/s390/include/asm/tlb.h index b91f4a9b044c..383b1f91442c 100644 --- a/arch/s390/include/asm/tlb.h +++ b/arch/s390/include/asm/tlb.h @@ -89,12 +89,12 @@ static inline void pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, { if (mm_pmd_folded(tlb->mm)) return; - pgtable_pmd_page_dtor(virt_to_page(pmd)); + pagetable_pmd_dtor(virt_to_ptdesc(pmd)); __tlb_adjust_range(tlb, address, PAGE_SIZE); tlb->mm->context.flush_mm = 1; tlb->freed_tables = 1; tlb->cleared_puds = 1; - tlb_remove_table(tlb, pmd); + tlb_remove_ptdesc(tlb, pmd); } /* diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index d7374add7820..07fc660a24aa 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -43,17 +43,17 @@ __initcall(page_table_register_sysctl); unsigned long *crst_table_alloc(struct mm_struct *mm) { - struct page *page = alloc_pages(GFP_KERNEL, CRST_ALLOC_ORDER); + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, CRST_ALLOC_ORDER); - if (!page) + if (!ptdesc) return NULL; - arch_set_page_dat(page, CRST_ALLOC_ORDER); - return (unsigned long *) page_to_virt(page); + arch_set_page_dat(ptdesc_page(ptdesc), CRST_ALLOC_ORDER); + return (unsigned long *) ptdesc_to_virt(ptdesc); } void crst_table_free(struct mm_struct *mm, unsigned long *table) { - free_pages((unsigned long)table, CRST_ALLOC_ORDER); + pagetable_free(virt_to_ptdesc(table)); } static void __crst_table_upgrade(void *arg) @@ -140,21 +140,21 @@ static inline unsigned int atomic_xor_bits(atomic_t *v, unsigned int bits) struct page *page_table_alloc_pgste(struct mm_struct *mm) { - struct page *page; + struct ptdesc *ptdesc; u64 *table; - page = alloc_page(GFP_KERNEL); - if (page) { - table = (u64 *)page_to_virt(page); + ptdesc = pagetable_alloc(GFP_KERNEL, 0); + if (ptdesc) { + table = (u64 *)ptdesc_to_virt(ptdesc); memset64(table, _PAGE_INVALID, PTRS_PER_PTE); memset64(table + PTRS_PER_PTE, 0, PTRS_PER_PTE); } - return page; + return ptdesc_page(ptdesc); } void page_table_free_pgste(struct page *page) { - __free_page(page); + pagetable_free(page_ptdesc(page)); } #endif /* CONFIG_PGSTE */ @@ -242,7 +242,7 @@ void page_table_free_pgste(struct page *page) unsigned long *page_table_alloc(struct mm_struct *mm) { unsigned long *table; - struct page *page; + struct ptdesc *ptdesc; unsigned int mask, bit; /* Try to get a fragment of a 4K page as a 2K page table */ @@ -250,9 +250,9 @@ unsigned long *page_table_alloc(struct mm_struct *mm) table = NULL; spin_lock_bh(&mm->context.lock); if (!list_empty(&mm->context.pgtable_list)) { - page = list_first_entry(&mm->context.pgtable_list, - struct page, lru); - mask = atomic_read(&page->_refcount) >> 24; + ptdesc = list_first_entry(&mm->context.pgtable_list, + struct ptdesc, pt_list); + mask = atomic_read(&ptdesc->_refcount) >> 24; /* * The pending removal bits must also be checked. * Failure to do so might lead to an impossible @@ -264,13 +264,13 @@ unsigned long *page_table_alloc(struct mm_struct *mm) */ mask = (mask | (mask >> 4)) & 0x03U; if (mask != 0x03U) { - table = (unsigned long *) page_to_virt(page); + table = (unsigned long *) ptdesc_to_virt(ptdesc); bit = mask & 1; /* =1 -> second 2K */ if (bit) table += PTRS_PER_PTE; - atomic_xor_bits(&page->_refcount, + atomic_xor_bits(&ptdesc->_refcount, 0x01U << (bit + 24)); - list_del_init(&page->lru); + list_del_init(&ptdesc->pt_list); } } spin_unlock_bh(&mm->context.lock); @@ -278,28 +278,28 @@ unsigned long *page_table_alloc(struct mm_struct *mm) return table; } /* Allocate a fresh page */ - page = alloc_page(GFP_KERNEL); - if (!page) + ptdesc = pagetable_alloc(GFP_KERNEL, 0); + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!pagetable_pte_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - arch_set_page_dat(page, 0); + arch_set_page_dat(ptdesc_page(ptdesc), 0); /* Initialize page table */ - table = (unsigned long *) page_to_virt(page); + table = (unsigned long *) ptdesc_to_virt(ptdesc); if (mm_alloc_pgste(mm)) { /* Return 4K page table with PGSTEs */ - INIT_LIST_HEAD(&page->lru); - atomic_xor_bits(&page->_refcount, 0x03U << 24); + INIT_LIST_HEAD(&ptdesc->pt_list); + atomic_xor_bits(&ptdesc->_refcount, 0x03U << 24); memset64((u64 *)table, _PAGE_INVALID, PTRS_PER_PTE); memset64((u64 *)table + PTRS_PER_PTE, 0, PTRS_PER_PTE); } else { /* Return the first 2K fragment of the page */ - atomic_xor_bits(&page->_refcount, 0x01U << 24); + atomic_xor_bits(&ptdesc->_refcount, 0x01U << 24); memset64((u64 *)table, _PAGE_INVALID, 2 * PTRS_PER_PTE); spin_lock_bh(&mm->context.lock); - list_add(&page->lru, &mm->context.pgtable_list); + list_add(&ptdesc->pt_list, &mm->context.pgtable_list); spin_unlock_bh(&mm->context.lock); } return table; @@ -322,19 +322,18 @@ static void page_table_release_check(struct page *page, void *table, static void pte_free_now(struct rcu_head *head) { - struct page *page; + struct ptdesc *ptdesc; - page = container_of(head, struct page, rcu_head); - pgtable_pte_page_dtor(page); - __free_page(page); + ptdesc = container_of(head, struct ptdesc, pt_rcu_head); + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } void page_table_free(struct mm_struct *mm, unsigned long *table) { unsigned int mask, bit, half; - struct page *page; + struct ptdesc *ptdesc = virt_to_ptdesc(table); - page = virt_to_page(table); if (!mm_alloc_pgste(mm)) { /* Free 2K page table fragment of a 4K page */ bit = ((unsigned long) table & ~PAGE_MASK)/(PTRS_PER_PTE*sizeof(pte_t)); @@ -344,51 +343,50 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) * will happen outside of the critical section from this * function or from __tlb_remove_table() */ - mask = atomic_xor_bits(&page->_refcount, 0x11U << (bit + 24)); + mask = atomic_xor_bits(&ptdesc->_refcount, 0x11U << (bit + 24)); mask >>= 24; - if ((mask & 0x03U) && !PageActive(page)) { + if ((mask & 0x03U) && !folio_test_active(ptdesc_folio(ptdesc))) { /* * Other half is allocated, and neither half has had * its free deferred: add page to head of list, to make * this freed half available for immediate reuse. */ - list_add(&page->lru, &mm->context.pgtable_list); + list_add(&ptdesc->pt_list, &mm->context.pgtable_list); } else { /* If page is on list, now remove it. */ - list_del_init(&page->lru); + list_del_init(&ptdesc->pt_list); } spin_unlock_bh(&mm->context.lock); - mask = atomic_xor_bits(&page->_refcount, 0x10U << (bit + 24)); + mask = atomic_xor_bits(&ptdesc->_refcount, 0x10U << (bit + 24)); mask >>= 24; if (mask != 0x00U) return; half = 0x01U << bit; } else { half = 0x03U; - mask = atomic_xor_bits(&page->_refcount, 0x03U << 24); + mask = atomic_xor_bits(&ptdesc->_refcount, 0x03U << 24); mask >>= 24; } - page_table_release_check(page, table, half, mask); - if (TestClearPageActive(page)) - call_rcu(&page->rcu_head, pte_free_now); + page_table_release_check(ptdesc_page(ptdesc), table, half, mask); + if (folio_test_clear_active(ptdesc_folio(ptdesc))) + call_rcu(&ptdesc->pt_rcu_head, pte_free_now); else - pte_free_now(&page->rcu_head); + pte_free_now(&ptdesc->pt_rcu_head); } void page_table_free_rcu(struct mmu_gather *tlb, unsigned long *table, unsigned long vmaddr) { struct mm_struct *mm; - struct page *page; unsigned int bit, mask; + struct ptdesc *ptdesc = virt_to_ptdesc(table); mm = tlb->mm; - page = virt_to_page(table); if (mm_alloc_pgste(mm)) { gmap_unlink(mm, table, vmaddr); table = (unsigned long *) ((unsigned long)table | 0x03U); - tlb_remove_table(tlb, table); + tlb_remove_ptdesc(tlb, table); return; } bit = ((unsigned long) table & ~PAGE_MASK) / (PTRS_PER_PTE*sizeof(pte_t)); @@ -398,19 +396,19 @@ void page_table_free_rcu(struct mmu_gather *tlb, unsigned long *table, * outside of the critical section from __tlb_remove_table() or from * page_table_free() */ - mask = atomic_xor_bits(&page->_refcount, 0x11U << (bit + 24)); + mask = atomic_xor_bits(&ptdesc->_refcount, 0x11U << (bit + 24)); mask >>= 24; - if ((mask & 0x03U) && !PageActive(page)) { + if ((mask & 0x03U) && !folio_test_active(ptdesc_folio(ptdesc))) { /* * Other half is allocated, and neither half has had * its free deferred: add page to end of list, to make * this freed half available for reuse once its pending * bit has been cleared by __tlb_remove_table(). */ - list_add_tail(&page->lru, &mm->context.pgtable_list); + list_add_tail(&ptdesc->pt_list, &mm->context.pgtable_list); } else { /* If page is on list, now remove it. */ - list_del_init(&page->lru); + list_del_init(&ptdesc->pt_list); } spin_unlock_bh(&mm->context.lock); table = (unsigned long *) ((unsigned long) table | (0x01U << bit)); @@ -421,30 +419,30 @@ void __tlb_remove_table(void *_table) { unsigned int mask = (unsigned long) _table & 0x03U, half = mask; void *table = (void *)((unsigned long) _table ^ mask); - struct page *page = virt_to_page(table); + struct ptdesc *ptdesc = virt_to_ptdesc(table); switch (half) { case 0x00U: /* pmd, pud, or p4d */ - free_pages((unsigned long)table, CRST_ALLOC_ORDER); + pagetable_free(ptdesc); return; case 0x01U: /* lower 2K of a 4K page table */ case 0x02U: /* higher 2K of a 4K page table */ - mask = atomic_xor_bits(&page->_refcount, mask << (4 + 24)); + mask = atomic_xor_bits(&ptdesc->_refcount, mask << (4 + 24)); mask >>= 24; if (mask != 0x00U) return; break; case 0x03U: /* 4K page table with pgstes */ - mask = atomic_xor_bits(&page->_refcount, 0x03U << 24); + mask = atomic_xor_bits(&ptdesc->_refcount, 0x03U << 24); mask >>= 24; break; } - page_table_release_check(page, table, half, mask); - if (TestClearPageActive(page)) - call_rcu(&page->rcu_head, pte_free_now); + page_table_release_check(ptdesc_page(ptdesc), table, half, mask); + if (folio_test_clear_active(ptdesc_folio(ptdesc))) + call_rcu(&ptdesc->pt_rcu_head, pte_free_now); else - pte_free_now(&page->rcu_head); + pte_free_now(&ptdesc->pt_rcu_head); } #ifdef CONFIG_TRANSPARENT_HUGEPAGE @@ -488,16 +486,20 @@ static void base_pgt_free(unsigned long *table) static unsigned long *base_crst_alloc(unsigned long val) { unsigned long *table; + struct ptdesc *ptdesc; - table = (unsigned long *)__get_free_pages(GFP_KERNEL, CRST_ALLOC_ORDER); - if (table) - crst_table_init(table, val); + ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, CRST_ALLOC_ORDER); + if (!ptdesc) + return NULL; + table = ptdesc_address(ptdesc); + + crst_table_init(table, val); return table; } static void base_crst_free(unsigned long *table) { - free_pages((unsigned long)table, CRST_ALLOC_ORDER); + pagetable_free(virt_to_ptdesc(table)); } #define BASE_ADDR_END_FUNC(NAME, SIZE) \ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579040.906918 (Exim 4.92) (envelope-from ) id 1qT9Jy-0002fr-G0; Mon, 07 Aug 2023 23:07:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579040.906918; Mon, 07 Aug 2023 23:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Jy-0002em-4g; Mon, 07 Aug 2023 23:07:30 +0000 Received: by outflank-mailman (input) for mailman id 579040; Mon, 07 Aug 2023 23:07:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Id-0001NS-MK for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:07 +0000 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [2607:f8b0:4864:20::1131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb6e887d-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:04 +0200 (CEST) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-583c48a9aa1so52641847b3.1 for ; Mon, 07 Aug 2023 16:06:04 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb6e887d-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449563; x=1692054363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b5UN203jFDiNo/YHJ5VSjgxwvcpHMPrLplz2RQSMCvk=; b=OTPDdNMzu7YNnKXhv+Q3ZqqlENNm5aYdj6D71YWlelfDeuCfloDRpvW/2blg63fLEM wp2lqLun+gv7jM76tgF3SL5EUSik6EQoGHQg/la3vssrqrbUd6clAJJZm9oTnkSFnW3p rrak3TkX2TlgthUOthGhnmNqe2u92uklZfoOWmy63Mi41aONrji7aHLiDQehYWfjAdaZ soPZkqDTfcWv3Jopxt6sr0srYUxYWkTWEBaSK7GkVRhdyRSTtqcke1kGItccZqtqhkia YtUOs+TmHqOaN+5n3hq45fmviaiyb+cOIccc/DlZdoNJ1+R3sKq7dO2/Ljgq8Rru35Tt Yo/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449563; x=1692054363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b5UN203jFDiNo/YHJ5VSjgxwvcpHMPrLplz2RQSMCvk=; b=HfY6+EkRwf7PyBwl0XFHD3xE+oRdNy+4KRnFdcYQFC3Ptx5KXhmTGXs4at+ex9AxHQ ueqqEEa6PNqoEdFBzHn5ojx8ylg/FthPYTaR5I4+4oYHRX6fUtSzhcQjZlCmb/rk17C0 pZF0SBCDm3iJ9jziM/0lVD76P8l6OqamrnnYH1bk7ZriRKVBqL0FUluHIhsZjmmMQqMV evHHF6L2gORVCd0UL6Gan33KMa5FEORNqS9vpSYJwPIwoF6VxzmAfWKFQdY2BirmvBY5 yvkwuYzbY8iyICK1cAkNcpL5eBUoOm17CNl4lqxRQSJFc+Fld3p+h0Uk5e1FJb4mFKQD 0Caw== X-Gm-Message-State: AOJu0YzjBzWgxnhN2wz9ntd9FqXLIx/7pB7KRHj7/4pVGku4wfJ+fj8D zkfRtYDHgHMNNV5CrmpcIgA= X-Google-Smtp-Source: AGHT+IGso2idiavqhjdtI0le+b51Epzt0Ore5+PmjI6n65mRaKN/pRbN2Fu2wELJlR9Tq3E7Uha1dg== X-Received: by 2002:a25:be08:0:b0:d0e:2e5c:2f80 with SMTP id h8-20020a25be08000000b00d0e2e5c2f80mr8938705ybk.64.1691449563064; Mon, 07 Aug 2023 16:06:03 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport , Geert Uytterhoeven Subject: [PATCH mm-unstable v9 22/31] m68k: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:05:04 -0700 Message-Id: <20230807230513.102486-23-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Acked-by: Mike Rapoport (IBM) Acked-by: Geert Uytterhoeven Signed-off-by: Vishal Moola (Oracle) --- arch/m68k/include/asm/mcf_pgalloc.h | 47 ++++++++++++++-------------- arch/m68k/include/asm/sun3_pgalloc.h | 8 ++--- arch/m68k/mm/motorola.c | 4 +-- 3 files changed, 30 insertions(+), 29 deletions(-) diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h index 5c2c0a864524..302c5bf67179 100644 --- a/arch/m68k/include/asm/mcf_pgalloc.h +++ b/arch/m68k/include/asm/mcf_pgalloc.h @@ -5,22 +5,22 @@ #include #include -extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) +static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) { - free_page((unsigned long) pte); + pagetable_free(virt_to_ptdesc(pte)); } extern const char bad_pmd_string[]; -extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) +static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) { - unsigned long page = __get_free_page(GFP_DMA); + struct ptdesc *ptdesc = pagetable_alloc((GFP_DMA | __GFP_ZERO) & + ~__GFP_HIGHMEM, 0); - if (!page) + if (!ptdesc) return NULL; - memset((void *)page, 0, PAGE_SIZE); - return (pte_t *) (page); + return ptdesc_address(ptdesc); } extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) @@ -35,36 +35,34 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pgtable, unsigned long address) { - struct page *page = virt_to_page(pgtable); + struct ptdesc *ptdesc = virt_to_ptdesc(pgtable); - pgtable_pte_page_dtor(page); - __free_page(page); + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } static inline pgtable_t pte_alloc_one(struct mm_struct *mm) { - struct page *page = alloc_pages(GFP_DMA, 0); + struct ptdesc *ptdesc = pagetable_alloc(GFP_DMA | __GFP_ZERO, 0); pte_t *pte; - if (!page) + if (!ptdesc) return NULL; - if (!pgtable_pte_page_ctor(page)) { - __free_page(page); + if (!pagetable_pte_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - pte = page_address(page); - clear_page(pte); - + pte = ptdesc_address(ptdesc); return pte; } static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable) { - struct page *page = virt_to_page(pgtable); + struct ptdesc *ptdesc = virt_to_ptdesc(pgtable); - pgtable_pte_page_dtor(page); - __free_page(page); + pagetable_pte_dtor(ptdesc); + pagetable_free(ptdesc); } /* @@ -75,16 +73,19 @@ static inline void pte_free(struct mm_struct *mm, pgtable_t pgtable) static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - free_page((unsigned long) pgd); + pagetable_free(virt_to_ptdesc(pgd)); } static inline pgd_t *pgd_alloc(struct mm_struct *mm) { pgd_t *new_pgd; + struct ptdesc *ptdesc = pagetable_alloc((GFP_DMA | __GFP_NOWARN) & + ~__GFP_HIGHMEM, 0); - new_pgd = (pgd_t *)__get_free_page(GFP_DMA | __GFP_NOWARN); - if (!new_pgd) + if (!ptdesc) return NULL; + new_pgd = ptdesc_address(ptdesc); + memcpy(new_pgd, swapper_pg_dir, PTRS_PER_PGD * sizeof(pgd_t)); memset(new_pgd, 0, PAGE_OFFSET >> PGDIR_SHIFT); return new_pgd; diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index 198036aff519..ff48573db2c0 100644 --- a/arch/m68k/include/asm/sun3_pgalloc.h +++ b/arch/m68k/include/asm/sun3_pgalloc.h @@ -17,10 +17,10 @@ extern const char bad_pmd_string[]; -#define __pte_free_tlb(tlb,pte,addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte) diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c index 8bca46e51e94..c1761d309fc6 100644 --- a/arch/m68k/mm/motorola.c +++ b/arch/m68k/mm/motorola.c @@ -161,7 +161,7 @@ void *get_pointer_table(int type) * m68k doesn't have SPLIT_PTE_PTLOCKS for not having * SMP. */ - pgtable_pte_page_ctor(virt_to_page(page)); + pagetable_pte_ctor(virt_to_ptdesc(page)); } mmu_page_ctor(page); @@ -201,7 +201,7 @@ int free_pointer_table(void *table, int type) list_del(dp); mmu_page_dtor((void *)page); if (type == TABLE_PTE) - pgtable_pte_page_dtor(virt_to_page((void *)page)); + pagetable_pte_dtor(virt_to_ptdesc((void *)page)); free_page (page); return 1; } else if (ptable_list[type].next != dp) { -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579044.906925 (Exim 4.92) (envelope-from ) id 1qT9Jz-0002rk-IB; Mon, 07 Aug 2023 23:07:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579044.906925; Mon, 07 Aug 2023 23:07:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Jz-0002oF-2T; Mon, 07 Aug 2023 23:07:31 +0000 Received: by outflank-mailman (input) for mailman id 579044; Mon, 07 Aug 2023 23:07:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9It-0001NS-77 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:23 +0000 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [2607:f8b0:4864:20::b30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 05dc7ba9-3577-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:21 +0200 (CEST) Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-d299ed34bacso8703918276.1 for ; Mon, 07 Aug 2023 16:06:21 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05dc7ba9-3577-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449580; x=1692054380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T9QlLO1dPeyZnWI5hHw1TuJlTK1nfQVgIvIYX0JocUU=; b=ZmZBlK2BE47dPXTqc8IQ1uTKCUobrHijjQnotS76WbJUUgCGVOPFVEmsLAOFQve7Mq 8k04A5/AuFSS607BBJG/Nd5XpAmnH5zPypJPEnlo7r978iqN52fpsMDyDxOev3Z41hLb CpvzpxqdWGHuM0xgZvYoYbOi2GTwb0pfPUe0oyJziB36Q6lozhNOIAq2JTvWjnhFdQ2U 4BFxzsH5/HG/XXl5/YPVavhDi3L4gvkLB1NxxGw9654yYac9diJlEe3+5Z8y0K4G8C7u mJwXJ96QObfNW/oMJd7PgnIP4//NNbVjGeiAj0SJF/1wFKYAbBETcCfRmwi4qkbVDTFa RY/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449580; x=1692054380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T9QlLO1dPeyZnWI5hHw1TuJlTK1nfQVgIvIYX0JocUU=; b=QG3GsaFOlqX/hDzKUYg3wAc8G+wZVdcn6+iitxkAeFnwrdsa3EPfzYdHMpl7Ubvfw2 A5hWWOYpPJNjAQ2eAW/dfEpFprr9jN+rBVvSdoD0AXylRDWYq6lwuJww0bfdXw45PYAP i+0C153C2IccOPyGlOA4R/kHvTOId0PAW3HBFO5T6Sygu3HzQ6Vmn3oqSkTiW68H/sOd 84a9oUhIc2MzUL7n9BgaQRm8qGNm1tkTIV/Szpx73mZNUO/5qSx+S+y2KYh36eXViJ29 8nHRRtYji9sMq+C4dkVWcELFi1vB2o03td0odrY6wtekn4XcLI9gRuWCqqEEfRZsAInV dHag== X-Gm-Message-State: AOJu0YwgEQMtpV3OPsTjGZUMvjpUhw5j4V3Ku5rCIyIXDbDMNvIJVKPo 5kFNVyOiZqV947qJJnsk2dI= X-Google-Smtp-Source: AGHT+IFhMlpHJ+7onf6BYxf2ZEVLLZTaCynnVlAbd/4Vka+RTYiQ5OXzXPwOq0O9emhI9trC6wG3Sw== X-Received: by 2002:a5b:f8c:0:b0:d0b:7e30:6d17 with SMTP id q12-20020a5b0f8c000000b00d0b7e306d17mr8498276ybh.14.1691449580620; Mon, 07 Aug 2023 16:06:20 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Richard Weinberger , Mike Rapoport Subject: [PATCH mm-unstable v9 30/31] um: Convert {pmd, pte}_free_tlb() to use ptdescs Date: Mon, 7 Aug 2023 16:05:12 -0700 Message-Id: <20230807230513.102486-31-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/um/include/asm/pgalloc.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h index 8ec7cd46dd96..de5e31c64793 100644 --- a/arch/um/include/asm/pgalloc.h +++ b/arch/um/include/asm/pgalloc.h @@ -25,19 +25,19 @@ */ extern pgd_t *pgd_alloc(struct mm_struct *); -#define __pte_free_tlb(tlb,pte, address) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb),(pte)); \ +#define __pte_free_tlb(tlb, pte, address) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #ifdef CONFIG_3_LEVEL_PGTABLES -#define __pmd_free_tlb(tlb, pmd, address) \ -do { \ - pgtable_pmd_page_dtor(virt_to_page(pmd)); \ - tlb_remove_page((tlb),virt_to_page(pmd)); \ -} while (0) \ +#define __pmd_free_tlb(tlb, pmd, address) \ +do { \ + pagetable_pmd_dtor(virt_to_ptdesc(pmd)); \ + tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd)); \ +} while (0) #endif -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579045.906931 (Exim 4.92) (envelope-from ) id 1qT9K0-0002zd-7x; Mon, 07 Aug 2023 23:07:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579045.906931; Mon, 07 Aug 2023 23:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Jz-0002y4-O5; Mon, 07 Aug 2023 23:07:31 +0000 Received: by outflank-mailman (input) for mailman id 579045; Mon, 07 Aug 2023 23:07:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ie-0001NS-Ma for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:08 +0000 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [2607:f8b0:4864:20::112e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcbd8f71-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:06 +0200 (CEST) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5768a7e3adbso87638447b3.0 for ; Mon, 07 Aug 2023 16:06:06 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcbd8f71-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449565; x=1692054365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SCvcoKWLGx6gAjym9VWVFszZElqPM/KxU0nQCUs9lhU=; b=UEUmdRWyflXklFyhNX736vuEaqgiuaE747b2iDMdbsntaDVnz91uxqlH5BcdgyOH5x uvJaTvPkpQGN9akIqApZ8zKHvLZguej6njtjOnVMX/cM5jmsFezl/LYYVYVkbeho4b0z HHNTILzp+Xc4v6kzsuUo73oAPiN0CJazQDUAwcPLlet/lIEFQgMVrv8B24qA6Hz5wjkw b8w6Ifa5zhm6L11dsVrnJ9eA4XJTM6QxI5QWilhFcSjtgNKdoGywloLoSOAO6BZpBMSb 8CiRrKjceUBw/RGFjWiyE5TzR9GZJ5T3ThAn9ujnfgeZbAfe+0n8PqgNKPCIQtpGYCsJ QRzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449565; x=1692054365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SCvcoKWLGx6gAjym9VWVFszZElqPM/KxU0nQCUs9lhU=; b=R3JunrGGIQG4Q5OK2PgYMTv1KGtPqRpCwyJobbEGp9haYT7vep3l4hkE/VQYH++fYD KarZ6YZrbkZCUVdkkBlsJMaTJoXg29ivTwpUJjCDD/1/bmz1JDU9ZaybWm42CtQ4dYqk h6g1vByCcFsfJPkamPkdK8TmRqK9kqNX33Mf8wSxX2rfL7PrB6b7Yy8gg02+hnCLQFPz WqMzODD3i/AnMeGXGpk+WJtjy67hGPPtS6lFLCO4zukAIMdmvGDQ3RdultwbFfgnG15F NjjjmDSgvlzEKS/wdX6F7aRnGy2v9ah7i9BXzhPiV7wv58wI5IcBAePP+lo5+vBbq78b GKYQ== X-Gm-Message-State: AOJu0Yzxxp94PQD0eNt918+CMDtmGiHxVoGeT/Cv+CQcRt8WwyiohYdS ubtgaGEKZ8H/g3qcooQ0F3s= X-Google-Smtp-Source: AGHT+IEqzmUPQsWPkdBtUj3V9QXK122J73o4hp/g5UvHeQgKIN7qrVubtY48PFSpogl4MBW4UXPeVQ== X-Received: by 2002:a25:944:0:b0:cb4:6167:a69c with SMTP id u4-20020a250944000000b00cb46167a69cmr9868214ybm.8.1691449565251; Mon, 07 Aug 2023 16:06:05 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Thomas Bogendoerfer , Mike Rapoport Subject: [PATCH mm-unstable v9 23/31] mips: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:05:05 -0700 Message-Id: <20230807230513.102486-24-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/mips/include/asm/pgalloc.h | 32 ++++++++++++++++++-------------- arch/mips/mm/pgtable.c | 8 +++++--- 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index f72e737dda21..40e40a7eb94a 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -51,13 +51,13 @@ extern pgd_t *pgd_alloc(struct mm_struct *mm); static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd) { - free_pages((unsigned long)pgd, PGD_TABLE_ORDER); + pagetable_free(virt_to_ptdesc(pgd)); } -#define __pte_free_tlb(tlb,pte,address) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +#define __pte_free_tlb(tlb, pte, address) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #ifndef __PAGETABLE_PMD_FOLDED @@ -65,18 +65,18 @@ do { \ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) { pmd_t *pmd; - struct page *pg; + struct ptdesc *ptdesc; - pg = alloc_pages(GFP_KERNEL_ACCOUNT, PMD_TABLE_ORDER); - if (!pg) + ptdesc = pagetable_alloc(GFP_KERNEL_ACCOUNT, PMD_TABLE_ORDER); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(pg)) { - __free_pages(pg, PMD_TABLE_ORDER); + if (!pagetable_pmd_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - pmd = (pmd_t *)page_address(pg); + pmd = ptdesc_address(ptdesc); pmd_init(pmd); return pmd; } @@ -90,10 +90,14 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address) { pud_t *pud; + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, + PUD_TABLE_ORDER); - pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_TABLE_ORDER); - if (pud) - pud_init(pud); + if (!ptdesc) + return NULL; + pud = ptdesc_address(ptdesc); + + pud_init(pud); return pud; } diff --git a/arch/mips/mm/pgtable.c b/arch/mips/mm/pgtable.c index b13314be5d0e..1506e458040d 100644 --- a/arch/mips/mm/pgtable.c +++ b/arch/mips/mm/pgtable.c @@ -10,10 +10,12 @@ pgd_t *pgd_alloc(struct mm_struct *mm) { - pgd_t *ret, *init; + pgd_t *init, *ret = NULL; + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, + PGD_TABLE_ORDER); - ret = (pgd_t *) __get_free_pages(GFP_KERNEL, PGD_TABLE_ORDER); - if (ret) { + if (ptdesc) { + ret = ptdesc_address(ptdesc); init = pgd_offset(&init_mm, 0UL); pgd_init(ret); memcpy(ret + USER_PTRS_PER_PGD, init + USER_PTRS_PER_PGD, -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579047.906938 (Exim 4.92) (envelope-from ) id 1qT9K1-00038F-2Q; Mon, 07 Aug 2023 23:07:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579047.906938; Mon, 07 Aug 2023 23:07:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9K0-00034h-B6; Mon, 07 Aug 2023 23:07:32 +0000 Received: by outflank-mailman (input) for mailman id 579047; Mon, 07 Aug 2023 23:07:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ib-0001NS-M1 for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:05 +0000 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [2607:f8b0:4864:20::b30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa41787b-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:02 +0200 (CEST) Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-d4789fd9317so2925221276.1 for ; Mon, 07 Aug 2023 16:06:02 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa41787b-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449561; x=1692054361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VD2saKmHCgP979K/4Ur2DZD5lv+pCsAy+26MDZ4lRXE=; b=KaA5Xf0Zq7VankK3QOvVnhKCvDQA0idGZ5r/QtBaYpBUZhM7IUDDnipX0Mck9NuTr6 FMzfUiWHWV61utAYtiNJjvsmZyQrjEGqV1vWWuYtjGooZk9wKA6pHj8JXiEh77Vd66gm gq9wCdtohtsBXI+QiM0g5DM3RYb5yVm35tcAKNI7nQZaFVODWjyuyXisRnjCevekbcDp QweW3qBvEiOtjGdP8+KO+Ai79xaww40f8oFcpzIoZ31G0t7vkt4E3RfT7Asw6Y6mNUmW 4v5tgaFeOHT3yezqwQ6Pv7HkjczS8wtW/o3vWALkNkC7/L83lM6ERIvU0onlnalg95pZ XQOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449561; x=1692054361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VD2saKmHCgP979K/4Ur2DZD5lv+pCsAy+26MDZ4lRXE=; b=Y5V8yPmQ90rBDY9TLUXh7DxkIJIqkY5+/P7oHorOO1kt33P8OHri1SQZ4FPsm2vHNT IBmQRKX18IzwCNIw2bJ8gRhNyCw18YpmACX7WkxytpLXBFxNhI9W18QVtYyAlWlNbQ/k LDyFtWtDbIiCn+J8/OrSybRHT/yqrbHbDKgGBvV3ciS3Sgi4A497hmMgEP0mdgcVFgq4 pFCmsE1Prp88HwLASb1/MPO2QFH9xVjMZKuNgj/Imyue8S0KQMH9oRRHGMltprikpPzb 9rmelENw25l9zBXc+QHwwotEh+8eppJ0ozU11ZMfNmfOlF2zsKe/1Di7hERGnduRgNf+ 1jzA== X-Gm-Message-State: AOJu0YxTxYOMXxVN1xuREVqGagJL8AR+MUtEgKtxY9Xk3eP3AgMEh3Ch baFO/EICASx29Su02J3WHko= X-Google-Smtp-Source: AGHT+IGT7jcZ858GNZbGv2ymKyHkNCq6k2xr+zx9+OdmxVuwoAhnOKduGJp0I6ObmWSEyVKiLNM8sw== X-Received: by 2002:a25:8210:0:b0:d39:fa2f:8b63 with SMTP id q16-20020a258210000000b00d39fa2f8b63mr13670853ybk.25.1691449561057; Mon, 07 Aug 2023 16:06:01 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Huacai Chen , Mike Rapoport Subject: [PATCH mm-unstable v9 21/31] loongarch: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:05:03 -0700 Message-Id: <20230807230513.102486-22-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/loongarch/include/asm/pgalloc.h | 27 +++++++++++++++------------ arch/loongarch/mm/pgtable.c | 7 ++++--- 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h index af1d1e4a6965..23f5b1107246 100644 --- a/arch/loongarch/include/asm/pgalloc.h +++ b/arch/loongarch/include/asm/pgalloc.h @@ -45,9 +45,9 @@ extern void pagetable_init(void); extern pgd_t *pgd_alloc(struct mm_struct *mm); #define __pte_free_tlb(tlb, pte, address) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), pte); \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ } while (0) #ifndef __PAGETABLE_PMD_FOLDED @@ -55,18 +55,18 @@ do { \ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) { pmd_t *pmd; - struct page *pg; + struct ptdesc *ptdesc; - pg = alloc_page(GFP_KERNEL_ACCOUNT); - if (!pg) + ptdesc = pagetable_alloc(GFP_KERNEL_ACCOUNT, 0); + if (!ptdesc) return NULL; - if (!pgtable_pmd_page_ctor(pg)) { - __free_page(pg); + if (!pagetable_pmd_ctor(ptdesc)) { + pagetable_free(ptdesc); return NULL; } - pmd = (pmd_t *)page_address(pg); + pmd = ptdesc_address(ptdesc); pmd_init(pmd); return pmd; } @@ -80,10 +80,13 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address) { pud_t *pud; + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0); - pud = (pud_t *) __get_free_page(GFP_KERNEL); - if (pud) - pud_init(pud); + if (!ptdesc) + return NULL; + pud = ptdesc_address(ptdesc); + + pud_init(pud); return pud; } diff --git a/arch/loongarch/mm/pgtable.c b/arch/loongarch/mm/pgtable.c index 1260cf30e3ee..b14343e211b6 100644 --- a/arch/loongarch/mm/pgtable.c +++ b/arch/loongarch/mm/pgtable.c @@ -11,10 +11,11 @@ pgd_t *pgd_alloc(struct mm_struct *mm) { - pgd_t *ret, *init; + pgd_t *init, *ret = NULL; + struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0); - ret = (pgd_t *) __get_free_page(GFP_KERNEL); - if (ret) { + if (ptdesc) { + ret = (pgd_t *)ptdesc_address(ptdesc); init = pgd_offset(&init_mm, 0UL); pgd_init(ret); memcpy(ret + USER_PTRS_PER_PGD, init + USER_PTRS_PER_PGD, -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579048.906947 (Exim 4.92) (envelope-from ) id 1qT9K2-0003Yu-Jh; Mon, 07 Aug 2023 23:07:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579048.906947; Mon, 07 Aug 2023 23:07:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9K2-0003U0-0E; Mon, 07 Aug 2023 23:07:34 +0000 Received: by outflank-mailman (input) for mailman id 579048; Mon, 07 Aug 2023 23:07:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IR-0001NS-Fr for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:55 +0000 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [2607:f8b0:4864:20::b2a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f537af55-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:53 +0200 (CEST) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-ccc462deca6so5489192276.0 for ; Mon, 07 Aug 2023 16:05:53 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f537af55-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449552; x=1692054352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mSWx8dFer3K04xJe2FS2V6S19uUh9FiSOjAjYMXRNjw=; b=mEF5uAs6LPH63FkNSBplLFspkb60DHxm6zOnUwvAQJc3E/pOwbhAIiNFZBUYHiCsiM p2tbQp60CKHpnlFx92kmBMq0iICGLFKDwXQ0LyWNPB5CTFYLszQ4c8mEuzgfzEni9mwM Ttmf1qUiq6AjtyU7518jshwfi+pChbC60Sh5kSbXAB+lvEOcHSUd/ZfP7MFS2PgNjGFo r7Bvb+zEwdMz3ovaFVdL7n7AY1JJbQH54hsJVFdRCSvSwoDtl5zIXSCLg5x4eEWrxL65 mP+yB5DlcuhDlbUdEBdiXWCJptk41KogbXQLbDgKd5NU/tlto4itztjaP5et2Hvpw0rt 7VEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449552; x=1692054352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mSWx8dFer3K04xJe2FS2V6S19uUh9FiSOjAjYMXRNjw=; b=M46y74Uj0HWwFr5a/71IlhuZ2i+E2U+QJ9k17WSVTjddXltel713J1eSjLz9KeNGJa 33JuajndOHOqqDhiMp0BK6PNTEwOMLXON7sKwSXUrgHgdDgcrNP3zpa+hhHAP5um3vNG Y04qjraPfe3N5rKE1gUOXn13eeAHKPWosy2c4/wSZlUS+gZ11ebLrHtR9XooQUUE90qz Ba0qqukT8jjr1fg2TJDQ1JDcIaLcwH6sx8nvI3jZvhbMIGonoTdaxXvRo8aHEnka/Dkv wuWEFIMbBj0KNiOvsmazXbyE4yDc0f7JeDhgLK4+2lviNJ16eVmPd8MS8maqH2nbUvPC 6YoA== X-Gm-Message-State: AOJu0YzxYn7bCUgq1HixWvC+wGbVgS2mgVdndovxuM/Yd1mOVmMMuFhp uGOqj9qlmjyFFoj4Sy3FOn8= X-Google-Smtp-Source: AGHT+IFZB5AVL/MxN7IM/ds0EZn0mK90E4BWht9Xyb7zBcTjMbr/Qp8cCY+l+/2imbi83tiWiC1i0w== X-Received: by 2002:a25:4e05:0:b0:d12:3108:f90f with SMTP id c5-20020a254e05000000b00d123108f90fmr10423741ybb.24.1691449552662; Mon, 07 Aug 2023 16:05:52 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Catalin Marinas , Mike Rapoport Subject: [PATCH mm-unstable v9 17/31] arm: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:04:59 -0700 Message-Id: <20230807230513.102486-18-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. late_alloc() also uses the __get_free_pages() helper function. Convert this to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/arm/include/asm/tlb.h | 12 +++++++----- arch/arm/mm/mmu.c | 7 ++++--- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index b8cbe03ad260..f40d06ad5d2a 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -39,7 +39,9 @@ static inline void __tlb_remove_table(void *_table) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) { - pgtable_pte_page_dtor(pte); + struct ptdesc *ptdesc = page_ptdesc(pte); + + pagetable_pte_dtor(ptdesc); #ifndef CONFIG_ARM_LPAE /* @@ -50,17 +52,17 @@ __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) __tlb_adjust_range(tlb, addr - PAGE_SIZE, 2 * PAGE_SIZE); #endif - tlb_remove_table(tlb, pte); + tlb_remove_ptdesc(tlb, ptdesc); } static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) { #ifdef CONFIG_ARM_LPAE - struct page *page = virt_to_page(pmdp); + struct ptdesc *ptdesc = virt_to_ptdesc(pmdp); - pgtable_pmd_page_dtor(page); - tlb_remove_table(tlb, page); + pagetable_pmd_dtor(ptdesc); + tlb_remove_ptdesc(tlb, ptdesc); #endif } diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index c9981c23e8e9..674ed71573a8 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -737,11 +737,12 @@ static void __init *early_alloc(unsigned long sz) static void *__init late_alloc(unsigned long sz) { - void *ptr = (void *)__get_free_pages(GFP_PGTABLE_KERNEL, get_order(sz)); + void *ptdesc = pagetable_alloc(GFP_PGTABLE_KERNEL & ~__GFP_HIGHMEM, + get_order(sz)); - if (!ptr || !pgtable_pte_page_ctor(virt_to_page(ptr))) + if (!ptdesc || !pagetable_pte_ctor(ptdesc)) BUG(); - return ptr; + return ptdesc_to_virt(ptdesc); } static pte_t * __init arm_pte_alloc(pmd_t *pmd, unsigned long addr, -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579050.906955 (Exim 4.92) (envelope-from ) id 1qT9K3-0003g8-K7; Mon, 07 Aug 2023 23:07:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579050.906955; Mon, 07 Aug 2023 23:07:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9K2-0003cz-Ov; Mon, 07 Aug 2023 23:07:34 +0000 Received: by outflank-mailman (input) for mailman id 579050; Mon, 07 Aug 2023 23:07:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Iq-0001NY-UO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:20 +0000 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [2607:f8b0:4864:20::b2c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 02166de8-3577-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:06:15 +0200 (CEST) Received: by mail-yb1-xb2c.google.com with SMTP id 3f1490d57ef6-d35e565071aso5316994276.2 for ; Mon, 07 Aug 2023 16:06:15 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02166de8-3577-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449574; x=1692054374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SuJFa6mAGFwbCAvFBsdWEeQAHJIQ94yaq1s2El5pO5M=; b=sRCgndxFhKIflL3dRUOciVixuY3um2CsOH9mqCT4RfpcBNQLoC/2xIlVP2BC0LrRXg d0Mfnrp8G1Gq70+B6oCgBqzc+N7zHH9xY0+av47l7B8CO6Tt+n9pMVSoswf5Jzx8/yzy NzCNQAVK/Lkid61qiT1qq4e/dSW3T9N7fVh6BXy/whyNG/50NiRv4160ULtNDt7ZAJ8u ZEinV12wAdQdY0FHQSDiTfa7/P6pGvAR+Q1UWR0j31w4+0ktiAC1WT1q41QbYEtl/+hQ cKdjsvUfk2w2q52f0mVtR4dPNDq1UHAYwd2r0wZzmsP36I/aPnhCen/ej73PJ82E0WBs UQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449574; x=1692054374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SuJFa6mAGFwbCAvFBsdWEeQAHJIQ94yaq1s2El5pO5M=; b=eP73u68iz/XkUBtQth2GLzzDIlRRYimRvnFL5lIORo+4MPV0MYnel5V1YXQY8lTqXP 5j6LieBA4LpWsH4U3Xc/QxE6/8NVRFqgmkLmr0THWnb/zlOJxPZEEIC2JINpZgLnna/m KUo1vXLG/CSKOCrglxJmTZyyIwGjtBLtJWhhlLp+97rqEK4/8WiR5a/iWloQ8KFHgiC8 L5CvwlWI7NBOyO6R4mGTSbABmTyhpba4UdGVSx+Xhrk7ho9OJGc4z/DNBtEz2fsUaIUM eogrMcR/Lp/0WFmmwIxph02qjtFf8sHwHEo5mbvsgvaxOcEHKqyyk6HLHCFjqtcZVZMG bbNQ== X-Gm-Message-State: AOJu0YyqAGmlSSY2n6O9O+OXfFXEsEgLeo0VtDlY2vcshUr/Mymor726 72/cqWEVpUZ07nCvBzsaQXM= X-Google-Smtp-Source: AGHT+IHDPhUgl52q/fREvy7LWtCvyksQLzlkWI4tWrtb//A8NgqAG/s+XL1YOkSBACmJ6FF0msS3mA== X-Received: by 2002:a25:4081:0:b0:d4c:82ff:7bde with SMTP id n123-20020a254081000000b00d4c82ff7bdemr6684894yba.63.1691449574044; Mon, 07 Aug 2023 16:06:14 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Yoshinori Sato , Geert Uytterhoeven , John Paul Adrian Glaubitz , Mike Rapoport Subject: [PATCH mm-unstable v9 27/31] sh: Convert pte_free_tlb() to use ptdescs Date: Mon, 7 Aug 2023 16:05:09 -0700 Message-Id: <20230807230513.102486-28-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Reviewed-by: Geert Uytterhoeven Acked-by: John Paul Adrian Glaubitz Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/sh/include/asm/pgalloc.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index a9e98233c4d4..5d8577ab1591 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -2,6 +2,7 @@ #ifndef __ASM_SH_PGALLOC_H #define __ASM_SH_PGALLOC_H +#include #include #define __HAVE_ARCH_PMD_ALLOC_ONE @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, set_pmd(pmd, __pmd((unsigned long)page_address(pte))); } -#define __pte_free_tlb(tlb,pte,addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif /* __ASM_SH_PGALLOC_H */ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579053.906962 (Exim 4.92) (envelope-from ) id 1qT9K5-0003tg-4d; Mon, 07 Aug 2023 23:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579053.906962; Mon, 07 Aug 2023 23:07:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9K3-0003n0-Nt; Mon, 07 Aug 2023 23:07:35 +0000 Received: by outflank-mailman (input) for mailman id 579053; Mon, 07 Aug 2023 23:07:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Im-0001NY-Tc for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:16 +0000 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [2607:f8b0:4864:20::c2a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff60c49c-3576-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 01:06:10 +0200 (CEST) Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-5633b7e5f90so3615823eaf.1 for ; Mon, 07 Aug 2023 16:06:10 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff60c49c-3576-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449570; x=1692054370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8XaHpTf3P/utbT17OPG/H5MolPsiYyRMVXSdV5AvoHU=; b=GmyaVrawFabDS7oM/FJ2wsqOTnvNiSZkWHllyllBSGtBhNSpEmhqjU2xmr+48gvMwO LUXnCk58UhmfTImv2R4R9LNF0+WlzxXIVQ4Y7ZC5fEeHoGrn0o/ogRSADB0Y+NluFrtN MrrlZ4Lz/gi5878wRIWP06wgFFKVx+8i+ghKFpBHekPx9T0p+3sqj2xh34rznNB4nw+U O7FH+uzt41O2vvO9FAauF/idvM9r4rw7Q35Wwsa8GbYTT2MLxcQcKcfZ8291m/c55wrV URc64VPnBpaXKs/Bni+oDqsCjGnYy/ppZbjbVbnispVrc0PlqosfX2g85SuErvT0W1h1 o3sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449570; x=1692054370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8XaHpTf3P/utbT17OPG/H5MolPsiYyRMVXSdV5AvoHU=; b=JNaCEAh0F9ogZx7p8idPPcrcMKlgg3ESkBb1wJhZ0+/o8C8oLKUQ6xrcVtC3wHyn6a 25J88keWREsRi4DBoYoqPQkUFDp34Q5TCALJu7yH/RBZntPEOM/q2qo4lSt4HEayK3VI gboVMf5cm2ZtepEduq1kQarb7UxsMqjJw0VtlKZ/NIYgq+oHrkwEiYSFvu2+PkH42ZYl gqrXSvZu9xtHVyKFzOJ8+mkbKJLSaEe18KWtHOYRusD/g2LV4ZiJMDBGFlDjX6lT+kzw cY/i/X6fw3mrj257LJLkyi0TfgeeOPUwsTehHzWW1ibTsiQ1sZ+npLtbIUMsnSywS+ic lDRA== X-Gm-Message-State: AOJu0YxBMoTeYNSrkhWKeof/+5jRjgpsuhqOjGJAnRWSfjyOR5xoGB7N sVlSjuD8RlTj07he/jIyTqg= X-Google-Smtp-Source: AGHT+IFfR71b5uGC/N7nUJvkV7EEf+q4ZrD/2jbgt4p5+XAZUesJuHroaMR2T6Qu+08oLKK4OIq5Tg== X-Received: by 2002:a05:6808:1997:b0:3a7:5314:e55e with SMTP id bj23-20020a056808199700b003a75314e55emr14747526oib.24.1691449569767; Mon, 07 Aug 2023 16:06:09 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Jonas Bonn , Mike Rapoport Subject: [PATCH mm-unstable v9 25/31] openrisc: Convert __pte_free_tlb() to use ptdescs Date: Mon, 7 Aug 2023 16:05:07 -0700 Message-Id: <20230807230513.102486-26-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/openrisc/include/asm/pgalloc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h index b7b2b8d16fad..c6a73772a546 100644 --- a/arch/openrisc/include/asm/pgalloc.h +++ b/arch/openrisc/include/asm/pgalloc.h @@ -66,10 +66,10 @@ extern inline pgd_t *pgd_alloc(struct mm_struct *mm) extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); -#define __pte_free_tlb(tlb, pte, addr) \ -do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ +do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579061.906988 (Exim 4.92) (envelope-from ) id 1qT9KB-0005gW-Ec; Mon, 07 Aug 2023 23:07:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579061.906988; Mon, 07 Aug 2023 23:07:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9KA-0005bZ-SD; Mon, 07 Aug 2023 23:07:42 +0000 Received: by outflank-mailman (input) for mailman id 579061; Mon, 07 Aug 2023 23:07:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ir-0001NS-Ae for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:21 +0000 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [2607:f8b0:4864:20::1134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04a379a9-3577-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:19 +0200 (CEST) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5839f38342fso54971387b3.0 for ; Mon, 07 Aug 2023 16:06:19 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04a379a9-3577-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449578; x=1692054378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yb5+fiX/YSPgeVruPImZCslC+7XzLtSDmAZ+KnCCvCw=; b=LURal4KqklmU9AiCOifU5Mxc6WM+IybZMw4f+H9b+ehsvWfF2rdEGUCUpHED/xgeP0 03+is7BherE6vDUPF9cInwhZZ6O6FVEP73Sri7+CBG0/7jN64G4bgtBq56ZrcLUBIxxT uSfx8fFqjmiqF0MtkULVgc1gjFJH4lOvkwRfZt9wzMVRnizjKRrxJwuFQ2mIfEo7cHgy UR2ZIO+mIWR9RWU4d+HJedZnPKiZaDv8i4STB2D6+pQaLcMt/pvWXKdhAwPxBTPHyGDc YUL8XwwyvOUHrQNxNKfZS8WVqZrgPXs80ZLFz3I7kRgWNiGS07HTyMzLuT9V1dLH0d1v g2Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449578; x=1692054378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yb5+fiX/YSPgeVruPImZCslC+7XzLtSDmAZ+KnCCvCw=; b=AslJ7ICD1SFZiw/MaPHqUMQCo/J5NbmNTE/BsLH1ULShe66do6VU2cvAH/YeyOZRI/ k8E+Hdw+kLRrK65BN+7BrTWKVZOEqBLB8VYxZQUJwq1Qw+QakyS30lJXk8DPp23nDM5/ BwmDZ1KhES+eJZHidjeaeZHYaD+p9wvWWFF27ZYEoGRjtyxmc/oXoiqeQc6a+baGvSr8 cj1CQokSax025yF0fyItJGLTZZ2/ZgczQt2Ef2vyWFkVh2OMl3v4P+7mlxboWagf1le6 g/YbKAXHJaMcb2JwvewC+Hqrg0l37JvTu/b1rNOzcQzlaiwXkqaJAwbhgvMISDBG7b2N YaVw== X-Gm-Message-State: AOJu0YzMDua5m/R9ge30S5Cp155XqewOadT8JEGQtjXoGbxCdeg2Wkj2 Kz+Fn8fJFT2Kst1W/ZGxuK8= X-Google-Smtp-Source: AGHT+IHSK0JHQfLZYNqZB3BuP0bNBVURutz2ITpQB4n2EhlNMl4NfRND8wevRJ4hRdMY0+rsbG2z6w== X-Received: by 2002:a25:ac04:0:b0:d0a:8269:e5d9 with SMTP id w4-20020a25ac04000000b00d0a8269e5d9mr9659872ybi.60.1691449578542; Mon, 07 Aug 2023 16:06:18 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , "David S. Miller" , Mike Rapoport Subject: [PATCH mm-unstable v9 29/31] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents Date: Mon, 7 Aug 2023 16:05:11 -0700 Message-Id: <20230807230513.102486-30-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable pte constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/srmmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index 13f027afc875..8393faa3e596 100644 --- a/arch/sparc/mm/srmmu.c +++ b/arch/sparc/mm/srmmu.c @@ -355,7 +355,8 @@ pgtable_t pte_alloc_one(struct mm_struct *mm) return NULL; page = pfn_to_page(__nocache_pa((unsigned long)ptep) >> PAGE_SHIFT); spin_lock(&mm->page_table_lock); - if (page_ref_inc_return(page) == 2 && !pgtable_pte_page_ctor(page)) { + if (page_ref_inc_return(page) == 2 && + !pagetable_pte_ctor(page_ptdesc(page))) { page_ref_dec(page); ptep = NULL; } @@ -371,7 +372,7 @@ void pte_free(struct mm_struct *mm, pgtable_t ptep) page = pfn_to_page(__nocache_pa((unsigned long)ptep) >> PAGE_SHIFT); spin_lock(&mm->page_table_lock); if (page_ref_dec_return(page) == 1) - pgtable_pte_page_dtor(page); + pagetable_pte_dtor(page_ptdesc(page)); spin_unlock(&mm->page_table_lock); srmmu_free_nocache(ptep, SRMMU_PTE_TABLE_SIZE); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579065.906997 (Exim 4.92) (envelope-from ) id 1qT9KC-0005yL-Lc; Mon, 07 Aug 2023 23:07:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579065.906997; Mon, 07 Aug 2023 23:07:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9KB-0005su-PF; Mon, 07 Aug 2023 23:07:43 +0000 Received: by outflank-mailman (input) for mailman id 579065; Mon, 07 Aug 2023 23:07:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IY-0001NS-LO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:02 +0000 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [2607:f8b0:4864:20::b29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7b3131f-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:58 +0200 (CEST) Received: by mail-yb1-xb29.google.com with SMTP id 3f1490d57ef6-d35a9d7a5bdso5116782276.0 for ; Mon, 07 Aug 2023 16:05:57 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7b3131f-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449557; x=1692054357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H/qh+9u1BcCIl2V5thva5G2rletbRXaxfcBgzJGGgXU=; b=pCbA+UxrLZ96Iu/LappjpSZmLEozYOYmdO5RTxaM7BlCH20e3MEhp3Bn4lGiK7HrnF zI5vTymTyexPs2fEWKMf3YOixGPBtUiqT1+gX7fLWBa+Q9gs2M2cYtqmojJG+cqpxy8a yiuXYP2euWfRpeTnK/Ph7t69G3h70UOk68zLodvepBaU3Ub4ZFK2KFzJhB7TlCbjRGdX ie8hnx40ZzCuPRz3xDX8QGC9rAdvd3I0ubBMPCct9yJ64tgNkqrnZ4vxqqMZLVPIiaaP rYqmFrrQlxG0A3en5YH5Vcd7HyjhL8swCun/14090vxoeSz0eujRX7UW9eNuwqOQts53 n0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449557; x=1692054357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H/qh+9u1BcCIl2V5thva5G2rletbRXaxfcBgzJGGgXU=; b=isQv0ST8QJIR/y1fc+4g3NwBYRutjFValFahP3cWKOvQdPCmPLZmhtIqJT3bSwmy9V Lyw27sSE4i/YNcRfNfyrdPZ+czb4KsukCEgRoc+Pg4gw+Ti/ocqYjvI2pfsHTWJUaB+S zjoLzCQ7wv9XJILTcpsm7Syp4fN6rMKaC8BkQ8VgzjEYiWy9zpUj4r8YywpAmZrx08Mr xtND04eFZxVgfXNpjRdrg7qRGiCSDj4nO+dXLRpdV+4qCOy+RgvnIhGY0qbckEGhvluG 4i4eMHsL2tznW4t6ZNqhqNVUgYwkEaSBDLJ7GbbmsgBna6QUTIQH5ESpL834es9d83KM /Sjw== X-Gm-Message-State: AOJu0YzhLYcSE9B+pJgLlUWUOlYiQ7Wy3kQrdgkBMctrliYRSNKOZaVZ 9V/B3kI8824yZJv/IX6c9lg= X-Google-Smtp-Source: AGHT+IGb7qTBQz9qcaNa56xxCbdxPZmnKDiha96eaUPQlL4XzY5YUB1UJSqCKxKHPrzOS/VVDboJfg== X-Received: by 2002:a05:6902:4c4:b0:d0f:65db:dc0e with SMTP id v4-20020a05690204c400b00d0f65dbdc0emr10052463ybs.39.1691449556886; Mon, 07 Aug 2023 16:05:56 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Guo Ren , Mike Rapoport Subject: [PATCH mm-unstable v9 19/31] csky: Convert __pte_free_tlb() to use ptdescs Date: Mon, 7 Aug 2023 16:05:01 -0700 Message-Id: <20230807230513.102486-20-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Guo Ren Acked-by: Mike Rapoport (IBM) Signed-off-by: Vishal Moola (Oracle) --- arch/csky/include/asm/pgalloc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h index 7d57e5da0914..9c84c9012e53 100644 --- a/arch/csky/include/asm/pgalloc.h +++ b/arch/csky/include/asm/pgalloc.h @@ -63,8 +63,8 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm) #define __pte_free_tlb(tlb, pte, address) \ do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page(tlb, pte); \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc(tlb, page_ptdesc(pte)); \ } while (0) extern void pagetable_init(void); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579070.907007 (Exim 4.92) (envelope-from ) id 1qT9KG-0006o1-8N; Mon, 07 Aug 2023 23:07:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579070.907007; Mon, 07 Aug 2023 23:07:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9KF-0006k3-5d; Mon, 07 Aug 2023 23:07:47 +0000 Received: by outflank-mailman (input) for mailman id 579070; Mon, 07 Aug 2023 23:07:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9Ih-0001NS-1U for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:06:11 +0000 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [2607:f8b0:4864:20::b2d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fdf436fe-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:06:08 +0200 (CEST) Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-d43930354bcso2766695276.3 for ; Mon, 07 Aug 2023 16:06:08 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:06:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdf436fe-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449567; x=1692054367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ke0Z6VjA86Q0iJYCAtHmQzMGt2iXqJZdkl8QiQF9dCo=; b=W+7e7ZXA6pq6bkOdiU4kqXMdaRoaFiJYq1YjNheTen2BEAKrJsHyDCwylC8TwIaELf OoOeKnKEm2Bup1E3lQkfzBFhNx4UEQeZdbP6gFS8EtHNx1s6wSSR8pJNy131BEuCYsID 5yHclRtlDqB0YUpxc8mp/j3duvqB/kcSwVKs7titgSAxTd3bahGpDvqB1s5BR/l1Q8b5 JJTz17F1sukT0v2fD4c6TeVfoKxL+4R8ZKOAgjggAvDHXskwAwGz/9+hK5mkw3BMis+2 8wcIPPvCrUvFi8Oxcy9SzYIpq7haNxXeYlICDRNRlufgVcr5TYo9K2btnO8SAcdlpPvp 77sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449567; x=1692054367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ke0Z6VjA86Q0iJYCAtHmQzMGt2iXqJZdkl8QiQF9dCo=; b=LsRmHtWnucY7nVj/YEaJyuLZ6Nf0n3OsVS+00kWxPpAb6HbhdCOUwuCANGACw7fJoG shkV2a9mgYgyW8QZqhC/Cdp+ZU9KbDfrddqUUnQRaxyEUuwQEl2sNigmC8j2znIUTPkz myM+z0s57V6AfYNazBN3XntgGVZ/iJo+jM8tMdRjDmNyYcvFUZN0PI1zL7fK6OM0BVv9 jW2He2901b56iYgsYzoJXZr6V8LHCbpKzk115sWdKhFSxPLWkkHM/dmvw/KIJhkl9YBe c1LyjgFtSKMKJynmkNuh8yF6zmqkD/jNMBwI0to07uCx3PdQeENleyzbS7ZQVsMug/B5 s4xw== X-Gm-Message-State: AOJu0YyKnip9/f/iicDQHEXPjAzjvahDrcPlt40LuY/QfAoKLHiKqd6V s0/ZnY/r8Fs6TfJsiaLeFLI= X-Google-Smtp-Source: AGHT+IEFwZzf7hWzCaDcJ0rf5o011LKpXcZZ+QgyAwbXtivToV2K1Z3qkIAZZunAX4r/XJQivv3Vpw== X-Received: by 2002:a25:29c2:0:b0:d4c:f456:d562 with SMTP id p185-20020a2529c2000000b00d4cf456d562mr4842541ybp.1.1691449567341; Mon, 07 Aug 2023 16:06:07 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport , Dinh Nguyen Subject: [PATCH mm-unstable v9 24/31] nios2: Convert __pte_free_tlb() to use ptdescs Date: Mon, 7 Aug 2023 16:05:06 -0700 Message-Id: <20230807230513.102486-25-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Acked-by: Mike Rapoport (IBM) Acked-by: Dinh Nguyen Signed-off-by: Vishal Moola (Oracle) --- arch/nios2/include/asm/pgalloc.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h index ecd1657bb2ce..ce6bb8e74271 100644 --- a/arch/nios2/include/asm/pgalloc.h +++ b/arch/nios2/include/asm/pgalloc.h @@ -28,10 +28,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, extern pgd_t *pgd_alloc(struct mm_struct *mm); -#define __pte_free_tlb(tlb, pte, addr) \ - do { \ - pgtable_pte_page_dtor(pte); \ - tlb_remove_page((tlb), (pte)); \ +#define __pte_free_tlb(tlb, pte, addr) \ + do { \ + pagetable_pte_dtor(page_ptdesc(pte)); \ + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ } while (0) #endif /* _ASM_NIOS2_PGALLOC_H */ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:07:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579074.907016 (Exim 4.92) (envelope-from ) id 1qT9KI-0007Qn-NJ; Mon, 07 Aug 2023 23:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579074.907016; Mon, 07 Aug 2023 23:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9KI-0007Pb-A9; Mon, 07 Aug 2023 23:07:50 +0000 Received: by outflank-mailman (input) for mailman id 579074; Mon, 07 Aug 2023 23:07:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9IU-0001NS-Kk for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:05:58 +0000 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [2607:f8b0:4864:20::b2d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f66c3f2f-3576-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:05:55 +0200 (CEST) Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-d593a63e249so512409276.3 for ; Mon, 07 Aug 2023 16:05:55 -0700 (PDT) Received: from unknowna0e70b2ca394.attlocal.net ([2600:1700:2f7d:1800::16]) by smtp.googlemail.com with ESMTPSA id d190-20020a25cdc7000000b00d3596aca5bcsm2545203ybf.34.2023.08.07.16.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:05:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f66c3f2f-3576-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691449554; x=1692054354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d6BZos7Ybf69Lr9ubs2a6Azcthgsxnr+LK2TqOKvMHI=; b=p8G6Pt9QZsVgDIw5B0YZsM1HO9y9fkrb/cw0HZOe9s94xOMFlEATGdftneo/KGkdaX TwSO+l67/znn0WvrOrRHHntMUuj9nNFXoTE85WKOjzGwb94eB3i84/XFPlTd02w2CLrJ DwESQ9jUYWS2DSwjhw7JNYWMJXOT94ZS609EVQWWoXQdRFNt0hhd7LN+kuo1QQmNKeS0 XHBIPjPF8dy/T4snUiw6ibSJ1ZirvD/sPtDvke5ir6zweBiFnq3ooQs72HZNE6w+OGww eTDTJaym+WVQphZfxFF+BeQU7jP4VlgJoz6RKQntFEtdMFIN0fhGKatr4Jikr9avLVk6 gEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691449554; x=1692054354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d6BZos7Ybf69Lr9ubs2a6Azcthgsxnr+LK2TqOKvMHI=; b=HYMxFa4XzXiGoku87OZZKfgD8cPbz85rg7H0WztUHJgSEh6zScWaDlVOC9NUoy5Oe4 2YIU85YwXhBrN7VwS+ezXL8JdJRR+NRz5lwdTniSBLD9fn9GlCNyjdw1abHDXMe1VOpZ LONJuMxYGSIg4Zhx3m6t+jwzNmASdGCYfc50UA2DHOpKB0u7N/baAL87UGhqAtn/wmk7 PtOj2PvaV2KtK3+RSjLDDMOHych/a/RNfxp4oa+9F9HgbwHKV1v3Do80oudE2Ty/WWFP VB7W0BySxAqBQA3hNg0BAeTOjHEt3rcnzNPyMZAe6UcyL4poV4dQ4OfXkvM2PsRpFceM AAhg== X-Gm-Message-State: AOJu0YxRhjGkRc5ZnVp5j5waxYWmNwGKJAWDK8xMGF5xjMTGINGxgDDm 9fsJrdX6f3V0qQ+1EV00AaY= X-Google-Smtp-Source: AGHT+IHnEVFzuxaIlZevFxX1u5N6TSfYAnl0Ngd19zcPS1yyZn6+F2gzJTtnG1yf2qQFJp4HGPdIaw== X-Received: by 2002:a25:aea5:0:b0:d0b:fe82:8b99 with SMTP id b37-20020a25aea5000000b00d0bfe828b99mr10007354ybj.44.1691449554679; Mon, 07 Aug 2023 16:05:54 -0700 (PDT) From: "Vishal Moola (Oracle)" To: Andrew Morton , Matthew Wilcox Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , "Vishal Moola (Oracle)" , Mike Rapoport , Catalin Marinas Subject: [PATCH mm-unstable v9 18/31] arm64: Convert various functions to use ptdescs Date: Mon, 7 Aug 2023 16:05:00 -0700 Message-Id: <20230807230513.102486-19-vishal.moola@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230807230513.102486-1-vishal.moola@gmail.com> References: <20230807230513.102486-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Acked-by: Mike Rapoport (IBM) Acked-by: Catalin Marinas Signed-off-by: Vishal Moola (Oracle) --- arch/arm64/include/asm/tlb.h | 14 ++++++++------ arch/arm64/mm/mmu.c | 7 ++++--- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h index c995d1f4594f..2c29239d05c3 100644 --- a/arch/arm64/include/asm/tlb.h +++ b/arch/arm64/include/asm/tlb.h @@ -75,18 +75,20 @@ static inline void tlb_flush(struct mmu_gather *tlb) static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) { - pgtable_pte_page_dtor(pte); - tlb_remove_table(tlb, pte); + struct ptdesc *ptdesc = page_ptdesc(pte); + + pagetable_pte_dtor(ptdesc); + tlb_remove_ptdesc(tlb, ptdesc); } #if CONFIG_PGTABLE_LEVELS > 2 static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, unsigned long addr) { - struct page *page = virt_to_page(pmdp); + struct ptdesc *ptdesc = virt_to_ptdesc(pmdp); - pgtable_pmd_page_dtor(page); - tlb_remove_table(tlb, page); + pagetable_pmd_dtor(ptdesc); + tlb_remove_ptdesc(tlb, ptdesc); } #endif @@ -94,7 +96,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pudp, unsigned long addr) { - tlb_remove_table(tlb, virt_to_page(pudp)); + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pudp)); } #endif diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 95d360805f8a..47781bec6171 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -426,6 +426,7 @@ static phys_addr_t __pgd_pgtable_alloc(int shift) static phys_addr_t pgd_pgtable_alloc(int shift) { phys_addr_t pa = __pgd_pgtable_alloc(shift); + struct ptdesc *ptdesc = page_ptdesc(phys_to_page(pa)); /* * Call proper page table ctor in case later we need to @@ -433,12 +434,12 @@ static phys_addr_t pgd_pgtable_alloc(int shift) * this pre-allocated page table. * * We don't select ARCH_ENABLE_SPLIT_PMD_PTLOCK if pmd is - * folded, and if so pgtable_pmd_page_ctor() becomes nop. + * folded, and if so pagetable_pte_ctor() becomes nop. */ if (shift == PAGE_SHIFT) - BUG_ON(!pgtable_pte_page_ctor(phys_to_page(pa))); + BUG_ON(!pagetable_pte_ctor(ptdesc)); else if (shift == PMD_SHIFT) - BUG_ON(!pgtable_pmd_page_ctor(phys_to_page(pa))); + BUG_ON(!pagetable_pmd_ctor(ptdesc)); return pa; } -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:29:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579175.907033 (Exim 4.92) (envelope-from ) id 1qT9eh-0004lQ-Aa; Mon, 07 Aug 2023 23:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579175.907033; Mon, 07 Aug 2023 23:28:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9eh-0004lJ-6P; Mon, 07 Aug 2023 23:28:55 +0000 Received: by outflank-mailman (input) for mailman id 579175; Mon, 07 Aug 2023 23:28:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qT9eg-0004lD-IO for xen-devel@lists.xenproject.org; Mon, 07 Aug 2023 23:28:54 +0000 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [2607:f8b0:4864:20::42b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29722fc7-357a-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 01:28:50 +0200 (CEST) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6874d1c8610so3598397b3a.0 for ; Mon, 07 Aug 2023 16:28:50 -0700 (PDT) Received: from dread.disaster.area (pa49-180-166-213.pa.nsw.optusnet.com.au. [49.180.166.213]) by smtp.gmail.com with ESMTPSA id e18-20020aa78c52000000b0068620bee456sm6663729pfd.209.2023.08.07.16.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 16:28:47 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qT9eW-002TeM-1d; Tue, 08 Aug 2023 09:28:44 +1000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29722fc7-357a-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1691450928; x=1692055728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0xqamAux0UTVG6klbJHwJNM84FqVsjBhqmY+h06Y7S4=; b=adlg0mZ+HbNffKaKec2p7cVEI4EUlpFfVSVpmG5fvHzHnQEOdBYZjEy4QnkJtTu7lu YmN6EGaH1vJkJ2ZOmqiBcV/yaN6Y4JVna47CjKD7nPXpOiMzYNw9UySGma80pWoaj7Dk jUxXtUXqouB4bUXn3WeUBdMeMQNzv8NtKVfvER+m7KEKe99ZrQWUTG4Y9TUCDw4Kbcew TFF8/aAopaaIk2YO3rVVNpTSZmvFLss5lfJ8bn13k+LTkCPg51SMuEfV97r2Zvr+7s3C AcdJXj3qJcnQFWBnyvELMIWQLaBKzEk7yCwrvdFLv4Z0y5aFUIdjan9j2uUGZT7xZ3GX Ib8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691450928; x=1692055728; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0xqamAux0UTVG6klbJHwJNM84FqVsjBhqmY+h06Y7S4=; b=hIbGiV/uBU2CpqN3+ZpRx/fkIxo8ZvMsN5jTLsUhRCwF06P5iypftFJZG8dzZETvbZ TAKrsslkxePnm7wE7D+pZzd3weIxr/Pz63RV9pbxim3s2bkdiFAytnB8f5l2Dj0ZdD8m icSFqB7d0/DdXLYc11Jfrsh7mon3YcQvVm+O8bG7vtwb+DYWke7Ck2Q25IHMefMnxN5+ FyCJK4aAKQJjVplHoZic83tSB0q5WZ0rgyE0oEHesgaysmHtZ02J6pfatCNewF60+WB/ gqc8Sa3tTwLaXiJBR54TPecExGQObR9CgE2qx/ixAjroq1mSPGF9ZBkJO6rzWxwO9q3H c4Ig== X-Gm-Message-State: AOJu0Yx85Phc7YRLWaKWfdt2skc/xSOrd+zydIfdrol83pRaPBSaDpW8 iuJuBYTx/hhB4RFrPzWV+HYGvw== X-Google-Smtp-Source: AGHT+IHWcHOenJQfOaWa9c7YDyMdy3l3j1H0rEzsEcwqog5HJ9HhPve3KCBNDXb4QQT+YEAg/cljWw== X-Received: by 2002:a05:6a20:8e04:b0:13c:8e50:34b8 with SMTP id y4-20020a056a208e0400b0013c8e5034b8mr12892217pzj.35.1691450928413; Mon, 07 Aug 2023 16:28:48 -0700 (PDT) Date: Tue, 8 Aug 2023 09:28:44 +1000 From: Dave Chinner To: Qi Zheng Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless Message-ID: References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-46-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807110936.21819-46-zhengqi.arch@bytedance.com> On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: > The shrinker_rwsem is a global read-write lock in shrinkers subsystem, > which protects most operations such as slab shrink, registration and > unregistration of shrinkers, etc. This can easily cause problems in the > following cases. .... > This commit uses the refcount+RCU method [5] proposed by Dave Chinner > to re-implement the lockless global slab shrink. The memcg slab shrink is > handled in the subsequent patch. .... > --- > include/linux/shrinker.h | 17 ++++++++++ > mm/shrinker.c | 70 +++++++++++++++++++++++++++++----------- > 2 files changed, 68 insertions(+), 19 deletions(-) There's no documentation in the code explaining how the lockless shrinker algorithm works. It's left to the reader to work out how this all goes together.... > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index eb342994675a..f06225f18531 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include > +#include > > #define SHRINKER_UNIT_BITS BITS_PER_LONG > > @@ -87,6 +89,10 @@ struct shrinker { > int seeks; /* seeks to recreate an obj */ > unsigned flags; > > + refcount_t refcount; > + struct completion done; > + struct rcu_head rcu; What does the refcount protect, why do we need the completion, etc? > + > void *private_data; > > /* These are for internal use */ > @@ -120,6 +126,17 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); > void shrinker_register(struct shrinker *shrinker); > void shrinker_free(struct shrinker *shrinker); > > +static inline bool shrinker_try_get(struct shrinker *shrinker) > +{ > + return refcount_inc_not_zero(&shrinker->refcount); > +} > + > +static inline void shrinker_put(struct shrinker *shrinker) > +{ > + if (refcount_dec_and_test(&shrinker->refcount)) > + complete(&shrinker->done); > +} > + > #ifdef CONFIG_SHRINKER_DEBUG > extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker, > const char *fmt, ...); > diff --git a/mm/shrinker.c b/mm/shrinker.c > index 1911c06b8af5..d318f5621862 100644 > --- a/mm/shrinker.c > +++ b/mm/shrinker.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > > #include "internal.h" > @@ -577,33 +578,42 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, > if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) > return shrink_slab_memcg(gfp_mask, nid, memcg, priority); > > - if (!down_read_trylock(&shrinker_rwsem)) > - goto out; > - > - list_for_each_entry(shrinker, &shrinker_list, list) { > + rcu_read_lock(); > + list_for_each_entry_rcu(shrinker, &shrinker_list, list) { > struct shrink_control sc = { > .gfp_mask = gfp_mask, > .nid = nid, > .memcg = memcg, > }; > > + if (!shrinker_try_get(shrinker)) > + continue; > + > + /* > + * We can safely unlock the RCU lock here since we already > + * hold the refcount of the shrinker. > + */ > + rcu_read_unlock(); > + > ret = do_shrink_slab(&sc, shrinker, priority); > if (ret == SHRINK_EMPTY) > ret = 0; > freed += ret; > + > /* > - * Bail out if someone want to register a new shrinker to > - * prevent the registration from being stalled for long periods > - * by parallel ongoing shrinking. > + * This shrinker may be deleted from shrinker_list and freed > + * after the shrinker_put() below, but this shrinker is still > + * used for the next traversal. So it is necessary to hold the > + * RCU lock first to prevent this shrinker from being freed, > + * which also ensures that the next shrinker that is traversed > + * will not be freed (even if it is deleted from shrinker_list > + * at the same time). > */ This comment really should be at the head of the function, describing the algorithm used within the function itself. i.e. how reference counts are used w.r.t. the rcu_read_lock() usage to guarantee existence of the shrinker and the validity of the list walk. I'm not going to remember all these little details when I look at this code in another 6 months time, and having to work it out from first principles every time I look at the code will waste of a lot of time... -Dave. -- Dave Chinner david@fromorbit.com From xen-devel-bounces@lists.xenproject.org Mon Aug 07 23:59:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 07 Aug 2023 23:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579180.907042 (Exim 4.92) (envelope-from ) id 1qTA8U-0008Nj-Kw; Mon, 07 Aug 2023 23:59:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579180.907042; Mon, 07 Aug 2023 23:59:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTA8U-0008Nc-Hs; Mon, 07 Aug 2023 23:59:42 +0000 Received: by outflank-mailman (input) for mailman id 579180; Mon, 07 Aug 2023 23:59:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTA8T-0008NS-DS; Mon, 07 Aug 2023 23:59:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTA8T-00070H-2N; Mon, 07 Aug 2023 23:59:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTA8S-0005Vw-J3; Mon, 07 Aug 2023 23:59:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTA8S-0007C6-IZ; Mon, 07 Aug 2023 23:59:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WeK3IIWxPXHcqovaDPBs433L0fBoefnfDLJKsF7pLR0=; b=313zJ0ZsFKS9At8nr4q5yHcqk0 AyssHt1mmS1p8noj+j97wG+dfUVcK8pdEpm7ddzSU5+9B6UqAbKkJzMZO9mGn+naacOizERTScsqG 2GgTpqEvZBJAmAZDn6bebuxaiWWGedv1HfVmU/WcRvmdS/ktIB+r42A4LV+0cydZ0jrk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182219: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:host-ping-check-xen:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=52a93d39b17dc7eb98b6aa3edb93943248e03b2f X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Mon, 07 Aug 2023 23:59:40 +0000 flight 182219 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182219/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail in 182209 pass in 182219 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail in 182209 pass in 182219 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail in 182209 pass in 182219 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 182209 pass in 182219 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail pass in 182209 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 182209 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 182209 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 182209 test-amd64-amd64-xl-qemut-ws16-amd64 18 guest-localmigrate/x10 fail pass in 182209 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-xl-rtds 10 host-ping-check-xen fail in 182209 blocked in 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 182209 like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail in 182209 like 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 52a93d39b17dc7eb98b6aa3edb93943248e03b2f baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 113 days Failing since 180281 2023-04-17 06:24:36 Z 112 days 204 attempts Testing same since 182209 2023-08-07 01:42:54 Z 0 days 2 attempts ------------------------------------------------------------ 3912 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 658349 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 01:14:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 01:14:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579189.907053 (Exim 4.92) (envelope-from ) id 1qTBID-0002UC-S0; Tue, 08 Aug 2023 01:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579189.907053; Tue, 08 Aug 2023 01:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTBID-0002Tr-Mz; Tue, 08 Aug 2023 01:13:49 +0000 Received: by outflank-mailman (input) for mailman id 579189; Tue, 08 Aug 2023 01:13:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTBIB-0002TV-TB for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 01:13:47 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2044.outbound.protection.outlook.com [40.107.7.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d27e87f5-3588-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 03:13:46 +0200 (CEST) Received: from AM6P193CA0061.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::38) by AM7PR08MB5431.eurprd08.prod.outlook.com (2603:10a6:20b:10c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 01:13:05 +0000 Received: from AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::53) by AM6P193CA0061.outlook.office365.com (2603:10a6:209:8e::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26 via Frontend Transport; Tue, 8 Aug 2023 01:13:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT063.mail.protection.outlook.com (100.127.140.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.16 via Frontend Transport; Tue, 8 Aug 2023 01:13:04 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Tue, 08 Aug 2023 01:13:04 +0000 Received: from e6699f1ce5be.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 92EED3FB-B4D4-4F28-9AB1-482077DDB106.1; Tue, 08 Aug 2023 01:12:18 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e6699f1ce5be.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Aug 2023 01:12:18 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB5763.eurprd08.prod.outlook.com (2603:10a6:20b:1d7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 01:12:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 01:12:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d27e87f5-3588-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9hZh/FasuzIaiEaNf3QrEe3BVC9c1xc5yAp1v/YpTVo=; b=uVwIQaWmAdkPlSS2/gsH7tCHWy3cXqj2/P6D5E8wHBMSjiJs0Cdll2PKvC+VGeObAu7ihYEXsQG1bVgWFwAWB/KRHRb3hmr9Z6qcc6u3k3OF0J9F3dvMJyx3QHlU0UvrvB9TTPzxM0+4kwFzZCgdI7NmR9Gef26dzZ1CtOps9BI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 881e4134ef41e0c8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cmCLElw2eREJNch7Rj3ZyDY7HI+bF4iWxtiD8b06AM6WT5ZJucgU2flbT4Kpkwdt8ANqiYAiX7HUB/K7Nzzm9Hcfjooka3+lFzwmx/dk4S5qCWzvDBeiak7o+ovpm3tqPSWdoxHUgtFPttb/bblflJ6zobi8oFK00P27d+WlDsHOFURdXEo4gMisdIQaQYfjs+XmrlRRW1YiQKWvaDULq0Mpqay/h0j7sp2ChNnCZujyLsjPRjJSwp5sFDqj6E9P+MWBFBigjCvsVXfR+xBsKwwNHCJVSqOLBRaOgLajhOMGx3CSJBw9b6zDyhh/+j4nVLcDqshGwiBtSkBqlCw+QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9hZh/FasuzIaiEaNf3QrEe3BVC9c1xc5yAp1v/YpTVo=; b=GJP2RJYXapoV3elk+MwsA14iO0awakFQouny8YJa30Cd545q7HxApnInJF/Ag+xVkJ+1LniVYVo5FxhfHwZdIDcHgRSONIppKoZpvEtJoPfK83oUKrCeJ5yu99ZsCN3uWHYXTA8sppCQyqNJHriKJ1ClJVUEWWogZAkjO7SeqddOh9z0/GPSryeMzXQrMmGwyOyjhew8WIYY8EdL3b29mNN5Q4sBP9GdPgnZ82vEnS2PlGLjfLammOKnJhTCYVfa0fRfVUB8DU3x68BsR6CZobKSxazmBGsh7oEONajxQJ3HQuPv/rHxs32i+I+GGDQAeJF2ycz2h1eVQHzbsLk6kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9hZh/FasuzIaiEaNf3QrEe3BVC9c1xc5yAp1v/YpTVo=; b=uVwIQaWmAdkPlSS2/gsH7tCHWy3cXqj2/P6D5E8wHBMSjiJs0Cdll2PKvC+VGeObAu7ihYEXsQG1bVgWFwAWB/KRHRb3hmr9Z6qcc6u3k3OF0J9F3dvMJyx3QHlU0UvrvB9TTPzxM0+4kwFzZCgdI7NmR9Gef26dzZ1CtOps9BI= From: Henry Wang To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Andrew Cooper , Jan Beulich , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Julien Grall , Bertrand Marquis Subject: Re: Xen 4.18 release: Reminder about last posting date Thread-Topic: Xen 4.18 release: Reminder about last posting date Thread-Index: AdnGpQJJnpHQXjHHQ2KSH/TFd+8FbgCv9A+AAAwhZoA= Date: Tue, 8 Aug 2023 01:12:16 +0000 Message-ID: <5466B9C5-8D63-48F0-B899-DADCFC75F0B2@arm.com> References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM8PR08MB5763:EE_|AM7EUR03FT063:EE_|AM7PR08MB5431:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c9d3faf-5ac1-4692-8cf2-08db97ac9e3f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1WlPMYUW6VUujME74VJkOgfIk8LNZi8AP48DL8jkBWB5MGCGIWd2vL11vEwzFHQOS/Dvf9N2a8bdC+8kC3nEmxAtB0T/wl/riN3l6c2qYpyEzlc5Jb2Xo2rRbL0d30cy/tcWxHLiY58hZUNX66qV0P7YeD1a3sOohWBin4cnTqEPVq6ZrBiY/5/63yKC/SEge4NzQ44iHiOD7SjP+WNGfxX8AqfwmgQ9Tf2BmIuATfc8pealwmfOtlkrZPzqqHfPWiPjjkGSglyQGNgR8M7bwRwOGS2h0I3JiY4pEyZEoqN9s33LCHzvK6vg9MudUb9K8f9yiHIIdnjXqEPmn87t1DqeSgfzrR/lisYFgBGFIMJixm0BCS19CpUmnznY498tU09olo5wUHU4i0Xa0VVAWwJYrtkAmPcwiRNSdhHMNgtVFOXrAoiD0QMzeNO+ShjltociwSPeQAWpwUGrTDTNh/QkxIgpdIcQJam3bH/0KSOnDCx1Q4Lp5MW73t+6Yht6CQnJPYchtJT7ueZwpopRSALUtiSa8hhBRaRFQh9WhdNniWDcSzJOSzPIxMskXlyTAOXu0grn98gkaT8qbQ/iKwWCTIzV872sCsMbMXHmv/riklfsULa2dIhQvtkr3MfeT9/9aOQOfOf31GwtSWqguJ4R+CpV1wYHycs8kckWY9PCfqKjLzuEqL/mCD18Q/KXsS03vBJwHbYFpGj9sUUrKW7NN2y960SKgQ+sLSGf6j0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(186006)(90011799007)(1800799003)(90021799007)(451199021)(2616005)(6486002)(45080400002)(122000001)(478600001)(83380400001)(966005)(6512007)(53546011)(26005)(6506007)(66556008)(33656002)(64756008)(66446008)(66476007)(66946007)(91956017)(76116006)(8676002)(41300700001)(316002)(8936002)(2906002)(4326008)(6916009)(71200400001)(36756003)(54906003)(38100700002)(86362001)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <34B40C817654F549BFA8D800209F8C9F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5763 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d3f3d493-41c9-4982-a8bf-08db97ac819f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vn8LD+AV03BEIT/F7xSgqicGmYFj2CbTz1vcFGMPCe1+qylsy1jCr5ZP2/ynLUdLnmPycMN7YoLMu14RoFRLFmubn7RJPta3q8fS1p+nQjAX+Sdwvh1Xx1+drxaZ38v+LZ6uO24nGq9FRw9eHfe/i/73ZLtjRmMhELuSr5jJgw+qQd9yJv9QqUurSHoPwJ2H5/xRJu95ytsN/1+M1k4LAD9aRvFkfZ8wLZx4xniZ+Z6P72RkS13SPbGabtA7kwaRfCRszxary58dOOnqCjgU2vSdrukgJ+IZ5PxU1TNXRc11WkvyhthRJAim4olHcjUQ58Og2JFQVXK+DoRRfauq/zgMza+d50ujtqhM/89IB1IzRU/O7I5Cyb9iEVoHxrI6KHV4NSmK/FvjKBjDBERzcFGv90giW5+TTxMgXhG0BmT2nCNyQj6c2CsY6QfplvtOW4RTfTr7RojZuxaMPcZFX4eCrQdimGjuaO+3Efo6nRwc9HPNHTEZJ91FKdlWNpn50b/JaxEN2uQjJp65Dc3q3Yg4sqKsBPkAVGPZP8xIsj2WEMXs14kiHkIbf5tpl0t0Ayjqj0ct0d1GbB8Xy3c1KLpxb/lLRnU8mpTH6HMgrgYk8U+6oawA24PHi5/ZFlK7qld6gmYLQo0zGmN+0w+cfS4XmQ6I4+YJuXasuS6aKkLhqvmCdjREZUCG0fUUD9mDVoGuR1ESLQKnHEd2Pz6lOxxlkxN2rCesyHWVs6ZtlXwL3qPqvgxriiybYNmrWMNYct/md/DVH1lSVNFI5OJmLJLen8mVEWbboKhJeVsXzCuBlmwCN5qylJvw4wUNxim0TMR+NJBFBp0fdlhjXcT1Vg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(90011799007)(451199021)(82310400008)(90021799007)(186006)(1800799003)(40470700004)(36840700001)(46966006)(6862004)(8676002)(8936002)(5660300002)(4326008)(41300700001)(316002)(47076005)(86362001)(83380400001)(40480700001)(40460700003)(2906002)(36860700001)(6512007)(966005)(6486002)(2616005)(6506007)(53546011)(26005)(36756003)(336012)(70586007)(70206006)(356005)(45080400002)(478600001)(81166007)(82740400003)(54906003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 01:13:04.7722 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c9d3faf-5ac1-4692-8cf2-08db97ac9e3f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5431 SGkgU3RlZmFubywNCg0KPiBPbiBBdWcgOCwgMjAyMywgYXQgMDM6MjQsIFN0ZWZhbm8gU3RhYmVs bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBNb24sIDcgQXVn IDIwMjMsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+PiBIaSBldmVyeW9uZSwNCj4+IA0KPj4gRm9sbG93 aW5nIHRoZSByZWxlYXNlIHNjaGVkdWxlIGRpc2N1c3Npb24gaW4gaW4gQXByaWwsIEkgYW0gc2Vu ZGluZyB0aGlzIGVtYWlsDQo+PiB0byByZW1pbmQgdGhhdCBhY2NvcmRpbmcgdG8gdGhlIHJlbGVh c2Ugc2NoZWR1bGUgWzFdLCBBdWd1c3QgMTEgKHRoaXMgRnJpZGF5KQ0KPj4gd2lsbCBiZSB0aGUg bGFzdCBwb3N0aW5nIGRhdGUsIHdoZW4gcGF0Y2hlcyBhZGRpbmcgbmV3IGZlYXR1cmVzIGFyZSBl eHBlY3RlZA0KPj4gdG8gYmUgcG9zdGVkIHRvIHRoZSBtYWlsaW5nIGxpc3QgYnkgdGhpcyBkYXRl Lg0KPj4gDQo+PiBBbHNvLCBub3RlIHRoYXQgd2UgY3VycmVudGx5IGhhdmUgMSByZWxlYXNlIGJs b2NrZXIgWzJdIHdoaWNoIG1pZ2h0IG5lZWQNCj4+IHNvbWUgYXR0ZW50aW9uLg0KPj4gDQo+PiBb MV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsL0FTOFBSMDhNQjc5OTE5RjlDRTBC MkJGODBFNzEwM0ZCNTkyNjA5QEFTOFBSMDhNQjc5OTEuZXVycHJkMDgucHJvZC5vdXRsb29rLmNv bS8NCj4+IFsyXSBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QveGVuLy0vaXNzdWVzLzEx NA0KPiANCj4gV2UgaGF2ZSBhbm90aGVyIHJlbGVhc2UgYmxvY2tlciBpbiBteSBvcHRpb246DQo+ IGh0dHBzOi8vbWFyYy5pbmZvLz9sPXhlbi1kZXZlbCZtPTE2ODMxMjQ2ODgwODk3Nw0KPiBodHRw czovL21hcmMuaW5mby8/bD14ZW4tZGV2ZWwmbT0xNjgzMTI2ODc2MTAyODMNCg0KSeKAmXZlIHRh a2VuIGEgbm90ZSBmb3IgdGhpcywgdGhhbmtzIGZvciB0aGUgcmVtaW5kZXIuDQoNCktpbmQgcmVn YXJkcywNCkhlbnJ5DQoNCj4gDQo+IEFuZHJldywgd291bGQgeW91IE9LIHdpdGggbWFraW5nIGl0 IGEgcmVsZWFzZSBibG9ja2VyPyBXZSBhbHJlYWR5IGhhdmUgYQ0KPiB0ZW50YXRpdmUgZml4IGZy b20gSnVsaWVuLg0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Tue Aug 08 01:36:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 01:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579195.907063 (Exim 4.92) (envelope-from ) id 1qTBdm-0004ym-J2; Tue, 08 Aug 2023 01:36:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579195.907063; Tue, 08 Aug 2023 01:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTBdm-0004ye-Ee; Tue, 08 Aug 2023 01:36:06 +0000 Received: by outflank-mailman (input) for mailman id 579195; Tue, 08 Aug 2023 01:36:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTBdk-0004yU-T7; Tue, 08 Aug 2023 01:36:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTBdk-0003Ww-O1; Tue, 08 Aug 2023 01:36:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTBdk-0001nw-9c; Tue, 08 Aug 2023 01:36:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTBdk-0003HS-98; Tue, 08 Aug 2023 01:36:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4Nd4FByL2D5IlDGnd1+R0DW+6VmuB9uC5CzYQInlXhs=; b=dY+pDueD0A2ze3j29KC5DWCZl/ iSmwPWW1V8pjgtPmayBo2BCI0Hti5j5wDmge3+K8f/sJjzH2PgC9djTgetok8Vy1pfSKQWRnHqUwt MbjvQehonOf9d5ZuyNxmXlL+1ksbScXgJf5lKLkhyZCRmj9k1XzlfS0M56XXMFzZGk5U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182224: all pass - PUSHED X-Osstest-Versions-This: ovmf=3c274c0d83d5464b336e40058bc5969bfef25f7b X-Osstest-Versions-That: ovmf=2d8c17a9b61ad298986daffe5373026c3b88c741 From: osstest service owner Date: Tue, 08 Aug 2023 01:36:04 +0000 flight 182224 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182224/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3c274c0d83d5464b336e40058bc5969bfef25f7b baseline version: ovmf 2d8c17a9b61ad298986daffe5373026c3b88c741 Last test of basis 182184 2023-08-04 14:44:00 Z 3 days Testing same since 182224 2023-08-07 23:10:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Nate DeSimone jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2d8c17a9b6..3c274c0d83 3c274c0d83d5464b336e40058bc5969bfef25f7b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:02:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579203.907073 (Exim 4.92) (envelope-from ) id 1qTC2w-0000Hy-GC; Tue, 08 Aug 2023 02:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579203.907073; Tue, 08 Aug 2023 02:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTC2w-0000Hq-DT; Tue, 08 Aug 2023 02:02:06 +0000 Received: by outflank-mailman (input) for mailman id 579203; Tue, 08 Aug 2023 02:02:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTC2w-0000Hh-0X for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 02:02:06 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on062e.outbound.protection.outlook.com [2a01:111:f400:fe0c::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 905ce88b-358f-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 04:02:02 +0200 (CEST) Received: from DUZPR01CA0268.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::16) by DU0PR08MB8640.eurprd08.prod.outlook.com (2603:10a6:10:400::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 02:01:58 +0000 Received: from DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::d9) by DUZPR01CA0268.outlook.office365.com (2603:10a6:10:4b9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 02:01:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT044.mail.protection.outlook.com (100.127.142.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.16 via Frontend Transport; Tue, 8 Aug 2023 02:01:58 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Tue, 08 Aug 2023 02:01:58 +0000 Received: from f2d9e0b0293b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BEC2FAF1-3579-4520-BE87-45EEB7A2D982.1; Tue, 08 Aug 2023 02:01:21 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2d9e0b0293b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Aug 2023 02:01:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB9586.eurprd08.prod.outlook.com (2603:10a6:10:454::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 02:01:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 02:01:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 905ce88b-358f-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVh67N903PEeqgYmoTVepU8+1oMgWaDdvrubCIM5/DY=; b=wokl2kC/d9yBW1h76+5n/OrbreOXgyeT/tCQnThJjLBkEZJ9CyUegswE9+OfAgQkeGQS0dnFHF5EGR466WiNpyy1iSuqMmRgI6ZPbDlgnCuXbfrZZqjKwbZ4NNgkFRXNjexJfNuRRSW1e8bctMHDLbKjeZ2/9cfrpS/wJmaREoA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8f57b506ecfbf673 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjcT06M2F8jsPISg5M6zYHlM4+/2HZuXozqk8mo9fYXRA+/pEV/5RHEczwZaR1qU0n8oS0yGlubxF3Sne4f8TU8xlhMjRy/inl/+YWecutCzt69xWvEg9LQVuxlO5Aj0uaSIGMI/LBmlI3JNpiuhSOIvca/EKK+GZ1pnvy0dJ5+o9DWA59TUHCZrVrITOEgTUQmBVCnlFhoLuEi0jW0NUXbYM4sfMsxsw+F09Zh1QGm8z+mYwzXwW+OWrFCGu+1YJRLwMTKDSeDhEawuJzQDvSduPMRmBWQ2rbUOcruqZTJLfCvrIMxfEj1HmSZ1trkegotMw9rhJ4SNoLH3uYPeIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kVh67N903PEeqgYmoTVepU8+1oMgWaDdvrubCIM5/DY=; b=mejGeM5BzK6YAw9/MgYyfGx76tNLHWUnL/g6kJpmZKrU63sLvI8IOa7WD2fJ6nV8R/HqzJgK83dOHw6khzdd79uP0ZuQtg/joP5BRbi6yjZMlfsBNFWOvVo1vOzaHaOlxE8qET7vZNVYsSeu6XapbhWLrMgAQnjdPvCC9kEwaDGAkHB0x4OvNx3n7ZIyadBIHbqj6y1SHosnnKe1brWkpKC9z3mAoTvlG5VJqlURUdNG9ZvoLyaixDlmezOrr2O2nkDZPNkvbU9rCXGI7LFYWoBciZ1+RzAJI1ZTZRF8GOxWCquSCpiZAI9Xp3PnRXk5SzPhgHDXbeHboo5nhyGknQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVh67N903PEeqgYmoTVepU8+1oMgWaDdvrubCIM5/DY=; b=wokl2kC/d9yBW1h76+5n/OrbreOXgyeT/tCQnThJjLBkEZJ9CyUegswE9+OfAgQkeGQS0dnFHF5EGR466WiNpyy1iSuqMmRgI6ZPbDlgnCuXbfrZZqjKwbZ4NNgkFRXNjexJfNuRRSW1e8bctMHDLbKjeZ2/9cfrpS/wJmaREoA= From: Henry Wang To: Ayan Kumar Halder CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Julien Grall Subject: Re: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture Thread-Topic: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture Thread-Index: AQHZxCqJmtSfvrOVyE67LM5R2F23xa/e2swAgADVQQA= Date: Tue, 8 Aug 2023 02:01:17 +0000 Message-ID: References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-3-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB9586:EE_|DBAEUR03FT044:EE_|DU0PR08MB8640:EE_ X-MS-Office365-Filtering-Correlation-Id: eeec1f96-bf42-4409-124d-08db97b372cc x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GYNlqg8RFi7vlgRs3SzZBG/vOou9sbEEGLgXcPaKkgoeZGklU5zrV7hx/sAUdp50ZYJojcOfqI5YACzeTPXtjgX6VX2TiFq7ZEcg/cjFk+MBBKl6vzsPks2UOEVfoRd9lhTR5VYYDzC6TWNRIOWA2c4OFnWS4hY+72sVucKEfUegiYFFSUxFTOZDLz64Y1uMa3ZMBRru6KpHAuQr+bFdyfyxE3BEevRZpHeI/dXKNsSX9/1QltuNKyT5DVoq2jrHlDYNzJCUX6XCud8nmu02j/EkThGzUFIsg2cvZEauyugJiuD2bRtGPziryzBixWAGKsT5bhQBjVfK9OC95FPBk5R4qFRAF4gqwgDac1WcYx61YnZbfWNcOzXMHR38S919ArrnifHD+QrnQeSksEry6OMnjO6U6P40KlEe2bjmQP4+DL52l7yF6gHaQLHaXl2lsmuLONOx3d2C+uJ/qYOTuQy6VsgQTP42pPVEELI2w6Pc2KICf+JurphO8X7fjCRb2uEJvqPeOIPHBtETK6O/RcAZ9lPwXodjEXQbXI5o4lg0+CkfCLP4R6Hh358MQqzDNACkFiu69HHsTXxesYNcsen4WFAgbxGMIkMCRP2dXpF9N4xEXubkD3dvvHMwvnEBCMOm6UjXVxA/QyZ1zjk9cWbyzBgNy8EAZOH16G/Twuf9B6/kHLx6KONJRHbcMeSguY4w0WOO+Ulx+6ET+Ybg5w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(1800799003)(186006)(90011799007)(90021799007)(451199021)(83380400001)(2616005)(54906003)(2906002)(6916009)(4326008)(316002)(5660300002)(8936002)(38070700005)(8676002)(76116006)(64756008)(66556008)(66476007)(91956017)(66946007)(38100700002)(66446008)(966005)(6512007)(478600001)(33656002)(122000001)(71200400001)(86362001)(6486002)(41300700001)(6506007)(36756003)(26005)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <2279DB4368683942AB995E3EA0B189D9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9586 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 585252b5-531b-4be5-063c-08db97b35a49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bCFZW49IyNcA4ZiEaSKwPUBcIXcTFqFjw3Whyra34bSnWY4KFcI9h+vti7+g2xJFfqfYCKkhQFOb3cp2HbnE2b2LFOrggL9ZiQmOM0zu/Yr7oHGQocn5SI5wXmVjik2EV5EnFvqWYteiNw4vjqliLdzCBVd0nA/48H8iTj2B95Hu62QxsWddoD8lS26eulUteHyUra6mhhoC/klQnMkp7tBUa+erk8ITbIxu57faBTmyfbuIzuzaxjdMF8DFMvAzUGxjMsNHBvhqdwus2f/0gDyCVJZkggXaJqZJCiSVBTUIBGdUlJZpSuXjOJxKzJYb6RwwiFmRQIi/r7wxKlIEpK6OqfpxALa1PRyEfM8q2fV5vxIysMYN7MgBBQBYwkhsvFTZMTPJh0frsPPODdW6mxBAqe28QATnKQGjPu2R+Dz2eUMt8QlaBAET+uq3cGLSbGpGmn6V5QgjDjJOYEbRnN7mt+/xCgtk8fSXxGDZUaBtVHL5UUmlzLfabzKryS13cNYhGMtGIfO9ILxb/rCMb3JSM7CcDIHJHuxwOLmgPAd8aOAneDB9p6lS4udzUwfPTclThtzzKO/d5xepQ6ssXc3ghlBqhi1Rg6gjDkUF9dMQA8s7Y6swd4PWw0PcOa+Zumhin/3YT8ehLp3m9jNrsy431yb9KR4ujWyhUMfO+jGygLGLS4nD4USdisAzo4TsGYv14jjXqAYEb91oOeXPnEgHIGgFgQ+0fMiMJdznfN3jfvMl/vp7pvNU6LrCljZZuxHumu1NCnNmwdfKAOBV2b8T7YnLobp2KA4Qpgr4ZXM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(396003)(39860400002)(82310400008)(90011799007)(186006)(1800799003)(90021799007)(451199021)(46966006)(36840700001)(40470700004)(41300700001)(26005)(107886003)(2906002)(5660300002)(83380400001)(8676002)(36860700001)(47076005)(8936002)(6862004)(40460700003)(2616005)(40480700001)(336012)(81166007)(86362001)(316002)(33656002)(53546011)(82740400003)(6506007)(6486002)(54906003)(356005)(478600001)(70586007)(70206006)(6512007)(966005)(4326008)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 02:01:58.3817 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eeec1f96-bf42-4409-124d-08db97b372cc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8640 Hi Ayan, > On Aug 7, 2023, at 21:17, Ayan Kumar Halder wrote: >=20 > Hi Henry, >=20 > On 01/08/2023 04:44, Henry Wang wrote: >> CAUTION: This message has originated from an External Source. Please use= proper judgment and caution when opening attachments, clicking links, or r= esponding to this email. >>=20 >>=20 >> There are two types of memory system architectures available for >> Arm-based systems, namely the Virtual Memory System Architecture (VMSA) >> and the Protected Memory System Architecture (PMSA). According to >> ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that >> controls address translation, access permissions, and memory attribute >> determination and checking, for memory accesses made by the PE. And >> refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection >> scheme where an Memory Protection Unit (MPU) manages instruction and >> data access. Currently, Xen only suuports VMSA. >>=20 >> As a preparation of the Xen MPU (PMSA) support. Introduce a Kconfig >> choice under the "Architecture Features" menu for user to choose the >> memory system architecture for the system. Since currently only VMSA >> is supported, only add the bool CONFIG_HAS_MMU to keep consistent with >> the default behavior. User can choose either VMSA or PMSA but not both >> in the future after PMSA/MPU is supported in Xen. >>=20 >> Suggested-by: Julien Grall >> Signed-off-by: Henry Wang >=20 > The patch looks good, but it does not cleanly apply >=20 > b4 mbox 20230801034419.2047541-3-Henry.Wang@arm.com >=20 > git am ./20230801034419.2047541-3-Henry.Wang@arm.com.mbx >=20 > Applying: xen/arm: Introduce 'choice' for memory system architecture > error: xen/arch/arm/Kconfig: does not match index > Patch failed at 0001 xen/arm: Introduce 'choice' for memory system archit= ecture This is weird, so I tried to apply this patch (by clicking the mbox button = on the top right of [1]) on top of 65f0d6fc80 x86: Drop opt_pku entirely and below is what I have: $ git am ~/v4-02-13-xen-arm-Introduce-choice-for-memory-system-architecture= .patch Applying: xen/arm: Introduce 'choice' for memory system architecture I suspect recently there is some Kconfig changes, so could you please clari= fy your base commit? Thanks! [1] https://patchwork.kernel.org/project/xen-devel/patch/20230801034419.204= 7541-3-Henry.Wang@arm.com/ Kind regards, Henry >=20 > - Ayan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:12:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:12:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579210.907083 (Exim 4.92) (envelope-from ) id 1qTCCh-0001s8-Gn; Tue, 08 Aug 2023 02:12:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579210.907083; Tue, 08 Aug 2023 02:12:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCCh-0001s1-Dx; Tue, 08 Aug 2023 02:12:11 +0000 Received: by outflank-mailman (input) for mailman id 579210; Tue, 08 Aug 2023 02:12:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCCg-0001rv-Cv for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 02:12:10 +0000 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [2607:f8b0:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f948c127-3590-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 04:12:07 +0200 (CEST) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1bbd03cb7c1so33253145ad.3 for ; Mon, 07 Aug 2023 19:12:07 -0700 (PDT) Received: from dread.disaster.area (pa49-180-166-213.pa.nsw.optusnet.com.au. [49.180.166.213]) by smtp.gmail.com with ESMTPSA id jv14-20020a17090b31ce00b00263e4dc33aasm9313956pjb.11.2023.08.07.19.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 19:12:05 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qTCCY-002WbH-25; Tue, 08 Aug 2023 12:12:02 +1000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f948c127-3590-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1691460726; x=1692065526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S5nJ90Y7HkcDKRE+pcPu5keZJ+24iVkBC6PdC2b5uJ0=; b=AFt/VuazRx0w4Tn1IU2JUHjsvK9//KmKNKOzUsMjyPWc+WauQSv5qCgAlx5y8wlPIL hZ4kYEryWxLgRLeYaQj4xKQmbz2+fwGFdpiEnUYFWB8cS1WKDsqaNRvUwjpvdhEE1wqM Pa0gWwQ1zRdGeKwMXonsis/5aIvId3dvX65TjmeUK6fHIDfWZQ6NWrHdG0BFjSgBlwHn EPCT/fdxzOXvB1URY1V13teKkeQnNqcDN6h4mKjIkvEjRefZqSa/0jDLGkSWo+riYILJ 5YWVtmGXaJL6ouBig0rvs/QbDa4KngUZ9XItmSUyw062F/G/EjTZcECBZuQiNzd7pFh2 XSVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691460726; x=1692065526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S5nJ90Y7HkcDKRE+pcPu5keZJ+24iVkBC6PdC2b5uJ0=; b=LBXsuz/GxxqMKGoOTrVObdS/OjVabJnNf/9LOjos+O+7LiXdqlBb6P/v+KrOOghXZ1 Kq3zGi3Me2Jtc83cBSeX2Fd7M20gFJCCeVKfQPKvxsuDwVC6oUy1fniyhE1swcsxxoCH FX7tFRrgRNFFxA8m2orBUF/jJ36BsWogSHS1IQnHyf74+KiSKK+C8XZnm1TB6S2NU3Qe /+//TK6zbH3QJTYK206twrisXg84/XQBHy9LZSkqVQhIpmUomXnWlFpMrRwmvCjHctHo 4pghOsQ61PuNeGS7goiW7DfUFgvmfZmLr3Z3rT/7/3R7PbLhpANveGvKV1hM1qyYfqL3 qDXw== X-Gm-Message-State: AOJu0Yzu3ZfmLas3WtTsdZ+w9Bc6wQWxnYmjbq5nMRdo8nEkAVacEHLJ Gc7EK7QbWaKQ7JV/cYTswBpFlg== X-Google-Smtp-Source: AGHT+IHE8FO8RAjHks3Izbxy+yXIAOFeIsxej7SyncoSZwq8TiDh2J09MxtXtA2ffdHhYGJ2WNjVaA== X-Received: by 2002:a17:90a:ad90:b0:25e:d013:c22c with SMTP id s16-20020a17090aad9000b0025ed013c22cmr8256877pjq.47.1691460726140; Mon, 07 Aug 2023 19:12:06 -0700 (PDT) Date: Tue, 8 Aug 2023 12:12:02 +1000 From: Dave Chinner To: Qi Zheng Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song Subject: Re: [PATCH v4 44/48] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} Message-ID: References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-45-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807110936.21819-45-zhengqi.arch@bytedance.com> On Mon, Aug 07, 2023 at 07:09:32PM +0800, Qi Zheng wrote: > Currently, we maintain two linear arrays per node per memcg, which are > shrinker_info::map and shrinker_info::nr_deferred. And we need to resize > them when the shrinker_nr_max is exceeded, that is, allocate a new array, > and then copy the old array to the new array, and finally free the old > array by RCU. > > For shrinker_info::map, we do set_bit() under the RCU lock, so we may set > the value into the old map which is about to be freed. This may cause the > value set to be lost. The current solution is not to copy the old map when > resizing, but to set all the corresponding bits in the new map to 1. This > solves the data loss problem, but bring the overhead of more pointless > loops while doing memcg slab shrink. > > For shrinker_info::nr_deferred, we will only modify it under the read lock > of shrinker_rwsem, so it will not run concurrently with the resizing. But > after we make memcg slab shrink lockless, there will be the same data loss > problem as shrinker_info::map, and we can't work around it like the map. > > For such resizable arrays, the most straightforward idea is to change it > to xarray, like we did for list_lru [1]. We need to do xa_store() in the > list_lru_add()-->set_shrinker_bit(), but this will cause memory > allocation, and the list_lru_add() doesn't accept failure. A possible > solution is to pre-allocate, but the location of pre-allocation is not > well determined. So you implemented a two level array that preallocates leaf nodes to work around it? It's remarkable complex for what it does, I can't help but think a radix tree using a special holder for nr_deferred values of zero would end up being simpler... > Therefore, this commit chooses to introduce a secondary array for > shrinker_info::{map, nr_deferred}, so that we only need to copy this > secondary array every time the size is resized. Then even if we get the > old secondary array under the RCU lock, the found map and nr_deferred are > also true, so no data is lost. I don't understand what you are trying to describe here. If we get the old array, then don't we get either a stale nr_deferred value, or the update we do gets lost because the next shrinker lookup will find the new array and os the deferred value stored to the old one is never seen again? > > [1]. https://lore.kernel.org/all/20220228122126.37293-13-songmuchun@bytedance.com/ > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- ..... > diff --git a/mm/shrinker.c b/mm/shrinker.c > index a27779ed3798..1911c06b8af5 100644 > --- a/mm/shrinker.c > +++ b/mm/shrinker.c > @@ -12,15 +12,50 @@ DECLARE_RWSEM(shrinker_rwsem); > #ifdef CONFIG_MEMCG > static int shrinker_nr_max; > > -/* The shrinker_info is expanded in a batch of BITS_PER_LONG */ > -static inline int shrinker_map_size(int nr_items) > +static inline int shrinker_unit_size(int nr_items) > { > - return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); > + return (DIV_ROUND_UP(nr_items, SHRINKER_UNIT_BITS) * sizeof(struct shrinker_info_unit *)); > } > > -static inline int shrinker_defer_size(int nr_items) > +static inline void shrinker_unit_free(struct shrinker_info *info, int start) > { > - return (round_up(nr_items, BITS_PER_LONG) * sizeof(atomic_long_t)); > + struct shrinker_info_unit **unit; > + int nr, i; > + > + if (!info) > + return; > + > + unit = info->unit; > + nr = DIV_ROUND_UP(info->map_nr_max, SHRINKER_UNIT_BITS); > + > + for (i = start; i < nr; i++) { > + if (!unit[i]) > + break; > + > + kvfree(unit[i]); > + unit[i] = NULL; > + } > +} > + > +static inline int shrinker_unit_alloc(struct shrinker_info *new, > + struct shrinker_info *old, int nid) > +{ > + struct shrinker_info_unit *unit; > + int nr = DIV_ROUND_UP(new->map_nr_max, SHRINKER_UNIT_BITS); > + int start = old ? DIV_ROUND_UP(old->map_nr_max, SHRINKER_UNIT_BITS) : 0; > + int i; > + > + for (i = start; i < nr; i++) { > + unit = kvzalloc_node(sizeof(*unit), GFP_KERNEL, nid); A unit is 576 bytes. Why is this using kvzalloc_node()? > + if (!unit) { > + shrinker_unit_free(new, start); > + return -ENOMEM; > + } > + > + new->unit[i] = unit; > + } > + > + return 0; > } > > void free_shrinker_info(struct mem_cgroup *memcg) > @@ -32,6 +67,7 @@ void free_shrinker_info(struct mem_cgroup *memcg) > for_each_node(nid) { > pn = memcg->nodeinfo[nid]; > info = rcu_dereference_protected(pn->shrinker_info, true); > + shrinker_unit_free(info, 0); > kvfree(info); > rcu_assign_pointer(pn->shrinker_info, NULL); > } Why is this safe? The info and maps are looked up by RCU, so why is freeing them without a RCU grace period expiring safe? Yes, it was safe to do this when it was all under a semaphore, but now the lookup and use is under RCU, so this freeing isn't serialised against lookups anymore... > @@ -40,28 +76,27 @@ void free_shrinker_info(struct mem_cgroup *memcg) > int alloc_shrinker_info(struct mem_cgroup *memcg) > { > struct shrinker_info *info; > - int nid, size, ret = 0; > - int map_size, defer_size = 0; > + int nid, ret = 0; > + int array_size = 0; > > down_write(&shrinker_rwsem); > - map_size = shrinker_map_size(shrinker_nr_max); > - defer_size = shrinker_defer_size(shrinker_nr_max); > - size = map_size + defer_size; > + array_size = shrinker_unit_size(shrinker_nr_max); > for_each_node(nid) { > - info = kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); > - if (!info) { > - free_shrinker_info(memcg); > - ret = -ENOMEM; > - break; > - } > - info->nr_deferred = (atomic_long_t *)(info + 1); > - info->map = (void *)info->nr_deferred + defer_size; > + info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); > + if (!info) > + goto err; > info->map_nr_max = shrinker_nr_max; > + if (shrinker_unit_alloc(info, NULL, nid)) > + goto err; That's going to now do a lot of small memory allocation when we have lots of shrinkers active.... > @@ -150,17 +175,34 @@ static int expand_shrinker_info(int new_id) > return ret; > } > > +static inline int shriner_id_to_index(int shrinker_id) shrinker_id_to_index > +{ > + return shrinker_id / SHRINKER_UNIT_BITS; > +} > + > +static inline int shriner_id_to_offset(int shrinker_id) shrinker_id_to_offset > +{ > + return shrinker_id % SHRINKER_UNIT_BITS; > +} .... > @@ -209,26 +251,31 @@ static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, > struct mem_cgroup *memcg) > { > struct shrinker_info *info; > + struct shrinker_info_unit *unit; > > info = shrinker_info_protected(memcg, nid); > - return atomic_long_xchg(&info->nr_deferred[shrinker->id], 0); > + unit = info->unit[shriner_id_to_index(shrinker->id)]; > + return atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); > } > > static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, > struct mem_cgroup *memcg) > { > struct shrinker_info *info; > + struct shrinker_info_unit *unit; > > info = shrinker_info_protected(memcg, nid); > - return atomic_long_add_return(nr, &info->nr_deferred[shrinker->id]); > + unit = info->unit[shriner_id_to_index(shrinker->id)]; > + return atomic_long_add_return(nr, &unit->nr_deferred[shriner_id_to_offset(shrinker->id)]); > } > > void reparent_shrinker_deferred(struct mem_cgroup *memcg) > { > - int i, nid; > + int nid, index, offset; > long nr; > struct mem_cgroup *parent; > struct shrinker_info *child_info, *parent_info; > + struct shrinker_info_unit *child_unit, *parent_unit; > > parent = parent_mem_cgroup(memcg); > if (!parent) > @@ -239,9 +286,13 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) > for_each_node(nid) { > child_info = shrinker_info_protected(memcg, nid); > parent_info = shrinker_info_protected(parent, nid); > - for (i = 0; i < child_info->map_nr_max; i++) { > - nr = atomic_long_read(&child_info->nr_deferred[i]); > - atomic_long_add(nr, &parent_info->nr_deferred[i]); > + for (index = 0; index < shriner_id_to_index(child_info->map_nr_max); index++) { > + child_unit = child_info->unit[index]; > + parent_unit = parent_info->unit[index]; > + for (offset = 0; offset < SHRINKER_UNIT_BITS; offset++) { > + nr = atomic_long_read(&child_unit->nr_deferred[offset]); > + atomic_long_add(nr, &parent_unit->nr_deferred[offset]); > + } > } > } > up_read(&shrinker_rwsem); > @@ -407,7 +458,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > { > struct shrinker_info *info; > unsigned long ret, freed = 0; > - int i; > + int offset, index = 0; > > if (!mem_cgroup_online(memcg)) > return 0; > @@ -419,56 +470,63 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > if (unlikely(!info)) > goto unlock; > > - for_each_set_bit(i, info->map, info->map_nr_max) { > - struct shrink_control sc = { > - .gfp_mask = gfp_mask, > - .nid = nid, > - .memcg = memcg, > - }; > - struct shrinker *shrinker; > + for (; index < shriner_id_to_index(info->map_nr_max); index++) { > + struct shrinker_info_unit *unit; This adds another layer of indent to shrink_slab_memcg(). Please factor it first so that the code ends up being readable. Doing that first as a separate patch will also make the actual algorithm changes in this patch be much more obvious - this huge hunk of diff is pretty much impossible to review... -Dave. -- Dave Chinner david@fromorbit.com From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:24:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:24:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579215.907093 (Exim 4.92) (envelope-from ) id 1qTCOS-0003Pp-ID; Tue, 08 Aug 2023 02:24:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579215.907093; Tue, 08 Aug 2023 02:24:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCOS-0003Pi-EM; Tue, 08 Aug 2023 02:24:20 +0000 Received: by outflank-mailman (input) for mailman id 579215; Tue, 08 Aug 2023 02:24:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCOR-0003Pa-Co for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 02:24:19 +0000 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [2607:f8b0:4864:20::635]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaf9d239-3592-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 04:24:15 +0200 (CEST) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1b9c5e07c1bso46334815ad.2 for ; Mon, 07 Aug 2023 19:24:15 -0700 (PDT) Received: from dread.disaster.area (pa49-180-166-213.pa.nsw.optusnet.com.au. [49.180.166.213]) by smtp.gmail.com with ESMTPSA id h17-20020a170902f55100b001b864add154sm7583543plf.154.2023.08.07.19.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 19:24:13 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qTCOH-002Wjl-2u; Tue, 08 Aug 2023 12:24:09 +1000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf9d239-3592-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1691461454; x=1692066254; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HUGk8Gm4qWKcvYyYW1oMdtOdnxgdWZtLrf0WmvG8aOg=; b=E8R/sNcxrOK1IUnWWdPxuHAURfzEKsQXFvPF/8WoYIocyBzrOF6C/15wk0bBTyq8fp w+9skh2POsCjChG96SdxCE1ukUJoo7U6iUCJoOHux3qHabiPQt2q8GYhzVnnqh4Ia8gf otMrpF/u+4+6GZvnjfH9iZQVLX7oYyO80eB3aSg/65gqSdDxQ6TBQ0eTbg/7hck8CRIR N2poqJrxPUv+xHM8+kwldwyyrpY8ClA2gjcNqxK3I6Rjaxj3f+CIGTw2aTNSrwyrBhAC fS1NWvmq7XKVFcVROA15iTu7BqzTlMOOgRsfusR61dD9uCRFfNfvH5SixHmdTB0ZZ2at NUZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691461454; x=1692066254; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HUGk8Gm4qWKcvYyYW1oMdtOdnxgdWZtLrf0WmvG8aOg=; b=JCDEPKy/OxTqIlFSkq0CoxQgeSx4n2rmAemcxLE/xC5G55O5gJ6qew9WIEoN533Sjz 4vYEvvORlsxQkgurs9pORdraUeAO7qCEDVTftD4WTIq2Zbl8xO8JyeAf4AnUl2kW9Wba 4SuD2tBi8X3roieTlEPHespJrZ1UpmsnoIur8B5gJIyIQpF5iND/VvII0EKTQg4YVmLp wTsNU8BBQmebgxSVeZbBzMBc5LGc1HfBzuhW6S5FUrgv4h1mgYz0hhkQHhS8E+6vFNeK ld8e3r7nn12Zbdkion32n30lOWhazpP2ceYlc4kkRAtgGKwt9VPtftzwDVSqnZ8khEpZ T6qA== X-Gm-Message-State: AOJu0YyXTzUAEp7OXOlGC9rVN7IlMZXmSZIdNsg/D0+ePAkTQEoz+gTl wRYGjmM/lvZuJmpqqwr+QuKyoQ== X-Google-Smtp-Source: AGHT+IEzrDGpXyLCXRNBmZGxK80nBmbnZ3Zc29NdEkVzSJ3QNXEJvOFh13D52+77LsVxnWz7HKqTHA== X-Received: by 2002:a17:902:8692:b0:1b9:d307:c1df with SMTP id g18-20020a170902869200b001b9d307c1dfmr10722096plo.17.1691461453690; Mon, 07 Aug 2023 19:24:13 -0700 (PDT) Date: Tue, 8 Aug 2023 12:24:09 +1000 From: Dave Chinner To: Qi Zheng Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless Message-ID: References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-46-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807110936.21819-46-zhengqi.arch@bytedance.com> On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index eb342994675a..f06225f18531 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -4,6 +4,8 @@ > > #include > #include > +#include > +#include > > #define SHRINKER_UNIT_BITS BITS_PER_LONG > > @@ -87,6 +89,10 @@ struct shrinker { > int seeks; /* seeks to recreate an obj */ > unsigned flags; > > + refcount_t refcount; > + struct completion done; > + struct rcu_head rcu; Documentation, please. What does the refcount protect, what does the completion provide, etc. > + > void *private_data; > > /* These are for internal use */ > @@ -120,6 +126,17 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); > void shrinker_register(struct shrinker *shrinker); > void shrinker_free(struct shrinker *shrinker); > > +static inline bool shrinker_try_get(struct shrinker *shrinker) > +{ > + return refcount_inc_not_zero(&shrinker->refcount); > +} > + > +static inline void shrinker_put(struct shrinker *shrinker) > +{ > + if (refcount_dec_and_test(&shrinker->refcount)) > + complete(&shrinker->done); > +} > + > #ifdef CONFIG_SHRINKER_DEBUG > extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker, > const char *fmt, ...); > diff --git a/mm/shrinker.c b/mm/shrinker.c > index 1911c06b8af5..d318f5621862 100644 > --- a/mm/shrinker.c > +++ b/mm/shrinker.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > #include > > #include "internal.h" > @@ -577,33 +578,42 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, > if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) > return shrink_slab_memcg(gfp_mask, nid, memcg, priority); > > - if (!down_read_trylock(&shrinker_rwsem)) > - goto out; > - > - list_for_each_entry(shrinker, &shrinker_list, list) { > + rcu_read_lock(); > + list_for_each_entry_rcu(shrinker, &shrinker_list, list) { > struct shrink_control sc = { > .gfp_mask = gfp_mask, > .nid = nid, > .memcg = memcg, > }; > > + if (!shrinker_try_get(shrinker)) > + continue; > + > + /* > + * We can safely unlock the RCU lock here since we already > + * hold the refcount of the shrinker. > + */ > + rcu_read_unlock(); > + > ret = do_shrink_slab(&sc, shrinker, priority); > if (ret == SHRINK_EMPTY) > ret = 0; > freed += ret; > + > /* > - * Bail out if someone want to register a new shrinker to > - * prevent the registration from being stalled for long periods > - * by parallel ongoing shrinking. > + * This shrinker may be deleted from shrinker_list and freed > + * after the shrinker_put() below, but this shrinker is still > + * used for the next traversal. So it is necessary to hold the > + * RCU lock first to prevent this shrinker from being freed, > + * which also ensures that the next shrinker that is traversed > + * will not be freed (even if it is deleted from shrinker_list > + * at the same time). > */ This needs to be moved to the head of the function, and document the whole list walk, get, put and completion parts of the algorithm that make it safe. There's more to this than "we hold a reference count", especially the tricky "we might see the shrinker before it is fully initialised" case.... ..... > void shrinker_free(struct shrinker *shrinker) > { > struct dentry *debugfs_entry = NULL; > @@ -686,9 +712,18 @@ void shrinker_free(struct shrinker *shrinker) > if (!shrinker) > return; > > + if (shrinker->flags & SHRINKER_REGISTERED) { > + shrinker_put(shrinker); > + wait_for_completion(&shrinker->done); > + } Needs a comment explaining why we need to wait here... > + > down_write(&shrinker_rwsem); > if (shrinker->flags & SHRINKER_REGISTERED) { > - list_del(&shrinker->list); > + /* > + * Lookups on the shrinker are over and will fail in the future, > + * so we can now remove it from the lists and free it. > + */ .... rather than here after the wait has been done and provided the guarantee that no shrinker is running or will run again... -Dave. -- Dave Chinner david@fromorbit.com From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:24:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:24:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579216.907103 (Exim 4.92) (envelope-from ) id 1qTCOY-0003fi-Op; Tue, 08 Aug 2023 02:24:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579216.907103; Tue, 08 Aug 2023 02:24:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCOY-0003fZ-LP; Tue, 08 Aug 2023 02:24:26 +0000 Received: by outflank-mailman (input) for mailman id 579216; Tue, 08 Aug 2023 02:24:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCOX-0003f1-La; Tue, 08 Aug 2023 02:24:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCOX-00055X-Dz; Tue, 08 Aug 2023 02:24:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCOW-00053b-Tb; Tue, 08 Aug 2023 02:24:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTCOW-0000Cj-T2; Tue, 08 Aug 2023 02:24:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=etp0bgJ8r++B1jgp7jsvLrBI5+5WmCUVmu03pkfdBlM=; b=1SCRc3Aj0CdUkRhvJCoyUALQYy Z7ehrNJg/9X4CBxlM8AvP6kdw3087955axxbnTxHeLAuc8j8fcdZc+zvk/euFhzjTYZbStkc+Cab9 qcpO1eOnJLquimBDbbFGOz7wk4ow07ClE9BZLjE+E6FlTsQaZeSToC1cyYPIxQMYVuz0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182223: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d3be806dae9c122fe94702cd9fa2e358a60828cd X-Osstest-Versions-That: xen=65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 From: osstest service owner Date: Tue, 08 Aug 2023 02:24:24 +0000 flight 182223 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182223/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen d3be806dae9c122fe94702cd9fa2e358a60828cd baseline version: xen 65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 Last test of basis 182218 2023-08-07 15:00:24 Z 0 days Testing same since 182223 2023-08-07 23:02:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Federico Serafini Gianluca Luparini Jan Beulich Michal Orzel Nicola Vetrini Simone Ballarin Stefano Stabellini Tamas K Lengyel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 65f0d6fc80..d3be806dae d3be806dae9c122fe94702cd9fa2e358a60828cd -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:28:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:28:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579228.907113 (Exim 4.92) (envelope-from ) id 1qTCSp-0004au-9f; Tue, 08 Aug 2023 02:28:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579228.907113; Tue, 08 Aug 2023 02:28:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCSp-0004an-6N; Tue, 08 Aug 2023 02:28:51 +0000 Received: by outflank-mailman (input) for mailman id 579228; Tue, 08 Aug 2023 02:28:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCSn-0004aO-Q3 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 02:28:50 +0000 Received: from out-64.mta1.migadu.com (out-64.mta1.migadu.com [95.215.58.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4dc898f0-3593-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 04:28:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dc898f0-3593-11ee-b280-6b7b168915f2 Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691461726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b018wDD09q8ybQHeVjJQlHvcOhDGiPGtV/Qkh1+P4Jk=; b=qG+f2yssWczIj/c36Dv6lyS9LMH4Qo3IpX5TeG1prf8Sjbf2TndiPspYdq8X2q9u4a0d4+ mAWwkzbtPW05nR7/h47VG61cI5kT4JFrqpqLlXTjX8sbawq1mwyPUSZYPolnAScsj79wmk u8AjZlHRxpLLihMJimmgVrAhX04JcfM= MIME-Version: 1.0 Subject: Re: [PATCH v4 19/48] rcu: dynamically allocate the rcu-kfree shrinker X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230807110936.21819-20-zhengqi.arch@bytedance.com> Date: Tue, 8 Aug 2023 10:28:00 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , simon.horman@corigine.com, dlemoal@kernel.org, LKML , Linux-MM , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <0C2FEFBD-B866-46C4-B684-1FB9A048B899@linux.dev> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-20-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT > On Aug 7, 2023, at 19:09, Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-kfree shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:31:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:31:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579234.907123 (Exim 4.92) (envelope-from ) id 1qTCVW-00064D-QH; Tue, 08 Aug 2023 02:31:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579234.907123; Tue, 08 Aug 2023 02:31:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCVW-000646-NO; Tue, 08 Aug 2023 02:31:38 +0000 Received: by outflank-mailman (input) for mailman id 579234; Tue, 08 Aug 2023 02:31:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTCVU-00063t-Or for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 02:31:36 +0000 Received: from out-75.mta0.migadu.com (out-75.mta0.migadu.com [2001:41d0:1004:224b::4b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1b35dbc-3593-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 04:31:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1b35dbc-3593-11ee-b280-6b7b168915f2 Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691461894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYMFGUKWQ+g0CyW9GTfXDcuOQANHVM/3Ghb9+ZBk468=; b=SxDNqxqUZNnRnBlh2G9KUWvivC/VvwTPU5/lDdc1G8r6XSCULCEnHFJghGF7/AiccY4oHl BBxN99+RbiiBoUusHHczSoq6/RgGM1N3zCJvlmXh3/z/H3OCVkCw+RxEiqw4cAM7WaU0dm eCamJhqdXamgXqX+92wkV8I/0pw0E38= MIME-Version: 1.0 Subject: Re: [PATCH v4 06/48] binder: dynamically allocate the android-binder shrinker X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230807110936.21819-7-zhengqi.arch@bytedance.com> Date: Tue, 8 Aug 2023 10:30:45 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <680D8CC2-114E-452F-9824-D6F59D917E84@linux.dev> References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-7-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT > On Aug 7, 2023, at 19:08, Qi Zheng wrote: > > Use new APIs to dynamically allocate the android-binder shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song From xen-devel-bounces@lists.xenproject.org Tue Aug 08 02:44:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 02:44:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579241.907133 (Exim 4.92) (envelope-from ) id 1qTChn-0007du-Rb; Tue, 08 Aug 2023 02:44:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579241.907133; Tue, 08 Aug 2023 02:44:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTChn-0007dn-Oq; Tue, 08 Aug 2023 02:44:19 +0000 Received: by outflank-mailman (input) for mailman id 579241; Tue, 08 Aug 2023 02:44:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTChl-0007df-Rf for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 02:44:17 +0000 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [2607:f8b0:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76b7a0b6-3595-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 04:44:16 +0200 (CEST) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1bbf3da0ea9so33830225ad.2 for ; Mon, 07 Aug 2023 19:44:16 -0700 (PDT) Received: from dread.disaster.area (pa49-180-166-213.pa.nsw.optusnet.com.au. [49.180.166.213]) by smtp.gmail.com with ESMTPSA id u2-20020a170902e80200b001b893b689a0sm7632067plg.84.2023.08.07.19.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 19:44:14 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qTChf-002XBg-27; Tue, 08 Aug 2023 12:44:11 +1000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76b7a0b6-3595-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1691462655; x=1692067455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZZ3n364wJBBn5i6olC7X8xOphz5aoEwi3PPn9Humxy4=; b=c9iOPpy41VC6QSzv5vLbmCPsxZB2K7hAItf8MEtryT/BAlfvdA0UPM4PAg3DtN7rr+ GFW2nm1AoLFEe5zmSSiqyIhn92P6iecybeuExkqa7jbnj+LEVM1LioV7SZGiR/8Kzy2+ mJYrJW8XMi2+dbRvP7Xg6QuSzUnp/yHkq29M7vbAYNrF1NokfShgkpn7COiSBb38dkF0 MWE0ZNG9ZS4LzaWgVeAy0Pmh7etHcKYaOYLW+oCVP3Q2zlcEbOnfLG0lI+GjqQwBJGqv OKDqkP3u3mDYRaZI2hDArPl64kIP09oRYh791qhymi4aMBqJthtqlGcAIAw7e+Im4Q2d AiTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691462655; x=1692067455; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZZ3n364wJBBn5i6olC7X8xOphz5aoEwi3PPn9Humxy4=; b=MnKB9VzBhtElJF8DuaK8pjAVdh/k2dk+/8cgzFVei7nZye4JkM1L1Swa5OnAwLC5/t ffqcQ9KiaXcFX6GM1UJINN2nx0S+8cD6EEzjD9C44ypEQsn12d0+G6vwDBuXBgNsu2Xn j9B/LgczRfH4hBuLQudUCnvbopu0mvBBqAT8AaO/V7VnIm61m2hbMgs3ZIUpBisEK2GN UPbYP9hulDH5tjP5nha5+gc+ekxLlFBZ24QhEeTJrJyjVV2G4FV80L3MgC499/ju66aU LgLbA7iBgOEHD3peq14sz6j6GNIiZ2yvxutTItieQULnHmcOFybXPlwc7g8u3SdnT3/9 1TEw== X-Gm-Message-State: AOJu0Yw77Nq89SBYVtYy6F3GBWO23SA6rFCfROYVErGf3UkgL9qpI7LA KU8kUJLPiDwRdXrzEHrQ8uEGdQ== X-Google-Smtp-Source: AGHT+IEZT2gUmOSYrkIbMjP5ySF6z1UEt5Q+o+GMN8zU98oO9pgzqqi+i8QK+swPthTlPTk4WQ36Qw== X-Received: by 2002:a17:902:7287:b0:1b3:f5c7:4e75 with SMTP id d7-20020a170902728700b001b3f5c74e75mr9699662pll.58.1691462654669; Mon, 07 Aug 2023 19:44:14 -0700 (PDT) Date: Tue, 8 Aug 2023 12:44:11 +1000 From: Dave Chinner To: Qi Zheng Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v4 46/48] mm: shrinker: make memcg slab shrink lockless Message-ID: References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-47-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807110936.21819-47-zhengqi.arch@bytedance.com> On Mon, Aug 07, 2023 at 07:09:34PM +0800, Qi Zheng wrote: > Like global slab shrink, this commit also uses refcount+RCU method to make > memcg slab shrink lockless. This patch does random code cleanups amongst the actual RCU changes. Can you please move the cleanups to a spearate patch to reduce the noise in this one? > diff --git a/mm/shrinker.c b/mm/shrinker.c > index d318f5621862..fee6f62904fb 100644 > --- a/mm/shrinker.c > +++ b/mm/shrinker.c > @@ -107,6 +107,12 @@ static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, > lockdep_is_held(&shrinker_rwsem)); > } > > +static struct shrinker_info *shrinker_info_rcu(struct mem_cgroup *memcg, > + int nid) > +{ > + return rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); > +} This helper doesn't add value. It doesn't tell me that rcu_read_lock() needs to be held when it is called, for one.... > static int expand_one_shrinker_info(struct mem_cgroup *memcg, int new_size, > int old_size, int new_nr_max) > { > @@ -198,7 +204,7 @@ void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) > struct shrinker_info_unit *unit; > > rcu_read_lock(); > - info = rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); > + info = shrinker_info_rcu(memcg, nid); ... whilst the original code here was obviously correct. > unit = info->unit[shriner_id_to_index(shrinker_id)]; > if (!WARN_ON_ONCE(shrinker_id >= info->map_nr_max)) { > /* Pairs with smp mb in shrink_slab() */ > @@ -211,7 +217,7 @@ void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) > > static DEFINE_IDR(shrinker_idr); > > -static int prealloc_memcg_shrinker(struct shrinker *shrinker) > +static int shrinker_memcg_alloc(struct shrinker *shrinker) Cleanups in a separate patch. > @@ -253,10 +258,15 @@ static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, > { > struct shrinker_info *info; > struct shrinker_info_unit *unit; > + long nr_deferred; > > - info = shrinker_info_protected(memcg, nid); > + rcu_read_lock(); > + info = shrinker_info_rcu(memcg, nid); > unit = info->unit[shriner_id_to_index(shrinker->id)]; > - return atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); > + nr_deferred = atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); > + rcu_read_unlock(); > + > + return nr_deferred; > } This adds two rcu_read_lock() sections to every call to do_shrink_slab(). It's not at all clear ifrom any of the other code that do_shrink_slab() now has internal rcu_read_lock() sections.... > @@ -464,18 +480,23 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > if (!mem_cgroup_online(memcg)) > return 0; > > - if (!down_read_trylock(&shrinker_rwsem)) > - return 0; > - > - info = shrinker_info_protected(memcg, nid); > +again: > + rcu_read_lock(); > + info = shrinker_info_rcu(memcg, nid); > if (unlikely(!info)) > goto unlock; > > - for (; index < shriner_id_to_index(info->map_nr_max); index++) { > + if (index < shriner_id_to_index(info->map_nr_max)) { > struct shrinker_info_unit *unit; > > unit = info->unit[index]; > > + /* > + * The shrinker_info_unit will not be freed, so we can > + * safely release the RCU lock here. > + */ > + rcu_read_unlock(); Why - what guarantees that the shrinker_info_unit exists at this point? We hold no reference to it, we hold no reference to any shrinker, etc. What provides this existence guarantee? > + > for_each_set_bit(offset, unit->map, SHRINKER_UNIT_BITS) { > struct shrink_control sc = { > .gfp_mask = gfp_mask, > @@ -485,12 +506,14 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > struct shrinker *shrinker; > int shrinker_id = calc_shrinker_id(index, offset); > > + rcu_read_lock(); > shrinker = idr_find(&shrinker_idr, shrinker_id); > - if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { > - if (!shrinker) > - clear_bit(offset, unit->map); > + if (unlikely(!shrinker || !shrinker_try_get(shrinker))) { > + clear_bit(offset, unit->map); > + rcu_read_unlock(); > continue; > } > + rcu_read_unlock(); > > /* Call non-slab shrinkers even though kmem is disabled */ > if (!memcg_kmem_online() && > @@ -523,15 +546,20 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > set_shrinker_bit(memcg, nid, shrinker_id); > } > freed += ret; > - > - if (rwsem_is_contended(&shrinker_rwsem)) { > - freed = freed ? : 1; > - goto unlock; > - } > + shrinker_put(shrinker); Ok, so why is this safe to call without holding the rcu read lock? The global shrinker has to hold the rcu_read_lock() whilst calling shrinker_put() to guarantee the validity of the list next pointer, but we don't hold off RCU here so what guarantees a racing global shrinker walk doesn't trip over this shrinker_put() call dropping the refcount to zero and freeing occuring in a different context... > + /* > + * We have already exited the read-side of rcu critical section > + * before calling do_shrink_slab(), the shrinker_info may be > + * released in expand_one_shrinker_info(), so reacquire the > + * shrinker_info. > + */ > + index++; > + goto again; With that, what makes the use of shrinker_info in xchg_nr_deferred_memcg() in do_shrink_slab() coherent and valid? -Dave. -- Dave Chinner david@fromorbit.com From xen-devel-bounces@lists.xenproject.org Tue Aug 08 05:59:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 05:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579248.907143 (Exim 4.92) (envelope-from ) id 1qTFkN-0002Vk-Bo; Tue, 08 Aug 2023 05:59:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579248.907143; Tue, 08 Aug 2023 05:59:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTFkN-0002Vc-6g; Tue, 08 Aug 2023 05:59:11 +0000 Received: by outflank-mailman (input) for mailman id 579248; Tue, 08 Aug 2023 05:59:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTFkM-0002VQ-0b for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 05:59:10 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2060a.outbound.protection.outlook.com [2a01:111:f400:fe13::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aeecbadc-35b0-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 07:59:06 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB7065.eurprd04.prod.outlook.com (2603:10a6:10:127::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 05:59:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 05:59:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aeecbadc-35b0-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C29dsAKW34byNOvfiZG6+HMKlZEzQvwnbCHugjRvdZeZ8zTfRnWkt4eMnbAK9RysV4noNPKjTqXBOvkEBq2kmRHbTL4LY2tr5sz9PZlC3ojc2f36a4PJbZUTXBZskcFGKUhaE5YN5X6rRlv2AmunUf5ViwIVKvys+b1GQfoxrCb1A9JL0QzrUT4yn/1QYvXQ45ZjVdl4yloAcD0xu9Bnpu5cnJnyiLbjUn3qRyzWcUc+dFzbNfIqWLJNCn0eny0TdJHACp+l7JC3eW6qcicSoRUOOdMuHUV9Bp6hdGLCL4KaB4/EzWKPEP5QGiQMZNK0QTusat5aPKUythCKzDszUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m4ctNrmOfO/RfePvyQSK2MCUsiV+pzkfaZdvF5ctkM=; b=F/gADHFb6Cjti7y8cbW5kp66P5h1rxPOdDkD57JMYInY3E7N3vLtlFYM1YHdsEjrkQ6I9dlQpyH1/wvvjF7iDsoBZkte67at5//9XT8lIKRkllAvxaeP3/qBtjQAUp6fNWJgTRcLaM89dWyA57ZgMBzq/sYUOsITFpI+eCUJqFPmpgKq6RZ8bAvxQ/5bFonzKOL1mvtxJ9AWHt7sXCgqd6qTeaSwXdNWA5oanuGhAftJjhoqagKzgE30+nlHc2kA+GIUx4H2UVj3aeLq1KW8tr1A+o5nNVg1CSNmZlfvOo2Xsel3l9n9HwTRreaYqBCNFxj6k5pK8hOcxSuXqFKspQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7m4ctNrmOfO/RfePvyQSK2MCUsiV+pzkfaZdvF5ctkM=; b=aaRDP9J5p9a2P9qsxGOd66qPC78hF7Xd3Z+4CbGOVgKgh3VSU0HFRR1qU1pHR1y2uVNO8t4/0nFM8Qph9zBmswussjzTJtyvjZJZjyyK/bzQyqnOWfvk4feVFTIoMs717cOYftuUyI/p1C4wFURgyiSWm+/pu1+f81ViVPBPeldkfBL78ebzHU6W+R7/gY67Ni6kUwsUNv+gIjNLdTmDn8hXADq589Jq1MMzaaItHujhIo5dxeCWWLs1njkGeKn5NMJV3umOkLvf3ELAM2GngVhaXhhvtVWg/UEeyt7a3lsEy+YxLa4VJ9jlgkb6kag5wByY2OpVk04F+b+6QelTrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 07:59:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <62c8859d-8904-ce30-019b-df976378256c@raptorengineering.com> From: Jan Beulich In-Reply-To: <62c8859d-8904-ce30-019b-df976378256c@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0267.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB7065:EE_ X-MS-Office365-Filtering-Correlation-Id: 52ab680d-5d18-4810-0f1e-08db97d491c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: btg+o0QNExR+kIzFTWGQEjf6NL2j4ZVlFJkhO362hTlGlbv/R623kHaBbxIFBQAY6xK03Vuo3sqg5hjOKOszrPFWW4H0Zfpb1O7PTUkRJ0aiGtNW5eI5k+Q1mll25dJh2n/ZxGqBUYrPEC3av+WCiWxTMcvNxkNKssX4diO7lbSuxmKAQelNRuemTKjHq4EXaaAvZME3x6Kc6dq7FdczLkC1E3pUXLq8X3mbnMi1+Bcw/Q+lweQPoM9vRlcOofUbIkkN3MDYMz7w+XdJzjaeyFs+YI6hGFwOwNQmATn0dBBI4+BMvpdFzcvfTcNJk9QhdRieSAtl9f52Ht6wyUnyDQx/u07NTmze0fXvyQ618vuv2QHlmHcSzYQGygQr5fZr5In/n//iHvccbL4S2cQlGw945lmUmTUrVQTJ9dKOke+nZuRAyuQ1rL6hjM2Nzuh+4rv6LMNdpG4EipBPQclg6VjgyokssQ+SiP+al4LL2/u4t0za/+GyTNdjsjeWBj5q4Cu4Y1Wjhz9tP7wIUOOqrRFWqvA7moS8Rfdskc7/zonNYT1HETqjyWbiLnWakz+JTIJnP3PnSQ2k7TmyP26QYLZ40roXFF5dwLKSpruxlQIxqJiee/rEDNZ4Z+0zNXm9c1h7ithdze1FcLfJrlVcpK/1K7OA7fO3bawXHh6+xbtBj7c/d2mbqUZ1stxFbdi7l5eaiP7sus1w2cFVZrVp1g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199021)(90011799007)(90021799007)(1800799003)(186006)(8936002)(8676002)(5660300002)(6916009)(4326008)(41300700001)(316002)(86362001)(31696002)(2906002)(6512007)(6666004)(6486002)(2616005)(6506007)(53546011)(26005)(36756003)(66476007)(66556008)(66946007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFVuK2FDUU9XZGR0KzI2WkY1OERxd2J2N3hETDhiejR2b1BQcE1mY2RPVzF6?= =?utf-8?B?NDBzL1EwRjJkY092VFU5ZnNyS2hpc0hZaWtZZmdmTzdYb0djUjlUODlZTWF3?= =?utf-8?B?MEVNTFJsRXdHRnYwLytEZVk1b05QZzZSVTRsRFFPZGpwQjNkMTNSM21Ca2NK?= =?utf-8?B?UW8zT2tkbU41WXhDZ1MvOHBNMkVXWDB3SWovQ2pLanFxeG9nWUUzQXF2UGN6?= =?utf-8?B?Vm5vR0E2T0IyVWlGZG9wZEppWml4S3dTNHNkVUdjaDdzTURoL1F1TGJUMWYz?= =?utf-8?B?RC9ueXBvMkV0T1RLUnJCMDZLaGpiL2tVMDJxT3VIaUVENWFLQ1pWcWFZVGhS?= =?utf-8?B?eDcrVVVlUVloakpERVl4WHZEL0Zvd1BETDh1VXhCZUVlbWxLS2o3ajBRZHB1?= =?utf-8?B?UkVvbFZ1TTZlZWcxQVhucTVnZGI0cHptZ2dtQnZoMnJMUWo3Qko2dUI5cDEy?= =?utf-8?B?MXJGQ0NFRlJWd29LUlNZaFhGUmRYT0JabGsxd0xuWGhSazNNSmkvV0ZSd1Fz?= =?utf-8?B?bERydGlGdlBHSmU2Q2UxckxZb2l4Tk5BUGV3ajVIOXR1KzZpYy9mWkdTc2Fm?= =?utf-8?B?K2RMUm41dXRlL01Md1pEOW52MlZsaUlrY3ppTGlYVXg0bVE3VnhQYUZUOUtl?= =?utf-8?B?QXVZUytIcXJZT1Y1OTIyeEY1OHN5MDIwSmc1cEg0QnVaclJyOExjMnAvcFdS?= =?utf-8?B?bzhIU2hNN2NVaEkyaTd6ZElKeDM0OWR4SzFXYVFsaUlqckEwRFZOalkrSExU?= =?utf-8?B?UUFUdm1raXdpcW1BTWk4bGdCL0M2dGFUbDlnNmRzN3poQ2x6T1hoQTV2aHRk?= =?utf-8?B?akRvTDIvZ1JsVGlKQXNIUlNNU3YrSU11b3BPSk5NN2FpOE44elNkV2c4Nm1Z?= =?utf-8?B?by9QT3loekZtYzRja2IrY1ErU1Bidnd2eHJyUmpVdi9QMVk3cDE3Y3hkMXdy?= =?utf-8?B?S2hTcGxXSVNmc2JsTHZIdllmU3RTd0oxaGowSE0rRUZDK2ZWamFTdFdMb1h0?= =?utf-8?B?WWI1alB1ckpYM213OVROZjVxWTAzUU9icXZOVERXR1pzaVVVT2FWZ0N5ekJm?= =?utf-8?B?bmdybG16UlpEdGEramJadDNySjZnU1JSb3pGR3JnaU5mdlFoM1JVNDRDU2Ny?= =?utf-8?B?MnFVOVkvTXlETWhrQmJVUkx6dkoyWWZ3QU4wR3h1LzNtYUR1QVg1VmF4YitU?= =?utf-8?B?cUtrR0piUEQwd2NGS3hCakpYc1R3eWcrc3J3VTJudWFsN21Ba0N6QzNOcXk5?= =?utf-8?B?QWxmb3Brc0dLUWxmZnBCYTV3RkdwQ3dKUFRVZ2xZVkNnUzlKYmV4ZWZWb0Mv?= =?utf-8?B?b2hvMnpibTRLa1k1M3ZlTHZjVjhlYkN5bnJJcTR1WFhpcVdOYTNxeERzWldw?= =?utf-8?B?MXEvOGV1dGRHYkU3VUJPR015VWRTbjlaU2tyVStPdGgwYW9seWlqUkd6amVB?= =?utf-8?B?bHh2OHhPWUtyTlVTNGFJNWFRUm5tT2t3V2IrOWc2TFI5ZHJ3NUhxQmtabVlU?= =?utf-8?B?b0NLaTZIT1Q1eDg5T0NWVkI3aXZGMG1KenFEeU1IR1J1LzN3aU8zazRjdjV1?= =?utf-8?B?Qkg5bWZLajN5Y2RTZi9YT3BaK0hEeDZ3UXM5ZVRjVDUxbElvSnp2cU5YcUVB?= =?utf-8?B?dXBwTnF2em92TjZCUkJtSUFEaEhUTEdkNmdjV09CMDJZTzFRci9NRnFtMU9S?= =?utf-8?B?YUV0TkJZUEdVZzgrOVltbFB5MTVmdnl1aDRxRE5xRWJSV2RvakNueGJDaGs0?= =?utf-8?B?YnpucnNjRXNVSDFVQ3ZZRm5HVXZvaGdWRnZzeWhQVy9LQlBhVXVUcFhKd20z?= =?utf-8?B?QWNTMEM1UTBOQlhzWXdHS1c3elorZHdtWElpcnhGSHh0S3BzdytkU2ZhaFlM?= =?utf-8?B?YXoxR1dGV0tOSHZDaUJIRVRoK3V2VEpVb1VpbDM1QXlsRmdhR0kwSGNkZjJC?= =?utf-8?B?clAvWlBRcCsyM1I0T0drQ0cybHRTUmo1VUFGV09YcWVpR3JtYm51d05CaUVV?= =?utf-8?B?VDFOWEVhaWVTYklBUFpDWnZYVXZIUmhlQ1V3c2hxcU1GRjZKUW52TTlEeTNE?= =?utf-8?B?VnlxOWFxU3dyQ3lDNDhvRnVpNXpkNC9oOUpkQ3ZMZGRkdzNrdlo3a053NHov?= =?utf-8?Q?EeAEETEDU2TlLTGrObkdqOIY6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52ab680d-5d18-4810-0f1e-08db97d491c2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 05:59:04.0263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MtoxgsTzZA7CGu9Sd/f9slrzegd8KSnwMsTngBfWjPVyrelFPxL+6YeZJEhCTz6Qiu8B2+ePNzwHAZio27+Hqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7065 On 07.08.2023 18:22, Shawn Anastasio wrote: > On 8/2/23 2:16 AM, Jan Beulich wrote: >> On 02.08.2023 02:11, Shawn Anastasio wrote: >>> --- a/xen/arch/ppc/include/asm/asm-defns.h >>> +++ b/xen/arch/ppc/include/asm/asm-defns.h >>> @@ -16,6 +16,13 @@ >>> lis reg, (val) @h; \ >>> ori reg, reg, (val) @l; \ >>> >>> +/* >>> + * Load the address of a symbol from the TOC into the specified GPR. >>> + */ >>> +#define LOAD_REG_ADDR(reg,name) \ >>> + addis reg,%r2,name@toc@ha; \ >>> + addi reg,reg,name@toc@l >> >> Didn't you indicate you'd add blanks after the commas (also) here? >> >>> --- a/xen/arch/ppc/ppc64/head.S >>> +++ b/xen/arch/ppc/ppc64/head.S >>> @@ -1,6 +1,7 @@ >>> /* SPDX-License-Identifier: GPL-2.0-or-later */ >>> >>> #include >>> +#include >>> >>> .section .text.header, "ax", %progbits >>> >>> @@ -11,16 +12,19 @@ ENTRY(start) >>> FIXUP_ENDIAN >>> >>> /* set up the TOC pointer */ >>> - LOAD_IMM32(%r2, .TOC.) >>> + bcl 20, 31, 1f >> >> Hard tab slipped in. >> >> I'm happy to take care of both while committing; then: >> Acked-by: Jan Beulich > > Thanks, Jan. Just to clarify, are there any outstanding comments that I > need to address in this series, or are they all able to be handled by > you during commit? I intend to take care of the minor changes to the last two patches during commit. The patch here has gone in already anyway. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 06:05:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 06:05:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579254.907152 (Exim 4.92) (envelope-from ) id 1qTFqj-00045v-UB; Tue, 08 Aug 2023 06:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579254.907152; Tue, 08 Aug 2023 06:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTFqj-00045o-RP; Tue, 08 Aug 2023 06:05:45 +0000 Received: by outflank-mailman (input) for mailman id 579254; Tue, 08 Aug 2023 06:05:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTFqi-00045i-Cn for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 06:05:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20628.outbound.protection.outlook.com [2a01:111:f400:7e1a::628]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b059bbc-35b1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 08:05:42 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8303.eurprd04.prod.outlook.com (2603:10a6:102:1c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 06:05:40 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 06:05:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b059bbc-35b1-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYjzD2nVc9oegIBKedZSUX3uTqvFys8bGzW/t2Gv6AQjoE64y267dSIxMjhlfoRXb7DB5ILSYKomTaWzxx2PVjRohtzzriKXjMHE5nHrgtT1OyFAtunbdKzUHfShE3wIrhshBShWOwl26U4XLcP+zhtTWKsO/Sggm5UPafM9LaqknJL3NeXjVby+7d3CD1uNHDjUWwy6FZZv7Z/Pu7n7opLMx9dNCHG8vwOzzL6PI58wvPG2x90qm19fsXFjMRJa/HWYEz7mnPuuALLEyKAHHA8KzEhTPrDwCeirAOBWy7POx3jo6A/soELLtLhyA3rzRPLCFqEqLVdeIhG4oogszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2Yzjge/p0tWN7wdJH/oMS1mkwIsQlhjyMxz148iZ2M=; b=TKppu9NmhXrFIP969QiRbsrBiFNqMSSLhUFPnTmmGmlrI/DqyR05CIfuBppyqgvHXXnGDdC8N1ry9cVJ01cZyJrS2mMfxaU27ynhswF51ZJmpIX/fdBJGgLr2IUMORBFo9xCWsLHCuljk7ToA8TsS8+OfCgQERtMKvp52YlBvKAEXmJzpsLOd7pd7O431Lsk4yEKMvF8rv16JhS48s6ejq/+VGArjlq9WqZnDvV7i/z0Azey61M90F3WJQ17mi1j+nAGWPP/941vphPa1GGIKT4KSR5P6w5t7G4pn/5U+gItwMZxwptPm3/6BuV5ITwQsXCu0Ixx9Da4Jn2a2YrZWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g2Yzjge/p0tWN7wdJH/oMS1mkwIsQlhjyMxz148iZ2M=; b=kwEpkHABcReSeErJ9Eje3vt+imOWvEJDTH26q62oEG8zge+MT6pHK5b1cOneRF7S4hXW9ragcD9Pt5GxpAVcwN2gFD//k5XS+OnzD68Q+NzPWxsRR8vj4i1dTmycPcHuWhp9iKj5NvgraPTDGfvspTDrH2PCwe0BUNkqKEpd8PSJcXJP/3dcnls4S2Y7+mm6nZGFEt0R1rhojsnVefNWV0/KosJwU4/4KuZruT1shWHj69aFuvbYs8j3BHHdvyOFHVo9VUTbj6AmSVbCe3z3Ohoru5/oiQ75E6FQB3DQ1KgKxa+YSfQlSPv+YJm5hRox6Op4gKMb4jGgKCj/QYdxUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <825bb94c-a427-62ff-a790-39c0792553d3@suse.com> Date: Tue, 8 Aug 2023 08:05:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 2/5] mm: Factor out the pdx compression logic in ma/va converters Content-Language: en-US To: Alejandro Vallejo Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-3-alejandro.vallejo@cloud.com> <64d11b39.050a0220.2ab40.c2cc@mx.google.com> From: Jan Beulich In-Reply-To: <64d11b39.050a0220.2ab40.c2cc@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8303:EE_ X-MS-Office365-Filtering-Correlation-Id: c11a9028-d14a-41d4-c253-08db97d57e15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3wyQ+mO39wN94ENW42/74qpWHvwSTMyQB/RNfeBfwlr5zQva+6sUSEHNfa+v1ULI+i9s0gYvxvW56h917vo4Gqz2shET55uDyQTwTAGwSH6U2k5dwhReQgHdisCaVNvtkA8o5U3jBPhL3OjtJOktIgMg5Y7zAueMEs09RhnyzLo+L3c7pTb9SRiZHSy9WRTwvIlTNFrL2wF2zEtI5ubSYv3JaL/X+nwwAP9aQhoegxcAOKGOjXH6WBsc+bpVJu7C0+agOqm/RYnOOL5ILBQSXqT0oy4TbPyOSjz+t/Vkdd91tclw02uJDxK6FlnwajNy2Ln9lJMhm06IJWJekS5IrDFeazjeEq7IMsLAFqrBhWyb4IVQ/hAFkg6bDKfjMj8fSUKYYFcfsKizQ4Bm+MobJrHmf1FsW7+r+XHX1rFw+wy3vQv3UIX9KrY/CrDJKuOC2f+eZLWeDzuDQXx9GNU1n9sdASmHoCIlTd5elYw2yet85t2deS0biIrmyrT7O0Gfs+ano7Dr24t+SYLK/aedhMbzK6bqkZqUfO3M0Lrohi+fjKL7XwxB6hVKMYH1htRtaCk4HOFWHSZth2dNceCIuaKjiILxz7L5an7Jc7juccTHyOA/r9vha9/mdEBzRnsZWe5PPcAnSBUT3u5Tiqbr5wCOgOKKVTUjUBvOet+aLtQRKfU34sEKLRjZakYeY/rj95L3iG6dCEghDyV8e9L55Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(346002)(376002)(136003)(186006)(1800799003)(90011799007)(90021799007)(451199021)(31686004)(6666004)(2616005)(54906003)(2906002)(38100700002)(4326008)(5660300002)(8936002)(316002)(4744005)(6916009)(8676002)(7416002)(66946007)(66556008)(66476007)(86362001)(6512007)(478600001)(31696002)(6486002)(41300700001)(36756003)(6506007)(26005)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1hJNFNjdWoxM1Bld1VONmt5NGNJTFBIYUxXbk1BSXdCNU5nTDFwTEtwMDhX?= =?utf-8?B?OFM3U242bjEyY1gxQkIrZzhaUUFmQkorN3Exb3Y0VHh1RjdnNm9nSGNOWHlU?= =?utf-8?B?M04vcitpMTNteTNGbUpSWWNzMTJMM1RCSDVJNml2RFBnZElFK0xnY2dQbmhy?= =?utf-8?B?Uy9Cc3VSUUpDVnlOalJDczB4ZzdSVkdnclZ5VjBQVmR0d1FDZjBjRkI4Tko3?= =?utf-8?B?dmVYeFNsbEt3OVdoZ3BQdzVDU0VZUnFLcUozOG1zMzNCeHI3VUgxOFJlWnVW?= =?utf-8?B?c2pSTnFBWVozKzI4cXVsV215ZGNIMGduWlk4NlNXSTRrekNPYWlQS2JjUWxB?= =?utf-8?B?Y2dKOHk1aUovZHpZcjhPUUtWbk9iVzNObS9NdGFrVzZVSlV1MkUxQnk3Vjlv?= =?utf-8?B?ak5ZWmtPVXJvdjJ5VGZoVCt4OU84NjN2KzV1N2JNcC9ocXhOK1JTWUZxbkNs?= =?utf-8?B?eUxNM0kvKysrT2gvcHdLY0Z0b2tBV013djA2bFFsVEVzS01zZkw1QmVscDBF?= =?utf-8?B?OGdLd29iT1FHVmhVT0pkbGQrbnNSaDEvbXE5dkxWVmRlcHNEUUNRNUJmZDV1?= =?utf-8?B?U2pmbzJLWEFIb1poZ2FvWU12eUNYUWhJUTIrV3hGVGl2cXFRMDZBYldFZm5q?= =?utf-8?B?bFBpSXJ2MU4vTVF2VzB6UFJsTWl1akNxMkNrRDVhcGR6T3ZFbUxHV1ZlSlps?= =?utf-8?B?TXFoU01URmIwM1Q2SjE4WFdmVnI1SXA4RXM5TmNQd29EaWlNS3pMbVUxaFVR?= =?utf-8?B?bUxKMmVtd1grVWZNNWRZNERDVWNUcVYwVzI3NzV5UTNWblFFR3ZoZzJoRWQ2?= =?utf-8?B?WkdKMmtNRnAzZm8vOVJmSitzci9EUkxQSmxMVnZDYWp3LzBYNnJxYnB0cGd0?= =?utf-8?B?emhRTlU0WjE2Q1A1d2U4SytmOEdHUEdHeVVmL21DSlBBcUdRMTl1SE9mREJD?= =?utf-8?B?cVIzeTNTZlBrVjBCWVFEbk9yRFlGdExValFvaERKbWVGN1ZCc2hKOHc0T3NQ?= =?utf-8?B?ZmtZNHd3a2FvZHVCR3d5cWwyb2ZMdTk2NkdXazY3OFNDV3ZGTU1oaTNqWmhr?= =?utf-8?B?SmY4RnRGSFc3YnNYcWR6NFNjUlZpOElsNjBTS0dySXloOHNEWkg4RVAyR1hu?= =?utf-8?B?blhiMDl5RlUyVkdVZXAzdWFGTDhEdmpnc2tGcFJMWDJjaSs3YWlvN3RxQmpS?= =?utf-8?B?NTVXLzZPL0V4blpTeUU5TkIyNHVLMkE5bFBrcVp0OWN6M2pPeitQSXI3ektS?= =?utf-8?B?ZVdLVElPZ2FRT0FDQUFKdjYwM2dPYjVTZDNwODBWbm1CeXdkNGU5Vm5YRXdh?= =?utf-8?B?M0ZiYnFSMlljWnorM2lJWlFwd05UZ3VJSjBmdkZsTUpob3hLRFNtVjY5U1Jq?= =?utf-8?B?Z1I3MFdtM3FUS29KcXNOQzE4eVVKVGZQZ241NXFuWmludVlzaWdKRkY1alRn?= =?utf-8?B?aFowejZEUGZZNTF4SE1hZlBDNnZYTXYyM2lvUnFTdGhPS2p2b2hIYUVDOGN5?= =?utf-8?B?QnkweDJjeG5UNmpsUnZqVldyK2Q0RWhDaWFsVU1jVnIwVlhpMmtzUTR0ZDA3?= =?utf-8?B?Ym9ENGJFR29kd2t4SWRSbnNFUk9jYjNJZVdGNWp5OTNRWEx5S2hoNTBoWi9s?= =?utf-8?B?WXNPWDFxaHBmRmZ2UnNHd1NEV3o0NHY2aXVXR3pzVFZwMUJKajZhRkFCYlJP?= =?utf-8?B?dklPRHUrWmtkWjhHMHFxOE5mTmJDendVWXFpWkZFQ0UzMTIwMms0Nzg4dld1?= =?utf-8?B?NlBLUGt4ZDJ0NE0zZGhIQ2NwbzNuVEllZXRIS3lqMkZzOUpHNk9sZTl4eW5m?= =?utf-8?B?OHh0YlY1VnFWaTlYdmp4VGJTcUtDOS9raE1FTStNY2JKTnlWQ0tHaUFva3E0?= =?utf-8?B?WGVvL2tyQkZzUHc5TkFrUEhjK1pSbVoyTi9GcDF3QW9XZS9GcEhIUTdUOHF0?= =?utf-8?B?RXY1c1R4ZStWRWNjYytYZmxJdDlQaVZDMW14eUliODhQV1UxOTYyVHR3U0gz?= =?utf-8?B?Qzl2aTY5aTdOZDB5bW1IZ1JGYkZDZkZXOUJTZ01jeDNlRkVWWDRrandHUWlp?= =?utf-8?B?L09ZYlQxbXpTaFhjQ3dTV1R6TDgyRGZEWWNMV3dUc1poVFcyRmxCbTMwZ1Fj?= =?utf-8?Q?lDuEyRIvT/B+W1+vfRZScLvyg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c11a9028-d14a-41d4-c253-08db97d57e15 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 06:05:40.3690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KUKTJW/TLm6XFjI+nB4tcr9dps39yDgUQ+siT7ZyzOmvr+hYMJickeF06EmRKgK/uR6QavpvNGpIk2ACvsYVIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8303 On 07.08.2023 18:26, Alejandro Vallejo wrote: > On Mon, Jul 31, 2023 at 05:15:19PM +0200, Jan Beulich wrote: >> Especially since the names of the helper functions are longish, >> I'm afraid I'm not fully convinced of the transformation. > In what sense? If it's just naming style I'm happy to consider other names, > but taking compression logic out of non-pdx code is essential to removing > compiling it out. I understand that, but my dislike for long names of functions doing basic transformations remains. I'm afraid I have no good alternative suggestion, though, and while it's been a long time, this may also have been one reason why I didn't go with helpers back at the time. Plus of course I remain unconvinced that compiling out really is the better option compared to patching out, as was done by my series. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 06:17:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 06:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579262.907163 (Exim 4.92) (envelope-from ) id 1qTG1t-0005jA-1l; Tue, 08 Aug 2023 06:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579262.907163; Tue, 08 Aug 2023 06:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTG1s-0005j3-V1; Tue, 08 Aug 2023 06:17:16 +0000 Received: by outflank-mailman (input) for mailman id 579262; Tue, 08 Aug 2023 06:17:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTG1r-0005ix-OP for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 06:17:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20611.outbound.protection.outlook.com [2a01:111:f400:7e1a::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 375ab3a3-35b3-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 08:17:14 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7858.eurprd04.prod.outlook.com (2603:10a6:20b:237::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 06:17:11 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 06:17:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 375ab3a3-35b3-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ip19fuEGKZ8hRXwRXWtUsmloZB2qXC+ou8kbZaZj3u4OjaKIzrWUXmz2wuHRPeaNH7pbnVr3JOKpnYH8vyPocR2tz9pelhPnyKHC/zKQ50Pp8mj6co6OTznD3yul5xEOOiYL/OVb2FKgh9N8CQfDCKZaKUYx/ii+DQXdyZMtF4mHWwGXT4cYEpLpBQ4Mf2lJilc+pCCnmyfCGmo1Aw5j1Ejx118qFQjLWq/4F+en52C3Pv53JHxWAYiESiOkrTw46SP305jAhmkQhM0v1sll3+GbOPUP4o7Yn4ShRD2C2vhf0jtKp9cZPvCWH3E9dllrZBS+K6V1sZIZgphu7l8X0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DLRrvUKXB/O7RFFHnmwCd+qmJOIipN2/PdpFVANAkR4=; b=UGFGanwCMymYUf+kXwqzMuzRpUkAQyzJMckcjMpnOubk2oVo0L56vMKqhYgeTeWBLIj7Sw4hhHtXfFR9IR2o60Un/ErAvKLmIdd3IdCWUVM9YxksEsZ9g3p2xq9L/XPvrYqGNYzKDgvpzpLjF1LgdkTHzs9Cgy1pyLknltSna2O+7fF/u/m/H0RJfq6Cum2Ka9+U7bjVMpGaa9ILXAwnS9OULNPLbmiKhlHN2KNoxVcO4+DfruYMXbURF0zFUFvyI/VJup0bmVucDadUxFY71XbAmq0nrB2FqM/BV8PrpTaH680wzxKLSf2ZKne8/cnB4+xDZWCqZyOV7eVDtU/q4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLRrvUKXB/O7RFFHnmwCd+qmJOIipN2/PdpFVANAkR4=; b=TuCjCGH39nHddx8Z7MZ1J1SMBDFm+Ur7Es5R8NFF3hd7pzrbAwKKFbgldv4Ylk0qgnczOLDdUrAYKpExFQB0LuGv8FXrJ/xMNcuM49KlY9UUGFb3l0eyeRYYQc1yyXRebOJZr3n/ZBsFT2Xp0zodxs8qB5/bES8cRE7ktNgr5ruEJwcxkjfiwn7KuY6N/TYBtOkldAlVHOp0bFAIc9SjhJzkYokUrXTVj6ULQNe+5yiXfwX47qsMA0tNyf1bNxaLPMbbyYS+OGe3tmmlusL8NWzl2skMHheT7t3Os0StEUwkXQ/aCZCio+zZBZOxAETmUUau1Y8DWs+s1CXCfsyBeA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <02de9a1f-87d2-1a7c-a475-a83a6ce998cf@suse.com> Date: Tue, 8 Aug 2023 08:17:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option Content-Language: en-US To: Alejandro Vallejo Cc: Andrew Cooper , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-6-alejandro.vallejo@cloud.com> <9f0b7ab4-090f-21ea-2cf8-6ecdc7c02225@citrix.com> <3470bc26-3cbc-e0de-53ae-203449493b51@citrix.com> <06a3f79e-4345-7a4b-be57-728a8b01befd@suse.com> <67b5c363-a653-3f5c-ea3a-f52bfac3dc49@citrix.com> <75a70fa0-ab40-e2b0-685d-db752c943a7d@suse.com> <64d11674.7b0a0220.ec9d0.7073@mx.google.com> From: Jan Beulich In-Reply-To: <64d11674.7b0a0220.ec9d0.7073@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7858:EE_ X-MS-Office365-Filtering-Correlation-Id: fab78cda-7570-47c0-8891-08db97d719de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yk6sYKl0S52BQpjnX/h8bBakIRMvj8wWIsmI5pFVAibvzhUdLyM7Cjaj6GF5kv7wQUsNgXsDdlk0T4NtmhI1ny11ctfkxBR9693FOcUGArQnegczwrScUisMsACI3e9Ce+kA+rxHssElyEVvOTg/m5INQWfaQUkEPzMLv/Iq2C+yN73IUzNy/PabMhsK242/pVLM3e5dzheyh5MDp/b9JL53k7KWFQdNcCZcv85GniaIiy2Nl8gJ0QhbJZwIatMy/OkX8/jKXh+b8T4Q+rLFXh/8oM/AxBqctWFClMoXxjHrJXOac2OhvJ+rRQVGhOiJbieXCZfG1xH8hSonMbOAv8CZsqe6UYhyxu6mhl+nJZw+cbZm+9ES8Zs4OFzdmfGCbhBmBg5o9Ssop6ul0cZa0XXhvxM5EKEPlb7zBTtV2kpcpXg+K8Z/+oc3ClDMoAeG47DnHfYOzPBVoDHiq3TfD9Cw/nWuB1ThWMH9LEv/wi04RK2A+mSxcsJvhElsB67PJmlhCpb0/6V7B6W6NlTex4gz9lPZBwHHOZL9s0OjJb1gkV0yIbzsGYOEk/fDiO/NKrDNBAdLY5dm/NXA1e3YXL/inmbam9hKBws3DCVvH1OK6sYwvBeYDmT19l3KNmNDWBdVF6aBQYmrzUYvsZ2WdxR7dU+ycs7J9Q/HknG5YheNLWMtFoDPk6SNMsWq+Er3ep4SlN4LsA07JQ/5Uoeh0A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(376002)(39860400002)(136003)(396003)(90011799007)(1800799003)(186006)(90021799007)(451199021)(38100700002)(54906003)(478600001)(6666004)(6486002)(6512007)(6916009)(41300700001)(316002)(5660300002)(8676002)(66946007)(66556008)(66476007)(8936002)(4326008)(83380400001)(2616005)(53546011)(26005)(6506007)(86362001)(31696002)(36756003)(7416002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckx0OHlQWUVFdFZPQzBWejExVVlsU1ZUNEkvcG5HQW82MTBkQXFUTHpubDVX?= =?utf-8?B?NnpWYzUzQ1FiU2s5bnc5NzZOQXlzeU1XVWV0enhyMGwvNFV6dWdjcCtSaFV2?= =?utf-8?B?OFdnTHBndnZUNlduVytwZkhtaG5SUEF2STc2bnorUkZkUVRPQVBUVmlOT2M5?= =?utf-8?B?UTQ0cEY0MFo4ZnhnWFhwUjRYSXcvekI1SnF2TTRlWUNUTnZpMmJ4U0xiSjBx?= =?utf-8?B?cFBOcGZKWitBc0FiQjVkK3JoU2FyVUtqYjNnL2ordC9xMUI3UDgwMVhjOWJh?= =?utf-8?B?R244a1VSTStmNHFqZHlhV0ZkakhORUxod1dvditJUldPd3Rpa012SFViUEZ0?= =?utf-8?B?bEpUUE5QcTBhR1lPK2lxVmtzcHRaelVUWElyaVpXU21IbHlGb0hRTmY4ZlJm?= =?utf-8?B?Z3hXQy9EcXhwdTdNN0RDNXN4YUhzU2hyVlRTT3RTWWNjL0VxeTVmQXNBNHk3?= =?utf-8?B?RGNORlBwZzBCZTlId3JGODlka0dwUmhLY0RyL0tlU3BycnA2RjJqOEEweTlq?= =?utf-8?B?c3IxVUNrOUV4Y0J3R29UYjFsWEtGQi8zSnlJaGtBMTJYdU9BSXZxN3EwNUMw?= =?utf-8?B?WGdsaUtXWEp1aUpscUFjUTBJSXhIclVGblRPVjkwcjB3dmN4UGp6bzB2SVJF?= =?utf-8?B?T3F2LzVKOGNYNkprSWFPVG5TbnQvYjVMUnNqUHdRWDEzb29TQkg2M09qSnFT?= =?utf-8?B?cVh5VHZ6V1N4UmM3R2x4dnZVMElzVW56cFc0Zmp4MzBtK0lZRFFhT3c4NlpV?= =?utf-8?B?MUp4N1pKNXdRdHI5aGorcnkySVA3S0JXL3l1ZDZiRE5oT3NZWGZXUUsyZWZW?= =?utf-8?B?d09HRGh5L1Ard01ucmtOY1VSOFozMmcrY054Q0dOZldQZlBWb0xpc1R5OERs?= =?utf-8?B?M0duSWxoeWVMQWQxT1dNSnVzSld5SHpWalpuYXg2MTVLdndmVStMeDZ4U2xL?= =?utf-8?B?SHhhdE0vMVY2YVE1Y1ZMWnltZkhUWE56Y2hNcmlRZDRQTWFtWXFoa0hMNHdn?= =?utf-8?B?Y2JsNFFaZDMzUXpzT2tEWDZ2SWM1L1dYYmxSMHhmWXpwQVlTK21YZGxjNHR2?= =?utf-8?B?czMzWFArRHhvZ3Y3YnRnalNkNk5TV0Fzdkg4L1NaOEkrOSt5emIxS0ltNWR2?= =?utf-8?B?KzYwSVRBVGNod25uZXZac1FDU1BJbUdCcUE2N2ZUU2M4ZXIzRlFvSThHOVht?= =?utf-8?B?NThXQjluUUtmWHJxb291anhHRFRlZlpidUU2bDlrdmkwVHBUYnlTd1VGTkFU?= =?utf-8?B?dzludjE2cnlQTkxxbUNLTWo0MzZ1YUxrYVg3NnpqdlprS0tmaW9qSGdUVHpB?= =?utf-8?B?TGF4RkEzTmpnSmdUbTkwU1ZodWsvYTdhakdtbVREZEVUd3lTQ0d1NGI3cjhJ?= =?utf-8?B?NWxGUnFCZ1lDbkJWaXpXcjI2UHU5R1VKNzVBTXdMbmxLbFFjWWRzL2Y2WFAz?= =?utf-8?B?S01ZbExiVWg1S2Z2cFFyREI2VzRZci90SG1YMjlZNU1rZUtpVWU0bnpsVVlq?= =?utf-8?B?Tyt3NGpic2tITG5VTDROZG5Rc29wS0xCdDIzQVQxZUhGWm5neGh6Yk5FMUtZ?= =?utf-8?B?RlZTRUVudlZwbG1BbEhyQkRBOE9jZXUvZlVjV0NhMHpvWWg1UnF5a3pNRDBT?= =?utf-8?B?SCs2NHVPdGxBbXpXTHdDWktiODRDOTlLSCs4cWhIVjNiL3Y4cWxyeDJGZWtC?= =?utf-8?B?S2tucEM0Sk1aN3FtSno0UTFDcStXVTJSYktIYzJtNm5Idk0rNWNxYXk4YkFl?= =?utf-8?B?V3RrcmZsdlNaV1lhWDl5ZXNjYy8wTUpPcURaTFU4ZXVHUDZSUWFreW5YMWhG?= =?utf-8?B?Mk0veUVXMlcyVnJaSEwzeE8yMDFEK0Eva3VhSU9sUExhSjduMzVPVmllSzZD?= =?utf-8?B?eG44cnA5anpQRzlaUW9pTUYySUNEQVJWWlM0NFErektZdGgzYjZwLzRtQ0xw?= =?utf-8?B?c25VenFKRVk3Qko0ZVR6eEJ0bWduTVBYNnlVVGJ5b3Q2TEdURFdyUzI3ell6?= =?utf-8?B?OUR1enRMYUttaUNaZmJNV3plbWNwQmNiZ0hYdXlmeENadDRwRlVvZW1udlVQ?= =?utf-8?B?U0crVUwvbUZCZXQycUxvUmxzN3Y2U2Frd0hZcUErME10c2tER09SelJ6Y3U2?= =?utf-8?Q?EaYXOsWvS+M0d7Hik8R1DQISU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fab78cda-7570-47c0-8891-08db97d719de X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 06:17:11.2276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jt/G6c1r4aG0m25LFcXny73/J92BKz0Xhr8P6wAUH5Tj5HSTSw9EnnxXVxlzl76ZKysBHcIMVrchhFjD0ZOqkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7858 On 07.08.2023 18:06, Alejandro Vallejo wrote: > An alt-patching series can probably make it very close to the perf win of > this patch as long as it transforms the conversion hunks into no-ops when > there's no hole. I looked into the 2018 patch, and I don't think it tried > to go that far (afaics it's purpose is to inline the compression parameters > into the code stream). I highly suspect it would still noticiably > underperform compared to this one, but I admit it's guesswork and I'd be > happy to be proven wrong through benchmarks. The alt-patching certainly will have some residual overhead; if for nothing else then for the long clobber lists in some of the alternatives. > Summary: > * While alt-patching is an attractive alternative this series doesn't do > that and in the spirit of keeping things simple I'd really rather keep > it that way. Does this sound reasonable? > * For the topic of when to disable compression by default on x86, I > genuinely think now's as good a time as any. If we were to do it in 2 > steps any project downstream may very well not notice until 2 releases > down the line, at which point they simply must turn compression back > on, which is what they would have to do now anyway. > * For the topic of allowing or not the option to be selectable, I think > it would be a mistake to preclude it because while we don't know of > physical memory maps with big holes on (publicly available) x86, Xen > may be itself virtualized with arbitrary memory maps. Unlikely and far > fetched as it is, it's IMO worth being at least cautious about. Gating > the feature on EXPERT=y and adding a big warning should be good enough > to avoid foot-shootouts. I could live with this as a compromise; really my main objection is to not allowing the functionality at all on x86. Beyond that I'm obviously not overly happy with how things are moving here, but so be it. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 06:33:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 06:33:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579268.907172 (Exim 4.92) (envelope-from ) id 1qTGHQ-0008Ay-AQ; Tue, 08 Aug 2023 06:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579268.907172; Tue, 08 Aug 2023 06:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGHQ-0008Ar-7Y; Tue, 08 Aug 2023 06:33:20 +0000 Received: by outflank-mailman (input) for mailman id 579268; Tue, 08 Aug 2023 06:33:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGHO-0008Al-0C for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 06:33:18 +0000 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [2607:f8b0:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72ca329d-35b5-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 08:33:13 +0200 (CEST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6873f64a290so1465073b3a.0 for ; Mon, 07 Aug 2023 23:33:13 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id ff12-20020a056a002f4c00b0067f2f7eccdcsm7204570pfb.193.2023.08.07.23.32.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 23:33:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72ca329d-35b5-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691476392; x=1692081192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m1STCrinczuq8FuoUgLs8N4vldOealvmees85dm6MPY=; b=DHsGX8t2DlnQTZ3P5OI9n7d2eKbW76xN4tTGVVJSGRA1IM8FeS8yeKRc7hPuylIUq6 Vn6fFj0Cv1x6zxvq6HdiZeD3sss54GzeWb8hF97LFXrHomN7WJ9YcJ4yAlUPs8k8HgNL jvDOSB+a6LFcWjcXHBVF7wtFqF14I5u1bMgCHhYO6BYyHXF5r6kcqyvIScTKejNj9azo Dlxz0pBdKdmaGIcMiIhQ+2FswwrIXK2CIvDeChsrdQ0sCkYtUwWfiT2WKOfkpBIAGKTy jKW26xAUSVtB349qP1v3gjKBFhibzKHRUcGcdDNMBlsrboMdDTLiQvbJMlgqGN2hazF3 /EiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691476392; x=1692081192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m1STCrinczuq8FuoUgLs8N4vldOealvmees85dm6MPY=; b=H1jYq2PhU+e6C5LxQXIUHGgvSdLt2DyHxZ8wOP8yAvSK9xHup7Ujc8CKlAKddif76q uMlhUnW/ovJ6546XyDfulCxoUOHZ7su/2Z2z3wdckZLfROwgxjSb0H80FqHqBNNvnK/w lFxZTOEKeDj/mGVJ2n2L+9PcaPLmhjDlyEAE9GSK1JzGME7sXfOW1ebGhgbB+eK1nhNX id3FfrS5AI4diZVMGkoOUMOu37Llxt+DFFAGFSTYdSz6AIknRGLbiE0tealMAPJbnVdj AucSR5Z4RpUyUdC6m+Q3aJX3n4zQWalyRjTWHp0HmtMu9P/cDxpCP+Wdp83oVL+DfEHE eeOQ== X-Gm-Message-State: ABy/qLYHS2sZQ5eHT8ktvjxXEHFWHRXEh8TAHK4O1mm3NrVe8ROr2Hpg Nn1zdyn5aN3hSPaMdH3JC+w4Cg== X-Google-Smtp-Source: APBJJlEAHd7r+M3vyCUQDMAxEjMveuzSqb/Q6wUuSUNAB0Ns9zs1qKL/YECIY4J9DtcJjA3HpA/s7A== X-Received: by 2002:a05:6a21:998c:b0:13d:1ebf:5dfc with SMTP id ve12-20020a056a21998c00b0013d1ebf5dfcmr38062815pzb.5.1691476391828; Mon, 07 Aug 2023 23:33:11 -0700 (PDT) Message-ID: <0e7b16ce-19f9-0c70-4a94-f05cbfee613a@bytedance.com> Date: Tue, 8 Aug 2023 14:32:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 44/48] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} To: Dave Chinner Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-45-zhengqi.arch@bytedance.com> Content-Language: en-US From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Dave, On 2023/8/8 10:12, Dave Chinner wrote: > On Mon, Aug 07, 2023 at 07:09:32PM +0800, Qi Zheng wrote: >> Currently, we maintain two linear arrays per node per memcg, which are >> shrinker_info::map and shrinker_info::nr_deferred. And we need to resize >> them when the shrinker_nr_max is exceeded, that is, allocate a new array, >> and then copy the old array to the new array, and finally free the old >> array by RCU. >> >> For shrinker_info::map, we do set_bit() under the RCU lock, so we may set >> the value into the old map which is about to be freed. This may cause the >> value set to be lost. The current solution is not to copy the old map when >> resizing, but to set all the corresponding bits in the new map to 1. This >> solves the data loss problem, but bring the overhead of more pointless >> loops while doing memcg slab shrink. >> >> For shrinker_info::nr_deferred, we will only modify it under the read lock >> of shrinker_rwsem, so it will not run concurrently with the resizing. But >> after we make memcg slab shrink lockless, there will be the same data loss >> problem as shrinker_info::map, and we can't work around it like the map. >> >> For such resizable arrays, the most straightforward idea is to change it >> to xarray, like we did for list_lru [1]. We need to do xa_store() in the >> list_lru_add()-->set_shrinker_bit(), but this will cause memory >> allocation, and the list_lru_add() doesn't accept failure. A possible >> solution is to pre-allocate, but the location of pre-allocation is not >> well determined. > > So you implemented a two level array that preallocates leaf > nodes to work around it? It's remarkable complex for what it does, Yes, here I have implemented a two level array like the following: +---------------+--------+--------+-----+ | shrinker_info | unit 0 | unit 1 | ... | (secondary array) +---------------+--------+--------+-----+ ^ | +---------------+-----+ | nr_deferred[] | map | (leaf array) +---------------+-----+ (shrinker_info_unit) The leaf array is never freed unless the memcg is destroyed. The secondary array will be resized every time the shrinker id exceeds shrinker_nr_max. > I can't help but think a radix tree using a special holder for > nr_deferred values of zero would end up being simpler... I tried. If the shrinker uses list_lru, then we can preallocate xa node where list_lru_one is pre-allocated. But for other types of shrinkers, the location of pre-allocation is not easy to determine (Such as deferred_split_shrinker). And we can't force all memcg aware shrinkers to use list_lru, so I gave up using xarray and implemented the above two-level array. > >> Therefore, this commit chooses to introduce a secondary array for >> shrinker_info::{map, nr_deferred}, so that we only need to copy this >> secondary array every time the size is resized. Then even if we get the >> old secondary array under the RCU lock, the found map and nr_deferred are >> also true, so no data is lost. > > I don't understand what you are trying to describe here. If we get > the old array, then don't we get either a stale nr_deferred value, > or the update we do gets lost because the next shrinker lookup will > find the new array and os the deferred value stored to the old one > is never seen again? As shown above, the leaf array will not be freed when shrinker_info is expanded, so the shrinker_info_unit can be indexed from both the old and the new shrinker_info->unit[x]. So the updated nr_deferred and map will not be lost. > >> >> [1]. https://lore.kernel.org/all/20220228122126.37293-13-songmuchun@bytedance.com/ >> >> Signed-off-by: Qi Zheng >> Reviewed-by: Muchun Song >> --- > ..... >> diff --git a/mm/shrinker.c b/mm/shrinker.c >> index a27779ed3798..1911c06b8af5 100644 >> --- a/mm/shrinker.c >> +++ b/mm/shrinker.c >> @@ -12,15 +12,50 @@ DECLARE_RWSEM(shrinker_rwsem); >> #ifdef CONFIG_MEMCG >> static int shrinker_nr_max; >> >> -/* The shrinker_info is expanded in a batch of BITS_PER_LONG */ >> -static inline int shrinker_map_size(int nr_items) >> +static inline int shrinker_unit_size(int nr_items) >> { >> - return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); >> + return (DIV_ROUND_UP(nr_items, SHRINKER_UNIT_BITS) * sizeof(struct shrinker_info_unit *)); >> } >> >> -static inline int shrinker_defer_size(int nr_items) >> +static inline void shrinker_unit_free(struct shrinker_info *info, int start) >> { >> - return (round_up(nr_items, BITS_PER_LONG) * sizeof(atomic_long_t)); >> + struct shrinker_info_unit **unit; >> + int nr, i; >> + >> + if (!info) >> + return; >> + >> + unit = info->unit; >> + nr = DIV_ROUND_UP(info->map_nr_max, SHRINKER_UNIT_BITS); >> + >> + for (i = start; i < nr; i++) { >> + if (!unit[i]) >> + break; >> + >> + kvfree(unit[i]); >> + unit[i] = NULL; >> + } >> +} >> + >> +static inline int shrinker_unit_alloc(struct shrinker_info *new, >> + struct shrinker_info *old, int nid) >> +{ >> + struct shrinker_info_unit *unit; >> + int nr = DIV_ROUND_UP(new->map_nr_max, SHRINKER_UNIT_BITS); >> + int start = old ? DIV_ROUND_UP(old->map_nr_max, SHRINKER_UNIT_BITS) : 0; >> + int i; >> + >> + for (i = start; i < nr; i++) { >> + unit = kvzalloc_node(sizeof(*unit), GFP_KERNEL, nid); > > A unit is 576 bytes. Why is this using kvzalloc_node()? Ah, will use kzalloc_node() in the next version. > >> + if (!unit) { >> + shrinker_unit_free(new, start); >> + return -ENOMEM; >> + } >> + >> + new->unit[i] = unit; >> + } >> + >> + return 0; >> } >> >> void free_shrinker_info(struct mem_cgroup *memcg) >> @@ -32,6 +67,7 @@ void free_shrinker_info(struct mem_cgroup *memcg) >> for_each_node(nid) { >> pn = memcg->nodeinfo[nid]; >> info = rcu_dereference_protected(pn->shrinker_info, true); >> + shrinker_unit_free(info, 0); >> kvfree(info); >> rcu_assign_pointer(pn->shrinker_info, NULL); >> } > > Why is this safe? The info and maps are looked up by RCU, so why is > freeing them without a RCU grace period expiring safe? The free_shrinker_info() will be called in alloc_shrinker_info() and mem_cgroup_css_free(). In alloc_shrinker_info(), it will only be called in the error path, so shrinker_info_unit and shrinker_info can be safely freed. In mem_cgroup_css_free(), when we get here, the traversal of this memcg has ended and will not be found again. That is to say, the corresponding shrink_slab() is also over, so shrinker_info_unit and shrinker_info can also be safely freed here. > > Yes, it was safe to do this when it was all under a semaphore, but > now the lookup and use is under RCU, so this freeing isn't > serialised against lookups anymore... > > >> @@ -40,28 +76,27 @@ void free_shrinker_info(struct mem_cgroup *memcg) >> int alloc_shrinker_info(struct mem_cgroup *memcg) >> { >> struct shrinker_info *info; >> - int nid, size, ret = 0; >> - int map_size, defer_size = 0; >> + int nid, ret = 0; >> + int array_size = 0; >> >> down_write(&shrinker_rwsem); >> - map_size = shrinker_map_size(shrinker_nr_max); >> - defer_size = shrinker_defer_size(shrinker_nr_max); >> - size = map_size + defer_size; >> + array_size = shrinker_unit_size(shrinker_nr_max); >> for_each_node(nid) { >> - info = kvzalloc_node(sizeof(*info) + size, GFP_KERNEL, nid); >> - if (!info) { >> - free_shrinker_info(memcg); >> - ret = -ENOMEM; >> - break; >> - } >> - info->nr_deferred = (atomic_long_t *)(info + 1); >> - info->map = (void *)info->nr_deferred + defer_size; >> + info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); >> + if (!info) >> + goto err; >> info->map_nr_max = shrinker_nr_max; >> + if (shrinker_unit_alloc(info, NULL, nid)) >> + goto err; > > That's going to now do a lot of small memory allocation when we have > lots of shrinkers active.... > >> @@ -150,17 +175,34 @@ static int expand_shrinker_info(int new_id) >> return ret; >> } >> >> +static inline int shriner_id_to_index(int shrinker_id) > > shrinker_id_to_index Will fix. > >> +{ >> + return shrinker_id / SHRINKER_UNIT_BITS; >> +} >> + >> +static inline int shriner_id_to_offset(int shrinker_id) > > shrinker_id_to_offset Will fix. > >> +{ >> + return shrinker_id % SHRINKER_UNIT_BITS; >> +} > > .... >> @@ -209,26 +251,31 @@ static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, >> struct mem_cgroup *memcg) >> { >> struct shrinker_info *info; >> + struct shrinker_info_unit *unit; >> >> info = shrinker_info_protected(memcg, nid); >> - return atomic_long_xchg(&info->nr_deferred[shrinker->id], 0); >> + unit = info->unit[shriner_id_to_index(shrinker->id)]; >> + return atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); >> } >> >> static long add_nr_deferred_memcg(long nr, int nid, struct shrinker *shrinker, >> struct mem_cgroup *memcg) >> { >> struct shrinker_info *info; >> + struct shrinker_info_unit *unit; >> >> info = shrinker_info_protected(memcg, nid); >> - return atomic_long_add_return(nr, &info->nr_deferred[shrinker->id]); >> + unit = info->unit[shriner_id_to_index(shrinker->id)]; >> + return atomic_long_add_return(nr, &unit->nr_deferred[shriner_id_to_offset(shrinker->id)]); >> } >> >> void reparent_shrinker_deferred(struct mem_cgroup *memcg) >> { >> - int i, nid; >> + int nid, index, offset; >> long nr; >> struct mem_cgroup *parent; >> struct shrinker_info *child_info, *parent_info; >> + struct shrinker_info_unit *child_unit, *parent_unit; >> >> parent = parent_mem_cgroup(memcg); >> if (!parent) >> @@ -239,9 +286,13 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg) >> for_each_node(nid) { >> child_info = shrinker_info_protected(memcg, nid); >> parent_info = shrinker_info_protected(parent, nid); >> - for (i = 0; i < child_info->map_nr_max; i++) { >> - nr = atomic_long_read(&child_info->nr_deferred[i]); >> - atomic_long_add(nr, &parent_info->nr_deferred[i]); >> + for (index = 0; index < shriner_id_to_index(child_info->map_nr_max); index++) { >> + child_unit = child_info->unit[index]; >> + parent_unit = parent_info->unit[index]; >> + for (offset = 0; offset < SHRINKER_UNIT_BITS; offset++) { >> + nr = atomic_long_read(&child_unit->nr_deferred[offset]); >> + atomic_long_add(nr, &parent_unit->nr_deferred[offset]); >> + } >> } >> } >> up_read(&shrinker_rwsem); >> @@ -407,7 +458,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, >> { >> struct shrinker_info *info; >> unsigned long ret, freed = 0; >> - int i; >> + int offset, index = 0; >> >> if (!mem_cgroup_online(memcg)) >> return 0; >> @@ -419,56 +470,63 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, >> if (unlikely(!info)) >> goto unlock; >> >> - for_each_set_bit(i, info->map, info->map_nr_max) { >> - struct shrink_control sc = { >> - .gfp_mask = gfp_mask, >> - .nid = nid, >> - .memcg = memcg, >> - }; >> - struct shrinker *shrinker; >> + for (; index < shriner_id_to_index(info->map_nr_max); index++) { >> + struct shrinker_info_unit *unit; > > This adds another layer of indent to shrink_slab_memcg(). Please > factor it first so that the code ends up being readable. Doing that > first as a separate patch will also make the actual algorithm > changes in this patch be much more obvious - this huge hunk of > diff is pretty much impossible to review... OK, I will send this patch together with PATCH v4 01/02/03/43 as a single cleanup patchset. Thanks, Qi > > -Dave. From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:05:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579274.907182 (Exim 4.92) (envelope-from ) id 1qTGmR-0003Iy-NC; Tue, 08 Aug 2023 07:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579274.907182; Tue, 08 Aug 2023 07:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGmR-0003Ir-KJ; Tue, 08 Aug 2023 07:05:23 +0000 Received: by outflank-mailman (input) for mailman id 579274; Tue, 08 Aug 2023 07:05:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGmQ-0003Il-Kg for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:05:22 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on060f.outbound.protection.outlook.com [2a01:111:f400:fe0c::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efefc292-35b9-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 09:05:20 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7757.eurprd04.prod.outlook.com (2603:10a6:102:b8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 07:05:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 07:05:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efefc292-35b9-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g2/2rqgPHzgsYrFEseDYCrYLX61k61eehvBvsCnsvNZ58LxMGQAIjy5LVLsf8ehStI5D+tDYXz0GXxsVgFRBxYM1DXh0JvxpBhPUbcEBAmZp9OBD7S13ZM03ChIwnqNWOCycnHCRKtvdJUd7DmU1IKWAm8SmgR3JL8mmuwQTwkO39xjnf0bofkSw/T8v5R6kS2lqQ/mmtES1gpQPcQYchRX8Ti8x08B4yWekpRl6dq/FqnDwWbpmy8jq9SZyPz4tzT0zDktoYSQxib1CVG4LxD8AeOhyB2aw0G7Q9vanHB9JJkhEY/Zp9fhQKpGhwFUCRxden0se7QSVkdTfY0JFVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TkJ3g32OqlIHjrdAMHwXrRmn+rgF3dKMx4rDtU8a/k4=; b=EQSmMQPbE3kp+FqY4X0CBVOmDFnNTPUMvCrEqRwveKtSjon/r3ZzLZ5EwHLdQrdg/SJNZMwKXbam4D3fOkjhaRMvLmSJz4d+GBgjBQtfZKfZy5bjUn7dgtm6RsyJStQv1vzG+iHEMs52nqHh5TlQFKdlRRIgUiZkBWAp/UwuKjlA6X8qgSw4a+JFoh3RkxsYqFrz7QWvIphQDvhPvqQ3c2h6r64FCNvdTa/nslPger72tqaUxg9cIAA1QF95qEzpDwT9fSKb44iW0TSGbf7a8HmXNgdg98HEf7iHzx0KvSkDRXrjj6nCPEb1jY/Y1NNzxt5ynxSSW77GtBOg+Xcrow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkJ3g32OqlIHjrdAMHwXrRmn+rgF3dKMx4rDtU8a/k4=; b=zzx+EarkrvP2pWYK/Ya/u0nuNCc9VnxQwJS5ymlRP8IKKDnqXc11A2Q2u0W+MAlskgmGseDx/2lwhIHvBLwy1973qGtGvgFDQGf3HdhJxT0j5jPesh95snHtzUhki7ZnRuxRuD2pT0Uh1ZalhZE2zJe10Uha6Vl75IglPUbrQNxXSo45TIc4KyMSU/14diAaAWdWITsMhte5QT3+ygn1qeAb4J6fhaC3kLeKeTs/AcUx73OW/5QwEDdj3XEwfvmTLHKxSr4YmJS6KMXetO0bjBYKjjxkREyNejnI0l7HXQV70Ay9zNO1KWXEwEUZJ2n3/cXXRxxXMveOz/3ekSJ+3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5fd0359b-fcbb-3073-6fb1-bc462eceb295@suse.com> Date: Tue, 8 Aug 2023 09:05:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v8 04/15] xen/sysctl: Nest cpufreq scaling options Content-Language: en-US To: Wei Liu , Anthony PERARD Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Jason Andryuk , xen-devel@lists.xenproject.org, Juergen Gross References: <20230807185119.98333-1-jandryuk@gmail.com> <20230807185119.98333-5-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20230807185119.98333-5-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7757:EE_ X-MS-Office365-Filtering-Correlation-Id: 677bec7a-cf78-4126-75ec-08db97ddd287 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MC7gxlXMiApdw8ksmk2TDBGRsuq6t3N0dLLXLhSF40tCDatdIeTkKiPD5wSD5N/JduhmZscIOWJjvivcOc5NoL8KY65ZKXgA8EQK8uPmvWlGXGDst3j5k0b4gItgcocnUztKeeN+IfrkCi1MSmrwTKbBosEz9gzV8cbWTALUclHloeXqhZ45PTAFETRfibbrpKu819vS+GL7+8MLp8+b62aLR/IpFHdF9qrAyFWPbYo8/k9lTlbpZjaabJifyoZ0I+IgVRG9wUQx+xfkpzrBs2v0wKrLkvq3vuYhEYqex77y2AzzDCjNxg+HbYTF3A6L5fUE3XnCIF5VPWL+Un2VOZOkiiVye54HbHozFN6wAvlfWPJw961dLVbuPirw/tVOEeBMuZfIqoaFwli4RHGN3dX4otWNmAaHzpbSImBfBO01kiAlFJza89jaPSUjE8LtYGXieC8Tx7ArlXm9cgZ7UFtNQfavtZBo2nJdYmD74lYumgrcyZiN+fzeMBgqkBZq2eBoVyI4dJmBEsOpKAniyyMIn3rULdo6RDJZ2OShXy4Iiy4LHykKPV2huLrGSJr18TPKdibU4rNm87vrlPt2f3W2u2hyrhqtkQ4Smn2jNomy7cdOIsrMdbuOee4jq9jSRiWpCDqC7N5doak8VzdCAllpn+4bVfZSX5VyqJdPydthOF2OvoA9qefTwLXVOeXrIQ+HyzkC6vsgGiXfqnf/nQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199021)(186006)(1800799003)(90011799007)(90021799007)(31686004)(316002)(83380400001)(107886003)(2616005)(2906002)(36756003)(8936002)(8676002)(26005)(53546011)(38100700002)(6666004)(6486002)(5660300002)(66476007)(66556008)(66946007)(41300700001)(4326008)(6506007)(478600001)(31696002)(54906003)(110136005)(86362001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3haVDN0alU0Mk9LSTU0Qm8xRjBNRHdlanA4anh1THg1eU5POGx1VHpFampu?= =?utf-8?B?UzhqMWtHYTMvT1hGVFFYSDcxY0Jyc055bnIrVXBrcGp2WGtlQjZaMXBLa1F1?= =?utf-8?B?VzZOcGd6U25qeGNnQ2U0QXQxbkpCRHY5VE52R1o2R3hvclFYOEdMVDB6UVdU?= =?utf-8?B?b0YwWWZzMVhrNkxtY1VmZnJWVXJiNlRkejlUM3dLOTBibFl0WHdUd0xveDdT?= =?utf-8?B?Y0w0aTNLV25vSW5MQVpNNUJMUEhlU29MbGxnMnNSajVCQlNLNnZOdVp3dWJ6?= =?utf-8?B?MXhQbGZHbTJWSDhiempEeUVBWUhqTzlzRTVoNURMSHN0TkY5TUNEWDBrL2x2?= =?utf-8?B?Zm5SZGx4dUkzU21QY2FXWkgreldMcTlJTEhvaE51YjVrQ25GSXRWM1QvSHU1?= =?utf-8?B?US9wVjdTUU1FM3BwcXRWcTczODJOa0NGbDlFRTE0ZlppZkVJc0hxQ04rODNT?= =?utf-8?B?TEltMFFUMTNtV0VVUXg3ZFBpQ1BqSlRTNWVNS0orUGo0V0R1T2lPUGh5T3FE?= =?utf-8?B?a3hhOVFyWm5KYTNaVU9rTkg1bEhETi84YUZzZEliK0JRZGxyWGFjM1FqMWxO?= =?utf-8?B?ZzREMDJDVWJUV2NhZGlQSkpMeGtpRnlUYTZod2l6c1JyNitpWFdLQlBLaVpZ?= =?utf-8?B?ZWw4a1dMQkZCUTB1NGdaY1hpQ3diSU9pZHgybGlNL0pXSkhaenJkUEV1MVBp?= =?utf-8?B?RWllT1RpMlg4SWdOWFF0eHdrbnJPeUVzTTNobS90RG96VTR6Y25xaGxROTBw?= =?utf-8?B?MWlQK2YzYWxoZ1U2bEgxbU5CV3VwcmZ0bU1SQk9qOThubG4xVEhtZUU3ZHU2?= =?utf-8?B?OFBNYkIwaEdwR1ppdmdScW0vUGJta1daQjMrMEdoQ1Awanp0dlBlRHJsbGxh?= =?utf-8?B?T0c4NEU4V0E4bnlrTURMVGlSTDQzSUN2UmFrcTl0TTkwRjFQQU01cDRMTTRt?= =?utf-8?B?cENJQ3RkRHNvbXowMlh3RUVjcTc1d1lSenRBUDFhc3grZ214UWIxcVdJNkYw?= =?utf-8?B?blI1a0xjL2s3SWRPTUVaK0NCblJMVjU5WHMyc2hzRGVGRDlBUEM3NGp3NTNp?= =?utf-8?B?dG5LZE9LczZwVFRIRW9ELzMxeU9KTTVOMmZIc0tyVitmL3EwUjROaDBlTVNi?= =?utf-8?B?MnNFbDE4ZG5zTjg4MmVPS2xpUEJUOXZDQUFxVkxpcEFrYktSR3RkcFcxRi9i?= =?utf-8?B?RnY1V1NpZEkyRlBxcUFYV0ZTZk5VVjVERm42UWgvWGVTOXJBeWsraGJJNVA0?= =?utf-8?B?V1pmQUlrSEluOVMrOXVsdU1rcFhMckJrQnJyelhVRGE5bVR0MTlIM1c0N0lL?= =?utf-8?B?dmJOS1BzVnBoSS80MzltRXhXcnJkVHFUMW5FeUJ6cVRGL3Q1UGtXaHMraXJI?= =?utf-8?B?emNSdFlhT0xjb3FOaWt0MU9IeUV0NnMwOUl6UU5mVmE0NFE5anZwK3NrVk0r?= =?utf-8?B?YVA5ZjcrUlJPaU9WMGRLVGp3SDVOUk1FMVJjMXphNWV3NEdJYkZGZFk2MmZP?= =?utf-8?B?c2FkNUk1YjlncUp3dTBHQUNVZmttZk8wbGUvZi94NlJEUG8zR1BZMFZsYzF1?= =?utf-8?B?ajB2eWhPSUVlaVFNS2Z4RmFYR3gwc2R2cnVDQWN5bHhsblJ0RnZTU0tSLzlQ?= =?utf-8?B?bG5QOWNVaHYyaGRtbEFsTzE4c3BTYjlSMTZBbXZ2eGpiYURnSmliNkZuR01K?= =?utf-8?B?MXRmY3Q3ekZ0elRyTzhXUXpnaWxDd1AwTHhTWExYU05VeWpjUjB5VlVJcWFH?= =?utf-8?B?ZkFiL2Y5aFQzbkJaQ0F4aXcxL0ZZZVNLYnhyWHowMndNRnJzQzY0b29TZElL?= =?utf-8?B?VnQrbVp2R0dmc2pvQThNaWk4QVljRDVpYTRHalFPUkFZRHdDMklnR0REMm5z?= =?utf-8?B?dXRMd0E3Q3E0ZE0vWlJVT01xMGI2UVlISjNNcEZDRGtVai8xN2ppb2toREpy?= =?utf-8?B?Q1hvS1pJcGdxNTFIcC84M0RVdGpGVm9wM1hZcmJsWE03eUtOWHQwblhPa3FZ?= =?utf-8?B?L29qRzE3OXMyUnUzUnpwbG4wV3E5RE16MERCWjNUOHlxNW1VblBOeGhnNkdn?= =?utf-8?B?dW1mZG1MeHhlMitRZlpLKzd2QjVqeUYrM1pvNnAyNlQ5MjU5a3JFWVNBa1FE?= =?utf-8?Q?VpcuD2ZfSB64f1Si8mcE/1elZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 677bec7a-cf78-4126-75ec-08db97ddd287 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 07:05:18.0374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t0gbp7vuuMy5U4zzzwdeYsGRz3bC12KbOxWsgyfjY/tZoSGRz2qLgdl7H4TUZ2WHw4gDw+HJHlXdsMraO7D8Eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7757 On 07.08.2023 20:51, Jason Andryuk wrote: > Add a union and struct so that most of the scaling variables of struct > xen_get_cpufreq_para are within in a binary-compatible layout. This > allows cppc_para to live in the larger union and use uint32_ts - struct > xen_cppc_para will be 10 uint32_t's. > > The new scaling struct is 3 * uint32_t + 16 bytes CPUFREQ_NAME_LEN + 4 * > uint32_t for xen_ondemand = 11 uint32_t. That means the old size is > retained, int32_t turbo_enabled doesn't move and it's binary compatible. > > The out-of-context memcpy() in xc_get_cpufreq_para() now handles the > copying of the fields removed there. > > Signed-off-by: Jason Andryuk > Reviewed-by: Jan Beulich > --- > v8: > Add BUILD_BUG_ON checks for structs xc_get_cpufreq_para & xen_get_cpufreq_para > > v6: > Add Jan's Reviewed-by > > v5: > Expand commit message > Change comment to driver/governor > --- > tools/include/xenctrl.h | 22 ++++++++++-------- > tools/libs/ctrl/xc_pm.c | 46 ++++++++++++++++++++++++++++++++----- > tools/misc/xenpm.c | 24 +++++++++---------- > xen/drivers/acpi/pmstat.c | 27 +++++++++++----------- > xen/include/public/sysctl.h | 22 ++++++++++-------- > 5 files changed, 92 insertions(+), 49 deletions(-) Since the note in the cover letter may not be noticed - this wants looking at by a tool stack person. Thanks, Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:07:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579281.907193 (Exim 4.92) (envelope-from ) id 1qTGoO-0003v8-7r; Tue, 08 Aug 2023 07:07:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579281.907193; Tue, 08 Aug 2023 07:07:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGoO-0003v1-4O; Tue, 08 Aug 2023 07:07:24 +0000 Received: by outflank-mailman (input) for mailman id 579281; Tue, 08 Aug 2023 07:07:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGoM-0003up-S9 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:07:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7e1a::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3722a41c-35ba-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 09:07:21 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7757.eurprd04.prod.outlook.com (2603:10a6:102:b8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 07:07:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 07:07:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3722a41c-35ba-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYpXMwmcGDS1yr/uGYGcKiB8ZsgOU4+ZiTAWqdWcakds6wMpOuu3pxMYy2NsFuF+1242hjpTkvamv+iP4ns6sg8XcveVeRTqV6CZw/l4uU3xyIyyfJxDCLfp1zonSdW8Hnl4pYZO/NI7JLgreZI0iizn8ZNnmZU2UJ0t1YH0qqo5thVHnMX7EkqMkV23Zb9eSFgmf7BgX8HrWWjeSlhh8dmJxsDzrRif9SsGEHNeIHOUVyXZiNFu7A4fw8o7Ckhl2rUNKU8cfCVyt2Uhspra7b28oJ+RdwZbwy3dMgIcv/M9TYRsZfYOccA0CL+gjSWPeVYjxmV/SgANCDD14UuAiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4K/6ih7WCPUX5PqpeT51DGBp3NNyv+xM1y49KZkLv5c=; b=D1hUKdL/PUTV5P7GBhz3RDCM4PK76H1PsP5kMkHefO9Hl/5x/CBsyXhTGLOCaZLY58Ivv5bHFw2ti7QANOFlyb09aYf6u1vWrG72J9346y3xXEzlN2opWlj+jBQXidFBIQuV+oFHrXY4C90worgkkBa/tjWVDMrjx1Ktys+OES7Rfaba1oiwWxG43Da9f+r/sYpM/93nXPta4+nxtQTHJLZPbbD2r9aYXw/Qr3YabpGYujrhF2d543K9HYv57KSByphUHzig3nnVHMt+qB5PiHocu7jUlPdNfFN0RwybmW/af96tI7dcPbn9IET6W4DQx5P50LchmgC3qxu0Df7NtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4K/6ih7WCPUX5PqpeT51DGBp3NNyv+xM1y49KZkLv5c=; b=5QPqHIN2+feSAzpQ+OFJDDrntSMbmLXD6vIbga7ROKTCU0Dsq2Mh53k256mUvdCWAyObJWLsRqM4PsHPQwKyKEoHJSGUfCX8lL3IYOgeHYBfGKDFiolxLAn+dEfboiPk/JFsdn/QLmmmz6KiaPxdwFFHiZ3hYom/RAp6iqsepyoyaP0I8W5LL2+aQwJ0mQoruALheYPQGS1vVH79GUg8PWs4ZnZ9Zfd9Ya+D1LFxgls668XBxSr09OmgUGW/8DqROg0+wxrH3IMHXLvEx0dAR+0utnIdjaG7bx0YjarwkNSlsHxVvKpFsu+m5vSuXsPhZKNqAR2sI2ZrmXEAKcCg9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1e5a1e82-b472-8c47-4d21-6df34755381d@suse.com> Date: Tue, 8 Aug 2023 09:07:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb Content-Language: en-US To: Kevin Alarcon Negy Cc: Wei Liu , Anthony PERARD , Juergen Gross , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0041.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7757:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d0e74e5-de3a-40ed-8636-08db97de1a03 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jGc/OKvdXyLCE/hGXZ0QSxeU+VsdDleVW1nGCUfXrQyWFo2xCTyIfvikdsyJ0BUS7Vm/XHhQSXVMSaARCpoguJ6WrMd3U4qzUZRon9D4CTD1Cjpd6IBPE/+cBm83y3cE00ZmpdxHl3HDffu7k+8FnZUQoFmUN79vswT1cUDAfAbl1EVVdZ+SFiexvh/HIUF04gGI4aO2mCsi/SilfDrqlr4qCkBTxmWMrzJeUGPGdPOZrJnQ6baCArhecHClFAguSGbI+F7GacKiNr5xlKWxO5Guz2PlaVa2dJAi1m+buU7lIx+aViyhdRoLl5d3vZYqxPkwtL78y67zxX9fX3+omGc5Z7yzkxL6mWziCHmAGZTbEYZWdXq3Hv2QrPG2ihhr01BEFvQB9C7tKJwpvxxJToXlHrDR5fB3vsjoPWTaYwSkhqeiGlGQtzUoqAUimyWNukzO7KfRTotU4QSHQJo6aFeTU3qXM5l0gQchS4N5p7TD1Vri6BTLybKyIB5fApaljFhKYCXd+OvM96yHvpixytXlsrATIxk8DtokT2va+pSp/32m3P9JxKcDQDJrJ8jWNHU6j7PNNd4rFtsBQnBrYX5ZyasUrj4ZR8T0FV0SdBUKhcg1xaRlvR2uUtuyNPZOZXjaT/DuikKqXnE6AcKYFG78bO36cFbvhCr+LCnphiyyp2O5Hh376Ojg6nkAKkTB2Wcw3TlO0XVA0ANfz8/1xA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199021)(186006)(1800799003)(90011799007)(90021799007)(31686004)(316002)(83380400001)(2616005)(2906002)(36756003)(8936002)(8676002)(26005)(53546011)(38100700002)(6486002)(5660300002)(66476007)(66556008)(66946007)(41300700001)(4326008)(6916009)(6506007)(478600001)(31696002)(54906003)(86362001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFVHMTVhY2x1WVNsQ3dKZnoxVWVqazdITkZlYWhjekxlSmFXMk1keS90ZXYr?= =?utf-8?B?bnZmbCtoSUlzTTBXbkw3aVZQV002Wk5XNjFBTXI1QXlpcDdFOTNxYzk2dU5H?= =?utf-8?B?T0UrejcrajkvWDFHelZqcER3bDJPdDF6NFNyeDN1RnBMNmxMN3pGR0pTN01x?= =?utf-8?B?RUljSmttZ1FKbm9aTDNrQU02Q1p6eXBHaWFpajdwLzJsTTJOR056UzlmZk1q?= =?utf-8?B?K2Jwb3F2cTNQVW9TQ0VxSUZ2SE9UZ3lJUWZPVythMWdTVFA0SmM2NitHYnR2?= =?utf-8?B?K1FBbDNVU01GL0FBRTMyMmZ0Rjg3cldyQlJiN0xjV2RLeHB1UDFzRC9iOUhP?= =?utf-8?B?Z0Z4U3NTREhjTE9jeU5sc29HYjIxNVc4WTUwbDlaSjNlTFVHWEtGNEZyR1Zt?= =?utf-8?B?VURlRTQ1bmg3MzYxa2NNRytjdzNzZjZrQ1dTNk0yNHpaNmdRTEE5bEZJbXFr?= =?utf-8?B?NnZOTEorMXFqZFkrS1FmTFJSSENCQzMwaytoRWo0MFB2aVYwRDNteFhOc3Qz?= =?utf-8?B?b1ovazdEb25QSzZ5RWVrZ21wNUZzcmJrZDlvOEJTU3g0K0UvVGJLNldWSTJo?= =?utf-8?B?YjRFK0ZNL3luYVFnSlF0enI3R1JKUC95MzhKK1RpQXp3eDF5MmVlLzNJMEdY?= =?utf-8?B?N3I4QXJkQjRYU0QvNStKUE1yQVlFVlVzK1A1L3g2UUc2bnF3UzBLM3hxT1VQ?= =?utf-8?B?K24vbTRSVEcrSmxHUG9MNGVWUDBsQzNpVGRDVmRiNmdscXBkOUt4YW5Ybjcx?= =?utf-8?B?VWpNRFAveENpZGhvYkhEZTJqTFVISmNzMW55TncvUms2TFg4Zm0wOFhUSjB2?= =?utf-8?B?NmljbVFhd3RqQlBWdzdYdDNWenpZTFRxYTJCOGNuT2h3dnFWUDM4U01RZ1B4?= =?utf-8?B?MWdRMUY2dG55d2FRcGVsNEFNMkEvTHJpWUVBRSsyOUJWMExDSUU0UFRVV0w5?= =?utf-8?B?a0hBTVE4Q092S3Noa0Q4YnYyeTgxWGJhYWNFNUU5WUpSTlBKQm1LWnpRMEFs?= =?utf-8?B?SzZDbjB2RVR1UHdGbnhyd0g0bTFSREFXc1VwZ3FkZCthblNiQjVmcnJUeGF5?= =?utf-8?B?c1ZCemszdkJWaGo3bXlGQWVmV3lUNit0Mjdnblo0c1Y4ZmJNYVRTTDNFQWQ3?= =?utf-8?B?SnlMMHMrcHNWTFhoQUpkNEZVSUNUVkMyQWJUdXM5NHp3Nms5R1VIMzIrTVhE?= =?utf-8?B?Vlk2ajBHbjN2NngzSm1TWjl6RkxkU0lYM3ZZRDFRdWFiVGZQaEdsWlFuZ0s0?= =?utf-8?B?OGRBcTQ2YnhlV21DUzQ5SlhqaldvR0UyNERHZWRPc3kxc1BiYXVEZGZwMHR5?= =?utf-8?B?WGIycGlYNXhENHVudjZkQmIvSVlIaHJ2Sm5RdzEyVFRLZnJUaGx3WkRLV1BY?= =?utf-8?B?SWR0dUdBVC9OTWdRWXBWZVdNL1kxVzd3dlR6UVcvNTRHdlIwREVqY1gwL0NN?= =?utf-8?B?eTZHcUhiR3Z3N3BuN29pNForRHFZanRLcUM4RWtRb244QU5XTWRreG9jL28w?= =?utf-8?B?bFR6NTgyempLZ3JqNE8remZOY1lLYVcya05ZZWYrTVFieW40dmRrMllkaDRX?= =?utf-8?B?RzdjTGtZY0svdk1KZXprd09wRE1JeEZsN3JCdWd0K2gxVWcxU2EzeWhtV0Vv?= =?utf-8?B?V2xIMURFR0QyV29ZMjFDakZLcHFxejFWVkJKYkluOHB0K2l6blYrckV5YWlY?= =?utf-8?B?SXQ5SFNLdjF6MjlQTDRzVDVkem9OeCtvY2NNOTBaMDduSTM2dnpvNHdMcFQx?= =?utf-8?B?eG16WjN1Y3NodG1jZWx4T0hmVnB2OWJpaXYwZTJrV2hUZnRpM3J5T1BPS2Y4?= =?utf-8?B?VGlxK1QxVTRaWENiMXMya1dMdW5QTnNiVm0rR1RndEZIaWhCcnN6Nno4Zyts?= =?utf-8?B?dkhNYllTcU1JTUYyZTFicDRBMERHSG9aQ0d4MGE2M3BPVmM3V0JHNElVWHY1?= =?utf-8?B?S1ZsU2IwN1VkcktxaUJGRXRRSUpvOWhYbXZsK2duZ2FKeDZScFlCSVgwdWc3?= =?utf-8?B?OXQvQVIzc3pGZGdZbVcwSklRT09JYXhTRnBhYnBaVGpvVUdRM092SFlMRk1s?= =?utf-8?B?ODBMd3lXY2h4cS9zRWlKOVJhMFJ5YnhzV0loL2ZubDE4KzQvaGkyY1g3cGV2?= =?utf-8?Q?M7H9uMCWkGT5fQcyuELiPklYd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d0e74e5-de3a-40ed-8636-08db97de1a03 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 07:07:17.9940 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9GkCW4V92leApKI65tj+xCFs9P/WktzWN/NRmp0OSBtvJ3P2huifWiRlb7bTA20DyjZRJZtDbnXbzsbAk6HjjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7757 On 08.08.2023 00:16, Kevin Alarcon Negy wrote: > When building a domain, xc_domain_setmaxmem() is called with target_memkb (memory in domain config file). > If a config specifies maxmem > memory, any attempts to increase the domain memory size to its max, > outside of xl mem-set or xl mem-max, which already call xc_domain_setmaxmem() properly, will fail. > Changed xc_domain_setmaxmem() call inside libxl__build_pre() to use max_memkb. > > Signed-off-by: Kevin Alarcon Negy > --- > tools/libs/light/libxl_dom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) A note on why you resent would have been useful here. Is this perhaps more a ping than a resend? Jan > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 94fef37401..16aa255aad 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -355,7 +355,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, > return ERROR_FAIL; > } > > - if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + size) < 0) { > + if (xc_domain_setmaxmem(ctx->xch, domid, info->max_memkb + size) < 0) { > LOGE(ERROR, "Couldn't set max memory"); > return ERROR_FAIL; > } From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:08:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:08:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579287.907203 (Exim 4.92) (envelope-from ) id 1qTGpF-0004SR-FN; Tue, 08 Aug 2023 07:08:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579287.907203; Tue, 08 Aug 2023 07:08:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGpF-0004SK-Ch; Tue, 08 Aug 2023 07:08:17 +0000 Received: by outflank-mailman (input) for mailman id 579287; Tue, 08 Aug 2023 07:08:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGpE-0004SA-7B for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:08:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 571023df-35ba-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 09:08:13 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 498924EE0737; Tue, 8 Aug 2023 09:08:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 571023df-35ba-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Tue, 08 Aug 2023 09:08:13 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <55599ec7a1c6d07af6093920fe3f9125@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 07/08/2023 11:10, Jan Beulich wrote: > On 07.08.2023 10:59, Nicola Vetrini wrote: >> On 07/08/2023 10:09, Jan Beulich wrote: >>> On 04.08.2023 17:27, Nicola Vetrini wrote: >>>> The variable declared in the header file >>>> 'xen/arch/x86/include/asm/e820.h' >>>> is shadowed by many function parameters, so it is renamed to avoid >>>> these >>>> violations. >>>> >>>> No functional changes. >>>> >>>> Signed-off-by: Nicola Vetrini >>>> --- >>>> This patch is similar to other renames done on previous patches, and >>>> the >>>> preferred strategy there was to rename the global variable. This one >>>> has more occurrences that are spread in various files, but >>>> the general pattern is the same. >>> >>> Still I think it would be better done the other way around, and >>> perhaps >>> in >>> more than a single patch. It looks like "many == 3", i.e. >>> - e820_add_range(), which is only ever called with "e820" as its >>> argument, >>> and hence the parameter could be dropped, I see another downside with this approach (I should have spotted this sooner): Since e820_add_range and the other functions expected e820 as a pointer, they are written like this: for ( i = 0; i < e820->nr_map; ++i ) { uint64_t rs = e820->map[i].addr; uint64_t re = rs + e820->map[i].size; if ( rs == e && e820->map[i].type == type ) { e820->map[i].addr = s; return 1; } ... Dropping the parameter would either mean 1. Use a local parameter that stores the address of e820, which kind of nullifies the purpose of dropping the parameter imho; 2. Rewrite it so that it operates on a "struct e820map", which would mean substantial churn; 3. Make the global a pointer, which is reminiscent of (1) All in all, I do like the global renaming approach more, because it lessens the amount of code that needs to change to accomodate a case of shadowing. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:14:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:14:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579296.907213 (Exim 4.92) (envelope-from ) id 1qTGus-0005x5-4M; Tue, 08 Aug 2023 07:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579296.907213; Tue, 08 Aug 2023 07:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGus-0005wy-0R; Tue, 08 Aug 2023 07:14:06 +0000 Received: by outflank-mailman (input) for mailman id 579296; Tue, 08 Aug 2023 07:14:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGuq-0005ws-PW for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:14:04 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 277ce34c-35bb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 09:14:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E74FC2247E; Tue, 8 Aug 2023 07:14:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BFEEA13451; Tue, 8 Aug 2023 07:14:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id N2t1LTrr0WRbWAAAMHmgww (envelope-from ); Tue, 08 Aug 2023 07:14:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 277ce34c-35bb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691478842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=c+qF184B5rmJ/fR8Yb3OZb8seiHxjL7CMZfZGReEIlw=; b=EC1lc1fQzYx5WU3RKWQegFJP6jNyT9ZOzLEiPFg+cFA/Qrd5M6lwvdGodnOod6R4XhYKtE ONligztZClZpWj7nESh2iQhVj5XXVexLPleQTDd9oUR4d1av5LYJBGeHmcv9G8PO53n2eq ikmLxiCYl0nmnOdVIi5t60/SKVZeZtQ= Message-ID: <226469c1-c291-3756-88c8-24b51fecc6a2@suse.com> Date: Tue, 8 Aug 2023 09:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb Content-Language: en-US To: Kevin Alarcon Negy , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------tBBrA0wep04TuWTsbF0xBK0d" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------tBBrA0wep04TuWTsbF0xBK0d Content-Type: multipart/mixed; boundary="------------aj0uQ70ddhSk6iwUnIkoxP0C"; protected-headers="v1" From: Juergen Gross To: Kevin Alarcon Negy , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <226469c1-c291-3756-88c8-24b51fecc6a2@suse.com> Subject: Re: [PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb References: In-Reply-To: --------------aj0uQ70ddhSk6iwUnIkoxP0C Content-Type: multipart/mixed; boundary="------------AzvIcT0FpbHwyGgoJ5s1ODMG" --------------AzvIcT0FpbHwyGgoJ5s1ODMG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDguMjMgMDA6MTYsIEtldmluIEFsYXJjb24gTmVneSB3cm90ZToNCj4gV2hlbiBi dWlsZGluZyBhIGRvbWFpbiwgeGNfZG9tYWluX3NldG1heG1lbSgpIGlzIGNhbGxlZCB3aXRo IHRhcmdldF9tZW1rYiAobWVtb3J5IGluIGRvbWFpbiBjb25maWcgZmlsZSkuDQo+IElmIGEg Y29uZmlnIHNwZWNpZmllcyBtYXhtZW0gPiBtZW1vcnksIGFueSBhdHRlbXB0cyB0byBpbmNy ZWFzZSB0aGUgZG9tYWluIG1lbW9yeSBzaXplIHRvIGl0cyBtYXgsDQo+IG91dHNpZGUgb2Yg eGwgbWVtLXNldCBvciB4bCBtZW0tbWF4LCB3aGljaCBhbHJlYWR5IGNhbGwgeGNfZG9tYWlu X3NldG1heG1lbSgpIHByb3Blcmx5LCB3aWxsIGZhaWwuDQoNCkJ1dCB0aGlzIGlzIGhvdyBp dCBzaG91bGQgd29yaywgbm8/DQoNCldpdGggeW91ciBjaGFuZ2UgdGhlIGd1ZXN0IGNvdWxk IGVhc2lseSBiYWxsb29uIGl0c2VsZiB1cCB0byBtYXhtZW0gd2l0aG91dCBpdA0KaGF2aW5n IGJlZW4gYWxsb3dlZCB0byBkbyBzby4NCg0KVGhlIG1heG1lbSBjb25maWcgb3B0aW9uIGlz IG1lYW50IHRvIHRlbGwgdGhlIGRvbWFpbiBob3cgbXVjaCBtZW1vcnkgaXQgc2hvdWxkDQpi ZSBwcmVwYXJlZCB0byB1c2Ugc29tZSB0aW1lIGluIHRoZSBmdXR1cmUuIEl0IGlzbid0IG1l YW50IHRvIGFsbG93IHRoZSBkb21haW4NCnRvIHVzZSByaWdodCBub3cuDQoNCg0KSnVlcmdl bg0KDQo+IENoYW5nZWQgeGNfZG9tYWluX3NldG1heG1lbSgpIGNhbGwgaW5zaWRlIGxpYnhs X19idWlsZF9wcmUoKSB0byB1c2UgbWF4X21lbWtiLg0KPiANCj4gU2lnbmVkLW9mZi1ieTog S2V2aW4gQWxhcmNvbiBOZWd5IDxrZXZpbkBleG9zdGVsbGFyLmlvPg0KPiAtLS0NCj4gICB0 b29scy9saWJzL2xpZ2h0L2xpYnhsX2RvbS5jIHwgMiArLQ0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rv b2xzL2xpYnMvbGlnaHQvbGlieGxfZG9tLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2Rv bS5jDQo+IGluZGV4IDk0ZmVmMzc0MDEuLjE2YWEyNTVhYWQgMTAwNjQ0DQo+IC0tLSBhL3Rv b2xzL2xpYnMvbGlnaHQvbGlieGxfZG9tLmMNCj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9kb20uYw0KPiBAQCAtMzU1LDcgKzM1NSw3IEBAIGludCBsaWJ4bF9fYnVpbGRfcHJl KGxpYnhsX19nYyAqZ2MsIHVpbnQzMl90IGRvbWlkLA0KPiAgICAgICAgICAgcmV0dXJuIEVS Uk9SX0ZBSUw7DQo+ICAgICAgIH0NCj4gICANCj4gLSAgICBpZiAoeGNfZG9tYWluX3NldG1h eG1lbShjdHgtPnhjaCwgZG9taWQsIGluZm8tPnRhcmdldF9tZW1rYiArIHNpemUpIDwgMCkg ew0KPiArICAgIGlmICh4Y19kb21haW5fc2V0bWF4bWVtKGN0eC0+eGNoLCBkb21pZCwgaW5m by0+bWF4X21lbWtiICsgc2l6ZSkgPCAwKSB7DQo+ICAgICAgICAgICBMT0dFKEVSUk9SLCAi Q291bGRuJ3Qgc2V0IG1heCBtZW1vcnkiKTsNCj4gICAgICAgICAgIHJldHVybiBFUlJPUl9G QUlMOw0KPiAgICAgICB9DQoNCg== --------------AzvIcT0FpbHwyGgoJ5s1ODMG Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AzvIcT0FpbHwyGgoJ5s1ODMG-- --------------aj0uQ70ddhSk6iwUnIkoxP0C-- --------------tBBrA0wep04TuWTsbF0xBK0d Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTR6zoFAwAAAAAACgkQsN6d1ii/Ey+/ VAgAkzTHnljJVZg5sw4nP7caJtbjmcekQu7sbUARJqHdKyHpM/gQ7aQI6HJDddFy7lZW8oh5v+Mw b92iztQAz0S8/Yb++6m8+nul4jqYX5o4Y/Q41WPV88RoEe46DUCuyL/fvqOg4xQTB9qOIzPLNrxm SP63UxAOQLSWnX8K0ZfS8q5Ab5F0YALq+jGbVjJPm4Vx1785XB4dIsCLUOha+AD6aPPaNB11EpoM Vn5TIq86W3gRniUAzNMXOmJHyM9c2HYLnFoiMBu72I9ggwYxkXmnqWSbYNTdK2mqqporOZtayPaN yE8Z3mlZOEZfIRipQppZGO2EAHlTpP2oic9drEee5w== =z279 -----END PGP SIGNATURE----- --------------tBBrA0wep04TuWTsbF0xBK0d-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:14:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:14:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579299.907223 (Exim 4.92) (envelope-from ) id 1qTGvS-0006SD-Bx; Tue, 08 Aug 2023 07:14:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579299.907223; Tue, 08 Aug 2023 07:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGvS-0006S6-97; Tue, 08 Aug 2023 07:14:42 +0000 Received: by outflank-mailman (input) for mailman id 579299; Tue, 08 Aug 2023 07:14:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGvQ-0006Ru-QA; Tue, 08 Aug 2023 07:14:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGvQ-0003kg-Gk; Tue, 08 Aug 2023 07:14:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTGvQ-0005rf-0q; Tue, 08 Aug 2023 07:14:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTGvQ-000860-0O; Tue, 08 Aug 2023 07:14:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FQYVY+Id1sADrSRkNk/YmKIsSLIkLY97Poi88PNBnGY=; b=nO+zGnoRci0AHYFGftmIX2aLRr /2I8BHquemIzMC0ymNpyOvzsveGgCGrxgF6Z/X1VD1chlnnEp1dBzNw/b7UCm817y2wMfD7ZXnOJL NYG7zrDdebcUeeCoP0l2zZzr5RNzAS2ecnGh/wZDIWc0cymq8VkqqkoAk8MDDh8BnlHc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182221: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:regression xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 X-Osstest-Versions-That: xen=e55146071de9257d70bd157047700071d0007622 From: osstest service owner Date: Tue, 08 Aug 2023 07:14:40 +0000 flight 182221 xen-unstable real [real] flight 182226 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182221/ http://logs.test-lab.xenproject.org/osstest/logs/182226/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-examine-bios 6 xen-install fail REGR. vs. 182210 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail pass in 182226-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182210 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182210 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182210 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182210 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182210 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182210 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182210 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182210 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182210 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182210 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182210 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182210 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 baseline version: xen e55146071de9257d70bd157047700071d0007622 Last test of basis 182210 2023-08-07 01:52:04 Z 1 days Testing same since 182221 2023-08-07 18:40:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alejandro Vallejo Andrew Cooper Dario Faggioli Federico Serafini Gianluca Luparini Gianluca Luparini Henry Wang Jan Beulich Nicola Vetrini Simone Ballarin jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 65f0d6fc80cba9d79b58e6f2bfc00e36d4e66898 Author: Andrew Cooper Date: Tue Jun 20 18:01:46 2023 +0100 x86: Drop opt_pku entirely This option is particularly dubious as Xen does not use Protection Keys, owing to the sharing of pagetables with PV guests. All this option does is hide PKU by default from HVM guests, and is therefore redundant with the more generic cpuid=no-pku. The variable ought to be in __initdata given it's single user, but deleting it entirely looks to be a better course of action. Visibility of PKU to guests should be handled via its vm.cfg file. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Henry Wang commit 767d1a2cfdca962f4ae3f9f620e5c5f94db5f3e9 Author: Alejandro Vallejo Date: Fri Jul 28 08:58:59 2023 +0100 arm/mm: Document the differences between arm32 and arm64 directmaps arm32 merely covers the XENHEAP, whereas arm64 currently covers anything in the frame table. These comments highlight why arm32 doesn't need to account for PDX compression in its __va() implementation while arm64 does. Signed-off-by: Alejandro Vallejo Reviewed-by: Julien Grall commit d63ea6c46b89bffb99647871c788c236a8286646 Author: Nicola Vetrini Date: Mon Aug 7 11:25:02 2023 +0200 libelf: address MISRA C:2012 Rule 5.3 The types u{8,16,32,64} defined in 'xen/arch/x86/include/asm/types.h' shadow the variables in the modified function, hence violating Rule 5.3. Therefore, the rename takes care of the shadowing. No functional changes. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini commit 202a341fd41d281d08846136289d93a5425520f6 Author: Federico Serafini Date: Mon Aug 7 11:24:28 2023 +0200 x86: Address violations of MISRA C:2012 by replacing bool_t uses Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between object and function declarations thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). Replace the occurrences of bool_t with bool. No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich commit 0c8d77e117126ffd15aa63fe7617c4fd64b3ad77 Author: Gianluca Luparini Date: Mon Aug 7 11:23:54 2023 +0200 xen/include: address violations of MISRA C:2012 Rule 7.3 From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini commit 6ad7563727ab383396e7932e5f2005f032f4eb59 Author: Gianluca Luparini Date: Mon Aug 7 11:23:29 2023 +0200 xen/common: address violations of MISRA C:2012 Rule 7.3 From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini commit b89d204ee0fec0c4c2c639b9f37ef431d3b66100 Author: Gianluca Luparini Date: Mon Aug 7 11:22:58 2023 +0200 xen/arm: address violations of MISRA C:2012 Rule 7.3 The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini commit 680e66544caa5cf5dbb55e0b160733f61d9157c1 Author: Federico Serafini Date: Mon Aug 7 11:22:24 2023 +0200 xen/sched: address violations of MISRA C:2012 Rules 8.2 and 8.3 Give a name to unnamed parameters to address violations of MISRA C:2012 Rule 8.2 ("Function types shall be in prototype form with named parameters"). Keep consistency between parameter names and types used in function declarations and the ones used in the corresponding function definitions, thus addressing violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). No functional changes. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Acked-by: Dario Faggioli commit e26230a34982d8b771734cf43dbdc87864329d5a Author: Nicola Vetrini Date: Mon Aug 7 11:21:24 2023 +0200 xen/sched: mechanical renaming to address MISRA C:2012 Rule 5.3 Rule 5.3 has the following headline: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" The renaming s/sched_id/scheduler_id/ of the function defined in 'xen/common/sched/core.c' prevents any hiding of that function by the instances of homonymous function parameters that are defined in inner scopes. Similarly, the renames - s/ops/operations/ for the static variable in 'xen/common/sched/core.c' - s/do_softirq/needs_softirq/ are introduced for variables, to avoid any conflict with homonymous parameters or function identifiers. Moreover, the variable 'loop' defined at 'xen/common/sched/credit2.c:3887' has been dropped, in favour of the homonymous variable declared in the outer scope. This in turn requires a modification of the printk call that involves it. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini Acked-by: Dario Faggioli commit a628e73de1f4839b58f3ef4026ade3e06f7e54ea Author: Jan Beulich Date: Mon Aug 7 11:20:15 2023 +0200 x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}() In the latter case the variable altogether is then unused and hence gets dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly introduced both assignments in 57a57465daaf ("x86/HVM: use available linear->phys translations in REP MOVS/STOS handling"), likely as a result of some re-work on the patch. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:22:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579312.907232 (Exim 4.92) (envelope-from ) id 1qTH2W-00084K-43; Tue, 08 Aug 2023 07:22:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579312.907232; Tue, 08 Aug 2023 07:22:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH2W-00084D-1K; Tue, 08 Aug 2023 07:22:00 +0000 Received: by outflank-mailman (input) for mailman id 579312; Tue, 08 Aug 2023 07:21:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH2V-000847-Eo for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:21:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4291032c-35bc-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 09:21:58 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 07:21:29 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 07:21:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4291032c-35bc-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYcyGT6CiDUyxag7eSOL8Ie6m1wsdZKFjAIcOQSr0WZTUxGj5cTaMCvvy2hH4cFGdLC5HbYOxC60P/7VCrcLvX4JnMf+BzproeaH5xYU6Q8CeYqLlmjCAp4bphGJbBXG50tuWbw1PDQnAzBXutBqydHXaJdizbWQ6wBFB2CMHEeItDT7zALKFErVue6aoUQPTa/WBhxdprhW3VtM0v6phRAUOblyVs8rJv52yPTWuzsA+W5wssJeIxNscj+xB4ED/zsfaNT++9aBrYFn1VfYNs5zu3Yyaaj0Kk4dg1Xpc9S1LU1Q8Kctybd29NZoSUdFpvnhHcLB8mU+aRAV3Gel7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jpm7zzJKhEBlzZOTLSH5wysuwemJIRZ5GAovXG2lyus=; b=ZFyD1XTTEGKjwDY/bittyeSJq1J6xyRyQUgQA0/wva2qUTxLygNpZmannFVU2fMZg+UQcdmbpAF723Ff2k2Kywe/46Z0UsFzN0H9xnrmQiDIQOhi66NcUbM1HC/uSKFt5chMA8PoC+ups9+D7LOgEty0vQ1UvkFx78V6NTIqyITF96UR3rfu6wAzA/MC0vtwJH9jMPXb5/nF3wmcag/b8QrNzJ1K17UzrEXNlI+daFRfygZsllcgRLeCcjAcmafdklbzAMdWWoXCz9duMZ9fVGXP2k3b5mCs8ISPhLVrSXnxtcJ7QSqb7LImHXSNcmA0vxaBzzMx84NxDKhvFchOLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jpm7zzJKhEBlzZOTLSH5wysuwemJIRZ5GAovXG2lyus=; b=1EDCVz9h0Bxb7DlwN52N+DWu/EN6KTynmdNydG/tyNjGcmjnc0363c2gwSFnI9+RtcH4qwd1dkElXqDj1FkJFWanDDuuoX6RyL8NDdbdG2GXVkCehD7u+zp+HTnJjDiCL4g7gMKWfSaI/QR5rSHqKOrjKceoWN9JTcfWXt/bbLlXn2kXHEGWiZri9vvjPGSvCDzTv53RGc5+8c4zPdaahPuMqHr+wa98J2JeTBriw7qH7EDIN8RHI/iUAo8ZlOh4Gd7aAF++NrSCGCK3gL3iXucjpHVjltGTiNA9KNPhysT33ba/V2F1gMSHtZfV8oy8tzjR7jMa5HUz0aLtfY/y9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0164b934-cf15-9e45-28b7-b3c9ac2038da@suse.com> Date: Tue, 8 Aug 2023 09:21:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> <55599ec7a1c6d07af6093920fe3f9125@bugseng.com> From: Jan Beulich In-Reply-To: <55599ec7a1c6d07af6093920fe3f9125@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7970:EE_ X-MS-Office365-Filtering-Correlation-Id: b45fa1c7-73e7-4155-ea7b-08db97e01557 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iSc1aSeeSiTj7XtnIHcQiUiT4mHTxxee0Tyy4tkHx64NyOuMk/UgzsyDI+XFqf+kmwiGQVkY8HyyWllqsCVjTl26jWPvnsIjyOs8b8t5s4bUGxLrr3cd6NMDjT3l5BxDqrsk3X5pZqxskBRDzZ/j3HABrCgQWIVVrr1OgpV59Sg9TllEZa5LfzIH6lHlPumpULPLm3hEAzudqsttpEpO/9j4itzHrjZN+2Wxp+5a8kSOpAekr6WznEQwZXK2hHuOAtwVFS+ds2aRdr53pOtm15wiEDyxlZDPTp+QFYCR9T6pxKOAU0O6wKIP/v3Ee0bsMUiGCntKsZ4sf5kighX7JQfyZMAT+1cFNPWAlILZ33y3QHf3NEdkeXt+AU/5As1P9gD5nHBHbIL0AIbt47VunBMh/MtyIEYWsTDHb3goH8kFrEQVYaTg2RHh6SB6IUonmletxVuAUx03RAFPLMnyTgLnt1945Sb+FZjwAZ6cUBEKssUCbhHWZisjdoNdzazdTS038gDX8gOatWV9wfAVTqL98ToKhD8GzMJPaQCiLbgXIuFQMEJizTD3Eu+LI3DZKLyovTmwn1b5C2A03kEYzKv6KDplTF42yqz33a6x2IDXqjx3E/whrIpRfufinxCRCLNOFgz6RudOeXSZ2iU/eNzNSgeZhswz/i6lEAAwuwA7kogC12xjhczwTxxHO/283t+GOfEp+/BO7nUlAQ30uQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(136003)(396003)(376002)(1800799003)(186006)(90021799007)(451199021)(90011799007)(6486002)(478600001)(83380400001)(31686004)(2616005)(6512007)(26005)(53546011)(6506007)(8936002)(66476007)(66556008)(66946007)(316002)(41300700001)(4326008)(8676002)(31696002)(2906002)(6916009)(6666004)(36756003)(54906003)(38100700002)(86362001)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWx4Z3VBNXdzV1pSaTZwNWl0cTJYMjU1bnhxRllEdytrQzVNdko3b25VanNL?= =?utf-8?B?cnN6bTlrWTBLZmZhSS9ZaEdyK3BhZkUzWHh1K1k0WUpPR3daaG4vemlnaE1U?= =?utf-8?B?eVhZeUlmL0JGLy9JOU1QaVhpczRZd0dLVnpDVXZhK1Y5eVRQNk1oTVZ2dUFP?= =?utf-8?B?bHd3alBUb0pTSXBzNlRaYkEzSkYwMW9aenc2eCtSNUM1WXptWGw1YjE2ZXBB?= =?utf-8?B?dTdLZTJDb01uTjFYYk1rMEtPR05ZSngwS1RIbkxreFBFR0RybHJpQXNqVU5H?= =?utf-8?B?MWFvVXozQ3RaMEhGZUNmbGc0WTFSNEpucDlOcEFwNU5tdjA5Zlc1Q29SYUdn?= =?utf-8?B?MjlxY21IbmVNVTkxOUNZdUxUQzAzRFB3V093eTRLeVlnTnhCZzVtZ3ZQZkZL?= =?utf-8?B?WkFONHM2cWVwWTJOMkxOM0pIclFGZG9rRm51U2VHb2VLc2pUakZuMnd6VjJv?= =?utf-8?B?RmtqTkNKMGQ0VUJ2VGRpck5IdTgrVnJDOUliUC95bzlOS0w5SnAvWE03clJs?= =?utf-8?B?Z1I0eGs5dDc0QUpkWDRhZVpQdnhkL2dqbFg0UGl0M1orZEQ2YzhYRFlKRXdH?= =?utf-8?B?WHR4TTdQVVlIV0NwSWplcm9xZWxCNHZCSUwrTUczRGs4dE9rdThkZkNzQU9H?= =?utf-8?B?UU1BR20ydHA3SUpPRGdmT2pFajl1TjVockpQQUFWNUR3bXE4U3N6alRGZUlo?= =?utf-8?B?RnlYSEFab2dRTU5Ebk9rZkVzQ25aTUFjSXM2ajcvcmFuMU9OVi9hQzZZdlAr?= =?utf-8?B?Tm1KdU1Ha1hvUlU4K01WdkV6NVZ2QlJXSWlxOUxGTkJzTmxmOFU2TG9IVnFk?= =?utf-8?B?NHZBc2E2ZHFsU1VzM3R4T1hpMCtIVWJzWTAyRndHaXc4T05ZWWNPS1ZHdkhn?= =?utf-8?B?L2tKcGgwa2NQYVlHZ0trcHloTHczL0M3UUFOc09MbmpXVUo1MHdLZUsrK1RM?= =?utf-8?B?K3o2ZkZPa0daK1BVZlJOaWdXUDY0eWlHdjAwbVN3eGdQYTBzcFNUYmRkNzNL?= =?utf-8?B?YVF3ek54UEI0cGhLZUtYalFnenZBNHgvZVhwbkpsSnpGWHQ3SHJ6Z25xdENH?= =?utf-8?B?YlhWUEZBcGxYZzBmRE9EUGpJbEI2WUlsaXM4T0c1UVJUR25rMnduQkRnNld5?= =?utf-8?B?dEt3MWQ0clFYTm9RMFhtNHAxQm5aRXNGTGZEUEV2amNjOGpZVjRxSy9GYzVC?= =?utf-8?B?LzVsMXExUDhJWjI4QnR1Tm9DQ2Z2SmQxQStGY3NBanNJQmtrd1RoZnRZbTU3?= =?utf-8?B?YklKMTRLRGdyMU5CV2JJWGtSa2ZiVXJ3TFJiYXJRYkh1SHJhTS9LQm81Tm9h?= =?utf-8?B?WWsxNlVHaS9hNm1QaUlRNjRtVzF3T1VyaFJ5cHFsdytObjI0TXVHSWtJL1Z3?= =?utf-8?B?d0N4U2lJZFhkNUUyTjlWYTM2bUtYUUVvOHFqcVFhNDgrVldnQjkzeGVYT2t5?= =?utf-8?B?NVdCVUQxUmtsN0xWY3R4eUFrcTFJTDg4bmxDcU1xVDlyb0NtdXZncXpmVlA5?= =?utf-8?B?QTRBUlBzYVFBNmxLVHF0eU5HTGdrNVg0a2wxWlNxaS9qRzEwRDR0dUxCWWZT?= =?utf-8?B?STU3YkJXMmxoQ1BUYVFSRndhWjFHQ0pmNER3N2FmSEJmZm1wYmE2ejloejJ2?= =?utf-8?B?bXhQa2QrS0lUemNtM2h2RzAwRzZRV2VZZjdGMW5SanhBQnM3THBYS040dHBa?= =?utf-8?B?ZkM4TEo1SEZWYXdKaHpjRGlVQk5WNGtOSGd6M2Q0NGpIczhMYWdaK3lvWXFz?= =?utf-8?B?Q2QweUpmZERuSUdKMkdwZDFFRU9OUkJScUxFQlN1ck5tRnM5amphUEMwWmN3?= =?utf-8?B?Ty9pTFdBbjQvQTRQcXZqZVpQNHhuT0h2TkYzTUV4bHYxUzhPeDlHMWlRRENt?= =?utf-8?B?S0FMbEk0SElpYTU3cTBVN2EzbHZKSm5IYy85ZkpEdmo4cVZhaUpYR0NFemdz?= =?utf-8?B?d3Y1cmtxeDRPN0tlS3Ixc25HQ3pMMytxM3QrUkpYa2Vsck9EZlNBUmZMcVlt?= =?utf-8?B?SCtiMk9NQnlxN05VR0grZzAyRU1KejhReTh5RXZBeStPTVJIcUF1bW9yeHVI?= =?utf-8?B?d0I2dW1FamNOdzVOcW51OU1ta1F6c3FMb3VoQUc2dm5kVjJGQzd5SWdKWHZt?= =?utf-8?Q?jErA4/a7gIag6jokxWhwNFo5a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b45fa1c7-73e7-4155-ea7b-08db97e01557 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 07:21:29.0849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pet60bjFxa2vUOkXw5oVi+TpV6jOzvXSU3H2b/YBFXF++nGTtfWEfefOzmoPwsOWvmIT2JhX6VbRTXlXVB8Zhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970 On 08.08.2023 09:08, Nicola Vetrini wrote: > On 07/08/2023 11:10, Jan Beulich wrote: >> On 07.08.2023 10:59, Nicola Vetrini wrote: >>> On 07/08/2023 10:09, Jan Beulich wrote: >>>> On 04.08.2023 17:27, Nicola Vetrini wrote: >>>>> The variable declared in the header file >>>>> 'xen/arch/x86/include/asm/e820.h' >>>>> is shadowed by many function parameters, so it is renamed to avoid >>>>> these >>>>> violations. >>>>> >>>>> No functional changes. >>>>> >>>>> Signed-off-by: Nicola Vetrini >>>>> --- >>>>> This patch is similar to other renames done on previous patches, and >>>>> the >>>>> preferred strategy there was to rename the global variable. This one >>>>> has more occurrences that are spread in various files, but >>>>> the general pattern is the same. >>>> >>>> Still I think it would be better done the other way around, and >>>> perhaps >>>> in >>>> more than a single patch. It looks like "many == 3", i.e. >>>> - e820_add_range(), which is only ever called with "e820" as its >>>> argument, >>>> and hence the parameter could be dropped, > > I see another downside with this approach (I should have spotted this > sooner): > Since e820_add_range and the other functions expected e820 as a pointer, > they are > written like this: > > for ( i = 0; i < e820->nr_map; ++i ) > { > uint64_t rs = e820->map[i].addr; > uint64_t re = rs + e820->map[i].size; > > if ( rs == e && e820->map[i].type == type ) > { > e820->map[i].addr = s; > return 1; > } > ... > > Dropping the parameter would either mean > 1. Use a local parameter that stores the address of e820, which kind of > nullifies the purpose of dropping the parameter imho; This isn't an unusual thing to do; it is only the name being short which may make it look "unnecessary" here. But especially if the local variable was made of type struct e820entry * (and updated in the for()) I think this could be useful overall. > 2. Rewrite it so that it operates on a "struct e820map", which would > mean > substantial churn; > 3. Make the global a pointer, which is reminiscent of (1) > > All in all, I do like the global renaming approach more, because it > lessens > the amount of code that needs to change to accomodate a case of > shadowing. Well, to go that route you need to come up with a suitable new name (no prior proposal was really meeting that requirement) and you'd need to convince at least one of the x86 maintainers. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:23:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:23:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579318.907243 (Exim 4.92) (envelope-from ) id 1qTH3e-00009v-E2; Tue, 08 Aug 2023 07:23:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579318.907243; Tue, 08 Aug 2023 07:23:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH3e-00009l-Ar; Tue, 08 Aug 2023 07:23:10 +0000 Received: by outflank-mailman (input) for mailman id 579318; Tue, 08 Aug 2023 07:23:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH3c-00008I-O6 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:23:08 +0000 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [2607:f8b0:4864:20::130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b2c26fc-35bc-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 09:23:07 +0200 (CEST) Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-346434c7793so5314945ab.0 for ; Tue, 08 Aug 2023 00:23:07 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id s15-20020a63af4f000000b00564ca424f79sm4948391pgo.48.2023.08.08.00.22.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 00:23:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b2c26fc-35bc-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691479386; x=1692084186; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=if5VWB18nVWwRp6UCb6aPEiH47g9I/o9CGJnGCggs6I=; b=Mnl0X9gAUC+TX6mJR8mVBxy4/YY9ZnsIqqbI3Lfyi8wyHvx1vCgiMQzro/5+MvPtg7 rXoES6uNYyqB6hAadoK+JhiLrRJcV2a1SauK74Fo+QgskggrpKST7Q5+m6teYvR8e4tA dcZeOtaDf0Rd9+kc+LJz513/LAkTal/IYIX9DnJ4z84K6HpsLIJ90Jamw7qS1U2+fb2T E2X5y4E7mVpGf6lSS7nOAzl3gvR6+Jw0hw4oEJ+kBhol+PlGk5o70522UKHLTkm0KAg0 ZhNaOymrQBqWDvmGRTs6Q0O1Bt27v7iPkeiHC47LN5BEMRNJZINNo5Ho/St2M7DsfprN 6jkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691479386; x=1692084186; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=if5VWB18nVWwRp6UCb6aPEiH47g9I/o9CGJnGCggs6I=; b=cDmCdkz9KLvqzmQCuruwTClKVDj3dUVlTVqLXOpKRsHXDOxaQMn2x1oCJIJbtMKU6V /U4emRmjAsE5LqPadad2aQnvXmGClEts+clQLtZBoCcfPzbTHGqWSnIRQVu637PQ9xFo TVCzvyhVgAPs623agMf+UK8Bvdi+HBnJw4pUmF0gx+vcAPE8RYlF3ywbfz6x+vqvFjiW NPnAd+9Nxn0DcEQcjna4gi+tsY7gfbDyHNNATB4waQsTQsY/apiejou2DR6yGr4/5jEk RXwW1GDrYpPsOQd19jtee5FpF9pYqbWM5KvTHPTRNjxJhIDWCYTs9CKQaGmefM6t/7nO Hlmw== X-Gm-Message-State: AOJu0YwBDTDb7tkSwp8FQX0QZmJhr7JvR0Wru5qj2Cn0aGTQStITxb4K Rhrx5VEdHF4zQHZokjkkdE90+Q== X-Google-Smtp-Source: AGHT+IGrIAD/R1XG8iT7hZdid4m31qfruz9y309af9L0+sAELwy0z1r+YzLKvbiH8nyqlY1j6mrYWw== X-Received: by 2002:a92:2802:0:b0:349:7518:4877 with SMTP id l2-20020a922802000000b0034975184877mr3215795ilf.0.1691479385787; Tue, 08 Aug 2023 00:23:05 -0700 (PDT) Message-ID: <0fdb926c-0d61-d81f-1a52-4ef634b51804@bytedance.com> Date: Tue, 8 Aug 2023 15:22:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 45/48] mm: shrinker: make global slab shrink lockless Content-Language: en-US To: Dave Chinner Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-46-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Dave, On 2023/8/8 10:24, Dave Chinner wrote: > On Mon, Aug 07, 2023 at 07:09:33PM +0800, Qi Zheng wrote: >> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >> index eb342994675a..f06225f18531 100644 >> --- a/include/linux/shrinker.h >> +++ b/include/linux/shrinker.h >> @@ -4,6 +4,8 @@ >> >> #include >> #include >> +#include >> +#include >> >> #define SHRINKER_UNIT_BITS BITS_PER_LONG >> >> @@ -87,6 +89,10 @@ struct shrinker { >> int seeks; /* seeks to recreate an obj */ >> unsigned flags; >> >> + refcount_t refcount; >> + struct completion done; >> + struct rcu_head rcu; > > Documentation, please. What does the refcount protect, what does the > completion provide, etc. How about the following: /* * reference count of this shrinker, holding this can guarantee * that the shrinker will not be released. */ refcount_t refcount; /* * Wait for shrinker::refcount to reach 0, that is, no shrinker * is running or will run again. */ struct completion done; > >> + >> void *private_data; >> >> /* These are for internal use */ >> @@ -120,6 +126,17 @@ struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); >> void shrinker_register(struct shrinker *shrinker); >> void shrinker_free(struct shrinker *shrinker); >> >> +static inline bool shrinker_try_get(struct shrinker *shrinker) >> +{ >> + return refcount_inc_not_zero(&shrinker->refcount); >> +} >> + >> +static inline void shrinker_put(struct shrinker *shrinker) >> +{ >> + if (refcount_dec_and_test(&shrinker->refcount)) >> + complete(&shrinker->done); >> +} >> + >> #ifdef CONFIG_SHRINKER_DEBUG >> extern int __printf(2, 3) shrinker_debugfs_rename(struct shrinker *shrinker, >> const char *fmt, ...); >> diff --git a/mm/shrinker.c b/mm/shrinker.c >> index 1911c06b8af5..d318f5621862 100644 >> --- a/mm/shrinker.c >> +++ b/mm/shrinker.c >> @@ -2,6 +2,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> #include "internal.h" >> @@ -577,33 +578,42 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, >> if (!mem_cgroup_disabled() && !mem_cgroup_is_root(memcg)) >> return shrink_slab_memcg(gfp_mask, nid, memcg, priority); >> >> - if (!down_read_trylock(&shrinker_rwsem)) >> - goto out; >> - >> - list_for_each_entry(shrinker, &shrinker_list, list) { >> + rcu_read_lock(); >> + list_for_each_entry_rcu(shrinker, &shrinker_list, list) { >> struct shrink_control sc = { >> .gfp_mask = gfp_mask, >> .nid = nid, >> .memcg = memcg, >> }; >> >> + if (!shrinker_try_get(shrinker)) >> + continue; >> + >> + /* >> + * We can safely unlock the RCU lock here since we already >> + * hold the refcount of the shrinker. >> + */ >> + rcu_read_unlock(); >> + >> ret = do_shrink_slab(&sc, shrinker, priority); >> if (ret == SHRINK_EMPTY) >> ret = 0; >> freed += ret; >> + >> /* >> - * Bail out if someone want to register a new shrinker to >> - * prevent the registration from being stalled for long periods >> - * by parallel ongoing shrinking. >> + * This shrinker may be deleted from shrinker_list and freed >> + * after the shrinker_put() below, but this shrinker is still >> + * used for the next traversal. So it is necessary to hold the >> + * RCU lock first to prevent this shrinker from being freed, >> + * which also ensures that the next shrinker that is traversed >> + * will not be freed (even if it is deleted from shrinker_list >> + * at the same time). >> */ > > This needs to be moved to the head of the function, and document > the whole list walk, get, put and completion parts of the algorithm > that make it safe. There's more to this than "we hold a reference > count", especially the tricky "we might see the shrinker before it > is fully initialised" case.... How about moving these documents to before list_for_each_entry_rcu(), and then go to the head of shrink_slab_memcg() to explain the memcg slab shrink case. > > > ..... >> void shrinker_free(struct shrinker *shrinker) >> { >> struct dentry *debugfs_entry = NULL; >> @@ -686,9 +712,18 @@ void shrinker_free(struct shrinker *shrinker) >> if (!shrinker) >> return; >> >> + if (shrinker->flags & SHRINKER_REGISTERED) { >> + shrinker_put(shrinker); >> + wait_for_completion(&shrinker->done); >> + } > > Needs a comment explaining why we need to wait here... /* * Wait for all lookups of the shrinker to complete, after that, no * shrinker is running or will run again, then we can safely free * the structure where the shrinker is located, such as super_block * etc. */ >> + >> down_write(&shrinker_rwsem); >> if (shrinker->flags & SHRINKER_REGISTERED) { >> - list_del(&shrinker->list); >> + /* >> + * Lookups on the shrinker are over and will fail in the future, >> + * so we can now remove it from the lists and free it. >> + */ > > .... rather than here after the wait has been done and provided the > guarantee that no shrinker is running or will run again... With the above comment, how about simplifying the comment here to the following: /* * Now we can safely remove it from the shrinker_list and free it. */ Thanks, Qi > > -Dave. From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:23:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579319.907253 (Exim 4.92) (envelope-from ) id 1qTH3h-0000Qu-Ld; Tue, 08 Aug 2023 07:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579319.907253; Tue, 08 Aug 2023 07:23:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH3h-0000Qj-Hw; Tue, 08 Aug 2023 07:23:13 +0000 Received: by outflank-mailman (input) for mailman id 579319; Tue, 08 Aug 2023 07:23:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH3g-00008I-0u for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:23:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0623.outbound.protection.outlook.com [2a01:111:f400:fe0e::623]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e035360-35bc-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 09:23:11 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 07:22:56 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 07:22:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e035360-35bc-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oEl6I3Slo2ryws2bd0Uq31f3rK+9XVcz7jlrwSlsUgCO2VscmJ5/5ZfogFNbzUZl42DxXskh3JHiz2pmfq5GRXAMBtlEfRbhZh5UIgeRvr5EnrzYF065qYloDCS1iCKUbX/VCuuwzxQwfLr9PEToWaolgXqgaVUqsU20wnrmLsDUOEfCQAnnRmKSHlXNQ15PA7DHJfmxJ/0dpzovAOE2XgNZnY19vg0ilrqO+qyrLEjapgMGhXwuhZXr7LgsXb/Qkk9SYhOYEvn7dkzXaNdPJ+DfFqW+Lz8WVi0UmdFMixgaHCeZ1xi9C95IuzQ7SEJiKZBrAFvyZdlVVcejVtcLJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IsrWtmWG7rBGWqtN6Nbj9lITQcyNwJ9A8pnEseQgdPs=; b=Nj3N3aDcYnIligpdBgMFIh1wrwRjfDOa331egtUNd7r44OYCnJNmz5oMZiBSXmNpg0QJ8i0vUMsBqtZPbuF7iIDbyEa28qZ8SzwsvtMhzTwO8Z4c085qrx5m2w7BA2IBRxnGwnGSmmKgmAXVYIrLbGfOjyLsPzSLHS4HMNW8zLONW9lxkriZXcHlUz5+Cl0rwzZ/xJUqZHUdd/Pi3HLH7wUbQET/ndJk98/Nmz++Pp8Kg/QLQ8AE9UkXVIEiuiVHZ6dzjKIdUUSzaoI/F1JpLwkHk5lizgkjY5r2DGOvedu55Yr02Pns1E5erxZBWQlACrbkHQLtssO2Wvju05lqUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IsrWtmWG7rBGWqtN6Nbj9lITQcyNwJ9A8pnEseQgdPs=; b=OF1Mkd6K9a0N5BSXhN/HwktZuTZUw0p7IOAkv7G9P8eK7qw5Q6eQvlKyJFtU7OhxGxNdFavOumFyFWpmJ9QyEdIK2HAmJwofeqPIYlwlcYLeGg0n4CUWGOPFafqJRVk2UyhVjXLWGm6LIAacyWU5jP0qE2T0EA0XeFvLnh+PlpP9yTxv0cU2oZqRSvasfRQtAuqfr9QN7JGArHAvgsDTzEXsUeQYvllw/YnPwU8XSNVJmtAFi8+qtmmdBReRlkLsSATWO2MqYw/NtVq3NjGD2W+AcvjzD6LEFavQUWkmJV44mFfcuJ7G16rkCAehAUGrgpI4K+5mBMkWdOPbRdm9Aw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <17842357-d26e-3c57-25a7-76c09a8c3733@suse.com> Date: Tue, 8 Aug 2023 09:22:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3 Content-Language: en-US To: Federico Serafini Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <8536f54b708a1b3a906d14a63958c2e6dd0d034e.1691427640.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: <8536f54b708a1b3a906d14a63958c2e6dd0d034e.1691427640.git.federico.serafini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0130.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7970:EE_ X-MS-Office365-Filtering-Correlation-Id: c52a5332-0fc6-49eb-bd28-08db97e04905 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TWk3mi2LG3PHxoxbK1LYzTSO1RlFRv1oDjn+Muf5Wq1JRTIb2V4Ry6Ao9im1grXbD93ewRfPd5JuAUDbzuQv/hL5UyqBHMq1//jD2prbU+qi8u/E9gL/D29RfdPq4fH1Z0VPgI5fr2CPyYuu9+AgxApbjidivs4PbJYa6tKyxpt3S86B6ys7Z++1N+O+HKi/FR6ID4Tz11chNP1fpak9YHxx09JN5TJY6Ctix1L0z4SR39I3eA99nppR/YDIi0IJwZq7jtAPjnTzUU3AZMB8WnAnSALvWiHImwX8uwv0j2oIXTgPfOAasjGMwWcsLvyz9DpdE7R6DZggRcuN5fiq12ZoUp19RRQnQOjxXXgv/UD7IX9Vh0yTkCRWvf0hrIEfAkgPTg9U2hHACi2mgLQkD+8m8Rs7+B/JQB6S28iomYt2fl2HL/9fuCvr+8aZ5y+yWa50gJVBtAbxxZltXKuuiDYTRWwq0m3SSw/GV47ZUQFxO1MyHa6YEyNXVddsXBvWzBzDKnKDgLZp4hRcQzJ2mto0/chjA7txr5JhNpY4K3DabAyx6MXRUybjn9GzToN9ykZtjVRMnwuiVkUNw9wLMJ849u1L6Lva1GEoujJph73Y63o2blmukJEyYhwkk+zmp+u7/t1zkqbnmqOjLRI+omz99aSQA2PtLxRqNCIBUBxfwqIuToz8BWkZipcltlCVeOq+8UPUepXdzYlVg6Adxg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(136003)(396003)(376002)(1800799003)(186006)(90021799007)(451199021)(90011799007)(6486002)(478600001)(83380400001)(31686004)(2616005)(6512007)(26005)(53546011)(6506007)(8936002)(66476007)(66556008)(66946007)(316002)(41300700001)(4326008)(8676002)(4744005)(31696002)(2906002)(6916009)(36756003)(54906003)(38100700002)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2pWZnozWHJTaTFERktCWGJTcmplb2JrZnd0V1dZbjZHM0VvUTk4dFFkRWps?= =?utf-8?B?WW5CZ0NMMVpYcTBJSDBsTVFHRlhMZlFXdnAyWGM5MEVabGFYeURzSjBLRUxH?= =?utf-8?B?RzQzNEtMS243SC92ejBBZU9ONWo0cDg5TTkzVXUwTk1SYkNiaThJdXZqMXJL?= =?utf-8?B?VHY2NVpDemNNMkwwRGxEcGNBQlVqTlhraDZnQU9lcGtObXRjT2NYVHVrZEha?= =?utf-8?B?NExka0RTNExOdHZueDlYL0k4TjJQUTlKbnFaSEluWWl2SE8xNk5kcWwwOEpT?= =?utf-8?B?R0Q0cU1rQVFQQ0tzVHc0eWJMdzNnaFZETy9GR3pnNUl1UDcreWxzWXpTUUdv?= =?utf-8?B?VGV0M2JCOGZoZmtleWRaV1g2bS9zVHdNQmFSeld5WHovMHpDbUEvbGZaVm1o?= =?utf-8?B?dVRSa1pObU5VOUNhbEY3OHVBUWtDc2pkc2JaVFg0ZFpPdGQ1SWpZdU1EWmdG?= =?utf-8?B?eFBLNHVObE9yai9rQmR3YXBLMStlM09QZ3NCelUvYXpYZkNNVjcrZGMxYzJx?= =?utf-8?B?U0dIM2JNV1dyWHV4YVRoVmZKTFl1d3RwUWtvUTFWb29pbWRYS0ZQRm1wMmZO?= =?utf-8?B?NkpQVndydUlzcjRrY3gxUnZ0TzBZZzhmbFJqUTVjS0g2cW5yeDJkR2RXdzZ5?= =?utf-8?B?b1pYanlLK1VYcFBQTldDanZnWkF5UzI4ZEpCbVphRjhzK1FjU0FEWGQ5RFM1?= =?utf-8?B?ajlMazVjZ3pPcEFaMEZ3L1R5NEgwczVjZUhudUtab2RpOEsrOGRybjY3TXZl?= =?utf-8?B?VkZwS3JWRG8rcXJSVWExYi9BNVZJU1A5ZnpBSzd2VlNGYXhITDdMSExnaUg4?= =?utf-8?B?RzFNYW0wZldQTktGSTUvTW8wWDU2cFRPWURxcXNKaHZWOUpHVXhMK294OEEr?= =?utf-8?B?cHBkbDVyUy91OVNqZUFsNnFoRHFCdTNodDJEQmhySEZQY2pNcEZlU0lQVzlx?= =?utf-8?B?N2srbEVKdURnV25NakVXQ0NFclFFM2hqRTkvczdIMW5lWW1IL2FVeXB2MXpQ?= =?utf-8?B?M2t6WGlWcVRtVi9IK001N1ZzQTAxN28yVGZnYTFMWVdEVWZNYnFLQ1VlSXpO?= =?utf-8?B?S0swVFZodk1LZmVGcXlVRDY0NFJMblFibWQ5TVlybGFtaUdPSXJtZ1NweHY3?= =?utf-8?B?TEoxN0kxUEhXV09kUDBmQXFGTVJCbmFEY2NGdmE1akVXOTlvNWVacWk5Uy95?= =?utf-8?B?T0lTQ2VxdzM2SW9ENU1JeU1va1M0dXZucXRZbUZ2dUNnUXljbzVFYlhNaG5E?= =?utf-8?B?ZnIzVzRkL2ZiaEo2V1k2NFRmdmI3Y2tOamMvcE83VXkxWkZnSTVMMHVqdGpP?= =?utf-8?B?Z0xUaTFVUDlHVzZXUDBTc2FkeWFxV2p0ako5T3pPSWd0SEtneTZ3ZWZ4elQv?= =?utf-8?B?QkdubmRCcEJWaVpNeEtkUERNVkVjL0VtUzlLcHZ3RWVaN3IwSW1MRnkydjJs?= =?utf-8?B?Y0hpcFN5dHMxbnNtTkR0Q2VJMHBhaHZ6dXd2b3RXNENrSk1JaUx3UFZYV1BT?= =?utf-8?B?RG1lcTkrVzJFSEpEZWoyeEVjMjRTZEwxL1RxNEdQeW9vbFNqcENmN2lucDZ1?= =?utf-8?B?dmlsZFB3RVh0L1BhK3N5ZWI5ZndTVEJHV2M4aGlaZmpxelRnUGhxOTNxWUVw?= =?utf-8?B?VG1UaDdCY2N5b1ViYnRWTnJpN3BWcHpsTFJONTlkS3ltV1dwZXlmK0RWODYx?= =?utf-8?B?MmNsSE1ReGlrOXNad1lFdU8wNVFzZXNqbWpWQ3BsNmpJQkZKMnpZS0tZOTFS?= =?utf-8?B?MHBzNHpJSm1LTkxhMDhNcGllV1hWZVE5KzI2OERWb3k2MlBWREFnWCszRVht?= =?utf-8?B?a2ZXc2lOWjMxNmFBZ0VIQXMrTFlaY3hjcVpDYlAwQktCN2VYSWdnVnhpbVRE?= =?utf-8?B?ZXFORXVxcDNQMXFVYmNLQUVWbnlvejliU2dDbVB2NlhyclZYRHMraktLZHlM?= =?utf-8?B?U0Mvbk5SUEJrVk5zNjdDbmtCWEsxdFlpNlBaaUJxdk84WkJud2ZDWitncGJX?= =?utf-8?B?Mng1WndDdzRDMUJNMTZJOVhwcXRFNnMrU1ExNlhYMHFNdi9oazdiUWpGVVcx?= =?utf-8?B?M3dSc1I3NlJrdS9odU5tL1ZpZHpOemRXYm1BYisxcERhRnhsU1BRRzRmb3Zk?= =?utf-8?Q?Adrw+frJewxpote7DZuoOrygj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c52a5332-0fc6-49eb-bd28-08db97e04905 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 07:22:55.7855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FuSGfblazyc8fH13DJZ4WkBl7eNOBOCaUm1NEqx+Sa5X9iomLMl/TemXdFQVLmKDq7SN716cQ2JPsi5SVMw0+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970 On 07.08.2023 19:02, Federico Serafini wrote: > A missing change to the type in 'opt_arat' declaration introduced a new > violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or > function shall use the same names and type qualifiers"). > Change the type to restore the consistency between all declarations of > the object and drop a further usage of 'bool_t'. > > Fixes: 202a341f ("x86: Address violations of MISRA C:2012 by replacing bool_t uses") > Reported-by: Andrew Cooper > Signed-off-by: Federico Serafini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:27:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579334.907263 (Exim 4.92) (envelope-from ) id 1qTH7y-0001Rk-Ai; Tue, 08 Aug 2023 07:27:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579334.907263; Tue, 08 Aug 2023 07:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH7y-0001Rd-7s; Tue, 08 Aug 2023 07:27:38 +0000 Received: by outflank-mailman (input) for mailman id 579334; Tue, 08 Aug 2023 07:27:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTH7w-0001RX-C6 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:27:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0607.outbound.protection.outlook.com [2a01:111:f400:fe0c::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0aacba6f-35bd-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 09:27:34 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GV1PR04MB9199.eurprd04.prod.outlook.com (2603:10a6:150:2a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 07:27:30 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 07:27:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aacba6f-35bd-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnzI7vYF/6vtpJQ3Gdfdm5SonW9mWy+Bl103XgymBNzrrz/5qdx1azfsvXK5fGusFq+QFJKIYTKRU+iUu1q24+JSgHJ+z6Itckw/KRC8ZECx+lyU9PnDNpEPrTenrDz7trCcn5+ftdiIRtFaBViwEnyNSjuRDZUq91tvV6Emz8OwyZWyQ37zd7bU4SuUnNFkkgmAdviBnMO3vuBUC12aOKZzXb88FFOhrH1sOYLWUxIv6d5uJmuD4uB6XxR9RJGlT1szlXnfgkY6xkIh3KPxbLnn4s5UETphWmDeqKp8WHLrA6KuPi4e+W1VlCupvJwloJgi7wxYOCKFwuHMWAyK3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1CR+QH2QRjA3s8fhRSnMYrugfzzVYpsSu4bpcG0fP4=; b=buS4HUvG0RtpUSdKKKR7S+2vpPwHAW72Lpjk9AHtS1czhCH5AlDLzuXhq2r0YxX8535tfBzGdncswMigAY4HexVOOmRZvigFHQu5Or1Oz3QbmjptR3h57OciYrKjwDi8BHRBXPW5vmncMKZOb+k/Iy/jwjjo2t71HqDReOTUqpF3J9KdLkqdlGWXIXAMkpHUiNVu5uFEED/BzWepgSl1iCyV3IgQfSvvX25S50E6skw26CyjbBvONDnaC0M//d8wOUebDWQzC/IF2889lGm7yfDhlIHXcnu0iyVJnc0mEMxSJhcSkvVxSfONhTrBqyIHdRp2vW6wHHzc9bzWID+n0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1CR+QH2QRjA3s8fhRSnMYrugfzzVYpsSu4bpcG0fP4=; b=axJrtm3+9oAS9F5CkW5hJ7VZPQCg2230TiKS/L9fyhsflgfasSkPaA03m5HzPjm03vSdWZC0mPjdl6GZCIOYHSjDhBvoiJz9kV6eeN/AgFgfHYXy3Hak0D7+3VCjyUOi3YH/pzFzQlmXAoEvNjS/w4AECLmLOhQ3PW/3JbAk0tLuk9D8aQCdxBF8OG0wJ2FuNoa+AWNiH5032NzAptF5F9tMKR8/w2lWTK7Wp6Wd0ygn7/OOIow54Gjc1IIheK9RaJbV60r7lQLIH+8U5kKcxLvv/Rikjb1NcAD3HgEwDAlszMSKEPArLpw/5BXChKFTKFh7FcekmQCurp+selpRhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4722cb01-2e0a-6a12-b398-0ddd024b50bd@suse.com> Date: Tue, 8 Aug 2023 09:27:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Alexandru Isaila , Petre Pircalabu , federico.serafini@bugseng.com, tamas@tklengyel.com References: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GV1PR04MB9199:EE_ X-MS-Office365-Filtering-Correlation-Id: 21054775-db59-47ab-1d46-08db97e0ec99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 287e/WZ3Rd4lsywnxGdrrRZRceE1JjEN+wSa70zOhNGFwsTO+pM+3fi9jK5nHiVxmv2yd5HrTVtum2+ilFcwTbWiZlszXHLeJMYVp8xk0AorFguse6eIIZVuS1EPWLwEcKAN2WMzEXpx9nQLfhOuUVfhl0LtH/TPqduDDUUBuMsp7KtnTG2n/1OdRfYU7Sp1a3JzTx6VPTWvGRyDdjasODhNxbcMp/ChJ3XPPtEyxTOgaH1tR7/WTGyPVM8Zuzae5wHAoaq/xsC8WSTmsbyhuawn3MSBdCayjRZE7IjvZTcJdAFz3+O0A6wsZ8L/OUeo4ubJ7CsU2vhniJJjk4EzLPNFsvxpBFiiKPEysXzfKyXbI1K4RJGP9DMgDq0FNzLmWyKNauI8FAQU1Bersb5nqeGWrqgTmeJ1s3hnsjowTxV1bsVnyggKeROc0pN1w4z7OchYKlXLtkyQfgrQHWyyeCw+M/NnvldX/5IFilN0qj5u4ZDIRC0Y1Rv+y5MXaXWOAlAvNNT6SvkyjcydthloLPdQ7a2usaVkZ7OOwtTOjobQVCcTazHxfW7A+dOimShDXB2RCAJTzCMloIKmBpI4quGQnb9NGZM+HR3CDsMRgyAVetJ0iL0bIOUW9lcXqxpUMKe8xUBlhTFCiyyLuooxAp6iJrxyTv+j/Jn59rK4GXzw+ZK+dRpiKNK4bvQre9kxv1h4jf05z0rb+OqHSI6VUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(136003)(346002)(90021799007)(451199021)(1800799003)(186006)(90011799007)(6512007)(26005)(6506007)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(31696002)(4326008)(2906002)(6916009)(66476007)(41300700001)(66946007)(66556008)(316002)(8936002)(8676002)(478600001)(2616005)(6486002)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3plSnRHTmJuR1pQcmNxNitTT0pnR0xpUE9aSFA3YnB3Z3Ria09NVSsxS1JU?= =?utf-8?B?T0hWWEhvakZsUWNrQ3hreFlMeURzMGxRNEZLL1FvbUZRMVBXOG5KVkh6d2J0?= =?utf-8?B?ODh3R1J1Y3VKS0VlcjhVWGlRUmFCclJWbCsvQXdxRFpRVXJsZ201NkVObnpy?= =?utf-8?B?bjFjalBXSmYxek90ZjkydkJJcVB0bjFSMldKZ2prbFZZcTdCQ2w4VUhBRFVD?= =?utf-8?B?SHd4WjZCc2hrV1paU0xsUDBZS3dHWFd5RzRudnZwemlRYzZRaEdKaHVMS1FB?= =?utf-8?B?d013cHh5MUplQ1BOamNZNWdoUjhqMmp6OHNmQVcvQVdJSTRkaFBLNmtlMFNa?= =?utf-8?B?NnNWeHVLeXhOWHd4M2paRElUR003SFh4alB4Yzdvb29XdHg4ajhraXh6M2Ni?= =?utf-8?B?QVRnU2NISXBrMjd0UmlBMXhCYlE0b1RoYjd5Z2I0T2ZLWk90RTZhRXZVMU5E?= =?utf-8?B?YTkyNyt5Ris5RkNWTFRsMHUraVhyRSt5eW04dVNMZk1RSTFmVDlqU25GMjds?= =?utf-8?B?RFZBL0JOUy83dFkxYWpYQk1SejVaeVU4R1p3ZEdlTnlVQnc1TjBZT2dxUHVQ?= =?utf-8?B?bjd5aU04d1lJZ1I1elFYOURVSFc3cU9hZXd3MkdFcWt0WHl6WXJscHRlS1RT?= =?utf-8?B?S2ZoeXdqL3VKM0lKRGtacjBZVGVhTTNlcTdieFB5MlBCOVpTSm5nTkdBcGZU?= =?utf-8?B?SkduU2w2QW5MMlJnanJnODhxTFpwY3lHRTdacnY5OUtGWVF0TnBsMFRVb2J2?= =?utf-8?B?VGVtY05sTHdqYUhYdzNGQ2JQeGoxN2IvSXN6enhSVE9nL1YvZjNRL2dJMjhX?= =?utf-8?B?aUZKS3JNaUhYajhveEMwOUdlZmhIczdPbjErVWU0ZWxmclhiN25xNkpIYThP?= =?utf-8?B?YXV2YzlJc1FiQ1RXZkFqdktVNDQ5MjZMNGh0YzE2V2dxTFhhbEtwN1gzbUtq?= =?utf-8?B?dGFzRlp2eWhrVXl6cVBBYXdpcG1iaUtsYXhpVXdpVjVhMzU2UEU1eGFGQnJT?= =?utf-8?B?cWo3VGJWSlRBTmN2RmJLYVVjUEJlK2djZVVnY2Zxdm9ndk1GbCsrSXFTU3Uz?= =?utf-8?B?a2dyeThUUVFaTGZhZksvRHp6SVBmdURycXArQmFSR21pUTVib05HN1hSU1hZ?= =?utf-8?B?bVVCRFdhc1IxdzV5OEtGdndYME9WZGtGeXNEbUJqV1RHNzZqYTljdzNpbjRk?= =?utf-8?B?Z2dUeWIrUEI2TlFjeFBuMFVVRktZVDRuWXBscFZBZXI4Vm8zTFFvUWJoTHNN?= =?utf-8?B?YzVIam9CK3FnaTFVZGUxSlR1amIyMGVmZmZJd3hpZzNZdkh0bnpxdFhweXMv?= =?utf-8?B?SmZwcm85dmc5YWR1Q2QramFtLzNnd1ZNWVVFUXE5Z0hQWjJwTGljTVBvKytV?= =?utf-8?B?SWdIWlcxbTBoeFU3TkQ5dXZCZENhbWdORXVGWTZsRFNtaEUrVEVwTkNjeEsr?= =?utf-8?B?ek9JNVQ2T1AzMlhvbU5VU0laYjU4RlNvdnZ0T1VmVnowU1BROWZiYnJycnNV?= =?utf-8?B?MHB5aTg2Y1ErMUdIZlVBcUNPSi92MmVxWUR2dEhBdUF6RGppd3V6TjhKK2p5?= =?utf-8?B?OWJTdzlPU2ZmY2tJK2ZmSFcrUzM2YWYrTUZjKzhOM2lGMFpHYytLb0Fyd1ZW?= =?utf-8?B?S2I2cjVIaHBtbnF3c0RydVcxVlJTVFgwUlQ2TSs3MXRPbXVOenM4NVlJcTFa?= =?utf-8?B?SVZTRmtCdG9pZkFvenM1ME9GUHpObzVvT2xqdGVHeWNYY0lrK0NPaVgxZlFt?= =?utf-8?B?bGhTR3ZCVTFFazlDRExEMkIvZWZNRkg3bWY5OUZCYUNVT2JkeE1kczR6a0NW?= =?utf-8?B?T1U1M296d1Q4dGdQaGFCTHNsdnFEYkhyUXZMdGtabjA3YVB6VS9YeFFEV0xH?= =?utf-8?B?ZUJCbERTN2tRSk1rcWc4eTR6WjlGYzRYbzA4Ung0SDFmL0RzR3d4dEFBYXBV?= =?utf-8?B?aDRTRS8zbnVNOFJ4UDBTQ3drQTBwa09nbHpZNk5uYkJyaTRQTkE3eWM2RWZr?= =?utf-8?B?bGQyQXZJQmZqbTZYaUQ4bGdXRWdkL2NzckNGY3N3NFhKMVcvOVY3NVgwNFJ1?= =?utf-8?B?UGF1MXI0Y2xudk85YVp6SkFBcTZEdzc3WHdmNHJ6YWc5RGFTUTNtT2hNc1VP?= =?utf-8?Q?4vwI0GiYqUN2BPpVkVGaNTQCH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21054775-db59-47ab-1d46-08db97e0ec99 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 07:27:30.2620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QmnpoLTs5xJAvWDSywn+6pepvZ/82dBNBalzVrxDV5xIfEqqfUGa2ODGthNX5gqMEAEwFSwngw0FLe20B5OeNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9199 On 04.08.2023 23:39, Stefano Stabellini wrote: > Hi Tamas, > > May I have your ack on this change? I see you committed this, and there is an ack in the commit, but I can't see any ack on list (incl when checking mail archives, to exclude an issue with my mailbox). Jan > On Thu, 27 Jul 2023, Federico Serafini wrote: >> Change parameter name in monitor_domctl() declaration for >> consistency with the corresponding definition. >> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations >> of an object or function shall use the same names and type qualifiers". >> >> No functional changes. >> >> Signed-off-by: Federico Serafini > > Reviewed-by: Stefano Stabellini > > >> --- >> xen/include/xen/monitor.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h >> index 6b17a93071..713d54f7c1 100644 >> --- a/xen/include/xen/monitor.h >> +++ b/xen/include/xen/monitor.h >> @@ -27,7 +27,7 @@ >> struct domain; >> struct xen_domctl_monitor_op; >> >> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op); >> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop); >> void monitor_guest_request(void); >> >> int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req); >> -- >> 2.34.1 >> >> > From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:50:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:50:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579342.907275 (Exim 4.92) (envelope-from ) id 1qTHUD-0004oh-50; Tue, 08 Aug 2023 07:50:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579342.907275; Tue, 08 Aug 2023 07:50:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHUD-0004oa-2K; Tue, 08 Aug 2023 07:50:37 +0000 Received: by outflank-mailman (input) for mailman id 579342; Tue, 08 Aug 2023 07:50:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHUC-0004oU-6L for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:50:36 +0000 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [2607:f8b0:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 40a8ba4a-35c0-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 09:50:33 +0200 (CEST) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-55b78bf0423so522687a12.0 for ; Tue, 08 Aug 2023 00:50:33 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id u4-20020a17090a410400b00263154aab24sm7244870pjf.57.2023.08.08.00.50.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 00:50:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40a8ba4a-35c0-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1691481032; x=1692085832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wpg6aIffbYjICJhycB3Bph3fxU0UaKYZ32RPKTrhmtc=; b=FcXFQj7o5xQr1tbRw7Pn9UcrCi1B232+uajLTiNwX9TdfSjMFaRRVdHzMiOaxlryr4 TqsRZGIMtiNm6ZippcajS5s8BFNszaSa/g6yFRgc1b4Nrb+clf9RoWeRHJwEtReG4gDh LBwyybjoJjy6Q47GUlBU0hOxHJ5B5n+H+unsOBMRFGW3IeVtuYALwNVCTH0vLIY9qjFM CyLNGOebqxclIqP3q4eqEvOWKbqhuuoRiG1QYUPJbHFervGiVpOZhfBMii4BWNV8TQee jZz6YmXfb9rl1Oy5qXM+JWmVZktQ1qA2f5FKoSylWcG/GIFy7RhDcwYEdv8PeGx8L8zA uA1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691481032; x=1692085832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wpg6aIffbYjICJhycB3Bph3fxU0UaKYZ32RPKTrhmtc=; b=Hsl9IieWPdk6hsCBxKyCRb3uz+AD5z33/p0ANisaQT2HTb7eOEmKJ5m1ZzdVTe/oTm TvcMP/nzVr23BWsCuJZ+N/VmznMC/n3/YfBL+XWzqEj4zKxlGNGqmjT2qff04R0upna3 7Cf5cE75GKcCX1gmSSF+2d6L935jnjSuJNyjtfcxIRzlJS//OaJmhsxWINgZW0PsZO1B Yj1Z5lU4GwyItuxYLy7r2eqByZH6zl7qBsqLM2Zx2+rHiivzvgsuJM/aQFci/7KMeGnN FbGCOz5YCCVkE/UkrcdSgHu30LdfzgsHJybPhT4jKTHGR6/8IxFtpVcRgdCPgSAVjAIt QF7A== X-Gm-Message-State: ABy/qLa1Dqkx5nLTZ69iu9Y8xIWZWn+fPEf0YxwaFwp/kY13uoquf4ME VEcqOnJKOiyAOaw/reW8ZRSC7g== X-Google-Smtp-Source: APBJJlEd8UgUmVjTGODajLkItGQ9rG+lZy4ypLT00ATvxhzy6MYHUWJPNACQWVHeXI8Weqa+eylbDA== X-Received: by 2002:a17:90a:6c97:b0:263:730b:f568 with SMTP id y23-20020a17090a6c9700b00263730bf568mr25207579pjj.3.1691481032358; Tue, 08 Aug 2023 00:50:32 -0700 (PDT) Message-ID: <5757e341-b261-14de-e052-46606d530460@bytedance.com> Date: Tue, 8 Aug 2023 15:50:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 46/48] mm: shrinker: make memcg slab shrink lockless Content-Language: en-US To: Dave Chinner Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, simon.horman@corigine.com, dlemoal@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-47-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Dave, On 2023/8/8 10:44, Dave Chinner wrote: > On Mon, Aug 07, 2023 at 07:09:34PM +0800, Qi Zheng wrote: >> Like global slab shrink, this commit also uses refcount+RCU method to make >> memcg slab shrink lockless. > > This patch does random code cleanups amongst the actual RCU changes. > Can you please move the cleanups to a spearate patch to reduce the > noise in this one? Sure, will do. > >> diff --git a/mm/shrinker.c b/mm/shrinker.c >> index d318f5621862..fee6f62904fb 100644 >> --- a/mm/shrinker.c >> +++ b/mm/shrinker.c >> @@ -107,6 +107,12 @@ static struct shrinker_info *shrinker_info_protected(struct mem_cgroup *memcg, >> lockdep_is_held(&shrinker_rwsem)); >> } >> >> +static struct shrinker_info *shrinker_info_rcu(struct mem_cgroup *memcg, >> + int nid) >> +{ >> + return rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); >> +} > > This helper doesn't add value. It doesn't tell me that > rcu_read_lock() needs to be held when it is called, for one.... How about adding a comment or an assertion here? > >> static int expand_one_shrinker_info(struct mem_cgroup *memcg, int new_size, >> int old_size, int new_nr_max) >> { >> @@ -198,7 +204,7 @@ void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) >> struct shrinker_info_unit *unit; >> >> rcu_read_lock(); >> - info = rcu_dereference(memcg->nodeinfo[nid]->shrinker_info); >> + info = shrinker_info_rcu(memcg, nid); > > ... whilst the original code here was obviously correct. > >> unit = info->unit[shriner_id_to_index(shrinker_id)]; >> if (!WARN_ON_ONCE(shrinker_id >= info->map_nr_max)) { >> /* Pairs with smp mb in shrink_slab() */ >> @@ -211,7 +217,7 @@ void set_shrinker_bit(struct mem_cgroup *memcg, int nid, int shrinker_id) >> >> static DEFINE_IDR(shrinker_idr); >> >> -static int prealloc_memcg_shrinker(struct shrinker *shrinker) >> +static int shrinker_memcg_alloc(struct shrinker *shrinker) > > Cleanups in a separate patch. OK. > >> @@ -253,10 +258,15 @@ static long xchg_nr_deferred_memcg(int nid, struct shrinker *shrinker, >> { >> struct shrinker_info *info; >> struct shrinker_info_unit *unit; >> + long nr_deferred; >> >> - info = shrinker_info_protected(memcg, nid); >> + rcu_read_lock(); >> + info = shrinker_info_rcu(memcg, nid); >> unit = info->unit[shriner_id_to_index(shrinker->id)]; >> - return atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); >> + nr_deferred = atomic_long_xchg(&unit->nr_deferred[shriner_id_to_offset(shrinker->id)], 0); >> + rcu_read_unlock(); >> + >> + return nr_deferred; >> } > > This adds two rcu_read_lock() sections to every call to > do_shrink_slab(). It's not at all clear ifrom any of the other code > that do_shrink_slab() now has internal rcu_read_lock() sections.... The xchg_nr_deferred_memcg() will only be called in shrink_slab_memcg(), so other code doesn't need to know that information? > >> @@ -464,18 +480,23 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, >> if (!mem_cgroup_online(memcg)) >> return 0; >> >> - if (!down_read_trylock(&shrinker_rwsem)) >> - return 0; >> - >> - info = shrinker_info_protected(memcg, nid); >> +again: >> + rcu_read_lock(); >> + info = shrinker_info_rcu(memcg, nid); >> if (unlikely(!info)) >> goto unlock; >> >> - for (; index < shriner_id_to_index(info->map_nr_max); index++) { >> + if (index < shriner_id_to_index(info->map_nr_max)) { >> struct shrinker_info_unit *unit; >> >> unit = info->unit[index]; >> >> + /* >> + * The shrinker_info_unit will not be freed, so we can >> + * safely release the RCU lock here. >> + */ >> + rcu_read_unlock(); > > Why - what guarantees that the shrinker_info_unit exists at this > point? We hold no reference to it, we hold no reference to any > shrinker, etc. What provides this existence guarantee? The shrinker_info_unit is never freed unless the memcg is destroyed. Here we hold the refcount of this memcg (mem_cgroup_iter() --> css_tryget()), so the shrinker_info_unit will not be freed. > >> + >> for_each_set_bit(offset, unit->map, SHRINKER_UNIT_BITS) { >> struct shrink_control sc = { >> .gfp_mask = gfp_mask, >> @@ -485,12 +506,14 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, >> struct shrinker *shrinker; >> int shrinker_id = calc_shrinker_id(index, offset); >> >> + rcu_read_lock(); >> shrinker = idr_find(&shrinker_idr, shrinker_id); >> - if (unlikely(!shrinker || !(shrinker->flags & SHRINKER_REGISTERED))) { >> - if (!shrinker) >> - clear_bit(offset, unit->map); >> + if (unlikely(!shrinker || !shrinker_try_get(shrinker))) { >> + clear_bit(offset, unit->map); >> + rcu_read_unlock(); >> continue; >> } >> + rcu_read_unlock(); >> >> /* Call non-slab shrinkers even though kmem is disabled */ >> if (!memcg_kmem_online() && >> @@ -523,15 +546,20 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, >> set_shrinker_bit(memcg, nid, shrinker_id); >> } >> freed += ret; >> - >> - if (rwsem_is_contended(&shrinker_rwsem)) { >> - freed = freed ? : 1; >> - goto unlock; >> - } >> + shrinker_put(shrinker); > > Ok, so why is this safe to call without holding the rcu read lock? > The global shrinker has to hold the rcu_read_lock() whilst calling > shrinker_put() to guarantee the validity of the list next pointer, > but we don't hold off RCU here so what guarantees a racing global > shrinker walk doesn't trip over this shrinker_put() call dropping > the refcount to zero and freeing occuring in a different context... This will not be a problem, even if shrinker::refcount is reduced to 0 here, the racing global shrinker walk already holds the rcu lock. shrink_slab shrink_slab_memcg =========== ================= rcu_read_lock() shrinker_put() shrinker_put() And in shrink_slab_memcg(), the shrinker is not required to traverse the next bit in the shrinker_info_unit::map, so there is no need to hold the rcu lock to ensure the existence of this shrinker. > > >> + /* >> + * We have already exited the read-side of rcu critical section >> + * before calling do_shrink_slab(), the shrinker_info may be >> + * released in expand_one_shrinker_info(), so reacquire the >> + * shrinker_info. >> + */ >> + index++; >> + goto again; > > With that, what makes the use of shrinker_info in > xchg_nr_deferred_memcg() in do_shrink_slab() coherent and valid? Holding rcu lock can ensure that the old shrinker_info will not be freed, and the shrinker_info_unit::nr_deferred can also be indexed from the old shrinker_info::unit[x], so the updated nr_deferred will not be lost. Thanks, Qi > > -Dave. From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:54:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:54:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579347.907287 (Exim 4.92) (envelope-from ) id 1qTHYL-0005OX-OR; Tue, 08 Aug 2023 07:54:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579347.907287; Tue, 08 Aug 2023 07:54:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHYL-0005OQ-JC; Tue, 08 Aug 2023 07:54:53 +0000 Received: by outflank-mailman (input) for mailman id 579347; Tue, 08 Aug 2023 07:54:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHYL-0005OK-0I for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:54:53 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20606.outbound.protection.outlook.com [2a01:111:f400:fe12::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da0f57a6-35c0-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 09:54:50 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8850.eurprd04.prod.outlook.com (2603:10a6:20b:42d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 07:54:47 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 07:54:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da0f57a6-35c0-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OKO3yTvpEzSxgeJqSkA/WsJif4rlpy5oqOH/TSuPvAfE1zhL5wo1A5E5v9eR1j2A3jr35PUDxH/YNCvsPv0K4pnk0UBFNlCGxZ4xlPUN1LLwZ2jnUzXXDu2vkpj5nrvXlghJRkxcVBybnKuqEGQMSL8HwhaqfPVwmaaxAuH174leubD/dlq6KBkmbfsUAhz0fvSvqOFKcccK0vAs0Bc//vYv4qij7QICcR4QE+Q1G5NOl5il9UuTY/XJeOK/Xc52Slchg1mUn3mP+9iHOotj6JoiNxmkIH3kaD5gkAEYsgL6GsuGYm6G9/Dno6jGd1t2Fs0rztUII6UZs2VLoQm9EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jOr0By17pAHE2B7BMnGWJAufSS89hXto64ugIguYhGM=; b=AJ/4QLqRGvTlKny09HQeNOMoetSyepJt1wDUgpwn6YRAkKiSEmpc1EBrWrx+fTIswLXrB6kxXd041R7Xbb8F3dmZyL59EZULKz7tBqGVRlfhXZ6wxM7ZauLl6D9c9tpgdgAyHiHbEKsBfoBvyn54xhUEJIWgLYPv1rcWD6Rb1EMxab6OmtBPltAQcdgLS9NSjUIeOg4iqUQXYx/wXBiybBDfKGOvvvqyVxQScnk6VVE8qsG95+fbajm57nCcNQ487krQGLuqdDEVL6VRcMUjpAYbqgU5LnO33ZorSZG51wB5839WE55SnmBVNRsnqnOy7lVDYfC/d1BBjo9OEpmT4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jOr0By17pAHE2B7BMnGWJAufSS89hXto64ugIguYhGM=; b=y9R7W5dkU7vPYr0MMPjd9+T+i0s9/Zaowx+TFItV3AdhLlORA0mdgeQIRaEbdjdbCta62OTiHRvygUBri2x83nkCUxghUU/Pg21LSjQTUPJNGTEmKfEFsZz7Hf8Gs4oBdFjFbOpY0K616BTLykXdYwHCWgxk8/hgGR1ypvPrP1z7M4o2PrHlECq7/JjbuaS1str1fOKusWMQV9H/2TY1Mg7RGJSNAxB+/cwZdmEDfzIh8eVr0clZOubM6et41/3YQvDSCYOYWP2J/DBZR8rI+68Pbfmji1hx8EBl6hJNJ2i69p0qqopcK/j8yeEqo58LxENtXN2pIM5AH5dbJCDHHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <504749e9-1782-f031-e015-d36c538e80cc@suse.com> Date: Tue, 8 Aug 2023 09:54:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] xen/IOMMU: Switch bool_t to bool Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel , Paul Durrant , Julien Grall , Stefano Stabellini References: <20230807165830.6719-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230807165830.6719-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8850:EE_ X-MS-Office365-Filtering-Correlation-Id: 66a1f2df-f691-4ce9-2f6a-08db97e4bca2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: //CPBsDvPyzRndaxBxt4nEFszG554b76Jkp9yrSkmbwAhLRJjJn94Axvo3ujjRtV6svVdsMEtfD9G0Tp06V8bTYVNc6SEqI44TfSDTQuKAEwApmJ2HTRB6b2CBWc2mJsmfvYg5MJW6G8RW8oIkGRD8A2lixV1sZ1PLXNMeThM8xigDi9nfPYF/8KkcF57nVMZdCtDfjTfw3Lv3pn3+YJUu0DHkksatrNFHkqciGAeOaTcjvCQAMj1aYhSmuL4DbMNQgjkojICcwbwk7bq2wJ0ljLjA5PaycPjZ0ITB/hCWnQCeFMSvsPDUJ1tnrfMXd6begQBFPGNhqKKHZGpklEEzfgF4sHf5uZazSQpmcLJ6NvhhCophwaYU6BYUy4q9bKW5SPAbjaeY8vmlXHezGLyxy3rNfnY3uuyLhn5JT7QCmczgZqjODIVSydO3nGNUY3+HiE7KKrx2st1aRe8AIyj3ZIfh/tMSKApenYnCTAEicAGJst8klaA8/6AVStwh0iTGl1ovtmq49mfds8HIaBD0ex1GNg4X6R6TovJ5EB28VqMBFMg6GbC/cRWVAhaSHWTWvonhVXh4zFydejHB64yKYT0EMOcS6CfVXVqCX0Mkh4j/GEdWjwtZoAGDW+Xv7xdSTRdpIhh5qmdEFsCy7kYY56GZ7TA36mt4KsR3BjQTG4ygi68mItU0ZspsFqbYGswxuA9DOIGrvcE3o2/HmT4ZHMYwb7//tXLbg/H+aFfGbIQpKc3f4NkFYebBJoaOl3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199021)(90011799007)(90021799007)(186006)(1800799003)(2616005)(36756003)(6512007)(4326008)(316002)(86362001)(6916009)(54906003)(38100700002)(66946007)(478600001)(66476007)(66556008)(31696002)(6486002)(53546011)(6506007)(41300700001)(26005)(8676002)(8936002)(2906002)(30864003)(83380400001)(5660300002)(31686004)(45980500001)(43740500002)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmRrcSs3cU5KRTltQmZTSzYwZEFCUkorM0N5eHpmdzlKUTRLQmFIUSsyeGVN?= =?utf-8?B?b2NwV3VwL0VhRk0wMTVjNndTaGFDNVhsUmJ3ZTZYOXhJK0xYRE5tS3hsL3R4?= =?utf-8?B?SU1VcHQ2a2xFQWM1OXRuWHo0L3cybjdmTmo4MVRrVXQ0eXBkV3h6SDhjVm1y?= =?utf-8?B?VFd5VGhWRXJRTjVlbkJMczRrVUl0MWpVbXFpRHpUOWlSYXU0VTlKRHY2ZHFC?= =?utf-8?B?UkQ1WUFkbzV0ZmhZbU83VFkwemxIVy81Rit0TkNaRy9XRExvaVRXRGFGUXJ4?= =?utf-8?B?bGJaUTYwMGxraTJSMytlSFpsRVRXN3lLcHZLbGlaK0lnOE5nclBHMlV6M0t4?= =?utf-8?B?bUMvS29BYjJxQTdadU1VNStmQnFqaXZEK2tGMUtDMHJPaE1ITXVva3ExRDNr?= =?utf-8?B?Uk9QL0VFYjlXRjQ0R2F4aDRqR2F2Y25IV1hZUUFCQVdJcDhPSmxuR3Y4d0M5?= =?utf-8?B?Y2RuclQrMFVrT0dUNzZ4enAxMG00RTdJRThIcmRVeFdWQlVnMkV6V0JYZjlQ?= =?utf-8?B?NlcrOHltU3QwY2MvNzZ1NHAxekZpV1RCTXNyZWs0RnkwL29GNlVMTlhCWWVj?= =?utf-8?B?Ukc4aDJRR1JhTTBaZjBFK0JJVU04czlVUE93a1pwNWRVRVEvTGtwNEJ5M1Nx?= =?utf-8?B?ZGN3eUYxOVZHM01qNEJGTmlDak5FMnNUS0F5Y0FuSjRDL1VoZmh5NnhKSktt?= =?utf-8?B?dENXV1NDc0ZWN3VCVXZpWVBObEtSOEJJOTdRK2M4dnJVWHZhUDlGVUFqc1Vu?= =?utf-8?B?L21tVWoycWZpd2QyTFpSVklkOEhOMjRyZFJBUm83SXZLdlRqR3J0d3d0a2xN?= =?utf-8?B?SkFhZTNGNXVnMWlPUUR0NHhDRFFiTHFBQ1REN1RJdElBNkRCcCs4STNIRTh2?= =?utf-8?B?UUVlWmRpb3lIUEE2U0JkNitGN2cvWnk4M0Z3bkV3SkZ6SWlweWdRenpTVWkx?= =?utf-8?B?OW9aaFl0QUs2eFNkMFpsbWtTNjB1d3E3Yi93SWJCeVhhbXZPSXR2emt1TjZt?= =?utf-8?B?S2FWMlRORi94YmJnSjZmVU5hM1dxTUVGeGpITWpKaVFmSEdjVFBMck81V3dG?= =?utf-8?B?NDVjS09rZ2gzQWFHV05uT0lVWGxrb2xkdUhRSEhFZkJDaWpOTTdpN2lWc0t0?= =?utf-8?B?Q0NYY3p0bGdLZUFMaW9xWDdtMnluM1p2Vnc1M1paWkplc0RxdEdFWUYyYnVr?= =?utf-8?B?RHRKVzdDV3hXUVA3endZMDlpL2g4K1dDUjhFU2RqSTRuczdHZE5CZHRVdG5l?= =?utf-8?B?anNmN3Q4VVR6Z1BWNGRXM1F3eEw0d2Vyalo3VWphV1liUFR2eUZrTUxScDNT?= =?utf-8?B?M0kxM0dqSlpVeGhpTlZVbVoxSWxhUWp3SDBkblNBeGdyWlVkSitPRURiekgx?= =?utf-8?B?RHBjRDllQmR5Qm1CNThLR1dlb0NlQU1HWk1WNTNWQUFoejgwb0puSlZ6NHNq?= =?utf-8?B?bHMvOWYrb3ZsK2VnRk03SGNwNTFTcG1PcDlTcmxmMW5sM1RIWVdXVkpUSjEv?= =?utf-8?B?UzAyeGxoYTB1bzE4YldtZ2FlTzFnWXk0R2ZOcFNDY21nRHkrcys3enJJL3Y4?= =?utf-8?B?NHh0OWE0YXBTdG5ZbzdqUG4zOGR6TVAvNzNkelozTDNJSy9XYTdmNHFudVVL?= =?utf-8?B?SEJoY3NzZnArZUZLQnlDaHVqNTZuOFNJdkVybTIybHk4endTVGJTNHo3YzJB?= =?utf-8?B?UXMwbitZaHFScHJySmUxalVsNkcxZzVHNllYTHhZOCttc0NBZkJiaFE1Q2ZQ?= =?utf-8?B?UFNaZlorT3I5TnNUa0laUHlpZktuZEdGOWZMVXhQR0Y0dzF1ZlptUDU5MzBI?= =?utf-8?B?ZHJiRHdlMVFraXlDS0ltS0RDYnlnbVJNUHg0UHBPMFNVY0tPNXFBU0M3S3I2?= =?utf-8?B?a0Nzay9Ya21RNUtpVzhyZzdOL2VOM1V4Z2l0akNxdmdmUDZUUEdLSHc4S2h0?= =?utf-8?B?WHBZZ1Y2VSt2YS9UK1N1RE9ITnZuWlFMRlVaSzFGY0JQYnhVTWZmS01QdFhH?= =?utf-8?B?RHRkdnF1TnRucXU3MkFrc1ZDb1ZPTU1nTG9PYkZKbXhzaEY0bG8zM2c5d3I0?= =?utf-8?B?dzFWTnJidkFlYTc2TkY4VGdXVmphSG02R0lWZmFYeGw0SFpaZVZqZmR1bXQx?= =?utf-8?Q?zZrmUJny5TR5Xlc+FnUe7yjDu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66a1f2df-f691-4ce9-2f6a-08db97e4bca2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 07:54:47.7481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AFpRzurN8Q9x8KIoxg0XuaufFF2X6H0ACWdHf6MnvQJ8oOp/dLg8rukSpmCFOjPz1BnSxFYwNT4I/nF70XY2VA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8850 On 07.08.2023 18:58, Andrew Cooper wrote: > ... as part of cleaning up the types used. Minor style cleanup on some > altered lines. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > --- > xen/drivers/passthrough/amd/iommu.h | 4 ++-- > xen/drivers/passthrough/amd/iommu_acpi.c | 6 +++--- > xen/drivers/passthrough/amd/iommu_init.c | 6 +++--- > xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- > xen/drivers/passthrough/ats.c | 2 +- > xen/drivers/passthrough/ats.h | 2 +- > xen/drivers/passthrough/device_tree.c | 4 ++-- This will want a DEVICE TREE ack; Cc-ing respective maintainers here (and therefore preserving full context). > xen/drivers/passthrough/iommu.c | 8 ++++---- > xen/drivers/passthrough/pci.c | 16 ++++++++-------- For these and ats.? you would also have wanted to Cc Paul. Jan > xen/drivers/passthrough/vtd/dmar.c | 6 +++---> xen/drivers/passthrough/vtd/extern.h | 6 +++--- > xen/drivers/passthrough/vtd/iommu.c | 18 +++++++++--------- > xen/drivers/passthrough/vtd/qinval.c | 2 +- > xen/drivers/passthrough/vtd/quirks.c | 8 ++++---- > xen/drivers/passthrough/vtd/x86/ats.c | 2 +- > xen/include/xen/iommu.h | 6 +++--- > 16 files changed, 49 insertions(+), 49 deletions(-) > > diff --git a/xen/drivers/passthrough/amd/iommu.h b/xen/drivers/passthrough/amd/iommu.h > index 5429ada58ef5..acbaad30d564 100644 > --- a/xen/drivers/passthrough/amd/iommu.h > +++ b/xen/drivers/passthrough/amd/iommu.h > @@ -174,7 +174,7 @@ struct guest_iommu { > > struct domain *domain; > spinlock_t lock; > - bool_t enabled; > + bool enabled; > > struct guest_dev_table dev_table; > struct guest_buffer cmd_buffer; > @@ -194,7 +194,7 @@ struct guest_iommu { > struct guest_iommu_msi msi; > }; > > -extern bool_t iommuv2_enabled; > +extern bool iommuv2_enabled; > > struct acpi_ivrs_hardware; > > diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c > index 3b577c9b390c..891c6c6ddde2 100644 > --- a/xen/drivers/passthrough/amd/iommu_acpi.c > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c > @@ -1063,14 +1063,14 @@ static unsigned int __initdata nr_ivmd; > #define to_ivmd_block(hdr) \ > container_of(hdr, const struct acpi_ivrs_memory, header) > > -static inline bool_t is_ivhd_block(u8 type) > +static inline bool is_ivhd_block(u8 type) > { > return (type == ACPI_IVRS_TYPE_HARDWARE || > ((amd_iommu_acpi_info & ACPI_IVRS_EFR_SUP) && > type == ACPI_IVRS_TYPE_HARDWARE_11H)); > } > > -static inline bool_t is_ivmd_block(u8 type) > +static inline bool is_ivmd_block(u8 type) > { > return (type == ACPI_IVRS_TYPE_MEMORY_ALL || > type == ACPI_IVRS_TYPE_MEMORY_ONE || > @@ -1102,7 +1102,7 @@ static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) > const struct acpi_ivrs_header *ivrs_block; > unsigned long length; > unsigned int apic, i; > - bool_t sb_ioapic = !iommu_intremap; > + bool sb_ioapic = !iommu_intremap; > int error = 0; > > BUG_ON(!table); > diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c > index af6713d2fc02..41ec38bb72eb 100644 > --- a/xen/drivers/passthrough/amd/iommu_init.c > +++ b/xen/drivers/passthrough/amd/iommu_init.c > @@ -34,7 +34,7 @@ unsigned int __read_mostly ivrs_bdf_entries; > u8 __read_mostly ivhd_type; > static struct radix_tree_root ivrs_maps; > LIST_HEAD_READ_MOSTLY(amd_iommu_head); > -bool_t iommuv2_enabled; > +bool iommuv2_enabled; > > bool __ro_after_init amd_iommu_perdev_intremap = true; > > @@ -737,7 +737,7 @@ static void cf_check iommu_interrupt_handler( > tasklet_schedule(&amd_iommu_irq_tasklet); > } > > -static bool_t __init set_iommu_interrupt_handler(struct amd_iommu *iommu) > +static bool __init set_iommu_interrupt_handler(struct amd_iommu *iommu) > { > int irq, ret; > > @@ -1329,7 +1329,7 @@ static int __init cf_check amd_iommu_setup_device_table( > } > > /* Check whether SP5100 SATA Combined mode is on */ > -static bool_t __init amd_sp5100_erratum28(void) > +static bool __init amd_sp5100_erratum28(void) > { > u32 bus, id; > u16 vendor_id, dev_id; > diff --git a/xen/drivers/passthrough/amd/pci_amd_iommu.c b/xen/drivers/passthrough/amd/pci_amd_iommu.c > index 94e37755064b..f7f9f4e5423a 100644 > --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c > +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c > @@ -28,7 +28,7 @@ > /* dom_io is used as a sentinel for quarantined devices */ > #define QUARANTINE_SKIP(d, p) ((d) == dom_io && !(p)->arch.amd.root_table) > > -static bool_t __read_mostly init_done; > +static bool __read_mostly init_done; > > static const struct iommu_init_ops _iommu_init_ops; > > diff --git a/xen/drivers/passthrough/ats.c b/xen/drivers/passthrough/ats.c > index 7f7b16dc490c..253f5c2e1042 100644 > --- a/xen/drivers/passthrough/ats.c > +++ b/xen/drivers/passthrough/ats.c > @@ -18,7 +18,7 @@ > #include > #include "ats.h" > > -bool_t __read_mostly ats_enabled = 0; > +bool __read_mostly ats_enabled; > boolean_param("ats", ats_enabled); > > int enable_ats_device(struct pci_dev *pdev, struct list_head *ats_list) > diff --git a/xen/drivers/passthrough/ats.h b/xen/drivers/passthrough/ats.h > index c202f4ecdd67..baa5f6a6dc04 100644 > --- a/xen/drivers/passthrough/ats.h > +++ b/xen/drivers/passthrough/ats.h > @@ -22,7 +22,7 @@ > #define ATS_QUEUE_DEPTH_MASK 0x1f > #define ATS_ENABLE (1<<15) > > -extern bool_t ats_enabled; > +extern bool ats_enabled; > > int enable_ats_device(struct pci_dev *pdev, struct list_head *ats_list); > void disable_ats_device(struct pci_dev *pdev); > diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c > index 1c32d7b50cce..3c0322c7973d 100644 > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -83,9 +83,9 @@ int iommu_deassign_dt_device(struct domain *d, struct dt_device_node *dev) > return rc; > } > > -static bool_t iommu_dt_device_is_assigned(const struct dt_device_node *dev) > +static bool iommu_dt_device_is_assigned(const struct dt_device_node *dev) > { > - bool_t assigned = 0; > + bool assigned = false; > > if ( !dt_device_is_protected(dev) ) > return 0; > diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c > index 7bbe3889a214..f9a9f53dbd44 100644 > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -29,7 +29,7 @@ bool __initdata iommu_enable = 1; > bool __read_mostly iommu_enabled; > bool __read_mostly force_iommu; > bool __read_mostly iommu_verbose; > -static bool_t __read_mostly iommu_crash_disable; > +static bool __read_mostly iommu_crash_disable; > > #define IOMMU_quarantine_none 0 /* aka false */ > #define IOMMU_quarantine_basic 1 /* aka true */ > @@ -59,7 +59,7 @@ bool __read_mostly iommu_hap_pt_share = true; > > bool __read_mostly iommu_debug; > > -DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb); > +DEFINE_PER_CPU(bool, iommu_dont_flush_iotlb); > > static int __init cf_check parse_iommu_param(const char *s) > { > @@ -548,7 +548,7 @@ static int __init iommu_quarantine_init(void) > int __init iommu_setup(void) > { > int rc = -ENODEV; > - bool_t force_intremap = force_iommu && iommu_intremap; > + bool force_intremap = force_iommu && iommu_intremap; > > if ( iommu_hwdom_strict ) > iommu_hwdom_passthrough = false; > @@ -672,7 +672,7 @@ int iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt) > return iommu_call(ops, get_reserved_device_memory, func, ctxt); > } > > -bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) > +bool iommu_has_feature(struct domain *d, enum iommu_feature feature) > { > return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); > } > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 33452791a8e0..ed1f689227fa 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -62,7 +62,7 @@ void pcidevs_unlock(void) > spin_unlock_recursive(&_pcidevs_lock); > } > > -bool_t pcidevs_locked(void) > +bool pcidevs_locked(void) > { > return !!spin_is_locked(&_pcidevs_lock); > } > @@ -74,7 +74,7 @@ static inline struct pci_seg *get_pseg(u16 seg) > return radix_tree_lookup(&pci_segments, seg); > } > > -bool_t pci_known_segment(u16 seg) > +bool pci_known_segment(u16 seg) > { > return get_pseg(seg) != NULL; > } > @@ -984,7 +984,7 @@ int find_upstream_bridge(u16 seg, u8 *bus, u8 *devfn, u8 *secbus) > return ret; > } > > -bool_t __init pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func) > +bool __init pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func) > { > u32 vendor; > > @@ -1181,7 +1181,7 @@ static int hest_match_pci(const struct acpi_hest_aer_common *p, > p->function == PCI_FUNC(pdev->devfn); > } > > -static bool_t hest_match_type(const struct acpi_hest_header *hest_hdr, > +static bool hest_match_type(const struct acpi_hest_header *hest_hdr, > const struct pci_dev *pdev) > { > unsigned int pos = pci_find_cap_offset(pdev->seg, pdev->bus, > @@ -1207,10 +1207,10 @@ static bool_t hest_match_type(const struct acpi_hest_header *hest_hdr, > > struct aer_hest_parse_info { > const struct pci_dev *pdev; > - bool_t firmware_first; > + bool firmware_first; > }; > > -static bool_t hest_source_is_pcie_aer(const struct acpi_hest_header *hest_hdr) > +static bool hest_source_is_pcie_aer(const struct acpi_hest_header *hest_hdr) > { > if ( hest_hdr->type == ACPI_HEST_TYPE_AER_ROOT_PORT || > hest_hdr->type == ACPI_HEST_TYPE_AER_ENDPOINT || > @@ -1224,7 +1224,7 @@ static int cf_check aer_hest_parse( > { > struct aer_hest_parse_info *info = data; > const struct acpi_hest_aer_common *p; > - bool_t ff; > + bool ff; > > if ( !hest_source_is_pcie_aer(hest_hdr) ) > return 0; > @@ -1254,7 +1254,7 @@ static int cf_check aer_hest_parse( > return 0; > } > > -bool_t pcie_aer_get_firmware_first(const struct pci_dev *pdev) > +bool pcie_aer_get_firmware_first(const struct pci_dev *pdev) > { > struct aer_hest_parse_info info = { .pdev = pdev }; > > diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c > index 4936c20952ec..07772f178fe6 100644 > --- a/xen/drivers/passthrough/vtd/dmar.c > +++ b/xen/drivers/passthrough/vtd/dmar.c > @@ -149,7 +149,7 @@ struct vtd_iommu *ioapic_to_iommu(unsigned int apic_id) > return NULL; > } > > -static bool_t acpi_hpet_device_match( > +static bool acpi_hpet_device_match( > struct list_head *list, unsigned int hpet_id) > { > struct acpi_hpet_unit *hpet; > @@ -1052,14 +1052,14 @@ void acpi_dmar_zap(void) > write_atomic((uint32_t*)&dmar_table->signature[0], sig); > } > > -bool_t platform_supports_intremap(void) > +bool platform_supports_intremap(void) > { > const unsigned int mask = ACPI_DMAR_INTR_REMAP; > > return (dmar_flags & mask) == ACPI_DMAR_INTR_REMAP; > } > > -bool_t __init platform_supports_x2apic(void) > +bool __init platform_supports_x2apic(void) > { > const unsigned int mask = ACPI_DMAR_INTR_REMAP | ACPI_DMAR_X2APIC_OPT_OUT; > > diff --git a/xen/drivers/passthrough/vtd/extern.h b/xen/drivers/passthrough/vtd/extern.h > index d49e40c5ce7d..667590ee52df 100644 > --- a/xen/drivers/passthrough/vtd/extern.h > +++ b/xen/drivers/passthrough/vtd/extern.h > @@ -26,7 +26,7 @@ > #define VTDPREFIX "[VT-D]" > > struct pci_ats_dev; > -extern bool_t rwbf_quirk; > +extern bool rwbf_quirk; > extern const struct iommu_init_ops intel_iommu_init_ops; > > void print_iommu_regs(struct acpi_drhd_unit *drhd); > @@ -111,7 +111,7 @@ int __must_check me_wifi_quirk(struct domain *domain, uint8_t bus, > void pci_vtd_quirk(const struct pci_dev *); > void quirk_iommu_caps(struct vtd_iommu *iommu); > > -bool_t platform_supports_intremap(void); > -bool_t platform_supports_x2apic(void); > +bool platform_supports_intremap(void); > +bool platform_supports_x2apic(void); > > #endif // _VTD_EXTERN_H_ > diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c > index 0e3062c820f9..d34c98d9c773 100644 > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -644,8 +644,8 @@ static int __must_check iommu_flush_iotlb_global(struct vtd_iommu *iommu, > } > > static int __must_check iommu_flush_iotlb_dsi(struct vtd_iommu *iommu, u16 did, > - bool_t flush_non_present_entry, > - bool_t flush_dev_iotlb) > + bool flush_non_present_entry, > + bool flush_dev_iotlb) > { > int status; > > @@ -663,8 +663,8 @@ static int __must_check iommu_flush_iotlb_dsi(struct vtd_iommu *iommu, u16 did, > > static int __must_check iommu_flush_iotlb_psi(struct vtd_iommu *iommu, u16 did, > u64 addr, unsigned int order, > - bool_t flush_non_present_entry, > - bool_t flush_dev_iotlb) > + bool flush_non_present_entry, > + bool flush_dev_iotlb) > { > int status; > > @@ -694,7 +694,7 @@ static int __must_check iommu_flush_all(void) > { > struct acpi_drhd_unit *drhd; > struct vtd_iommu *iommu; > - bool_t flush_dev_iotlb; > + bool flush_dev_iotlb; > int rc = 0; > > flush_local(FLUSH_CACHE); > @@ -736,7 +736,7 @@ static int __must_check cf_check iommu_flush_iotlb(struct domain *d, dfn_t dfn, > struct domain_iommu *hd = dom_iommu(d); > struct acpi_drhd_unit *drhd; > struct vtd_iommu *iommu; > - bool_t flush_dev_iotlb; > + bool flush_dev_iotlb; > int iommu_domid; > int ret = 0; > > @@ -1480,7 +1480,7 @@ int domain_context_mapping_one( > uint16_t seg = iommu->drhd->segment, prev_did = 0; > struct domain *prev_dom = NULL; > int rc, ret; > - bool_t flush_dev_iotlb; > + bool flush_dev_iotlb; > > if ( QUARANTINE_SKIP(domain, pgd_maddr) ) > return 0; > @@ -1874,7 +1874,7 @@ int domain_context_unmap_one( > struct context_entry *context, *context_entries; > u64 maddr; > int iommu_domid, rc, ret; > - bool_t flush_dev_iotlb; > + bool flush_dev_iotlb; > > ASSERT(pcidevs_locked()); > spin_lock(&iommu->lock); > @@ -2873,7 +2873,7 @@ static int cf_check intel_iommu_assign_device( > if ( rmrr->segment == seg && bdf == PCI_BDF(bus, devfn) && > rmrr->scope.devices_cnt > 1 ) > { > - bool_t relaxed = !!(flag & XEN_DOMCTL_DEV_RDM_RELAXED); > + bool relaxed = flag & XEN_DOMCTL_DEV_RDM_RELAXED; > > printk(XENLOG_GUEST "%s" VTDPREFIX > " It's %s to assign %pp" > diff --git a/xen/drivers/passthrough/vtd/qinval.c b/xen/drivers/passthrough/vtd/qinval.c > index 4f9ad136b9c5..036f3e850544 100644 > --- a/xen/drivers/passthrough/vtd/qinval.c > +++ b/xen/drivers/passthrough/vtd/qinval.c > @@ -152,7 +152,7 @@ static int __must_check queue_invalidate_iotlb_sync(struct vtd_iommu *iommu, > > static int __must_check queue_invalidate_wait(struct vtd_iommu *iommu, > u8 iflag, u8 sw, u8 fn, > - bool_t flush_dev_iotlb) > + bool flush_dev_iotlb) > { > static DEFINE_PER_CPU(uint32_t, poll_slot); > unsigned int index; > diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c > index fcc8f73e8b90..5d706a539788 100644 > --- a/xen/drivers/passthrough/vtd/quirks.c > +++ b/xen/drivers/passthrough/vtd/quirks.c > @@ -56,9 +56,9 @@ static unsigned int snb_igd_timeout; > > static u32 __read_mostly ioh_id; > static u32 __initdata igd_id; > -bool_t __read_mostly rwbf_quirk; > -static bool_t __read_mostly is_cantiga_b3; > -static bool_t __read_mostly is_snb_gfx; > +bool __read_mostly rwbf_quirk; > +static bool __read_mostly is_cantiga_b3; > +static bool __read_mostly is_snb_gfx; > static u8 *__read_mostly igd_reg_va; > static spinlock_t igd_lock; > > @@ -498,7 +498,7 @@ void pci_vtd_quirk(const struct pci_dev *pdev) > int seg = pdev->seg; > int bus = pdev->bus; > int pos; > - bool_t ff; > + bool ff; > u32 val, val2; > u64 bar; > paddr_t pa; > diff --git a/xen/drivers/passthrough/vtd/x86/ats.c b/xen/drivers/passthrough/vtd/x86/ats.c > index 04d702b1d6b1..9de419775f90 100644 > --- a/xen/drivers/passthrough/vtd/x86/ats.c > +++ b/xen/drivers/passthrough/vtd/x86/ats.c > @@ -119,7 +119,7 @@ int dev_invalidate_iotlb(struct vtd_iommu *iommu, u16 did, > > list_for_each_entry_safe( pdev, temp, &iommu->ats_devices, ats.list ) > { > - bool_t sbit; > + bool sbit; > int rc = 0; > > switch ( type ) > diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h > index 110693c59fe8..0e33ff79684b 100644 > --- a/xen/include/xen/iommu.h > +++ b/xen/include/xen/iommu.h > @@ -46,7 +46,7 @@ static inline dfn_t dfn_add(dfn_t dfn, unsigned long i) > return _dfn(dfn_x(dfn) + i); > } > > -static inline bool_t dfn_eq(dfn_t x, dfn_t y) > +static inline bool dfn_eq(dfn_t x, dfn_t y) > { > return dfn_x(x) == dfn_x(y); > } > @@ -193,7 +193,7 @@ enum iommu_feature > IOMMU_FEAT_count > }; > > -bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature); > +bool iommu_has_feature(struct domain *d, enum iommu_feature feature); > > #ifdef CONFIG_HAS_PCI > struct pirq; > @@ -409,7 +409,7 @@ void iommu_dev_iotlb_flush_timeout(struct domain *d, struct pci_dev *pdev); > * iommu_iotlb_flush/iommu_iotlb_flush_all will be explicitly called by > * the caller. > */ > -DECLARE_PER_CPU(bool_t, iommu_dont_flush_iotlb); > +DECLARE_PER_CPU(bool, iommu_dont_flush_iotlb); > > extern struct spinlock iommu_pt_cleanup_lock; > extern struct page_list_head iommu_pt_cleanup_list; From xen-devel-bounces@lists.xenproject.org Tue Aug 08 07:58:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 07:58:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579356.907296 (Exim 4.92) (envelope-from ) id 1qTHbW-00064L-9j; Tue, 08 Aug 2023 07:58:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579356.907296; Tue, 08 Aug 2023 07:58:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHbW-00064E-6c; Tue, 08 Aug 2023 07:58:10 +0000 Received: by outflank-mailman (input) for mailman id 579356; Tue, 08 Aug 2023 07:58:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHbV-000648-Cy for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 07:58:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHbQ-0004oz-86; Tue, 08 Aug 2023 07:58:04 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTHbP-0004q8-Ru; Tue, 08 Aug 2023 07:58:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=MkAvYxPF5O5PUVW2zj0seh+ME1qdF6hK2yx1CWIRDgk=; b=w4CYa7kPMf5d2SRxA1WuczJS46 eA+lBFNcl5NB9d349qJvKQ3PjIETCZPcGV0yLPrIv4UIh8/yaCQfiRSCWpvHbGKyjpizmKpRe73Ho EEaopvj0jQ67V0pz86WzLpjJXC3ToJdGXN4mHUr0bYjtlVlbGjYZhINqm+T/d0QXWQhw=; Message-ID: Date: Tue, 8 Aug 2023 08:58:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] mm: Factor out the pdx compression logic in ma/va converters Content-Language: en-GB To: Jan Beulich , Alejandro Vallejo Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Xen-devel References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-3-alejandro.vallejo@cloud.com> <64d11b39.050a0220.2ab40.c2cc@mx.google.com> <825bb94c-a427-62ff-a790-39c0792553d3@suse.com> From: Julien Grall In-Reply-To: <825bb94c-a427-62ff-a790-39c0792553d3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 08/08/2023 07:05, Jan Beulich wrote: > On 07.08.2023 18:26, Alejandro Vallejo wrote: >> On Mon, Jul 31, 2023 at 05:15:19PM +0200, Jan Beulich wrote: >>> Especially since the names of the helper functions are longish, >>> I'm afraid I'm not fully convinced of the transformation. >> In what sense? If it's just naming style I'm happy to consider other names, >> but taking compression logic out of non-pdx code is essential to removing >> compiling it out. > > I understand that, but my dislike for long names of functions doing > basic transformations remains. I'm afraid I have no good alternative > suggestion, though, and while it's been a long time, this may also > have been one reason why I didn't go with helpers back at the time. > > Plus of course I remain unconvinced that compiling out really is the > better option compared to patching out, as was done by my series. I am with Alejandro here. The altpatching is more complex and would likely require arch specific code. I don't exactly see the benefits of such approach given that are no known x86 platform where PDX might be useful. Even for Arm, I am not aware of a platform where PDX could be disabled. I agree this could change in the future, but this could be revisit if needed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:00:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579368.907317 (Exim 4.92) (envelope-from ) id 1qTHdi-00085Q-KX; Tue, 08 Aug 2023 08:00:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579368.907317; Tue, 08 Aug 2023 08:00:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdi-000834-EQ; Tue, 08 Aug 2023 08:00:26 +0000 Received: by outflank-mailman (input) for mailman id 579368; Tue, 08 Aug 2023 08:00:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdh-0007uw-K5 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:00:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a03ca1b7-35c1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:00:23 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07D3F1424; Tue, 8 Aug 2023 01:01:05 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1F5613F6C4; Tue, 8 Aug 2023 01:00:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a03ca1b7-35c1-11ee-8613-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Michal Orzel Subject: [PATCH 1/5] arm/gicv2: make GICv2 driver and vGICv2 optional Date: Tue, 8 Aug 2023 09:00:06 +0100 Message-Id: <20230808080010.3858575-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808080010.3858575-1-luca.fancellu@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that compiles the Generic Interrupt Controller v2 emulation for domains, it is required only when using GICv2 driver, otherwise using the GICv3 driver it is optional and can be deselected if the user doesn't want to offer the v2 emulation to domains or maybe its GICv3 hardware can't offer the GICv2 compatible mode. Signed-off-by: Luca Fancellu Reviewed-by: Julien Grall Reviewed-by: Michal Orzel --- xen/arch/arm/Kconfig | 19 +++++++++++++++++++ xen/arch/arm/Makefile | 4 ++-- xen/arch/arm/domain_build.c | 4 ++++ xen/arch/arm/gic-v3.c | 4 ++++ xen/arch/arm/vgic.c | 2 ++ xen/arch/arm/vgic/Makefile | 4 ++-- 6 files changed, 33 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index fd57a82dd284..03ec1247ad4c 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -78,6 +78,14 @@ config ARM_EFI UEFI firmware. A UEFI stub is provided to allow Xen to be booted as an EFI application. +config GICV2 + bool "GICv2 driver" + default y + select VGICV2 + help + Driver for the ARM Generic Interrupt Controller v2. + If unsure, say Y + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC @@ -92,11 +100,22 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +config VGICV2 + bool "vGICv2 interface for domains" + default y + help + Allow Xen to expose a Generic Interrupt Controller version 2 like to Xen + domains. This can be configured at the domain creation. + This option is mandatory when using GICv2. + For GICv3, this allows domain to use GICv2 when the hardware supports it. + If unsure say Y. + config HVM def_bool y config NEW_VGIC bool "Use new VGIC implementation" + select GICV2 ---help--- This is an alternative implementation of the ARM GIC interrupt diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 7bf07e992046..81c31c36fc3d 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -22,7 +22,7 @@ obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += efi/ obj-y += gic.o -obj-y += gic-v2.o +obj-$(CONFIG_GICV2) += gic-v2.o obj-$(CONFIG_GICV3) += gic-v3.o obj-$(CONFIG_HAS_ITS) += gic-v3-its.o obj-$(CONFIG_HAS_ITS) += gic-v3-lpi.o @@ -57,7 +57,7 @@ obj-$(CONFIG_NEW_VGIC) += vgic/ ifneq ($(CONFIG_NEW_VGIC),y) obj-y += gic-vgic.o obj-y += vgic.o -obj-y += vgic-v2.o +obj-$(CONFIG_VGICV2) += vgic-v2.o obj-$(CONFIG_GICV3) += vgic-v3.o obj-$(CONFIG_HAS_ITS) += vgic-v3-its.o endif diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 39b4ee03a505..b2b609eb0c2d 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2775,6 +2775,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, return res; } +#ifdef CONFIG_VGICV2 static int __init make_gicv2_domU_node(struct kernel_info *kinfo) { void *fdt = kinfo->fdt; @@ -2826,6 +2827,7 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo) return res; } +#endif #ifdef CONFIG_GICV3 static int __init make_gicv3_domU_node(struct kernel_info *kinfo) @@ -2901,8 +2903,10 @@ static int __init make_gic_domU_node(struct kernel_info *kinfo) case GIC_V3: return make_gicv3_domU_node(kinfo); #endif +#ifdef CONFIG_VGICV2 case GIC_V2: return make_gicv2_domU_node(kinfo); +#endif default: panic("Unsupported GIC version\n"); } diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 95e4f020febe..d18a3317ccc4 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1334,6 +1334,7 @@ static paddr_t __initdata dbase = INVALID_PADDR; static paddr_t __initdata vbase = INVALID_PADDR, vsize = 0; static paddr_t __initdata cbase = INVALID_PADDR, csize = 0; +#ifdef CONFIG_VGICV2 /* If the GICv3 supports GICv2, initialize it */ static void __init gicv3_init_v2(void) { @@ -1359,6 +1360,9 @@ static void __init gicv3_init_v2(void) vgic_v2_setup_hw(dbase, cbase, csize, vbase, 0); } +#else +static inline void gicv3_init_v2(void) { } +#endif static void __init gicv3_ioremap_distributor(paddr_t dist_paddr) { diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 97d6f6106638..86fa8bc7e894 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -95,10 +95,12 @@ int domain_vgic_register(struct domain *d, int *mmio_count) return -ENODEV; break; #endif +#ifdef CONFIG_VGICV2 case GIC_V2: if ( vgic_v2_init(d, mmio_count) ) return -ENODEV; break; +#endif default: printk(XENLOG_G_ERR "d%d: Unknown vGIC version %u\n", d->domain_id, d->arch.vgic.version); diff --git a/xen/arch/arm/vgic/Makefile b/xen/arch/arm/vgic/Makefile index 806826948e20..60cbf7f2f94a 100644 --- a/xen/arch/arm/vgic/Makefile +++ b/xen/arch/arm/vgic/Makefile @@ -1,5 +1,5 @@ obj-y += vgic.o -obj-y += vgic-v2.o +obj-$(CONFIG_VGICV2) += vgic-v2.o obj-y += vgic-mmio.o -obj-y += vgic-mmio-v2.o +obj-$(CONFIG_VGICV2) += vgic-mmio-v2.o obj-y += vgic-init.o -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:00:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579366.907306 (Exim 4.92) (envelope-from ) id 1qTHdi-0007xn-2n; Tue, 08 Aug 2023 08:00:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579366.907306; Tue, 08 Aug 2023 08:00:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdh-0007xg-Vd; Tue, 08 Aug 2023 08:00:25 +0000 Received: by outflank-mailman (input) for mailman id 579366; Tue, 08 Aug 2023 08:00:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdg-0007uw-UX for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:00:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 9f626118-35c1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:00:21 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E477139F; Tue, 8 Aug 2023 01:01:03 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBC293F6C4; Tue, 8 Aug 2023 01:00:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f626118-35c1-11ee-8613-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/5] Fine granular configuration Date: Tue, 8 Aug 2023 09:00:05 +0100 Message-Id: <20230808080010.3858575-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This serie aims to add more modularity to some feature that can be excluded without issues from the build. The first patch is already reviewed. Luca Fancellu (5): arm/gicv2: make GICv2 driver and vGICv2 optional xen/arm: Add asm/domain.h include to kernel.h arm/dom0less: put dom0less feature code in a separate module xen/arm: Move static memory build code in separate modules arm/dom0less: introduce Kconfig for dom0less feature xen/arch/arm/Kconfig | 28 + xen/arch/arm/Makefile | 7 +- xen/arch/arm/bootfdt.c | 161 +- xen/arch/arm/dom0less-build.c | 1086 ++++++ xen/arch/arm/domain_build.c | 4096 ++++++--------------- xen/arch/arm/efi/efi-boot.h | 4 + xen/arch/arm/gic-v3.c | 4 + xen/arch/arm/include/asm/dom0less-build.h | 35 + xen/arch/arm/include/asm/domain_build.h | 33 + xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/setup.h | 1 - xen/arch/arm/include/asm/static-memory.h | 50 + xen/arch/arm/include/asm/static-shmem.h | 72 + xen/arch/arm/setup.c | 58 +- xen/arch/arm/static-memory.c | 294 ++ xen/arch/arm/static-shmem.c | 515 +++ xen/arch/arm/vgic.c | 2 + xen/arch/arm/vgic/Makefile | 4 +- 18 files changed, 3357 insertions(+), 3094 deletions(-) create mode 100644 xen/arch/arm/dom0less-build.c create mode 100644 xen/arch/arm/include/asm/dom0less-build.h create mode 100644 xen/arch/arm/include/asm/static-memory.h create mode 100644 xen/arch/arm/include/asm/static-shmem.h create mode 100644 xen/arch/arm/static-memory.c create mode 100644 xen/arch/arm/static-shmem.c -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:00:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579367.907313 (Exim 4.92) (envelope-from ) id 1qTHdi-0007zq-DR; Tue, 08 Aug 2023 08:00:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579367.907313; Tue, 08 Aug 2023 08:00:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdi-0007yc-5e; Tue, 08 Aug 2023 08:00:26 +0000 Received: by outflank-mailman (input) for mailman id 579367; Tue, 08 Aug 2023 08:00:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdh-0007xV-FJ for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:00:25 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a10e1a25-35c1-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:00:24 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E38D143D; Tue, 8 Aug 2023 01:01:06 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B195F3F6C4; Tue, 8 Aug 2023 01:00:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a10e1a25-35c1-11ee-b280-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h Date: Tue, 8 Aug 2023 09:00:07 +0100 Message-Id: <20230808080010.3858575-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808080010.3858575-1-luca.fancellu@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add asm/domain.h that is defining the type 'enum domain_type', it is needed on arm64 build where this type is used for a member of the structure kernel_info. Fixes: 66e994a5e74f ("xen: arm64: add guest type to domain field.") Signed-off-by: Luca Fancellu --- xen/arch/arm/include/asm/kernel.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index 4617cdc83bac..0a23e86c2d37 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -7,6 +7,7 @@ #define __ARCH_ARM_KERNEL_H__ #include +#include #include /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:00:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:00:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579369.907336 (Exim 4.92) (envelope-from ) id 1qTHdm-0000P9-Se; Tue, 08 Aug 2023 08:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579369.907336; Tue, 08 Aug 2023 08:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdm-0000Ox-Ox; Tue, 08 Aug 2023 08:00:30 +0000 Received: by outflank-mailman (input) for mailman id 579369; Tue, 08 Aug 2023 08:00:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdl-0007xV-11 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:00:29 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id a22e377b-35c1-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:00:26 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 409DD1480; Tue, 8 Aug 2023 01:01:08 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A8823F6C4; Tue, 8 Aug 2023 01:00:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a22e377b-35c1-11ee-b280-6b7b168915f2 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/5] arm/dom0less: put dom0less feature code in a separate module Date: Tue, 8 Aug 2023 09:00:08 +0100 Message-Id: <20230808080010.3858575-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808080010.3858575-1-luca.fancellu@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the dom0less feature code is mostly inside domain_build.c and setup.c, it is a feature that may not be useful to everyone so put the code in a different compilation module in order to make it easier to disable the feature in the future. Move gic_interrupt_t in domain_build.h to use it with the function declaration, move its comment above the declaration. The following functions are now visible externally from domain_build because they are used also from the dom0less-build module: - get_allocation_size - set_interrupt - domain_fdt_begin_node - make_memory_node - make_resv_memory_node - make_hypervisor_node - make_psci_node - make_cpus_node - make_timer_node - handle_device_interrupts - construct_domain The following function were static in domain_build but they are now externally visible and moved to dom0less-build module because they are used from both modules: - process_shm - make_shm_memory_node Move init_staticmem_pages and is_dom0less_mode from setup.c to dom0less-build.c and make them externally visible so that they can be used from outside. No functional change is intended. Signed-off-by: Luca Fancellu --- xen/arch/arm/Makefile | 1 + xen/arch/arm/dom0less-build.c | 1728 +++++++++ xen/arch/arm/domain_build.c | 4096 ++++++--------------- xen/arch/arm/include/asm/dom0less-build.h | 30 + xen/arch/arm/include/asm/domain_build.h | 33 + xen/arch/arm/include/asm/setup.h | 1 - xen/arch/arm/setup.c | 57 +- 7 files changed, 3016 insertions(+), 2930 deletions(-) create mode 100644 xen/arch/arm/dom0less-build.c create mode 100644 xen/arch/arm/include/asm/dom0less-build.h diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 81c31c36fc3d..70dd7201ef30 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -15,6 +15,7 @@ obj-y += cpufeature.o obj-y += decode.o obj-y += device.o obj-$(CONFIG_IOREQ_SERVER) += dm.o +obj-y += dom0less-build.init.o obj-y += domain.o obj-y += domain_build.init.o obj-$(CONFIG_ARCH_MAP_DOMAIN_PAGE) += domain_page.o diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c new file mode 100644 index 000000000000..9159837924de --- /dev/null +++ b/xen/arch/arm/dom0less-build.c @@ -0,0 +1,1728 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/dom0less-build.c + * + * Code related to the dom0less functionality + * + * Copyright (C) 2023 Arm Ltd. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +/* Static memory initialization */ +void __init init_staticmem_pages(void) +{ +#ifdef CONFIG_STATIC_MEMORY + unsigned int bank; + + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) + { + mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); + unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); + mfn_t bank_end = mfn_add(bank_start, bank_pages); + + if ( mfn_x(bank_end) <= mfn_x(bank_start) ) + return; + + unprepare_staticmem_pages(mfn_to_page(bank_start), + bank_pages, false); + } + } +#endif +} + +bool __init is_dom0less_mode(void) +{ + struct bootmodules *mods = &bootinfo.modules; + struct bootmodule *mod; + unsigned int i; + bool dom0found = false; + bool domUfound = false; + + /* Look into the bootmodules */ + for ( i = 0 ; i < mods->nr_mods ; i++ ) + { + mod = &mods->module[i]; + /* Find if dom0 and domU kernels are present */ + if ( mod->kind == BOOTMOD_KERNEL ) + { + if ( mod->domU == false ) + { + dom0found = true; + break; + } + else + domUfound = true; + } + } + + /* + * If there is no dom0 kernel but at least one domU, then we are in + * dom0less mode + */ + return ( !dom0found && domUfound ); +} + +static bool __init allocate_bank_memory(struct domain *d, + struct kernel_info *kinfo, + gfn_t sgfn, + paddr_t tot_size) +{ + int res; + struct page_info *pg; + struct membank *bank; + unsigned int max_order = ~0; + + /* + * allocate_bank_memory can be called with a tot_size of zero for + * the second memory bank. It is not an error and we can safely + * avoid creating a zero-size memory bank. + */ + if ( tot_size == 0 ) + return true; + + bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; + bank->start = gfn_to_gaddr(sgfn); + bank->size = tot_size; + + while ( tot_size > 0 ) + { + unsigned int order = get_allocation_size(tot_size); + + order = min(max_order, order); + + pg = alloc_domheap_pages(d, order, 0); + if ( !pg ) + { + /* + * If we can't allocate one page, then it is unlikely to + * succeed in the next iteration. So bail out. + */ + if ( !order ) + return false; + + /* + * If we can't allocate memory with order, then it is + * unlikely to succeed in the next iteration. + * Record the order - 1 to avoid re-trying. + */ + max_order = order - 1; + continue; + } + + res = guest_physmap_add_page(d, sgfn, page_to_mfn(pg), order); + if ( res ) + { + dprintk(XENLOG_ERR, "Failed map pages to DOMU: %d", res); + return false; + } + + sgfn = gfn_add(sgfn, 1UL << order); + tot_size -= (1ULL << (PAGE_SHIFT + order)); + } + + kinfo->mem.nr_banks++; + kinfo->unassigned_mem -= bank->size; + + return true; +} + +static void __init allocate_memory(struct domain *d, struct kernel_info *kinfo) +{ + unsigned int i; + paddr_t bank_size; + + printk(XENLOG_INFO "Allocating mappings totalling %ldMB for %pd:\n", + /* Don't want format this as PRIpaddr (16 digit hex) */ + (unsigned long)(kinfo->unassigned_mem >> 20), d); + + kinfo->mem.nr_banks = 0; + bank_size = MIN(GUEST_RAM0_SIZE, kinfo->unassigned_mem); + if ( !allocate_bank_memory(d, kinfo, gaddr_to_gfn(GUEST_RAM0_BASE), + bank_size) ) + goto fail; + + bank_size = MIN(GUEST_RAM1_SIZE, kinfo->unassigned_mem); + if ( !allocate_bank_memory(d, kinfo, gaddr_to_gfn(GUEST_RAM1_BASE), + bank_size) ) + goto fail; + + if ( kinfo->unassigned_mem ) + goto fail; + + for( i = 0; i < kinfo->mem.nr_banks; i++ ) + { + printk(XENLOG_INFO "%pd BANK[%d] %#"PRIpaddr"-%#"PRIpaddr" (%ldMB)\n", + d, + i, + kinfo->mem.bank[i].start, + kinfo->mem.bank[i].start + kinfo->mem.bank[i].size, + /* Don't want format this as PRIpaddr (16 digit hex) */ + (unsigned long)(kinfo->mem.bank[i].size >> 20)); + } + + return; + +fail: + panic("Failed to allocate requested domain memory." + /* Don't want format this as PRIpaddr (16 digit hex) */ + " %ldKB unallocated. Fix the VMs configurations.\n", + (unsigned long)kinfo->unassigned_mem >> 10); +} + +#ifdef CONFIG_STATIC_MEMORY +static bool __init append_static_memory_to_bank(struct domain *d, + struct membank *bank, + mfn_t smfn, + paddr_t size) +{ + int res; + unsigned int nr_pages = PFN_DOWN(size); + gfn_t sgfn; + + /* + * For direct-mapped domain, the GFN match the MFN. + * Otherwise, this is inferred on what has already been allocated + * in the bank. + */ + if ( !is_domain_direct_mapped(d) ) + sgfn = gaddr_to_gfn(bank->start + bank->size); + else + sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); + + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); + if ( res ) + { + dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); + return false; + } + + bank->size = bank->size + size; + + return true; +} + +static mfn_t __init acquire_static_memory_bank(struct domain *d, + const __be32 **cell, + u32 addr_cells, u32 size_cells, + paddr_t *pbase, paddr_t *psize) +{ + mfn_t smfn; + int res; + + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); + ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); + if ( PFN_DOWN(*psize) > UINT_MAX ) + { + printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr, + d, *psize); + return INVALID_MFN; + } + + smfn = maddr_to_mfn(*pbase); + res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + return INVALID_MFN; + } + + return smfn; +} + +static int __init parse_static_mem_prop(const struct dt_device_node *node, + u32 *addr_cells, u32 *size_cells, + int *length, const __be32 **cell) +{ + const struct dt_property *prop; + + prop = dt_find_property(node, "xen,static-mem", NULL); + + *addr_cells = dt_n_addr_cells(node); + *size_cells = dt_n_size_cells(node); + + *cell = (const __be32 *)prop->value; + *length = prop->length; + + return 0; +} + +/* Allocate memory from static memory as RAM for one specific domain d. */ +static void __init allocate_static_memory(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + u32 addr_cells, size_cells, reg_cells; + unsigned int nr_banks, gbank, bank = 0; + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; + const __be32 *cell; + u64 tot_size = 0; + paddr_t pbase, psize, gsize; + mfn_t smfn; + int length; + + if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) + goto fail; + reg_cells = addr_cells + size_cells; + + /* + * The static memory will be mapped in the guest at the usual guest memory + * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by + * xen/include/public/arch-arm.h. + */ + gbank = 0; + gsize = ramsize[gbank]; + kinfo->mem.bank[gbank].start = rambase[gbank]; + nr_banks = length / (reg_cells * sizeof (u32)); + + for ( ; bank < nr_banks; bank++ ) + { + smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, + &pbase, &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + goto fail; + + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", + d, bank, pbase, pbase + psize); + + while ( 1 ) + { + /* Map as much as possible the static range to the guest bank */ + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, + min(psize, gsize)) ) + goto fail; + + /* + * The current physical bank is fully mapped. + * Handle the next physical bank. + */ + if ( gsize >= psize ) + { + gsize = gsize - psize; + break; + } + /* + * When current guest bank is not enough to map, exhaust + * the current one and seek to the next. + * Before seeking to the next, check if we still have available + * guest bank. + */ + else if ( (gbank + 1) >= GUEST_RAM_BANKS ) + { + printk(XENLOG_ERR "Exhausted all possible guest banks.\n"); + goto fail; + } + else + { + psize = psize - gsize; + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); + /* Update to the next guest bank. */ + gbank++; + gsize = ramsize[gbank]; + kinfo->mem.bank[gbank].start = rambase[gbank]; + } + } + + tot_size += psize; + } + + kinfo->mem.nr_banks = ++gbank; + + kinfo->unassigned_mem -= tot_size; + /* + * The property 'memory' should match the amount of memory given to the + * guest. + * Currently, it is only possible to either acquire static memory or let + * Xen allocate. *Mixing* is not supported. + */ + if ( kinfo->unassigned_mem ) + { + printk(XENLOG_ERR + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n"); + goto fail; + } + + return; + + fail: + panic("Failed to allocate requested static memory for domain %pd.\n", d); +} + +/* + * Allocate static memory as RAM for one specific domain d. + * The static memory will be directly mapped in the guest(Guest Physical + * Address == Physical Address). + */ +static void __init assign_static_memory_11(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + u32 addr_cells, size_cells, reg_cells; + unsigned int nr_banks, bank = 0; + const __be32 *cell; + paddr_t pbase, psize; + mfn_t smfn; + int length; + + if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) + { + printk(XENLOG_ERR + "%pd: failed to parse \"xen,static-mem\" property.\n", d); + goto fail; + } + reg_cells = addr_cells + size_cells; + nr_banks = length / (reg_cells * sizeof(u32)); + + if ( nr_banks > NR_MEM_BANKS ) + { + printk(XENLOG_ERR + "%pd: exceed max number of supported guest memory banks.\n", d); + goto fail; + } + + for ( ; bank < nr_banks; bank++ ) + { + smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, + &pbase, &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + goto fail; + + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", + d, bank, pbase, pbase + psize); + + /* One guest memory bank is matched with one physical memory bank. */ + kinfo->mem.bank[bank].start = pbase; + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[bank], + smfn, psize) ) + goto fail; + + kinfo->unassigned_mem -= psize; + } + + kinfo->mem.nr_banks = nr_banks; + + /* + * The property 'memory' should match the amount of memory given to + * the guest. + * Currently, it is only possible to either acquire static memory or + * let Xen allocate. *Mixing* is not supported. + */ + if ( kinfo->unassigned_mem != 0 ) + { + printk(XENLOG_ERR + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); + goto fail; + } + + return; + + fail: + panic("Failed to assign requested static memory for direct-map domain %pd.\n", + d); +} +#else /* !CONFIG_STATIC_MEMORY */ +static void __init allocate_static_memory(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + ASSERT_UNREACHABLE(); +} + +static void __init assign_static_memory_11(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + ASSERT_UNREACHABLE(); +} +#endif /* CONFIG_STATIC_MEMORY */ + +#ifdef CONFIG_STATIC_SHM +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned int bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( (pbase == bank_start) && (psize == bank_size) ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + + return 0; +} + +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + struct domain *d; + + page = maddr_to_page(pbase); + d = page_get_owner_and_reference(page); + if ( d == NULL ) + return false; + put_page(page); + + if ( d != dom_io ) + { + printk(XENLOG_ERR + "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", + d); + return false; + } + + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + unsigned long nr_pfns; + int res; + + /* + * Pages of statically shared memory shall be included + * into domain_tot_pages(). + */ + nr_pfns = PFN_DOWN(psize); + if ( (UINT_MAX - d->max_pages) < nr_pfns ) + { + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", + d, nr_pfns); + return INVALID_MFN; + } + d->max_pages += nr_pfns; + + smfn = maddr_to_mfn(pbase); + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + d->max_pages -= nr_pfns; + return INVALID_MFN; + } + + return smfn; +} + +static int __init assign_shared_memory(struct domain *d, + uint32_t addr_cells, uint32_t size_cells, + paddr_t pbase, paddr_t psize, + paddr_t gbase) +{ + mfn_t smfn; + int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; + + printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, pbase, psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need + * to create mapping in the P2M. + */ + nr_pages = PFN_DOWN(psize); + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, + PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + /* + * Get the right amount of references per page, which is the number of + * borrower domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of letting borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + * So if the borrower is created first, it will cause adding pages + * in the P2M without reference. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); + return ret; +} + +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + const char *shm_id) +{ + if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); + kinfo->shm_mem.nr_banks++; + + return 0; +} + +int __init process_shm(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + + dt_for_each_child_node(node, shm_node) + { + const struct dt_property *prop; + const __be32 *cells; + uint32_t addr_cells, size_cells; + paddr_t gbase, pbase, psize; + int ret = 0; + unsigned int i; + const char *role_str; + const char *shm_id; + bool owner_dom_io = true; + + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + /* + * xen,shared-mem = ; + * TODO: pbase is optional. + */ + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + BUG_ON(!prop); + cells = (const __be32 *)prop->value; + device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); + psize = dt_read_paddr(cells, size_cells); + if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, pbase, gbase); + return -EINVAL; + } + if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, psize); + return -EINVAL; + } + + for ( i = 0; i < PFN_DOWN(psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) + { + printk("%pd: invalid physical address 0x%"PRI_mfn"\n", + d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + + if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) + { + printk("%pd: invalid \"xen,shm-id\" property", d); + return -EINVAL; + } + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + + /* + * DOMID_IO is a fake domain and is not described in the Device-Tree. + * Therefore when the owner of the shared region is DOMID_IO, we will + * only find the borrowers. + */ + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) + { + /* + * We found the first borrower of the region, the owner was not + * specified, so they should be assigned to dom_io. + */ + ret = assign_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); + if ( ret ) + return ret; + } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; + } + + return 0; +} + +int __init make_shm_memory_node(const struct domain *d, void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + unsigned int i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + const char compat[] = "xen,shared-memory-v1"; + /* Worst case addrcells + sizecells */ + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + res = domain_fdt_begin_node(fdt, "xen-shmem", mem->bank[i].start); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); + if ( res ) + return res; + + /* + * TODO: + * - xen,offset: (borrower VMs only) + * 64 bit integer offset within the owner virtual machine's shared + * memory region used for the mapping in the borrower VM + */ + res = fdt_property_u64(fdt, "xen,offset", 0); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else /* !CONFIG_STATIC_SHM */ +int __init make_shm_memory_node(const struct domain *d, void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); + return -EOPNOTSUPP; +} +#endif /* CONFIG_STATIC_SHM */ + +#ifdef CONFIG_VGICV2 +static int __init make_gicv2_domU_node(struct kernel_info *kinfo) +{ + void *fdt = kinfo->fdt; + int res = 0; + __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2]; + __be32 *cells; + const struct domain *d = kinfo->d; + + res = domain_fdt_begin_node(fdt, "interrupt-controller", + vgic_dist_base(&d->arch.vgic)); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", 3); + if ( res ) + return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", "arm,gic-400"); + if ( res ) + return res; + + cells = ®[0]; + dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + vgic_dist_base(&d->arch.vgic), GUEST_GICD_SIZE); + dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + vgic_cpu_base(&d->arch.vgic), GUEST_GICC_SIZE); + + res = fdt_property(fdt, "reg", reg, sizeof(reg)); + if (res) + return res; + + res = fdt_property_cell(fdt, "linux,phandle", kinfo->phandle_gic); + if (res) + return res; + + res = fdt_property_cell(fdt, "phandle", kinfo->phandle_gic); + if (res) + return res; + + res = fdt_end_node(fdt); + + return res; +} +#endif + +#ifdef CONFIG_GICV3 +static int __init make_gicv3_domU_node(struct kernel_info *kinfo) +{ + void *fdt = kinfo->fdt; + int res = 0; + __be32 *reg, *cells; + const struct domain *d = kinfo->d; + unsigned int i, len = 0; + + res = domain_fdt_begin_node(fdt, "interrupt-controller", + vgic_dist_base(&d->arch.vgic)); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#interrupt-cells", 3); + if ( res ) + return res; + + res = fdt_property(fdt, "interrupt-controller", NULL, 0); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", "arm,gic-v3"); + if ( res ) + return res; + + /* reg specifies all re-distributors and Distributor. */ + len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * + (d->arch.vgic.nr_regions + 1) * sizeof(__be32); + reg = xmalloc_bytes(len); + if ( reg == NULL ) + return -ENOMEM; + cells = reg; + + dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + vgic_dist_base(&d->arch.vgic), GUEST_GICV3_GICD_SIZE); + + for ( i = 0; i < d->arch.vgic.nr_regions; i++ ) + dt_child_set_range(&cells, + GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + d->arch.vgic.rdist_regions[i].base, + d->arch.vgic.rdist_regions[i].size); + + res = fdt_property(fdt, "reg", reg, len); + xfree(reg); + if (res) + return res; + + res = fdt_property_cell(fdt, "linux,phandle", kinfo->phandle_gic); + if (res) + return res; + + res = fdt_property_cell(fdt, "phandle", kinfo->phandle_gic); + if (res) + return res; + + res = fdt_end_node(fdt); + + return res; +} +#endif + +static int __init make_gic_domU_node(struct kernel_info *kinfo) +{ + switch ( kinfo->d->arch.vgic.version ) + { +#ifdef CONFIG_GICV3 + case GIC_V3: + return make_gicv3_domU_node(kinfo); +#endif +#ifdef CONFIG_VGICV2 + case GIC_V2: + return make_gicv2_domU_node(kinfo); +#endif + default: + panic("Unsupported GIC version\n"); + } +} + +#ifdef CONFIG_SBSA_VUART_CONSOLE +static int __init make_vpl011_uart_node(struct kernel_info *kinfo) +{ + void *fdt = kinfo->fdt; + int res; + gic_interrupt_t intr; + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; + __be32 *cells; + struct domain *d = kinfo->d; + + res = domain_fdt_begin_node(fdt, "sbsa-uart", d->arch.vpl011.base_addr); + if ( res ) + return res; + + res = fdt_property_string(fdt, "compatible", "arm,sbsa-uart"); + if ( res ) + return res; + + cells = ®[0]; + dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, + GUEST_ROOT_SIZE_CELLS, d->arch.vpl011.base_addr, + GUEST_PL011_SIZE); + + res = fdt_property(fdt, "reg", reg, sizeof(reg)); + if ( res ) + return res; + + set_interrupt(intr, d->arch.vpl011.virq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH); + + res = fdt_property(fdt, "interrupts", intr, sizeof (intr)); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "interrupt-parent", + kinfo->phandle_gic); + if ( res ) + return res; + + /* Use a default baud rate of 115200. */ + fdt_property_u32(fdt, "current-speed", 115200); + + res = fdt_end_node(fdt); + if ( res ) + return res; + + return 0; +} +#endif + +/* + * Scan device tree properties for passthrough specific information. + * Returns < 0 on error + * 0 on success + */ +static int __init handle_passthrough_prop(struct kernel_info *kinfo, + const struct fdt_property *xen_reg, + const struct fdt_property *xen_path, + bool xen_force, + uint32_t address_cells, uint32_t size_cells) +{ + const __be32 *cell; + unsigned int i, len; + struct dt_device_node *node; + int res; + paddr_t mstart, size, gstart; + + /* xen,reg specifies where to map the MMIO region */ + cell = (const __be32 *)xen_reg->data; + len = fdt32_to_cpu(xen_reg->len) / ((address_cells * 2 + size_cells) * + sizeof(uint32_t)); + + for ( i = 0; i < len; i++ ) + { + device_tree_get_reg(&cell, address_cells, size_cells, + &mstart, &size); + gstart = dt_next_cell(address_cells, &cell); + + if ( gstart & ~PAGE_MASK || mstart & ~PAGE_MASK || size & ~PAGE_MASK ) + { + printk(XENLOG_ERR + "DomU passthrough config has not page aligned addresses/sizes\n"); + return -EINVAL; + } + + res = iomem_permit_access(kinfo->d, paddr_to_pfn(mstart), + paddr_to_pfn(PAGE_ALIGN(mstart + size - 1))); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to dom%d access to" + " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", + kinfo->d->domain_id, + mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); + return res; + } + + res = map_regions_p2mt(kinfo->d, + gaddr_to_gfn(gstart), + PFN_DOWN(size), + maddr_to_mfn(mstart), + p2m_mmio_direct_dev); + if ( res < 0 ) + { + printk(XENLOG_ERR + "Failed to map %"PRIpaddr" to the guest at%"PRIpaddr"\n", + mstart, gstart); + return -EFAULT; + } + } + + /* + * If xen_force, we let the user assign a MMIO region with no + * associated path. + */ + if ( xen_path == NULL ) + return xen_force ? 0 : -EINVAL; + + /* + * xen,path specifies the corresponding node in the host DT. + * Both interrupt mappings and IOMMU settings are based on it, + * as they are done based on the corresponding host DT node. + */ + node = dt_find_node_by_path(xen_path->data); + if ( node == NULL ) + { + printk(XENLOG_ERR "Couldn't find node %s in host_dt!\n", + (char *)xen_path->data); + return -EINVAL; + } + + res = handle_device_interrupts(kinfo->d, node, true); + if ( res < 0 ) + return res; + + res = iommu_add_dt_device(node); + if ( res < 0 ) + return res; + + /* If xen_force, we allow assignment of devices without IOMMU protection. */ + if ( xen_force && !dt_device_is_protected(node) ) + return 0; + + return iommu_assign_dt_device(kinfo->d, node); +} + +static int __init handle_prop_pfdt(struct kernel_info *kinfo, + const void *pfdt, int nodeoff, + uint32_t address_cells, uint32_t size_cells, + bool scan_passthrough_prop) +{ + void *fdt = kinfo->fdt; + int propoff, nameoff, res; + const struct fdt_property *prop, *xen_reg = NULL, *xen_path = NULL; + const char *name; + bool found, xen_force = false; + + for ( propoff = fdt_first_property_offset(pfdt, nodeoff); + propoff >= 0; + propoff = fdt_next_property_offset(pfdt, propoff) ) + { + if ( !(prop = fdt_get_property_by_offset(pfdt, propoff, NULL)) ) + return -FDT_ERR_INTERNAL; + + found = false; + nameoff = fdt32_to_cpu(prop->nameoff); + name = fdt_string(pfdt, nameoff); + + if ( scan_passthrough_prop ) + { + if ( dt_prop_cmp("xen,reg", name) == 0 ) + { + xen_reg = prop; + found = true; + } + else if ( dt_prop_cmp("xen,path", name) == 0 ) + { + xen_path = prop; + found = true; + } + else if ( dt_prop_cmp("xen,force-assign-without-iommu", + name) == 0 ) + { + xen_force = true; + found = true; + } + } + + /* + * Copy properties other than the ones above: xen,reg, xen,path, + * and xen,force-assign-without-iommu. + */ + if ( !found ) + { + res = fdt_property(fdt, name, prop->data, fdt32_to_cpu(prop->len)); + if ( res ) + return res; + } + } + + /* + * Only handle passthrough properties if both xen,reg and xen,path + * are present, or if xen,force-assign-without-iommu is specified. + */ + if ( xen_reg != NULL && (xen_path != NULL || xen_force) ) + { + res = handle_passthrough_prop(kinfo, xen_reg, xen_path, xen_force, + address_cells, size_cells); + if ( res < 0 ) + { + printk(XENLOG_ERR "Failed to assign device to %pd\n", kinfo->d); + return res; + } + } + else if ( (xen_path && !xen_reg) || (xen_reg && !xen_path && !xen_force) ) + { + printk(XENLOG_ERR "xen,reg or xen,path missing for %pd\n", + kinfo->d); + return -EINVAL; + } + + /* FDT_ERR_NOTFOUND => There is no more properties for this node */ + return ( propoff != -FDT_ERR_NOTFOUND ) ? propoff : 0; +} + +static int __init scan_pfdt_node(struct kernel_info *kinfo, const void *pfdt, + int nodeoff, + uint32_t address_cells, uint32_t size_cells, + bool scan_passthrough_prop) +{ + int rc = 0; + void *fdt = kinfo->fdt; + int node_next; + + rc = fdt_begin_node(fdt, fdt_get_name(pfdt, nodeoff, NULL)); + if ( rc ) + return rc; + + rc = handle_prop_pfdt(kinfo, pfdt, nodeoff, address_cells, size_cells, + scan_passthrough_prop); + if ( rc ) + return rc; + + address_cells = device_tree_get_u32(pfdt, nodeoff, "#address-cells", + DT_ROOT_NODE_ADDR_CELLS_DEFAULT); + size_cells = device_tree_get_u32(pfdt, nodeoff, "#size-cells", + DT_ROOT_NODE_SIZE_CELLS_DEFAULT); + + node_next = fdt_first_subnode(pfdt, nodeoff); + while ( node_next > 0 ) + { + scan_pfdt_node(kinfo, pfdt, node_next, address_cells, size_cells, + scan_passthrough_prop); + node_next = fdt_next_subnode(pfdt, node_next); + } + + return fdt_end_node(fdt); +} + +static int __init check_partial_fdt(void *pfdt, size_t size) +{ + int res; + + if ( fdt_magic(pfdt) != FDT_MAGIC ) + { + dprintk(XENLOG_ERR, "Partial FDT is not a valid Flat Device Tree"); + return -EINVAL; + } + + res = fdt_check_header(pfdt); + if ( res ) + { + dprintk(XENLOG_ERR, "Failed to check the partial FDT (%d)", res); + return -EINVAL; + } + + if ( fdt_totalsize(pfdt) > size ) + { + dprintk(XENLOG_ERR, "Partial FDT totalsize is too big"); + return -EINVAL; + } + + return 0; +} + +static int __init domain_handle_dtb_bootmodule(struct domain *d, + struct kernel_info *kinfo) +{ + void *pfdt; + int res, node_next; + + pfdt = ioremap_cache(kinfo->dtb_bootmodule->start, + kinfo->dtb_bootmodule->size); + if ( pfdt == NULL ) + return -EFAULT; + + res = check_partial_fdt(pfdt, kinfo->dtb_bootmodule->size); + if ( res < 0 ) + goto out; + + for ( node_next = fdt_first_subnode(pfdt, 0); + node_next > 0; + node_next = fdt_next_subnode(pfdt, node_next) ) + { + const char *name = fdt_get_name(pfdt, node_next, NULL); + + if ( name == NULL ) + continue; + + /* + * Only scan /gic /aliases /passthrough, ignore the rest. + * They don't have to be parsed in order. + * + * Take the GIC phandle value from the special /gic node in the + * DTB fragment. + */ + if ( dt_node_cmp(name, "gic") == 0 ) + { + kinfo->phandle_gic = fdt_get_phandle(pfdt, node_next); + continue; + } + + if ( dt_node_cmp(name, "aliases") == 0 ) + { + res = scan_pfdt_node(kinfo, pfdt, node_next, + DT_ROOT_NODE_ADDR_CELLS_DEFAULT, + DT_ROOT_NODE_SIZE_CELLS_DEFAULT, + false); + if ( res ) + goto out; + continue; + } + if ( dt_node_cmp(name, "passthrough") == 0 ) + { + res = scan_pfdt_node(kinfo, pfdt, node_next, + DT_ROOT_NODE_ADDR_CELLS_DEFAULT, + DT_ROOT_NODE_SIZE_CELLS_DEFAULT, + true); + if ( res ) + goto out; + continue; + } + } + + out: + iounmap(pfdt); + + return res; +} + +/* + * The max size for DT is 2MB. However, the generated DT is small (not including + * domU passthrough DT nodes whose size we account separately), 4KB are enough + * for now, but we might have to increase it in the future. + */ +#define DOMU_DTB_SIZE 4096 +static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) +{ + int addrcells, sizecells; + int ret, fdt_size = DOMU_DTB_SIZE; + + kinfo->phandle_gic = GUEST_PHANDLE_GIC; + kinfo->gnttab_start = GUEST_GNTTAB_BASE; + kinfo->gnttab_size = GUEST_GNTTAB_SIZE; + + addrcells = GUEST_ROOT_ADDRESS_CELLS; + sizecells = GUEST_ROOT_SIZE_CELLS; + + /* Account for domU passthrough DT size */ + if ( kinfo->dtb_bootmodule ) + fdt_size += kinfo->dtb_bootmodule->size; + + /* Cap to max DT size if needed */ + fdt_size = min(fdt_size, SZ_2M); + + kinfo->fdt = xmalloc_bytes(fdt_size); + if ( kinfo->fdt == NULL ) + return -ENOMEM; + + ret = fdt_create(kinfo->fdt, fdt_size); + if ( ret < 0 ) + goto err; + + ret = fdt_finish_reservemap(kinfo->fdt); + if ( ret < 0 ) + goto err; + + ret = fdt_begin_node(kinfo->fdt, ""); + if ( ret < 0 ) + goto err; + + ret = fdt_property_cell(kinfo->fdt, "#address-cells", addrcells); + if ( ret ) + goto err; + + ret = fdt_property_cell(kinfo->fdt, "#size-cells", sizecells); + if ( ret ) + goto err; + + ret = make_chosen_node(kinfo); + if ( ret ) + goto err; + + ret = make_psci_node(kinfo->fdt); + if ( ret ) + goto err; + + ret = make_cpus_node(d, kinfo->fdt); + if ( ret ) + goto err; + + ret = make_memory_node(d, kinfo->fdt, addrcells, sizecells, &kinfo->mem); + if ( ret ) + goto err; + + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( ret ) + goto err; + + /* + * domain_handle_dtb_bootmodule has to be called before the rest of + * the device tree is generated because it depends on the value of + * the field phandle_gic. + */ + if ( kinfo->dtb_bootmodule ) + { + ret = domain_handle_dtb_bootmodule(d, kinfo); + if ( ret ) + goto err; + } + + ret = make_gic_domU_node(kinfo); + if ( ret ) + goto err; + + ret = make_timer_node(kinfo); + if ( ret ) + goto err; + + if ( kinfo->vpl011 ) + { + ret = -EINVAL; +#ifdef CONFIG_SBSA_VUART_CONSOLE + ret = make_vpl011_uart_node(kinfo); +#endif + if ( ret ) + goto err; + } + + if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) + { + ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); + if ( ret ) + goto err; + } + + ret = fdt_end_node(kinfo->fdt); + if ( ret < 0 ) + goto err; + + ret = fdt_finish(kinfo->fdt); + if ( ret < 0 ) + goto err; + + return 0; + + err: + printk("Device tree generation failed (%d).\n", ret); + xfree(kinfo->fdt); + + return -EINVAL; +} + +static unsigned long __init domain_p2m_pages(unsigned long maxmem_kb, + unsigned int smp_cpus) +{ + /* + * Keep in sync with libxl__get_required_paging_memory(). + * 256 pages (1MB) per vcpu, plus 1 page per MiB of RAM for the P2M map, + * plus 128 pages to cover extended regions. + */ + unsigned long memkb = 4 * (256 * smp_cpus + (maxmem_kb / 1024) + 128); + + BUILD_BUG_ON(PAGE_SIZE != SZ_4K); + + return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT); +} + +static int __init alloc_xenstore_evtchn(struct domain *d) +{ + evtchn_alloc_unbound_t alloc; + int rc; + + alloc.dom = d->domain_id; + alloc.remote_dom = hardware_domain->domain_id; + rc = evtchn_alloc_unbound(&alloc, 0); + if ( rc ) + { + printk("Failed allocating event channel for domain\n"); + return rc; + } + + d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; + + return 0; +} + +static int __init construct_domU(struct domain *d, + const struct dt_device_node *node) +{ + struct kernel_info kinfo = {}; + const char *dom0less_enhanced; + int rc; + u64 mem; + u32 p2m_mem_mb; + unsigned long p2m_pages; + + rc = dt_property_read_u64(node, "memory", &mem); + if ( !rc ) + { + printk("Error building DomU: cannot read \"memory\" property\n"); + return -EINVAL; + } + kinfo.unassigned_mem = (paddr_t)mem * SZ_1K; + + rc = dt_property_read_u32(node, "xen,domain-p2m-mem-mb", &p2m_mem_mb); + /* If xen,domain-p2m-mem-mb is not specified, use the default value. */ + p2m_pages = rc ? + p2m_mem_mb << (20 - PAGE_SHIFT) : + domain_p2m_pages(mem, d->max_vcpus); + + spin_lock(&d->arch.paging.lock); + rc = p2m_set_allocation(d, p2m_pages, NULL); + spin_unlock(&d->arch.paging.lock); + if ( rc != 0 ) + return rc; + + printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n", + d->max_vcpus, mem); + + kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); + + rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced); + if ( rc == -EILSEQ || + rc == -ENODATA || + (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) + { + if ( hardware_domain ) + kinfo.dom0less_feature = DOM0LESS_ENHANCED; + else + panic("At the moment, Xenstore support requires dom0 to be present\n"); + } + else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) + kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; + + if ( vcpu_create(d, 0) == NULL ) + return -ENOMEM; + + d->max_pages = ((paddr_t)mem * SZ_1K) >> PAGE_SHIFT; + + kinfo.d = d; + + rc = kernel_probe(&kinfo, node); + if ( rc < 0 ) + return rc; + +#ifdef CONFIG_ARM_64 + /* type must be set before allocate memory */ + d->arch.type = kinfo.type; +#endif + if ( !dt_find_property(node, "xen,static-mem", NULL) ) + allocate_memory(d, &kinfo); + else if ( !is_domain_direct_mapped(d) ) + allocate_static_memory(d, &kinfo, node); + else + assign_static_memory_11(d, &kinfo, node); + +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, &kinfo, node); + if ( rc < 0 ) + return rc; +#endif + + /* + * Base address and irq number are needed when creating vpl011 device + * tree node in prepare_dtb_domU, so initialization on related variables + * shall be done first. + */ + if ( kinfo.vpl011 ) + { + rc = domain_vpl011_init(d, NULL); + if ( rc < 0 ) + return rc; + } + + rc = prepare_dtb_domU(d, &kinfo); + if ( rc < 0 ) + return rc; + + rc = construct_domain(d, &kinfo); + if ( rc < 0 ) + return rc; + + if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) + { + ASSERT(hardware_domain); + rc = alloc_xenstore_evtchn(d); + if ( rc < 0 ) + return rc; + d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL; + } + + return rc; +} + +void __init create_domUs(void) +{ + struct dt_device_node *node; + const struct dt_device_node *cpupool_node, + *chosen = dt_find_node_by_path("/chosen"); + + BUG_ON(chosen == NULL); + dt_for_each_child_node(chosen, node) + { + struct domain *d; + struct xen_domctl_createdomain d_cfg = { + .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, + .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, + /* + * The default of 1023 should be sufficient for guests because + * on ARM we don't bind physical interrupts to event channels. + * The only use of the evtchn port is inter-domain communications. + * 1023 is also the default value used in libxl. + */ + .max_evtchn_port = 1023, + .max_grant_frames = -1, + .max_maptrack_frames = -1, + .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), + }; + unsigned int flags = 0U; + uint32_t val; + int rc; + + if ( !dt_device_is_compatible(node, "xen,domain") ) + continue; + + if ( (max_init_domid + 1) >= DOMID_FIRST_RESERVED ) + panic("No more domain IDs available\n"); + + if ( dt_find_property(node, "xen,static-mem", NULL) ) + flags |= CDF_staticmem; + + if ( dt_property_read_bool(node, "direct-map") ) + { + if ( !(flags & CDF_staticmem) ) + panic("direct-map is not valid for domain %s without static allocation.\n", + dt_node_name(node)); + + flags |= CDF_directmap; + } + + if ( !dt_property_read_u32(node, "cpus", &d_cfg.max_vcpus) ) + panic("Missing property 'cpus' for domain %s\n", + dt_node_name(node)); + + if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") && + iommu_enabled ) + d_cfg.flags |= XEN_DOMCTL_CDF_iommu; + + if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) ) + { + int vpl011_virq = GUEST_VPL011_SPI; + + d_cfg.arch.nr_spis = gic_number_lines() - 32; + + /* + * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map is + * set, in which case it'll match the hardware. + * + * Since the domain is not yet created, we can't use + * d->arch.vpl011.irq. So the logic to find the vIRQ has to + * be hardcoded. + * The logic here shall be consistent with the one in + * domain_vpl011_init(). + */ + if ( flags & CDF_directmap ) + { + vpl011_virq = serial_irq(SERHND_DTUART); + if ( vpl011_virq < 0 ) + panic("Error getting IRQ number for this serial port %d\n", + SERHND_DTUART); + } + + /* + * vpl011 uses one emulated SPI. If vpl011 is requested, make + * sure that we allocate enough SPIs for it. + */ + if ( dt_property_read_bool(node, "vpl011") ) + d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis, + vpl011_virq - 32 + 1); + } + + /* Get the optional property domain-cpupool */ + cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0); + if ( cpupool_node ) + { + int pool_id = btcpupools_get_domain_pool_id(cpupool_node); + if ( pool_id < 0 ) + panic("Error getting cpupool id from domain-cpupool (%d)\n", + pool_id); + d_cfg.cpupool_id = pool_id; + } + + if ( dt_property_read_u32(node, "max_grant_version", &val) ) + d_cfg.grant_opts = XEN_DOMCTL_GRANT_version(val); + + if ( dt_property_read_u32(node, "max_grant_frames", &val) ) + { + if ( val > INT32_MAX ) + panic("max_grant_frames (%"PRIu32") overflow\n", val); + d_cfg.max_grant_frames = val; + } + + if ( dt_property_read_u32(node, "max_maptrack_frames", &val) ) + { + if ( val > INT32_MAX ) + panic("max_maptrack_frames (%"PRIu32") overflow\n", val); + d_cfg.max_maptrack_frames = val; + } + + if ( dt_get_property(node, "sve", &val) ) + { +#ifdef CONFIG_ARM64_SVE + unsigned int sve_vl_bits; + bool ret = false; + + if ( !val ) + { + /* Property found with no value, means max HW VL supported */ + ret = sve_domctl_vl_param(-1, &sve_vl_bits); + } + else + { + if ( dt_property_read_u32(node, "sve", &val) ) + ret = sve_domctl_vl_param(val, &sve_vl_bits); + else + panic("Error reading 'sve' property\n"); + } + + if ( ret ) + d_cfg.arch.sve_vl = sve_encode_vl(sve_vl_bits); + else + panic("SVE vector length error\n"); +#else + panic("'sve' property found, but CONFIG_ARM64_SVE not selected\n"); +#endif + } + + /* + * The variable max_init_domid is initialized with zero, so here it's + * very important to use the pre-increment operator to call + * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0) + */ + d = domain_create(++max_init_domid, &d_cfg, flags); + if ( IS_ERR(d) ) + panic("Error creating domain %s (rc = %ld)\n", + dt_node_name(node), PTR_ERR(d)); + + d->is_console = true; + dt_device_set_used_by(node, d->domain_id); + + rc = construct_domU(d, node); + if ( rc ) + panic("Could not set up domain %s (rc = %d)\n", + dt_node_name(node), rc); + } +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b2b609eb0c2d..2f8221590954 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include @@ -117,7 +118,7 @@ struct vcpu *__init alloc_dom0_vcpu0(struct domain *dom0) return vcpu_create(dom0, 0); } -static unsigned int __init get_allocation_size(paddr_t size) +unsigned int __init get_allocation_size(paddr_t size) { /* * get_order_from_bytes returns the order greater than or equal to @@ -413,988 +414,781 @@ static void __init allocate_memory_11(struct domain *d, } } -static bool __init allocate_bank_memory(struct domain *d, - struct kernel_info *kinfo, - gfn_t sgfn, - paddr_t tot_size) +/* + * When PCI passthrough is available we want to keep the + * "linux,pci-domain" in sync for every host bridge. + * + * Xen may not have a driver for all the host bridges. So we have + * to write an heuristic to detect whether a device node describes + * a host bridge. + * + * The current heuristic assumes that a device is a host bridge + * if the type is "pci" and then parent type is not "pci". + */ +static int __init handle_linux_pci_domain(struct kernel_info *kinfo, + const struct dt_device_node *node) { + uint16_t segment; int res; - struct page_info *pg; - struct membank *bank; - unsigned int max_order = ~0; - - /* - * allocate_bank_memory can be called with a tot_size of zero for - * the second memory bank. It is not an error and we can safely - * avoid creating a zero-size memory bank. - */ - if ( tot_size == 0 ) - return true; - - bank = &kinfo->mem.bank[kinfo->mem.nr_banks]; - bank->start = gfn_to_gaddr(sgfn); - bank->size = tot_size; - while ( tot_size > 0 ) - { - unsigned int order = get_allocation_size(tot_size); + if ( !is_pci_passthrough_enabled() ) + return 0; - order = min(max_order, order); + if ( !dt_device_type_is_equal(node, "pci") ) + return 0; - pg = alloc_domheap_pages(d, order, 0); - if ( !pg ) - { - /* - * If we can't allocate one page, then it is unlikely to - * succeed in the next iteration. So bail out. - */ - if ( !order ) - return false; + if ( node->parent && dt_device_type_is_equal(node->parent, "pci") ) + return 0; - /* - * If we can't allocate memory with order, then it is - * unlikely to succeed in the next iteration. - * Record the order - 1 to avoid re-trying. - */ - max_order = order - 1; - continue; - } + if ( dt_find_property(node, "linux,pci-domain", NULL) ) + return 0; - res = guest_physmap_add_page(d, sgfn, page_to_mfn(pg), order); - if ( res ) + /* Allocate and create the linux,pci-domain */ + res = pci_get_host_bridge_segment(node, &segment); + if ( res < 0 ) + { + res = pci_get_new_domain_nr(); + if ( res < 0 ) { - dprintk(XENLOG_ERR, "Failed map pages to DOMU: %d", res); - return false; + printk(XENLOG_DEBUG "Can't assign PCI segment to %s\n", + node->full_name); + return -FDT_ERR_NOTFOUND; } - sgfn = gfn_add(sgfn, 1UL << order); - tot_size -= (1ULL << (PAGE_SHIFT + order)); + segment = res; + printk(XENLOG_DEBUG "Assigned segment %d to %s\n", + segment, node->full_name); } - kinfo->mem.nr_banks++; - kinfo->unassigned_mem -= bank->size; - - return true; + return fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment); } -static void __init allocate_memory(struct domain *d, struct kernel_info *kinfo) +static int __init write_properties(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) { - unsigned int i; - paddr_t bank_size; - - printk(XENLOG_INFO "Allocating mappings totalling %ldMB for %pd:\n", - /* Don't want format this as PRIpaddr (16 digit hex) */ - (unsigned long)(kinfo->unassigned_mem >> 20), d); - - kinfo->mem.nr_banks = 0; - bank_size = MIN(GUEST_RAM0_SIZE, kinfo->unassigned_mem); - if ( !allocate_bank_memory(d, kinfo, gaddr_to_gfn(GUEST_RAM0_BASE), - bank_size) ) - goto fail; - - bank_size = MIN(GUEST_RAM1_SIZE, kinfo->unassigned_mem); - if ( !allocate_bank_memory(d, kinfo, gaddr_to_gfn(GUEST_RAM1_BASE), - bank_size) ) - goto fail; - - if ( kinfo->unassigned_mem ) - goto fail; - - for( i = 0; i < kinfo->mem.nr_banks; i++ ) - { - printk(XENLOG_INFO "%pd BANK[%d] %#"PRIpaddr"-%#"PRIpaddr" (%ldMB)\n", - d, - i, - kinfo->mem.bank[i].start, - kinfo->mem.bank[i].start + kinfo->mem.bank[i].size, - /* Don't want format this as PRIpaddr (16 digit hex) */ - (unsigned long)(kinfo->mem.bank[i].size >> 20)); - } - - return; - -fail: - panic("Failed to allocate requested domain memory." - /* Don't want format this as PRIpaddr (16 digit hex) */ - " %ldKB unallocated. Fix the VMs configurations.\n", - (unsigned long)kinfo->unassigned_mem >> 10); -} + const char *bootargs = NULL; + const struct dt_property *prop, *status = NULL; + int res = 0; + int had_dom0_bootargs = 0; + struct dt_device_node *iommu_node; -#ifdef CONFIG_STATIC_MEMORY -static bool __init append_static_memory_to_bank(struct domain *d, - struct membank *bank, - mfn_t smfn, - paddr_t size) -{ - int res; - unsigned int nr_pages = PFN_DOWN(size); - gfn_t sgfn; + if ( kinfo->cmdline && kinfo->cmdline[0] ) + bootargs = &kinfo->cmdline[0]; /* - * For direct-mapped domain, the GFN match the MFN. - * Otherwise, this is inferred on what has already been allocated - * in the bank. + * We always skip the IOMMU device when creating DT for hwdom if there is + * an appropriate driver for it in Xen (device_get_class(iommu_node) + * returns DEVICE_IOMMU). + * We should also skip the IOMMU specific properties of the master device + * behind that IOMMU in order to avoid exposing an half complete IOMMU + * bindings to hwdom. + * Use "iommu_node" as an indicator of the master device which properties + * should be skipped. */ - if ( !is_domain_direct_mapped(d) ) - sgfn = gaddr_to_gfn(bank->start + bank->size); - else - sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); + iommu_node = dt_parse_phandle(node, "iommus", 0); + if ( iommu_node && device_get_class(iommu_node) != DEVICE_IOMMU ) + iommu_node = NULL; - res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); - if ( res ) + dt_for_each_property_node (node, prop) { - dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); - return false; - } - - bank->size = bank->size + size; - - return true; -} + const void *prop_data = prop->value; + u32 prop_len = prop->length; -static mfn_t __init acquire_static_memory_bank(struct domain *d, - const __be32 **cell, - u32 addr_cells, u32 size_cells, - paddr_t *pbase, paddr_t *psize) -{ - mfn_t smfn; - int res; + /* + * In chosen node: + * + * * remember xen,dom0-bootargs if we don't already have + * bootargs (from module #1, above). + * * remove bootargs, xen,dom0-bootargs, xen,xen-bootargs, + * linux,initrd-start and linux,initrd-end. + * * remove stdout-path. + * * remove bootargs, linux,uefi-system-table, + * linux,uefi-mmap-start, linux,uefi-mmap-size, + * linux,uefi-mmap-desc-size, and linux,uefi-mmap-desc-ver + * (since EFI boot is not currently supported in dom0). + */ + if ( dt_node_path_is_equal(node, "/chosen") ) + { + if ( dt_property_name_is_equal(prop, "xen,xen-bootargs") || + dt_property_name_is_equal(prop, "linux,initrd-start") || + dt_property_name_is_equal(prop, "linux,initrd-end") || + dt_property_name_is_equal(prop, "stdout-path") || + dt_property_name_is_equal(prop, "linux,uefi-system-table") || + dt_property_name_is_equal(prop, "linux,uefi-mmap-start") || + dt_property_name_is_equal(prop, "linux,uefi-mmap-size") || + dt_property_name_is_equal(prop, "linux,uefi-mmap-desc-size") || + dt_property_name_is_equal(prop, "linux,uefi-mmap-desc-ver")) + continue; - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); - ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); - if ( PFN_DOWN(*psize) > UINT_MAX ) - { - printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr, - d, *psize); - return INVALID_MFN; - } + if ( dt_property_name_is_equal(prop, "xen,dom0-bootargs") ) + { + had_dom0_bootargs = 1; + bootargs = prop->value; + continue; + } + if ( dt_property_name_is_equal(prop, "bootargs") ) + { + if ( !bootargs && !had_dom0_bootargs ) + bootargs = prop->value; + continue; + } + } - smfn = maddr_to_mfn(*pbase); - res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0); - if ( res ) - { - printk(XENLOG_ERR - "%pd: failed to acquire static memory: %d.\n", d, res); - return INVALID_MFN; - } + /* Don't expose the property "xen,passthrough" to the guest */ + if ( dt_property_name_is_equal(prop, "xen,passthrough") ) + continue; - return smfn; -} + /* Remember and skip the status property as Xen may modify it later */ + if ( dt_property_name_is_equal(prop, "status") ) + { + status = prop; + continue; + } -static int __init parse_static_mem_prop(const struct dt_device_node *node, - u32 *addr_cells, u32 *size_cells, - int *length, const __be32 **cell) -{ - const struct dt_property *prop; + if ( iommu_node ) + { + /* Don't expose IOMMU specific properties to hwdom */ + if ( dt_property_name_is_equal(prop, "iommus") ) + continue; - prop = dt_find_property(node, "xen,static-mem", NULL); + if ( dt_property_name_is_equal(prop, "iommu-map") ) + continue; - *addr_cells = dt_n_addr_cells(node); - *size_cells = dt_n_size_cells(node); + if ( dt_property_name_is_equal(prop, "iommu-map-mask") ) + continue; + } - *cell = (const __be32 *)prop->value; - *length = prop->length; + res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len); - return 0; -} + if ( res ) + return res; + } -/* Allocate memory from static memory as RAM for one specific domain d. */ -static void __init allocate_static_memory(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - u32 addr_cells, size_cells, reg_cells; - unsigned int nr_banks, gbank, bank = 0; - const uint64_t rambase[] = GUEST_RAM_BANK_BASES; - const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; - const __be32 *cell; - u64 tot_size = 0; - paddr_t pbase, psize, gsize; - mfn_t smfn; - int length; + res = handle_linux_pci_domain(kinfo, node); - if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) - goto fail; - reg_cells = addr_cells + size_cells; + if ( res ) + return res; /* - * The static memory will be mapped in the guest at the usual guest memory - * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by - * xen/include/public/arch-arm.h. + * Override the property "status" to disable the device when it's + * marked for passthrough. */ - gbank = 0; - gsize = ramsize[gbank]; - kinfo->mem.bank[gbank].start = rambase[gbank]; - nr_banks = length / (reg_cells * sizeof (u32)); + if ( dt_device_for_passthrough(node) ) + res = fdt_property_string(kinfo->fdt, "status", "disabled"); + else if ( status ) + res = fdt_property(kinfo->fdt, "status", status->value, + status->length); + + if ( res ) + return res; - for ( ; bank < nr_banks; bank++ ) + if ( dt_node_path_is_equal(node, "/chosen") ) { - smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, - &pbase, &psize); - if ( mfn_eq(smfn, INVALID_MFN) ) - goto fail; + const struct bootmodule *initrd = kinfo->initrd_bootmodule; - printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", - d, bank, pbase, pbase + psize); + if ( bootargs ) + { + res = fdt_property(kinfo->fdt, "bootargs", bootargs, + strlen(bootargs) + 1); + if ( res ) + return res; + } - while ( 1 ) + /* + * If the bootloader provides an initrd, we must create a placeholder + * for the initrd properties. The values will be replaced later. + */ + if ( initrd && initrd->size ) { - /* Map as much as possible the static range to the guest bank */ - if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, - min(psize, gsize)) ) - goto fail; + u64 a = 0; + res = fdt_property(kinfo->fdt, "linux,initrd-start", &a, sizeof(a)); + if ( res ) + return res; - /* - * The current physical bank is fully mapped. - * Handle the next physical bank. - */ - if ( gsize >= psize ) - { - gsize = gsize - psize; - break; - } - /* - * When current guest bank is not enough to map, exhaust - * the current one and seek to the next. - * Before seeking to the next, check if we still have available - * guest bank. - */ - else if ( (gbank + 1) >= GUEST_RAM_BANKS ) - { - printk(XENLOG_ERR "Exhausted all possible guest banks.\n"); - goto fail; - } - else - { - psize = psize - gsize; - smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); - /* Update to the next guest bank. */ - gbank++; - gsize = ramsize[gbank]; - kinfo->mem.bank[gbank].start = rambase[gbank]; - } + res = fdt_property(kinfo->fdt, "linux,initrd-end", &a, sizeof(a)); + if ( res ) + return res; } - - tot_size += psize; } - kinfo->mem.nr_banks = ++gbank; + return 0; +} - kinfo->unassigned_mem -= tot_size; - /* - * The property 'memory' should match the amount of memory given to the - * guest. - * Currently, it is only possible to either acquire static memory or let - * Xen allocate. *Mixing* is not supported. - */ - if ( kinfo->unassigned_mem ) - { - printk(XENLOG_ERR - "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n"); - goto fail; - } +void __init set_interrupt(gic_interrupt_t interrupt, + unsigned int irq, + unsigned int cpumask, + unsigned int level) +{ + __be32 *cells = interrupt; + bool is_ppi = !!(irq < 32); - return; + BUG_ON(irq < 16); + irq -= (is_ppi) ? 16: 32; /* PPIs start at 16, SPIs at 32 */ - fail: - panic("Failed to allocate requested static memory for domain %pd.\n", d); + /* See linux Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt */ + dt_set_cell(&cells, 1, is_ppi); /* is a PPI? */ + dt_set_cell(&cells, 1, irq); + dt_set_cell(&cells, 1, (cpumask << 8) | level); } /* - * Allocate static memory as RAM for one specific domain d. - * The static memory will be directly mapped in the guest(Guest Physical - * Address == Physical Address). + * Helper to set interrupts for a node in the flat device tree. + * It needs 2 property: + * "interrupts": contains the list of interrupts + * "interrupt-parent": link to the GIC */ -static void __init assign_static_memory_11(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - u32 addr_cells, size_cells, reg_cells; - unsigned int nr_banks, bank = 0; - const __be32 *cell; - paddr_t pbase, psize; - mfn_t smfn; - int length; - - if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) - { - printk(XENLOG_ERR - "%pd: failed to parse \"xen,static-mem\" property.\n", d); - goto fail; - } - reg_cells = addr_cells + size_cells; - nr_banks = length / (reg_cells * sizeof(u32)); - - if ( nr_banks > NR_MEM_BANKS ) - { - printk(XENLOG_ERR - "%pd: exceed max number of supported guest memory banks.\n", d); - goto fail; - } - - for ( ; bank < nr_banks; bank++ ) - { - smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, - &pbase, &psize); - if ( mfn_eq(smfn, INVALID_MFN) ) - goto fail; - - printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", - d, bank, pbase, pbase + psize); +static int __init fdt_property_interrupts(const struct kernel_info *kinfo, + gic_interrupt_t *intr, + unsigned int num_irq) +{ + int res; - /* One guest memory bank is matched with one physical memory bank. */ - kinfo->mem.bank[bank].start = pbase; - if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[bank], - smfn, psize) ) - goto fail; + res = fdt_property(kinfo->fdt, "interrupts", + intr, sizeof(intr[0]) * num_irq); + if ( res ) + return res; - kinfo->unassigned_mem -= psize; - } + res = fdt_property_cell(kinfo->fdt, "interrupt-parent", + kinfo->phandle_gic); - kinfo->mem.nr_banks = nr_banks; + return res; +} +/* + * Wrapper to convert physical address from paddr_t to uint64_t and + * invoke fdt_begin_node(). This is required as the physical address + * provided as part of node name should not contain any leading + * zeroes. Thus, one should use PRIx64 (instead of PRIpaddr) to append + * unit (which contains the physical address) with name to generate a + * node name. + */ +int __init domain_fdt_begin_node(void *fdt, const char *name, uint64_t unit) +{ /* - * The property 'memory' should match the amount of memory given to - * the guest. - * Currently, it is only possible to either acquire static memory or - * let Xen allocate. *Mixing* is not supported. + * The size of the buffer to hold the longest possible string (i.e. + * interrupt-controller@ + a 64-bit number + \0). */ - if ( kinfo->unassigned_mem != 0 ) + char buf[38]; + int ret; + + /* ePAPR 3.4 */ + ret = snprintf(buf, sizeof(buf), "%s@%"PRIx64, name, unit); + + if ( ret >= sizeof(buf) ) { printk(XENLOG_ERR - "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); - goto fail; - } + "Insufficient buffer. Minimum size required is %d\n", + (ret + 1)); - return; + return -FDT_ERR_TRUNCATED; + } - fail: - panic("Failed to assign requested static memory for direct-map domain %pd.\n", - d); + return fdt_begin_node(fdt, buf); } -#ifdef CONFIG_STATIC_SHM -static int __init acquire_nr_borrower_domain(struct domain *d, - paddr_t pbase, paddr_t psize, - unsigned long *nr_borrowers) +int __init make_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) { - unsigned int bank; + unsigned int i; + int res, reg_size = addrcells + sizecells; + int nr_cells = 0; + __be32 reg[NR_MEM_BANKS * 4 /* Worst case addrcells + sizecells */]; + __be32 *cells; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* find the first memory range that is reserved for device (or firmware) */ + for ( i = 0; i < mem->nr_banks && + (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) + ; + + if ( i == mem->nr_banks ) + return 0; + + dt_dprintk("Create memory node\n"); + + res = domain_fdt_begin_node(fdt, "memory", mem->bank[i].start); + if ( res ) + return res; + + res = fdt_property_string(fdt, "device_type", "memory"); + if ( res ) + return res; - /* Iterate reserved memory to find requested shm bank. */ - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + cells = ®[0]; + for ( ; i < mem->nr_banks; i++ ) { - paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; - paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + u64 start = mem->bank[i].start; + u64 size = mem->bank[i].size; - if ( (pbase == bank_start) && (psize == bank_size) ) - break; + if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) + continue; + + dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + nr_cells += reg_size; + BUG_ON(nr_cells >= ARRAY_SIZE(reg)); + dt_child_set_range(&cells, addrcells, sizecells, start, size); } - if ( bank == bootinfo.reserved_mem.nr_banks ) - return -ENOENT; + dt_dprintk("(reg size %d, nr cells %d)\n", reg_size, nr_cells); + + res = fdt_property(fdt, "reg", reg, nr_cells * sizeof(*reg)); + if ( res ) + return res; - *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + res = fdt_end_node(fdt); - return 0; + return res; } -/* - * This function checks whether the static shared memory region is - * already allocated to dom_io. - */ -static bool __init is_shm_allocated_to_domio(paddr_t pbase) +int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) { - struct page_info *page; - struct domain *d; + int res = 0; + /* Placeholder for reserved-memory\0 */ + const char resvbuf[16] = "reserved-memory"; - page = maddr_to_page(pbase); - d = page_get_owner_and_reference(page); - if ( d == NULL ) - return false; - put_page(page); + if ( mem->nr_banks == 0 ) + /* No shared memory provided. */ + return 0; - if ( d != dom_io ) - { - printk(XENLOG_ERR - "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", - d); - return false; - } + dt_dprintk("Create reserved-memory node\n"); - return true; -} + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; -static mfn_t __init acquire_shared_memory_bank(struct domain *d, - paddr_t pbase, paddr_t psize) -{ - mfn_t smfn; - unsigned long nr_pfns; - int res; + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; - /* - * Pages of statically shared memory shall be included - * into domain_tot_pages(). - */ - nr_pfns = PFN_DOWN(psize); - if ( (UINT_MAX - d->max_pages) < nr_pfns ) - { - printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", - d, nr_pfns); - return INVALID_MFN; - } - d->max_pages += nr_pfns; + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; - smfn = maddr_to_mfn(pbase); - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + res = fdt_property_cell(fdt, "#size-cells", sizecells); if ( res ) - { - printk(XENLOG_ERR - "%pd: failed to acquire static memory: %d.\n", d, res); - d->max_pages -= nr_pfns; - return INVALID_MFN; - } + return res; - return smfn; + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; } -static int __init assign_shared_memory(struct domain *d, - uint32_t addr_cells, uint32_t size_cells, - paddr_t pbase, paddr_t psize, - paddr_t gbase) +static int __init add_ext_regions(unsigned long s_gfn, unsigned long e_gfn, + void *data) { - mfn_t smfn; - int ret = 0; - unsigned long nr_pages, nr_borrowers, i; - struct page_info *page; - - printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", - d, pbase, pbase + psize); + struct meminfo *ext_regions = data; + paddr_t start, size; + paddr_t s = pfn_to_paddr(s_gfn); + paddr_t e = pfn_to_paddr(e_gfn); - smfn = acquire_shared_memory_bank(d, pbase, psize); - if ( mfn_eq(smfn, INVALID_MFN) ) - return -EINVAL; + if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) ) + return 0; /* - * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need - * to create mapping in the P2M. + * Both start and size of the extended region should be 2MB aligned to + * potentially allow superpage mapping. */ - nr_pages = PFN_DOWN(psize); - if ( d != dom_io ) - { - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, - PFN_DOWN(psize)); - if ( ret ) - { - printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); - return ret; - } - } + start = (s + SZ_2M - 1) & ~(SZ_2M - 1); + if ( start > e ) + return 0; /* - * Get the right amount of references per page, which is the number of - * borrower domains. + * e is actually "end-1" because it is called by rangeset functions + * which are inclusive of the last address. */ - ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); - if ( ret ) - return ret; + e += 1; + size = (e - start) & ~(SZ_2M - 1); /* - * Instead of letting borrower domain get a page ref, we add as many - * additional reference as the number of borrowers when the owner - * is allocated, since there is a chance that owner is created - * after borrower. - * So if the borrower is created first, it will cause adding pages - * in the P2M without reference. + * Reasonable size. Not too little to pick up small ranges which are + * not quite useful but increase bookkeeping and not too large + * to skip a large proportion of unused address space. */ - page = mfn_to_page(smfn); - for ( i = 0; i < nr_pages; i++ ) - { - if ( !get_page_nr(page + i, d, nr_borrowers) ) - { - printk(XENLOG_ERR - "Failed to add %lu references to page %"PRI_mfn".\n", - nr_borrowers, mfn_x(smfn) + i); - goto fail; - } - } + if ( size < MB(64) ) + return 0; - return 0; + ext_regions->bank[ext_regions->nr_banks].start = start; + ext_regions->bank[ext_regions->nr_banks].size = size; + ext_regions->nr_banks++; - fail: - while ( --i >= 0 ) - put_page_nr(page + i, nr_borrowers); - return ret; + return 0; } -static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, - paddr_t start, paddr_t size, - const char *shm_id) +/* + * Find unused regions of Host address space which can be exposed to Dom0 + * as extended regions for the special memory mappings. In order to calculate + * regions we exclude every region assigned to Dom0 from the Host RAM: + * - domain RAM + * - reserved-memory + * - grant table space + */ +static int __init find_unallocated_memory(const struct kernel_info *kinfo, + struct meminfo *ext_regions) { - if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) - return -ENOMEM; - - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; - safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); - kinfo->shm_mem.nr_banks++; + const struct meminfo *assign_mem = &kinfo->mem; + struct rangeset *unalloc_mem; + paddr_t start, end; + unsigned int i; + int res; - return 0; -} + dt_dprintk("Find unallocated memory for extended regions\n"); -static int __init process_shm(struct domain *d, struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - struct dt_device_node *shm_node; + unalloc_mem = rangeset_new(NULL, NULL, 0); + if ( !unalloc_mem ) + return -ENOMEM; - dt_for_each_child_node(node, shm_node) + /* Start with all available RAM */ + for ( i = 0; i < bootinfo.mem.nr_banks; i++ ) { - const struct dt_property *prop; - const __be32 *cells; - uint32_t addr_cells, size_cells; - paddr_t gbase, pbase, psize; - int ret = 0; - unsigned int i; - const char *role_str; - const char *shm_id; - bool owner_dom_io = true; - - if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) - continue; - - /* - * xen,shared-mem = ; - * TODO: pbase is optional. - */ - addr_cells = dt_n_addr_cells(shm_node); - size_cells = dt_n_size_cells(shm_node); - prop = dt_find_property(shm_node, "xen,shared-mem", NULL); - BUG_ON(!prop); - cells = (const __be32 *)prop->value; - device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); - psize = dt_read_paddr(cells, size_cells); - if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) - { - printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", - d, pbase, gbase); - return -EINVAL; - } - if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + start = bootinfo.mem.bank[i].start; + end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size; + res = rangeset_add_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); + if ( res ) { - printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", - d, psize); - return -EINVAL; + printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; } + } - for ( i = 0; i < PFN_DOWN(psize); i++ ) - if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) - { - printk("%pd: invalid physical address 0x%"PRI_mfn"\n", - d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); - return -EINVAL; - } - - /* - * "role" property is optional and if it is defined explicitly, - * then the owner domain is not the default "dom_io" domain. - */ - if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) - owner_dom_io = false; - - if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) + /* Remove RAM assigned to Dom0 */ + for ( i = 0; i < assign_mem->nr_banks; i++ ) + { + start = assign_mem->bank[i].start; + end = assign_mem->bank[i].start + assign_mem->bank[i].size; + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); + if ( res ) { - printk("%pd: invalid \"xen,shm-id\" property", d); - return -EINVAL; + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; } - BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + } - /* - * DOMID_IO is a fake domain and is not described in the Device-Tree. - * Therefore when the owner of the shared region is DOMID_IO, we will - * only find the borrowers. - */ - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || - (!owner_dom_io && strcmp(role_str, "owner") == 0) ) + /* Remove reserved-memory regions */ + for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + start = bootinfo.reserved_mem.bank[i].start; + end = bootinfo.reserved_mem.bank[i].start + + bootinfo.reserved_mem.bank[i].size; + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), + PFN_DOWN(end - 1)); + if ( res ) { - /* - * We found the first borrower of the region, the owner was not - * specified, so they should be assigned to dom_io. - */ - ret = assign_shared_memory(owner_dom_io ? dom_io : d, - addr_cells, size_cells, - pbase, psize, gbase); - if ( ret ) - return ret; - } - - if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) - { - /* Set up P2M foreign mapping for borrower domain. */ - ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), - _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); - if ( ret ) - return ret; + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; } + } - /* - * Record static shared memory region info for later setting - * up shm-node in guest device tree. - */ - ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); - if ( ret ) - return ret; + /* Remove grant table region */ + start = kinfo->gnttab_start; + end = kinfo->gnttab_start + kinfo->gnttab_size; + res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end - 1)); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; } - return 0; -} -#endif /* CONFIG_STATIC_SHM */ -#else -static void __init allocate_static_memory(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - ASSERT_UNREACHABLE(); -} + start = 0; + end = (1ULL << p2m_ipa_bits) - 1; + res = rangeset_report_ranges(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end), + add_ext_regions, ext_regions); + if ( res ) + ext_regions->nr_banks = 0; + else if ( !ext_regions->nr_banks ) + res = -ENOENT; -static void __init assign_static_memory_11(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - ASSERT_UNREACHABLE(); +out: + rangeset_destroy(unalloc_mem); + + return res; } -#endif -/* - * When PCI passthrough is available we want to keep the - * "linux,pci-domain" in sync for every host bridge. - * - * Xen may not have a driver for all the host bridges. So we have - * to write an heuristic to detect whether a device node describes - * a host bridge. - * - * The current heuristic assumes that a device is a host bridge - * if the type is "pci" and then parent type is not "pci". - */ -static int __init handle_linux_pci_domain(struct kernel_info *kinfo, - const struct dt_device_node *node) +static int __init handle_pci_range(const struct dt_device_node *dev, + uint64_t addr, uint64_t len, void *data) { - uint16_t segment; + struct rangeset *mem_holes = data; + paddr_t start, end; int res; - if ( !is_pci_passthrough_enabled() ) - return 0; - - if ( !dt_device_type_is_equal(node, "pci") ) - return 0; - - if ( node->parent && dt_device_type_is_equal(node->parent, "pci") ) - return 0; - - if ( dt_find_property(node, "linux,pci-domain", NULL) ) - return 0; - - /* Allocate and create the linux,pci-domain */ - res = pci_get_host_bridge_segment(node, &segment); - if ( res < 0 ) + if ( (addr != (paddr_t)addr) || (((paddr_t)~0 - addr) < len) ) { - res = pci_get_new_domain_nr(); - if ( res < 0 ) - { - printk(XENLOG_DEBUG "Can't assign PCI segment to %s\n", - node->full_name); - return -FDT_ERR_NOTFOUND; - } + printk(XENLOG_ERR "%s: [0x%"PRIx64", 0x%"PRIx64"] exceeds the maximum allowed PA width (%u bits)", + dt_node_full_name(dev), addr, (addr + len), PADDR_BITS); + return -ERANGE; + } - segment = res; - printk(XENLOG_DEBUG "Assigned segment %d to %s\n", - segment, node->full_name); + start = addr & PAGE_MASK; + end = PAGE_ALIGN(addr + len); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end - 1)); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + return res; } - return fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment); + return 0; } -static int __init write_properties(struct domain *d, struct kernel_info *kinfo, - const struct dt_device_node *node) +/* + * Find the holes in the Host DT which can be exposed to Dom0 as extended + * regions for the special memory mappings. In order to calculate regions + * we exclude every addressable memory region described by "reg" and "ranges" + * properties from the maximum possible addressable physical memory range: + * - MMIO + * - Host RAM + * - PCI aperture + */ +static int __init find_memory_holes(const struct kernel_info *kinfo, + struct meminfo *ext_regions) { - const char *bootargs = NULL; - const struct dt_property *prop, *status = NULL; - int res = 0; - int had_dom0_bootargs = 0; - struct dt_device_node *iommu_node; + struct dt_device_node *np; + struct rangeset *mem_holes; + paddr_t start, end; + unsigned int i; + int res; - if ( kinfo->cmdline && kinfo->cmdline[0] ) - bootargs = &kinfo->cmdline[0]; + dt_dprintk("Find memory holes for extended regions\n"); + + mem_holes = rangeset_new(NULL, NULL, 0); + if ( !mem_holes ) + return -ENOMEM; + + /* Start with maximum possible addressable physical memory range */ + start = 0; + end = (1ULL << p2m_ipa_bits) - 1; + res = rangeset_add_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end)); + if ( res ) + { + printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; + } /* - * We always skip the IOMMU device when creating DT for hwdom if there is - * an appropriate driver for it in Xen (device_get_class(iommu_node) - * returns DEVICE_IOMMU). - * We should also skip the IOMMU specific properties of the master device - * behind that IOMMU in order to avoid exposing an half complete IOMMU - * bindings to hwdom. - * Use "iommu_node" as an indicator of the master device which properties - * should be skipped. + * Remove regions described by "reg" and "ranges" properties where + * the memory is addressable (MMIO, RAM, PCI BAR, etc). */ - iommu_node = dt_parse_phandle(node, "iommus", 0); - if ( iommu_node && device_get_class(iommu_node) != DEVICE_IOMMU ) - iommu_node = NULL; - - dt_for_each_property_node (node, prop) + dt_for_each_device_node( dt_host, np ) { - const void *prop_data = prop->value; - u32 prop_len = prop->length; + unsigned int naddr; + paddr_t addr, size; - /* - * In chosen node: - * - * * remember xen,dom0-bootargs if we don't already have - * bootargs (from module #1, above). - * * remove bootargs, xen,dom0-bootargs, xen,xen-bootargs, - * linux,initrd-start and linux,initrd-end. - * * remove stdout-path. - * * remove bootargs, linux,uefi-system-table, - * linux,uefi-mmap-start, linux,uefi-mmap-size, - * linux,uefi-mmap-desc-size, and linux,uefi-mmap-desc-ver - * (since EFI boot is not currently supported in dom0). - */ - if ( dt_node_path_is_equal(node, "/chosen") ) - { - if ( dt_property_name_is_equal(prop, "xen,xen-bootargs") || - dt_property_name_is_equal(prop, "linux,initrd-start") || - dt_property_name_is_equal(prop, "linux,initrd-end") || - dt_property_name_is_equal(prop, "stdout-path") || - dt_property_name_is_equal(prop, "linux,uefi-system-table") || - dt_property_name_is_equal(prop, "linux,uefi-mmap-start") || - dt_property_name_is_equal(prop, "linux,uefi-mmap-size") || - dt_property_name_is_equal(prop, "linux,uefi-mmap-desc-size") || - dt_property_name_is_equal(prop, "linux,uefi-mmap-desc-ver")) - continue; + naddr = dt_number_of_address(np); - if ( dt_property_name_is_equal(prop, "xen,dom0-bootargs") ) + for ( i = 0; i < naddr; i++ ) + { + res = dt_device_get_paddr(np, i, &addr, &size); + if ( res ) { - had_dom0_bootargs = 1; - bootargs = prop->value; - continue; + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(np)); + goto out; } - if ( dt_property_name_is_equal(prop, "bootargs") ) + + start = addr & PAGE_MASK; + end = PAGE_ALIGN(addr + size); + res = rangeset_remove_range(mem_holes, PFN_DOWN(start), + PFN_DOWN(end - 1)); + if ( res ) { - if ( !bootargs && !had_dom0_bootargs ) - bootargs = prop->value; - continue; + printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", + start, end); + goto out; } } - /* Don't expose the property "xen,passthrough" to the guest */ - if ( dt_property_name_is_equal(prop, "xen,passthrough") ) - continue; - - /* Remember and skip the status property as Xen may modify it later */ - if ( dt_property_name_is_equal(prop, "status") ) - { - status = prop; - continue; - } - - if ( iommu_node ) + if ( dt_device_type_is_equal(np, "pci") ) { - /* Don't expose IOMMU specific properties to hwdom */ - if ( dt_property_name_is_equal(prop, "iommus") ) - continue; - - if ( dt_property_name_is_equal(prop, "iommu-map") ) + /* + * The ranges property in this context describes the PCI host + * bridge aperture. It shall be absent if no addresses are mapped + * through the bridge. + */ + if ( !dt_get_property(np, "ranges", NULL) ) continue; - if ( dt_property_name_is_equal(prop, "iommu-map-mask") ) - continue; + res = dt_for_each_range(np, &handle_pci_range, mem_holes); + if ( res ) + goto out; } - - res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len); - - if ( res ) - return res; } - res = handle_linux_pci_domain(kinfo, node); - + start = 0; + end = (1ULL << p2m_ipa_bits) - 1; + res = rangeset_report_ranges(mem_holes, PFN_DOWN(start), PFN_DOWN(end), + add_ext_regions, ext_regions); if ( res ) - return res; + ext_regions->nr_banks = 0; + else if ( !ext_regions->nr_banks ) + res = -ENOENT; - /* - * Override the property "status" to disable the device when it's - * marked for passthrough. - */ - if ( dt_device_for_passthrough(node) ) - res = fdt_property_string(kinfo->fdt, "status", "disabled"); - else if ( status ) - res = fdt_property(kinfo->fdt, "status", status->value, - status->length); +out: + rangeset_destroy(mem_holes); - if ( res ) - return res; + return res; +} - if ( dt_node_path_is_equal(node, "/chosen") ) +static int __init find_domU_holes(const struct kernel_info *kinfo, + struct meminfo *ext_regions) +{ + unsigned int i; + uint64_t bankend; + const uint64_t bankbase[] = GUEST_RAM_BANK_BASES; + const uint64_t banksize[] = GUEST_RAM_BANK_SIZES; + int res = -ENOENT; + + for ( i = 0; i < GUEST_RAM_BANKS; i++ ) { - const struct bootmodule *initrd = kinfo->initrd_bootmodule; + struct membank *ext_bank = &(ext_regions->bank[ext_regions->nr_banks]); - if ( bootargs ) - { - res = fdt_property(kinfo->fdt, "bootargs", bootargs, - strlen(bootargs) + 1); - if ( res ) - return res; - } + ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size, SZ_2M); - /* - * If the bootloader provides an initrd, we must create a placeholder - * for the initrd properties. The values will be replaced later. - */ - if ( initrd && initrd->size ) - { - u64 a = 0; - res = fdt_property(kinfo->fdt, "linux,initrd-start", &a, sizeof(a)); - if ( res ) - return res; + bankend = ~0ULL >> (64 - p2m_ipa_bits); + bankend = min(bankend, bankbase[i] + banksize[i] - 1); + if ( bankend > ext_bank->start ) + ext_bank->size = bankend - ext_bank->start + 1; - res = fdt_property(kinfo->fdt, "linux,initrd-end", &a, sizeof(a)); - if ( res ) - return res; - } + /* 64MB is the minimum size of an extended region */ + if ( ext_bank->size < MB(64) ) + continue; + ext_regions->nr_banks++; + res = 0; } - return 0; -} - -/* - * Helper to write an interrupts with the GIC format - * This code is assuming the irq is an PPI. - */ - -typedef __be32 gic_interrupt_t[3]; - -static void __init set_interrupt(gic_interrupt_t interrupt, - unsigned int irq, - unsigned int cpumask, - unsigned int level) -{ - __be32 *cells = interrupt; - bool is_ppi = !!(irq < 32); - - BUG_ON(irq < 16); - irq -= (is_ppi) ? 16: 32; /* PPIs start at 16, SPIs at 32 */ - - /* See linux Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt */ - dt_set_cell(&cells, 1, is_ppi); /* is a PPI? */ - dt_set_cell(&cells, 1, irq); - dt_set_cell(&cells, 1, (cpumask << 8) | level); + return res; } -/* - * Helper to set interrupts for a node in the flat device tree. - * It needs 2 property: - * "interrupts": contains the list of interrupts - * "interrupt-parent": link to the GIC - */ -static int __init fdt_property_interrupts(const struct kernel_info *kinfo, - gic_interrupt_t *intr, - unsigned int num_irq) +int __init make_hypervisor_node(struct domain *d, + const struct kernel_info *kinfo, + int addrcells, int sizecells) { + const char compat[] = + "xen,xen-" XEN_VERSION_STRING "\0" + "xen,xen"; + __be32 *reg, *cells; + gic_interrupt_t intr; int res; + void *fdt = kinfo->fdt; + struct meminfo *ext_regions = NULL; + unsigned int i, nr_ext_regions; - res = fdt_property(kinfo->fdt, "interrupts", - intr, sizeof(intr[0]) * num_irq); - if ( res ) - return res; - - res = fdt_property_cell(kinfo->fdt, "interrupt-parent", - kinfo->phandle_gic); - - return res; -} + dt_dprintk("Create hypervisor node\n"); -/* - * Wrapper to convert physical address from paddr_t to uint64_t and - * invoke fdt_begin_node(). This is required as the physical address - * provided as part of node name should not contain any leading - * zeroes. Thus, one should use PRIx64 (instead of PRIpaddr) to append - * unit (which contains the physical address) with name to generate a - * node name. - */ -static int __init domain_fdt_begin_node(void *fdt, const char *name, - uint64_t unit) -{ /* - * The size of the buffer to hold the longest possible string (i.e. - * interrupt-controller@ + a 64-bit number + \0). + * Sanity-check address sizes, since addresses and sizes which do + * not take up exactly 4 or 8 bytes are not supported. */ - char buf[38]; - int ret; + if ((addrcells != 1 && addrcells != 2) || + (sizecells != 1 && sizecells != 2)) + panic("Cannot cope with this size\n"); - /* ePAPR 3.4 */ - ret = snprintf(buf, sizeof(buf), "%s@%"PRIx64, name, unit); + /* See linux Documentation/devicetree/bindings/arm/xen.txt */ + res = fdt_begin_node(fdt, "hypervisor"); + if ( res ) + return res; - if ( ret >= sizeof(buf) ) - { - printk(XENLOG_ERR - "Insufficient buffer. Minimum size required is %d\n", - (ret + 1)); + /* Cannot use fdt_property_string due to embedded nulls */ + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; - return -FDT_ERR_TRUNCATED; + if ( !opt_ext_regions ) + { + printk(XENLOG_INFO "%pd: extended regions support is disabled\n", d); + nr_ext_regions = 0; } + else if ( is_32bit_domain(d) ) + { + printk(XENLOG_WARNING + "%pd: extended regions not supported for 32-bit guests\n", d); + nr_ext_regions = 0; + } + else + { + ext_regions = xzalloc(struct meminfo); + if ( !ext_regions ) + return -ENOMEM; - return fdt_begin_node(fdt, buf); -} - -static int __init make_memory_node(const struct domain *d, - void *fdt, - int addrcells, int sizecells, - struct meminfo *mem) -{ - unsigned int i; - int res, reg_size = addrcells + sizecells; - int nr_cells = 0; - __be32 reg[NR_MEM_BANKS * 4 /* Worst case addrcells + sizecells */]; - __be32 *cells; - - if ( mem->nr_banks == 0 ) - return -ENOENT; - - /* find the first memory range that is reserved for device (or firmware) */ - for ( i = 0; i < mem->nr_banks && - (mem->bank[i].type != MEMBANK_DEFAULT); i++ ) - ; - - if ( i == mem->nr_banks ) - return 0; - - dt_dprintk("Create memory node\n"); + if ( is_domain_direct_mapped(d) ) + { + if ( !is_iommu_enabled(d) ) + res = find_unallocated_memory(kinfo, ext_regions); + else + res = find_memory_holes(kinfo, ext_regions); + } + else + { + res = find_domU_holes(kinfo, ext_regions); + } - res = domain_fdt_begin_node(fdt, "memory", mem->bank[i].start); - if ( res ) - return res; + if ( res ) + printk(XENLOG_WARNING "%pd: failed to allocate extended regions\n", + d); + nr_ext_regions = ext_regions->nr_banks; + } - res = fdt_property_string(fdt, "device_type", "memory"); - if ( res ) - return res; + reg = xzalloc_array(__be32, (nr_ext_regions + 1) * (addrcells + sizecells)); + if ( !reg ) + { + xfree(ext_regions); + return -ENOMEM; + } + /* reg 0 is grant table space */ cells = ®[0]; - for ( ; i < mem->nr_banks; i++ ) + dt_child_set_range(&cells, addrcells, sizecells, + kinfo->gnttab_start, kinfo->gnttab_size); + /* reg 1...N are extended regions */ + for ( i = 0; i < nr_ext_regions; i++ ) { - u64 start = mem->bank[i].start; - u64 size = mem->bank[i].size; - - if ( mem->bank[i].type == MEMBANK_STATIC_DOMAIN ) - continue; + u64 start = ext_regions->bank[i].start; + u64 size = ext_regions->bank[i].size; - dt_dprintk(" Bank %d: %#"PRIx64"->%#"PRIx64"\n", - i, start, start + size); + printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n", + d, i, start, start + size); - nr_cells += reg_size; - BUG_ON(nr_cells >= ARRAY_SIZE(reg)); dt_child_set_range(&cells, addrcells, sizecells, start, size); } - dt_dprintk("(reg size %d, nr cells %d)\n", reg_size, nr_cells); + res = fdt_property(fdt, "reg", reg, + dt_cells_to_size(addrcells + sizecells) * + (nr_ext_regions + 1)); + xfree(ext_regions); + xfree(reg); - res = fdt_property(fdt, "reg", reg, nr_cells * sizeof(*reg)); + if ( res ) + return res; + + BUG_ON(d->arch.evtchn_irq == 0); + + /* + * Interrupt event channel upcall: + * - Active-low level-sensitive + * - All CPUs + * TODO: Handle properly the cpumask; + */ + set_interrupt(intr, d->arch.evtchn_irq, 0xf, DT_IRQ_TYPE_LEVEL_LOW); + res = fdt_property_interrupts(kinfo, &intr, 1); if ( res ) return res; @@ -1403,1449 +1197,222 @@ static int __init make_memory_node(const struct domain *d, return res; } -#ifdef CONFIG_STATIC_SHM -static int __init make_shm_memory_node(const struct domain *d, - void *fdt, - int addrcells, int sizecells, - const struct meminfo *mem) +int __init make_psci_node(void *fdt) { - unsigned int i = 0; - int res = 0; - - if ( mem->nr_banks == 0 ) - return -ENOENT; - - /* - * For each shared memory region, a range is exposed under - * the /reserved-memory node as a child node. Each range sub-node is - * named xen-shmem@
. - */ - dt_dprintk("Create xen-shmem node\n"); - - for ( ; i < mem->nr_banks; i++ ) - { - uint64_t start = mem->bank[i].start; - uint64_t size = mem->bank[i].size; - const char compat[] = "xen,shared-memory-v1"; - /* Worst case addrcells + sizecells */ - __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; - __be32 *cells; - unsigned int len = (addrcells + sizecells) * sizeof(__be32); - - res = domain_fdt_begin_node(fdt, "xen-shmem", mem->bank[i].start); - if ( res ) - return res; - - res = fdt_property(fdt, "compatible", compat, sizeof(compat)); - if ( res ) - return res; - - cells = reg; - dt_child_set_range(&cells, addrcells, sizecells, start, size); - - res = fdt_property(fdt, "reg", reg, len); - if ( res ) - return res; - - dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", - i, start, start + size); - - res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); - if ( res ) - return res; - - /* - * TODO: - * - xen,offset: (borrower VMs only) - * 64 bit integer offset within the owner virtual machine's shared - * memory region used for the mapping in the borrower VM - */ - res = fdt_property_u64(fdt, "xen,offset", 0); - if ( res ) - return res; - - res = fdt_end_node(fdt); - if ( res ) - return res; - } - - return res; -} -#else -static int __init make_shm_memory_node(const struct domain *d, - void *fdt, - int addrcells, int sizecells, - const struct meminfo *mem) -{ - ASSERT_UNREACHABLE(); - return -EOPNOTSUPP; -} -#endif - -static int __init make_resv_memory_node(const struct domain *d, - void *fdt, - int addrcells, int sizecells, - const struct meminfo *mem) -{ - int res = 0; - /* Placeholder for reserved-memory\0 */ - const char resvbuf[16] = "reserved-memory"; - - if ( mem->nr_banks == 0 ) - /* No shared memory provided. */ - return 0; - - dt_dprintk("Create reserved-memory node\n"); - - res = fdt_begin_node(fdt, resvbuf); - if ( res ) - return res; - - res = fdt_property(fdt, "ranges", NULL, 0); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "#address-cells", addrcells); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "#size-cells", sizecells); - if ( res ) - return res; - - res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); - if ( res ) - return res; - - res = fdt_end_node(fdt); - - return res; -} - -static int __init add_ext_regions(unsigned long s_gfn, unsigned long e_gfn, - void *data) -{ - struct meminfo *ext_regions = data; - paddr_t start, size; - paddr_t s = pfn_to_paddr(s_gfn); - paddr_t e = pfn_to_paddr(e_gfn); - - if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) ) - return 0; - - /* - * Both start and size of the extended region should be 2MB aligned to - * potentially allow superpage mapping. - */ - start = (s + SZ_2M - 1) & ~(SZ_2M - 1); - if ( start > e ) - return 0; - - /* - * e is actually "end-1" because it is called by rangeset functions - * which are inclusive of the last address. - */ - e += 1; - size = (e - start) & ~(SZ_2M - 1); - - /* - * Reasonable size. Not too little to pick up small ranges which are - * not quite useful but increase bookkeeping and not too large - * to skip a large proportion of unused address space. - */ - if ( size < MB(64) ) - return 0; - - ext_regions->bank[ext_regions->nr_banks].start = start; - ext_regions->bank[ext_regions->nr_banks].size = size; - ext_regions->nr_banks++; - - return 0; -} - -/* - * Find unused regions of Host address space which can be exposed to Dom0 - * as extended regions for the special memory mappings. In order to calculate - * regions we exclude every region assigned to Dom0 from the Host RAM: - * - domain RAM - * - reserved-memory - * - grant table space - */ -static int __init find_unallocated_memory(const struct kernel_info *kinfo, - struct meminfo *ext_regions) -{ - const struct meminfo *assign_mem = &kinfo->mem; - struct rangeset *unalloc_mem; - paddr_t start, end; - unsigned int i; - int res; - - dt_dprintk("Find unallocated memory for extended regions\n"); - - unalloc_mem = rangeset_new(NULL, NULL, 0); - if ( !unalloc_mem ) - return -ENOMEM; - - /* Start with all available RAM */ - for ( i = 0; i < bootinfo.mem.nr_banks; i++ ) - { - start = bootinfo.mem.bank[i].start; - end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size; - res = rangeset_add_range(unalloc_mem, PFN_DOWN(start), - PFN_DOWN(end - 1)); - if ( res ) - { - printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - goto out; - } - } - - /* Remove RAM assigned to Dom0 */ - for ( i = 0; i < assign_mem->nr_banks; i++ ) - { - start = assign_mem->bank[i].start; - end = assign_mem->bank[i].start + assign_mem->bank[i].size; - res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), - PFN_DOWN(end - 1)); - if ( res ) - { - printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - goto out; - } - } - - /* Remove reserved-memory regions */ - for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ ) - { - start = bootinfo.reserved_mem.bank[i].start; - end = bootinfo.reserved_mem.bank[i].start + - bootinfo.reserved_mem.bank[i].size; - res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), - PFN_DOWN(end - 1)); - if ( res ) - { - printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - goto out; - } - } - - /* Remove grant table region */ - start = kinfo->gnttab_start; - end = kinfo->gnttab_start + kinfo->gnttab_size; - res = rangeset_remove_range(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end - 1)); - if ( res ) - { - printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - goto out; - } - - start = 0; - end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_report_ranges(unalloc_mem, PFN_DOWN(start), PFN_DOWN(end), - add_ext_regions, ext_regions); - if ( res ) - ext_regions->nr_banks = 0; - else if ( !ext_regions->nr_banks ) - res = -ENOENT; - -out: - rangeset_destroy(unalloc_mem); - - return res; -} - -static int __init handle_pci_range(const struct dt_device_node *dev, - uint64_t addr, uint64_t len, void *data) -{ - struct rangeset *mem_holes = data; - paddr_t start, end; - int res; - - if ( (addr != (paddr_t)addr) || (((paddr_t)~0 - addr) < len) ) - { - printk(XENLOG_ERR "%s: [0x%"PRIx64", 0x%"PRIx64"] exceeds the maximum allowed PA width (%u bits)", - dt_node_full_name(dev), addr, (addr + len), PADDR_BITS); - return -ERANGE; - } - - start = addr & PAGE_MASK; - end = PAGE_ALIGN(addr + len); - res = rangeset_remove_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end - 1)); - if ( res ) - { - printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - return res; - } - - return 0; -} - -/* - * Find the holes in the Host DT which can be exposed to Dom0 as extended - * regions for the special memory mappings. In order to calculate regions - * we exclude every addressable memory region described by "reg" and "ranges" - * properties from the maximum possible addressable physical memory range: - * - MMIO - * - Host RAM - * - PCI aperture - */ -static int __init find_memory_holes(const struct kernel_info *kinfo, - struct meminfo *ext_regions) -{ - struct dt_device_node *np; - struct rangeset *mem_holes; - paddr_t start, end; - unsigned int i; - int res; - - dt_dprintk("Find memory holes for extended regions\n"); - - mem_holes = rangeset_new(NULL, NULL, 0); - if ( !mem_holes ) - return -ENOMEM; - - /* Start with maximum possible addressable physical memory range */ - start = 0; - end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_add_range(mem_holes, PFN_DOWN(start), PFN_DOWN(end)); - if ( res ) - { - printk(XENLOG_ERR "Failed to add: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - goto out; - } - - /* - * Remove regions described by "reg" and "ranges" properties where - * the memory is addressable (MMIO, RAM, PCI BAR, etc). - */ - dt_for_each_device_node( dt_host, np ) - { - unsigned int naddr; - paddr_t addr, size; - - naddr = dt_number_of_address(np); - - for ( i = 0; i < naddr; i++ ) - { - res = dt_device_get_paddr(np, i, &addr, &size); - if ( res ) - { - printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", - i, dt_node_full_name(np)); - goto out; - } - - start = addr & PAGE_MASK; - end = PAGE_ALIGN(addr + size); - res = rangeset_remove_range(mem_holes, PFN_DOWN(start), - PFN_DOWN(end - 1)); - if ( res ) - { - printk(XENLOG_ERR "Failed to remove: %#"PRIpaddr"->%#"PRIpaddr"\n", - start, end); - goto out; - } - } - - if ( dt_device_type_is_equal(np, "pci") ) - { - /* - * The ranges property in this context describes the PCI host - * bridge aperture. It shall be absent if no addresses are mapped - * through the bridge. - */ - if ( !dt_get_property(np, "ranges", NULL) ) - continue; - - res = dt_for_each_range(np, &handle_pci_range, mem_holes); - if ( res ) - goto out; - } - } - - start = 0; - end = (1ULL << p2m_ipa_bits) - 1; - res = rangeset_report_ranges(mem_holes, PFN_DOWN(start), PFN_DOWN(end), - add_ext_regions, ext_regions); - if ( res ) - ext_regions->nr_banks = 0; - else if ( !ext_regions->nr_banks ) - res = -ENOENT; - -out: - rangeset_destroy(mem_holes); - - return res; -} - -static int __init find_domU_holes(const struct kernel_info *kinfo, - struct meminfo *ext_regions) -{ - unsigned int i; - uint64_t bankend; - const uint64_t bankbase[] = GUEST_RAM_BANK_BASES; - const uint64_t banksize[] = GUEST_RAM_BANK_SIZES; - int res = -ENOENT; - - for ( i = 0; i < GUEST_RAM_BANKS; i++ ) - { - struct membank *ext_bank = &(ext_regions->bank[ext_regions->nr_banks]); - - ext_bank->start = ROUNDUP(bankbase[i] + kinfo->mem.bank[i].size, SZ_2M); - - bankend = ~0ULL >> (64 - p2m_ipa_bits); - bankend = min(bankend, bankbase[i] + banksize[i] - 1); - if ( bankend > ext_bank->start ) - ext_bank->size = bankend - ext_bank->start + 1; - - /* 64MB is the minimum size of an extended region */ - if ( ext_bank->size < MB(64) ) - continue; - ext_regions->nr_banks++; - res = 0; - } - - return res; -} - -static int __init make_hypervisor_node(struct domain *d, - const struct kernel_info *kinfo, - int addrcells, int sizecells) -{ - const char compat[] = - "xen,xen-" XEN_VERSION_STRING "\0" - "xen,xen"; - __be32 *reg, *cells; - gic_interrupt_t intr; - int res; - void *fdt = kinfo->fdt; - struct meminfo *ext_regions = NULL; - unsigned int i, nr_ext_regions; - - dt_dprintk("Create hypervisor node\n"); - - /* - * Sanity-check address sizes, since addresses and sizes which do - * not take up exactly 4 or 8 bytes are not supported. - */ - if ((addrcells != 1 && addrcells != 2) || - (sizecells != 1 && sizecells != 2)) - panic("Cannot cope with this size\n"); - - /* See linux Documentation/devicetree/bindings/arm/xen.txt */ - res = fdt_begin_node(fdt, "hypervisor"); - if ( res ) - return res; - - /* Cannot use fdt_property_string due to embedded nulls */ - res = fdt_property(fdt, "compatible", compat, sizeof(compat)); - if ( res ) - return res; - - if ( !opt_ext_regions ) - { - printk(XENLOG_INFO "%pd: extended regions support is disabled\n", d); - nr_ext_regions = 0; - } - else if ( is_32bit_domain(d) ) - { - printk(XENLOG_WARNING - "%pd: extended regions not supported for 32-bit guests\n", d); - nr_ext_regions = 0; - } - else - { - ext_regions = xzalloc(struct meminfo); - if ( !ext_regions ) - return -ENOMEM; - - if ( is_domain_direct_mapped(d) ) - { - if ( !is_iommu_enabled(d) ) - res = find_unallocated_memory(kinfo, ext_regions); - else - res = find_memory_holes(kinfo, ext_regions); - } - else - { - res = find_domU_holes(kinfo, ext_regions); - } - - if ( res ) - printk(XENLOG_WARNING "%pd: failed to allocate extended regions\n", - d); - nr_ext_regions = ext_regions->nr_banks; - } - - reg = xzalloc_array(__be32, (nr_ext_regions + 1) * (addrcells + sizecells)); - if ( !reg ) - { - xfree(ext_regions); - return -ENOMEM; - } - - /* reg 0 is grant table space */ - cells = ®[0]; - dt_child_set_range(&cells, addrcells, sizecells, - kinfo->gnttab_start, kinfo->gnttab_size); - /* reg 1...N are extended regions */ - for ( i = 0; i < nr_ext_regions; i++ ) - { - u64 start = ext_regions->bank[i].start; - u64 size = ext_regions->bank[i].size; - - printk("%pd: extended region %d: %#"PRIx64"->%#"PRIx64"\n", - d, i, start, start + size); - - dt_child_set_range(&cells, addrcells, sizecells, start, size); - } - - res = fdt_property(fdt, "reg", reg, - dt_cells_to_size(addrcells + sizecells) * - (nr_ext_regions + 1)); - xfree(ext_regions); - xfree(reg); - - if ( res ) - return res; - - BUG_ON(d->arch.evtchn_irq == 0); - - /* - * Interrupt event channel upcall: - * - Active-low level-sensitive - * - All CPUs - * TODO: Handle properly the cpumask; - */ - set_interrupt(intr, d->arch.evtchn_irq, 0xf, DT_IRQ_TYPE_LEVEL_LOW); - res = fdt_property_interrupts(kinfo, &intr, 1); - if ( res ) - return res; - - res = fdt_end_node(fdt); - - return res; -} - -static int __init make_psci_node(void *fdt) -{ - int res; - const char compat[] = - "arm,psci-1.0""\0" - "arm,psci-0.2""\0" - "arm,psci"; - - dt_dprintk("Create PSCI node\n"); - - /* See linux Documentation/devicetree/bindings/arm/psci.txt */ - res = fdt_begin_node(fdt, "psci"); - if ( res ) - return res; - - res = fdt_property(fdt, "compatible", compat, sizeof(compat)); - if ( res ) - return res; - - res = fdt_property_string(fdt, "method", "hvc"); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "cpu_off", PSCI_cpu_off); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "cpu_on", PSCI_cpu_on); - if ( res ) - return res; - - res = fdt_end_node(fdt); - - return res; -} - -static int __init make_cpus_node(const struct domain *d, void *fdt) -{ - int res; - const struct dt_device_node *cpus = dt_find_node_by_path("/cpus"); - const struct dt_device_node *npcpu; - unsigned int cpu; - const void *compatible = NULL; - u32 len; - /* Placeholder for cpu@ + a 32-bit hexadecimal number + \0 */ - char buf[13]; - u32 clock_frequency; - /* Keep the compiler happy with -Og */ - bool clock_valid = false; - uint64_t mpidr_aff; - - dt_dprintk("Create cpus node\n"); - - if ( !cpus ) - { - dprintk(XENLOG_ERR, "Missing /cpus node in the device tree?\n"); - return -ENOENT; - } - - /* - * Get the compatible property of CPUs from the device tree. - * We are assuming that all CPUs are the same so we are just look - * for the first one. - * TODO: Handle compatible per VCPU - */ - dt_for_each_child_node(cpus, npcpu) - { - if ( dt_device_type_is_equal(npcpu, "cpu") ) - { - compatible = dt_get_property(npcpu, "compatible", &len); - clock_valid = dt_property_read_u32(npcpu, "clock-frequency", - &clock_frequency); - break; - } - } - - if ( !compatible ) - { - dprintk(XENLOG_ERR, "Can't find cpu in the device tree?\n"); - return -ENOENT; - } - - /* See Linux Documentation/devicetree/booting-without-of.txt - * section III.5.b - */ - res = fdt_begin_node(fdt, "cpus"); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "#address-cells", 1); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "#size-cells", 0); - if ( res ) - return res; - - for ( cpu = 0; cpu < d->max_vcpus; cpu++ ) - { - /* - * According to ARM CPUs bindings, the reg field should match - * the MPIDR's affinity bits. We will use AFF0 and AFF1 when - * constructing the reg value of the guest at the moment, for it - * is enough for the current max vcpu number. - * - * We only deal with AFF{0, 1, 2} stored in bits [23:0] at the - * moment. - */ - mpidr_aff = vcpuid_to_vaffinity(cpu); - if ( (mpidr_aff & ~GENMASK_ULL(23, 0)) != 0 ) - { - printk(XENLOG_ERR "Unable to handle MPIDR AFFINITY 0x%"PRIx64"\n", - mpidr_aff); - return -EINVAL; - } - - dt_dprintk("Create cpu@%"PRIx64" (logical CPUID: %d) node\n", - mpidr_aff, cpu); - - /* - * We use PRIx64 because mpidr_aff is a 64bit integer. However, - * only bits [23:0] are used, thus, we are sure it will fit in - * buf. - */ - snprintf(buf, sizeof(buf), "cpu@%"PRIx64, mpidr_aff); - res = fdt_begin_node(fdt, buf); - if ( res ) - return res; - - res = fdt_property(fdt, "compatible", compatible, len); - if ( res ) - return res; - - res = fdt_property_string(fdt, "device_type", "cpu"); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "reg", mpidr_aff); - if ( res ) - return res; - - if ( clock_valid ) - { - res = fdt_property_cell(fdt, "clock-frequency", clock_frequency); - if ( res ) - return res; - } - - if ( is_64bit_domain(d) ) - { - res = fdt_property_string(fdt, "enable-method", "psci"); - if ( res ) - return res; - } - - res = fdt_end_node(fdt); - if ( res ) - return res; - } - - res = fdt_end_node(fdt); - - return res; -} - -static int __init make_gic_node(const struct domain *d, void *fdt, - const struct dt_device_node *node) -{ - const struct dt_device_node *gic = dt_interrupt_controller; - int res = 0; - const void *addrcells, *sizecells; - u32 addrcells_len, sizecells_len; - - /* - * Xen currently supports only a single GIC. Discard any secondary - * GIC entries. - */ - if ( node != dt_interrupt_controller ) - { - dt_dprintk(" Skipping (secondary GIC)\n"); - return 0; - } - - dt_dprintk("Create gic node\n"); - - res = fdt_begin_node(fdt, "interrupt-controller"); - if ( res ) - return res; - - /* - * The value of the property "phandle" in the property "interrupts" - * to know on which interrupt controller the interrupt is wired. - */ - if ( gic->phandle ) - { - dt_dprintk(" Set phandle = 0x%x\n", gic->phandle); - res = fdt_property_cell(fdt, "phandle", gic->phandle); - if ( res ) - return res; - } - - addrcells = dt_get_property(gic, "#address-cells", &addrcells_len); - if ( addrcells ) - { - res = fdt_property(fdt, "#address-cells", addrcells, addrcells_len); - if ( res ) - return res; - } - - sizecells = dt_get_property(gic, "#size-cells", &sizecells_len); - if ( sizecells ) - { - res = fdt_property(fdt, "#size-cells", sizecells, sizecells_len); - if ( res ) - return res; - } - - res = fdt_property_cell(fdt, "#interrupt-cells", 3); - if ( res ) - return res; - - res = fdt_property(fdt, "interrupt-controller", NULL, 0); - if ( res ) - return res; - - res = gic_make_hwdom_dt_node(d, node, fdt); - if ( res ) - return res; - - res = fdt_end_node(fdt); - - return res; -} - -static int __init make_timer_node(const struct kernel_info *kinfo) -{ - void *fdt = kinfo->fdt; - static const struct dt_device_match timer_ids[] __initconst = - { - DT_MATCH_TIMER, - { /* sentinel */ }, - }; - struct dt_device_node *dev; - int res; - unsigned int irq[MAX_TIMER_PPI]; - gic_interrupt_t intrs[3]; - u32 clock_frequency; - bool clock_valid; - - dt_dprintk("Create timer node\n"); - - dev = dt_find_matching_node(NULL, timer_ids); - if ( !dev ) - { - dprintk(XENLOG_ERR, "Missing timer node in the device tree?\n"); - return -FDT_ERR_XEN(ENOENT); - } - - res = fdt_begin_node(fdt, "timer"); - if ( res ) - return res; - - if ( !is_64bit_domain(kinfo->d) ) - res = fdt_property_string(fdt, "compatible", "arm,armv7-timer"); - else - res = fdt_property_string(fdt, "compatible", "arm,armv8-timer"); - if ( res ) - return res; - - /* - * The timer IRQ is emulated by Xen. - * It always exposes an active-low level-sensitive interrupt. - */ - - if ( is_hardware_domain(kinfo->d) ) - { - irq[TIMER_PHYS_SECURE_PPI] = timer_get_irq(TIMER_PHYS_SECURE_PPI); - irq[TIMER_PHYS_NONSECURE_PPI] = - timer_get_irq(TIMER_PHYS_NONSECURE_PPI); - irq[TIMER_VIRT_PPI] = timer_get_irq(TIMER_VIRT_PPI); - } - else - { - irq[TIMER_PHYS_SECURE_PPI] = GUEST_TIMER_PHYS_S_PPI; - irq[TIMER_PHYS_NONSECURE_PPI] = GUEST_TIMER_PHYS_NS_PPI; - irq[TIMER_VIRT_PPI] = GUEST_TIMER_VIRT_PPI; - } - dt_dprintk(" Secure interrupt %u\n", irq[TIMER_PHYS_SECURE_PPI]); - set_interrupt(intrs[0], irq[TIMER_PHYS_SECURE_PPI], - 0xf, DT_IRQ_TYPE_LEVEL_LOW); - dt_dprintk(" Non secure interrupt %u\n", irq[TIMER_PHYS_NONSECURE_PPI]); - set_interrupt(intrs[1], irq[TIMER_PHYS_NONSECURE_PPI], - 0xf, DT_IRQ_TYPE_LEVEL_LOW); - dt_dprintk(" Virt interrupt %u\n", irq[TIMER_VIRT_PPI]); - set_interrupt(intrs[2], irq[TIMER_VIRT_PPI], 0xf, DT_IRQ_TYPE_LEVEL_LOW); - - res = fdt_property_interrupts(kinfo, intrs, 3); - if ( res ) - return res; - - clock_valid = dt_property_read_u32(dev, "clock-frequency", - &clock_frequency); - if ( clock_valid ) - { - res = fdt_property_cell(fdt, "clock-frequency", clock_frequency); - if ( res ) - return res; - } - - res = fdt_end_node(fdt); - - return res; -} - -/* - * This function is used as part of the device tree generation for Dom0 - * on ACPI systems, and DomUs started directly from Xen based on device - * tree information. - */ -int __init make_chosen_node(const struct kernel_info *kinfo) -{ - int res; - const char *bootargs = NULL; - const struct bootmodule *mod = kinfo->kernel_bootmodule; - void *fdt = kinfo->fdt; - - dt_dprintk("Create chosen node\n"); - res = fdt_begin_node(fdt, "chosen"); - if ( res ) - return res; - - if ( kinfo->cmdline && kinfo->cmdline[0] ) - { - bootargs = &kinfo->cmdline[0]; - res = fdt_property(fdt, "bootargs", bootargs, strlen(bootargs) + 1); - if ( res ) - return res; - } - - /* - * If the bootloader provides an initrd, we must create a placeholder - * for the initrd properties. The values will be replaced later. - */ - if ( mod && mod->size ) - { - u64 a = 0; - res = fdt_property(kinfo->fdt, "linux,initrd-start", &a, sizeof(a)); - if ( res ) - return res; - - res = fdt_property(kinfo->fdt, "linux,initrd-end", &a, sizeof(a)); - if ( res ) - return res; - } - - res = fdt_end_node(fdt); - - return res; -} - -int __init map_irq_to_domain(struct domain *d, unsigned int irq, - bool need_mapping, const char *devname) -{ - int res; - - res = irq_permit_access(d, irq); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to %pd access to IRQ %u\n", d, irq); - return res; - } - - if ( need_mapping ) - { - /* - * Checking the return of vgic_reserve_virq is not - * necessary. It should not fail except when we try to map - * the IRQ twice. This can legitimately happen if the IRQ is shared - */ - vgic_reserve_virq(d, irq); - - res = route_irq_to_guest(d, irq, irq, devname); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map IRQ%u to %pd\n", irq, d); - return res; - } - } - - dt_dprintk(" - IRQ: %u\n", irq); - return 0; -} - -static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, - const struct dt_irq *dt_irq, - void *data) -{ - struct map_range_data *mr_data = data; - struct domain *d = mr_data->d; - unsigned int irq = dt_irq->irq; - int res; - - if ( irq < NR_LOCAL_IRQS ) - { - printk(XENLOG_ERR "%s: IRQ%u is not a SPI\n", dt_node_name(dev), irq); - return -EINVAL; - } - - /* Setup the IRQ type */ - res = irq_set_spi_type(irq, dt_irq->type); - if ( res ) - { - printk(XENLOG_ERR "%s: Unable to setup IRQ%u to %pd\n", - dt_node_name(dev), irq, d); - return res; - } - - res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev)); - - return res; -} - -int __init map_range_to_domain(const struct dt_device_node *dev, - uint64_t addr, uint64_t len, void *data) -{ - struct map_range_data *mr_data = data; - struct domain *d = mr_data->d; - int res; - - if ( (addr != (paddr_t)addr) || (((paddr_t)~0 - addr) < len) ) - { - printk(XENLOG_ERR "%s: [0x%"PRIx64", 0x%"PRIx64"] exceeds the maximum allowed PA width (%u bits)", - dt_node_full_name(dev), addr, (addr + len), PADDR_BITS); - return -ERANGE; - } - - /* - * reserved-memory regions are RAM carved out for a special purpose. - * They are not MMIO and therefore a domain should not be able to - * manage them via the IOMEM interface. - */ - if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", - strlen("/reserved-memory/")) != 0 ) - { - res = iomem_permit_access(d, paddr_to_pfn(addr), - paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); - if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIx64" - 0x%"PRIx64"\n", - d->domain_id, - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); - return res; - } - } - - if ( !mr_data->skip_mapping ) - { - res = map_regions_p2mt(d, - gaddr_to_gfn(addr), - PFN_UP(len), - maddr_to_mfn(addr), - mr_data->p2mt); - - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to map 0x%"PRIx64 - " - 0x%"PRIx64" in domain %d\n", - addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, - d->domain_id); - return res; - } - } - - dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", - addr, addr + len, mr_data->p2mt); - - return 0; -} - -/* - * For a node which describes a discoverable bus (such as a PCI bus) - * then we may need to perform additional mappings in order to make - * the child resources available to domain 0. - */ -static int __init map_device_children(const struct dt_device_node *dev, - struct map_range_data *mr_data) -{ - if ( dt_device_type_is_equal(dev, "pci") ) - { - int ret; - - dt_dprintk("Mapping children of %s to guest\n", - dt_node_full_name(dev)); - - ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data); - if ( ret < 0 ) - return ret; - - ret = dt_for_each_range(dev, &map_range_to_domain, mr_data); - if ( ret < 0 ) - return ret; - } - - return 0; -} - -/* - * handle_device_interrupts retrieves the interrupts configuration from - * a device tree node and maps those interrupts to the target domain. - * - * Returns: - * < 0 error - * 0 success - */ -static int __init handle_device_interrupts(struct domain *d, - struct dt_device_node *dev, - bool need_mapping) -{ - unsigned int i, nirq; - int res; - struct dt_raw_irq rirq; - - nirq = dt_number_of_irq(dev); - - /* Give permission and map IRQs */ - for ( i = 0; i < nirq; i++ ) - { - res = dt_device_get_raw_irq(dev, i, &rirq); - if ( res ) - { - printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - /* - * Don't map IRQ that have no physical meaning - * ie: IRQ whose controller is not the GIC - */ - if ( rirq.controller != dt_interrupt_controller ) - { - dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", - i, dt_node_full_name(rirq.controller)); - continue; - } - - res = platform_get_irq(dev, i); - if ( res < 0 ) - { - printk(XENLOG_ERR "Unable to get irq %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); - if ( res ) - return res; - } - - return 0; -} - -/* - * For a given device node: - * - Give permission to the guest to manage IRQ and MMIO range - * - Retrieve the IRQ configuration (i.e edge/level) from device tree - * When the device is not marked for guest passthrough: - * - Try to call iommu_add_dt_device to protect the device by an IOMMU - * - Assign the device to the guest if it's protected by an IOMMU - * - Map the IRQs and iomem regions to DOM0 - */ -static int __init handle_device(struct domain *d, struct dt_device_node *dev, - p2m_type_t p2mt) -{ - unsigned int naddr; - unsigned int i; int res; - paddr_t addr, size; - bool own_device = !dt_device_for_passthrough(dev); - /* - * We want to avoid mapping the MMIO in dom0 for the following cases: - * - The device is owned by dom0 (i.e. it has been flagged for - * passthrough). - * - PCI host bridges with driver in Xen. They will later be mapped by - * pci_host_bridge_mappings(). - */ - struct map_range_data mr_data = { - .d = d, - .p2mt = p2mt, - .skip_mapping = !own_device || - (is_pci_passthrough_enabled() && - (device_get_class(dev) == DEVICE_PCI_HOSTBRIDGE)) - }; - - naddr = dt_number_of_address(dev); - - dt_dprintk("%s passthrough = %d naddr = %u\n", - dt_node_full_name(dev), own_device, naddr); - - if ( own_device ) - { - dt_dprintk("Check if %s is behind the IOMMU and add it\n", - dt_node_full_name(dev)); - - res = iommu_add_dt_device(dev); - if ( res < 0 ) - { - printk(XENLOG_ERR "Failed to add %s to the IOMMU\n", - dt_node_full_name(dev)); - return res; - } - - if ( dt_device_is_protected(dev) ) - { - dt_dprintk("%s setup iommu\n", dt_node_full_name(dev)); - res = iommu_assign_dt_device(d, dev); - if ( res ) - { - printk(XENLOG_ERR "Failed to setup the IOMMU for %s\n", - dt_node_full_name(dev)); - return res; - } - } - } - - res = handle_device_interrupts(d, dev, own_device); - if ( res < 0 ) - return res; - - /* Give permission and map MMIOs */ - for ( i = 0; i < naddr; i++ ) - { - res = dt_device_get_paddr(dev, i, &addr, &size); - if ( res ) - { - printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", - i, dt_node_full_name(dev)); - return res; - } - - res = map_range_to_domain(dev, addr, size, &mr_data); - if ( res ) - return res; - } - - res = map_device_children(dev, &mr_data); - if ( res ) - return res; - - return 0; -} - -static int __init handle_node(struct domain *d, struct kernel_info *kinfo, - struct dt_device_node *node, - p2m_type_t p2mt) -{ - static const struct dt_device_match skip_matches[] __initconst = - { - DT_MATCH_COMPATIBLE("xen,xen"), - DT_MATCH_COMPATIBLE("xen,multiboot-module"), - DT_MATCH_COMPATIBLE("multiboot,module"), - DT_MATCH_COMPATIBLE("arm,psci"), - DT_MATCH_COMPATIBLE("arm,psci-0.2"), - DT_MATCH_COMPATIBLE("arm,psci-1.0"), - DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"), - DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"), - DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"), - DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"), - DT_MATCH_PATH("/cpus"), - DT_MATCH_TYPE("memory"), - /* The memory mapped timer is not supported by Xen. */ - DT_MATCH_COMPATIBLE("arm,armv7-timer-mem"), - { /* sentinel */ }, - }; - static const struct dt_device_match timer_matches[] __initconst = - { - DT_MATCH_TIMER, - { /* sentinel */ }, - }; - static const struct dt_device_match reserved_matches[] __initconst = - { - DT_MATCH_PATH("/psci"), - DT_MATCH_PATH("/memory"), - DT_MATCH_PATH("/hypervisor"), - { /* sentinel */ }, - }; - struct dt_device_node *child; - int res, i, nirq, irq_id; - const char *name; - const char *path; + const char compat[] = + "arm,psci-1.0""\0" + "arm,psci-0.2""\0" + "arm,psci"; - path = dt_node_full_name(node); + dt_dprintk("Create PSCI node\n"); - dt_dprintk("handle %s\n", path); + /* See linux Documentation/devicetree/bindings/arm/psci.txt */ + res = fdt_begin_node(fdt, "psci"); + if ( res ) + return res; - /* Skip theses nodes and the sub-nodes */ - if ( dt_match_node(skip_matches, node) ) - { - dt_dprintk(" Skip it (matched)\n"); - return 0; - } - if ( platform_device_is_blacklisted(node) ) - { - dt_dprintk(" Skip it (blacklisted)\n"); - return 0; - } + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; - /* - * Replace these nodes with our own. Note that the original may be - * used_by DOMID_XEN so this check comes first. - */ - if ( device_get_class(node) == DEVICE_GIC ) - return make_gic_node(d, kinfo->fdt, node); - if ( dt_match_node(timer_matches, node) ) - return make_timer_node(kinfo); + res = fdt_property_string(fdt, "method", "hvc"); + if ( res ) + return res; - /* Skip nodes used by Xen */ - if ( dt_device_used_by(node) == DOMID_XEN ) - { - dt_dprintk(" Skip it (used by Xen)\n"); - return 0; - } + res = fdt_property_cell(fdt, "cpu_off", PSCI_cpu_off); + if ( res ) + return res; - /* - * Even if the IOMMU device is not used by Xen, it should not be - * passthrough to DOM0 - */ - if ( device_get_class(node) == DEVICE_IOMMU ) + res = fdt_property_cell(fdt, "cpu_on", PSCI_cpu_on); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + +int __init make_cpus_node(const struct domain *d, void *fdt) +{ + int res; + const struct dt_device_node *cpus = dt_find_node_by_path("/cpus"); + const struct dt_device_node *npcpu; + unsigned int cpu; + const void *compatible = NULL; + u32 len; + /* Placeholder for cpu@ + a 32-bit hexadecimal number + \0 */ + char buf[13]; + u32 clock_frequency; + /* Keep the compiler happy with -Og */ + bool clock_valid = false; + uint64_t mpidr_aff; + + dt_dprintk("Create cpus node\n"); + + if ( !cpus ) { - dt_dprintk(" IOMMU, skip it\n"); - return 0; + dprintk(XENLOG_ERR, "Missing /cpus node in the device tree?\n"); + return -ENOENT; } /* - * The vGIC does not support routing hardware PPIs to guest. So - * we need to skip any node using PPIs. + * Get the compatible property of CPUs from the device tree. + * We are assuming that all CPUs are the same so we are just look + * for the first one. + * TODO: Handle compatible per VCPU */ - nirq = dt_number_of_irq(node); - - for ( i = 0 ; i < nirq ; i++ ) + dt_for_each_child_node(cpus, npcpu) { - irq_id = platform_get_irq(node, i); - - /* PPIs ranges from ID 16 to 31 */ - if ( irq_id >= 16 && irq_id < 32 ) + if ( dt_device_type_is_equal(npcpu, "cpu") ) { - dt_dprintk(" Skip it (using PPIs)\n"); - return 0; + compatible = dt_get_property(npcpu, "compatible", &len); + clock_valid = dt_property_read_u32(npcpu, "clock-frequency", + &clock_frequency); + break; } } - /* - * Xen is using some path for its own purpose. Warn if a node - * already exists with the same path. - */ - if ( dt_match_node(reserved_matches, node) ) - printk(XENLOG_WARNING - "WARNING: Path %s is reserved, skip the node as we may re-use the path.\n", - path); - - res = handle_device(d, node, p2mt); - if ( res) - return res; + if ( !compatible ) + { + dprintk(XENLOG_ERR, "Can't find cpu in the device tree?\n"); + return -ENOENT; + } - /* - * The property "name" is used to have a different name on older FDT - * version. We want to keep the name retrieved during the tree - * structure creation, that is store in the node path. + /* See Linux Documentation/devicetree/booting-without-of.txt + * section III.5.b */ - name = strrchr(path, '/'); - name = name ? name + 1 : path; - - res = fdt_begin_node(kinfo->fdt, name); + res = fdt_begin_node(fdt, "cpus"); if ( res ) return res; - res = write_properties(d, kinfo, node); + res = fdt_property_cell(fdt, "#address-cells", 1); if ( res ) return res; - for ( child = node->child; child != NULL; child = child->sibling ) - { - res = handle_node(d, kinfo, child, p2mt); - if ( res ) - return res; - } + res = fdt_property_cell(fdt, "#size-cells", 0); + if ( res ) + return res; - if ( node == dt_host ) + for ( cpu = 0; cpu < d->max_vcpus; cpu++ ) { - int addrcells = dt_child_n_addr_cells(node); - int sizecells = dt_child_n_size_cells(node); - /* - * It is safe to allocate the event channel here because all the - * PPIs used by the hardware domain have been registered. + * According to ARM CPUs bindings, the reg field should match + * the MPIDR's affinity bits. We will use AFF0 and AFF1 when + * constructing the reg value of the guest at the moment, for it + * is enough for the current max vcpu number. + * + * We only deal with AFF{0, 1, 2} stored in bits [23:0] at the + * moment. */ - evtchn_allocate(d); + mpidr_aff = vcpuid_to_vaffinity(cpu); + if ( (mpidr_aff & ~GENMASK_ULL(23, 0)) != 0 ) + { + printk(XENLOG_ERR "Unable to handle MPIDR AFFINITY 0x%"PRIx64"\n", + mpidr_aff); + return -EINVAL; + } + + dt_dprintk("Create cpu@%"PRIx64" (logical CPUID: %d) node\n", + mpidr_aff, cpu); /* - * The hypervisor node should always be created after all nodes - * from the host DT have been parsed. + * We use PRIx64 because mpidr_aff is a 64bit integer. However, + * only bits [23:0] are used, thus, we are sure it will fit in + * buf. */ - res = make_hypervisor_node(d, kinfo, addrcells, sizecells); + snprintf(buf, sizeof(buf), "cpu@%"PRIx64, mpidr_aff); + res = fdt_begin_node(fdt, buf); if ( res ) return res; - res = make_psci_node(kinfo->fdt); + res = fdt_property(fdt, "compatible", compatible, len); if ( res ) return res; - res = make_cpus_node(d, kinfo->fdt); + res = fdt_property_string(fdt, "device_type", "cpu"); if ( res ) return res; - res = make_memory_node(d, kinfo->fdt, addrcells, sizecells, &kinfo->mem); + res = fdt_property_cell(fdt, "reg", mpidr_aff); if ( res ) return res; - /* - * Create a second memory node to store the ranges covering - * reserved-memory regions. - */ - if ( bootinfo.reserved_mem.nr_banks > 0 ) + if ( clock_valid ) { - res = make_memory_node(d, kinfo->fdt, addrcells, sizecells, - &bootinfo.reserved_mem); + res = fdt_property_cell(fdt, "clock-frequency", clock_frequency); if ( res ) return res; } - res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, - &kinfo->shm_mem); + if ( is_64bit_domain(d) ) + { + res = fdt_property_string(fdt, "enable-method", "psci"); + if ( res ) + return res; + } + + res = fdt_end_node(fdt); if ( res ) return res; } - res = fdt_end_node(kinfo->fdt); + res = fdt_end_node(fdt); return res; } -#ifdef CONFIG_VGICV2 -static int __init make_gicv2_domU_node(struct kernel_info *kinfo) +static int __init make_gic_node(const struct domain *d, void *fdt, + const struct dt_device_node *node) { - void *fdt = kinfo->fdt; + const struct dt_device_node *gic = dt_interrupt_controller; int res = 0; - __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2]; - __be32 *cells; - const struct domain *d = kinfo->d; - - res = domain_fdt_begin_node(fdt, "interrupt-controller", - vgic_dist_base(&d->arch.vgic)); - if ( res ) - return res; - - res = fdt_property_cell(fdt, "#address-cells", 0); - if ( res ) - return res; + const void *addrcells, *sizecells; + u32 addrcells_len, sizecells_len; - res = fdt_property_cell(fdt, "#interrupt-cells", 3); - if ( res ) - return res; + /* + * Xen currently supports only a single GIC. Discard any secondary + * GIC entries. + */ + if ( node != dt_interrupt_controller ) + { + dt_dprintk(" Skipping (secondary GIC)\n"); + return 0; + } - res = fdt_property(fdt, "interrupt-controller", NULL, 0); - if ( res ) - return res; + dt_dprintk("Create gic node\n"); - res = fdt_property_string(fdt, "compatible", "arm,gic-400"); + res = fdt_begin_node(fdt, "interrupt-controller"); if ( res ) return res; - cells = ®[0]; - dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, - vgic_dist_base(&d->arch.vgic), GUEST_GICD_SIZE); - dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, - vgic_cpu_base(&d->arch.vgic), GUEST_GICC_SIZE); - - res = fdt_property(fdt, "reg", reg, sizeof(reg)); - if (res) - return res; - - res = fdt_property_cell(fdt, "linux,phandle", kinfo->phandle_gic); - if (res) - return res; - - res = fdt_property_cell(fdt, "phandle", kinfo->phandle_gic); - if (res) - return res; - - res = fdt_end_node(fdt); - - return res; -} -#endif - -#ifdef CONFIG_GICV3 -static int __init make_gicv3_domU_node(struct kernel_info *kinfo) -{ - void *fdt = kinfo->fdt; - int res = 0; - __be32 *reg, *cells; - const struct domain *d = kinfo->d; - unsigned int i, len = 0; + /* + * The value of the property "phandle" in the property "interrupts" + * to know on which interrupt controller the interrupt is wired. + */ + if ( gic->phandle ) + { + dt_dprintk(" Set phandle = 0x%x\n", gic->phandle); + res = fdt_property_cell(fdt, "phandle", gic->phandle); + if ( res ) + return res; + } - res = domain_fdt_begin_node(fdt, "interrupt-controller", - vgic_dist_base(&d->arch.vgic)); - if ( res ) - return res; + addrcells = dt_get_property(gic, "#address-cells", &addrcells_len); + if ( addrcells ) + { + res = fdt_property(fdt, "#address-cells", addrcells, addrcells_len); + if ( res ) + return res; + } - res = fdt_property_cell(fdt, "#address-cells", 0); - if ( res ) - return res; + sizecells = dt_get_property(gic, "#size-cells", &sizecells_len); + if ( sizecells ) + { + res = fdt_property(fdt, "#size-cells", sizecells, sizecells_len); + if ( res ) + return res; + } res = fdt_property_cell(fdt, "#interrupt-cells", 3); if ( res ) @@ -2855,533 +1422,621 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo) if ( res ) return res; - res = fdt_property_string(fdt, "compatible", "arm,gic-v3"); + res = gic_make_hwdom_dt_node(d, node, fdt); if ( res ) return res; - /* reg specifies all re-distributors and Distributor. */ - len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * - (d->arch.vgic.nr_regions + 1) * sizeof(__be32); - reg = xmalloc_bytes(len); - if ( reg == NULL ) - return -ENOMEM; - cells = reg; - - dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, - vgic_dist_base(&d->arch.vgic), GUEST_GICV3_GICD_SIZE); - - for ( i = 0; i < d->arch.vgic.nr_regions; i++ ) - dt_child_set_range(&cells, - GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, - d->arch.vgic.rdist_regions[i].base, - d->arch.vgic.rdist_regions[i].size); - - res = fdt_property(fdt, "reg", reg, len); - xfree(reg); - if (res) - return res; - - res = fdt_property_cell(fdt, "linux,phandle", kinfo->phandle_gic); - if (res) - return res; - - res = fdt_property_cell(fdt, "phandle", kinfo->phandle_gic); - if (res) - return res; - res = fdt_end_node(fdt); return res; } -#endif - -static int __init make_gic_domU_node(struct kernel_info *kinfo) -{ - switch ( kinfo->d->arch.vgic.version ) - { -#ifdef CONFIG_GICV3 - case GIC_V3: - return make_gicv3_domU_node(kinfo); -#endif -#ifdef CONFIG_VGICV2 - case GIC_V2: - return make_gicv2_domU_node(kinfo); -#endif - default: - panic("Unsupported GIC version\n"); - } -} -#ifdef CONFIG_SBSA_VUART_CONSOLE -static int __init make_vpl011_uart_node(struct kernel_info *kinfo) +int __init make_timer_node(const struct kernel_info *kinfo) { void *fdt = kinfo->fdt; + static const struct dt_device_match timer_ids[] __initconst = + { + DT_MATCH_TIMER, + { /* sentinel */ }, + }; + struct dt_device_node *dev; int res; - gic_interrupt_t intr; - __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; - __be32 *cells; - struct domain *d = kinfo->d; + unsigned int irq[MAX_TIMER_PPI]; + gic_interrupt_t intrs[3]; + u32 clock_frequency; + bool clock_valid; - res = domain_fdt_begin_node(fdt, "sbsa-uart", d->arch.vpl011.base_addr); - if ( res ) - return res; + dt_dprintk("Create timer node\n"); + + dev = dt_find_matching_node(NULL, timer_ids); + if ( !dev ) + { + dprintk(XENLOG_ERR, "Missing timer node in the device tree?\n"); + return -FDT_ERR_XEN(ENOENT); + } - res = fdt_property_string(fdt, "compatible", "arm,sbsa-uart"); + res = fdt_begin_node(fdt, "timer"); if ( res ) return res; - cells = ®[0]; - dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, - GUEST_ROOT_SIZE_CELLS, d->arch.vpl011.base_addr, - GUEST_PL011_SIZE); - - res = fdt_property(fdt, "reg", reg, sizeof(reg)); + if ( !is_64bit_domain(kinfo->d) ) + res = fdt_property_string(fdt, "compatible", "arm,armv7-timer"); + else + res = fdt_property_string(fdt, "compatible", "arm,armv8-timer"); if ( res ) return res; - set_interrupt(intr, d->arch.vpl011.virq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH); + /* + * The timer IRQ is emulated by Xen. + * It always exposes an active-low level-sensitive interrupt. + */ - res = fdt_property(fdt, "interrupts", intr, sizeof (intr)); - if ( res ) - return res; + if ( is_hardware_domain(kinfo->d) ) + { + irq[TIMER_PHYS_SECURE_PPI] = timer_get_irq(TIMER_PHYS_SECURE_PPI); + irq[TIMER_PHYS_NONSECURE_PPI] = + timer_get_irq(TIMER_PHYS_NONSECURE_PPI); + irq[TIMER_VIRT_PPI] = timer_get_irq(TIMER_VIRT_PPI); + } + else + { + irq[TIMER_PHYS_SECURE_PPI] = GUEST_TIMER_PHYS_S_PPI; + irq[TIMER_PHYS_NONSECURE_PPI] = GUEST_TIMER_PHYS_NS_PPI; + irq[TIMER_VIRT_PPI] = GUEST_TIMER_VIRT_PPI; + } + dt_dprintk(" Secure interrupt %u\n", irq[TIMER_PHYS_SECURE_PPI]); + set_interrupt(intrs[0], irq[TIMER_PHYS_SECURE_PPI], + 0xf, DT_IRQ_TYPE_LEVEL_LOW); + dt_dprintk(" Non secure interrupt %u\n", irq[TIMER_PHYS_NONSECURE_PPI]); + set_interrupt(intrs[1], irq[TIMER_PHYS_NONSECURE_PPI], + 0xf, DT_IRQ_TYPE_LEVEL_LOW); + dt_dprintk(" Virt interrupt %u\n", irq[TIMER_VIRT_PPI]); + set_interrupt(intrs[2], irq[TIMER_VIRT_PPI], 0xf, DT_IRQ_TYPE_LEVEL_LOW); - res = fdt_property_cell(fdt, "interrupt-parent", - kinfo->phandle_gic); + res = fdt_property_interrupts(kinfo, intrs, 3); if ( res ) return res; - /* Use a default baud rate of 115200. */ - fdt_property_u32(fdt, "current-speed", 115200); + clock_valid = dt_property_read_u32(dev, "clock-frequency", + &clock_frequency); + if ( clock_valid ) + { + res = fdt_property_cell(fdt, "clock-frequency", clock_frequency); + if ( res ) + return res; + } res = fdt_end_node(fdt); - if ( res ) - return res; - return 0; + return res; } -#endif /* - * Scan device tree properties for passthrough specific information. - * Returns < 0 on error - * 0 on success + * This function is used as part of the device tree generation for Dom0 + * on ACPI systems, and DomUs started directly from Xen based on device + * tree information. */ -static int __init handle_passthrough_prop(struct kernel_info *kinfo, - const struct fdt_property *xen_reg, - const struct fdt_property *xen_path, - bool xen_force, - uint32_t address_cells, uint32_t size_cells) +int __init make_chosen_node(const struct kernel_info *kinfo) { - const __be32 *cell; - unsigned int i, len; - struct dt_device_node *node; int res; - paddr_t mstart, size, gstart; + const char *bootargs = NULL; + const struct bootmodule *mod = kinfo->kernel_bootmodule; + void *fdt = kinfo->fdt; - /* xen,reg specifies where to map the MMIO region */ - cell = (const __be32 *)xen_reg->data; - len = fdt32_to_cpu(xen_reg->len) / ((address_cells * 2 + size_cells) * - sizeof(uint32_t)); + dt_dprintk("Create chosen node\n"); + res = fdt_begin_node(fdt, "chosen"); + if ( res ) + return res; - for ( i = 0; i < len; i++ ) + if ( kinfo->cmdline && kinfo->cmdline[0] ) { - device_tree_get_reg(&cell, address_cells, size_cells, - &mstart, &size); - gstart = dt_next_cell(address_cells, &cell); + bootargs = &kinfo->cmdline[0]; + res = fdt_property(fdt, "bootargs", bootargs, strlen(bootargs) + 1); + if ( res ) + return res; + } - if ( gstart & ~PAGE_MASK || mstart & ~PAGE_MASK || size & ~PAGE_MASK ) - { - printk(XENLOG_ERR - "DomU passthrough config has not page aligned addresses/sizes\n"); - return -EINVAL; - } + /* + * If the bootloader provides an initrd, we must create a placeholder + * for the initrd properties. The values will be replaced later. + */ + if ( mod && mod->size ) + { + u64 a = 0; + res = fdt_property(kinfo->fdt, "linux,initrd-start", &a, sizeof(a)); + if ( res ) + return res; - res = iomem_permit_access(kinfo->d, paddr_to_pfn(mstart), - paddr_to_pfn(PAGE_ALIGN(mstart + size - 1))); + res = fdt_property(kinfo->fdt, "linux,initrd-end", &a, sizeof(a)); if ( res ) - { - printk(XENLOG_ERR "Unable to permit to dom%d access to" - " 0x%"PRIpaddr" - 0x%"PRIpaddr"\n", - kinfo->d->domain_id, - mstart & PAGE_MASK, PAGE_ALIGN(mstart + size) - 1); return res; - } + } + + res = fdt_end_node(fdt); + + return res; +} + +int __init map_irq_to_domain(struct domain *d, unsigned int irq, + bool need_mapping, const char *devname) +{ + int res; + + res = irq_permit_access(d, irq); + if ( res ) + { + printk(XENLOG_ERR "Unable to permit to %pd access to IRQ %u\n", d, irq); + return res; + } + + if ( need_mapping ) + { + /* + * Checking the return of vgic_reserve_virq is not + * necessary. It should not fail except when we try to map + * the IRQ twice. This can legitimately happen if the IRQ is shared + */ + vgic_reserve_virq(d, irq); - res = map_regions_p2mt(kinfo->d, - gaddr_to_gfn(gstart), - PFN_DOWN(size), - maddr_to_mfn(mstart), - p2m_mmio_direct_dev); + res = route_irq_to_guest(d, irq, irq, devname); if ( res < 0 ) { - printk(XENLOG_ERR - "Failed to map %"PRIpaddr" to the guest at%"PRIpaddr"\n", - mstart, gstart); - return -EFAULT; + printk(XENLOG_ERR "Unable to map IRQ%u to %pd\n", irq, d); + return res; } } - /* - * If xen_force, we let the user assign a MMIO region with no - * associated path. - */ - if ( xen_path == NULL ) - return xen_force ? 0 : -EINVAL; + dt_dprintk(" - IRQ: %u\n", irq); + return 0; +} - /* - * xen,path specifies the corresponding node in the host DT. - * Both interrupt mappings and IOMMU settings are based on it, - * as they are done based on the corresponding host DT node. - */ - node = dt_find_node_by_path(xen_path->data); - if ( node == NULL ) +static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, + const struct dt_irq *dt_irq, + void *data) +{ + struct map_range_data *mr_data = data; + struct domain *d = mr_data->d; + unsigned int irq = dt_irq->irq; + int res; + + if ( irq < NR_LOCAL_IRQS ) { - printk(XENLOG_ERR "Couldn't find node %s in host_dt!\n", - (char *)xen_path->data); + printk(XENLOG_ERR "%s: IRQ%u is not a SPI\n", dt_node_name(dev), irq); return -EINVAL; } - res = handle_device_interrupts(kinfo->d, node, true); - if ( res < 0 ) - return res; - - res = iommu_add_dt_device(node); - if ( res < 0 ) + /* Setup the IRQ type */ + res = irq_set_spi_type(irq, dt_irq->type); + if ( res ) + { + printk(XENLOG_ERR "%s: Unable to setup IRQ%u to %pd\n", + dt_node_name(dev), irq, d); return res; + } - /* If xen_force, we allow assignment of devices without IOMMU protection. */ - if ( xen_force && !dt_device_is_protected(node) ) - return 0; + res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev)); - return iommu_assign_dt_device(kinfo->d, node); + return res; } -static int __init handle_prop_pfdt(struct kernel_info *kinfo, - const void *pfdt, int nodeoff, - uint32_t address_cells, uint32_t size_cells, - bool scan_passthrough_prop) +int __init map_range_to_domain(const struct dt_device_node *dev, + uint64_t addr, uint64_t len, void *data) { - void *fdt = kinfo->fdt; - int propoff, nameoff, res; - const struct fdt_property *prop, *xen_reg = NULL, *xen_path = NULL; - const char *name; - bool found, xen_force = false; + struct map_range_data *mr_data = data; + struct domain *d = mr_data->d; + int res; - for ( propoff = fdt_first_property_offset(pfdt, nodeoff); - propoff >= 0; - propoff = fdt_next_property_offset(pfdt, propoff) ) + if ( (addr != (paddr_t)addr) || (((paddr_t)~0 - addr) < len) ) { - if ( !(prop = fdt_get_property_by_offset(pfdt, propoff, NULL)) ) - return -FDT_ERR_INTERNAL; - - found = false; - nameoff = fdt32_to_cpu(prop->nameoff); - name = fdt_string(pfdt, nameoff); - - if ( scan_passthrough_prop ) - { - if ( dt_prop_cmp("xen,reg", name) == 0 ) - { - xen_reg = prop; - found = true; - } - else if ( dt_prop_cmp("xen,path", name) == 0 ) - { - xen_path = prop; - found = true; - } - else if ( dt_prop_cmp("xen,force-assign-without-iommu", - name) == 0 ) - { - xen_force = true; - found = true; - } - } + printk(XENLOG_ERR "%s: [0x%"PRIx64", 0x%"PRIx64"] exceeds the maximum allowed PA width (%u bits)", + dt_node_full_name(dev), addr, (addr + len), PADDR_BITS); + return -ERANGE; + } - /* - * Copy properties other than the ones above: xen,reg, xen,path, - * and xen,force-assign-without-iommu. - */ - if ( !found ) + /* + * reserved-memory regions are RAM carved out for a special purpose. + * They are not MMIO and therefore a domain should not be able to + * manage them via the IOMEM interface. + */ + if ( strncasecmp(dt_node_full_name(dev), "/reserved-memory/", + strlen("/reserved-memory/")) != 0 ) + { + res = iomem_permit_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); + if ( res ) { - res = fdt_property(fdt, name, prop->data, fdt32_to_cpu(prop->len)); - if ( res ) - return res; + printk(XENLOG_ERR "Unable to permit to dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1); + return res; } } - /* - * Only handle passthrough properties if both xen,reg and xen,path - * are present, or if xen,force-assign-without-iommu is specified. - */ - if ( xen_reg != NULL && (xen_path != NULL || xen_force) ) + if ( !mr_data->skip_mapping ) { - res = handle_passthrough_prop(kinfo, xen_reg, xen_path, xen_force, - address_cells, size_cells); + res = map_regions_p2mt(d, + gaddr_to_gfn(addr), + PFN_UP(len), + maddr_to_mfn(addr), + mr_data->p2mt); + if ( res < 0 ) { - printk(XENLOG_ERR "Failed to assign device to %pd\n", kinfo->d); + printk(XENLOG_ERR "Unable to map 0x%"PRIx64 + " - 0x%"PRIx64" in domain %d\n", + addr & PAGE_MASK, PAGE_ALIGN(addr + len) - 1, + d->domain_id); return res; } } - else if ( (xen_path && !xen_reg) || (xen_reg && !xen_path && !xen_force) ) - { - printk(XENLOG_ERR "xen,reg or xen,path missing for %pd\n", - kinfo->d); - return -EINVAL; - } - /* FDT_ERR_NOTFOUND => There is no more properties for this node */ - return ( propoff != -FDT_ERR_NOTFOUND ) ? propoff : 0; + dt_dprintk(" - MMIO: %010"PRIx64" - %010"PRIx64" P2MType=%x\n", + addr, addr + len, mr_data->p2mt); + + return 0; } -static int __init scan_pfdt_node(struct kernel_info *kinfo, const void *pfdt, - int nodeoff, - uint32_t address_cells, uint32_t size_cells, - bool scan_passthrough_prop) +/* + * For a node which describes a discoverable bus (such as a PCI bus) + * then we may need to perform additional mappings in order to make + * the child resources available to domain 0. + */ +static int __init map_device_children(const struct dt_device_node *dev, + struct map_range_data *mr_data) { - int rc = 0; - void *fdt = kinfo->fdt; - int node_next; - - rc = fdt_begin_node(fdt, fdt_get_name(pfdt, nodeoff, NULL)); - if ( rc ) - return rc; + if ( dt_device_type_is_equal(dev, "pci") ) + { + int ret; - rc = handle_prop_pfdt(kinfo, pfdt, nodeoff, address_cells, size_cells, - scan_passthrough_prop); - if ( rc ) - return rc; + dt_dprintk("Mapping children of %s to guest\n", + dt_node_full_name(dev)); - address_cells = device_tree_get_u32(pfdt, nodeoff, "#address-cells", - DT_ROOT_NODE_ADDR_CELLS_DEFAULT); - size_cells = device_tree_get_u32(pfdt, nodeoff, "#size-cells", - DT_ROOT_NODE_SIZE_CELLS_DEFAULT); + ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data); + if ( ret < 0 ) + return ret; - node_next = fdt_first_subnode(pfdt, nodeoff); - while ( node_next > 0 ) - { - scan_pfdt_node(kinfo, pfdt, node_next, address_cells, size_cells, - scan_passthrough_prop); - node_next = fdt_next_subnode(pfdt, node_next); + ret = dt_for_each_range(dev, &map_range_to_domain, mr_data); + if ( ret < 0 ) + return ret; } - return fdt_end_node(fdt); + return 0; } -static int __init check_partial_fdt(void *pfdt, size_t size) +/* + * handle_device_interrupts retrieves the interrupts configuration from + * a device tree node and maps those interrupts to the target domain. + * + * Returns: + * < 0 error + * 0 success + */ +int __init handle_device_interrupts(struct domain *d, + struct dt_device_node *dev, + bool need_mapping) { + unsigned int i, nirq; int res; + struct dt_raw_irq rirq; - if ( fdt_magic(pfdt) != FDT_MAGIC ) - { - dprintk(XENLOG_ERR, "Partial FDT is not a valid Flat Device Tree"); - return -EINVAL; - } + nirq = dt_number_of_irq(dev); - res = fdt_check_header(pfdt); - if ( res ) + /* Give permission and map IRQs */ + for ( i = 0; i < nirq; i++ ) { - dprintk(XENLOG_ERR, "Failed to check the partial FDT (%d)", res); - return -EINVAL; - } + res = dt_device_get_raw_irq(dev, i, &rirq); + if ( res ) + { + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } - if ( fdt_totalsize(pfdt) > size ) - { - dprintk(XENLOG_ERR, "Partial FDT totalsize is too big"); - return -EINVAL; + /* + * Don't map IRQ that have no physical meaning + * ie: IRQ whose controller is not the GIC + */ + if ( rirq.controller != dt_interrupt_controller ) + { + dt_dprintk("irq %u not connected to primary controller. Connected to %s\n", + i, dt_node_full_name(rirq.controller)); + continue; + } + + res = platform_get_irq(dev, i); + if ( res < 0 ) + { + printk(XENLOG_ERR "Unable to get irq %u for %s\n", + i, dt_node_full_name(dev)); + return res; + } + + res = map_irq_to_domain(d, res, need_mapping, dt_node_name(dev)); + if ( res ) + return res; } return 0; } -static int __init domain_handle_dtb_bootmodule(struct domain *d, - struct kernel_info *kinfo) +/* + * For a given device node: + * - Give permission to the guest to manage IRQ and MMIO range + * - Retrieve the IRQ configuration (i.e edge/level) from device tree + * When the device is not marked for guest passthrough: + * - Try to call iommu_add_dt_device to protect the device by an IOMMU + * - Assign the device to the guest if it's protected by an IOMMU + * - Map the IRQs and iomem regions to DOM0 + */ +static int __init handle_device(struct domain *d, struct dt_device_node *dev, + p2m_type_t p2mt) { - void *pfdt; - int res, node_next; + unsigned int naddr; + unsigned int i; + int res; + paddr_t addr, size; + bool own_device = !dt_device_for_passthrough(dev); + /* + * We want to avoid mapping the MMIO in dom0 for the following cases: + * - The device is owned by dom0 (i.e. it has been flagged for + * passthrough). + * - PCI host bridges with driver in Xen. They will later be mapped by + * pci_host_bridge_mappings(). + */ + struct map_range_data mr_data = { + .d = d, + .p2mt = p2mt, + .skip_mapping = !own_device || + (is_pci_passthrough_enabled() && + (device_get_class(dev) == DEVICE_PCI_HOSTBRIDGE)) + }; - pfdt = ioremap_cache(kinfo->dtb_bootmodule->start, - kinfo->dtb_bootmodule->size); - if ( pfdt == NULL ) - return -EFAULT; + naddr = dt_number_of_address(dev); - res = check_partial_fdt(pfdt, kinfo->dtb_bootmodule->size); - if ( res < 0 ) - goto out; + dt_dprintk("%s passthrough = %d naddr = %u\n", + dt_node_full_name(dev), own_device, naddr); - for ( node_next = fdt_first_subnode(pfdt, 0); - node_next > 0; - node_next = fdt_next_subnode(pfdt, node_next) ) + if ( own_device ) { - const char *name = fdt_get_name(pfdt, node_next, NULL); - - if ( name == NULL ) - continue; + dt_dprintk("Check if %s is behind the IOMMU and add it\n", + dt_node_full_name(dev)); - /* - * Only scan /gic /aliases /passthrough, ignore the rest. - * They don't have to be parsed in order. - * - * Take the GIC phandle value from the special /gic node in the - * DTB fragment. - */ - if ( dt_node_cmp(name, "gic") == 0 ) + res = iommu_add_dt_device(dev); + if ( res < 0 ) { - kinfo->phandle_gic = fdt_get_phandle(pfdt, node_next); - continue; + printk(XENLOG_ERR "Failed to add %s to the IOMMU\n", + dt_node_full_name(dev)); + return res; } - if ( dt_node_cmp(name, "aliases") == 0 ) + if ( dt_device_is_protected(dev) ) { - res = scan_pfdt_node(kinfo, pfdt, node_next, - DT_ROOT_NODE_ADDR_CELLS_DEFAULT, - DT_ROOT_NODE_SIZE_CELLS_DEFAULT, - false); + dt_dprintk("%s setup iommu\n", dt_node_full_name(dev)); + res = iommu_assign_dt_device(d, dev); if ( res ) - goto out; - continue; + { + printk(XENLOG_ERR "Failed to setup the IOMMU for %s\n", + dt_node_full_name(dev)); + return res; + } } - if ( dt_node_cmp(name, "passthrough") == 0 ) + } + + res = handle_device_interrupts(d, dev, own_device); + if ( res < 0 ) + return res; + + /* Give permission and map MMIOs */ + for ( i = 0; i < naddr; i++ ) + { + res = dt_device_get_paddr(dev, i, &addr, &size); + if ( res ) { - res = scan_pfdt_node(kinfo, pfdt, node_next, - DT_ROOT_NODE_ADDR_CELLS_DEFAULT, - DT_ROOT_NODE_SIZE_CELLS_DEFAULT, - true); - if ( res ) - goto out; - continue; + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(dev)); + return res; } + + res = map_range_to_domain(dev, addr, size, &mr_data); + if ( res ) + return res; } - out: - iounmap(pfdt); + res = map_device_children(dev, &mr_data); + if ( res ) + return res; - return res; + return 0; } -/* - * The max size for DT is 2MB. However, the generated DT is small (not including - * domU passthrough DT nodes whose size we account separately), 4KB are enough - * for now, but we might have to increase it in the future. - */ -#define DOMU_DTB_SIZE 4096 -static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) +static int __init handle_node(struct domain *d, struct kernel_info *kinfo, + struct dt_device_node *node, + p2m_type_t p2mt) { - int addrcells, sizecells; - int ret, fdt_size = DOMU_DTB_SIZE; - - kinfo->phandle_gic = GUEST_PHANDLE_GIC; - kinfo->gnttab_start = GUEST_GNTTAB_BASE; - kinfo->gnttab_size = GUEST_GNTTAB_SIZE; - - addrcells = GUEST_ROOT_ADDRESS_CELLS; - sizecells = GUEST_ROOT_SIZE_CELLS; - - /* Account for domU passthrough DT size */ - if ( kinfo->dtb_bootmodule ) - fdt_size += kinfo->dtb_bootmodule->size; - - /* Cap to max DT size if needed */ - fdt_size = min(fdt_size, SZ_2M); - - kinfo->fdt = xmalloc_bytes(fdt_size); - if ( kinfo->fdt == NULL ) - return -ENOMEM; + static const struct dt_device_match skip_matches[] __initconst = + { + DT_MATCH_COMPATIBLE("xen,xen"), + DT_MATCH_COMPATIBLE("xen,multiboot-module"), + DT_MATCH_COMPATIBLE("multiboot,module"), + DT_MATCH_COMPATIBLE("arm,psci"), + DT_MATCH_COMPATIBLE("arm,psci-0.2"), + DT_MATCH_COMPATIBLE("arm,psci-1.0"), + DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"), + DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"), + DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"), + DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"), + DT_MATCH_PATH("/cpus"), + DT_MATCH_TYPE("memory"), + /* The memory mapped timer is not supported by Xen. */ + DT_MATCH_COMPATIBLE("arm,armv7-timer-mem"), + { /* sentinel */ }, + }; + static const struct dt_device_match timer_matches[] __initconst = + { + DT_MATCH_TIMER, + { /* sentinel */ }, + }; + static const struct dt_device_match reserved_matches[] __initconst = + { + DT_MATCH_PATH("/psci"), + DT_MATCH_PATH("/memory"), + DT_MATCH_PATH("/hypervisor"), + { /* sentinel */ }, + }; + struct dt_device_node *child; + int res, i, nirq, irq_id; + const char *name; + const char *path; - ret = fdt_create(kinfo->fdt, fdt_size); - if ( ret < 0 ) - goto err; + path = dt_node_full_name(node); - ret = fdt_finish_reservemap(kinfo->fdt); - if ( ret < 0 ) - goto err; + dt_dprintk("handle %s\n", path); - ret = fdt_begin_node(kinfo->fdt, ""); - if ( ret < 0 ) - goto err; + /* Skip theses nodes and the sub-nodes */ + if ( dt_match_node(skip_matches, node) ) + { + dt_dprintk(" Skip it (matched)\n"); + return 0; + } + if ( platform_device_is_blacklisted(node) ) + { + dt_dprintk(" Skip it (blacklisted)\n"); + return 0; + } - ret = fdt_property_cell(kinfo->fdt, "#address-cells", addrcells); - if ( ret ) - goto err; + /* + * Replace these nodes with our own. Note that the original may be + * used_by DOMID_XEN so this check comes first. + */ + if ( device_get_class(node) == DEVICE_GIC ) + return make_gic_node(d, kinfo->fdt, node); + if ( dt_match_node(timer_matches, node) ) + return make_timer_node(kinfo); - ret = fdt_property_cell(kinfo->fdt, "#size-cells", sizecells); - if ( ret ) - goto err; + /* Skip nodes used by Xen */ + if ( dt_device_used_by(node) == DOMID_XEN ) + { + dt_dprintk(" Skip it (used by Xen)\n"); + return 0; + } - ret = make_chosen_node(kinfo); - if ( ret ) - goto err; + /* + * Even if the IOMMU device is not used by Xen, it should not be + * passthrough to DOM0 + */ + if ( device_get_class(node) == DEVICE_IOMMU ) + { + dt_dprintk(" IOMMU, skip it\n"); + return 0; + } - ret = make_psci_node(kinfo->fdt); - if ( ret ) - goto err; + /* + * The vGIC does not support routing hardware PPIs to guest. So + * we need to skip any node using PPIs. + */ + nirq = dt_number_of_irq(node); - ret = make_cpus_node(d, kinfo->fdt); - if ( ret ) - goto err; + for ( i = 0 ; i < nirq ; i++ ) + { + irq_id = platform_get_irq(node, i); - ret = make_memory_node(d, kinfo->fdt, addrcells, sizecells, &kinfo->mem); - if ( ret ) - goto err; + /* PPIs ranges from ID 16 to 31 */ + if ( irq_id >= 16 && irq_id < 32 ) + { + dt_dprintk(" Skip it (using PPIs)\n"); + return 0; + } + } - ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, - &kinfo->shm_mem); - if ( ret ) - goto err; + /* + * Xen is using some path for its own purpose. Warn if a node + * already exists with the same path. + */ + if ( dt_match_node(reserved_matches, node) ) + printk(XENLOG_WARNING + "WARNING: Path %s is reserved, skip the node as we may re-use the path.\n", + path); + + res = handle_device(d, node, p2mt); + if ( res) + return res; /* - * domain_handle_dtb_bootmodule has to be called before the rest of - * the device tree is generated because it depends on the value of - * the field phandle_gic. + * The property "name" is used to have a different name on older FDT + * version. We want to keep the name retrieved during the tree + * structure creation, that is store in the node path. */ - if ( kinfo->dtb_bootmodule ) - { - ret = domain_handle_dtb_bootmodule(d, kinfo); - if ( ret ) - goto err; - } + name = strrchr(path, '/'); + name = name ? name + 1 : path; - ret = make_gic_domU_node(kinfo); - if ( ret ) - goto err; + res = fdt_begin_node(kinfo->fdt, name); + if ( res ) + return res; - ret = make_timer_node(kinfo); - if ( ret ) - goto err; + res = write_properties(d, kinfo, node); + if ( res ) + return res; - if ( kinfo->vpl011 ) + for ( child = node->child; child != NULL; child = child->sibling ) { - ret = -EINVAL; -#ifdef CONFIG_SBSA_VUART_CONSOLE - ret = make_vpl011_uart_node(kinfo); -#endif - if ( ret ) - goto err; + res = handle_node(d, kinfo, child, p2mt); + if ( res ) + return res; } - if ( kinfo->dom0less_feature & DOM0LESS_ENHANCED_NO_XS ) + if ( node == dt_host ) { - ret = make_hypervisor_node(d, kinfo, addrcells, sizecells); - if ( ret ) - goto err; - } + int addrcells = dt_child_n_addr_cells(node); + int sizecells = dt_child_n_size_cells(node); - ret = fdt_end_node(kinfo->fdt); - if ( ret < 0 ) - goto err; + /* + * It is safe to allocate the event channel here because all the + * PPIs used by the hardware domain have been registered. + */ + evtchn_allocate(d); - ret = fdt_finish(kinfo->fdt); - if ( ret < 0 ) - goto err; + /* + * The hypervisor node should always be created after all nodes + * from the host DT have been parsed. + */ + res = make_hypervisor_node(d, kinfo, addrcells, sizecells); + if ( res ) + return res; - return 0; + res = make_psci_node(kinfo->fdt); + if ( res ) + return res; - err: - printk("Device tree generation failed (%d).\n", ret); - xfree(kinfo->fdt); + res = make_cpus_node(d, kinfo->fdt); + if ( res ) + return res; - return -EINVAL; + res = make_memory_node(d, kinfo->fdt, addrcells, sizecells, &kinfo->mem); + if ( res ) + return res; + + /* + * Create a second memory node to store the ranges covering + * reserved-memory regions. + */ + if ( bootinfo.reserved_mem.nr_banks > 0 ) + { + res = make_memory_node(d, kinfo->fdt, addrcells, sizecells, + &bootinfo.reserved_mem); + if ( res ) + return res; + } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( res ) + return res; + } + + res = fdt_end_node(kinfo->fdt); + + return res; } static int __init prepare_dtb_hwdom(struct domain *d, struct kernel_info *kinfo) @@ -3694,22 +2349,7 @@ static void __init find_gnttab_region(struct domain *d, kinfo->gnttab_start, kinfo->gnttab_start + kinfo->gnttab_size); } -static unsigned long __init domain_p2m_pages(unsigned long maxmem_kb, - unsigned int smp_cpus) -{ - /* - * Keep in sync with libxl__get_required_paging_memory(). - * 256 pages (1MB) per vcpu, plus 1 page per MiB of RAM for the P2M map, - * plus 128 pages to cover extended regions. - */ - unsigned long memkb = 4 * (256 * smp_cpus + (maxmem_kb / 1024) + 128); - - BUILD_BUG_ON(PAGE_SIZE != SZ_4K); - - return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT); -} - -static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) +int __init construct_domain(struct domain *d, struct kernel_info *kinfo) { unsigned int i; struct vcpu *v = d->vcpu[0]; @@ -3800,296 +2440,6 @@ static int __init construct_domain(struct domain *d, struct kernel_info *kinfo) return 0; } -static int __init alloc_xenstore_evtchn(struct domain *d) -{ - evtchn_alloc_unbound_t alloc; - int rc; - - alloc.dom = d->domain_id; - alloc.remote_dom = hardware_domain->domain_id; - rc = evtchn_alloc_unbound(&alloc, 0); - if ( rc ) - { - printk("Failed allocating event channel for domain\n"); - return rc; - } - - d->arch.hvm.params[HVM_PARAM_STORE_EVTCHN] = alloc.port; - - return 0; -} - -static int __init construct_domU(struct domain *d, - const struct dt_device_node *node) -{ - struct kernel_info kinfo = {}; - const char *dom0less_enhanced; - int rc; - u64 mem; - u32 p2m_mem_mb; - unsigned long p2m_pages; - - rc = dt_property_read_u64(node, "memory", &mem); - if ( !rc ) - { - printk("Error building DomU: cannot read \"memory\" property\n"); - return -EINVAL; - } - kinfo.unassigned_mem = (paddr_t)mem * SZ_1K; - - rc = dt_property_read_u32(node, "xen,domain-p2m-mem-mb", &p2m_mem_mb); - /* If xen,domain-p2m-mem-mb is not specified, use the default value. */ - p2m_pages = rc ? - p2m_mem_mb << (20 - PAGE_SHIFT) : - domain_p2m_pages(mem, d->max_vcpus); - - spin_lock(&d->arch.paging.lock); - rc = p2m_set_allocation(d, p2m_pages, NULL); - spin_unlock(&d->arch.paging.lock); - if ( rc != 0 ) - return rc; - - printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n", - d->max_vcpus, mem); - - kinfo.vpl011 = dt_property_read_bool(node, "vpl011"); - - rc = dt_property_read_string(node, "xen,enhanced", &dom0less_enhanced); - if ( rc == -EILSEQ || - rc == -ENODATA || - (rc == 0 && !strcmp(dom0less_enhanced, "enabled")) ) - { - if ( hardware_domain ) - kinfo.dom0less_feature = DOM0LESS_ENHANCED; - else - panic("At the moment, Xenstore support requires dom0 to be present\n"); - } - else if ( rc == 0 && !strcmp(dom0less_enhanced, "no-xenstore") ) - kinfo.dom0less_feature = DOM0LESS_ENHANCED_NO_XS; - - if ( vcpu_create(d, 0) == NULL ) - return -ENOMEM; - - d->max_pages = ((paddr_t)mem * SZ_1K) >> PAGE_SHIFT; - - kinfo.d = d; - - rc = kernel_probe(&kinfo, node); - if ( rc < 0 ) - return rc; - -#ifdef CONFIG_ARM_64 - /* type must be set before allocate memory */ - d->arch.type = kinfo.type; -#endif - if ( !dt_find_property(node, "xen,static-mem", NULL) ) - allocate_memory(d, &kinfo); - else if ( !is_domain_direct_mapped(d) ) - allocate_static_memory(d, &kinfo, node); - else - assign_static_memory_11(d, &kinfo, node); - -#ifdef CONFIG_STATIC_SHM - rc = process_shm(d, &kinfo, node); - if ( rc < 0 ) - return rc; -#endif - - /* - * Base address and irq number are needed when creating vpl011 device - * tree node in prepare_dtb_domU, so initialization on related variables - * shall be done first. - */ - if ( kinfo.vpl011 ) - { - rc = domain_vpl011_init(d, NULL); - if ( rc < 0 ) - return rc; - } - - rc = prepare_dtb_domU(d, &kinfo); - if ( rc < 0 ) - return rc; - - rc = construct_domain(d, &kinfo); - if ( rc < 0 ) - return rc; - - if ( kinfo.dom0less_feature & DOM0LESS_XENSTORE ) - { - ASSERT(hardware_domain); - rc = alloc_xenstore_evtchn(d); - if ( rc < 0 ) - return rc; - d->arch.hvm.params[HVM_PARAM_STORE_PFN] = ~0ULL; - } - - return rc; -} - -void __init create_domUs(void) -{ - struct dt_device_node *node; - const struct dt_device_node *cpupool_node, - *chosen = dt_find_node_by_path("/chosen"); - - BUG_ON(chosen == NULL); - dt_for_each_child_node(chosen, node) - { - struct domain *d; - struct xen_domctl_createdomain d_cfg = { - .arch.gic_version = XEN_DOMCTL_CONFIG_GIC_NATIVE, - .flags = XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - /* - * The default of 1023 should be sufficient for guests because - * on ARM we don't bind physical interrupts to event channels. - * The only use of the evtchn port is inter-domain communications. - * 1023 is also the default value used in libxl. - */ - .max_evtchn_port = 1023, - .max_grant_frames = -1, - .max_maptrack_frames = -1, - .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), - }; - unsigned int flags = 0U; - uint32_t val; - int rc; - - if ( !dt_device_is_compatible(node, "xen,domain") ) - continue; - - if ( (max_init_domid + 1) >= DOMID_FIRST_RESERVED ) - panic("No more domain IDs available\n"); - - if ( dt_find_property(node, "xen,static-mem", NULL) ) - flags |= CDF_staticmem; - - if ( dt_property_read_bool(node, "direct-map") ) - { - if ( !(flags & CDF_staticmem) ) - panic("direct-map is not valid for domain %s without static allocation.\n", - dt_node_name(node)); - - flags |= CDF_directmap; - } - - if ( !dt_property_read_u32(node, "cpus", &d_cfg.max_vcpus) ) - panic("Missing property 'cpus' for domain %s\n", - dt_node_name(node)); - - if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") && - iommu_enabled ) - d_cfg.flags |= XEN_DOMCTL_CDF_iommu; - - if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) ) - { - int vpl011_virq = GUEST_VPL011_SPI; - - d_cfg.arch.nr_spis = gic_number_lines() - 32; - - /* - * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map is - * set, in which case it'll match the hardware. - * - * Since the domain is not yet created, we can't use - * d->arch.vpl011.irq. So the logic to find the vIRQ has to - * be hardcoded. - * The logic here shall be consistent with the one in - * domain_vpl011_init(). - */ - if ( flags & CDF_directmap ) - { - vpl011_virq = serial_irq(SERHND_DTUART); - if ( vpl011_virq < 0 ) - panic("Error getting IRQ number for this serial port %d\n", - SERHND_DTUART); - } - - /* - * vpl011 uses one emulated SPI. If vpl011 is requested, make - * sure that we allocate enough SPIs for it. - */ - if ( dt_property_read_bool(node, "vpl011") ) - d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis, - vpl011_virq - 32 + 1); - } - - /* Get the optional property domain-cpupool */ - cpupool_node = dt_parse_phandle(node, "domain-cpupool", 0); - if ( cpupool_node ) - { - int pool_id = btcpupools_get_domain_pool_id(cpupool_node); - if ( pool_id < 0 ) - panic("Error getting cpupool id from domain-cpupool (%d)\n", - pool_id); - d_cfg.cpupool_id = pool_id; - } - - if ( dt_property_read_u32(node, "max_grant_version", &val) ) - d_cfg.grant_opts = XEN_DOMCTL_GRANT_version(val); - - if ( dt_property_read_u32(node, "max_grant_frames", &val) ) - { - if ( val > INT32_MAX ) - panic("max_grant_frames (%"PRIu32") overflow\n", val); - d_cfg.max_grant_frames = val; - } - - if ( dt_property_read_u32(node, "max_maptrack_frames", &val) ) - { - if ( val > INT32_MAX ) - panic("max_maptrack_frames (%"PRIu32") overflow\n", val); - d_cfg.max_maptrack_frames = val; - } - - if ( dt_get_property(node, "sve", &val) ) - { -#ifdef CONFIG_ARM64_SVE - unsigned int sve_vl_bits; - bool ret = false; - - if ( !val ) - { - /* Property found with no value, means max HW VL supported */ - ret = sve_domctl_vl_param(-1, &sve_vl_bits); - } - else - { - if ( dt_property_read_u32(node, "sve", &val) ) - ret = sve_domctl_vl_param(val, &sve_vl_bits); - else - panic("Error reading 'sve' property\n"); - } - - if ( ret ) - d_cfg.arch.sve_vl = sve_encode_vl(sve_vl_bits); - else - panic("SVE vector length error\n"); -#else - panic("'sve' property found, but CONFIG_ARM64_SVE not selected\n"); -#endif - } - - /* - * The variable max_init_domid is initialized with zero, so here it's - * very important to use the pre-increment operator to call - * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0) - */ - d = domain_create(++max_init_domid, &d_cfg, flags); - if ( IS_ERR(d) ) - panic("Error creating domain %s (rc = %ld)\n", - dt_node_name(node), PTR_ERR(d)); - - d->is_console = true; - dt_device_set_used_by(node, d->domain_id); - - rc = construct_domU(d, node); - if ( rc ) - panic("Could not set up domain %s (rc = %d)\n", - dt_node_name(node), rc); - } -} - static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; diff --git a/xen/arch/arm/include/asm/dom0less-build.h b/xen/arch/arm/include/asm/dom0less-build.h new file mode 100644 index 000000000000..868143d4f95a --- /dev/null +++ b/xen/arch/arm/include/asm/dom0less-build.h @@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/include/asm/dom0less-build.h + * + * Copyright (C) 2023 Arm Ltd. + */ + +#ifndef __ARM_DOM0LESS_BUILD_H_ +#define __ARM_DOM0LESS_BUILD_H_ + +#include + +void create_domUs(void); +void init_staticmem_pages(void); +bool is_dom0less_mode(void); +int make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, + int sizecells, const struct meminfo *mem); +int process_shm(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node); + +#endif /* __ARM_DOM0LESS_BUILD_H_ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End:b + */ diff --git a/xen/arch/arm/include/asm/domain_build.h b/xen/arch/arm/include/asm/domain_build.h index 34ceddc99576..57d24976e6aa 100644 --- a/xen/arch/arm/include/asm/domain_build.h +++ b/xen/arch/arm/include/asm/domain_build.h @@ -4,11 +4,44 @@ #include #include +typedef __be32 gic_interrupt_t[3]; + +int construct_domain(struct domain *d, struct kernel_info *kinfo); +int domain_fdt_begin_node(void *fdt, const char *name, uint64_t unit); int map_irq_to_domain(struct domain *d, unsigned int irq, bool need_mapping, const char *devname); +int make_resv_memory_node(const struct domain *d, void *fdt, int addrcells, + int sizecells, const struct meminfo *mem); int make_chosen_node(const struct kernel_info *kinfo); +int make_cpus_node(const struct domain *d, void *fdt); +int make_hypervisor_node(struct domain *d, const struct kernel_info *kinfo, + int addrcells, int sizecells); +int make_memory_node(const struct domain *d, void *fdt, int addrcells, + int sizecells, struct meminfo *mem); +int make_psci_node(void *fdt); +int make_timer_node(const struct kernel_info *kinfo); void evtchn_allocate(struct domain *d); +unsigned int get_allocation_size(paddr_t size); + +/* + * handle_device_interrupts retrieves the interrupts configuration from + * a device tree node and maps those interrupts to the target domain. + * + * Returns: + * < 0 error + * 0 success + */ +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, + bool need_mapping); + +/* + * Helper to write an interrupts with the GIC format + * This code is assuming the irq is an PPI. + */ +void set_interrupt(gic_interrupt_t interrupt, unsigned int irq, + unsigned int cpumask, unsigned int level); + #ifndef CONFIG_ACPI static inline int prepare_acpi(struct domain *d, struct kernel_info *kinfo) { diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 19dc637d55f5..2800c3ef6f21 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -132,7 +132,6 @@ void acpi_create_efi_mmap_table(struct domain *d, int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); -void create_domUs(void); void create_dom0(void); void alloc_static_evtchn(void); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index bbf72b69aae6..44bf872bc38f 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -33,6 +33,7 @@ #include #include #include +#include #include #include #include @@ -756,30 +757,6 @@ static void __init init_pdx(void) } } -/* Static memory initialization */ -static void __init init_staticmem_pages(void) -{ -#ifdef CONFIG_STATIC_MEMORY - unsigned int bank; - - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) - { - if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) - { - mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); - unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); - mfn_t bank_end = mfn_add(bank_start, bank_pages); - - if ( mfn_x(bank_end) <= mfn_x(bank_start) ) - return; - - unprepare_staticmem_pages(mfn_to_page(bank_start), - bank_pages, false); - } - } -#endif -} - /* * Populate the boot allocator. * If a static heap was not provided by the admin, all the RAM but the @@ -1041,38 +1018,6 @@ static void __init setup_mm(void) } #endif -static bool __init is_dom0less_mode(void) -{ - struct bootmodules *mods = &bootinfo.modules; - struct bootmodule *mod; - unsigned int i; - bool dom0found = false; - bool domUfound = false; - - /* Look into the bootmodules */ - for ( i = 0 ; i < mods->nr_mods ; i++ ) - { - mod = &mods->module[i]; - /* Find if dom0 and domU kernels are present */ - if ( mod->kind == BOOTMOD_KERNEL ) - { - if ( mod->domU == false ) - { - dom0found = true; - break; - } - else - domUfound = true; - } - } - - /* - * If there is no dom0 kernel but at least one domU, then we are in - * dom0less mode - */ - return ( !dom0found && domUfound ); -} - size_t __read_mostly dcache_line_bytes; /* C entry point for boot CPU */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:00:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579370.907346 (Exim 4.92) (envelope-from ) id 1qTHdo-0000gn-KA; Tue, 08 Aug 2023 08:00:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579370.907346; Tue, 08 Aug 2023 08:00:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdo-0000gS-E5; Tue, 08 Aug 2023 08:00:32 +0000 Received: by outflank-mailman (input) for mailman id 579370; Tue, 08 Aug 2023 08:00:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdn-0007uw-BJ for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:00:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a2f0dd85-35c1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:00:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A88114BF; Tue, 8 Aug 2023 01:01:09 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED9B63F6C4; Tue, 8 Aug 2023 01:00:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2f0dd85-35c1-11ee-8613-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 4/5] xen/arm: Move static memory build code in separate modules Date: Tue, 8 Aug 2023 09:00:09 +0100 Message-Id: <20230808080010.3858575-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808080010.3858575-1-luca.fancellu@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move static memory and static shared memory code in separate modules so that they are included only when the corresponding feature is enabled, doing that we modularise the features and we remove some ifdefs from the code to improve readability. Move process_shm_node function from bootfdt module and make it externally visible. The visibility of the functions allocate_static_memory and assign_static_memory_11 is changed during the move from the dom0less-build module to the static-memory module, now they are externally visible. A static inline helper called process_shm_chosen is introduced, it will call the process_shm function for the '/chosen' node, and will be used by the funciton construct_dom0 instead of using directly process_shm, allowing some #ifdef to be removed. No functional changes are intended. Signed-off-by: Luca Fancellu --- xen/arch/arm/Makefile | 2 + xen/arch/arm/bootfdt.c | 161 +----- xen/arch/arm/dom0less-build.c | 646 +--------------------- xen/arch/arm/domain_build.c | 8 +- xen/arch/arm/include/asm/dom0less-build.h | 7 - xen/arch/arm/include/asm/static-memory.h | 50 ++ xen/arch/arm/include/asm/static-shmem.h | 72 +++ xen/arch/arm/setup.c | 1 + xen/arch/arm/static-memory.c | 294 ++++++++++ xen/arch/arm/static-shmem.c | 515 +++++++++++++++++ 10 files changed, 939 insertions(+), 817 deletions(-) create mode 100644 xen/arch/arm/include/asm/static-memory.h create mode 100644 xen/arch/arm/include/asm/static-shmem.h create mode 100644 xen/arch/arm/static-memory.c create mode 100644 xen/arch/arm/static-shmem.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 70dd7201ef30..89ef0c9075b5 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -50,6 +50,8 @@ obj-y += setup.o obj-y += shutdown.o obj-y += smp.o obj-y += smpboot.o +obj-$(CONFIG_STATIC_MEMORY) += static-memory.init.o +obj-$(CONFIG_STATIC_SHM) += static-shmem.init.o obj-y += sysctl.o obj-y += time.o obj-y += traps.o diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 2673ad17a1e1..fcf851b4c99b 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -15,6 +15,7 @@ #include #include #include +#include static bool __init device_tree_node_matches(const void *fdt, int node, const char *match) @@ -402,166 +403,6 @@ static int __init process_domain_node(const void *fdt, int node, MEMBANK_STATIC_DOMAIN); } -#ifdef CONFIG_STATIC_SHM -static int __init process_shm_node(const void *fdt, int node, - uint32_t address_cells, uint32_t size_cells) -{ - const struct fdt_property *prop, *prop_id, *prop_role; - const __be32 *cell; - paddr_t paddr, gaddr, size; - struct meminfo *mem = &bootinfo.reserved_mem; - unsigned int i; - int len; - bool owner = false; - const char *shm_id; - - if ( address_cells < 1 || size_cells < 1 ) - { - printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); - return -EINVAL; - } - - /* - * "xen,shm-id" property holds an arbitrary string with a strict limit - * on the number of characters, MAX_SHM_ID_LENGTH - */ - prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); - if ( !prop_id ) - return -ENOENT; - shm_id = (const char *)prop_id->data; - if ( strnlen(shm_id, MAX_SHM_ID_LENGTH) == MAX_SHM_ID_LENGTH ) - { - printk("fdt: invalid xen,shm-id %s, it must be limited to %u characters\n", - shm_id, MAX_SHM_ID_LENGTH); - return -EINVAL; - } - - /* - * "role" property is optional and if it is defined explicitly, - * it must be either `owner` or `borrower`. - */ - prop_role = fdt_get_property(fdt, node, "role", NULL); - if ( prop_role ) - { - if ( !strcmp(prop_role->data, "owner") ) - owner = true; - else if ( strcmp(prop_role->data, "borrower") ) - { - printk("fdt: invalid `role` property for static shared memory node.\n"); - return -EINVAL; - } - } - - /* - * xen,shared-mem = ; - * Memory region starting from physical address #paddr of #size shall - * be mapped to guest physical address #gaddr as static shared memory - * region. - */ - prop = fdt_get_property(fdt, node, "xen,shared-mem", &len); - if ( !prop ) - return -ENOENT; - - if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) - { - if ( len == dt_cells_to_size(size_cells + address_cells) ) - printk("fdt: host physical address must be chosen by users at the moment.\n"); - - printk("fdt: invalid `xen,shared-mem` property.\n"); - return -EINVAL; - } - - cell = (const __be32 *)prop->data; - device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); - size = dt_next_cell(size_cells, &cell); - - if ( !size ) - { - printk("fdt: the size for static shared memory region can not be zero\n"); - return -EINVAL; - } - - for ( i = 0; i < mem->nr_banks; i++ ) - { - /* - * Meet the following check: - * 1) The shm ID matches and the region exactly match - * 2) The shm ID doesn't match and the region doesn't overlap - * with an existing one - */ - if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) - { - if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) - break; - else - { - printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", - shm_id); - return -EINVAL; - } - } - else - { - paddr_t end = paddr + size; - paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; - - if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) - { - printk("fdt: static shared memory region %s overflow\n", shm_id); - return -EINVAL; - } - - if ( check_reserved_regions_overlap(paddr, size) ) - return -EINVAL; - else - { - if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) - continue; - else - { - printk("fdt: different shared memory region could not share the same shm ID %s\n", - shm_id); - return -EINVAL; - } - } - } - } - - if ( i == mem->nr_banks ) - { - if ( i < NR_MEM_BANKS ) - { - /* Static shared memory shall be reserved from any other use. */ - safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); - mem->bank[mem->nr_banks].start = paddr; - mem->bank[mem->nr_banks].size = size; - mem->bank[mem->nr_banks].type = MEMBANK_STATIC_DOMAIN; - mem->nr_banks++; - } - else - { - printk("Warning: Max number of supported memory regions reached.\n"); - return -ENOSPC; - } - } - /* - * keep a count of the number of borrowers, which later may be used - * to calculate the reference count. - */ - if ( !owner ) - mem->bank[i].nr_shm_borrowers++; - - return 0; -} -#else -static int __init process_shm_node(const void *fdt, int node, - uint32_t address_cells, uint32_t size_cells) -{ - printk("CONFIG_STATIC_SHM must be enabled for parsing static shared memory nodes\n"); - return -EINVAL; -} -#endif - static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, diff --git a/xen/arch/arm/dom0less-build.c b/xen/arch/arm/dom0less-build.c index 9159837924de..4ca15f2a461b 100644 --- a/xen/arch/arm/dom0less-build.c +++ b/xen/arch/arm/dom0less-build.c @@ -21,30 +21,8 @@ #include #include #include - -/* Static memory initialization */ -void __init init_staticmem_pages(void) -{ -#ifdef CONFIG_STATIC_MEMORY - unsigned int bank; - - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) - { - if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) - { - mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); - unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); - mfn_t bank_end = mfn_add(bank_start, bank_pages); - - if ( mfn_x(bank_end) <= mfn_x(bank_start) ) - return; - - unprepare_staticmem_pages(mfn_to_page(bank_start), - bank_pages, false); - } - } -#endif -} +#include +#include bool __init is_dom0less_mode(void) { @@ -185,624 +163,6 @@ fail: (unsigned long)kinfo->unassigned_mem >> 10); } -#ifdef CONFIG_STATIC_MEMORY -static bool __init append_static_memory_to_bank(struct domain *d, - struct membank *bank, - mfn_t smfn, - paddr_t size) -{ - int res; - unsigned int nr_pages = PFN_DOWN(size); - gfn_t sgfn; - - /* - * For direct-mapped domain, the GFN match the MFN. - * Otherwise, this is inferred on what has already been allocated - * in the bank. - */ - if ( !is_domain_direct_mapped(d) ) - sgfn = gaddr_to_gfn(bank->start + bank->size); - else - sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); - - res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); - if ( res ) - { - dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); - return false; - } - - bank->size = bank->size + size; - - return true; -} - -static mfn_t __init acquire_static_memory_bank(struct domain *d, - const __be32 **cell, - u32 addr_cells, u32 size_cells, - paddr_t *pbase, paddr_t *psize) -{ - mfn_t smfn; - int res; - - device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); - ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); - if ( PFN_DOWN(*psize) > UINT_MAX ) - { - printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr, - d, *psize); - return INVALID_MFN; - } - - smfn = maddr_to_mfn(*pbase); - res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0); - if ( res ) - { - printk(XENLOG_ERR - "%pd: failed to acquire static memory: %d.\n", d, res); - return INVALID_MFN; - } - - return smfn; -} - -static int __init parse_static_mem_prop(const struct dt_device_node *node, - u32 *addr_cells, u32 *size_cells, - int *length, const __be32 **cell) -{ - const struct dt_property *prop; - - prop = dt_find_property(node, "xen,static-mem", NULL); - - *addr_cells = dt_n_addr_cells(node); - *size_cells = dt_n_size_cells(node); - - *cell = (const __be32 *)prop->value; - *length = prop->length; - - return 0; -} - -/* Allocate memory from static memory as RAM for one specific domain d. */ -static void __init allocate_static_memory(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - u32 addr_cells, size_cells, reg_cells; - unsigned int nr_banks, gbank, bank = 0; - const uint64_t rambase[] = GUEST_RAM_BANK_BASES; - const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; - const __be32 *cell; - u64 tot_size = 0; - paddr_t pbase, psize, gsize; - mfn_t smfn; - int length; - - if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) - goto fail; - reg_cells = addr_cells + size_cells; - - /* - * The static memory will be mapped in the guest at the usual guest memory - * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by - * xen/include/public/arch-arm.h. - */ - gbank = 0; - gsize = ramsize[gbank]; - kinfo->mem.bank[gbank].start = rambase[gbank]; - nr_banks = length / (reg_cells * sizeof (u32)); - - for ( ; bank < nr_banks; bank++ ) - { - smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, - &pbase, &psize); - if ( mfn_eq(smfn, INVALID_MFN) ) - goto fail; - - printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", - d, bank, pbase, pbase + psize); - - while ( 1 ) - { - /* Map as much as possible the static range to the guest bank */ - if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, - min(psize, gsize)) ) - goto fail; - - /* - * The current physical bank is fully mapped. - * Handle the next physical bank. - */ - if ( gsize >= psize ) - { - gsize = gsize - psize; - break; - } - /* - * When current guest bank is not enough to map, exhaust - * the current one and seek to the next. - * Before seeking to the next, check if we still have available - * guest bank. - */ - else if ( (gbank + 1) >= GUEST_RAM_BANKS ) - { - printk(XENLOG_ERR "Exhausted all possible guest banks.\n"); - goto fail; - } - else - { - psize = psize - gsize; - smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); - /* Update to the next guest bank. */ - gbank++; - gsize = ramsize[gbank]; - kinfo->mem.bank[gbank].start = rambase[gbank]; - } - } - - tot_size += psize; - } - - kinfo->mem.nr_banks = ++gbank; - - kinfo->unassigned_mem -= tot_size; - /* - * The property 'memory' should match the amount of memory given to the - * guest. - * Currently, it is only possible to either acquire static memory or let - * Xen allocate. *Mixing* is not supported. - */ - if ( kinfo->unassigned_mem ) - { - printk(XENLOG_ERR - "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n"); - goto fail; - } - - return; - - fail: - panic("Failed to allocate requested static memory for domain %pd.\n", d); -} - -/* - * Allocate static memory as RAM for one specific domain d. - * The static memory will be directly mapped in the guest(Guest Physical - * Address == Physical Address). - */ -static void __init assign_static_memory_11(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - u32 addr_cells, size_cells, reg_cells; - unsigned int nr_banks, bank = 0; - const __be32 *cell; - paddr_t pbase, psize; - mfn_t smfn; - int length; - - if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) - { - printk(XENLOG_ERR - "%pd: failed to parse \"xen,static-mem\" property.\n", d); - goto fail; - } - reg_cells = addr_cells + size_cells; - nr_banks = length / (reg_cells * sizeof(u32)); - - if ( nr_banks > NR_MEM_BANKS ) - { - printk(XENLOG_ERR - "%pd: exceed max number of supported guest memory banks.\n", d); - goto fail; - } - - for ( ; bank < nr_banks; bank++ ) - { - smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, - &pbase, &psize); - if ( mfn_eq(smfn, INVALID_MFN) ) - goto fail; - - printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", - d, bank, pbase, pbase + psize); - - /* One guest memory bank is matched with one physical memory bank. */ - kinfo->mem.bank[bank].start = pbase; - if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[bank], - smfn, psize) ) - goto fail; - - kinfo->unassigned_mem -= psize; - } - - kinfo->mem.nr_banks = nr_banks; - - /* - * The property 'memory' should match the amount of memory given to - * the guest. - * Currently, it is only possible to either acquire static memory or - * let Xen allocate. *Mixing* is not supported. - */ - if ( kinfo->unassigned_mem != 0 ) - { - printk(XENLOG_ERR - "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); - goto fail; - } - - return; - - fail: - panic("Failed to assign requested static memory for direct-map domain %pd.\n", - d); -} -#else /* !CONFIG_STATIC_MEMORY */ -static void __init allocate_static_memory(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - ASSERT_UNREACHABLE(); -} - -static void __init assign_static_memory_11(struct domain *d, - struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - ASSERT_UNREACHABLE(); -} -#endif /* CONFIG_STATIC_MEMORY */ - -#ifdef CONFIG_STATIC_SHM -static int __init acquire_nr_borrower_domain(struct domain *d, - paddr_t pbase, paddr_t psize, - unsigned long *nr_borrowers) -{ - unsigned int bank; - - /* Iterate reserved memory to find requested shm bank. */ - for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) - { - paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; - paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; - - if ( (pbase == bank_start) && (psize == bank_size) ) - break; - } - - if ( bank == bootinfo.reserved_mem.nr_banks ) - return -ENOENT; - - *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; - - return 0; -} - -/* - * This function checks whether the static shared memory region is - * already allocated to dom_io. - */ -static bool __init is_shm_allocated_to_domio(paddr_t pbase) -{ - struct page_info *page; - struct domain *d; - - page = maddr_to_page(pbase); - d = page_get_owner_and_reference(page); - if ( d == NULL ) - return false; - put_page(page); - - if ( d != dom_io ) - { - printk(XENLOG_ERR - "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", - d); - return false; - } - - return true; -} - -static mfn_t __init acquire_shared_memory_bank(struct domain *d, - paddr_t pbase, paddr_t psize) -{ - mfn_t smfn; - unsigned long nr_pfns; - int res; - - /* - * Pages of statically shared memory shall be included - * into domain_tot_pages(). - */ - nr_pfns = PFN_DOWN(psize); - if ( (UINT_MAX - d->max_pages) < nr_pfns ) - { - printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", - d, nr_pfns); - return INVALID_MFN; - } - d->max_pages += nr_pfns; - - smfn = maddr_to_mfn(pbase); - res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); - if ( res ) - { - printk(XENLOG_ERR - "%pd: failed to acquire static memory: %d.\n", d, res); - d->max_pages -= nr_pfns; - return INVALID_MFN; - } - - return smfn; -} - -static int __init assign_shared_memory(struct domain *d, - uint32_t addr_cells, uint32_t size_cells, - paddr_t pbase, paddr_t psize, - paddr_t gbase) -{ - mfn_t smfn; - int ret = 0; - unsigned long nr_pages, nr_borrowers, i; - struct page_info *page; - - printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", - d, pbase, pbase + psize); - - smfn = acquire_shared_memory_bank(d, pbase, psize); - if ( mfn_eq(smfn, INVALID_MFN) ) - return -EINVAL; - - /* - * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need - * to create mapping in the P2M. - */ - nr_pages = PFN_DOWN(psize); - if ( d != dom_io ) - { - ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, - PFN_DOWN(psize)); - if ( ret ) - { - printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); - return ret; - } - } - - /* - * Get the right amount of references per page, which is the number of - * borrower domains. - */ - ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); - if ( ret ) - return ret; - - /* - * Instead of letting borrower domain get a page ref, we add as many - * additional reference as the number of borrowers when the owner - * is allocated, since there is a chance that owner is created - * after borrower. - * So if the borrower is created first, it will cause adding pages - * in the P2M without reference. - */ - page = mfn_to_page(smfn); - for ( i = 0; i < nr_pages; i++ ) - { - if ( !get_page_nr(page + i, d, nr_borrowers) ) - { - printk(XENLOG_ERR - "Failed to add %lu references to page %"PRI_mfn".\n", - nr_borrowers, mfn_x(smfn) + i); - goto fail; - } - } - - return 0; - - fail: - while ( --i >= 0 ) - put_page_nr(page + i, nr_borrowers); - return ret; -} - -static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, - paddr_t start, paddr_t size, - const char *shm_id) -{ - if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) - return -ENOMEM; - - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; - kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; - safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); - kinfo->shm_mem.nr_banks++; - - return 0; -} - -int __init process_shm(struct domain *d, struct kernel_info *kinfo, - const struct dt_device_node *node) -{ - struct dt_device_node *shm_node; - - dt_for_each_child_node(node, shm_node) - { - const struct dt_property *prop; - const __be32 *cells; - uint32_t addr_cells, size_cells; - paddr_t gbase, pbase, psize; - int ret = 0; - unsigned int i; - const char *role_str; - const char *shm_id; - bool owner_dom_io = true; - - if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) - continue; - - /* - * xen,shared-mem = ; - * TODO: pbase is optional. - */ - addr_cells = dt_n_addr_cells(shm_node); - size_cells = dt_n_size_cells(shm_node); - prop = dt_find_property(shm_node, "xen,shared-mem", NULL); - BUG_ON(!prop); - cells = (const __be32 *)prop->value; - device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); - psize = dt_read_paddr(cells, size_cells); - if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) - { - printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", - d, pbase, gbase); - return -EINVAL; - } - if ( !IS_ALIGNED(psize, PAGE_SIZE) ) - { - printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", - d, psize); - return -EINVAL; - } - - for ( i = 0; i < PFN_DOWN(psize); i++ ) - if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) - { - printk("%pd: invalid physical address 0x%"PRI_mfn"\n", - d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); - return -EINVAL; - } - - /* - * "role" property is optional and if it is defined explicitly, - * then the owner domain is not the default "dom_io" domain. - */ - if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) - owner_dom_io = false; - - if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) - { - printk("%pd: invalid \"xen,shm-id\" property", d); - return -EINVAL; - } - BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); - - /* - * DOMID_IO is a fake domain and is not described in the Device-Tree. - * Therefore when the owner of the shared region is DOMID_IO, we will - * only find the borrowers. - */ - if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || - (!owner_dom_io && strcmp(role_str, "owner") == 0) ) - { - /* - * We found the first borrower of the region, the owner was not - * specified, so they should be assigned to dom_io. - */ - ret = assign_shared_memory(owner_dom_io ? dom_io : d, - addr_cells, size_cells, - pbase, psize, gbase); - if ( ret ) - return ret; - } - - if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) - { - /* Set up P2M foreign mapping for borrower domain. */ - ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), - _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); - if ( ret ) - return ret; - } - - /* - * Record static shared memory region info for later setting - * up shm-node in guest device tree. - */ - ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); - if ( ret ) - return ret; - } - - return 0; -} - -int __init make_shm_memory_node(const struct domain *d, void *fdt, - int addrcells, int sizecells, - const struct meminfo *mem) -{ - unsigned int i = 0; - int res = 0; - - if ( mem->nr_banks == 0 ) - return -ENOENT; - - /* - * For each shared memory region, a range is exposed under - * the /reserved-memory node as a child node. Each range sub-node is - * named xen-shmem@
. - */ - dt_dprintk("Create xen-shmem node\n"); - - for ( ; i < mem->nr_banks; i++ ) - { - uint64_t start = mem->bank[i].start; - uint64_t size = mem->bank[i].size; - const char compat[] = "xen,shared-memory-v1"; - /* Worst case addrcells + sizecells */ - __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; - __be32 *cells; - unsigned int len = (addrcells + sizecells) * sizeof(__be32); - - res = domain_fdt_begin_node(fdt, "xen-shmem", mem->bank[i].start); - if ( res ) - return res; - - res = fdt_property(fdt, "compatible", compat, sizeof(compat)); - if ( res ) - return res; - - cells = reg; - dt_child_set_range(&cells, addrcells, sizecells, start, size); - - res = fdt_property(fdt, "reg", reg, len); - if ( res ) - return res; - - dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", - i, start, start + size); - - res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); - if ( res ) - return res; - - /* - * TODO: - * - xen,offset: (borrower VMs only) - * 64 bit integer offset within the owner virtual machine's shared - * memory region used for the mapping in the borrower VM - */ - res = fdt_property_u64(fdt, "xen,offset", 0); - if ( res ) - return res; - - res = fdt_end_node(fdt); - if ( res ) - return res; - } - - return res; -} -#else /* !CONFIG_STATIC_SHM */ -int __init make_shm_memory_node(const struct domain *d, void *fdt, - int addrcells, int sizecells, - const struct meminfo *mem) -{ - ASSERT_UNREACHABLE(); - return -EOPNOTSUPP; -} -#endif /* CONFIG_STATIC_SHM */ - #ifdef CONFIG_VGICV2 static int __init make_gicv2_domU_node(struct kernel_info *kinfo) { @@ -1516,11 +876,9 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); -#ifdef CONFIG_STATIC_SHM rc = process_shm(d, &kinfo, node); if ( rc < 0 ) return rc; -#endif /* * Base address and irq number are needed when creating vpl011 device diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 2f8221590954..d9f1c3269751 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @@ -2444,9 +2445,6 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; -#ifdef CONFIG_STATIC_SHM - const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); -#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -2481,11 +2479,9 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); -#ifdef CONFIG_STATIC_SHM - rc = process_shm(d, &kinfo, chosen); + rc = process_shm_chosen(d, &kinfo); if ( rc < 0 ) return rc; -#endif /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); diff --git a/xen/arch/arm/include/asm/dom0less-build.h b/xen/arch/arm/include/asm/dom0less-build.h index 868143d4f95a..d95cb6234b62 100644 --- a/xen/arch/arm/include/asm/dom0less-build.h +++ b/xen/arch/arm/include/asm/dom0less-build.h @@ -8,15 +8,8 @@ #ifndef __ARM_DOM0LESS_BUILD_H_ #define __ARM_DOM0LESS_BUILD_H_ -#include - void create_domUs(void); -void init_staticmem_pages(void); bool is_dom0less_mode(void); -int make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, - int sizecells, const struct meminfo *mem); -int process_shm(struct domain *d, struct kernel_info *kinfo, - const struct dt_device_node *node); #endif /* __ARM_DOM0LESS_BUILD_H_ */ diff --git a/xen/arch/arm/include/asm/static-memory.h b/xen/arch/arm/include/asm/static-memory.h new file mode 100644 index 000000000000..0fe193b36861 --- /dev/null +++ b/xen/arch/arm/include/asm/static-memory.h @@ -0,0 +1,50 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/include/asm/static-memory.h + * + * Copyright (C) 2023 Arm Ltd. + */ + +#ifndef __ARM_STATIC_MEMORY_H_ +#define __ARM_STATIC_MEMORY_H_ + +#include + +#ifdef CONFIG_STATIC_MEMORY + +void allocate_static_memory(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node); +void assign_static_memory_11(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node); +void init_staticmem_pages(void); + +#else /* !CONFIG_STATIC_MEMORY */ + +static inline void allocate_static_memory(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + ASSERT_UNREACHABLE(); +} + +static inline void assign_static_memory_11(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + ASSERT_UNREACHABLE(); +} + +static inline void init_staticmem_pages(void) {}; + +#endif /* CONFIG_STATIC_MEMORY */ + +#endif /* __ARM_STATIC_MEMORY_H_ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End:b + */ diff --git a/xen/arch/arm/include/asm/static-shmem.h b/xen/arch/arm/include/asm/static-shmem.h new file mode 100644 index 000000000000..5a8075fbee55 --- /dev/null +++ b/xen/arch/arm/include/asm/static-shmem.h @@ -0,0 +1,72 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/include/asm/static-shmem.h + * + * Copyright (C) 2023 Arm Ltd. + */ + +#ifndef __ARM_STATIC_SHMEM_H_ +#define __ARM_STATIC_SHMEM_H_ + +#include + +#ifdef CONFIG_STATIC_SHM + +int make_shm_memory_node(const struct domain *d, void *fdt, int addrcells, + int sizecells, const struct meminfo *mem); + +int process_shm(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node); + +static inline int process_shm_chosen(struct domain *d, + struct kernel_info *kinfo) +{ + const struct dt_device_node *node = dt_find_node_by_path("/chosen"); + + return process_shm(d, kinfo, node); +} + +int process_shm_node(const void *fdt, int node, uint32_t address_cells, + uint32_t size_cells); + +#else /* !CONFIG_STATIC_SHM */ + +static inline int make_shm_memory_node(const struct domain *d, void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); + return -EOPNOTSUPP; +} + +static inline int process_shm(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + return 0; +} + +static inline int process_shm_chosen(struct domain *d, + struct kernel_info *kinfo) +{ + return 0; +} + +static inline int process_shm_node(const void *fdt, int node, + uint32_t address_cells, uint32_t size_cells) +{ + printk("CONFIG_STATIC_SHM must be enabled for parsing static shared memory nodes\n"); + return -EINVAL; +} + +#endif /* CONFIG_STATIC_SHM */ + +#endif /* __ARM_STATIC_SHMEM_H_ */ + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End:b + */ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 44bf872bc38f..9c1fa3f1d4ed 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include diff --git a/xen/arch/arm/static-memory.c b/xen/arch/arm/static-memory.c new file mode 100644 index 000000000000..9aecdae28846 --- /dev/null +++ b/xen/arch/arm/static-memory.c @@ -0,0 +1,294 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/static-memory.c + * + * Code related to the static memory functionality + * + * Copyright (C) 2023 Arm Ltd. + */ + +#include + +#include + +static bool __init append_static_memory_to_bank(struct domain *d, + struct membank *bank, + mfn_t smfn, + paddr_t size) +{ + int res; + unsigned int nr_pages = PFN_DOWN(size); + gfn_t sgfn; + + /* + * For direct-mapped domain, the GFN match the MFN. + * Otherwise, this is inferred on what has already been allocated + * in the bank. + */ + if ( !is_domain_direct_mapped(d) ) + sgfn = gaddr_to_gfn(bank->start + bank->size); + else + sgfn = gaddr_to_gfn(mfn_to_maddr(smfn)); + + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); + if ( res ) + { + dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); + return false; + } + + bank->size = bank->size + size; + + return true; +} + +static mfn_t __init acquire_static_memory_bank(struct domain *d, + const __be32 **cell, + u32 addr_cells, u32 size_cells, + paddr_t *pbase, paddr_t *psize) +{ + mfn_t smfn; + int res; + + device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize); + ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE)); + if ( PFN_DOWN(*psize) > UINT_MAX ) + { + printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr, + d, *psize); + return INVALID_MFN; + } + + smfn = maddr_to_mfn(*pbase); + res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + return INVALID_MFN; + } + + return smfn; +} + +static int __init parse_static_mem_prop(const struct dt_device_node *node, + u32 *addr_cells, u32 *size_cells, + int *length, const __be32 **cell) +{ + const struct dt_property *prop; + + prop = dt_find_property(node, "xen,static-mem", NULL); + + *addr_cells = dt_n_addr_cells(node); + *size_cells = dt_n_size_cells(node); + + *cell = (const __be32 *)prop->value; + *length = prop->length; + + return 0; +} + +/* Allocate memory from static memory as RAM for one specific domain d. */ +void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + u32 addr_cells, size_cells, reg_cells; + unsigned int nr_banks, gbank, bank = 0; + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; + const __be32 *cell; + u64 tot_size = 0; + paddr_t pbase, psize, gsize; + mfn_t smfn; + int length; + + if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) + goto fail; + reg_cells = addr_cells + size_cells; + + /* + * The static memory will be mapped in the guest at the usual guest memory + * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by + * xen/include/public/arch-arm.h. + */ + gbank = 0; + gsize = ramsize[gbank]; + kinfo->mem.bank[gbank].start = rambase[gbank]; + nr_banks = length / (reg_cells * sizeof (u32)); + + for ( ; bank < nr_banks; bank++ ) + { + smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, + &pbase, &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + goto fail; + + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", + d, bank, pbase, pbase + psize); + + while ( 1 ) + { + /* Map as much as possible the static range to the guest bank */ + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, + min(psize, gsize)) ) + goto fail; + + /* + * The current physical bank is fully mapped. + * Handle the next physical bank. + */ + if ( gsize >= psize ) + { + gsize = gsize - psize; + break; + } + /* + * When current guest bank is not enough to map, exhaust + * the current one and seek to the next. + * Before seeking to the next, check if we still have available + * guest bank. + */ + else if ( (gbank + 1) >= GUEST_RAM_BANKS ) + { + printk(XENLOG_ERR "Exhausted all possible guest banks.\n"); + goto fail; + } + else + { + psize = psize - gsize; + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); + /* Update to the next guest bank. */ + gbank++; + gsize = ramsize[gbank]; + kinfo->mem.bank[gbank].start = rambase[gbank]; + } + } + + tot_size += psize; + } + + kinfo->mem.nr_banks = ++gbank; + + kinfo->unassigned_mem -= tot_size; + /* + * The property 'memory' should match the amount of memory given to the + * guest. + * Currently, it is only possible to either acquire static memory or let + * Xen allocate. *Mixing* is not supported. + */ + if ( kinfo->unassigned_mem ) + { + printk(XENLOG_ERR + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n"); + goto fail; + } + + return; + + fail: + panic("Failed to allocate requested static memory for domain %pd.\n", d); +} + +/* + * Allocate static memory as RAM for one specific domain d. + * The static memory will be directly mapped in the guest(Guest Physical + * Address == Physical Address). + */ +void __init assign_static_memory_11(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + u32 addr_cells, size_cells, reg_cells; + unsigned int nr_banks, bank = 0; + const __be32 *cell; + paddr_t pbase, psize; + mfn_t smfn; + int length; + + if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) ) + { + printk(XENLOG_ERR + "%pd: failed to parse \"xen,static-mem\" property.\n", d); + goto fail; + } + reg_cells = addr_cells + size_cells; + nr_banks = length / (reg_cells * sizeof(u32)); + + if ( nr_banks > NR_MEM_BANKS ) + { + printk(XENLOG_ERR + "%pd: exceed max number of supported guest memory banks.\n", d); + goto fail; + } + + for ( ; bank < nr_banks; bank++ ) + { + smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells, + &pbase, &psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + goto fail; + + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", + d, bank, pbase, pbase + psize); + + /* One guest memory bank is matched with one physical memory bank. */ + kinfo->mem.bank[bank].start = pbase; + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[bank], + smfn, psize) ) + goto fail; + + kinfo->unassigned_mem -= psize; + } + + kinfo->mem.nr_banks = nr_banks; + + /* + * The property 'memory' should match the amount of memory given to + * the guest. + * Currently, it is only possible to either acquire static memory or + * let Xen allocate. *Mixing* is not supported. + */ + if ( kinfo->unassigned_mem != 0 ) + { + printk(XENLOG_ERR + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); + goto fail; + } + + return; + + fail: + panic("Failed to assign requested static memory for direct-map domain %pd.\n", + d); +} + +/* Static memory initialization */ +void __init init_staticmem_pages(void) +{ + unsigned int bank; + + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + if ( bootinfo.reserved_mem.bank[bank].type == MEMBANK_STATIC_DOMAIN ) + { + mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); + unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); + mfn_t bank_end = mfn_add(bank_start, bank_pages); + + if ( mfn_x(bank_end) <= mfn_x(bank_start) ) + return; + + unprepare_staticmem_pages(mfn_to_page(bank_start), + bank_pages, false); + } + } +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/static-shmem.c b/xen/arch/arm/static-shmem.c new file mode 100644 index 000000000000..fd826f486e8a --- /dev/null +++ b/xen/arch/arm/static-shmem.c @@ -0,0 +1,515 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * xen/arch/arm/static-shmem.c + * + * Code related to the static shared memory functionality + * + * Copyright (C) 2023 Arm Ltd. + */ + +#include +#include + +#include +#include + +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned int bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( (pbase == bank_start) && (psize == bank_size) ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + + return 0; +} + +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + struct domain *d; + + page = maddr_to_page(pbase); + d = page_get_owner_and_reference(page); + if ( d == NULL ) + return false; + put_page(page); + + if ( d != dom_io ) + { + printk(XENLOG_ERR + "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", + d); + return false; + } + + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + unsigned long nr_pfns; + int res; + + /* + * Pages of statically shared memory shall be included + * into domain_tot_pages(). + */ + nr_pfns = PFN_DOWN(psize); + if ( (UINT_MAX - d->max_pages) < nr_pfns ) + { + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", + d, nr_pfns); + return INVALID_MFN; + } + d->max_pages += nr_pfns; + + smfn = maddr_to_mfn(pbase); + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + d->max_pages -= nr_pfns; + return INVALID_MFN; + } + + return smfn; +} + +static int __init assign_shared_memory(struct domain *d, + uint32_t addr_cells, uint32_t size_cells, + paddr_t pbase, paddr_t psize, + paddr_t gbase) +{ + mfn_t smfn; + int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; + + printk("%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, pbase, psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is not auto-translated (i.e. it sees RAM 1:1). So we do not need + * to create mapping in the P2M. + */ + nr_pages = PFN_DOWN(psize); + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, + PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + /* + * Get the right amount of references per page, which is the number of + * borrower domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of letting borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + * So if the borrower is created first, it will cause adding pages + * in the P2M without reference. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); + return ret; +} + +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + const char *shm_id) +{ + if ( kinfo->shm_mem.nr_banks >= NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); + kinfo->shm_mem.nr_banks++; + + return 0; +} + +int __init process_shm(struct domain *d, struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + + dt_for_each_child_node(node, shm_node) + { + const struct dt_property *prop; + const __be32 *cells; + uint32_t addr_cells, size_cells; + paddr_t gbase, pbase, psize; + int ret = 0; + unsigned int i; + const char *role_str; + const char *shm_id; + bool owner_dom_io = true; + + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + /* + * xen,shared-mem = ; + * TODO: pbase is optional. + */ + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + BUG_ON(!prop); + cells = (const __be32 *)prop->value; + device_tree_get_reg(&cells, addr_cells, addr_cells, &pbase, &gbase); + psize = dt_read_paddr(cells, size_cells); + if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, pbase, gbase); + return -EINVAL; + } + if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, psize); + return -EINVAL; + } + + for ( i = 0; i < PFN_DOWN(psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) + { + printk("%pd: invalid physical address 0x%"PRI_mfn"\n", + d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + + if ( dt_property_read_string(shm_node, "xen,shm-id", &shm_id) ) + { + printk("%pd: invalid \"xen,shm-id\" property", d); + return -EINVAL; + } + BUG_ON((strlen(shm_id) <= 0) || (strlen(shm_id) >= MAX_SHM_ID_LENGTH)); + + /* + * DOMID_IO is a fake domain and is not described in the Device-Tree. + * Therefore when the owner of the shared region is DOMID_IO, we will + * only find the borrowers. + */ + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) + { + /* + * We found the first borrower of the region, the owner was not + * specified, so they should be assigned to dom_io. + */ + ret = assign_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); + if ( ret ) + return ret; + } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; + } + + return 0; +} + +int __init make_shm_memory_node(const struct domain *d, void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + unsigned int i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + const char compat[] = "xen,shared-memory-v1"; + /* Worst case addrcells + sizecells */ + __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + res = domain_fdt_begin_node(fdt, "xen-shmem", mem->bank[i].start); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); + if ( res ) + return res; + + /* + * TODO: + * - xen,offset: (borrower VMs only) + * 64 bit integer offset within the owner virtual machine's shared + * memory region used for the mapping in the borrower VM + */ + res = fdt_property_u64(fdt, "xen,offset", 0); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} + +int __init process_shm_node(const void *fdt, int node, uint32_t address_cells, + uint32_t size_cells) +{ + const struct fdt_property *prop, *prop_id, *prop_role; + const __be32 *cell; + paddr_t paddr, gaddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned int i; + int len; + bool owner = false; + const char *shm_id; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + /* + * "xen,shm-id" property holds an arbitrary string with a strict limit + * on the number of characters, MAX_SHM_ID_LENGTH + */ + prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); + if ( !prop_id ) + return -ENOENT; + shm_id = (const char *)prop_id->data; + if ( strnlen(shm_id, MAX_SHM_ID_LENGTH) == MAX_SHM_ID_LENGTH ) + { + printk("fdt: invalid xen,shm-id %s, it must be limited to %u characters\n", + shm_id, MAX_SHM_ID_LENGTH); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * it must be either `owner` or `borrower`. + */ + prop_role = fdt_get_property(fdt, node, "role", NULL); + if ( prop_role ) + { + if ( !strcmp(prop_role->data, "owner") ) + owner = true; + else if ( strcmp(prop_role->data, "borrower") ) + { + printk("fdt: invalid `role` property for static shared memory node.\n"); + return -EINVAL; + } + } + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + prop = fdt_get_property(fdt, node, "xen,shared-mem", &len); + if ( !prop ) + return -ENOENT; + + if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) + { + if ( len == dt_cells_to_size(size_cells + address_cells) ) + printk("fdt: host physical address must be chosen by users at the moment.\n"); + + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } + + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, address_cells, &paddr, &gaddr); + size = dt_next_cell(size_cells, &cell); + + if ( !size ) + { + printk("fdt: the size for static shared memory region can not be zero\n"); + return -EINVAL; + } + + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * Meet the following check: + * 1) The shm ID matches and the region exactly match + * 2) The shm ID doesn't match and the region doesn't overlap + * with an existing one + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + { + if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + break; + else + { + printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", + shm_id); + return -EINVAL; + } + } + else + { + paddr_t end = paddr + size; + paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + + if ( (end <= paddr) || (bank_end <= mem->bank[i].start) ) + { + printk("fdt: static shared memory region %s overflow\n", shm_id); + return -EINVAL; + } + + if ( check_reserved_regions_overlap(paddr, size) ) + return -EINVAL; + else + { + if ( strcmp(shm_id, mem->bank[i].shm_id) != 0 ) + continue; + else + { + printk("fdt: different shared memory region could not share the same shm ID %s\n", + shm_id); + return -EINVAL; + } + } + } + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].type = MEMBANK_STATIC_DOMAIN; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of borrowers, which later may be used + * to calculate the reference count. + */ + if ( !owner ) + mem->bank[i].nr_shm_borrowers++; + + return 0; +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:00:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579371.907356 (Exim 4.92) (envelope-from ) id 1qTHdq-0000xI-7F; Tue, 08 Aug 2023 08:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579371.907356; Tue, 08 Aug 2023 08:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdq-0000wf-2J; Tue, 08 Aug 2023 08:00:34 +0000 Received: by outflank-mailman (input) for mailman id 579371; Tue, 08 Aug 2023 08:00:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTHdo-0007uw-Al for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:00:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id a3ced59d-35c1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:00:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F17F7150C; Tue, 8 Aug 2023 01:01:10 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.arm.com [10.1.199.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 506C63F6C4; Tue, 8 Aug 2023 01:00:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3ced59d-35c1-11ee-8613-37d641c3527e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 5/5] arm/dom0less: introduce Kconfig for dom0less feature Date: Tue, 8 Aug 2023 09:00:10 +0100 Message-Id: <20230808080010.3858575-6-luca.fancellu@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808080010.3858575-1-luca.fancellu@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a Kconfig for the dom0less feature, enabled by default, to be able to choose if the feature should be compiled or not. Provide static inline stubs when the option is disabled for the functions externally visible. Use the new Kconfig to remove dom0less DT binding from the efi-boot.h code when the Kconfig is not enabled. Signed-off-by: Luca Fancellu --- xen/arch/arm/Kconfig | 9 +++++++++ xen/arch/arm/Makefile | 2 +- xen/arch/arm/efi/efi-boot.h | 4 ++++ xen/arch/arm/include/asm/dom0less-build.h | 12 ++++++++++++ 4 files changed, 26 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 03ec1247ad4c..2fbbfd8518d4 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -86,6 +86,15 @@ config GICV2 Driver for the ARM Generic Interrupt Controller v2. If unsure, say Y +config DOM0LESS_BOOT + bool "Dom0less boot support" if EXPERT + depends on ARM + default y + help + Dom0less boot support enables Xen to create and start domU guests during + Xen boot without the need of a control domain (Dom0), which could be + present anyway. + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 89ef0c9075b5..5daf8f10114d 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -15,7 +15,7 @@ obj-y += cpufeature.o obj-y += decode.o obj-y += device.o obj-$(CONFIG_IOREQ_SERVER) += dm.o -obj-y += dom0less-build.init.o +obj-$(CONFIG_DOM0LESS_BOOT) += dom0less-build.init.o obj-y += domain.o obj-y += domain_build.init.o obj-$(CONFIG_ARCH_MAP_DOMAIN_PAGE) += domain_page.o diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index f24df2abb91c..bc6413d0dbfd 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -802,6 +802,7 @@ static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image, return 1; } +#ifdef CONFIG_DOM0LESS_BOOT /* * This function checks for boot modules under the domU guest domain node * in the DT. @@ -849,6 +850,7 @@ static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_ima return mb_modules_found; } +#endif /* * This function checks for xen domain nodes under the /chosen node for possible @@ -876,6 +878,7 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) { int ret; +#ifdef CONFIG_DOM0LESS_BOOT if ( !fdt_node_check_compatible(fdt_efi, node, "xen,domain") ) { /* Found a node with compatible xen,domain; handle this node. */ @@ -884,6 +887,7 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) return ERROR_DT_MODULE_DOMU; } else +#endif { ret = handle_module_node(loaded_image, &dir_handle, node, addr_len, size_len, false); diff --git a/xen/arch/arm/include/asm/dom0less-build.h b/xen/arch/arm/include/asm/dom0less-build.h index d95cb6234b62..859944eece16 100644 --- a/xen/arch/arm/include/asm/dom0less-build.h +++ b/xen/arch/arm/include/asm/dom0less-build.h @@ -8,9 +8,21 @@ #ifndef __ARM_DOM0LESS_BUILD_H_ #define __ARM_DOM0LESS_BUILD_H_ +#ifdef CONFIG_DOM0LESS_BOOT + void create_domUs(void); bool is_dom0less_mode(void); +#else /* !CONFIG_DOM0LESS_BOOT */ + +static inline void create_domUs(void) {} +static inline bool is_dom0less_mode(void) +{ + return false; +} + +#endif /* CONFIG_DOM0LESS_BOOT */ + #endif /* __ARM_DOM0LESS_BUILD_H_ */ /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:26:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:26:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579412.907366 (Exim 4.92) (envelope-from ) id 1qTI3D-00056l-9a; Tue, 08 Aug 2023 08:26:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579412.907366; Tue, 08 Aug 2023 08:26:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTI3D-00056e-6s; Tue, 08 Aug 2023 08:26:47 +0000 Received: by outflank-mailman (input) for mailman id 579412; Tue, 08 Aug 2023 08:26:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTI3C-00056Y-BI for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:26:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dd1be92-35c5-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:26:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0352B622AB; Tue, 8 Aug 2023 08:26:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CAECC433C7; Tue, 8 Aug 2023 08:26:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dd1be92-35c5-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691483201; bh=1ijsJa2eh4p1IcCoOuBZVpoxzDn4f5UY3AUI/la7Uu8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z2mh4nj4UTCvyovhEk3tQD6tH0991P3wRL7uqwF0I7iL1RV1pjAIjwq6eTQ8ZJS7C uyTXP7yyRpyY1wDj3M+ATiEKgwDQUeASy/5cAZe9RZlnaW/MwJ2QU2s1V92VaV74LR C1TqPzCd8b4FSaY4wUlcxRcTKJ2mzBh3CYytWM/0= Date: Tue, 8 Aug 2023 10:26:38 +0200 From: Greg KH To: Alan Stern Cc: Zhang Shurong , jgross@suse.com, xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control() Message-ID: <2023080845-talisman-ravage-0b58@gregkh> References: <2023062628-shame-ebook-56f2@gregkh> <4825193.GXAFRqVoOG@localhost.localdomain> <2023080659-turban-exemption-1196@gregkh> <3481a644-1648-4fa9-86eb-2a0b86b8f47a@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3481a644-1648-4fa9-86eb-2a0b86b8f47a@rowland.harvard.edu> On Sun, Aug 06, 2023 at 11:15:51AM -0400, Alan Stern wrote: > On Sun, Aug 06, 2023 at 04:27:27PM +0200, Greg KH wrote: > > On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > > > 在 2023å¹´7月1日星期六 CST 下åˆ11:51:43，Zhang Shurong 写é“ï¼ > > > > 在 2023å¹´6月26日星期一 CST 下åˆ1:52:02，您写é“ï¼ > > > > > > > > > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > > > > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > > > > > --- a/drivers/usb/host/xen-hcd.c > > > > > > > +++ b/drivers/usb/host/xen-hcd.c > > > > > > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *hcd, > > > > > > > __u16 typeReq, __u16 wValue,> > > > > > > > > > > > > > > > info->ports[wIndex - 1].c_connection = > > > > > > > > false; > > > > > > > > > > > fallthrough; > > > > > > > > > > > > > > default: > > > > > > > + if (wValue >= 32) > > > > > > > + goto error; > > > > > > > > > > > > > > info->ports[wIndex - 1].status &= ~(1 > > > > > > > > << wValue); > > > > > > > > > > Even 31 is out of bounds (as in: UB) as long as it's 1 here rather > > > > > > than 1u. > > > > > > > > > > Why isn't the caller fixed so this type of value could never be passed > > > > > to the hub_control callback? > > > > > > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > Although I'm not knowledgeable about the USB subsystem, I've observed that > > > > not all driver code that implements hub_control callback performs a shift > > > > operation on wValue, and not all shift operations among them cause > > > > problems. Therefore, I've decided to fix this issue within each driver > > > > itself. > > > > > > > > For example, in r8a66597_hub_control, it will first check whether wValue is > > > > valid (always < 31) before the shift operation. In case of an invalid > > > > number, the code would execute the error branch instead of the shift > > > > operation. > > > > > > > > switch (wValue) { > > > > case USB_PORT_FEAT_ENABLE: > > > > rh->port &= ~USB_PORT_STAT_POWER; > > > > break; > > > > case USB_PORT_FEAT_SUSPEND: > > > > break; > > > > case USB_PORT_FEAT_POWER: > > > > r8a66597_port_power(r8a66597, port, 0); > > > > break; > > > > case USB_PORT_FEAT_C_ENABLE: > > > > case USB_PORT_FEAT_C_SUSPEND: > > > > case USB_PORT_FEAT_C_CONNECTION: > > > > case USB_PORT_FEAT_C_OVER_CURRENT: > > > > case USB_PORT_FEAT_C_RESET: > > > > break; > > > > default: > > > > goto error; > > > > } > > > > rh->port &= ~(1 << wValue); > > > > > > Hi there. I apologize for reaching out once more. I'm feeling a bit puzzled > > > about what my next step should be. I'm unsure whether I should rewrite this > > > patch or attempt to address the issue at the caller level. > > > > Try addressing it at the caller level first please. If that somehow > > does not work, then we will take a patch series that fixes all of the > > host controller drivers at once. > > It's not feasible to fix all the callers, because the calls can come > from userspace via usbfs. It can? Hm, that happens through the call in rh_call_control(), right? But there, we do a bunch of validation before calling hub_control() so why can't we do the same thing in that one place as well? Making invalid requests from userspace should be disallowed (or we can catch this in the usbfs interface.) thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:27:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579416.907375 (Exim 4.92) (envelope-from ) id 1qTI44-0005ce-JF; Tue, 08 Aug 2023 08:27:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579416.907375; Tue, 08 Aug 2023 08:27:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTI44-0005cX-Gb; Tue, 08 Aug 2023 08:27:40 +0000 Received: by outflank-mailman (input) for mailman id 579416; Tue, 08 Aug 2023 08:27:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTI43-0005cM-Gq for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:27:39 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ea41b1b-35c5-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:27:37 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b95d5ee18dso82737911fa.1 for ; Tue, 08 Aug 2023 01:27:37 -0700 (PDT) Received: from [192.168.201.133] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id s5-20020a2e2c05000000b002b9f9cb8e08sm2183839ljs.21.2023.08.08.01.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 01:27:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ea41b1b-35c5-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691483257; x=1692088057; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Y/kBOFCMeqWNBXymWnPLRcTDvKoIuo7naaa88L56UZ8=; b=bcr4F3DHfpaWrGKfIkX9kS2cAmjudL1x1b5dbnJlH4Jwgot4LELk74fKj0zevEa0d3 r/cVAcatnwuYFG62dlOLgKfDXMDv734gWZsiBXm0/eSwAbr4YoXlUkT7ym1xR7ggdcxK 0Aol3nEW/Y8Tvludkgr0kkgj8tqa2VnUws/K51Hw//3SGvLe+E2uycwOaRix8C2jL/ii LzO7JZN5GNyn4nq+RsIno1kesDV6cGaCRRdw16C4k27JJ+5wlV2RWEXEIum3KpfwmjXN Uno5cCTHDbGrNdFwC6kl8MVnF9VwpqAixEr/Xl/zSNuHFvw7Dzi47dqO0vcTHiGiyYqR D1BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691483257; x=1692088057; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y/kBOFCMeqWNBXymWnPLRcTDvKoIuo7naaa88L56UZ8=; b=V1WQZkMnbctACTmCLeOMMDcQZ3TH5q3OI8OsGHfNSLxEz7Y+ycfiWx3aQZ5UjGHbU9 prnzUHwT0zc/11RIFUr+0c1XzXUpSrLYlpnM24sa0E2duJBKSQ86rD3LD+rkBED6Pe2h C6qhSk5eTv3hRyVlqMPGRTb/VdxzDNOwTn4evat/giFH01DtXNyP10BpaB44c3XR6oGu Yhl0siBxWpnzJobRFG9JVz8Olx1+beLUyeDbGJdk98DjcwZbNzfF8GXqtWD8iAkQRVPw LgJuuJmk6V7fus5mkfBW8e558kWwbzNcONQ8K0SJKQATXBGcNUQjg6zCsjPJ71ME6nFM aMvA== X-Gm-Message-State: AOJu0YyuxgDbV/igReSIjgqy1ki3KsJrnc4XTgGM3okinsW5I3VFiTer T0+Z3eBIdQGmxBDhkqE9yHEbeE4JErQ= X-Google-Smtp-Source: AGHT+IFIeGr12llUtgighl0vxr/xBnuyySw1/BAN/iigulBgV5rgr6OrUd02pPdwZRJxC7Kq0VlsSQ== X-Received: by 2002:a2e:90d4:0:b0:2b9:cd79:8f94 with SMTP id o20-20020a2e90d4000000b002b9cd798f94mr8177618ljg.39.1691483256896; Tue, 08 Aug 2023 01:27:36 -0700 (PDT) Message-ID: Subject: Re: [PATCH v7 2/6] xen/riscv: introduce dummy From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 08 Aug 2023 11:27:36 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 On Mon, 2023-08-07 at 11:01 +0200, Jan Beulich wrote: > On 03.08.2023 14:05, Oleksii Kurochko wrote: > > will be used in the patch "xen/riscv: introduce > > decode_cause() stuff" and requires >=20 > While as it stands the description is accurate, I don't think that > later > patch has a need to include xen/lib.h anymore. xen/macros.h will do, > I > think. >=20 > Also please don't write descriptions in terms of "patches" or more > generally future "commits". Their titles may change, they may > disappear > altogether, etc. Finding such a description later will end up > confusing. Thanks for recommendations. I'll take them into account. ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:36:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:36:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579425.907389 (Exim 4.92) (envelope-from ) id 1qTICO-0007C4-EK; Tue, 08 Aug 2023 08:36:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579425.907389; Tue, 08 Aug 2023 08:36:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTICO-0007Bx-AO; Tue, 08 Aug 2023 08:36:16 +0000 Received: by outflank-mailman (input) for mailman id 579425; Tue, 08 Aug 2023 08:36:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTICN-0007Br-4u for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:36:15 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20618.outbound.protection.outlook.com [2a01:111:f400:fe1a::618]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a110124c-35c6-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:36:12 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB7090.eurprd04.prod.outlook.com (2603:10a6:208:19e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 08:36:09 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 08:36:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a110124c-35c6-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hJr6EG+EPjaG4zPV/pZvTeQUJEWy+Ys2QanSrB6OOVCfuMSMHBrtqDUYPG0hJ0CAJpc5edKe/LWrxeRTMN/NLK9B4WPBXsVh0Gx9ieNIGBYXmwruoqXlBIJYXgmFGM+/9veQrTuqGo1UwnKG/fxGS+Tcpt2hw507xRv+9mW2OEdB6lNu2c5pCZPHMWJnzysKYa3QtJKwPLrTChM95tlOF9SZ+Z/WUa7AiOc9bntTnUA4mi7SmOIzUNNa4twg+zwg8x7qT8Q24gyx3I6MiWltl7kQXb9lY0YbGtQw4lMdqoS6oG5C6V5k0krZSPFBQh44nk7cCeBjAZ/Fe0UfqSIu7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GAhpQQaSgLWIXTUHj4amqaa9+AIw6ifGrKeqoVVKn5I=; b=bh7drHid3/csu6PFe4j+jGQ5LozTtKoNShhW/QLyjkJQ2X6rJgu06sH4EeXgJPxtwvgOHv6NkXIzPAAxZ4N23DbjtvdKLMUMFD0YF6ZQADBHimUZ5DRIXitkgU7BvyCk3ECeixPLxCeVGvA9bTvC9ql+iKeg3toDHVEm++b14CqQlqkLwtx8lZCJ6/EUPdUx20Jc6jINjMG+P25l/LhFyIPc9lg8VIYemxaV/ZK+riBIR65VA5q/UXNf/PW1ZpyYm6eGyRQ0EVmLVf0yDemba0qpeLUGVclJ2wTs7KHOFJ6bXNkZiI0qs/6E8mjhRMyy/4rGbQM3BbNwb4xtV3Yj/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAhpQQaSgLWIXTUHj4amqaa9+AIw6ifGrKeqoVVKn5I=; b=Jx+XTET9lc7QHph143leN0Xgd0G/zKQDllqDiB5E9HI0OqIbXRAdnf44tZTPgloivVdM0HvAYMPb6Sx9Fn83AFYNBzD07sMC/zQmUCx/yAcDR3C89fTZsl1SzFbi0TQOjq6wGWVQvnxFGi31ffe98TfsREO3GF4+vPhaPfOkGuseX0Inwphcwg/vmUg7fNZl9W8ibeXddMls9gfA3UOng4ncDiHZeW0REmymNPj5QpAcp6CBFGRq5NLZTxd2KIKS49JYUnC79K9dtjX5PcHz5U0qcU1TooWTsVBDTMP1OGiI14zfRntTkgbg4xFVNOoTQSP1okA4miTPX2pvuzbEdg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <61ca4a1d-2589-5794-5560-db60e10a7f15@suse.com> Date: Tue, 8 Aug 2023 10:36:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 4/9] xen/ppc: Implement bitops.h Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <63b89c627948015cc9a1c1e5d1775ee9e41508ba.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <63b89c627948015cc9a1c1e5d1775ee9e41508ba.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB7090:EE_ X-MS-Office365-Filtering-Correlation-Id: c37ce1d1-e0cb-4337-bbd1-08db97ea82fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: psREk+wu81/D6ZWB3Yftp1NEa6xKYEaTitHNYO6wwLau4rWz3AtcwHUvLGDOiUFuUfV9xrMw21C45jvq+RwtlOfaPUvHuXnC1c2M6kGSopIrUdEe97uzxfdOmkiojIM2yQDLO2WUxKP0XM2H58oX+Gkrw2mxZGL25Ojow4fEeYNf+QihoIxxSp2cFNbqXTI2Ya1WuIx5T3oA5WbupLtYGrACSysl24VgA1qICRlRmgH56zWHQCZ2GBeeJeybdQdygc/r6cps4xGjq2v8D7PRyKefSCBBDgMeJphRz/3/bSDdc5nRqJZfX28Uguo06aOLckBh3Q4jSbFrnjDsmZ4P/u/Cx5rartXL9qsIxqarbgkMJBgr/utNPVfXTa13isMxVQtMZ6qCYFbi+d+yohhQSQ3K4Hprs8b53QXkLHMgqk/SQoCnBVLym2quq5OExVCN7kP8sj9JU4YdC9TndiHTnXDhuDNIeAVzSxVbfemkT6or6kV/Tp1L3fT5KM+sv3796wCm2k6pktNXY/9cIKXnEpAazeraTB2zhoCe2TZvADOABcZl1pjgrl2Qz9spc3AzCGesjEf+d8Jn1e6b0H1XvMq2SJ8+E70OR5kq8ymCay5j8kiQPT3oy08q0JZcbj1gpmH9wQdVEvoK/2YAPkcQig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199021)(186006)(1800799003)(6512007)(6506007)(26005)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(4744005)(31696002)(2906002)(6916009)(66946007)(316002)(66556008)(66476007)(8936002)(8676002)(4326008)(41300700001)(6486002)(478600001)(2616005)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDZUTUJhcnpFTzdoZzFGYjN2ZEd1QnJSc2pFYmcxVUY2SHRadEQ1djlydXhn?= =?utf-8?B?YnVSQWJFSlNHeXNJNGZndkVEc2haWVdjRWdIWnMwUzVrRjlDMnRaOUNwTU9a?= =?utf-8?B?YUhWV25raktoK3JoNXJLTGNTVG02UmhYYytKbUp4WFVTVzJZWWpQSjNoL0xR?= =?utf-8?B?YU1LaTl5Q0VkczNoVGtVcVpjVW1pR3JqVmNaNFl1cWE1dlEvTmc0RStRelpm?= =?utf-8?B?aWh6cFVpd1NDczlCM0JUNlhiMTlOdSthN1picHdGNWRoYWNpSFJ2Z3VSMHRp?= =?utf-8?B?dHRvb1BhMHVJMmwvZUNvS1dkb0VzV1ZSN0ZZdEVjeFRSdEs2dExVUC9ocFNv?= =?utf-8?B?dFhqWFl3Vjl5TGhOSDRPdVc3aTJXT3NXOFN1b1cxYWkwbEFUWTNFWEJ3QVE0?= =?utf-8?B?WTFoSnhFT0pBMFBxaFhIZUJjQnFYY0NwdmFXTGtjWUtmQWxRWHdPeGtWQm0y?= =?utf-8?B?SWZadzAyYVZsQVRYZW5ubURyOUpnSkVDVVQrM2k2QzI1Z2Fhb0l5dmpJV2NT?= =?utf-8?B?ZlVoVENpUERSdkpUOURPdGFBYlZpSDJiQWhROHlWYWI1Q0hBbFpuZjBZVXJF?= =?utf-8?B?YzJSS0ZRZTdPcTI0N2RrdGVOQ1lkSWNOVUM5NlRNTmtlSytqc0ZodW5heHhj?= =?utf-8?B?SzVJaWpCSm5RTFljUTI5OUVPcllQSUUxL0JMdUlJa0grSTUzUDdiTTZKeWE5?= =?utf-8?B?U1Y3MDZJWnJWZGhiRllZN1IxVzJCNVAxQjBqSmY5ZVNKTmxNcjBNVnd1c2l0?= =?utf-8?B?SUlzb3lhU3h2ZzN2bTdpSjdBZUQwWjFJSjJMdTBndVVzL1BWMHNSc2o0Y3pl?= =?utf-8?B?eWJjV3ZtVy90Q3Zvc1pIZkNmTlEzeWNFWmJYb01WT3BYWEhHc1QxbUtOd3R3?= =?utf-8?B?dHNMaUVyYlBKU2pNS3BKSXFEdTEveTNHSFBrQmphc2xhNWRPaUZPNCtqQTB5?= =?utf-8?B?MFB6NXhqT0NBWXpmWGp5UW1ZbklHRzdRcGVEbEhaelJsN3NtUXByZ3lzM2NJ?= =?utf-8?B?MU50TSt0MlNMR1BhdzBUZ1g4SUtJeHhTL1MvRFRZU2NVU3NjR1FvN21FZ2JB?= =?utf-8?B?Sko0STNOeXRJaDloT3MzQk5HSzFSdUN1N2dObWl1aFBDZzJHQmpraVMyMkFS?= =?utf-8?B?SWZhTWhDaGtYSTBTUEZLWkFLQ1NwZVcyMy9LVmtnSlFvRE9aSTZjUXNzUC9r?= =?utf-8?B?YVpoU0RVNjVwaURZM1pzRkM1UUtVSWcxMjh0dHhZVGJPY281TFI3OFg1ZzNr?= =?utf-8?B?WVlzbjhvZndEcUlsdHdmdEFaNlJNUzBaSHBKM1VQSmtjcngrTVVMQzJXTm1C?= =?utf-8?B?SU9FbDBMM0VyMjVsa3hUaEczM21NRE1hUFA0SGRyd1Ntdkwwa29pU1pxQXUv?= =?utf-8?B?dUF6U2RBVEdzMmpmN1dnTXp3MVJHbHQ3OTY4WGtpb1JBYk5QYnJ1dTFMdUh6?= =?utf-8?B?TUwreXVReVVWaVJTVGNmQTNIL0JVdnlQVG1tQkoxQ0ZTdEJxV3FuRG9aSGdR?= =?utf-8?B?NzlPQThYUVFYSDhNdGVpUmV6Wm5TVHJuYnVXbE9LOUdDN25IUlJGWEE5YXoy?= =?utf-8?B?TjkzTm00bnpidWFTdUd1Vk9vRmkrbUhGZHgxcFl2SmdzT200RzhQb1RhbE03?= =?utf-8?B?VTRGamkxeFk3bTVZRWREQVM5UFdqeGc5L1JZY094ZlRjU2dxNEFpNVRYZlNN?= =?utf-8?B?Zm9leFVBbGNtNFZvWVVYUzVySFAvT2tYS3l2V3JhaUYrRkdyLzZjSWhabDhC?= =?utf-8?B?aWE5ZW5YNUh3ZDFWdDdXVmNhTXBVeGVsTlZpdEg4WlF1WjM5RXp4citpbHRj?= =?utf-8?B?dEt2bEZEdmxELzhzbGdIUGFHeTBPK2dXc3ByYUMyRk1oeHliNDNmZ0NKL0RO?= =?utf-8?B?SlFhUDhPOWZ4L05zaXlFQ1QyZ05JMUhNSVZ2Wi9SaEhvdTZRNFhSTUhBVWFi?= =?utf-8?B?YXk2MzFDTDY3T2FnYWdSdGRlTHEvM0ZIUDZOLzVXbDdOUVZBVnhSZll1OS9w?= =?utf-8?B?QWNyWkd0dUY5VHpnQXQyeWI4MXkrUWxJTHpIOVI2Sk1Zb1ZiMUVBQVFYMysz?= =?utf-8?B?K2ZSOHlnNERLREl3ZzVZb2VuRForZDZwdlV3OG1OVXpRNmxmS2NqMmlHTHRi?= =?utf-8?Q?5L5GuvGixs0pywD9HSBDdRsv0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37ce1d1-e0cb-4337-bbd1-08db97ea82fa X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 08:36:08.0723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p15Ckc0JoXYTowZM5iDSFzb2qvaCVv9nM9GE8KyRu9uYVwTU6xD59sFruR7msnIppEPDnQ6UKY0McVt6yH2Dpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7090 On 03.08.2023 01:03, Shawn Anastasio wrote: > Implement bitops.h, based on Linux's implementation as of commit > 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc But with PPC32 bits dropped afaics, and with leading hard tabs replaced by four spaces - which in turn appears to yield some unhelpful placement of line-continuing backslashes. And with some asm-generic/bitops/builtin-*.h expanded. Please mention all adjustments you made, to allow for some future importing of updates to go as smoothly as possible. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:43:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:43:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579431.907398 (Exim 4.92) (envelope-from ) id 1qTIJa-0000EO-4u; Tue, 08 Aug 2023 08:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579431.907398; Tue, 08 Aug 2023 08:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIJa-0000EH-1n; Tue, 08 Aug 2023 08:43:42 +0000 Received: by outflank-mailman (input) for mailman id 579431; Tue, 08 Aug 2023 08:43:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIJY-0000E7-82; Tue, 08 Aug 2023 08:43:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIJY-0006IN-0m; Tue, 08 Aug 2023 08:43:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIJX-0008MV-DV; Tue, 08 Aug 2023 08:43:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTIJX-0004xy-D2; Tue, 08 Aug 2023 08:43:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=umfJOw8fzLOkld/T1GdaQ5L5FuppztZ2vYPHqLh8Tdc=; b=XJAXDFtA65ihKmBu9F3c6s9j/6 jITS3iA/2Ni2VPVYE5WlZoyg4E/Ze9JfBmimd8Wd72suUKRxfHqc4sMIXRwASNMoKTX+9r5PaY1Gi 3RTTFWCKPZMge5i2YK90NHWaGcX1oGtOfBOZguztxt3iEZyTTHKAIOEnOyq6U5AMXpsk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182222: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e0e5dca517a5964d407f48bdfccbea88113b2736 X-Osstest-Versions-That: qemuu=9400601a689a128c25fa9c21e932562e0eeb7a26 From: osstest service owner Date: Tue, 08 Aug 2023 08:43:39 +0000 flight 182222 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182222/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182208 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182208 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182208 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182208 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182208 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182208 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182208 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182208 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu e0e5dca517a5964d407f48bdfccbea88113b2736 baseline version: qemuu 9400601a689a128c25fa9c21e932562e0eeb7a26 Last test of basis 182208 2023-08-07 01:39:59 Z 1 days Testing same since 182222 2023-08-07 20:38:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Klaus Jensen Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9400601a68..e0e5dca517 e0e5dca517a5964d407f48bdfccbea88113b2736 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:47:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:47:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579440.907410 (Exim 4.92) (envelope-from ) id 1qTIMw-0000u8-PO; Tue, 08 Aug 2023 08:47:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579440.907410; Tue, 08 Aug 2023 08:47:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIMw-0000u1-LG; Tue, 08 Aug 2023 08:47:10 +0000 Received: by outflank-mailman (input) for mailman id 579440; Tue, 08 Aug 2023 08:47:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIMv-0000tv-0m for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:47:09 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 271fb911-35c8-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:47:06 +0200 (CEST) Received: from [192.168.1.15] (host-79-35-203-138.retail.telecomitalia.it [79.35.203.138]) by support.bugseng.com (Postfix) with ESMTPSA id AB9714EE0737; Tue, 8 Aug 2023 10:47:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 271fb911-35c8-11ee-8613-37d641c3527e Message-ID: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> Date: Tue, 8 Aug 2023 10:47:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US, it From: Federico Serafini Subject: MISRA violations in hypercall-defs Organization: BUGSENG srl To: Xen-devel Cc: jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Stefano Stabellini Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello everyone. I would like to to ask your opinion about the auto-generated file xen/include/xen/hypercall-defs.h which contains some violations of MISRA C:2012 Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". Such violations can be seen at the following links (copy and paste the link on you browser, including also the characters after the '#'): - arm https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} - x86 https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} Some of the violations are due to mismatches on the return types and the use of `ret_t`. I see that xen/include/hypercall-defs.c generates the declarations but I am not sure about what might be the best way to modify it so as to address violations with the least amount of changes. Do you have any suggestions? Regards -- Federico Serafini, M.Sc. Software Engineer, BUGSENG (http://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:48:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:48:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579446.907418 (Exim 4.92) (envelope-from ) id 1qTIOa-0001Tt-2R; Tue, 08 Aug 2023 08:48:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579446.907418; Tue, 08 Aug 2023 08:48:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIOZ-0001Tm-W6; Tue, 08 Aug 2023 08:48:51 +0000 Received: by outflank-mailman (input) for mailman id 579446; Tue, 08 Aug 2023 08:48:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIOY-0001Te-Lu for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:48:50 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 64c7b750-35c8-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:48:49 +0200 (CEST) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b9cdbf682eso82908921fa.2 for ; Tue, 08 Aug 2023 01:48:49 -0700 (PDT) Received: from [192.168.201.133] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id y15-20020a2e978f000000b002b6c56fe862sm2143390lji.63.2023.08.08.01.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 01:48:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 64c7b750-35c8-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691484529; x=1692089329; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Xeyk9j8uv9IEWoHvsDNlnRdPsM1L1t/cJx4iovXa6Cw=; b=hbm4+6WZyNd22/aR7q1VUxf3J4RtUAIX+IZfx6nrZ2RxmTLFC5IhQQSFd6Xaqekqv9 KHaq1b/TNO39Va9ajYlzia0O5C6f/mNHpsvL/iA0EmPXqwG/5TV4VuapiGigJV8p7WEs NZ9aA/qnPpRhaXCAjL+LwAulfkWlo8Bi3yqJOGetOt8enY1IjRw/dbsqVgQaBn5Ko11/ cmiXPpjW8fZJCp5sO8qr0S0FQN2hmfUuQoQw4bBaggCrog3Ho0jOafE5/4PUinZ2Kv6A uyVQnrPrL16zi23sepQOYqobMjOUCUHQl/h9lALoxeWYit63JVpdOzA4c5P+Lo4GYpAR Iaaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691484529; x=1692089329; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Xeyk9j8uv9IEWoHvsDNlnRdPsM1L1t/cJx4iovXa6Cw=; b=YOCw+7yVFNL+qh7pWWGrJbl8Srkb7xTVcLs0YjdIWzKQhrDnOhg0wbmPCd7DGipU93 hCgHPFhsAWbDKKn58zp0Ruy9xXanm5rzf261GClRMl6w2YNX6dH1lKKJ0+UwDMiwSM4d rZDzdwFaFmpiDS3FqFzlw+lZDVgMGNpj+8HEySjd8ijyNik1FEk9qUDcR81LQLrF1a/F AKaq8FgpoCKFyuSNt64XapOWBbnTerzb4Xon3h+uoiebGNyvQt1jyxGQY5U+hmHzzLCD PafOnvTfn3ErhB4sQDXbeiP/Mk+NP6j2XghLnAoF6/oWR5LTU0sv0PCtsoprRg/8zG7S YYuw== X-Gm-Message-State: AOJu0YwBaNwFuPvNLTJ7U1QxRwQSEyMnkphB+kgv31zF59Ur83wb4pD2 rJU9R56h4TIdWM7pTj6DFRk= X-Google-Smtp-Source: AGHT+IGHFaT9cExJYQOkXw2FUwPED/U1cRarZnRifSNetksyPjjKE7QeHrhbz7uPJslDOUiac1x+0Q== X-Received: by 2002:a2e:9254:0:b0:2b6:da1e:d063 with SMTP id v20-20020a2e9254000000b002b6da1ed063mr7670245ljg.45.1691484528946; Tue, 08 Aug 2023 01:48:48 -0700 (PDT) Message-ID: Subject: Re: [PATCH v7 5/6] xen/riscv: introduce an implementation of macros from From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Tue, 08 Aug 2023 11:48:47 +0300 In-Reply-To: <8098e465-d25c-7fe4-dd97-2f44a689c9a6@suse.com> References: <9fdda7716faf412f1e2cdf9a990c98e64c4b21f3.1691063432.git.oleksii.kurochko@gmail.com> <8098e465-d25c-7fe4-dd97-2f44a689c9a6@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 On Mon, 2023-08-07 at 15:29 +0200, Jan Beulich wrote: > On 03.08.2023 14:05, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/traps.c > > +++ b/xen/arch/riscv/traps.c > > @@ -5,6 +5,8 @@ > > =C2=A0 * RISC-V Trap handlers > > =C2=A0 */ > > =C2=A0 > > +#include > > +#include > > =C2=A0#include > > =C2=A0 > > =C2=A0#include > > @@ -12,6 +14,8 @@ > > =C2=A0#include > > =C2=A0#include > > =C2=A0 > > +#define cast_to_bug_frame(addr) ((const struct bug_frame *)(addr)) > > + > > =C2=A0/* > > =C2=A0 * Initialize the trap handling. > > =C2=A0 * > > @@ -101,7 +105,131 @@ static void do_unexpected_trap(const struct > > cpu_user_regs *regs) > > =C2=A0=C2=A0=C2=A0=C2=A0 die(); > > =C2=A0} > > =C2=A0 > > +void show_execution_state(const struct cpu_user_regs *regs) > > +{ > > +=C2=A0=C2=A0=C2=A0 printk("implement show_execution_state(regs)\n"); > > +} > > + > > +/* > > + * TODO: generic do_bug_frame() should be used instead of current > > + * implementation panic(), printk() and find_text_region() > > + * (virtual memory?) will be ready/merged > > + */ > > +int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t pc) > > +{ > > +=C2=A0=C2=A0=C2=A0 const struct bug_frame *start, *end; > > +=C2=A0=C2=A0=C2=A0 const struct bug_frame *bug =3D NULL; > > +=C2=A0=C2=A0=C2=A0 unsigned int id =3D 0; >=20 > Pointless initializer. Agree. Thanks. I'll remove it. >=20 > > +=C2=A0=C2=A0=C2=A0 const char *filename, *predicate; > > +=C2=A0=C2=A0=C2=A0 int lineno; > > + > > +=C2=A0=C2=A0=C2=A0 static const struct bug_frame *bug_frames[] =3D { >=20 > You likely want another const here. Yes, I will add it. >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &__start_bug_frames[0], > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &__stop_bug_frames_0[0], > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &__stop_bug_frames_1[0], > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &__stop_bug_frames_2[0], > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &__stop_bug_frames_3[0], > > +=C2=A0=C2=A0=C2=A0 }; > > + > > +=C2=A0=C2=A0=C2=A0 for ( id =3D 0; id < BUGFRAME_NR; id++ ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 start =3D cast_to_bug_frame= (bug_frames[id]); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 end=C2=A0=C2=A0 =3D cast_to= _bug_frame(bug_frames[id + 1]); >=20 > Why these casts (and then even hidden in a macro)? The array elements > look to already be of appropriate type. There is no any sense for these casts. It looks like that before bug_frames array has a different type. >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 while ( start !=3D end ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if = ( (vaddr_t)bug_loc(start) =3D=3D pc ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 bug =3D start; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 goto found; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sta= rt++; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > +=C2=A0=C2=A0=C2=A0 } > > + > > + found: > > +=C2=A0=C2=A0=C2=A0 if ( bug =3D=3D NULL ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENOENT; > > + > > +=C2=A0=C2=A0=C2=A0 if ( id =3D=3D BUGFRAME_run_fn ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 void (*fn)(const struct cpu= _user_regs *) =3D bug_ptr(bug); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fn(regs); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto end; > > +=C2=A0=C2=A0=C2=A0 } > > + > > +=C2=A0=C2=A0=C2=A0 /* WARN, BUG or ASSERT: decode the filename pointer= and line > > number. */ > > +=C2=A0=C2=A0=C2=A0 filename =3D bug_ptr(bug); > > +=C2=A0=C2=A0=C2=A0 lineno =3D bug_line(bug); > > + > > +=C2=A0=C2=A0=C2=A0 switch ( id ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0 case BUGFRAME_warn: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk("Xen WARN at %s:%d\n= ", filename, lineno); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 show_execution_state(regs); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto end; > > + > > +=C2=A0=C2=A0=C2=A0 case BUGFRAME_bug: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk("Xen BUG at %s:%d\n"= , filename, lineno); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 show_execution_state(regs); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk("change wait_for_int= errupt to panic() when common > > is available\n"); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 die(); > > + > > +=C2=A0=C2=A0=C2=A0 case BUGFRAME_assert: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* ASSERT: decode the predi= cate string pointer. */ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 predicate =3D bug_msg(bug); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk("Assertion %s failed= at %s:%d\n", predicate, > > filename, lineno); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 show_execution_state(regs); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk("change wait_for_int= errupt to panic() when common > > is available\n"); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 die(); > > +=C2=A0=C2=A0=C2=A0 } > > + > > +=C2=A0=C2=A0=C2=A0 return -EINVAL; > > + > > + end: > > +=C2=A0=C2=A0=C2=A0 return 0; > > +} > > + > > +static bool is_valid_bugaddr(uint32_t insn) > > +{ > > +=C2=A0=C2=A0=C2=A0 return insn =3D=3D BUG_INSN_32 || > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (insn & C= OMPRESSED_INSN_MASK) =3D=3D BUG_INSN_16; > > +} >=20 > Why "addr" in the name when this takes an insn as argument? In the earliest patch series it was an address. But now it should be changed. Thanks. >=20 > > +/* Should be used only in Xen code ? */ >=20 > What is this question about? With ... I meant that it's not safe to use in guest code. >=20 > > +static uint32_t read_instr(unsigned long pc) > > +{ > > +=C2=A0=C2=A0=C2=A0 uint16_t instr16 =3D *(uint16_t *)pc; > > + > > +=C2=A0=C2=A0=C2=A0 if ( GET_INSN_LENGTH(instr16) =3D=3D 2 ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return (uint32_t)instr16; >=20 > (I don't think this cast is needed.) >=20 > > +=C2=A0=C2=A0=C2=A0 else > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return *(uint32_t *)pc; > > +} >=20 > ... there still being a double read here, do you perhaps mean to > make a statement (that this code isn't safe to use on guest code)? I wonder if it'll be safe to read 16 bytes at a time then we won't have double read ( if you meant that first 16 bytes are read twice ): static uint32_t read_instr(unsigned long pc) { uint16_t instr16 =3D *(uint16_t *)pc; if ( GET_INSN_LENGTH(instr16) =3D=3D 2 ) return (uint32_t)instr16; else{ // return *(uint32_t *)pc; uint16_t next_16 =3D *((uint16_t *)pc + 1); return ((uint32_t)instr16 << sizeof(instr16)) + next_16; } } >=20 > > =C2=A0void do_trap(struct cpu_user_regs *cpu_regs) > > =C2=A0{ > > +=C2=A0=C2=A0=C2=A0 register_t pc =3D cpu_regs->sepc; > > +=C2=A0=C2=A0=C2=A0 uint32_t instr =3D read_instr(pc); > > + > > +=C2=A0=C2=A0=C2=A0 if ( is_valid_bugaddr(instr) ) > > +=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( !do_bug_frame(cpu_regs= , pc) ) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cpu= _regs->sepc +=3D GET_INSN_LENGTH(instr); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret= urn; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > +=C2=A0=C2=A0=C2=A0 } > > + > > =C2=A0=C2=A0=C2=A0=C2=A0 do_unexpected_trap(cpu_regs); > > =C2=A0} >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:51:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:51:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579453.907432 (Exim 4.92) (envelope-from ) id 1qTIR2-0002vU-I7; Tue, 08 Aug 2023 08:51:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579453.907432; Tue, 08 Aug 2023 08:51:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIR2-0002vN-EA; Tue, 08 Aug 2023 08:51:24 +0000 Received: by outflank-mailman (input) for mailman id 579453; Tue, 08 Aug 2023 08:51:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIR1-0002vH-IH for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:51:23 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060a.outbound.protection.outlook.com [2a01:111:f400:7eab::60a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be8e1956-35c8-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:51:21 +0200 (CEST) Received: from SJ0PR03CA0111.namprd03.prod.outlook.com (2603:10b6:a03:333::26) by DM4PR12MB5133.namprd12.prod.outlook.com (2603:10b6:5:390::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 08:51:11 +0000 Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:a03:333:cafe::a2) by SJ0PR03CA0111.outlook.office365.com (2603:10b6:a03:333::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 08:51:15 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Tue, 8 Aug 2023 08:51:15 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 03:51:14 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 8 Aug 2023 03:51:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be8e1956-35c8-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OZADm3QZPm9kXFgl+5vip5eDaY/WxIebd0+dBAcyUQMI/P6qFkjvSCbPo2HSJrSfLRIcU0Lx9TpuuASGsi2KYI/0ihcJkkXCCE9hPlZFjwd8qDQNFP+VFPDkEs9NhWQoiP9mrrGKK/v/V9bfPp95zFezkXfDPA+VLm6XNXaKNJlh3mBBXoYuD3wFvgjHsNzuIeFBZTikPt/UNU4es6ClHX/VyROYqEFSxjW4HRx5VY84SxUu7fi4dL+0t3a08zaRCZyl1KVT/uWSTVK0retABdg45iKj3rGkdozi9MG/C3KHmdywEPt/w0uhnsekQcQClPXjmDxDXDeCMeyGINRXGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pE2YST4ruG9R8GnmQ8+4KZbvCk2XZ3h2oHzBJBNFzrc=; b=UhScKq5cwgJjEwe0rGDBNF+kOBAOp+gtIGkW4Of0V1v0VHBEVsexPtEhYOjm5naQWf8ejLXUTFua37dMy110O/uuAnMHci0UobT60bZdUqpMGV4q6QodphX5whfxzwokJ413qgLZMlf8rVMl768H8PV/7PDX6/OkM74HrC7ud/3H9zYYjkBklk+lCplT719+UnXy8W2dBjIMrhRlB0NCvuYTRdc/9cQclEi+nlp236bC8cdtoFF/MdcN1yxGtZDcseUAFUJUytS6gM0tcQAeIF/LPf3UHIYlpVYPuLgFeKMZPkR9d0KB/AcgVsm+oOVh5jptLeusEIfjcpEqb3Vdew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pE2YST4ruG9R8GnmQ8+4KZbvCk2XZ3h2oHzBJBNFzrc=; b=pNECnW5xPOP7vWkthaWftm3RwLAE6URuf2/EmqeFQQHXK72cbYXRB29GWyQyiYN6uPLvjLCz6SCRU2C+tpc3zcxQZ3Lmi3FM7acNk/ikH6rHnW8VGb5+wQkekewIbxAa7IvAxW7pcr6yzlPADjdfjTsVQYFgvLFRKI6P/Bisr1U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Doug Goldstein , Stefano Stabellini Subject: [PATCH] automation: Fix missing smoke.serial in artifacts of qemu arm32 jobs Date: Tue, 8 Aug 2023 10:50:59 +0200 Message-ID: <20230808085059.13112-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|DM4PR12MB5133:EE_ X-MS-Office365-Filtering-Correlation-Id: 88153766-55c6-42ee-ef97-08db97ec9fe4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R76gCFZeY5wJF+pMmdKA6F0hJGTPTHTtzv2h4VWaSu//QUZwCLXt5ixWWcf8/6iK0spLZtoVDHcDexUaJx4Xl+hraMmRmc4B3zRirAQ+hQVahvJgGGEatt06W+JD/gpFV8Oy1YLZ3bS41Hg/VPXYaXqWDMCiVe+RIH3DMnoqb+u7WP0Jz4fnUS0foMmU495dusV3FQmeEjKObHc2L0v+78ShV8yLzw7LwAPn5grU8ObyCKb/ow2iQDTlhffzfVYe/eU/g/Pay+q+bPIdy2BEVsUtd+2X+MTzrVjN9EnEsBHoKvR2vEtmS/VIramuYxN3CIzBO3ZDvFoEVhGbiqXm5hQxnqlaZoR1VvmrZPwggJC1jVa8Nw3gkQ47IKJbPHIWw+9BmdaCZRYsk8MAwpd5eH7FOqpvauQDgyuPQ2eK+o8bmllQ/ue5a0GSxvMp6Lq/Cer30vaFQeyR39bUWdLSUzrsBS23FNmThgyDXpO3lH5vwVl2jlc6g7Jaa/GcWqvs6DeseF27wskrritdBiGIu6ePDnXBA4snu0TBwDeFpGQu9tvOJ4CRrxxRYZnjsPqe17nuQ6JiHcMXsnOomTxQ3CE2mFrOtZo1PScRG7H4ar5mTmq1VgAyziYDIoUTJ1+wg2FDA0DZtf+b6+ddCR6aXu6qHd4qE9NtzWOjRIi9+i/+TuhkHW6VINsw2FrLFfpQ2eLUVYO9RtUIW3A7hkeaFehfHT+FTpNC8+bMzhw+gcKLhPdiZpnqw5teqVfv/jrjrH2hbLNDTeSQi10hOdd6bA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(376002)(136003)(82310400008)(451199021)(1800799003)(186006)(46966006)(40470700004)(36840700001)(47076005)(83380400001)(426003)(36860700001)(40480700001)(316002)(41300700001)(70586007)(70206006)(6916009)(44832011)(4326008)(1076003)(8936002)(8676002)(26005)(6666004)(5660300002)(966005)(478600001)(54906003)(86362001)(2616005)(40460700003)(356005)(81166007)(36756003)(336012)(82740400003)(2906002)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 08:51:15.2307 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88153766-55c6-42ee-ef97-08db97ec9fe4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5133 It was observed that smoke.serial file (used to store boot logs) is missing in artifacts of qemu based arm32 jobs. This is because the artifacts:paths listing smoke.serial specifies paths relative to the project directory but the qemu-smoke-dom0{less}-arm32.sh scripts create this file under binaries/. Fix it so that smoke.serial gets created in project directory just like for every other test job. Signed-off-by: Michal Orzel --- automation/scripts/qemu-smoke-dom0-arm32.sh | 8 +++++--- automation/scripts/qemu-smoke-dom0less-arm32.sh | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/automation/scripts/qemu-smoke-dom0-arm32.sh b/automation/scripts/qemu-smoke-dom0-arm32.sh index 2c80df089f23..e6f303064a83 100755 --- a/automation/scripts/qemu-smoke-dom0-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0-arm32.sh @@ -2,6 +2,8 @@ set -ex +serial_log="$(pwd)/smoke.serial" + cd binaries mkdir rootfs @@ -74,7 +76,7 @@ rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config -rm -f smoke.serial +rm -f ${serial_log} set +e echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ timeout -k 1 720 \ @@ -89,8 +91,8 @@ timeout -k 1 720 \ -no-reboot \ -device virtio-net-pci,netdev=n0 \ -netdev user,id=n0,tftp=./ \ - -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee ${serial_log} set -e -(grep -q "Domain-0" smoke.serial && grep -q "^/ #" smoke.serial) || exit 1 +(grep -q "Domain-0" ${serial_log} && grep -q "^/ #" ${serial_log}) || exit 1 exit 0 diff --git a/automation/scripts/qemu-smoke-dom0less-arm32.sh b/automation/scripts/qemu-smoke-dom0less-arm32.sh index cc91238f4222..fb8f044a51f6 100755 --- a/automation/scripts/qemu-smoke-dom0less-arm32.sh +++ b/automation/scripts/qemu-smoke-dom0less-arm32.sh @@ -7,6 +7,8 @@ test_variant=$1 # Prompt to grep for to check if dom0 booted successfully dom0_prompt="^/ #" +serial_log="$(pwd)/smoke.serial" + cd binaries # Use the kernel from Debian curl --fail --silent --show-error --location --output vmlinuz https://deb.debian.org/debian/dists/bullseye/main/installer-armhf/current/images/netboot/vmlinuz @@ -120,7 +122,7 @@ git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d . -c config # Run the test -rm -f smoke.serial +rm -f ${serial_log} set +e echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ timeout -k 1 240 \ @@ -135,8 +137,8 @@ timeout -k 1 240 \ -no-reboot \ -device virtio-net-pci,netdev=n0 \ -netdev user,id=n0,tftp=./ \ - -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee smoke.serial + -bios /usr/lib/u-boot/qemu_arm/u-boot.bin |& tee ${serial_log} set -e -(grep -q "${dom0_prompt}" smoke.serial && grep -q "${passed}" smoke.serial) || exit 1 +(grep -q "${dom0_prompt}" ${serial_log} && grep -q "${passed}" ${serial_log}) || exit 1 exit 0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:52:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:52:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579459.907441 (Exim 4.92) (envelope-from ) id 1qTISI-0003U0-S3; Tue, 08 Aug 2023 08:52:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579459.907441; Tue, 08 Aug 2023 08:52:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTISI-0003Tt-PG; Tue, 08 Aug 2023 08:52:42 +0000 Received: by outflank-mailman (input) for mailman id 579459; Tue, 08 Aug 2023 08:52:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTISH-0003Tj-ER for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:52:41 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec2d3a1c-35c8-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 10:52:38 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec2d3a1c-35c8-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691484758; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uFJS4zUP1wrl2GtEuegrig1oYvjn3Yx0XvzdioJ2fk8=; b=bqHHOp3+NpBDKCELRRSo/q9nOU97RKtzgDe13wE8apeqKr85DfRt0SIA GinQiASs1ZYozis/GCR2OX52I7b+IB1zTb//Oc631RD1ZeKUMNzZgenH9 mM+blK+Bn4xN+UfANLbDLyMx4MeEaRO6009mGluPXNG4AYfiIkbnmXAYX E=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 119255927 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:mUv5+aiaklxVgh80srR2N/CIX161lhAKZh0ujC45NGQN5FlHY01je htvWTuDbvyOYjDyLo9zbtvgo08C6pXcyIJkQAtk/y9hRXwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT7AeBzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQHKCIdXzq6vN6G0bu3UulLqZohNPbSadZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJYw1MYH49tL7Aan3XejtEqFWTtOwv7nLa1gBZ27nxKtvFPNeNQK25m27B/ zOcojmoWE5y2Nq3kheM0Finvev2jz7XQdI0Ba2ayvNyuQjGroAUIEJPDgbqyRWjsWa8UtRTM V0J+QIhqKEz8AqgSdyVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOq8seVTEsk FiTkLvBBzN1t6aOYWmA7brSpjS3UQAXJ2IfYS4PTSMe/sLu5oo0i3rnTMtnEaOzps34H3f32 T/ihDMlm7wZgMoP1qO61VPKmTShot7OVAFdzgzPU3is9A9ReI+vbIvu4l/ehcusN67AEAPH5 iJd3ZHDsqZXV8rleDGxrPslA7G798evCQbgsU9mE4Eh0Bvz+WacRNUFiN1hH3tBPsEBcD7vR UbcvwJN+ZNeVEeXgb9Lj5GZUJpzk/W5fTjxfrWNN4cVPMAtHOOS1Hs2DXN8yVwBh6TFfUsXH Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwZ507/uVZ9TCTPIVvgDLdpRr5R0U98iF+Jm +uzzuPTo/mlbMXwYzPM7akYJk0QIH4wCPje8pIGL7LYeVA3RDF4W5c9JI/NnKQ/xsxoehrgp CnhCie0NnKg7ZE4Fel6Qi86M+6+NXqOhXk6ITYtLT6VN4sLOO6SAFMkX8JvJ9EPrbUzpcOYu tFZI61s9NwTEGWYk9ncBLGhxLFfmOOD31/Xbnr/PmZjJ/aNhWXho7fZQ+cmzwFWZgLfiCf0i +fIOt/zKXbbezlfMQ== IronPort-HdrOrdr: A9a23:RR3PT6wZp8TSTgA3HOhvKrPwDL1zdoMgy1knxilNoH1uA6ulfq WV98jzuiWVtN98YgBCpTniAtjjfZq/z/FICOAqVN+ftWHdyQ2Vxa5ZjLcKqAeQfxEWmNQtsJ uINJIVNPTASXh8kOP95hDheuxP/PC3tICumMLZyW5GSx1sdvoI1WtE4wCgf3FLeA== X-Talos-CUID: 9a23:hY2VXmxsOfseVU564wUcBgULGtI1Q1fk90vgMka0EWZOZ+OXUWCprfY= X-Talos-MUID: 9a23:BBXsmgno0I4VDVabWskadno5Gc5Kya+VDHkfjLkf6++VJQ5MNi+k2WE= X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="119255927" Date: Tue, 8 Aug 2023 09:52:26 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: Re: [PATCH v8 04/15] xen/sysctl: Nest cpufreq scaling options Message-ID: <70f310ae-5007-45dc-b0a8-dbf20be59747@perard> References: <20230807185119.98333-1-jandryuk@gmail.com> <20230807185119.98333-5-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230807185119.98333-5-jandryuk@gmail.com> On Mon, Aug 07, 2023 at 02:51:08PM -0400, Jason Andryuk wrote: > diff --git a/tools/libs/ctrl/xc_pm.c b/tools/libs/ctrl/xc_pm.c > index c3a9864bf7..5ec050982a 100644 > --- a/tools/libs/ctrl/xc_pm.c > +++ b/tools/libs/ctrl/xc_pm.c > @@ -245,6 +245,45 @@ int xc_get_cpufreq_para(xc_interface *xch, int cpuid, > sys_para->freq_num = user_para->freq_num; > sys_para->gov_num = user_para->gov_num; > > + /* Sanity check struct layout */ > + BUILD_BUG_ON(sizeof(*user_para) != sizeof(*sys_para)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), cpu_num) != > + offsetof(typeof(*sys_para), cpu_num)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), freq_num) != > + offsetof(typeof(*sys_para), freq_num)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), gov_num) != > + offsetof(typeof(*sys_para), gov_num)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), affected_cpus) != > + offsetof(typeof(*sys_para), affected_cpus)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), scaling_available_frequencies) != > + offsetof(typeof(*sys_para), scaling_available_frequencies)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), scaling_available_governors) != > + offsetof(typeof(*sys_para), scaling_available_governors)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), scaling_driver) != > + offsetof(typeof(*sys_para), scaling_driver)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), cpuinfo_cur_freq) != > + offsetof(typeof(*sys_para), cpuinfo_cur_freq)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), cpuinfo_max_freq) != > + offsetof(typeof(*sys_para), cpuinfo_max_freq)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), cpuinfo_min_freq) != > + offsetof(typeof(*sys_para), cpuinfo_min_freq)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_cur_freq) != > + offsetof(typeof(*sys_para), u.s.scaling_cur_freq)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_governor) != > + offsetof(typeof(*sys_para), u.s.scaling_governor)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_max_freq) != > + offsetof(typeof(*sys_para), u.s.scaling_max_freq)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.scaling_min_freq) != > + offsetof(typeof(*sys_para), u.s.scaling_min_freq)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.u.userspace) != > + offsetof(typeof(*sys_para), u.s.u.userspace)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.s.u.ondemand) != > + offsetof(typeof(*sys_para), u.s.u.ondemand)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), u.cppc_para) != > + offsetof(typeof(*sys_para), u.cppc_para)); > + BUILD_BUG_ON(offsetof(typeof(*user_para), turbo_enabled) != > + offsetof(typeof(*sys_para), turbo_enabled)); These could have been done by defining a temporary macro to avoid repeating the fields name twice, but this sanity check is good and should prevent anyone from changing one struct without changing the other one. Thanks. Reviewed-by: Anthony PERARD Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 08:56:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 08:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579468.907452 (Exim 4.92) (envelope-from ) id 1qTIW1-0004Aj-GP; Tue, 08 Aug 2023 08:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579468.907452; Tue, 08 Aug 2023 08:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIW1-0004Ac-CI; Tue, 08 Aug 2023 08:56:33 +0000 Received: by outflank-mailman (input) for mailman id 579468; Tue, 08 Aug 2023 08:56:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIW0-0004AW-Ar for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 08:56:32 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76cd6391-35c9-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 10:56:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76cd6391-35c9-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691484990; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=G8sksAySfdqgLV99gZYQwtewml6bcB/hzhA07cdtiU4=; b=KIjbINkxdIqvHx+OkNPtE7PGcf3+V9e1adf1aoTMIa8u7dL5A4qFJGVA YUcuz1ffn5dhaKYQ27PpqeBrtljvT5mPts8cdvi81KUej5CoDh4jYfEiB itulO4NjNaocKB09O77XWCFWm71euBXphrzNLkuIAw/SwOYIEbtTd9B7N I=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118703922 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:HZPbHKrncK69rNGWTD8w3q6HI6BeBmInZRIvgKrLsJaIsI4StFCzt garIBmFP6neM2f8etwiaom3oUMP6MSBz4QwQVRpqy80FClD85uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOzyZNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAAsmPwGgm9uO+rS2S/FPif17LfG6O4xK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jufrzuhWUBAbrRzzxLG/0qQr9b+hxnGSaUtS5KCzO9W2wCckzl75Bo+CgLg/KjRZlSFc9BWL UAO6zcthac3/U2vCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcpQRQ62 1nPmMnmbRRturCITXOW9p+PsCi/fyMSKAcqbDcJVwIf7/H/oYs4iVTESdMLLUKupoSrQ3eqm WnM9XVgwexJ1qbnyplX43j8qGO9hYTwdjQz6wTPfW2ctgJBNYmqMtnABUfg0d5MK4OQT1+kt XcCmtSD4O1mMaxhhBBhU81WQuj3uq/t3Cn0xAc2QsJ/r2jFF2uLJ9g43d1oGKt+3i/okxfNa VSbhw5e7YQ70JCCPf4uONLZ5yjHIMHd+TXZuhL8NIImjntZLlXvEMRSiam4gQjQfLAEy/1XB HtiWZ/E4YwmIapm1iGqYOwWzKUmwCszrUuKG8Gik0/8i+vCNCfFIVvgDLdpRrpghJ5oXS2Pq 4oPXyd040o3vBLCjtn/rtdIcAFiwYkTDpHqsc1HHtNv0SI/cFzN/8T5mOt7E6Q8xvQ9qws91 i3lMqOu4Aal1CKvxMTjQiwLVY4Dqr4l8CtqbXZyYwrws5XhCK72hJoim1IMVeFP3IReITRcF pHpp+3o7ixzdwn6 IronPort-HdrOrdr: A9a23:sEci+qHTGYGGqOYGpLqE0ceALOsnbusQ8zAXPidKOHlom62j5q KTdZEgvnXJYVkqNU3I5urwXpVoLUmxyXcN2+ks1NSZLWrbUQmTQ72KhLGKqwEIcBeOkdK1u5 0QF5SWcOeQMbEAt6jHCQCDYq8d/OU= X-Talos-CUID: 9a23:TXE0tmNThfTA5u5DYwI25W0II/gfdHDc1FTfGhe5MTduR+jA X-Talos-MUID: =?us-ascii?q?9a23=3AgTOYnA76nVhF4GJ1qdxhdTr7xowr7pySIXk8i68?= =?us-ascii?q?7qu67agNKASah12m4F9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="118703922" Date: Tue, 8 Aug 2023 09:56:19 +0100 From: Anthony PERARD To: Jason Andryuk CC: , Wei Liu , Jan Beulich Subject: Re: [PATCH v8 11/15] xenpm: Print HWP/CPPC parameters Message-ID: References: <20230807185119.98333-1-jandryuk@gmail.com> <20230807185119.98333-12-jandryuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230807185119.98333-12-jandryuk@gmail.com> On Mon, Aug 07, 2023 at 02:51:15PM -0400, Jason Andryuk wrote: > Print HWP-specific parameters. Some are always present, but others > depend on hardware support. > > Signed-off-by: Jason Andryuk > Reviewed-by: Jan Beulich > --- > v8: > Switch from "if ( !hwp )" to "if ( hwp )" and re-org code. > Use %PRIu32 instead of %u - this lengthens some strings past 80 chars Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:03:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:03:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579480.907461 (Exim 4.92) (envelope-from ) id 1qTIcu-0005g1-Ak; Tue, 08 Aug 2023 09:03:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579480.907461; Tue, 08 Aug 2023 09:03:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIcu-0005fu-7O; Tue, 08 Aug 2023 09:03:40 +0000 Received: by outflank-mailman (input) for mailman id 579480; Tue, 08 Aug 2023 09:03:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIcs-0005fo-Gd for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:03:38 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 759aa5e8-35ca-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 11:03:37 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 7A1C64EE0737; Tue, 8 Aug 2023 11:03:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 759aa5e8-35ca-11ee-b280-6b7b168915f2 MIME-Version: 1.0 Date: Tue, 08 Aug 2023 11:03:36 +0200 From: Nicola Vetrini To: Jan Beulich Cc: Stefano Stabellini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1 In-Reply-To: <3a6ab847-fd31-60e4-2558-feed71d670dd@suse.com> References: <7f8cbd8c8ad64cd3a0d099f31cb4d3fad48aa63b.1690985045.git.nicola.vetrini@bugseng.com> <3a6ab847-fd31-60e4-2558-feed71d670dd@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 04/08/2023 08:42, Jan Beulich wrote: > On 04.08.2023 01:50, Stefano Stabellini wrote: >> On Thu, 3 Aug 2023, Jan Beulich wrote: >>> On 02.08.2023 16:38, Nicola Vetrini wrote: >>>> Rule 2.1 states: "A project shall not contain unreachable code". >>>> >>>> The functions >>>> - machine_halt >>>> - maybe_reboot >>>> - machine_restart >>>> are not supposed to return, hence the following break statement >>>> is marked as intentionally unreachable with the ASSERT_UNREACHABLE() >>>> macro to justify the violation of the rule. >>> >>> During the discussion it was mentioned that this won't help with >>> release builds, where right now ASSERT_UNREACHABLE() expands to >>> effectively nothing. You want to clarify here how release builds >>> are to be taken care of, as those are what eventual certification >>> will be run against. >> >> Something along these lines: >> >> ASSERT_UNREACHABLE(), not only is used in non-release builds to >> actually >> assert and detect errors, but it is also used as a marker to tag >> unreachable code. In release builds ASSERT_UNREACHABLE() doesn't >> resolve >> into an assert, but retains its role of a code marker. >> >> Does it work? > > Well, it states what is happening, but I'm not convinced it satisfies > rule 2.1. There's then still code there which isn't reachable, and > which a scanner will spot and report. > > Jan It's not clear to me whether you dislike the patch itself or the commit message. If it's the latter, how about: "ASSERT_UNREACHABLE() is used as a marker for intentionally unreachable code, which constitutes a motivated deviation from Rule 2.1. Additionally, in non-release builds, this macro performs a failing assertion to detect errors." -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:12:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:12:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579486.907472 (Exim 4.92) (envelope-from ) id 1qTIlB-0007Ab-3n; Tue, 08 Aug 2023 09:12:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579486.907472; Tue, 08 Aug 2023 09:12:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIlB-0007AU-0p; Tue, 08 Aug 2023 09:12:13 +0000 Received: by outflank-mailman (input) for mailman id 579486; Tue, 08 Aug 2023 09:12:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIl9-0007AO-He for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:12:11 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20626.outbound.protection.outlook.com [2a01:111:f400:fe16::626]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a62d6030-35cb-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 11:12:08 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8975.eurprd04.prod.outlook.com (2603:10a6:102:20e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Tue, 8 Aug 2023 09:12:05 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 09:12:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a62d6030-35cb-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mt3l1naRyE0uTbediYkK65YJJvvV6onIAvSzlxo9IAx5UEm79u8D91/Bw3ZLeh7weoGwc4eZ4r06QEOnAkFPnXQG9v5j0WA9Rnztt3NjceTR8ofdoN6cLMjZreaymosMsMpNIMdOrqw47KuZqufGoMvkAREAtZPEls0oaTqSWQfOau042QFiq0s5zH9kGlxjMVQW86bpuoAQLZkGBC+N4w+hras2DirQ8luN8Fp7ZJDrXdM2WOLV9nWTESW6JLRikwnJaE8QXaLpRD66sDhyn3uVe09ukOjzu2euJX1vrDziPcAoVnncUFB4s7eaLmR4bJfvyfTBbH8t9y3Ee1EiDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WRMrlbTsrT8329VDgQBLi4g1G38EtH7AKmj/hwaLD3w=; b=atvhuv4Dw8UD7BsriRAWu9RBUx02k1LKJ3fWu0fcZHKBMM8GbGfKPTW1Kms7zQCbmHB2Fg7y5N1r671CEnYY+NcYDaMhRvRQVDhjcV2dJNMmUTBR0yEYpgtPRtWtt9ky5tRBrOni8VAi0yQyn1I9JLaHsf/J2bTA5XWMKCeB/iWbRsF5zQURD88JqCUbHmPlwvYJp+lDWRZj4yB5ZYVhgMWbvOy6eV6Ap7Ax2Nrg12ALz+TRP8TLyDSzM66oQI3mprq/VsLaxcizVYWMtjaDlEwW6jaDZ69V8bMTUjOytGNcaKljn7TwoxkK03cOa/DtyFziPbhshHOotS9QfMZhLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WRMrlbTsrT8329VDgQBLi4g1G38EtH7AKmj/hwaLD3w=; b=pZEWDjhWbXpKGZor7BejrUo0iWs9R2/llL9mCW04g4JjB4Bi5hUguC26lgG52ZHFC9LzcgtApvrxR0yuGKV/QpC0d3/1BkhLYBRWYEEwaIUY8qegF4lHI/j4qotVSAYlPUH676ga1w3cRbBRr3ML7zRHEV/ivWmkacxqkeSIPXMro5hZtDywAStSQ9CmCKhGxv/Vm3/lh3qVyyslIHVTshF3RgXkGSrKQ1eSWsILOVy9QfEibsRWOtv3i0bxr38Usf9lJqVxwd+P44Jup6RGqBHPaVEqvh3vJYAf42zG/1mHUNCSaPPBsPatKNakWsawgDxTWW8NUuZM31Uq+6+iGw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 11:12:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 5/9] xen/ppc: Define minimal stub headers required for full build Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <9cd545a4a9ef55d06ea0b81044e22f64ee42823e.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <9cd545a4a9ef55d06ea0b81044e22f64ee42823e.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8975:EE_ X-MS-Office365-Filtering-Correlation-Id: b6168f74-adc9-43de-e2f3-08db97ef88cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GCX4RmUeHBkwICcTeu3Ek63MnEu+q0UGaubuG/zhdw07h1ACQ64Dcu2JUYMZBIWLTSMd1B06tp6R/kRzjRoSFdSv9xL2Yju85r9CpifmMfDQ/lPjeDE1GaF1tdeSYKRddAgpOuhoH1hv5J0bgqpJdxl928g6TbXMSjAsBSLKzCjZUMovAwtAxzE/SxYg9ZwKJ++GTznn4+ugkGS8QDk5lZDeLEFAA9dTyVQ4nObgtIdpRHMt1x2nz4C7HmYDnwMgwcG5HBjH2I/TdsMKOqXvY8/hRzCkQpO4lRAmRe43ffguOQH/s8nzIVHGuy1HXH0sKCtasFEuHRHTqEhwn5lJmrDKOMuU2vVTAYHvpzkN9KxvPAqaYbq6KOu4S82XFvaNDJTbGpAQ9KIkhCz4dILueLAy28iARLtb0hXzLaDW/bgf3io/42fIiLjpipSzKb9EZKsqIAjNIhd9HaU9Kg2xdhMI6xBC1KX62nVv5Q7HW3i21u8EukV6XolIP/cFft2glNVTOhChszktuFoz79PTjfgEE6sGXK473ch7PJUQf8XYJGi/xtp2nXWRiYqBDSrCrlvVuYGmgJD16BXAlhSzWk/TqL6KF6Ht0A/RRCEWC1us5RlZtzVTv0wGKvVzOlgU4DbWaiK41WEo0gUeEGTEAP3wsXH0AVVVu5mjI9vC7rw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199021)(1800799003)(186006)(2616005)(36756003)(4326008)(6512007)(316002)(6916009)(86362001)(6506007)(54906003)(6486002)(66946007)(38100700002)(6666004)(66556008)(478600001)(66476007)(31696002)(53546011)(41300700001)(26005)(8676002)(8936002)(66899021)(2906002)(30864003)(83380400001)(5660300002)(31686004)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVZZSDdkM0NpeGR5OWNFYytmTGhMUjlueEpXWHcxM3h2aFFETzRsL0lzdVN3?= =?utf-8?B?aUt2dC9xUjhTd0dyUTEvWU00MW16ejArU0FFMkFqUVo1WmZuUVZaQUFVT1Bu?= =?utf-8?B?OXgwdFZvbGxIMVUzdDdNM1lsRjRMdkdkWWRmRXl1RmRLQkhxa2gyeTF5ZG0v?= =?utf-8?B?UnhQdHZtRmNXOGhhTVBvMFkvZGlHL1ZNdURVQjRteVpUOXBTcXpORE9TdjJz?= =?utf-8?B?bFIzc0NhaWowMFZIK0VDMThBZnI3T1AwbFBHaGJvQTRDMUF6ZEZKVWVBT0w4?= =?utf-8?B?Q0NmTzR1cXV1T2NyTmU3K3ovQUgvbFJpZTZheEtSTlFSTmxyUGN1NWpLeEEy?= =?utf-8?B?WTZqbE84c3hEbTFuUFAwZzJRbWp5R2ppQjBmV1RFQWZ4aktjRnYxU2NuOGZJ?= =?utf-8?B?Qk5FbkkrZEc1WTRmZkd4Z25yWE5iVWNJaGV0RU93YUt6Rkk1Z2JEL1lkRDQ5?= =?utf-8?B?OG1LcStaUFlxR245dk5SNEIxOTQrVUZpd2ZXMXdMY05kMkpzWTkyU0hINnoz?= =?utf-8?B?Z3R5d3h6VWpqTkM3VmsrUm9BTkFOaHhQTFluZnZYd0o2bFZrUjJHUEIrbDJ3?= =?utf-8?B?Qk1kM3oveTR2aWFSQ3RHV3dGaE8vRzBIZ3ZFVzgvdmR1amJHSENVN21Sd3M4?= =?utf-8?B?MkhVdXdwRzJZdlJobHpqOC9uZ2U5YWxmeWt5cDMzdHhmZ0F4U2xQNUFRVmVT?= =?utf-8?B?WWt4ZmsxTWM5L3hPNkdsSm1YeDdDNGpWMjZaZjN2YUxZSTNaaGdpL2FRcDkv?= =?utf-8?B?eGhPVy8wZWRjNFE0bjA3VVp3N1pGTTYwNzg5VFFQMnVZNHZybjFqNGYzWFhT?= =?utf-8?B?VmVRVXBJUzVpV2dQd2tFaWJhbm5YVmcwdFo3NWE5ZlMyckE5OWE5eFQwZkxh?= =?utf-8?B?Y2k5RFgyVXErN2czWFFBYjE0b1VhQ0lHYzZhSkw1QjNVRnhCelcyN25qdkJC?= =?utf-8?B?ZnFVWFprWXFlNkJMckU4RmxSNUNLQWRTc2dRZ3BjTTZCSHE0ZStZVVBZdzM1?= =?utf-8?B?S0h2UENVSHZYZVIrWWh4S0VlbG1DMGpZZGpqN2hxUGUyRHNkbjhlOENxWGx1?= =?utf-8?B?TWtXakpMM296M1N2b21kbXI3TmVvZUlXazFFOHZ2M3l0Qkt2NGh2TWt3eHBi?= =?utf-8?B?d0xONWtmcGF2c1JmN3M4dVFkMmROUnBQamcxTjI3dDZjTmZlWFFSd05TZ2Vr?= =?utf-8?B?NUdTeHMvQzZPS0s3a2llQmpGZ01Gc1M5N1E5dGQ0cndhMCtlNitjWUtZbnpV?= =?utf-8?B?aWtlL05jUnZlNUFWUlM1aktsTXVsWW9uYVQ3TTRMc3k2ZUJKQml2Tk1PYndX?= =?utf-8?B?QXJRclZFbkNjZTNMd0JoalNxWkNORkozTjlpcGNuVTZGRzNBSUNNb3hLS2xP?= =?utf-8?B?SFdta1VRV3NRczBpYi94K0dqN2xJc1FFcGpwRkpOZ2F2Z1VqYmZqWGR6cGxT?= =?utf-8?B?M0FUTmJHaWRmYkZSN0diUHViSXVvVTRGUUp4MVVsc25UcVZsWENkUGRhbjdK?= =?utf-8?B?OG9GWU1xWlhDRmFJYWlMZ1c4WWU2Q0pQTWNRamRwdE1ZMmpsM0RFcXBaZlhz?= =?utf-8?B?VFc2Y2wrZTZoeXVQYmxLbjBreGlMczhWRlpFVDdsZHdraDFHbXRDUjh5eGdh?= =?utf-8?B?Mm0ya2E0MDFCTXNDVGlVUDBGWjhSWDFDbjhwZW1zL3dIa3U4WXIzdDR4RGhn?= =?utf-8?B?MWJDbnpka3lyR3dCbU94c2Ixb3ZDR3JwL1JwL2dvMHpUUkFXMHpCRTJ6eHBw?= =?utf-8?B?Qys2MFB2M0wweGEwMTY4SmpQVmJaL2JuTEpRWkpMaXFJVDRmNks1MmpMZFZw?= =?utf-8?B?RGtJYzNObHlpNW1mZkxyZy8wUnZRTUhibVFjNGE5SHV0V0s1UlA2ZU9YbkIx?= =?utf-8?B?SG04N25FaGt0bXRzcVFhS1VHOXg5RDhGUlNkcUFpY2lMRGM0czI5WThxTURV?= =?utf-8?B?aG5ScnY3UWUwYXB4SzB5Z0ZZeUdCbFZoOGxjbGpUdkF5U045MUI1U1p0T2V1?= =?utf-8?B?REtFdzRFNmRPZDJGTFN4RG5GOUlmdXBRYzBQVnlWNGU2Mk9oSDFKbnJ6ZTJm?= =?utf-8?B?cFEycm1KdlFDaC9IRU1mSWVLTjRnd0ZmSncrajhZaGRsZDRSN1ZxTDhna2Nh?= =?utf-8?Q?/y+qreG9Sl24ZIxP14JxoN9Pd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6168f74-adc9-43de-e2f3-08db97ef88cc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 09:12:05.2898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 905/h8N/aZEQ+6MdtXIM/5LpBRy4lSc23As8rhkfWCk7lFkU9QK9DISxCgJ+Z8R7oPj9Bq2AIuKOVzkUPyb+Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8975 On 03.08.2023 01:03, Shawn Anastasio wrote: > --- /dev/null > +++ b/xen/arch/ppc/include/asm/altp2m.h > @@ -0,0 +1,39 @@ > +/* > + * Alternate p2m > + * > + * Copyright (c) 2014, Intel Corporation. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program; If not, see . > + */ Please use an SPDX header instead in new code. I also wonder about the Intel copyright. I realize it's that way in the Arm header that you apparently copied, but even there it's pretty odd. I don't think such a pair of stub functions is reasonably copyrightable. > +#ifndef __ASM_PPC_ALTP2M_H__ > +#define __ASM_PPC_ALTP2M_H__ > + > +#include I don't think this is needed here (nor in Arm's original). All you need are forward decls of struct domain and struct vcpu. And xen/bug.h plus xen/types.h. > --- a/xen/arch/ppc/include/asm/bug.h > +++ b/xen/arch/ppc/include/asm/bug.h > @@ -4,6 +4,7 @@ > #define _ASM_PPC_BUG_H > > #include > +#include > > /* > * Power ISA guarantees that an instruction consisting of all zeroes is > @@ -15,4 +16,10 @@ > > #define BUG_FN_REG r0 > > +#define BUG() do { \ > + die(); \ > +} while (0) This looks like it's temporary. I think any construct that later needs updating wants marking in some common way (such that it's easy to grep for items left to be dealt with; you have such a comment in e.g. asm/event.h). Of course if an entire header consists of _only_ stubs, perhaps a single such comment would suffice. > --- a/xen/arch/ppc/include/asm/cache.h > +++ b/xen/arch/ppc/include/asm/cache.h > @@ -3,4 +3,6 @@ > #ifndef _ASM_PPC_CACHE_H > #define _ASM_PPC_CACHE_H > > +#define __read_mostly __section(".data.read_mostly") Not something for you to do, but we really want to move this to xen/cache.h. > diff --git a/xen/arch/ppc/include/asm/desc.h b/xen/arch/ppc/include/asm/desc.h > new file mode 100644 > index 0000000000..e69de29bb2 Along the lines of the above - common code should not include this header, and Arm shouldn't need one either. I'll see if I can sort this. > --- a/xen/arch/ppc/include/asm/mm.h > +++ b/xen/arch/ppc/include/asm/mm.h > @@ -1,19 +1,270 @@ > #ifndef _ASM_PPC_MM_H > #define _ASM_PPC_MM_H > > +#include > +#include > +#include > #include > #include > > +void setup_initial_pagetables(void); > + > +extern unsigned long total_pages; > + > #define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT) > #define paddr_to_pfn(pa) ((unsigned long)((pa) >> PAGE_SHIFT)) > +#define paddr_to_pdx(pa) mfn_to_pdx(maddr_to_mfn(pa)) > +#define gfn_to_gaddr(gfn) pfn_to_paddr(gfn_x(gfn)) > +#define gaddr_to_gfn(ga) _gfn(paddr_to_pfn(ga)) > +#define mfn_to_maddr(mfn) pfn_to_paddr(mfn_x(mfn)) > +#define maddr_to_mfn(ma) _mfn(paddr_to_pfn(ma)) > +#define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) > +#define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) > > #define virt_to_maddr(va) ((paddr_t)((vaddr_t)(va) & PADDR_MASK)) > -#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START) > +#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START)) > > /* Convert between Xen-heap virtual addresses and machine addresses. */ > #define __pa(x) (virt_to_maddr(x)) > #define __va(x) (maddr_to_virt(x)) > > -void setup_initial_pagetables(void); > +/* Convert between Xen-heap virtual addresses and machine frame numbers. */ > +#define __virt_to_mfn(va) (virt_to_maddr(va) >> PAGE_SHIFT) > +#define __mfn_to_virt(mfn) (maddr_to_virt((paddr_t)(mfn) << PAGE_SHIFT)) > + > +/* Convert between Xen-heap virtual addresses and page-info structures. */ > +static inline struct page_info *virt_to_page(const void *v) > +{ > + BUG(); > + return NULL; > +} > + > +/* > + * We define non-underscored wrappers for above conversion functions. > + * These are overriden in various source files while underscored version > + * remain intact. > + */ > +#define virt_to_mfn(va) __virt_to_mfn(va) > +#define mfn_to_virt(mfn) __mfn_to_virt(mfn) > + > +#define PG_shift(idx) (BITS_PER_LONG - (idx)) > +#define PG_mask(x, idx) (x ## UL << PG_shift(idx)) > + > +#define PGT_none PG_mask(0, 1) /* no special uses of this page */ > +#define PGT_writable_page PG_mask(1, 1) /* has writable mappings? */ > +#define PGT_type_mask PG_mask(1, 1) /* Bits 31 or 63. */ > + > + /* 2-bit count of uses of this frame as its current type. */ > +#define PGT_count_mask PG_mask(3, 3) > + > +/* Cleared when the owning guest 'frees' this page. */ > +#define _PGC_allocated PG_shift(1) > +#define PGC_allocated PG_mask(1, 1) > +/* Page is Xen heap? */ > +#define _PGC_xen_heap PG_shift(2) > +#define PGC_xen_heap PG_mask(1, 2) > +/* Page is static memory */ > +#define PGC_static 0 You don't need this. > +/* Page is broken? */ > +#define _PGC_broken PG_shift(7) > +#define PGC_broken PG_mask(1, 7) > + /* Mutually-exclusive page states: { inuse, offlining, offlined, free }. */ > +#define PGC_state PG_mask(3, 9) > +#define PGC_state_inuse PG_mask(0, 9) > +#define PGC_state_offlining PG_mask(1, 9) > +#define PGC_state_offlined PG_mask(2, 9) > +#define PGC_state_free PG_mask(3, 9) > +#define page_state_is(pg, st) (((pg)->count_info&PGC_state) == PGC_state_##st) > +/* Page is not reference counted */ > +#define _PGC_extra PG_shift(10) > +#define PGC_extra PG_mask(1, 10) > + > +/* Count of references to this frame. */ > +#define PGC_count_width PG_shift(10) > +#define PGC_count_mask ((1UL< + > +/* > + * Page needs to be scrubbed. Since this bit can only be set on a page that is > + * free (i.e. in PGC_state_free) we can reuse PGC_allocated bit. > + */ > +#define _PGC_need_scrub _PGC_allocated > +#define PGC_need_scrub PGC_allocated > + > +#define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) > +#define is_xen_heap_mfn(mfn) \ > + (mfn_valid(mfn) && is_xen_heap_page(mfn_to_page(mfn))) > + > +#define is_xen_fixed_mfn(mfn) \ > + ((mfn_to_maddr(mfn) >= virt_to_maddr(&_start)) && \ > + (mfn_to_maddr(mfn) <= virt_to_maddr((vaddr_t)_end - 1))) > + > +#define page_get_owner(_p) (_p)->v.inuse.domain > +#define page_set_owner(_p,_d) ((_p)->v.inuse.domain = (_d)) > + > +/* TODO: implement */ > +#define mfn_valid(mfn) ({ (void) (mfn); 0; }) > +#define max_page ((unsigned long )0) It's clear this is temporary, but it would still be nice if you could omit stray blanks. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/monitor.h > @@ -0,0 +1,48 @@ > +/* Derived from xen/arch/arm/include/asm/monitor.h */ > +#ifndef __ASM_PPC_MONITOR_H__ > +#define __ASM_PPC_MONITOR_H__ > + > +#include > + > +#include > +#include Judging from the contents of the file, you don't need either (and you certainly don't need public/domctl.h twice). Only xen/types.h looks to be needed right now. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/numa.h > @@ -0,0 +1,26 @@ > +#ifndef __ASM_PPC_NUMA_H__ > +#define __ASM_PPC_NUMA_H__ > + > +#include > +#include > + > +typedef uint8_t nodeid_t; > + > +/* Fake one node for now. See also node_online_map. */ > +#define cpu_to_node(cpu) 0 > +#define node_to_cpumask(node) (cpu_online_map) > + > +/* > + * TODO: make first_valid_mfn static when NUMA is supported on Arm, this > + * is required because the dummy helpers are using it. > + */ > +extern mfn_t first_valid_mfn; At least "Arm" wants replacing in the comment, I think. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/percpu.h > @@ -0,0 +1,26 @@ > +#ifndef __PPC_PERCPU_H__ > +#define __PPC_PERCPU_H__ > + > +#ifndef __ASSEMBLY__ > + > +#include Looks like nothing in the file requires this. > --- /dev/null > +++ b/xen/arch/ppc/include/asm/procarea.h > @@ -0,0 +1,38 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. SPDX again please (and there's at least one more below). > + * Copyright (C) IBM Corp. 2005 > + * > + * Authors: Hollis Blanchard > + */ > + > +#ifndef _ASM_PROCAREA_H_ > +#define _ASM_PROCAREA_H_ > + > +#include Again nothing looks to require this. > +struct vcpu; > +struct gdb_state; The later of these is unused below. The former is used, but in a way that would require a forward decl only in C++. > --- a/xen/arch/ppc/include/asm/processor.h > +++ b/xen/arch/ppc/include/asm/processor.h > @@ -110,6 +110,10 @@ > /* Macro to adjust thread priority for hardware multithreading */ > #define HMT_very_low() asm volatile ( "or %r31, %r31, %r31" ) > > +/* TODO: This isn't correct */ > +#define cpu_to_core(_cpu) (0) > +#define cpu_to_socket(_cpu) (0) As mentioned elsewhere, please try to avoid leading underscores in macro parameter names (or macro local variables, just to mention it again in this context). > @@ -175,6 +179,8 @@ static inline void noreturn die(void) > HMT_very_low(); > } > > +#define cpu_relax() asm volatile ( "or %r1, %r1, %r1; or %r2, %r2, %r2" ) Just like HMT_very_low() this could do with a comment explaining the "interesting" ORs (until such time when the assembler supports suitable mnemonics). > --- a/xen/arch/ppc/include/asm/regs.h > +++ b/xen/arch/ppc/include/asm/regs.h > @@ -23,6 +23,8 @@ > #ifndef _ASM_REG_DEFS_H_ > #define _ASM_REG_DEFS_H_ > > +#include > + > /* Special Purpose Registers */ > #define SPRN_VRSAVE 256 > #define SPRN_DSISR 18 Why would this #include be needed here all of the sudden? > --- a/xen/arch/ppc/include/asm/system.h > +++ b/xen/arch/ppc/include/asm/system.h > @@ -1,6 +1,247 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. > + * > + * Copyright (C) IBM Corp. 2005 > + * Copyright (C) Raptor Engineering LLC > + * > + * Authors: Jimi Xenidis > + * Shawn Anastasio > + */ > + > #ifndef _ASM_SYSTEM_H_ > #define _ASM_SYSTEM_H_ > > -#define smp_wmb() __asm__ __volatile__ ( "lwsync" : : : "memory" ) > +#include As mentioned before - any such #include you find is a leftover. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:15:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:15:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579494.907481 (Exim 4.92) (envelope-from ) id 1qTIoX-0007pR-Mt; Tue, 08 Aug 2023 09:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579494.907481; Tue, 08 Aug 2023 09:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIoX-0007pK-KF; Tue, 08 Aug 2023 09:15:41 +0000 Received: by outflank-mailman (input) for mailman id 579494; Tue, 08 Aug 2023 09:15:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIoW-0007pE-4a for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:15:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062f.outbound.protection.outlook.com [2a01:111:f400:fe0e::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2412213b-35cc-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 11:15:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB7569.eurprd04.prod.outlook.com (2603:10a6:20b:2d8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 09:15:37 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 09:15:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2412213b-35cc-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XFgj2Q5teOd/SEjVqTa3gxAE1iyQFUmIZi3D34sFbyiNgt09etjECYsidW2VG6iLqkWa1mM+Rd6bUeQLG9XEiEfNzztJ17x/8QrzOWV3K1DbjmFSnasXiUCAGUmlkP6xH087XsBgwlGKyr8wS/S1aIiyk0GOUB9o5xFEWKvlybZ/oW8hBfM8LFXP+GJSdDJeY6F7czw0JXXjuoDETB959kiMSN2iCFiR0N7gI3HrEUz/7plN5WfN/skaf1otvHO7LmowSWPpclQAbSaGeasvhVhAVoqdAOuG6YcSU1fcU/dFNyiMqMtzBlj4SubkIXSvuwz8k993G9YXRPetENCibw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VAsLA7s8Di76h+92NZz50JjD7JBHvWH9yNdvc7cCjz8=; b=dccA5Ypc4Ada+xCrFPSYF8h3VOwz7x5gcSL8y/9LGFR71b3Hz1OPPTXzzO0IXLsMazf282WE4NIa6RVlMio8q+uxkm17DrRC823IAnBvtqtlRY4AL2rs3kGLHUIuZCj1ck/PKPiYqmaWXViybMk/41P5Jm2OasLnuLn8GySJnscBWrBlwnkmWUIb4F9LK+HbL+RK84jui1ZJtgnyLylyPA3qcxY9tILi1PuBP7kvbP/EB5h+2fQXgCS6evzkMVYrMckOM1etN7WANlUgwfI9YyC0HkxHD1Fuafu7iB1DMvp/hdl1GxjJvS7K/CDhBnZBAvM0rQvPZyR4V9WuSznlrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VAsLA7s8Di76h+92NZz50JjD7JBHvWH9yNdvc7cCjz8=; b=jfhkr39V3FcA6qffqBUivCoGCMSdtEl2qSbxzNon5cfsb5r8wXMDHa6FOLjyiPwCLPDzXFdJIRM5qUtawg/wbZKBFn6zWKYmzO0bMvhodWXzmnAj/Kr5+F5tJr4togktqd2X518IVpWmyIk9AL+j2V4aFPJRNO57H9tKJkoWxsQhOtJ/tM9tyTkcVQ4EyPJYizKvJ32U9IRA7Y7nEUlsDrh2l2eABLy99cfbEJItQIgKRNkt4G9xBnEFfaPUwFi3Y3m0X22yAKag9Yb1F/BJrSFTNN8drN9psZTJkXrZC5/SWqc878t3ZI5VdMnYhOfFuT2f9PAnIlxFxdaaghcGWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 11:15:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v7 5/6] xen/riscv: introduce an implementation of macros from Content-Language: en-US To: Oleksii Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <9fdda7716faf412f1e2cdf9a990c98e64c4b21f3.1691063432.git.oleksii.kurochko@gmail.com> <8098e465-d25c-7fe4-dd97-2f44a689c9a6@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0097.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB7569:EE_ X-MS-Office365-Filtering-Correlation-Id: e7503ee0-32ee-4238-a2aa-08db97f006d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BWSjaSw5GlUvvwgNe6wrvxbhd3R8oQ1DxtWMQz+umbdzGHgDGdZF3rM7mMkxizY7ICCa8XTMbLcnoIPSXhNhC4Bwn0m8BPSYkK9ckMSJ5srQbjY8QQPuzvGqh5Ktl+zcXgCfmZz2L3f8VmDKZq+eXpMyjRO4vH+oEBA1ymvtqjyldAiqBZ0WjVZFKQ69+IIbeSYq2DLzlIHLUP8xIRj0Y2cYNwoVFBHRVD/xrdWUSpt5V98HG6s6KNBORa0nFWh/TxG7bVO/GLqyhOZNiTjLuG8CjO0orJpgSV/JRh/RkMsMaTTVV8aeVrEXGDapeg3Rr5ve1WlU6XtjAQVLN8QtC3R9Zlm5e2T7NnT7ktFHrhtpvqYsGjUzJXpBPb7GERJSbawPb5VBfDDHLm0OhYwpQD5Spt+4idW/bveTcpUyRzxFoYDAWa9qbhxYFxL7dc1GH5VrnRSsVr7IVkl7PZU1Srh/uONk2CcW9Q1pq7AB7g4pPZyXOpRTg1QBKvCvfC9Oa99hPyCKypGjmqMx8FaFt9UicFXoje/2LNB0kQDiUyft2dbGmxmQ7wh8TXaU4cLr+8Oq8wNojbOwFLOSHg34ubPkoqkp97vUFbGAhycNVNvpGReZQ84rbCu8125uzb2wFrikb0VfJb83XbTUXx5cxQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(376002)(396003)(136003)(346002)(186006)(1800799003)(451199021)(2616005)(478600001)(31686004)(6486002)(6512007)(53546011)(26005)(6506007)(66476007)(66946007)(41300700001)(66556008)(8936002)(316002)(8676002)(31696002)(2906002)(4326008)(6916009)(54906003)(36756003)(38100700002)(5660300002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3JGVkI0bW5UeElxeFhETm1jeGQzWEI3by9XVFBGSTlaU1QrVVpxTDlKRWd0?= =?utf-8?B?dXNvdXFidVlndVIyakgyMW1WMGhvelJkYlgvK3lnQm5Nb29rTlF2bjBTem53?= =?utf-8?B?OFkwZytjTGVJcHdMUStnalZsVmhvekxBOThhU2xFQms1TTNmenplMDRhZ3Ri?= =?utf-8?B?WXBTUFBuZlg5ZVFFeWJBUTZTN0kycGVEeEthbVFsUjMvZFJyY0J0em5Ta0Rs?= =?utf-8?B?SzRzNys2MEhaRStIL08vMHU5YkNGUGVGSDZncGJTOFVLL0ZUeHljWWNRK3ds?= =?utf-8?B?dWY4R1dYWXZUSEEzQytzL0pEcHpPYlZBUC96RlFhS3libTdicDV3YVd5ZGg0?= =?utf-8?B?NXNpTTVrM3hwcFNzZTdmeWJYTHNCUGR5Nmo0dm1tTzF6aHEybGQrelcvQ2xs?= =?utf-8?B?QXNCdFRUcHEyTzdIbktFd204OHErcUpZb3lYRGRnSFdzTitHdHRGT01saXpW?= =?utf-8?B?c3lKbUtKZHlDeitsZGp0WjFIVDNhamJ5aW9wM1NMbkJXQm1TRXBHMVNCL0ZY?= =?utf-8?B?Zm1FanBTTnpFcFg3K1NlYVg2YWFLclpIWmRJdzU5MUFEVjk2WWRCS0FNWjY2?= =?utf-8?B?Y2VoVFJWdFpMNW5YTmVacFBIdUt4RVF1VjhvSGdiQ1NYM1dHS1hpKzBLWW03?= =?utf-8?B?YWxNS3Q0TGtNeGV2MkJ1d0lqYyttRTdqQXN3Z3ZtYUVocnE3RlNVYUYyRUpD?= =?utf-8?B?cGZBSzlsZm5jS2tvOUhZMUdRYXBtM3A4SVJ3M0s0UWdFUSs3djl6QVFIVC9l?= =?utf-8?B?Rkd4bHdUbE1jbUtYSHpBUzlLZG80WVI5OGN5TnJZQWNoUy9hbTVBZkRpcGVs?= =?utf-8?B?SUp1MW9oRWJFQ2p0bmExQkdmNFFjZ3hEazdhK0ZuWm9TbzEzMmRGam5lRWNh?= =?utf-8?B?dXNlL25iR1krbSsxL0lYNHpXZXREV3NuVzJ5QU1HS0pXQi9ydXNWdVJsYTVw?= =?utf-8?B?VnI1eklzbjBpbzFaVWxiV3AxbmQ2ZlZML0w0UmYyZ2pteFFCUGVxNjl0ZUJB?= =?utf-8?B?OEwwb0hhY0MvTExlRmJlTEJqU3Zua1lwZDNCNTlLV25oSTU0Uys5b3g4N2xD?= =?utf-8?B?U3RtY3dEdkdINE5vdWtIQlhTSnU2RTRnQTJtTDRuY25ZNERtNFdtNVlSUis4?= =?utf-8?B?S1FIWkpiRUplVGVmUFpCa0M5T2pJdVI2TmdZUEQ2UHc2Vkc2STRBeXo5ZzlF?= =?utf-8?B?VFhQYkxaaHdkVmhvOW5EMkRjTm4rM3pLZTB5dGtRSVVDc0FEY3FsSHFTbUd6?= =?utf-8?B?aFdVWWVMS2hncUdOQkQ3aEJYdEY4T25qdmczSy9BbUdHNldFay9EZlUyc0ow?= =?utf-8?B?N0V6Y0ptamhVTlJtb3hXN1c4RXdpTk5wR050a1ZxQXBiZVJ4Vmhzbld6Z01i?= =?utf-8?B?TC8zc1Rnejg4TzJGcUppaUY1NS9zZ3p3QVhIL1pjN2N4VTB2Z1MyWWhqbVJ4?= =?utf-8?B?cDBiaVI4UnVleWlOZURtdDhnVlBNTWoyN3FPVE5GMHZNWU1YWmdJOThiZFg1?= =?utf-8?B?UHh2Uy84eTFiNkNsOHg2Z1BzeG9yVEhsVjl1Q1lNK0pwZkJBem5jR20vRVMr?= =?utf-8?B?Qkh2VjVFU0lNd2tGc2tIclNjSVJMTy9jZmFXWnB4cU9lUnlFUFBESlYvRzAz?= =?utf-8?B?UmtUSE9Vb2FHdGFjeFNveTYzZGJmTjN3YlBDY1hMdHVaVWt1UzhNR1RZVkQ4?= =?utf-8?B?VGpFTk5RaEtJZDV6bGJ5SVk1L0RId1ZXcGN0Vkk5a1hIQ3dKMzIzVlpUM3RK?= =?utf-8?B?UVNidUw5NXhPbTRrMzJjby9sRU9ZekdtdmExSzdiaXNFVnBNekFicDl0aXgx?= =?utf-8?B?QjQ3cEs5Q0RyM1F3cnhwWTdndVVkckRwanYvVDBYV2JIQk9hVkRieWlCQjRs?= =?utf-8?B?UEg1emlHdFIydG1OSURaaUdlTm9OalZtYlRtQ2J4KzQ4L3VZdjVSQ3dTRGFW?= =?utf-8?B?K0RpZmpsWGVjR0lacmVrSEdlTnBvTmxFSEJ3QjRjQ3dsUm8xTjJOQlRqc21u?= =?utf-8?B?aHVVUzlWRGZrQUpLeUxvUm9kdUVYaGJVdjgvd2dYZFFNbHN2dnZBVG00MDNP?= =?utf-8?B?VlBGcGRXQ2dtN05CTFViVnc5ZXoxaWdLQlRDclBWcVBSVkwyQXJqR1REeWE5?= =?utf-8?Q?0Nzz+ndpKMkLAIC7dPe5R33cU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7503ee0-32ee-4238-a2aa-08db97f006d2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 09:15:36.7155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: te0L94DG7tXF+zitKcyFfmF/VicctFiktXm3eKfWvCdR80h4hmNBBmZoCcYtmRmMrbO0vked7IjWsvBzAxHuYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7569 On 08.08.2023 10:48, Oleksii wrote: > On Mon, 2023-08-07 at 15:29 +0200, Jan Beulich wrote: >> On 03.08.2023 14:05, Oleksii Kurochko wrote: >>> +static uint32_t read_instr(unsigned long pc) >>> +{ >>> +    uint16_t instr16 = *(uint16_t *)pc; >>> + >>> +    if ( GET_INSN_LENGTH(instr16) == 2 ) >>> +        return (uint32_t)instr16; >> >> (I don't think this cast is needed.) >> >>> +    else >>> +        return *(uint32_t *)pc; >>> +} >> >> ... there still being a double read here, do you perhaps mean to >> make a statement (that this code isn't safe to use on guest code)? > I wonder if it'll be safe to read 16 bytes at a time then we won't have > double read ( if you meant that first 16 bytes are read twice ): > > static uint32_t read_instr(unsigned long pc) > { > uint16_t instr16 = *(uint16_t *)pc; > > if ( GET_INSN_LENGTH(instr16) == 2 ) > return (uint32_t)instr16; > else{ > // return *(uint32_t *)pc; > > uint16_t next_16 = *((uint16_t *)pc + 1); > return ((uint32_t)instr16 << sizeof(instr16)) + next_16; > } > } Whether this is safe for guest code depends further on what underlying mappings there are. Surely you can't simply cast a guest add (coming in as "unsigned long pc") to a hypervisor address. So as it stands the function can only ever be used on Xen code anyway. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:17:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579499.907492 (Exim 4.92) (envelope-from ) id 1qTIqJ-0008OY-2U; Tue, 08 Aug 2023 09:17:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579499.907492; Tue, 08 Aug 2023 09:17:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIqI-0008OR-Vw; Tue, 08 Aug 2023 09:17:30 +0000 Received: by outflank-mailman (input) for mailman id 579499; Tue, 08 Aug 2023 09:17:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIqH-0008Mh-DO for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:17:29 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7d00::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63835951-35cc-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 11:17:25 +0200 (CEST) Received: from DB8PR03CA0031.eurprd03.prod.outlook.com (2603:10a6:10:be::44) by PAVPR08MB8800.eurprd08.prod.outlook.com (2603:10a6:102:2fc::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 09:17:18 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::8) by DB8PR03CA0031.outlook.office365.com (2603:10a6:10:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26 via Frontend Transport; Tue, 8 Aug 2023 09:17:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Tue, 8 Aug 2023 09:17:18 +0000 Received: ("Tessian outbound e1fdbe8a48d3:v145"); Tue, 08 Aug 2023 09:17:18 +0000 Received: from 70315378e119.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B602DDDA-DD00-4B11-8F51-3FD7858C5C6A.1; Tue, 08 Aug 2023 09:17:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70315378e119.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Aug 2023 09:17:11 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB9450.eurprd08.prod.outlook.com (2603:10a6:20b:5ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 09:17:09 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 09:17:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63835951-35cc-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E5/6eynU8wmMfq8xlBDA/OlTx/dc1Cb3+eprC4tznHQ=; b=K6sXuaB9fMlU9P/vPaycLLG3tfP0ODwyU9ytesZd5x7pw5mB+R8FjfN3ugzuto8HgvAvSrOfBv5LqAfl/m3jhMadnte2IbkIX+3WxGR0iEJwkNPOZgirb5Hn6CpYeJQjcyxO4XDGsDLdC0dAceTtKi3XVwgbJqzGlam327fhj70= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 57074e8260c8fed5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QujDfSXr7iFeKvZDV3VuPnfMgzTyem3Kz/kBOiUBjR5ZFsWXog+P3KQbJmE9eNfOPjPehjro0ao/Nz2dLQpIvcIwz34Wccw5K6/Ml6rWEu3frLxzSs67oqwQU1j/3fUoG/EqCtEaVv85eJ2ezD1A849YLpG+cRx/Apuw8qC4YP3NFZsikmp27aIHELtiK6TiTdhXLuejdSX2FmxQ6cjB7vm2aPA8kAdVKJivR6L4uZUYPqXyfkCLA7mqxa7tXBQMjW3a9hpE48A3ipmpnqYrir4ZHfnElymd1ZzZtejmAvDv6anp+eU5nNfqI07//tbLDBWhcJ4U6DjC9/D+fXqOxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E5/6eynU8wmMfq8xlBDA/OlTx/dc1Cb3+eprC4tznHQ=; b=hK+D9Xis6ri/17kdX3VLqtblA1Qi7XB4+87X0fblcf1KFbluiSaKgsFOSX7QpY5VgFOqcPfU7rOCSJTsNI1KYWHGRAT3HfDAPK/YRKEVkL2ICQUHPoQtUgCioTfO6UrVUpSD2Llf0UluBluS+dA07CVQXG2QiW0plkyLz+9L5fn+/dCp1mLCG0v1CfaH6nyfcBR9M4OhiEGb5jo/rE6A+FraEv6fljHUDzkJ491jgD6f1hpZVV8+p+MBsvQBMHdMo/A0ST7peSdsQDV4xImU4N5mjGcDqcDwlsAXxzNpvwEUw11nzMOfx0fihVZ3fJSmmqgK5fjulIdo1iU8NzPUSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E5/6eynU8wmMfq8xlBDA/OlTx/dc1Cb3+eprC4tznHQ=; b=K6sXuaB9fMlU9P/vPaycLLG3tfP0ODwyU9ytesZd5x7pw5mB+R8FjfN3ugzuto8HgvAvSrOfBv5LqAfl/m3jhMadnte2IbkIX+3WxGR0iEJwkNPOZgirb5Hn6CpYeJQjcyxO4XDGsDLdC0dAceTtKi3XVwgbJqzGlam327fhj70= From: Luca Fancellu To: Michal Orzel CC: "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH] automation: Fix missing smoke.serial in artifacts of qemu arm32 jobs Thread-Topic: [PATCH] automation: Fix missing smoke.serial in artifacts of qemu arm32 jobs Thread-Index: AQHZydWPumMM9UHF6EKOWcKXws4Tpq/gHn4A Date: Tue, 8 Aug 2023 09:17:09 +0000 Message-ID: <7B3BFA6D-5BC3-4ECA-B897-07996D0E9883@arm.com> References: <20230808085059.13112-1-michal.orzel@amd.com> In-Reply-To: <20230808085059.13112-1-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB9450:EE_|DBAEUR03FT032:EE_|PAVPR08MB8800:EE_ X-MS-Office365-Filtering-Correlation-Id: 504d4e92-f0f1-48c6-9ecb-08db97f04360 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KSD1s7qg+HFnmfyunMXzHqOSdfmc6SnQG8jsN9lS0yVZdus6zmIVHsCnb+/75FlMF/X8TdnU2p6UW0IZgXkMVF4p1cYLUAOg4cSPSAvr7rAjXfr8s8CcbkH2WDoIL4XsAoNMnsHqafn/mkWa46LMtnQY8ZNo1CCHSQjUryXsuGR1NS4bhpBKujUBpBtBRjOCZueT/Ke+jUwImPVpo6rDuiE9dTOmpRa9EKLGDryflG4ji8nbRXmNPewyedPVxr/iS4OyWvdAEOnUcn2/AH49LeATdRZ6R5G7d1W0hffVZtKMRO2aAQw7ZCTi/TTk+SiKyeJVr9bWIG7HATvqlDCve6CnFiEccR8ZtzJ6XOvvaYBWc6/2OfdkTDlCDzpL0Sh419nVa0hGHPn8Ugf5YbpjdItPU+y5ZNYdnFdSkJznP10lZ/+mJOTfm0vyWUsSusvdVsLuESQnPa5xDwmWigPYXD11zh6xY1ILzJHF9fLUwnaAoluo48TKBWHKw/gNHy1ZsJrY3wqjADFLS6OeQkd4kG49nfTHH3qDLriGh/lYMSQq3mqhPCGd3ApRjtaNNzcn0tR7QJFoGm5pg/Hpvxq4qGShhvsR2JRKvv1DjUI6VdY5WqguUiDFGqgSDXaXOaKjdtXy/OF+pDNVyEh+grK19A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(346002)(376002)(136003)(451199021)(186006)(1800799003)(36756003)(2906002)(5660300002)(4744005)(2616005)(71200400001)(38070700005)(54906003)(38100700002)(6486002)(91956017)(76116006)(64756008)(66446008)(66556008)(66476007)(6916009)(66946007)(33656002)(6512007)(122000001)(4326008)(316002)(41300700001)(86362001)(8676002)(8936002)(26005)(6506007)(53546011)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <71E197C55DB29D4491D492453A2465DF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9450 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c857708-d677-4c67-8ada-08db97f03e68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0PqAK3LpAMPH1PbcSqRJLB7KswDW/EaQLTZFV5wDfM96CGyNg+QdRZ5S5vOQwVxxzTJY8epR50kGxjVBigjqr+gx8GE3g6hZRRPqljbDkMYJEfaP3s5kDKblhFSJRaO4J2p2O6VQAqXBeJRE1WMLfivCUE4tIdHi7KeH9d8s0AcQsN6fJ5Pg3kzkSZgiY2F63HO9OpLkAd//Jj9bI7iKUY2SicfPJh1YeoZr/niQ2HejsAZ8jyWP15X5ZZwQh2XMF9XWxs+DN9z+apXg7+So+gSVSvxNHP50K/IyVyb0w9v7dn78om5gXZrowm2oMxeA4pKJwcGVLnqFBvOULsdrKu5zsat5ksvoGBd6mLa9JZAu3S+9kxAmDwaLm4N7rBkg12WoqR7SPRd4mG5NRGP/KXcYJXuxvTUV9CpyHEKBTvEgLYPYmIUFXQIt2I/k2OCDGMyz3hozkazLTsYHC4PP3ul1y3OfKkxCeCPgZxS2BCJNqsxiDejzJVGkQ0oZO495CcNzZSXZA1c5DNWvD7C5TplQzGW592SGfGotfE+Ru4/+7+Ycu1OuVoqoDD1dQTrl2Z1EE4KAr2qGyEzfO95Po4WkUrWqJHbsHV9CDuFrMfXv2fEBIg1ryVkSdBg1qYlz6jF5VntaZGuOc1kUEBaURhr1vi3Pf+BEMCIED73wvbzqSPkVDv6xwQGFiRP+JCX1lYDUWCZsUqRPjEEn2ujqH3zrplP8xpMpGz9V5rbqJcwK1TeoS3Z8PB6G5dJfOpxA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(39860400002)(136003)(1800799003)(186006)(451199021)(82310400008)(36840700001)(40470700004)(46966006)(70206006)(36756003)(4326008)(2906002)(478600001)(70586007)(8936002)(8676002)(6862004)(5660300002)(41300700001)(40460700003)(316002)(36860700001)(4744005)(40480700001)(54906003)(33656002)(6486002)(82740400003)(356005)(81166007)(6512007)(6506007)(2616005)(26005)(53546011)(336012)(107886003)(47076005)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 09:17:18.1407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 504d4e92-f0f1-48c6-9ecb-08db97f04360 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8800 > On 8 Aug 2023, at 09:50, Michal Orzel wrote: >=20 > It was observed that smoke.serial file (used to store boot logs) is > missing in artifacts of qemu based arm32 jobs. This is because the > artifacts:paths listing smoke.serial specifies paths relative to the > project directory but the qemu-smoke-dom0{less}-arm32.sh scripts create > this file under binaries/. Fix it so that smoke.serial gets created in > project directory just like for every other test job. >=20 > Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:20:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:20:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579505.907503 (Exim 4.92) (envelope-from ) id 1qTIsl-0000wz-Hw; Tue, 08 Aug 2023 09:20:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579505.907503; Tue, 08 Aug 2023 09:20:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIsl-0000wS-DH; Tue, 08 Aug 2023 09:20:03 +0000 Received: by outflank-mailman (input) for mailman id 579505; Tue, 08 Aug 2023 09:20:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTIsk-0000hK-Cp for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:20:02 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20623.outbound.protection.outlook.com [2a01:111:f400:7e1a::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf52cd76-35cc-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 11:19:59 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8887.eurprd04.prod.outlook.com (2603:10a6:10:2e2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.22; Tue, 8 Aug 2023 09:19:58 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 09:19:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf52cd76-35cc-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzRSsHT3A88ZYnQzzid4kJZR61AJt04pxrTLD+XLdHR37eFkUsKSGB+ctPTmgqwrE3fpbp7vqawJXfqA1nd1is7CNF3ZIuUqrdqsHsTGZqSixXplZ1A1l6CFvH4YlUMo92TL9/O4EH7nUCdw63udjzKI50kJzR0BC0maz+akn+NiFONfpD4jWMECLLXjcANKuka+QkNvq3WIqP9ZeGl6VeCwwMXu7lh3jxT+uadDW1I2Juva16uNqK2AuuflJ3KrU56jj9yGY+msVQk2CfFe59zo7IziG5JZwimZdCAKKGBAtRPbek+hKyevKtpn4EZwic1BnsqIEH2sNvFw7lm8Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2kX3Jb1H36shYj6GK+7YjzVzxy2ryONoD+u91GGcdpM=; b=djFiDYo7/lbPmP9JX1WhtnLG3xpgP/MO7zaoyaCCQOhEFp++5JgiMAnkPSCslnsCUqYPIz4lsNEmYahBJZxZXolqjQ7PEa0LhFTMvSjyOPGCsvt+o9SNymQO8526dr0KVaUfab8vj+YKu2zPQseDFLH+TNVfKCOHyVIr9gR7RR762samogvYsjHolpzNyF5YVfCaRbLViQcoPUVUsDDmWzXxhs/py+/1nM3c6Aow3vy3SJJPHebqd1Kyk4ZwsRKSK7HyqxtK8H56feSjCWVj8GCY3wnmLqIF3/g5vbyS1zowHGiqrZzszbEjq2CF2FlcRooMfKs8Xlb0YJapGP+Ptg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2kX3Jb1H36shYj6GK+7YjzVzxy2ryONoD+u91GGcdpM=; b=Z8uuGm8sxBIvufyXdDhEEDF1dW5UvwSpq1fDyZOjkFyZ9UN9vYnBoAzNx01XB8cbBs+6ASsn4fw9Lv5b34I+lh4xWXf9y+/TOWuoOcQbPXQ9IeTMt4iWYW8qkAJE5cuwAugb0zjRTCE0ZebILti4Sv9yuCAKTuWEL6YoZgWZJmZyfb/HUbohKR6vlkwI3MA3Ubkui+VnWeYS3wma9ZRNU/qjvJKbZmn4m37ujM5otePv/3/ebWM1tJTMfTqz52vPDodVar1R+Xs57fER6A4gLF2rqbJFKNirzjHWgfkNb23q7MRN50tAlnqr/0ChpLZx0lEEhoCU5lwfT3FIP4DN5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> Date: Tue, 8 Aug 2023 11:19:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: MISRA violations in hypercall-defs Content-Language: en-US To: Federico Serafini Cc: jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Stefano Stabellini , Xen-devel References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> From: Jan Beulich In-Reply-To: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8887:EE_ X-MS-Office365-Filtering-Correlation-Id: 8462c055-604f-43f1-47c0-08db97f0a2b0 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mEukfATbTrjU/12pmu+izgqg0VhyhcdLZOGcw+8vx86+NtF/AOvIi1dPnD3YTVKk4loZN7BvpQBO7VwvgqlcRBw1IRWH6V6lVEUodCPXnixcEU388VMoA4BLyc2Rft0kTWmHTMX0PVtlF6OfCnA3ci9zO+sO6jdEzfC+UovgwfDhrcbx6SfWojNjJdMVw1VDO84Qx9RlK6W2tVzOG5zLenTP6huaVvw5b37ipiE6+aViFeipWyYYhAwLsSvl7kmDGu1J+IiYgrgHNxU2AIbJW4b1ZAaKE2vaxny3tXD1e053eeRtQvWhPx87vligoP6IWIwkrMjcwOWHqLvaMwDKLBYkA+f9h2w1iFwbuaE2tjP7iy0IK8dymkYhysVoXCAzlvQKCVI8a25Rs7K/SHR5IlOMVUjGRuJuZzehfY+R4vhxIysDfKQdKYgRW19zNuKR4vRpuEJMSLJOEoK27DvEDTbn7mX6tawPEzmg9YdZX1j8xf2yh+mU3fGx8J0+P9M0BlxMLj7gLvtmHanc1ynckuTbJshkrlLaxtl3tmY1bPQBSy/DIa2wnYYu73g13l3/2rZ1fiIcdxRvsF3pQBvBWNBbFA0SAzfD015sYFPO1nlQqmhmi4QYj7gcURlf2gVnOGRb5yrSGDIhk91WTFZwiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(1800799003)(186006)(451199021)(66574015)(41300700001)(26005)(2906002)(31686004)(5660300002)(8676002)(8936002)(2616005)(6916009)(86362001)(316002)(53546011)(6506007)(31696002)(54906003)(38100700002)(478600001)(6486002)(66476007)(66556008)(6666004)(66946007)(6512007)(966005)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWt2SkdaQjhMTlQ0V29jdk0vVE5Dd2ZPaHpoWStMRkhHZXdTdVhpNE1haW11?= =?utf-8?B?bnlMcytJamhNNDAxVk1CMmJ0Y0MwS1ZQQjB5eWpoek1YVjJTV0tvejNTWFJw?= =?utf-8?B?SmlkMUw4eFRYMzdybEVFWGJjTDVFUUkvMENadm5VVzdEcjhNNDlVMXNnQ3V2?= =?utf-8?B?MVhVREdiU2drNE0yTmdVRUZsVk82Y0N1MWFWdGFKRWFkTHlGZG5HelY0MG54?= =?utf-8?B?T3Z2UGZpRmR6a0dBSG42Z0hNenhhSURFUXVWQ0hpM25XZ04wdk5LcFgwNUk3?= =?utf-8?B?R3pDRWhOUHBzS1A4MHJPblNFbk13RENGTVQweURncnBMeDV1UmN4Y1ZhU0VN?= =?utf-8?B?ZFc5MDVIU3NjMTkvMjdSN0h5YU4rMVpGdkRkaTdXZ01IbUczN0VWOXBxMjgz?= =?utf-8?B?eXMwRUE1aUd5TXFkV3pxYUhWNXgyQXZFdzc2U0NOYUwrZHRzVUZrUWhjUzYy?= =?utf-8?B?TUN2dzlzNU04eUQrMUJYUmFwN0pwOFhVc0RuSUZ0S3BTcDFSK2NLWS94WWpN?= =?utf-8?B?anV1clVnZEpwYkZ4Skw1bmxobnErZ1FPZ3o0Kzk3cnFOZFU5MzBSRHNhYjUz?= =?utf-8?B?T3lWK3JWK2paVVlLYmxRVkltN1hxUHppVlkzRjMwK2tteFhXTkNFdmhEbXRx?= =?utf-8?B?THl0bkZZL2NpcFo1UnhDSVdsT0xMVW1ZY0VBbFhlWURlSEJLSnluWDlaQkww?= =?utf-8?B?ZGswdlIwdzFxTWl5ZjVBN3VHWTFTa3N6QjBSWGMxMmEwT0k0VzBiK3VsZUNs?= =?utf-8?B?aHkvS2dobDRIaTZyUjlVTzNGWjlyc2dEWWwrUUZzWC9CdmtjeFdIUTRLMm9E?= =?utf-8?B?enFsK3hOZFBaY1hHa1VnT3R1WnlrODVpZzdONVNDd21aSGk3cnRFN1ZkS1Zk?= =?utf-8?B?Y0FBY0ZrWGlsSzVKT05MdysyaEEyS2F4SVQ5T2EwV1RReTk1LzdzOWVJMVlL?= =?utf-8?B?Zjd0b2JCR0ZreFlOZ0VUcVlZN0pUc1VoRWcxay9EYWI4MXJvWS9rTm16bWZi?= =?utf-8?B?Q1NESys1YUpNN3ExTmRvUW4yQ1F0V0plbThnU2lUSDFsKzcwcU1xbXUxR24v?= =?utf-8?B?djIrODA1M3VUcWhaOUVaVThxKzNqT2oxUkIwV0FuMWw1ZlNIb2x5RkE3U1Mx?= =?utf-8?B?Y0ZrSDRPSFErRnJyZ05aencwNi9aSkZxT28xMFZPemE3bUIvbURSOVJVd290?= =?utf-8?B?d2R5T3lIUEh6UUQ4dllXRENyelJhTkFuUzlqRnAvTG52cXA4WWk5KzVQSmJN?= =?utf-8?B?Z3lvT0VqSVU1aXRuNFFyS2U3NWh0YTc5MTQyRFgxZDlLWWJ1UTc5ZzYyR2hT?= =?utf-8?B?TjlUZCsvY2JhSkJPcGQybDl3Tkw4RkcxNjFBREhXMDlQYVZrK2pEMGxXckFV?= =?utf-8?B?bmU1bUpNM1o0VG9wYm81Yy9GNC9tWnpiUTdvMmZnSTVXL25tMFFqWUNhcVZW?= =?utf-8?B?T3JQMzkzVjcyd3RUUEJuK3ZROEk0Tk9QeTRCNDNYem5mNHhYTkdJRmxKanBN?= =?utf-8?B?WlJXYjVkbE5VVUsxU05ZSExCaElPMzJYbzFzdmw3NGZxaHAvbER1SnR2RWhR?= =?utf-8?B?c0Qzb1QwLzJndkZ6NTJQTC9MRnRsclV6d2hQTXJnMDBaQUhLVVJzS3lYRlJG?= =?utf-8?B?S1gvSVRvQWVtQzIyS1JuSmErdk9Qck13MTIwQzVOU1pzRHJwNitPQ1kwamxa?= =?utf-8?B?b1BkQ2gvaGdrYU5FSEptMWt1ME5DenMrQmEra1NXMURqWFR2dE9QbHNOaDg3?= =?utf-8?B?a0xvUXkyaFZkc3ZEVERuUkQ4NWwvOG9LR2ZSZDgwUjdGMk1VSG02Z1d0NVpB?= =?utf-8?B?UnR6TTUwWTJOVmVNOGFURXVwT1pYZDlhZDQrR0p1dGNvQVh2M1l5djAraDNh?= =?utf-8?B?YThEMlJER2o2cmdPUHFGaFNIa3JGa09SeXc5elFMajFvK3R5TGswNmNaanJW?= =?utf-8?B?MmJaQTEyR2hjRmhMYVVTNCtLcHlSZGNsa0xjeDhlQXpNNzdsL213Z1VYNjVF?= =?utf-8?B?eFprT2pBVlV6UVVlYXdxZFUyQ3JyL3FlSWh3ZVRvWVEybUJyZ1h6bkFRV2VH?= =?utf-8?B?Z0NmaWRmL1Fac25XWWVucmViYmtVUzBTOTYwYW4vcXQxVHNHY2pKUGk1N01F?= =?utf-8?Q?FkKFax5dQQ4IYmRUYCbDo3xsA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8462c055-604f-43f1-47c0-08db97f0a2b0 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 09:19:58.1750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZRhIx5urfCQyRmrCAcSG1vm1syoXuNdSrikwXOZ9ZE6Uy1Ng7yL3+9oNXGG4q/1QQgFRzhH2J8jauQPbVlDymw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8887 On 08.08.2023 10:47, Federico Serafini wrote: > Hello everyone. > > I would like to to ask your opinion about the auto-generated file > xen/include/xen/hypercall-defs.h which contains some violations of > MISRA C:2012 Rule 8.3: > "All declarations of an object or function shall use the same names and > type qualifiers". > > Such violations can be seen at the following links > (copy and paste the link on you browser, including also the characters > after the '#'): > > - arm > https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} > > - x86 > https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} > > Some of the violations are due to mismatches on the return types > and the use of `ret_t`. We already said that ret_t will need deviating. For parameter names it ought to be possible to suitably rename, like done elsewhere. Whether that means renaming in the generator script or in the definitions likely again needs judging on a case-by-case basis. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:43:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:43:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579513.907512 (Exim 4.92) (envelope-from ) id 1qTJF1-0003wu-Df; Tue, 08 Aug 2023 09:43:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579513.907512; Tue, 08 Aug 2023 09:43:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJF1-0003wn-AQ; Tue, 08 Aug 2023 09:43:03 +0000 Received: by outflank-mailman (input) for mailman id 579513; Tue, 08 Aug 2023 09:43:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJEz-0003we-Sy for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:43:01 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20627.outbound.protection.outlook.com [2a01:111:f400:7eaf::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f564ded8-35cf-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 11:42:59 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8446.eurprd04.prod.outlook.com (2603:10a6:10:2ce::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 09:42:57 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 09:42:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f564ded8-35cf-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPXeyOsLZliMptjjZeeTGURCav9pRAq9yWEBq9BFhgmIJElUJc9BpqPbkJ/I2WWVC+QKHXQugHBHo0yWXLsVHnnJgW7YFuT+73cXKnGX8umeLz8xp1N7RElM2zhIf/33x9mgcq/93Ig/pZr6jKqpJlFouqbO/g0i0qrgUMfj11kOiuomnEQbdG98OcKAui/SXbSHrHQfQa7uZDT5N7aCy4NRdflGbEkkMvLy/grB7wm+0wLLqbW0SadWq3xIgTjHAcLoLNJPGmor9rnoxyVh5ucnsewDIVR1XUD6ecrXnFBJfVJCOnZyrcZh48yTxb3SbCHnVcPQIgnA+bHXqzTIJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k294eyeSeuiB2Xr7E798WNtAaFEAoAWoNZteqPxNH5c=; b=Vp4LkRnSI2ZLLZllY6dNSiwLiDvkyRzSx94bPnW6i68QN8dVFOgtnrgWBdT71pBtE0ZAolU589qem5sdYiqlG45cIs6CFZG7NaISsIkEl5wP9RaYy0bq5NKBKBG92jAIGRWH85otpeCCs0v/fE9x4jWmxHYLAz7bisuEmTIr9gWIJbnBCcFsTK9cBSsdtD2PCPTGosFAxtf1bMH+n3BH5maRCB9MZoftFS4y2QloHiddty48qFHOJ8gH0H4/mXatxQr1FCETIbA+lmdKPzwubZb4JafNP//Z6qQqS3VxlgQTHKMY7i4dOYZWxADgY0lhgjmhHXukNauRwQVuzURoUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k294eyeSeuiB2Xr7E798WNtAaFEAoAWoNZteqPxNH5c=; b=LvrBKXUva837NtaMuSUuUEKsUcuQXcqqjzrNsnQw1FklZP3jk2gsRaE4PAeXt+6nG9QgqF9i3xPlB5M1ycDkExi9JqafBn9MVxYylICsNm+WKgXwvC5whbNPxlvyoBFl9mvTgqpAXQ3CJb6xts9/id2WvrWATjIg476DDCJdpwYfryRPjGd0nTQzjbX2PUSEGd69RA295eF7rTHualUWzOiCC+xFm/8LvPVZcNe1h+As/ORHG2KlVciPdSuvItM+1TyOjmM1I/Ex4PdqIH5GYAzkmVjP/UADJcqCrfdjkBy5g3cyJy/NpB2sHfnsObxpfDawqIbtssfRj+LCDQRLgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1ea0cd2e-1821-541d-068f-a18309d1823c@suse.com> Date: Tue, 8 Aug 2023 11:42:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio From: Jan Beulich Subject: [PATCH] common: asm/desc.h is an x86-only header Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8446:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b51bdc6-18fe-4c32-1d02-08db97f3d8c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oYClyM64+2U6YcM1VUd3uitq2aXhx8+pr42+7aw4OQq0EbiHvd01arkiOeZYnp5QrgjD48iVT3VdJHNpPf7KcT5c3XZqKNYjzb7H/UYlbnYSsuH3PVdtjozQbAwrzM1BuR+N52QyJtSA3ZBP2U3DMuljmXkEggR110e0pPPiDKuCdepWZqa53FApN9FR62vn1vf+FkvO1t6+54K4BcS+dVFtGBqRV+nYEn1oDmNqigZ+BW77q51jt8v+7JQQVLZaQGKRBsNKIiD9fkYM6enU5tLK0NYRbWYRtoyafDZmQOolbUKQ7viJKDy+gjYxnkpsn7aPKRVzY2b82bUH36OEN1qNglWHeN/073rdIEy1Tvf0E/4u2Tda3XPWRF+q7G1k3f+K5rGVks3CAoUI9rgM/JY0QP1wIOljlErSrnhV12D7DW2KjsSKxdDB558n2o8h+SmQfuWu3sxR5ty7xGLd8oJNsqN8kURpXp+L7lpPiil/pOd5nnPaD5f5f/m89ImsAkYWAMhbbcsDIYhMSG7/a8zUYzBKG5lVqodRRF7EgLKWNvjqFPF7HbhUilvKw7YbOF13kz+Si5hEdBKYzaEADfhCtH2V+0XEshDNY4H+4SRKoK7gti6r6XrtarniHiHRGWuZTy7llt+CZ1P6E1uUyQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(366004)(346002)(136003)(39860400002)(451199021)(186006)(1800799003)(8676002)(8936002)(5660300002)(4326008)(6916009)(41300700001)(316002)(83380400001)(86362001)(31696002)(4744005)(2906002)(6512007)(6486002)(2616005)(6506007)(26005)(36756003)(66946007)(66476007)(66556008)(478600001)(31686004)(54906003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEk2eVZpMzVBRU1TQy9DK3dyd3VXaEJvNUxoSXlUazA3WVhudjJud2ZubFgz?= =?utf-8?B?My9yeDdhMFRSOE9tNG9tRlJBaS9sMnQvdk1zWENNRWlZV1ZTVUNhcC9BQXRR?= =?utf-8?B?eDlHKzJKbEQ0Y2d6ZzBORXBTdWM3MWE0THQvNFlWSXcvU0FEMUE5bEpxVENy?= =?utf-8?B?TXpKN3NLNURVVHRoVHlsamFTeEo0MVc3M3lyNDdvK3JLTlpnNURIaEF1Rkh5?= =?utf-8?B?SlRxcXd5aVNDV0xua2UrdXZLOEgvNjRqdEY4eTJyT21UWXo5cnNCSlpTdUx0?= =?utf-8?B?NEdSRVNNc2ozN3ByRy9wN0J4V21pY2JTbmNZZG5GdkZXOFplejZsd29heVVs?= =?utf-8?B?ZTlja3hDTk8wbHZmNTJzdk9vWWNkSFpQaWhhc3RPZmluZkxtZTNCektCYWU1?= =?utf-8?B?SHlrL2kvR1JqQkl6Q2dqV3NJcjZXSWM2ejVFMkRTTUFrbEtzaW1XREtuS25l?= =?utf-8?B?RWQyNk9YUEU2SGNndDMyN2xLcC9teXJkL2l5RGNxdmhxTzVLREh1T2RqTFZp?= =?utf-8?B?S252WkF2S3EvRzB2YnV4T3Ayd2thQWJyOVNXUng4cTduaXE2NXE4dVNKaGM0?= =?utf-8?B?TllqWWRQUjdsdVM5VmdKbG9OZWprRU1rdHZxTWJrYVBuV3UzZUZoa0x0T1pl?= =?utf-8?B?UkJHelpUZmw3eGdXbFJ4eDVDRmxSU0lOWkxxRFVTaEFoUXZMbTlDdlF3SDVQ?= =?utf-8?B?N3JCdnc5YzFLbEQ3KzV1TlVNMFZmT25Ya0JMWFJhT3RWVWxKdzNEVTBsaDI4?= =?utf-8?B?RHBmS0xOb25LbmI1dmxGRXcwTnRLTG5oUHhsNVNxVWhEMm9TY2ZOcmV5cXlD?= =?utf-8?B?bE0zOVRjUW1pZDVKN3RxUEs5enVLd1BVRnhraUV6K3hydng4VURPNHhITVdi?= =?utf-8?B?ZldCSmFCUW40eUdlWEJ4MGVvZCtBVEw0RnBaN0ppT2dnR0lJU09jN0I4MEgr?= =?utf-8?B?cDZ3V0xQY3Z3RC84UlBTVXp3TWVkVnFSMG5yVlg2bWxYaWRaeFdtZWJzRXZN?= =?utf-8?B?RHpRK2xZSWNQVDBibkhzOXZJbTNvWG9XNnR5RHQvWEV3S0JUaEZhdmFiK3Fl?= =?utf-8?B?d3g3dkdYODJ6OXl0clhrMHdlbFdKV2o0RWNZeWk3Ritld0UxRkdqWDVtT1NJ?= =?utf-8?B?VWxGeEJmbVQ2QkcvcHpCRHlmMjdVUjZSUEhFUkY5c1BIMVloa214VDUxZ1Rr?= =?utf-8?B?ZWdmMllURWtWNDgraCt6V0hyTzM5ZW85NXFNa2VVTWlhOHdUUjVrYUZaemJy?= =?utf-8?B?TVM4ZExqNnRycVRqcWoyYk9WSGtoYjZDT05NWk5XQUE2Y2g0K1FJVjlmeGJM?= =?utf-8?B?eDFRSTdRcUs3V1k0Uk83OTdXUE9yeUpYbTBpK2J5VFBqU3pjaHlhQmpRb3JW?= =?utf-8?B?WVYzSmgvbCtITTRrM3EyZVE1cDMxdVE4UEZTZ2dCQjhCMkorbmxpYVAvVEN2?= =?utf-8?B?emo4Mk5NMmdDdWpiaGc1ZHUzdHlQQnF0S25EUEJxVU9kMlk4bWZ3aHAycSt6?= =?utf-8?B?RlRIN294V0MyUE1ZeHhmWVBrajAvdlZPUHUyMWp5UkYvN0EwMlJWeUdrM2o2?= =?utf-8?B?L0xUZ0FzbVdhSlBoaUJSNXlnZGlDNlcwUk5lZE9nTVBROVYvd3dYSkxMWUIv?= =?utf-8?B?LzlSeVBaaWVwbk1pSkxCcU1oQjQ4TThwdzVBbVpJcXF6MnRVMlFna05OMERx?= =?utf-8?B?b1ZZYnpoK0ZzVmZjWFpWK1JORXZleWwyMVp4SHdhMnBOd1VCVkMwQ3FVVFRB?= =?utf-8?B?STFydm5MTUxtSEFhbnJtVEFOKzhuWUM3d3kyRmtQdUJxVEpjZ0dhVE1iaHRj?= =?utf-8?B?OUJQK1RHL1d2RjJuT2pIS2F1NGV5bTFBZUJSVDBpOHZBbW9CWGY1UnZGMWg1?= =?utf-8?B?Sld4aHNJQjNJQ0VHRWVhdU95R2ZUeDdaUVJmZUc1aUFOZXdodklqZnpuYnB2?= =?utf-8?B?bHhhZk5WZk1sZnZNU2ZJVndMTTU1UUhhZG4yNVJxSExuYlVCY3J2RmpRWncx?= =?utf-8?B?eFpQSk40ZVY3bnMycTJrd3MzclhYT1NtL1Q3bEpFQ2xlanRyYmZxTlBpRVN1?= =?utf-8?B?SGtHRmRpUW11eHdnUkRkZ2g4bHhOcThQcEpZcEx5TFBhclVBZ3lmdE81b0RZ?= =?utf-8?Q?tSlgPbJ1v7z9XLdi5KrhdtLZa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b51bdc6-18fe-4c32-1d02-08db97f3d8c9 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 09:42:57.4311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TVWPT2ZUeH5KoTnOoTJZpd3Ajo/olGy6LJh3G4JIVfjXToJ/mvo+vd4ugW7n31HxexZMxVhJHrcqRoX/OnNrMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8446 >From briefly going over 9062553a0dc1 it looks like the #include in what was ac_timer.c was added there for no reason. It's unneeded now in any event, and it is the sole reason for Arm to have that dummy header. Purge that, thus avoiding PPC to also gain one. Signed-off-by: Jan Beulich --- a/xen/arch/arm/include/asm/desc.h +++ /dev/null @@ -1,12 +0,0 @@ -#ifndef __ARCH_DESC_H -#define __ARCH_DESC_H - -#endif /* __ARCH_DESC_H */ -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * indent-tabs-mode: nil - * End: - */ --- a/xen/common/timer.c +++ b/xen/common/timer.c @@ -22,7 +22,6 @@ #include #include #include -#include #include /* We program the time hardware this far behind the closest deadline. */ From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:46:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:46:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579518.907522 (Exim 4.92) (envelope-from ) id 1qTJI8-0004Xf-Sw; Tue, 08 Aug 2023 09:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579518.907522; Tue, 08 Aug 2023 09:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJI8-0004XY-PR; Tue, 08 Aug 2023 09:46:16 +0000 Received: by outflank-mailman (input) for mailman id 579518; Tue, 08 Aug 2023 09:46:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJI7-0004XQ-W6 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:46:15 +0000 Received: from ppsw-41.srv.uis.cam.ac.uk (ppsw-41.srv.uis.cam.ac.uk [131.111.8.141]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69e3550f-35d0-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 11:46:14 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:54378) by ppsw-41.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25) with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1qTJHu-009IcP-aQ (Exim 4.96) (return-path ); Tue, 08 Aug 2023 10:46:02 +0100 Received: from [10.80.67.25] (default-46-102-197-194.interdsl.co.uk [46.102.197.194]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id D63AB1FC27; Tue, 8 Aug 2023 10:46:01 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69e3550f-35d0-11ee-b280-6b7b168915f2 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <77a9f66f-6535-e64c-6022-8de62b405f64@srcf.net> Date: Tue, 8 Aug 2023 10:46:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] common: asm/desc.h is an x86-only header Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio , Oleksii Kurochko References: <1ea0cd2e-1821-541d-068f-a18309d1823c@suse.com> From: Andrew Cooper In-Reply-To: <1ea0cd2e-1821-541d-068f-a18309d1823c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08/08/2023 10:42 am, Jan Beulich wrote: > From briefly going over 9062553a0dc1 it looks like the #include in what > was ac_timer.c was added there for no reason. It's unneeded now in any > event, and it is the sole reason for Arm to have that dummy header. > Purge that, thus avoiding PPC to also gain one. And RISC-V too. > Signed-off-by: Jan Beulich I'd noticed this too, and was wondering why it had escaped into common code.  Good riddance. Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:46:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:46:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579519.907531 (Exim 4.92) (envelope-from ) id 1qTJIL-0004qc-4A; Tue, 08 Aug 2023 09:46:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579519.907531; Tue, 08 Aug 2023 09:46:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJIL-0004qT-1A; Tue, 08 Aug 2023 09:46:29 +0000 Received: by outflank-mailman (input) for mailman id 579519; Tue, 08 Aug 2023 09:46:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJIK-0004XQ-21 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:46:28 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062e.outbound.protection.outlook.com [2a01:111:f400:7eaf::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7199e127-35d0-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 11:46:27 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8446.eurprd04.prod.outlook.com (2603:10a6:10:2ce::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 09:46:26 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 09:46:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7199e127-35d0-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TsQbHyK8371hUpUCjQ2h6kvc8HkwF3y7Z9LtBlQWjIa1MaZJULl6ReeSxv4LWLAxb/MY/cCBpFxAZ6wnvVl6hxh6y9oakyCAL3wPzWxsqlJwq/DnvnEm8/Ri9Tsd0GMTNq9GUx1oWHwLnWzt6KcUCXLstX7rlG5M29ekNO6Lng0TmWHLPcx1RRcFnGm+SbJENil5LHk/S+YvKXqhUvayu/6bBtv0X4s9awc8l+7a62WSpXjXH3gkXyo9FaoDz8PLxbr9sfXh0fPXhPB8WBAnfsL4O/O55NUDgT5zuaaCJ2ncAT0S3Tgy9noyFVIoFCduiJQdNKpXH1z4E2DfKZVXUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SVrFtQxpqHFMm4qDt7dXEN4BfK0cHrftLblwpSh5cH0=; b=TXhsNkxj0pcrYayCxGnboHo0BOIAsIvvY3yKTqP7r0PhFrkawwCPsSfRjfAU1kElAu8oN8Ww/5Ke39+IBZUFhn6lKyhZH5Z2pH6PEgHJgN9xkbmufoUUQxLOO6/iNv2ql1MKANK6vurGLRkFj0DFQHJldBb3y8djQR+uwWRZS5a5708jo/neEV8Uq/IrBM5uUJSociq7SSTvChne4CWr+D3ZFu6wJt7LOr6KUbIfJvSxBGzDVDYpnbin0zQKLMM1t+kzveeiXUnl75YOMcP/gHftHuJbEa70KBdow8HO9ZYBn+eDRgxi1cJ1KqxIfyPlGAImbRiHIesvQpolp3pH8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SVrFtQxpqHFMm4qDt7dXEN4BfK0cHrftLblwpSh5cH0=; b=Su0FHVYqDlZKYxTe11zbOkJlub8bMKdXITFuM5Du9ptsTYnjhrTqzuCV+sWP/xkY7W5WCFVOB7QvKjZ0e1KazFQtuglGyucDfB+O5NHgRMYeLNhYilnKTin7b7Su9/zYWkUJKwLo+LgpD53TH8Ocbv6rJfMyE3iecU1O+crWwJuGxSWbibpJfI2iLsw1TmALtD2HfWt6D4ISfHOfB92DEP9eGPJ4JUM4WYFo2+vqbj2Uo9ACvdQFbmzydH/mPcPXsylIJB2JFpqrTdTvfohk2E/3gN28zLzFhdzNQkCJex/zuxRt3NZ5v3uxN2s9nd/YTetOk69cQ/jINQ8mBFrtGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 11:46:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio From: Jan Beulich Subject: [PATCH] move __read_mostly to xen/cache.h Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0194.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8446:EE_ X-MS-Office365-Filtering-Correlation-Id: 24628a65-1c93-4ddc-4ec5-08db97f4550c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZtLsTheX+PuBQyB/isMq0GkEsyY09jQbKY3AsayPlfoKdDGWCFLoQugUUu26z7T8SkweCtd3HMMA0/tRFPDOzfMeK1nsWTe7uBiFqsVv4pPgLTLZcFNc7yU832WjPGdA21WkHk0bmW3bZiQXcVceSBaoH05MLMY9/OaCuvGZ3FE4JiHIyUq4QuvyAXXrl3G1tS8IDNaSDip6yvKrxEDo9mwpZ6arQJUFTf0vdO+YZzf5A+X9QEqrY6QexD8Ktm1KgqG7/dv0zSxt1pbAki09vcWo30LvbvH714yoy2mdgWtdChwT36lycuSPUlHGyXqi43hC7xlKrc9IJVSqOrVOqRCrulKfWFuwWlyaLGjJk/P65d2MMD1hwmhTnox4dhr3osO6z85p1pyV5QXtkGvbmaTWXshgsMUXKf8ZJn43/5T4E50P6ZEbR69zFIvOCF5VudASV3byeGkGLsomCQWvcHwlFyZqwYI9hpJHNUn2dwTziPIc09wcH9MMrIxE2b2NhCeVb7mx+HaKWZR0uYf3fnl+bQeG5oe12i5FqsEgiaoBUHFH1LXS2wgvfNoS0gPmuDHc5p3c/t9T6Y0VFXDB4LF7v/WP80io+ZzKk8milNsuyurrpq9MFcRBvCIWOpPrpQ7CB1Ctb5cZAgtMVFAGWHzR/8ITJfese/4kbpqm1t5ACirBYNkNDnLCaC1WrX+z X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(366004)(346002)(136003)(39860400002)(451199021)(186006)(1800799003)(7416002)(8676002)(8936002)(5660300002)(4326008)(6916009)(41300700001)(316002)(83380400001)(86362001)(31696002)(2906002)(6512007)(6486002)(2616005)(6506007)(26005)(36756003)(66946007)(66476007)(66556008)(45080400002)(478600001)(31686004)(54906003)(38100700002)(45980500001)(30990500010)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2pFTGt1N1RRTEdxSlJCUllBNzgwNnViaFpUYXBYMHFSM0lSMkx3WkxWNis4?= =?utf-8?B?TjBtOERERXZTN3Vac3h3emdmMW8vWnpVSUFJT25jTkM4c3FoWGlwUXZuYStr?= =?utf-8?B?VUlKeEZLc3JTTE83NTdEczZIbHZ4T00vMytIMzg4aC9tT3RMZTBLck5OY3kw?= =?utf-8?B?ZjFwcnVXUTJmNExxOUVUd1Z0SEN0SVFHWnN5bWFPcUxRQnlEM2hRUGVKbXBW?= =?utf-8?B?bHhMNnV3RUNuaDZXTVBhN2M3bEM2RGQrVEt0TnNwMnVNVWZJVHZvTWVoN2N1?= =?utf-8?B?NHc1aTJVYUN3b2xDMWpZbk9CWFpUS1ZXcktBMDJTa2JNS1ZhN05VTFZtUjhN?= =?utf-8?B?NmtEM0hJNFhKRTA4SzU5RGNlVU1BdUtkNEtmVERXUW84djIyYTRJOTkrMXlt?= =?utf-8?B?d2FOTUV4VWN4ZWdva0RNQWk1OFk1Z3UzT1pXd3BVdW1Vam8ybFlSN3BVRnNo?= =?utf-8?B?SVdJTU1pT2FUWEhFRnRmY085TWFsZ05pVjNjZ3hIQytlTnduVW1icGlYWHl4?= =?utf-8?B?RGNYKzJVaEpOYWxLZndrd0oweURGOG9ubzhaY3M0V1l5allVajRjZHlIKzFN?= =?utf-8?B?b3liUDhBUlIvaVB3d2VUVnYyOW9EZy9ES01wbGVJbXgxMWhCUlRPdE1sMUMw?= =?utf-8?B?ODhXZnlFbzRVNVhKcXlLSkI5bjFFWlBWaHRlSXAvR1N6VnVzSzQ4eGZUT1RU?= =?utf-8?B?MmpFOGttR0crL1VmRmZhamdidzhXdmVPdTBBT2ZVSXZheHJTVDRuN1dXK1o1?= =?utf-8?B?MXZ6Z0l5TW1PbjNnUnlGNTduN3NIME1TREN3TkVEa2xxdWZaYlQxZ2lDUFVW?= =?utf-8?B?eHdsUkMwOUoxTUJzNUJKNWlaNkxNS2s0RDJ6eVVZQU03cTBXTXVIdkYwZlN5?= =?utf-8?B?NlZHSGFmdHNOT1FQaTRZUVhrY2Z5a0JQcVNtdEZjaHBGb3BSY2kvdUNCdnB1?= =?utf-8?B?R2lUbE03MFc3ZTBEQVJ0SFFzcHRNR3E0eWxrNCszQXFIS1FhbS94STVsSmNL?= =?utf-8?B?OEpyTlExSmQ3b1hvdkt5eDg1dkRJeTZKZ2JXdWx5VkVNRXh1KytDdEFCemxl?= =?utf-8?B?RnFsUVJ0KzNYK05QMFdWWkU1akx2QzF4Wmg1Nkt0R0tTMnhRYVV4NDUwL00y?= =?utf-8?B?d2tEWEZCL0pGaXRxak1QMjlaNDBpQmNGelJVSnNyRno0QWlSWVdMZ3hRNkh3?= =?utf-8?B?Mkt4UDRVZlZGUmozVEpsZTVKK25Ta2dzT0JVMGFsdGQvVzZBRGl0WWM4ZE5R?= =?utf-8?B?dU1wa1BiMVRRakh2amJNNlo3dDMxK1Z5Mktib0YrWVNhWDlLbEVWVnNyN2M2?= =?utf-8?B?WEJBdmlrSG5scW01ck9JVEw1TWpwek1uTEtVUmZCbGF2SVIxSUNEclk4cVo2?= =?utf-8?B?SUt3azF3eWJXSjFyVTZFaDJQYmppTGUvVkFFdk1IaGZhQm00NkZBNDJHSnRS?= =?utf-8?B?M2l2UklHd1kyS3JSbE01WEJ0SEVjU2t2eU1nejVlZVV3bTN4VWdrSVJkZDBq?= =?utf-8?B?dStjbkYrT2xoZDBzMFVLcU5BdnFISmxkd0NIa0xaUXNCbTk2Tnh4dGV0Z1hQ?= =?utf-8?B?VmpQWGRvOXRpNHhzTWYyVXphM0JUZXhzeDI5dkVaeGxKcHRZYjVta3VhRXF5?= =?utf-8?B?MEFGYkw5djNkckt1YndTbXJya3pabEpveWExMEsxMnEzYkM3c29La3cvZW9F?= =?utf-8?B?UG90Vzd1Q0hQdjBpTkhnN2I1K255Mkc3ZWlHSXp4L2NZTkxtRW1TdHpMb0FV?= =?utf-8?B?ZFRZa25JS1gyN1B0VXNrK2ZsNE1kK3Rxcy8vcHkrUzI3ZmNzcFhJNzRyckth?= =?utf-8?B?OUVrdzdwSWU3Y2I2NnNFTDNTWHlJOGx4dWZ5ZjhDTXFCTldRdlBGRDhocGdm?= =?utf-8?B?MDJMejArOGtodmp2Z0prYlp1NTlzZjg4K1c5L2pPdzZrYVc2TnlpcjIzdDR3?= =?utf-8?B?c2k2eUY4MGVHVDAveTdyRVhueEUyWjJjck80dzBBcWplMUhyVDAyKzBkUVVN?= =?utf-8?B?b211azZwUjAvTExTY2JXVkE4MVVZcVQrN0RCUlNNaUVXYndHZVE5WnZsZmdt?= =?utf-8?B?ZCt4ZHlJQmQzUUhsV3JwWnM2cDlEaG9PWjdNZnBxaVJ6TmdSUmhYWGNQTGxJ?= =?utf-8?Q?MjVJC4+K2lssM3U6hamPIGewS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24628a65-1c93-4ddc-4ec5-08db97f4550c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 09:46:25.8838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p5Qa+SdjgpvN8/r6BQ1V4xLbWEGLQb99h3v+6rTfai70EE8dvhbjUAM08I9mXpqc/M7XNmFkFQiZDjpL74l1yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8446 There's no need for every arch to define its own identical copy. If down the road an arch needs to customize it, we can add #ifndef around the common #define. To be on the safe side build-breakage-wise, change a couple of #include to the xen/ equivalent. Signed-off-by: Jan Beulich --- a/xen/arch/arm/include/asm/cache.h +++ b/xen/arch/arm/include/asm/cache.h @@ -6,8 +6,6 @@ #define L1_CACHE_SHIFT (CONFIG_ARM_L1_CACHE_SHIFT) #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT) -#define __read_mostly __section(".data.read_mostly") - #endif /* * Local variables: --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -34,13 +34,13 @@ #include #include #include +#include #include #include #include #include #include #include -#include #include #include #include --- a/xen/arch/x86/flushtlb.c +++ b/xen/arch/x86/flushtlb.c @@ -7,11 +7,11 @@ * Copyright (c) 2003-2006, K A Fraser */ +#include #include #include #include #include -#include #include #include #include --- a/xen/arch/x86/genapic/probe.c +++ b/xen/arch/x86/genapic/probe.c @@ -6,10 +6,10 @@ #include #include #include +#include #include #include #include -#include #include #include #include --- a/xen/arch/x86/guest/hypervisor.c +++ b/xen/arch/x86/guest/hypervisor.c @@ -6,11 +6,11 @@ * * Copyright (c) 2019 Microsoft. */ +#include #include #include #include -#include #include static struct hypervisor_ops __read_mostly ops; --- a/xen/arch/x86/include/asm/cache.h +++ b/xen/arch/x86/include/asm/cache.h @@ -9,8 +9,6 @@ #define L1_CACHE_SHIFT (CONFIG_X86_L1_CACHE_SHIFT) #define L1_CACHE_BYTES (1 << L1_CACHE_SHIFT) -#define __read_mostly __section(".data.read_mostly") - #ifndef __ASSEMBLY__ void cache_flush(const void *addr, unsigned int size); --- a/xen/common/version.c +++ b/xen/common/version.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -8,8 +9,6 @@ #include #include -#include - const char *xen_compile_date(void) { return XEN_COMPILE_DATE; --- a/xen/include/xen/cache.h +++ b/xen/include/xen/cache.h @@ -15,6 +15,7 @@ #define __cacheline_aligned __attribute__((__aligned__(SMP_CACHE_BYTES))) #endif +#define __read_mostly __section(".data.read_mostly") #define __ro_after_init __section(".data.ro_after_init") #endif /* __LINUX_CACHE_H */ From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:53:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:53:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579532.907542 (Exim 4.92) (envelope-from ) id 1qTJOZ-0006Yg-Pg; Tue, 08 Aug 2023 09:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579532.907542; Tue, 08 Aug 2023 09:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJOZ-0006YZ-Mw; Tue, 08 Aug 2023 09:52:55 +0000 Received: by outflank-mailman (input) for mailman id 579532; Tue, 08 Aug 2023 09:52:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJOX-0006YA-S4 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:52:53 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5654acf0-35d1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 11:52:51 +0200 (CEST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-317c1845a07so4045812f8f.2 for ; Tue, 08 Aug 2023 02:52:51 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id f6-20020adfdb46000000b003177074f830sm13122945wrj.59.2023.08.08.02.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 02:52:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5654acf0-35d1-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691488371; x=1692093171; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=1ny2lmOhIgokgHz6VdMH7DQQmIyVahsX5ZjUgT/HTBU=; b=W8xMmLsazsGGrf/WVu7d2ZLVN0X9rRchXdEl2BSMMzPY5mTXFvwqi129d3msky0qpE +0mkEPHTMcsLXiVg8J8r+RnOCrLKnTOBDtn7bQcjNSAQDRQQToKSX3NA+CqOcUbajibl iARCa1zjse3CabFYvaEbo3ci86N5JJkFbYjIs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691488371; x=1692093171; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ny2lmOhIgokgHz6VdMH7DQQmIyVahsX5ZjUgT/HTBU=; b=f2R6BubCLfPQYUt3GyWCrqXqwEyFZtBdG7K1fQfJSL0tgTQjOPrpi0emFWF4/ylFg+ zXDo1J31QvJBvCL9PMA7jrqVV8GWY1YwV7TVlqBjf0KRrSYFeq5MJMOvpMfQP342Jl1Q TQ3QZpSjEyPTKAzbXbHTKNAMJe5lUL0CQATv5DQJVC+FH0fxzcNh6kMImBW/Z0Fde+9z cRRZMOH+/J8PeAwNMFnHnJ21rtbw5H7XU0/OX90g1ewkPcU1i7JvMpb64xaJ6bwxm4lp KOMM1oIWsgKDX5T/SDtQ/6cfutdiPxkaIjgZDq6CnWRlSC0I29Il6WLYx9o4iWZKFtzM w7gQ== X-Gm-Message-State: AOJu0YzIB8UA21NNK/Oi9/BWuND26x9DTlzRrP+nWnyNTGJfrFkXT8ep xwdD8CM7fdFRpD8bf06zkaNoBQ== X-Google-Smtp-Source: AGHT+IFVgI9gGVkg+vluaazwSOrh/swjDa5/VCu5uqWz5MKw9HghNyk7kF3CDAHeCOGk+oPqmP/cHw== X-Received: by 2002:a5d:464a:0:b0:315:a1bb:4d7b with SMTP id j10-20020a5d464a000000b00315a1bb4d7bmr6792592wrs.35.1691488370921; Tue, 08 Aug 2023 02:52:50 -0700 (PDT) Message-ID: <64d21072.df0a0220.bdac0.2e7e@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 8 Aug 2023 10:52:48 +0100 From: Alejandro Vallejo To: Julien Grall Cc: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option References: <20230728075903.7838-1-alejandro.vallejo@cloud.com> <20230728075903.7838-6-alejandro.vallejo@cloud.com> <5bd0894b-6114-48dd-8c7f-2d1fe142c9d8@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5bd0894b-6114-48dd-8c7f-2d1fe142c9d8@xen.org> On Mon, Aug 07, 2023 at 06:48:13PM +0100, Julien Grall wrote: > Hi Alex, > > One more remark in the title. s/HAS// as you renamed the Kconfig. > > [snip] > > -- > Julien Grall Oops. Good catch, cheers. From xen-devel-bounces@lists.xenproject.org Tue Aug 08 09:53:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 09:53:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579538.907552 (Exim 4.92) (envelope-from ) id 1qTJPY-00079E-78; Tue, 08 Aug 2023 09:53:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579538.907552; Tue, 08 Aug 2023 09:53:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJPY-000797-44; Tue, 08 Aug 2023 09:53:56 +0000 Received: by outflank-mailman (input) for mailman id 579538; Tue, 08 Aug 2023 09:53:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJPW-0006YA-By for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 09:53:54 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 798c4c75-35d1-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 11:53:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 798c4c75-35d1-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691488431; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OjlPd5DxKYzZO/DBZ0j0P070yN/pTV1Fa2AkA1x6QFU=; b=Gx1G0F/Lx2khIvsWGpO6iPf12CbAiKntGoFQ+M6kWFLzetdoFIdYnXSR eFcLDIXxhu/QOLVldqqEeZ4R81ns7MCMtsZa9jiOpaN/21ZXzn1TBaR1a 398rahrWBIaeb5SJESSjL57AubV9GquVV0QkQbCn6c8FRvMvY4ogsLbHr k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118113088 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:7+LMkKCIjQC0wxVW/xvjw5YqxClBgxIJ4kV8jS/XYbTApDgn0mBTy TEWWG2DOfaONmqgctFzOYy29ExU757XyNFmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GNA4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5tlbLlERz N4jcxtSY0GAq+m42b+fVbw57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4XaHJwOxhbIz o7A12P5ITsrDuK+8we+40iCoOzxpSG8ZrtHQdVU8dY12QbOlwT/EiY+V1G2vP24gU6WQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceRzMw0 USSt8j0HjEpu7qQIVqU7rqOpCm+ETQUJ2QFIyQDSGM4D8LL+d9pyEiVF5A6TfDz14eucd3t/ 9yUhDQBq5oj0vcp7P6Qol2WgB6nqIHEahFgs207QVmZxg9+YYekYamh5l7a8etMIe6lc7WRg JQXs5PAtb5TVPlhgATIGbxQR+/xu55pJRWG2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M RaI6Wu9CHK+VUZGjJObgarrU6zGLoC6T7wJs8w4ifIQCqWdjCfdoElTibe4hggBanQEn6AlI ou8es2xF3scAqkP5GPoFr5BiuRxl3xunDO7qXXHI/OPi+P2WZJoYe1dbAvmgh4Rs8toXzk5A /4AbpDXmn2zocX1YzXN8J57ELz5BSFTOHwCkOQOLrTrClM/SAkc5wr5netJl3pNw/4EyY8lP xiVBidl9bYIrSeacFTaMC49NOuHsFQWhStTABHA9G2AgxALCbtDJo9GH3frVdHLLNBe8MM= IronPort-HdrOrdr: A9a23:xOjV762D7xpA2xSkHZpCkAqjBEQkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7gr5PUtLpTnuAsa9qB/nm6KdpLNhX4tKPzOW31dATrsSjrcKqgeIc0HDH6xmpM JdmsBFY+EYZmIK6foSjjPYLz4hquP3j5xBh43lvglQpdcBUdAQ0+97YDzrYnGfXGN9dOME/A L33Ls7m9KnE05nFviTNz0+cMXogcbEr57iaQ5uPW9a1OHf5QnYk4ITCnKjr20jbw8= X-Talos-CUID: 9a23:mnuSDW8ybEb6Rd/4/YGVv1IrNu8VLUT/9yz7fELpCkpiRqSYbUDFrQ== X-Talos-MUID: 9a23:ZrfYgwZ2UELGnuBTsD/PrgBYCuZS3p+/Mm4rkqs+uY66DHkl X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="118113088" Date: Tue, 8 Aug 2023 10:53:43 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu , Juergen Gross Subject: Re: [PATCH] libxenstat/Linux: pass nul-terminated string to strpbrk() Message-ID: <9654cdaf-48d0-41d4-8b1a-ee711950c45e@perard> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Jul 26, 2023 at 12:42:00PM +0200, Jan Beulich wrote: > While what "tmp" points to has been cleared at the end of the first > iteration of parseNetDevLine()'s main loop, this is too late for the > first iteration's invocation of strpbrk() (copying the interface name). > Properly nul-terminate the string at population time instead, removing > the late clearing. > > While there also eliminate a confusing (because of being wrong) comment: > A regex parsing error would be handled one further scope outwards. Here > we're dealing with field 1 vs any of the later fields. I think the author of the comment meant that they couldn't create a regex that locate the interface name, and instead used strpbrk(). But if the comment is confusing, it's not helpful. > Signed-off-by: Jan Beulich Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:05:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:05:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579545.907562 (Exim 4.92) (envelope-from ) id 1qTJai-0000Mb-6b; Tue, 08 Aug 2023 10:05:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579545.907562; Tue, 08 Aug 2023 10:05:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJai-0000MT-3v; Tue, 08 Aug 2023 10:05:28 +0000 Received: by outflank-mailman (input) for mailman id 579545; Tue, 08 Aug 2023 10:05:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJah-0000MM-BK for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:05:27 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0604.outbound.protection.outlook.com [2a01:111:f400:fe1f::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 174c35b1-35d3-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 12:05:25 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB7132.eurprd04.prod.outlook.com (2603:10a6:10:12e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:05:21 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 10:05:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 174c35b1-35d3-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4Myi64rXXfX1+OX/g64WatPxg+6k6i91ypSlF2oXOmjqT+TbXkZ4JZZ6SKO0W8LCsmyiO95Z0vReYoddAnRZD+CeBPs5pa+sNqUlBuGt91+71hRbl/My+vnR4xt1K1ru6SXTa2JOqrL76AYJwbHdMAIQkiloDSxKOcSBbCCeDbqDzYzj5mR2eQegUIDG13ow7IjZ906irKfS83X1HLVrB9/YTEcypBHKoiGc+5pep6wU/AIQyJqR88Oi5KPd31kQA0fOvjao3YGAn/tongLsNpnzvO6Wd8LTKcTfSN3uqZGyHHSmsCO+6ZQOA1arQtVbj0mh0IWfR1bDG3bIz/LOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C29WstG3FNN7JIwmB+XA6DOxLNVEuHctkhVXHKl2C9Y=; b=Qt5Gibhw9QmYK8a4hc77ZyN0kDf0UIG8UyoyDMG8MbLMBWRdfqgLNSRIuviYnDpDsU70N2JfIeilLlK20poALT03VfIG2Sefi2Dql2khCO7EtxrDWgtiB8yXzGABpbeRXCMdfqrqdoZMbhBEG8Frtcp4sUzy/ZDQoAYJcpPragL5WifPePNEqmIRat3l4wmopg+E8wKmhuf+xapLRGX6cSjTKZ7F1xJyANFro/nPoDJHhjCo11J/EIO0Fzze6Nlv2ZYaPQFTl5h4dAR/BkGaNnaYsPXIlkFGVQ0mKfhqKG2ZCxj9dHHnGYoxNUhWclusdeE4B8YJqwfHrad+udAa5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C29WstG3FNN7JIwmB+XA6DOxLNVEuHctkhVXHKl2C9Y=; b=CGjxzsOqgmmrsvgeibM23Qe60q2iRLLiUlIZsvRAQgWVXmNXDT42TCN44VZc1WHBzpO+C+R2S9BjotlTqrDVi3Dc9UHGYXyKpAWD5iGkZT3vO5Xo0OZ3kUVsLRWE14cO/ZLFQ3b2D4wadpDxfnVzUktkuriCVr0D+R24t7jSI0DPL/2NTEEAJVyPWj32QLKWikZ1u8FNwe4s7+YZTEwEFvogjnMCFO6dPmtjVFFW8ecWRNh4LEAHTMPbz9JqFFxPZGZkHZ0hbdELVhTPTl4fhrOf13ZKbuTBaNhP+U/73HUI7Hxkjpc+8frentTKq9WXV2tPTn1NISeabDFAara1nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 12:05:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 6/9] ns16550: Guard accesses to `vuart` field by CONFIG_ARM Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <1bee2fe06c4a9262b05cb4b8cd392d9630279f30.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <1bee2fe06c4a9262b05cb4b8cd392d9630279f30.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB7132:EE_ X-MS-Office365-Filtering-Correlation-Id: b5dd1285-7a5d-474b-ec2d-08db97f6f993 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +QWBVsmlOPRchqXkKey82/2lJbcts8WllpoyEsUCF992s+TtonehXf/X7/+W2MIQwSkY2mLnRJTOdxMsinHIJwNPDoqnJOjKP3eXkTjBOFbWgWMCKd1S7SnTGumZXvsajY8wt/SUnUjEkqLG9Mq+s30f+V1DdUSseensOf2mMXODmTBdkE4IY22TE4W9hNbhfSg1iqTZ0ddDLGwNzZhE6aZ8C0tC1R8t1GevPXDh93VGh+NSMwWdo9PaoZMgB38rrDllGCOpw1ANenWQHH/j8NqOFxzpXN9zGZ1SACLcufHDD5UIdn1WgG+ZiTMecBXxqJnSZ5arnhl8FMoaumnDcgY4UaehU/h2B2Sq4YZxbQuYmb+1MWLdNgDB7Cz3AZ3GZoZQvKaqkCtZidPBY2AVueclkQanK2i2By5sUWhXCVsfNE3nJmeCQHoLZXr8YApj2lZCbRBw7OvvVzjfga8SwBBmhrHT+wfaXU4RtayhbwvazO1RPmYulZt228s7rHQ0evUIH5eqVWlA3l8+6N9sY/r7HeD4tJJ/493rTSXuz0cZ4j7/ENrwMv9O7mBP0P9ZD4DyeFpUw5C3UoeA14+craDUSnsyLHwwETOFsH3YzbY/AIcXP+4Eo30idAGfDwoCAOlnF7BIXwYdaTYi72DAyeEa5WqtdJirMwYmz16pcMQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(136003)(39860400002)(396003)(346002)(186006)(1800799003)(451199021)(31686004)(4744005)(2906002)(6666004)(31696002)(6512007)(86362001)(6916009)(36756003)(4326008)(6486002)(54906003)(478600001)(26005)(53546011)(2616005)(316002)(38100700002)(6506007)(5660300002)(8676002)(83380400001)(8936002)(66556008)(66946007)(66476007)(41300700001)(81973001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1dQbTFkNmptVGpRWmh3QjBFaVVoSDRjWVFGUXR6TEFDWktMQTB0NFMzQUpG?= =?utf-8?B?T3hXc3dCUktGM0VPUDNxbVhFaDhSTkpFeXJ3cE1qbUQra3hlSGZNbjkySGFV?= =?utf-8?B?R3RUdmgyazdSV2tGaVVxRjZCSytJbDUwWW5iTTgrWHo3dmZQdUhIS2NZT0RT?= =?utf-8?B?L0RPTWZvQ2ptOWIwRXZ1cFE4S2c2akJzWDltRUROMXZXbFhJaEd1MTYrVDVz?= =?utf-8?B?c0Q4M0pWd3hJTExYaDVMNkVBWDFEbHpEQ0hPbm5TNkR0NHNnZXFISUhkREhK?= =?utf-8?B?L3BycFJBTEFRWjBKWWhmdDFWTWdEK3p5WHlEY2xvS0FnNDRGSTBXRGFkelUx?= =?utf-8?B?bVgvejY3S3pWZW0ySkdsMjZoRUJ6Z0FYZzVsdmY2UGRZOVVUdEd6OVdmd0c2?= =?utf-8?B?bklyYjgyZUUyaUR0enFUdFZUazJwYkxKaU9jTWEzZGVWaFUyTXdyaDNCODFD?= =?utf-8?B?dEg1TGcyM2kwa3JyeVpYajJlN2dXc0NtcXNsTU9kZ1VrdXNtd1ZLWWtBZFpE?= =?utf-8?B?MjZlQkkwUEhBUEVQeGxoMXBjeEhqZzMzSVh3MDBMbjlVM3pPR3ZCMzNzN09z?= =?utf-8?B?RDIxQllvZkhKUFBNZGZVZ3lMWUlXcjk2ZUozQ3B4aHJFUUR3Y25HZDRSeURw?= =?utf-8?B?Tno4R2Y5c3M4a1Y5WnVkWWlUM0k3dmgyd2IyNFR4S0NaUmdQajJGQ2MwbWty?= =?utf-8?B?ekRpVmJpZVIvVHhNQUF1VlB5eFVMUk5UemlEV0xqZEEvcTMvMmJkNkRCOURl?= =?utf-8?B?blhoTjA4emlDNlVNa2R3dmZWTEJhdm5pbHpJaklBSjFWeHBEbUZzVTVJS3Ja?= =?utf-8?B?MlVodk1hMGRYSmJSM1VKRTFoYWp3TmFVblF0MmROTjRNZmNVYUJXTWFySkMw?= =?utf-8?B?eUpmRlFzOGFoNXVpY015R1dMRDIvbTZ6cnFjVFNrdUg2WW8yNE41akdUNVFW?= =?utf-8?B?bHVyMXM4cDVReUd6RDdrSjNLODlGSjhRT095U3ZpbEJtZHkrM2pCeW1MeVFV?= =?utf-8?B?WlkyTk8vRUlvbWhHb0NCY1hDUnQzaFVqUE05RnRyazlrbEIzdEFucE1qWEpj?= =?utf-8?B?S2llaDRtcXRVQ2JaZWtuYmJxZUhlblVRSHcxRVZVVmt3dnJESCt5Sk5nUXNu?= =?utf-8?B?R09PYUpXUHVSamRscVdieWJzc0ZQaCtxL1Q5dk5ZbHowSSt6cHk2anpZOWs5?= =?utf-8?B?ZVRWYmJhMVprMHJ2RHdZUUV0KzJ0M2NFWlZDRG5KU3Q3Ty9xSmNjN1FONEtO?= =?utf-8?B?aXJZaGQrZWN1cVhFSFRNakk4TjVydFJpeHRWaHZNYjVKaDJsOThTdmhiTkkr?= =?utf-8?B?ZWZJZHlCUmJYK1JCOS9VTjJUYkZTa3hkc1RFazFQeDNLN3hyVHhlNzgzSEZD?= =?utf-8?B?aTJXa1RZOVdMdklMNmFTYTI2NnNCc2NoOUJqeWQ0dy9Ma0FEOXQweE85dG9r?= =?utf-8?B?b3MvekZybHdRN09zRklJWmdHVytJRngwcmpMREZJVkJicEswL3VuWDh1UCt5?= =?utf-8?B?clpqc0toaXpWSGpFRFhnbDEvTDE5cUhiRFFERG0xaVBZakhNWUx2d1VyUHZI?= =?utf-8?B?VG9tSmkyQnNHcG9INk8veU5LOWU0enUwUk9EdkxZU0Z5UGxnL2M2TElZSFow?= =?utf-8?B?NUxVaWRSbHhBRTBkalg5d2JjdEYwQzRwZ29IcHBYUjQ2V09vVzJMYktKQ0M1?= =?utf-8?B?eGdZeC95bHVGY0JRY3JldjNERHUzbERLS1RZYWk4ZEhqaWVZem4zSXAvMkYr?= =?utf-8?B?Q01YZ05IMVV6ZnoxQTRBM2o3TVRQZlhsQnp3UzhlM25tdElOWWdIM3RNY2lC?= =?utf-8?B?WUE1ZlE3SUFIRTNMeHBzSFZnRFBJMGJQTG9YMEJ1Skd1eElQTUZRREhHZW9O?= =?utf-8?B?Q3Npcm9BUE9lc0gyVHlFUUpXdzJzWnoreHNuRDFralFMR0doL0xNQzR3NHFw?= =?utf-8?B?RmFkQkFORkdQZ0t6OVdUaDBSNWtmZGFVU2JTVGwzNmxNQmpMdERBeGduMGln?= =?utf-8?B?VTJWM1hHTWVUZXFmQkVnbTlyOVJXeHNPM0c4UHF2SUNQUkN5cGpBZlY4RnE3?= =?utf-8?B?bU5xa3dwOWFzUjRWTlhtK2toaVZFOWUwbWsxSjlaaWgzM1BSWlo2bVRRTGZl?= =?utf-8?Q?RjH2HT7mxipwLLcjuYSVXx3vM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5dd1285-7a5d-474b-ec2d-08db97f6f993 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:05:20.9827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A+vY3qR4roXjaUFSjGHW47bDUL1T6ubr4wUCE6B9ArWE4c1qkgsd5HtWcYQHqnnC7NeBNNRtxlcZszWdaZUtFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7132 On 03.08.2023 01:03, Shawn Anastasio wrote: > When CONFIG_ARM is defined, a `vuart` field is added to struct ns16550, > but accesses to this field in ns16550_uart_dt_init weren't correctly > guarded. Fix build on !ARM platforms that define CONFIG_HAS_DEVICE_TREE > by correctly guarding access to the vuart field in this function. > > Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:06:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:06:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579551.907572 (Exim 4.92) (envelope-from ) id 1qTJc0-0000tY-I6; Tue, 08 Aug 2023 10:06:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579551.907572; Tue, 08 Aug 2023 10:06:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJc0-0000tR-EP; Tue, 08 Aug 2023 10:06:48 +0000 Received: by outflank-mailman (input) for mailman id 579551; Tue, 08 Aug 2023 10:06:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJbz-0000tH-46 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:06:47 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20605.outbound.protection.outlook.com [2a01:111:f400:fe13::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47888136-35d3-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 12:06:45 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6857.eurprd04.prod.outlook.com (2603:10a6:10:114::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:06:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 10:06:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47888136-35d3-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zh9blmFV191qIhf6hQvC6BPBNokFLBkDgY3U5DtV7AvWWY805cnkFlCX6wEmpq0MejJioaCeAOMas6He6fxB4cuvZJaL1OiAoUPW0wg8U4bNwrOf0E9E9WuIoDyhdSueF4uIj0nG7z/IZRszkaiX0McgNggP0uEa8k8TlQpa/RLz8GYT5EWekWk8WwX0o8oDxtUtLGufb/NHkx2z3peJXIJUsx3hQK33NKkov8qwcR+R4MRayV5CLXSEb3n5YYQbzWy6LoBmSTot8RuMoXzCMTnK6ACy5i6Lm+EC560BR/5bF70mYUGiiDKZKY4IvqdcHhwX0aj6NiJ4/cuPxQGFtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vow4pBM9reenEJMA4yQKVwMg3H2d4S3CfioddDhs0/k=; b=RjCskfejuTL3YPjxmDEuZZtocFn2IyAPOUDdUZR2Y3EPHoLzHPd487JFlhXSEb4ID00LXwWnsNOX9WHVvXPnFGq/G2Ajqp94190ym+78buD4LdPmwQBoci9IIHtY6Dnpm1xbQq357qmEzZs1gkBZBbg42UCzwqs2y6KdJQtcwxcr3zt4l2p+rHf2nKy/qxWKRCwm3o//1Jjch09nsp8C2MfPx+JRAeG/2npCtK90nFhPVX2f4rfbEx3Yg2I6jKBcB23iytAmqbYsnowtTjaF6AX50Iu4MhXwve6NSh/ShRi87jpCjzLFhbae2zKcmoLdghYH4sdyai02LUcVCWKexA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vow4pBM9reenEJMA4yQKVwMg3H2d4S3CfioddDhs0/k=; b=eK44V0tRLmsw7r9ooAD23yZQGUlv99ld7GAOhrCsXp0qTkLWFfzEoUnu2w+ZB6vh276z9BJm91t2yfEW++H0pc2kcr6XeM/cfD+u/zV7GgndMfAtHOzfABGNB3JGm/XtZ9eS7qeWNeBO9ojijLAQWlxCSjS7HZYYleKCiDwUNIpm3GbpwxG5G/tZIVf2YEv0TPfbVJE+SUNTGTdLthmGV8uAgh1txknHd8ZkMJ/hzmlVUimhh4PWcpKIS7v97Dhh6RWvfjr0jjP3WJH9QBB58RATO74q2IAqrnEEla9Qd2bRSKkLZzQTRbYh98LgTtTxzHwQj43K0MHFgFPtSExWmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2709366a-207c-d05e-a458-dcfe5964a5c3@suse.com> Date: Tue, 8 Aug 2023 12:06:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 7/9] xen/ppc: Define bug frames table in linker script Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <65e26bb63977749cc50daad4ecaf891bf7cc6b0a.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <65e26bb63977749cc50daad4ecaf891bf7cc6b0a.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6857:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ac16b23-d6f9-4238-6010-08db97f72ad8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qF7UrdcHfOfVkDXMyhjRgHmBo8k3UkUyIKOSzzSCjEYc8SoNCGV+UayIOwThJXDqkyudBIn8Gk6M76IHr5u5jJc2lU1FG5nkxfiGYeLTqqtj9rmmJgJn+DdGV9AKTSFSrWaktSN61DwZaaiYMLEk/PdHcRLV+gwx9+nZiNwNPb6rKtGbbq032GadFnk7kRvzAT5ii6efcexa5m/IKFOffm33470VT4GgHG9jPUL3qD/bXdVDZYO8A48NnfZlf9gD6eksLFCwAHO4d/v1b6t4Rpnod2o/CVkgj8bXapSjCmA0cWOTVXkBMLzPQCJDvl5OJ1ePDQGmSPLpK1bbLyK3D0hm695p9iZI3Nol1n/5wJ+3snXF4bc4ZNl1VcjCipfh7yWulLxGmLAiGGJN02DW0z3tmwnXXKmVeyyTw8uIJTrG49IQq3og+yzo1hSFQ51ZoT+Es8BOhZez2/6Mk7UAycO2UAbTdU+Jm9nOT7p48ONhGHP/jWvC/w6l+NNOZIq+jXrl4+rfRwfN86ST0iFR+GtaWM0xYCcOyXEmEEG+9PePjhjOGfXOrUMaLsuif49JDlwqt25lCSvv3IrN9oeE5ex96+PwWapAFi0OlIKgPMb5a3f2/uxfER5Lhm8U+UoEyMwKyrXnmQzd/jrT/bdFXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(396003)(136003)(376002)(39860400002)(186006)(1800799003)(451199021)(2616005)(36756003)(26005)(53546011)(6506007)(6486002)(6512007)(31686004)(478600001)(38100700002)(54906003)(66946007)(66476007)(66556008)(6916009)(4326008)(316002)(41300700001)(8676002)(8936002)(5660300002)(4744005)(2906002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmoyS3hOaHN2N1l3aEwrSS9aVzljZFc5QU5VaEtKSWNXV0xYdDBIaCtybjcz?= =?utf-8?B?Y2xKeE11QWN1Q1pMUnhpelpPZERpK0ZLVnZVVFIxdURxaDVWT0tKSlphSEh2?= =?utf-8?B?QnBURlNUUzhXUXh5OWl4eGZNdWdielBPckxIV1dtT0tDMHFHMkg4VXFhNGxa?= =?utf-8?B?UHpraFAzQktDTEo1ZVdxNjVaRmVtMWNYYXc2UWZNeW1XVmJFMjFwd2E1MkJs?= =?utf-8?B?bjIrME5QeVlQV1U4ZWJ3OXd6eGNOaWV0cTg2bkk2dm9lSEhKVUd4ZjJxQ3I1?= =?utf-8?B?QnAySjZtblQvbGVaOW5iVFV6c2FWT2o1WlpKRlFtdU4vMmNIRHJHVFVPR3A4?= =?utf-8?B?R1JjTjJpNmZ2QzJYSFZ3ejBrLzJzcGdZZjhIK1F2OERmcjRFejVNS2IxUkpk?= =?utf-8?B?OWRLNkk0SlQ3aEowVklMcWVlRGpKazhNbWpiemtXTnZRK3hVS2FJa3pJZWtW?= =?utf-8?B?R1NHVDZIZ2l3NGJnTUFRTFllM1ZURDlYSDltMW5OZmkwQkxGdWU3TjJNNlhp?= =?utf-8?B?Sm4rZ2pIL3E2QS9tMjU1dVFHT1BiSnYwNWNOZnU0WWRZUzRBNGFVR0NFSmRZ?= =?utf-8?B?RDBVc3JORzBzUXViM3NDeGxXWm5vNTF1UFZLeDZhSWFOMlZFQXRDZytVSlFh?= =?utf-8?B?b3pML0Zmd1F5M0JOL3FuNkRrZXlFWUg5aDcrNE9yeWh6d3NpTVlWY3BLeFZ4?= =?utf-8?B?aUhjZDE3MTM3aUFTUnhSZFJzdTA2cEdPb1Bod1VaUnZrelBVeUtxMmJib0N5?= =?utf-8?B?ZjdYU2Q2SkpGTGt0QmtwR3ZraiszUkY4Y0QyOXhsQzJTMThOVHN3MjJxSlY3?= =?utf-8?B?OHBSU2RmMENvNWVRNFN0RjhTaFp1UzE5eW9FY1BNSUJNeCtPNnBhelh4aXdz?= =?utf-8?B?dTZnY0lIR1B6MjgrdGRUdHdORjNsQU5mdGE0Um9teU1SWE5ZWHFyRUJmWjhZ?= =?utf-8?B?RDY5RWF0RTJmZ09aeGNSTTcra0tLKzJuQ0FYejlQSloxbW5DSk00Q1p1ODVu?= =?utf-8?B?aUJTZXlBaU14Wm9GVEkvTldpZG1mVEdpZytpU1ZMNHltOTg5aklhUFpkbnMy?= =?utf-8?B?MWVXdE92Q1hKVER5NnNmVW5WL3FIVEd2MmZLVjNlTmxIOFFTY2RWR0dEc0dM?= =?utf-8?B?ZXgyRGZFRFJSbnA2VW5nQ2RhS3ZIVmJuYk9sdnhzQnhKbldIaFVvODI2L3hN?= =?utf-8?B?VC9iZXM5Qzc4Q01RRjdNblBVZDlMcVk2S0JQQTNVZmlZaExRMndtNVpZYnpk?= =?utf-8?B?bmtnMHJTcTZjSkY5aG1ydUMrNXg2RnpUcEhlMUpQWjVvK2xheEJ1Tm1TL2xW?= =?utf-8?B?OXJydnJZL3FJdFZjaVdSUmZUV1ZSUGNycC9DOEpHdk1XLzQzbnBNL0RobVoy?= =?utf-8?B?bEc1MlVuVHJMT2Y0RUFLcTRxOU1iRWFrVnNvZ1Vqano2RXBRQUhmOWxnQzls?= =?utf-8?B?d1NaVlhUR21PejVLbk1sQVZ5V3Z2MHROSVRjblMvMFZIOTh6dVEzUXNsWjYz?= =?utf-8?B?QlI3Y0VsY015bzNLVEYxM1o1UFVmalpLL0t1akRjbmVTZ3cvUGNvS3pTYktD?= =?utf-8?B?UHYrTElma0xlVXNsaml5bWJQNlNWVExlald5N1VFTmlGVFl6elB3akU1aHVh?= =?utf-8?B?SWtjVVlRRFhzY2RSZE5UbE9CRnRpQkhuNStNR3ZpMm1DNVA3RlVmakFFamxz?= =?utf-8?B?d2pDMEFvWDdNVWhTanFPZEdvVWRHMUQ3NzlZYjFua0sxd0RLdVd0YXhLcnlz?= =?utf-8?B?UFpEanJUS1MvZlRVZ1VKVkhCUDhMWHJNT3NoWmgvWTVLMFdUYXpNcWJZTkgy?= =?utf-8?B?SEFXVFpLUERnUmZBNFMzUzRUMFVoTnFzVVFJa2hzRnZoOUpvSVNTbWJFS0Fz?= =?utf-8?B?TUtKdS9sZDk0bjN6NThtb1phT0dsK0tRdmpobHV5L0tIZHlSMUIrWk5ONXVO?= =?utf-8?B?cUtPR21DaFE5ZGkyeThTRVJMbDUvVnNxSFIrWUhiblFqSlN1VEQ3a2UvYzlZ?= =?utf-8?B?bG95c0drbjRHWEs3bi93VFhFSmpBY0hMQlR6djVLcjNhTjEwODliTzVyZ1FI?= =?utf-8?B?NnZBa0FiT0NBTDEyckhLN0FjYytZc2pvdFZPYlNyZ0twbUJqTWcxU2V2UUg5?= =?utf-8?Q?t6QwzJmvbayu++12JaaGP1/Em?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac16b23-d6f9-4238-6010-08db97f72ad8 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:06:43.5903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F5bQLHXMs45Jpm7jvxjVG4a2/LJJ1Sd4U6iOkguYrhcl3X6ujcLxSoTIESc+5cc+FQVr6oG8BgLWuCvvezEBcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6857 On 03.08.2023 01:03, Shawn Anastasio wrote: > --- a/xen/arch/ppc/xen.lds.S > +++ b/xen/arch/ppc/xen.lds.S > @@ -41,6 +41,16 @@ SECTIONS > . = ALIGN(PAGE_SIZE); > .rodata : { > _srodata = .; /* Read-only data */ > + /* Bug frames table */ > + __start_bug_frames = .; > + *(.bug_frames.0) > + __stop_bug_frames_0 = .; > + *(.bug_frames.1) > + __stop_bug_frames_1 = .; > + *(.bug_frames.2) > + __stop_bug_frames_2 = .; > + *(.bug_frames.3) > + __stop_bug_frames_3 = .; > *(.rodata) > *(.rodata.*) > *(.data.rel.ro) Looks like the added lines are indented by one too few blanks. With that adjusted: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:17:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:17:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579559.907582 (Exim 4.92) (envelope-from ) id 1qTJlo-0002SD-H1; Tue, 08 Aug 2023 10:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579559.907582; Tue, 08 Aug 2023 10:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJlo-0002S6-DB; Tue, 08 Aug 2023 10:16:56 +0000 Received: by outflank-mailman (input) for mailman id 579559; Tue, 08 Aug 2023 10:16:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJlm-0002Rh-NC for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:16:54 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af9c27b4-35d4-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 12:16:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af9c27b4-35d4-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691489810; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=k1s+dkCK9zYbkDJ3cmihj8RjVYKk8Tzuz2jSQgZd5kU=; b=bzOBuLsZOWKQjBDSP/vLZ4WbY1xZQnSMJe6Xhs7aVhv8+bLBUygOB6pN 5PF52vvQrf2PoiS8sNlZhWGDCpPQ81xWe0TeU2UPj+T7s19iwFG4p4jsw 06gzwPlrIvr/SmYUiNAByUIipDL6MIzxCOcsW+PQMQSTligAMZKPSz6g4 g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 119265225 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:JIoRIqoyAnznWcYmqFoi4S6qEXFeBmI5ZRIvgKrLsJaIsI4StFCzt garIBnSafuNZ2r9cownPoWw8x5Vu5TWy4VqGVQ6qiA1EHsapJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOzyZNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACFWP02M2LPm+uKyT8tKrN8RFfDJDLpK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jufrj6nX0tAabRzzxK4o0/2vsXvmB/Ze79DGZ6fxvVro0+Mkzl75Bo+CgLg/KjRZlSFc9BQM UsP4QI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ5sOcmSDps0 UWG9/vgHTF1uaeZYW6c/LyT6zi1PEAowXQqPHFeC1Ffup+6/d9110iUJjp+LEKrpsyuSGz/n GHalng3gpc1p9U57pyZzWmS1lpAuaP1ZgIy4wzWWEes4QV4eJOpauSU1LTL0RpTBN3HFwfc5 RDoj+DbtblTVs/VyERhVc1XRNmUC+C53CowaLKFN70o7HyT9nGqZui8CxkudR4yYq7oldIEC XI/WD+9BrcJZBNGjoctOepd7vjGKoC+fekJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yXC9GUv89nWbmHrd1PVoXKscWnzq7eHwG507/jer2iIC9Ft/pz2dinshmtfjZ8W05A v5UNteQygU3bQENSnC/zGLnFnhTdSJTLcmv+6RqmhurflIO9JcJV6WAntvMuuVNw8xoqws/1 irgBhEBkAKl1CGvxMfjQikLVY4DlK1X9RoTVRHA937ys5T/Se5DNJsiSqY= IronPort-HdrOrdr: A9a23:K4UO2qvSjbKcTpHGPQMx7r1i7skDstV00zEX/kB9WHVpm6yj+v xG/c5rsCMc7Qx6ZJhOo7+90cW7L080lqQFg7X5X43DYOCOggLBQL2KhbGI/9SKIVycygcy78 Zdm6gVMqyLMbB55/yKnTVRxbwbsaW6GKPDv5ag8590JzsaD52Jd21Ce36m+ksdfnggObMJUK Cyy+BgvDSadXEefq2AdwI4t7iqnaysqHr+CyR2fiIa1A== X-Talos-CUID: =?us-ascii?q?9a23=3A1ZpVI2nq70MPWo/h9B+lTNO994/XOWyGnSrffB7?= =?us-ascii?q?oMzZgTZ+zY0SiwZpGo/M7zg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AIhMSIA0RS3aO6eTwUtRjTEXvMzUj3vWTUngnsZA?= =?us-ascii?q?6meq5ZCFTHAeWjRelXdpy?= X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="119265225" Date: Tue, 8 Aug 2023 11:16:44 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH 1/2] tools: add configure option for disabling pygrub Message-ID: <7826b9c0-38da-414c-813f-ee3ac4ee18ce@perard> References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230804060000.27710-2-jgross@suse.com> On Fri, Aug 04, 2023 at 07:59:59AM +0200, Juergen Gross wrote: > Add a "--disable-pygrub" option for being able to disable the build > and installation of pygrub. > > There are two main reasons to do so: > > - A main reason to use pygrub is to allow a PV guest to choose its > bitness (32- or 64-bit). Pygrub allows that by looking into the boot > image and to start the guest in the correct mode depending on the > kernel selected. With 32-bit PV guests being deprecated and the > possibility to even build a hypervisor without 32-bit PV support, > this use case is gone for at least some configurations. > > - Pygrub is running in dom0 with root privileges. As it is operating > on guest controlled data (the boot image) and taking decisions based > on this data, there is a possible security issue. Not being possible > to use pygrub is thus a step towards more security. > > Default is still to build and install pygrub. > > Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:18:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579566.907591 (Exim 4.92) (envelope-from ) id 1qTJnW-00034H-2V; Tue, 08 Aug 2023 10:18:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579566.907591; Tue, 08 Aug 2023 10:18:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJnV-00034A-VH; Tue, 08 Aug 2023 10:18:41 +0000 Received: by outflank-mailman (input) for mailman id 579566; Tue, 08 Aug 2023 10:18:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJnT-000342-RK for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:18:39 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef067c26-35d4-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 12:18:36 +0200 (CEST) Received: from mail-dm6nam10lp2100.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Aug 2023 06:18:33 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6139.namprd03.prod.outlook.com (2603:10b6:408:11c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:18:28 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 10:18:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef067c26-35d4-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691489917; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=Y48+mdA12KlhD2wOqIeA0SVsEUh5pXtbmmkGEanAYtI=; b=PbDDz0INbvR7h939H6fBCAloI3rUHra9/SEoxMB9Eu+pARROXeFDHR6w w7KDi0wUL4a7SDdDjTmkYFw/hPzwWuX0mL9YBW4frSoAn2ZOPGQw52XXG 54SCSSuzZMA4bfQL2lsREp3SEXEWk15iHc0URym6lbh7+Kizca/X/mh+E U=; X-IronPort-RemoteIP: 104.47.58.100 X-IronPort-MID: 118712592 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ItPIy68vMaNyXtJ8KQWnDrUDLX+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2cfX2CEPv7fZ2ehKoxzYYWyp0hV7JCAm9UxTlNoqXw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks21BjOkGlA5AdmNagU5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklz9 fwZMjUcbCm7xLuxmo7iGvllhvs8eZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpiNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdtCS+Tiq68w6LGV7jVDJhcHUWKdmtnjoXWFeYJbe 1JTyiV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19KqQrD60ETgYKykFfyBsZRAe/9DprYU3jxTOZtVuCqi4ipvyAz6Y6 y+OhDgzgfMUl8Fj/6+250zdijSg4J3AVBco5x7/V3igqAh+YeaNeYus7lTK6OdaG4yQRFKBo XssltCX6aYFCpTlvDeERuwWALiy5vGtKjTEnVl1Ep8u9jKg9mSie48W6zZ7THqFKe4BcD7tJ UPW5wVY4cYLOGPwNPcvJYWsF84t0K7sU8z/UezZZcZPZZ43cxKb+CZpZgib2GWFfFUQrJzT8 KyzKa6EZUv2w4w+pNZqb4/xCYMW+x0= IronPort-HdrOrdr: A9a23:0ixsUqAUFNOCj9TlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-Talos-CUID: =?us-ascii?q?9a23=3AdCU922rZSZNynnWytqPMBsXmUf0lcnzHyWbSGnf?= =?us-ascii?q?7UGEzdOTFWVaQx7wxxg=3D=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3Ai/dHxA5aplDLLAZdht8Vpmutxowxs4qkGUQ0t64?= =?us-ascii?q?m4eK/Dg4gP2eDywS4F9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="118712592" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+PQxvJaK4YP062TEM/FXAJBZwmOaMlse9CxhpIbvVBiBA+PWXUnIV8yHk4bwsNHv0vL2iFe5VMn3shI2j37FI9KT4C4K3zTAqSOfCWH7K3kQtRM58qIlcCDUO4MQmgHxsg52P8TYQdq/SgpvmnujDnFsoDb6EQ5ZW+IY7E7J7ulOTI9PXSUgcUaiWu0ANdzxsSh8BZHSUC62Dw4fG6eggP5hx6oWWOfeFqcsl/s/wIGHTct8i9VIuYPdduHIEuCqjGyQ3mC1Plx5xjhZqTc7YFgqbRjBFtWEJ3Hb/pgtT1HEqBPlaWTf80kWwH2ulhRLEyJWZ5b7jcUSMP2J+SQMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y48+mdA12KlhD2wOqIeA0SVsEUh5pXtbmmkGEanAYtI=; b=IpRRpYdDUrURu0848MF7qceY1xX3YEeRUH1fsM3PiJttVyd5OilME/VKyqyOpAcEQCltIOrPwUGJG/3KHDieKEI+zacXS+wBwkVXJEJhFGMVrdJC+fxnSCm1oytpzKaVg42aOR5UkqGbUDicQFHxVNMPLlf4cyF/uZhssIVgbnVAo0ZXhKZXupND1cDf2oT9jM4iqGdzEWeL0990cstuBl7PHXPvyl0pZ1MNJhNwiJ/4J7pXFWGGarfKmzfJgZL1x9XoVA+lcIgovIXKK7ONn7X4MprB1tl/Vw7gJ3fmpKAslMQ578O27OgrPdWMtczWqBdVdZtvORt7/eQd3WX1xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y48+mdA12KlhD2wOqIeA0SVsEUh5pXtbmmkGEanAYtI=; b=TxLtu7cMEudzvDS3OPu7FT24C9sScLUVJUPj9qFHMO5zVPox6qKO6HqFSLGK6s8/YxB20i2nQAyW3hlIZ8K5isIwK8Q8qoygxQ5o/T/QR7gqSDObEVUkAqtTblBh7mOKth/5dMt3zg6u3vylakFxz5oaLQvUqY78g3zc02olPQk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 8 Aug 2023 11:18:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] move __read_mostly to xen/cache.h Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0075.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::8) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN9PR03MB6139:EE_ X-MS-Office365-Filtering-Correlation-Id: eb87309a-f392-42bd-f15c-08db97f8ced8 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0sYf5t2qeF2NAlIUIHwNfR5zsJk1h5HkhoTnziUnkgxjgRQWFQ7rHU38/6HqLQSFAfhQEU5ZVU73kU5aXILRqchgF6mfdf1G0HDEANi987FGveAXedQAlJirV35O6fz0OnP6ka0Lx2lfAj/zEF36DgczzvalzULLSALsRft3omlXeDG0jJDIzXYvaqpJTrMdMEYyqxPm5Y/r9yZaeYNoFxsIDTa7ySCDIGKHaqBIs2bt2BRtzVCZk6wkwiv3MS6oROp//EuwFbExDV0aEKw7oz722L6vyMdEc6L7BMNfoLedrHGhVhdmUZGptACpjtsEnS37IES5A8fkaOvZ7ROGfLlNgRB+FUVaMC5wt5Qx+nkA0WBXu6qz5Qt0CH3h09N+LuBVGWUXuBTnvtxzjg83y+hp0edyGHQXAxFo+UIH0eJkr/gax0OxR4j2/ZLn37xE9n2kORBA4bmwNw2inasds73nipiSc+CzjEKWNIrjpQIRGdiKPtAr5WKJDUhqpY1wNI+eVs0qp5My4NTJ0cJCf5wUaUdJY4XIXf7W3AMwfCyOVh753ouYNs2ogWQssDDeDcrFsVrQUWjCmghpFe1gfloYmYJIdR+5vYZhTX/HUh9Y3XS03qLGciRSu9peb3GyYSFaevmGFmxqniYAsD8Gsg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(186006)(1800799003)(451199021)(2616005)(36756003)(6506007)(26005)(53546011)(6486002)(6512007)(6666004)(478600001)(31686004)(82960400001)(54906003)(38100700002)(110136005)(66946007)(66476007)(66556008)(4326008)(316002)(41300700001)(8936002)(8676002)(5660300002)(7416002)(4744005)(2906002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnJoSVpsK3VpUk53dFMxMEEvcDhEYUdVQm80Y1ZQTmp1NzZCczdVZzlpZ0JB?= =?utf-8?B?SVBJWkZjeGh1TVEreC9XSkI2cC9NWnVLM0s4UU1pa2E5eiszb214Q3NXK1hI?= =?utf-8?B?RVpXYkVtOXR4R2VyV3dEeVp4MlYxUmR5aEpON29rUjhxaUd5TlRZTlUvcUU5?= =?utf-8?B?c2svZ0ZKakFiMktrMUZmSGJsS1cyVlBiQm9OeDFSRm9Mc3RHRnhtck96R1Y2?= =?utf-8?B?Z0NoTmxEdng2cVNWNG5Wa1lKMHQ2RGcxdEpwb0ZuMmJiYmZRWkNFdDR4eEdQ?= =?utf-8?B?dUNDN29wRmxsWnRwYmpMR3dkaW5lY1ViSDZFdmoyN1J2cGF6RHVlWlA0Zmxj?= =?utf-8?B?RFErYjdKZGNiZU95T21EbllwdXJNVzZkamovVC82aituYWgwVEhVM3NKOEcx?= =?utf-8?B?V2ZYU2RCQ3BHUEFrcWVPd3p2N1lRalZTeXpYTklleURkd3h1TXlmd2lzbFQv?= =?utf-8?B?eUdJai9sdmhNd1lKajJiaC9aaEhqVFZvZzVNT0dmclBnRWFlRUNHWmtyVEkx?= =?utf-8?B?dDBtTlhwbWNMRlFwbEUwb0RJZGhiSjY5cEhUbmlXQU0zdjFQVUFzSm1rNnVv?= =?utf-8?B?Y1lyWE1ROWx1WHdGRE1idmJ1MnIwYUU3dElYdmRTRlcrTTNyOUJrUjZjQkxy?= =?utf-8?B?aUt6aFZQQTVEQjN2ZEZPL0lSbGpINDg1NmhnZjZibWZ3cTRzdmo1aXovb05M?= =?utf-8?B?blZ2OTNLQlRZU2ExcVBFWGJuZW4wUEFIaGRUY2Z5c3Zxa3prcGFERld5RHlK?= =?utf-8?B?ZlY2SVpIUi8waU9hMUEwc1VCZWJIS3BIRHpjYUF2cEh2VE8vVWFycGxzeEps?= =?utf-8?B?cFE4TVcvdnRVYm5BeEdzZGtPeDFDQlliMmxkVWU3V21odHNoUEJiNi9JQ0pE?= =?utf-8?B?MlF0MVc4OEJDWmVtcitmcGx2Y3dKcFBCengvdEF4S3pvVzdaM0JpaGx3MFdC?= =?utf-8?B?ZDF1amcvSFM4eFFscWJhTzhkckdnVjB3ck5uemd0NkpsMUdJcGNyK05DVExD?= =?utf-8?B?Tmw4WmVRY1d6TUN2Rk96MVUxWFlUdUQvdW9VdkFSNXdnK1BmRHR0L1RUUExq?= =?utf-8?B?MnljMEhJZUE3SGFqU1phV3ZHT010UUE1TjB3WWNvRDRld09pSHM4Q284Q1d6?= =?utf-8?B?UzFzWFpLTys5VTArQ1Y4cEZXSVdVaUYrRStob3hhb3V3QVErNTBiSzhNMCt6?= =?utf-8?B?TGg0N2VFNG1PNEp6ZjFoUno4L0VsSUtFc2FPbmhxRlJFTXArbEZQVEVFdktV?= =?utf-8?B?ck85S0lEQmNjSGRkN3g1M1NHM3ZxVitBOFFnLzd4M3I5L3V5UmFOelU3VjlF?= =?utf-8?B?dnl2eGdKbllDdFhCZ04vWWVtR29VQkZlOFJ3K2VYYVhWL0VvT0U1UTJXN2Ft?= =?utf-8?B?SjVlRCtMYmtzZHBXQzdZQmJZM0xja2NRRVlVMW15Wm9PcEM4YlZnVk5aY3d0?= =?utf-8?B?NDdSRmh2eEl4bjEvQ3drWjBEWUZ5SkZzRlFKZGNPREVtbU5RNWZZYzcvS3FG?= =?utf-8?B?ZnUzQXpPRFl6Y25DZEpJTUN4bWM1RVNVU2JVNW1wMVZKZXlWT3QzZ3JsbTNE?= =?utf-8?B?aHFnamZBREVuOHVSeHN4OHNSNHZhdGFwZ2x1U3VMa3llOEI1MnVaSmZGaHJN?= =?utf-8?B?YmJXQlhVMHdtYmJSUkNWVVhuaEpDc1dCS0h1dFNDUC9ESUZEZnJLVWVzc3pZ?= =?utf-8?B?U3FXWmF1V0s5SVBiRW1kSXlMWDdoak00bDJ6aitjUFY0U0VXb2FZdXZKWTBj?= =?utf-8?B?MG5tb01lM3kyMXhINlNsWExrL0R6ZUxHM09OdloyRjNZSW9rWndUWi9ici9X?= =?utf-8?B?b1prZm5DK3FlTFVLaUc4TlRyckVoNHAwbThkMUE1ZzB3dmtXNXZ3N3lBMGRN?= =?utf-8?B?WXpHbXpYK2xNclBVajRWQnpJdERGQmQ1TVg5eUpsRjMzR1RuTFFYaGJNQnpw?= =?utf-8?B?Z3lhTjlINno1NDE1WHFtMXd6YkZGNjJwT3ZLWU40b0FvUkJKZHRnSkl3b21R?= =?utf-8?B?ckl2TW0rOUVzNHRkUEg0R1d2UWhPUElNM2ZOMWtzQ1IyS2xOVEs0aXIzK1h2?= =?utf-8?B?cytqK3phU1lNczFEeTJOZEpuR0M0TlBueXVjQ3dHR0NCa25XZDFPTXhnMkZE?= =?utf-8?B?K3ovL1l6Z01maTVITEMvUjRQa1IraVFpeXpxenlXdGJkVEh0UFdHTHBDbTN3?= =?utf-8?B?bWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?TVVoT0NGa2wrSmpVUkliUFNQaW4zdDhsTDRCSzdCU3RsaEhPSEY3VExWWCto?= =?utf-8?B?ZEV3OHlyL0lITXBvTWl4dUpEcHVseit5SEdLNEhkbFc0ZEtMZkZ5czUvTm9J?= =?utf-8?B?S1BuMHByM3RkYkR3bGhCakdGbEh1M3R1dTQwcDBTWTd6eEVFcjdQUVJUclUz?= =?utf-8?B?MWlFRURpQVQ2S3QyZzB1SHN1ZjlFRDNPQUVUaFpsT1NqaWl2Uk8xbldBZHZR?= =?utf-8?B?cS94L0p5b3Y4ejVObUlrbjhlMXhEbVFhYkZMaUlPUnFaMURJLzgwME5KamJm?= =?utf-8?B?NFdVcXY1SDBVQkw2NzZleVAvUmVDcDRQTXZwR1prOTNZWUhRaW5RUkkxUnZa?= =?utf-8?B?S1hmVGcyNnJsQjNmTkZjUGYwdlN0L2VPVFV2emtRSFRXd1RqMjEzSVRBQ3Fa?= =?utf-8?B?bEw4ZE9lRDl3cHNCbUNqMmJBMmZzQzdYblowa1pBUzljUjdjWk9uK2VPWXBa?= =?utf-8?B?T2YraEQ1cTY0Qzk4cC8xTlhaR1Z3b3JIcmgxNmJza1gxY01JdENNaG9yOUl0?= =?utf-8?B?YWZMeENPSjFRdFlsV1d1OE1EZUVNQUdlM3EzQU9wdFBlNXRwalNUZVc0dHM0?= =?utf-8?B?d3QwbUFETW55SHE0ckNDWmlwc3JKbTB2b3hPOGFZeU92RTB2Z3ZrN0pTMEw1?= =?utf-8?B?dzh5UTNxZjJBaWxTdVIwSjNRc0tFQXJPNnNFOGdxTStLMU1YWldTRlJEYktV?= =?utf-8?B?V3dFaEVsSzY3dW05d0VEa0gzZ3BpNU5GaW54U0tXMkdWS2pZOS9nNm1vKy9a?= =?utf-8?B?SjA0STdKQUNFYVdCRlNvei9xOUZxT2kyRUtBcWxYUHlGYVVMMldBei8rWXJr?= =?utf-8?B?clhpdkUyUmhqeVVLMXFoYmNPMGJ0b2tzS1A5U0s2S3pLN3BJTFVzdlFCVm9E?= =?utf-8?B?N2JqemFiRGc5TXIyMTBlRzYxSnJlL1VscEV6YklwMENobXhsSHlOT2dHNTZa?= =?utf-8?B?L1lnTjVSWXpZT29QODZIS3dNRVFwSm1nQTlDTlRlM21BYjNlTzlnUUY3clRC?= =?utf-8?B?QXFxa3hLUkhVN3V3TlljdE9VSUpaTnBaMnlEcVhzWWdaMXk4MEZnSCtYVUNT?= =?utf-8?B?cjFydjAyVGtpUkpUNEkzM2doZURPOVlhUDhZd1d5MUxXZWN3a1VZOUpJL3pB?= =?utf-8?B?aTN1M1k0d2dHbkplZHpkK1Z4Z0RZaE5VVnlQdXAxZTVDbHZ2RFgxZnVINEFI?= =?utf-8?B?NUkzRlhnNFUyaWpYNFZKWFFRSUNKdEZ5d28rdFBlTEg1aGZidkVmL3RGTFFK?= =?utf-8?B?ZzhkWWxhdHJKV0Q0UW9rV3h6TUdvOXQ4UDJhRXQzMWtNM1I5UT09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb87309a-f392-42bd-f15c-08db97f8ced8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:18:28.4423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EXxXMSIWgLmAYk9F/ZgvrnpU37ucWfpgxoudnwSncBgQWevwJXSLgS2t+aNWtNW54gmys+h0sui26/HotymGYDJF1uscyMFvfkczlQCsWQE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6139 On 08/08/2023 10:46 am, Jan Beulich wrote: > There's no need for every arch to define its own identical copy. If down > the road an arch needs to customize it, we can add #ifndef around the > common #define. > > To be on the safe side build-breakage-wise, change a couple of #include > to the xen/ equivalent. > > Signed-off-by: Jan Beulich Could we find a better place to put this? __read_mostly is just a section.  It's relationship to the cache is only microarchitectural, and is not the same kind of information as the rest of cache.h __ro_after_init is only here because __read_mostly is here, but has absolutely nothing to do with caches whatsoever. If we're cleaning them up, they ought to live elsewhere. ~Andre From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:27:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:27:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579573.907602 (Exim 4.92) (envelope-from ) id 1qTJwH-0004aQ-TL; Tue, 08 Aug 2023 10:27:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579573.907602; Tue, 08 Aug 2023 10:27:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJwH-0004aJ-QJ; Tue, 08 Aug 2023 10:27:45 +0000 Received: by outflank-mailman (input) for mailman id 579573; Tue, 08 Aug 2023 10:27:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTJwG-0004aD-SD for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:27:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0600.outbound.protection.outlook.com [2a01:111:f400:fe0c::600]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34863260-35d6-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:27:43 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8263.eurprd04.prod.outlook.com (2603:10a6:20b:3f9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:27:39 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 10:27:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34863260-35d6-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j1MPDeyYi4+5zCex9lGXDobjwUvlloBn/fKQ+Gi1ZwLZjU4KTEK0QiES2VaWEKL3qbkTvkEnm/Y9PDI9sdKkyeJGNzwjWAgMncyyTMDjd9keCqHNrlIB3pR8iKEpiYdnipsaJNVKN/TB2dNWj29YUx2b/EPPAAw6MAWq8FaVtRlW6NWVzTsMUrTBo80zd6mZ94KBRLu+qElQRNIe6PrDhALelLgSVFdhmYseLhdBmjVH6z7vmkGXR/HmnoS3gsyRJNKjUuC2tIP9bFbAFl3ZdlYREYq6XTmGLPH1niRCnKLrGj+fUYmlhmA2Y+MeNjtrs5Faqw/E4oOJubd5pYIHVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0017iN4hQj/VyiDseYwsrRDB1EjpFC20roEf6xPZg0=; b=gT8NZ8hvx01WqdW3iGe37kaOpIPOsdkRDh9/0x/QrEo2Kd7VWLnNcmeZD3d0osZeh8jUdvqBtAhGKEfsqEhoCXWZTGa18SfYdSgK9Tlvoq3nJGyFKT1vktFsHuzqjdXO0mcJCQgkAToTkSk7eyS8f9ZDehh0RYhSabsZayrZPp3tpldTym37xaBzEUO0oJb3fsc336gCSyF7hLE/xRrQK5SQqDisldJTDL8ntItgYwnLEcNiDWfoeUmmPUqN8qQM5/bkrlrtKC0wb9CgkntoR8g7Vv0siB52HQ33v8+lixoZTcGfuvrUsLOPlmEuXol70o1KXt1krmT4PkknSp9rHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0017iN4hQj/VyiDseYwsrRDB1EjpFC20roEf6xPZg0=; b=AihQ3wl64AGg3KAPpB0Mp7XdUla6QuDb2VfEncfy+hYUUvFqae94H4RvYsHw+gh3NmUMQ40J0D3mvRSDDPjYxn2IoE9sKJ0BItNLTEuY5DeR2zyAt83Xm9ZmFn/6nlX4/QlNa/2RxP/Va+FMgR4XjcpwDRAGw3D7Rk3FYFTSm64H9F2qfoRZd5rbCkr+GzGDRmw2aVE8k1CL/gMoJeVfgs34h3UAcpG3kzLGKll7kgS31SxkdECzGRemOdNlYOssmbhzI6YdPAKBQ4a9IvV7Jix2Hp24txxd3ku7QnoXwu1j3Q5kFKNwjSFCjJUtYkIJV+W6db1gmf84sQRP0tGgKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1866073f-9611-f5bb-9b5b-05ad463650e6@suse.com> Date: Tue, 8 Aug 2023 12:27:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <2702cfa486aa92e82fccd6393519073f10f4c40c.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <2702cfa486aa92e82fccd6393519073f10f4c40c.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8263:EE_ X-MS-Office365-Filtering-Correlation-Id: 42b18577-063a-43b8-9033-08db97fa1761 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nvwHSsvINKNWxMgo1YMbtUVay7vBslXAKvusBVimJsbbCpH/D5UbqyWAJHlzZvwlpqlMnA+k+lvc/xbr9+8I0ktOY4rVyhX4sQG8oVdRjcLxkF2i3BPAoKPqhH4DHNWwIPgxxPSMfV9VDnsm9KDlsxvUyHFcvBC5PSlh6ISw91A1gU+7H55UIH27QIysTJR65RQym212gowCGIbZ1Pg3V86rTTZ1Ium0dKQLUCmZS6gbYhu04sPqAzGMvv+f/0M+eMnbhA7Gq6aRdiPCixfInd/7E0QhdRCcwdVCYMQD50jfbtYBf/AewTmb91uOvgErb0Spl54emUFhq70YiymgrgGKboMB7pQ5yEQ5FdLkzgegIeOV8GzCZcVnp+9jluxABJGRQA1z0eJg/5slYaTKRwWFy5ccPMkQTaTq12wuwNAC5IaTYOpdsHbv/5sFLbTQYaL7VGj4AetSJUfVkcRBynIjox9iPbgqTGnhNcW+wfRVBuEutyt+i5Uxnj+oveTlqaNgeWx6EzukUTNNz9YWwpWX430cmWxILgVe7fMagpwRz7tf68o0xbB1kmJBt5RvJMe+kxusVlH8b6Dkx1yzn4zOXvSbk0iHMO7DqkT9CphTFoUVw77ULvgVx1oLcrdFioGJyA1zYXTKiZWWBnyrZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(366004)(346002)(376002)(396003)(186006)(1800799003)(451199021)(2616005)(53546011)(26005)(6506007)(6512007)(6486002)(31686004)(478600001)(54906003)(38100700002)(36756003)(66946007)(66476007)(66556008)(4326008)(6916009)(316002)(41300700001)(8676002)(8936002)(5660300002)(2906002)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlFtYWFiQ2xncWUvK2ZtUUMrajZvMituaDB1QlJHMjVzVVl1OWVTWWJFMXhR?= =?utf-8?B?SmxMKzh3YklJdDlkOXd1Sk1HcTN0a1NjcUlNcHdIcnA0bTZHVHVXMGUzeElm?= =?utf-8?B?M25YbENndzBreitNdDZXQlRGcDhqUEN6UmdlRVpmOEo1TXZ2bWNVbTlNeHBr?= =?utf-8?B?ejZWeUlXOG9oS29OMW9pbVFRK0dqTzhKekJJMndaa2RBcjRldEYrS2x1KzJY?= =?utf-8?B?MHJYbFA3UCtFUVRGRVRQdXNKbFlUODJvN3NyOGNpSGg0NjhpVVlCcTd3UGw0?= =?utf-8?B?ek1WeTJUK2hCQ05GejF0YlVpRDVVQVcvYjBBNTZMLzdURXdDaTN3NW9HUzR6?= =?utf-8?B?NHh2dUFxdUxjbG1kWmdPTFJPOGoxMWhNdHlyc3o0b083NmhaOUEza2NzUFJ0?= =?utf-8?B?Z2xzTE5ZSkR6ODRhdmRhUGpFUmUzUWlaUDVZbTdHTnhhTCt1ZHVyeCtRekVT?= =?utf-8?B?RlVhMUNBV2dyckN1UkZFSWxhNWxvMXhDWmk5ZkFBOWk4MFlDaHN0dHh0Um5p?= =?utf-8?B?R2x6Tk9ocFVIM2U2dVFUMWx0UEhMK05mNlBYNGdHQkV3YnFOd2hSUzhaU21s?= =?utf-8?B?LzlJaHIvTXFET3JLZE1TRDBnMVRudS9wMFBHUUtOanZhVFVtVlRQd2hSNHYr?= =?utf-8?B?aE9YV2xSZ1NVVGxZOVN3dVIzRSt2WmhZbEpvT0R3RE56dWU0d0R0dVJHNWhl?= =?utf-8?B?N25iUWtocXdJRXBYVmlPbmNieGdzakplTWZKTG9hZGwwYzUwWWpBSUJKQ1d5?= =?utf-8?B?dmw2L2NvcEg3T2tOZ0hSaW5pZ1VScVJWY25RWnNhZ0RvRkNOR2hDSnVQR28x?= =?utf-8?B?UXBmaTNHM1REa2txYzFVODFMaU5YQ1YxL0lnM3p1NnNwTjhvMWtyRVVzcm83?= =?utf-8?B?TmhKZGNkVkpkcWF6Y0srY0NtZ2JyMDFDSXlZUDNnSDRyZFJja0I4NzVtSDZ4?= =?utf-8?B?MUYzeGViNVBRblpCeXlCeVdXRzBXUlRqS0w5SmVjL1FPZDlDRndGakpmMWFW?= =?utf-8?B?YktPM2pOZzZYS1RibHg1Sld2dk9nMTE0ZHlOeEppNlh3L1ZiL2xFdEsrNUE5?= =?utf-8?B?RnZDWnNtQ2R2MWxRTkh5S0Nib09lUFMwZ2pBeUJTNFFhU2Vvc0lzaHg2UHNW?= =?utf-8?B?NFVIYnFNTXl6eUZiYkFlbXI2Y3lNalhBNWZKWGJ3TnVWMDZXUUNOZ3d4Yzdq?= =?utf-8?B?NkNpcWRZdlBxQVRUQVp2aGxZbU1XallYbVhwOUt6MEF1WmhSOFR6Z0JwUHE2?= =?utf-8?B?YXFndnovM0tJK1BZdncxK1NXQ2txSXg0Si9oZVQ5MHYvUldBM0R5UlUwZ1Jl?= =?utf-8?B?U0k3dTJTRWJCUlloeDNmSnJtU1oyRnloZkphVjVQRStScSthamFPS0MwSDJU?= =?utf-8?B?QTdBSFU3SlE4aDZzTWpDVzRJZE5OdjkrMXIzNEFseEhQdE9zcVU0LzhvWTVZ?= =?utf-8?B?MXliMlh0TDVvVVMyVXhub2h3aWM0K3ZWZ1JQaXNvK3haQzlVZS9NSitWN1l5?= =?utf-8?B?TWZIY1B1VFBRR2lEaHAyOTR4RVRyMjZkVHhZZC82aXJCSWxEdHhXL2VwcXFw?= =?utf-8?B?L1l3MG9JNkhFM3JoU1FtL2xrNDF4QW5lT0Y0eHNBMlpZVUQ2NGpLTTg1Rldq?= =?utf-8?B?cDFYdTVVKzRXTHpsS3RmblR3TGFoK1dnaVpjM29VMlp4U3h5bGVkc0J2UVVX?= =?utf-8?B?aGRaZ09QdlRCaWVWTk1vdHNQanBYaStOY0VtSzc4Zis2Q1hIOEViQU16eTNM?= =?utf-8?B?YURoRmRkU0dubWlkbVJDWFFuUWhiY3B6QTJlZXJWVnRHNENKanNjZFVSUGU1?= =?utf-8?B?NTUyWWh4V1R4aTdUWm5rRlBPdG5RN0MxZStPSnFTeHBMNE44cEM0R2VML21q?= =?utf-8?B?TTdjbDVPV3ZQdWdUQ0VTSmRoaTVZd3FIcVpWSi9aK0RsZVlXcHczUjBFSFNT?= =?utf-8?B?ZGNVVFJVM0lqajE0UXlMZS8xbGVVTG9nMjVxR0R1eG9rckowUDFnbVBNMjc4?= =?utf-8?B?WXZvY1lWVXpDMHltOUpJeWdJSnhIc0RDZDl6TVc1WWxqLytDZytBTGoxOVl5?= =?utf-8?B?K2hsVnU0emU5b25Ld0RSSkRoM3VrM0tHYTV0c2xXajZUZVFEKzJFeUltR0tH?= =?utf-8?Q?pd3CD49EQPbtoUZVTf92/f1GO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42b18577-063a-43b8-9033-08db97fa1761 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:27:39.4350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d5dRuTJaAytLjsZ7B0zUemRupofuwLRs5rtw27I+HraSMNNPd+9LBDEZmJRBjW07vrlIHWqcyEH89xkdHOJthw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8263 On 03.08.2023 01:03, Shawn Anastasio wrote: > --- a/xen/arch/ppc/mm-radix.c > +++ b/xen/arch/ppc/mm-radix.c > @@ -266,3 +266,47 @@ void __init setup_initial_pagetables(void) > /* Turn on the MMU */ > enable_mmu(); > } > + > + Nit: No double blank lines please. > +/* > + * TODO: Implement the functions below > + */ > +unsigned long total_pages; Hmm, yet one more prereq patch for me to make: There should be no need for every arch to have a definition, when common code requires the variable. While looking there I found max_page, which common code references as well. I'm surprised you get away without. I guess I'll learn why that is when making the patch moving both. > +unsigned long frametable_base_pdx __read_mostly; While we still have many instances like this, we prefer this form: unsigned long __read_mostly frametable_base_pdx; > + > +void put_page(struct page_info *p) > +{ > + BUG(); > +} > + > +void arch_dump_shared_mem_info(void) > +{ > + BUG(); > +} And perhaps one further prereq patch to avoid the need for this. > +int xenmem_add_to_physmap_one(struct domain *d, > + unsigned int space, > + union add_to_physmap_extra extra, > + unsigned long idx, > + gfn_t gfn) > +{ > + BUG(); > +} > + > +int destroy_xen_mappings(unsigned long s, unsigned long e) > +{ > + BUG(); > +} > + > +int map_pages_to_xen(unsigned long virt, > + mfn_t mfn, > + unsigned long nr_mfns, > + unsigned int flags) There's a patch in flight regarding the naming of this last parameter. I guess PPC would best be in sync right away. > --- a/xen/arch/ppc/setup.c > +++ b/xen/arch/ppc/setup.c > @@ -1,5 +1,8 @@ > /* SPDX-License-Identifier: GPL-2.0-or-later */ > +#include > #include > +#include > +#include > #include > #include > #include There's no need for xen/lib.h to come ahead of xen/init.h, is there? > --- /dev/null > +++ b/xen/arch/ppc/stubs.c > @@ -0,0 +1,351 @@ >[...] > +static void ack_none(struct irq_desc *irq) > +{ > + BUG(); > +} > + > +static void end_none(struct irq_desc *irq) > +{ > + BUG(); > +} > + > +hw_irq_controller no_irq_type = { > + .typename = "none", > + .startup = irq_startup_none, > + .shutdown = irq_shutdown_none, > + .enable = irq_enable_none, > + .disable = irq_disable_none, > + .ack = ack_none, > + .end = end_none > +}; I would recommend to avoid filling pointers (and hence having private hook functions) where it's not clear whether they'll be required. "end", for example, is an optional hook on x86. Iirc common code doesn't use any of the hooks. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:33:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:33:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579579.907612 (Exim 4.92) (envelope-from ) id 1qTK1K-00061d-FG; Tue, 08 Aug 2023 10:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579579.907612; Tue, 08 Aug 2023 10:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK1K-00061W-Bv; Tue, 08 Aug 2023 10:32:58 +0000 Received: by outflank-mailman (input) for mailman id 579579; Tue, 08 Aug 2023 10:32:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK1I-00061Q-TS for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:32:56 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20622.outbound.protection.outlook.com [2a01:111:f400:fe1a::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efa85691-35d6-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:32:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8628.eurprd04.prod.outlook.com (2603:10a6:20b:42b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:32:54 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 10:32:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efa85691-35d6-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWLtjisE9QzbfTYXaigkyWZvWAPFo7vt+951Py5m7vA9s1niWpVgjHIWGxJlkwl5t6SLhrBos6vtaQocQNayg1cg/WhE0779D1DJrKHWmdNAOTwe2qOHmwgQ0Lq3N7f3cwMhA7Gxut1Ps7r0uUwaeTrtSHf3D0eDgRsdrmu5kGEMkKhoNla1JW2BsYym4bYgSl4k6RTlz8nek39WpJwOfMCblX2eoOgkxxVUSw6vhPqlzoMu6G5CAbiN195CQzZM9SMlim9I3Js0eXNQ707RcHz55VIgI6BSjow5t5eiSdweP6yCrFcuUS2misi/RnCPY0KltfDPxC3UlvuSDOFGAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQ7m4npKV+BARwzs3twm21xAb/EAsWBaVN1ShDwcHkk=; b=dHHBz47F+ALlJ+HFpqlmwH7GEttjYEf2tHzmZeyL2qHXCok6auGh6Ep5rV4VxXMcd9No13UZj3WVNE882rT+HMesEshWca4KEpO0Z+dEH8NKQkBaQ68ecnJQMIiE93tRfLp1OdWgcPTeVcz+ndEYKuoEo1ODzg1mg6EoQfh+hXjg2PbLwFWldpn/C05pWdj8Pp9J+TcY2jXALeaDJbTLghjgIHqKSAAhi4nLZaUzGvMUeCMmAztsqWAJBNkE5SzimMPllJXwW3IGHeQ0PmpF/emQmVX1nKDun5cEIKFTGZ16HbUrYT7MnRfXg8oqMYYJf3tC8pV4YIku7Uz4YNyqig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQ7m4npKV+BARwzs3twm21xAb/EAsWBaVN1ShDwcHkk=; b=P2M13sITPzHQaY5oeCogIp0O40g1I6eKLms+pqvQ/AxYlD+ow+39rhPQuSPneGY8hs98cuNCjE0DZ3VvnrINE4QZN2r8Cw7ZSmrvqC5oxXZP03W/G3ewOm+Tks6iA2qZE2yjmJ106MMusXE8cr/rIqjSFFe/7n+8+agtqDu00iITtfscxFI2xv9cp5Re5c/QT3hjF82NtnBgdMUwlG4tyl/2PDuJm8igKuhKpUUBxzN2Jm2eyksGJukWpzcUglt/qhxM9Ci1NTkqdk830xmCdA48Gu4MgPSI+oVJZity/Bsnsdf1F97zO+NIvq1ZOAVJqmhz6/h8wEyoqf02g8Owcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <893a5ebf-54e2-f2b2-1365-2a6d36ed3a39@suse.com> Date: Tue, 8 Aug 2023 12:32:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] move __read_mostly to xen/cache.h Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0203.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8628:EE_ X-MS-Office365-Filtering-Correlation-Id: 0777078e-942f-4f02-0783-08db97fad2fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ubaMNxoinWtD0+L5sMr4cq9s0lfhRGT0+hDoIAMLiBBE8GvYgggpqZmTDU5ZBHgI+UGKL5ejQVjA9Xd89fSUNGFYugumvd6mngZHUKusj19hxKaD2yZHO7yNWCXnLSsw2OzjJn1c3d3hxzSwG2nZZvi1D3RBWRCMyVQFR6YwiYSsS1WNXtmqUN49YcxSV8VnozAwy4Hr+/r8cdHonu6Q3G9UoNssRrVIZCOT1uzry2BbXDgKFGa+gomH7LPDENErMhGiHnX5yDvul8/ViDkZbQmbRXybFzJISPjHbXRl9+WkdZT/CYfu5yk7vA445K5iM5zjfGOq4vU1wUxMdp2KVKspKOphSg3/8BaO9k4cr5HGuAxd8OCWIjcyFnibEJVE9UbCZbondnrOTd6v8QP2AULIpjr0e2bY9qn+JDe6ILB40qzuVGYp/pg25AXvtt7q4BofAiOSwcLUAQ1/MSw6lr7xbedp3oT1GuKCdBQCddwjL7pyexNtEqK7OFj7dY7OTzLsaMU73sMlPgGMHnoeCGRztEI9sPjACndomY/l2mC+Jthsun02SWBAKnC7ZyWF2DZZJUBqGIMdQeAQMeL3AqgWS6pQykmau1++xBRqpCxzS1bwQriM3812G4hHt8TmlU654yheL+ObmIydz8dcGw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199021)(186006)(1800799003)(7416002)(8676002)(8936002)(5660300002)(4326008)(6916009)(66899021)(41300700001)(316002)(83380400001)(86362001)(31696002)(2906002)(6486002)(6512007)(6666004)(2616005)(53546011)(6506007)(26005)(36756003)(66476007)(66556008)(66946007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2Fva1VGL3R4eThlS2xpK0lCajcxMHpCQmFoVGF4enVEV1pNa0JUQ3NoWndV?= =?utf-8?B?aWRGMjllWUhtVHhMM2wrNnArQURIR1orYU5DRmxBbkpsUXVsbFNhNUtQSkRu?= =?utf-8?B?a1VUbEMrd0pkZEFrc3RxaDZFR0RvT2FiNi9XZS8wTjMzb0krUkN1Vmg3Ui82?= =?utf-8?B?TldLY0syUnJZNitHOVU5NnlFZk9oTWpESjcwU0ZLNGhwOEQ4MDlDUm5IZjlC?= =?utf-8?B?VXQ1S1p5TEl1K0hPdUw5Q202MTBmYjNWVElxQlFMd2h2Z2E1U0dLZkZlWHUy?= =?utf-8?B?amRpNFZocWowc2tJaHNrUGFkY3hQMWxqM0Z4K1Zpd2NoVXFDZ2tvWm94QWxl?= =?utf-8?B?MHc4L1ltR0lhYWxRV2dCdUFkRHBpeHRValJSMi9UR1E4clhJTUVESnJFejlj?= =?utf-8?B?MFpjT2hpaVdRSXJnT2lSOFVicGN0UEx2OTljbEpsd2pRK2VUeWd5Q1FlTGx1?= =?utf-8?B?V3FndExSVzczQWRSN0YwalhxRmZlNkxBR0Z0WW1VQ0c4ejhraFZDMEFBdXVG?= =?utf-8?B?QzN3NTl0dU84MTZ1ejA0dmwzZ0lpVlZoaFBoUkZEYkRkL3FscDV4UmhTalVz?= =?utf-8?B?OGRJYmpERGVIWGtqeDZFMnpRY2g0NHI3MzdJU08ydnBQbm9zbWk5eis0SCt6?= =?utf-8?B?em1lbklKdnN3UVQzM3JrdXdVMkRoZ2dDL2dNTUhNNXRnR1Q4UEM4ZkoyVjVo?= =?utf-8?B?NDVIS1BoYjZadnBiMnRlOVU5YnRaMWNpdEtlejl3b0ErSVd1Y1BVUkVaVisr?= =?utf-8?B?TE9GaUwzMnNtK2wrMThjemJTQUNrSGNxTWpsWG5HUVM1dkY5WWZncTlpaDVi?= =?utf-8?B?WmxiVzRNL3BqSVEzZEh2dVFxSlpxSE1qb1Fya0lUdi9yRjBQS2JFM1JTVEZa?= =?utf-8?B?WDlpL0ZHSW5aazlGc3o4OS9WQ1NQT0ZQSjEycU5HU0RveFZ2eDdOWkdnc0dN?= =?utf-8?B?MDdjNkNxbElnbzJIL01UZHQ2YkxVc2dRamhxRGJQbm1Ua2w1bUpRL0FiaU9W?= =?utf-8?B?bkdpRXJCeGVYbGZ0b3NoR01OUW1OZ0RlVUtvaTNEb29RZy9yR3diaGlUSnd3?= =?utf-8?B?NUxKOHpaRU9TVFA5anpWK21TVjN5RTFiS1hmb203RWZkL3Z0RGl0emwwWVkz?= =?utf-8?B?WU9lWnYzclJaR2NRRmVwMGZGQUpsVE5pM1BPVmFnb1J6a00zSmJaMi9QQUxu?= =?utf-8?B?VU5FY0swZHdsMnkrNDV0akRzOGNhZS9zeE0xSERlTnNqWE43VElPR2Y1NnQ3?= =?utf-8?B?WE9XY0NBTkpVV3BwRmxwcUhnNGNxS1d6b0tsY2NGSW1rUy8yV1lMUWlFdjBr?= =?utf-8?B?NTlKNnVHQ2VtVTNGV1FqZ01zc1FlKzBqMTcvVXY0d0xzbGw2OXdJYjZqWDJK?= =?utf-8?B?UUp4aDRYUmN6ZUJMZWpNUlh4WDgza1J3ZU9MYjJjV3ZmNWpXRDY1d0xGQ2Rl?= =?utf-8?B?c3N4dmduTEJROGo2R2M3YnVxWXo1L3k3bi9pWEs2MFNzZENoUGZPbW9xeklt?= =?utf-8?B?U2FnNERUdEczMUREdERNVHJWTGh2Z21jcldqdndFWGJ3RnJNaUZuVzBEZkpU?= =?utf-8?B?WmM3UUM4elNHSU5zTFpVbzBYakExaGp5TFY2bHNOanJtSEFRcEtrd09uSldp?= =?utf-8?B?RDRHRDJlQlE3VjlRMml1NmRGb1ZSU2Y2WVMvZ1VxV3E2NXlITzd4OTFVdC93?= =?utf-8?B?OEt6T0FFTlE0WG1SVlJwK0VodFZNQTlrOTRlZmJjdVVQVWh6clpzWlNhWG5F?= =?utf-8?B?b2dyWkkyWk1xNGlyWkxRUVZrS3BJSk5hWWx0a2xzekovNXBCKzBPWHVZTjNB?= =?utf-8?B?ZXdsV2VYOFpUZ1d0TWY4cU9pSDJIOTN5Tmlvcll1b04ycWJrZ0pUM1RJUlNw?= =?utf-8?B?bUV3RDAzdGVqRFI5UW9ENks5TzRpN1hLMGFTd2ZOQTl2ZlZRZTg5T3daTzBH?= =?utf-8?B?RFRwdUpLRWlGb3IxVXVnY09wVkVaRUNLQU5Rd1dxNjY3RkVxNXkxb2pmWjJX?= =?utf-8?B?SXRQcm1PRWdRZUw4QVFCVlpseTJtdDd0c2hDUHdkNTNWU3JoNDB6bHZ1U0Zq?= =?utf-8?B?aXY3bER2UVlXVE9qcStKOEZ0aTZMV0tJWVJMbDcxV1p3djhpWklwLzk0T0FT?= =?utf-8?Q?2uWqM/yAmmeEWDlSStLZaSWcY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0777078e-942f-4f02-0783-08db97fad2fb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:32:54.1553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QwNyARLtouYthPasnM9chiuXBX6hpUxKi6vElKv0jKGtI91XolHctt2NfUCdkzS3ulsTjLvwJwSBA+Skrj9L+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8628 On 08.08.2023 12:18, Andrew Cooper wrote: > On 08/08/2023 10:46 am, Jan Beulich wrote: >> There's no need for every arch to define its own identical copy. If down >> the road an arch needs to customize it, we can add #ifndef around the >> common #define. >> >> To be on the safe side build-breakage-wise, change a couple of #include >> to the xen/ equivalent. >> >> Signed-off-by: Jan Beulich > > Could we find a better place to put this? > > __read_mostly is just a section.  It's relationship to the cache is only > microarchitectural, and is not the same kind of information as the rest > of cache.h > > __ro_after_init is only here because __read_mostly is here, but has > absolutely nothing to do with caches whatsoever. > > If we're cleaning them up, they ought to live elsewhere. I would be considering init.h (for having most other __section() uses, and for also needing __read_mostly), but that's not a great place to put these either. In fact I see less connection there than for cache.h. So the primary need is a good suggestion (I'm hesitant to suggest to introduce section.h just for this). In the absence of this, can we perhaps deal with this in a 2nd step, thus not blocking this patch and therefore not needing to then also clean up PPC-specific code? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:35:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:35:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579585.907622 (Exim 4.92) (envelope-from ) id 1qTK3b-0006fd-VO; Tue, 08 Aug 2023 10:35:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579585.907622; Tue, 08 Aug 2023 10:35:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK3b-0006fW-SV; Tue, 08 Aug 2023 10:35:19 +0000 Received: by outflank-mailman (input) for mailman id 579585; Tue, 08 Aug 2023 10:35:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK3a-0006fM-Di for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:35:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2060f.outbound.protection.outlook.com [2a01:111:f400:7e1b::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44340661-35d7-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:35:17 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8628.eurprd04.prod.outlook.com (2603:10a6:20b:42b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:35:16 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 10:35:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44340661-35d7-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g4lwwanTZjhL/RzXv3lqfonBzM1SHMK1c0Tdd5uRbW/sN30h1cNkrIVEa4m2U2L71n4Hj+/WQXhRja/3bFxOZL7Jwej3sJcfZ5LT1wLuZzWuOADCZA4QfuNkNMvIxww0ldQ8D0RG8qcl2aDz1SEnK0oaGZYqNVFWHMVS4ATWJ+wND7+sfjwOmxgTH9wXxVBiL2+o+aCX5dKEBD9vMQzOlDiphJa6B4hIrvi8JJmpsMZYMwMuaxQkY0UgCz794xKg3UtDJzGGsBJ0oyjEDyhTJ3vop6uT9Ej4R3KM8g+NM0cMdxbqTDA+Txv7UiXgra4pjOOD9PT1s1l4tfXfDd4ovA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DlJ3WM6FvUIkZY0BuNVxuiXNNnSEQhgfB4Uyx14ToyY=; b=MuM0pIQcNHB+JehZWIKS2nUvv5KjwtLWeSfSeeuCJmwZIbQQ26+uziSKT7ICXt5NpZjCOnKKD8ymQxDc57aO0/9kCuy4Ovue24oE/+OjbtMlgVdZAaEuPhswMbDEAO3TN3EJId00eX+QZ1rTTKTrk3di7Lqfe1eCptSoq4Qx0u0JUpVXAgZnTKW9VP5I7R0x/ZDSZ8ue4f3Ko4Ic0hiYbVsqtrv44204+8IBcjuSlGOVs/v2iU3jjTsXAiJhdpQfN+p8eP1tJOQRKHjbi/z/pzyBaPcxl34Uq/E+FqGMBs0sNvWtmBfaL7WcZCC1JmEx5idGYBLFjomWmqz22qBMoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DlJ3WM6FvUIkZY0BuNVxuiXNNnSEQhgfB4Uyx14ToyY=; b=t4FX7hjHiui+CI1B6RKe1CE79rsVJ3Ztp8j3/HVs+y5Hp6KnR2ZWVwHeHy9QEL+WENE5/k3RUv/br3Xw5zu8r3yytOeTOtwcIraeqow1kQfL8FqkEo+fY84u8R52GJBJX28bRoYwX5BWd2ugp/NOXNutB54ak9Jv7Z0vStfE8iNV3t1OwAGlAf660Svd8Y/rIMn6zsREaAfFTAimlrG0jg5P3BE6iIUOzanvzt4sF2sHMmGMlextepGQ8Uxo01/ff8MW/Ho1OyLS/XYVMuuugE/nrMJHGIAkW8TiuFkF8lHAm72Gu5BlWxZV2adAhkKY9PMS5GXmLrPl6+ELdAJsfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <077004b0-4938-ed87-81a1-9071f80f61e4@suse.com> Date: Tue, 8 Aug 2023 12:35:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] move __read_mostly to xen/cache.h Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio , "xen-devel@lists.xenproject.org" References: <893a5ebf-54e2-f2b2-1365-2a6d36ed3a39@suse.com> In-Reply-To: <893a5ebf-54e2-f2b2-1365-2a6d36ed3a39@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0184.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8628:EE_ X-MS-Office365-Filtering-Correlation-Id: adf9793d-ca8f-4623-0347-08db97fb27b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gnxBuYGbOzyPNNaYH40+o5mOYaM7nnAl5e0rZCaP2A5DGOhAt6gQ4dWCDWewk3/YRlFU4lZlcnHldW9yxFp2EgGoY6Vfv8IbNWvkSDUTgDzFciJ6xflK6fOpQGhPnIcEizj6ufkvUBsY7y5y1gKQmvPYa8thdLOEwWBFUoXe2JNlRGchSZeH5kiYop33OxcpjNKIkuoTN+tISB4m7qRomPsGRotc7U/Nj0sqax7+vcCdDOze6j24Pgkx/WsEK3PoBQyxlg/J3qNnhgqhr8T2ai6R2kjf3OM/UYegDxTyU+9vgw53kgVpXCfkj/NHkMfmcyJcmVuoVCHHBW1nI+abIzDpioD5HGSGWSC58fZy5mOeZWkm1si1kO0NwbiS9FYdHsTSOnE3UumoTGVLgPuZtDLyZrJKb77fL4MvTWCPfq8ihntasH1mfD1qlKxmaBwMESJozOsK+lRAWzstgIGW+DwO9uhJUpv2qQWxx1PU/3tyvVCiWbTJ0xdWR0sUYTh2An3dy+65HihbUO+K61gmalcEG8cRdz5e5EIySupW84jvavwgV+VZQb7HJx1GVSrSnPasjhlLDlAL4QYkgebhbLZ/BO9AU5HHScbAJpFR5DFMshhHSjEcsxLbH1Ju6fhT3MWUdXBuzvNkb0kSi+ELSA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199021)(186006)(1800799003)(7416002)(8676002)(8936002)(5660300002)(4326008)(6916009)(66899021)(41300700001)(316002)(83380400001)(86362001)(31696002)(2906002)(6486002)(6512007)(6666004)(2616005)(53546011)(6506007)(26005)(36756003)(66476007)(66556008)(66946007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2d4U2hOZHJ0bGhDTkNvVDdCUExjZER5ODV3Yk1kZUk4ZldIKzlSZEVXUXNW?= =?utf-8?B?MFl1VkxMUDlPa3B3Z3hmbzZmdUdlWjhPQUkxY3NmamZRUDg2Ky9KNGNkZXg4?= =?utf-8?B?YlNDbXVxR1dHZEhOaTVFdVZCcHNpdGlBcUtYT0NuUUwvOFNqWmRoakkxYTVB?= =?utf-8?B?R0tCbGxVZnRaMHJ0ZGtHTFVUVE10a3psMlJ1dFR1Q1hxalJhR1N1eFlxMDE4?= =?utf-8?B?dHJVelI1eHFqSHVGRGNRTkt2ejFEcHREejgzSURDNEpLblgvRWdCYkZCVGFl?= =?utf-8?B?NG8yMVI2NnluM2c2RitLWjZ1Mm93aDdDckdjUEVqRnBUSCs1Z1hKd05vWmVH?= =?utf-8?B?bmdEY0E2ZDJ6bUNlNTYvWmM4TjRkaW13dVZ0aExIV1c3bUU5eExpTjZXZkdP?= =?utf-8?B?VG80WXpjbDNlTEFMUCtablBocjNZeE54TFd4V0piVUdJditneElzYjQ4SENL?= =?utf-8?B?a2VZMWgvSUp6NUtKODVTbSs5dS9pLzRSd092YkVsczNFT2tDV25wd0d6Z3c4?= =?utf-8?B?YmQ4cHBYckUvdkRzanFOQ0UxbTRtYTJOanJoUEt5Zlh6MzNITWFtNnZyeW1X?= =?utf-8?B?R2xoT0tncUIzWXFleTNJY2pUYjl4Y1lyNWc0YzgrNHRDU1JQUGJSZklzUnJH?= =?utf-8?B?aW16ZytDcFR5NWluUkwwcDRCbWVnOHoxZENzdVk4QUM1MHNDVTk2YmgyZ2tJ?= =?utf-8?B?N3lhTk1JUXhodE1lV1ZMMTROK2tvdXpIN1ErRTJxWTlRcXFHdkp4RDM2NzhF?= =?utf-8?B?VDFhT3BVU3JsZDdHcndMLzVQd3lwTnErVU1EMUNKcUhLZE5iREJJNVpQWFly?= =?utf-8?B?cXViTmxiZkZiT2RSZklvQ04rb2RyYzIrbUJ0WUFzWjhXa0FTb3RabGZiZnBp?= =?utf-8?B?TjJDSHQwb3d1RzR3bTdlY1g5Z0tKQVNMOUdzbnBTaVdQR1JLNkV6T2FRcjR3?= =?utf-8?B?ZGt2SUN0Q1JnL2hvZXpVTEVhVGRlQXQxcU55b0pCK3VoNUl0SVRSUGY3dnRr?= =?utf-8?B?RW1KUVVJSUlHWUdmcTB3ZjE1dDM4MC9Nd0JZMXpwbXNmeFJreWVZdjdna2dp?= =?utf-8?B?T0U0U0VTMHpKb3JvWmtlRGs2OGk4QmxxVXVvZlBXSWZHc0dIM1lMbkFnaFZG?= =?utf-8?B?VDBldDNheSs0RU5VWWtqTHE4RHpNSlZpa0FzN2Y0SEt1MHhpd3haNmNiQk5m?= =?utf-8?B?U28yYjJFZncxeFV3YndUdTV3VmZBaUZoY2V0Q0tBdjZuUVhSd1NlZXhYTXBh?= =?utf-8?B?Y0VLMjZ4Z09rS2NSeXM5OVJVU2l5elVFWmE1eEhNVU44V1BNYVpmdXJITDRv?= =?utf-8?B?MnpkOGJBbmNTRVh5SndEdmZNcVpIQWg5cnRlY1JvRjB0L253djhHaG9ZcG13?= =?utf-8?B?MkdDblVPTUY3WE9UT0NFQ0xpaFM3MHRmYzlUcGUrMEhVbXBoOUI5OEJweDVY?= =?utf-8?B?TEs1QUZCZDN5QVNmMFV1NXdtQU5pYW9Zc1dkd3VudkdhcmFVMk55T0h1cXlj?= =?utf-8?B?QlpLOFNCQW5LVVR3L21xMFNWbFVOR2Rzb2V5eTBoR1EwaHF3T2hXelZHNk9h?= =?utf-8?B?bk9lTTZKNDZVVmZMeEQ5T0k2dlVEWmJ5K3BjdEVHTDlqTVEwV2VYV3JXTGNQ?= =?utf-8?B?dHo2ZDRXV1I5TzBxYVltRE9sV2RjRFBSRzBOSWVwb2lKK2ZHNzlVT2d5c0Jr?= =?utf-8?B?MUhRTDN1aG84QjkzbDYvS2lRenRrKzl4TzJENW1yVGQzTW5ZWHpwY1BEMm85?= =?utf-8?B?QUNDbWpaY2F2YjNleFhJUUhPRlFjVDhlUStTeFRPcVErRUZQWHJna2thRkJF?= =?utf-8?B?YTFwYXNxeklPOXVsd0xNa2NuaUUwSmswQzZYYm9xcWJXNFp2SWxCY2QwbjZR?= =?utf-8?B?WFFqUVE3cEFYRWc0TnJXeWU5ZW5DMWh3VnJaV1lrZis2ckh5MHpibUFEOWk5?= =?utf-8?B?MG1wenJoVy8vQXAyQXZlTTZxM0lQSTMxZ2pva2xDZisxTkNld0xZSlZpRStZ?= =?utf-8?B?QnYvUlBQazk0Zk5TQVVlZmZoQmt6RkFoNllKTTVDQnFCd1pkSUtkaVl0UnVh?= =?utf-8?B?ZVRnMUo2a0NTYXdGSVZocTFLMU41WGlnVFliZHpNL003TTFJdGZYcm5LT3Va?= =?utf-8?Q?mYV3Sx5SxRPGyjtjdVeSoWExH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: adf9793d-ca8f-4623-0347-08db97fb27b0 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:35:16.2652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4noygbaSha2XcaPhwE1/pzQ7h68DPZVmjZzyHXiPnG1mAhrp8FRGznMfjMaUaLcM8TUIdAydLRTETn7Y+Er+pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8628 On 08.08.2023 12:32, Jan Beulich wrote: > On 08.08.2023 12:18, Andrew Cooper wrote: >> On 08/08/2023 10:46 am, Jan Beulich wrote: >>> There's no need for every arch to define its own identical copy. If down >>> the road an arch needs to customize it, we can add #ifndef around the >>> common #define. >>> >>> To be on the safe side build-breakage-wise, change a couple of #include >>> to the xen/ equivalent. >>> >>> Signed-off-by: Jan Beulich >> >> Could we find a better place to put this? >> >> __read_mostly is just a section.  It's relationship to the cache is only >> microarchitectural, and is not the same kind of information as the rest >> of cache.h >> >> __ro_after_init is only here because __read_mostly is here, but has >> absolutely nothing to do with caches whatsoever. >> >> If we're cleaning them up, they ought to live elsewhere. > > I would be considering init.h (for having most other __section() uses, > and for also needing __read_mostly), but that's not a great place to > put these either. In fact I see less connection there than for cache.h. > So the primary need is a good suggestion (I'm hesitant to suggest to > introduce section.h just for this). In the absence of this, can we > perhaps deal with this in a 2nd step, thus not blocking this patch and > therefore not needing to then also clean up PPC-specific code? Oh, also: I we move them elsewhere, it wouldn't be logical for xen/cache.h to include that other header as well. Yet without that the risk of build breakages (perhaps in only exotic configs) is of course quite a bit higher. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:35:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:35:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579586.907631 (Exim 4.92) (envelope-from ) id 1qTK3z-00073r-6h; Tue, 08 Aug 2023 10:35:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579586.907631; Tue, 08 Aug 2023 10:35:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK3z-00073h-4B; Tue, 08 Aug 2023 10:35:43 +0000 Received: by outflank-mailman (input) for mailman id 579586; Tue, 08 Aug 2023 10:35:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK3x-0006fM-QQ for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:35:41 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51591192-35d7-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:35:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51591192-35d7-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691490940; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BrTXV0zGTCBFA5cHhsVl+NKGNpqGumAs1gqFHvWjauQ=; b=iiOElW66YpPhbOBsD1caQKQ3C1hqSMkW6ssglK1ter9KL2K7/FxylCMs qFLWJ15MwIASVpAb2VZRe+Z18G4RMP7q8H7oUvYwpAcuvWgOvsPZkqXNe c5vJNANTPZf/84IakVn+xXw6XTNmUy21wr1PkyoH6MwttPHuIyIU/VGPr s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118117886 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:+bfqqayD6Gk4bTN9ZpZ6t+cWxirEfRIJ4+MujC+fZmUNrF6WrkUEm 2IdWmzVa62Majb2e9Agbdzkp0wA75DVz983HQdp/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPa8T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVBt1 78mOXMIVTqS19uyy4iqYfdnqtt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwMzh/B+ TKWoQwVBDk+a/iH8RSAqUuCreCXxGTWVdg5BOSBo6sCbFq7mTVIVUx+uUGAifu2kEmlQPpEN lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAbShZRZdpgs9U5LRQjz lKTlsnlLSBuuraSD3ma89+pQSiaYHZPazVYPGldEFVDuoO4yG0usv7RZudAMu2Ln57wIhvhk wmOpxIvrKsYodFegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg meJ4Wu9B7cJZhNGiJObhKrvY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhha M7HKp32XCpKUPQPIN+KqwA1i+ZD+8zD7TmLGcCTI+qPjtJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQEKWQGOqdR7BQlTfRAG6WXe95Q/mhirflA3RwnMypb5ndscRmCSt/8IyrmRp innCxMwJZiWrSSvFDhmo0tLMNvHNauTZ1piVcDwFT5EA0QeXLs= IronPort-HdrOrdr: A9a23:zn3B1KvD6nsNZQQEOhHbbVwk7skDe9V00zEX/kB9WHVpm62j5q OTdZsgvyMc5Ax9ZJhCo7C90cu7L080nKQdieIs1NGZMDUO01HIEGgN1+Tf6gylNQW7y/VU0r 1pebV/Dtr5CDFB/KTH3DU= X-Talos-CUID: 9a23:j5IceW+2nFkrPCtv1A2Vv383OIMbYz7Y913Bc3a8Alx4Y6OeZUDFrQ== X-Talos-MUID: 9a23:XCLWnAp1AhyKqvcRnlgezxU9EN9QzaH1MW4mns1f/OSJbwdgYg7I2Q== X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="118117886" Date: Tue, 8 Aug 2023 11:35:28 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH 2/2] tools: add configure option for libfsimage Message-ID: <4679e0f5-f5ea-4182-887c-0fe65539f9c2@perard> References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230804060000.27710-3-jgross@suse.com> On Fri, Aug 04, 2023 at 08:00:00AM +0200, Juergen Gross wrote: > The only in-tree user of libfsimage is pygrub. Now that it is possible > to disable the build of pygrub, the same should be possible for > libfsimage. > > Add an option for controlling the build of libfsimage. The default is > on if pygrub is being built, and off if it isn't. Without pygrub the > build of libfsimage can be enabled via --enable-libfsimage. > > Signed-off-by: Juergen Gross > --- > diff --git a/tools/configure.ac b/tools/configure.ac > index 9947bcefc6..aea24eb982 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -185,6 +185,19 @@ AS_IF([test "x$enable_rombios" = "xyes"], [ > ]) > AC_SUBST(rombios) > > +AC_ARG_ENABLE([libfsimage], > + AS_HELP_STRING([--enable-libfsimage], > + [Enable libfsimage, (DEFAULT is on if pygrub is enabled, > + otherwise off)]),,[ > + AS_IF([test "x$enable_pygrub" = "xno"], [ > + enable_libfsimage="no" > + ], [ > + enable_libfsimage="yes" > + ]) > +]) > +AS_IF([test "x$enable_libfsimage" = "xyes"], [libfsimage=y], [libfsimage=n]) > +AC_SUBST(libfsimage) > + Should we issue an error if one does "--disable-libfsimage --enable-pygrub" ? Or just let the build of pygrub fails? Also, "--disable-libfsimage" alone will keep "pygrub" enabled, so we should probably check. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:40:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:40:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579600.907645 (Exim 4.92) (envelope-from ) id 1qTK8L-0000Fa-PD; Tue, 08 Aug 2023 10:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579600.907645; Tue, 08 Aug 2023 10:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK8L-0000FT-M5; Tue, 08 Aug 2023 10:40:13 +0000 Received: by outflank-mailman (input) for mailman id 579600; Tue, 08 Aug 2023 10:40:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTK8L-0000FN-0K for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:40:13 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f2e5b033-35d7-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:40:11 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Aug 2023 06:40:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB5048.namprd03.prod.outlook.com (2603:10b6:a03:1e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:40:07 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 10:40:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2e5b033-35d7-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691491211; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=adSk8xWebp+2j4PwG4Sb6nV0/iaLUvFNtEzrRMpbQS8=; b=VZ1rUPG+BNV5zFo9ymeg/UXQxZjiGmvdaZe2pqNzX5I+HTQXZ7RSp5Uo e/KF+fx7zIE7BO/1wcbu0sI3qjosIEpxplBsnpIF0FUOvbKehthoNOrGb 9yTRSQJEGPkIzxhK9ER6HishDIEgcLMAEoreE/pJ4fyhZKi9cDc7fzuFN k=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 117516469 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0S7z5qsVM2cLCjBC90x/+Rv1L+fnVHVfMUV32f8akzHdYApBsoF/q tZmKTvVMvyDNGL8eY13YYWx9xsF7ZfQzt82SgNo/iphQitA+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5A+GyCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOmgGYDC6ttON/K+1Ue9gqIczNPOwBdZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4O9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOThqaMz3gHNlwT/DjUfR2aLv8idqnK1BfZ/D mtMuXF0hKI9oRnDot7VGkfQTGS/lhwTQd1LCMUh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+LqRuiNC5TKnUNDRLoViMA6tjn5Ys13hTGS485FLbv14KsXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU= IronPort-HdrOrdr: A9a23:n2/HSqHusLkamEUNpLqE5ceALOsnbusQ8zAXPiFKOH9om6Oj/f xG8M536faWslYssRMb9+xoUZPoKRjhHPhOjbX5Vo3CYOCJggSVBbAnw6On/ibpHDf3/PNc06 BpdsFFeb/NMWQ= X-Talos-CUID: 9a23:KUsOLGBUI00cc1/6Ezs//0A0I/EUSUHAwmzWL2H7GX5TE4TAHA== X-Talos-MUID: 9a23:R2cAxwYzt4cT+eBTvi3RtC9TEOdU6PqKKGUqydZd4eCOOnkl X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="117516469" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtoyHqltReVXrilX14dnd3xGncsBhCDmem5pJtKYeWnhyCklpBlbpYRfMwJq4GMLMYbo+uUWi3KiAnAAX98oMaQUqUoqVhcIsZaNlNADiVNBZZBnpyyncH4I38ZXXGRwi8k4AjsRJG8uX/4YucGF92VTZbjpG/K6rJv2J0Kw1+Y/ry+7OZmeAED6yk7eCdZNDfCclCKiEnR/M1eQQpYDj3YKBTy+N+/U0lU5Bjvz5ZaXt8MlkT8JFXf8/+ef/KcG1FnsSZSQEN89GM3mLve672huxde+6U+/kEqkMVvTTFM9bUIixU51FGrXOJuu2BztAfTsR+BUIvCdWmjoOGVb+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jl16JPyCczFISBufob8qw6MsNZc5UvLU2ffFVK4T680=; b=WtHVnZ73ZTY87/nqvS/vD/x5zbe583u3NZ90q2Xs5oKapvGuuvjm5HlncQ5T+N3Y/W55YP5d7QM/V00U3OmSqgPhpbs0huzMaARqXPvClZDPW3zhO6eYlENo60VfWoOkpS95Afn1u5ha4MuTunxml6CtilrbnWIRFZr51PzrRrKcAnKwkPvIbfZL3GJ0UNhdqmTwwvawL2lzLRf+BdCxmIh3fRExaXt4SnclhBwWoEdvfesKsYqXKPWLKitMIo8cmBXGgfdNXYK0Csh93T01+8V2kvm4j6KDh8bsNGuLgSGDtg0Mdq9RtpEBxTKERDLmm7PLlYyQg9YaJBSIMPKxPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jl16JPyCczFISBufob8qw6MsNZc5UvLU2ffFVK4T680=; b=iXS61/XH7XubMQZN1q+xnpDPawa1j1RMHfXzrG0/IzCY1Cw/r05KINHvZVZ+lnUUzd8qNZ7HCo4TZR2ZAzKBjoL2UtiRq8ekkYto5tyILTTu1eLWxL7eS+E/OCFjiXZ2JP+jyfwcQdz6b9uoeOOmEmf4SgqhGBTvDgM9m7+UGVc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 8 Aug 2023 11:40:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] tools: add configure option for libfsimage Content-Language: en-GB To: Anthony PERARD , Juergen Gross Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-3-jgross@suse.com> <4679e0f5-f5ea-4182-887c-0fe65539f9c2@perard> From: Andrew Cooper In-Reply-To: <4679e0f5-f5ea-4182-887c-0fe65539f9c2@perard> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0042.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB5048:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d30d788-831c-40bf-7cf6-08db97fbd515 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hf7jcj2M+UhIEuhFF6j1KEwqHCWle0CZ2mYPrK5qvljWINQCjSUd7m7tnPo6nOsY6wubAmh/2v7Mk7Vb8Ej2isEJYRT7HIgHwtgcPTBTJxh+AcRRWx47tzRJ5l9SyCynIaJaQXQbkw2dGsJvx8u2TILCTdpuayaslvLmgEIaqPL/VqkfkDUQozXsEo1KrsGdymNzUOY+dCRsb8CNLs3SYATdY/RjMBg8r7U2icLLeEqp+f/Kf7DK58pb4uUEHV9zM+qyJ/7UUYbb0QuFO7rzoUEWMmfMt2ubvcX6j+AZ/UMaIq/H70K/uLhgsQNnwh9p+pxFb1JUSpFQacpjRQ0SsxLLInAeAktHNpjW41nmMp0vpCHu77MxK46LP75a2xL8+t7GU/b/UBeimfuPef3dc6gLSgbZ4j5Rv1zNhoaKKlagjmu2wpvRRDSHry4iAUEb4qJ74SXpwYXP4i7v9/sERpo2lohsESWRQC3VY3ujW+LRQ/rCjk31tQs9SLoLK9r8mlzp3JwufkF0xvt3RiCMWhGi1H4f0Zdpaph2yCuGSeFBs+B1TYV8y7eK7cfHwBE1OEWrSyXmjwDs0SxR3dIiYejoZx7ju4pwT/6/7hiXEe5TchV7EwmCnlSBzl5AroRBp5mj4OhThLsmsvBv9TrUlw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(366004)(376002)(451199021)(1800799003)(186006)(2616005)(6512007)(36756003)(4326008)(316002)(38100700002)(6506007)(6666004)(86362001)(82960400001)(66946007)(6486002)(110136005)(66556008)(66476007)(31696002)(478600001)(53546011)(41300700001)(26005)(8936002)(8676002)(2906002)(83380400001)(5660300002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVhvSXJkNkFYem96ako1bFBqQ1dHY2RpNG82SHlmcDZxNEpZK0J4NWZPcVVD?= =?utf-8?B?RURHdTI2Wk16dnloY1JIQnJnS1RENlpkM2tQdzhaWGdkcENwNENUamtJRWxz?= =?utf-8?B?RlZBRnNZclFWWEtra0RoOUV6czA4L1g1U1RZY3R4dHBFQkxFS0M4NTN0Qmgx?= =?utf-8?B?SzdJTzUwWFo1V1psMkdOSjUzM1lreEdiSDg5ZnNaYWFlbVU2TG9UK2NCaWlU?= =?utf-8?B?V0t2K1dCZ3ZmSzR5SnFFSy9sL1lLUGdhRnhGWTN5dEVWQlpwQU45cTlmdWZY?= =?utf-8?B?WHNJaEI3bEpZY0VCUXRBUFNiakdJb2xHV3IvVHJHVDZGZXVaVll3cE5JSEV6?= =?utf-8?B?d2tBbktCWHBZbnQ3VnhzcDhWRWp4alY0S0RTY1pReWpXK0o5RTQ0bzBRTWR4?= =?utf-8?B?YWMrb0p0ZCtHeitKS2kvRTVuZWRSeWNjVTc0VThKZFE3QkJvQmtVeVhaenVr?= =?utf-8?B?U1JCa0FCQmpvY3lGeGE0bnl6dHBZS0lWZE5wYWc1dzFZUVcySHRpZ3RNRE55?= =?utf-8?B?NkpxeEVPWXQ2ekVKeXlkejlodnFxU2hlQ0FCQXVjYW1tdy9NTStEY1NkT2xC?= =?utf-8?B?emVvOWJURXhBb1hVbXpRT1Y5K1FZV1hoQ2JvNlBSTTkyTTFvSzVJNVhNVXg5?= =?utf-8?B?ekk4bnlNdmkyUEorc2FoOUNsY05JbTRKcmdKQ2lNa1J4R2dqOXNHaHJacUkw?= =?utf-8?B?STFmNE5LdHpwSDNSV1ZCeXNhKzIyMDRkYTBnQkFDRVF4dTBOUnNOdktGdnRm?= =?utf-8?B?dkYzYm4zb3RncWhUWThsbXZhTlJ6dWVqY0hyeUVOeC9PZERBOGpCMHdRSjUy?= =?utf-8?B?SHA5azNJR2R6aS9iZWtSd1VUaTc1WGJWck11YUVINEp4MHRUQVkya2RYUGZ5?= =?utf-8?B?ZGZFSXUwN1ZjWXRWSWhFODhIdnV6Ty8yOWJTUWdPRFlub1lCMXc3OUQ2ckN6?= =?utf-8?B?Vm9Gbnh3WWhZTmpSNWt2em1zdUZyUUhzZWFDRXc3Q1JPYnJBWGNkNFlvRGVY?= =?utf-8?B?MEhFQWVNaHBJWERtNTRDSGQrbE9laTZSc1J0UGRTY1ZBbEE4WHVVdWphMUla?= =?utf-8?B?ZFZlN1VXSWxkYk9jNXh4bElITENzMmJuTjg2a0wwbEVhcXR4OGRRYnQyZ3Fr?= =?utf-8?B?cXNCL2tLR2xZWUh6VUg4SnRjOWpkeGNJU0lzY3VtVGZKbWtjeTl0SjdOSDF6?= =?utf-8?B?WlJ5T09Jd2UzQzNXOXFiRlorRlEwNXdWclp1WWN4bERVWVhOaWxVemNuSTV6?= =?utf-8?B?eVZ1S0lFUWpvK2J1Q3g3YWFPaUhudGIzYktBdmtwbW50Q1UxSGxrNnU1Mzll?= =?utf-8?B?NGZqdklHclFJRmViQ1pnMlZmN2xNQzF5SjR4TndDRElkZjBZWDZmNS9manpK?= =?utf-8?B?a2hPSEdhYzhZNFFZc1RZY2M0UFZybHlIK01zK1UrbWZEdkk1a2RKSHhOZkZw?= =?utf-8?B?aHEvVHhvUG9nWWN6bHphZkE3UzUrSjlmVlo0TmVuY0ZmSzhmQ3VkUHkrTXRQ?= =?utf-8?B?YlM1bDFIVGptRjRJQ0ZUQWttcERjcWhNZkpWTHI5c3RrZmxZMkxKNjQyRXpq?= =?utf-8?B?US9YYW5OWFNlTTJOc2hRT2FlY3ZSMExkWnRtWjN6SXplMnFvRFI3cEtFNVpt?= =?utf-8?B?SlRSUTlyQWpncWNWNU5SZXVpc1gyTnVEQmRuYmNrSXJYK3p1VHZKeHczNm9O?= =?utf-8?B?WDBXbm9BUHRVTGRsRjI0REpBQStzbVFpZ2IwY2R3K245RHkzbFRFalVvTytq?= =?utf-8?B?QkxZNXAwNU5QVGNxaU9Jd25nYWVTaFpVSzNGc0ZVK3paZTdMcUVNUzdKbkFu?= =?utf-8?B?VCs2RjlNWk9GMW1NNkhmeVBrK0xFRy8wWGl0bmk2d2VZaysyUm1oeWl4WDNW?= =?utf-8?B?M1U4ZVZqSXl5ZC9BMDVCWU8ybUoyb1pqRkJIV3Q2dGtRRTZWcm9oU2gvNGgw?= =?utf-8?B?d1RBSU82c3BzcE1MNlcwYmlXb1l3TUtsY3lOaWlHSW1NRUtWY0JFUXNIalNF?= =?utf-8?B?UWRpa3dPMUtuR1VyWVk1WFVscDJ0VG5Xc1h3aTkvUTVkc1JKbEJrT0xHd0lB?= =?utf-8?B?V3F5cFExVlVaTFNLUGRvemlnZTNaRmV6WjRLZWlNblhqNHZHSUpZYUVZSUVk?= =?utf-8?B?MVh2ZzE2ZU9WZTNaeUpnRVNiWURwNE1kdzJ3YUEzOHI2UG1pODM3bEt1c3F5?= =?utf-8?B?aVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IDUtnp6JXmXsHaKDsxny8XV5tZVzFcw5WAPa+ohF+F9fU+aETGceSwbuVIgPordfoS2T4oCJn/tfOkp+Clu9pfQnPIemXAaR5Kec2LuZZLadMXmSFzXOhLk0JnSaEqlnskXcnBrq6QyNYSJ+yT1v7AHLJY6PF1p0sGYsaWbCcBs823jE6pTCKa2ba5fz8DJzJty3S3aGQP6tlW1e5KsvwSTe9+Hl++JGHv7DMEnxI2JJSF5FV2D9imoC6mhiQYeO3D4BpRQEu+RX97WUfBESIICf4cjn2LWryBi0EAutkpcTPk+yYLfN2g+t2I/3sPikX95ATpQ7YLzE+Su9SVFUk8FUJ9bbCqpVGg6wr+LWTQ8nr1aAaZTBP/hyfETxWUntm6VfU1G41qozY9zPyGkLvsxG73RSKikU1st6ou4vcapSYG9udE+DBB8JW7LpN5ojfsNoC7HAJLa69bRphF5K2ParNzeY8tjcflda8CeNoYr59j0s9Jt7ng2fA3DIcEIrjIuPN0EuW4zg0jayg1DDQeqhKr/PigOkf02+RtbhXQU3bRnIB4kApHlneiEmKM4NmypAVTVTwDqZEq1mmcwcmhAxgJnafdDYB/oi7SVvZH/9Gzio58JbsFBAPITiP50jQ2gOPTh9dObxeWj9RkB5D1gW1NodQ9aVqkesbxxnbvd3mjczGugAhNleP04hmI3J7GigpZto7k40LP9oIiV+ZE0m/JxUu+dcQOjZF7d4YIbuPMoXf3p7aQNZNbO+Tbbdc/mxLkjRe253dojbR8/yG7xpohVV5V6RLzBn+QlI9vg4ripPz4AnfGJiD4bXJUQ3 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d30d788-831c-40bf-7cf6-08db97fbd515 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:40:07.3139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OndqdJdCZayICaA7K0E63JWiOhx3+PTQdfllkz12Y69iHdR9mAay7Y8glsw3QIzDlLjzflIojt47mlkA+Xo8h7id9bFXwUWfEA38CcGM2mc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5048 On 08/08/2023 11:35 am, Anthony PERARD wrote: > On Fri, Aug 04, 2023 at 08:00:00AM +0200, Juergen Gross wrote: >> The only in-tree user of libfsimage is pygrub. Now that it is possible >> to disable the build of pygrub, the same should be possible for >> libfsimage. >> >> Add an option for controlling the build of libfsimage. The default is >> on if pygrub is being built, and off if it isn't. Without pygrub the >> build of libfsimage can be enabled via --enable-libfsimage. >> >> Signed-off-by: Juergen Gross >> --- >> diff --git a/tools/configure.ac b/tools/configure.ac >> index 9947bcefc6..aea24eb982 100644 >> --- a/tools/configure.ac >> +++ b/tools/configure.ac >> @@ -185,6 +185,19 @@ AS_IF([test "x$enable_rombios" = "xyes"], [ >> ]) >> AC_SUBST(rombios) >> >> +AC_ARG_ENABLE([libfsimage], >> + AS_HELP_STRING([--enable-libfsimage], >> + [Enable libfsimage, (DEFAULT is on if pygrub is enabled, >> + otherwise off)]),,[ >> + AS_IF([test "x$enable_pygrub" = "xno"], [ >> + enable_libfsimage="no" >> + ], [ >> + enable_libfsimage="yes" >> + ]) >> +]) >> +AS_IF([test "x$enable_libfsimage" = "xyes"], [libfsimage=y], [libfsimage=n]) >> +AC_SUBST(libfsimage) >> + > Should we issue an error if one does "--disable-libfsimage > --enable-pygrub" ? Or just let the build of pygrub fails? In such a case, it wouldn't be a build failure.  It would fail at runtime with an ImportError. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:44:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:44:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579607.907654 (Exim 4.92) (envelope-from ) id 1qTKCU-0000tt-Dh; Tue, 08 Aug 2023 10:44:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579607.907654; Tue, 08 Aug 2023 10:44:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKCU-0000tm-BB; Tue, 08 Aug 2023 10:44:30 +0000 Received: by outflank-mailman (input) for mailman id 579607; Tue, 08 Aug 2023 10:44:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKCT-0000tg-35 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:44:29 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c3174c7-35d8-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:44:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 44D2B22492; Tue, 8 Aug 2023 10:44:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 16F4F139D1; Tue, 8 Aug 2023 10:44:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CtPSA4sc0mQDPgAAMHmgww (envelope-from ); Tue, 08 Aug 2023 10:44:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c3174c7-35d8-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691491467; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JQt/6oSGcQmeP+N1n6U41fB3kJA/D3HeA5RfDDxn/bk=; b=bU45MmruvdYA8Vy3jmkMxGHclvpwbeSDxWfZz6OfYOwyG/SAnAk8DR3OTWXHcr0Kxp+cSs GsyEoptgKEAHlRyHLeF+TZ1AEKnXcG4bfkNdmP5s0fCxPuSZcT9f8Oi49+T3Ht1Xc2WDgg 46EDXMsiYG/PGYL06Ke85vBOUUgPbrw= Message-ID: Date: Tue, 8 Aug 2023 12:44:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] tools: add configure option for libfsimage Content-Language: en-US To: Andrew Cooper , Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-3-jgross@suse.com> <4679e0f5-f5ea-4182-887c-0fe65539f9c2@perard> From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Euz5ftqUSIiz00qhiAls9s8i" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Euz5ftqUSIiz00qhiAls9s8i Content-Type: multipart/mixed; boundary="------------uJ8vfuxMDRk7ZgE0k7s1dmKD"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: Subject: Re: [PATCH 2/2] tools: add configure option for libfsimage References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-3-jgross@suse.com> <4679e0f5-f5ea-4182-887c-0fe65539f9c2@perard> In-Reply-To: --------------uJ8vfuxMDRk7ZgE0k7s1dmKD Content-Type: multipart/mixed; boundary="------------I0mXE28OvUUKOAOS0VwzC8rl" --------------I0mXE28OvUUKOAOS0VwzC8rl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDguMjMgMTI6NDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA4LzA4LzIw MjMgMTE6MzUgYW0sIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4gT24gRnJpLCBBdWcgMDQs IDIwMjMgYXQgMDg6MDA6MDBBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+PiBU aGUgb25seSBpbi10cmVlIHVzZXIgb2YgbGliZnNpbWFnZSBpcyBweWdydWIuIE5vdyB0aGF0 IGl0IGlzIHBvc3NpYmxlDQo+Pj4gdG8gZGlzYWJsZSB0aGUgYnVpbGQgb2YgcHlncnViLCB0 aGUgc2FtZSBzaG91bGQgYmUgcG9zc2libGUgZm9yDQo+Pj4gbGliZnNpbWFnZS4NCj4+Pg0K Pj4+IEFkZCBhbiBvcHRpb24gZm9yIGNvbnRyb2xsaW5nIHRoZSBidWlsZCBvZiBsaWJmc2lt YWdlLiBUaGUgZGVmYXVsdCBpcw0KPj4+IG9uIGlmIHB5Z3J1YiBpcyBiZWluZyBidWlsdCwg YW5kIG9mZiBpZiBpdCBpc24ndC4gV2l0aG91dCBweWdydWIgdGhlDQo+Pj4gYnVpbGQgb2Yg bGliZnNpbWFnZSBjYW4gYmUgZW5hYmxlZCB2aWEgLS1lbmFibGUtbGliZnNpbWFnZS4NCj4+ Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4N Cj4+PiAtLS0NCj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvY29uZmlndXJlLmFjIGIvdG9vbHMv Y29uZmlndXJlLmFjDQo+Pj4gaW5kZXggOTk0N2JjZWZjNi4uYWVhMjRlYjk4MiAxMDA2NDQN Cj4+PiAtLS0gYS90b29scy9jb25maWd1cmUuYWMNCj4+PiArKysgYi90b29scy9jb25maWd1 cmUuYWMNCj4+PiBAQCAtMTg1LDYgKzE4NSwxOSBAQCBBU19JRihbdGVzdCAieCRlbmFibGVf cm9tYmlvcyIgPSAieHllcyJdLCBbDQo+Pj4gICBdKQ0KPj4+ICAgQUNfU1VCU1Qocm9tYmlv cykNCj4+PiAgIA0KPj4+ICtBQ19BUkdfRU5BQkxFKFtsaWJmc2ltYWdlXSwNCj4+PiArICAg IEFTX0hFTFBfU1RSSU5HKFstLWVuYWJsZS1saWJmc2ltYWdlXSwNCj4+PiArICAgICAgICAg ICAgICAgICAgIFtFbmFibGUgbGliZnNpbWFnZSwgKERFRkFVTFQgaXMgb24gaWYgcHlncnVi IGlzIGVuYWJsZWQsDQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgb3RoZXJ3aXNlIG9mZild KSwsWw0KPj4+ICsgICAgQVNfSUYoW3Rlc3QgIngkZW5hYmxlX3B5Z3J1YiIgPSAieG5vIl0s IFsNCj4+PiArICAgICAgICBlbmFibGVfbGliZnNpbWFnZT0ibm8iDQo+Pj4gKyAgICBdLCBb DQo+Pj4gKyAgICAgICAgZW5hYmxlX2xpYmZzaW1hZ2U9InllcyINCj4+PiArICAgIF0pDQo+ Pj4gK10pDQo+Pj4gK0FTX0lGKFt0ZXN0ICJ4JGVuYWJsZV9saWJmc2ltYWdlIiA9ICJ4eWVz Il0sIFtsaWJmc2ltYWdlPXldLCBbbGliZnNpbWFnZT1uXSkNCj4+PiArQUNfU1VCU1QobGli ZnNpbWFnZSkNCj4+PiArDQo+PiBTaG91bGQgd2UgaXNzdWUgYW4gZXJyb3IgaWYgb25lIGRv ZXMgIi0tZGlzYWJsZS1saWJmc2ltYWdlDQo+PiAtLWVuYWJsZS1weWdydWIiID8gT3IganVz dCBsZXQgdGhlIGJ1aWxkIG9mIHB5Z3J1YiBmYWlscz8NCj4gDQo+IEluIHN1Y2ggYSBjYXNl LCBpdCB3b3VsZG4ndCBiZSBhIGJ1aWxkIGZhaWx1cmUuwqAgSXQgd291bGQgZmFpbCBhdA0K PiBydW50aW1lIHdpdGggYW4gSW1wb3J0RXJyb3IuDQoNCkluZGVlZC4NCg0KSSdsbCB1cGRh dGUgdGhlIHBhdGNoIHRvIGZhaWwgY29uZmlndXJlIGluIHN1Y2ggYSBjYXNlLg0KDQoNCkp1 ZXJnZW4NCg0K --------------I0mXE28OvUUKOAOS0VwzC8rl Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------I0mXE28OvUUKOAOS0VwzC8rl-- --------------uJ8vfuxMDRk7ZgE0k7s1dmKD-- --------------Euz5ftqUSIiz00qhiAls9s8i Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTSHIoFAwAAAAAACgkQsN6d1ii/Ey/M ogf9E/YGsiVwG/jrhJtqgxORkOgPb8rrJNB9L9FwZwAxeY97l+HGorptsz2V+cQV5WG1oHsYBZvt UArlBWAaZ49PLOOSJByL1kYTxjtTpIdybq6KJmKO4B+nc9JS70JKMYwHrBye0g3/jsZQG6D5ZGK/ lyAkzbY+T0WEFCEk1ID14LEZluQHTCzZnWeFMdf6pisnUhKQIy/zamI3JULgc/cyA24Wm0xKgwQq dB0x5F6oLXsjNoUQm3HOhuR8pgb+nTdfBDTOZxc35NKbgcQXXzTbc4HCLGBR1sm/ZiMnuQCqhDDD A4PRnVEyU38rYi8oH77fzJBDZeeJSAqomB2GwAA9nQ== =ZS32 -----END PGP SIGNATURE----- --------------Euz5ftqUSIiz00qhiAls9s8i-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:48:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:48:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579613.907664 (Exim 4.92) (envelope-from ) id 1qTKFz-0001Ws-To; Tue, 08 Aug 2023 10:48:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579613.907664; Tue, 08 Aug 2023 10:48:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKFz-0001Wl-R3; Tue, 08 Aug 2023 10:48:07 +0000 Received: by outflank-mailman (input) for mailman id 579613; Tue, 08 Aug 2023 10:48:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKFy-0001We-15 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:48:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20606.outbound.protection.outlook.com [2a01:111:f400:7e1b::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d7872f2-35d9-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 12:48:04 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9979.eurprd04.prod.outlook.com (2603:10a6:800:1da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:48:01 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 10:48:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d7872f2-35d9-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lg4eshNPK0BogUBqtukGSJpyZVE37nMdSp+E4hZ1ygQdDDEo+JSh8kVrPxU7hrgGX+l7aj8V8nLKZW6vsCE/26lA/crjNTSSa9rNQzB17wPFuUAR2HwlS9lIG42I0/Ab8RPIrw7RL4TNyocvrM264B1R1iZZS4i22Bbk2Q0pDymbGUBZNGLZoobCYozMRfGqx2tFHUkgTykaAs5eM81VutbffAKky7jNzhVGaKJjH/P+Cg8wPtRzO8g6lOdfnR1V49EvMcDVy1/Sp5vGcieI7hDQrWxwulFxwdV08vBpl/LSckNVX/kPQVUubvb36+TNWMmIRguIX9PzG2KKnWk7lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fcYszhiG3WDt8qVSsB1WgPxqNNs02w+HO3DLk2/wK20=; b=b7pbgCuUuLmBxDLP6dOT4Rnx3n0GMDvuZQIR+YqUi9t6ePzJuEmiR9LK14cq6Xf54VpBuftuemtzcZb1+RgpJvtubIYYRpJL2Tjyz1m9tM5bHv38eWxuqlI+PKT1m73z4b+7jVXOEalKfMl3uMJW/3i1W/nLm8m8uOPIeOB9UnIIj93q12ZT+ZrgJxfX4GhvpEeVdptuou7Kjoh7odtXpwchqZFwceYDXRNgOU9mcCcLg/sfcPxis8JClN7T17gPVV8f+1yYw59QIQUwpbONJzpPGEQTuPDlUBEutCZyqV8lv4Me1pE10SwJevdmKZW5k/D7P1Grlqo4On2AYLrmVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fcYszhiG3WDt8qVSsB1WgPxqNNs02w+HO3DLk2/wK20=; b=311mBnHFR9oaMpqbVulG46Yzq8hLIHR2G9xnh5FLWmXLINAjf4vdkMk1gNIE2FZ74I82C39svkXkAAOFcXF2397GhbrlxCqywjAz9vOAmRfmebXnPFCiRn8AVBqkYesiuXNcG9ivCrE+JnqNvKOOwe40lNkMiRBqIghETELAJq4CGu3yZC7erEZF0S6Hb8Ee9rey4fxTpu9RFUGMdDZrVCRGRPqIWQvOnJGzav3UUx92dteq7DX6LxcJ5Rj5RP9AezqsZExHpl4gQhlVKc/y5U9kxclJYBCduW1dqUMBIY+WsMPYqBD/+eqJXu3tEAkqvK9bxDLmcinwJ7Osiz2gDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 12:47:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio From: Jan Beulich Subject: [PATCH] move max_page and total_pages to common code Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0185.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9979:EE_ X-MS-Office365-Filtering-Correlation-Id: f1faa532-c1ce-4350-abf2-08db97fcef9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LMHTQSs9uOy0LRrx142NjDh3RtarZxrOVUYaqrdLQax+dy+E4vsFturAPSEtfjAWsKJVUNlBodq6sDru7MAkfZiwmak8wAS2byzMATg+RV5J+1TiNnHuOL7NhtBkLwI0AnmVyd3vdzQsUHwOP/KiaUs9u802NOodTFVfVGhr6K7NjDvVniEZGaQ+pupG+Rp73TTSCcQsjKodIDOynXGrw4UtpQVPF8E+CFmjV9UsOtpvU2wN3SASY0AD3GlgR+YxqLFKKU848etKuGNwJtmlv5OwTA84Z7gcHuux0lBxHsZ5R1vZZhkqk2hpuBW2GH9f9xyCLvnmBbE+OOg1thbdz+SSaNoySnEuDeKuDEOwdgbovHhOBTf13z3NiuV7CuO/t2brM2zYTex4TBdVJkvbSDJpxpLWUYfHTGnYg4N8tcqRZk8tWTE9iiMjFE8Q+v09ELJ0xMt91oddALf5Vkc55z+UfQ+HlksxH79zseV04Krmq99XUmkNCW3izM0M9dAdpVguCQesY9fBNVyF6phh+OPbRRMhJxC5w4oJ4BANJxWLAwptIyQQ9wE/wN4mTeEXJl6e3jkYV4eomJraZPPh8spS+iMnS+4SnUJ8RQoYvXeS2mfVyN4Y5tz0xa8wvAv6pHQ2y2Zu4YdO3YF+r51gkbQk+4/EzFk5jpyPTvqyKCuCxyK6PXMY63i66JS+U882gPjq3cO6y1DWfjKGqJp8tA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199021)(186006)(1800799003)(7416002)(8936002)(8676002)(5660300002)(6916009)(4326008)(41300700001)(316002)(86362001)(31696002)(2906002)(6486002)(6512007)(6666004)(2616005)(26005)(6506007)(36756003)(66476007)(66556008)(66946007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnRTR0VQdExXOHpWZFo5TG9JMjYwZVpWUGJMYXNBZjF1bk8zWFlNaVI0b3Zj?= =?utf-8?B?bFNlZlBsU0I0OFMwK1hFRDVzN21UMndDTkc0VXFVSDlyL200eUF6eEVUR1Fu?= =?utf-8?B?VEVBM21wdkVnSHZaRlI5R0Y4am1ZeDJIQkVkeUx4UjhicWR4RDk4Q3dickJq?= =?utf-8?B?czJ0bTF1Wnc0RUxKRm5LWUJRL0owQklUSHQ4cTI4NG5yUDZTV2swZTJRVUlp?= =?utf-8?B?eTNheFowcWtoOHRvYWMvRVVwMFE1V3ROMTJ6bHg1czRzM0lmWUxrZ0o4MS9V?= =?utf-8?B?cWgvNkF6bXJqaWR5bm96SWI2V1dqaFdUT1ZqNkRjekppM3BaOG9ySjUyV3lF?= =?utf-8?B?Rk1KaHNzQnFLNy9TQWRrV2FMWUljSEhpQkd0TmdkNUYxeDZONE5kSzZRN3Ra?= =?utf-8?B?YjZMV3V5NVhVVVdhTzR2WTBzRWgvYTh2aFZzb01sQWl0a1JHMEpjbWoyaDd5?= =?utf-8?B?L3Y3azN0dExScVRXdkxWOEZ0bkNlaWwxTkF6eVNUdkcyZUdWbTdCa20wWTA5?= =?utf-8?B?OFpKMS90ODU1bTk4NTIwUWhvdWVtT3JTQjdybzRnakJBdjNwNmdwaWc2UExM?= =?utf-8?B?RS9ybHc2QUJYOERyajNxdlBsNFpMQ0lwS0ZEdUhJbE9PS1EwVEZKT1RDTHZS?= =?utf-8?B?QzRtK3JlRHNLcEtNMWJRd1Z1dWJWNkQ3QU5KTW5oSGxsRlpBWmJRdHBnOWxZ?= =?utf-8?B?Y08yRmMyVC82RFZoMjIzMnhGTngzRk5tQlh2V3kraXdpd0V4OUZzdUhWM0xa?= =?utf-8?B?Qk96emROd3ZGRXRMWW1uWnZVbExSeHNjYysxUzYrZnI1WkpmbGR0VDI5dGQz?= =?utf-8?B?NmZrR1B2dHIrMjVYTVgrOW1XSEM1UUdEc2tsdlBlNnlNTCt3K0RwbUtybHM3?= =?utf-8?B?Wm8wMFRyMlBjaE5tMEZEcXIyaGJSZUUwSGxIak5ybWJTRmI2UFJyMDkzRjI5?= =?utf-8?B?V0tpQm1vVlN3RDk0djVybjIwMWFXS0I0SlpqMWxQRW9mMGIrUThSbzY4WjBM?= =?utf-8?B?M2RRUkZtUkZuTWFsZ3JKRktYaUR4V2RhaTR5SWRWMU1VRHZjOGtMSG51Tk13?= =?utf-8?B?VlprS1lPeDN6dkMyb1NEd01LVWhnM0pzVmQyOFFYWXdpMHc1UkgyY3d5Q3hJ?= =?utf-8?B?aGtSaVBTZjNlSTRsVUx1S2tTY01hU0g5UFJKbHZaWk43bm10MVowTE9kZFlY?= =?utf-8?B?eGxjYThyOXZqTjEwNzg1Yytqa0VzZFR2WEVRcHNMYmlZTmlJQ0N4enFPSnVW?= =?utf-8?B?N0dqUmdHQjcyaG1FZ1RUQjVUWVJJMFVoS3FLUk9oUk9VYm5yUGdudXoyUnVr?= =?utf-8?B?SDBTNzIyalVReC9KdDVvdmJFMEJOdjBMUXdTaEcxdk1aQ1N3SGsxY3hPWHRT?= =?utf-8?B?Q3A5cXRYak1odER3OU9tRHZEWmF5T1NqcGJBdjZpVGNKakZ3TFFxMlpxOUE3?= =?utf-8?B?cENlUjlHeVB2Y3FtSDRWQ3prS1NwNmxBV1BleDMxUmxkMVg3ZThUZnBsR2p5?= =?utf-8?B?RXcxbXRMTEpDR21yMzA1bEtRbjNnTTljR2VmNUVlbUtNMXQrUXFhSmZpOWZz?= =?utf-8?B?cGtjYTBNMjc0NlowUXJGME1CMDB6UG1DMDdaVUFIZlVIUjZaVmNHRE95NThx?= =?utf-8?B?aVRreWJzNVM5NTdHNTVJYllPTzdQdFhoT3ZyVS9ucmJ6bzkwN3dQd0dURHJL?= =?utf-8?B?ak9Jem1GNnBzbTVUWlBLZFRNeVJIdDF1QmRwRHlWL09QcnBPdEUxZi9XcW5X?= =?utf-8?B?N1lZT1ovcjhvSFN2UTg5eFF1dmtnR1dQVGpKa3owcXBlN0hSWTdCeUVMTlFT?= =?utf-8?B?L21JcUYyOFBHbjRPL1NLWHhjcmptMDY2c0ZPUW4vTmI3SitNbGJPWkNXUmFE?= =?utf-8?B?ZzkwL0ZkK2VSdk5VQzROUlVhZmJKdnMvdWk5N0tCcFd3T2cya2srblU2V2pH?= =?utf-8?B?ZHBYTG9mUkpKUzh3S1MyM1ErWm5ibFhGNXhRVit5YUFDaWxWRUZSZnQ2T2Jk?= =?utf-8?B?aU9LOUxjY3ZYL0EvcnZHTkVjbElrK3NZa1V3WUpNTGJLRFk3YlBJNlVSZ0Vu?= =?utf-8?B?NEhINEsvSVRERzlsdkd4TXZUVGJ0N0FCQ0RwVXdQODhlWkR3Rm5DNS8vcjZ4?= =?utf-8?Q?0cziEcfa5FMFFpJYfjf0HlOUW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1faa532-c1ce-4350-abf2-08db97fcef9b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:48:01.1603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lKu3gs1Bl77CCe0P+LIKkY96SUGETL25tZROw0/B9AxDd3AaUNz4rpPIKv2gB92fwINDV3EA2Etqv8jVsKSQzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9979 Common code references both, so the variables shouldn't need declaring and defining by every arch. While moving the definitions, add __read_mostly (__ro_after_init would only be appropriate when !mem_hotplug). Signed-off-by: Jan Beulich --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -198,9 +198,6 @@ extern unsigned long directmap_base_pdx; /* PDX of the first page in the frame table. */ extern unsigned long frametable_base_pdx; -extern unsigned long max_page; -extern unsigned long total_pages; - #define PDX_GROUP_SHIFT SECOND_SHIFT /* Boot-time pagetable setup */ --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -134,9 +134,6 @@ unsigned long directmap_base_pdx __read_ unsigned long frametable_base_pdx __read_mostly; unsigned long frametable_virt_end __read_mostly; -unsigned long max_page; -unsigned long total_pages; - extern char __init_begin[], __init_end[]; /* Checking VA memory layout alignment. */ --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -337,8 +337,6 @@ struct page_info #define maddr_get_owner(ma) (page_get_owner(maddr_to_page((ma)))) #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) -extern unsigned long max_page; -extern unsigned long total_pages; void init_frametable(void); #define PDX_GROUP_SHIFT L2_PAGETABLE_SHIFT --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -146,10 +146,6 @@ l1_pgentry_t __section(".bss.page_aligne l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap_x[L1_PAGETABLE_ENTRIES]; -/* Frame table size in pages. */ -unsigned long max_page; -unsigned long total_pages; - bool __read_mostly machine_to_phys_mapping_valid; struct rangeset *__read_mostly mmio_ro_ranges; --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -162,6 +162,8 @@ #define PGT_TYPE_INFO_INITIALIZER 0 #endif +unsigned long __read_mostly max_page; +unsigned long __read_mostly total_pages; paddr_t __ro_after_init mem_hotplug; /* --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -159,6 +159,8 @@ int assign_page( /* Dump info to serial console */ void arch_dump_shared_mem_info(void); +extern unsigned long max_page; +extern unsigned long total_pages; extern paddr_t mem_hotplug; /* From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:57:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579619.907674 (Exim 4.92) (envelope-from ) id 1qTKOZ-00031I-OK; Tue, 08 Aug 2023 10:56:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579619.907674; Tue, 08 Aug 2023 10:56:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKOZ-00031B-Lo; Tue, 08 Aug 2023 10:56:59 +0000 Received: by outflank-mailman (input) for mailman id 579619; Tue, 08 Aug 2023 10:56:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKOY-000315-KA for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:56:58 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 496d3e19-35da-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 12:56:56 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Aug 2023 06:56:48 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW5PR03MB6931.namprd03.prod.outlook.com (2603:10b6:303:1cc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 10:56:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 10:56:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 496d3e19-35da-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691492216; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=2jNFxlV28QRE3OEi++L+SMgSEc3ioujoxZyvZzAKJN8=; b=S1ZiSW7sHlWY/WXjqFxOnFPWEnugxDZysqnRGwmaiAinsPk/OPl7tvRv ywcmcxljK97V17rtPPG7+ieX9kblI5uKsMRAio2re/6T41JA8qYjeyFTx +rME/NdLIwxu11Je9kc8Zc4xwI5QYZHPRbfPmwhO1iwUNhTfPft4k4I41 I=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 121486593 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KTWs762jGTbI7kH1PfbD5fBwkn2cJEfYwER7XKvMYLTBsI5bpzMCx zBMXW7TMvfZNzT1e9lza9zkoUgE7ZWHzoBrSQNvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8XuDgNyo4GlD5gxmOqgR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfG3Fr/ OM/EysxYh3eiOWfwYmLRdVDr5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6Kkl0ZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqhAd5CSuDprZaGhnWh6mgLLxRJCWG3it2Ck16jBugCc WMbr39GQa8asRbDosPGdx+3unmfpTYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACAEDs9/qpdhqigqVF4gyVqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraTxgbQHxZ6s9Lqkc2Q= IronPort-HdrOrdr: A9a23:wxLoNqBXEFI0LCflHemM55DYdb4zR+YMi2TDtnocdfUxSKelfq +V/MjzuSWUtN86YgBDpTniAsa9qA3nhPtICOAqVN/JMTUO01HHEGgN1/qF/xTQXwH46+5Bxe NBXsFFeaTN5IFB/KLHCd+DYrEd6ejCyqyumPzPi053SwJnYbwI1XYbNjqm X-Talos-CUID: 9a23:usFcLm8ZEebeIQj/GsyVv1QEP8k6VUbG8HvdfkC/IGdSeLKpZnbFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3AxRtolA1bwkmQDuntNAT9HaOZrDUj0YiqEGcEzsk?= =?us-ascii?q?8t+KgDjVgJmqn0W6YTdpy?= X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="121486593" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c6P2zQBJmJogMPGsZOxiZbGtXRCHylIPw/rCDL0jyIAZrSitBew8ZgbIODyjyjiEXFZJi6TKsiJdfBu157+hfUUL4/TU/31fPZgRnC2n3iJhe6xwTGLLH+a/8bgio4gB/QEp7/VlKcLPlzjzadaF9yayDdCvmrP1EbZWRMezv8SmWlEJ2TxI/4wO4gD+Ria6g26uR8+iGeGPqBe6xXVnH+Ijgrepdoc58yPX40igLAWQJqArElGxYxIjm/ZXEFibSiPiPf9SVJxlc60RJgNNQdJhlLI2wnEQQK866Voxmy6gOQRs4MMxp1fwfWaSUKlUAs4n6MDdf+4GX+fpCx4qZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2qCSSSOg1/cz8iOPZBvc5n7Io6CJH4Cb61rXtF0d+tA=; b=fqtrXpp3H/VH6xIUuPjxTZoNrNqbpa/PSriFGOzC4k1mPEhHDB8M7xVG1ZQVQ+aAheqC8+GOp3utuQbBRGwb+m8EFWJyVqNgN122NDshiIe4PyRxHPgIUxXi1iDPzOBQjBdeu8o+OXXLCJ7bg6IAn8HfJNg8RD79QNZOfJ7y5dg29TByvwN2LbNtJmlD/ZDdM44I1Qi9fNpP/l+SLcG088Rld7W5IqpciiAGlr82gylWF4L5UkkyklFLHTq3yCVV6s7tRWiHWY5k4J9yte8HUQ3XesWCe6epVtprY3pVC2LVdbXkNi3b2XmmbU2FRQh3MX95D0E6u5oNHdyRGhxU1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2qCSSSOg1/cz8iOPZBvc5n7Io6CJH4Cb61rXtF0d+tA=; b=EnE9ege0lZ/+ZdkFK7mw47dOx63Xwftp5LeLyWNiRgzBtdz+0m/kMBk1FLRL+EwFas3wWRYANqH9Ci28DB5QEFezdolRihFT5HD8/iM08QMKhJNRkLY13OSzsXxlUUPxGmAGEl8PqK64m8IEUXrOOzEE8fYTmQBQmdFtjTT88KI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 8 Aug 2023 11:56:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] tools: add configure option for disabling pygrub Content-Language: en-GB To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-2-jgross@suse.com> From: Andrew Cooper In-Reply-To: <20230804060000.27710-2-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0030.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW5PR03MB6931:EE_ X-MS-Office365-Filtering-Correlation-Id: c83f654e-fd11-4210-4638-08db97fe27a7 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nLcHmpzCxM1/ZiecxS+rId5b2bPtigaE3ENtZL28f32/ObIWDGStzRcISIaaZg07gUKWbRL7Gq0CzNYU2LUXJynwNE1Tei5rnIoVScuYJ2ps8llasDjJI1KmtiF0JzSCqDq7T+eN0WWpf86eOnCN8qSUIlA2R4BNbdaCtnAJbB1vtORUZ+JcY798cOc5cl4xFuEpTBPaK2Va8sU5yOIl2S0c82WSN7ibS+ZBI3KxF5/7IXQV1l1yStJZWChi2MtPi7EKmrOHHboUH6BfTv1N2FyOdotKZfVzI0tnjEkmY5HxLWTwHpIXCvEGabZelK5nS7lhoc4fCv6W/UrcFK69n2Tksi5NFGVIfMpINPncedLyb1T10LiL7ZwqHzCqIPfqVT7JRIyxWSw+i6lUpyQNygYlIP9URhz7zO7Dj3wpZzKHJEcz0QgxSEPwIWyLgNsE6fpo+PkHUko/w1RvwstYzPsbprKQ6SSRau4yYaQqsLacpHhfNvvcaEOH/a66k1sC7t9XhEeED8GwFsc5S+oVgYe7mTzi9MfsKD3dAGQUd9HOOiROw9F5qxHEuygM2/4gBieTlnPu5hSLRFv/A9ouHXgwDTkspggAJWT3fR0iS1yeIHN661PHMqM8AF6JTOEN7XkxBgJYvfku2GTj5iR6PA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199021)(1800799003)(186006)(2616005)(6666004)(6486002)(82960400001)(478600001)(86362001)(31696002)(6512007)(26005)(107886003)(36756003)(6506007)(53546011)(316002)(5660300002)(8936002)(4326008)(38100700002)(2906002)(8676002)(41300700001)(66556008)(54906003)(66476007)(66946007)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWlEYWtMTGRtc0NvSjdvWG1ncHh4YXdrL2NtTW1BOXEwekcrTnNRRTVPSis5?= =?utf-8?B?ZlpsK1hjRkpaamRQMVRqMWl0aHB4azZFekcwTytjN2w5UUJBenpETUZwcXEw?= =?utf-8?B?SldjM3l5OEpIRXE0b3dRZHZ3UTlCZ292MGdWN1ZiS0dubDArcVVjdTlsZzA0?= =?utf-8?B?NlFNL2drZHU0ZnBicmFIYVF3N1dDTlRyeHZ2MDZWUi9COFpDQ0VQVzlOZnNi?= =?utf-8?B?WGxSMG1nVzRyM25LbnM0YkNhVUs1bHdJYlJXSnBLRGp3OE5vaEFzOTIrdDZB?= =?utf-8?B?cUJTVVYrK2kvU1VNZ0MrSVovMUdBZXV6S0g5NXhkRTV2N1EweDFPR3p1Ry9o?= =?utf-8?B?R3djdHNEMzBpVFFnZkZGdlh3Q21zQlVXR3FyZTZJZnhhRmN6YlE0ZDRwOVQz?= =?utf-8?B?ODBCczJzN2VZcUs3RGpkeGpmdURSUjhtWXd4V2FCUVpkS0YvTE9PcjdHRzhK?= =?utf-8?B?OEhmZXpaU3oyWmI0QldpaFhtNzZIZzBhOWxBb1FGVTl3M2FzWEpyZCsxUUJi?= =?utf-8?B?bHh0WDRCT1BXdGlsUUFKbU41Rkl3ZXFmdVFhNlRiWDZmUTUwUjA1MTVvdXRL?= =?utf-8?B?WWxDekN2ZjZpcitVODA3UjVudmxGMjJMUDNEdGxKL1RlUmhURG5lNEM1bzd1?= =?utf-8?B?OTd1SmdDaGV1R2s5Zm1seS9hcjZnMnlxeGc0SDFpRTNEYVRlTXY3WlR0TzlV?= =?utf-8?B?UmVELzRSTk04UEFSV2IrVVVON3BIRk04QjFFY2RJQ1ZGV2tuS0JJMmMvZjYr?= =?utf-8?B?SS9VM1NaOU84ZVZlU2JVdG1nTzVvRisvUGkzaUowaW9UYXU1cWN3OGFTVkNR?= =?utf-8?B?NDRoWUZ1c2lnWjNteHZBaDJ3blRtY1cwcHZMcnNLTmJZd3JjWGpLWEt3QVc0?= =?utf-8?B?bG9oMjVrejQ2ZHlHTEV3SllZOXZhaCtxSC9zbTJZd0pYTWZHRWpXQ0huMnRw?= =?utf-8?B?VUtVZk9WWTR4QzUyNHNqRFdzYXdrNTRDV1BYZjNPakREbDZvb2lsdHlLWjRV?= =?utf-8?B?RDdSSWQ3eEhRQUJkRTY1V2ZJcWxlMXNNSU1TTloyVDk3eXlYVktJeExldGxi?= =?utf-8?B?eEx5TitsWENUcjFSV3Ztay9MbnVya1o5cVFtRjRkMzgvTVFvdUI4a0tlelhE?= =?utf-8?B?MXZ4VHdLeVNEL3UwNkN4aGEwWkhNVkVaeUp1aDRaWFJweGo3Y3V5UHNRSFpu?= =?utf-8?B?Qmo2Z3IwOUlMSkxDTGEzWXNkTmFHUXF3UkRzNGtrektKQlpQeWtxeHhwMFgz?= =?utf-8?B?dlQxRDc3SWdzRVB0TXlwYldpQ3FnaWxCQjdzQ0QyNEh5RkZPMGVUYTRGblRD?= =?utf-8?B?dFlDUzF6NFJKL0pwd0lva0hwUFdrOCs3QlFFek9vR2pMZjQxczByRVVSY3Zw?= =?utf-8?B?U1poaklyOFZ5andibjFBUHEydmxIbUJDUk0zYmZsUDdkdlJZSm55MFE1RmZ1?= =?utf-8?B?SURGK3B0aTcyWVpCbTFLNlVncmV3b1lNem15alNmZlRmS3U2RzBHTUVHY0tl?= =?utf-8?B?c24ycWVPc3VCaEt6Q1ptY2R5SVVKZGRnaEp3WkVnNGplQkZPeVRySTlDMTUw?= =?utf-8?B?dEZvMmNubHRpNVZsekdWNEg0YTFtZjV1UnR6ajlOMzdNZzdpZWxMbEVGT25j?= =?utf-8?B?ZzZCSXBlMWpmZmRaZ05ka1RTZm95R0dmT1Rxc05DRXhNTDFhSzcyYi9vTnpy?= =?utf-8?B?RlFWNlhZRk44SkRFMTBLS0x2c0UrZm9rK05IamFwendNTFh2RlE0aDFXTyt6?= =?utf-8?B?SEtxdncwOXpZYjJJQWpnTldXbm0zQS9PM0pBTUZwR2hCYVU2SkZ2SG5oSldK?= =?utf-8?B?WXVOeGVZakxmbFlQZy9meFpwVUVkUEgzTDQwcEcxNGZSTnJ3UHJnRUNiNWhK?= =?utf-8?B?U05CR3Y0NDNGeEJ0eVdxZUVIVklOcjR0NS9VMUd0ODVtTis4K2NuY1U3OXpr?= =?utf-8?B?bm9VMnBIa2tTWUtGSGlZREd5MzgwM2JHeWVrUnU5bTNuQlJUekN3anZ2NllR?= =?utf-8?B?d1hHTUNtQXNmYndCaWxabzBoMS9kOE1MZFhUR01vamVDemZSK2tTS3pPL3pa?= =?utf-8?B?T0wzVVh6eVQ0VDFyd3dub2xFKzdBY2FYTlJGViszSlloQ3ZieTVxaXo4R1A2?= =?utf-8?B?S1ZpNlBDRnIxZm9Kc1JBaW1ZdERMWWY3eU1hQlovQVNFVEhvSldNSG9WVUg3?= =?utf-8?B?eXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: m6AGP1w9yqw8AvGf26qoTbTAPThB7Q1ghtVqpuWevWxR7dGYkqDwaIw3b4QSLciezBBnjyskiHfNh2Gi3yofI8skp9DDsMn9GtG/7qlAR6T2lW/m/5SSgLw1kDVxSPUrmFO8Q9V8kxY8QU4qjjSjODkY/ZGXHn5qWvIBkxf0NJ67lJsR74Zh7o4yNKFEIFIkJ3/XZYWyWfQeUdyIjB11SHEgiQp2Sas9k74nlMi3cYls8B+kkQ41BF+be9e7w7UOmEyjvMb0HGqdYasgoKBt+l/1pPb4zpUcnIb0t6lr/NIjIcm0VqMfx8X1vnEgF0PvLhhtrXmpFyAmcSeThr1kJfxJtv2+7rmJuK5wi9EcmSe3gj5Jlxk9AH1Bu2XpI5LLZuVWH2p7wrJ66ms3dhIjctEKC3br7ZFmomVa4in2+gC6CTHDbmPFDAo1EBitvy+8ABIAUzATbjqovRCVerE9ddU19Nx1IAmEvrG4KvbE0VPYnp2LUgZib2HFiAWMEkJyzFucfcHBpGeSEFL4hacGz+GaXniZGfL8NYl62ucHj42knbC6VLcG4GjyRyG58Gelx9xFDtALH9nxKuYyNdLnw31rwV+TvMQTyO2bpph65aHfnjz/WuAJmosDnei8SWljvZJCCAZ4yCyuOHKtE+KjaPSoGc9T5s86UbgJc8BOTaq4ZhsDoJtPQZZ9d5jrqj1UhBKeu/6z1+Oz4fzC8eRurJFg5IHStu5WT1TbgE1/U+5BdLDF6GC+squuXWJFcxudI0Wv+/ZVqAv8z1AFEmWaFHDRy2MWLeTVyC/YeoTa3d1L7LAiX3T2sXpazT66nQ1u X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c83f654e-fd11-4210-4638-08db97fe27a7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:56:44.8688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RfZCsaI1CEC40kA4DWS6j0wCqjeGkS1XzvkTA81E/MPiiC6H57bTPRuuDUS7wuJA+FPOkBdqtvETsYNvwLEA4QHV5tJy3TNxtopxMcqmIBA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6931 On 04/08/2023 6:59 am, Juergen Gross wrote: > Add a "--disable-pygrub" option for being able to disable the build > and installation of pygrub. > > There are two main reasons to do so: > > - A main reason to use pygrub is to allow a PV guest to choose its > bitness (32- or 64-bit). Pygrub allows that by looking into the boot > image and to start the guest in the correct mode depending on the > kernel selected. With 32-bit PV guests being deprecated and the > possibility to even build a hypervisor without 32-bit PV support, > this use case is gone for at least some configurations. > > - Pygrub is running in dom0 with root privileges. As it is operating > on guest controlled data (the boot image) and taking decisions based > on this data, there is a possible security issue. This isn't really a possible security issue.  It's a high(er) security risk. Pygrub is still security supported, so falls under the usual security process if an issue were to be found. > Not being possible > to use pygrub is thus a step towards more security. IMO, the phrase you want to use here is "reduction in attack surface". > Default is still to build and install pygrub. > > Signed-off-by: Juergen Gross > --- > config/Tools.mk.in | 1 + > tools/Makefile | 2 +- > tools/configure | 26 ++++++++++++++++++++++++++ > tools/configure.ac | 1 + > 4 files changed, 29 insertions(+), 1 deletion(-) Shouldn't we have a patch to (lib)xl which provides a clean error message (rather than -ESRCH/etc) when the user selects bootloader=pygrub ? Fine to be a separate patch, but not something which wants forgetting. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 08 10:59:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 10:59:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579625.907685 (Exim 4.92) (envelope-from ) id 1qTKQo-0003eC-9x; Tue, 08 Aug 2023 10:59:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579625.907685; Tue, 08 Aug 2023 10:59:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKQo-0003e5-70; Tue, 08 Aug 2023 10:59:18 +0000 Received: by outflank-mailman (input) for mailman id 579625; Tue, 08 Aug 2023 10:59:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKQn-0003dx-OA for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 10:59:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c853bac-35da-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 12:59:15 +0200 (CEST) Received: from mail-dm3nam02lp2049.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.49]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Aug 2023 06:59:12 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW5PR03MB6931.namprd03.prod.outlook.com (2603:10b6:303:1cc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 10:59:10 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 10:59:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c853bac-35da-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691492355; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=240ItFNQDfsYGdaD7F771Y48LREjkKdZjnYUTIJFswY=; b=QCQ7th9GbXnjTWr+420uvptgtXXw7sqyGbqdx+9X/YoNQgIu78wKjWK6 b5VpCyFPUIs/Jn8eomhNzddoiWkA1BkMKDl1HyWvF2f/GhQbzz5tOq/vW 2GC3CvUffotsuDec/kg6XlLl2C5B7/a8o76DpqAWWbmX7xlqaE1Tk1pUi A=; X-IronPort-RemoteIP: 104.47.56.49 X-IronPort-MID: 119269582 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zpJNfaicoMIThOIkqL7+g6bvX161whEKZh0ujC45NGQN5FlHY01je htvUDqGOvmPNGP8Kt5wa4S0/UlTu5/RndBlHAE9ri5jEn4b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT7AeBzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQXMjJOZ068ldnv/5aFdtNq2Z44NZTkadZ3VnFIlVk1DN4AaLWbGeDmwIQd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEvluS8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTeziqK830Af7Kmo7FxoTXmaKnMmC1RS0R/FaC G0M9wV0ov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz FiisywWl7gVy8kR2M2T913dnyiloJSPSwcv/xjWRUqs9AY/b4mgD6S27lzc4edFPZyuRFCLt 3gZmOCT9OkLS5qKkUSlW+wLFaq17u2ENxXGiEZzGIMs8Tus/XOuZ4FW73d1I0IBDyofUTrgY UuWtQYK4pZWZCGudfUvP9P3DNk2x6/9E9ijTurTctdFfpl2ckmA4T1qYkmTmWvqlSDAjJ0CB HtSSu70ZV5yNEit5GPeqzs1uVPz+h0D+A== IronPort-HdrOrdr: A9a23:6MRrKasSUcIGsOZ6vBNbLyhk7skDVtV00zEX/kB9WHVpm62j+/ xG+c5x6faaslYssR0b+OxoEpPwI080lqQb3WBuB8bGYOCOggLBRuxfBODZrQEIdReOkNJ15O NNdLV/Fc21LXUSt7eC3OBgKadF/DBQytHOuc7ui01gShxwe+VY9AF7BgyHe3cGJzV7OQ== X-Talos-CUID: 9a23:SjoXKmG+sB6t19GpqmJo7kxXE54aYEaE81PuH3W+VjxyUeCaHAo= X-Talos-MUID: 9a23:jQalJQgHc1kqYuFqviRovMMpK8Bt6JmfNXA2zs8Mp+qBFg1oNhjHg2Hi X-IronPort-AV: E=Sophos;i="6.01,263,1684814400"; d="scan'208";a="119269582" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIW0PeUib6h3xgKSHp/L3/4Awl9DPFw0aygqG/LOyRNu26GOW3dW1g5g8mcDVyHCalWQVZ9JpIyHigAe7SALfu1RMVule30TDb+2twWRCNksJJowItFRNr/hjv79rmO98vU1TuaqZDthjaeqcV/zQRDxP1lVNpwCOghdnF4wBXauPFEKe0OVjOv720TrvKA3mdOIChLehPS6vNFBbr03I3d2WRknBqB2U71Jca7qUDS09eqeQUBQ14+I4y9nK1OgoF/R7lbNcZDEFdKt3AJA5i6vGBUOEruPN4ZaXY0ZmbqlZjvnmPwi+Kst/iIxecpgqMhRk+qDHSkVbWtY8xXGww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=240ItFNQDfsYGdaD7F771Y48LREjkKdZjnYUTIJFswY=; b=oG06pq7a+pwP+q0LWx3wXIDT/BhHMuHWBXO6HcXnbhIgL4D4OGOEslYUhlHeMx4uVuutET35kgoZzAfvmNpu1cIZxTRg6FiL/GYa2oboJRGq0IPTpyRfuYBAsdzqu+m6v2SlJxiPh0Nx/dKBERv6/lC7PbXZNKQHMAnYxQNLalS/h2BIO9BZlo5DE7hJQe5WLzin4XcpZvkBx8iPpgG/bCw2Or8uhHrDO4rv0tWUTzLmF6ZBVps2WWwuBBo1iILcjSL+LUVgZxNhDiFrK+DB6P0uwR//JHpSOyFa7uneDfAONjhgblGNsrnXkN6e2xGCqPg/Xtsi53n+eWoIVWE/Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=240ItFNQDfsYGdaD7F771Y48LREjkKdZjnYUTIJFswY=; b=Mu4qUisjfLKgKFy9ccflV2xsKsC0lMQMfW23tTIC6dd23kEUCGrO2PtL1kZeEnmteCv1k7IwbXscsJgjUbWJo68f7a19CiPAsniuJTsg9Rb9lYhkNeSHIdj6uqo9rmTG0jmNE2NB+UB+zDLdk9AiAwrhWSCbQqhWiBhljcbdSvM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <3ab0e8b5-05a8-6157-28df-d40cceafef06@citrix.com> Date: Tue, 8 Aug 2023 11:59:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] move max_page and total_pages to common code Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0131.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9f::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MW5PR03MB6931:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e18d40f-ca3b-4fd6-d414-08db97fe7e5c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FnhVsF80jaoBENjx9TSzEL8jE8nqQogUalJlBigHYVi8scvjlvhJND0vOyLjlCfdDM5kpln7KXnve8rMe3GmthgWiTvqmsaZCoso+6dVHe5psdeSrQAVUvOzs4icKv+DQw4EZ7Pu7U8DL3VIxu6ctkVLtu6TimrEVxop2sQLSeuAmZZlBUdi3fIKe652pD99qhF08twY+MSoE6L9OfIiqP6EuuufsEj1S1BH18CO5H16UnpmIJk4LEuw9WjQWNRNASYV5GekHpF/WqPx1a1QTEkDVYXFCIuaCNCywKKoQRkkKDOTfxCZPWtlz/h0pVGA9ypoUccLxQPXobc3WDHXxiSwmwfXxalwSFCsJ7c2g6i/6K198ffwn/LWSoZvjy/d1mxvux6EBwD4DNuyrXxg5rqEzLALYsiDggKhPHSblP0p85St/Jc/p0uP7nysIE6Qht+j8iavhx7sVy+DMjbq/dLBlu1IIJ19izxYvWz2KtIEMa+tQZNzF8MnC1suCbp+28iiHC37Sk8bI0BmERyAWn6v7hW+Hy1B197yVOndwYGUrUUihXIOrUNdKId4Mlvu5kQOvxHC9VDJWTZ5KH8McV3x5aOqAJRNyNQdKcJ0vtXlzhNc8cgCqb5uMtYYA0R49qRKjQ6FaTSmWRB8lnwW8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199021)(1800799003)(186006)(2616005)(6666004)(6486002)(82960400001)(478600001)(86362001)(31696002)(6512007)(26005)(36756003)(6506007)(53546011)(110136005)(7416002)(316002)(4744005)(5660300002)(8936002)(4326008)(38100700002)(2906002)(8676002)(41300700001)(66556008)(54906003)(66476007)(66946007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vzd1STVVU3NoZzBzRWxKWkNsZysxdlhseG1jclBGL3B6c2xYL0NnOC9MQytS?= =?utf-8?B?Q2F3RkwzVHJXdk4vb0hScDU4L09IQU9GOTdoQ2R1cHA1dUFnWmJ3cjFqUGJo?= =?utf-8?B?c1JsL0RiaGFSa1NyMDRnZmdUYWRSRHM2ZC9sSHp4S2RHQkZwbm95bi9HdHN6?= =?utf-8?B?WEZCOUtYeUNYM1FBaGpMaFYwUEdZZGRQVFkzZWRLOVhCTlhkRW1xdXVvaVdX?= =?utf-8?B?dTFtUnBzWFFNaFBWNXVzV1oxeE1ZUFV6dG9HRTgwVGJEYTdYWnlGaVJYMFlk?= =?utf-8?B?eWxzT1dvZVFERkhrWDNFNFMwOUVob0puclZzZGdmcjBzbHljaUVFTFdTbW9G?= =?utf-8?B?c3RybWVVdFQ4K21va1RwMzRJWWkzeGo2U0Zoc0dKbHYzeERzR0ZvV01xTlhi?= =?utf-8?B?ZEJMQXBGZm5pbVFJTkN2UlN6Wkd2bVVtTmhYTUY2d1NvcGxYYmtxSmp4NzF5?= =?utf-8?B?bk16VEVrbVd6OHZDYmJkUmY4T2FyWUlVUHdYemZxZlNLN3VEcEJJaytqVi9x?= =?utf-8?B?MkJiTmFMbDRFRi9RZzFYZkV5MXQrN3hISTdNNlZEdXhKeHFvMDF3L2RBeURQ?= =?utf-8?B?VjhwYzFCZko1RGpVRlJKUkFxcTBoc0F0dDJ4cXFkcnBGcGlSd29ZUkV3cjZa?= =?utf-8?B?bEdiVXNEOFRkMUw1eEJSOUY0em0zRFM2enBnU2x4aHJGRHZYY3pHSm5jaDZs?= =?utf-8?B?clNxL3B6MjU1RS9INFdEc2JPWmpFRlhnd1huWHA3ZDJ1KzE1TTdnQzQvVjZB?= =?utf-8?B?bmF5TUJ4cTIvNlFZU2FaeFI1QUhrc2ZSWGhWeUlDa2VxRVJ6clNCOURKYzZh?= =?utf-8?B?UDZnUW5VMkU1eDRJOXQ3eTdQUzdBTHNyY0lGQ2F2OEpnUitxVGxtdkw2a0hy?= =?utf-8?B?MXl4ZWYyMEx0TUpidFExTnJ1WXJjeEppTGlzRlRNZWE2VEV3bU9BZjVaQk13?= =?utf-8?B?bkk4bDBhaHo0WnVKS3BIYlFpTjhVRk1ZU3JIeUlpQ2V3QjlvaExFclZOVXpI?= =?utf-8?B?VkpWMUJxOHZWSXo4YXh2MFRNV2p2VEg2bVVDdjdDMnNXVUVtTkJIb0ljRDFn?= =?utf-8?B?U2xyL25PUThIanJvcTBINUs4UjdLMnVjTTJjdnFnQmVGQlpGa092WU9LL2R3?= =?utf-8?B?eHE1bG5GZy9GYTBoejg2MGwrZUprYWd0TVFyM0FoOENQbWszVzB3Z0JEei9h?= =?utf-8?B?Y3FqaUtSNWo5d25VUWJpcjRtQXFjNVZQYno4S2VjMFhhQVdtamJNMlFhMFhn?= =?utf-8?B?eTIvdm50R3JMdG51cjJEU1hLRGNwSUFJMkVCbUlScmk2eEtDTTNYUFRZQWF1?= =?utf-8?B?Q0c0MDNPZXRyZnBEYTg1a213L0tvSHlpTVhEYktsSTd5VGR2WW5aSGxESlhl?= =?utf-8?B?WG1GRERDckxkSlE4Q2FSenk0MHJSMkVzakpiZzFMb1p0SXgvcVJJcDdWeFpi?= =?utf-8?B?Nkdqdlk5dk56eVFPNG4vdmt6Um9QekR1dXAxcWhmeWZrQmNiWmxJS29ZOXpX?= =?utf-8?B?NmNBcmlTYmFQN1dIeUpObkNvbG01b21vSTJsc2ZKQ3pnaGhEQnkxbVoyend5?= =?utf-8?B?ckw2QzdRMzFicEZsV3dmZUpZNkNPWE4zUkxWMHF0OGxWQmpYai9WTkRkcENo?= =?utf-8?B?NGlKWVZMT0p6dGJTWk16b1BrODhSS0c2eVljWXdDbk9ISVRvMlhkTWg2SW9P?= =?utf-8?B?cXRrTjI3dGVMSmdhZ1pvN2RNTk5HSm54ZCthdkZQSGxKNlU4RjBSMUFWUzlD?= =?utf-8?B?Z0FQRWt5WlJBY3dwRHEyWldSWUViL1pVbGVuYVhTb2VKZ0FDalZwZEJtMnlm?= =?utf-8?B?NE4yMGxRb0M3TlVrcnRHTnNhcGh3TDEveTVtcXdza3FMSjJneWwzL3h1OWkv?= =?utf-8?B?UnBkZEtTcTlOZzlSbDJLMHU4Rlcya084Tzd6WVRtL2F0UUo2NFZjdUVXKzla?= =?utf-8?B?cUExTlF5cU9QY0FZclR1dy9wS0R3ZkF3L1ljUmtqU0QzVlZkZGFzd0ZqWXRa?= =?utf-8?B?L2dSNWRySC9sQ2VVOWJVejJPMUVKeFlnTkFWSWJYVklneTVRWnRpMnZMVkox?= =?utf-8?B?NFkwaGdWdk5IVG5lcFVWMG1FaS83Ym9UQkJvS3RZRE5USFd1bUM4eFlpQlNB?= =?utf-8?B?bXUraWxMbjJybmdKaWh2WGtVSlBFZS9DUE5PK1NxT3Jsc3NwTTRsTGliOUds?= =?utf-8?B?Y3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UnhwZDh5TTBKWnhKTTNNRHFnVm1uRkpQbWRnWjA1QnhLaEc0RU9xeHZ2eUs3?= =?utf-8?B?bTJmNDRxbmloZVNhaTUyOVpVSjBxV1JIY1pwOXlWNWt5Q1lvaVVHbms1dTBp?= =?utf-8?B?Q0JCSHd0U0U0QjN2RHFwZ0N5RitTYlByZGhySWJ2UnNFbk5GV2E2RmZBM242?= =?utf-8?B?K0tUellZV01aWjQzY0lsV24xZlJXQ3ZOZFZLenFtVzBsNmtvOGNNN2tjZzlY?= =?utf-8?B?RTdla1dNcXMvUHdpc29idmw4Vmx1YzNwTXgvKzEzOC9GdnpVQ0hsWWpCdWZR?= =?utf-8?B?K2FRRWhVdVFOVllaRlNRTzZDVDBEWFNsaG45T1RRdW9LMm42RU1rZVFYaU92?= =?utf-8?B?Rm5seG92VXhjMDEzQWhCU2g4cFFDcmdHVStTYzBkWDhIWjN0RFZSRVJLaEUy?= =?utf-8?B?cCtIWFovYkNSeXJmNStyZjNIQTl1K0d4RmhzZ3BkTndDeU84Uy9keUdRQ2pi?= =?utf-8?B?TmlZVEt4WXhNdW84MlZSUDd6Nkt5MkdJY29uVE1ydnNiT0o0MGNDR3hxTlN3?= =?utf-8?B?dm85WmkwRHYyVTlaZXN0YUdVS1FHR3p3QWF0UnNjYjEzbHBMOXpRTk1BK0N2?= =?utf-8?B?TlowbHJPbVBGZC9UNDdMbnB5VndoM0hoN1hoNkFxZk5EQU82NmJFUHZncVZI?= =?utf-8?B?UVRmbHpHeGtBZHdnYytFZU9iM1RZaXJsMXBFNzc0eXh6cTRkVHAxUHBlUGRB?= =?utf-8?B?NzJ0VS8zNUJsSXErdlFEck1vOWJ0Unp1d0VFM0RycGV2QjU4SWVNME1mcW43?= =?utf-8?B?Yk9RaGJGOHFXWlU2aGhxelJIVkNHUmZQQ1ZSeUZySW1DMmRrcUhZaEJ0Y1dh?= =?utf-8?B?SnN4QXBERkRBSnJ4b0Y3TTlrMmU1Z0lzNFlCZkxTcC83a3BUTWZWbXEwY0R2?= =?utf-8?B?bXg5Y25GOTVtSllka2VGSWlyRW1XaU1ZNXIzWGIzQ3RJa0ExT1JZbnhDS1J4?= =?utf-8?B?UW8zWFBpWmFvS2p6OXVFOUxuVnFSY2tORmx3WTk3SVlqUmlGY21qMHJwNERa?= =?utf-8?B?aFpCdTdkdmR6UWVGSzhPaWdGb1FVTUVVY2c0SXorYzRObXpWMHFPYmRtbDJF?= =?utf-8?B?V1VqRUhsM1VZdHV3QUROeXBNck10MDB1QnJLbEdMS2luL2t2U3FYcStqVXJj?= =?utf-8?B?cklvMnVDVUxWYUZWOTZpYU96MUp0Z3h0TGxuUit6aCs3NGtDQU9LZ0dPT2JP?= =?utf-8?B?N1R2OTRnRVpHRjlYZko5L2tTRjhGUjZRcEg5YXlxUkpTSThzSDhsV0dFVFJv?= =?utf-8?B?Q0svYkZCeGZ1aDZIUUxhRUsrU1Rnb2tlZ2FXa2RjK2RkZnYydz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e18d40f-ca3b-4fd6-d414-08db97fe7e5c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:59:10.3232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F7HwleFaBZ8RRKwJcsQtTlpUl0dyCyyfxrZechgwqaAGfdwk4/4h6++4HBeR0p/xPHYf4jwvW6Jeo9NASLi2i6ClnCk5JeNM7oiz3ZoE5gw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6931 On 08/08/2023 11:47 am, Jan Beulich wrote: > Common code references both, so the variables shouldn't need declaring > and defining by every arch. While moving the definitions, add > __read_mostly (__ro_after_init would only be appropriate when > !mem_hotplug). > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:03:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:03:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579632.907694 (Exim 4.92) (envelope-from ) id 1qTKUl-000588-Qa; Tue, 08 Aug 2023 11:03:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579632.907694; Tue, 08 Aug 2023 11:03:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKUl-000581-O5; Tue, 08 Aug 2023 11:03:23 +0000 Received: by outflank-mailman (input) for mailman id 579632; Tue, 08 Aug 2023 11:03:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKUk-00057v-GU for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:03:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f2ca625-35db-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:03:20 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CAC2E2031C; Tue, 8 Aug 2023 11:03:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9BA46139D1; Tue, 8 Aug 2023 11:03:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fsBGJPcg0mTVRwAAMHmgww (envelope-from ); Tue, 08 Aug 2023 11:03:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f2ca625-35db-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691492599; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qodi7cWZzIyQxgbGlhauM6FDc8cfLIWh9gf+S++C2Z4=; b=XsAwUa+FzgnLkoQQ0N2TqGGrDsmyWUag34JpdlsXJr0ExcLTm1g/EWkiaOqXRXolwIQFPh FN24RAKK215ShD5NpVhFPZ0oqd2acwZgzWZsMclUHREX4S7X+yIFWsM3ZJQjQDMp2AwfUu tdPp54dQPj/cykafk74yqUAcVYqlBVA= Message-ID: <77a85400-91b7-f560-9581-7ddfe5667853@suse.com> Date: Tue, 8 Aug 2023 13:03:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] tools: add configure option for disabling pygrub Content-Language: en-US To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-2-jgross@suse.com> From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3LNuFQBYUNSPDYNLL0xigtBd" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3LNuFQBYUNSPDYNLL0xigtBd Content-Type: multipart/mixed; boundary="------------m0f6FjJmF066Uurzwru0JOml"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <77a85400-91b7-f560-9581-7ddfe5667853@suse.com> Subject: Re: [PATCH 1/2] tools: add configure option for disabling pygrub References: <20230804060000.27710-1-jgross@suse.com> <20230804060000.27710-2-jgross@suse.com> In-Reply-To: --------------m0f6FjJmF066Uurzwru0JOml Content-Type: multipart/mixed; boundary="------------Gj0rgRjsBl0FHbvDu5LRuzKe" --------------Gj0rgRjsBl0FHbvDu5LRuzKe Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDguMjMgMTI6NTYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IE9uIDA0LzA4LzIw MjMgNjo1OSBhbSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IEFkZCBhICItLWRpc2FibGUt cHlncnViIiBvcHRpb24gZm9yIGJlaW5nIGFibGUgdG8gZGlzYWJsZSB0aGUgYnVpbGQNCj4+ IGFuZCBpbnN0YWxsYXRpb24gb2YgcHlncnViLg0KPj4NCj4+IFRoZXJlIGFyZSB0d28gbWFp biByZWFzb25zIHRvIGRvIHNvOg0KPj4NCj4+IC0gQSBtYWluIHJlYXNvbiB0byB1c2UgcHln cnViIGlzIHRvIGFsbG93IGEgUFYgZ3Vlc3QgdG8gY2hvb3NlIGl0cw0KPj4gICAgYml0bmVz cyAoMzItIG9yIDY0LWJpdCkuIFB5Z3J1YiBhbGxvd3MgdGhhdCBieSBsb29raW5nIGludG8g dGhlIGJvb3QNCj4+ICAgIGltYWdlIGFuZCB0byBzdGFydCB0aGUgZ3Vlc3QgaW4gdGhlIGNv cnJlY3QgbW9kZSBkZXBlbmRpbmcgb24gdGhlDQo+PiAgICBrZXJuZWwgc2VsZWN0ZWQuIFdp dGggMzItYml0IFBWIGd1ZXN0cyBiZWluZyBkZXByZWNhdGVkIGFuZCB0aGUNCj4+ICAgIHBv c3NpYmlsaXR5IHRvIGV2ZW4gYnVpbGQgYSBoeXBlcnZpc29yIHdpdGhvdXQgMzItYml0IFBW IHN1cHBvcnQsDQo+PiAgICB0aGlzIHVzZSBjYXNlIGlzIGdvbmUgZm9yIGF0IGxlYXN0IHNv bWUgY29uZmlndXJhdGlvbnMuDQo+Pg0KPj4gLSBQeWdydWIgaXMgcnVubmluZyBpbiBkb20w IHdpdGggcm9vdCBwcml2aWxlZ2VzLiBBcyBpdCBpcyBvcGVyYXRpbmcNCj4+ICAgIG9uIGd1 ZXN0IGNvbnRyb2xsZWQgZGF0YSAodGhlIGJvb3QgaW1hZ2UpIGFuZCB0YWtpbmcgZGVjaXNp b25zIGJhc2VkDQo+PiAgICBvbiB0aGlzIGRhdGEsIHRoZXJlIGlzIGEgcG9zc2libGUgc2Vj dXJpdHkgaXNzdWUuDQo+IA0KPiBUaGlzIGlzbid0IHJlYWxseSBhIHBvc3NpYmxlIHNlY3Vy aXR5IGlzc3VlLsKgIEl0J3MgYSBoaWdoKGVyKSBzZWN1cml0eSByaXNrLg0KDQpUcnVlLiBJ J2xsIHMvcG9zc2libGUgc2VjdXJpdHkgaXNzdWUvaGlnaGVyIHNlY3VyaXR5IHJpc2svLg0K DQo+IA0KPiBQeWdydWIgaXMgc3RpbGwgc2VjdXJpdHkgc3VwcG9ydGVkLCBzbyBmYWxscyB1 bmRlciB0aGUgdXN1YWwgc2VjdXJpdHkNCj4gcHJvY2VzcyBpZiBhbiBpc3N1ZSB3ZXJlIHRv IGJlIGZvdW5kLg0KPiANCj4+ICAgTm90IGJlaW5nIHBvc3NpYmxlDQo+PiAgICB0byB1c2Ug cHlncnViIGlzIHRodXMgYSBzdGVwIHRvd2FyZHMgbW9yZSBzZWN1cml0eS4NCj4gDQo+IElN TywgdGhlIHBocmFzZSB5b3Ugd2FudCB0byB1c2UgaGVyZSBpcyAicmVkdWN0aW9uIGluIGF0 dGFjayBzdXJmYWNlIi4NCg0KVGhhbmtzLiBJJ2xsIHVzZSB0aGF0Lg0KDQo+IA0KPj4gRGVm YXVsdCBpcyBzdGlsbCB0byBidWlsZCBhbmQgaW5zdGFsbCBweWdydWIuDQo+Pg0KPj4gU2ln bmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4gLS0tDQo+ PiAgIGNvbmZpZy9Ub29scy5tay5pbiB8ICAxICsNCj4+ICAgdG9vbHMvTWFrZWZpbGUgICAg IHwgIDIgKy0NCj4+ICAgdG9vbHMvY29uZmlndXJlICAgIHwgMjYgKysrKysrKysrKysrKysr KysrKysrKysrKysNCj4+ICAgdG9vbHMvY29uZmlndXJlLmFjIHwgIDEgKw0KPj4gICA0IGZp bGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IFNo b3VsZG4ndCB3ZSBoYXZlIGEgcGF0Y2ggdG8gKGxpYil4bCB3aGljaCBwcm92aWRlcyBhIGNs ZWFuIGVycm9yDQo+IG1lc3NhZ2UgKHJhdGhlciB0aGFuIC1FU1JDSC9ldGMpIHdoZW4gdGhl IHVzZXIgc2VsZWN0cyBib290bG9hZGVyPXB5Z3J1YiA/DQo+IA0KPiBGaW5lIHRvIGJlIGEg c2VwYXJhdGUgcGF0Y2gsIGJ1dCBub3Qgc29tZXRoaW5nIHdoaWNoIHdhbnRzIGZvcmdldHRp bmcuDQoNCkknbGwgYWRkIGl0Lg0KDQoNCkp1ZXJnZW4NCg== --------------Gj0rgRjsBl0FHbvDu5LRuzKe Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Gj0rgRjsBl0FHbvDu5LRuzKe-- --------------m0f6FjJmF066Uurzwru0JOml-- --------------3LNuFQBYUNSPDYNLL0xigtBd Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTSIPcFAwAAAAAACgkQsN6d1ii/Ey/C xgf/aHi7DSv1X+BSJUoiAXrp1SOWj8H+uLAn7VNbulQCwRzMHY8F8oLrYxiB9AAeosLwFIsZXIU5 UUxwodeTxUjSvnY3KZ3mnHCTUzISMvg8CPW0jlkkPflp+TNHm7AW66D18BSOdZlSnyUMsdKFlOya 77ZiG4mQq4Iq79XFER1OuRVEds0yrPWHmLvb4rLAhXmIYqIDOMlQqw5CF/P93vfmw+1JE1DRTLN+ gDcSmN0qrGR0fjyUGOMYzY5EsvtP7JcDqgMmROU+NScM80+1USf2k3nI1T7Nq5283C6yKT+VWif2 3Kk3J5XO5EJ8dSByPfydY+SFqMIsCHEsNu/N/wkVNw== =84oy -----END PGP SIGNATURE----- --------------3LNuFQBYUNSPDYNLL0xigtBd-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579638.907704 (Exim 4.92) (envelope-from ) id 1qTKZe-0005n7-EI; Tue, 08 Aug 2023 11:08:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579638.907704; Tue, 08 Aug 2023 11:08:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZe-0005n0-Bj; Tue, 08 Aug 2023 11:08:26 +0000 Received: by outflank-mailman (input) for mailman id 579638; Tue, 08 Aug 2023 11:08:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZd-0005mu-8c for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:25 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20609.outbound.protection.outlook.com [2a01:111:f400:7eaa::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e22fdd38-35db-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:08:20 +0200 (CEST) Received: from CYXPR02CA0013.namprd02.prod.outlook.com (2603:10b6:930:cf::24) by PH7PR12MB7283.namprd12.prod.outlook.com (2603:10b6:510:20a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 11:08:13 +0000 Received: from CY4PEPF0000E9D8.namprd05.prod.outlook.com (2603:10b6:930:cf:cafe::ee) by CYXPR02CA0013.outlook.office365.com (2603:10b6:930:cf::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 11:08:12 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D8.mail.protection.outlook.com (10.167.241.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Tue, 8 Aug 2023 11:08:12 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 06:08:11 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 04:08:11 -0700 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 8 Aug 2023 06:08:10 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e22fdd38-35db-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l46pOAumjyeX78+zlSS9q2c8A1hOLH0rCZ88GS2nidC0sr9Me5WGMYOvof9LCSpYMtj8nhzYr32hPfRNv8v9QLAzZoTBNpyEvRJ+cQEXPIxa60Ub5Ltp09JBwi3I0ohCzyKf4V+MF0mPQ10124axr3t7oyvys5T9PCFHG6ZTFNsTm8Q4ZNWVATU8Zxco2IM7fM1vReT/h4Qo9T8BZTJ/MdfH/FZ1eHqLS/cexJPorwr5sTbt5ZpurXdbm5qTkB2TQsz6SnTsTU4WSvBJuuz1mkjDQXjzo+I7KpJxRPaOBnbnMC9OIAyLVZQK5MfdeyTPqACcVOPyYoBMVbEC+iZjLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hi0xi37ivdqnavovEZwHm4E3+cicdkaCXIVkuc06OwA=; b=bxLquCMPOJEsu3UToGYj6I+smSMyevVetq9buA9Qd8dC0Rawv+/KzJujt/1/U1NddOMbFOv71qApArvnGChzb3UZpgzAicpRdcuhGsugce1JuRNtH84+0NMEJSHWcPlpJnviZRtKjuTXHISeDjJxLV59GdvpgnGsX+YeCeNMfnQUjq3zWLREK7SWaw2CXpYPqBXoClMBp21Xjs2ZTq+ejn0wzFLvQmhMeALzW+jfJTEYPXS1CjVho5k5OQkxSp7oV4/380VpkstGSBfg2lTCrttneboRw7tXadoAy12d/hws/xm9cyX0mh7gZyeOnLfyAwNq2cmuRqoEKsjGsEVTDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hi0xi37ivdqnavovEZwHm4E3+cicdkaCXIVkuc06OwA=; b=HNJk65u0/Ml03Jg7YVgXruAYeNiSdy5BQQcwyTfgTwZ13W3vsRClEQ2DWGpqbHCB5CYcMulfqqYJWmJ3P7vEQg81R05pnBOC52tf4J4IXaCakb52mCwgtSsFzoeauScx+sk3HfvrKwpzBAxOQcXSlsJxi6HuJGuHJKoHMhKMGS8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm64: head: Introduce a helper to flush local TLBs Date: Tue, 8 Aug 2023 13:07:39 +0200 Message-ID: <20230808110739.1296-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D8:EE_|PH7PR12MB7283:EE_ X-MS-Office365-Filtering-Correlation-Id: f24e20f8-192f-417c-2192-08db97ffc18e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B0P1CZDQni3sh3uR2xhjue+eNo6UdVIkRFgQ6Zsm91UczCyfNdKpQ+hFml8r/sNo027WSXHu42Q7Krmu2tlhL9vdsRfNcUfVvCfLzoIMHJL5EJCCOnTlJJMOU5x3VR2VK31geNTCIEmkIK+Kf4pHMtvNpCrLXGBgBlDuuF0tbZWFpBiR2doofbrmirhr/MPkZz+F8VSQt2wA3+9bgsDKI+mjkNHsBsMfzNcf2ZfbXgQDB7lPNdiuRYvmVtxNveOZzsgEr4nDRmyDBJJgqSC/SicQ3A35nVMSwB1HDgivR2KnZLci1saLrHLY+Zqpy7f2N7ge/EnnbCnsY/hGJwNOq+cjEDjxKZ2iS6B3FizidoncFg8+IezIFvcUlftl3nTa+tjQ05wldiCF+d8cJQoI4UOJNg1nHT0gdMqiRjf/o4W4VxlHqKhkjfvOKTPQ859it2RASznbB87na7o8/aLYlLi6ANoOu4D3E1LukDJ3mxricY4Om86BSblifmOlYj5VfthNTaic/04kmAP99QWcoK+c8v8e+SBCH+BjjRP+Jskxbs4LMP0jrmGOAKlJAkaSvdagoGmAt/kF7KLCNr1ntC4xlV0YfuTJ967ZWob5m1SMG1HdLBOmz1NHG0qc8OFw34YbrWciO6BvE7y1J6TwG4RNEF8sfDoN5SUK5sfRfmb7xVtGniroTbszOOu8LP9iA6kua7rq2kd+El3ST9dGsp0AK4onmfpJQxI+EvrJV6zvVbAuhXMT1eQS2HjarHpMLbghQ4Mro84Ew54Pj9oTKg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199021)(186006)(82310400008)(1800799003)(46966006)(36840700001)(40470700004)(40480700001)(2616005)(40460700003)(6666004)(356005)(82740400003)(478600001)(86362001)(81166007)(26005)(36756003)(1076003)(41300700001)(5660300002)(8936002)(316002)(44832011)(8676002)(54906003)(2906002)(6916009)(4326008)(70586007)(70206006)(336012)(83380400001)(36860700001)(47076005)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 11:08:12.1735 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f24e20f8-192f-417c-2192-08db97ffc18e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7283 Instead of repeating the same sequence of instructions to flush the TLBs in various places, introduce a macro flush_xen_tlb_local and make use of it. This is similar to what was done for arm32 by the commit: dea9dddeceec8a1d68da24b14d5b2396effe555f This is also making the flush sequence in enable_mmu more clear and consistent. Signed-off-by: Michal Orzel --- xen/arch/arm/arm64/head.S | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 31cdb54d74e5..8bca9afa27b2 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -136,6 +136,18 @@ add \xb, \xb, x20 .endm +/* + * Flush local TLBs + * + * See asm/arm64/flushtlb.h for the explanation of the sequence. + */ +.macro flush_xen_tlb_local + dsb nshst + tlbi alle2 + dsb nsh + isb +.endm + .section .text.header, "ax", %progbits /*.aarch64*/ @@ -721,8 +733,7 @@ enable_mmu: * The state of the TLBs is unknown before turning on the MMU. * Flush them to avoid stale one. */ - tlbi alle2 /* Flush hypervisor TLBs */ - dsb nsh + flush_xen_tlb_local /* Write Xen's PT's paddr into TTBR0_EL2 */ msr TTBR0_EL2, x4 @@ -786,11 +797,7 @@ remove_identity_mapping: str xzr, [x0, x1, lsl #3] identity_mapping_removed: - /* See asm/arm64/flushtlb.h for the explanation of the sequence. */ - dsb nshst - tlbi alle2 - dsb nsh - isb + flush_xen_tlb_local ret ENDPROC(remove_identity_mapping) @@ -872,14 +879,8 @@ ENTRY(switch_ttbr_id) msr SCTLR_EL2, x1 isb - /* - * 3) Flush the TLBs. - * See asm/arm64/flushtlb.h for the explanation of the sequence. - */ - dsb nshst - tlbi alle2 - dsb nsh - isb + /* 3) Flush the TLBs */ + flush_xen_tlb_local /* 4) Update the TTBR */ msr TTBR0_EL2, x0 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579639.907715 (Exim 4.92) (envelope-from ) id 1qTKZv-0006Am-Ps; Tue, 08 Aug 2023 11:08:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579639.907715; Tue, 08 Aug 2023 11:08:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZv-0006Ad-Mb; Tue, 08 Aug 2023 11:08:43 +0000 Received: by outflank-mailman (input) for mailman id 579639; Tue, 08 Aug 2023 11:08:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZt-00068O-UK for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:41 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edf280b3-35db-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 13:08:40 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 333A84EE0737; Tue, 8 Aug 2023 13:08:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edf280b3-35db-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant , George Dunlap , Julien Grall Subject: [XEN PATCH v2 0/5] x86: address MISRA C:2012 Rule 5.3 Date: Tue, 8 Aug 2023 13:08:02 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series addresses shadowing issues to resolve violations of Rule 5.3, whose headline states: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope". To do this, suitable renames are made. The thread of the first submission is here [1] --- Changes in v2: - Addressed numerous review comments - Dropped patch 2/6 [2], as that has already been committed [1] https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg00538.html [2] https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg00539.html Nicola Vetrini (5): x86: address MISRA C:2012 Rule 5.3 xen/delay: address MISRA C:2012 Rule 5.3. x86/include: address MISRA C:2012 Rule 5.3. x86/xstate: address MISRA C:2012 Rule 5.3 x86: refactor macros in 'xen-mca.h' xen/arch/x86/e820.c | 36 +++++++++---------- xen/arch/x86/guest/hyperv/hyperv.c | 4 +-- xen/arch/x86/guest/hypervisor.c | 2 +- xen/arch/x86/guest/xen/xen.c | 4 +-- xen/arch/x86/include/asm/e820.h | 3 +- xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- xen/arch/x86/include/asm/mpspec.h | 1 - xen/arch/x86/include/asm/pv/shim.h | 2 +- xen/arch/x86/pv/shim.c | 10 +++--- xen/arch/x86/setup.c | 8 ++--- xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- xen/arch/x86/xstate.c | 30 ++++++++-------- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- xen/include/public/arch-x86/xen-mca.h | 38 ++++++++++----------- xen/include/xen/delay.h | 9 +++-- 15 files changed, 78 insertions(+), 75 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579640.907725 (Exim 4.92) (envelope-from ) id 1qTKZx-0006Qp-2M; Tue, 08 Aug 2023 11:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579640.907725; Tue, 08 Aug 2023 11:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZw-0006Qg-UT; Tue, 08 Aug 2023 11:08:44 +0000 Received: by outflank-mailman (input) for mailman id 579640; Tue, 08 Aug 2023 11:08:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZv-0005mu-00 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee59a454-35db-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:08:41 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 111564EE0740; Tue, 8 Aug 2023 13:08:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee59a454-35db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [XEN PATCH v2 1/5] x86: address MISRA C:2012 Rule 5.3 Date: Tue, 8 Aug 2023 13:08:03 +0200 Message-Id: <3a9db416c6f8b2d5a549d49ff02238eb408cc905.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Address some occurrences of shadowing between the global variable 'e820' in 'xen/arch/x86/e820.c' and function parameter names (such as that of 'e820_add_range'). The parameter is removed in those functions whose call chain ultimately supplies the global variable as a parameter, which is already visible from their definitions in 'e820.c'. Signed-off-by: Nicola Vetrini --- Changes in v2: - Reworked the patch to remove the parameter e820 where possible and consequential changes to the involved functions. --- xen/arch/x86/e820.c | 36 ++++++++++----------- xen/arch/x86/guest/hyperv/hyperv.c | 4 +-- xen/arch/x86/guest/hypervisor.c | 2 +- xen/arch/x86/guest/xen/xen.c | 4 +-- xen/arch/x86/include/asm/e820.h | 3 +- xen/arch/x86/include/asm/guest/hypervisor.h | 2 +- xen/arch/x86/include/asm/pv/shim.h | 2 +- xen/arch/x86/pv/shim.c | 10 +++--- xen/arch/x86/setup.c | 8 ++--- xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- 11 files changed, 37 insertions(+), 38 deletions(-) diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c index 4911e64b8c..875572b23e 100644 --- a/xen/arch/x86/e820.c +++ b/xen/arch/x86/e820.c @@ -543,27 +543,27 @@ static void __init machine_specific_memory_setup(struct e820map *raw) clip_to_limit(top_of_ram, "MTRRs do not cover all of memory."); } -/* This function relies on the passed in e820->map[] being sorted. */ -int __init e820_add_range( - struct e820map *e820, uint64_t s, uint64_t e, uint32_t type) +/* This function relies on the global e820->map[] being sorted. */ +int __init e820_add_range(uint64_t s, uint64_t e, uint32_t type) { unsigned int i; + struct e820entry *ei = e820.map; - for ( i = 0; i < e820->nr_map; ++i ) + for ( i = 0; i < e820.nr_map; ++i ) { - uint64_t rs = e820->map[i].addr; - uint64_t re = rs + e820->map[i].size; + uint64_t rs = ei[i].addr; + uint64_t re = rs + ei[i].size; - if ( rs == e && e820->map[i].type == type ) + if ( rs == e && ei[i].type == type ) { - e820->map[i].addr = s; + ei[i].addr = s; return 1; } - if ( re == s && e820->map[i].type == type && - (i + 1 == e820->nr_map || e820->map[i + 1].addr >= e) ) + if ( re == s && ei[i].type == type && + (i + 1 == e820.nr_map || ei[i + 1].addr >= e) ) { - e820->map[i].size += e - s; + ei[i].size += e - s; return 1; } @@ -574,20 +574,20 @@ int __init e820_add_range( return 0; } - if ( e820->nr_map >= ARRAY_SIZE(e820->map) ) + if ( e820.nr_map >= ARRAY_SIZE(e820.map) ) { printk(XENLOG_WARNING "E820: overflow while adding region" " %"PRIx64"-%"PRIx64"\n", s, e); return 0; } - memmove(e820->map + i + 1, e820->map + i, - (e820->nr_map - i) * sizeof(*e820->map)); + memmove(ei + i + 1, ei + i, + (e820.nr_map - i) * sizeof(*e820.map)); - e820->nr_map++; - e820->map[i].addr = s; - e820->map[i].size = e - s; - e820->map[i].type = type; + e820.nr_map++; + ei[i].addr = s; + ei[i].size = e - s; + ei[i].type = type; return 1; } diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c index aacc7a6167..912099564e 100644 --- a/xen/arch/x86/guest/hyperv/hyperv.c +++ b/xen/arch/x86/guest/hyperv/hyperv.c @@ -187,11 +187,11 @@ static int cf_check ap_setup(void) return setup_vp_assist(); } -static void __init cf_check e820_fixup(struct e820map *e820) +static void __init cf_check e820_fixup(void) { uint64_t s = HV_HCALL_MFN << PAGE_SHIFT; - if ( !e820_add_range(e820, s, s + PAGE_SIZE, E820_RESERVED) ) + if ( !e820_add_range(s, s + PAGE_SIZE, E820_RESERVED) ) panic("Unable to reserve Hyper-V hypercall range\n"); } diff --git a/xen/arch/x86/guest/hypervisor.c b/xen/arch/x86/guest/hypervisor.c index b8549a131a..bf5be97bc3 100644 --- a/xen/arch/x86/guest/hypervisor.c +++ b/xen/arch/x86/guest/hypervisor.c @@ -63,7 +63,7 @@ void hypervisor_resume(void) void __init hypervisor_e820_fixup(struct e820map *e820) { if ( ops.e820_fixup ) - ops.e820_fixup(e820); + ops.e820_fixup(); } int hypervisor_flush_tlb(const cpumask_t *mask, const void *va, diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index f93dfc89f7..139489c666 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -306,10 +306,10 @@ static void cf_check resume(void) pv_console_init(); } -static void __init cf_check e820_fixup(struct e820map *e820) +static void __init cf_check e820_fixup() { if ( pv_shim ) - pv_shim_fixup_e820(e820); + pv_shim_fixup_e820(); } static int cf_check flush_tlb( diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e820.h index 213d5b5dd2..af90085d65 100644 --- a/xen/arch/x86/include/asm/e820.h +++ b/xen/arch/x86/include/asm/e820.h @@ -29,8 +29,7 @@ extern int reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e); extern int e820_change_range_type( struct e820map *e820, uint64_t s, uint64_t e, uint32_t orig_type, uint32_t new_type); -extern int e820_add_range( - struct e820map *, uint64_t s, uint64_t e, uint32_t type); +extern int e820_add_range(uint64_t s, uint64_t e, uint32_t type); extern unsigned long init_e820(const char *str, struct e820map *raw); extern void print_e820_memory_map(const struct e820entry *map, unsigned int entries); diff --git a/xen/arch/x86/include/asm/guest/hypervisor.h b/xen/arch/x86/include/asm/guest/hypervisor.h index 4cffea3866..9c8a893da3 100644 --- a/xen/arch/x86/include/asm/guest/hypervisor.h +++ b/xen/arch/x86/include/asm/guest/hypervisor.h @@ -22,7 +22,7 @@ struct hypervisor_ops { /* Resume from suspension */ void (*resume)(void); /* Fix up e820 map */ - void (*e820_fixup)(struct e820map *e820); + void (*e820_fixup)(void); /* L0 assisted TLB flush */ int (*flush_tlb)(const cpumask_t *mask, const void *va, unsigned int flags); }; diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h index 5625b90b72..7bae9ae372 100644 --- a/xen/arch/x86/include/asm/pv/shim.h +++ b/xen/arch/x86/include/asm/pv/shim.h @@ -85,7 +85,7 @@ static inline uint64_t pv_shim_mem(uint64_t avail) ASSERT_UNREACHABLE(); return 0; } -static inline void pv_shim_fixup_e820(struct e820map *e820) +static inline void pv_shim_fixup_e820(void) { ASSERT_UNREACHABLE(); } diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index 4044087119..a8883a1ebd 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -98,17 +98,17 @@ uint64_t pv_shim_mem(uint64_t avail) return shim_nrpages; } -static void __init mark_pfn_as_ram(struct e820map *e820, uint64_t pfn) +static void __init mark_pfn_as_ram(uint64_t pfn) { - if ( !e820_add_range(e820, pfn << PAGE_SHIFT, + if ( !e820_add_range(pfn << PAGE_SHIFT, (pfn << PAGE_SHIFT) + PAGE_SIZE, E820_RAM) && - !e820_change_range_type(e820, pfn << PAGE_SHIFT, + !e820_change_range_type(&e820, pfn << PAGE_SHIFT, (pfn << PAGE_SHIFT) + PAGE_SIZE, E820_RESERVED, E820_RAM) ) panic("Unable to add/change memory type of pfn %#lx to RAM\n", pfn); } -void __init pv_shim_fixup_e820(struct e820map *e820) +void __init pv_shim_fixup_e820(void) { uint64_t pfn = 0; unsigned int i = 0; @@ -120,7 +120,7 @@ void __init pv_shim_fixup_e820(struct e820map *e820) rc = xen_hypercall_hvm_get_param(p, &pfn); \ if ( rc ) \ panic("Unable to get " #p "\n"); \ - mark_pfn_as_ram(e820, pfn); \ + mark_pfn_as_ram(pfn); \ ASSERT(i < ARRAY_SIZE(reserved_pages)); \ reserved_pages[i++].mfn = pfn; \ }) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 80ae973d64..03f9a03180 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -686,7 +686,7 @@ static void __init parse_video_info(void) #endif } -static void __init kexec_reserve_area(struct e820map *e820) +static void __init kexec_reserve_area(void) { #ifdef CONFIG_KEXEC unsigned long kdump_start = kexec_crash_area.start; @@ -700,7 +700,7 @@ static void __init kexec_reserve_area(struct e820map *e820) is_reserved = true; - if ( !reserve_e820_ram(e820, kdump_start, kdump_start + kdump_size) ) + if ( !reserve_e820_ram(&boot_e820, kdump_start, kdump_start + kdump_size) ) { printk("Kdump: DISABLED (failed to reserve %luMB (%lukB) at %#lx)" "\n", kdump_size >> 20, kdump_size >> 10, kdump_start); @@ -1308,7 +1308,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( e820.map[i].type == E820_RAM ) nr_pages += e820.map[i].size >> PAGE_SHIFT; set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); - kexec_reserve_area(&boot_e820); + kexec_reserve_area(); initial_images = mod; nr_initial_images = mbi->mods_count; @@ -1495,7 +1495,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); /* Late kexec reservation (dynamic start address). */ - kexec_reserve_area(&boot_e820); + kexec_reserve_area(); setup_max_pdx(raw_max_page); if ( highmem_start ) diff --git a/xen/arch/x86/x86_64/mmconf-fam10h.c b/xen/arch/x86/x86_64/mmconf-fam10h.c index a834ab3149..36b32eb769 100644 --- a/xen/arch/x86/x86_64/mmconf-fam10h.c +++ b/xen/arch/x86/x86_64/mmconf-fam10h.c @@ -135,7 +135,7 @@ static void __init get_fam10h_pci_mmconf_base(void) return; out: - if (e820_add_range(&e820, start, start + SIZE, E820_RESERVED)) + if (e820_add_range(start, start + SIZE, E820_RESERVED)) fam10h_pci_mmconf_base = start; } diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index 3b577c9b39..db993d6df2 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -418,7 +418,7 @@ static int __init parse_ivmd_block(const struct acpi_ivrs_memory *ivmd_block) if ( type == RAM_TYPE_UNKNOWN ) { - if ( e820_add_range(&e820, addr, addr + PAGE_SIZE, + if ( e820_add_range(addr, addr + PAGE_SIZE, E820_RESERVED) ) continue; AMD_IOMMU_ERROR("IVMD: page at %lx couldn't be reserved\n", -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579641.907730 (Exim 4.92) (envelope-from ) id 1qTKZx-0006UB-Fz; Tue, 08 Aug 2023 11:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579641.907730; Tue, 08 Aug 2023 11:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZx-0006Ru-6Z; Tue, 08 Aug 2023 11:08:45 +0000 Received: by outflank-mailman (input) for mailman id 579641; Tue, 08 Aug 2023 11:08:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZv-00068O-To for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:43 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id efae8582-35db-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 13:08:43 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 50E094EE0744; Tue, 8 Aug 2023 13:08:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efae8582-35db-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 4/5] x86/xstate: address MISRA C:2012 Rule 5.3 Date: Tue, 8 Aug 2023 13:08:06 +0200 Message-Id: <927d771a3c38b8a3c47913aea21cf8890fd4e6ef.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename the local variables s/xsave/xstate/ to avoid clashing with function 'xsave' defined in 'xen/arch/x86/include/asm/xstate.h'. No functional changes. Signed-off-by: Nicola Vetrini --- Changes in v2: - s/xsave_area/xstate/, since that is the newest common name, also used in other parts of the modified file. --- xen/arch/x86/xstate.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/xstate.c b/xen/arch/x86/xstate.c index 770747d88f..f442610fc5 100644 --- a/xen/arch/x86/xstate.c +++ b/xen/arch/x86/xstate.c @@ -174,10 +174,10 @@ static void setup_xstate_comp(uint16_t *comp_offsets, */ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) { - const struct xsave_struct *xsave = v->arch.xsave_area; + const struct xsave_struct *xstate = v->arch.xsave_area; const void *src; uint16_t comp_offsets[sizeof(xfeature_mask)*8]; - u64 xstate_bv = xsave->xsave_hdr.xstate_bv; + u64 xstate_bv = xstate->xsave_hdr.xstate_bv; u64 valid; /* Check there is state to serialise (i.e. at least an XSAVE_HDR) */ @@ -185,19 +185,19 @@ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) /* Check there is the correct room to decompress into. */ BUG_ON(size != xstate_ctxt_size(v->arch.xcr0_accum)); - if ( !(xsave->xsave_hdr.xcomp_bv & XSTATE_COMPACTION_ENABLED) ) + if ( !(xstate->xsave_hdr.xcomp_bv & XSTATE_COMPACTION_ENABLED) ) { - memcpy(dest, xsave, size); + memcpy(dest, xstate, size); return; } - ASSERT(xsave_area_compressed(xsave)); - setup_xstate_comp(comp_offsets, xsave->xsave_hdr.xcomp_bv); + ASSERT(xsave_area_compressed(xstate)); + setup_xstate_comp(comp_offsets, xstate->xsave_hdr.xcomp_bv); /* * Copy legacy XSAVE area and XSAVE hdr area. */ - memcpy(dest, xsave, XSTATE_AREA_MIN_SIZE); + memcpy(dest, xstate, XSTATE_AREA_MIN_SIZE); memset(dest + XSTATE_AREA_MIN_SIZE, 0, size - XSTATE_AREA_MIN_SIZE); ((struct xsave_struct *)dest)->xsave_hdr.xcomp_bv = 0; @@ -206,7 +206,7 @@ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) * Copy each region from the possibly compacted offset to the * non-compacted offset. */ - src = xsave; + src = xstate; valid = xstate_bv & ~XSTATE_FP_SSE; while ( valid ) { @@ -239,7 +239,7 @@ void expand_xsave_states(const struct vcpu *v, void *dest, unsigned int size) */ void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size) { - struct xsave_struct *xsave = v->arch.xsave_area; + struct xsave_struct *xstate = v->arch.xsave_area; void *dest; uint16_t comp_offsets[sizeof(xfeature_mask)*8]; u64 xstate_bv, valid; @@ -252,7 +252,7 @@ void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size) if ( !(v->arch.xcr0_accum & XSTATE_XSAVES_ONLY) ) { - memcpy(xsave, src, size); + memcpy(xstate, src, size); return; } @@ -260,19 +260,19 @@ void compress_xsave_states(struct vcpu *v, const void *src, unsigned int size) * Copy legacy XSAVE area, to avoid complications with CPUID * leaves 0 and 1 in the loop below. */ - memcpy(xsave, src, FXSAVE_SIZE); + memcpy(xstate, src, FXSAVE_SIZE); /* Set XSTATE_BV and XCOMP_BV. */ - xsave->xsave_hdr.xstate_bv = xstate_bv; - xsave->xsave_hdr.xcomp_bv = v->arch.xcr0_accum | XSTATE_COMPACTION_ENABLED; + xstate->xsave_hdr.xstate_bv = xstate_bv; + xstate->xsave_hdr.xcomp_bv = v->arch.xcr0_accum | XSTATE_COMPACTION_ENABLED; - setup_xstate_comp(comp_offsets, xsave->xsave_hdr.xcomp_bv); + setup_xstate_comp(comp_offsets, xstate->xsave_hdr.xcomp_bv); /* * Copy each region from the non-compacted offset to the * possibly compacted offset. */ - dest = xsave; + dest = xstate; valid = xstate_bv & ~XSTATE_FP_SSE; while ( valid ) { -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579642.907736 (Exim 4.92) (envelope-from ) id 1qTKZx-0006ZH-R0; Tue, 08 Aug 2023 11:08:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579642.907736; Tue, 08 Aug 2023 11:08:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZx-0006YR-Iz; Tue, 08 Aug 2023 11:08:45 +0000 Received: by outflank-mailman (input) for mailman id 579642; Tue, 08 Aug 2023 11:08:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZw-0005mu-09 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eed0fce2-35db-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:08:41 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id C23304EE0741; Tue, 8 Aug 2023 13:08:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eed0fce2-35db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH v2 2/5] xen/delay: address MISRA C:2012 Rule 5.3. Date: Tue, 8 Aug 2023 13:08:04 +0200 Message-Id: <27631ba28fc6f47095fe0db3f8ee2cd87de616ed.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable 'msec' declared in the macro shadows the local variable in 'ehci_dbgp_bios_handoff', but to prevent any future clashes with other functions the macro is converted to a static inline function. No functional change. Signed-off-by: Nicola Vetrini --- Changes in v2: - Switched to a static inline function, as suggested by Julien --- xen/include/xen/delay.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h index 9d70ef035f..6ecee851f6 100644 --- a/xen/include/xen/delay.h +++ b/xen/include/xen/delay.h @@ -4,7 +4,12 @@ /* Copyright (C) 1993 Linus Torvalds */ #include -#define mdelay(n) (\ - {unsigned long msec=(n); while (msec--) udelay(1000);}) + +static inline void mdelay(unsigned long n) +{ + unsigned long msec=n; + while ( msec-- ) + udelay(1000); +} #endif /* defined(_LINUX_DELAY_H) */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579643.907744 (Exim 4.92) (envelope-from ) id 1qTKZy-0006lY-Bx; Tue, 08 Aug 2023 11:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579643.907744; Tue, 08 Aug 2023 11:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZy-0006jn-2W; Tue, 08 Aug 2023 11:08:46 +0000 Received: by outflank-mailman (input) for mailman id 579643; Tue, 08 Aug 2023 11:08:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZw-00068O-LO for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:44 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f022ab89-35db-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 13:08:44 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 1193B4EE0743; Tue, 8 Aug 2023 13:08:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f022ab89-35db-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' Date: Tue, 8 Aug 2023 13:08:07 +0200 Message-Id: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised to address the following concerns: - needless underscore prefixes for parameter names; - the variable 'i' in function 'mce_action' that is shadowed by the local variable in the macro. Therefore, the refactoring aims to resolve present shadowing issues, which violate MISRA C:2012 Rule 5.3, and lessen the probability of future ones with some renames. No functional change. Signed-off-by: Nicola Vetrini --- Changes in v2: - Added missing parentheses. - Clarified commit message. --- xen/include/public/arch-x86/xen-mca.h | 38 +++++++++++++-------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xen/include/public/arch-x86/xen-mca.h b/xen/include/public/arch-x86/xen-mca.h index b897536ec5..bb1b12f14f 100644 --- a/xen/include/public/arch-x86/xen-mca.h +++ b/xen/include/public/arch-x86/xen-mca.h @@ -280,39 +280,39 @@ DEFINE_XEN_GUEST_HANDLE(xen_mc_logical_cpu_t); /* Prototype: * uint32_t x86_mcinfo_nentries(struct mc_info *mi); */ -#define x86_mcinfo_nentries(_mi) \ - (_mi)->mi_nentries +#define x86_mcinfo_nentries(mi) \ + (mi)->mi_nentries /* Prototype: * struct mcinfo_common *x86_mcinfo_first(struct mc_info *mi); */ -#define x86_mcinfo_first(_mi) \ - ((struct mcinfo_common *)(_mi)->mi_data) +#define x86_mcinfo_first(mi) \ + ((struct mcinfo_common *)(mi)->mi_data) /* Prototype: * struct mcinfo_common *x86_mcinfo_next(struct mcinfo_common *mic); */ -#define x86_mcinfo_next(_mic) \ - ((struct mcinfo_common *)((uint8_t *)(_mic) + (_mic)->size)) +#define x86_mcinfo_next(mic) \ + ((struct mcinfo_common *)((uint8_t *)(mic) + (mic)->size)) /* Prototype: - * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t type); + * void x86_mcinfo_lookup(void *ret, struct mc_info *mi, uint16_t mc_type); */ -#define x86_mcinfo_lookup(_ret, _mi, _type) \ +#define x86_mcinfo_lookup(ret, mi, mc_type) \ do { \ - uint32_t found, i; \ - struct mcinfo_common *_mic; \ + uint32_t found_, i_; \ + struct mcinfo_common *mic_; \ \ - found = 0; \ - (_ret) = NULL; \ - if (_mi == NULL) break; \ - _mic = x86_mcinfo_first(_mi); \ - for (i = 0; i < x86_mcinfo_nentries(_mi); i++) { \ - if (_mic->type == (_type)) { \ - found = 1; \ + found_ = 0; \ + (ret) = NULL; \ + if ((mi) == NULL) break; \ + mic_ = x86_mcinfo_first(mi); \ + for (i_ = 0; i_ < x86_mcinfo_nentries(mi); i_++) { \ + if (mic_->type == (mc_type)) { \ + found_ = 1; \ break; \ } \ - _mic = x86_mcinfo_next(_mic); \ + mic_ = x86_mcinfo_next(mic_); \ } \ - (_ret) = found ? _mic : NULL; \ + (ret) = found_ ? mic_ : NULL; \ } while (0) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:08:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579644.907755 (Exim 4.92) (envelope-from ) id 1qTKZz-00074z-C6; Tue, 08 Aug 2023 11:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579644.907755; Tue, 08 Aug 2023 11:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZy-00072a-SO; Tue, 08 Aug 2023 11:08:46 +0000 Received: by outflank-mailman (input) for mailman id 579644; Tue, 08 Aug 2023 11:08:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKZx-0005mu-0D for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:08:45 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef41c923-35db-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:08:42 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 91D064EE0742; Tue, 8 Aug 2023 13:08:41 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef41c923-35db-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 3/5] x86/include: address MISRA C:2012 Rule 5.3. Date: Tue, 8 Aug 2023 13:08:05 +0200 Message-Id: <4b41f84c6cbce3466917d1091029cacb3c327d7b.1691492441.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Variable 'mpc_default_type' in 'xen/arch/x86/include/asm/mpspec.h' has no uses and causes shadowing with function parameter names in 'mpparse.c'. Therefore, it is removed. No functional changes. Signed-off-by: Nicola Vetrini --- Changes in v2: - Removed the variable. --- xen/arch/x86/include/asm/mpspec.h | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/include/asm/mpspec.h b/xen/arch/x86/include/asm/mpspec.h index 1246eece0b..45e474dfd1 100644 --- a/xen/arch/x86/include/asm/mpspec.h +++ b/xen/arch/x86/include/asm/mpspec.h @@ -15,7 +15,6 @@ extern void get_smp_config (void); extern unsigned char apic_version [MAX_APICS]; extern int mp_irq_entries; extern struct mpc_config_intsrc mp_irqs [MAX_IRQ_SOURCES]; -extern int mpc_default_type; extern unsigned long mp_lapic_addr; extern bool pic_mode; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:14:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:14:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579673.907775 (Exim 4.92) (envelope-from ) id 1qTKfa-0002Fz-RD; Tue, 08 Aug 2023 11:14:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579673.907775; Tue, 08 Aug 2023 11:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKfa-0002Fs-NL; Tue, 08 Aug 2023 11:14:34 +0000 Received: by outflank-mailman (input) for mailman id 579673; Tue, 08 Aug 2023 11:14:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKfY-0002Fg-KR; Tue, 08 Aug 2023 11:14:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKfY-0001bB-Eo; Tue, 08 Aug 2023 11:14:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKfY-00008c-1c; Tue, 08 Aug 2023 11:14:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTKfY-0002nH-1F; Tue, 08 Aug 2023 11:14:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4G5K2W1uL+hI/kLBZpAo4TDhKPvOkPE9bNf8chu88Z8=; b=5SUA3rhdt4osjYNOkyp6QtKD1l 697fCDcTGYTiK1tRgAODn+iYTVMdkbpa3A3aaNwsVWlXuKL/WkMWKrZlnpyRr1cOIuhp+IPW+VzvK RF62laDj2TU4CH5T7cgh6IrCj0bY5jfmwRYqqOSw3zTVryIjLhuOmhQjFuvO/oHEifS0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182229: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bd3ddaf6ee7fa312bd077305819105f84a34008d X-Osstest-Versions-That: xen=d3be806dae9c122fe94702cd9fa2e358a60828cd From: osstest service owner Date: Tue, 08 Aug 2023 11:14:32 +0000 flight 182229 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182229/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bd3ddaf6ee7fa312bd077305819105f84a34008d baseline version: xen d3be806dae9c122fe94702cd9fa2e358a60828cd Last test of basis 182223 2023-08-07 23:02:06 Z 0 days Testing same since 182229 2023-08-08 08:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Federico Serafini Jan Beulich Luca Fancellu Shawn Anastasio jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d3be806dae..bd3ddaf6ee bd3ddaf6ee7fa312bd077305819105f84a34008d -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 08 11:23:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 11:23:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579696.907785 (Exim 4.92) (envelope-from ) id 1qTKns-0003nt-Jy; Tue, 08 Aug 2023 11:23:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579696.907785; Tue, 08 Aug 2023 11:23:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKns-0003nm-H6; Tue, 08 Aug 2023 11:23:08 +0000 Received: by outflank-mailman (input) for mailman id 579696; Tue, 08 Aug 2023 11:23:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTKnq-0003nd-I0 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 11:23:06 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef9221d1-35dd-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 13:23:03 +0200 (CEST) Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Aug 2023 07:22:59 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY1PR03MB7261.namprd03.prod.outlook.com (2603:10b6:a03:526::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 11:22:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 11:22:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef9221d1-35dd-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691493783; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=r/iiAB3KxCPjuU9BKf58ZNB3v7HDrTyB/JucDDyIpZ8=; b=ZbytNufSk80t6+FpjKGxfT4VC6e5uSmbKBeqF0rCVwHAfb9Puxu/+RbX ktjMOiwxgeUBb+crLHYj9Y/EkmO9TX2vUwx5PTsUG+CkDbvv2NsBAgbdd SqOgJ4OqS8+RfGCNZ866KkYs/XMxkqzfKPkej3FLBTV01NmBedUHcwtVN Q=; X-IronPort-RemoteIP: 104.47.70.109 X-IronPort-MID: 119271607 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:XtZTz6rM9b524wHllfkfLOiaT+leBmJOZRIvgKrLsJaIsI4StFCzt garIBnUaPnYYzbyfo90a43k9xkBvJHQzNJhSQtv+yFmQSwV9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOzylNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXABwMaBu4of2I/IiEb7dMnZsBdsDXIKpK7xmMzRmBZRonabbqZvySoPV+g3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+CraYKEEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr68w3wTNnjN75Bs+Z1GFkN2Fm2GESssEc 24p6xEPsbgN6xn+JjX6d1jiyJKehTYeUtxcCfwn6ymCz6PV50CSAW1sZjxLZcEitcQ2bSc3z VLPlNTsbRR0q6GcQ3+Z8raSrBuxNDITIGtEYjULJSMa5/HzrYd1iQjAJv5hDaq0g9vdCTz2h TeQo0AWhboJitUQ/76m5l2BiDWpzrDMRxQw7x/aXUqk6B14f4+vY4G06Vnd4u1EJYzfRV6E1 FAIg9Ob7fwOJZiVmTaRXf4WG7W0+/eCNiaaillqd7Eq9y6s4GKkZYBd+ndhYkxtO9wHUTDsa U7X/whW4fd7LHasKKN6fY+1I8Ar1rT7U8ToUOjOadhDaYQ3cxWIlByCfmaV1mHp1UIqzqc2P M7Ddd72VC5LT6N60DCxWuERl6cxwTwzzn/SQpa9yAm71b2ZZzieTrJt3EayU93VJZis+G39m +uz/ePTo/mDeIUSuhXqzLM= IronPort-HdrOrdr: A9a23:bC9r26A3BYNRmo/lHeixsseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ4OxoS5PwJk80kqQFnLX5XI3SJjUO3VHFEGgM1/qA/9SNIVyaygcZ79 YaT0EcMqyPMbEZt6bHCWCDer5PoeVvsprY/ds2p00dMj2CAJsQizuRZDzrdHGeCDM2Z6bQQ/ Gnl7Z6TnebCDwqhoPRPAh2Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzSIwxsEVDtL4LE6tU zIiRbw6KmPu+yyjka07R6e071m3P/ajvdTDs2FjcYYbh3qlwaTfYxkH5GSoTwvp+mryVAy1P 3BuQ0pMchf427YOku1vRzu8Q/91ytG0Q6u9XaoxV/Y5eDpTjMzDMRMwapfbxvi8kIl+PVxyr hC0W61v4deSUqoplW22/H4EzVR0makq3srluAey1RZTIslcbdU6agS5llcHpssFD/zrKonDO 5tJsfB4+s+SyLQU1np+k1UhPC8VHU6GRmLBmAEp8yuyjBT2Et0ykMJrfZv6UsoxdYYcd1p9u 7EOqNnmPVlVckNd59wA+8HXI+eFnHNaQikChPTHX3XUIU8f17doZ/+57s4oMuwfoYT8Zc0kJ PdFHtFqG8JfV70A8Hm5uwLzvn0ehT+Yd3R8LAa23Ag0YeMAIYDcBfzBmzGqvHQ4Mn2WabgKr GO0JE/OY6WEYKhI/cO4+TEYeggFZAvarxlhj8FYSP/nivqEPydigWJSoebGJPdVRAZZ0jYPl wvGBDOGeQo1DHfZpa/ummfZ0/Q X-Talos-CUID: 9a23:9Si14mxTE9fZU5B1rG6kBgU4G8YuSVvC8kvqHGrmKX02auecdUO5rfY= X-Talos-MUID: =?us-ascii?q?9a23=3AJCXBDw0DQFESl54fL1QlzGoiKjUj0a6QOWQxgLo?= =?us-ascii?q?8qtDfbQ5NKgy8kCSIXdpy?= X-IronPort-AV: E=Sophos;i="6.01,156,1684814400"; d="scan'208";a="119271607" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VjLNGFstjlmeInOCMJDTuXpVW0x+wP1zgJ77E501Gv3AEa7bx6Xlyfq0ovfoV2M+S2hP7kVGXhhSQ0ee1jXljntw7sg+yItzReNU0UX4iGMcVSpeL8a2fvsYqvrSh6mU0YrUoKUarLDXxcoZDfTd8AQB4NykW4p/lJ/9HDDF8wuxbHI+n1BQHFO+z1LTdqiXtCCfl+Nr1su7nKwpDT2SK9HmbNyd4Uggz32X82g8r/iZk0KjwCQpIZdKrifDqmqAzNo5viyVCJ1TMarfIceCreqcs75qITprcME8ybXaUWPew/xj3vL2qDMN/hjAmJPdei4BdQ4CM8YbxJickzPZ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Ri+ATDYnV0KthEWTlZPa/ReZoN6eTbSdoj9jjZdprA=; b=gdFupiA3O3OYZCXmEgX49+oe6wIlPb9BUjn/DjfSn3UWGat+2e2MCHGC7PNdaZIXOEhbRDbbuRUJfn0jp1a+Dz7G5nn3i542s3iP4si8WWQUvBECh087pJvq+9+MWfsFJLImVlRK+GozfAbT01kFmxRW/1XqkbUM6d7cx+79msPfLVy3NUmYHkl6a+wyOUmGdZ1CqXZ34X4hBFP5q86iFolSWXh8QnjpYNV4AvbmEO07IHPNRT0xXEHSLgpUCww0/mvN/lEyIRcTfdcjWEHM9aLii+2WRcpRv7Urrdde5p42YEVirmaJIcjo7MSre6g9Kq3LKnhRjqtUanaM5Ym/xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Ri+ATDYnV0KthEWTlZPa/ReZoN6eTbSdoj9jjZdprA=; b=Tq21p9sIAXwK46TmUNcurvd75LZCcxJhlDDQKsS4D6qrFQO9tqf7fumx/CYqwG925/Eqss+ZKfsDr/GyP3+W0Qey3oR1UXcskE0ADEWJWPz+80SHTOq5cr56k8dtSFHw/Wy6Or6XNlaO4YLk8e73uDfqbEYagLHroS8lwQH4720= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <72435ef3-821b-9feb-16f5-d3304776b44b@citrix.com> Date: Tue, 8 Aug 2023 12:22:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator Content-Language: en-GB To: Jason Andryuk , Jan Beulich Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Daniel Smith , Christopher Clark , Xen-devel References: <20230803203650.1474936-1-andrew.cooper3@citrix.com> <722dfba8-a768-55c1-29bb-2d8525282b4b@citrix.com> <464d71e4-9047-0461-afdc-8df8b8f569fb@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0470.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY1PR03MB7261:EE_ X-MS-Office365-Filtering-Correlation-Id: b5e2169b-498b-4384-6a14-08db9801d099 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q8he3byNi8UuB+ZwmzGcIYkLUxtV0/i9N7+MZRWjbAxErcOTxmoGzTjSDXy7AIrEbl5ch76/JsHOl5N4ZmidQ0b7pMjPw7VxgzUvYnpdN6AW33S5h9670HxjJIDbAcTuVq4iqAVObTygI+AT/poaQLwBWa5iujhk0cSEqjScsyDJymSPDsovbc51MWPBQUY6iWcPg1ncoJaYkfPhoXgls3HZcE9XbaiZ3SeTTX6jZ378K5Y8bLJA/y2f8gCpeQqglZrhUW73XGN4PmkkTTmWtKV/NPCgDtc8RIlmPYSZWp/0VmldfkXw+7nu2J81uFmowMHLulP4ey6w4BMGLMHGbyANSmhGv5H6uOUiUjOlrnOih/QlYQ3RC8xfjkvmUULi75fSnIXqXrXqA2Bm5Fh0VhpOojXwmWglYWuztyub9f6XWEIuDvXrmDiPmqog0zg9kfnWU4APKv4dY0TeKzCG5ylHsTkfm6SrG1pbunw0dJ9Xb15PBcxggSwB8DHlR75hlgPa4aAZibA/zQ9oZJmzZUfEl8Lk7XLlIjnKVzZYezOlCxzm2M3gOh5TPlVvjTsMHGV0CzrqdIrvakR6DeFGJVIOOuZCIDwF9+8zYc6+iDHzCF2DB3b/Wpk1zms01smgFocfG1dnUpH9zNHpVn/a/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(1800799003)(451199021)(186006)(31686004)(316002)(83380400001)(2616005)(2906002)(82960400001)(36756003)(53546011)(8936002)(26005)(8676002)(38100700002)(5660300002)(6666004)(6486002)(7416002)(66556008)(41300700001)(66476007)(4326008)(66946007)(6506007)(478600001)(54906003)(110136005)(86362001)(31696002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWNYbFVRWnI3TU9VMDBxczZJdG9pcStwRXJCVGVRYXVyajVwNEVDcWZpUEFj?= =?utf-8?B?eHJmQ3NobmRJYjh1dm9GOGNPQVBhSjljNDFiVGxCUm9oV3MzOWFXdDR3VUhW?= =?utf-8?B?aVREYk5nT09tT1gvVVI3MW9Wbytla1hFaUpwaElIRzNDM3hOWm9zSk9HbDh4?= =?utf-8?B?azlvOUtqcjlZOVVCZGIxYUpZeVJ4ak1NU3B3cW40dmZZdVhkUVNTdzJOenZH?= =?utf-8?B?NHNmZlVPK2JmajkxaDZDUWtvYkdTSHlNaTlhdk0wYW8vT2JUZUp2VHpmTzIz?= =?utf-8?B?L0F3WVBHUDN6eUh2TEQxcnJCQ0VUK0FXWFBPTEhoSitiamlrS2hCVkxTUHE3?= =?utf-8?B?S0x3WHBnSW12OFJiL1NHbmdndSswRjJVOE1ndWhxcEszZWR4YzY4bkdESkpW?= =?utf-8?B?MWRNUHIrRGhIWlJXUm53Mzhabk5NazdDY1BZWlRkOUVPZDNrLzUvTFFmdkdj?= =?utf-8?B?dFVkMzAwWWI2NnpqTUhwbnF0T0t1dG9VT1RZOHIybU5kQW1IS1BHWkNQamVT?= =?utf-8?B?bW1HMm5pbzVIYXVISDgyb3oxZE91V2toZVcxZVJKQWJtdGFjUjNJRUF2cjNE?= =?utf-8?B?L1pwWnBWZWVCemhZNVdWdUdpY1dqVWhjL0NpK3hPZytoSHE4amQzL0RyWWx5?= =?utf-8?B?SUNJQmNXQW9JaDMvMmx2OG1NeEVaODQxZnZJQTQ4Qk03cWVabFV3MitBZG5a?= =?utf-8?B?ZUlMSHBBY0lwY2VCZFFkUTNrTHN4SzdiU21GWkpudkg5NDRnN3gvUG5uMzg2?= =?utf-8?B?RzFMdWNFZTlsR0xITERlaHBFcXNxalVZcU1hTFk4MHh1T1hyaS9lbXRaVGtE?= =?utf-8?B?eVN4N283N25rUm9VR0o2RmF0Y0RLdnRBTGQrdDZZS09uRDJWNk9XYWpWVU9R?= =?utf-8?B?MTg3NmJPeEVnU0VoMFFKVXBLMHp0bEk1TzZOcTViNzFINVF4bHpBajc1M1g1?= =?utf-8?B?OVVvVmVodUJnWTFkWXcxOU5qVGkrS2dZWGtlWk1oWldBSURxeWRDU2hTbzV1?= =?utf-8?B?S2NkTTNzWlRQdjB2RnFYTllDVDk0aEtZanhxUjQ0NEZKWVphT3c4bWxxRE9U?= =?utf-8?B?MFI0aEFmcDRDRjBFWkFpaDhGSERqZGJndE96emdOb1RlL0haZGxEd2lhUGVz?= =?utf-8?B?aDRHOUZDbitwU3RSTEc1ekFlek90eHIxRXBDbG5sNUp4anhmaVpRS2htQVJz?= =?utf-8?B?eTAwSE5YazFoMCtVVldXK2crR1NzWU9VYTJaRGRIYmdYbmloa0ZQZktBcTNv?= =?utf-8?B?akdkL01Ba0R0T2pZRkp1SHJuWG5PakJpT1Z3cUMyZ1haemYxVThHNlljcWlM?= =?utf-8?B?OUJaRENQcnA5UVdnTFpvaVlaMlNXYmlyTGw3Qlh4MU1XWFRJL1M1bnZEZ1px?= =?utf-8?B?T3hsYkplNVY1c3NkaUNtOG5aeTVPdm5Jc0NsbThCYWlMeFpPRjIzQ201WWFK?= =?utf-8?B?UlNuSGRsNmMyWXkwNFBXcnNRc1ZrRWs2NlZRTUx1T25OMGdNSTdKVW14Umdx?= =?utf-8?B?ZEFId1c1MS9yS0pERVNyMXdrem0yYTRQN2tYK0hKclczUnpnNmtJRUZIUDVz?= =?utf-8?B?amQ3S0c4NXp3UkZhMC9HNU5qK1J2ckFxYlZxbUFpNEp5cFZNcW9RWnpjTVdn?= =?utf-8?B?bVNTd2lsYjlWcnlVV2REOExZaTMrRFdEdHc4M3g4SThKejloeE9XUi9XNlox?= =?utf-8?B?WGlPWlV1SHpLZFVDZ0ExNHB4T3BZVy8wRzBiZXZCZjFGaUZVNE1HL1lYN01Z?= =?utf-8?B?aFBiRUNsWFVmRzNUdGRxNVBxZEQ4aTM2MEJTdk5KQWc0cWQwQzI3L2tBajhB?= =?utf-8?B?VGNyQlZNT1psa05DcVZHQXNSaFEvMGYyd09yRlZDTlNHODU3TElUUTNVdW10?= =?utf-8?B?dExoTkJCaDFWVFVxQ2lyOWZveVJlL2pVOXBnd0FHMjhNNHFCQjVwNG8xTldO?= =?utf-8?B?WEk1b055YncxV0NlaHR2ZmloYkxRVThicjlsRjF6eHVGRXFQRW4rSGVIcjRv?= =?utf-8?B?NnpVVmt0c0dxaHp0MzBhdkFxbVc0ZnpPSDBDdUdIME9qaTV0ZzU5MTdMblFD?= =?utf-8?B?RDVmdHZsWUkzODhkWHh6MHBVTFljdjZoVmpGbkcwUWxkbG5oK1Q3cThjbFdm?= =?utf-8?B?U1E4RVI5cEFjV2NyakgxZTU3am9YYmFZWDVuRVk2enhIcW1Wb0pxMHhXV3Nw?= =?utf-8?B?aHc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?a21lZzFXZUVzNWgwbmdkbUZ1WUM4RjF2U3FtdjJ3R0Y5TDFsYWVqaDY5Z1hz?= =?utf-8?B?cG5wQm5jTnBFVzZXc0hPR0JvVmkyZ1FHQ3gwTTY2NVlRTlV0elRlUmFUdnMy?= =?utf-8?B?RktIZFNHTS9hQktFdHQ2Nm5oZjVETmp5UXZOeC9haXBWVjY0OS8wWFkyeFVo?= =?utf-8?B?L0lUcWt0TVM4Z0c1UVpkNERwcHVxcUxuNzdjZFc1RGg0WVJrSnI4aGxtUkkw?= =?utf-8?B?N0JnRnZvU0RBdy85UEdLZExvSVljRGl4Z1hpL25OcGtyZU44Rk14U1ZkTjA3?= =?utf-8?B?ZEdaMVpPc2U5SXMxcDBSZ0h0YTN6dWdkUVJEOGtWNStMN0NCVVBsZ3F3S1Rr?= =?utf-8?B?RDlkTFIxbWlvN2NOMGJxUU5MMDlmeXdNNjFYZDhkVUFqckQ0NWVtaTlBQmdQ?= =?utf-8?B?Um1YOVVUKy9KQ1AxYmV5TldlUlRRNXZzc2JUUWFYb0MzVVVqVXY0QWorZ0xT?= =?utf-8?B?UTVGVkl3azRZVGlxYjQ3NVJ6YkxyMXA0SkRyYjZ2bGhPU0VUTzZxZnB5OVZ5?= =?utf-8?B?VkhrZWV3cEJtYjNkaEc0UnR2Q0VzMVZ0TVdmYjFrT3pUZy8xTjdQM09UQVVL?= =?utf-8?B?Y1JJbU55WnZnWnE0UWtaN3k3TzRFMHk1OFpVQ2hsWnkxaHh2a0ppcWdLZllO?= =?utf-8?B?NmtRL0lBSGlnYTEvQ0pJSGlLUlk2VjQzQjgyTHdDM211VnZHUEQrUlV3NytM?= =?utf-8?B?Tm9oSkJqdFlSY2llYzNudzQ5b2s2SHFWbzhqL29IM25uWjhBb2VnQXh3cUd0?= =?utf-8?B?MVQrWHVqYzBwV25XSFJFeUp5TkJzTXBTNlJPc2JGbmRwK2tsdWtoMkhLYlZn?= =?utf-8?B?bkFxdGU5MDJBZ0NuY2NhWjdOZCtKZWZXeVFpQ3N4YUVTcE5peThHYm9NVTVv?= =?utf-8?B?Z0ZwMGpFa2RRMUZxcnlGMWhaVFlOcjM3c0dERFFGK1VMcnc1RndKREczNjBn?= =?utf-8?B?Qy9PTS9JL242N3F5dVYwQ1VFOFhtbjZZeW1mTnhpRm44MnNMem9NczE2ejNO?= =?utf-8?B?Y1FEbGJRbTlWdFp5S0xPcHFCR0FrSm9BcUhqZ3NNZXp5OUEyN1lybGxSTUZZ?= =?utf-8?B?dkNGYzFoc29ncVdRWFExcm1TQXhIU0htdlVsRVNpeE5MVUxCVkZ4SDhtM3ZS?= =?utf-8?B?ZFBnY0phVFh6Q00rQ3ZJeUN3L2hWRFlRTGtxWC9PaElvV0JaUkFQNk5kSGk2?= =?utf-8?B?cy9rcFF4RDhJd3dSUDRtSU9wTjk4cFVBLzgwbTBXVFB3MjNxSmRncnhZQ3Iy?= =?utf-8?B?OXd2S1RSMzFRclVDN1JqZ2c4QjJVaVNVc21qZnpjU1ZDRWM0OFA5azVzNnJi?= =?utf-8?Q?cGgOKGMcqFssBziHa1Q04QSXKjAWVe+JdD?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5e2169b-498b-4384-6a14-08db9801d099 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 11:22:56.7869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H6QxbzR+1s9CtqPzUkqzeVRRRv3bRQZKYmx+6OKnUb0uYQcicLRsGQriJzH5MXoYgf3tI/SXzjpMAPbbH0tTGmMJH5FAMconDhwRItiCGks= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB7261 On 07/08/2023 7:56 pm, Jason Andryuk wrote: > On Fri, Aug 4, 2023 at 7:36 AM Jan Beulich wrote: >> On 04.08.2023 11:29, Andrew Cooper wrote: >>> On 04/08/2023 8:23 am, Jan Beulich wrote: >>>> On 03.08.2023 22:36, Andrew Cooper wrote: >>>>> The opensuse-tumbleweed build jobs currently fail with: >>>>> >>>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': >>>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NULL [-Werror=address] >>>>> 56 | if (!key->p || !key->q || !key->u) { >>>>> | ^ >>>>> In file included from /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17: >>>>> /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12: note: 'p' declared here >>>>> 28 | tpm_bn_t p; >>>>> | ^ >>>>> >>>>> This is because all tpm_bn_t's are 1-element arrays (of either a GMP or >>>>> OpenSSL BIGNUM flavour). The author was probably meaning to do value checks, >>>>> but that's not what the code does. >>>> Looking at the code, I'm not sure about this. There could as well have been >>>> the intention to allow pointers there, then permitting them to be left at >>>> NULL. Who knows where that code came from originally. > The logic looks to be that if p, q, or u are not present, then perform > a regular modular exponentiation. If they are available, then perform > an optimized Chinese Remainder Theorem exponentiation. > > In that light, it's written as if pointers were expected. However, > the code history doesn't show pointers for p/q/u. An RSA key can't > have 0 for p/q/u, so value checks don't make sense. Hmmm, I suppose a > 0 value could make sense to indicate uninitialization. > > tpm_rsa_import_key() and tpm_rsa_generate_key() set p, q, & u. > tpm_rsa_copy_key() copies those over. So it should be okay to use > this patch to just always use the CRT path. It would be safer to > check for 0 though, I suppose. Ok, I'll adjust the commit message. >>> Do you agree that the patch is no function change, or are you saying >>> that you think I got some of my analysis wrong? >> Oh, I'm sorry for the potentially ambiguous reply: I agree there's no functional >> change. I'm merely not sure about your guessing of value checks being meant. > Agreed - no functional change. > > Reviewed-by: Jason Andryuk Thanks.  I'll put it in like this to fix CI, then do ... > > Disabling vtpm is also reasonable given the reasons Andrew outlined. ... this separately. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:02:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579714.907804 (Exim 4.92) (envelope-from ) id 1qTLPr-0000Ly-20; Tue, 08 Aug 2023 12:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579714.907804; Tue, 08 Aug 2023 12:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLPq-0000Lr-VX; Tue, 08 Aug 2023 12:02:22 +0000 Received: by outflank-mailman (input) for mailman id 579714; Tue, 08 Aug 2023 12:02:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLPp-0000LA-E2 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:02:21 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2062a.outbound.protection.outlook.com [2a01:111:f400:7eaf::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d23dc5a-35e3-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 14:02:20 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 12:02:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 12:02:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d23dc5a-35e3-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sneue+UY5J8HTHSuni2y+o4Hsz8BYG5who5PLvAhUdd33Bld8LOKC7ruqbJlRNjNaLvR8PGWwzB0oCZRcNv0gjoYeqr2FgfxCVm7c7f0k6nBcQZlXw4nO8kK4VmtYYe2CABHxWxfcAtpDoOx8KygDC3VCYOfgvsVMaN6NcFuz5ysk4p5ZV7lZy94Xs3H1RQVD84epP5hP/WmyGMWDjE1bxi8AbHeT2169MpFKAwci2kOuADUPbE1lW9T6BxZTpZ6+NqkCLlulTXzwXFDjNGUO7dm7hiC5lofkpnWAKp0Ss0NUMxLvm9Q00lMZuEeC8xlqqWCjLpCDLIQb6sIllGWPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dDsmnaGASxToYZZz1o3iNQdkmcA5nYpDQhCG+xL1ORA=; b=T8vf/wmIe5U2DwfiUQfZ0WmcAMRjjmxOC4oRi0XNuSlQ0tiVgg8Vj4DvYQewjFdlcXoh831pdwl/doUuYddl0tCMYVhH93qEfS36jFrVB5IEnkeC+5h+J0hkEuf4ZFGbqS/emwm0R5kJq/ZDVUNQ4cdlSPyS6vuV+p0sus+dYWxIrdE/v/MeRDK4sswxVtkauHVbLQl4Z2suB/NBJVy04kfgmaOPZS7/ssvOBxtayWy9/dUXQSI77YP8KVG29pBhg6QhM1uhEdz/4JPkzOwf7QUa88aVftzuiFlloHuE8leeFmFoOxvNQEurWfDxLk17igdra+amn9D2gp0ipIxy6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dDsmnaGASxToYZZz1o3iNQdkmcA5nYpDQhCG+xL1ORA=; b=GKgx4frY/KyieoFM6q/wGk/7MgzhIyD2BhVqdHgoLwGVVOpN7bIAX6+KjNeHY/Q6HLdLKWrLrctsstUo/vr+Ml4GTfjtNYeDSpWotxpdxzDCH+8JynQANhS6NvsGCsd4FrIcmybYN8/NR68xareF5VHQ4vJKVMF8k7HDLBDx0EA8afc8/jBs46IVvjrHWkJ2l699fE4vyHy4RvQOsv18YsbQznIfOQmPyWMzrXg0uYIvJfRN67xOXut5+YsWemmFB/dN4M3LvjGNscUaZ7hshfpxTK0S5gkplTYznYMsfr9HKwlcrBLSssXFh0GfjTa+MWqQwkgt6V+A2CbFU0jlcQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 14:02:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio , Tamas K Lengyel From: Jan Beulich Subject: [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 6605eee5-37bd-4eac-9575-08db98074fda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0NM4se0FX4ZVODYYXkFmQDkmgeH2UpKk6xcCEFyDdRxnc7Zmd+lu9CWVZQcluk/CthHCr+r0BXra5B/lmk+1/AkYPMZIYTTR1NMTwSKdT9cJsniC0tF9veVyaDFhZaDtfeCE61YaqCPumn61QyaCVI6sK75IyN7tMppDu1SFmV5K1tGaTb6hbw8qSiQXvQdYJfRaDnxDWyjxTAHpytbzin550+jy5L2qa3XLFLjpK49ysJULCjlGnn4uQzSES9Dq74tNrTKxWxBklqjl+zFthfrSKhkDvsXfH6PyY0HOW+iCTEBL/ZztVU8WxQKnHBrzKCFB7RgBA7bn2JI6/xE7P6KxNCLHDEYQ3C/1kKRKRInU80bE9jqBiYwJqY8lZDQNiWPwtWqT2SYfUxtkxSfUFfu1IwICx/eW0+Z2axXVibwAOS7sqvYCiSI4YHwA9vnHcU3wSlvq95jE8nvQclJAfi5GjUeihLrhKHLi6pFmxKx+OFP0/U+inm32hxYznwBOuqR7kKqTYWhL4tG4V5X+vyWBL24guJurYsMUgDqJ+fHp6+VjUyFA9v1ABlMk+dtNJXwOU5Zwub7ZiIjVsRUMUVF+asUjIVTxrCaWPH4p11exY6FMgf3UpWNfsyUMzNoc+1m62DF36ZuoCQvkXtCq6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(39860400002)(376002)(366004)(136003)(451199021)(186006)(1800799003)(6512007)(26005)(6506007)(66946007)(54906003)(38100700002)(36756003)(41300700001)(7416002)(86362001)(5660300002)(31696002)(4326008)(2906002)(6916009)(66556008)(66476007)(316002)(8936002)(8676002)(478600001)(2616005)(6486002)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amt5Nzc4Qk1XSHNKd1BFWmNSLzh1TU4vZTdPdEpoclIyL2EzaTFnbHFERVBB?= =?utf-8?B?SjBzelhIdWNwbEc2ZnVMTVA5SFJEVzJlalhIeEd3TFFPZlJtdUoyMnZDbFpr?= =?utf-8?B?b3lsa2piN0FmZGZWL3JjenRoWmNGQm5WdFNndmhtRVdpWTI2L1dBZFl0TzE2?= =?utf-8?B?YXBqdkVIdG5tbE00MWlpT1NSbFE1K3B0SHJpSmE3RjlhYWdjNkljdCs2Wkha?= =?utf-8?B?ejZ2dThMaXIyeDRzNlYrQ2xLYjV0RHZsOGI0TXczVmJUVEx3R3luNTdZM2pn?= =?utf-8?B?NFVQNG4rUXJnbm41Tzg1RUtvc3gwanU0TDkyd0N3Ky9JU05BelBhWFlKMmhT?= =?utf-8?B?bDFNZUVST2MrZnFIUHlwa3FuZkpzMGJrTFE5akJNMklCK3Y3TkEyNHRBYVJO?= =?utf-8?B?aEM2dTgvY3ZESVpJSkhwZUxJZFhqVENzNEpUSzlER1J4WjA3RTVFQlFkUnBF?= =?utf-8?B?ZEpsdHpKQU83Qmo0T2c2d0RnVlM3SDBHanRJUG82OElzVDZneHJWZDRNcDVG?= =?utf-8?B?a2RYRFhHZm5BeVpoTlE2V2RkUjQ4aEVwU1BKYTdQV2x0UzhXemFTejlaaG04?= =?utf-8?B?VHBaOFdHdkFLRTYrSWdxWHlQdDEvcDl4QXdwU0JIeHFKMEZZaDFyelUvT1F5?= =?utf-8?B?cmNUY2dhajYybVE2VndMMjErMnVZQVgyM3FHVlU2ZUo1MW05TWVDb012MUR0?= =?utf-8?B?WGE4Rnpadm5xeG5tc0pjVjFISjJxQXczOWN2aFVnc0N6R0lDNXlqbUtmQzNZ?= =?utf-8?B?b0pudEZWN1AzNHZVRysyalM5bnk4bjF6OVZuclh0Y3RaeUxCcnoyTjBjdEZr?= =?utf-8?B?YUxjTUJvWXB5UFZER09CcXlpWElQdC9ZVXdnQkpjaWxZMUtmb0lGTndEUnRG?= =?utf-8?B?Z1cwK2JFYi8wT2FiRVBBbkZQTjcvSDEzOFovZlN6ZSsrNHZmZlJpUmRoQ3V5?= =?utf-8?B?d2RlVG1vSWxUUzVVY0huWVNRWVJBeFg1MGpEU0Q5YlcwQUhqN3hsclo1N1lz?= =?utf-8?B?blhqSlVvckN5VU1ZMDB1MExMbW95bi9XdUJrREVZOU5zN2FMd0ZUcVNqRm5q?= =?utf-8?B?R28zdWlmeVkwem41UytQaEIyRWNpWHIySjNkUjVoREZrSm5TdTU3NnBPYkRp?= =?utf-8?B?bkZGaThJMFQzcUtmeCtZcHM5VEUrVXYrb3oxTWRuaWVjUWlBclptRWJoYlo3?= =?utf-8?B?SUxWNGJGVVdyY1BMUThFYzA1UlZ4ckowZmFST1pEaEtEYkFnTnNsNmJxRHJ2?= =?utf-8?B?bXNIb1VJaVd3ekE3WDBjbWptNTdlUWN0cGsxN2wyQldpL0l5TXNNdU56TWY2?= =?utf-8?B?VzVndVNvaFNnUXY3RHFKUGVaczFZVW9nZUlzd0FmeDU4M0U3Z3QydXVPZGk1?= =?utf-8?B?Z3NnVWlZdkFvMUkzN1g0OWt4SXdtUm16ZmY1NXJsa2xLNGZMT1FFU3FyZXNy?= =?utf-8?B?RmkzZ2RuZTlCMkt0ejJOWGgwZkxUN25TOTBZbVJmQUdEWDh5ZW1rUFNPb3Ax?= =?utf-8?B?OGFpTU93ek5JQ1ozbk5tOG94aUFuZllQcmM5QkhURjVPdlpQOHB6bmFvZms3?= =?utf-8?B?aFl1QXhOeGFtcUJyWUhNSExUdVlWL1VoSW9IajJReUNhUkFQMHZrU3BBTkx5?= =?utf-8?B?dDByMXcwb3Zaa3F5eXRzMlZscnVVazQ2b2p4VEsrVnBhelVFZWFTWm0xcjAx?= =?utf-8?B?SitHdmptcWlpYlZtN3pybEJMVndRdkR2V2ZMZUdoV1lZRFg3RXR2a1pRSFZt?= =?utf-8?B?bUljKzloWnFGSzdXMjBuMW9jMVFjVWp2OHl6aWY5bzYxWHR1Q3EvU1I3aVEz?= =?utf-8?B?RW55anpESFNVcmJ4UkRvRDZ2Tkcrc2w0NG9sekVuTHJFalVpcjRySWxXM2Z4?= =?utf-8?B?L1ZxeDBIYUp0RXpRTkxZeWNqeU9TWXRWNndYNXZMc0RpQ2Y4NWN0eEtUVUdO?= =?utf-8?B?RzFpWnlyT01sMlArQmltWDZXTkIrT0pTTkRKdHJvdTNtMG0zOEpXN3dLdDIx?= =?utf-8?B?ME4wWkpzOFZ2ZEI1YXNFeTlrU2NJaGRheWczdmJjV1cwZWtVNU9uY0ZNVHdJ?= =?utf-8?B?OGtGbVZuenZUYjBXcDUwcjJjZTN5bGJQenV6OGhDTnIwUS9jYitWa0tvUVhG?= =?utf-8?Q?rq0ZIO/RjFaOPxO6qNY/hYFzB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6605eee5-37bd-4eac-9575-08db98074fda X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 12:02:17.6843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H2oUN6fAZvDOQQccBUJcmeDVAFR2J5svzMg5RepdB/TitLE6IudiXE3APF+MuV6ySx4yCP79J/Gsq1mOvFkUJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 When !MEM_SHARING no useful output is produced. Move the function into mm/mem_sharing.c while conditionalizing the call to it, thus allowing to drop it altogether from Arm (and eliminating the need to introduce stubs on PPC and RISC-V). Signed-off-by: Jan Beulich --- I wasn't really sure whether introducing a stub in xen/mm.h would be any better than adding the (further) #ifdef to dump_domains(). We could go further and also eliminate the need for the stub variants of mem_sharing_get_nr_{shared,saved}_mfns() by moving the XENMEM_get_sharing_{shared,freed}_pages cases in {,compat_}arch_memory_op() into the already existing #ifdef-s there. Returning an error for those sub-ops may be slightly more appropriate than returning 0 when !MEM_SHARING. --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1297,10 +1297,6 @@ void free_init_memory(void) printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10); } -void arch_dump_shared_mem_info(void) -{ -} - int steal_page( struct domain *d, struct page_info *page, unsigned int memflags) { --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -6265,13 +6265,6 @@ void memguard_unguard_stack(void *p) map_pages_to_xen((unsigned long)p, virt_to_mfn(p), 1, PAGE_HYPERVISOR_RW); } -void arch_dump_shared_mem_info(void) -{ - printk("Shared frames %u -- Saved frames %u\n", - mem_sharing_get_nr_shared_mfns(), - mem_sharing_get_nr_saved_mfns()); -} - const struct platform_bad_page *__init get_platform_badpages(unsigned int *array_size) { u32 igd_id; --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -2329,3 +2329,10 @@ int mem_sharing_domctl(struct domain *d, return rc; } + +void arch_dump_shared_mem_info(void) +{ + printk("Shared frames %u -- Saved frames %u\n", + mem_sharing_get_nr_shared_mfns(), + mem_sharing_get_nr_saved_mfns()); +} --- a/xen/common/keyhandler.c +++ b/xen/common/keyhandler.c @@ -365,7 +365,9 @@ static void cf_check dump_domains(unsign } } +#ifdef CONFIG_MEM_SHARING arch_dump_shared_mem_info(); +#endif rcu_read_unlock(&domlist_read_lock); } From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:02:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579713.907795 (Exim 4.92) (envelope-from ) id 1qTLPm-00005L-Qu; Tue, 08 Aug 2023 12:02:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579713.907795; Tue, 08 Aug 2023 12:02:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLPm-00005E-Nz; Tue, 08 Aug 2023 12:02:18 +0000 Received: by outflank-mailman (input) for mailman id 579713; Tue, 08 Aug 2023 12:02:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLPk-00004t-Rh for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:02:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6a0d092e-35e3-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 14:02:15 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 6B9DC4EE0737; Tue, 8 Aug 2023 14:02:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a0d092e-35e3-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Tue, 08 Aug 2023 14:02:14 +0200 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' In-Reply-To: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> References: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <9eea3e6039a72d0502ed1416449e041a@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2023 13:08, Nicola Vetrini wrote: > The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised > to address the following concerns: > - needless underscore prefixes for parameter names; > - the variable 'i' in function 'mce_action' that is shadowed > by the local variable in the macro. > > Therefore, the refactoring aims to resolve present shadowing > issues, which violate MISRA C:2012 Rule 5.3, and lessen the > probability of future ones with some renames. > > No functional change. > > Signed-off-by: Nicola Vetrini > --- > Changes in v2: > - Added missing parentheses. > - Clarified commit message. > --- Missing a Reviewed-by: Stefano Stabellini from the other version, since nothing changed code-wise. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:06:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579727.907815 (Exim 4.92) (envelope-from ) id 1qTLUG-0001Ge-M1; Tue, 08 Aug 2023 12:06:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579727.907815; Tue, 08 Aug 2023 12:06:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLUG-0001GX-IO; Tue, 08 Aug 2023 12:06:56 +0000 Received: by outflank-mailman (input) for mailman id 579727; Tue, 08 Aug 2023 12:06:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLUF-0001GR-W1 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:06:56 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fde57df-35e4-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 14:06:54 +0200 (CEST) Received: from mail-dm6nam10lp2101.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Aug 2023 08:06:52 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5018.namprd03.prod.outlook.com (2603:10b6:5:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 12:06:47 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 12:06:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fde57df-35e4-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691496414; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=nm06pE+DvkhhsspPt8Z2wjQuX5ALmz/AziCtoufuze4=; b=GRLVEPv4n+ylWigG7Xvi4j4gBcgfnUEeNkpmQvsPsPeXb3PTj8g7pdcr /IUk2fM1TdB8U8j/AfSAAGuECZB5VSlqvesYYVo+zHYeU/DmyHndyfxbW 04khE749bN1e8yqBw96yLGxybxner/7Z+fCoI/JL6+6OfVsDn83xRDO3r o=; X-IronPort-RemoteIP: 104.47.58.101 X-IronPort-MID: 119276021 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5rehuK3CnJuYLhT5ZPbD5Qhwkn2cJEfYwER7XKvMYLTBsI5bpzMBy GtKDW3Qa6zeZWSgfNEiYN+38kwG7cPUmNQ2QQJvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8XuDgNyo4GlD5gxmNagS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfEERE2 acgcC0xdjOdo9qK0LGeT9RMr5F2RCXrFNt3VnBI6xj8VK5jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6KlFUZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqiCdhNSuXir5aGhnWvwWMzIjFRW2CAhr6erHXnBeJlI nY9r39GQa8asRbDosPGdx+yrWOAvxUcc8FNCOB84waIooLL5y6JC25CSSROAPQ2uclzSTE02 1uhm9LyGScpoLCTUWia9LqfsXW1Iyd9BXcLeCssXQYDpd75r+kbjA/LT9tlOL64iJvyAz6Y6 yuWoSY3gbI7ltIC3ai/+VHBgnSqq4Shc+IuzgDeX2bg4gYnYoegPtSs8QKCta8GK5uFRF6cu nRCg9KZ8O0FEZCKkmqKXfkJG7aqof2CNVUwnGJSInXozBz1k1bLQGyayGgWyJtBWircRQLUX Q== IronPort-HdrOrdr: A9a23:7bHX8K2UPZxw3o/NMNgDzwqjBLokLtp133Aq2lEZdPU1SL36qy nKpp8mPHDP5Qr5NEtNpTn4AtjkfZq+z/5ICOsqU4tKNTOO0AGVxepZjLcKrQeOJwTOstR3+o xEGpIOauHNMQ== X-Talos-CUID: 9a23:ZhI1oW9aiGDDdxPfQwKVv18xEOx+SiXA8G/zPWuANXZqbbioaXbFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3AMf5eXw1YW29CN6igsircpJvbsjUj36OhKGoh1ps?= =?us-ascii?q?9gO7DEgpLYmmttj2Na9py?= X-IronPort-AV: E=Sophos;i="6.01,156,1684814400"; d="scan'208";a="119276021" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrilHjanNiWvw9CcBvuy18sUTV6V07vNyJk2troGZT/WY01hNvti2yCQFB70geGDPyB05/NsrjSLfKBEkoVPFPSo6A5qquvwo9LXDvdDCGHsgW7m2Uqbciqqyv6WVI4xoVscChmaDNG8fkdc9itN7zKyapoyVwsJ2TfWftm0IkrMyYFc6HWQqTWU+Uwk5RW65FdrGTbneR08hs/Hyj+Mgmd8p0D2nWRnLdAgBj+qwWvY8lABoySo3fAVRsKUcZzVbROlxN21QDEGRe/ArWiUB3uvPcfF0szU2l3G3DMipBsNWLRW8Sl8yL5Buyl8N4hoMRbQFMmQXY3u7OBU492hmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=paskMqDzMx6NCTCwQr3nWGzjL6QapiqdakCF63HtgjQ=; b=eB6HjUkceKJ/HzC7vzb5fdMfbwKGtId2ZkbooKqVYEOR6R5LAj5nLd1Bf6NYGNBRJQWVKZSO3+T2qvVvt+r++sAhwsXkdCgET+qdLddhA59GTGWlQJWkRcw3wooRIydg2IgsYipyEmvS1jKmqmJXhtvtqy6sjFkMgA4oJoU6VxEvNzwQHc0Fb/W3kwo2yGJqr87+pcv16CmHgUQ5D1B8PynWNwKJVRVBZBOivjzlLZZaC9cG0sKcedKHOYCcGKGlzITXRvfxO1Oz/YroJu1KP8qD9fZySxiDhuVQF8FfEMx674Xgme9f+5YZTNVBZXmi7Kz/m+IvIcHCQUwsmVr3MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=paskMqDzMx6NCTCwQr3nWGzjL6QapiqdakCF63HtgjQ=; b=KuD6+ryROWMnF45KUldwRpxBFU/bMavxsj0Zy3xrRrVmKz2FVC44zmHVHbkd82+QGHYhXLJItE4EIWwsZdNzEZ6PCIXunOXQFJ8kLH8nPBzpKDRY9dPQZEd2lX//JGLt6jh6FfFC/pElUFAqbPL261a7EcwXt89WIq0+zNRTAFs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Tue, 8 Aug 2023 13:06:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] xen/IOMMU: Switch bool_t to bool Content-Language: en-GB To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel , Paul Durrant , Julien Grall , Stefano Stabellini References: <20230807165830.6719-1-andrew.cooper3@citrix.com> <504749e9-1782-f031-e015-d36c538e80cc@suse.com> In-Reply-To: <504749e9-1782-f031-e015-d36c538e80cc@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0233.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::29) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB5018:EE_ X-MS-Office365-Filtering-Correlation-Id: b7c927a1-8fc9-44a0-c833-08db9807f003 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: az1CEY54AJcccEsiWxKm1DNKmjwZnmNjzsUXKySpAwWHwKVtlJcXuWOULdf9JD1uc1lYfe/yU8B5vW4ySV8mq3Evfijg3D4upswVw6cvXQ4v4RNNg7M/myWseJgdr8K1Ui/C2Af6CUu7/BqNLCEpLYuEJyYvnLTh+gDto6wJeUKeBwYq8RgT+vHUy9KvOMkN24jaMWVaiazQDaQRoDIVC4l900PT9TWFZCl6TmBcSfLmtCsdIVN2ds9lOVZAHfhdUwcqGnTvs43qnsv2N/Sd+6pojI87jphR8aCfq21S/V3HGgNENPDIXVrGpi7Tpiu/sFQClnIM+RBkoUFDjwHRkHdAwWNmEUW61CMG22Uz3pBxPiptJ7vF61lM2BTvBpzO0v8qVGsgFD2+X6/7egy4ZbEWSECmsUcRAPLMCpnEuJAHhwjnNoBnbQ7AufjlclDz67hOEm/mZENgccBqvySDJ29qr+i+A8jIjvGyU+Qka/LgsGGt86EvzxtH7SmrGvthcG/wlnWMdROWpNMboBvoBgzV4Lhm2qGoZTBeE7DDeIExrT7xHy/H9j0v+RN9PLxgWO8acNa8nJ+/tnNhDAauVvnSiVwLQL48pz+jQ9WbSAEpPLO3TWLUQL9YW4NEoEyWZ2GJNjUyF0jDcVmuOvYIsg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199021)(186006)(1800799003)(8936002)(8676002)(5660300002)(6916009)(4326008)(41300700001)(316002)(86362001)(31696002)(2906002)(6486002)(6512007)(6666004)(2616005)(53546011)(6506007)(26005)(36756003)(66476007)(66946007)(66556008)(82960400001)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2grQ0U4emVwa2xxVXd6VU1OQmllUXJNS21Hd3dac3d3SHZGOU4zb1dhVHFX?= =?utf-8?B?R2crQzh1b2d1QkFSQUpmbTNyS3NWclZNYVZmZUxxSlZrOVRWcUhrdjRYaGVt?= =?utf-8?B?eEF6Nlo5cERSenpOaDcrUy96S3NQUWcwa21aZlVKSzZqSytxa1lKeW10ZFZr?= =?utf-8?B?SDJBaXBoOUJvUzdUcUtrVmdzOUdnZjkxK0tiMlZnRUxqcG1lcG5FODFYR2JK?= =?utf-8?B?SDZsNExiSDEzaDhHOU1Rb2ppMExoRGhzaHRFNkxnRXRlUzh1RDlyY3VLSkE4?= =?utf-8?B?RHNJeGxEZmFkY2ZsZDEzMTlFSkdsSnRNUlhJeFJTcW9iY2NFMHo1bkhheUJE?= =?utf-8?B?L0ViY29valFqZUd0MkRmVjVJeFI3QnRrTU1qckc1VThuRi9BUmFSVytNOEwr?= =?utf-8?B?TDVpaFc5UmVvRzBweDBpeHE3bWJJb1NZWmpURXlmOXk3ZDRBOStITWtYWkZh?= =?utf-8?B?djRydjkvWGFpSmRveGdLamlvT2VJb1UrMTdTdTNIRFdlaWFIV1FLMmNoQVJL?= =?utf-8?B?UHdTQUdFVGRnTHRiM3U1Yjk0MFN4eXhqVWxnZldrcjJvbDVxZnlwVWZESUJK?= =?utf-8?B?ZFBCRXAyTm5EZTBiQlE2TFdCODlwZjJ5b0xQNFMzZkZZVjFLZ2M4bHBYV3lH?= =?utf-8?B?KzNZWTlkRndCeTNlL1licVI3RUJzbkxYWHFNZVlLVndpci91c01TaW12bGFO?= =?utf-8?B?S1FrMTd1MlBtNlU0eERKM1EvTnQzOU9PRklXRGtuSXRqNnpZL1QrcFlxalRG?= =?utf-8?B?eXhYc1hMYVFsa0svM0tGcHljS3VpL1NZNUtKYVFQbGVnNWZvZHFGVFNoMlIw?= =?utf-8?B?TUQzanlkN0FvR3NRVDNJY092V3Nzc3BUdVZKaFI4dXFKVVg2a0FrWG0wNExH?= =?utf-8?B?eWk3Z1dFVnVEL2NXaU1iVjRBSWFhWkJlcWt0RmZ4TDBsM1VSVUtJYUdmQkZo?= =?utf-8?B?SWdkNW1HY1VaWnp2MTJjK1lRalA5VTZEMm5tVXVJQVBnSVJmRVphMDZiYndH?= =?utf-8?B?U21KSzhIZldHcm9YSUJ3a3RQZmZ2NWR0TlNmUUVNQ2ViNU5DMlZXdXcrMkJB?= =?utf-8?B?ay9rbVdVSnVoSUdXdmhBVWVMOENNNDhaNVNkWFViejk5VW56TlorVDFURUNE?= =?utf-8?B?VnQ3eXVRaDdlYko5TC85SFBFSUt5T3UzWThUM1FjTlV2Unl0WVJiYnFtY291?= =?utf-8?B?WDljWENSRlA0akE5RHNiL2tFZWZ2M1BRSDNrbnk1R1IzYUtkMjN5dENZNjhM?= =?utf-8?B?eHVranNSZjRJK1A5bVhUa0FRZTR5TW1Jdm9ZZXRjZEU3VzMxSkdUTnBFZzFr?= =?utf-8?B?c0p0eC90THdEL2dWZlpRb0lGZ1E1WllXNzZBOXJ6UVV2RUkxbStzUXJlWVJG?= =?utf-8?B?b1hJaGV1TGZ6Zm5VTk5RTE5KT280NHhWd25jQzhGSllyd2xOSXlmTmdmUnZq?= =?utf-8?B?VDNkNmd3VElrU2RPdTQySUNiQ2RtTzhqdmVNNlhlbHF4UUZKR0w5K0tXNmk4?= =?utf-8?B?bHJyM0pWSXRncHpENkI2ZWxqaWVDVEQwSHJHZ1pKZXZzNU5zUzFBUnZRUExE?= =?utf-8?B?V0haeXVETS9RbVJaZC9TNS81WjVSc1g4RngxTkJoYWt4c2xtRmQwbjJ2aSti?= =?utf-8?B?WHZybHg0eWdRYW1QY2ZGYzJtNDYrTlVkTVlRbHN2aWtZOWVtREdQVEh6NGhU?= =?utf-8?B?N3laaXZlb3FQZzlsODhxeHBpQ000cjA5VkFld2s3SEpFM0gxaElSUlIwZStx?= =?utf-8?B?VTMrejZ4VFRQZnlhRVZnTVZnQjlkWCsxN0VzK3QzeitSYnh3eFRLb3ZJaTVT?= =?utf-8?B?NlJGbFlTK2djMzlZMzZvQjZxZXNVQWNPUmVKQkV5ejdOYUJxVTNoM1pSU0Fr?= =?utf-8?B?OXRpTTk5eUc3eTFXSjhhVkFBOVp5ZlA5YWx6YTBaWkd1dklkSjZrMkIrTGhx?= =?utf-8?B?NXpuWXJiV2F3NVU0SmRGSjNaTCtxcVRLaFVWWWNFMnQ1cURrRXFpZkV3R2dp?= =?utf-8?B?b1QvWTFITUlzaXdBSlU4eXJpUk56VXRhTklpNXBrMnhncTM0RWFDc1JnZTAx?= =?utf-8?B?c3hRTUlyQ0d4VW5rb05ZZjY4VGRQUHVFOEg1a0E2dVFXRzBBa1JnL0tROVpS?= =?utf-8?B?WXFyclhzSmJ4ajM5aXh6MlRzTjhtQXRwTzlYMlR0d0ZSM081TWVDL1ZjRERK?= =?utf-8?B?Wmc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uGHhIa3S6k6OgNVF+TflSHiSd3Nz7DTgLHiaErd8/oGbBbc6PTrxeZh1YGz+hJ7J0AKbW6REHQTztvZvvU3eKdqgzFQ/yyAlJqFrl7vLClivmIncZ6f0fN2EPxzvhvwspqe02hJwAzy0GglHJ2YHdxsiSX+ybkk957p1fUniUWIYOv23k5AHCM4zS/2f0aKd+w1AF4TtsPYRJE+c2aSFtnawB6hbb5xrR6Aa6Nd77nePpgjAng6zyFy+hoUnrlgM4cG8bIGmoMZ+UBZ9CQv/EnXMFjQCXDuCuFF92/np202EpFodYYz/9iUKS7aDzCke05VEPfz7VLst5xWhYYuNiWEljNVprIZKYC84CZM5Whtnb84Mpa766KjA4p0/0fu4ps9lha20kVzfAx4PU+plsRM1jXPPEqSk/gDA0Q/q8kre2LPjENnb7x3UIXGq/D7zFWsz/heIHnZQtbeFV01R7qphhSyysXm5w+X9z6YU8YVi+dvB/OToBbJQ2G2LOQiNpr3Phh6EXqtKo/5eUR1RM90xSyjXreRxP2sW1Fd1TLPGOD51BUpoaNvPVsd2bbJBmZfg2pNbADI0sax9d+94BwmG2ZG08taRgoYFELbxd3BtY5nqdQP66S7xnGuIdZZDVrK17Vv0mXziHdqZgmiy8K9bA5/OlKgdcr+jkZ8u17pXBTUhAzSfPuB9zW5kURaX55JVNTHAxJcjZx4oJTnOrvOHcm9/R6gZsZRW88y5gIk1Ve+uxsE/Gx6PPDIDCJ0r7rMqYaB9uDgSF3nPQKr7iH7x9QtvptD3aUv2cGpd1D1Jv+LXI0wUyEvy/DmbKxhIAZZTbtHM+thHkKDYhrewI4gUKzdnKhdO/FRvpnWHy2A= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7c927a1-8fc9-44a0-c833-08db9807f003 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 12:06:46.5268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aPioY9wuzq1IUGGWcBpcgxB7YQk3abW+Ri1TdoKxJ780FtQy6VHrzSbAIFAEowgCFg7z8PLwQ0KJRuDmd1SySGu5CZZ8zFTlnOfWTJHwlR4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5018 On 08/08/2023 8:54 am, Jan Beulich wrote: > On 07.08.2023 18:58, Andrew Cooper wrote: >> ... as part of cleaning up the types used. Minor style cleanup on some >> altered lines. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich > >> --- >> CC: Jan Beulich >> CC: Roger Pau MonnĂ© >> CC: Wei Liu >> --- >> xen/drivers/passthrough/amd/iommu.h | 4 ++-- >> xen/drivers/passthrough/amd/iommu_acpi.c | 6 +++--- >> xen/drivers/passthrough/amd/iommu_init.c | 6 +++--- >> xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- >> xen/drivers/passthrough/ats.c | 2 +- >> xen/drivers/passthrough/ats.h | 2 +- >> xen/drivers/passthrough/device_tree.c | 4 ++-- > This will want a DEVICE TREE ack; Cc-ing respective maintainers here > (and therefore preserving full context). > >> xen/drivers/passthrough/iommu.c | 8 ++++---- >> xen/drivers/passthrough/pci.c | 16 ++++++++-------- > For these and ats.? you would also have wanted to Cc Paul. This very much qualifies as tree-wide. In fact, it was the only decently-sized chunk I could pull out of the pair of patches, one for common and one for x86. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:06:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:06:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579728.907824 (Exim 4.92) (envelope-from ) id 1qTLUI-0001XF-US; Tue, 08 Aug 2023 12:06:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579728.907824; Tue, 08 Aug 2023 12:06:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLUI-0001X8-Qw; Tue, 08 Aug 2023 12:06:58 +0000 Received: by outflank-mailman (input) for mailman id 579728; Tue, 08 Aug 2023 12:06:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLUH-0001RT-HA for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:06:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20619.outbound.protection.outlook.com [2a01:111:f400:7e1b::619]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1122ec32-35e4-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 14:06:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 12:06:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 12:06:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1122ec32-35e4-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyOM7dJNu0A7qG6HCeasam+Gn4m0TCwhQcapVozyWE6sfjOgUUwKoQgahM0Owsp4l9a5LRecP50tobVYtqAlq8xx2LwtrcAhRzeUoki+UEVFemxAWWL9cwTYD6ZKz4aBYGszqxvWUYuELTHev+3Haq35wLqtVXegZFMrfzxezd6K6EjpiLDOuLUCYvyBzTbBHReiUplwq3f9iizGFhTeoXujiMbs/pORHjuesNyFHxcfP4IfSO81ZY1+xUEeH+riDqXjUz8LDD5ubBX7R3TZ5sRqQ5wnluue5Y3V3l+z+WWtBRIjL88bwhs00IjrEwiJEhLiPACykdL1u2jjwnPP0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kbSVd4AQ/cg4rWC6Eiz1nBnPOOJ0qhAEOljRQ+KIphM=; b=iWWxYU9cvC3XTEDGpweRMDzKC28vtcsJTGiE6eNm9NJm9/jWyH4aE36Up7cDjIEIezpjQxrsp1djVVvkSJ3mx8YAtNZpBCpR5tCDFUTEJm5noJc1G/5sbAP/71khH22KyqPWDo/Cc2DlZDMv2yEr5u/wLt4d0xYtWhBPR/CaFmjzdOEIFX8figWLuD9iR4wBO64QmFgHW2NDP5rPdnlcJQJegOIZCER55kdN/y7O/3uUGkxhlgUDqLuq1e/Wqh8YqkidTXlJoRK1SNQ/5nLHc9BHJFdiO04TaG8DjDpuFVtps7SPvETNGfn416wEX08+qeu7cNw8ggFGRBBMdjsYAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kbSVd4AQ/cg4rWC6Eiz1nBnPOOJ0qhAEOljRQ+KIphM=; b=GrH10CNa35lRbA9RZv1cA4GU8oF8vgbzpZLDXRistgOtxZrzI6gDTaHRN7dCZsdaE+hk9VmzQoQH2I7ebO6TepuRSoJa1uqR0/R6d7SmssvU8dm1q+bCWbCFYUJrUwvgrjqzHYBIsqc2eD4V90SaqDEO4JC9HtEmsQkjtZWiPUAy5ok4nfPmvEb1dIdFKKixjVqeiLA8L/VjDIv9wvV0e3Aivlk+64sazEFjNdQSyQxM4QoDd2hmDH9PzBraywJqzWw2RFjH+8vGRDlAHcXyzQy40aHllAwWt1ZwYnhDBzHMe7LqoHENU/RQv4zFKlrHhDYyCKiqSyd97+weyRvW9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80ead475-68cd-0cf3-3d2e-252ad4b1f976@suse.com> Date: Tue, 8 Aug 2023 14:06:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> <9eea3e6039a72d0502ed1416449e041a@bugseng.com> From: Jan Beulich In-Reply-To: <9eea3e6039a72d0502ed1416449e041a@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 63a56f3d-2096-4524-9b0c-08db9807f476 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p6KjIhenvxpMQYt82C+KjOGC6wyXZXR24cZA86svZQZcur6yTF+41C54NlZbRRUPJThVYAFW2k8benA8P6Qynj7qype5QpVNL1qze0hjVZcmRGb5eFzbCD3AizA+4E0dWm4amBw7VgPejImCqN00dwhrg4ViGkzg5qD8bCH5GMvCj/0yP1gTrd+PmELFJlHjl4OHcJZWxJih7lQ0a2bOx7LjiSvk0SfX9/e7FXfvJMZ1B58CGoHo8m+VINzRBWOYAn2Ojb+0NMIaoAdabQ5UIQPa8GKac6amLuaM3NoSIePPu8o6uizlCiyY/OY/vAt2Pf1DfceeCyUjEOVkAJDKS6wulsEdJOwW+ILg7GToMQXJ1WUTput057yLNZVsNBsN4Pcd/YynWC4ZyK4l7tAsHuqgqgf2OjB2oR6s1SwmTcdSW/LgxnpDV+9rwbsgPS1N/74SPrMXZlwBp7BMZL5YP8Vlq16HEE/yNgZd34u5cA2gfeQ+cJxzJ62PpEypksrbygAnp+ZgG2ELgp3x9meqbZryWFvKnpWgjkwFYCLpytCgCI835SmcNGxmlR8hsH6apBjl0ScOZudyonGuo17y5CnJ04braqhlXxgPjfKNS5F+7qSTz75yL9MMhjCoEJhcomsLQDg9fE7qoFqRjYbx7A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(39860400002)(376002)(366004)(136003)(451199021)(186006)(1800799003)(6512007)(26005)(6506007)(53546011)(66946007)(54906003)(38100700002)(36756003)(41300700001)(7416002)(86362001)(5660300002)(31696002)(4326008)(4744005)(2906002)(6916009)(66556008)(66476007)(316002)(8936002)(8676002)(478600001)(2616005)(6486002)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWFNM0h3N3J1aVlqR3ZDWWQvalNGQk9vOGhCOWVjMHpWYXFDV2ZKNXpseUFN?= =?utf-8?B?QllUZ3Y2YVc4N1VCZ0dNK1BoTkNIRjdldFlJSmNPMHNrV1BReUVoRFJNeDBp?= =?utf-8?B?NDRtZlBoM2JUM1AwYnhIV3kyRjBheTZoVjdqd3Z4NjhGT3ZIcFdtVVB4aGxs?= =?utf-8?B?ZkxMMk5TQ0ljNnJDclQwQ1NGL0dMeU9GK3V3V2l6WjlJeUd2UE1uUHB3UW5s?= =?utf-8?B?aVpoOW04aGNOOHlYVWlaUUp1N3BsZ2NxeDlHc2JZa3JRdTlHRXVLOHVXSXpT?= =?utf-8?B?SUVDbHZ1VEY4UjJTMWhkN1NhM2ZSV05IV1kyMGdtTldKZWozZFVMMitLUEhB?= =?utf-8?B?LzRNc01SeVA3R210RUhPLzI0WU95Vkc5bmJ1VVVZRjBmWE10NFB4TmtOUmFQ?= =?utf-8?B?ZG51enhQdGV6SnVVK3hQeHV6Ni8zQmtGQnh5MlBnSExTQ0VSazY0VjA5MnU5?= =?utf-8?B?QXhiQmZPN2FyMlM4SHhlRVhTdGtxd3hxY3VidUMzN1JCTjFHdGs1bzRLMEg5?= =?utf-8?B?UzdINEYvVWo2c1d4bzUyWTFFak5RcWtuQUZsbFJGNFZiWFVWblFZSzZ5M2FI?= =?utf-8?B?a2tkd2w0VzlHTFJCSk92VmNCNzNwOVJINDg5c2ZBTEs0QzZYbGQyN0pNaW9k?= =?utf-8?B?N1dIbXh2dXNiY25PdjJWVHpjNFZwODBYRUF2QXRnRzNxTFBTNHpKbk9QWG9n?= =?utf-8?B?SER2eG9ST0w2RWJ2REgySTdOOEFyZTgzNklpTEZsUS8wb2V5ZkNqVllpU3JE?= =?utf-8?B?VCt1c3UzeWtHRis3M1VFQnM4Rm5FbFRzQXhIeG0wMU8rQ3FYc0ZsSWpmTXNM?= =?utf-8?B?VUVkdmJyQUc3V3Q2RkFVQys4TmNXUHdMbXJkeGl6S2Y4ZFo2bHVaT01VNjdw?= =?utf-8?B?enpsOFU5dlV5RURXQ3pzcE9pcW1NdGxLNTFlcDY3b25wYit1cXN1N2xkZXo5?= =?utf-8?B?U1FmdFdwaXE1dnJwM0RJbDFhc0hDV1VVdk95aFk3SzVYaWlXeUZiMHlFNFZ5?= =?utf-8?B?U0hnK3ZzUmhVQ2NUWHNiRlJCbm5ZQ2tma2doR1VTb0l1Z1BLVmlnTzRveklV?= =?utf-8?B?TVRLenY5QWlsc0RKVnBlMHNRdE9JNGNheXZNMktKWGVmQVhpaUZGS0o2Z2Yy?= =?utf-8?B?K0lScUkrWEc0ZkRhdHprdDNhd1NKY0Zwb20yYjZ4cjlCM0wxN2Mxb3pqMkdk?= =?utf-8?B?QmRlZGpVRU5ZS2RRdFpLV2NDdkNUVk1TbGFra1VQUElLbW9oK2dPUGE5bW9x?= =?utf-8?B?SmErODl2U01xZWVQa2tOV3ZQb2xHRjJnajMyRVVNcDNNNzkzNnQ2cDJNQWY0?= =?utf-8?B?YnlNazZXKzl2d2dYMHp4RGRDTmJwRTFJQjQ2L1ZYY3VzYmJrWmpQcTY2c2x2?= =?utf-8?B?SHg4MlhHcmUzc3hnVkc2QVVtWXJvUEZuWkhJM3BTeTBGaXZHdGFDNDBpV3Nw?= =?utf-8?B?SEZ6OGVKUngvbkNCeUxrMVRXM1ZubC93Ly9VMlR2azd5YlplY1Q5SHgwUGY3?= =?utf-8?B?RHFIV0tlR0lZbldqSVIyeWt6RGVwWlBnZGlEb1ZoZWwweGozcWJjSGpETlh5?= =?utf-8?B?enJqM3BxdEhiR2g1ZUswOEVjczl1RFZIT1BlQ0J5YU9YcEJScllYdWh2dkM5?= =?utf-8?B?bWVqUExuZXo4emNrSTlza3I5THRLbm5uSjBXbngvU3Nwa29qUmhxQVhwUHdu?= =?utf-8?B?RnNDK2UrQWZYck1ScUVOTlBvcVBqYzIrUEVJcUhnRnZFNit6T2xSUFB4NU4x?= =?utf-8?B?Wk01OFZrSnFBYi9NNDdsY2hzNDFmdithT1gydlU2YXdzQm1KSmd6WU4wc1FG?= =?utf-8?B?MjdMUmNTNFNqQStROTBFcGg0cUNzZzk3ZFlFRE1iOWZmZDU3U3B4VytDZHls?= =?utf-8?B?QnhSRWQxTEJQSWxNckVSYlFrTnEwT1h0NG5HQ0d3eTJ4b1hSaXRselBDMy9X?= =?utf-8?B?Zzd6d3F5SEJVQ3A4KzZyWVlkakp6Y0lUc1k2dnFTSEY4dHZ3cDNhMTlIQVdi?= =?utf-8?B?bmx5Qjc3ZXZXdUM3d3NTZzBSNjFNdTB1SDUxMW95eGRiQkE1RElOOU45RURq?= =?utf-8?B?QmVEaGx0Z0lpcmZCNHc4enl5WmVVVjY4OUMvUFVXdCszbytQd0hqVXFURFNJ?= =?utf-8?Q?N0T3QSIWDBDmxzbFwdMaTQ3ED?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63a56f3d-2096-4524-9b0c-08db9807f476 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 12:06:53.8187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mhcZ9DkAJ6yRiKvCiQOjP1RjHgIMlwrhV6UNCn4K0PRZXtTjKww3wQFpLNEZTqo/G06Kwghj9sW6VixegwPIWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 On 08.08.2023 14:02, Nicola Vetrini wrote: > On 08/08/2023 13:08, Nicola Vetrini wrote: >> The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised >> to address the following concerns: >> - needless underscore prefixes for parameter names; >> - the variable 'i' in function 'mce_action' that is shadowed >> by the local variable in the macro. >> >> Therefore, the refactoring aims to resolve present shadowing >> issues, which violate MISRA C:2012 Rule 5.3, and lessen the >> probability of future ones with some renames. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini >> --- >> Changes in v2: >> - Added missing parentheses. This ... >> - Clarified commit message. >> --- > > Missing a > Reviewed-by: Stefano Stabellini > from the other version, since nothing changed code-wise. ... isn't exactly "nothing", but well. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:12:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579741.907835 (Exim 4.92) (envelope-from ) id 1qTLZT-0003NB-LM; Tue, 08 Aug 2023 12:12:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579741.907835; Tue, 08 Aug 2023 12:12:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLZT-0003N4-HN; Tue, 08 Aug 2023 12:12:19 +0000 Received: by outflank-mailman (input) for mailman id 579741; Tue, 08 Aug 2023 12:12:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLZR-0003My-VD for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:12:17 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20603.outbound.protection.outlook.com [2a01:111:f400:fe16::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0b5484d-35e4-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 14:12:17 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB9246.eurprd04.prod.outlook.com (2603:10a6:102:2a1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 12:12:14 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 12:12:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0b5484d-35e4-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PAw7OTb9LnBNeCD9K60MXEF/XieD3kyvM/vXEI/lu8NQ+K8VmNP82P0qXJ1wq+7mWNUwIP9G6aH+CR47huale44YndB5PzFm7pD1BSpV0cXNVZLLriPqg5/det7d8kmzZ/ji5f3pGedYGvhg830xMllORKVXbvuVXQDLsDEteAZOTXaUTf2WiEC4XAJ4OWhg9tr+CP9zXgRSwepRdeiFd9VaT0qGeeBHWIjMntJnYOzS425vqLCYg9NWDflFztwEYrMIdOoywEa8ghZAEHYSmxZrBw4RMr1cQ7d3TL0ma/ZmwjLqRVM+XSSbmgvn8ynRIBrYrE/8kNEv9mEya525lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sDXJFUhU/mADNUjwLM0sVzaAQ/sTsGmRu5XwIKXxzJs=; b=a4CLkuaS43axHZcj1SyQpDbwAo8fdpaJJU1h1miTP5LwdzPL1adpbn9MkTcdCPBvJY+H/kRwzjHlR6P/iisaQk3DDlWX9jOviLx7pqK9Bf7dAT0Un/MFb0foStYyRGHqtZE/0RIyDxcdmLY3OVOEppFPQRlRQZpcK5Ip0rHQ0d8q0V+eTI+0BIzx/XDwRRC5w9eWAeHzbdlOiSjeM+YFd6yk5CJeVBB8ssnFzlENDEY5gVEiVE+y2H934yJOKymIjTNdWGMovipZQm12zhIBDA/flrqHAeOkU+ox4l4N5S2sSArBzp9itdX3dx/G/s/K8QDRQoZrrGU9k+2toAU2SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDXJFUhU/mADNUjwLM0sVzaAQ/sTsGmRu5XwIKXxzJs=; b=FkHmhla452ZOjqYybjwON6n3FcZJ+Vp7c9DHKt+wLDTfbpNG1oEXbLQDfHZ7VXtAV6JZGMJMJ4oIP5mMVgNlpgyKh+5KZnnxnbEaUpMKwez3itSQcJwGbS893SjckM+JU7RSRJtLahJVWWYhV+Bfnd+aNwPkeynjNFpAlR3HldpsdsqLf9/Hbm1OixZmTqcbN+9fi/hgoP/KdR/W4PctLIODiY304G4ySMj27DFfxu6cmfoYt9D1xKK76hTKyEUOVmPq763AgBuau7ayP2uQ1rM24LE2qA2wut0/vfhGuyexycgP4cTV7l2I/ybQEHRKbeEhTVjOqKKD0ym6VuHRrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 14:12:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] xen/IOMMU: Switch bool_t to bool Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel , Paul Durrant , Julien Grall , Stefano Stabellini References: <20230807165830.6719-1-andrew.cooper3@citrix.com> <504749e9-1782-f031-e015-d36c538e80cc@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB9246:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c24a097-6e9a-479b-ec32-08db9808b35b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 62up28BMCp5CJ646YvRL2N3dhdJL6b2hWnQ3cZLEkUd/VBVIFJYZ0v7KV0vernDza342aynQljw2/+VMfR+qCzeXySMtLSEhspB0TSz0+dbicAnEfDULzlCw0H8MMF43g2oDkIOyS0h4FSelBnD0lCmMCa9HYsWxUXz/fP/tIZY/SRGd1+TltYsmhIJTKE9CHZAvsmBnlfYrDANws8UFZ4Bs+rSb2Me+XTq0JCEGfp8edopsNRjKOGhSFLgAX+iuXTVtvF19UvBN6FBVY8E0b/0GT+KSM5uWKWgAiG3U0siFpsDn17IRBOQpou0xAPyoqGTCMJh97kdlO/1iUq++GlUZOvJhM8a1X9CNpmHaVImashSKzT/hbt3JyMbLEFxo/FudWpQgQBxfgQhWddkgrU2aQQJE7FdwWul3askJsahx1GiYGmtXeQGDe2MayGjuLDkbadq4DvCGizGV+coU6w/eohbYZV3iqNYfVO94fAcFdlOPfyjZkbgtWFrVt/RrIC1SDpxiB7vaS+neUNkE4LkdWreOYEK+JoMM/GE99ztVDg+xyyNFj2xHy6azC+RtyySHcMfgSP8heBiHjHwKW1aG0MwRxPSO8VvYrRgtfjfkDlvxj9hJff+rPoZWXGzvIcAUmYAF2vag7Js/n0Npzg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(396003)(39860400002)(366004)(1800799003)(186006)(451199021)(6512007)(26005)(6506007)(53546011)(66899021)(36756003)(54906003)(38100700002)(5660300002)(86362001)(2906002)(4326008)(66476007)(66946007)(8676002)(316002)(6916009)(66556008)(8936002)(41300700001)(31696002)(6666004)(6486002)(31686004)(478600001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmQ1d2Y5Z3hQZXdtWTdmajQrM3BQNDlKSjFWd1BwclhoMWVlWERua0hIWDha?= =?utf-8?B?NFA2eUt4VWtvZDVLSmVQbmFrVTdCc091Q1NDbEh3WU0xTlljaCtXandqamRB?= =?utf-8?B?TGlEUDZiclRQTEc1UGt5eS9HY3ZQMXpEQzB4M1k0eVkrZnhUR1dWN1NwMWZJ?= =?utf-8?B?WDRlVmYwRVJ5VlVJS01xWHlIUzhHOEN5TDBuTEZ2QklCVFNyNWtrNjlKM1U1?= =?utf-8?B?cDMzWS9NTmJWRkNRL1ZvSlhTNmdTTHBQaGxTaTFEQlA2NXZoNzdYZlMwaERt?= =?utf-8?B?UC9XMXJQalJZbGVWS2diTEJWbTQ3dE5jZ1ZhZjJmODgyOWk1Z1FqdWN1LzV5?= =?utf-8?B?Q3d4cnBKdmYrcjZpRXkyRnNseDBGYXlXYlNCUkF1Q2dFbXNZV0RXS3BNZnBN?= =?utf-8?B?OUhUeUJkd1ZBcTJWNkRPTEhTaVVVbHB4VkJSYjNnckpBa2M4K2Y1czZwMWRS?= =?utf-8?B?aFJrMHZ2S3laalh6Y0ZqazFjeEQ3aXlJWkNGWHpkb1lUTXV5TG1JTkNWTjgv?= =?utf-8?B?S0tPQmEwOE8yUFNCUFFIYmZxd1N6emw0Rnhtd3pNZHJQUDNaWUdGWTRvQTFN?= =?utf-8?B?WmdjbU5xaExxUUg4ZVU4dEoyS2ExZTFSSWJoei85NTNaNlk2MkZFUGxOOGdP?= =?utf-8?B?cXBYd1VNc1JmcnVaenV3QURqTS9KWjY2WmIyT3duVHpJeXovUmRod2RMSUlj?= =?utf-8?B?amNaQ2EyQW5yelppQnZkd1NLQUFzTUhFS2wwUFM2WXhtSnZxNFZpRG1taEIr?= =?utf-8?B?c09QVjVKWk96b0Q3TjhhZzFaRkdXZDR2QVp5dFN3RXhNMXBNWW9NbWR0Rk9J?= =?utf-8?B?ZEF3bUwyS2YxZU93Nmd1ZHVRdXJnTW1qVW1DWFNNVlZFV3dXQ1RyWHNFRDd4?= =?utf-8?B?Y0IzeUpzaXJQbzJ6OGI5OEZVeEthVEtMOTB2bWdMYlhJRXd1b2o3aU9WbllD?= =?utf-8?B?VE9Vb0hyT1NXa1VONGphOHBDQTNVSWtzMXlIM1M0MVJyWVUva0NYSXFSeDN2?= =?utf-8?B?OHV0OFZpTlR6YnV4bXVQK3NIU3dlOURkNTdwaGU1K0E1M09BRGxRaTc1SG9L?= =?utf-8?B?Q25DcUY0bmdVTXg4eWNyekZPNEpLcW9oc3pFMC9EaGpmNWEvM2ZhMWszQ1RN?= =?utf-8?B?aWlST2JqeExBRVRNYXlQdlpKVWw2Y3o3aGN4ZVg4L0JhbUt5V0pwckFmNlhp?= =?utf-8?B?Sys1WlhvcDNpSjNrMnU5RW1yNFRjMGZGb0hLSE9WcTA4MlNwRm9ucElDblJp?= =?utf-8?B?cUtlbVRZSWRORlp3SXpaYjB5YWRZVllnNmtEaXI5NFFvMHpzU0pnU1paMGVI?= =?utf-8?B?YkIvT2JKa29HUk5lU0pacmw1a3JaK1kxMjJrakJSamdJeW1vbzdvaUxTVVRB?= =?utf-8?B?L2xQV3pkOVM0WDRnL3I5WVJOb24raUJya05RN29xa0tTVm83dnFjWHk4cDlO?= =?utf-8?B?RlQvaFA0WE92QUdSUFBSUFVmSlY1NjBaMFNUMDNSRWlJK21OajNwcTQwVVZU?= =?utf-8?B?NnFrNWxJNWZqLzhmTWx3anc2SlIrTmNSWjFNWnVBcFhhaWF1cGt5YVIvbm9K?= =?utf-8?B?eUhpajdBdzQ4Ky81azRmcnZsbGJEblpReXZGQ1JkcUNBNHRneTdVWDBhMnl2?= =?utf-8?B?TzR2d211aGoxZDBnZkJlQnEzZWJsZi8vSlM3VnkxeEtEc05VdWprNWJGM0Nz?= =?utf-8?B?a29iQXhhQ1krbitMYTc4RUFBanZiRHJaRjk3aUVkOEtlOXF6RElHcExqcjVx?= =?utf-8?B?bWlWWEtPemlJMXJCRzlUT0ttN3hBSjN1ay92dzRVYkRyYkdkUExrRmNhNE93?= =?utf-8?B?NHFhbVBaMHBzc1Y2MTJCcWVHTStBRkRodC9FMWx4bE5xUFlRVU1CSWtZbW5L?= =?utf-8?B?ZjM4U3A4NTVUR3FPN2xBaDQwckFBaFhrQkpKR3RIck95RldkenpaY0Z3aHMz?= =?utf-8?B?QnQ5bkRvdWh0RjA2aVRJVnZMWVdrMHAyKzdYVzROZnN6THc3ZjNNQktFbDdJ?= =?utf-8?B?cFRVODRQV0FmTDFzdFpRdkV3aEJ1MnU5a2NMZE9DeU5lRmhrZTFOaXdDU0N1?= =?utf-8?B?NWNZd0N0MU5oMFczQlZkanNSTnl5aVFDNmNPbjV6M1NXTUp3cjZMa0JTbSth?= =?utf-8?Q?aRSNhvOie3h1qq7eG8EowjgOs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c24a097-6e9a-479b-ec32-08db9808b35b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 12:12:14.0595 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AfIasFnb4WNoQafjEXymlIlpnZ+j23nKUTOI5h3Eadd1FWpMjnBkRs+FsNp6IEhjg4ny87v1/r0TFxKGuMlW/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9246 On 08.08.2023 14:06, Andrew Cooper wrote: > On 08/08/2023 8:54 am, Jan Beulich wrote: >> On 07.08.2023 18:58, Andrew Cooper wrote: >>> ... as part of cleaning up the types used. Minor style cleanup on some >>> altered lines. >>> >>> No functional change. >>> >>> Signed-off-by: Andrew Cooper >> Reviewed-by: Jan Beulich >> >>> --- >>> CC: Jan Beulich >>> CC: Roger Pau MonnĂ© >>> CC: Wei Liu >>> --- >>> xen/drivers/passthrough/amd/iommu.h | 4 ++-- >>> xen/drivers/passthrough/amd/iommu_acpi.c | 6 +++--- >>> xen/drivers/passthrough/amd/iommu_init.c | 6 +++--- >>> xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- >>> xen/drivers/passthrough/ats.c | 2 +- >>> xen/drivers/passthrough/ats.h | 2 +- >>> xen/drivers/passthrough/device_tree.c | 4 ++-- >> This will want a DEVICE TREE ack; Cc-ing respective maintainers here >> (and therefore preserving full context). >> >>> xen/drivers/passthrough/iommu.c | 8 ++++---- >>> xen/drivers/passthrough/pci.c | 16 ++++++++-------- >> For these and ats.? you would also have wanted to Cc Paul. > > This very much qualifies as tree-wide. Certainly. Question is what follows from this. In Prague we discussed whether to weaken the required-acks model, and if I'm not mistaken we said we'd first try whether we can't really get chasing acks to work (i.e. for people to respond in a timely fashion, ideally not really requiring any "chasing"). That said, it certainly remains up to you whether to wait of whether to commit. Yet even if already at submission time you know you're not going to wait, I think relevant maintainers should still be Cc-ed. > In fact, it was the only decently-sized chunk I could pull out of the > pair of patches, one for common and one for x86. Right, and I was actually (positively) surprised you sent a smaller granularity patch here. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:23:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:23:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579748.907856 (Exim 4.92) (envelope-from ) id 1qTLk1-00057s-Ti; Tue, 08 Aug 2023 12:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579748.907856; Tue, 08 Aug 2023 12:23:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLk1-00057l-Os; Tue, 08 Aug 2023 12:23:13 +0000 Received: by outflank-mailman (input) for mailman id 579748; Tue, 08 Aug 2023 12:23:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLk0-0004sp-S1 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:23:12 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56056ff7-35e6-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 14:23:10 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id DA9164EE0737; Tue, 8 Aug 2023 14:23:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56056ff7-35e6-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v3 0/2] x86: address MISRA C:2012 Rule 5.3 and 8.3 Date: Tue, 8 Aug 2023 14:22:49 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series is the part of series [1] that needed further adjustments. The first two patches of that series are already committed. The changes in this version are detailed in the individual commit messages. [1] https://lists.xenproject.org/archives/html/xen-devel/2023-08/msg00492.html Nicola Vetrini (2): x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 x86/setup: address MISRA C:2012 Rule 5.3 and 8.3 xen/arch/x86/hvm/vmsi.c | 46 ++++++++++++++++---------------- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/setup.c | 3 +-- 3 files changed, 25 insertions(+), 26 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:23:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:23:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579749.907865 (Exim 4.92) (envelope-from ) id 1qTLk3-0005N1-2y; Tue, 08 Aug 2023 12:23:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579749.907865; Tue, 08 Aug 2023 12:23:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLk3-0005Mt-0B; Tue, 08 Aug 2023 12:23:15 +0000 Received: by outflank-mailman (input) for mailman id 579749; Tue, 08 Aug 2023 12:23:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLk1-0004sp-HW for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:23:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56e016a6-35e6-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 14:23:11 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 649EF4EE0741; Tue, 8 Aug 2023 14:23:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56e016a6-35e6-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v3 2/2] x86/setup: address MISRA C:2012 Rule 5.3 and 8.3 Date: Tue, 8 Aug 2023 14:22:51 +0200 Message-Id: <05ff36ef9e1838ac782201998f49f6f56f78332a.1691488505.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The parameters in the function declaration 'construct_dom0' violate Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers", but also cause shadowing inside the declaration scope with the variable "static struct file __initdata kernel;" in 'xen/common/efi/boot.c'. Renaming the parameters in the declaration resolves both issues The local variable 'mask' is removed because it shadows the homonymous variable defined in an outer scope. There's no change to the semantics since the last use of this variable is in the scope touched by this commit. No functional changes. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- Changes in v2: - Clarified commit message As mentioned in the preivious iteration's thread: the declaration itself is a scope and shadowing can happen, as in: int x; void f(int x, int arr[x]); Now, the example is a bit contrived, but the fact that the rule does not list any exception motivates the declaration of 'construct_dom0' being considered a violation. --- xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/setup.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 51fce66607..b0e6a39e23 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -33,7 +33,7 @@ static inline void vesa_init(void) {}; int construct_dom0( struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, + const module_t *image, unsigned long image_headroom, module_t *initrd, const char *cmdline); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2dbe9857aa..80ae973d64 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1577,8 +1577,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) s = map_s; if ( s < map_e ) { - uint64_t mask = (1UL << L2_PAGETABLE_SHIFT) - 1; - + mask = (1UL << L2_PAGETABLE_SHIFT) - 1; map_s = (s + mask) & ~mask; map_e &= ~mask; init_boot_pages(map_s, map_e); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:23:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579747.907844 (Exim 4.92) (envelope-from ) id 1qTLk0-0004sx-LA; Tue, 08 Aug 2023 12:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579747.907844; Tue, 08 Aug 2023 12:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLk0-0004sq-IL; Tue, 08 Aug 2023 12:23:12 +0000 Received: by outflank-mailman (input) for mailman id 579747; Tue, 08 Aug 2023 12:23:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLjz-0004sj-ML for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:23:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 566fc8bb-35e6-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 14:23:10 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id A4AE04EE0740; Tue, 8 Aug 2023 14:23:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 566fc8bb-35e6-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v3 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 Date: Tue, 8 Aug 2023 14:22:50 +0200 Message-Id: <605687eff99db7181ef6c05bce671e20f194b46b.1691488505.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The local variables 'irq_desc' shadow the homonymous global variable, declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed 'irqd' for consistency with ARM code. Other variables of the same type in the file are also renamed 'irqd' for consistency. Signed-off-by: Nicola Vetrini --- Changes in v2: - Renamed the local variables instead of the global. - Edited subject from x86/irq to x86/vmsi Renaming everything to 'desc' would have been the most obvious choice, but given that there's also 'msi_desc' used in the same functions, 'irqd' is less error-prone in my opinion. --- xen/arch/x86/hvm/vmsi.c | 46 ++++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 3cd4923060..55d5e26a04 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -281,7 +281,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, unsigned int nr_entry, index; int r = X86EMUL_UNHANDLEABLE; unsigned long flags; - struct irq_desc *desc; + struct irq_desc *irqd; if ( (len != 4 && len != 8) || (address & (len - 1)) ) return r; @@ -330,21 +330,21 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, if ( !msi_desc || msi_desc->irq < 0 ) goto out; - desc = irq_to_desc(msi_desc->irq); - if ( !desc ) + irqd = irq_to_desc(msi_desc->irq); + if ( !irqd ) goto out; - spin_lock_irqsave(&desc->lock, flags); + spin_lock_irqsave(&irqd->lock, flags); - if ( !desc->msi_desc ) + if ( !irqd->msi_desc ) goto unlock; - ASSERT(msi_desc == desc->msi_desc); + ASSERT(msi_desc == irqd->msi_desc); - guest_mask_msi_irq(desc, !!(val & PCI_MSIX_VECTOR_BITMASK)); + guest_mask_msi_irq(irqd, !!(val & PCI_MSIX_VECTOR_BITMASK)); unlock: - spin_unlock_irqrestore(&desc->lock, flags); + spin_unlock_irqrestore(&irqd->lock, flags); if ( len == 4 ) r = X86EMUL_OKAY; @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry *entry) int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtable) { - struct irq_desc *irq_desc; + struct irq_desc *irqd; struct msi_desc *msi_desc; struct pci_dev *pdev; struct msixtbl_entry *entry, *new_entry; @@ -482,14 +482,14 @@ int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtable) if ( !new_entry ) return -ENOMEM; - irq_desc = pirq_spin_lock_irq_desc(pirq, NULL); - if ( !irq_desc ) + irqd = pirq_spin_lock_irq_desc(pirq, NULL); + if ( !irqd ) { xfree(new_entry); return r; } - msi_desc = irq_desc->msi_desc; + msi_desc = irqd->msi_desc; if ( !msi_desc ) goto out; @@ -508,7 +508,7 @@ found: r = 0; out: - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); xfree(new_entry); if ( !r ) @@ -533,7 +533,7 @@ out: void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) { - struct irq_desc *irq_desc; + struct irq_desc *irqd; struct msi_desc *msi_desc; struct pci_dev *pdev; struct msixtbl_entry *entry; @@ -544,11 +544,11 @@ void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) if ( !msixtbl_initialised(d) ) return; - irq_desc = pirq_spin_lock_irq_desc(pirq, NULL); - if ( !irq_desc ) + irqd = pirq_spin_lock_irq_desc(pirq, NULL); + if ( !irqd ) return; - msi_desc = irq_desc->msi_desc; + msi_desc = irqd->msi_desc; if ( !msi_desc ) goto out; @@ -559,14 +559,14 @@ void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) goto found; out: - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); return; found: if ( !atomic_dec_and_test(&entry->refcnt) ) del_msixtbl_entry(entry); - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); } void msixtbl_init(struct domain *d) @@ -664,12 +664,12 @@ static unsigned int msi_gflags(uint16_t data, uint64_t addr, bool masked) static void vpci_mask_pirq(struct domain *d, int pirq, bool mask) { unsigned long flags; - struct irq_desc *desc = domain_spin_lock_irq_desc(d, pirq, &flags); + struct irq_desc *irqd = domain_spin_lock_irq_desc(d, pirq, &flags); - if ( !desc ) + if ( !irqd ) return; - guest_mask_msi_irq(desc, mask); - spin_unlock_irqrestore(&desc->lock, flags); + guest_mask_msi_irq(irqd, mask); + spin_unlock_irqrestore(&irqd->lock, flags); } void vpci_msi_arch_mask(struct vpci_msi *msi, const struct pci_dev *pdev, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:24:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:24:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579765.907874 (Exim 4.92) (envelope-from ) id 1qTLlC-0006TK-E2; Tue, 08 Aug 2023 12:24:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579765.907874; Tue, 08 Aug 2023 12:24:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLlC-0006TB-BV; Tue, 08 Aug 2023 12:24:26 +0000 Received: by outflank-mailman (input) for mailman id 579765; Tue, 08 Aug 2023 12:24:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLlB-0006T1-6d for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:24:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLl9-0003K6-Qy; Tue, 08 Aug 2023 12:24:23 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.31.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTLl9-0000yI-HG; Tue, 08 Aug 2023 12:24:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=39kcSSHBhdyZ37w3Fi441KnjRHvlOsxLqca8Jjs7ZZo=; b=isdET1bEgHpNW/xFEDA6nxcfUp ZEraDiksFsW4ESff4QX5+SHiSHVykw3kYX6HBu900jVG1QyiLEcRmSl4KIC8FfQeVrU1rDfsJapjs KkO9v0cziTvKCj64RHnpTqPhCepBP5ljyaCelL12OnZ7114WW1+qj67un7McujN2oIbY=; Message-ID: <9fc81ba0-ca27-425c-84b6-90d767022086@xen.org> Date: Tue, 8 Aug 2023 13:24:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/IOMMU: Switch bool_t to bool Content-Language: en-GB To: Jan Beulich , Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Xen-devel , Paul Durrant , Stefano Stabellini References: <20230807165830.6719-1-andrew.cooper3@citrix.com> <504749e9-1782-f031-e015-d36c538e80cc@suse.com> From: Julien Grall In-Reply-To: <504749e9-1782-f031-e015-d36c538e80cc@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/08/2023 08:54, Jan Beulich wrote: > On 07.08.2023 18:58, Andrew Cooper wrote: >> ... as part of cleaning up the types used. Minor style cleanup on some >> altered lines. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > > Reviewed-by: Jan Beulich > >> --- >> CC: Jan Beulich >> CC: Roger Pau MonnĂ© >> CC: Wei Liu >> --- >> xen/drivers/passthrough/amd/iommu.h | 4 ++-- >> xen/drivers/passthrough/amd/iommu_acpi.c | 6 +++--- >> xen/drivers/passthrough/amd/iommu_init.c | 6 +++--- >> xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- >> xen/drivers/passthrough/ats.c | 2 +- >> xen/drivers/passthrough/ats.h | 2 +- >> xen/drivers/passthrough/device_tree.c | 4 ++-- > > This will want a DEVICE TREE ack; Cc-ing respective maintainers here > (and therefore preserving full context). Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 12:28:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 12:28:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579774.907885 (Exim 4.92) (envelope-from ) id 1qTLpH-0007Ab-Uq; Tue, 08 Aug 2023 12:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579774.907885; Tue, 08 Aug 2023 12:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLpH-0007AU-S5; Tue, 08 Aug 2023 12:28:39 +0000 Received: by outflank-mailman (input) for mailman id 579774; Tue, 08 Aug 2023 12:28:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLpG-0007AO-Ai for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 12:28:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTLpE-0003NM-E6; Tue, 08 Aug 2023 12:28:36 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[192.168.31.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTLpE-00013Q-7d; Tue, 08 Aug 2023 12:28:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=EYaOroeVFlJM9DpgQl2/n4FQhpOoYKJb12BcVk4ofpU=; b=nioaxZiF7EzxSXQLk7D4M6Qv6b rnUMLD6UzwqC36spkmCoIrXEWPtfJU1dB0KLEJr2paS1JhcLM5wjSeX/zIOecC7uxj/QN+vg2jrMo 0V/5aXmy54ayPr/gdLuo2eiyKL7TJGiz2pZwkOhpHn5xwVP8qgs3RRO5RPHQEODl9PzM=; Message-ID: <2c9ec464-954a-4404-973d-4d7b6ab7be54@xen.org> Date: Tue, 8 Aug 2023 13:28:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/IOMMU: Switch bool_t to bool Content-Language: en-GB To: Jan Beulich , Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Xen-devel , Paul Durrant , Stefano Stabellini References: <20230807165830.6719-1-andrew.cooper3@citrix.com> <504749e9-1782-f031-e015-d36c538e80cc@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 08/08/2023 13:12, Jan Beulich wrote: > On 08.08.2023 14:06, Andrew Cooper wrote: >> On 08/08/2023 8:54 am, Jan Beulich wrote: >>> On 07.08.2023 18:58, Andrew Cooper wrote: >>>> ... as part of cleaning up the types used. Minor style cleanup on some >>>> altered lines. >>>> >>>> No functional change. >>>> >>>> Signed-off-by: Andrew Cooper >>> Reviewed-by: Jan Beulich >>> >>>> --- >>>> CC: Jan Beulich >>>> CC: Roger Pau MonnĂ© >>>> CC: Wei Liu >>>> --- >>>> xen/drivers/passthrough/amd/iommu.h | 4 ++-- >>>> xen/drivers/passthrough/amd/iommu_acpi.c | 6 +++--- >>>> xen/drivers/passthrough/amd/iommu_init.c | 6 +++--- >>>> xen/drivers/passthrough/amd/pci_amd_iommu.c | 2 +- >>>> xen/drivers/passthrough/ats.c | 2 +- >>>> xen/drivers/passthrough/ats.h | 2 +- >>>> xen/drivers/passthrough/device_tree.c | 4 ++-- >>> This will want a DEVICE TREE ack; Cc-ing respective maintainers here >>> (and therefore preserving full context). >>> >>>> xen/drivers/passthrough/iommu.c | 8 ++++---- >>>> xen/drivers/passthrough/pci.c | 16 ++++++++-------- >>> For these and ats.? you would also have wanted to Cc Paul. >> >> This very much qualifies as tree-wide. > > Certainly. Question is what follows from this. In Prague we discussed > whether to weaken the required-acks model, and if I'm not mistaken we > said we'd first try whether we can't really get chasing acks to work > (i.e. for people to respond in a timely fashion, ideally not really > requiring any "chasing"). > > That said, it certainly remains up to you whether to wait of whether > to commit. Yet even if already at submission time you know you're not > going to wait, I think relevant maintainers should still be Cc-ed. +1. Nowadays, it is also not very difficult to CC the relevant maintainers. scripts/add_maintainers.pl will add all of them automatically for you. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:02:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579784.907925 (Exim 4.92) (envelope-from ) id 1qTMMF-00043N-DB; Tue, 08 Aug 2023 13:02:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579784.907925; Tue, 08 Aug 2023 13:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMF-00043G-9I; Tue, 08 Aug 2023 13:02:43 +0000 Received: by outflank-mailman (input) for mailman id 579784; Tue, 08 Aug 2023 13:02:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMD-0003KL-8i for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:02:41 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db1c4a94-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:02:40 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fbea14700bso48055405e9.3 for ; Tue, 08 Aug 2023 06:02:40 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b003144b50034esm13567072wrs.110.2023.08.08.06.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:02:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db1c4a94-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499760; x=1692104560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CLKiL/jNslxYi/QSWYQzg3uu6el6+QZP5XsqGeRNlAs=; b=Yk2dU9B70C6NTd0q+fmYujVQUDxUzjoJ1Ysp42lk4W37mG7tb3DKPXw/RhRga+2oRR M/kOXQzc5+oJVn6ptI/aUS9kSvCrV0rxeKDHsjAyrb8/4pnJY27YeCCAS5399PRQeBIY BWMKM/aK7koR6IvEahvAw0xLiWNgi/Wr4WqYc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499760; x=1692104560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CLKiL/jNslxYi/QSWYQzg3uu6el6+QZP5XsqGeRNlAs=; b=ZGrpmHoJwna1rb1N1Ea0s8BxA2L8UUjuv7e6x2BgP0jKCLQmoTEu2qe2o0SlYIQ8W4 lXFL4504GWdn79DJcOFZ09aBCOZ3ztNvY4wgynDdsLC8ADe4aYtW03ZGZkphtQZJaUwI t5X5vp2nqoiDwegiqN7UpqR3CjQIAS4qSyiOIsVAGIpZny5aWWGD6aJ5MX6vnv1P3Ufd gwckdetsMDG3fWfoDBEjZBVqKESZLWTfEEPpyaIJhRdiK63D3utrSdF25XvMPy7CqJRb zsXQ98lCpCakR6awF61ugD6W3orPIRdAPLRl4Ilxsm8wgsI3XqO43NDPJpCv4jcNO2LN lbPA== X-Gm-Message-State: AOJu0YzsViNU8HhyhmkVUmN4p/LOfTbaa0VC/beB3nSMYZpB8RjVMKZ2 k7G8xfwq5DtaLE60qcHosdEKF4cy0HP9TJg8Ttw= X-Google-Smtp-Source: AGHT+IGaM6+/0iPdaGeT67glHUk1CVKgmWsCdOnkmwkJfkQWD8hDRBMP6LVD/yt05UNn/y/OWrxcyA== X-Received: by 2002:a1c:7708:0:b0:3fe:108d:7f88 with SMTP id t8-20020a1c7708000000b003fe108d7f88mr7998422wmi.36.1691499759914; Tue, 08 Aug 2023 06:02:39 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall Subject: [PATCH v3 4/4] pdx: Add CONFIG_PDX_COMPRESSION as a common Kconfig option Date: Tue, 8 Aug 2023 14:02:20 +0100 Message-Id: <20230808130220.27891-5-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130220.27891-1-alejandro.vallejo@cloud.com> References: <20230808130220.27891-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds a new compile-time flag to allow disabling pdx compression and compiles out compression-related code/data. It also shorts the pdx<->pfn conversion macros and creates stubs for masking fucntions. While at it, removes the old arch-defined CONFIG_HAS_PDX flag, as it was not removable in practice. Signed-off-by: Alejandro Vallejo Reviewed-by: Julien Grall --- v3: * Fixed a typo in Kconfig's help * Gated CONFIG_PDX_COMPRESSION under EXPERT=y and left default=ARM * Fixed commit message after renaming CONFIG_PDX_COMPRESSION (Julien) * Changed #else comment to the reason it executes (Julien) * Various blank-line related style changes (Jan) --- xen/arch/arm/Kconfig | 1 - xen/arch/x86/Kconfig | 1 - xen/arch/x86/domain.c | 19 +++++++++++++------ xen/common/Kconfig | 13 ++++++++++--- xen/common/Makefile | 2 +- xen/common/pdx.c | 16 ++++++++++++---- xen/include/xen/pdx.h | 38 +++++++++++++++++++++++++++++++++++--- 7 files changed, 71 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index 57bd1d01d7..224db89c05 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -14,7 +14,6 @@ config ARM select HAS_ALTERNATIVE select HAS_DEVICE_TREE select HAS_PASSTHROUGH - select HAS_PDX select HAS_PMAP select HAS_UBSAN select IOMMU_FORCE_PT_SHARE diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 92f3a627da..30df085d96 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -24,7 +24,6 @@ config X86 select HAS_PASSTHROUGH select HAS_PCI select HAS_PCI_MSI - select HAS_PDX select HAS_SCHED_GRANULARITY select HAS_UBSAN select HAS_VPCI if HVM diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index fe86a7f853..f476df17e4 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -458,7 +458,7 @@ void domain_cpu_policy_changed(struct domain *d) } } -#ifndef CONFIG_BIGMEM +#if !defined(CONFIG_BIGMEM) && defined(CONFIG_PDX_COMPRESSION) /* * The hole may be at or above the 44-bit boundary, so we need to determine * the total bit count until reaching 32 significant (not squashed out) bits @@ -485,13 +485,20 @@ static unsigned int __init noinline _domain_struct_bits(void) struct domain *alloc_domain_struct(void) { struct domain *d; -#ifdef CONFIG_BIGMEM - const unsigned int bits = 0; -#else + /* - * We pack the PDX of the domain structure into a 32-bit field within - * the page_info structure. Hence the MEMF_bits() restriction. + * Without CONFIG_BIGMEM, we pack the PDX of the domain structure into + * a 32-bit field within the page_info structure. Hence the MEMF_bits() + * restriction. With PDX compression in place the number of bits must + * be calculated at runtime, but it's fixed otherwise. + * + * On systems with CONFIG_BIGMEM there's no packing, and so there's no + * such restriction. */ +#if defined(CONFIG_BIGMEM) || !defined(CONFIG_PDX_COMPRESSION) + const unsigned int bits = IS_ENABLED(CONFIG_BIGMEM) ? 0 : + 32 + PAGE_SHIFT; +#else static unsigned int __read_mostly bits; if ( unlikely(!bits) ) diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0d248ab941..2c1d1fc3a2 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -23,6 +23,16 @@ config GRANT_TABLE If unsure, say Y. +config PDX_COMPRESSION + bool "PDX (Page inDeX) compression support" if EXPERT + default ARM + help + PDX compression is a technique that allows the hypervisor to + represent physical addresses in a very space-efficient manner. + This is very helpful reducing memory wastage in systems with + memory banks with base addresses far from each other, but carries + a performance cost. + config ALTERNATIVE_CALL bool @@ -53,9 +63,6 @@ config HAS_IOPORTS config HAS_KEXEC bool -config HAS_PDX - bool - config HAS_PMAP bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 46049eac35..0020cafb8a 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -29,7 +29,7 @@ obj-y += multicall.o obj-y += notifier.o obj-$(CONFIG_NUMA) += numa.o obj-y += page_alloc.o -obj-$(CONFIG_HAS_PDX) += pdx.o +obj-y += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o obj-bin-$(CONFIG_HAS_PMAP) += pmap.init.o obj-y += preempt.o diff --git a/xen/common/pdx.c b/xen/common/pdx.c index d3d38965bd..d3d63b0750 100644 --- a/xen/common/pdx.c +++ b/xen/common/pdx.c @@ -31,11 +31,16 @@ unsigned long __read_mostly pdx_group_valid[BITS_TO_LONGS( bool __mfn_valid(unsigned long mfn) { - if ( unlikely(evaluate_nospec(mfn >= max_page)) ) + bool invalid = mfn >= max_page; + +#ifdef CONFIG_PDX_COMPRESSION + invalid |= mfn & pfn_hole_mask; +#endif + + if ( unlikely(evaluate_nospec(invalid)) ) return false; - return likely(!(mfn & pfn_hole_mask)) && - likely(test_bit(pfn_to_pdx(mfn) / PDX_GROUP_COUNT, - pdx_group_valid)); + + return test_bit(pfn_to_pdx(mfn) / PDX_GROUP_COUNT, pdx_group_valid); } void set_pdx_range(unsigned long smfn, unsigned long emfn) @@ -49,6 +54,8 @@ void set_pdx_range(unsigned long smfn, unsigned long emfn) __set_bit(idx, pdx_group_valid); } +#ifdef CONFIG_PDX_COMPRESSION + /* * Diagram to make sense of the following variables. The masks and shifts * are done on mfn values in order to convert to/from pdx: @@ -176,6 +183,7 @@ void __init pfn_pdx_hole_setup(unsigned long mask) ma_top_mask = pfn_top_mask << PAGE_SHIFT; } +#endif /* CONFIG_PDX_COMPRESSION */ /* * Local variables: diff --git a/xen/include/xen/pdx.h b/xen/include/xen/pdx.h index b5367a33ca..6511aba6c7 100644 --- a/xen/include/xen/pdx.h +++ b/xen/include/xen/pdx.h @@ -67,8 +67,6 @@ * region involved. */ -#ifdef CONFIG_HAS_PDX - extern unsigned long max_pdx; #define PDX_GROUP_COUNT ((1 << PDX_GROUP_SHIFT) / \ @@ -100,6 +98,8 @@ bool __mfn_valid(unsigned long mfn); #define mfn_to_pdx(mfn) pfn_to_pdx(mfn_x(mfn)) #define pdx_to_mfn(pdx) _mfn(pdx_to_pfn(pdx)) +#ifdef CONFIG_PDX_COMPRESSION + extern unsigned long pfn_pdx_bottom_mask, ma_va_bottom_mask; extern unsigned int pfn_pdx_hole_shift; extern unsigned long pfn_hole_mask; @@ -206,7 +206,39 @@ static inline paddr_t directmapoff_to_maddr(unsigned long offset) */ void pfn_pdx_hole_setup(unsigned long mask); -#endif /* HAS_PDX */ +#else /* !CONFIG_PDX_COMPRESSION */ + +/* Without PDX compression we can skip some computations */ + +/* pdx<->pfn == identity */ +#define pdx_to_pfn(x) (x) +#define pfn_to_pdx(x) (x) + +/* directmap is indexed by by maddr */ +#define maddr_to_directmapoff(x) (x) +#define directmapoff_to_maddr(x) (x) + +static inline bool pdx_is_region_compressible(unsigned long smfn, + unsigned long emfn) +{ + return true; +} + +static inline uint64_t pdx_init_mask(uint64_t base_addr) +{ + return 0; +} + +static inline uint64_t pdx_region_mask(uint64_t base, uint64_t len) +{ + return 0; +} + +static inline void pfn_pdx_hole_setup(unsigned long mask) +{ +} + +#endif /* CONFIG_PDX_COMPRESSION */ #endif /* __XEN_PDX_H__ */ /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:02:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579782.907901 (Exim 4.92) (envelope-from ) id 1qTMMC-0003NJ-UN; Tue, 08 Aug 2023 13:02:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579782.907901; Tue, 08 Aug 2023 13:02:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMC-0003Mw-P0; Tue, 08 Aug 2023 13:02:40 +0000 Received: by outflank-mailman (input) for mailman id 579782; Tue, 08 Aug 2023 13:02:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMB-0003KL-QL for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:02:39 +0000 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [2a00:1450:4864:20::334]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d9aac536-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:02:38 +0200 (CEST) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3fe2fb9b4d7so47794765e9.1 for ; Tue, 08 Aug 2023 06:02:38 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b003144b50034esm13567072wrs.110.2023.08.08.06.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:02:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9aac536-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499757; x=1692104557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6QBQAGjY2r360IlHRoBLqtdiryrX7RiFTTDs7pUf/s=; b=lc7bZs3dOMd6Nfz9ANn2pPGoZX0osgPGShUy6l6kN2Yq6Z/ZJoMOqVnmGyLsy4hCDL B6MG6+iJjZKS9NaWVbpqrgb28AwKQWOzmdYsoFhSiStk+8R0UMs9djSaBGjN14+qhMkn GX+CpclGLCSR4GndhJCA93ewSmAEiGEuTp4Bw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499757; x=1692104557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6QBQAGjY2r360IlHRoBLqtdiryrX7RiFTTDs7pUf/s=; b=Yb1k6OWU82S00uPKZ4rgat0tUsRvZpsKHzVjIiKtxa7xZPVJmphXX/22nySLtP1+7f WZ28LVfgDeRAgardKIUWunMoMHHYkr9/SEjz+9OC8RjRl9TcAWFsW3+gNSf0PrKQYDWj I7o+RIon4WnsnMwQgcp9lhB5oy1EUyCWqqOteyUJOzK1FSLNrXj9oj+ru9Tvo0LXDPPx 5uknn9KWyhQcr7JTB1Jr7BHAxsbi/Ud1YzD3B7eyeF0BcOZK2j487yl9ERlRn85LpyAR c3YX6ZpH/JEOE6WSO900Pch5TIy/2igOM5lTXUS2PQgTftjPzANd9RYDYSFmP3sAhZMn 4LhQ== X-Gm-Message-State: AOJu0YxawKebhctvo702AlRnN+iGnv9EdEqKOqZN8qjlw2l/WxtTltWw CLm6faZrKozZQQ14gq0ki8PQ656/nZNB022A8DE= X-Google-Smtp-Source: AGHT+IGI4sjkvPq5FlJLChKC03G3IDBfL8r9LDQBa14X9x6e46zkyN+2uB0RKQUmhONKDEg0sakldw== X-Received: by 2002:adf:ce09:0:b0:317:5caa:c3a3 with SMTP id p9-20020adfce09000000b003175caac3a3mr7489337wrn.40.1691499757343; Tue, 08 Aug 2023 06:02:37 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall Subject: [PATCH v3 1/4] mm: Factor out the pdx compression logic in ma/va converters Date: Tue, 8 Aug 2023 14:02:17 +0100 Message-Id: <20230808130220.27891-2-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130220.27891-1-alejandro.vallejo@cloud.com> References: <20230808130220.27891-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch factors out the pdx compression logic hardcoded in both ports for the maddr<->vaddr conversion functions. Touches both x86 and arm ports. Signed-off-by: Alejandro Vallejo Reviewed-by: Julien Grall --- v3: * size_t -> unsigned long (Jan) * uint64_t -> paddr_t (Jan) --- xen/arch/arm/include/asm/mm.h | 3 +-- xen/arch/x86/include/asm/x86_64/page.h | 28 +++++++++++--------------- xen/include/xen/pdx.h | 25 +++++++++++++++++++++++ 3 files changed, 38 insertions(+), 18 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 5b530f0f40..c0d7f0f181 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -319,8 +319,7 @@ static inline void *maddr_to_virt(paddr_t ma) (DIRECTMAP_SIZE >> PAGE_SHIFT)); return (void *)(XENHEAP_VIRT_START - (directmap_base_pdx << PAGE_SHIFT) + - ((ma & ma_va_bottom_mask) | - ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); + maddr_to_directmapoff(ma)); } #endif diff --git a/xen/arch/x86/include/asm/x86_64/page.h b/xen/arch/x86/include/asm/x86_64/page.h index 53faa7875b..e40b451221 100644 --- a/xen/arch/x86/include/asm/x86_64/page.h +++ b/xen/arch/x86/include/asm/x86_64/page.h @@ -36,26 +36,22 @@ static inline unsigned long __virt_to_maddr(unsigned long va) { ASSERT(va < DIRECTMAP_VIRT_END); if ( va >= DIRECTMAP_VIRT_START ) - va -= DIRECTMAP_VIRT_START; - else - { - BUILD_BUG_ON(XEN_VIRT_END - XEN_VIRT_START != GB(1)); - /* Signed, so ((long)XEN_VIRT_START >> 30) fits in an imm32. */ - ASSERT(((long)va >> (PAGE_ORDER_1G + PAGE_SHIFT)) == - ((long)XEN_VIRT_START >> (PAGE_ORDER_1G + PAGE_SHIFT))); - - va += xen_phys_start - XEN_VIRT_START; - } - return (va & ma_va_bottom_mask) | - ((va << pfn_pdx_hole_shift) & ma_top_mask); + return directmapoff_to_maddr(va - DIRECTMAP_VIRT_START); + + BUILD_BUG_ON(XEN_VIRT_END - XEN_VIRT_START != GB(1)); + /* Signed, so ((long)XEN_VIRT_START >> 30) fits in an imm32. */ + ASSERT(((long)va >> (PAGE_ORDER_1G + PAGE_SHIFT)) == + ((long)XEN_VIRT_START >> (PAGE_ORDER_1G + PAGE_SHIFT))); + + return xen_phys_start + va - XEN_VIRT_START; } static inline void *__maddr_to_virt(unsigned long ma) { - ASSERT(pfn_to_pdx(ma >> PAGE_SHIFT) < (DIRECTMAP_SIZE >> PAGE_SHIFT)); - return (void *)(DIRECTMAP_VIRT_START + - ((ma & ma_va_bottom_mask) | - ((ma & ma_top_mask) >> pfn_pdx_hole_shift))); + /* Offset in the direct map, accounting for pdx compression */ + unsigned long va_offset = maddr_to_directmapoff(ma); + ASSERT(va_offset < DIRECTMAP_SIZE); + return (void *)(DIRECTMAP_VIRT_START + va_offset); } /* read access (should only be used for debug printk's) */ diff --git a/xen/include/xen/pdx.h b/xen/include/xen/pdx.h index de5439a5e5..8f29598230 100644 --- a/xen/include/xen/pdx.h +++ b/xen/include/xen/pdx.h @@ -160,6 +160,31 @@ static inline unsigned long pdx_to_pfn(unsigned long pdx) #define mfn_to_pdx(mfn) pfn_to_pdx(mfn_x(mfn)) #define pdx_to_mfn(pdx) _mfn(pdx_to_pfn(pdx)) +/** + * Computes the offset into the direct map of an maddr + * + * @param ma Machine address + * @return Offset on the direct map where that + * machine address can be accessed + */ +static inline unsigned long maddr_to_directmapoff(paddr_t ma) +{ + return ((ma & ma_top_mask) >> pfn_pdx_hole_shift) | + (ma & ma_va_bottom_mask); +} + +/** + * Computes a machine address given a direct map offset + * + * @param offset Offset into the direct map + * @return Corresponding machine address of that virtual location + */ +static inline paddr_t directmapoff_to_maddr(unsigned long offset) +{ + return (((paddr_t)offset << pfn_pdx_hole_shift) & ma_top_mask) | + (offset & ma_va_bottom_mask); +} + /** * Initializes global variables with information about the compressible * range of the current memory regions. -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:02:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579783.907907 (Exim 4.92) (envelope-from ) id 1qTMMD-0003TD-7y; Tue, 08 Aug 2023 13:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579783.907907; Tue, 08 Aug 2023 13:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMD-0003SD-0W; Tue, 08 Aug 2023 13:02:41 +0000 Received: by outflank-mailman (input) for mailman id 579783; Tue, 08 Aug 2023 13:02:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMC-0003KL-6A for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:02:40 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da3608df-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:02:39 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fe4cdb724cso35102535e9.1 for ; Tue, 08 Aug 2023 06:02:39 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b003144b50034esm13567072wrs.110.2023.08.08.06.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:02:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da3608df-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499758; x=1692104558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8bmCX6/SgqPEzLULBMXi4oRdiZi0jx4EL6SjA6yskLk=; b=bYvV3jm8vm2ZXHhiwwyLmeZIgAfDGl8g1mq6KQErwgRsYe/a/ByiM5MSIQS7FZHhel 6Hv3ekMucT5gR64edHqzlpOaJpy4Foi3NGc2eQgQaAiReMfAute04vzsr6W1bR/F5ewv iMY2HtiwXSxkMf1JC1nXYTTs6DCeAyM4JyN9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499758; x=1692104558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8bmCX6/SgqPEzLULBMXi4oRdiZi0jx4EL6SjA6yskLk=; b=jTaErEwRMirqqcJkhQBv19YNwrI8JwX38zzqeis4V6ooUHyfqGe/mU7SfsNQ41oiHI a++r5xk8TV+Psc0yXOORVKQ/CEkDAd8FLJXh00Tfd2uIqMWS19KhEM2Z3IAym4JBRZJj rbDzpL2/tShna+EZeKph3MlkK+z3bdFcvx0Fm/LB7fqgYN6a7JRZTvGik4oA52qTuPFu H3tztfhQwxSmahXOwOLfN5P7aU6IcK51B6Dnd0KkGyvS+yFaRyVGkEagfngR75QLSiGv dbArUJq0XQ7E/7lgUrPuL4BlX4fCIJ+4PJuNqK+pPwF7adDCWNLo4/d3GuMQm4WqgNrk gIlw== X-Gm-Message-State: AOJu0YzuNHGy3sMewVkbeCXJ8c/zCsd4q9fdWI14QQw0+4VYFby43CGo l07KWgQFMg6MnatXqomZyZqkCiZt5o3cT73vf5I= X-Google-Smtp-Source: AGHT+IERdw9jYA65AeSDb2KHKpJuXgzQlTIsNLOUX/DL5ZjhbGQmF3n4QiyOitzjtZblISW7wP80Xg== X-Received: by 2002:adf:e50e:0:b0:314:1ebc:6e19 with SMTP id j14-20020adfe50e000000b003141ebc6e19mr8153117wrm.64.1691499758316; Tue, 08 Aug 2023 06:02:38 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Julien Grall Subject: [PATCH v3 2/4] mm/pdx: Standardize region validation wrt pdx compression Date: Tue, 8 Aug 2023 14:02:18 +0100 Message-Id: <20230808130220.27891-3-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130220.27891-1-alejandro.vallejo@cloud.com> References: <20230808130220.27891-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Regions must be occasionally validated for pdx compression validity. That is, whether any of the machine addresses spanning the region have a bit set in the pdx "hole" (which is expected to always contain zeroes). There are a few such tests through the code, and they all check for different things. This patch replaces all such occurrences with a call to a centralized function that checks a region for validity. Signed-off-by: Alejandro Vallejo Reviewed-by: Julien Grall --- v3: * Pack variable declarations on top of the function (Jan) * Restrict variable scope by moving their declaration to the top of the loop in which they are used (Jan) --- xen/arch/x86/x86_64/mm.c | 6 ++++-- xen/common/efi/boot.c | 13 ++++++++++--- xen/common/pdx.c | 10 ++++++++-- xen/include/xen/pdx.h | 9 +++++++++ 4 files changed, 31 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c index 15b36e332d..d3f7c59638 100644 --- a/xen/arch/x86/x86_64/mm.c +++ b/xen/arch/x86/x86_64/mm.c @@ -1158,6 +1158,8 @@ static int transfer_pages_to_heap(struct mem_hotadd_info *info) static int mem_hotadd_check(unsigned long spfn, unsigned long epfn) { unsigned long s, e, length, sidx, eidx; + paddr_t mem_base = pfn_to_paddr(spfn); + unsigned long mem_npages = epfn - spfn; if ( (spfn >= epfn) ) return 0; @@ -1168,7 +1170,7 @@ static int mem_hotadd_check(unsigned long spfn, unsigned long epfn) if ( (spfn | epfn) & ((1UL << PAGETABLE_ORDER) - 1) ) return 0; - if ( (spfn | epfn) & pfn_hole_mask ) + if ( !pdx_is_region_compressible(mem_base, mem_npages) ) return 0; /* Make sure the new range is not present now */ @@ -1207,7 +1209,7 @@ static int mem_hotadd_check(unsigned long spfn, unsigned long epfn) length += (e - s) * sizeof(struct page_info); - if ((length >> PAGE_SHIFT) > (epfn - spfn)) + if ((length >> PAGE_SHIFT) > mem_npages) return 0; return 1; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 79a654af69..be4e3a0259 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #if EFI_PAGE_SIZE != PAGE_SIZE # error Cannot use xen/pfn.h here! @@ -1645,9 +1646,11 @@ static __init void copy_mapping(unsigned long mfn, unsigned long end, static bool __init cf_check ram_range_valid(unsigned long smfn, unsigned long emfn) { + paddr_t ram_base = pfn_to_paddr(smfn); + unsigned long ram_npages = emfn - smfn; unsigned long sz = pfn_to_pdx(emfn - 1) / PDX_GROUP_COUNT + 1; - return !(smfn & pfn_hole_mask) && + return pdx_is_region_compressible(ram_base, ram_npages) && find_next_bit(pdx_group_valid, sz, pfn_to_pdx(smfn) / PDX_GROUP_COUNT) < sz; } @@ -1681,6 +1684,8 @@ void __init efi_init_memory(void) u64 len = desc->NumberOfPages << EFI_PAGE_SHIFT; unsigned long smfn, emfn; unsigned int prot = PAGE_HYPERVISOR_RWX; + paddr_t mem_base; + unsigned long mem_npages; printk(XENLOG_INFO " %013" PRIx64 "-%013" PRIx64 " type=%u attr=%016" PRIx64 "\n", @@ -1732,6 +1737,9 @@ void __init efi_init_memory(void) smfn = PFN_DOWN(desc->PhysicalStart); emfn = PFN_UP(desc->PhysicalStart + len); + mem_base = pfn_to_paddr(smfn); + mem_npages = emfn - smfn; + if ( desc->Attribute & EFI_MEMORY_WB ) prot |= _PAGE_WB; else if ( desc->Attribute & EFI_MEMORY_WT ) @@ -1759,8 +1767,7 @@ void __init efi_init_memory(void) prot |= _PAGE_NX; if ( pfn_to_pdx(emfn - 1) < (DIRECTMAP_SIZE >> PAGE_SHIFT) && - !(smfn & pfn_hole_mask) && - !((smfn ^ (emfn - 1)) & ~pfn_pdx_bottom_mask) ) + pdx_is_region_compressible(mem_base, mem_npages)) { if ( (unsigned long)mfn_to_virt(emfn - 1) >= HYPERVISOR_VIRT_END ) prot &= ~_PAGE_GLOBAL; diff --git a/xen/common/pdx.c b/xen/common/pdx.c index 99d4a90a50..3c88ceeb9c 100644 --- a/xen/common/pdx.c +++ b/xen/common/pdx.c @@ -88,7 +88,7 @@ bool __mfn_valid(unsigned long mfn) } /* Sets all bits from the most-significant 1-bit down to the LSB */ -static uint64_t __init fill_mask(uint64_t mask) +static uint64_t fill_mask(uint64_t mask) { while (mask & (mask + 1)) mask |= mask + 1; @@ -96,6 +96,12 @@ static uint64_t __init fill_mask(uint64_t mask) return mask; } +bool pdx_is_region_compressible(paddr_t base, unsigned long npages) +{ + return !(paddr_to_pfn(base) & pfn_hole_mask) && + !(pdx_region_mask(base, npages * PAGE_SIZE) & ~ma_va_bottom_mask); +} + /* We don't want to compress the low MAX_ORDER bits of the addresses. */ uint64_t __init pdx_init_mask(uint64_t base_addr) { @@ -103,7 +109,7 @@ uint64_t __init pdx_init_mask(uint64_t base_addr) (uint64_t)1 << (MAX_ORDER + PAGE_SHIFT)) - 1); } -uint64_t __init pdx_region_mask(uint64_t base, uint64_t len) +uint64_t pdx_region_mask(uint64_t base, uint64_t len) { /* * We say a bit "moves" in a range if there exist 2 addresses in that diff --git a/xen/include/xen/pdx.h b/xen/include/xen/pdx.h index 8f29598230..5674506f3a 100644 --- a/xen/include/xen/pdx.h +++ b/xen/include/xen/pdx.h @@ -79,6 +79,15 @@ extern unsigned long pfn_top_mask, ma_top_mask; (sizeof(*frame_table) & -sizeof(*frame_table))) extern unsigned long pdx_group_valid[]; +/** + * Validate a region's compatibility with the current compression runtime + * + * @param base Base address of the region + * @param npages Number of PAGE_SIZE-sized pages in the region + * @return True iff the region can be used with the current compression + */ +bool pdx_is_region_compressible(paddr_t base, unsigned long npages); + /** * Calculates a mask covering "moving" bits of all addresses of a region * -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:02:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579785.907929 (Exim 4.92) (envelope-from ) id 1qTMMF-00046m-MQ; Tue, 08 Aug 2023 13:02:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579785.907929; Tue, 08 Aug 2023 13:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMF-000469-HI; Tue, 08 Aug 2023 13:02:43 +0000 Received: by outflank-mailman (input) for mailman id 579785; Tue, 08 Aug 2023 13:02:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMME-0003uf-8Q for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:02:42 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id daa46d75-35eb-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:02:40 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3fe4b95c371so23264865e9.1 for ; Tue, 08 Aug 2023 06:02:40 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b003144b50034esm13567072wrs.110.2023.08.08.06.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:02:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daa46d75-35eb-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499759; x=1692104559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qw5ydlPzexz1P1bvK3hrQOjcFc77zxXZqKmERgYMjHk=; b=RgIsn4uEOt+KjgK2T9EVYtD4z2FBCAK55OG2bEpL7qWYK1VEylPO8+JC7Uimb+w/h5 c/pOGK8spbPUZmHBk+F7aBBQwcoxu5wTMqYgbk/rwbWOnrRaO7RCUyUUASKpmLfFOFLi +olC7T2HgdoQgeDjsW50FW/0s6DTYxVFf2Iqo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499759; x=1692104559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qw5ydlPzexz1P1bvK3hrQOjcFc77zxXZqKmERgYMjHk=; b=ifh0C4ftYhrYMhDioCqYR24WszCLUuquqfirScwa6I655qyZbzfchpX1ckCdtKep2Y FLK0sLuxJ7G7TJeuPXheDfl6pPo4MQ1lDv6/oOjFzPDOtlWPsEe19EmfgHs/WwxvhRAl 39K1Zi6Lla+8O7VKwqyZxk3VFrMlhUsfB4Jk6Y9j8PbhgvoUjE1RP4s5wYbiaW9Upwd6 IuFmoWN2fCK2+wIUethvCjrAWtkFY2cwOiroWb6R7AvFUtq4NHD/+TfnywgBYB+2eYD6 QFpKwEA/nJMpqsbrIw8tgHRDA7lYXg7m8P80I95HO9bZBJ5TrB5QyBFx4IL4Ra5nENej MRBA== X-Gm-Message-State: AOJu0Yy2/ZZMD7q5pV7NIeqlSBnMRvEtUC9T3S7o6wZYEBzVS+4y0RLa u3tX/u+iGfk2PTMf4s8snsOPyZ+H0N5a/O8M8F8= X-Google-Smtp-Source: AGHT+IG5t63tS6JnlI7jLQBy9wATzP5e8eansQp2xZQ2UfnvSwZDyJeO9dhLA0qeSeJUwSS4AguJmA== X-Received: by 2002:a05:600c:2212:b0:3fa:aeac:e978 with SMTP id z18-20020a05600c221200b003faaeace978mr8102633wml.0.1691499759057; Tue, 08 Aug 2023 06:02:39 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v3 3/4] pdx: Reorder pdx.[ch] Date: Tue, 8 Aug 2023 14:02:19 +0100 Message-Id: <20230808130220.27891-4-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130220.27891-1-alejandro.vallejo@cloud.com> References: <20230808130220.27891-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The next patch compiles out compression-related chunks, and it's helpful to have them grouped together beforehand. Signed-off-by: Alejandro Vallejo Reviewed-by: Julien Grall --- v3: * No changes --- xen/common/pdx.c | 58 +++++++++++++++++++++--------------------- xen/include/xen/pdx.h | 59 ++++++++++++++++++++++--------------------- 2 files changed, 59 insertions(+), 58 deletions(-) diff --git a/xen/common/pdx.c b/xen/common/pdx.c index 3c88ceeb9c..d3d38965bd 100644 --- a/xen/common/pdx.c +++ b/xen/common/pdx.c @@ -20,6 +20,35 @@ #include #include +/** + * Maximum (non-inclusive) usable pdx. Must be + * modifiable after init due to memory hotplug + */ +unsigned long __read_mostly max_pdx; + +unsigned long __read_mostly pdx_group_valid[BITS_TO_LONGS( + (FRAMETABLE_NR + PDX_GROUP_COUNT - 1) / PDX_GROUP_COUNT)] = { [0] = 1 }; + +bool __mfn_valid(unsigned long mfn) +{ + if ( unlikely(evaluate_nospec(mfn >= max_page)) ) + return false; + return likely(!(mfn & pfn_hole_mask)) && + likely(test_bit(pfn_to_pdx(mfn) / PDX_GROUP_COUNT, + pdx_group_valid)); +} + +void set_pdx_range(unsigned long smfn, unsigned long emfn) +{ + unsigned long idx, eidx; + + idx = pfn_to_pdx(smfn) / PDX_GROUP_COUNT; + eidx = (pfn_to_pdx(emfn - 1) + PDX_GROUP_COUNT) / PDX_GROUP_COUNT; + + for ( ; idx < eidx; ++idx ) + __set_bit(idx, pdx_group_valid); +} + /* * Diagram to make sense of the following variables. The masks and shifts * are done on mfn values in order to convert to/from pdx: @@ -47,12 +76,6 @@ * ones. */ -/** - * Maximum (non-inclusive) usable pdx. Must be - * modifiable after init due to memory hotplug - */ -unsigned long __read_mostly max_pdx; - /** Mask for the lower non-compressible bits of an mfn */ unsigned long __ro_after_init pfn_pdx_bottom_mask = ~0UL; @@ -75,18 +98,6 @@ unsigned long __ro_after_init pfn_hole_mask = 0; /** Number of bits of the "compressible" bit slice of an mfn */ unsigned int __ro_after_init pfn_pdx_hole_shift = 0; -unsigned long __read_mostly pdx_group_valid[BITS_TO_LONGS( - (FRAMETABLE_NR + PDX_GROUP_COUNT - 1) / PDX_GROUP_COUNT)] = { [0] = 1 }; - -bool __mfn_valid(unsigned long mfn) -{ - if ( unlikely(evaluate_nospec(mfn >= max_page)) ) - return false; - return likely(!(mfn & pfn_hole_mask)) && - likely(test_bit(pfn_to_pdx(mfn) / PDX_GROUP_COUNT, - pdx_group_valid)); -} - /* Sets all bits from the most-significant 1-bit down to the LSB */ static uint64_t fill_mask(uint64_t mask) { @@ -124,17 +135,6 @@ uint64_t pdx_region_mask(uint64_t base, uint64_t len) return fill_mask(base ^ (base + len - 1)); } -void set_pdx_range(unsigned long smfn, unsigned long emfn) -{ - unsigned long idx, eidx; - - idx = pfn_to_pdx(smfn) / PDX_GROUP_COUNT; - eidx = (pfn_to_pdx(emfn - 1) + PDX_GROUP_COUNT) / PDX_GROUP_COUNT; - - for ( ; idx < eidx; ++idx ) - __set_bit(idx, pdx_group_valid); -} - void __init pfn_pdx_hole_setup(unsigned long mask) { unsigned int i, j, bottom_shift = 0, hole_shift = 0; diff --git a/xen/include/xen/pdx.h b/xen/include/xen/pdx.h index 5674506f3a..b5367a33ca 100644 --- a/xen/include/xen/pdx.h +++ b/xen/include/xen/pdx.h @@ -70,15 +70,41 @@ #ifdef CONFIG_HAS_PDX extern unsigned long max_pdx; -extern unsigned long pfn_pdx_bottom_mask, ma_va_bottom_mask; -extern unsigned int pfn_pdx_hole_shift; -extern unsigned long pfn_hole_mask; -extern unsigned long pfn_top_mask, ma_top_mask; #define PDX_GROUP_COUNT ((1 << PDX_GROUP_SHIFT) / \ (sizeof(*frame_table) & -sizeof(*frame_table))) extern unsigned long pdx_group_valid[]; +/** + * Mark [smfn, emfn) as allocatable in the frame table + * + * @param smfn Start mfn + * @param emfn End mfn + */ +void set_pdx_range(unsigned long smfn, unsigned long emfn); + +/** + * Invoked to determine if an mfn has an associated valid frame table entry + * + * In order for it to be legal it must pass bounds, grouping and + * compression sanity checks. + * + * @param mfn To-be-checked mfn + * @return True iff all checks pass + */ +bool __mfn_valid(unsigned long mfn); + +#define page_to_pdx(pg) ((pg) - frame_table) +#define pdx_to_page(pdx) gcc11_wrap(frame_table + (pdx)) + +#define mfn_to_pdx(mfn) pfn_to_pdx(mfn_x(mfn)) +#define pdx_to_mfn(pdx) _mfn(pdx_to_pfn(pdx)) + +extern unsigned long pfn_pdx_bottom_mask, ma_va_bottom_mask; +extern unsigned int pfn_pdx_hole_shift; +extern unsigned long pfn_hole_mask; +extern unsigned long pfn_top_mask, ma_top_mask; + /** * Validate a region's compatibility with the current compression runtime * @@ -120,28 +146,6 @@ uint64_t pdx_region_mask(uint64_t base, uint64_t len); */ uint64_t pdx_init_mask(uint64_t base_addr); -/** - * Mark [smfn, emfn) as accesible in the frame table - * - * @param smfn Start mfn - * @param emfn End mfn - */ -void set_pdx_range(unsigned long smfn, unsigned long emfn); - -#define page_to_pdx(pg) ((pg) - frame_table) -#define pdx_to_page(pdx) gcc11_wrap(frame_table + (pdx)) - -/** - * Invoked to determine if an mfn has an associated valid frame table entry - * - * In order for it to be legal it must pass bounds, grouping and - * compression sanity checks. - * - * @param mfn To-be-checked mfn - * @return True iff all checks pass - */ -bool __mfn_valid(unsigned long mfn); - /** * Map pfn to its corresponding pdx * @@ -166,9 +170,6 @@ static inline unsigned long pdx_to_pfn(unsigned long pdx) ((pdx << pfn_pdx_hole_shift) & pfn_top_mask); } -#define mfn_to_pdx(mfn) pfn_to_pdx(mfn_x(mfn)) -#define pdx_to_mfn(pdx) _mfn(pdx_to_pfn(pdx)) - /** * Computes the offset into the direct map of an maddr * -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:02:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579781.907895 (Exim 4.92) (envelope-from ) id 1qTMMC-0003Ki-LJ; Tue, 08 Aug 2023 13:02:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579781.907895; Tue, 08 Aug 2023 13:02:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMC-0003Kb-Hc; Tue, 08 Aug 2023 13:02:40 +0000 Received: by outflank-mailman (input) for mailman id 579781; Tue, 08 Aug 2023 13:02:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMMB-0003KL-Iy for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:02:39 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d91e1864-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:02:37 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3159d5e409dso4036857f8f.0 for ; Tue, 08 Aug 2023 06:02:37 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id y15-20020a5d4acf000000b003144b50034esm13567072wrs.110.2023.08.08.06.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:02:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d91e1864-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499756; x=1692104556; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Ec8TrED3aRx0vHHIlwtP34Rk7pkdy6yKzk82FFTpTU=; b=A4j17B4b2jzh//qNnMqga7eCrHZs2Jw1UYsnbiWt3xd8XJcyYPydS0t9Qeu8vxa/qh czKVfN4U67bQfk6yCDBhLlocAoOMmyMcBY6S3N/l6gaXuQd63nr7yYRYrf6JIpHPE9Os XjvlZwT+EReBjnyQriH/3CfB31O0KxIfrLskU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499756; x=1692104556; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5Ec8TrED3aRx0vHHIlwtP34Rk7pkdy6yKzk82FFTpTU=; b=BbKmf1oAFYN4IkTpynm4XYNprmjzaei1srDHORL2S6yU0Lfv8f9yEJC62NuIrPci7l nzCTvgu/F4epy5EXYzEEXGVhJOD9wR9nSwgR0PDjeYd0gLVQ4v1d4PCTKXka+bLw7N2y YoHeu5iZ0IlbFIZ58I0MgjFgWMzYCa+4mGBtjgGwrchrdmUx4bc+HX9LitnoQ/NYSf4c D4J2KFyBUzhrrRCakLxN9LeJ518lJ35+CXVmVWQTZTxVve6w537PzdgwhNaB0QG3wUbc Lp6SryV+tAC5Rw0C3OZ09Njrn6Zr3Fi01Kfs1i2qgFbZO7by9CNV9dFq0YvcxU2wOGmt 8okQ== X-Gm-Message-State: AOJu0YyIuCK/KAP9uOKvh0bmvTi9Mjku+sxlJtiXlIbmz+QtLiWjm7/A kZfQqz6IUEAlHpHOB2Q3yDgK84sDamxtxxvTOLI= X-Google-Smtp-Source: AGHT+IGuOT4NkLxsFpYqnMTa9TMufD+Y5HiN4gkF8fGCGqZ7rhUYxvJWxrng6ui1k+L/XEgE0fvhqQ== X-Received: by 2002:adf:edcc:0:b0:314:314e:fdda with SMTP id v12-20020adfedcc000000b00314314efddamr8294825wro.23.1691499756436; Tue, 08 Aug 2023 06:02:36 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 0/4] Make PDX compression optional Date: Tue, 8 Aug 2023 14:02:16 +0100 Message-Id: <20230808130220.27891-1-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently there's a CONFIG_HAS_PDX Kconfig option, but it's impossible to disable it because the whole codebase performs unconditional compression/decompression operations on addresses. This has the unfortunate side effect that systems without a need for compression still have to pay the performance impact of juggling bits on every pfn<->pdx conversion (this requires reading several global variables). This series attempts to: * Leave the state of pdx and pdx compression documented * Factor out compression so it _can_ be removed through Kconfig * Make it so compression is disabled on x86 and enabled on both Aarch32 and Aarch64 by default. Series summary: Patch 1 Moves hard-coded compression-related logic to helper functions Patch 2 Refactors all instances of regions being validated for pdx compression conformance so it's done through a helper Patch 3 Non-functional reorder in order to simplify the patch 8 diff Patch 4 Adds new Kconfig option to compile out PDX compression and removes the old CONFIG_HAS_PDX, as it was non removable Already committed: v1/patch 1 documents the current general understanding of the pdx concept and pdx compression in particular v1/patch 3 Marks the pdx compression globals as ro_after_init v2/patch 1 Documents the differences between arm32 and arm64 directmaps Alejandro Vallejo (4): mm: Factor out the pdx compression logic in ma/va converters mm/pdx: Standardize region validation wrt pdx compression pdx: Reorder pdx.[ch] pdx: Add CONFIG_PDX_COMPRESSION as a common Kconfig option xen/arch/arm/Kconfig | 1 - xen/arch/arm/include/asm/mm.h | 3 +- xen/arch/x86/Kconfig | 1 - xen/arch/x86/domain.c | 19 ++-- xen/arch/x86/include/asm/x86_64/page.h | 28 +++--- xen/arch/x86/x86_64/mm.c | 6 +- xen/common/Kconfig | 13 ++- xen/common/Makefile | 2 +- xen/common/efi/boot.c | 13 ++- xen/common/pdx.c | 76 +++++++++------ xen/include/xen/pdx.h | 127 +++++++++++++++++++------ 11 files changed, 193 insertions(+), 96 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:03:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:03:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579802.907944 (Exim 4.92) (envelope-from ) id 1qTMNB-0005vn-3C; Tue, 08 Aug 2023 13:03:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579802.907944; Tue, 08 Aug 2023 13:03:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMNB-0005vg-0e; Tue, 08 Aug 2023 13:03:41 +0000 Received: by outflank-mailman (input) for mailman id 579802; Tue, 08 Aug 2023 13:03:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMN9-0003KL-NR for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:03:39 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe04cde5-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:03:39 +0200 (CEST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-317798b359aso4301263f8f.1 for ; Tue, 08 Aug 2023 06:03:39 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id t6-20020adfe446000000b003179b3fd837sm13699587wrm.33.2023.08.08.06.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:03:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe04cde5-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499818; x=1692104618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CLQCJAr0rC6dxrW2X+lLr/OB58MmuMcxotnvqWKYPbM=; b=UGPW1p2RXholxwOATeLDNTjmIUchwn+XV6jwctj/fYgqKK2cprRWTt7kO8lOCq50Kp JptcMxuQEndlNW29pSLDdyMxWfWBi5kN1IO51HdLDsnCvjQko6bmZ3RjJEBfvfE4KwDm k8nuNQpdXTr8ju1inovh6r4pp7HOp+O4TxS0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499818; x=1692104618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CLQCJAr0rC6dxrW2X+lLr/OB58MmuMcxotnvqWKYPbM=; b=CYEZwQi3qXV66D6zEoSorq1VSc1dgCMr36N80wUuobhnjDlMIaHtP0dwvPxGd1DMTP wXovoQPk3NY+pOY+EHYJhCh41HPw+TGjCfN/zezsBbvDzJC4mAGEMLRMLIscJcEDBqjY wpykUNU9kfvD/2fngIXQTAUMVdlXa8UkoO/O3hq+dmAohYxRBwhOubu63tlD78OR0zYW Q+kUWaF4bSGPPEs1/7ZjqeJDSuypwcHyYDkZGNEWrA7565sWbDkmW6WR4p5oHOEa9SHE +5W1rbYxnuDcRfyuNDfq6vYJJLzvFoJSQ6q71AAQKBYOV9sPyi6MOUCGxEmYJcZF46GI cwJg== X-Gm-Message-State: AOJu0YzmH1vA+BhF3rA8j7hQ4NIQ3HrVNaFp++1hFdZn2IFxK0rVC+/p L6U/McBdY+KJA/rzk5vmGIigVjFC+UxNjMusSoU= X-Google-Smtp-Source: AGHT+IFFliAuXIbhDdB6fd04YO90HpZVHVdq6h+VWGjhQ8tReKodm6RNfQoaKVgmVhWpbeJuEFtMdw== X-Received: by 2002:adf:ce90:0:b0:314:3b02:a8a8 with SMTP id r16-20020adfce90000000b003143b02a8a8mr7914781wrn.55.1691499818483; Tue, 08 Aug 2023 06:03:38 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v7 0/3] Prevent attempting updates known to fail Date: Tue, 8 Aug 2023 14:03:28 +0100 Message-Id: <20230808130331.27995-1-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Under certain conditions a CPU may not be able to perform microcode updates even if hardware exists to that effect. In particular: * If Xen runs under certain hypervisors they won't allow microcode updates, and will signal this fact by reporting a microcode revision of -1. * If the DIS_MCU_LOAD bit is set, which is expected in some baremetal clouds where the owner may not trust the tenant, then the CPU is not capable of loading new microcode. This series adds logic so that in both of these cases we don't needlessly attempt updates that are not going to succeed. Patch summary: Patch 1 Ignores microcode facilities when the current microcode revision is -1 Patch 2 Moves the MSR_ARCH_CAPS read in tsx_init() to early_cpu_init() and early_microcode_init() Patch 3 Adds the logic to detect microcode updates being disabled on Intel. Alejandro Vallejo (3): x86/microcode: Ignore microcode loading interface for revision = -1 x86: Read MSR_ARCH_CAPS immediately after early_microcode_init() x86/microcode: Disable microcode update handler if DIS_MCU_UPDATE is set xen/arch/x86/cpu/common.c | 20 ++++++++++---- xen/arch/x86/cpu/microcode/core.c | 38 ++++++++++++++++++++++++--- xen/arch/x86/cpu/microcode/intel.c | 13 +++++++++ xen/arch/x86/cpu/microcode/private.h | 7 +++++ xen/arch/x86/include/asm/cpufeature.h | 1 + xen/arch/x86/include/asm/msr-index.h | 5 ++++ xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/setup.c | 2 +- xen/arch/x86/tsx.c | 16 +++-------- 9 files changed, 81 insertions(+), 23 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:03:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:03:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579803.907955 (Exim 4.92) (envelope-from ) id 1qTMNC-0006Bk-D1; Tue, 08 Aug 2023 13:03:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579803.907955; Tue, 08 Aug 2023 13:03:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMNC-0006BY-8g; Tue, 08 Aug 2023 13:03:42 +0000 Received: by outflank-mailman (input) for mailman id 579803; Tue, 08 Aug 2023 13:03:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMNB-0003KL-EK for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:03:41 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff15ba11-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:03:41 +0200 (CEST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3179ed1dfbbso4856344f8f.1 for ; Tue, 08 Aug 2023 06:03:40 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id t6-20020adfe446000000b003179b3fd837sm13699587wrm.33.2023.08.08.06.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:03:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff15ba11-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499820; x=1692104620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gaUnmMyQzDhGHHuFVEoa7z0wlHrRhTGB1FTCEPFAUdE=; b=gZ8xL6bwBxFzJByOAln36wXNPZouGdnItFdcjErxU7T8URfC6pdPKuOWRETdwBl7SX 5dSGLgtKA4Obpgvqi7CUGW57RKP02v7ZzRT/wOOv4aQTclSm0PkvHpXWKVyDxSpJpiYU dDU6fEF49KXKEvE9QkgxJxf6QzHlacyMGbE/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499820; x=1692104620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gaUnmMyQzDhGHHuFVEoa7z0wlHrRhTGB1FTCEPFAUdE=; b=iBDpFvn8nDlyrxxZ0tM0P5F/4pTZZHJ+NCzGv7SsqDOTKMoxWEy/qF5KJGwJxhPFNW WWS9upVmpwAwLo6rhi1ixG0IaUbHuRYRbxsn+mMtsJ1Do2dq4079181fyAz+UpoATBKa HlVPJIh3OvkTWzkH6UD1CdUOQQPa0WBh2msdm2UmBANnlcD0MVGMBFBJ4zZO+SPe9hTp iwEtMegJ6e6SyEULW0qmvVZOkYmGkADLGQ87KGRxz3fh5l0eC/VAGEyJ9rr7WR7dX5We Y7VlCHvj4Y+4NtQY42Dt0fgbNbjY6gPJEPn9q6AMweRDcYiKL6DUKzLXapfF7VF4K2k5 jw/A== X-Gm-Message-State: AOJu0YyIRuV5Ay43AxiV9nPOd5SpfTKWTZ5lhHQOLbamYQmq70I4v5Xu uQ379hR5NHrXZ+hqS3CA/2MIEJAaJzyL67sPsC4= X-Google-Smtp-Source: AGHT+IEYDGSkpMaqWcQxT/ufTuQ3pPRFdEjSmZM59zxeeh9HwU47uTo5ykj5hPRSkOhQ+CiG94Ay4Q== X-Received: by 2002:a5d:5346:0:b0:317:5a9b:fcec with SMTP id t6-20020a5d5346000000b003175a9bfcecmr9185739wrv.14.1691499819257; Tue, 08 Aug 2023 06:03:39 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1 Date: Tue, 8 Aug 2023 14:03:29 +0100 Message-Id: <20230808130331.27995-2-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130331.27995-1-alejandro.vallejo@cloud.com> References: <20230808130331.27995-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some hypervisors report ~0 as the microcode revision to mean "don't issue microcode updates". Ignore the microcode loading interface in that case. Signed-off-by: Alejandro Vallejo --- v7: * Removed R-by tag. It wasn't meant to be there! * Fix wrong substring inserted in printk statement * Returned the printk severity to WARNING I still think both this new print and the previous one in the function should have severity INFO instead, but I'm not bothered either way and they should both have the same severity because they highlight equivalent events. --- xen/arch/x86/cpu/microcode/core.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index bec8b55db2..205bb52201 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long *module_map, return -ENODEV; } - microcode_grab_module(module_map, mbi); - ucode_ops.collect_cpu_info(); + /* + * Some hypervisors deliberately report a microcode revision of -1 to + * mean that they will not accept microcode updates. We take the hint + * and ignore the microcode interface in that case. + */ + if ( this_cpu(cpu_sig).rev == ~0 ) + { + printk(XENLOG_WARNING "Microcode loading disabled due to: %s", + "rev = ~0"); + ucode_ops.apply_microcode = NULL; + return -ENODEV; + } + + microcode_grab_module(module_map, mbi); + if ( ucode_mod.mod_end || ucode_blob.size ) rc = early_microcode_update_cpu(); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:03:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:03:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579804.907965 (Exim 4.92) (envelope-from ) id 1qTMND-0006Ru-La; Tue, 08 Aug 2023 13:03:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579804.907965; Tue, 08 Aug 2023 13:03:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMND-0006Rh-Gk; Tue, 08 Aug 2023 13:03:43 +0000 Received: by outflank-mailman (input) for mailman id 579804; Tue, 08 Aug 2023 13:03:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMNB-0003KL-Nm for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:03:41 +0000 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [2a00:1450:4864:20::42c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fefdcd62-35eb-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:03:40 +0200 (CEST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3178dd81ac4so4679622f8f.3 for ; Tue, 08 Aug 2023 06:03:40 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id t6-20020adfe446000000b003179b3fd837sm13699587wrm.33.2023.08.08.06.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:03:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fefdcd62-35eb-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499820; x=1692104620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Drl1WoVQFYKt7SnkepxymBZ1cgaNy4U6Y8pES3y0IG0=; b=IgEyeP56E5Q5RHrY3Dw7IREGaBWkLvdLiOUD+NFHoIoIa+XiWKYBuFbNDl4fSo0l5g Em0hETb2ZyfPH89U+9muDE6UyGevxcdsjlQmSxWlIeZlHDcNXGbOACq3mUMCJOj+lKkm uFfJGFKuRAy2dpzK65UCj9VPkY5Seea9LIH1Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499820; x=1692104620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Drl1WoVQFYKt7SnkepxymBZ1cgaNy4U6Y8pES3y0IG0=; b=OQt5+Tk+Tghtj9WmITyQeevg3bQ5r3NAUB9ROU1lfIJjOwyvIhRcpbmSqdNxlJbsOA MA3Dj5A1J1L6/5m5Mr4q9Gem8ewJ/XahZRh1+n6rXaf9a7fdVPvAnttGuqGwXm0LViAq p3QfR/RgcFP6Tdc+2RHw/BRuXvVK9hjs3l37BDI6GGChU1FOZgdUjQ5fQfmApe45oXx8 gPA67mh7Y920SX3xBNkCawoDbSBbK4YiMcpVioTj5HyrBbEDPEExgLq6Y+4cgp0688ow 8E/Uz1TvQp6+51925/4zBYmeUOkvjrHnVwwVPBl0aNq8P3ScUOTwJk4scXkkat9e5F5N xvbg== X-Gm-Message-State: AOJu0YxCevU07DIbH0xcotjRpCL/tqfkM4QLjj9w+oSTbOedu0EFRzki VZMCnzKFnsDfDNNu3nfwr0cgi65hUT8Ep2nyZc8= X-Google-Smtp-Source: AGHT+IFsHmqMp2toFeDTaYonJi4Mxyq93TXJf/Cy5qj5i0N+qKCTpHEpN4U5GZ8C7IBGcFPuXqszKQ== X-Received: by 2002:adf:fd8b:0:b0:317:cddf:1c71 with SMTP id d11-20020adffd8b000000b00317cddf1c71mr9773543wrr.23.1691499820143; Tue, 08 Aug 2023 06:03:40 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v7 2/3] x86: Read MSR_ARCH_CAPS immediately after early_microcode_init() Date: Tue, 8 Aug 2023 14:03:30 +0100 Message-Id: <20230808130331.27995-3-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130331.27995-1-alejandro.vallejo@cloud.com> References: <20230808130331.27995-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move MSR_ARCH_CAPS read code from tsx_init() to early_cpu_init(). Because microcode updates might make them that MSR to appear/have different values we also must reload it after a microcode update in early_microcode_init(). Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich --- v7: * No change --- xen/arch/x86/cpu/common.c | 20 +++++++++++++++----- xen/arch/x86/cpu/microcode/core.c | 9 +++++++++ xen/arch/x86/include/asm/setup.h | 2 +- xen/arch/x86/setup.c | 2 +- xen/arch/x86/tsx.c | 16 ++++------------ 5 files changed, 30 insertions(+), 19 deletions(-) diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c index 6fada384a1..3fd4fd0654 100644 --- a/xen/arch/x86/cpu/common.c +++ b/xen/arch/x86/cpu/common.c @@ -299,7 +299,7 @@ static inline u32 phys_pkg_id(u32 cpuid_apic, int index_msb) WARNING: this function is only called on the BP. Don't add code here that is supposed to run on all CPUs. */ -void __init early_cpu_init(void) +void __init early_cpu_init(bool verbose) { struct cpuinfo_x86 *c = &boot_cpu_data; u32 eax, ebx, ecx, edx; @@ -320,6 +320,8 @@ void __init early_cpu_init(void) case X86_VENDOR_SHANGHAI: this_cpu = &shanghai_cpu_dev; break; case X86_VENDOR_HYGON: this_cpu = &hygon_cpu_dev; break; default: + if (!verbose) + break; printk(XENLOG_ERR "Unrecognised or unsupported CPU vendor '%.12s'\n", c->x86_vendor_id); @@ -336,10 +338,13 @@ void __init early_cpu_init(void) c->x86_capability[FEATURESET_1d] = edx; c->x86_capability[FEATURESET_1c] = ecx; - printk(XENLOG_INFO - "CPU Vendor: %s, Family %u (%#x), Model %u (%#x), Stepping %u (raw %08x)\n", - x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, c->x86, - c->x86_model, c->x86_model, c->x86_mask, eax); + if (verbose) + printk(XENLOG_INFO + "CPU Vendor: %s, Family %u (%#x), " + "Model %u (%#x), Stepping %u (raw %08x)\n", + x86_cpuid_vendor_to_str(c->x86_vendor), c->x86, + c->x86, c->x86_model, c->x86_model, c->x86_mask, + eax); if (c->cpuid_level >= 7) { uint32_t max_subleaf; @@ -348,6 +353,11 @@ void __init early_cpu_init(void) &c->x86_capability[FEATURESET_7c0], &c->x86_capability[FEATURESET_7d0]); + if (test_bit(X86_FEATURE_ARCH_CAPS, c->x86_capability)) + rdmsr(MSR_ARCH_CAPABILITIES, + c->x86_capability[FEATURESET_m10Al], + c->x86_capability[FEATURESET_m10Ah]); + if (max_subleaf >= 1) cpuid_count(7, 1, &eax, &ebx, &ecx, &c->x86_capability[FEATURESET_7d1]); diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 205bb52201..273840fbcf 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -887,5 +887,14 @@ int __init early_microcode_init(unsigned long *module_map, if ( ucode_mod.mod_end || ucode_blob.size ) rc = early_microcode_update_cpu(); + /* + * Some CPUID leaves and MSRs are only present after microcode updates + * on some processors. We take the chance here to make sure what little + * state we have already probed is re-probed in order to ensure we do + * not use stale values. tsx_init() in particular needs to have up to + * date MSR_ARCH_CAPS. + */ + early_cpu_init(false); + return rc; } diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 51fce66607..dad8b3e605 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -15,7 +15,7 @@ extern uint64_t boot_tsc_stamp; extern void *stack_start; -void early_cpu_init(void); +void early_cpu_init(bool verbose); void early_time_init(void); void set_nr_cpu_ids(unsigned int max_cpus); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2dbe9857aa..12cb28e969 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1211,7 +1211,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) panic("Bootloader provided no memory information\n"); /* This must come before e820 code because it sets paddr_bits. */ - early_cpu_init(); + early_cpu_init(true); /* Choose shadow stack early, to set infrastructure up appropriately. */ if ( !boot_cpu_has(X86_FEATURE_CET_SS) ) diff --git a/xen/arch/x86/tsx.c b/xen/arch/x86/tsx.c index 80c6f4cedd..50d8059f23 100644 --- a/xen/arch/x86/tsx.c +++ b/xen/arch/x86/tsx.c @@ -39,9 +39,10 @@ void tsx_init(void) static bool __read_mostly once; /* - * This function is first called between microcode being loaded, and CPUID - * being scanned generally. Read into boot_cpu_data.x86_capability[] for - * the cpu_has_* bits we care about using here. + * This function is first called between microcode being loaded, and + * CPUID being scanned generally. early_cpu_init() has already prepared + * the feature bits needed here. And early_microcode_init() has ensured + * they are not stale after the microcode update. */ if ( unlikely(!once) ) { @@ -49,15 +50,6 @@ void tsx_init(void) once = true; - if ( boot_cpu_data.cpuid_level >= 7 ) - boot_cpu_data.x86_capability[FEATURESET_7d0] - = cpuid_count_edx(7, 0); - - if ( cpu_has_arch_caps ) - rdmsr(MSR_ARCH_CAPABILITIES, - boot_cpu_data.x86_capability[FEATURESET_m10Al], - boot_cpu_data.x86_capability[FEATURESET_m10Ah]); - has_rtm_always_abort = cpu_has_rtm_always_abort; if ( cpu_has_tsx_ctrl && cpu_has_srbds_ctrl ) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:07:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:07:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579822.907975 (Exim 4.92) (envelope-from ) id 1qTMQo-0007wx-Dl; Tue, 08 Aug 2023 13:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579822.907975; Tue, 08 Aug 2023 13:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMQo-0007wq-Av; Tue, 08 Aug 2023 13:07:26 +0000 Received: by outflank-mailman (input) for mailman id 579822; Tue, 08 Aug 2023 13:07:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMND-0003uf-IT for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:03:43 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ffa01cc4-35eb-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:03:41 +0200 (CEST) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-317e427488aso2043307f8f.1 for ; Tue, 08 Aug 2023 06:03:41 -0700 (PDT) Received: from localhost.localdomain (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id t6-20020adfe446000000b003179b3fd837sm13699587wrm.33.2023.08.08.06.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:03:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffa01cc4-35eb-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691499821; x=1692104621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kvlCcPtPAQFDMSDymQzg61qOJ0Yqizq1giWyB3+8O1o=; b=UhZDUQUqIzVHwHRdOITT+sEaVR91EiAnNxDHC7GkBAUt7ayneL22IhlskttvQoTrVK R91w0dOcAe5vT6mLDvIuVcKyffIkGmrZhfZnO2yvkeBvvuBg455OU4CBSM7eqQYwT6ZN 4b5vhe9218fy2NjXrvdq/iCtHgnWp19jQIZXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691499821; x=1692104621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kvlCcPtPAQFDMSDymQzg61qOJ0Yqizq1giWyB3+8O1o=; b=MXIdOWkC3s9GMvPFG9Rs3EvffDwgeD+fKXdaffi95lFfK+Y3gBZibL6/N6pP5MGnCz yg8vJy1F7f+CyrvwoaE4ZZQsKrsLJPzfgCRgMHG8dAh/VUNwrwRCBHNRt/Lhy7iV6F/v AeppuZkVGhRWe9Ht1rX87+i79Vkg9G9WMIKj0+4PPTFesHSCedC2IbryIZ5oQhaI6dzP pJQ1uoduRauRWOKHJFjgpEfAv2YyOwaUb+V5VQmFHxyciFd1Ela35dNvR6CxGQDBcQA9 8jNybWnwmx6lbeahV4/cQQUx8TdV7eg1h9aKcgbdKcseMTA4It5gYUH5qR5w/cMEFUVX gD/A== X-Gm-Message-State: AOJu0YyVy5LcHVaWLDLc+kGZdzINI/9TaXlhg8jV9aWAIsYif1wX+qPY wYupZgA2I/v1GbWLjJBGIjrD+YWgfe1AYYOF0Ds= X-Google-Smtp-Source: AGHT+IF5l6zl97y667NwMhYRhmd4uw5p8W7y4gDLDxyKSXlHz8gs2OM1dba3xSr7Z4fI5rjxLLfvnQ== X-Received: by 2002:a05:6000:c8:b0:313:fbd0:9813 with SMTP id q8-20020a05600000c800b00313fbd09813mr9103289wrx.28.1691499821207; Tue, 08 Aug 2023 06:03:41 -0700 (PDT) From: Alejandro Vallejo To: Xen-devel Cc: Alejandro Vallejo , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v7 3/3] x86/microcode: Disable microcode update handler if DIS_MCU_UPDATE is set Date: Tue, 8 Aug 2023 14:03:31 +0100 Message-Id: <20230808130331.27995-4-alejandro.vallejo@cloud.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230808130331.27995-1-alejandro.vallejo@cloud.com> References: <20230808130331.27995-1-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If IA32_MSR_MCU_CONTROL exists then it's possible a CPU may be unable to perform microcode updates. This is controlled through the DIS_MCU_LOAD bit and is intended for baremetal clouds where the owner may not trust the tenant to choose the microcode version in use. If we notice that bit being set then simply disable the "apply_microcode" handler so we can't even try to perform update (as it's known to be silently dropped). While at it, remove the Intel family check, as microcode loading is supported on every Intel64 CPU. Signed-off-by: Alejandro Vallejo Reviewed-by: Jan Beulich --- v7: * No change --- xen/arch/x86/cpu/microcode/core.c | 20 ++++++++++++++------ xen/arch/x86/cpu/microcode/intel.c | 13 +++++++++++++ xen/arch/x86/cpu/microcode/private.h | 7 +++++++ xen/arch/x86/include/asm/cpufeature.h | 1 + xen/arch/x86/include/asm/msr-index.h | 5 +++++ 5 files changed, 40 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 273840fbcf..ba9c9a8b1d 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -847,17 +847,21 @@ int __init early_microcode_init(unsigned long *module_map, { const struct cpuinfo_x86 *c = &boot_cpu_data; int rc = 0; + bool can_load = false; switch ( c->x86_vendor ) { case X86_VENDOR_AMD: if ( c->x86 >= 0x10 ) + { ucode_ops = amd_ucode_ops; + can_load = true; + } break; case X86_VENDOR_INTEL: - if ( c->x86 >= 6 ) - ucode_ops = intel_ucode_ops; + ucode_ops = intel_ucode_ops; + can_load = intel_can_load_microcode(); break; } @@ -871,13 +875,17 @@ int __init early_microcode_init(unsigned long *module_map, /* * Some hypervisors deliberately report a microcode revision of -1 to - * mean that they will not accept microcode updates. We take the hint - * and ignore the microcode interface in that case. + * mean that they will not accept microcode updates. + * + * It's also possible the hardware might have built-in support to disable + * updates and someone (e.g: a baremetal cloud provider) disabled them. + * + * Take the hint in either case and ignore the microcode interface. */ - if ( this_cpu(cpu_sig).rev == ~0 ) + if ( this_cpu(cpu_sig).rev == ~0 || !can_load ) { printk(XENLOG_WARNING "Microcode loading disabled due to: %s", - "rev = ~0"); + can_load ? "rev = ~0" : "HW toggle"); ucode_ops.apply_microcode = NULL; return -ENODEV; } diff --git a/xen/arch/x86/cpu/microcode/intel.c b/xen/arch/x86/cpu/microcode/intel.c index 8d4d6574aa..060c529a6e 100644 --- a/xen/arch/x86/cpu/microcode/intel.c +++ b/xen/arch/x86/cpu/microcode/intel.c @@ -385,6 +385,19 @@ static struct microcode_patch *cf_check cpu_request_microcode( return patch; } +bool __init intel_can_load_microcode(void) +{ + uint64_t mcu_ctrl; + + if ( !cpu_has_mcu_ctrl ) + return true; + + rdmsrl(MSR_MCU_CONTROL, mcu_ctrl); + + /* If DIS_MCU_LOAD is set applying microcode updates won't work */ + return !(mcu_ctrl & MCU_CONTROL_DIS_MCU_LOAD); +} + const struct microcode_ops __initconst_cf_clobber intel_ucode_ops = { .cpu_request_microcode = cpu_request_microcode, .collect_cpu_info = collect_cpu_info, diff --git a/xen/arch/x86/cpu/microcode/private.h b/xen/arch/x86/cpu/microcode/private.h index 626aeb4d08..d80787205a 100644 --- a/xen/arch/x86/cpu/microcode/private.h +++ b/xen/arch/x86/cpu/microcode/private.h @@ -60,6 +60,13 @@ struct microcode_ops { const struct microcode_patch *new, const struct microcode_patch *old); }; +/** + * Checks whether we can perform microcode updates on this Intel system + * + * @return True iff the microcode update facilities are enabled + */ +bool intel_can_load_microcode(void); + extern const struct microcode_ops amd_ucode_ops, intel_ucode_ops; #endif /* ASM_X86_MICROCODE_PRIVATE_H */ diff --git a/xen/arch/x86/include/asm/cpufeature.h b/xen/arch/x86/include/asm/cpufeature.h index 64e1dad225..5422baed27 100644 --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -193,6 +193,7 @@ static inline bool boot_cpu_has(unsigned int feat) #define cpu_has_if_pschange_mc_no boot_cpu_has(X86_FEATURE_IF_PSCHANGE_MC_NO) #define cpu_has_tsx_ctrl boot_cpu_has(X86_FEATURE_TSX_CTRL) #define cpu_has_taa_no boot_cpu_has(X86_FEATURE_TAA_NO) +#define cpu_has_mcu_ctrl boot_cpu_has(X86_FEATURE_MCU_CTRL) #define cpu_has_fb_clear boot_cpu_has(X86_FEATURE_FB_CLEAR) #define cpu_has_rrsba boot_cpu_has(X86_FEATURE_RRSBA) diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 4d41c171d2..cf8b2fa15c 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -165,6 +165,11 @@ #define PASID_PASID_MASK 0x000fffff #define PASID_VALID (_AC(1, ULL) << 31) +#define MSR_MCU_CONTROL 0x00001406 +#define MCU_CONTROL_LOCK (_AC(1, ULL) << 0) +#define MCU_CONTROL_DIS_MCU_LOAD (_AC(1, ULL) << 1) +#define MCU_CONTROL_EN_SMM_BYPASS (_AC(1, ULL) << 2) + #define MSR_UARCH_MISC_CTRL 0x00001b01 #define UARCH_CTRL_DOITM (_AC(1, ULL) << 0) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:08:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:08:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579836.907984 (Exim 4.92) (envelope-from ) id 1qTMRX-0008Um-N9; Tue, 08 Aug 2023 13:08:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579836.907984; Tue, 08 Aug 2023 13:08:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMRX-0008Uf-KI; Tue, 08 Aug 2023 13:08:11 +0000 Received: by outflank-mailman (input) for mailman id 579836; Tue, 08 Aug 2023 13:08:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMRW-0008UT-Js for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:08:10 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe13::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e837b5f-35ec-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:08:08 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB7643.eurprd04.prod.outlook.com (2603:10a6:10:203::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:08:06 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:08:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e837b5f-35ec-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+1EgTAUNRTc+bj2jM9VqjhwKR+ImArCw3XnHBM/aTbJlrkEKDoCKOXXAsYtiXxyqqRCqNR7zVNjc8cPXgtmWrw2IJkWfP9urGSqd4pAlJ5nXMd1Rv6qE1oqMmOy8ln2Ej3VZQmc64seDkCUEYyPsXIuoPsWZjdthxlpMRkopQPKvzALlnmWmRXxt4+sGv1ndXBTLu50zQ0DxlnL2tNB/xczfRE1yQpy2ZfLQZktLyMr/avFBvazOSjk1L/YEV+pduljaLy7s9dMEYmeeH5kK+FIgMV++N+Smseg/Xyt3zUXu821uCjnHTyZtxQh8WhYHIQwNMmUKvuVuR8DTakgpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0t1G/E/XXCvKHnnjq9IYybPQRG3YkpdsFkUeUcddnQ8=; b=OTKsWTn1i2iYvsrKsfLrW0Dyyo1jx5KApI/9QJ929s6cJCGRt2UqvEvHUQIAqq7uRuK5hTb7dhLE5RhbwlXqrSph0ueSPri7U3QD40HT3DM5ErrUD25oq+VEc/zk1IysJ/ZBZbajLMGeVvjlA1S6xkgY4SiYCHGt7WVZX6v+9T+q6gLaF60dutx8YD+2shm5VtpEqRVq9fMQRgfy3syFm53o/4JBLquIRaxmj7ziIXGsfbV6vjmCNeUaVIfWd++jjyS60So594Xu01SMFIIrqFmzGvXEb9QJs292cJJcgaUq5maZAtzY2iUkjfxnlr5Mfd0+/LRpF8bz+kNKckyT1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0t1G/E/XXCvKHnnjq9IYybPQRG3YkpdsFkUeUcddnQ8=; b=urjD4QYxQO4+XZRb3WKsCNLHfsVe1hEfjIl9R9YucLk5OZW91hk46UvbarwlZ0b0rnJuq8O368f+aTJ/NspGbNgeVQSI8HMlE7mo0UNJnYdtWI47RNfzW/Qci4eviOPSDHFWboBoL6do1Bamed6uW12N0TWPbyQ5FyfNFpyEVkfoxqvv11uCJWdFx47CaqAc8UIkT0R/yqrhl9hnV40RrB5X79J999fXK0hHinFfA0MhZCX2NDURKLKvP8vR+ZmZE5+YvfroHebUYwfJ9RZffSQ/r2D4nx8iwnbcHpIXLFfCtGqJl+pjALEzJYjrkOsStgPPxSwy8URu80rnRRdoLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 15:08:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1 Content-Language: en-US To: Alejandro Vallejo Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230808130331.27995-1-alejandro.vallejo@cloud.com> <20230808130331.27995-2-alejandro.vallejo@cloud.com> From: Jan Beulich In-Reply-To: <20230808130331.27995-2-alejandro.vallejo@cloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB7643:EE_ X-MS-Office365-Filtering-Correlation-Id: a32d1c58-0c94-4a38-0ebb-08db9810819b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T3z07wh7t4WnZnow5sNrj3fAq7xKQIobJob8ydyPHtVpOVILdUCmCYryZmkeuUuKNseTpi6Vza3e8qBVgSzn0K1AegJq+ChtFYmNVQg/IaL8+1ZzU0f+l5LoIiFyhwfVxY22e1skmJj+NV3xdAWd/2MyZAqFUqjZcbuwULNy4WoMlowf4dTz0pRkBaU6oD/O+nKr2Ew12S0Mr5L90S2yHfa4e0rvnJlMjBbnGCvtGyDMsZ3BgTawwF9Asb+SgLTzvRBv6VNWqiuCBhDSDXqQvSaM5Qiwh5RUuf/BYYzFIx5rQR4AJlIAQ7kDE2ZiM+ba/rrf0eCc34QAN9thY4NIw7U+RS7jDGSf3h7Jhl+TE3YbIddfcslk/TI2ql/OiTAyghKDlnOas4yApFRCsmzQ4jzKU2atb2YxJ9lUeQWEZlSYEkOBGbVoB0wVjgkA096yIW5nuNm+QN5dicA1Xd2Gq0LiLBzx96P9ORJbfiuokyhuCF+doVzPYlyKrQX7Ogo60j13dYnOskOcLxvcWPw+FyeE9QQWFlR+5nPZLMHUd6FzsTgPyQmZrne82Zar2yG+tYYjzAikEVVQ2HPvUN87YGd00CR+3ImYjDE4MFGVqk0Vj5xyQYjc+MScUvXZGOST5y8XNDfG6o6m3NeGcsZhUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199021)(186006)(1800799003)(8936002)(8676002)(5660300002)(6916009)(4326008)(41300700001)(316002)(86362001)(83380400001)(31696002)(2906002)(4744005)(6486002)(6512007)(2616005)(53546011)(26005)(6506007)(36756003)(66476007)(66556008)(66946007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmVnWEpJZGxOc1g5VFhrcXBqd0w3L004K3dNVnVDczdoWTBPeTdHbkRSTjNT?= =?utf-8?B?ekZsbjZJK3BJemo2ODFrVmdoRGMyMmx5MDZlT1F2dDdGcGZOU0R3RjlGcXNi?= =?utf-8?B?dU16WTRRWVFzLzlzS1hsOXd0Zk8rRW5YNDI3dGE4TjlvTk5yZ21Ga0w4KzBP?= =?utf-8?B?YUhpNUNVSXA2VWdGOXIrcXZ2OFgzd05tdHFaRE54em9iN3M3NTJSYjlPZUll?= =?utf-8?B?SWRBUUg4ak1ydVlvT2N1UDd0bUtuTXhUdlE5MjhhNWhNbmwvMWxRVEhQQWRj?= =?utf-8?B?dzRmejN2TkE4ZEFWWi8wcHFoR1R2Mk9mcVdVMTMxUGdVRThXOWFHT1E2VmpJ?= =?utf-8?B?OVdyclpIakxwZzVTUEZYb0hGZWJndk9vUEpLc0lDVDltL2U3dmFMakdMS3ht?= =?utf-8?B?THV6R2dJN2VtZFdyVVdPMFNsd3JZR2Y2YVFZSUZ3Wm5KUjZ0djNpUVBVcTVY?= =?utf-8?B?YzZqUHBhMnNndy9YZGo2NGROSmY0MCs5aHhmV2lJTHBkNkhldVdkZHZwUGVu?= =?utf-8?B?R09KWFoxdi91d0xPWUxoZ0R0c21lYTNZUXV4RlhCTzJFL0NzWjVUNGU0TjY4?= =?utf-8?B?Y1VZNjVHSFZtUkxWRVMweUdmTHhrS05zMmpmOHF2ejZNWCtSNUt5c0VBUmNC?= =?utf-8?B?Tm9uczR1eENOWUlaV1Bzdk5td28vNG1FR0M5QytodFVPaEtQRFJpZ3ZMc0Zw?= =?utf-8?B?ejZ6YUFSMEp5ZGYyVHZGa25TVk1rVEFCWjVBM2p4dTZpdStSb0E2SzNiWWZO?= =?utf-8?B?S01IdlFtSnhCTVhvd0RuTnJVUi9pdjBOcUxVS25WVGVxd1NLeFRjSjFUTjNR?= =?utf-8?B?dXJEbzZBcWxpejlmT09palVGWnBlaW53ZjlwdDVldStqRVFHM3UzUkRzQm1n?= =?utf-8?B?TWlHZ0ZzMkZlbTJUQ2YyR3JxS2VYc21aWVN0bmZib0M3V1VPem9YZkpDZVpy?= =?utf-8?B?ZHVKWkROVVY4WkR0c2RRb3NmVHZIZzgwcWtkakRIbE1JaTBGMVVuWEU2VDBD?= =?utf-8?B?VXZESnRBbWtYelRrWlhDLzRCZW53REZrTEJpZlBEMFliTThxeWo4enhTYVJF?= =?utf-8?B?M0ppWkxiN1dkSDVZQTFDdmFiN2VONHp5T09aZnlqbkp3a0RNODQ2YWpvQ3hY?= =?utf-8?B?eUhWeEdlNGlYNURDMHZES3BpSGc1Q3ZjbDBiTVBPbDF3dUNvR3BqZjhzZjNw?= =?utf-8?B?MGtNMmFJNFZ5ZVJqbzRuNk8zQ3cvRW40ci95bnY4VWJzTysyeDVuSENlZ2U5?= =?utf-8?B?b295UkxTN29tV09BK2FXTDd0VDNrOHNISDNMQ3dMZC9aRjVsRm9YUWg4Yi9y?= =?utf-8?B?TW8wWmdaS0p3YWFsRVYwM0UrVnh5Q0hUNlF6R1pML0ZuK2RSczVOKzBURENR?= =?utf-8?B?SHl4cXYzL2xPb3pBVVBoUjhPUVQ4QkZzQWNiSkJ3eDRZRUw5bjM4SndrSzFk?= =?utf-8?B?SDR0VG5OYVFmRnBFcERlekVXblR1emhGdXpncC9rOXdRNmgvdGxUL1NXdWkw?= =?utf-8?B?bW8wZTJzS3NhZ1haUkZEME5TRmd0WmZaTUVrV3hsU0ExbERjV25JcTlFdDlu?= =?utf-8?B?SUlCbldEd0dVaVFwUjZVSmFwQ2NsQTBrY25YcU1Tbmdpd1VQSzZMb0JFcHVE?= =?utf-8?B?bTVxMi9xUXo3ZXM5MDhVSjY0WHZ2dlo3Tjc5YWZQWXo5aXFaYUpWdmN5UmNO?= =?utf-8?B?MktUdjlRbGpQU1ZweHpBU0liNHZiL3pVSVlvc2tHV3UydWtvVEZYYVYwS1ZT?= =?utf-8?B?aHpnUkg0ZTVma0pBVzR5Q0N0RUdMK041MktpZEN5S0ZCTzhUbFdDUHZKQklB?= =?utf-8?B?ZFJneFdHL1dFWi9rd0F2QTJjSGE1U0t5ZklUNGt5WGJBU1M2dER2bnVWeG1h?= =?utf-8?B?cVBKbEN2REIzM01jVmcvRmxJMlNETTRlUW5lOE4zaWthTUk0THI5Nnd0bFVN?= =?utf-8?B?UzBwUGtwMlUzMmdKditOdGFkdkpWNzZWV1ZjbEVYUEErbUdqV3k3VUhFZWN0?= =?utf-8?B?bWZYL0tnaENlUmEzOWJtRGtPa3hOUW9hODFuQkhKS1pVN05Ed2pKTS9EMW9m?= =?utf-8?B?WlJxWHladGdnVXNwbXAyeU5MN2lyM2IvRzl0K1N2MnRpVzlGQnM4emtKK0dK?= =?utf-8?Q?wTb9fOUkCSiaNu6H80W7JLWR0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a32d1c58-0c94-4a38-0ebb-08db9810819b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:08:06.6040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +L44zMvKej45l0JEvOwcmAwaw5Sbhr7AK20id2cf7p2IjqDjqaMyyXoWlh9PYFVVruQwBvMtSFgjRNhpFjemAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7643 On 08.08.2023 15:03, Alejandro Vallejo wrote: > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long *module_map, > return -ENODEV; > } > > - microcode_grab_module(module_map, mbi); > - > ucode_ops.collect_cpu_info(); > > + /* > + * Some hypervisors deliberately report a microcode revision of -1 to > + * mean that they will not accept microcode updates. We take the hint > + * and ignore the microcode interface in that case. > + */ > + if ( this_cpu(cpu_sig).rev == ~0 ) > + { > + printk(XENLOG_WARNING "Microcode loading disabled due to: %s", > + "rev = ~0"); Sadly there now looks to be a newline missing. Easy to add while committing, I suppose, and with it added (back) Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:11:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:11:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579843.907995 (Exim 4.92) (envelope-from ) id 1qTMUp-0001Yb-5A; Tue, 08 Aug 2023 13:11:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579843.907995; Tue, 08 Aug 2023 13:11:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMUp-0001YU-2b; Tue, 08 Aug 2023 13:11:35 +0000 Received: by outflank-mailman (input) for mailman id 579843; Tue, 08 Aug 2023 13:11:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMUn-0001YO-Og for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:11:33 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2062f.outbound.protection.outlook.com [2a01:111:f400:fe16::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 176e2bfd-35ed-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:11:31 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9290.eurprd04.prod.outlook.com (2603:10a6:20b:4e5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:11:29 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:11:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 176e2bfd-35ed-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cHn4GBhcfzXjOj3FvuSCWnJkh2A9IlPEjSv3iTPCs7G/T9MX8Rauy5IegQpmv5E2Vf9DZ/8Ra7tYVakS37ocT6O2E3zz7zYSBG//AmOWipE8jYUmd35bXwiNaT5MTiK4N4P2E2LBFc3S+3sgvh5aLf0/ngpLfbeJ4JCdwE+u4y63I+uOzz8yhh3td/TIaHpwhCaFSIAFuC5J2b3IXpo4AR0eLVX4utAFPQS2pe19hyOkxv/WheSz1+krrjZ8vAL9HJJ+ivo9fllQUZ4JYw3f1qNrukxNcqfYp20C3rdOY0XdAho01Hy4Y3pAP+9hedK4iuyo0W3N1ubavjqeF2BARQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nw2w4nqLCdZLnnBWhs6E0rXyEuT75m9g3M9OCtBTI3g=; b=HaX53deg4BE2cwjBxBDw90J0KqL0zYy7mCWgziuYiaPA6/lQYx/ulW3jMGMvBMPW3EbcqLb3Rey01sCDz2KH7RtCqHwTeifvaA+hafKej6czsU2qzLS7dGKcflPAIENgE+3LEttOBKft4KxGMOGpE4zaYnp+LR1WIz/EZfodVQq0c+PStVnvsNm+hFlR+pbXYIWqlRlquuhaliDlg6KaVRGPPsp3ioGIr/V+p6Lq4cmL8gUIlAqYxi+Jui27iXS0vYd69dz9sa818S+ohFgkpVxePeaQFRKdVAPrOztDvSac5Ic4yxswtMEMpKcYvjKbA992CSLcV5l/9g/v8sGAvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nw2w4nqLCdZLnnBWhs6E0rXyEuT75m9g3M9OCtBTI3g=; b=CS39rNaqoyv7lvHyuFzieFAXvm1yBLzFLHS35QU0mUFUuubH+OITqued5NzzdATp1SdKmbmpj8Pumb8TC6KgAvaL13c2Col01y9lS93miY6enMEcIWsl7DnXF+FQOR3E+qvSAQnYpGbfJWh5SNvpT676rxhMvckgRzQ0opM2/ZcjjisF9zVpLdLSIYMciUgh4PTYFFBs/jTPbNp4bwXYg5m3MzTAt/9MLX+ct/junl996St7A78ZpJJtM7o6GviwMuW5HZxBBo9/Hed2gCC+YU77zDEmncvZXmxupm9wzrPpNMLgL7jfG2XFG54d5+p0QdC3+kMSxwr+XIFqSoV2Sg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0c0dd699-dc20-2cd7-bfda-d41e5d45cfbe@suse.com> Date: Tue, 8 Aug 2023 15:11:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1 Content-Language: en-US From: Jan Beulich To: Alejandro Vallejo Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230808130331.27995-1-alejandro.vallejo@cloud.com> <20230808130331.27995-2-alejandro.vallejo@cloud.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9290:EE_ X-MS-Office365-Filtering-Correlation-Id: bd2c6662-fff7-404b-67a5-08db9810fa73 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: axcxJVMOIBx+/aC2Q8VhEqZfF/uHoSiZGfYMVSmh0GZtCRq5LIeukNod2dF01TNrCKaYucGJsfRfn30k5/Dlzffzsqh2ZEDDhPhvBjWcWe2hD0awqlJZrZl5nXbm3mNUauhlFWlZs9BCTIm1ql3P1z5gqyIQz5GaDnT4QEDJlsB50efBMtiVdbrYpQFlRuqANUgCZwwr9gskrIHycOp/JtIrUBeGlLgnbLMBnP6AkWdV1lZxdV9cZQHrtxwr4p0RRacaZav1dGl1WMmkbNu74FkZwEDVgAJaIT1JMqYn+50+sklECcbU3sx8aBBn1g5t3nY3Q7wFUlfs5K8noPH40GwDr/xvhbF8eBrBl2E5UsMd/TUWoTmjjW1nbPlLoHKWZ3FUib/aIJWmGOr5fIPywB3qJZmiMHO+wiPD6K9dZMmU78JIMqHTqVnu4zDB2ZnDIW5UiSF/9qISUFjbKBndmylaamIVyuakYMevtmDXg3ZYfsSXsaxuyZb1qfUJLi1hqW77X3Ftk7g65pJfbeW/jREgkvcofNe2eckcs3eiKIGhTvfPeeQYlgSkPChiaZdVZTiKI1QxkoZR6G+I9SC7tWUTwh+cpLXKNmNHfCc2gKs0Hxcv5QBQxPyyaMVSMuoZUzGFgbo8BGQI52Iv+b44jA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(39860400002)(366004)(136003)(346002)(451199021)(1800799003)(186006)(31696002)(41300700001)(6486002)(38100700002)(6512007)(2616005)(83380400001)(53546011)(6506007)(26005)(316002)(54906003)(86362001)(478600001)(2906002)(4326008)(6916009)(66946007)(36756003)(66476007)(66556008)(31686004)(8936002)(8676002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTZaYThuaFFuMC9POU5hOWpDeGhVRzAzWHM4YmdZQlA3NkF4T3RmTFNyOEE2?= =?utf-8?B?QU5WUHhRTlRFWmkrT1hJZGhGVm9MWjJsNEJlOXRFdjlIcWxHZ2pEWUwxa0Nm?= =?utf-8?B?cDlvY3NONVZMSitiY2JMSm5SVzhSYlVJZG1DcmpOL1owbGtZU1VrUHJodU9O?= =?utf-8?B?R2RRbmdYNHpqSmxNakRYZ3NMLzlVNThVTFViSndscnA2NE91cGtKdElhSXRq?= =?utf-8?B?SXVzMXR1T2xlb2ZOUnVqdkpFMHlSRTROMFpOcmpabEkwQmd5bUV2WmkzK05r?= =?utf-8?B?dEhvVmhkT2daMFpoOVpSY2REWFp2KzRLSTFzSWhSalZXM1FXempuazFGREVS?= =?utf-8?B?L3BMT0RBMU12cGIvSHhWN2F0OFFqM3BGWm1EY3A2ZkNDUUFYeDB6ellFVUk2?= =?utf-8?B?UGRLM05zSGh5WXVHUVk5VUNxN3hXQUZ1Q2x2SnFpYnVsYVY5djhQMm1wNjRq?= =?utf-8?B?RHFZM2tnNUhzaGdPbGF2OVJ6RDdWYStrUUhudUVCa3dIN1ZPU2V6aEtsZVYv?= =?utf-8?B?aVJDQmM4TFFGalBURUxvRTh3cjI5SFBRSkhMT0JML2diUFhZeTRIeEVIWjNS?= =?utf-8?B?Q1I1WkQ3TFBOdU5XNzJWOTdDSjVSU3NWYURSOWVlUWk0NTYxUlpRdUYzWmpq?= =?utf-8?B?WkVFZHUyelJYZ2t5ei9RUzlrc240Yk5qOTRrTUJYNDI4TDJ6SDZ0VWJEbnpa?= =?utf-8?B?bHNCL3hYd0k1bkZSaDBQaGZ2ZGtkZm5ZREdvUm5rQjNIV3NlK3A4NWs5eTB1?= =?utf-8?B?Umt0cHhzY2pNb041cWRGaHZqWFY3eUVVaUtlbzBrYjZVQnh5SmlSZVR5RGFw?= =?utf-8?B?MzFLc3UxNm5iS0FHL05zMERFcitLdENUTnJNU3ZjNU1HQ3BXZVRncXdDZmh0?= =?utf-8?B?UWlUTTJ4VlRleUxQUHNTSVF3TFdGK0Fza0JRTk0rRVNLRmowaUhhTFM0azFG?= =?utf-8?B?SmErdlNDRjlGVWd1ZTQ0Njd2aHB1M0l6RlhmdDZuRktUZWdmV0FLZmVrcTlU?= =?utf-8?B?ZW5hSk5IS0hVeUJUQmNDZlYvMlZ2Zi8raHBaUkE4S0RKc0pPeTlRZHJKTVRn?= =?utf-8?B?eW1sMDNOT01ubVBkT3EzU1V4ckt2NWVUcVBxMDhRYkJJRnJMU0pueWNzbmZF?= =?utf-8?B?RElpTjFmclE2OU1PZ0RkYkRUUGU2RlNDMGpuSFcwOEF0MlBlbk1JRm0zU3pB?= =?utf-8?B?QlhkYkdYTVJrSDNIb0NoRHBMVFlmNEl2U29iZTF1Y0poaUxVcXpxNHFkTmlu?= =?utf-8?B?Q1NISzN6MjVwU2Z4ZGJNNDNyYXJkbUhkZmNRRERPU0JaeXNCdFB2VFJ6S0VB?= =?utf-8?B?MUlVeXB1ZU5ieTA0dHA4cTg2RHQzT1hMVWpFcU5HY3VIMmRBQUJYMUg0QTBR?= =?utf-8?B?THBWTjFDbHVqZHgvWit5ZXArMmFCRFdpWjF3ZXA4dGJRbDNkWExqRjhuOGlC?= =?utf-8?B?K2lIMW1NTUV0Y3phM1RWTUp0US9LK2xhcUVTclpPeS9PTVhNY1VseldiSW1C?= =?utf-8?B?NFVNK3ArMmZvY3NpL3JvVGVKZWtsNmdlZU9KTHRUeWVQT3IxN2hOVjZEdGlG?= =?utf-8?B?bjFIQVZ5enYwLzRsTWdUOVowdWMzNjRENjJSOStzTkxXWTFHZzlzK1oyRWNP?= =?utf-8?B?d1VwL2sxOUVJZm5qQTJuam54YUVUSSsrUUFualliRndJd0JkeWxEbmtWNXd5?= =?utf-8?B?WWl4NFFYbTlzY1BNMU1vMStvMUVTM0lpV3d5bndmZ2NVQ1FhdVE2elcwK2pn?= =?utf-8?B?L2NVM3QvUlBFU0c4VGppdHpvWDdPQUN3RGhqdzFuL1BPcndoYlhLSnZKY3Fr?= =?utf-8?B?RWlwM0JXUFR3M1pCbU9xRDBEUGlNYVhDSThZMHQxVmpQWXNnQ0FPNG9sajl3?= =?utf-8?B?NnhuVGptSmVFVTA4cmZLTk1vTHV6bFQxL0JmQlBFUThPMEVKbUw2d204NThw?= =?utf-8?B?eTA0aGR2NmNWbU54WEVIa1hKdFlHMDY3UmhHRGJod2E4RVFzQXpubkxsaVRh?= =?utf-8?B?a25GcWlOVEkvTFJ1S2Z5dHArY0ZYaDl3a3pXb29lanNPMHJrb1cwVHkrOXBq?= =?utf-8?B?Z3BuRGVaVUJ6VVVXQkx2Mzd4aWx1SVVoZWxVSlZLcy9tMVRyMzE5Q2ZGOWpV?= =?utf-8?Q?F1O1eNfQ6HiY7lwPoY8B/ilPs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd2c6662-fff7-404b-67a5-08db9810fa73 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:11:29.3151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XiXJ2KHU0Y3GocbKEz7GFhkHCwI0yi1yzLN/CxxCxJywAtkLkPQcVE2uTshU/pR686JHKwUQWasAq3c89IjgJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9290 On 08.08.2023 15:08, Jan Beulich wrote: > On 08.08.2023 15:03, Alejandro Vallejo wrote: >> --- a/xen/arch/x86/cpu/microcode/core.c >> +++ b/xen/arch/x86/cpu/microcode/core.c >> @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long *module_map, >> return -ENODEV; >> } >> >> - microcode_grab_module(module_map, mbi); >> - >> ucode_ops.collect_cpu_info(); >> >> + /* >> + * Some hypervisors deliberately report a microcode revision of -1 to >> + * mean that they will not accept microcode updates. We take the hint >> + * and ignore the microcode interface in that case. >> + */ >> + if ( this_cpu(cpu_sig).rev == ~0 ) >> + { >> + printk(XENLOG_WARNING "Microcode loading disabled due to: %s", >> + "rev = ~0"); > > Sadly there now looks to be a newline missing. Easy to add while committing, > I suppose, and with it added (back) > Reviewed-by: Jan Beulich Actually, the 2nd string also is indented too deeply; unindenting will in particular help with line length in the 3rd patch (which isn't to say that the line's getting too long there, but it also doesn't need to grow as long as it does). Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:15:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:15:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579850.908006 (Exim 4.92) (envelope-from ) id 1qTMYg-0002EC-S5; Tue, 08 Aug 2023 13:15:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579850.908006; Tue, 08 Aug 2023 13:15:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMYg-0002E5-N0; Tue, 08 Aug 2023 13:15:34 +0000 Received: by outflank-mailman (input) for mailman id 579850; Tue, 08 Aug 2023 13:15:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMYf-0002Dz-30 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:15:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on062c.outbound.protection.outlook.com [2a01:111:f400:fe0e::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6dab170-35ed-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:15:32 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GVXPR04MB9952.eurprd04.prod.outlook.com (2603:10a6:150:117::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 13:15:29 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:15:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6dab170-35ed-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f72ammhn/hSC7P8T7jXx2rQk+VxGafDNDTQtUzSAiKy5Yvk4jPalGu0Cb3r0tWm0YsqWgIP0Q0acPYDCktNHuCvMC8gk6ITys/E3Z2LcbzjrMBiHNo93qUmIo9kWqh+bAkJVta8ZQ9icIVlIX2ymXKGDnLhs2jrPxJaB4btv3aUEwg+l2YIQUUQv+d+srvrHEB9iuSpPJBGC6QrsYJPbJn15pNJxgbLYXFW6gWcKCQMnGAH1g2sckF7z5Kxe4psyg6kXoMOW18vP9J7Rwrfst/ZfjQQNBJMXEc0n8+o19QtjzN4J5HeNdInfx7KEHaG9FewC56ydk1HW6nB7EEXW2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAOXKKo0TLRDPIkp9mwQunwjQIo9OyvBvSz1/TOsE2w=; b=QD0tJRFUwNnIXH5rbnuVPVu0RHbhCxkE+T4OCfu9RcPKPHPUeDqeS8X0FA+3sKya/D4XhW9p2usbVe5dRaidt8rCL1Ue60UPPpOOLPW022QRyMzn76nREEIGzp6tLn+zmbaUT02ppRn9itZmLRQG6Nf//2f3XQQsSTnKRMu24qwvpZBoranFgrtrDbmeVxsV96tG7MMQzqTeJPx7Ba2Wc71f1E9zpRaFXwcnGbMo8FPkM0KFZbUFatWA/HMTZH2ZEZwdt5tgH9GcUOISQbpRAXDA4KmBevb7/Zsh9S1ikkYO2vu9Hnxhh4wZ0a0qM3lcQloFAG5Pmv8eJ5DMrLchdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAOXKKo0TLRDPIkp9mwQunwjQIo9OyvBvSz1/TOsE2w=; b=h4Rw/cUIz+NOqKNnwBFclaJYcf+lERE74TRMKDp1vc8RTD0IxhagkVnOm36p7QalWFxkP8xQYVyP6de/YJVF9nL6omYlUtzaHbZdWbNj7LrfVwsGqJKQ+PH4ZY6S3bmtqJim9OWpRRa49F//ZvxHs1CtyTPu2hv81Lk8droXOEVJZihLmeWTdyeF+xhN0P9wz2jlWFAHt6UeDbX4Q0zzOS4PwZUnzyHj5FKMjiPfmCQXwYfNf2pHwuQmPRMT0u4BECDCpd+C/s7gQ2ijDOUHlnk7j6Y2lzhC0C5sbdHVj1fLXHS08KjY7G3jlsUo/y4B/VCoAE5sMeEFz121JO/6iQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 15:15:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 9/9] xen/ppc: Enable full Xen build Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <44fe62a196e2621ac88d0f4b9e7ee97bf1874d59.1691016993.git.sanastasio@raptorengineering.com> From: Jan Beulich In-Reply-To: <44fe62a196e2621ac88d0f4b9e7ee97bf1874d59.1691016993.git.sanastasio@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GVXPR04MB9952:EE_ X-MS-Office365-Filtering-Correlation-Id: 9214b949-334d-439f-ba13-08db98118972 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uwYl7XHiY9cvBaPHtPwpJhRCOZwxUN2gpDWFdfQRk3anwDmFV8BvGcAbqoEJeDh2VwiopCoHs1Dupse+mUAsuQvqr8oSSIjwX0deezfUGXe3V3Kg+qrxO3c8dcMvFjkOLxtWN5MfuZ1sw9cfIAPYgKRSu3s7lx4fvBJSARMjL8WUOnSaP8ZoImdRwyk92VHx46qpFdJaT4qhaHaaeDrPvKGApxYakpoJImWWPAgC0t4cdA3cEWMhbIn39FQBFfln8qtXAimG/0w3M3/4Yy9//cFXGPbMMyJVmkWmNnOFq4M2zW6WBlfS+5fBgIlg82AP5NHgqfPW0rso4s0ceoz4ANkKVqkSz8UzCziDczRRJroFWlwnPfFK/hH9x/i8OUvobvcXskBSsjj4gyy+6wgImAFlFoTgAlj95pKT/lK0jDEt3Ky5lWBuxn1G2vkUWANw09RMLOrK/zh/CWljh0bZHeW2jwiC9S98SzTwBh65/vbP368U8n83ybY78OQ/95Kt7lajOdflldo99c0N3GGYmNJ4PT/lIknk7p7u43l49ykbwMVjVldai4TCckav/vH1fbgWXoQxbxHjf3MRXCy2qTek9qDXMSb6C+OFZo/ppSvqTkBVdXpqnnwCaPjUabgJBeWM6v4RwJh2MspFue7/OA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39860400002)(186006)(1800799003)(451199021)(26005)(41300700001)(2906002)(5660300002)(31686004)(8676002)(8936002)(2616005)(86362001)(53546011)(6916009)(6506007)(558084003)(316002)(478600001)(38100700002)(31696002)(54906003)(6486002)(66556008)(66476007)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bStyUTY5UFhwbWN2UUdwa3FEaFh0T0E3UWlDRzFOMnJIVVc0WXhoZFF0UzRs?= =?utf-8?B?Vy9uTFppRUdNMTA2UTZTaFhJak0wYVVMaXN1UzB2bzlyZnA2Rk1QY3V1VWRK?= =?utf-8?B?MjZnOFVCaWU5Mm9JcHFZemNVM0VWbnZFUUtJdzBTTEpDZlZQSjZjcmVXbERZ?= =?utf-8?B?bjVtTGFsa3NXNXV6d2lUYVk5bC83UWZRRFloVk4zdFNEN0wydEcvMHZlK3Nr?= =?utf-8?B?bC93SzJVOEYvSmpqZHFBMWZ5dzBEeE9wdHJOY3dCZ0E1S1pONXBVY29HNDBi?= =?utf-8?B?NGxrMTNKYnF4SFZVQVo4NjFKc0lMQ0lzVHkvZERGamw1blNuWU83T1J2dW1y?= =?utf-8?B?UkZBaGZra2RGQlJPd3RDb3ZVbDlBYTdRd3Y3N1hSc2pvaW9yQ290aU5nRzFM?= =?utf-8?B?a1pna2lldjlvazhWYTc5bnE4YWFGaWhFUnV3M0dxRklkYldDamdrai8zQjJD?= =?utf-8?B?dTFBRVFWcWcza1pvQ2RPTHk1WHlIWUFmdTYrSjFHSDhTU1NMdElvdnI4bUFq?= =?utf-8?B?YmJGQ1V5SUNDWk1kZTU1czdCdmIxMS80eFdraTAvcGtQdHJqUTAxTVVuL3Rr?= =?utf-8?B?Q29CZVhRL2pxYlNmeW1EakxHZlpnVzhzcUZuV2lxblU2L0VVL0owL29lNG43?= =?utf-8?B?Qmh2OVFzcTVzT29pSE1NWG5MMFVpanBDWVE2b2lMYTdWWWM4bVJpYkZkV0Nt?= =?utf-8?B?SmlLRERPRFVFcWFTdStYV1VkblBDYTBrWUVSQ01KVWFURTVxMDhoL3NLdXU5?= =?utf-8?B?RUhtYTViR2hEQ1kzK1ROeWtpVWliOWo3UysvZEpOTnliWEp6SVdYNHNZeVpZ?= =?utf-8?B?ckJNcS9ndHJZdmZuRHMveS9PMVY1MkYvVXJINmlxRkVOZjZlQU5rN1E3OW9k?= =?utf-8?B?dEZKZU5BbGdkdzBTMFZOdENOSmxzbVk3dUFqdW9tbjhqVENqTXlKUlBHVXFN?= =?utf-8?B?OUFtWnJBYW94MFZhSElHWnZOMUFFYTRzcHR0VWRqSXZjcmU2bzJOY2dUMFor?= =?utf-8?B?aDAzMHRrMVNOb0oxUm9kMXZucjZ2K2xuZHBpNDB0VHA5RVRTUytBNFJaVFhH?= =?utf-8?B?R3pJSTNtOTRxTDZlWFJIdEFKZFYwUWdNQU5pSFBoaWJjWU5NVWIvWUlpdEEw?= =?utf-8?B?RU03Z0ZPQ29XUGFLdnp5SmlrTDJkN0JWTW1qTXhnRXhzUHY4R0tIWE1IYUU1?= =?utf-8?B?dklnWEVZT3gwTWRXTXhuTWx0TXFzYy9XZFhVYlFqOFZzWEtMdEpycUxlZnBL?= =?utf-8?B?Wld3dGF4SXN3MzZFdEh0WWVWWUJMekdtU254dDZ6eHRBVS9WRFg0TkdQdERM?= =?utf-8?B?ajdKZXhCaWdHSUlnRm4yenIxMnRSTHppYy9rR2dzS0xhKzc5ZktCdkdhSGJh?= =?utf-8?B?RzNONTNJdTIxQTNkT2lpemZsVUJiblZ5c0VrZTNudVp4ZTQ3K0J3L3JPRTdK?= =?utf-8?B?T2ozWXhPbFkvQkZscEhqbEhZYkZUNjFUcCtHaktaQWZ0a2phVVBHbVQvS092?= =?utf-8?B?QTlpdE85UVV1ekdVV0VoalBvWmdZU0xMcE5GWDFydlgyLzE5blNOdWNTeGRY?= =?utf-8?B?bU82SFpFZU9oL3lDVmY5MGtsV2FZZElVMHRtd21DUU1acjlwZVZFRElxcFJZ?= =?utf-8?B?NEFWQlM5RWw5U0pBOEZFY09PenliRDdhdkFPdjhORm96Q3FWRlMvNTFIYWtr?= =?utf-8?B?SXc4cHJHVE5MWXBBUDV2bzRUNjNRdlEzbml1Mk5CMFQ4bG83WTltckR4SXlq?= =?utf-8?B?bHBEaW03YUh1NWNqWnRFNzZ3eCtwMWRxekgxUm9udzRmcVVNbTRWTDJvNnJJ?= =?utf-8?B?S0YxSmZldnJqNm1nU0daZzkzaml4WS9UM0UvRWFibjZKakJJVDU4TjZzaElR?= =?utf-8?B?K3AyOFNkbEdKNkhHYlppa0t4SHdDZFZZa0EyUU4xQllvbDEyK1VhbHBTd0lL?= =?utf-8?B?NU1takxIVWV4ZkZGNzRoQ0NQaDNjY21ZWGdqc09zYjJERjd3RldNN0o2OWxt?= =?utf-8?B?WTBtZXE1c3pPbCtwOXRNTXkwMExTZjRzUlM1ZG8xNUQ2SFJuQmY5bFg5Z0s1?= =?utf-8?B?U2xOeHpjbllTYWRDazZ0U200Zjc5U0Z3VHFRS1pkNXMzK0xsNFkzTS9lSkRS?= =?utf-8?Q?Ql+FwJI7rQdl3ZB4bwx4UqHCY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9214b949-334d-439f-ba13-08db98118972 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:15:29.2754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AKIB+YlaSCcBNzAn36BUaRg2p5Nf6+9rOjayTTE11vkcMmrsUvTfdjVTC8X4VzRUUx6vgBJHNLdTK1fr29id2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9952 On 03.08.2023 01:03, Shawn Anastasio wrote: > Bring ppc's Makefile and arch.mk in line with arm and x86 to disable the > build overrides and enable the full Xen build. > > Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:22:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:22:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579857.908025 (Exim 4.92) (envelope-from ) id 1qTMfK-0003yN-OV; Tue, 08 Aug 2023 13:22:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579857.908025; Tue, 08 Aug 2023 13:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfK-0003yG-LS; Tue, 08 Aug 2023 13:22:26 +0000 Received: by outflank-mailman (input) for mailman id 579857; Tue, 08 Aug 2023 13:22:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfJ-0003ij-Ia for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:22:25 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe16::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9c943163-35ee-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:22:24 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB8052.eurprd04.prod.outlook.com (2603:10a6:20b:234::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:22:21 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:22:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c943163-35ee-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XyAPWua5zCdja2FoLnbNhQRPl3z1vuQj1DMYL52NCjwHJAVAiggMaT62rcctPVBNFjLSgI88yCHqoQRb7LIt+mi3AIPGUZCi1V8tAxaFP4P7wOGuRMQqZ6po2n0y0XxXKfOtuqtzU7Jr5Qg22ORKy/hV9s8EKtgjKa/wDbs76cfqon2n9hibuFcwvN3SdhhU1RQmNvv7rm0dAy7oLJWWYbfDQhoyLSD8Q5z/k3rDcl0MZhScUTNJMZxT/WlONIB90H6xHm021O+8A9h+CqideoZT9YfyqB0IoFFB2S2iYWaSaH8TpGKkE3XLgyBdlmWznHv74+1p9MNCfJIP0/kEqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LXcdRd7ipB1pLLnNe0yBmXkY6bBajuyKhto5TUY9SDY=; b=RP/2mBoj1qbXJlvqHJNBAYCHstOvVc4EO6CM9sC/MSqMlJwnPMOmddioDoKYIFbb3kf7SaG6LCSKHf7fEKYXXAVjr9Metm2/etVhCWO2acQ49lAeXFuslZj2aaqWYfLWN2X3+Ae9VddJxxiz16wGZgHJf+dMxmd2Z9Vp2KiA2ZNM5GxcOvLo5jDyXmFPEhFIC4vnaZK4qzl4XTTVmbKhI9iyTZxn+4VFQVs9SAtvx5seAnfYzYjKuOEicpXuHK7Y6VQVgY2QXb2ejb57XwOEzqsgZxDrzCJU5p7iEgNpJjvJBqIPAxaMUWt1e8pqeFTv+swAEzPjddN4LP8XZbSE8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LXcdRd7ipB1pLLnNe0yBmXkY6bBajuyKhto5TUY9SDY=; b=Ro70st6lFaSyU1rN7o2pyFAdPY5RYeOhYYnT/oIdbsHndzTL8W+IFxkPDiVxfEqlmbEZ+jZXv1xxFfNFhKLsir+atsyAOYss+vFUr3CTDarMTHZ5OxXb/+B2KUmfzCNrWE+o48li07lT9wTkfxjI9RC4s7xxoXez0vLWJHvd0v/x/m0wmqaKKM4o5ncd1XGPIbaXTiyl0akOFPLB7nGI7MB7HwXP0mwru5kjxlEoRawkv5pND93DhHi8xdcJi1bRnJtTmfNqiC21kvlimWMi1vgsgYouqq/G6z8IrT5NI4yOYlxvRdTff4orsELwTatclZZlrI2EzM14Bg89/OLLhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e5f208e-7419-b16d-c705-592959dc0ea1@suse.com> Date: Tue, 8 Aug 2023 15:22:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v3 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <605687eff99db7181ef6c05bce671e20f194b46b.1691488505.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <605687eff99db7181ef6c05bce671e20f194b46b.1691488505.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB8052:EE_ X-MS-Office365-Filtering-Correlation-Id: 61298191-510b-42aa-0b4d-08db98127f03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TTWOnXNa/2yloyvnNKZ4WJFl8yBX0CiRydM3Ioi1kXnQU0OMu8LMsWOZUrlObdWaVQNHLdWSUgP3RoYi84tDpNq2CG4a5TwuOKZvlr/h6mJQljjsqWsrIazu8W74j1zeiH7599c+/tlUAspxrZvAXUUmmfd3Ulp6oa+3ApRkPQTnfoAAFw8+4MF+2ijh4sF5hJZd8AVLhl4APaJTncW3ohncwRDur37YnaxGzGu/+p1G+A8cmm1jQvZ9ChcnzTnoJvKMahEMDGBeT6IMaOFPSyqjH7PjXvkcAdB/vDhFGzjxYD7cAc4fsxgKylqvB4Ak4OruUKt5sL94VEHKZBYgKoY7YfRrq3PY9aXKhqICkdQSPUVf9E3NWRUk1yUvPRGxan4MMlllevlAeblD6eie9F3JIwG9oWTA8QmMFM7EmtNulkj7KbW8OZQd0FkesGA7lKKRDum2gXrCGTL2orP4uRVqP0WqxwT2OIl8Bdcls5M5qAtLthnGRNb5pWw7fhp+s4Q23DzHXcucGgCL5YT08D9lijKGvftx8aQnIgY34PbI+lc2mglyey4fx2juoklDI30P5kRPDTrYynBdULQIyWt+/h4UND7gneTlNcgSxumBZIi+nzfK9dpBKpN01miltAzW9irdJymkxRnKY8XvoA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(39860400002)(136003)(396003)(366004)(346002)(186006)(451199021)(1800799003)(66946007)(6916009)(2906002)(66476007)(4326008)(6486002)(6666004)(83380400001)(5660300002)(7416002)(66556008)(41300700001)(8676002)(316002)(8936002)(38100700002)(2616005)(54906003)(31686004)(478600001)(36756003)(26005)(6506007)(53546011)(31696002)(86362001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmxxYjVYSStBQXppRi83Z0tJMzBVSnp4aHBRbFRaZ2tOTW84TURKWXlXYWc5?= =?utf-8?B?U3hmUW5FVUsreDVNa1dOQ2t6KzYzYlM2YkFaUUN2TUpNNGw5dzUxTVg5bWlN?= =?utf-8?B?RVdROXY4YWJYd2JzTjBudWcwdFNHQ3k3OHFmZnRrNGF3TFdXeE1JbTV6eHNT?= =?utf-8?B?VjMwSnZDQWJxR0pxVmt3L1BlMURTVjdrcjQvdTRWaEdxRGdQOStPN3VFOGNr?= =?utf-8?B?VW1UNnQ5dTd3VkVNQ3VBc253cnk1cmEzSTJVcGd0SnNDQVNBZXk5UUptWnNn?= =?utf-8?B?cUZOeEZnWEFFWUlTMTlGWlhpZ2hPNm9FMDJweWhUMHk5aWhDYUdxRG44Sktq?= =?utf-8?B?U0lWZC9IOFl5SS9naVNVYnNPdUF5NWg5T2xvRFhDZDlFZ1RXbGd0RzFJcktl?= =?utf-8?B?SHZFa3J3YWYxQm5OV3pxWVp0UDFHMTFtSTZrTUlsMVVaQ3hsVFNBOFhEeU1P?= =?utf-8?B?cXZEUWU4dlFpWGNKYWtibzZhS3pHZnU4aXVmeFRWaHd0cEd1SzhIZGE2dXYr?= =?utf-8?B?K2dHUDFWeG5YYXFuVE4zaTlqM2wwUVdXeHBXQW1lQllUMmt2MVBIcHFzY2p4?= =?utf-8?B?c1IwTEtEWHdHL2JFSURJVVVNeDdJMEdqaTFjTDhYcUFWUmVGN1JsNWtrZ1dB?= =?utf-8?B?Q042eVJKcGg2RmpPeTR0ZnZ0NGZGd0Y0NzNXVm1zaE05K25FT3ZXNGhNUXRZ?= =?utf-8?B?YlgyK21na29kUzhiL3FVRjNBYm96T2xLSUVRdjg1TFhzejFyaENjd20wVzNs?= =?utf-8?B?a1VMOEgxVTVwMTUycUk3bTIwR3ZBbnJ5UWhMSVVkeU13K2JQSy9xTm5qMGRW?= =?utf-8?B?aE9PN1JiRzBuTmw2dFNqN3FiTUxHN01CSVYzN0hrZWtRZnVLemJIYmpIN1N1?= =?utf-8?B?RHBHN2UyS3QxS3U5NHhyRG1nbkNOM0Y1L3BnN2RFTnBZTnFiSk90WUxibVg2?= =?utf-8?B?SEdFa2pPbkFqQjhZTHE0WnUxR3RXRVFoVjBIeEFpc292NG9hSXkrWFBibHFa?= =?utf-8?B?aXE5N1dnVXNvbm9pc3FHWnBXcWorbWJXTmRXS2owSnp0dlVkUnpJdnZ2L2l4?= =?utf-8?B?djBGcG4wMitQMFMwTS9qUVlKc0MyLzJjQjR4ZUIxOEkrblRSbmRRZCtqOHlH?= =?utf-8?B?YlFoT1A2OE5NYVFRdGt1SmtxOXRRaFRIWmFOckpqekNpQVN5OVc4eXV4YVdX?= =?utf-8?B?VHNERGpYZXBMaU5TNEk2V0dxb2dVT2Yyb2M3Nk15N0toaHJ0ZzFQcFo1WTIy?= =?utf-8?B?N1BLTVBUeXZOZkE5WGhoWlQrYk5GdnF6Z3RTWGlFdEFyZkdQRGk2VGdRc2xF?= =?utf-8?B?OUJPS3JiMlJwME4zdFhpMSswR1FUazJRYm9ITmF2bEFtdkYxdXRSa3llTkQ2?= =?utf-8?B?bUFvZE10bGZFc1d5Zkw5eTd5cHdqOWs4NU1OQTJOUnNmZ0Jjd2VmNVRScmFM?= =?utf-8?B?MmdobXUxQUpSV2hyRHRGbnRlQkMzRVVEMUZsZlBnMmsweHdMNkJablZNSS9p?= =?utf-8?B?dnMvZ1JXYUE3QWNDVmtNSVIrb01CN3BXNWRtSkZLN1Q5T2loZlNMT2VUU1hK?= =?utf-8?B?ZXBmZ1QrRXppNEx4UU8wV3BERzY4UnVkWFpHd3U0a0FSZ29Zc1RQa1FVSWVM?= =?utf-8?B?QVFKV0JUK1pkMmdpNk9CVkozdzl4YmNCTnhxQ29rc0JjQkV6ZGFaVi9NbTJm?= =?utf-8?B?VU1zNnVobTZlOWY0SHZUaVZFbTA0azhnWjVUOGl6clBiYVg2eWl3MU92WjNW?= =?utf-8?B?blc0d1V0aDdNSzFIeTl3dnp3RVNDd1I3V0xSczdhdEhJcTBaeCtuZEpzbEYz?= =?utf-8?B?bXFSMnZRT0p1OWdMdzJDUHdwc1ZGUGFWbFZ6cG1QS2JHVnNmaEl2WERsNWp5?= =?utf-8?B?cFc0MURFdFNIaFRGNHlIeGE4QXg5R3BMcEt6UDZOa09CVys4U0ladDZwczhv?= =?utf-8?B?dGZ2VVgwdUNWZTdIeThtUWNEQUhNTEIyTVRFaUdVb3lQYkhxNHBDUkdTNTdC?= =?utf-8?B?eHRmNUJ2TENVcXRtZjZ6KzlIRVBOQ3JIYmpxWXlMV1pSQVRxMUc0alZTRXp2?= =?utf-8?B?ZFVJN3RFamFZeWxaMnB3NFVvOHh6d2R5YzI3Z2djN3k4ZUFDNlpNNHN2N0Np?= =?utf-8?Q?cE2ANH92/mUX65THpvnU1dpn8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61298191-510b-42aa-0b4d-08db98127f03 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:22:21.2260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Df371Tflgggjh0QrSEvwQkWkH2s/oz1/eQTTo5ndeFfYJcb0eqH5hx4CCzeYkVwrH3tbFW02C7YKrQJ8CoXyUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8052 On 08.08.2023 14:22, Nicola Vetrini wrote: > The local variables 'irq_desc' shadow the homonymous global variable, > declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed > 'irqd' for consistency with ARM code. Other variables of the same type > in the file are also renamed 'irqd' for consistency. I'm pretty sure I pointed out that Arm uses a mix of "desc" and "irqd". So "consistency with ARM code" doesn't ... > --- a/xen/arch/x86/hvm/vmsi.c > +++ b/xen/arch/x86/hvm/vmsi.c > @@ -281,7 +281,7 @@ static int msixtbl_write(struct vcpu *v, unsigned long address, > unsigned int nr_entry, index; > int r = X86EMUL_UNHANDLEABLE; > unsigned long flags; > - struct irq_desc *desc; > + struct irq_desc *irqd; ... require e.g. this rename. As mentioned before: Let's limit code churn where possible, and where going beyond what's strictly necessary isn't otherwise useful; there's already enough of it with all these not really helpful Misra changes. > @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry *entry) > > int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtable) > { > - struct irq_desc *irq_desc; > + struct irq_desc *irqd; This one indeed wants renaming, but then - consistent within the file - to "desc". At least that's my view. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:22:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:22:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579856.908015 (Exim 4.92) (envelope-from ) id 1qTMfH-0003iw-Ga; Tue, 08 Aug 2023 13:22:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579856.908015; Tue, 08 Aug 2023 13:22:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfH-0003ip-Dh; Tue, 08 Aug 2023 13:22:23 +0000 Received: by outflank-mailman (input) for mailman id 579856; Tue, 08 Aug 2023 13:22:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfG-0003ij-MP for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:22:22 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b1b3759-35ee-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:22:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5733C1F854; Tue, 8 Aug 2023 13:22:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1DBAF139D1; Tue, 8 Aug 2023 13:22:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aTeDBY1B0mSEFAAAMHmgww (envelope-from ); Tue, 08 Aug 2023 13:22:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b1b3759-35ee-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691500941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UQ+5zBn1XAZxftfBB0XZsFZk9nESEsmFs1t+RvZXh0w=; b=rXseobaNJvAPZ//kgm0nIWfo1uxKnsTBKgMspqVsbiZ5VBgUKdFIOY8cKULidc4g6Zb3ax PKT2ispOWxv/29uearM7QoEe4e+3AooUIuICjSaxQLrIX0J3NQOZtNCNLwa2Clye28oOCb CINpxGFChosvVyS5zL+xCpJ4C1Ua2vk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH v2 0/3] tools: add some more configure options Date: Tue, 8 Aug 2023 15:22:16 +0200 Message-Id: <20230808132219.6422-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add two additional configure options for controlling the build of pygrub and libfsimage. Changes in V2: - add check for --enable-pygrub --disable-libfsimage - new patch 3 Juergen Gross (3): tools: add configure option for disabling pygrub tools: add configure option for libfsimage tools/xl: reject bootloader=pygrub in case pygrub is disabled config/Tools.mk.in | 2 ++ tools/Makefile | 4 +-- tools/config.h.in | 3 ++ tools/configure | 74 +++++++++++++++++++++++++++++++++++++++++++++ tools/configure.ac | 26 ++++++++++++++++ tools/xl/xl_parse.c | 9 ++++++ 6 files changed, 116 insertions(+), 2 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:22:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:22:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579858.908035 (Exim 4.92) (envelope-from ) id 1qTMfN-0004FS-21; Tue, 08 Aug 2023 13:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579858.908035; Tue, 08 Aug 2023 13:22:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfM-0004FJ-V1; Tue, 08 Aug 2023 13:22:28 +0000 Received: by outflank-mailman (input) for mailman id 579858; Tue, 08 Aug 2023 13:22:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfL-0003ij-Py for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:22:27 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e6214ea-35ee-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:22:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 034282031B; Tue, 8 Aug 2023 13:22:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C7F1A139D1; Tue, 8 Aug 2023 13:22:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CO8JL5JB0mSPFAAAMHmgww (envelope-from ); Tue, 08 Aug 2023 13:22:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e6214ea-35ee-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691500947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=frP7fLjhFOfOILeVRX9wP4pxrjeCRuK4+ypxOEXe4Qk=; b=DkzjRWwhBNVPOzGTKjT26u3UZeKnxC4cW3qeB3ONufmx0e62k6RuTHRsAk4nGQabXrEwA6 K0jeokb7VtAWRJtLkEPEG9XKDWCXiGXYmLW+NSSsHKgNwavvdSQO+FMcCFo8Kw4LLXiBFY m+tsdBxNEgIgrJOOXf+SfZoN0rAb1OM= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH v2 1/3] tools: add configure option for disabling pygrub Date: Tue, 8 Aug 2023 15:22:17 +0200 Message-Id: <20230808132219.6422-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230808132219.6422-1-jgross@suse.com> References: <20230808132219.6422-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a "--disable-pygrub" option for being able to disable the build and installation of pygrub. There are two main reasons to do so: - A main reason to use pygrub is to allow a PV guest to choose its bitness (32- or 64-bit). Pygrub allows that by looking into the boot image and to start the guest in the correct mode depending on the kernel selected. With 32-bit PV guests being deprecated and the possibility to even build a hypervisor without 32-bit PV support, this use case is gone for at least some configurations. - Pygrub is running in dom0 with root privileges. As it is operating on guest controlled data (the boot image) and taking decisions based on this data, there is a higher security risk. Not being possible to use pygrub is thus a step towards a reduction of attack surface. Default is still to build and install pygrub. Signed-off-by: Juergen Gross --- V2: - better wording regarding security aspects (Andrew Cooper) - add HAVE_PYGRUB to tools/config.h --- config/Tools.mk.in | 1 + tools/Makefile | 2 +- tools/config.h.in | 3 +++ tools/configure | 34 ++++++++++++++++++++++++++++++++++ tools/configure.ac | 5 +++++ 5 files changed, 44 insertions(+), 1 deletion(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index b7cc2961d8..432d7496f1 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -48,6 +48,7 @@ CONFIG_QEMU_XEN := @qemu_xen@ CONFIG_QEMUU_EXTRA_ARGS:= @EXTRA_QEMUU_CONFIGURE_ARGS@ CONFIG_LIBNL := @libnl@ CONFIG_GOLANG := @golang@ +CONFIG_PYGRUB := @pygrub@ CONFIG_SYSTEMD := @systemd@ SYSTEMD_CFLAGS := @SYSTEMD_CFLAGS@ diff --git a/tools/Makefile b/tools/Makefile index 1ff90ddfa0..bbd75ebc1a 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -36,7 +36,7 @@ SUBDIRS-$(CONFIG_X86) += debugger SUBDIRS-$(CONFIG_TESTS) += tests SUBDIRS-y += python -SUBDIRS-y += pygrub +SUBDIRS-$(CONFIG_PYGRUB) += pygrub SUBDIRS-$(OCAML_TOOLS) += ocaml ifeq ($(CONFIG_RUMP),y) diff --git a/tools/config.h.in b/tools/config.h.in index 3071cb3998..eacf1438d8 100644 --- a/tools/config.h.in +++ b/tools/config.h.in @@ -45,6 +45,9 @@ /* ROMBIOS enabled */ #undef HAVE_ROMBIOS +/* pygrub enabled */ +#undef HAVE_PYGRUB + /* Define to 1 if you have the header file. */ #undef HAVE_STDINT_H diff --git a/tools/configure b/tools/configure index 52b4717d01..44ec7a6477 100755 --- a/tools/configure +++ b/tools/configure @@ -707,6 +707,7 @@ AS86 ipxe qemu_traditional LINUX_BACKEND_MODULES +pygrub golang seabios ovmf @@ -811,6 +812,7 @@ enable_xsmpolicy enable_ovmf enable_seabios enable_golang +enable_pygrub with_linux_backend_modules enable_qemu_traditional enable_ipxe @@ -1498,6 +1500,7 @@ Optional Features: --enable-ovmf Enable OVMF (default is DISABLED) --disable-seabios Disable SeaBIOS (default is ENABLED) --disable-golang Disable Go tools (default is ENABLED) + --disable-pygrub Disable pygrub (default is ENABLED) --enable-qemu-traditional Enable qemu traditional device model, (DEFAULT is off) @@ -4287,6 +4290,29 @@ golang=$ax_cv_golang +# Check whether --enable-pygrub was given. +if test "${enable_pygrub+set}" = set; then : + enableval=$enable_pygrub; +fi + + +if test "x$enable_pygrub" = "xno"; then : + + ax_cv_pygrub="n" + +elif test "x$enable_pygrub" = "xyes"; then : + + ax_cv_pygrub="y" + +elif test -z $ax_cv_pygrub; then : + + ax_cv_pygrub="y" + +fi +pygrub=$ax_cv_pygrub + + + # Check whether --with-linux-backend-modules was given. if test "${with_linux_backend_modules+set}" = set; then : @@ -4595,6 +4621,14 @@ else fi +if test "x$pygrub" = "xy"; then : + + +$as_echo "#define HAVE_PYGRUB 1" >>confdefs.h + + +fi + # Check whether --with-system-qemu was given. if test "${with_system_qemu+set}" = set; then : diff --git a/tools/configure.ac b/tools/configure.ac index 3cccf41960..0d1c8f9fa3 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -89,6 +89,7 @@ AX_ARG_DEFAULT_ENABLE([xsmpolicy], [Disable XSM policy compilation]) AX_ARG_DEFAULT_DISABLE([ovmf], [Enable OVMF]) AX_ARG_DEFAULT_ENABLE([seabios], [Disable SeaBIOS]) AX_ARG_DEFAULT_ENABLE([golang], [Disable Go tools]) +AX_ARG_DEFAULT_ENABLE([pygrub], [Disable pygrub]) AC_ARG_WITH([linux-backend-modules], AS_HELP_STRING([--with-linux-backend-modules="mod1 mod2"], @@ -184,6 +185,10 @@ AS_IF([test "x$enable_rombios" = "xyes"], [ ]) AC_SUBST(rombios) +AS_IF([test "x$pygrub" = "xy"], [ + AC_DEFINE([HAVE_PYGRUB], [1], [pygrub enabled]) +]) + AC_ARG_WITH([system-qemu], AS_HELP_STRING([--with-system-qemu@<:@=PATH@:>@], [Use system supplied qemu PATH or qemu (taken from $PATH) as qemu-xen -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:22:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:22:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579859.908045 (Exim 4.92) (envelope-from ) id 1qTMfW-0004ha-FF; Tue, 08 Aug 2023 13:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579859.908045; Tue, 08 Aug 2023 13:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfW-0004hR-BN; Tue, 08 Aug 2023 13:22:38 +0000 Received: by outflank-mailman (input) for mailman id 579859; Tue, 08 Aug 2023 13:22:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfU-0004aK-Kk for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:22:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1c3ee17-35ee-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:22:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A63EA21A5E; Tue, 8 Aug 2023 13:22:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 779E9139D1; Tue, 8 Aug 2023 13:22:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ggiOG5hB0mSfFAAAMHmgww (envelope-from ); Tue, 08 Aug 2023 13:22:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1c3ee17-35ee-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691500952; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ILsXfNsar6elu7aqIAUAvhq1elG/GdFUcYJ19l5rS0=; b=AaCQvnaiM3b2x6iwqJnm4VweB8u7YWAeBB0v4sssntQQZZlOaRbp3c/BijWSZtH6Bfpxyt sMX6KtAefjUEUQC9U8RCboCDtfOJp1eMdJhU2d8yN+WEYAnL4YN9QGNYl07k34OV8qkXtR gHN7qfkIjyER/HwmP7KDpokgG5cbok4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH v2 2/3] tools: add configure option for libfsimage Date: Tue, 8 Aug 2023 15:22:18 +0200 Message-Id: <20230808132219.6422-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230808132219.6422-1-jgross@suse.com> References: <20230808132219.6422-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The only in-tree user of libfsimage is pygrub. Now that it is possible to disable the build of pygrub, the same should be possible for libfsimage. Add an option for controlling the build of libfsimage. The default is on if pygrub is being built, and off if it isn't. Without pygrub the build of libfsimage can be enabled via --enable-libfsimage. Signed-off-by: Juergen Gross --- V2: - add check for pygrub enabled and libfsimage disabled (Andrew Cooper) --- config/Tools.mk.in | 1 + tools/Makefile | 2 +- tools/configure | 40 ++++++++++++++++++++++++++++++++++++++++ tools/configure.ac | 21 +++++++++++++++++++++ 4 files changed, 63 insertions(+), 1 deletion(-) diff --git a/config/Tools.mk.in b/config/Tools.mk.in index 432d7496f1..b54ab21f96 100644 --- a/config/Tools.mk.in +++ b/config/Tools.mk.in @@ -49,6 +49,7 @@ CONFIG_QEMUU_EXTRA_ARGS:= @EXTRA_QEMUU_CONFIGURE_ARGS@ CONFIG_LIBNL := @libnl@ CONFIG_GOLANG := @golang@ CONFIG_PYGRUB := @pygrub@ +CONFIG_LIBFSIMAGE := @libfsimage@ CONFIG_SYSTEMD := @systemd@ SYSTEMD_CFLAGS := @SYSTEMD_CFLAGS@ diff --git a/tools/Makefile b/tools/Makefile index bbd75ebc1a..311a9098d7 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -18,7 +18,7 @@ SUBDIRS-$(CONFIG_X86) += firmware SUBDIRS-y += console SUBDIRS-y += xenmon SUBDIRS-$(XENSTAT_XENTOP) += xentop -SUBDIRS-y += libfsimage +SUBDIRS-$(CONFIG_LIBFSIMAGE) += libfsimage SUBDIRS-$(CONFIG_Linux) += vchan # do not recurse in to a dir we are about to delete diff --git a/tools/configure b/tools/configure index 44ec7a6477..ed4eb64568 100755 --- a/tools/configure +++ b/tools/configure @@ -700,6 +700,7 @@ EXTRA_QEMUU_CONFIGURE_ARGS qemu_xen_systemd qemu_xen_path qemu_xen +libfsimage rombios BCC LD86 @@ -818,6 +819,7 @@ enable_qemu_traditional enable_ipxe with_system_ipxe enable_rombios +enable_libfsimage with_system_qemu with_stubdom_qmp_proxy with_system_seabios @@ -1508,6 +1510,8 @@ Optional Features: --with-system-ipxe) --enable-rombios Enable ROMBIOS, (DEFAULT is on if qemu-traditional or ipxe is enabled, otherwise off) + --enable-libfsimage Enable libfsimage, (DEFAULT is on if pygrub is + enabled, otherwise off) --enable-systemd Enable systemd support (default is DISABLED) --enable-9pfs Explicitly enable 9pfs support in QEMU build (default is to defer to QEMU configure default) @@ -4629,6 +4633,42 @@ $as_echo "#define HAVE_PYGRUB 1" >>confdefs.h fi +# Check whether --enable-libfsimage was given. +if test "${enable_libfsimage+set}" = set; then : + enableval=$enable_libfsimage; +else + + if test "x$pygrub" = "xn"; then : + + enable_libfsimage="no" + +else + + enable_libfsimage="yes" + +fi + +fi + +if test "x$enable_libfsimage" = "xyes"; then : + + libfsimage=y + +else + + if test "x$pygrub" = "xy"; then : + + as_fn_error $? "pygrub needs libfsimage" "$LINENO" 5 + +else + + libfsimage=n + +fi + +fi + + # Check whether --with-system-qemu was given. if test "${with_system_qemu+set}" = set; then : diff --git a/tools/configure.ac b/tools/configure.ac index 0d1c8f9fa3..618ef8c63f 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -189,6 +189,27 @@ AS_IF([test "x$pygrub" = "xy"], [ AC_DEFINE([HAVE_PYGRUB], [1], [pygrub enabled]) ]) +AC_ARG_ENABLE([libfsimage], + AS_HELP_STRING([--enable-libfsimage], + [Enable libfsimage, (DEFAULT is on if pygrub is enabled, + otherwise off)]),,[ + AS_IF([test "x$pygrub" = "xn"], [ + enable_libfsimage="no" + ], [ + enable_libfsimage="yes" + ]) +]) +AS_IF([test "x$enable_libfsimage" = "xyes"], [ + libfsimage=y +], [ + AS_IF([test "x$pygrub" = "xy"], [ + AC_MSG_ERROR([pygrub needs libfsimage]) + ], [ + libfsimage=n + ]) +]) +AC_SUBST(libfsimage) + AC_ARG_WITH([system-qemu], AS_HELP_STRING([--with-system-qemu@<:@=PATH@:>@], [Use system supplied qemu PATH or qemu (taken from $PATH) as qemu-xen -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:22:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579860.908055 (Exim 4.92) (envelope-from ) id 1qTMfX-000510-Px; Tue, 08 Aug 2023 13:22:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579860.908055; Tue, 08 Aug 2023 13:22:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfX-00050s-Lr; Tue, 08 Aug 2023 13:22:39 +0000 Received: by outflank-mailman (input) for mailman id 579860; Tue, 08 Aug 2023 13:22:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMfX-0003ij-3a for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:22:39 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5282306-35ee-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:22:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5B39821CC5; Tue, 8 Aug 2023 13:22:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 23510139D1; Tue, 8 Aug 2023 13:22:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nhv0Bp5B0mSqFAAAMHmgww (envelope-from ); Tue, 08 Aug 2023 13:22:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5282306-35ee-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691500958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/AHDp091ry1sq7bDUAxHTIgZCYOG8/+0FTmesY5Vjg=; b=bWr3s96eU9z2EIZ5poVBpHPjBxsT1bl4L75UlatOE7GePtIEBAN/IdNR7Y4awTLjIjP2jG iPC/lSTST3X8whr7mx/habJlmb9N6ljaMNFgIMRS6QH/c4wKlPaRTZucEoVnIb4c4bEsik yCHTGz0gx/Ecv18DebFLC/hhRKbfo2A= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD , Andrew Cooper Subject: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled Date: Tue, 8 Aug 2023 15:22:19 +0200 Message-Id: <20230808132219.6422-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230808132219.6422-1-jgross@suse.com> References: <20230808132219.6422-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In case Xen has been configured with "--disable-pygrub", don't accept the domain config option "bootloader=pygrub". Suggested-by: Andrew Cooper Signed-off-by: Juergen Gross --- V2: - new patch --- tools/xl/xl_parse.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 1a5556d3bb..0e8c604bbf 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1692,6 +1692,15 @@ void parse_config_data(const char *config_source, xlu_cfg_get_defbool(config, "acpi", &b_info->acpi, 0); xlu_cfg_replace_string (config, "bootloader", &b_info->bootloader, 0); +#ifndef HAVE_PYGRUB + if (b_info->bootloader && + (!strcmp(b_info->bootloader, "pygrub") || + !strcmp(b_info->bootloader, "/usr/bin/pygrub"))) { + fprintf(stderr, "ERROR: this instance of Xen has been built without support of \"pygrub\".\n"); + exit(-ERROR_FAIL); + } +#endif + switch (xlu_cfg_get_list_as_string_list(config, "bootloader_args", &b_info->bootloader_args, 1)) { case 0: -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:27:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:27:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579887.908065 (Exim 4.92) (envelope-from ) id 1qTMkZ-0006dP-AF; Tue, 08 Aug 2023 13:27:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579887.908065; Tue, 08 Aug 2023 13:27:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMkZ-0006dI-7V; Tue, 08 Aug 2023 13:27:51 +0000 Received: by outflank-mailman (input) for mailman id 579887; Tue, 08 Aug 2023 13:27:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMkY-0006dC-GI for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:27:50 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0622.outbound.protection.outlook.com [2a01:111:f400:fe1f::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e4b174f-35ef-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:27:49 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9773.eurprd04.prod.outlook.com (2603:10a6:10:4ed::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:27:47 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:27:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e4b174f-35ef-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5IN8Ibj612KarmZ85cMngmIlSEj6XMzDxcKsmUJP0lu1HkmTzdloxrfRCCM04Au+Z4yMZcgGtEkoTUzGzRqixBOO//0lWgQTj/DrIQ3FC8yJ3JkT5hLX4Ifqj1HofKsw42Ykg5QTaaq6I1vicUnAQrLZITZz1KtCCJiV87dX5w7HSY5OQLcMlur2Odh8E9ac7Y5pK+9I1Jc+c2PO4V8SO9ChUYBQxV86l9bQuPV1Yj/1uovpxTRI3xIAnD57RgYrp9mAL/Q1YwpNPAmCoiqY2wKGPcNDXeIZW3PXzHh+83YqPou+m78KUUrOPhN51RdzXfPbgZwjRMKAe9E+jut3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p+1bKuDF35nMD+PYNOUpTAuzjL08nbd+vBgymUMmn3s=; b=df5IM0af2Vk9olW5jUUG7X67Q92m0BCNkWVxTIN3KqwrbkxzQnvS8S9JOYovF7rf9c9LC7nBhrccx9bb0P93YN7Sq6VyZ7WqNimBNFvY51UDvkWEAvJX56B0S/znsBPfDkTkUcLd2knTMsfk8ydCAReo0wdLaiUxwCYsDNIVBMpVMriaq8IIzNVGws0ZW3gpsEdCdUbMK7Mba/p+9bqxkeQ31SvrjkvC7hP7c5o0uUoH1ZJzJ0FWjc3P0+WgG77WX0eF6C2RlceI3jHCaDK0HDTekpGDsgwdR14F+BRC/zTZwDwjCHx5bfmzREo2uENtXiY/75a40gEOc1Op6UTu1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p+1bKuDF35nMD+PYNOUpTAuzjL08nbd+vBgymUMmn3s=; b=mJuuHF+xlGVpH/hzVfZdq4N/1GqluVxtq5BWwM/g4S5mycSb7KkF6g6ms4EaZrgK/FslRFa+959VEGzx/AEc0W7HL4mOS0dO2ordQpxqCp8IcIl0VBKZMpqZ7+YOlh7LmxWBLQE0kVqclu6muOciZj+oDlZvXDq3khnfC1IIUOeeZwdrnSiTY727f4nJI5tWVnCM/Ex3MnTxhTONxlqfUUluVzDVtIwvBzPG3v/VHAIFPiCcnKyDRt+zPygN8gsy2BBrEYk0AGaOx87jAMWBCw6FtqtS7EEFK8tFJvJrvb1mXel+Z+/OkkKUziwSLqVxbL383a6cJ3wFwrU0LsrVeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <10f10773-698e-e834-14dc-51477388fda8@suse.com> Date: Tue, 8 Aug 2023 15:27:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v3 2/2] x86/setup: address MISRA C:2012 Rule 5.3 and 8.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <05ff36ef9e1838ac782201998f49f6f56f78332a.1691488505.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <05ff36ef9e1838ac782201998f49f6f56f78332a.1691488505.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9773:EE_ X-MS-Office365-Filtering-Correlation-Id: 83409d74-a98e-400e-f6b7-08db98134157 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xqdZ+54HsLabC+TnsUgVcFdaVCRD3C0wXgQTpXoZbj0cGSC+dylRu2XSLTDt1JmrHu5r0oad7qfe6B4kWqbl3lzByN7vdGtQi7Uqm6PJ4YcW1pP3PF/I56XwlU7kKKWa9aGqVQ35gXXxwkk/TTHFinCPVlEfO+VYyJxqlWZW7AQiRI8YAtt2w/ATkezVPVhc2Kv11KmLfP8CSb+91KC2NEp/66Is5dGpPc1lr0K5V3ohw+1CNz1oAkKAj9Y9DsrrLLaD+RrrmhkmpJ4levC2EjUVn7Iyq9vJS3v5L/Aaa+LvOxJDzBrWFiQwWC4lnac7W9MGmKKU+3t1nx9ewUzypn051KeOfYJ8TqOR4b1OvyTL797YBHdG+ExkcgABB7C4+hPv5fefNRz3omXDOmQDiqFGLV0+hU5AcWFvsmrcAZUJ8zEs3VFIojLn6qLrSWgN4RTHUD3jRin9MZ9BS0D94dAN3X6ghjCrB/PfBNuBBN+TIuO1p/A0iJYZcetzbO7dmOfPrsIhd8twuRBUY22zXSV0ULuqg2HkjIXdVrZiDOUyr5lCrmVQ63er+A3D2/YcdnUlXsanFfX4OyxWhrcNmZKaM9XLey9OqpEbtWpBMRMTj0227O6/Zmpp52MHIfXcfxQkjmIv1tPdyGOXdBxBaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(396003)(136003)(376002)(346002)(451199021)(186006)(1800799003)(8936002)(7416002)(8676002)(5660300002)(6916009)(4326008)(41300700001)(316002)(86362001)(31696002)(2906002)(4744005)(6486002)(6512007)(6666004)(2616005)(53546011)(26005)(6506007)(36756003)(66476007)(66556008)(66946007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T01YeStjbndjcU9mM1d0MWd3RjFNNVFabWo3K2FldjdQNXBlMEtsQTNBdlo4?= =?utf-8?B?MGxObmF6MXNSZ0p0cE1hYmUzWDlhU0R2TGZ1ZFR2NVlPaUJKek9SZ1JsTVVP?= =?utf-8?B?a1FyQS8xVHBqMTN1VC92ZE53bm13NG9LVUo1K0pUekUxbzB3RUlRSHZtMHFM?= =?utf-8?B?elVOM2NTbjhjdEJreXhORTlZTUNJTFAvZ2xNT09JdXZhalc0aWw3YnhjQnpw?= =?utf-8?B?azhlMFcvRW9kMHdKYTBGVGoyOXBndk5aKzJ5aEUxL1hxdUF1UDFhVU1tYThm?= =?utf-8?B?VmVlelRjTGdQeHhmZlJoTUNZenlaSUVScFIzbWhJVHlMM214TXMvVURqMWUx?= =?utf-8?B?QnllNnovZEVaNjlxYmRsMUF4KzVIUWZRc3FpdDRWc1d3c09QZTIwa2dIakFv?= =?utf-8?B?NUNLVmxkVm10b0RHL2NUSDRTMzUyajBoMW1CUmZ0aDEwOVJnVXJVKzVPZlNU?= =?utf-8?B?cWQ1MW9xNnlvQUJVVG81bG9RZDBRQ3U3ZXI2eEgwbzFDbVlaa2YvNXZCUWhz?= =?utf-8?B?cFRYbHlnRVRDckp6Uk5kRkVES0lWNVI3cnBQUjgrZE4wU0ZYVS9ReUxTVFNE?= =?utf-8?B?V0VFVXVzd2RnWUs2blQ4ak9MWHk4T0o0SUFsdUVTa3VJZEt2K0tjQksrajVq?= =?utf-8?B?bE5neDFPaDFqckkvMVp1cHR1K1k4cjJhbUVOUlVHKzl0bDM3ak52UGJFcWdq?= =?utf-8?B?SWlremFmZ25lSm1yeUhPQ0NRRDZDWitFZWh0elFEUVJzcmgzRytHSGhwZ1pz?= =?utf-8?B?ZmE4ZzBGZ2FSVzRuL2R2OEltbjlOWTJYT0NuUDA2ZDY5VE9HRkM0M1ZnWTFw?= =?utf-8?B?bTJSSEsyWnV2REtuTzVsOWtDMUdmaVVYbklIejRkQitENE5YV3o0QXd3MG42?= =?utf-8?B?Z2tZeXJxKzRJVjA2eVg4c2NldW0ySENPL1loclMxb1NlOGRlSW5XZ1huYUdK?= =?utf-8?B?SjFCaVl4bjhIU2VoRERGbWpLdDU0YVh6dHRLSmcvWHFSVmNxeXJVTVNiMnRi?= =?utf-8?B?M2ZzSGZHbER5UTNIRzNSYkt5am1KaDViUEh6VUhkS2s2djFWQTlESVZ5My9j?= =?utf-8?B?ZUZYTk41V3NCL1pOZVFmWG5YMU5RSlVKcFE1MmFzWnMySFJSdlpoRmtIanlt?= =?utf-8?B?bksydkR6NzhYTVdaalFhWE10TUo2UjFWRm1xVGpGZzI2bXVwbzg0dmRlc3RQ?= =?utf-8?B?ZkJkNnN5Z2tWUU1jNlQyTlJqVm00NzZ4dHpjVmV5NmxyL3hRTjQ3cUhGMnFs?= =?utf-8?B?emhUTUdQZ2pvUHRRTFNkWTd1NklqeTNiUG8rRXBxQ2ZRR1RycHJxZEk4M1dy?= =?utf-8?B?Vm9rSlNacHZFcUNqVmdoVjNMbXdoRy9qNTZBNnR4YWlRMTBuSHhkZW5GN3NS?= =?utf-8?B?SHVpd01oNU9GdHNLNFJUWklrNTdadEJDejRuT0Z2NC9JbG9tZGE5U05IeU9u?= =?utf-8?B?NEk3aEd2N0JGMWxYMVlwZ1dRQ2VNdkJuNXhNQ0c4T1AvcXNEdFVQS1ZQNisv?= =?utf-8?B?QmxkL0kyamF1US9qaklhUldWVTdTWHJ2RnU0VVkxdkloSHBuOEdMZkdWcDJD?= =?utf-8?B?ai82TlZ1UTh6Yk9Odm5xZWdtbHVNY0pzVWg1MVBaZ292a3dlemM5ZkhFSkZ3?= =?utf-8?B?RnMvWVpoakNCUXNiNzZ2Z2NKMjN3UHk2M2JsZXRsS2RnRlp0cTUzTmY4RHRp?= =?utf-8?B?KzBDN0FhVmMwSkVoNTh1cWt2L3BESGNUWHlqNWFubUpmbk1iK0ZWcGxBMTc3?= =?utf-8?B?Z3B3U2Zyc3orTklKMHk3MEw5ZEZ3Y0pINFhnMSt6QTZxYit5Y1RjdGVkZzQ1?= =?utf-8?B?R2locmozSnhWRzJBNWF3Z0FEeU1EdDJzbVpxRFhaL1h5NmNuSmMwaUxSNVMy?= =?utf-8?B?dDl0WnBtRUhKUnJhTFZrM09UeitPeFhMYkpLcm54dHhBYkJ3Sk9EVEZtSS9i?= =?utf-8?B?Qjl5R3JsN0R4MzF6RStFT1c5VzNxSGE1M2trWmZ3TnJVMU4raTZRQXBFOGd3?= =?utf-8?B?ak0xZjA0TGpJeEFTeXFETXVHczV0UC8zTmtIT3lydTFWOEl6NWlpbEI3anRP?= =?utf-8?B?cVJHRFdoN2szbkx4Um1QaFdOcWw1bnkrN3l3Ync1NEFiNUFVVVgvT0NsYzBz?= =?utf-8?Q?seHPz7OK2h2xpFAgWn2rWxWCk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83409d74-a98e-400e-f6b7-08db98134157 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:27:47.2252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ++ckueVIMNc/Y4U32RMSvEOC1iO85poyJikh6vIC/sFIr2bJQXjahGahMM06XfaPQ2KmvZs2xjaH6V8da+zr5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9773 On 08.08.2023 14:22, Nicola Vetrini wrote: > The parameters in the function declaration 'construct_dom0' violate > Rule 8.3: > "All declarations of an object or function shall use the same names > and type qualifiers", but also cause shadowing inside the declaration > scope with the variable "static struct file __initdata kernel;" in > 'xen/common/efi/boot.c'. Renaming the parameters in the declaration > resolves both issues > > The local variable 'mask' is removed because it shadows the homonymous > variable defined in an outer scope. There's no change to the semantics since > the last use of this variable is in the scope touched by this commit. > > No functional changes. > > Signed-off-by: Nicola Vetrini > Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:27:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:27:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579888.908074 (Exim 4.92) (envelope-from ) id 1qTMkd-0006sr-Gg; Tue, 08 Aug 2023 13:27:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579888.908074; Tue, 08 Aug 2023 13:27:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMkd-0006sk-Dk; Tue, 08 Aug 2023 13:27:55 +0000 Received: by outflank-mailman (input) for mailman id 579888; Tue, 08 Aug 2023 13:27:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMkb-0006sC-Su for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:27:53 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5fe9dd3c-35ef-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:27:51 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fe1c285690so8763764e87.3 for ; Tue, 08 Aug 2023 06:27:51 -0700 (PDT) Received: from EMEAENGAAD19049. (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id y14-20020a25ad0e000000b00d59ac349fe0sm431377ybi.25.2023.08.08.06.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:27:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fe9dd3c-35ef-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.com; s=cloud; t=1691501271; x=1692106071; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=NoQrogLV9f5a5mnrTdAisY2Um7UDzKxPXcl25SM3U04=; b=eyP5qe/EmJhArZ8mNk+WDiEx+C7k3o3fKsxQt+6X4AH1pbMXedscRsNHyjqufzauIc S4rVGyIDGMhF/0bPOZYcjrUMmwnyPEUVxMVdIhFzIr7e0eSugkeL7S2HiDey0QCPrwsZ x2/1cAVyKIstAHUQK37doSlFLq5SVdN77QLuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691501271; x=1692106071; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NoQrogLV9f5a5mnrTdAisY2Um7UDzKxPXcl25SM3U04=; b=CrZ9ctuqbj5AU4T3Bql2wLN1ODcp6cmShZOEokQi0CqYKTnX3by7LvVeVYrr1rNFvn I7XMbF9XjDTJY+duuHHB/da+yoVbYuhZe2QR8BRcOR6s50EEokPL+ORZpZsEvctbJxzt kOpMnUQFvo6qY5PW2b/GPiBVPIkPgIDQQswBBWcWSRNCG8mIuVk6nsuRVJk7yU3r+TAB mO9QFbW72JdLTrFr0KeLN1bUZr4X9FnyNhE5kb6IqO4KAODDEwAt80+dKP7McsO5dvu2 wY3bwwFxeHTVfqX6KCkTzuEq1FwMna/l+5L9/1DbfLB2YbYiUB5NXOXxTFT59n81e4i/ n3uA== X-Gm-Message-State: AOJu0Yx42cEcHcEkvAbzCTC8iLef89Zg89+tDQFj5sSNOnaSyh/VZw2A WTYtcvNXCH+Ti0cNQXl8/PkeAg== X-Google-Smtp-Source: AGHT+IHYtuFP80fZIYZobFnijetCi53/w7Gpsd2lBsHcrZLuTWwOR76UNvXkTfFTUOoXW3x80WAc4w== X-Received: by 2002:a05:6512:3b29:b0:4fd:faa5:64ed with SMTP id f41-20020a0565123b2900b004fdfaa564edmr10967056lfv.11.1691501271248; Tue, 08 Aug 2023 06:27:51 -0700 (PDT) Message-ID: <64d242d6.250a0220.6b78d.2b35@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 8 Aug 2023 14:27:46 +0100 From: Alejandro Vallejo To: Jan Beulich Cc: Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Xen-devel Subject: Re: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1 References: <20230808130331.27995-1-alejandro.vallejo@cloud.com> <20230808130331.27995-2-alejandro.vallejo@cloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi, On Tue, Aug 08, 2023 at 03:08:04PM +0200, Jan Beulich wrote: > On 08.08.2023 15:03, Alejandro Vallejo wrote: > > --- a/xen/arch/x86/cpu/microcode/core.c > > +++ b/xen/arch/x86/cpu/microcode/core.c > > @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long *module_map, > > return -ENODEV; > > } > > > > - microcode_grab_module(module_map, mbi); > > - > > ucode_ops.collect_cpu_info(); > > > > + /* > > + * Some hypervisors deliberately report a microcode revision of -1 to > > + * mean that they will not accept microcode updates. We take the hint > > + * and ignore the microcode interface in that case. > > + */ > > + if ( this_cpu(cpu_sig).rev == ~0 ) > > + { > > + printk(XENLOG_WARNING "Microcode loading disabled due to: %s", > > + "rev = ~0"); > > Sadly there now looks to be a newline missing. Easy to add while committing, > I suppose, and with it added (back) > Reviewed-by: Jan Beulich > > Jan You mean the missing newline after "%s"? It fell under the cracks while adding the substring in v6. It should indeed be there, cheers. Thanks, Alejandro From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:32:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:32:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579899.908085 (Exim 4.92) (envelope-from ) id 1qTMoz-0000Bh-2n; Tue, 08 Aug 2023 13:32:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579899.908085; Tue, 08 Aug 2023 13:32:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMoy-0000Ba-VQ; Tue, 08 Aug 2023 13:32:24 +0000 Received: by outflank-mailman (input) for mailman id 579899; Tue, 08 Aug 2023 13:32:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMox-0000BU-Nx for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:32:23 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20604.outbound.protection.outlook.com [2a01:111:f400:7eaf::604]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 008e9d4c-35f0-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:32:21 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9232.eurprd04.prod.outlook.com (2603:10a6:102:2ba::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 13:32:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:32:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 008e9d4c-35f0-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ogQO7KvVI/FS5SIg4I1vNsElA8VD9SOHk1NN77XcDSasjaNp+M9DKAsoTRQ6944YrE+lPdGHo5ri7T+D55lmoITb2+lCeDiTlP7IDNBGZIx23Jc7XjGlvLw9l4OMXK67arIUpoeKV2CVlpk21CMXsq2rJCoCUsWg3eTEazJZlMkKSqt0zW4NHZXQY8ffabJklhCg14lsZEpgOGj6RAISS5ZbzBblOubt1rzM74m+nsX2AyovpNEmDS/HFdegw7NGtRdwl1zgtHndgwQYo0olWoyRP6qMuhNRLj5qpCsuGvEEoW7iHy7JBDoQHu2xapIydwkztUHbmnhpGpiLPwZ6Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LS9EXPu1kaxGyZ2rFP39sKzgFC+GHstcRYigC+hlzEY=; b=CCeMbAtQWPBfveboVRndnpdg5Y4omnyAF7Gf35ywPeDUEQH0vbb1CQGxSSFwGjEv/bFoBd6s2c0nl82LBuytkCpVtEwfaQHNHVKTwimh5aYK7HwLMlLEwMdt+B0LLoC0WjV9B2CW9My4iAWTDuDEbUntJKD+T23aSMN3Uz/vs0q/9uw8ZP90TtZxaIsmGFP9YAUDh9KsWiV0H+MAmMxCP+QNBwqytYPcQfSUJTNb4FlHv1meu59vCgkBOSaaqPLsSdn1dODVT1YVDNqfqwfrtkIHVbQh7RHYKmpa5Mwe4ORS0Ehj5zuYdQ9Pff89Icjbt+qLUg7TvdVDm3JwqL7rPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LS9EXPu1kaxGyZ2rFP39sKzgFC+GHstcRYigC+hlzEY=; b=kxxCj/GjOGqjz5+65TmDcV5Zd0C15baa9+ZPqcCL0Dl0Y9pJ1bDNiNLCQxroVBTU1Uh6ioX5byyj2tatSfiLayztJlNwS/4s7VqXb9mTYNLHMFSgnN5uGPtTBDfw8noVHTbKpOYq1Eg+838WR8561RLP0rq0FRcZnRJogQWsadGGzXTN3e0O7qh+L8C8/v+A+muV9R3dEoKE6QVmjDNmXXu8oH5e6UVFTgRCatpLphm/smM7ckidd4AGg8RHSJ/egI1idZIggh4kgLIvGnf2ZQRtiNASfBR+LgsdWCuzzYjbqooQZVx5V0tMioPvizqVH1xHgpFLAaSNSn8B/M2AvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 15:32:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Anthony PERARD , Andrew Cooper , xen-devel@lists.xenproject.org References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-4-jgross@suse.com> From: Jan Beulich In-Reply-To: <20230808132219.6422-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9232:EE_ X-MS-Office365-Filtering-Correlation-Id: f2883185-b653-4f6b-8ab2-08db9813e339 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Xk6lTm+9hIvNPkNYPJTEgWm+J6P92hkEpN1VYjzvOo7/+ggqL0pqfOMGSRvchNKHpzPgZ6BHtVlx7swkXZDzXz8AAMsfABtQmNTxgnX9ooi8+VzPYjfKjCC7YSruOifzk7O4vWxjodxmoRL6U1mR/TgB9hzvawr9ue3CibVVLRQpJQJhHb4jgmPwmj1BCjMMDsH4CXoUL4HGIgFMKOgVkB1DDB7llOqjSSUD0TFwzNJSHyI76qop2RvxPBrCz5Gpt4OCue+0waozRbEQ+5BViAg2qrnn578tyayKf7nyg1rW7SXgm8ReL/Ri1I++5fL3s8cpHm8FDlbhDViACIgsTxqOSPGpYbgrUCBjiPilBx1XEjOd7FzjcpzPhge5ojwbKAuvl/K6HGhLdGB8fuAekpi5waXAcxXsHhwCsNqfs1QAA6+itAgMphuThV7SmxsOmbW9RmrktyLF6/Bd80w76cE/5Nhq8YTm30lbrWwuy5AE7hmDoxdHLbi/hHxjLwuMDPK74bTg3yEIUyS4Byyiu4XI52w19foU3YvEwJa0By6cODbTDPDsllHIMQSggA8WtOl7SD9ZXBbwF635Lx6uO4V546WOzdqTlF72y6n58P1BQLKd+3eUK2MNEsslgpy0tFkiPrqCvI0GYo1DkJkIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(1800799003)(186006)(451199021)(26005)(2906002)(31686004)(5660300002)(6862004)(8676002)(8936002)(41300700001)(4744005)(2616005)(86362001)(6636002)(53546011)(6506007)(316002)(31696002)(66556008)(37006003)(54906003)(38100700002)(66476007)(6666004)(66946007)(478600001)(6486002)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzYrVWdMRWs5SkNTcjcraGRPWEdTd1E5cWJIY3krc0ZheWFmbE9pcVp4ZVRX?= =?utf-8?B?VUtmZ0lwbHJJbG5PL2liVmJzc2gybHpULzhnRUp1a2tHUXJyYXk3OHRpNTFu?= =?utf-8?B?UTZ6V20rVFdDYUlsbklFaDF6L0lDNGl5VHBOUi9Ub281TzVleXVkYTRmbXFm?= =?utf-8?B?MExkaE51RHN2b0JWVld1ZnBOejlucm5iRE5yMWYrUjZ0bWxzUFdNa0p4Q1Zo?= =?utf-8?B?NEJHc3JheWh6WThyL05CRi9aL3VUL2tYNEV4clNhdXIzQmkyVjhEKzB3OXpq?= =?utf-8?B?UTFiTUtjbGxqdG1jTDJEMXpXejFscllZNmg1UCtLNVkxcGxJSmgxTmNWK1B3?= =?utf-8?B?UzJoQk9aSitxQXFaOFcwd3VUTmdlOUJOb2FGaExDWWVmekJBaUJpMm9rWTRh?= =?utf-8?B?Sll6WUFDaUhyeUJYY3hJSDU1LytDQWlGN1ZtUnRFMUp6QkIyVVVEUG5pb0Qr?= =?utf-8?B?N2hTN2tzZHdhVmVWczBmQzRHNTJDbUFKQTk5ak5rYldpR3l1cmo2L1l5V0xM?= =?utf-8?B?dkJCZmJWZzZveG0yRzR3OFB2b1MrYkJhSjVNUFR2VEMwQ1RrMFViOW9HSlpW?= =?utf-8?B?UE40V1pPQkxoeVU1QkJJcGRTREpCUzArSEI4c2syczlVUU1Ea1FRd3JodzVU?= =?utf-8?B?TTJvWUZ3OTFLRUFXMFY5c29UTGpOZGJDVlVtRG4yNWNZcG1WVExraHZYUTV1?= =?utf-8?B?VnhFelRzVlJlZjYrUnJiZHRuRXVVaTQzUnJQaEdZU1B1djI1SUlJaExTRHQy?= =?utf-8?B?QXI5cml6VTl3T0xoQVZTYnh1V0xxQ2hHZVlyWjd2UzhLNjZmZHcybXhMbVNp?= =?utf-8?B?MnFYMzdzRDcvNG84SjhyTVdxbGs2QVE5eFZNdytPUVRNRk9aaEpJK1AxQ01j?= =?utf-8?B?SStBeGFTVlFmdTlrdjJmNWxMeXh0M0Y5K0lLc3ZwMkU4dlcyNVNMMXJLZkl6?= =?utf-8?B?Zjc3YWJ2cjBWSlVUZFJMVnViTngvRisrWC8ybGFQWjl6UGU3bzhZZmNlL2Fj?= =?utf-8?B?cUZwODY5OWJMTHZ1eFJ4bmw3c01vUVN0T2RibDhoMXF6UCtEcnVBSXgwZ1dC?= =?utf-8?B?S09nTHQvT3oydHNWTXFhSTJvc2VKZWtvY1dqdjhkTXZHMGJuQUwxSkxBb29p?= =?utf-8?B?ZFR2UlNEOXk5eHBHOWltYS9yYUNwYnlqWWtuenM3eGkzU2NhbjZpUUhtTzdp?= =?utf-8?B?UTU0MVE2ZENYMWNHbDJuTjJ6ODhiNzNtRm13UGYvTUNrVVRNWFNsRC9sVE51?= =?utf-8?B?R0JWN1ovQ3luU1kwZWJkZFRGYjhad0J6YVN5ZUpBVU9lYS93blJMZTlyRlho?= =?utf-8?B?WTNUOGdFUUI2dGY0TXlhRnJ1S054ZkxvSGJOMFNnT2M3dnZ5cHBVRWRmSG5r?= =?utf-8?B?SVFvQ2FZSFl0N3RGTHd2K2FVM2VxTUEvMSsxMGV0RVcwOXZPVG1kclJKUXpU?= =?utf-8?B?bHhmQlJ0NnRndXhneUx4MkNldUJWT3J2NGY4ZU9VbHBvaWFQTlhwbjlPNTMw?= =?utf-8?B?QXpFdXZIaEJsRVpOL2VWajgyb3FTR2ViNElhTlFrY3NlTVlCajM4ZUFML1I3?= =?utf-8?B?TDlOUDMzNDRSRDBJbkhSb2hXUTB6cnh6QnZGMUhDMlQ4K1ZLKzJoK2hreUdH?= =?utf-8?B?aEVjR0ZsZnFHWVhIcVJsTUpuK0liaDNGVkJXNkRZTVBYTnBJTnZka3Q3bW5X?= =?utf-8?B?MlUyaTR3YllwdHQvOGpwV25EVGc5Qmt0K0pmVHhBaUdvTExIbDFvYlFKNHZR?= =?utf-8?B?RTNONld2eW8xMGlJR3AvOUdRS0xrcHpUWkxMTGRHOVlSSW80YTl5KzUxZGM3?= =?utf-8?B?cnJ5WmNSV1VsQkxqTHJiNmRMUU4zWkdkeEpWWk5RSlNUejVUTjRNQkkxMGZZ?= =?utf-8?B?MS81Z0owQ3RYdHlBS2ZoYVNORE0vd0FqRUhMOEJ1MWRaRzhJUVE3T1JUWGZa?= =?utf-8?B?S1J1OGg0bGJuT0VuZUZRdUlUWGVuZzBibndMcU9lUUV4TitGUVlrd2VSc05S?= =?utf-8?B?eGxmRURNQXNyZUJrbVJsOTN5ZjU3eEtaVk83cHNqRkFZeVNNWk1wb1hBRy9t?= =?utf-8?B?NzFyU1dNVXdJS09oRjBUalNYYVdkeUFaQ21pNkthUWRXRGMwb0RBdkVFNHBN?= =?utf-8?Q?CKYq42ZUKzZFgyprf0MWvPHb6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2883185-b653-4f6b-8ab2-08db9813e339 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:32:18.7985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AdvMXdo2fBcMG8C7ZQUHCvqOOFgINIlIvFK5XzYiDrIL9gLkaahW+CngBzyS5xthr73OnoNG2+8oE69Gdd6Q2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9232 On 08.08.2023 15:22, Juergen Gross wrote: > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1692,6 +1692,15 @@ void parse_config_data(const char *config_source, > xlu_cfg_get_defbool(config, "acpi", &b_info->acpi, 0); > > xlu_cfg_replace_string (config, "bootloader", &b_info->bootloader, 0); > +#ifndef HAVE_PYGRUB > + if (b_info->bootloader && > + (!strcmp(b_info->bootloader, "pygrub") || > + !strcmp(b_info->bootloader, "/usr/bin/pygrub"))) { And no other path combinations can occur? strstr() is perhaps too lax, but what about finding the last slash (if any) and comparing the rest of the string (the full string when there's no slash) against "pygrub"? > + fprintf(stderr, "ERROR: this instance of Xen has been built without support of \"pygrub\".\n"); The other question (I'm sorry for my ignorance here) is whether pygrub could come from anywhere else. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:36:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:36:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579906.908095 (Exim 4.92) (envelope-from ) id 1qTMsw-0000rM-MV; Tue, 08 Aug 2023 13:36:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579906.908095; Tue, 08 Aug 2023 13:36:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMsw-0000rF-Jt; Tue, 08 Aug 2023 13:36:30 +0000 Received: by outflank-mailman (input) for mailman id 579906; Tue, 08 Aug 2023 13:36:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMsu-0000r9-G2 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:36:28 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 929126a5-35f0-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:36:26 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1E321F854; Tue, 8 Aug 2023 13:36:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8A8B8139D1; Tue, 8 Aug 2023 13:36:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +ovSH9lE0mRCGwAAMHmgww (envelope-from ); Tue, 08 Aug 2023 13:36:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 929126a5-35f0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691501785; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0ckaGPw0PFzbyaDdJQH9XsD1EFVVmcqY46PcHTcVJLQ=; b=BUqNRunkAhJF99kz4nyGd48XKDLtdgvqb2x2jtJUnel/MbFHCoWf3AOhxIW+tN4uEcjl5+ 5oXU5C4IZTz6Y1KmuTgSC+Aw1ZgkdamxpAYg6pnBHkuuokHM8ICicMSiE4HQwCzjkFCTQg vZf7DaMeqaycZ27x0AVgq0SH1yjtZYc= Message-ID: <726d0de5-bf4c-1fff-78ea-a52a7c84b635@suse.com> Date: Tue, 8 Aug 2023 15:36:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled Content-Language: en-US To: Jan Beulich Cc: Wei Liu , Anthony PERARD , Andrew Cooper , xen-devel@lists.xenproject.org References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-4-jgross@suse.com> From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------nYerczBihkqmIErMosPxaIm0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------nYerczBihkqmIErMosPxaIm0 Content-Type: multipart/mixed; boundary="------------xJwvjweMnJ3grugNFWNdJYwy"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Wei Liu , Anthony PERARD , Andrew Cooper , xen-devel@lists.xenproject.org Message-ID: <726d0de5-bf4c-1fff-78ea-a52a7c84b635@suse.com> Subject: Re: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-4-jgross@suse.com> In-Reply-To: --------------xJwvjweMnJ3grugNFWNdJYwy Content-Type: multipart/mixed; boundary="------------dmgwq7DJcOJNB2qYbqfUNYNP" --------------dmgwq7DJcOJNB2qYbqfUNYNP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDguMjMgMTU6MzIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAwOC4wOC4yMDIz IDE1OjIyLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEvdG9vbHMveGwveGxfcGFy c2UuYw0KPj4gKysrIGIvdG9vbHMveGwveGxfcGFyc2UuYw0KPj4gQEAgLTE2OTIsNiArMTY5 MiwxNSBAQCB2b2lkIHBhcnNlX2NvbmZpZ19kYXRhKGNvbnN0IGNoYXIgKmNvbmZpZ19zb3Vy Y2UsDQo+PiAgICAgICB4bHVfY2ZnX2dldF9kZWZib29sKGNvbmZpZywgImFjcGkiLCAmYl9p bmZvLT5hY3BpLCAwKTsNCj4+ICAgDQo+PiAgICAgICB4bHVfY2ZnX3JlcGxhY2Vfc3RyaW5n IChjb25maWcsICJib290bG9hZGVyIiwgJmJfaW5mby0+Ym9vdGxvYWRlciwgMCk7DQo+PiAr I2lmbmRlZiBIQVZFX1BZR1JVQg0KPj4gKyAgICBpZiAoYl9pbmZvLT5ib290bG9hZGVyICYm DQo+PiArICAgICAgICAoIXN0cmNtcChiX2luZm8tPmJvb3Rsb2FkZXIsICJweWdydWIiKSB8 fA0KPj4gKwkgIXN0cmNtcChiX2luZm8tPmJvb3Rsb2FkZXIsICIvdXNyL2Jpbi9weWdydWIi KSkpIHsNCj4gDQo+IEFuZCBubyBvdGhlciBwYXRoIGNvbWJpbmF0aW9ucyBjYW4gb2NjdXI/ IHN0cnN0cigpIGlzIHBlcmhhcHMgdG9vIGxheCwNCj4gYnV0IHdoYXQgYWJvdXQgZmluZGlu ZyB0aGUgbGFzdCBzbGFzaCAoaWYgYW55KSBhbmQgY29tcGFyaW5nIHRoZSByZXN0DQo+IG9m IHRoZSBzdHJpbmcgKHRoZSBmdWxsIHN0cmluZyB3aGVuIHRoZXJlJ3Mgbm8gc2xhc2gpIGFn YWluc3QgInB5Z3J1YiI/DQoNCiJweWdydWIiIGlzIHRoZSBwcmVmZXJyZWQgdmFyaWFudCwg Ii91c3IvYmluL3B5Z3J1YiIgc2VlbXMgdG8gYmUgdGhlDQpsZWdhY3kgdmFyaWFudCwgd2hp Y2ggd2lsbCByZXN1bHQgaW4gYSB3YXJuaW5nIHRvIHVzZSAicHlncnViIiBvbmx5DQooaW4g Y2FzZSBweWdydWIgaXMgZW5hYmxlZCwgb2YgY291cnNlKS4NCg0KSSBkb24ndCB0aGluayB3 ZSBzaG91bGQgdGVzdCBmb3Igb3RoZXIgbm9uLXN0YW5kYXJkIHBhdGhzLg0KDQo+IA0KPj4g KyAgICAgICAgZnByaW50ZihzdGRlcnIsICJFUlJPUjogdGhpcyBpbnN0YW5jZSBvZiBYZW4g aGFzIGJlZW4gYnVpbHQgd2l0aG91dCBzdXBwb3J0IG9mIFwicHlncnViXCIuXG4iKTsNCj4g DQo+IFRoZSBvdGhlciBxdWVzdGlvbiAoSSdtIHNvcnJ5IGZvciBteSBpZ25vcmFuY2UgaGVy ZSkgaXMgd2hldGhlciBweWdydWINCj4gY291bGQgY29tZSBmcm9tIGFueXdoZXJlIGVsc2Uu DQoNCkl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIHVzZSB0aGF0IGluIGNhc2UgaXQgaXMgZS5n LiBpbnN0YWxsZWQgaW4NCi91c3IvbG9jYWwvYmluL3B5Z3J1YiAoYXNzdW1pbmcgdGhlIGNo ZWNrIGFib3ZlIGlzbid0IG1vZGlmaWVkKS4NCg0KDQpKdWVyZ2VuDQo= --------------dmgwq7DJcOJNB2qYbqfUNYNP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------dmgwq7DJcOJNB2qYbqfUNYNP-- --------------xJwvjweMnJ3grugNFWNdJYwy-- --------------nYerczBihkqmIErMosPxaIm0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTSRNkFAwAAAAAACgkQsN6d1ii/Ey+y Gwf/YHtbldXkWDfZF65rh+cMUVcRTs6CFKJBgQ6qEdyfEj9iDxrxkTdup13/m2YFlLU7Krp7H54o HkqY4X0eXMHaGM3vSnlb2sahDZqeR/1BOavLAS8gtgj3Ch2WlgjDOLJ/hCIMfjA5G1Qm7t99p58u Pgd29G49ZaCPQxQCA7/NU4ozI5hcXc8bqvBz4SLp67asb6xf7tifpnWWxXcSt5YhcIGKPo+AOOYr hYGkxRKMovHgjiflwxvJtdBnvDiwgXGAebXgarHVoK4k1uZMGS0HBCMMu07DNEpI+AACHSUlyTfD OXsnt7aJnsUibeQ7Hqzazt0lxxkA/cCvxYRZAqY3VQ== =LYp1 -----END PGP SIGNATURE----- --------------nYerczBihkqmIErMosPxaIm0-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:38:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:38:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579911.908105 (Exim 4.92) (envelope-from ) id 1qTMuk-0001RB-2R; Tue, 08 Aug 2023 13:38:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579911.908105; Tue, 08 Aug 2023 13:38:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMuj-0001R4-Vu; Tue, 08 Aug 2023 13:38:21 +0000 Received: by outflank-mailman (input) for mailman id 579911; Tue, 08 Aug 2023 13:38:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMuj-0001Qy-A9 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:38:21 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d584da4c-35f0-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:38:18 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 3442E4EE0737; Tue, 8 Aug 2023 15:38:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d584da4c-35f0-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Tue, 08 Aug 2023 15:38:18 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v3 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 In-Reply-To: <9e5f208e-7419-b16d-c705-592959dc0ea1@suse.com> References: <605687eff99db7181ef6c05bce671e20f194b46b.1691488505.git.nicola.vetrini@bugseng.com> <9e5f208e-7419-b16d-c705-592959dc0ea1@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2023 15:22, Jan Beulich wrote: > On 08.08.2023 14:22, Nicola Vetrini wrote: >> The local variables 'irq_desc' shadow the homonymous global variable, >> declared in 'xen/arch/x86/include/asm/irq.h', therefore they are >> renamed >> 'irqd' for consistency with ARM code. Other variables of the same type >> in the file are also renamed 'irqd' for consistency. > > I'm pretty sure I pointed out that Arm uses a mix of "desc" and "irqd". > So "consistency with ARM code" doesn't ... > >> --- a/xen/arch/x86/hvm/vmsi.c >> +++ b/xen/arch/x86/hvm/vmsi.c >> @@ -281,7 +281,7 @@ static int msixtbl_write(struct vcpu *v, unsigned >> long address, >> unsigned int nr_entry, index; >> int r = X86EMUL_UNHANDLEABLE; >> unsigned long flags; >> - struct irq_desc *desc; >> + struct irq_desc *irqd; > > ... require e.g. this rename. As mentioned before: Let's limit code > churn where possible, and where going beyond what's strictly necessary > isn't otherwise useful; there's already enough of it with all these not > really helpful Misra changes. > >> @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry >> *entry) >> >> int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t >> gtable) >> { >> - struct irq_desc *irq_desc; >> + struct irq_desc *irqd; > > This one indeed wants renaming, but then - consistent within the file - > to "desc". At least that's my view. > > Jan Well, but having struct irq_desc *desc; struct msi_desc *msi_desc; and then using them both within the function doesn't seem that readable, but if you prefer "desc" I have no objection (just two local variables that need to be changed). -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:39:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:39:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579917.908115 (Exim 4.92) (envelope-from ) id 1qTMvk-0001z6-Ao; Tue, 08 Aug 2023 13:39:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579917.908115; Tue, 08 Aug 2023 13:39:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMvk-0001yz-86; Tue, 08 Aug 2023 13:39:24 +0000 Received: by outflank-mailman (input) for mailman id 579917; Tue, 08 Aug 2023 13:39:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTMvi-0001nd-NT for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:39:22 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f99ed504-35f0-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:39:21 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f99ed504-35f0-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691501961; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9JMjH+v1dEhayh9NSbcXKavTJC0JEFjd/xZ2S7oZ0Qo=; b=c4C8ycuFJf7RlCfwiJpfTA1mysrN7+wSXHdelUffabzPWQM6N50/Pd4k S3bDwAN1YwIeZwhdwjfhxWKF+fE+kaaxsWbBl+UYY3c1vvo31Y8EDdfYZ b4RjtRyKP99fRtfQqme/ZKtED5S2LC+WZLL4H7CXBV6hXvICyNKVR+BMs Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118870632 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:V5V9Gqo5QsA6bNdPmkAFd/MU/OpeBmI+ZRIvgKrLsJaIsI4StFCzt garIBnTPa2OYmKgct5+O4vk8hsEupDSx9NhTFNvqSAyF35G9puZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOzylNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACoGUAGyo8Sm/Le+QMdSqpUTL/moZ7pK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jufrzSmWk9BbrRzzxK54Civ27DDlx/4UbIrMvqf1tJBuXKMkzl75Bo+CgLg/KjRZlSFc9BQM UsP4QI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ5sOcmSDps0 UWG9/vgHTF1uaeZYW6c/LyT6zi1PEAowXQqPHFeC1Ffup+6/d9110iUJjp+LEKrpsf+JyDB5 xaakC07jZstoZ871JX4pmmS1lpAuaP1ZgIy4wzWWEes4QV4eJOpauSU1LTL0RpTBN3HFwfc5 RDoj+DbtblTVs/VyERhVc1XRNmUC+C53CowaLKFN70o7HyT9nGqZui8CxkudR4yYq7oldIEC XI/WD+9BrcJZBNGjoctOepd7vjGKoC+fekJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yXC9GUv89nWbmHrd1PVoXKscWnzq7eHwG507/jer2iIC9Ft/pz2dinshmtfjZ8W05A v5UNteQygU3bQENSnC/zGLnFnhTdSJTLcmv+6RqmhurflIO9JcJV6WAntvMuuVNw8xoqws/1 i3hCxYHlQeu3xUq62yiMxheVV8mZr4nxVpTAMDmFQ3AN6QLCWp30JoiSg== IronPort-HdrOrdr: A9a23:nnY7KKutZkHtMDEM7668U4dD7skDTNV00zEX/kB9WHVpm5qj5q eTdZMgpHzJYVcqOE3I9urqBEDtexnhHP1OgLX5X43MYOC8ghrNEGgK1+KL/9SHIUDDH4Vmu5 uIHZITNDVeZ2IK6/oTTGODYrQdKHjsytHMudvj X-Talos-CUID: 9a23:al8m1mCXpTrEkuD6EzNsyl8lPuY1TnjYxlnuDx6IClYqE4TAHA== X-Talos-MUID: =?us-ascii?q?9a23=3AibQmAw9ze2AHv8CTgkeOY3+Qf/t6uafzV0wHrZY?= =?us-ascii?q?Pi/CicgtQFxykoyviFw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,156,1684814400"; d="scan'208";a="118870632" Date: Tue, 8 Aug 2023 14:39:09 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH v2 1/3] tools: add configure option for disabling pygrub Message-ID: References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230808132219.6422-2-jgross@suse.com> On Tue, Aug 08, 2023 at 03:22:17PM +0200, Juergen Gross wrote: > Add a "--disable-pygrub" option for being able to disable the build > and installation of pygrub. > > There are two main reasons to do so: > > - A main reason to use pygrub is to allow a PV guest to choose its > bitness (32- or 64-bit). Pygrub allows that by looking into the boot > image and to start the guest in the correct mode depending on the > kernel selected. With 32-bit PV guests being deprecated and the > possibility to even build a hypervisor without 32-bit PV support, > this use case is gone for at least some configurations. > > - Pygrub is running in dom0 with root privileges. As it is operating > on guest controlled data (the boot image) and taking decisions based > on this data, there is a higher security risk. Not being possible > to use pygrub is thus a step towards a reduction of attack surface. > > Default is still to build and install pygrub. > > Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:46:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:46:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579925.908124 (Exim 4.92) (envelope-from ) id 1qTN2d-0003Ty-1M; Tue, 08 Aug 2023 13:46:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579925.908124; Tue, 08 Aug 2023 13:46:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTN2c-0003Tr-V2; Tue, 08 Aug 2023 13:46:30 +0000 Received: by outflank-mailman (input) for mailman id 579925; Tue, 08 Aug 2023 13:46:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTN2b-0003Tl-AS for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:46:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8166ebb-35f1-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:46:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8166ebb-35f1-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691502387; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QhRcYhG/lkFwGKf2f9TvUdQxSdlBQ94FWwsoAVwZKdw=; b=SJlHuqRz3yAIwYPG/UVKbSpswD/0otlk24boroQjXPSdqp3yHzyUVv5T vyKwn264VTdB84divNCtFbMwlB/mJQdTUtz88Tf4r+KPRpwrvcr7aqjHQ c8/xEVdS4G7BOn3wHaWUxJ8OAYrbuqBpVIGsCVEaOqOLtCoiQlIg2PxEM M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 117538111 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:IHateKIR7qz5sK8KFE+R95UlxSXFcZb7ZxGr2PjKsXjdYENS0GYEm jdLUWqHO6uNZDahKd11Po2z9xwCu57WyoQ3TQBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRuPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5KKG5Uq +IXCQwBfzS6veXuxbaDdrFV05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpNU6bC/FMEg5/5JYWleG0hn75YntApUicv6Yf6GnP1g1hlrPqNbI5f/TTHJoIxRbB/ zuuE2LRHR85F9KN6T+/9neRtrHlrSrLB6FJLejtnhJtqALKnTFCYPEMbnO5ruO+kVWWQM9EJ gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xGWwsXjNHLts8u6ceTCQnz FaTk/v1BDZkt/ueTnf1y1uPhWrsY25PdzZEPHJaC1JfuLEPvb3fkDryZ9l5TrC6r+H5CBXJ+ TfSqSwGu+0q2JtjO7qAwXjLhDelp57sRwEz5xnKUm/N0j6VdLJJdKTztwGFsK8owJKxCwDY4 SNaw5T2APUmV8nlqcCbfAka8FhFDd6hOSaUv1NgFoJJG9+Fqy/6JtA4DN2TyS5U3ic4ld3BO he7VeB5vsU70J6WgUhfPeqM5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/BmZ czAK5fwXS9KYUiC8NZRb71EuYLHOwhknT+DLXwF50vPPUWiiI69Fu5ebQrmghER56KYugTFm +uzxOPToyizpNbWO3GNmaZKdABiEJTOLcyuwyChXrLZc1UO9aBII6O5/I7NjKQ5w/UMybqVr yvVt40x4AOXuEAr4D6iMhhLAI4Dl74lxZ7nFUTA5WqV5kU= IronPort-HdrOrdr: A9a23:wBs8vq6sk+rPYcCQewPXwPLXdLJyesId70hD6qkmc20zTiX+rb HMoB1773/JYVkqM03I9errBEDiexLhHPxOjrX5Zo3SODUO0VHARL2Ki7GO/9SKIUPDH4BmuZ uJ3MJFebvN5fQRt7eZ3OEYeexQpeW6zA== X-Talos-CUID: 9a23:u8t7L29F/PmIdP5BfGOVv3M9Fdp7bHL88HvBB3aCDj5sTIWpEWbFrQ== X-Talos-MUID: =?us-ascii?q?9a23=3Ai/ljXg5IsYpVCZjD7SNCq9x0xox37YeNBlItlK8?= =?us-ascii?q?CvvS0awZAMgfCr2+OF9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,156,1684814400"; d="scan'208";a="117538111" Date: Tue, 8 Aug 2023 14:46:12 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH v2 2/3] tools: add configure option for libfsimage Message-ID: References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230808132219.6422-3-jgross@suse.com> On Tue, Aug 08, 2023 at 03:22:18PM +0200, Juergen Gross wrote: > The only in-tree user of libfsimage is pygrub. Now that it is possible > to disable the build of pygrub, the same should be possible for > libfsimage. > > Add an option for controlling the build of libfsimage. The default is > on if pygrub is being built, and off if it isn't. Without pygrub the > build of libfsimage can be enabled via --enable-libfsimage. > > Signed-off-by: Juergen Gross Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:47:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:47:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579929.908135 (Exim 4.92) (envelope-from ) id 1qTN3F-0003yD-AP; Tue, 08 Aug 2023 13:47:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579929.908135; Tue, 08 Aug 2023 13:47:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTN3F-0003y6-6u; Tue, 08 Aug 2023 13:47:09 +0000 Received: by outflank-mailman (input) for mailman id 579929; Tue, 08 Aug 2023 13:47:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTN3D-0003u6-QS for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:47:07 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20623.outbound.protection.outlook.com [2a01:111:f400:fe13::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0f932adc-35f2-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:47:06 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9884.eurprd04.prod.outlook.com (2603:10a6:800:1d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:47:02 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f932adc-35f2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1m968OiRp76HrSj7ITHPRRVgVOs+H0dWMw8gUvnKVTfdtiwoA7lzdUFh4DIyTC5CZ1ArXgty2oCFR5hwluXSSDa2mvgD7yWwgUrqfVUHQfhTaImh6Y909CjLZfBov+EEbF6t2CqetQPUo4+GFVDL1L40BeRaJsI0Zkc6KQdkwEVoKLsGXLykX+2E0q2+vDOpyGM+vYRfQxzCj1BRMAaUUWA2x588Fj8or5BSXzUCDl5SehU2mywLTW273KOo7xshqVV3Fg50HdNrcQCy+G4ZirFNn75JMEj6U5rlONzVt9YEI7T95FH6HuqxcCdvM+WIhaylWIhe3WJmbH+VaNc3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GL8Pm/P4/zQxUN8Cll8FWmPW6DZ35OKVjXUR9OfSrZ0=; b=n5DhyErNsY+xiSsNyOHz8CHn1qsgLChxcfcOb7LYc/z09jmzX3OuzBXMRKhznrmeSKWm3/J095hK/eeznyV2cF43eY6+ZSH7nlsc6nEye66oRIQmFMRSH9FGYx1XtMnU1tGaWz2TWZdRO5ZBGhoJ/i8iXhtIr2Ns2Hg4RSyhH8ZVGiCMMPDX5mvPtjB0DvvumgZ+qwdw3EEjPC8ykocFoDpRCK2IT5JUtYJg0GSP6kIYHDrV7jmdijRHJW/NrzQc15VD8o2bDoYEhLLwshxODuTf55M+yEvhM8rnvuu6saGzRcLlqHoSpfZkhaUeMtUW5AeR6EENnpaCZOfthaUInA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GL8Pm/P4/zQxUN8Cll8FWmPW6DZ35OKVjXUR9OfSrZ0=; b=cUhMl7s8u4hFJS8b8ZPEJLqccqE4q4cJEHrKFwaMBbTLgu/2uxts49p4LKQCx/xgrOIL3AyXgNKe39TOpfKYoI/zCi/dT/oQns84ErcUd5vXbYGESayxZuhHvuANJ0nlWdvQGryRMh44wwwXnG6g7a+P92SG9JjRME+yt0rrk4cDDeSFyFQT8qC4XgiGVqnxT+yuY3GkAwoOQVR0sBUCm5i50vVA61fEowXtvCTvpbTgc5caC5x4gNcyFB8Dd15bXh3heMfImkRanIe1uTMuSe9Bsv4mau3x9t8oV3Fvo3IUXzMfgyCEsRDRLo2jrJb+OoM/sDmfMQNer4C2Hj50vw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 15:46:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 1/5] x86: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <3a9db416c6f8b2d5a549d49ff02238eb408cc905.1691492441.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <3a9db416c6f8b2d5a549d49ff02238eb408cc905.1691492441.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9884:EE_ X-MS-Office365-Filtering-Correlation-Id: 33633e7f-0651-4cca-2cac-08db9815f20b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7Sjr5r3Rp668gmoZMy6yYulMMee/4vWA3HyRr8cTTVgKXA9QXZI5PdtxNtBtjPjYbJP+RRfwI4SFuR/FBzxJBR2F1WPlZXB1zj3tsdrAPv+XJz9+KVuTCRVoKuGdoCwXv4nXGiY+exTdHvIRym0h1vj2gvLyq7CkRDrrp3oWvz1VcvPPCOfJvjJ05tEo7grgSuCxpdxM6XmbCawxNQ39NXQu7Mat6mBW/yeIoc6QxC2KBmY7Gf0GPHhiA0UPSa0Z91lJLFYvn/Am1tCAAttDDUwPSBDFC+Zhwum9bzJfrBEETP75BaLHOwkGuX9D52kwPffVjhUW8syoUiwLkS+kApUaT7UHyv6VaImu5p01IIMSZPAAk9bGTq55ZAgVTEdsO7BOiqFdtaf3YQCI3r4AgCowSCSi8QxyHZi2cE7yC1DMk9I+0s14/A22GRqIWoxiGNc63yJZuRgpL5jmyaFZsohmFINsVLm2V9Gj4Sh2bXOeZ09YnJ6NJxsZFgZNz7OZrr9aOqMasVSFiDPwfTCug99ououaZ/h44vRzcpScr/PY0Py9zc6ZH9ToMBe3nwu46hODe+yMItcIz576thO3EIm+tnRLxZtl1QSAPSWW91/eRzdlzvGTY5gXKiThVWJxNHdLNQjbrzCkY7kE91LYrw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(376002)(346002)(396003)(1800799003)(186006)(451199021)(478600001)(31686004)(6512007)(86362001)(6486002)(6506007)(66476007)(26005)(6916009)(66556008)(66946007)(53546011)(4326008)(38100700002)(54906003)(6666004)(316002)(2616005)(66899021)(41300700001)(2906002)(83380400001)(36756003)(8936002)(7416002)(5660300002)(8676002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHEwOTBObjJvSkJWOTE5OUErVlhWcUlzTmR0OWxBc3o3UGp0Q3VJNmpoazlK?= =?utf-8?B?RUNwNXVlS3RUY3ViNzNBa0JDTmRqM3RUMStYRk92ZXp4VHNpWU9EVFZ6UjJL?= =?utf-8?B?d3YvZU9HQStFMVduemp2NjRVQ0RIditiQmd1c2J3NjdFM1VGUHpGTnpLRXRT?= =?utf-8?B?bUg5OUpCUnl1R0JNZ0ZQdUx5S1hWT2lEeTBuSEc5cSsrZ3g1K1VXZTArdkFx?= =?utf-8?B?V2dBWmlTMUhWTDFiRVVQdUE0VndMdDcrR1BnVzZoQ3lyZE4yTk5lK251V1kw?= =?utf-8?B?K1VaYzRCZnVQNnh1bmtqZXFiM3FiOEFzcEs2aUVSelIyaU12Rm9tN3RUTG5R?= =?utf-8?B?eVprNXpUeVV2b24wODhQU0xsdXRCS3MyNVpoTmZaai9VeDNoUFBMSS9tenhh?= =?utf-8?B?akE0S2MycFA4N3BEUzhydEVKdFljMzNraGdodDFXM2k2Syt4T1ZDSHRmQnV1?= =?utf-8?B?MzE0TkU1bFR0TSt5NzREVnhIelVZYTFrMUQ1c0svejQ5RDZ4TlpzdkRUeE0y?= =?utf-8?B?blBlcjBlNU5KTWlTZzloUHkzUkhnUUNCWkJ5QXJyeWZyL3laak90K3dkcHd5?= =?utf-8?B?UHpiSFZ2cDlZcnJPR2U2bUlYcTJPY08rWmw3eUJ2NVBxRmU5WXR2TmpacDZa?= =?utf-8?B?bkhQYnIxQkRLdkNFdFJTQVhKR2FXNlZ5Tlc4N0tDbmhlZU9XNno3NzJLNHZU?= =?utf-8?B?cndRMkhxTzBKMERObFF6eWJxYkx2NzZSRjZlMGVlN2cybnNzVGZNeDcrZ3pY?= =?utf-8?B?bUNXWXJoVW5qV2lkUE5WeTdCcE03ZEk3b0JpaTIrbCtSUHpPR0lRRzlJL3Fp?= =?utf-8?B?NnZvenBRLzNEam5CcU15MHFIbFRETFBteUthTmdCSHhXdkZjaEpDLzZ4T1lG?= =?utf-8?B?MGR5c2trV0l2d1NsVGVLbHdhR1B5ODZlbUNrQ1c2c1RQdi9QVmdxdCs1ZjhL?= =?utf-8?B?TkR0Z1Zjc3l1ZHczTnlxODNiZElOWWwrUVh3ZTVMYW9xSnpVRXA5WUwvR3d0?= =?utf-8?B?YkNVV2lZVE40SGUrRUdnQ0F3eEhTSkNuOFpPWE9HK3YrNXZ5dmVIRFhYOWZQ?= =?utf-8?B?QlY5ZVcxaDViVWZDbHRqbDJBaXFDa3VldVJtVitaMmJjaldJN08vVU9OYVFz?= =?utf-8?B?RWVnWkdTOEV1MWFJbXgzZXZIV2tENWtoaUpMWnVCQ2taWjJ2TE52b2x0RG5u?= =?utf-8?B?R016cGNQSGNvUm5udzJkNmpOVHBldlYxenVCSHN1ODJLdWQyaEdmbDNXeXY5?= =?utf-8?B?a0FFYVNKY01iUlpMZ3N0aC95UnBveDN3MVQvKy9EYjlmRkpvWlo5dDZGNTBv?= =?utf-8?B?YXcxWjh1MzNhM0JUb04rUmxXNnRxSk1rNmVEK2lYTml4SEJ5cEYwWUxqZVA0?= =?utf-8?B?S2pzS3gxYmtVOVUxN0x1aTYvM0NHdWVCVEEvU1FnOEoyRWdEeUhqMExzNEJF?= =?utf-8?B?WkFEOWNKSzFIbFc4WHJPMmRyT3BNY2hFOXdQK3FoSWV2WU1vSHluTEJpdkN5?= =?utf-8?B?clIyeCtDWEpDMlJrR2QzVytDMmhtYmdPNURiTEVDbGJqN3M3RFFxbHVYZ3A2?= =?utf-8?B?SjRyeUI2anRQbWlxUUZtOHVNUmJvU2Ewdk15VkwrbmRWZWdXTjVIUXZQd1NN?= =?utf-8?B?ZE00YnJxcHZuU0xYdy96ZjE0dDFKbHVvWklLUyt3SW5sRTZMOWNiU2REeEln?= =?utf-8?B?R3ZrOFJ6cDFXbkp1SFJ4aDVWODl4QVp4MFdHYnFZYnhPUWJSblZEbnNFQ3BB?= =?utf-8?B?U2NFLzJYemJwZDIzZnp6cFBCYWprUVRLTkg0aHFwMDAyWVViM1pPMGEvczh3?= =?utf-8?B?UXlqakdqaE9lOXpnME9KTVhUK2xZcmlJcDBCSjd4djFZR01OVGV3QmpMNFJa?= =?utf-8?B?TkJ5S1Q2L1ZNdDd6SVBGcmVJOStjOVBtR2J6VTA0aHFFU0RaT3pxQUNLTTZj?= =?utf-8?B?SGFVL1cxNmFndWpJSm4rNDdQWGpmeloyN1JoN2FpMTR6YkhYYXFYVHV0OU51?= =?utf-8?B?Tk5VbGRRU2prU256RzRxLzVmYzh2bFpCdUxueXNxMkhGNnNTU1l3QXpYR1J4?= =?utf-8?B?WFZJU2cxcHF5eHI2bEZkVit6aDY0L2FEU0RuemF2Tlh2QzhqekY5akR1elYr?= =?utf-8?Q?Koz9ZrhGD3DFAFpaIKzRlbtE6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33633e7f-0651-4cca-2cac-08db9815f20b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:47:02.6581 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mt5GbH9y616r/puKuYTdaE/QwhKOVt9ymT1L5vf1KCvpztFrbhf6eLtbmmG+S2gQXBYfnNVPAiw/6tbP2w3ZLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9884 On 08.08.2023 13:08, Nicola Vetrini wrote: > --- a/xen/arch/x86/e820.c > +++ b/xen/arch/x86/e820.c > @@ -543,27 +543,27 @@ static void __init machine_specific_memory_setup(struct e820map *raw) > clip_to_limit(top_of_ram, "MTRRs do not cover all of memory."); > } > > -/* This function relies on the passed in e820->map[] being sorted. */ > -int __init e820_add_range( > - struct e820map *e820, uint64_t s, uint64_t e, uint32_t type) > +/* This function relies on the global e820->map[] being sorted. */ > +int __init e820_add_range(uint64_t s, uint64_t e, uint32_t type) > { > unsigned int i; > + struct e820entry *ei = e820.map; > > - for ( i = 0; i < e820->nr_map; ++i ) > + for ( i = 0; i < e820.nr_map; ++i ) > { > - uint64_t rs = e820->map[i].addr; > - uint64_t re = rs + e820->map[i].size; > + uint64_t rs = ei[i].addr; > + uint64_t re = rs + ei[i].size; > > - if ( rs == e && e820->map[i].type == type ) > + if ( rs == e && ei[i].type == type ) > { > - e820->map[i].addr = s; > + ei[i].addr = s; > return 1; > } > > - if ( re == s && e820->map[i].type == type && > - (i + 1 == e820->nr_map || e820->map[i + 1].addr >= e) ) > + if ( re == s && ei[i].type == type && > + (i + 1 == e820.nr_map || ei[i + 1].addr >= e) ) > { > - e820->map[i].size += e - s; > + ei[i].size += e - s; > return 1; > } > > @@ -574,20 +574,20 @@ int __init e820_add_range( > return 0; > } > > - if ( e820->nr_map >= ARRAY_SIZE(e820->map) ) > + if ( e820.nr_map >= ARRAY_SIZE(e820.map) ) > { > printk(XENLOG_WARNING "E820: overflow while adding region" > " %"PRIx64"-%"PRIx64"\n", s, e); > return 0; > } > > - memmove(e820->map + i + 1, e820->map + i, > - (e820->nr_map - i) * sizeof(*e820->map)); > + memmove(ei + i + 1, ei + i, > + (e820.nr_map - i) * sizeof(*e820.map)); > > - e820->nr_map++; > - e820->map[i].addr = s; > - e820->map[i].size = e - s; > - e820->map[i].type = type; > + e820.nr_map++; > + ei[i].addr = s; > + ei[i].size = e - s; > + ei[i].type = type; > > return 1; > } To be honest this isn't quite what I was hoping for; the many ei[i]. are (imo) quite a bit harder to read than ei-> would have been (hence my earlier suggestion to also update that pointer in the for() loop header). Then again I see there is one use of ei[i + 1], which would likely look less neat as ei[1].addr when everywhere else we have ei->. So I guess up to you whether you adjust further; I'll ack either form. > --- a/xen/arch/x86/guest/hypervisor.c > +++ b/xen/arch/x86/guest/hypervisor.c > @@ -63,7 +63,7 @@ void hypervisor_resume(void) > void __init hypervisor_e820_fixup(struct e820map *e820) What about this one? The function parameter ... > { > if ( ops.e820_fixup ) > - ops.e820_fixup(e820); > + ops.e820_fixup(); > } ... isn't used anymore, and the sole call site passes &e820. > --- a/xen/arch/x86/include/asm/e820.h > +++ b/xen/arch/x86/include/asm/e820.h > @@ -29,8 +29,7 @@ extern int reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e); > extern int e820_change_range_type( > struct e820map *e820, uint64_t s, uint64_t e, > uint32_t orig_type, uint32_t new_type); And what about this one? None of the other subjects in the series suggest this is then taken care of in a separate patch (as per the earlier discussion it indeed doesn't want dealing with right here). > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -686,7 +686,7 @@ static void __init parse_video_info(void) > #endif > } > > -static void __init kexec_reserve_area(struct e820map *e820) > +static void __init kexec_reserve_area(void) > { > #ifdef CONFIG_KEXEC > unsigned long kdump_start = kexec_crash_area.start; > @@ -700,7 +700,7 @@ static void __init kexec_reserve_area(struct e820map *e820) > > is_reserved = true; > > - if ( !reserve_e820_ram(e820, kdump_start, kdump_start + kdump_size) ) > + if ( !reserve_e820_ram(&boot_e820, kdump_start, kdump_start + kdump_size) ) > { > printk("Kdump: DISABLED (failed to reserve %luMB (%lukB) at %#lx)" > "\n", kdump_size >> 20, kdump_size >> 10, kdump_start); > @@ -1308,7 +1308,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > if ( e820.map[i].type == E820_RAM ) > nr_pages += e820.map[i].size >> PAGE_SHIFT; > set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); > - kexec_reserve_area(&boot_e820); > + kexec_reserve_area(); > > initial_images = mod; > nr_initial_images = mbi->mods_count; > @@ -1495,7 +1495,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); > > /* Late kexec reservation (dynamic start address). */ > - kexec_reserve_area(&boot_e820); > + kexec_reserve_area(); > > setup_max_pdx(raw_max_page); > if ( highmem_start ) Seeing all the knock-on effects for the add_range() change, I think this separate adjustment would better have been an independent patch. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:52:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:52:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579938.908145 (Exim 4.92) (envelope-from ) id 1qTN8A-0005YJ-1Q; Tue, 08 Aug 2023 13:52:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579938.908145; Tue, 08 Aug 2023 13:52:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTN89-0005YC-Td; Tue, 08 Aug 2023 13:52:13 +0000 Received: by outflank-mailman (input) for mailman id 579938; Tue, 08 Aug 2023 13:52:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTN88-0005Y6-Q5 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:52:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20631.outbound.protection.outlook.com [2a01:111:f400:7d00::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c573dc44-35f2-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:52:10 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9884.eurprd04.prod.outlook.com (2603:10a6:800:1d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:52:09 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:52:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c573dc44-35f2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeyeqAqps5nXJzmEDroH6FpDAFEv2s06tmZ4fUbu0wa/TU30chMojI5ubWinO+yOo7vmpPFLFHtZ1K5KicFSes05xdXF/HjBhMrDLzqtIuHFcpdb7doGbfDtZkam3jGGMfUHLkblfO8cTTN03PqxmjlsJi7EClV8BMgGGuZ2uq5fKRxuz5ISlBhSyelGGu/cF6bEIH3EoFgzlfKPIlXPuDb3DVn/ipIkwOXIJWS6gEnpNynCiaav8ZqG13rxFXCrIyD5gVkwtwqQeywWZCEs1oFmuit6X/5hpgzcvhed/buVKVycGXqGYLEnaMfOlJY8Rsawmd7mkc7NuyGSFGnIKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GoCjWo1H3Dimg14cyPXEhhyFcvBL1Snduz8ZBJpjG5U=; b=N39+nOlYKqNRg/XSM0PscQZbhhjNievJEQTHFvdPZDm5b9aNvkOEPIprKbV1HGRvUdukj5+MZ/oyrS4bz+ounmPplNQRclgBd11YW+b1OQshdVKLDcyYcE61mZnh4jkXsNOyFER7R0AJI3lAspqVx2Q5YNdWqCXGiW7vpOBNH8kwUujcYycW+UKvBjOMmeZLDEeq9RkLyJiTTtHMsAP6fGYvmNiNGu3x+/MUJr3R7RgU0wB6BNSsK2RHa2hMaOu0nLYzxHgRTX9kFhKG/Nxnuh2jFfhz9VpU3C6LIRIsG+bwYeE9pVdHJB4uXU7KlgrfEYjGsmOHdFFe/toZpN44vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GoCjWo1H3Dimg14cyPXEhhyFcvBL1Snduz8ZBJpjG5U=; b=Zi3ZsZTfi4dNgn1rz3HinGh5jfz7EkQ6uyCbMmnbPlAarAYuVYqbp230Dp0HEUNDGqHk5n+Y7/l7fj76Uccv4VokZhek5XuOOxzHqPbvE95zOFgC1wRR2OdyKo1ZZGT7BMYmuffZJpeLrGjzkkqiQ7SqwZzytCDLHwXdyM4iOr2vg/jmHw1muD/FuDlA2bPkaqAjAc7MIxBHt/rr6DtlM2yFiVJ4HbGATZvAQuzTWZNUEqiyznIcadDaMT3dHfqIQmkS/HL/gKLUW1Ui3XN6WZAUKN54MnEOFZItNnk4YMOlZ1Ocub9POutUuAP0Wu7HlvRaAZYtUQJtVZArnYfDAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <250d3d77-9668-eac3-172d-5a0e50d33070@suse.com> Date: Tue, 8 Aug 2023 15:52:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v3 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <605687eff99db7181ef6c05bce671e20f194b46b.1691488505.git.nicola.vetrini@bugseng.com> <9e5f208e-7419-b16d-c705-592959dc0ea1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9884:EE_ X-MS-Office365-Filtering-Correlation-Id: e3edd54b-36bb-4190-e99e-08db9816a8b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J7oE+aD4In7IsNmT3+zEWJTgSDpjCEQjIndUVauuakXx9uTPb2xW/BY0f7Jz6Mg+03olhv4mljTVNhe9MUKDjWrhLkbWj7Fbf/u5DnrJTX/KmFixiJ3ihpgjggnJJyavvgxahRr2c/MUfn2VrDULal2ecY+GlyhnQHKNqQ88wYQYInxnuWa0VVPfRbtiFQYrtz3g02suqR1fMY6yAEs5QfdgEK6AVfrG24nmtJoNxT9q3YIJJM74LsBVNwi2Pf9FweoaBBLXN/rRmYPKRw0fZ50jmNTBJg2Hsskex0dfOJplPD7MLJ4g+Qi/C4IS1Cri+VDtezgkGn6PUUdRRuJQcfzkrJL/xPpHo8Son3WykTB6QSreIqQLjKzjiwHhpa7f9JBbCSj8/8yTAlz8OElm1jdZj+vWmLEVRKjXEmbPSNFuBflGuEKV3e1KByTy2Udqh/mkjK4RyNkz9WYERZ+IWrqJV8psfwGBc1AW8vFCRjrMl2t6QUPj2tpdteV5qrdFA9u8bsyYCRIZXPHhzPk/y0MD6zYHebwdbyDF8BMFjxuMOuR+hqMIRN80XqSFEQRtebX20RmP0xuN0sRnVwpt22WwyWd3qdFk6mwGQnAtf17QrGCX6H1240ncLa+Xa2SViXv3krjjqwF9xuRNvZSFnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(376002)(346002)(396003)(1800799003)(186006)(451199021)(478600001)(31686004)(6512007)(86362001)(6486002)(6506007)(66476007)(26005)(6916009)(66556008)(66946007)(53546011)(4326008)(38100700002)(54906003)(6666004)(316002)(2616005)(41300700001)(2906002)(83380400001)(36756003)(8936002)(7416002)(5660300002)(8676002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OE9RWGllaDF3NVFYdFFHbVpSdDNjRE5LRjZzT01ra2VzWTV6cXdJellkTElK?= =?utf-8?B?eGY4MGF0WFNSS2dQMmgzTGRkNDJyQ1Q1VHQ5dGNyTnU4bC9SeUdQTi9MeFJV?= =?utf-8?B?bkVCdmxyalQ3dDZaWUoxSXJ1T25VdXpKSVlDZXdXQXZTeWJ6WGhYVjdSYzhK?= =?utf-8?B?cVRYNXBpZzdyYm5wVk9mYldkUGtNNmV1OWV6dVlnTDUraUM3Q2JacjZveVpZ?= =?utf-8?B?aWJDeEZkOXYyYm9tYW5ORzd2Zkc1RW5FcExEL2JJdTUrdmNQQ3RXQ3JNTkY2?= =?utf-8?B?ZG14S2t3U0dKUGg4aGh6WCtVNFlvVEhjNlMxOW8vQXhza0VrTnphczZuVXJ3?= =?utf-8?B?dGRRcUdkRXp6RTRvdEVCOE13bE9QY1Y1bm9TclZFU2FCYlkrMmMrWDNjSE1r?= =?utf-8?B?S2ZaVGduT2J4NitPTnJsYzZKU1h0N3RGS3JKeVVVQ1l2aklNQTlBZ3Rrellt?= =?utf-8?B?QVZIZGdWZ3cvczV3dU1QT0tscWhuWDNBTm1HOWdqRldHcHAwM2EwR294MzRy?= =?utf-8?B?N0ZFTTY1SGhDQ00vdDlXZzkvbnlSRjJrUGloM0dBekFkYm1ONjdoOFF6U1F4?= =?utf-8?B?RVpVZG1sb0JjdFF2N0toc1BGYjhYUG9ZTElidGNOVE5Tck5jeWUrYVNtU1dk?= =?utf-8?B?dHF0OTRBbE9KYUNJSVFlUEFkamNkSFpuTzlNcFhZL2RMNm9SaENkd2tFdnFH?= =?utf-8?B?Wm4yWU9vUHZxaDVaT1RpTi9MUWljdW5PTnN4UzJuQ3hvaTU1T0E1RUFRTlZJ?= =?utf-8?B?SUlKYmx1WlpKTTRpbGxhc04yYlhCSVRVd3d1U1J5RHgvQ0lEVHlUWWJVL2g1?= =?utf-8?B?bWZqclNHdVlwNHVhbzQzaUNVMGIvZHF4anZ3cUQ5ZFUvMmJCWVVaVWU3OUky?= =?utf-8?B?K1hwY1dNY2lidmk0SDZ3R2djNWFhWXhjT1I4NTdONTg5WmxXclVORVBuMGVN?= =?utf-8?B?aEM1WXZlTW1YWWpKU1lvM2JuMGdnMHZIQldJS1dnSzJuNXNuc01oZno5cmlK?= =?utf-8?B?dm1wZ3c5VUJxNmpyY1AyUVVOOEI2VmNLWGVDT1pUOW1uV1RKNVhzcXdEMHN2?= =?utf-8?B?d1RGdVAxYTc4WTFLUklrODVHL0NtdnB2emdQT0FLVkNRZUQxMnE1NkYyem4y?= =?utf-8?B?bXIwU3BZRlYrNndnbVRqeENvbUFtdjlvSWhuUFVqbGZGTUhCbk43SHRGYTla?= =?utf-8?B?cjFOcXdieEM3Q3JtdkZ2em5kUmZuSHJZSHV4amhCMElBM3B2cDJNSXZKL29F?= =?utf-8?B?OUdOaTBFQWVkWmNobXgxWWJ1UXNhdU1VNU1GOFBObit4OHFzZVUwUStNV3pC?= =?utf-8?B?MXU2VFNYNDhoU3V6QmNWaUdIcjNFMFBHZGpPbEVnMHI0SS8wTTVUY1RvWE9t?= =?utf-8?B?a2FwOS8wU0kyQ1NjTmdweGtvY2NRc2p2RFlFNUoxT2dTbDZzQzFUWGFuL3c1?= =?utf-8?B?bmtCeFhEUGxIakU2K2hHMTdpMmpoODllZElmTHA3UytGUTlqazRmcG5Ldncx?= =?utf-8?B?MU5rOW9IQTZvVzJlaHF3REsxTWJJU0dnOFllV0pVVDNrM2FaNFBuTVRWRGFI?= =?utf-8?B?QjFRamdHZmJHVVNwN0tVdlFhTkJaQTdRbHlvUU9kakhQb2dRdmo3dWJKOEFC?= =?utf-8?B?bWN0WDE0bHhnUkEwRHJRc0pPREs0Ukx4U25jT3JmRkY3Vkl4NTNZNlN5Unpj?= =?utf-8?B?dzlrcVkxQktreDVmYTBDMitCSWFTSTJXNWw2Y3JZbzhXa0QxMW9TMGMvajJB?= =?utf-8?B?bExaWEhaTXczaGJGSEE1dUh1QjE2Q0g1NjZWaWtQMWdTRmN1NndtNDJrVGNu?= =?utf-8?B?VWNwZGd5MGFWYWFtZUo2d01oSXZrWVpVb1RiYmh5NDRuVlYxWTRaQWxQd1h2?= =?utf-8?B?dGZrZUlVd3Z1eWdkUlZsNXRtK2lLYnpscGREaWJQNHNnZXlzeXZaL0lyV3Iy?= =?utf-8?B?Q3hrTENGem5sWDlzZVZURE0rWnA3VEw5bDk2V1JZVjZwLytRelJpZ0Vzb1ZO?= =?utf-8?B?TTRXTzhzaHl2REpoNWp2ZHo3OENLaUZVbXlWR2FjVHcrK1haYnljRk5wSzlO?= =?utf-8?B?Wm96NXpOWS95RkZtRUVNNUdnTXo2WW42QUQwQ0lwY3lnbVIvWVUrZElmS3BS?= =?utf-8?Q?YTKoOFoxqYbZk8B/p3IgIRTbh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3edd54b-36bb-4190-e99e-08db9816a8b2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:52:09.1123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dQhKcY0WFCrx1c8oauLlMzHPCrmBuYRKEuAdIF+HnXYVJqTeKsz57WRUbXr2UV+RgbVxSMdMQ+XKTRnhvEnz5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9884 On 08.08.2023 15:38, Nicola Vetrini wrote: > On 08/08/2023 15:22, Jan Beulich wrote: >> On 08.08.2023 14:22, Nicola Vetrini wrote: >>> The local variables 'irq_desc' shadow the homonymous global variable, >>> declared in 'xen/arch/x86/include/asm/irq.h', therefore they are >>> renamed >>> 'irqd' for consistency with ARM code. Other variables of the same type >>> in the file are also renamed 'irqd' for consistency. >> >> I'm pretty sure I pointed out that Arm uses a mix of "desc" and "irqd". >> So "consistency with ARM code" doesn't ... >> >>> --- a/xen/arch/x86/hvm/vmsi.c >>> +++ b/xen/arch/x86/hvm/vmsi.c >>> @@ -281,7 +281,7 @@ static int msixtbl_write(struct vcpu *v, unsigned >>> long address, >>> unsigned int nr_entry, index; >>> int r = X86EMUL_UNHANDLEABLE; >>> unsigned long flags; >>> - struct irq_desc *desc; >>> + struct irq_desc *irqd; >> >> ... require e.g. this rename. As mentioned before: Let's limit code >> churn where possible, and where going beyond what's strictly necessary >> isn't otherwise useful; there's already enough of it with all these not >> really helpful Misra changes. >> >>> @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry >>> *entry) >>> >>> int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t >>> gtable) >>> { >>> - struct irq_desc *irq_desc; >>> + struct irq_desc *irqd; >> >> This one indeed wants renaming, but then - consistent within the file - >> to "desc". At least that's my view. > > Well, but having > > struct irq_desc *desc; > struct msi_desc *msi_desc; > > and then using them both within the function doesn't seem that readable, You have a point there, yes. Still I'd then probably follow up with a change to rename msi_desc -> msi (and I say this despite seeing that farther down in the file "msi" is also used for another pointer type variables/parameters). But with what you say in mind I'd also be okay with you renaming to irqd where renaming is needed, but leaving "desc" alone. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:54:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:54:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579943.908155 (Exim 4.92) (envelope-from ) id 1qTNA4-00066e-Ci; Tue, 08 Aug 2023 13:54:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579943.908155; Tue, 08 Aug 2023 13:54:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNA4-00066X-9J; Tue, 08 Aug 2023 13:54:12 +0000 Received: by outflank-mailman (input) for mailman id 579943; Tue, 08 Aug 2023 13:54:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNA3-00066R-LL for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:54:11 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060b.outbound.protection.outlook.com [2a01:111:f400:fe16::60b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cbf85b5-35f3-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:54:10 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7967.eurprd04.prod.outlook.com (2603:10a6:102:b8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:54:08 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:54:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cbf85b5-35f3-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbD7bnqCOvGpWwjNZrUots+mmoxPVutc3fQxxsORVnH4PaFTnRVSRyAbGYotb6U6QJDepcekfDRQcY4V4kDzZYo5u0R85XQzzMSPu4ra0YjKX690EbIx7JHpnElmIOknNgprGakw4QAG/owshgZLBdDAFPDNMNGFoLnuuzb3j3rlWmStCo0fjqe1g7AE8q+y/VlTjUDGNCU9H1aydvZU3TDd8ccSPmDQu+YIYTzNemTpRsArS1/oqssBV6j7kKXAHX6bEaC2sfjJQpuw7mPQmvJn+77Pu3t4ua9onesvkNnAoG5QA8ffYDPQ1WafeE5M7RfmvSFo97vABUs3kkgSQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yFsBgP0I2lsEjEXUSrhbALEWBDLafndh5axRrWRGhI8=; b=hpLZvAtN7cxkHj/+OW/HHif2XBVAfXNnIwYPkWWTG9Zf5Kj1pS+qvXez2Z1DAipr+Dh6BecK8XbitrWLL2CSSApKV3r1aiAg08SRdpO5tGDm+dRyZaYs5ssRQ4pXG0iqDsTNLraSvyA23HxK6WPL8GdKQUBrJOG28+C43XKwJbW7vM43zyONRcJE10ynAmWAMWpiHU85+tQAMTRnKmREYDndOpFQukyilttTRnQJZvkv+wvSbiei6cbKTYrKIIJFxcHihs4eGKQXt/8w0Oqgu2O9VHKXiFdKFexkJmvff7v3XZfrBWVSjCaH2hfcD2UWWGfR4ry54S6SZ0Gtl6z19A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yFsBgP0I2lsEjEXUSrhbALEWBDLafndh5axRrWRGhI8=; b=uWJ0o1gY6tBt5ekPgj9CjhOJT/9IcHrrMhM97I7Zi5IQhMiLavrRyweDI+dG6mnDGMtSJDil4AR6Yu2iwPZiBlaYNU1JlE76G3aE8dDukjx+2qa8KrhKmJD2NOAfmF2LT3SeOfOaMtpG11xQtoqHRJYQW3AaR8FxbAsPW2ggXwhKg7crxe7HVAcN/0wzcz7mCqfu+Uy9tBT+xpi66Sx4qgsoFINOPR2ztoUL5pJt3hITkl0dQlDmY4E1NJ82PZhvrtHT5KhLtqCzaoEhWGavhqTk8X5riL7JqLJv55Rp++qV776JHnFhdvOqaTZ6WNm1m+Uk8IlRr26YhyIfl4vkBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3dd8adcf-dba0-f6f4-7519-dda14763a4b2@suse.com> Date: Tue, 8 Aug 2023 15:54:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Anthony PERARD , Andrew Cooper , xen-devel@lists.xenproject.org References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-4-jgross@suse.com> <726d0de5-bf4c-1fff-78ea-a52a7c84b635@suse.com> From: Jan Beulich In-Reply-To: <726d0de5-bf4c-1fff-78ea-a52a7c84b635@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7967:EE_ X-MS-Office365-Filtering-Correlation-Id: 569b7f63-8885-49aa-5558-08db9816efc1 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +F89fd51kOuquC0UxN//nmI97XcIeRuymw8RPGqLw5urFxgR6u8dBK2BMbwykKrptcTUs3vFl7KMpg97YqhTepR0WzdT2nSzNtKCjvA/I9DZtD3JWM39OvACBinLfLl4hKCvJ1nfQ6A4WsLngyKLdePT36Fs5v7qNb3vTyXXZSkzCYkGcNatQa+dE4McurwHe7G9u+Wd9qUV+4eEmPv1udNrBQWkuxnfYnq9K3QGZULKC9Zj76+SfHGU9u5hkpo3ipbkhSC/v7XLB1Wa2U9xNTK2gdI33es+6yq+j63aGNztRJNW9FVBOqk3vOchzeFibJVj6FVaAnuV/gFyUK6Xl1ulFxRoGv6tNlANjBw9nWusd3o07CCk2wCaLMbaOThYSn4/BtDuLxb5c+Eg45ponwIRxCSze9YBO5xgO5KtuHF+1LMRo7Pe8KZngciNPpDyzqNcoljuQdEOfbvwIbYRmW3FNloENJimjWhxYc6d2cA7nkiNfr44vp9VIvEtWl9J7kht8R6AQGJaye9kEBqYF78yr2Oqmq0BWUZrJTZLdvaHcRmlsYrM5vI0LH+3Ld2omkNPzpAmj7QJz4ajvlxN//dejf2NiayE84Xsv344ddsfl2uZOApZX9E663Qa+kzJUW9TnIcXnbhpLnBnHasF/g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(346002)(136003)(396003)(39860400002)(186006)(1800799003)(451199021)(41300700001)(26005)(2906002)(5660300002)(83380400001)(31686004)(6862004)(8936002)(8676002)(2616005)(478600001)(86362001)(316002)(6506007)(31696002)(53546011)(37006003)(54906003)(38100700002)(66556008)(6486002)(66476007)(66946007)(6512007)(6636002)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2RjdGRhSURzbjhFTGR1V1lQR3Bad1JFYTBuR2ZxZXRpd05vWVkxNWJzejI5?= =?utf-8?B?TDFxYnZYVmdlZEFCZjExSWdZV01lQldldWFqZWZtMGp3NDd6K0d4QXZmVzF4?= =?utf-8?B?QWlXa1hoaTQwQjlnTWFvRWU1ME5ZeXlGaEh2anJGbzV2MmJkZkExTFZYaHV4?= =?utf-8?B?Njh5V2hmQXpoZ1JZUHlCUENBNkM3Q0dhSWJVazFSNzJQc3lwbGNGZUdTSUVZ?= =?utf-8?B?ZmYzMlQzNEZsN1lUbmJPUkd3c1NiWXJBUDBMSHhxZkg3TldyMVFURWpYQnp6?= =?utf-8?B?U1VXR2pxNXhUK1NmWFdKNVVGVW92a1Vab1RYS3JmcEN6TmJRZDJXcWpMM2k0?= =?utf-8?B?WUt3SG5BRitTMDg5VTBXS0tibkVTZCtKZ0E2MDVKNUdhMHJYbG51aG1CaFh5?= =?utf-8?B?cFFuRHV5aU16NGRzTHR6dDk3K1d2ZTZPRU9ERFl3VzJ6T0pvbUVFU0dnalQ2?= =?utf-8?B?ZmJEakVoZ25LWmhGTGxjemRIOGRTakZhVldLdzJEVEtrbzhkVkR0SDBtY29B?= =?utf-8?B?NFZ1NTBtajY5czJjZVloOEZyVWNqbTR2SUx1VHpPd2J5bUttdUpjSGlYcWFH?= =?utf-8?B?OFdXbHVSUTVXSmptUG9BcThSNUYxWUw4RFBqMStJbytmRHFBMG9oNmtJNWdL?= =?utf-8?B?cVl0SGdCQUFhWTBTTXpUamR2V1dlWG00bWk3YVhhVllSTXVxZWZ2SWxseGxy?= =?utf-8?B?ZTJZdmRoSnlHdXQrYjgweS95cDRycWNZNnN3SjFDMUFodDN5cTc5Wmt0dGE4?= =?utf-8?B?Zy9PR1N0TXI1UGlZb0NKcFRBYndXNFBFTlkzNEtkYUw5S3VONnh6ZitaUDJX?= =?utf-8?B?R3lGbVozNVI2dnRTb0l3WDVVekk0YkJmemhPSWEvVU1PeUszeWpWVDROYm13?= =?utf-8?B?anJ2Wkx6VDI5TjBXTDFyajZjQnpMdjZLcjZvREZ1d3A5MnJQdWxuTFIrTFYw?= =?utf-8?B?NmpRSml5clBoZ0lVSHJKZ0ZiREt0ekhSUDJibzNXSFBoeHpOQitMKytPUnc5?= =?utf-8?B?RFdxZ3lUTTYxaUlVcmY4czJXNWlUR3lycFprSkpzT2IzYnd0TE9CY1NrYjFU?= =?utf-8?B?eE5TNXMyTDBBdEZGcXFnZVZHaWFCVjlCYUpmbEd4VDdQUlpVZmFBdXV3OWI5?= =?utf-8?B?VC85OFFtcE11MGQ2b3BZQStuNVA4cUZjNlAxdmZsTGdMY0dzNWJZWlNzQ0xk?= =?utf-8?B?WUhpZkZoMk9VQzgrV3JRMDV1NGZlOU9OS3E1L0pXaFc3QTlOK2RWVmlFT3Mw?= =?utf-8?B?TElHS0dDQlV2Mmc1UEYwemVpM1piUERKYllVK09NK2E5bjVjZno3M0xzdW9m?= =?utf-8?B?TVZ3Mk16Ylk3VVo2R2xKVjJHb2hPQ3FIcHpIQmlRNi9kYXRZa0ErazVFMzlE?= =?utf-8?B?NGRhTHJKS0Q0N1k2SEJEMkVTWFBDS0prdlYwWjFqcVBia2hPMS9CSkxqczdN?= =?utf-8?B?TDNid1c5N3N3L29EUlFWRG9SdHBBK0xVZm96MysxZXpNQjhqV0QvVDNlTVJS?= =?utf-8?B?bEwxUGxhRWhqREErcmtyMVdJVVZVWUdac1JKWDEyc3E2QXlRVUoxVTdncncv?= =?utf-8?B?UmlIMnlwempkcmhsYStGK2NIdGZCVHlDWVFaZEwyOGV0aEl5SElnbFpidk9o?= =?utf-8?B?V0VWS1NuSWd1WHlOY1ZoMk1ISzBKdi80eVVhdTlpTXVRYmZid2RTQzg0Q0Fi?= =?utf-8?B?cmFyQUZlSlpXb0lnMEVvZFQ5QlVVZzZoMFBmSWZmQkYrNmFjZjErT3cvOTF5?= =?utf-8?B?dGpOdU5LN2N6MG1ZQzIvSW5CSWtrNGJYOXJ3b2RZSFJORERJdGY3TnJNSlE2?= =?utf-8?B?TjkrSEg3SlJYTGNVcFFrR1lPWFZwTlJuNDJPZXpTdUNwL3ZxWFVTaEQ1V2hF?= =?utf-8?B?QmJnVHFwTmhHTTNQSDBvM0xqUUlpN0ZJVWdFSVpxaTZFVHJRd3lSZHI3U2RT?= =?utf-8?B?aUZhQnJldU9WbCthKy82VTRPejhrRjhJdENrZ2l4ZEhTdisyeXB2ZUg3ZW1S?= =?utf-8?B?UUt5Y00xU0QzdWszR0dXMTNYeXNzZ2JiT1d1dVg2UTF3UC9UeW51aEhqSWI5?= =?utf-8?B?anBreVdyL2lZb1ZsQ0V6QTZmWkJjUm03UWQ4b2pmTkhjb016YUZYUGNJL2dk?= =?utf-8?Q?/DivR0zB5KL54VWu9w1iFja0B?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 569b7f63-8885-49aa-5558-08db9816efc1 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:54:08.3339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lF9b9jILPNT0bFySWKMV33jS+mPf1SBjDNEYIn5nIcaYW8c0Q1hGueGcG+K8eibIO2G7IrrX+JsTNdvEg4nMJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7967 On 08.08.2023 15:36, Juergen Gross wrote: > On 08.08.23 15:32, Jan Beulich wrote: >> On 08.08.2023 15:22, Juergen Gross wrote: >>> --- a/tools/xl/xl_parse.c >>> +++ b/tools/xl/xl_parse.c >>> @@ -1692,6 +1692,15 @@ void parse_config_data(const char *config_source, >>> xlu_cfg_get_defbool(config, "acpi", &b_info->acpi, 0); >>> >>> xlu_cfg_replace_string (config, "bootloader", &b_info->bootloader, 0); >>> +#ifndef HAVE_PYGRUB >>> + if (b_info->bootloader && >>> + (!strcmp(b_info->bootloader, "pygrub") || >>> + !strcmp(b_info->bootloader, "/usr/bin/pygrub"))) { >> >> And no other path combinations can occur? strstr() is perhaps too lax, >> but what about finding the last slash (if any) and comparing the rest >> of the string (the full string when there's no slash) against "pygrub"? > > "pygrub" is the preferred variant, "/usr/bin/pygrub" seems to be the > legacy variant, which will result in a warning to use "pygrub" only > (in case pygrub is enabled, of course). > > I don't think we should test for other non-standard paths. > >> >>> + fprintf(stderr, "ERROR: this instance of Xen has been built without support of \"pygrub\".\n"); >> >> The other question (I'm sorry for my ignorance here) is whether pygrub >> could come from anywhere else. > > It would be possible to use that in case it is e.g. installed in > /usr/local/bin/pygrub (assuming the check above isn't modified). Well, okay, I'll leave this to Anthony then. Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:55:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579949.908165 (Exim 4.92) (envelope-from ) id 1qTNBZ-0006gf-Md; Tue, 08 Aug 2023 13:55:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579949.908165; Tue, 08 Aug 2023 13:55:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNBZ-0006gW-K4; Tue, 08 Aug 2023 13:55:45 +0000 Received: by outflank-mailman (input) for mailman id 579949; Tue, 08 Aug 2023 13:55:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNBY-0006gQ-P5 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:55:44 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42a0f203-35f3-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:55:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42a0f203-35f3-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691502941; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=17T/aoOsALy0M/J00/DrJ/Rw39x1aMjip/oySxG8Qo4=; b=dkM43OnAGNGpRZDQ4J59s3AO0iXs+v0YX+xd0s98c9EuTAWGkVrjE1py a7Xft+xUyn+8b7uheOcKgd3laILjsZNHY/g8BJADti+HWtqcn8Yhri3gR 6whF9FkgNVg3RF1vrXXxHO++ENyjizGQ7vgNodCUlg560PIyN44mdaxVp 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 118138738 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:OEqeLKCHj0zmNRVW/w/jw5YqxClBgxIJ4kV8jS/XYbTApG8q0DADy GdKUWDVP6qLM2DwKI9wPtzi/B4Cu5CBy4dnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GNA7gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw8eYwIHBi7 /MhAz0jNUCpo6Hr/7brc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4XaHJ4FwR3Iz o7A1zjIIggjbtiW8juU7Cq8g/CfnS3QWqtHQdVU8dY12QbOlwT/EiY+V1ShpuKiolWjQN8ZI EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yxmdLngJSHhGctNOnMYuSCYjz FOhg9LjDjspu7qQIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bhRKIb8dPCqGMpdDbQmHa5 3PXkyxuvuBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWWxC KMwkVkLjHO2AJdNRfEfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZ9yP1kY s3KLZb1XR727JiLKxLsHo8gPUIDnHhilQs/u7ikp/hY7VZuTCHMEupUWLd/Rus48LmFsG3oH yV3bqO3J+FkeLSmOEH/qNdDRW3m2FBnXfgaXeQLLL/cSuencUl9Y8LsLUQJJ9A0xvsIy7aSl px/M2cBoGfCabT8AV3iQhhehHnHB/6TcVpT0fQQAGuV IronPort-HdrOrdr: A9a23:+NW3iKuuc/1AAo4GShoJOMRA7skDTNV00zEX/kB9WHVpm5qj5q eTdZMgpHzJYVcqOE3I9urqBEDtexnhHP1OgLX5X43MYOC8ghrNEGgK1+KL/9SHIUDDH4Vmu5 uIHZITNDVeZ2IK6/oTTGODYrQdKHjsytHMudvj X-Talos-CUID: =?us-ascii?q?9a23=3AzEbXPmgjPhfQcrJckZv+ez5dBTJueX2a7Wb8OUC?= =?us-ascii?q?BImtHE+2/bRzNx6c0qp87?= X-Talos-MUID: =?us-ascii?q?9a23=3AZGQRkgy7do8o0Yege/ogsR1sYCKaqPifKFk0y5E?= =?us-ascii?q?PgMiVK3RgPijNjDqcQKZyfw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,156,1684814400"; d="scan'208";a="118138738" Date: Tue, 8 Aug 2023 14:55:33 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu , Andrew Cooper Subject: Re: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled Message-ID: References: <20230808132219.6422-1-jgross@suse.com> <20230808132219.6422-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230808132219.6422-4-jgross@suse.com> On Tue, Aug 08, 2023 at 03:22:19PM +0200, Juergen Gross wrote: > In case Xen has been configured with "--disable-pygrub", don't accept > the domain config option "bootloader=pygrub". > > Suggested-by: Andrew Cooper > Signed-off-by: Juergen Gross I'm unsure about this patch, but I guess we kind of expect pygrub to be built at the same time as `xl'. And it still allow to use "pygrub" if one specify the full path to it. So, Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:55:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:55:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579950.908175 (Exim 4.92) (envelope-from ) id 1qTNBj-0006ze-UE; Tue, 08 Aug 2023 13:55:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579950.908175; Tue, 08 Aug 2023 13:55:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNBj-0006zX-Rl; Tue, 08 Aug 2023 13:55:55 +0000 Received: by outflank-mailman (input) for mailman id 579950; Tue, 08 Aug 2023 13:55:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNBi-0006yO-4z for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:55:54 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49a4c9fc-35f3-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:55:52 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 3313E4EE0737; Tue, 8 Aug 2023 15:55:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49a4c9fc-35f3-11ee-b280-6b7b168915f2 MIME-Version: 1.0 Date: Tue, 08 Aug 2023 15:55:52 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v3 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 In-Reply-To: <250d3d77-9668-eac3-172d-5a0e50d33070@suse.com> References: <605687eff99db7181ef6c05bce671e20f194b46b.1691488505.git.nicola.vetrini@bugseng.com> <9e5f208e-7419-b16d-c705-592959dc0ea1@suse.com> <250d3d77-9668-eac3-172d-5a0e50d33070@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <3ce445c4628b28b3aa0869ab2250c9b2@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >>> >>>> @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct >>>> msixtbl_entry >>>> *entry) >>>> >>>> int msixtbl_pt_register(struct domain *d, struct pirq *pirq, >>>> uint64_t >>>> gtable) >>>> { >>>> - struct irq_desc *irq_desc; >>>> + struct irq_desc *irqd; >>> >>> This one indeed wants renaming, but then - consistent within the file >>> - >>> to "desc". At least that's my view. >> >> Well, but having >> >> struct irq_desc *desc; >> struct msi_desc *msi_desc; >> >> and then using them both within the function doesn't seem that >> readable, > > You have a point there, yes. Still I'd then probably follow up with a > change to rename msi_desc -> msi (and I say this despite seeing that > farther down in the file "msi" is also used for another pointer type > variables/parameters). But with what you say in mind I'd also be okay > with you renaming to irqd where renaming is needed, but leaving "desc" > alone. > > Jan I'll go for the latter (it's quicker) as a separate patch, since hopefully the other patch in the series can go in unmodified. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:56:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:56:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579957.908185 (Exim 4.92) (envelope-from ) id 1qTNC7-0007kq-Af; Tue, 08 Aug 2023 13:56:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579957.908185; Tue, 08 Aug 2023 13:56:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNC7-0007kh-7V; Tue, 08 Aug 2023 13:56:19 +0000 Received: by outflank-mailman (input) for mailman id 579957; Tue, 08 Aug 2023 13:56:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNC5-0006gQ-Ca for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:56:17 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2062b.outbound.protection.outlook.com [2a01:111:f400:fe13::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57452b1c-35f3-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 15:56:15 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9884.eurprd04.prod.outlook.com (2603:10a6:800:1d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:56:13 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:56:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57452b1c-35f3-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D8lgDNbi+Q/dqs2X+Q+MjOGiHnI2+EOd3LCRYbaIAreCsgg3ClBWXG7UvBz4HM4oI07tax9cCPPoeKsJN+3LwLav9asELMh6sOMldteMammlbng0bMb8UdrBZcuKgmnfuYEGDz/GaeYXgyD8bCGNqiwx6RX3hebEnGaIgSR8F1ovHPYeKKUtxPt8tyUx8vU2HGDHsVSSjMUEkaTXk8Uckgw22OYZpvqjAgdbRVus3glgB43U36vN4wwzokaoE1kmgLcW7wXX3t82mAQ+s3haf2ENOLPDgL4XpoV72P69QUS7KfH92tikidkxpjiLIvg+wZCiBLCK8Y1WabH4n3lfyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uz4px8UJT1vPWJRglAC0NI2xRKiOs91Y99XgwbTNFIE=; b=HWoBoKvA2+9M/Lm+qGBDMjNfsDF18deWjK4u2ybPdRz72LrgvSlOFat6TF0+ZZ95rO/fK6oLXVelDFGvfAr+ubqQqntBzH3mD2edEnavoDD1A2aWaH2CFyxqUl9xdrkU6TZoEsaLp8d6Rh9ZocQElkZfUrxSyphUoBFWTKONwdenKmuvOVD9v5IMXsTHQb5MAYaa4Xrq21dAueqUSwj5b/cQm4ZeyyY9/dDaX2mAdp21uQzWIbiGUrlxpY4ZYJuxqZg2YoX11zlkxLzoMZegQY/GOnf++kGQF1r6YnJzAcQxkxpt3EFPwhTQjHd6QfX0oZPgzJU9fg1/4vDFqGFTtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uz4px8UJT1vPWJRglAC0NI2xRKiOs91Y99XgwbTNFIE=; b=FtPg8GMrcGhFOdVfK8d9aJFESt4Xf+cregp87njxE5LT2VqwwQPDMee3JhCP56pWj2S2TfTqF4zq3P/olssCFm6zeCkJznJj1zG5/j2DOoBqq+RqRqf69Ij1f/8j8BGDZ27TvxXn0v85dnXqiqvrn6x/MBdJBcgNSPx7oNXjkto9sPZrasaZTK0xpHxJJ4VyMiqOyUM1U4cvZRy70aup3d1NkLypheAI/U2HRjQ6M6VaPITdCJ6ioSghQjBvtZ1Tp7WyO5rY+gFSFYMOcqVqA8YuFHCW6gjHAqKb0yTdWyvy0sqApVlb2UdT9m7V3EItEygziiZ44x71yYEkHZfDsA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <391b07ba-5004-6236-5296-efaf06720371@suse.com> Date: Tue, 8 Aug 2023 15:56:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 2/5] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <27631ba28fc6f47095fe0db3f8ee2cd87de616ed.1691492441.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <27631ba28fc6f47095fe0db3f8ee2cd87de616ed.1691492441.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0205.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9884:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f1f1eea-6cbd-4633-2e79-08db98173a76 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k5qEUsSQ3XHua7j1X/WD8wa/OokSiRvIQV8BTTFKUyARUX24m/TC5cKBEp2Qeqx8b5zZuozpwHuRQdrR8bgQf+CPWdT44ZHltMz5iLudTJhTWIxOvXf+Kv8JanZtP6rJ6tKyuV7i795DQxbnfRq/oYF2Dj1ZEECubtiQOo0vZABXJFIdfLCEduFiBtCbEwJkFNBvh/x3emx3Y/cm4up2k8YCtdHc3oBHyfF/j6pMWwoLZ9u9Rr62iq9dSBYfEzi7U/1UkApuAUrwrZfr4/k7jhi7ETkiPO9pI/pmSFq+XCs58BG25ubewysT3N/+SJ+9+FtBX+8x4sbuF/pmiGRhrjgRpWVA8JA3F9oRM+AVL7KF9ej+FUClUsIALd+89RtZKkVb8eSCiKVGIVGG7Z4b8kbInWYVCDib0A1Pv6l3hZg7v9gAPI1UKQoy+asLgelZTZ+BXZdruHfYrnL3itVpofNAJk6i2SH8PAEurYrcT/UQfqvkBBrfSj+u3GAfvUV91A2i5Ym6rItVnupn5YQSXsjISjkKRmlEsskv3P/jfg8JeSyesvvpfPCwe+rO8mqVgFcbQq/5ryOeinzEBUhpmlaPzOtIRoLDLo7XZsa7tpWIx2zppFb69iR+am9MvuwNvhV1fft17MAUXGaldoIQuw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(376002)(346002)(396003)(1800799003)(186006)(451199021)(478600001)(31686004)(6512007)(86362001)(6486002)(6506007)(66476007)(26005)(6916009)(66556008)(66946007)(53546011)(4326008)(38100700002)(54906003)(316002)(2616005)(41300700001)(4744005)(2906002)(36756003)(8936002)(7416002)(5660300002)(8676002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTV0V1BSV2oxVzRldUNwNzkyclQyeFRFbG5PdEVpNklqWFJoZW5relJwWHd2?= =?utf-8?B?Um1Eb0xCMFU5MXY0QUJmbHFuT1Qwc1dESTc2TnZibU4yOExZQXZvWVVJQlZB?= =?utf-8?B?RloyUnJFTHcrbjA0bmN6S2F5WDlIdm1kdXNaVUE0R2VlNVBwZlpVOTdSM0xa?= =?utf-8?B?c1huM3I1R011bytyeU5HSVgzbW5rZmtCbGhHdjdjZHhSb096dDhLZzF6cFpv?= =?utf-8?B?dy9ObmpzTStqMnJNbFBNanZFN0RtMjVkZkpncnh3cUxxZGJkVkhPdXNxZFVV?= =?utf-8?B?bk9hbEZGTS9ycEoyY29mK1YwMDd2ZStsaVBTMXNYY0hkMGNlcG8vallGdVdY?= =?utf-8?B?bXZLN0cwUDNrblA0OGxXeVdEbHVWa0trNFVpZzI3ZHc1ak5KZW82cU1jNkpU?= =?utf-8?B?QTNLY2FVSFl3UHl3YVJrTURPYmZmM1dOM1pHV2F0Wk5lYmswTkl1ZDJEUzNa?= =?utf-8?B?RUwrTmRIYUNIWHdSS3dDU2NRYnJMK0oxRkxVekdDa2k5dUp2eFFRUnl6eTFu?= =?utf-8?B?SW1KeWlwbmpDQmtDdHpTamNiTFNqT1ZGVEQ4WXRvdTJzbXJxM2ZPZWFqYzBu?= =?utf-8?B?c3NqOXpkbTZqRk50Z2VRSHZ6ejdrOG90cDJ3elhsc1RTbWpTbC8wYTR6TkpO?= =?utf-8?B?Tkx1eGI3cHdoNHlxZDdNMkpocFNmbFZ4QnJ1UHJPWis1YWxCY1liSkhWcjMw?= =?utf-8?B?dWdDS3hhNlpISi9hNXFtT2I1MkdlUnQwOFh5TitTd3pFZFhTQTgzUmpqZVg5?= =?utf-8?B?Y0R6ZjFtNEtHbk9KVmROUnJrTW1rbkhWeEtoZnQ4czJBTkYyTjJZTDh1YWR4?= =?utf-8?B?YjdrVXBEeVZPZU1ubzZOSkVHSWZUTS9kS1NpWmRVMHNDVFZBTzBZeGdxZkI0?= =?utf-8?B?M2V1WVkySWMvU2RXQ2Q4Nko2ekEySFkwaVdVcHIyQkhjWmpoVm51TldWQk8w?= =?utf-8?B?cjFkc3dvL0VYUGI2dHdBem1ScEJYSVJZZG5BejdrUU9DRzI4M2hESmQ1VzJN?= =?utf-8?B?UEpicnRMQzljQkRQQXVSRDNZQVR4ZVNEbmtrOU9SY1M3V2hlSTVTTE00OG5o?= =?utf-8?B?eVVRdFd6d2lJT09CZS9NRkN5dHVOZVE2QnZ2VWQxSEl2bEMybkRNa2pjWkx1?= =?utf-8?B?MU96MEFGZDZCb2MzZUpsQ3FXQ2M3LzE1cnJqbnJ4V3FkelNncGdUZVlXbVFr?= =?utf-8?B?bHFvbXArTXpWM3NjSExscmRXaEdiNWZ3Y29UaHRTcmZYTFY2MC9ocEVIOExj?= =?utf-8?B?VEcxODFrNlpHRlZLZHpSZ1F5WXBETHhGY3lZYkQyK2Q1dVhULzczbjNodTdH?= =?utf-8?B?eThKaUQ0dW5vem5tN08xS1Jna1UxVmZnc2xESUs1cjRRcVdxd2RSbzhoUmVy?= =?utf-8?B?REJXamtlYU9iRW9EZWlvUDBpcU9zZk5jaVovcUVsS3FBdUlMTnZDTzEzc1JM?= =?utf-8?B?djE0Z1FNais0TFp1OFNLKzJkYUIybVd1RVdlb0RVN3FhK2MwNzd1SHFkcDVa?= =?utf-8?B?SzcvVUJhcmdySEg5a2lVR2NxWXFwSGxRK2U3M00vS2tLWjdDM3lkL2pxeTZ2?= =?utf-8?B?c2tQVmZ6WGVZeVFPMTNyTG9UZmVtZTdxVHVDckpMSzRRUFZQRktvMUxBNzVX?= =?utf-8?B?bWdPVkFxUnJLQlpud0Y0TDNpUkNaWVZka0hGZGJsdG1HUSt6RVlqNUpEYXdG?= =?utf-8?B?SVZUY2VFd1pRN1dKRDFRSGJlMnJ0ZkRpbjFQWnVOZDBQU1BOZ2plK3o1V3hL?= =?utf-8?B?WFlRV25maFZDclpka2FLZ3p1bkdjcmpQNzdtaVBJeUE1SlZxRW12VVJWQ1B3?= =?utf-8?B?cnl4Y1VyeVNDUDJEZmJFUk9ZcjFJbFNsSWdoclVReWlJbzJKQmw3cWNWN0JG?= =?utf-8?B?ekphV2RWTjlqbExmY2lBekQ3bHh2UFFhVUgrdUszWlZkUWo4R3ZWdWhWRSt6?= =?utf-8?B?cSsxc3IvTGRIcTdGeEx2YldkY0wyMlRxdVM0QTI1SXg4bXdRM0U4OGVhSGdR?= =?utf-8?B?TzBWRlgzUjBZS3Q3WU91NFF2RE9tTnF6dkw4eWREMXVTU21ieFk1b3pBNlpF?= =?utf-8?B?eHBsazIwWnNaM0xKa3lBTkFUTjJ0anVPT1lDUnZ2R2E3amRUUTBQQm9oaWdT?= =?utf-8?Q?IWywY663kc43yU0Hk/84aB82P?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f1f1eea-6cbd-4633-2e79-08db98173a76 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:56:13.6519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ktdFf6mvQHJBZVTSVN4oIQr6bBBMKqgkwCJLMdGrNOSQHiN8WI0L1J/IcBjGHlsDOWH3LBVrrJywUY45zGWHtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9884 On 08.08.2023 13:08, Nicola Vetrini wrote: > --- a/xen/include/xen/delay.h > +++ b/xen/include/xen/delay.h > @@ -4,7 +4,12 @@ > /* Copyright (C) 1993 Linus Torvalds */ > > #include > -#define mdelay(n) (\ > - {unsigned long msec=(n); while (msec--) udelay(1000);}) > + > +static inline void mdelay(unsigned long n) > +{ > + unsigned long msec=n; > + while ( msec-- ) > + udelay(1000); > +} Nit: Style (blanks around = and blank line between declaration and statement). If need be I guess this again can be taken care of while committing. With the adjustments Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 13:57:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 13:57:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579966.908195 (Exim 4.92) (envelope-from ) id 1qTNDB-0008P1-KD; Tue, 08 Aug 2023 13:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579966.908195; Tue, 08 Aug 2023 13:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNDB-0008Ou-HO; Tue, 08 Aug 2023 13:57:25 +0000 Received: by outflank-mailman (input) for mailman id 579966; Tue, 08 Aug 2023 13:57:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNDB-0008Ol-0i for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 13:57:25 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20625.outbound.protection.outlook.com [2a01:111:f400:fe13::625]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8008323a-35f3-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 15:57:24 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9884.eurprd04.prod.outlook.com (2603:10a6:800:1d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 13:57:21 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 13:57:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8008323a-35f3-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grazFLqUtDII6jduNncHAG0SFaC4y8tAZBbZdOCweSQCB01G3jkRkqZENfSWVQo8YdHHYefy5IfYBK2zddAuYh0qBqhv/Qtvs9DLw/YKPERbyD42HiKehtYRUu6WYcg5uWM842viTqChb0lLg0Lse3cnksF6EbXN/Y9j14RhgLMKxiiLJWf2Y3I0wGIOWOlKSCmKp+HM0KEdNZWPY76wuWO63k/zIxYmVEbnj5zsJQWLp4SjpkpjeYeYIX4tLUn0bUvegB4PfDYV4UTh4hkLHTm1rbW3eWx8lHitCYjBT51S2qcM81DgnYBUcbYfKxHUKUMbg/oRhQJzxhQWLY/oXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e67eX2oDl6jpU/qekLSK4xUFjZSfHvdrTMKP+TQ/U1s=; b=kwB0FqKkbZN9dNdtnMHvuzg6D69XWenjhGzGSXjycqNyXqurEGPibbiq/HQNWxr9JuEISddZ6s0CNZeCumAAso1Trmeimf6eNvaeFWROHR9+5Fg/8IN0mzgBDnKqRJd+AQw5IVD6CFv+hVMBv53kwMzfdH8m/EIdK7Cxn4l6tiBLHqOs3zIRXglaiDKMAcDdxsqmyHjc3lSupYucfMdvISwWt1L7IJYVa9KhkP0CEO1qMe+Q2AAh39VZJUbEyCzeqIY+Jfpz66L7qJrahJKln4BBVjn+ayayoMq+dFq6S1xrX4skwYU9MmIJLGcTBgT4c6/8ryd3O8lJ12ex/PO1og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e67eX2oDl6jpU/qekLSK4xUFjZSfHvdrTMKP+TQ/U1s=; b=g+Lo3w+KanQgV5sp4iH4BzpiX1fR0ZEuMmj8ZpHt++rN6njhGH4Iw5Xs1N5RLOmnzp5BMVnyEPud9da/cZYrJ/FcpK002mB5/AWWl1dGVoAg5aCW+CA+pEHZZ3RzNV2bWxUBW9utl4pM7hRob3U1v88hmtBz3QoNHTaO6a6A043GCSoryEV/PV7Pa7OdRUIK8IostEtliXzb2WM/LRKYAWj2+8XxpH+SpUFNKxGRocs/bA1OJes0Mu9YGq1OApALhyrvp1xgwZmWBwm+FriTFhTd1XivztVk7gkpaQ04ygWTCfF3s4iOiMokn66tYep/5Vi/SZ/HOOtOWQ3Z81LPAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1e7f8260-2047-c504-0c00-e2ec4145ec03@suse.com> Date: Tue, 8 Aug 2023 15:57:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 2/5] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-US From: Jan Beulich To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <27631ba28fc6f47095fe0db3f8ee2cd87de616ed.1691492441.git.nicola.vetrini@bugseng.com> <391b07ba-5004-6236-5296-efaf06720371@suse.com> In-Reply-To: <391b07ba-5004-6236-5296-efaf06720371@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9884:EE_ X-MS-Office365-Filtering-Correlation-Id: 3881e5ba-306c-4adb-6f65-08db981762e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ntJU3/lHOlL7SyWGnwE9oAIdfH0qXdpNEs6wx8oVa+lsxDc6Re2GgH5xJynPqTIkCLkDZI788A/2xYkscNujDpndwgkTjyVtf17zdI0/I61/EkS8TemBeSzi6xkU9P4QHORpv02NTFRxnlpBp30Fi3VvWkJUoya9u9wm79HQfb7GqJMTVahT1OLVY/uNRQxxzxKcPxIJbg9WW94uWmV7dFOQE3JoCI/mgzPxT/SQQWJWR7U6T3KtL8un3eluLIZYwRm+ZXsKCghZErdzI+IEFues1mzolLYW8YOU+QQnJeH37usRFWou6lH2qsl7TIEYtewGbJvWykD5d2HZDbik3nC+zN9+G2eVx5D/PSAsHQib5bX1douPGeg5doRu7LAvdWOFSeo5APfEvtWE1zrNOEBfcUEUXf/SXgQ26FpZdarAVTRfL2gAd+Ltp3Yazr5D5ZS/1O4AnDtbONFQf0Ru/KqfmHkcuyr6QoRBbfKbr9arwwu+GnYDTOPa7hFwduzdXgwgCzcaKk0sAxeyoIYqBHwsxVqJWUzKLRkSP8Gm45P1xnMfekvYWOhtDNSofxrV7afbEllj4RZQzqas3kVlluXyE6/kY8lSItWBN23da8U6zfm8DQzyAkQmP5wVHBU8GZF0HscDELAUiqGEwKZJcw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(376002)(346002)(396003)(1800799003)(186006)(451199021)(478600001)(31686004)(6512007)(86362001)(6486002)(6506007)(66476007)(26005)(6916009)(66556008)(66946007)(53546011)(4326008)(38100700002)(54906003)(316002)(2616005)(41300700001)(4744005)(2906002)(36756003)(8936002)(7416002)(5660300002)(8676002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTN1b3pqaCtCOHMwWDFlRjlEV1RwaTFkZDZkUU1DY1o5QXpGNmZVbCtQNElu?= =?utf-8?B?VnVxV3NETU9MNFNGZjY0M3owY1diVkp0anZ0dGtORGFCODRQRUdKdHRuUTlr?= =?utf-8?B?dXM1aE1LaGJHM1RReHBDUzJ0VE1TdzYweXg5Zld3SSt3VjBOa3d5MnFzQjJN?= =?utf-8?B?ckN2LzVNdEd0RW5nNUNzMFJWbjNRenBUa1R5NVByMkhIMkkySXBrWFUvNCtV?= =?utf-8?B?dzNXdlhES0ljNG1iT0FRY2NEb3NhTmVnZHV3TWN2aUZ0bkQ4bWtZY2hzam1Q?= =?utf-8?B?R3JrSXBNbFJFTEN6VnBzWGVIVzBQa1Z5d2RYdldJMVR5U2RsWFBUQjhYWHBy?= =?utf-8?B?Sjd5TWlPTUpZOWpKdysvdVdSdXpXQTdWdWpOZGpSTmFzbUpDL1NmU0ZQYW85?= =?utf-8?B?TXArQUc2aXJTZkhPYS9lcFZINWYvVTA1K1hoL2xQSlFxWEhNd2RKZmE3dDJt?= =?utf-8?B?bk1PSDd3QkMwK3dsemJYd3NuMHJEOFBhSVdjaWZYVUZpcFdOMmxmcXQvQXdZ?= =?utf-8?B?a2w4ZlpQZDUxbXRweCtNRUtJY2tCNUJOM3BUWTJTRHh3djZyZDdvZk9uSGps?= =?utf-8?B?Z295YUZwU0QyREdpQUxkQXJmN1JNa2ZDYlpGcHJCOW1XU0lZR3JZaHFua0Rv?= =?utf-8?B?Q1BLU3dROVkxVDVmTmdJeC9DeXhMeTE2ZXY3K0ZsNWxqaG9GQ01DaTBXcU5v?= =?utf-8?B?amJlR3ArY0ZjNVhnU3FFREhpK1dudHlSUkFPSGpBQlIyUkQ0QzFLTU53UThz?= =?utf-8?B?YzB5cVVIK3Y0MUpUUlpyeExLSElOMEFxTWwwRUJqU0Z3YUt2bnlWZUFid0J0?= =?utf-8?B?Q1FwSDNVV251alZzdXRyOTFIUnVkZlFtTlVxRjhnSUVtNzRxaVpTcThha01j?= =?utf-8?B?Z2RHTHlPTEVlNk5WUUxWTkdmcm11Y2U1d1hnTFFSK2xMbUNEcFcycDMxVzUy?= =?utf-8?B?N095aEtUa0xPN241YWFhTWVtSUFiQmZTM2tqRWI5QWNYeFBDZ09VYkovYWNr?= =?utf-8?B?bEQ4cHc4ZkRyUlVueE1iT0lMZDd3cGNFSW9uaVU0ZFNrR2FXUWFwdzFuVzNR?= =?utf-8?B?OHFNWFBlWXBEdEZYZHhVR2pKQ3FZVjhzTkhlRERGdmRZOTRpRU1HTERNYWhU?= =?utf-8?B?Yy94OElKVENvcGdLYmFmSTZobTgrKzRFK2tOWTdSVFNZMjZ2ZWZPSWVvZkM5?= =?utf-8?B?L3lpRVhMOWozM2pFaitrSkZPSmE3U0VvMWR2bWVMT3orSVdkVHRMM0UzVWhW?= =?utf-8?B?VVFJby90WUdXelkvanJEV3dCeWVxMXJKNDMzOWZZM0pnTDBQQVo3N2lNZ2dq?= =?utf-8?B?cE91a3dSYjV5Y3J1S0NjUmY2VmtlYWFiS3lPbmJCOERVR3ZTZmFqbXQrbFFI?= =?utf-8?B?RmlDTktPT3Z4ZXZxZHE5MGlianJKR2N1WnZJVng1dXluWU1RcnViYlpJWU83?= =?utf-8?B?UDF6Z0FnbHMyNHVzMHJQdjdmNGZwbXMzRGZ0dnIwdWp5dWZzVFdpNmhhejRk?= =?utf-8?B?NGNKWE5PanFpdDFReDU2Q0syT1VCMDhiU283bXpIdVBmY0pLWm5JU0ZxWk5o?= =?utf-8?B?dEFpcVhoQmVzRDEwVEcwTW1rdHpHVTg3bzVNdmtxbEM5cE9JcXlvbGRZd3Uz?= =?utf-8?B?WmhIRVJVVDRWK3gra0tWdGNUNEV6KzdIRU9Ha2FmTitpaFhBakZoYjRBNG9E?= =?utf-8?B?YXNBRlZkOUg1cTY1ZW83OUg1WW91L1c2MmJ6enc4ckhqdWV5RHhFcFdkQjJx?= =?utf-8?B?a0dGOVUxT05tUmZMdEdLWDI2S1Z5QUlvQncrN2ZsbCtkL3pjeWN5NVpEOStu?= =?utf-8?B?ZCsxa0c0MHZBOTBxcXRmUUw3aWpEM1ZsVGR0eW9QTE82amMxbVBmS0p4ZGdX?= =?utf-8?B?dythbHZnU3hFTnZFb29sRy8wMStBTXZ1aVAyTitKd3U5ZDRIQnFLODBTY3hL?= =?utf-8?B?WFpVNGUwRjdpNmhJU3NYWnI2WXRDNWFrS2I5TjRMbVNhWnRPZ2xYYjdCTnJS?= =?utf-8?B?L2d6bzZJc21EeXhYeTdaeUo5c3lRYTdTb1JjanVkb015aVpXYTBzRzFXNHlq?= =?utf-8?B?cHdINjFZc1V4ZjBoQmhGRzg5czJ3eEdmTzhDNmhSUXc1S3M2VXVFZkkyVzVF?= =?utf-8?Q?F5wb57q1dc50JnFekV6hFW6d3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3881e5ba-306c-4adb-6f65-08db981762e4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 13:57:21.4874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pcNufy/K59DP98QoYb5qd6RDyRf6fUR0+IC7wh6kkcvYyxzyFgOXG6Dw21ul63nRgvrSsiptDF1BOjxEo+TgsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9884 On 08.08.2023 15:56, Jan Beulich wrote: > On 08.08.2023 13:08, Nicola Vetrini wrote: >> --- a/xen/include/xen/delay.h >> +++ b/xen/include/xen/delay.h >> @@ -4,7 +4,12 @@ >> /* Copyright (C) 1993 Linus Torvalds */ >> >> #include >> -#define mdelay(n) (\ >> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >> + >> +static inline void mdelay(unsigned long n) >> +{ >> + unsigned long msec=n; >> + while ( msec-- ) >> + udelay(1000); >> +} > > Nit: Style (blanks around = and blank line between declaration and > statement). If need be I guess this again can be taken care of while > committing. With the adjustments > Acked-by: Jan Beulich Actually - why have a local variable here at all? Just name the function parameter "msec". Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 14:01:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 14:01:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579976.908205 (Exim 4.92) (envelope-from ) id 1qTNH4-0001Xu-47; Tue, 08 Aug 2023 14:01:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579976.908205; Tue, 08 Aug 2023 14:01:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNH4-0001Xn-1V; Tue, 08 Aug 2023 14:01:26 +0000 Received: by outflank-mailman (input) for mailman id 579976; Tue, 08 Aug 2023 14:01:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNH3-0001Xh-7I for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 14:01:25 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0606.outbound.protection.outlook.com [2a01:111:f400:fe0c::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f4a8935-35f4-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 16:01:24 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7869.eurprd04.prod.outlook.com (2603:10a6:102:c4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 14:01:22 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 14:01:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f4a8935-35f4-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odPYHy13W948CIc0WTEbnj/sRPp0MXPEkF0vY5pbdc9GBV2qClcKsleR/dclcCPhV6Xt+NGai+PucCg5U5c1WgQztmJyDzpJTzXDhr1NwXrQOuPwRM2IdeQPM4J4rkoxfCWSOceRrKXdZgUUHQdzyX2r5Szheo30HxwrN0+FS06BqwblFelKgr2zz1cT4ZSSWTwMPZo4ezJ9UFLla46o7372kiaMRK+Xkof155eAPxl7Fi4yCfVBVAYTgXegf1Sosq/6/MrHOVeosFPTxBLPfPPbWJXGyJ9z5Kj1sULp2ND0XGHpIXfSexzlzWKrPFChGKj0AqjY0V+r5nXOQnumKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baBWFeRjOBkdXC/voNhdSJw5wzxdGRLHNp0RW+pSYAU=; b=cIUgtHum3ktYsG489zG7/k6UeJ+idr88GDeYwEX5wnfTzTHf2ZuEqmPYNU1l16w/GDUyknbzWyw+lzqjBlGDzU7VkBsLzVyBEmWQZpaPtcIWB6Mc13x+c91Ybuj52bk63vle+WtY/FnSdieceDBV50s4jOHzB0mlRsZv0f3qL0abgMcQX0gePuUERD3x96WYmLPWy1a5uqB9XGRAO/dkHmAiZBpfY7PaMMgItri3SPe3Rs6da+IF8SrwFBtWj4A9YIdVQeLGwb/wAQpONCGfeSlfrmin//hME3vJOKCcJAhR0eGYZ0JBImbMO1MbzbP/tRkodXaVHCixJVj+oVD9aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=baBWFeRjOBkdXC/voNhdSJw5wzxdGRLHNp0RW+pSYAU=; b=Mt0Wfhv6PO3mQl4EObpiA1H80OYhrjGfNflxJWoGABgJSjBrj9MA25+fgRfD2MOvsNMXZiUsCLdn2cvPiUlNljPk7AANQnMcdi3Xk7faU9ZvAwIELI9anxmsnFplMETZbQvXUXUXfFB9+ov6K0DsQKzg59vkKdEMXzvJmSh1JMiEmbWgq5gPzZlKYNNgtNRey2M6HfYQ4GyYGSLTL9Ce0Jkcx2HfEksimOwE49Oc0LO6dJc3hhj7JE2mVUZ6/XCigodj0O5G/ER64ELp2g3zdT8PeaZyw5XHgdqdPqqGAhBZ3g41NAead/dSeiYLlPuOYU2x7mLlkj1sdxBoVUJ7Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <97b43017-722f-4891-395c-d53ae4e6c24d@suse.com> Date: Tue, 8 Aug 2023 16:01:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 3/5] x86/include: address MISRA C:2012 Rule 5.3. Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <4b41f84c6cbce3466917d1091029cacb3c327d7b.1691492441.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <4b41f84c6cbce3466917d1091029cacb3c327d7b.1691492441.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7869:EE_ X-MS-Office365-Filtering-Correlation-Id: db3a8eed-68ca-46a8-60d3-08db9817f251 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xWcQ3Ne6EYf64pjx4nDhrw/fNWpdntspbf4GPERanYFbZt29QVWInrgIkwB/JQKVHrKQ03nBzgWYcCIWepFXoQ751dqWRXfUi6I6jS1fNoYIPL23hBMVab2YqEi2pC8shvCZJDLR6kge/B4J5ZwcKagO8IWqrsrwTFJgX94Cqmmuql/UPvSJHvM+Gnvws9BqUu4qQtGqbHacH+5vR7YzgVHWnFdot5eE+iSMi5zxPK1kOBfmV9kJ0Xliviip7ElSfbPcUZRpFd1xTUfUXe5Gd/CHz5FTWpHHSrD4wSs3Uu3DrOZ683V62ZRNrMIzB4RIiltdOu3jKtmXNQovQa+P8qkhgRYk8jaTqHQsAcbQrjre+cQXSMjcSgrFbeW191nsorKiiPV6B/hilBGq5SpYitndnxJdwewRwiVtrcrHWTWyiEApiTYoZhEcL5LMlnn/xeD9Es+22wzYxKauG+kPTvermutoPggALTz/hVFCWF6dAygmXQTAphysHifo4akHuuD973P2oMYbao7C5fKkRrg17ZdYr7OG9N+Lk35tKi0wClcHc0XqGepA/fY6PMjd03qcVvaOPrd5XmgVdwo1uv/WKLeTRd1SiaBUJQGGuG6KMrEUEcwn2ST689DgTmwhJsk1SGpUC6EXyCIQd3cCFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(396003)(39860400002)(376002)(136003)(186006)(451199021)(1800799003)(8936002)(7416002)(8676002)(54906003)(478600001)(5660300002)(31686004)(41300700001)(4326008)(6916009)(316002)(66476007)(66556008)(66946007)(38100700002)(31696002)(26005)(53546011)(6506007)(4744005)(2906002)(86362001)(36756003)(6486002)(6666004)(6512007)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGI2MmtPWVdac2hrTG5tWm82SVJ5WWxpQTdmanpSKzhJaTN3OG02NnNaU08v?= =?utf-8?B?TmlzcURoOUxGSHpPTHo4QTQzdTdLRnhZM3UyQXphL1BhaFlZQzFZNGpCQkk0?= =?utf-8?B?WGlKQTBLNCtyZXpId2ljS3p2QWpHUHpWVWlDSU0zYVduQm9VZ3hXczJ0L1pU?= =?utf-8?B?UkpyMEN3L0s1R0JSd0FrQ0FlejNTQzczak9LNDdOL0svTlgvRU4rcUg0bjk4?= =?utf-8?B?OHhSVjc3ekRoYy93MWJVbGJRV0xGaEJXOENqaGMvanFsRUlPZ2gySWZRcFJ5?= =?utf-8?B?Wlg3UUJWU1ZYdksvWWxHclYvOUdRVThvYzM5SHhaaTBIWmszaENQRGJWRXpO?= =?utf-8?B?Qk9wMy8wN1RhUFA2SnFwWmFpOExBMTd1QURrd0oxRW16WUpaWWhhNHFvalJD?= =?utf-8?B?dmNoekNncWZRbFN1Z3dXU1F1djY0K2FURHZBUVFYOU5oV1lTMEN3bHRwcWJi?= =?utf-8?B?UkUyRUNIWk1ZMnZrclFJcnNLQzhNcEJJYk1BNHhiYnhYV29SS2NyNHFJaGFP?= =?utf-8?B?cFB3Y3JqRGIybkMwaFkrK0J0bVN6UzA1N1I2a2tjVjM5TG5Ba2tCSnBNT3k3?= =?utf-8?B?ODNYdVZwOTJkL0JpZjZ2dTRyS2VxOUJZUUlmcGl2Ymw5S0F5N0NramdtSVFS?= =?utf-8?B?WEcrT1p5bWJ3SHdMWUdhQjg2RC96T1dNMTg2S3ZyK1o4UWY2cVJOWDNmcW10?= =?utf-8?B?OGVpcDkwUjFqWGFPRXV3MWh6dmdlUjVXZGovNHp0b0hwVVI0dWxvNkZic0hM?= =?utf-8?B?WEZuSVZwRXlON0wyWGlsWFBRTWV2SWdqQ2VubVp1Y3hMeWQvKzNaTUF6cVFt?= =?utf-8?B?b2ltUHY1eDM4ZDFDTEt0d2wxV2xTY01mSTRPMjdTTjR6cmlnT09ta3pyQmFV?= =?utf-8?B?NS9zRzJRdElMUzdLT21aN1c5MzRxdDZpMkk2cm5uMFlpN05YOHRqaHdITldD?= =?utf-8?B?VUR0NVp6R2xGcnZzbU41TnRPTDVWUDdyaEZiSzl2VnVnS2JoZi96bFJnd1pz?= =?utf-8?B?eW0xSG1DcmJYRXhveU80UjFYRldBNFh1Z0RNQkkySCtIa1k1THUzMWxkeDdP?= =?utf-8?B?ZktmM29lSnJlSDhsOVRkVU8wdmJPK2J6M3BkOGl2a0JjM09vY3VRQmwrZjA2?= =?utf-8?B?eFFkMG9FYjIxNndJTVdEaGlncU5rdjBtRVJEL1FramsvNzBGOGtrRmlMbmhj?= =?utf-8?B?eHRMK2thNHRrbzFtZHByUm10U2plTHI3NGVia0V1dXhobnIrNitnTnIzUHNG?= =?utf-8?B?VkN4eXBFWEVFaHBvdTBWR2x4M09QekNRWXJqUlY0aDRLYkU5N1U0VTBBT3Nu?= =?utf-8?B?Q3BmVHpMcXR2dUNYYVJpZ09JYmd0NE1lLzVXWHkxYk5UVTJhSFFWQUkyQ3Fr?= =?utf-8?B?dFdvNkNhSTFQVGczMG5hY1QvODVVWnV4L1JackdTQ1dPVHBWV2gxSVdsclFH?= =?utf-8?B?S3liNlFaZ2lEbFRWVzF1SVNRZUJSSEpWV0xkeW9EajI2M0VjbUhTRWxyUGR5?= =?utf-8?B?UXJtajM0cGwwaHV0UDAvTStiNW9iTk52NUhSYm5SQmZncXNsSk91cS83NFE1?= =?utf-8?B?OGNBNG5rTWJHWTVyWTZxbkQyZzhUbjlxamV4SkZ0eC8rYzdKWE51RlpKSE1k?= =?utf-8?B?dSs5K0lKR1ArOU5sWjBSMUtVMi9NUmVIaW9zeVRrMm5VOHZHRmdJbGFCNnRw?= =?utf-8?B?Tml6UVFUbEs1SmFRNmFGQW5mV3VuOUNERzRRQzlLcXQrY1JhYm43Q2VJK0pm?= =?utf-8?B?OGtJUWJKTWY1MUttRG9IYmZPbXlQUWs4cHdINXRNbHlxL3FjQm9MNVpFMHF1?= =?utf-8?B?VGd0ckxSd2pPSWJjZWxNdG5QWVJkWjVHVFd0Nlp0WHUzdG9zMjZ1VjVnT3Ir?= =?utf-8?B?bXg5WEo4Wmp4U0IwMEl3MVFRemVrT0hKdVVSREgyeVoxdHFFT2lSeGlWb2tP?= =?utf-8?B?eExqYTgySkJSZkVucHZ0U3h1Q3h5WDdpVUZFYlM4bEtWTzVkamVZTk1GQ1ZV?= =?utf-8?B?bXoyVm43R09lWXNNdVRDbXNFMDlJcXNWUjlBZktnZEFoMlNFVHVVZnhGTzBV?= =?utf-8?B?TDJQQ0RhK3JQcUlOMmFhbEhXZThRa0k1UHlFS0lWWkxMOG00QU1BeWo3SnVT?= =?utf-8?Q?JI3BeTMd3ALfZS14N+QOvEI4/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: db3a8eed-68ca-46a8-60d3-08db9817f251 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 14:01:22.1255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /LOWqBt7/0PhC/KTapMJ/ydXMUGz9/YpvEg9CZUvnl78WIiSUoSNOGA5a6wAISKrwWLTee4R1DO/O+dBm1EuCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7869 On 08.08.2023 13:08, Nicola Vetrini wrote: > Variable 'mpc_default_type' in 'xen/arch/x86/include/asm/mpspec.h' > has no uses and causes shadowing with function parameter names > in 'mpparse.c'. Therefore, it is removed. Personally I'd again wish this could be expressed more precisely than just "variable". What you're removing is a declaration which has no definition. So aiui shadowing is only one of the concerns Misra would have here; the lack of a definition would be another. > No functional changes. > > Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 14:04:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 14:04:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579982.908214 (Exim 4.92) (envelope-from ) id 1qTNJW-0002Aa-JP; Tue, 08 Aug 2023 14:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579982.908214; Tue, 08 Aug 2023 14:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNJW-0002AT-Gv; Tue, 08 Aug 2023 14:03:58 +0000 Received: by outflank-mailman (input) for mailman id 579982; Tue, 08 Aug 2023 14:03:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNJU-0002A5-Tc for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 14:03:56 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20603.outbound.protection.outlook.com [2a01:111:f400:fe12::603]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68f66e5a-35f4-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 16:03:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8945.eurprd04.prod.outlook.com (2603:10a6:20b:42c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.22; Tue, 8 Aug 2023 14:03:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 14:03:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68f66e5a-35f4-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/MhJs5AV1Phb3NblQxVs8PMDu0IGIf5Hg/Pao7yAEPd7TCV9AQPSE31+Vuegf51HoXoplwcRwm4Y2iwZOQSqtOXNkp3nLochtzDoXcuzkhEg8i9XmTAwgaSqmzBAwhv3pTvi4xg5+ku8SVkQnKJfa3GLHJJRQwc35B9edWvbA/gN1RwOICi+npeIvZv+i7IOFJ22x6hkCgerRL/5wxg9K+ELqF2jNzEqGOtCbnMQK194JH+2rI7PxKrMk8Vu9Gt5fEpryOtIDvEUIoow4pt9zKf2Gau2EJiYPZ2ucUrA2CM0q4HVlPun9HRJ2yau1kIEvr/VhW/yP4qDXQ6iFcziw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJeY52rlTThTYy2nDcE8cZ/gX+XfB/fqbt0cVJxWawU=; b=RgflQ1Sl0iV08TtgD3Ang5koUM4Ku7knuQfyL1cCzHSa8c+z9PObQDhWf4205pyWifZ5ExLHuAu0OtuG+PXxsv8rRnEdNIq0XE8YocnumWwtrSy6ypuxMucQIGVtDnf4GhCR36zg/iS4SAMv854kSMMgqLYMAWSHNMWBpfgQlhe04QuPouwDz6MVaEm+jTbcxJbzuQb73LaUzuf7ntY8A/CxiFrFPT290Tx2Gc4WMZMeE1BcmYLLkKuMt+P5ToW3jKhhmeefPnMbPkRje5yi5u4LhDTYv6fwHK85VeUm2ct3cPheYTCE3gl5iAt/8+71hoOf7z2RNiYl+vnOs1yx5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJeY52rlTThTYy2nDcE8cZ/gX+XfB/fqbt0cVJxWawU=; b=Ks9BWLY1YJR3nkE66/TA7Hrs/lDY3fES9sGmlsES3zQnHqhp1cgXwW2/yzHJ16WpzbBBO3KNgidfUvwaG9GYJHeFRILmiAtl7HwzXLXV0rYrzOzCm7fy2it4gi84/VQvTeblPixcbHt+xDw4xFk2ex3Q9h9iySZh6l584UAS5q6+xINqE0WIv+dlgyjGpRFyA6IRF5w+F40MJ/4CM9abJrHj5zkxeUCU4i6q7q82yTUUJUjXVjywZV5mMC1tWinnsjhnF7/N5jaZaPEKUHNQrYrhHJ0nP/PZsrWbwh6qKop41mFwNDHbcDEIfQ1AntHbOK4k0ZIKVVeHiHtdm4rdkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <30c4b7b4-6043-8ac2-67d5-000fd1a81266@suse.com> Date: Tue, 8 Aug 2023 16:03:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 4/5] x86/xstate: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <927d771a3c38b8a3c47913aea21cf8890fd4e6ef.1691492441.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <927d771a3c38b8a3c47913aea21cf8890fd4e6ef.1691492441.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8945:EE_ X-MS-Office365-Filtering-Correlation-Id: b8bd7c30-63b4-4d75-1985-08db98184c23 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JkT1QZX/Qv9OwGc2p4c2ntxvK8V1+qyptPJKvZkf5sNwf83nA4JL7dzfB0djfqgRXrFEezTACYpHTrAT4ldjvmah7lgPlaw4IIkJ3TtnRsXqDHdn4YIMefo+E+dDYQBqxM74eABe+D1nvfpkAUZwcaL0zX4Dr4Xy/e7eS1QaeMYrX7QwCTLejFd+nWtUac3Rbcfj3a/mzXS2MX7A38ud+sipaDMnBZzH9n2txhnDpxdyQC6wdxAw5smfGyrANmjXf94luxlk2Hopcr/+GNjwt8FYKX0Bm3hMOUiNefVQuNmR9ybp6tCN8qPUOZjO3p6wTp9Vgf1cXnA9eQiOU40ITuWY+WMXdsNHBDNIPDTCpCxK+bmcSXkByGI9YrPDDnfJMUokYPirvL761DB6jJc/baAmzkvaKFokxcVPG2H46UjUEUesjrlrUphRek7tI/+U1gUBNRtkkXoNDY+RriGQOa3HPwVSzmhfAY4a9PzGf89mKfOeLoHs8hTN7GzVtHFhR+/o8NmN5GPC5SLQRwoYyzBGN5Hqj0fVGbCAIN8zRM27pIBlbPhOxj8rY2PWdA0jeO9z4Pzhxf5ocGfGabTcZ1Ejv0xKZIXNyAcUlIOtD2cpNH4EnIkKUAQzwzZT2m1mnc3sq0J9rSRPKzbj3V/5ZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(136003)(39860400002)(366004)(451199021)(1800799003)(186006)(41300700001)(38100700002)(6486002)(6506007)(53546011)(26005)(2616005)(6512007)(4744005)(316002)(54906003)(2906002)(86362001)(31696002)(6916009)(66946007)(66556008)(36756003)(4326008)(66476007)(8936002)(31686004)(478600001)(8676002)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG14d1hoT3k1OFBndFJXMG5JdzZDWEtMbmdhT3I4KzduSnA3Rk1MQllDZWor?= =?utf-8?B?SlZiNmdKaG9sYWZxaHF5R2dmc3lxcW9oN05JV3I1enFoVGJCRVVwWTdVQ1Jj?= =?utf-8?B?Y0RibTRJV3BmN3MyOU0vUGFER09ldU9XMkQvNldPSnM0Wis1Lzh2WkhXQkd0?= =?utf-8?B?Vnl1Q3JUMlhtYkc1VTk2UGhUQy9jblc1YVFtdGVBQktCUjZpd3d3OXE4bnZL?= =?utf-8?B?YmE0WGxFWnkxV3ZZSWZ0Y2hUcWY2OXRSME9BK0sxdFlNV1MzNGtLbWZhYTB0?= =?utf-8?B?UVVwWkVoNDhseWhjSnM1NWdNU24wcXZia1d3NTMvSW5Oc2Q1cHpXalNwRFRX?= =?utf-8?B?MlhuNWNYK2NrV2RPcDZ5MFJ2NU5teUJCUCtwTVF0K2NYNlJveTE3VXlNZVlN?= =?utf-8?B?bUNmSDhDZmhTSHFoSW13d1hYNGh5T2pFTCthOU52YUViUlpENEVxUngxc1hS?= =?utf-8?B?VEFSMHcvbk02S29XU3MvK3dyYnpkY1BsNHB1OXR6THpGTUt5aE5yb2szUnZ1?= =?utf-8?B?L1d1R09MTlJoYm9MRmFmS2M2WHhQaGVqUm1wTTJJREpDTVZha1VZcFgxdEF1?= =?utf-8?B?Q2RzWGRpTVVtOStJMEoyVGl2ZndSV0VTYzR6M2RwSjlpY2JCNnVvaXJrbkVI?= =?utf-8?B?Tnduckd1dDdTM3U3TzgrV0JJeVF3Q3RLdm5KYkVEdUsrek5kWk9DUGY0RXhw?= =?utf-8?B?YjhtckE3N3R5cWdVcmd3RkYxRXJrSDUwdCs3QVZ0OHZDM2R3UjFKRGpMUWky?= =?utf-8?B?ZUp3ZFEvY3U2WGJKZ1ZyUkZqRkdlTW5aRVJZSjJmc2RITDJhR2xCd0lxbWdV?= =?utf-8?B?TnZqUS9IQUExeU1zcHlNaEVGRWtpRTN1LzV5bDNvY0N6R0pJU3VvMlU1Y3Vm?= =?utf-8?B?aGVxTldSZWE0NUVKU25zNDh5NFdYeXVHVzcxZm5PcGxTd2FCVzIyYWU0TVUz?= =?utf-8?B?NTE4M2ZaSzI4YTUyM25ZQjdmaE5VZ1VmUzVzR0JyS3psRFBUcFJ6bkNyRGlM?= =?utf-8?B?WFR1d2lhRmVlamJFYlc0NloyeVZXWkt4VXVENStadjhqQ3cwQlA3eGwzVUVq?= =?utf-8?B?SHM4RFZWQWZWNUJPeW5Ka0tKMzBrT1dsL2lndEwzUXA1NkpoSXNuUFIzWEJk?= =?utf-8?B?RTZuV3E1RDVBSFNJcXBBc1doQVRnQkhKZU1EZWFDWmN5TXR2ZzgxaWtIdVN3?= =?utf-8?B?UTFTVFZmU0RVci83Qk9VSlFaazNRZkJLOG1XNWQ2aHpQdzdCVFBBT0owT3B2?= =?utf-8?B?eG1MVGl1WGdCbzZlM3AzY0NPazhZV3crY1NiSHJ6dTZQWkhPc1F6TG93cEVX?= =?utf-8?B?a1N0aHh1VWVHK0NDZlRzQ0lOMEZ3UDhud3NXekI1RnZDbUFuTC9sZGlXRHE2?= =?utf-8?B?aytMV1hyaHdtbm9kTnU2Q0JyemFWWUxUZWxPWlNYT2l5UVFrYitDN2lROHVQ?= =?utf-8?B?TlhOQURqM09VZ3I1YmR0cVlLMnJ2MWxteTJwUURJOERMNENHd2s2T1hXcmh0?= =?utf-8?B?M3dySmNyRDlHaHpOOFdYREw0WUVOZjViaHgwOVR4dkZsMCt4UzBpbGtMY2Ry?= =?utf-8?B?MnF2amkyQyswRWY4VFJudURoRG1qNVVhMHFYMWNrU0NsVlA1WVlvd3VaV2V0?= =?utf-8?B?OFFDd2VWckUzc1lIVUxlMFd6L3JUQkgxRUp3aWVZeGpGNGpJNVNxWjUxUXhB?= =?utf-8?B?S1I4VVZiZlQxakJOSFpRSWo0Qmt5bzMydDk0RTdqTmpRUVhoWEYrMFdWai8r?= =?utf-8?B?REZjVm5MRElrN2tlM3EyNmNOYkNsdTVMOVE3VnVxMm5zcXZOY0xoT3hwVVds?= =?utf-8?B?ek5PbEVHVE9ZK2JJQjFYOFY2MU1MY0hFMWRnNUdlUGEzb2IzZS8yZWJzNDBJ?= =?utf-8?B?RExXbkpPNElWRVpmc2ZyczllQW9GbmFpTGRxZFdlS0x1d3VEcWdmV0dCZDNX?= =?utf-8?B?T01NMlY0VDQ3YTBIOGVYT3JXd1psNjEyWUpJV3BmT1hvbksvY3JoTERXTllT?= =?utf-8?B?TzJuVXRzSE1Ydk9lYlJoN3NFWUJIc09oVDE4aFZTcW1jc1pNY1UvcmhLYVdB?= =?utf-8?B?TDFNWGkzY3J3Zm95bTFXdU1jaGxUbVkrV3J3UE9POG5VTGgxTDdiMVR5TXNq?= =?utf-8?Q?aGk7/Odf45GZXM7vrHaoOW88G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8bd7c30-63b4-4d75-1985-08db98184c23 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 14:03:52.7871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 00Qu44L1u5mrfHR592AILj4XYYN/aa77JWXFGtY5VQsvjic6iUc1s4bN6e0Tbs1g23PpVxUthiuLPkNIwynz1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8945 On 08.08.2023 13:08, Nicola Vetrini wrote: > Rename the local variables s/xsave/xstate/ to avoid clashing > with function 'xsave' defined in 'xen/arch/x86/include/asm/xstate.h'. s/defined/declared/ (in some areas of Misra the distinction looks to be quite relevant, so being precise everywhere is helpful even if only to not leave uncertainty) > No functional changes. > > Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 14:47:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 14:47:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579989.908225 (Exim 4.92) (envelope-from ) id 1qTNzM-0006Zt-TB; Tue, 08 Aug 2023 14:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579989.908225; Tue, 08 Aug 2023 14:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNzM-0006Zm-Q6; Tue, 08 Aug 2023 14:47:12 +0000 Received: by outflank-mailman (input) for mailman id 579989; Tue, 08 Aug 2023 14:47:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTNzL-0006Zg-7K for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 14:47:11 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2045.outbound.protection.outlook.com [40.107.13.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 729da326-35fa-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 16:47:10 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB8958.eurprd04.prod.outlook.com (2603:10a6:102:20d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.21; Tue, 8 Aug 2023 14:46:38 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 14:46:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 729da326-35fa-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OJWE593TnzdxZu42I8QwikONsN+rurtok+RiovoIKnONWUaxRGBx/JJKpY84KY1UwFMId2MzzYj06BEu179eAaCMIDiijeHnbRRJExBUJuSpd85brt4tHHKJl9ggmU8izzkkajCvWPQWXC15Kj2y1W4rg2qgqmugRKtPrfQDDp8FYA0AGZHXKJnewET9ka3j6F2TCUUTzNhQLK5g0UvAjXWDGxmpEZbSMe+5fDkz8QrjaLTPL8HXTQi4c31sXBrfV2/tkfHbtTIZ+3z8ntMBw6o50zoR2/+2ds620HoUiq06XImSSOoqZjQH7K9NC/cZBUu1kZANMG6C7E1eT44/4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LFHFg9Drna9jR44+rSeaaZx+wNcat5CHqUdBCywA9k4=; b=ZsPpMSPe8+pJP9a0nGOoUBMhk/8qQIU5b4t+GLWtRaTZIYovpPwztzzrIMo9Nns05tAcorxfBaveU9iIww6/kFqqdYPO8csmgvPLJBkmKK3RYlikABKQQwDWoCvjr7zOQJ3vLBEasbQu3VGAXLcuQTiIGT8XQNvYo+omYsEZSvLqipib3uCGK7wPh9dJdo0t1mT/S7d82JChuFHzWarYM9jfqn8zQifehQSpTU93PpcpHAwtd71Q4qHrtyWYK8//PPk/epBOOLdsgKmK4+x1s/dsJ7+f316n18px3zvO8H2wQ7g0BMR05VxEXE+UMKiW3O1LU5PMkpb7Q0bcxx2Phw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LFHFg9Drna9jR44+rSeaaZx+wNcat5CHqUdBCywA9k4=; b=Pfqq4JrHvLV87LCkfkDwlId9F6Rs4V+pkzJTswGJbt64w5+++NnUcZM4lupe1Klu6Nx+df4Er5/mw8R9DSulilXADc5DCI0iTXjrnktm/9rWwXTDsaKkOQXMmf1H6/1f8Scj20Iy2iU0OpwiX2K8iUlUo++3zA0GZgUFWlDOpW7nKI7hnfy3n1o/L4luNh+m7OwAowVeT0qMu2S9v151+0icb9d1+EwuM9m5tSleAZLRMUK8HTEYA1NM9rhcQP2tfb8Qa9q3Y0Fyan2OiJGTUTqjBHB0NHqfZkBldW+RXDzZzxEua0DiD4snGBA9mz8DVGqXLwodKzWZVyI3vkXSJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e689708-5ea8-c3d9-10a1-3de5e2ecdab9@suse.com> Date: Tue, 8 Aug 2023 16:46:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h' Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <8df1af6384606d8176525fbffb364ec814d48db1.1691492441.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0241.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB8958:EE_ X-MS-Office365-Filtering-Correlation-Id: 21ec88d2-c3c8-4705-f082-08db981e453f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FSLQkKcmV2BhmxOisaTAjEQIj/NHzwoUSeHgfdZInToNlV7fRCxPilxteXtEg5PWvJRS7E3/gZtUlm+YQPkSQA5m1GOrcrl5WDslrPwym2EIINhWEXefG8hHdsDtDeHhySjTVXbwapSl7DMfZ0zzEaF1ffncaTczS5N0zUCo31JDdgZ5wp3/PvauQ0rlzOSWzHV9PT/Hd4kBeBDEpdOevufa+PnWBb6N93mrG6yoaSmajWqQMf7Ptp0AgYPDzodZ1sJOGRtpFcg/tBgJWoB6OT8yk6LrmrW4xS1PXiQkh4Eoer8f9eE7ld89NwmVvpEjxVJ4snid/ISQ2atnQyFoFXgtvUFK48Hd0s/dCAsVwLu7xMqXF3COdmK6yTAWB0mv8achhcko9QErfczr1G1U8J61ZTwgSWpDkAC9Aw/mSPr0Mk4s6/VNxxP5zWLka8q8n5B86sKXsR0hEp8wzVg/vtTVyOLV1VvoNKn6K1X68bTMtqNDH4PLjTuxuvlrdiu+NYekD32kG5bpXYiB3cbWb76mi8xiKSzRqo5QSlPqzn5YqH5IY5xKcSPOI6prIQaV9ukAGv7LPIso3LL80ifu1Wbt/jtGfZZffPtuaHjwH3h/HmZAsb0yu4MEmfhPhUbdSj19dSUoQ7Pv6qeE4YPE3A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(346002)(39860400002)(136003)(366004)(1800799003)(186006)(451199021)(8936002)(316002)(31686004)(8676002)(66946007)(66556008)(66476007)(6916009)(5660300002)(2906002)(4326008)(478600001)(54906003)(7416002)(4744005)(41300700001)(31696002)(86362001)(6486002)(6512007)(2616005)(36756003)(38100700002)(53546011)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzVtNXFZMWthRkMxTzJRdnEybUdvUlhkcGdEZ2tRM0QwcXZneGRRWUdCRXZm?= =?utf-8?B?ZzNpeFkyTlo1ak1EakJFQytzOFB4R2pHSmR0aXdIZmZ1ZGFNVFpoYkJGR0RI?= =?utf-8?B?TWRqU1gwOHUzblZ0emFqaUJTUFhlWHlOQjlnNnpwL1I4YnFVekpSTHlieXlj?= =?utf-8?B?NUZXRmVlai81WHpmVEc1VDJTdGhiMmVkMUhOTE5aNXhXdWFKR28rK3NUMDdK?= =?utf-8?B?Y09MNDlzSGMyNHFsTGZ5UGxZQjgvMTA3Y0xtaXF5QllLMnhESU1ZV0JtdElV?= =?utf-8?B?RWh4dGVDUzVzcHBZZG9ZbHg2a1M4NTVMRG5yOTU1VTB0M2NXWWRxSDRhWFQw?= =?utf-8?B?Mkt2dHhMTUVQaDB4Q1dmc3Fidjd5cW1pZktqQm5sQWFTcFZEdGNRZ2Q1Qlhu?= =?utf-8?B?a0JkaWtxcjhvNlg2a28yOVVWK2VETWZWelc5WDNjbVp1RjZ4TFJWWnFtbTVZ?= =?utf-8?B?bGp1OTVFaGpsM09UYVJSMXR3eFlIMVMrMUMyeWE0U0RQZVd1cEdtWkhCbkxL?= =?utf-8?B?SllEWTdDcVR5dDQrRnQ4TjQweWF4blBoMzJLRW8xUjJLWlhCSlB2bE1TUXdR?= =?utf-8?B?TE9ET3ovbHZiY1FiTDF2Mi9INGswUHpvR2E5RHFicWc0N2Exa2xhYk5ZZnpn?= =?utf-8?B?ZFBhK0VyV0oxR1h0NFZBdnJlZE5icFNvaElJZXNyQVJka3JIMnBXSFA3VTIr?= =?utf-8?B?NXYzK1pFRlhyNkdSZGpKN3hMb281YW5SSVplTXdudEErVGdsWGlXSjhFdENN?= =?utf-8?B?V0o3NFVqdzQwcEZSSFhOUTFTUHp3c1ZRWnVmb2RVNGZBSTljdFdjWlFrU2Ez?= =?utf-8?B?Wjd6QnhXei9CM1dMbWZKWGV4UldZUkwwNlB6Mm1mczFrZldaSmVBL2hDWnUw?= =?utf-8?B?eVNzWndvczVVeUtzYVZ4RnlrdldNRmFBQjIzWU5lV1J2ZUFwN3lNV0hSQ0cr?= =?utf-8?B?UXUrcS9HbExZTTI2c1hBZEhHVjA2di9XT3A3RmJWUDJYcytSUm5KR0NLQ1NS?= =?utf-8?B?S3JEUEJtVTlUMVIvdGo5OGlyVUlYdEQwbjlTd05paEg5SXQ4MmJGdjJhVXEv?= =?utf-8?B?QU9MelhqOUlpRzh4cGZkOUNlSThRWVpLdHpJUHhOR0xHOUJWcUNTWGJiTU41?= =?utf-8?B?WFF0TlU3dW9vNkRBcEw4YUxFQUNILzhIendJWU5oVzZQY0tpZkFmZHlsODBQ?= =?utf-8?B?RUhWVnpoZ1ZHcjVoMmlqMnJwbWIxd0p4d2FRVE92ODBIN2tLQjIxWlRoS0E1?= =?utf-8?B?bHIrZ1QvMGlUb1VNaUJtdFpZMG84TWd4NTN5ejk5LzVKUDlIdCt2NnBTS3ln?= =?utf-8?B?eWZCNjBsazh0dnZvRkg0eW5wSnpBdVcyamVuUTNZdGtGT3V4bXJiMUIxRGVJ?= =?utf-8?B?dkwvdE1WOFdmbWU0dmQ2RXUxcDZCMlNZaGxZbEZsOWhBaVJTU0xLV3VQaWhw?= =?utf-8?B?LzkvUmlYcE94VndvRThONUdlN20yWWc5dTRleXR1dCtyaGREdG13eFFNOEVE?= =?utf-8?B?dmJtZzNPaHU1Vlk0L1h3dlcyUkk4WE1uWFpGZWJTR1JLWDRJa0tOQ2xmL0pw?= =?utf-8?B?WURTU2s1Vmc5VXBEQytYWjYybmU3QkJUTldQMnRsV3p3MllBODdmcXYxc3Jy?= =?utf-8?B?RlBVZFVIWDIwV3piSHN6TElkNk9GZ29DLzRnUkRKdXFOOGNsMENYTS8wV1Ev?= =?utf-8?B?QmxZVTRLUDFtbThVM2JYZkVvZnN1V0xSTXM5U05yQm9WMUo0akE1YjUwN0dv?= =?utf-8?B?bU9TbWtOZzFtZFJpV3pCalVtc05MRGJKNVZjNW95NHRURDdITnVrdUtnc1F4?= =?utf-8?B?ZjkzS3QxTCtlRjFYZ2xhN3VJcjUwRkVNeUF6RlNycmFGME4xNTc2MEpiOVdG?= =?utf-8?B?UzlCa1RIc3laWEV0VThpTUsrRUhGQWcyaWdNeWdBY0JzWVYxRk1EeW5ob0J5?= =?utf-8?B?M2MyZHY0UkpDSndqdVhRS1JVSXVyMzljZjB3ek1VVzdGRVhGckFBY1ovVE1U?= =?utf-8?B?djV5VFA2QzFldXoxZ1EySnlYZVlQbGk1VG1lb2xxVlcwZGxQVmIzWDljWlZa?= =?utf-8?B?aXhVektsQ0tiNDRUb3k3Z3NXZzJTRTFXRms4YXpDVXh3QVpCaVh2eVFOSTNX?= =?utf-8?Q?3vfu+1CWOqtiBvxRq1pTwk9qG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21ec88d2-c3c8-4705-f082-08db981e453f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 14:46:38.2835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ojb+HJNHmgyFLt3J31jvbT0912VTjN4ZWoJ0T3yURPHUZFokxhJYE3i1FTmrWgRfbf/iPfXo58bQh4stTEU4mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8958 On 08.08.2023 13:08, Nicola Vetrini wrote: > The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised > to address the following concerns: > - needless underscore prefixes for parameter names; > - the variable 'i' in function 'mce_action' that is shadowed > by the local variable in the macro. > > Therefore, the refactoring aims to resolve present shadowing > issues, which violate MISRA C:2012 Rule 5.3, and lessen the > probability of future ones with some renames. > > No functional change. > > Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Aug 08 14:58:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 14:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.579995.908234 (Exim 4.92) (envelope-from ) id 1qTO9u-00088X-Qg; Tue, 08 Aug 2023 14:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 579995.908234; Tue, 08 Aug 2023 14:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTO9u-00088Q-O5; Tue, 08 Aug 2023 14:58:06 +0000 Received: by outflank-mailman (input) for mailman id 579995; Tue, 08 Aug 2023 14:58:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTO9t-00088A-2n; Tue, 08 Aug 2023 14:58:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTO9s-00075z-NX; Tue, 08 Aug 2023 14:58:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTO9s-00032f-CG; Tue, 08 Aug 2023 14:58:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTO9s-0005wO-Bn; Tue, 08 Aug 2023 14:58:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gS7RUyB6IZOdbY+hMx6hZfdpIm8NelETnx9jc/dvm+U=; b=VPlCpizGs9SF860EiXZVIB90HW RkhOKMkKDUYXjwWwScZAsjp0DL87goWpJ+El12CPBzkJRTfYnYCKxpwt4l5FrVFfG7cRzWuEiEAH2 GZHM3dqU+DI9UMepdxjuBxJtlZXnAowVhCeYhnMiuR5jBX7OR3f5glGrcgXEDi8RUIkA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182232: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46c5ef609b09cf51d7535aebbc05816eafca4c8d X-Osstest-Versions-That: xen=bd3ddaf6ee7fa312bd077305819105f84a34008d From: osstest service owner Date: Tue, 08 Aug 2023 14:58:04 +0000 flight 182232 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182232/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 46c5ef609b09cf51d7535aebbc05816eafca4c8d baseline version: xen bd3ddaf6ee7fa312bd077305819105f84a34008d Last test of basis 182229 2023-08-08 08:00:25 Z 0 days Testing same since 182232 2023-08-08 12:03:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bd3ddaf6ee..46c5ef609b 46c5ef609b09cf51d7535aebbc05816eafca4c8d -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 08 14:59:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 14:59:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580002.908245 (Exim 4.92) (envelope-from ) id 1qTOAr-0000E5-59; Tue, 08 Aug 2023 14:59:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580002.908245; Tue, 08 Aug 2023 14:59:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOAr-0000Dy-1S; Tue, 08 Aug 2023 14:59:05 +0000 Received: by outflank-mailman (input) for mailman id 580002; Tue, 08 Aug 2023 14:59:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOAp-0000Di-CP for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 14:59:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20610.outbound.protection.outlook.com [2a01:111:f400:7e1b::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1c5b17a4-35fc-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 16:59:02 +0200 (CEST) Received: from AS9PR0301CA0002.eurprd03.prod.outlook.com (2603:10a6:20b:468::15) by GVXPR08MB7800.eurprd08.prod.outlook.com (2603:10a6:150:2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 14:58:50 +0000 Received: from AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:468:cafe::ff) by AS9PR0301CA0002.outlook.office365.com (2603:10a6:20b:468::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 14:58:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT029.mail.protection.outlook.com (100.127.140.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44 via Frontend Transport; Tue, 8 Aug 2023 14:58:49 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Tue, 08 Aug 2023 14:58:49 +0000 Received: from 8265cc1e5107.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DB10868E-CF16-4D61-9BD1-6E2D12100997.1; Tue, 08 Aug 2023 14:58:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8265cc1e5107.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Aug 2023 14:58:38 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB8407.eurprd08.prod.outlook.com (2603:10a6:20b:55a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 14:58:35 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 14:58:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c5b17a4-35fc-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xF+8elf0srI676hurlCM6tUw+eU2R2hA6iovNjlb81w=; b=wpCyar7dsY/qpLcnHCRvJACMGHcU3Cuuxsn9oUcXRk47UaVL56Wv80tDwK+vHYXqmAvzWk1kx2X0THsACLZRrZSr+6qQ5I/LHQW1xid83beB45ZoFuV+SC8t5pHFc5TfIeI0LHkd+zZGaPKxwWXa0h1Opuj/V5Y49LzqNL1/YT8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 34de6929aae927cc X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AduSbX07SNLKOncIX37KHZuBlhyVwfkqM5zp1opMY+gdrJhN4QDJ6aEhPG2w0sCY0cTkvuTQXXfjskbgFxzn/CQucUwOEld2C82UhZDrNDF1fiW8u0HPmDoMzFDzBnh+jhtV7p7D01K+vEr0YZm69QCG0nKIvZL44c4eMGV0d0TCIn70tz2MMAeOHSkQV9KlhYuESjo5W/yflkXYSa9U1a1jOAOXer4hyySuckXVJvd8NXEOXyqOWxZt2iRs4ph+Vt6TSUexzDM2D33N1W7TdtMDp3ymu5O3fRZSni4LQU3fREHTfJEALA61m8Yluls2lscpkEoELI47PHjJFlj/OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xF+8elf0srI676hurlCM6tUw+eU2R2hA6iovNjlb81w=; b=WreL9ojM+GcTyYpMwGZcDWlEfd/ZASE+cxaBLbTtBgK9/oxE/xRSLjBb7VlDJ2ja1dYOBkMSSIMeN7KTshMsKAXP4wJHfef2rfTVjjsfbWA8yEGrWzbHM+P4V6DV44QyoDh1Z32dXlSJa8f67BVcmi32PkBiadXvOZJY198fbtiMAGyB+RzHgdUf1I9a87Ufsmh8ebXtj0S1vKrgRA4wyF2uDPDlPUzsojCxXLoiyB1bRjIiZ1mhH6bIxzl901qsETlj2ZsT8ZoxXD/FRGHagMfVUp+NRgZgTp1kkluzoFUnP/YemT1IowKBHwG92ivUZrv5U+kLkbU5Dc1zHDrRUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xF+8elf0srI676hurlCM6tUw+eU2R2hA6iovNjlb81w=; b=wpCyar7dsY/qpLcnHCRvJACMGHcU3Cuuxsn9oUcXRk47UaVL56Wv80tDwK+vHYXqmAvzWk1kx2X0THsACLZRrZSr+6qQ5I/LHQW1xid83beB45ZoFuV+SC8t5pHFc5TfIeI0LHkd+zZGaPKxwWXa0h1Opuj/V5Y49LzqNL1/YT8= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm64: head: Introduce a helper to flush local TLBs Thread-Topic: [PATCH] xen/arm64: head: Introduce a helper to flush local TLBs Thread-Index: AQHZyei3T61KAOi37UiuQYtlptp+oq/gfbsA Date: Tue, 8 Aug 2023 14:58:33 +0000 Message-ID: <416EFCDE-063D-416D-AEC4-8EA15BE0396C@arm.com> References: <20230808110739.1296-1-michal.orzel@amd.com> In-Reply-To: <20230808110739.1296-1-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB8407:EE_|AM7EUR03FT029:EE_|GVXPR08MB7800:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cf8b859-11e8-4813-430e-08db981ff957 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AuRBzEMlG8aHij+Zkr/OryrC3gywTiknIge8R4ZfTYt2gva7YO0UGGXFcXsW47vfQsh0hnvgtxrIA232BfAD65VJgs56+YJgN2sJJYxsiP+OPjZ9BqTqXT+3SJcavVayXX1QIECnSYydsCiDE3eJQX5MZ+7JtYcUit8IXigPqaXOkCAS+E5rh2eurwA36YDs0kSl+BgmfjfdxwIJYMoYwdcHsvDTn80NnNbddOxZaIxjPNFr5zKD6uwVDOSlDZWXAlmNAbqXABJxi79PeIQx0hwrm+IbkxFJLNudkrYvpZeMHee+u4jE7A/Aan8GRLj5SPyQ8nhkG8Cd1tp/h20tjuQmDLZImvPoSoMpVv/jjSXu/cub0nO2oNgkP9R6ux8oWAtbZDlkrzJOZ+s7tvmYOK7DmNT+U0V3RTNYsVsAlfC0uKhLo2k8plARrkMbRAXKc9IM4Cmaa+qWnCFJU1UNQXn8ZPhg7kvc1C3wI4iyfwI/JIw1jQjh1ypPL7TeLWjPnR/Md4JS3/cqBkMITEBpPnSmEMov7/IuAIJ8SikvD1R0xDUjxZ2A+3uPND76sniET97n13sRvhL9oOEkRXzviV4jAQLgxjR4e/8c/hJ5I9bS2MjVyGh5HYykC6uVMxFvU5rnA1Nu6bR0wf1DriRjhg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(39860400002)(366004)(451199021)(1800799003)(186006)(38070700005)(8676002)(8936002)(5660300002)(4326008)(6916009)(64756008)(41300700001)(316002)(86362001)(4744005)(2906002)(6512007)(71200400001)(6486002)(2616005)(53546011)(6506007)(26005)(36756003)(76116006)(91956017)(66446008)(66946007)(66476007)(66556008)(478600001)(122000001)(54906003)(38100700002)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <470368FCCD51AE4A8E324E8419882240@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8407 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 08c42f3a-8621-4709-1053-08db981fef76 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i83qHe7T29CMSF404T8YgiM5EF1Nv7II4XplhrCXZHmVI/OI60nk/wK6PK1+TCeyMIwG5r19dPRxHzRztARwKxnmxb39rLApznAe1toOXye2lqg+XZIrd+a6x5NFLpc5B3O0/JWTdU0YseLW7NaOLxLSVNQ8w71Mbo4/kEd2OiyppwJlaLxaIMU6hihtUvn1P6NK+WC2X7kpyLcXBla5hu2shFHZXQpMtgmRYV/pGw2KKDlcUFui7kIJX5+Ov6TCJy0ECgk1XGZY0yl0My3VByZ0O/A8PmDrdPe9GJWqdkPC3mrPP/k6VUEgGieoT4oL4qr9nv1tLMuXIT9rGfdYy5+UWg13xfTJF4UkmupcmAMmQYYvIjBMCeYu1JdCfsqkcuCKJ/CHcaJMjQ7NIbyBZtsUytUcNljn+ImSwR0lZyAw4CyacE8z2i0HD6XKW6jGZaECa0gnWpcc9sm2FxdcbCXwRJ/uIiNgDYD73V8k83nx+51bvZ1Mf1mhzOcrMgKmNzH00AMyVi4Q3fMXeY+8w35UAHNn7ofva8zTHPRqQQq88LJUZ4f+ked0AySjT6UmfYT5foIiM1OdzhKrPvCB9Y3ysxJzJb934oKSAGab5BKM4R0VV1ML4HWVSog/+7lnyejgdayMPa+RivVpcohGxns8Yq4+kYK50106rShL990zq9mmr/0KAFV0P1JrKPOfgGRo4igd4rigbk6LaxLmqZro2Z2/BTFL2sZ5mTfO5JPh/6ETR+LRhfxDjLmXXlgS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(136003)(82310400008)(451199021)(1800799003)(186006)(40470700004)(36840700001)(46966006)(2906002)(4744005)(47076005)(40480700001)(41300700001)(40460700003)(5660300002)(8936002)(8676002)(6862004)(33656002)(36756003)(36860700001)(86362001)(6486002)(81166007)(6512007)(82740400003)(478600001)(356005)(54906003)(336012)(2616005)(316002)(107886003)(4326008)(70206006)(26005)(6506007)(70586007)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 14:58:49.7085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf8b859-11e8-4813-430e-08db981ff957 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7800 > On 8 Aug 2023, at 12:07, Michal Orzel wrote: >=20 > Instead of repeating the same sequence of instructions to flush the TLBs > in various places, introduce a macro flush_xen_tlb_local and make use of > it. This is similar to what was done for arm32 by the commit: > dea9dddeceec8a1d68da24b14d5b2396effe555f >=20 > This is also making the flush sequence in enable_mmu more clear and > consistent. >=20 > Signed-off-by: Michal Orzel > --- Hi Michal, Looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:05:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:05:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580010.908254 (Exim 4.92) (envelope-from ) id 1qTOGs-0001sH-Tx; Tue, 08 Aug 2023 15:05:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580010.908254; Tue, 08 Aug 2023 15:05:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOGs-0001sA-RU; Tue, 08 Aug 2023 15:05:18 +0000 Received: by outflank-mailman (input) for mailman id 580010; Tue, 08 Aug 2023 15:05:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOGs-0001s4-Aj for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:05:18 +0000 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by se1-gles-sth1.inumbo.com (Halon) with SMTP id fa967014-35fc-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:05:15 +0200 (CEST) Received: (qmail 161982 invoked by uid 1000); 8 Aug 2023 11:05:14 -0400 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa967014-35fc-11ee-b280-6b7b168915f2 Date: Tue, 8 Aug 2023 11:05:14 -0400 From: Alan Stern To: Greg KH Cc: Zhang Shurong , jgross@suse.com, xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control() Message-ID: References: <2023062628-shame-ebook-56f2@gregkh> <4825193.GXAFRqVoOG@localhost.localdomain> <2023080659-turban-exemption-1196@gregkh> <3481a644-1648-4fa9-86eb-2a0b86b8f47a@rowland.harvard.edu> <2023080845-talisman-ravage-0b58@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023080845-talisman-ravage-0b58@gregkh> On Tue, Aug 08, 2023 at 10:26:38AM +0200, Greg KH wrote: > On Sun, Aug 06, 2023 at 11:15:51AM -0400, Alan Stern wrote: > > On Sun, Aug 06, 2023 at 04:27:27PM +0200, Greg KH wrote: > > > On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > > > > 在 2023å¹´7月1日星期六 CST 下åˆ11:51:43，Zhang Shurong 写é“ï¼ > > > > > 在 2023å¹´6月26日星期一 CST 下åˆ1:52:02，您写é“ï¼ > > > > > > > > > > > On Mon, Jun 26, 2023 at 07:48:05AM +0200, Jan Beulich wrote: > > > > > > > On 25.06.2023 18:42, Zhang Shurong wrote: > > > > > > > > --- a/drivers/usb/host/xen-hcd.c > > > > > > > > +++ b/drivers/usb/host/xen-hcd.c > > > > > > > > @@ -456,6 +456,8 @@ static int xenhcd_hub_control(struct usb_hcd *hcd, > > > > > > > > __u16 typeReq, __u16 wValue,> > > > > > > > > > > > > > > > > > info->ports[wIndex - 1].c_connection = > > > > > > > > > > false; > > > > > > > > > > > > > fallthrough; > > > > > > > > > > > > > > > > default: > > > > > > > > + if (wValue >= 32) > > > > > > > > + goto error; > > > > > > > > > > > > > > > > info->ports[wIndex - 1].status &= ~(1 > > > > > > > > > > << wValue); > > > > > > > > > > > > Even 31 is out of bounds (as in: UB) as long as it's 1 here rather > > > > > > > than 1u. > > > > > > > > > > > > Why isn't the caller fixed so this type of value could never be passed > > > > > > to the hub_control callback? > > > > > > > > > > > > thanks, > > > > > > > > > > > > greg k-h > > > > > > > > > > Although I'm not knowledgeable about the USB subsystem, I've observed that > > > > > not all driver code that implements hub_control callback performs a shift > > > > > operation on wValue, and not all shift operations among them cause > > > > > problems. Therefore, I've decided to fix this issue within each driver > > > > > itself. > > > > > > > > > > For example, in r8a66597_hub_control, it will first check whether wValue is > > > > > valid (always < 31) before the shift operation. In case of an invalid > > > > > number, the code would execute the error branch instead of the shift > > > > > operation. > > > > > > > > > > switch (wValue) { > > > > > case USB_PORT_FEAT_ENABLE: > > > > > rh->port &= ~USB_PORT_STAT_POWER; > > > > > break; > > > > > case USB_PORT_FEAT_SUSPEND: > > > > > break; > > > > > case USB_PORT_FEAT_POWER: > > > > > r8a66597_port_power(r8a66597, port, 0); > > > > > break; > > > > > case USB_PORT_FEAT_C_ENABLE: > > > > > case USB_PORT_FEAT_C_SUSPEND: > > > > > case USB_PORT_FEAT_C_CONNECTION: > > > > > case USB_PORT_FEAT_C_OVER_CURRENT: > > > > > case USB_PORT_FEAT_C_RESET: > > > > > break; > > > > > default: > > > > > goto error; > > > > > } > > > > > rh->port &= ~(1 << wValue); > > > > > > > > Hi there. I apologize for reaching out once more. I'm feeling a bit puzzled > > > > about what my next step should be. I'm unsure whether I should rewrite this > > > > patch or attempt to address the issue at the caller level. > > > > > > Try addressing it at the caller level first please. If that somehow > > > does not work, then we will take a patch series that fixes all of the > > > host controller drivers at once. > > > > It's not feasible to fix all the callers, because the calls can come > > from userspace via usbfs. > > It can? Hm, that happens through the call in rh_call_control(), right? > But there, we do a bunch of validation before calling hub_control() so > why can't we do the same thing in that one place as well? Making > invalid requests from userspace should be disallowed (or we can catch > this in the usbfs interface.) Yes, we could filter these things out at either spot. But that's not the best approach. The reason xen-hcd.c needs this change in the first place is because the code is buggy, and the change does not fix the real bug. Section 11.24.2.2 (CLEAR PORT FEATURE) of the USB-2 spec says: It is a Request Error if wValue is not a feature selector listed in Table 11-17, if wIndex specifies a port that does not exist, or if wLength is not as specified above. xenhcd_hub_control() validates wIndex but not wValue. (In theory we should validate wLength also, but in practice it doesn't matter.) Here's an example from the code: case ClearPortFeature: if (!wIndex || wIndex > ports) goto error; switch (wValue) { case USB_PORT_FEAT_SUSPEND: xenhcd_rhport_resume(info, wIndex); break; case USB_PORT_FEAT_POWER: xenhcd_rhport_power_off(info, wIndex); break; case USB_PORT_FEAT_ENABLE: xenhcd_rhport_disable(info, wIndex); break; case USB_PORT_FEAT_C_CONNECTION: info->ports[wIndex - 1].c_connection = false; default: info->ports[wIndex - 1].status &= ~(1 << wValue); This line is wrong, and not just because wValue might be too large. The only status bits that should be manipulated are the ones controlling features the driver actually implements. Not random bits passed in by the caller! break; } break; So here's what the code _should_ look like (just the end part): case USB_PORT_FEAT_C_CONNECTION: info->ports[wIndex - 1].c_connection = false; fallthrough; case USB_PORT_FEAT_C_RESET: case USB_PORT_FEAT_C_ENABLE: case USB_PORT_FEAT_C_SUSPEND: info->ports[wIndex - 1].status &= ~(1 << wValue); break; default: goto error; } break; (Perhaps also include USB_PORT_FEAT_C_OVER_CURRENT and USB_PORT_FEAT_INDICATOR, depending on whether the driver supports them.) This way the driver does the right thing in all cases and it never runs the risk of a shift amount being too big. The other HCD drivers are written this way. Similar reasoning applies to the SetPortFeature section. Alan Stern From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:09:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:09:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580017.908265 (Exim 4.92) (envelope-from ) id 1qTOKq-0002UF-9S; Tue, 08 Aug 2023 15:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580017.908265; Tue, 08 Aug 2023 15:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOKq-0002U8-6t; Tue, 08 Aug 2023 15:09:24 +0000 Received: by outflank-mailman (input) for mailman id 580017; Tue, 08 Aug 2023 15:09:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOKp-0002U1-IB for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:09:23 +0000 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8bc2ba54-35fd-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:09:20 +0200 (CEST) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RKxMc1GBVztRt1; Tue, 8 Aug 2023 23:05:48 +0800 (CST) Received: from localhost (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 23:09:16 +0800 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bc2ba54-35fd-11ee-b280-6b7b168915f2 From: Yue Haibing To: , , , CC: Subject: [PATCH -next] xen-pciback: Remove unused function declarations Date: Tue, 8 Aug 2023 23:09:12 +0800 Message-ID: <20230808150912.43416-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected Commit a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.") declared but never implemented these functions. Signed-off-by: Yue Haibing --- drivers/xen/xen-pciback/conf_space_quirks.h | 2 -- drivers/xen/xen-pciback/pciback.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/xen/xen-pciback/conf_space_quirks.h b/drivers/xen/xen-pciback/conf_space_quirks.h index d873abe35bf6..fc1557dfef49 100644 --- a/drivers/xen/xen-pciback/conf_space_quirks.h +++ b/drivers/xen/xen-pciback/conf_space_quirks.h @@ -21,8 +21,6 @@ struct xen_pcibk_config_quirk { int xen_pcibk_config_quirks_add_field(struct pci_dev *dev, struct config_field *field); -int xen_pcibk_config_quirks_remove_field(struct pci_dev *dev, int reg); - int xen_pcibk_config_quirks_init(struct pci_dev *dev); void xen_pcibk_config_field_free(struct config_field *field); diff --git a/drivers/xen/xen-pciback/pciback.h b/drivers/xen/xen-pciback/pciback.h index 9a64196e831d..f9599ed2f2e2 100644 --- a/drivers/xen/xen-pciback/pciback.h +++ b/drivers/xen/xen-pciback/pciback.h @@ -201,6 +201,3 @@ static inline void xen_pcibk_lateeoi(struct xen_pcibk_device *pdev, int xen_pcibk_xenbus_register(void); void xen_pcibk_xenbus_unregister(void); #endif - -/* Handles shared IRQs that can to device domain and control domain. */ -void xen_pcibk_irq_handler(struct pci_dev *dev, int reset); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:10:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:10:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580022.908274 (Exim 4.92) (envelope-from ) id 1qTOLo-0003ra-Jd; Tue, 08 Aug 2023 15:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580022.908274; Tue, 08 Aug 2023 15:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOLo-0003rT-Gx; Tue, 08 Aug 2023 15:10:24 +0000 Received: by outflank-mailman (input) for mailman id 580022; Tue, 08 Aug 2023 15:10:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOLn-0003rJ-Tr for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:10:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2050.outbound.protection.outlook.com [40.107.7.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b23016d8-35fd-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:10:23 +0200 (CEST) Received: from FRYP281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::21) by DU0PR08MB9418.eurprd08.prod.outlook.com (2603:10a6:10:421::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Tue, 8 Aug 2023 15:09:51 +0000 Received: from VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:0:cafe::77) by FRYP281CA0011.outlook.office365.com (2603:10a6:d10::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.16 via Frontend Transport; Tue, 8 Aug 2023 15:09:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VI1EUR03FT039.mail.protection.outlook.com (100.127.144.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45 via Frontend Transport; Tue, 8 Aug 2023 15:09:50 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Tue, 08 Aug 2023 15:09:49 +0000 Received: from 475518f4f4a6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3ABC8230-D378-487F-A7F6-DC6C2B638105.1; Tue, 08 Aug 2023 15:08:42 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 475518f4f4a6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Aug 2023 15:08:42 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM8PR08MB5570.eurprd08.prod.outlook.com (2603:10a6:20b:1d2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 15:08:40 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 15:08:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b23016d8-35fd-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LR531HV0oY4lV7VgzQe4AkX5MZLRVgBb2FpikOdOUg8=; b=4U9P9lgiK8WLsyEiLeKo+WjTlMPwFUAMAKVpavbTzLAJvICUJ9WtTIZE1sv796v95isWLLHlbk3T/QN1AOWqwJ4bbO0vMDQ5693e0Gnz3YiZ7v3O75B0mdPIikG4xAL38nMX3PV35OQfvd21Z0GFed7jMcxZr+ccUNt26YH8Ad0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d65cbdfe526c7782 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAHcJ+JOVMUeQ/3Z1pG7lqAVX6cO/4ui6+MuAP4rhiYCOECz9B9zDWgalouPcnVUaw+4ESmNwquMWSyDBak3yjcX6iyQ870BVssGgDVINIzcv1V7GtP2Tuv6wHa4R1lj7nqoAQbjtNPNzfW3E3gInUZlAl1QneeZdxaGv8SvdHREAXb5KYzVnN7XLvcOyhIaRHEI4aoeG1hHpwQ5ClhuCScg+TnmNkv0Z7FYEwGBhCGcxpK7jiddU1ahLvFhEX8D3ukdVO4n/ECb3GT/EcVqsmXbmaSioYcN0uOpNVWyMFyUT3R+Lm2XYc/0fql6QZ9jT7k0U8d7Y8j81LtQVdRO0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LR531HV0oY4lV7VgzQe4AkX5MZLRVgBb2FpikOdOUg8=; b=HMwsirfTTKamCsO84s+DfEuq03sgHCNuDgBtlBN1Y+HOw9FiLuy0+6bmfmrLgjQmBd83IHKKLlON5JFd4NmRSQBMUCt0IzKxa0Z6yfgIFEw0nuc6HllKVqn3rWQhZ+MoBF4rznq+u5LSUk2M/ry16BSsNjnG7MnAGU14UUedArNzJeoksODcR2M9yBIc3eBI2XeT05izUxjjo6McrDK3RRh9P2r9h7LK5iC6K8WoqmXEGqju57EjU0A5EZEJhFkbhQ4JkXvd+lg/ANhZegI3WjBb/EhvlrRj+dNJvvQFrjqMXD7+5LZj+ceZntysU34KWlaUHwnG1ZUZADqK34C5Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LR531HV0oY4lV7VgzQe4AkX5MZLRVgBb2FpikOdOUg8=; b=4U9P9lgiK8WLsyEiLeKo+WjTlMPwFUAMAKVpavbTzLAJvICUJ9WtTIZE1sv796v95isWLLHlbk3T/QN1AOWqwJ4bbO0vMDQ5693e0Gnz3YiZ7v3O75B0mdPIikG4xAL38nMX3PV35OQfvd21Z0GFed7jMcxZr+ccUNt26YH8Ad0= From: Luca Fancellu To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio , Tamas K Lengyel Subject: Re: [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info() Thread-Topic: [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info() Thread-Index: AQHZyfBJrIpFu/4jlkOaspAEusf4b6/ggH4A Date: Tue, 8 Aug 2023 15:08:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM8PR08MB5570:EE_|VI1EUR03FT039:EE_|DU0PR08MB9418:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cf4f673-021c-4176-90f7-08db982182f1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C3uozCephDrjXiuj05xMEVeIi9HxA1X/4vWhElrgVOc6T6sgB9Jegk19DfKv7kAIMPoYJynVbapsLVHaaft+KJfu4YooBWIhVLvntcCTlOpbZikyG1txaJXk0y+k0kuzNI2sXGP8UtShp+W8hSKuzYnXwFx1lx+ESaOntEsD91UAH5X0/IyJcKNmQOPPPrIpAjAqlMevLUguLfz1bfukzv+wxhzAlbVRUKpt9wl/eVQquK8/ysrsvl8BCouhv/5S2aDh36fd8lqXQZpLYKPG0pNXrg0r+zP7Tpq5c1xLOOUrpDBCR8tE7rGNjFhcmLONWD5n0qTdM7AXyABaugbW1g4mwx5kp+YH0odd6pgr8uCGAl89n86Esz4Ov/csbUCUbtq0G5RBSCTpMtN/h5HBFc+cDVc4/74+1Qeryvn0TD32G8Mc9C7NO1kBJUYI/PMstQDUZJcOHlZKWbtqWjBsirYiYe205YPWA0o+szQaYQfIDq8Za9aZt6f5rHWTxY2Ff3eWuJT7EtC6xvZocs7wgkrlAJqTVgQ5pVpM7I2z5Sc52px1ZQGfmJNi5OgmUEQ3q9nmTh1LmxOtkBorP4/XIdkI/1jFGNhtXDZY/YcHSBtaMuODgvcAJ+Xnr+USxmUoDYjxVUaaymp2LoUktamH4A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(366004)(346002)(396003)(39850400004)(1800799003)(186006)(451199021)(2616005)(122000001)(478600001)(6486002)(66556008)(6512007)(53546011)(26005)(6506007)(33656002)(64756008)(66476007)(41300700001)(76116006)(91956017)(316002)(8676002)(4326008)(8936002)(66946007)(66446008)(2906002)(6916009)(71200400001)(54906003)(36756003)(38100700002)(38070700005)(86362001)(5660300002)(7416002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5570 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ecc51250-5664-4de8-5f14-08db98215911 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MvKObE3HSM2wlnbmLu6T6ilolNUOy/bISFgmc5F5jwqQ5POoZtDiQ7qnxi/SRBiPoi5B6aY2wMhUwUXqlS90fwhOFII1AZZz2MQm1kZUKXVngxre/RiI4Vj/q9UJg0erBmPINGmpvSccO7W5pl50HeXnaVJZ6N1wUQ827mddsSM4xl9w0rrIAucAfMWOKZ5bN77H/P/uN6VFJkUVmgulQEHDuc4jtbcQIIk6Xl3F+Enf6fC5+DyosIbNu7ti05/OkgNIBEJLKZB9oYm/TmSo4EKg3qs1QubwBg5EAQWkCpA+lCtTzOQPea+YjY6XHUPM+g396eujJdezQJ+Sg7uHpHDA4uSfzaYddPFlkAf8Z2lWm7VN6HZsufvK0B9di+9X4Ymq14cu2FTNRPoYKxQOkBDeKXYZW9p021JwyoDI60S7dQyDVuXDva1h0dGfEuN5wh4Px5dkm8mkN1VzQShriqV22CtCiWR89t17+7Y0B9HNvTsPwh14gZzTiuB30pDQB+I/nJqncyEFJEC2ttHKMvbkHmIV048S6H7cc58cF4nHjZ16z47MseuJ8DMWVLEEJ1ZvWA4R4mgXjik7A4+fE/uK0nrJILucrQ++CIoaEkBr9SBDj2K9sUxQ/BsOrIOyNU/eBKdXzAuJqTAGQIXb0oymCuw630xzpVh8Gp4dldlbzCh1QOKcTGwlJTNk8UA0+Ju5P/vOfukMCxlNF9nspn0GA6YDj2x9yR0mdgElF7YXjpz5+4uMQ0iYtusF6VMl X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39850400004)(396003)(376002)(346002)(136003)(186006)(1800799003)(451199021)(82310400008)(46966006)(36840700001)(40470700004)(47076005)(6512007)(2906002)(36756003)(5660300002)(2616005)(36860700001)(54906003)(6486002)(70206006)(70586007)(356005)(33656002)(4326008)(82740400003)(316002)(81166007)(40480700001)(41300700001)(86362001)(107886003)(40460700003)(8676002)(26005)(8936002)(6862004)(6506007)(336012)(53546011)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:09:50.0175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cf4f673-021c-4176-90f7-08db982182f1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VI1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9418 > On 8 Aug 2023, at 13:02, Jan Beulich wrote: >=20 > When !MEM_SHARING no useful output is produced. Move the function into > mm/mem_sharing.c while conditionalizing the call to it, thus allowing to > drop it altogether from Arm (and eliminating the need to introduce stubs > on PPC and RISC-V). >=20 > Signed-off-by: Jan Beulich > --- > I wasn't really sure whether introducing a stub in xen/mm.h would be any > better than adding the (further) #ifdef to dump_domains(). >=20 > We could go further and also eliminate the need for the stub variants > of mem_sharing_get_nr_{shared,saved}_mfns() by moving the > XENMEM_get_sharing_{shared,freed}_pages cases in > {,compat_}arch_memory_op() into the already existing #ifdef-s there. > Returning an error for those sub-ops may be slightly more appropriate > than returning 0 when !MEM_SHARING. >=20 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1297,10 +1297,6 @@ void free_init_memory(void) > printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>= >10); > } >=20 > -void arch_dump_shared_mem_info(void) > -{ > -} > - Hi Jan, For the arm part: Reviewed-by: Luca Fancellu #arm From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:14:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580031.908300 (Exim 4.92) (envelope-from ) id 1qTOPx-0004mg-Q5; Tue, 08 Aug 2023 15:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580031.908300; Tue, 08 Aug 2023 15:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOPx-0004lv-JW; Tue, 08 Aug 2023 15:14:41 +0000 Received: by outflank-mailman (input) for mailman id 580031; Tue, 08 Aug 2023 15:14:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOPw-0004UR-KW for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:14:40 +0000 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [2a00:1450:4864:20::22f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ae78a6b-35fe-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:14:39 +0200 (CEST) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b974031aeaso89851441fa.0 for ; Tue, 08 Aug 2023 08:14:39 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id i19-20020a2e8093000000b002ba053e1f9bsm2319794ljg.35.2023.08.08.08.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 08:14:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ae78a6b-35fe-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691507678; x=1692112478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zBo4a0LOmDp0vEKiKru6TZXuvShqIRQBxpU/AyLezzQ=; b=W3sPxy5JVA9DZUH6+fZtB1MMqE9D1LYuuritC/SsrYZSIN9CAtWdnURRVd0oOmitmH qJUJPATaxTtZGG4cFzq27S0w4vYxbZBCUurObCxz7xFWCZinQx80cQh4djxTC+fKYK78 WHXM2lPKbweGA0gm7YlGLl0Nf97ZaU+wdUtwcJ8qfX93Gkc3TNS8DyT3vodbpaveN/fR gxFEo4H/BF4um5bflbihsECUdDK05w5qr0vU3lWwZrn02BNS8BtJZA+pCW4kxYg4Zp/o N84/EuKlhgH3AXeiC/b53dymF+wHHxeg5xHzD5oJK4XJ8XcT1F6RMYJYNJOCKtvkzqkv GYtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691507678; x=1692112478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zBo4a0LOmDp0vEKiKru6TZXuvShqIRQBxpU/AyLezzQ=; b=CWV/rj3sxJVF/qp5G5oY9gr6TvJlSxtAtJXPxhimBtJ2zbbjcHY1OG1iM7BaAUTK2r jR9hWya7TE/eG4wFlZUJoDtwgnuDG66XeaH4BsshGaepR2iW3vXCqK30fEzKGwEUTrRK OgLTarixsifO+CeBwDEXHLk7VL46/xJ+oMkEIuz5n4Tl0zma+OJNTQKlpaT/4NrExc/A R4LdvbeEBhDhP5d8SOnhXTL8My9GWsIynT4LMt1FsjsTuotOucvkcYwfiw6v/UrnR6IT xnTSnXH5jQrLsVKcSLTeGq41WirWkugtvjdJmtNMfiUojQtOJQEsNy6Ihhm/htamqTd6 ei9w== X-Gm-Message-State: AOJu0YwBW9qez9Ydvez/V5+0i3/cNjP4oVrvamlBMn/KfR6Oew/ns0ga 18jVaWqKrKuSiBVA5m/rNjnlFD6olgM= X-Google-Smtp-Source: AGHT+IEFvXB/+IbxQgNVpghbUdJMZXkb/OylUu793A5PEzUAfDWm0qCdCXMMhDENg8zS/aq6K/3cgQ== X-Received: by 2002:a2e:3c05:0:b0:2b6:d6e1:a191 with SMTP id j5-20020a2e3c05000000b002b6d6e1a191mr9172586lja.23.1691507678228; Tue, 08 Aug 2023 08:14:38 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 2/2] xen/riscv: introduce identity mapping Date: Tue, 8 Aug 2023 18:14:34 +0300 Message-ID: <177ad805a6508cf4adc9f54c20333ebcf12c333b.1691507564.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The way how switch to virtual address was implemented in the commit e66003e7be ("xen/riscv: introduce setup_initial_pages") isn't safe enough as: * enable_mmu() depends on hooking all exceptions and pagefault. * Any exception other than pagefault, or not taking a pagefault causes it to malfunction, which means you will fail to boot depending on where Xen was loaded into memory. Instead of the proposed way of switching to virtual addresses was decided to use identity mapping for area which constains needed code to switch from identity mapping and after switching to virtual addresses, identity mapping is removed from page-tables in the following way: search for top-most page table entry and remove it. Fixes: e66003e7be ("xen/riscv: introduce setup_initial_pages") Signed-off-by: Oleksii Kurochko Suggested-by: Andrew Cooper --- Changes in V7: - use srli instruction to be consistent with slli instruction in turn_on_mmu() --- Changes in V6: - t2 register was renamed to t1 as t1 isn't used anymore in turn_on_mmu(). - fold li, sll instructions to slli. - use a0 directly to calculate an argument of turn_on_mmu() instead of t0. --- Changes in V5: - update the algo of identity mapping removing. - introduce IDENT_AREA_SIZE. - introduce turn_on_mmu() function to enable and switch from 1:1 mapping. - fix typo in PGTBL_INITIAL_COUNT define. - update the comment above PGTBL_INITIAL_COUNT. - update the commit message. --- Changes in V4: - remove definition of ARRAY_SIZE and ROUNDUP as was introduced where these macros are located now. - update definition of PGTBL_INITIAL_COUNT - update the commit message - update the algo of identity mapping removing --- Changes in V3: - remove unrelated to the patch changes ( SPDX tags in config.h ). - update definition of PGTBL_INITIAL_COUNT taking into account identity mapping. - refactor remove_identity_mapping() function. - add explanatory comments in xen.lds.S and mm.c. - update commit message. - move save/restore of a0/a1 registers to [PATCH v2 2/3] xen/riscv: introduce function for physical offset calculation. --- Changes in V2: - update definition of PGTBL_INITIAL_COUNT and the comment above. - code style fixes. - 1:1 mapping for entire Xen. - remove id_addrs array becase entire Xen is mapped. - reverse condition for cycle inside remove_identity_mapping(). - fix page table walk in remove_identity_mapping(). - update the commit message. - add Suggested-by: Andrew Cooper - save hart_id and dtb_addr before call MMU related C functions. - use phys_offset variable instead of doing calcultations to get phys offset in head.S file. ( it can be easily done as entire Xen is 1:1 mapped ) - declare enable_muu() as __init. --- xen/arch/riscv/include/asm/acpi.h | 6 ++ xen/arch/riscv/include/asm/config.h | 2 + xen/arch/riscv/include/asm/mm.h | 5 +- xen/arch/riscv/mm.c | 90 +++++++++++++++-------------- xen/arch/riscv/riscv64/head.S | 30 ++++++++++ xen/arch/riscv/setup.c | 14 +---- xen/arch/riscv/xen.lds.S | 11 ++++ 7 files changed, 103 insertions(+), 55 deletions(-) create mode 100644 xen/arch/riscv/include/asm/acpi.h diff --git a/xen/arch/riscv/include/asm/acpi.h b/xen/arch/riscv/include/asm/acpi.h new file mode 100644 index 0000000000..3aef993d81 --- /dev/null +++ b/xen/arch/riscv/include/asm/acpi.h @@ -0,0 +1,6 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef __ASM_RISCV_ACPI_H +#define __ASM_RISCV_ACPI_H + +#endif /* __ASM_RISCV_ACPI_H */ diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h index fa90ae0898..f0544c6a20 100644 --- a/xen/arch/riscv/include/asm/config.h +++ b/xen/arch/riscv/include/asm/config.h @@ -95,6 +95,8 @@ #define RV_STAGE1_MODE SATP_MODE_SV32 #endif +#define IDENT_AREA_SIZE 64 + #endif /* __RISCV_CONFIG_H__ */ /* * Local variables: diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h index 7b94cbadd7..07c7a0abba 100644 --- a/xen/arch/riscv/include/asm/mm.h +++ b/xen/arch/riscv/include/asm/mm.h @@ -13,8 +13,11 @@ extern unsigned char cpu0_boot_stack[]; void setup_initial_pagetables(void); void enable_mmu(void); -void cont_after_mmu_is_enabled(void); + +void remove_identity_mapping(void); unsigned long calc_phys_offset(void); +void turn_on_mmu(unsigned long ra); + #endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index a73f135a3c..053f043a3d 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include @@ -35,8 +36,11 @@ static unsigned long __ro_after_init phys_offset; * * It might be needed one more page table in case when Xen load address * isn't 2 MB aligned. + * + * CONFIG_PAGING_LEVELS page tables are needed for the identity mapping, + * except that the root page table is shared with the initial mapping */ -#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) + 1) +#define PGTBL_INITIAL_COUNT ((CONFIG_PAGING_LEVELS - 1) * 2 + 1) pte_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) stage1_pgtbl_root[PAGETABLE_ENTRIES]; @@ -75,6 +79,7 @@ static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, unsigned int index; pte_t *pgtbl; unsigned long page_addr; + bool is_identity_mapping = map_start == pa_start; if ( (unsigned long)_start % XEN_PT_LEVEL_SIZE(0) ) { @@ -108,16 +113,18 @@ static void __init setup_initial_mapping(struct mmu_desc *mmu_desc, { unsigned long paddr = (page_addr - map_start) + pa_start; unsigned int permissions = PTE_LEAF_DEFAULT; + unsigned long addr = is_identity_mapping + ? page_addr : LINK_TO_LOAD(page_addr); pte_t pte_to_be_written; index = pt_index(0, page_addr); - if ( is_kernel_text(LINK_TO_LOAD(page_addr)) || - is_kernel_inittext(LINK_TO_LOAD(page_addr)) ) - permissions = - PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; + if ( is_kernel_text(addr) || + is_kernel_inittext(addr) ) + permissions = + PTE_EXECUTABLE | PTE_READABLE | PTE_VALID; - if ( is_kernel_rodata(LINK_TO_LOAD(page_addr)) ) + if ( is_kernel_rodata(addr) ) permissions = PTE_READABLE | PTE_VALID; pte_to_be_written = paddr_to_pte(paddr, permissions); @@ -211,6 +218,13 @@ void __init setup_initial_pagetables(void) unsigned long linker_start = LOAD_TO_LINK(load_start); unsigned long linker_end = LOAD_TO_LINK(load_end); + unsigned long ident_start; + unsigned long ident_end; + + /* + * If the overlapping check will be removed then remove_identity_mapping() + * logic should be updated. + */ if ( (linker_start != load_start) && (linker_start <= load_end) && (load_start <= linker_end) ) { @@ -232,48 +246,40 @@ void __init setup_initial_pagetables(void) linker_start, linker_end, load_start); + + if ( linker_start == load_start ) + return; + + ident_start = (unsigned long)turn_on_mmu & XEN_PT_LEVEL_MAP_MASK(0); + ident_end = ident_start + PAGE_SIZE; + + setup_initial_mapping(&mmu_desc, + ident_start, + ident_end, + ident_start); } -void __init noreturn noinline enable_mmu() +void __init remove_identity_mapping(void) { - /* - * Calculate a linker time address of the mmu_is_enabled - * label and update CSR_STVEC with it. - * MMU is configured in a way where linker addresses are mapped - * on load addresses so in a case when linker addresses are not equal - * to load addresses, after MMU is enabled, it will cause - * an exception and jump to linker time addresses. - * Otherwise if load addresses are equal to linker addresses the code - * after mmu_is_enabled label will be executed without exception. - */ - csr_write(CSR_STVEC, LOAD_TO_LINK((unsigned long)&&mmu_is_enabled)); - - /* Ensure page table writes precede loading the SATP */ - sfence_vma(); + unsigned int i; + pte_t *pgtbl; + unsigned int index, xen_index; + unsigned long ident_start = + LINK_TO_LOAD(turn_on_mmu) & XEN_PT_LEVEL_MAP_MASK(0); - /* Enable the MMU and load the new pagetable for Xen */ - csr_write(CSR_SATP, - PFN_DOWN((unsigned long)stage1_pgtbl_root) | - RV_STAGE1_MODE << SATP_MODE_SHIFT); + for ( pgtbl = stage1_pgtbl_root, i = CONFIG_PAGING_LEVELS; i; i-- ) + { + index = pt_index(i - 1, ident_start); + xen_index = pt_index(i - 1, XEN_VIRT_START); - asm volatile ( ".p2align 2" ); - mmu_is_enabled: - /* - * Stack should be re-inited as: - * 1. Right now an address of the stack is relative to load time - * addresses what will cause an issue in case of load start address - * isn't equal to linker start address. - * 2. Addresses in stack are all load time relative which can be an - * issue in case when load start address isn't equal to linker - * start address. - * - * We can't return to the caller because the stack was reseted - * and it may have stash some variable on the stack. - * Jump to a brand new function as the stack was reseted - */ + if ( index != xen_index ) + { + pgtbl[index].pte = 0; + break; + } - switch_stack_and_jump((unsigned long)cpu0_boot_stack + STACK_SIZE, - cont_after_mmu_is_enabled); + pgtbl = (pte_t *)LOAD_TO_LINK(pte_to_paddr(pgtbl[index])); + } } /* diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index ae194bb099..b6ce2894ab 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -39,6 +39,22 @@ ENTRY(start) jal calc_phys_offset mv s2, a0 + jal setup_initial_pagetables + + /* Calculate proper VA after jump from 1:1 mapping */ + la a0, .L_primary_switched + sub a0, a0, s2 + + jal turn_on_mmu + +.L_primary_switched: + /* + * cpu0_boot_stack address is 1:1 mapping related so it should be + * recalculated after jump from 1:1 mapping world as 1:1 mapping + * will be removed soon in start_xen(). + */ + jal reset_stack + /* restore hart_id ( bootcpu_id ) and dtb address */ mv a0, s0 mv a1, s1 @@ -54,3 +70,17 @@ ENTRY(reset_stack) ret + .section .text.ident, "ax", %progbits + +ENTRY(turn_on_mmu) + sfence.vma + + li t0, RV_STAGE1_MODE + slli t0, t0, SATP_MODE_SHIFT + + la t1, stage1_pgtbl_root + srli t1, t1, PAGE_SHIFT + or t1, t1, t0 + csrw CSR_SATP, t1 + + jr a0 diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c index dde8fb898b..6593f601c1 100644 --- a/xen/arch/riscv/setup.c +++ b/xen/arch/riscv/setup.c @@ -13,20 +13,10 @@ unsigned char __initdata cpu0_boot_stack[STACK_SIZE] void __init noreturn start_xen(unsigned long bootcpu_id, paddr_t dtb_addr) { - early_printk("Hello from C env\n"); - - setup_initial_pagetables(); - - enable_mmu(); - - for ( ;; ) - asm volatile ("wfi"); + remove_identity_mapping(); - unreachable(); -} + early_printk("Hello from C env\n"); -void __init noreturn cont_after_mmu_is_enabled(void) -{ early_printk("All set up\n"); for ( ;; ) diff --git a/xen/arch/riscv/xen.lds.S b/xen/arch/riscv/xen.lds.S index 9064852173..3fa7db3bf9 100644 --- a/xen/arch/riscv/xen.lds.S +++ b/xen/arch/riscv/xen.lds.S @@ -31,6 +31,11 @@ SECTIONS *(.text.*) #endif + . = ALIGN(IDENT_AREA_SIZE); + _ident_start = .; + *(.text.ident) + _ident_end = .; + *(.fixup) *(.gnu.warning) . = ALIGN(POINTER_ALIGN); @@ -173,4 +178,10 @@ ASSERT(IS_ALIGNED(__bss_end, POINTER_ALIGN), "__bss_end is misaligned") ASSERT(!SIZEOF(.got), ".got non-empty") ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") +/* + * Changing the size of Xen binary can require an update of + * PGTBL_INITIAL_COUNT. + */ ASSERT(_end - _start <= MB(2), "Xen too large for early-boot assumptions") + +ASSERT(_ident_end - _ident_start <= IDENT_AREA_SIZE, "identity region is too big"); -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:14:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580029.908285 (Exim 4.92) (envelope-from ) id 1qTOPw-0004Uj-4o; Tue, 08 Aug 2023 15:14:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580029.908285; Tue, 08 Aug 2023 15:14:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOPw-0004Uc-0k; Tue, 08 Aug 2023 15:14:40 +0000 Received: by outflank-mailman (input) for mailman id 580029; Tue, 08 Aug 2023 15:14:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOPu-0004UR-VJ for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:14:39 +0000 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [2a00:1450:4864:20::230]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a5a618d-35fe-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:14:38 +0200 (CEST) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b9d3dacb33so93632001fa.1 for ; Tue, 08 Aug 2023 08:14:38 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id i19-20020a2e8093000000b002ba053e1f9bsm2319794ljg.35.2023.08.08.08.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 08:14:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a5a618d-35fe-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691507677; x=1692112477; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WnbMFsw2xJyZrC0SKfFmGk7wApTlrJZ562TuRi7g2Ug=; b=LbjK4PUzxnKJZdrQZK+/vINCygJMsr+1UNpkwzkSuI83/mCu+BAQcQimIS9FzxCdkO GIZvx4RMXHudGYoOpZonwUwabDvib9KTNEd0D4QPjii318mKQIbdQjEMl/J9yfGGAg/F TUUvG5ir1jcmpj4wvVH3SKcA190xu6COyNbIw3Qm13j4kZ9767a2cMede92qHsnE7b1R tcieZAxKe7pq5RbOBeOV+Wj1d7yYTc7hiNXDVuyZVf7kuFdlYLUeYfvwIdkVLdio9JrE 3p7EHFs5vlRJiWvegz7XxDs/kczHkowOj8TM3qTTey6u425jEQifrxJUp5hoC6Tl/GA4 gnSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691507677; x=1692112477; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WnbMFsw2xJyZrC0SKfFmGk7wApTlrJZ562TuRi7g2Ug=; b=e44FlfSSV6LldQ7DIDqblOt/sBqbxxh+H/Jc0ih8AdBHB6tgZWK3N3k9LLh6vl6VZR Dgf5yaH/9prCbhJitOcNqb5AmXduBc9ci13I9qlrOC8Ve9zIZBT5DsLsWNd7GokvCOue 9IeZVjypOOuV/gq+7++Efm0L3Guh1q2BWigQbjWVoR6M+XTGhN4ulNsCYAfJpnBWqZRR a3o2B5WBzDfc/18fQ+ZKDh4DE9Q47384TZuqfDs9mpl2akWCwSzwAeMkmV5xJfxcYCBU OAsRiAWw6d6097VtuSrOTKMEzwJYrB+sBupZ3WcFL17NcH1gwWuMfTMpaYXpPVxp/pm7 Ulxw== X-Gm-Message-State: AOJu0YzJixQh4mitRcEKs8I1F8dN/iL++VdmDj07NPMAQ7hRYyy8BqBl wodpGSzBy1N8qIpH5AA4KvRUCcRR8Eo= X-Google-Smtp-Source: AGHT+IG6XoenVJGnOoi1kpLKAM55KifzOuJ3fg9FeOma9pKXOGiDSbaMLijCj0QQp6g92dMtGjYLSw== X-Received: by 2002:a2e:968d:0:b0:2b6:c528:4940 with SMTP id q13-20020a2e968d000000b002b6c5284940mr10504116lji.3.1691507677036; Tue, 08 Aug 2023 08:14:37 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 0/2] xen/riscv: introduce identity mapping Date: Tue, 8 Aug 2023 18:14:32 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The patch series introduces things necessary to implement identity mapping: 1. Make identity mapping for the entire Xen. 2. Enable MMU. 3. Jump to the virtual address world 4. Remove identity mapping. Also current patch series introduces the calculation of physical offset before MMU is enabled as access to physical offset will be calculated wrong after MMU will be enabled because access to phys_off variable is PC-relative and in the case when linker address != load address, it will cause MMU fault. The reason for this patch series can be found here: https://lore.kernel.org/xen-devel/4e336121-fc0c-b007-bf7b-430352563d55@citrix.com/ --- Changes in V7: - use srli instruction to be consistent with slli instruction in turn_on_mmu() --- Changes in V6: - Update calc_phys_offset() after rebase. - Refactor turn_on_mmu() and a way how an argument of turn_on_mmu() is calculated. --- Changes in V5: - update the algo of identity mapping removing. - introduce IDENT_AREA_SIZE. - introduce turn_on_mmu() function to enable and switch from 1:1 mapping. - fix typo in PGTBL_INITIAL_COUNT define. - update the comment above PGTBL_INITIAL_COUNT. - update prototype of calc_phys_offset(). now it returns phys_offset. - declare phys_offset as static. - save returned value of calc_phys_offset to register s2. --- Changes in V4: - drop patch [PATCH v3 1/3] xen/riscv: add SPDX tag to config.h as it was merged to staging - remove definition of ARRAY_SIZE and ROUNDUP as was introduced where these macros are located now. - update definition of PGTBL_INITIAL_COUNT - update the commit message for patch 'xen/riscv: introduce identity mapping' - update the comments in head.S - update the algo of identity mapping removing --- Changes in V3: - Update the patch series message. - The following patches were merged to staging so droped from the patch series: * xen/riscv: add .sbss section to .bss * xen/riscv: introduce reset_stack() function * xen/riscv: move extern of cpu0_boot_stack to header * xen/riscv: add SPDX tags - move save/restore of a0/a1 registers from patch 4 to patch 2 ( numbers are from the previous patch series version ) - add SPDX tag in config.h - update definition of PGTBL_INITIAL_COUNT taking into account identity mapping. - refactor remove_identity_mapping() function. - add explanatory comments in xen.lds.S and mm.c. --- Changes in V2: - update the patch series message. - drop patches from the previous version of the patch series: * xen/riscv: add __ASSEMBLY__ guards". ( merged ) * xen/riscv: make sure that identity mapping isn't bigger then page size ( entire Xen is 1:1 mapped so there is no need for the checks from the patch ) - add .sbss.* and put it befor .bss* . - move out reset_stack() to .text section. - add '__ro_after_init' for phys_offset variable. - add '__init' for calc_phys_offset(). - declaring variable phys_off as non static as it will be used in head.S. - update definition of PGTBL_INITIAL_COUNT and the comment above. - code style fixes. - remove id_addrs array becase entire Xen is mapped. - reverse condition for cycle inside remove_identity_mapping(). - fix page table walk in remove_identity_mapping(). - save hart_id and dtb_addr before call MMU related C functions - use phys_offset variable instead of doing calcultations to get phys offset in head.S file. ( it can be easily done as entire Xen is 1:1 mapped now ) - declare enable_muu() as __init. - Update SPDX tags. - Add Review-By/Suggested-By for some patches. - code style fixes. Oleksii Kurochko (2): xen/riscv: introduce function for physical offset calculation xen/riscv: introduce identity mapping xen/arch/riscv/include/asm/acpi.h | 6 ++ xen/arch/riscv/include/asm/config.h | 2 + xen/arch/riscv/include/asm/mm.h | 7 +- xen/arch/riscv/mm.c | 109 +++++++++++++++++----------- xen/arch/riscv/riscv64/head.S | 44 +++++++++++ xen/arch/riscv/setup.c | 14 +--- xen/arch/riscv/xen.lds.S | 11 +++ 7 files changed, 136 insertions(+), 57 deletions(-) create mode 100644 xen/arch/riscv/include/asm/acpi.h -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:14:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:14:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580030.908295 (Exim 4.92) (envelope-from ) id 1qTOPx-0004k6-FF; Tue, 08 Aug 2023 15:14:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580030.908295; Tue, 08 Aug 2023 15:14:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOPx-0004jz-CM; Tue, 08 Aug 2023 15:14:41 +0000 Received: by outflank-mailman (input) for mailman id 580030; Tue, 08 Aug 2023 15:14:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOPv-0004UR-KT for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:14:39 +0000 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [2a00:1450:4864:20::22d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4aae772e-35fe-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:14:38 +0200 (CEST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9e6cc93c6so88864971fa.2 for ; Tue, 08 Aug 2023 08:14:38 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id i19-20020a2e8093000000b002ba053e1f9bsm2319794ljg.35.2023.08.08.08.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 08:14:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4aae772e-35fe-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691507678; x=1692112478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVnapX6pJbuyIiJqPHyIE7upozAeCAUpzwk8pWdYKkk=; b=F45IcP//lDRI8/cXxnZYlW9HKIKiVcS2qrf7XQdv3kUb2RmiOD1XLwunLcM85kSwW5 ECWtqCGXl8lIjZmkNXmH9oEHNoQyjG4rcNGXW0QxQgjEeZQo7EmQ19b2zzSTIb60ZBnU rQMG/Fhc4InsAfAOTk0aHj8NBvSCOw1O6gjk+zyLU+X11suCjrAg4IzVYcZMr9Axq9WG 5oUYOOZoiDFSTmZddXXMtqoQF9KjGl/h0G/AMjmPFd+IlmMyXB39EOgGQ4vsTzFtVRZ+ Qz/BiEPrIdg8cv15AyvlunAxWxHX5/uUFU9xm39qNjMxVM1sHhHcukLBtpe7qrMSAlBi AFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691507678; x=1692112478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XVnapX6pJbuyIiJqPHyIE7upozAeCAUpzwk8pWdYKkk=; b=dUPcnWPXYClKV3RsBheJ/znN/r9krvUIRwEDdsWrI728o9FjjVkU0feYctjqXVU1v9 XmWkYER54km05OdPCN2XAsxqYLCcxJlkPWn0WYnyaY5UXEoAR1pptKIwG213u+mqH18F rn/SkyybyRZqZiCHyEVJSanrdHdO8bUXyP1GlIDHnZkhQeoKxOgB/dOr596gQkX7Rren rO7Jrl0CWPnxsWmXtQ8nXyJzXWyMvte+rO/zyCFszZnjtOYTiLiHnf6MqRlBsHNwzAbB 9IOXeHJNED3HCrDUg3/qkm5rl8vr+fTnFY9v2XCw47+avmU1EYujKuPzpRkhOKX22ywD ivBQ== X-Gm-Message-State: AOJu0YwUhfNzwZRkMcQcdkkIsVoZiM6fVCWAbZ/Rmpx+EJtOaV8IVVGj OUjPrNPRUN8CggVUkhfU2CEwlya7e2I= X-Google-Smtp-Source: AGHT+IFzCBnt4pdAkSiRqtYmX3q6Mntbuz8yqFz0Mml4QXcR3rKhYsF3I0dAe5a/yBsW7Ovkm7ENOw== X-Received: by 2002:a2e:6a11:0:b0:2b6:a6e7:5afa with SMTP id f17-20020a2e6a11000000b002b6a6e75afamr8817605ljc.12.1691507677614; Tue, 08 Aug 2023 08:14:37 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , Oleksii Kurochko , Bob Eshleman , Alistair Francis , Connor Davis Subject: [PATCH v7 1/2] xen/riscv: introduce function for physical offset calculation Date: Tue, 8 Aug 2023 18:14:33 +0300 Message-ID: <53d4251e79c5b4effb3a077d1b102c57ed1a10b3.1691507564.git.oleksii.kurochko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function was introduced to calculate and save physical offset before MMU is enabled because access to start() is PC-relative and in case of linker_addr != load_addr it will result in incorrect value in phys_offset. Signed-off-by: Oleksii Kurochko --- Changes in V7: - nothing changed. only rebase --- Changes in V6: - After 9380f06fe8("xen: Drop the (almost) unused extern start[]") an update of calc_phys_offset() was needed: - change start to _start. - add local volatile variable load_start to get properly Xens' load address. Otherwise compile thinks that (start - XEN_VIRT_START) is equal to 0. --- Changes in V5: - update prototype of calc_phys_offset(). now it returns phys_offset. - declare phys_offset as static. - save returned value of calc_phys_offset to register s2. --- Changes in V4: - update the comment messages in head.S related to save/restore of a0/a1 regs. --- Changes in V3: - save/restore of a0/a1 registers before C first function call. --- Changes in V2: - add __ro_after_init for phys_offset variable. - remove double blank lines. - add __init for calc_phys_offset(). - update the commit message. - declaring variable phys_off as non static as it will be used in head.S. --- xen/arch/riscv/include/asm/mm.h | 2 ++ xen/arch/riscv/mm.c | 21 ++++++++++++++++++--- xen/arch/riscv/riscv64/head.S | 14 ++++++++++++++ 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h index 5e3ac5cde3..7b94cbadd7 100644 --- a/xen/arch/riscv/include/asm/mm.h +++ b/xen/arch/riscv/include/asm/mm.h @@ -15,4 +15,6 @@ void setup_initial_pagetables(void); void enable_mmu(void); void cont_after_mmu_is_enabled(void); +unsigned long calc_phys_offset(void); + #endif /* _ASM_RISCV_MM_H */ diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c index 99ed5e9623..a73f135a3c 100644 --- a/xen/arch/riscv/mm.c +++ b/xen/arch/riscv/mm.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include #include #include #include @@ -19,9 +20,10 @@ struct mmu_desc { pte_t *pgtbl_base; }; -#define PHYS_OFFSET ((unsigned long)_start - XEN_VIRT_START) -#define LOAD_TO_LINK(addr) ((addr) - PHYS_OFFSET) -#define LINK_TO_LOAD(addr) ((addr) + PHYS_OFFSET) +static unsigned long __ro_after_init phys_offset; + +#define LOAD_TO_LINK(addr) ((unsigned long)(addr) - phys_offset) +#define LINK_TO_LOAD(addr) ((unsigned long)(addr) + phys_offset) /* * It is expected that Xen won't be more then 2 MB. @@ -273,3 +275,16 @@ void __init noreturn noinline enable_mmu() switch_stack_and_jump((unsigned long)cpu0_boot_stack + STACK_SIZE, cont_after_mmu_is_enabled); } + +/* + * calc_phys_offset() should be used before MMU is enabled because access to + * start() is PC-relative and in case when load_addr != linker_addr phys_offset + * will have an incorrect value + */ +unsigned long __init calc_phys_offset(void) +{ + volatile unsigned long load_start = (unsigned long)_start; + + phys_offset = load_start - XEN_VIRT_START; + return phys_offset; +} diff --git a/xen/arch/riscv/riscv64/head.S b/xen/arch/riscv/riscv64/head.S index 2c0304646a..ae194bb099 100644 --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -29,6 +29,20 @@ ENTRY(start) jal reset_stack + /* + * save hart_id ( bootcpu_id ) and dtb_base as a0 and a1 register can + * be used by C code + */ + mv s0, a0 + mv s1, a1 + + jal calc_phys_offset + mv s2, a0 + + /* restore hart_id ( bootcpu_id ) and dtb address */ + mv a0, s0 + mv a1, s1 + tail start_xen .section .text, "ax", %progbits -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:16:12 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:16:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580045.908314 (Exim 4.92) (envelope-from ) id 1qTORO-0006C1-0X; Tue, 08 Aug 2023 15:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580045.908314; Tue, 08 Aug 2023 15:16:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTORN-0006Bu-UF; Tue, 08 Aug 2023 15:16:09 +0000 Received: by outflank-mailman (input) for mailman id 580045; Tue, 08 Aug 2023 15:16:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTORN-0006Bk-Da for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:16:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20621.outbound.protection.outlook.com [2a01:111:f400:7e1a::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7df3b75a-35fe-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:16:05 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7763.eurprd04.prod.outlook.com (2603:10a6:20b:246::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 15:16:03 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 15:16:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7df3b75a-35fe-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SQBjC7vEu6+GuCAPhOicdNPM3044slf9Xl/DN5Rw1KSRodK/NKZygtsmOC2K4Zs0maJK4iI/Uf5oSTGlOqBwci0Z3tL13Q2BvtxkbHITKZrUuPL4Ya1351LRIQ88vw0XS4R4OnX7VPycEgkJtQdgSfvnYr4W4l9FPdDvt6f76qxFwQRDKsvBgA5vo9KdCA3j0bhZb1Az0bIL9600iOlMTHbG2t/kyJ+swILEv2EBwmwKTPoE9fUYb82WHgLXIaWgo417ZLbdQD0pmxrBZykxqnT4KaTQdobmeh2RK6UlO0LdJ3BpxlP+ULOW+t0lSIENE/0BPhhFtqrQaKZcsLfJww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rPLem2qXu3qEoFuK1xBkTuhqviQq9n7waaPtSwXl7MA=; b=EwdcnfCH5by8vN4kWcBsIRbk8mSUQhQ++Cv5bYRnXxg/eNpHvIjBEhiWyyRSvACA3wArNp+FWIu9RnAkDZQgmJ7RLgbCiccGSQ2XpA4o6OAX4ruRZlK+ULorERyCCF2zBbGF28oEhEZ6tKcgz1XwvVsUNQTRso+OwfFn8dIIAjMTiUGeBfOm43bNU+5rXS0BLK2+LCMWJpZQr5w2aasB4agZLvoJwMefXKKDsWUYmuFHY8+2pm+Vqv9fwmvvBxpeVRseMd2x0K6P7yTeueZtT9urukoFx5/WQXNTNAfgN3WPrW7FvOTJulgS/MIMFlnqDkTg4poQbxJLJ5paL9tQOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPLem2qXu3qEoFuK1xBkTuhqviQq9n7waaPtSwXl7MA=; b=bn1uCwJjaflYvKRHOgESJyXUrr2otd5CFTEbYuVHgD683eYPvp5CrSrr2otfsq+MUDbwK6dk8Etz2uvCkS4F4u0QpH9qgFJ35jw12rDiS4NKWqttkaeH3z2yieKEBy4wHuOxv2L7DjEbWUBhNzYAutlQOeM/4/2/sYdj5F+1idxmWrSawgeogySaMoWk6JrZiWYAg2VoZV7i3iUW7R271DNpAgvs5HcHn/ApNxV2LVycyrRNzFv0bcFLoewZHtSj2tRcQdUeOQmw24KXBwN2qy8kP78JmfeRgfQkoOJspCKoKYwfY45uw/3b3RwzEVnj0SK5CH7moqlz0VrmYt/YmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 8 Aug 2023 17:15:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: "Daniel P. Smith" Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801202006.20322-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7763:EE_ X-MS-Office365-Filtering-Correlation-Id: 1170767f-c3a3-4be6-b066-08db982260e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Aioq506w83RbALyXVG8D0epnx1w/NDvmq/Ih/E118LROABngKUZnlWYWp9hl8/b78szF5LgHi0Ly9CYwEIGAWSAQvnDELOrnLo9vjyi1IkEkuMDmiPLGPw4kFKEUV08CdiKT3QhveL8IUC+PVS+dXlwx4aUNwSiJ5HD1d7f71Jes153zAyq+qCbEb4jVcR6jScPeeiSWDSnGlpRBsiZstJ2T/SZzh+O35VJCih8StqsGds1iVKYIq5Gof3cPzN88cmu/9vH0UHskPHJYE+JlwwRZX1K5ohdTkBHugMwSeLnOeoXx8WHZnkZNu2pjd3k0K7s+cbIly5LcvJz5reAHgZsOYpSQCEdecV7WFR8moRJDAlBJ6QdbkWWhrdwANRkB5Yieid43ry9lTflPLM+iOt02VIl47/lKenrO2EJz5JlGsEXXMEkpndmZBk4AnGO8P+TPPqNIXsP6vVZ1dWGveUv/VSOFp1x617kW0f6pj1lk93I5Mi21Enowm6b9HhLdE/REyQ6fYOmk9UWJQDboWxRM/pX4LMExUbo9lPlFc7Y0NczJfo16eQgjgjum19LNl6VGcimCRjNEw001Jw1R0Aw4KuB2BqrDpo+jYeKv39QUu4Kr1PUAjFmSVFUZRt6ijTnEzLLZLt/JKF7N42aTgg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(346002)(136003)(396003)(39860400002)(186006)(1800799003)(451199021)(41300700001)(26005)(2906002)(5660300002)(31686004)(7416002)(4744005)(8936002)(8676002)(2616005)(478600001)(6916009)(86362001)(316002)(6506007)(31696002)(53546011)(54906003)(38100700002)(6666004)(66556008)(6486002)(66476007)(66946007)(6512007)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2ErODZPS3RKV3M1NXFuZy9iTnltTHQxUVU5UFBhcDU3S0Q3cmN2VEQ4OVZQ?= =?utf-8?B?RG9xTTA3Y25sdS9LcTdZZG5wK3dJSWErTm05MTE0b3lTNlF0YWQ3dXF4MFl1?= =?utf-8?B?U0xrQ1orRytnUElxeWIrSXBFUk5sME4wa0YyUnVOaGlkSWVFbFdkT0JSbk9C?= =?utf-8?B?U0FWb0oxSVdFOUhzY1dyaFMvM1U5clFZTFZDUnNCbVFWVVpKTDhpMWlkdVFE?= =?utf-8?B?Z0tKVXpLU1BWVGtyK21NNmxlaitGWVpZWU5qYnB2N1lSdlIrT3FhODVCOE04?= =?utf-8?B?VFlTc1BaSnVhV05henRZWWk3czhWOHU5c2Y0R09ZUU9STnRmOEZNN3UwdUZU?= =?utf-8?B?SGp1Wk5LVG9rUWY4ZjlUOXNXZHZwNHJ1cElvTE1yZ1EzTEtRTmw0YmtwaHla?= =?utf-8?B?Um9Ec0w4VitOclFiT3U4UUMwZDRTMnZxM21ocStycmx1eWxuWTYxUk1Fdits?= =?utf-8?B?V1FRSy9OdzFTQ2lFWXZHUDBQcUNYTk5tVFVVWkVNRmx6V3ZRWnpZWDJsVGVN?= =?utf-8?B?YXZjL2Zpb21rRnA1NDRRdU1ENDArdUw3MmNpUnppV043Z2k0d2Z5SzVDWjZB?= =?utf-8?B?MjJrV3RvM05Kbk11eXFYcEdaMGZ3SXVzUDd4VERVTjVValJnRmdWZUxqVDl4?= =?utf-8?B?V05oZEk4bEh1RWYybWU0WStOMDVmZkhzcFVaZENQTjZJZHM2Q0NsUTJoOEc0?= =?utf-8?B?VCswR1R4d1IzRnhmeU5uWkpPUmxkZFRBaHgwQnQrVDB3dWVsNWMxaTBITkFW?= =?utf-8?B?SldSakxZOVhMbGxMVWl2STB5ajFkSWFjVjREamE4eWpHQzZMRjAvNGFTd3Nz?= =?utf-8?B?anNFRmI0SnN4NTNXUDNiNGE0VHNRNmNnYTF3QzZ6ZFB1bVpPekRIZ082L2hZ?= =?utf-8?B?dWdTT2k2dFdkRVMwOTI5YzNpcjhOVnBxM0JzYXVrckUveXJ1S2JSdFUwVG1w?= =?utf-8?B?UGVjVFZwUk9ieml6M3N0bFB6THI3MElUUkVPTEZQVFFLc1Rwc1lHOXluN09k?= =?utf-8?B?YkhjTmlBbCtrMmZ1V1VKSWphQmFHL1FuUHNXOXZmREx2QmQvVlZvUWhSU1hz?= =?utf-8?B?ZUZPTkx4UTRYRVFHcmFURnVOSUlkN3hPUkhaOWNVcWx1bnlheGt0ZzdKWXJL?= =?utf-8?B?YXorSkdGdjZzNlVhRmEzZXRBeUV4a29qWWlxL25LbG14U2pUdGVJcnFuTExF?= =?utf-8?B?WTgrblRTZzNEaFhHcVJPUERnVjk2ZVI2SjhVWW1STlpBZEVWQnArM1NkUDFp?= =?utf-8?B?akI3MjVvU291VW5kb3AvWkFRSVdIMVBiNVNURldqZnFHTFZQRGYrZ1F3YitK?= =?utf-8?B?elBCUE9VeTllRlBwZ2dLT0FpYU1JYklIRGFVN1NjWHc1ZHJac3dDb0d3c0Rk?= =?utf-8?B?U0hNQ0VqTmRRWUpTc2dvQjVMcHI3YWlwN1E4bWtxY1oycGFSOGhGYzZjQVJ1?= =?utf-8?B?SEx0VWNjUXNxYXlzczF6RmFkd2xNSHluNnl3Qkd2MHVibTU2NmY2SitWM1k0?= =?utf-8?B?UHpZRzQ3RXFsRWZESFVSQ1Vtd1VrTUx6eDU0Vk8xUVVRRVhwZ1JObEtRb1Zk?= =?utf-8?B?WWppbWIvQTFTeEU4V1NrUXA1Sk5JSDdPSmtxSlRYa3V2TEloOEJGK3ExRUVB?= =?utf-8?B?NjBnd21mU0J2eWpRSHZLVFhZSjEvVFpJQU1JdWRWaVNueW4rV25WaEZUd2dq?= =?utf-8?B?eHFhQWxuTnV2RGlocG5ORlplMmI0S3VhanhrUksvOW81akM4TXBqKzZjWXlZ?= =?utf-8?B?K1JpOXk5TWR3djQ2dGRWYjFUbEUrV1V5N0NtTzBRRi9rVFRJZjk0UVlSUkN0?= =?utf-8?B?dlF4cXo0WWhnVFdTcENjVHhiaE80Z2RTL2taSS83WTlKQzZlbndmYWRYa3Yz?= =?utf-8?B?ZXc3S3U0UUdBakwvaCt3OHBiWXJvSW1mcE5Lb00xUnhlNjFTdzFsYWIwc2NI?= =?utf-8?B?bkVBYlF4Z1NVWm5aOUdJRUZKNjVDNmd1Z0J3UjROdFVEaGdCRDB4RGJ1eGJM?= =?utf-8?B?bGp6bTFPek1jeTFya1lPSi9uWFJzN0VaSHlTV0g0VzNFYkZMYlY5NzZFNFlT?= =?utf-8?B?MUZaNWNtUDhWSTUrZUVoMmVxRzdkZXdEUll3UjVzR2loNTBkTFQ2dzFZTklZ?= =?utf-8?Q?rlDhFV9arZHT+NIKRx87YO3dL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1170767f-c3a3-4be6-b066-08db982260e2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:16:02.6395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O1VK8i//DSwFiPoBIwZPR4XJsSQwrwHv6aVPWWWOGc4QybHne7JOKs6pbxLYT93NDdk98QHiz5NhtBbwZkujJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7763 On 01.08.2023 22:20, Daniel P. Smith wrote: > @@ -1076,7 +1076,8 @@ static always_inline bool is_hardware_domain(const struct domain *d) > if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) > return false; > > - return evaluate_nospec(d == hardware_domain); > + return evaluate_nospec(((d->role & ROLE_HARDWARE_DOMAIN) || > + is_initial_domain(d)) && (d == hardware_domain)); > } > > /* This check is for functionality specific to a control domain */ > @@ -1085,7 +1086,8 @@ static always_inline bool is_control_domain(const struct domain *d) > if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) > return false; > > - return evaluate_nospec(d->is_privileged); > + return evaluate_nospec((d->role & ROLE_CONTROL_DOMAIN) || > + is_initial_domain(d)); > } Why these complicated conditions, and not just the check of the single relevant role bit? (Also note that indentation used here doesn't really match our expectations, but there are other style issues in the patch as well, which I assume is okay for an RFC.) Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:24:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:24:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580055.908325 (Exim 4.92) (envelope-from ) id 1qTOZl-0007nN-UM; Tue, 08 Aug 2023 15:24:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580055.908325; Tue, 08 Aug 2023 15:24:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOZl-0007nG-Rh; Tue, 08 Aug 2023 15:24:49 +0000 Received: by outflank-mailman (input) for mailman id 580055; Tue, 08 Aug 2023 15:24:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOZk-0007nA-MT for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:24:48 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20611.outbound.protection.outlook.com [2a01:111:f400:7eaf::611]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b575a587-35ff-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:24:47 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9677.eurprd04.prod.outlook.com (2603:10a6:102:24f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 15:24:45 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 15:24:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b575a587-35ff-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZiIfzy1WNlAn3kC2JdN7yNJIZ2QbtdYw3IRa4k/BFJrMMzWoJGqi+/RtAp/8kiWXx4M3uUVtLAy7C+LCWfK2jsdQguR3/xl1avq70KU0QfPmLEQVd1OsxqLHPilo0uOWMcMT5uI+ESo0Zm7YJNMx1ontHi/Q7IDEK4UQA/p/4x1NfthtWm0Ncbtk/U8dRZlwmWC5pOqJwxH9DEhjR6JRJXeMvyo87Ij4G2wdTGBYZKKfmAJDNLOjok0wyDMhV8V1/INNRsh8EqY7rSgShcHEGmFJSrxEftIWKIcY6dBo+bhFcXyQfBs7HiI/4G4vG1J8/r4dIbH3NPY6Mt7DuolfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Iac+cMqKUP/CLiNKEpV07tq09X8Swz8dmGF7ta92L0U=; b=aFqQzBHoCgmMyvV+04Ta2YOtWiLwMySaBfbcKU6iXqYrm4rFDAggn+6BOLL+k7ifyF+2slV6VxNc6Ik8lN73clToOxwsqWvf1j8mch8YVCzkizAbtYqiOM+4LqSz1ibB1N7u232ubwg3K2TA12rc5OLF8hMpH14mJMOnDboWfjiilyefxoIL8pe0NiixaVdGiPpwgI9i47m9geqVw8xDT7CUBP7GaXmeirZmZIMoGmI178TRaMerEBaGmE+nhcvTPQtYCqQ90BSkyBClSKEw8v7c3+PXL00cozhsOioGcHhmijzNklSjiKRoQssQg7l3126xfk59XFHPeK47EyyHiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Iac+cMqKUP/CLiNKEpV07tq09X8Swz8dmGF7ta92L0U=; b=ibJmsgdUUqSvATGYc1eoMEhArsqRrTmnEyJiWyN+q5Vw6sOiLz2zxmdLMiIzEPCxsQGGEt7bz/movFBL+QYnmEODqMxnfq43XGI7tu3ZZFMlEryLefiwOxP27dsDEeJMAAr6K2qbg2+CmI5AU+VGeVnQ/cr+E0p9gTCJxJBPjJ5AKkPFwO4uppJnujwtdRnvujWR+S3T7SlaZ+KPQk+7APduSnpNuHJZB1d37Pwsdr4lijgMJgt1au0KxuMO86DUXMcF55q7zVR1J6ZHLjloXXwodqHHXOMUE98Mm4JGG3n8Ml6TwPjBYaVih6zhZffX4bFmZhpAuoxNC+nBwNFJnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <72f6cdbb-44a0-d821-1b7a-607e031cde99@suse.com> Date: Tue, 8 Aug 2023 17:24:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-US To: "Daniel P. Smith" Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Wei Liu , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801202006.20322-5-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9677:EE_ X-MS-Office365-Filtering-Correlation-Id: 8698ef4b-dca1-40fe-179c-08db982394a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vg8iDqUa3s7aCqOzjxtjGMRLKk8/CfVxF/hmjS/B3QL83X/r5+ibp9shni0FSVSv5CZimVsKe32P75rxW89+Gib6df96KckGtnYtO43OJ99tzlVfrXLzXy/AJyOZAfnMjH07xGa99wtgAL2sccspnfo01d+f/BMgGn12qATGYjcSBjKiF7MeVF/0wzjhUPs4jvphLSE/Ic4ui5calkN8XmEhOR6LClTAtdahx9fxpwBbXtRhRlJGyiqyXCjBexu88TPN3+Rqpa6pO/5HayMikhymENaQesBLKSHXs+MLekKaLHtIN6JXIJo50oypihwpYAp1hf7Nf0Npfq/08gzWybU8DaLlvg519wrq8QPGLiKHOJC2pYOCsAAhvIjHlEEjec7DaABcl6TexB8EcnOUA/pLfmKAHnwrre68+nm5w1ZXhpPf5PhGbv3QamEH0SBjSgidrbk6Q+3H+c+DKJU6TXHBscI9S+3t5HaO7H3gi9T2uWbSJ1q7b8dcChJcvEy3R7IoLhwgoDs9uDfzxC4aau4oPktoxs2h1/SrgcWO3Tj+RIYwvALI9RgrcSYtVIAojWT56XX6tQBvaNWGuz2micSPogJ0ST0iNJZkSbv8NCcZyUpJPJYEl5hE6Vi18EA9+m09nbf9Ak9DdrgxbCTozg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199021)(1800799003)(186006)(478600001)(54906003)(83380400001)(31696002)(86362001)(53546011)(26005)(2616005)(6506007)(38100700002)(6486002)(6512007)(36756003)(4326008)(6916009)(66476007)(66946007)(5660300002)(8676002)(8936002)(316002)(41300700001)(31686004)(66556008)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWY1ejdnb2NDQzhlWGw5UmN0eG1telRiWnc1bzRxUWtIQ0RrbmhEMjlvdHdW?= =?utf-8?B?UEZJSGpLM29FU2l6OVhmc3ZOTkFYTFZ0b1htVXM5bjcrSVV0Y2k0VG9QSEJn?= =?utf-8?B?L2cwYytuNUhWeWdDMGVVQ0xPVEN5ZnFGM1J5QmROd0JKMzc3Rno4czU3b2Z6?= =?utf-8?B?dk94SG53dHhMTGNxM2xodndKci95SzlJZm52MnJCM2tqdlFNUjl2WUZXNExX?= =?utf-8?B?S2VLamZMdHdROFlXeitMS3EwOHhIR2FGOFdCNXZ0SmdwQXBSdTBwbHZSVWNz?= =?utf-8?B?NjNVb0FkYk1BbDB2MDNYc2pIVHFyVUNZNDRmQzhkbkZCYTdtUlBoK003ckVT?= =?utf-8?B?M3BKNTIwbzE4NkxrOE5DSlN5dCs3OTV4Q0FQVXREL240OElIQVlLOEJScWli?= =?utf-8?B?cXdwN0NJQlgwZ1hpVUNjOS9qUUw4MWNUVllUVXpzTm5GLzJiTUdnSUxya3h4?= =?utf-8?B?TFRYRmFhL1hOUk5Sb1J1OW8rbWI0bzJwQ2NHWXM4WGpYR2dYaVQrMjJKWEVl?= =?utf-8?B?cHlJYjV4M3pMa3R0TkN6SHBkRjgyUXdVLzZaOExoNjl3Z0tIdEx0WjhKNUFC?= =?utf-8?B?aDkrQ0p6d3J3VmxMTGpXa01MOGJEdVN4OW53eEJDSUFJdEtMakdxWGhSdkJ1?= =?utf-8?B?N3cwekV6dTZ4VkxYWUY2ZUhibkVLWlRVWTVRYzViMnBqMFJKSUNTR3dtSGEx?= =?utf-8?B?OE1sSUdjaDhYelFwVHZBRlNlaU1SUjV0b1p4Vjh4eDJiWlNWK09FVTZWWjQw?= =?utf-8?B?cjQzcVhPaGRHMW9aajhYQngwVjg3RG1OdVoxRysyc3UxK1FhYkJ2Z0RCdWpn?= =?utf-8?B?NW1lRTVvY0dTRTdhMlczS3ZFQnN5eVMyOStDY2ljV0x4K2o5YVJUZEZRb3dP?= =?utf-8?B?SjhGZHdWZHVZcDJKVmNVclFEWWN1Z0NDUDZmZTdwcWhkbi8yN0c4ZnFlOUZh?= =?utf-8?B?SHNGaEpFaitkVXV2ZXNVMjdURCt4MWNyY09iRCtTaWFnclgvWHVSS1hqSERs?= =?utf-8?B?YzY0Yk9mVlQwQmE1UzNIM3BtbmpLQ2ZlYWJpVzJoUXBXT2hxZ2poTkJkUXg3?= =?utf-8?B?czJCbWNlMnliQlAyRm1zSHJOeTlZeDFWU3EzKzlyQVR0dUNpL205eExtZC9P?= =?utf-8?B?RUNkR0xjd0loR2h3dlVTcWZFMmtLU1lpRVNzWEtZeU9xNmRGOGNkdjRzdEto?= =?utf-8?B?L3JETG1kZUhpREgxeTBCdTRGdGY2SmVHS21SZWozR29QNkZWVXVacTY4M3Zr?= =?utf-8?B?cUNQOE1EMktqMFVzVXBiVk1WTXpZaGtEZG1XN29DOVNFeEFMdWhxbmV3NDZo?= =?utf-8?B?Z2tBM3FaRFg3UytTaU5JN29WTlJYSTlvaXM5U1N1RC9zMFdCbmJqMTNOM3Qr?= =?utf-8?B?ZGN2Q2E3b0UxQk1ZR1FBWkx5ZkgrMCthUjV2QlMwR3BybndLUTd3dEN4VHp5?= =?utf-8?B?UldsRXMxWDdlaWpHVllJY3B0Q1JEN3NId2JNQndYT3BDSENlaGZHRWF4ZWxm?= =?utf-8?B?YTJySmNCOS9pbWpHWFUwRjdVSjk4SC9CRFdHOCtuZGY3Skh0SXZVbkJzUUkx?= =?utf-8?B?aHU3NTI4MGd4ZGUrVlNLSkdvQ1MzaXVDdnA1c0x5K0R4cm9YVDJGYlR2d0xm?= =?utf-8?B?L0dJKzc3Y0prQm5jU1NSUHMyZmFYbWl6WG9TMmJydUR2U0RUNXdkS1AvTm9Q?= =?utf-8?B?eU9yeXpxZVFrekJmMWtkNDgzZEJ0eG0zZ3pUdjZiS1EvRUFtYVhBckVSTGdI?= =?utf-8?B?UXc4MFNYUWFkT3gwbDAvRUw3MG9KZ2pqNmFBYW1RMS9ZSW9vUmhkWkpEVkNi?= =?utf-8?B?Z0srVjRCVjVwd1lkL0VrR2JoWFZLWUw4dURrdVBOR1hYRS9aZjBWeUtpNWd4?= =?utf-8?B?dnhHcWc1TFRhUmcyT2xQTDdIWU9KNHdkK0ExVzRsMmtIenJ3OFF2Z1BSdThh?= =?utf-8?B?UUNDYkx6WElUTGppOEtuNHRpazBpajhIQ3N4aDZCL29taHNKRDZkNmhMSlpT?= =?utf-8?B?L3FWV3RhQW4zaGw3NDlZZEdnMHN2akRXS05scDRmWUcxdlJJRDgxaWZPUW5h?= =?utf-8?B?R1dIRzZ0RGxETjczbkpSTGFDcEtZK1BrMjdqR2V6TjNMOWwyNCtOdGJqd2Ro?= =?utf-8?Q?QsmgHbapy0I6Nmcz4RJlqUO3s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8698ef4b-dca1-40fe-179c-08db982394a4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:24:38.9468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eJ12R0ZmOgZVboXjQMPmgxgqj7JirTa3hdthTWkNBRF+Zi7OvAcqsxHADfHDQ1ggP9QorP6mh76npD1C92Cy2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9677 On 01.08.2023 22:20, Daniel P. Smith wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -472,8 +472,8 @@ struct domain > #define ROLE_HARDWARE_DOMAIN (1U<<2) > #define ROLE_XENSTORE_DOMAIN (1U<<3) > uint8_t role; > - /* Can this guest access the Xen console? */ > - bool is_console; > +#define CAP_CONSOLE_IO (1U<<0) > + uint8_t capabilities; > /* Is this guest being debugged by dom0? */ > bool debugger_attached; > /* > @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const struct vcpu *v) > return is_hvm_domain(v->domain); > } > > +static always_inline bool domain_has_cap( > + const struct domain *d, uint8_t cap) > +{ > + return d->capabilities & cap; > +} What you implement here is effectively domain_has_any_cap(), which I don't think is of much use. At the very least you want to assert that cap is a power of two. But perhaps you rather want the caller to pass in a bit number, not a mask, such that it's obvious that only one thing can be checked at a time. > +static always_inline bool domain_set_cap( > + struct domain *d, uint8_t cap) > +{ > + switch ( cap ) > + { > + case CAP_CONSOLE_IO: > + d->capabilities |= cap; > + break; > + default: > + return false; > + } > + > + return domain_has_cap(d, cap); > +} The "set" operation doesn't need to be an inline function, does it? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:25:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:25:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580057.908334 (Exim 4.92) (envelope-from ) id 1qTOa9-0008Fr-5i; Tue, 08 Aug 2023 15:25:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580057.908334; Tue, 08 Aug 2023 15:25:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOa9-0008Fk-3E; Tue, 08 Aug 2023 15:25:13 +0000 Received: by outflank-mailman (input) for mailman id 580057; Tue, 08 Aug 2023 15:25:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOa7-0008ED-9h for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:25:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOa6-0007wL-DC; Tue, 08 Aug 2023 15:25:10 +0000 Received: from [15.248.2.255] (helo=[10.24.67.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTOa6-0000Vm-6e; Tue, 08 Aug 2023 15:25:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mhSkcYjKzdM1A8cSCbo8QWS/K4QuN9VbXSR/mvklOw0=; b=FdHsyD3E6xSLTW03K+nKX2/lT/ lGroxu7TRFv0oGe1YVXZyZE5C/mPnNs6+GWVkp9Po9wD8QIJAk4QskEWrwtFc/k8wQTJCQ6dN2RFb 73/leSvX2hRG+GsDJYk25VaSmXj4QhzKLUFvLBXiyva4tV/Sq4RLHVzuoRSRdZIqEw2o=; Message-ID: Date: Tue, 8 Aug 2023 16:25:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-GB To: Nicola Vetrini , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> From: Julien Grall In-Reply-To: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 02/08/2023 15:38, Nicola Vetrini wrote: > The break statement after the return statement is definitely unreachable. > As such, an call to the ASSERT_UNREACHABLE() macro is added to signal > the intentionality of such construct. How about using unreachable() rather than ASSERT_UNREACHABLE()? The main difference is the later will hint the compiler that the code cannot be reached and will not crash Xen in debug build (this could be changed). > > Signed-off-by: Nicola Vetrini > --- > The break in the clause is mandated by Required Rule 16.3, which is > not yet an accepted rule for Xen, but may be in the future. > --- > xen/common/sched/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index 022f548652..fcee902b4e 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) > /* fallthrough */ > case TASKLET_enqueued|TASKLET_scheduled: > return true; > + ASSERT_UNREACHABLE(); > break; > case TASKLET_scheduled: > clear_bit(_TASKLET_scheduled, tasklet_work); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:30:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:30:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580067.908345 (Exim 4.92) (envelope-from ) id 1qTOfO-0001Q2-Oa; Tue, 08 Aug 2023 15:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580067.908345; Tue, 08 Aug 2023 15:30:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOfO-0001Pv-Lu; Tue, 08 Aug 2023 15:30:38 +0000 Received: by outflank-mailman (input) for mailman id 580067; Tue, 08 Aug 2023 15:30:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOfM-0001Pp-VY for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:30:36 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062b.outbound.protection.outlook.com [2a01:111:f400:7d00::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 850c52f2-3600-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:30:35 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB9741.eurprd04.prod.outlook.com (2603:10a6:102:37e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 15:30:33 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 15:30:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 850c52f2-3600-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcPcTPG+xXurrrJTlJYv850/j9QoH3YflLGl8DB2pcbQ8gMQ615IxvI8+C3PbTAdyeFf5iTXNFP3c2BUVUHMdPvih+AATNPufBSc6iuYyJeJ9ECE5n44E38Rb/v/sOw+NMMYeFFIfrn/mMhyizHFC2DRHAPUGZeRBa8lIVYYS451sNkWP7FU6/f4kZ7x/d5SGuulMQVRWtThJ3i05vAh0Q3mtcsaB6BKaCowh+Ga6cLCQYyyLZHy8jF06lF+6bW0nbVgWLyolwk4mQK9NGcS4ikgWg3+Ac5R6Vl5rbpJSIGYNq1rvmemQymmmj6yEvT7mg9zKUOl4bGYwDEn/bmUNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kt2S1S0jn+nKaJ0uq97aWIlcDX7aRs+BnFNHWu+f7zU=; b=Tf9iYGH/3v2W6gfKboLZVTun9IaA9AmXUwjbHJJHI073E8rnuMf8SZlx2V+juaWo0IL6rNqYFwAfJBWvjH/XACBNb/UFBwx8w/n61jll9n8/qwX4BZgTAwXF+xOwvPQYwSRb1gCu3bb94nJyIOhoajy28CQgcs5VnSy46ikufLehrI4+PCRlECdYa/21oROsBmmahZgqZ7pHtJKcVoP+qYo/0wkmtTjTWG1+O9VlAPJQzz6WGh06J3f6hyy4CKPk3944stDRCra8U1scpkeqAmJpgeL2t7a1C5jKtoqwE77KUUs+yMhc22MuxIvQnwV8/nlo9yvU5RVs4ukwB62nOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kt2S1S0jn+nKaJ0uq97aWIlcDX7aRs+BnFNHWu+f7zU=; b=gE32Oiiq+eZqSLogueGcFaF0jekvc5YjrIgeR3fXeYNvD7vo0WPegRrApCZQ8WwjyvP6dy+UZ2LrqOL2c1AEn2s7n4kqyan4Z7HqoiZyX3yFnQOrrN0sew3zEdvWHDPqjT7IOgE4xqV/3K4w+nYf5d+SuI8XKrdi9xmH186e3hEderutAd14ckYGuXvAv8drHC2+iczoyzFYdEL1wPh01haOUweImqMY9hyNModABvdWcq6UcOtO7O9pnbJ5V/asidpdpItbhn0qe4sroTmVoLeBeHzhmPuALAaltb72AvRHgorXOqTFaSy3a0aDenPNOa7wgxrQVOsAWtnwSoxEbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <93750d64-07b3-2a92-4851-bcd5bda9a0a5@suse.com> Date: Tue, 8 Aug 2023 17:30:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC 5/6] capabilities: add dom0 cpu faulting disable Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-6-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801202006.20322-6-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB9741:EE_ X-MS-Office365-Filtering-Correlation-Id: 979ac47b-d4df-4fac-33f9-08db982467dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AyFeoiCtu2bnJuOmjzW19TQNYO/8r31DRwEFBDklVh0niMP9xVJmoDA8nh5Afh7sCFBdelwHOYGEjmuXguOjWhe1lPoPEoWa221UgP4DhlZriaugTqHApnaJGICgpyyEUWJdHz3DKmeJ8pFvSC0OplNCiDDjLOq8h731xb2ISSDk7ruImZRXwBp9CgkTQ+uwsgcmH0mq3jpOqcy0SkyZds8lg+gvUYFo7uhfgufax1yMWMievMI5akpNBiPUpYmeANP3iA1mm8lFzag7BV4pUzbe3aCl7xM/yC6FXZsmgsvVX+qVUffwq/QpFLZ5bQvLYTmGGqPrSn6PMQ+MuiWY0qEkQ6JfxV0krW73bWpO1ai3/AYJpVawB0cb9BSyqgksfZfNEtF4DIUAZxoiScGRi58FVA8jFUkIlf65JdEM34VTZvYcpAAbuOaEmwJuI7lcdJ/X0stEDCa5quOjXBclj0xl1285GIgr2474G/o/shPG6G8dAcGRRfifCPCAfkFcFcQfW3yt28CSsQ1vAjeBgNDzK2bVh4S/XZR02h/kJV5eMuOpkoSCpG8payQVYZ7ww4x4NMlcr3m3cr5U5/de4zUTwySbVcgZfTHHnZ+JyztiZQbbFCdFofJFopezgAg44C45llp6YY4+9lSItDQo4g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199021)(186006)(1800799003)(2616005)(38100700002)(6512007)(478600001)(86362001)(31696002)(6486002)(26005)(53546011)(6506007)(36756003)(41300700001)(5660300002)(8936002)(316002)(8676002)(54906003)(4326008)(6916009)(2906002)(66556008)(66476007)(66946007)(83380400001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QklaTk04MnV2ajZXa1RLZFRjdW9YQ3dRUWxXakNpUVdTRU5yMWZlKzlNYjJX?= =?utf-8?B?TmdPL2NNUzVZOG90ekVTdmNzY1FrUUpvMzF4a0pwdTRXeTNhTzQ0Nm01VFF0?= =?utf-8?B?a01oQkRVbytjYVFjLzBVZXBJRzVZNWdSVERVWVo0ajhaSVI5cVp2TEhuSDM2?= =?utf-8?B?ZlZwcFpPTmtSMFRhRUFZaU1aeHhCMzgwdXVwUWJzOEliMTVGQWlzb3hHeUVC?= =?utf-8?B?MGFxMlVyVnlnSjJqUEp2aUlPQVFkL1djejNZRnM3ZHYyRXBvN3hXeTFIZUJh?= =?utf-8?B?elA2VzIzU3JZcVVsVFJXYnpiUFZvS0dpZ2JGV3RTbXdxSG5aLzZobmJVVVNu?= =?utf-8?B?cXFJeStwTmtDeEcyb0oxbmFmVzZIMFE4Q0RVY0JjUjR1cjZHbEFWczA2OVcy?= =?utf-8?B?UStIcU1wZ0ZSRE93alltK1BZRHZKK3NPSVdWaXY4QWp2YVhIV1h6ZHgybExw?= =?utf-8?B?NUwyN2RCTUhEM0N6WCtGc2NnbjRGUDJkQmdYOXdlWEUrWTJuTlVHTnNsNDRy?= =?utf-8?B?RlNsbFRPSXp3a3QvNFBIUnRtUXFzK3JrL1daN2lTWjFnZFNBUGY2UDBLQkUr?= =?utf-8?B?ZXo4OWRDampoUXgwOTFtMTYySkxSL0JYZmd2RFNpOGhSa0MrYVJLY1MzdTFn?= =?utf-8?B?aXVucGNUbTA3QzR0c1RiUGY1MXlVQndQbEU1SzVnSkdKNGVsWlUvV0xZL0Fn?= =?utf-8?B?Y0N2MWhmRTMvZGJaYnkzam1WK0NnOXRLZ2dsTUpQM294S3FDbUxDN0s1bDlK?= =?utf-8?B?UGFsd0FnMTUzT2dDdFJYbnhxYlBteUdGK2thaUd4Z2gzYmtJU1ZNUWpGK2hM?= =?utf-8?B?WGNFejk3WFY5cGtSTWthQ3NrSmhRd2VWTm1JYmwrVktiY1NldXREUlB0eGlu?= =?utf-8?B?N1dwNkJBazNCN3gyL0QvQTZ4N3k1VEIwQmtzSnBHTms1VUROc0RPYTgyekU4?= =?utf-8?B?UXpPcXpEMmp3cFFkczhvdFpXY0YxakhRdGJyVTc0c0dTbGdiUXIvUDIxdTY0?= =?utf-8?B?Q2FtU3lwck8xdk9KM2tUOXpaL2o1L3lGTGY4cVh6THd6QzdjSmRtS3JBc0VJ?= =?utf-8?B?d1VOdHozVnhyRFBOcWFCNHlLY1ZvR2VwT3VOQno0ZnQrVlA5d0VlMnN3elNS?= =?utf-8?B?aHRDaEF3bWZRaWQ5YUhBTkVta0FSSVR5b3dZclNkY3hvS2twcU1weFp4K0JF?= =?utf-8?B?LzV6eEY0dFg5U1d3RjdGa0RDRHYzdkpIY01xQWJxMFV0a0tROE9SVTFFWi9M?= =?utf-8?B?TEpxOVlGZU5TZFBRT2paQnloY25NUC9XUTBMZHFoOExiZVczYTVGY2ZjS3Yv?= =?utf-8?B?ekF4MFFKVDl0Tjhyc2FKZ2VKeEJvRWh3cENxbWNDeU5YS0xlSGJxVklONGg5?= =?utf-8?B?MGRZQkkrNk9sZEk1c3c3NTVvYWtaWjBrUWJHUk00Q2t4UTFNYUNJOTNOYUxZ?= =?utf-8?B?TUZtbzc1bEdkZnR5NDlZRnErWGl0TTY0SXdQQ1lFbnkzdG00UnpNdEZ5U2Rt?= =?utf-8?B?d1E1Zi9uOGh4OW5NMTQrWjRWSjcvdkxMYUlZbDVmSXpLcW1QY0FUYW5VMmZN?= =?utf-8?B?MjZBNzV5Sy9Sd3luZEl3eFJmSTg0R2RaTDgwSWphTkdzNWdBeWhSRVZWNVhQ?= =?utf-8?B?ODRCRWVMWllsTXJvanN4VFY3Ym1yQVZERkFlTDEwRTJWUFp1UmFWMnlPZDhI?= =?utf-8?B?VWR0Ukc2em5nR0JwcGpXTUZTU1JJZk5ZWVVJb0gvaERXQTZWTDY0Y0MxZW9X?= =?utf-8?B?Z2pMek1XenpKWVNnZ3FhRUxQM01PVHVZUWhKbjF3R3hGY2RTQ3Y3NUtzNVpi?= =?utf-8?B?Tjk1eUp1dTFQeG1ubGxmMHBlZjB1NS81bzZxTGlUN25QOU1KZzQ2b29NS3Nl?= =?utf-8?B?UysvalBEeFZTeURHalhSMG5SQ3B3Rk0xaHYvRXZ1TVpOWHcvM1FNMmVoRld6?= =?utf-8?B?dC8rYWNhdFhkSnc2T0Y2blRiMjRGQTVZSGozU2N5NHZZdWdmOWNGeFpiTDg5?= =?utf-8?B?RWdJMnlUY1FJbmtmU3JmTStHdWduRVNjZFJQVHA0cTIxS0R0NmdzTWVhcEhZ?= =?utf-8?B?bCtpa21UQlk3N0JHOVUvYmtWVEhBcTUwM1hveGorUGc4aFRCa1lxYnZOUVVq?= =?utf-8?Q?YTU/sbExtMfz41lw0BCy7xw2L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 979ac47b-d4df-4fac-33f9-08db982467dd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:30:33.3242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KO/JT6lmkSy23azeYtj2VYfw6nJYoJLUsabBOtq1oqwBlJQRmjSbtH/uD32upj4KikH3nELXdRdwh3ucbq0lbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9741 On 01.08.2023 22:20, Daniel P. Smith wrote: > --- a/xen/arch/x86/cpu/common.c > +++ b/xen/arch/x86/cpu/common.c > @@ -164,48 +164,46 @@ static void set_cpuid_faulting(bool enable) > > void ctxt_switch_levelling(const struct vcpu *next) > { > - const struct domain *nextd = next ? next->domain : NULL; > - bool enable_cpuid_faulting; > - > - if (cpu_has_cpuid_faulting || > - boot_cpu_has(X86_FEATURE_CPUID_USER_DIS)) { > - /* > - * No need to alter the faulting setting if we are switching > - * to idle; it won't affect any code running in idle context. > - */ > - if (nextd && is_idle_domain(nextd)) > - return; > - /* > - * We *should* be enabling faulting for PV control domains. > - * > - * The domain builder has now been updated to not depend on > - * seeing host CPUID values. This makes it compatible with > - * PVH toolstack domains, and lets us enable faulting by > - * default for all PV domains. > - * > - * However, as PV control domains have never had faulting > - * enforced on them before, there might plausibly be other > - * dependenices on host CPUID data. Therefore, we have left > - * an interim escape hatch in the form of > - * `dom0=no-cpuid-faulting` to restore the older behaviour. > - */ > - enable_cpuid_faulting = nextd && (opt_dom0_cpuid_faulting || > - !is_control_domain(nextd) || > - !is_pv_domain(nextd)) && > - (is_pv_domain(nextd) || > - next->arch.msrs-> > - misc_features_enables.cpuid_faulting); > - > - if (cpu_has_cpuid_faulting) > - set_cpuid_faulting(enable_cpuid_faulting); > - else > - amd_set_cpuid_user_dis(enable_cpuid_faulting); > - > - return; > - } > - > - if (ctxt_switch_masking) > - alternative_vcall(ctxt_switch_masking, next); > + const struct domain *nextd = next ? next->domain : NULL; > + bool enable_cpuid_faulting; > + > + if ( cpu_has_cpuid_faulting || > + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS) ) { > + /* > + * No need to alter the faulting setting if we are switching > + * to idle; it won't affect any code running in idle context. > + */ > + if (nextd && is_idle_domain(nextd)) > + return; > + /* > + * We *should* be enabling faulting for PV control domains. > + * > + * The domain builder has now been updated to not depend on > + * seeing host CPUID values. This makes it compatible with > + * PVH toolstack domains, and lets us enable faulting by > + * default for all PV domains. > + * > + * However, as PV control domains have never had faulting > + * enforced on them before, there might plausibly be other > + * dependenices on host CPUID data. Therefore, we have left > + * an interim escape hatch in the form of > + * `dom0=no-cpuid-faulting` to restore the older behaviour. > + */ > + enable_cpuid_faulting = nextd && > + domain_has_cap(nextd, CAP_DISABLE_CPU_FAULT) && > + (is_pv_domain(nextd) || > + next->arch.msrs->misc_features_enables.cpuid_faulting); > + > + if (cpu_has_cpuid_faulting) > + set_cpuid_faulting(enable_cpuid_faulting); > + else > + amd_set_cpuid_user_dis(enable_cpuid_faulting); > + > + return; > + } > + > + if (ctxt_switch_masking) > + alternative_vcall(ctxt_switch_masking, next); > } I don't think I can spot what exactly changes here. Please avoid re- indenting the entire function. > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -907,6 +907,10 @@ static struct domain *__init create_dom0(const module_t *image, > > d->role |= ROLE_UNBOUNDED_DOMAIN; > > + if ( !opt_dom0_cpuid_faulting && > + !domain_set_cap(d, CAP_DISABLE_CPU_FAULT) ) > + printk(XENLOG_WARNING "failed to set CPU faulting on Dom %pd\n", d); No "Dom" please when you use %pd. Also I don't think you mean "set". Plus we commonly use "%pd: xyz failed\n". > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -472,7 +472,8 @@ struct domain > #define ROLE_HARDWARE_DOMAIN (1U<<2) > #define ROLE_XENSTORE_DOMAIN (1U<<3) > uint8_t role; > -#define CAP_CONSOLE_IO (1U<<0) > +#define CAP_CONSOLE_IO (1U<<0) > +#define CAP_DISABLE_CPU_FAULT (1U<<1) > uint8_t capabilities; > /* Is this guest being debugged by dom0? */ > bool debugger_attached; > @@ -1160,6 +1161,11 @@ static always_inline bool domain_set_cap( > case CAP_CONSOLE_IO: > d->capabilities |= cap; > break; > + case CAP_DISABLE_CPU_FAULT: > + /* Disabling cpu faulting is only allowed for a PV control domain. */ > + if ( is_pv_domain(d) && is_control_domain(d) ) > + d->capabilities |= cap; > + break; How do you express the x86-ness of this? Plus shouldn't this fail when either of the two conditions isn't met? Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:36:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:36:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580073.908355 (Exim 4.92) (envelope-from ) id 1qTOlS-000230-Eq; Tue, 08 Aug 2023 15:36:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580073.908355; Tue, 08 Aug 2023 15:36:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOlS-00022t-AV; Tue, 08 Aug 2023 15:36:54 +0000 Received: by outflank-mailman (input) for mailman id 580073; Tue, 08 Aug 2023 15:36:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOlQ-00022l-Ge for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:36:52 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062f.outbound.protection.outlook.com [2a01:111:f400:fe1a::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6499cdf9-3601-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:36:51 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8952.eurprd04.prod.outlook.com (2603:10a6:10:2e3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 15:36:48 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Tue, 8 Aug 2023 15:36:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6499cdf9-3601-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mva2z9WvqJl4epr7zZuY5uudnGMKwiSpuHbe7wTO4/hy7c6556cGbzZIbl7RXcX8RitF2XbrYBo51O74aXwDwZ99TcziLuSjC++Yp8um4PfVTRaHrIcWDF3qUAVD9S13/aHJ6psn9bgQVDkKLtu4XWgb/eottV1Ypg7JbMeLytsDWr5+5r4ROsDewyA82WleacCHN3q1gDo/GTED76hffqcJBgmUMa1lxx/fR6f6JLft46AbAsoHrXxJgs7R0DvFyKk4OmxrrN1riK7LDlyEszBnQmbG9MqTHrMwvJyREqKOekSay3hH0Js5NloQVpg+/c671ZNtSjlC2zpckMQdIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0SflO+UEOlwdotTVRSMKPXjDifvAURaeLbRt7mtTpIw=; b=WZ8xfzKNFuJh64FfhyuGh8ofq8Gf2mZHpS2ubF+kz1UFgt4/dbxaEV4TfEjFebpn1cKoIvLewLm8vVBxgHa8njT1STajOLG3LAwkSPyVgQqUJ0w4y+u0Izc3CX2K1ZvJWL9rX/rN3sNDy8rJ1lAgdqGA0rIcUsn6br0HO6vkAiTEoLcBiO2xhM++ABxIgXP/YH1cjfdo//ld4ne5R2MYV3+AyGbqIhvznbJHdA3m6zN8jkD9evjLTpTnDAUakDtXkgt7+1J28Ra/dHk16t3xtD1dfvQC9DtBQW470/6qu739xmhzzP7TLh8nds2G4ksKKLaRDFZWobLqFKrAFtGqhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0SflO+UEOlwdotTVRSMKPXjDifvAURaeLbRt7mtTpIw=; b=Hyf5UP3cLL+TLikl/Z2lbWyorzoFLZDKeK2r3mVM6pYBZOCWT/LxxMe5m4pSjzSPlxZqhQyvX6WwM+u7CnvVvqzNZUQdGemfRNldSxFJ79YcbcnRGHjz/5U8FvQ61B52sC35QCnW3+kaXpft8fgXhXiWQNc1idPP1RC+jHLrHOLiIKngT3/XRVISoVNxb+9aKMS5et032vlElOeXR3T4cyeKuSCwYljMaCntI5QCRNv60Jl94o2a7nPZbgFSZcwTvk30ClN03j53HNocrk870zUayZspxKd4VVQVTH+s82081OUYuU7tDkg/90SKqNtw/5nbThSiKsnYUhoP7BMvyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> Date: Tue, 8 Aug 2023 17:36:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Julien Grall Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , Nicola Vetrini , xen-devel@lists.xenproject.org References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8952:EE_ X-MS-Office365-Filtering-Correlation-Id: 82fcdb77-b364-44f2-f4d2-08db982547a5 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EqgEbG5klXu4tjqD9fD/NS2YMM+9MmP7plu+Ia41rJ04hLZ9B47GPizTil4Ee8VE80iUjdA3vfQVjwVeLycyc9Z17aRQXyC1mZvb4SDvNGY536anyRoQLbyaL2wKqc6c6a+IueyOy9tmoiybZWkUEmzMzW2ADOtui6Ny+tb/aTeY3y3eufait0VRsWX/jG8bpg4xiavQMOwYRNIbNBuNP1W0Esmknb1aL+PvJrkW6fX9hm1c17CYYSZX8efcSitDC/kd0yI6+cI3g0Jlr9EjI+yGCvVjYBnEtYUIExJVkuGKG1lcCFTHe+SXVRWdSNTPnoVBFC7IPHXHy5Ibuwj7BV6OayogYchTcJD/ranNuZOlBVPUDxGYhoqi3eve6vTSw3VtlS/oPNg1MA+gEIAGhFlLrLqSqcE8A1RywpLkue8b+YhD8HjP023rndOtWH0NuHoGgi3Wp4yBT6T1nZcCvA3LcdY6df1qVn9mgQNGmawpfPIB+Rn0ct6x00OvPni9dkMq3IzLiKmn8VjBn8VqERQe0hK9m8uwrbfRrZkr9X3e3IrcoXpRHYoO2V9qZWEDmQr5KUWJx7UiZ40piUUXPy0j8Y5AssypT4C/Xo7NetCrVbJpgCY2A9bGcpXYzy8yKOnFGYjscQsO+Ovi7AINQg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199021)(1800799003)(186006)(36756003)(2906002)(5660300002)(2616005)(54906003)(38100700002)(6486002)(66476007)(66946007)(66556008)(6916009)(6512007)(4326008)(316002)(31686004)(41300700001)(31696002)(86362001)(8676002)(8936002)(26005)(6506007)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTNxRFlHOFV2WmhSZ2MveWRaWHIvWGJldnNaY3ZYem5kdERyWC9TRW00aDZJ?= =?utf-8?B?blFJN0NHbnRQemxPZ2xGS0sxQmZqaDgrMTVwQmpnMDZuZkFkOWxWQThzdHBu?= =?utf-8?B?OUcrQWpEYkNxR1VMWmRIRDFtYm9ZTExPRXc1eHNxczZqeDd4S0JRRGl3djVo?= =?utf-8?B?Z3l1UDl5WlN6UGFNUFJlNE1iMURCSXhhTm9OS01TV0JxM1hTWlI1bVI1YzIv?= =?utf-8?B?OE94UkErRGdoTENKdzI1UXpwNWMvSzVlbnlvRCs1bU43cnFNWXlvVDMyRUQr?= =?utf-8?B?TENnVzhxcE9BV3BVSVYxUzN3QlZlMHB4bmtUNTJvYU9wZzZhZFgwcGpKeEFz?= =?utf-8?B?aVNBamNwZ2NhWnptVk5IMmhyZjNnMUFIcTRaRzRuNForaENwVlB6MVlONktB?= =?utf-8?B?bXkvWFU1Vk5qd2NFUkNSZHNWdEVkSG9ySFgvMnY5OGpOazA1RDRSNVBHY0E3?= =?utf-8?B?NHZlcmJwNS90WFBRQ2tJZWRhaWo1T3AvSmhLMjQ5b2pVRzg0RlU5UXhLTGFj?= =?utf-8?B?VkdPaTN3VzQ0QTFEdmcwSmlJenBVOHZQSm5wdnY2dE9qbmJqbHVQNml1aUF5?= =?utf-8?B?VVI4SEc2VnhNdWhTUVRsM2x6NjdHckRxWFdQZmh0cHVla2N4eSszcVgvTWE1?= =?utf-8?B?bGg1T3lsZGF4OFBacEdmbmFkVlNhV1YrU1NQZlNiWEhnWThIY0RIY3U2enVp?= =?utf-8?B?ekpXaVhHNkFPTW9tZmdaSWtoa3JIZ1phMEthV01wdXB3M0dEbFhWV3ZwQS93?= =?utf-8?B?c1pjem5aUkxZZHIrRHZDQUFiNkdDcjNrMEpFTzU5N1duTXFRZGpyVWk1WG1C?= =?utf-8?B?MFJsZndIdlo5YlNXNFZBNmlhK2tYRkJ0REZSQlgxeDFpbzhtWk5kQ0c4bGZu?= =?utf-8?B?cmxkd21temJTSEY3bVhYbEZXaFJvVHdFNmVXcWRUNTJnZC9LSDVSS0N0bU9x?= =?utf-8?B?K3BtcVBBNDRkcmVnVXhTRnJETEYrMk4xTlFQTlRQb25LUHRSWlNOZ1hZeVBs?= =?utf-8?B?Z2tEa1BLTXMyV2RyZ1ZPWTF5SUFaN3pqVis2SWZqWnpMUHp1dEdITEI5bGYr?= =?utf-8?B?WVpDVXZmdjkxV1B6L203d0t1Z0dzNGFjYWpQRkZqNUlsQzJobFk5dDFpTXRa?= =?utf-8?B?MlBFR2NsL0F0YlVtaEhwYS9YbjVGWmN4c3JwNC9EUVVoZHQ4OXhxWEtBTlFK?= =?utf-8?B?aWNybDQyZjFlZWFUMzBWcVBPKzZzNmRZS3gybm9udm8yczFQOTJ4K3BzaHRW?= =?utf-8?B?bnVMWHlldUtPek82eWNiOEtjUGlDS1dtUTNHOFFNYzF4aE9vM1dLMVUwNDdt?= =?utf-8?B?UHkvNTVnN0ZjLzE0c1cwa0hlazllNWw4ZXlSWlhLaHk4L3pDQm8rRkhrczNk?= =?utf-8?B?V3pvZURGcVdMRFI2eWJLQngzNmJsTE5tb2t5NTcxQk5pQjNkN0cxNXM2M1hC?= =?utf-8?B?dzY0dHgyOVZUQXBjdHdUU0IxKzBza1BhNklPN2NyM1A2M21ha3EzM2VtL2s2?= =?utf-8?B?c3d5R2dXUDRuaWJVV3p6UEZ3NGoyOWJDanplUHJKQ3JyczNpUnRZN3JQR3B6?= =?utf-8?B?eDBQY2JvcEVhVVFheVV3bjhYOWtaZTM4WldudWViNWpyVWxiMWFTaDdSQzdD?= =?utf-8?B?TTNzZktsakJabGhSS1ZzYW0rZ2Ntc1VXZ0wweXQvUEhvQWFUdGdsd000UjZG?= =?utf-8?B?blFhWEp2SjNLd0hwOWdYN0svNlgxL0I4Y0JEYXJZSFd2NjNGaWs4aFNzbEFx?= =?utf-8?B?ZEtHQ05IM0tNNEY4dFBuNEtxZHUyZDU4VldJUEppSUNRYmlnQ0haK05yWjRC?= =?utf-8?B?SHAzMzBIYStwMUsycGpja09TNXJibnBuT2t4VmhLdlZTZk55ZjJFUWRVV1hM?= =?utf-8?B?akxhcHVselVGM1RNdHNIR0h1aEZBb0N5UTdOWHZSYU1MNVJBMGdNalBQLzVj?= =?utf-8?B?eGNNTkNRKzhob1JwTHJTZjNtcUdmdVg5RTlYNTNRMnM0azhCb1FiZytHYnpY?= =?utf-8?B?L21td2pVMU41dlpJUWhKc2hnYk5HcUxUeThYZEZGdXNPN1pkUGFEYjMzd1p5?= =?utf-8?B?eGEvcW5veEdKYnZ5RGtMUzBCampVRm5QdXhLUHlXcUh2SC9lMlVjbVMrRUo1?= =?utf-8?Q?BdLI4dFeAUK0NLZJ46WtbCY5J?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82fcdb77-b364-44f2-f4d2-08db982547a5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 15:36:48.7693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 15Lr6/nuZvCWabBVf1aB7HzV9cCKFcbKr9GhlzUQH+0sTj5+XvubgdIe2OEPcDz2Wn7P4RIjLp190lv77IRC/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8952 On 08.08.2023 17:25, Julien Grall wrote: > On 02/08/2023 15:38, Nicola Vetrini wrote: >> The break statement after the return statement is definitely unreachable. >> As such, an call to the ASSERT_UNREACHABLE() macro is added to signal >> the intentionality of such construct. > > How about using unreachable() rather than ASSERT_UNREACHABLE()? The main > difference is the later will hint the compiler that the code cannot be > reached and will not crash Xen in debug build (this could be changed). Isn't using unreachable() in place of ASSERT_UNREACHABLE() unsafe (not here but in general)? It'll tell the compiler that (in the extreme case) it can omit the function epilogue, including the return instruction. In the resulting build, if the code turns out to be reachable, execution would fall through into whatever follows. In the case here ... >> --- a/xen/common/sched/core.c >> +++ b/xen/common/sched/core.c >> @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) >> /* fallthrough */ >> case TASKLET_enqueued|TASKLET_scheduled: >> return true; >> + ASSERT_UNREACHABLE(); >> break; >> case TASKLET_scheduled: >> clear_bit(_TASKLET_scheduled, tasklet_work); ... "return" alone already tells the compiler that "break" is unreachable. You don't need unreachable() for that. As said before, "break" like this simply want purging (and Misra is wrong to demand "break" everywhere - it should instead demand no [unannotated] fall-through, which can also be achieved by return, continue, and goto). Jan From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:44:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:44:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580080.908364 (Exim 4.92) (envelope-from ) id 1qTOsU-0003aG-89; Tue, 08 Aug 2023 15:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580080.908364; Tue, 08 Aug 2023 15:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOsU-0003a9-5X; Tue, 08 Aug 2023 15:44:10 +0000 Received: by outflank-mailman (input) for mailman id 580080; Tue, 08 Aug 2023 15:44:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOsS-0003a3-Ty for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:44:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTOsP-0008LA-2U; Tue, 08 Aug 2023 15:44:05 +0000 Received: from [15.248.2.255] (helo=[10.24.67.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTOsO-0001oX-SL; Tue, 08 Aug 2023 15:44:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=sqyyigZHJaOtU1jw9Xx23TLmVkSGZVzIrTLrpNwpGN8=; b=b/jPwmZlgfsEpY4wQOHQQgxZuP TsheKpSUk+4vO3CrOfh+0CSV+kv4pTjQKEtZeD/g3DCLZrNYQYZiPo75LXsj0LUkTjxFaK8JAwxbv 7SI0g3ax3kwbH715BnUwJKccPbO6gTH9DgXgHrapa1DUmHIn0D5AX2okqfp/G1xrOJww=; Message-ID: Date: Tue, 8 Aug 2023 16:44:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-GB To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , Nicola Vetrini , xen-devel@lists.xenproject.org References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> From: Julien Grall In-Reply-To: <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/08/2023 16:36, Jan Beulich wrote: > On 08.08.2023 17:25, Julien Grall wrote: >> On 02/08/2023 15:38, Nicola Vetrini wrote: >>> The break statement after the return statement is definitely unreachable. >>> As such, an call to the ASSERT_UNREACHABLE() macro is added to signal >>> the intentionality of such construct. >> >> How about using unreachable() rather than ASSERT_UNREACHABLE()? The main >> difference is the later will hint the compiler that the code cannot be >> reached and will not crash Xen in debug build (this could be changed). > > Isn't using unreachable() in place of ASSERT_UNREACHABLE() unsafe (not > here but in general)? Yes it is. It'll tell the compiler that (in the extreme case) > it can omit the function epilogue, including the return instruction. In > the resulting build, if the code turns out to be reachable, execution > would fall through into whatever follows. Right, but the problem is somewhat similar with adding ASSERT_UNREACHABLE() without proper error path because there is no guarantee the rest of the code will be correct in the unlikely case it is reachable. > > In the case here ... > >>> --- a/xen/common/sched/core.c >>> +++ b/xen/common/sched/core.c >>> @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) >>> /* fallthrough */ >>> case TASKLET_enqueued|TASKLET_scheduled: >>> return true; >>> + ASSERT_UNREACHABLE(); >>> break; >>> case TASKLET_scheduled: >>> clear_bit(_TASKLET_scheduled, tasklet_work); > > ... "return" alone already tells the compiler that "break" is > unreachable. You don't need unreachable() for that. As said before, > "break" like this simply want purging (and Misra is wrong to demand > "break" everywhere - it should instead demand no [unannotated] > fall-through, which can also be achieved by return, continue, and > goto). My suggestion was in the context of this series where we add ASSERT_UNREACHABLE() before break. From my understanding, we don't have a lot of leeway here because, from what Nicola wrote, rule 16.3 is mandatory. So I think using unreachable is better if we every decide to use break after return. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:54:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:54:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580086.908376 (Exim 4.92) (envelope-from ) id 1qTP22-00056Y-6w; Tue, 08 Aug 2023 15:54:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580086.908376; Tue, 08 Aug 2023 15:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTP22-00056R-1x; Tue, 08 Aug 2023 15:54:02 +0000 Received: by outflank-mailman (input) for mailman id 580086; Tue, 08 Aug 2023 15:54:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTP20-00056I-Gu for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:54:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c95bd1f8-3603-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 17:53:59 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 3779B4EE0737; Tue, 8 Aug 2023 17:53:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c95bd1f8-3603-11ee-b280-6b7b168915f2 MIME-Version: 1.0 Date: Tue, 08 Aug 2023 17:53:58 +0200 From: Nicola Vetrini To: Julien Grall Cc: Jan Beulich , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 In-Reply-To: References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit >> >> ... "return" alone already tells the compiler that "break" is >> unreachable. You don't need unreachable() for that. As said before, >> "break" like this simply want purging (and Misra is wrong to demand >> "break" everywhere - it should instead demand no [unannotated] >> fall-through, which can also be achieved by return, continue, and >> goto). > > My suggestion was in the context of this series where we add > ASSERT_UNREACHABLE() before break. From my understanding, we don't > have a lot of leeway here because, from what Nicola wrote, rule 16.3 > is mandatory. > > So I think using unreachable is better if we every decide to use break > after return. > > Cheers, 16.3 is not Mandatory, just Required. I was just reluctant to knowingly add one more violation while fixing another before submitting the patch. If indeed 16.3 won't likely be adopted by Xen, then that break should indeed go away. However, the main thing that's holding me back from doing a slimmed-down v2 here is that evidently there's no consensus even on the ASSERT_UNREACHABLE() patches. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 15:57:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 15:57:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580093.908385 (Exim 4.92) (envelope-from ) id 1qTP5e-0005il-KZ; Tue, 08 Aug 2023 15:57:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580093.908385; Tue, 08 Aug 2023 15:57:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTP5e-0005ie-Hd; Tue, 08 Aug 2023 15:57:46 +0000 Received: by outflank-mailman (input) for mailman id 580093; Tue, 08 Aug 2023 15:57:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTP5c-0005iY-N2 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 15:57:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTP5Z-0000Ga-8n; Tue, 08 Aug 2023 15:57:41 +0000 Received: from [15.248.2.255] (helo=[10.24.67.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTP5Z-0002PF-2P; Tue, 08 Aug 2023 15:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7EvLkAQmuz3R6hHoKhPlhpWB0vD5TVJ4Ate7DCOp56A=; b=OBZ5ZRagInM3yustkcaBNJOUw4 M2GvmZ4lTxz1nLkBWjlnNspvRlIv/ZKLDqDyu+RmPgx4UN4SHWuPQt67+uF/VujVm/u6wnGALEOlV WotO84SNL3Om3PeZjl+8Q9TvWCgfgN/+k6IpfUB8fQCIvqeXAU3LHFrYNSwTXVak68lk=; Message-ID: <6aac7add-544b-4c8a-b397-2a6b6c6b766c@xen.org> Date: Tue, 8 Aug 2023 16:57:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-GB To: Nicola Vetrini Cc: Jan Beulich , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2023 16:53, Nicola Vetrini wrote: > >>> >>> ... "return" alone already tells the compiler that "break" is >>> unreachable. You don't need unreachable() for that. As said before, >>> "break" like this simply want purging (and Misra is wrong to demand >>> "break" everywhere - it should instead demand no [unannotated] >>> fall-through, which can also be achieved by return, continue, and >>> goto). >> >> My suggestion was in the context of this series where we add >> ASSERT_UNREACHABLE() before break. From my understanding, we don't >> have a lot of leeway here because, from what Nicola wrote, rule 16.3 >> is mandatory. >> >> So I think using unreachable is better if we every decide to use break >> after return. >> >> Cheers, > > 16.3 is not Mandatory, just Required. Ah I misread what you wrote. In that case... > I was just reluctant to knowingly > add one more violation > while fixing another before submitting the patch. If indeed 16.3 won't > likely be adopted by Xen, > then that break should indeed go away. > > However, the main thing that's holding me back from doing a slimmed-down > v2 here is that > evidently there's no consensus even on the ASSERT_UNREACHABLE() patches. ... I agree with the following statement from Jan: "it should instead demand no [unannotated] fall-through, which can also be achieved by return, continue, and goto" Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 16:26:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 16:26:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580100.908394 (Exim 4.92) (envelope-from ) id 1qTPXR-0001Hq-IT; Tue, 08 Aug 2023 16:26:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580100.908394; Tue, 08 Aug 2023 16:26:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPXR-0001Hj-Fv; Tue, 08 Aug 2023 16:26:29 +0000 Received: by outflank-mailman (input) for mailman id 580100; Tue, 08 Aug 2023 16:26:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPXQ-0001HZ-0m; Tue, 08 Aug 2023 16:26:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPXP-0001Sw-O9; Tue, 08 Aug 2023 16:26:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPXP-0005pG-Cr; Tue, 08 Aug 2023 16:26:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTPXP-0005RF-CT; Tue, 08 Aug 2023 16:26:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vmjvnu+1rd7kVMziml73cRUIC0zSaFyBMOmHhRMENRM=; b=IZAZOwWrhjiv/Mkf9P+cvRZdzN QGISmS+H0gcWydh1oSBCp8Adtlxtr4ecKG4xtjuFXVxjyIjJFXhH973qLiqv3JpAXdkMVOsIpfuG2 pVlr+wEKQUpRdSnFeObjKDaQnaiUro5Ad86QlWyWBcKkUNPhRwy9gWpC8Cx4p2seFY0Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182225: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt-qcow2::broken:regression linux-linus:test-armhf-armhf-libvirt-qcow2:host-install(5):broken:regression linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=14f9643dc90adea074a0ffb7a17d337eafc6a5cc X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Tue, 08 Aug 2023 16:26:27 +0000 flight 182225 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182225/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-qcow2 broken test-armhf-armhf-libvirt-qcow2 5 host-install(5) broken REGR. vs. 180278 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail REGR. vs. 180278 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 14f9643dc90adea074a0ffb7a17d337eafc6a5cc baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 113 days Failing since 180281 2023-04-17 06:24:36 Z 113 days 205 attempts Testing same since 182225 2023-08-08 00:12:17 Z 0 days 1 attempts ------------------------------------------------------------ 3915 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 broken test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-qcow2 broken broken-step test-armhf-armhf-libvirt-qcow2 host-install(5) Not pushing. (No revision log; it would be 658984 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 16:43:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 16:43:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580108.908404 (Exim 4.92) (envelope-from ) id 1qTPo1-0003ix-Vm; Tue, 08 Aug 2023 16:43:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580108.908404; Tue, 08 Aug 2023 16:43:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPo1-0003iq-TB; Tue, 08 Aug 2023 16:43:37 +0000 Received: by outflank-mailman (input) for mailman id 580108; Tue, 08 Aug 2023 16:43:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPo0-0003ik-O3 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 16:43:36 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b5683846-360a-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 18:43:34 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691513003720900.7514399342488; Tue, 8 Aug 2023 09:43:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5683846-360a-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691513005; cv=none; d=zohomail.com; s=zohoarc; b=Ars4vVcGhiDHxCU36qEhp85KzI5ev7jsJ+KagjOKqLneQlqX6GYkJrhrW5QpkCIHJ0i8cMA2cmFWEGQJNufWPYybhEfxp4lbwzh2wohA1lP4OxprJ/PdY1vSN9BxQsPmcAbnnrxD0KxPf+q2ZbJ4bARqCklTyqxjKhnadSqac/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691513005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=52txK7ESKDZok3A5srdKuASszxGqFqTYvgKIv0vR6sY=; b=V8eP5AtnJCYb3ogGRO169JXpHwbkeO8PydthFx2231tpBhrYRzyR7BnJTZTcsoGMgdPR843KHtZLzmolmURxDkmlHbSML15kUTwqTbBJGBCNMAw6gUzZnn8x5Qd/jcGiiMoNVk2ojaK4DIWCiyt79b9RQiLe1glCVYp4Y4X71Fo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691513005; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=52txK7ESKDZok3A5srdKuASszxGqFqTYvgKIv0vR6sY=; b=I8oEGcCW3cTdLAS0A7IXI/XyKwm8pvtniAPKCh7va/pC/xLtEjfmmIuZEsRStlOY hyRGqvm2aO9Zte/Nb5aUF8HNhYol5vQC62m5B56kfHFa0PWS0du2dfgXpmzCyffRQi8 HlJQfn1xJtC8dVsxAzofEJ/QatifnbP61kK0XH0E= Message-ID: <4ee78808-5807-58e8-2054-016486607713@apertussolutions.com> Date: Tue, 8 Aug 2023 12:43:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Shawn Anastasio , Volodymyr Babchuk References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> Content-Language: en-US From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/4/23 02:08, Jan Beulich wrote: > Have these in one place, for all architectures to use. Also use the C99 > types as the "original" ones, and derive the Linux compatible ones > (which we're trying to phase out). For __s, seeing that no uses exist > anymore, move them to a new Linux compatibility header (as an act of > precaution - as said, we don't have any uses of these types right now). > > In some Flask sources inclusion of asm/byteorder.h needs moving later. I just did a test build against staging for x86 with all asm/byteorder.h includes removed from FLASK and it built successfully. If there are no object to a small non-functional change patch, I can clean up include ordering as well and submit it to xen-devel. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 16:49:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 16:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580116.908415 (Exim 4.92) (envelope-from ) id 1qTPtP-0004PN-QL; Tue, 08 Aug 2023 16:49:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580116.908415; Tue, 08 Aug 2023 16:49:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPtP-0004PG-M6; Tue, 08 Aug 2023 16:49:11 +0000 Received: by outflank-mailman (input) for mailman id 580116; Tue, 08 Aug 2023 16:49:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTPtN-0004PA-LP for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 16:49:09 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7cb120c0-360b-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 18:49:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 6204A8285619; Tue, 8 Aug 2023 11:49:05 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vzE_jrHoXU42; Tue, 8 Aug 2023 11:49:04 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id A916982856A2; Tue, 8 Aug 2023 11:49:04 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7jmK_WrnR538; Tue, 8 Aug 2023 11:49:04 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 03AD28285619; Tue, 8 Aug 2023 11:49:03 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7cb120c0-360b-11ee-b280-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com A916982856A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691513344; bh=p6+9yv2csDBijRpJzkd92jEcGbqUYM/6By887NKnwKc=; h=Message-ID:Date:MIME-Version:To:From; b=IU1HUA0t8um28VpddkG/oEySeGen62eAG2SyFwDZ30R0c5AVWEFFllY1ccnxuBo11 4mKJyRMMNfg0UIfXlApXSwAFef8T/70FgbWQae2uCRy+lZ/u1Z8PdEH3vd2bvaAR5b c0SY4uuIPCVv0LwGkA3QspwJJgtX+Vj7YAHUvFI4= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <7e77b8ed-2c0e-b814-6ce2-c6b2cf47bec9@raptorengineering.com> Date: Tue, 8 Aug 2023 11:49:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/9] xen/common: Add missing #includes treewide Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <2c9eb4fc175a1bdd21293f2e2611d8e21991636d.1691016993.git.sanastasio@raptorengineering.com> From: Shawn Anastasio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/7/23 10:39 AM, Jan Beulich wrote: > On 03.08.2023 01:02, Shawn Anastasio wrote: >> A few files treewide depend on defininitions in headers that they >> don't include. This works when arch headers end up including the >> required headers by chance, but broke on ppc64 with only minimal/stub >> arch headers. >> >> Signed-off-by: Shawn Anastasio > > I'm okay with the changes in principle, but I'd like to ask a question > nevertheless, perhaps also for other REST maintainers (whom you should > have Cc-ed, btw) to chime in. > >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include > > I realize there are several asm/*.h being included here already. Yet > generally I think common .c files would better not include any of > them directly; only xen/*.h ones should (and even there one might see > possible restrictions on what's "legitimate"). Do you recall what it > was that's needed from asm/page.h here ... The references to invalidate_icache (memory.c:310), clear_page (memory.c:1867), and copy_page (memory.c:1876) all need asm/page.h to be included somehow. I'm not sure which file ends up including asm/page.h for build to work on x86/arm, but with my minimal PPC headers it wasn't getting incidentally included and build was failing. > >> --- a/xen/common/xmalloc_tlsf.c >> +++ b/xen/common/xmalloc_tlsf.c >> @@ -27,6 +27,7 @@ >> #include >> #include >> #include >> +#include > > ... and here? Here it's the PAGE_ALIGN used at xmalloc_tlsf.c:549 > >> --- a/xen/include/xen/domain.h >> +++ b/xen/include/xen/domain.h >> @@ -4,6 +4,7 @@ >> >> #include >> >> +#include >> #include > > While following our sorting guidelines, this still looks a little odd. > We typically would include public/xen.h first, but then almost all other > public headers include it anyway. So I'm inclined to suggest to replace > (rather than amend) the existing #include here. To be clear, you're suggesting replacing the include of to ? I've tested this and it works fine, as expected. > > Then again I wonder why this include is needed. xen/domain.h is > effectively included everywhere, yet I would have hoped public/domctl.h > isn't. domctl.h is required because of the reference to `struct xen_domctl_createdomain` on domain.h:84. Alternatively, we could get away with a forward declaration of the struct. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Tue Aug 08 16:58:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 16:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580122.908425 (Exim 4.92) (envelope-from ) id 1qTQ2c-0005uS-MX; Tue, 08 Aug 2023 16:58:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580122.908425; Tue, 08 Aug 2023 16:58:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ2c-0005uL-Ig; Tue, 08 Aug 2023 16:58:42 +0000 Received: by outflank-mailman (input) for mailman id 580122; Tue, 08 Aug 2023 16:58:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ2b-0005uF-Ac for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 16:58:41 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d060796c-360c-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 18:58:37 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691513907885492.6306990381539; Tue, 8 Aug 2023 09:58:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d060796c-360c-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691513910; cv=none; d=zohomail.com; s=zohoarc; b=hhuK0tKhf9t493M/8GRmbr0aXPGUKF1JM5ZG9yg7eHtPWYBGsifdHMgMA5xxxF+/R0lmjakz2HpVdzWP78n8u6V/Z+jp6H9jTkS6bbqKFW30zTbGJVBDpOksupGHsqosYtevRSmEjp+PWnNcpFADkSDLKZMrxsCUY7tlWR9wlJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691513910; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3dUJBOjuqqWLjpxfBkSfndZTHDMoM6dCP9+ndRkRl/Y=; b=Pythcn5vYe714EREOI5XkhnYFP/FwmCn0oXHsFHgm6WI1cY8QrEloTui/B4VZzNfUdC2vMyQa/qL+oNt1tPFBBNXvGAtHry5Cniq5kcCN9ps9JLPYIu233afcs8D7XS2DU3d5hpS5vHe8Ivu6U0Y5maEeSPQzOMs7JoPcyLunTw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691513910; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3dUJBOjuqqWLjpxfBkSfndZTHDMoM6dCP9+ndRkRl/Y=; b=a0pIBflVFGXlGAlzBuQH+nOZar2uWMFQJPvH2+fdhMl55fs2zewOfMyl9o8f/Drj fKo04+mUQXUo0bvQ5SunV/MmUljfcPI6a5dauGP7BIkRDO3NbZnoiCMRUAhqXSI+osB C2BsmZWwU6I9tgz0pTRkLHU5ojw1XhkKZ0bQ+nRE= Message-ID: <72274554-5942-294e-aa1f-a594ae2e37e9@apertussolutions.com> Date: Tue, 8 Aug 2023 12:58:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: Jan Beulich Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> <01a80d4c-f19b-98ec-805e-e648e752d6b1@suse.com> <2ded224f-0b8b-90fe-367a-91762d1f25d5@suse.com> From: "Daniel P. Smith" In-Reply-To: <2ded224f-0b8b-90fe-367a-91762d1f25d5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/4/23 03:49, Jan Beulich wrote: > On 03.08.2023 18:31, Daniel P. Smith wrote: >> On 8/3/23 11:56, Jan Beulich wrote: >>> On 03.08.2023 14:56, Daniel P. Smith wrote: >>>> On 8/2/23 07:01, Jan Beulich wrote: >>>>> On 01.08.2023 18:06, Daniel P. Smith wrote: >>>>>> + { >>>>>> + for_each_domain(next) >>>>> >>>>> What guarantees that the list won't change behind your back? You don't >>>>> hold domlist_read_lock here afaict. It might be that you're safe because >>>>> that lock is an RCU one and this function is only invoked at init time >>>>> or from some form of interrupt handler. But that's far from obvious and >>>>> will hence need both properly confirming and stating in a comment. (It >>>>> is actually this concern, iirc, which so far had us avoid iterating the >>>>> domain list here.) >>>> >>>> It is better to error on the side of caution instead of assuming this >>>> will always be invoked in a safe manner. I will add a read lock for the >>>> domain list. >>> >>> I'm not firm enough in RCU to be certain whether acquiring that lock is >>> permissible here. >> >> Same and I took your statements to suggest that I should. > > Actually I wasn't paying close enough attention here: The code already > uses rcu_lock_domain_by_id(), which acquires domlist_read_lock. > Right, it grabs the lock while iterating through domain_hash[], I thought your concern was with regard to the iterating with for_each_domain and the embedded open coded version. Because of your inquiry, I have been thinking about it and I should be grabbing the lock as I iterate to be sure that I don't get deceived into believing the end of list was hit because a domain was being removed as I walked the list. And if it so happens that the context is always safe, then there should be no contention on grabbing the lock. Do you disagree? v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 17:00:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 17:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580129.908437 (Exim 4.92) (envelope-from ) id 1qTQ4D-0007MA-1i; Tue, 08 Aug 2023 17:00:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580129.908437; Tue, 08 Aug 2023 17:00:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4C-0007M3-VC; Tue, 08 Aug 2023 17:00:20 +0000 Received: by outflank-mailman (input) for mailman id 580129; Tue, 08 Aug 2023 17:00:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4B-0007KP-Nd for xen-devel@lists.xen.org; Tue, 08 Aug 2023 17:00:19 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b054daf-360d-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 19:00:15 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ3w-0002Cv-Ig; Tue, 08 Aug 2023 17:00:04 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTQ3w-0002JL-FQ; Tue, 08 Aug 2023 17:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b054daf-360d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=hx/b/ysblgOZvwHoYIpAdSgwsVEOYjRPfsd5/+vNC9k=; b=0DBpqTbjDr8PJUmiugsxaL363J ZWHE8GoyZaK4fHSBjk6bca98y80xB/RKuSadVHblLGpj3ceLkOooIBE0JnLHN53OQnNq6adHxxj7j 8slVTZJRPziCiSVbeKyPB4RhCqNOfuK5hDimQIdAsL1aq4MpWX8qOecTwdslljwwWrjI=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 432 v2 (CVE-2023-34319) - Linux: buffer overrun in netback due to unusual packet Message-Id: Date: Tue, 08 Aug 2023 17:00:04 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2023-34319 / XSA-432 version 2 Linux: buffer overrun in netback due to unusual packet UPDATES IN VERSION 2 ==================== Public release. ISSUE DESCRIPTION ================= The fix for XSA-423 added logic to Linux'es netback driver to deal with a frontend splitting a packet in a way such that not all of the headers would come in one piece. Unfortunately the logic introduced there didn't account for the extreme case of the entire packet being split into as many pieces as permitted by the protocol, yet still being smaller than the area that's specially dealt with to keep all (possible) headers together. Such an unusual packet would therefore trigger a buffer overrun in the driver. IMPACT ====== An unprivileged guest can cause Denial of Service (DoS) of the host by sending network packets to the backend, causing the backend to crash. Data corruption or privilege escalation seem unlikely but have not been ruled out. VULNERABLE SYSTEMS ================== All systems using a Linux based network backend with kernel 3.19 and newer are vulnerable, on the assumption that the fix for XSA-423 was taken. Systems using other network backends are not known to be vulnerable. MITIGATION ========== Using another PV network backend (e.g. the qemu based "qnic" backend) will mitigate the problem. Using a dedicated network driver domain per guest will mitigate the problem. CREDITS ======= This issue was discovered by Ross Lagerwall of Citrix. RESOLUTION ========== Applying the attached patch resolves this issue. xsa432-linux.patch Linux 6.3 - 6.5-rc $ sha256sum xsa432* bf7acd23be1d185c40aca8b4f7700e25afd482d9ac8671ae22b021380b059091 xsa432-linux.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmTSZKYMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZv9YH+wSW/H8BRo3hat2ssz4GOkNf/okVzOFyde0n6rsI uPeRbRqjnd9f+rvHFIYhi9sa2MUSZ9Lg/WwmZ1YdTFXB1PBZw1iDujB1HvDu7Xlm E0f6IkdhC17YaiBnmsUOwGhE/1wj0KOF86t92VX5skWK9NQ2OMOSYsBxHLFkNmBd VNHApva8ICfSfUA4pXuh3Zgaw2yw8k2ZcyFN8Aixd+1Vrxq7jfZ/PUL6hfLaNjLs a5xdj/b5+RuwRMqOI8jCFQXSgZLPDtZIIAFRi93ZMtUraARSjiN0tLpoRXsKp1u+ 0T1sgTApHJGTm7jgPAz3WMCh2innRBkEVvU55hRKZ4INIbc= =mMq6 -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa432-linux.patch" Content-Disposition: attachment; filename="xsa432-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5j b20+ClN1YmplY3Q6IHhlbi9uZXRiYWNrOiBGaXggYnVmZmVyIG92ZXJydW4g dHJpZ2dlcmVkIGJ5IHVudXN1YWwgcGFja2V0CgpJdCBpcyBwb3NzaWJsZSB0 aGF0IGEgZ3Vlc3QgY2FuIHNlbmQgYSBwYWNrZXQgdGhhdCBjb250YWlucyBh IGhlYWQgKyAxOApzbG90cyBhbmQgeWV0IGhhcyBhIGxlbiA8PSBYRU5fTkVU QkFDS19UWF9DT1BZX0xFTi4gVGhpcyBjYXVzZXMgbnJfc2xvdHMKdG8gdW5k ZXJmbG93IGluIHhlbnZpZl9nZXRfcmVxdWVzdHMoKSB3aGljaCB0aGVuIGNh dXNlcyB0aGUgc3Vic2VxdWVudApsb29wJ3MgdGVybWluYXRpb24gY29uZGl0 aW9uIHRvIGJlIHdyb25nLCBjYXVzaW5nIGEgYnVmZmVyIG92ZXJydW4gb2YK cXVldWUtPnR4X21hcF9vcHMuCgpSZXdvcmsgdGhlIGNvZGUgdG8gYWNjb3Vu dCBmb3IgdGhlIGV4dHJhIGZyYWdfb3ZlcmZsb3cgc2xvdHMuCgpUaGlzIGlz IENWRS0yMDIzLTM0MzE5IC8gWFNBLTQzMi4KCkZpeGVzOiBhZDdmNDAyYWU0 ZjQgKCJ4ZW4vbmV0YmFjazogRW5zdXJlIHByb3RvY29sIGhlYWRlcnMgZG9u J3QgZmFsbCBpbiB0aGUgbm9uLWxpbmVhciBhcmVhIikKU2lnbmVkLW9mZi1i eTogUm9zcyBMYWdlcndhbGwgPHJvc3MubGFnZXJ3YWxsQGNpdHJpeC5jb20+ ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KUmV2 aWV3ZWQtYnk6IFdlaSBMaXUgPHdlaS5saXVAa2VybmVsLm9yZz4KLS0tCiBk cml2ZXJzL25ldC94ZW4tbmV0YmFjay9uZXRiYWNrLmMgfCAxNSArKysrKysr KysrLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1u ZXRiYWNrL25ldGJhY2suYyBiL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL25l dGJhY2suYwppbmRleCBjMTUwMWY0MWUyZDguLjcyMDkxYjMzMTk2MyAxMDA2 NDQKLS0tIGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svbmV0YmFjay5jCisr KyBiL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL25ldGJhY2suYwpAQCAtMzk2 LDcgKzM5Niw3IEBAIHN0YXRpYyB2b2lkIHhlbnZpZl9nZXRfcmVxdWVzdHMo c3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUsCiAJc3RydWN0IGdudHRhYl9t YXBfZ3JhbnRfcmVmICpnb3AgPSBxdWV1ZS0+dHhfbWFwX29wcyArICptYXBf b3BzOwogCXN0cnVjdCB4ZW5fbmV0aWZfdHhfcmVxdWVzdCAqdHhwID0gZmly c3Q7CiAKLQlucl9zbG90cyA9IHNoaW5mby0+bnJfZnJhZ3MgKyAxOworCW5y X3Nsb3RzID0gc2hpbmZvLT5ucl9mcmFncyArIGZyYWdfb3ZlcmZsb3cgKyAx OwogCiAJY29weV9jb3VudChza2IpID0gMDsKIAlYRU5WSUZfVFhfQ0Ioc2ti KS0+c3BsaXRfbWFzayA9IDA7CkBAIC00NjIsOCArNDYyLDggQEAgc3RhdGlj IHZvaWQgeGVudmlmX2dldF9yZXF1ZXN0cyhzdHJ1Y3QgeGVudmlmX3F1ZXVl ICpxdWV1ZSwKIAkJfQogCX0KIAotCWZvciAoc2hpbmZvLT5ucl9mcmFncyA9 IDA7IHNoaW5mby0+bnJfZnJhZ3MgPCBucl9zbG90czsKLQkgICAgIHNoaW5m by0+bnJfZnJhZ3MrKywgZ29wKyspIHsKKwlmb3IgKHNoaW5mby0+bnJfZnJh Z3MgPSAwOyBucl9zbG90cyA+IDAgJiYgc2hpbmZvLT5ucl9mcmFncyA8IE1B WF9TS0JfRlJBR1M7CisJICAgICBzaGluZm8tPm5yX2ZyYWdzKyssIGdvcCsr LCBucl9zbG90cy0tKSB7CiAJCWluZGV4ID0gcGVuZGluZ19pbmRleChxdWV1 ZS0+cGVuZGluZ19jb25zKyspOwogCQlwZW5kaW5nX2lkeCA9IHF1ZXVlLT5w ZW5kaW5nX3JpbmdbaW5kZXhdOwogCQl4ZW52aWZfdHhfY3JlYXRlX21hcF9v cChxdWV1ZSwgcGVuZGluZ19pZHgsIHR4cCwKQEAgLTQ3NiwxMiArNDc2LDEy IEBAIHN0YXRpYyB2b2lkIHhlbnZpZl9nZXRfcmVxdWVzdHMoc3RydWN0IHhl bnZpZl9xdWV1ZSAqcXVldWUsCiAJCQl0eHArKzsKIAl9CiAKLQlpZiAoZnJh Z19vdmVyZmxvdykgeworCWlmIChucl9zbG90cyA+IDApIHsKIAogCQlzaGlu Zm8gPSBza2Jfc2hpbmZvKG5za2IpOwogCQlmcmFncyA9IHNoaW5mby0+ZnJh Z3M7CiAKLQkJZm9yIChzaGluZm8tPm5yX2ZyYWdzID0gMDsgc2hpbmZvLT5u cl9mcmFncyA8IGZyYWdfb3ZlcmZsb3c7CisJCWZvciAoc2hpbmZvLT5ucl9m cmFncyA9IDA7IHNoaW5mby0+bnJfZnJhZ3MgPCBucl9zbG90czsKIAkJICAg ICBzaGluZm8tPm5yX2ZyYWdzKyssIHR4cCsrLCBnb3ArKykgewogCQkJaW5k ZXggPSBwZW5kaW5nX2luZGV4KHF1ZXVlLT5wZW5kaW5nX2NvbnMrKyk7CiAJ CQlwZW5kaW5nX2lkeCA9IHF1ZXVlLT5wZW5kaW5nX3JpbmdbaW5kZXhdOwpA QCAtNDkyLDYgKzQ5MiwxMSBAQCBzdGF0aWMgdm9pZCB4ZW52aWZfZ2V0X3Jl cXVlc3RzKHN0cnVjdCB4ZW52aWZfcXVldWUgKnF1ZXVlLAogCQl9CiAKIAkJ c2tiX3NoaW5mbyhza2IpLT5mcmFnX2xpc3QgPSBuc2tiOworCX0gZWxzZSBp ZiAobnNrYikgeworCQkvKiBBIGZyYWdfbGlzdCBza2Igd2FzIGFsbG9jYXRl ZCBidXQgaXQgaXMgbm8gbG9uZ2VyIG5lZWRlZAorCQkgKiBiZWNhdXNlIGVu b3VnaCBzbG90cyB3ZXJlIGNvbnZlcnRlZCB0byBjb3B5IG9wcyBhYm92ZS4K KwkJICovCisJCWtmcmVlX3NrYihuc2tiKTsKIAl9CiAKIAkoKmNvcHlfb3Bz KSA9IGNvcCAtIHF1ZXVlLT50eF9jb3B5X29wczsK --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 17:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 17:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580138.908530 (Exim 4.92) (envelope-from ) id 1qTQ4U-00015o-Co; Tue, 08 Aug 2023 17:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580138.908530; Tue, 08 Aug 2023 17:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4T-00012T-Uq; Tue, 08 Aug 2023 17:00:37 +0000 Received: by outflank-mailman (input) for mailman id 580138; Tue, 08 Aug 2023 17:00:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4R-0007KP-Ny for xen-devel@lists.xen.org; Tue, 08 Aug 2023 17:00:35 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 141b2db0-360d-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 19:00:30 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4E-0002EB-Ly; Tue, 08 Aug 2023 17:00:22 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTQ4E-0002Mq-KX; Tue, 08 Aug 2023 17:00:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 141b2db0-360d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=XF+UrQzxCsQAO1ziUVnoWjoX2Wjp8D0sLL+ai1kpVc8=; b=pwUzTpFpAOwLBfHDBG7djxbQM4 mREzvolVB1T3ZIfsnyjjGMkT/B+fTcsuD7VhpYtCCAZNS96m/098QIRxLlkXVmFn20J4I+/sPmHpx J1cwyy6tGPdnkTtnXoAV/aPTQ13vad0Cl5z3AwoJOSTGUzVOOnXTgoBGmiqJ8jMc2P20=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 434 v1 (CVE-2023-20569) - x86/AMD: Speculative Return Stack Overflow Message-Id: Date: Tue, 08 Aug 2023 17:00:22 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2023-20569 / XSA-434 x86/AMD: Speculative Return Stack Overflow ISSUE DESCRIPTION ================= Researchers from ETH Zurich have extended their prior research (XSA-422, Branch Type Confusion, a.k.a Retbleed) and have discovered INCEPTION, also know as RAS (Return Address Stack) Poisoning, and Speculative Return Stack Overflow. The RAS is updated when a CALL instruction is predicted, rather than at a later point in the pipeline. However, the RAS is still fundamentally a circular stack. It is possible to poison the branch type and target predictions such that, at a point of the attackers choosing, the branch predictor predicts enough CALLs back-to-back to wrap around the entire RAS and overwrite a correct return prediction with one of the attackers choosing. This allows the attacker to control RET speculation in a victim context, and leak arbitrary data as a result. For more details, see: https://comsec.ethz.ch/inception https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-7005 IMPACT ====== An attacker might be able to infer the contents of memory belonging to other guests. VULNERABLE SYSTEMS ================== Only CPUs from AMD are believed to be potentially vulnerable. CPUs from other manufacturers are not believed to be impacted. At the time of writing, all in-support AMD CPUs (that is, Zen1 thru Zen4 microarchitectures) are believed to be potentially vulnerable. Older CPUs have not been analysed. By default following XSA-422, Xen mitigates BTC on AMD Zen2 and older CPUs by issuing an IBPB on entry to Xen. On Zen2 and older CPUs, this is believed to be sufficient to protect against SRSO too. AMD Zen3 and Zen4 CPUs are susceptible to SRSO too. All versions of Xen are vulnerable on these CPUs. MITIGATION ========== On Zen3 and Zen4, there is no mitigation. RESOLUTION ========== AMD are producing microcode updates for Zen3 and Zen4. Consult your dom0 OS vendor. With the microcode update applied, booting Xen with `spec-ctrl=ibpb-entry` is sufficient to protect against SRSO. The appropriate set of patches will default to using IBPB-on-entry on Zen3 and Zen4 CPUs, as well as synthesise new CPUID bits for guests to use in order to determine their susceptibility in a migration-safe way. The patches for this issue interact texturally but not logically with the fixes for XSA-435, which itself has complexities. See XSA-435 for details of how to obtain the fixes. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmTSZOsMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZ8uMIAL2xBV/B3O0t90aFhX75dOWZBUkujMN0xHDjyI+c lnEmy44QnX+jI9IBSuc4qaJmLXnUO71WsMU1XeKucOnh9E1kjgHB2H0GgS+GI6dG LtAVxn+RRK39YIO0CHAXvr/tlX/eyodvxtmxOKLRY47J0hHLToXBEdc2VfXrUEfk 8AZn4hhHDGfRMX7jguxPFnrKCS3sZCFn1FYPtUxNGi2BbUzFacc+zZ2OISR7C59H 24q9UIgUVoVwOnUWBEzW6oHmjP44Q0kG3E8LhZQhr1YkAG++KapgTPllc3cU4xja G8ozTeMeyVbM29EMS7QknOlkvMSUmtgzNg7Pt6El9oSyuH4= =rrcN -----END PGP SIGNATURE----- --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 17:00:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 17:00:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580137.908538 (Exim 4.92) (envelope-from ) id 1qTQ4V-0001E3-4G; Tue, 08 Aug 2023 17:00:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580137.908538; Tue, 08 Aug 2023 17:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4U-0001Cv-Hv; Tue, 08 Aug 2023 17:00:38 +0000 Received: by outflank-mailman (input) for mailman id 580137; Tue, 08 Aug 2023 17:00:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4R-0008Pg-HR for xen-devel@lists.xen.org; Tue, 08 Aug 2023 17:00:35 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15ac9c68-360d-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 19:00:33 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ4I-0002EZ-BA; Tue, 08 Aug 2023 17:00:26 +0000 Received: from andrewcoop by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTQ4I-0002Ny-AH; Tue, 08 Aug 2023 17:00:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15ac9c68-360d-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=en5sf8iDi6wMkkzej5Amgs+r5p4GVNXHBgZi2MSJb+Y=; b=MPKkG5jYUN1tO1svplxiF31itS EfRa7qABXTT6mdyJmfkzEiCeGh5QCYMrshVCbcsWvIX4jERLUo2cWdKnhrclAI/UVwb1RBiK7fOtQ ffUNRwKar3WoVhwdaOwzqdlBce6uDGTNfeRu1D1JuxEEmTV07FG3UNJGgqPEUEEMhfDo=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 435 v1 (CVE-2022-40982) - x86/Intel: Gather Data Sampling Message-Id: Date: Tue, 08 Aug 2023 17:00:26 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-40982 / XSA-435 x86/Intel: Gather Data Sampling ISSUE DESCRIPTION ================= A researcher has discovered Gather Data Sampling, a transient execution side-channel whereby the AVX GATHER instructions can forward the content of stale vector registers to dependent instructions. The physical register file is a structure competitively shared between sibling threads. Therefore an attacker can infer data from the sibling thread, or from a more privileged context. For more details, see: https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/technical-documentation/gather-data-sampling.html IMPACT ====== An attacker can infer data from different contexts on the same core. Examples of such data includes key material, cipher and plaintext from the AES-NI instructions, or the contents of REP-MOVS instructions, commonly used to implement memcpy(). VULNERABLE SYSTEMS ================== Systems running all versions of Xen are affected. See the Intel documentation for a list of affected processors. CPUs from other hardware vendors are not believed to be affected. MITIGATION ========== This issue can be mitigated by disabling AVX, either by booting Xen with `cpuid=no-avx` on the command line, or by specifying `cpuid="host:avx=0"` in the vm.cfg file of all untrusted VMs. However, this may come with a significant performance impact on the system and is not recommended for anyone able to deploy the microcode and patch described below. RESOLUTION ========== Intel are producing microcode updates to address the issue for most affected CPUs. Consult your dom0 OS vendor. This microcode is effective when late-loaded, which can be performed on a live system without reboot. Without microcode, disabling AVX is the only mitigation. This is implemented by the patches to Xen on hardware believed to be vulnerable. In addition, to indicate safety to guest kernels, Xen needs to synthesise new bits for guests to see, which depends on MSR_ARCH_CAPS being visible to guests. The work to support MSR_ARCH_CAPS is extensive and has been going on in public in earnest since March. The backports to security trees are more-extensive still. Therefore, we have decided to produce new releases on all stable trees. Please find fixes in the respective branches under the following release tags: RELEASE-4.17.2 RELEASE-4.16.5 RELEASE-4.15.5 RELEASE-4.14.6 Other release activities (tarballs, announcements, etc) will happen in due course. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmTSZQcMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZoMQH/RAjt/wZHCg/aFunhbiAbdzWmJo36Cz6KL+R2G+v sBiPMsBvZxSikl6yeYAADgEUFKqNWQhLCAl6oaqgPbtDhFOxeZ72DRhgwZIx2KNL 85ECXk3rFhipiai6oHHbOemjPglXsyz+B5+NE64gOjpjdms9cfvfWnMnSQRF+NKa vbpEeP+KIK1EcmKOp/xfzjjgEzg7VmJ8jnct0A77sUQYi3Ll1+ENLEcqDElP+Qob wmM6QYkz78q/xO+R+bT+NNJ33q6JXQdixXa3ddiWrcvL/A3SveqtQh78u9daKmFM aaivBTgJSWk0348aelEF8UjLNKx8rVRc4Dk2elioiE1PCe8= =05gz -----END PGP SIGNATURE----- --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 17:05:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 17:05:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580222.908564 (Exim 4.92) (envelope-from ) id 1qTQ8f-00067A-3D; Tue, 08 Aug 2023 17:04:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580222.908564; Tue, 08 Aug 2023 17:04:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ8f-000673-0h; Tue, 08 Aug 2023 17:04:57 +0000 Received: by outflank-mailman (input) for mailman id 580222; Tue, 08 Aug 2023 17:04:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQ8e-00062a-JW for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 17:04:56 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1163a2e-360d-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 19:04:53 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 21B538285626; Tue, 8 Aug 2023 12:04:52 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zcTuPCpCFHRq; Tue, 8 Aug 2023 12:04:51 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id EFC1282856A2; Tue, 8 Aug 2023 12:04:50 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id c5x8cFD2Kyjd; Tue, 8 Aug 2023 12:04:50 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id D252D8285626; Tue, 8 Aug 2023 12:04:49 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1163a2e-360d-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com EFC1282856A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691514291; bh=8mDkZMO38zMcyRoQH/8OKwJ+pAJdMUYCt14tcGDJBsE=; h=Message-ID:Date:MIME-Version:To:From; b=G5COsaTNrdoAo4OMZuqGVaY5f3O0gnMsQb2oAcsXE+R21gxG03iKI/tpYJl3WF9WP RU3yCWbYeGhZurjdrNn4WtwqrWfYjmAqQZSfcgJWPkRlBe+w8oHS7UEPvX05gu5BYu 4az8lFDMhWdW81EbMv9xUtIPOpgDJd/Ji+KLI3e4= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <95e2da23-1c04-266f-5a26-e43564485751@raptorengineering.com> Date: Tue, 8 Aug 2023 12:04:48 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/9] xen/ppc: Add public/arch-ppc.h Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <14d8455ca49f69a56e87aad5d4e20cf8f77e55cd.1691016993.git.sanastasio@raptorengineering.com> <2705d5dd-e74f-4093-aad9-3e54060160f6@suse.com> From: Shawn Anastasio In-Reply-To: <2705d5dd-e74f-4093-aad9-3e54060160f6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/7/23 10:51 AM, Jan Beulich wrote: > On 03.08.2023 01:02, Shawn Anastasio wrote: >> Signed-off-by: Shawn Anastasio >> --- >> xen/include/public/arch-ppc.h | 140 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 140 insertions(+) >> create mode 100644 xen/include/public/arch-ppc.h >> >> diff --git a/xen/include/public/arch-ppc.h b/xen/include/public/arch-ppc.h >> new file mode 100644 >> index 0000000000..0eb7ce4208 >> --- /dev/null >> +++ b/xen/include/public/arch-ppc.h >> @@ -0,0 +1,140 @@ >> +/* >> + * Permission is hereby granted, free of charge, to any person obtaining a copy >> + * of this software and associated documentation files (the "Software"), to >> + * deal in the Software without restriction, including without limitation the >> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the Software is >> + * furnished to do so, subject to the following conditions: >> + * >> + * The above copyright notice and this permission notice shall be included in >> + * all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, >> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE >> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER >> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER >> + * DEALINGS IN THE SOFTWARE. > > Any reason for a spelled out license rather than an SPDX header? > This was an oversight when importing the file from the old Xen 3.2 source tree. I'll drop the license text in favor of an SPDX header. >> + * Copyright (C) IBM Corp. 2005, 2006 >> + * Copyright (C) Raptor Engineering, LLC 2023 >> + * >> + * Authors: Hollis Blanchard >> + * Timothy Pearson >> + */ >> + >> +#ifndef __XEN_PUBLIC_ARCH_PPC64_H__ >> +#define __XEN_PUBLIC_ARCH_PPC64_H__ > > The 64 wants dropping here, considering the name of the header. Ditto. Will fix. >> +#define int64_aligned_t int64_t __attribute__((aligned(8))) >> +#define uint64_aligned_t uint64_t __attribute__((aligned(8))) > > I understand arch-arm.h has it this way too, but in public headers I > think we're better off using __aligned__ (in the example here). Sure, I can make that change. >> +#ifndef __ASSEMBLY__ >> +#define ___DEFINE_XEN_GUEST_HANDLE(name, type) \ >> + typedef union { type *p; unsigned long q; } \ >> + __guest_handle_ ## name; \ >> + typedef union { type *p; uint64_aligned_t q; } \ >> + __guest_handle_64_ ## name >> + >> +#define __DEFINE_XEN_GUEST_HANDLE(name, type) \ >> + ___DEFINE_XEN_GUEST_HANDLE(name, type); \ >> + ___DEFINE_XEN_GUEST_HANDLE(const_##name, const type) >> +#define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name) >> +#define __XEN_GUEST_HANDLE(name) __guest_handle_64_ ## name >> +#define XEN_GUEST_HANDLE(name) __XEN_GUEST_HANDLE(name) >> +#define XEN_GUEST_HANDLE_PARAM(name) __guest_handle_ ## name >> +#define set_xen_guest_handle_raw(hnd, val) \ >> + do { \ >> + __typeof__(&(hnd)) _sxghr_tmp = &(hnd); \ > > In new code, can you please avoid underscore-prefixed macro locals, > which violate name space rules set forth by the standard? We appear > to be adopting underscore-suffixed naming for such locals. Sure, will fix. >> + _sxghr_tmp->q = 0; \ >> + _sxghr_tmp->p = val; \ > > "val" need parenthesizing here. Will fix. >> + } while ( 0 ) >> +#define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) >> + >> +#ifdef __XEN_TOOLS__ >> +#define get_xen_guest_handle(val, hnd) do { val = (hnd).p; } while (0) >> +#endif >> + >> +typedef uint64_t xen_pfn_t; >> +#define PRI_xen_pfn PRIx64 >> +#define PRIu_xen_pfn PRIu64 >> + >> +/* >> + * Maximum number of virtual CPUs in legacy multi-processor guests. >> + * Only one. All other VCPUS must use VCPUOP_register_vcpu_info. >> + */ >> +#define XEN_LEGACY_MAX_VCPUS 1 >> + >> +typedef uint64_t xen_ulong_t; >> +#define PRI_xen_ulong PRIx64 >> +#endif >> + >> +/* >> + * Pointers and other address fields inside interface structures are padded to >> + * 64 bits. This means that field alignments aren't different between 32- and >> + * 64-bit architectures. >> + */ >> +/* NB. Multi-level macro ensures __LINE__ is expanded before concatenation. */ >> +#define __MEMORY_PADDING(_X) >> +#define _MEMORY_PADDING(_X) __MEMORY_PADDING(_X) >> +#define MEMORY_PADDING _MEMORY_PADDING(__LINE__) > > This doesn't parallel anything in other architectures afaics, and it is > also not used anywhere in this header. What is this about? If it needs > to stay, it'll need properly moving into XEN_* namespace. This was another holdover from the old Xen code. I'll remove it. >> +/* And the trap vector is... */ >> +#define TRAP_INSTR "li 0,-1; sc" /* XXX just "sc"? */ > > Same question / remark here. Ditto, will remove. > >> +#ifndef __ASSEMBLY__ >> + >> +#define XENCOMM_INLINE_FLAG (1UL << 63) > > Is this an indication that you mean to revive xencomm.h? No, this was yet another holdover from the old Xen tree. I'll remove it. >> +typedef uint64_t xen_ulong_t; >> + >> +/* User-accessible registers: nost of these need to be saved/restored >> + * for every nested Xen invocation. */ > > Nit: comment style (and s/nost/most/). > Will fix. >> +struct vcpu_guest_core_regs >> +{ >> + uint64_t gprs[32]; >> + uint64_t lr; >> + uint64_t ctr; >> + uint64_t srr0; >> + uint64_t srr1; >> + uint64_t pc; >> + uint64_t msr; >> + uint64_t fpscr; /* XXX Is this necessary */ >> + uint64_t xer; >> + uint64_t hid4; /* debug only */ >> + uint64_t dar; /* debug only */ >> + uint32_t dsisr; /* debug only */ >> + uint32_t cr; >> + uint32_t __pad; /* good spot for another 32bit reg */ >> + uint32_t entry_vector; >> +}; >> +typedef struct vcpu_guest_core_regs vcpu_guest_core_regs_t; >> + >> +typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */ /* XXX timebase */ >> + >> +/* ONLY used to communicate with dom0! See also struct exec_domain. */ >> +struct vcpu_guest_context { >> + vcpu_guest_core_regs_t user_regs; /* User-level CPU registers */ >> + uint64_t sdr1; /* Pagetable base */ >> + /* XXX etc */ >> +}; >> +typedef struct vcpu_guest_context vcpu_guest_context_t; >> +DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t); >> + >> +struct arch_shared_info { >> + uint64_t boot_timebase; >> +}; >> + >> +struct arch_vcpu_info { >> +}; >> + >> +struct xen_arch_domainconfig { >> +}; >> + >> +typedef struct xen_pmu_arch { uint8_t dummy; } xen_pmu_arch_t; >> + >> +/* Support for multi-processor guests. */ >> +#endif > > Stray comment? Yup, I'll drop it. > > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Tue Aug 08 17:23:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 17:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580388.908574 (Exim 4.92) (envelope-from ) id 1qTQQB-0000iL-Pw; Tue, 08 Aug 2023 17:23:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580388.908574; Tue, 08 Aug 2023 17:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQQB-0000iE-NB; Tue, 08 Aug 2023 17:23:03 +0000 Received: by outflank-mailman (input) for mailman id 580388; Tue, 08 Aug 2023 17:23:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTQQ9-0000hY-VC for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 17:23:02 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 381b4b6c-3610-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 19:22:59 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691515374507665.4281754622317; Tue, 8 Aug 2023 10:22:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 381b4b6c-3610-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691515376; cv=none; d=zohomail.com; s=zohoarc; b=KfWyKAd7k/j1FvjXNy8LfveOuk5h72ovl4+xbP7C9k1vyRlVcI/odaQusP1zKIuQ0Dsm6zUnKqygrEPKnsp7jAdedO9BWKtxqAbwPMFYTc5jUrRJyt5JdsP1Be4zpF++HPkom3cJiWX9swlp8l7L05QcJKHl6OwO6U7hs/ZmSTc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691515376; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=QgUwB5bURqerdWrUtMak9mr4Qnpb0Dv3X45/DrKwdsY=; b=ZkyhkoGDS6TBGNIiXjZypsMkibvCumAdWKk/VubxVqMe+8OmTeZZd8clQ3McqzTbqTMJLvLQzGv+HeCLtg4AaK+VgZFfpC6zxSlaTA1ElcuYjwHsbGHk9XLVKTj7XGpMgOAJc1MpwgLiXYA9nOG4RpDNI+eZ2zFj8d9rMqlZle4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691515376; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=QgUwB5bURqerdWrUtMak9mr4Qnpb0Dv3X45/DrKwdsY=; b=PEinN6+ckmSE7+oiygpyU5WPE1QhGKSwcwzwJ+C3YPVCaTj9L0WbI8EmFcF6Ap/h YAc7IuQAWDIH9zFOASMzqwl5oc8P/yKy++UeNrh4czPN5b6ViL0tUTv4w1Lpq6eQdtF i8Qpk8gv+B9nxhRLpxw3lIrzBoGkZcopaHZaYUUs= Message-ID: Date: Tue, 8 Aug 2023 13:22:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: Stefano Stabellini Cc: Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 19:38, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Daniel P. Smith wrote: >>> Also, what is the plan for the existing dom0less dt properties? >>> Will they need to be moved to new /hypervisor node or we will have to parse >>> both /chosen and /hypervisor nodes? >> >> In the proposal I sent to xen-devel in response to Luca's RFC for rebranding >> dom0less features under hyperlaunch, that is the purpose of this commit. Get >> this document up to date with what was done in v1 along with what we are >> planning/working on for hyperlaunch. One could think of this as effectively >> the API to the capabilities hyperlaunch will provide. Not just how to >> construct a domain, but what kinds of domains can be constructed by >> hyperlaunch. Step one of the proposal is to publish a patch upon which we all >> can iterate over and get to an agreement on a suitable interface for all. The >> next step would be the introduction of hyperlaunch dom0less compatibility >> mode, that would see the moving of the parsing logic for the existing dom0less >> nodes under /xen/common/domain-builder. It would continue to exist there even >> after hyperlaunch proper is merged and can remain there for backward >> compatibility until there is a decision to retire the compatibility interface. > > I like this plan. The two interfaces are so similar that it is basically > one interface with a couple of tiny differences. > > So I expect we would move the existing dom0less parsing code to common/, > add a couple of extensions (such as parsing /hypervisor in addition to > /chosen) and use it as it. Do you mean /chosen/hypervisor? > Later on, after a few years of using /hypervisor instead of /chosen, if > nobody is using /chosen anymore, we could retire /chosen completely. But > this is just one DT node/property that gets retired (there are a couple > of others). I don't imagine we'll have a full new implementation of the > DT parsing logic that supersedes the existing implementation of it > (especially considering the difficulty of maintaining 2 different parsing > logics in the hypervisor for similar interfaces). +1 > Same thing for the DT interface documentation. I don't think we need two > DT interface docs? We could start with the existing dom0less interface > (docs/misc/arm/device-tree/booting.txt), and move it somewhere common > like docs/misc/device-tree. So in the plan that I sent, patch series 3 was were I was going to consolidate docs/design/launch/hyperlaunch-devicetree.rst and docs/misc/arm/device-tree/booting.txt into a single document under docs/features/hyperlaunch/device-tree.rst along with moving docs/features/dom0less.pandoc to docs/features/hyperlaunch/dom0less-compatibility-mode.pandoc. The thinking here was to get all the feature documentation together in a single place, but I would be open to putting the suggested consolidated device-tree.rst mentioned above into docs/misc/device-tree/hyperlaunch.rst if that is preferred. > Then add any changes or extensions required by other architecture, such > as x86 and RISC-V. > > For sure for x86 we need "module-index". I don't know if anything else > is must-have to get it to work on x86 but if there is, we should add > those too. Hmm good point, since in the suggested patch series 3 from the plan, this probably should get cropped down to what we actually have implemented for x86 hyperlaunch and then get expanded as it becomes feature complete. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 19:20:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 19:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580397.908584 (Exim 4.92) (envelope-from ) id 1qTSFK-0003tH-25; Tue, 08 Aug 2023 19:19:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580397.908584; Tue, 08 Aug 2023 19:19:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTSFJ-0003sl-RH; Tue, 08 Aug 2023 19:19:57 +0000 Received: by outflank-mailman (input) for mailman id 580397; Tue, 08 Aug 2023 19:19:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTSFH-0003sI-Pb for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 19:19:55 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ca36bd0-3620-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 21:19:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 744CC828587A; Tue, 8 Aug 2023 14:19:51 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id bcHlttGesGtC; Tue, 8 Aug 2023 14:19:50 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 47DC682855D5; Tue, 8 Aug 2023 14:19:50 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1bEtGMk1tYep; Tue, 8 Aug 2023 14:19:50 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id D6FEF828587A; Tue, 8 Aug 2023 14:19:49 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ca36bd0-3620-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 47DC682855D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691522390; bh=HYGdGlNDyauIBLzupGLZafVYsfWvl2F0CI3SW+AmCnk=; h=Message-ID:Date:MIME-Version:To:From; b=u+m7SMyJIq0iBH2P0YZVpklRZif67qxmQPhJpMtYRmJYRbuMDZN0KvTe/+cjG6vhc 0UXr6KhtvwAzsh3iXqlksjZuE2tSG+A8x0bG+vQUYILUK/zwqCyq+PvljGHWwZXmyR fDaLzJxACkeafPR8U9QDaFW1ObzEZUOxXlAbzBws= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <080f37f4-2b2a-c057-568d-6e4974eb2f8c@raptorengineering.com> Date: Tue, 8 Aug 2023 14:19:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/9] xen/ppc: Implement atomic.h Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <8035b9659a5930c00802dd36ab52574695d6b419.1691016993.git.sanastasio@raptorengineering.com> <5e9380a5-7e33-ea70-6aa5-3ce1906a159c@suse.com> From: Shawn Anastasio In-Reply-To: <5e9380a5-7e33-ea70-6aa5-3ce1906a159c@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/7/23 11:13 AM, Jan Beulich wrote: > On 03.08.2023 01:02, Shawn Anastasio wrote: >> Implement atomic.h for PPC, based off of the original Xen 3.2 >> implementation. > > Since likely that originally came from Linux, did you cross check that > Linux hasn't gained any bug fixes in the meantime? I did -- the atomic barrier instructions used by linux have changed since this code was originally written, so I've updated them to be inline with modern linux. > Other than this just a couple of nits; I'm not really qualified to > review in particular the inline assembly here, I'm afraid. > >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/atomic.h >> @@ -0,0 +1,387 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * PowerPC64 atomic operations >> + * >> + * Copyright (C) 2001 Paul Mackerras , IBM >> + * Copyright (C) 2001 Anton Blanchard , IBM >> + * Copyright Raptor Engineering LLC >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version >> + * 2 of the License, or (at your option) any later version. >> + */ >> + >> +#ifndef _ASM_PPC64_ATOMIC_H_ >> +#define _ASM_PPC64_ATOMIC_H_ > > To fit the name, no "64" please. Will fix. >> +#include >> + >> +#include >> +#include >> + >> +static inline int atomic_read(const atomic_t *v) >> +{ >> + return *(volatile int *)&v->counter; >> +} >> + >> +static inline int _atomic_read(atomic_t v) >> +{ >> + return v.counter; >> +} >> + >> +static inline void atomic_set(atomic_t *v, int i) >> +{ >> + v->counter = i; >> +} >> + >> +static inline void _atomic_set(atomic_t *v, int i) >> +{ >> + v->counter = i; >> +} >> + >> +void __bad_atomic_read(const volatile void *p, void *res); >> +void __bad_atomic_size(void); >> + >> +#define build_atomic_read(name, insn, type) \ >> + static inline type name(const volatile type *addr) \ >> + { \ >> + type ret; \ >> + asm volatile ( insn "%U1%X1 %0,%1" : "=r"(ret) : "m<>"(*addr) ); \ > > As I think I had mentioned before, asm() contraints want a blank between > closing quote and opend paren. I.e. like this > > asm volatile ( insn "%U1%X1 %0,%1" : "=r" (ret) : "m<>" (*addr) ); > My mistake, I went through and hand-formatted all of this code to try to be inline with Xen's style but forgot about the constraints. As an aside, I don't suppose there is an automatic formatter somewhere that I've missed? I found an old clang-format fork that claims to add support for Xen's formatting[1] but it seems to only handle a subset of Xen's rules so I haven't found it very useful. [1] https://github.com/NastyaVicodin/llvm-project/commits/main >> +#define read_atomic(p) \ >> + ({ \ >> + union { \ >> + typeof(*(p)) val; \ >> + char c[0]; \ >> + } x_; \ >> + read_atomic_size(p, x_.c, sizeof(*(p))); \ >> + x_.val; \ >> + }) >> + >> +#define write_atomic(p, x) \ >> + do \ >> + { \ >> + typeof(*(p)) x_ = (x); \ >> + write_atomic_size(p, &x_, sizeof(*(p))); \ >> + } while ( 0 ) > > Up to here you use underscore-suffixed locals, but then ... > >> +#define add_sized(p, x) \ >> + ({ \ >> + typeof(*(p)) __x = (x); \ > > ... you have even two prefixing underscores here. > The definitions of these macros were directly copied from elsewhere in Xen (x86 and arm). I can change them all to use underscore-suffixed local naming here, though. >> + switch ( sizeof(*(p)) ) \ >> + { \ >> + case 1: \ >> + add_u8_sized((uint8_t *) (p), __x); \ >> + break; \ >> + case 2: \ >> + add_u16_sized((uint16_t *) (p), __x); \ >> + break; \ >> + case 4: \ >> + add_u32_sized((uint32_t *) (p), __x); \ >> + break; \ >> + default: \ >> + __bad_atomic_size(); \ >> + break; \ >> + } \ >> + }) >> + >> +static inline void atomic_add(int a, atomic_t *v) >> +{ >> + int t; >> + >> + asm volatile ( "1: lwarx %0,0,%3\n" >> + "add %0,%2,%0\n" >> + "stwcx. %0,0,%3\n" >> + "bne- 1b" >> + : "=&r"(t), "=m"(v->counter) >> + : "r"(a), "r"(&v->counter), "m"(v->counter) : "cc" ); > > "+m" and then drop the last input? > Yes, that makes sense. Not sure why it was originally written that way but I'll change it. >> +static inline int atomic_dec_if_positive(atomic_t *v) >> +{ >> + int t; >> + >> + asm volatile(PPC_ATOMIC_ENTRY_BARRIER >> + "1: lwarx %0,0,%1 # atomic_dec_if_positive\n" >> + "addic. %0,%0,-1\n" >> + "blt- 2f\n" >> + "stwcx. %0,0,%1\n" >> + "bne- 1b\n" >> + PPC_ATOMIC_EXIT_BARRIER >> + "2:" : "=&r"(t) >> + : "r"(&v->counter) : "cc", "memory"); > > Missing blanks near the parentheses. Would also be nice if the padding > blanks actually vertically aligned the operands. I tried to make the spacing uniform across all asm blocks in this file, but the convention I used was just a single space between the mnemonic and the operands. I seemed to have missed this one though, so I'll bring it in line with the others. >> + return t; >> +} >> + >> +static inline atomic_t atomic_compareandswap(atomic_t old, atomic_t new, >> + atomic_t *v) >> +{ >> + atomic_t rc; >> + rc.counter = __cmpxchg(&v->counter, old.counter, new.counter, sizeof(int)); >> + return rc; >> +} >> + >> +#define arch_cmpxchg(ptr, o, n) \ >> + ({ \ >> + __typeof__(*(ptr)) _o_ = (o); \ >> + __typeof__(*(ptr)) _n_ = (n); \ > > Problematic leading underscores again. > Will fix. >> + (__typeof__(*(ptr))) __cmpxchg((ptr), (unsigned long) _o_, \ >> + (unsigned long) _n_, sizeof(*(ptr))); \ >> + }) >> + >> +static inline int atomic_cmpxchg(atomic_t *v, int old, int new) >> +{ >> + return arch_cmpxchg(&v->counter, old, new); >> +} >> + >> +#define ATOMIC_OP(op, insn, suffix, sign) \ >> + static inline void atomic_##op(int a, atomic_t *v) \ >> + { \ >> + int t; \ >> + asm volatile ( "1: lwarx %0,0,%3\n" \ >> + insn "%I2" suffix " %0,%0,%2\n" \ >> + "stwcx. %0,0,%3 \n" \ >> + "bne- 1b\n" \ >> + : "=&r"(t), "+m"(v->counter) \ >> + : "r" #sign(a), "r"(&v->counter) \ >> + : "cc" ); \ >> + } >> + >> +ATOMIC_OP(and, "and", ".", K) >> + >> +static inline int atomic_sub_and_test(int i, atomic_t *v) >> +{ >> + return atomic_sub_return(i, v) == 0; >> +} >> + >> +static inline int atomic_inc_and_test(atomic_t *v) >> +{ >> + return atomic_add_return(1, v) == 0; >> +} >> + >> +static inline int atomic_dec_and_test(atomic_t *v) >> +{ >> + return atomic_sub_return(1, v) == 0; >> +} >> + >> +static inline int atomic_add_negative(int i, atomic_t *v) >> +{ >> + return atomic_add_return(i, v) < 0; >> +} >> + >> +static inline int __atomic_add_unless(atomic_t *v, int a, int u) >> +{ >> + int c, old; >> + >> + c = atomic_read(v); >> + while (c != u && (old = atomic_cmpxchg((v), c, c + a)) != c) > > Btw, no real need to parenthesize v in cases like this one. Otoh a needs > parenthesizing. FWIW this was copied directly from arm64/atomic.h, but seeing as its a normal function and not a macro I'm not sure I see why `a` would need parenthesis. I'll drop the ones around `v` though. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Tue Aug 08 19:52:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 19:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580404.908593 (Exim 4.92) (envelope-from ) id 1qTSkc-0008Ob-IV; Tue, 08 Aug 2023 19:52:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580404.908593; Tue, 08 Aug 2023 19:52:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTSkc-0008OU-G2; Tue, 08 Aug 2023 19:52:18 +0000 Received: by outflank-mailman (input) for mailman id 580404; Tue, 08 Aug 2023 19:52:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTSkb-0008OO-Ll for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 19:52:17 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1334efdb-3625-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 21:52:16 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 4E0718285285; Tue, 8 Aug 2023 14:52:15 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SG_fbO8XG_c0; Tue, 8 Aug 2023 14:52:14 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 8E136828593C; Tue, 8 Aug 2023 14:52:14 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Er11vF-l5oIy; Tue, 8 Aug 2023 14:52:14 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 1E61D8285285; Tue, 8 Aug 2023 14:52:14 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1334efdb-3625-11ee-b280-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 8E136828593C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691524334; bh=S74nCpp+zbs+6j1cN313tLRIw0grqHtroJIyEPXUZkU=; h=Message-ID:Date:MIME-Version:To:From; b=D/57Npe3f6jh3mhIXThO//OUVtk25ZMWnd02FuI1wtuz7tmOyj8gyf7YSKwqHHvyU Ag/ba1TLcdl0m6v37ZLdwwdtcLanFjfVJmyzG7jte80I55GZFXvCvA7kmp24m2wcEw EsB7fzEfF885cgVtVga3UPXA6KklPzjqUBTXmMJo= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: Date: Tue, 8 Aug 2023 14:52:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/9] xen/ppc: Implement bitops.h Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <63b89c627948015cc9a1c1e5d1775ee9e41508ba.1691016993.git.sanastasio@raptorengineering.com> <61ca4a1d-2589-5794-5560-db60e10a7f15@suse.com> From: Shawn Anastasio In-Reply-To: <61ca4a1d-2589-5794-5560-db60e10a7f15@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/8/23 3:36 AM, Jan Beulich wrote: > On 03.08.2023 01:03, Shawn Anastasio wrote: >> Implement bitops.h, based on Linux's implementation as of commit >> 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc > > But with PPC32 bits dropped afaics, and with leading hard tabs replaced > by four spaces - which in turn appears to yield some unhelpful placement > of line-continuing backslashes. And with some > asm-generic/bitops/builtin-*.h expanded. Please mention all adjustments > you made, to allow for some future importing of updates to go as > smoothly as possible. Yes, that is all correct. Additionally, the code was adapted to use 32-bit words for bitmap entries like the rest of Xen's architectures do instead of the 64-bit longs used by the Linux implementation. I provided the reference to the Linux commit for completeness' sake, but to be clear, my changes have caused it to diverge enough where I wouldn't expect direct imports from Linux to be (conveniently) possible. I'll clarify this in the commit message and also fix the macro line-continuing backslash spacing. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Tue Aug 08 19:54:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 19:54:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580409.908604 (Exim 4.92) (envelope-from ) id 1qTSmN-0000Wf-To; Tue, 08 Aug 2023 19:54:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580409.908604; Tue, 08 Aug 2023 19:54:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTSmN-0000WY-Qv; Tue, 08 Aug 2023 19:54:07 +0000 Received: by outflank-mailman (input) for mailman id 580409; Tue, 08 Aug 2023 19:54:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTSmM-0000WS-7p for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 19:54:06 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52fcd48e-3625-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 21:54:04 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691524439090360.089032463114; Tue, 8 Aug 2023 12:53:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52fcd48e-3625-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691524440; cv=none; d=zohomail.com; s=zohoarc; b=OSRsXbbEZoXLkhFyYOoWxl1EkyA0chm2kkoBnLzViYFyN73Codh5pub56Gek2XfZ/lTe8U+hKPh2TnASxvLMiSjmF4LBOXum/k6jrRoJeySdoXhVeVGI/GPIt1d+c5UxTYutOVWbhHyVgZfB1xw7RNHd37uFs4N8L6y9cqZjhsU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691524440; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DmZPxTSfNhc0mZHMD+7OFVxhiA+rfHCfTf2zgwRrq7M=; b=dAqToByapNa/zpK3lpbUmx+jNPvKKpXu7tvNSqwbqmsGV16VVNiO8U9atfxpBETJmaKjGPiEgjedTO9fGD5LXyOpo4hBuBM9gpVw8Bm8axWyh174COptFTu/ASQg3Y9vcuKXGaEG59mGOjd1IWUZw5/eJ/G5yslsY88tzGYLhVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691524440; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=DmZPxTSfNhc0mZHMD+7OFVxhiA+rfHCfTf2zgwRrq7M=; b=JWOj4FFIgOSdp9I0u0stIOt89U+BY0WiKkIRp68S7W6LPSijR4hJEpWSF4nia+EE tdJ9IgT6O3EXuZ/IvmjRZAonbl4mL6ZdDuEsCedbvu5Bo0zMjSDAKGpvb2fbyf8RLzg FRq/3sZHH9vfncE4mdy6mUoicMrZD13ZTzbbISrY= Message-ID: Date: Tue, 8 Aug 2023 15:53:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: Stefano Stabellini Cc: Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 20:09, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Stefano Stabellini wrote: >> On Thu, 3 Aug 2023, Daniel P. Smith wrote: >>>> Also, what is the plan for the existing dom0less dt properties? >>>> Will they need to be moved to new /hypervisor node or we will have to parse >>>> both /chosen and /hypervisor nodes? >>> >>> In the proposal I sent to xen-devel in response to Luca's RFC for rebranding >>> dom0less features under hyperlaunch, that is the purpose of this commit. Get >>> this document up to date with what was done in v1 along with what we are >>> planning/working on for hyperlaunch. One could think of this as effectively >>> the API to the capabilities hyperlaunch will provide. Not just how to >>> construct a domain, but what kinds of domains can be constructed by >>> hyperlaunch. Step one of the proposal is to publish a patch upon which we all >>> can iterate over and get to an agreement on a suitable interface for all. The >>> next step would be the introduction of hyperlaunch dom0less compatibility >>> mode, that would see the moving of the parsing logic for the existing dom0less >>> nodes under /xen/common/domain-builder. It would continue to exist there even >>> after hyperlaunch proper is merged and can remain there for backward >>> compatibility until there is a decision to retire the compatibility interface. >> >> I like this plan. The two interfaces are so similar that it is basically >> one interface with a couple of tiny differences. >> >> So I expect we would move the existing dom0less parsing code to common/, >> add a couple of extensions (such as parsing /hypervisor in addition to >> /chosen) and use it as it. >> >> Later on, after a few years of using /hypervisor instead of /chosen, if >> nobody is using /chosen anymore, we could retire /chosen completely. But >> this is just one DT node/property that gets retired (there are a couple >> of others). I don't imagine we'll have a full new implementation of the >> DT parsing logic that supersedes the existing implementation of it >> (especially considering the difficulty of maintaining 2 different parsing >> logics in the hypervisor for similar interfaces). >> >> Same thing for the DT interface documentation. I don't think we need two >> DT interface docs? We could start with the existing dom0less interface >> (docs/misc/arm/device-tree/booting.txt), and move it somewhere common >> like docs/misc/device-tree. >> >> Then add any changes or extensions required by other architecture, such >> as x86 and RISC-V. >> >> For sure for x86 we need "module-index". I don't know if anything else >> is must-have to get it to work on x86 but if there is, we should add >> those too. > > > For clarity, I think we should definitely have > docs/design/launch/hyperlaunch.rst, and maybe we should also have > hyperlaunch-devicetree.rst as an overview description and user guide. > That's useful. > > But in terms of official device tree bindings interface description > (basically what in Linux would go under > Documentation/devicetree/bindings/), I think it would be best to only > have a single document. The current one is > docs/misc/arm/device-tree/booting.txt. Does the proposal to your first message align with your follow-up here? v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 20:15:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 20:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580417.908614 (Exim 4.92) (envelope-from ) id 1qTT70-0003H5-MW; Tue, 08 Aug 2023 20:15:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580417.908614; Tue, 08 Aug 2023 20:15:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTT70-0003Gy-Ib; Tue, 08 Aug 2023 20:15:26 +0000 Received: by outflank-mailman (input) for mailman id 580417; Tue, 08 Aug 2023 20:15:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTT6y-0003Gs-Ot for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 20:15:24 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4cde2426-3628-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 22:15:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DE2A618C5; Tue, 8 Aug 2023 20:15:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93401C433C7; Tue, 8 Aug 2023 20:15:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cde2426-3628-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691525719; bh=DzLqUjHIokBCqXIWi41GI1OSvOB+/1CmJeF1xpqRA1o=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mHjFWk9kEWjBv0s7LnAjrn3S+o24epM9JdKOgT4GNrfjJu+UoKvHh8jhYkE8HkMJ2 rH1ePgfidumnwmdkeHfhquXihP4G9+LATeRgXhdU44LaN9lTywqNLJJx0LHNET167b ycCoBju7Y7ZAADzHmNlllw4n55+sCYMLi72cKpYGCQDXQkXBMvygLcLIGAjBcWf48h uuwYfuGKfvf5fOd6gso5mL7dXdbm9iHhiw/n+4DH4bB5+yoPpYGVR3eA26/Gso3QxZ 5B+Ar7INTGWJpvqWApNGAOKLJlv0dEaOG+HSawRwM/ws7K+pkHGpFIhkbSurvTp1E3 fsEtIIX3QBj1Q== Date: Tue, 8 Aug 2023 13:15:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , xen-devel@lists.xenproject.org, consulting@bugseng.com, Alexandru Isaila , Petre Pircalabu , federico.serafini@bugseng.com, tamas@tklengyel.com, george.dunlap@cloud.com Subject: Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration In-Reply-To: <4722cb01-2e0a-6a12-b398-0ddd024b50bd@suse.com> Message-ID: References: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com> <4722cb01-2e0a-6a12-b398-0ddd024b50bd@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1365989943-1691525642=:2127516" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1365989943-1691525642=:2127516 Content-Type: text/plain; CHARSET=US-ASCII Content-ID: On Tue, 8 Aug 2023, Jan Beulich wrote: > On 04.08.2023 23:39, Stefano Stabellini wrote: > > Hi Tamas, > > > > May I have your ack on this change? > > I see you committed this, and there is an ack in the commit, but I can't > see any ack on list (incl when checking mail archives, to exclude an > issue with my mailbox). That is strange! Something appears to be wrong with xen-devel. Adding George in CC and attaching Tamas' reply. > > On Thu, 27 Jul 2023, Federico Serafini wrote: > >> Change parameter name in monitor_domctl() declaration for > >> consistency with the corresponding definition. > >> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations > >> of an object or function shall use the same names and type qualifiers". > >> > >> No functional changes. > >> > >> Signed-off-by: Federico Serafini > > > > Reviewed-by: Stefano Stabellini > > > > > >> --- > >> xen/include/xen/monitor.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h > >> index 6b17a93071..713d54f7c1 100644 > >> --- a/xen/include/xen/monitor.h > >> +++ b/xen/include/xen/monitor.h > >> @@ -27,7 +27,7 @@ > >> struct domain; > >> struct xen_domctl_monitor_op; > >> > >> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op); > >> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop); > >> void monitor_guest_request(void); > >> > >> int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req); > >> -- > >> 2.34.1 > >> > >> > > > --8323329-1365989943-1691525642=:2127516 Content-Type: message/rfc822; NAME=tamas.eml Content-Transfer-Encoding: BINARY Content-ID: Content-Description: Content-Disposition: ATTACHMENT; FILENAME=tamas.eml >From tamas@tklengyel.com Sat Aug 5 04:06:33 2023 Return-Path: Delivered-To: stefano-oss@posteo.net Received: from posteo.de [185.67.36.169] by ubuntu-linux-20-04-desktop with IMAP (fetchmail-6.4.2) for (single-drop); Sat, 05 Aug 2023 04:06:33 -0700 (PDT) Received: from proxy02.posteo.name ([127.0.0.1]) by dovecot15.posteo.name (Dovecot) with LMTP id OD0XKygrzmTfMAIAB3Nl4w for ; Sat, 05 Aug 2023 13:06:14 +0200 Received: from proxy02.posteo.de ([127.0.0.1]) by proxy02.posteo.name (Dovecot) with LMTP id fqefNzspzmTX4QAAGFAyLg ; Sat, 05 Aug 2023 13:06:14 +0200 Received: from mailin02.posteo.de (unknown [10.0.0.62]) by proxy02.posteo.de (Postfix) with ESMTPS id 4RJ0BL2G6Jz12M6 for ; Sat, 5 Aug 2023 13:06:02 +0200 (CEST) Received: from mx01.posteo.de (mailin02.posteo.de [127.0.0.1]) by mailin02.posteo.de (Postfix) with ESMTPS id 3ED26216E2 for ; Sat, 5 Aug 2023 13:06:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at posteo.de X-Spam-Flag: NO X-Spam-Score: -4.75 X-Spam-Level: X-Spam-Status: No, score=-4.75 tagged_above=-1000 required=5 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, T_POSTEO_TLSINY=0.01, T_RCVD_IN_ABUSIX_WHITE=-0.01] autolearn=disabled X-Posteo-Antispam-Signature: v=1; e=base64; a=aes-256-gcm; d=p4jeoLx8GSVfXysvUQMETnPVZwsS1NCfRrCQ+OIfXMVkjhIZ6cJqJzQ2xsxWawG5B4emcNKFyaO0uF37H3jKNhljpy3WUd4kJSdvfddciH4VZJrlRmkPTO3n77X06CxEC2ZK2K7g Authentication-Results: posteo.de; dmarc=none (p=none dis=none) header.from=tklengyel.com Authentication-Results: posteo.de; spf=pass smtp.mailfrom=kernel.org Authentication-Results: posteo.de; dkim=pass (2048-bit key) header.d=tklengyel.com header.i=@tklengyel.com header.b=NZXhVc+1; dkim-atps=neutral X-Posteo-TLS-Received-Status: TLSv1.3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx01.posteo.de (Postfix) with ESMTPS id 4RJ0BK3q2Lz11g3 for ; Sat, 5 Aug 2023 13:06:01 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 748A3601D0 for ; Sat, 5 Aug 2023 11:06:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id E997BC433C9; Sat, 5 Aug 2023 11:05:59 +0000 (UTC) Delivered-To: sstabellini@kernel.org Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 348A5C433C8 for ; Sat, 5 Aug 2023 11:05:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 348A5C433C8 Authentication-Results: smtp.kernel.org; dmarc=none (p=none dis=none) header.from=tklengyel.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=tklengyel.com DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com; q=dns/txt; s=mailo; t=1691233557; x=1691240757; h=Content-Type: Cc: To: To: Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References: MIME-Version: Sender: Sender; bh=XEy1vcTg986vcuRn0cPfqtUGQoVn71aO6yXWNPsDcxk=; b=NZXhVc+1LvgtFz3pZo5eY/1oI+bvlQ3bB+A78sFqnfnLDKJHOLEuyKq99mzA6xhCmle23OzwhRXlfjR0LhB5pn4eVXXoV+/SIXHrUd4/yX/JPwvz03PB7MiA4ori9XJ88+EjC4BEJaniSPsz3G3hc0L/niZXBBzOJZXVCwR5K+cwaW4TECmqvXDAdvOiTkyfmU9df3JW7qSdw6+0SbtvQcTI06VFiROAHiBn2TGDwSzxYtEA43P3JHEw2zvukbN+VqO8dj6dDMAVtyYPimJ79CPesn6HYDDmsR0kTptCyFBgHLT7Gm2rFb1qoh1feNUtlH6rw4kZnH21KTHw7io5ZQ== X-Mailgun-Sending-Ip: 198.61.254.35 X-Mailgun-Sid: WyI2MzhkZCIsInNzdGFiZWxsaW5pQGtlcm5lbC5vcmciLCJjZDg0MCJd Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by aba04b98da0a with SMTP id 64ce2d1544e01654935e5a3b (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Sat, 05 Aug 2023 11:05:57 GMT Sender: tamas@tklengyel.com Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-586a3159588so25627287b3.0 for ; Sat, 05 Aug 2023 04:05:57 -0700 (PDT) X-Gm-Message-State: AOJu0YziM/EzIuEAzcUpHfY7hNhb9pGl+eZvYLzSfl2n7nkjDlH48XUp 6O8gexWJG+sWR/f3n9EugmCpOnFYliZVhHKlcr4= X-Google-Smtp-Source: AGHT+IHeaTodq61jc8nt4YGs/RkXrtsDT5KZst1gZHUjz80gQXJivp4tUcqwXUIDc+OnFE93Mhgqw4csAoe7ZxG3rV0= X-Received: by 2002:a81:6c45:0:b0:586:9384:ffd7 with SMTP id h66-20020a816c45000000b005869384ffd7mr2473174ywc.9.1691233556109; Sat, 05 Aug 2023 04:05:56 -0700 (PDT) MIME-Version: 1.0 References: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com> In-Reply-To: From: Tamas K Lengyel Date: Sat, 5 Aug 2023 13:05:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration To: Stefano Stabellini Cc: Xen-devel , consulting@bugseng.com, Alexandru Isaila , Petre Pircalabu , Federico Serafini Content-Type: multipart/alternative; boundary="0000000000005822c306022aff56"


On Fri, Aug 4, 2023, 11:39 PM Stefano Stabellini <sstabellini@kernel.org> wrote:
Hi Tamas,

May I have your ack on this change?


On Thu, 27 Jul 2023, Federico Serafini wrote:
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> of an object or function shall use the same names and type qualifiers".
>
> No functional changes.
>
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Tamas K Lengyel <tamas@tklengyel.com>
--8323329-1365989943-1691525642=:2127516-- From xen-devel-bounces@lists.xenproject.org Tue Aug 08 20:48:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 20:48:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580433.908627 (Exim 4.92) (envelope-from ) id 1qTTcz-0006tl-5n; Tue, 08 Aug 2023 20:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580433.908627; Tue, 08 Aug 2023 20:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTcz-0006te-3E; Tue, 08 Aug 2023 20:48:29 +0000 Received: by outflank-mailman (input) for mailman id 580433; Tue, 08 Aug 2023 20:48:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTcx-0006tY-SO for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 20:48:27 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ead8b7a2-362c-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 22:48:25 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8AF4D62CB8; Tue, 8 Aug 2023 20:48:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8CC7C433C7; Tue, 8 Aug 2023 20:48:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ead8b7a2-362c-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691527702; bh=FYbbd7qQVQZaGqd4d1CTFtThoJ1+SUu0wdRwt+YrOEQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=T+/6gZNHu+vSZpj3zJrywt3/r4buvzTZKcG7iUEqeRTB9fmnbH2lXAhN2RoX9f3So BcBsQCxu4TVMTg9419/BOjpk8U7S3qSL4jH+R4mW8jKraqb6nRIRuNmdKmnMzZfYkS YdNi4luudmOgoAwfqqHVP8p7/dgPekO1QNOB6hCM7npDTuxLhF0kfb6SMWQHu8f40v hZFqOe3tB+7EmH2xuR71/TSP0Y9i1rxAV2iSCPO5hSrnwJSnzYxoWriu0B9J7QA8rg iWOH3QCfY9pTJMOjNbcizFb4gWbfdvR93NUFlXESjj1+n/Ub8qLPXyiX7BEGr+MsEg OlojuKeOWIQew== Date: Tue, 8 Aug 2023 13:48:19 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Jan Beulich , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio , Tamas K Lengyel Subject: Re: [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Luca Fancellu wrote: > > On 8 Aug 2023, at 13:02, Jan Beulich wrote: > > > > When !MEM_SHARING no useful output is produced. Move the function into > > mm/mem_sharing.c while conditionalizing the call to it, thus allowing to > > drop it altogether from Arm (and eliminating the need to introduce stubs > > on PPC and RISC-V). > > > > Signed-off-by: Jan Beulich > > --- > > I wasn't really sure whether introducing a stub in xen/mm.h would be any > > better than adding the (further) #ifdef to dump_domains(). > > > > We could go further and also eliminate the need for the stub variants > > of mem_sharing_get_nr_{shared,saved}_mfns() by moving the > > XENMEM_get_sharing_{shared,freed}_pages cases in > > {,compat_}arch_memory_op() into the already existing #ifdef-s there. > > Returning an error for those sub-ops may be slightly more appropriate > > than returning 0 when !MEM_SHARING. > > > > --- a/xen/arch/arm/mm.c > > +++ b/xen/arch/arm/mm.c > > @@ -1297,10 +1297,6 @@ void free_init_memory(void) > > printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10); > > } > > > > -void arch_dump_shared_mem_info(void) > > -{ > > -} > > - > > Hi Jan, > > For the arm part: > > Reviewed-by: Luca Fancellu #arm Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Tue Aug 08 20:49:22 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 20:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580437.908638 (Exim 4.92) (envelope-from ) id 1qTTdq-0007OY-Ej; Tue, 08 Aug 2023 20:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580437.908638; Tue, 08 Aug 2023 20:49:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTdq-0007OP-C2; Tue, 08 Aug 2023 20:49:22 +0000 Received: by outflank-mailman (input) for mailman id 580437; Tue, 08 Aug 2023 20:49:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTdp-0007Ln-I7 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 20:49:21 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0aa53b01-362d-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 22:49:19 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691527754532158.44535830733014; Tue, 8 Aug 2023 13:49:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aa53b01-362d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691527755; cv=none; d=zohomail.com; s=zohoarc; b=KY/s9YNKZ1aTKvo1EedCM+0ctLQxGveKJIHTVRzf0hIboO6dS39ezOOSu/9bbKhge5DmYYvroBDxQgf+TrhEqAv9fcmvEHjxQtQv/uFeGm9/UWAlsz0PYTX3TEwRdlLwVdXCCOcqkws0s/3FK0eHsiYODULc+GEoeLWHVRQQwf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691527755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/w/Am2MySHbgAw5P6JWjiaZULfNc48wFcVVLbQ8Y9YE=; b=oE2WhI2WZUzZSYfHsGwTpum4wX0zuUrHt5baBLLSCGhItvVEMoDqH+5YBDogA87HxEl5y8aFi9lqcWTkRI1kftVZ6ul4daGerJmvDkfd4xtQcduXAw12YnBmuvEEnkluVF3UR9B0cXSDJ4ASHVfNLz+ZQZi6YdJ5wkY06M3iGW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691527755; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=/w/Am2MySHbgAw5P6JWjiaZULfNc48wFcVVLbQ8Y9YE=; b=AX32es/gDFgK+jw8qczNeHL3bcSOIezkDHseY3xF1gmbglwh1UAJ1uye6ePoA3pj JklQVTVhEdYsXQxnH8AYSSqkqbSf7l2UEfN3jSzq1CifwY2v+7Klo8YHRsnEudwwTw7 2SqUxgroZJu+dlAPxNyNi4MInhCn4E0o9Y7YJrmY= Message-ID: <76249714-6d1d-a2ad-cfe5-d7eae0ce3a1b@apertussolutions.com> Date: Tue, 8 Aug 2023 16:49:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <3ddab6ee-54fc-49a0-8f14-79ca258d04af@xen.org> From: "Daniel P. Smith" In-Reply-To: <3ddab6ee-54fc-49a0-8f14-79ca258d04af@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/4/23 05:03, Julien Grall wrote: > Hi Daniel, > > On 03/08/2023 11:44, Daniel P. Smith wrote: >> +compatible >> +  Identifies which hypervisors the configuration is compatible. >> Required. >> -    hypervisor { >> -        compatible = “hypervisor,xen†>> +  Format: "hypervisor,", e.g "hypervisor,xen" > > I read "e.g" as "for example". You don't explicitely say which > compatible will be supported by Xen, so one could write "hypervisor,foo" > and expect to work. > > Also, it is not fully clear why you need both the hypervisor and each > domain node to have a compatible with the hypervisor name in it. Ack, it should be explicit to what is expected for a Xen configuration. As for compatible on the domain node, I think that was from being overly cautious, it can be dropped. This did get me reflecting that the compatibility was added there as there was some initial participation in standardization efforts going on at the time. I am not sure what has come of those, but the question it raised is that domain is a Xen specific term, whereas generally vm is accepted as the generic term. Maybe this node needs renaming? >> +compatible >> +  Identifies the hypervisor the confiugration is intended. Required. > > Also typo: s/confiugration/configuration/ Ack. >> -The modules that would be supplied when using the above config would be: >> +  Format: ",config", e.g "xen,config" >> -* (the above config, compiled into hardware tree) >> -* CPU microcode >> -* XSM policy >> -* kernel for boot domain >> -* ramdisk for boot domain >> -* boot domain configuration file >> -* kernel for the classic dom0 domain >> -* ramdisk for the classic dom0 domain >> +bootargs >> +  This is used to provide the boot params for Xen. > > How is this different from the command line parameter chosen? And if you > want to keep both, what is the expected priority if a user provides both? A DT file for x86, there is only a need to provide the hypervisor node, for which we already needed a hypervisor config section to describe XSM policy and microcode, at this point at least. It was decided in an effort to provide flexibility, the ability to specify command line parameters to the hypervisor in DT config. It is expected these parameters would function as a base parameters that would be overridden by those provided via the multiboot kernel entry. Now as you point out for Arm, this becomes a bit redundant, to a degree, as the Xen command line is already under the /chosen node. But even here it would be beneficial, as a hyperlaunch configuration could be distributed consisting of a dtb that has core parameters set with base values along with a set of kernels and ramdisks. At boot, the hyperlaunch dtb could then be concatenated with the device specific dtb. >> -The hypervisor device tree would be compiled into the hardware device >> tree and >> -provided to Xen using the standard method currently in use. The >> remaining >> -modules would need to be loaded in the respective addresses specified >> in the >> -`module-addr` property. >> +  Format: String, e.g. "flask=silo" >> +Child Nodes >> +""""""""""" >> -The Hypervisor node >> -------------------- >> +* module >> -The hypervisor node is a top level container for the domains that >> will be built >> -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` >> -property is used to identify the type of hypervisor node present.. >> +Domain Node >> +----------- >> -compatible >> -  Identifies the type of node. Required. >> +A ``domain`` node is for describing the construction of a domain. >> Since there >> +may be one or more domain nodes, each one requires a unique, DTB >> compliant name >> +and a ``compatible`` property to identify as a domain node. >> -The Config node >> ---------------- >> +A ``domain`` node  may provide a ``domid`` property which will be >> used as the >> +requested domain id for the domain with a value of “0†signifying to >> use the >> +next available domain id, which is the default behavior if omitted. >> It should >> +be noted that a domain configuration is not able to request a domid >> of “0†> > Why do you need this restriction? And more importantly how would you > describe dom0 in hyperlaunch? I would start by saying one of the goals/purposes behind hyperlaunch is to remove the binding that "dom0" is identified by having domid 0. That is what the roles patch recently submitted is working to achieve. "Dom0" is a role in the system, which I tried calling the "unbounded role" but that seems to have caused some confusion. That aside, IMHO because of the legacy around domid 0, I don't think it should be assignable through hyperlaunch. Additionally, there should be an identifier that signifies auto-assign the domid and that value should not conflict/limit what domids are usable by the hypervisor. Given we should not be assigning domid 0 through this interface, it makes it the perfect candidate value. >> +Beyond that, a domain node may have any of the following optional >> properties. >> -A config node is for detailing any modules that are of interest to >> Xen itself. >> -For example this would be where Xen would be informed of microcode or >> XSM >> -policy locations. If the modules are multiboot modules and are able >> to be >> -located by index within the module chain, the ``mb-index`` property >> should be >> -used to specify the index in the multiboot module chain.. If the >> module will be >> -located by physical memory address, then the ``module-addr`` property >> should be >> -used to identify the location and size of the module. >> +Properties >> +"""""""""" >>   compatible >> -  Identifies the type of node. Required. >> - >> -The Domain node >> ---------------- >> +  Identifies the node as a domain node and for which hypervisor. >> Required. >> -A domain node is for describing the construction of a domain. It may >> provide a >> -domid property which will be used as the requested domain id for the >> domain >> -with a value of “0†signifying to use the next available domain id, >> which is >> -the default behavior if omitted. A domain configuration is not able >> to request >> -a domid of “0â€. After that a domain node may have any of the following >> -parameters, >> - >> -compatible >> -  Identifies the type of node. Required. >> +  Format: ",domain", e.g "xen,domain" >>   domid >> -  Identifies the domid requested to assign to the domain. Required. >> +  Identifies the domid requested to assign to the domain. >> -permissions >> +  Format: Integer, e.g <0> >> + >> +role >>     This sets what Discretionary Access Control permissions >>     a domain is assigned. Optional, default is none. >> -functions >> -  This identifies what system functions a domain will fulfill. >> +  Format: Bitfield, e.g <3> or <0x00000003> >> + >> +          ROLE_NONE                (0) >> +          ROLE_UNBOUNDED_DOMAIN    (1U<<0) >> +          ROLE_CONTROL_DOMAIN      (1U<<1) >> +          ROLE_HARDWARE_DOMAIN     (1U<<2) >> +          ROLE_XENSTORE_DOMAIN     (1U<<3) > > Please describe what each roles are meant for. Agreed, but this obviously is in flux based on the current review of the roles patch. >> + >> +capability >> +  This identifies what system capabilities a domain may have beyond >> the role it >> +  was assigned. >>     Optional, the default is none. >> -.. note::  The `functions` bits that have been selected to indicate >> -   ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last >> two bits >> -   (30, 31) such that should these features ever be fully retired, >> the flags may >> -   be dropped without leaving a gap in the flag set. >> +  Format: Bitfield, e.g <3221225487> or <0xC0000007> > > I thik we should favor the hexadecimal version because this will be > somewhat easier to read. I too favor the hex version, but as I recall, DT/libfdt doesn't care/enforce. > Also, the Device-Tree values work in term of 32-bit cell. Also, how do > you plan to handle the case where you have more than 32 capabilities? I would add a capabalities2 field, this is how SELinux/Flask handle the same problem. >> + >> +          CAP_NONE            (0) >> +          CAP_CONSOLE_IO      (1U<<0) > > Please describe the capabilities. Agreed and again, will change based on final version of roles patch. >>   mode >>     The mode the domain will be executed under. Required. >> +  Format: Bitfield, e.g <5> or <0x00000005> >> + >> +          MODE_PARAVIRTUALIZED     (1 << 0) PV | PVH/HVM >> +          MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH >> +          MODE_LONG                (1 << 2) 64 BIT | 32 BIT >> + >>   domain-uuid >>     A globally unique identifier for the domain. Optional, >>     the default is NULL. >> +  Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] >> + >>   cpus >>     The number of vCPUs to be assigned to the domain. Optional, >>     the default is “1â€. >> +  Format: Integer, e.g <0> > > This is odd to suggest to give '0' as an example. Wouldn't Xen throw an > error if a user provide it? Good catch, though I am now thinking individual examples are not needed and the full example below should be sufficient. >> + >>   memory >> -  The amount of memory to assign to the domain, in KBs. >> +  The amount of memory to assign to the domain, in KBs. This field >> uses a DTB >> +  Reg which contains a start and size. For memory allocation start >> may or may >> +  not have significance but size will always be used for the amount >> of memory >>     Required. > > The description doesn't match... Ack, others caught that as well. Will be fixed. >> +  Format: String  min: | max: | , e.g. "256M" > > ... the format. But strings are difficult to parse. If you want to > provide 3 different values (possibly optional), then it would be best to > have 3 different properties. That format comes from the command line dom0 memory parameter, in the hyperlaunch series I reused that existing parser that I am fairly confident will be maintained. > I will continue to review the rest later. Great, thank you so much for your feedback thus far. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 20:53:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 20:53:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580446.908648 (Exim 4.92) (envelope-from ) id 1qTThS-0000W5-27; Tue, 08 Aug 2023 20:53:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580446.908648; Tue, 08 Aug 2023 20:53:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTThR-0000Vy-Uh; Tue, 08 Aug 2023 20:53:05 +0000 Received: by outflank-mailman (input) for mailman id 580446; Tue, 08 Aug 2023 20:53:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTThQ-0000Vs-N4 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 20:53:04 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 902b6581-362d-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 22:53:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4D3E62CCB; Tue, 8 Aug 2023 20:53:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E3EDC433C8; Tue, 8 Aug 2023 20:52:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 902b6581-362d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691527980; bh=s7MCFjn0aQjiYEMHaJP2WcHXORAVkz3Wx2uB9R7Ygyk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tFLGQoCXHQ5swCVhIkHOhrUesIEsGMRbsLZhlAlnLTV8LWRqj3RSUrD6DNCbQ4q56 JLT/M5NIoNfg2r3uZ75OgkCb8hQRqmFI1uL2U0fEidfFq3/EOhPXbgBpc3Ai8hbFyK yoREamgbnmIwenOiKoTcCliAeafSAZhdRYvrWsMyu1ea9NeyuwZ49cKnqcsrvHf7qR fYYlkXvWcvzA6E8F+gQle+AWibFI49bQXEbJVbYOjcytrwxOmjYvJxxgfn2W9eLS4l W/GyauP12E82MEWGOxrCA2h4HFAxRxl5G8W3EAsDBt5j6DXK1giSyyO9cp1zXQVrMy V+Adlzyid+skA== Date: Tue, 8 Aug 2023 13:52:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Michal Orzel , Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm64: head: Introduce a helper to flush local TLBs In-Reply-To: <416EFCDE-063D-416D-AEC4-8EA15BE0396C@arm.com> Message-ID: References: <20230808110739.1296-1-michal.orzel@amd.com> <416EFCDE-063D-416D-AEC4-8EA15BE0396C@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Luca Fancellu wrote: > > On 8 Aug 2023, at 12:07, Michal Orzel wrote: > > > > Instead of repeating the same sequence of instructions to flush the TLBs > > in various places, introduce a macro flush_xen_tlb_local and make use of > > it. This is similar to what was done for arm32 by the commit: > > dea9dddeceec8a1d68da24b14d5b2396effe555f > > > > This is also making the flush sequence in enable_mmu more clear and > > consistent. > > > > Signed-off-by: Michal Orzel > > --- > > Hi Michal, > > Looks good to me > > Reviewed-by: Luca Fancellu Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:01:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:01:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580452.908657 (Exim 4.92) (envelope-from ) id 1qTTpY-00024l-S6; Tue, 08 Aug 2023 21:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580452.908657; Tue, 08 Aug 2023 21:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTpY-00024e-P7; Tue, 08 Aug 2023 21:01:28 +0000 Received: by outflank-mailman (input) for mailman id 580452; Tue, 08 Aug 2023 21:01:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTpX-00024Y-IP for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:01:27 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb4a5146-362e-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 23:01:24 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691528480253457.4882144624638; Tue, 8 Aug 2023 14:01:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb4a5146-362e-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691528482; cv=none; d=zohomail.com; s=zohoarc; b=oDxGIUnDD2zuyfOt4Zo4f8PqvknzjOvSA5/MM5Y214JiN3//6QyOP9jR6KvaXm2VOMdb4tMUSAN4xXRF6tU4gvPHrsj8KedgKxDKntlTKA0ERyCl31mxReT/XcpTB9z8459f9kaOkdMO29uKIGexncUcqqB1AkWsCx7iy38AoH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691528482; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GCt+oDOouAj+Db+dnF97vVixLfO0dNuLruGV9RVi4O0=; b=V7YprwBu/R62Cf3aVCRW/KeZEEl8pKG+6HyANiviIZiP4wEMUd4WHvpiT2zaAOuCdJEM1pA2pOwr53L06z4r8WbGE6Mc77HcmLnuy5ZH+yf6Ky7pICxMFqpTGCjVXtQXxUuvytZeLIzeCiNbTSnZxuDQlNeMZ6bSRbx1WWL28jQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691528482; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=GCt+oDOouAj+Db+dnF97vVixLfO0dNuLruGV9RVi4O0=; b=Jv9V/JnYHXU//vGjuG1jRBXPzTGAfEfF3m0PkcC2Axu5lsmJmFJhmZ7GjEV2mcaB PkWXHa/DWckgSWfRl6YYwof0VLpzK5xMtxNZAXzcrXsEkCj570fQOzWrfTYwNuKUuaq RM74PR9Y7MGVnK9JrZsA6tRgD+zTSTEugRLQ3iFA= Message-ID: <577f5e19-a54c-955c-581d-ac35145911be@apertussolutions.com> Date: Tue, 8 Aug 2023 17:01:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Luca Fancellu Cc: Volodymyr Babchuk , Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> <8a51be9e-0131-0590-9aea-bbec146ce239@apertussolutions.com> <2E1A5918-A475-4055-A5A5-DE0CE30C061A@arm.com> From: "Daniel P. Smith" In-Reply-To: <2E1A5918-A475-4055-A5A5-DE0CE30C061A@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/3/23 16:37, Luca Fancellu wrote: > >> >>> Regarding the coding style, I think it’s better to keep the style you’ve found in the original file, >>> and change only some bits when the code is not following it. >>> I know there is nothing enforcing parameters on the same line of the function definition at the >>> moment, but it is how it’s done from the original file so I would stick with it. >>> Regarding the u32/u64 types, maybe since you are moving the code it can be the occasion to >>> convert them, but check with the maintainer before. >> >> I can leave the main code as is, but I do think header decl's should be styled correctly as there is no need to have them churn in the future over purely style changes. > > Uhm, when you say “styled correctly†do you mean as below? I am retracting that after going back to review my notes, see below. >>>> +bool __init device_tree_node_matches( >>>> + const void *fdt, int node, const char *match) >>>> +{ > > > If that’s the case, it seems to me that there is nothing like that in the codebase, > in my work with clang-format I’ve configured it to match as much as I can the > Xen style and this function would be formatted as the old style that it had. > > Can I ask you where did you find instruction to style in that way? > I went back to my old notes on styling to make sure I was correct. Turns out I was incorrect and do apologies. There are two accepted styles for function declarations[1] and the one I used in this patch was the one that I got a recommendation to use. I have gotten so use to that style, that I must have lost track the other was valid. As was pointed out elsewhere, I should use the form that the maintainer desires. As XSM maintainer, I use the one I submitted here and would ask for a style correct if someone submitted a patch using the form that is desired here. I will roll back the declaration styling for now and per the prior guidance[1], I will flip the linux-compat int over C spec fixed width int notation, unless there is objection to it happening during the move. [1] https://lists.xenproject.org/archives/html/xen-devel/2021-07/msg01133.html v/r dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:05:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:05:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580457.908668 (Exim 4.92) (envelope-from ) id 1qTTtS-0002fX-Bq; Tue, 08 Aug 2023 21:05:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580457.908668; Tue, 08 Aug 2023 21:05:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTtS-0002fQ-8Z; Tue, 08 Aug 2023 21:05:30 +0000 Received: by outflank-mailman (input) for mailman id 580457; Tue, 08 Aug 2023 21:05:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTTtR-0002fI-5A for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:05:29 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bca816e-362f-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 23:05:27 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691528722397254.1191249886159; Tue, 8 Aug 2023 14:05:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bca816e-362f-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691528723; cv=none; d=zohomail.com; s=zohoarc; b=X79NqvruxQcjF7y4zKUaPB18AMYaNHef6SWu2Uog+5qshRzGAlC4OS/VrpwDX8FP1oMgMJgUwuX26LkIexnrEi7Cq9O18VR6UIRzXAdU1o/c65Knz8Rjpsjjw+J0QMhKpjNL+z35H3jEVNLD7MVcpyYwqZpyGdQiQEqa1JzyIaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691528723; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+KTa3ESM4PEr3LYAF4nERwcd7tDhYndVrIOZUj8bCJE=; b=JG29pazNLMBhn2hVCC9SWnTS73YCtvl5ZS+dC0IQEf24Z9StUvlTbFYoFNx2YCJwcjF95nOI/aoDHTraShXNGQ79wp1ayGdP4PNkspIh0ddMnltLxA6cpeaG+TasBQDJQVtUEm4xIiZw8PZaNH+Dh3lQXqweAlp2MeZ8MjNZhOs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691528723; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=+KTa3ESM4PEr3LYAF4nERwcd7tDhYndVrIOZUj8bCJE=; b=Ry4cwZaShiZKTU/eskUcbtNSDlw/+Ba1g9ewsYuT4yz9NGxL1FiLLBupbvZr+1WP cvORJ3XJOHUIj1FrpjKSBG5wBR+/LX2Q8SpNfKnTnCE5tna5ozWWO13295IYaaTHr+t DY6VbrMF/E4tOuKuFQYQa5qDgv4co1dDCZc6jBk8= Message-ID: <90656f0f-0597-31ed-190e-d697e081d4b5@apertussolutions.com> Date: Tue, 8 Aug 2023 17:05:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch Content-Language: en-US To: Henry Wang , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/4/23 00:10, Henry Wang wrote: > Hi Daniel, Hey Henry! >> -----Original Message----- >> Subject: [PATCH v2 2/2] fdt: make fdt handling reusable across arch >> >> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is >> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is >> introduced for when the ability of parsing DTB files is needed by a capability >> such as hyperlaunch. >> >> Signed-off-by: Daniel P. Smith > > As said yesterday, I tested this patch and can confirm this patch will not > break any of the boards we used for our testing. So > > Tested-by: Henry Wang Thank your for running it through your tests. > (But I saw there are some comments from Michal and Luca about this > patch so I think these comments need to be addressed) So far the changes are style and a few mechanical. While unlikely to cause a functional change that could break, probably best to hold off adding your Tb for now. v/r dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:15:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:15:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580464.908678 (Exim 4.92) (envelope-from ) id 1qTU2h-0004CP-8T; Tue, 08 Aug 2023 21:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580464.908678; Tue, 08 Aug 2023 21:15:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU2h-0004CI-4e; Tue, 08 Aug 2023 21:15:03 +0000 Received: by outflank-mailman (input) for mailman id 580464; Tue, 08 Aug 2023 21:15:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU2g-0004Bt-Eu for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:15:02 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1659fe9-3630-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 23:14:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 400E762D2D; Tue, 8 Aug 2023 21:14:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BA7BC433C7; Tue, 8 Aug 2023 21:14:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1659fe9-3630-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691529297; bh=eRLrTUS7VX4+Uznzq3r36Rqo2PTybBhEnPNzTP/L9yE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VtfyeHb81VAvzF3qGjzp+2NOcpzrZoBABTyzM0BrSwyobMOD9aIYq8V9ofbaeD3rH r38fnPotp+kKCJgm/V1QkuRqxyqAJhtMZbFbs3zlOlSdqsP0KyDWuZi7obZ3Ko9iR4 RuRSzOmUvaBP2b5LJUiK6VekzspUTLnm8NDm3DXlYNKlF4hcExCCVe6nv3VK+jhLK1 D/IUSU5h6UX9GE7rWbldvtguV/J+FD97A1XJbPiQN2ETKCgbTuR3+p6Ae4d3UkO6or Y6q40dkalrpzegzrOTYy0Tnp2xnXkuC0evQZPUkIDbVsej2KphtnbdjNj91FX8iBf6 EKx/i7Nyi/kRA== Date: Tue, 8 Aug 2023 14:14:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Nicola Vetrini , Jan Beulich , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 In-Reply-To: <6aac7add-544b-4c8a-b397-2a6b6c6b766c@xen.org> Message-ID: References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> <6aac7add-544b-4c8a-b397-2a6b6c6b766c@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Julien Grall wrote: > On 08/08/2023 16:53, Nicola Vetrini wrote: > > > > ... "return" alone already tells the compiler that "break" is > > > > unreachable. You don't need unreachable() for that. As said before, > > > > "break" like this simply want purging (and Misra is wrong to demand > > > > "break" everywhere - it should instead demand no [unannotated] > > > > fall-through, which can also be achieved by return, continue, and > > > > goto). > > > > > > My suggestion was in the context of this series where we add > > > ASSERT_UNREACHABLE() before break. From my understanding, we don't > > > have a lot of leeway here because, from what Nicola wrote, rule 16.3 > > > is mandatory. > > > > > > So I think using unreachable is better if we every decide to use break > > > after return. > > > > > > Cheers, > > > > 16.3 is not Mandatory, just Required. > > Ah I misread what you wrote. In that case... > > > I was just reluctant to knowingly add one more violation > > while fixing another before submitting the patch. If indeed 16.3 won't > > likely be adopted by Xen, > > then that break should indeed go away. > > > > However, the main thing that's holding me back from doing a slimmed-down v2 > > here is that > > evidently there's no consensus even on the ASSERT_UNREACHABLE() patches. > > ... I agree with the following statement from Jan: > > "it should instead demand no [unannotated] fall-through, which can also be > achieved by return, continue, and goto" I also think it is a better idea to have no unannotated fall-through in switch statements (unless we have a "case" with nothing underneath, so two cases next to each other). In other words the following are all OK in my view: case A: do(); break; case B: do(); return true; case Ca: case Cb: goto fail; case D: i++; continue; case E: do(); /* fall-through */ case F: do(); break; While the following is not OK: case A: do(); case B: do(); This should be what we already do in Xen, although it is not documented properly. Jan, Julien do you agree? If so, could Eclair be configured to check for this pattern (or similar)? We must have one of the following: - break, continue, return, goto - /* fall-through */ - empty case body (case Ca/Cb) From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:17:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:17:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580469.908689 (Exim 4.92) (envelope-from ) id 1qTU5G-0004mt-MI; Tue, 08 Aug 2023 21:17:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580469.908689; Tue, 08 Aug 2023 21:17:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU5G-0004mm-Hj; Tue, 08 Aug 2023 21:17:42 +0000 Received: by outflank-mailman (input) for mailman id 580469; Tue, 08 Aug 2023 21:17:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU5G-0004me-0W for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:17:42 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00c412fc-3631-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 23:17:40 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691529454289825.6972881222913; Tue, 8 Aug 2023 14:17:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00c412fc-3631-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691529456; cv=none; d=zohomail.com; s=zohoarc; b=bWZ96RYWs2zTCSBhUa4XqhfrH/dRwZrDtjZ/fDju1umciQyDfqON8YF6qXGZS4OJ30Jq/dAgSb8zYucfaFlchyiCc7MhH0JySznz6q08rRplwMAWOiLvLY13tXPMi8+UAwmGz0d2wNin/qxzjE4oeJQj9D7AgZzXvuPK6z67ob4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691529456; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Q9bUDKxlqAq/RRI2lcmaz2jxZMJZQ5lF2Xvw2zb5hyo=; b=kDZKMidf3RhwDHzAjSCB8whlFnDlGDfw3OH8ip9Vg0jpCmuR5ByrJhI3ZfUW33hYgs8JNEPPKnRTtGNxIn44+pMR+rl+8VAZspo+waXXt4tsDfE2oV3vqh5jUGYm8JOetgbqNgVTqBvy9mGD9u2dkXzgo+fSbkic/GtZFoWes+U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691529456; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Q9bUDKxlqAq/RRI2lcmaz2jxZMJZQ5lF2Xvw2zb5hyo=; b=nDttOTywfSx4HVP+i9Hl/UVWC594v6plWLtgfjDgqho2/nEyN0qeaetjCZ3Dzxjl V9oFhkc/dc9CGPMBDAF2EYFzrGGHVeCFdqDypGwb057+qYg26q3gQlf995EotxOGcmf NRwNq35zkjBXL54MphpEBCujTtIoeq0b6mtjNISA= Message-ID: Date: Tue, 8 Aug 2023 17:17:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-US To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> <2a72cbf1-a9d7-6edf-37f6-5197c9d40452@amd.com> From: "Daniel P. Smith" In-Reply-To: <2a72cbf1-a9d7-6edf-37f6-5197c9d40452@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/4/23 03:06, Michal Orzel wrote: > Hi Daniel, > > On 03/08/2023 18:57, Daniel P. Smith wrote: >> >> >> On 8/3/23 07:45, Michal Orzel wrote: >>> Hi Daniel, >>> >>> On 03/08/2023 12:44, Daniel P. Smith wrote: >>>> >>>> >>>> With on going development of hyperlaunch, changes to the device tree definitions >>>> has been necessary. This commit updates the specification for all current changes >>>> along with changes expected to be made in finalizing the capability. >>>> >>>> This commit also adds a HYPERLAUNCH section to the MAINTAINERS file and places >>>> this documentation under its purview. It also reserves the path >>>> `xen/common/domain-builder` for the hyperlaunch domain builder code base. >>>> >>>> Signed-off-by: Daniel P. Smith > > [...] >>>> + >>>> memory >>>> - The amount of memory to assign to the domain, in KBs. >>>> + The amount of memory to assign to the domain, in KBs. This field uses a DTB >>>> + Reg which contains a start and size. For memory allocation start may or may >>>> + not have significance but size will always be used for the amount of memory >>>> Required. >>>> >>>> + Format: String min: | max: | , e.g. "256M" >>> There is a mismatch between the description and above format: >>> - KB vs MB >>> - string vs reg format >>> - the x86 example uses string and Arm uses reg format >> >> Hmmm. I missed this in the hyperlaunch v1 update. In the original design >> that came from the working group it was going to use a reg as suggest by >> dom0less. During development of v1, we found it was not rich enough to >> express how Dom0 could be allocated memory and switched to a string to >> mirror the dom0 memory hypervisor command line parameter. > On Arm, dom0_mem cmdline parameter is used to specify only size (no min,max) I understand. For general domain construction, these are legitimate values and hyperlaunch is meant to be able to fully construct a running environment just as if it was constructed by a toolstack. We must also be able to handle situations where a general configuration is being reused across systems and must be able to express the minimum memory each domain must have, how much should be attempted to be allocated, and if ballooning is enabled, being able to articulate that to the hyperlaunch domain builder. I did not say this in reply to Julien, but I am not opposed to three separate parameters if that is what the conscience arrives at. I found the existing parser and the structure it creates as a useful and reusable component for obtaining and storing the values. >> >> A question for those involved with dom0less, is what are the opinions >> about using this form for memory allocation. Is it required/possible to >> be able to instruct the hypervisor what physical address to use as the >> start of a domain's memory? > "memory" dt property is used to specify just amount of memory for domain in KBs using reg format. > It is not used to specify the static memory region (with start and size). For that, we have another property called "xen,static-mem". > Therefore, it would be possible to switch memory to string but it would not be compatible with the current use anymore. It would be compatible in the sense that dom0less-compatibility-mode could still accept it as just amount of memory. Which brings up a good point, whether I do it here or it is done in the patch series that will introduce dom0less-compatibilty-mode, there probably will need to be a top level flag under the hypervisor node to indicate it is a dom0less compatible configuration. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:21:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:21:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580476.908698 (Exim 4.92) (envelope-from ) id 1qTU93-0006Dc-48; Tue, 08 Aug 2023 21:21:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580476.908698; Tue, 08 Aug 2023 21:21:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU93-0006DV-1L; Tue, 08 Aug 2023 21:21:37 +0000 Received: by outflank-mailman (input) for mailman id 580476; Tue, 08 Aug 2023 21:21:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU91-0006DO-KP for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:21:35 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8c8722bb-3631-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 23:21:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD06E6255A; Tue, 8 Aug 2023 21:21:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE276C433C7; Tue, 8 Aug 2023 21:21:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c8722bb-3631-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691529692; bh=ZjF+MW+RGSNyMp2hKrQlVLYHZbaWBd95p/pBI3t2Bus=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=YNWUvRSHIe5QycUhpXBoko1PLcxrNabJOGLEVgyEJKwakHDrKWax28RvoPvsPLSdS saglGeCVdmZtnA95/J+iUGG8EQzgKq2d3QrfbfdP+QXtfgCMiSGB+Cc8D8l69BRcbw NFsRAVYbp+Rk/Uy5+6euDJWM4F395ton2yJP1ESClBMS/0drQ2Or4yb66PJFDOrqD0 VcHIwM2nM0TYb0RvP7v9F7rsS94O+HYyzj/nNMahwFR4ObCt0hhfTDl7Xii/iFz5Dr YlxeYCckG70oZv/lTulCQxnlRuj0r+aglrphlBXhGOPYYo1Tjjy+IsuoD9lk9iFAlf Y1uCIOI378J1w== Date: Tue, 8 Aug 2023 14:21:29 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: <0164b934-cf15-9e45-28b7-b3c9ac2038da@suse.com> Message-ID: References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> <55599ec7a1c6d07af6093920fe3f9125@bugseng.com> <0164b934-cf15-9e45-28b7-b3c9ac2038da@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Jan Beulich wrote: > On 08.08.2023 09:08, Nicola Vetrini wrote: > > On 07/08/2023 11:10, Jan Beulich wrote: > >> On 07.08.2023 10:59, Nicola Vetrini wrote: > >>> On 07/08/2023 10:09, Jan Beulich wrote: > >>>> On 04.08.2023 17:27, Nicola Vetrini wrote: > >>>>> The variable declared in the header file > >>>>> 'xen/arch/x86/include/asm/e820.h' > >>>>> is shadowed by many function parameters, so it is renamed to avoid > >>>>> these > >>>>> violations. > >>>>> > >>>>> No functional changes. > >>>>> > >>>>> Signed-off-by: Nicola Vetrini > >>>>> --- > >>>>> This patch is similar to other renames done on previous patches, and > >>>>> the > >>>>> preferred strategy there was to rename the global variable. This one > >>>>> has more occurrences that are spread in various files, but > >>>>> the general pattern is the same. > >>>> > >>>> Still I think it would be better done the other way around, and > >>>> perhaps > >>>> in > >>>> more than a single patch. It looks like "many == 3", i.e. > >>>> - e820_add_range(), which is only ever called with "e820" as its > >>>> argument, > >>>> and hence the parameter could be dropped, > > > > I see another downside with this approach (I should have spotted this > > sooner): > > Since e820_add_range and the other functions expected e820 as a pointer, > > they are > > written like this: > > > > for ( i = 0; i < e820->nr_map; ++i ) > > { > > uint64_t rs = e820->map[i].addr; > > uint64_t re = rs + e820->map[i].size; > > > > if ( rs == e && e820->map[i].type == type ) > > { > > e820->map[i].addr = s; > > return 1; > > } > > ... > > > > Dropping the parameter would either mean > > 1. Use a local parameter that stores the address of e820, which kind of > > nullifies the purpose of dropping the parameter imho; > > This isn't an unusual thing to do; it is only the name being short which > may make it look "unnecessary" here. But especially if the local variable > was made of type struct e820entry * (and updated in the for()) I think > this could be useful overall. > > > 2. Rewrite it so that it operates on a "struct e820map", which would > > mean > > substantial churn; > > 3. Make the global a pointer, which is reminiscent of (1) > > > > All in all, I do like the global renaming approach more, because it > > lessens > > the amount of code that needs to change to accomodate a case of > > shadowing. > > Well, to go that route you need to come up with a suitable new name (no > prior proposal was really meeting that requirement) and you'd need to > convince at least one of the x86 maintainers. Would you be OK with your previous suggestion: > Alternatively, if we really were to change the name of the global, we'd > want to take a more complete approach: Right now we have e820_raw[], > boot_e820[], and e820[]. We'd want them to follow a uniform naming scheme > then (e820_ first or _e820 last), with the other part of the name suitably > describing the purpose (which "map" doesn't do). So: e820_raw -> unchanged boot_e820 -> e820_boot e820 -> e820_table (or e820_list or e820_ranges)? From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:22:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580482.908708 (Exim 4.92) (envelope-from ) id 1qTU9v-0006nI-Ju; Tue, 08 Aug 2023 21:22:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580482.908708; Tue, 08 Aug 2023 21:22:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU9v-0006nB-Fp; Tue, 08 Aug 2023 21:22:31 +0000 Received: by outflank-mailman (input) for mailman id 580482; Tue, 08 Aug 2023 21:22:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTU9u-0006DO-E2 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:22:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adac6596-3631-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 23:22:29 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B632761B0B; Tue, 8 Aug 2023 21:22:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63886C433C7; Tue, 8 Aug 2023 21:22:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adac6596-3631-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691529748; bh=m+MGQspKxTlbfsdEbp86EmmhwiZxUDaiH6labh1c8ms=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DEo9B6E13L2Dlv53vyzgHr8B8gL5EbJOEsOriFZ6M9egl2WK+vo0GiP4f83PSAeL5 QZ+yjKSTdoEQnqL3CfXnzr+h+BYEErY5jMcFile6PZf3MMqunbm87VJU9ckRVqmyQb 8+ZrbuauE5oe/oJAVLZ9LTS/Jxr19/dy/uxi6Gqquk0W8/AtESbut8S7cMd8XzJuUp V6vGWyNs8rffP+0IziIugtAYwoav6EOVQEjXP4jh9B43CwhMvnjrbVbvvVZDK2/4wu z7fY/+4tijlvF2oEJd2IXpwKzk7Pup/JV3+qxPG04yBRa6J8377VymDVBTba2Z6YEc D3GfzckVWdbRQ== Date: Tue, 8 Aug 2023 14:22:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Michal Orzel , "xen-devel@lists.xenproject.org" , Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH] automation: Fix missing smoke.serial in artifacts of qemu arm32 jobs In-Reply-To: <7B3BFA6D-5BC3-4ECA-B897-07996D0E9883@arm.com> Message-ID: References: <20230808085059.13112-1-michal.orzel@amd.com> <7B3BFA6D-5BC3-4ECA-B897-07996D0E9883@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Luca Fancellu wrote: > > On 8 Aug 2023, at 09:50, Michal Orzel wrote: > > > > It was observed that smoke.serial file (used to store boot logs) is > > missing in artifacts of qemu based arm32 jobs. This is because the > > artifacts:paths listing smoke.serial specifies paths relative to the > > project directory but the qemu-smoke-dom0{less}-arm32.sh scripts create > > this file under binaries/. Fix it so that smoke.serial gets created in > > project directory just like for every other test job. > > > > Signed-off-by: Michal Orzel > > Reviewed-by: Luca Fancellu Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:24:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:24:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580488.908717 (Exim 4.92) (envelope-from ) id 1qTUCG-0007Oq-UD; Tue, 08 Aug 2023 21:24:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580488.908717; Tue, 08 Aug 2023 21:24:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUCG-0007Oj-R7; Tue, 08 Aug 2023 21:24:56 +0000 Received: by outflank-mailman (input) for mailman id 580488; Tue, 08 Aug 2023 21:24:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUCE-0007Od-N3 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:24:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03564a8f-3632-11ee-b280-6b7b168915f2; Tue, 08 Aug 2023 23:24:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6BA29623F5; Tue, 8 Aug 2023 21:24:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DF61C433C7; Tue, 8 Aug 2023 21:24:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03564a8f-3632-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691529891; bh=MAnf6uILt51JRzdHgEubOjKoMNQhgU70wc2+sfWOBmE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=cL5YtVd0iLwdhQFLwhbnKoeOstGxGn106cqQI/zlmphVzLAxBcMLEAYiwnJKWaPf3 zvH5qKqT11axw8i3kUwYuX4e1v3PbwGrNEM7dHBmmJugGOqHbAljheWzvtyD/PsQAn 675m+1CuBPSFevRpUGrrNGRe4UH5TedJoaRPTXootGoYAGXyYmarqH3tjGiDdoM2D3 0IAoy6BRFYlmLpMPz+gX9p4ld57jtATaMcVLiUYLm9wm0JytefNwxX3KbNyFMKwdi0 vFS2BWe/ooCOWajWOr3VGoyuU3Va7g/1LKt8wkeyq9u8mictiuUg7njm23+SayYR4E +wbV/f6dPKDow== Date: Tue, 8 Aug 2023 14:24:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Stefano Stabellini cc: Jan Beulich , Nicola Vetrini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/6] x86: rename variable 'e820' to address MISRA C:2012 Rule 5.3 In-Reply-To: Message-ID: References: <896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com> <9e2b0b7d-2c9c-b4db-fb91-1a43ba8e8294@suse.com> <838a53b9ef4a8d258feceabb4c811534@bugseng.com> <742f4a4a-5938-82f5-7e76-1189a2519063@suse.com> <55599ec7a1c6d07af6093920fe3f9125@bugseng.com> <0164b934-cf15-9e45-28b7-b3c9ac2038da@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Stefano Stabellini wrote: > On Tue, 8 Aug 2023, Jan Beulich wrote: > > On 08.08.2023 09:08, Nicola Vetrini wrote: > > > On 07/08/2023 11:10, Jan Beulich wrote: > > >> On 07.08.2023 10:59, Nicola Vetrini wrote: > > >>> On 07/08/2023 10:09, Jan Beulich wrote: > > >>>> On 04.08.2023 17:27, Nicola Vetrini wrote: > > >>>>> The variable declared in the header file > > >>>>> 'xen/arch/x86/include/asm/e820.h' > > >>>>> is shadowed by many function parameters, so it is renamed to avoid > > >>>>> these > > >>>>> violations. > > >>>>> > > >>>>> No functional changes. > > >>>>> > > >>>>> Signed-off-by: Nicola Vetrini > > >>>>> --- > > >>>>> This patch is similar to other renames done on previous patches, and > > >>>>> the > > >>>>> preferred strategy there was to rename the global variable. This one > > >>>>> has more occurrences that are spread in various files, but > > >>>>> the general pattern is the same. > > >>>> > > >>>> Still I think it would be better done the other way around, and > > >>>> perhaps > > >>>> in > > >>>> more than a single patch. It looks like "many == 3", i.e. > > >>>> - e820_add_range(), which is only ever called with "e820" as its > > >>>> argument, > > >>>> and hence the parameter could be dropped, > > > > > > I see another downside with this approach (I should have spotted this > > > sooner): > > > Since e820_add_range and the other functions expected e820 as a pointer, > > > they are > > > written like this: > > > > > > for ( i = 0; i < e820->nr_map; ++i ) > > > { > > > uint64_t rs = e820->map[i].addr; > > > uint64_t re = rs + e820->map[i].size; > > > > > > if ( rs == e && e820->map[i].type == type ) > > > { > > > e820->map[i].addr = s; > > > return 1; > > > } > > > ... > > > > > > Dropping the parameter would either mean > > > 1. Use a local parameter that stores the address of e820, which kind of > > > nullifies the purpose of dropping the parameter imho; > > > > This isn't an unusual thing to do; it is only the name being short which > > may make it look "unnecessary" here. But especially if the local variable > > was made of type struct e820entry * (and updated in the for()) I think > > this could be useful overall. > > > > > 2. Rewrite it so that it operates on a "struct e820map", which would > > > mean > > > substantial churn; > > > 3. Make the global a pointer, which is reminiscent of (1) > > > > > > All in all, I do like the global renaming approach more, because it > > > lessens > > > the amount of code that needs to change to accomodate a case of > > > shadowing. > > > > Well, to go that route you need to come up with a suitable new name (no > > prior proposal was really meeting that requirement) and you'd need to > > convince at least one of the x86 maintainers. > > Would you be OK with your previous suggestion: > > > Alternatively, if we really were to change the name of the global, we'd > > want to take a more complete approach: Right now we have e820_raw[], > > boot_e820[], and e820[]. We'd want them to follow a uniform naming scheme > > then (e820_ first or _e820 last), with the other part of the name suitably > > describing the purpose (which "map" doesn't do). > > So: > > e820_raw -> unchanged > boot_e820 -> e820_boot > e820 -> e820_table (or e820_list or e820_ranges)? Nevermind, I saw now the updated patch From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:27:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:27:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580495.908728 (Exim 4.92) (envelope-from ) id 1qTUF8-00081W-Bu; Tue, 08 Aug 2023 21:27:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580495.908728; Tue, 08 Aug 2023 21:27:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUF8-00081P-8e; Tue, 08 Aug 2023 21:27:54 +0000 Received: by outflank-mailman (input) for mailman id 580495; Tue, 08 Aug 2023 21:27:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUF7-00081J-Th for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:27:53 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6cd524e5-3632-11ee-8613-37d641c3527e; Tue, 08 Aug 2023 23:27:51 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691530062954947.7218140859737; Tue, 8 Aug 2023 14:27:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cd524e5-3632-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691530064; cv=none; d=zohomail.com; s=zohoarc; b=Gg82p8SFLAS85ZsR5VgvXpPM5slIHZcXyDhNHVe6WG1wEPmXvIDXWa4hyC+P1TXHPJ+Y8kxmBIt3K30ISVo2dTMRMDcsFxfJ9j9sTPbnfusiB2ojsQjmyaQcMAjhR9ytQDmfAbae/JeYOHzP5hUi5bcm0L8AM2SqoDr59ZGqiHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691530064; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=qhdsCcqLV5gPF6Pj1XWQJS4sDgk8TWD9gM81TQ2vS6s=; b=lX9FY0HK/kuELKZ++w7P8LcLIQ4WvaQw5SZt9+L65sBMMJeUaBVXjcoG7qwd5IbIFV9URH+VLANEXCDccD8ICLNPGvVmDcu7gHlxfUZQx43OCu9h69sCj7GEG2XT0+Z/BerWh7mf0eMpM09xv94lWuyf/oK790ayGSLBmB4p5bU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691530064; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=qhdsCcqLV5gPF6Pj1XWQJS4sDgk8TWD9gM81TQ2vS6s=; b=qQbUSFf4udCXycZVO7oCT9DhkrXsPh9WAn5ZO7QdbN5rsKTf2qbSFMv0jL9ANfJb Jung7bwd95VNhxgGL/2nOKo6xIopypKgUmqd5r0OUrCVOOo4sVdSPjWynMA9BnT6kWM 2dORYAKI+HbzNygZveea8asLuXvIlGl04oXBtaWI= Message-ID: Date: Tue, 8 Aug 2023 17:27:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH] subdom: Fix -Werror=address failure in tmp_emulator Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= , Jason Andryuk , Christopher Clark References: <20230803203650.1474936-1-andrew.cooper3@citrix.com> From: "Daniel P. Smith" In-Reply-To: <20230803203650.1474936-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/3/23 16:36, Andrew Cooper wrote: > The opensuse-tumbleweed build jobs currently fail with: > > /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c: In function 'rsa_private': > /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:56:7: error: the comparison will always evaluate as 'true' for the address of 'p' will never be NULL [-Werror=address] > 56 | if (!key->p || !key->q || !key->u) { > | ^ > In file included from /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.c:17: > /builds/xen-project/xen/stubdom/tpm_emulator-x86_64/crypto/rsa.h:28:12: note: 'p' declared here > 28 | tpm_bn_t p; > | ^ > > This is because all tpm_bn_t's are 1-element arrays (of either a GMP or > OpenSSL BIGNUM flavour). The author was probably meaning to do value checks, > but that's not what the code does. > > Adjust it to compile. No functional change. > > Signed-off-by: Andrew Cooper > --- > CC: George Dunlap > CC: Jan Beulich > CC: Stefano Stabellini > CC: Wei Liu > CC: Julien Grall > CC: Juergen Gross > CC: Marek Marczykowski-GĂ³recki > CC: Jason Andryuk > CC: Daniel Smith > CC: Christopher Clark > > While I've confirmed this to fix the build issue: > > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/955160430 > > I'm -1 overall to the change, and would prefer to disable vtpm-stubdom > entirely. > > It's TPM 1.2 only, using decades-old libs, and some stuff in the upstream > https://github.com/PeterHuewe/tpm-emulator (which is still abandaonded as of > 2018) is just as concerning as the basic error here in rsa_private(). For semantics sake, the Guest PV interface is 1.2 compliant but the PV backend, vtpmmgr, is capable of using TPM2.0. > vtpm-stubdom isn't credibly component of a Xen system, and we're wasting loads > of CI cycles testing it... Unfortunately, I cannot disagree here. This is the only proper vTPM, from a trustworthy architecture perspective, that I know of existing today. Until I can find someone willing to fund updating the implementation and moving it to being an emulated vTPM and not a PV interface, it is likely to stay in this state for some time. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:29:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580500.908737 (Exim 4.92) (envelope-from ) id 1qTUGo-00008V-M7; Tue, 08 Aug 2023 21:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580500.908737; Tue, 08 Aug 2023 21:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUGo-00008O-Jf; Tue, 08 Aug 2023 21:29:38 +0000 Received: by outflank-mailman (input) for mailman id 580500; Tue, 08 Aug 2023 21:29:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUGo-00008D-2e; Tue, 08 Aug 2023 21:29:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUGn-0008WE-OH; Tue, 08 Aug 2023 21:29:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUGn-0001nX-8o; Tue, 08 Aug 2023 21:29:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTUGn-0008CH-3J; Tue, 08 Aug 2023 21:29:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qMGnWXpuIwlWGT9CiYJ6yHDvuzqzro5CysoPuq6EyLc=; b=OgG1DeBHrutGMlCXjB+SzQ2ULD E7i7s+NJkUvqVLa5RjMlCIHqTT1ebYw8B0m3y3NN+/maoCyH053/wmwtCih8fjA7fbw2Cs2YL5xRG LKHYZ78cxeFlA9l8TY+VbhGwN0Rh20Iz/iQVHioc0tz39eY4bDVSqiM5TifKS3oH7UYc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182238: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=56d690efd3ca3c68e1d222f259fb3d216206e8e5 X-Osstest-Versions-That: xen=46c5ef609b09cf51d7535aebbc05816eafca4c8d From: osstest service owner Date: Tue, 08 Aug 2023 21:29:37 +0000 flight 182238 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182238/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 56d690efd3ca3c68e1d222f259fb3d216206e8e5 baseline version: xen 46c5ef609b09cf51d7535aebbc05816eafca4c8d Last test of basis 182232 2023-08-08 12:03:48 Z 0 days Testing same since 182238 2023-08-08 18:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 46c5ef609b..56d690efd3 56d690efd3ca3c68e1d222f259fb3d216206e8e5 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Aug 08 21:45:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 21:45:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580509.908748 (Exim 4.92) (envelope-from ) id 1qTUW1-0002cT-0f; Tue, 08 Aug 2023 21:45:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580509.908748; Tue, 08 Aug 2023 21:45:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUW0-0002cM-UA; Tue, 08 Aug 2023 21:45:20 +0000 Received: by outflank-mailman (input) for mailman id 580509; Tue, 08 Aug 2023 21:45:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUW0-0002cG-40 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 21:45:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTUVy-0000L9-Ed; Tue, 08 Aug 2023 21:45:18 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTUVy-0000c5-7a; Tue, 08 Aug 2023 21:45:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/ptdp1jNOu3zIbj++3uF01/aR4VDNlm76f4WVZ+9cSY=; b=G3bJz5Cb8fobjInPFDhYRJsOw1 QOIOyxws4RfIHG2YjIDhGWa/FbcvxiCCFP2O2NhviaUs0NWdr6m01/moSc0FIJxsKC0M67zWxYFey 3K76bfWgSqUY5RrniPImJ+36T0nz+lUtN/UZRqx8VD8e6mC9aTcD4YiQyuy2e/TtXvVs=; Message-ID: Date: Tue, 8 Aug 2023 22:45:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-GB To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <3ddab6ee-54fc-49a0-8f14-79ca258d04af@xen.org> <76249714-6d1d-a2ad-cfe5-d7eae0ce3a1b@apertussolutions.com> From: Julien Grall In-Reply-To: <76249714-6d1d-a2ad-cfe5-d7eae0ce3a1b@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Daniel, On 08/08/2023 21:49, Daniel P. Smith wrote: > On 8/4/23 05:03, Julien Grall wrote: >> Hi Daniel, >> >> On 03/08/2023 11:44, Daniel P. Smith wrote: >>> +compatible >>> +  Identifies which hypervisors the configuration is compatible. >>> Required. >>> -    hypervisor { >>> -        compatible = “hypervisor,xen†>>> +  Format: "hypervisor,", e.g "hypervisor,xen" >> >> I read "e.g" as "for example". You don't explicitely say which >> compatible will be supported by Xen, so one could write >> "hypervisor,foo" and expect to work. >> >> Also, it is not fully clear why you need both the hypervisor and each >> domain node to have a compatible with the hypervisor name in it. > > Ack, it should be explicit to what is expected for a Xen configuration. > As for compatible on the domain node, I think that was from being overly > cautious, it can be dropped. > > This did get me reflecting that the compatibility was added there as > there was some initial participation in standardization efforts going on > at the time. I am not sure what has come of those, but the question it > raised is that domain is a Xen specific term, whereas generally vm is > accepted as the generic term. Maybe this node needs renaming? IIRC Stefano attempted to (partially?) standardized the Device-Tree configuration for domains. So I will let him comment here. > >>> +compatible >>> +  Identifies the hypervisor the confiugration is intended. Required. >> >> Also typo: s/confiugration/configuration/ > > Ack. > >>> -The modules that would be supplied when using the above config would >>> be: >>> +  Format: ",config", e.g "xen,config" >>> -* (the above config, compiled into hardware tree) >>> -* CPU microcode >>> -* XSM policy >>> -* kernel for boot domain >>> -* ramdisk for boot domain >>> -* boot domain configuration file >>> -* kernel for the classic dom0 domain >>> -* ramdisk for the classic dom0 domain >>> +bootargs >>> +  This is used to provide the boot params for Xen. >> >> How is this different from the command line parameter chosen? And if >> you want to keep both, what is the expected priority if a user >> provides both? > > A DT file for x86, there is only a need to provide the hypervisor node, > for which we already needed a hypervisor config section to describe XSM > policy and microcode, at this point at least. It was decided in an > effort to provide flexibility, the ability to specify command line > parameters to the hypervisor in DT config. It is expected these > parameters would function as a base parameters that would be overridden > by those provided via the multiboot kernel entry. ]> > Now as you point out for Arm, this becomes a bit redundant, to a degree, > as the Xen command line is already under the /chosen node. But even here > it would be beneficial, as a hyperlaunch configuration could be > distributed consisting of a dtb that has core parameters set with base > values along with a set of kernels and ramdisks. At boot, the > hyperlaunch dtb could then be concatenated with the device specific dtb. I don't have a strong opinions on how it should be done. My point is more that the priority should be document. > > >>> -The hypervisor device tree would be compiled into the hardware >>> device tree and >>> -provided to Xen using the standard method currently in use. The >>> remaining >>> -modules would need to be loaded in the respective addresses >>> specified in the >>> -`module-addr` property. >>> +  Format: String, e.g. "flask=silo" >>> +Child Nodes >>> +""""""""""" >>> -The Hypervisor node >>> -------------------- >>> +* module >>> -The hypervisor node is a top level container for the domains that >>> will be built >>> -by hypervisor on start up. On the ``hypervisor`` node the >>> ``compatible`` >>> -property is used to identify the type of hypervisor node present.. >>> +Domain Node >>> +----------- >>> -compatible >>> -  Identifies the type of node. Required. >>> +A ``domain`` node is for describing the construction of a domain. >>> Since there >>> +may be one or more domain nodes, each one requires a unique, DTB >>> compliant name >>> +and a ``compatible`` property to identify as a domain node. >>> -The Config node >>> ---------------- >>> +A ``domain`` node  may provide a ``domid`` property which will be >>> used as the >>> +requested domain id for the domain with a value of “0†signifying to >>> use the >>> +next available domain id, which is the default behavior if omitted. >>> It should >>> +be noted that a domain configuration is not able to request a domid >>> of “0†>> >> Why do you need this restriction? And more importantly how would you >> describe dom0 in hyperlaunch? > > I would start by saying one of the goals/purposes behind hyperlaunch is > to remove the binding that "dom0" is identified by having domid 0. That > is what the roles patch recently submitted is working to achieve. "Dom0" > is a role in the system, which I tried calling the "unbounded role" but > that seems to have caused some confusion. > > That aside, IMHO because of the legacy around domid 0, I don't think it > should be assignable through hyperlaunch. I understand the end goal. But I am not entirely convinced this will be wanted for everyone. So it might be preferable to avoid using '0' as 'assign any free domid' as this would not prevent to describe dom0 in hyperlaunch if needed in the future. > Additionally, there should be > an identifier that signifies auto-assign the domid and that value should > not conflict/limit what domids are usable by the hypervisor. Why is this requirement? Why can't we simply rely on the property is not present? > Given we > should not be assigning domid 0 through this interface, it makes it the > perfect candidate value. To be honest, even if you don't want to allow an admin to allocate ID 0, I think using it is confusing because of the legacy meaning behind it. I would likely be confused every time I read a device-tree. Also, given you already have a way to say 'assign a domain ID', it is not clear to me why you really need a second way to do it. [...] >>> + >>> +capability >>> +  This identifies what system capabilities a domain may have beyond >>> the role it >>> +  was assigned. >>>     Optional, the default is none. >>> -.. note::  The `functions` bits that have been selected to indicate >>> -   ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last >>> two bits >>> -   (30, 31) such that should these features ever be fully retired, >>> the flags may >>> -   be dropped without leaving a gap in the flag set. >>> +  Format: Bitfield, e.g <3221225487> or <0xC0000007> >> >> I thik we should favor the hexadecimal version because this will be >> somewhat easier to read. > > I too favor the hex version, but as I recall, DT/libfdt doesn't > care/enforce. Indeed the device-tree compiler is able to cope with both. However, we don't have to mention the two. It would be ok to only mention the one we prefer (i.e. hexadecimal) so the reader will more naturally use it. > >> Also, the Device-Tree values work in term of 32-bit cell. Also, how do >> you plan to handle the case where you have more than 32 capabilities? > > I would add a capabalities2 field, this is how SELinux/Flask handle the > same problem. You should not need to introduce a new field. Instead you can add a second cell. But we would need to describe the ordering because for backward compatibility the cell 0 would want to cover bits [0:31] and cell 2 bits [64:31]. [...] >>> + >>>   memory >>> -  The amount of memory to assign to the domain, in KBs. >>> +  The amount of memory to assign to the domain, in KBs. This field >>> uses a DTB >>> +  Reg which contains a start and size. For memory allocation start >>> may or may >>> +  not have significance but size will always be used for the amount >>> of memory >>>     Required. >> >> The description doesn't match... > > Ack, others caught that as well. Will be fixed. > >>> +  Format: String  min: | max: | , e.g. "256M" >> >> ... the format. But strings are difficult to parse. If you want to >> provide 3 different values (possibly optional), then it would be best >> to have 3 different properties. > > That format comes from the command line dom0 memory parameter, in the > hyperlaunch series I reused that existing parser that I am fairly > confident will be maintained. Fair enough. However, I am still unconvinced this is the way to go. I don't have a strong argument other than 'memory' is already a number for dom0less DT and it sounds strange to change it. Stefano, Bertrand, any opinions? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 22:17:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 22:17:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580516.908758 (Exim 4.92) (envelope-from ) id 1qTV0U-00069r-JB; Tue, 08 Aug 2023 22:16:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580516.908758; Tue, 08 Aug 2023 22:16:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV0U-00069k-FY; Tue, 08 Aug 2023 22:16:50 +0000 Received: by outflank-mailman (input) for mailman id 580516; Tue, 08 Aug 2023 22:16:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV0S-00069e-V7 for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 22:16:49 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV0R-00011C-8S; Tue, 08 Aug 2023 22:16:47 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTV0R-0001om-1F; Tue, 08 Aug 2023 22:16:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5Mk/uF6D99CYHy/bzJ6wkcl29nXJb80x3eKam8vfQPU=; b=KKEkkbXHfJROf6goVJMwLuSNLl JHbiVP+jsO/IYDCqEyt/hJXIWKcoqKN2UAVsS3GbfIGuyNQna+LRE8g/a5MVRb8gCsXQRqrk/t/Jc zfhMPD4FQOmG14rtCtd26ZE3OiXvDlG0sE+1jxgwJdudCcvEfBsO24Fe16zmoxmGBwU0=; Message-ID: <14e22832-6e40-43a4-8dea-1f9b2141b2b4@xen.org> Date: Tue, 8 Aug 2023 23:16:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree Content-Language: en-GB To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20230803104438.24720-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 03/08/2023 11:44, Daniel P. Smith wrote: > ---------------- > +This node describes a boot module loaded by the boot loader. A ``module`` node > +will often appear repeatedly and will require a unique and DTB compliant name > +for each instance. For clarification, do you mean module@? or something different? > The compatible property is required to identify that the > +node is a ``module`` node, the type of boot module, and what it represents. > > -This node describes a boot module loaded by the boot loader. The required > -compatible property follows the format: module, where type can be > -“kernelâ€, “ramdiskâ€, “device-treeâ€, “microcodeâ€, “xsm-policy†or “configâ€. In > -the case the module is a multiboot module, the additional property string > -“multiboot,module†may be present. One of two properties is required and > -identifies how to locate the module. They are the mb-index, used for multiboot > -modules, and the module-addr for memory address based location. > +Depending on the type of boot module, the ``module`` node will require either a > +``module-index`` or ``module-addr`` property must be present. They provide the > +boot module specific way of locating the boot module in memory. > + > +Properties > +"""""""""" > > compatible > This identifies what the module is and thus what the hypervisor > should use the module for during domain construction. Required. > > -mb-index > - This identifies the index for this module in the multiboot module chain. > + Format: "module,"[, "module,"] > + module type: kernel, ramdisk, device-tree, microcode, xsm-policy, > + config All but the last are pretty self-explanatory. Can you clarify what the last one is? > + > + locating type: index, addr It is not clear to me why you need to specify the locating type in the compatible. Would not it be sufficient to check the presence of either module-index or module-addr? If you still want both, then which property belong to which compatible? > + > +module-index > + This identifies the index for this module when in a module chain. > Required for multiboot environments. 'multiboot' is somewhat overloaded as we also use it to describe the binding in the device-tree. So I would clarify which multiboot you are referring to. I assume this is x86 multiboot. That said, my knowledge about it is limited. How would a user be able to find the index to write down here? > > + Format: Integer, e.g. <0> > + > module-addr > This identifies where in memory this module is located. Required for > non-multiboot environments. > > + Format: DTB Reg , e.g. <0x0 0x20000> What is the expected number of cells? > + > bootargs > This is used to provide the boot params to kernel modules. > > + Format: String, e.g. "ro quiet" > + > .. note:: The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain. I realize this wasn't added in your patch. But it is not entirely clear what this means given that an admin may still want to use 'bootargs' even if there is a single kernel. > + > +Example Configuration > +--------------------- > + > +Below are two example device tree definitions for the hypervisor node. The > +first is an example of a multiboot-based configuration for x86 and the second > +is a module-based configuration for Arm. > + > +Multiboot x86 Configuration: > +"""""""""""""""""""""""""""" > + > +:: > + > + /dts-v1/; > + > + / { > + chosen { > + hypervisor { > + compatible = "hypervisor,xen", "xen,x86"; > + > + dom0 { > + compatible = "xen,domain"; > + > + domid = <0>; This is actually a good example where '0' would become confusing because the name of the domain is 'dom0' so one could mistakenly assume that it means domid 0 will be assigned. > + > + role = <9>; Reading this, I wonder if using number is actually a good idea. While this is machine friendly, this is not human friendly. The most human friendly interface would be to use string, but I understand this is more complex to parse. So maybe we could use some pre-processing (like Linux does) to ease the creation of the hyperlaunch DT. Bertrand, Stefano, what do you think? > + mode = <12>; > + > + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 13 F0 8C]; > + > + cpus = <1>; > + memory = "1024M"; > + > + kernel { > + compatible = "module,kernel", "module,index"; > + module-index = <1>; > + }; > + > + initrd { > + compatible = "module,ramdisk", "module,index"; > + module-index = <2>; > + }; > + }; > + > + dom1 { > + compatible = "xen,domain"; > + domid = <1>; > + role = <0>; > + capability = <1>; > + mode = <12>; > + domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 54 1A 74]; > + cpus = <1>; > + memory = "1024M"; > + > + kernel { > + compatible = "module,kernel", "module,index"; > + module-index = <3>; > + bootargs = "console=hvc0 earlyprintk=xen root=/dev/ram0 rw"; > + }; > + > + initrd { > + compatible = "module,ramdisk", "module,index"; > + module-index = <4>; > + }; > + }; > + }; > + }; > + }; > + > + > + > +The multiboot modules supplied when using the above config would be, in order: > + > +* (the above config, compiled) > +* kernel for PVH unbounded domain > +* ramdisk for PVH unbounded domain > +* kernel for PVH guest domain > +* ramdisk for PVH guest domain > + > +Module Arm Configuration: > +""""""""""""""""""""""""" > + > +:: > + > + /dts-v1/; > + > + / { > + chosen { > + hypervisor { > + compatible = “hypervisor,xen†> + > + // Configuration container > + config { > + compatible = "xen,config"; > + > + module { > + compatible = "module,xsm-policy"; > + module-addr = <0x0000ff00 0x80>; > + > + }; > + }; > + > + // Unbounded Domain definition > + dom0 { > + compatible = "xen,domain"; > + > + domid = <0>; > + > + role = <9>; > + > + mode = <12>; /* 64 BIT, PVH */ Arm guest have similar feature compare to PVH guest but they are strictly not the same. So we have been trying to avoid using the term on Arm. I would prefer if we continue to avoid using the word 'PVH' to describe Arm. Lets just call them 'Arm guest'. > + > + memory = <0x0 0x20000>; Here you use the integer version, but AFAICT this wasn't described in the binding above. > + security-id = “dom0_tâ€; > + > + module { > + compatible = "module,kernel"; > + module-addr = <0x0000ff00 0x80>; Reading the binding, this is suggest that the first cell is the start address and the second is the size. Cells are 32-bits. So what if you have a 64-bit address? For 'reg' property, the DT addressed this by using #address-cells and #size-cells to indicate the number of cells for each. > + bootargs = "console=hvc0"; > + }; > + module { > + compatible = "module,ramdisk"; > + module-addr = <0x0000ff00 0x80>; > + }; > + }; > + }; > + }; > + }; > + > +The modules that would be supplied when using the above config would be: > + > +* (the above config, compiled into hardware tree) > +* XSM policy > +* kernel for unbounded domain > +* ramdisk for unbounded domain > +* kernel for guest domain > +* ramdisk for guest domain > + > +The hypervisor device tree would be compiled into the hardware device tree and > +provided to Xen using the standard method currently in use. It is not clear what you mean by 'compiled in'. Do you mean the /hypervisor node will be present in the device-tree provided to Xen? > The remaining > +modules would need to be loaded in the respective addresses specified in the > +`module-addr` property. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Aug 08 22:17:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 22:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580520.908769 (Exim 4.92) (envelope-from ) id 1qTV1J-0006g5-TU; Tue, 08 Aug 2023 22:17:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580520.908769; Tue, 08 Aug 2023 22:17:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV1J-0006fy-OW; Tue, 08 Aug 2023 22:17:41 +0000 Received: by outflank-mailman (input) for mailman id 580520; Tue, 08 Aug 2023 22:17:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV1I-0006Zt-Jk for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 22:17:40 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61a14670-3639-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 00:17:38 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691533052569825.8071215817118; Tue, 8 Aug 2023 15:17:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61a14670-3639-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691533055; cv=none; d=zohomail.com; s=zohoarc; b=gS49CPn7XdvuzrO5jPQIp9d4UZd2rGtphjZGtTxInZZlaJKHHeOV18f5IvLvhHuGehbyAbby1AWlafxXP0LZnXgxW5pUUNzx24W0It7d5qbBjMhP8Biym75yB3ubi14jUSa/H3/i2xWw/kZBiqmZNw3DagJ7Z3f0pas0NV3+fZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691533055; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=XcpGlMEf5qRPH3+rRcZXT5HOscVJRVyIaVj+3He1MN0=; b=dWi/eHCuS+A8vuZ0i+0X7bLVczmZuWAygQVGw7fyFbPiFyuz2RWYUcAtQVjg9llvSauUjC4lqTkpEX9CndocEHjAeh9JBYqkxc8u9hJasLK6Euamz8qsL7TbwA/ZveoNTUdoC0qhwz3eQmT4n/BmhCzR2VxLr0hvITNQlUEm9EI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691533055; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=XcpGlMEf5qRPH3+rRcZXT5HOscVJRVyIaVj+3He1MN0=; b=u0jN4Qihbi8YV2KvHoYxnyV4yn/paZ6lKIV0K+bLmR07PaoA/AOSUGfJr8UE93yj yDuwN/HsA2T4vbU5LExOM3fFNfeaDQp43AOOwYEL63x9JfR7BXWI4NMhkUsbd94lh79 gVv78TofvEOgkxv9ESQGZ6ACCkdQpY/SzY63t/zM= Message-ID: <119710f3-82b1-2066-5fa0-164bd293836e@apertussolutions.com> Date: Tue, 8 Aug 2023 18:17:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: Stefano Stabellini Cc: Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 16:19, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Daniel P. Smith wrote: >> On 8/1/23 20:54, Stefano Stabellini wrote: >>> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>>> The existing concepts such as unbounded domain, ie. all powerful, control >>>> domain and hardware domain are, effectively, roles the domains provide for >>>> the >>>> system. Currently, these are represented with booleans within `struct >>>> domain` >>>> or global domid variables that are compared against. This patch begins to >>>> formalize these roles by replacing the `is_control` and `is_console`, >>>> along >>>> with expanding the check against the global `hardware_domain` with a >>>> single >>>> encapsulating role attribute in `struct domain`. >>>> >>>> Signed-off-by: Daniel P. Smith >>> >>> This is definitely heading in the right direction >> >> Thank you, it is good to know there is some agreement here. >> >>>> --- >>>> xen/arch/arm/domain_build.c | 2 ++ >>>> xen/arch/x86/setup.c | 2 ++ >>>> xen/common/domain.c | 14 +++++++++++++- >>>> xen/include/xen/sched.h | 16 +++++++++------- >>>> xen/include/xsm/dummy.h | 4 ++-- >>>> xen/xsm/flask/hooks.c | 12 ++++++------ >>>> 6 files changed, 34 insertions(+), 16 deletions(-) >>>> >>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>>> index 39b4ee03a5..51b4daefe1 100644 >>>> --- a/xen/arch/arm/domain_build.c >>>> +++ b/xen/arch/arm/domain_build.c >>>> @@ -4201,6 +4201,8 @@ void __init create_dom0(void) >>>> if ( IS_ERR(dom0) ) >>>> panic("Error creating domain 0 (rc = %ld)\n", PTR_ERR(dom0)); >>>> + dom0->role |= ROLE_UNBOUNDED_DOMAIN; >>> >>> I am not a fan of "UNBOUNDED". Maybe "PRIMARY"? "PRIVILEGED"? "SUPER"? >>> "ROOT"? >>> >>> I also recognize I am not good at naming things so I'll stop here and >>> let other provide better feedback :-) >> >> In first version of hyperlaunch and in the early roles work, I was working to >> move toward eliminating this concept entirely. The reality is this is a model >> that has existed for over 20 years and there are those who accept and embrace >> the model. Introducing the name UNBOUNDED was to at least break the idea that >> the all powerful domain necessarily is the first/initial domain to run. With >> hyperlaunch, there are still security-based scenarios where you might want to >> run a DomB before starting an all privileged domain. I spent quite some time, >> probably more than I should have, to find a good name that expresses what this >> role is. Considering a comment below and a comment by Jan, I am starting to >> think a better way to view it is a domain that assumes all roles in the >> system. So your suggestions of SUPER or ROOT might be more fitting. I >> considered ROLE_ALL, but something about it doesn't sit right with me. With >> that said I welcome the yak shaving of naming to begin. ( ^_^) >> >>> Also, do we actually need unbounded given that it gets replaced with >>> control_domain pretty soon? >> >> Yes, because as mentioned above, this is meant to express a domain that has >> been assigned all roles, for which later the domain may decided to delegate >> the role to another domain. >> >>> I am asking because I think that at least from a safety perspective it >>> would be a problem to run a domain as "unbounded". In a safety system, >>> we wouldn't want anything to be unbounded, not even temporarily at boot. >>> If "unbounded" is removed before running dom0, then of course it is no >>> problem because actually dom0 never gets to run with "unbounded" set. >> >> I think this is were the name UNBOUNDED may have been a bad choice. The >> UNBOUNDED role is dom0. It is the control domain, the hardware domain, the >> Xenstore domain, and the crash domain (if that were to be solidified). >> >>> (I am currently thinking of solving the privilege issue by using XSM and >>> removing most privileges from Dom0.) >> >> I obviously would be a huge advocate of that approach. ( ^_^) > > Thanks for the history, that helps. I was asking because I would like to > make sure that all the options below are possible and easy to achieve: > > 1) traditional dom0 + some traditional domUs booted in a dom0less fashion > 2) only traditional domUs booted in a dom0less fashion (no dom0 at all) > 3) not-godlike-but-still-super dom0 + some traditional domUs booted in a dom0less fashion > 4) domB booting > > This ROLE_ALL domain would be dom0 in 1) and would be domB in 4). > In 2), there is no dom0 so there should also be no ROLE_ALL domain. All > good so far. You are correct that constructing a traditional dom0 would be accomplished by assigning this role. As mentioned over in the hyperlaunch devicetree series that by a domain be a traditional dom0 would not be about ensuring it was give domid 0, but that it was assigned this role. As for domB, no, it would not get the ROLE_ALL. It's purpose is assist the hyperlaunch domain builder with functions that just should not be done inside the hypervisor. A less-than-ideal analogy, is domB is like an initrd for Linux. Like an initrd is an environment that runs in user-space with controlled kernel interfaces to interact with system, domB provides the concept of a domain role that has restricted access to hypervisor interfaces to those needed to configure/setup the domains constructed by the hypervisor. In the roles case, a course-grained common base set of capabilities will need to be determined, but those using FLASK will be able to do fine grained access assignment for more rigid/stringent use cases. Yes, in scenario 2 you provided, no domain would get assigned ROLE_ALL. > In 3), it looked to me that we would be creating a ROLE_ALL domain, then > taking away some of the ROLEs. It doesn't sound right? Let's say that we > want to have a hardware_domain (in the sense of default recipient of > hardware, not necessarily privileged) with dm_ops access, but no domctl > access. How would you go about it? With what is there today for dom0less, you have to go down the path that when dom0less constructs the hwdom, this will trigger dom0 to be demoted to the control domain role before either of them get unpaused. Moving forward to a when hyperlaunch appears, then you would just assign the control domain role to "dom0" and the hardware domain role to "hwdom" and nothing would ever be assigned ROLE_ALL. > Would it be required to go through the ROLE_ALL stage? How does it > compare to the way it would work today without this patch applied? > Today, does XSM kick in after is_privileged is set, effectively being > the same thing as XSM kicking in later and removing some ROLEs after > ROLE_ALL is already set? So, basically nothing is changing? Until hyperlaunch, yes you would have to go through ROLE_ALL, but in dom0less case, as long as the hwdom is one of the domains it constructs, dom0 would never run with that role. Your next question is a bit tricky. XSM is effective fairly early in start_xen() and begins enforcing its policy. The tricky part is that there is functionality and hypervisor behaviors that are not protected behind an XSM hook but where is_privileged, checked via is_control_domain(), is used to controls how they work. There are other places in the code where one would say that DAC is enforced before MAC, specifically one of the is_{control,hardware,xenstore}_domain() is enforced before the fine grained XSM check is made. In most cases this is not an issue, the role can just be given to the domain and the FLASK policy can be relied upon to restrict down. But there are some esoteric cases that could be constructed where this behavior would break the security model. >>>> if ( alloc_dom0_vcpu0(dom0) == NULL ) >>>> panic("Error creating domain 0 vcpu0\n"); >>>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >>>> index 2dbe9857aa..4e20edc3bf 100644 >>>> --- a/xen/arch/x86/setup.c >>>> +++ b/xen/arch/x86/setup.c >>>> @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const >>>> module_t *image, >>>> if ( IS_ERR(d) ) >>>> panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); >>>> + d->role |= ROLE_UNBOUNDED_DOMAIN; >>>> + >>>> init_dom0_cpuid_policy(d); >>>> if ( alloc_dom0_vcpu0(d) == NULL ) >>>> diff --git a/xen/common/domain.c b/xen/common/domain.c >>>> index 8fb3c052f5..0ff1d52e3d 100644 >>>> --- a/xen/common/domain.c >>>> +++ b/xen/common/domain.c >>>> @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) >>>> setup_io_bitmap(dom0); >>>> #endif >>>> + /* >>>> + * "dom0" may have been created under the unbounded role, demote it >>>> from >>>> + * that role, reducing it to the control domain role and any other >>>> roles it >>>> + * may have been given. >>>> + */ >>>> + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); >>>> + dom0->role |= ROLE_CONTROL_DOMAIN; >>> >>> I think we need a better definition of the three roles to understand >>> what this mean. >> >> Definition and as highlighted, a better name. >> >>>> rcu_unlock_domain(dom0); >>>> iommu_hwdom_init(d); >>>> @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, >>>> } >>>> /* Sort out our idea of is_control_domain(). */ >>>> - d->is_privileged = flags & CDF_privileged; >>>> + if ( flags & CDF_privileged ) >>>> + d->role |= ROLE_CONTROL_DOMAIN; >>>> + else >>>> + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ >>>> /* Sort out our idea of is_hardware_domain(). */ >>>> if ( is_initial_domain(d) || domid == hardware_domid ) >>>> @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, >>>> old_hwdom = hardware_domain; >>>> hardware_domain = d; >>>> + d->role |= ROLE_HARDWARE_DOMAIN; >>>> } >>>> TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); >>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >>>> index a9276a7bed..695f240326 100644 >>>> --- a/xen/include/xen/sched.h >>>> +++ b/xen/include/xen/sched.h >>>> @@ -467,8 +467,10 @@ struct domain >>>> #endif >>>> /* is node-affinity automatically computed? */ >>>> bool auto_node_affinity; >>>> - /* Is this guest fully privileged (aka dom0)? */ >>>> - bool is_privileged; >>>> +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) >>>> +#define ROLE_CONTROL_DOMAIN (1U<<1) >>>> +#define ROLE_HARDWARE_DOMAIN (1U<<2) >>> >>> This is a great step in the right direction but I think at least a short >>> in-code comment to explain the difference between the three >> >> Ack. >> >>>> + uint8_t role; >>>> /* Can this guest access the Xen console? */ >>>> bool is_console; >>>> /* Is this guest being debugged by dom0? */ >>>> @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); >>>> static always_inline bool is_initial_domain(const struct domain *d) >>>> { >>>> - static int init_domain_id = 0; >>>> - >>>> - return d->domain_id == init_domain_id; >>>> + return d->role & ROLE_UNBOUNDED_DOMAIN; >>>> } >>> >>> As far as I can tell this is the only functional change in this patch: >>> given that dom0 loses unbounded soon after boot, the "is_initial_domain" >>> checks will start to fail? >> >> Today, dom0 should not lose any of its roles at boot unless dom0less were to >> create a hardware domain. > > I don't understand this sentence. To me, hardware_domain means "default > recipient of hardware devices". It also happens to be traditionally > associated with Dom0, so many privilege checks are hardware_domain > check, although they should be instead control_domain checks. What I am saying is that with this patch, dom0 will retain ROLE_ALL unless a separate hardware domain is constructed. If a separate hardware domain, aka late hardware domain, is created, then dom0 will loose ROLE_ALL and be demoted/limited to only ROLE_CONTROL_DOMAIN and the new late hardware domain will be give ROLE_HARDWARE_DOMAIN. > So if you say "dom0 should not lose any of its roles at boot unless > dom0less were to create a hardware domain", I read it as: > > "dom0 (all powerful) would not lose any of its powers at boot unless we > created dom0 (hardware domain, all powerful) with other domUs at boot > using dom0less." Let's say dom0less set the xen command line parameter hardware_dom=1, and it has a configuration that constructs dom0 and 3 domU. The the first domU constructed would result in dom0 get limited to ROLE_CONTROL_DOMAIN and dom1 would be given ROLE_HARDWARE_DOMAIN. What I would advise against, as I think it would end up crashing Xen, is if you gave dom0less a configuration with command line parameter hardware_dom=1, no dom0 and 3 domU. This would trigger the late_hwdom_init() which would it ASSERT(dom0 != NULL) and crash the hypervisor. > which I don't understand Did the above help? >> Upon reflection, I am thinking this check might want renaming to align with >> the rename of this role. >> >>> We have a few of them in the code and I couldn't rule out that at least >>> these 3 could happen at runtime: >>> >>> xen/common/sched/core.c: else if ( is_initial_domain(d) && >>> opt_dom0_vcpus_pin ) >>> xen/common/sched/core.c: else if ( is_initial_domain(d) ) >>> xen/common/sched/arinc653.c: if ( is_initial_domain(unit->domain) ) >>> >>> Maybe they need to be changed to control_domain checks? >> >> Perhaps, I would want to study them a bit before switching them over. > > +1 From xen-devel-bounces@lists.xenproject.org Tue Aug 08 22:21:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 22:21:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580528.908777 (Exim 4.92) (envelope-from ) id 1qTV5K-0008AT-Ab; Tue, 08 Aug 2023 22:21:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580528.908777; Tue, 08 Aug 2023 22:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV5K-0008AM-7z; Tue, 08 Aug 2023 22:21:50 +0000 Received: by outflank-mailman (input) for mailman id 580528; Tue, 08 Aug 2023 22:21:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTV5I-0008AG-9y for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 22:21:48 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4d1e5f9-3639-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 00:21:45 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 169153329184280.73507637940781; Tue, 8 Aug 2023 15:21:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4d1e5f9-3639-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691533294; cv=none; d=zohomail.com; s=zohoarc; b=S5UbPESoyGc4fJ9i3MzznzVVl8DXErgTlpt56beSU85PhS55JSwlsYOUH+AMkWx3ADoSoE9U9pi2pxYvTT4kty3a05N93HYqrSbhXcbqTvBFYSDX7tKcgI3qmp8xTkZOnp99BZ4jJy1R8Y2jGsH840LXglaCYh/O2gZyBEoWF9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691533294; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=88j7gu/5pbiHC2iyQK4RrtMPtJazFeuz6Ak0rV88tXc=; b=m2WjCTUlCpe0wKwFNb1dHj+o/l1R+gSpfaU7PWZU0GVoxE/2pk4e1hpV+bXRAW/2fx5fHMIfMKwaOUi0o6KREiHG56vSXRlRQv4PKuMpcTKp7JAGr2FJxi/W/mXDDEBMpRYm4tpH752+c7yN/RzctsqxZmkZVGS8k0ECBKhWRgc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691533294; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=88j7gu/5pbiHC2iyQK4RrtMPtJazFeuz6Ak0rV88tXc=; b=XJ9QxwP1vHqD28YG9/xJUoIpe6ZbeIt5+yXIHczlCZW1YUqmO5eFLKb+oVjMC8uL a37LdDQWNimp6eDD8O0VQy0BlagAgAQLwCNoJ5lx4et6gv6Kl8KRBs8aAwibFlgjeKF pgov/DVQLqBwgh8j44ByZT+2zjcjd2TiHyazWPdM= Message-ID: Date: Tue, 8 Aug 2023 18:21:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/8/23 11:15, Jan Beulich wrote: > On 01.08.2023 22:20, Daniel P. Smith wrote: >> @@ -1076,7 +1076,8 @@ static always_inline bool is_hardware_domain(const struct domain *d) >> if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) >> return false; >> >> - return evaluate_nospec(d == hardware_domain); >> + return evaluate_nospec(((d->role & ROLE_HARDWARE_DOMAIN) || >> + is_initial_domain(d)) && (d == hardware_domain)); >> } >> >> /* This check is for functionality specific to a control domain */ >> @@ -1085,7 +1086,8 @@ static always_inline bool is_control_domain(const struct domain *d) >> if ( IS_ENABLED(CONFIG_PV_SHIM_EXCLUSIVE) ) >> return false; >> >> - return evaluate_nospec(d->is_privileged); >> + return evaluate_nospec((d->role & ROLE_CONTROL_DOMAIN) || >> + is_initial_domain(d)); >> } > > Why these complicated conditions, and not just the check of the single > relevant role bit? (Also note that indentation used here doesn't really > match our expectations, but there are other style issues in the patch > as well, which I assume is okay for an RFC.) They go away with suggestion to move ROLE_UNBOUNDED a concatenation of all the other roles. Ack on the style. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 22:31:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 22:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580535.908787 (Exim 4.92) (envelope-from ) id 1qTVEw-0001KK-D0; Tue, 08 Aug 2023 22:31:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580535.908787; Tue, 08 Aug 2023 22:31:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVEw-0001KD-AB; Tue, 08 Aug 2023 22:31:46 +0000 Received: by outflank-mailman (input) for mailman id 580535; Tue, 08 Aug 2023 22:31:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVEv-0001K7-6H for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 22:31:45 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 593e7257-363b-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 00:31:43 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691533898593224.91657336270953; Tue, 8 Aug 2023 15:31:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 593e7257-363b-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691533899; cv=none; d=zohomail.com; s=zohoarc; b=eGWJ45Z2fb64MaWqGYJLo/rxei9X9M2+d4WskopTEu4DFJ9r113JWJ3THa3o+ZQEhsQchQ/WQ8rDeSfwVQ3zcELzXw+K3KLgB8qd4QAhkool96aIrzRMrmNOQeh4B1ae48f6VHpdGDMOBzrJK9bikLP0qlOxkDXHhLFmYJChoIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691533899; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=4UzpQ0OMpp/sjYWeLMxe4Hy3t+xUFbjxQS08RimHyQ8=; b=ZM/q5OLf+XNDDg5E6AYyxZ7JyxGDEueTCyxP9etDCDE9OKkYiBlAXXO6wbOMGTNF5WKoasBBSR7So2wT7VIz+Q/u8srhTWZ+ptuOtb/rpCuOKpPYtBS1PoIe4k+k4F4KZPopgZxyk2VFlWXJtj2kQmVN+8ipDU4JTjaipO0Dcbo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691533899; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=4UzpQ0OMpp/sjYWeLMxe4Hy3t+xUFbjxQS08RimHyQ8=; b=VBx/6geEBP9wzVMco7zzVOyWhUA4yyAe2IaYBX8Me86jZ73mRtsnXB/qSwYE5VCo KNsOSx63Vvcqv5OGvbkP8kh2GOzp3qJAJYbf3RVk4hGoo0pJlS+hqmianc1QHZAvZnV WRvK/ZM4Uyw1U5LGIz6CgWbr1K5FgWq1RdQuEEy8= Message-ID: <3decc6de-8d82-a862-36a8-9ddcd94fac4f@apertussolutions.com> Date: Tue, 8 Aug 2023 18:31:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-US To: Julien Grall , Stefano Stabellini Cc: Volodymyr Babchuk , xen-devel@lists.xenproject.org, Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> <14346689-8276-3c26-91e1-59bc2328518e@apertussolutions.com> <423f86e7-10ee-134e-7683-e15f7e2c64ed@xen.org> From: "Daniel P. Smith" In-Reply-To: <423f86e7-10ee-134e-7683-e15f7e2c64ed@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/3/23 17:24, Julien Grall wrote: > Hi Daniel, > > On 03/08/2023 16:41, Daniel P. Smith wrote: >> On 8/1/23 21:01, Stefano Stabellini wrote: >>> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>>> patch the field is renamed to capabilities to encapsulate the >>>> capabilities a >>>> domain has been granted. The first capability being the ability to >>>> read/write >>>> the Xen console. >>>> >>>> Signed-off-by: Daniel P. Smith >>> >>> Patch looks fine to me aside the two minor nits. I am not sure I >>> understand 100% the difference between capabilities and roles but I am >>> OK with the patch. I'd like to hear Julien's feedback on this as well. >> >> This might be worth a section in the hypervisor-guide. As mentioned in >> the cover letter, this was originally proposed as being under XSM. A >> challenge I ran into is that, depending on your view, the >> `is_privileged` field and `hardware_domain` global were either abused >> as a function check and a non-resource privilege check or are just >> multifaceted variables. This is why the concept of the role was struck >> upon, it is more intuitive (for me at least) that have a role is >> something that imparts accesses (privilege checks) and dictates >> hypervisor behaviors when handling the domain (function checks). This >> then brings us to an access or behavior that may be inherent to some >> role(s) but may want to grant on an individually to a guest. A prime >> example of this is console_io, for which it is inherent that the >> hardware domain role will have access but may want to grant to a guest >> without granting it an entire role. This is why I provided for >> identifying these capabilities so that they may be assigned >> individually to a domain. > > Thanks for the explanation. Just to confirm my understanding, what you > are suggesting is that for a given role, a domain will at least have the > matching capabilities (more could be granted). Is that correct? > > If so, this wouldn't this mean we can remove d->role and simply use > d->capabilities? We could start out with CAP_CTRL and CAP_HW, but it is a little illogical. For instance, control domain has many capabilities, they just have never been fully broken out. XSM did some, but the focus there was just on system resources. Similar with the hardware domain. You are right that it would better deal with the limited number of bits currently available. >> >> While the role/capability is a natural progression from how the >> hypervisor currently operates. Another approach that could be consider >> to deliver a similar experience would be to break down every access >> and function into a capability and then define the standard roles as a >> conglomeration of certain capabilities. > > At least from the explanation above, I think it would make sense to > break down role to multiple capabilities. Would it be acceptable to do this incrementally over time as we are able to determine what needs to be broken out as a distinct capability? From xen-devel-bounces@lists.xenproject.org Tue Aug 08 22:40:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 22:40:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580541.908799 (Exim 4.92) (envelope-from ) id 1qTVNc-0002qR-9g; Tue, 08 Aug 2023 22:40:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580541.908799; Tue, 08 Aug 2023 22:40:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVNc-0002qK-5C; Tue, 08 Aug 2023 22:40:44 +0000 Received: by outflank-mailman (input) for mailman id 580541; Tue, 08 Aug 2023 22:40:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVNb-0002qA-Bl; Tue, 08 Aug 2023 22:40:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVNb-0001bm-1G; Tue, 08 Aug 2023 22:40:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVNa-0007B4-Gk; Tue, 08 Aug 2023 22:40:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTVNa-0001jM-Fo; Tue, 08 Aug 2023 22:40:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3lX48N2Vi0PeEXioaUxXwEKB4Q0uYvFP1VNCzn7oZNI=; b=Ci1GpzcvJUKpF0eSvpxHItb3NI stClERufW+Qul8Lya6oU0IZrtl+Mkt60rUEmyUAkc0pbR8Iu4R/pmsSnVERGe+9tKrXt3DNS0REdH O3bfWP4vxFfmDyebAQFb36Pqjzeig2/ldub64zLkp76U3CujAW0d2Bd2ytl1J++agoTg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182227: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:guest-start/redhat.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d3be806dae9c122fe94702cd9fa2e358a60828cd X-Osstest-Versions-That: xen=e55146071de9257d70bd157047700071d0007622 From: osstest service owner Date: Tue, 08 Aug 2023 22:40:42 +0000 flight 182227 xen-unstable real [real] flight 182240 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182227/ http://logs.test-lab.xenproject.org/osstest/logs/182240/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail pass in 182240-retest test-amd64-i386-examine-uefi 6 xen-install fail pass in 182240-retest test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail pass in 182240-retest test-amd64-i386-qemuu-rhel6hvm-amd 14 guest-start/redhat.repeat fail pass in 182240-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182210 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182210 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182210 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182210 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182210 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182210 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182210 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182210 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182210 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182210 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182210 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182210 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen d3be806dae9c122fe94702cd9fa2e358a60828cd baseline version: xen e55146071de9257d70bd157047700071d0007622 Last test of basis 182210 2023-08-07 01:52:04 Z 1 days Failing since 182221 2023-08-07 18:40:18 Z 1 days 2 attempts Testing same since 182227 2023-08-08 07:17:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alejandro Vallejo Andrew Cooper Dario Faggioli Federico Serafini Gianluca Luparini Gianluca Luparini Henry Wang Jan Beulich Michal Orzel Nicola Vetrini Simone Ballarin Stefano Stabellini Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e55146071d..d3be806dae d3be806dae9c122fe94702cd9fa2e358a60828cd -> master From xen-devel-bounces@lists.xenproject.org Tue Aug 08 22:49:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 22:49:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580569.908888 (Exim 4.92) (envelope-from ) id 1qTVVu-0004O3-Vq; Tue, 08 Aug 2023 22:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580569.908888; Tue, 08 Aug 2023 22:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVVu-0004Nw-RY; Tue, 08 Aug 2023 22:49:18 +0000 Received: by outflank-mailman (input) for mailman id 580569; Tue, 08 Aug 2023 22:49:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTVVt-0004No-LW for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 22:49:17 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbed0d3d-363d-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 00:49:15 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691534949515220.7474258351242; Tue, 8 Aug 2023 15:49:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbed0d3d-363d-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; t=1691534952; cv=none; d=zohomail.com; s=zohoarc; b=bLuua5r1LGNNx9rs9d8ELD99e5LrC+mFsCiHru+q1Li8jWTDNs+sZ0kkoSwnWDp4Ffrf0DLH0vPfJGX4dWk/jzGdSdE5D25T0y9zUiAbUjm8PTpuXaDBS0tiqZWL3mteZln2cMQZJRHRbTnPjtuBV5CczyoEityoC9e3pvrpGhM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691534952; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WgoM135m2U7UBiCaQNsuLm8Ol43KKt1u10XOAsqh1Jg=; b=MqaUT7gohEQ9H+UhBjd5Uyugu+kJyCdfw6RlzprwBUm5KH6FrVifgUPmBXUusnT8Rb0W+RVrMNTxZeOtFqbgdpuRbzvDuvqOV0qgVvWC1xodgSxRE0tDkpE1Oax36cjqQh4CkNdWxAhZxMxO/EV7uv1wD9/Sjz7ippx9/GR7hLI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691534952; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WgoM135m2U7UBiCaQNsuLm8Ol43KKt1u10XOAsqh1Jg=; b=L/VMeVVlrVWPRTcgIcaIIwIBM+ix1ERKqxFvnMeDsCzQZdfljupnN46upoLbW15X lsaHaZEM69xRN6DUmo6GQX9hIm/hbaFZAKdqJeGGNF5iX2qXOnWuG1+LWggxcNrqNqh x72ThNy3TDGTbutGrpJO7FPZHGbCEKS8jlwaROfc= Message-ID: <7a10af10-27c7-257e-9564-2716c67bb400@apertussolutions.com> Date: Tue, 8 Aug 2023 18:49:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-US To: Julien Grall , Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> <8951f722-6949-b2b5-f6d4-2d515f085cde@xen.org> From: "Daniel P. Smith" In-Reply-To: <8951f722-6949-b2b5-f6d4-2d515f085cde@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 8/3/23 17:03, Julien Grall wrote: > Hi, Greetings > On 01/08/2023 21:20, Daniel P. Smith wrote: >> The field `is_console` suggests that the field represents a state of >> being or >> posession, not that it reflects the privilege to access the console. >> In this >> patch the field is renamed to capabilities to encapsulate the >> capabilities a >> domain has been granted. The first capability being the ability to >> read/write >> the Xen console. >> >> Signed-off-by: Daniel P. Smith >> --- >>   xen/arch/arm/domain_build.c |  4 +++- >>   xen/include/xen/sched.h     | 25 +++++++++++++++++++++++-- >>   xen/include/xsm/dummy.h     |  2 +- >>   3 files changed, 27 insertions(+), 4 deletions(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 51b4daefe1..ad7432b029 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -4076,7 +4076,9 @@ void __init create_domUs(void) >>               panic("Error creating domain %s (rc = %ld)\n", >>                     dt_node_name(node), PTR_ERR(d)); >> -        d->is_console = true; >> +        if ( ! domain_set_cap(d, CAP_CONSOLE_IO) ) > > Coding style: We don't usually add a space after '!'. Ack. >> +            printk("failed setting console_io on %pd\n", d); > > I find a bit odd that we would continue even if the cap cannot be set. > Can you clarify? This is the construction of a domU, so the system is very much capable of coming up and reviewing the hypervisor messages from dom0 to discover the issue. I am hard pressed to believe the hypervisor should be panicked because the domU is not allowed to use the hypervisor's console. g>> + >>           dt_device_set_used_by(node, d->domain_id); >>           rc = construct_domU(d, node); >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index ec0f9baff6..b04fbe0565 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -472,8 +472,8 @@ struct domain >>   #define ROLE_HARDWARE_DOMAIN   (1U<<2) >>   #define ROLE_XENSTORE_DOMAIN   (1U<<3) >>       uint8_t          role; >> -    /* Can this guest access the Xen console? */ >> -    bool             is_console; >> +#define CAP_CONSOLE_IO  (1U<<0) > Coding style: Space before and after <<. Ack. >> +    uint8_t          capabilities; >>       /* Is this guest being debugged by dom0? */ >>       bool             debugger_attached; >>       /* >> @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const >> struct vcpu *v) >>       return is_hvm_domain(v->domain); >>   } >> +static always_inline bool domain_has_cap( >> +    const struct domain *d, uint8_t cap) > > Coding style: We don't usually wrap the arguments this way. See > domain_create() for an example. I was informed it was[1], also, please see next_domain_in_cpupool() amongst many others further below. [1] https://lists.xenproject.org/archives/html/xen-devel/2021-07/msg01133.html >> +{ >> +    return d->capabilities & cap; >> +} >> + >> +static always_inline bool domain_set_cap( >> +    struct domain *d, uint8_t cap) > > Same about the coding style here. Ditto. > Also, do you expect the cap to be set only when the domain is created? > If not, would you prevent potentially concurrent update to d->capabilities? Currently the only means being devise to set this is via hyperlaunch domain creation. If a domctl op was added to be able to manipulate the caps, then yes a lock on the domain would be advised to block. With that said, if we switch over to CAP_CTRL/HW, then it might be good to grab a lock on the domain for the late hardware domain case. >> +{ >> +    switch ( cap ) >> +    { >> +    case CAP_CONSOLE_IO: >> +        d->capabilities |= cap; >> +        break; >> +    default: > > Is this meant to be reached? If not, maybe add ASSERT_UNREACHABLE()? Yah, that would be a good idea. >> +        return false; >> +    } >> + >> +    return domain_has_cap(d, cap); >> +} > + >>   static always_inline bool hap_enabled(const struct domain *d) >>   { >>       /* sanitise_domain_config() rejects HAP && !HVM */ >> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h >> index 18f1ddd127..067ff1d111 100644 >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h >> @@ -268,7 +268,7 @@ static XSM_INLINE int cf_check xsm_console_io( >>       XSM_DEFAULT_ARG struct domain *d, int cmd) >>   { >>       XSM_ASSERT_ACTION(XSM_OTHER); >> -    if ( d->is_console ) >> +    if ( domain_has_cap(d, CAP_CONSOLE_IO) ) >>           return xsm_default_action(XSM_HOOK, d, NULL); >>   #ifdef CONFIG_VERBOSE_DEBUG >>       if ( cmd == CONSOLEIO_write ) v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 23:22:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 23:22:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580576.908897 (Exim 4.92) (envelope-from ) id 1qTW1g-0000O9-J6; Tue, 08 Aug 2023 23:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580576.908897; Tue, 08 Aug 2023 23:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTW1g-0000O2-G3; Tue, 08 Aug 2023 23:22:08 +0000 Received: by outflank-mailman (input) for mailman id 580576; Tue, 08 Aug 2023 23:22:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTW1f-0000Nw-LS for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 23:22:07 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62b838b3-3642-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 01:22:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E29F762DEE; Tue, 8 Aug 2023 23:22:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57C84C433C7; Tue, 8 Aug 2023 23:22:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62b838b3-3642-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691536923; bh=wkz4QDdS6EOodgWlT5pB8X3kXd5cGOfsF6oFMIZTu7g=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JXwyk83Fmf7HArs2ZHTXy+zLOn8eCzpOpXYsX1YVRzYowkcy0+ZQA59aWIlgtZQ+h RyJ/k5ORouWq4WwsEB18DkEsqNfaXXu6s7wCpem2PrLN4lVDkhF3sjfJT7+paltzYt c00Kom/qEta3wjLJIHCaAah5zKJAw+TGXW5pnqyyUfdVleLq8Fh+jssjrbtfg95ikR I+JgUTDGVWgTvm5PbXxn/moFJ9kLnm0g6hyCChqjiawNB4zuQw0posAmQiLtLVLDki GsVUkpUN/nY6fa7lFGeL5csE3IbOAFDCkdmBnox2au8KOTAGp97bLNdU/iaQomYnGo ehEjoejLC3JGQ== Date: Tue, 8 Aug 2023 16:22:00 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Stefano Stabellini , Xen-devel Subject: Re: MISRA violations in hypercall-defs In-Reply-To: <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> Message-ID: References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Jan Beulich wrote: > On 08.08.2023 10:47, Federico Serafini wrote: > > Hello everyone. > > > > I would like to to ask your opinion about the auto-generated file > > xen/include/xen/hypercall-defs.h which contains some violations of > > MISRA C:2012 Rule 8.3: > > "All declarations of an object or function shall use the same names and > > type qualifiers". > > > > Such violations can be seen at the following links > > (copy and paste the link on you browser, including also the characters > > after the '#'): > > > > - arm > > https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} > > > > - x86 > > https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} > > > > Some of the violations are due to mismatches on the return types > > and the use of `ret_t`. > > We already said that ret_t will need deviating. For parameter names > it ought to be possible to suitably rename, like done elsewhere. Whether > that means renaming in the generator script or in the definitions likely > again needs judging on a case-by-case basis. Is it the case that ret_t is purposedly defined as 'long' for 64-bit x86 guests and 'int' for 32-bit x86 guests? I am asking because it looks like we don't use ret_t at all on ARM and on the public interfaces. From xen-devel-bounces@lists.xenproject.org Tue Aug 08 23:33:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 23:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580582.908908 (Exim 4.92) (envelope-from ) id 1qTWCG-0001w5-IX; Tue, 08 Aug 2023 23:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580582.908908; Tue, 08 Aug 2023 23:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWCG-0001vy-FH; Tue, 08 Aug 2023 23:33:04 +0000 Received: by outflank-mailman (input) for mailman id 580582; Tue, 08 Aug 2023 23:33:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWCF-0001vZ-9K for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 23:33:03 +0000 Received: from sender3-of-o58.zoho.com (sender3-of-o58.zoho.com [136.143.184.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e861f0c6-3643-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 01:33:00 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691537573501190.40765713349026; Tue, 8 Aug 2023 16:32:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e861f0c6-3643-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691537576; cv=none; d=zohomail.com; s=zohoarc; b=EBSJmbzn2Rkk06O6cgqX3DQB0dg1wY/I/sp1NglCIifjRAmxqSlHqBPMnQzuS+hcxhqVOZ+GiSAyUNSqKykOpoh1DXWJ87R7W+NRaXtrrTRonA0xnaXSSrgCZU8TH+WSldYliBErJwAEpJw9W4sBxTt8Jnar3j6JWFShTlDDaSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691537576; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yIJghSW8omd3M8TJsuo41CcpbjM/paoBCzdM07Hk/Ik=; b=HNm2K1Qq2wZIb+QE5Os6paD26kL8WvBj16PcQlGTaRB3/bqCBN4ml3LUXMaQPZRTK3O+BQeybRgHRYu/KKxhqSDzyXJWh72bSSRrczdFPEW0AlRE1LwIv5dC3IcKAXMPZWPz9JEgkLR4Kpw3kMy63NoFvWlk/pyTCyrpHNiVndA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691537576; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=yIJghSW8omd3M8TJsuo41CcpbjM/paoBCzdM07Hk/Ik=; b=oJ5g9bh1gcw8AsvQJ29qm60SfQb/mxgjGO3jufa9BIWawDI2PSq0qf0vkExbSBm7 W22onsRHSGxpj1TkD7kHdeDzz00P8hGeak9IEAKkDIDgWQcY0He3UqOQ2GnBJaGSo9h A/1ICT4yKs7jrvVpb57p79ZOV+rn4tbQeGxAuJfA= Message-ID: <810a7e96-9175-aea1-e01f-4f6ae1cbf690@apertussolutions.com> Date: Tue, 8 Aug 2023 19:32:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Wei Liu , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> <72f6cdbb-44a0-d821-1b7a-607e031cde99@suse.com> From: "Daniel P. Smith" In-Reply-To: <72f6cdbb-44a0-d821-1b7a-607e031cde99@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/8/23 11:24, Jan Beulich wrote: > On 01.08.2023 22:20, Daniel P. Smith wrote: >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -472,8 +472,8 @@ struct domain >> #define ROLE_HARDWARE_DOMAIN (1U<<2) >> #define ROLE_XENSTORE_DOMAIN (1U<<3) >> uint8_t role; >> - /* Can this guest access the Xen console? */ >> - bool is_console; >> +#define CAP_CONSOLE_IO (1U<<0) >> + uint8_t capabilities; >> /* Is this guest being debugged by dom0? */ >> bool debugger_attached; >> /* >> @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const struct vcpu *v) >> return is_hvm_domain(v->domain); >> } >> >> +static always_inline bool domain_has_cap( >> + const struct domain *d, uint8_t cap) >> +{ >> + return d->capabilities & cap; >> +} > > What you implement here is effectively domain_has_any_cap(), which I > don't think is of much use. At the very least you want to assert that > cap is a power of two. But perhaps you rather want the caller to pass > in a bit number, not a mask, such that it's obvious that only one > thing can be checked at a time. I did this thinking I was going to save keystrokes and encapsulate the check, but I just double checked and it would have only saved one. I will drop this and put the explicit bit checks at all the check sites. >> +static always_inline bool domain_set_cap( >> + struct domain *d, uint8_t cap) >> +{ >> + switch ( cap ) >> + { >> + case CAP_CONSOLE_IO: >> + d->capabilities |= cap; >> + break; >> + default: >> + return false; >> + } >> + >> + return domain_has_cap(d, cap); >> +} > > The "set" operation doesn't need to be an inline function, does it? I guess not, I can move into common/domain.c. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Aug 08 23:38:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 23:38:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580588.908919 (Exim 4.92) (envelope-from ) id 1qTWHa-0002ZE-6b; Tue, 08 Aug 2023 23:38:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580588.908919; Tue, 08 Aug 2023 23:38:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWHa-0002Z7-26; Tue, 08 Aug 2023 23:38:34 +0000 Received: by outflank-mailman (input) for mailman id 580588; Tue, 08 Aug 2023 23:38:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWHY-0002Z1-Eu for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 23:38:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad8ee705-3644-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 01:38:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C57CD62E3F; Tue, 8 Aug 2023 23:38:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8D15C433C8; Tue, 8 Aug 2023 23:38:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad8ee705-3644-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691537908; bh=6l3NUxE3JGV6lK+c4EEgpFscVvTK57T9LWR6Dzjlivs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=d+sY75+Uevl7oJLRi/mhMHdNw+u3jkduiccm21t9fTQ7zmUcAEk8eMxZsl0afnelg TRqztNZuTKel4FUJAAC5d7aWGJ/SpC6HBWwqr4zs+Qibo1F0x0f9ekOPdLrvy34IKq lKcJKHCzMTQS/lme279m7Jwb6Fw7Krx+kgAYashcLAXQ5TffuG0qZcIkJ1jvBkMFPo bpmCivmgD+Ao+RAQv+JZoAjh4Qgv6ln9kdKHetJXms1n5IaRh+POD2jq7VZHjpRCOD 04FeiWXou+EJIOyw/zkXMtI8+8nzf54GRKbUkmR4Z/1XTTQBc4ikXa+khkiPecNOh4 x4aaNc2RwHbZQ== Date: Tue, 8 Aug 2023 16:38:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Stefano Stabellini , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles In-Reply-To: <119710f3-82b1-2066-5fa0-164bd293836e@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> <119710f3-82b1-2066-5fa0-164bd293836e@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Daniel P. Smith wrote: > On 8/3/23 16:19, Stefano Stabellini wrote: > > On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > > On 8/1/23 20:54, Stefano Stabellini wrote: > > > > On Tue, 1 Aug 2023, Daniel P. Smith wrote: > > > > > The existing concepts such as unbounded domain, ie. all powerful, > > > > > control > > > > > domain and hardware domain are, effectively, roles the domains provide > > > > > for > > > > > the > > > > > system. Currently, these are represented with booleans within `struct > > > > > domain` > > > > > or global domid variables that are compared against. This patch begins > > > > > to > > > > > formalize these roles by replacing the `is_control` and `is_console`, > > > > > along > > > > > with expanding the check against the global `hardware_domain` with a > > > > > single > > > > > encapsulating role attribute in `struct domain`. > > > > > > > > > > Signed-off-by: Daniel P. Smith > > > > > > > > This is definitely heading in the right direction > > > > > > Thank you, it is good to know there is some agreement here. > > > > > > > > --- > > > > > xen/arch/arm/domain_build.c | 2 ++ > > > > > xen/arch/x86/setup.c | 2 ++ > > > > > xen/common/domain.c | 14 +++++++++++++- > > > > > xen/include/xen/sched.h | 16 +++++++++------- > > > > > xen/include/xsm/dummy.h | 4 ++-- > > > > > xen/xsm/flask/hooks.c | 12 ++++++------ > > > > > 6 files changed, 34 insertions(+), 16 deletions(-) > > > > > > > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > > > > index 39b4ee03a5..51b4daefe1 100644 > > > > > --- a/xen/arch/arm/domain_build.c > > > > > +++ b/xen/arch/arm/domain_build.c > > > > > @@ -4201,6 +4201,8 @@ void __init create_dom0(void) > > > > > if ( IS_ERR(dom0) ) > > > > > panic("Error creating domain 0 (rc = %ld)\n", > > > > > PTR_ERR(dom0)); > > > > > + dom0->role |= ROLE_UNBOUNDED_DOMAIN; > > > > > > > > I am not a fan of "UNBOUNDED". Maybe "PRIMARY"? "PRIVILEGED"? "SUPER"? > > > > "ROOT"? > > > > > > > > I also recognize I am not good at naming things so I'll stop here and > > > > let other provide better feedback :-) > > > > > > In first version of hyperlaunch and in the early roles work, I was working > > > to > > > move toward eliminating this concept entirely. The reality is this is a > > > model > > > that has existed for over 20 years and there are those who accept and > > > embrace > > > the model. Introducing the name UNBOUNDED was to at least break the idea > > > that > > > the all powerful domain necessarily is the first/initial domain to run. > > > With > > > hyperlaunch, there are still security-based scenarios where you might want > > > to > > > run a DomB before starting an all privileged domain. I spent quite some > > > time, > > > probably more than I should have, to find a good name that expresses what > > > this > > > role is. Considering a comment below and a comment by Jan, I am starting > > > to > > > think a better way to view it is a domain that assumes all roles in the > > > system. So your suggestions of SUPER or ROOT might be more fitting. I > > > considered ROLE_ALL, but something about it doesn't sit right with me. > > > With > > > that said I welcome the yak shaving of naming to begin. ( ^_^) > > > > > > > Also, do we actually need unbounded given that it gets replaced with > > > > control_domain pretty soon? > > > > > > Yes, because as mentioned above, this is meant to express a domain that > > > has > > > been assigned all roles, for which later the domain may decided to > > > delegate > > > the role to another domain. > > > > > > > I am asking because I think that at least from a safety perspective it > > > > would be a problem to run a domain as "unbounded". In a safety system, > > > > we wouldn't want anything to be unbounded, not even temporarily at boot. > > > > If "unbounded" is removed before running dom0, then of course it is no > > > > problem because actually dom0 never gets to run with "unbounded" set. > > > > > > I think this is were the name UNBOUNDED may have been a bad choice. The > > > UNBOUNDED role is dom0. It is the control domain, the hardware domain, the > > > Xenstore domain, and the crash domain (if that were to be solidified). > > > > > > > (I am currently thinking of solving the privilege issue by using XSM and > > > > removing most privileges from Dom0.) > > > > > > I obviously would be a huge advocate of that approach. ( ^_^) > > > > Thanks for the history, that helps. I was asking because I would like to > > make sure that all the options below are possible and easy to achieve: > > > > 1) traditional dom0 + some traditional domUs booted in a dom0less fashion > > 2) only traditional domUs booted in a dom0less fashion (no dom0 at all) > > 3) not-godlike-but-still-super dom0 + some traditional domUs booted in a > > dom0less fashion > > 4) domB booting > > > > This ROLE_ALL domain would be dom0 in 1) and would be domB in 4). > > In 2), there is no dom0 so there should also be no ROLE_ALL domain. All > > good so far. > > You are correct that constructing a traditional dom0 would be accomplished by > assigning this role. As mentioned over in the hyperlaunch devicetree series > that by a domain be a traditional dom0 would not be about ensuring it was give > domid 0, but that it was assigned this role. > > As for domB, no, it would not get the ROLE_ALL. It's purpose is assist the > hyperlaunch domain builder with functions that just should not be done inside > the hypervisor. A less-than-ideal analogy, is domB is like an initrd for > Linux. Like an initrd is an environment that runs in user-space with > controlled kernel interfaces to interact with system, domB provides the > concept of a domain role that has restricted access to hypervisor interfaces > to those needed to configure/setup the domains constructed by the hypervisor. > In the roles case, a course-grained common base set of capabilities will need > to be determined, but those using FLASK will be able to do fine grained access > assignment for more rigid/stringent use cases. > > Yes, in scenario 2 you provided, no domain would get assigned ROLE_ALL. > > > In 3), it looked to me that we would be creating a ROLE_ALL domain, then > > taking away some of the ROLEs. It doesn't sound right? Let's say that we > > want to have a hardware_domain (in the sense of default recipient of > > hardware, not necessarily privileged) with dm_ops access, but no domctl > > access. How would you go about it? > > With what is there today for dom0less, you have to go down the path that when > dom0less constructs the hwdom, this will trigger dom0 to be demoted to the > control domain role before either of them get unpaused. > > Moving forward to a when hyperlaunch appears, then you would just assign the > control domain role to "dom0" and the hardware domain role to "hwdom" and > nothing would ever be assigned ROLE_ALL. OK > > Would it be required to go through the ROLE_ALL stage? How does it > > compare to the way it would work today without this patch applied? > > Today, does XSM kick in after is_privileged is set, effectively being > > the same thing as XSM kicking in later and removing some ROLEs after > > ROLE_ALL is already set? So, basically nothing is changing? > > Until hyperlaunch, yes you would have to go through ROLE_ALL, but in dom0less > case, as long as the hwdom is one of the domains it constructs, dom0 would > never run with that role. OK, I think we are on the same page. For extra clarity I want to add that in scenario 3) there is no control domain at all. There is only hardware_domain with a few control powers (not many). > Your next question is a bit tricky. XSM is effective fairly early in > start_xen() and begins enforcing its policy. The tricky part is that there is > functionality and hypervisor behaviors that are not protected behind an XSM > hook but where is_privileged, checked via is_control_domain(), is used to > controls how they work. There are other places in the code where one would say > that DAC is enforced before MAC, specifically one of the > is_{control,hardware,xenstore}_domain() is enforced before the fine grained > XSM check is made. In most cases this is not an issue, the role can just be > given to the domain and the FLASK policy can be relied upon to restrict down. > But there are some esoteric cases that could be constructed where this > behavior would break the security model. OK. I understand there are corner cases, but I am also understanding that "nothing is changing" in terms of order of XSM enforcement and deprivilege execution with this patch series? It is not getting "worse" the window of time where Dom0 has ROLE_ALL/is_privileged? > > > > > if ( alloc_dom0_vcpu0(dom0) == NULL ) > > > > > panic("Error creating domain 0 vcpu0\n"); > > > > > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > > > > > index 2dbe9857aa..4e20edc3bf 100644 > > > > > --- a/xen/arch/x86/setup.c > > > > > +++ b/xen/arch/x86/setup.c > > > > > @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const > > > > > module_t *image, > > > > > if ( IS_ERR(d) ) > > > > > panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); > > > > > + d->role |= ROLE_UNBOUNDED_DOMAIN; > > > > > + > > > > > init_dom0_cpuid_policy(d); > > > > > if ( alloc_dom0_vcpu0(d) == NULL ) > > > > > diff --git a/xen/common/domain.c b/xen/common/domain.c > > > > > index 8fb3c052f5..0ff1d52e3d 100644 > > > > > --- a/xen/common/domain.c > > > > > +++ b/xen/common/domain.c > > > > > @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) > > > > > setup_io_bitmap(dom0); > > > > > #endif > > > > > + /* > > > > > + * "dom0" may have been created under the unbounded role, demote > > > > > it > > > > > from > > > > > + * that role, reducing it to the control domain role and any > > > > > other > > > > > roles it > > > > > + * may have been given. > > > > > + */ > > > > > + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); > > > > > + dom0->role |= ROLE_CONTROL_DOMAIN; > > > > > > > > I think we need a better definition of the three roles to understand > > > > what this mean. > > > > > > Definition and as highlighted, a better name. > > > > > > > > rcu_unlock_domain(dom0); > > > > > iommu_hwdom_init(d); > > > > > @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, > > > > > } > > > > > /* Sort out our idea of is_control_domain(). */ > > > > > - d->is_privileged = flags & CDF_privileged; > > > > > + if ( flags & CDF_privileged ) > > > > > + d->role |= ROLE_CONTROL_DOMAIN; > > > > > + else > > > > > + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ > > > > > /* Sort out our idea of is_hardware_domain(). */ > > > > > if ( is_initial_domain(d) || domid == hardware_domid ) > > > > > @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, > > > > > old_hwdom = hardware_domain; > > > > > hardware_domain = d; > > > > > + d->role |= ROLE_HARDWARE_DOMAIN; > > > > > } > > > > > TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); > > > > > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > > > > > index a9276a7bed..695f240326 100644 > > > > > --- a/xen/include/xen/sched.h > > > > > +++ b/xen/include/xen/sched.h > > > > > @@ -467,8 +467,10 @@ struct domain > > > > > #endif > > > > > /* is node-affinity automatically computed? */ > > > > > bool auto_node_affinity; > > > > > - /* Is this guest fully privileged (aka dom0)? */ > > > > > - bool is_privileged; > > > > > +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) > > > > > +#define ROLE_CONTROL_DOMAIN (1U<<1) > > > > > +#define ROLE_HARDWARE_DOMAIN (1U<<2) > > > > > > > > This is a great step in the right direction but I think at least a short > > > > in-code comment to explain the difference between the three > > > > > > Ack. > > > > > > > > + uint8_t role; > > > > > /* Can this guest access the Xen console? */ > > > > > bool is_console; > > > > > /* Is this guest being debugged by dom0? */ > > > > > @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); > > > > > static always_inline bool is_initial_domain(const struct domain > > > > > *d) > > > > > { > > > > > - static int init_domain_id = 0; > > > > > - > > > > > - return d->domain_id == init_domain_id; > > > > > + return d->role & ROLE_UNBOUNDED_DOMAIN; > > > > > } > > > > > > > > As far as I can tell this is the only functional change in this patch: > > > > given that dom0 loses unbounded soon after boot, the "is_initial_domain" > > > > checks will start to fail? > > > > > > Today, dom0 should not lose any of its roles at boot unless dom0less were > > > to > > > create a hardware domain. > > > > I don't understand this sentence. To me, hardware_domain means "default > > recipient of hardware devices". It also happens to be traditionally > > associated with Dom0, so many privilege checks are hardware_domain > > check, although they should be instead control_domain checks. > > What I am saying is that with this patch, dom0 will retain ROLE_ALL unless a > separate hardware domain is constructed. If a separate hardware domain, aka > late hardware domain, is created, then dom0 will loose ROLE_ALL and be > demoted/limited to only ROLE_CONTROL_DOMAIN and the new late hardware domain > will be give ROLE_HARDWARE_DOMAIN. > > > So if you say "dom0 should not lose any of its roles at boot unless > > dom0less were to create a hardware domain", I read it as: > > > > "dom0 (all powerful) would not lose any of its powers at boot unless we > > created dom0 (hardware domain, all powerful) with other domUs at boot > > using dom0less." > > Let's say dom0less set the xen command line parameter hardware_dom=1, and it > has a configuration that constructs dom0 and 3 domU. The the first domU > constructed would result in dom0 get limited to ROLE_CONTROL_DOMAIN and dom1 > would be given ROLE_HARDWARE_DOMAIN. What I would advise against, as I think > it would end up crashing Xen, is if you gave dom0less a configuration with > command line parameter hardware_dom=1, no dom0 and 3 domU. This would trigger > the late_hwdom_init() which would it ASSERT(dom0 != NULL) and crash the > hypervisor. Thanks for the example, it is finally clear! I don't think we should add hardware_dom=1 to the command line (I don't know if it was just an example to make it easier to understand for me). Instead it should a property on device tree. hardware_dom=1 is not great because it is tied to the order of domain construction. Instead it should be a device tree property under the specific domain. That way you can clearly specify which one is tradition dom0, or which is hardware_domain and which is control_domain. > > which I don't understand > > Did the above help? A lot, thanks! > > > Upon reflection, I am thinking this check might want renaming to align > > > with > > > the rename of this role. > > > > > > > We have a few of them in the code and I couldn't rule out that at least > > > > these 3 could happen at runtime: > > > > > > > > xen/common/sched/core.c: else if ( is_initial_domain(d) && > > > > opt_dom0_vcpus_pin ) > > > > xen/common/sched/core.c: else if ( is_initial_domain(d) ) > > > > xen/common/sched/arinc653.c: if ( is_initial_domain(unit->domain) ) > > > > > > > > Maybe they need to be changed to control_domain checks? > > > > > > Perhaps, I would want to study them a bit before switching them over. > > > > +1 > From xen-devel-bounces@lists.xenproject.org Tue Aug 08 23:59:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 08 Aug 2023 23:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580595.908928 (Exim 4.92) (envelope-from ) id 1qTWc1-000559-S0; Tue, 08 Aug 2023 23:59:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580595.908928; Tue, 08 Aug 2023 23:59:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWc1-000552-On; Tue, 08 Aug 2023 23:59:41 +0000 Received: by outflank-mailman (input) for mailman id 580595; Tue, 08 Aug 2023 23:59:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWbz-00054w-MT for xen-devel@lists.xenproject.org; Tue, 08 Aug 2023 23:59:39 +0000 Received: from sender3-of-o57.zoho.com (sender3-of-o57.zoho.com [136.143.184.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9fa2066b-3647-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 01:59:36 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1691539168302242.3678362872048; Tue, 8 Aug 2023 16:59:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fa2066b-3647-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691539169; cv=none; d=zohomail.com; s=zohoarc; b=E97/EQ4Rd/ItcjCrL9baRh8iy1jdUfPcjAYrphTDuSppIPSIHZdmennI8yA5RTuH8/NrJk13eXmO7KLQMfLJcUeDQ+vh6YVZUtnsw/CxfXVADXCVwR24ahX9QFwHuJtcEm7pHW6sqiNr8U1XoR4NR/n1yj6UZuj5GunXSOjULfk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691539169; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=b7arqanQZaKrseLp8T3E5x22B2H7nmPRA4KWnM7oBUo=; b=PXSE+j55WkuaAiU5vqA2xHecWxUSl918r/GctxvbCtSqF9tsHjDJ1k7KkoLoxXX+/lGxhk/FWc9lVJPcVPCN/NI1ToB3S6NeA85UeCESouGZkyWvMsQghYsnaa0NMnLdS5mUqj7iMyZUDjemHHEfSh65yyeAYPcUTwa3GezgIQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691539169; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=b7arqanQZaKrseLp8T3E5x22B2H7nmPRA4KWnM7oBUo=; b=GChef75QLMo+fqpJY/F7pTWyK7WEO+Z98V6szlB0fb8J7xIjrK5/ecc63Jxdorzo 2Dy7uTEHfC3EA/nDZMPM95nqthv5qvyPEPjgKKrMF5I1byu3QIi9h1mlI/xwFPGYoMH iu6KyhpegGwCr46VELlKRujbSv19Hf/t0UGgwiIk= Message-ID: <331ee5de-3c90-2e3f-ef1c-914a2cbf14cf@apertussolutions.com> Date: Tue, 8 Aug 2023 19:59:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 5/6] capabilities: add dom0 cpu faulting disable Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-6-dpsmith@apertussolutions.com> <93750d64-07b3-2a92-4851-bcd5bda9a0a5@suse.com> From: "Daniel P. Smith" In-Reply-To: <93750d64-07b3-2a92-4851-bcd5bda9a0a5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/8/23 11:30, Jan Beulich wrote: > On 01.08.2023 22:20, Daniel P. Smith wrote: >> --- a/xen/arch/x86/cpu/common.c >> +++ b/xen/arch/x86/cpu/common.c >> @@ -164,48 +164,46 @@ static void set_cpuid_faulting(bool enable) >> >> void ctxt_switch_levelling(const struct vcpu *next) >> { >> - const struct domain *nextd = next ? next->domain : NULL; >> - bool enable_cpuid_faulting; >> - >> - if (cpu_has_cpuid_faulting || >> - boot_cpu_has(X86_FEATURE_CPUID_USER_DIS)) { >> - /* >> - * No need to alter the faulting setting if we are switching >> - * to idle; it won't affect any code running in idle context. >> - */ >> - if (nextd && is_idle_domain(nextd)) >> - return; >> - /* >> - * We *should* be enabling faulting for PV control domains. >> - * >> - * The domain builder has now been updated to not depend on >> - * seeing host CPUID values. This makes it compatible with >> - * PVH toolstack domains, and lets us enable faulting by >> - * default for all PV domains. >> - * >> - * However, as PV control domains have never had faulting >> - * enforced on them before, there might plausibly be other >> - * dependenices on host CPUID data. Therefore, we have left >> - * an interim escape hatch in the form of >> - * `dom0=no-cpuid-faulting` to restore the older behaviour. >> - */ >> - enable_cpuid_faulting = nextd && (opt_dom0_cpuid_faulting || >> - !is_control_domain(nextd) || >> - !is_pv_domain(nextd)) && >> - (is_pv_domain(nextd) || >> - next->arch.msrs-> >> - misc_features_enables.cpuid_faulting); >> - >> - if (cpu_has_cpuid_faulting) >> - set_cpuid_faulting(enable_cpuid_faulting); >> - else >> - amd_set_cpuid_user_dis(enable_cpuid_faulting); >> - >> - return; >> - } >> - >> - if (ctxt_switch_masking) >> - alternative_vcall(ctxt_switch_masking, next); >> + const struct domain *nextd = next ? next->domain : NULL; >> + bool enable_cpuid_faulting; >> + >> + if ( cpu_has_cpuid_faulting || >> + boot_cpu_has(X86_FEATURE_CPUID_USER_DIS) ) { >> + /* >> + * No need to alter the faulting setting if we are switching >> + * to idle; it won't affect any code running in idle context. >> + */ >> + if (nextd && is_idle_domain(nextd)) >> + return; >> + /* >> + * We *should* be enabling faulting for PV control domains. >> + * >> + * The domain builder has now been updated to not depend on >> + * seeing host CPUID values. This makes it compatible with >> + * PVH toolstack domains, and lets us enable faulting by >> + * default for all PV domains. >> + * >> + * However, as PV control domains have never had faulting >> + * enforced on them before, there might plausibly be other >> + * dependenices on host CPUID data. Therefore, we have left >> + * an interim escape hatch in the form of >> + * `dom0=no-cpuid-faulting` to restore the older behaviour. >> + */ >> + enable_cpuid_faulting = nextd && >> + domain_has_cap(nextd, CAP_DISABLE_CPU_FAULT) && >> + (is_pv_domain(nextd) || >> + next->arch.msrs->misc_features_enables.cpuid_faulting); >> + >> + if (cpu_has_cpuid_faulting) >> + set_cpuid_faulting(enable_cpuid_faulting); >> + else >> + amd_set_cpuid_user_dis(enable_cpuid_faulting); >> + >> + return; >> + } >> + >> + if (ctxt_switch_masking) >> + alternative_vcall(ctxt_switch_masking, next); >> } > > I don't think I can spot what exactly changes here. Please avoid re- > indenting the entire function. Oh, that was not intentional. I must have done a retab as that entire function is indented using hardtabs. >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -907,6 +907,10 @@ static struct domain *__init create_dom0(const module_t *image, >> >> d->role |= ROLE_UNBOUNDED_DOMAIN; >> >> + if ( !opt_dom0_cpuid_faulting && >> + !domain_set_cap(d, CAP_DISABLE_CPU_FAULT) ) >> + printk(XENLOG_WARNING "failed to set CPU faulting on Dom %pd\n", d); > > No "Dom" please when you use %pd. Also I don't think you mean "set". Plus > we commonly use "%pd: xyz failed\n". Ack on the "Dom" removal and "%pd:". As for set, it failed to set the capability on the domain. You could say enable but that is nothing more than synonyms, not changing the meaning of the statement. >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -472,7 +472,8 @@ struct domain >> #define ROLE_HARDWARE_DOMAIN (1U<<2) >> #define ROLE_XENSTORE_DOMAIN (1U<<3) >> uint8_t role; >> -#define CAP_CONSOLE_IO (1U<<0) >> +#define CAP_CONSOLE_IO (1U<<0) >> +#define CAP_DISABLE_CPU_FAULT (1U<<1) >> uint8_t capabilities; >> /* Is this guest being debugged by dom0? */ >> bool debugger_attached; >> @@ -1160,6 +1161,11 @@ static always_inline bool domain_set_cap( >> case CAP_CONSOLE_IO: >> d->capabilities |= cap; >> break; >> + case CAP_DISABLE_CPU_FAULT: >> + /* Disabling cpu faulting is only allowed for a PV control domain. */ >> + if ( is_pv_domain(d) && is_control_domain(d) ) >> + d->capabilities |= cap; >> + break; > > How do you express the x86-ness of this? Plus shouldn't this fail when > either of the two conditions isn't met? You are correct, since this moves an x86 capability out into common, it should be ifdef'ed for x86. Correct me if I am wrong here, but in the original check it would evaluate that all three conditions to be true. All this change did is effectively move the last two conditions into domain_set_cap(). Thus storing the evaluation of the first two conditions during dom0 capability setup for the result to later be evaluated during dom0 cpuid policy setup as it was done before. v/r, dps From xen-devel-bounces@lists.xenproject.org Wed Aug 09 00:02:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 00:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580601.908938 (Exim 4.92) (envelope-from ) id 1qTWf5-0007B9-SY; Wed, 09 Aug 2023 00:02:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580601.908938; Wed, 09 Aug 2023 00:02:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWf5-0007B2-NM; Wed, 09 Aug 2023 00:02:51 +0000 Received: by outflank-mailman (input) for mailman id 580601; Wed, 09 Aug 2023 00:02:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWf4-0007Aq-HC; Wed, 09 Aug 2023 00:02:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWf4-00046v-Cj; Wed, 09 Aug 2023 00:02:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTWf3-0005U7-V4; Wed, 09 Aug 2023 00:02:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTWf3-0001VE-Sc; Wed, 09 Aug 2023 00:02:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ka2tyQOcPIx3SgHL41bYctcFHxq/yKWfxBdN7nbEmfo=; b=ldXW5bRhAXM9GUiQqXfMjolJON 9CAC8P0BKZP+JR67hiUOGUTll2jV1xheRQk1MMgm6g5wxyLJJUbUGnQ/EXR9kJ/oXq1sooLemAWD0 U7uP2yEeEyDFsF/TvLwvZbABEu4EUa5eQVo/gItBw0888q9goMdVdwG3E898hsWM5Z+o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182231: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=0450cf08976f9036feaded438031b4cba94f6452 X-Osstest-Versions-That: qemuu=e0e5dca517a5964d407f48bdfccbea88113b2736 From: osstest service owner Date: Wed, 09 Aug 2023 00:02:49 +0000 flight 182231 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182231/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182222 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182222 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182222 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182222 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182222 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182222 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182222 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182222 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 0450cf08976f9036feaded438031b4cba94f6452 baseline version: qemuu e0e5dca517a5964d407f48bdfccbea88113b2736 Last test of basis 182222 2023-08-07 20:38:59 Z 1 days Testing same since 182231 2023-08-08 08:51:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: BALATON Zoltan Dongli Zhang Dongwon Kim Luca Bonissi Marc-AndrĂ© Lureau Michael Tokarev Richard Henderson Zongmin Zhou Zongmin Zhou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git e0e5dca517..0450cf0897 0450cf08976f9036feaded438031b4cba94f6452 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Aug 09 00:34:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 00:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580610.908949 (Exim 4.92) (envelope-from ) id 1qTX9l-0002Jz-BV; Wed, 09 Aug 2023 00:34:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580610.908949; Wed, 09 Aug 2023 00:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTX9l-0002Js-7B; Wed, 09 Aug 2023 00:34:33 +0000 Received: by outflank-mailman (input) for mailman id 580610; Wed, 09 Aug 2023 00:34:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTX9j-0002Jm-6Y for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 00:34:31 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e57c31c-364c-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 02:34:27 +0200 (CEST) Received: from [10.10.1.156] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 16915412635711018.2146342926833; Tue, 8 Aug 2023 17:34:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e57c31c-364c-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; t=1691541264; cv=none; d=zohomail.com; s=zohoarc; b=H9VdcIqtvDHawaggAa60LjdLVJ6afkqNxXI0Gxgb1slWX8vwb/kMLAjWiCemo8BXHsD6uZrp2UvfOmUHiR3z+KVuj0TeeLRIKlrEEP2XkQGBDG8tVrR3/AJnReVlF5dIEQb6u+257rWfnnuC++sOl9Y3AVSZKmYxkln1A6u5KgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691541264; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=83T5jzdPlLeVfNFoB0HbUs7iFodqjP9UZnCLmRe025g=; b=hxEyX+KmBOkmzi2fhKoVua1TuogHRM2Nu1vjD5XbhT06UIeDmk3oBh0mTX9lkU3vgoJs/5F1SXWl7JRra5YALwIi/Fs/zDWJ7VVuWXnZ6rkjt77GTJ/oqaVX8O5KM678LQo/d1flE/rxayzQyzbFpbi7JGE+udZ27mrH/Cf13Aw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691541264; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=83T5jzdPlLeVfNFoB0HbUs7iFodqjP9UZnCLmRe025g=; b=jnnR3Bnb1joNFIRS/FKD7wWmEV+K/pDoe5CczIaHOnRFUsgCOUvQdC62sJIMxEGO vY70QrLTfS4G02qCermvYWcXzSaJWO0iy3/wee9UnrJxAtPT7rE2qSMyz8WnlGDFTR1 LddQANJs2Aja3tNxtlUAMofjJK3bUzCQN2hN81uw= Message-ID: <961664b6-ede3-c803-293a-0aeb5792990d@apertussolutions.com> Date: Tue, 8 Aug 2023 20:34:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles Content-Language: en-US To: Stefano Stabellini Cc: Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> <119710f3-82b1-2066-5fa0-164bd293836e@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 8/8/23 19:38, Stefano Stabellini wrote: > On Tue, 8 Aug 2023, Daniel P. Smith wrote: >> On 8/3/23 16:19, Stefano Stabellini wrote: >>> On Thu, 3 Aug 2023, Daniel P. Smith wrote: >>>> On 8/1/23 20:54, Stefano Stabellini wrote: >>>>> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>>>>> The existing concepts such as unbounded domain, ie. all powerful, >>>>>> control >>>>>> domain and hardware domain are, effectively, roles the domains provide >>>>>> for >>>>>> the >>>>>> system. Currently, these are represented with booleans within `struct >>>>>> domain` >>>>>> or global domid variables that are compared against. This patch begins >>>>>> to >>>>>> formalize these roles by replacing the `is_control` and `is_console`, >>>>>> along >>>>>> with expanding the check against the global `hardware_domain` with a >>>>>> single >>>>>> encapsulating role attribute in `struct domain`. >>>>>> >>>>>> Signed-off-by: Daniel P. Smith >>>>> >>>>> This is definitely heading in the right direction >>>> >>>> Thank you, it is good to know there is some agreement here. >>>> >>>>>> --- >>>>>> xen/arch/arm/domain_build.c | 2 ++ >>>>>> xen/arch/x86/setup.c | 2 ++ >>>>>> xen/common/domain.c | 14 +++++++++++++- >>>>>> xen/include/xen/sched.h | 16 +++++++++------- >>>>>> xen/include/xsm/dummy.h | 4 ++-- >>>>>> xen/xsm/flask/hooks.c | 12 ++++++------ >>>>>> 6 files changed, 34 insertions(+), 16 deletions(-) >>>>>> >>>>>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>>>>> index 39b4ee03a5..51b4daefe1 100644 >>>>>> --- a/xen/arch/arm/domain_build.c >>>>>> +++ b/xen/arch/arm/domain_build.c >>>>>> @@ -4201,6 +4201,8 @@ void __init create_dom0(void) >>>>>> if ( IS_ERR(dom0) ) >>>>>> panic("Error creating domain 0 (rc = %ld)\n", >>>>>> PTR_ERR(dom0)); >>>>>> + dom0->role |= ROLE_UNBOUNDED_DOMAIN; >>>>> >>>>> I am not a fan of "UNBOUNDED". Maybe "PRIMARY"? "PRIVILEGED"? "SUPER"? >>>>> "ROOT"? >>>>> >>>>> I also recognize I am not good at naming things so I'll stop here and >>>>> let other provide better feedback :-) >>>> >>>> In first version of hyperlaunch and in the early roles work, I was working >>>> to >>>> move toward eliminating this concept entirely. The reality is this is a >>>> model >>>> that has existed for over 20 years and there are those who accept and >>>> embrace >>>> the model. Introducing the name UNBOUNDED was to at least break the idea >>>> that >>>> the all powerful domain necessarily is the first/initial domain to run. >>>> With >>>> hyperlaunch, there are still security-based scenarios where you might want >>>> to >>>> run a DomB before starting an all privileged domain. I spent quite some >>>> time, >>>> probably more than I should have, to find a good name that expresses what >>>> this >>>> role is. Considering a comment below and a comment by Jan, I am starting >>>> to >>>> think a better way to view it is a domain that assumes all roles in the >>>> system. So your suggestions of SUPER or ROOT might be more fitting. I >>>> considered ROLE_ALL, but something about it doesn't sit right with me. >>>> With >>>> that said I welcome the yak shaving of naming to begin. ( ^_^) >>>> >>>>> Also, do we actually need unbounded given that it gets replaced with >>>>> control_domain pretty soon? >>>> >>>> Yes, because as mentioned above, this is meant to express a domain that >>>> has >>>> been assigned all roles, for which later the domain may decided to >>>> delegate >>>> the role to another domain. >>>> >>>>> I am asking because I think that at least from a safety perspective it >>>>> would be a problem to run a domain as "unbounded". In a safety system, >>>>> we wouldn't want anything to be unbounded, not even temporarily at boot. >>>>> If "unbounded" is removed before running dom0, then of course it is no >>>>> problem because actually dom0 never gets to run with "unbounded" set. >>>> >>>> I think this is were the name UNBOUNDED may have been a bad choice. The >>>> UNBOUNDED role is dom0. It is the control domain, the hardware domain, the >>>> Xenstore domain, and the crash domain (if that were to be solidified). >>>> >>>>> (I am currently thinking of solving the privilege issue by using XSM and >>>>> removing most privileges from Dom0.) >>>> >>>> I obviously would be a huge advocate of that approach. ( ^_^) >>> >>> Thanks for the history, that helps. I was asking because I would like to >>> make sure that all the options below are possible and easy to achieve: >>> >>> 1) traditional dom0 + some traditional domUs booted in a dom0less fashion >>> 2) only traditional domUs booted in a dom0less fashion (no dom0 at all) >>> 3) not-godlike-but-still-super dom0 + some traditional domUs booted in a >>> dom0less fashion >>> 4) domB booting >>> >>> This ROLE_ALL domain would be dom0 in 1) and would be domB in 4). >>> In 2), there is no dom0 so there should also be no ROLE_ALL domain. All >>> good so far. >> >> You are correct that constructing a traditional dom0 would be accomplished by >> assigning this role. As mentioned over in the hyperlaunch devicetree series >> that by a domain be a traditional dom0 would not be about ensuring it was give >> domid 0, but that it was assigned this role. >> >> As for domB, no, it would not get the ROLE_ALL. It's purpose is assist the >> hyperlaunch domain builder with functions that just should not be done inside >> the hypervisor. A less-than-ideal analogy, is domB is like an initrd for >> Linux. Like an initrd is an environment that runs in user-space with >> controlled kernel interfaces to interact with system, domB provides the >> concept of a domain role that has restricted access to hypervisor interfaces >> to those needed to configure/setup the domains constructed by the hypervisor. >> In the roles case, a course-grained common base set of capabilities will need >> to be determined, but those using FLASK will be able to do fine grained access >> assignment for more rigid/stringent use cases. >> >> Yes, in scenario 2 you provided, no domain would get assigned ROLE_ALL. >> >>> In 3), it looked to me that we would be creating a ROLE_ALL domain, then >>> taking away some of the ROLEs. It doesn't sound right? Let's say that we >>> want to have a hardware_domain (in the sense of default recipient of >>> hardware, not necessarily privileged) with dm_ops access, but no domctl >>> access. How would you go about it? >> >> With what is there today for dom0less, you have to go down the path that when >> dom0less constructs the hwdom, this will trigger dom0 to be demoted to the >> control domain role before either of them get unpaused. >> >> Moving forward to a when hyperlaunch appears, then you would just assign the >> control domain role to "dom0" and the hardware domain role to "hwdom" and >> nothing would ever be assigned ROLE_ALL. > > OK Apologies I was more clear the first time. >>> Would it be required to go through the ROLE_ALL stage? How does it >>> compare to the way it would work today without this patch applied? >>> Today, does XSM kick in after is_privileged is set, effectively being >>> the same thing as XSM kicking in later and removing some ROLEs after >>> ROLE_ALL is already set? So, basically nothing is changing? >> >> Until hyperlaunch, yes you would have to go through ROLE_ALL, but in dom0less >> case, as long as the hwdom is one of the domains it constructs, dom0 would >> never run with that role. > > OK, I think we are on the same page. For extra clarity I want to add > that in scenario 3) there is no control domain at all. There is only > hardware_domain with a few control powers (not many). If that is the case, then you need FLASK and would either change the dom0_t label to remove the privileges you don't want it to have or derive a new label from dom0_t, again with the privileges you don't want removed. I think the latter would be recommended as you can give that label a name to reflect what the domain is. >> Your next question is a bit tricky. XSM is effective fairly early in >> start_xen() and begins enforcing its policy. The tricky part is that there is >> functionality and hypervisor behaviors that are not protected behind an XSM >> hook but where is_privileged, checked via is_control_domain(), is used to >> controls how they work. There are other places in the code where one would say >> that DAC is enforced before MAC, specifically one of the >> is_{control,hardware,xenstore}_domain() is enforced before the fine grained >> XSM check is made. In most cases this is not an issue, the role can just be >> given to the domain and the FLASK policy can be relied upon to restrict down. >> But there are some esoteric cases that could be constructed where this >> behavior would break the security model. > > OK. I understand there are corner cases, but I am also understanding > that "nothing is changing" in terms of order of XSM enforcement and > deprivilege execution with this patch series? It is not getting "worse" > the window of time where Dom0 has ROLE_ALL/is_privileged? Correct. >>>>>> if ( alloc_dom0_vcpu0(dom0) == NULL ) >>>>>> panic("Error creating domain 0 vcpu0\n"); >>>>>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >>>>>> index 2dbe9857aa..4e20edc3bf 100644 >>>>>> --- a/xen/arch/x86/setup.c >>>>>> +++ b/xen/arch/x86/setup.c >>>>>> @@ -905,6 +905,8 @@ static struct domain *__init create_dom0(const >>>>>> module_t *image, >>>>>> if ( IS_ERR(d) ) >>>>>> panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); >>>>>> + d->role |= ROLE_UNBOUNDED_DOMAIN; >>>>>> + >>>>>> init_dom0_cpuid_policy(d); >>>>>> if ( alloc_dom0_vcpu0(d) == NULL ) >>>>>> diff --git a/xen/common/domain.c b/xen/common/domain.c >>>>>> index 8fb3c052f5..0ff1d52e3d 100644 >>>>>> --- a/xen/common/domain.c >>>>>> +++ b/xen/common/domain.c >>>>>> @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) >>>>>> setup_io_bitmap(dom0); >>>>>> #endif >>>>>> + /* >>>>>> + * "dom0" may have been created under the unbounded role, demote >>>>>> it >>>>>> from >>>>>> + * that role, reducing it to the control domain role and any >>>>>> other >>>>>> roles it >>>>>> + * may have been given. >>>>>> + */ >>>>>> + dom0->role &= ~(ROLE_UNBOUNDED_DOMAIN & ROLE_HARDWARE_DOMAIN); >>>>>> + dom0->role |= ROLE_CONTROL_DOMAIN; >>>>> >>>>> I think we need a better definition of the three roles to understand >>>>> what this mean. >>>> >>>> Definition and as highlighted, a better name. >>>> >>>>>> rcu_unlock_domain(dom0); >>>>>> iommu_hwdom_init(d); >>>>>> @@ -609,7 +617,10 @@ struct domain *domain_create(domid_t domid, >>>>>> } >>>>>> /* Sort out our idea of is_control_domain(). */ >>>>>> - d->is_privileged = flags & CDF_privileged; >>>>>> + if ( flags & CDF_privileged ) >>>>>> + d->role |= ROLE_CONTROL_DOMAIN; >>>>>> + else >>>>>> + d->role &= ~ROLE_CONTROL_DOMAIN; /*ensure not set */ >>>>>> /* Sort out our idea of is_hardware_domain(). */ >>>>>> if ( is_initial_domain(d) || domid == hardware_domid ) >>>>>> @@ -619,6 +630,7 @@ struct domain *domain_create(domid_t domid, >>>>>> old_hwdom = hardware_domain; >>>>>> hardware_domain = d; >>>>>> + d->role |= ROLE_HARDWARE_DOMAIN; >>>>>> } >>>>>> TRACE_1D(TRC_DOM0_DOM_ADD, d->domain_id); >>>>>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >>>>>> index a9276a7bed..695f240326 100644 >>>>>> --- a/xen/include/xen/sched.h >>>>>> +++ b/xen/include/xen/sched.h >>>>>> @@ -467,8 +467,10 @@ struct domain >>>>>> #endif >>>>>> /* is node-affinity automatically computed? */ >>>>>> bool auto_node_affinity; >>>>>> - /* Is this guest fully privileged (aka dom0)? */ >>>>>> - bool is_privileged; >>>>>> +#define ROLE_UNBOUNDED_DOMAIN (1U<<0) >>>>>> +#define ROLE_CONTROL_DOMAIN (1U<<1) >>>>>> +#define ROLE_HARDWARE_DOMAIN (1U<<2) >>>>> >>>>> This is a great step in the right direction but I think at least a short >>>>> in-code comment to explain the difference between the three >>>> >>>> Ack. >>>> >>>>>> + uint8_t role; >>>>>> /* Can this guest access the Xen console? */ >>>>>> bool is_console; >>>>>> /* Is this guest being debugged by dom0? */ >>>>>> @@ -1060,9 +1062,7 @@ void watchdog_domain_destroy(struct domain *d); >>>>>> static always_inline bool is_initial_domain(const struct domain >>>>>> *d) >>>>>> { >>>>>> - static int init_domain_id = 0; >>>>>> - >>>>>> - return d->domain_id == init_domain_id; >>>>>> + return d->role & ROLE_UNBOUNDED_DOMAIN; >>>>>> } >>>>> >>>>> As far as I can tell this is the only functional change in this patch: >>>>> given that dom0 loses unbounded soon after boot, the "is_initial_domain" >>>>> checks will start to fail? >>>> >>>> Today, dom0 should not lose any of its roles at boot unless dom0less were >>>> to >>>> create a hardware domain. >>> >>> I don't understand this sentence. To me, hardware_domain means "default >>> recipient of hardware devices". It also happens to be traditionally >>> associated with Dom0, so many privilege checks are hardware_domain >>> check, although they should be instead control_domain checks. >> >> What I am saying is that with this patch, dom0 will retain ROLE_ALL unless a >> separate hardware domain is constructed. If a separate hardware domain, aka >> late hardware domain, is created, then dom0 will loose ROLE_ALL and be >> demoted/limited to only ROLE_CONTROL_DOMAIN and the new late hardware domain >> will be give ROLE_HARDWARE_DOMAIN. >> >>> So if you say "dom0 should not lose any of its roles at boot unless >>> dom0less were to create a hardware domain", I read it as: >>> >>> "dom0 (all powerful) would not lose any of its powers at boot unless we >>> created dom0 (hardware domain, all powerful) with other domUs at boot >>> using dom0less." >> >> Let's say dom0less set the xen command line parameter hardware_dom=1, and it >> has a configuration that constructs dom0 and 3 domU. The the first domU >> constructed would result in dom0 get limited to ROLE_CONTROL_DOMAIN and dom1 >> would be given ROLE_HARDWARE_DOMAIN. What I would advise against, as I think >> it would end up crashing Xen, is if you gave dom0less a configuration with >> command line parameter hardware_dom=1, no dom0 and 3 domU. This would trigger >> the late_hwdom_init() which would it ASSERT(dom0 != NULL) and crash the >> hypervisor. > > Thanks for the example, it is finally clear! > > I don't think we should add hardware_dom=1 to the command line (I don't > know if it was just an example to make it easier to understand for me). > Instead it should a property on device tree. hardware_dom=1 is not great > because it is tied to the order of domain construction. Instead it > should be a device tree property under the specific domain. That way you > can clearly specify which one is tradition dom0, or which is > hardware_domain and which is control_domain. I was describing with today's code, how you would launch a late hardware domain. The logic to trigger the hardware transfer from dom0 to the hardware domain is triggered by the command line parameter `hardware-dom`. With hyperlaunch, this can eventually be retired and separate control domain and hardware domain can be constructed at launch as we expose access to roles/capabilities through its DT interface. >>> which I don't understand >> >> Did the above help? > > A lot, thanks! Your welcome, glad I was able to articulate it better this time. >>>> Upon reflection, I am thinking this check might want renaming to align >>>> with >>>> the rename of this role. >>>> >>>>> We have a few of them in the code and I couldn't rule out that at least >>>>> these 3 could happen at runtime: >>>>> >>>>> xen/common/sched/core.c: else if ( is_initial_domain(d) && >>>>> opt_dom0_vcpus_pin ) >>>>> xen/common/sched/core.c: else if ( is_initial_domain(d) ) >>>>> xen/common/sched/arinc653.c: if ( is_initial_domain(unit->domain) ) >>>>> >>>>> Maybe they need to be changed to control_domain checks? >>>> >>>> Perhaps, I would want to study them a bit before switching them over. >>> >>> +1 >> From xen-devel-bounces@lists.xenproject.org Wed Aug 09 00:43:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 00:43:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580617.908958 (Exim 4.92) (envelope-from ) id 1qTXIg-0003tb-Bw; Wed, 09 Aug 2023 00:43:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580617.908958; Wed, 09 Aug 2023 00:43:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXIg-0003tU-7f; Wed, 09 Aug 2023 00:43:46 +0000 Received: by outflank-mailman (input) for mailman id 580617; Wed, 09 Aug 2023 00:43:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXIf-0003tO-OG for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 00:43:45 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9c7b0d6-364d-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 02:43:43 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 608DA62E77; Wed, 9 Aug 2023 00:43:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F8C4C433C8; Wed, 9 Aug 2023 00:43:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9c7b0d6-364d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691541820; bh=oVABKR76DoWqzsGRz1snuwY40T+DoDY/s5F1RUNNCuY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MszJN5RH230+Ij2IPlb0zpY1xRocUEdH8HvMm7s09CqV9JeHyQZ0FAgZF92gn9PSL 8BIhpRN6W7rXtkb4aa3uNOIDzh9/b0jW7M7qQkMFUiD1SVTJoNBNuGWjM7HPCTIZWb oFU3tzUI3hIvuFyncNMnNwIAALf3yl/SZpwFj+Tx5NmT+win9/97s0q/8cv2IDVgLl gVhRNytjOM5Rp7afgDEpx4hQtv0LEkiooSfDKoV7OtOhU6b9vwMYQ+5UkzhWImCfbV YXaZZbcpnqc9Mjln0Me7vGz9TsntjkAtXoGWsaBAdCbYoW8oZKHx7BWRRz3GgANq56 ydu4+aSbgAp9A== Date: Tue, 8 Aug 2023 17:43:38 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Stefano Stabellini , Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Daniel P. Smith wrote: > On 8/3/23 19:38, Stefano Stabellini wrote: > > On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > > > Also, what is the plan for the existing dom0less dt properties? > > > > Will they need to be moved to new /hypervisor node or we will have to > > > > parse > > > > both /chosen and /hypervisor nodes? > > > > > > In the proposal I sent to xen-devel in response to Luca's RFC for > > > rebranding > > > dom0less features under hyperlaunch, that is the purpose of this commit. > > > Get > > > this document up to date with what was done in v1 along with what we are > > > planning/working on for hyperlaunch. One could think of this as > > > effectively > > > the API to the capabilities hyperlaunch will provide. Not just how to > > > construct a domain, but what kinds of domains can be constructed by > > > hyperlaunch. Step one of the proposal is to publish a patch upon which we > > > all > > > can iterate over and get to an agreement on a suitable interface for all. > > > The > > > next step would be the introduction of hyperlaunch dom0less compatibility > > > mode, that would see the moving of the parsing logic for the existing > > > dom0less > > > nodes under /xen/common/domain-builder. It would continue to exist there > > > even > > > after hyperlaunch proper is merged and can remain there for backward > > > compatibility until there is a decision to retire the compatibility > > > interface. > > > > I like this plan. The two interfaces are so similar that it is basically > > one interface with a couple of tiny differences. > > > > So I expect we would move the existing dom0less parsing code to common/, > > add a couple of extensions (such as parsing /hypervisor in addition to > > /chosen) and use it as it. > > Do you mean /chosen/hypervisor? I meant /hypervisor as in "the node under which the hyperlaunch configuration is presented". If HyperLaunch uses /chosen/hypervisor, then that's what I meant :-) > > Later on, after a few years of using /hypervisor instead of /chosen, if > > nobody is using /chosen anymore, we could retire /chosen completely. But > > this is just one DT node/property that gets retired (there are a couple > > of others). I don't imagine we'll have a full new implementation of the > > DT parsing logic that supersedes the existing implementation of it > > (especially considering the difficulty of maintaining 2 different parsing > > logics in the hypervisor for similar interfaces). > > +1 > > > Same thing for the DT interface documentation. I don't think we need two > > DT interface docs? We could start with the existing dom0less interface > > (docs/misc/arm/device-tree/booting.txt), and move it somewhere common > > like docs/misc/device-tree. > > So in the plan that I sent, patch series 3 was were I was going to consolidate > docs/design/launch/hyperlaunch-devicetree.rst and > docs/misc/arm/device-tree/booting.txt into a single document under > docs/features/hyperlaunch/device-tree.rst along with moving > docs/features/dom0less.pandoc to > docs/features/hyperlaunch/dom0less-compatibility-mode.pandoc. The thinking > here was to get all the feature documentation together in a single place, but > I would be open to putting the suggested consolidated device-tree.rst > mentioned above into docs/misc/device-tree/hyperlaunch.rst if that is > preferred. Yes I think we should have a single consolidated document, because it is not a good idea to support very similar but subtly different interfaces on ARM/x86. docs/misc/device-tree/hyperlaunch.rst should work fine. And I think we should try to minimize differences and have a single common parsing code. Any role definition introduced by hyperlaunch originally for x86 would undoubtedly be useful on ARM. Conversely, all the existing ARM dom0less tools (ImageBuilder) might be useful on x86 too. RISC-V might use it too in the near future. > > Then add any changes or extensions required by other architecture, such > > as x86 and RISC-V. > > > > For sure for x86 we need "module-index". I don't know if anything else > > is must-have to get it to work on x86 but if there is, we should add > > those too. > > Hmm good point, since in the suggested patch series 3 from the plan, this > probably should get cropped down to what we actually have implemented for x86 > hyperlaunch and then get expanded as it becomes feature complete. Yes exactly. So I think the best way to move forward is something along these lines: a) work on a single arch-neutral hyperlaunch/dom0less DT interface document for ARM/x86/RISC-V b) in parallel, move dom0less parsing code to common (AMD might be able to work on this, to be confirmed) c) add x86 features as needed to the code and to the interface doc, "module-index" would probably be among the first ones d) as we add more features, we expand the hyperlaunch/dom0less DT interface document I think a) only really needs the smallest amount of changes to make it work on non-ARM architectures From xen-devel-bounces@lists.xenproject.org Wed Aug 09 00:43:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 00:43:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580618.908968 (Exim 4.92) (envelope-from ) id 1qTXIn-0004Ay-IY; Wed, 09 Aug 2023 00:43:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580618.908968; Wed, 09 Aug 2023 00:43:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXIn-0004Ar-Fv; Wed, 09 Aug 2023 00:43:53 +0000 Received: by outflank-mailman (input) for mailman id 580618; Wed, 09 Aug 2023 00:43:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXIm-0004AJ-Me for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 00:43:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce663524-364d-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 02:43:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7BCC262E76; Wed, 9 Aug 2023 00:43:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8B89C433C7; Wed, 9 Aug 2023 00:43:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce663524-364d-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691541828; bh=eG7pqWOuk/Rfgfwp5QpRzBlLDZJCfn0qFLVG7dJSE8w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=GbpR13/9PJ1OaBNjBiTIczndcpTnEQhfo3B9lBcQqGICDp/2BH0UhCT5Z59ObXUIx SyF2q/KPx0X45DEfMTR5cVwK56u456T3CPTD373vZTIFGBNMs2Ec/u8QM0fWSVZMRC yYLbdCX03n78zOA8M7Q2Sko9qgQMnAovsg2j47dK8YjmOWDFeb43t66hbkGbG4C7dg 59u8Z6F5UXOhMi5x+101Vj2OB1CpqDXxBWzdyD382XFPx4g1lbJ3s5K35ni1TYsp2Z n7mpPcoFl1jXSYw0GP4f6jRxbs6thOnPBm8N1/loYdSagLGywJGSjBLmHqTmFS3gnN rP184+0U/P/sw== Date: Tue, 8 Aug 2023 17:43:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Stefano Stabellini , Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Daniel P. Smith wrote: > On 8/3/23 20:09, Stefano Stabellini wrote: > > On Thu, 3 Aug 2023, Stefano Stabellini wrote: > > > On Thu, 3 Aug 2023, Daniel P. Smith wrote: > > > > > Also, what is the plan for the existing dom0less dt properties? > > > > > Will they need to be moved to new /hypervisor node or we will have to > > > > > parse > > > > > both /chosen and /hypervisor nodes? > > > > > > > > In the proposal I sent to xen-devel in response to Luca's RFC for > > > > rebranding > > > > dom0less features under hyperlaunch, that is the purpose of this commit. > > > > Get > > > > this document up to date with what was done in v1 along with what we are > > > > planning/working on for hyperlaunch. One could think of this as > > > > effectively > > > > the API to the capabilities hyperlaunch will provide. Not just how to > > > > construct a domain, but what kinds of domains can be constructed by > > > > hyperlaunch. Step one of the proposal is to publish a patch upon which > > > > we all > > > > can iterate over and get to an agreement on a suitable interface for > > > > all. The > > > > next step would be the introduction of hyperlaunch dom0less > > > > compatibility > > > > mode, that would see the moving of the parsing logic for the existing > > > > dom0less > > > > nodes under /xen/common/domain-builder. It would continue to exist there > > > > even > > > > after hyperlaunch proper is merged and can remain there for backward > > > > compatibility until there is a decision to retire the compatibility > > > > interface. > > > > > > I like this plan. The two interfaces are so similar that it is basically > > > one interface with a couple of tiny differences. > > > > > > So I expect we would move the existing dom0less parsing code to common/, > > > add a couple of extensions (such as parsing /hypervisor in addition to > > > /chosen) and use it as it. > > > > > > Later on, after a few years of using /hypervisor instead of /chosen, if > > > nobody is using /chosen anymore, we could retire /chosen completely. But > > > this is just one DT node/property that gets retired (there are a couple > > > of others). I don't imagine we'll have a full new implementation of the > > > DT parsing logic that supersedes the existing implementation of it > > > (especially considering the difficulty of maintaining 2 different parsing > > > logics in the hypervisor for similar interfaces). > > > > > > Same thing for the DT interface documentation. I don't think we need two > > > DT interface docs? We could start with the existing dom0less interface > > > (docs/misc/arm/device-tree/booting.txt), and move it somewhere common > > > like docs/misc/device-tree. > > > > > > Then add any changes or extensions required by other architecture, such > > > as x86 and RISC-V. > > > > > > For sure for x86 we need "module-index". I don't know if anything else > > > is must-have to get it to work on x86 but if there is, we should add > > > those too. > > > > > > For clarity, I think we should definitely have > > docs/design/launch/hyperlaunch.rst, and maybe we should also have > > hyperlaunch-devicetree.rst as an overview description and user guide. > > That's useful. > > > > But in terms of official device tree bindings interface description > > (basically what in Linux would go under > > Documentation/devicetree/bindings/), I think it would be best to only > > have a single document. The current one is > > docs/misc/arm/device-tree/booting.txt. > > Does the proposal to your first message align with your follow-up here? You are referring to a common docs/misc/device-tree/hyperlaunch.rst, right? Then yes. From xen-devel-bounces@lists.xenproject.org Wed Aug 09 00:44:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 00:44:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580626.908979 (Exim 4.92) (envelope-from ) id 1qTXJJ-0004uL-SD; Wed, 09 Aug 2023 00:44:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580626.908979; Wed, 09 Aug 2023 00:44:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXJJ-0004uE-Np; Wed, 09 Aug 2023 00:44:25 +0000 Received: by outflank-mailman (input) for mailman id 580626; Wed, 09 Aug 2023 00:44:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXJI-0003tO-43 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 00:44:24 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e101da2f-364d-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 02:44:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97F81621E5; Wed, 9 Aug 2023 00:44:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED40C433C8; Wed, 9 Aug 2023 00:44:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e101da2f-364d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691541860; bh=7D+P9K07J5ED2+m1dphwVZo4e3lgK4BSZDueqQ3XM3k=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bqhrA2vc33gfPzdWfPjwNiKBU55KjcfljbtQhq+hj47jtaMlGOZfdDGZrzCJIo6nA 70PCuqfDfcrufZtwF747+OP4nQLRThiTwDqddxmONu2ApnpZTfdkvyHjOVG7Hr2o9I liCOBMvRGySlifFegdgtLOOuV25++ffJOua+enbBe5ZEF4+BhAhM5P8o01vRE9zq4W HLUJrFxkJxGciEUUqF5L5tvuhhZPLh5VhzIU66Eufipixa84M21VqI94OEGmgMZRq1 2s1tmli7MlO/I0qB6sV882c21z6klRfZ9EM019JKrXjQPZp3Yo3V9zrbkQeL6d+o1+ TkEAmUEkZaY1Q== Date: Tue, 8 Aug 2023 17:44:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <3ddab6ee-54fc-49a0-8f14-79ca258d04af@xen.org> <76249714-6d1d-a2ad-cfe5-d7eae0ce3a1b@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1287296653-1691539381=:2127516" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1287296653-1691539381=:2127516 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 8 Aug 2023, Julien Grall wrote: > On 08/08/2023 21:49, Daniel P. Smith wrote: > > On 8/4/23 05:03, Julien Grall wrote: > > > Hi Daniel, > > > > > > On 03/08/2023 11:44, Daniel P. Smith wrote: > > > > +compatible > > > > +  Identifies which hypervisors the configuration is compatible. > > > > Required. > > > > -    hypervisor { > > > > -        compatible = “hypervisor,xen†> > > > +  Format: "hypervisor,", e.g "hypervisor,xen" > > > > > > I read "e.g" as "for example". You don't explicitely say which compatible > > > will be supported by Xen, so one could write "hypervisor,foo" and expect > > > to work. > > > > > > Also, it is not fully clear why you need both the hypervisor and each > > > domain node to have a compatible with the hypervisor name in it. > > > > Ack, it should be explicit to what is expected for a Xen configuration. As > > for compatible on the domain node, I think that was from being overly > > cautious, it can be dropped. > > > > This did get me reflecting that the compatibility was added there as there > > was some initial participation in standardization efforts going on at the > > time. I am not sure what has come of those, but the question it raised is > > that domain is a Xen specific term, whereas generally vm is accepted as the > > generic term. Maybe this node needs renaming? > > IIRC Stefano attempted to (partially?) standardized the Device-Tree > configuration for domains. So I will let him comment here. Yes it is called System Device Tree there is a public version of it here: https://github.com/devicetree-org/lopper/tree/master/specification/source https://github.com/devicetree-org/lopper/blob/3e501d6c87f32d26fe5906760d1f661dbc0b4400/specification/source/system-device-tree.dts#L797 Here is what I would suggest for the hyperlaunch DT interface: - try to minimize changes with the existing dom0less DT interface - only introduce changes that are strictly necessary - when changes are necessary, try to align with the System DT specification (which I can update if required) - try to avoid changes that are different from dom0less and SystemDT both > > > > +compatible > > > > +  Identifies the hypervisor the confiugration is intended. Required. > > > > > > Also typo: s/confiugration/configuration/ > > > > Ack. > > > > > > -The modules that would be supplied when using the above config would > > > > be: > > > > +  Format: ",config", e.g "xen,config" > > > > -* (the above config, compiled into hardware tree) > > > > -* CPU microcode > > > > -* XSM policy > > > > -* kernel for boot domain > > > > -* ramdisk for boot domain > > > > -* boot domain configuration file > > > > -* kernel for the classic dom0 domain > > > > -* ramdisk for the classic dom0 domain > > > > +bootargs > > > > +  This is used to provide the boot params for Xen. > > > > > > How is this different from the command line parameter chosen? And if you > > > want to keep both, what is the expected priority if a user provides both? > > > > A DT file for x86, there is only a need to provide the hypervisor node, for > > which we already needed a hypervisor config section to describe XSM policy > > and microcode, at this point at least. It was decided in an effort to > > provide flexibility, the ability to specify command line parameters to the > > hypervisor in DT config. It is expected these parameters would function as a > > base parameters that would be overridden by those provided via the multiboot > > kernel entry. > ]> > > Now as you point out for Arm, this becomes a bit redundant, to a degree, as > > the Xen command line is already under the /chosen node. But even here it > > would be beneficial, as a hyperlaunch configuration could be distributed > > consisting of a dtb that has core parameters set with base values along with > > a set of kernels and ramdisks. At boot, the hyperlaunch dtb could then be > > concatenated with the device specific dtb. > > I don't have a strong opinions on how it should be done. My point is more that > the priority should be document. Any change we make to the existing interface is more effort for us. I would try to avoid changes. But of course we'll need new properties to define domain roles (e.g. hardware domain, control domain). For instance, do we need a hypervisor node? The XSM policy can be specified already in dom0less and we could use the same strategy for microcode. > > > > -The hypervisor device tree would be compiled into the hardware device > > > > tree and > > > > -provided to Xen using the standard method currently in use. The > > > > remaining > > > > -modules would need to be loaded in the respective addresses specified > > > > in the > > > > -`module-addr` property. > > > > +  Format: String, e.g. "flask=silo" > > > > +Child Nodes > > > > +""""""""""" > > > > -The Hypervisor node > > > > -------------------- > > > > +* module > > > > -The hypervisor node is a top level container for the domains that will > > > > be built > > > > -by hypervisor on start up. On the ``hypervisor`` node the > > > > ``compatible`` > > > > -property is used to identify the type of hypervisor node present.. > > > > +Domain Node > > > > +----------- > > > > -compatible > > > > -  Identifies the type of node. Required. > > > > +A ``domain`` node is for describing the construction of a domain. Since > > > > there > > > > +may be one or more domain nodes, each one requires a unique, DTB > > > > compliant name > > > > +and a ``compatible`` property to identify as a domain node. > > > > -The Config node > > > > ---------------- > > > > +A ``domain`` node  may provide a ``domid`` property which will be used > > > > as the > > > > +requested domain id for the domain with a value of “0†signifying to > > > > use the > > > > +next available domain id, which is the default behavior if omitted. It > > > > should > > > > +be noted that a domain configuration is not able to request a domid of > > > > “0†> > > > > > Why do you need this restriction? And more importantly how would you > > > describe dom0 in hyperlaunch? > > > > I would start by saying one of the goals/purposes behind hyperlaunch is to > > remove the binding that "dom0" is identified by having domid 0. That is what > > the roles patch recently submitted is working to achieve. "Dom0" is a role > > in the system, which I tried calling the "unbounded role" but that seems to > > have caused some confusion. > > > > That aside, IMHO because of the legacy around domid 0, I don't think it > > should be assignable through hyperlaunch. > > I understand the end goal. But I am not entirely convinced this will be wanted > for everyone. So it might be preferable to avoid using '0' as 'assign any free > domid' as this would not prevent to describe dom0 in hyperlaunch if needed in > the future. In general I find that forcing people to adopt security features is detrimental because: - people that wants the security feature would have used it anyway - people that doesn't want it, still doesn't want it and now they are frustrated So I think we should let users specify domid 0. Is that a configuration for a secure or a safe system? It is not. But some systems are just for handling cats pictures. If after the hyperlaunch patches domid 0 becomes meaningless then at that point I would make a change to the DT interface potentially for Xen to refuse to continue because the feature requested is unavailable. > > Additionally, there should be an identifier that signifies auto-assign the > > domid and that value should not conflict/limit what domids are usable by the > > hypervisor. > > Why is this requirement? Why can't we simply rely on the property is not > present? > > > Given we should not be assigning domid 0 through this interface, it makes > > it the perfect candidate value. > To be honest, even if you don't want to allow an admin to allocate ID 0, I > think using it is confusing because of the legacy meaning behind it. > > I would likely be confused every time I read a device-tree. I agree > Also, given you > already have a way to say 'assign a domain ID', it is not clear to me why you > really need a second way to do it. > > [...] > > > > > + > > > > +capability > > > > +  This identifies what system capabilities a domain may have beyond the > > > > role it > > > > +  was assigned. > > > >     Optional, the default is none. > > > > -.. note::  The `functions` bits that have been selected to indicate > > > > -   ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two > > > > bits > > > > -   (30, 31) such that should these features ever be fully retired, the > > > > flags may > > > > -   be dropped without leaving a gap in the flag set. > > > > +  Format: Bitfield, e.g <3221225487> or <0xC0000007> > > > > > > I thik we should favor the hexadecimal version because this will be > > > somewhat easier to read. > > > > I too favor the hex version, but as I recall, DT/libfdt doesn't > > care/enforce. > > Indeed the device-tree compiler is able to cope with both. However, we don't > have to mention the two. It would be ok to only mention the one we prefer > (i.e. hexadecimal) so the reader will more naturally use it. > > > > > > Also, the Device-Tree values work in term of 32-bit cell. Also, how do you > > > plan to handle the case where you have more than 32 capabilities? > > > > I would add a capabalities2 field, this is how SELinux/Flask handle the same > > problem. > > You should not need to introduce a new field. Instead you can add a second > cell. But we would need to describe the ordering because for backward > compatibility the cell 0 would want to cover bits [0:31] and cell 2 bits > [64:31]. > > [...] > > > > > + > > > >   memory > > > > -  The amount of memory to assign to the domain, in KBs. > > > > +  The amount of memory to assign to the domain, in KBs. This field uses > > > > a DTB > > > > +  Reg which contains a start and size. For memory allocation start may > > > > or may > > > > +  not have significance but size will always be used for the amount of > > > > memory > > > >     Required. > > > > > > The description doesn't match... > > > > Ack, others caught that as well. Will be fixed. > > > > > > +  Format: String  min: | max: | , e.g. "256M" > > > > > > ... the format. But strings are difficult to parse. If you want to provide > > > 3 different values (possibly optional), then it would be best to have 3 > > > different properties. > > > > That format comes from the command line dom0 memory parameter, in the > > hyperlaunch series I reused that existing parser that I am fairly confident > > will be maintained. > > Fair enough. However, I am still unconvinced this is the way to go. I don't > have a strong argument other than 'memory' is already a number for dom0less DT > and it sounds strange to change it. > > Stefano, Bertrand, any opinions? The current way to express domain memory in dom0less is not my favorite. However, for the sake of minimizing changes, I think we should re-use it as-is. That is my preference. If the min/max parameters, currently unsupported, are must-have, then yes we could introduce them as a change to the dom0less interface. I think we have 3 options: - Expand the existing memory node in a backware compatible way, i.e. min and max could be the second and third cell of "memory" - Introduce a new parameter to express memory, min and max, it cannot be called "memory" as it would conflict with the same name we use in dom0less - for instance, memory_string or memory_str if we use a string type - or memory_limits or memory_amounts if we use numerical types - Introduce 2 new parameters to specify min and max separately in addition to memory I am fine with all three, but I think this is not a high-priority item as most domains would work fine with just memory specified (without min and max). --8323329-1287296653-1691539381=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 00:45:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 00:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580633.908988 (Exim 4.92) (envelope-from ) id 1qTXK7-0005ZY-AP; Wed, 09 Aug 2023 00:45:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580633.908988; Wed, 09 Aug 2023 00:45:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXK7-0005ZR-79; Wed, 09 Aug 2023 00:45:15 +0000 Received: by outflank-mailman (input) for mailman id 580633; Wed, 09 Aug 2023 00:45:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTXK5-0003tO-O7 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 00:45:13 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id feb17dce-364d-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 02:45:11 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 92715621E5; Wed, 9 Aug 2023 00:45:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC1B0C433C8; Wed, 9 Aug 2023 00:45:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: feb17dce-364d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691541910; bh=Mnkd2lJGxIDT+8evqkZP6daLEcD0abcyJwr+5/uqVg0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=K6ITTMi0PDiSS0e0r8RtzRLyvG2AzWAkENpL4+TrukpQoJ5nQYVOwemdFJ07q1EOJ lg7o2IpCfEvOv98o5Aa6G6Qy48CvjC/fLOrKJnhC5JlTQYac8ssPxPJyPU/AoGyE+H roBjqgOUXEojUm9C0kyMADysrTfdK+P2fs2Pr8rqz4by328gA8ePa9yqvc3+gh+DHB QHN21dVnuDTVGIFgEqS+jqrlIl4pdqbqaYTPgBQ8k+ekNC1v9F64G+/Pvjni+gJI+P IcxlBR/wDcoLTw6bXgRvWnUCowXQ1jNud2R4YVCf/U8uGRyzFxxtNQw14KnFDYYwPr 6qWpIDdNxyKfA== Date: Tue, 8 Aug 2023 17:45:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Michal Orzel , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <65e62111-7997-de4d-cf12-15d89ec87471@apertussolutions.com> <2a72cbf1-a9d7-6edf-37f6-5197c9d40452@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Daniel P. Smith wrote: > On 8/4/23 03:06, Michal Orzel wrote: > > Hi Daniel, > > > > On 03/08/2023 18:57, Daniel P. Smith wrote: > > > > > > > > > On 8/3/23 07:45, Michal Orzel wrote: > > > > Hi Daniel, > > > > > > > > On 03/08/2023 12:44, Daniel P. Smith wrote: > > > > > > > > > > > > > > > With on going development of hyperlaunch, changes to the device tree > > > > > definitions > > > > > has been necessary. This commit updates the specification for all > > > > > current changes > > > > > along with changes expected to be made in finalizing the capability. > > > > > > > > > > This commit also adds a HYPERLAUNCH section to the MAINTAINERS file > > > > > and places > > > > > this documentation under its purview. It also reserves the path > > > > > `xen/common/domain-builder` for the hyperlaunch domain builder code > > > > > base. > > > > > > > > > > Signed-off-by: Daniel P. Smith > > > > [...] > > > > > + > > > > > memory > > > > > - The amount of memory to assign to the domain, in KBs. > > > > > + The amount of memory to assign to the domain, in KBs. This field > > > > > uses a DTB > > > > > + Reg which contains a start and size. For memory allocation start > > > > > may or may > > > > > + not have significance but size will always be used for the amount > > > > > of memory > > > > > Required. > > > > > > > > > > + Format: String min: | max: | , e.g. "256M" > > > > There is a mismatch between the description and above format: > > > > - KB vs MB > > > > - string vs reg format > > > > - the x86 example uses string and Arm uses reg format > > > > > > Hmmm. I missed this in the hyperlaunch v1 update. In the original design > > > that came from the working group it was going to use a reg as suggest by > > > dom0less. During development of v1, we found it was not rich enough to > > > express how Dom0 could be allocated memory and switched to a string to > > > mirror the dom0 memory hypervisor command line parameter. > > On Arm, dom0_mem cmdline parameter is used to specify only size (no min,max) > > I understand. For general domain construction, these are legitimate values and > hyperlaunch is meant to be able to fully construct a running environment just > as if it was constructed by a toolstack. This is a good goal to have. > We must also be able to handle > situations where a general configuration is being reused across systems and > must be able to express the minimum memory each domain must have, how much > should be attempted to be allocated, and if ballooning is enabled, being able > to articulate that to the hyperlaunch domain builder. I agree and most of those can already be specified in dom0less. The minimum/maximum memory amounts are an exception. > I did not say this in reply to Julien, but I am not opposed to three separate > parameters if that is what the conscience arrives at. I found the existing > parser and the structure it creates as a useful and reusable component for > obtaining and storing the values. Yes, if they are required we just need to agree on a format to specify minimum/maximum. We have options. > > > A question for those involved with dom0less, is what are the opinions > > > about using this form for memory allocation. Is it required/possible to > > > be able to instruct the hypervisor what physical address to use as the > > > start of a domain's memory? > > "memory" dt property is used to specify just amount of memory for domain in > > KBs using reg format. > > It is not used to specify the static memory region (with start and size). > > For that, we have another property called "xen,static-mem". > > Therefore, it would be possible to switch memory to string but it would not > > be compatible with the current use anymore. > > It would be compatible in the sense that dom0less-compatibility-mode could > still accept it as just amount of memory. Which brings up a good point, > whether I do it here or it is done in the patch series that will introduce > dom0less-compatibilty-mode, there probably will need to be a top level flag > under the hypervisor node to indicate it is a dom0less compatible > configuration. I don't think is a good idea to have a dom0less-compatibility-mode. I think we should have a single interface between dom0less and hyperlaunch. I think we should start with the existing dom0less interface and add anything missing (e.g. module-index, min/max). From xen-devel-bounces@lists.xenproject.org Wed Aug 09 01:33:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 01:33:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580642.908998 (Exim 4.92) (envelope-from ) id 1qTY4l-0004ey-PL; Wed, 09 Aug 2023 01:33:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580642.908998; Wed, 09 Aug 2023 01:33:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTY4l-0004em-J1; Wed, 09 Aug 2023 01:33:27 +0000 Received: by outflank-mailman (input) for mailman id 580642; Wed, 09 Aug 2023 01:33:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTY4j-0004eg-Ks for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 01:33:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba57a726-3654-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 03:33:23 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E39562EA4; Wed, 9 Aug 2023 01:33:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C5C0C433C8; Wed, 9 Aug 2023 01:33:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba57a726-3654-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691544801; bh=qGY73qrlSIzq7u5mbmYNyXsFJt6vFXG6r9EIUsbT6WU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mbTodNKQPxalCMvoh65i6wUivV5kYPF+ryG88bp3EztOCCqJt5FNpHdHPHqn3VC1p 4iMCOqbN9afHFLW8sbYlhwdD5S8iaMSbdc8AYjKCWGPME7PHiIuy4V07pjvI4d+uk2 eZ/YtUjdOBqXMQn0D1SZcdxg7SaeX38QHHMcbENbduU6M0IPXBWg3ipkDN+m7lnuZD CACpYCtwAH/WpzLsMe5LNWH6vwtq83EbO0QC9AQY9gDwbCq4elPQ68298/5R/w+22s S6kH5vUfYWnHQaOduUgkEzjxPXjZIP4WrjCAZPQOYOWprRon3uUyM4TleYRcw6wrA7 Cu2ItL3KqecLw== Date: Tue, 8 Aug 2023 18:33:18 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Bertrand Marquis Subject: Re: [PATCH v2 1/2] docs: update hyperlaunch device tree In-Reply-To: <14e22832-6e40-43a4-8dea-1f9b2141b2b4@xen.org> Message-ID: References: <20230803104438.24720-1-dpsmith@apertussolutions.com> <20230803104438.24720-2-dpsmith@apertussolutions.com> <14e22832-6e40-43a4-8dea-1f9b2141b2b4@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-986984340-1691544801=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-986984340-1691544801=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 8 Aug 2023, Julien Grall wrote: > > + > > + role = <9>; > > Reading this, I wonder if using number is actually a good idea. While this is > machine friendly, this is not human friendly. +1 > The most human friendly interface would be to use string, but I understand > this is more complex to parse. So maybe we could use some pre-processing (like > Linux does) to ease the creation of the hyperlaunch DT. > > Bertrand, Stefano, what do you think? I think that some preprocessing (e.g. ImageBuilder) is very likely required. At the same time I think that "role" could make sense as a string and parsed as a string without issues. I am happy either way. > > + mode = <12>; > > + > > + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 > > 13 F0 8C]; > > + > > + cpus = <1>; > > + memory = "1024M"; > > + > > + kernel { > > + compatible = "module,kernel", "module,index"; > > + module-index = <1>; > > + }; > > + > > + initrd { > > + compatible = "module,ramdisk", "module,index"; > > + module-index = <2>; > > + }; > > + }; > > + > > + dom1 { > > + compatible = "xen,domain"; > > + domid = <1>; > > + role = <0>; > > + capability = <1>; > > + mode = <12>; > > + domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 > > 54 1A 74]; > > + cpus = <1>; > > + memory = "1024M"; > > + > > + kernel { > > + compatible = "module,kernel", "module,index"; > > + module-index = <3>; > > + bootargs = "console=hvc0 earlyprintk=xen > > root=/dev/ram0 rw"; > > + }; > > + > > + initrd { > > + compatible = "module,ramdisk", "module,index"; > > + module-index = <4>; > > + }; > > + }; I think dom1 should be written as follows: dom1 { compatible = "xen,domain"; domid = <1>; role = <0>; capability = <1>; mode = <12>; domain-uuid = [C2 5D 91 CB 60 4B 45 75 89 04 FF 09 64 cpus = <1>; memory = <0 1048576>; kernel { compatible = "multiboot,kernel" "multiboot,module"; module-index = <3>; bootargs = "console=hvc0 earlyprintk=xen0 rw"; }; initrd { compatible = "multiboot,ramdisk" "multiboot,module" module-index = <4>; }; }; > > + }; > > + }; > > + }; > > + > > + > > + > > +The multiboot modules supplied when using the above config would be, in > > order: > > + > > +* (the above config, compiled) > > +* kernel for PVH unbounded domain > > +* ramdisk for PVH unbounded domain > > +* kernel for PVH guest domain > > +* ramdisk for PVH guest domain > > + > > +Module Arm Configuration: > > +""""""""""""""""""""""""" > > + > > +:: > > + > > + /dts-v1/; > > + > > + / { > > + chosen { > > + hypervisor { > > + compatible = “hypervisor,xen†> > + > > + // Configuration container > > + config { > > + compatible = "xen,config"; > > + > > + module { > > + compatible = "module,xsm-policy"; > > + module-addr = <0x0000ff00 0x80>; > > + > > + }; > > + }; > > + > > + // Unbounded Domain definition > > + dom0 { > > + compatible = "xen,domain"; > > + > > + domid = <0>; > > + > > + role = <9>; > > + > > + mode = <12>; /* 64 BIT, PVH */ > > Arm guest have similar feature compare to PVH guest but they are strictly not > the same. So we have been trying to avoid using the term on Arm. > > I would prefer if we continue to avoid using the word 'PVH' to describe Arm. > Lets just call them 'Arm guest'. > > > + > > + memory = <0x0 0x20000>; > > Here you use the integer version, but AFAICT this wasn't described in the > binding above. > > > + security-id = “dom0_tâ€; > > + > > + module { > > + compatible = "module,kernel"; > > + module-addr = <0x0000ff00 0x80>; > > Reading the binding, this is suggest that the first cell is the start address > and the second is the size. Cells are 32-bits. So what if you have a 64-bit > address? > > For 'reg' property, the DT addressed this by using #address-cells and > #size-cells to indicate the number of cells for each. I would not deviate from the dom0less spec on this one, which uses reg for modules addresses and sizes. > > + bootargs = "console=hvc0"; > > + }; > > + module { > > + compatible = "module,ramdisk"; > > + module-addr = <0x0000ff00 0x80>; > > + }; > > + }; > > + }; > > + }; > > + }; > > + > > +The modules that would be supplied when using the above config would be: > > + > > +* (the above config, compiled into hardware tree) > > +* XSM policy > > +* kernel for unbounded domain > > +* ramdisk for unbounded domain > > +* kernel for guest domain > > +* ramdisk for guest domain > > + > > +The hypervisor device tree would be compiled into the hardware device tree > > and > > +provided to Xen using the standard method currently in use. > > It is not clear what you mean by 'compiled in'. Do you mean the /hypervisor > node will be present in the device-tree provided to Xen? That is the way I read it as well. I think this statement is unnecessary as we assume there is only 1 device tree passed to Xen, so this specification would cover the relevant part of it. > > The remaining > > +modules would need to be loaded in the respective addresses specified in > > the > > +`module-addr` property. > > Cheers, > > -- > Julien Grall > --8323329-986984340-1691544801=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 01:37:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 01:37:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580647.909008 (Exim 4.92) (envelope-from ) id 1qTY85-0005FB-6f; Wed, 09 Aug 2023 01:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580647.909008; Wed, 09 Aug 2023 01:36:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTY85-0005F3-1q; Wed, 09 Aug 2023 01:36:53 +0000 Received: by outflank-mailman (input) for mailman id 580647; Wed, 09 Aug 2023 01:36:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTY84-0005Ep-BM for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 01:36:52 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 361a42c4-3655-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 03:36:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A97B9624E5; Wed, 9 Aug 2023 01:36:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F47AC433C7; Wed, 9 Aug 2023 01:36:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 361a42c4-3655-11ee-b280-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691545009; bh=Hqo0K274CWnED+YLh7Sffcn/xf+hdeJU5GsOxxHi3hA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=XBgnvoPflLXaHsIucJ9SrsAXzmnDd6SGSUbjNUPPjgo7J4Sk1uBDHHkzcLSVxKW13 VeRvqktDvD901EdTpeCadCzS4qqaKCsBqTwSpLt4MNTLKN650IuflXixv9cqqkhnzH Hot+gjrkQF40ZV8b7OF8XTJ/eXiPfa4CwN9Kt0hz6bH8lyvgXoPGBwnDZKXjp2QZH2 +9p445r5mF8PuiF6pevOx99lHjHx9cl6fyDjXf0U4nbEYOOHJFz+ZyhfnFkV7dVGp+ h+Ct6wBgtJVsNm+VT3an/D8/FKJBE1fAY56QIYeMsGOUoiNbHDioBWBHl0KokDqeyz ApufED00n95xg== Date: Tue, 8 Aug 2023 18:36:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Daniel P. Smith" cc: Stefano Stabellini , Volodymyr Babchuk , Wei Liu , xen-devel@lists.xenproject.org, Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Subject: Re: [RFC 2/6] roles: provide abstraction for the possible domain roles In-Reply-To: <961664b6-ede3-c803-293a-0aeb5792990d@apertussolutions.com> Message-ID: References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-3-dpsmith@apertussolutions.com> <119710f3-82b1-2066-5fa0-164bd293836e@apertussolutions.com> <961664b6-ede3-c803-293a-0aeb5792990d@apertussolutions.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 8 Aug 2023, Daniel P. Smith wrote: > > Thanks for the example, it is finally clear! > > > > I don't think we should add hardware_dom=1 to the command line (I don't > > know if it was just an example to make it easier to understand for me). > > Instead it should a property on device tree. hardware_dom=1 is not great > > because it is tied to the order of domain construction. Instead it > > should be a device tree property under the specific domain. That way you > > can clearly specify which one is tradition dom0, or which is > > hardware_domain and which is control_domain. > > I was describing with today's code, how you would launch a late hardware > domain. The logic to trigger the hardware transfer from dom0 to the hardware > domain is triggered by the command line parameter `hardware-dom`. With > hyperlaunch, this can eventually be retired and separate control domain and > hardware domain can be constructed at launch as we expose access to > roles/capabilities through its DT interface. +1 > > > > which I don't understand > > > > > > Did the above help? > > > > A lot, thanks! > > Your welcome, glad I was able to articulate it better this time. Thanks for the explanation, it all looks good to me. From xen-devel-bounces@lists.xenproject.org Wed Aug 09 05:18:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 05:18:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580654.909018 (Exim 4.92) (envelope-from ) id 1qTbaH-00036H-CR; Wed, 09 Aug 2023 05:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580654.909018; Wed, 09 Aug 2023 05:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTbaH-00036A-7w; Wed, 09 Aug 2023 05:18:13 +0000 Received: by outflank-mailman (input) for mailman id 580654; Wed, 09 Aug 2023 05:18:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTbaG-00035y-3l; Wed, 09 Aug 2023 05:18:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTbaF-0005rQ-Sw; Wed, 09 Aug 2023 05:18:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTbaF-0001Y1-Jx; Wed, 09 Aug 2023 05:18:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTbaF-0002v2-G6; Wed, 09 Aug 2023 05:18:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8+zsZKVd0fQd04ZTmtbINObcca4bDu1vo5GX0ajRLu8=; b=Hodv0UFI8QmTwgZVpy9L5f8hDw /LYlDI6qeDJjf8qCAOATsV5COILrJm8WMYnECGPq3iKtYQ4EV2CZ5JpfDIgcncU1VzLkEtlbsD8/R lZAx+vyRhbjHBe6pzvnffk8OrVKHEFONm1BUOulQ3mPNZJWQtcJ0fr2Zt+Tx6+VSohFg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182243: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=76c243b1bc59660e3a643c17bff72fe674782564 X-Osstest-Versions-That: xen=56d690efd3ca3c68e1d222f259fb3d216206e8e5 From: osstest service owner Date: Wed, 09 Aug 2023 05:18:11 +0000 flight 182243 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182243/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 76c243b1bc59660e3a643c17bff72fe674782564 baseline version: xen 56d690efd3ca3c68e1d222f259fb3d216206e8e5 Last test of basis 182238 2023-08-08 18:00:28 Z 0 days Testing same since 182243 2023-08-09 02:04:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Michal Orzel Nicola Vetrini Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 56d690efd3..76c243b1bc 76c243b1bc59660e3a643c17bff72fe674782564 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:01:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:01:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580662.909028 (Exim 4.92) (envelope-from ) id 1qTcGT-0000GO-Je; Wed, 09 Aug 2023 06:01:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580662.909028; Wed, 09 Aug 2023 06:01:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcGT-0000GH-GU; Wed, 09 Aug 2023 06:01:49 +0000 Received: by outflank-mailman (input) for mailman id 580662; Wed, 09 Aug 2023 06:01:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcGS-0000GB-Jb for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:01:48 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2061c.outbound.protection.outlook.com [2a01:111:f400:fe12::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39370935-367a-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:01:47 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB8044.eurprd04.prod.outlook.com (2603:10a6:10:1e5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 06:01:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:01:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39370935-367a-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gh9As4dI3RDB6TeFF7fv0i5NlFD1VOUUwhixcy59Ie7EOFqVwbD6eWR5zUEn9V3cOG9HOOc2Vu3Or+0HnKDvx0s6CxjmoBE7d8r70wxUhwmAkoQGDLu4k1ouQ7tHwefSdbypi6QDAJocdck+BHu7vahd/Jc4YEz50OcOZPnGoDDt1+jTAmgNePZm0NA5ROpUQxUbXnIu63CV2FUCPlFOgm51K2RJHveI6lcnbfXlWxfaCPArojpMwulnBvV86aKOlApU3D0c++HtiIxUBtbmvcRmDOcFEhIK3AzawIkeFn6fcAwzogFW+HfNi4gJ2E5HSf0QEpTn9D+eXxeZScU7Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HptNpV9Xu5w/FMHSsalOGCr10g0/JLWelsXEpWUVTU4=; b=H7kMThJhWZfWGqllFuPluFB1fwYN13GKZi/E/U+8PdyzOYE6KzkowAQR9Cvq3RFsCjiwlmTmSLUPjxOTB6RtGldw6HtpZHkFdl5iwNTVm2EzpDkRIZHRGG1t71zlqTOeQJmzrq3Iml5KRbIvmrHkjocbMOWKftoHKTUse91x/+wuET14XRmg4OMRY8qLDPZockaspcSrkdkUTi4EGEdgTBtB+zxGSoU+eU/LMW2auV7cu751U7ymoHQCabdU7T96c8NO0vG55584Fbel9nFeH55yxK5pN6IDjy2uldHmJMpp3P+AQGzLuc08j83gKBdeRvcQXALI+aIwHBuNXk4TIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HptNpV9Xu5w/FMHSsalOGCr10g0/JLWelsXEpWUVTU4=; b=uwG4RFRE+7jGu9IyB84s2XKI31gtS1YA6Z/GaTmzEGCsgbbsjWV9pjW7rp8xL+mJ5FflWanmV9udHausz36sMgqMmuFPpAbLJjxUKUJDltlLeFpm0RdUg3/8YiK47qGe6SAB5gWw7WnRF3aqB7joQh/6czRp+oki6ISJU1ss+QNZBcxBqSWRrVXzkbDrfeQe8nQXVzFNmCcX4B8ODYQRXuFteIk8vbagJS/wB3lGOGvm+Bt1FCGEsJ6InGygmCQmxIgdp5YHMnEgnmcDlhiSlImxYJyV8HOBv8nDOPYhE5PhWaXGpOa6RdhDPN9xOW+A6//yiy8jl0MGh3MDBdcFRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <109c8ea3-a260-9d7f-8408-e3ee217e1696@suse.com> Date: Wed, 9 Aug 2023 08:01:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1 Content-Language: en-US To: Stefano Stabellini Cc: Nicola Vetrini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, George Dunlap , Dario Faggioli , xen-devel@lists.xenproject.org, Julien Grall References: <3f1385f2ddb151a53ca092ea1caeac5d12fd80f5.1690985045.git.nicola.vetrini@bugseng.com> <5135e7ac-1025-3a45-7cf6-d049a15b8df5@suse.com> <6aac7add-544b-4c8a-b397-2a6b6c6b766c@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0169.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB8044:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ca2c3f4-f0c9-4f15-2642-08db989e1bac X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fNSopjrva+5jhqFX8ITYlU/rI3fem5JcfZXSljlIdvfhDUemTs79DL/I+cwm/Xlv9LBOnE9jJKrrkbw6nW8oWoYEiuSGylD3Ya0/346bTjYRRUfe+8HQHchkOzZLVwdX83XdszJ57Gjtnshnh6+OfuuKt3noW3cR13F55cYg8aOaxrMfTxfAViXUKuM9vvpc6Gguw2wt5h6T52FfmruCZ7qi+gKBtXEWAccIJJZ0HpdUzxUzMKmzFILBUR+6R35yrU4rmm5yFyL6wo8AY+xnUoWdQSzhJKXqnK+zYnOetZClu+TfOgIXI9pVQObDFUtLpJDe7jBF8c9OgKwROq63Na7Dg0moSwdAOONj28rxZySMz873T9+lcMXzvcQ+/wRnOc9CcbHXm5ezsK7DViyuzIAJccGDBDLinZD80T9Ea7zzC6aqHQ+/QmiqwmqLaeidGCGiH8LS226gxDyKs00gKGz5wKdefzdjPHssxYr5TkwxJZHNrr2SkGfr3PeDNPNmGT4QgQR6cD40u7lY4/YyA8CCe8Yq388cuGg3n3w9fQJjpvzcHoysfi25ck1YkjLwjnqB7me3wkCeYcpo8U1p2iNhTLCrtKzt2ziDcPEHoV+tn+bDejnzBwxCEoga0tRPnoY8ocqsL8X3zrG+loiiFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(39860400002)(346002)(366004)(396003)(186006)(1800799006)(451199021)(31686004)(478600001)(2616005)(6512007)(26005)(53546011)(6506007)(66946007)(66556008)(66476007)(41300700001)(8676002)(8936002)(316002)(31696002)(2906002)(6916009)(4326008)(6486002)(6666004)(36756003)(54906003)(38100700002)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2tYTU82QldMS1FreEZiYmVzT1hsalNUTTFCTGMxbmZodldKY1F5WFFTVUd0?= =?utf-8?B?M2MyN21LTVNEVzNSTG9NazFqOFFoaG1EWHZ1bm9SVE1GNDZrekhjUjRYSlFj?= =?utf-8?B?bnVqbXZEWVVyUE5LVWdVZUsyY1VUWlBZaGxPZXV3THhOM0FKYzY2ZFlzSzRY?= =?utf-8?B?YzBSZkdTclR4L1pNdVNOczBhWUMwTW9jWXJtUlBCeU13cXU5bDFxNmVFSE5L?= =?utf-8?B?UWVlV1hHWVkzemErcnZXWEVaZit3Y3ZENzBJOUt5bEtMZXJlUEFoYm1vZ0ZM?= =?utf-8?B?U0dZTUNuQytSb3BlUTVqdm5xLzZ3RXVGeFMxTjVaTkxER3ZyMUtDUkF5VTM2?= =?utf-8?B?RWRFSVJ1bm1VSmxJQ0kyR3Q3NnNqMzVHWmlsVW5ScUNmbFJXYnhqSEx0dm5X?= =?utf-8?B?MG9LN3EyaXMreExTVEplbVR4bVhnT2RpVThSaWtmNFhCampYcXRTbE9pMVVu?= =?utf-8?B?amNoWHN5MU1IQ1FVbDBsUGZTeCtTTnNBeEdndTZPSFRwYUZTWW1FTzFGcm9L?= =?utf-8?B?bUFLaCttNTdVbG56aGZ1a0gzNlE2WStOelR6dSt1Ylo5NWFmQUFHcnI3L1Vn?= =?utf-8?B?WVVXa0prYnJqME5XWWZ6bFkyYzVEM21POXZJaGdrZGc4TXRMckdFYk9QZmFS?= =?utf-8?B?eERtK3lBc2FVTGFQKzY1VEtoNzhFVVNjNlpkMjNBWUZkSkxpVDQ2QlEyRlVh?= =?utf-8?B?TzA2QVgyenVPWk9KY1lIY3ROelZhd09wam1IbTZVUWR5ZDhtdngxZkEvckJD?= =?utf-8?B?K2w0N3p3L3E0L08zb25rZHR4eE5lc0dPUGVCT2Zzc1RCc2xydDFRaWJ6cXZU?= =?utf-8?B?aHV5S2FqTHZ2ckd4NnR1Njc5OE9xM2VVRXpJRzRvakRud3d5dzJ4Y0RVWFhK?= =?utf-8?B?ZFZiUzdnbUJTbTh6SU9NN20yaGVmQjRQckowTi80RUVRSFI2NVd0Rm1NZEN4?= =?utf-8?B?eG4zTFZaVktQZFpPSnlGSktYdEhQZld3WkxmeGhDcFUwbVNwZDNQSHQ4NkJN?= =?utf-8?B?ampEeEtFc041NDVFK0M0SzF3bnFPeVhsc2xNMnlMR3ZNL0I0eU1MWENpdi9w?= =?utf-8?B?T2wwTmN6UEhBV25uODd1cm42Q2xtZzR4V2tBRjFkTGk5TUpjak9hWG9jOGFy?= =?utf-8?B?L1Z4YWdGcUxIR0hBQ1BRM3lReWVrSVZKaE0xaDdJTm9rclFxenFkRlNQT0l1?= =?utf-8?B?TTFqZ1hFQzNQbkF0UnI4bVJDTkR5VXNzaTBKa09qY3RHOHYybkJ5UnduY0Vn?= =?utf-8?B?QlNTZ2dtZDZZTXpVZGtGOENaV2htY0N1Y3RjbFozSUQ2QWxaU2pmL1lYR0hQ?= =?utf-8?B?emJuR2xOVFZhczFzaUNlNFo1aGtiM1VXcDRGQlBuN3FoVXhMNEdkTkxGSk1G?= =?utf-8?B?QUFvRUI3NnE4MC9xQ24yVkxyZTd0ZVZvRHgwRDFNTTlmNHZ3UUV2UHFRcE1y?= =?utf-8?B?MTJJeVRjaHE1S1lRNUpHbG8ydHdMTGVBYjd6S3hDZ2s3dWY5WVQxR1J3c29h?= =?utf-8?B?Y1FNSTBvbi9yR2h1Qm9pTHRXZExxazAxSXE0d2dTZjFmSzJITU1KNEJtYW1M?= =?utf-8?B?aklwenVES3VjOVZLUXBJRWFWQnFsZlNCV2taU3RMc0M1VVpMR1l2T1B2MUNK?= =?utf-8?B?aUdNcThPVk9vaTVxV3l2V0Fob2RPOWloS09RK3RRemU3ZEhVSHo5QVJLVFVX?= =?utf-8?B?VVVJODhNRTMvbW1iL2ZBK2g4d0pZUmtqR3dWczJRVUdyU0Eva0tkU0NPNFBU?= =?utf-8?B?aUJRMnp5ZzljK0VtdExHWWRSWno5ak15RWxVZTMxSzY2SUhuRHp4dEdDeTBN?= =?utf-8?B?eDZNd0g1dFNXci9zOVo2SFFaTGErSThCM1NoeHIrVnJZNVBXak8yakh1MnBr?= =?utf-8?B?Y2loWWJ4VGxjTjVlYmQ5T3VJc0hWdmRla1ovM0VBcW92QUJjczR5MzUyaGRa?= =?utf-8?B?Qm9QZU9YT0JJaEw5TExLUDB6R0dKeldUWnAxYml1NzExMWNYUTZ0WkdlUkUr?= =?utf-8?B?SURLVk1GRXpXbWFOdDQvTlQ2N3U0QUN4NHNoVVdYcHpCbzFJdjFqZDBVdjI3?= =?utf-8?B?MitWbW1GY1FxVEZpTStUZXNpdGpyNHdVdzRHRW1pL0d5L1NQMkhFYmdLRmlu?= =?utf-8?Q?pC/z+BaDjlK7wmBUTF6V2ubU1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca2c3f4-f0c9-4f15-2642-08db989e1bac X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:01:44.4524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jgRIcEGD9xxa8vUzTjr1rBGj5yF0A+sShZnBlkVu94ALknAm8T9uJlYE2KKC7lS4PtUzBU9z+mSoOxZe/E6GPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8044 On 08.08.2023 23:14, Stefano Stabellini wrote: > On Tue, 8 Aug 2023, Julien Grall wrote: >> On 08/08/2023 16:53, Nicola Vetrini wrote: >>>>> ... "return" alone already tells the compiler that "break" is >>>>> unreachable. You don't need unreachable() for that. As said before, >>>>> "break" like this simply want purging (and Misra is wrong to demand >>>>> "break" everywhere - it should instead demand no [unannotated] >>>>> fall-through, which can also be achieved by return, continue, and >>>>> goto). >>>> >>>> My suggestion was in the context of this series where we add >>>> ASSERT_UNREACHABLE() before break. From my understanding, we don't >>>> have a lot of leeway here because, from what Nicola wrote, rule 16.3 >>>> is mandatory. >>>> >>>> So I think using unreachable is better if we every decide to use break >>>> after return. >>>> >>>> Cheers, >>> >>> 16.3 is not Mandatory, just Required. >> >> Ah I misread what you wrote. In that case... >> >>> I was just reluctant to knowingly add one more violation >>> while fixing another before submitting the patch. If indeed 16.3 won't >>> likely be adopted by Xen, >>> then that break should indeed go away. >>> >>> However, the main thing that's holding me back from doing a slimmed-down v2 >>> here is that >>> evidently there's no consensus even on the ASSERT_UNREACHABLE() patches. >> >> ... I agree with the following statement from Jan: >> >> "it should instead demand no [unannotated] fall-through, which can also be >> achieved by return, continue, and goto" > > I also think it is a better idea to have no unannotated fall-through in > switch statements (unless we have a "case" with nothing underneath, so > two cases next to each other). In other words the following are all OK > in my view: > > case A: > do(); > break; > case B: > do(); > return true; > case Ca: > case Cb: > goto fail; > case D: > i++; > continue; > case E: > do(); > /* fall-through */ > case F: > do(); > break; > > While the following is not OK: > > case A: > do(); > case B: > do(); > > This should be what we already do in Xen, although it is not documented > properly. Jan, Julien do you agree? Yes. > If so, could Eclair be configured to check for this pattern (or > similar)? > > We must have one of the following: > - break, continue, return, goto > - /* fall-through */ - fallthrough; (the pseudo keyword that we have; see compiler.h for actually having the documentation you're looking for, albeit missing "continue", and of course not really expected to live [just] there) Jan > - empty case body (case Ca/Cb) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:24:36 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:24:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580669.909038 (Exim 4.92) (envelope-from ) id 1qTccH-0002qS-HU; Wed, 09 Aug 2023 06:24:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580669.909038; Wed, 09 Aug 2023 06:24:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTccH-0002qL-Ds; Wed, 09 Aug 2023 06:24:21 +0000 Received: by outflank-mailman (input) for mailman id 580669; Wed, 09 Aug 2023 06:24:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTccF-0002qF-U0 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:24:19 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20607.outbound.protection.outlook.com [2a01:111:f400:fe12::607]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d708c03-367d-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 08:24:17 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8692.eurprd04.prod.outlook.com (2603:10a6:20b:42b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 06:24:14 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:24:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d708c03-367d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hm5Q5MPJkaGWVRSFijfYYlwflyp6YVPFEwnGyUTBDcz125Byvb44H/oy2jVgN3RwqL5l1LY4Cb2e1yS8bvYLVPIQN4fjEVb0qaBNT4+FhGTcw+H1HoUjqNFrLDliMAlnIpW+8cB5Vk4hlaJFA4ANkhXFV5JPYuXHjoXGItDXbWTRTCvEgSk7oyC1Ca+mv/d8n4BFMutY1+J/uas/YHHaXmRm0w44+yNZwu5D/bmERjQ8piWN12t0vXN7XX8Zv6q5Ykh/ZIJQy2AZh9ebId/2zLoQ8VDSYHerNsTqSv7u8rNb4yEcn/nXqZevHawuE/EMe9QSIBsypctLxeI2baDPHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZcQPoU4wDplfHrsiYLp28heQKr7vwf8EIERgo5gXJWM=; b=UNcMeBu49OW/B+MK33TqQwm2SrzKDFbA4WXV6S7PLUF78WFe0rIO7NIRiRO1XW8jz2/Fd99G4evTKkCfe4K7RRfeHVD8lfyus+stjfYj1fdRkqdlTGRNCqpn+A9tbvFVE1/CKU48kM1ADQ6+Xe9s2gREtBoUn5XgR7/adWSJEPDzt/5wEllMNg9KBTs/ZlvJBXmf5jI9lEpGs9SUYG3LaZQFYgDreO27THhQKN8nC0EolSoYerxo/rFG1WQJFHxqWaTU2BHPEqoCLqcztnLOPYvrciKDolvBbrhRq4vYLte5NebajldnMCavoxTEy1L3ejTvv+NAlsWhVZNXyP6j5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZcQPoU4wDplfHrsiYLp28heQKr7vwf8EIERgo5gXJWM=; b=1mGrltdpyhOsdef5WIFS47N7HAntZn4osPHFnk4p8tTrs1fdls6CnEE+jx/Al6Nog/OsJe/tjE4FnPITR08MsYjdyhwMmh4IT3z3S1aZYmxmYCTqdhM6+fNAQ+dNTHGRDLrlpK0KCjoyfr2euy9F8KmaubqzuQCZg+80tD4oOMw+tC4Uz4E9FTDs8MrywB+kQLIWWxiXlag38MSEGCduexVwAsJgdsmTaVJpi4i2jmVHY+jwsMh/9isqmFXFD6VSjuXAIzTnRM4/JmIFGZqYUfVfEiicBIII6aLeEd1EhkUbS60I5rsk58QtPhWAI3NdQl+XyvIYZQXlLjQQstPCng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> Date: Wed, 9 Aug 2023 08:24:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: MISRA violations in hypercall-defs Content-Language: en-US To: Stefano Stabellini Cc: Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Xen-devel References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8692:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9c384c-88c9-4cc3-2083-08db98a14022 X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NJovWp9JWr0FpETeEZoujc35TfCwZh+t5I8m43PeJJW551Zo+o4lxLva7ibaI+o4oBImgQ4hLmsMr1HxZ7oy/guREg3MDMX77VAGfU4OGADIl6hJwXO8R9xeRKmv9FXTseHre5Da0QlFmj2+t6rW6TnjqZKSzcZtMreWbzXNRVyuC5FA5KtLaPZe2QvBcJNiQKI9Ws1PGKQAK8PkLUG64mFwKfZhKzPlrN/235ypsaGPEvLlFCbmeDJScV73LrG6ufLIOUXQ0TKut8FKUdbacDlry2/yE1mvAeC9A86XAxJsds8GQcWuXHHzAc62FT4G3W+ONfsgLH7HFTrxzKmraeSTQOs5PKxbALpeEq/XwjtW2ZejhddTk/2zUr1mvJL9dm78Cacxi1ns7KiBbiZxiiHgnIuT0ij/Q3qbyNOt3SyWDLziMLyej0zLbKZZVsIVbvpUKwOyuePBudW+wOn6e5kBh7WClkXIgIHTM2CYPn69jE6kVIsLboJG6xYbRMO2Qw2RdnddQ9oxfJM5bi+GkaN4eTC7vK2//526v+rVVnF46C1EQZXr/WZInKs8LcVLIoFxDJn8DJo1YoKhE4gp2PK5FgFU7ZIia5t9QZEag/Ekl04b/it8kjOTb5LtMTD6WY9l4A91T52VLPu4Pq32uw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199021)(1800799006)(186006)(31686004)(86362001)(316002)(31696002)(66476007)(4326008)(6916009)(66556008)(8936002)(8676002)(2906002)(53546011)(5660300002)(38100700002)(36756003)(41300700001)(66946007)(54906003)(2616005)(66574015)(83380400001)(478600001)(6506007)(26005)(6512007)(966005)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2hvMm51KzZtNEZPUTlDcmdzU2lFMURyV1l0WXFtV01KKy91R0RMYWxxNjZN?= =?utf-8?B?MHhMNFdNcGEwS1hBSzRadFN5aXRiMllGMngxZ0RqU1I1N0wzSEx0dVJLUDFy?= =?utf-8?B?bHNCMy9HMlVLWlBmNWRVeHJUSmlsNUgycm13dWN2RUxNOFRwOUhRUE9yR1N3?= =?utf-8?B?Nzd4d0t1eVIyZEF6cEswTVVOSTFnNjlxSGRjbGhxV3VPNUpUMW9tMU1oVStP?= =?utf-8?B?aTltc2tROURIc3VBbmpmNWp4cjlKUTk2N2MzcUYxRmMxdUdpa21RWlZUZWFz?= =?utf-8?B?S0RCTVNaK3VQbE1NbVhmODhSeW9rTGs1SktzenVjNFVYQk1FcEZlZFdqVldB?= =?utf-8?B?K2V3NUtBcDFQVWNYcmlFbXRRUjJLNkh0L0pjR2syYzBITG1vVU5aMy9Ba0la?= =?utf-8?B?bjlCb21tRHh2WGs5ZnlqU1lSRFJSQVNLU1dkVEVUemwxUStIUk9IeVpyV2xj?= =?utf-8?B?aklrdEtMNWUrano1WGs0VFVuWHJIY1dyRUNRZzRhOHl2YmYvZlo1MEM5cjJT?= =?utf-8?B?VmpQM29tTXJZZGU5dUhSaXFQcVhBWExSNnR3YzdWT0tjNEhaQnlSN2pHV2Ji?= =?utf-8?B?OUtUV0tiRWpoZXdQNEF3VzBPRFNMbk1UbnJ5UUJHVjVkY1VRQ0E1cGk4Z2ZO?= =?utf-8?B?VVVhUjFZNEcrVWdoeTdmaEgrZnNqQmlKOWRNQU82VlBvR2R1bEZORThMRDlC?= =?utf-8?B?ZnZDYnBUb1lWc3o0Vzc0d0h0SFppQzI4d25vWWt0RWhsZDVaMHlDM1NXRTgz?= =?utf-8?B?L1M4VTVoSnp1K0VrVWJlR2V3cVczUU5LSGlGN0tCV1JmcDk3Y0hDRkl6UUZt?= =?utf-8?B?TnhRWW5BYnltMFZNQklsdW4wUmZDNTVtdEtGMlN2U2FSc0JKQUpZV2dTbThV?= =?utf-8?B?VG5RcXF0bEgwNER4M0k5TXBiYWNucVhHbG9EdDVQVU9NTmpiNVJBOFZuNEFM?= =?utf-8?B?RUJERnBzTE9sSC92UkwrcXdLWVR3cHdGTHFnR2NhbnVNVDlsakR2d1dtemhj?= =?utf-8?B?Tm1kbUZQWVR0eXREa1l4QzJFWmRvS1VEQ1dBdEtKRlBaN3hSdkl1TUtrZkYv?= =?utf-8?B?SEw4SDkwMndEWnF5VW5yQ0V6clUvdEZ1RW1nYVEyQlBHL3dCeEw4bTVaQmJM?= =?utf-8?B?TkpFY2F3TmIwcWp0dHRKSUc1OTdobG8ybTBhK2RJRmdCekRyRW5WRUtOdHFQ?= =?utf-8?B?SUNYeXd6d3JMMXNvUmF2bzgxZUF2aHdST3lkU2F0bkFjWjFDa3dpNHdNUkI5?= =?utf-8?B?M0R0akhLeWFiajdZR0ErdE1EOFJpajJoMVpSeDVsNVdkSEN4MW1IUGVHWW9l?= =?utf-8?B?aFhkSnNFd2cxazZCdUpPRUtnbVpTRlh6bkNpOVhoMkpweXlHNmVrQXBlc2sv?= =?utf-8?B?SDNoeGJSN1RubEk5VjIyeEZhbitxakNIcHcvWEIzenlnbzhZOThQTHVHTFFQ?= =?utf-8?B?K3VWSlMyeHNLT3pvWFNzMjZYMWxQc3hWb3FmK2VoQmVLOGdLSndYZHFYM0hG?= =?utf-8?B?QWpBeHFacWhKcHppOTRyQ3NlRlc3MTlQZjFFZVgwNHpGY1B5eVJ1U3FlNHVv?= =?utf-8?B?cnlaeXZzVDJtNjZsRGR2RU5GY1ZBd0NWZ2xCMFRmeTEvMy92Nzd3dDBxRHRU?= =?utf-8?B?eTdqamR3NThST1pOeE9EaGJvNUtFcUtsbC83NW5yVk1hZktHclhxcGFmNWdL?= =?utf-8?B?N012MEJaMG56TVh6cEU0VWlqVHhwZUdNNXlIdWZZL2pGR2NreCtkUUppeW9q?= =?utf-8?B?QUsrN2tUT3A2OXJkSlM5bU9FWUt2TlV2TlVGQXNWMFQ4SGEvNmR0N29jNXlL?= =?utf-8?B?UDFvYTJkSkpJUlZzZE5STUhwVGdwdk80UUd2TVd2cVhxcXFlYnVGRlp3Ykpi?= =?utf-8?B?aUFtZE9uM3JGZm5nVTlZakFia1FnMnFiQmNDNnBZeXJrbmIrbW1hV3NjSHhz?= =?utf-8?B?ak5zUkh0RlhUbnc3bzZ4SEtrdUtWNXpON2pNSk1TTWNQaUwwVmJxYW5OVUdw?= =?utf-8?B?bU9nRWxFa0plTVNGaEEwdWNDZ2wzRkg5YkpLbGpuazB6Zjk2OGZYMVlHTHg4?= =?utf-8?B?ME9vUzNWTGF0YzNGTkZJRCthb1J3N2dpdzU3MVEyOFJLVGdBZ1VKWVhWYlp1?= =?utf-8?Q?GPyRCXFGRyH0U0Mpyhgs1xraB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce9c384c-88c9-4cc3-2083-08db98a14022 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:24:13.7481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Po88BpC7tFo2cUM+m34sYmUh6FHEecPBbqmXB/HgKAV8/4j6QTmYMHw+lIWOEtYloQtV5Xr9vAcQZSBjldVvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8692 On 09.08.2023 01:22, Stefano Stabellini wrote: > On Tue, 8 Aug 2023, Jan Beulich wrote: >> On 08.08.2023 10:47, Federico Serafini wrote: >>> Hello everyone. >>> >>> I would like to to ask your opinion about the auto-generated file >>> xen/include/xen/hypercall-defs.h which contains some violations of >>> MISRA C:2012 Rule 8.3: >>> "All declarations of an object or function shall use the same names and >>> type qualifiers". >>> >>> Such violations can be seen at the following links >>> (copy and paste the link on you browser, including also the characters >>> after the '#'): >>> >>> - arm >>> https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} >>> >>> - x86 >>> https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} >>> >>> Some of the violations are due to mismatches on the return types >>> and the use of `ret_t`. >> >> We already said that ret_t will need deviating. For parameter names >> it ought to be possible to suitably rename, like done elsewhere. Whether >> that means renaming in the generator script or in the definitions likely >> again needs judging on a case-by-case basis. > > Is it the case that ret_t is purposedly defined as 'long' for 64-bit x86 > guests and 'int' for 32-bit x86 guests? Yes. > I am asking because it looks like we don't use ret_t at all on ARM and > on the public interfaces. And I wonder how you get away with this. Aiui hypercall return values are 32-bit on Arm32, so I'd expect you to be at risk of truncation issues in a limited set of cases (see in particular the bottom of compat_memory_op(), where out-of-range values are saturated rather than truncated). But maybe in practice this can't happen? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:27:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:27:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580674.909047 (Exim 4.92) (envelope-from ) id 1qTcet-0003Pu-Tg; Wed, 09 Aug 2023 06:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580674.909047; Wed, 09 Aug 2023 06:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcet-0003Pn-R6; Wed, 09 Aug 2023 06:27:03 +0000 Received: by outflank-mailman (input) for mailman id 580674; Wed, 09 Aug 2023 06:27:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTces-0003Ph-UD for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:27:02 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20621.outbound.protection.outlook.com [2a01:111:f400:fe1a::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c00180cd-367d-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:27:02 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7218.eurprd04.prod.outlook.com (2603:10a6:20b:1d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 06:26:59 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:26:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c00180cd-367d-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1wLjXGCfJvvLH+UwLlHB2ZF9vn75+QXPmFBsjgugLA9Bv5QS1xMAW5SHnvMn/gVLdkl2N68KSLLdeq8fR1Yay/x5M35pEwiiLXK4icZSbBHOTA9EF8InsgWkD/EruX19z94118j8pkcc59B2WT4C8cEp7pRLzoP1QFdj7MpGNorj+DgI7mEydSYwyPP/5KD/bndC+2DwNdyKalGNBexRAvwEoTZN3mwrYngqQCfeTX9KPcyAWpvMetTXiLgCgNnugVenyZArW2yKreiZnKbEslnWJ7NS9Dd96smNGciXIU67TGDU6gp15mEwavizh6TWdlDoupKTsM1f/f/iu+v/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D2nDJ5XMJv2EifefEbEul9k7J4abXSvgY3cIrzd6hDU=; b=KEJmEATHZswOQ4rUFL7XmoK2CHP+/Wyh9YfmDk8qHVjtg217AiFccKYAWTukQsDzqKIRB67O08WrdWXSQckSqxaxOtYHw1BvqlqazyQxU4Y+XJiVqibR907K/P+GX9SfE1KXs7FbTaS80xQumG+fuf/N7vkacpMgqy8MfNmkWwMbu8k4Tyuo/Oekt2OM2rLOBoHS4sIBgBCBg7fZTt8ssq9ofAtWgI46aDMDu7d6zn71xEu03vmzX93/Mw9z9HKM78m8YlcpfQV46oFe2HxA61/bJ8oy6wPUtdtvygjbKmXgxV5epXWfHQZYEoDoc/PfWdxcQvPKM5VHlPog3zYf9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D2nDJ5XMJv2EifefEbEul9k7J4abXSvgY3cIrzd6hDU=; b=BWERm0lCsmcliqX4I6GI27IcuHKhARM5kgvSImH+HHy43/Svst9tOuvKSrQwVKEfDgWMOBA1T5jndnxu3J4l4XNCfNaXu5wlhyCsiQQGmSDdMiJnVEEYZ01aCNeFMurpBVgZsVwLpp+Rh1rZv4oAM326iz96R8u0O2Zw4rojjnFQjuiS7rBcRXTg2AEtaP5nKb4DiVF6EGk8OvPWx1B1DdpqJqv0aoZGSlwiA4zrE8sFp0fcYT8lXPLCWMe6s8tDnvuD8BS1+ck9qiqMBH545LNcZNVkhy++ILFys781KIbkomKozHyqy3SzmwV9SIPjGfjwiOdn3GRw0CXR55ivig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1292dc4f-2966-d8c7-53c8-f465dd9344dd@suse.com> Date: Wed, 9 Aug 2023 08:26:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Shawn Anastasio , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> <4ee78808-5807-58e8-2054-016486607713@apertussolutions.com> From: Jan Beulich In-Reply-To: <4ee78808-5807-58e8-2054-016486607713@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0162.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7218:EE_ X-MS-Office365-Filtering-Correlation-Id: e2e5668b-086f-4c23-2733-08db98a1a2b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U+EREC3PAhqKpT8wMC6aS2zX9IEMpWpY7dpPh9r9jyuDVA5LXEX8uxuiHf69BjleRhau9mBAR8cgsF0obA6oFPzsyTUomtMLNamdmiMY1E29MqQg1kleOXiw6yLoCgE88jfVUwPXuH+JrOMBDYmmnr1SM5r4k/KR6nuimOBmp1J6tVr7bYjKUf0bCFcBU5v7djb+6oCvLdDgxlh13VnSM0l4vnBGE/Is21SX5gZbYEswak3ZIFZgnaWgLBKU185nG5a+oUPCTE4DFS+yZd57QBE90tnod5SCQeXj4QJI+yLmNRYlO+h1+q7sjVz0LwnuWiaRHaPUnWaJUiAL30lBwKd9+RdTMAok8EQ6MXbWRmTG9oLejZpeNI+wlqET7g7ECwyo1fFcXCBysIhrPJnBPhFJu/9GC40DD3gIaVctOGTxUIaxu+O/GZd1VAQv3UYuPC7nuNW1jHggXFbDHMnIALYU8iHIVR74VqRPym0VWbXf4poWBhZEZgHxhuNxpTuEFe8U7ON4TWJKVonaFaXIDDkK5H4eWI2MhLLg1qvkzg7OFQpRUpdDyVLBhpL2BsbqYLZtfJPGHN6mzTcWo/Kr3wHsOOOGApDiwInYRBOI5ELRQc8CpjQlfn3pBH5z36SMry9lZP4gtFO+OH+shHgvMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(396003)(346002)(376002)(39860400002)(186006)(451199021)(1800799006)(53546011)(26005)(6506007)(36756003)(31686004)(6512007)(31696002)(86362001)(2616005)(6486002)(478600001)(54906003)(41300700001)(83380400001)(316002)(6916009)(66476007)(66556008)(66946007)(4326008)(5660300002)(38100700002)(8936002)(8676002)(7416002)(4744005)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHE2dVlGQ2hNaEsrS0J4ejFnOFZBbTFybjFVbjg1N0Fkck5zaWNmWURzTFNP?= =?utf-8?B?akZuUzNBbWs3VlA3c3FLV0ZCOW9KQ0xtNEZvOExQbUllLzVNT3kyT3I3d3RR?= =?utf-8?B?TTc3alFLOU1LQmZDNVl3MW1tNFluVFBXOTNGR1BTQUhsTXNYREw0bGxnRlQr?= =?utf-8?B?d1U0eUpyNTl2UkxRc0lJK0xZc1MxcURFT2hrSTNCNmx2b1l3NTFjQWwvaHZT?= =?utf-8?B?R2o2OEM1YnVjQ09qM05TWXhTQjU3TEIrSFI2NXp4cm80ZjhnTjUwQzZPblNy?= =?utf-8?B?VmhUaU5ad1oxL0dIQW1ldWlnd1IrS1duT0RwTmIzWk15T2NNUHVsdVovTWlD?= =?utf-8?B?VzI0QkZnWG9mTWlUMHlvVXJkclo0M1NkaEJTcVdLc2ttc1BvbHhLdDA2QnlK?= =?utf-8?B?UGhVSWpFM0p1NmN3aXB2TlpnNTR2cnVSd1B5OW5KcXdNZm9vRXNPdHI3QXdj?= =?utf-8?B?OUtyS3FGVVB2NklTdk5XK1d6M1FqdlY0aGdXNFIxN1prY3czdUFMbnRBNHFp?= =?utf-8?B?bWNjLzYybjlYWG9rakt3eUJjeUtMdzgyUWVVQ005dGlBZVM1MUU1UFNIY000?= =?utf-8?B?NDM1U3lNREYwRkduRzFiMjlnOSs2N3pOMXZlQ2VMVkkwZmIxR3JGRytPS3lT?= =?utf-8?B?VkxheVZQRFRQbFZmTU9qbGYzaXVNVFdzTW5DUGF6bHRPRW5NUm5ERml1cUVQ?= =?utf-8?B?bG5MWTJwY2ZKVkFEQkpTNDFzZTVJNXN6RTJncnJxdnArUm0wTUJ4TVdNYTgx?= =?utf-8?B?VGZST1RNQzNUa2V4N21za2RnN1RkY1BYak5vbnBia0pSS3dNZW5uZkduRG1z?= =?utf-8?B?OC9NZ1phcnh0aVMxRTMvNmt2VGhyeStzT3hyYVVidTNOQ2Y4d3lSdVM0WjZq?= =?utf-8?B?Q3JHZm05MC8rWFM5YkhEWTV5WXVHUi9pMGFHS3pMb1BkSmcwL09McDk0U0hz?= =?utf-8?B?VU1hdnNSdktsV3djcHlmZ294TmYzNkhYUUVkVnEvMVBVcTdHV1cwcko1QUZR?= =?utf-8?B?cVFhVzI2RTAyUjBMdW1RQ2N3K3JVS0N1MGVVb2pIRTVaYngxeWdYNzd4aVpn?= =?utf-8?B?NmpUQThLUzZGalFvaG9nRVZJa1NCYkloUWZUejBmUlcvVWw3eGRDK2ZkdWRN?= =?utf-8?B?Mml6S0dUaWdiRjBVUm1zMlczYUhzZTNXeUJsK3kyaGRZVXBRMDVMTEtqc0JN?= =?utf-8?B?UE5jQTZwUEVWWVp5WmV4d0ZIRjA2eTYvZVlIdEJmME9HakJraEJJZjJZSysv?= =?utf-8?B?Nkc4R3l4MUJ4L1JZV1VTS1hBVmJ4UFFHSFVRcWQwSU43Z1d4Y2FlSGg5V0FO?= =?utf-8?B?S054K3BBL1ZNc05uVnRIOGVCZ0x4Q3A5MWJWd3BqQ0tVNUpsc21JVTNKV3g5?= =?utf-8?B?YlJwZWNNT3lVOFQyam95NjZJZWNQS3NzR0JMUW5SVzVVNFoxU2pGM3NCOWRB?= =?utf-8?B?M3dXbDFtRTRWeDl3cVI0dUEwSk1YSk5OK2lwNThBenhpWWw3ZFg3RlNNVVpz?= =?utf-8?B?MHh5NEJ6WlJueTRPYjFVRUtNanNUSnNOdTFCblVqekkwRkFFNXd6SXovT085?= =?utf-8?B?NlB0RmlrdUxaRmhoWmMzMFk4UUFGN05EeXRVcFBFSVQ1MWEzN3hmVkMrTDh6?= =?utf-8?B?VUR5UDU2U0ltK3hBczl6bG5XYnE4RFFBWXVwaW53dnlkNDBSdis1MDVlNkhy?= =?utf-8?B?amRhZnJ0RVVIalNpOWZOOXF6VzVOUm5GQ20rYlpmSG9FeU9kVk9teithV1Zy?= =?utf-8?B?TS80VWZYdkk3dWFYdjNxR1dYZnpoWFZ2aFhxK2NTTDFxNFJBVnNIVXVXWjJS?= =?utf-8?B?VGUwT1J2K042OU91dXNsNXhwZ2VmMW5kZVdRa3Zlc213K3NQZ3VRZ3BPbUlp?= =?utf-8?B?ckFIUkFnVGxabk1hM1JtUi9nZlZueERmZjZpVjZOLzVUR1FWVjJPWElxK0RZ?= =?utf-8?B?bEYvT3ljRFF2SldjcVJFWFE4SytpZ08zWTFDcHkwZXVmaGJUdDg1QU9TaHhm?= =?utf-8?B?dUUvTkpneEQ3S1E5UUx0L0ZEUmhwaVczSHEyNXZMcE1yMVhYSExVTVp4dC83?= =?utf-8?B?Z1dCaGEwZUp2R0ptUnFEWnJ1RmF1L20yQUZ2NnIxNnNKN0lsREY5dFR1eXRX?= =?utf-8?Q?ca/zJz+NILBO6iEef2Rz2Ey15?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2e5668b-086f-4c23-2733-08db98a1a2b2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:26:59.1060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 09lnmJIU0cSjYOk4Xl9PrAni9HYQEoHFS2oNRmx4uWndW5idTnnr85UZGwODWmr+yWf9UHaCPZplDXzZ8kJhow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7218 On 08.08.2023 18:43, Daniel P. Smith wrote: > On 8/4/23 02:08, Jan Beulich wrote: >> Have these in one place, for all architectures to use. Also use the C99 >> types as the "original" ones, and derive the Linux compatible ones >> (which we're trying to phase out). For __s, seeing that no uses exist >> anymore, move them to a new Linux compatibility header (as an act of >> precaution - as said, we don't have any uses of these types right now). >> >> In some Flask sources inclusion of asm/byteorder.h needs moving later. > > I just did a test build against staging for x86 with all asm/byteorder.h > includes removed from FLASK and it built successfully. If there are no > object to a small non-functional change patch, I can clean up include > ordering as well and submit it to xen-devel. Of course, please go ahead. Simplifies the patch here. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:32:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:32:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580682.909058 (Exim 4.92) (envelope-from ) id 1qTckL-0004tq-Gr; Wed, 09 Aug 2023 06:32:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580682.909058; Wed, 09 Aug 2023 06:32:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTckL-0004tj-E6; Wed, 09 Aug 2023 06:32:41 +0000 Received: by outflank-mailman (input) for mailman id 580682; Wed, 09 Aug 2023 06:32:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTckJ-0004td-Mi for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:32:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0c::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88c6cb3e-367e-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:32:38 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBAPR04MB7432.eurprd04.prod.outlook.com (2603:10a6:10:1a9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 06:32:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:32:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88c6cb3e-367e-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XMHlAQYnI2uMNs+y32FX25ir+y3qfwnab9iIpoVNOJEYMLqaib4maOX25C0Uuiz7h51gSW5j9ZbHsiu8Et0srl5Xyr8q2gukDQVNJuDssJilddHSC5Ll21EBt0KkYZhOpb+VBeKKUvrq4YB25D/xJSsc+CMwkj3zd4B1muxaPlMJfSuUnVgQ0E723SJt5j8OuiPPwB1CQ/n6WqXCH7NSdIwMsSFSASm4LETs3idgcV4nhbvy9EnEq7Csbkh87DIntD7N4QERyNshBylkUvorkZC3BHS3tLNdcZxEOQJdLNyzYl6eYmBGSlZPi597ObqB3vVjJI5hG4VbqoY3WJnzoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ByodkMIVROhN2z9DAPf8Hsi6nxk9Y2/Zf7NQe4V6UoM=; b=iXDMFbIOU5ZA8alGKY09D9zKoQXb+aS49JwEQyYXBOFKDhq3vPSeZfv7df+6IdrIi68oPYt2zdlkdeJUMQCeRhFRQwGi8sqr5FfwQb8GJVUO0NEFylD8kiPd0nRTaRrosJ+cydBrT0e38bb3GerPAUc0XF89BNBEFRn9Gmca3YpgLo0aAHADUABuWjnCqE/5NVAnVSXjLMQr1suLFAxZ8igkwweo5Dycmkd2OzGGTItGWbcyrL6AZah/OTqhXdisaMfxrLSZuqj5h53+YL2Tjon0wxVs8ECUvPHlzJQ4NF177+tPBURu0tu2//2wAEfH+p1iis470xM9IZQosaKa1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ByodkMIVROhN2z9DAPf8Hsi6nxk9Y2/Zf7NQe4V6UoM=; b=E+9I/f1kNjWn0rEjkD3kblyn1fN2v8naIj1Ne3qM9HDGj0jiSkV5aTWafNWf6IPrQetiQ30ySnt8/IwZ1fmunUiAyPjdcXjNNtjiD+FdQN4HnoXkfBG/aWP/Ptl0c2RDEaMSZnsCApbDGEjOzVjVF9iRc1PzMcE4wl1qbO9p0hXRKjPXvszhGmyzbEbmIZ+KyeYLdYH19Cf9FarrWsrs3/f1MUXDgjp6N602jN/S4wuVu16ALRje2jvDUG9EHZAd0kYOOYyN17Jmxg6soc69EpT9tHXDB6w5p3rmc2T0fAKY6yxog3cuEKH8J6IslgiSgprXEBYXK7yVnMYrbWhQDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 08:32:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Alexandru Isaila , Petre Pircalabu , federico.serafini@bugseng.com, tamas@tklengyel.com, george.dunlap@cloud.com References: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com> <4722cb01-2e0a-6a12-b398-0ddd024b50bd@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBAPR04MB7432:EE_ X-MS-Office365-Filtering-Correlation-Id: b6015a15-67b8-4b6c-b7d7-08db98a26b8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mTuWaqSCO0XI6Ghb0Dl0D5V7r6XKZ9/LnjmsCp/xa5u3KPkQuVbrkPlC/LIyjwQS96cvOuRoegMH5ExoNJHp9VAUrTH+IDXFeb9xC4eqLX+Eyu6cEPKayRDltpAeXdQX4OyKH8rGAdChnQ2Eu0l5BLobGi/XA1EGX2qD+DpzR5vt3IoNiDE9Brsk55M77OGS7/KVZB+T9I81DCRiUql34DnZWP9PCgRfewWMtfJ0lI75flZo9b38HIPF86mv7LiV8QcueTR811arIc/Tmg0HRw5RetLOUxjS1JHoHgt/uqFyqWG2/6SfyX9cKHjoPtNrEDeejFF+mgd+pctWMo9gYtm/Qa9nycCGQBn1hKGxiOrqS24qOXwIZAmchOdL0K2rEZyIaeYMm2sF+6kox2q4lI7sNOZlIiEQVqbmri185Vtyi4VN0JoasuXjdLqEb+565HiF+qB0/nKBSbAqd5UGuUP9QIFGfTo+EGH29nitA+eZ6UtCRxjJVdeFxdWA6dFewYx34/cNX7p0T3qyFohnDTcG/DbYxAN4TkIg7emAuAs+REIf3z6oMOXN+tNgk0ki6CJUsEYRIcHwhwnwqP+hjzBFOvDqHu0yyLNClc/M0iK+m1GT5Gy2RP6fLxbVRr9l3DuIxK98Qg5ka0HQGLUhng== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(346002)(366004)(39860400002)(136003)(1800799006)(451199021)(186006)(966005)(6512007)(26005)(6506007)(53546011)(54906003)(36756003)(38100700002)(5660300002)(86362001)(31696002)(4744005)(2906002)(4326008)(6916009)(66476007)(66556008)(66946007)(8936002)(8676002)(316002)(41300700001)(6666004)(6486002)(478600001)(31686004)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUxMd2Z5dzVqQ2p5ZEdSdTkrMEwyUk03WWpWQ3phdkhiMjNZamRta0NNMDRE?= =?utf-8?B?RmVjdEFIYkorVTlISTZTWlJOa0drUzdtU3I1NjdaZm5rSmIrQ0t3M25Ed096?= =?utf-8?B?bnVyWm5laTRFano2dEo2c2pLWFFYRURvYVhUQlFDZldsS1hBRkU1aDFrdENa?= =?utf-8?B?Q2NnaUdYSDJoL1psSmIwQjl0QTF0Nk5ZUkNwRlpPQW1nKzlpekpKdGVKWGJZ?= =?utf-8?B?VkNJZ0I4SXN1Uk5WL2RJYnkyZXU3WkEzRXk4bG8xUzR1bi9RNmVPazdKT05K?= =?utf-8?B?SmF0NTBxR0U2RVdHMVBvbVBkTHgvTzJkOWhkZ1FNWDNYckZuS3p1cjcrc0lH?= =?utf-8?B?ekJmcXRBMFJyZXRzSGVYV1NTSGlVM1JSb2hlUGVxU1E5dVRldno0cFRtZDZw?= =?utf-8?B?N0tYMi9sVHdSV25yRHp5d3VvaFV2VU56T3lYQ3JUald5UG5lcFcvSW5Cc0hp?= =?utf-8?B?QXBpT1pKd3lJQkJ6NGxFOEw2UUZ1MmYxdGh1RUdhcVp5aURMVmNlWlZDM09s?= =?utf-8?B?U0VlVFcybTdoK0RZQXI2U0V3UTV2RnVFejdPSy9UaWZZSmR3a0NzUU5ZcUV0?= =?utf-8?B?dWhuaTFDYndxVm9hcEh2UGJKaEhuVjZWMjRLVWNLT2t6SFpwZDMrWDR1S0pi?= =?utf-8?B?eW5YRXErZDI3YVlzUHJPdS96RU9xb1p5RGsrS2JYNWoxYTFrM2tHSDRqZzdD?= =?utf-8?B?bjlaS2x2NVdXWXFzcGoyYXVoZlhJekIyUDI1QUFjS1pSYlNVaW5kRWJ4VTFz?= =?utf-8?B?MnFqMHlVenhQV2h3MjkyN3U5RWh0YVNuZTU5Wk12bFJCd1JyeFR3SGdMYzJp?= =?utf-8?B?WnNJWHV0Z2FvNGM4RDhQTmtoVWNtRlB6UmtxRHErcUhCUkE0NHV5andaWEhn?= =?utf-8?B?OTFqeW5kTXVGbmpFTkJ2L3E3bHZrRTN1TVVLRWhKL2hJa05VbXFPckNOSDlu?= =?utf-8?B?OGVLdWRQS081ZEdHaFpnb2t4OEFCbE9mUTlvK0wvVzlHY3dDalBZeDhWTFJC?= =?utf-8?B?SzJhOU4zQ3FnRVlVeHRlZU1GVTRFVi92OEVDb09hTkdBd3pnc0ROd2xUYzdS?= =?utf-8?B?d3h6Rjd1K3hkVk0rMjVCNUYvUUdHbGZIR21TZ3JpbFovdHhjOUhjSXRCSjNl?= =?utf-8?B?b1ZpVVVEVnJMY3ZBRnpjSWVITzBPQ21FMGFKWmxYS3JaenhHTkNyT3Q4dGhC?= =?utf-8?B?cVJFTTVtT2llZTR4Q0M3Rm5ScVNTSXZEa0pxMWNaWG9VdkMvNEtPWEU2L3lT?= =?utf-8?B?VXF6Z1hkNURkV3V4R2tZd3ZlekxJT0lhWnc1K0xSRUt0SEwzVVRKY3pjQWpY?= =?utf-8?B?UXJZN3hmVWtHY2JsZk5yaDVvVHhLUnNla1FSNE5SODA5R1JlUVBoUWN2N250?= =?utf-8?B?VHcvWXpUa3czMlFiZldvd3lNWWg0MkkydmIyaFNjSEtNUlFTblpMdEtIODkx?= =?utf-8?B?bW95UlhmY3RNU2pNRi9ra0xLcStnSy9GNC9Ma0g3QSt4WHZ3NjFUcFNPellO?= =?utf-8?B?MTF2MUhod1dRZWRVdm85Um1jaU5UNjlYRDNqQ0NIYWRsbDdtOXlRZWloMEs5?= =?utf-8?B?Z3h4QnVUV3VEZ0pkMXVYTm9aOHViZTdDMFVoWE92UWRmcTNEZkpENTY1UnIr?= =?utf-8?B?WFo5cUlWZ1dFajM2dnYyKytjdDMwTCtnZVVjeFNNMG5kaHVQUU1IcUpZVnMy?= =?utf-8?B?RFVJa0lVUm5JMG56STVWK0dZMDRGRjgyaTB5NHNXMGwvbTF4bGtYZlRidGtw?= =?utf-8?B?YWxCT2QzeVZVa1VadSsrUUwyakJxcG5Sc0VsV0ZCSUdRYXg1OXZqYi9zTFlU?= =?utf-8?B?b3lkZTlHQjJkY1VuSzNHTko0bnVSTzhROENkbWdTL2tSWlp0SGVxampBWmN0?= =?utf-8?B?ajh2MXcwNDMxL3Z6VEV1eW9vSDVYVnN4aCtKbmtueHhocEIvdVFkMzk1aWFi?= =?utf-8?B?SDRGQU5OaDdxaHdoY1NVbS82aTlGbXJCTjRMVnNqQjVodFdOQ0xvQkZ3K0p0?= =?utf-8?B?bm9tcWNHY2FlTHFjaUNEaXFVZzZTSHNsRHZhZWxhaHZsUEFVZ1BuUWg5c3Zj?= =?utf-8?B?aFhkeUQ0NEVVdjhmWFRJanRSY3VwakNBZjBhV2Vub1g5aXJDNDN3WjhmUkNF?= =?utf-8?Q?w3aN3raJY/3hFH2ci0IpPzY1H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6015a15-67b8-4b6c-b7d7-08db98a26b8b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:32:36.2370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KfFwdZjp627pAv+MF7V0GjDRmEeArBuGjaFxHQvIP5JYjMEyfpgoMq4Px9w+kXGvbGmpAbvC39QsFyDKsGmW4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7432 On 08.08.2023 22:15, Stefano Stabellini wrote: > On Tue, 8 Aug 2023, Jan Beulich wrote: >> On 04.08.2023 23:39, Stefano Stabellini wrote: >>> Hi Tamas, >>> >>> May I have your ack on this change? >> >> I see you committed this, and there is an ack in the commit, but I can't >> see any ack on list (incl when checking mail archives, to exclude an >> issue with my mailbox). > > That is strange! Something appears to be wrong with xen-devel. Adding > George in CC and attaching Tamas' reply. Yet more strange: The attachment (as it arrived here) is zero size. But I can see it at https://lists.xen.org/archives/html/xen-devel/2023-08/msg00959.html Part of the reason may be that it looks to have been a HTML mail (which it shouldn't have been). Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:39:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:39:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580690.909068 (Exim 4.92) (envelope-from ) id 1qTcrC-0005bb-Bx; Wed, 09 Aug 2023 06:39:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580690.909068; Wed, 09 Aug 2023 06:39:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcrC-0005bU-9M; Wed, 09 Aug 2023 06:39:46 +0000 Received: by outflank-mailman (input) for mailman id 580690; Wed, 09 Aug 2023 06:39:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcrB-0005bO-Gn for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:39:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0605.outbound.protection.outlook.com [2a01:111:f400:fe0c::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 86963bc5-367f-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:39:44 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9195.eurprd04.prod.outlook.com (2603:10a6:10:2fa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 06:39:41 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:39:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86963bc5-367f-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlgUx+U4hK1ednOtWqEdo7yGaM6pqnrUnGkzhEiRCkaZRL1S92qmlHxFo8FBgZukn8xMC0aqwN9LM2B80u3ABiHyXG51PN9pwkY1i9qQ+6BnX1cWtVy+zjiIrn58tKFfBGPZcDypwL9MpN5rUsC/fYYYKLdpzOgz2DIf4JEhFxbuAbvZN46dnG7hpnXFW/uWYlMiFXZXsmNQpHhj4l45UHk66Bsei/d1oYFWS1iJzmmBfqPXjsKlZTrFnqaY0XbwYR/bvSwfOVxsR2e+odU1fRcE8fdYVgnpQRX1w5QqVgygIK2npvdAG5aSjJRDdS+3ZKIxVVVYjaDr08FXAuUBTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uZ4awkKV8+Y/0cKxPAF4bECQPSCs1gIuSPS13v726vk=; b=EaHtuXRuaJ9Ad0LjFuDg0+WsgooAUNnNcnyXXM2sNOzZMgrHt5a62o4y3ajPL+D+VW4XDWscJGLwWYLXWetxuv6wMQtGoCFfq8SOfKRF8R/lScpvgz2VzmCyCNJZI4/Br0EPAKww3jOyzgK9LyagQx7gHkWu1dXFEt31fr6gBsgo/j2EVMujChTtHRs0R6cob8qvv6caDWxOx29glfgFsy1FO/+Wg+mMqRQ6GyofUdzGq+S4oCOIRL+4fH3u1L4b61YZlq23St4K0GEgUJcvTmVcbd3hPjkvJ1kzgbQpHXbOmiIbB8h42nGhOFTZuiKp9B50tgIYDEfImZJ10nggZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uZ4awkKV8+Y/0cKxPAF4bECQPSCs1gIuSPS13v726vk=; b=1Y4vlXhl+pPv/WbXkLuGxTtzvqk3mZEZrW4IuS55n+8nr+n73fd5N9U1i/tbi80Tt/N2fmVnIRJVZ5qMuSqhR8C2CQqCehMyMcAZ5zGhthFARlHjCZ44wS0Prgrnprz4gFW/MY2SSCHDcBwpZ2VriDkC8oU/5B9p5RV6rD6znyRtUllT1rN2EY/vZ1/NZG8/WzQKZvLIzoCyIEnXQrteH0LJmN8y8jQ5Tza4NQZ4IUvyjY4mLEHg7fsBcX91uDS/2HkUemkZuOnlNnL7qXtoDiIscrQ031bjiwWEwX1E8TnEO9dsBdko5PMkiyDY1MxO3qyTdbK7BDlSgOXG3JYOnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3667bf0b-5e5b-ac31-4d79-122f8ad159be@suse.com> Date: Wed, 9 Aug 2023 08:39:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] console: generalize the ability for domU access Content-Language: en-US To: "Daniel P. Smith" Cc: Christopher Clark , Luca Fancellu , Henry Wang , Bertrand Marquis , Volodymyr Babchuk , Stefano Stabellini , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801160608.19219-1-dpsmith@apertussolutions.com> <3b889079-571a-a83a-0cba-c30cf2ce0b1b@suse.com> <01a80d4c-f19b-98ec-805e-e648e752d6b1@suse.com> <2ded224f-0b8b-90fe-367a-91762d1f25d5@suse.com> <72274554-5942-294e-aa1f-a594ae2e37e9@apertussolutions.com> From: Jan Beulich In-Reply-To: <72274554-5942-294e-aa1f-a594ae2e37e9@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9195:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d901e04-f341-4936-ea6d-08db98a368a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MEvxUb09zAbUR+afv7cvx+qBB5oLm7XMdmBza1lCKNiHdgFbFw5jv0KWI5FDeRuZHJZISqWef6g0CubegQ8whlD/X1W53Os3p2VdN7zL9MitkNPoMoLhT/I+sz+IRJasgSwOw6Z6BZvBh3i4Zs6joNROurU9XEn6sWCuna4KuH99JJYj5FOo/08YAoexQSvidr0yBrDUeUpUrTKGH68zofUbGf2aZKDTEKXx+0RgAs2EsjWAkPlGsP7HbqlsaS8M9Y55obsrnLy5qr6mJ68S3vH5zCqBhNjEeXz//kk7/zmOGzTduJRbL1K5xGLlf2v6DBrBJisZJxkOtV+kI54swbQYM7R61Ds5lxiEFYEBeiz96hy+1rtzGpS5wczCB/9sx/t0jLPcVK38qTJ8b/AlEqJbCM4G41KiAamBnFrLnN20SbF+FdGlT2SO6fixOe6Yeowm+lwI2VhGOuRj3u2Q5xNIWPhSRDrkNS+269X4nH5NlJPpV7KubrbM74WDFujLmLy8VvrdlyNe1JLUmwGv79zdDnJtjiBdW2imFTCfa5YAQCrTZzRxVEgs9A5aVu2DBG3wew3XB3nuxBKV1KBwdH+pLcUqOC+WnogFqh9ng4U45t0zYxsjQTBvcbFJTGQwQ26x/GCoTWbRXasFmC0R8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(39860400002)(136003)(346002)(366004)(186006)(451199021)(1800799006)(478600001)(31686004)(2616005)(83380400001)(6512007)(26005)(53546011)(6506007)(66946007)(8676002)(316002)(8936002)(31696002)(41300700001)(66556008)(2906002)(4326008)(6916009)(66476007)(6486002)(6666004)(36756003)(38100700002)(54906003)(86362001)(5660300002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTV4bWtIdnlOY0JaelJ3NkFVbGZlU0NhblBpWWdCTCtyV1IvcVp4aElmOGs2?= =?utf-8?B?SWs0b1JkS1QydU41VE5URlR0NDh1c01WZzhzQk5FOThiMXphUG5uTFBCNlJo?= =?utf-8?B?V1FEdkRGbDl2L2UxTTV4Qkc5MTNMMnBWZE95SUhhUzRYWmNRNm1OcWVqWitj?= =?utf-8?B?UUhQa0phSUY5MVpMcmZITUNTRjM4bk1PTngyL2kxVzlGcy9TVVprNEFHaDlC?= =?utf-8?B?cnpacGtLbHdqS080KzkwUi9RUDVzUDBvYUlXVXpIUGY4alJVUk5YZnpCZFBC?= =?utf-8?B?cnhqb0dIanQ4dFVKRC9FS1lxYlFXUTNjRDY0ZU1XbWR0NFlFZVpxSXJIZG9l?= =?utf-8?B?cktwb1E1ckVNME10TnNHWUhrVWRkaG0ycEZLVEhpYzIvaWI4TkczSERtVGY3?= =?utf-8?B?cVRmS1lWSE80VjErV201MWNtUW85SGhPanhPZzZrbGF6amcrOFhSZmFCRW9R?= =?utf-8?B?eTZLQi9mVFJWVENMdTNQZUg5SGRRQzlIdkUrNXVjWksydVRPdWRQU1dwS1VT?= =?utf-8?B?Skg5T3FoY3Z6VkJ3MzNwaXZXbThXc3hNd28zMkUxdXduQUxXbEtQT2JpbHd4?= =?utf-8?B?UWs1UFFOd2E2dVlaUEFUNFpIYjlBL09NUk5CbGdRZWF5ZHZvcUg3ZWVvY092?= =?utf-8?B?VXp2T1hXQkl6UHVvN3Z1ZXduSHhGN0NQODBQdWFBRXdsR3BPT1ljaHY2c1Yv?= =?utf-8?B?RGxlc214TkxkTm9EMWgxdzY4MXB4S3BXcEI1L0VybmlNMVdXMmNpajFVOURw?= =?utf-8?B?ODlHeVlwYVl2eStrY1hmUUdjSWRoMFVtQ3JSK1BoNmJoUVMwYTZFdHpYTnJH?= =?utf-8?B?dUNqbU1DZ0hZUkFwTWdNRjgrVnhSUE5MWTVwNmR4b2pYMTc1Y0ZFZVRpemZv?= =?utf-8?B?ZDYzYjcrZ0phVHlMaEJzMjB4RGRQc1NPOFozUVlrMmV3WVllbGt2V0V6cHhP?= =?utf-8?B?dTZEcFRLa1k3L2w0REFRRGF3bU10UUpxZ3Rmckc2VlFPZmRRL2dXRTk1NHVv?= =?utf-8?B?aTRoTnAvdi9Fb1YzazU4andQeGdtSjBiM2xvNy9Yem1JTGZwK290QVZkbHAw?= =?utf-8?B?N0pYaS84cHA1MUM3RGFSdGJUNkllRndReUx2VXJSRmk1aUw0UHVEUnpXdzFO?= =?utf-8?B?bnFTWVBvdGp2S1dJVHYyeEZyNGpCeGVmS3JvNjB4MEVjUlB1T3F5ajNqckla?= =?utf-8?B?ci9hVTZVb21UOXdlK1ArU3hyRUtMVzVKaUt6VXMzalRoczhUSHRsZWJjSzBr?= =?utf-8?B?NTdCZ2hpOVFUSFhkVWRaMU40LytRSlJ6TnVpYlo4S0RCNHVMK21ML2JGSUFn?= =?utf-8?B?bE44Z1ZkK2ZyQmlQR0V0Zml2VVpVZ2hyc3FQQmgzMXpYUlpDamR3R0JGcUVa?= =?utf-8?B?UjJjMjdQdkIwQWlUUmxyNlcwRFFwK21MOGViQXlrMUVQeWkxeXV0OGVEQkYz?= =?utf-8?B?cGNFQ1NVNjJDQTZHejBXOXhBMlp4WUxtM3hXdjdTZ240MlJiaHNOblcxMith?= =?utf-8?B?RVNGNXV2cnUyV3Q3UWRlbEpPNUtPbjM2ZVE0NEtmc1JwY0hxanQrVm5VTDRG?= =?utf-8?B?eCtQOFMrc0pTaWI5R0xkNC9PaW5FcHloSDVLYXBqZERmZTY3SU45ZHU1T1pT?= =?utf-8?B?M2lwWTJlM2ZIL25kdDdPL1NQaFYvcnI0OEY1ZUlzaVdRNlN4dko4TkRaRjY3?= =?utf-8?B?Z3cydFo3bkNmY3lCTm1wbmpYUHhwOHhjaEk4YXNoNUYySWtvYk0va2RFYStl?= =?utf-8?B?V2RneGlPdDkwVmxJWlp1WmNCRVJKbHFRZkxuVXVGa0E4QjFMc1EzY3lJa000?= =?utf-8?B?S0hXSnBaL2c2ZnFFbW0yZzhTNXNZdTdtbFNtd2JuNGY1RzFPTTRha1FBaWdU?= =?utf-8?B?VkFFcTNOU0RNQzJKVU1Hd2VRaXI0OThUdDRoL2lWZHVEanNpMUx6Y2t4V21r?= =?utf-8?B?MVUyMk9tdXIzMkh5V1l6WTBCWDFFSEJ1V1VaSTJ2bWVuejBZSEtZSjFtMk9u?= =?utf-8?B?cVprczFXUTdsOC9YQ0kwekRkWVduSFRuOUZnL3A4SW0zS2Vnck5ERE51bHRM?= =?utf-8?B?WUdEQVRtMnV6MExrSkIxNnE3aWM0ZzZMbkowby9wSlNSZE9YSXJnRDlXcG51?= =?utf-8?Q?gqRnjz5XbzAtMu7TjfrjEGHnK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d901e04-f341-4936-ea6d-08db98a368a6 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:39:40.7760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kkzQ1hxWISo4zoYH/x98JPV4kDjGdlAu4ehX2yzJ0pQ1f3JPzKADlkEdMG3yG4f7ScrRJjFHO77jatEgr/wKpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9195 On 08.08.2023 18:58, Daniel P. Smith wrote: > On 8/4/23 03:49, Jan Beulich wrote: >> On 03.08.2023 18:31, Daniel P. Smith wrote: >>> On 8/3/23 11:56, Jan Beulich wrote: >>>> On 03.08.2023 14:56, Daniel P. Smith wrote: >>>>> On 8/2/23 07:01, Jan Beulich wrote: >>>>>> On 01.08.2023 18:06, Daniel P. Smith wrote: >>>>>>> + { >>>>>>> + for_each_domain(next) >>>>>> >>>>>> What guarantees that the list won't change behind your back? You don't >>>>>> hold domlist_read_lock here afaict. It might be that you're safe because >>>>>> that lock is an RCU one and this function is only invoked at init time >>>>>> or from some form of interrupt handler. But that's far from obvious and >>>>>> will hence need both properly confirming and stating in a comment. (It >>>>>> is actually this concern, iirc, which so far had us avoid iterating the >>>>>> domain list here.) >>>>> >>>>> It is better to error on the side of caution instead of assuming this >>>>> will always be invoked in a safe manner. I will add a read lock for the >>>>> domain list. >>>> >>>> I'm not firm enough in RCU to be certain whether acquiring that lock is >>>> permissible here. >>> >>> Same and I took your statements to suggest that I should. >> >> Actually I wasn't paying close enough attention here: The code already >> uses rcu_lock_domain_by_id(), which acquires domlist_read_lock. >> > > Right, it grabs the lock while iterating through domain_hash[], I > thought your concern was with regard to the iterating with > for_each_domain and the embedded open coded version. Because of your > inquiry, I have been thinking about it and I should be grabbing the lock > as I iterate to be sure that I don't get deceived into believing the end > of list was hit because a domain was being removed as I walked the list. > And if it so happens that the context is always safe, then there should > be no contention on grabbing the lock. Do you disagree? Well, RCU locks aren't real locks, so there's no contention in the first place. As to the context being safe - I continue to be uncertain, but the pre-existing use of the lock means you adding the necessary locking to your code won't regress in that regard. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:42:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:42:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580696.909077 (Exim 4.92) (envelope-from ) id 1qTcu7-00072v-Qi; Wed, 09 Aug 2023 06:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580696.909077; Wed, 09 Aug 2023 06:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcu7-00072o-No; Wed, 09 Aug 2023 06:42:47 +0000 Received: by outflank-mailman (input) for mailman id 580696; Wed, 09 Aug 2023 06:42:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTcu6-00072g-Ah for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:42:46 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0609.outbound.protection.outlook.com [2a01:111:f400:fe0c::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f274eda9-367f-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:42:45 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9195.eurprd04.prod.outlook.com (2603:10a6:10:2fa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 06:42:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:42:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f274eda9-367f-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrZBk/vck8q8iXLXfSQP1WZ4CxT4GbKrap82cWGmskOb/yGfqau0uvjZoqio96wCc030Ax2icJ6MNV3eJQeEJV44fzmAPnwR7ygoh1LleqnFJDKem71YsqEOqL7V+is8DoObfPRAc1S1XBSXUUYcheX/KQik1yZMMIehwV/dypAFtA2EGD0/9VtQItKdXNqhPtknm7/Dqg6yy1pMH/viQjTNnsy0rm+dFTeFPY+GqnFel+EBdMei0bDsF0AevEhKck+3uHYj2+vMarVYy6pgH2k4iQgMhBklfVC1ji21dTLynI7GmvNTihquxxl7PctPZ2FvYayQp1mEYMmK0bJk8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/qv8RzdLGkHNogzIJrzcZKa6WYQvuP94xlgxFUFJqQ=; b=nG5b59+BDfokVxFwcodbAH6dNrj74IeSvILCktyTWTXw/X745X9QMjM/8ulEUXOf0XIrtiyf4zjVdxLpXQb0c6YqeyM9OzDL7D1yQ+uW+7ERdo1OoXIHDNpzG1fXZ0qEbWGw52fIjuJRAIPRgf38N0okw9vsrEbHmPxYVH54RKiLDpRGrhEv02X8ziwzfycHEcQRZhexjnSkdOoLZ+DQxsVW0f+GSTc/TlxImEmetfZeMWeNZUI6JgQOGGbvAmByBbK7O5Y1c0E2evz1hPW05i7TquuqMIHrhZFJZIUgskUE5gu9KLzbXc2TgLkuxX3z071aPbh7AVp4KjvqbLRktg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/qv8RzdLGkHNogzIJrzcZKa6WYQvuP94xlgxFUFJqQ=; b=HkBwV8pO26q/eKWt306YnHyFXliyFDoJf8vCeqGvo9OhKw5LFyEsGX99XhjgV+s8MEiynE2KCKyo8mgQ3yL9nQFyM2q+8/wgqZMckTC1i3udOdEU7cXib/YorX/2F4Ky0aUsItZXri5wyloqy6CPV0MlEOl+rwO0+PmxlsegYjoMeR7nEPbyPs1AdTHpiDcqiWYPaLnURN2w+k7gnPJOdyGfm5CmjreqX/mVNSSwI2deZUUeTqtP2QyOVGHBofGNnU4MSTMcQnPbdwatuk8as2DWytCwKzXxHOd5YbJenMPRTV5uK5JX8gSk/mvRCKyVxUehRU1z2CQNWl69+tSL8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 08:42:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/9] xen/common: Add missing #includes treewide Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <2c9eb4fc175a1bdd21293f2e2611d8e21991636d.1691016993.git.sanastasio@raptorengineering.com> <7e77b8ed-2c0e-b814-6ce2-c6b2cf47bec9@raptorengineering.com> From: Jan Beulich In-Reply-To: <7e77b8ed-2c0e-b814-6ce2-c6b2cf47bec9@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0216.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ac::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9195:EE_ X-MS-Office365-Filtering-Correlation-Id: f462b139-4708-4c39-96ed-08db98a3d5bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7nq8935HvKCxfyVcqYFuqNgraQp/ToTu2ZDzj9MaAnTl0BY/8vy4DropGES3eezgC4al4icLBmrLgWhkpobX4ghl5f5VL8vG/bLsaMgLcYy/4VsARAIjRQDrgNUOJfrvCGRoblVfD54WhQvGOlgnWkhq8ZMoapyvkPtl5nD0xzh4UpISMDxa10QZLLF9OMdOqCBnYQxBoIPlOPGtZWA9C7rjZB7SkyNg0x6bNULd4Y5+QRawbHo8WFr0w6k2bYTnP5Ya2kzrOixUehvhHN0nLErlBpknJzqjADvZSuGIAnpxB401s5s9BV2DypLAUVTb2eShnIf3y2Ex88fOmWzqPXE2VH1uc53s+dWCkGuQA+YAJXwzu2gsCA+bBoWeau4X/Hrh2jaJ0edYGajdmZXUsIfAOqFIApSnu7Va8RgtgDNifGCDlP4KwuL1JyfkFQqFoFRPNTCwK4j+7SuDW2jy9+gR1UHog4XieWfxZWR1t272XzZeOcCsSDIiPs3p6MCpVXWw2W63bKVUoobPZg6LGpcx7qgvPHo3+1opBpjNnK9q0tQoFE30Koaza2idIfCBGHSlpzCj5AHxv720ORu8jEnu4PNRLx0f5Qjs76/OPk9qQZ945rzoxzUqeA99Md8cH50wlZZukBtsgq302MimpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(39860400002)(136003)(346002)(366004)(186006)(451199021)(1800799006)(478600001)(31686004)(2616005)(83380400001)(6512007)(26005)(53546011)(6506007)(66946007)(8676002)(316002)(8936002)(31696002)(41300700001)(66556008)(2906002)(4326008)(6916009)(66476007)(6486002)(6666004)(36756003)(38100700002)(54906003)(86362001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjN6dVJrYnVCbUNXVUFUMnMvTXJLc1MxaFMyNkZSd3crdk9nVVdid1JYWGFB?= =?utf-8?B?N3hQbTBEb0xNM1kvL0FESkNnSCtCUkJhUmpybDhPM2g2ZUFGdVlNVTN0K3JU?= =?utf-8?B?YU02WEluZnlSSHI2RHArK2tIbGhEN1BFTWpFS2VuRkFxMGVtdlV2OTVWRUY0?= =?utf-8?B?WXJ0ZWdVMWp4TUlLdUQxKzAxZ0Jnbk15UTdpL21YYVFqQkxJUmR3S1dyTmNW?= =?utf-8?B?YWs4UEQvbU9FV01YVDZTZ3dnY2liSFlEcDhqQjdJelVwWU5XMU1HK2dPU0tL?= =?utf-8?B?bTBtOFMwVk5OcGJsUmRQUDMxM2UwNDdzS2NnYmF4bkxXNU9OZlE3dFFjUU95?= =?utf-8?B?bitYNGVydzlqRHVwdEFwZmZLMEVyVDIxME1QaC8xSDRzbE5WTDVWQ05vakNI?= =?utf-8?B?OHcyK0sxRFpSYXpsYi80SGtOcmVqRjFnUDJFdmJ3a1lsdnJRcytQZE81czZY?= =?utf-8?B?QVJZREdBL0E3WFd6VkhsU2M2L0VkYWRtbTJmSkNyL3JrTUk3QndqL2FmUlBI?= =?utf-8?B?cmlJWlZxdFpSVVNCOEhZV0ZZN0dBekxvUVVqTUNad2E5dncvbHUyY2dSTHBJ?= =?utf-8?B?ejhKOGpwVEU2dTBtOENxY3Noc0l5ZzlxOWJKVEd3RVJNK0Y0bjBZVm5LcnZG?= =?utf-8?B?TkpwNVVtb3k4cXNiVjlzaHUxREdqK1lWVW05aE1vd3dZUHd5L1JudndtTVFH?= =?utf-8?B?ZFBCanV0Z2FuTjdhdC9QQUsrUmtJZGdDN1kxR29rVThvZXlrNXV1RmFxbjV5?= =?utf-8?B?eFh5UVdseE9NTEMveENYQzRQeHV3Z0lwby82YWpCdDM3UkVrSENuY3pTSVpJ?= =?utf-8?B?M216NXFKLzgvbnlLdXNXSXRVT1p2elJQQmd2cGdkMzF2M0l3Q25Rc05TUVMr?= =?utf-8?B?R3puMXpTRGxCektUSGZ2OXA2c1hPSE5wRDl2aWFFN1M2V1VLWmRRZDVXNkpJ?= =?utf-8?B?T0d2dzFWc01IazVveXJUb1hHTWM0ZFFiczJFQ1VsNHRORkFhZlM5bzN2OFZl?= =?utf-8?B?Ui9wdThST1B0MG1CSnRNdkhBYnhjVTJNelJqM0lNQktFQmpxeTJMd1ZOVUpr?= =?utf-8?B?NmdaRzl6MFdtejE2K0VxdVlSc1cvcE1MWVg4WkpkUzdPbTh5RnM3RWo5K2Mw?= =?utf-8?B?VlIvMS82WDN6Y1I4NzQvTUZTdUs1U2dTbytwRUhwSnZFNitabC9wbHBxUXV5?= =?utf-8?B?S0ZXZnZOa21XMll5ZDVmQkdPYm5xYUo0aWc0ekRNUlRDL2dBSlBKT1NOcHdF?= =?utf-8?B?bVB4TzhBRG5LZTNTOHpSK2t6NEplb0h4SU9lYkJrWnl2dllhVEhLVnlvK3dH?= =?utf-8?B?dnRsempNT09KZEZubkhabjV2MWtiQXNDbkorR1lqa1c5UmtOZU9CYTFBMDQy?= =?utf-8?B?LzkwWWYvcnpJQTQwYU9LUnllZkxpaEthUDMyZVE1QTdma04yQzZsNGRmWlRS?= =?utf-8?B?bFZsRG11dGZxSzN0SHlvMWdKb3RMM3ZRUHpxWXhWS2ZoY3RGb0lCeXdBcWJT?= =?utf-8?B?VVdwVGd4UnRFZzhFdkhRZURINHlGeDdqcEduMUVIR2xQY2J3dXJ4cGZMdU1r?= =?utf-8?B?b01UZjRXUnN3a2xSTk5aRU1vaVVLaUtDN1FpMFFIbi9ESTlPU0I5OTR4VHZX?= =?utf-8?B?QkFaeVhsZ1RDVFhEd2p2Rm5kbDNwcEtTbnVkY1YzVm9KV1Y4TmRMT2ZzbVV5?= =?utf-8?B?SGp3VW03WnU5S2sybDF2Wm5XTFlvckdKVURDbmtOZi9XdU1IbE4vcUZsdjdM?= =?utf-8?B?RndyT0gxTERWZmVyOTNNbXJ5c0srTURqdFBZZjlCV3RYMzdEVTkxaExqYzZ3?= =?utf-8?B?d0o1cjRObXRDVlk1blpKRkgrenpEU1dsZ3lseEloblhFem41ckM3b0l2NDVZ?= =?utf-8?B?SzBNKzBqVmlnWFJHY2I1amVCNmhqVDFiMGhFaWRtZ2tNelRLZ1U4ZFZ4L2xZ?= =?utf-8?B?SUNJcW55eGo5bE9sNnEyVUxNRi93eVBiOHBWYjlIZkIrSEU3dElrK0VRZXl0?= =?utf-8?B?UE9WWnJkTWYxekFJckQyQ0MzTmpIVHBEWllPRjJ3THJZMFBBdm9XRjNXeTAy?= =?utf-8?B?QWhpc3hNRUtiSGhBMzZBMkgvZmhLKzBNWlBkVW5QbGIrbGh2WXU1YTFITFVh?= =?utf-8?Q?sU923wdNX3Do5A2MnCBTtwAHk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f462b139-4708-4c39-96ed-08db98a3d5bc X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:42:44.0449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PXBM/3/vpdsMJC5K6oO0M4WLteBQPQNS0/TF7F1JWFKjrDoSJRZRLkT0kA3KQrx74R6GJ/lDqNZjqZZsH6uFlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9195 On 08.08.2023 18:49, Shawn Anastasio wrote: > On 8/7/23 10:39 AM, Jan Beulich wrote: >> On 03.08.2023 01:02, Shawn Anastasio wrote: >>> --- a/xen/common/memory.c >>> +++ b/xen/common/memory.c >>> @@ -28,6 +28,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >> >> I realize there are several asm/*.h being included here already. Yet >> generally I think common .c files would better not include any of >> them directly; only xen/*.h ones should (and even there one might see >> possible restrictions on what's "legitimate"). Do you recall what it >> was that's needed from asm/page.h here ... > > The references to invalidate_icache (memory.c:310), clear_page > (memory.c:1867), and copy_page (memory.c:1876) all need asm/page.h to be > included somehow. I'm not sure which file ends up including asm/page.h > for build to work on x86/arm, but with my minimal PPC headers it wasn't > getting incidentally included and build was failing. Okay, that's unavoidable then. >>> --- a/xen/common/xmalloc_tlsf.c >>> +++ b/xen/common/xmalloc_tlsf.c >>> @@ -27,6 +27,7 @@ >>> #include >>> #include >>> #include >>> +#include >> >> ... and here? > > Here it's the PAGE_ALIGN used at xmalloc_tlsf.c:549 Hmm, PAGE_ALIGN() really shouldn't be a per-arch #define. >>> --- a/xen/include/xen/domain.h >>> +++ b/xen/include/xen/domain.h >>> @@ -4,6 +4,7 @@ >>> >>> #include >>> >>> +#include >>> #include >> >> While following our sorting guidelines, this still looks a little odd. >> We typically would include public/xen.h first, but then almost all other >> public headers include it anyway. So I'm inclined to suggest to replace >> (rather than amend) the existing #include here. > > To be clear, you're suggesting replacing the include of > to ? Yes (but see below). > I've tested this and it works fine, as expected. Good. >> Then again I wonder why this include is needed. xen/domain.h is >> effectively included everywhere, yet I would have hoped public/domctl.h >> isn't. > > domctl.h is required because of the reference to `struct > xen_domctl_createdomain` on domain.h:84. Alternatively, we could get > away with a forward declaration of the struct. This is always the preferred solution, when available. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:49:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:49:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580704.909088 (Exim 4.92) (envelope-from ) id 1qTd0A-0007gd-GQ; Wed, 09 Aug 2023 06:49:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580704.909088; Wed, 09 Aug 2023 06:49:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTd0A-0007gW-DN; Wed, 09 Aug 2023 06:49:02 +0000 Received: by outflank-mailman (input) for mailman id 580704; Wed, 09 Aug 2023 06:49:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTd08-0007gQ-VR for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:49:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20614.outbound.protection.outlook.com [2a01:111:f400:7e1b::614]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1c75afd-3680-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:49:00 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8890.eurprd04.prod.outlook.com (2603:10a6:20b:409::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 06:48:58 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:48:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1c75afd-3680-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S5f47C9Khtn+y3rDsY4uaiA9W6bnqaM67FLsLYuvTb4L24xYjWJiOYNiMSvDbHps9uCdEsJskUZnhuVa2O/vu2gvVFhPZ2CKEfX+5gWEDNiCkRMGEckOz/wW+ikqR0AiCkvSQawaV/bALmpRS2hE4r6NwWbPOkttsX+wlGfaKhF7qE/Bw3hQ3jQmn4YgsEhIuQW3o+1bjjPiMoETL75OXaenIwD/o+W+VGxWHefwwKwnUa6qIqH/bIMZ+5makNrmbxfgK9O5n/V2lpfZpB01Trv9aN8XwD8wMAxwel4dLLZSGMrxwn+g/rqzXRa1pvEzyRkxGCPcOJPPNDuEHX9itA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bf48YHefA6bFkSCH3odqD4dx8zvG/JfvGMJBg1ei1Bc=; b=NFnh4pIWoWBm7r/tvtDoxTs7oacird47wQh0HvY2+s5+00T/EjGjnxFGFlfnXShXkXNObkDYej4oBaJakK4zSrpAAbv6tldJvqpaKkrV1jtjmd+uQnEfabwpXVO9IHO1lg+Zr6GlhDwxhw7+BAZq/eS6SflCFSCdAhvOViu8kIxpJjbh1KOkU/fGyhhCMxT0T54A7yolWkiS7FgpiVwTkn7iRb1gLJv/V8/210dLgrkt3J0FIZmGSd0zG4ALvmbQ53fo8dkyIP3j/z9m/l8U7W9TkEcZXvyTzK/d8cEMTKR6eDHYV92Xr7pl97vj3ZUY93AvSGDEieK2xS+ybGw0jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bf48YHefA6bFkSCH3odqD4dx8zvG/JfvGMJBg1ei1Bc=; b=azEOsYDY/u01QBRO2WiTP0abtk4Bg/dEoBJ9EuLx9bDCVpVzeKc28MU4wfu622zJdlCeEfRGz2GNcBobU9e47NU/x4/03x7qfZGfUyH36V8ryzHO2u81127bwUZlnMKFKX+pI0XMhGDIDGqFiAw4OllX2jZ49ED6cGEiAv5qHjkKLuW7VLHd4Ike24DXWzTy9/njEDV2E8kYSCWnP7JJJh7zeZJBwlw4W/umc1II5ToZZpfByOB5rrT9qAkM8vnm0AzXuRnwlgTPaQmL3uGuEdxONRZmgLN7xJVS4fJEmxGLNcp+18gbZc6UCu0PTDYMW1br08jyqO9VC8yZP4f3sQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2307c6c6-1794-30e2-a6ba-f40fda313738@suse.com> Date: Wed, 9 Aug 2023 08:48:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/9] xen/ppc: Implement atomic.h Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <8035b9659a5930c00802dd36ab52574695d6b419.1691016993.git.sanastasio@raptorengineering.com> <5e9380a5-7e33-ea70-6aa5-3ce1906a159c@suse.com> <080f37f4-2b2a-c057-568d-6e4974eb2f8c@raptorengineering.com> From: Jan Beulich In-Reply-To: <080f37f4-2b2a-c057-568d-6e4974eb2f8c@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0171.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8890:EE_ X-MS-Office365-Filtering-Correlation-Id: b4ccacc9-29d3-4345-b030-08db98a4b4f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lAhH19H7EqUYynIpuc7KPTqQTk5j+4x1hYqqOh+Kj4SO0as2avbDM4YhJr6jFdD+GBCpF4TYM8EIzrDd/G2Uy/9DEqzsbFLTxPKwSjTRH0yIveS6EhpmzkSX3gvATJomO+ivUv9g1JS2Dnd607LAet4/ddAgMzrezash/qvPAI21t5a2IE3zXHDQRTcrIPXBt+dlcETY9TH7tBuZXQBlVzsYu1LCYsu7Pmm5N0Qp4Gz/tJ20Z80cukPyXlGgNhvmwRM9Ws/81e4A8ltBHoa8OkKAO8dhKdFB4Vbemrc9D8OBLOmbQI8PSxd20NA0dhZSslJme0MInN6Hif0HPLBqpHDVoa5pJJsZBU5gcsJKYsl3GMH7OvQFmLSoG7XPdhNAkUtY1FCPCejvxUKIY2MUXNtHSTpVAS+1QWNfVAFL2m9nFL0ys3lnl9VxMs9DuDQz9pSTYL69XiK89DXDL05M12Cyvrkj9XNeZJWZGoozkvuaNq3vw9XV14/ytI3sfrhIW+Rts3Ke/AcF1teyLiuCHbSJDstW2MeEa8cmJL/YhH0tFkBMtvvxAmRHUeTzPpldW3Mdmkdty9Vp76ak5hIDInZlmgxwdmYHXc1CmuiPGlCArrJARkdCx9UuezGNOfzFdKAWzyDC5FGgVMSiDhgWJMUBDruPxbYD3Wqx6AL1spo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(39860400002)(376002)(136003)(1800799006)(186006)(451199021)(2616005)(6486002)(478600001)(31686004)(83380400001)(66556008)(966005)(6512007)(53546011)(26005)(6506007)(8676002)(316002)(66946007)(8936002)(4326008)(31696002)(2906002)(6916009)(54906003)(66476007)(38100700002)(86362001)(41300700001)(5660300002)(36756003)(57644004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z2JUZU1naldxZFZ0QktQcmhGUm9nWDVwS1JBa002Wjd2RlR2TmRwMmVIMkdG?= =?utf-8?B?ekNSdWtSck54aXZWYUYzc2hhdktJMXhrcTRROEZ2cHdjTFZmcGI1Q2w5UllZ?= =?utf-8?B?d0NSV1JlbzVROXlQVU9OcUowMittZU1xNjRFVWRUUGx2dGdlWmxuNEpyamxw?= =?utf-8?B?SDdacmphbTg1UlVPM056dk4vcEpkWXdrZUt3RjNqb2VxOVBKNVFsZU05cHo4?= =?utf-8?B?UFhIVjBSTlcyNVRPNk9BNDlGRlgxQUEvZjFYKzBhVEpmOEVsQ1c1US9YbXRR?= =?utf-8?B?bHc2RmdYRFlxeEdzZ3M0RVh4M2RwQnU0QUFkaHF1S0ptZGE4TjdlTEpiKzJs?= =?utf-8?B?UFBQajFtUGlTaVRORHZCT1NkUE9yVXhlRzJ4eVVxOTZVQm1PZFRLNWdBUlpV?= =?utf-8?B?MFBpWjc4TDRIbmQ5bHUrenFNVnozc1Y0ZVphT1c2dC8ycG9tZVZrR2xLL2ZN?= =?utf-8?B?Z1BLQXQwaHZ1Z0hqNHQwNjdHWDlxR0d4cjFXQjhoZGxoMWkyNVBwa0o0Y0NG?= =?utf-8?B?dVU5TzhRNDBEMmRhSFZydWZNQmZlV2hzUUZ0aGpUTFpjMUJvS2E2OG1vVklU?= =?utf-8?B?THBpQjdycDZKMHI0NlhpbkY2U1hxek5vdzZYVy9hT0xtUWFpNzEvVTVMSGow?= =?utf-8?B?RmlQL2pxT3pHcVZiYW5GWStXL3R0a3Z6bFI4M3VOQ1h0blNxWVlxYlV3SWgx?= =?utf-8?B?WExTZVpSMnZVenJTS3BiT0tQcGxQRUp0SnpTOWEzWkEraDNvQUNlaTZCY21o?= =?utf-8?B?RFBvc25FbjVoNURDNTV2blB0MWlMaysvRjFyR2MvZ3Jnd1hGdllKcFdpajFD?= =?utf-8?B?ZXpveUpKUXFrRHZrTVJydUpyU3RLL2hGTk1OcGFzMDgveldLbEQxSllYZ0k1?= =?utf-8?B?NXF6azZlbmgvcGw1WjBGRHBVc1JjMk5TcHZudEgreVc2QkJOWlViS3E0RjVV?= =?utf-8?B?ME1KdUJkWWRUNzYxdkgyRlJ2MFMzRms4M09SUWo1ajB3UU5oSTNqSTNSVUUx?= =?utf-8?B?VHZvZFVGc0lFamZrZEgwMCsxQzJsdzg1QmFHV09yNXNlbFJFd0xFU29PajZI?= =?utf-8?B?ZnlnM2FKbndhaXZQbjRjYlpEemhhZ3owd21NV0xTWG9UNW5FWmtGbkJOUmRF?= =?utf-8?B?ZUpzWnZlTHhnejBJOGIvdXJpOUMwWGpEN3hpbEVQblZmN21tbThhaWtRMGZW?= =?utf-8?B?RzRzTkRkR01KOWRGaGxwWXNFWEVsTEFsQlhFWTRZdTNmdkI0QnJ1R3d1bjNz?= =?utf-8?B?Vmo4OStUaUJBYTdvYTY3U00xT0F5bjNZaWJ2R1QwbTBxZm02azlUdDVZR0JN?= =?utf-8?B?MTExR3J3NmNBMjBuZ00vOC96bjRrQTdBTEFBbmY0emdXTVRVOEsreitpbUU1?= =?utf-8?B?UXQwL1FHa0lqZWRCMnJUUHI5YkFlekpnbUdPcXBlalgxZkpFV1ovNm5YczRQ?= =?utf-8?B?blB5d2xsUGRyc2RDckNNOWg4VjNlWE5temdCVkhwSjRsbnp1cXBDdlBUYTls?= =?utf-8?B?NEQ5ZWliL0JTVTl2aWs2dWkxeCtDbStqd0Y3M2hML0trZFU2djBrb0tsL1ZD?= =?utf-8?B?RmxjVFcyMHMweWJaNjVJODlYNnB5N2ZKMWdsdHFjQ0F1bDlyL0JubmtkWXpi?= =?utf-8?B?MzRZcTcrcHZ2K3ltdFoybHBta3liMkRmSTdDK2FMcEpYMnRrdmorbU96QnVt?= =?utf-8?B?TkUxK0ZwRW1TREdBMGJwN0d4YWNSc0tUS1FZM1JuUWpJT2JSYUw5V1BIcVVU?= =?utf-8?B?U1F2SHRHQ3VWMlFDT2tRQjc2YTVjZzVWcXpEMlhqU1FEQWp1aHB0R3BucWtN?= =?utf-8?B?QnJhem9ra25kVFBHV0VMMSs0TmY3ZUYxY1RXbXlvUzdpRzMzTVJtVDZSczZl?= =?utf-8?B?R2N2b3V0eW1xWmhRZ1gySDUwU3M2eDJCSGMvWlM2T2l1Tkd1b1NXRmtuVTVl?= =?utf-8?B?U09hWEZvdCtaMWZJK21pZ2hRTTVpeWV1dUJQYjFQazQ3M0dBcE51MENMRERj?= =?utf-8?B?Q3Z4U1JMU2E1NVBXWnVjWnhKR2wrK21yMjg1MEVIbFJzNVlMSHo3aHZHZjVF?= =?utf-8?B?VHRPSkV6Tm9RSkMrKzVQVStXWmdQL2x4RG9iYkVVSUZuZTNyR0lNNGFodGpp?= =?utf-8?Q?QOqL3L3jP/Psycy1Xfxu0dtp3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4ccacc9-29d3-4345-b030-08db98a4b4f8 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:48:58.2666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yQSztZbnx7O9ANibI07uPdhxUzzHc4l2fPuFkKqWvaEOHRs0PFGDq2AW6FleQLpmcj+2iw+RVw/KF6QaVjredA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8890 On 08.08.2023 21:19, Shawn Anastasio wrote: > On 8/7/23 11:13 AM, Jan Beulich wrote: >> On 03.08.2023 01:02, Shawn Anastasio wrote: >>> Implement atomic.h for PPC, based off of the original Xen 3.2 >>> implementation. >> >> Since likely that originally came from Linux, did you cross check that >> Linux hasn't gained any bug fixes in the meantime? > > I did -- the atomic barrier instructions used by linux have changed > since this code was originally written, so I've updated them to be > inline with modern linux. Please mention this in the description then. >>> +#include >>> + >>> +#include >>> +#include >>> + >>> +static inline int atomic_read(const atomic_t *v) >>> +{ >>> + return *(volatile int *)&v->counter; >>> +} >>> + >>> +static inline int _atomic_read(atomic_t v) >>> +{ >>> + return v.counter; >>> +} >>> + >>> +static inline void atomic_set(atomic_t *v, int i) >>> +{ >>> + v->counter = i; >>> +} >>> + >>> +static inline void _atomic_set(atomic_t *v, int i) >>> +{ >>> + v->counter = i; >>> +} >>> + >>> +void __bad_atomic_read(const volatile void *p, void *res); >>> +void __bad_atomic_size(void); >>> + >>> +#define build_atomic_read(name, insn, type) \ >>> + static inline type name(const volatile type *addr) \ >>> + { \ >>> + type ret; \ >>> + asm volatile ( insn "%U1%X1 %0,%1" : "=r"(ret) : "m<>"(*addr) ); \ >> >> As I think I had mentioned before, asm() contraints want a blank between >> closing quote and opend paren. I.e. like this >> >> asm volatile ( insn "%U1%X1 %0,%1" : "=r" (ret) : "m<>" (*addr) ); >> > > My mistake, I went through and hand-formatted all of this code to try to > be inline with Xen's style but forgot about the constraints. > > As an aside, I don't suppose there is an automatic formatter somewhere > that I've missed? I found an old clang-format fork that claims to add > support for Xen's formatting[1] but it seems to only handle a subset of > Xen's rules so I haven't found it very useful. > > [1] https://github.com/NastyaVicodin/llvm-project/commits/main Work there was recently revived, but we're not quite there yet, sorry. >>> +#define read_atomic(p) \ >>> + ({ \ >>> + union { \ >>> + typeof(*(p)) val; \ >>> + char c[0]; \ >>> + } x_; \ >>> + read_atomic_size(p, x_.c, sizeof(*(p))); \ >>> + x_.val; \ >>> + }) >>> + >>> +#define write_atomic(p, x) \ >>> + do \ >>> + { \ >>> + typeof(*(p)) x_ = (x); \ >>> + write_atomic_size(p, &x_, sizeof(*(p))); \ >>> + } while ( 0 ) >> >> Up to here you use underscore-suffixed locals, but then ... >> >>> +#define add_sized(p, x) \ >>> + ({ \ >>> + typeof(*(p)) __x = (x); \ >> >> ... you have even two prefixing underscores here. >> > > The definitions of these macros were directly copied from elsewhere in > Xen (x86 and arm). I can change them all to use underscore-suffixed > local naming here, though. We're still far away from eliminating all pre-existing issues. So copying existing code is always at risk of then getting such comments. Again - sorry for that, but otherwise we'll grow the number of issues. >>> + switch ( sizeof(*(p)) ) \ >>> + { \ >>> + case 1: \ >>> + add_u8_sized((uint8_t *) (p), __x); \ >>> + break; \ >>> + case 2: \ >>> + add_u16_sized((uint16_t *) (p), __x); \ >>> + break; \ >>> + case 4: \ >>> + add_u32_sized((uint32_t *) (p), __x); \ >>> + break; \ >>> + default: \ >>> + __bad_atomic_size(); \ >>> + break; \ >>> + } \ >>> + }) >>> + >>> +static inline void atomic_add(int a, atomic_t *v) >>> +{ >>> + int t; >>> + >>> + asm volatile ( "1: lwarx %0,0,%3\n" >>> + "add %0,%2,%0\n" >>> + "stwcx. %0,0,%3\n" >>> + "bne- 1b" >>> + : "=&r"(t), "=m"(v->counter) >>> + : "r"(a), "r"(&v->counter), "m"(v->counter) : "cc" ); >> >> "+m" and then drop the last input? >> > > Yes, that makes sense. Not sure why it was originally written that way > but I'll change it. I think this was attributed to not sufficiently well written documentation for older gcc. >>> +static inline int __atomic_add_unless(atomic_t *v, int a, int u) >>> +{ >>> + int c, old; >>> + >>> + c = atomic_read(v); >>> + while (c != u && (old = atomic_cmpxchg((v), c, c + a)) != c) >> >> Btw, no real need to parenthesize v in cases like this one. Otoh a needs >> parenthesizing. > > FWIW this was copied directly from arm64/atomic.h, but seeing as its a > normal function and not a macro I'm not sure I see why `a` would need > parenthesis. Oh, right you are. The parenthesized v misled me. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 06:54:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 06:54:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580712.909098 (Exim 4.92) (envelope-from ) id 1qTd4z-0000kj-7G; Wed, 09 Aug 2023 06:54:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580712.909098; Wed, 09 Aug 2023 06:54:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTd4z-0000kc-4a; Wed, 09 Aug 2023 06:54:01 +0000 Received: by outflank-mailman (input) for mailman id 580712; Wed, 09 Aug 2023 06:53:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTd4x-0000kW-85 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 06:53:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20609.outbound.protection.outlook.com [2a01:111:f400:7e1b::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 839877b8-3681-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 08:53:58 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8890.eurprd04.prod.outlook.com (2603:10a6:20b:409::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 06:53:57 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 06:53:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839877b8-3681-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAjVfmc2NPp8OhBdXYg+YrtvZVXDXUpiNqQU7jNZ0VTUt0O6bmOWWs2qMA/FOI57yUCHy6difOPeqIuPyXtdMWSk5bNTwajLCKL68t9ZAHUK35Mj4zr9ihPRKkmOAlOE0QDsrXtB3k3Epo25Vjy5rlTluhEnl56M6KRS+9jnNb2CqBFfb2ImU+S+vFb5kcdlEKfuPZ5lL/7UGwYglE0ddB1IggMrBl7svrZJizByD25eYuY8TcDkNJBat5EJysy9k+KSjdMTtak76hGMyzpsP8GJKZRd1bTLS5ixE5sorcemd65NYz9WwxqzuzbYTUFgYtZ9nu/cpEiW9RB6GFcnng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p1cFDW0cxg+T7WdovLB28zEgLcbGf1NgCosVjYcqQDk=; b=KsVAcxBSiLqmIPJuxxsjnKVqCKbAGT7nUc5RShFYYkDNUWva6H17IptvBErgoTM9kyZ3Od/4qn4nlQuRruNgE9IMvw0FUNGIy2wZpttXs7DM3BlXY5Bp9DuYiIsSQmYVxqGDKIAkBJm52yagbP6NhK692FzNd3KGej0G722UaXYgvocvbvxhHVThcYfj/dOGjOBo4X4FvSlVv50vAmYMExKrfnYsj5ObDCXtV13iOcrfjGbPXhps/qQFdLQtXtP3otaxXygWDIE6mLdF6a3vttpr3j+AQo6aeAXNzZuhqDAb6GQuwTFmBKv2XmGKvgK95Te/zBHvmW1yokjySSxPKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p1cFDW0cxg+T7WdovLB28zEgLcbGf1NgCosVjYcqQDk=; b=29AHdEEq+LcPoE9n5bsnd2Z2qR6tCqOHQtYqVyffgY97Kj66hz9dJt2ci+dje9LiBnjalwGRUL1TCgHHoxXBk6W+q4fgyQvjLErpRq+6NnlbupAf4wsiIeCb86RWwxTylIp8qIFK61YUyuY+okd6Q+/b7x5ygANap+xEfzVOf8NvJ0WYvCCLwCp2JM9BsvmR6jXjVP2OPq7iWeSBG9pTgZ6b0YdecGhthfXKQQ+Ad4rU+dgFwAi1aOIi8AKgVWW7Jrpu9bJ7QV7Ys9pakbpE/tvl90ICcOwgeYpnfZ9HFzI4Ek8cHBa4vUSevvO5IrTgCne9SSORaslwunDT0cqreQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 08:53:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC 5/6] capabilities: add dom0 cpu faulting disable Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-6-dpsmith@apertussolutions.com> <93750d64-07b3-2a92-4851-bcd5bda9a0a5@suse.com> <331ee5de-3c90-2e3f-ef1c-914a2cbf14cf@apertussolutions.com> From: Jan Beulich In-Reply-To: <331ee5de-3c90-2e3f-ef1c-914a2cbf14cf@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0091.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::11) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8890:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ceee960-efdd-4e70-94f7-08db98a56749 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BXg+yH/9oqhiLcxs9iVN2YpC+hvIgD6Z+3ycQ3WID3wLC0U0TtAf9dxUPZ2CpDIV6j3jp2I11/FJhPYrP5F2JIjDnGXuI3Ar6a9fSjbac+wtBC1jmOkwMB0JQfYFEvg0vLY/3icJLNT8vKRwoXXE4wCPzw9J+RDBeZQrgbBCPZQZk+dQSYkGoaJwN+iwTXNdvndDuA/cIg67+Ih2T+041nw2gCFJcRPFWUiqQoe4ZTwgvoPQPIT1ZZL/8QKZJhbm6ocMr6HhUATc4SgOLVvUQ9oGr40wk7OvEZHZrvNmidyKv/TyKaH7fLFPtFPtmzxpGWylyDmLGWPWd5PI5q9hDEYmani2LGTVciyDifoX1jXpGSVrfnFZNWGeoVsqaABn4HPN+cZHAJdyecnsQIauiUPkorqPTCWNfRp6msJmc4meP5Y4leUEEJT5IN9+WicaEaj8tB3efBCcEHuFRUwewuBl9E7KjaX1L2GD+6eyHfe85TyNteyZKnYraOpULegokBa/L7o8OePs2qtNp3fUSwjVsmGA+b4L69poUa4yY09v/ii8ismd+0rERkGkTiVCGNQnA68sVa1knDsoC9CL5/V59Tft8mHw1ZzRI2dTB2VThTfRNffwspzX5WfEmcXQYNWZEAGB3it1imLCskFugw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(39860400002)(376002)(136003)(1800799006)(186006)(451199021)(2616005)(6486002)(478600001)(31686004)(83380400001)(66556008)(6512007)(53546011)(26005)(6506007)(8676002)(316002)(66946007)(8936002)(4326008)(31696002)(2906002)(6916009)(54906003)(66476007)(38100700002)(86362001)(41300700001)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWlpMVJGNEZmKzZYcHNjTThGdm42bFJCZ3lnTzFVbDBlYVhGdHJpMTBYd0FD?= =?utf-8?B?enF1MFFRcW1OTGJlTElzc2prOUpOY3pMa1lrQWQzSDZpUE5nS0tkdmp0ci9n?= =?utf-8?B?aEFqSkIrVE9ZdEJreDlEQXNpL1dmc05XeEVOdC9KV3hpeXpUTHk5L3JpdDFV?= =?utf-8?B?L0x2c0xsOWZhRFVOS3JSQWJ0bjAxdkNIYW5YRmRCN3pPOXBTYkNHSDAvVitG?= =?utf-8?B?N3ZvRWc5NW5IVXJyV21ib3U1MXFOOWJnUUlJa2Q3dk5sRmdUbTJCRk9rSXhZ?= =?utf-8?B?NkxLWnBxa0FQWlM0OU5LK3VZWmliSU9NZk0zOTdTaSt1aXJEK2JFR25ROVp6?= =?utf-8?B?dkgvVzlPNTZBUmNTd0V5cTRwdUxBSFBRdnlkMFRaNCsweXJNU2Y5ZnpXZmg4?= =?utf-8?B?Z2N5b1NGYloyckF1NUREMU9tODk5V3AwbU0xQlpmazE2R2J5bGx2SGkrQmtx?= =?utf-8?B?RGdrTkQ1MmF3VHBveVl5OG41ZG94dWNXdHVXR3d1RVJzOWh2ZnNOQWlrNHBD?= =?utf-8?B?aW8xZWZIYUU3WFRvdFN6QlNKRytYdkRlMmdMUkJuTVJYTWZqdUtTUTQ3aXg3?= =?utf-8?B?eUhKMlBiSm1OditvK1pKWDlkcktBNUJ0QVlZcmF1MXdCQkh2WE8vSVRWYm5h?= =?utf-8?B?SUlMMWRpYUp2cVhSNExnNnUwMENUeXJ1NnY4YWdPYjI3cmtHOVYxY0VoZFdU?= =?utf-8?B?VUJGQ0g0blFmcEY0OG0vbjVwaitkQ1FhKzc4Tk5YcWM2d3U1QlVSMGVFajVM?= =?utf-8?B?MGxNRzU0L3I3RTJJNkRXU0VyMHN3QUE0bEJKSm5vZGViNHVPc2hBRnVNSVR3?= =?utf-8?B?SVNMc3RvclV3WmNpdjZFNDRqeDU2OGlkZG5SS3dkRFpSSGhEZm9MRFJ2QTg5?= =?utf-8?B?ak53ZFVGWlMrb3ZHZm1mTzZ5eE44ckc4c0ZmQ3k0T0c1ZTRiYnNKVkhyY0po?= =?utf-8?B?RTFRc1R5T0R2YmhIa2FFZVZNYnZqSjNnemxuT25STG1BeUtHdVk5U2ZqY3VV?= =?utf-8?B?RUVVdE1wU3dKRk55bDFobG0rYmhBN2VZZTU2eHdmbitVMzBFN1VUWFZwbXZx?= =?utf-8?B?VUIxenRUTWp3d29jTGhXMnMrVXdNY2pyQUIvdDNvQ2U4cHFrWm5uNmhES2No?= =?utf-8?B?aEFnb3c0SlNENk1TcXk4dlo5YVhVdVIyNkZOYVliRzZnYmMvbEcySUJIS2NV?= =?utf-8?B?c09qbk80ckRSdzY3NGdYaHRwcE1JSEJub2ZrQVlEazBqR29xdkF2RzEyZ0Jw?= =?utf-8?B?RSsrOVNrSHFlZXFEYWpZZTdNK08zbmorMzJBWjBqQUhNWEU2cTFpbzJFRWF2?= =?utf-8?B?a0ZzVGxnazJXT0Vqa0hmb2V3NzBMb1lNcFozUEZIRW10V2hyL2FNKy8yTUZl?= =?utf-8?B?RFpsdjFENGVYZWNCUWd1dVhYY3d1b3hHV09FaHR2aGt0UG5xd21sR21Rdm1T?= =?utf-8?B?TlFCT1BOcnAxa1Vac2o1Ny9kZHdzUVpEZ1RDaXhxRVVKUU5ZQ29wMjM1Mzgx?= =?utf-8?B?dXd2NVBWbEdxVmZUMjZpbTFTSGxzZW12Zmg4d2tBZW1LL2JoNkVrWmZPamxk?= =?utf-8?B?RXRmVjJpMWJneWNFd0I4VXBCY3U5ZEp6RmhKWWxyUitLSGpMMXIyaG4wUytI?= =?utf-8?B?d1FVd09EdHZEYWtVWUJHcXR6aFIya1RUSWVrKzd2Q3gxc0xMU3ZxUGt0V0Fs?= =?utf-8?B?eSt4L0w5dzNUNTk2c2h2NEU3aWpadVlGVmhMZGVTK0lNQzg2a2pheTFHUk9l?= =?utf-8?B?K043SjM1Y2RTMHBLYXV4Tm5Sa1JVNWhQdXpTMzRTbGhwUEcvQlVxQ2VjMFRm?= =?utf-8?B?bEo0bTc5OG9UemVsbFVaRGUrOG5HcVZWWk9SWUsrYVFaVVdQdytnYlVjakFO?= =?utf-8?B?KzNDM3dpaFNKcURRQnlrWEdnOU5NY0hDSGRwWnVyUEl4Q1ZiWUJzYVJOdVFy?= =?utf-8?B?NkxSWTI4WW4va2dQSk9vdUkvVHY1L2U0d3QrMXhyWjVSc2NuR2hXZTNtK1pK?= =?utf-8?B?a2dtM1ZSUndzRTlHSXFnejdFdXVxbXpYdCtSR2p6TVNab29CdXJ5QVZXck4z?= =?utf-8?B?RDhWVnQzZ0dabnZSWHJuRUFKbUJkV0JTRG1FSDRlWXJnT0lrZ2toUndPaGRL?= =?utf-8?Q?f9RjfzowxgdS2SUTyHqaWQP2d?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ceee960-efdd-4e70-94f7-08db98a56749 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 06:53:57.4268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JovA9z3cAvJqqKhMFkhoetVgowyUzQ6kyCgGkXlOqE6fkEJ0zyZqGN5wpWkLbW/n3xGrTs4E/EjFYqBG6kMoDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8890 On 09.08.2023 01:59, Daniel P. Smith wrote: > On 8/8/23 11:30, Jan Beulich wrote: >> On 01.08.2023 22:20, Daniel P. Smith wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -907,6 +907,10 @@ static struct domain *__init create_dom0(const module_t *image, >>> >>> d->role |= ROLE_UNBOUNDED_DOMAIN; >>> >>> + if ( !opt_dom0_cpuid_faulting && >>> + !domain_set_cap(d, CAP_DISABLE_CPU_FAULT) ) >>> + printk(XENLOG_WARNING "failed to set CPU faulting on Dom %pd\n", d); >> >> No "Dom" please when you use %pd. Also I don't think you mean "set". Plus >> we commonly use "%pd: xyz failed\n". > > Ack on the "Dom" removal and "%pd:". > > As for set, it failed to set the capability on the domain. You could say > enable but that is nothing more than synonyms, not changing the meaning > of the statement. But you don't say "capability" in the message. That's what is being set. But what you do instead is disable CPUID faulting. In fact I wonder whether expressing that as a capability actually makes sense. To me a capability is something a domain may make use of, but doesn't have to. That's not the case here: CPUID faulting is either active for a domain, or it is not. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 07:33:09 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 07:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580718.909108 (Exim 4.92) (envelope-from ) id 1qTdgb-0005Du-6A; Wed, 09 Aug 2023 07:32:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580718.909108; Wed, 09 Aug 2023 07:32:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTdgb-0005Dn-1w; Wed, 09 Aug 2023 07:32:53 +0000 Received: by outflank-mailman (input) for mailman id 580718; Wed, 09 Aug 2023 07:32:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTdgZ-0005Dh-Sa for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 07:32:51 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f00a463d-3686-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 09:32:48 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 438D44EE073F; Wed, 9 Aug 2023 09:32:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f00a463d-3686-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Wed, 09 Aug 2023 09:32:47 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH v2 1/5] x86: address MISRA C:2012 Rule 5.3 In-Reply-To: References: <3a9db416c6f8b2d5a549d49ff02238eb408cc905.1691492441.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <1e0912a2bae65db5c85b18bf1208bf37@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 08/08/2023 15:46, Jan Beulich wrote: > On 08.08.2023 13:08, Nicola Vetrini wrote: >> --- a/xen/arch/x86/e820.c >> +++ b/xen/arch/x86/e820.c >> @@ -543,27 +543,27 @@ static void __init >> machine_specific_memory_setup(struct e820map *raw) >> clip_to_limit(top_of_ram, "MTRRs do not cover all of >> memory."); >> } >> >> -/* This function relies on the passed in e820->map[] being sorted. */ >> -int __init e820_add_range( >> - struct e820map *e820, uint64_t s, uint64_t e, uint32_t type) >> +/* This function relies on the global e820->map[] being sorted. */ >> +int __init e820_add_range(uint64_t s, uint64_t e, uint32_t type) >> { >> unsigned int i; >> + struct e820entry *ei = e820.map; >> >> - for ( i = 0; i < e820->nr_map; ++i ) >> + for ( i = 0; i < e820.nr_map; ++i ) >> { >> - uint64_t rs = e820->map[i].addr; >> - uint64_t re = rs + e820->map[i].size; >> + uint64_t rs = ei[i].addr; >> + uint64_t re = rs + ei[i].size; >> >> - if ( rs == e && e820->map[i].type == type ) >> + if ( rs == e && ei[i].type == type ) >> { >> - e820->map[i].addr = s; >> + ei[i].addr = s; >> return 1; >> } >> >> - if ( re == s && e820->map[i].type == type && >> - (i + 1 == e820->nr_map || e820->map[i + 1].addr >= e) ) >> + if ( re == s && ei[i].type == type && >> + (i + 1 == e820.nr_map || ei[i + 1].addr >= e) ) >> { >> - e820->map[i].size += e - s; >> + ei[i].size += e - s; >> return 1; >> } >> >> @@ -574,20 +574,20 @@ int __init e820_add_range( >> return 0; >> } >> >> - if ( e820->nr_map >= ARRAY_SIZE(e820->map) ) >> + if ( e820.nr_map >= ARRAY_SIZE(e820.map) ) >> { >> printk(XENLOG_WARNING "E820: overflow while adding region" >> " %"PRIx64"-%"PRIx64"\n", s, e); >> return 0; >> } >> >> - memmove(e820->map + i + 1, e820->map + i, >> - (e820->nr_map - i) * sizeof(*e820->map)); >> + memmove(ei + i + 1, ei + i, >> + (e820.nr_map - i) * sizeof(*e820.map)); >> >> - e820->nr_map++; >> - e820->map[i].addr = s; >> - e820->map[i].size = e - s; >> - e820->map[i].type = type; >> + e820.nr_map++; >> + ei[i].addr = s; >> + ei[i].size = e - s; >> + ei[i].type = type; >> >> return 1; >> } > > To be honest this isn't quite what I was hoping for; the many ei[i]. > are > (imo) quite a bit harder to read than ei-> would have been (hence my > earlier suggestion to also update that pointer in the for() loop > header). > Then again I see there is one use of ei[i + 1], which would likely look > less neat as ei[1].addr when everywhere else we have ei->. So I guess > up > to you whether you adjust further; I'll ack either form. > I'll leave it as is. >> --- a/xen/arch/x86/guest/hypervisor.c >> +++ b/xen/arch/x86/guest/hypervisor.c >> @@ -63,7 +63,7 @@ void hypervisor_resume(void) >> void __init hypervisor_e820_fixup(struct e820map *e820) > > What about this one? The function parameter ... > >> { >> if ( ops.e820_fixup ) >> - ops.e820_fixup(e820); >> + ops.e820_fixup(); >> } > > ... isn't used anymore, and the sole call site passes &e820. > It remained there by accident. >> --- a/xen/arch/x86/include/asm/e820.h >> +++ b/xen/arch/x86/include/asm/e820.h >> @@ -29,8 +29,7 @@ extern int reserve_e820_ram(struct e820map *e820, >> uint64_t s, uint64_t e); >> extern int e820_change_range_type( >> struct e820map *e820, uint64_t s, uint64_t e, >> uint32_t orig_type, uint32_t new_type); > > And what about this one? None of the other subjects in the series > suggest > this is then taken care of in a separate patch (as per the earlier > discussion it indeed doesn't want dealing with right here). > I'll mention this detail. While I work on other rules I'll think of a good way to rename. >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -686,7 +686,7 @@ static void __init parse_video_info(void) >> #endif >> } >> >> -static void __init kexec_reserve_area(struct e820map *e820) >> +static void __init kexec_reserve_area(void) >> { >> #ifdef CONFIG_KEXEC >> unsigned long kdump_start = kexec_crash_area.start; >> @@ -700,7 +700,7 @@ static void __init kexec_reserve_area(struct >> e820map *e820) >> >> is_reserved = true; >> >> - if ( !reserve_e820_ram(e820, kdump_start, kdump_start + >> kdump_size) ) >> + if ( !reserve_e820_ram(&boot_e820, kdump_start, kdump_start + >> kdump_size) ) >> { >> printk("Kdump: DISABLED (failed to reserve %luMB (%lukB) at >> %#lx)" >> "\n", kdump_size >> 20, kdump_size >> 10, >> kdump_start); >> @@ -1308,7 +1308,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> if ( e820.map[i].type == E820_RAM ) >> nr_pages += e820.map[i].size >> PAGE_SHIFT; >> set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); >> - kexec_reserve_area(&boot_e820); >> + kexec_reserve_area(); >> >> initial_images = mod; >> nr_initial_images = mbi->mods_count; >> @@ -1495,7 +1495,7 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >> reserve_e820_ram(&boot_e820, __pa(_stext), >> __pa(__2M_rwdata_end)); >> >> /* Late kexec reservation (dynamic start address). */ >> - kexec_reserve_area(&boot_e820); >> + kexec_reserve_area(); >> >> setup_max_pdx(raw_max_page); >> if ( highmem_start ) > > Seeing all the knock-on effects for the add_range() change, I think > this > separate adjustment would better have been an independent patch. > > Jan I can submit it standalone and put together x86/vmsi and delay -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 07:55:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 07:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580726.909127 (Exim 4.92) (envelope-from ) id 1qTe2Y-00080J-57; Wed, 09 Aug 2023 07:55:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580726.909127; Wed, 09 Aug 2023 07:55:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2Y-00080C-2O; Wed, 09 Aug 2023 07:55:34 +0000 Received: by outflank-mailman (input) for mailman id 580726; Wed, 09 Aug 2023 07:55:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2W-0007py-Fv for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 07:55:32 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c34454b-368a-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 09:55:30 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 77E3C4EE0741; Wed, 9 Aug 2023 09:55:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c34454b-368a-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 Date: Wed, 9 Aug 2023 09:55:08 +0200 Message-Id: <37bb5dc6f323bd2dc250c519523d05b66d17fdee.1691567429.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The local variables 'irq_desc' shadow the homonymous global variable, declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed 'irqd' for consistency. Signed-off-by: Nicola Vetrini --- xen/arch/x86/hvm/vmsi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index 3cd4923060..128f236362 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry *entry) int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtable) { - struct irq_desc *irq_desc; + struct irq_desc *irqd; struct msi_desc *msi_desc; struct pci_dev *pdev; struct msixtbl_entry *entry, *new_entry; @@ -482,14 +482,14 @@ int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtable) if ( !new_entry ) return -ENOMEM; - irq_desc = pirq_spin_lock_irq_desc(pirq, NULL); - if ( !irq_desc ) + irqd = pirq_spin_lock_irq_desc(pirq, NULL); + if ( !irqd ) { xfree(new_entry); return r; } - msi_desc = irq_desc->msi_desc; + msi_desc = irqd->msi_desc; if ( !msi_desc ) goto out; @@ -508,7 +508,7 @@ found: r = 0; out: - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); xfree(new_entry); if ( !r ) @@ -533,7 +533,7 @@ out: void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) { - struct irq_desc *irq_desc; + struct irq_desc *irqd; struct msi_desc *msi_desc; struct pci_dev *pdev; struct msixtbl_entry *entry; @@ -544,11 +544,11 @@ void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) if ( !msixtbl_initialised(d) ) return; - irq_desc = pirq_spin_lock_irq_desc(pirq, NULL); - if ( !irq_desc ) + irqd = pirq_spin_lock_irq_desc(pirq, NULL); + if ( !irqd ) return; - msi_desc = irq_desc->msi_desc; + msi_desc = irqd->msi_desc; if ( !msi_desc ) goto out; @@ -559,14 +559,14 @@ void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq) goto found; out: - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); return; found: if ( !atomic_dec_and_test(&entry->refcnt) ) del_msixtbl_entry(entry); - spin_unlock_irq(&irq_desc->lock); + spin_unlock_irq(&irqd->lock); } void msixtbl_init(struct domain *d) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 07:55:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 07:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580725.909118 (Exim 4.92) (envelope-from ) id 1qTe2V-0007lK-Uv; Wed, 09 Aug 2023 07:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580725.909118; Wed, 09 Aug 2023 07:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2V-0007lD-Ro; Wed, 09 Aug 2023 07:55:31 +0000 Received: by outflank-mailman (input) for mailman id 580725; Wed, 09 Aug 2023 07:55:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2U-0007l2-RH for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 07:55:30 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1bdfebd5-368a-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 09:55:29 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 8FF924EE073F; Wed, 9 Aug 2023 09:55:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bdfebd5-368a-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall Subject: [XEN PATCH 0/2] xen: address MISRA C:2012 Rule 5.3 Date: Wed, 9 Aug 2023 09:55:07 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series contains two patches left from previous series addressing the same MISRA Rule [1] [2], to make a standalone patch with the more involved changes that the first patch of [1] brings. The review comments on the respective threads about these patches have been addressed. [1] https://lore.kernel.org/xen-devel/cover.1691492441.git.nicola.vetrini@bugseng.com/ [2] https://lore.kernel.org/xen-devel/cover.1691488505.git.nicola.vetrini@bugseng.com/ Nicola Vetrini (2): x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 xen/delay: address MISRA C:2012 Rule 5.3. xen/arch/x86/hvm/vmsi.c | 22 +++++++++++----------- xen/include/xen/delay.h | 8 ++++++-- 2 files changed, 17 insertions(+), 13 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 07:55:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 07:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580727.909132 (Exim 4.92) (envelope-from ) id 1qTe2Y-00083C-Dg; Wed, 09 Aug 2023 07:55:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580727.909132; Wed, 09 Aug 2023 07:55:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2Y-000822-8s; Wed, 09 Aug 2023 07:55:34 +0000 Received: by outflank-mailman (input) for mailman id 580727; Wed, 09 Aug 2023 07:55:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTe2X-0007py-5M for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 07:55:33 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ca55bb2-368a-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 09:55:31 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 2F0374EE0740; Wed, 9 Aug 2023 09:55:30 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ca55bb2-368a-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3. Date: Wed, 9 Aug 2023 09:55:09 +0200 Message-Id: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable 'msec' declared in the macro shadows the local variable in 'ehci_dbgp_bios_handoff', but to prevent any future clashes with other functions the macro is converted to a static inline function. No functional change. Signed-off-by: Nicola Vetrini --- xen/include/xen/delay.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h index 9d70ef035f..9150226271 100644 --- a/xen/include/xen/delay.h +++ b/xen/include/xen/delay.h @@ -4,7 +4,11 @@ /* Copyright (C) 1993 Linus Torvalds */ #include -#define mdelay(n) (\ - {unsigned long msec=(n); while (msec--) udelay(1000);}) + +static inline void mdelay(unsigned long msec) +{ + while ( msec-- ) + udelay(1000); +} #endif /* defined(_LINUX_DELAY_H) */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 08:07:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 08:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580751.909147 (Exim 4.92) (envelope-from ) id 1qTeDy-0002ch-Vm; Wed, 09 Aug 2023 08:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580751.909147; Wed, 09 Aug 2023 08:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeDy-0002ca-TG; Wed, 09 Aug 2023 08:07:22 +0000 Received: by outflank-mailman (input) for mailman id 580751; Wed, 09 Aug 2023 08:07:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeDx-0002cQ-Ui; Wed, 09 Aug 2023 08:07:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeDx-0001sP-Na; Wed, 09 Aug 2023 08:07:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeDx-000363-8O; Wed, 09 Aug 2023 08:07:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTeDx-00031H-7B; Wed, 09 Aug 2023 08:07:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mnv87k4yU+7V4QLDKdDxsTMKzBFSxY3WxaqEH1iOWHw=; b=tBT9U46pPVk+llsv6Vzo7Kk2mi kAxuhpf79Lqvf1cI7E9nuNKd7mRKJ8LDzIYC72nvAIRtrbzXSFiH0Ds6yIMuNDU3o9/h3LI8sIGDt IDogHhMh9MHluX5xNAk796Bh3FtXnYCsmkc0ap2OFSLjZp1jz0dP5ZkeMlDAjUXBH3TQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182233: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt-qcow2::broken:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-armhf-armhf-libvirt-qcow2:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=14f9643dc90adea074a0ffb7a17d337eafc6a5cc X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Wed, 09 Aug 2023 08:07:21 +0000 flight 182233 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182233/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-qcow2 broken in 182225 test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 5 host-install(5) broken in 182225 pass in 182233 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail in 182225 pass in 182233 test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 182225 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail pass in 182225 test-amd64-amd64-xl-qemuu-ovmf-amd64 18 guest-localmigrate/x10 fail pass in 182225 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 14f9643dc90adea074a0ffb7a17d337eafc6a5cc baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 114 days Failing since 180281 2023-04-17 06:24:36 Z 114 days 206 attempts Testing same since 182225 2023-08-08 00:12:17 Z 1 days 2 attempts ------------------------------------------------------------ 3915 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt-qcow2 broken Not pushing. (No revision log; it would be 658984 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 08:09:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 08:09:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580759.909157 (Exim 4.92) (envelope-from ) id 1qTeFk-0003Bn-CI; Wed, 09 Aug 2023 08:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580759.909157; Wed, 09 Aug 2023 08:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFk-0003Bg-9R; Wed, 09 Aug 2023 08:09:12 +0000 Received: by outflank-mailman (input) for mailman id 580759; Wed, 09 Aug 2023 08:09:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFj-0003Ba-Bg for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 08:09:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0459be0a-368c-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 10:09:09 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 848F64EE073F; Wed, 9 Aug 2023 10:09:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0459be0a-368c-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 0/3] automation/eclair: update ECL configurations and builds Date: Wed, 9 Aug 2023 10:07:58 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series contains new ECL configurations and adds some build options in the ARM64 build. Simone Ballarin (3): automation/eclair: update clean guidelines automation/eclair: add ECL deviations automation/eclair: update analyzed builds .../eclair_analysis/ECLAIR/deviations.ecl | 34 ++++++++----------- automation/eclair_analysis/ECLAIR/tagging.ecl | 17 ++++++++-- automation/eclair_analysis/xen_arm_config | 14 +++----- automation/eclair_analysis/xen_x86_config | 9 ----- 4 files changed, 34 insertions(+), 40 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 08:09:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 08:09:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580760.909168 (Exim 4.92) (envelope-from ) id 1qTeFo-0003SF-KF; Wed, 09 Aug 2023 08:09:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580760.909168; Wed, 09 Aug 2023 08:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFo-0003S8-GJ; Wed, 09 Aug 2023 08:09:16 +0000 Received: by outflank-mailman (input) for mailman id 580760; Wed, 09 Aug 2023 08:09:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFn-0003RD-07 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 08:09:15 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 071effee-368c-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 10:09:13 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 65B284EE073F; Wed, 9 Aug 2023 10:09:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 071effee-368c-11ee-b280-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 1/3] automation/eclair: update clean guidelines Date: Wed, 9 Aug 2023 10:07:59 +0200 Message-Id: <89e4ad4c56c083391b24b9da55212e888c5f3beb.1691568344.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch splits the former list in two separate selectors clean_guidelines_common and additional_clean_guidelines. clean_guidelines_common contains the guidelines that are clean in both the analyzed builds, instead additional_clean_guidelines is popolated depending on the current one. The following clean guidelines have been added: - MC3R1.R1.1; - MC3R1.R1.3; - MC3R1.R3.1; - MC3R1.R4.1; - MC3R1.R17.4; - MC3R1.R22.6; - MC3R1.D4.3 (just x86_64); - MC3R1.R5.3 (just arm64); - MC3R1.R7.2 (just arm64); - MC3R1.R8.6 (just arm64); - MC3R1.R9.3 (just arm64). Signed-off-by: Simone Ballarin --- automation/eclair_analysis/ECLAIR/tagging.ecl | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl index ef2e56e186..3f589fd716 100644 --- a/automation/eclair_analysis/ECLAIR/tagging.ecl +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl @@ -28,7 +28,20 @@ #################### -doc_begin="Clean guidelines: new violations for these guidelines are not accepted." --service_selector={clean_guidelines,"^(MC3R1\\.D1\\.1|MC3R1\\.D2\\.1|MC3R1\\.D4\\.11|MC3R1\\.D4\\.14|MC3R1\\.R1\\.4|MC3R1\\.R2\\.2|MC3R1\\.R3\\.2|MC3R1\\.R5\\.1|MC3R1\\.R5\\.2|MC3R1\\.R5\\.4|MC3R1\\.R6\\.1|MC3R1\\.R6\\.2|MC3R1\\.R7\\.1|MC3R1\\.R8\\.1|MC3R1\\.R8\\.5|MC3R1\\.R8\\.8|MC3R1\\.R8\\.10|MC3R1\\.R8\\.12|MC3R1\\.R8\\.14|MC3R1\\.R9\\.2|MC3R1\\.R9\\.4|MC3R1\\.R9\\.5|MC3R1\\.R12\\.5|MC3R1\\.R17\\.3|MC3R1\\.R17\\.6|MC3R1\\.R21\\.13|MC3R1\\.R21\\.19|MC3R1\\.R21\\.21|MC3R1\\.R22\\.2|MC3R1\\.R22\\.4|MC3R1\\.R22\\.5)$" + +-service_selector={clean_guidelines_common,"^(MC3R1\\.D1\\.1|MC3R1\\.D2\\.1|MC3R1\\.D4\\.11|MC3R1\\.D4\\.14|MC3R1\\.R1\\.1|MC3R1\\.R1\\.3|MC3R1\\.R1\\.4|MC3R1\\.R2\\.2|MC3R1\\.R3\\.1|MC3R1\\.R3\\.2|MC3R1\\.R4\\.1|MC3R1\\.R5\\.1|MC3R1\\.R5\\.2|MC3R1\\.R5\\.4|MC3R1\\.R6\\.1|MC3R1\\.R6\\.2|MC3R1\\.R7\\.1|MC3R1\\.R8\\.1|MC3R1\\.R8\\.5|MC3R1\\.R8\\.8|MC3R1\\.R8\\.10|MC3R1\\.R8\\.12|MC3R1\\.R8\\.14|MC3R1\\.R9\\.2|MC3R1\\.R9\\.4|MC3R1\\.R9\\.5|MC3R1\\.R12\\.5|MC3R1\\.R17\\.3|MC3R1\\.R17\\.4|MC3R1\\.R17\\.6|MC3R1\\.R21\\.13|MC3R1\\.R21\\.19|MC3R1\\.R21\\.21|MC3R1\\.R22\\.2|MC3R1\\.R22\\.4|MC3R1\\.R22\\.5|MC3R1\\.R22\\.6)$" } --reports+={clean:added,"service(clean_guidelines)"} + +-setq=target,getenv("XEN_TARGET_ARCH") + +if(string_equal(target,"x86_64"), + service_selector({"additional_clean_guidelines","^(MC3R1\\.D4\\.3)$"}) +) + +if(string_equal(target,"arm64"), + service_selector({"additional_clean_guidelines","^(MC3R1\\.R5\\.3|MC3R1\\.R7\\.2|MC3R1\\.R8\\.6|MC3R1\\.R9\\.3)$"}) +) + +-reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"} + -doc_end -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 08:09:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 08:09:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580761.909178 (Exim 4.92) (envelope-from ) id 1qTeFu-0003mC-SN; Wed, 09 Aug 2023 08:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580761.909178; Wed, 09 Aug 2023 08:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFu-0003m1-Oc; Wed, 09 Aug 2023 08:09:22 +0000 Received: by outflank-mailman (input) for mailman id 580761; Wed, 09 Aug 2023 08:09:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFt-0003RD-GB for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 08:09:21 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b469882-368c-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 10:09:20 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 5E77B4EE073F; Wed, 9 Aug 2023 10:09:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b469882-368c-11ee-b280-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 2/3] automation/eclair: add ECL deviations Date: Wed, 9 Aug 2023 10:08:00 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch adds some deviations for the following guidelines: Rule 2.1, Rule 5.3 and Rule 8.2. Signed-off-by: Simone Ballarin --- .../eclair_analysis/ECLAIR/deviations.ecl | 34 ++++++++----------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl index e1a06daf2f..696618b59e 100644 --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -14,8 +14,13 @@ Constant expressions and unreachable branches of if and switch statements are ex -config=MC3R1.R2.1,+reports={deliberate,"first_area(^.*is never referenced$)"} -doc_end --doc_begin="Unreachability in the following macros are expected and safe." --config=MC3R1.R2.1,statements+={safe,"macro(name(BUG||assert_failed||ERROR_EXIT||ERROR_EXIT_DOM||PIN_FAIL))"} +-doc_begin="Unreachability caused by calls to the following functions or macros is deliberate and there is no risk of code being unexpectedly left out." +-config=MC3R1.R2.1,statements+={deliberate,"macro(name(BUG||assert_failed||ERROR_EXIT||ERROR_EXIT_DOM||PIN_FAIL))"} +-config=MC3R1.R2.1,statements+={deliberate, "call(decl(name(__builtin_unreachable||panic||do_unexpected_trap||machine_halt||machine_restart||maybe_reboot)))"} +-doc_end + +-doc_begin="Unreachability of an ASSERT_UNREACHABLE() and analogous macro calls is deliberate and safe." +-config=MC3R1.R2.1,reports+={deliberate, "any_area(any_loc(any_exp(macro(name(ASSERT_UNREACHABLE||PARSE_ERR_RET||PARSE_ERR||FAIL_MSR||FAIL_CPUID)))))"} -doc_end -doc_begin="Proving compliance with respect to Rule 2.2 is generally impossible: @@ -93,25 +98,11 @@ conform to the directive." -doc_begin="The project adopted the rule with an exception listed in 'docs/misra/rules.rst'" -config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^READ_SYSREG$))&&any_exp(macro(^WRITE_SYSREG$))))"} --config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^max_t$))&&any_exp(macro(^min_t$))))"} +-config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^max(_t)?$))&&any_exp(macro(^min(_t)?$))))"} -config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^read[bwlq]$))&&any_exp(macro(^read[bwlq]_relaxed$))))"} -config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^per_cpu$))&&any_exp(macro(^this_cpu$))))"} --doc_end - --doc_begin="The identifier 'fdt' is a widely-used name, for which no suitable -substitute can be found. It is understood in 'xen/arch/arm/efi-boot.h' that the -static variable 'fdt' cannot be confused with parameter names of the function -declarations that are present in the file." --file_tag+={efi_boot_h, "^xen/arch/arm/efi/efi-boot\\.h$"} --config=MC3R1.R5.3,reports+={deliberate, "any_area(decl(kind(var)&&static_storage()&&^fdt$)&&any_loc(file(efi_boot_h)))"} --doc_end - --doc_begin="The identifier 'start' is a widely-used name, for which no suitable -substitute can be found. It is understood in 'xen/include/xen/kernel.h' that the -extern variable 'start' cannot be confused with omonymous parameter names of the -function declarations where that variable is visible." --file_tag+={kernel_h, "^xen/include/xen/kernel\\.h$"} --config=MC3R1.R5.3,reports+={deliberate, "any_area(decl(kind(var)&&linkage(external)&&^start$)&&any_loc(file(kernel_h)))"} +-config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^__emulate_2op$))&&any_exp(macro(^__emulate_2op_nobyte$))))"} +-config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^read_debugreg$))&&any_exp(macro(^write_debugreg$))))"} -doc_end -doc_begin="Function-like macros cannot be confused with identifiers that are @@ -179,6 +170,11 @@ const-qualified." # Series 8. # +-doc_begin="The following file is imported from Linux: ignore for now." +-file_tag+={adopted_r8_2,"^xen/common/inflate\\.c$"} +-config=MC3R1.R8.2,reports+={deliberate,"any_area(any_loc(file(adopted_r8_2)))"} +-doc_end + -doc_begin="The following variables are compiled in multiple translation units belonging to different executables and therefore are safe." -config=MC3R1.R8.6,declarations+={safe, "name(current_stack_pointer||bsearch||sort)"} -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 08:09:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 08:09:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580763.909188 (Exim 4.92) (envelope-from ) id 1qTeFw-00042x-8q; Wed, 09 Aug 2023 08:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580763.909188; Wed, 09 Aug 2023 08:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFw-00042n-5C; Wed, 09 Aug 2023 08:09:24 +0000 Received: by outflank-mailman (input) for mailman id 580763; Wed, 09 Aug 2023 08:09:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTeFv-0003RD-QH for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 08:09:23 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cb5bcc8-368c-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 10:09:23 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id C02244EE0740; Wed, 9 Aug 2023 10:09:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cb5bcc8-368c-11ee-b280-6b7b168915f2 From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Simone Ballarin , Doug Goldstein , Stefano Stabellini Subject: [XEN PATCH 3/3] automation/eclair: update analyzed builds Date: Wed, 9 Aug 2023 10:08:01 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The xen build for ARM64 now has new configuration options which require to be defined: this patch defines them. In both configuration files some no longer true comments have been removed. Signed-off-by: Simone Ballarin --- automation/eclair_analysis/xen_arm_config | 14 ++++---------- automation/eclair_analysis/xen_x86_config | 9 --------- 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/automation/eclair_analysis/xen_arm_config b/automation/eclair_analysis/xen_arm_config index 26f5fcca41..ef140ceb73 100644 --- a/automation/eclair_analysis/xen_arm_config +++ b/automation/eclair_analysis/xen_arm_config @@ -1,12 +1,3 @@ -# File provided in -# Re: Xen MISRA C: Source files in scope and out of scope -# from: Stefano Stabellini -# date: 6 giu 2023, 02:53 - -# -# Automatically generated file; DO NOT EDIT. -# Xen/arm 4.18-unstable Configuration -# CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=90400 CONFIG_CLANG_VERSION=0 @@ -34,7 +25,9 @@ CONFIG_HVM=y CONFIG_SBSA_VUART_CONSOLE=y CONFIG_ARM_SSBD=y CONFIG_HARDEN_BRANCH_PREDICTOR=y -# CONFIG_TEE is not set +CONFIG_TEE=n +CONFIG_OPTEE=n +CONFIG_FFA=n # CONFIG_STATIC_SHM is not set # end of Architecture Features @@ -47,6 +40,7 @@ CONFIG_ARM64_ERRATUM_819472=y CONFIG_ARM64_ERRATUM_843419=y CONFIG_ARM64_ERRATUM_832075=y CONFIG_ARM64_ERRATUM_834220=y +CONFIG_ARM64_ERRATUM_1508412=y CONFIG_ARM_ERRATUM_858921=y CONFIG_ARM64_WORKAROUND_REPEAT_TLBI=y CONFIG_ARM64_ERRATUM_1286807=y diff --git a/automation/eclair_analysis/xen_x86_config b/automation/eclair_analysis/xen_x86_config index d497814e01..abc44d43e1 100644 --- a/automation/eclair_analysis/xen_x86_config +++ b/automation/eclair_analysis/xen_x86_config @@ -1,12 +1,3 @@ -# File provided in -# Re: Xen MISRA C: Source files in scope and out of scope -# from: Stefano Stabellini -# date: 6 giu 2023, 02:53 - -# -# Automatically generated file; DO NOT EDIT. -# Xen/x86 4.18-unstable Configuration -# CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=90400 CONFIG_CLANG_VERSION=0 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 08:59:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 08:59:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580789.909198 (Exim 4.92) (envelope-from ) id 1qTf1k-0001uQ-Sv; Wed, 09 Aug 2023 08:58:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580789.909198; Wed, 09 Aug 2023 08:58:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTf1k-0001uJ-Pf; Wed, 09 Aug 2023 08:58:48 +0000 Received: by outflank-mailman (input) for mailman id 580789; Wed, 09 Aug 2023 08:58:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTf1j-0001uD-MY for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 08:58:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f130a448-3692-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 10:58:43 +0200 (CEST) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by support.bugseng.com (Postfix) with ESMTPSA id 329CB4EE0744 for ; Wed, 9 Aug 2023 10:58:43 +0200 (CEST) Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-487203bfbc6so1656546e0c.1 for ; Wed, 09 Aug 2023 01:58:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f130a448-3692-11ee-8613-37d641c3527e X-Gm-Message-State: AOJu0YzJyVfs3P3K5xuG2CadkS0vVu3wrMWiDkKuX7YdYBEnhgv1LUJ1 XyJ0pBUpJw9QQSjFF8EI49gC0v0w6IRmEtn4INU= X-Google-Smtp-Source: AGHT+IHfqkd1fs1G+auNdi2Jj0DmziS1LodfzCG8egIJC6u0z/v+TFsgiaa/G2Oz9iw4GmTqU/V7Q3OIs/4+7wNKt5Q= X-Received: by 2002:a1f:6082:0:b0:485:ac24:df1 with SMTP id u124-20020a1f6082000000b00485ac240df1mr2598536vkb.12.1691571521967; Wed, 09 Aug 2023 01:58:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Simone Ballarin Date: Wed, 9 Aug 2023 10:58:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 7.2 To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant , Stefano Stabellini Content-Type: multipart/alternative; boundary="000000000000addeab060279afac" --000000000000addeab060279afac Content-Type: text/plain; charset="UTF-8" Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin < simone.ballarin@bugseng.com> ha scritto: > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline > states: > "A 'u' or 'U' suffix shall be applied to all integer constants that are > represented in an unsigned type". > > These violations are caused by the missing "u" or "U" suffix in unsigned > integer constants, such as: > > xen/arch/x86/hvm/hypercall.c:132.17-132.26 > if ( (eax & 0x80000000) && is_viridian_domain(currd) ) > > If a rule is not met, changes are needed in order to achieve compliance. > The patches in this series achieve compliance for MISRA C:2012 Rule 7.2 by > adding the 'U' suffix to integers literals with unsigned type and also to > other > literals used in the same contexts or near violations, when their positive > nature is immediately clear. The latter changes are done for the sake of > uniformity. > > Gianluca Luparini (4): > x86/vmx: address violations of MISRA C:2012 Rule 7.2 > xen/vpci: address violations of MISRA C:2012 Rule 7.2 > x86/viridian: address violations of MISRA C:2012 Rule 7.2 > xen/x86: address violations of MISRA C:2012 Rule 7.2 > > xen/arch/x86/apic.c | 2 +- > xen/arch/x86/cpu-policy.c | 18 +- > xen/arch/x86/cpu/mcheck/mce-apei.c | 4 +- > xen/arch/x86/cpu/vpmu_intel.c | 2 +- > xen/arch/x86/cpuid.c | 8 +- > xen/arch/x86/efi/efi-boot.h | 6 +- > xen/arch/x86/extable.c | 2 +- > xen/arch/x86/hvm/hypercall.c | 2 +- > xen/arch/x86/hvm/pmtimer.c | 4 +- > xen/arch/x86/hvm/stdvga.c | 50 +++--- > xen/arch/x86/hvm/viridian/viridian.c | 2 +- > xen/arch/x86/hvm/vlapic.c | 6 +- > xen/arch/x86/hvm/vmx/vmcs.c | 6 +- > xen/arch/x86/hvm/vmx/vvmx.c | 8 +- > xen/arch/x86/include/asm/apicdef.h | 2 +- > xen/arch/x86/include/asm/config.h | 2 +- > xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 +-- > xen/arch/x86/include/asm/hpet.h | 2 +- > xen/arch/x86/include/asm/hvm/trace.h | 4 +- > xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- > xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 84 ++++----- > xen/arch/x86/include/asm/hvm/vmx/vmx.h | 16 +- > xen/arch/x86/include/asm/msi.h | 2 +- > xen/arch/x86/include/asm/msr-index.h | 180 +++++++++---------- > xen/arch/x86/include/asm/pci.h | 8 +- > xen/arch/x86/include/asm/x86-defns.h | 24 +-- > xen/arch/x86/percpu.c | 2 +- > xen/arch/x86/psr.c | 2 +- > xen/arch/x86/spec_ctrl.c | 8 +- > xen/arch/x86/x86_64/pci.c | 2 +- > xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- > xen/drivers/vpci/msi.c | 2 +- > xen/drivers/vpci/msix.c | 2 +- > xen/drivers/vpci/vpci.c | 6 +- > xen/lib/x86/cpuid.c | 8 +- > xen/lib/x86/policy.c | 2 +- > 36 files changed, 255 insertions(+), 255 deletions(-) > > -- > 2.34.1 > > Hi all, the entire series has not received yet any feedback or Acked-by. I would kindly ask if it is possible to have at least some feedback -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com ) --000000000000addeab060279afac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
Il giorno mer 26 lug 2023 alle ore 13= :04 Simone Ballarin <simo= ne.ballarin@bugseng.com> ha scritto:
The xen sources contains violations of MISRA C:= 2012 Rule 7.2 whose headline
states:
"A 'u' or 'U' suffix shall be applied to all integer c= onstants that are
represented in an unsigned type".

These violations are caused by the missing "u" or "U" s= uffix in unsigned
integer constants, such as:

xen/arch/x86/hvm/hypercall.c:132.17-132.26
if ( (eax & 0x80000000) && is_viridian_domain(currd) )

If a rule is not met, changes are needed in order to achieve compliance. The patches in this series achieve compliance for MISRA C:2012 Rule 7.2 by<= br> adding the 'U' suffix to integers literals with unsigned type and a= lso to other
literals used in the same contexts or near violations, when their positive<= br> nature is immediately clear. The latter changes are done for the sake of uniformity.

Gianluca Luparini (4):
=C2=A0 x86/vmx: address violations of MISRA C:2012 Rule 7.2
=C2=A0 xen/vpci: address violations of MISRA C:2012 Rule 7.2
=C2=A0 x86/viridian: address violations of MISRA C:2012 Rule 7.2
=C2=A0 xen/x86: address violations of MISRA C:2012 Rule 7.2

=C2=A0xen/arch/x86/apic.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/cpu-policy.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 18 +-
=C2=A0xen/arch/x86/cpu/mcheck/mce-apei.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 =C2=A04 +-
=C2=A0xen/arch/x86/cpu/vpmu_intel.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/cpuid.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A08 +-
=C2=A0xen/arch/x86/efi/efi-boot.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 +-
=C2=A0xen/arch/x86/extable.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/hvm/hypercall.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/hvm/pmtimer.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A04 +-
=C2=A0xen/arch/x86/hvm/stdvga.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 50 +++---
=C2=A0xen/arch/x86/hvm/viridian/viridian.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/hvm/vlapic.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 +-
=C2=A0xen/arch/x86/hvm/vmx/vmcs.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 +-
=C2=A0xen/arch/x86/hvm/vmx/vvmx.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A08 +-
=C2=A0xen/arch/x86/include/asm/apicdef.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/include/asm/config.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/include/asm/guest/hyperv-tlfs.h |=C2=A0 28 +--
=C2=A0xen/arch/x86/include/asm/hpet.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/include/asm/hvm/trace.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 =C2=A04 +-
=C2=A0xen/arch/x86/include/asm/hvm/vioapic.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 =C2=A02 +-
=C2=A0xen/arch/x86/include/asm/hvm/vmx/vmcs.h=C2=A0 =C2=A0 =C2=A0 |=C2=A0 8= 4 ++++-----
=C2=A0xen/arch/x86/include/asm/hvm/vmx/vmx.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 16 +-
=C2=A0xen/arch/x86/include/asm/msi.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/include/asm/msr-index.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 180 +++++++++----------
=C2=A0xen/arch/x86/include/asm/pci.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 =C2=A08 +-
=C2=A0xen/arch/x86/include/asm/x86-defns.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 24 +--
=C2=A0xen/arch/x86/percpu.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/psr.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/spec_ctrl.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A08 +-
=C2=A0xen/arch/x86/x86_64/pci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/arch/x86/x86_emulate/x86_emulate.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 =C2=A02 +-
=C2=A0xen/drivers/vpci/msi.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A0xen/drivers/vpci/msix.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
=C2=A0xen/drivers/vpci/vpci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A06 +-
=C2=A0xen/lib/x86/cpuid.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A08 +-
=C2=A0xen/lib/x86/policy.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
=C2=A036 files changed, 255 insertions(+), 255 deletions(-)

--
2.34.1


Hi all,
the entire seri= es has not received yet any feedback or Acked-by.
I wo= uld kindly ask if it is possible to have at least some feedback

--
Simone Ballarin, M.Sc.

Fi= eld Application Engineer, BUGSENG (https://bugseng.com)
--000000000000addeab060279afac-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 09:00:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 09:00:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580794.909207 (Exim 4.92) (envelope-from ) id 1qTf3N-0003Jc-6Y; Wed, 09 Aug 2023 09:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580794.909207; Wed, 09 Aug 2023 09:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTf3N-0003JV-3s; Wed, 09 Aug 2023 09:00:29 +0000 Received: by outflank-mailman (input) for mailman id 580794; Wed, 09 Aug 2023 09:00:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTf3L-0003JF-JJ for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 09:00:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTf3I-0003CE-77; Wed, 09 Aug 2023 09:00:24 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTf3H-0005Jl-UQ; Wed, 09 Aug 2023 09:00:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZpyrlDtSAaBmGeL8uwVxOFxS5efcTJ6IEwKkh8xyLW8=; b=w2Nq+mlzvqECg1iZM9d8ThDA7j 4PFcoyyySIpCw9g5zsEH0RA+ltJR5eU3Uz2aPGpD5vB+tSmQC9mKpE5bVl3mhk6yZgEbMpuZQhwAd vFzRZOQC5kTtC7sQ/PPnKV/WbNMy5x3eh+q+330m1F6e//u7zmlIMM7/XltJr44VVtHY=; Message-ID: Date: Wed, 9 Aug 2023 10:00:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-GB To: "Daniel P. Smith" , Stefano Stabellini Cc: Volodymyr Babchuk , xen-devel@lists.xenproject.org, Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> <14346689-8276-3c26-91e1-59bc2328518e@apertussolutions.com> <423f86e7-10ee-134e-7683-e15f7e2c64ed@xen.org> <3decc6de-8d82-a862-36a8-9ddcd94fac4f@apertussolutions.com> From: Julien Grall In-Reply-To: <3decc6de-8d82-a862-36a8-9ddcd94fac4f@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Daniel, On 08/08/2023 23:31, Daniel P. Smith wrote: > > > On 8/3/23 17:24, Julien Grall wrote: >> Hi Daniel, >> >> On 03/08/2023 16:41, Daniel P. Smith wrote: >>> On 8/1/23 21:01, Stefano Stabellini wrote: >>>> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>>>> patch the field is renamed to capabilities to encapsulate the >>>>> capabilities a >>>>> domain has been granted. The first capability being the ability to >>>>> read/write >>>>> the Xen console. >>>>> >>>>> Signed-off-by: Daniel P. Smith >>>> >>>> Patch looks fine to me aside the two minor nits. I am not sure I >>>> understand 100% the difference between capabilities and roles but I am >>>> OK with the patch. I'd like to hear Julien's feedback on this as well. >>> >>> This might be worth a section in the hypervisor-guide. As mentioned >>> in the cover letter, this was originally proposed as being under XSM. >>> A challenge I ran into is that, depending on your view, the >>> `is_privileged` field and `hardware_domain` global were either abused >>> as a function check and a non-resource privilege check or are just >>> multifaceted variables. This is why the concept of the role was >>> struck upon, it is more intuitive (for me at least) that have a role >>> is something that imparts accesses (privilege checks) and dictates >>> hypervisor behaviors when handling the domain (function checks). This >>> then brings us to an access or behavior that may be inherent to some >>> role(s) but may want to grant on an individually to a guest. A prime >>> example of this is console_io, for which it is inherent that the >>> hardware domain role will have access but may want to grant to a >>> guest without granting it an entire role. This is why I provided for >>> identifying these capabilities so that they may be assigned >>> individually to a domain. >> >> Thanks for the explanation. Just to confirm my understanding, what you >> are suggesting is that for a given role, a domain will at least have >> the matching capabilities (more could be granted). Is that correct? >> >> If so, this wouldn't this mean we can remove d->role and simply use >> d->capabilities? > > We could start out with CAP_CTRL and CAP_HW, but it is a little > illogical. For instance, control domain has many capabilities, they just > have never been fully broken out. XSM did some, but the focus there was > just on system resources. Similar with the hardware domain. You are > right that it would better deal with the limited number of bits > currently available. > >>> >>> While the role/capability is a natural progression from how the >>> hypervisor currently operates. Another approach that could be >>> consider to deliver a similar experience would be to break down every >>> access and function into a capability and then define the standard >>> roles as a conglomeration of certain capabilities. >> >> At least from the explanation above, I think it would make sense to >> break down role to multiple capabilities. > > Would it be acceptable to do this incrementally over time as we are able > to determine what needs to be broken out as a distinct capability? I would be fine with that. Note that some care will be needed for the Device-Tree to either version the capabilities or at least not break boot when using an old DT on a new Xen. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 09:16:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 09:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580802.909217 (Exim 4.92) (envelope-from ) id 1qTfIc-0004wW-Gw; Wed, 09 Aug 2023 09:16:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580802.909217; Wed, 09 Aug 2023 09:16:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfIc-0004wO-EG; Wed, 09 Aug 2023 09:16:14 +0000 Received: by outflank-mailman (input) for mailman id 580802; Wed, 09 Aug 2023 09:16:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfIb-0004w0-1P for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 09:16:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2072.outbound.protection.outlook.com [40.107.7.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 62354762-3695-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 11:16:12 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB7604.eurprd04.prod.outlook.com (2603:10a6:20b:287::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 09:15:42 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 09:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62354762-3695-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KlyaBEURdZHr7ialhospcLF7ozvSSWdqOSBxqsJMH2TiKAsKlAYt8qHmX3Zrr9bm0t8lsJy0pW0ByfB+IsBweIov/dH50YjdIylHA7VEOhefVb3obfQp/D/Md3QdGLU23J3aCB2Nf4CVIrh/JtO4mf0OBdK+sPtBJTOYEQD5CCO8RWDOHFFCplNXbOJMlbKz8B+Vvi0T9699iw1Gjr+8xH1AsbDWSwrJLSTp9yPoaWwwUyl3d8XupryWFR84fGylFlMPvWS71eqCJYPBmGJ648puZS8db8EPt2otLbVGM2jqdMFTVFKMPHr91jiC4b6f6M+eMyahhX8q+32DpfUubQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g0SVfRREii59ren720/+A5oU1Ur2AyrXTFM7UsWvm1w=; b=LmmoZ66jdR3Lbaq+fc2ezA1FU0IeZpw3/3z/peQD+i7oMy05Fv6UpZ1nn5lp8yantUdxAX7UZdu6btmUmsk9nQ0bNnAP+pkXe7OMsigJnxk+KWSqFJUsB9nupb/WAzUOrMYnl82BrzoQWxZlpX2lR3acrfHHXtVeg9xaCHyPyYGHl1ne1u7rbmuN9zpYPNTW2DvJ4WSBefUahgi+g7T0KYFBZ2KVdajcSJIb2K3V5dGal1zyKF63YAzpDfn/VYl3uIgdsJxwCetja8znIzjgZdiW6+n/GGWorolq8UP7df39VS4L1R/RMW+WwpcWNe7dYvfBSxGLt6865gtITfgQbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g0SVfRREii59ren720/+A5oU1Ur2AyrXTFM7UsWvm1w=; b=sU77fNL94lP1frF6n4A13+YgGwUN27o7SNFiw1/DtCeOHrK+vhxGpSSKSmlg3d7SczvcIva6GavhCH/vqRx+VNWcwBkmK1aJmKMOtsdMPIyHJYfXV/2aEicKXmI90W68F9GP+D4f/BuMeIrJ48UoeqEoEydYcaXTBjOwmiYdSRU3f3UhDPvpWHKNYhLlSvjwW0V8eftfU/QV+eJrMi3oXj/t19EuIMKbZb1ovbALxyVccctUxjxWBeRIm2c6jxHfBiibdTQ+jBVHp7tWEL/3riCWCvRPsbJIKOymKzFBeKa+lY+RmtO+rtyqXVZOpokYo0FC+wbgPnuhAVwY4Wg+yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8da9b4fe-3109-3a5e-9bc6-15fccc13a8f3@suse.com> Date: Wed, 9 Aug 2023 11:15:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 7.2 Content-Language: en-US To: Simone Ballarin Cc: consulting@bugseng.com, Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , Stefano Stabellini , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB7604:EE_ X-MS-Office365-Filtering-Correlation-Id: c76555d3-84da-4622-aec0-08db98b9347f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rHC7YvQOXNbYYTGb7wX+L2C+iDfLzOatZqaIMLIINZTt9UPf3ScfuPIZkGAttVjn7LgZxbHbCClARhRfgytoSwP2sZcom77HtkI6IVAmemt/RWky/4VBdVWFMgKamBaUsa47nsZRiXF6FocK5kQulMajtx2DU+7FpqHif03Gw4xJSgGqtgQBODJ/1kNBtXmJz/5EOYNbcR8feuO8slK2tcbEfCpFegUm7lPc6SYJP+t6/DTMdS+lv5HH2Vp7/PQqbVb3M5f/vmGJCO1fX5subnk/O6IT047ZKBrWQ1VqTLZjSP9tGBuWxGmEm8vdvOZMQC1iRC/Q0J7XSza6CrghUVmGUkK348B3bPoviRVRcx/kx3VcImvykl/yqXiG4YKd86i9jbQdlY9xQakPmV1x7iSaaZAu7peCPd06HyP/zeyMYR23SauTCqwQszd6JSoT54pHZb17AsvZytbUBmT4we6xIPd66H4EEnUV+CllKfvIveWIsFxHwRzOHpCMAIrOVY61y4licsp25CDg921NQOeaGc9jlnXh4tnmphJllpMm8tVkLnqsW87MI0zQEtSfHOV/KiQQJuJ1lAAWjwAl2uqrgfhmglGkUetI9/QRdrWG+BnVJqG9K+j6qkk/lqTGOD4f5RFiXOl5iv+g9sdDoA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39860400002)(186006)(1800799006)(451199021)(26005)(41300700001)(7416002)(2906002)(31686004)(5660300002)(83380400001)(8936002)(8676002)(2616005)(478600001)(6916009)(31696002)(53546011)(38100700002)(66556008)(86362001)(6666004)(54906003)(6506007)(66476007)(66946007)(6486002)(4326008)(6512007)(316002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmF0WjFqMitDRHVlaytDRkxiS2Uza1BYd2huYnlTc0NoTWttM3liNXE3S0NG?= =?utf-8?B?THhBT1pmVWtkaGRvSEh0VUdSVHNpQWVxYWkrcjhFeDBRV1pjUnNMOFNHeHAy?= =?utf-8?B?c3JhREg4anU2dkEwZmhta1ZsN0VXcThKT0F1ZFZXUnZVOFdkZjJ5emdYaVpQ?= =?utf-8?B?bnhqRTNvL0N5RmR2NzVLRVVkZzUxUytwdUtGOFJUdithSkc0UVp5QU1ocjlF?= =?utf-8?B?dmpXQkhVWUlmNWkyaEZ0MFhJWUJ3Rzc2dXdvWHlPS2ZXY25IemFiV1ZnbDFJ?= =?utf-8?B?NEdvblRsRVYvbUh4SmVWRG0xcW80bnNFdjljY1MyYjI3aVpwc3FEK3JPd1Ja?= =?utf-8?B?dHcxWnB2RERnOUNwZFZBdG9sUHh0VFh5UlJybERDUGJ6bmVyUVV4a2FMYlVV?= =?utf-8?B?dGhOR1JKKzRiYm9XZ0RVSERNK3BUbksvZ1FHSlkvdjU2V1RYdWttTUhSVnZt?= =?utf-8?B?WHVwYUVtSVBhbTRuNTUrVXBNcGhzRGJRd3FTcjBPejQza0F2MVFGbXpWZDZ2?= =?utf-8?B?a01FMkpHNVV2NjJSSXNKc29DeGpSenZnTGEvMGVwVXl3NDA1SGI1K2pubzFv?= =?utf-8?B?d29NNkNPVnIzcVJBRlpYbWRXbmlaQnp2ejdISUZCbTdTOEN1S2FyVlloazRS?= =?utf-8?B?Y1ZEUzJYVlg4L2dtM0dGTUl6RlhIVXY5TTRHb0xuUG0rL0daZUhhV2M3QWRh?= =?utf-8?B?UU1MVXpML3ZxQ1FhQW9PZU5pU3NXbWduZUdTdzJWeE1vMmZKUEpoZnBoTjhX?= =?utf-8?B?RVNKVWhNdC93dlo5d2FSQWxDTGNvS0l5cHlXR0thQXNxNG1XSjhXbzdOdzNF?= =?utf-8?B?SEJhZlZUWkpWM3RpT29QaXZkb1VFQWN2eGtMYk1hQUFzVmdaRExCWU9YeU51?= =?utf-8?B?OGNibFgzMDAvMnVUWnZFUkplZXRNRThBVW5zZlNwR0JuemUrOXhvaVZGM2VK?= =?utf-8?B?N3o2Vy91aEs2SUdseDJnYzJKWEoxbStpeVFsS2c4OHdEdEt4RVlaaVJhRk5C?= =?utf-8?B?SEw0SjRHUlZ5VlBqbGxwMk9uM2F2bVNQQVVzWDBZZHVXUkpPRkxna1NDQWw5?= =?utf-8?B?YVNSMFFKVEpQU3VoWEViT0RnbEpqVk03RkFMU1FBYUh2Rzg3Tk81VWg5Q091?= =?utf-8?B?bkNBQWhiSUhVYlh0WFJqZ2NCdXMzWE0vV2tXaFFoODUxbFFxdmcxd2VqU0dC?= =?utf-8?B?T2dSQlIvUDAwNG9OaWV3MVpycUR1UzAwcHkwNFFOanU5TSswUTZoMjI5MlVX?= =?utf-8?B?VVdNdG91ZVFteS9MSlBQbVBqSjJJQVloZEdjSFVwQzZRZjZwRnp3ZisvRk41?= =?utf-8?B?NFdVWVQrd3k1Z1JrUGhEcUJqaGFWZHA4Sjcwa05LckJZb0xndng3Q2NwRXc0?= =?utf-8?B?Y3FQVnUzVEdyYU5aMnBmSDJtMlJuNDM5UGJvM0tKK2pSSFJma1c5MjRadzdz?= =?utf-8?B?eGNIWUlZZzgrNFRMRkd1cGpKUW5ZU0dZWnpsNFUzbCtCL2R2djRudC9aNk5F?= =?utf-8?B?Sk1FRFh6d0FUdXpKRFNwYW1xNmtxdFM0RVlhbEhxNThBYysvM2hzU0ZKRE9y?= =?utf-8?B?SDRhWTBKdHR5dU54N0NMRGFqK1MrREl4NVVkZE5PYjdXdXJFWjBleXJBSHYx?= =?utf-8?B?cks3U1ZlZzk3R21QekhYOEEyclZiL2Z3MDAvdXJnWS9jekdRQVVDNm1ZYTQ4?= =?utf-8?B?UGMwaWJDUjg5VWJlVXVZdmlOSjd3Zmw1bk1RMmVkOW5FcWY3bGN0cXNMaUJ3?= =?utf-8?B?bkU5ZnFINFQzd01vVjVBV0Z1QzVnM01xTjJKK3VMeHU5VkdqNkVNQVdoTGF0?= =?utf-8?B?T1ltcXdNbEZ2UUhmY05IUVJYQTFNTjRYL3IzazI5Z2xheTQxd3lvdjBrOUht?= =?utf-8?B?NlZaSTRnZDFFNlNTR1U1eVBkZlk1Qk9MYlNqNXU2eC8rZ0NSNjhWbkxZWnk0?= =?utf-8?B?QWphZjJxeTU1NUs1emJqdHQxOWJTU29MaG02UnY4VkVIWXFFa2JrbE5TNmxr?= =?utf-8?B?TnowWE03K3lQWXpqNnZIUG43a2FGd2JVL0hnZFd0TUNrSXJlK2x2S1R3SUIy?= =?utf-8?B?S2g1STN3M3NxbXJncFVBZnVIZXNNbTZ3SEZKUUlzbjJhekVDSUhMeW9YaWxO?= =?utf-8?Q?wE+hKoFVl2TbTW9pCwkTDieV2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c76555d3-84da-4622-aec0-08db98b9347f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 09:15:42.2094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9FqJ7nKLQu5ZUhT4sA/Xueg3fiPPxb/FUNFc92Enf1PQHrNcd8Y/M6lW9VVDMeg3VAUX/+YlfG96OxAsnf2bbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7604 On 09.08.2023 10:58, Simone Ballarin wrote: > Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin < > simone.ballarin@bugseng.com> ha scritto: > >> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline >> states: >> "A 'u' or 'U' suffix shall be applied to all integer constants that are >> represented in an unsigned type". >> >> These violations are caused by the missing "u" or "U" suffix in unsigned >> integer constants, such as: >> >> xen/arch/x86/hvm/hypercall.c:132.17-132.26 >> if ( (eax & 0x80000000) && is_viridian_domain(currd) ) >> >> If a rule is not met, changes are needed in order to achieve compliance. >> The patches in this series achieve compliance for MISRA C:2012 Rule 7.2 by >> adding the 'U' suffix to integers literals with unsigned type and also to >> other >> literals used in the same contexts or near violations, when their positive >> nature is immediately clear. The latter changes are done for the sake of >> uniformity. >> >> Gianluca Luparini (4): >> x86/vmx: address violations of MISRA C:2012 Rule 7.2 >> xen/vpci: address violations of MISRA C:2012 Rule 7.2 >> x86/viridian: address violations of MISRA C:2012 Rule 7.2 >> xen/x86: address violations of MISRA C:2012 Rule 7.2 >> >> xen/arch/x86/apic.c | 2 +- >> xen/arch/x86/cpu-policy.c | 18 +- >> xen/arch/x86/cpu/mcheck/mce-apei.c | 4 +- >> xen/arch/x86/cpu/vpmu_intel.c | 2 +- >> xen/arch/x86/cpuid.c | 8 +- >> xen/arch/x86/efi/efi-boot.h | 6 +- >> xen/arch/x86/extable.c | 2 +- >> xen/arch/x86/hvm/hypercall.c | 2 +- >> xen/arch/x86/hvm/pmtimer.c | 4 +- >> xen/arch/x86/hvm/stdvga.c | 50 +++--- >> xen/arch/x86/hvm/viridian/viridian.c | 2 +- >> xen/arch/x86/hvm/vlapic.c | 6 +- >> xen/arch/x86/hvm/vmx/vmcs.c | 6 +- >> xen/arch/x86/hvm/vmx/vvmx.c | 8 +- >> xen/arch/x86/include/asm/apicdef.h | 2 +- >> xen/arch/x86/include/asm/config.h | 2 +- >> xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 +-- >> xen/arch/x86/include/asm/hpet.h | 2 +- >> xen/arch/x86/include/asm/hvm/trace.h | 4 +- >> xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- >> xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 84 ++++----- >> xen/arch/x86/include/asm/hvm/vmx/vmx.h | 16 +- >> xen/arch/x86/include/asm/msi.h | 2 +- >> xen/arch/x86/include/asm/msr-index.h | 180 +++++++++---------- >> xen/arch/x86/include/asm/pci.h | 8 +- >> xen/arch/x86/include/asm/x86-defns.h | 24 +-- >> xen/arch/x86/percpu.c | 2 +- >> xen/arch/x86/psr.c | 2 +- >> xen/arch/x86/spec_ctrl.c | 8 +- >> xen/arch/x86/x86_64/pci.c | 2 +- >> xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- >> xen/drivers/vpci/msi.c | 2 +- >> xen/drivers/vpci/msix.c | 2 +- >> xen/drivers/vpci/vpci.c | 6 +- >> xen/lib/x86/cpuid.c | 8 +- >> xen/lib/x86/policy.c | 2 +- >> 36 files changed, 255 insertions(+), 255 deletions(-) >> >> -- >> 2.34.1 >> >> > Hi all, > the entire series has not received yet any feedback or Acked-by. > I would kindly ask if it is possible to have at least some feedback I did reply to patch 4 on July 27th. For patch 2, Roger is on PTO for another week and a half. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 09:42:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 09:42:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580810.909227 (Exim 4.92) (envelope-from ) id 1qTfhr-0008QQ-KZ; Wed, 09 Aug 2023 09:42:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580810.909227; Wed, 09 Aug 2023 09:42:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfhr-0008QJ-I3; Wed, 09 Aug 2023 09:42:19 +0000 Received: by outflank-mailman (input) for mailman id 580810; Wed, 09 Aug 2023 09:42:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfhq-0008QD-B9 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 09:42:18 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 06650817-3699-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 11:42:16 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B351921836; Wed, 9 Aug 2023 09:42:15 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 93132133B5; Wed, 9 Aug 2023 09:42:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kCURIndf02RZGAAAMHmgww (envelope-from ); Wed, 09 Aug 2023 09:42:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06650817-3699-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691574135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aJf+gy5hzHlvoLiAoq6+3TVdJV6SqJynVwap+TW+0E4=; b=dVXwxNLntQlmyAP45Lf67JVbZsy4QL8ZM3tazkZVWSsFn5wRg49XYzP8Vmrki+vpfw/9BN z38iVswDxyMy/FUxmW9nci/ZOzybRPeXUKS4u6A78iSlZKXWHxXZICgQXaerF4i8vrEwW7 3hUSccT+GYF9C0shZj3IZMa1LgZDxvs= Message-ID: <6300d166-621e-83bf-0ac2-70ea89b75492@suse.com> Date: Wed, 9 Aug 2023 11:42:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/public: fix flexible array definitions Content-Language: en-US To: Jan Beulich , Andrew Cooper Cc: xen-devel@lists.xenproject.org References: <20230725135557.20518-1-jgross@suse.com> <5ba647c0-fc74-595e-5fe3-658f4662f16e@suse.com> <6cd0c3e2-ecae-971a-5c86-cf408591bee9@suse.com> From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: <6cd0c3e2-ecae-971a-5c86-cf408591bee9@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0nDYHTuWUPQqKRfboFyLpVSh" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0nDYHTuWUPQqKRfboFyLpVSh Content-Type: multipart/mixed; boundary="------------UEuCEY2Du6AFMDYN7ex7sBPj"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Andrew Cooper Cc: xen-devel@lists.xenproject.org Message-ID: <6300d166-621e-83bf-0ac2-70ea89b75492@suse.com> Subject: Re: [PATCH] xen/public: fix flexible array definitions References: <20230725135557.20518-1-jgross@suse.com> <5ba647c0-fc74-595e-5fe3-658f4662f16e@suse.com> <6cd0c3e2-ecae-971a-5c86-cf408591bee9@suse.com> In-Reply-To: <6cd0c3e2-ecae-971a-5c86-cf408591bee9@suse.com> --------------UEuCEY2Du6AFMDYN7ex7sBPj Content-Type: multipart/mixed; boundary="------------hmWWbqZGtNCbE2iju17w3Kpw" --------------hmWWbqZGtNCbE2iju17w3Kpw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjYuMDcuMjMgMDc6NTIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNS4wNy4yMDIz IDE4OjU5LCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gT24gMjUvMDcvMjAyMyA1OjE2IHBt LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAyNS4wNy4yMDIzIDE1OjU1LCBKdWVyZ2Vu IEdyb3NzIHdyb3RlOg0KPj4+PiBGbGV4aWJsZSBhcnJheXMgaW4gcHVibGljIGhlYWRlcnMg Y2FuIGJlIHByb2JsZW1hdGljIHdpdGggc29tZQ0KPj4+PiBjb21waWxlcnMuDQo+Pj4+DQo+ Pj4+IFJlcGxhY2UgdGhlbSB3aXRoIGFycltYRU5fRkxFWF9BUlJBWV9ESU1dIGluIG9yZGVy IHRvIGF2b2lkIGNvbXBpbGF0aW9uDQo+Pj4+IGVycm9ycy4NCj4+Pj4NCj4+Pj4gVGhpcyBp bmNsdWRlcyBhcnJheXMgZGVmaW5lZCBhcyAiYXJyWzFdIiwgYXMgc2VlbiB3aXRoIGEgcmVj ZW50IExpbnV4DQo+Pj4+IGtlcm5lbCBbMV0uDQo+Pj4+DQo+Pj4+IFsxXTogaHR0cHM6Ly9i dWd6aWxsYS5rZXJuZWwub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTc2OTMNCj4+Pj4NCj4+Pj4g U2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+IEkg dGhpbmsgd2UgbmVlZCB0byBiZSBjYXJlZnVsIGhlcmU6IFdoYXQgaWYgc29tZW9uZSBzb21l d2hlcmUgYXBwbGllcw0KPj4+IHNpemVvZigpIHRvIGFueSBvZiB0aGUgdHlwZXMgeW91IGFs dGVyPw0KPj4NCj4+IFRoZW4gdGhlIGNvZGUgd2FzIG1vc3QgbGlrZWx5IHdyb25nIGFscmVh ZHkuDQo+IA0KPiBUaGF0J3MgcG9zc2libGUgdG8ganVkZ2Ugb25seSB3aGVuIHNlZWluZyB0 aGUgY29kZSBpbiBxdWVzdGlvbi4NCj4gDQo+Pj4gICBUaGUgcmVzdWx0aW5nIHZhbHVlIHdv dWxkDQo+Pj4gY2hhbmdlIHdpdGggdGhlIGNoYW5nZXMgeW91IHByb3Bvc2UsIHdoaWNoIHdl IGNhbm5vdCBhbGxvdyB0byBoYXBwZW4NCj4+PiBpbiBhIHN0YWJsZSBpbnRlcmZhY2UuIFRo ZXJlZm9yZSBpbW8gaXQgY2FuIG9ubHkgYmUgYW4gb3B0LWluIGZlYXR1cmUNCj4+PiB0byBo YXZlIHRoZXNlIGFycmF5cyBubyBsb25nZXIgYmUgb25lLWVsZW1lbnQgb25lcy4NCj4+DQo+ PiBJIGRvbid0IGNvbnNpZGVyIHRoaXMgYW4gaXNzdWUuDQo+Pg0KPj4gSWYgcGVvcGxlIHRh a2UgYW4gdXBkYXRlIHRvIHRoZSBoZWFkZXJzIGFuZCB0aGVpciBjb2RlIHN0b3BzIGNvbXBp bGluZywNCj4+IHRoZW4gb2YgY291cnNlIHRoZXkgZml4IHRoZSBjb21waWxhdGlvbiBpc3N1 ZS7CoCBUaGF0J3Mgbm9ybWFsLg0KPiANCj4gVGhlIGNvZGUgbWF5IGNvbnRpbnVlIHRvIGNv bXBpbGUgZmluZSwgYW5kIGV2ZW4gYXBwZWFyIHRvIHdvcmsgaW5pdGlhbGx5Lg0KPiANCj4+ IEl0J3MgdW5yZWFzb25hYmxlIHRvIHRha2Ugb3B0LWluIGZlYXR1cmVzIHRvIGEgc2V0IG9m IGhlYWRlcnMgaW50ZW5kZWQNCj4+IHRvIGJlIHZlbmRvcmVkIGluIHRoZSBmaXJzdCBwbGFj ZSwgdG8gd29yayBhcm91bmQgYSBjb3JuZXIgY2FzZSB0aGF0J3MNCj4+IGxpa2VseSBidWdn eSBhbHJlYWR5Lg0KPiANCj4gVGhlIG9yaWdpbmFsIGludGVudGlvbiBjbGVhcmx5IHdhcyB0 byBhbGxvdyB1c2Ugb2YgdGhlc2UgaGVhZGVycyBhcyBpcy4NCj4gQW55d2F5LCBJJ3ZlIHZv aWNlZCBteSB2aWV3LCB5ZXQgaWYgdGhlcmUgYXJlIGVub3VnaCBwZW9wbGUgYWdyZWVpbmcN Cj4gd2l0aCB5b3UsIHRoZW4gc28gYmUgaXQuDQoNCkFueSBmdXJ0aGVyIHRob3VnaHRzPw0K DQpJIGhhdmUgY2hlY2tlZCB0aGUgY29kZSBpbiB0aGUgTGludXgga2VybmVsIG1lYW53aGls ZS4gVGhlcmUgc2hvdWxkIGJlIG5vDQpmYWxsb3V0IHJlc3VsdGluZyBmcm9tIHRoaXMgY2hh bmdlLCBidXQgSSB0aGluayB0aGVyZSBhcmUgc29tZSB1c2VyIG1vZGUNCmJhY2tlbmRzIG91 dHNpZGUgb2YgcWVtdSB3aGljaCBhcmUgcHJvYmFibHkgdXNpbmcgYWZmZWN0ZWQgc3RydWN0 cy4NCg0KDQpKdWVyZ2VuDQo= --------------hmWWbqZGtNCbE2iju17w3Kpw Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------hmWWbqZGtNCbE2iju17w3Kpw-- --------------UEuCEY2Du6AFMDYN7ex7sBPj-- --------------0nDYHTuWUPQqKRfboFyLpVSh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTTX3cFAwAAAAAACgkQsN6d1ii/Ey9d Ugf3YTXXAVakgcWvErp4nV8F8vW9Cfa2idmRis5yDuCqVZSN+Xf/oTpyg2lOzmVti7tDQtirsiZu D3EgofzOF6Y3xwdf9m5NaaynyB55LQPpYTC8G7ZLIHFlFTg3LKoTxTfUKKnjXvVRkzloVOxPx802 684gDeS3x3NDZOoH6EL5QgXoIH4Q+BwCPTC1Bh3kfWfUDcQPcrazVQzQxDULBWUEdj1PPQFKN9/3 QM51Tcd93YDsie0fBNR0VjhtcXK1P1VX/2pykkVGSEs+gLQtmsQsYxjJQWPl544t2z7NbJQN9pn5 1KJSTfqHjfk61gwIWKRaQfPcbas5EoG82Db6EIkh =cM8Q -----END PGP SIGNATURE----- --------------0nDYHTuWUPQqKRfboFyLpVSh-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 09:44:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 09:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580815.909238 (Exim 4.92) (envelope-from ) id 1qTfk8-0000YN-23; Wed, 09 Aug 2023 09:44:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580815.909238; Wed, 09 Aug 2023 09:44:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfk7-0000YG-U5; Wed, 09 Aug 2023 09:44:39 +0000 Received: by outflank-mailman (input) for mailman id 580815; Wed, 09 Aug 2023 09:44:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfk6-0000Y8-ML for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 09:44:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfk3-00044a-Ug; Wed, 09 Aug 2023 09:44:35 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTfk3-00078e-Jf; Wed, 09 Aug 2023 09:44:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=D3TUk0fVtuJ/htEceC83j6Ej9T9H0oui2/i6dkCkfgo=; b=kYcOaJ7urvmOyu6YfKEd5a5TNh 5t0ZLDDWkQc+UbDoCAl+sBFFxd9mZZR60NjbsL1vJAI7KtGkp0kKXZ7zpKTRDtxRPjBACnb+bgTy4 jW5rMEKyj3ngeTT4W1XUu76GugYKAKkOpLdJaHnho+HimlLMAu4npaKNRgXTVqVaxtCE=; Message-ID: <7e578cfd-b74c-45d6-9b90-9963cff2c8e3@xen.org> Date: Wed, 9 Aug 2023 10:44:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 4/6] capabilities: introduce console io as a domain capability Content-Language: en-GB To: "Daniel P. Smith" , Volodymyr Babchuk , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-5-dpsmith@apertussolutions.com> <8951f722-6949-b2b5-f6d4-2d515f085cde@xen.org> <7a10af10-27c7-257e-9564-2716c67bb400@apertussolutions.com> From: Julien Grall In-Reply-To: <7a10af10-27c7-257e-9564-2716c67bb400@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Daniel, On 08/08/2023 23:49, Daniel P. Smith wrote: > On 8/3/23 17:03, Julien Grall wrote: >> On 01/08/2023 21:20, Daniel P. Smith wrote: >>> The field `is_console` suggests that the field represents a state of >>> being or >>> posession, not that it reflects the privilege to access the console. >>> In this >>> patch the field is renamed to capabilities to encapsulate the >>> capabilities a >>> domain has been granted. The first capability being the ability to >>> read/write >>> the Xen console. >>> >>> Signed-off-by: Daniel P. Smith >>> --- >>>   xen/arch/arm/domain_build.c |  4 +++- >>>   xen/include/xen/sched.h     | 25 +++++++++++++++++++++++-- >>>   xen/include/xsm/dummy.h     |  2 +- >>>   3 files changed, 27 insertions(+), 4 deletions(-) >>> >>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >>> index 51b4daefe1..ad7432b029 100644 >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -4076,7 +4076,9 @@ void __init create_domUs(void) >>>               panic("Error creating domain %s (rc = %ld)\n", >>>                     dt_node_name(node), PTR_ERR(d)); >>> -        d->is_console = true; >>> +        if ( ! domain_set_cap(d, CAP_CONSOLE_IO) ) >> >> Coding style: We don't usually add a space after '!'. > > Ack. > >>> +            printk("failed setting console_io on %pd\n", d); >> >> I find a bit odd that we would continue even if the cap cannot be set. >> Can you clarify? > > This is the construction of a domU, so the system is very much capable > of coming up and reviewing the hypervisor messages from dom0 to discover > the issue. I am hard pressed to believe the hypervisor should be > panicked because the domU is not allowed to use the hypervisor's console. I understand the system may be able to boot. However, the problem is that it may take a while to discover that the console is not working properly (the more if you only use it for error logging). So on Arm, we have so always decided to fail early rather than late in order to help debugging. So I would rather not change the behavior even if this is "just" for the console. If you expect the console to be disabled, then we should provide a property in the Device-Tree to select/deselect. It should not be hidden. > > g>> + >>>           dt_device_set_used_by(node, d->domain_id); >>>           rc = construct_domU(d, node); >>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >>> index ec0f9baff6..b04fbe0565 100644 >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -472,8 +472,8 @@ struct domain >>>   #define ROLE_HARDWARE_DOMAIN   (1U<<2) >>>   #define ROLE_XENSTORE_DOMAIN   (1U<<3) >>>       uint8_t          role; >>> -    /* Can this guest access the Xen console? */ >>> -    bool             is_console; >>> +#define CAP_CONSOLE_IO  (1U<<0) >> Coding style: Space before and after <<. > > Ack. > >>> +    uint8_t          capabilities; >>>       /* Is this guest being debugged by dom0? */ >>>       bool             debugger_attached; >>>       /* >>> @@ -1146,6 +1146,27 @@ static always_inline bool is_hvm_vcpu(const >>> struct vcpu *v) >>>       return is_hvm_domain(v->domain); >>>   } >>> +static always_inline bool domain_has_cap( >>> +    const struct domain *d, uint8_t cap) >> >> Coding style: We don't usually wrap the arguments this way. See >> domain_create() for an example. > > I was informed it was[1], also, please see next_domain_in_cpupool() > amongst many others further below. The unwritten coding style strike again... I am not sure where the agreement comes from. At least on Arm, we have been using the first version in that thread and if it can't be wrapped to 80 characters, then move the "static inline void " on its own line. The advantage with the Arm approach is that parameters are always indented the same way. Anyway, the way you wrote is not my personal preference but I am also not up to bikeshed too much on it. Hopefully this sort of style discussion will be resolved with clang-format. [...] > >> Also, do you expect the cap to be set only when the domain is created? >> If not, would you prevent potentially concurrent update to >> d->capabilities? > > Currently the only means being devise to set this is via hyperlaunch > domain creation. If a domctl op was added to be able to manipulate the > caps, then yes a lock on the domain would be advised to block. Loking at patch #6, you are using domctl there. > With that > said, if we switch over to CAP_CTRL/HW, then it might be good to grab a > lock on the domain for the late hardware domain case. Are you planning to clear the caps? If not, then using set_bit() and test_bit() should be enough. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 09:57:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 09:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580822.909248 (Exim 4.92) (envelope-from ) id 1qTfwN-00027O-4H; Wed, 09 Aug 2023 09:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580822.909248; Wed, 09 Aug 2023 09:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfwN-00027H-15; Wed, 09 Aug 2023 09:57:19 +0000 Received: by outflank-mailman (input) for mailman id 580822; Wed, 09 Aug 2023 09:57:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfwL-00027B-TE for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 09:57:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTfwJ-0004Pf-EM; Wed, 09 Aug 2023 09:57:15 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTfwJ-0007Xw-57; Wed, 09 Aug 2023 09:57:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7XtZtEZ0xxi5mkadlbZLobdao4529DCHbuutS7ckqi8=; b=U8IoLCHLqtOjHxoSA16platkms VQjmM0a7m2hdOAfOlsgqH+stjtMR6CU4fwwG9Vo8pMsP7iprhlzbpk+cbavoBkF9omreAuJCi/A9O nAgFJ9uKTb/rpIW3++XOuaYKThROZGp8e0PiDsH/irt6RQoIMEfCjY9YvUtlEtjpsVmM=; Message-ID: Date: Wed, 9 Aug 2023 10:57:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 6/6] capabilities: convert attach debugger into a capability Content-Language: en-GB To: "Daniel P. Smith" , Wei Liu , xen-devel@lists.xenproject.org Cc: Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Stefano Stabellini , Jun Nakajima , Kevin Tian References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-7-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20230801202006.20322-7-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Daniel, On 01/08/2023 21:20, Daniel P. Smith wrote: > Expresses the ability to attach a debugger as a capability that a domain can be > provisioned. > > Signed-off-by: Daniel P. Smith > --- > xen/arch/x86/hvm/svm/svm.c | 8 ++++---- > xen/arch/x86/hvm/vmx/realmode.c | 2 +- > xen/arch/x86/hvm/vmx/vmcs.c | 2 +- > xen/arch/x86/hvm/vmx/vmx.c | 10 +++++----- > xen/arch/x86/traps.c | 6 ++++-- > xen/common/domctl.c | 6 ++++-- > xen/include/xen/sched.h | 9 ++++++--- > 7 files changed, 25 insertions(+), 18 deletions(-) > > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c > index 27170213ae..9872804d39 100644 > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -999,7 +999,7 @@ static void noreturn cf_check svm_do_resume(void) > { > struct vcpu *v = current; > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > - bool debug_state = (v->domain->debugger_attached || > + bool debug_state = (domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) || > v->domain->arch.monitor.software_breakpoint_enabled || > v->domain->arch.monitor.debug_exception_enabled); > bool_t vcpu_guestmode = 0; > @@ -1335,7 +1335,7 @@ static void cf_check svm_inject_event(const struct x86_event *event) > } > /* fall through */ > case X86_EXC_BP: > - if ( curr->domain->debugger_attached ) > + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) > { > /* Debug/Int3: Trap to debugger. */ > domain_pause_for_debugger(); > @@ -2732,7 +2732,7 @@ void svm_vmexit_handler(void) > > case VMEXIT_ICEBP: > case VMEXIT_EXCEPTION_DB: > - if ( !v->domain->debugger_attached ) > + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > unsigned int trap_type; > > @@ -2769,7 +2769,7 @@ void svm_vmexit_handler(void) > if ( insn_len == 0 ) > break; > > - if ( v->domain->debugger_attached ) > + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > /* AMD Vol2, 15.11: INT3, INTO, BOUND intercepts do not update RIP. */ > __update_guest_eip(regs, insn_len); > diff --git a/xen/arch/x86/hvm/vmx/realmode.c b/xen/arch/x86/hvm/vmx/realmode.c > index ff44ddcfa6..f761026a9d 100644 > --- a/xen/arch/x86/hvm/vmx/realmode.c > +++ b/xen/arch/x86/hvm/vmx/realmode.c > @@ -121,7 +121,7 @@ void vmx_realmode_emulate_one(struct hvm_emulate_ctxt *hvmemul_ctxt) > > if ( rc == X86EMUL_EXCEPTION ) > { > - if ( unlikely(curr->domain->debugger_attached) && > + if ( unlikely(domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH)) && > ((hvmemul_ctxt->ctxt.event.vector == X86_EXC_DB) || > (hvmemul_ctxt->ctxt.event.vector == X86_EXC_BP)) ) > { > diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c > index 13719cc923..9474869018 100644 > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -1912,7 +1912,7 @@ void cf_check vmx_do_resume(void) > hvm_asid_flush_vcpu(v); > } > > - debug_state = v->domain->debugger_attached > + debug_state = domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) > || v->domain->arch.monitor.software_breakpoint_enabled > || v->domain->arch.monitor.singlestep_enabled; > > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > index 7ec44018d4..5069e3cbf3 100644 > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -2041,7 +2041,7 @@ static void cf_check vmx_inject_event(const struct x86_event *event) > break; > /* fall through */ > case X86_EXC_BP: > - if ( curr->domain->debugger_attached ) > + if ( domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) > { > /* Debug/Int3: Trap to debugger. */ > domain_pause_for_debugger(); > @@ -2121,7 +2121,7 @@ static void cf_check vmx_set_info_guest(struct vcpu *v) > * immediately vmexit and hence make no progress. > */ > __vmread(GUEST_INTERRUPTIBILITY_INFO, &intr_shadow); > - if ( v->domain->debugger_attached && > + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) && > (v->arch.user_regs.eflags & X86_EFLAGS_TF) && > (intr_shadow & VMX_INTR_SHADOW_STI) ) > { > @@ -4283,7 +4283,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > } > } > > - if ( !v->domain->debugger_attached ) > + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > unsigned long insn_len = 0; > int rc; > @@ -4307,7 +4307,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > break; > case X86_EXC_BP: > HVMTRACE_1D(TRAP, vector); > - if ( !v->domain->debugger_attached ) > + if ( !domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > unsigned long insn_len; > int rc; > @@ -4647,7 +4647,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > HVM_MONITOR_SINGLESTEP_BREAKPOINT, > 0, 0, 0); > > - if ( v->domain->debugger_attached ) > + if ( domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > domain_pause_for_debugger(); > } > > diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c > index 4229bda159..041ced35ea 100644 > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -1214,7 +1214,8 @@ void do_int3(struct cpu_user_regs *regs) > return; > } > > - if ( guest_kernel_mode(curr, regs) && curr->domain->debugger_attached ) > + if ( guest_kernel_mode(curr, regs) && > + domain_has_cap(curr->domain, CAP_DEBUGGER_ATTACH) ) > { > curr->arch.gdbsx_vcpu_event = X86_EXC_BP; > domain_pause_for_debugger(); > @@ -1995,7 +1996,8 @@ void do_debug(struct cpu_user_regs *regs) > v->arch.dr6 |= (dr6 & ~X86_DR6_DEFAULT); > v->arch.dr6 &= (dr6 | ~X86_DR6_DEFAULT); > > - if ( guest_kernel_mode(v, regs) && v->domain->debugger_attached ) > + if ( guest_kernel_mode(v, regs) && > + domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) ) > { > domain_pause_for_debugger(); > return; > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 505e29c0dc..895ddf0600 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -99,7 +99,8 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) > ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying : 0) | > (d->is_shut_down ? XEN_DOMINF_shutdown : 0) | > (d->controller_pause_count > 0 ? XEN_DOMINF_paused : 0) | > - (d->debugger_attached ? XEN_DOMINF_debugged : 0) | > + (domain_has_cap(d, CAP_DEBUGGER_ATTACH) ? > + XEN_DOMINF_debugged : 0) | > (is_xenstore_domain(d) ? XEN_DOMINF_xs_domain : 0) | > (is_hvm_domain(d) ? XEN_DOMINF_hvm_guest : 0) | > d->shutdown_code << XEN_DOMINF_shutdownshift; > @@ -643,7 +644,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > else > { > domain_pause(d); > - d->debugger_attached = !!op->u.setdebugging.enable; > + if ( !!op->u.setdebugging.enable ) > + domain_set_cap(d, CAP_DEBUGGER_ATTACH); From my understanding, before this patch, it was possible to detach the debugger. But now, you don't seem to allow clearing. Is it intended? If so, can you explain why? (The outcome would want to be written down in the commit message). > domain_unpause(d); /* causes guest to latch new status */ > } > break; > diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > index ebfe65cd73..47eadb5008 100644 > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -474,9 +474,8 @@ struct domain > uint8_t role; > #define CAP_CONSOLE_IO (1U<<0) > #define CAP_DISABLE_CPU_FAULT (1U<<1) > - uint8_t capabilities; > - /* Is this guest being debugged by dom0? */ > - bool debugger_attached; > +#define CAP_DEBUGGER_ATTACH (1U<<2) > + uint16_t capabilities; > /* > * Set to true at the very end of domain creation, when the domain is > * unpaused for the first time by the systemcontroller. > @@ -1166,6 +1165,10 @@ static always_inline bool domain_set_cap( > if ( is_pv_domain(d) && is_control_domain(d) ) > d->capabilities |= cap; > break; > + case CAP_DEBUGGER_ATTACH: > + if ( !is_control_domain(d) ) This seems to be a new restriction. Can you explain why? > + d->capabilities |= cap; > + break; > default: > return false; > } Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:33:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580830.909268 (Exim 4.92) (envelope-from ) id 1qTgVi-0006sp-7S; Wed, 09 Aug 2023 10:33:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580830.909268; Wed, 09 Aug 2023 10:33:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVi-0006si-4i; Wed, 09 Aug 2023 10:33:50 +0000 Received: by outflank-mailman (input) for mailman id 580830; Wed, 09 Aug 2023 10:33:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVg-0006oL-Is for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:33:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVg-0005Ho-6p; Wed, 09 Aug 2023 10:33:48 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgVf-0000jc-VN; Wed, 09 Aug 2023 10:33:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=WDE+FPlIuV/hN9LV2qapinnwY81PAynIDFvx+oUY3q0=; b=2/HvtZVAIIxaq4laM3RlmqP9u/ KlqMLwy4JjvxKWssqvOY5gbS2KIst6EDtSw8xcXVYDlPTEL/xmqKkpjEFYiny8Z6dCEANSSkIDUnr D4P7cDFz0lktOvORmbw1TtcPHWUg1x8y14V4Eza4I+6sgmulDoiXTQ1gbqypVd9Yg4Yo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 1/2] tools/libs: light: Remove the variable 'domainid' do_pci_remove() Date: Wed, 9 Aug 2023 11:33:04 +0100 Message-Id: <20230809103305.30561-2-julien@xen.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230809103305.30561-1-julien@xen.org> References: <20230809103305.30561-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall The function do_pci_remove() has two local variables 'domid' and 'domainid' containing the same value. Looking at the history, until 2cf3b50dcd8b ("libxl_pci: Use libxl__ao_device with pci_remove") the two variables may have different value when using a stubdomain. As this is not the case now, remove 'domainid'. This will reduce the confusion between the two variables. Note that there are other places in libxl_pci.c which are using the two confusing names within the same function. They are left unchanged for now. No functional changes intented. Signed-off-by: Julien Grall --- tools/libs/light/libxl_pci.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 27d9dbff2522..7f5f170e6eb0 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -1953,8 +1953,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) libxl_domain_type type = libxl__domain_type(gc, domid); libxl_device_pci *pci = &prs->pci; int rc, num; - uint32_t domainid = domid; - pcis = libxl_device_pci_list(ctx, domid, &num); if (!pcis) { rc = ERROR_FAIL; @@ -1966,7 +1964,7 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) rc = ERROR_INVAL; if (!attached) { - LOGD(ERROR, domainid, "PCI device not attached to this domain"); + LOGD(ERROR, domid, "PCI device not attached to this domain"); goto out_fail; } @@ -2000,7 +1998,7 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) int i; if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); goto skip1; } for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { @@ -2011,7 +2009,7 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) if (flags & PCI_BAR_IO) { rc = xc_domain_ioport_permission(ctx->xch, domid, start, size, 0); if (rc < 0) - LOGED(ERROR, domainid, + LOGED(ERROR, domid, "xc_domain_ioport_permission error 0x%x/0x%x", start, size); @@ -2019,7 +2017,7 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) rc = xc_domain_iomem_permission(ctx->xch, domid, start>>XC_PAGE_SHIFT, (size+(XC_PAGE_SIZE-1))>>XC_PAGE_SHIFT, 0); if (rc < 0) - LOGED(ERROR, domainid, + LOGED(ERROR, domid, "xc_domain_iomem_permission error 0x%x/0x%x", start, size); @@ -2034,17 +2032,17 @@ skip1: pci->bus, pci->dev, pci->func); f = fopen(sysfs_path, "r"); if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); goto skip_irq; } if ((fscanf(f, "%u", &irq) == 1) && irq) { rc = xc_physdev_unmap_pirq(ctx->xch, domid, irq); if (rc < 0) { - LOGED(ERROR, domainid, "xc_physdev_unmap_pirq irq=%d", irq); + LOGED(ERROR, domid, "xc_physdev_unmap_pirq irq=%d", irq); } rc = xc_domain_irq_permission(ctx->xch, domid, irq, 0); if (rc < 0) { - LOGED(ERROR, domainid, "xc_domain_irq_permission irq=%d", irq); + LOGED(ERROR, domid, "xc_domain_irq_permission irq=%d", irq); } } fclose(f); -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:33:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580829.909257 (Exim 4.92) (envelope-from ) id 1qTgVg-0006dv-0q; Wed, 09 Aug 2023 10:33:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580829.909257; Wed, 09 Aug 2023 10:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVf-0006do-UL; Wed, 09 Aug 2023 10:33:47 +0000 Received: by outflank-mailman (input) for mailman id 580829; Wed, 09 Aug 2023 10:33:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVe-0006di-4v for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:33:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVd-0005GD-Rr; Wed, 09 Aug 2023 10:33:45 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgVd-0000jc-Iu; Wed, 09 Aug 2023 10:33:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=gqsPc6Dj+x+vL8iP4OcWHmHCsnEFSblX9PTtCumU6Hw=; b=Lmrh2S AJX525aTBZP1t4wkTfJhtb1SeoM1OvjLmrf1khQRebh3cm/e3F+pkbDebXAD8UFLvwaCNqiHy8GJm f5RogIeW6hzfNHq6+milDX4w/JMoxrme4xLlFqe1+Zqi/2tQsI/+vMnMECk8kDvFQwFDWMHUpICXO 3tvmV6LPVC4=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 0/2] Revoke IOMEM/IO port/IRQ permissions on PCI detach for HVM guest Date: Wed, 9 Aug 2023 11:33:03 +0100 Message-Id: <20230809103305.30561-1-julien@xen.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, This small series is looking to revoke properly IOMEM/IO port/IRQ permissions on PCI detach for HVM guest. For more details, see patch #2. Cheers, Julien Grall (2): tools/libs: light: Remove the variable 'domainid' do_pci_remove() tools/light: Revoke permissions when a PCI detach for HVM domain tools/libs/light/libxl_pci.c | 146 +++++++++++++++++++---------------- 1 file changed, 81 insertions(+), 65 deletions(-) -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:33:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:33:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580831.909278 (Exim 4.92) (envelope-from ) id 1qTgVj-00077v-Eg; Wed, 09 Aug 2023 10:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580831.909278; Wed, 09 Aug 2023 10:33:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVj-00077o-Bf; Wed, 09 Aug 2023 10:33:51 +0000 Received: by outflank-mailman (input) for mailman id 580831; Wed, 09 Aug 2023 10:33:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVi-0006sd-2B for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:33:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgVh-0005I9-Tn; Wed, 09 Aug 2023 10:33:49 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgVh-0000jc-Lk; Wed, 09 Aug 2023 10:33:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=MdXl/LIdvThA4/9huGT3jC+CrkA+9dM8EtHZn3fXDBQ=; b=0QjX//y0RAiMGmUeH+NGDbojgD frnXw4yz11KsytPMO53DMTb+n0idG8h5Neec06evTsgzcwrXm6QAIO3QRf4UYrTTc65xlmM9X63rl H80IQXc239uajd++L9zxnjag4puAEONZaY9ibGihVgtKumIzErBfFjGZwA6qbX64tJHg=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain Date: Wed, 9 Aug 2023 11:33:05 +0100 Message-Id: <20230809103305.30561-3-julien@xen.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230809103305.30561-1-julien@xen.org> References: <20230809103305.30561-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Currently, libxl will grant IOMEM, I/O port and IRQ permissions when a PCI is attached (see pci_add_dm_done()) for all domain types. However, the permissions are only revoked for non-HVM domain (see do_pci_remove()). This means that HVM domains will be left with extra permissions. While this look bad on the paper, the IRQ permissions should be revoked when the Device Model call xc_physdev_unmap_pirq() and such domain cannot directly mapped I/O port and IOMEM regions. Instead, this has to be done by a Device Model. The Device Model can only run in dom0 or PV stubdomain (upstream libxl doesn't have support for HVM/PVH stubdomain). For PV/PVH stubdomain, the permission are properly revoked, so there is no security concern. This leaves dom0. There are two cases: 1) Privileged: Anyone gaining access to the Device Model would already have large control on the host. 2) Deprivileged: PCI passthrough require PHYSDEV operations which are not accessible when the Device Model is restricted. So overall, it is believed that the extra permissions cannot be exploited. Rework the code so the permissions are all removed for HVM domains. This needs to happen after the QEMU has detached the device. So the revocation is now moved in a separate function which is called from pci_remove_detached(). Signed-off-by: Julien Grall --- TODO: I am getting a bit confused with the async work in libxl. I am not entirely sure whether pci_remove_detached() is the correct place to revoke. TODO: For HVM, we are now getting the following error on detach: libxl: error: libxl_pci.c:2009:pci_revoke_permissions: Domain 3:xc_physdev_unmap_pirq irq=23: Invalid argument This is because the IRQ was unmapped by QEMU. It doesn't feel right to skip the call. So maybe we can ignore the error? --- tools/libs/light/libxl_pci.c | 142 ++++++++++++++++++++--------------- 1 file changed, 80 insertions(+), 62 deletions(-) diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 7f5f170e6eb0..f5a4b88eb2c0 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -1943,6 +1943,79 @@ static void pci_remove_stubdom_done(libxl__egc *egc, static void pci_remove_done(libxl__egc *egc, pci_remove_state *prs, int rc); +static void pci_revoke_permissions(libxl__egc *egc, pci_remove_state *prs) +{ + STATE_AO_GC(prs->aodev->ao); + libxl_ctx *ctx = libxl__gc_owner(gc); + const libxl_device_pci *pci = &prs->pci; + const char *sysfs_path; + uint32_t domid = prs->domid; + FILE *f; + unsigned int start = 0, end = 0, flags = 0, size = 0; + int irq = 0; + int i, rc; + + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", + pci->domain, pci->bus, pci->dev, pci->func); + + f = fopen(sysfs_path, "r"); + if (f == NULL) { + LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); + goto skip_bar; + } + + for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { + if (fscanf(f, "0x%x 0x%x 0x%x\n", &start, &end, &flags) != 3) + continue; + size = end - start + 1; + if (start) { + if (flags & PCI_BAR_IO) { + rc = xc_domain_ioport_permission(ctx->xch, domid, start, size, 0); + if (rc < 0) + LOGED(ERROR, domid, + "xc_domain_ioport_permission error 0x%x/0x%x", + start, + size); + } else { + rc = xc_domain_iomem_permission(ctx->xch, domid, start>>XC_PAGE_SHIFT, + (size+(XC_PAGE_SIZE-1))>>XC_PAGE_SHIFT, 0); + if (rc < 0) + LOGED(ERROR, domid, + "xc_domain_iomem_permission error 0x%x/0x%x", + start, + size); + } + } + } + fclose(f); + +skip_bar: + if (!pci_supp_legacy_irq()) + return; + + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, + pci->bus, pci->dev, pci->func); + + f = fopen(sysfs_path, "r"); + if (f == NULL) { + LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); + return; + } + + if ((fscanf(f, "%u", &irq) == 1) && irq) { + rc = xc_physdev_unmap_pirq(ctx->xch, domid, irq); + if (rc < 0) { + LOGED(ERROR, domid, "xc_physdev_unmap_pirq irq=%d", irq); + } + rc = xc_domain_irq_permission(ctx->xch, domid, irq, 0); + if (rc < 0) { + LOGED(ERROR, domid, "xc_domain_irq_permission irq=%d", irq); + } + } + + fclose(f); +} + static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) { STATE_AO_GC(prs->aodev->ao); @@ -1968,7 +2041,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) goto out_fail; } - rc = ERROR_FAIL; if (type == LIBXL_DOMAIN_TYPE_HVM) { prs->hvm = true; switch (libxl__device_model_version_running(gc, domid)) { @@ -1980,75 +2052,19 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) prs->xswait.timeout_ms = LIBXL_DEVICE_MODEL_START_TIMEOUT * 1000; prs->xswait.callback = pci_remove_qemu_trad_watch_state_cb; rc = libxl__xswait_start(gc, &prs->xswait); - if (rc) goto out_fail; - return; + if (!rc) return; + break; case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN: pci_remove_qmp_device_del(egc, prs); /* must be last */ return; default: rc = ERROR_INVAL; - goto out_fail; + break; } } else { - char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain, - pci->bus, pci->dev, pci->func); - FILE *f = fopen(sysfs_path, "r"); - unsigned int start = 0, end = 0, flags = 0, size = 0; - int irq = 0; - int i; - - if (f == NULL) { - LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); - goto skip1; - } - for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { - if (fscanf(f, "0x%x 0x%x 0x%x\n", &start, &end, &flags) != 3) - continue; - size = end - start + 1; - if (start) { - if (flags & PCI_BAR_IO) { - rc = xc_domain_ioport_permission(ctx->xch, domid, start, size, 0); - if (rc < 0) - LOGED(ERROR, domid, - "xc_domain_ioport_permission error 0x%x/0x%x", - start, - size); - } else { - rc = xc_domain_iomem_permission(ctx->xch, domid, start>>XC_PAGE_SHIFT, - (size+(XC_PAGE_SIZE-1))>>XC_PAGE_SHIFT, 0); - if (rc < 0) - LOGED(ERROR, domid, - "xc_domain_iomem_permission error 0x%x/0x%x", - start, - size); - } - } - } - fclose(f); -skip1: - if (!pci_supp_legacy_irq()) - goto skip_irq; - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); - if (f == NULL) { - LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); - goto skip_irq; - } - if ((fscanf(f, "%u", &irq) == 1) && irq) { - rc = xc_physdev_unmap_pirq(ctx->xch, domid, irq); - if (rc < 0) { - LOGED(ERROR, domid, "xc_physdev_unmap_pirq irq=%d", irq); - } - rc = xc_domain_irq_permission(ctx->xch, domid, irq, 0); - if (rc < 0) { - LOGED(ERROR, domid, "xc_domain_irq_permission irq=%d", irq); - } - } - fclose(f); + rc = 0; } -skip_irq: - rc = 0; + out_fail: pci_remove_detached(egc, prs, rc); /* must be last */ } @@ -2242,6 +2258,8 @@ static void pci_remove_detached(libxl__egc *egc, if (rc && !prs->force) goto out; + pci_revoke_permissions(egc, prs); + isstubdom = libxl_is_stubdom(CTX, domid, &domainid); /* don't do multiple resets while some functions are still passed through */ -- 2.40.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:44:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:44:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580847.909288 (Exim 4.92) (envelope-from ) id 1qTgfv-0000q6-EV; Wed, 09 Aug 2023 10:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580847.909288; Wed, 09 Aug 2023 10:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgfv-0000pz-Bj; Wed, 09 Aug 2023 10:44:23 +0000 Received: by outflank-mailman (input) for mailman id 580847; Wed, 09 Aug 2023 10:44:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgft-0000pt-IK for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:44:21 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id afb77466-36a1-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 12:44:17 +0200 (CEST) Received: from mail-bn8nam12lp2176.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2023 06:44:14 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB5027.namprd03.prod.outlook.com (2603:10b6:408:db::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 10:44:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 10:44:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afb77466-36a1-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691577857; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=XkIoWwn3MaIHGEJIW6OGud/vIUMx5fHuhQewOctn+8E=; b=EsVi9boNbCGaBPENBp96stJgmMZEZvog93umWTlVwtrSrkMB1PxAZt02 vlshItieR+Rb2vcdLgvyYkXcZLe7z3R3FMoxY/GdM8ieBGEBcR6J5xUZl d39wg6LG88HIDg5qhXEksdGCpparKQ6zvcvEcGdZmgIPr1TH+S/zZ+Riy M=; X-IronPort-RemoteIP: 104.47.55.176 X-IronPort-MID: 118857517 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:+e4jJaJ/w747KhD/FE+RxJUlxSXFcZb7ZxGr2PjKsXjdYENSgjADy WseXj+Cb67bMWeheNx3Pdiz9UxUupKDy9IwSAtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4uC05U2 PggBAwCdzCJv+vqnq6ccbBV05FLwMnDZOvzu1lG5BSAV7MMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqrCN9NSeTnnhJsqHGU/2MJJDAsbEG6hvOlt2mPR8hAK XVBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9S2+Z97qShSO/P24SN2BqTTQfUQIP7t3noYcyphHCVNBuFOiylNKdMS706 yCHqm45nbp7pcQGzbmh9FbLxTelvIHUTxUd7x/SGGmi62tRbomvbZ2l8ljf4PNJKq6WS1CAu D4PnM32xOkKDIqRnS2XBusXFbei5u2tLzHXx1VoGvEJ/DOr/XmhcYlO4SpWK0JgM8JCcjjsC GffoRhU5YNTFHKyYLVrfpmqDMA30annE8+jXffRBvJVa554bxOO5yBpTVSZx3zqikUqnqA5N JqBcMCjS30dDMxP0j2yQOsM1K4x8So3z2jTWJPTwgyu1PyVY3v9dFseGF6Hb+R85qXUpgzQq oxbL5HTlEsZV/DiaC7K94JVNUoNMXUwGZHxrYpQa/KHJQ1lXmomDpc93I8cRmCspIwN/s+gw 513chYwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:n7aLdK1xF4PltBIio5AETAqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-Talos-CUID: =?us-ascii?q?9a23=3AJq5NuWtqW4yC7fhEWOFk5Vwu6It8eFLH4XPoD3O?= =?us-ascii?q?3EEZjcLTJF0O3w/pdxp8=3D?= X-Talos-MUID: =?us-ascii?q?9a23=3AjkXS6w/T+a5K/jdpFEKaVdeQf+tv2qu0JG03qI8?= =?us-ascii?q?HnMOYCAtBJy2Cjg3iFw=3D=3D?= X-IronPort-AV: E=Sophos;i="6.01,159,1684814400"; d="scan'208";a="118857517" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VLT+UIxaHvAnQMYtx8sI1OIKmb0jBfDI1TfG9rpkvH1NDHv3uAB42UyAvnFbqtn2M2Z1S8QI/xUd4tkaS/Ze5plyBMUGtQqfde38w0Je6m/vBoGRUrk2mvFBHelI8jyRE0QdTMSvkBy9rhHg2yL7JVOGvCZxY2uR2RgXquRP3XkDiu13cwFXqI4cLPuHsh5a741ZUDrlHJqTJEEWczG3BbuNJfeclkpO06SKOHt2CwISQR4tG+oHSV/+8irSxqon/cop9nYikSJoxL3xlYDA+yrwdyi4837JX+Q0/qD0lfWBHytORfnoqnUNuI1/Yk2AQeTHUU1TlXrbPt+V2IFR6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XkIoWwn3MaIHGEJIW6OGud/vIUMx5fHuhQewOctn+8E=; b=AAqsCtK7XDrJb7MFXjIkTcTqWt9+bnx7CMi1uG9n9C8CYtC2Ded+AQYxDUexfBLaLYZz+qcQal7lCdO7PKKqpeLZTngLfLvjA7YLX2I9VNxS7q4VKOLtmedfn2/4Ieg5xGmTnQKX+c6OxYa/vjwlbSLH6qz7qYJe2jwmMVzq6B/eb++T8nIUo2t7ofl5zbfMG7hdQjbNqb7P0KG87CqtBKG5pZN++wls642CjezrszfSaG/Y+e8dWTWjccNxV8mJ7uKjr27WI6oIpydAcNDRuSVSUFZTBmEAv80tEjrwgonlbs3PiLk6VJ5yRPNQoIJfJHvOGGwH+4y6Wp0MNx/71w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XkIoWwn3MaIHGEJIW6OGud/vIUMx5fHuhQewOctn+8E=; b=p6ZX9pKuuQ2qGDKPKTKIG9mGpZXEd13A/Vkop3SKmJsxnrspZsLwBev9Q/W1NgYxaFGEEvnPHXEmeWiYyMw0pOTFZ7w5ghvVEQ6GGtE60gkS8Fyc5nHRk/WcCi1rhTggUgqhCBLku7uUtTnbAxRW+oICWrfxuN+/1kIDAjxojSA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <5c4ebc77-0a1f-0b66-7423-966e88091644@citrix.com> Date: Wed, 9 Aug 2023 11:44:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::23) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BN8PR03MB5027:EE_ X-MS-Office365-Filtering-Correlation-Id: 7983e89a-d755-446f-45f8-08db98c590f0 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LaSwZATaDHM1W2bOVvMKIX7SmnA6XjeS/5r/3cXIgr7B9b/GDbbUdekvO4KBtzejaRx6uqHP9yjJsyNG+IJNLch3gl/8xKdX28noQWlcDpXB0CmCvWFg1D0AILU41yI/rvx64zOdvpeLw2ItKDyrwDgFDNyroOMYSdtW93dU1s5PEYZEoI4SRJSc01cyM1MHHeRiAtrLjyZhrAhhCVSjjOPKLLRKO/d//SV9WVyYNuaLeXy9TKeqc8YlN3fXtOccwWOP0yqmxNSD5cJp/gLSRaGxGo8jwE+bwiV2b8llgqGxCkIh9dkRboNOvt6+EuKSO9Vbf4yYTmRkDX3oykODeEGBn7oxrgZnx99aOF6WCa8Dx86Mz5PV3ghFSQ8yhPlFMxMA8mI2oxZaj3y//u/dJ+NcdYwahZ7OLktwhUBx5DE97Ix4YgfTR9KxMJAlPZiljmEEYMR/O3aPqc0aiDtCcnY4YkF+v6un3f3PmXx28mE0pFeQI0ROhDtBLNZ9yiKAoNeiqKXstjvHF4RhcxiE+1oqN7jX27VFfbC67sIGETMZi5AuT1DM14TA5RaUw1DJW2wr1PCswUoEGEO9mOblgyv23Y/1Dv+zhRwkQHHFxHKt9pyd8fy+DfaK1AvVLnvuZTJkpjY9OzB/hFaYchfr/A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(1800799006)(451199021)(186006)(8676002)(31686004)(478600001)(8936002)(66476007)(36756003)(4326008)(66556008)(86362001)(31696002)(66946007)(5660300002)(7416002)(41300700001)(110136005)(316002)(4744005)(54906003)(2906002)(82960400001)(6666004)(6486002)(6512007)(26005)(6506007)(53546011)(2616005)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emt5bDEvVTNoNFZyNG9KeW9tbnp5YjF0R2xxN0RaUlhBdXNOcWNwT3pqQ1cz?= =?utf-8?B?VUVBektoYU1Ic0ZibnRzMjAyRHdMNUljY242RmUvWEZObTRuWWdzZldoUHBn?= =?utf-8?B?ZkdXb3NPOWU1blBNTjFCcGFSanFHbXNDVk1vb09VQ0hpN2hKcnZSYVpESGhr?= =?utf-8?B?cGRxeUJWY2ZZRjlucXRkczhiMWRiWGlWdFpNOWJ4SU9QK0Y0MW1PcEQzOTRD?= =?utf-8?B?RENoWkx3QUtBWjBXOU1MYTRlbzIvRlBsYmZCNkdkdENxWXlwYVdWOUVzNGxK?= =?utf-8?B?RW1qTHppL3NIUHMzQXMrVnhteXpJSXRQaTF2TWQvOGV1cnlBVlplTUtyOTdZ?= =?utf-8?B?NmQreHYwaER5a1NmamxZdHhwaDZsRlJRc2FxalB5SnAwMVpSbUVrQ2tHVkd3?= =?utf-8?B?RGY0QzRnWUVGWkVmTDVCY2FRTUUxR3ZhTk8zSndQTDBSS29VQXMxRmo4MVlI?= =?utf-8?B?Q2lOZWdQbDNhWFoxc0NBcXB2MnNXcnhOeW14Um9lRkdpMCszOUNMWndJVStR?= =?utf-8?B?RVNmZnBxTmMwL2d5ME1lZUJSdmxhc1lROVQvNytTd2RidEUrYTNwSE55blBw?= =?utf-8?B?SlJLMlltQW1ldVViOGlSRFp2bWdYRmhlRkhmRU9WQWxuUHQ5dlJFSkIvL3ND?= =?utf-8?B?RDFzM25XTmlXOHVVTDFFT1A2SjJnUnFkOVRRcWFYNUdaSHVPekkrVkhNRUFS?= =?utf-8?B?dkpzcmRYVktUeTVFTTZPTnRaaVJ0a1lBeW9maFgxVnVpK0Z5Z0YxNnNTdk1P?= =?utf-8?B?dEdwbDB5OGV1N1RvUVNnNE5USWdwZ1E2WlZoRzAydlpRUytWMzhRNzdjc2Fh?= =?utf-8?B?NEg5SzkwaExGQnl5NHI4ZmszUGRaRnZyWXo1QTdVV1UveEYwM01nb3FNQU5j?= =?utf-8?B?c0ozZDJ4LzEvTEtDOFVyNjBpZjlEL0lycHlBQ1dNUVRyUUZsT3dHU2ZEMFJo?= =?utf-8?B?WWdZcFpNN1FuYWY0ZEIzNnlGMTNDcVlMQVdwOXgzOUxuUWsvVEExOHp3WjBP?= =?utf-8?B?V1BuejRPQklnU25CWG5Hek4zYk1scUpCNWRxLy9MREdiQXQ4a1hrdnhDM0Nq?= =?utf-8?B?TFRRWGRwNDI1ellESUNqVHdmZit2TU1tR0ZGaE15eHFsMEZ6cWJmd0Vya212?= =?utf-8?B?bFhyM2FEd2gwWUtYNHpKaWdFV0gvU0UvcVNqOFFjWXJSK2NRRmNReStGYlRh?= =?utf-8?B?YmRxd2xiVmdXaGdRZHE3LzAyTms1SWs3SHl0elhHeVZoazRKU0hpbndmZjBi?= =?utf-8?B?b3BhUWZkQkpCTUhIRkpiYkZZeFVreUxtS1BWWFdKME5ySmxUR05kdkY0bXc1?= =?utf-8?B?R29OM1BVbzJzZlNlWFpsRktyRXhPN0ZOTFFsRmNPcjN3TFlZUkJrMGg0bzgx?= =?utf-8?B?TEJOZUcrV1cyRkdQTmFPa05SbS80MHExT2ZBM1ZtaXp3T09BUFF3Wm1ENTEv?= =?utf-8?B?VWE0azk0ZEZvWWcwNk9peTFWUm93RGU2VXd4aE5JUS9Pei93aGgvaXMyZU42?= =?utf-8?B?Y3hNcTIzRWVrYVJ3VEgwamZuU0NMQmZ1Zzl5cWk4VUVIbDRUWDE4ZVRwSzZQ?= =?utf-8?B?eTQvU3hmRjYrbk1yT2FVZ0JLaXR5aXFaMG9YMGp2eG1jT1NnWXUwOVBocTdh?= =?utf-8?B?Tzl4RTRDWGFqaVM4eWlZU3VZZlNzcGhLTXlDQytKSTl4TEU2S3VBSzIySlkr?= =?utf-8?B?bkRoMG9qK29VN3VxZm1zY2hDMjZaaDRrUHdkMFZWTi84bkpLL3hQeFNHdW9G?= =?utf-8?B?SkFOM0YwdE1qU3owWUtPSDhmVUdaZGRtOS9JejBQS0VrbEQ1MHc3NGFyMm5D?= =?utf-8?B?Y21pSGhFTU94TTQ5ZlkvNmE0S2NrQml0OGVJS2drSE80ZnIzSU9xUGJCazdP?= =?utf-8?B?bHdMc25EQ3VUYy8zRUQzM0ZCTmVKSVVMZVVWeHltZFYwa2x3b0wzU3VpV0lm?= =?utf-8?B?WnlobDZCSzJDOHdwalo3Mm1zR05NbytXVGh2NnBrSjNDTlJjOEtlSmx1Nm9v?= =?utf-8?B?NUVONFpWZmhDR0w3RTgrNUlBK3cvQk1QT085Y28rUXlKUjd3ZmZnbXhUM0VF?= =?utf-8?B?eE1uMWJpcWx6aEFVUU1mK3FUMkFNVkIvSGxOREc5R25aRmJUZFkzNHR3Nko1?= =?utf-8?B?RDdtYmR0U2xNbm5ta0E5VklxN1IxeEdYbHRmR2UyRjFFV1Z2N0VXVU01ZmU4?= =?utf-8?B?Unc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?SFBNT0tnV1Y5R0RnWFdzaU04NzJ1Q2lpbno0aUlLVTAxRTNTbjFoQzI4WEtL?= =?utf-8?B?b3dKQkZKeXJmVWRRMEZicXM5ZFVRdEM5dXJ2QUNNQXV0Z2J0Wkp5V2tVNUt6?= =?utf-8?B?YTR6a3dWcjI5RkxNWVhBRnVUcll2ajkwbHJaMkpNY0dMMW1LMTZzVkZpZXNh?= =?utf-8?B?MTR1RVREWmNwbG1JN1ZRVzdkM0x6Tm5ZdDJUTExJUXVJOGJJWEFESmc1YW1k?= =?utf-8?B?aDZWRHJoTDVkUVNySlNYKzJLYjh2NkNNalhyZ0NLeE1pOGlqUm1ucGh1cHhm?= =?utf-8?B?OTRRWVdncmdlYTQ3WllqT0d5cFZMZmQzbm9iWUtwYkxDZSttODl4RHhIZ25R?= =?utf-8?B?aVcyMEFNbU4vK0pSbDhMVDgrUjdGMzAvSmtFNk9pNkxmbCs1RTF1eFNDR0l1?= =?utf-8?B?ZURqMCttT3F1VTVtUXpxOVJLWXBrRndKRG5JY3pTVThpN2VQeXBJUDJMaUR0?= =?utf-8?B?a0lyS2pRVGI5TStlamtSYitsZGxJOE0rdzZmdTBmY2pxNG5jdDhkUDVkNHRI?= =?utf-8?B?bStNZVZxN1BXWmQvZHoxa2s1cE1qN05JcFVZVG8zY3BBQ3ZMR0FZNDV3ZVNp?= =?utf-8?B?eHYxUzFlaXFJK1B5UlJaQ1FuT1hPZ3pWcGxoWFgvVnBLeWJQVDNtajNkSTE0?= =?utf-8?B?WVlyd3F2eXRuSDAzejZxS2dhbC85bVZERzEwTG5GSUxNZHJmTzVTSjU3a2Mr?= =?utf-8?B?OGduOU5laWhhd3RGaHA3aG9Qd1B2RTJsNVQrUThac1FWdzdpVnNubTdoRVht?= =?utf-8?B?WFhxQmJUQXZkMmZzc2ZGNmpoYnVqeTRsdHEyWWJ1d2tEdit0Nm5oeHNtQ3pv?= =?utf-8?B?dFk3dTVSdmwrSnA4OTR3czhFZUdqYllzWHZwNW53QVRHTXV6Y0pONnI3a00x?= =?utf-8?B?MmxlZkFYTWlhK2UzZGcyYmgzenFJQVVib1BmNnJLYTBYc25FUUZXSFFJeSt6?= =?utf-8?B?bnZ3ZVZxTzg1ZU4wV1J5TlNWd3ZtQmhWVExYWjY4NHF3S0taQkhFcG9UQWsx?= =?utf-8?B?Rk9DOFF3N3pUY2pmNXdJOXU4RGVhTEVaNElMWFJiOHE2K1d3aWRNSEhZTWVC?= =?utf-8?B?SGdhYmdrcTQya2VoVzU3bjA0YllUTzg3eU9ya1ZaUnhBZkRTOFZKV2Jod2pN?= =?utf-8?B?T2JWd0ZCMk5URUJWZFhvYWhPeWoxZVlPZnFiaVVVV3duRU4xZ3pVUnZISzlo?= =?utf-8?B?WVpjcjRmdFNBOGNtN2RiR3pUZ2hmMWxvTzZJSG10NE1jak1jTklpMlBvY2VF?= =?utf-8?B?bFUwc1I4NXh2ZWJOVjVyUTBVSHRBM1pnWWNHdThZR0NaakdrTVhHeDh2bmdl?= =?utf-8?B?MjVydXJQRjhxSnRMKzNjSmpEeWVyRFRvWjdwMTJGUFNySCtsUCtuVWIrTm5Y?= =?utf-8?B?NFRGWGFXN0xCRDZ0MjdNd3dhZkhTMDF4VndDeHduVmU5ZG4xWjhPWE0zTUZj?= =?utf-8?Q?E8QjB/k3?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7983e89a-d755-446f-45f8-08db98c590f0 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 10:44:11.5819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oPxF0dyqjIfu+mDmbfEmougRCiMsfz/wp0SqeLhpuUoOYvc7t4pK0vfgJA4ZQR+rgmK9iziyzyg0B6dmqaNOygF8B+2LKV8bftNHCLgk2+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5027 On 04/08/2023 7:08 am, Jan Beulich wrote: > Have these in one place, for all architectures to use. Also use the C99 > types as the "original" ones, and derive the Linux compatible ones > (which we're trying to phase out). For __s, seeing that no uses exist > anymore, move them to a new Linux compatibility header (as an act of > precaution - as said, we don't have any uses of these types right now). > > In some Flask sources inclusion of asm/byteorder.h needs moving later. > > No functional change intended. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:49:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:49:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580854.909298 (Exim 4.92) (envelope-from ) id 1qTgkx-0001Wh-5s; Wed, 09 Aug 2023 10:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580854.909298; Wed, 09 Aug 2023 10:49:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgkx-0001Wa-2i; Wed, 09 Aug 2023 10:49:35 +0000 Received: by outflank-mailman (input) for mailman id 580854; Wed, 09 Aug 2023 10:49:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgkw-0001WU-4p for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:49:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgku-0005jW-3X; Wed, 09 Aug 2023 10:49:32 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgkt-0001uy-Nv; Wed, 09 Aug 2023 10:49:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=T/l5dC5R+z0cxfPQVXXu9+fyUqoj8QwUNxzt6UeKQLY=; b=0E+VQmLqKceQBcVvCXHHysESZn 5B7+z8gK4bL7suJGmyLlSzc3K7hVMeXOe6PooEJKbzos998bPw9p/Z6sxK45j/NNwiDG1hGPMcxxC EPCmOGr/5AMGM0Scy3BsxgculZ6N8lM5/n6nc9lKuK7SEeQTPORJMBGxcT+HGyNR/mKA=; Message-ID: <115e080e-ecba-4117-9d43-9888f82c8d5f@xen.org> Date: Wed, 9 Aug 2023 11:49:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 04/08/2023 07:08, Jan Beulich wrote: > Have these in one place, for all architectures to use. Also use the C99 > types as the "original" ones, and derive the Linux compatible ones > (which we're trying to phase out). For __s, seeing that no uses exist > anymore, move them to a new Linux compatibility header (as an act of > precaution - as said, we don't have any uses of these types right now). > > In some Flask sources inclusion of asm/byteorder.h needs moving later. > > No functional change intended. > > Signed-off-by: Jan Beulich With one remark: Acked-by: Julien Grall > --- > v2: This is the residual (extended to PPC) of an earlier larger patch > which was partly replaced by introducing xen/stdint.h. > > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -1,18 +1,7 @@ > #ifndef __ARM_TYPES_H__ > #define __ARM_TYPES_H__ > > -typedef signed char s8; > -typedef unsigned char u8; > - > -typedef signed short s16; > -typedef unsigned short u16; > - > -typedef signed int s32; > -typedef unsigned int u32; > - > #if defined(CONFIG_ARM_32) > -typedef signed long long s64; > -typedef unsigned long long u64; > typedef u32 vaddr_t; > #define PRIvaddr PRIx32 > #if defined(CONFIG_PHYS_ADDR_T_32) > @@ -34,9 +23,9 @@ typedef u64 paddr_t; > #endif I find odd that you don't add a newline before/after #endif here but... > typedef u32 register_t; > #define PRIregister "08x" > -#elif defined (CONFIG_ARM_64) > -typedef signed long s64; > -typedef unsigned long u64; > + > +#elif defined(CONFIG_ARM_64) > + > typedef u64 vaddr_t; > #define PRIvaddr PRIx64 > typedef u64 paddr_t; > @@ -44,6 +33,7 @@ typedef u64 paddr_t; > #define PRIpaddr "016lx" > typedef u64 register_t; > #define PRIregister "016lx" > + .. you add one here. But this change looks a bit unrelated and IMHO of out context. > #endif > > #endif /* __ARM_TYPES_H__ */ > --- a/xen/arch/ppc/include/asm/types.h Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:51:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580859.909308 (Exim 4.92) (envelope-from ) id 1qTgmJ-0002uV-GJ; Wed, 09 Aug 2023 10:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580859.909308; Wed, 09 Aug 2023 10:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgmJ-0002uO-DT; Wed, 09 Aug 2023 10:50:59 +0000 Received: by outflank-mailman (input) for mailman id 580859; Wed, 09 Aug 2023 10:50:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgmI-0002uI-0R for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:50:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20624.outbound.protection.outlook.com [2a01:111:f400:7e1b::624]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9dc98129-36a2-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 12:50:55 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9067.eurprd04.prod.outlook.com (2603:10a6:10:2f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 10:50:53 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 10:50:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9dc98129-36a2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RFe4HA4Y49KLAaP1LuMJtKAY6YGczGurCwJOeG6H0xwN5CeIqNuOIhdboQF3px3elN+vZ9eMqwNnZ3lHG6GwA7ziG22i77EYeYU2tUfHLFigCSnzAVno5LkpP2/X5VFQ/D59k1zTxYCFjjrZQO+fFuKLtTFYuq2be4+7+A0bRGZH3x3U28Ad+AR5wCX+T3ziNjFiQH+bHMaO25HBBrj+Jo5G6nsxln5ZulnOJF4OnSRDA8N/SNRnSjpkzZRc/WodtGUzLjQ3QgL1hzi3a9dqKDBmAnn5/jJa/6IMoHEi+1FgmLcqtZWsazY3fS0p9sF7PBFqSBGy9SmBQNiWUrYktg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C1GQHusw4elOucUIan9J4ndko7DdBkW3IAgTLctyzHs=; b=nD/Zp7rHCIbGfpbqcbsSBRB27l3c4gzq1WVMupY1pg+Wck/WSr/yjZ0aft502S+uiSJDAtb4AQxhnmZqCXsuwlsPB7gukQxU7cet/RkPGgpKZbgzEUNWV8dlet0j0KVcNEKbBeLmmYLNj7AqILV1hfXyb1waGqcV349OkXJ3FKDV1zj/7hiPqehM9GcPp5GQIAMPOtLE8W5PnifcjQfvzfWNaWOArilR9RceKzNuZ9FGTD88vyxVxwVsRT02BJDtMMPO5pbUgDHil2B/uK4X8eHiP7Ri7+XOFTwkAhA+IO2SDtq34vK4X8p8ZXJFf5cpyxbhOzMes02c4XC5gkRMoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1GQHusw4elOucUIan9J4ndko7DdBkW3IAgTLctyzHs=; b=HxfG28qdVGP1y3/JAj/I/03DarTyYxsELd6RB31neVHar7Jsl4hgqBclfMqD73xHRj4Wc8Y5NBHo1x/ENMooeeLhLc8J0vl4uaFOxHtcFj7ekoZs5yVN0PA8ac3YXUSmhJj6I0ynO0fGQVFESmEWQoKmz2LqB1YxDbxiaXeiUQsoCY+QwmLMUgD+ztYl/hcBUn/IghoznksKxOBBLiJroku485xT6TQmH8somaaK0SmjNQnAh0l5NPgyzYy9SmJcfudMmkddkxaxp463+mrpi59UBuGN178+Tqolz9yPcOUhXyMYMhPNa/IkOZWU9QVbV/3tj51k/DzHj7IMMe7bSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 12:50:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio From: Jan Beulich Subject: [PATCH] move PAGE_ALIGN() to common header Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0240.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b2::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9067:EE_ X-MS-Office365-Filtering-Correlation-Id: a574a85f-8e13-4896-0415-08db98c68039 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5PF2GSZSno/3iS/dS9BqQq4VQgnD8hjqhLqJMCsvteMs2lILGaqlcUfg7kacI0QHxZIBOZOCfpSAMcHyUuen254FwCO7sffJYLqCzebTOR4mS2xsoxORRdFtHZho1W+nkyGhE2themhM0mpRkAhDlY28QBhfgEZOr4d/gtnfBgdSoyQlAzdkM/bU1LFE1By9Z8VhvuoDnw5sOBD8kGslc/LcGg8THy970hHfJxP18tpl9mns46gLMMMZcKgBPmhfZXnE1HBUqcyaddP2eyhAdbwSDBvtX88ipU6OU4OBXmVybhWviGRD+/KhN+Ibh/rB+FeEur5qaofGZrMWy2Y0IJzYTNzL+gdsfuRE4E2xgo/zXRIPhyIFjV1SlUnnxtJ8EwLlTUDl6dZ2iapb+4Zq601Iq3xs0zirEsiT8zuwHSM4wTS/f+erwssVkJLV+z+j1Kicm9Ls2m9eXwkjRDv0Gtz6UU5+CYfuHhHoBIkKBo6wukNsKkTp//8r1W8oD1B9kHEAH+GFgKs2V0U6Lb/rGT0+2ZsoMv4uiUtFIg+Ps9h/Jq++MLUVph/6K1EjnZ0OgLx1+Saa2FsXJ3UytbXmqJsHMnPeDAbRjfWbdgBjzJRwT4B47W05PUYk+ByDJWPpLFEqGlm3V9o3Ts4uw9Tacw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(346002)(136003)(376002)(1800799006)(451199021)(186006)(7416002)(8936002)(8676002)(5660300002)(4326008)(316002)(41300700001)(86362001)(83380400001)(31696002)(6916009)(2906002)(6486002)(6512007)(6666004)(2616005)(6506007)(26005)(36756003)(66556008)(66946007)(66476007)(478600001)(31686004)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGtDVWp6R1BLNnU4ZVFud3ozK08vNnJLU2pjUUs5MlF3L1RaRTlNNm9zb3R0?= =?utf-8?B?Q1NJRG92azZYTUc1RnZmazRFeEpZRFI3aEhCQ0JFaC83bWh2VjloVExZbjk1?= =?utf-8?B?SCtxeEpPcitlTndTK2lMd0w2Mmc2OGR4TWdPbG1NRFZzMzBvZWQxTTZ5YnRt?= =?utf-8?B?cnhwb3JsR29iQ1BzYmdiNktGVlU5SkFhV3pwS1VGaGZmS3RlZENIQnI5SStO?= =?utf-8?B?RWE0VHdScUNvdm5ud0pxU1VTOUlBZk11SlpWandYcEM2OVV5SmJYaEJHeFlZ?= =?utf-8?B?Mi9XaXdxc2srYVRjYXQzSWlUVDRlTkYwL1J6c0Y0eVgxc2xpUENjOWdyTWhr?= =?utf-8?B?c0JXR3prS3hPN2VvMk5HSndxcWU3K2xHaGdrTGtrQ2xuZjFVS2c4Z2UzM0xI?= =?utf-8?B?bmtUVk1pL3VwdU54MlFzeS96L2dPUWsyS2ZkcURETzl4R2JqQml6UFpMUnpS?= =?utf-8?B?UzBSN1ExYS9vUW5zUVJhVjF5RHFNVjR4c01xVmp2QTZmdlg4R1ZXeVZhLzVM?= =?utf-8?B?TnVCUmJ4dVgyNVl1b0NMK3JYNDcyU2dYU0tLUUFoRE1KL1BNbUdtZ1Y5eHVm?= =?utf-8?B?N3phYWk0VTNpclJBL1JMaFgvdm4zOVVSeUhlNm9VYnBUOWhtWmFQWVJycEcr?= =?utf-8?B?RDhYQVFJay9WWVNwUXJXQlJwUHVnbndrWjU4U0dha1dkTGRHd3E4S2JSWitB?= =?utf-8?B?dmp4NklMN3NwMUVBaWQ2b2xpOCtHa2FYL2F5SE82QVhyZzA3czVWM1Q1dk9P?= =?utf-8?B?MDJPaytaU0k3MVF4cTlVdXpzUXJreHQ1QWc4NlNVcVpEK3NlclN0ckpVVG4v?= =?utf-8?B?MERGeEJ2TWRraGdOczlnZUFqbVRkTGozeXN0anBKcU1NMmJpT0dCMTZFNTd0?= =?utf-8?B?cUpxRENXZ2xNRUdlaFlnTjZnT2VNZDRKQjl6RDFSMUZ5bDg1dlV6NGdlSGhQ?= =?utf-8?B?OGx6eWVsNEY1SW5WZlE3Y1Nhd2VEcGNacGZzdWxVNEljYkNjTGF6Mi83dXAx?= =?utf-8?B?QlYrNjQ2eG52ckl6RWZ4aTJOanhuZUhuakpMWHp1RXJxRS9PbHRkSFQ5L0hR?= =?utf-8?B?OW1NM1ArU0VRVlJPTGdkdTFoQVdxai8yMjdjai9JV3gwMExtR2trWGV1Um9X?= =?utf-8?B?NDJMY01iclhqSnpoRkRSOHowMGI0eVpHWkk5cnVrck9ONHk0SEdmbjVpcWFs?= =?utf-8?B?TzJyb3hiZkg1UnpmdmZZcVpOdWZvemdZUDQ2aEszaG05cmdKZzZ4SktOZitu?= =?utf-8?B?bUVsL21ZcWxUT3hLbXREUCthVkFLWTZQL1IrTEVyVm1LWXgwWVdWay9Md2Zp?= =?utf-8?B?UU9XS2F3UWIzZ3Jvc3QvRkJYT1AvVldlNGNsR21ubzVtYW1XZkxObWhUSnhY?= =?utf-8?B?R2JGSEJlSUFDeVl1Z29UV083RzNzTCswQUJGMXFiWTlmWXJBSTVxU0VvSUJE?= =?utf-8?B?Wk9Ydlh0bVpYSmw1cm9sbHkxTDhIdmhYUWdsNXg1RjQvRjN6T1NoR1AyZmxz?= =?utf-8?B?NlNqTyszZ0JGUzh4S001Tzl3UUhJaE1Vd1lRU0dIaitoZHRVamR3Ynk5M1Fn?= =?utf-8?B?MzV1QnMwWENrZjUwU1d4WUNQUHpKY1FyNTBFVTZrUVVHUHpjSUMzdFgxTzk2?= =?utf-8?B?cFN4TVZFcXNsUUZUZWJhdkRLQlNwaitoSHhJQXhHRnZJeTh3aDZlNEMvTU1n?= =?utf-8?B?UFZqT0FYUkZVV3RpNHBKNUtoeEw3ZUhxVVBtU1FGVFZ1LzY5VTE5d0M0dUsw?= =?utf-8?B?eEZkVkc0V2dsTHA4Z1h2VEdHUmR1emxxWEw2NFB0S3VPdURVelBjL2V3Y1oy?= =?utf-8?B?QmtQNU0wbXJEN3VRTmY2TmpucDVxTXJsTVBiaEFETVhoMnZuTG9tTmxIWjNm?= =?utf-8?B?RERIYnJTRjR0UCtOSW9xeGdiZTlyNHZaSmhXV0F2TTJWOUxSeGJuTzh6YWxn?= =?utf-8?B?R3RzMlBuRG9GejZnM2puRlJqU3hGTGF2WmUzbTBLOGUwMzI3MGtNR0x1aFdq?= =?utf-8?B?VzJnRVhpN3RVMko2Z0QyemFBdFp0ZFhBM0dISUhlZnhOOE5lUFJxVEhweldY?= =?utf-8?B?Sk1KajFiQzBlVzdHZWFDUFRsR01oVnFaUlRKdUppa3l1dGFFQVBwOHpCTFRD?= =?utf-8?Q?4iFq7RPfjNrLffx98Ki32Ta1u?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a574a85f-8e13-4896-0415-08db98c68039 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 10:50:52.7499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OT+YVVvXuHxPNbkjIBXM8R8SkDOsXqnHpeFAX2hfk1j9Go6KkbJkGEKfuVjeH4p3FJCWcQQdgCqW1mIVYQlH8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9067 Much like we have PAGE_OFFSET() there already, there's also no reason for each arch to define identical PAGE_ALIGN(). Signed-off-by: Jan Beulich --- a/xen/arch/arm/include/asm/page.h +++ b/xen/arch/arm/include/asm/page.h @@ -303,8 +303,6 @@ static inline int gva_to_ipa(vaddr_t va, #endif /* __ASSEMBLY__ */ -#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) - #endif /* __ARM_PAGE_H__ */ /* --- a/xen/arch/x86/include/asm/page.h +++ b/xen/arch/x86/include/asm/page.h @@ -404,8 +404,6 @@ static inline void invalidate_icache(voi #endif /* !__ASSEMBLY__ */ -#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) - #endif /* __X86_PAGE_H__ */ /* --- a/xen/include/xen/page-size.h +++ b/xen/include/xen/page-size.h @@ -10,7 +10,8 @@ */ #define PAGE_SIZE (_AC(1,L) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) -#define PAGE_OFFSET(ptr) ((unsigned long)(ptr) & ~PAGE_MASK) +#define PAGE_OFFSET(ptr) ((unsigned long)(ptr) & ~PAGE_MASK) +#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) #define PADDR_MASK ((_AC(1,ULL) << PADDR_BITS) - 1) #define VADDR_MASK (~_AC(0,UL) >> (BITS_PER_LONG - VADDR_BITS)) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:55:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:55:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580866.909317 (Exim 4.92) (envelope-from ) id 1qTgql-0003Xh-1h; Wed, 09 Aug 2023 10:55:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580866.909317; Wed, 09 Aug 2023 10:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgqk-0003Xa-VM; Wed, 09 Aug 2023 10:55:34 +0000 Received: by outflank-mailman (input) for mailman id 580866; Wed, 09 Aug 2023 10:55:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgqk-0003XU-BO for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:55:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgqi-0005qB-MK; Wed, 09 Aug 2023 10:55:32 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgqi-0002Db-FB; Wed, 09 Aug 2023 10:55:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uGxsdS7rY7GvnSEbPsH4bZeQXPNOc0MWLGxxwo9QX0k=; b=EPM+q+GPBv9NgQ9eEkX2NyBbsa 87uI1MA958g1f2LGpU8LvXU+A3iPbipMeM1WIDYRWNhEW94H6G2WFdnGzn5TsMtIo6E4I1v89MLEp jp5lWQe7/aYYYcv6Z+THkq2vD/D9Z1QmvB8MK/mdj3ESmAS0cBvNiiTU0irAYAs51VvI=; Message-ID: Date: Wed, 9 Aug 2023 11:55:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] move PAGE_ALIGN() to common header Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/08/2023 11:50, Jan Beulich wrote: > Much like we have PAGE_OFFSET() there already, there's also no reason > for each arch to define identical PAGE_ALIGN(). > > Signed-off-by: Jan Beulich > > --- a/xen/arch/arm/include/asm/page.h > +++ b/xen/arch/arm/include/asm/page.h > @@ -303,8 +303,6 @@ static inline int gva_to_ipa(vaddr_t va, > > #endif /* __ASSEMBLY__ */ > > -#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) > - > #endif /* __ARM_PAGE_H__ */ > > /* > --- a/xen/arch/x86/include/asm/page.h > +++ b/xen/arch/x86/include/asm/page.h > @@ -404,8 +404,6 @@ static inline void invalidate_icache(voi > > #endif /* !__ASSEMBLY__ */ > > -#define PAGE_ALIGN(x) (((x) + PAGE_SIZE - 1) & PAGE_MASK) > - > #endif /* __X86_PAGE_H__ */ > > /* > --- a/xen/include/xen/page-size.h > +++ b/xen/include/xen/page-size.h > @@ -10,7 +10,8 @@ > */ > #define PAGE_SIZE (_AC(1,L) << PAGE_SHIFT) > #define PAGE_MASK (~(PAGE_SIZE-1)) > -#define PAGE_OFFSET(ptr) ((unsigned long)(ptr) & ~PAGE_MASK) > +#define PAGE_OFFSET(ptr) ((unsigned long)(ptr) & ~PAGE_MASK) Please mention in the commit message that you took the opportunity to re-indent PAGE_OFFSET(). With that: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 10:58:50 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 10:58:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580873.909328 (Exim 4.92) (envelope-from ) id 1qTgts-00048m-H9; Wed, 09 Aug 2023 10:58:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580873.909328; Wed, 09 Aug 2023 10:58:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgts-00048f-EF; Wed, 09 Aug 2023 10:58:48 +0000 Received: by outflank-mailman (input) for mailman id 580873; Wed, 09 Aug 2023 10:58:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgtr-00048Z-C8 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 10:58:47 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0622.outbound.protection.outlook.com [2a01:111:f400:fe02::622]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b63b3f72-36a3-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 12:58:46 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PR3PR04MB7419.eurprd04.prod.outlook.com (2603:10a6:102:80::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 10:58:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 10:58:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b63b3f72-36a3-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1rQimP/a2kdgqF8JEpSFsu5OQgBHql+zUpHUHPbD/dfzhUgyqgi10u+KtQjDF4gOjgwKoViqPpbLQlHHnTYa1bwW/p8FWoNtl+EiPc/FrrGSy9ZzTJuYdOAkjOmwUkzm8KAus+maB3jp0H7me/JCi0HFcN5SrqxoNlT6/6wF77uDB9u6TgnEHXrQ6x6AXCVCu4IGb2z/w66yuLvj2/NOCmhaJ2luOYQHGZIAiEStAXd07roSKig18MkrwU3q4InwWwomgtgkUXPQ5t5/1rzPsGq5iEhm50xwJJVo07oWnpcEHgw1RHX88owgCGC5iJuK/cPYr0BKOGYKF/C9jf8oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AJPJp4MZfHRx9lZamo6Lxirl2WEO4pNO4Pg62Jcnd70=; b=S82DhUAkug0c6ceHyrm7sMnRASCjlOm4gNq7EH1rM3ViogHuPg6fsYrci6+EFOflpbf5dy1P9kvafkWY3fXk86OEfy0m0/TOytEvrvLSQrnIaKKsDzaEduJiHzMQdl832lz70GJZcsnyqs+RQ9Vcq1BPQD3bBsqmHmjsAP+lgQzC0G/NnxHGZpuCuSwhesSpKa1T2fvsLXm0sBYbrM/Dm9iFhgo454wSqojKqgzgFbcLge46AHNqFrF57QZO43o/tg15MolACQt+FmocgAiDil/2LAgfOm8M2n/d+s90iRbwcmCsVOhYcvD2GfN0jadWiqJBD8mnUGZzTiXyhPDxzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AJPJp4MZfHRx9lZamo6Lxirl2WEO4pNO4Pg62Jcnd70=; b=hVr/qO9zNFfQ5jokGSAnhKPQVE2NJWoNqCie8E5RFrfnlynXxZ15vv3eMf3isXLi+4DCUQQyAfLWkeuibzkkhBp7JgTYaeCdPgvKAr9R6xdcSGXjnVOBPuz91TEt4ox3V9pxm0GM8w68/3rcqObg1yyfAnh7GGu3J0qw1sykPhZ0UnXIBKzW6yIYGidUmFNa5ubahpS8LyvGW7cbowFcuvRyh08yLkVE3SR0h+8rYlGFnSmsU0Q97rn9Pd5o4eh4tbIT9fjrC12y4z6l40/ruXnWCcb7jR7067igmY9E/HR3bLMDggCLb7O37Y1izzxY3F0yMczxEObo2kE/TG+anA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 12:58:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> <115e080e-ecba-4117-9d43-9888f82c8d5f@xen.org> From: Jan Beulich In-Reply-To: <115e080e-ecba-4117-9d43-9888f82c8d5f@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::6) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PR3PR04MB7419:EE_ X-MS-Office365-Filtering-Correlation-Id: 869b035d-cc4c-42fe-2257-08db98c79941 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CuKVdFywyxVgX6/9aTUdoDH8jm+xOMRZfsEX2b2HPnAaefEDVVkkil06zqPQgMQtfrS1tkfJFweCl1q0z7Lmg0vV1UesEi0/aBzpsu7GMQq7GFRRk8HowrOt6DcJUThkXg8qtVXpC6IPANKg0mCq3HiPShi+dQKrihUVAijHhBq5jFjqcRK9Y0XxKPlOLwgF6mi19soKtXijF3rVzcKNWjdNM1pqxrsZBlJxhMP9OU7qs2cCG/B06Lhzg9OSHjVXjFnxjfEAiyIhgCNZHSCfi+Xese1ZzDl1bmCmKqWPdDeuK/+IGdv48xYH3HO4YVrwHL0Sx7h3gSEwCEhPQE79tuPZo74r9s4zact/5WJBgJBQa4zG7eKQ93uFFYGuFvfmCDkhF9u/Awkh2EVOZFxjqEAShMFBw8JKsR+5uMMtkyNc1I1hpVZL2COjqQSIc5QHSlg3q2apKbigzuuKtgt785aQwgf2dC2HfD2Kqzkqvs0SjspBYfNBP+3Pg9nXE+XvrZzX6RtAvFA2EDXuncNGWEg7ShoFoXk+SN67xYMrAYbBXwFScxz7IEMRuecc8kxD2JMG74i+JMDuzROKtgqoZfg0/9Q6795HJEb4L7RNnqJg3K+AwBNDcu5Dm6aGWmPb4Xuza5K7IA86XhsZj6ajmw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(136003)(39860400002)(346002)(366004)(186006)(451199021)(1800799006)(316002)(7416002)(8936002)(8676002)(5660300002)(2906002)(6506007)(38100700002)(53546011)(26005)(83380400001)(2616005)(41300700001)(36756003)(6512007)(86362001)(31696002)(6486002)(66476007)(66556008)(66946007)(4326008)(478600001)(54906003)(31686004)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akNjdVplNDNLSWdOeW1LVFFYK1RUVFFzTENyOEVmalNMejFuK0RCYnRJVmhw?= =?utf-8?B?TlZaZi9qWkJhY2JSZGtDWDl3SUlvTU13dk56V3dad0pkMk5hMVlqTGxpY3ow?= =?utf-8?B?TWc1OTJuYVBQR3p0UVZadW50VXVwRHhXQmRBUGJ3Wmw1ZXl6MStkZEdMYnI0?= =?utf-8?B?NEtqSGpHUDJ6dlo5YjJVQUJabDVFMkxndy84bXl4UVFCN1BwRU1ZclNmOWpU?= =?utf-8?B?WkoyVkZMVmFLK3lDZTJlZzkrMkx6SWg3SWFjNmptaGFJcFhQYmxhcFU1Z3h1?= =?utf-8?B?WnZJOU9ESkFramM2MnFLSXNaMTFwOHZOSU9TY2ZaYnl3VndVaFZBekdOUTF4?= =?utf-8?B?VkZKZlJPMDJrOW5kK2NFamVMMXJqV0UyL2FYKzBLeUQvYWs4NVBtS3J3dGZW?= =?utf-8?B?b0R2aTk0dm9RWGpSYnpZczFGUzRMRTlhYSsveHF4N1Y1UThxenUveElWQ0Qx?= =?utf-8?B?NDZZS1dGc2kzekFMbENkRzFYMGpaYXZhemkrb3puWmRqbk1hS3h3QWJmb0hM?= =?utf-8?B?bnZvUDMyMFhldGswd3hvQjVVKzdra3dYVGt4WlZLcUx3WHhqRFQ4YjdNaDA1?= =?utf-8?B?R1JTNmwwSG0zMlZhdTNJUG10N29SV0s4OUZJeGl1U3d2THpHV29NU0twRHc4?= =?utf-8?B?YlNJUjRzT3VvZExSb0c0N05vVHVRYzFjcFJ5cGdIWSsxbmxaNmptZ00yd1ls?= =?utf-8?B?bVQzbmlJOExJOU5yakVjN2o2VWtnY3JMeDh2ZDVWWUs0SS9vRTYrYWdDZXla?= =?utf-8?B?NWEvV3VxSjA3TUUyK2t0aFF0V3FjMmN0SzdGdWFIV25yVW0yVXpJU2Z1czV1?= =?utf-8?B?MHNkZDFtN0tUbElVZmFxbmR4RDNEb3BwOVlkUDU1VHJDNXFtMElLVVdITVZR?= =?utf-8?B?RU1TNWZOQ2dCTFhOSVgrYVFBRnY4SHQrR0l0MzlCb09WQWVrWDZaZll6RW04?= =?utf-8?B?czRSTHRwOWNoUkRNVnZ0Qy9mWjIrVnUxREhYOFJ1eGdIRWNvMkYrUEYwWUp1?= =?utf-8?B?UC96dUlxbjBicVhzK2dWdlV1dWwzUXVDc2JaZmk2RTdqUlJhdUtORXZyZURC?= =?utf-8?B?VWc5WGRwdXJCdnlqTDM1dWdYcWhQNTlIaTlSQjR3WE4xNVZFR25ZbkhKQm9L?= =?utf-8?B?RGF4aldSSi9kaHBzU2FPZFdqNVlRSGRGMWY5Wk9Mc0JHT2Y2TXp1Z2Vwdmk3?= =?utf-8?B?TDQ0TWZaT0VtTDNCYXMyb1pXWVNOT09Gc3NyU0ZuOEsrVnNMVmxwQVFJNnBn?= =?utf-8?B?VnY2alBxNUJzT05wam81Wi9DVU1Hdnl4VUpDa3IvTEt6LzVSRGFpelRXUDhs?= =?utf-8?B?bCtBOEM2bVM0SGJFd3lQdStKS1M0WlF3akNkNEFJb1RUN0VVRFhyVlYxOTV5?= =?utf-8?B?RzBuZURwZkEranJ3YnRsQWxDZFJmSy84S29BS1pnRmhVN2tUS1JaZUlLZmZK?= =?utf-8?B?K0lINjBPZ081RjA5L2Z2c1QxUTdEM0xhV0hLM1FCTk9xM1ZOVE11OTFFTHhC?= =?utf-8?B?eGNVL3hSVlhQdDNQaCtyb09NM0NDYldXazg3L1ZpWjJXdUxqdG16YXhCd2o3?= =?utf-8?B?T29Va2tFWFYzTDBjdUJ2U2M5VnEzd1Q3VXhrTCtEV29VSWRpTnlIUjJQS2Mv?= =?utf-8?B?L0F3ZXY0NnZBb3BWNGJ4ODZvbmFoODJSdXZGZ0RwM2RHZzJhS2JMV3QzUllL?= =?utf-8?B?MkNJL2ZJM2Y1bkw4cWJmQitpVXlndUhhSDJMUEwrS1NURWRqZDFQWGdJaDhH?= =?utf-8?B?QkNKekVjRHpoYkU5ekt4SXRUcncrZ053QW1PRUw5b0oyWVJXc0p2UENtOXdK?= =?utf-8?B?REphdTIxbW1NQXV5ZWVKTWFIWmc1NnJTME5EOE52eDNOOFJZWjdkanNFYjNP?= =?utf-8?B?WEJhd3BCOGRHMEZWZ0dJWmlNTkV0TERVbm9EalBkdEloSW5ocHpiVC8ycEow?= =?utf-8?B?VVBEYlN0YlZUS2NzOUpDcjFIeDcxQm5tSWtrcldQT3VxZElmMkY5aFVFZ0Fw?= =?utf-8?B?ZUFHTVMxVEF4TFNQR1pkd2tGcUlvQUdNYU1sZDNwRk45aWdhNVlwVmhNY2Qr?= =?utf-8?B?VGhNU1hPL0M0alRCNXRjcVEzVFZMakFBQnREUTJlME5aeUVzdUt2eGwxYTNY?= =?utf-8?Q?W79E9euMPeqMerTyX9yQQgISW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 869b035d-cc4c-42fe-2257-08db98c79941 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 10:58:44.1486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nlnxrZBSXcP0Er4q568zR6BbFlJlqVLrkIqcjGcM7OYC5oXwVuOg6U+HIc7oihJvg465L7Lsakq/T3+fibHgEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7419 On 09.08.2023 12:49, Julien Grall wrote: > On 04/08/2023 07:08, Jan Beulich wrote: >> Have these in one place, for all architectures to use. Also use the C99 >> types as the "original" ones, and derive the Linux compatible ones >> (which we're trying to phase out). For __s, seeing that no uses exist >> anymore, move them to a new Linux compatibility header (as an act of >> precaution - as said, we don't have any uses of these types right now). >> >> In some Flask sources inclusion of asm/byteorder.h needs moving later. >> >> No functional change intended. >> >> Signed-off-by: Jan Beulich > > With one remark: > > Acked-by: Julien Grall Thanks. >> --- a/xen/arch/arm/include/asm/types.h >> +++ b/xen/arch/arm/include/asm/types.h >> @@ -1,18 +1,7 @@ >> #ifndef __ARM_TYPES_H__ >> #define __ARM_TYPES_H__ >> >> -typedef signed char s8; >> -typedef unsigned char u8; >> - >> -typedef signed short s16; >> -typedef unsigned short u16; >> - >> -typedef signed int s32; >> -typedef unsigned int u32; >> - >> #if defined(CONFIG_ARM_32) >> -typedef signed long long s64; >> -typedef unsigned long long u64; >> typedef u32 vaddr_t; >> #define PRIvaddr PRIx32 >> #if defined(CONFIG_PHYS_ADDR_T_32) >> @@ -34,9 +23,9 @@ typedef u64 paddr_t; >> #endif > > I find odd that you don't add a newline before/after #endif here but... > >> typedef u32 register_t; >> #define PRIregister "08x" >> -#elif defined (CONFIG_ARM_64) >> -typedef signed long s64; >> -typedef unsigned long u64; >> + >> +#elif defined(CONFIG_ARM_64) >> + >> typedef u64 vaddr_t; >> #define PRIvaddr PRIx64 >> typedef u64 paddr_t; >> @@ -44,6 +33,7 @@ typedef u64 paddr_t; >> #define PRIpaddr "016lx" >> typedef u64 register_t; >> #define PRIregister "016lx" >> + > > .. you add one here. But this change looks a bit unrelated and IMHO of > out context. > >> #endif >> >> #endif /* __ARM_TYPES_H__ */ Hmm, I think I was mistaking the blank line after #if defined(CONFIG_PHYS_ADDR_T_32) as the matching one. Which way would you prefer me to resolve the inconsistency: Add the missing blank line, or drop again the three ones I'm presently adding? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:00:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:00:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580879.909337 (Exim 4.92) (envelope-from ) id 1qTgvE-0005cg-Vu; Wed, 09 Aug 2023 11:00:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580879.909337; Wed, 09 Aug 2023 11:00:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgvE-0005cZ-TK; Wed, 09 Aug 2023 11:00:12 +0000 Received: by outflank-mailman (input) for mailman id 580879; Wed, 09 Aug 2023 11:00:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgvD-0005cA-L0 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:00:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgv6-0005xS-IT; Wed, 09 Aug 2023 11:00:04 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgv6-0002MQ-7r; Wed, 09 Aug 2023 11:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ZxNB12wNpny7r9ud8OtR3ATVISScB3GPuEO1v1d7kwA=; b=Uu5CxjfIy9b0jPd3h2Dpjiu9uG mn1x0sbFqo6JkGfJ7pYqjI+I4qNvamQbthr9NuXoAwVJ5pn6NUZXGv9TjhhgW2PLl4neRu0/2Cm+j Zg84lEHNaZPstxaFywlnu1VeH0eRpSVKI75lFqe03bDPOnwT6d1nPWv0cQ6ychuAfQTk=; Message-ID: <58ea791e-5d9e-4e60-afae-602f39316cf2@xen.org> Date: Wed, 9 Aug 2023 12:00:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] common: move Linux-inherited fixed width type decls to common header Content-Language: en-GB To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Bertrand Marquis , Bobby Eshleman , Alistair Francis , Connor Davis , Daniel Smith , Shawn Anastasio , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <652ef09f-3654-548a-37d7-bbc46cbda177@suse.com> <115e080e-ecba-4117-9d43-9888f82c8d5f@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 11:58, Jan Beulich wrote: > On 09.08.2023 12:49, Julien Grall wrote: >> On 04/08/2023 07:08, Jan Beulich wrote: >>> Have these in one place, for all architectures to use. Also use the C99 >>> types as the "original" ones, and derive the Linux compatible ones >>> (which we're trying to phase out). For __s, seeing that no uses exist >>> anymore, move them to a new Linux compatibility header (as an act of >>> precaution - as said, we don't have any uses of these types right now). >>> >>> In some Flask sources inclusion of asm/byteorder.h needs moving later. >>> >>> No functional change intended. >>> >>> Signed-off-by: Jan Beulich >> >> With one remark: >> >> Acked-by: Julien Grall > > Thanks. > >>> --- a/xen/arch/arm/include/asm/types.h >>> +++ b/xen/arch/arm/include/asm/types.h >>> @@ -1,18 +1,7 @@ >>> #ifndef __ARM_TYPES_H__ >>> #define __ARM_TYPES_H__ >>> >>> -typedef signed char s8; >>> -typedef unsigned char u8; >>> - >>> -typedef signed short s16; >>> -typedef unsigned short u16; >>> - >>> -typedef signed int s32; >>> -typedef unsigned int u32; >>> - >>> #if defined(CONFIG_ARM_32) >>> -typedef signed long long s64; >>> -typedef unsigned long long u64; >>> typedef u32 vaddr_t; >>> #define PRIvaddr PRIx32 >>> #if defined(CONFIG_PHYS_ADDR_T_32) >>> @@ -34,9 +23,9 @@ typedef u64 paddr_t; >>> #endif >> >> I find odd that you don't add a newline before/after #endif here but... >> >>> typedef u32 register_t; >>> #define PRIregister "08x" >>> -#elif defined (CONFIG_ARM_64) >>> -typedef signed long s64; >>> -typedef unsigned long u64; >>> + >>> +#elif defined(CONFIG_ARM_64) >>> + >>> typedef u64 vaddr_t; >>> #define PRIvaddr PRIx64 >>> typedef u64 paddr_t; >>> @@ -44,6 +33,7 @@ typedef u64 paddr_t; >>> #define PRIpaddr "016lx" >>> typedef u64 register_t; >>> #define PRIregister "016lx" >>> + >> >> .. you add one here. But this change looks a bit unrelated and IMHO of >> out context. >> >>> #endif >>> >>> #endif /* __ARM_TYPES_H__ */ > > Hmm, I think I was mistaking the blank line after > > #if defined(CONFIG_PHYS_ADDR_T_32) > > as the matching one. Which way would you prefer me to resolve the > inconsistency: Add the missing blank line, or drop again the three ones > I'm presently adding? I would be ok with adding the missing blank line. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:00:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580883.909348 (Exim 4.92) (envelope-from ) id 1qTgvl-00068p-9C; Wed, 09 Aug 2023 11:00:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580883.909348; Wed, 09 Aug 2023 11:00:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgvl-00068i-52; Wed, 09 Aug 2023 11:00:45 +0000 Received: by outflank-mailman (input) for mailman id 580883; Wed, 09 Aug 2023 11:00:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgvj-00068Y-Qd for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:00:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgvj-0005yO-A5; Wed, 09 Aug 2023 11:00:43 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgvj-0002MQ-3I; Wed, 09 Aug 2023 11:00:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=iMjVP/GQZiK3SrVoydRLINYyt3X0YfehMkN5udkQGA4=; b=gLB3b951or8PiyjoQMiqqmOUxK dTcMUgIoo/otkCoinJ5gAwrpg5L7waaiY8HCOigj0oEFdJPdubkNlS26j1x5txIZwJCemRwHuQAIB tfufF6yR5VIxhaLN+spL/Wz/RpC0k0axnHSasCvsuv8W1vAtY+N117X8zEfEFoZBbge0=; Message-ID: <55750925-8966-47ef-ace1-712a9467876b@xen.org> Date: Wed, 9 Aug 2023 12:00:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/arm64: head: Introduce a helper to flush local TLBs Content-Language: en-GB To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230808110739.1296-1-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20230808110739.1296-1-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 08/08/2023 12:07, Michal Orzel wrote: > Instead of repeating the same sequence of instructions to flush the TLBs > in various places, introduce a macro flush_xen_tlb_local and make use of > it. This is similar to what was done for arm32 by the commit: > dea9dddeceec8a1d68da24b14d5b2396effe555f NIT: In general, we tend to refer to commit with the abbreviated ID and the title. > > This is also making the flush sequence in enable_mmu more clear and > consistent. > > Signed-off-by: Michal Orzel Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:01:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:01:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580887.909359 (Exim 4.92) (envelope-from ) id 1qTgw8-0006ev-HK; Wed, 09 Aug 2023 11:01:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580887.909359; Wed, 09 Aug 2023 11:01:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgw8-0006eo-Cu; Wed, 09 Aug 2023 11:01:08 +0000 Received: by outflank-mailman (input) for mailman id 580887; Wed, 09 Aug 2023 11:01:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgw6-0006eP-BR for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:01:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgw6-0005z1-2q; Wed, 09 Aug 2023 11:01:06 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTgw5-0002MQ-T0; Wed, 09 Aug 2023 11:01:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=xOx+4Ax9tWrThOMr59/CmR+MJNDke0Rlr81gpb/QdF0=; b=BPYLpauOeaw4+ra7gYleAt/E/E ODNwbji6dcTkLFks8Cp1R9YG39SwFCS7rzvQivGMFclSgy7DTVzZsrJlXKTTGlQrEqhK31yY+lM2m ZzRIwmCgRSHXolId+1silHXz2dukjudH9hDzpfFiu7vqqnxe0a7VfKXo0sngxiz/TFJc=; Message-ID: <42256506-2437-4f6a-849d-df8101ec6aa9@xen.org> Date: Wed, 9 Aug 2023 12:01:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/arm64: head: Introduce a helper to flush local TLBs Content-Language: en-GB From: Julien Grall To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230808110739.1296-1-michal.orzel@amd.com> <55750925-8966-47ef-ace1-712a9467876b@xen.org> In-Reply-To: <55750925-8966-47ef-ace1-712a9467876b@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 12:00, Julien Grall wrote: > Hi Michal, > > On 08/08/2023 12:07, Michal Orzel wrote: >> Instead of repeating the same sequence of instructions to flush the TLBs >> in various places, introduce a macro flush_xen_tlb_local and make use of >> it. This is similar to what was done for arm32 by the commit: >> dea9dddeceec8a1d68da24b14d5b2396effe555f > > NIT: In general, we tend to refer to commit with the abbreviated ID and > the title. > >> >> This is also making the flush sequence in enable_mmu more clear and >> consistent. >> >> Signed-off-by: Michal Orzel > > Reviewed-by: Julien Grall I forgot to mention that I have committed the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:02:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580898.909378 (Exim 4.92) (envelope-from ) id 1qTgxu-0007Tw-DQ; Wed, 09 Aug 2023 11:02:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580898.909378; Wed, 09 Aug 2023 11:02:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxu-0007TQ-8w; Wed, 09 Aug 2023 11:02:58 +0000 Received: by outflank-mailman (input) for mailman id 580898; Wed, 09 Aug 2023 11:02:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxt-0007Jy-En for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:02:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4bbc57ce-36a4-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 13:02:57 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 16C204EE0743; Wed, 9 Aug 2023 13:02:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4bbc57ce-36a4-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:36 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable 'saved_cmdline' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. Signed-off-by: Nicola Vetrini --- xen/common/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index fb919f3d9c..52aa287627 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -28,7 +28,7 @@ CHECK_feature_info; enum system_state system_state = SYS_STATE_early_boot; -xen_commandline_t saved_cmdline; +static xen_commandline_t saved_cmdline; static const char __initconst opt_builtin_cmdline[] = CONFIG_CMDLINE; static int assign_integer_param(const struct kernel_param *param, uint64_t val) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:02:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580896.909367 (Exim 4.92) (envelope-from ) id 1qTgxt-0007KO-RU; Wed, 09 Aug 2023 11:02:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580896.909367; Wed, 09 Aug 2023 11:02:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxt-0007KH-Oo; Wed, 09 Aug 2023 11:02:57 +0000 Received: by outflank-mailman (input) for mailman id 580896; Wed, 09 Aug 2023 11:02:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxs-0007Jy-FY for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:02:56 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ad2802d-36a4-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 13:02:55 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id A0A094EE0741; Wed, 9 Aug 2023 13:02:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ad2802d-36a4-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH 1/8] arm/efi: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:34 +0200 Message-Id: <4d087a54edb3f92e9271e3d01c1abebf00d3e298.1691575243.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit the function 'fdt_add_uefi_nodes' can be defined static, as its only callers are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/arm/efi/efi-boot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index f24df2abb9..1c3640bb65 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -227,7 +227,7 @@ static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR * * of the System table address, the address of the final EFI memory map, * and memory map information. */ -EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table, +static EFI_STATUS __init fdt_add_uefi_nodes(EFI_SYSTEM_TABLE *sys_table, void *fdt, EFI_MEMORY_DESCRIPTOR *memory_map, UINTN map_size, -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:02:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580897.909374 (Exim 4.92) (envelope-from ) id 1qTgxu-0007O6-4t; Wed, 09 Aug 2023 11:02:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580897.909374; Wed, 09 Aug 2023 11:02:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxu-0007N9-06; Wed, 09 Aug 2023 11:02:58 +0000 Received: by outflank-mailman (input) for mailman id 580897; Wed, 09 Aug 2023 11:02:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxt-0007K6-By for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:02:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a849d26-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:02:55 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id B0CED4EE073F; Wed, 9 Aug 2023 13:02:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a849d26-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH 0/8] xen: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:33 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rule states the following: "A compatible declaration shall be visible when an object or function with external linkage is defined". This series deals with violations concerning functions and variables used by C code (thus not used only within asm). The resolution strategies are as follows: 1. make the functions/variables static 2. include the header that contains the compatible declaration, or add one in the header if that's not the case. No functional change. Additional notes: - other cases, such as functions/variables used only in asm code will be possibly dealt with in future patches. - functions in 'gcov_base.c' are deviated, since they are called only from code generated by gcc in a particular non-release build configuration; - variables in 'xen/include/acpi/acglobal.h' are deviated temporarily, since it's uncertain whether modifying the include pattern to be compliant with the rule would introduce subtle bugs. Nicola Vetrini (8): arm/efi: address MISRA C:2012 Rule 8.4 xen/memory: address MISRA C:2012 Rule 8.4 xen: address MISRA C:2012 Rule 8.4 xen/arm: address MISRA C:2012 Rule 8.4 x86: address MISRA C:2012 Rule 8.4 xen/arm: mm: address MISRA C:2012 Rule 8.4 x86/i8259: address MISRA C:2012 Rule 8.4 x86/nmi: address MISRA C:2012 Rule 8.4 xen/arch/arm/efi/efi-boot.h | 2 +- xen/arch/arm/include/asm/mm.h | 3 +++ xen/arch/arm/setup.c | 1 + xen/arch/arm/time.c | 1 + xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- xen/arch/x86/cpu/microcode/core.c | 2 +- xen/arch/x86/i8259.c | 1 + xen/arch/x86/nmi.c | 3 ++- xen/arch/x86/spec_ctrl.c | 4 ++-- xen/common/kernel.c | 2 +- xen/common/memory.c | 2 +- xen/include/xen/cper.h | 3 +-- xen/include/xen/time.h | 1 + 14 files changed, 18 insertions(+), 11 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:02:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:02:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580899.909398 (Exim 4.92) (envelope-from ) id 1qTgxv-00081N-Ob; Wed, 09 Aug 2023 11:02:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580899.909398; Wed, 09 Aug 2023 11:02:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxv-00080q-Ji; Wed, 09 Aug 2023 11:02:59 +0000 Received: by outflank-mailman (input) for mailman id 580899; Wed, 09 Aug 2023 11:02:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxu-0007K6-1h for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:02:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b441916-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:02:56 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 4F6E74EE0742; Wed, 9 Aug 2023 13:02:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b441916-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:35 +0200 Message-Id: <844e7bf57c2eb7b20d8b1f81a7730a7612f1b6ac.1691575243.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function 'ioreq_server_max_frames' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. No functional change. Signed-off-by: Nicola Vetrini --- xen/common/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index c206fa4808..b1dcbaf551 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1120,7 +1120,7 @@ static long xatp_permission_check(struct domain *d, unsigned int space) return xsm_add_to_physmap(XSM_TARGET, current->domain, d); } -unsigned int ioreq_server_max_frames(const struct domain *d) +static unsigned int ioreq_server_max_frames(const struct domain *d) { unsigned int nr = 0; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:03:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:03:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580900.909403 (Exim 4.92) (envelope-from ) id 1qTgxw-00086p-5I; Wed, 09 Aug 2023 11:03:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580900.909403; Wed, 09 Aug 2023 11:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxv-00085g-TG; Wed, 09 Aug 2023 11:02:59 +0000 Received: by outflank-mailman (input) for mailman id 580900; Wed, 09 Aug 2023 11:02:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxu-0007Jy-AM for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:02:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c3c12b6-36a4-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 13:02:57 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D6B454EE0744; Wed, 9 Aug 2023 13:02:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c3c12b6-36a4-11ee-b280-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:37 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow the declaration of 'arch_get_xen_caps' to be visible when defining the function. The header 'xen/delay.h' is included in 'xen/arch/arm/time.c' to allow the declaration of 'udelay' to be visible. At the same time, a declaration for 'get_sec' is added in 'xen/include/xen/time.h' to be available for every call site (in particular cper.h). Signed-off-by: Nicola Vetrini --- xen/arch/arm/setup.c | 1 + xen/arch/arm/time.c | 1 + xen/include/xen/cper.h | 3 +-- xen/include/xen/time.h | 1 + 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index bbf72b69aa..44ccea03ca 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 0b482d7db3..3535bd8ac7 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/include/xen/cper.h b/xen/include/xen/cper.h index 7c6a4c45ce..de8f385bdd 100644 --- a/xen/include/xen/cper.h +++ b/xen/include/xen/cper.h @@ -23,8 +23,7 @@ #include #include - -extern unsigned long get_sec(void); +#include typedef struct { uint8_t b[16]; diff --git a/xen/include/xen/time.h b/xen/include/xen/time.h index 5aafdda4f3..67c586b736 100644 --- a/xen/include/xen/time.h +++ b/xen/include/xen/time.h @@ -36,6 +36,7 @@ s_time_t get_s_time_fixed(u64 at_tick); s_time_t get_s_time(void); unsigned long get_localtime(struct domain *d); uint64_t get_localtime_us(struct domain *d); +unsigned long get_sec(void); struct tm { int tm_sec; /* seconds */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:03:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:03:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580901.909417 (Exim 4.92) (envelope-from ) id 1qTgxx-00005l-CI; Wed, 09 Aug 2023 11:03:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580901.909417; Wed, 09 Aug 2023 11:03:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxx-0008Vv-64; Wed, 09 Aug 2023 11:03:01 +0000 Received: by outflank-mailman (input) for mailman id 580901; Wed, 09 Aug 2023 11:03:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxw-0007K6-2X for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:03:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ca83da8-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:02:58 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id B0A884EE0745; Wed, 9 Aug 2023 13:02:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ca83da8-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 5/8] x86: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:38 +0200 Message-Id: <4a07e7bb893f3d96e007ef6ccb645eee0d730489.1691575243.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions and variables touched by this commit can be static, as they are only used within the same unit. This in turn addresses the absence of declarations that violates Rule 8.4. Signed-off-by: Nicola Vetrini --- xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- xen/arch/x86/cpu/microcode/core.c | 2 +- xen/arch/x86/nmi.c | 2 +- xen/arch/x86/spec_ctrl.c | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index 57e1eb221e..6141b7eb9c 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -599,7 +599,7 @@ unsigned int mce_firstbank(struct cpuinfo_x86 *c) c->x86_vendor == X86_VENDOR_INTEL && c->x86_model < 0x1a; } -int show_mca_info(int inited, struct cpuinfo_x86 *c) +static int show_mca_info(int inited, struct cpuinfo_x86 *c) { static enum mcheck_type g_type = mcheck_unset; diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index adc36522cc..72f3feeaee 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -87,7 +87,7 @@ enum mc_ec_type { MC_EC_BUS_TYPE = 0x0800, }; -enum mc_ec_type +static enum mc_ec_type mc_ec2type(uint16_t errorcode) { if ( errorcode & MC_EC_BUS_TYPE ) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index bec8b55db2..9fcb9c1c3a 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -149,7 +149,7 @@ static int __init cf_check parse_ucode(const char *s) } custom_param("ucode", parse_ucode); -void __init microcode_scan_module( +static void __init microcode_scan_module( unsigned long *module_map, const multiboot_info_t *mbi) { diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index c5c28300b0..104e366bd3 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -108,7 +108,7 @@ static unsigned int lapic_nmi_owner; * be enabled * -1: the lapic NMI watchdog is disabled, but can be enabled */ -int nmi_active; +static int nmi_active; #define K7_EVNTSEL_ENABLE (1 << 22) #define K7_EVNTSEL_INT (1 << 20) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index ebe56a96cd..9b8fdb5303 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -43,9 +43,9 @@ static enum ind_thunk { } opt_thunk __initdata = THUNK_DEFAULT; static int8_t __initdata opt_ibrs = -1; -int8_t __initdata opt_stibp = -1; +static int8_t __initdata opt_stibp = -1; bool __ro_after_init opt_ssbd; -int8_t __initdata opt_psfd = -1; +static int8_t __initdata opt_psfd = -1; int8_t __ro_after_init opt_ibpb_ctxt_switch = -1; int8_t __read_mostly opt_eager_fpu = -1; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:03:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:03:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580902.909428 (Exim 4.92) (envelope-from ) id 1qTgxy-0000Tf-S4; Wed, 09 Aug 2023 11:03:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580902.909428; Wed, 09 Aug 2023 11:03:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxy-0000SI-ON; Wed, 09 Aug 2023 11:03:02 +0000 Received: by outflank-mailman (input) for mailman id 580902; Wed, 09 Aug 2023 11:03:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxw-0007K6-Q3 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:03:00 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d11c6ae-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:02:59 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 6A39B4EE0746; Wed, 9 Aug 2023 13:02:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d11c6ae-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH 6/8] xen/arm: mm: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:39 +0200 Message-Id: <67163dc4bc2e44d3f70f9c49295b993663d2fd5a.1691575243.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a declaration for the variable 'init_ttbr' to resolve the violation of Rule 8.4 present in the associated source file 'mm.c'. No functional changes. Signed-off-by: Nicola Vetrini --- xen/arch/arm/include/asm/mm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 5b530f0f40..698e54aff0 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -165,6 +165,9 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated +/* Non-boot CPUs use this to find the correct pagetables. */ +extern uint64_t init_ttbr; + extern mfn_t directmap_mfn_start, directmap_mfn_end; extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:03:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:03:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580903.909433 (Exim 4.92) (envelope-from ) id 1qTgxz-0000Xq-CA; Wed, 09 Aug 2023 11:03:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580903.909433; Wed, 09 Aug 2023 11:03:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxz-0000WY-4D; Wed, 09 Aug 2023 11:03:03 +0000 Received: by outflank-mailman (input) for mailman id 580903; Wed, 09 Aug 2023 11:03:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxx-0007K6-FG for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:03:01 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4d864b60-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:03:00 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 1F8A64EE0747; Wed, 9 Aug 2023 13:02:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d864b60-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:40 +0200 Message-Id: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The additional header file makes the declaration for the function 'init_IRQ', defined in this file visible, thereby resolving the violation of Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/i8259.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c index 6b35be10f0..9b02a3a0ae 100644 --- a/xen/arch/x86/i8259.c +++ b/xen/arch/x86/i8259.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:03:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:03:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580904.909437 (Exim 4.92) (envelope-from ) id 1qTgxz-0000e8-Ri; Wed, 09 Aug 2023 11:03:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580904.909437; Wed, 09 Aug 2023 11:03:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxz-0000c3-IE; Wed, 09 Aug 2023 11:03:03 +0000 Received: by outflank-mailman (input) for mailman id 580904; Wed, 09 Aug 2023 11:03:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxy-0007K6-83 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:03:02 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4df2377e-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:03:00 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D6AA94EE0748; Wed, 9 Aug 2023 13:02:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4df2377e-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 8/8] x86/nmi: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:41 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Include an additional header to make the declarations for functions 'watchdog_*' visible prior to their definition in the file, thereby resolving the violations of Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/nmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 104e366bd3..dc79c25e3f 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:10:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:10:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580962.909457 (Exim 4.92) (envelope-from ) id 1qTh5D-0004vv-Gb; Wed, 09 Aug 2023 11:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580962.909457; Wed, 09 Aug 2023 11:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh5D-0004vo-Dv; Wed, 09 Aug 2023 11:10:31 +0000 Received: by outflank-mailman (input) for mailman id 580962; Wed, 09 Aug 2023 11:10:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh5B-0004vd-RM for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:10:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh5B-0006AR-5F; Wed, 09 Aug 2023 11:10:29 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTh5A-0002zf-Tt; Wed, 09 Aug 2023 11:10:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CxnjCleyFkTE+K7wEWE78iYHYZLHMNKCnrJLJ5Tn36o=; b=W+5/hgBgCrdIDZzNGR78VmLpsG 87TNU+EUwCXQZ4Tixg7DW/+L6PRLwMaGCBqnDRIC9xVnBlS6/umMbiaUa9AkFCoBMFwbi4PzfHPIV Oo0SFiKHAdS/D5UfAFnQMhze1McR5BqcR/HjCC0pJjooVNmti/AQ36p+j6BCe7m3Xwuk=; Message-ID: Date: Wed, 9 Aug 2023 12:10:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3. Content-Language: en-GB To: Nicola Vetrini , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> From: Julien Grall In-Reply-To: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nicola, On 09/08/2023 08:55, Nicola Vetrini wrote: > The variable 'msec' declared in the macro shadows the local > variable in 'ehci_dbgp_bios_handoff', but to prevent any > future clashes with other functions the macro is converted to > a static inline function. > > No functional change. > > Signed-off-by: Nicola Vetrini Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:12:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:12:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580968.909468 (Exim 4.92) (envelope-from ) id 1qTh7T-0005UM-UX; Wed, 09 Aug 2023 11:12:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580968.909468; Wed, 09 Aug 2023 11:12:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh7T-0005UF-R4; Wed, 09 Aug 2023 11:12:51 +0000 Received: by outflank-mailman (input) for mailman id 580968; Wed, 09 Aug 2023 11:12:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh7S-0005U9-9S for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:12:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh7R-0006Cc-0p; Wed, 09 Aug 2023 11:12:49 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTh7Q-0003DF-PG; Wed, 09 Aug 2023 11:12:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CrMdiQMaLptKwzaFPdJHhC2cjSee0EqW3qV3Mp3fBNk=; b=xTXIWhYiPuLPakdF4isNEislVp GxF8S5N5ud2kcHkwSerPp8WLk4mqf7RGP7S4o2dNf6meiLTCSdrVGdo7RiOG4TGbbad9Dra0ZqoHj daZevUnTFe74B0pGerld0Sy/RgEmNtq3kEb/tTLB6LrO/FwjaPNeP30DHsHKCHcS3sjo=; Message-ID: Date: Wed, 9 Aug 2023 12:12:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] move max_page and total_pages to common code Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 08/08/2023 11:47, Jan Beulich wrote: > Common code references both, so the variables shouldn't need declaring > and defining by every arch. While moving the definitions, add > __read_mostly (__ro_after_init would only be appropriate when > !mem_hotplug). > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, > > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -198,9 +198,6 @@ extern unsigned long directmap_base_pdx; > /* PDX of the first page in the frame table. */ > extern unsigned long frametable_base_pdx; > > -extern unsigned long max_page; > -extern unsigned long total_pages; > - > #define PDX_GROUP_SHIFT SECOND_SHIFT > > /* Boot-time pagetable setup */ > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -134,9 +134,6 @@ unsigned long directmap_base_pdx __read_ > unsigned long frametable_base_pdx __read_mostly; > unsigned long frametable_virt_end __read_mostly; > > -unsigned long max_page; > -unsigned long total_pages; > - > extern char __init_begin[], __init_end[]; > > /* Checking VA memory layout alignment. */ > --- a/xen/arch/x86/include/asm/mm.h > +++ b/xen/arch/x86/include/asm/mm.h > @@ -337,8 +337,6 @@ struct page_info > #define maddr_get_owner(ma) (page_get_owner(maddr_to_page((ma)))) > > #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START) > -extern unsigned long max_page; > -extern unsigned long total_pages; > void init_frametable(void); > > #define PDX_GROUP_SHIFT L2_PAGETABLE_SHIFT > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -146,10 +146,6 @@ l1_pgentry_t __section(".bss.page_aligne > l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) > l1_fixmap_x[L1_PAGETABLE_ENTRIES]; > > -/* Frame table size in pages. */ > -unsigned long max_page; > -unsigned long total_pages; > - > bool __read_mostly machine_to_phys_mapping_valid; > > struct rangeset *__read_mostly mmio_ro_ranges; > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -162,6 +162,8 @@ > #define PGT_TYPE_INFO_INITIALIZER 0 > #endif > > +unsigned long __read_mostly max_page; > +unsigned long __read_mostly total_pages; > paddr_t __ro_after_init mem_hotplug; > > /* > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -159,6 +159,8 @@ int assign_page( > /* Dump info to serial console */ > void arch_dump_shared_mem_info(void); > > +extern unsigned long max_page; > +extern unsigned long total_pages; > extern paddr_t mem_hotplug; > > /* -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:13:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:13:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580974.909477 (Exim 4.92) (envelope-from ) id 1qTh8X-000631-77; Wed, 09 Aug 2023 11:13:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580974.909477; Wed, 09 Aug 2023 11:13:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh8X-00062u-4R; Wed, 09 Aug 2023 11:13:57 +0000 Received: by outflank-mailman (input) for mailman id 580974; Wed, 09 Aug 2023 11:13:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh8W-00062o-12 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:13:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTh8U-0006FW-My; Wed, 09 Aug 2023 11:13:54 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTh8U-0003DF-Gn; Wed, 09 Aug 2023 11:13:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=yciX83DpxqrFk9CyGdNw2PmMRLfLuq1v2HCUB9ydSXw=; b=kk0AfUlGwtPInjlqadg6jgkDWS yUWSJTVYTKU5zuAljIhbygMXUuCPQZx/Am3+/TWPQoCNgKaLhgjn48R+EQ69dyH5xDAdsDoXEh+gf yGvGtCzloc2LTuy37Oh8YUGyGV4sxOF2VgLsrUBj0F2lg9FVbQ8qWxQphDSYM+xAiKok=; Message-ID: <94a5862e-d1c0-432b-9864-90a43945bc9b@xen.org> Date: Wed, 9 Aug 2023 12:13:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] common: asm/desc.h is an x86-only header Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , Shawn Anastasio References: <1ea0cd2e-1821-541d-068f-a18309d1823c@suse.com> From: Julien Grall In-Reply-To: <1ea0cd2e-1821-541d-068f-a18309d1823c@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 08/08/2023 10:42, Jan Beulich wrote: > From briefly going over 9062553a0dc1 it looks like the #include in what > was ac_timer.c was added there for no reason. It's unneeded now in any > event, and it is the sole reason for Arm to have that dummy header. > Purge that, thus avoiding PPC to also gain one. > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 11:20:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 11:20:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580981.909488 (Exim 4.92) (envelope-from ) id 1qThFA-0007bg-VH; Wed, 09 Aug 2023 11:20:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580981.909488; Wed, 09 Aug 2023 11:20:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThFA-0007bZ-RX; Wed, 09 Aug 2023 11:20:48 +0000 Received: by outflank-mailman (input) for mailman id 580981; Wed, 09 Aug 2023 11:20:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThF9-0007bP-GS; Wed, 09 Aug 2023 11:20:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThF9-0006WY-7o; Wed, 09 Aug 2023 11:20:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThF8-0005g2-VV; Wed, 09 Aug 2023 11:20:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qThF8-0004nh-Se; Wed, 09 Aug 2023 11:20:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=16bR4ACa46+9uZQ7/SgKau2SbNhjoov988R4IoJFMfA=; b=nqknTgkyfey8gcArpopP0c7kFF Q1sOShzPzLvyd8A9EYIzZSs/dj8SYOTWyibAYJzbdoH1oIpuN9TjXeNHW349q2xPV5ZIjhEf1KR2G SNYmZj6a+E4uiLpUOOTc/zae2v0nCVfHV5kRn8Tx+EYpYW4/dfIrgl+IQdTpHUOnyabU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182246: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a8a7c33e7dd684966d7df66058f2397995dbae31 X-Osstest-Versions-That: xen=76c243b1bc59660e3a643c17bff72fe674782564 From: osstest service owner Date: Wed, 09 Aug 2023 11:20:46 +0000 flight 182246 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182246/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a8a7c33e7dd684966d7df66058f2397995dbae31 baseline version: xen 76c243b1bc59660e3a643c17bff72fe674782564 Last test of basis 182243 2023-08-09 02:04:34 Z 0 days Testing same since 182246 2023-08-09 08:02:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Jan Beulich Juergen Gross Shawn Anastasio jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 76c243b1bc..a8a7c33e7d a8a7c33e7dd684966d7df66058f2397995dbae31 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:00:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:00:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.580989.909497 (Exim 4.92) (envelope-from ) id 1qThqu-0002w5-Nm; Wed, 09 Aug 2023 11:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580989.909497; Wed, 09 Aug 2023 11:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThqu-0002vy-KX; Wed, 09 Aug 2023 11:59:48 +0000 Received: by outflank-mailman (input) for mailman id 580989; Wed, 09 Aug 2023 11:59:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThqt-0002vs-FC for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:59:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThqs-0007Hq-UG; Wed, 09 Aug 2023 11:59:46 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qThqs-0004tZ-Lt; Wed, 09 Aug 2023 11:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ruK1AP6TCGwvuXlVRjH6SGh3dbWYvlB5t99ppl+Ov1E=; b=L2aJJUYeeO9lsTXf8cjVA4Ujpj pGNrXUz4md1hyeJFJrY690BeKKqzVlyss9flT6ZcD1t1B/M3r7M+p/Vnv4iDMlOA5QX3nE1KOSVJ9 8Vn6Bhx99qjq1LY5tT4TZe49ScI1pVsihxMlK9eeEXhdHVPBGKm2Xlwb7IVDbjoVCQG8=; Message-ID: Date: Wed, 9 Aug 2023 12:59:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20230801034419.2047541-2-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, Title: NIT: Add () after _mm to stay consistent with the rest. On 01/08/2023 04:44, Henry Wang wrote: > From: Wei Chen > > At the moment, on MMU system, enable_mmu() will return to an > address in the 1:1 mapping, then each path is responsible to > switch to virtual runtime mapping. Then remove_identity_mapping() > is called on the boot CPU to remove all 1:1 mapping. > > Since remove_identity_mapping() is not necessary on Non-MMU system, > and we also avoid creating empty function for Non-MMU system, trying > to keep only one codeflow in arm64/head.S, we move path switch and > remove_identity_mapping() in enable_mmu() on MMU system. > > As the remove_identity_mapping should only be called for the boot > CPU only, so we introduce enable_boot_cpu_mm() for boot CPU and > enable_secondary_cpu_mm() for secondary CPUs in this patch. > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > Signed-off-by: Henry Wang > --- > v4: > - Clarify remove_identity_mapping() is called on boot CPU and keep > the function/proc format consistent in commit msg. > - Drop inaccurate (due to the refactor) in-code comment. > - Rename enable_{boot,runtime}_mmu to enable_{boot,secondary}_cpu_mm. > - Reword the in-code comment on top of enable_{boot,secondary}_cpu_mm. > - Call "fail" for unreachable code. > v3: > - new patch > --- > xen/arch/arm/arm64/head.S | 89 ++++++++++++++++++++++++++++++--------- > 1 file changed, 70 insertions(+), 19 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 31cdb54d74..2af9f974d5 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -313,21 +313,11 @@ real_start_efi: > > bl check_cpu_mode > bl cpu_init > - bl create_page_tables > - load_paddr x0, boot_pgtable > - bl enable_mmu > > - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > - ldr x0, =primary_switched > - br x0 > + ldr lr, =primary_switched > + b enable_boot_cpu_mm > + > primary_switched: > - /* > - * The 1:1 map may clash with other parts of the Xen virtual memory > - * layout. As it is not used anymore, remove it completely to > - * avoid having to worry about replacing existing mapping > - * afterwards. > - */ > - bl remove_identity_mapping > bl setup_fixmap > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > @@ -372,13 +362,10 @@ GLOBAL(init_secondary) > #endif > bl check_cpu_mode > bl cpu_init > - load_paddr x0, init_ttbr > - ldr x0, [x0] > - bl enable_mmu > > - /* We are still in the 1:1 mapping. Jump to the runtime Virtual Address. */ > - ldr x0, =secondary_switched > - br x0 > + ldr lr, =secondary_switched > + b enable_secondary_cpu_mm > + > secondary_switched: > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > @@ -737,6 +724,70 @@ enable_mmu: > ret > ENDPROC(enable_mmu) > > +/* > + * Enable mm (turn on the data cache and the MMU) for secondary CPUs. > + * The function will return to the virtual address provided in LR (e.g. the > + * runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +enable_secondary_cpu_mm: > + mov x5, lr > + > + load_paddr x0, init_ttbr > + ldr x0, [x0] > + > + bl enable_mmu > + mov lr, x5 > + > + /* return to secondary_switched */ Technically, you will return to the virtual address set in 'lr'. This is 'secondary_switched' today but this could change. So it would be better to have a more generic comment like: Return to the virtual address requested by the caller. > + ret > +ENDPROC(enable_secondary_cpu_mm) > + > +/* > + * Enable mm (turn on the data cache and the MMU) for the boot CPU. > + * The function will return to the virtual address provided in LR (e.g. the > + * runtime mapping). > + * > + * Inputs: > + * lr : Virtual address to return to. > + * > + * Clobbers x0 - x5 > + */ > +enable_boot_cpu_mm: > + mov x5, lr > + > + bl create_page_tables > + load_paddr x0, boot_pgtable > + > + bl enable_mmu > + mov lr, x5 > + > + /* > + * The MMU is turned on and we are in the 1:1 mapping. Switch > + * to the runtime mapping. > + */ > + ldr x0, =1f > + br x0 > +1: > + /* > + * The 1:1 map may clash with other parts of the Xen virtual memory > + * layout. As it is not used anymore, remove it completely to > + * avoid having to worry about replacing existing mapping > + * afterwards. Function will return to primary_switched. Same remark here. > + */ > + b remove_identity_mapping > + > + /* > + * Below is supposed to be unreachable code, as "ret" in > + * remove_identity_mapping will use the return address in LR in advance. > + */ > + b fail Looking at this again, I am not entirely sure how this could reached if remove_identity_mapping use 'ret' and you call it with 'b'. So I would suggest to drop it and move 'mov lr, x5' closer to 'b remove_identity_mapping'. So it is clearer that it will return. > +ENDPROC(enable_boot_cpu_mm) > + > /* > * Remove the 1:1 map from the page-tables. It is not easy to keep track > * where the 1:1 map was mapped, so we will look for the top-level entry Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:05:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581014.909507 (Exim 4.92) (envelope-from ) id 1qThvw-0004l9-QT; Wed, 09 Aug 2023 12:05:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581014.909507; Wed, 09 Aug 2023 12:05:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThvw-0004l2-Nn; Wed, 09 Aug 2023 12:05:00 +0000 Received: by outflank-mailman (input) for mailman id 581014; Wed, 09 Aug 2023 12:04:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThvv-0004kp-2C for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:04:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qThvu-0007PM-BL; Wed, 09 Aug 2023 12:04:58 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qThvu-0005Gw-1g; Wed, 09 Aug 2023 12:04:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uaoIynkU2pY3gFRMpGc6i6B4rs+Girk9h8f0BeXw+JI=; b=2t5OdSoxAeSEm6igj+c5n66RvY LY/pCwSJVE3OuXQ9C75iqTY2SMZ6OLLFGdJw82qQAXgDl4eaV7HeHbeRAQSJuGGmnRcJa2sokfy96 eNNPrzjV9/gFpZpgeERUXfyGiufflFKzg2X8K7X4DGtafN9MwzYWyQij9f3FQnUJl7Wo=; Message-ID: <429625da-ec4f-448f-a0c4-47ca0f62f395@xen.org> Date: Wed, 9 Aug 2023 13:04:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Julien Grall References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-3-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20230801034419.2047541-3-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 01/08/2023 04:44, Henry Wang wrote: > There are two types of memory system architectures available for > Arm-based systems, namely the Virtual Memory System Architecture (VMSA) > and the Protected Memory System Architecture (PMSA). According to > ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that > controls address translation, access permissions, and memory attribute > determination and checking, for memory accesses made by the PE. And > refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection > scheme where an Memory Protection Unit (MPU) manages instruction and > data access. Currently, Xen only suuports VMSA. > > As a preparation of the Xen MPU (PMSA) support. Introduce a Kconfig > choice under the "Architecture Features" menu for user to choose the > memory system architecture for the system. Since currently only VMSA > is supported, only add the bool CONFIG_HAS_MMU to keep consistent with > the default behavior. User can choose either VMSA or PMSA but not both > in the future after PMSA/MPU is supported in Xen. So in the long run I agree that we will want to have a choice. But this seems to be a bit premature to introduce it now as the user can't select the MPU and also can't deselect MMU. Therefore, I think it would be best if we introduce an unselectable config for now. Like: HAS_MMU def_bool y This could be turned to a choice once you introduce the MPU. Also, from my understanding, we are using the prefix HAS_ to indicate if an architecture support the given feature. In your case, you will want the user to select it, so I would just name the config MMU. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:12:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:12:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581022.909517 (Exim 4.92) (envelope-from ) id 1qTi3C-0006FK-H7; Wed, 09 Aug 2023 12:12:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581022.909517; Wed, 09 Aug 2023 12:12:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTi3C-0006FD-E4; Wed, 09 Aug 2023 12:12:30 +0000 Received: by outflank-mailman (input) for mailman id 581022; Wed, 09 Aug 2023 12:12:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTi3A-0006F1-WB for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:12:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTi3A-0007Wf-GB; Wed, 09 Aug 2023 12:12:28 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTi3A-0005h2-9U; Wed, 09 Aug 2023 12:12:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=klAsC5S3XnRoWUoZy1fqMQRxT5h82QeX36vv+wiklAA=; b=WtArLd9HxRe2oPCrqGdb6Xc7w2 vbBoz7hFIH/tlddA4MShKrziOUp6Nci0DfPSZeoooW+ai0bbMV49ntHfszsXuONJcURRoK5MEUwAz 1DjgDUqOSRd06Uhn0moSYyXdDF0Jc5ZsVPv9pNOsSAJh6jJ+ubIpgfpBRTcKDVeCGJMg=; Message-ID: Date: Wed, 9 Aug 2023 13:12:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-4-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20230801034419.2047541-4-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 01/08/2023 04:44, Henry Wang wrote: > From: Wei Chen > > We want to reuse head.S for MPU systems, but there are some > code are implemented for MMU systems only. We will move such > code to another MMU specific file. But before that we will > do some indentations fix in this patch to make them be easier > for reviewing: > 1. Fix the indentations and incorrect style of code comments. > 2. Fix the indentations for .text.header section. > 3. Rename puts() to asm_puts() for global export > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > Signed-off-by: Henry Wang With one remark below: Reviewed-by: Julien Grall > --- > v4: > - Rebase to pick the adr -> adr_l change in PRINT(_s). > - Correct in-code comment for asm_puts() and add a note to > mention that asm_puts() should be only called from assembly. > - Drop redundant puts (now asm_puts) under CONFIG_EARLY_PRINTK. > v3: > - fix commit message > - Rename puts() to asm_puts() for global export > v2: > - New patch. > --- > xen/arch/arm/arm64/head.S | 46 ++++++++++++++++++++------------------- > 1 file changed, 24 insertions(+), 22 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 2af9f974d5..b29bffce5b 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -94,7 +94,7 @@ > #define PRINT(_s) \ > mov x3, lr ; \ > adr_l x0, 98f ; \ > - bl puts ; \ > + bl asm_puts ; \ > mov lr, x3 ; \ > RODATA_STR(98, _s) > > @@ -136,21 +136,21 @@ > add \xb, \xb, x20 > .endm > > - .section .text.header, "ax", %progbits > - /*.aarch64*/ > +.section .text.header, "ax", %progbits > +/*.aarch64*/ > > - /* > - * Kernel startup entry point. > - * --------------------------- > - * > - * The requirements are: > - * MMU = off, D-cache = off, I-cache = on or off, > - * x0 = physical address to the FDT blob. > - * > - * This must be the very first address in the loaded image. > - * It should be linked at XEN_VIRT_START, and loaded at any > - * 4K-aligned address. > - */ > +/* > + * Kernel startup entry point. > + * --------------------------- > + * > + * The requirements are: > + * MMU = off, D-cache = off, I-cache = on or off, > + * x0 = physical address to the FDT blob. > + * > + * This must be the very first address in the loaded image. > + * It should be linked at XEN_VIRT_START, and loaded at any > + * 4K-aligned address. > + */ > > GLOBAL(start) > /* > @@ -535,7 +535,7 @@ ENDPROC(cpu_init) > * Macro to create a mapping entry in \tbl to \phys. Only mapping in 3rd > * level table (i.e page granularity) is supported. > * > - * ptbl: table symbol where the entry will be created > + * ptbl: table symbol where the entry will be created > * virt: virtual address > * phys: physical address (should be page aligned) > * tmp1: scratch register > @@ -970,19 +970,22 @@ init_uart: > ret > ENDPROC(init_uart) > > -/* Print early debug messages. > +/* > + * Print early debug messages. > + * Note: This function is only supposed to be called from assembly. I realize the wording is just a copy of what I wrote earlier on. But I would use 'must' as this is a stronger than 'is supposed to'. This can be dealt on commit if there is nothing else to change. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:19:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:19:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581028.909528 (Exim 4.92) (envelope-from ) id 1qTi9c-0006tk-8t; Wed, 09 Aug 2023 12:19:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581028.909528; Wed, 09 Aug 2023 12:19:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTi9c-0006td-4h; Wed, 09 Aug 2023 12:19:08 +0000 Received: by outflank-mailman (input) for mailman id 581028; Wed, 09 Aug 2023 12:19:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTi9b-0006tX-Ai for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:19:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTi9a-0007fK-S1; Wed, 09 Aug 2023 12:19:06 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTi9a-0005o5-Fj; Wed, 09 Aug 2023 12:19:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rh+puutyKeAjoWJBiHzu9Jn5y5g+2e2Vl5kbP9d2D5g=; b=BaycMp0q/89eqdhEb1Zr9Erm31 IK9BM2U2JUjFsDsfyrG4lRL4U5XJiNN96ED8L2cGQBYapDz4EAPuYeyuyrLbzxGX3TtFdU1jSywci H9qaTJBvr7dD5/8oVhLHirZjtNggjUMiSWUQxDfLagemca1jhuX71Ekx6MYcWMtpiCO4=; Message-ID: <83022ef2-dfd1-438c-b8e8-2f1bf0866918@xen.org> Date: Wed, 9 Aug 2023 13:19:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/13] xen/arm: Move MMU related definitions from config.h to mmu/layout.h Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-6-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20230801034419.2047541-6-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, On 01/08/2023 04:44, Henry Wang wrote: > From: Wei Chen > > Xen defines some global configuration macros for Arm in config.h. > However there are some address layout related definitions that are > defined for MMU systems only, and these definitions could not be > used by MPU systems. Adding ifdefs with CONFIG_HAS_MPU to gate these You haven't yet introduced HAS_MPU. So I would suggest to write: 'Adding ifdefs to differentiate the MPU from MMU layout will result in a ...'. > definitions will result in a messy and hard-to-read/maintain code. > > So move MMU related definitions to a new file, i.e. mmu/layout.h to > avoid spreading "#ifdef" everywhere. AFAICT, you are moving all memory layout definition in a separate file. So I would say it explicitely rather than using "MMU related definitions". > > Signed-off-by: Wei Chen > Signed-off-by: Penny Zheng > Signed-off-by: Henry Wang With the comments addressed: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:28:41 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:28:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581034.909537 (Exim 4.92) (envelope-from ) id 1qTiIj-0008Q6-2Z; Wed, 09 Aug 2023 12:28:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581034.909537; Wed, 09 Aug 2023 12:28:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiIj-0008Pz-00; Wed, 09 Aug 2023 12:28:33 +0000 Received: by outflank-mailman (input) for mailman id 581034; Wed, 09 Aug 2023 12:28:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiIi-0008Pt-4d for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:28:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiIh-0007wa-HL; Wed, 09 Aug 2023 12:28:31 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTiIh-0006A2-Aa; Wed, 09 Aug 2023 12:28:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RVSUjH3ciftGt3wM0Uv3ufgpFySL2jxRjB74OhNJa7Y=; b=tT4G2k4bUse8r8D/OJ+p68TVgX 8AAZW5pUMJ2AcemG2LopJC+lZToa0W7mcXw/1Zh/RhDjg2xY5pFh+QYvYrlZ+WgvUXVXKmHOUK65U 8tt3KaFqk7cDqn/pD2KOUoGHLuhuVkH/O1fjOmgoknec/vtlGfH+GyGQ2AmdAWKsDOkc=; Message-ID: <1307da1d-5d56-4fe1-932a-c384323264ec@xen.org> Date: Wed, 9 Aug 2023 13:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables() Content-Language: en-GB To: Henry Wang , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-7-Henry.Wang@arm.com> From: Julien Grall In-Reply-To: <20230801034419.2047541-7-Henry.Wang@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Henry, Title: NIT: It is more a fold rather than move. On 01/08/2023 04:44, Henry Wang wrote: > For the > future MPU support work, the early UART mapping could then be moved > in prepare_early_mappings(). I would drop this sentence as this is more related to the future implementation of MPU rather than this patch itself. > > No functional change intended. > > [1] https://lore.kernel.org/xen-devel/78862bb8-fd7f-5a51-a7ae-3c5b5998ed80@xen.org/ > > Signed-off-by: Henry Wang > --- > v4: > - Rework "[v3,12/52] xen/mmu: extract early uart mapping from setup_fixmap" > --- > xen/arch/arm/arm64/head.S | 1 - > xen/arch/arm/arm64/mmu/head.S | 50 ++++++++++++----------------------- > 2 files changed, 17 insertions(+), 34 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index e4f579a48e..56f68a8e37 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -275,7 +275,6 @@ real_start_efi: > b enable_boot_cpu_mm > > primary_switched: > - bl setup_fixmap > #ifdef CONFIG_EARLY_PRINTK > /* Use a virtual address to access the UART. */ > ldr x23, =EARLY_UART_VIRTUAL_ADDRESS > diff --git a/xen/arch/arm/arm64/mmu/head.S b/xen/arch/arm/arm64/mmu/head.S > index b7c3dd423a..6bd94c3a45 100644 > --- a/xen/arch/arm/arm64/mmu/head.S > +++ b/xen/arch/arm/arm64/mmu/head.S The second paragraph in create_page_tables() now needs to be dropped. > @@ -231,6 +231,23 @@ link_from_second_id: > create_table_entry boot_second_id, boot_third_id, x19, 2, x0, x1, x2 > link_from_third_id: > create_mapping_entry boot_third_id, x19, x19, x0, x1, x2 > + > +#ifdef CONFIG_EARLY_PRINTK > + /* Add UART to the fixmap table */ > + ldr x0, =EARLY_UART_VIRTUAL_ADDRESS > + /* x23: Early UART base physical address */ > + create_mapping_entry xen_fixmap, x0, x23, x1, x2, x3, type=PT_DEV_L3 > +#endif > + /* Map fixmap into boot_second */ > + ldr x0, =FIXMAP_ADDR(0) > + create_table_entry boot_second, xen_fixmap, x0, 2, x1, x2, x3 > + /* Ensure any page table updates made above have occurred. */ > + dsb nshst > + /* > + * The fixmap area will be used soon after. So ensure no hardware > + * translation happens before the dsb completes. > + */ > + isb The DSB/ISB is not necessary anymore as you are not modifying live page-tables. So I would prefer if this is removed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:29:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581039.909547 (Exim 4.92) (envelope-from ) id 1qTiJx-0000Wk-CI; Wed, 09 Aug 2023 12:29:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581039.909547; Wed, 09 Aug 2023 12:29:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiJx-0000Wd-9b; Wed, 09 Aug 2023 12:29:49 +0000 Received: by outflank-mailman (input) for mailman id 581039; Wed, 09 Aug 2023 12:29:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiJv-0000WR-PM for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:29:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060f.outbound.protection.outlook.com [2a01:111:f400:7e1a::60f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6cc5f5b0-36b0-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 14:29:46 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8792.eurprd04.prod.outlook.com (2603:10a6:10:2e3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Wed, 9 Aug 2023 12:29:44 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 12:29:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cc5f5b0-36b0-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U7sGYmwSz5Wa0LUVrmfr0xxJ7Ngy/9ayMytBl/nykxdwou5fWxq52x8g+y94tMN+vvXvXG9v+aVQ3FwNrDhXb4YnzFS/LsDs3CaTv7Jj3I56a5iw/wSUKoiTVBt29KA7fRlIQ01gWGoZN/nIgG/TRuhtB/YjgQaWeVxJcWcpS2IaqN2iLMfXmow/XMXMt7e2TT+4C31sANGTlMkdwTd8wljSHSQZ9SAgIe0ZMv8oLRNa3Q2kZqPowCGZR1ORIDxA/mZGVYwN6wo34pG0vNBiveioj38j2H0+RYr6bBV52QHTko/wZXdRvJTXsNR3jgFTmaMR6RCp3eO5GQR3qM3MRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LELKa6p2/OKxQTGmguNp2vkQIbLmcSv+nDELPfyHX3Y=; b=gGJ82yNCR2LEMpVVcCFkfrGA6drxkegawsZ6Wg6HtZZpujN111RzldSRXQUTwZL5ZxXC9bAf9Nbrie79xEcRGgmf7eDWBTIUMvXnSgWY9qPVLX5xxtBG1m1U4QQmjVhZ4hpIzpmZ/m2/YefIhwEoj6d1d8wx+/M1fBmz8OG6fAEO1FmwYeV7HT3B/csq1nXTqiNMjbAJki7i2BPQd4qLiW2P2DW/UCxBALAZyJSzDfyUYd6HuSbp/sG/6Qkpch51gAMum23fjp7nqjgBq8Z/WlmbyvHCWQWjDmnE/8ZpwHKW76F+NHk9vkew9pXfBuN5USJHH9C+cjUCdcZuBHZZ7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LELKa6p2/OKxQTGmguNp2vkQIbLmcSv+nDELPfyHX3Y=; b=bleYAoSlVQPUrrr/NnBT18l+lb1dnHOxHPSScWhx+9Izw912Kv7o48p1+vWWsPtS1CwUcp8kCNChNXCeah42/tgB876+LTbu/NkoGSlxqaVWDLfQTl/vO82WpBzwbV0yNpq+DqUK84AMdFr8znD8R5TkVD88cO5KLADlcUUKrHsgJ6R3IYOgvBBTdxaaEqGbu4tu2Uak/wOAXJVLYmMyTeAFLPmVyFmiZtNVEf57WENpMqKfe1CP9iWYKldCMweUbszgMeXNV6UpuNWqcLSu8YVEnF1Wpu7FKaDqPcyn1VAO83A2Y51Gloiv/nIKpWkYiAxp2O/TywYCu1+rekc2yQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9c310f74-e6c3-f86e-8044-0e078ad00254@suse.com> Date: Wed, 9 Aug 2023 14:29:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: implement cpuid() in terms of cpuid_count() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0053.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8792:EE_ X-MS-Office365-Filtering-Correlation-Id: ae78f145-0cc8-475b-8e72-08db98d44f97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6lkCR7uR07mgRP4dtBnkED1EVZQ9/jTzt8NvNexrIrAeu4xLnmzhtCtSEvW2XNAh9FjDc+uB8jCkiza8lJZwuXBOhbv1S8psu/SSR0ejJHv/vyYzj9woCmNisMa+wWivxOoUHJuzyLyHEwHmTfLhqrF/iMO5G/J5vUR+8n74Rq2lNtF1QbMFzpiJXZaRM+hd6gGYutGv/KSYtVqzmk1YQA4q1pI/Qy1yllktP3/1AhZJvGLk8q0VlEgH49yF5V0D8tX4nZiNFXqhKb86iU8ZaxpS3WQ3wdbT1S1V0BSeCdrMQdNoFqqfcb0iAc4dswfKzFx3NZfcAETVSkgtV6GdIWoS7veXvlta9Va2C4X4aWcei8F1ADv2uCCZkVqXVnVqhamokf9NGEU/IwmBUmrCsRvll+qzj//Cr9BnCmLvTZbnfL66QGDcTvCRhLwRZatiULgWjG6OW2FugxxZ0vwgGE7v6SItpiJ/IocMYVsJHqRZ0/+W1HQcs0pKbjym6bhFxkNzmYnLTYaakF+jZgL/PkduyZl5vh7lTK2lzx2k0mpSxde6Jva1MWde0P2s31SWDPZoo21INX0brjxHI6ib+tFXlHrI1ckz6OpVm31zbRn7nvuXUBh9rTYmhWJCYF4nqHnYsdEYVGtowKc32nGbjw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(396003)(39860400002)(376002)(346002)(1800799006)(186006)(451199021)(8936002)(8676002)(54906003)(478600001)(5660300002)(31686004)(41300700001)(6916009)(316002)(4326008)(38100700002)(66476007)(66946007)(66556008)(86362001)(6506007)(31696002)(26005)(2906002)(6486002)(36756003)(6512007)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWt2cGN0bU9nMGZBUFlHOVg3d2FtNzkrU3ZVUXFyMW0xeEg0RnRQZDJtY09a?= =?utf-8?B?UXBXS1VaZTQ5VmpLTWx2eituYTU4RFNrVXFJM3hRdjErMHl6NkUySjZaVjF2?= =?utf-8?B?bStvYS8xWjBtYkhCQ29LRG5VY3hzQUY4VzFHdjEwU3h5c1NLSWNCcmVGeTJ3?= =?utf-8?B?UHVHeUt2azdnWVNDWXZML2w1azVGY3NHZzRUV1hOWlhQY2U3L1lhMHZwSGtY?= =?utf-8?B?K0w4UGtsQWhXc3Y4c2RPQ0JhczlWNDE5Yk5BVzc4WlpFWGlTSDRkNDBwbkN4?= =?utf-8?B?eGorUmxKUHlhU2MwZWtLYU16dUxhY0JBSG15RzFpZ1dPRXkybitEM2pXWlVU?= =?utf-8?B?TUFNd0M1SEZ5WjA0NngvV3ljKzJEOW42cEdRVFBKRXdrYTl0L09EeHVySVpB?= =?utf-8?B?Z1VwdFJhWHZVMDNYOVVDYktTVXpyUnBBWW5ZNnB4UjdkRDdiUkh5UVBYeE5i?= =?utf-8?B?Y1hKdWpCYXlNZUtnODVkK0htUXM1R2dwREczSE1RU2pKcm8rT2RBSzkxSXN2?= =?utf-8?B?S0F6OGFVQzVnRGx3ckVsQlZtcVB5WnVuVDJZdFEzUURZMUpOb1FiYTNMcHFn?= =?utf-8?B?eFFqM21Ka0M4TDd0ZWZxcFNZdHQzYi9FSkdrQlVVSGROWVI1SWdEOCtkNDJj?= =?utf-8?B?NXFhK2lFbU5KNDFkTDZxV29IUTQ0QkVYS3k1dGl1VnNUYnA3ampvUnV3MTRV?= =?utf-8?B?bjFsVUdROE9FOGNzSHZpVjRxeGVGcTVaRmVZTDRFZXlQeGc0YUhXSjlleEVn?= =?utf-8?B?b2VYT2I0V3NVUEF3b0lsRGY1RGhGbVNmUTVMM214T3hBOHJsbnJmdWMwMGN2?= =?utf-8?B?RVJYem1uOG5ROURsd0ZManRLSXl2alBVc0pvNU9hZWxURW1EL1FCWXVGeHRW?= =?utf-8?B?VkRROTVEWkZ5R2d0cjZ3RmFBNGV2d01RQStuM0JDY2ZiYW1oUVpIV1Q4M3dk?= =?utf-8?B?T25KUG1tdExSdUdCMDlsUHNZd2h1bGN1eCt0WFpBbEdveTZwNnVhUmVlN2Y1?= =?utf-8?B?QlBLM25Da1N2TUUwMnFoTjIrMHp0RUdBZ0JmM1JxR2QrR1NtcmIwL0RKc2Rv?= =?utf-8?B?emt1U3dXdjY5SFZtdFAwOUhTRzNVUmNtdXQvbkZBMDFMTWZCb2pRSXYxK0lr?= =?utf-8?B?bERIWEhYQWszOFM4SG5XazRhMFY5OXRTZGtsSmUwV0FzZ3VkbGdxYUxRTjFz?= =?utf-8?B?aDA4SVpyajVBNk5kSFpmZzZRekpieVFoR0RmSXRGSWNla2VLa3ZzQmo4SFh6?= =?utf-8?B?aGFhWVAxaFFXS1hLRkVpK1M1eFJ2MDZ5RExwd2hXTm5Xa0R4cGxkSkN0VzND?= =?utf-8?B?RTEra0tVVmhhUmhYMjFiaFFvNUQ3UWIzVE5ndVIreDZpQkF4WlJtL0FWaGZo?= =?utf-8?B?LzRnT1MxMEpyUE9lL09lSnFYZ2MzVlNFSUk2TEUvSVRkckxsYTBSMHdWeFp2?= =?utf-8?B?cEUyUGd4czlsSGZ2NnBPMlhOMGRMV1c4amtQSUFlMVZOQncxQ1lwLzUyVWV3?= =?utf-8?B?dkhQTTNhSXUxWEh3MENVbk5STll0THd4djA4QkVBNUlESDBBVGtITnJvZE1z?= =?utf-8?B?MHNQRmFSUDdlcEIrZGNKNzBiR0dGRjMrQkhZeCt0SGRRRmJBZktWVXQxbWUz?= =?utf-8?B?MWFKaXptVVZNeXNSYnpZL3c4SitleHFHWHdjR21zSGdodVFxc2ljVE9UM211?= =?utf-8?B?UXpzSk56VFYwdDNFNFBsMkdnanhrbUllWTVudjliZ0orL1pINGVsVGlSd21v?= =?utf-8?B?RWJsdnJGWkFTdGdqRUNFbkN5Vm5PbWhKYU5YVjd2SmN6L1JOV1RIZGxyNzRH?= =?utf-8?B?R1hsTWpPT3kwQy8wb0xPU21NUTY5ZmJJa1ZwZmFOd0pnbSt0V3lEZzgyMlBG?= =?utf-8?B?WFhGZTFKa093U2RVMGZaSUplRi93V0lTNTZ3eWNxNnhCOGJxODlOcXpGVFV2?= =?utf-8?B?Y2VxeHZkOS9lNURJTzRteVl3eVBnQWtsSFdrbmZ3WXc0NUV4M3pHV1VlN0J0?= =?utf-8?B?N2dQY3VNdlVMTWlsRmg3bzJ3SnhSb1BrTlEvY2E4OVpLYjNsNE9JYWk2K0NB?= =?utf-8?B?TmpJbFN6V0VlZXVkSFkrcEFJVUU5ditkOGtzajVvQzAvbDZ1SU8wZjBwQzJO?= =?utf-8?Q?gg9uGywJpYvK7WO1YLz+7zeOU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae78f145-0cc8-475b-8e72-08db98d44f97 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:29:43.9984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lhKpWYnX0TH78yS0snOnl5XE8xC02Qny6um8pJ51NbRAsaQCRtNxHOid/KlSXtJhRSPfugiAM63iAnLzoz+Jnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8792 Since as a bug workaround (likely inapplicable to any 64-bit CPUs, but it probably doesn't hurt to keep this) we clear %ecx on input anyway, we can as well fall back to cpuid_count(). This allows getting rid of four risky casts and makes things type-safe. The latter aspect requires two type adjustments elsewhere. While adjusting init_intel_cacheinfo(), convert three other local variables there as well. For the struct cpuinfo_x86 change it is relevant to note that no 64-bit CPU comes without CPUID support, and hence cpuid_level is never set to -1; the comment there was simply stale. No functional change intended, yet of course generated code isn't identical. Signed-off-by: Jan Beulich --- It may also be interesting to see whether this addresses issues Coverity recently spotted (in error), in spec-ctrl.c:print_details(). Andrew considers cpuid() being (just) a macro as a possible reason. I'm willing to switch to an inline function, but I chose the macro route because this way it's less code (and hence less redundancy) overall, without any loss of functionality. --- a/xen/arch/x86/cpu/intel_cacheinfo.c +++ b/xen/arch/x86/cpu/intel_cacheinfo.c @@ -172,8 +172,7 @@ void init_intel_cacheinfo(struct cpuinfo c->x86_vendor != X86_VENDOR_SHANGHAI) { /* supports eax=2 call */ - int i, j, n; - int regs[4]; + unsigned int i, j, n, regs[4]; unsigned char *dp = (unsigned char *)regs; int only_trace = 0; --- a/xen/arch/x86/include/asm/cpufeature.h +++ b/xen/arch/x86/include/asm/cpufeature.h @@ -23,7 +23,7 @@ struct cpuinfo_x86 { unsigned char x86_vendor; /* CPU vendor */ unsigned char x86_model; unsigned char x86_mask; - int cpuid_level; /* Maximum supported CPUID level, -1=no CPUID */ + unsigned int cpuid_level; /* Maximum supported CPUID level */ unsigned int extended_cpuid_level; /* Maximum supported CPUID extended level */ unsigned int x86_capability[NCAPINTS]; char x86_vendor_id[16]; --- a/xen/arch/x86/include/asm/processor.h +++ b/xen/arch/x86/include/asm/processor.h @@ -131,13 +131,8 @@ static inline int cpu_nr_siblings(unsign * clear %ecx since some cpus (Cyrix MII) do not set or clear %ecx * resulting in stale register contents being returned. */ -#define cpuid(_op,_eax,_ebx,_ecx,_edx) \ - asm volatile ( "cpuid" \ - : "=a" (*(int *)(_eax)), \ - "=b" (*(int *)(_ebx)), \ - "=c" (*(int *)(_ecx)), \ - "=d" (*(int *)(_edx)) \ - : "0" (_op), "2" (0) ) +#define cpuid(op, eax, ebx, ecx, edx) \ + cpuid_count(op, 0, eax, ebx, ecx, edx) /* Some CPUID calls want 'count' to be placed in ecx */ static inline void cpuid_count( From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:43:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:43:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581047.909557 (Exim 4.92) (envelope-from ) id 1qTiXC-0002zl-NG; Wed, 09 Aug 2023 12:43:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581047.909557; Wed, 09 Aug 2023 12:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiXC-0002ze-Kg; Wed, 09 Aug 2023 12:43:30 +0000 Received: by outflank-mailman (input) for mailman id 581047; Wed, 09 Aug 2023 12:43:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiXA-0002zY-UI for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:43:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 55a7a6a4-36b2-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 14:43:26 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8966.eurprd04.prod.outlook.com (2603:10a6:10:2e1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 12:42:57 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 12:42:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55a7a6a4-36b2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMZKrwULhP1vU7HwgyLMZOEqxyHHk5PsSMSmnbOno3ZUmvomHCRMwksCIM4x7iWYCJZ+DEtAS607yxONVj4RheE9o87vzOMACPvhU6L4SXzCXnCQyh3sPvZ60H1s7BrY3Mx/gkNyJiDbnGYj5iHwec63ulA/ZBlzUW5VgXWYYEjFtWA6RCtOxf2pzyWqFaNYjFzYyyS1P12hKT2e50OYCyZkPPIpke2MjBsKAc2scygIVC70DqKIZRwoPlqdMh5fvloX5KdeftErCk8oAOi/7nTWzyWm0dRJF7ppmM4YESw+hdCiC3+BXhQY6wvoBSXq0WgSyads8XMiqe31spFxLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qDCvP9gDz4OwFGJD9WlNakVlIXibVVDA0fVaxyA6IxA=; b=gO4vFJqruKJjqr2ChuEHntO1f93043HMBGDADAZ2tC553AWhJxAT0M+QQvFSjENgCUNuewZWSV9jsSGPMmAJMVf7taXRDVdqTwupGmtGdl2Kz8/UALFzYAphV9sWHQDUmoXOFCrtBBXFHReLMpPEW94nPIh0UVNEvBk0V3m+zvrHxt+TZh+WWElYJsldmtno3uJOA+HVtXU4Vs4enX03cUQvlETelZ9FG/M3+6uJknK2BLzTANqgYPo2+Myncq1x8nsKcKBAqTKjTdRzCi9YndpTImSEGWWdpwFxHVFRXp4mBwSaukor+AcNx5vAiPHb0TXCV4CpNI2TPjtQPNm+jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qDCvP9gDz4OwFGJD9WlNakVlIXibVVDA0fVaxyA6IxA=; b=CuazNH8zkKJ1s87Sm3CABabz/adOUdgpxBnrrKNU4JiqqGDEmF8GPPCBGXhCEspBlWAq5uVtxPsYQt7TMpU8yUJKF5pqhllwS8u554YCeRBOFKjZV8PlXE7vE8tbCvcrS4UADILvam0pCF5PCL+bqU7JlaTvDVg7o60eJm6/gNDOtUBnVSC0c7eN6fO+wfazPlCniCqf+I5nOylWb6r47W3JqEOD898KF6Ms3U5lfJKGDeWES6vqidSVq/OfcCH0glsBUdQspA1rmZJZEgySmu4rk7UTnPvMoKvjpTBzMNNGsm+ru4fTpmepZjBIthzxSCc+Mmaw4HK5Gwi1EltJyA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 14:42:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8966:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c858806-d82b-48aa-e3b5-08db98d628a7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jmS5l2hIgTGTcCtgJbuL0ifWUQg81//9Uywe6zXykvfOTOChCJbTY2pcx1rTa3xXukEVw+8hR5YDlpIWSN0Xef1WxLfye2M4lVPkAlaLXc7/hmbxNT8AwMQpQs9KjhKFRx8RwbD8pPDNq+8+8DfnWGiDX1A87xcK+b0hyAGlOeum+Q5VD7Su8um656zV2z/tq8RTf+iyMG9Mx3tIu4Ua7eCY1zzbjzmKYVRHfDAAJb8uaf0bVsy/KbqJlVL07A296rbbhlzYYoKj+8thfFdv9DcNwHmwkxPQ8SbYpsi0PUSpsHI8gIM99uNu1NQQLT+X1WzB7TSQYEuh3cN2ZMexaSVWIkP4xPzYkOJJ2IN2FrA5XtFpGGWiQOkQ9psMuXTZdeKN+lARKX/kpj5THUHw9D+gMhcaKEClJPbsjEKCI7JhenEnbTNEWiSq51X27TexS+yXZx+Yjvsvu9fORgsD2UYisbvEW82JLqvQeJ1NBglKS2xJWWu9TLP5kbf9FjhGUNptD4+GC55HlC+usYu63gDinuX+K4iUp7IKRfJAQvxSY0ewVJXYvFwHbpKwkU90Zxi28O9fD+fzVEWwzRd1nanLTE4Tex4owtcPIKuwrc6oBmrhZZW2+0pJXOzjJBqWHjEgleDtQMG8REHp9NIFDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(136003)(396003)(366004)(39860400002)(1800799006)(186006)(451199021)(6512007)(6506007)(26005)(53546011)(66899021)(66556008)(36756003)(38100700002)(54906003)(316002)(7416002)(86362001)(5660300002)(4326008)(2906002)(66476007)(8676002)(31696002)(6916009)(8936002)(66946007)(41300700001)(6486002)(31686004)(478600001)(83380400001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzg4RXBUZWdzWC9wdlhmUGFzUW9BM2JwYm92T1ZLK1FKeStPZFhkRis0Wjgr?= =?utf-8?B?NkRsR0RSRGIwVmZxMksvUDJUSndranpZWjZOQTNMWnRPT29lRVdTbmQ1WURi?= =?utf-8?B?TkJ2S0J5eWxTR3BHcUQvWmFrcEpuczAyeVByaFhhZ2t5engxOVgwZFJHa2lJ?= =?utf-8?B?R1M3SGtMd2Q4K2ZVNEpmMExjdlQ2K0tJK2VseHlSWEdqQlJ5QVo3MjRlWUR0?= =?utf-8?B?bmR3S1VSYjBic3RIWENsNWRrcFJqZmlSUzQrNzh4NUJyREFNM1RtdjRlbTVX?= =?utf-8?B?WHh5ckw4OS90dGNFcDhxOG1LUG5yNHoybUdJOGVIK3MwMjRHVUwvVzJRSkc4?= =?utf-8?B?VnBNUWRYZk1mbDNxaG1ORzdwZVdaWUhtdGIraTFFbk5wTUM3OHRPNkFiQ2tw?= =?utf-8?B?aGUrZDVSTS9TWVNHblRlU3VxQlZXSE9SbktlTXl0ckhXZXdLRVNkRWhHSzZG?= =?utf-8?B?VkdNMno1WDFHc2xmZXBBL1V0M0Jjb0UvbWlwQ1pudFR4cjkvaDV4SGNRK1l0?= =?utf-8?B?YThzc3UwME5CazFNSTJ4QjErWS81anpzakNkMGEyYmhyRDZ6OU5lYXdQZlZH?= =?utf-8?B?dmNCbjh2d3lYdnRGd29xbzgyQWFtczNpOU9GanZjM2R4OEx3Z2tnbzd4aTNu?= =?utf-8?B?OG5CZWZBeU1aQVdnd1NkREtUSWRCTjJ2cUJoZkpCcmRLTUtnZ3J6SlIrZzJS?= =?utf-8?B?N0c4b3JKNGtNY3JDMXlsdmc4L3BQdU51MGtFOTlQakV6NGFLWHBaZVVJYzNI?= =?utf-8?B?SjRBVDlSNmJOMUMweVlUb3VDVFh6STNtQUJHV2htd1N1YkdLVisrdW9oVHBR?= =?utf-8?B?dEZIaWFkS1Z3VERtWURHTncrZnJqVUJOU1lpVExQMDR4TVNyRnBBUHZsaVRG?= =?utf-8?B?OW5ZU1RXeDl4STkySFVNSklrMG1UTkNrYm42aW9BaExRRkk1US9ZN2owRWZE?= =?utf-8?B?bnJITWdyZWJBTExnK29zNzBZUWt1SWpOcTUzaUpWQW9yOTRqaXBqSW5YejBw?= =?utf-8?B?MGFWbklneEJIN0FBcGI5VHpRUWxUcXp6VDlRUDJjUnpyQkZrc1VHZ3NSYzRZ?= =?utf-8?B?Zkt5bFp4dVRCeWJKd0toOU1tNzZ6V1hTNThRSjdZeGhCV0pOajlTVmZZMHpo?= =?utf-8?B?TVQyUDJrNVdmaDVveSs3Z2NVODR0V1kzdzduVXlJa3JHMGVzMi91c2x5WXRI?= =?utf-8?B?ZDBJK0ZrOHNWeUZYaTA5R0JuMWZtUUFCUnJOcFI2WXVmeHhNK290eGVBRTc0?= =?utf-8?B?QTBCaEZJVXE1SmtCcUxHbWRCTWJpYm1hMlB3MVlyL05zUHJKTDFQRk1WRUdr?= =?utf-8?B?VmxFTnoxREJoa1dETGVBNmNLZ1pMWjBkZTFIRkxYUGdIMG0yRlc1ajh5VlZN?= =?utf-8?B?dktYM3U3ajZmemcvUGxMM2o5b0Q3OVZodUwyOWUzK2l0dk80dFAzd0dlQnpX?= =?utf-8?B?NllKWXFCRmNGa25IY1Q1QTVFcDE2U0p0Y3FXSlZkTUJONndDOFVLRzYydWFW?= =?utf-8?B?OU9mT0plWlJvQkpqeWVpWitwaSt5NjkwZnVjTUR0bXlKTm1lRDh6S1JTdzgv?= =?utf-8?B?V3BDdzQ5dW5RdHpuNVpsRVBBWGx1VGpGUkpGajBFUFBPMGRjVkxYYjB3eUFu?= =?utf-8?B?RUQxQnFMa0NLOVRPMVIxazA2T0ZmQTIxOXhkODJ1L0VtZFdHaHBsZ1hxZUM0?= =?utf-8?B?OHhJbWQ1U21vNXZwQVlFL0s3dmxMQWVFSkp6QkIvUjJXQmhCTHdUKzhKbGkz?= =?utf-8?B?ZDJhbjByZDZkVWpuellpcTN1U1ArR3VETC92dzZ3N0lDSnEvNGRUQ0pZSG83?= =?utf-8?B?TDJrVzN2Z2FrdloyeXAyaXI1azdpck5pL0ZadFlKb3pYcVJVV3h4WGhacnhX?= =?utf-8?B?VUhxbTNaS2lJSkYzZHo5bzhnVnplS0xUZlB1QVFpNHJVc3BPQWQyUGRGeDY2?= =?utf-8?B?bDBlQlI0dTVpeXZHdDNjLy91aEpMaHREbTZvM1hLSjNzd08rT05yNU1Vclpl?= =?utf-8?B?Y255SisxRDY3ZFVlcDVzZk96Rnh3ME5iK0gvZWp0MElFd1hmTEV1STVJd0tj?= =?utf-8?B?WnZxNVJweWlEdE1WZlpWQTNpSTkzTEhvenRtRzc5cDVkU0ZOcnFGRWZlYTFz?= =?utf-8?Q?DN7YUsObthHRfTTNKhZxRwyIE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c858806-d82b-48aa-e3b5-08db98d628a7 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:42:57.6632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jPWDeQ3bhrSMeJkrNxzt7mEjT7bXa63XRZQa5RYutvXvAdQ7UDMRGzettp52Gvzl2ni5Yo8p0Sx0JBRSf1slHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8966 On 09.08.2023 13:02, Nicola Vetrini wrote: > 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow > the declaration of 'arch_get_xen_caps' to be visible when > defining the function. > > The header 'xen/delay.h' is included in 'xen/arch/arm/time.c' > to allow the declaration of 'udelay' to be visible. > > At the same time, a declaration for 'get_sec' is added in > 'xen/include/xen/time.h' to be available for every call site > (in particular cper.h). > > Signed-off-by: Nicola Vetrini > --- > xen/arch/arm/setup.c | 1 + > xen/arch/arm/time.c | 1 + > xen/include/xen/cper.h | 3 +-- > xen/include/xen/time.h | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) I would have almost put this off as Arm-only, but then saw this diffstat. How come you consider cper.h Arm-related? This is used only by APEI source files, which in turn are used only by x86 afaics. So I think you want to split off the movement of the get_sec() declaration. As to title and description (perhaps affecting more than just this patch): Failing to have declarations in scope where definitions appear is an at least latent bug. We fix these as we find them anyway, so Misra is secondary here. Hence I'd like to suggest that you declare any such change as an actual bugfix, ideally including a Fixes: tag. It is of course fine to mention that this then also addresses Misra rule 8.4. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:46:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581052.909568 (Exim 4.92) (envelope-from ) id 1qTiZh-0003ZQ-6P; Wed, 09 Aug 2023 12:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581052.909568; Wed, 09 Aug 2023 12:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiZh-0003ZJ-3g; Wed, 09 Aug 2023 12:46:05 +0000 Received: by outflank-mailman (input) for mailman id 581052; Wed, 09 Aug 2023 12:46:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiZg-0003ZD-6J for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:46:04 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2060e.outbound.protection.outlook.com [2a01:111:f400:fe12::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b2675725-36b2-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 14:46:02 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8533.eurprd04.prod.outlook.com (2603:10a6:10:2d4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 12:46:00 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 12:46:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2675725-36b2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fN9dfwLYVwcRZqwLANN+unwN4Yy2Rz35v5BaT10kHkQRD6Np7LAMvVw3WkeUK2RMQ8xlQdcrDv0mZGMIs7khRaVdTcvCu7LrC5+F0ec64CYA52AmriGCg7QCp9og9fs0R5kI6udXyctZelafz+81yuR/FEJdeeOWe8/CJkPVbogfBkkt6vZUkM28ZCvvpRNzKhG2hCW1EARd8P/b1ouI3Cf6G/ALo3ym3wvVQVe9bS/7T4tdno61TsM+UNchQgY0Jp/8Rwzvn6mHvZVupKRFPkHpObbFgc7idvhMjqDcsseCMzUQSbw65XPlJ8KksB4t80I2wkJM6OcyAVNWM1TIVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q6DHxT3FK1KX+fYL3PgU3l+FRGXVf2Q2tDn7awPp8m8=; b=mR08kxzCptggWHh/50b4DaHmn2rie0uKbEMDyCOoroJ0UrVKrt6H4XoH9WmdEDMbl4a+C/6NLTwFxvMVSD/Cu1fajzgHdUoDdH1gKYz048ZkXm7GHiJENR4SHl4kF4Cl48G8jSwvUK/v7iRAnkNgXpUXJ1Ud/RJxv00N3drGFJ9JdPm0yFMI9dodnmzcP4NiVRB40aMYbJx0/PI7Z3kZE1BL5L9kog0h2axgdU8nQ+dPdCxfa/XhYRTKaN4nxuuCKuWN/vx9xqiAf2JBdgqN22UdQgnvh/Frye5Qi8G73P7oDN5xW7kBjvyhtQk06s9AO+VFeJwLSZtdQ0D56aXU3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6DHxT3FK1KX+fYL3PgU3l+FRGXVf2Q2tDn7awPp8m8=; b=D2vI8qTjwJdIyWbuS6pAcVvheI2aLL2Vm/3Huw40+qKv9TT4eZ31iCS6ZC0T8KKZCyM8K7U0ikxGpGqs44/7snc4L7ouVIdp15V0L3Mbkyc8MStqIDoaSJZH/IK7d50cw93d9ulb5s+pP0N1937IY9e45CShhnOK8S22clPsw0Hy4/xKtDODTyjxbZdR95JZQEOUY0G+7fcuWKIzSCv7oQBwU0dqqBNuCM6KSsianJ3Rj35azaqbm6iUsNq075l59GSOGLk26v+13Bn6KF3iAhKxJPrWQU85HITUZkx/fKRieDhsh0ehMNlAveYxqfnVHY1xYAtM8e6dzxdm73UlQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <35c1a691-92a3-0fb1-04f2-f75755a3b5e9@suse.com> Date: Wed, 9 Aug 2023 14:45:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <37bb5dc6f323bd2dc250c519523d05b66d17fdee.1691567429.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <37bb5dc6f323bd2dc250c519523d05b66d17fdee.1691567429.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8533:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a12c53e-84b3-41c3-e939-08db98d6954f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uJv8AIH9/8mEQ7zo15lh/AseqpTj253I6I2aAaiwsPJUN4U974puCxvzz0rpaNSGRcpFrejecZK4kXZGo9HRmRvTmK3PJ6UEk/mNGKqPL4CaBI+3OlDbUSWyJ4S/xk/mPg7WsA1rUClpElL9ansThKZz34XEpHX7pfcPKNX7cZmOxShbv6wIn7R8aKzGpYUiGUBZYQdZMvGdr4F8mTFSkKOzgu8aZwVj/ZQQGWNTJWs4DS0meUPkr1gNeqd7gaydgQAQmhZ2PMB/E6C0CQDXPsZ1tYUeESAa+qiINtRgW+a1FkJi/BqZ/P3WzjChWaZMg/XSYBgCdnH/mQh7WjQ18CA7SQd34b3ItnSQ5oOOYrEUrAmbmpE40ALsRQzvm3XPA9d9b6bDPgMKEF3g4SuKynsPP8ZCCGIWYtudCuhLhpHPG8OPRL+D6/2ZJyvSrYS/PqkjdlId5HqFlHi6xIZkqH5C4Q87isjNay7DYFam7u5SipS+xuYjPm2ijrzNzzOBLnBwzKbbqX7WL3zUQuKEIeMYsPhoCfhJhL8l6qYHpGSbdhuFyPf9T0qhVtsrk98OxYAnOMmenDRPscu3KkyXxu+tDUl9ZkCASGKwMOcZ5B8mIjVEG5IEtQel/nQBnJFD3Re/Ri8fbUoZVxIrQXTScA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(376002)(136003)(346002)(396003)(186006)(1800799006)(451199021)(31686004)(53546011)(6506007)(38100700002)(26005)(478600001)(8936002)(7416002)(5660300002)(8676002)(41300700001)(66476007)(66556008)(66946007)(6916009)(4326008)(6512007)(54906003)(31696002)(86362001)(316002)(6666004)(6486002)(2616005)(4744005)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z05rZ1c0VDZCWEs3ZTl5c1oxOHd3WTdsQzdaZU5WYmFQcVRJTHlUUEVHVW0r?= =?utf-8?B?ZXhkYTIwLzViNXJSR0pOVjFmNFBpMGgrSHV6RkNncUkxMWwyeDF6bVp3NFNo?= =?utf-8?B?VEplNFBGWHFCaFFCZGJDRG9NdGExeG9OSjBFR056bnd2Z2w1VGFlYnRod2xo?= =?utf-8?B?aVJVYStVMnROSnE4dFVSekFlc3ovS0poOWxvQ0hZSmkzZzE4ZlllbW1jNDF5?= =?utf-8?B?MXpreVgxbVlNNE5lelU5T0UweEpBYUc3eXpZMzM3TUhIZFVtWG9kS3FXVS9G?= =?utf-8?B?RktUcmJnaDRCNHVaazZUTmVnc2d1OXp4QmdvSWFtREdBOWJybmhEalBub0ZW?= =?utf-8?B?RWFOWU9YZmJlUmhJcCtJUEdTMVhWZ05QakYxMzVMRkhmaHVBNkg4dTJyM0dW?= =?utf-8?B?K2dWbTVZUmNBbEJ2akNiMkQ0Q2V1MTRHL0NsSm9qYWdVUGxQQzMrNmUxdnVw?= =?utf-8?B?Y0txczVDOElUK1RacC9wK0x6VW1EeVdhSFY3KzFlalhSNGlRMTZzVkVuekpt?= =?utf-8?B?WndFZ1I1cnNEd09vcmRzYU1kRi9XbDJBZUF1VEVBQWltRHVVRFBKNVlnSTJZ?= =?utf-8?B?RGh0RWh0Q0NEN1FEeHJ3WldRMnp4NzQ2Uy84TkdLeFVxVVl3VURQa3R2QWpV?= =?utf-8?B?NlRxU2d4cVlreml3QmVZN0tYdGozYktIblNiR2JQK2ZNYnN6WlFRVjlxbkNR?= =?utf-8?B?OEF5MGoyK0JzUU1BVHBTNGlxVno3eHA0dXBkUkRQd0ZEWjhuNnBFZm1tWWNq?= =?utf-8?B?NjRKb0xxdnJPMXRrZ2R5R2xIVDgvUUpLMk4yMTBQbCtpUW5pckJXaXJOZEhh?= =?utf-8?B?blJhMkF3WFF5d1l3bkhEd0k4NTV2ZE85dElXK1RzSlJZS3E3TUdpak15THRm?= =?utf-8?B?eUx5aGxnZUlXcUJjS2h1b2o4b0dGN2I4K01Za3dDV0JlakxQWFJ5RzV3QkRK?= =?utf-8?B?d3MrVVFUYVlRWW5lVzNaV05abWY0Zk4xMGhnNHRkV3haaTlQYitkMS8rVlJU?= =?utf-8?B?YkV6a1lZQU1YNFd0WGg4U0FVQUhnSmEwenp0aU90Vkl0N0VSMHNRTE9FN0Rk?= =?utf-8?B?ZkhTSGhZNkd4TERZWkwvdW5yT1ZVLzFSRGJESHBweFhFTjB6VVZtSDJraVVK?= =?utf-8?B?cmZNUUZqbVgvSU9ITHF6MmpXcVN5VVo4MCtZeFNFSm9WS1M0YWtsNDVNR2Y4?= =?utf-8?B?SjdQd0ViUE81NnlMYjcvd1loWU9ncFBMaEdnN05IUFM1UmM0NStJWTZzZjky?= =?utf-8?B?NVhDUmJUQkFJZDhvMXIwVmtSZVJmckZ5VUYxTUVjRmgvWmJHcm5oZHhpTUNQ?= =?utf-8?B?V2h3U25xeTRuU3BjTTZkcnh4NDBuRWFkY1U3NGt3V1AwdzdrZCtYaE1JRTE5?= =?utf-8?B?eXIyL1hlUFNWc1lzSjRid1V6bDFNZkxkMllSRElzUDc1aENhcFNXM3U2UWpX?= =?utf-8?B?VGpXdWtlWkpwUFZ5aFVTV0FabmpnVXFFT2E0dlpKeVMyWCs4em90K0ZlSHRB?= =?utf-8?B?QUVoRnNwVVhaWncwVzZhMWNlRHErNU0rWTV3aGdEOG9hMHh1YW5MYlROSDla?= =?utf-8?B?N2lEZ3lYVmc3YnlqdTkxVG9DSmJjZ1g3cmZJRmFJc1BPK3RWTnJxYmxIRXox?= =?utf-8?B?eHVUaGltV091MHNmQzZVbDZPcmk5V0lyMFJuUVNBdzltWitsZnJuSy9jMTdD?= =?utf-8?B?cDdKN1dKL3lIbXM5b1ZTSUYzMEdDOFJZSzJjR1NkUnArNGpnRVNlTWhwOWRH?= =?utf-8?B?NHovL1VBdkR2NDJvMmFLT1JHMjRMZVFicUFzU3JuYWlNTksxdlhvS2lxYVVG?= =?utf-8?B?bENyQmlyQVZEMnI2RERuZ25QUDFnTGNLdS9FK0RhTEp0SUo0MVJpVnR4aEkz?= =?utf-8?B?RWx4L04yRVB5NlUwbE41My9hdzZMOUUyOGZ1SWN4ZmtZMjJucUlkTTVZSUc4?= =?utf-8?B?UkhXaWtOZHd0ZDdFbkFGWjA4b1hTMC9wZ2ZsTVJrS2ZTOHkyTmh0SjhCWWta?= =?utf-8?B?N2tONy92TjBqMGhMNlNNTGlZZGtTSmFHZHZ2SUtVVEY2MG5FODJDRmZVYTRt?= =?utf-8?B?Tjh0VW1iOUduWFBYZmRUM2VrZVZCT2w5amlMQ3hsSXlzQXlEWkxsVENsbUQ1?= =?utf-8?Q?rBZSsV1EYck/kfDfjp0QRKpdv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a12c53e-84b3-41c3-e939-08db98d6954f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:46:00.0841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mVNzu8bJGZcYwrWy0DGcFExfyueA+dDRNGpy/yj1U+YLQC+WR3Cds4tH6za+gRZP+TKbr+Kb5NevFyojQdZHhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8533 On 09.08.2023 09:55, Nicola Vetrini wrote: > The local variables 'irq_desc' shadow the homonymous global variable, > declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed > 'irqd' for consistency. Perhaps with "for consistency" dropped (or else clarified what this is to be consistent with) ... > Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:52:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:52:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581059.909577 (Exim 4.92) (envelope-from ) id 1qTigC-00053a-SQ; Wed, 09 Aug 2023 12:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581059.909577; Wed, 09 Aug 2023 12:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTigC-00053T-Pm; Wed, 09 Aug 2023 12:52:48 +0000 Received: by outflank-mailman (input) for mailman id 581059; Wed, 09 Aug 2023 12:52:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTigB-00053M-Ax for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:52:47 +0000 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2061b.outbound.protection.outlook.com [2a01:111:f400:fe1b::61b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a3396899-36b3-11ee-b280-6b7b168915f2; Wed, 09 Aug 2023 14:52:46 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GV1PR04MB9054.eurprd04.prod.outlook.com (2603:10a6:150:1d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 12:52:42 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 12:52:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3396899-36b3-11ee-b280-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdPTyyVVS45EDDuOjEl2oODT4s7iaIdJxLfMu5F9kJi0ng12DGvq/A+iU6Wjv+7ZIUWIk3PJ9LOZBzF9v6V48KP7hHYI/TgQCKMdM8vA+GJcbDnRMxtp0eDhiHW/ief38LZIM3J4caqyvLEW3wYhpfOliB+xfKkACJqcli96fyhAezSn+PQzuAV62c8QlUbqwocckFmeoOphkGT96HxGdHa6TDXhb8PNSEs6413TGtv66SJMHI8i/nwsGNw2s673jVLuOrOqaSWfIGusw9uXObX+X1J4onFqH5hnuEpldkfeLYSp3sv76YxfMCcqcwjZ5clen2jtN9RKhWDJkIz8WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VdwjTbUbO+QqXHR55jQn/wqnb9odMkztNp0p2VMdN2U=; b=SPZEtrzKCeQvZpbngVd8zVahPA39sG8c0psr0Eg9P6MSh4n/0ZHsm6QOg/ysvbCmm02qPRjvojGy8FLfhEwWcuzKa9I74KSW91qT64VO06LC/zMaAXWGWkCegntdrMxvJ2MMOY0IaS849EVJNDQv6At9wY5U1pwR/HaFZpMNXFkmSm/e+2Q0Jt1jLxHr/YlEF8C6S+eHdWVrInXmOJ9YlU4k8E15UzPHOwer9HbW/sLWrzkyBO66TTnEuX+VUgLCeqdNqYZhFerSV2ZsH63lGL5Dt4r9juHLHkF9R4crrIbEffJ1ae5fqU5bNIdsvF56eN+d4flfMTotrsp2w2v9fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VdwjTbUbO+QqXHR55jQn/wqnb9odMkztNp0p2VMdN2U=; b=SMuK184L+TW4OooCxL95ZZbs+nUYhJcDHTzF6Y/BGJq3guAAq2Nz+eT4jgZ9P/zwqKkmYf6FQ6oh48pgF4A+KQHAwOon1B175OsZ82yhaRBwdx6Xx0XzyFdyM4DH8RQyZeV2E9s2/Pph175eZJlyjMr/OHTO+chy1/o4SjdYG6geXpe2G9zfWgXgS1j40Sw8n0FGJqiiR/NWPH7Qc8U/4N/IWvhXL2XlgEz+GaETuQ5qZvVgSfP1CvbxblMAEidZcen5bdBXASKJafxSP4q0QdaR33OLTKeBligDAhxCsuUrU/2ZOzU1jSRKwwQ3K0Lxb/oLBfagzxWwSAfC5P0Z3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 14:52:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GV1PR04MB9054:EE_ X-MS-Office365-Filtering-Correlation-Id: a184170c-d869-4e50-cce5-08db98d78547 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WfwnzvesxRP/CEGpeznaTlKcpZAps1BGR1Oe2ROmBrMXlAWUnWpSl5OcybxFw6WacvseTyll/UPrej342bKVViFNAIZu7s970cXqi6FLWLtOeDQJxCCPCH/qg7AovCN+/TAmNcbsIQozwgaLEO+lhLnB4aMNLV7JKmkrypUDjHb3R1qZ38G/0yJ10WjxFTb1iTWaBUEa+czDaonjQjn7dq7Q1a7U3GB/rRPicV+mqgWRcJfAGDfA80XKUf/LOY20SVA7ykgUycH6tzaT1uVRs5F0wXJE26Iqrka6JAfZop/D+xudlIy+bvlmxlihAk6nffL86cWB4tsucOzdtoOF7XwZxVg7Q2+Hx2haWT65fITeb3+KfupVzthEj5uoz6orGW5IOTm2I04DBGIm00orcnqNjn/kevCmJQCkJSEddIuMWINhAE3V7jIuQ5SGjb1TIsF7JgV3dgHIpNRqChC5JKMBWBIm4plAMrCICv3JKGwYDSfjpjBHUMSNkwwgdtatGUYOeb5V/R9bgayTOUxTH0je83VWLifQR8UTYKZqsiSqrAmBFQsQbp0z6ed5NF29z7GA2D1d7Fi4xrdJXGKd8gONXhxJqAq7NUKtNOTg4zdiTfHhz6O1JnT6IMXMWWh7NDgvlY5VTBlsTPefx3BrhQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(376002)(136003)(366004)(39860400002)(451199021)(1800799006)(186006)(966005)(6512007)(6506007)(26005)(53546011)(36756003)(54906003)(38100700002)(5660300002)(86362001)(7416002)(31696002)(4744005)(4326008)(2906002)(6916009)(66476007)(66946007)(8676002)(8936002)(41300700001)(316002)(66556008)(6666004)(6486002)(478600001)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3hQakFrMTc4ak9penJ0OFRLc29LM04wQkVBZEZXQ2JDTkN2NHFzMXkxbXpq?= =?utf-8?B?U0thV2RXc0Nxc3NDZGZ6YUJTRW5FRGJUTUZmNUEwQ1BsRTB6c3VpNzVBY2FU?= =?utf-8?B?UkFGTy9jVWZnd0hUYTM4dnhZTldiMEpmSGZob0lFQ3FVUVoyS0tnYk83ekpo?= =?utf-8?B?MnJhMU81QXEwbzZLaFpjUitqVG5iN3RBVFVLbUxFZDR5WG93anExZmJwV0NL?= =?utf-8?B?Nzh4aU9EU1Jwb05SYVpwUGxnM0NUdmRiWDluTWpUcEZnTTJzeWxNTDFiaVlq?= =?utf-8?B?NzdaNFJZMHlaNEFHMGZGYWpTa2R4SHBLU2N2eDF3VHRyR3R0Mll2TUZOSFJp?= =?utf-8?B?dXBpaG10RlpEZU5EVVkrOFhjMTc3OExiVzAyaDRWYUJqMEN3MUxscDdDQzY5?= =?utf-8?B?MzU4MFo1VFZtc28wYWRoa3I1cWpwY2xBelpWUXNtMytoRk4reUo0TDM5d0lP?= =?utf-8?B?NXFJaDBMR1NZcEl3bGl2TXVNWkh3M1BzeHd4MU5GR3FLZUdXZFNVTVArcnFm?= =?utf-8?B?L3BXeVJUelNCK250OUd6ZVEzMExpNHlydUFnVURTU3lqU2JVZWhMVGtZNjFu?= =?utf-8?B?SDdjZzJMUm9LZ0lBMTIwMExISVlOdGgvTk43ZkFCcDNCd0RZbnJoQTNaUjRs?= =?utf-8?B?MU1CZXdtT0d3NVZGL2ZMNWllL1dubGNZeUlCQ0FKUUpqR1VIcHlGT2NqQ0Vk?= =?utf-8?B?OEZHVXVHV0NCYzZKeXNrVXpwazRkOEhGV05ucW5ESWJJT0x6ZUNEbXM1R0c5?= =?utf-8?B?MEEzTnVoZkl4TVNUazdlcVRQR0xzNnQ1d3p2eWs1Y0haYndzeVpCa1BZcGVi?= =?utf-8?B?dHZEcmJwVUxYUHNmRFViaDFWcXc3MWtFd0FzTmwzN2xLUit5Zmg4eWtsUnA5?= =?utf-8?B?dXBUeEt4aUp4TlErTjdMZzhNeU9iV3RuQWdJai83Mnk5VVc2Lyt6UVZEQUNX?= =?utf-8?B?bGJPWC9FT005TmxkOXhUa3ZnZmRPeWplZUZEdS9JTjdjQ0RjUkxnSzNRNEN5?= =?utf-8?B?RERsYW9XOG93Q0F3cm9KL0NyNTRGU1JNUXhZak4zckpCSHBvdHVlcElES3ZG?= =?utf-8?B?NUV1Sm12OGpwbm9PZk5FVGJ3Vm9NWXRhaEhubXl4YzhsMHhFMXZSR04zNVVH?= =?utf-8?B?T0oxOUJTWXFra2JjdUt0cFlzZHZLZTZHY21ZSzN4djZ5V3dURzNueEZETGtr?= =?utf-8?B?QkZ6RmxXWEh3Tm1DVFhpRmxpWitLcmVvbG1tRzQzRVgyd2JiSUpieEp0eElk?= =?utf-8?B?MDRuWlEzcFpSSmgwNUp0VVBjOWpwVDF0a09nR08yOG9jRlRUbEFTcThXSGRE?= =?utf-8?B?RFAzdVM4ZXBHbGZ6VkVFQXQ0ZGY2aTRhQS9hNnhxNXBIK2pwM0kwdnN3Q3dj?= =?utf-8?B?bnZBRVBOMFZUdG1veGdlNGdGdE5RM1YrOXowM2RyeVpKR1lHZi9yRDRTNy9n?= =?utf-8?B?c0FMeEtxZU9tRlZLbU9XYWMyK0I1UnlqbjYyN2hIeE52cm12RzRENkRLYStv?= =?utf-8?B?dytHVmxNTkY2UlFQeisvcjdmMi9UY3JLT0E5Ri93ZDFVUXBMRGphYlB3Y2Er?= =?utf-8?B?dTBXbDhmeklrT2dvZEQ4K2tCZ1JnVXgva0NQL0tBMzFMOWxVcDFQWVFUOHZH?= =?utf-8?B?SFh1Wjk2ZEpzYUkyMG5FYjRoeDErdHZjM2ZQb1hmZ1hhcFZqT3RNNmZGYTdZ?= =?utf-8?B?U3hIVlJzdjdwRDRtNys2RTc2a0xqRHNVMVpucm5zenlFcEZVV0tkcm9DV056?= =?utf-8?B?RmdBdDFCM1kvTEVlakVheU5ydi82bjR2dmxQZm5WcFNoNWEwZUlzTnpVSGNw?= =?utf-8?B?dFRlVU5QTjhYUWk5TEFwWFhreW5RWjc0SVczSzByeDJneE5RRFNyWkd3TnNi?= =?utf-8?B?SHYzRG5oQWpMcnlxVHMwMEhISForUTR1bUp3dXJ1SERwUkNvaWoySWxrVExP?= =?utf-8?B?RmhmeVdDaG96ZlJhN1BIVGRJWjExQTAwSUNOeVM4TGNDRUhzRFB0bko2ZkZG?= =?utf-8?B?Q09ZaEJLSHVybnRrYTdSV0JzY0czUkZNbXB5NzlFMEpZQTFCdVh3WG1Gd3Na?= =?utf-8?B?TFluWjJZS1BCbXd2TllnbVhYQ3pvck8waXB2NjNlUU1wNWszaXJRbGJwWXow?= =?utf-8?Q?bl9YVKk7dz3bFwqdqiDX7TF9y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a184170c-d869-4e50-cce5-08db98d78547 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:52:42.5501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EJ1rRv2Uyo0zSwBhFFAESfGnTmmbM7GO3dLJlBHUlO6T/kYW915J65QMIB+uR3QFiS7j4/eeBYY6ElD+ZLHbyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9054 On 09.08.2023 13:02, Nicola Vetrini wrote: > The additional header file makes the declaration for the function > 'init_IRQ', defined in this file visible, thereby resolving the > violation of Rule 8.4. > > No functional change. > > Signed-off-by: Nicola Vetrini > --- > xen/arch/x86/i8259.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c > index 6b35be10f0..9b02a3a0ae 100644 > --- a/xen/arch/x86/i8259.c > +++ b/xen/arch/x86/i8259.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include A patch adding this #include has been pending for almost 3 months: https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:56:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:56:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581065.909588 (Exim 4.92) (envelope-from ) id 1qTik1-0005is-HB; Wed, 09 Aug 2023 12:56:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581065.909588; Wed, 09 Aug 2023 12:56:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTik1-0005il-DX; Wed, 09 Aug 2023 12:56:45 +0000 Received: by outflank-mailman (input) for mailman id 581065; Wed, 09 Aug 2023 12:56:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTik0-0005id-08 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:56:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0c::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f73f832-36b4-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 14:56:41 +0200 (CEST) Received: from AS9PR0301CA0035.eurprd03.prod.outlook.com (2603:10a6:20b:469::15) by AS4PR08MB7709.eurprd08.prod.outlook.com (2603:10a6:20b:510::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 12:56:39 +0000 Received: from AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::49) by AS9PR0301CA0035.outlook.office365.com (2603:10a6:20b:469::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Wed, 9 Aug 2023 12:56:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT026.mail.protection.outlook.com (100.127.140.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Wed, 9 Aug 2023 12:56:38 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Wed, 09 Aug 2023 12:56:37 +0000 Received: from 8dfa888c9974.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 484763F2-F111-458E-81F3-7B13147D0DFF.1; Wed, 09 Aug 2023 12:51:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8dfa888c9974.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 12:51:11 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PA4PR08MB5904.eurprd08.prod.outlook.com (2603:10a6:102:e5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 12:51:06 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 12:51:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f73f832-36b4-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K5NAvYB686LIK+svT2xjiSytdBeT8WGVqQ5/TmHumMk=; b=NGjg53nLrnm00TPcXWQBkSc6Vl9lLEB5y0KCezzcSzCu00TY580F1mvk7mOlPVX9+lVR8WkPoG4gdAOFZpJn6S9ipzGQiGuCwkM3SeQIZbGsahZL4KOUiqbJhZpGxa2alnNEpl0Ex0r8cQqDfjCtV1+W86E5pmlk5o3AVsoqNR4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1f7bcf09de862bc5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAZ3hsti0/CYYuhz+v0WOMAZhMc7G1TBBIYpogwU5zrqvrG8iJ3wvEWHG1We+lXoSAhkA4I8WmIkdNJ1oOegHzg1UAGH+5S9AYuEAQkFsdkEXq5o4J/PVfoFoKd8p+KzxqWD/hSuwaxCD33RcZAGtlbPrue4Gc/hC9sNE5rUXDBc/ze1pF7ZjIOZT8ZcZ0K1+gZuVAIbeUL8NPl2FeaV5TYWSfSbUBXbEuHnG8IhOnJKBFXkEq/Ty4q/t3LNjLFF8tnJvswK7onRUPM/XlIC0jufBvNiN5Xu0lUMXAI9lqI9HyyHpME4BWO7zaQ0OeJFfcgkRMVoGWCJEXw39ugkCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5NAvYB686LIK+svT2xjiSytdBeT8WGVqQ5/TmHumMk=; b=DVKMr2Y4AAmBYO6jN29yGSCdgzin2fF+9wCNVhsZ62mYepYD4SD8AvQfp7ERNz6CKTNVmu9gJGSanP6kM5l13oEEaR3GzYaXwlRyhMm1NNNHo2qhe4//kWTWCyRZpI6nFiC4d2yv0ismtiYpxwMkZVEqPBHlZL3XsAjrYA67h+GIr00W5kzz4XiCxcv+UK8qZOecj73yvLXMjRP1/MynIT/xmVxhhdCkQ7c4IiLao7vocrmZx76bQNkzyIzaCYnAJZ2zPRpH+WIyID/qx883JDHgxPwXSrQxeFRxlvvvJPx7BKXv6ftEZIJrOj/1arwWaEcHwFUfGp2dsIyQR9+vAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K5NAvYB686LIK+svT2xjiSytdBeT8WGVqQ5/TmHumMk=; b=NGjg53nLrnm00TPcXWQBkSc6Vl9lLEB5y0KCezzcSzCu00TY580F1mvk7mOlPVX9+lVR8WkPoG4gdAOFZpJn6S9ipzGQiGuCwkM3SeQIZbGsahZL4KOUiqbJhZpGxa2alnNEpl0Ex0r8cQqDfjCtV1+W86E5pmlk5o3AVsoqNR4= From: Luca Fancellu To: Nicola Vetrini CC: Jan Beulich , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , Ayan Kumar Halder , "consulting@bugseng.com" , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Xen-devel Subject: Re: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 Thread-Topic: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 Thread-Index: AQHZyrEaGXA3hK6V6kyURalgDFtEka/h6KeAgAACPIA= Date: Wed, 9 Aug 2023 12:51:06 +0000 Message-ID: <906F3F94-49E4-46A7-8CC7-DCB44FDF494C@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PA4PR08MB5904:EE_|AM7EUR03FT026:EE_|AS4PR08MB7709:EE_ X-MS-Office365-Filtering-Correlation-Id: 130402a4-decc-4dae-71fe-08db98d811df x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4rDikFiFxi5uR6zF9Gw1/2Aufy8TkwREyFYNXf9PzmjInB0/oS7ALyhipXmKRknerh+smTBiVpobsitzvXmPrLLOFqwUBwcCaWBjcUD8WbefWG89kflEMcoGVV7ViOqCDgJvu1E6pHhR7hzzQygv8wdvC4gYnuJ9/YD7jnz0r8puZZwxZvymG7a1zpOuj6s1wxK7bbHxBtpA0rQuY6TVIS4Ljl3XEm2z+aIUr8CbKV9DX4LJnXukzpz/qETlNK5REKfwdJ0pGlNO9ODW2ggZukqXzs4EYdskbyJvFOiwNB1sOf+nB4GCrvK2sNFlnql9884Lu/eswCnON1l/7grO4Qg3alM36/Hk0+8cTJSWgQVrEe7uWAm5Ayc9BHco4t5YRpV/YDIqDOpOYKy57CRwuI2O8+lBRVFNiwchWE0IKIsqGJa2d81s6mqBX2z8Ka3BjpSE873mTQW+Jb7bbzh81YXlGwgWDWXvzuLyNwvAckNcUAxo9OE1JsLIGauTG7AmyoiAnF2i2/UcNUE9YW1rIwak2rFyRRK0v6uszXUv63rdbECVo+EMxcaoxBnbZrmykp/asojEYGuzppyahXY1GutWtSlWYKDDbyxW+RI4re32JBttxLrMIhVNkhZj/c5cFGDdL2AW8BmArOSSmSpojw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(186006)(1800799006)(54906003)(478600001)(122000001)(38100700002)(6486002)(71200400001)(83380400001)(86362001)(2616005)(36756003)(6512007)(33656002)(6506007)(26005)(53546011)(38070700005)(5660300002)(66476007)(4326008)(6916009)(316002)(8936002)(8676002)(76116006)(66446008)(66556008)(64756008)(66946007)(41300700001)(7416002)(66899021)(91956017)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5904 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 424e5d99-278e-473b-52a0-08db98d74bff X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: urXYtDzyfuG/4a+7FEwn8g49eeNmjY6t4JWTZZ1L/wfcwi5mw/wdKo0yrlLRSQzUyLhVyrx6sePG26MbjwwQ9e9YZIbrD7EAjd0UxoOmOj6FCCSeYm92rAgGafzLuPjuqVnIfJj2aX4VIA49TkNmjQYPCX/sBuowC9BUtL9h+42w0AqqKWmp0A49Beq0ShosJGU4ZA9VvSnveCTJ83bBai/P49sOSui79hGDZnUf3VnQN2BPBG7jCjjwPVmMcq/mHUN2wq/99eHiksOKecVMO3S4pdhP0XkdqhBLE1BnkChqsn/0jLh6SUd5ntfA/7sVKUSTFFPc0GGbQKhWVzI0Zd09lBRhKzn8b8Gqvz6qzfixSfqoiU+aiCCVMy4vslWkpNpNb9PKt6BOBbJIQdgGPTfkoG/78xu242cmPNbyHmuUdq9cQEf0xdk2SXVY7YEJBEtjxqlKRJ5mSrp9fRtacMeHM5fxHlMUowe/ixkr5S0e4166NgWl2invXJT9iE00LiwURmRZOvKxuLWicGxlD8bdMoFHSMhYIJkB5Stm7fHw8QSpzX54Fnjtr+DGdN6KxqCg32bcgAH8xJvJvSNHnFJ2W9azDuo6PUCGSAAGJGgc7cQT9G4qksw5qdO0YLNrgzGB9Fyz9+1OYefB9h32zWCcBa1kYALsFHig5PrTD4QAVtLDLEDdP6p6BbE0TpckXV2Q6u2OGlbKgD5tiGnayiSNcpdIqcWUzGS5+iGACa+swX7ujk4xSdr/9LsRtTWF X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(346002)(82310400008)(186006)(451199021)(1800799006)(40470700004)(36840700001)(46966006)(2906002)(66899021)(5660300002)(8676002)(6862004)(36860700001)(40480700001)(33656002)(8936002)(41300700001)(70586007)(70206006)(4326008)(36756003)(6506007)(6512007)(478600001)(54906003)(26005)(316002)(86362001)(336012)(2616005)(47076005)(83380400001)(6486002)(53546011)(82740400003)(356005)(81166007)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:56:38.2646 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 130402a4-decc-4dae-71fe-08db98d811df X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7709 > On 9 Aug 2023, at 13:42, Jan Beulich wrote: >=20 > On 09.08.2023 13:02, Nicola Vetrini wrote: >> 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow >> the declaration of 'arch_get_xen_caps' to be visible when >> defining the function. >>=20 >> The header 'xen/delay.h' is included in 'xen/arch/arm/time.c' >> to allow the declaration of 'udelay' to be visible. >>=20 >> At the same time, a declaration for 'get_sec' is added in >> 'xen/include/xen/time.h' to be available for every call site >> (in particular cper.h). >>=20 >> Signed-off-by: Nicola Vetrini >> --- >> xen/arch/arm/setup.c | 1 + >> xen/arch/arm/time.c | 1 + >> xen/include/xen/cper.h | 3 +-- >> xen/include/xen/time.h | 1 + >> 4 files changed, 4 insertions(+), 2 deletions(-) >=20 > I would have almost put this off as Arm-only, but then saw this diffstat. > How come you consider cper.h Arm-related? This is used only by APEI sourc= e > files, which in turn are used only by x86 afaics. So I think you want to > split off the movement of the get_sec() declaration. >=20 > As to title and description (perhaps affecting more than just this patch)= : > Failing to have declarations in scope where definitions appear is an at > least latent bug. We fix these as we find them anyway, so Misra is > secondary here. Hence I'd like to suggest that you declare any such > change as an actual bugfix, ideally including a Fixes: tag. To prevent back and forth I would suggest also to have a look in sending-pa= tches.pandoc, ### Fixes section, on the expected syntax for the tag > It is of > course fine to mention that this then also addresses Misra rule 8.4. >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 12:59:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 12:59:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581072.909598 (Exim 4.92) (envelope-from ) id 1qTimW-0006L0-TM; Wed, 09 Aug 2023 12:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581072.909598; Wed, 09 Aug 2023 12:59:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTimW-0006Kt-Qj; Wed, 09 Aug 2023 12:59:20 +0000 Received: by outflank-mailman (input) for mailman id 581072; Wed, 09 Aug 2023 12:59:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTimV-0006Kn-8t for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 12:59:19 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8c19a59d-36b4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 14:59:17 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GV1PR04MB9070.eurprd04.prod.outlook.com (2603:10a6:150:21::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 12:58:45 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 12:58:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c19a59d-36b4-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P1OnF6DE7Hoi1yBe1sQmmA8DzP+dzWnVxnTf3VcRXrTvBYZ4PueEv4ut+5ofbR6nNPqhKbwdDU5ZAYK4vQNKn5vukjgzmorTYpL5B+bb896fquBCwq6qUBwREo726vJfSoTW6AmIByZY9873JEUIyVLIbGUrPFLhz2NRZRIiA0Lv+gdLlsyFFs0UZHzI6OwKJruw4N64wvJiU84hufJFPsg6C+0Z8p+XP6EIGM+YJBebm3MFJFoxXnsd/2hcSKq1uk0GNhh2O7OQrXyPd4lC+Yd3R0+qi/c2JIW/TcqEB8NsZDg7LN5q0C3JtG/t6hYAj3F88Hb9HasqD1OSQdKg8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tBb2vbJvdTKzia1A1t1ysqiU/HUf11dh6j3TxeCtJPQ=; b=AioXwZwHqkFXityjHxMOesZkEqjSU/ARJ3csksedg9ETeBJUsbeOA4/C9FCjQM050e/T7KJ5RyktTd+3qOEJaM9ARj6a2tM0SHrk8Yd39EuJau87oEwb9h/lqKrgb2/p1ZnWM2D4fEd3ao0SYFBi2m+Zp/dQlIcqPd8eHOR+4hbd+XUJNGK2JfN+Ajt4wMLL8T5sQxS9dJJUpCz0TkOPrweaOgCEI/dp4cu6i96rCavS1J1Bhus82VPAu7lq+3u7NV4INGFeofLahuBHjcUD49MF0t9hvjyqAU0Obm9bpV25PC1xbU8o0U8tmbKTMZIAnophnA5+HxVxh2MyQcjf1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tBb2vbJvdTKzia1A1t1ysqiU/HUf11dh6j3TxeCtJPQ=; b=W2YIsL7itZZ1RgymwIv/QZztChAU+g+GXnxsb3itHSlB16peukc0bvofbzi4q46I6G6B8LXTKOn41nVjVprg0zkFT4sSgtw8vCb8aWx2h2LoxlrskrvN3J+R6Nt8ihrW1cHbt+saIdjVharuzvDgiEkh+1jypom8CiHtCOMgrKpRxyvbj9fcJPfmKWdaf1jn3ydxJfGMXeU2SzZgfzJF4qCbLXvFtrgiTLMdJ+YzuNS9YxhZOYvZmEYyWTNhttyP27UfaTX3lMqokBGOf/adInJbGd1acmsNs6fpmO7ARnFurCeko4s+FzkgUgJc+TmQiSkBl9QwYOWdybXhPEwgog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5c2b3ce5-2081-0894-5e47-2feaaacea830@suse.com> Date: Wed, 9 Aug 2023 14:58:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 8/8] x86/nmi: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::20) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GV1PR04MB9070:EE_ X-MS-Office365-Filtering-Correlation-Id: f4414fe0-a2ef-431d-4975-08db98d85d8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5u0AjMjMwrION3nWk5qsSp3Z3cJpu8bMrvdL2PEiOZ/LCAha3Jxxsk4vMxzigzNzpQzSHNu21M0HTKJuq1qQPZF/DT4hDhSdMBVtm3m0CifsO3h2wwWqR5H11q275Yj30/P8d2aboLYl/wtQWWY6l9PIlHSY7YMPwVxCu+pAjtTwHEPyR1bUD3v7PWUa0XPJhaLlWS4fzsliv17lNWONXIxDfi6iZviUrYbcJsJhTmPlbt43liwBljVx22bxpbNmlJwU+Ms6XG5bYZ8JXAnRR9O9rTfA7erz0dikdVK+Rlfe2St9Qrvig7+sqXlEHHdxcMEQSLKE6nz/6QGkp1AqD18KB8ljH2yi6ZdGq1+anGctdLl33/e+YeqhYpq15agPSIH/F/Hi1eqsviiCe0Ad9aVXbq+2RXx04dwxjGVE4tNgfOtp5dqbCu+sSCxUTYKJD3JuQdT+MTNmAZfLU0aTjS21zqArIOtRE7xSMhL+XdAV4dG/aaMtFM0k1lgIHNBwNYhiu8zHL1Vf5dS2+g8kY3BeFkJyr55dvkf/WwctPgodc3hfLCxUvPBuiFIYPczWx3AJG/dEk+/IvfPVP8naKHzoqC78g+4h1LnTNNWdDywTl8g/0uAqTl+HKxdJmyJ39arBcPdl+0jdeG0at9/QnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(39860400002)(366004)(396003)(186006)(1800799006)(451199021)(2616005)(26005)(36756003)(6506007)(53546011)(31686004)(6486002)(6512007)(478600001)(38100700002)(54906003)(66476007)(66946007)(66556008)(6916009)(4326008)(316002)(41300700001)(8936002)(5660300002)(8676002)(7416002)(4744005)(2906002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1NGcDVYcDFHQ3Q2R2JkMiswVTcwb1gzQ250U2w1Um11V3RQampvUkROODlB?= =?utf-8?B?RzBwZEE5eDdOQ3lXYWI2ZmNEMEpodXdVUkRrNjdwc3VHMlBLelFVaGtTWmdN?= =?utf-8?B?WUtHUnF0NjEvbTRnVTRnTkNHK2huQy80WldNZExKWEVwSVNhQ0RzekFCMXBM?= =?utf-8?B?U0VSbkREaFBBenpwV0szb3VsWnRJRUt5LzlFdWNpRGduZXc5TE1MamQvTkJm?= =?utf-8?B?aE5TeTRBSEtWcURza2s3ZE1yNW1ISklTTnRqT1NtaDBRRzZjWkJEcnA0RG9N?= =?utf-8?B?RktVZi94MHBSSTgwUjIyM3ZsdThHMnF4Vk9VZlEzUllUTEFvM2ZZTXNSaXdP?= =?utf-8?B?V1FLOGRtNEhOYlZDbUJGejJTNXdFbHFiVk9yQWJkUmp4RlJaU1NDNlFzV0E3?= =?utf-8?B?aS9LYTA1aHplREl5RmZIUlZzNVdGd0dFVXJBckpyZ1BGUlZsay95UlRVdjNz?= =?utf-8?B?LzNRcGpsZjlkQVBtTEhwS3NSaDBxK04rUngyVmszWVZBWWorcUdJeFBrdWI0?= =?utf-8?B?RGw3VVFtZWtJVjVtNmVUQU9mbFNoODFTQjczSVNER3Bia2ZTam5YWC9KN2Ri?= =?utf-8?B?SWdLSGpGV05BazVLRE9sYzluQlpGZjVHTVppVTlaV2c2aHI3aGZSNHVWNXRP?= =?utf-8?B?U2RPaWlndGVnZC9vK3NzOW5pakZiT3RsVkdNeE9FZ2RYVG5aeHNtL0R3K0w4?= =?utf-8?B?RE9FQU92d09ZWmZuZ0dLQ0Rva2JhY3NrZWE0Ujk1NU9aUzJDN0NMV3I1NlI2?= =?utf-8?B?elhlMThPOXNrak8wZ01XcVEwMnd5SWMwUjRNdkVobE5TQjVnaFFYYjF2dE96?= =?utf-8?B?c0YxMVNxRnJURzFQK1k4cmc2ZCtHT3RkT3VFMTRrb2hLRFZoQzZoSHF5UWdP?= =?utf-8?B?RW90L0IvS0cvSVNrNFpYRzRPZkVuSHNBc0tTSis3WjhwQVZOOGNTVTlYWnRw?= =?utf-8?B?ZE1QSFdSV3dHd2cwejJOMW5lVUlGbi9GS1Z2cnZXam9JZzdrbm14WFhRZHMz?= =?utf-8?B?cXJrYWhGWTgwYkVsdWZwZHpjV1k1b0xVZXBPM3cwcWpPWGhMWUdxMmZZSE9m?= =?utf-8?B?V0Jmam9rdmtoNVVSNkNHV3d2cHBoblZCUG8ybWVnTGlLUGRuVTZ0SitrNHBj?= =?utf-8?B?b3VaYnpsbXZVdStuTXE3QS9iTEpnMEFJZ0pkemRJM1BWK3UrK0R2SGo5WS9T?= =?utf-8?B?Nnhic0lLM3ZZaGFmMklhNlZTRnFmR3MxSG1jbGREN3A1M3pKckRySEhUY05t?= =?utf-8?B?K2FreGVVUFI2SW0zT2U2L3VVbWRUeElTSFREL0RBQk9rTmJLSHh1Rnl5dGlJ?= =?utf-8?B?QkI4WUROdTBiSGhrbzNBZUJtRkdzbVNnV1hhMi9nRHFUVFBXMlRuVDJ2UDNK?= =?utf-8?B?UWtweXFlc1ZWVW5vdm9zbUg1VXVjaXlmVktwWDlLMk1DVU1od0JCR05RUHE4?= =?utf-8?B?enlvc1BOU2JvOGQwK2V0UjIvbjk5dUwyQTRBeDVUeVlDZW92Z3I3bGtDNlVs?= =?utf-8?B?eGljZytWeEgrZjBLaS92SzNRMmlLWmJTejEzQkQxcGE3RmFvK0E1YnFQcStE?= =?utf-8?B?STNyUDUrUjArSWpvZE54aE12Tkp3ZmZoZ2llYjA5TjU1bFhvTUFHZ0JsMkZD?= =?utf-8?B?UGRnV0tmS0VqTXRuYnJsWGM3bkx5Vi9FRC9WOVAweUtyYlkrRm5IN1NINTlh?= =?utf-8?B?K1lGakN6TUQzYXN2dUtLOFVReFpkN1NVdlVXa3M3aGw5UlNodjByQ2loQkk1?= =?utf-8?B?ajVrTkErS292K2F0SVNvTEI3blU2SGhyUHdoTURNSSt6bkZxQVd5WkVnNFJi?= =?utf-8?B?ZDFwMFg4aHNmUndaT1JtMnIySXpZSGwzcjY3VGdmUzU2ekpMZjNhNldvb1c3?= =?utf-8?B?QVdRaEhwT1crQVZRZzBtODlhYkZRdFVrQ29salc4MGFXRHdKbDNZNE5sdGdZ?= =?utf-8?B?TFNpb2lxTGlvZU5QYWtMNlRQUG5TV0c5MUdrRmhqdHpKVnEyYkVYQkNBR2V2?= =?utf-8?B?SGVMZ0NmM0tGc2lvckRwdjNPTFZHWit6Q0plRkJNSzdBajJ2RjQzYXNOZis4?= =?utf-8?B?VlFFdnF6SFNLR0ZUZmFsbktiSTNBSmhRUFl6YkljVWxydFZsblhyR2ErYU80?= =?utf-8?Q?O1esKU1jQE5EGnXz/KzW9XPMj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4414fe0-a2ef-431d-4975-08db98d85d8f X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 12:58:45.4072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WYON/srCWxvtWmE/UfEEd78TRmz960poGioiIJedsr1+dNkkUA+xfviNH6FcJdBd5XBKuGGGOAjEsN0BvpANIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9070 On 09.08.2023 13:02, Nicola Vetrini wrote: > Include an additional header to make the declarations for > functions 'watchdog_*' visible prior to their definition in > the file, thereby resolving the violations of Rule 8.4. > > No functional change. Fixes: c8177e691f0f ("watchdog: Move watchdog from being x86 specific to common code") > Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:08:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:08:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581080.909607 (Exim 4.92) (envelope-from ) id 1qTiv6-0007sp-Nl; Wed, 09 Aug 2023 13:08:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581080.909607; Wed, 09 Aug 2023 13:08:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiv6-0007si-Kp; Wed, 09 Aug 2023 13:08:12 +0000 Received: by outflank-mailman (input) for mailman id 581080; Wed, 09 Aug 2023 13:08:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTiv4-0007sc-Nh for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:08:10 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c790fb95-36b5-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 15:08:06 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id A31644EE073F; Wed, 9 Aug 2023 15:08:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c790fb95-36b5-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Wed, 09 Aug 2023 15:08:05 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: <744a4ae451f3751d5a6c97e5f28cdaf1@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 14:42, Jan Beulich wrote: > On 09.08.2023 13:02, Nicola Vetrini wrote: >> 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow >> the declaration of 'arch_get_xen_caps' to be visible when >> defining the function. >> >> The header 'xen/delay.h' is included in 'xen/arch/arm/time.c' >> to allow the declaration of 'udelay' to be visible. >> >> At the same time, a declaration for 'get_sec' is added in >> 'xen/include/xen/time.h' to be available for every call site >> (in particular cper.h). >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/arch/arm/setup.c | 1 + >> xen/arch/arm/time.c | 1 + >> xen/include/xen/cper.h | 3 +-- >> xen/include/xen/time.h | 1 + >> 4 files changed, 4 insertions(+), 2 deletions(-) > > I would have almost put this off as Arm-only, but then saw this > diffstat. > How come you consider cper.h Arm-related? This is used only by APEI > source > files, which in turn are used only by x86 afaics. So I think you want > to > split off the movement of the get_sec() declaration. > My mistake, I squashed the arm and the cper part together to avoid touching the time headers twice, but the old tag remained. > As to title and description (perhaps affecting more than just this > patch): > Failing to have declarations in scope where definitions appear is an at > least latent bug. We fix these as we find them anyway, so Misra is > secondary here. Hence I'd like to suggest that you declare any such > change as an actual bugfix, ideally including a Fixes: tag. It is of > course fine to mention that this then also addresses Misra rule 8.4. > > Jan Ok -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:25:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:25:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581087.909618 (Exim 4.92) (envelope-from ) id 1qTjBi-0001xq-4Y; Wed, 09 Aug 2023 13:25:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581087.909618; Wed, 09 Aug 2023 13:25:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjBi-0001xj-14; Wed, 09 Aug 2023 13:25:22 +0000 Received: by outflank-mailman (input) for mailman id 581087; Wed, 09 Aug 2023 13:25:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjBh-0001xd-5Q for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:25:21 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f37517c-36b8-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 15:25:19 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 8D2A84EE073F; Wed, 9 Aug 2023 15:25:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f37517c-36b8-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Wed, 09 Aug 2023 15:25:18 +0200 From: Nicola Vetrini To: Luca Fancellu Cc: Jan Beulich , Stefano Stabellini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, Ayan Kumar Halder , consulting@bugseng.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Xen-devel Subject: Re: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 In-Reply-To: <906F3F94-49E4-46A7-8CC7-DCB44FDF494C@arm.com> References: <906F3F94-49E4-46A7-8CC7-DCB44FDF494C@arm.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit > To prevent back and forth I would suggest also to have a look in > sending-patches.pandoc, > ### Fixes section, on the expected syntax for the tag > Thanks -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:35:26 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:35:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581095.909628 (Exim 4.92) (envelope-from ) id 1qTjLN-0003YB-4l; Wed, 09 Aug 2023 13:35:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581095.909628; Wed, 09 Aug 2023 13:35:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjLN-0003Y4-1x; Wed, 09 Aug 2023 13:35:21 +0000 Received: by outflank-mailman (input) for mailman id 581095; Wed, 09 Aug 2023 13:35:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjLM-0003Xy-4W for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:35:20 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0600.outbound.protection.outlook.com [2a01:111:f400:fe0e::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93820e20-36b9-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 15:35:17 +0200 (CEST) Received: from AS8P189CA0047.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::27) by PAVPR08MB9040.eurprd08.prod.outlook.com (2603:10a6:102:32d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 13:35:13 +0000 Received: from AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:458:cafe::a) by AS8P189CA0047.outlook.office365.com (2603:10a6:20b:458::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Wed, 9 Aug 2023 13:35:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT052.mail.protection.outlook.com (100.127.140.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 13:35:13 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Wed, 09 Aug 2023 13:35:13 +0000 Received: from df7c8f155ca6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1C30309F-0116-4FE1-939F-B53627B27A08.1; Wed, 09 Aug 2023 13:34:50 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id df7c8f155ca6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 13:34:50 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB7592.eurprd08.prod.outlook.com (2603:10a6:10:311::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 13:34:46 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 13:34:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93820e20-36b9-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JE+zwnNBEWcZY3KByuvoYBwueGKBwPSlNOUFMVG6wK4=; b=gDDrGV1uegTltK81PO9SknLNgGLGxLTecWsI3ht6zyiVoLGe9ZAwGa8QL3siHPIrNoMtpekNtKMqNEMp4zmtaiRSMzppBbc7VDeuUqDyHzlYx7y0s+RF5rLBy08F8hFa47WYglNzIA0I1GBdYWfK3MUpB+FnZsCne50qksX7hHQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3e18648eb2eff96a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpKaMvL0YW0ckNkAGvol/P4igcjU7HmomIgGjPDc1Y8ZTusG/6el1SEBpzA/vaLL05155Y963wMf/GUgNNsVphgpTnHuLfPx6IshKkvHXp3dcXLQf4t6/ZYvAmbOeEvViSQuddcojwiwu2gUqXcvGz5fJFDz605XZlGuhYRp1AQvBi+RbP6hLz6xbvIyyAwv4dS9MUx/DoCWorBusC14kCWIASyHeU4cVQShRAHtvytamLyKUdXSlYSfWgZ1V9qbDwrH/GxrTmoT/O7a7Jxj/g5BHkEJMVikxvfqGf8fvD/vMpFK/oKhbCVxnXNULvq/UjQVwlSYHEUvKC79zVpzuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JE+zwnNBEWcZY3KByuvoYBwueGKBwPSlNOUFMVG6wK4=; b=d0AUKmGi3bkUHVtFd6hkTkPolOEZMAjfkMa/fLM1OXIUMXxHa4Czkw+nsQEx8rvEnIfV8JXWIW9tyTXTnmYYkDcQSciBUCsB75aYolZ8vuTRXqtDUunaZ/3ZwWu3idY9mm6hBgVnblBT5ZSMyd1YUsNnjHzkZODIc2gpGgB43QrHxpdgZft0tMaXy/eNUY6kYVITip7QMpDfAmThIP9RfySjxe2I3obN5VO5RNImb8tGPtYIYYfoUCtexcOBUtnzgMg6VMUGiG+kPXusjdq3PCDZIChVWk7ka8ENVNHjQszCCDIOh+dvL4wONJooAzrvDW6z4agUrnJue1lsy9DOZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JE+zwnNBEWcZY3KByuvoYBwueGKBwPSlNOUFMVG6wK4=; b=gDDrGV1uegTltK81PO9SknLNgGLGxLTecWsI3ht6zyiVoLGe9ZAwGa8QL3siHPIrNoMtpekNtKMqNEMp4zmtaiRSMzppBbc7VDeuUqDyHzlYx7y0s+RF5rLBy08F8hFa47WYglNzIA0I1GBdYWfK3MUpB+FnZsCne50qksX7hHQ= From: Luca Fancellu To: Nicola Vetrini CC: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4 Thread-Topic: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4 Thread-Index: AQHZyrEh5sKZJy8ET0extcxfAe4LeK/h9xaA Date: Wed, 9 Aug 2023 13:34:46 +0000 Message-ID: <2AD1EA83-AE7F-485C-ABFA-D285B4BAB1CC@arm.com> References: <844e7bf57c2eb7b20d8b1f81a7730a7612f1b6ac.1691575243.git.nicola.vetrini@bugseng.com> In-Reply-To: <844e7bf57c2eb7b20d8b1f81a7730a7612f1b6ac.1691575243.git.nicola.vetrini@bugseng.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB7592:EE_|AM7EUR03FT052:EE_|PAVPR08MB9040:EE_ X-MS-Office365-Filtering-Correlation-Id: aa3bef2a-7f0e-43d2-a0db-08db98dd75be x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ksC50CeKdPgfjcs/pXTAVW+ucQOlDLO7v6jVbngU/e404HPkCjdBXaoHX+/EKixWV0wd23RQ8BwaqYITtOPplkqE3zvE2s7uOYwQDdYRJ2c+ssgG6Hs9TIWktk1BiujWzsPob6jpA6c9NMrIpRQtXRh6+nE7KtDKAuQWTySNNOJznBjbZxvc8CTLkZSzl0isFmUOQrrCDwcoEjQ1Q+32L3vMJj6hUHuB+XjXF2x8sHHdrWCcFcWLlMNcrADs8i4WR9RwZUVE51gzWoDyPBOPyKBR0gnWiUq1z39pOBzJgR4roYlX2QqA7Cc2vzeF5SAL34yJM3iYa6Ubb4GqibwHqgFZlquz9MNInP1TnwI8gE/ZXVb8CIlBQyP3710SExkuAJ0jccXWYnKTe/EUESipQS49segaURT34NqhCvN39omuMnQi4ww5AMyjF+9oDvoEQ0NEzMSTqE+Nyn4eIBhPjgiuP9CKMWgAIq9M0AliFl5wKpHwIb0ZUOupKRAxXpOei1eaD6J0d3ynwzgIgotPQS2j9r4+k4vbzxcHjggf8tMKAKDt2XM3ldZOP8bcCe+ZHbHobV/Cs1z81kolpgtAWBj1qEmH0zVqtmEbJEC4RPVVFfaoX3hKCW3DQgkkL/6Ux4aa3ISnSMe7K7qSiLZk9Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(186006)(1800799006)(451199021)(122000001)(478600001)(2616005)(6512007)(26005)(53546011)(6506007)(8936002)(41300700001)(91956017)(76116006)(66446008)(66556008)(66476007)(66946007)(64756008)(316002)(8676002)(4744005)(4326008)(2906002)(6916009)(6486002)(71200400001)(36756003)(54906003)(38100700002)(33656002)(86362001)(38070700005)(7416002)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <81BDF0E81145284F9A8CF16ECEB2CD2C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7592 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a215bdea-0e15-4f8f-69f6-08db98dd65a1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fCuvFc9aliqCcD8VTZLDHSL+RuPirwSgom9u8vlf8jW4DGd2X9Y5b0FR3Lj4+wXkOBxiiL0Q8OWrbfKLE75TPhgO49JFXOYo5Mnm5wYBkD9PnLyo46sr34AXGNgZN7mdGQdm02FLRBgbo4f7rZ0XoufpceMHkEouh6H4yYPpnu7iX97REXR9jkNDNpVPdlXp3h1YunS2GLx4Au1Ieh1XFgn3yMx8tMGMxM2ysxzdb0V7We4zZIai4Hym3QprzJ98WOFe5naROM/SUv5hGpElJzZe3oO5HewEvokoX7EsMUz11ifW+MwM2MjZvdTx7X62pICl1mX0gTzUfm9rT6ZTv9HZ2SAjvL1y7sJSTKt1z9EohQoj6rhrGX6GLvaoLqlUW2utUYN+zxHcIQtQpaQg1abG+/prcJ8tCYaSconEU8w9V7mkkFGvcjc4CdIvGys+Ebzw3WDjncQ6S65IiXRxLcSofxLDfyduAP0txIGn4R3oVwo1+uDuA0b2gXsxf2+fDbbKFkzwUqkqz+P04CPHiFXsCLkeWfBWOYNvuuvixA40IqmN2KNWnXgUwi6/yq5eLW3sxoepEh2YgU4vbh33L2n5cP3m/QSLN0f47KIxa/M1pZ5BXgX0FGKY1LW+wvYPbtaUnB9q7z7EJLP1von/O/urdUkrlHMei8hJOkQNwSxhP+k+vfWoN70IVLqPizG2s9wr5ZEBSHjG5dXSL0tbUjz1wgCWAdSQLaodI/bbpCFb7/J4B+kHgQoHzOVqRuVs X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(82310400008)(186006)(1800799006)(451199021)(40470700004)(46966006)(36840700001)(36860700001)(356005)(478600001)(82740400003)(81166007)(2616005)(47076005)(336012)(40460700003)(6512007)(26005)(53546011)(6506007)(40480700001)(8936002)(41300700001)(70206006)(70586007)(316002)(8676002)(4744005)(4326008)(2906002)(6486002)(6862004)(36756003)(54906003)(33656002)(86362001)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:35:13.3210 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa3bef2a-7f0e-43d2-a0db-08db98dd75be X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9040 DQoNCj4gT24gOSBBdWcgMjAyMywgYXQgMTI6MDIsIE5pY29sYSBWZXRyaW5pIDxuaWNvbGEudmV0 cmluaUBidWdzZW5nLmNvbT4gd3JvdGU6DQo+IA0KPiBUaGUgZnVuY3Rpb24gJ2lvcmVxX3NlcnZl cl9tYXhfZnJhbWVzJyBjYW4gYmUgZGVmaW5lZCBzdGF0aWMsDQo+IGFzIGl0cyBvbmx5IHVzZXMg YXJlIHdpdGhpbiB0aGUgc2FtZSBmaWxlLiBUaGlzIGluIHR1cm4gYXZvaWRzDQo+IHZpb2xhdGlu ZyBSdWxlIDguNCBiZWNhdXNlIG5vIGRlY2xhcmF0aW9uIGlzIHByZXNlbnQuDQo+IA0KPiBObyBm dW5jdGlvbmFsIGNoYW5nZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE5pY29sYSBWZXRyaW5pIDxu aWNvbGEudmV0cmluaUBidWdzZW5nLmNvbT4NCg0KTWFrZXMgc2Vuc2UsDQoNClJldmlld2VkLWJ5 OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCk1heWJlIGl04oCZcyBh bHNvIGJldHRlciBhZGRpbmcgdGhpczoNCkZpeGVzOiA5MjQ0NTI4OTU1ZGUgKCJ4ZW4vbWVtb3J5 OiBGaXggYWNxdWlyZV9yZXNvdXJjZSBzaXplIHNlbWFudGljc+KAnSkNCg0KSWYgdGhlIG1haW50 YWluZXJzIGFncmVlDQoNCg0K From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:41:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:41:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581101.909638 (Exim 4.92) (envelope-from ) id 1qTjR6-000519-PX; Wed, 09 Aug 2023 13:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581101.909638; Wed, 09 Aug 2023 13:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjR6-000512-MF; Wed, 09 Aug 2023 13:41:16 +0000 Received: by outflank-mailman (input) for mailman id 581101; Wed, 09 Aug 2023 13:41:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjR5-00050w-1q for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:41:15 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20605.outbound.protection.outlook.com [2a01:111:f400:7eaf::605]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 663dd44b-36ba-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 15:41:10 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8642.eurprd04.prod.outlook.com (2603:10a6:20b:429::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 13:41:09 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 13:41:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 663dd44b-36ba-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FL/jKIG07D/7FDLlDlKwU38FCdoXGzcS7emKy4s/PkxNerpnAIkvppPmdIVJRVEwt8+13t5SxmXro974cWiyZOIDzlV7nwp7jnXo7NcN3BtM0ZPyazNDiR1PpRNmXf9Z0vt0/UTuj43JUxl2ghVdydKKWaKjR+8lgciirQE1D2JcygQIcqtv3gg6pcdOOcUFpap5rGQyNUq1GFbIBLV5r0gyiN3sJJ4tqSpzIA1CqnrJebrSags8AMbl8C45GAQlduB+VKRI6FRlb8L4vEK44hNTkOhtGiupmSagQCVzWBBuYYT66QSv5j0mlm5SXuXh3ZlpRj7iQrvA8EcF778qgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IwLfT/HY8Y+KE1UDEXbyy7Wsk9vEplxTZdEr1YhPpo8=; b=WPSI0Px+6CS+ptK1WjRwPLaMMEaZKuAZ4mF+9OZVe4/KOM+HnWoV0QpgxTd0zjT8SjGA6sAlHH0bL1sfqueDuKnLkK0BCYPuU0eavYx70OmAEjdkUXiYHYjApKRdGKGP9L7F6Ayvnt6XWxVaqrJfxzNvRu1s52ytHkt9PQjlFOp9q9Ahgk+IKqR6vqWayCv3fTsG5TFxyM4xTbsFiWEiMTuab27qpx/Ma7WXzqWLVNnYAIDznPGN/APt4Ud3YwmJLW72dLotzB68+GAQUIIDhRn3ZqFbP2kEeaI8WuJIj+XLVHd6O8kKQpUo3Ss8BZjZK40grJa4n3XnDvq9BQxY3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IwLfT/HY8Y+KE1UDEXbyy7Wsk9vEplxTZdEr1YhPpo8=; b=iWsdFcsHL2AZHKTt49wMN46iAsIlFlIxvZCAkBjNWVqiHmsH1X4YwzlRNUkZ5f8DdBgt6xQwDazKuqpva5Attg5AwzUa/IWpoSQQ9Hm4nxDufR7C+4fng/Gs/SD3KlxPkh7Ht0uChE6KlEurrUGzC7SfHjrIRGypUaRORCOfktUNJWsCmiZ+KK/VcSk7xgXfrReAALLUht+R/C5zCM9h/1RTQ9Pe0RRJfHEmQVHAVpQtTS+oD6ijzI/dFDT6CmGQ7Ba0VVpkipY+PgM0Qa80PD8lWrRH+BszIOtq5vZtYUv9iUEY4usGVllMdlQKk8P+dSGmpvpztO/O9GlzTf3d3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <461a30d3-29a4-8c53-1dc3-42cdd50bdb01@suse.com> Date: Wed, 9 Aug 2023 15:41:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Luca Fancellu , Nicola Vetrini Cc: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu References: <844e7bf57c2eb7b20d8b1f81a7730a7612f1b6ac.1691575243.git.nicola.vetrini@bugseng.com> <2AD1EA83-AE7F-485C-ABFA-D285B4BAB1CC@arm.com> From: Jan Beulich In-Reply-To: <2AD1EA83-AE7F-485C-ABFA-D285B4BAB1CC@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8642:EE_ X-MS-Office365-Filtering-Correlation-Id: 73dccb94-5205-4b43-f768-08db98de4999 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z4pDWmYJSLnSEKCGF8EgY91/WtYCtFXsWo0WmtyO4h9d792RjPdh3md8UPZTcKn513BTvfkNEnFdkwZYZKOrKc8bMZ0vOlzCB/d4oAce2OwZQnY8I+dOKcQT8R9APEF+tA9sVL08187Wl/fU/4NYxSKfB3HgUyLpgr4I1fBQNP/ihJDIezF5YB5gCwUavg5GU/Hj5vkaZWXPXLqCtfl7U7/svT47QJZsORbTtzG5TJd/daKOx+T6gWzl5ss9ZqVGBrjyot777Me88bAEKWSKDj0hbQYBumw4DL3JutlFDOWdpcJagYG/bKTs9Uqd8vgUnYRIBUbIfoAAk/0rfnrKV+cfOET9riWxHdlsbRQqqUYCapSS5e/Ali6Eu501xpeA2C+gNCOPP/25bWnajvMXOCL9r6UnCU87cpZacXNZjzxZVzmJoJottMhCdGPSYt1e1aLC3Bd2iLK7uwHB2yP71TvCarUy646CQgfk9YMUUsaX+8nxh+tmyqdjVxKrqWhgXuor/SGzWTRFanUJ8z0fQWEKV7bOlBhHR/3NXogE3uKxmtDYibabhy9qnWj5ptjLc26jmsi23VKhdh5NZSZp7u5tNMLbt9Rg6FHQEX6nG+8ruR4OYLttYz4X+oQ9ez6fuTyZ6YGobQJtsoIYeS8Fmg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(376002)(136003)(346002)(39860400002)(186006)(1800799006)(451199021)(4744005)(2906002)(8676002)(5660300002)(8936002)(31696002)(86362001)(36756003)(7416002)(38100700002)(31686004)(53546011)(54906003)(110136005)(6486002)(6512007)(478600001)(26005)(6506007)(2616005)(316002)(41300700001)(66946007)(66556008)(66476007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnk4R0E1bzNTa2ZpTHJFT3NtajdFdXgzMUJXaWtwbjhkUmpLbjlSc2xIVzJo?= =?utf-8?B?NkdzSWtPSkJyclEzSEF6c0cwZTRnWTRDSEU0cWNIbHRiZW80WFdIbFRyVndV?= =?utf-8?B?UEhkbnlhK2NVUXNwZkM1OEVRREY1OE9EN2kwaFVOYUp5OS9xOHhkZ2M5Vm1T?= =?utf-8?B?OVdIRm1jWWRsSUxYT29XNS9lZmZ5aUVCVTNrVmt4VklKVG1IRzV1RGUrQjQ5?= =?utf-8?B?RVUrQkVKZ0tZRHdSZzIyUXN6c3FqZ2JqeVlObGNLaXNZNlNDa05kS21wVjE5?= =?utf-8?B?RWNJWHJnMnEzY0xHL3d5ZGo2T1d4Zk5idVVBZXFhY3NNWGxsZllOaW1Ta082?= =?utf-8?B?NUFQRWZ6MWVJVWtzUkxEUkFCbUdmYjRxdUlYVjRqdmVDSk1peENjWjBCczdM?= =?utf-8?B?a3BwdHgvZlArTE83Tk5GYzJWMU9VV2VWRjJnMWp5RlY3T2xFak40RDlkVXQ3?= =?utf-8?B?Z3NpZmNTRTFDMDdUTlRBWTZicmhranorb1huNXQzWjc2QUpDM1BhS0hiT05C?= =?utf-8?B?TjU2aUpieTM0U3RIZU8wWUNUSlFhVjhzbXZMd3h1QlNRWFRoQWZCbHZueTUv?= =?utf-8?B?Y3NsV3dEYmxKNHBNU2xOcURBVHk4OS9odmxCVnBta0VPdEE5TXU2S0hZcnJu?= =?utf-8?B?RnlyMldtQnYxRmJXQ21FS05nUFh4dFdEVm1vb0d3SHRkRGlKR0cwYWRlNzRT?= =?utf-8?B?NUdXNzJLQ0REeGM3MUxQTDg2ZkdPTnpoQXFwdENJYWhKSnhVZThBMlJXQnc1?= =?utf-8?B?WjVCVlNvRTRJZUFjc2ZCNDg1aEhKYUZFYVdKTGhWcnNpQ1dMSUxlZ2ZVb1lj?= =?utf-8?B?ZTY4cEJKdzNUZllldHladFo2MGIyMVNMY0NaeHdsMjlWTCtqSEdSRnNjSUpK?= =?utf-8?B?a2VYdXRTbTU5ektxV0ZEdktLaDMxRFBIaWVHNXhTa1grOEI5TmVqYlNDMXNJ?= =?utf-8?B?WDhVK2NqQVRaU205MmFsVkJtMzl6SFhLNmF0TVB5WEVaZ3JSbzc5R1dUbEdF?= =?utf-8?B?L1NyYkRBc1FoMjZHaXI4RHB3WkFudlBOZ1FQV1hHdGlKZ1hROTZMaFVHVm04?= =?utf-8?B?b0QycnlNZUdjOUN4Rm1WeXdWUEo5S0g0T01XTVhQalNZSzJpQlJaSnJWVkNZ?= =?utf-8?B?MlpVUWZiNlZiSGdweFpjM1ZBOGZkeGk4Tjh0bzB5YzJuZ3NMc24yVXZ5VlhK?= =?utf-8?B?b2x1TlRVSlM1TUVGZ0l1RG1WMXljRVFld1d1VVRnUUM4cENzWVMrK2VVbjl0?= =?utf-8?B?KzVNSy9qMG52ZVpWQ2s2R1A0alNSY0EzeVJ6QkxMQmhPUERSc1l4bW5RQXdD?= =?utf-8?B?aUpUZVFKL29qeVljbnNGQU1pTlJHZGlNQTZpOEJLVjFoYjdyUlpWeFh5RDds?= =?utf-8?B?THFFSzNwU1ZveitEeEtQeWFiWEhwbFoxWFJRTDhTUTR5c1FMVGk3cXRPMjVx?= =?utf-8?B?SUNKMXRjaXhlSVk1YXdtUCtoZVRvU2JFRUdMOWEyaU1PN0djUUVLWTZOQ1Nn?= =?utf-8?B?cWdEaWpGQVYrcXRjQ3ZxN0kxeXRSekEzSzBYTnhuL1I1Q01kd2s0ZjFqZ0VF?= =?utf-8?B?L01zMlpKTUFKM1JMVHd4akFhMlErNlVDMDR2WXZvT1p3bG1VMU9OWEpveDc2?= =?utf-8?B?dG8wa0U5TlU4U3RNSkFDMUFRREdSQ29tbGt6cXVXSEY0QlZYVDJqNEQ1RXU2?= =?utf-8?B?YWRBbHBiRGpLS0NyTjFxZGkxeEtuajBlRkhtaFlNS2IxSXJ6RmFuTWJ0NVR4?= =?utf-8?B?d1V4ME5VQ2FEK1FaUmw2NXFhM1RscTEvU2h4d2ZDSVhvVkcvVFdjVGIyMi9T?= =?utf-8?B?ZXgyLzVQdzB1T05udkRTS1k1VTZLODVnWEZBbUxBUFBRVC9HRzRxTnNaSjZo?= =?utf-8?B?SW9McW5FWEtTRHNSSU1lNXpQRlB6ay82dkVlcDU0WSt3VXR2V2RldmlBT0I5?= =?utf-8?B?aW5ZViswU05ML2xXWXYzc3NoRHgwanpXRUFrNFZHQ09PZElaNEFjOVhzOTd1?= =?utf-8?B?L2lYM2RMZ2NsekNqbWp1V1hrSWRIVTV0TzcvZENOaGFYN25sZXYvVFB2K1pi?= =?utf-8?B?S1JtdFJMM0MrcmFHNmNNczlFemtpUkVQWWxON0pjT0tkcVlRWStBZFdQdjV3?= =?utf-8?Q?xc9Vg0oPI778/eLVjRIFZXtC9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73dccb94-5205-4b43-f768-08db98de4999 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:41:08.9323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NfVOSxrTxMaITaAoX/bwuq0fHdBkIqSNMngCY9lv01/9UIRegzjgwjUJxd/Yig26Sk98JImYAfb9CIDvNhe8rA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8642 On 09.08.2023 15:34, Luca Fancellu wrote: >> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: >> >> The function 'ioreq_server_max_frames' can be defined static, >> as its only uses are within the same file. This in turn avoids >> violating Rule 8.4 because no declaration is present. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini > > Makes sense, > > Reviewed-by: Luca Fancellu > > Maybe it’s also better adding this: > Fixes: 9244528955de ("xen/memory: Fix acquire_resource size semanticsâ€) > > If the maintainers agree I for one agree; in fact I did ask for Fixes: tags throughout this series, but in the context of another patch. As said there I also think titles and descriptions want writing differently here. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:44:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:44:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581106.909647 (Exim 4.92) (envelope-from ) id 1qTjTo-0005a9-5c; Wed, 09 Aug 2023 13:44:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581106.909647; Wed, 09 Aug 2023 13:44:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjTo-0005a2-31; Wed, 09 Aug 2023 13:44:04 +0000 Received: by outflank-mailman (input) for mailman id 581106; Wed, 09 Aug 2023 13:44:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjTm-0005Zw-EC for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:44:02 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0614.outbound.protection.outlook.com [2a01:111:f400:fe0e::614]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc208c1f-36ba-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 15:44:01 +0200 (CEST) Received: from DU2P251CA0022.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::20) by AS8PR08MB5989.eurprd08.prod.outlook.com (2603:10a6:20b:297::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 13:43:51 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::4d) by DU2P251CA0022.outlook.office365.com (2603:10a6:10:230::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Wed, 9 Aug 2023 13:43:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 13:43:51 +0000 Received: ("Tessian outbound e1fdbe8a48d3:v145"); Wed, 09 Aug 2023 13:43:51 +0000 Received: from d3663516bddb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6EAC9B19-1904-4FB7-BE11-93A5909DE6E5.1; Wed, 09 Aug 2023 13:43:03 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d3663516bddb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 13:43:03 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB8116.eurprd08.prod.outlook.com (2603:10a6:10:3ec::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 13:43:02 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 13:43:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc208c1f-36ba-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/Yj8Ae1uxprVYPAiU4vBf3XP8MCk4USbss9Nmn4utc=; b=FqUUx4rviVmhrL1sQ6ES9Qwg1s1pmx2lINCZRhj4fCoOdui22s1cCck2SsvclIQZuLRh0G/PyNvxhhECl7BQQEcSKTr0y9/d6e4cKxqffaeb9OgkxD8sh6J8GSO/s6v3E2+HCOGDfFTv0gr+73j1zTpFs1DylbDmn48Kikx4gSo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: cdd756b83d2ddcac X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bhspUFx4EVyOE5wl2kcyP63Fr1ycDh72ZskEqRYcSPj8exdNnXI7ebODNf2Sb7c6S9SGSNCWLnj0DXX8pSGPn7Zo7wB28r7baP/Ul39KgX04J4gf0srjbmVwQlKVcTZ0EMFCwGDRBH79slgI1hJb97dTwQ5v/xf4Z/WcCm7VGJZxTuQTG9CSL6YvjodroqII1iyL3p31j/XtgCVYRRPUHfXkx5I6bHdkIY9Ft71vYUlWbFTRoiatYoI5kw8F2K+VNQVkGP03Ap+OYa3TtK+A1lPVE3h0O3yAOwLq3muMIh180Ko2rFxOiGJSBAIzeQ9dvY2DxT3etNrlNvvUWbUPBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u/Yj8Ae1uxprVYPAiU4vBf3XP8MCk4USbss9Nmn4utc=; b=cdSHLd+wL5Hg9JHPpaWcL+cIfG44GK/hZ1WiylzIUNzaP3u01w37tceYBEvuYfLJs8dCVhf+XLf4MrHxej1Nv2dsj0OqosmCp08fZf6iXEZ42YK2XXlttFPyrjUIblUfjx9XO16cBY/Es/K7QnxNm7iU2mkn86qSwzUdskeq1wFzJ+XMyMDSkJIwFp//33In6l4+u61XRKYD6SVCTZTA7cASqh0GSnicggnNrmRaSKlFpGLdbTIY3ipDBOeBmOIaN0CeT0F/L+rboPG8MIs7LqDJyzGyTLtj0Gj8NlVBcCvoFLWZnHMgWdcDVbX+x/vmV8UQS0n9TkFuiH/SB5kMAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u/Yj8Ae1uxprVYPAiU4vBf3XP8MCk4USbss9Nmn4utc=; b=FqUUx4rviVmhrL1sQ6ES9Qwg1s1pmx2lINCZRhj4fCoOdui22s1cCck2SsvclIQZuLRh0G/PyNvxhhECl7BQQEcSKTr0y9/d6e4cKxqffaeb9OgkxD8sh6J8GSO/s6v3E2+HCOGDfFTv0gr+73j1zTpFs1DylbDmn48Kikx4gSo= From: Luca Fancellu To: Nicola Vetrini CC: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [XEN PATCH 6/8] xen/arm: mm: address MISRA C:2012 Rule 8.4 Thread-Topic: [XEN PATCH 6/8] xen/arm: mm: address MISRA C:2012 Rule 8.4 Thread-Index: AQHZyrEdmNcwigzYukmEfRcETstuuK/h+WWA Date: Wed, 9 Aug 2023 13:43:02 +0000 Message-ID: <0C30A959-AF46-484D-B44B-058A86799FE6@arm.com> References: <67163dc4bc2e44d3f70f9c49295b993663d2fd5a.1691575243.git.nicola.vetrini@bugseng.com> In-Reply-To: <67163dc4bc2e44d3f70f9c49295b993663d2fd5a.1691575243.git.nicola.vetrini@bugseng.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB8116:EE_|DBAEUR03FT060:EE_|AS8PR08MB5989:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ff88c4c-ea40-443b-4a3c-08db98deaa96 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DkMQ3+89bXg08Z1Id1+QflRLmYwA1msT3uWtWsLkT9IJkJ61WPiMENiqBXA3NCYPSoBVEefA6Lmf19VX74OXm8HUbZ1e/tzWhePnvPw8E5jSAzIWCwueFlR46dwZnuDSM9Nv98WRkGPAEaY0HMQ916FweTn56IOaaN32bzYv7PEi7/vd9lCsGuXQFPzO+CifCJ5DwacsId3rKmsfiSRJYeCEiQTknATKyNlgGtqkTOakHKcZ5eq8WS9Pf048ASiw7+CtnS3ZtbbWAJZ45Rf9BOk8YSweIdQb7ImjMFyIr+wGbE6Of7lbIFeyjdd2pq/9UNCKZBwzciIlwxs8RpEmbF2IXLMjuQ/UbxeyZ05u13f/MwGCNsRN81CkstCgUJIML46XTrRPFpI0daa0h/KMQJMJR4lsxyvrm2g+0nt+jyZ+VGr1EZNdh3olO+wqOQPvNOvUohiRg0cTK58T3qWip1OKPawzFV2ZqZe1zRnMB32d5+fgZdePOJx4nECbs+xfBlI8MgGAi5UaH2FDjJRv4qnL1Ub/zyVDYNDy0uG6H12ixIKA8sbgT39dLe0HEn5aN1SljXJkyAkclVSpkmpXFqS8/PiW2L0yd26kzwNW2d/L3TZ6NPqRylNbirisBZWTG8trVH8+eLEtPepbHnZn8w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(186006)(1800799006)(451199021)(316002)(2616005)(2906002)(122000001)(36756003)(71200400001)(6506007)(8676002)(5660300002)(53546011)(6486002)(38100700002)(26005)(66446008)(64756008)(41300700001)(6916009)(76116006)(66476007)(4326008)(66556008)(66946007)(54906003)(33656002)(86362001)(91956017)(38070700005)(8936002)(6512007)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7EBDACD8C8EBD24B872027029807A142@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8116 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba0f673b-1880-412e-92cc-08db98de8d2c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IeFO1/2uIuWmRIe5j6mAwX5v2KHn+ypKco9khijrVrk92ZxMKRlMdIUalc1eNrNDlRwB/CP6aq/Kbekg7AdN/ionrmxh5jSLyM7cp2Zt0MSJywJigFmHDB0xx5qzZ+uEr5PKV6/DGo2zIUk0cdk/JM7CeNs/QfWbdFsDmg4oozz+R+IKYDXsRJIs/GgAqjI16N5t3LVbCGANavN8uyORluFdyToXDwqNBKNbDZdrZHnW2K5Z8tWCDUnam/39dVRUFRXwfdlWANjWkPTorR6hOC/l0e7tVKbspmnZvLAiQ1Z0xszczwRU9UxBSPiukUw5SoyW2KlS6XoKDmcwPIhCQXUxBMGHAoznswLPZxttkiQNvO6Cd0gzCxDDUO9PmrD5BbAJ7/F1uIY95YqeoxTmh/rpH0/4gWlSka2GTtG/O9XM9VPXM4sNwbnI+rpDJKH1MoFGvu+UO1MpfSPRSzvu+XWMjSqiQvELmm3aDeTQFcUFHcfgYuEVo7iAt8eEdYaUvQ3O1OY/YwfHQnC62mC/5DIZ/ToaX8BJLCE3lGiLNlQCUBdfUxl70WUDgLi9XZiptiSLr4jCL6KSohbeGvM4NhvKHWdMasc2fmNM2gpwlRz8n+YGfpPybhQVJVtdp04qhwpCo0ooFTvbiPCVxNpyxTWt8ftSNccEshVJvSYzt2lx47Jzy/4OaGmGqBzcVgGgwD3ZDhD4xokp+qFxSp/ObsTGkLUY/0hFp80U6jcQreV8H985e81MuCqw5I/VPZ1t X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(82310400008)(186006)(1800799006)(451199021)(40470700004)(46966006)(36840700001)(36860700001)(356005)(478600001)(82740400003)(81166007)(2616005)(47076005)(336012)(40460700003)(6512007)(26005)(53546011)(6506007)(107886003)(40480700001)(8936002)(41300700001)(70206006)(70586007)(316002)(8676002)(4326008)(2906002)(6486002)(6862004)(36756003)(54906003)(33656002)(86362001)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:43:51.5038 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ff88c4c-ea40-443b-4a3c-08db98deaa96 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5989 > On 9 Aug 2023, at 12:02, Nicola Vetrini wrot= e: >=20 > Add a declaration for the variable 'init_ttbr' to resolve > the violation of Rule 8.4 present in the associated source file 'mm.c'. >=20 > No functional changes. >=20 > Signed-off-by: Nicola Vetrini > --- Reviewed-by: Luca Fancellu With: Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bri= ng up") If maintainers are ok > xen/arch/arm/include/asm/mm.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.= h > index 5b530f0f40..698e54aff0 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -165,6 +165,9 @@ struct page_info > #define _PGC_need_scrub _PGC_allocated > #define PGC_need_scrub PGC_allocated >=20 > +/* Non-boot CPUs use this to find the correct pagetables. */ > +extern uint64_t init_ttbr; > + > extern mfn_t directmap_mfn_start, directmap_mfn_end; > extern vaddr_t directmap_virt_end; > #ifdef CONFIG_ARM_64 > --=20 > 2.34.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:47:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581114.909658 (Exim 4.92) (envelope-from ) id 1qTjWq-0006FH-OY; Wed, 09 Aug 2023 13:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581114.909658; Wed, 09 Aug 2023 13:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjWq-0006FA-Lf; Wed, 09 Aug 2023 13:47:12 +0000 Received: by outflank-mailman (input) for mailman id 581114; Wed, 09 Aug 2023 13:47:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjWp-0006F4-UU for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:47:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20626.outbound.protection.outlook.com [2a01:111:f400:7e1a::626]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ca472a5-36bb-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 15:47:10 +0200 (CEST) Received: from AS9PR05CA0085.eurprd05.prod.outlook.com (2603:10a6:20b:499::21) by AS8PR08MB8972.eurprd08.prod.outlook.com (2603:10a6:20b:5b1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 13:47:03 +0000 Received: from AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:499:cafe::87) by AS9PR05CA0085.outlook.office365.com (2603:10a6:20b:499::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Wed, 9 Aug 2023 13:47:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT015.mail.protection.outlook.com (100.127.140.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 13:47:02 +0000 Received: ("Tessian outbound f5de790fcf89:v145"); Wed, 09 Aug 2023 13:47:02 +0000 Received: from e50cb6b2a6fc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 13122922-4605-48AF-A6AB-39F962C47799.1; Wed, 09 Aug 2023 13:46:17 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e50cb6b2a6fc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 13:46:17 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB8116.eurprd08.prod.outlook.com (2603:10a6:10:3ec::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 13:46:15 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 13:46:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ca472a5-36bb-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VIERSjKWNtMQeI30hlttanV74S1x+tMjIBCWEsekEDE=; b=JS/9zyPB/Lz+pCT+egWgsbfaWN8sX+ykeMT+FRjgQUs2NTGzJnXaKBc8rSfu6ZcWXBbSqksiP24j2NXNqUAezrlBbIq0LN+XUYH8OTihDKjWaUgAKIYz1iR8yJKUmv5GpkyB5fQb3gxqnQivrEqUKfrJEC8kTBhGNxA2kzt8xtU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b44125c2c1412d39 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kq67HLxrFClvX6EG2b1kHk+9kB3nrZE02/XYCwOJJEBwJbEY33YgChYeVYMfLKsAUatuOrov3pNIB3O/d+YOo58cktSQ7He1oZOkzIDmjsOLbLcYOCwFkrkZgvELH7qt4rxPfjp1u/JiuX1HLoyawMupCvqarTzZJGbRueFRy8yfP1DHm4khvuiVo6IJgl5FJrHbegOWUMvSSYXrd1mIfL+OFs5/tmIixX5bGvbfkKS22ScQAc7JWc8qXXr+4HvJV2ppKubRS8HLBUDjfqgLPEpCFiPkimslq1K8qzKmEHaxLc6d+OtgI0Oxr5whFnARrwnZA9ADXIOet6MCt8ik8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VIERSjKWNtMQeI30hlttanV74S1x+tMjIBCWEsekEDE=; b=MYtw+7feV3Tbt3rUSXPhZHtQgrq7xJWL5s8Ko5fvZ0aw0a8ijMhEW0/GaWymEE4DlDcZRCJcOuq0E+Y6jNw6eY2TEw0yZQNE/AZ+vT4H/piOvqjwHbDZwL8t3MPtMjW9KwZTs9v7/VCesq7r5xQLOkpE9rL1o91C/BetdYXNabpB3TEdYJFoBWB9pSOyuwWYqs6X7nz2SvoqAlEQV4b2odDc8aewQw/EoTaSzkGteCM2r1KgGM4ez+ynnaIc1IE1c5obodQwHoQ0WbWEKoujguXIgHkO+m3EcHp9AYhfEMPFuSbFSIdpb8JgID+jPSR8IG1w2L+ue6x9uNZGlLpmgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VIERSjKWNtMQeI30hlttanV74S1x+tMjIBCWEsekEDE=; b=JS/9zyPB/Lz+pCT+egWgsbfaWN8sX+ykeMT+FRjgQUs2NTGzJnXaKBc8rSfu6ZcWXBbSqksiP24j2NXNqUAezrlBbIq0LN+XUYH8OTihDKjWaUgAKIYz1iR8yJKUmv5GpkyB5fQb3gxqnQivrEqUKfrJEC8kTBhGNxA2kzt8xtU= From: Luca Fancellu To: Nicola Vetrini CC: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [XEN PATCH 1/8] arm/efi: address MISRA C:2012 Rule 8.4 Thread-Topic: [XEN PATCH 1/8] arm/efi: address MISRA C:2012 Rule 8.4 Thread-Index: AQHZyrEbxFin9q0gU0Kc4Cnx0VHQla/h+kkA Date: Wed, 9 Aug 2023 13:46:14 +0000 Message-ID: References: <4d087a54edb3f92e9271e3d01c1abebf00d3e298.1691575243.git.nicola.vetrini@bugseng.com> In-Reply-To: <4d087a54edb3f92e9271e3d01c1abebf00d3e298.1691575243.git.nicola.vetrini@bugseng.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB8116:EE_|AM7EUR03FT015:EE_|AS8PR08MB8972:EE_ X-MS-Office365-Filtering-Correlation-Id: a3b4435f-c8b3-4806-8d9e-08db98df1c66 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /Pu57sFhVnhcIBRCK1cwPqGS+Epw+/EDIT5ZOL/XK18iTSQKpiywBpc+Giyq8u5bDYISrz/x2TfX7s6kXeTHP5Dhv18R5qr8iEaXScGg3jPuXHr28TY7beiSOn1aveP4qPBefGh5w3Lvyjyvv9pawWPJFuBjf3eAQDA0xYLuG0OGK84ZBn4RH5D1fbh4bSZS/37BopxD5Gb+OQ9utgSjq3ZLBfl0wVLSRdHGgFlV9Y3x55ElP83FzpRui/dag2zOM53wg6pPc5aP+nYeF4peL7V1Lv1AmVnC9cein0sgx3Ze3Zs/z0AFVLlZsUsrHu9sEe1ewwge+6I1uxx5lzC3xZQ4NzLRIPCJ4MGtIYLetilpc5lBNpHuowuI/qc0Jge4GkyisjN9BHwjPueY51a9a070WO54/ILPyPMJOjLacChyZt8vAayX5wG1MdEwfje1e8XkeJLHQvO8fTbqtD4otcrIpdwQSmX4Iqt2/4+roS86d34a7x8bZO0F7i4UMnXw8GD0ecqplE7FDHXIvGZSS3OQULZNtngPj//fqcQQ81ckrBHFcA5aOBBpd8hvV3sdgdS7clw9ZmNlCQIsnV8q3wAnSuLhpQZGA+HCkAyYBGbYRzW+OBJg/u9AjA/zu6K4P4+tm3/ycRdqtF5xfPMFWg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(186006)(1800799006)(451199021)(316002)(2616005)(2906002)(4744005)(122000001)(36756003)(71200400001)(6506007)(8676002)(5660300002)(53546011)(6486002)(38100700002)(26005)(66446008)(64756008)(41300700001)(6916009)(76116006)(66476007)(4326008)(66556008)(66946007)(54906003)(33656002)(86362001)(91956017)(38070700005)(8936002)(6512007)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <0A52F88E1D468D4D8879FC51DF280EDF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8116 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 02ad181f-192c-453c-9a72-08db98deffb5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fu/Q295nMAvQo92MlKZZJaE9yF8bSFNeyOK+4/qSmG1VEatG6rCMrfUtXhvSBfUmBNZtiOeN5rItp74oiTgEqmov11Lu5AaGmr/VfSybSmvBYRdqxuCi4IpIylO2C7zLlMe+YMblsoYXUgv4FKUIom8NwQkJCgz8A7YTP04YfL1rsVNKBLrzEB5J3sPvyEQjlzeEHbHH4k5sbuMP+rvJMSy8fO976aj5wMoJ+THJAQarJwxcXmqxkefnPqnc8/C8mo84Lwczv8UOq8nPXMJpHJW437sQ5zFzIby3V+Djyq6psfV0X8vywjddUwbnriSgdgvueb+56sKIiY+YbVGy9rMl8Pogv8C0TVZF0ajbagc9laEgu4QT8jEVZ8LribqTXlAdd626q9F1d8zjgognEem40pmkgO/Z9Ep9075m29HbXF+rPDqIXuwbHRjgb8x+rsf5UbfjBktUK2PqthH/xQhIogP+Hj8kaI371eUqu8S/oooihqK9HSml92vi+3qy3hEssLpD8wSYnYJIMVkgDR1JJh0YKkBWBs4NaKIq5UqdTNGH0/dOv2fkD288Nd7BPPFkYgMz7AQliANH7TVks+4BGhcZuVJDrXKtcF+n+kJOIFYw81TDCe+QjFTL2iSc2zX3rEOY4JWWyZQ6Nu6zol2F6YFjZcKGFzDu05cDuPOIsRPC8D22ME30aoS4/GB2PdLZSCk5bve4nUUIKqyN/q5eDjKnH44Wpkj/2Co3jHIAyhdjz6vnEMrHeAbyc8jS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(1800799006)(451199021)(82310400008)(186006)(46966006)(36840700001)(40470700004)(8676002)(6862004)(5660300002)(8936002)(81166007)(40480700001)(356005)(82740400003)(4744005)(40460700003)(2906002)(86362001)(2616005)(6486002)(336012)(54906003)(478600001)(107886003)(33656002)(26005)(6506007)(53546011)(6512007)(36756003)(4326008)(36860700001)(41300700001)(316002)(47076005)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:47:02.4044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3b4435f-c8b3-4806-8d9e-08db98df1c66 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8972 DQoNCj4gT24gOSBBdWcgMjAyMywgYXQgMTI6MDIsIE5pY29sYSBWZXRyaW5pIDxuaWNvbGEudmV0 cmluaUBidWdzZW5nLmNvbT4gd3JvdGU6DQo+IA0KPiB0aGUgZnVuY3Rpb24gJ2ZkdF9hZGRfdWVm aV9ub2RlcycgY2FuIGJlIGRlZmluZWQgc3RhdGljLCBhcyBpdHMNCj4gb25seSBjYWxsZXJzIGFy ZSB3aXRoaW4gdGhlIHNhbWUgZmlsZS4gVGhpcyBpbiB0dXJuIGF2b2lkcw0KPiB2aW9sYXRpbmcg UnVsZSA4LjQgYmVjYXVzZSBubyBkZWNsYXJhdGlvbiBpcyBwcmVzZW50Lg0KPiANCj4gTm8gZnVu Y3Rpb25hbCBjaGFuZ2UuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBOaWNvbGEgVmV0cmluaSA8bmlj b2xhLnZldHJpbmlAYnVnc2VuZy5jb20+DQoNClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxs dWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCldpdGgNCg0KRml4ZXM6IDZkNzBlYTEwZDQ5ZiAoIkFk ZCBBUk0gRUZJIGJvb3Qgc3VwcG9ydOKAnSkNCg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:48:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:48:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581119.909668 (Exim 4.92) (envelope-from ) id 1qTjY5-0006pM-36; Wed, 09 Aug 2023 13:48:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581119.909668; Wed, 09 Aug 2023 13:48:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjY5-0006pF-07; Wed, 09 Aug 2023 13:48:29 +0000 Received: by outflank-mailman (input) for mailman id 581119; Wed, 09 Aug 2023 13:48:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjY4-0006p9-9W for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:48:28 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061e.outbound.protection.outlook.com [2a01:111:f400:7e1a::61e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a78b682-36bb-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 15:48:27 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8904.eurprd04.prod.outlook.com (2603:10a6:10:2e3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Wed, 9 Aug 2023 13:48:24 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 13:48:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a78b682-36bb-11ee-b281-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qt3jCZT36OvyLyjVbuYqBu1bRoW+ETHahrim5JAfj7b7Ikt1HSVTJMD6FVzWl5zLC2SFLVIzXsngIj+y6PDloC1Hj+ZoBQHVXJk/6vfIwGbIwdxzohaAezDKOYMkgh2sQf5p8YrDgtDICxs7osVysRQWlBoI6HIepRQIS81Yv4uZQN855etPAHTFaOmZFagEMDkUUiSiPh0APZkny1dRG5jWIXH5uAFOzMFCcT9RbhKcYCbH9qtTUGkx7G0qkcHBUJv/xRAowIIOJQxwOlOXjWj2xD2/hIsA2gl4AZ1/fC/v+cHw+SbQ53y5GEEYZu5J2Yh+yDgoICsQwV+5mpZKtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aiX0nx08s7rsrGTCb7zbmS6NckAEj1pNnvMYg6Sfa+0=; b=WVAJv7nKRNDzSoRMp3SMt34MsnTHaG2RFsxZB0Lm1fOa/4YWwl3wwHI+Pv/4Ptc/kwPcvELc97VwjWGs3B+CPm6mHlhseeuJpAzUSg74wyChl1Tp4psf8Zp7zynaS1IuQoG3sE8+7ArpMEIXliogu8WzGJOAGC0ZSy82/ZFRUVXnZKeY3k2+X60cdx5QFXhxi5TREr/x4wH0iWbyZoc4jHcOzOF+jezy/c7T0QPMGdobnzITVlMTReT3LPQnJrEc0uqNGLwx3Cq70mvFd09ZFUQYUKqJ/Z7o9l0KjAuceHuLW+lubUnWzLuoCZ5U4e0S6xB3V8Ce9I/dd1wz6Z6fPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aiX0nx08s7rsrGTCb7zbmS6NckAEj1pNnvMYg6Sfa+0=; b=Kf9dXCWmmK2jjoWs420lpld5v5ej9Z3N4iVKbEI3FsegTegtT3542dbBQDOGdEUb8DVybbsi55dqZY+2xSIWU/S6hMz/aGlsuijpcAc55W/eQ/N9Vu0uWJa0X0JmhFXAIsP/V6JhLlATiTiSaXJTHkZALwx/xJWKpAaHHQScTzOlEbp7pbVWadkgx82xc1KTKcTMbDFQz3PuVDsUFU/0Kzm8IuDLsWy+xEsSpHlheUKPZeFBhbuG6NHZaFH2jBUqM0fuio0qqEvapDfoh9ClaHJJ/ePDLBj5BKx5t6BHhcwDKT08ZChIJPeB7yCRP2ZbohG822DjjVE09j5OMlJ4vw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <076d7588-8fab-51c9-f382-58350c91cce8@suse.com> Date: Wed, 9 Aug 2023 15:48:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 5/8] x86: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <4a07e7bb893f3d96e007ef6ccb645eee0d730489.1691575243.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <4a07e7bb893f3d96e007ef6ccb645eee0d730489.1691575243.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0241.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8904:EE_ X-MS-Office365-Filtering-Correlation-Id: b3a2ff42-93a6-4b8d-2bd9-08db98df4d67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L6749WGXf9evcQ15JOS6gquaWWlrtTFDyQfgfzuPJ8XPPgEsXpSQPteErVr9lGY8TMKdDl7KNitrZQSErNRDNBdjfV3j1XYpWDb4tXogDIxfGF58u2YOYziP3raAjc8nD/k+ByRKprcgFkqvIw4wt8UVdTFnE9vco5BRxpU5aCY6qKGuxJ4GWwm1bmNL9zLkNpR5NcfoJskH8UV5tPaehFKCmdR2dJ2yRGqlCV/PtsVpCdcF+pdcRDe1dl1XBX9RraTzwLpVjs9z5zaxQcya8O1UKR7w+nC+gDTDcC/JtLVbWjWuutjJ5FqLgDsKlHnWD6/1KkTyloAlrbEfesl1QbaaZlfiuTqhE35WYOaH/bWG2ig6B7oabx9wpmnUU448nGKRSwfZjovW9OlWq5wu6q9E7Or3HTvuy1zrvEr4VwzWLTMLpmv96wIvS0bZ8ywA89Bi1l/ieopV5Uo2BmHE2HbAiZjKHblx4HI15vxNRU7sMzTNTYXv64O1gPg2V8k5/AIlKNCHWMeN9rKWr/6+gC0yvIOXx3E7mvJrw1JnsoQSwJiZfxSxyAcYrVZwHPbz5Jq/WLT0OpsZ75EW1aVnXRL7z38eG3XGrlCRJX7LVcF2t4Y5iVs8UghFl4pKVAEakwcNDRKiGS3dAeZeZRxtqg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(346002)(376002)(366004)(1800799006)(451199021)(186006)(2616005)(6512007)(36756003)(4326008)(316002)(6916009)(38100700002)(54906003)(478600001)(6506007)(86362001)(6486002)(66946007)(66476007)(53546011)(31696002)(66556008)(41300700001)(26005)(8676002)(8936002)(4744005)(2906002)(7416002)(31686004)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0FaRW9TdFNwS1lhMWpPRWlrMlppUGRHaHp6aXBnNEpNb1FCWGVCOVRHeU5Q?= =?utf-8?B?TTlsbUlMM0xXRUg2M3Vkem1obDJqR3B1ZGxpdEJ4OEZZWGk2TGRBNVBXT3FY?= =?utf-8?B?QWhWRFJGYVVJbEw2Q1cvZmRFYkFjTTlZRGdGY0lzallJRlE0VFZ1bmVreDBw?= =?utf-8?B?TnhXdThsMHpKV2JSVTNOUGVQK0w3L2t2RTVPQ0NmK1N3QTZraU9RdDEwNEZa?= =?utf-8?B?ZnYwNHU0cDMxSGhyekpqdWE0eFZVUCtqMFdrR1NUUnhwMlB5aUVHTmxKVTBl?= =?utf-8?B?eFkxTE1ETEZ5NkR0MkNBazBtTzJKZEhpYkxpaWlScGZ0Y3NtQXFkU01FQlQy?= =?utf-8?B?OEdUaVVGRWFsL2lLUnhEYzhOZUVVTHlFMXV1QlFGcUd2RUk4SzlkMlcxeEFk?= =?utf-8?B?dEs5OGU4TzZJTjhaempOOWNmdHlzai80QUh3dGxmNDI1SHhVUUJjZWdrbHJp?= =?utf-8?B?b1lPdTJBd2VVM1FvVkVyZVhHa251c0phcUpPQjFySjRCQWRPU09KQ1RaTCtF?= =?utf-8?B?akkzSnlTdTl5eE5QRHFKUjFZemZMVnNDSzhtdmVSNXlOcU8vMEZVcWs5bW5y?= =?utf-8?B?VUxuSEpMcXcrNVlNWTBrMHZpZytRTTlWNVRDa3FFU1cvWkZPOTg3OWlwT2dW?= =?utf-8?B?QW9wWWtEa1k5Y2MrRU43Zm4zcmV2eVhxWFE5dHhrOUlnWFovelNoTCtnbWYy?= =?utf-8?B?TzN6dFJUVk5oeVhwVktiUE00STBSWXFSMGRaclNZWXF6Y3NmaVV5b0lVZE0y?= =?utf-8?B?OHdkWmZPU1U4NnJlWEZsYXIxQlRHRWcwbGl3Q3U0dUJQaUlQaHlhSk5tNW9C?= =?utf-8?B?ckhzdmNWS2o5SHB0YW9GMHBLamZNS1dNSStGV2lweVQ2bUFQTHBpZGRINUF3?= =?utf-8?B?ck9obFRpNDJWODBZNlZpNDJGSFdtNzU2Q2NSVTFFRXczTFJnTmhXYTlvY3Ux?= =?utf-8?B?MWtaWW8waWZoSWZ4YXBlanJpcWd2NXdKOENjcWIzc0piY0c3N3FHaEVBUDVJ?= =?utf-8?B?cmJSNnNsNVFEVTdZTjdwYmpSUkUwZTVveFJmWm9kUDNCYWhiaElROXVCbkdx?= =?utf-8?B?eXNDQisvTC9hMWFCc3lvRWQ1ZUNoQ2NsNy9yZzZBNkhQSkF0QzZWcXV6czM5?= =?utf-8?B?dFpFT1ZhTGVNTXJRcE5KQTdZQzZWcFd3WHZicXBTUnJ5ZzBnemNHTEMxdTNM?= =?utf-8?B?eEZrMndEclo2by9XTEtheU81Wjh0Z3dqc29KVldQWmRiSmYxSHU4RmVsWm8x?= =?utf-8?B?SUFZT09IcHRvUkZPYjMvYXNzYmR0Vm1lTDQ1NFQxbTE1RnpiaHN0YzF0Vmxn?= =?utf-8?B?M2ZwcTlzUWZtQ1RpWGkwSGNJNUpwd211QjdQb1FLRGhqaURqSnR2WFcvSi9X?= =?utf-8?B?U2pFNGhnTDNqTmNkK1F2RmxlT01ydXlTOFFjRi9MY1NrQlppU3R3aUM4M3ll?= =?utf-8?B?cUd0V0JxM1VRZC84VEgxNVNYZjVkWFNVblFkcW1WSGpKbkR6TitNQ1NCNnI0?= =?utf-8?B?NHhBNjAybnl2NTVXd2FlSEZpZ2REUks2dDJjZGRQVytsQzlGVGZndHRJejVa?= =?utf-8?B?aHBmVUFSY0RCa0E0RnhUbUtsY3M0cHY2TnFROXBIMWN1MkVZMCszZTdsYUty?= =?utf-8?B?RERyZldwTjFCZ3VDOE0wdzZPTTQ0WUMvSUgzcG9sKzdKVkVkVmZDcWdySmk5?= =?utf-8?B?Z2x5d01FcUl3bFUwaEFYZXVxZ2dsM1l4TWYxRW5NNGpJWVdJYTN4ZnNxQW9l?= =?utf-8?B?YnZmSUV1VmxNcnhEQisvVVI1M2ZjbWt3a1dCTDV2SkQvMTEwdUZYZktjOEd0?= =?utf-8?B?eDFyajJrTVE4REd2LzdtbkswY05yRkJFemVRKzAxaERRK1R6YXRwKy9US1gx?= =?utf-8?B?Y1l1RnlZK3ZpWHNhL1Y5SXJnM2dXNEVQNzdSdmxPN0thZEg4WXluTUcyT1Ry?= =?utf-8?B?T3ZQTmVwQllIWGNxa1Y2N3Q5c1RhZE5Eb1ZIWGtkMW42R09RRExnbC9ZcElE?= =?utf-8?B?MmtYM1JJT2Q2Q0NxRWtBZWpWdUdKeVVyYXdVT1RnUzNFd0hUU1E1MG9ZMXFu?= =?utf-8?B?MFRRTXV2d1JHbDZlRlJ3MTdpVk1jQzFXMTFVZlpLeDJGcVp0RUNJazNVRjJu?= =?utf-8?Q?Pif+sjzz/WuPZ4w+Z1SBR0wgB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3a2ff42-93a6-4b8d-2bd9-08db98df4d67 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:48:24.8015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y8cQBzT2dFMlSfPpWtOU2zeGR9ypAsmnaSrgFCYCgv6yHRqTCXGcBCTlBdiKSSE2bEfOER82vc9zqLQauYyZWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8904 On 09.08.2023 13:02, Nicola Vetrini wrote: > The functions and variables touched by this commit can be static, > as they are only used within the same unit. This in turn addresses > the absence of declarations that violates Rule 8.4. > > Signed-off-by: Nicola Vetrini I'm happy with the code changes here and also in patch 3, but please make the titles meaningful (in patch 3 the prefix also wants to be more specific). As mentioned, the Misra rule is secondary here, and hence doesn't need to be present in the titles. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:51:40 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:51:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581126.909678 (Exim 4.92) (envelope-from ) id 1qTjb4-0008Gr-G1; Wed, 09 Aug 2023 13:51:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581126.909678; Wed, 09 Aug 2023 13:51:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjb4-0008Gk-Cz; Wed, 09 Aug 2023 13:51:34 +0000 Received: by outflank-mailman (input) for mailman id 581126; Wed, 09 Aug 2023 13:51:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjb2-0008Ge-W6 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:51:32 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20609.outbound.protection.outlook.com [2a01:111:f400:fe12::609]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7f622a7-36bb-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 15:51:31 +0200 (CEST) Received: from DUZP191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::21) by VI1PR08MB10029.eurprd08.prod.outlook.com (2603:10a6:800:1c6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Wed, 9 Aug 2023 13:51:27 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4f8:cafe::a6) by DUZP191CA0025.outlook.office365.com (2603:10a6:10:4f8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Wed, 9 Aug 2023 13:51:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 13:51:27 +0000 Received: ("Tessian outbound 95df046a2e2c:v145"); Wed, 09 Aug 2023 13:51:27 +0000 Received: from f6a2c0602c2a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B601A46D-BB41-4652-9D43-B04EB2D1E5F4.1; Wed, 09 Aug 2023 13:50:29 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f6a2c0602c2a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 13:50:29 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB8116.eurprd08.prod.outlook.com (2603:10a6:10:3ec::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 13:50:28 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 13:50:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7f622a7-36bb-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rQNT8PERyXuLdsuD19oU8pXPPzCvFl1yWXLc6ZmLdpY=; b=G2KBhp95grLb9w0jfyyjSzMOZNnAoZzU9QDROjJvF1f/7DDtRxqy5qC1h/6aFHpWesB1hHkaxT0ZCKofeDnjq0Ts+1RsUn+GJ2TwdnBWJwCEw3TLmsRvpT0nPNV89WImNzGt9hy6tRzh+RX1uIVUiZ8mEzJUXRUOT9kC5cG3CKI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1525b17b58706906 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPtCBT5Rnpid7iK/ZcGhhlf7Qp4fxjFTGBTm3Ei970N4p1E70Tfr2/SfocY6bnAfaP7j9JBSdt7vPyohxS/eF09kF/6v0M79ztKgQV0P2IbLQ2L2mxcYOmhSmgJA6e2/30SlrBEUkpleq82uDio30MqEcFBooZ8eS414JYc9JB6iACcvyxoszoQnzZ/YoV/snL5pAiFZQPtUdnaumOm+O3IvGkJf2WXoly6ut4hffewSVMzgEe/F74fOgkwuwdtXmRIqs5b1cMoFNPMb+GVaQ+Uthn/b33Bw78b/2/F8csmHRNU7fVzjxFnkjr6fDWa0W9d3w2dxxVIzCJT58oE4PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQNT8PERyXuLdsuD19oU8pXPPzCvFl1yWXLc6ZmLdpY=; b=Yq/o8+wJpgYcicfD+VY562WIsmbgmU70RicVLYHvyGWA9pUP0t8QSJluJdi8vqZnj9ejykTPJOyNoOkGjLugwtNuQfSlA6YJYguFb3dgFyi31Dni4XETRbwzL3HTioXqwqfAnjfdQXaVeqme2UAwYYRBxKsPpU8GxXf+7pCXuk8mRAEjvwSfkMd895u1cDYm+54csqY+TqU2NEGK3C/OAvpjZty94KGmTKAGcPxoX5QbkSqewF4rLwnPKAJGvpUK6OEIedwPWShPslFEXorEefUPtKjs79aFf8xVpCch/1hVzbH0rIUpw9XPtrmiGxZSdpiZtg1IcDfciAQFwjZcsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rQNT8PERyXuLdsuD19oU8pXPPzCvFl1yWXLc6ZmLdpY=; b=G2KBhp95grLb9w0jfyyjSzMOZNnAoZzU9QDROjJvF1f/7DDtRxqy5qC1h/6aFHpWesB1hHkaxT0ZCKofeDnjq0Ts+1RsUn+GJ2TwdnBWJwCEw3TLmsRvpT0nPNV89WImNzGt9hy6tRzh+RX1uIVUiZ8mEzJUXRUOT9kC5cG3CKI= From: Luca Fancellu To: Nicola Vetrini CC: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 Thread-Topic: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 Thread-Index: AQHZyrEYmlGLQrMXXU2mT8iNskDvw6/h+3gA Date: Wed, 9 Aug 2023 13:50:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB8116:EE_|DBAEUR03FT057:EE_|VI1PR08MB10029:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b5c3c18-196b-4c73-c6c1-08db98dfba4f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Gl/bhcZALul2f0hbF3VhQybofTByrHnLoFP5kaQo2BBbAiiPZ6Qn94EQtSbNK1Foh4qq2bTtj3bej3AY2rRxJ+LZikbiVvQKLW1rFVSWAFcU5mzTU6xg3HxzHJFHUzIJET61+mKWSV8s1a7IPOeQjw1ypv9xGdBE3RpzAnFHz8vyf9G6SvY3YwOyMPPBKPY0Pl4adIVxkc32c5WioZoA/XUCoof+SvgPHpLHuBzijsliO03ipi/siWcIye9qotOcY6hE5V5WOjIGdNVC3+RAICWu6aVaed9E7CoASIRDtvN+/F4rZnK+JKVORc04IFp6cX9TLuA38ZVEMCqjtIERdUrFftUaFhG6n3vX/0rG5mheoNZsTvFVxINC7T/RyvfZkUQJLOwkzspNZwHWJdfMEA2A3+fLBWBrrmLTjGHW423A+8sWQljfQIw7l24ws39EqTPTMi4rPsuixxUcTZZJUygQDyd2gujP6p6e1yTYqupknJ2kVo+i9i1byc1j07iNGmsb8ihdnD5Yf1/A8MPMldtWI32t+a3A8rK/Og8fHSB0d231KqofzttqHZV0z07RA3K2WBiYNgjyfdkf9cUXBPd/SYHqhf/SzFsO/FrooAqkXLdMhM3M82aEJwEKNOFvNgHR5Ildiz/riRn3ajUqGA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(186006)(1800799006)(451199021)(316002)(83380400001)(2616005)(2906002)(4744005)(122000001)(36756003)(71200400001)(6506007)(8676002)(5660300002)(53546011)(6486002)(38100700002)(26005)(66446008)(64756008)(41300700001)(6916009)(76116006)(66476007)(4326008)(66556008)(66946007)(54906003)(33656002)(86362001)(91956017)(38070700005)(7416002)(8936002)(6512007)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1902852551DCDF469E7FB038272FA202@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8116 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f23349b-5c61-4e43-b9a8-08db98df96c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sakAe8Pya6lKQ2I+KN+oao/3o4bhSYyvrdH/9vdcGcNfM8qkxHAjNS0Wll8yhL8Vzr49AX5Y+FwxuelhjQEfSH96wxLtdDWtORwC1SzuTVAnLnP3OhYXPQbgjTgLHSUDyXFxdtRcUL1iAgRZ160yLeR1q5+4xDAJxLP2VVriw/Jx15moUWz6UxwBsFdxcxvVyAEVEXK/6Z9vD+cjKhDNMlMQ0soOt30ZWDbfgI5RNlTi5tLnkTGzcErgY2p6ncDPk+WOZCdmBM61kYI7jkr/GMGXKloFIKDFdvbxJbIKzfDGeJswpcAvffJogZylNx3NhfnKKwTDHWRq5HJX4x25aevyBBdY2qPHx93dxaIHRPKXqDj7GDWQuwMbCkpyXpU11BCvomJtbBP0VFSpxcTteMEbKse2IRVbb7Sq4KU5efBdnVg4dXl9f19NE8oM97Mecl0GyDzcu0zLas4Z94IqrFMzwGVu7JaxLmNsdzenDxqq2mz229dgPShjL9EL9KJRn1/aYZ88lSaff+kJNAOTvgP9foYxi+je2J6A2ZpjZJZ1tX5TeI0hvUkr7q0Ai0ek4kO6YLgHXTIxIGD5kaQx647JiRnYPGjKJdOX/OlQOCnW8P2EmkhNpLl/z/efGASBCxzHqmoeFGRYt3LodO0766mlrzBr+Ddh4kES0aCcZ/P93uk7CxSFcxjK5GsNRAHIL38l8qw+By/QzV9bxBzOtvIHdCCwMNt99xQC3HPU+gJSjaAmcAloS13MlG+tmyi2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(376002)(136003)(1800799006)(451199021)(186006)(82310400008)(36840700001)(40470700004)(46966006)(40480700001)(336012)(2616005)(40460700003)(6512007)(36756003)(4326008)(316002)(6506007)(356005)(70206006)(70586007)(478600001)(86362001)(82740400003)(6486002)(53546011)(33656002)(81166007)(54906003)(26005)(8676002)(8936002)(6862004)(47076005)(36860700001)(2906002)(83380400001)(41300700001)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:51:27.3507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b5c3c18-196b-4c73-c6c1-08db98dfba4f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10029 > On 9 Aug 2023, at 12:02, Nicola Vetrini wrot= e: >=20 > The variable 'saved_cmdline' can be defined static, > as its only uses are within the same file. This in turn avoids > violating Rule 8.4 because no declaration is present. >=20 > Signed-off-by: Nicola Vetrini > --- > xen/common/kernel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/xen/common/kernel.c b/xen/common/kernel.c > index fb919f3d9c..52aa287627 100644 > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -28,7 +28,7 @@ CHECK_feature_info; >=20 > enum system_state system_state =3D SYS_STATE_early_boot; >=20 > -xen_commandline_t saved_cmdline; > +static xen_commandline_t saved_cmdline; I see this line was touched by fa97833ae18e4a42c0e5ba4e781173457b5d3397, have you checked that making it static was not affecting anything else? > static const char __initconst opt_builtin_cmdline[] =3D CONFIG_CMDLINE; >=20 > static int assign_integer_param(const struct kernel_param *param, uint64_= t val) > --=20 > 2.34.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 13:57:23 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 13:57:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581133.909688 (Exim 4.92) (envelope-from ) id 1qTjgc-0000WE-6s; Wed, 09 Aug 2023 13:57:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581133.909688; Wed, 09 Aug 2023 13:57:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjgc-0000W7-2z; Wed, 09 Aug 2023 13:57:18 +0000 Received: by outflank-mailman (input) for mailman id 581133; Wed, 09 Aug 2023 13:57:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjga-0000W1-L4 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 13:57:16 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20609.outbound.protection.outlook.com [2a01:111:f400:7eaf::609]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a514c65e-36bc-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 15:57:14 +0200 (CEST) Received: from AS8PR05CA0011.eurprd05.prod.outlook.com (2603:10a6:20b:311::16) by PAWPR08MB10017.eurprd08.prod.outlook.com (2603:10a6:102:34e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 13:57:11 +0000 Received: from AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::ef) by AS8PR05CA0011.outlook.office365.com (2603:10a6:20b:311::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Wed, 9 Aug 2023 13:57:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT041.mail.protection.outlook.com (100.127.140.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 13:57:10 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Wed, 09 Aug 2023 13:57:10 +0000 Received: from 17dc439d95f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 33DE6BF8-83F2-45FA-9D2A-BF84218584BF.1; Wed, 09 Aug 2023 13:56:31 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17dc439d95f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 13:56:30 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DU0PR08MB8116.eurprd08.prod.outlook.com (2603:10a6:10:3ec::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 13:56:29 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 13:56:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a514c65e-36bc-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AHdWBxCSqPq2YeMQiK1OXXbKH02/DFQllBT60BSrEtA=; b=BU8uAtEewF5RF0svZuYYj1mAwAtNypuILG0caj6Oq8DImxPi742ChkcvsdVgfMn5+0IWEDuTxO3AHWN98r1RObQT3RzvOocufgy24UgpslYYbwPO97/oDAoOWRAuecHO1BdrdC/4hMPKKWJk9JRYKqsl/PywQOUwFxBTs0UbsA0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9af028e2086d487f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m59RVKfLoVYh6VOhBHhZEZxTXm0EubVwNX97wZXaW9+9y5Yzf9jNeSZAkZJc4IVbAr/LqI+GEYTDzGXJhooOteu1/kbSJaB+JEaobVNGSLhovjI3Z6LlV4z+bEr7axScxyteLc7Y+Lmk8BLOZ6O2/lPItdOymPs1KEYxG7dCCP/lSokv1xJ2kzJFJgkj4wfDonHwlxhZBR+UXZyVmHk7nytMaNdP+cAZUpWmWxMwb0xIO7ylaxLLylV37c4uHgGdA5eEBmqmRCM1QcrH5v1SCqh5k0CSZnEMsUwFLBjTUjn57hcrewTdrr8WhuDavSfVD47LUuuCQZr6yDOFmL/cNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AHdWBxCSqPq2YeMQiK1OXXbKH02/DFQllBT60BSrEtA=; b=UEU7TS3bASADIbhBvzkCXRTQhYx/Wc7XfC19i+NFYMCaqLGSEZ0sPWTEsE8UMJ0G6XjtYRyk76YOL167w5fZo9axF+qm9xrMS+Xv0DVhGP742M9hjL9uLsuDsffI4+DPOiao364WV/fWo2AFWj7pO66z/EUzH73kSaDMmvDJ39LOVLrY6TVISLaa3MBsCICaL/eKLvCTdq/S4TbsTUH09K359JhnwZIRyr/aMEDygrxIuZwkSl1iIm6J4HWZx6tuac7ATtH2PGcrYIb4mNwo//E1DkHTsI+6KamrX3KatSm9IjFgDNsdmnqVPK/Qz5RSaeDPOJWlCFUKgVDaJndDOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AHdWBxCSqPq2YeMQiK1OXXbKH02/DFQllBT60BSrEtA=; b=BU8uAtEewF5RF0svZuYYj1mAwAtNypuILG0caj6Oq8DImxPi742ChkcvsdVgfMn5+0IWEDuTxO3AHWN98r1RObQT3RzvOocufgy24UgpslYYbwPO97/oDAoOWRAuecHO1BdrdC/4hMPKKWJk9JRYKqsl/PywQOUwFxBTs0UbsA0= From: Luca Fancellu To: Nicola Vetrini CC: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3. Thread-Topic: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3. Thread-Index: AQHZypb0I6Psnfw1ike70N3zDUOJFa/h/VwA Date: Wed, 9 Aug 2023 13:56:29 +0000 Message-ID: References: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> In-Reply-To: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DU0PR08MB8116:EE_|AM7EUR03FT041:EE_|PAWPR08MB10017:EE_ X-MS-Office365-Filtering-Correlation-Id: 16982fb9-ebd9-42be-80d9-08db98e086cd x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a8NBy3xVLczwDz24Tvmd+dQu1SlY5vGu+6qBYXMyGaPTcakznU2HEC5XLbfsUTUELLZu87znroeU59TxB2gZyDdkx68l8AZl3hLx1QZ1nAjcDgF5yow5MVgpaZOg1zwsDX0c7DhGipkan/x0c0/hNzeqNh874iXtA3WileawrBQOTEpda/2i/epFeK/NLkvlTMYcZ3Uqd0PEhHlNlZaL1HKWSuBKN1VTojlp4R+1CgkkY4buglfMpgv7Feug0bfBn/jb8u9HzMv/BKOTZwpB/GGZf2HY2ViPQZpxQKz5PUuVXeKPkFzuGaAzcNC7f0qhK7OsN3kEE8wfN3ggbU3b24iSwGSH3iiQZ/pemCNKFoAuQVdnLZd0Qpfd6O8sbo35eC3249hSfW33jshS/nxYse1X7aLGfGZnIYbi9Oqf29r/yttumjiW1wRPhvy5bqF3TV//8L440kO9sazjXdFvQ3AB/H2nys+s5n5oRtU1GdNVyZgbPBXI5An3n5xqJUJgShP+TKgnmb1GqfQNwbMQvidMHn6q0rUSTtPGe5otafIsfnwu1wn/nbUdR4/laUZfReOIEMVFSiFEzQ/BxWdrQ9H3t0jiA8gWl2WcM0Cp9aYBAob8xUFeqwtr4P+7CKu99kAQEU0Y0Vt3B6M02SuReg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(186006)(1800799006)(451199021)(316002)(83380400001)(2616005)(2906002)(4744005)(122000001)(36756003)(71200400001)(6506007)(8676002)(5660300002)(53546011)(6486002)(38100700002)(26005)(66446008)(64756008)(41300700001)(6916009)(76116006)(66476007)(4326008)(66556008)(66946007)(54906003)(33656002)(86362001)(91956017)(38070700005)(7416002)(8936002)(6512007)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <662F63AFD3C9A540A429F0C264F18699@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8116 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f04c8d7c-c9cc-4470-87fc-08db98e06e34 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XQwpPbadcS1PVa6UYfux1C4Gg01JCt8E2dXZOW0kortazTsBUJFFCj/MLQKaNAySw7dgT1CjDJqJiv6ae0zNhWWyFviCAUvIfDAe9q7uCsCRo36+ztFiykipiPwlNpQeXrF45Gxil9yaRks7jXRvursXXWjlFJEwE9BWyYpGlxC4QxiphHWE9vNDHlLM4fHdEm8ict/Pi8k7UCldzh0lx1rnubGc4fvYkBiM+Kctt09nDOgYBEZOTK//FisR6+IVsD+ojQs/5VsRV9Paj7XaxxDY5VltHu6DP6V0xuNdKLGhyt3yc/9/6pd4gv7mDW+kradKkdWNiixY9KAu/aBktrn3PVMsnNcdcIJcLe7NMYlQOSncAbRnvbmMxZRoPTRQSoJH5TIgCaBf1xldB/CM6zXEvYWQEz5ZLWb+OGZPHJuQgSLTtGOpkFBhMVzEOYCMNhVgdbzcnd6IfE8350e7JJ02f3xt8BWrES87fOsTbjvo+NU/TG2nojIwVMQxp/HeMFf194UDJTBVxrfxry1IAKqj8idQ7fO2C/+Iz2uXO2gnVD6r+AcXkbfVwoAE1jw5wYXOvCVy01PqQxNWziNRiSxufbvzcObbvyIIv2k9KSjA6EKZvGeDdCYimdhC8FDzJEfetHFqiaYZPcWvaP4gBsksqfUOacqDkxmBr5pc+i0Hl8ShrLNgjNUMFoQXsvt0ccXYYHliW/Q1y/VXFNu5yMCwDKeYHzpssSNQ0zrBDXG8yT6rMJq6LUvCqstUqCR0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(39860400002)(396003)(1800799006)(82310400008)(186006)(451199021)(40470700004)(36840700001)(46966006)(2906002)(8936002)(41300700001)(316002)(40460700003)(5660300002)(6862004)(8676002)(33656002)(36756003)(86362001)(40480700001)(81166007)(356005)(53546011)(478600001)(82740400003)(26005)(6506007)(54906003)(83380400001)(6512007)(2616005)(6486002)(36860700001)(336012)(70206006)(4326008)(47076005)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:57:10.4143 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16982fb9-ebd9-42be-80d9-08db98e086cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10017 > On 9 Aug 2023, at 08:55, Nicola Vetrini wrot= e: >=20 > The variable 'msec' declared in the macro shadows the local > variable in 'ehci_dbgp_bios_handoff', but to prevent any > future clashes with other functions the macro is converted to > a static inline function. >=20 > No functional change. >=20 > Signed-off-by: Nicola Vetrini > --- > xen/include/xen/delay.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h > index 9d70ef035f..9150226271 100644 > --- a/xen/include/xen/delay.h > +++ b/xen/include/xen/delay.h > @@ -4,7 +4,11 @@ > /* Copyright (C) 1993 Linus Torvalds */ >=20 > #include > -#define mdelay(n) (\ > - {unsigned long msec=3D(n); while (msec--) udelay(1000);}) > + > +static inline void mdelay(unsigned long msec) > +{ > + while ( msec-- ) Does misra allows to modify the function parameters? (Truly asking because = IDK) > + udelay(1000); > +} >=20 > #endif /* defined(_LINUX_DELAY_H) */ > --=20 > 2.34.1 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:06:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:06:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581139.909698 (Exim 4.92) (envelope-from ) id 1qTjpa-000270-2W; Wed, 09 Aug 2023 14:06:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581139.909698; Wed, 09 Aug 2023 14:06:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjpZ-00026t-VY; Wed, 09 Aug 2023 14:06:33 +0000 Received: by outflank-mailman (input) for mailman id 581139; Wed, 09 Aug 2023 14:06:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjpX-00026n-RT for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:06:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20623.outbound.protection.outlook.com [2a01:111:f400:7e1a::623]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef90a1bb-36bd-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 16:06:29 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9388.eurprd04.prod.outlook.com (2603:10a6:20b:4eb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Wed, 9 Aug 2023 14:06:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 14:06:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef90a1bb-36bd-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QKEfx+RThUtbNvHdDgsfKz/HFWDbQo41PQPxMoFy61JlVcQ7/O5qc1Mn5m9k6Up2ME64QFI20a8gbOEgG8bUM6QgaFurWJD1MUTEJr9W9Bzy1YcrJyVjQwXTUDNLn6haAk8mce9y5XpmIfBxASlBoy2Ui5MXGUVyeELcJDjfjAAFq9p7xsU52P/Ld02eRFkcykYPVgFSGCK0F+Q7phDOCEq70Io0sBkWYYpOGgxWNxtnxm3pGtlpkpdpHd7ZUp1GFz/FJpa+8vq20JVmNFWwzZK/Cvz+mx2PyOF0JWbMMecN/Uouvh6VxtFX33EUThg7EPREyXFaTrqpciW0kpGPyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FhUA5NsuWDlnopf/bqdUYEngu35mooPiQlSbCKPaHSQ=; b=AKGlm6msXo/CLA0RImfUQsj0xRCLr/dEGTBhUzW9Bo2Wnet3D8n6JNNlEt7pjOGqVZN3ho+45v4WqkMlg1kuKY7dCIfA2Er4DsS98cbgXYISw7r3217cjr6gIGJS5RwgEVCxSApasGZhAo9EjRsYUn8RNcHDYnXgNb82Uk/+Qf+oIkNgxaO6G5Tkulw14AHcEowYcoCUMIaWHIAsBeT1guF1fNZOeWQSeS30gD6X9Pw9YJENBDJ6SMJTPv7x7PnHlrJQ33pCFWIpD+w8VHT1b+3aG6uCYAer7X1j86ffoKOoLUUn0lfBMM1v/dvZZ6R0I6QujJ9V0PJrmtvlE3ITxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FhUA5NsuWDlnopf/bqdUYEngu35mooPiQlSbCKPaHSQ=; b=RYA0/PCpgW/83sjuJMrYfIaFUF+QdFeDkHUw7QFUc0kktAg5JTixrVNGP90UUrhio2Orl1u1L2FneeIv3KNbCPynptR6hd5VhuoYDXiLf50rNIsh4ko9GuDI8R4O1a2Nvqb59gpvAdUpYSuu1NtUJNmyiKGF5wTxhudNbshPNMz7isKZzRRifUlqXh4/3FBMO0KTrnWh20i1ikD3lQAQnLsEjGJp7Rz6zfCc1BG31pM8loj+UXCm5Qj4pqIxuRzVXSQYEHJVfsSXyAvHF91vlnKCdIHozy+tKTuWZ5vpciwpsYGIAOxe0Mv1BwpWvcnyu7ndo317xAUzuEnc9YVOJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <041f2137-8a90-79f6-3677-f764cb1b6656@suse.com> Date: Wed, 9 Aug 2023 16:06:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Nicola Vetrini References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9388:EE_ X-MS-Office365-Filtering-Correlation-Id: 57502bc4-63d0-461c-c744-08db98e1d2de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KrIkVvsj5B91x2rTfrE5fdeENn6P1PJavRXUeo7BvHPVU+HLRNZjyglHxmg2lIUxn252mYHm/IaKYTFdFpGTH1gri2+6hKL49fZYYmUp9DDktPwTsgNshX7r4p4BTvUQmRrXc86sng588Yvzp476cneJnr1G1Nzr+p2FbeD8jnuaxEmFQO8sc2dTNs0EuYQiwRFPvXDaHnsVSjZJh+KKrrcXUG2hj4EPYuFTidMhXOONq+SUui3eGKUjwxHexP3gu3BzrX6v/nheJ3+O4KfcAgprxrWJiLDc1t3F0x13oXU8ehX3naT8gnPsSq0k85VSWCT7qmu9X2y5it3iCmLG3xhEHmR8oVwVM0lEmYTCf1x2A0EiGlCoNLBGhN9XEcUTo6zqY9AiHWO5qReTDLZyZNdhEisiSmWnt83I2qIwTnDnmj39fHfl9IPTYMC4Pk2kn1dcyaRK35RJGUASaVIzLiOWJwg4yCTms+84lrAEvqYgcz9doAMM49FAlo8Viaq8jHao3SIhRuQFZHDwzO4TEFTcSgwsG9A4I5u1V+Yqfe0q1Q5MKPAZzczx36bfZCbbvewEjO5hz3u9hSBv2/tSzDuH0Kr2yosLDdx2kYAx6IZgX/hIuO/zF4EGhH8Dq2GbX1mvTw6qhtApX8e5IXoxUA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(1800799006)(186006)(451199021)(26005)(83380400001)(2906002)(31686004)(5660300002)(7416002)(8676002)(41300700001)(8936002)(2616005)(86362001)(54906003)(316002)(6486002)(53546011)(31696002)(6506007)(66476007)(38100700002)(66946007)(478600001)(66556008)(6916009)(4326008)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anN1K1VCZFBNR3V2Z1hOWU5zTDRYakxUc3Y2QUZiZXhKazBvZXFBNUR2YmNq?= =?utf-8?B?cHdrVnNhYkZLWnY3SXVpbFVVVXp0RjNFMHUzc0lhMHNRV3VubjlNSEp2NlR5?= =?utf-8?B?bzdXb1o5SmVJUzI2SW5jeEJqWkYyWTlVTnM4bys5cjNVNk1SaDJ4M1J5SlV6?= =?utf-8?B?Z09XQm9Dc3JJVTNYOG1Jb1dZNzc4bmFBUDkyNXloWTh0ZVp5aE51N3BYQk1y?= =?utf-8?B?UnZBUTZSWE1mWGN1MUVkdHVCdEhhYU84b05mcGVJWndtdW1MRDVXa2M1cldM?= =?utf-8?B?ZFdRdmZxWVNwa1lwZWlZOWszUTlHdEtJUlRCMDlZenpTa014ZE5zeWdndUkz?= =?utf-8?B?VzUvR2ZjQ1YwbjYwazJNWGU0dmNXc3ZKdlphUGFQL09YK0x2UmVBVlVXSmlI?= =?utf-8?B?U2tvZDJkRkQyRlB4aTdGd29aMVRZVjVYNWZ4NzZRT1FXbk1rRGdCK1B3SFJx?= =?utf-8?B?WG52MmpaYkxyMjRwbFRBVVpENml0Qm4xWGduaVp5VVRGMUIzMG5JaXAxbUtu?= =?utf-8?B?RklTNm1KZlVGWnQvcUs5VUxmdXFDQUJzSE9DVXFkRG5Bd0s1dEdoSFhjNFh1?= =?utf-8?B?US9zRTEySnZGbFVkcElTVi9DYlBUb3FvMUVUUG5IMHBIMnkyVnQyaEF1TTB3?= =?utf-8?B?Q1F3Q3lzQ2JuNFhGRHJFakh5cU9FS2VMZ0hJNDNxck04cU1hOEM0VXM0QkNS?= =?utf-8?B?UDFQTFNFdnlpTUNmOFRLeFBMMVlFK2RMbzdJeldBR1NSQ0djTkZORS9EL1RX?= =?utf-8?B?c1laUlRHTk1kekNzc1k4SWlHVjdnak5rZHIyaE5IZzZvVWExdlVUQlFDQmwx?= =?utf-8?B?QnkwMmVXZ3NmN3pUcHdtcVN6TWEvOXo2ZDEvOTY1MmNwajJwbVBmd3pEelFE?= =?utf-8?B?NFNFWEljYytPTHpOVldDYWNHcEtZK1BlU1lrM1Z5Sk1JQ2RuakdGV2djVlpI?= =?utf-8?B?T211RThuR1huUmh4c0pCNnFhalYrbmVBKzA4WVFWbXEyT1hrUTNackxCNGY4?= =?utf-8?B?RTBCZEc4aUFwZ29OZEU2elM0cmlZajBSWVgyZFZUd3EwUFB6RG5kZDJWOGN0?= =?utf-8?B?czE1RnBlTTg2L2JvbmpQYXhZWFdDR1NBNVR0cFhqS0NpbWhralNEKzVaUTZ6?= =?utf-8?B?YmpJa3BnT2VhTnJPZ01UcnJ2MEV1dkw3UnNIc1JJN3paY29vWUsraVRtMFhJ?= =?utf-8?B?TFIvbnhyRWV6eWVQOXU1c0pFM1VnbG1Xc3Rjc2N6djZTMnFraUw4dDduL1Bz?= =?utf-8?B?NEJOQk0zWi9MUnpIUHRRc09sWGFBZ29tRGVRZ0pQT3c1Mnp6ODVQcmFhYkIy?= =?utf-8?B?Vzh0WW9CcGt2ZzNHRUZMOTFpdEFrSkpQaHNHcXU5WElNL0ZMR1RYMVJlTzMx?= =?utf-8?B?Nks2Y3BTOHZNOEpNdFJrREExRC9CMTFFejQ4SmhySVZ4QmJOQ1RtT0xDcXhD?= =?utf-8?B?UWx6ZHVVc3VrcWlGWVIvb3Rid3lSWG9uVnYzSWpZRnNkTDF1R0RJZ3d0aDhX?= =?utf-8?B?czBrME94bVZYTk9wcHhlUy9RK0VRbEt2RFFjNnltNVlKbmI5WU5TQVFTNU14?= =?utf-8?B?ZWgydVNUeDIxSHQ3UlhGckRmSzlhaHVjZ1VKZFZyQVlCZnRZVXhQTkpkdzVy?= =?utf-8?B?eFcyS1dxNmVtMmNOSGZFam1hd05aVEZxSHU5TGdPVHJiNTlVUU5ML0ZzeVBi?= =?utf-8?B?bHhOYUVYRmpveE1mb0dGZG1vVFdzd1hFZDJmSkltMGZSUC9vbnRCWEFIcVlU?= =?utf-8?B?blJyYjhDMmZhOXpXb0R0Rnd3TW51bWZXRUdScUV6enVuM1VMU2VWWUwrMEJX?= =?utf-8?B?MHVNYVFEU0paNENPV0tzVHNsYkQrOThNQXRhVlo4TVZURFdGZXRlb2daZm1j?= =?utf-8?B?cDdpM1NDWHZzOEtyMnhLVGJJZjNYWnJtZk5mUkxEejFNV1A1eTcwc09Ha0Rl?= =?utf-8?B?T0hFSHBqUmE1MG85aFZJc21mVzFUeDhrS1BEK1E0VERRYnJHWjgwZ2gxRWhm?= =?utf-8?B?a0drVXp0c1BmYjhGNU1vZDRxbDR1eGhpRHA5Y091OTF6dlJsaG0zWFVHRXRj?= =?utf-8?B?dXUrcXhsbVlHdUZCak1Day9MOENPZWVybjlIYTdNZ0NQM3V4aHkzcFNyYWZv?= =?utf-8?Q?JcT4kafLW0L+c4ARSZ+8h8yEJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57502bc4-63d0-461c-c744-08db98e1d2de X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 14:06:27.7298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J+wo8ux1t5j4Ss2bUkHPRG0Z5Gj+DH4GDOP/Hdq7vmzXruFTuVZYrx5zooio8XHiEP8bgaZTihrOI+LsdLWrVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9388 On 09.08.2023 15:50, Luca Fancellu wrote: >> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: >> >> The variable 'saved_cmdline' can be defined static, >> as its only uses are within the same file. This in turn avoids >> violating Rule 8.4 because no declaration is present. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/common/kernel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/common/kernel.c b/xen/common/kernel.c >> index fb919f3d9c..52aa287627 100644 >> --- a/xen/common/kernel.c >> +++ b/xen/common/kernel.c >> @@ -28,7 +28,7 @@ CHECK_feature_info; >> >> enum system_state system_state = SYS_STATE_early_boot; >> >> -xen_commandline_t saved_cmdline; >> +static xen_commandline_t saved_cmdline; > > I see this line was touched by fa97833ae18e4a42c0e5ba4e781173457b5d3397, > have you checked that making it static was not affecting anything else? The code requiring the symbol to be non-static went away in e6ee01ad24b6 ("xen/version: Drop compat/kernel.c"). That's where the symbol would have wanted to become static. But that was very easy to overlook. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:09:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:09:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581144.909708 (Exim 4.92) (envelope-from ) id 1qTjsX-0002h1-Gw; Wed, 09 Aug 2023 14:09:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581144.909708; Wed, 09 Aug 2023 14:09:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjsX-0002gu-DJ; Wed, 09 Aug 2023 14:09:37 +0000 Received: by outflank-mailman (input) for mailman id 581144; Wed, 09 Aug 2023 14:09:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjsW-0002go-D9 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:09:36 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c706ae3-36be-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 16:09:32 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 64EFC4EE073F; Wed, 9 Aug 2023 16:09:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c706ae3-36be-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Wed, 09 Aug 2023 16:09:31 +0200 From: Nicola Vetrini To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 2/2] xen/delay: address MISRA C:2012 Rule 5.3. In-Reply-To: References: <47e2c8770e38ab064cbcdfaafa8467c5e733f11d.1691567429.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 15:56, Luca Fancellu wrote: >> On 9 Aug 2023, at 08:55, Nicola Vetrini >> wrote: >> >> The variable 'msec' declared in the macro shadows the local >> variable in 'ehci_dbgp_bios_handoff', but to prevent any >> future clashes with other functions the macro is converted to >> a static inline function. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/include/xen/delay.h | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h >> index 9d70ef035f..9150226271 100644 >> --- a/xen/include/xen/delay.h >> +++ b/xen/include/xen/delay.h >> @@ -4,7 +4,11 @@ >> /* Copyright (C) 1993 Linus Torvalds */ >> >> #include >> -#define mdelay(n) (\ >> - {unsigned long msec=(n); while (msec--) udelay(1000);}) >> + >> +static inline void mdelay(unsigned long msec) >> +{ >> + while ( msec-- ) > > Does misra allows to modify the function parameters? (Truly asking > because IDK) > I checked: there's an advisory (R17.8) that disallows this, but since advisories (apart from a couple of selected ones) are not taken into consideration for compliance, so it's not a big deal. Even less so since it's not a pointer type. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:15:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:15:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581152.909717 (Exim 4.92) (envelope-from ) id 1qTjxk-0004C3-2I; Wed, 09 Aug 2023 14:15:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581152.909717; Wed, 09 Aug 2023 14:15:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjxj-0004Bw-Vu; Wed, 09 Aug 2023 14:14:59 +0000 Received: by outflank-mailman (input) for mailman id 581152; Wed, 09 Aug 2023 14:14:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjxi-0004B4-QN for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:14:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ed36ac9-36bf-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 16:14:58 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id B2F574EE073F; Wed, 9 Aug 2023 16:14:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ed36ac9-36bf-11ee-b281-6b7b168915f2 MIME-Version: 1.0 Date: Wed, 09 Aug 2023 16:14:57 +0200 From: Nicola Vetrini To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 15:50, Luca Fancellu wrote: >> On 9 Aug 2023, at 12:02, Nicola Vetrini >> wrote: >> >> The variable 'saved_cmdline' can be defined static, >> as its only uses are within the same file. This in turn avoids >> violating Rule 8.4 because no declaration is present. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/common/kernel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/common/kernel.c b/xen/common/kernel.c >> index fb919f3d9c..52aa287627 100644 >> --- a/xen/common/kernel.c >> +++ b/xen/common/kernel.c >> @@ -28,7 +28,7 @@ CHECK_feature_info; >> >> enum system_state system_state = SYS_STATE_early_boot; >> >> -xen_commandline_t saved_cmdline; >> +static xen_commandline_t saved_cmdline; > > I see this line was touched by > fa97833ae18e4a42c0e5ba4e781173457b5d3397, > have you checked that making it static was not affecting anything else? > > Though Jan already replied on this, the commit(s) were tested by patchew and our pipeline. This is normally our process, apart from MISRA checks. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:15:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:15:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581157.909728 (Exim 4.92) (envelope-from ) id 1qTjyX-0004i7-Fi; Wed, 09 Aug 2023 14:15:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581157.909728; Wed, 09 Aug 2023 14:15:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjyX-0004i0-Bo; Wed, 09 Aug 2023 14:15:49 +0000 Received: by outflank-mailman (input) for mailman id 581157; Wed, 09 Aug 2023 14:15:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjyW-0004co-1P for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:15:48 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on20603.outbound.protection.outlook.com [2a01:111:f400:fe13::603]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b0659eb-36bf-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 16:15:45 +0200 (CEST) Received: from AS9PR07CA0001.eurprd07.prod.outlook.com (2603:10a6:20b:46c::11) by GVXPR08MB7823.eurprd08.prod.outlook.com (2603:10a6:150:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Wed, 9 Aug 2023 14:15:30 +0000 Received: from AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46c:cafe::be) by AS9PR07CA0001.outlook.office365.com (2603:10a6:20b:46c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.16 via Frontend Transport; Wed, 9 Aug 2023 14:15:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT053.mail.protection.outlook.com (100.127.140.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 14:15:30 +0000 Received: ("Tessian outbound d7adc65d10b4:v145"); Wed, 09 Aug 2023 14:15:30 +0000 Received: from 6173bcbeebb4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 88C104C3-4C56-4BFC-88A0-181BE510A1E7.1; Wed, 09 Aug 2023 14:15:02 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6173bcbeebb4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 14:15:02 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by VI1PR08MB10102.eurprd08.prod.outlook.com (2603:10a6:800:1cf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 14:14:58 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 14:14:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b0659eb-36bf-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//FkV4ksvf/p2bNa4niW0ittErPqSYgl/6jmAxuAk6A=; b=JLzubRAZMd+Ug2bl8NlvldvrkMSMCqwwJCdkBqoeTZsvdEgxC5eFVIzCDN0W/B7wNQOBTpHGwYWk1HaesN7LEIH4ZPvWeM37H4ioaeoN2mlTui5mynNwtXrjyUsFQcHSKFYYpMsvaFF6NnRzyUOX19ySklcLczgllIMApYqMO7I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2c5594971fdbb592 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NCEW01dodYRVRIBn19sJ9Mox7XpVE1L+z5hEGqg3PInX5N6Rq9yucnpPrxUl9wPACH/wClZM7qfLKfPJjTdqeBMwSn1OmzjNfGQXcBay1ChLBMEvhwAgGciapnNICUHWLpDhUbUqmfIMF6tgN5u05TOeANrTuOTbi5EjaZuhryMtxTGg2g3Gevb/KgjgEH3wOMOzSKDdg7Pgn7hgKUlKDcdCmEUFv2q1/Vvs2CPJuJEUQBV4qAUolzaPQ5Db7fZ/DDz5kBOYA88Unwkx8b0ui1jGlSZZDe1fMLfY/TWocSlw81XlEoFcZYOVniVbutKyYZPnScLnlL7+PEbVdX4Tsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=//FkV4ksvf/p2bNa4niW0ittErPqSYgl/6jmAxuAk6A=; b=DDyztEsWaZvnFX7C/iXUimseaO2iVsJn5lfXxOiwPp4ugkJYwpZzN8GTM5g/iA8Y3NO3i9ZkyoUPlzO8HRSPNZ4nXyzJ4WmpApKobghX2JlXlqAwkg4lZ9X3ZjRMBFTxwxVOval1yT4UqJhcFk+MWfM0oQfoMITCSOSmL2nXt5L2A71YKPFX3qhOU/2/gFv4K60r5vM4fJHzey8/fyKINiq4t+qCLQPGCfrJAhljwXE13oE0TZtnqYiaQVyEd5eA1K+lp99Nci3anyJOdjgMT/1SOkGgWl3AcS3CsHCQMEavwZcijxElnzGIAWIjhvaf0VVx8+6cHCYpCC2hRBeODA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//FkV4ksvf/p2bNa4niW0ittErPqSYgl/6jmAxuAk6A=; b=JLzubRAZMd+Ug2bl8NlvldvrkMSMCqwwJCdkBqoeTZsvdEgxC5eFVIzCDN0W/B7wNQOBTpHGwYWk1HaesN7LEIH4ZPvWeM37H4ioaeoN2mlTui5mynNwtXrjyUsFQcHSKFYYpMsvaFF6NnRzyUOX19ySklcLczgllIMApYqMO7I= From: Luca Fancellu To: Nicola Vetrini CC: Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Jan Beulich Subject: Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 Thread-Topic: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 Thread-Index: AQHZyrEYmlGLQrMXXU2mT8iNskDvw6/h+3gAgAAEg4CAAAJWgA== Date: Wed, 9 Aug 2023 14:14:58 +0000 Message-ID: <771C6AF9-8BB8-466C-B9A4-1745016BEB1E@arm.com> References: <041f2137-8a90-79f6-3677-f764cb1b6656@suse.com> In-Reply-To: <041f2137-8a90-79f6-3677-f764cb1b6656@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|VI1PR08MB10102:EE_|AM7EUR03FT053:EE_|GVXPR08MB7823:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c07b279-b456-429c-c4a2-08db98e31663 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vRfJ0dRRLVXTV88UPlAnWIFLXKSq8lRD7Os4Euzm0Ul9ZV/0XET6gJXpIVmlCd74Y0SMtjXebcCifmRUjAnzBLtY464mE4bYTpVLACzmgCYMXGPmj8TGo13Y22/j9MsRINZzlXdnUyLQ+uqe0D5WjYtD5w7ruaVLm21LaHcsKM/vgfnYwLBV9B3iYKY2LLSQhfbF/bR8+tJFYrOdTP6bUH/B047FwaUw9LzEc1z/SX74x4GkMJdAPnEWeJ/VH6Iw10UMlNBgPA1fSwl2sVbxGIfE8XvFR3pC+AlYoGOQay59U2ewiWGE/4hs8G/uXVbUh/dJKb8/v4RnJBg7zthsHVSK9NF3guTWncfwKnsSmAbL62jA9pys2I7UUdDJ17sx9MV8oF5rfMyTLTsbhNTGS8zLUEM/LSIcuFYjPEACHPX5uTB0kwwqCwkzoSqOZuMIR+LCZ5PY2NQmXuoDvqk3wzXWS1cofMwJASWAGJJoyyL+bOv/Qk5DlK/gpdewKehWP6rbUYEtISOlalnczbfWrIp4v9DmLJGIQhEeMYqQ4Cl2z1i5OhQ0WY/WGTUTsR3TWqd9BfC/U8m85tabI3VldXFzCdGivgfTdo6p6DxEao2RWlCvILXm4oMD320fehcrBpXojQzoZUkbswhVDazGWg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(1800799006)(451199021)(186006)(122000001)(478600001)(6486002)(2616005)(83380400001)(6916009)(6512007)(53546011)(6506007)(26005)(76116006)(66946007)(66476007)(8676002)(8936002)(41300700001)(33656002)(64756008)(66446008)(66556008)(316002)(4326008)(2906002)(91956017)(71200400001)(36756003)(38100700002)(38070700005)(5660300002)(54906003)(86362001)(7416002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <18C13D500FBE4A4E8C803DE9B01F35FA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10102 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1deefa6b-d3c0-4560-602e-08db98e30376 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v+x3F9RibBb6WfTe9cdsmWNoWkt16hWkWNS2GneFWniCN2Ktg23cwk5GX6at41xQjVICNLwDUHiLNCvuyTTqFHuXhWDARAvO5wR/vZHJRWlipheSPWiW7x0g7sp6abaD0WO9p+q+FbLdMhIHL25nd4ZR8EN+UbqVU+gncQDmSVFp/3SeDLzve2xN4SJpH2UlxMI6i93WmmPjATNVPpZH9/Nb61E2GdN9xfaaVz9vmw+2DLgTowYRkcYz4mMdcAv3BLe9tORzjON0Cw0AsWxvsZip+oKEVCQ5SMZkBq9G48cdOHKg6erhL2RvXqaSDr1W+peAby5GWMqYLgu/N8sye1DgyUTIZ9qi6nQt43rjO9WZHm1kq2gJgp2/u2nM3DsdIsMKco4ZfTw3ZjPq0mtUJ8ohtbpAmEX7VKVlCXUd3gsbWgVuw6q58FjKJ4/gkjYQJSGH+KkgCc8LgFq7/iDqWc+iZWwOTiB4WgSLS6Axkr8jX95fmKutAu8Bv9VyGSNEcyWo9RSHGvc9jNXEKPhjBnNjZVIQPo6uUlHNQg2coElLn4HCeNdlIaMu1xxIxRVRuPWov1pZNN8p5bqEW6UKhMnylzT2ptW79mYoHSuvzMMOM39slIF5MUE8EunQbAOouwpmKPWfJ77Y5D47TiHmXsEgyiHCIkQw/7VcL0OnIgN44ukFHseMZswyu7tqIDn2qEEGu+heSNBNVuK0k++KpnVd5ogBXczalP2zAZe0FCc/4UjuqX+5mgUO1eJGf0h5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(346002)(1800799006)(451199021)(186006)(82310400008)(36840700001)(40470700004)(46966006)(40480700001)(2616005)(40460700003)(6486002)(478600001)(86362001)(82740400003)(33656002)(81166007)(6512007)(356005)(53546011)(26005)(36756003)(6506007)(107886003)(41300700001)(6862004)(5660300002)(8676002)(316002)(4326008)(70586007)(2906002)(54906003)(70206006)(336012)(8936002)(83380400001)(47076005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 14:15:30.3067 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c07b279-b456-429c-c4a2-08db98e31663 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7823 > On 9 Aug 2023, at 15:06, Jan Beulich wrote: >=20 > On 09.08.2023 15:50, Luca Fancellu wrote: >>> On 9 Aug 2023, at 12:02, Nicola Vetrini wr= ote: >>>=20 >>> The variable 'saved_cmdline' can be defined static, >>> as its only uses are within the same file. This in turn avoids >>> violating Rule 8.4 because no declaration is present. >>>=20 >>> Signed-off-by: Nicola Vetrini >>> --- >>> xen/common/kernel.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>=20 >>> diff --git a/xen/common/kernel.c b/xen/common/kernel.c >>> index fb919f3d9c..52aa287627 100644 >>> --- a/xen/common/kernel.c >>> +++ b/xen/common/kernel.c >>> @@ -28,7 +28,7 @@ CHECK_feature_info; >>>=20 >>> enum system_state system_state =3D SYS_STATE_early_boot; >>>=20 >>> -xen_commandline_t saved_cmdline; >>> +static xen_commandline_t saved_cmdline; >>=20 >> I see this line was touched by fa97833ae18e4a42c0e5ba4e781173457b5d3397, >> have you checked that making it static was not affecting anything else? >=20 > The code requiring the symbol to be non-static went away in e6ee01ad24b6 > ("xen/version: Drop compat/kernel.c"). That's where the symbol would have > wanted to become static. But that was very easy to overlook. Yes you are right Jan, Reviewed-by: Luca Fancellu Possibly with the Fixes tag Cheers, Luca= From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:17:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581164.909737 (Exim 4.92) (envelope-from ) id 1qTjzx-0005MD-Qr; Wed, 09 Aug 2023 14:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581164.909737; Wed, 09 Aug 2023 14:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjzx-0005M6-No; Wed, 09 Aug 2023 14:17:17 +0000 Received: by outflank-mailman (input) for mailman id 581164; Wed, 09 Aug 2023 14:17:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjzw-0005Lw-1i for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:17:16 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ff732a7-36bf-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 16:17:14 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id DBD0D4EE073F; Wed, 9 Aug 2023 16:17:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ff732a7-36bf-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Wed, 09 Aug 2023 16:17:13 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4 In-Reply-To: References: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <1cfa92d52d89b2013218cef1c518ab4d@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 14:52, Jan Beulich wrote: > On 09.08.2023 13:02, Nicola Vetrini wrote: >> The additional header file makes the declaration for the function >> 'init_IRQ', defined in this file visible, thereby resolving the >> violation of Rule 8.4. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/arch/x86/i8259.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c >> index 6b35be10f0..9b02a3a0ae 100644 >> --- a/xen/arch/x86/i8259.c >> +++ b/xen/arch/x86/i8259.c >> @@ -19,6 +19,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include > > A patch adding this #include has been pending for almost 3 months: > https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html > > Jan So do you prefer going forward with that patch or this one (mentioning it in the additional commit context of course)? -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:22:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:22:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581173.909748 (Exim 4.92) (envelope-from ) id 1qTk5C-0006ta-DP; Wed, 09 Aug 2023 14:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581173.909748; Wed, 09 Aug 2023 14:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTk5C-0006tT-Ab; Wed, 09 Aug 2023 14:22:42 +0000 Received: by outflank-mailman (input) for mailman id 581173; Wed, 09 Aug 2023 14:22:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTk5A-0006tN-MR for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:22:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0610.outbound.protection.outlook.com [2a01:111:f400:fe0e::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 319862e4-36c0-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 16:22:39 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DBBPR04MB8012.eurprd04.prod.outlook.com (2603:10a6:10:1e6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 14:22:36 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 14:22:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 319862e4-36c0-11ee-b281-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5QLnH2jERA6yEMwuOCkT514wN5yq2V+N0N3v9/RFjnoHoPQk/0h59u+gU5f2nraOTFxa4b5QKIyYfQh9yNvIj8ToMuYxw6S26t/21Wf+p/FfKSrDQKM7VYWnbxMOkaTK8fZ35mweb7XZ89ysnv/A+wsNIIgQ1wFJdRJwauDxU+IwthYi2/GraKeMocCZWGck/HbUhf3d1uj9ctOJ9MSYCiC/hHPdXgVsVGprOy9Q6eK3N9GKRSZUvqakQRrDfr0dabUcWHdOY0xjxc6hBxJ/7Ec+bVDwtYcpKFxNgUizHy03H35gR+HwatoFO4BO1RYhyrgfODYKWftiT2wqzJ+qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jgM5Mt6ivU6EM9j1oL3VKfq3p/kvqxSG+6Cr5YWWDJk=; b=XE99X53Np0lt/vCvvvbCT2VElFi4XSnyJS1cLrJiE0z7emc4Z0j59ULYvtNuujstKu5+PO5Cp/NScc4RqfjmGvodnri/bV9LtXb5vm8liquypSwtewBIqlFMyLLnZ1dtcXzdekWOk2SsRbig1aAHKjvNy6gyEUCwxBZlR6XjyGYLE+j4FvV2YL8rANmoyE4XG4MWY7NRDXE16vdQf0e00WQncbpUK22wDGy1OMIYwmlNwak3ePpP2oveVdW47MY5tyExgFxNSDExLNtKUqdxGtlhzUMDO5SKyDih7z00Yvu9ub21YEVMOUIo+6TFZCJYAAKOWHgWlD0zdcH25+4INw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jgM5Mt6ivU6EM9j1oL3VKfq3p/kvqxSG+6Cr5YWWDJk=; b=vTFolcHrBc/beWwYJqSGzSzt9+8XqgM5dFvgin9qs+6G9NPJKafJQKs/JfY41CTL55ZN627/B5DVV5+Y0l7AkmB8WqcoDvU1vw+v869EWnnD8DfhnrDVdVkaajr4DyyKN3kDbPXNrzuuUBgjShNHZT/n3hCpTAc2CPvWix48X6rczSZHX3xR29Y2MsRVllPU8fWUbnp59JtObwJgRcn5d99QUrO5cAQ4Danev/V2Rjzh4a9ppSMqqNXhUk9vtCrOSsQg1ZubhzYdc6tNmvEamnAo+1qMyLB3gFZe1UZc/F/gWezgGVNdFzdzYldYtMvWKAP/V02+BqKKwfpkuyUHDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <30cd1bdb-be77-a192-eca7-6fcd60eca610@suse.com> Date: Wed, 9 Aug 2023 16:22:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> <1cfa92d52d89b2013218cef1c518ab4d@bugseng.com> From: Jan Beulich In-Reply-To: <1cfa92d52d89b2013218cef1c518ab4d@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0254.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DBBPR04MB8012:EE_ X-MS-Office365-Filtering-Correlation-Id: 8aabeb02-852c-4fbc-7346-08db98e413f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mMz5HWvqXr6OxD4YMZmuj4/9OEHTOx4Z9gy/S7Ah6HYyqn0G0vpsKEjZ6QAn1dSOAus1qYKXDaTrrs6RB7vsycgO5jrY0PVnMsF9kjE83AYos4vLGinsRTypRy9SfF/kvDCmhMTRNpjecE+lAMSbv22M8Y1XBrFzR2DKZvW7g1kDnkrBFEfkMoEnt5bSJE1SFpYAl+SPjr7mmGZ6Ip+FeJ2PEWBNaifae6PJYwdRqd1zG21zwZeCcRtuisWM4hdXdiLTIHhV4/0Cg8tzH/itlXErDWatQWV/rX/Yh+8Njkx5w+X1cueIB6IRRd0FyETxk9gJ/i+LR7BnSaveNomkKIQ74xhorfLCCi3Gq/Op4OyvmUp+GmZLK7SmwfwpxcSADeRlvM+2IyxxJ8LuCb7cg6Mrzsy41EZwiuQG32qN/6PlIchaBmdoSi/MaurDbVKMekH6g4BBH6hhXRMG2QFrFJzGRrxpYxVni/4QL/f2HifTxQrM45drNCppkFZpqmUCorcvWJKx4ffiUb7XHeX+9f8ftqNYOMl326Autsq9DvMHyftMGT3ohbxaHxvSlH9fGxLBy///fuHkc2iYAfnJy1ATjdArqOTNT5XSx2QUxa+azPkA/WJGeeu/vtq3OEpM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(366004)(376002)(136003)(396003)(1800799006)(186006)(451199021)(31686004)(2906002)(7416002)(5660300002)(8676002)(8936002)(41300700001)(316002)(66556008)(66946007)(66476007)(6916009)(4326008)(36756003)(6506007)(6486002)(6666004)(6512007)(54906003)(966005)(478600001)(26005)(31696002)(86362001)(2616005)(53546011)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHJ6M1hKWnEvRmk5YkVIMXJDVXRIeWNMZU1RK1QxaUFYOFRoWGtvSXBhUE4w?= =?utf-8?B?WEZTMWFJWFNPWGx0clhlMTU3R2JiNVVMRkNiSEtPMXRYT1dXMHJBdUtKdlVM?= =?utf-8?B?RlpMUWRYSXlVbXpmaVpNcjFHelpTUFZaS21BL2RMcWVpYjRJNWhSdXluWFVQ?= =?utf-8?B?aXhsZk1xRmNwRm9adTlZOUxXb25nQ1czOVdBdkU5ZCsrcExzNDhWQzYwRUIz?= =?utf-8?B?WDExb012b2MyTDBNSE1naUltVStBRkxoVEtwdkFhWkdGU0ZIT1RqMWJUSHVq?= =?utf-8?B?RWJqN0hDUG8reVpLUC94TzlGSHc0TVdSd2pUbTMvc0ZEQWw2QmpJajNkWXN1?= =?utf-8?B?UmYyOXdQK2dFOG5jajRFcW9aMVVWN1Q2Skx1cDhSY29SMHI5bTBNaHJuNFJw?= =?utf-8?B?alFieTBRZ0xzWXpxM0tZcFFRQ3d1dHBxQW9xUWo0WFFaY0lyeTd5WlFLanVE?= =?utf-8?B?NGtUd0w3YWloRGptR2dwMkU4TlBxM1I4enFVTVNsaU91b2tONUZDSUVPbU43?= =?utf-8?B?aUMyNXNXTTNpU003aVM3TnNzZkUxL1B1cUVTVTREdnFibmlWcGRma0hmK2VU?= =?utf-8?B?cTR1L1k4UVJKZEpuOVNjV2haZmVoQ21ZT3lTSktrMm9hUHdZUE85WXgyYWs3?= =?utf-8?B?OWIxWDVpclZsVHQxVWVEelRzM1dxRi83ZlRHUGt4c1RidHBUYjlsamlRekxj?= =?utf-8?B?bU8zR1hneWo1MERQUTB4MGcvc3F5a3RnQXhTWUFUaDVvQ3AyL0JQQ0gzbzh3?= =?utf-8?B?K2F4ZlEvTk5NTGpwc1hFRzJZbTJaZktJbFVDTjR0ZExnM043YnZOaTNDcGg3?= =?utf-8?B?cUJMUUJZQllLeW03RU82QnNubllhNW11VTdtcng3OVpNaEgxdEVjSlB1Y1Nx?= =?utf-8?B?WHFDSEhYT0ppQUhtdjdxcHkrVU9kVlBxQ2tBeU1sdkR5bmFhekszUldYMCsy?= =?utf-8?B?Q1I4WVdaZmg1cWZzL3RQZmtmMjRQbGh4Uk4yTFdudnNhdjNXTnRad0VKVWpo?= =?utf-8?B?cHI5bHozamlWQkJySkxLdWtpeVJRUTBYa2FncVc3SVJlVkxicGpHTUo3L3VZ?= =?utf-8?B?aWVFWjBSVUpjUUNRcy9aUUcwYkY3NnRXWWcyNEVlV3pRMThpQlhvaTRVRVV4?= =?utf-8?B?azUxdmIrQ2liSTlwVURzN25yclNSL1M4TEdneDlsNk5nam0zNkh1UzZTTVdS?= =?utf-8?B?RGs2WVJ6cXJ3a1VjalhXWExvRG9DSjFkeVJjMkJ2eXhKZjQ3V2dnUEdTaW1w?= =?utf-8?B?VElMU214anhwNUt0YSsyS3RxWmpueXFxd28vUU1NOGRkRlo1RVhETmdNL1Qz?= =?utf-8?B?UEtqUklYOCt3Mkhxb0owNnBweVZ5c28zNFVGRnp3N3VuakhSME9CNGlHMlBt?= =?utf-8?B?blpEWEh6eVQwa0tNc1ZMZ2NDUTF2WXpHSy91aEpTWERvQkJwOWtwQ0JielVY?= =?utf-8?B?RlYvaC95b1R6bW1KajBPNnNBTHB1K3NMZ2U1ZWFTdjR4dWxSek9hQzY1WlBv?= =?utf-8?B?cWxtZTVWQkcrajEvMWVPYjdmRjJSN3U3UXZYRGgyRFg2Vm8wUXpld1hBWS94?= =?utf-8?B?NGJ3VmxCVklRWlc1K2VrQWFUK3B0ckpzSXZTR3ZmdGtFMzZPS2V3SUtEN2tF?= =?utf-8?B?M1R5SVVwZ1hNRWF6S3Y5WGNhclJnSkcrdXlqTWRGK2hzRHZndURsdjMzL0R5?= =?utf-8?B?azNNcWozZmpwaGVUemJHcEZNcEhnQnNWU05qR0tEMlo1V3lzVGpZd2JLSEhJ?= =?utf-8?B?T0VpTFBPUFhORTBmNWpGTjFHZFNacjhTNC9temNPTjBURDBpU3R2OEhmQnFj?= =?utf-8?B?OHNZRk9QOGR3UVdiaWVNR1hCYy9Ha3hXOUZGb0lGaEJzaExsTEthN3ZPR3Zv?= =?utf-8?B?RkpJODlLeHdiNGZoKzVmaGN1dGY4UGQzU1VOSzBCRzNCcnZGZVdFMGtZUU9V?= =?utf-8?B?Z2RRZFFRdTNRVWhSN2hJRE1rM3dRZUZkYnhWNm5IcHBXWE5mY045UnRwZ0Zq?= =?utf-8?B?OE9LVXJNUUxEZ1Bkc2I4OTNzMTNYSHUrbzhrQkhVMmRDUlh5NjlraVk3NTFv?= =?utf-8?B?eTJaYjR0VFZROUc1Sm1yR0NkcDhvRWZHRk1HaU1mOUtGVFRHSjZQcDIrK1Bl?= =?utf-8?Q?fBLI2u0/j9sEdzL0sAjlsQyd4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aabeb02-852c-4fbc-7346-08db98e413f6 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 14:22:35.9351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KjoJndRK12XdcoTw1YhIHdsaLXFWbNRgrEitLzlOQK7yqaeJZ/I/YmOXVs5e3nyng/I6Ccm9ekCCMVy+pOxq8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8012 On 09.08.2023 16:17, Nicola Vetrini wrote: > On 09/08/2023 14:52, Jan Beulich wrote: >> On 09.08.2023 13:02, Nicola Vetrini wrote: >>> The additional header file makes the declaration for the function >>> 'init_IRQ', defined in this file visible, thereby resolving the >>> violation of Rule 8.4. >>> >>> No functional change. >>> >>> Signed-off-by: Nicola Vetrini >>> --- >>> xen/arch/x86/i8259.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c >>> index 6b35be10f0..9b02a3a0ae 100644 >>> --- a/xen/arch/x86/i8259.c >>> +++ b/xen/arch/x86/i8259.c >>> @@ -19,6 +19,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >> >> A patch adding this #include has been pending for almost 3 months: >> https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html > > So do you prefer going forward with that patch or this one (mentioning > it > in the additional commit context of course)? I would prefer using the much older patch, but of course this requires someone providing R-b or A-b. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:36:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581179.909757 (Exim 4.92) (envelope-from ) id 1qTkIB-0008Um-Hk; Wed, 09 Aug 2023 14:36:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581179.909757; Wed, 09 Aug 2023 14:36:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkIB-0008Uf-F2; Wed, 09 Aug 2023 14:36:07 +0000 Received: by outflank-mailman (input) for mailman id 581179; Wed, 09 Aug 2023 14:36:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkIA-0008UZ-If for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:36:06 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0f3b12f5-36c2-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 16:36:01 +0200 (CEST) Received: from mail-dm6nam12lp2170.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2023 10:35:58 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BY5PR03MB4919.namprd03.prod.outlook.com (2603:10b6:a03:1ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 14:35:57 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 14:35:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f3b12f5-36c2-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691591761; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=nYx+HxtKi1JS4SAOvd39cD21W4X8yr8Lg7PLyMUnq8s=; b=S62RG+iljrX+Y9u3zI3o85MkoJ3SU7zqPDgX5kp2irQvH/j8f3gWa6yK RrPXE02qBtW/fA0XZYXqssyQLWwjHOhnHZfsQgsKRWFiLUURx26xCOvNG lD9kXZ7AZv57Hg5qKEbsYWAV1RvScrIB1dWqB6E+uzuuWjkxxyeLpe+CS c=; X-IronPort-RemoteIP: 104.47.59.170 X-IronPort-MID: 119017707 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:J3xyuqK0sWXkXfW/FE+R/JQlxSXFcZb7ZxGr2PjKsXjdYENShTMDm zQdXm6BOqyNNGL2LttyPN/i8U4B6J/UmN9lHgBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4pBGt+p dgkAwshdy2FqO2H2eriW+dF05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMlGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqqANtNS+XnnhJsqFif7WMXUT8caXa2pMbhmmOYfNBuD 3VBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqYCYFSU4J5oflqYRq1BbXFI88SOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:pHR41av1Oe3beomZUBf1iuq/7skDSNV00zEX/kB9WHVpm62j5r mTdZEgvyMc5wx+ZJhRo7u90Ze7IU80iqQFhrX5UY3OYOCkghrKEGlahbGSoQEIYheOk9K1jJ 0QF5SWa+eAa2SS8/ya3ODQKb9J/DDtys+VbInlo0tQcQ== X-Talos-CUID: 9a23:Q0zFsG0c9BxfW9egWm3ZPbxfRMUvQi358FzrD1aFD0lmeaTNEE6e0fYx X-Talos-MUID: =?us-ascii?q?9a23=3AgJ5cnA4o7wghZQ1WPOyug1Jcxoxt74+hDBkvm6k?= =?us-ascii?q?rtsy7bTxdHRCfvRCOF9o=3D?= X-IronPort-AV: E=Sophos;i="6.01,159,1684814400"; d="scan'208";a="119017707" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PiIqgldnA3UAn7dl31PDlEZkiHB6LhGp2ZXQTPRpTmlxRTphqyUDe/hjHDz4341E4sdldfOgkvLwWSz6kH+k9QE5uXINzlH/h21soWBvGbDmcrj3kshHniao7W8zV0T5FMO6KtjrMlluwQyw6MTK3K+PtIYklC2PFX1hNsd6p7hV16wm1Rvfu82RMyT9lDO+EiWFNFMeZcYMm+K0wgLl78ChrqUSld00py/E7t6C90xD0recnQMYs8jEIYK0dJmVPJUL1UlgH6g9NZ7OcmsP0/JZ3+rl7CSPVkXafow/m47nx2Pz+MetcY7GR4hp0vjlPa5D65E9QZDFtYe97F9GvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RpMMCxfj7BVSG4J1D4V3WsA/uJ7w6fw04YD4dnrrU2w=; b=jesuw7ruz2mAzS/8J0+vN6QcSaIC3laWEpO1/UHAW/gOe5HjoeyuYW9xz9/ppstUvjctN+807ikNNC55B085+U3R0rk4o4St7oDWtJPapMWZ1nSS5FFohqSBoeS1pG1XRnD2PMlHM/4IiGuo8rZ5oBSPQ/2mZiJDPfm4Bvyl72T6NmjMsv517uYPJjq0gNWWDAFB1Cpjdlr0Xft0FBVrdh2KTdn0MUv3O7nph0lRH9fwrWpDZVZh+EhNIDUot1NMeV/Lzil5SeqTvXGZqmyo9ZIlHvuDIG/G8n1uDJaP3gdPb8SnUjdrZpA8kzurX7ExPHb5HFSRrsavW/SXY6r+pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpMMCxfj7BVSG4J1D4V3WsA/uJ7w6fw04YD4dnrrU2w=; b=PfUs2JjybMS3HRe72P9UIDAGfI3ChbIijpeZa4QhavGx0azCf8eckC1+EVRHRjXzGaA6Mx2ncgQCt4I33nL8sixZ2NzEyt4J81RZbS/ZJj0fKDlOSJ45+bHBkBGPWiu4kOBk4Qy5W0zqb5pNW6JBe1ToClH9HRMT+ZhtdUgLfCo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 9 Aug 2023 15:35:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: [PATCH] x86: implement cpuid() in terms of cpuid_count() Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <9c310f74-e6c3-f86e-8044-0e078ad00254@suse.com> In-Reply-To: <9c310f74-e6c3-f86e-8044-0e078ad00254@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0560.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|BY5PR03MB4919:EE_ X-MS-Office365-Filtering-Correlation-Id: 8908885b-2e2a-48cb-4f71-08db98e5f16c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BSq+9hTXoBrhZqW5JYfHxBPa9qKJB4Jg2fE9Xi9yYjv3NLjZwwAAnIg6JWv2hJWqWgWAYcySCU2KoXbpfg5YcFREHtHsnm2xHt30h3HF1QNeYs/xI0uFkdMHSk4tX4Eo42w2iaH/FTWw/jdrmPD0YyF+I3272Xpw/dWwD1IsuDiQVzG+YdkcTe5DVfD3Upexhj2wwnTrZK0OsNBu93vWiCmbDQSHCpogirVxcbOvyqmD3PcbnZ96UwFAYqaJcC+ZXaEpzt+pFwyTfczhO2xlJyK3NTLaBQxws9M6FNsNWpTEezE9NqMTouNUAV6/9jZlXMw6tdArFeWIuKudcTXm/6+yC65CCpvQ21dzkFV+LmPaNcLng8B6trQsSwLU6uUJZHCxOz4c2BvKAeqDI23Rs9qUwhq8IFwC+aBf1C6mpcHeo8cjt9nraFdt/JYYx4ttKABXyeK9gks9RVBawtaDvY8spxd/UkLp2xgVJGDsm3N8TNmR67hhcCHSvH1pCctAatuJHlFJHd2V73bN7Ks91CZZnwWBPgwEwqn36HU6Mxb3pwI9qU2n9RfGc0J4Qzx8H0ccEvQ3ubceyxyRRHx524p7kL7Jgu8xcix1IOE5mv3bHDnwJ+aEZnX8eOLunuRxKr+g4wa15U5fHRcQNQh/aQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(186006)(1800799006)(451199021)(31686004)(83380400001)(478600001)(82960400001)(2616005)(6512007)(26005)(53546011)(6506007)(107886003)(8936002)(41300700001)(66556008)(66476007)(66946007)(316002)(8676002)(31696002)(4326008)(2906002)(6486002)(6666004)(36756003)(110136005)(54906003)(38100700002)(86362001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEpEbDlXZTNQUnBkNWdQakVXQmVnWnhvbXJ3RmZPclVQS3FLU2JNWDgyRlhh?= =?utf-8?B?alJSZk5tMGw0VXdiS2h3dWdQeVpQU29wZnNQWlM1T2lZYjlHWStpTkpiWGEw?= =?utf-8?B?Ti9Eb0lJZnh5QVpLSXRMQ1BBMFl2UDlKdWMxb2FVdStWY3NuK2VFRXdaZkdz?= =?utf-8?B?b21OcE1helBKaE8rS2l4WjErT0VJdkxOL3UycktVTGtTRE5iRnpGWjhYUlJ2?= =?utf-8?B?ZG9JbW9iN0p6emZEVVd5OWhzckdrVzFvdUVLazl3dGErUSt4SXQvaUh0NDhO?= =?utf-8?B?WnJMUTFONitMQXR4cjNjS241UVo5bVI3SUZYbmhpZVRBOExxNHZLTWV6NVli?= =?utf-8?B?WTNMdFRjakNXb0NYRzQySmdjZ1h0K09rTXR4NGlxTE5Td1lpNS8wV2ZpeXRG?= =?utf-8?B?bk9MbjJ4eS91eWJaTDNQdEV1bktDay9MMnpxU1VxRXd4dEswbUhVK0VSSDVC?= =?utf-8?B?WEtwL01PVEUxQlcybkJGTjJEWVgxbHBKRlc5K0cvYXBwNUgwSlZPcHVrUHN6?= =?utf-8?B?ekd6amxwRE4yRC9uclpjb2JkQ0U1SUVzV0xZbEJxSlhKOGd1NFJKTmplT1li?= =?utf-8?B?OTdOcVZTNkY4NE1HNjR0cEh4dWw0dGExVGNvNnRuYmIzbk1jb0drSHNuTENH?= =?utf-8?B?RXJCWDIzRzVNRXVPcnRxQlVLdS9rY21xTzVtUFZWMGFUSU93S09oRlZNK3NR?= =?utf-8?B?WGVYS3YrZWtaSERWYzh5b2RteGEzRHhIRG1WYUIzeEFMRnVNMWhNcmQ3ZGFQ?= =?utf-8?B?eHFQS0JzUGRObTNzczVOaXZEb3dyOGlVMkIxbG4wRGkvcGtjYjJrVGtCNzFz?= =?utf-8?B?b3NqSzk5UlorWjJRQmFXSGVFam1mYXI0NE5lYlBxeFB4aE9NRTBjTERiOFlh?= =?utf-8?B?RlllQ2xnYTE1VjJBMUhreG9qanlpT0hLN2RJNzdwcEg1OVZDMUxZYzMza2o4?= =?utf-8?B?aFhkbEEvbXNDTHI0VUltK1V5dUdRQ2cybmt2dFBqdndGaUVCSVZWOU80N09r?= =?utf-8?B?NlJGTDhpcjdxWkcyeW5Ub0U2VmpkYUU2bEhKQjltT3N0aitpQVp0RjJiT21z?= =?utf-8?B?TVo2TDlIU3M0bHg0Ni9FQlNMdG1FWGJHbGxPUFhKcnd1WFJoWU1EdWlyd3Jv?= =?utf-8?B?c091MFJCK1JhTGFCcmNWcHVjazZSbVk2dFkwVzhkWVRPa0o5eTZSYkN0ZnRk?= =?utf-8?B?dXdETyttWVV4MHg0c3pZVGJ2NXZzVC9Rb3VjMVl1djAyZ2FUQ203dDdTQmZO?= =?utf-8?B?UzlzeGNpUmYvcmJodUNnY3VVZzlDRlpEWGJkZlQwdGdKMmVKOGM2L0xNNm5o?= =?utf-8?B?UWFreWJ0RHUvYUIvdWhHdEJXc05Hd1NRK2pzYTdxc3ZQemlmT2RMWm9IbGdU?= =?utf-8?B?UXk0S0ZudGdxMjFCdWpQVmkzdW5rT2ptSEVoN3RpQXhVTjUvTDU1ckJzamVH?= =?utf-8?B?M2VoVWdkM0NhRlF2V1pEc1N3d0JIMHl5b1JYSUFyaVZqTGh2MFdKbVFYL3lP?= =?utf-8?B?RmJqa2l3T3R2UWlFMEFzdUJMWlhNREJWRGNPaUtYc1FMM2tmd2pIeFZKVFhx?= =?utf-8?B?M1pnZyt5ck9lSHY5QnRCc0JqSHYxL3dXa1k1M2UwQWpPNjM0a3h0OVRTQ29y?= =?utf-8?B?NDB1Yi80bDBkNDIvVFRTakNNRWtpdE5IdkxOV2FheW5RSjVLS1pzOXAxK1dM?= =?utf-8?B?NEFXd0xYODVKdG1weE1XQnRSOG1mb3BiQmYyZGhqZm1KcGcyVnBDdVNSZVY3?= =?utf-8?B?dlNXQ1VvTHpMN0Z5M201S1MzR3VqcXBaT3M4S0lSTkRhOVNjUUxXeGFPeE04?= =?utf-8?B?eDBTMy90WW16WTVIRnN0VzlUbVFmbC8zK2VUN3hMaGdyNTlqRkc5RzNMQmlm?= =?utf-8?B?ZjNhK3hMWWpmdWw0OE9CdWxKZzd6TmRwbE8wR0V5WVNFN2dIeGlhQjlGZXRO?= =?utf-8?B?Y0Q1S0NOQmZoKzZ5QWQ5VUY0MUpwWHlESXVuR2VjcFBrZlhTeTR6UkJGTm9n?= =?utf-8?B?QjVnejl5T0t6N0Z4TEdBWm1xbTdYSnlSR0VzYUQ5MXR2eko0WlY3bDhOaGZN?= =?utf-8?B?SG5aeWpWUkRLK2VDcm1IWEh1U05aczhsUjVIMzc3bmhmMXFLVVMyWE9OeFNy?= =?utf-8?B?UkZnVm1DeUpEcDVTT1JuS1RQNlErcEdoamhKSG1rMVBJZkF5YkY2MS9nUThx?= =?utf-8?B?Rnc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: fBdRq232Ao49GTaXnB3SQKpP09v0ncCERDsPn7FPjmWszaVNO4/VCFChUSffvfZ+54GMQpkwx/Y3VLQA5aiO0eWygzb2PbqDXP8fDzG7FKfVfH+iRg3oPy1lyKJ4Q7RtUFhcYYojZ61pMeLa1Iq/q6Yi/KtXT7+nSuYbvulBN8mKcnTDPG3BLIl3HKwazNVfq+C0A8a/1vvj/eyjXI5nBlCecfi2jQmwMlSnFT4aMBZo5uSDR6cwde08M7xBI34gFs1QcciY3TgGgWdru2SKOVFQVddN96hHl+YZEnMMUnD1ruGVam3XfwDDckG3OIWOWfI2LbZVutCQhdB9d9iRFeVwpMqN6+zh7aYp7+O5hwbNpuEIOwAxb6zXP9c0k+4G4tpUytzXWpy3/xc9gn9bd2/xDtPUoPG42sK7N/RVO+oF1O7N7aDW2BCaERbEfezjcIkhSh3iLGh5xscFKskHLG7SBIkVisJjMbS6QGoRxtSrxU4UwDvAG+V7W/G+Amjx38UuDSIWR+OVbKhHm3xVAcwAmaz39UZLFY1xU5Zh/evpCJg/qYFUnAUeVAMDj6k2t8V+xGHRjtikMOkVdZZgpGzIDcRKbtINfiTgHpRbvvpXa4ce8zA70iQ+ndi5CNQN88h0+IU0BPSOrhyHFeFIBN1N4CtFHsWUZtJWQofhaes1pD9Up4Mi/YjlzVncvvwz0DcBTkBWVCnQhSMQmqAZLOmyPN1B9lw9QQQ+sSh7NwmeTQkEZVnSFFo1Cn/wk4SGqtwUR+OrC6EQl5FVnPsNJ77lQZNKL6U3dwEbf0lyjlzd0ggSeP/vZx3SupGhC8MQ X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8908885b-2e2a-48cb-4f71-08db98e5f16c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 14:35:57.0953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T/I6iiiWIELGHhv6ECEKmeN/Mxl7Zz6lAlRx8kIxrHQc2Bksny6f5zBnsx2L+7h3yXtFtReG6GnKm0i7LSNzZIIyRUuKEf9lsmEonGJyBmw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4919 On 09/08/2023 1:29 pm, Jan Beulich wrote: > Since as a bug workaround (likely inapplicable to any 64-bit CPUs, but > it probably doesn't hurt to keep this) we clear %ecx on input anyway, > we can as well fall back to cpuid_count(). This allows getting rid of > four risky casts and makes things type-safe. The latter aspect requires > two type adjustments elsewhere. While adjusting init_intel_cacheinfo(), > convert three other local variables there as well. For the struct > cpuinfo_x86 change it is relevant to note that no 64-bit CPU comes > without CPUID support, and hence cpuid_level is never set to -1; the > comment there was simply stale. > > No functional change intended, yet of course generated code isn't > identical. > > Signed-off-by: Jan Beulich Hmm, far less invasive than when I last tried this, but that was years ago. > --- a/xen/arch/x86/include/asm/processor.h > +++ b/xen/arch/x86/include/asm/processor.h > @@ -131,13 +131,8 @@ static inline int cpu_nr_siblings(unsign > * clear %ecx since some cpus (Cyrix MII) do not set or clear %ecx > * resulting in stale register contents being returned. > */ > -#define cpuid(_op,_eax,_ebx,_ecx,_edx) \ > - asm volatile ( "cpuid" \ > - : "=a" (*(int *)(_eax)), \ > - "=b" (*(int *)(_ebx)), \ > - "=c" (*(int *)(_ecx)), \ > - "=d" (*(int *)(_edx)) \ > - : "0" (_op), "2" (0) ) > +#define cpuid(op, eax, ebx, ecx, edx) \ > + cpuid_count(op, 0, eax, ebx, ecx, edx) Can we swap op for leaf seeing as both are changing? Preferably with that changed, Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Aug 09 14:55:28 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 14:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581186.909768 (Exim 4.92) (envelope-from ) id 1qTkan-0002dd-7y; Wed, 09 Aug 2023 14:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581186.909768; Wed, 09 Aug 2023 14:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkan-0002dW-4z; Wed, 09 Aug 2023 14:55:21 +0000 Received: by outflank-mailman (input) for mailman id 581186; Wed, 09 Aug 2023 14:55:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkam-0002dM-4y; Wed, 09 Aug 2023 14:55:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkal-0003Aj-W7; Wed, 09 Aug 2023 14:55:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkal-0002se-Gj; Wed, 09 Aug 2023 14:55:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTkal-0005bY-Fn; Wed, 09 Aug 2023 14:55:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H5+mt77SC/et+wqVR/8ALaYxlzABOH3aj9unb6j2gdU=; b=zMr4aC9NbPjXZ7EDA+nuSaTmgq M5FQ0Qvay8SvJt9qnRxtDBn6AjnKqKAiA5LNRQrdWKkMytPH0ypVGA1IysxWFpVPMPxeUl8XiD0b8 becf0nMIpGD1u/qDcvaCBKUpY0eoaHRuksCbquOosuWeDGa1Y/8+F/RslLaCtypfMx6k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182245: all pass - PUSHED X-Osstest-Versions-This: ovmf=136931c4dbf532ec913b68673c91b4285e63464b X-Osstest-Versions-That: ovmf=3c274c0d83d5464b336e40058bc5969bfef25f7b From: osstest service owner Date: Wed, 09 Aug 2023 14:55:19 +0000 flight 182245 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182245/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 136931c4dbf532ec913b68673c91b4285e63464b baseline version: ovmf 3c274c0d83d5464b336e40058bc5969bfef25f7b Last test of basis 182224 2023-08-07 23:10:49 Z 1 days Testing same since 182245 2023-08-09 06:10:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Foster Nong jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3c274c0d83..136931c4db 136931c4dbf532ec913b68673c91b4285e63464b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:09:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:09:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581194.909777 (Exim 4.92) (envelope-from ) id 1qTkoC-0004J3-F1; Wed, 09 Aug 2023 15:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581194.909777; Wed, 09 Aug 2023 15:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkoC-0004Iw-CI; Wed, 09 Aug 2023 15:09:12 +0000 Received: by outflank-mailman (input) for mailman id 581194; Wed, 09 Aug 2023 15:09:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTkoB-0004Iq-2w for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 15:09:11 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afe573f5-36c6-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 17:09:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afe573f5-36c6-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691593749; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=P8fp+v/6smNsGrR1Qs3vlq1yLFmGcEtmhV0Xy/O2hIM=; b=DyrRwl04sBvwx2mfKIUcRFlSlBQujsXvI00e6oul0sCR3Mag0h5laTfn 63uGF8+OutEMhmjQbrHkRwig3T4yMl9ozzw9LgwOBwtzsqIMhiX0XGMTc j7mPLYc5fPS6MSUW3W2QNaEYQDEDTpTwnPTMNQxy2Ybyph2S016ukm4ao M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 119022402 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:ValHlaAXoq1K4BVW/zPjw5YqxClBgxIJ4kV8jS/XYbTApGh3hmZVm jRJWGzSOvzbazD2eYp2Ptnk8UIFvpDSztBmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GNA7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5NlOOFNnx /IkDzEobxCJteW1xbGac7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTILs4kP2lmT/UdDpApUjOjaE2/3LS3Ep6172F3N/9I4XbHZ8Pwh7Cz o7A1zvXDQ8XDNCQ8jGYw1iWl+HIlyrbfI1HQdVU8dY12QbOlwT/EiY+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFamlBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6cLqScCj wHT2YmzXHo27ePTECjGnluJkd+sETYqFFYwTB0KcSwExtjjqrM0jRfMb+82RcZZkebJMT33x jmLqg03iLMSkdMH2s2HwLzXv96/jsOXF1Bov207Skrgt1okP9D9O+RE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFRz3oxZPnqgKulmSwXuF1O5eIVcFh 2eN0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZrXgzPB/MgD68zxJEfUQD1 XGzK5nE4ZEyU/4P8dZLb71Fje9DKt4Wmgs/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iFy9z jqrDOPTk083eLSnMkHqHXs7cQhiwY4TWcqn9KS6t4erfmJbJY3WI6KAnOt+K9Q5z8y4VI7gp xmAZ6OR83Kn7VWvFOlAQio8AF8zdf6TdU4GABE= IronPort-HdrOrdr: A9a23:gSTAGq0wmMlRM1aWf2WIIwqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-Talos-CUID: 9a23:eeglZG7SCyKdeINnDdss6nEtI/IMQHPh63b1Ik+yO2FqTb60cArF X-Talos-MUID: 9a23:SneQqwS1kBEUWbtIRXSzqj58Of9k7J+lFXEnq4QIvMONFQh/bmI= X-IronPort-AV: E=Sophos;i="6.01,159,1684814400"; d="scan'208";a="119022402" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/spec-ctrl: Add SRSO whitepaper URL Date: Wed, 9 Aug 2023 16:08:54 +0100 Message-ID: <20230809150854.66849-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ... now that it exists in public. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau MonnĂ© CC: Wei Liu I did try to get this URL ahead of finalising the XSA-434 patches, but alas... --- xen/arch/x86/spec_ctrl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index ebe56a96cdca..bafc41a2f6c4 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -898,6 +898,9 @@ static bool __init should_use_eager_fpu(void) } } +/* + * https://www.amd.com/content/dam/amd/en/documents/corporate/cr/speculative-return-stack-overflow-whitepaper.pdf + */ static void __init srso_calculations(bool hw_smt_enabled) { if ( !(boot_cpu_data.x86_vendor & base-commit: 236fc9fdf97f4e7c64824ab793e8dca30dd54ffb -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:35:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581200.909788 (Exim 4.92) (envelope-from ) id 1qTlDB-0007lC-Cs; Wed, 09 Aug 2023 15:35:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581200.909788; Wed, 09 Aug 2023 15:35:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlDB-0007l5-9P; Wed, 09 Aug 2023 15:35:01 +0000 Received: by outflank-mailman (input) for mailman id 581200; Wed, 09 Aug 2023 15:35:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlDA-0007kz-7U for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 15:35:00 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20608.outbound.protection.outlook.com [2a01:111:f400:fe12::608]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4afb8afc-36ca-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 17:34:57 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8594.eurprd04.prod.outlook.com (2603:10a6:20b:425::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 15:34:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 15:34:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4afb8afc-36ca-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B3/KpqNa0tUfeLLfnImUJaI4iVzB6j/65zQ3vK/LrSpl1+Frzur3/mXIRFB/QuenS0L+nQvMOlx6lnZFVORgTQsBZZLNAZK0YDxAHsVzxzGfXy7zZa8epmUgr7tcvHk8orIkH0fyemYXA2HURQhSp4kSgDRnxkVscMYRw1CVG3yq39XPw6+HtW4eKskE2xowDi9PHJvbX0LC0IU2MjaY6QOGpPpFENuLFE7M8+py7s+XQE9DaYfwFM0BIeUihBqc0As/uhILLkTPvOmLcOrK5+fn5Hh/DGPTuP6c0dGhE6Eh+5iWCcrWPWYlNLKVZtfEZ7JGFt/RKoqeL8hUrvWaBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WGfDexlnaZ5wJJzQVskvQuhXLBE07gOBI96wbwnjhd4=; b=P0vR5gwCysMUXFr9IwCP9dthy6Z6Shc6tcyXwlfwg3az5ivjzoiy678dP7DaUASHFn48vGBod0ItM/84wpzkcUMPilhqjEXBzxAOyIDeXBLZTCZGP09UzN8Ep76ByqRuH7DOgwSbyoeNmbwcAzzpYJqf9GlyE/SZz97eYc6DV/8Hrg5VbM9ToOiV9w4hrtYQy8XXCQq1/Ewid4qeUYMvWveV6mIqTxHhqZaEPDSaO07hD0WfyrbHOVcR1tas/lQpISynOe9yIED+8iP4QfzD48EesBY11reepBpA9ForxSZHIINKPxpbMJYu7kackJiW9gC5ZEU8xGDT8sjCMYQ79w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WGfDexlnaZ5wJJzQVskvQuhXLBE07gOBI96wbwnjhd4=; b=dUjQybJc28uGNKfMQgTIFP/Hfb1CMRL9MUYiMknNTmgRMtJfHqkZ3bE5UlKK1gapQSZATCK2Zd/pGnbVUfauiS730I0Tq/b64MhF1MmGq7DtRxbMRwnjoAFFwSc3bRFQ9fkQOywINu/opPAyJxuPmixfKLAlY47ToIk3OjlC9kmkXQl5bF1ehCuMiErGzeXh+Fbneejio0/5lNmovHLfL2FSWHgIMFJJpfMLklxbmxsuPj9WBOJGs5yAXHv9qqkBbExv+aM0lxh6rhnrVmSa+QdxMeI43oNsIDmrdOyxV6c8EH7zHwwp5iqz3J4buTVa6pPtN6u1pxOCh1eEx4Yz/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 17:34:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] x86/spec-ctrl: Add SRSO whitepaper URL Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20230809150854.66849-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20230809150854.66849-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8594:EE_ X-MS-Office365-Filtering-Correlation-Id: 6796d4a1-a26b-4d49-36c8-08db98ee2e22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eIqwWREAtWCCgBZ+sQ/sXf7sQpBFeFFb7PqT7dRllTHJ/UbIdW/n7hmJ8Q8y0AniUnon8APzUCKGWU5nZ2qbEYqD604rK/TO99jrKELkZkco+32YSTiVNDCuga5oZWzVUZQ2lLiiwdlfu+3pJz7hy9iDw0A6cXUIuVlrEuf+cBYuRubjeVXQQkZ3jGQTMbF0PFfa8pviGzlWaMlWkDrSMM9nIOny86SjcKouLWJX3t1fCQimcXXILuA8Ej+3T4yn6Abns1ZZBmgrgau8ws0bEEEstWQYV0hcCreMYpKPaFBtNdIyCpmZDklhUPENf3+s3KENr3d9dzRsC3c4Uff/HkkDGqpC7QloQM2XOHKFm/VOewj/XQI8Njgkge5Bflz3ZO8RReD3+KdzZmyHXlm58pmf5+YY2aU/VQNgrBNdsk4FQbrU3UyC3hXdVoBUh3amO1TW1kIvoaqpnAugBrCuHqhjyMFWinnmZ+qaaVmM/CxPQ2f8EL/XzTi7yrg8xAo0LbLwUd7FJ25CaaTKEDiFnLzqmr0hPZVOVWGl8QrvD/mcXTB2zpmynyhmMYOErrRWbNsmDIQ1ufKbTvBaKjRcjtQYHb9m13MMp5i5+POpsGg3TIRvnjyG45NmVLjakhAxlXfczPssYVX8n3Ny2d2S6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199021)(186006)(1800799006)(54906003)(26005)(6506007)(53546011)(6512007)(2616005)(6486002)(478600001)(38100700002)(2906002)(5660300002)(8676002)(8936002)(36756003)(66946007)(316002)(41300700001)(66476007)(31696002)(86362001)(4326008)(558084003)(66556008)(31686004)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWVQdWZaVVNpMEkxYTJWSkZsQTR0bkxpWmR0Y1dyVnpmeXRQd0F1RUZQdXNt?= =?utf-8?B?K0lscTVFdjdzbHV4Ri9aRWs2UWU0c3EyK2p2MGJpU21PbzdsdC96eUFpUGIy?= =?utf-8?B?SlhvcWJQSWt3bWR0LzFCQVcwRm00enFsV2x5WlovUU5WMVNiU0RyQXU4YUJD?= =?utf-8?B?ZXo4SEswSGJMdXhTN1dSUGR2M1crbVZuc3kwWG5FVmFWclc0T2t5Nm5idUFl?= =?utf-8?B?Nk5zcDNsWjMzdERxekRESWxBSWE1VDVlU3BiQVBENWVLRmlPbjBrOG5qZDN3?= =?utf-8?B?aU1Vb0JkU1JKTmNvVUdQZ3ZJOGxmdVo5RDlDekhxWlcrRWIrUDRacUU3blVr?= =?utf-8?B?bzNrK09FUzltUFByZ2MzaEJFejNSMXV2UVVFb2g2WU1ZeEs0YnI5czhoNklM?= =?utf-8?B?S0tSTXZlUkRtY1JwMDJ6WFJiVnFyTGVzaVJqMk03VnZQS2kwTUNmSURWVHk2?= =?utf-8?B?cGh2UlNBbWhyUVJFSFUwcTRiV3ROWHgzQ1piSVIzSklLQVQ2aVd1VDJKTzIw?= =?utf-8?B?MFJkY09IbFM1QkExNU92WlFYQU5CZmloUzFObkxCbk44VHdxa0k1YVFlZy9o?= =?utf-8?B?YzZ0anJES1hxVlAzTlM2N1JNdHVScXVaQWRCRXlWaHMzTk5YaC9tUGNrUkx3?= =?utf-8?B?VEE3Uk1kNUp5Z2ZabjhPMWRNVUxLUjFobXBPT0U5dDBsLzdPUUcxNnQvRDd4?= =?utf-8?B?VitieWMzazVkSldzS25IS1VZYXZxbCt5RSs3VjlKT1g1a01wRm05U0VjVFhX?= =?utf-8?B?MlpnQllGQ3psS29IdHl2dkdrbSs3SEdldjFoOGpWOWFLM21qRlpHZ1plZ2xu?= =?utf-8?B?OUo4Y3pvSjdtbC94aFhxLzRrSHFBdk5EY3l3b3p1MWs0RllIWVdia3hpZ2E3?= =?utf-8?B?L2VldWJpTkYrR1dVQ0NYSkw0QmJTR1F3NElkanFlTFQ3ZDNma0NoZU45MXo5?= =?utf-8?B?eE1JeEdORktVWm5mYjJ3Q2lTYkJIazBQZVE3TlY4dEFtbXhwWDN0Y3NnR1FC?= =?utf-8?B?S1drUi80K0RwTVJucWJ1TForc0RDQnBEUWpONFQ2dWxDcWtOa0d2RHRyeDFi?= =?utf-8?B?WVZUamRVRnA1QjZJMGltTDgvWlhYdFJhU0dBbDNpdXYyUnVKUDh0QjYwbHNs?= =?utf-8?B?a3FGbHUwbDNQYk51ZHFuUTMvamtIK3VMS0dFdDZIb1ovNm1jeXUxWERsQWVE?= =?utf-8?B?Mm8rL1dTaGg3WVBqdEZxTjZHYTRmK3M4K2M0WWdDU1owOVlsREV5RkV3UDgv?= =?utf-8?B?OUxjLy85Tm02cEpTYWZpdjNRWWhoOVpLSURRWTJuV082ZU5NTFN3K1dIcGti?= =?utf-8?B?cXBnQlIxSkRzaExzVFpBczZzcTBsaDdVWjNxQXZoTkdYQ3c4VldQbDZGSjRy?= =?utf-8?B?eUVRbFlKb1RWbEN1NGh4ODBxakhsOXNnUUtBQm80M0xaT0p3dHVBSE90NU1r?= =?utf-8?B?VklnNEhoU2R5RHVXL0o0amZwTkQ3R0NDL3JydUgvRCt3L2lwYWNJUUhheXl4?= =?utf-8?B?bEdzKzUxN0xkUk13UCtwSXA1TC9FV3h3VU1FQlBEMlhnTnl0TU1uMzF6YVJi?= =?utf-8?B?My9LaCs5bEsrdDVhQVVMemZ1MjNlVjZIYjkwWGd2WXllL2NJcmZOSGU2Z21t?= =?utf-8?B?WVVhVkExMm16ejV0NXNZQ1Q4dVU2b3dWb24vM0pHSEU3QkZwQmRodTBBRWx6?= =?utf-8?B?dVhkUWUyQjhUcXpwNXp0OTJDZ211QkxLdW1qczh0KzhQbERsTVZNM25kVWhi?= =?utf-8?B?VWFudmVoMTkxS3RVNmI4bFpDZExMcHRpbDlOblJqWkVqR3ZHU0J6QXVXdnRx?= =?utf-8?B?Yk9saEN4Q1F0Mm1NU2lLblRMUVhlbDBFbmh1cjBidWJUZVI3Z3RheFcwZE5a?= =?utf-8?B?aGkrZWc0MXpIUXN5dW54ZkIrZFlrYkRCNWZWMVg5MVdwUDl2YTEvOVJML0sv?= =?utf-8?B?OW4wMWdRMHN2Qmg4OWFFbkhZaHRhUG1QVXRwWGlTaTF0L3Z5VnJXdXN6VnNB?= =?utf-8?B?Rk1ibmlXTU5HS003SGg2dWJmbnNyT28rK1dJdW04ejdQZjFRMHl4RmEwWlZ0?= =?utf-8?B?ZlNBemxqc1Y1ZnRZWXk4Slc3ZG1DaW4zRDFIeDVYNXhVb1h6VEhlOHVFcXh5?= =?utf-8?Q?hmEMOxgInwJjU4ZulU8Ks/8rr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6796d4a1-a26b-4d49-36c8-08db98ee2e22 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 15:34:54.8615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XfUcTJBhDtstV/M7eb7g3roEpOhUWBlv1TzUR8xFGmv2moQsdurDnEHm+1u9sONEVieneS7Z6P39MOJsNDQjwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8594 On 09.08.2023 17:08, Andrew Cooper wrote: > ... now that it exists in public. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:35:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:35:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581204.909798 (Exim 4.92) (envelope-from ) id 1qTlE2-0008F1-Ls; Wed, 09 Aug 2023 15:35:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581204.909798; Wed, 09 Aug 2023 15:35:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlE2-0008Eu-J9; Wed, 09 Aug 2023 15:35:54 +0000 Received: by outflank-mailman (input) for mailman id 581204; Wed, 09 Aug 2023 15:35:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlE1-0008Ei-ON; Wed, 09 Aug 2023 15:35:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlE1-0004BH-Gj; Wed, 09 Aug 2023 15:35:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlE0-0005UL-W6; Wed, 09 Aug 2023 15:35:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTlE0-0004fh-Vc; Wed, 09 Aug 2023 15:35:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9eE0xlSztZqm9yaNhLnxkX9s2+WmsHKaq6J5u3qB0B0=; b=N392GzDThdxloBkLzRX/e0z+dj GJnF+mKW6AZedw0AwGtdVkDOX/GaBEA47+Zv/iXE07R5e0ZO0c5Zquo6r76a6Uc/HRuuKdnZqLL3h uXVdLUZ/RytU3At3IlRm0TDHkU3ri1Av4tOyOUU9JUEvJGSw/+LyaGv6jie74mIdMrLI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182248: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=15601eed05922c0df5b59d5fb3f9ec6d85e57a00 X-Osstest-Versions-That: xen=a8a7c33e7dd684966d7df66058f2397995dbae31 From: osstest service owner Date: Wed, 09 Aug 2023 15:35:52 +0000 flight 182248 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182248/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 15601eed05922c0df5b59d5fb3f9ec6d85e57a00 baseline version: xen a8a7c33e7dd684966d7df66058f2397995dbae31 Last test of basis 182246 2023-08-09 08:02:25 Z 0 days Testing same since 182248 2023-08-09 12:04:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a8a7c33e7d..15601eed05 15601eed05922c0df5b59d5fb3f9ec6d85e57a00 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:37:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:37:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581212.909807 (Exim 4.92) (envelope-from ) id 1qTlG0-0000Sn-1p; Wed, 09 Aug 2023 15:37:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581212.909807; Wed, 09 Aug 2023 15:37:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlFz-0000Sg-VS; Wed, 09 Aug 2023 15:37:55 +0000 Received: by outflank-mailman (input) for mailman id 581212; Wed, 09 Aug 2023 15:37:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlFy-0000SY-FA for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 15:37:54 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on20610.outbound.protection.outlook.com [2a01:111:f400:fe1a::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b45a2acb-36ca-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 17:37:53 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9446.eurprd04.prod.outlook.com (2603:10a6:102:2b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 15:37:51 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 15:37:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b45a2acb-36ca-11ee-b281-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q3bNOkZ6nvEq1Q9xsJ+hrMV+tGUlsXt9CWeYh/ozE/i1qIiZXt1NiDbYx2EcTSVWDnJgku5MVO2EOlQCG9dSj8tqcputn9HgV4MeuwamBy7V+h8tBqEZ2Nv0LfsayD907gcQwyclY1kSbvDFrU+jCp6h3LttLT+Maxw6jh4geHJ0g2EmRrCkvrAaEkWfusxvnNTAexVxfyipkIpmyzbCdNoTGZbPiGjIkmogFi3JZp9jLx685ypaD7A0pHQ8fyHmQjb5N6BQ8nDwlvvvewnS2b63DfyyzsR0s5lxZeBcDlQFDbRHLTnY2BElXqvoby1uEETUvmfDsOcQPkImyOvGBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rtG9aa4De4cidOdl0bUwW5wESMhb3t/jAM6e15+TQgs=; b=i3pT/Tf8EWBYwNrTdJjZ4Ea7wqdfQhD7QtLrCWy2cBf5Ba6IS6iRPnemjF68r+QSym/KZzuKcpUe9173b0xOKpwN6xS/IhBYZZzdNPf1PUzFlBXxfXoYubqCyTzcm+4mF5x4AFFZKwy+UBm/9WSv32XxxvblRHYUPPQ0a1mFwcHgy71l4in3dnQzCtwwnt0bpMSxhAi3u7QPLlBwkhHbyhu/T9qG9dTWUk7G0LGFz6SEOKFxDOARyG9BiSHgNTW636E61BS1z1Vgj3DrDuvOveZIkonXtd1/Sipm8HtAMnpaqzT9d3HPPAKi8Rc3f0J803/rW9KCJ7qTmmx9EuYH/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rtG9aa4De4cidOdl0bUwW5wESMhb3t/jAM6e15+TQgs=; b=NOZnBJyLEmEe76Trf/3WQ4TV90Ycr/xO7BafWMvgUpbcw8vIJFHpAiPEQLEszXGI2b6UGd0m6kIh87irmLWX2EADHlTJErseYNNdUawXg0Rue3bG3C1StPYkA6c9EXaAI4HrSEL+1LuctspnSHgWAYUP6NkyAtFVawjXVwKLfiFBaFMj6msV1bIjYH84Ow12oFD1otJ5KZN7K+F7r9Yiy9V60hCpOT2ZrMxcWM3GVnwnoLrG3KYeBJ2gddt4LgG8SJr0ZMR4OV1+GDEq7PzZfKwke9CyPPGPPiPzq5jUpG6/mKpbFSbkFhXt7owgaq59CyC11twDcU67f4RcLOXSQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 9 Aug 2023 17:37:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC 6/6] capabilities: convert attach debugger into a capability Content-Language: en-US To: "Daniel P. Smith" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian , Wei Liu , xen-devel@lists.xenproject.org References: <20230801202006.20322-1-dpsmith@apertussolutions.com> <20230801202006.20322-7-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20230801202006.20322-7-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9446:EE_ X-MS-Office365-Filtering-Correlation-Id: 748093c4-55a0-4f6b-09ec-08db98ee9671 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9c0Odhe6JOKz9Rf9iqyXJ/Y6XTJtKpi5xdQ9yuWr/ZEisvfltdtAopOugyuKTwdKJUVAFADoTLf4BSzI3udeJv5vg7UQhM4Gza0euFCDCynS0+RaSjK8UCHNWDP0JDDXO3bRHntVOp2bUEQR1JPKCORkk5Wc6C0pKdxRJKKNxZNi9UjVklujIKLjGxoBW0sHB5nQ5KFTbSH8GCqidmT3z8YxNtJlT7yYMquzIudSSnvuWCxVPFZeXXUmDtuVPrf/4Dw4hYVpvgcmjJH6bWfmdRyKfN9xOGvwe+DK8fissqUqPzP5G+7KMbYG6h1D2s9BsJXDBF4nTXY05GQU+dUswJrDvw71xrEUfwOEAxeqAscdndUPD9ZWQzOvoFZ1TjF087PL/ad9LT2sCChhVgKZkcwFauHujQ6sRol3udWLbuOfHEyC5Lz/sv7IiJb2WSc51PCKD8fanY6m+0Jh59hMmGmjraPW7dWLq1yw5yh4NmjnH8k3vSkYZ+WZiEfYf39ojmlF2h8MmHcabvpDjHPLcrghPPMi+wvAFyhTMNQ+L+m4x35X907i7VH5VQDkIdAo0x36cVUc1mnasFMkQGlb2bBCbm2Xg139ObWM12l7uKbE93fcgeyZXUvlKIVQhTTfjJr+jW9iskcskUr45lZEJw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(376002)(346002)(366004)(186006)(1800799006)(451199021)(36756003)(478600001)(54906003)(6666004)(66946007)(66556008)(53546011)(6916009)(4326008)(6506007)(66476007)(26005)(6512007)(2906002)(41300700001)(316002)(8936002)(31696002)(7416002)(4744005)(8676002)(38100700002)(5660300002)(86362001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c21uRjZhYXpZS0R2bGtsak9hbUt2bUxFeWRQa09zZ3Q2ZGViVWNPSnA4bG1o?= =?utf-8?B?djNUYVRubFY0OTRyMjU2dkEzS3ozVjRkK1RMSFBuNjFwOHN1MHJKSTlVZ1NW?= =?utf-8?B?SzBNT25kY0Ird1VtTU5JL1hMdTk4UmRTdzkxVFFFMmpaR2FPekFGZ1Q3Nkkr?= =?utf-8?B?ekVtQ2J6WndIWTcrbGI3MmRUK3VobUJxUWluSWx6SjBkYW1QMVNOVFArUWxl?= =?utf-8?B?cWtZUVExSWtqL2JJdHZrZHBTcFp2QzFTWlZnZFVrQ0QwN0FnTkV3alNIT00y?= =?utf-8?B?OTc3QjdKbGE3S2J4VjJ3aTdvNDlRL25xUmlYY3lweldmemZtUzVkblhyeDBH?= =?utf-8?B?YzZsQ3h1UFJYeGt0Y1V6MG9PRjlOaFRuQ0Jhb0tPT0Nmd0NMSHFXdytVY3dN?= =?utf-8?B?SjNWSUxZSjVKRzZsMGJ3d25WQVFaMWM3RlFySHNIdmxqUkZRRVZNb2l6R3o3?= =?utf-8?B?QWxTcS9DNEhzSXlhNmp5Z3lDT2VXV0Yzb2s5NnlTK29LT1RjNm0xYTVQT3dy?= =?utf-8?B?aDFJZFR0UGNDN3Ivcms5a2pybEtYaXpFZ3F4QmI4NUtwaTNHMG9VY0xDNm9P?= =?utf-8?B?UWxMQjJHa2ZtN1BXaDZxT3U5WWx5WVpmZVUyS1ZweWw2RUx3L0xtRHpMNlls?= =?utf-8?B?bVFlblF3NmR2NVltWVdhMDdaOEZ4cWl0NERUbmJCVDkzdHhmQUFEbmRRZG9B?= =?utf-8?B?UFBPKzZLdktxNzkwWFhyR29LaXQ4d3BlUDQyUVBNMDlGRklMNnBCNkxxZk9Q?= =?utf-8?B?UXpreEhlbG1lMlpaUHZaUndFMzNOamo1Zk5xQkdybUR6M0hvTnE0OFlBUWNN?= =?utf-8?B?ekFhOTBJQTdPdWt1blJTeU9ZRTdOMzAxZ1IreEYwOXZaYUhTSi9Mc1ZpTmdX?= =?utf-8?B?RjlrTUtzVXI2dHBqM2NQNGJYeUZHdU9YSzZlaU90MWlYZFNqajdhRGhwZTVp?= =?utf-8?B?VnozdEFBeVR0anJXcCtLWXhmbjZCd2ExZ29yek1HYUVTcHF2anpHdVpCN1JV?= =?utf-8?B?S2lsckhZQXk5L0VkQWNCSis5T3E0K2RPTmh2bXkybnNQeThsRzNzVmw3YVQw?= =?utf-8?B?NXk0U0gwTUFPTFFvcDYwV28yWi9UQjV5STY5SUxpa3V0dGxXUE92ZGNhSTNw?= =?utf-8?B?Qk00dWc5eFJXZ0M0SEEvVTV1NE5Pc0RjWXpybEF3TUt0cUk0WVU2OUZWcVhV?= =?utf-8?B?aE15VWVGbFlXTm9rSkRJaEtNanRlVTZUODZoNERNdzg0S2JDa2tkZ1YrS3FI?= =?utf-8?B?VFp4VUZTVjdnZHpteFluVjVwQW5NZjVvb1Z1YzFNM2p3VEoyc3psMlhuOHhK?= =?utf-8?B?bk1GTmVuNE9UM2U2TXppUGt2eXJoZTJPVHRSRmx4YnZESVpGdlF2QXJXSkJl?= =?utf-8?B?Q1dxNnAzYURWWkp5S2JoT2NMWG9BMi9IMXJic1l5RFFiTU1peWQrR0dwMG9G?= =?utf-8?B?bTViakErU0pWMmluTUJ2Nyt6M3pwOCtDeEdKKytFT3lxTlV4cUJ5d1dheGw5?= =?utf-8?B?c21VeE9EQVZNcE51NzB4N2hBSENvcDByTnpmek5OWlJRbGU1N05pNk15UVRV?= =?utf-8?B?dnBPN2wwdkZzS2tNZE41c3NmdTQxUXVQL2tIY0Q1VFEyN3FWVWtaMFNtL2p2?= =?utf-8?B?VFVGSCs0NDgvU204cmZGbktBVWY2MVpTdW9JV1hpbjVoQm1CaU5KN2s1eEda?= =?utf-8?B?QjJDNVJianJOcy94SWZjZnRkZEhDcFJjSWp2T1l4bEtPQTdIa1dnKzRWTzRk?= =?utf-8?B?TkFSYUh4M1RPaFgxNGp1V01tbTY0M2xvUEFHWExyZWM2V2lJaXViVHZ0b0tz?= =?utf-8?B?aWtmM0VmajhhZ3A5cWxDaG1PUjhGMVFMdWVMN2h5NnI4aStJMlg2QVZzNnlm?= =?utf-8?B?RHI2RDJwOXo1ZUVQUnhBTmcvTWpxYlZSQjlLMENvOHR0TTA3ZEEvS25sQWVH?= =?utf-8?B?ZUIvNG5WQjNnYlgyT3dzY0xDVmxmU0dkUTFmWXQzRllWcTJuQndmTnRmek1t?= =?utf-8?B?NG9sa2dzSGgvbEJRNytubGRwcWRJWVoycEZvNzdONUt1NUQxNnI4MFFoUVNj?= =?utf-8?B?L3RuVlFDbjcxaWtZRm52bDJrWVBlRWtVTzJ1OEkxSDFQdkNtMWVHN3dNdk1s?= =?utf-8?Q?cgzXwG/yrvx9niWTn3usEgmTJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 748093c4-55a0-4f6b-09ec-08db98ee9671 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 15:37:51.6791 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ypHwc34me0MbL56EDR2TX4iKK6N2Q5qZd9npdZJiwhETdHG2mG2GgXPhe0wXuemWCbv19s4Un3zDULbE1DVFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9446 On 01.08.2023 22:20, Daniel P. Smith wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -999,7 +999,7 @@ static void noreturn cf_check svm_do_resume(void) > { > struct vcpu *v = current; > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > - bool debug_state = (v->domain->debugger_attached || > + bool debug_state = (domain_has_cap(v->domain, CAP_DEBUGGER_ATTACH) || > v->domain->arch.monitor.software_breakpoint_enabled || > v->domain->arch.monitor.debug_exception_enabled); Aren't you mixing capability and state here? d->debugger_attached set means a debugger _is_ attached. The capability only says whether a debugger may attach. Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:42:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:42:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581221.909818 (Exim 4.92) (envelope-from ) id 1qTlK1-0001yG-Nv; Wed, 09 Aug 2023 15:42:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581221.909818; Wed, 09 Aug 2023 15:42:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlK1-0001y9-Kx; Wed, 09 Aug 2023 15:42:05 +0000 Received: by outflank-mailman (input) for mailman id 581221; Wed, 09 Aug 2023 15:42:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlK0-0001y3-5b for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 15:42:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20627.outbound.protection.outlook.com [2a01:111:f400:7e1a::627]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 487f7f38-36cb-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 17:42:02 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9446.eurprd04.prod.outlook.com (2603:10a6:102:2b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 15:42:00 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 15:42:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 487f7f38-36cb-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hum0Fvogg6gk4P+QTUGJjJQKt1umYJkYLeOCuz9t0NyI3NTUMXstWYFbhTRdFT4SVL1GwnCscnNBGVKTj15Msa7jGirqc/4qtth+aX0uwhJN0OhQ5osIsnZsbrKaVhF0MopNoIc58E4L+8bhGajGOUjRO+sEv/5sIYTzQaEFvxb4DzcQuPe2GQM4Hj4uL6pXgrTJdtQnw2Fe3yiCgz1KZoo3xe9naFj4bCX4GK28W988N7RKiP2kK2REWiYx9szLEeztYeqS3N7bZz6CYfo6anHYwWkudP56kAlCgGzJDpqwRPjIRpJ7dzenyYns6b828Fgo9Y6Y63J0fIpOhWW4rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ik0Vxf42bfLbG418BKWRN8RzBEH+bI3LVPf5/4jUnGk=; b=b5Leq2PH28Jexj5mP8HBWK+PreMg/aWXiVgxSLynl7iWaE6LiWdZRG9RxkCXFlnlHKyzKQ1uLaDuWOupn70+/d39h7xQwEmFvDcF2YSOPlc37dJDsL4CL3aFqKyRWFDNJjjr4IAi+FX0hbEodzpE9WprKN8amN2iP52s5MQFDHwvYPLM5L/0uV+2urU5/h2709AR19N+i1k6lVpL3YDeZCFxi9O4CZbOsDHunvleh0jYU0p3OyC5EZGViuObdSgGZSH0bvG+gq1GpL4WLyxVbr8GyLhEDPOe/Dp+xL45tdGc3Xidz4TwgxqZTV0E2W6BHpJqIU4/WQv5B0bnwGSPog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ik0Vxf42bfLbG418BKWRN8RzBEH+bI3LVPf5/4jUnGk=; b=vUxjLm5tXNXKuu6at8wEroU2a46Tuf2vCzDAkNE7yWX9mVleIj8ipVALy4RYWnlpR6/ENc41sdsKLsWiz6S3kpqF3cFCwI3raAh/zSoYFWeyn3fL3zdDwfUTYSKnKTw2BI0XjFzBh9e4ER5508oKOmwpdtaopxDKQ058l9+XDGiWKMb+yh2agiFzX1KmWYxbXT2VVYDu44vRo4jMC431KTgM0vDIkrsI8DT8vwKvu5O6qhoRH9kqahH+B2jyZhafh4EKLkXSVhBmiVkrg4UEgpvpyvc13pMIZfti36KyWrw3OjqbXNyDXvn+0bFBpSicMJ1s6G1VapgmN9GsW7Hq4w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83037c3f-ca86-d2bc-d97a-8caee2e18b39@suse.com> Date: Wed, 9 Aug 2023 17:41:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC PATCH 3/5] [WIP]xen/scripts: add codestyle.py script Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-4-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20230728081144.4124309-4-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9446:EE_ X-MS-Office365-Filtering-Correlation-Id: feb7290d-88cb-4cb1-1569-08db98ef2b98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AQh9ohV3OoGz38vRzlL9g1jFcbz08g2ct2h0fNvg1QT18rUAYxhQMx/JtuWF/nS+l0zR1O4E8MeQjUvMICnd2BP4Dx2DS7PUh4ZrSBwKXfHG9MF8lBBo2xKbwjDcUie4krvwWmG8/XjCkiM2oIufUP+dua2yB7CxyM2OygTfv+lvemKHox6HU+MbNjYZkhHlX/f8Gw+ML//oC8baHY9k/qnKq0HdCMDXFeO1XN5qw9E18eTGlDowkeIxq8Q2JUoGBnVHiqW5PI7SMtkZFzFh479qYJnzO9rvGm5dcBdY2Tz8W7cBjDJ9KWDmEEgMxZn16YXIvCKGPeWnmWqcV8MCSrtIlQeSmVx9j0cVventujnuM1xANN79Xk941KjxejvBlZm/ofEzQze6LM7Mwa4IMZjkNQyR8Y9IZeIcpZNElhY65kkCSekPFbjKn+CwJiUzmt5Uj//kZLEstU5GnF2ybKMGE7CG9sdNdt3BtZlfo9L7FQaw++yJv89cu5evo6sypY0sFC3SeIGmbMXDmJIm06IE6w4dFC13/IBLx8+1h2mjZF5apPfBiR8WoAxXs6YaRHblNeTooVRjhP3FBfpegCAJ1q+3icV5/EPkmVLCPLomcUnLgD/QjOhDzug4ok+maa42wG/Kk+85dwwfQwZaqg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(376002)(346002)(366004)(186006)(1800799006)(451199021)(36756003)(478600001)(54906003)(6666004)(66946007)(66556008)(53546011)(6916009)(4326008)(6506007)(66476007)(26005)(6512007)(2906002)(41300700001)(316002)(8936002)(31696002)(4744005)(8676002)(38100700002)(5660300002)(86362001)(2616005)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2w0aFlFZm5JODI2V3NIdTMwazBxdFJUZDNLWitNd2FPSmRGL21nYytFRjJx?= =?utf-8?B?eWxrWWo2T1hFdXQrM0VPemxscVVxcTliU3FUaEVSOENHWE9kMlE5YWk3T041?= =?utf-8?B?U0pndE1DaFdBSGtFNkhPTzEzSGgzSzUvTVFpcTJ0Rmx6b3Bwa3padm9pRXZ0?= =?utf-8?B?bWxnS3dhMkNTaGFsK0UyaVh4cFNPZGJ0OTAwTFY4MWEzL21PUVB0dityVnRv?= =?utf-8?B?b2V1S3BIYzJBMFhOaUVPMlBYYzRBUldzSG96T3RLakNQUmhiTHp1VXpBSHlP?= =?utf-8?B?cUYxSzhPbTI1SW1VcSsrV3dRNmJDUFhDZ3RqdFRTUmVHY3NFUHU3U1Rya1M2?= =?utf-8?B?c3psZWFJTmVJWVBvV0xXdmx4WWVXYThjRjNWekdUUDdYemNDd1dkMW1PQkxV?= =?utf-8?B?clR0TSt6ZDk4M2MrTEU2aTVqcWVvQ2JUVzBVcFBKbzV6anNCOVRQRWFxRFh4?= =?utf-8?B?ZEc0TEpwb2o0dDFzcENlMGpSa1ltYUV5aHVpVUZQYnRkenV4aDRMTmdDeEk5?= =?utf-8?B?QTJ4MG5lV1EycHYwbTNRS0tEQmRLWVFRR2ZFTlkwNnpwS2NxeUJyYTNVeDVQ?= =?utf-8?B?SHVLaFdVL3BuNW5RL1lGSUo2c3RMbWlidXJaZlR1Y3NwUy9OY1poNUVBT0tl?= =?utf-8?B?VXhSTmNpZHpUVml0elJIWDFQb09BU01JWFgyc2lrN2ZPYmxuaERxN2grTTR3?= =?utf-8?B?aUxYTGVVKzVueisvNW9wNXVXZ1VaeTU2UDBXYXVjSndNK2xyYS9ob2Q2NnpF?= =?utf-8?B?V3Jyeko0eDZDN0JwTS82YWYvaGN3bGVtZC95VmxXdTZzcEw1QmdheHVOOUNH?= =?utf-8?B?OFZJVXBHQTJuY21JNTVtTXJzMkxNbndtbU9vMFBEcklsck5FUHdHQ3FBNERO?= =?utf-8?B?Z1dEeUlabjJLeXJRSjAyWmk4eXVudW9FL3g1WFRXVmVDa3ltZjRxZXAyQU5t?= =?utf-8?B?dk9nMGM0c20rbm93bW1oTDk4cnhqamJub2NDTGdsOUdVRFRMdTZ5UlA1dkl0?= =?utf-8?B?UTdrWkdWajE1RkpvNXR2WEJRTXV6aitNSzhtRGNpc0l0Vm5uelZ3WXc4MGhB?= =?utf-8?B?WSt5VHlPWU5KS3JWbTFYSXVSQXQybzM3RmdUMXl1S1RsRXBudDdGazIwd1o5?= =?utf-8?B?WThnWjh1ZUl2UzZvSXM4d2RONlc0QlpTa1ZERkp0V2dVK1NxdklRd1orRUxU?= =?utf-8?B?eGlIbUZIRGdMbUJET1hRbWYvRkJuUFBOZVdkZndOS28wcXhRYWxWTnRNeVZN?= =?utf-8?B?Z2VPV1VQYkNwVm1PYWRjS1RjQVZqMWZQWjV6NnI5VWhYSENzLzdpQ0ZkNG94?= =?utf-8?B?R1Y4M2hFRnN3MXNVUGxhbjRxaUVPTzRmWWpaR3BtYzF1S1B1ZndtRU9wd1di?= =?utf-8?B?bTBEUFNuQlZtV1haUTFpOFMxQXVJQlZZUHlTWDFUTW9hZmMwRmVyR0xuaVlN?= =?utf-8?B?VENSaGtPZFV2d2FSdHNhWmg2OGtnSHdFbGFXc25QZDZIQjAwNDFlQUhBdHc5?= =?utf-8?B?VzRJdDJhZkU2S3N2eTVndG11dmhuVnFtYUY4NWNReGM4dXJmL2N6UDhTbDY1?= =?utf-8?B?aURPSEYrY2RCRnBOTDJLdDY5bG1XNk90RkNyZjNGclZzT2drVGo5NkJMVlNr?= =?utf-8?B?clVDZTh4cEhvc3c2aThISXY5S3hlbWtLZ0h0M09Jd200RmlRNVY4Z0hnM0pr?= =?utf-8?B?U3lQOVRMQUpISTNOZWFwQTJBM3ZSNG5CbXpKZFI5ajBJU1hua2ZNTUxkQ2lM?= =?utf-8?B?S0FuOVNIOW9Eb2pYT0VERHJkNXdYbGZlT1ZPc2drd3RMOElyaU96aUVBLzk5?= =?utf-8?B?SjVtZzdoTTZoWjBzZGJyUWFsUmZNdmtTVHFNRjJuWkpHWFExNy8yaEo4bHlv?= =?utf-8?B?NjNkMnlHUWExTUZ1M3d1dG9JK25oK2ZuQmwwTGRLR0VKY1FxSmg0QTBGWmN2?= =?utf-8?B?VEZ3ZC91S2hRazQydFlKaEdTSEZuL0x4bzB1SHFDdmlhV2lsYWV0Vnpab2xl?= =?utf-8?B?anhYUVJabCtreWpkMjNhTkUxL29TN0JreEE5b2RKTk4vRm1yenRzWWpXaG81?= =?utf-8?B?b1dBMXl6N2ppaHhZTkpPZHd1SHFlallOck93aVRrQUNnNGtOR1B2KzlIbmVt?= =?utf-8?Q?uRAsgC+XURicMUcyDlSJwEcSe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: feb7290d-88cb-4cb1-1569-08db98ef2b98 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 15:42:00.0432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LESpRJtOTcRXfmaziwKYH5srz2IjD5/Oz8NExV5SCmpLtXYwFSy3htAfS42P0xJHNeM+GzFaZEFJFrMupvxwKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9446 On 28.07.2023 10:11, Luca Fancellu wrote: > This script finds every .c and .h file in the xen hypervisor > codebase, takes the exclusion list from docs/misra, removes the > file excluded from the list and for the remaining files is > calling clang-format on them. I was going to ask what the intended purpose is, but looking at the script itself I think I see the script can also be passed a set of file names, so it won't necessarily scan the entire code base. That'll make it more suitable to also be used in an incremental fashion (whether that's also useful to scan patches isn't really clear to me, but I guess that'll require yet more work). Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:48:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:48:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581227.909827 (Exim 4.92) (envelope-from ) id 1qTlQO-0002c5-CI; Wed, 09 Aug 2023 15:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581227.909827; Wed, 09 Aug 2023 15:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlQO-0002by-9W; Wed, 09 Aug 2023 15:48:40 +0000 Received: by outflank-mailman (input) for mailman id 581227; Wed, 09 Aug 2023 15:48:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlQM-0002bs-Uh for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 15:48:38 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [2a01:111:f400:fe0e::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 337e75f1-36cc-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 17:48:36 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM0PR04MB6785.eurprd04.prod.outlook.com (2603:10a6:208:189::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 15:48:33 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Wed, 9 Aug 2023 15:48:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 337e75f1-36cc-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1nDpbAM0pF2HjZONhsNrZ/JgAZh7Vk9bv0CGWGyCQleOPbatpPPDDDPcUPipxx5qwSTKPNnI6VQLZw6LTCNaXgcsLJKSKmrgZrylfW0dEQE0YzAv1bbdzRqwBWHX64Z2y1qZsFoK0vCvuUwSzqpAdpid86ySMEYF2QKbrOwxYndU2rJCOlzo1GssNZ1N0PxVj9gjMPQ4rqNdx7HrFYnIUrBYeRDYkt5gM8Fc7iBwg9ntNCLWfeOC4Wo1KIhqpIp7dL4ITc5C7/lsL1yAj1jcT/Te9bT7ZMX/kyjmr2fm3wIgIxWeciDVkxsXQVQOZ/FKUHEw92Xv1yUg5Kd6xNTBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ymVo+NV60+65k9RHPYq16orj79qnJL1RT/G9okpDYzE=; b=bGhrDUT+uqZLLkRA8T+8repXx7waL9RLK+CBiUQLP7sh8hwjm8wEDIJ2NdMNtTeDjzsJCjiDxPZlEm4Suxgv3qdo8qWgjaYKKchRY2kSJvmJP2kk1aarMksSg9c+qcESCPyn6Q+oRjoa5DxuBLW7a4JGQkY6VnijERsMR2KCLyuQtfaKF4hft23BBzmEpzaZoK4dPGQq9k8JZwim16xD6ZhfLis6FNKjDVeOeeN7VmrYQ7JTJKZ/MQl8Enp4hNhRpNv+IglLZU8VtOik0A7nnJ3CXImD/RRGR09oC8bEd8JQlMKTs2FR2+B6bltP0RovSgBe0qAhuAaVK0XBcjKpJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ymVo+NV60+65k9RHPYq16orj79qnJL1RT/G9okpDYzE=; b=litH3ta3utPXagxim67Z7HmElxWZfZd+7GyWal4Mbezcx6wPca6gIPRcWBRplIckKQHNakqqXHCPDT3XHsGbAF+6kKEcgoQqoMm+uegGDK2CIiVsGpjF420LqYo2OEaV+rwKNiX57GmsT3RK7n+820OJ8/EGBx6PGlu/Ug066VA7XxxhZbEM6ST+XrNr6hcVl7eT1VV1+aiEyubNWitEC9xQqjY9u85gGtaN+I9eNtRF90X95hODphTsncqnQCZmNgfyolueV+PXRTU2KBHk0Svh5Tw1pAgFglCfzoLKbivEMCRq3r0RpEfoUlZL3NiXLx2nS9DvCP+3FMQr1AqtUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c5ae070-d6c2-070c-e482-e5135e2acef1@suse.com> Date: Wed, 9 Aug 2023 17:48:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC PATCH 5/5] xen: Add clang-format configuration Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-6-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20230728081144.4124309-6-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0199.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a5::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM0PR04MB6785:EE_ X-MS-Office365-Filtering-Correlation-Id: f5d4cede-3265-42db-f61a-08db98f0161a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GLyqG3kHqb6iFmpMiMMhPiAAvRgZ2d+4qi/LDx91Nj13dFWTYAv3TB7btunApez4XwP5FgObeHIAegbCyg4LdIC+KBo+8lqwO3vIeZHudfDxXgmKKQqdI0XkIWapIllteZYebFpVreVNv6H/J4YUvq2J2yG9/xEgy45sL7wLh3Eet1Bhv+KF2lxcY8/x0Dt3bOkYl7vGOTGaW90Ca94gllau/HnYnw04kttzxNjL9hxwq4fqfbGnarYkp1QfMUOHUQhLBG9V/kTsK/AzqoNBV++OWSuSDzcPE4GbD7Gfe/GJ+uk/Ucgg8YdY+nUej9dWKYOJr/wf3hKS2u4QzecCIP4W9N0K/d2eJHt5im6AuIZYTZp8nfz4jnZdXI0KHCtHq/PwHqjF0ZbNmp0Rl9Pk4cUhXFewvKF1pRgjqfoRhjRCqJg9bKjkWUFkMe4pATxoIHIeWDnN2Q0N6d+w88vdQBJDFBVoxFbv14bu/if2zuVBSnDBpaTkS2BCFjY8CvPa9SjarWPnxMeOtmPnM0GKI4t1UpGJKgqvtnHUOm+dxu6rm7gM71yWB2tgrnfYgcMoH69pX04M2r0zgSka2wR1qPwgkquq18EMdv9rKJ+i0765Y7BHBwlVUh1AGj5cr1nUcGlkGIG81RBPrViHs7f0lw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(376002)(396003)(366004)(1800799006)(186006)(451199021)(6486002)(478600001)(83380400001)(31686004)(2616005)(966005)(6512007)(26005)(53546011)(6506007)(316002)(66556008)(8936002)(41300700001)(66476007)(8676002)(6916009)(31696002)(2906002)(66946007)(4326008)(36756003)(38100700002)(54906003)(86362001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3VFdVQ2djdOVVlpSU1VSkVRR2srVGp2V0hPejlRcUR2Y054NHhZcVBrdjhB?= =?utf-8?B?Z0dsZCsrZFJEK1hwNWZmQ0ZZWHBmNEQ4M0xETmNuck8reVIwN25hU2dWaG9Z?= =?utf-8?B?WlFxMGJtdTgvSmhXd05Ha1JBKzJ5blludG9nN01TQjhySXB4bmVHRHBBcHMz?= =?utf-8?B?SkNmajlRdUx4ZThUSHplRWE0U25sZE83WldMNmF4T3VCRnJ1M2NKcmVsWVJO?= =?utf-8?B?dDdXWWJHOEQ1Q2pueVdVamxFK0tYcFU0ak84d2Vtb3ZVeHg1eU5Cc0hSMXhN?= =?utf-8?B?b0VnWG9TZHg4L3dvWUFXVk00bXVXQklJV1N4c3ArU0JQYThjY2MzOGZpK1dQ?= =?utf-8?B?YVRMNDY0ek1xZWVyTElTTWFCYm5vTEV6WDV4UmlUSnA3QkRHRDFseGtmMjlv?= =?utf-8?B?dmhlZnMwelVucU11NHY3OXgxQU5uQkpmam4zd21wY3V6WXRQOUE2dEdwQVdE?= =?utf-8?B?R3lZZENmVS85OVByUjhYNXM0ZndRZnB1Qm8vN3EzWnVqayt5eDZaQ3lWeUI4?= =?utf-8?B?b1pDNTFzOWpPQ2pwY2ZoenhJMVhmTnJWRExXN3Jia0N5d3BvbEliRzJrRElR?= =?utf-8?B?V2JEOWtLZ0QyeDhLTlZialU2ZjIzbUxGVGNYZmRYNndwRW5WS3JaWmxZUjBm?= =?utf-8?B?b29Md2k4S1ZEYXlYKytxU0padnZBZXdJaTZRV2ZFbmJnekszZ1g0UU9ITm1a?= =?utf-8?B?N1I2QTlBNXBQOFhDb1I2RW1OL0hwa0pqVVA1aDgyWGwrNWFWODhsRWRiRm5x?= =?utf-8?B?OU5HZmg0UytSRE5OeWVFWDkvQ1pUTk1td25WTDhmUkJPY1Fzc2pEallvS3dz?= =?utf-8?B?NFgwMEd3KytwdXpxTlQ4NUtlVEVtYTVrVFFFMm44UlNsSy9iVXh5VmVRcnJY?= =?utf-8?B?T296ZUw2T0hNUytKWGRZVmRWVzIxek1xM0FkejI4N2R5NTdiaFJSU05PbjRa?= =?utf-8?B?bnBWVElhZDlQZWIxQk1HbEd6QzRhSy9mRDYySFh6bjJvMCtsTnRhL0ZBYWhR?= =?utf-8?B?cjV6VWhBRXk5Z1paV2dLZE9GTjFlUmdML3puUVE0TnhBTEViZjM2aThJQmlv?= =?utf-8?B?cmVtZ2lKOU9BYThqdEZzUUgweHhLcTdySFJtZmk3UFhKNUV1MjdPcytneTZW?= =?utf-8?B?VEJ0d0hGRW5yTEp6NTAxSE9PT290N0lFVFcrOWZnL0RZOWdVcmo4eGpwTytH?= =?utf-8?B?VTVOcmNaaG5KV3NURjBFM2s4V0RqNElSNHdDYjdPMlZzZkg1eVc3RGRsUkFh?= =?utf-8?B?V09vTXlVdUg3bERaV3FwbkxNSFZUdjNTb0ZzMUdWcnJzM1llazArNERaZTdT?= =?utf-8?B?ci9FU3piRXRuWDBDUjF0cE9aTjlOM1p4aHlHZ20reUtuZVk1THdsK3F3SXdw?= =?utf-8?B?UkVBK3JnejkzVDNXdzd1WU03TXV6WHZQUXRCbkI4SWduMHM2T2FHd2tOVkNG?= =?utf-8?B?Z21oamV3ZFpBTTFhSkorYUhhQ1B0cyttanc0VEpJditPMWFmUUpoK1JxZytR?= =?utf-8?B?UHQwc3lPemY2SE1RY1U5cVFjakdlY1p3VEozQnNIQVg2aGQzL3dnZ1o4ek1H?= =?utf-8?B?b0s0cTRMbWNMZVFnMUhGN09oTWx4NlkzdE4rM29JMGQxY3haQmNTUUxRanRC?= =?utf-8?B?d3FNZFNOQVBadnJ5c3lkdE9kaE5qLy9hN21uVUJZSEpVai9qcWVBNVIxeHIz?= =?utf-8?B?SzN0Y05yNXZKZVltckc1NjZ4M3VwMDdPZGF2SHFRRzJYRHAwTDJmOXZndXFh?= =?utf-8?B?VmV3bkEzeG03TWVDb1QwRGlWazgyWDF5Z3hxSStMM3o1WCtaTVdnazBNT1JL?= =?utf-8?B?MGJ2TUxzYnhVS0M1a3pKbUo4bmpXNHBDMmJiRHQ0anNBT0tQWk1RT3BlbGo2?= =?utf-8?B?V0JlZW1MT3NkS0k4b3V1VCt1RXgyaGRhYUF2YXkxRHUza1pkc3UzdmYvMTMr?= =?utf-8?B?VzhhNEkreVUrbWNYV28yMEtyZU8xTlp4ZVgzRlZRWklyeDMya0Y3Z1lPYkZF?= =?utf-8?B?NExnblppZnN5ZDkwUGVkSDQ5dWFDa2tHeUptK1JtTks3WnZZUXZJWDcyVm9r?= =?utf-8?B?cDNTbmEwVHRuR2d4MTFGNFg0WncxMklCdURWNmU0NWtUaS9QT0NMTTZGWEFp?= =?utf-8?Q?psatw7E3O2mw2tdz5/s4FXGsC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5d4cede-3265-42db-f61a-08db98f0161a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 15:48:33.4871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vYvqtUOPgcaNlyCqmIbWlcKhDwYJCdLcUIs8Cm3eLAhxTn2wS9F2zER7Y4yGdk6E4bY07VQLhjE0LwMzvqyZyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6785 On 28.07.2023 10:11, Luca Fancellu wrote: > --- /dev/null > +++ b/xen/.clang-format > @@ -0,0 +1,693 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# clang-format configuration file. Intended for clang-format >= 15. > +# > +# For more information, see: > +# > +# Documentation/process/clang-format.rst > +# https://clang.llvm.org/docs/ClangFormat.html > +# https://clang.llvm.org/docs/ClangFormatStyleOptions.html > +# > +--- > + > +# [not specified] > +# Align function parameter that goes into a new line, under the open bracket > +# (supported in clang-format 3.8) > +AlignAfterOpenBracket: Align I'm not convinced this rule (assuming I'm getting it right) is suitable in all cases, especially for functions with long names or very many parameters. > +# [not specified] > +# Align array of struct's elements by column and justify > +# struct test demo[] = > +# { > +# {56, 23, "hello"}, > +# {-1, 93463, "world"}, > +# {7, 5, "!!" } > +# }; I'm pretty sure we want to have blanks immediately inside the braces. > +# (supported in clang-format 13) > +AlignArrayOfStructures: Left > + > +# [not specified] > +# Align consecutive assignments (supported in clang-format 3.8) > +AlignConsecutiveAssignments: > + Enabled: true > + AcrossEmptyLines: true > + AcrossComments: false This is something we want to permit, but not demand, I think. I'm also unconvinced we want it across empty lines. > +# [not specified] > +# Do not align consecutive bit fields (supported in clang-format 11) > +AlignConsecutiveBitFields: None > + > +# [not specified] > +# Do not align values of consecutive declarations > +# (supported in clang-format 3.8) > +AlignConsecutiveDeclarations: None > + > +# [not specified] > +# Align values of consecutive macros (supported in clang-format 9) > +AlignConsecutiveMacros: > + Enabled: true > + AcrossEmptyLines: true > + AcrossComments: true This also looks to aggressive to me. And I guess I'll stop here. What is the plan wrt discussing which aspects we want to require and which we want to permit but not require? Or is there alternatively a way to leave unconfigured (and hence unaltered) anything that's not already spelled out in ./CODING_STYLE? Jan From xen-devel-bounces@lists.xenproject.org Wed Aug 09 15:49:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 15:49:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581230.909838 (Exim 4.92) (envelope-from ) id 1qTlQx-00035p-Kv; Wed, 09 Aug 2023 15:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581230.909838; Wed, 09 Aug 2023 15:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlQx-00035i-IE; Wed, 09 Aug 2023 15:49:15 +0000 Received: by outflank-mailman (input) for mailman id 581230; Wed, 09 Aug 2023 15:49:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTlQx-00030I-1I for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 15:49:15 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20604.outbound.protection.outlook.com [2a01:111:f400:7eaf::604]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 499a3d2e-36cc-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 17:49:13 +0200 (CEST) Received: from AS9PR01CA0007.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::12) by AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 15:49:10 +0000 Received: from AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::79) by AS9PR01CA0007.outlook.office365.com (2603:10a6:20b:540::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Wed, 9 Aug 2023 15:49:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT065.mail.protection.outlook.com (100.127.140.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 15:49:09 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Wed, 09 Aug 2023 15:49:09 +0000 Received: from a88308185d2d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ADB9FFB5-D9EC-4B0D-84FB-3CB4F75619B4.1; Wed, 09 Aug 2023 15:48:36 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a88308185d2d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 15:48:36 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by GV2PR08MB8703.eurprd08.prod.outlook.com (2603:10a6:150:b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Wed, 9 Aug 2023 15:48:30 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 15:48:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 499a3d2e-36cc-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zanEG82qDmobUBI5W3jSbksF1KslhpUDpD/Iplyhyls=; b=DdgJxPfXgW9k2JKfVMKcBMHXDxagNyFaNSijMZYLaCPCppCOUAmxApFaxepIjxWRQPT+xqCjxRzBcwZR05BdTY39bIl9vmcrictGFBRtD3jQ0TlHQmFpH3hb8J9hJe8fB4DK5RrWHRgv07ZLNZBcJWkzVk2NFkGGmUyTAEKe9Gc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b1d30bafb02a4ad8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AUVH0J6Cb+dFrQTsQ2Z16ZJLiGbQjVSKcPrIUVfPH39fVHNHdM5YLtRv6pBsnxHXvFqW6eomoRQnYKTuDAFDuVTEnNqAl3yzbL8f6diczyW/hVa7gL+fQ2QTOQ6SRi/apifz7xmvQvyG0dXcpJrRee565A3QAlbQu0gZrLoBApiOn7tqUagqk1+16ym7LbG2TpEpDxGstaofw8X5oap7VTWI0rNpkrjl4SfQi7VnN7KfASmk+TCS/bFRotABlZ/s2yYYzMwWw92Go7QERPVc+pinJPbvcTBTTfyB3huyq8xa6u/qUZac6Dfi0nwsPk3b4jd9rYMobllpqn/ef1bV0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zanEG82qDmobUBI5W3jSbksF1KslhpUDpD/Iplyhyls=; b=VLBUSYQpmGeHg1uQT7YRk73izw3qUxbB9klhtmP05gGpwmlklzYwuDf7saB4CDnCDxqtPp62VaZjC78Ta8gu9/WbsuEI6NKkpvjoL2ZayDrv3w1hXkTWyYjAw9UZqZzUw9vn/F4zRn6okTrhRH6dizIAb7rb87tpVTZBkmNxRKPaIPj+Jsg7n6Qa9fSUK/88GOd7q4lmdobxvnGaJZc+3pseSjcU8gdHWbWi6NLsyDk6BusjxjOeE2jSp0u5/KzJ2ejElmlasz5VF2mTCK3Di86DnbYtzswH2RiRDg9vM2xWFeq5MysTNzQLuQs+qw40flM/3k5KvrGC9JIKIIjaJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zanEG82qDmobUBI5W3jSbksF1KslhpUDpD/Iplyhyls=; b=DdgJxPfXgW9k2JKfVMKcBMHXDxagNyFaNSijMZYLaCPCppCOUAmxApFaxepIjxWRQPT+xqCjxRzBcwZR05BdTY39bIl9vmcrictGFBRtD3jQ0TlHQmFpH3hb8J9hJe8fB4DK5RrWHRgv07ZLNZBcJWkzVk2NFkGGmUyTAEKe9Gc= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 3/5] [WIP]xen/scripts: add codestyle.py script Thread-Topic: [RFC PATCH 3/5] [WIP]xen/scripts: add codestyle.py script Thread-Index: AQHZwStACZga8Y9XdUKITC8YuHP7fa/iLbiAgAABx4A= Date: Wed, 9 Aug 2023 15:48:30 +0000 Message-ID: References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-4-luca.fancellu@arm.com> <83037c3f-ca86-d2bc-d97a-8caee2e18b39@suse.com> In-Reply-To: <83037c3f-ca86-d2bc-d97a-8caee2e18b39@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|GV2PR08MB8703:EE_|AM7EUR03FT065:EE_|AS8PR08MB7696:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f99dc7b-2d26-43b4-7799-08db98f02bb1 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 57RENYwjndGgRECmr/EgPwUfbYVTjnUAE6FLVxmm2K9fMGw8Q41/TB5ymsE/xeKGGvR9MK6NeRZSVBJiucfLkJOxQU4Ula6YR+YoqyoG7QGDRbLuV901Ig5Up74qmTjMH120lmWllpV6LRrNj9fCL6qy4RuYVHhsykWPSNHbbwdDDL24fklzDmNAm9uN6Ik5dE10kA/w4lFvl+/vMz5B5A5lh4p3w9/0x3vXXXe3FLU4wz/hlu/KG5pTFTX3/+LvIPqg+fhETSjXDqoFrg8mfqPHStf0Djmjr6Wrn6D+m0KExR6MyWE4tsI7py8HUXG8q35ZeiHa7PPWOwx75GSwYjuiYy/eaIFrvnjMQbSEQ33xGyiVH3x6U7NY8fEGSk2xmWP7YYaYPvqo1Vu7LNmtzrtsJPTLtGz7cLPOVbBswzQ8AzX+K43Tovht5Ug62sPzwyo+0PfxpZAJ9hM7QqvmBpASVbmoUsVtqAy2nLzGod7fbDGzcO5+KtwjAQdnB6YTAHJEjPU0qW8WRXwzK4hfPbgZOmUL4vzE0zPuVf+RgfT3GmsA4uZyWRBaMo3XCNeCq1DRkS8YYAG6PJqSdzamRoY+XH7paPJFREVXprigx//M1lNMKTsJRcx/p0WzSPZiyHZ7iSRFujt0n1b0nXVOaQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(136003)(376002)(396003)(39860400002)(186006)(1800799006)(451199021)(2616005)(122000001)(478600001)(6486002)(6512007)(53546011)(6506007)(26005)(8936002)(33656002)(66476007)(66556008)(76116006)(8676002)(36756003)(4326008)(6916009)(66446008)(41300700001)(2906002)(66946007)(71200400001)(64756008)(54906003)(38100700002)(316002)(86362001)(91956017)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3DCA4330DFAC0642BEED840B6AF2D93B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8703 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b5022bc0-3455-40a8-cd6f-08db98f01462 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ljwgbVW2zFqjA93zqY9+HHOxFI+V8woW6Ed2JeFwaNVk0yNKc6wTJSCvoDMrmBGvpAQpl9Im56o44IdwY3LpYprpX4KwCjqs3s85CwOTtstVkIZAGDaZQk1YugrZ3VKvhzXrmRmFSu7qSHguwDty3lnBpaUwlAfZRdUqGRnRneQPRDPMAC699omW6jzkia6R5qNYXds6XL/O/wCfxO7Veo0iMueiO4KOWzzOLFhBnlxnEEY+/9PMz6qqp+mqjSs8OvpC8xGhZMdwM5YyOVVMzZo8qmOmq+0v8bifEAqtoKmhiK/uYI2NKwFIxmkpYWkAK0ZuXnsd3Eb7SuIlHaGUo9FNb9sWT7/dc08CwU+nu/vbZk2Uo2LhdL3JMcthTNpu9qZemraXjfXqjq6AK+DTvRgVHZhue9kEOpJ1tazPn1cEFuWHnGfjd2UZzAqT/FuUbsqkKIfK7/xK1lv4GJzFjCkTSAOqw/en0Bz5zdDhW2+OCCU4Qk2L32BjB8i4ikxDcKnXtwhFyg6aE6aFSopmJUpP3ITYqbP8d+DtOTP5Pv7tIjOP35k09gAgSksZTiyiwPcCs1sNn8mJpe4dmSbkXKtyT39G4ykqoAUYBDHTSIH09gR0WhFDp/HX0OcVj802KJJY/XBxRbkOrxerpup/jH3xfHTh01GEtlRPs/5ZSHFFuwWvxW0giECi61sxNYYwJBSxI91YqTYuv4PVvoY/5CmqpTQ8vRhnhGWqXTX9VNJK1hCu2z85ffKZcJBojNDp X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199021)(82310400008)(1800799006)(186006)(46966006)(36840700001)(40470700004)(6862004)(40480700001)(8676002)(5660300002)(8936002)(81166007)(356005)(82740400003)(2906002)(40460700003)(2616005)(86362001)(6486002)(478600001)(54906003)(6506007)(26005)(53546011)(36756003)(336012)(6512007)(33656002)(36860700001)(4326008)(41300700001)(316002)(47076005)(70586007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 15:49:09.5048 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f99dc7b-2d26-43b4-7799-08db98f02bb1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT065.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7696 > On 9 Aug 2023, at 16:41, Jan Beulich wrote: >=20 > On 28.07.2023 10:11, Luca Fancellu wrote: >> This script finds every .c and .h file in the xen hypervisor >> codebase, takes the exclusion list from docs/misra, removes the >> file excluded from the list and for the remaining files is >> calling clang-format on them. >=20 > I was going to ask what the intended purpose is, but looking at the > script itself I think I see the script can also be passed a set of > file names, so it won't necessarily scan the entire code base. > That'll make it more suitable to also be used in an incremental > fashion (whether that's also useful to scan patches isn't really > clear to me, but I guess that'll require yet more work). Yes, when we will do some automation, it would be useful to just run the sc= ript against the touched files from a patch. Indeed running it against the patch file is very difficult, since we are do= ing some pre-process and post-process that requires some context that might be missi= ng from the code inside the patch. Cheers, Luca From xen-devel-bounces@lists.xenproject.org Wed Aug 09 16:18:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 16:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581240.909849 (Exim 4.92) (envelope-from ) id 1qTltZ-0007FG-2P; Wed, 09 Aug 2023 16:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581240.909849; Wed, 09 Aug 2023 16:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTltY-0007F9-Tp; Wed, 09 Aug 2023 16:18:48 +0000 Received: by outflank-mailman (input) for mailman id 581240; Wed, 09 Aug 2023 16:18:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTltX-0007F3-HH for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 16:18:47 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20613.outbound.protection.outlook.com [2a01:111:f400:7d00::613]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a4a774f-36d0-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 18:18:46 +0200 (CEST) Received: from AS9PR06CA0289.eurprd06.prod.outlook.com (2603:10a6:20b:45a::29) by AS1PR08MB7498.eurprd08.prod.outlook.com (2603:10a6:20b:4dd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.25; Wed, 9 Aug 2023 16:18:33 +0000 Received: from AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::a5) by AS9PR06CA0289.outlook.office365.com (2603:10a6:20b:45a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Wed, 9 Aug 2023 16:18:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT016.mail.protection.outlook.com (100.127.140.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Wed, 9 Aug 2023 16:18:33 +0000 Received: ("Tessian outbound 997ae1cc9f47:v145"); Wed, 09 Aug 2023 16:18:33 +0000 Received: from 448e72feccd5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17C8ED21-55F3-4C61-98AF-51110E4E3489.1; Wed, 09 Aug 2023 16:18:03 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 448e72feccd5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Aug 2023 16:18:03 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM8PR08MB6323.eurprd08.prod.outlook.com (2603:10a6:20b:354::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 16:18:01 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 16:18:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a4a774f-36d0-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBKXN+jwBubVhY7AIfbvFgtfcMtXef2QqdlWUYThVzc=; b=dAe8H4k7TFJRnkbzkeysJ7VjxvCTGOijEjKJ4YNtqd7rWxjqCpofgtoOJsteFiiGMAWO0iqY+rjq70zA4wXWQuhElJNhNNIf4/pnG3D8jQUSP2H7wEpJ7M5qSDp1tuOcprbf7xwrRAh4g6uQA9eYfs8iQitoRmj7dsq6JfmNiCY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9aa6245a2abd8fba X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=brXqi8EaHCOVHlaj0BqHIhaGvlqs1zD25l+ZILj/aQJc7pdWI5Yzx8dHGVArvNZNm69m0Y526lz7XdLp+lBidG+ohDZr/mS5GZYdUqLNThvF0t+Tm4WBh9UFGeav1hk4LvCRZQoUo9aOJwQMrJ9KSgxErJv7OzUNrIOuF7D4bT8DpXc1zY4S+5d3jhgN2cGqf/YHJJwX9aHxu6dxkni9K3mjXSmoyTb64omzKCfs1AzxlP36335M7sKd6J9qsh5zi43bE2xoKYd4HoeIvEy/486ys6ePucpU6ROXNSMGQoJYlzk3Z4Uebo+BB3bT0HB8bK+88gyD/DjvSycT4bKMpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zBKXN+jwBubVhY7AIfbvFgtfcMtXef2QqdlWUYThVzc=; b=Um+4Z65No66MTWsK34U4U5s9d+1aXUmv0S885h64bbCyQOA+tLOJd8Q4mW9MOT9T1mgiJvVYVUSXE3HnYtj/+srSX9VO/7gekqTiogND/qPiiAPYGR8M/iKMJFM/xQI6Jha1GjV+wRA36MhV+9sqEuDoGFmTENjwgP1fqtyLev1NzL3O5CPWhkramO+hwMlU4VbbDMQ3ujIpJyIfLSTjvbv9fJWXiwL9Hpg6JJLmeZ5RJf2S0GXSA8OP4Rw86VifFG13cnrM/PYaKQYfEs635LTsj9BlOnV2qrnQVT8n52laO5RCFlgJN5Djh2zDrWhhQM7mGBc4vmJQueLbJZDAKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBKXN+jwBubVhY7AIfbvFgtfcMtXef2QqdlWUYThVzc=; b=dAe8H4k7TFJRnkbzkeysJ7VjxvCTGOijEjKJ4YNtqd7rWxjqCpofgtoOJsteFiiGMAWO0iqY+rjq70zA4wXWQuhElJNhNNIf4/pnG3D8jQUSP2H7wEpJ7M5qSDp1tuOcprbf7xwrRAh4g6uQA9eYfs8iQitoRmj7dsq6JfmNiCY= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 5/5] xen: Add clang-format configuration Thread-Topic: [RFC PATCH 5/5] xen: Add clang-format configuration Thread-Index: AQHZwStJjnl5s/6RqkyuxqTMVBpDCK/iL4wAgAAIMgA= Date: Wed, 9 Aug 2023 16:18:01 +0000 Message-ID: <394778DB-2D5E-4C52-9DA1-F23A530534A8@arm.com> References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-6-luca.fancellu@arm.com> <3c5ae070-d6c2-070c-e482-e5135e2acef1@suse.com> In-Reply-To: <3c5ae070-d6c2-070c-e482-e5135e2acef1@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM8PR08MB6323:EE_|AM7EUR03FT016:EE_|AS1PR08MB7498:EE_ X-MS-Office365-Filtering-Correlation-Id: ed24b110-62b8-4d47-130f-08db98f44711 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wwQoxNmZ/wsYv6swXzB2O0YhRX6CEaAaKuO0okfmtYFXKHvZEQBIIjpIDOPN/HZlpnfHSogB3wSjVpYQBTEvpcL/NKY/CPX6ue8hAxuWf0+WQi7C0WfL2j+bp9zIpHihM403eRxr2A186rSzsnAx5ArxlH70b66kcYKwJ5Fqj0YsxFQWCAZRaK9e/xkSjc9ZDec1fX/6B62BWPHcPNJSGB4hz94AYb24BpphIHPh3xg9ZDWNuLQ85ajDT1eIyUspdIT1k2F2j9bIdAza0/5o9og/+rtsorpjPepTZ+CVcH5w8cEwyRH7gRk6CfSKeGXT6Wmzs6wjXKSMJA13FYzVVrRRVYCgDZQeKNhrD9grNeDRUtpEMIqxnXCJAroIttSXTsQDLje4G/pN70BokT7OiaN5xph1dot24zZqHSdhalL19coJPipQdOXASz9325ft6T5n+lTgdWclyjWPbL9hrp4Niill5tOsfW2RukS70GQOix+7mZwnZkZ43WcomLqeU7uHg9JWmt+LF0SfGoD6CZ38KGoTWAkoQdG1ahapW2SWldBv+EzXH3BuPq6l6Fkbdi+uwmoWdI00zeEBlbKlh+Oc1MSF8sOx4IRWB9WWLQr6j8AhYQX8FLe7LanP7OEMVoZpmni265VaFSGCpQO05D8dk1YDW73NLo/ugIMvyvH0Tt99mKMcL9+6GcgVxxtD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(376002)(346002)(396003)(366004)(186006)(1800799006)(451199021)(83380400001)(122000001)(478600001)(2616005)(966005)(6512007)(26005)(53546011)(6506007)(41300700001)(8936002)(91956017)(76116006)(66446008)(66946007)(66476007)(66556008)(64756008)(316002)(8676002)(4326008)(2906002)(6916009)(6486002)(71200400001)(36756003)(38100700002)(54906003)(33656002)(86362001)(38070700005)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <5005D73431EAA045A9E6054B8F29C89B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6323 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8958d084-61c9-4ed7-56dd-08db98f433da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WFGDDfEMgXdeyn3ajOvrhglJWZVQmrTnsXyDdLL1TVTx4D2UW4SlBuOmVvvr6XMDo3SJl2xx7VfAjQjgIxkp8OBik3CqDT7IGtxaXl719aruX6ThQROdB3Ham/SkofByaNAH2prJw7YL7H0cYqrQJ3NkZjkcILRs9jTEy8ACuI8GMgtP0cUh9B5uUMSsr4vcvFnkYxVlP1LNxj/oKN7ftDb90ra8m5ciRnxfPAaNraAS6wb2o4ht8pj0BfEr/tjA/OVVPk0Ji/vwfF7r+fS47+xsf2b/FBJgvsH1VZCPxEz9Nb23HwN6Yv1EaGsWRM60n4KnXhIPxPOGaZieGj0BuuwM7JjSM1bc4gRmg7f8qUNSe6XC8K0jBFrG3vl0ngYCI09nJPFqmNKbYVa1oNo6JuKQ8g9B3MDt3IaPvNqqDs1y+0XvTzVP3WIQ4CeelNn5fUhSnnRtN86sbm+Zoz7APpDRUwyG/IX9kvOw2kkge28OOfJeoiQz9okdhijtnBlekHPszuMHzv/x/t2Qt878O3zDW3pVZ7xIK9TGa92cTuNP9drnqhGc0Lv63kLORL6mvH5pwJlIm2YxdDXrvd625RZT3qV5AKzFD7XUlWTGld7X+BBuecexbtDdLpRJp5egtOHAd8sx7KYFHIsNR8rrOvFxHJcshT238kgXv2gPdqrRqcfWR3Qt18u1utaZ+1Lzk+5DnENFPRf3jaKqgknGBSrw1MM1OtVU29KXCLWVn9W4f1YD2nwZbhB9T7wgv23+7Lk8QxSHHDdCIzdcl/L20Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(39860400002)(376002)(82310400008)(451199021)(186006)(1800799006)(36840700001)(40470700004)(46966006)(6512007)(966005)(6506007)(53546011)(26005)(40480700001)(40460700003)(36756003)(54906003)(86362001)(5660300002)(8676002)(2906002)(316002)(41300700001)(70586007)(33656002)(70206006)(8936002)(6862004)(4326008)(478600001)(356005)(81166007)(82740400003)(2616005)(47076005)(36860700001)(6486002)(83380400001)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 16:18:33.4175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ed24b110-62b8-4d47-130f-08db98f44711 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7498 DQoNCj4gT24gOSBBdWcgMjAyMywgYXQgMTY6NDgsIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAyOC4wNy4yMDIzIDEwOjExLCBMdWNhIEZhbmNlbGx1IHdy b3RlOg0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIveGVuLy5jbGFuZy1mb3JtYXQNCj4+IEBA IC0wLDAgKzEsNjkzIEBADQo+PiArIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1v bmx5DQo+PiArIw0KPj4gKyMgY2xhbmctZm9ybWF0IGNvbmZpZ3VyYXRpb24gZmlsZS4gSW50ZW5k ZWQgZm9yIGNsYW5nLWZvcm1hdCA+PSAxNS4NCj4+ICsjDQo+PiArIyBGb3IgbW9yZSBpbmZvcm1h dGlvbiwgc2VlOg0KPj4gKyMNCj4+ICsjICAgRG9jdW1lbnRhdGlvbi9wcm9jZXNzL2NsYW5nLWZv cm1hdC5yc3QNCj4+ICsjICAgaHR0cHM6Ly9jbGFuZy5sbHZtLm9yZy9kb2NzL0NsYW5nRm9ybWF0 Lmh0bWwNCj4+ICsjICAgaHR0cHM6Ly9jbGFuZy5sbHZtLm9yZy9kb2NzL0NsYW5nRm9ybWF0U3R5 bGVPcHRpb25zLmh0bWwNCj4+ICsjDQo+PiArLS0tDQo+PiArDQo+PiArIyBbbm90IHNwZWNpZmll ZF0NCj4+ICsjIEFsaWduIGZ1bmN0aW9uIHBhcmFtZXRlciB0aGF0IGdvZXMgaW50byBhIG5ldyBs aW5lLCB1bmRlciB0aGUgb3BlbiBicmFja2V0DQo+PiArIyAoc3VwcG9ydGVkIGluIGNsYW5nLWZv cm1hdCAzLjgpDQo+PiArQWxpZ25BZnRlck9wZW5CcmFja2V0OiBBbGlnbg0KPiANCj4gSSdtIG5v dCBjb252aW5jZWQgdGhpcyBydWxlIChhc3N1bWluZyBJJ20gZ2V0dGluZyBpdCByaWdodCkgaXMN Cj4gc3VpdGFibGUgaW4gYWxsIGNhc2VzLCBlc3BlY2lhbGx5IGZvciBmdW5jdGlvbnMgd2l0aCBs b25nIG5hbWVzIG9yDQo+IHZlcnkgbWFueSBwYXJhbWV0ZXJzLg0KDQpOb3Qgc3VyZSBJIHVuZGVy c3RhbmQsIEkgdGhpbmsgdGhpcyBpcyB0aGUgY3VycmVudCBiZWhhdmlvdXIgaW4gdGhlIGNvZGVi YXNlIG5vdy4NCg0KPiANCj4+ICsjIFtub3Qgc3BlY2lmaWVkXQ0KPj4gKyMgQWxpZ24gYXJyYXkg b2Ygc3RydWN0J3MgZWxlbWVudHMgYnkgY29sdW1uIGFuZCBqdXN0aWZ5DQo+PiArIyBzdHJ1Y3Qg dGVzdCBkZW1vW10gPQ0KPj4gKyMgew0KPj4gKyMgICAgIHs1NiwgMjMsICAgICJoZWxsbyJ9LA0K Pj4gKyMgICAgIHstMSwgOTM0NjMsICJ3b3JsZCJ9LA0KPj4gKyMgICAgIHs3LCAgNSwgICAgICIh ISIgICB9DQo+PiArIyB9Ow0KPiANCj4gSSdtIHByZXR0eSBzdXJlIHdlIHdhbnQgdG8gaGF2ZSBi bGFua3MgaW1tZWRpYXRlbHkgaW5zaWRlIHRoZSBicmFjZXMuDQoNCm9rDQoNCj4gDQo+PiArIyAo c3VwcG9ydGVkIGluIGNsYW5nLWZvcm1hdCAxMykNCj4+ICtBbGlnbkFycmF5T2ZTdHJ1Y3R1cmVz OiBMZWZ0DQo+PiArDQo+PiArIyBbbm90IHNwZWNpZmllZF0NCj4+ICsjIEFsaWduIGNvbnNlY3V0 aXZlIGFzc2lnbm1lbnRzIChzdXBwb3J0ZWQgaW4gY2xhbmctZm9ybWF0IDMuOCkNCj4+ICtBbGln bkNvbnNlY3V0aXZlQXNzaWdubWVudHM6DQo+PiArICBFbmFibGVkOiB0cnVlDQo+PiArICBBY3Jv c3NFbXB0eUxpbmVzOiB0cnVlDQo+PiArICBBY3Jvc3NDb21tZW50czogZmFsc2UNCj4gDQo+IFRo aXMgaXMgc29tZXRoaW5nIHdlIHdhbnQgdG8gcGVybWl0LCBidXQgbm90IGRlbWFuZCwgSSB0aGlu ay4gSSdtIGFsc28NCj4gdW5jb252aW5jZWQgd2Ugd2FudCBpdCBhY3Jvc3MgZW1wdHkgbGluZXMu DQoNClRoaXMgd2FzIHBvaW50ZWQgb3V0IGJ5IEFsZWphbmRybyBhbmQgU3RlZmFubywgd2UgY2Fu IGRpc2FibGUgdGhpcyBieQ0KcGFzc2luZyAnTm9uZScNCg0KPiANCj4+ICsjIFtub3Qgc3BlY2lm aWVkXQ0KPj4gKyMgRG8gbm90IGFsaWduIGNvbnNlY3V0aXZlIGJpdCBmaWVsZHMgKHN1cHBvcnRl ZCBpbiBjbGFuZy1mb3JtYXQgMTEpDQo+PiArQWxpZ25Db25zZWN1dGl2ZUJpdEZpZWxkczogTm9u ZQ0KPj4gKw0KPj4gKyMgW25vdCBzcGVjaWZpZWRdDQo+PiArIyBEbyBub3QgYWxpZ24gdmFsdWVz IG9mIGNvbnNlY3V0aXZlIGRlY2xhcmF0aW9ucw0KPj4gKyMgKHN1cHBvcnRlZCBpbiBjbGFuZy1m b3JtYXQgMy44KQ0KPj4gK0FsaWduQ29uc2VjdXRpdmVEZWNsYXJhdGlvbnM6IE5vbmUNCj4+ICsN Cj4+ICsjIFtub3Qgc3BlY2lmaWVkXQ0KPj4gKyMgQWxpZ24gdmFsdWVzIG9mIGNvbnNlY3V0aXZl IG1hY3JvcyAoc3VwcG9ydGVkIGluIGNsYW5nLWZvcm1hdCA5KQ0KPj4gK0FsaWduQ29uc2VjdXRp dmVNYWNyb3M6DQo+PiArICBFbmFibGVkOiB0cnVlDQo+PiArICBBY3Jvc3NFbXB0eUxpbmVzOiB0 cnVlDQo+PiArICBBY3Jvc3NDb21tZW50czogdHJ1ZQ0KPiANCj4gVGhpcyBhbHNvIGxvb2tzIHRv IGFnZ3Jlc3NpdmUgdG8gbWUuDQoNCkl0IGNhbiBiZSwgYnV0IGl0IGNhbiBsZWFkIHRvIGEgbmlj ZSBmb3JtYXQuIEFueXdheSBjYW4gYmUgY3VzdG9taXNlZC4NCg0KPiANCj4gQW5kIEkgZ3Vlc3Mg SSdsbCBzdG9wIGhlcmUuIFdoYXQgaXMgdGhlIHBsYW4gd3J0IGRpc2N1c3Npbmcgd2hpY2gNCj4g YXNwZWN0cyB3ZSB3YW50IHRvIHJlcXVpcmUgYW5kIHdoaWNoIHdlIHdhbnQgdG8gcGVybWl0IGJ1 dCBub3QNCj4gcmVxdWlyZT8gT3IgaXMgdGhlcmUgYWx0ZXJuYXRpdmVseSBhIHdheSB0byBsZWF2 ZSB1bmNvbmZpZ3VyZWQNCj4gKGFuZCBoZW5jZSB1bmFsdGVyZWQpIGFueXRoaW5nIHRoYXQncyBu b3QgYWxyZWFkeSBzcGVsbGVkIG91dCBpbg0KPiAuL0NPRElOR19TVFlMRT8NCg0KSSB0aGluayBJ IGRpZCBjcmVhdGUgYSBjb25maWd1cmF0aW9uIHNwZWNpZnlpbmcgb25seSB3aGF0IHdhcyBzcGVs bGVkIG91dA0KaW4gQ09ESU5HX1NUWUxFLCBidXQgaXQgd2FzIG5vdCByZWFsbHkgc3VjY2Vzc2Z1 bCBhbmQgbGVkIHRvIG1hbnkgY2hhbmdlcywNCm1vcmUgdGhhbiBub3cuDQoNCkkgdGhpbmsgd2Ug bmVlZCB0byBjb2xsZWN0IG1haW50YWluZXJzIHZpZXcgb24gZXZlcnkgW25vdCBzcGVjaWZpZWRd IGNvbmZpZ3VyYWJsZQ0KYW5kIHNlZSB3aGljaCBvbmUgYXJlIGFncmVlZCBieSB0aGUgbWFqb3Jp dHksIGFuZCB3aGljaCBvbmUgYXJlIG1vcmUgY29udHJvdmVyc2lhbC4NCg0KSeKAmXZlIHB1c2hl ZCB0aGlzIHNlcmllIGFsc28gdG8gbWFrZSB0aGUgY29tbXVuaXR5IGFibGUgdG8gc2VlIHRoZSBv dXRwdXQgYW5kIHJhaXNlDQppc3N1ZXMgb3IgYmVoYXZpb3VyIHRoYXQgYXJlIG5vdCByaWdodCwg dG8gc2VlIGlmIHdlIGNhbiBkbyBzb21ldGhpbmcgb3IgaWYgdGhlcmUgaXMgbm8NCmFncmVlbWVu dCBhbmQgdGhlIHRvb2wgd291bGQgYmUgcHV0IG9uIGhvbGQuDQoNCkFueXdheSBJ4oCZbSBhd2Fy ZSB0aGF0IHdlIGFyZSBnb2luZyBpbnRvIGEgcGVyaW9kIHRoYXQgd2lsbCBiZSBwcmV0dHkgYnVz eSBiZXR3ZWVuDQphbm51YWwgbGVhdmVzIGFuZCB0aGUgcmVsZWFzZSwgc28gSeKAmW0gb2sgdG8g cGluZyB0aGlzIGRpc2N1c3Npb24gYWZ0ZXIgdGhlIHJlbGVhc2UuDQoNCkNoZWVycywNCkx1Y2EN Cg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Aug 09 17:06:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 17:06:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581246.909857 (Exim 4.92) (envelope-from ) id 1qTmd1-0004Jd-GK; Wed, 09 Aug 2023 17:05:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581246.909857; Wed, 09 Aug 2023 17:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTmd1-0004JW-Dl; Wed, 09 Aug 2023 17:05:47 +0000 Received: by outflank-mailman (input) for mailman id 581246; Wed, 09 Aug 2023 17:05:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTmcz-0004JM-Kx; Wed, 09 Aug 2023 17:05:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTmcz-0006jG-GR; Wed, 09 Aug 2023 17:05:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTmcz-0001Ar-6y; Wed, 09 Aug 2023 17:05:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTmcz-0004WL-6Z; Wed, 09 Aug 2023 17:05:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=r4DQ8tZvMHFPFVOjgBK48g9Luxe6F5vdK6bPR3Yr5N0=; b=Yt09+zCObIHEJHByZFGRlCODmb xLi09hSymQV6eeQAdWhGj+yVP+JMB/VmwlF26xEl+3j60ehSJG3YxGcQ6c0Y6UZGP6j4PVDNHrqEz nSg7OXrBUgu1Qlpxnm2ljZG1I4SVEn0zRcMYXw3djRISnR3Mfl/Q495HII58X+cXKJgE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 182249: all pass - PUSHED X-Osstest-Versions-This: ovmf=991515a0583f65a64b3a6fa354409c64e670a762 X-Osstest-Versions-That: ovmf=136931c4dbf532ec913b68673c91b4285e63464b From: osstest service owner Date: Wed, 09 Aug 2023 17:05:45 +0000 flight 182249 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182249/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 991515a0583f65a64b3a6fa354409c64e670a762 baseline version: ovmf 136931c4dbf532ec913b68673c91b4285e63464b Last test of basis 182245 2023-08-09 06:10:51 Z 0 days Testing same since 182249 2023-08-09 15:12:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Brian J. Johnson Gerd Hoffmann Kenneth Lautner Yi Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 136931c4db..991515a058 991515a0583f65a64b3a6fa354409c64e670a762 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Aug 09 17:34:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 17:34:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581267.909868 (Exim 4.92) (envelope-from ) id 1qTn4e-0007ob-QG; Wed, 09 Aug 2023 17:34:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581267.909868; Wed, 09 Aug 2023 17:34:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTn4e-0007oU-Mo; Wed, 09 Aug 2023 17:34:20 +0000 Received: by outflank-mailman (input) for mailman id 581267; Wed, 09 Aug 2023 17:34:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTn4d-0007oO-Mq for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 17:34:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTn4c-0007Mm-Uv; Wed, 09 Aug 2023 17:34:18 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=[192.168.16.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTn4c-0007dh-Kh; Wed, 09 Aug 2023 17:34:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dvABPzMPqixvm+5Bz9qkLEvwpUhsKZKnJlXFqeYdjBQ=; b=Ic2u3D5/FNJZEp52KnUH8tDh91 TF5hR62ME40gxBj6ebIPUVCJXjAWEbDlaQdDDvUhAPqQQ3mg7+AiKLQRD4GfkbtfDo+bMV7EVi8TH NVOa+klOzAU7XYfG3rQNMxIKiVwUL2WeW9T26nPnnDqHJ/MSFh/1v+/F+sIstcoaoC7I=; Message-ID: <79702aee-e02e-4503-a808-288ba00b8df3@xen.org> Date: Wed, 9 Aug 2023 18:34:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of MPU work Content-Language: en-GB To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Jan Beulich , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20230801034419.2047541-1-Henry.Wang@arm.com> <4f43b069-cb78-f356-628e-29b8ca8e595a@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/08/2023 04:59, Henry Wang wrote: > Hi Julien, Hi Henry, -----Original Message----- >> From: Julien Grall >> Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of >> MPU work >> >> Hi, >> >> On 01/08/2023 04:44, Henry Wang wrote: >>> Based on the discussion in the Xen Summit [1], sending this series out after >>> addressing the comments in v3 [2] as the preparation work to add MPU >> support. >>> >>> Mostly code movement, with some of Kconfig and build system (mainly >> Makefiles) >>> adjustment. No functional change expected. >> >> I can't really review this series without knowing how this will >> integrate with the rest of the MPU work. > > Sorry about it, I should have asked before sending the series. > >> Can you at least provide a tree >> with all the patches applied (including the MPU one)? > > See [1] for the full single core MPU implementation which I've verified > locally about the MMU and MPU single core Linux boot on FVP, and > looks like Gitlab is also not complaining [2]. Thanks for the link! > > Note that I've addressed comments from you and Ayan in v3 about the > MMU/MPU helpers duplication and the arm32/arm64 split work. I didn't > address the comment in [3] about the RES0 stuff, but I think this is not > related to the MMU split series I sent yesterday to mailing list and the > formal v4 MPU work sent to the mailing list will contain the fix for this > comment. Agree, the RES0 bit is MPU specific. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 18:38:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 18:38:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581273.909878 (Exim 4.92) (envelope-from ) id 1qTo4t-00062r-Iz; Wed, 09 Aug 2023 18:38:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581273.909878; Wed, 09 Aug 2023 18:38:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTo4t-00062k-Fn; Wed, 09 Aug 2023 18:38:39 +0000 Received: by outflank-mailman (input) for mailman id 581273; Wed, 09 Aug 2023 18:38:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTo4s-00062a-3T; Wed, 09 Aug 2023 18:38:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTo4r-0000M0-Uq; Wed, 09 Aug 2023 18:38:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTo4r-0004Bj-G6; Wed, 09 Aug 2023 18:38:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTo4r-00024K-Ff; Wed, 09 Aug 2023 18:38:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A4Ce1BtWmGboiX1DTClxeWZe2Gd7lCa+9I6ZZA/Pyjo=; b=BNImc1CRr//NIqFocJJMmgR+fx zEIAgdpru31YECgi4mdpKTKEyKMpIvWsUxKhzCP1545jsSIkisk5aKi66vatffdfdnsXSj40Nutth r4YhAaOUNE4KceiHiJRcKYuBjrjhRn7baF40RqvWiZJ3PJ8TZWXZgFA0hPP9VwDb8Pgk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182250: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=236fc9fdf97f4e7c64824ab793e8dca30dd54ffb X-Osstest-Versions-That: xen=15601eed05922c0df5b59d5fb3f9ec6d85e57a00 From: osstest service owner Date: Wed, 09 Aug 2023 18:38:37 +0000 flight 182250 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182250/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 236fc9fdf97f4e7c64824ab793e8dca30dd54ffb baseline version: xen 15601eed05922c0df5b59d5fb3f9ec6d85e57a00 Last test of basis 182248 2023-08-09 12:04:01 Z 0 days Testing same since 182250 2023-08-09 16:02:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Nicola Vetrini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 15601eed05..236fc9fdf9 236fc9fdf97f4e7c64824ab793e8dca30dd54ffb -> smoke From xen-devel-bounces@lists.xenproject.org Wed Aug 09 18:42:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 18:42:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581281.909888 (Exim 4.92) (envelope-from ) id 1qTo8C-0007YN-7O; Wed, 09 Aug 2023 18:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581281.909888; Wed, 09 Aug 2023 18:42:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTo8C-0007YG-44; Wed, 09 Aug 2023 18:42:04 +0000 Received: by outflank-mailman (input) for mailman id 581281; Wed, 09 Aug 2023 18:42:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTo8A-0007Y8-6g for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 18:42:02 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b779173-36e4-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 20:41:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 4271482854AF; Wed, 9 Aug 2023 13:41:57 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id i-jk6jubwgRR; Wed, 9 Aug 2023 13:41:55 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 75239828553F; Wed, 9 Aug 2023 13:41:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KFN2J-Za5LsL; Wed, 9 Aug 2023 13:41:55 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 0A37282854AF; Wed, 9 Aug 2023 13:41:55 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b779173-36e4-11ee-b281-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 75239828553F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691606515; bh=mcGoxV1b2BeXAtbsXWVL+8EprU7jc+Wwc/qEI47/3sc=; h=Message-ID:Date:MIME-Version:To:From; b=X1QZmlzQMM7v5gARlIXQKWy1MFz/43p2uwn9bm/6tF/uGhYoFJVcY5zs9Q/M1bCCb WvU5JlPEDjbcQHzhhAK5VrSOUwyXjYWnTrfp1RVripE093Fmlf8ayVc1/99cTsbF5c iuK9oos3wK81VSaOremfnaUZAW4Cd75h/jN82lsA= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: <21365276-8338-12b9-b3b8-2a222e7eceef@raptorengineering.com> Date: Wed, 9 Aug 2023 13:41:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/9] xen/ppc: Define minimal stub headers required for full build Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <9cd545a4a9ef55d06ea0b81044e22f64ee42823e.1691016993.git.sanastasio@raptorengineering.com> From: Shawn Anastasio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/8/23 4:12 AM, Jan Beulich wrote: > On 03.08.2023 01:03, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/altp2m.h >> @@ -0,0 +1,39 @@ >> +/* >> + * Alternate p2m >> + * >> + * Copyright (c) 2014, Intel Corporation. >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms and conditions of the GNU General Public License, >> + * version 2, as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License along with >> + * this program; If not, see . >> + */ > > Please use an SPDX header instead in new code. I also wonder about the > Intel copyright. I realize it's that way in the Arm header that you > apparently copied, but even there it's pretty odd. I don't think such > a pair of stub functions is reasonably copyrightable. Yes, I agree the copyright is a bit strange and was likely just copied on the Arm side from the original x86 header. Since I'm not copying any actually implemented code, I think it's safe to drop this in favor of just a standard SPDX header. I'll make that change. >> +#ifndef __ASM_PPC_ALTP2M_H__ >> +#define __ASM_PPC_ALTP2M_H__ >> + >> +#include > > I don't think this is needed here (nor in Arm's original). All you > need are forward decls of struct domain and struct vcpu. And > xen/bug.h plus xen/types.h. > Fair enough -- and bug.h seems to already include types.h for us, so we only need the one include plus the two forward declarations. I'll update this. >> --- a/xen/arch/ppc/include/asm/bug.h >> +++ b/xen/arch/ppc/include/asm/bug.h >> @@ -4,6 +4,7 @@ >> #define _ASM_PPC_BUG_H >> >> #include >> +#include >> >> /* >> * Power ISA guarantees that an instruction consisting of all zeroes is >> @@ -15,4 +16,10 @@ >> >> #define BUG_FN_REG r0 >> >> +#define BUG() do { \ >> + die(); \ >> +} while (0) > > This looks like it's temporary. I think any construct that later needs > updating wants marking in some common way (such that it's easy to grep > for items left to be dealt with; you have such a comment in e.g. > asm/event.h). Of course if an entire header consists of _only_ stubs, > perhaps a single such comment would suffice. Yes, agreed that this macro deserves a TODO comment. As for the rest of the stub functions that this patch implements, are you suggesting that each file with stubs should contain a similar comment? Another alternative that I thought of would be to define a BUG_UNIMPLEMENTED() macro or similar and call that inside of all the stub functions. >> --- a/xen/arch/ppc/include/asm/cache.h >> +++ b/xen/arch/ppc/include/asm/cache.h >> @@ -3,4 +3,6 @@ >> #ifndef _ASM_PPC_CACHE_H >> #define _ASM_PPC_CACHE_H >> >> +#define __read_mostly __section(".data.read_mostly") > > Not something for you to do, but we really want to move this to > xen/cache.h. > Perfect, will drop this from my series. >> diff --git a/xen/arch/ppc/include/asm/desc.h b/xen/arch/ppc/include/asm/desc.h >> new file mode 100644 >> index 0000000000..e69de29bb2 > > Along the lines of the above - common code should not include this > header, and Arm shouldn't need one either. I'll see if I can sort > this. > Ditto. >> --- a/xen/arch/ppc/include/asm/mm.h >> +++ b/xen/arch/ppc/include/asm/mm.h >> @@ -1,19 +1,270 @@ >> #ifndef _ASM_PPC_MM_H >> #define _ASM_PPC_MM_H >> >> +#include >> +#include >> +#include >> #include >> #include >> >> +void setup_initial_pagetables(void); >> + >> +extern unsigned long total_pages; >> + >> #define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT) >> #define paddr_to_pfn(pa) ((unsigned long)((pa) >> PAGE_SHIFT)) >> +#define paddr_to_pdx(pa) mfn_to_pdx(maddr_to_mfn(pa)) >> +#define gfn_to_gaddr(gfn) pfn_to_paddr(gfn_x(gfn)) >> +#define gaddr_to_gfn(ga) _gfn(paddr_to_pfn(ga)) >> +#define mfn_to_maddr(mfn) pfn_to_paddr(mfn_x(mfn)) >> +#define maddr_to_mfn(ma) _mfn(paddr_to_pfn(ma)) >> +#define vmap_to_mfn(va) maddr_to_mfn(virt_to_maddr((vaddr_t)va)) >> +#define vmap_to_page(va) mfn_to_page(vmap_to_mfn(va)) >> >> #define virt_to_maddr(va) ((paddr_t)((vaddr_t)(va) & PADDR_MASK)) >> -#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START) >> +#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START)) >> >> /* Convert between Xen-heap virtual addresses and machine addresses. */ >> #define __pa(x) (virt_to_maddr(x)) >> #define __va(x) (maddr_to_virt(x)) >> >> -void setup_initial_pagetables(void); >> +/* Convert between Xen-heap virtual addresses and machine frame numbers. */ >> +#define __virt_to_mfn(va) (virt_to_maddr(va) >> PAGE_SHIFT) >> +#define __mfn_to_virt(mfn) (maddr_to_virt((paddr_t)(mfn) << PAGE_SHIFT)) >> + >> +/* Convert between Xen-heap virtual addresses and page-info structures. */ >> +static inline struct page_info *virt_to_page(const void *v) >> +{ >> + BUG(); >> + return NULL; >> +} >> + >> +/* >> + * We define non-underscored wrappers for above conversion functions. >> + * These are overriden in various source files while underscored version >> + * remain intact. >> + */ >> +#define virt_to_mfn(va) __virt_to_mfn(va) >> +#define mfn_to_virt(mfn) __mfn_to_virt(mfn) >> + >> +#define PG_shift(idx) (BITS_PER_LONG - (idx)) >> +#define PG_mask(x, idx) (x ## UL << PG_shift(idx)) >> + >> +#define PGT_none PG_mask(0, 1) /* no special uses of this page */ >> +#define PGT_writable_page PG_mask(1, 1) /* has writable mappings? */ >> +#define PGT_type_mask PG_mask(1, 1) /* Bits 31 or 63. */ >> + >> + /* 2-bit count of uses of this frame as its current type. */ >> +#define PGT_count_mask PG_mask(3, 3) >> + >> +/* Cleared when the owning guest 'frees' this page. */ >> +#define _PGC_allocated PG_shift(1) >> +#define PGC_allocated PG_mask(1, 1) >> +/* Page is Xen heap? */ >> +#define _PGC_xen_heap PG_shift(2) >> +#define PGC_xen_heap PG_mask(1, 2) >> +/* Page is static memory */ >> +#define PGC_static 0 > > You don't need this. > Will drop. >> +/* Page is broken? */ >> +#define _PGC_broken PG_shift(7) >> +#define PGC_broken PG_mask(1, 7) >> + /* Mutually-exclusive page states: { inuse, offlining, offlined, free }. */ >> +#define PGC_state PG_mask(3, 9) >> +#define PGC_state_inuse PG_mask(0, 9) >> +#define PGC_state_offlining PG_mask(1, 9) >> +#define PGC_state_offlined PG_mask(2, 9) >> +#define PGC_state_free PG_mask(3, 9) >> +#define page_state_is(pg, st) (((pg)->count_info&PGC_state) == PGC_state_##st) >> +/* Page is not reference counted */ >> +#define _PGC_extra PG_shift(10) >> +#define PGC_extra PG_mask(1, 10) >> + >> +/* Count of references to this frame. */ >> +#define PGC_count_width PG_shift(10) >> +#define PGC_count_mask ((1UL<> + >> +/* >> + * Page needs to be scrubbed. Since this bit can only be set on a page that is >> + * free (i.e. in PGC_state_free) we can reuse PGC_allocated bit. >> + */ >> +#define _PGC_need_scrub _PGC_allocated >> +#define PGC_need_scrub PGC_allocated >> + >> +#define is_xen_heap_page(page) ((page)->count_info & PGC_xen_heap) >> +#define is_xen_heap_mfn(mfn) \ >> + (mfn_valid(mfn) && is_xen_heap_page(mfn_to_page(mfn))) >> + >> +#define is_xen_fixed_mfn(mfn) \ >> + ((mfn_to_maddr(mfn) >= virt_to_maddr(&_start)) && \ >> + (mfn_to_maddr(mfn) <= virt_to_maddr((vaddr_t)_end - 1))) >> + >> +#define page_get_owner(_p) (_p)->v.inuse.domain >> +#define page_set_owner(_p,_d) ((_p)->v.inuse.domain = (_d)) >> + >> +/* TODO: implement */ >> +#define mfn_valid(mfn) ({ (void) (mfn); 0; }) >> +#define max_page ((unsigned long )0) > > It's clear this is temporary, but it would still be nice if you could > omit stray blanks. > With your max_page/total_pages common patch I can drop this entirely. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/monitor.h >> @@ -0,0 +1,48 @@ >> +/* Derived from xen/arch/arm/include/asm/monitor.h */ >> +#ifndef __ASM_PPC_MONITOR_H__ >> +#define __ASM_PPC_MONITOR_H__ >> + >> +#include >> + >> +#include >> +#include > > Judging from the contents of the file, you don't need either (and you > certainly don't need public/domctl.h twice). Only xen/types.h looks to > be needed right now. The implementation of `arch_monitor_get_capabilities` uses XEN_DOMCTL_* macros defined in public/domctl.h. xen/errno.h is also needed for EOPNOTSUPP (it seemed to be getting included by sched.h). I'll drop the sched.h include as well as the duplicate public/domctl.h include though. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/numa.h >> @@ -0,0 +1,26 @@ >> +#ifndef __ASM_PPC_NUMA_H__ >> +#define __ASM_PPC_NUMA_H__ >> + >> +#include >> +#include >> + >> +typedef uint8_t nodeid_t; >> + >> +/* Fake one node for now. See also node_online_map. */ >> +#define cpu_to_node(cpu) 0 >> +#define node_to_cpumask(node) (cpu_online_map) >> + >> +/* >> + * TODO: make first_valid_mfn static when NUMA is supported on Arm, this >> + * is required because the dummy helpers are using it. >> + */ >> +extern mfn_t first_valid_mfn; > > At least "Arm" wants replacing in the comment, I think. > Good catch. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/percpu.h >> @@ -0,0 +1,26 @@ >> +#ifndef __PPC_PERCPU_H__ >> +#define __PPC_PERCPU_H__ >> + >> +#ifndef __ASSEMBLY__ >> + >> +#include > > Looks like nothing in the file requires this. > You are correct. I'll drop it. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/procarea.h >> @@ -0,0 +1,38 @@ >> +/* >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. > > SPDX again please (and there's at least one more below). > Will fix. >> + * Copyright (C) IBM Corp. 2005 >> + * >> + * Authors: Hollis Blanchard >> + */ >> + >> +#ifndef _ASM_PROCAREA_H_ >> +#define _ASM_PROCAREA_H_ >> + >> +#include > > Again nothing looks to require this. > Will remove. >> +struct vcpu; >> +struct gdb_state; > > The later of these is unused below. The former is used, but in a way > that would require a forward decl only in C++. > I'll drop them both. >> --- a/xen/arch/ppc/include/asm/processor.h >> +++ b/xen/arch/ppc/include/asm/processor.h >> @@ -110,6 +110,10 @@ >> /* Macro to adjust thread priority for hardware multithreading */ >> #define HMT_very_low() asm volatile ( "or %r31, %r31, %r31" ) >> >> +/* TODO: This isn't correct */ >> +#define cpu_to_core(_cpu) (0) >> +#define cpu_to_socket(_cpu) (0) > > As mentioned elsewhere, please try to avoid leading underscores in > macro parameter names (or macro local variables, just to mention > it again in this context). > Will fix. >> @@ -175,6 +179,8 @@ static inline void noreturn die(void) >> HMT_very_low(); >> } >> >> +#define cpu_relax() asm volatile ( "or %r1, %r1, %r1; or %r2, %r2, %r2" ) > > Just like HMT_very_low() this could do with a comment explaining > the "interesting" ORs (until such time when the assembler supports > suitable mnemonics). > >> --- a/xen/arch/ppc/include/asm/regs.h >> +++ b/xen/arch/ppc/include/asm/regs.h >> @@ -23,6 +23,8 @@ >> #ifndef _ASM_REG_DEFS_H_ >> #define _ASM_REG_DEFS_H_ >> >> +#include >> + >> /* Special Purpose Registers */ >> #define SPRN_VRSAVE 256 >> #define SPRN_DSISR 18 > > Why would this #include be needed here all of the sudden? > This was a stray change I forgot to remove. Will fix. >> --- a/xen/arch/ppc/include/asm/system.h >> +++ b/xen/arch/ppc/include/asm/system.h >> @@ -1,6 +1,247 @@ >> +/* >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. >> + * >> + * Copyright (C) IBM Corp. 2005 >> + * Copyright (C) Raptor Engineering LLC >> + * >> + * Authors: Jimi Xenidis >> + * Shawn Anastasio >> + */ >> + >> #ifndef _ASM_SYSTEM_H_ >> #define _ASM_SYSTEM_H_ >> >> -#define smp_wmb() __asm__ __volatile__ ( "lwsync" : : : "memory" ) >> +#include > > As mentioned before - any such #include you find is a leftover. Will update. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Wed Aug 09 19:51:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 19:51:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581289.909900 (Exim 4.92) (envelope-from ) id 1qTpDL-0006We-86; Wed, 09 Aug 2023 19:51:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581289.909900; Wed, 09 Aug 2023 19:51:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpDL-0006WX-5V; Wed, 09 Aug 2023 19:51:27 +0000 Received: by outflank-mailman (input) for mailman id 581289; Wed, 09 Aug 2023 19:51:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpDK-0006WR-6P for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 19:51:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d80763a-36ee-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 21:51:23 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4DD3563D2A; Wed, 9 Aug 2023 19:51:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCD31C433C8; Wed, 9 Aug 2023 19:51:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d80763a-36ee-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691610680; bh=n7HxIyR3ae7w/kdJbvhrByOAckYn8xYNfuHb2yW74Eo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=i0DfBHWmBP1cB2JvGyBPMQY+ZroqyFkuREBbr86B2Q5O5uGqNRkOKfMxEavWN7ggC itIQ6cHJaYfEzhgKDOcO9tg6sq+fqHzkJZdIH76rszvmxeKxjkEF0JwNAhnGcbTmYI SCt83ImNSJuPIWHjR93NsEhlfiIyAiBQQhpxVa59g72Us+cayUPKvaBIHOAMSH/rsc PxfW/EOOiHNjpj+vXZfalC7TFQSWnCGtZ+z+G++aAHBi6K0knnVgNtWnJctgXMV0ie 7O9JNkxwqcaRJUIXAuCVtq72sDZ+Q9NgCtZP1X8oA8lNTgHH2Rog8XVktFcQUPq/D+ qsXIJ/Ob41VQA== Date: Wed, 9 Aug 2023 12:51:17 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu , jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , george.dunlap@citrix.com, christopher.w.clark@gmail.com, dpsmith@apertussolutions.com Subject: Moving Dom0less to common, Was: [PATCH 0/5] Fine granular configuration In-Reply-To: <20230808080010.3858575-1-luca.fancellu@arm.com> Message-ID: References: <20230808080010.3858575-1-luca.fancellu@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Adding hyperlaunch and x86 maintainers. Hi Luca, This patch series is very timely. You might not have realized but we were just discussing with the hyperlaunch guys to move dom0less code to common. Your series is a great step in the right direction. However, we don't want to move the dom0less code twice because it would make 'git blame' very hard to use. I wonder if I could ask you to move the code to xen/common/ instead. I am not asking you to make it buildable on x86, as that would take more work and also something along the lines of this patch series from Christopher: https://patchew.org/Xen/20230701071835.41599-1-christopher.w.clark@gmail.com/ The new code could be protected by CONFIG_DOM0LESS, and CONFIG_DOM0LESS could only be selectable on ARM, not on x86. Would you be OK with doing some extra work to move it to xen/common instead? Would the x86 maintainers be OK with it too? Of course further changes will be needed to make it useable on x86, but looking at the series from Christopher, the two sets of internal interfaces (dom0less/ARM and hyperlaunch/x86) are very much aligned and similar already. Cheers, Stefano On Tue, 8 Aug 2023, Luca Fancellu wrote: > This serie aims to add more modularity to some feature that can be excluded > without issues from the build. > > The first patch is already reviewed. > > Luca Fancellu (5): > arm/gicv2: make GICv2 driver and vGICv2 optional > xen/arm: Add asm/domain.h include to kernel.h > arm/dom0less: put dom0less feature code in a separate module > xen/arm: Move static memory build code in separate modules > arm/dom0less: introduce Kconfig for dom0less feature > > xen/arch/arm/Kconfig | 28 + > xen/arch/arm/Makefile | 7 +- > xen/arch/arm/bootfdt.c | 161 +- > xen/arch/arm/dom0less-build.c | 1086 ++++++ > xen/arch/arm/domain_build.c | 4096 ++++++--------------- > xen/arch/arm/efi/efi-boot.h | 4 + > xen/arch/arm/gic-v3.c | 4 + > xen/arch/arm/include/asm/dom0less-build.h | 35 + > xen/arch/arm/include/asm/domain_build.h | 33 + > xen/arch/arm/include/asm/kernel.h | 1 + > xen/arch/arm/include/asm/setup.h | 1 - > xen/arch/arm/include/asm/static-memory.h | 50 + > xen/arch/arm/include/asm/static-shmem.h | 72 + > xen/arch/arm/setup.c | 58 +- > xen/arch/arm/static-memory.c | 294 ++ > xen/arch/arm/static-shmem.c | 515 +++ > xen/arch/arm/vgic.c | 2 + > xen/arch/arm/vgic/Makefile | 4 +- > 18 files changed, 3357 insertions(+), 3094 deletions(-) > create mode 100644 xen/arch/arm/dom0less-build.c > create mode 100644 xen/arch/arm/include/asm/dom0less-build.h > create mode 100644 xen/arch/arm/include/asm/static-memory.h > create mode 100644 xen/arch/arm/include/asm/static-shmem.h > create mode 100644 xen/arch/arm/static-memory.c > create mode 100644 xen/arch/arm/static-shmem.c > > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:04:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:04:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581296.909910 (Exim 4.92) (envelope-from ) id 1qTpPW-0008B1-B0; Wed, 09 Aug 2023 20:04:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581296.909910; Wed, 09 Aug 2023 20:04:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpPW-0008Au-8L; Wed, 09 Aug 2023 20:04:02 +0000 Received: by outflank-mailman (input) for mailman id 581296; Wed, 09 Aug 2023 20:04:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpPV-0008Ao-2y for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:04:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfe62066-36ef-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:03:58 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1C63647D2; Wed, 9 Aug 2023 20:03:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1061C433C7; Wed, 9 Aug 2023 20:03:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfe62066-36ef-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691611436; bh=yaf3QiM3FCmuwE0+FvxSEerQ+2mm8mVn1PCR4QVEfYs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fG7aFgxXUbiNctTP3eoqOuNI24q8lF1i9MNlEjqAPFKyAit+ApDllrhr0RpeLxmp8 rjZQu7BwCLMMF/Hkun2S4IUEJ+0MMBl4+TiiQynkk8tNiyQxe85s7OkyZwvm1NCvnn bMI5FDRB+eaSYLhV0XDqLL+0sSuxHFH2ITzsAU8T1Qnk8t8Y9hpbwg2agRz/BsH++j guG45CHu5VM6KLEuf+OAXS4NkPJTNaROxsjtxiBJlmMarBJpRKNJd4EeRspts6IFuH yz7ztUvwFr5tI7E/yTCzpARl9+RS/LiOxJ2CQawHiW3kNOxwmxug4n/aDP2R2cKVto pcDVeuuLXFodA== Date: Wed, 9 Aug 2023 13:03:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Nicola Vetrini , Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [XEN PATCH 1/8] arm/efi: address MISRA C:2012 Rule 8.4 In-Reply-To: Message-ID: References: <4d087a54edb3f92e9271e3d01c1abebf00d3e298.1691575243.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1712112080-1691611436=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1712112080-1691611436=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 9 Aug 2023, Luca Fancellu wrote: > > On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: > > > > the function 'fdt_add_uefi_nodes' can be defined static, as its > > only callers are within the same file. This in turn avoids > > violating Rule 8.4 because no declaration is present. > > > > No functional change. > > > > Signed-off-by: Nicola Vetrini > > Reviewed-by: Luca Fancellu > > With > > Fixes: 6d70ea10d49f ("Add ARM EFI boot supportâ€) Acked-by: Stefano Stabellini --8323329-1712112080-1691611436=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:05:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:05:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581300.909921 (Exim 4.92) (envelope-from ) id 1qTpQS-0000IZ-JV; Wed, 09 Aug 2023 20:05:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581300.909921; Wed, 09 Aug 2023 20:05:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpQS-0000IS-Gg; Wed, 09 Aug 2023 20:05:00 +0000 Received: by outflank-mailman (input) for mailman id 581300; Wed, 09 Aug 2023 20:04:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpQR-00009o-Lj for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:04:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03ddfbb9-36f0-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 22:04:58 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B7AD1647E7; Wed, 9 Aug 2023 20:04:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 861B4C433C8; Wed, 9 Aug 2023 20:04:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03ddfbb9-36f0-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691611497; bh=OlA84lxKgd9t+5y59oDJoB/kbiieGIrCsjl/EpEXR5c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=P17sIxGZBrYK2FTKrCRgiHKf7D1szRcGQF/gnPtgA4mYMUjOw5H4wCtyHMcPoBPWP JMs1AgyC+pVtANDeW8DppfwmH+m8DFWbmqlDR7W6k74Uew0PkQ2XBPGUUnSG4As7BM H6FpNhzywMz/KN+3EI7jFL8EaGd9LHJIPUguaSPEmtzW/exRyvDLBnfW9/Hlyc5RaN 0fq0dgYx+6JozpkHWCeC/6y94J/8fZzcD2YctksIKA3lGUewwwGw/g1DQ7XTqPqFNI fmHblEAYR5Pse02brwThki+MBq8AjTvYyPi/HJoeAx9QcydRZ0fTOe0vyfqHNk0IoM wnTMSAQKeStVQ== Date: Wed, 9 Aug 2023 13:04:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Nicola Vetrini , Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 2/8] xen/memory: address MISRA C:2012 Rule 8.4 In-Reply-To: <2AD1EA83-AE7F-485C-ABFA-D285B4BAB1CC@arm.com> Message-ID: References: <844e7bf57c2eb7b20d8b1f81a7730a7612f1b6ac.1691575243.git.nicola.vetrini@bugseng.com> <2AD1EA83-AE7F-485C-ABFA-D285B4BAB1CC@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-51032565-1691611497=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-51032565-1691611497=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 9 Aug 2023, Luca Fancellu wrote: > > On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: > > > > The function 'ioreq_server_max_frames' can be defined static, > > as its only uses are within the same file. This in turn avoids > > violating Rule 8.4 because no declaration is present. > > > > No functional change. > > > > Signed-off-by: Nicola Vetrini > > Makes sense, > > Reviewed-by: Luca Fancellu Acked-by: Stefano Stabellini > Maybe it’s also better adding this: > Fixes: 9244528955de ("xen/memory: Fix acquire_resource size semanticsâ€) > > If the maintainers agree Yes --8323329-51032565-1691611497=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:06:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581304.909931 (Exim 4.92) (envelope-from ) id 1qTpRt-0000vd-2T; Wed, 09 Aug 2023 20:06:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581304.909931; Wed, 09 Aug 2023 20:06:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpRs-0000vW-VQ; Wed, 09 Aug 2023 20:06:28 +0000 Received: by outflank-mailman (input) for mailman id 581304; Wed, 09 Aug 2023 20:06:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpRq-0000vJ-Vw for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:06:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 371a5271-36f0-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:06:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 918D7647ED; Wed, 9 Aug 2023 20:06:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41C54C433C7; Wed, 9 Aug 2023 20:06:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 371a5271-36f0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691611583; bh=An2eScnbVLdGjB9nYSfhVdnbAk6Pvp4KnDnEvyDLZyc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=tuk+Xz+OSmrlQe2cFnJuzR3JDey2MSTathw77vje9fYaAT+dqzBATvQkKltfHRgZj JSl6DOyUebCnM1P7qhCrxVcG/Fum7GinpjdpnZxQXgcAOgK9v2BuBYoTeImzDMgW6A TN6KJ2lyDEeCukqpEH1fK+SJfsjQgBTUKZva7Xp+peOxN7iRu897MGIxXXyaFdMR1J uS6zqu1DFTF/ne+wh7OiaKG+EGkMYLitqY8RD+48Y0ZsoQbbZLp2Ti3OEfKkNvWvGj bZ3NARxXVmItzWIjtnelsB3I2zvNJMjX3hYRKipOHHFA4YkN30tHz6sY/0z8fTcmk/ bIyovvv6y0mjg== Date: Wed, 9 Aug 2023 13:06:19 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Nicola Vetrini , Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Jan Beulich Subject: Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 In-Reply-To: <771C6AF9-8BB8-466C-B9A4-1745016BEB1E@arm.com> Message-ID: References: <041f2137-8a90-79f6-3677-f764cb1b6656@suse.com> <771C6AF9-8BB8-466C-B9A4-1745016BEB1E@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Luca Fancellu wrote: > > On 9 Aug 2023, at 15:06, Jan Beulich wrote: > > > > On 09.08.2023 15:50, Luca Fancellu wrote: > >>> On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: > >>> > >>> The variable 'saved_cmdline' can be defined static, > >>> as its only uses are within the same file. This in turn avoids > >>> violating Rule 8.4 because no declaration is present. > >>> > >>> Signed-off-by: Nicola Vetrini > >>> --- > >>> xen/common/kernel.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/xen/common/kernel.c b/xen/common/kernel.c > >>> index fb919f3d9c..52aa287627 100644 > >>> --- a/xen/common/kernel.c > >>> +++ b/xen/common/kernel.c > >>> @@ -28,7 +28,7 @@ CHECK_feature_info; > >>> > >>> enum system_state system_state = SYS_STATE_early_boot; > >>> > >>> -xen_commandline_t saved_cmdline; > >>> +static xen_commandline_t saved_cmdline; > >> > >> I see this line was touched by fa97833ae18e4a42c0e5ba4e781173457b5d3397, > >> have you checked that making it static was not affecting anything else? > > > > The code requiring the symbol to be non-static went away in e6ee01ad24b6 > > ("xen/version: Drop compat/kernel.c"). That's where the symbol would have > > wanted to become static. But that was very easy to overlook. > > Yes you are right Jan, > > Reviewed-by: Luca Fancellu > > Possibly with the Fixes tag Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:10:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:10:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581311.909941 (Exim 4.92) (envelope-from ) id 1qTpVU-0002PI-GX; Wed, 09 Aug 2023 20:10:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581311.909941; Wed, 09 Aug 2023 20:10:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpVU-0002PB-Df; Wed, 09 Aug 2023 20:10:12 +0000 Received: by outflank-mailman (input) for mailman id 581311; Wed, 09 Aug 2023 20:10:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpVT-0002P5-KC for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:10:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd0f2e16-36f0-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:10:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5845A6482B; Wed, 9 Aug 2023 20:10:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E41BCC433CA; Wed, 9 Aug 2023 20:10:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd0f2e16-36f0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691611807; bh=z2Nl5yr8cnBc53hLZ3OJmUrtXEiHAEXf0P6LZhDoq5g=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jKYf0vQ+8kd/83X/+uEt6Dp1f0R8WXHXl2nxSd0nBiHYNkDWyDpv+vKlEglvIKvZZ PTXunhxkeFWlsrB7NXIPhHKsT3ipXiNSJw2Sulhl6ex0wOgslLhLyCqZ0YwzQYMG2E xD8aNfILityl50phbZsqRgAMNEsLjpk5kwMaoF6mvyr3VRynCbKvMh3oMG1AXmwuhg x/SltNIL1XV7uJcZWUAwh9OYkcxdAl6TI4ny/T1QlNjIJ1eDmOwnKlRjQLklx6sjR2 H31O4F8yZE67wDKU/KxEDr3GTYhDf+pWTVmrQL1rZZigq54nUVkIUbE9qJ/V2gvqNz h8NOIHjkJphKg== Date: Wed, 9 Aug 2023 13:10:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 4/8] xen/arm: address MISRA C:2012 Rule 8.4 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Jan Beulich wrote: > On 09.08.2023 13:02, Nicola Vetrini wrote: > > 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow > > the declaration of 'arch_get_xen_caps' to be visible when > > defining the function. > > > > The header 'xen/delay.h' is included in 'xen/arch/arm/time.c' > > to allow the declaration of 'udelay' to be visible. > > > > At the same time, a declaration for 'get_sec' is added in > > 'xen/include/xen/time.h' to be available for every call site > > (in particular cper.h). > > > > Signed-off-by: Nicola Vetrini > > --- > > xen/arch/arm/setup.c | 1 + > > xen/arch/arm/time.c | 1 + > > xen/include/xen/cper.h | 3 +-- > > xen/include/xen/time.h | 1 + > > 4 files changed, 4 insertions(+), 2 deletions(-) > > I would have almost put this off as Arm-only, but then saw this diffstat. > How come you consider cper.h Arm-related? This is used only by APEI source > files, which in turn are used only by x86 afaics. So I think you want to > split off the movement of the get_sec() declaration. > > As to title and description (perhaps affecting more than just this patch): > Failing to have declarations in scope where definitions appear is an at > least latent bug. We fix these as we find them anyway, so Misra is > secondary here. Hence I'd like to suggest that you declare any such > change as an actual bugfix, ideally including a Fixes: tag. It is of > course fine to mention that this then also addresses Misra rule 8.4. As you split the patches moving cper.h out, and fixing the commit message, please add my Reviewed-by for the setup.c/time.c/time.h changes. From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:11:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:11:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581315.909951 (Exim 4.92) (envelope-from ) id 1qTpX5-0002xF-SL; Wed, 09 Aug 2023 20:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581315.909951; Wed, 09 Aug 2023 20:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpX5-0002x8-PG; Wed, 09 Aug 2023 20:11:51 +0000 Received: by outflank-mailman (input) for mailman id 581315; Wed, 09 Aug 2023 20:11:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpX4-0002x2-HN for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:11:50 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f80fb126-36f0-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:11:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 497D464823; Wed, 9 Aug 2023 20:11:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 478B5C433C9; Wed, 9 Aug 2023 20:11:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f80fb126-36f0-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691611906; bh=AprQhLEFd+wp1TpuyZZ6oKaapiMpY5kk9+185VXeksk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Pkafl/rRgn8UgvSziOw/RoD0cezIoL5TsuhXlKIPgzmHmd0mgZwG2bNz9e0q0zHKw fQey6nBwSO9KgYYqJuiVDuIjXj7Vu7fE6SpT4b+qe4OALvlWLniLVgRfYpHj+GYqR0 458tVnh0EF91h1R+xo2bYyHAGm68HFde5P1r0ASz0QJLx/1rIeU2Or06ZAzOHOaDoo QA1qVUXBjFgFr/4tuP9GeE/12k0mWD4e8KfgO+1yBAivsUsUQgLa5YHg7bydsrwQSt BvKX7t0HjDiY0AhGy4HJoypEbK12O18rEvy2lzOhbyQAASMDIBVolzLNw4kjB5Xv4Z u1sLs30CvMnfw== Date: Wed, 9 Aug 2023 13:11:43 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Nicola Vetrini , Xen-devel , Stefano Stabellini , "michal.orzel@amd.com" , "xenia.ragiadakou@amd.com" , "ayan.kumar.halder@amd.com" , "consulting@bugseng.com" , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [XEN PATCH 6/8] xen/arm: mm: address MISRA C:2012 Rule 8.4 In-Reply-To: <0C30A959-AF46-484D-B44B-058A86799FE6@arm.com> Message-ID: References: <67163dc4bc2e44d3f70f9c49295b993663d2fd5a.1691575243.git.nicola.vetrini@bugseng.com> <0C30A959-AF46-484D-B44B-058A86799FE6@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Luca Fancellu wrote: > > On 9 Aug 2023, at 12:02, Nicola Vetrini wrote: > > > > Add a declaration for the variable 'init_ttbr' to resolve > > the violation of Rule 8.4 present in the associated source file 'mm.c'. > > > > No functional changes. > > > > Signed-off-by: Nicola Vetrini > > --- > > Reviewed-by: Luca Fancellu > > With: > > Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring up") > > If maintainers are ok Yes Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:16:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:16:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581321.909961 (Exim 4.92) (envelope-from ) id 1qTpb0-0003Zl-Bm; Wed, 09 Aug 2023 20:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581321.909961; Wed, 09 Aug 2023 20:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpb0-0003Ze-7y; Wed, 09 Aug 2023 20:15:54 +0000 Received: by outflank-mailman (input) for mailman id 581321; Wed, 09 Aug 2023 20:15:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpaz-0003ZY-2E for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:15:53 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88f89ec7-36f1-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 22:15:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6363C64313; Wed, 9 Aug 2023 20:15:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54E8BC433C7; Wed, 9 Aug 2023 20:15:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88f89ec7-36f1-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691612149; bh=X5BrOmy90ngq8WhBQ+nu64KlO6VYmdkoqXU0BuO/2AU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dX2XSnhJVCUF94ijuIPAKu30vOYR3wYeJZ6kRKyymW7/T3W8zVM2seW6Tmb6pD8C8 DHAQYMNyAQ7jv9cnF95ikfK70ZMizQtho8tKp1sMDvOqtyKBEpj2pJ0LR4svrXor5q d3XE2GQdcHGSHZugATGubfN4F7Y5m+wL6rtsftnLACnU1xKRxz435SGmWngPjRMjfF luxFjUwvbDJO81+x6ALAekQOo1pt+TpwkK1jwMxhgpnd12naWsqWCxjefOU/OEarca j6Z+lJh4UW8NFlWpFCoi/q47oALJtch14N7c+qQd2+jq1VJSW2FcQT88bkYWDRQpUn 2Z55CTirqBXsA== Date: Wed, 9 Aug 2023 13:15:46 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Nicola Vetrini , sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4 In-Reply-To: <30cd1bdb-be77-a192-eca7-6fcd60eca610@suse.com> Message-ID: References: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> <1cfa92d52d89b2013218cef1c518ab4d@bugseng.com> <30cd1bdb-be77-a192-eca7-6fcd60eca610@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Jan Beulich wrote: > On 09.08.2023 16:17, Nicola Vetrini wrote: > > On 09/08/2023 14:52, Jan Beulich wrote: > >> On 09.08.2023 13:02, Nicola Vetrini wrote: > >>> The additional header file makes the declaration for the function > >>> 'init_IRQ', defined in this file visible, thereby resolving the > >>> violation of Rule 8.4. > >>> > >>> No functional change. > >>> > >>> Signed-off-by: Nicola Vetrini > >>> --- > >>> xen/arch/x86/i8259.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c > >>> index 6b35be10f0..9b02a3a0ae 100644 > >>> --- a/xen/arch/x86/i8259.c > >>> +++ b/xen/arch/x86/i8259.c > >>> @@ -19,6 +19,7 @@ > >>> #include > >>> #include > >>> #include > >>> +#include > >>> #include > >>> #include > >> > >> A patch adding this #include has been pending for almost 3 months: > >> https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html > > > > So do you prefer going forward with that patch or this one (mentioning > > it > > in the additional commit context of course)? > > I would prefer using the much older patch, but of course this requires > someone providing R-b or A-b. Hi Jan, normally I'd be happy to do that but that patch makes other changes that I don't feel confident enough to Ack. For instance: + for ( offs = 0, i = pic_alias_mask & -pic_alias_mask ?: 2; + offs <= pic_alias_mask; offs += i ) pic_alias_mask is declared as unsigned int. From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:30:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:30:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581326.909971 (Exim 4.92) (envelope-from ) id 1qTpp2-00064S-JO; Wed, 09 Aug 2023 20:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581326.909971; Wed, 09 Aug 2023 20:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpp2-00064L-Fn; Wed, 09 Aug 2023 20:30:24 +0000 Received: by outflank-mailman (input) for mailman id 581326; Wed, 09 Aug 2023 20:30:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpp1-00064F-CS for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:30:23 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e5e6409-36f3-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:30:20 +0200 (CEST) Received: from mail-dm3nam02lp2044.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2023 16:30:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5006.namprd03.prod.outlook.com (2603:10b6:208:1a4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Wed, 9 Aug 2023 20:30:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 20:30:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e5e6409-36f3-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691613020; h=message-id:date:to:from:subject:cc: content-transfer-encoding:mime-version; bh=xEt8omjjwLTnL1JJwmidvyJpcJrZfGvSCisXkJKiNmE=; b=Pqz8bLeQ31Q766dpBlhcJdCO3wAXbc5iD9XkCLvskFTEbsR3HUMtQi+2 ShgP7pmygRxENF50l9iTYNaVUgKudqF40ubosSWiWD6VijqsTMrt43SAO 09Qqp4y5rpjNheFnCGfp1/zToVUfMiICSCphWfajAnSbsm49n/XnDb6HA c=; X-IronPort-RemoteIP: 104.47.56.44 X-IronPort-MID: 117724301 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4kvJgqjDrj62gNOmmctihhJeX161TREKZh0ujC45NGQN5FlHY01je htvUDvTa/vZZmX8f9p/Poixp0JSsZWAm4JrGwI6rHhjRSkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT7AePzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQDFCktawGnqtvr0eydE8o1qoMlD5LSadZ3VnFIlVk1DN4AaLWbGeDmwIQd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEvluSxWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTeLnrKIx2AT7Kmo7BQxKX2C3r8WAjHGlA9ltK 0ZI+yU+lP1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebT4g2 0KNntjpLSdyq7DTQnWYnp+LqRuiNC5TKnUNDRLoViMA6tjn5Y021RTGS445FLbv1oGpXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94ZcO51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:Llz5QK4Zva1kCEaAnQPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-Talos-CUID: =?us-ascii?q?9a23=3AVmNTdWo0CeFlnNVnONBXFdrmUdsZa13Y3VP9GhK?= =?us-ascii?q?pV0Awa+S5Dlmzo5oxxg=3D=3D?= X-Talos-MUID: 9a23:zEK7/AU6TjCLE3Pq/DL92DtZOMlU2qKRExgGo5UM58iLJRUlbg== X-IronPort-AV: E=Sophos;i="6.01,160,1684814400"; d="scan'208";a="117724301" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FZ7DqKcCxMbhNuY4JOU4MRtGh0wmOz3IpHWbSPqqMbZc1DhOqK863WOkzDHoslJlQxEphHi3pwUx5DTKNreLkdawNXNqr0jhs2geUBP2ZzNikAujBaximvzTNgnK6MYJl3z80Y9xWBWMdyC0EKR3G8NZtQmnJD/4UDUZaSjDxLPbziZYo58MixPu15FHxrl9DhyQPi9ghJZ79y3nq0ckX8CgZB/vOrXNFhI+TsOmBlgqfP+b49D8dtBQVSucGBH3W4Wk47p9yC+tDNhLxFJ75tRx7vb+OAhgaCFOTavPAgCwJbuUxoroTmZL37ouH0ej8/PSDeXYOgpbqbJ19G/QxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xEt8omjjwLTnL1JJwmidvyJpcJrZfGvSCisXkJKiNmE=; b=JJDLNu8ch27kUEsDSePtZxMQEqpDvf35tYoYiyK3kuT8yM2B30kVOCOJVCZ2Rypbce/E50rIfn8j+GwkuWqo5PSW5fK29tTM12LHPSAvTKQknuQgQgbwfv3oV9qB8DigoHJOml+l76wJsyzzssdjWHLV0myVJpoKV7bdeqwJiBHtwKC9PkwdpVJnzgGB0Dxwo2TfqhDNAl//szDms7QeVsjg6agb+zad1X0NEyK0W5rh+/ANvUZy7Oi9pBXmjoUwiy+GnxeJdwbB9jvSeIN2ITIDNtepuQQTlIJGEowStCBIu/32kOFaRpO/mHcgg/6asfWbecpmRS3dgNDsJpkpdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEt8omjjwLTnL1JJwmidvyJpcJrZfGvSCisXkJKiNmE=; b=cLSqZoHO85nZ6DD0iNTiPfQoJ24SiBg22mKtQdDFhXE6VZA64knS1+2bZRLOTwHSqD1FbDpCuJ0+UY+uDQfVFzhn4XFMOFabC+yt8abDNuBfVHrUtgsqDmmi4xch2QeH5z+84Vo6MXtMPXjKuwgyWtXlX72xGQk+5w8N6QDy+6o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <9072ddad-3f79-42fa-1e6f-352c9796ea52@citrix.com> Date: Wed, 9 Aug 2023 21:29:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-GB To: xen-devel From: Andrew Cooper Subject: x86: AMD Zen1 Div leakage Cc: Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0536.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|MN2PR03MB5006:EE_ X-MS-Office365-Filtering-Correlation-Id: 30426746-a810-4ebf-5c64-08db9917687d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /E37xjhQwpCe70mYDzw4afaaqpjwO3RmV6fIT4zH/kou58KjfdT6B9v13HXUMCZa8LIOp7G0li3nArNEI11h3haJEdxja+L6SJSK1rvSHHP7aeRfRC+Me0nDKqiFgZ3JkEvr8gqHNwmhwoe8dWUUPcjjo/ZhK95svsz1K8PeyILuEM4jC2+p0KnHkNQyiM1lMVND6UuM3F2KW/1qhU4vOzDXuQq/eig5FtqKAaoaNORb7ncryjYyZmPqN1HV2Uast58kTFCF3fKRd/DUN9OYEoWaqqPtIuSkJn08y/9/ATs1Z0D2BTXkdH2/Os7VhuXKbA9KMHMPlLolLnSni5u6FXEzb/Jz7oTy6oCh2k19tcNj17q8+wABTj/0vRnx8WIX5WqkLBn4T7uhtO3mYL6jSkA1tobQ/m5Koiba2c7qVpFdBeaoMXJ0f+v1wfHdBLGqXrbAebjaJOZGhVjeplRZMpLZQc6rpr97Ymtg93vD0HiVWwAHjusJfuiHNANuQoJB1BtBU888W8Non8BzB9GYbAf5nNnUzwprU5jINsU3HwYIptdzwsZ0cSMVR5byusQv1TU8YQyrgdd4ww/IE4Bvpx2wYzfKy2QYk4UV0eb5BUTysGdg0BvIi87Ckm0YNmudH8NZPi2N415rN+VDXOlFbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(1800799006)(451199021)(186006)(6486002)(54906003)(6666004)(31686004)(478600001)(316002)(66556008)(66946007)(66476007)(4326008)(6916009)(83380400001)(31696002)(6512007)(2906002)(966005)(38100700002)(41300700001)(5660300002)(8936002)(6506007)(2616005)(36756003)(8676002)(26005)(86362001)(82960400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rjg1U1NzbWdNem5EWHRwUXlUSDA1R3R1cHl4NlRkbncxQlBvL2czYUF3MDdR?= =?utf-8?B?Qm1yaTdrZGRDQm9CbVZEVVZ6Y1JLcVFBdzQrZGd5SWE3aUx5Y0p4MWlxSjFa?= =?utf-8?B?YXNRWDV2bi81b2tFRkNiemJJWmp6T3hscVZyZ0VMVEhTTVAraUtyZG9xbFJm?= =?utf-8?B?aHVKaUlSYlhRenNQMm4zL1pObFVYZU5OWks0cWoxZS9yclF0WXlHT3QxazVO?= =?utf-8?B?N3hhbElpanRQUmR6WW90VkE1aE41Mmt2c0RjY0RBR2tSUWRILzRORHozcXZQ?= =?utf-8?B?NytrOUdqMWZaRjVRZlg1cmlka1pmM1FGV2tYdGFVOVNYdlMyOFgxT3dIU2RF?= =?utf-8?B?WjFaRXhrSC9rTHlGeE95dVJxb0RSZHoxWnlrM25la3dxb2g3dUhUbDZYVUFQ?= =?utf-8?B?V01CMG5lZUZtV1JwNklsQmoyVWtaRjdkRUc3dXRTRFlJblVBZ2NKOXVuYmYx?= =?utf-8?B?cnZEQUI3MDlBQ2pUUUZhN3F2ZGM2VXdBVXlMa0orRGtxaS8vTS8xS3MveC9C?= =?utf-8?B?NWxyNHNIL3RqUVY5Ui9XcjhhUkxQeEx2UlcxWnE4WnF1NmJEbC9HelBjMWFV?= =?utf-8?B?MllTNUZKYjZFay8vNVZsSmIwNGsvaHJtQVQ0SUFNVFlZWVRhRk5EakgxRTd3?= =?utf-8?B?UkpZNUpzNFcranVudlZMWjFWQjFUY3ZGMElmNTdXZ2RpaW8yVXZFUmVJOHR0?= =?utf-8?B?UTNKQTlMMnJIV0hNU0FYN3l5Q0QySWVYb2hKZTh3aVA4SnpZN1kvaEE3Y2Jn?= =?utf-8?B?NFhiSW5CT3hwYWN3Qmdsa1JLTFJHNGcyWG9hN1RhSjRqU3hOM2cycTJKTTdC?= =?utf-8?B?QUZ6ajVlbTB1KzJ0NlNqaDR4V3FwUUxGUnBZSHRFb2hKYXB1ZFZONjZvREVG?= =?utf-8?B?ekFBc01xZ1BjWjZBRlFRMVZIVy9iUW5aRjlNa3doM0hCcXdidWtpY2ZZZ0Jj?= =?utf-8?B?ME9iM0k5ZVZramxoKzNZTjdEeCtrZHhhR2ZQNEgzdHdJcWhZV1ppaUlaTDlC?= =?utf-8?B?bDZabTdhenVqQmE3ODV6YzFVNU1LS3dMYmZTK2FkRnNKUUxQalpDaEFvWDNR?= =?utf-8?B?QnZGY0oxNmtVTXNhTEo1RmhPRGJFMlRENHJPN2hRU1YwVitueWxGRmhkUjhK?= =?utf-8?B?ZERhVExCK3dsakZoWHNXNnlNOHNzT3VSSmIwOW03b1dXRktGQ0x4Rm5ScWNQ?= =?utf-8?B?ZjhFU2VnOVN2UmJtTXNYTXBaVXNqVTVYV1pPV0VxSlIxTkFhekU5aDF6OGNE?= =?utf-8?B?NU83QXhNUEdWVVVrYURWdGpuelhLNVZIM2FvWHRwRmFHRERPQVRicC9rVVFB?= =?utf-8?B?SnRhMWxUUE84OW91bk5LeXdsK2xpYnIxWGlrVmlSeW9BVjFPNkFxbWpRaWxJ?= =?utf-8?B?NXQ5WGxPeVhGSWdGOE5mZ0p5YlFlTXgwc1V4MG85YjNRbDQyM0xGM1ZJWmFD?= =?utf-8?B?MHpSbnFkb2ZIeEs0Q3NJU2RKRlBGWGd5SkRLL0pIZXl5MWx2aExTeDUvQ0lm?= =?utf-8?B?dnZsNGljRlpoc0xmVU8zQUZ3SFMxWTl5bzlUZXJzQTJ2elpmZ1VJRlJBbXRC?= =?utf-8?B?MEZMbzZYNTIyZ3p3aGxFSWdJNUxYL3hZY2xGakFaZ2ExWC9mYzFHVU51V000?= =?utf-8?B?ZHJ2N1RRak5KUytTWFpjdkxnTkNnak8zcm01amR5WWViY0xZMjBxVU1FR2Rj?= =?utf-8?B?alBaa0N5NkZQNU1rUDBjY1p5ckVtUlIxNndvb01DWDcybExxMFhBS2pONXUz?= =?utf-8?B?VjVvVGJNTWQ2LzNQRVpyaEJUTXRHMTIyWk1Lb0VjeDg2Y2pUeEZZQ2dwKy9q?= =?utf-8?B?ZzU1cTFUbXNORkNjS0dUN2dwTW04eUFaS3g0WWU5R2wyTDgzZWpuS0pyV1hs?= =?utf-8?B?enpFUllYMExrUjNDR2l0OG90ZjZDc3JYUUM3Z2VDSUlRZWxic2pqbFRFaG1s?= =?utf-8?B?TWtOVkYvMWZnNXFmaWhzZVRDV0RrcFN2Q0ZrRmVSQVNqV25mdFNiQUFSMXZx?= =?utf-8?B?T2Z1d3EzUzZYbkp3WmdjRTFjOEVQWG5tL3h2cFo3dnpQckgrQzZ5S2VsSHVW?= =?utf-8?B?TkFpOXZuVXdHTDhjZTQ3WkdxZFphN09QSEdHY29BYUZsMTc5YWRBWXhwYUVz?= =?utf-8?B?cWRCcVJwZlFKbXBSWVZUNEhoTXFyTWNzWUwxOFpicVNLL1hZNUVoVjFxMVhS?= =?utf-8?B?S3c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: t9NjARMlp1Hh5Od7yVmYgx2KOm7vlHyYMYG9v1loMsyz/s1/zLwIdo6ABPj+WT87cN/5TcPod5ZeLba/xk/It1n6d2p60dnHTeua2wGt6HGgZYFe8FX0rufWHypGrsEaGk6ZjFQWo1r7TzXrHnaZ+lWMgx+mvIZ7/gFCNR+5MZ9upu3Y15ODEJzRozEyT2wH/YAqJ/MtKpLZKgmYWprowqbHQ0cq8SB7r0u2dUrXYO6WhF/URmFB4rbLaZBkSfTTqLtpkswAFBtr9E4Rt3dYlWTKpO/tKC8VWyifJ/AIOCscaYk0TjP3gfpd4RZGvb+zMnnkGZeHMQE+OP0rEhyykZ5Mfy1zkU86bMM5k56G8v1rEW7056GWzxo7ABeblpxlFSrd84xbHwOlHYNwFospP6Ug9D8mQH9PBSWLc2+8kS87J0afOIrk4neYJEojYNOQZVPk0jIGXZ/kmw/muF5nbJ5CFfLq6bXYf25OcbwWrecXnuIj6CqkPs3psqsco24WOkPqlVmF2Q+7nyEg18qP4Oe47cCvkqhcav8E54+mivoR5gSAobKOA7A0e+pKn2ptZ/5ZFdBSYpj78Hh6KGivec3GwFbK0HigKd+7AarMyJyhxKozGgPqG7eVHH87a4c4WKA9VfWfQ7jn9rTkQZd/Z0xtAiFIiW2asMO4W5eNMYXoWfKoQgAW/DcrUaNbHxxl2sFYl+bS7+Hy+5qdbgzggPLfoD5XUHQ5Ou50hb8jED1XUXNmiR5OZghsct1pFvuV6g83yCA0rYesbFvGGr8A0HF0hSJRg1z2rdf3BmElVbd8hQ80quh/lRrZaecNyS43 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30426746-a810-4ebf-5c64-08db9917687d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 20:30:02.8064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N+wnOubV/F4i/KpGEhJ6w+M9HhmF00qCl2q84wv7Di9PQxMD1wogUmtVDQfaZJ6AQtPg01wD+flahN4qQ4pc5rPorsKRpJyb1GtOd1ZwjHg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5006 This popped up with insufficient time to organise a response before the pile of fixes yesterday. https://www.amd.com/en/resources/product-security/bulletin/amd-sb-7007.html Per my current understanding: * There is a single integer divider in a Zen1 pipeline.  When SMT is active, it services uops from both threads. * It latches the result of the last calculation performed, but forwards said result transiently in the case of #DE (i.e. meltdown-like). If this is accurate, then there's a nice covert channel between the two threads, where they can communicate by issuing specific divides, without ever leaving userspace.  (It's easy to hide a #DE in the shadow of some other misprediction, and not suffer a real divide exception.) But, div isn't a serialising uop, so the advice of "don't divide secrets" is tantamount to useless.  Transient execution can pick up a div uop from any misaligned instruction, and end up caculating on arbitrary operands. In SMT=0 cases, we can scrub in Xen by executing 0 / 1, and would need to go in the same place as VERW on Intel (i.e. very late in the return-to-guest path). In SMT=1 cases, I can't see any fix.  It's very much like L1TF/MDS, and cooperating threads can snatch data a cycle or two after it was placed in the channel. As yet, I haven't started any patches to this effect, but it would be nice to have more clarity from AMD first. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:35:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581333.909980 (Exim 4.92) (envelope-from ) id 1qTptk-0006jh-8P; Wed, 09 Aug 2023 20:35:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581333.909980; Wed, 09 Aug 2023 20:35:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTptk-0006ja-5k; Wed, 09 Aug 2023 20:35:16 +0000 Received: by outflank-mailman (input) for mailman id 581333; Wed, 09 Aug 2023 20:35:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpti-0006jU-6B for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:35:14 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3cf908bb-36f4-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 22:35:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CC2D648CA; Wed, 9 Aug 2023 20:35:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B551C433C7; Wed, 9 Aug 2023 20:35:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cf908bb-36f4-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691613310; bh=d8m+bEzzXs7EYuIc1E122NeHbdYRXYN5o9QCFt3vJS0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EQbgfblMcF2TYFdiO3C6iuq51jWa8J2U0BkGP0QOKlVpVHj4jLBxjMYaoDTl2ZlPu v5kYhxxLNOdWP4FqYCYIXkRUfPp8nWd4eSEh4k919CUr15yVScx7v0tQHrHcyFOjv3 GU+YiGu9OtvqTR6nheS/K9q6KRlmhHDM8h0QfmAcpNMBXyaRY6b0uQxjVj7dB2q53i 4KNAPeKzP9KG593s1lldePddwpBtKghlsHoJy9BRnBcm3hrpKZXoOqSKFtTfZ4lAbt LG8u5Ict6gs8E68PfDRHkHnpbsq0uWqOvE+gBa1Cnh7O38xQyslGvm8BjTm1ANbZwf OFI8nZFTVYw1Q== Date: Wed, 9 Aug 2023 13:35:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Xen-devel , julien@xen.org, Bertrand.Marquis@arm.com Subject: Re: MISRA violations in hypercall-defs In-Reply-To: <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> Message-ID: References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Jan Beulich wrote: > On 09.08.2023 01:22, Stefano Stabellini wrote: > > On Tue, 8 Aug 2023, Jan Beulich wrote: > >> On 08.08.2023 10:47, Federico Serafini wrote: > >>> Hello everyone. > >>> > >>> I would like to to ask your opinion about the auto-generated file > >>> xen/include/xen/hypercall-defs.h which contains some violations of > >>> MISRA C:2012 Rule 8.3: > >>> "All declarations of an object or function shall use the same names and > >>> type qualifiers". > >>> > >>> Such violations can be seen at the following links > >>> (copy and paste the link on you browser, including also the characters > >>> after the '#'): > >>> > >>> - arm > >>> https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/ARM64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} > >>> > >>> - x86 > >>> https://saas.eclairit.com:3787/fs/var/local/eclair/XEN.ecdf/ECLAIR_normal/origin/staging/X86_64-Set1/218/PROJECT.ecd;/by_service/MC3R1.R8.3.html#{"select":true,"selection":{"hiddenAreaKinds":[],"hiddenSubareaKinds":[],"show":true,"selector":{"enabled":true,"negated":false,"kind":2,"children":[{"enabled":true,"negated":false,"kind":0,"domain":"file","inputs":[{"enabled":true,"text":"xen/include/xen/hypercall-defs.h"}]}]}}} > >>> > >>> Some of the violations are due to mismatches on the return types > >>> and the use of `ret_t`. > >> > >> We already said that ret_t will need deviating. For parameter names > >> it ought to be possible to suitably rename, like done elsewhere. Whether > >> that means renaming in the generator script or in the definitions likely > >> again needs judging on a case-by-case basis. > > > > Is it the case that ret_t is purposedly defined as 'long' for 64-bit x86 > > guests and 'int' for 32-bit x86 guests? > > Yes. > > > I am asking because it looks like we don't use ret_t at all on ARM and > > on the public interfaces. > > And I wonder how you get away with this. Aiui hypercall return values are > 32-bit on Arm32, so I'd expect you to be at risk of truncation issues in > a limited set of cases (see in particular the bottom of compat_memory_op(), > where out-of-range values are saturated rather than truncated). But maybe > in practice this can't happen? Yes I think that must be it. Also consider that mixing 32/64 environments on ARM is rare: the arm32 version of Xen is mostly to run on arm32 targets with only 32-bit guests. The arm64 version of Xen is to run on arm64 targets with mostly (only?) 64-bit guests. Which is a different situation compared to x86. So the ret_t deviation would only affect the x86 version of the hypervisor. P.S. Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today it is not clarified) 32-bit guests on a 64-bit ARM hypervisor? From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:38:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:38:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581338.909991 (Exim 4.92) (envelope-from ) id 1qTpwi-0007Nw-Mv; Wed, 09 Aug 2023 20:38:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581338.909991; Wed, 09 Aug 2023 20:38:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpwi-0007Np-Jn; Wed, 09 Aug 2023 20:38:20 +0000 Received: by outflank-mailman (input) for mailman id 581338; Wed, 09 Aug 2023 20:38:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpwh-0007Nj-Do for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:38:19 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaf98a46-36f4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:38:17 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1448D64882; Wed, 9 Aug 2023 20:38:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8DDDC433C8; Wed, 9 Aug 2023 20:38:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf98a46-36f4-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691613495; bh=lbkZflBp5itVPUsoazTbfLX47M0+8ic4rZjA+np+dKM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mHodPuq8Er/sBgHvQTuaHzFQ+13imLk4e1L34YKKkRyeuLCoY0Kc1qHypPI27Vrzg jzL/oxWqFOYWNurydkWD5vdmdaLGz1uJKyoDiykTAcSbhCiJOV4v3av9kxVy+AQraI LrymAVerXFHKM/HdbEX9JW0JQX4H/cuH62Qwhc2lfXfGe9UwL633uAmEuG6N0FOmje C5YvENi4Lzx8/66cELXJFyjXuUqMQPdWtq1dELvy3uRkd7D7BeCuftM9JJwrbeI6Pu Dv/T7lQ8Vc5sJDoQp6IyzzKRu2tyvuWBrdLhmqTaNrPryFq/fzPfZIZz0cVmuX6KD2 B2G0zcXUbw9+A== Date: Wed, 9 Aug 2023 13:38:13 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 3/3] automation/eclair: update analyzed builds In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Simone Ballarin wrote: > The xen build for ARM64 now has new configuration options which > require to be defined: this patch defines them. > > In both configuration files some no longer true comments have been removed. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini (By the way, there is a way to start a Xen default kconfig from a seed config so that we don't necessarely need to specify all the options. The missing options are filled with default values.) > --- > automation/eclair_analysis/xen_arm_config | 14 ++++---------- > automation/eclair_analysis/xen_x86_config | 9 --------- > 2 files changed, 4 insertions(+), 19 deletions(-) > > diff --git a/automation/eclair_analysis/xen_arm_config b/automation/eclair_analysis/xen_arm_config > index 26f5fcca41..ef140ceb73 100644 > --- a/automation/eclair_analysis/xen_arm_config > +++ b/automation/eclair_analysis/xen_arm_config > @@ -1,12 +1,3 @@ > -# File provided in > -# Re: Xen MISRA C: Source files in scope and out of scope > -# from: Stefano Stabellini > -# date: 6 giu 2023, 02:53 > - > -# > -# Automatically generated file; DO NOT EDIT. > -# Xen/arm 4.18-unstable Configuration > -# > CONFIG_CC_IS_GCC=y > CONFIG_GCC_VERSION=90400 > CONFIG_CLANG_VERSION=0 > @@ -34,7 +25,9 @@ CONFIG_HVM=y > CONFIG_SBSA_VUART_CONSOLE=y > CONFIG_ARM_SSBD=y > CONFIG_HARDEN_BRANCH_PREDICTOR=y > -# CONFIG_TEE is not set > +CONFIG_TEE=n > +CONFIG_OPTEE=n > +CONFIG_FFA=n > # CONFIG_STATIC_SHM is not set > # end of Architecture Features > > @@ -47,6 +40,7 @@ CONFIG_ARM64_ERRATUM_819472=y > CONFIG_ARM64_ERRATUM_843419=y > CONFIG_ARM64_ERRATUM_832075=y > CONFIG_ARM64_ERRATUM_834220=y > +CONFIG_ARM64_ERRATUM_1508412=y > CONFIG_ARM_ERRATUM_858921=y > CONFIG_ARM64_WORKAROUND_REPEAT_TLBI=y > CONFIG_ARM64_ERRATUM_1286807=y > diff --git a/automation/eclair_analysis/xen_x86_config b/automation/eclair_analysis/xen_x86_config > index d497814e01..abc44d43e1 100644 > --- a/automation/eclair_analysis/xen_x86_config > +++ b/automation/eclair_analysis/xen_x86_config > @@ -1,12 +1,3 @@ > -# File provided in > -# Re: Xen MISRA C: Source files in scope and out of scope > -# from: Stefano Stabellini > -# date: 6 giu 2023, 02:53 > - > -# > -# Automatically generated file; DO NOT EDIT. > -# Xen/x86 4.18-unstable Configuration > -# > CONFIG_CC_IS_GCC=y > CONFIG_GCC_VERSION=90400 > CONFIG_CLANG_VERSION=0 > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:38:47 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:38:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581340.910001 (Exim 4.92) (envelope-from ) id 1qTpx9-0007pp-17; Wed, 09 Aug 2023 20:38:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581340.910001; Wed, 09 Aug 2023 20:38:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpx8-0007pi-TZ; Wed, 09 Aug 2023 20:38:46 +0000 Received: by outflank-mailman (input) for mailman id 581340; Wed, 09 Aug 2023 20:38:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTpx8-0007pW-7T for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:38:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb7726e5-36f4-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 22:38:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B9EB364935; Wed, 9 Aug 2023 20:38:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6428BC433C7; Wed, 9 Aug 2023 20:38:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb7726e5-36f4-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691613523; bh=UTenjmu6K4fpcMAKpBRCNNjzOwB2Mfar1dpF5re/vTk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fEMtWfpHVGYnExTwrOddUxtPoZ5tIN/baS6kRKU8txc+Wa0TZedkeNZOg9/D/SxXY rIyPIKdhi44iaMhKr77zXifNkvlf9+QQ/+vn922FDdm/7QEz/18eq6hGz4Ge9/n3vw EVgdm+OMFhgNtBXcOAkTO4UjNAv+Ctk9HM0/ZUHLKcschLSG/IEcDdIOM2wRzcLFdE 6iFhud1fL/GARNY0tPZVECF9hxPnZKOuC9HV1kNDqL/+oXImje1HLmdwX8oF2KOTAQ 4BDRqAD8qJXH0EFG2Tgk16DGahAH1AlhJt2FYUWG5HfPmdmzXCLVW96ve57qjHh1I6 mQxVyahvSUI8A== Date: Wed, 9 Aug 2023 13:38:41 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 1/3] automation/eclair: update clean guidelines In-Reply-To: <89e4ad4c56c083391b24b9da55212e888c5f3beb.1691568344.git.simone.ballarin@bugseng.com> Message-ID: References: <89e4ad4c56c083391b24b9da55212e888c5f3beb.1691568344.git.simone.ballarin@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Simone Ballarin wrote: > This patch splits the former list in two separate selectors > clean_guidelines_common and additional_clean_guidelines. > > clean_guidelines_common contains the guidelines that are clean > in both the analyzed builds, instead additional_clean_guidelines > is popolated depending on the current one. > > The following clean guidelines have been added: > - MC3R1.R1.1; > - MC3R1.R1.3; > - MC3R1.R3.1; > - MC3R1.R4.1; > - MC3R1.R17.4; > - MC3R1.R22.6; > - MC3R1.D4.3 (just x86_64); > - MC3R1.R5.3 (just arm64); > - MC3R1.R7.2 (just arm64); > - MC3R1.R8.6 (just arm64); > - MC3R1.R9.3 (just arm64). > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini > --- > automation/eclair_analysis/ECLAIR/tagging.ecl | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl > index ef2e56e186..3f589fd716 100644 > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl > @@ -28,7 +28,20 @@ > #################### > > -doc_begin="Clean guidelines: new violations for these guidelines are not accepted." > --service_selector={clean_guidelines,"^(MC3R1\\.D1\\.1|MC3R1\\.D2\\.1|MC3R1\\.D4\\.11|MC3R1\\.D4\\.14|MC3R1\\.R1\\.4|MC3R1\\.R2\\.2|MC3R1\\.R3\\.2|MC3R1\\.R5\\.1|MC3R1\\.R5\\.2|MC3R1\\.R5\\.4|MC3R1\\.R6\\.1|MC3R1\\.R6\\.2|MC3R1\\.R7\\.1|MC3R1\\.R8\\.1|MC3R1\\.R8\\.5|MC3R1\\.R8\\.8|MC3R1\\.R8\\.10|MC3R1\\.R8\\.12|MC3R1\\.R8\\.14|MC3R1\\.R9\\.2|MC3R1\\.R9\\.4|MC3R1\\.R9\\.5|MC3R1\\.R12\\.5|MC3R1\\.R17\\.3|MC3R1\\.R17\\.6|MC3R1\\.R21\\.13|MC3R1\\.R21\\.19|MC3R1\\.R21\\.21|MC3R1\\.R22\\.2|MC3R1\\.R22\\.4|MC3R1\\.R22\\.5)$" > + > +-service_selector={clean_guidelines_common,"^(MC3R1\\.D1\\.1|MC3R1\\.D2\\.1|MC3R1\\.D4\\.11|MC3R1\\.D4\\.14|MC3R1\\.R1\\.1|MC3R1\\.R1\\.3|MC3R1\\.R1\\.4|MC3R1\\.R2\\.2|MC3R1\\.R3\\.1|MC3R1\\.R3\\.2|MC3R1\\.R4\\.1|MC3R1\\.R5\\.1|MC3R1\\.R5\\.2|MC3R1\\.R5\\.4|MC3R1\\.R6\\.1|MC3R1\\.R6\\.2|MC3R1\\.R7\\.1|MC3R1\\.R8\\.1|MC3R1\\.R8\\.5|MC3R1\\.R8\\.8|MC3R1\\.R8\\.10|MC3R1\\.R8\\.12|MC3R1\\.R8\\.14|MC3R1\\.R9\\.2|MC3R1\\.R9\\.4|MC3R1\\.R9\\.5|MC3R1\\.R12\\.5|MC3R1\\.R17\\.3|MC3R1\\.R17\\.4|MC3R1\\.R17\\.6|MC3R1\\.R21\\.13|MC3R1\\.R21\\.19|MC3R1\\.R21\\.21|MC3R1\\.R22\\.2|MC3R1\\.R22\\.4|MC3R1\\.R22\\.5|MC3R1\\.R22\\.6)$" > } > --reports+={clean:added,"service(clean_guidelines)"} > + > +-setq=target,getenv("XEN_TARGET_ARCH") > + > +if(string_equal(target,"x86_64"), > + service_selector({"additional_clean_guidelines","^(MC3R1\\.D4\\.3)$"}) > +) > + > +if(string_equal(target,"arm64"), > + service_selector({"additional_clean_guidelines","^(MC3R1\\.R5\\.3|MC3R1\\.R7\\.2|MC3R1\\.R8\\.6|MC3R1\\.R9\\.3)$"}) > +) > + > +-reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"} > + > -doc_end > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:43:44 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:43:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581348.910011 (Exim 4.92) (envelope-from ) id 1qTq1q-0000xW-IR; Wed, 09 Aug 2023 20:43:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581348.910011; Wed, 09 Aug 2023 20:43:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTq1q-0000xP-FA; Wed, 09 Aug 2023 20:43:38 +0000 Received: by outflank-mailman (input) for mailman id 581348; Wed, 09 Aug 2023 20:43:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTq1p-0000xJ-IX for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:43:37 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 691fea1b-36f5-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 22:43:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABB776494C; Wed, 9 Aug 2023 20:43:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5793AC433C8; Wed, 9 Aug 2023 20:43:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 691fea1b-36f5-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691613814; bh=GLEEEVzmf8c44IWFcXE8OXscGqPErXwfrxKkNNHH08w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JfZepUZl40TLsQ/+5TgU4Q6XYWjR60zej/WZ3ZiL2Cz/ZK384TI4fzuSPoPgWRBQ9 0GeT3S3SqkauvoUXmE/OAxb4y7vh3bLQEIS9uq7klCaByZWIFxZQbnX0r9lLyBQp2w HramWnKjIoDLKCsVsk+KICekSPFsDbka6jaTzVHdg8D2DtCA0cGGdooM8d2v6HOpSs M3h0Cfdln9MndlCmptpRztmJFGG2ae3KirGlGCEb11JaO2LLFjyuTCLR2FQpeNo2Az wkxkOf0tE8/eFGUivzZBRlRurfSFUtvVqk3JjMvmKExxhXmOMrBC352Y6yhh8VkwWA Rl5Y9Z8yKx39w== Date: Wed, 9 Aug 2023 13:43:32 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Simone Ballarin cc: xen-devel@lists.xenproject.org, consulting@bugseng.com, Doug Goldstein , Stefano Stabellini Subject: Re: [XEN PATCH 2/3] automation/eclair: add ECL deviations In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Simone Ballarin wrote: > This patch adds some deviations for the following guidelines: > Rule 2.1, Rule 5.3 and Rule 8.2. > > Signed-off-by: Simone Ballarin Acked-by: Stefano Stabellini Looking at the below, is there anything we should add to docs/misra/rules.rst to specify that we are adopting the MISRA rule but in a slightly different way? I am happy to make any necessary changes to docs/misra/rules.rst myself, but I would like to keep docs/misra/rules.rst consistent with deviations.ecl. It seems to me that maybe we should add a note about ASSERT_UNREACHABLE() and BUG() and similar for Rule 2.1. What do you think? Anything else that I am missing? > --- > .../eclair_analysis/ECLAIR/deviations.ecl | 34 ++++++++----------- > 1 file changed, 15 insertions(+), 19 deletions(-) > > diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl > index e1a06daf2f..696618b59e 100644 > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl > @@ -14,8 +14,13 @@ Constant expressions and unreachable branches of if and switch statements are ex > -config=MC3R1.R2.1,+reports={deliberate,"first_area(^.*is never referenced$)"} > -doc_end > > --doc_begin="Unreachability in the following macros are expected and safe." > --config=MC3R1.R2.1,statements+={safe,"macro(name(BUG||assert_failed||ERROR_EXIT||ERROR_EXIT_DOM||PIN_FAIL))"} > +-doc_begin="Unreachability caused by calls to the following functions or macros is deliberate and there is no risk of code being unexpectedly left out." > +-config=MC3R1.R2.1,statements+={deliberate,"macro(name(BUG||assert_failed||ERROR_EXIT||ERROR_EXIT_DOM||PIN_FAIL))"} > +-config=MC3R1.R2.1,statements+={deliberate, "call(decl(name(__builtin_unreachable||panic||do_unexpected_trap||machine_halt||machine_restart||maybe_reboot)))"} > +-doc_end > + > +-doc_begin="Unreachability of an ASSERT_UNREACHABLE() and analogous macro calls is deliberate and safe." > +-config=MC3R1.R2.1,reports+={deliberate, "any_area(any_loc(any_exp(macro(name(ASSERT_UNREACHABLE||PARSE_ERR_RET||PARSE_ERR||FAIL_MSR||FAIL_CPUID)))))"} > -doc_end > > -doc_begin="Proving compliance with respect to Rule 2.2 is generally impossible: > @@ -93,25 +98,11 @@ conform to the directive." > -doc_begin="The project adopted the rule with an exception listed in > 'docs/misra/rules.rst'" > -config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^READ_SYSREG$))&&any_exp(macro(^WRITE_SYSREG$))))"} > --config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^max_t$))&&any_exp(macro(^min_t$))))"} > +-config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^max(_t)?$))&&any_exp(macro(^min(_t)?$))))"} > -config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^read[bwlq]$))&&any_exp(macro(^read[bwlq]_relaxed$))))"} > -config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^per_cpu$))&&any_exp(macro(^this_cpu$))))"} > --doc_end > - > --doc_begin="The identifier 'fdt' is a widely-used name, for which no suitable > -substitute can be found. It is understood in 'xen/arch/arm/efi-boot.h' that the > -static variable 'fdt' cannot be confused with parameter names of the function > -declarations that are present in the file." > --file_tag+={efi_boot_h, "^xen/arch/arm/efi/efi-boot\\.h$"} > --config=MC3R1.R5.3,reports+={deliberate, "any_area(decl(kind(var)&&static_storage()&&^fdt$)&&any_loc(file(efi_boot_h)))"} > --doc_end > - > --doc_begin="The identifier 'start' is a widely-used name, for which no suitable > -substitute can be found. It is understood in 'xen/include/xen/kernel.h' that the > -extern variable 'start' cannot be confused with omonymous parameter names of the > -function declarations where that variable is visible." > --file_tag+={kernel_h, "^xen/include/xen/kernel\\.h$"} > --config=MC3R1.R5.3,reports+={deliberate, "any_area(decl(kind(var)&&linkage(external)&&^start$)&&any_loc(file(kernel_h)))"} > +-config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^__emulate_2op$))&&any_exp(macro(^__emulate_2op_nobyte$))))"} > +-config=MC3R1.R5.3,reports+={safe, "any_area(any_loc(any_exp(macro(^read_debugreg$))&&any_exp(macro(^write_debugreg$))))"} > -doc_end > > -doc_begin="Function-like macros cannot be confused with identifiers that are > @@ -179,6 +170,11 @@ const-qualified." > # Series 8. > # > > +-doc_begin="The following file is imported from Linux: ignore for now." > +-file_tag+={adopted_r8_2,"^xen/common/inflate\\.c$"} > +-config=MC3R1.R8.2,reports+={deliberate,"any_area(any_loc(file(adopted_r8_2)))"} > +-doc_end > + > -doc_begin="The following variables are compiled in multiple translation units > belonging to different executables and therefore are safe." > -config=MC3R1.R8.6,declarations+={safe, "name(current_stack_pointer||bsearch||sort)"} > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:55:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:55:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581361.910021 (Exim 4.92) (envelope-from ) id 1qTqCs-0002Ym-Ih; Wed, 09 Aug 2023 20:55:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581361.910021; Wed, 09 Aug 2023 20:55:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqCs-0002Yf-FO; Wed, 09 Aug 2023 20:55:02 +0000 Received: by outflank-mailman (input) for mailman id 581361; Wed, 09 Aug 2023 20:55:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqCr-0002WX-0Y for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:55:01 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0086e657-36f7-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 22:54:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 3653A828538F; Wed, 9 Aug 2023 15:54:58 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id usqnpS88QlFm; Wed, 9 Aug 2023 15:54:55 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id D03BD82856F5; Wed, 9 Aug 2023 15:54:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PnUMHGvrVBQm; Wed, 9 Aug 2023 15:54:55 -0500 (CDT) Received: from [10.11.0.2] (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 22566828538F; Wed, 9 Aug 2023 15:54:55 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0086e657-36f7-11ee-b281-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com D03BD82856F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691614495; bh=zHXCCnOOWO7/rMYgzVXLYuRN9Jt9vZQbfdwIISnfup4=; h=Message-ID:Date:MIME-Version:To:From; b=kiV3x0gRXnlAS9zV6imJ9vcMgD4y2zSWngAgbpziNzB7s/Tve75im7WMejaPm2jLr 92CxvqwTF8ae/AF4E2h5XoKfdoFvNX7jreXFEn9xGQFqonsq7qfsQ/FXCWJgKeLUSA apDoWxbtigB/YDagSm35TGD6Ig+1dQlQ93WQjvQQ= X-Virus-Scanned: amavisd-new at rptsys.com Message-ID: Date: Wed, 9 Aug 2023 15:54:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/3] xen/ppc: Implement initial Radix MMU support Content-Language: en-US To: Jan Beulich Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <55e1391e-a289-72bd-f663-62276cf4b065@suse.com> From: Shawn Anastasio In-Reply-To: <55e1391e-a289-72bd-f663-62276cf4b065@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/23 8:18 AM, Jan Beulich wrote: > On 29.07.2023 00:21, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/bitops.h >> @@ -0,0 +1,11 @@ >> +#ifndef _ASM_PPC_BITOPS_H >> +#define _ASM_PPC_BITOPS_H >> + >> +#include > > Not a big deal, but ... > >> +/* PPC bit number conversion */ >> +#define PPC_BITLSHIFT(be) (BITS_PER_LONG - 1 - (be)) >> +#define PPC_BIT(bit) (1UL << PPC_BITLSHIFT(bit)) >> +#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs)) >> + >> +#endif /* _ASM_PPC_BITOPS_H */ > > ... nothing here looks to require that #include. > Good point, I'll drop it. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/mm.h >> @@ -0,0 +1,19 @@ >> +#ifndef _ASM_PPC_MM_H >> +#define _ASM_PPC_MM_H >> + >> +#include > > This is included by xen/config.h, which in turn is included from the > compiler command line. > Thanks for letting me know. Will drop. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/page.h >> @@ -0,0 +1,178 @@ >> +#ifndef _ASM_PPC_PAGE_H >> +#define _ASM_PPC_PAGE_H >> + >> +#include >> + >> +#include >> +#include >> + >> +#define PDE_VALID PPC_BIT(0) >> +#define PDE_NLB_MASK 0xfffffffffffffUL >> +#define PDE_NLB_SHIFT 5UL >> +#define PDE_NLS_MASK 0x1f >> + >> +#define PTE_VALID PPC_BIT(0) >> +#define PTE_LEAF PPC_BIT(1) >> +#define PTE_REFERENCE PPC_BIT(55) >> +#define PTE_CHANGE PPC_BIT(56) >> + >> +/* PTE Attributes */ >> +#define PTE_ATT_SAO PPC_BIT(59) /* Strong Access Ordering */ >> +#define PTE_ATT_NON_IDEMPOTENT PPC_BIT(58) >> +#define PTE_ATT_TOLERANT (PPC_BIT(58) | PPC_BIT(59)) >> + >> +/* PTE Encoded Access Authority*/ >> +#define PTE_EAA_PRIVILEGED PPC_BIT(60) >> +#define PTE_EAA_READ PPC_BIT(61) >> +#define PTE_EAA_WRITE PPC_BIT(62) >> +#define PTE_EAA_EXECUTE PPC_BIT(63) >> + >> +/* Field shifts/masks */ >> +#define PTE_RPN_MASK 0x1fffffffffffUL >> +#define PTE_RPN_SHIFT 12UL >> +#define PTE_ATT_MASK 0x3UL >> +#define PTE_ATT_SHIFT 4UL >> +#define PTE_EAA_MASK 0xfUL > > Did you consider introducing just *_MASK values, utilizing MASK_INSR() > and MASK_EXTR() instead of open-coded shifting/masking? > I actually wasn't aware of MASK_INSR/MASK_EXTR when writing this. I've just looked into it though, and I don't think using them makes the code much cleaner. Specifically I'm looking at the implementations of `pte_to_paddr` and `pde_to_paddr` which both need to ensure that the returned value retains its original shift. For example, with pte_to_paddr, this change would be: - return be64_to_cpu(pte.pte) & (PTE_RPN_MASK << PTE_RPN_SHIFT); + return MASK_EXTR(be64_to_cpu(pte.pte), PTE_RPN_MASK) << PTE_RPN_SHIFT; In addition to updating the definitions of the *_MASK macros to include the right-most padding zeros. - #define PTE_RPN_MASK 0x1fffffffffffUL + #define PTE_RPN_MASK 0x1fffffffffff000UL I don't really think this is an improvement, so I'm tempted to keep the code as-is. If you feel strongly about the usage of MASK_{INSR,EXTR}, though, I could make the change. >> +#define PTE_XEN_BASE (PTE_VALID | PTE_EAA_PRIVILEGED | PTE_REFERENCE) >> +#define PTE_XEN_RW (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_WRITE | PTE_CHANGE) >> +#define PTE_XEN_RO (PTE_XEN_BASE | PTE_EAA_READ) >> +#define PTE_XEN_RX (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_EXECUTE) >> + >> +/* >> + * Radix Tree layout for 64KB pages: >> + * >> + * [ L1 (ROOT) PAGE DIRECTORY (8192 * sizeof(pde_t)) ] >> + * | >> + * | >> + * v >> + * [ L2 PAGE DIRECTORY (512 * sizeof(pde_t)) ] >> + * | >> + * | >> + * v >> + * [ L3 PAGE DIRECTORY (512 * sizeof(pde_t)) ] >> + * | >> + * | >> + * v >> + * [ L4 PAGE TABLE (32 * sizeof(pte_t)) ] >> + * | >> + * | >> + * v >> + * [ PAGE TABLE ENTRY ] >> + */ >> + >> +#define XEN_PT_ENTRIES_LOG2_LVL_1 13 /* 2**13 entries, maps 2**13 * 512GB = 4PB */ >> +#define XEN_PT_ENTRIES_LOG2_LVL_2 9 /* 2**9 entries, maps 2**9 * 1GB = 512GB */ >> +#define XEN_PT_ENTRIES_LOG2_LVL_3 9 /* 2**9 entries, maps 2**9 * 1GB = 512GB */ >> +#define XEN_PT_ENTRIES_LOG2_LVL_4 5 /* 2**5 entries, maps 2**5 * 64K = 2MB */ >> + >> +#define XEN_PT_SHIFT_LVL_1 (XEN_PT_SHIFT_LVL_2 + XEN_PT_ENTRIES_LOG2_LVL_2) >> +#define XEN_PT_SHIFT_LVL_2 (XEN_PT_SHIFT_LVL_3 + XEN_PT_ENTRIES_LOG2_LVL_3) >> +#define XEN_PT_SHIFT_LVL_3 (XEN_PT_SHIFT_LVL_4 + XEN_PT_ENTRIES_LOG2_LVL_4) >> +#define XEN_PT_SHIFT_LVL_4 PAGE_SHIFT >> + >> +#define XEN_PT_ENTRIES_LOG2_LVL(lvl) (XEN_PT_ENTRIES_LOG2_LVL_##lvl) >> +#define XEN_PT_SHIFT_LVL(lvl) (XEN_PT_SHIFT_LVL_##lvl) >> +#define XEN_PT_ENTRIES_LVL(lvl) (1UL << XEN_PT_ENTRIES_LOG2_LVL(lvl)) >> +#define XEN_PT_MASK_LVL(lvl) (XEN_PT_ENTRIES_LVL(lvl) - 1) >> +#define XEN_PT_INDEX_LVL(lvl, va) ((va >> XEN_PT_SHIFT_LVL(lvl)) & XEN_PT_MASK_LVL(lvl)) >> + >> +/* >> + * Calculate the index of the provided virtual address in the provided >> + * page table struct >> + */ >> +#define pt_index(pt, va) _Generic((pt), \ > > Earlier on I did ask about the minimum compiler version you require for > building the PPC hypervisor. Iirc you said about any, but here you're > using another feature where I'm not sure how far back it is available. > As indicated back then, it would be nice if ./README could gain > respective information. > I'm locally building with gcc 10 (shipped with Debian 11), and the Xen CI image for ppc64le builds uses gcc 11 I believe. _Generic and the other features I'm using are certainly available further back, but I haven't personally tested anything earlier. If there's no objections, I'm tempted to just codify gcc 10 as the minimum supported compiler version and leave it up to users if they want to try testing on earlier versions. >> + struct lvl1_pd * : XEN_PT_INDEX_LVL(1, (va)), \ >> + struct lvl2_pd * : XEN_PT_INDEX_LVL(2, (va)), \ >> + struct lvl3_pd * : XEN_PT_INDEX_LVL(3, (va)), \ >> + struct lvl4_pt * : XEN_PT_INDEX_LVL(4, (va))) >> + >> +#define pt_entry(pt, va) (&((pt)->entries[pt_index((pt), (va))])) > > As to style: Here (and elsewhere) you put unnecessary parentheses > around two of the three uses of the macro arguments. If you think you > want to keep it like that, feel free; in general we're recommending to > omit ones not really needed, to help readability. Otoh a little higher > up in XEN_PT_INDEX_LVL() parentheses are missing around va. > If possible I'd prefer to just leave it as-is. Unconditionally parenthesizing macro arguments seems less error-prone as a general policy, though I agree the latter two here are unnecessary. That said, the lack of parenthesis around va in XEN_PT_INDEX_LEVEL was definitely an oversight and I'll fix that. >> +typedef struct >> +{ >> + __be64 pde; >> +} pde_t; >> + >> +typedef struct >> +{ >> + __be64 pte; >> +} pte_t; >> + >> +struct lvl1_pd >> +{ >> + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_1]; >> +}; >> + >> +struct lvl2_pd >> +{ >> + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_2]; >> +}; >> + >> +struct lvl3_pd >> +{ >> + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_3]; >> +}; >> + >> +struct lvl4_pt >> +{ >> + pte_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_4]; >> +}; >> + >> +static inline pte_t paddr_to_pte(paddr_t paddr, unsigned long flags) >> +{ >> + return (pte_t){ .pte = cpu_to_be64(paddr | flags | PTE_LEAF) }; >> +} >> + >> +static inline pde_t paddr_to_pde(paddr_t paddr, unsigned long flags, unsigned long nls) >> +{ >> + return (pde_t){ .pde = cpu_to_be64(paddr | flags | nls) }; >> +} > > In these two, are you sure you want to demand all callers to only ever > pass in page-aligned addresses? > Fair point. Perhaps it would be best to mask the caller-provided address. >> +static inline paddr_t pte_to_paddr(pte_t pte) >> +{ >> + return be64_to_cpu(pte.pte) & (PTE_RPN_MASK << PTE_RPN_SHIFT); >> +} >> + >> +static inline paddr_t pde_to_paddr(pde_t pde) >> +{ >> + return be64_to_cpu(pde.pde) & (PDE_NLB_MASK << PDE_NLB_SHIFT); >> +} >> + >> +static inline bool pte_is_valid(pte_t pte) >> +{ >> + return pte.pte & be64_to_cpu(PTE_VALID); >> +} >> + >> +static inline bool pde_is_valid(pde_t pde) >> +{ >> + return pde.pde & be64_to_cpu(PDE_VALID); >> +} >> + >> +/* >> + * ISA 3.0 partition and process table entry format >> + */ >> +struct patb_entry { >> + __be64 patb0; >> + __be64 patb1; >> +}; >> +#define PATB0_HR PPC_BIT(0) /* host uses radix */ >> +#define PATB1_GR PPC_BIT(0) /* guest uses radix; must match HR */ >> + >> +struct prtb_entry { >> + __be64 prtb0; >> + __be64 reserved; >> +}; >> + >> +/* >> + * We support 52 bits, hence: >> + * bits 52 - 31 = 21, 0b10101 >> + * RTS encoding details >> + * bits 0 - 3 of rts -> bits 6 - 8 unsigned long >> + * bits 4 - 5 of rts -> bits 62 - 63 of unsigned long >> + */ >> +#define RTS_FIELD ((0x2UL << 61) | (0x5UL << 5)) > > I'm afraid I can't bring comment and #define together. Bits 0-3 are > 4 bits; bits 6-8 are only three. And I'd expect the lower ends of > the ranges to appear as shift counts in the expression. > Yes, I agree that this is confusing. For reference, this comment was verbatim copied from a comment in Linux[*] and I admittedly didn't pay as much attention to it as I did to the expression itself. As far as I can tell, the original author's intent was to use 1-indexed non-PPC-style bit numbering and wrote 0-3 instead of 1-3 as a mistake. Under this interpretation, the comment makes more sense as do the shift counts in the expression being off by one. I'll rewrite it to correct the mistake and use standard 0-indexing for bits. Something like: /* * We support 52 bits, hence: * bits 52 - 31 = 21, 0b10101 * RTS encoding details * bits 0 - 2 of rts -> bits 5 - 7 of unsigned long * bits 3 - 4 of rts -> bits 61 - 62 of unsigned long */ [*] arch/powerpc/include/asm/book3s/64/radix.h:radix__get_tree_size >> --- a/xen/arch/ppc/include/asm/processor.h >> +++ b/xen/arch/ppc/include/asm/processor.h >> @@ -133,6 +133,37 @@ struct cpu_user_regs >> uint32_t entry_vector; >> }; >> >> +static __inline__ void sync(void) >> +{ >> + asm volatile ( "sync" ); >> +} >> + >> +static __inline__ void isync(void) >> +{ >> + asm volatile ( "isync" ); >> +} >> + >> +static inline unsigned long mfmsr(void) >> +{ >> + unsigned long msr; >> + asm volatile ( "mfmsr %0" : "=&r"(msr) ); > > Why the &? This was in the original Xen 3.2 header that this function was taken from, but I agree that it seems strange. I'll drop it in v2. > Also nit: Missing blank between closing double quote and opening paren. > More instances of this below. > Will fix. >> + return msr; >> +} >> + >> +static inline void mtmsrd(unsigned long msr) >> +{ >> + asm volatile ( "mtmsrd %0" : : "r"(msr) ); >> +} >> + >> +#define mtspr(reg, val) asm volatile ( "mtspr %0,%1" : : "K"(reg), "r"(val) ) >> + >> +#define mfspr(reg) \ >> + ({ \ >> + unsigned long val; \ >> + asm volatile ( "mfspr %0,%1" : "=r"(val) : "K"(reg) ); \ >> + val; \ >> + }) > > Why #define-s here when higher up you successfully use inline functions? > This was a temporary thing that I meant to convert into a full function before committing but seem to have overlooked. Thanks for pointing it out. > Also (nit) blanks would again be nice ahead of the commas. > Will do. >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/regs.h >> @@ -0,0 +1,138 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. > > You have an SPDX line first thing - why the spelled out license? > Leftover from importing the header from Xen 3.2. Will drop. >> --- /dev/null >> +++ b/xen/arch/ppc/mm-radix.c >> @@ -0,0 +1,268 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +#include >> +#include >> +#include >> +#include > > Nit: Please sort headers whenever possibly; also ... > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > ... this group then. > I'll alphabetically sort both groups. >> +void enable_mmu(void); >> + >> +#define INITIAL_LVL1_PD_COUNT 1 >> +#define INITIAL_LVL2_LVL3_PD_COUNT 2 >> +#define INITIAL_LVL4_PT_COUNT 256 >> + >> +static size_t initial_lvl1_pd_pool_used; >> +static struct lvl1_pd __aligned(sizeof(struct lvl1_pd)) >> +initial_lvl1_pd_pool[INITIAL_LVL1_PD_COUNT]; >> + >> +static size_t initial_lvl2_lvl3_pd_pool_used; >> +static struct lvl2_pd __aligned(sizeof(struct lvl2_pd)) >> +initial_lvl2_lvl3_pd_pool[INITIAL_LVL2_LVL3_PD_COUNT]; >> + >> +static size_t initial_lvl4_pt_pool_used; >> +static struct lvl4_pt __aligned(sizeof(struct lvl4_pt)) >> +initial_lvl4_pt_pool[INITIAL_LVL4_PT_COUNT]; > > Can instances of these structures usefully exist and be not suitably > aligned? If not, having the types rather than the instances already > declare the necessary alignment would seem better to me. > I can't think of a scenario in which we'd want instances of these structures without alignment. I'll go ahead and apply the alignment to the struct definitions instead. >> +/* Only reserve minimum Partition and Process tables */ >> +#define PATB_SIZE_LOG2 16 /* Only supported partition table size on POWER9 */ >> +#define PATB_SIZE (1UL << PATB_SIZE_LOG2) >> +#define PRTB_SIZE_LOG2 12 >> +#define PRTB_SIZE (1UL << PRTB_SIZE_LOG2) >> + >> +static struct patb_entry >> + __aligned(PATB_SIZE) initial_patb[PATB_SIZE / sizeof(struct patb_entry)]; >> + >> +static struct prtb_entry >> + __aligned(PRTB_SIZE) initial_prtb[PRTB_SIZE / sizeof(struct prtb_entry)]; > > The situation is different here, as array here aren't embedded into > the type (being just single entries). > Right. >> +_Static_assert(sizeof(initial_patb) == PATB_SIZE); > > Is this really useful. And if so, why no similar check for prtb? > Furthermore BUILD_BUG_ON() would be better, playing again into what > the range of suitable compilers is for this to build. > This was a debug statement that I had inadvertently left in. I'll remove it. >> +static void __init setup_initial_mapping(struct lvl1_pd *lvl1, >> + vaddr_t map_start, >> + vaddr_t map_end, >> + paddr_t phys_base) >> +{ >> + uint64_t page_addr; >> + >> + if ( map_start & ~PAGE_MASK ) >> + { >> + early_printk("Xen _start be aligned to 64k (PAGE_SIZE) boundary\n"); >> + die(); >> + } >> + >> + if ( (uint64_t) phys_base & ~PAGE_MASK ) > > Why the cast? > I believe in an earlier revision of this code I had phys_base's type as void* or similar, so this is just a leftover that I forgot to clean up. I'll remove the cast. >> + { >> + early_printk("Xen should be loaded at 64k (PAGE_SIZE) boundary\n"); >> + die(); >> + } >> + >> + for ( page_addr = map_start; page_addr < map_end; page_addr += PAGE_SIZE ) >> + { >> + struct lvl2_pd *lvl2; >> + struct lvl3_pd *lvl3; >> + struct lvl4_pt *lvl4; >> + pde_t *pde; >> + pte_t *pte; >> + >> + /* Allocate LVL 2 PD if necessary */ >> + pde = pt_entry(lvl1, page_addr); >> + if ( !pde_is_valid(*pde) ) >> + { >> + lvl2 = lvl2_pd_pool_alloc(); >> + *pde = paddr_to_pde(__pa(lvl2), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_2); > > paddr_to_pde() doesn't mask off the top bits. Are you relying on > lvl2_pd_pool_alloc() using PIC addressing to get at the value it > then returns? > I'm not sure I understand the question here. The pointer returned by lvl2_pd_pool_alloc() will indeed have the top address bits set in accordance with the link address, even before paging is enabled because of the relocation code and jump to XEN_VIRT_START in patch 2. This is fine though, since I call __pa() to strip off these bits before passing it to paddr_to_pde. > Also this and the similar lines below look to be a little too long. > Yeah, I noticed this as well, but my understanding was that lines longer than 80 columns were permitted in cases where they don't hurt readability. In any case, I can fix this. >> + } >> + else >> + lvl2 = (struct lvl2_pd *) pde_to_paddr(*pde); > > This casts a physical address to a pointer; normally only virtual > addresses can be used this way. Could there be a helper added to > have such a dangerous-looking construct in (ideally) just a single > place? > Fair point. We already have __va() which will work due to the previously mentioned relocation code in patch 2 even before the MMU is enabled. I think it might make sense to use that. >> + /* Allocate LVL 3 PD if necessary */ >> + pde = pt_entry(lvl2, page_addr); >> + if ( !pde_is_valid(*pde) ) >> + { >> + lvl3 = lvl3_pd_pool_alloc(); >> + *pde = paddr_to_pde(__pa(lvl3), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_3); >> + } >> + else >> + lvl3 = (struct lvl3_pd *) pde_to_paddr(*pde); >> + >> + /* Allocate LVL 4 PT if necessary */ >> + pde = pt_entry(lvl3, page_addr); >> + if ( !pde_is_valid(*pde) ) >> + { >> + lvl4 = lvl4_pt_pool_alloc(); >> + *pde = paddr_to_pde(__pa(lvl4), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_4); >> + } >> + else >> + lvl4 = (struct lvl4_pt *) pde_to_paddr(*pde); >> + >> + /* Finally, create PTE in LVL 4 PT */ >> + pte = pt_entry(lvl4, page_addr); >> + if ( !pte_is_valid(*pte) ) >> + { >> + unsigned long paddr = (page_addr - map_start) + phys_base; >> + unsigned long flags; >> + radix_dprint(paddr, "being mapped to "); > > Blank line again please between declarations and statements. > Will fix. >> + radix_dprint(page_addr, "!\n"); >> + if ( is_kernel_text(page_addr) || is_kernel_inittext(page_addr) ) >> + { >> + radix_dprint(page_addr, "being marked as TEXT (RX)\n"); >> + flags = PTE_XEN_RX; >> + } >> + else if ( is_kernel_rodata(page_addr) ) >> + { >> + radix_dprint(page_addr, "being marked as RODATA (RO)\n"); >> + flags = PTE_XEN_RO; >> + } >> + else >> + { >> + radix_dprint(page_addr, "being marked as DEFAULT (RW)\n"); >> + flags = PTE_XEN_RW; >> + } >> + >> + *pte = paddr_to_pte(paddr, flags); >> + radix_dprint(paddr_to_pte(paddr, flags).pte, >> + "is result of PTE map!\n"); >> + } >> + else >> + { >> + early_printk("BUG: Tried to create PTE for already-mapped page!"); >> + die(); >> + } >> + } >> +} >> + >> +static void setup_partition_table(struct patb_entry *patb, struct lvl1_pd *root) > > __init? > Yes, good call. Will add. >> +{ >> + unsigned long ptcr; >> + >> + /* Configure entry for LPID 0 to enable Radix and point to root PD */ >> + uint64_t patb0 = RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_1 | PATB0_HR; >> + uint64_t patb1 = __pa(initial_prtb) | (PRTB_SIZE_LOG2 - 12) | PATB1_GR; >> + patb[0].patb0 = cpu_to_be64(patb0); >> + patb[0].patb1 = cpu_to_be64(patb1); >> + >> + ptcr = __pa(initial_patb) | (PATB_SIZE_LOG2 - 12); >> + mtspr(SPRN_PTCR, ptcr); >> +} >> + >> +static void setup_process_table(struct prtb_entry *prtb, struct lvl1_pd *root) > > __init? > Ditto. >> +{ >> + /* Configure entry for PID 0 to point to root PD */ >> + uint64_t prtb0 = RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_1; >> + initial_prtb[0].prtb0 = cpu_to_be64(prtb0); >> +} >> + >> +void __init setup_initial_pagetables(void) >> +{ >> + struct lvl1_pd *root = lvl1_pd_pool_alloc(); >> + unsigned long lpcr; >> + >> + setup_initial_mapping(root, >> + (vaddr_t) _start, >> + (vaddr_t) _end, >> + __pa(_start)); > > setup_initial_mapping(root, > (vaddr_t)_start, > (vaddr_t)_end, > __pa(_start)); > > (if flowing across multiple lines is needed / wanted) > I just checked and the line without flowing fits within exactly 80 columns, so I'll make that change. >> --- a/xen/arch/ppc/opal.c >> +++ b/xen/arch/ppc/opal.c >> @@ -1,8 +1,10 @@ >> /* SPDX-License-Identifier: GPL-2.0-or-later */ >> +#include "xen/compiler.h" > > Surely , but then neither this nor ... > This was accidentally added by my editor/clangd and was not my intention. I'll remove all change to this file in this patch. >> #include >> #include >> #include >> #include >> +#include > > ... this addition look motivated when nothing else changes in this file. > See above. > Also (I overlooked this in the earlier patch) all xen/ headers generally > want to come ahead of all asm/ ones. > I'll keep that in mind going forward and for the next time I have a valid reason to touch this file. >> --- a/xen/arch/ppc/setup.c >> +++ b/xen/arch/ppc/setup.c >> @@ -7,6 +7,8 @@ >> /* Xen stack for bringing up the first CPU. */ >> unsigned char __initdata cpu0_boot_stack[STACK_SIZE] __aligned(STACK_SIZE); >> >> +void __init setup_initial_pagetables(void); > > This needs to live in a header which is included both here and in the > file defining the function. > I see I already declared the function's prototype in mm.h. This was probably an oversight from before I added that. I'll drop the prototype from setup.c and include asm/mm.h instead. >> +static void tlbiel_radix_set_isa300(unsigned int set, unsigned int is, >> + unsigned int pid, unsigned int ric, >> + unsigned int prs) >> +{ >> + unsigned long rb; >> + unsigned long rs; >> + >> + rb = (set << PPC_BITLSHIFT(51)) | (is << PPC_BITLSHIFT(53)); >> + rs = ((unsigned long) pid << PPC_BITLSHIFT(31)); >> + >> + asm volatile ( "tlbiel %0, %1, %2, %3, 1" : >> + : "r"(rb), "r"(rs), "i"(ric), "i"(prs) : "memory" ); > > Nit: One too few indenting blanks (besides others that are missing). > Perhaps also better to pull the standalone : onto this second line. > Overall perhaps (also for line length) > > asm volatile ( "tlbiel %0, %1, %2, %3, 1" > :: "r" (rb), "r" (rs), "i" (ric), "i" (prs) > : "memory" ); > Will do. >> +void radix__tlbiel_all(unsigned int action) > > Is the double underscore in here intentional? > It matches the original Linux file from which this routine was imported (referenced in the file's top-level comment). As I understand it, this is meant to indicate a private function that shouldn't be called outside of radix-specific MMU or TLB code. As Linux's radix support code spans multiple files, a static function wouldn't work for that. > Jan Thanks, Shawn From xen-devel-bounces@lists.xenproject.org Wed Aug 09 20:55:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 20:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581363.910031 (Exim 4.92) (envelope-from ) id 1qTqD9-0002rr-1X; Wed, 09 Aug 2023 20:55:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581363.910031; Wed, 09 Aug 2023 20:55:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqD8-0002rk-Uw; Wed, 09 Aug 2023 20:55:18 +0000 Received: by outflank-mailman (input) for mailman id 581363; Wed, 09 Aug 2023 20:55:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqD7-0002nd-Uk for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 20:55:18 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09bdf0a9-36f7-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 22:55:15 +0200 (CEST) Received: from mail-bn8nam12lp2173.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2023 16:55:08 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5938.namprd03.prod.outlook.com (2603:10b6:303:9b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Wed, 9 Aug 2023 20:55:06 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 20:55:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09bdf0a9-36f7-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691614515; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=fJuHu8NqLd2az+NUbKq47zdtoWIH/ARDT/1veQidzZs=; b=KZRK8zrZBvXO2IfLMnV417E90owtkUE2arXyYqHrPiyucddxEdNb8XZd kK4W6mxpyYtnCHWsjg2LLJELq1gfuWuRmaCDtZGGmd+imB1+oAsjPelKz G2Xn+yONWI7u7GK8SiMviHHDcFv3tSSgUpXOzT1sQ5P9slK1IOHNqgqfY o=; X-IronPort-RemoteIP: 104.47.55.173 X-IronPort-MID: 121700303 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YLpS2a7DqB0R73jbc3VdVQxRtKnGchMFZxGqfqrLsTDasY5as4F+v jAbCzqAOK2MZ2PyKtBxaY639UkHsMCEy95rSABspX0xHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPaAT7QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m1 /5JIhwnMza6gM2SmJCXabc33ekMI5y+VG8fkikIITDxK98DGMqGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OkUooj+OF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNtITeLgrqUy2zV/wEQXA0ZOc2DgpMOV1B/5fP9QB RAm0Qkx+P1aGEuDC4OVsweDiF6JuAQNHeVZFeIS4RuIjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+fqja3JC4UMX5EYCYCRAQI+fHzrYcrlBXNQ91/VqmvgbXdGzv93 jSLpygWnKgIgIgA0KDT1VLahzOhoLDZQwhz4R/YNkq+9R9wboOhY42u6HDY4OxGIYLfSUOO1 FAultKC9ukIAdeonTaUXeQWNLiz4rCONzi0vLJ0N5wo9jDo8Xjze4lVuWt6PB0wbZ1CfiL1a kjOvw8X/IVUIHahca5wZcS2Ftguyq/jU9/iU5g4c+ZzX3S4TyfflAkGWKJa9zmFfJQE+U3nB aqmTA== IronPort-HdrOrdr: A9a23:rqpfX6tW/fQXk4Y85cCGx0UB7skDSdV00zEX/kB9WHVpmwKj5r mTdZUgpGfJYVMqMk3I9urwXZVoLUmsl6KdpLNhXotKPzOGhILLFvAH0WKK+VSJcBEWtNQ86U 4KSdkYNDSfNykdsS842mWF+hQbreVvPJrGuQ4W9RlQcT0= X-Talos-CUID: 9a23:GNtpkm2M4ZkQLzT17SVUP7xfOMJ0eFH3kVHpJGCcUURFa+POEnK/9/Yx X-Talos-MUID: 9a23:9nRbwgZnJJwvkeBTszS33BdZb8JSz/r/T2cgnrtaieKnKnkl X-IronPort-AV: E=Sophos;i="6.01,160,1684814400"; d="scan'208";a="121700303" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+OpxoCU97OqkkPLAQvtXbtneEcIto+H3XZZZ+GUyq6CVWjmew7YBTw5SNH5aoU2PjY6eodalcR9fNQpk5s4oxhpkzuqRGjtKX6XsDPi6Scb59vuQmypT0NPlxgCp369Sh/WFw4ZTl1rXeb4ITwXqe+8YWcexiOZAG3xMItgfItX2+gfelPTZ327WU4v8gjgJtpW2Z9Kji7TdEbvnTgcwV3RDrZq41M2Q5Y3M28HaBS3XAPnI9rEST9x6YpmxkDMnQsj4/hLni7hR6eIDeDxC4Dms/k6yWyqJRzlGe9R3AdiaokVQiFHswIm1fGr8VEz/KT7VPx88ookJ/GPiqgJUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJuHu8NqLd2az+NUbKq47zdtoWIH/ARDT/1veQidzZs=; b=aEnLWOn4MkqRJhQbzEb2v01DBYO6jjruIsMlw0/Qf0Nn1vgNM946vESI6YnJN3erx0IEoLgHx4F2vnExFRJtrDI52x62skUgDOV5BRBPqSdFIJkOd0gO1G1YW6x2s01+LJQTYMDrQhCDOfTzjbMeVZJgf0uzPUu71Ia99z4yeSVopSfGsUVtfFr0gO3AvWvXTtxmdDN4gCsvwyUuc32ujgvXS8BUJOnQAC6gnX0jANxPvN3RI6Xv0vZQPjUj/Uq+OyWqyP1zVMWie6HOyZ49tVdIzgHN4nNCkMKzxCRcRASPYNCvRFPP+5RMyJDslmx7pL9XbFMMtRJ9eUQ1cgSb3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJuHu8NqLd2az+NUbKq47zdtoWIH/ARDT/1veQidzZs=; b=C+yZJlmkARBWrcklJ00A718yDXf2aes+TGUtHv8+Rpz0h/dFwo4mTm26uP6a1AKIQ/AkxL3BBZhSQ/8mB+aKMajAimoQeYU3UpFT+vwHYl8zE8v+MZeAesyfSToUd72Sf7vyeeFC4TzAhdW/Nm3AP3v6kwsoowAiNkuLsSb4iMc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 9 Aug 2023 21:54:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: Xen 4.18 release: Reminder about last posting date Content-Language: en-GB To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , "sstabellini@kernel.org" , Bertrand Marquis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0256.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|CO1PR03MB5938:EE_ X-MS-Office365-Filtering-Correlation-Id: b3d9b78e-d673-4cb6-583d-08db991ae84d X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kDWHdpIqZklk1ortUTwDg2l8rxGlsYqMnw8F8+J8sz7xwChzJjEkBJFBc1IbBuYNwHWRAvSGvDED3FWXR+vUdFgUid2AXI/03KL8cTMlGTgScMkcd49gLa4SQwJgIAfUjLYxww7BoyfOCpDWpIv0ejJ4GpuDbm3NsrSTjmgxs9GFUK8ToqYJ/v4NAsjYMObAAtinXKC71crXnw2MNBhGScMJ65s7FvOH9t40Zy7pd80u0i18JluIYoepUxhMgOaR6etMV7tfDtZLP6l1ww/uVTitAGXzXnas8xn3VCkNENxuZZkiMXEbCku6MbzHAU0IcitihFdq5gUrL0fs7C5li6oHoRyCcymS4G/ucbK+IhdAsFjC3i1SrCytRmMVHbYSXyaEHnBjpsL57opYfaFPi9JRfA2nNIjBV0qD7PwCIwVMUIkOnSHjGm+XLuxfqSVTN7px2O7Yff4aVmy1IA5UFvL0V28Tzbqq7B30DlwSd1ayUZugPNu7jKTiskI0hOwpGXRr4gUD49juFXCovT2TCiP6yM1/MgQaytXK0IcyZJExX1CMs7JiaWZ7iOmpHcr4xLA3LQSp/jfNKseLRhAI8tS6/zoQ8vZIU2BS8rOE1rUMdfU0em2VbxaKZjHUCYrbKR3fNYswJp/n5s711EpewA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199021)(186006)(1800799006)(31686004)(8676002)(8936002)(2906002)(82960400001)(4326008)(66946007)(66476007)(66556008)(478600001)(45080400002)(110136005)(54906003)(41300700001)(316002)(5660300002)(31696002)(86362001)(6666004)(6486002)(966005)(6512007)(38100700002)(53546011)(6506007)(26005)(83380400001)(2616005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3JRSXlBSlFWZGVUcWptZmJ6YUhacEpkNjRHbUZjRkhzL2tTUUpaU1UyaUZ3?= =?utf-8?B?OUp5T0thR2pnTjlhM004YytRTjV5NmhjUGM3NW9MRFJOQlNSMmE2OW5PajBz?= =?utf-8?B?RHJIZHdWSG5aR0ZrRTN5NEVKMWRUZGFGc0gzRi9hVVRTTUNBNXdnWGxYL0lT?= =?utf-8?B?SjlkSFRHS3N0TU9za3V3TTdiOUlrZjhPRThDZXRVaStCKzB4Q2wzQzVrQjBZ?= =?utf-8?B?OVBPZVV1OU5DL0NoQWlYNkt1dGoyT09EdjY2NHJGbnRFbU52c2JmZ1lYandO?= =?utf-8?B?cksvZmYvMThCa0N3YUhGNFdzUDNvUzc5c0RVdEZNZXZCMStxdms3ZUpMSnBl?= =?utf-8?B?dFdCbXQ1VUY1UWFOKzFYdjB1YXJDSER2dTFWRnVCcU5BVXl2aytycEF4MWg1?= =?utf-8?B?R0RpZWtLSEczb09jcGFzWFFUcGZsUVBaVi9rRkJSQkQ3cmNYMXlBZHhIdUUv?= =?utf-8?B?N0h1RTYwRlFUUGdaQmlpelAwYXhwL1IwOGhsMS9JVmx6ck8rejl5NmZNMXJi?= =?utf-8?B?a2RrazBuYTRQNXNhSDRwU216Y0tGeEZNL29EaEJYeFczWUVIQ2VYVUlsU2ow?= =?utf-8?B?TXlyc280Qi9yN2NKaUx4R0R5dzV1YjNvdzJXeEwyUXlYcEg4SHAvbUJhNDZO?= =?utf-8?B?eUdyWlZaQ2ZrS0RSR2k5Y2Noa2xTRVo5ZmtNb3NBL3JJSmJ5eUhjUXQzbXVU?= =?utf-8?B?cWExZjFidnBmVUZXVStWK2R4V0VaMjFUSGEvczlaeVhqZW13S0ZQcWdVaTJm?= =?utf-8?B?RGxWaTFnS01JU01yY0NvTXVwNlJEYWlINUlUMUhhNDZOWG55SWJDU1dqbU5N?= =?utf-8?B?b1Q0Rzk2azY2Sms0KzJuYU1TNEFmM0xTSFBhYk1vaDRBOTFOQ3RUK3B5em5D?= =?utf-8?B?NXl2cXF5RlpldjF1OWd2S2g3dEpZNlppemtkU0hUNUl2TXFUbnVXZ0Y4aTBq?= =?utf-8?B?WFozZFExaVh5SW5BakR2SldvVXJOQzMzbkg5YVN6a0FUZGRxQUpsYjROREVB?= =?utf-8?B?ZGlJL015czNSQUQ1bFlYUFR4ZnRBVGNENW1zajFub244YlFHU0czMHEwd2p0?= =?utf-8?B?cENqOXJLMVYrQ0czWm5aTzBCOGJIRTZia3l5WlRoeVVSSlNYaUlZQ1V0RjZ2?= =?utf-8?B?Z3dpaDd1aFJDcEhRZkdybDFaWlA3RTN5UjZSa2QzUDNxN25oZGtZSE1JWjE5?= =?utf-8?B?aTBRSVhQbWRjTzFTWnVBQ3J3R2hYaWRWVDVvWlZSRDBHTENWbmRIelM5S2E1?= =?utf-8?B?QStRNzNnTTdGMjBCTFNwU0t1MXB6Y2xnQ3UrbllnejZXRlQ1ZmpOM0ZJOGFK?= =?utf-8?B?Q3NKdXNsbmlCOWEwTTRiNXZDNmlLRzdYOTFtY2RNSlFuMjVZU1NIL1VnWmJq?= =?utf-8?B?a0kxWW1RSmptbEdCd2Q3a0FNQmlqWlpPY1dMa2NpSUkxTmFObHM2WU9kckly?= =?utf-8?B?N1UzbytqR2J1eHlKTGM3UFhkTWlCRFJ6WVNyZGRvLzN0VE5sQ1JjdHFlcENk?= =?utf-8?B?enR6TnR5TEJIcU9iSWNSR205NnM3VHFUcGg5Zm5PcFRsS2txOFl1a0dGdXpj?= =?utf-8?B?TkVoL3QvcG9RZVQ4eFdlMlF6MHM1WmM3eDE0M3NtMnFLeTRKS2p6MTdMSUFQ?= =?utf-8?B?RWovTkFxai9Lc1NmNjB1ZWFUb0xJYXZRaXVzWUZMTVpGdnFXckQ3VWFwR1hN?= =?utf-8?B?NUVheFdCOGJNT3hOc3d4d01rdlhPYjg1N3hFWmNaNWxucFVQdFRiNExDM1gw?= =?utf-8?B?WjE0R1MzeTlBVUVZbDl0SDJIRGdCc3E1OUtuNHNyY0ZlcFh3NXFYb3FvZU1u?= =?utf-8?B?T0c3SmZWVXZiaXRzcUt2UjVGRWF2VGVxNEdNdmhWeHBtTHEzWW1nSUVXTS9o?= =?utf-8?B?bFJONUhxSkNZR0Z5dDB1dG9uTFEvZ3VxdWN3VDR3MHR5cko3TWFubitJQVRW?= =?utf-8?B?Umd3bElNQ1NQTFpacDJGeVJ2K3RtS2pnQVEvbmFYTkd3ckFQV3hKOUkweE9o?= =?utf-8?B?UGJxTUtQZmMzMU1MdlFQOUdEak8wQ2lVZ1NTMkRIV3dHN3VPQWloWTBzc0g5?= =?utf-8?B?dEVZVkQxQ2ZkUUlwMHZhcXdBT1QvRDk4ZGx0YnBxQlpzclFUMHZYREROZW1D?= =?utf-8?B?ejVXamVQeWdjU1p1Y0QrZ2kwQ3BrWkJIdTJnTUE0Z0hJR0FOU1dJdmg0WjVY?= =?utf-8?B?ekE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6L0SK6oEnNwOpTG8b9oCaFnN21p8HRRGBpb8DcP0l5bQt2+jJxpQtrUBgPcWNF1PgCX0PpuIJzFuCSZdeTlJCPjIudCExbkeNhhGy33vCT5IdOn1bV0wCBTLSPPfkZqFRcyH70MDSVn1F2cZroingNtU3f7uWINJni/7p630Fhjj0MamZWT6V/ci61+ZZATd2x179DCGkoDi6TDR1gOpjQgOOisX1Aut8PVcj8ncJt2avdHdMDIifZsCLIDPmt7jPzuB5+KN6tUv7eUKh77H1xZvFxOTY/FjUYSmZJDTmimlc3j798MpavNlt0wEdZDRAX1tyNc+K3xbVrjC2WdN83wiNWStsoKCJxD63Mi61pv44+AmVEKgDh/CMIKOv0fi2Ar0jFKePwoNIuNcO0Ut1tHh4nUMGyJRBMNz9j5MxcCNM5ZWo6KJUdZZ8j3ptQIu9E/0JX6VQ6Mwaq5a9Ak9UyNW2Xtvi0zkUt5db67dG3RHKIlpEbYR7PBszbZlggIHd279PTMDVvf5jllvM5kkV7TTtF4ay2RM+3gVfhXYI6C0OCOgUOLSlqwwR3Nlt66QVHV9rdMw2/A9Zaun84EZpNOPYqNGOhfO2D3I5y1vrmBnVAE9JMfaS03KHSkQ+opprPtd5YveGo+whT7h7nuRuxbHBonPndoVqVn5qbw+iOEIdKXHG22QPqumDRv5u914o10URIA5r3ne3t+B9xWj0zW+aLhmcL3YhphDIqsE/ikCvCRPcTmgWzb06n5ECmEbW6QaglOhpjn07NW8BU2tR2yeg/CWMh+uqgJID9w1mnXqisO9Pd4ZEwLarDOSnF7Uc2HPAB4kr3uBR9g6xnPhsFArqwdjiFp2Ih6xRjA5GZhW9GNThqswu3zUkExpUreGnSkTaCWunZojDdeyJOPj2TMBcXqVhqrWXAvMKL8TzDk= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3d9b78e-d673-4cb6-583d-08db991ae84d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 20:55:05.6101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3/kShmj3Ov0427yxnTaRWLTjHa/9v9YMARAWW1XnyHaS2wKtr7gaCHb1mhh8bPrfCSJenPHssRULD4TRKHiUn4duDfislX0ymfz0hzadaUM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5938 On 07/08/2023 2:24 am, Henry Wang wrote: > Hi everyone, > > Following the release schedule discussion in in April, I am sending this email > to remind that according to the release schedule [1], August 11 (this Friday) > will be the last posting date, when patches adding new features are expected > to be posted to the mailing list by this date. > > Also, note that we currently have 1 release blocker [2] which might need > some attention. > > [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ > [2] https://gitlab.com/xen-project/xen/-/issues/114 Off the top of my head. There are still unaddressed Gitlab bugs from the Eclair integration, and other Gitlab bugs (use of unstable containers) which I'd unwilling to let 4.18 be released with, given the pain we've had on the stable trees trying to keep CI working. There's the XENVERSION_* hypercall ABI truncation fixes which is a blocker for XenServer (I'm refusing to forward port a piece of technical debt when it needs fixing upstream). There's another thing on the back of Tuesday's mess which has technically been posted years ago - the proper eIBRS support, but I want to refresh and get sorted for 4.18.  I expect it to be an even bigger perf win than the ARCH_CAPS work was.  But I'm not going to have time to get that sorted this week. At this point, I'm hoping to squeeze in before RC1, along with some compelling perf numbers. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 09 21:21:01 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 21:21:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581377.910041 (Exim 4.92) (envelope-from ) id 1qTqbr-0006ei-2u; Wed, 09 Aug 2023 21:20:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581377.910041; Wed, 09 Aug 2023 21:20:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqbq-0006eb-W5; Wed, 09 Aug 2023 21:20:50 +0000 Received: by outflank-mailman (input) for mailman id 581377; Wed, 09 Aug 2023 21:20:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqbp-0006eV-CV for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 21:20:49 +0000 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a8def81-36fa-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 23:20:47 +0200 (CEST) Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 5DF4E218; Wed, 9 Aug 2023 21:20:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a8def81-36fa-11ee-b281-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 5DF4E218 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1691616044; bh=D3OCzS/TjQzlx859sDe4uhCo8ItizHSPamS05kU7M/E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NXwT7fNZt30FAE6/rsWNAIxKfZAnHdE0QNzpPAfTcuuLXJv/8sSeNpRi/YYa5NjJC JPc/pZIj2m1/iKfmCA6z6g2y88sFf4ZH/bH/4XDB2qcRK5jWAwzLmabxM5iXzuAYwc gdH4oIFqQIHil75Is17wCUwIlXkrwODoldc2N5n5BFNAkaN5JRNZKvsISIklyJvP2F 4+b3s2bgvKX3Qdk1NsvqoUWqBFM5kFpduA+bStZQdIeCWxvmzzb6PeCz24WoTHyNsu hckvkWe4mo+JyUGpbBEyCK3lFgQYmdeewhQkWR1ZSjYdvGexm2T+wCrOys5KDkkoTp DAFJ4ZWqDCc4Q== From: Jonathan Corbet To: Petr Tesarik , Stefano Stabellini , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Greg Kroah-Hartman , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Petr Tesarik , Andy Shevchenko , Hans de Goede , James Seo , James Clark , Kees Cook , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , "open list:SLAB ALLOCATOR" Cc: Roberto Sassu , petr@tesarici.cz Subject: Re: [PATCH v7 9/9] swiotlb: search the software IO TLB only if the device makes use of it In-Reply-To: References: Date: Wed, 09 Aug 2023 15:20:43 -0600 Message-ID: <87a5uz3ob8.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Petr Tesarik writes: > From: Petr Tesarik > > Skip searching the software IO TLB if a device has never used it, making > sure these devices are not affected by the introduction of multiple IO TLB > memory pools. > > Additional memory barrier is required to ensure that the new value of the > flag is visible to other CPUs after mapping a new bounce buffer. For > efficiency, the flag check should be inlined, and then the memory barrier > must be moved to is_swiotlb_buffer(). However, it can replace the existing > barrier in swiotlb_find_pool(), because all callers use is_swiotlb_buffer() > first to verify that the buffer address belongs to the software IO TLB. > > Signed-off-by: Petr Tesarik > --- Excuse me if this is a silly question, but I'm not able to figure it out on my own... > include/linux/device.h | 2 ++ > include/linux/swiotlb.h | 7 ++++++- > kernel/dma/swiotlb.c | 14 ++++++-------- > 3 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/include/linux/device.h b/include/linux/device.h > index 5fd89c9d005c..6fc808d22bfd 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -628,6 +628,7 @@ struct device_physical_location { > * @dma_io_tlb_mem: Software IO TLB allocator. Not for driver use. > * @dma_io_tlb_pools: List of transient swiotlb memory pools. > * @dma_io_tlb_lock: Protects changes to the list of active pools. > + * @dma_uses_io_tlb: %true if device has used the software IO TLB. > * @archdata: For arch-specific additions. > * @of_node: Associated device tree node. > * @fwnode: Associated device node supplied by platform firmware. > @@ -737,6 +738,7 @@ struct device { > #ifdef CONFIG_SWIOTLB_DYNAMIC > struct list_head dma_io_tlb_pools; > spinlock_t dma_io_tlb_lock; > + bool dma_uses_io_tlb; You add this new member here, fine... > #endif > /* arch specific additions */ > struct dev_archdata archdata; > diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h > index 8371c92a0271..b4536626f8ff 100644 > --- a/include/linux/swiotlb.h > +++ b/include/linux/swiotlb.h > @@ -172,8 +172,13 @@ static inline bool is_swiotlb_buffer(struct device *dev, phys_addr_t paddr) > if (!mem) > return false; > > - if (IS_ENABLED(CONFIG_SWIOTLB_DYNAMIC)) > + if (IS_ENABLED(CONFIG_SWIOTLB_DYNAMIC)) { > + /* Pairs with smp_wmb() in swiotlb_find_slots() and > + * swiotlb_dyn_alloc(), which modify the RCU lists. > + */ > + smp_rmb(); > return swiotlb_find_pool(dev, paddr); > + } > return paddr >= mem->defpool.start && paddr < mem->defpool.end; > } > > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index adf80dec42d7..d7eac84f975b 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c > @@ -730,7 +730,7 @@ static void swiotlb_dyn_alloc(struct work_struct *work) > > add_mem_pool(mem, pool); > > - /* Pairs with smp_rmb() in swiotlb_find_pool(). */ > + /* Pairs with smp_rmb() in is_swiotlb_buffer(). */ > smp_wmb(); > } > > @@ -764,11 +764,6 @@ struct io_tlb_pool *swiotlb_find_pool(struct device *dev, phys_addr_t paddr) > struct io_tlb_mem *mem = dev->dma_io_tlb_mem; > struct io_tlb_pool *pool; > > - /* Pairs with smp_wmb() in swiotlb_find_slots() and > - * swiotlb_dyn_alloc(), which modify the RCU lists. > - */ > - smp_rmb(); > - > rcu_read_lock(); > list_for_each_entry_rcu(pool, &mem->pools, node) { > if (paddr >= pool->start && paddr < pool->end) > @@ -813,6 +808,7 @@ void swiotlb_dev_init(struct device *dev) > #ifdef CONFIG_SWIOTLB_DYNAMIC > INIT_LIST_HEAD(&dev->dma_io_tlb_pools); > spin_lock_init(&dev->dma_io_tlb_lock); > + dev->dma_uses_io_tlb = false; ...here you initialize it, fine... > #endif > } > > @@ -1157,9 +1153,11 @@ static int swiotlb_find_slots(struct device *dev, phys_addr_t orig_addr, > list_add_rcu(&pool->node, &dev->dma_io_tlb_pools); > spin_unlock_irqrestore(&dev->dma_io_tlb_lock, flags); > > - /* Pairs with smp_rmb() in swiotlb_find_pool(). */ > - smp_wmb(); > found: > + dev->dma_uses_io_tlb = true; > + /* Pairs with smp_rmb() in is_swiotlb_buffer() */ > + smp_wmb(); > + ...and here you set it if swiotlb is used. But, as far as I can tell, you don't actually *use* this field anywhere. What am I missing? Thanks, jon From xen-devel-bounces@lists.xenproject.org Wed Aug 09 21:43:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 21:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581383.910051 (Exim 4.92) (envelope-from ) id 1qTqy3-0000vu-Sw; Wed, 09 Aug 2023 21:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581383.910051; Wed, 09 Aug 2023 21:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqy3-0000vn-QO; Wed, 09 Aug 2023 21:43:47 +0000 Received: by outflank-mailman (input) for mailman id 581383; Wed, 09 Aug 2023 21:43:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTqy2-0000vh-5a for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 21:43:46 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf8d7409-36fd-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 23:43:44 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8705D64A8A; Wed, 9 Aug 2023 21:43:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE0A2C433C8; Wed, 9 Aug 2023 21:43:40 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf8d7409-36fd-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691617422; bh=qy3g1xe0C13bmZblWwqNR7H1+t/fCpycJnO7iRGfc7Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=j8Dplpqah295g0lnfVn8vNMPOHMM9nlmMaSFkIFMaQYplD24Q3b2boruuVCXpSaUF CAlyaV/hksOhNkpCXMrj+JAHRI5CBQFppS3m63lM3dYOPXhHQyFAoM0qYH2un2+7qJ f4qVsK2EP1aW5gsXC3XmrGsOEz7Ku4/8sTs6SAQOvRlwJWAIK12/lEmXlphOA7XTRV 1OV5d21X/KCjt0g7dHLj38VLwnKUO53F2da5A1EB6OMOOF7EFZqCRt4enO+M1UIUb1 Dwe5aTE8zt5kEzpir1hSF73We9WR0OqA4W3MfDXYP8PTuGumAO0F4FdJuhFgdtj66b eqzAuyPzVe4ag== Date: Wed, 9 Aug 2023 14:43:39 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Henry Wang , "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Julien Grall , "sstabellini@kernel.org" , Bertrand Marquis Subject: Re: Xen 4.18 release: Reminder about last posting date In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Andrew Cooper wrote: > On 07/08/2023 2:24 am, Henry Wang wrote: > > Hi everyone, > > > > Following the release schedule discussion in in April, I am sending this email > > to remind that according to the release schedule [1], August 11 (this Friday) > > will be the last posting date, when patches adding new features are expected > > to be posted to the mailing list by this date. > > > > Also, note that we currently have 1 release blocker [2] which might need > > some attention. > > > > [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ > > [2] https://gitlab.com/xen-project/xen/-/issues/114 > > Off the top of my head. > > There are still unaddressed Gitlab bugs from the Eclair integration The bug you managed to find it is now fixed (commit e55146071de9). I am all for fixing Gitlab bugs so let me know if you find anything else! I am not aware of any other issue with Eclair at the moment. > and other Gitlab bugs (use of unstable containers) which I'd unwilling > to let 4.18 be released with, given the pain we've had on the stable > trees trying to keep CI working. That is fair enough. To make this more concrete and easier to track, the following would need to be changed to using stable containers: - .qemu-arm64 - .qemu-arm32 (I am not counting .qemu-riscv64) Andrew, is that what you meant? Am I missing anything? From xen-devel-bounces@lists.xenproject.org Wed Aug 09 21:51:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 21:51:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581389.910061 (Exim 4.92) (envelope-from ) id 1qTr5n-0002ST-LJ; Wed, 09 Aug 2023 21:51:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581389.910061; Wed, 09 Aug 2023 21:51:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTr5n-0002SM-HT; Wed, 09 Aug 2023 21:51:47 +0000 Received: by outflank-mailman (input) for mailman id 581389; Wed, 09 Aug 2023 21:51:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTr5m-0002SG-9v for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 21:51:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTr5i-0005CF-99; Wed, 09 Aug 2023 21:51:42 +0000 Received: from [54.239.6.185] (helo=[192.168.6.56]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTr5i-0000AL-12; Wed, 09 Aug 2023 21:51:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=5Rm0lE1tq8VCtXtig6KHKXIqLjZf2jl56CFbzjUNHN8=; b=qOv/KVjCb143/Xf8yvLA7kSo8T ATKPNXyLVWtrj7/7D6r6HqnKn1xBO+aUAgDbkle0xlRZToqFfS8iMD/NX3j9k5M0prcpJP0ih83vE lOMt93PBpkm1Mpcdy3v3lI7plcr5fqSVLipDEeDk/K3JkHTIaPlA57DSNNuyK5z/wlYI=; Message-ID: <0d7cabca-e0d5-4ab6-a16d-11da35e45149@xen.org> Date: Wed, 9 Aug 2023 22:51:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: MISRA violations in hypercall-defs Content-Language: en-GB To: Stefano Stabellini , Jan Beulich Cc: Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Xen-devel , Bertrand.Marquis@arm.com References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/08/2023 21:35, Stefano Stabellini wrote: > P.S. > Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today > it is not clarified) 32-bit guests on a 64-bit ARM hypervisor? I read your explanation above and I don't really understand why you would want to de-support it. This works pretty well and I am not aware of any issue right now to run 32-bit guest on 64-bit HW. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:06:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:06:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581396.910071 (Exim 4.92) (envelope-from ) id 1qTrJQ-0004Ar-VX; Wed, 09 Aug 2023 22:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581396.910071; Wed, 09 Aug 2023 22:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrJQ-0004Ak-Re; Wed, 09 Aug 2023 22:05:52 +0000 Received: by outflank-mailman (input) for mailman id 581396; Wed, 09 Aug 2023 22:05:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrJP-0004Ac-3r for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:05:51 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e468d388-3700-11ee-b281-6b7b168915f2; Thu, 10 Aug 2023 00:05:48 +0200 (CEST) Received: from mail-bn7nam10lp2109.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2023 18:05:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5580.namprd03.prod.outlook.com (2603:10b6:806:b0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Wed, 9 Aug 2023 22:05:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 22:05:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e468d388-3700-11ee-b281-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691618748; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=4PNHQ3QIFvXym8exbv2duveRtPtQM96yFsWD7UI869o=; b=TZhOz3vuMQ9rXYHY8MW8Qhdelrlo/u8eOubyDqBuh8ownvS0jovzm42s x6j8toU89GKFLaptsyGTkxiWMzRISTQO1DNeMsnGRX7syphtQpbNEJh+7 bizm78gWcT5/haCIHQ5dH07bFUuW+yQTZITNCC9bB75MGznTXWXcgEuNi 4=; X-IronPort-RemoteIP: 104.47.70.109 X-IronPort-MID: 118924847 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ywmgHqo+d6dk2ev3niyYAnLNlwFeBmKJZBIvgKrLsJaIsI4StFCzt garIBmDb6qKYjGkfNB+Po7j/B4G65fVyoNgTVFoqyg9QypEpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOzyhNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAB0pcg/ap8ub/IOQacU0p+kkCdvkB4xK7xmMzRmBZRonabbqZvySoPV+g3I3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+CraYKEEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6472gHDmjN75Bs+SUKe4qmkoXCERZFGD kY/5ScLtqto6xn+JjX6d1jiyJKehTYHQMZZGeA+7ACLy4LX7hyfC2xCSSROAPQGucksVHoV3 1mGt9rzAHpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LG6mwi8DzGC3hh TWDqiExiq87ncMNz7+8/13Mn3SrvJehZgw/6xjTX2mlxhhkf4PjbIutgXDZ8PJBIYCxXlSH+ n8elKC2xu0UEYuEkiDLZewXBayo/N6MKjiaillqd6TN7Byo8n+nOIpWvzd3IR4xNt5eIGe4J kjOpQlW+ZlfemOwarN6aJ6wDMJsyrX8EdPiVbbfad8mjoVNSTJrNRpGPSa4t10BWmB1+U3jE f93qfqRMEs= IronPort-HdrOrdr: A9a23:oanwGq2I7vpbOdaF3CkQkgqjBHYkLtp133Aq2lEZdPU0SKGlfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0AeVxelZhrcKqAeQeBEWmNQ96U 9hGZIOcuEZDzJB/LvHCN/TKadd/DGFmprY+ts31x1WPGVXgzkL1XYANu6ceHcGIzVuNN4CO7 e3wNFInDakcWR/VLXBOpFUN9KzweEijfjdEGc7OyI= X-Talos-CUID: 9a23:htX+D2O3eIcEru5DdQ176xc0M+0ZQ1b+4C/xDkidG2lSR+jA X-Talos-MUID: 9a23:NmHCaAXnBQhE6+Dq/CP1oXIyKexW2brtEWUHuooLntKHbzMlbg== X-IronPort-AV: E=Sophos;i="6.01,160,1684814400"; d="scan'208";a="118924847" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GcfpDi53g7l2eThGuyl4KaTRZsGZ8lg3TyxgbLpSAVr4hZABa9nLGbY+a3gpwBj0q6Wr6+7F1EskTwx0N/vlp78gsvM06B2wwvxlCHTKjQexvRFbcFlg2u+b0KRbCsZu4ZSlB5FARD3UyrlzQuN3VqWTjHdLa4ylYnMIQfZxNHZhROuKgsZT309mG/umt8Y2O0+uBcdFR7zFwOC/Utw6ttD5Zd9HZjg6ME5pL23cuflCvNRpxKSRQsguXY/Je8cQ2Rf+ImPp9G+28kiSGG5TtQF2h+8P63vVhLfL7CRPJ1SnXyKLB+ILmjTQ7zT8jNlOYcyVLTQIgetLOm9i6rI1Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4PNHQ3QIFvXym8exbv2duveRtPtQM96yFsWD7UI869o=; b=kBeIJ2duSB6/Cl+WyzUiNzR4g3Ma23doJCIL1uT4Dxn55+Md7Nax/ZzYfBZ4j4L6V4qp5eHCKZILI8bmX4sCKJedKJBGHMY9eIyAdTdQsRH6XHpVsWWdsQbxSRff/UFDxz9Dpfe44NFZKMoXA2Gm1zJuPIv+65lk7VEc6cYgUd7LnUa3nk00rwNy+Bz1uzX0G4wMJqxmU9wFEDKx7zqaE4Ux7+p2MtWrK1O52NhYT1nEZxF0s46tTOu8YKXmavxE44MkOWzX39cWWztqBB7oe0gcNlwnOgEHSw6MJuWJn3kD9r8or3Jk9hGWIZQe9lViQULbbTIflVHV4oFD5sI3JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4PNHQ3QIFvXym8exbv2duveRtPtQM96yFsWD7UI869o=; b=bm2xXN03NgoYqtGSsOdKlGzkCB0ONMXOJ2AHdsLJof2OmQ7FfxjuHXDEPiZtfYAl/o05M8xxAJ14d5v0p0WfUCWpuW/uYQAvCLWFjDstJobWVcsy791H+S5XLfYz6bsa1d7g0cQAPKGzDnvuO95vY4oTxHeS7ZqUo10lxujMUHc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: <1ac14ed0-d489-0efe-0b0c-200792a50fde@citrix.com> Date: Wed, 9 Aug 2023 23:05:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: Xen 4.18 release: Reminder about last posting date Content-Language: en-GB To: Stefano Stabellini Cc: Henry Wang , "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Bertrand Marquis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0412.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::21) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|SA0PR03MB5580:EE_ X-MS-Office365-Filtering-Correlation-Id: b1782737-f5bf-4955-de41-08db9924c54c X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /kOn0vrcUk6rBzMiIbPgxUb+jc4911v0lFnDkIuKDWz5Bm7jPzxUXSxlECf654v9ZD9eoibaz2Fez9EAMnn3xq4gX60/zPs6x0U80T/OyWOSFWoU5m9uPkU6EPBPtjxRtfsurWHUgQYHHeE0oiMGAWSamOoiDiiH9O6Wlj7n7xwT57Cpgq6EyPnKN7k/OmT6CMBkA4A/celExUlFSd4jWHjslbgvWehaY2uD++nAzf4OrGPi0twXHCsurJhrn0YLPVydInJrGfGACb6FK+2TJXYYRNS7XB3H9izFVwa0TTp620g653Krhk4afHyYkuv/QMuvK6mmXR8GwRgFTPCUl4pCJbS/jcs+AXYRjVUndD5tieNr4gkzFS3uhYWu191nuLJqrEwjc1m/jTknNV3qNaa+bAyeBq0JTYwsRxn5dGgIhaMLwRj3PBItfZ7DlTtcrRdmZCPQr7oYEnJFulE7i0h77vCyjmAN7DTDhFYOxyErGPyVablTSh7BS/KKxaeGsbePvRKyweeStO2ikGfkXFDpP0Y1DbjwAlE/pWz2smRe3lhZNPDiWZjgDdxxYMOw6/hItGZJzSsMdz77ODyp6tg9IucH+Ud8m1UkYP//AqtfxozbUzS3wpsVnWVCIOL9IFaE+0JsBUgP66RI7xpTig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(1800799006)(186006)(451199021)(31686004)(66946007)(66476007)(6916009)(54906003)(66556008)(6506007)(53546011)(26005)(45080400002)(6666004)(478600001)(36756003)(83380400001)(2616005)(41300700001)(316002)(6512007)(966005)(4326008)(6486002)(2906002)(86362001)(31696002)(8676002)(8936002)(82960400001)(5660300002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1ZHYVFMOGZ5QVAzbFFLenJ6UTBUWk0zSElqWFNOL1JCazFHOURhTDBLUVpD?= =?utf-8?B?aUxzZFNGSDI4bVpOSnlGNTQrTVZhSitCOWtYNExKa2pYYzJ0YUpyVDVZSXNl?= =?utf-8?B?SXB2NFdlQStnQmFIRjJ3bnQvVzIvalpFdExXK0duZXFpUWV5YllsY1RKdzR1?= =?utf-8?B?NFJFb0ZWajREZm9FMHZRTEl2UUUxWHRGNTZ1ejlMY1RjUUsrMWNlWE0xMUFO?= =?utf-8?B?Z3d1WlR2VmhJTzQ3RUc4YklBQW11LzVZRkc1clg5OWpUOUJjSUoxL1U2alNz?= =?utf-8?B?cmRjbnhXdjFnTW5iOGJRZUphVjZnQjZFSExFK092NHpBbU1DV1JJaU9QUnJl?= =?utf-8?B?R3luZ3RLR3BPRkFocU9LYkJIMGhDRDlpWFgrMTh2ZGdyMVpVMUZpbkI0L2xI?= =?utf-8?B?bnE5QmVVTXRZNDRldytURFpOUXp0VWYzUkxMR2gxcy82eTZPK1JXRm1zNFJ6?= =?utf-8?B?UnVqZUU3YVl2SFpJeWZGdlhLQ0xicjJ1RERuSzdqMllQU3pZa3ZTWklJSDh3?= =?utf-8?B?SXR3eU1lU3JTMjh6bG9VQ1FXUlF4bXhiOFpiRVRvNFV1MDdrbmNCYW54bGZ6?= =?utf-8?B?WmRJQm5zeDJqK0tEK2x6bVNkWHJYSkhJTGdVRkdEeS9kZWlTMG5NdklpV1dG?= =?utf-8?B?dUhrV0MzTUd5UFJyNHFGbUVCVjBOTnJRNTlZSWlkM0t2MjdHay9EUkZvWDBJ?= =?utf-8?B?eVloa3c0SU1GSGtpZ2VYY2pQL1dQalFSaS9wUFVBS3FSSFZPUEl6a212M1Ny?= =?utf-8?B?R3crZDE0Q3BDZExRblJIVDZjVExSbzB1NzE2dFRKWEJRVXRtanV2Y3lPT2dX?= =?utf-8?B?WHlYQ245WllJU3RCWUxybmxaMmJpaXFIVTZ6MTlpdDRCR1Zxc2lBTHNVSTFW?= =?utf-8?B?QldRYVU4clZXYWtzaUI1TDJkR3JZV05hdDhqSUdBM0NON3J3RE9XQ0lTVE1Y?= =?utf-8?B?Q245NHBQRmdXekN5dmlpSjhCUEhKbHNvRU9ycjljWXNsYmI3TDFUczhBZXho?= =?utf-8?B?MksrQVhFVHA0cVE1aGk2cGN0VWJpTE1ubXZ5OTJoM01BRSszYWlWYjU3RWVQ?= =?utf-8?B?aHl3clJKVFBKWk9PeSthdUZZMDhSbUJReWp5dmxHSGZML2JEUnY1VU1jZUNu?= =?utf-8?B?a25VNWIrZkhpa1cxejFFS0o5V1JGbUtsOWdLWDRzYWtVeHIrblVYT0w3TEg5?= =?utf-8?B?MWdHZlJtK1RSVGpZVFlvOUtvL2d1TVMyOGlYdGQyV0RiaHMzS0dJdnlBQlF0?= =?utf-8?B?czZTNzhtTTMzMlFCNHROR3VlVjdMRmxDWWJLUklMeVZxRTAzOXY0THFhbUZi?= =?utf-8?B?aFpyY0JaeW9VNThjRVg1SmM1b25JOTlFbEJxb1Z5Wk1rUzVsTHFpVlUwQlJY?= =?utf-8?B?S1NpV0txSXZtdlZvQUdqakxQNlJ1dnlBdHBJZXZ2VW1MTTJCdjFvZXhhTUJm?= =?utf-8?B?NTlDVjFwU0VScEpBS2J1N05XSnMrc3JGK1pqd2l3K0wvVGlQQ0ZXQzZrejBz?= =?utf-8?B?dkM1a0hqck1CZld4M1dtbEJ0Skp5WlYxRFdjRVpBeVoyK2tpa0VjUGhiVElF?= =?utf-8?B?a20rWTFrd05pWVA4SHpIcGhKcWhQV3JvZDJUcmg0MVk3WmNEWlZMTVNzYjVr?= =?utf-8?B?TlhWZDcyQ1NTU2xaZWZLUHM4ZlVvbEhoRWgvdnBFZkxHZyt6Y0lGQ1FLU0FT?= =?utf-8?B?QzZOT2hBWWFMS1l4eWZzdy9CbElndWFyTjBSNTRCQjNFcjNuYkNFeStZVHJ5?= =?utf-8?B?WlBSM1FDY01ibmczcndzcTZJbFoyZ28rMHp0anJvRUk5OW44d3NnMXhoeWt2?= =?utf-8?B?V014VkthUWJvVis1Z3BXK0NpTlRzdDBFNnloTllMdG9KNVozQ0w2dXZGRHBF?= =?utf-8?B?M1ZmY09RMVprbGdpQUtobDlSd0J6UWkrZjVqcloxTFRsc2lCQ3N5T3ZGRDNw?= =?utf-8?B?VGYvRlRiQjZPZGNsK1Y2UkxRdWJNSlloMWJJOXVzRHdLT1I5bnhybTlPNEI1?= =?utf-8?B?d28wK0U3ZXlzcUQ2NVlvenRSSlFya2UzU09ha3Q0dzJHbDViNnU5d1VLMFdp?= =?utf-8?B?bU9rUFA4MkJrRVVIMWlGZnlFUzV1RVNPaHVxTExZcHVTdFNRS1B6T0ZoVGwv?= =?utf-8?B?aXJGV1NkNFF1Vm8rTEU2RnNVQUJ1aHI5V2ZkM2hYYURBOU9JanFGQm9WWE1q?= =?utf-8?B?NkE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XUHWlxCwKtfTPMzt3yZi+BnfcykH5th2DDa4Q9QJOArWN1/ObjyEuxnSL+agQIiSGz1sUTtV8ynTpOR10WkRlL1a2jK7H6mnfrWSX/wohz6KHqWrSMDRqphNyjOCgj/UuJH2/GpyT4tYiFVdomSH6NuSH5nCpkqKluwGfhc7cYtYoGMuWF0dZRXv8PJxPz3mnhpWLHEoj6jaHFM8hsMeXu1CEvln2M6D5XySqIo7vSbOVlx9/rBXXt9KWk+kzCzDvQ2kglbk2xszd4s8ERKN2hCbmEG1qFzFtc0htcLQv9ojSPJlB7Z1epk1I1R2HttgrBOvoQaS0Xg4cwO+7jPhJqd0hW0lKINH6SXkcXIcej2N2zfATrHzE04NoncnbtkMYGPE8OrcYG1w1Vh5winVIKaMTn6vg6xCoSMwqRSpFu9jYjFdkhR08bzpgSV4XfAGrOpa6Ds6VtB+VCzQWdkGPMJ49gdzZ5tz1+HycALa0LCVU7kbYfiFCzDlKko5+LXnncp2EJfqO7X0Clgiz+owomO62nEMQw+c/KyOfGhEV6MiwoigDnc5y38ynigLQ7i+WIWDKT4Mvv6yW8yM4rPOQT7iOQIoPcb9Y7bPbDYmG75SkkD/X0DE6xLcGwZsMR6AZZQ/9253bNKpZFF1JZcTde36l34FUCWMWCu0LklNQ0inpAtSHoaBElu0eeNALI4C4h+9JCrWX63USs92UyVBsBNXDCGXFqOQUmgAjuG+MkrDcx+MQVlPtGJJOdpLYb48+HXKQShO3+yPNlM6ukieqVPaW9ycQ3Z3CqUAHzE55b2SgQ6YkcnRZx/esVJ3AwNDiGP55+XRJlOjyp3RqknesjU2rOe7ce61jMCQ6q4Gxr0R9ZnuTScWbI6Tz5Flxchjl7NYNMcPP1yFWI2WCHKKUrf6vold+SsDYc2oV/etuVE= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1782737-f5bf-4955-de41-08db9924c54c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 22:05:41.3127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OqAprbj5GQokTOPntrsG0D2xSj9+xPGTQw54lIle8Ha0cpV1g6cGdWaD0yojqgngClfaYKZ1wBOrHs0+UY17IghYGnmNvUs/R2c2YQcDt4s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5580 On 09/08/2023 10:43 pm, Stefano Stabellini wrote: > On Wed, 9 Aug 2023, Andrew Cooper wrote: >> On 07/08/2023 2:24 am, Henry Wang wrote: >>> Hi everyone, >>> >>> Following the release schedule discussion in in April, I am sending this email >>> to remind that according to the release schedule [1], August 11 (this Friday) >>> will be the last posting date, when patches adding new features are expected >>> to be posted to the mailing list by this date. >>> >>> Also, note that we currently have 1 release blocker [2] which might need >>> some attention. >>> >>> [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ >>> [2] https://gitlab.com/xen-project/xen/-/issues/114 >> Off the top of my head. >> >> There are still unaddressed Gitlab bugs from the Eclair integration > The bug you managed to find it is now fixed (commit e55146071de9). I am > all for fixing Gitlab bugs so let me know if you find anything else! I > am not aware of any other issue with Eclair at the moment. I meant the one where Eclair is still running on `smoke` and twiddling its thumbs for 1h doing so each time OSSTest says yes to a push.  It will be a missing 'exclude' somewhere, but I haven't hand enough time to look. >> and other Gitlab bugs (use of unstable containers) which I'd unwilling >> to let 4.18 be released with, given the pain we've had on the stable >> trees trying to keep CI working. > That is fair enough. To make this more concrete and easier to track, the > following would need to be changed to using stable containers: > > - .qemu-arm64 > - .qemu-arm32 > (I am not counting .qemu-riscv64) > > Andrew, is that what you meant? Am I missing anything? Every debian unstable container, and the other containers (OpenSUSE) which are using an non-specific upstream version.  Upstreams which really are rolling distros (Arch, Tumbleweed) need to be made non-fatal. Then the second part which is also a blocker.  Update the distros we test with to be less obsolete.  e.g. the majority of our CI testing runs with Alpine-3.12 when EOL more than a year ago. (2022-05-01) ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:07:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:07:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581400.910081 (Exim 4.92) (envelope-from ) id 1qTrKY-0004gB-8j; Wed, 09 Aug 2023 22:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581400.910081; Wed, 09 Aug 2023 22:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrKY-0004g2-5X; Wed, 09 Aug 2023 22:07:02 +0000 Received: by outflank-mailman (input) for mailman id 581400; Wed, 09 Aug 2023 22:07:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrKX-0004eZ-D1 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:07:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e078489-3701-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 00:06:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE258632F6; Wed, 9 Aug 2023 22:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0F12C433C8; Wed, 9 Aug 2023 22:06:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e078489-3701-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691618815; bh=qN6DogoprZBKjEiveQbJCgpWVxtxZuRS60IAgAoeTUw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=j9UVmreC0gSBeyHRtAnmk1XzYstPfldY1jjXSlsG/JL2d2AOlDxpi1OngIstqNoJu PolojbBsI/l2TUSll7sMlMJKVFvbojqtWyRU+FvAwlNErflMEDy3P5bE/cxcNnbeiG 5wGtGVVL3XpZedeXgWROmPIy/FNsO1smMdaT/SMK2m62OPmvCx7cEGehN0jH4B5o/y lDTYUBo9K58Ktqkn+MM5mrzDeJPA6qfbLOOIEyF1LhN4STP5TJ+v2qH+JUE3m3zJ99 PE+OGcLrrI4ZOGGSTMEf7phHPkLnULPJlZV69M8OTP2CquRkgFX2HIT02/0M76DFe/ LN1lQUlxr7bMA== Date: Wed, 9 Aug 2023 15:06:52 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Jan Beulich , Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Xen-devel , Bertrand.Marquis@arm.com Subject: Re: MISRA violations in hypercall-defs In-Reply-To: <0d7cabca-e0d5-4ab6-a16d-11da35e45149@xen.org> Message-ID: References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> <0d7cabca-e0d5-4ab6-a16d-11da35e45149@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Julien Grall wrote: > Hi, > > On 09/08/2023 21:35, Stefano Stabellini wrote: > > P.S. > > Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today > > it is not clarified) 32-bit guests on a 64-bit ARM hypervisor? > > I read your explanation above and I don't really understand why you would want > to de-support it. This works pretty well and I am not aware of any issue right > now to run 32-bit guest on 64-bit HW. I am happy either way. The reason why I brought it up is that we don't have a specific test for this in gitlab-ci and Jan raised concerns that greater-than 32-bit values as possible as ret from hypercalls on a 64-bit build of Xen. From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581410.910109 (Exim 4.92) (envelope-from ) id 1qTrVB-0006g0-WF; Wed, 09 Aug 2023 22:18:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581410.910109; Wed, 09 Aug 2023 22:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrVB-0006eX-Qd; Wed, 09 Aug 2023 22:18:01 +0000 Received: by outflank-mailman (input) for mailman id 581410; Wed, 09 Aug 2023 22:18:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrVA-0006IW-Ha for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:18:00 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 974d6116-3702-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 00:17:57 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id B79B08285659; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YTb4zV7X71eC; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id E48B782853C6; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yzFT7O9onz5q; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 6DFC9828553F; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 974d6116-3702-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com E48B782853C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691619474; bh=7lQu3tplviyWuv7MQo2mgYjPtzmb7VZm3OD4gwUxqiA=; h=From:To:Date:Message-Id:MIME-Version; b=VvL9o1ClReLz/bt+qvkjSJzcGV7oM8idu5lNcfHWJOGNQd8xBtGsrOk8S1oDDk7cO 4aRyBGomRZZDes+y7iJLfRu7afMcgdIWwEdjKoEjuythZnD3TJI/Gj0B+MNmrxV9VT 1LE/JIATV39nXxFeVzQZMXPfZnNczLys0zJPeBrk= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v2 1/3] xen/ppc: Bump minimum target ISA to 3.0 (POWER9) Date: Wed, 9 Aug 2023 17:17:41 -0500 Message-Id: <85588932309900fc850be91c5fa7815463a7af7e.1691617957.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B from the supported ISA list to avoid having a non-working configuration in tree. It can be re-added at a later point when Hash MMU support is added. Signed-off-by: Shawn Anastasio --- v2: no changes. xen/arch/ppc/Kconfig | 7 +------ xen/arch/ppc/arch.mk | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/xen/arch/ppc/Kconfig b/xen/arch/ppc/Kconfig index b32dce39b8..ab116ffb2a 100644 --- a/xen/arch/ppc/Kconfig +++ b/xen/arch/ppc/Kconfig @@ -20,15 +20,10 @@ menu "ISA Selection" choice prompt "Base ISA" - default POWER_ISA_2_07B + default POWER_ISA_3_00 help This selects the base ISA version that Xen will target. -config POWER_ISA_2_07B - bool "Power ISA 2.07B (POWER8)" - help - Target version 2.07B of the Power ISA (POWER8) or later - config POWER_ISA_3_00 bool "Power ISA 3.00 (POWER9)" help diff --git a/xen/arch/ppc/arch.mk b/xen/arch/ppc/arch.mk index 3bf79bac37..d05cbf1df5 100644 --- a/xen/arch/ppc/arch.mk +++ b/xen/arch/ppc/arch.mk @@ -1,7 +1,6 @@ ######################################## # Power-specific definitions -ppc-march-$(CONFIG_POWER_ISA_2_07B) :=3D power8 ppc-march-$(CONFIG_POWER_ISA_3_00) :=3D power9 CFLAGS +=3D -m64 -mlittle-endian -mcpu=3D$(ppc-march-y) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581409.910101 (Exim 4.92) (envelope-from ) id 1qTrVB-0006Xa-Eq; Wed, 09 Aug 2023 22:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581409.910101; Wed, 09 Aug 2023 22:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrVB-0006XT-BZ; Wed, 09 Aug 2023 22:18:01 +0000 Received: by outflank-mailman (input) for mailman id 581409; Wed, 09 Aug 2023 22:17:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrV9-0006IW-Sc for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:17:59 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9717a99b-3702-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 00:17:57 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 60DAE8285C0F; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8dNL_78n-oFE; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 75BF78285659; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JS67M3ijrk3y; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id E9A8582853C6; Wed, 9 Aug 2023 17:17:53 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9717a99b-3702-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 75BF78285659 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691619474; bh=Sq0fNuH96kE7w+0/7R97Zwh45snqYHWhdAIxpNB8X5c=; h=From:To:Date:Message-Id:MIME-Version; b=ZVh9e0csRkxA0PZxiBHRoHW0i5aKMIL1y+Z9XhPHvodbIdBhMz/94vmsbQ3BPSzHs /s8XmouIpl+dDq/jBLrpytCjqlX07IAgZJTFK/ENZtEbc+9hbB2Buc+i64VewIK365 RxToglF14Vw2wpcURpmd0UDX9DT8C0qM7y7/xgYs= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v2 0/3] xen/ppc: Add early Radix MMU support Date: Wed, 9 Aug 2023 17:17:40 -0500 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hello all, This series adds support for bringing up the Radix MMU with basic identity-mapped page tables. In order to simplify the memory layout, the series changes XEN_VIRT _START to 0xC000_0000_0000_0000, which has a couple of convenient properties. When the MMU is off, the top 4 address bits are ignored by the hardware, so this is equivalent to physical address 0. When the MMU is enabled, the top 4 address bits are used to select the memory quadrant, and 0xC corresponds to quadrant 3 which is used for kernel memory. Thus, by linking the kernel here and ensuring its physical load address is 0x0, we are able to run at the correct address both before and after the MMU is enabled. Additionally, as the Radix MMU was only added in ISA 3.0 (POWER9), this series also drops support for POWER8 for now, to avoid having a non-working build configuration in-tree. Thanks, Shawn Shawn Anastasio (3): xen/ppc: Bump minimum target ISA to 3.0 (POWER9) xen/ppc: Relocate kernel to physical address 0 on boot xen/ppc: Implement initial Radix MMU support xen/arch/ppc/Kconfig | 7 +- xen/arch/ppc/Makefile | 2 + xen/arch/ppc/arch.mk | 1 - xen/arch/ppc/include/asm/bitops.h | 9 + xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/include/asm/mm.h | 18 ++ xen/arch/ppc/include/asm/page-bits.h | 3 +- xen/arch/ppc/include/asm/page.h | 178 ++++++++++++++++++ xen/arch/ppc/include/asm/processor.h | 34 ++++ xen/arch/ppc/include/asm/regs.h | 138 ++++++++++++++ xen/arch/ppc/include/asm/types.h | 1 + xen/arch/ppc/mm-radix.c | 268 +++++++++++++++++++++++++++ xen/arch/ppc/ppc64/head.S | 42 +++++ xen/arch/ppc/setup.c | 3 + xen/arch/ppc/tlb-radix.c | 96 ++++++++++ 15 files changed, 793 insertions(+), 9 deletions(-) create mode 100644 xen/arch/ppc/include/asm/bitops.h create mode 100644 xen/arch/ppc/include/asm/mm.h create mode 100644 xen/arch/ppc/include/asm/page.h create mode 100644 xen/arch/ppc/include/asm/regs.h create mode 100644 xen/arch/ppc/mm-radix.c create mode 100644 xen/arch/ppc/tlb-radix.c -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581411.910121 (Exim 4.92) (envelope-from ) id 1qTrVE-00074G-6u; Wed, 09 Aug 2023 22:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581411.910121; Wed, 09 Aug 2023 22:18:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrVE-000745-30; Wed, 09 Aug 2023 22:18:04 +0000 Received: by outflank-mailman (input) for mailman id 581411; Wed, 09 Aug 2023 22:18:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrVC-0006IW-F1 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:18:02 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98f7872f-3702-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 00:17:59 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id DE5C482853C6; Wed, 9 Aug 2023 17:17:58 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jflgPxlZXNrT; Wed, 9 Aug 2023 17:17:56 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id D9345828663A; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0CZNlI3_fxqW; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 33CE48285C34; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98f7872f-3702-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com D9345828663A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691619475; bh=jRQHtUUKl76Rh39J66PCy9Aw7hkCY8hDbofqLNMxf3g=; h=From:To:Date:Message-Id:MIME-Version; b=fBL6UOKFtQ0EzZ/XjXmnVsPFUXUwVaaQ8piO9JanMI2QoJ0O/mCTCqThqdY+0MGYf 1A+BM1P+7/dbsP1xnfsbAdBfDpMFyOQTxD83QVLTmxVc72rEXRtYobObRTM8QCJ4qE BoyzMouhbECcqzEyCk+qaNEneGUw/0PLpgGbaD44= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v2 3/3] xen/ppc: Implement initial Radix MMU support Date: Wed, 9 Aug 2023 17:17:43 -0500 Message-Id: <55621be668cdd13889fbbc251b74ae8e6e0af664.1691617957.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Add code to construct early identity-mapped page tables as well as the required process and partition tables to enable the MMU. Signed-off-by: Shawn Anastasio --- v2: - Add missing ')' to mm.h/maddr_to_virt definition - Add missing parens around `va` argument in XEN_PT_INDEX_LVL - Drop '&' asm constraint modifier in processor.h/mfmsr() - Fix asm constraint formatting in processor.h - Change mtspr,mfspr to functions in processor.h - Drop unnecessary _Static_assert in mm-radix.c - Drop unnecessary cast in setup_initial_mapping - Use __va() to obtain pde/pte addresses in setup_initial_mapping - Wrap >80col lines in mm-radix.c - Drop unnecessary parameters in setup_{process,partition}_table - Add __init to setup_{process,partition}_table - Drop unnecessary opal.c changes - Drop manual prototype of setup_initial_pagetables in setup.c in favor of using the one already in asm/mm.h - Fix formatting of tlbiel asm block in tlb-radix.c xen/arch/ppc/Makefile | 2 + xen/arch/ppc/include/asm/bitops.h | 9 + xen/arch/ppc/include/asm/mm.h | 18 ++ xen/arch/ppc/include/asm/page-bits.h | 3 +- xen/arch/ppc/include/asm/page.h | 178 ++++++++++++++++++ xen/arch/ppc/include/asm/processor.h | 34 ++++ xen/arch/ppc/include/asm/regs.h | 138 ++++++++++++++ xen/arch/ppc/include/asm/types.h | 1 + xen/arch/ppc/mm-radix.c | 268 +++++++++++++++++++++++++++ xen/arch/ppc/ppc64/head.S | 15 ++ xen/arch/ppc/setup.c | 3 + xen/arch/ppc/tlb-radix.c | 96 ++++++++++ 12 files changed, 764 insertions(+), 1 deletion(-) create mode 100644 xen/arch/ppc/include/asm/bitops.h create mode 100644 xen/arch/ppc/include/asm/mm.h create mode 100644 xen/arch/ppc/include/asm/page.h create mode 100644 xen/arch/ppc/include/asm/regs.h create mode 100644 xen/arch/ppc/mm-radix.c create mode 100644 xen/arch/ppc/tlb-radix.c diff --git a/xen/arch/ppc/Makefile b/xen/arch/ppc/Makefile index 0c0a7884a1..a059ac4c0a 100644 --- a/xen/arch/ppc/Makefile +++ b/xen/arch/ppc/Makefile @@ -2,8 +2,10 @@ obj-$(CONFIG_PPC64) +=3D ppc64/ obj-y +=3D boot-of.init.o obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.init.o +obj-y +=3D mm-radix.o obj-y +=3D opal.o obj-y +=3D setup.o +obj-y +=3D tlb-radix.o $(TARGET): $(TARGET)-syms cp -f $< $@ diff --git a/xen/arch/ppc/include/asm/bitops.h b/xen/arch/ppc/include/asm= /bitops.h new file mode 100644 index 0000000000..548e97b414 --- /dev/null +++ b/xen/arch/ppc/include/asm/bitops.h @@ -0,0 +1,9 @@ +#ifndef _ASM_PPC_BITOPS_H +#define _ASM_PPC_BITOPS_H + +/* PPC bit number conversion */ +#define PPC_BITLSHIFT(be) (BITS_PER_LONG - 1 - (be)) +#define PPC_BIT(bit) (1UL << PPC_BITLSHIFT(bit)) +#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs)) + +#endif /* _ASM_PPC_BITOPS_H */ diff --git a/xen/arch/ppc/include/asm/mm.h b/xen/arch/ppc/include/asm/mm.= h new file mode 100644 index 0000000000..c85a7ed686 --- /dev/null +++ b/xen/arch/ppc/include/asm/mm.h @@ -0,0 +1,18 @@ +#ifndef _ASM_PPC_MM_H +#define _ASM_PPC_MM_H + +#include + +#define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT) +#define paddr_to_pfn(pa) ((unsigned long)((pa) >> PAGE_SHIFT)) + +#define virt_to_maddr(va) ((paddr_t)((vaddr_t)(va) & PADDR_MASK)) +#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START)) + +/* Convert between Xen-heap virtual addresses and machine addresses. */ +#define __pa(x) (virt_to_maddr(x)) +#define __va(x) (maddr_to_virt(x)) + +void setup_initial_pagetables(void); + +#endif /* _ASM_PPC_MM_H */ diff --git a/xen/arch/ppc/include/asm/page-bits.h b/xen/arch/ppc/include/= asm/page-bits.h index 4c01bf9716..0286177520 100644 --- a/xen/arch/ppc/include/asm/page-bits.h +++ b/xen/arch/ppc/include/asm/page-bits.h @@ -2,6 +2,7 @@ #define __PPC_PAGE_BITS_H__ #define PAGE_SHIFT 16 /* 64 KiB Pages */ -#define PADDR_BITS 48 +#define PADDR_BITS 53 +#define VADDR_BITS 52 #endif /* __PPC_PAGE_BITS_H__ */ diff --git a/xen/arch/ppc/include/asm/page.h b/xen/arch/ppc/include/asm/p= age.h new file mode 100644 index 0000000000..9b49424714 --- /dev/null +++ b/xen/arch/ppc/include/asm/page.h @@ -0,0 +1,178 @@ +#ifndef _ASM_PPC_PAGE_H +#define _ASM_PPC_PAGE_H + +#include + +#include +#include + +#define PDE_VALID PPC_BIT(0) +#define PDE_NLB_MASK 0xfffffffffffffUL +#define PDE_NLB_SHIFT 5UL +#define PDE_NLS_MASK 0x1f + +#define PTE_VALID PPC_BIT(0) +#define PTE_LEAF PPC_BIT(1) +#define PTE_REFERENCE PPC_BIT(55) +#define PTE_CHANGE PPC_BIT(56) + +/* PTE Attributes */ +#define PTE_ATT_SAO PPC_BIT(59) /* Strong Access Ordering */ +#define PTE_ATT_NON_IDEMPOTENT PPC_BIT(58) +#define PTE_ATT_TOLERANT (PPC_BIT(58) | PPC_BIT(59)) + +/* PTE Encoded Access Authority*/ +#define PTE_EAA_PRIVILEGED PPC_BIT(60) +#define PTE_EAA_READ PPC_BIT(61) +#define PTE_EAA_WRITE PPC_BIT(62) +#define PTE_EAA_EXECUTE PPC_BIT(63) + +/* Field shifts/masks */ +#define PTE_RPN_MASK 0x1fffffffffffUL +#define PTE_RPN_SHIFT 12UL +#define PTE_ATT_MASK 0x3UL +#define PTE_ATT_SHIFT 4UL +#define PTE_EAA_MASK 0xfUL + +#define PTE_XEN_BASE (PTE_VALID | PTE_EAA_PRIVILEGED | PTE_REFERENCE) +#define PTE_XEN_RW (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_WRITE | PTE_= CHANGE) +#define PTE_XEN_RO (PTE_XEN_BASE | PTE_EAA_READ) +#define PTE_XEN_RX (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_EXECUTE) + +/* + * Radix Tree layout for 64KB pages: + * + * [ L1 (ROOT) PAGE DIRECTORY (8192 * sizeof(pde_t)) ] + * | + * | + * v + * [ L2 PAGE DIRECTORY (512 * sizeof(pde_t)) ] + * | + * | + * v + * [ L3 PAGE DIRECTORY (512 * sizeof(pde_t)) ] + * | + * | + * v + * [ L4 PAGE TABLE (32 * sizeof(pte_t)) ] + * | + * | + * v + * [ PAGE TABLE ENTRY ] + */ + +#define XEN_PT_ENTRIES_LOG2_LVL_1 13 /* 2**13 entries, maps 2**13 * 512G= B =3D 4PB */ +#define XEN_PT_ENTRIES_LOG2_LVL_2 9 /* 2**9 entries, maps 2**9 * 1GB = =3D 512GB */ +#define XEN_PT_ENTRIES_LOG2_LVL_3 9 /* 2**9 entries, maps 2**9 * 1GB = =3D 512GB */ +#define XEN_PT_ENTRIES_LOG2_LVL_4 5 /* 2**5 entries, maps 2**5 * 64K = =3D 2MB */ + +#define XEN_PT_SHIFT_LVL_1 (XEN_PT_SHIFT_LVL_2 + XEN_PT_ENTRIES_LOG2_= LVL_2) +#define XEN_PT_SHIFT_LVL_2 (XEN_PT_SHIFT_LVL_3 + XEN_PT_ENTRIES_LOG2_= LVL_3) +#define XEN_PT_SHIFT_LVL_3 (XEN_PT_SHIFT_LVL_4 + XEN_PT_ENTRIES_LOG2_= LVL_4) +#define XEN_PT_SHIFT_LVL_4 PAGE_SHIFT + +#define XEN_PT_ENTRIES_LOG2_LVL(lvl) (XEN_PT_ENTRIES_LOG2_LVL_##lvl) +#define XEN_PT_SHIFT_LVL(lvl) (XEN_PT_SHIFT_LVL_##lvl) +#define XEN_PT_ENTRIES_LVL(lvl) (1UL << XEN_PT_ENTRIES_LOG2_LVL(lvl= )) +#define XEN_PT_MASK_LVL(lvl) (XEN_PT_ENTRIES_LVL(lvl) - 1) +#define XEN_PT_INDEX_LVL(lvl, va) (((va) >> XEN_PT_SHIFT_LVL(lvl)) & = XEN_PT_MASK_LVL(lvl)) + +/* + * Calculate the index of the provided virtual address in the provided + * page table struct + */ +#define pt_index(pt, va) _Generic((pt), \ + struct lvl1_pd * : XEN_PT_INDEX_LVL(1, (va)), \ + struct lvl2_pd * : XEN_PT_INDEX_LVL(2, (va)), \ + struct lvl3_pd * : XEN_PT_INDEX_LVL(3, (va)), \ + struct lvl4_pt * : XEN_PT_INDEX_LVL(4, (va))) + +#define pt_entry(pt, va) (&((pt)->entries[pt_index((pt), (va))])) + +typedef struct +{ + __be64 pde; +} pde_t; + +typedef struct +{ + __be64 pte; +} pte_t; + +struct lvl1_pd +{ + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_1]; +}; + +struct lvl2_pd +{ + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_2]; +}; + +struct lvl3_pd +{ + pde_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_3]; +}; + +struct lvl4_pt +{ + pte_t entries[1U << XEN_PT_ENTRIES_LOG2_LVL_4]; +}; + +static inline pte_t paddr_to_pte(paddr_t paddr, unsigned long flags) +{ + return (pte_t){ .pte =3D cpu_to_be64(paddr | flags | PTE_LEAF) }; +} + +static inline pde_t paddr_to_pde(paddr_t paddr, unsigned long flags, uns= igned long nls) +{ + return (pde_t){ .pde =3D cpu_to_be64(paddr | flags | nls) }; +} + +static inline paddr_t pte_to_paddr(pte_t pte) +{ + return be64_to_cpu(pte.pte) & (PTE_RPN_MASK << PTE_RPN_SHIFT); +} + +static inline paddr_t pde_to_paddr(pde_t pde) +{ + return be64_to_cpu(pde.pde) & (PDE_NLB_MASK << PDE_NLB_SHIFT); +} + +static inline bool pte_is_valid(pte_t pte) +{ + return pte.pte & be64_to_cpu(PTE_VALID); +} + +static inline bool pde_is_valid(pde_t pde) +{ + return pde.pde & be64_to_cpu(PDE_VALID); +} + +/* + * ISA 3.0 partition and process table entry format + */ +struct patb_entry { + __be64 patb0; + __be64 patb1; +}; +#define PATB0_HR PPC_BIT(0) /* host uses radix */ +#define PATB1_GR PPC_BIT(0) /* guest uses radix; must match HR */ + +struct prtb_entry { + __be64 prtb0; + __be64 reserved; +}; + +/* + * We support 52 bits, hence: + * bits 52 - 31 =3D 21, 0b10101 + * RTS encoding details + * bits 0 - 3 of rts -> bits 6 - 8 unsigned long + * bits 4 - 5 of rts -> bits 62 - 63 of unsigned long + */ +#define RTS_FIELD ((0x2UL << 61) | (0x5UL << 5)) + +void tlbie_all(void); + +#endif /* _ASM_PPC_PAGE_H */ diff --git a/xen/arch/ppc/include/asm/processor.h b/xen/arch/ppc/include/= asm/processor.h index 2300640787..6b70569eb8 100644 --- a/xen/arch/ppc/include/asm/processor.h +++ b/xen/arch/ppc/include/asm/processor.h @@ -133,6 +133,40 @@ struct cpu_user_regs uint32_t entry_vector; }; +static __inline__ void sync(void) +{ + asm volatile ( "sync" ); +} + +static __inline__ void isync(void) +{ + asm volatile ( "isync" ); +} + +static inline unsigned long mfmsr(void) +{ + unsigned long msr; + asm volatile ( "mfmsr %0" : "=3Dr" (msr) ); + return msr; +} + +static inline void mtmsrd(unsigned long msr) +{ + asm volatile ( "mtmsrd %0" : : "r" (msr) ); +} + +static inline void mtspr(uint16_t spr, unsigned long val) +{ + asm volatile ( "mtspr %0, %1" : : "K" (spr), "r" (val) ); +} + +static inline unsigned long mfspr(uint16_t spr) +{ + unsigned long val; + asm volatile ( "mfspr %0, %1" : "=3Dr" (val) : "K" (spr) ); + return val; +} + /* * panic() isn't available at the moment so an infinite loop will be * used temporarily. diff --git a/xen/arch/ppc/include/asm/regs.h b/xen/arch/ppc/include/asm/r= egs.h new file mode 100644 index 0000000000..d5f47a6ff1 --- /dev/null +++ b/xen/arch/ppc/include/asm/regs.h @@ -0,0 +1,138 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, = USA. + * + * Copyright IBM Corp. 2005, 2007 + * + * Authors: Jimi Xenidis + * Christian Ehrhardt + */ + +#ifndef _ASM_REG_DEFS_H_ +#define _ASM_REG_DEFS_H_ + +/* Special Purpose Registers */ +#define SPRN_VRSAVE 256 +#define SPRN_DSISR 18 +#define SPRN_DAR 19 +#define SPRN_DEC 22 +#define SPRN_SRR0 26 +#define SPRN_SRR1 27 +#define SPRN_TBRL 268 +#define SPRN_TBRU 269 +#define SPRN_SPRG0 272 +#define SPRN_SPRG1 273 +#define SPRN_SPRG2 274 +#define SPRN_SPRG3 275 +#define SPRN_TBWL 284 +#define SPRN_TBWU 285 + +#define SPRN_HSPRG0 304 +#define SPRN_HSPRG1 305 +#define SPRN_HDEC 310 +#define SPRN_HIOR 311 +#define SPRN_RMOR 312 +#define SPRN_HRMOR 313 +#define SPRN_HSRR0 314 +#define SPRN_HSRR1 315 +#define SPRN_LPIDR 319 + +#define SPRN_PTCR 0x1D0 /* Partition table control Register */ +#define SPRN_PID 0x030 /* Process ID */ + +/* Performance monitor spr encodings */ +#define SPRN_MMCRA 786 +#define MMCRA_SAMPHV _AC(0x10000000, UL) /* state of MSR HV when SI= AR set */ +#define MMCRA_SAMPPR _AC(0x08000000, UL) /* state of MSR PR when SI= AR set */ +#define MMCRA_SAMPLE_ENABLE _AC(0x00000001, UL) /* enable sampling */ +#define NUM_PMCS 8 +#define SPRN_PMC1 787 +#define SPRN_PMC2 788 +#define SPRN_PMC3 789 +#define SPRN_PMC4 790 +#define SPRN_PMC5 791 +#define SPRN_PMC6 792 +#define SPRN_PMC7 793 +#define SPRN_PMC8 794 +#define SPRN_MMCR0 795 +#define MMCR0_FC _AC(0x80000000, UL) /* freeze counters */ +#define MMCR0_FCS _AC(0x40000000, UL) /* freeze in supervisor stat= e */ +#define MMCR0_FCP _AC(0x20000000, UL) /* freeze in problem state *= / +#define MMCR0_FCM1 _AC(0x10000000, UL) /* freeze counters while MSR= mark =3D 1 */ +#define MMCR0_FCM0 _AC(0x08000000, UL) /* freeze counters while MSR= mark =3D 0 */ +#define MMCR0_PMAE _AC(0x04000000, UL) /* performance monitor alert= enabled */ +#define MMCR0_PMAO _AC(0x00000080, UL) /* performance monitor alert= occurred */ +#define MMCR0_FCH _AC(0x00000001, UL) /* freeze conditions in hype= rvisor */ +#define SPRN_SIAR 796 +#define SPRN_SDAR 797 +#define SPRN_MMCR1 798 + +/* As defined for PU G4 */ +#define SPRN_HID0 1008 +#define SPRN_HID1 1009 +#define SPRN_HID4 1012 + +#define SPRN_DABR 1013 +#define SPRN_HID5 1014 +#define SPRN_DABRX 1015 +#define SPRN_HID6 1017 +#define SPRN_HID7 1018 +#define SPRN_HID8 1019 +#define SPRN_PIR 1023 + +#define SPRN_LPCR 0x13E /* LPAR Control Register */ +#define LPCR_VPM0 _AC(0x8000000000000000, UL) +#define LPCR_VPM1 _AC(0x4000000000000000, UL) +#define LPCR_ISL _AC(0x2000000000000000, UL) +#define LPCR_VC_SH 61 +#define LPCR_DPFD_SH 52 +#define LPCR_DPFD (_AC(7, UL) << LPCR_DPFD_SH) +#define LPCR_VRMASD_SH 47 +#define LPCR_VRMASD (_AC(0x1f, UL) << LPCR_VRMASD_SH) +#define LPCR_VRMA_L _AC(0x0008000000000000, UL) +#define LPCR_VRMA_LP0 _AC(0x0001000000000000, UL) +#define LPCR_VRMA_LP1 _AC(0x0000800000000000, UL) +#define LPCR_RMLS 0x1C000000 /* Implementation dependent RMO limit se= l */ +#define LPCR_RMLS_SH 26 +#define LPCR_HAIL _AC(0x0000000004000000, UL) /* HV AIL (ISAv3.1) *= / +#define LPCR_ILE _AC(0x0000000002000000, UL) /* !HV irqs set MSR:LE= */ +#define LPCR_AIL _AC(0x0000000001800000, UL) /* Alternate interrupt l= ocation */ +#define LPCR_AIL_0 _AC(0x0000000000000000, UL) /* MMU off exception o= ffset 0x0 */ +#define LPCR_AIL_3 _AC(0x0000000001800000, UL) /* MMU on exception = offset 0xc00...4xxx */ +#define LPCR_ONL _AC(0x0000000000040000, UL) /* online - PURR/SPURR c= ount */ +#define LPCR_LD _AC(0x0000000000020000, UL) /* large decremeter */ +#define LPCR_PECE _AC(0x000000000001f000, UL) /* powersave exit cause= enable */ +#define LPCR_PECEDP _AC(0x0000000000010000, UL) /* directed priv dbe= lls cause exit */ +#define LPCR_PECEDH _AC(0x0000000000008000, UL) /* directed hyp dbel= ls cause exit */ +#define LPCR_PECE0 _AC(0x0000000000004000, UL) /* ext. exceptions c= an cause exit */ +#define LPCR_PECE1 _AC(0x0000000000002000, UL) /* decrementer can c= ause exit */ +#define LPCR_PECE2 _AC(0x0000000000001000, UL) /* machine check etc= can cause exit */ +#define LPCR_PECE_HVEE _AC(0x0000400000000000, UL) /* P9 Wakeup on H= V interrupts */ +#define LPCR_MER _AC(0x0000000000000800, UL) /* Mediated External Exc= eption */ +#define LPCR_MER_SH 11 +#define LPCR_GTSE _AC(0x0000000000000400, UL) /* Guest Translation = Shootdown Enable */ +#define LPCR_TC _AC(0x0000000000000200, UL) /* Translation control */ +#define LPCR_HEIC _AC(0x0000000000000010, UL) /* Hypervisor Externa= l Interrupt Control */ +#define LPCR_LPES 0x0000000c +#define LPCR_LPES0 _AC(0x0000000000000008, UL) /* LPAR Env selec= tor 0 */ +#define LPCR_LPES1 _AC(0x0000000000000004, UL) /* LPAR Env selec= tor 1 */ +#define LPCR_LPES_SH 2 +#define LPCR_RMI _AC(0x0000000000000002, UL) /* real mode is cac= he inhibit */ +#define LPCR_HVICE _AC(0x0000000000000002, UL) /* P9: HV interru= pt enable */ +#define LPCR_HDICE _AC(0x0000000000000001, UL) /* Hyp Decr enabl= e (HV,PR,EE) */ +#define LPCR_UPRT _AC(0x0000000000400000, UL) /* Use Process Tab= le (ISA 3) */ +#define LPCR_HR _AC(0x0000000000100000, UL) + +#endif /* _ASM_REG_DEFS_H_ */ diff --git a/xen/arch/ppc/include/asm/types.h b/xen/arch/ppc/include/asm/= types.h index b62ae0e7ae..ffaf378a4d 100644 --- a/xen/arch/ppc/include/asm/types.h +++ b/xen/arch/ppc/include/asm/types.h @@ -4,6 +4,7 @@ #define _ASM_PPC_TYPES_H typedef unsigned long paddr_t; +typedef unsigned long vaddr_t; #define INVALID_PADDR (~0UL) #define PRIpaddr "016lx" diff --git a/xen/arch/ppc/mm-radix.c b/xen/arch/ppc/mm-radix.c new file mode 100644 index 0000000000..a86cd2f73b --- /dev/null +++ b/xen/arch/ppc/mm-radix.c @@ -0,0 +1,268 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +void enable_mmu(void); + +#define INITIAL_LVL1_PD_COUNT 1 +#define INITIAL_LVL2_LVL3_PD_COUNT 2 +#define INITIAL_LVL4_PT_COUNT 256 + +static size_t initial_lvl1_pd_pool_used; +static struct lvl1_pd __aligned(sizeof(struct lvl1_pd)) +initial_lvl1_pd_pool[INITIAL_LVL1_PD_COUNT]; + +static size_t initial_lvl2_lvl3_pd_pool_used; +static struct lvl2_pd __aligned(sizeof(struct lvl2_pd)) +initial_lvl2_lvl3_pd_pool[INITIAL_LVL2_LVL3_PD_COUNT]; + +static size_t initial_lvl4_pt_pool_used; +static struct lvl4_pt __aligned(sizeof(struct lvl4_pt)) +initial_lvl4_pt_pool[INITIAL_LVL4_PT_COUNT]; + +/* Only reserve minimum Partition and Process tables */ +#define PATB_SIZE_LOG2 16 /* Only supported partition table size on POWE= R9 */ +#define PATB_SIZE (1UL << PATB_SIZE_LOG2) +#define PRTB_SIZE_LOG2 12 +#define PRTB_SIZE (1UL << PRTB_SIZE_LOG2) + +static struct patb_entry + __aligned(PATB_SIZE) initial_patb[PATB_SIZE / sizeof(struct patb_ent= ry)]; + +static struct prtb_entry + __aligned(PRTB_SIZE) initial_prtb[PRTB_SIZE / sizeof(struct prtb_ent= ry)]; + +static __init struct lvl1_pd *lvl1_pd_pool_alloc(void) +{ + if ( initial_lvl1_pd_pool_used >=3D INITIAL_LVL1_PD_COUNT ) + { + early_printk("Ran out of space for LVL1 PD!\n"); + die(); + } + + return &initial_lvl1_pd_pool[initial_lvl1_pd_pool_used++]; +} + +static __init struct lvl2_pd *lvl2_pd_pool_alloc(void) +{ + if ( initial_lvl2_lvl3_pd_pool_used >=3D INITIAL_LVL2_LVL3_PD_COUNT = ) + { + early_printk("Ran out of space for LVL2/3 PD!\n"); + die(); + } + + return &initial_lvl2_lvl3_pd_pool[initial_lvl2_lvl3_pd_pool_used++]; +} + +static __init struct lvl3_pd *lvl3_pd_pool_alloc(void) +{ + BUILD_BUG_ON(sizeof(struct lvl3_pd) !=3D sizeof(struct lvl2_pd)); + + return (struct lvl3_pd *) lvl2_pd_pool_alloc(); +} + +static __init struct lvl4_pt *lvl4_pt_pool_alloc(void) +{ + if ( initial_lvl4_pt_pool_used >=3D INITIAL_LVL4_PT_COUNT ) + { + early_printk("Ran out of space for LVL4 PT!\n"); + die(); + } + + return &initial_lvl4_pt_pool[initial_lvl4_pt_pool_used++]; +} + +#ifndef NDEBUG +/* TODO: Remove once we get common/ building */ +static char *__init itoa64_hex(uint64_t val, char *out_buf, size_t buf_l= en) +{ + uint64_t cur; + size_t i =3D buf_len - 1; + + /* Null terminate buffer */ + out_buf[i] =3D '\0'; + + /* Add digits in reverse */ + cur =3D val; + while ( cur && i > 0 ) + { + out_buf[--i] =3D "0123456789ABCDEF"[cur % 16]; + cur /=3D 16; + } + + /* Pad to 16 digits */ + while ( i > 0 ) + out_buf[--i] =3D '0'; + + return out_buf + i; +} +#endif + +static void __init radix_dprint(uint64_t addr, const char *msg) +{ +#ifndef NDEBUG + char buf[sizeof("DEADBEEFCAFEBABA")]; + char *addr_s =3D itoa64_hex(addr, buf, sizeof(buf)); + + early_printk("(0x"); + early_printk(addr_s); + early_printk(") "); + early_printk(msg); +#endif +} + +static void __init setup_initial_mapping(struct lvl1_pd *lvl1, + vaddr_t map_start, + vaddr_t map_end, + paddr_t phys_base) +{ + uint64_t page_addr; + + if ( map_start & ~PAGE_MASK ) + { + early_printk("Xen _start be aligned to 64k (PAGE_SIZE) boundary\= n"); + die(); + } + + if ( phys_base & ~PAGE_MASK ) + { + early_printk("Xen should be loaded at 64k (PAGE_SIZE) boundary\n= "); + die(); + } + + for ( page_addr =3D map_start; page_addr < map_end; page_addr +=3D P= AGE_SIZE ) + { + struct lvl2_pd *lvl2; + struct lvl3_pd *lvl3; + struct lvl4_pt *lvl4; + pde_t *pde; + pte_t *pte; + + /* Allocate LVL 2 PD if necessary */ + pde =3D pt_entry(lvl1, page_addr); + if ( !pde_is_valid(*pde) ) + { + lvl2 =3D lvl2_pd_pool_alloc(); + *pde =3D paddr_to_pde(__pa(lvl2), PDE_VALID, + XEN_PT_ENTRIES_LOG2_LVL_2); + } + else + lvl2 =3D (struct lvl2_pd *)__va(pde_to_paddr(*pde)); + + /* Allocate LVL 3 PD if necessary */ + pde =3D pt_entry(lvl2, page_addr); + if ( !pde_is_valid(*pde) ) + { + lvl3 =3D lvl3_pd_pool_alloc(); + *pde =3D paddr_to_pde(__pa(lvl3), PDE_VALID, + XEN_PT_ENTRIES_LOG2_LVL_3); + } + else + lvl3 =3D (struct lvl3_pd *)__va(pde_to_paddr(*pde)); + + /* Allocate LVL 4 PT if necessary */ + pde =3D pt_entry(lvl3, page_addr); + if ( !pde_is_valid(*pde) ) + { + lvl4 =3D lvl4_pt_pool_alloc(); + *pde =3D paddr_to_pde(__pa(lvl4), PDE_VALID, + XEN_PT_ENTRIES_LOG2_LVL_4); + } + else + lvl4 =3D (struct lvl4_pt *)__va(pde_to_paddr(*pde)); + + /* Finally, create PTE in LVL 4 PT */ + pte =3D pt_entry(lvl4, page_addr); + if ( !pte_is_valid(*pte) ) + { + unsigned long paddr =3D (page_addr - map_start) + phys_base; + unsigned long flags; + + radix_dprint(paddr, "being mapped to "); + radix_dprint(page_addr, "!\n"); + if ( is_kernel_text(page_addr) || is_kernel_inittext(page_ad= dr) ) + { + radix_dprint(page_addr, "being marked as TEXT (RX)\n"); + flags =3D PTE_XEN_RX; + } + else if ( is_kernel_rodata(page_addr) ) + { + radix_dprint(page_addr, "being marked as RODATA (RO)\n")= ; + flags =3D PTE_XEN_RO; + } + else + { + radix_dprint(page_addr, "being marked as DEFAULT (RW)\n"= ); + flags =3D PTE_XEN_RW; + } + + *pte =3D paddr_to_pte(paddr, flags); + radix_dprint(paddr_to_pte(paddr, flags).pte, + "is result of PTE map!\n"); + } + else + { + early_printk("BUG: Tried to create PTE for already-mapped pa= ge!"); + die(); + } + } +} + +static void __init setup_partition_table(struct lvl1_pd *root) +{ + unsigned long ptcr; + + /* Configure entry for LPID 0 to enable Radix and point to root PD *= / + uint64_t patb0 =3D RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_= 1 | + PATB0_HR; + uint64_t patb1 =3D __pa(initial_prtb) | (PRTB_SIZE_LOG2 - 12) | PATB= 1_GR; + initial_patb[0].patb0 =3D cpu_to_be64(patb0); + initial_patb[0].patb1 =3D cpu_to_be64(patb1); + + ptcr =3D __pa(initial_patb) | (PATB_SIZE_LOG2 - 12); + mtspr(SPRN_PTCR, ptcr); +} + +static void __init setup_process_table(struct lvl1_pd *root) +{ + /* Configure entry for PID 0 to point to root PD */ + uint64_t prtb0 =3D RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_= 1; + initial_prtb[0].prtb0 =3D cpu_to_be64(prtb0); +} + +void __init setup_initial_pagetables(void) +{ + struct lvl1_pd *root =3D lvl1_pd_pool_alloc(); + unsigned long lpcr; + + setup_initial_mapping(root, (vaddr_t)_start, (vaddr_t)_end, __pa(_st= art)); + + /* Enable Radix mode in LPCR */ + lpcr =3D mfspr(SPRN_LPCR); + mtspr(SPRN_LPCR, lpcr | LPCR_UPRT | LPCR_HR); + early_printk("Enabled radix in LPCR\n"); + + /* Set up initial process table */ + setup_process_table(root); + + /* Set up initial partition table */ + setup_partition_table(root); + + /* Flush TLB */ + tlbie_all(); + early_printk("Flushed TLB\n"); + + /* Turn on the MMU */ + enable_mmu(); +} diff --git a/xen/arch/ppc/ppc64/head.S b/xen/arch/ppc/ppc64/head.S index d91bd7f92d..1352bb5850 100644 --- a/xen/arch/ppc/ppc64/head.S +++ b/xen/arch/ppc/ppc64/head.S @@ -2,6 +2,7 @@ #include #include +#include .section .text.header, "ax", %progbits @@ -66,3 +67,17 @@ ENTRY(start) .size start, . - start .type start, %function + +ENTRY(enable_mmu) + mflr %r3 + mfmsr %r4 + + /* enable instruction and data relocation (MMU) */ + ori %r4, %r4, (MSR_IR | MSR_DR) + + mtsrr0 %r3 /* return to caller after MMU enable */ + mtsrr1 %r4 + rfid + + .size enable_mmu, . - enable_mmu + .type enable_mmu, %function diff --git a/xen/arch/ppc/setup.c b/xen/arch/ppc/setup.c index 8ab7bc19ee..0106e9c9da 100644 --- a/xen/arch/ppc/setup.c +++ b/xen/arch/ppc/setup.c @@ -2,6 +2,7 @@ #include #include #include +#include #include /* Xen stack for bringing up the first CPU. */ @@ -27,6 +28,8 @@ void __init noreturn start_xen(unsigned long r3, unsign= ed long r4, boot_opal_init((void *)r3); } + setup_initial_pagetables(); + early_printk("Hello, ppc64le!\n"); for ( ; ; ) diff --git a/xen/arch/ppc/tlb-radix.c b/xen/arch/ppc/tlb-radix.c new file mode 100644 index 0000000000..e9115ba2db --- /dev/null +++ b/xen/arch/ppc/tlb-radix.c @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Based on arch/powerpc/mm/book3s64/radix_tlb.c from Linux with the fol= lowing + * copyright notice: + * + * Copyright 2015-2016, Aneesh Kumar K.V, IBM Corporation. + */ +#include + +#include +#include +#include + +/* TLB flush actions. Used as argument to tlbiel_flush() */ +enum +{ + TLB_INVAL_SCOPE_LPID, /* invalidate TLBs for current LPID */ + TLB_INVAL_SCOPE_GLOBAL, /* invalidate all TLBs */ +}; + +#define POWER9_TLB_SETS_RADIX 128 /* # sets in POWER9 TLB Radix mode */ + +#define RIC_FLUSH_TLB 0 +#define RIC_FLUSH_PWC 1 +#define RIC_FLUSH_ALL 2 + +static void tlbiel_radix_set_isa300(unsigned int set, unsigned int is, + unsigned int pid, unsigned int ric, + unsigned int prs) +{ + unsigned long rb; + unsigned long rs; + + rb =3D (set << PPC_BITLSHIFT(51)) | (is << PPC_BITLSHIFT(53)); + rs =3D ((unsigned long) pid << PPC_BITLSHIFT(31)); + + asm volatile ( "tlbiel %0, %1, %2, %3, 1" + :: "r" (rb), "r" (rs), "i" (ric), "i" (prs) + : "memory" ); +} + +static void tlbiel_all_isa300(unsigned int num_sets, unsigned int is) +{ + unsigned int set; + + asm volatile ( "ptesync" : : : "memory" ); + + /* + * Flush the first set of the TLB, and the entire Page Walk Cache + * and partition table entries. Then flush the remaining sets of the + * TLB. + */ + + if ( mfmsr() & MSR_HV ) + { + /* MSR[HV] should flush partition scope translations first. */ + tlbiel_radix_set_isa300(0, is, 0, RIC_FLUSH_ALL, 0); + + for ( set =3D 1; set < num_sets; set++ ) + tlbiel_radix_set_isa300(set, is, 0, RIC_FLUSH_TLB, 0); + } + + /* Flush process scoped entries. */ + tlbiel_radix_set_isa300(0, is, 0, RIC_FLUSH_ALL, 1); + + for ( set =3D 1; set < num_sets; set++ ) + tlbiel_radix_set_isa300(set, is, 0, RIC_FLUSH_TLB, 1); + + asm volatile ( "ptesync" : : : "memory" ); +} + +void radix__tlbiel_all(unsigned int action) +{ + unsigned int is; + + switch ( action ) + { + case TLB_INVAL_SCOPE_GLOBAL: + is =3D 3; + break; + case TLB_INVAL_SCOPE_LPID: + is =3D 2; + break; + default: + die(); + } + + tlbiel_all_isa300(POWER9_TLB_SETS_RADIX, is); + + asm volatile ( "slbia 7; isync" : : : "memory" ); +} + +void tlbie_all(void) +{ + radix__tlbiel_all(TLB_INVAL_SCOPE_GLOBAL); +} -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:18:04 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:18:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581408.910090 (Exim 4.92) (envelope-from ) id 1qTrVA-0006Ij-6h; Wed, 09 Aug 2023 22:18:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581408.910090; Wed, 09 Aug 2023 22:18:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrVA-0006Ic-44; Wed, 09 Aug 2023 22:18:00 +0000 Received: by outflank-mailman (input) for mailman id 581408; Wed, 09 Aug 2023 22:17:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrV8-0006IQ-K6 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:17:58 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9759735e-3702-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:17:57 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id EF8A282868E2; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YVsL932o5Hnk; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 3A6FA828553F; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id O0kQthIAsvar; Wed, 9 Aug 2023 17:17:55 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id CBC2A8285C0F; Wed, 9 Aug 2023 17:17:54 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9759735e-3702-11ee-b282-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 3A6FA828553F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691619475; bh=KqI9TVA8FbZ1LWbWWdF8L7W6TWK7/HIuQJKiQybY8cE=; h=From:To:Date:Message-Id:MIME-Version; b=LW2iBzxaHgS3r+jsNRs/39lnDpsTuoj2Z1xWqMk1IQcsrUyuU+/qsqd5SxhTkMoNC tb5xl6rArrBe0VpAKat+5CvQDG0SroecokSzzIhJSTLmHKSEzOPWKGMumY7ZKRgpIQ 8UTF9VcgpsljK/BLTzCh6zz0Ij/6Gopl2NqGULv0= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v2 2/3] xen/ppc: Relocate kernel to physical address 0 on boot Date: Wed, 9 Aug 2023 17:17:42 -0500 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Introduce a small assembly loop in `start` to copy the kernel to physical address 0 before continuing. This ensures that the physical address lines up with XEN_VIRT_START (0xc000000000000000) and allows us to identity map the kernel when the MMU is set up in the next patch. We are also able to start execution at XEN_VIRT_START after the copy since hardware will ignore the top 4 address bits when operating in Real Mode (MMU off). Signed-off-by: Shawn Anastasio --- v2: - Fix definition of XEN_VIRT_START macro which incorrectly used _AT instead of _AC. - Use _start instead of start as symbol referring to beginning of Xen binary xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/ppc64/head.S | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/xen/arch/ppc/include/asm/config.h b/xen/arch/ppc/include/asm= /config.h index d060f0dca7..b76f940431 100644 --- a/xen/arch/ppc/include/asm/config.h +++ b/xen/arch/ppc/include/asm/config.h @@ -39,7 +39,7 @@ name: #endif -#define XEN_VIRT_START _AT(UL, 0xc000000000000000) +#define XEN_VIRT_START _AC(0xc000000000000000, UL) #define SMP_CACHE_BYTES (1 << 6) diff --git a/xen/arch/ppc/ppc64/head.S b/xen/arch/ppc/ppc64/head.S index 8f1e5d3ad2..d91bd7f92d 100644 --- a/xen/arch/ppc/ppc64/head.S +++ b/xen/arch/ppc/ppc64/head.S @@ -17,6 +17,33 @@ ENTRY(start) addis %r2, %r12, .TOC.-1b@ha addi %r2, %r2, .TOC.-1b@l + /* + * Copy Xen to physical address zero and jump to XEN_VIRT_START + * (0xc000000000000000). This works because the hardware will ignore= the top + * four address bits when the MMU is off. + */ + LOAD_REG_ADDR(%r1, _start) + LOAD_IMM64(%r12, XEN_VIRT_START) + + /* If we're at the correct address, skip copy */ + cmpld %r1, %r12 + beq .L_correct_address + + /* Copy bytes until _end */ + LOAD_REG_ADDR(%r11, _end) + addi %r1, %r1, -8 + li %r13, -8 +.L_copy_xen: + ldu %r10, 8(%r1) + stdu %r10, 8(%r13) + cmpld %r1, %r11 + blt .L_copy_xen + + /* Jump to XEN_VIRT_START */ + mtctr %r12 + bctr +.L_correct_address: + /* set up the initial stack */ LOAD_REG_ADDR(%r1, cpu0_boot_stack) li %r11, 0 -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:34:46 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581434.910130 (Exim 4.92) (envelope-from ) id 1qTrlG-00025D-Ox; Wed, 09 Aug 2023 22:34:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581434.910130; Wed, 09 Aug 2023 22:34:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrlG-000256-MQ; Wed, 09 Aug 2023 22:34:38 +0000 Received: by outflank-mailman (input) for mailman id 581434; Wed, 09 Aug 2023 22:34:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrlF-000250-9y for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:34:37 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eaa9193d-3704-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:34:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67DF664B82; Wed, 9 Aug 2023 22:34:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 983DBC433C8; Wed, 9 Aug 2023 22:34:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eaa9193d-3704-11ee-b282-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691620473; bh=ASLkJYW+aNebiQ/C5hjTpetqtLfQ6TDZsa31UZXTnYw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uttJxl7Dzd4QlTqHKvkYrJNbxYauBeEr0ODInCEMsCSIphBCSHnRlui6cVJxYjKKz d2yEdY4ftkS7UaBZYxUleb2/Mqzn3nte2SsWIfR2QehbdmW8DMnkv4SfaF1j8fvE5a xL1E6AQj/0FVLLCtTpboU9UV6nb+VtjKvQDGePNVi6Hwk2IExXPOpybxsaQeaKCCYg ISYakji6ON1KMhpubi7gICf3P1BomBR5qUPOeUbAQRsmoobJu1Kff+xUamwgSf53Ju fsrWvr/Xak2oHKPTP4rvU7sUFhAW6WjK8mxyH2fY2Fnh9hT0lJ+699evHleEo6zZ+Q rXKsfUQsMD6uw== Date: Wed, 9 Aug 2023 15:34:31 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Henry Wang , "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Julien Grall , Bertrand Marquis Subject: Re: Xen 4.18 release: Reminder about last posting date In-Reply-To: <1ac14ed0-d489-0efe-0b0c-200792a50fde@citrix.com> Message-ID: References: <1ac14ed0-d489-0efe-0b0c-200792a50fde@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-2084107488-1691620297=:2127516" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2084107488-1691620297=:2127516 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 9 Aug 2023, Andrew Cooper wrote: > On 09/08/2023 10:43 pm, Stefano Stabellini wrote: > > On Wed, 9 Aug 2023, Andrew Cooper wrote: > >> On 07/08/2023 2:24 am, Henry Wang wrote: > >>> Hi everyone, > >>> > >>> Following the release schedule discussion in in April, I am sending this email > >>> to remind that according to the release schedule [1], August 11 (this Friday) > >>> will be the last posting date, when patches adding new features are expected > >>> to be posted to the mailing list by this date. > >>> > >>> Also, note that we currently have 1 release blocker [2] which might need > >>> some attention. > >>> > >>> [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ > >>> [2] https://gitlab.com/xen-project/xen/-/issues/114 > >> Off the top of my head. > >> > >> There are still unaddressed Gitlab bugs from the Eclair integration > > The bug you managed to find it is now fixed (commit e55146071de9). I am > > all for fixing Gitlab bugs so let me know if you find anything else! I > > am not aware of any other issue with Eclair at the moment. > > I meant the one where Eclair is still running on `smoke` and twiddling > its thumbs for 1h doing so each time OSSTest says yes to a push.  It > will be a missing 'exclude' somewhere, but I haven't hand enough time to > look. Ah, yes, got it. I would call it "Eclair lagging behind". I am happy for this to be a blocker. > >> and other Gitlab bugs (use of unstable containers) which I'd unwilling > >> to let 4.18 be released with, given the pain we've had on the stable > >> trees trying to keep CI working. > > That is fair enough. To make this more concrete and easier to track, the > > following would need to be changed to using stable containers: > > > > - .qemu-arm64 > > - .qemu-arm32 > > (I am not counting .qemu-riscv64) > > > > Andrew, is that what you meant? Am I missing anything? > > Every debian unstable container, and the other containers (OpenSUSE) > which are using an non-specific upstream version.  Upstreams which > really are rolling distros (Arch, Tumbleweed) need to be made non-fatal. I was more asking whether for 4.18 you want to fix only test.yaml or also build.yaml. (Typically it is test.yaml that causes most issues with rolling containers.) .qemu-arm64 and .qemu-arm32 are the only ones using unstable/rolling containers in automation/gitlab-ci/test.yaml (excluding .qemu-riscv64), that's why I was asking about those two specifically. > Then the second part which is also a blocker.  Update the distros we > test with to be less obsolete.  e.g. the majority of our CI testing runs > with Alpine-3.12 when EOL more than a year ago. (2022-05-01) OK. Hopefully it will be trivial. --8323329-2084107488-1691620297=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:44:54 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:44:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581440.910140 (Exim 4.92) (envelope-from ) id 1qTrv4-0003ay-Ie; Wed, 09 Aug 2023 22:44:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581440.910140; Wed, 09 Aug 2023 22:44:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrv4-0003ar-G6; Wed, 09 Aug 2023 22:44:46 +0000 Received: by outflank-mailman (input) for mailman id 581440; Wed, 09 Aug 2023 22:44:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrv3-0003al-EX for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:44:45 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 54b609e4-3706-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:44:43 +0200 (CEST) Received: from mail-dm6nam12lp2174.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 09 Aug 2023 18:44:37 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB4969.namprd03.prod.outlook.com (2603:10b6:5:1e5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Wed, 9 Aug 2023 22:44:35 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::6bfe:c2d3:2c8e:d2ea%6]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 22:44:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54b609e4-3706-11ee-b282-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691621083; h=message-id:date:from:subject:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=+Nmxt6PsPoTAOqwy1lXBdfIyqlB7qE0GdGZxS716VyY=; b=EXKyiJXtS4Pf76RSscfz9JeqKXs80sYe9XZYYL0H/LNw2Q1Ssx+RX+LH E/bkoAad102VUBMxYW2Tfhs2a2YAX49aseaYu/BcYT1RCoZqPH/p35uo8 dzlHWhoA1aR97MzT7q6aI9OEU9TrJ+tXQU3/Zfsa97FLzrUEnKcZsbysO g=; X-IronPort-RemoteIP: 104.47.59.174 X-IronPort-MID: 121706681 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:veJujaK03ZZQfKw1FE+RQJQlxSXFcZb7ZxGr2PjKsXjdYENS32MAn TFKCm3XOP6JY2D9Kot3YI2z9UMD7ZPdm4dqTwVlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gRvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c56Qnhj/ v8CJwpWfwGNrcy154uaU+Vj05FLwMnDZOvzu1lG5BSAV7MKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dmpTGMkGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHmiB9pMSu3hnhJsqHvNwV1MBTEWb0OQvfmginKhUooYI kNBr0LCqoB3riRHVOLVRAakqXSJuhodXdt4EOAg7gyJjK3O7G6xJmUCVC8HV9Ugu+c/Xzls3 ViM9/v5CDoqvLCLRHa18raPsSj0KSUTNXUFZyIPUU0C+daLiIo0ixfSSNd/Aeiwh9v8Fjzq6 yCHqjAkgLcehtJN0L+0lXjFiT+xopnCTiYu+x7aGGmi62tRZpOhZoGuwUjW67BHNonxZnOMp mQeks6SqsUHF4iQlTelSf8IWrqu4p643Cb0hFduG9wt8mqr8nv6J4RIumgheAFuL9oOfiLvb AnLowRN6ZRPPXysK6hqf4a2DMdsxq/lfTj4as3pghN1SsAZXGe6EOtGPCZ8A0iFfJAQrJwC IronPort-HdrOrdr: A9a23:tmTi2qDBEbEfC4HlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-Talos-CUID: =?us-ascii?q?9a23=3AHDWEkWsNvTdG5qAI98cVgqUA6IsoMWTwx3TKLHX?= =?us-ascii?q?jGHdnYpOWbmax4a9rxp8=3D?= X-Talos-MUID: 9a23:B9kMbga6Eu57M+BTkWHrtW5vGMdS+4+yCFkNrYoP446NOnkl X-IronPort-AV: E=Sophos;i="6.01,160,1684814400"; d="scan'208";a="121706681" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LH4s8XOD35NmPxZA0nJuLzX+Ws8nYp/6a8lxw/pgbgOCGU7GWOQFRV2j/+F7VgCUmcNhqYlJZeimm6RZkwddGXMiHeSXdoAjWP5xl7VMNCKXFrQaaOLcjJVWuTBynpNPehlzl8M7lksmyBsf4w2n8Xh8d3gRXzIvLlM3XEIL4VUnEFdMlTpcDkrVvZUOU6v0umVVXyRBFEmBhUPpE4zEFCVgIa6GJSLHCHYNTAKXlb+yFnokDyAY/VUMzR8mPshNsei/knhRz9fmC9KAkxco+jneIHlrA7a8rGAy+hEO22S55GN1NNTq/QtRnNoNmwMyV6Zb3SG+sdPIltzLi5E6Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Nmxt6PsPoTAOqwy1lXBdfIyqlB7qE0GdGZxS716VyY=; b=exCe9xbVa6btVEDsSoQeaa6ILUlHJGQezVlN4NnF3EzYVsf1cCPWQmVJ4vtQ9ubrzlml3nv5yTkbqeLGtgwswAeO+DEgn4BTaCXWlBk6ZPKKODSxmuU937Qq1/JdxhhZzAweDmmN56qBO7/3cA1/tApS/X/Xn7kU7DUIEIkUBx+PyFf/GGyQNqVKCQwk2XWVOc7mLbrH0F2+5l4ZXWt2FfnZe0Z4N5UmouYNUz7exL74GRielpkGHt1MZKyhNXpndzejirSogEATqT6ldXIWxMUpUygYE14ay5oO74bWXO5xgut2lgRPNReDDZFFbLrXNajXBs1DOeAw2CiMg/YJ6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Nmxt6PsPoTAOqwy1lXBdfIyqlB7qE0GdGZxS716VyY=; b=K5p2RiiiUGR00nQFWwKdsfHqQuvYI0/TMlQ+r3mnwP9dK0lmnGKdxwd3oPyCtPDMGrEN7nGbDwk3Hbt+yqQYPRoU5bcCSB+z7onpvrApAs6OgpS0J3Zq8/fOLOgogKqhwX1Hbe6Itv2+Wfaqajfq4zcsukyfzpWAJO8ZGPBmsgk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Message-ID: Date: Wed, 9 Aug 2023 23:44:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Andrew Cooper Subject: Re: Xen 4.18 release: Reminder about last posting date Content-Language: en-GB To: Stefano Stabellini Cc: Henry Wang , "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Bertrand Marquis References: <1ac14ed0-d489-0efe-0b0c-200792a50fde@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0093.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR03MB3623:EE_|DM6PR03MB4969:EE_ X-MS-Office365-Filtering-Correlation-Id: af59176e-0ab2-4835-028b-08db992a3418 X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GXSIcQeoAJdXmzJEPzcKDQ0OPQGH03JHyfN6pI3mzZF0ergu3ZPCP5Hxx63UrqFA9tKZotHKF6c0aI03pq4o32c/TJUN+F8dDtAji+zyKKEXqEfb13BsMy2UkrKfdOKc26wEGz2kI1otTYPICsW1Js2pKTuq8ikdDRhppHhDiEggwwVyoEuQ1kEvhNTKM5Azkp5glp77X2j1Xbo+7Y44jlaWDk3YX6JPGIa767+rkOWUH/qIuN4Ls4RCj0xGjE1978Qx1BYmKgwyFypFgNIX2hlc+DYZ6TBSIBXwJJW9m0EMGm1WG6JSZqjf5JcVEKHl7R8OGwFZqqHjJENW/nRe7OHfs2jr7QWrIdgo9i6og/IEgxFT8olsiwe9GwBhLSs6O/ZIihH/+CQ4850QIRZXveBkhUIrcs3vzS9r+gYs+J/VQY6L/d7SZJHJE9eLLz9831c6brStEE5B0D8XydqZ7G4N2GMutiUyRNeCtfOWynmGmg+GHsVGTnBfnxiWeEjgv+ZPq/yH7pHZZzbinPjK3Zr5maqwjEcex8Pd5CUZX6mSkU4frO7glf5bKtVZVsLtWQI7DlKuUgOi/WOt6zqxGcPKuPVfG2C169Ixa7kupfJi8Sldy1WGdySSuWH/R7XrQOB0beTRpE7kkXEHKdJ9SQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(39860400002)(136003)(396003)(376002)(346002)(186006)(451199021)(1800799006)(83380400001)(6506007)(2616005)(53546011)(26005)(6916009)(2906002)(41300700001)(45080400002)(66556008)(66476007)(66946007)(316002)(54906003)(478600001)(4326008)(8936002)(8676002)(5660300002)(6486002)(6512007)(6666004)(966005)(38100700002)(82960400001)(31696002)(86362001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnBqOGUyZVBjZElWQ25tWSsvK25hZHlHc2FzQWgvMkZTMUVaWGp3NVo3b0RC?= =?utf-8?B?b2RwN0dqNWM1UkhPRW8rdFE0S2ZHdFZuR08vTnVYNjdrUGs3blBGRmdlOVhV?= =?utf-8?B?VHhTZXZCZTZDaFJxUEd3SVB3blNBL0YrWUJ3L1g2MGcxNGpLVFh0ZlhzT0Fh?= =?utf-8?B?WnJXNGpzaXFBd1dYRUYxZ2hDK1dNV3hNMGF6NEc0YUlXQnpNRFpmRk1WQ1ZO?= =?utf-8?B?dXBLblBhSUl5T2lvdzhqL3U3ZkdRaWZrYmpCUDNwaEpsNVBDVHY4REhTVWM0?= =?utf-8?B?OHJINVZENXpVaDVyUVZvT3pTSXhJSUdLUWUrNitmcjlLSjdYRW44eGpSMG5M?= =?utf-8?B?M2YwYmlPempNVnMvRTdXT3RLczVVT2RtQThTM0h4ZWNsR2lldFV1UDRFOC9X?= =?utf-8?B?K1BobUptWWx0WkpyYmZnWHJZTkRpZENNSVI2MVB1WnJUSk9wMmFCVkZCNTJ4?= =?utf-8?B?bWlPTjZYdWlGVHZ0RTh3UWZhK0YxeVdDQUtkRjBvMDhVTUp5NmpqNXNGaStk?= =?utf-8?B?SHF3UDZUMWc0VWhvenZ4L1dzNjRxTUM1c2o3SUxZY2gvdkt5cG5WaklNWWU5?= =?utf-8?B?ZkpLRXg3YlZ1U2tXSnNOYkxQb25ZY0poTUE3a29pSndpSzd5dmtWcE1xbWRj?= =?utf-8?B?N0hOU3lmZ0ZjeVVKUzFFMmdkTzdvTzVudVhwbmE3SkNhZmg2dHhpczRvdmhO?= =?utf-8?B?SmI2VWIvSnNaVXVIYmpmZnNHMHRkN1o1SmtzSU1BazQxcy80Rm5Wc1piWG1s?= =?utf-8?B?eXQxQUlkdDRsVHVNMGk4cGl3c2s5S0NIZnFuT2FoS05NaXg4U21MWi90RzUx?= =?utf-8?B?S1RJUFdXVFFvSXlOOWtXUVUybDhXUXhnajdwYzZBZFZYQXQyWjJsaDZkK0hp?= =?utf-8?B?d1ErQk45eHVtQ1BLcmRkUGNBU2lUellsWGRwa1Z1RDlodEJvNXNlOGVjaGZW?= =?utf-8?B?YnJWTHk4S1lva2Q0OFBPTHVLS2YzcXlkT3VMcUNvK3J5M0Z2d2M3MW5KVmFn?= =?utf-8?B?Z25QVitRZHVHdi9yNEVwM1NzUXh2UFVLcW4rOVY3TFNMaUVNcmt0QVpjY3Ur?= =?utf-8?B?M0FlaXc0eWZvYW52d2hyOTU1TUJ6VXFyY29vbFZSUU1nd3JRekRtUGZzU1Fp?= =?utf-8?B?b3lrUyszQWZZVmJlRGVKTm9HaU5iSmpHK1dFUVYrVHZJL3dxa0dLVXlraWFT?= =?utf-8?B?WHBSZEVobXhSY2FMOStRNnZjVENaQ1dFQVhJRkpnbjJUV0ZicEp5b291UCty?= =?utf-8?B?MUlZUnVvaGdhaTN3WkU5dHBiem5QMU1IaXNvRG9hVm42ckliTW9DemtFdVM5?= =?utf-8?B?d2N2Rjc3R3B1dEcvTzZod2RPMDdWckJ4QXdadUJuL2JqRXpJdGltbTRDWjhX?= =?utf-8?B?RCtWUnBPODlINnJpdmtVazdaQWpFV09pUHhKa3ZmT1ljbFNaQjNOTHlHUGQ4?= =?utf-8?B?RnpDRGVOVTRLZFlFbThqN05WU0tKYXY5ODNGdVc5d0NaVm5DcHZhallyWU0z?= =?utf-8?B?dEM1eGZJcTJOYWJXbzlvV1dwbkVKQzRnMThsSVhxQWFBUE55RnZVZHdVWkRq?= =?utf-8?B?QlBwVDdJVmFhVnpmNy9wM2ZCdC90RGhXS014dkxWYWpvQmtPS1MrdzNIRjB4?= =?utf-8?B?cElMbmorTEJBdittSzl4dllQOXBlMW9QbnNQUW1lUHpJeTJOQ2RaSURkUGE5?= =?utf-8?B?bzNJTENiQ3JqU2JOSEJaaFNpOEhpSmpPeFd5QUFycDJuKzFsWVB5REYrV3ZF?= =?utf-8?B?M3NKOXlnN1lzTzdoTno5L2ZFQTJSeUhpL1RTSGVYRENVNHdWRlBGWHExZmlP?= =?utf-8?B?S2ZkbDZObmFudTk0RG1XT2U2SFI4SGlsNG5GZzhGWU93RmJsQ3RiVGRJb2tS?= =?utf-8?B?N3FTNTIzUzBBSGQzL1ZBMVlPQ3d2b1F5Rk16K1ZjNDN1OEY2Wkt3NTUzSTVs?= =?utf-8?B?RWpxQ3Juckhyc0ZiSGR2eDRxT3FlSmlQOXpQd0U1YnF4a0dEM3FSeTlKQUFO?= =?utf-8?B?bnpRZWk0ZTZEYXFnamg2dDFvT1FBcXBSYndiUHFyM3RBS3F4OWIvZkVtSFA3?= =?utf-8?B?WEVMZWtJN2hPbG9mQjRtc0pHbkhSa216RE13YmVZQ0tSL2dlZ21oNHg3L01o?= =?utf-8?B?eUVOTW9ic0UvajEvNFdiV3BkMWJFc0ladWl5c1JIQ2VwOEpGUzNjeERhV3Np?= =?utf-8?B?d1E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mzv/9qxPHiNVMRoFSN/5qJWNwWhsDFOvjzQWVi/e2joMkrUExulAwflGpdkKHHUiJlkvo8xdhUGdUVFP/j3lBAJ4WnH3BqJGdUS0Wh0zFfSQcH3i1mtF697xRED9Ml0hvvmUe9Irn6dfSb2WD8uYNwoh+6rSAxnGwvDTtBy6ASsA71JXXszDT+tZLqLexrUesAMJX+10n7laWpcJY90frb4AFpDgY+K33gYc7kBp0zzEFDAhz8YoRfEmhl+/IrknFmjfcZUYVTi4a5rWQ697Dube/fbK8UtGkgvTRFxmUSudhZSwfkncF8vTiiZjryeaLscDOm/JatOod/6VKA2mD6JWfPkIaYHG4DW3krulNfHAajeRaNxFNni6sCiy7GiOG+zrgot4us501gIDc/ebU3vqPcso/odoj/2Glqv6a/TarcaMw2MD5aRdNrQJTuU/CDub/SGcLjfk16Od7/RXiyMVaH1DypEdRHdFNVZ7eyxp/hnMYhNzKOSGOSkjXDJhf5EHEpXlCathtd+I7wY39TDRWHOj/yUof2an5Y7LDbtlNQLo+Z+l04s9l2IwNhuDc29OSbn8yPP+17UpeMxXj1LmmWE4WiROgCGbufKX+NpgOplLEX0oLGjGl5k/fIEfzaJUUCmj1NfqGh8rVN/XQVWNbWIm31xb03F6gUrsKedtmV+u3gyxTILaLFgF4/4xy9qOz3SoTSKWETJLqfLY2PWSpBnYhEqEzATy3Tx7nC7bHoc3sVzCl4tDWJlCHTUr1pcltHtDEoFIhIkzs0ZeTNC7T7BuXKuxRbqr+IpPdaM0HABVKDQerJ7mEa0VJxKt0+j5QNaiZ1EOVjGIn2KGmv121oqJozLixx0WV+pFWVvTjJcVU/HMTrLBEbdGGHg8CJcBxW693JWORXJEWq/Tr2Sg1NG95m0wP53DdhtrN/8= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: af59176e-0ab2-4835-028b-08db992a3418 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 22:44:35.4828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HW/KzBCzOEfpM8V/3cuG9JNAOpaKvF2XS4QBT0yYMU64+ZieX2ck3/9WmEkRC+KZOTPF4JMQt0fgR90sjyDJVYHfebl4X//rLDwKJTy7//o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4969 On 09/08/2023 11:34 pm, Stefano Stabellini wrote: > On Wed, 9 Aug 2023, Andrew Cooper wrote: >> On 09/08/2023 10:43 pm, Stefano Stabellini wrote: >>> On Wed, 9 Aug 2023, Andrew Cooper wrote: >>>> On 07/08/2023 2:24 am, Henry Wang wrote: >>>>> Hi everyone, >>>>> >>>>> Following the release schedule discussion in in April, I am sending this email >>>>> to remind that according to the release schedule [1], August 11 (this Friday) >>>>> will be the last posting date, when patches adding new features are expected >>>>> to be posted to the mailing list by this date. >>>>> >>>>> Also, note that we currently have 1 release blocker [2] which might need >>>>> some attention. >>>>> >>>>> [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ >>>>> [2] https://gitlab.com/xen-project/xen/-/issues/114 >>>> Off the top of my head. >>>> >>>> There are still unaddressed Gitlab bugs from the Eclair integration >>> The bug you managed to find it is now fixed (commit e55146071de9). I am >>> all for fixing Gitlab bugs so let me know if you find anything else! I >>> am not aware of any other issue with Eclair at the moment. >> I meant the one where Eclair is still running on `smoke` and twiddling >> its thumbs for 1h doing so each time OSSTest says yes to a push.  It >> will be a missing 'exclude' somewhere, but I haven't hand enough time to >> look. > Ah, yes, got it. I would call it "Eclair lagging behind". I am happy for > this to be a blocker. Something else for the list is to see about trimming down the testing we're doing. I had to cancel 7 pipelines (mostly patchew) in order to get a gitlab run on a late-breaking tweak on the security content yesterday. Take https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/959800176 as an example.  Nearly 2h to run, and queued for 2h before that waiting to start.  This is not a rare occurrence right now. >>>> and other Gitlab bugs (use of unstable containers) which I'd unwilling >>>> to let 4.18 be released with, given the pain we've had on the stable >>>> trees trying to keep CI working. >>> That is fair enough. To make this more concrete and easier to track, the >>> following would need to be changed to using stable containers: >>> >>> - .qemu-arm64 >>> - .qemu-arm32 >>> (I am not counting .qemu-riscv64) >>> >>> Andrew, is that what you meant? Am I missing anything? >> Every debian unstable container, and the other containers (OpenSUSE) >> which are using an non-specific upstream version.  Upstreams which >> really are rolling distros (Arch, Tumbleweed) need to be made non-fatal. > I was more asking whether for 4.18 you want to fix only test.yaml or > also build.yaml. (Typically it is test.yaml that causes most issues > with rolling containers.) Everything.  Because both bite equally hard in stable trees. It's not hard to do - just needs some time. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:49:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:49:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581448.910166 (Exim 4.92) (envelope-from ) id 1qTrzK-0004Vj-N6; Wed, 09 Aug 2023 22:49:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581448.910166; Wed, 09 Aug 2023 22:49:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzK-0004Uz-Gb; Wed, 09 Aug 2023 22:49:10 +0000 Received: by outflank-mailman (input) for mailman id 581448; Wed, 09 Aug 2023 22:49:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzJ-0004Dn-BI for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:49:09 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f1dc15dc-3706-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 00:49:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id A57B58285C34; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id s871nVlU1vyy; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id CAC528285C0F; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3p-JqTwgk6O9; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 6B1438285613; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1dc15dc-3706-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com CAC528285C0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691621344; bh=7Z9IMg+s5CRD9k15jzJgSyuW7KZ1vrdUuV+kANxVxYA=; h=From:To:Date:Message-Id:MIME-Version; b=nRxLrp56Inmh/eYqB4YDJg0lBIhKdskfFN7tGBYS/68AXLYW2RfPiW/I/pV1VE2MQ g+VKOy7lOva1R1DifIYr+G6UupGjmLXVTdCQahTSIaVjj0jLxDmv8zd+PQs9mFZWpE BboFkSUFJsTDY6qIVMBrwOInKJfpUZtKf3DdrFys= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v3 1/3] xen/ppc: Bump minimum target ISA to 3.0 (POWER9) Date: Wed, 9 Aug 2023 17:48:53 -0500 Message-Id: <7d9380f413226e4f41d1137110e2bb78980d1b1a.1691620546.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B from the supported ISA list to avoid having a non-working configuration in tree. It can be re-added at a later point when Hash MMU support is added. Signed-off-by: Shawn Anastasio --- v3: no changes. v2: no changes. xen/arch/ppc/Kconfig | 7 +------ xen/arch/ppc/arch.mk | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/xen/arch/ppc/Kconfig b/xen/arch/ppc/Kconfig index b32dce39b8..ab116ffb2a 100644 --- a/xen/arch/ppc/Kconfig +++ b/xen/arch/ppc/Kconfig @@ -20,15 +20,10 @@ menu "ISA Selection" choice prompt "Base ISA" - default POWER_ISA_2_07B + default POWER_ISA_3_00 help This selects the base ISA version that Xen will target. -config POWER_ISA_2_07B - bool "Power ISA 2.07B (POWER8)" - help - Target version 2.07B of the Power ISA (POWER8) or later - config POWER_ISA_3_00 bool "Power ISA 3.00 (POWER9)" help diff --git a/xen/arch/ppc/arch.mk b/xen/arch/ppc/arch.mk index 3bf79bac37..d05cbf1df5 100644 --- a/xen/arch/ppc/arch.mk +++ b/xen/arch/ppc/arch.mk @@ -1,7 +1,6 @@ ######################################## # Power-specific definitions -ppc-march-$(CONFIG_POWER_ISA_2_07B) :=3D power8 ppc-march-$(CONFIG_POWER_ISA_3_00) :=3D power9 CFLAGS +=3D -m64 -mlittle-endian -mcpu=3D$(ppc-march-y) -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:49:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:49:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581446.910151 (Exim 4.92) (envelope-from ) id 1qTrzJ-0004Dq-3k; Wed, 09 Aug 2023 22:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581446.910151; Wed, 09 Aug 2023 22:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzJ-0004Di-0z; Wed, 09 Aug 2023 22:49:09 +0000 Received: by outflank-mailman (input) for mailman id 581446; Wed, 09 Aug 2023 22:49:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzI-0004DZ-C0 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:49:08 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f1df0abe-3706-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:49:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 72BEA828663A; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id KJP5SenASSx8; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 65E8C8285387; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4YyV_GkeTTjy; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id E59BF8285225; Wed, 9 Aug 2023 17:49:03 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1df0abe-3706-11ee-b282-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 65E8C8285387 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691621344; bh=Azi1XUqDdDmUx2jIDtnQNFXM9Pbptush/zECpYWLo5U=; h=From:To:Date:Message-Id:MIME-Version; b=Tud/wSlJhl7HchSQ5SvLl70ie8GlGp2LwCt+9k9oF8K/Xc8rdBmlX/t6AXjVOXfq3 7NKixkfgPKq0is0cSpOGUehd4+Fp4jVmUM6bD2tjvS/l5pXJPA1cybgff92zLJj07A xELUtNZ6S5Hy61BMkHlA6b71gskUVKcKKqABaCOg= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v3 0/3] xen/ppc: Add early Radix MMU support Date: Wed, 9 Aug 2023 17:48:52 -0500 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable (v3: Apologies for the noise, but v2 was submitted in error and was missing a few changes to patch 3 that were discussed) Hello all, This series adds support for bringing up the Radix MMU with basic identity-mapped page tables. In order to simplify the memory layout, the series changes XEN_VIRT _START to 0xC000_0000_0000_0000, which has a couple of convenient properties. When the MMU is off, the top 4 address bits are ignored by the hardware, so this is equivalent to physical address 0. When the MMU is enabled, the top 4 address bits are used to select the memory quadrant, and 0xC corresponds to quadrant 3 which is used for kernel memory. Thus, by linking the kernel here and ensuring its physical load address is 0x0, we are able to run at the correct address both before and after the MMU is enabled. Additionally, as the Radix MMU was only added in ISA 3.0 (POWER9), this series also drops support for POWER8 for now, to avoid having a non-working build configuration in-tree. Thanks, Shawn Shawn Anastasio (3): xen/ppc: Bump minimum target ISA to 3.0 (POWER9) xen/ppc: Relocate kernel to physical address 0 on boot xen/ppc: Implement initial Radix MMU support xen/arch/ppc/Kconfig | 7 +- xen/arch/ppc/Makefile | 2 + xen/arch/ppc/arch.mk | 1 - xen/arch/ppc/include/asm/bitops.h | 9 + xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/include/asm/mm.h | 18 ++ xen/arch/ppc/include/asm/page-bits.h | 3 +- xen/arch/ppc/include/asm/page.h | 179 ++++++++++++++++++ xen/arch/ppc/include/asm/processor.h | 34 ++++ xen/arch/ppc/include/asm/regs.h | 138 ++++++++++++++ xen/arch/ppc/include/asm/types.h | 1 + xen/arch/ppc/mm-radix.c | 265 +++++++++++++++++++++++++++ xen/arch/ppc/ppc64/head.S | 42 +++++ xen/arch/ppc/setup.c | 3 + xen/arch/ppc/tlb-radix.c | 96 ++++++++++ 15 files changed, 791 insertions(+), 9 deletions(-) create mode 100644 xen/arch/ppc/include/asm/bitops.h create mode 100644 xen/arch/ppc/include/asm/mm.h create mode 100644 xen/arch/ppc/include/asm/page.h create mode 100644 xen/arch/ppc/include/asm/regs.h create mode 100644 xen/arch/ppc/mm-radix.c create mode 100644 xen/arch/ppc/tlb-radix.c -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:49:11 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:49:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581447.910161 (Exim 4.92) (envelope-from ) id 1qTrzK-0004T1-CW; Wed, 09 Aug 2023 22:49:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581447.910161; Wed, 09 Aug 2023 22:49:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzK-0004Su-9J; Wed, 09 Aug 2023 22:49:10 +0000 Received: by outflank-mailman (input) for mailman id 581447; Wed, 09 Aug 2023 22:49:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzJ-0004DZ-1j for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:49:09 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f22dc019-3706-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:49:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 85B318285225; Wed, 9 Aug 2023 17:49:06 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id I6z8AMxnP63O; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 616A28285613; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WL2-DLOhLwdh; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id CBB798285C34; Wed, 9 Aug 2023 17:49:04 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f22dc019-3706-11ee-b282-6b7b168915f2 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 616A28285613 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691621345; bh=qrDPK5kIJ0/XTMRACSx+12t+ew2IakgJ1JW1Q6vpgG0=; h=From:To:Date:Message-Id:MIME-Version; b=oLD9Fjj9lEJ8yWi1SMp8uEhy58pEuf1kdq/qquy8p5/xaVlsp+cblyYWXEacxo86j P+JO8FaU9e38NGteLGASs86DClTVp0tgfG9FeJX4iBlE72Rqti108vivuF8GDXWrrm nVRIl4NJRmMhBK5wLdvkNNudvuacnuvZgAQ1lN54= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v3 2/3] xen/ppc: Relocate kernel to physical address 0 on boot Date: Wed, 9 Aug 2023 17:48:54 -0500 Message-Id: <6b965917ffb2185c541f04ff18a624282ca6e211.1691620546.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Introduce a small assembly loop in `start` to copy the kernel to physical address 0 before continuing. This ensures that the physical address lines up with XEN_VIRT_START (0xc000000000000000) and allows us to identity map the kernel when the MMU is set up in the next patch. We are also able to start execution at XEN_VIRT_START after the copy since hardware will ignore the top 4 address bits when operating in Real Mode (MMU off). Signed-off-by: Shawn Anastasio --- v3: no changes. v2: - Fix definition of XEN_VIRT_START macro which incorrectly used _AT instead of _AC. - Use _start instead of start as symbol referring to beginning of Xen binary xen/arch/ppc/include/asm/config.h | 2 +- xen/arch/ppc/ppc64/head.S | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/xen/arch/ppc/include/asm/config.h b/xen/arch/ppc/include/asm= /config.h index d060f0dca7..30438d22d2 100644 --- a/xen/arch/ppc/include/asm/config.h +++ b/xen/arch/ppc/include/asm/config.h @@ -39,7 +39,7 @@ name: #endif -#define XEN_VIRT_START _AT(UL, 0xc000000000000000) +#define XEN_VIRT_START _AC(0xc000000000000000, UL) #define SMP_CACHE_BYTES (1 << 6) diff --git a/xen/arch/ppc/ppc64/head.S b/xen/arch/ppc/ppc64/head.S index 8f1e5d3ad2..149af2c472 100644 --- a/xen/arch/ppc/ppc64/head.S +++ b/xen/arch/ppc/ppc64/head.S @@ -17,6 +17,33 @@ ENTRY(start) addis %r2, %r12, .TOC.-1b@ha addi %r2, %r2, .TOC.-1b@l + /* + * Copy Xen to physical address zero and jump to XEN_VIRT_START + * (0xc000000000000000). This works because the hardware will ignore= the top + * four address bits when the MMU is off. + */ + LOAD_REG_ADDR(%r1, _start) + LOAD_IMM64(%r12, XEN_VIRT_START) + + /* If we're at the correct address, skip copy */ + cmpld %r1, %r12 + beq .L_correct_address + + /* Copy bytes until _end */ + LOAD_REG_ADDR(%r11, _end) + addi %r1, %r1, -8 + li %r13, -8 +.L_copy_xen: + ldu %r10, 8(%r1) + stdu %r10, 8(%r13) + cmpld %r1, %r11 + blt .L_copy_xen + + /* Jump to XEN_VIRT_START */ + mtctr %r12 + bctr +.L_correct_address: + /* set up the initial stack */ LOAD_REG_ADDR(%r1, cpu0_boot_stack) li %r11, 0 -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:49:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:49:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581449.910181 (Exim 4.92) (envelope-from ) id 1qTrzN-00050P-84; Wed, 09 Aug 2023 22:49:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581449.910181; Wed, 09 Aug 2023 22:49:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzN-000506-3F; Wed, 09 Aug 2023 22:49:13 +0000 Received: by outflank-mailman (input) for mailman id 581449; Wed, 09 Aug 2023 22:49:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTrzM-0004Dn-Fk for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:49:12 +0000 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f397e6bf-3706-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 00:49:09 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id D3D088285225; Wed, 9 Aug 2023 17:49:08 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kC4o0gValSCQ; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id D22A08285387; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LVlMT_cAQN4w; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) Received: from raptor-ewks-026.lan (5.edge.rptsys.com [23.155.224.38]) by mail.rptsys.com (Postfix) with ESMTPSA id 591A48285225; Wed, 9 Aug 2023 17:49:05 -0500 (CDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f397e6bf-3706-11ee-8613-37d641c3527e DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com D22A08285387 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1691621345; bh=ZSuXcMQdvaB1FrdlsSYRktnjkCQuYOrqO1hk6jwASk4=; h=From:To:Date:Message-Id:MIME-Version; b=HFG8ACUcQ1NSx5ionDhm1WNRx+pWY89BDBaJIxNNTcKVY59vDmCQcWvHbdVYs/k4L f6Lou05prWLwjqcLGwmuUWQBh322Qm8rRk+BxkdBdmWJpgyBfUifjaD/MEeUQTbNdW nMnrG6uYUKL1FANV4k672qQa21BIa47gvcuBJIeA= X-Virus-Scanned: amavisd-new at rptsys.com From: Shawn Anastasio To: xen-devel@lists.xenproject.org Cc: Timothy Pearson , Andrew Cooper , Jan Beulich , Shawn Anastasio Subject: [PATCH v3 3/3] xen/ppc: Implement initial Radix MMU support Date: Wed, 9 Aug 2023 17:48:55 -0500 Message-Id: <6bacc1ca18273654229672e6ba2741da01a92f04.1691620546.git.sanastasio@raptorengineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Add code to construct early identity-mapped page tables as well as the required process and partition tables to enable the MMU. Signed-off-by: Shawn Anastasio --- v3: - Add XEN_PT_SIZE_LVL() macro for calculating the size in bytes of a page directory/page table structure. - Add alignment to struct lvl$N_{pd,pt} types. - Don't require aligned `paddr` in paddr_to_{pde,pte} - Fix RTS_FIELD comment bit numbering v2: - Add missing ')' to mm.h/maddr_to_virt definition - Add missing parens around `va` argument in XEN_PT_INDEX_LVL - Drop '&' asm constraint modifier in processor.h/mfmsr() - Fix asm constraint formatting in processor.h - Change mtspr,mfspr to functions in processor.h - Drop unnecessary _Static_assert in mm-radix.c - Drop unnecessary cast in setup_initial_mapping - Use __va() to obtain pde/pte addresses in setup_initial_mapping - Wrap >80col lines in mm-radix.c - Drop unnecessary parameters in setup_{process,partition}_table - Add __init to setup_{process,partition}_table - Drop unnecessary opal.c changes - Drop manual prototype of setup_initial_pagetables in setup.c in favor of using the one already in asm/mm.h - Fix formatting of tlbiel asm block in tlb-radix.c xen/arch/ppc/Makefile | 2 + xen/arch/ppc/include/asm/bitops.h | 9 + xen/arch/ppc/include/asm/mm.h | 18 ++ xen/arch/ppc/include/asm/page-bits.h | 3 +- xen/arch/ppc/include/asm/page.h | 179 ++++++++++++++++++ xen/arch/ppc/include/asm/processor.h | 34 ++++ xen/arch/ppc/include/asm/regs.h | 138 ++++++++++++++ xen/arch/ppc/include/asm/types.h | 1 + xen/arch/ppc/mm-radix.c | 265 +++++++++++++++++++++++++++ xen/arch/ppc/ppc64/head.S | 15 ++ xen/arch/ppc/setup.c | 3 + xen/arch/ppc/tlb-radix.c | 96 ++++++++++ 12 files changed, 762 insertions(+), 1 deletion(-) create mode 100644 xen/arch/ppc/include/asm/bitops.h create mode 100644 xen/arch/ppc/include/asm/mm.h create mode 100644 xen/arch/ppc/include/asm/page.h create mode 100644 xen/arch/ppc/include/asm/regs.h create mode 100644 xen/arch/ppc/mm-radix.c create mode 100644 xen/arch/ppc/tlb-radix.c diff --git a/xen/arch/ppc/Makefile b/xen/arch/ppc/Makefile index 0c0a7884a1..a059ac4c0a 100644 --- a/xen/arch/ppc/Makefile +++ b/xen/arch/ppc/Makefile @@ -2,8 +2,10 @@ obj-$(CONFIG_PPC64) +=3D ppc64/ obj-y +=3D boot-of.init.o obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.init.o +obj-y +=3D mm-radix.o obj-y +=3D opal.o obj-y +=3D setup.o +obj-y +=3D tlb-radix.o $(TARGET): $(TARGET)-syms cp -f $< $@ diff --git a/xen/arch/ppc/include/asm/bitops.h b/xen/arch/ppc/include/asm= /bitops.h new file mode 100644 index 0000000000..548e97b414 --- /dev/null +++ b/xen/arch/ppc/include/asm/bitops.h @@ -0,0 +1,9 @@ +#ifndef _ASM_PPC_BITOPS_H +#define _ASM_PPC_BITOPS_H + +/* PPC bit number conversion */ +#define PPC_BITLSHIFT(be) (BITS_PER_LONG - 1 - (be)) +#define PPC_BIT(bit) (1UL << PPC_BITLSHIFT(bit)) +#define PPC_BITMASK(bs, be) ((PPC_BIT(bs) - PPC_BIT(be)) | PPC_BIT(bs)) + +#endif /* _ASM_PPC_BITOPS_H */ diff --git a/xen/arch/ppc/include/asm/mm.h b/xen/arch/ppc/include/asm/mm.= h new file mode 100644 index 0000000000..c85a7ed686 --- /dev/null +++ b/xen/arch/ppc/include/asm/mm.h @@ -0,0 +1,18 @@ +#ifndef _ASM_PPC_MM_H +#define _ASM_PPC_MM_H + +#include + +#define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT) +#define paddr_to_pfn(pa) ((unsigned long)((pa) >> PAGE_SHIFT)) + +#define virt_to_maddr(va) ((paddr_t)((vaddr_t)(va) & PADDR_MASK)) +#define maddr_to_virt(pa) ((void *)((paddr_t)(pa) | XEN_VIRT_START)) + +/* Convert between Xen-heap virtual addresses and machine addresses. */ +#define __pa(x) (virt_to_maddr(x)) +#define __va(x) (maddr_to_virt(x)) + +void setup_initial_pagetables(void); + +#endif /* _ASM_PPC_MM_H */ diff --git a/xen/arch/ppc/include/asm/page-bits.h b/xen/arch/ppc/include/= asm/page-bits.h index 4c01bf9716..0286177520 100644 --- a/xen/arch/ppc/include/asm/page-bits.h +++ b/xen/arch/ppc/include/asm/page-bits.h @@ -2,6 +2,7 @@ #define __PPC_PAGE_BITS_H__ #define PAGE_SHIFT 16 /* 64 KiB Pages */ -#define PADDR_BITS 48 +#define PADDR_BITS 53 +#define VADDR_BITS 52 #endif /* __PPC_PAGE_BITS_H__ */ diff --git a/xen/arch/ppc/include/asm/page.h b/xen/arch/ppc/include/asm/p= age.h new file mode 100644 index 0000000000..51667a5e96 --- /dev/null +++ b/xen/arch/ppc/include/asm/page.h @@ -0,0 +1,181 @@ +#ifndef _ASM_PPC_PAGE_H +#define _ASM_PPC_PAGE_H + +#include + +#include +#include + +#define PDE_VALID PPC_BIT(0) +#define PDE_NLB_MASK 0xfffffffffffffUL +#define PDE_NLB_SHIFT 5UL +#define PDE_NLS_MASK 0x1f + +#define PTE_VALID PPC_BIT(0) +#define PTE_LEAF PPC_BIT(1) +#define PTE_REFERENCE PPC_BIT(55) +#define PTE_CHANGE PPC_BIT(56) + +/* PTE Attributes */ +#define PTE_ATT_SAO PPC_BIT(59) /* Strong Access Ordering */ +#define PTE_ATT_NON_IDEMPOTENT PPC_BIT(58) +#define PTE_ATT_TOLERANT (PPC_BIT(58) | PPC_BIT(59)) + +/* PTE Encoded Access Authority*/ +#define PTE_EAA_PRIVILEGED PPC_BIT(60) +#define PTE_EAA_READ PPC_BIT(61) +#define PTE_EAA_WRITE PPC_BIT(62) +#define PTE_EAA_EXECUTE PPC_BIT(63) + +/* Field shifts/masks */ +#define PTE_RPN_MASK 0x1fffffffffffUL +#define PTE_RPN_SHIFT 12UL +#define PTE_ATT_MASK 0x3UL +#define PTE_ATT_SHIFT 4UL +#define PTE_EAA_MASK 0xfUL + +#define PTE_XEN_BASE (PTE_VALID | PTE_EAA_PRIVILEGED | PTE_REFERENCE) +#define PTE_XEN_RW (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_WRITE | PTE_= CHANGE) +#define PTE_XEN_RO (PTE_XEN_BASE | PTE_EAA_READ) +#define PTE_XEN_RX (PTE_XEN_BASE | PTE_EAA_READ | PTE_EAA_EXECUTE) + +/* + * Radix Tree layout for 64KB pages: + * + * [ L1 (ROOT) PAGE DIRECTORY (8192 * sizeof(pde_t)) ] + * | + * | + * v + * [ L2 PAGE DIRECTORY (512 * sizeof(pde_t)) ] + * | + * | + * v + * [ L3 PAGE DIRECTORY (512 * sizeof(pde_t)) ] + * | + * | + * v + * [ L4 PAGE TABLE (32 * sizeof(pte_t)) ] + * | + * | + * v + * [ PAGE TABLE ENTRY ] + */ + +#define XEN_PT_ENTRIES_LOG2_LVL_1 13 /* 2**13 entries, maps 2**13 * 512G= B =3D 4PB */ +#define XEN_PT_ENTRIES_LOG2_LVL_2 9 /* 2**9 entries, maps 2**9 * 1GB = =3D 512GB */ +#define XEN_PT_ENTRIES_LOG2_LVL_3 9 /* 2**9 entries, maps 2**9 * 1GB = =3D 512GB */ +#define XEN_PT_ENTRIES_LOG2_LVL_4 5 /* 2**5 entries, maps 2**5 * 64K = =3D 2MB */ + +#define XEN_PT_SHIFT_LVL_1 (XEN_PT_SHIFT_LVL_2 + XEN_PT_ENTRIES_LOG2_= LVL_2) +#define XEN_PT_SHIFT_LVL_2 (XEN_PT_SHIFT_LVL_3 + XEN_PT_ENTRIES_LOG2_= LVL_3) +#define XEN_PT_SHIFT_LVL_3 (XEN_PT_SHIFT_LVL_4 + XEN_PT_ENTRIES_LOG2_= LVL_4) +#define XEN_PT_SHIFT_LVL_4 PAGE_SHIFT + +#define XEN_PT_ENTRIES_LOG2_LVL(lvl) (XEN_PT_ENTRIES_LOG2_LVL_##lvl) +#define XEN_PT_SHIFT_LVL(lvl) (XEN_PT_SHIFT_LVL_##lvl) +#define XEN_PT_ENTRIES_LVL(lvl) (1UL << XEN_PT_ENTRIES_LOG2_LVL(lvl= )) +#define XEN_PT_SIZE_LVL(lvl) (sizeof(uint64_t) * XEN_PT_ENTRIES_= LVL(lvl)) +#define XEN_PT_MASK_LVL(lvl) (XEN_PT_ENTRIES_LVL(lvl) - 1) +#define XEN_PT_INDEX_LVL(lvl, va) (((va) >> XEN_PT_SHIFT_LVL(lvl)) & = XEN_PT_MASK_LVL(lvl)) + +/* + * Calculate the index of the provided virtual address in the provided + * page table struct + */ +#define pt_index(pt, va) _Generic((pt), \ + struct lvl1_pd * : XEN_PT_INDEX_LVL(1, (va)), \ + struct lvl2_pd * : XEN_PT_INDEX_LVL(2, (va)), \ + struct lvl3_pd * : XEN_PT_INDEX_LVL(3, (va)), \ + struct lvl4_pt * : XEN_PT_INDEX_LVL(4, (va))) + +#define pt_entry(pt, va) (&((pt)->entries[pt_index((pt), (va))])) + +typedef struct +{ + __be64 pde; +} pde_t; + +typedef struct +{ + __be64 pte; +} pte_t; + +struct lvl1_pd +{ + pde_t entries[XEN_PT_ENTRIES_LVL(1)]; +} __aligned(XEN_PT_SIZE_LVL(1)); + +struct lvl2_pd +{ + pde_t entries[XEN_PT_ENTRIES_LVL(2)]; +} __aligned(XEN_PT_SIZE_LVL(2)); + +struct lvl3_pd +{ + pde_t entries[XEN_PT_ENTRIES_LVL(3)]; +} __aligned(XEN_PT_SIZE_LVL(3)); + +struct lvl4_pt +{ + pte_t entries[XEN_PT_ENTRIES_LVL(4)]; +} __aligned(XEN_PT_SIZE_LVL(4)); + +static inline pte_t paddr_to_pte(paddr_t paddr, unsigned long flags) +{ + paddr_t paddr_aligned =3D paddr & (PTE_RPN_MASK << PTE_RPN_SHIFT); + return (pte_t){ .pte =3D cpu_to_be64(paddr_aligned | flags | PTE_LEA= F) }; +} + +static inline pde_t paddr_to_pde(paddr_t paddr, unsigned long flags, uns= igned long nls) +{ + paddr_t paddr_aligned =3D paddr & (PDE_NLB_MASK << PDE_NLB_SHIFT); + return (pde_t){ .pde =3D cpu_to_be64(paddr_aligned | flags | nls) }; +} + +static inline paddr_t pte_to_paddr(pte_t pte) +{ + return be64_to_cpu(pte.pte) & (PTE_RPN_MASK << PTE_RPN_SHIFT); +} + +static inline paddr_t pde_to_paddr(pde_t pde) +{ + return be64_to_cpu(pde.pde) & (PDE_NLB_MASK << PDE_NLB_SHIFT); +} + +static inline bool pte_is_valid(pte_t pte) +{ + return pte.pte & be64_to_cpu(PTE_VALID); +} + +static inline bool pde_is_valid(pde_t pde) +{ + return pde.pde & be64_to_cpu(PDE_VALID); +} + +/* + * ISA 3.0 partition and process table entry format + */ +struct patb_entry { + __be64 patb0; + __be64 patb1; +}; +#define PATB0_HR PPC_BIT(0) /* host uses radix */ +#define PATB1_GR PPC_BIT(0) /* guest uses radix; must match HR */ + +struct prtb_entry { + __be64 prtb0; + __be64 reserved; +}; + +/* + * We support 52 bits, hence: + * bits 52 - 31 =3D 21, 0b10101 + * RTS encoding details + * bits 0 - 2 of rts -> bits 5 - 7 of unsigned long + * bits 3 - 4 of rts -> bits 61 - 62 of unsigned long + */ +#define RTS_FIELD ((0x2UL << 61) | (0x5UL << 5)) + +void tlbie_all(void); + +#endif /* _ASM_PPC_PAGE_H */ diff --git a/xen/arch/ppc/include/asm/processor.h b/xen/arch/ppc/include/= asm/processor.h index 2300640787..6b70569eb8 100644 --- a/xen/arch/ppc/include/asm/processor.h +++ b/xen/arch/ppc/include/asm/processor.h @@ -133,6 +133,40 @@ struct cpu_user_regs uint32_t entry_vector; }; +static __inline__ void sync(void) +{ + asm volatile ( "sync" ); +} + +static __inline__ void isync(void) +{ + asm volatile ( "isync" ); +} + +static inline unsigned long mfmsr(void) +{ + unsigned long msr; + asm volatile ( "mfmsr %0" : "=3Dr" (msr) ); + return msr; +} + +static inline void mtmsrd(unsigned long msr) +{ + asm volatile ( "mtmsrd %0" : : "r" (msr) ); +} + +static inline void mtspr(uint16_t spr, unsigned long val) +{ + asm volatile ( "mtspr %0, %1" : : "K" (spr), "r" (val) ); +} + +static inline unsigned long mfspr(uint16_t spr) +{ + unsigned long val; + asm volatile ( "mfspr %0, %1" : "=3Dr" (val) : "K" (spr) ); + return val; +} + /* * panic() isn't available at the moment so an infinite loop will be * used temporarily. diff --git a/xen/arch/ppc/include/asm/regs.h b/xen/arch/ppc/include/asm/r= egs.h new file mode 100644 index 0000000000..d5f47a6ff1 --- /dev/null +++ b/xen/arch/ppc/include/asm/regs.h @@ -0,0 +1,138 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, = USA. + * + * Copyright IBM Corp. 2005, 2007 + * + * Authors: Jimi Xenidis + * Christian Ehrhardt + */ + +#ifndef _ASM_REG_DEFS_H_ +#define _ASM_REG_DEFS_H_ + +/* Special Purpose Registers */ +#define SPRN_VRSAVE 256 +#define SPRN_DSISR 18 +#define SPRN_DAR 19 +#define SPRN_DEC 22 +#define SPRN_SRR0 26 +#define SPRN_SRR1 27 +#define SPRN_TBRL 268 +#define SPRN_TBRU 269 +#define SPRN_SPRG0 272 +#define SPRN_SPRG1 273 +#define SPRN_SPRG2 274 +#define SPRN_SPRG3 275 +#define SPRN_TBWL 284 +#define SPRN_TBWU 285 + +#define SPRN_HSPRG0 304 +#define SPRN_HSPRG1 305 +#define SPRN_HDEC 310 +#define SPRN_HIOR 311 +#define SPRN_RMOR 312 +#define SPRN_HRMOR 313 +#define SPRN_HSRR0 314 +#define SPRN_HSRR1 315 +#define SPRN_LPIDR 319 + +#define SPRN_PTCR 0x1D0 /* Partition table control Register */ +#define SPRN_PID 0x030 /* Process ID */ + +/* Performance monitor spr encodings */ +#define SPRN_MMCRA 786 +#define MMCRA_SAMPHV _AC(0x10000000, UL) /* state of MSR HV when SI= AR set */ +#define MMCRA_SAMPPR _AC(0x08000000, UL) /* state of MSR PR when SI= AR set */ +#define MMCRA_SAMPLE_ENABLE _AC(0x00000001, UL) /* enable sampling */ +#define NUM_PMCS 8 +#define SPRN_PMC1 787 +#define SPRN_PMC2 788 +#define SPRN_PMC3 789 +#define SPRN_PMC4 790 +#define SPRN_PMC5 791 +#define SPRN_PMC6 792 +#define SPRN_PMC7 793 +#define SPRN_PMC8 794 +#define SPRN_MMCR0 795 +#define MMCR0_FC _AC(0x80000000, UL) /* freeze counters */ +#define MMCR0_FCS _AC(0x40000000, UL) /* freeze in supervisor stat= e */ +#define MMCR0_FCP _AC(0x20000000, UL) /* freeze in problem state *= / +#define MMCR0_FCM1 _AC(0x10000000, UL) /* freeze counters while MSR= mark =3D 1 */ +#define MMCR0_FCM0 _AC(0x08000000, UL) /* freeze counters while MSR= mark =3D 0 */ +#define MMCR0_PMAE _AC(0x04000000, UL) /* performance monitor alert= enabled */ +#define MMCR0_PMAO _AC(0x00000080, UL) /* performance monitor alert= occurred */ +#define MMCR0_FCH _AC(0x00000001, UL) /* freeze conditions in hype= rvisor */ +#define SPRN_SIAR 796 +#define SPRN_SDAR 797 +#define SPRN_MMCR1 798 + +/* As defined for PU G4 */ +#define SPRN_HID0 1008 +#define SPRN_HID1 1009 +#define SPRN_HID4 1012 + +#define SPRN_DABR 1013 +#define SPRN_HID5 1014 +#define SPRN_DABRX 1015 +#define SPRN_HID6 1017 +#define SPRN_HID7 1018 +#define SPRN_HID8 1019 +#define SPRN_PIR 1023 + +#define SPRN_LPCR 0x13E /* LPAR Control Register */ +#define LPCR_VPM0 _AC(0x8000000000000000, UL) +#define LPCR_VPM1 _AC(0x4000000000000000, UL) +#define LPCR_ISL _AC(0x2000000000000000, UL) +#define LPCR_VC_SH 61 +#define LPCR_DPFD_SH 52 +#define LPCR_DPFD (_AC(7, UL) << LPCR_DPFD_SH) +#define LPCR_VRMASD_SH 47 +#define LPCR_VRMASD (_AC(0x1f, UL) << LPCR_VRMASD_SH) +#define LPCR_VRMA_L _AC(0x0008000000000000, UL) +#define LPCR_VRMA_LP0 _AC(0x0001000000000000, UL) +#define LPCR_VRMA_LP1 _AC(0x0000800000000000, UL) +#define LPCR_RMLS 0x1C000000 /* Implementation dependent RMO limit se= l */ +#define LPCR_RMLS_SH 26 +#define LPCR_HAIL _AC(0x0000000004000000, UL) /* HV AIL (ISAv3.1) *= / +#define LPCR_ILE _AC(0x0000000002000000, UL) /* !HV irqs set MSR:LE= */ +#define LPCR_AIL _AC(0x0000000001800000, UL) /* Alternate interrupt l= ocation */ +#define LPCR_AIL_0 _AC(0x0000000000000000, UL) /* MMU off exception o= ffset 0x0 */ +#define LPCR_AIL_3 _AC(0x0000000001800000, UL) /* MMU on exception = offset 0xc00...4xxx */ +#define LPCR_ONL _AC(0x0000000000040000, UL) /* online - PURR/SPURR c= ount */ +#define LPCR_LD _AC(0x0000000000020000, UL) /* large decremeter */ +#define LPCR_PECE _AC(0x000000000001f000, UL) /* powersave exit cause= enable */ +#define LPCR_PECEDP _AC(0x0000000000010000, UL) /* directed priv dbe= lls cause exit */ +#define LPCR_PECEDH _AC(0x0000000000008000, UL) /* directed hyp dbel= ls cause exit */ +#define LPCR_PECE0 _AC(0x0000000000004000, UL) /* ext. exceptions c= an cause exit */ +#define LPCR_PECE1 _AC(0x0000000000002000, UL) /* decrementer can c= ause exit */ +#define LPCR_PECE2 _AC(0x0000000000001000, UL) /* machine check etc= can cause exit */ +#define LPCR_PECE_HVEE _AC(0x0000400000000000, UL) /* P9 Wakeup on H= V interrupts */ +#define LPCR_MER _AC(0x0000000000000800, UL) /* Mediated External Exc= eption */ +#define LPCR_MER_SH 11 +#define LPCR_GTSE _AC(0x0000000000000400, UL) /* Guest Translation = Shootdown Enable */ +#define LPCR_TC _AC(0x0000000000000200, UL) /* Translation control */ +#define LPCR_HEIC _AC(0x0000000000000010, UL) /* Hypervisor Externa= l Interrupt Control */ +#define LPCR_LPES 0x0000000c +#define LPCR_LPES0 _AC(0x0000000000000008, UL) /* LPAR Env selec= tor 0 */ +#define LPCR_LPES1 _AC(0x0000000000000004, UL) /* LPAR Env selec= tor 1 */ +#define LPCR_LPES_SH 2 +#define LPCR_RMI _AC(0x0000000000000002, UL) /* real mode is cac= he inhibit */ +#define LPCR_HVICE _AC(0x0000000000000002, UL) /* P9: HV interru= pt enable */ +#define LPCR_HDICE _AC(0x0000000000000001, UL) /* Hyp Decr enabl= e (HV,PR,EE) */ +#define LPCR_UPRT _AC(0x0000000000400000, UL) /* Use Process Tab= le (ISA 3) */ +#define LPCR_HR _AC(0x0000000000100000, UL) + +#endif /* _ASM_REG_DEFS_H_ */ diff --git a/xen/arch/ppc/include/asm/types.h b/xen/arch/ppc/include/asm/= types.h index b62ae0e7ae..ffaf378a4d 100644 --- a/xen/arch/ppc/include/asm/types.h +++ b/xen/arch/ppc/include/asm/types.h @@ -4,6 +4,7 @@ #define _ASM_PPC_TYPES_H typedef unsigned long paddr_t; +typedef unsigned long vaddr_t; #define INVALID_PADDR (~0UL) #define PRIpaddr "016lx" diff --git a/xen/arch/ppc/mm-radix.c b/xen/arch/ppc/mm-radix.c new file mode 100644 index 0000000000..92cb9b6b2c --- /dev/null +++ b/xen/arch/ppc/mm-radix.c @@ -0,0 +1,265 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include + +void enable_mmu(void); + +#define INITIAL_LVL1_PD_COUNT 1 +#define INITIAL_LVL2_LVL3_PD_COUNT 2 +#define INITIAL_LVL4_PT_COUNT 256 + +static size_t initial_lvl1_pd_pool_used; +static struct lvl1_pd initial_lvl1_pd_pool[INITIAL_LVL1_PD_COUNT]; + +static size_t initial_lvl2_lvl3_pd_pool_used; +static struct lvl2_pd initial_lvl2_lvl3_pd_pool[INITIAL_LVL2_LVL3_PD_COU= NT]; + +static size_t initial_lvl4_pt_pool_used; +static struct lvl4_pt initial_lvl4_pt_pool[INITIAL_LVL4_PT_COUNT]; + +/* Only reserve minimum Partition and Process tables */ +#define PATB_SIZE_LOG2 16 /* Only supported partition table size on POWE= R9 */ +#define PATB_SIZE (1UL << PATB_SIZE_LOG2) +#define PRTB_SIZE_LOG2 12 +#define PRTB_SIZE (1UL << PRTB_SIZE_LOG2) + +static struct patb_entry + __aligned(PATB_SIZE) initial_patb[PATB_SIZE / sizeof(struct patb_ent= ry)]; + +static struct prtb_entry + __aligned(PRTB_SIZE) initial_prtb[PRTB_SIZE / sizeof(struct prtb_ent= ry)]; + +static __init struct lvl1_pd *lvl1_pd_pool_alloc(void) +{ + if ( initial_lvl1_pd_pool_used >=3D INITIAL_LVL1_PD_COUNT ) + { + early_printk("Ran out of space for LVL1 PD!\n"); + die(); + } + + return &initial_lvl1_pd_pool[initial_lvl1_pd_pool_used++]; +} + +static __init struct lvl2_pd *lvl2_pd_pool_alloc(void) +{ + if ( initial_lvl2_lvl3_pd_pool_used >=3D INITIAL_LVL2_LVL3_PD_COUNT = ) + { + early_printk("Ran out of space for LVL2/3 PD!\n"); + die(); + } + + return &initial_lvl2_lvl3_pd_pool[initial_lvl2_lvl3_pd_pool_used++]; +} + +static __init struct lvl3_pd *lvl3_pd_pool_alloc(void) +{ + BUILD_BUG_ON(sizeof(struct lvl3_pd) !=3D sizeof(struct lvl2_pd)); + + return (struct lvl3_pd *) lvl2_pd_pool_alloc(); +} + +static __init struct lvl4_pt *lvl4_pt_pool_alloc(void) +{ + if ( initial_lvl4_pt_pool_used >=3D INITIAL_LVL4_PT_COUNT ) + { + early_printk("Ran out of space for LVL4 PT!\n"); + die(); + } + + return &initial_lvl4_pt_pool[initial_lvl4_pt_pool_used++]; +} + +#ifndef NDEBUG +/* TODO: Remove once we get common/ building */ +static char *__init itoa64_hex(uint64_t val, char *out_buf, size_t buf_l= en) +{ + uint64_t cur; + size_t i =3D buf_len - 1; + + /* Null terminate buffer */ + out_buf[i] =3D '\0'; + + /* Add digits in reverse */ + cur =3D val; + while ( cur && i > 0 ) + { + out_buf[--i] =3D "0123456789ABCDEF"[cur % 16]; + cur /=3D 16; + } + + /* Pad to 16 digits */ + while ( i > 0 ) + out_buf[--i] =3D '0'; + + return out_buf + i; +} +#endif + +static void __init radix_dprint(uint64_t addr, const char *msg) +{ +#ifndef NDEBUG + char buf[sizeof("DEADBEEFCAFEBABA")]; + char *addr_s =3D itoa64_hex(addr, buf, sizeof(buf)); + + early_printk("(0x"); + early_printk(addr_s); + early_printk(") "); + early_printk(msg); +#endif +} + +static void __init setup_initial_mapping(struct lvl1_pd *lvl1, + vaddr_t map_start, + vaddr_t map_end, + paddr_t phys_base) +{ + uint64_t page_addr; + + if ( map_start & ~PAGE_MASK ) + { + early_printk("Xen _start be aligned to 64k (PAGE_SIZE) boundary\= n"); + die(); + } + + if ( phys_base & ~PAGE_MASK ) + { + early_printk("Xen should be loaded at 64k (PAGE_SIZE) boundary\n= "); + die(); + } + + for ( page_addr =3D map_start; page_addr < map_end; page_addr +=3D P= AGE_SIZE ) + { + struct lvl2_pd *lvl2; + struct lvl3_pd *lvl3; + struct lvl4_pt *lvl4; + pde_t *pde; + pte_t *pte; + + /* Allocate LVL 2 PD if necessary */ + pde =3D pt_entry(lvl1, page_addr); + if ( !pde_is_valid(*pde) ) + { + lvl2 =3D lvl2_pd_pool_alloc(); + *pde =3D paddr_to_pde(__pa(lvl2), PDE_VALID, + XEN_PT_ENTRIES_LOG2_LVL_2); + } + else + lvl2 =3D (struct lvl2_pd *)__va(pde_to_paddr(*pde)); + + /* Allocate LVL 3 PD if necessary */ + pde =3D pt_entry(lvl2, page_addr); + if ( !pde_is_valid(*pde) ) + { + lvl3 =3D lvl3_pd_pool_alloc(); + *pde =3D paddr_to_pde(__pa(lvl3), PDE_VALID, + XEN_PT_ENTRIES_LOG2_LVL_3); + } + else + lvl3 =3D (struct lvl3_pd *)__va(pde_to_paddr(*pde)); + + /* Allocate LVL 4 PT if necessary */ + pde =3D pt_entry(lvl3, page_addr); + if ( !pde_is_valid(*pde) ) + { + lvl4 =3D lvl4_pt_pool_alloc(); + *pde =3D paddr_to_pde(__pa(lvl4), PDE_VALID, + XEN_PT_ENTRIES_LOG2_LVL_4); + } + else + lvl4 =3D (struct lvl4_pt *)__va(pde_to_paddr(*pde)); + + /* Finally, create PTE in LVL 4 PT */ + pte =3D pt_entry(lvl4, page_addr); + if ( !pte_is_valid(*pte) ) + { + unsigned long paddr =3D (page_addr - map_start) + phys_base; + unsigned long flags; + + radix_dprint(paddr, "being mapped to "); + radix_dprint(page_addr, "!\n"); + if ( is_kernel_text(page_addr) || is_kernel_inittext(page_ad= dr) ) + { + radix_dprint(page_addr, "being marked as TEXT (RX)\n"); + flags =3D PTE_XEN_RX; + } + else if ( is_kernel_rodata(page_addr) ) + { + radix_dprint(page_addr, "being marked as RODATA (RO)\n")= ; + flags =3D PTE_XEN_RO; + } + else + { + radix_dprint(page_addr, "being marked as DEFAULT (RW)\n"= ); + flags =3D PTE_XEN_RW; + } + + *pte =3D paddr_to_pte(paddr, flags); + radix_dprint(paddr_to_pte(paddr, flags).pte, + "is result of PTE map!\n"); + } + else + { + early_printk("BUG: Tried to create PTE for already-mapped pa= ge!"); + die(); + } + } +} + +static void __init setup_partition_table(struct lvl1_pd *root) +{ + unsigned long ptcr; + + /* Configure entry for LPID 0 to enable Radix and point to root PD *= / + uint64_t patb0 =3D RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_= 1 | + PATB0_HR; + uint64_t patb1 =3D __pa(initial_prtb) | (PRTB_SIZE_LOG2 - 12) | PATB= 1_GR; + initial_patb[0].patb0 =3D cpu_to_be64(patb0); + initial_patb[0].patb1 =3D cpu_to_be64(patb1); + + ptcr =3D __pa(initial_patb) | (PATB_SIZE_LOG2 - 12); + mtspr(SPRN_PTCR, ptcr); +} + +static void __init setup_process_table(struct lvl1_pd *root) +{ + /* Configure entry for PID 0 to point to root PD */ + uint64_t prtb0 =3D RTS_FIELD | __pa(root) | XEN_PT_ENTRIES_LOG2_LVL_= 1; + initial_prtb[0].prtb0 =3D cpu_to_be64(prtb0); +} + +void __init setup_initial_pagetables(void) +{ + struct lvl1_pd *root =3D lvl1_pd_pool_alloc(); + unsigned long lpcr; + + setup_initial_mapping(root, (vaddr_t)_start, (vaddr_t)_end, __pa(_st= art)); + + /* Enable Radix mode in LPCR */ + lpcr =3D mfspr(SPRN_LPCR); + mtspr(SPRN_LPCR, lpcr | LPCR_UPRT | LPCR_HR); + early_printk("Enabled radix in LPCR\n"); + + /* Set up initial process table */ + setup_process_table(root); + + /* Set up initial partition table */ + setup_partition_table(root); + + /* Flush TLB */ + tlbie_all(); + early_printk("Flushed TLB\n"); + + /* Turn on the MMU */ + enable_mmu(); +} diff --git a/xen/arch/ppc/ppc64/head.S b/xen/arch/ppc/ppc64/head.S index 149af2c472..dedff7650c 100644 --- a/xen/arch/ppc/ppc64/head.S +++ b/xen/arch/ppc/ppc64/head.S @@ -2,6 +2,7 @@ #include #include +#include .section .text.header, "ax", %progbits @@ -66,3 +67,17 @@ ENTRY(start) .size start, . - start .type start, %function + +ENTRY(enable_mmu) + mflr %r3 + mfmsr %r4 + + /* enable instruction and data relocation (MMU) */ + ori %r4, %r4, (MSR_IR | MSR_DR) + + mtsrr0 %r3 /* return to caller after MMU enable */ + mtsrr1 %r4 + rfid + + .size enable_mmu, . - enable_mmu + .type enable_mmu, %function diff --git a/xen/arch/ppc/setup.c b/xen/arch/ppc/setup.c index 8ab7bc19ee..0106e9c9da 100644 --- a/xen/arch/ppc/setup.c +++ b/xen/arch/ppc/setup.c @@ -2,6 +2,7 @@ #include #include #include +#include #include /* Xen stack for bringing up the first CPU. */ @@ -27,6 +28,8 @@ void __init noreturn start_xen(unsigned long r3, unsign= ed long r4, boot_opal_init((void *)r3); } + setup_initial_pagetables(); + early_printk("Hello, ppc64le!\n"); for ( ; ; ) diff --git a/xen/arch/ppc/tlb-radix.c b/xen/arch/ppc/tlb-radix.c new file mode 100644 index 0000000000..3dde102c62 --- /dev/null +++ b/xen/arch/ppc/tlb-radix.c @@ -0,0 +1,96 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Based on arch/powerpc/mm/book3s64/radix_tlb.c from Linux with the fol= lowing + * copyright notice: + * + * Copyright 2015-2016, Aneesh Kumar K.V, IBM Corporation. + */ +#include + +#include +#include +#include + +/* TLB flush actions. Used as argument to tlbiel_flush() */ +enum +{ + TLB_INVAL_SCOPE_LPID, /* invalidate TLBs for current LPID */ + TLB_INVAL_SCOPE_GLOBAL, /* invalidate all TLBs */ +}; + +#define POWER9_TLB_SETS_RADIX 128 /* # sets in POWER9 TLB Radix mode */ + +#define RIC_FLUSH_TLB 0 +#define RIC_FLUSH_PWC 1 +#define RIC_FLUSH_ALL 2 + +static void tlbiel_radix_set_isa300(unsigned int set, unsigned int is, + unsigned int pid, unsigned int ric, + unsigned int prs) +{ + unsigned long rb; + unsigned long rs; + + rb =3D (set << PPC_BITLSHIFT(51)) | (is << PPC_BITLSHIFT(53)); + rs =3D ((unsigned long) pid << PPC_BITLSHIFT(31)); + + asm volatile ( "tlbiel %0, %1, %2, %3, 1" + :: "r" (rb), "r" (rs), "i" (ric), "i" (prs) + : "memory" ); +} + +static void tlbiel_all_isa300(unsigned int num_sets, unsigned int is) +{ + unsigned int set; + + asm volatile ( "ptesync" : : : "memory" ); + + /* + * Flush the first set of the TLB, and the entire Page Walk Cache + * and partition table entries. Then flush the remaining sets of the + * TLB. + */ + + if ( mfmsr() & MSR_HV ) + { + /* MSR[HV] should flush partition scope translations first. */ + tlbiel_radix_set_isa300(0, is, 0, RIC_FLUSH_ALL, 0); + + for ( set =3D 1; set < num_sets; set++ ) + tlbiel_radix_set_isa300(set, is, 0, RIC_FLUSH_TLB, 0); + } + + /* Flush process scoped entries. */ + tlbiel_radix_set_isa300(0, is, 0, RIC_FLUSH_ALL, 1); + + for ( set =3D 1; set < num_sets; set++ ) + tlbiel_radix_set_isa300(set, is, 0, RIC_FLUSH_TLB, 1); + + asm volatile ( "ptesync" : : : "memory" ); +} + +void radix__tlbiel_all(unsigned int action) +{ + unsigned int is; + + switch ( action ) + { + case TLB_INVAL_SCOPE_GLOBAL: + is =3D 3; + break; + case TLB_INVAL_SCOPE_LPID: + is =3D 2; + break; + default: + die(); + } + + tlbiel_all_isa300(POWER9_TLB_SETS_RADIX, is); + + asm volatile ( "slbia 7; isync" : : : "memory" ); +} + +void tlbie_all(void) +{ + radix__tlbiel_all(TLB_INVAL_SCOPE_GLOBAL); +} -- 2.30.2 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:52:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:52:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581472.910190 (Exim 4.92) (envelope-from ) id 1qTs2G-0007Qj-Un; Wed, 09 Aug 2023 22:52:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581472.910190; Wed, 09 Aug 2023 22:52:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs2G-0007Qc-SB; Wed, 09 Aug 2023 22:52:12 +0000 Received: by outflank-mailman (input) for mailman id 581472; Wed, 09 Aug 2023 22:52:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs2F-0007QW-Hr for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:52:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs2B-0006ka-2Z; Wed, 09 Aug 2023 22:52:07 +0000 Received: from [54.239.6.185] (helo=[192.168.6.56]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qTs2A-0002PZ-Nx; Wed, 09 Aug 2023 22:52:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=UYdnCNt4r1S81dTd3G5Gil6no3BdumaDACAQ4ib+IAw=; b=ZR3Ue5nD81JMcA7Khtarwa4L23 qNUnbFEQTKfxnZNMfhNd8Rgf4ZVbf9N2ZawvXGi0kKWXAdXKwL1besMmFiIhDnoyBcI5Bams9mfnv 3MQvzI64G1zwaGigR0FaRS4NwBhkCDzAi/dJF0IN3roXjkte7Q+eWv+ikY1tS/DIj84s=; Message-ID: <9456c12e-2960-4d93-86d3-f7fa578199cf@xen.org> Date: Wed, 9 Aug 2023 23:52:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: MISRA violations in hypercall-defs Content-Language: en-GB To: Stefano Stabellini Cc: Jan Beulich , Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Xen-devel , Bertrand.Marquis@arm.com References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> <0d7cabca-e0d5-4ab6-a16d-11da35e45149@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09/08/2023 23:06, Stefano Stabellini wrote: > On Wed, 9 Aug 2023, Julien Grall wrote: >> Hi, >> >> On 09/08/2023 21:35, Stefano Stabellini wrote: >>> P.S. >>> Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today >>> it is not clarified) 32-bit guests on a 64-bit ARM hypervisor? >> >> I read your explanation above and I don't really understand why you would want >> to de-support it. This works pretty well and I am not aware of any issue right >> now to run 32-bit guest on 64-bit HW. > > I am happy either way. The reason why I brought it up is that we don't > have a specific test for this in gitlab-ci But a gitlab CI test can be added, right? I mean it would seem to be odd to use this as a justification because a lot of features (e.g. passthrough, suspend/resume...) would end up to be de-support it as gitlab CI is still in early stage. > and Jan raised concerns that > greater-than 32-bit values as possible as ret from hypercalls on a > 64-bit build of Xen. This is a known problem and it was discussed several times on the ML in the past years. There is a theorical problem because in theory all the hypercalls could return a value that can't fit in 32-bit. However, AFAIK, only the memory hypercall XENMEM_maximum_gpfn may return a 64-bit value on 64-bit Xen. It is not a problem for a 32-bit domain issues the hypercall on itself because the guest physical maximum address should never be greater than 40-bit (so 28-bit page frame number) and therefore could fit in 32-bit. The only problem is if you want to use a 32-bit toolstack on 64-bit. But Jan sent a patch for SUPPORT.md to clarify this is not meant to always work (see [1]). Please let me know if you are aware of any other truncations. Cheers, [1] 6d6144f6-489e-d9b0-b590-f5d65c385116@suse.com -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:54:13 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:54:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581477.910200 (Exim 4.92) (envelope-from ) id 1qTs4C-0007zT-9R; Wed, 09 Aug 2023 22:54:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581477.910200; Wed, 09 Aug 2023 22:54:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs4C-0007zM-6m; Wed, 09 Aug 2023 22:54:12 +0000 Received: by outflank-mailman (input) for mailman id 581477; Wed, 09 Aug 2023 22:54:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs4A-0007zC-6G for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:54:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a5304ee7-3707-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:54:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B29AF64BB1; Wed, 9 Aug 2023 22:54:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBE78C433C8; Wed, 9 Aug 2023 22:54:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5304ee7-3707-11ee-b282-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691621646; bh=I9zQGnkPlhmcGiS0698COlr9BJ6IJc8ygi0fkqyS16I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=n3X3R5/d2NUcCQGOsJEfyVbxGAFoWgAEciFk1tOkK91JJn1YQ4M5ZmR8zFtpPV8fS ew+hk2AWJhyVWiT3sfbJy4xu6S/pd3+2kKGg3oN0Nz/+E28rSeGc+CUHhE06Xgq2Uz 9oPY38gk2z0WtdaY53fxegyCE0X+LViU0CdIKkqg/4Ru3LBfUCFbx1zjMHp0CB1XIv Cuji+TBz/MXARf35PbhX7onjVvkWAAK6o7v/3au8M974Hgj1K2klKzThVFFCFLDu4/ yvWR3BdR6N0YwvPUJGTrDi3vWevZsCrxcx7ZHql4cuNODzmHDUKwV2WfnaIkmU4ZFl 9Su7vKZPT/rqQ== Date: Wed, 9 Aug 2023 15:54:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: Stefano Stabellini , Henry Wang , "xen-devel@lists.xenproject.org" , "community.manager@xenproject.org" , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Julien Grall , Bertrand Marquis , simone.ballarin@bugseng.com Subject: Re: Xen 4.18 release: Reminder about last posting date In-Reply-To: Message-ID: References: <1ac14ed0-d489-0efe-0b0c-200792a50fde@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1874569854-1691621349=:2127516" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1874569854-1691621349=:2127516 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 9 Aug 2023, Andrew Cooper wrote: > On 09/08/2023 11:34 pm, Stefano Stabellini wrote: > > On Wed, 9 Aug 2023, Andrew Cooper wrote: > >> On 09/08/2023 10:43 pm, Stefano Stabellini wrote: > >>> On Wed, 9 Aug 2023, Andrew Cooper wrote: > >>>> On 07/08/2023 2:24 am, Henry Wang wrote: > >>>>> Hi everyone, > >>>>> > >>>>> Following the release schedule discussion in in April, I am sending this email > >>>>> to remind that according to the release schedule [1], August 11 (this Friday) > >>>>> will be the last posting date, when patches adding new features are expected > >>>>> to be posted to the mailing list by this date. > >>>>> > >>>>> Also, note that we currently have 1 release blocker [2] which might need > >>>>> some attention. > >>>>> > >>>>> [1] https://lore.kernel.org/xen-devel/AS8PR08MB79919F9CE0B2BF80E7103FB592609@AS8PR08MB7991.eurprd08.prod.outlook.com/ > >>>>> [2] https://gitlab.com/xen-project/xen/-/issues/114 > >>>> Off the top of my head. > >>>> > >>>> There are still unaddressed Gitlab bugs from the Eclair integration > >>> The bug you managed to find it is now fixed (commit e55146071de9). I am > >>> all for fixing Gitlab bugs so let me know if you find anything else! I > >>> am not aware of any other issue with Eclair at the moment. > >> I meant the one where Eclair is still running on `smoke` and twiddling > >> its thumbs for 1h doing so each time OSSTest says yes to a push.  It > >> will be a missing 'exclude' somewhere, but I haven't hand enough time to > >> look. > > Ah, yes, got it. I would call it "Eclair lagging behind". I am happy for > > this to be a blocker. > > Something else for the list is to see about trimming down the testing > we're doing. > > I had to cancel 7 pipelines (mostly patchew) in order to get a gitlab > run on a late-breaking tweak on the security content yesterday. > > Take > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/959800176 > as an example.  Nearly 2h to run, and queued for 2h before that waiting > to start.  This is not a rare occurrence right now. Yeah... So, an easy fix that would solve the problem for the rest of the tests but not Eclair would be to reduce the number of tests. It is easy because we can make them conditional on a CI/CD variable and *not* define the variable in patchew. That way patchew gets a reduced set of tests. I think that would be fine. Another option we can also pursue in parallel is to throw more hardware at the problem. I am not sure where we are on reusing Colo hardware for this. Eclair is a different issue because we cannot increase the hardware and I don't think we want to reduce the set of rules to be scanned. So the only idea I can come up with is to limit the number of Eclair jobs in patchew to 1-2 per day. However it would be pretty random which ones are getting executed. Or find a wat to prioritize non-patchew jobs? If you or anyone else has better idea feel free to suggest. > >>>> and other Gitlab bugs (use of unstable containers) which I'd unwilling > >>>> to let 4.18 be released with, given the pain we've had on the stable > >>>> trees trying to keep CI working. > >>> That is fair enough. To make this more concrete and easier to track, the > >>> following would need to be changed to using stable containers: > >>> > >>> - .qemu-arm64 > >>> - .qemu-arm32 > >>> (I am not counting .qemu-riscv64) > >>> > >>> Andrew, is that what you meant? Am I missing anything? > >> Every debian unstable container, and the other containers (OpenSUSE) > >> which are using an non-specific upstream version.  Upstreams which > >> really are rolling distros (Arch, Tumbleweed) need to be made non-fatal. > > I was more asking whether for 4.18 you want to fix only test.yaml or > > also build.yaml. (Typically it is test.yaml that causes most issues > > with rolling containers.) > > Everything.  Because both bite equally hard in stable trees. > > It's not hard to do - just needs some time. OK --8323329-1874569854-1691621349=:2127516-- From xen-devel-bounces@lists.xenproject.org Wed Aug 09 22:55:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 22:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581483.910211 (Exim 4.92) (envelope-from ) id 1qTs5W-00008L-Kp; Wed, 09 Aug 2023 22:55:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581483.910211; Wed, 09 Aug 2023 22:55:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs5W-00008D-GZ; Wed, 09 Aug 2023 22:55:34 +0000 Received: by outflank-mailman (input) for mailman id 581483; Wed, 09 Aug 2023 22:55:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTs5U-000087-IO for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 22:55:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d6f93431-3707-11ee-b282-6b7b168915f2; Thu, 10 Aug 2023 00:55:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23C5B6485B; Wed, 9 Aug 2023 22:55:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E910C433C8; Wed, 9 Aug 2023 22:55:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6f93431-3707-11ee-b282-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691621729; bh=1lhl3ap1zWM0chou3+Rggl1wTn/zkGmZwk1xENiVgfQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=c7GfCrnS4czVxVxZqZ7zJX4dZpQS4KyLofREV4HjnEyK5ke0LcvFCoRCOgJEv9el6 IahTWZVituEMACQ8e3aFaankkhyJ8c02K/mSZnxFXz9hXtz4vKd2Fwn+fb/WBbrssT PXVlWtlNZlAxz7yEWj9MLZ7MgHmxDpkX160UvcAMN0YQ4gi60E2nAjtnTa3pkhdyll bw+m6UGoIlXSh9ZeWNAjYuCvV8zySL8UM3bwaAEHgEylOm4ahAXYonYcZmrfrep6W0 W2IzEtj5meSnb3W8mGG8EQYvjVQSSl5EHfmGJ4c7hFFzuCoROhrIJeb+ygjPXnCT23 qCWJ0AoBVCraQ== Date: Wed, 9 Aug 2023 15:55:27 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Stefano Stabellini , Jan Beulich , Federico Serafini , jgross@suse.com, Andrew Cooper , "consulting@bugseng.com" , Xen-devel , Bertrand.Marquis@arm.com Subject: Re: MISRA violations in hypercall-defs In-Reply-To: <9456c12e-2960-4d93-86d3-f7fa578199cf@xen.org> Message-ID: References: <5972799c-99a6-73f5-eff2-b24469f7428d@bugseng.com> <01fbd921-8092-aedd-33ec-ef170d8ec6fc@suse.com> <456d6bb5-8fa2-d47a-5d1a-b3bda20e0a5b@suse.com> <0d7cabca-e0d5-4ab6-a16d-11da35e45149@xen.org> <9456c12e-2960-4d93-86d3-f7fa578199cf@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 9 Aug 2023, Julien Grall wrote: > On 09/08/2023 23:06, Stefano Stabellini wrote: > > On Wed, 9 Aug 2023, Julien Grall wrote: > > > Hi, > > > > > > On 09/08/2023 21:35, Stefano Stabellini wrote: > > > > P.S. > > > > Julien, Bertrand, do you think we should unsupport (in SUPPORT.md, today > > > > it is not clarified) 32-bit guests on a 64-bit ARM hypervisor? > > > > > > I read your explanation above and I don't really understand why you would > > > want > > > to de-support it. This works pretty well and I am not aware of any issue > > > right > > > now to run 32-bit guest on 64-bit HW. > > > > I am happy either way. The reason why I brought it up is that we don't > > have a specific test for this in gitlab-ci > > But a gitlab CI test can be added, right? I mean it would seem to be odd to > use this as a justification because a lot of features (e.g. passthrough, > suspend/resume...) would end up to be de-support it as gitlab CI is still in > early stage. Yes that's fair > > and Jan raised concerns that > > greater-than 32-bit values as possible as ret from hypercalls on a > > 64-bit build of Xen. > > This is a known problem and it was discussed several times on the ML in the > past years. > > There is a theorical problem because in theory all the hypercalls could return > a value that can't fit in 32-bit. > > However, AFAIK, only the memory hypercall XENMEM_maximum_gpfn may return a > 64-bit value on 64-bit Xen. > > It is not a problem for a 32-bit domain issues the hypercall on itself because > the guest physical maximum address should never be greater than 40-bit (so > 28-bit page frame number) and therefore could fit in 32-bit. > > The only problem is if you want to use a 32-bit toolstack on 64-bit. But Jan > sent a patch for SUPPORT.md to clarify this is not meant to always work (see > [1]). > > Please let me know if you are aware of any other truncations. No, that's fine. This is exactly what I wanted to know :-) From xen-devel-bounces@lists.xenproject.org Wed Aug 09 23:43:39 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 23:43:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581490.910220 (Exim 4.92) (envelope-from ) id 1qTspo-0005rC-4o; Wed, 09 Aug 2023 23:43:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581490.910220; Wed, 09 Aug 2023 23:43:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTspo-0005r5-1S; Wed, 09 Aug 2023 23:43:24 +0000 Received: by outflank-mailman (input) for mailman id 581490; Wed, 09 Aug 2023 23:43:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTspn-0005qv-23; Wed, 09 Aug 2023 23:43:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTspm-0007r5-Q3; Wed, 09 Aug 2023 23:43:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTspm-0004Bv-C0; Wed, 09 Aug 2023 23:43:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTspm-0005ra-BZ; Wed, 09 Aug 2023 23:43:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fVhrBGQaZG66npcTZtdp9uf3kdOFxJzeLOwWf2vmJvg=; b=ODrqnXTxD8C/+DVdSNj5Mh5JRS SsL8HMqHW8tCvmu5YXO3cOhqHnFVhEL8wPBa7R2XgBHeb8ZVzqyGGkgkVzubW2arRCPPJg9iesggO Egpo5vnxlC2gw1ZeMf7yOaILg1sSikuDZ7FgUCxIWC9WxjR9RlCmknvgJYTQLsKrQuxE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.17-testing test] 182237: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.17-testing:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:heisenbug xen-4.17-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.17-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.17-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.17-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.17-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=322a20add00a4687cd46d9183616fa6fecbef81f X-Osstest-Versions-That: xen=0a62b16489958715c20a2f6177a11a8ca3c4f7f3 From: osstest service owner Date: Wed, 09 Aug 2023 23:43:22 +0000 flight 182237 xen-4.17-testing real [real] flight 182252 xen-4.17-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182237/ http://logs.test-lab.xenproject.org/osstest/logs/182252/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail pass in 182252-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 182167 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182167 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182167 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182167 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182167 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182167 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182167 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182167 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182167 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182167 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182167 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182167 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 322a20add00a4687cd46d9183616fa6fecbef81f baseline version: xen 0a62b16489958715c20a2f6177a11a8ca3c4f7f3 Last test of basis 182167 2023-08-03 14:38:20 Z 6 days Testing same since 182237 2023-08-08 17:08:09 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Jan Beulich Olaf Hering Roger Pau Monne Roger Pau MonnĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0a62b16489..322a20add0 322a20add00a4687cd46d9183616fa6fecbef81f -> stable-4.17 From xen-devel-bounces@lists.xenproject.org Wed Aug 09 23:51:38 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 09 Aug 2023 23:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581547.910411 (Exim 4.92) (envelope-from ) id 1qTsxj-000123-JB; Wed, 09 Aug 2023 23:51:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581547.910411; Wed, 09 Aug 2023 23:51:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTsxj-00011w-Ej; Wed, 09 Aug 2023 23:51:35 +0000 Received: by outflank-mailman (input) for mailman id 581547; Wed, 09 Aug 2023 23:51:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTsxi-00011h-Hu; Wed, 09 Aug 2023 23:51:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTsxi-0008EB-Fk; Wed, 09 Aug 2023 23:51:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTsxh-0004Q1-V8; Wed, 09 Aug 2023 23:51:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTsxh-000791-Uf; Wed, 09 Aug 2023 23:51:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0Lx+ahVFpJXPuETZWBLvj//u9cKeNMeEMI6KMZ7abac=; b=eSSiuNMwZkpyoPhYfjhwe3jLUk axu2FAX9CeanLU6zd9X/LY5dcSTiJJmxQmw5zKHPurlf0VMFjhIKvTG8PpZGZCFC7dqQJTe8lhirD uGmXLWU7wugTu+peOBAnUD9QDZQnHp/lsxvWBKRhb+VOgeYsjwZfugjdvC8zeWNyuzbE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 182234: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-amd64-xl-pvshim:guest-localmigrate/x10:fail:heisenbug xen-4.14-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:windows-install:fail:heisenbug xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=297fce96e1329107f48c08f539bc3000652610cd X-Osstest-Versions-That: xen=602ee4c2954ed3f9f8552e08043146bee60ec012 From: osstest service owner Date: Wed, 09 Aug 2023 23:51:33 +0000 flight 182234 xen-4.14-testing real [real] flight 182251 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182234/ http://logs.test-lab.xenproject.org/osstest/logs/182251/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-pvshim 20 guest-localmigrate/x10 fail pass in 182251-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 182251-retest test-amd64-amd64-xl-qemut-ws16-amd64 12 windows-install fail pass in 182251-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail in 182251 like 182092 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182092 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182092 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182092 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182092 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182092 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182092 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182092 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182092 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182092 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182092 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182092 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 297fce96e1329107f48c08f539bc3000652610cd baseline version: xen 602ee4c2954ed3f9f8552e08043146bee60ec012 Last test of basis 182092 2023-07-31 13:06:48 Z 9 days Testing same since 182234 2023-08-08 17:08:09 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Jan Beulich Jason Andryuk Roger Pau Monne Roger Pau MonnĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim fail test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 602ee4c295..297fce96e1 297fce96e1329107f48c08f539bc3000652610cd -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 00:20:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 00:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581633.910693 (Exim 4.92) (envelope-from ) id 1qTtPc-0008LU-S3; Thu, 10 Aug 2023 00:20:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581633.910693; Thu, 10 Aug 2023 00:20:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtPc-0008LN-NP; Thu, 10 Aug 2023 00:20:24 +0000 Received: by outflank-mailman (input) for mailman id 581633; Thu, 10 Aug 2023 00:20:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtPb-0008LD-2O; Thu, 10 Aug 2023 00:20:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtPa-0001CC-M2; Thu, 10 Aug 2023 00:20:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtPa-00059W-5i; Thu, 10 Aug 2023 00:20:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTtPa-0007Sd-5B; Thu, 10 Aug 2023 00:20:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6vmN2cEto/K+A48cX1E3yEyBA+lmEInY99LbzCg2K5w=; b=nvax3LocVR6c9Jzc5xHPZLX+XS 2WDG0kJjtx7jwxqm8hurrX03Si5d1G0T2s0hD3fnRhPEfdkmZFZjG44YFoLADFMQdpP/mpd9bWmOJ OAQaKzv57bFGIzIAdkMmQb4omFDFCRP3Vh+5cuMPRoGtUG2kmcmi49FyLd1ggOyvS5wA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 182236: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-credit1:guest-localmigrate/x10:fail:heisenbug xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b9ad687bfd0a49f36e0dd9f038e73782595fb4af X-Osstest-Versions-That: xen=ff736d9f2abf9131414d72d0124b3c7739491249 From: osstest service owner Date: Thu, 10 Aug 2023 00:20:22 +0000 flight 182236 xen-4.16-testing real [real] flight 182253 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182236/ http://logs.test-lab.xenproject.org/osstest/logs/182253/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit1 20 guest-localmigrate/x10 fail pass in 182253-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182166 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182166 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182166 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182166 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182166 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182166 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182166 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182166 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182166 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182166 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182166 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182166 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen b9ad687bfd0a49f36e0dd9f038e73782595fb4af baseline version: xen ff736d9f2abf9131414d72d0124b3c7739491249 Last test of basis 182166 2023-08-03 14:38:20 Z 6 days Testing same since 182236 2023-08-08 17:08:09 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Jan Beulich Olaf Hering Roger Pau Monne Roger Pau MonnĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ff736d9f2a..b9ad687bfd b9ad687bfd0a49f36e0dd9f038e73782595fb4af -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 00:49:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 00:49:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581734.911043 (Exim 4.92) (envelope-from ) id 1qTtr8-0006XH-Lz; Thu, 10 Aug 2023 00:48:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581734.911043; Thu, 10 Aug 2023 00:48:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtr8-0006X9-I0; Thu, 10 Aug 2023 00:48:50 +0000 Received: by outflank-mailman (input) for mailman id 581734; Thu, 10 Aug 2023 00:48:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtr7-0006Wr-Qg; Thu, 10 Aug 2023 00:48:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtr7-0001tr-PA; Thu, 10 Aug 2023 00:48:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTtr7-0005v6-Bb; Thu, 10 Aug 2023 00:48:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTtr7-0007xT-B0; Thu, 10 Aug 2023 00:48:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=haTWrYcmWoWvDR+Fz9ffwnWIgfavK4oHpJ0VzW7J12U=; b=bVhyLI2QakuC7fwMw0gEGW2aVV r1QrJ8kYIxm8f21EMyggOjiSURdfX8zu9sUhjpLb4IPiN9+HPqQ4/jkGY6XPYE4HzeaI+DIDMKxZk tZcPL2VV7BFchQlRzpBCRA215flLgl5vr+v7IkT5stVNziVHcLolInDMCUVoDDRrG64s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 182235: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=da7f151a63108db5543ca53c1e902c34ae6ee825 X-Osstest-Versions-That: xen=87eaa43b30f8ffb600f8e6f765d5c7e4bcb241b9 From: osstest service owner Date: Thu, 10 Aug 2023 00:48:49 +0000 flight 182235 xen-4.15-testing real [real] flight 182254 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182235/ http://logs.test-lab.xenproject.org/osstest/logs/182254/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 182254-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182106 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182106 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182106 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182106 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182106 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182106 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182106 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182106 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182106 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182106 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182106 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182106 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass version targeted for testing: xen da7f151a63108db5543ca53c1e902c34ae6ee825 baseline version: xen 87eaa43b30f8ffb600f8e6f765d5c7e4bcb241b9 Last test of basis 182106 2023-08-02 00:59:52 Z 7 days Testing same since 182235 2023-08-08 17:08:09 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Christian Lindig Jan Beulich Jason Andryuk Roger Pau Monne Roger Pau MonnĂ© jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 87eaa43b30..da7f151a63 da7f151a63108db5543ca53c1e902c34ae6ee825 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 01:18:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 01:18:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581773.911169 (Exim 4.92) (envelope-from ) id 1qTuJI-0005Qy-86; Thu, 10 Aug 2023 01:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581773.911169; Thu, 10 Aug 2023 01:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTuJI-0005Qr-4o; Thu, 10 Aug 2023 01:17:56 +0000 Received: by outflank-mailman (input) for mailman id 581773; Thu, 10 Aug 2023 01:17:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTuJH-0005Qg-66 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 01:17:55 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ba1bef79-371b-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 03:17:53 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6DBBE63AFF; Thu, 10 Aug 2023 01:17:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4852FC433C7; Thu, 10 Aug 2023 01:17:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba1bef79-371b-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691630270; bh=D0FGSftZn0DqRZGQRsIFnVzrT8ifJsbvF8WcTidNFKc=; h=Date:From:To:cc:Subject:From; b=vGt1lAl3DMlGPfxPuux/bJPf/+F/u1jSSzj7faBkETvxvwfAKVUJltV0/m0xiLtKu 9tzNFEW3V2XaxzWEzZ+HT4SIxPMlkHePn+OZQvVU2lTdzO3gPapJjPWSPs0Reo7TIB SZEp3nWyp0yNIjqpam+UfRxEIA9cVUPoj0Ax8UY3G8MQB2U03uD8K6OWLt5Pp+lYwW 2QJPF3KgMg7Ahm3v4kuhMBX7CzhPy837g0jriHcmINyR+x8RrzvwTdkGXM3prjX660 vm8GIFRBbIImASzhTx6eDayvOxX0I/rBQXh3eVTyTwLdV9IzSWhO/+RkM0tMI53E+o GOE5Datt18HsQ== Date: Wed, 9 Aug 2023 18:17:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: michal.orzel@amd.com cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, cardoe@cardoe.com Subject: [PATCH 0/2] automation: upgrade Alpine to 3.18 Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi all, This short series introduces a painless upgrade to Alpine 3.18, given that 3.12 is EOL. Proof that it works: https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/961413389 Cheers, Stefano From xen-devel-bounces@lists.xenproject.org Thu Aug 10 01:18:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 01:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581774.911179 (Exim 4.92) (envelope-from ) id 1qTuJW-0005jT-G7; Thu, 10 Aug 2023 01:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581774.911179; Thu, 10 Aug 2023 01:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTuJW-0005jL-Cy; Thu, 10 Aug 2023 01:18:10 +0000 Received: by outflank-mailman (input) for mailman id 581774; Thu, 10 Aug 2023 01:18:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTuJV-0005Qg-5s for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 01:18:09 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c3239f55-371b-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 03:18:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ECB9564D18; Thu, 10 Aug 2023 01:18:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9621AC433C8; Thu, 10 Aug 2023 01:18:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3239f55-371b-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691630286; bh=o38hDMnErido2ocHdI4zOyxzy0EWOn0IUkAUdx/QJ5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NjFuEjfmX4xYuUz86XSf3p6NV88k94l5oPSF9igwU30zhAN4C9jdSkq9Mfujm+TWr +pYCLHQSCXjOmKR2YExfdXpQ2c9C2ubEqQDr1KBb5qDqnmkfsZzHwJYlzXuPGhN0FN kt4gHvm6d35+0qfWBT2Qo/ePS+eDus44lZmqVw3+tj7Q7JbjgPGoy8ZSAEExj3kjel cifE6ui9zLiDtdWVmiVnVf9EvVb1cvQ0NY1AepZGwrT0ySMhQyFIsNB65TRJiANtkL WYCjm4WMjernOfp4Hca54Exgwty/GvaO1giAddbx7XbnNMeKPQ7GGvGnBEkdl9/Gta vAChxAxJhDoKA== From: Stefano Stabellini To: michal.orzel@amd.com Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, cardoe@cardoe.com, Stefano Stabellini Subject: [PATCH 1/2] automation: upgrade Alpine build and test artifact containers to 3.18 Date: Wed, 9 Aug 2023 18:18:02 -0700 Message-Id: <20230810011803.311832-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Alpine 3.12 is EOL. Also update the containerize script. Signed-off-by: Stefano Stabellini --- .../{3.12-arm64v8.dockerfile => 3.18-arm64v8.dockerfile} | 2 +- automation/build/alpine/{3.12.dockerfile => 3.18.dockerfile} | 2 +- automation/scripts/containerize | 4 ++-- .../{3.12-arm64v8.dockerfile => 3.18-arm64v8.dockerfile} | 4 ++-- .../alpine/{3.12.dockerfile => 3.18.dockerfile} | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) rename automation/build/alpine/{3.12-arm64v8.dockerfile => 3.18-arm64v8.dockerfile} (96%) rename automation/build/alpine/{3.12.dockerfile => 3.18.dockerfile} (97%) rename automation/tests-artifacts/alpine/{3.12-arm64v8.dockerfile => 3.18-arm64v8.dockerfile} (97%) rename automation/tests-artifacts/alpine/{3.12.dockerfile => 3.18.dockerfile} (97%) diff --git a/automation/build/alpine/3.12-arm64v8.dockerfile b/automation/build/alpine/3.18-arm64v8.dockerfile similarity index 96% rename from automation/build/alpine/3.12-arm64v8.dockerfile rename to automation/build/alpine/3.18-arm64v8.dockerfile index 1be3bf7805..ce198f7d04 100644 --- a/automation/build/alpine/3.12-arm64v8.dockerfile +++ b/automation/build/alpine/3.18-arm64v8.dockerfile @@ -1,4 +1,4 @@ -FROM arm64v8/alpine:3.12 +FROM arm64v8/alpine:3.18 LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.18.dockerfile similarity index 97% rename from automation/build/alpine/3.12.dockerfile rename to automation/build/alpine/3.18.dockerfile index 72ad3a07ad..ca5756955e 100644 --- a/automation/build/alpine/3.12.dockerfile +++ b/automation/build/alpine/3.18.dockerfile @@ -1,4 +1,4 @@ -FROM alpine:3.12 +FROM alpine:3.18 LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 6d46f63665..16d480ab75 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -24,8 +24,8 @@ die() { # BASE="registry.gitlab.com/xen-project/xen" case "_${CONTAINER}" in - _alpine) CONTAINER="${BASE}/alpine:3.12" ;; - _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.12-arm64v8" ;; + _alpine) CONTAINER="${BASE}/alpine:3.18" ;; + _alpine-arm64v8) CONTAINER="${BASE}/alpine:3.18-arm64v8" ;; _archlinux|_arch) CONTAINER="${BASE}/archlinux:current" ;; _riscv64) CONTAINER="${BASE}/archlinux:current-riscv64" ;; _centos7) CONTAINER="${BASE}/centos:7" ;; diff --git a/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile b/automation/tests-artifacts/alpine/3.18-arm64v8.dockerfile similarity index 97% rename from automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile rename to automation/tests-artifacts/alpine/3.18-arm64v8.dockerfile index cb8e9e59bb..cbd96d9bc6 100644 --- a/automation/tests-artifacts/alpine/3.12-arm64v8.dockerfile +++ b/automation/tests-artifacts/alpine/3.18-arm64v8.dockerfile @@ -1,4 +1,4 @@ -FROM arm64v8/alpine:3.12 +FROM arm64v8/alpine:3.18 LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" @@ -18,7 +18,7 @@ RUN \ apk add sudo && \ apk add dbus && \ apk add bash && \ - apk add python2 && \ + apk add python3 && \ apk add zlib && \ apk add ncurses && \ apk add texinfo && \ diff --git a/automation/tests-artifacts/alpine/3.12.dockerfile b/automation/tests-artifacts/alpine/3.18.dockerfile similarity index 97% rename from automation/tests-artifacts/alpine/3.12.dockerfile rename to automation/tests-artifacts/alpine/3.18.dockerfile index 073f16a0d7..32aa8e1778 100644 --- a/automation/tests-artifacts/alpine/3.12.dockerfile +++ b/automation/tests-artifacts/alpine/3.18.dockerfile @@ -1,4 +1,4 @@ -FROM alpine:3.12 +FROM alpine:3.18 LABEL maintainer.name="The Xen Project" \ maintainer.email="xen-devel@lists.xenproject.org" @@ -19,7 +19,7 @@ RUN \ apk add sudo && \ apk add dbus && \ apk add bash && \ - apk add python2 && \ + apk add python3 && \ apk add zlib && \ apk add ncurses && \ apk add texinfo && \ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 01:18:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 01:18:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581775.911189 (Exim 4.92) (envelope-from ) id 1qTuJa-00063c-0Z; Thu, 10 Aug 2023 01:18:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581775.911189; Thu, 10 Aug 2023 01:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTuJZ-00063T-SH; Thu, 10 Aug 2023 01:18:13 +0000 Received: by outflank-mailman (input) for mailman id 581775; Thu, 10 Aug 2023 01:18:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTuJY-0005zH-4f for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 01:18:12 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3d13540-371b-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 03:18:09 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A76864D23; Thu, 10 Aug 2023 01:18:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A41C6C433CA; Thu, 10 Aug 2023 01:18:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3d13540-371b-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691630287; bh=crHnn0Bq/eixmDIAlOgACBFKpTbRLyaaGW8boXXtf88=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XdFxW5hfkrVceBkw56P8vvnT7f+YOeZFW1DVrKImOL5kJeH0VelYhj68qazSJzMn1 VHBghTz5vijJSnxDk3tXpVsyGBG98dXAIe+N+YVL0+cRFg4fr4M0rKac2qGHWYQJmC 4xOy2g1D6s0RkG2ioM4tlSQV76zQwug6z9/sihI2LiY/wyHKeB0XUj+NdfGCUJxlZn CrY89z/5nRlX6Ule0FeFsieG0kmjhL80czmcldOzc9AHqAAZFgS0+GPytZnTwHwUUQ wNB3HQAXOfKO+4G37pBrLPZb6vnx5GEOqN3fuJcvHxovkGF+RicXHLQrYwiCFaWv9R B+xfEOTXGSQWA== From: Stefano Stabellini To: michal.orzel@amd.com Cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, cardoe@cardoe.com, Stefano Stabellini Subject: [PATCH 2/2] automation: use Alpine 3.18 instead of 3.12 for all gitlab jobs Date: Wed, 9 Aug 2023 18:18:03 -0700 Message-Id: <20230810011803.311832-2-sstabellini@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/build.yaml | 64 ++++++++++++++++----------------- automation/gitlab-ci/test.yaml | 56 ++++++++++++++--------------- 2 files changed, 60 insertions(+), 60 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index af64a53ead..173613567c 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -273,9 +273,9 @@ # Arm test artifacts -alpine-3.12-arm64-rootfs-export: +alpine-3.18-arm64-rootfs-export: extends: .test-jobs-artifact-common - image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12-arm64v8 + image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.18-arm64v8 script: - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz artifacts: @@ -319,9 +319,9 @@ qemu-system-aarch64-6.0.0-arm32-export: # x86_64 test artifacts -alpine-3.12-rootfs-export: +alpine-3.18-rootfs-export: extends: .test-jobs-artifact-common - image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12 + image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.18 script: - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz artifacts: @@ -345,15 +345,15 @@ kernel-6.1.19-export: # Build jobs needed for tests -alpine-3.12-gcc: +alpine-3.18-gcc: extends: .gcc-x86-64-build variables: - CONTAINER: alpine:3.12 + CONTAINER: alpine:3.18 -alpine-3.12-gcc-debug: +alpine-3.18-gcc-debug: extends: .gcc-x86-64-build-debug variables: - CONTAINER: alpine:3.12 + CONTAINER: alpine:3.18 debian-stretch-gcc-debug: extends: .gcc-x86-64-build-debug @@ -437,78 +437,78 @@ debian-unstable-gcc-debug-arm64-randconfig: CONTAINER: debian:unstable-arm64v8 RANDCONFIG: y -alpine-3.12-gcc-arm64: +alpine-3.18-gcc-arm64: extends: .gcc-arm64-build variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 -alpine-3.12-gcc-debug-arm64: +alpine-3.18-gcc-debug-arm64: extends: .gcc-arm64-build-debug variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 -alpine-3.12-gcc-arm64-randconfig: +alpine-3.18-gcc-arm64-randconfig: extends: .gcc-arm64-build variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 RANDCONFIG: y -alpine-3.12-gcc-debug-arm64-randconfig: +alpine-3.18-gcc-debug-arm64-randconfig: extends: .gcc-arm64-build-debug variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 RANDCONFIG: y -alpine-3.12-gcc-arm64-staticmem: +alpine-3.18-gcc-arm64-staticmem: extends: .gcc-arm64-build variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 EXTRA_XEN_CONFIG: | CONFIG_EXPERT=y CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y -alpine-3.12-gcc-debug-arm64-staticmem: +alpine-3.18-gcc-debug-arm64-staticmem: extends: .gcc-arm64-build-debug variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 EXTRA_XEN_CONFIG: | CONFIG_EXPERT=y CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y -alpine-3.12-gcc-arm64-static-shared-mem: +alpine-3.18-gcc-arm64-static-shared-mem: extends: .gcc-arm64-build variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 EXTRA_XEN_CONFIG: | CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y CONFIG_STATIC_SHM=y -alpine-3.12-gcc-debug-arm64-static-shared-mem: +alpine-3.18-gcc-debug-arm64-static-shared-mem: extends: .gcc-arm64-build-debug variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 EXTRA_XEN_CONFIG: | CONFIG_UNSUPPORTED=y CONFIG_STATIC_MEMORY=y CONFIG_STATIC_SHM=y -alpine-3.12-gcc-arm64-boot-cpupools: +alpine-3.18-gcc-arm64-boot-cpupools: extends: .gcc-arm64-build variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 EXTRA_XEN_CONFIG: | CONFIG_EXPERT=y CONFIG_UNSUPPORTED=y CONFIG_SCHED_NULL=y CONFIG_BOOT_TIME_CPUPOOLS=y -alpine-3.12-gcc-debug-arm64-boot-cpupools: +alpine-3.18-gcc-debug-arm64-boot-cpupools: extends: .gcc-arm64-build-debug variables: - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 EXTRA_XEN_CONFIG: | CONFIG_BOOT_TIME_CPUPOOLS=y @@ -622,15 +622,15 @@ debian-unstable-gcc-arm64-cppcheck: # Build jobs not needed for tests -alpine-3.12-clang: +alpine-3.18-clang: extends: .clang-x86-64-build variables: - CONTAINER: alpine:3.12 + CONTAINER: alpine:3.18 -alpine-3.12-clang-debug: +alpine-3.18-clang-debug: extends: .clang-x86-64-build-debug variables: - CONTAINER: alpine:3.12 + CONTAINER: alpine:3.18 archlinux-gcc: extends: .gcc-x86-64-build diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 45e8ddb7a3..8ccce1fe26 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -8,7 +8,7 @@ - /^stable-.*/ .arm64-test-needs: &arm64-test-needs - - alpine-3.12-arm64-rootfs-export + - alpine-3.18-arm64-rootfs-export - kernel-5.19-arm64-export - qemu-system-aarch64-6.0.0-arm64-export @@ -16,7 +16,7 @@ - qemu-system-aarch64-6.0.0-arm32-export .x86-64-test-needs: &x86-64-test-needs - - alpine-3.12-rootfs-export + - alpine-3.18-rootfs-export - kernel-6.1.19-export .qemu-arm64: @@ -105,7 +105,7 @@ extends: .test-jobs-common variables: # the test controller runs on RPi4 - CONTAINER: alpine:3.12-arm64v8 + CONTAINER: alpine:3.18-arm64v8 LOGFILE: smoke-test.log PCIDEV: "03:00.0" PCIDEV_INTR: "MSI-X" @@ -155,7 +155,7 @@ xilinx-smoke-dom0less-arm64-gcc: - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64 + - alpine-3.18-gcc-arm64 xilinx-smoke-dom0less-arm64-gcc-gem-passthrough: extends: .xilinx-arm64 @@ -163,7 +163,7 @@ xilinx-smoke-dom0less-arm64-gcc-gem-passthrough: - ./automation/scripts/xilinx-smoke-dom0less-arm64.sh gem-passthrough 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64 + - alpine-3.18-gcc-arm64 adl-smoke-x86-64-gcc-debug: extends: .adl-x86-64 @@ -171,7 +171,7 @@ adl-smoke-x86-64-gcc-debug: - ./automation/scripts/qubes-x86-64.sh 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug adl-smoke-x86-64-dom0pvh-gcc-debug: extends: .adl-x86-64 @@ -179,7 +179,7 @@ adl-smoke-x86-64-dom0pvh-gcc-debug: - ./automation/scripts/qubes-x86-64.sh dom0pvh 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug adl-suspend-x86-64-gcc-debug: extends: .adl-x86-64 @@ -187,7 +187,7 @@ adl-suspend-x86-64-gcc-debug: - ./automation/scripts/qubes-x86-64.sh s3 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug adl-pci-pv-x86-64-gcc-debug: extends: .adl-x86-64 @@ -195,7 +195,7 @@ adl-pci-pv-x86-64-gcc-debug: - ./automation/scripts/qubes-x86-64.sh pci-pv 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug adl-pci-hvm-x86-64-gcc-debug: extends: .adl-x86-64 @@ -205,7 +205,7 @@ adl-pci-hvm-x86-64-gcc-debug: - ./automation/scripts/qubes-x86-64.sh pci-hvm 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug zen3p-smoke-x86-64-gcc-debug: extends: .zen3p-x86-64 @@ -213,7 +213,7 @@ zen3p-smoke-x86-64-gcc-debug: - ./automation/scripts/qubes-x86-64.sh 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug zen3p-smoke-x86-64-dom0pvh-gcc-debug: extends: .zen3p-x86-64 @@ -221,7 +221,7 @@ zen3p-smoke-x86-64-dom0pvh-gcc-debug: - ./automation/scripts/qubes-x86-64.sh dom0pvh 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug zen3p-pci-hvm-x86-64-gcc-debug: extends: .zen3p-x86-64 @@ -229,7 +229,7 @@ zen3p-pci-hvm-x86-64-gcc-debug: - ./automation/scripts/qubes-x86-64.sh pci-hvm 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc-debug + - alpine-3.18-gcc-debug qemu-smoke-dom0-arm64-gcc: extends: .qemu-arm64 @@ -237,7 +237,7 @@ qemu-smoke-dom0-arm64-gcc: - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64 + - alpine-3.18-gcc-arm64 qemu-smoke-dom0-arm64-gcc-debug: extends: .qemu-arm64 @@ -245,7 +245,7 @@ qemu-smoke-dom0-arm64-gcc-debug: - ./automation/scripts/qemu-smoke-dom0-arm64.sh 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-debug-arm64 + - alpine-3.18-gcc-debug-arm64 qemu-smoke-dom0less-arm64-gcc: extends: .qemu-arm64 @@ -253,7 +253,7 @@ qemu-smoke-dom0less-arm64-gcc: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64 + - alpine-3.18-gcc-arm64 qemu-smoke-dom0less-arm64-gcc-debug: extends: .qemu-arm64 @@ -261,7 +261,7 @@ qemu-smoke-dom0less-arm64-gcc-debug: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-debug-arm64 + - alpine-3.18-gcc-debug-arm64 qemu-smoke-dom0less-arm64-gcc-staticmem: extends: .qemu-arm64 @@ -269,7 +269,7 @@ qemu-smoke-dom0less-arm64-gcc-staticmem: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64-staticmem + - alpine-3.18-gcc-arm64-staticmem qemu-smoke-dom0less-arm64-gcc-debug-staticmem: extends: .qemu-arm64 @@ -277,7 +277,7 @@ qemu-smoke-dom0less-arm64-gcc-debug-staticmem: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-mem 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-debug-arm64-staticmem + - alpine-3.18-gcc-debug-arm64-staticmem qemu-smoke-dom0less-arm64-gcc-staticheap: extends: .qemu-arm64 @@ -285,7 +285,7 @@ qemu-smoke-dom0less-arm64-gcc-staticheap: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-heap 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64 + - alpine-3.18-gcc-arm64 qemu-smoke-dom0less-arm64-gcc-debug-staticheap: extends: .qemu-arm64 @@ -293,7 +293,7 @@ qemu-smoke-dom0less-arm64-gcc-debug-staticheap: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-heap 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-debug-arm64 + - alpine-3.18-gcc-debug-arm64 qemu-smoke-dom0less-arm64-gcc-static-shared-mem: extends: .qemu-arm64 @@ -301,7 +301,7 @@ qemu-smoke-dom0less-arm64-gcc-static-shared-mem: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-shared-mem 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64-static-shared-mem + - alpine-3.18-gcc-arm64-static-shared-mem qemu-smoke-dom0less-arm64-gcc-debug-static-shared-mem: extends: .qemu-arm64 @@ -309,7 +309,7 @@ qemu-smoke-dom0less-arm64-gcc-debug-static-shared-mem: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh static-shared-mem 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-debug-arm64-static-shared-mem + - alpine-3.18-gcc-debug-arm64-static-shared-mem qemu-smoke-dom0less-arm64-gcc-boot-cpupools: extends: .qemu-arm64 @@ -317,7 +317,7 @@ qemu-smoke-dom0less-arm64-gcc-boot-cpupools: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-arm64-boot-cpupools + - alpine-3.18-gcc-arm64-boot-cpupools qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: extends: .qemu-arm64 @@ -325,14 +325,14 @@ qemu-smoke-dom0less-arm64-gcc-debug-boot-cpupools: - ./automation/scripts/qemu-smoke-dom0less-arm64.sh boot-cpupools 2>&1 | tee ${LOGFILE} needs: - *arm64-test-needs - - alpine-3.12-gcc-debug-arm64-boot-cpupools + - alpine-3.18-gcc-debug-arm64-boot-cpupools qemu-xtf-dom0less-arm64-gcc-hyp-xen-version: extends: .qemu-arm64 script: - ./automation/scripts/qemu-xtf-dom0less-arm64.sh hyp-xen-version 2>&1 | tee ${LOGFILE} needs: - - alpine-3.12-gcc-arm64 + - alpine-3.18-gcc-arm64 - qemu-system-aarch64-6.0.0-arm64-export qemu-xtf-dom0less-arm64-gcc-debug-hyp-xen-version: @@ -340,7 +340,7 @@ qemu-xtf-dom0less-arm64-gcc-debug-hyp-xen-version: script: - ./automation/scripts/qemu-xtf-dom0less-arm64.sh hyp-xen-version 2>&1 | tee ${LOGFILE} needs: - - alpine-3.12-gcc-debug-arm64 + - alpine-3.18-gcc-debug-arm64 - qemu-system-aarch64-6.0.0-arm64-export qemu-smoke-dom0-arm32-gcc: @@ -421,7 +421,7 @@ qemu-alpine-x86_64-gcc: - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee ${LOGFILE} needs: - *x86-64-test-needs - - alpine-3.12-gcc + - alpine-3.18-gcc qemu-smoke-x86-64-gcc: extends: .qemu-x86-64 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 03:33:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 03:33:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581793.911199 (Exim 4.92) (envelope-from ) id 1qTwQb-0004eh-Dv; Thu, 10 Aug 2023 03:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581793.911199; Thu, 10 Aug 2023 03:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTwQb-0004eM-7h; Thu, 10 Aug 2023 03:33:37 +0000 Received: by outflank-mailman (input) for mailman id 581793; Thu, 10 Aug 2023 03:33:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTwQZ-0004eC-AM; Thu, 10 Aug 2023 03:33:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTwQZ-0008Gd-5g; Thu, 10 Aug 2023 03:33:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTwQY-0001by-Ll; Thu, 10 Aug 2023 03:33:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTwQY-0003h1-LF; Thu, 10 Aug 2023 03:33:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HL04PmGx61j6Uc2nezhiY0Wyj/o2J7gpLUcBU03N0RU=; b=obytfAjE06S8aKc0I6oqT4Ec8D XfDt6DKm69jHZBSMwH/XwjQQkZHga4K5nJyKnai1F96l0rafs28oeBiwf3y/lYgyUDtStE4am2cLY iHHqgA1NyYYi478hFLgV4OyhsWT0V+C7a41TP7+ufQzbXB5wSWN9sDO3oBrP7sm/EmQQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182255: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=79c18114c7d71f0227abbbb75e24d114483765f7 X-Osstest-Versions-That: xen=236fc9fdf97f4e7c64824ab793e8dca30dd54ffb From: osstest service owner Date: Thu, 10 Aug 2023 03:33:34 +0000 flight 182255 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182255/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 79c18114c7d71f0227abbbb75e24d114483765f7 baseline version: xen 236fc9fdf97f4e7c64824ab793e8dca30dd54ffb Last test of basis 182250 2023-08-09 16:02:01 Z 0 days Testing same since 182255 2023-08-10 01:02:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Simone Ballarin Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 236fc9fdf9..79c18114c7 79c18114c7d71f0227abbbb75e24d114483765f7 -> smoke From xen-devel-bounces@lists.xenproject.org Thu Aug 10 04:12:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 04:12:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581801.911209 (Exim 4.92) (envelope-from ) id 1qTx2F-0000mI-9H; Thu, 10 Aug 2023 04:12:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581801.911209; Thu, 10 Aug 2023 04:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTx2F-0000mB-65; Thu, 10 Aug 2023 04:12:31 +0000 Received: by outflank-mailman (input) for mailman id 581801; Thu, 10 Aug 2023 04:12:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTx2E-0000lw-7V for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 04:12:30 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2060c.outbound.protection.outlook.com [2a01:111:f400:fe16::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1df0ca85-3734-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 06:12:27 +0200 (CEST) Received: from AS9PR05CA0230.eurprd05.prod.outlook.com (2603:10a6:20b:494::17) by DB9PR08MB8358.eurprd08.prod.outlook.com (2603:10a6:10:3da::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 04:12:16 +0000 Received: from AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:494:cafe::83) by AS9PR05CA0230.outlook.office365.com (2603:10a6:20b:494::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 04:12:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT051.mail.protection.outlook.com (100.127.140.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Thu, 10 Aug 2023 04:12:15 +0000 Received: ("Tessian outbound ba2f3d95109c:v145"); Thu, 10 Aug 2023 04:12:15 +0000 Received: from 045161a4d730.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3F5C4E51-A802-4BCF-A764-5CFD7F6B0FEC.1; Thu, 10 Aug 2023 04:12:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 045161a4d730.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 04:12:09 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com (2603:10a6:150:a9::12) by DB9PR08MB6617.eurprd08.prod.outlook.com (2603:10a6:10:261::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Thu, 10 Aug 2023 04:12:07 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::19bd:f9b9:756b:f1f6]) by GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::19bd:f9b9:756b:f1f6%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 04:12:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1df0ca85-3734-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m0EkChZIIJCHJ/QHdflQAoITOqAY/DUvdYi0tgRVvgU=; b=TOa2fgZkIDfSbLyCiSMfWJXb28qod1p+hSFTN03UyapMSEggoK13onUqPetT6ZQMokuTJnOkRBHOaoUQwq6BEqaZ0OhcMqmQEvmcoQ2ngynqcRwoRzI8LifqOLH32CN4AxjjaejgLZ7MEUTnCLWOWjRID/MfmpRdnxDOcA35vd0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a0c65f415ea28786 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHSFJUAbQ8zOTPskVMiaKQii6IPs41CMOt5US17d7vXG3QuwioE7t9obZ5C8K+BBhsZT1QUr0jFdeuOZJqkPwa2WSMBQLR6CMohoLE0Wnon+b+e+UsgZQiJrII+W6U2DdCVMqodmP167RDQhH2aNyjgC4CVYvZkJeTWBGxifWcpULp6d5x+1K3q5TZqzYNMtS/8JuFst8t8+NNpjBrwBusLnc4eoqHqccwlrwAqW7bVbOuJJXPCYxj8X2FabFWzekB4ydsKnjgjd+yN8uP+vglumOFPvFHetyy8AUNoD1OjXvtcMYiu0PMBc1tMbpvMs+MlD0MMVWjlJkUJPSnXOXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m0EkChZIIJCHJ/QHdflQAoITOqAY/DUvdYi0tgRVvgU=; b=Y1VCXfsfJC8ooo0eW3FS6tXX7CEP9qJARAUlqbGuPHcfWmo/rG63Wcsa1DiiW5y7sK9nKU9eVGvUodLMkwiUb51Un/5Lee3z9qKThR1x1WV52XIulTNdCc6ws5KVNP50o5mzq3IjVPxJ40snyFdK+11GRTrPvdK4LxbEwWR1hhks1FB7CahYmMgjQUKr3Mfw68doxZXpHyQvdxqBlEWzIR6UTAp6XJeK1E01x/Z8maft63EySfrQXHXi2ZbWEMB9CEfKk7Euf9f96ONqTfibM5UaNV2y6S4VEO0x7Ted8w6HhRZGUT+SHzulLc4PXJ4vI/TBQtx901D6R/KugsQMBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m0EkChZIIJCHJ/QHdflQAoITOqAY/DUvdYi0tgRVvgU=; b=TOa2fgZkIDfSbLyCiSMfWJXb28qod1p+hSFTN03UyapMSEggoK13onUqPetT6ZQMokuTJnOkRBHOaoUQwq6BEqaZ0OhcMqmQEvmcoQ2ngynqcRwoRzI8LifqOLH32CN4AxjjaejgLZ7MEUTnCLWOWjRID/MfmpRdnxDOcA35vd0= From: Henry Wang To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Thread-Topic: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm Thread-Index: AQHZxCqBtZIUxf7FmUaIEyO8EPs3TK/h6aMAgAEPoIA= Date: Thu, 10 Aug 2023 04:12:06 +0000 Message-ID: <9D42DF7B-B1E0-4A13-9F84-6CA2B77236D4@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-2-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: GV2PR08MB8001:EE_|DB9PR08MB6617:EE_|AM7EUR03FT051:EE_|DB9PR08MB8358:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ed7b82b-a70f-4a23-8f7b-08db9957fb47 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: biyQVrhcwC7YKf4IVqNfNVLeLi8AHp7U8FH5PoOElQjaxT3mW5EPw2G6RtObLS5GKf/nNRg0eMMJonGBCVKZjl6u33ftWznS/5KFI+0ykI5Aj/uennAcMVKZ8cQBSWSqSLwCMAsnPXIZ0lzxaptSwsl5CNg5/Znx9Zkc1Tlr0McYdFESjspRus4ns93BmWzXRqHLGQBbCrawEoubNeehi4SD4zV29DljPrCDQAbsI/zq4/qcCXzFAqN2PrvTZkwm02I40UAKNm/efivOaua4ixdCxnBYLDlTbbF4SuwvAdO/NzQB/dFPVZp73RQggbSLEquLQAJUCr2cvuyM7+N7CYaS+Kl/1bSSznzRPHAdDlFLNR9urXcNpHT4jhqQFxxd2wGcS+WqydvYcBsOujN4TPZ4zF9olzWvKrbvU8dyUzKMVufz9QbEETc+Y6C8d38i7Wy7zBatySyfSBVlrHwohzyNPs5igaGWfoMVO46ORQNnKkTFNdccNrtEhBLrE5ggLK2jVqT7/zYUstIWu0JuL420TPvk+pLRa1f6Wm6W3PSKqebtju+B1daqXlQ8QDg8McMqettA88oM18PDUpyd/soDWiSOwepoCVs5GaQwFEwP5fjcoID+hlOCotaC1iI7p72mmC+Ihbxw2mu+auO2tw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8001.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(1800799006)(186006)(26005)(38100700002)(122000001)(6916009)(6506007)(53546011)(38070700005)(2616005)(36756003)(83380400001)(2906002)(54906003)(5660300002)(478600001)(33656002)(71200400001)(6512007)(66446008)(6486002)(41300700001)(64756008)(66946007)(4326008)(66476007)(76116006)(316002)(91956017)(86362001)(8936002)(66556008)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <0CF4B78AD3D2FC41A941C4B6EDCF33C8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6617 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3623c2e8-08a3-4ee1-e19d-08db9957f5c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w9sH8FmRT3MzihYlqE/HYDdnLESwZ3lgx3P7dIs2V/wRx/dlIUobU9+8OLkII+CBj4z1MbVq8dLQ8Nva2BhqHVoeM6dnraLAosfIcLwFcOJFigzcQBr48pfVWlnIoVmv4q060hM5/TDfohDfiDdmPwrTXtEi0bYlnXlPjRX6J7zEG6YhhcXwNoIptIhdUdxHf0W9lDDMD+taRryZodGNVJy2qebEQQrkBfAXQd57/U519hgV4/KIUqtbThEjjSzQIPc8pI4A/HMBvxdcmUBwjTJeGZqgEhljzcdS/aiMxlIMP95CgexU3ETz8Btj2dnGPKJchtK/fLIibbSfXDRve/xl2/Bq7BbIaVhI123Tt9qmjb1Jg42vaHF+WSUBx026Ww9pSERcf9HjiK2V6f6tiNLYmfof2AGSYdxtYc+47WJglvbHqrQ3fR/KjmIgQHuGiiEwfKTimhmFEyNp15bkcahgR1yZVepXKXeJtO++rxi3LdYUAYpTtdih5SfT/Yhwd8s3b/x0hheRU0WLjQYvaZFAySmS+MKlSSLWr3dxXx6KBJLg2FsS/bPRhTcNB48+UWjL0wnBZoG/d4wN4pFml+g5aWojPZSb2Yxl5OZ636WawkNqynTaPzIwP7Bk8ay1KHqrnYnbq7JxCWRzbDAy8IEoaaIQwASL6UyeTxzh/8x8HKhtepwHl5SKRtDr2zH8A4byoG5gd4NlAqSoIMtdoVwwuartIceawq+GKn6+1uyHG8qVwnb7xX9kqTs9+L7p X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199021)(1800799006)(186006)(82310400008)(36840700001)(40470700004)(46966006)(40460700003)(40480700001)(70206006)(70586007)(336012)(54906003)(6506007)(53546011)(26005)(478600001)(36756003)(33656002)(47076005)(83380400001)(2616005)(36860700001)(41300700001)(316002)(6512007)(4326008)(6486002)(2906002)(6862004)(8936002)(86362001)(8676002)(82740400003)(5660300002)(356005)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 04:12:15.9407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ed7b82b-a70f-4a23-8f7b-08db9957fb47 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8358 SGkgSnVsaWVuLA0KDQo+IE9uIEF1ZyA5LCAyMDIzLCBhdCAxOTo1OSwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBIZW5yeSwNCj4gDQo+IFRpdGxlOiBOSVQ6 IEFkZCAoKSBhZnRlciBfbW0gdG8gc3RheSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3QuDQoNClll cyBzdXJlLCBJIHdpbGwgYWRkIOKAnCgp4oCdIGluIHY1Lg0KDQo+IA0KPiBPbiAwMS8wOC8yMDIz IDA0OjQ0LCBIZW5yeSBXYW5nIHdyb3RlOg0KPj4gRnJvbTogV2VpIENoZW4gPHdlaS5jaGVuQGFy bS5jb20+DQo+PiANCj4+ICtlbmFibGVfc2Vjb25kYXJ5X2NwdV9tbToNCj4+ICsgICAgICAgIG1v diAgIHg1LCBscg0KPj4gKw0KPj4gKyAgICAgICAgbG9hZF9wYWRkciB4MCwgaW5pdF90dGJyDQo+ PiArICAgICAgICBsZHIgICB4MCwgW3gwXQ0KPj4gKw0KPj4gKyAgICAgICAgYmwgICAgZW5hYmxl X21tdQ0KPj4gKyAgICAgICAgbW92ICAgbHIsIHg1DQo+PiArDQo+PiArICAgICAgICAvKiByZXR1 cm4gdG8gc2Vjb25kYXJ5X3N3aXRjaGVkICovDQo+IA0KPiBUZWNobmljYWxseSwgeW91IHdpbGwg cmV0dXJuIHRvIHRoZSB2aXJ0dWFsIGFkZHJlc3Mgc2V0IGluICdscicuIFRoaXMgaXMgJ3NlY29u ZGFyeV9zd2l0Y2hlZCcgdG9kYXkgYnV0IHRoaXMgY291bGQgY2hhbmdlLg0KPiANCj4gU28gaXQg d291bGQgYmUgYmV0dGVyIHRvIGhhdmUgYSBtb3JlIGdlbmVyaWMgY29tbWVudCBsaWtlOg0KPiAN Cj4gUmV0dXJuIHRvIHRoZSB2aXJ0dWFsIGFkZHJlc3MgcmVxdWVzdGVkIGJ5IHRoZSBjYWxsZXIu DQoNClN1cmUsIGFuZC4uLg0KDQo+IA0KPj4gKyAgICAgICAgcmV0DQo+PiArRU5EUFJPQyhlbmFi bGVfc2Vjb25kYXJ5X2NwdV9tbSkNCj4+ICsNCj4+IA0KPj4gKzE6DQo+PiArICAgICAgICAvKg0K Pj4gKyAgICAgICAgICogVGhlIDE6MSBtYXAgbWF5IGNsYXNoIHdpdGggb3RoZXIgcGFydHMgb2Yg dGhlIFhlbiB2aXJ0dWFsIG1lbW9yeQ0KPj4gKyAgICAgICAgICogbGF5b3V0LiBBcyBpdCBpcyBu b3QgdXNlZCBhbnltb3JlLCByZW1vdmUgaXQgY29tcGxldGVseSB0bw0KPj4gKyAgICAgICAgICog YXZvaWQgaGF2aW5nIHRvIHdvcnJ5IGFib3V0IHJlcGxhY2luZyBleGlzdGluZyBtYXBwaW5nDQo+ PiArICAgICAgICAgKiBhZnRlcndhcmRzLiBGdW5jdGlvbiB3aWxsIHJldHVybiB0byBwcmltYXJ5 X3N3aXRjaGVkLg0KPiANCj4gU2FtZSByZW1hcmsgaGVyZS4NCg0K4oCmc2FtZSBoZXJlLg0KDQo+ IA0KPj4gKyAgICAgICAgICovDQo+PiArICAgICAgICBiICAgICByZW1vdmVfaWRlbnRpdHlfbWFw cGluZw0KPj4gKw0KPj4gKyAgICAgICAgLyoNCj4+ICsgICAgICAgICAqIEJlbG93IGlzIHN1cHBv c2VkIHRvIGJlIHVucmVhY2hhYmxlIGNvZGUsIGFzICJyZXQiIGluDQo+PiArICAgICAgICAgKiBy ZW1vdmVfaWRlbnRpdHlfbWFwcGluZyB3aWxsIHVzZSB0aGUgcmV0dXJuIGFkZHJlc3MgaW4gTFIg aW4gYWR2YW5jZS4NCj4+ICsgICAgICAgICAqLw0KPj4gKyAgICAgICAgYiAgICAgZmFpbA0KPiAN Cj4gTG9va2luZyBhdCB0aGlzIGFnYWluLCBJIGFtIG5vdCBlbnRpcmVseSBzdXJlIGhvdyB0aGlz IGNvdWxkIHJlYWNoZWQgaWYgcmVtb3ZlX2lkZW50aXR5X21hcHBpbmcgdXNlICdyZXQnIGFuZCB5 b3UgY2FsbCBpdCB3aXRoICdiJy4gU28gSSB3b3VsZCBzdWdnZXN0IHRvIGRyb3AgaXQgYW5kIG1v dmUgJ21vdiBsciwgeDUnIGNsb3NlciB0byAnYiByZW1vdmVfaWRlbnRpdHlfbWFwcGluZycuIFNv IGl0IGlzIGNsZWFyZXIgdGhhdCBpdCB3aWxsIHJldHVybi4NCg0KT2ssIEnigJl2ZSBhZGRyZXNz ZWQgdGhpcyBsb2NhbGx5IGFuZCB0ZXN0ZWQgdGhlIGNoYW5nZSwgWGVuIGFuZCBEb20wIGJvb3QN CmZpbmUgd2l0aCB0aGUgY2hhbmdlcyB0aGF0IHlvdSBzdWdnZXN0ZWQuIFdpbGwgc2VuZCB2NSBz b29uIGFmdGVyIGZpeGluZw0KYWxsIHlvdXIgY29tbWVudHMuIFRoYW5rcyENCg0KS2luZCByZWdh cmRzLA0KSGVucnkNCg0KPiANCj4+ICtFTkRQUk9DKGVuYWJsZV9ib290X2NwdV9tbSkNCj4+ICsN Cj4+ICAvKg0KPj4gICAqIFJlbW92ZSB0aGUgMToxIG1hcCBmcm9tIHRoZSBwYWdlLXRhYmxlcy4g SXQgaXMgbm90IGVhc3kgdG8ga2VlcCB0cmFjaw0KPj4gICAqIHdoZXJlIHRoZSAxOjEgbWFwIHdh cyBtYXBwZWQsIHNvIHdlIHdpbGwgbG9vayBmb3IgdGhlIHRvcC1sZXZlbCBlbnRyeQ0KPiANCj4g Q2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Aug 10 04:39:18 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 04:39:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581809.911218 (Exim 4.92) (envelope-from ) id 1qTxRv-0004oi-F5; Thu, 10 Aug 2023 04:39:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581809.911218; Thu, 10 Aug 2023 04:39:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTxRv-0004ob-CH; Thu, 10 Aug 2023 04:39:03 +0000 Received: by outflank-mailman (input) for mailman id 581809; Thu, 10 Aug 2023 04:39:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTxRt-0004oR-I4 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 04:39:01 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0629.outbound.protection.outlook.com [2a01:111:f400:fe0c::629]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d1782cfa-3737-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 06:38:57 +0200 (CEST) Received: from DUZPR01CA0235.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::19) by PAWPR08MB8888.eurprd08.prod.outlook.com (2603:10a6:102:33c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 04:38:50 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b5:cafe::87) by DUZPR01CA0235.outlook.office365.com (2603:10a6:10:4b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 04:38:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.18 via Frontend Transport; Thu, 10 Aug 2023 04:38:49 +0000 Received: ("Tessian outbound f9124736ff4f:v145"); Thu, 10 Aug 2023 04:38:49 +0000 Received: from b47b496af87b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75B696E6-2673-4AEB-BA2D-4B58A5EFCB54.1; Thu, 10 Aug 2023 04:38:42 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b47b496af87b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 04:38:42 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com (2603:10a6:150:a9::12) by AS1PR08MB7563.eurprd08.prod.outlook.com (2603:10a6:20b:472::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 04:38:41 +0000 Received: from GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::19bd:f9b9:756b:f1f6]) by GV2PR08MB8001.eurprd08.prod.outlook.com ([fe80::19bd:f9b9:756b:f1f6%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 04:38:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1782cfa-3737-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yy62ScwNvi03uEzv2P7ASs/DqaoxRJuTMUvG7ja0Ffc=; b=Rq13kpv1m50Om3bLBby+YNIG0IAF5ZDUJr1sdAhAcw4kVY/Cj8vjyktEYyahJ2bPFUzUymiX70KqEgtwj83fClYv/8P+DPxlA/0kAK2g/1ioCn2pcUpz/DX2ndOCwp8tQoUz6FPMTv9YnrPEwu2POwUzPneMUQdlD5sJq3cGrAc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 122a2afff2d65ca3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbqQJ5JFVl12KcsWBzJiVUxh8bRlIKQ+rpHWTic8IocNU218qk8k8lE7h0HITE/G77WnKEmHBIBbzs+1dXKdI/bRgcnvZs4p2MlDNPERp7rFnG9y5GcULUTy7VK53UaEJA+1al/1WKfTWlw7NtEmyrechv/IW7CWQd+/TjKkdycZ75uJU3r2pVEoNkIxmHwdnsOoyzcxcZ7qbOjp+RBGlet8g7anCMC8Chd21blprMaqUzR9lGTbQ0w/tY/fW+oQJjv47Pyxs1Bq2uDRu852eM+nphqi7ZVtrAXR3r3Jyxtb3DN7oLlP8rrhIAjNyBYS+8lyjcK8Q+zfLzVY9mHe3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yy62ScwNvi03uEzv2P7ASs/DqaoxRJuTMUvG7ja0Ffc=; b=jiE9kpz8BYHlwyk0jlkVj1Icj/TtI/PqqGatNKaznB/ToY9gxiSe6S+5tWcWef8gsghyty+dGboKW1rTDyHJhR7fWxhmzTKGf9xYbpd+7CzqNvr0hatIFUgSJKzKxtwG0sTZq/rvqYGP+3HLr57zVLYP7z/D4SOp5s333iOJe374pbU1qAN/IVk67/qwy3zvMk/Yt/QFGizQspFr9vB2qe7TCQTtkY6KKrQH6fgsq9HHUIXn7+m4sJRg5mz7hLeARuKB9nfULDfpR+PKvGFlow2kH92ruNfE6EbLs8BQ12sV9FGfDmskE4/LMfz1X5jJdTWlLuOlGJQ75YNFvGp/gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yy62ScwNvi03uEzv2P7ASs/DqaoxRJuTMUvG7ja0Ffc=; b=Rq13kpv1m50Om3bLBby+YNIG0IAF5ZDUJr1sdAhAcw4kVY/Cj8vjyktEYyahJ2bPFUzUymiX70KqEgtwj83fClYv/8P+DPxlA/0kAK2g/1ioCn2pcUpz/DX2ndOCwp8tQoUz6FPMTv9YnrPEwu2POwUzPneMUQdlD5sJq3cGrAc= From: Henry Wang To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk , Julien Grall Subject: Re: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture Thread-Topic: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture Thread-Index: AQHZxCqJmtSfvrOVyE67LM5R2F23xa/h6xaAgAEVmgA= Date: Thu, 10 Aug 2023 04:38:41 +0000 Message-ID: <74203F81-0FFE-4474-88AF-D0126D3022C3@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-3-Henry.Wang@arm.com> <429625da-ec4f-448f-a0c4-47ca0f62f395@xen.org> In-Reply-To: <429625da-ec4f-448f-a0c4-47ca0f62f395@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: GV2PR08MB8001:EE_|AS1PR08MB7563:EE_|DBAEUR03FT021:EE_|PAWPR08MB8888:EE_ X-MS-Office365-Filtering-Correlation-Id: 59fe0b20-47bd-4a46-0d0b-08db995bb149 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G6kWyb8xaMq0mSX28bwEFuO6VudZNCy/NqmrRvSo1j2ddLDYeMCqxYNo0vQknnXsYzhEloymO/CTkvo3ow3h6p10Cuzqjt2/XxTO1WQrBbX3hOJuf2MoIlY8s/dLbXE4PV3u8vBjRVEdalF8eiSv/dKDCXgwtZ/9najlsPon/xmpgfMFYeuZcl+QvAR7dyCuepF5BsPee7GmvQlP9xPqjP8sNJ4T87VPu5H3pUbI5m93twHRg2uKPpcZx2VjzR3ROqFh9cDygWgEHYYyBR1gw3t9ANp6FN81oe5Hw8dwF7weqTnYBEyQAIGt8TqcPwsPkoHV5Ce9t8FeUy/g8pe9pkcbOBHMHlfqT5wve3F2RPB2penVO4zKOJweeq5r5Dpkmv2PlD3W93FTuS7v+LabXeRSwdmXtCt5aO9lhqqB8LOfq2IMvrqOLXZBjNupOAVDbKHx1F51/8bxuxikSBisy0k6/lwtwQqswgA7i8dMx6MS2gWVpvru39HQYUF/mzhmVlkZtUf4DoO9J67QO8jD2fF+LyH3gTvOFjsE36SRt/kIw1logE/CSrT6bo9B6xEnIJe8RCr61KVvFGi1psB0aHQa19sGp5ckiHhur/xZ8ZsF4m2X59A6E6WJk3uTS+QUClfqzSHv5BSPLMJwv0UP6Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8001.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199021)(1800799006)(186006)(33656002)(2616005)(316002)(41300700001)(8936002)(83380400001)(66946007)(478600001)(6486002)(66556008)(71200400001)(53546011)(76116006)(54906003)(6506007)(91956017)(26005)(64756008)(6916009)(6512007)(4326008)(66476007)(66446008)(38100700002)(86362001)(38070700005)(36756003)(122000001)(5660300002)(2906002)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7563 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25778f14-3221-41a0-24fa-08db995bac19 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AjqOYG5UcTA/fbc5rv1cA7yGjmDS4v5daMZXXHza+IAEpqtWktB4c+tUGoSh6rEDaDIIgaTg4N3fftMeuiIs0oA2xBTH5UDGJDSmvr8dhE+NCChZhdM/ylSP9PBbqoYzym2Afc5kEZn4Ld1NbAV/UlM2fV6yfBHYn2KsxHN3E0pGVrKBNCDUjedChoGTo79z0e7+azZ/7/4BcMZpq+9q7SFnO+g5wF6HMC4lM/u7A7TbQtoG0hVjcF24X7IBra7LJ9kb+4dCGGvQXMIOGesek25JLolfwAN/TOVpXsPUWpgKzEWKvjIbn3YuQuL3qYuiIQqahUKbS4SlYkqfSxe/T6/JaYVLqNL56ZqT+6hXFAhcPZvR7dDV5ECek6LJlHj5U6dqYlN4U1eUP5FnoZRrtJ9KjxGsN1Z0cbBFBRSm4Y7jxCUnjiqssJVAcaFSm6zCthvL6Vxqsx2dLx2yBlyHo3yEZ6tqpirERCRescjzVYcFpMm+g9iThf6+q3tdk0hT6GNsSTk40Vyp0+9d51fx9PxwZ9Hh9daTxIqQp7S+lJ/be23XNDry1BS6Y4ogv6EguXJT2FTjF5EFpkf6pckqwBII+0PCUWLK3oxQUJPmzGSw3NbAPcPTb05ovp2lmrdRpyOyi+d3cD+/T8SsYP2eTDT3Z1ZKP48w6ordiYfCzDqxAqvTCy5WUPGFxqXMHLRO1SWZM/fmzp45+XnPDBeSfEdsQG1R3+6AMQoOcUuqSlM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(186006)(82310400008)(1800799006)(451199021)(40470700004)(36840700001)(46966006)(2906002)(8676002)(83380400001)(107886003)(2616005)(41300700001)(47076005)(36756003)(336012)(5660300002)(40480700001)(36860700001)(40460700003)(6506007)(26005)(53546011)(8936002)(6862004)(86362001)(54906003)(6486002)(82740400003)(478600001)(81166007)(356005)(33656002)(316002)(4326008)(70206006)(70586007)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 04:38:49.8329 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59fe0b20-47bd-4a46-0d0b-08db995bb149 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB8888 Hi Julien, > On Aug 9, 2023, at 20:04, Julien Grall wrote: >=20 > Hi Henry, >=20 > On 01/08/2023 04:44, Henry Wang wrote: >> There are two types of memory system architectures available for >> Arm-based systems, namely the Virtual Memory System Architecture (VMSA) >> and the Protected Memory System Architecture (PMSA). According to >> ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that >> controls address translation, access permissions, and memory attribute >> determination and checking, for memory accesses made by the PE. And >> refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection >> scheme where an Memory Protection Unit (MPU) manages instruction and >> data access. Currently, Xen only suuports VMSA. >> As a preparation of the Xen MPU (PMSA) support. Introduce a Kconfig >> choice under the "Architecture Features" menu for user to choose the >> memory system architecture for the system. Since currently only VMSA >> is supported, only add the bool CONFIG_HAS_MMU to keep consistent with >> the default behavior. User can choose either VMSA or PMSA but not both >> in the future after PMSA/MPU is supported in Xen. >=20 > So in the long run I agree that we will want to have a choice. But this s= eems to be a bit premature to introduce it now as the user can't select the= MPU and also can't deselect MMU. >=20 > Therefore, I think it would be best if we introduce an unselectable confi= g for now. Like: >=20 > HAS_MMU > def_bool y >=20 > This could be turned to a choice once you introduce the MPU. >=20 > Also, from my understanding, we are using the prefix HAS_ to indicate if = an architecture support the given feature. In your case, you will want the = user to select it, so I would just name the config MMU. Make sense, I will just introduce a MMU def_bool y in this patch and turn this to a choice between CONFIG_MMU and CONFIG_MPU in the last patch of the full MPU series where MPU is expected to be functi= onal. Kind regards, Henry >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 10 05:44:32 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 05:44:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581815.911229 (Exim 4.92) (envelope-from ) id 1qTyT2-0003w8-6a; Thu, 10 Aug 2023 05:44:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581815.911229; Thu, 10 Aug 2023 05:44:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTyT2-0003w1-3N; Thu, 10 Aug 2023 05:44:16 +0000 Received: by outflank-mailman (input) for mailman id 581815; Thu, 10 Aug 2023 05:44:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTyT0-0003vr-3M; Thu, 10 Aug 2023 05:44:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTySz-0004Xf-S6; Thu, 10 Aug 2023 05:44:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTySz-0004px-CH; Thu, 10 Aug 2023 05:44:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qTySz-0005eC-Bk; Thu, 10 Aug 2023 05:44:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mXyQepKXgWQizKWM32QKaQwH9twQeUdHXXoEv1gvBPI=; b=llrdfhtXuiw2GzexEOsreUHPoV 7hwn+bCh0bVitN5JfU56I9EirytES8jC6YhJEkNR9biIVZlE10hqXPhBmr9enoO1P80G0DuPIaMxf QVORoMXDXfg7MaJLZGGmuii79YcTF0oDfrJstYEv4AaIh7vSVYnK/GpmILi/7MFCqJr4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 182239: regressions - FAIL X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start.2:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=21732fd224978ebddf4bded7cb99663d2be1e732 X-Osstest-Versions-That: linux=887433e4bc9394676d22c038dba33a27405f94e8 From: osstest service owner Date: Thu, 10 Aug 2023 05:44:13 +0000 flight 182239 linux-5.4 real [real] flight 182256 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182239/ http://logs.test-lab.xenproject.org/osstest/logs/182256/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 182076 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail in 182256 pass in 182239 test-amd64-i386-xl-xsm 7 xen-install fail pass in 182256-retest test-armhf-armhf-xl-credit2 19 guest-start.2 fail pass in 182256-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 14 guest-start fail like 182065 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182076 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182076 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182076 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182076 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182076 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail like 182076 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 182076 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182076 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182076 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182076 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182076 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182076 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182076 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182076 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 21732fd224978ebddf4bded7cb99663d2be1e732 baseline version: linux 887433e4bc9394676d22c038dba33a27405f94e8 Last test of basis 182076 2023-07-29 17:15:26 Z 11 days Testing same since 182239 2023-08-08 18:13:15 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arnaldo Carvalho de Melo Ben Hutchings Borislav Petkov (AMD) Borislav Petkov Daniel Sneddon Dave Hansen Geert Uytterhoeven Greg Kroah-Hartman Joerg Roedel Josh Poimboeuf Juergen Gross Kim Phillips Paolo Bonzini Peter Zijlstra (Intel) Peter Zijlstra Richard Weinberger Ross Lagerwall Sean Christopherson Thomas Gleixner Tom Lendacky jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 738 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Aug 10 06:46:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 06:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581825.911241 (Exim 4.92) (envelope-from ) id 1qTzQj-00021F-ES; Thu, 10 Aug 2023 06:45:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581825.911241; Thu, 10 Aug 2023 06:45:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTzQj-000218-Bs; Thu, 10 Aug 2023 06:45:57 +0000 Received: by outflank-mailman (input) for mailman id 581825; Thu, 10 Aug 2023 06:45:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTzQh-000212-ND for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 06:45:55 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20600.outbound.protection.outlook.com [2a01:111:f400:fe59::600]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85a72b89-3749-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 08:45:42 +0200 (CEST) Received: from CY5PR19CA0034.namprd19.prod.outlook.com (2603:10b6:930:1a::13) by MW4PR12MB7165.namprd12.prod.outlook.com (2603:10b6:303:21b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 06:45:46 +0000 Received: from CY4PEPF0000E9D9.namprd05.prod.outlook.com (2603:10b6:930:1a:cafe::37) by CY5PR19CA0034.outlook.office365.com (2603:10b6:930:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 06:45:46 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D9.mail.protection.outlook.com (10.167.241.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Thu, 10 Aug 2023 06:45:46 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 01:45:43 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 9 Aug 2023 23:45:34 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 01:45:31 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85a72b89-3749-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNKGXb9/ZI4rUunDiwSpMRsrcksHNxVy3LKrT5hwGTyGt5LfxO2ldnm0pLOOX/ZZBc8kqAHFLZt5NwQyWfr9iTxirtKgdo6Yf3kXBNgoD6tLXYEC/wMib4r8fDAFkEmSdvLwmgXy6/QpS90hkWTvydguX8zOmMMCCEq7tEOftagplmB/2rDxsbTCfc95dBfribsu5xWbHpXAflG9jpWjy4TkFQzV4hE1ULs0VTfhZajlEcGTyUVRQEpnGXoe3z+37I2B1lCvtv8cV40oOIzwk9QUm1LsNQ6AdlE7lNPVGlC9PkXEdoNe5x3yaRPpGyje73ZhxSuwB1zWBlUHs3aunA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R87u6pIYt02/RYsjsUdIkzY9niQNjr9GCe7BLv+qUqg=; b=ZN2+9J0+qMsALOO5vQ4OiU5M1SfDjUMygrKL5yFTmB4cwfQCOZOgihmDPQITdR3uSurJS2QgU87WRasVJNcAURXb4TPbsvVw+8rpKNTWoawnYOFwU8vMwe9c2XkTZ/Cwk4M6mBCzoMPnne0o+C+u2NrMfUwI14dLgzxAdxP3oB5Yv42iY+tiaQBuejRv1PzDhqETWQmz5o+ITxHWOoKS6IEHffPLVqL3xFPU4fOGDRhlgBMRPm3pddlpNKIruPeNUelu5gh++LxndNCiYENyovvAUX8DXUEW7UdNIhJtZFkfqHX/qmge+k0j/nwiC41zshNG38EFl99n8fzgapSNzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R87u6pIYt02/RYsjsUdIkzY9niQNjr9GCe7BLv+qUqg=; b=YrhuCT4hy1gi5bh9wz2HUdEQghoRHw5JkGnQxjt4yur27W4BiLJcgPuzzY3ET3Uh270XTKaAqpFPDMJxBH8bAGXPkTlG/zvv7F784WJSBT7BRKj/Lk3/d6FWgrhmXEZP20vAa3iDQC+nirTYI7HwGln6+JUIaCYTVFtuDn9NtAQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Message-ID: Date: Thu, 10 Aug 2023 08:45:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: Moving Dom0less to common, Was: [PATCH 0/5] Fine granular configuration Content-Language: en-US To: Stefano Stabellini , Luca Fancellu , , , CC: , , , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , , , References: <20230808080010.3858575-1-luca.fancellu@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D9:EE_|MW4PR12MB7165:EE_ X-MS-Office365-Filtering-Correlation-Id: a18ca832-33e4-40db-c133-08db996d6cef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mBctEQiSyqHUDLDUAPVxXceCxJ26ttum10AhKDhYAe+TiIbr9vivakWHMog8yH1sRoArFLaFgLLla0ZQU31LpG8WnpbbSpk6sLQ7cOKAcIwbCW7K5ViGBQEe0d2ace8QqTWd1GyGB9W+O+tAKzcGHtlpbDWBPUI0Eh3EYN5JrGHYFo9b7WsHLzHtr3bs/AmNoQ2LvVs2+cPGDN9YSA6MweH3JzOSYa3xkFwt+U4wKp0Oe7ogt7n4UaRCp8DUTKd2eyqOK1WQidyvb4xOy10GuqrQWtUgfKiMBLvagUzZSHeUhfTjbjZ6SgglwY9mkxClkSP/1YBCpwxuS73kwMqYSigJlh0iqfsVpwj0iHMWmFbskqz9OOtzwzo3JnrVa44ph73eo1Le1SAZqCePnaZZoymyDLXkolrR9+bfbArZAvALTPWN9/JJ9NorGXGM8v8nyReFNLjUJuMwJLZ0pnVfi3PxArKVwbajdqRjgaMnOOUGNNdUQ9NNQRAVvP5n7wFxvc2g0/Vl0SI7wZC4wh3hCP+3zDauyhdFhVCHmLcf/jXruo8bObYED4EYuR5ZH0UZhwnQW5tu0j9XCyP/9VD2puLC3hS8NeDkpMAmOib8N9L5/Gm/0Z2iEJkf+azkiuCILEuMFGLp53I3k1FIMFG8UhZxdrAggikv9PCM9FLZjGNVMx02tiiwXtbj9VeeQJV6LGOqKQsIrV15DEA7xNQPUcyV+OAbP34VdI9XKJfLZiH8gNduYBsmxpgoyJVGId+XpwIBQr8iALPFDGiFWfkYE8ufc4CiF74qxswGgkz+tqzmLG8GpLOgjQnD6x7LjI3O X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(136003)(376002)(186006)(82310400008)(1800799006)(451199021)(36840700001)(46966006)(40470700004)(478600001)(36756003)(110136005)(54906003)(2616005)(81166007)(336012)(356005)(70586007)(70206006)(4326008)(82740400003)(316002)(16576012)(41300700001)(8676002)(8936002)(36860700001)(5660300002)(31686004)(44832011)(7416002)(26005)(40480700001)(31696002)(47076005)(966005)(2906002)(53546011)(426003)(40460700003)(86362001)(32563001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 06:45:46.0100 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a18ca832-33e4-40db-c133-08db996d6cef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7165 On 09/08/2023 21:51, Stefano Stabellini wrote: > > > Adding hyperlaunch and x86 maintainers. > > > Hi Luca, > > This patch series is very timely. You might not have realized but we > were just discussing with the hyperlaunch guys to move dom0less code to > common. > > Your series is a great step in the right direction. However, we don't > want to move the dom0less code twice because it would make 'git blame' > very hard to use. > > I wonder if I could ask you to move the code to xen/common/ instead. I > am not asking you to make it buildable on x86, as that would take more > work and also something along the lines of this patch series from > Christopher: > https://patchew.org/Xen/20230701071835.41599-1-christopher.w.clark@gmail.com/ The question is whether we want to move everything related to dom0less parse/build to common. There are parts that make sense only for Arm. Also, a plain move might not be what hyperlaunch wants and what Daniel described in his plans for the future. FWIU, hyperlaunch wants to operate on flattened device tree whereas the majority of dom0less build/parse code is done using unflattened device tree (FDT is used at the very early stage of the boot and is contained in bootfdt.c). Maintaining two sets of parsers is not the best idea. @Daniel,Christopher, what is the reason of using FDT and not DT on hyperlaunch? Is is because there are parts of configuration that you want to probe early (e.g. XSM module)? ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 10 07:04:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 07:04:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581831.911252 (Exim 4.92) (envelope-from ) id 1qTziC-0004XC-U3; Thu, 10 Aug 2023 07:04:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581831.911252; Thu, 10 Aug 2023 07:04:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTziC-0004X4-RI; Thu, 10 Aug 2023 07:04:00 +0000 Received: by outflank-mailman (input) for mailman id 581831; Thu, 10 Aug 2023 07:03:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTziB-0004Wy-Km for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 07:03:59 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2062b.outbound.protection.outlook.com [2a01:111:f400:fe12::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cd4f256-374c-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 09:03:47 +0200 (CEST) Received: from DUZPR01CA0080.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::9) by AS2PR08MB9074.eurprd08.prod.outlook.com (2603:10a6:20b:5fc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 07:03:51 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46a:cafe::f2) by DUZPR01CA0080.outlook.office365.com (2603:10a6:10:46a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 07:03:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 07:03:51 +0000 Received: ("Tessian outbound f5de790fcf89:v145"); Thu, 10 Aug 2023 07:03:51 +0000 Received: from e2dff860498e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 616B723D-C73C-4945-AC2A-9676F1961407.1; Thu, 10 Aug 2023 07:03:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e2dff860498e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 07:03:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB6620.eurprd08.prod.outlook.com (2603:10a6:10:256::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Thu, 10 Aug 2023 07:03:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 07:03:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cd4f256-374c-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cvrWNyjbDpTmZnf0vMth/aapfAQuIjJ3bnmuNzS6s7s=; b=ZaHwD+I2aLK/WTynV/c1W/Fr6+0C6NyUyjfbmTxA1ygr4Fv5gyCLxCO6f3YXKlEGtB4MtAW9dgfStoqNeyZnqbFONP1LlrDf30TY7ksbY7yKVXwAU6n4rKUXAxhdFCf1IB+RpOyHPqH2GbPb596ZVJf9d1QMYFWcLDixexK7tto= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d1dbbf9236ecb5e2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFEoPCioU7bzNWFE7cD+VB14kUd4zNXkj3+3nyfH/Qjx2QZW26HNcCKbnp1q2KmsYM3MZCz/fMthbaOCYF1FgaDj5VVdKdHaNsVjIHP0Qjuof3CpCn55PXLDcqz9HqeXqObhvmKmk6LCMVzQWjfvREJ6E8T+7Gen8U7C02giKfASKKdiiqhO808JS/f2D9258YxHBfPpQDgKK0AzmgWtI7cj4qAhpwQMKk+p1JS+w9VMOuyZ70N/ogIvCi4j8NU4J+p+t2pjEckYa1JxIM3tt9yMjENHJrDt9d2vdTTAM4d9iIqfsAkfYmck5660lkL+JoSF0mDmILxo9oZdgMClYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cvrWNyjbDpTmZnf0vMth/aapfAQuIjJ3bnmuNzS6s7s=; b=CNEHI2ttBmIJW1tnpL11OeO33bdUhSisF4HMJSkaRlmO6UwHfrPCIyAvF0SbPk/bndVDcJLhzGPwcea5U/3JaS2eMjgzBlJliqoOlP6L2XHcrzaBLj/5oosRdwhmUD+/2Zftswe0C3SCB9CKPLW9SX79fGztcIDoc4kIp+Gv/tg6aQpcYdPAY4eT69yRGvcmxqKRbDUollu1IkMCUwyP/FjnE3rUcLpRM+1Dq8PdCJwJeQI5pVHntyNitOB6G8rOX6BMFGhhl0B3WMSRu5xJwjiCFNmm+s+a9Nv65CXs4olajnpWlQrv/7rq3aVA6HN5UyojDVI7aYgnoWEqNDk5ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cvrWNyjbDpTmZnf0vMth/aapfAQuIjJ3bnmuNzS6s7s=; b=ZaHwD+I2aLK/WTynV/c1W/Fr6+0C6NyUyjfbmTxA1ygr4Fv5gyCLxCO6f3YXKlEGtB4MtAW9dgfStoqNeyZnqbFONP1LlrDf30TY7ksbY7yKVXwAU6n4rKUXAxhdFCf1IB+RpOyHPqH2GbPb596ZVJf9d1QMYFWcLDixexK7tto= From: Henry Wang To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S Thread-Topic: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S Thread-Index: AQHZxCqG6oYnCgdHhkmb5cGeqRWv6K/h7S6AgAE7/YA= Date: Thu, 10 Aug 2023 07:03:36 +0000 Message-ID: <5F1FD746-ECC0-4C46-B946-E86E7DB6FAFE@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-4-Henry.Wang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|DB9PR08MB6620:EE_|DBAEUR03FT051:EE_|AS2PR08MB9074:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f55b1cf-2a2f-4772-55fc-08db996ff3bb x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /HGGNC7KbemEG9OUuTo8xhAwFdC3/epSF4SwvCxOePgA9Ad1ozPrx0U/Gjc3ASx74gBQ8ArC0Z2eZqIBAR2XWfWoePQHBUkxP06HGlOvDkXDQVGqqN9OtwZJMMwjGfFaRKXXCV6sYA/11++qunVcvQQNY79JgNoBqZPDEWcNUqEbMIeV52LFp2lsUD5n268rIl2uqH8kEfnfTNPW4D5tBydGUwJE2DRcHfGQ+JTubkVQkabcNMZTlutyGNawhepidi9VxRkzKWt5ILucm+lb5HlC/MDTcTGJ21XrDsf+5JJbhF1M05Kxfa18YkDkxRCHZSFMIBrHFqtFmGON6YDyonaEE07rNW6yWAE56wngdMjv47iw+BOU+MgQvBn/qjdUZTcU13NSmR//KZJKqS3v7OArh4PGz4okmRnoGjY7nGvNkqkTBHrCAMiBWpy0Sa6440LLJH2V2hMd7+luyER/OIEmg/dCg+qt9iswL50Onp88hezuuieUpsI6dIFu6OaaFKOyUdAVD8GHIwjOCeLWJMt2PTzwdSIrphUJKwvCS964gnpmuNP2dTk/WIn+3iRDpm4sewM5y3FIFW/Rr1WfcMcQs2ztqk39DXAUdoi0EpD8LxHggKlvuzWhmUoCjumRXT5X5kGcAOzNmk9GEVeTXQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(1800799006)(186006)(451199021)(83380400001)(478600001)(122000001)(2616005)(66899021)(6512007)(38070700005)(6506007)(53546011)(26005)(66476007)(76116006)(91956017)(66556008)(66946007)(8676002)(66446008)(64756008)(4326008)(2906002)(316002)(6916009)(6486002)(71200400001)(38100700002)(36756003)(54906003)(41300700001)(8936002)(33656002)(86362001)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <5B62A891F5FDFD4084FA4E075B610FB3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6620 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a03bd32a-7512-4b97-fbb8-08db996feb37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kWJDWk6iVH6gpLhoBdCnztCLfcxwRo85ygXMHbumFESrcIEToC08fm8V7LeY0kE3IgvNdXxZpQ1kday7A+ouKLcDwsfiyJ43G48QHsQDZSS3Fipa6u5jyR1dFDHw7ivzdugxlW6Yc0wU/1hbKd1AHUY+MBT1UDq2yuJhbW79Vlh70A/XSLJuZ8Jm63zUxHJi1lM+TQPqalHub/cJHwvulwQkw//keme9KyJqEXs27osuzovDLaY04oJ6AltEHNI/yhOl0nIi4/Z0XEtQbkJs6dQqiNoDKenWuRnuxQTmt3EbfE4Eq67WQwqwQYPj4567jFf6TN1mza/PycAyairEDb1uZW3Cycr8JueqN3VtyEhkCkWagQwDW/ZiorHyDXoswzkGmMQJI6kX3FMvdHV6Uuo5f1CJrv6l4Exy3onOI0Txjv9mV9Sr/9b4V4RifiCZnvBltrpoVAIqWfS9rusryGX/7zYNqtSJjeaG9xnUuQzsWAROdc6wc7GK5qlnVPYk4VlVg1Es0FqS/RCxgj8meEgakEzIQwrX8HBVCGStycXGk7Vp5uOBAx7onZlxx2RhZFEt4zMng2gDXZuSzPGpH9zFwQd4GY5pd733va/iywGrod/7h7+xd5LrXbgHRM2/kzYsHjjl7u3bk6CbeCneWErJGB2sHC7H74UVrpbFZdhnIiQtoKnk2u0L4fXLh8HDXXPpN7F6pVvbxOqUPrau8tQ6tOTKi+oc3ckDAAovZso= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(136003)(346002)(39860400002)(82310400008)(451199021)(1800799006)(186006)(40470700004)(36840700001)(46966006)(86362001)(478600001)(83380400001)(2906002)(66899021)(40480700001)(2616005)(54906003)(40460700003)(36756003)(36860700001)(6862004)(8936002)(82740400003)(6506007)(26005)(53546011)(316002)(8676002)(5660300002)(33656002)(6512007)(41300700001)(81166007)(6486002)(47076005)(4326008)(356005)(70206006)(70586007)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:03:51.2461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f55b1cf-2a2f-4772-55fc-08db996ff3bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9074 SGkgSnVsaWVuLA0KDQo+IE9uIEF1ZyA5LCAyMDIzLCBhdCAyMDoxMiwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBIZW5yeSwNCj4gDQo+IE9uIDAxLzA4LzIw MjMgMDQ6NDQsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+PiBGcm9tOiBXZWkgQ2hlbiA8d2VpLmNoZW5A YXJtLmNvbT4NCj4+IFdlIHdhbnQgdG8gcmV1c2UgaGVhZC5TIGZvciBNUFUgc3lzdGVtcywgYnV0 IHRoZXJlIGFyZSBzb21lDQo+PiBjb2RlIGFyZSBpbXBsZW1lbnRlZCBmb3IgTU1VIHN5c3RlbXMg b25seS4gV2Ugd2lsbCBtb3ZlIHN1Y2gNCj4+IGNvZGUgdG8gYW5vdGhlciBNTVUgc3BlY2lmaWMg ZmlsZS4gQnV0IGJlZm9yZSB0aGF0IHdlIHdpbGwNCj4+IGRvIHNvbWUgaW5kZW50YXRpb25zIGZp eCBpbiB0aGlzIHBhdGNoIHRvIG1ha2UgdGhlbSBiZSBlYXNpZXINCj4+IGZvciByZXZpZXdpbmc6 DQo+PiAxLiBGaXggdGhlIGluZGVudGF0aW9ucyBhbmQgaW5jb3JyZWN0IHN0eWxlIG9mIGNvZGUg Y29tbWVudHMuDQo+PiAyLiBGaXggdGhlIGluZGVudGF0aW9ucyBmb3IgLnRleHQuaGVhZGVyIHNl Y3Rpb24uDQo+PiAzLiBSZW5hbWUgcHV0cygpIHRvIGFzbV9wdXRzKCkgZm9yIGdsb2JhbCBleHBv cnQNCj4+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPj4gU2ln bmVkLW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+PiBTaWduZWQt b2ZmLWJ5OiBIZW5yeSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IA0KPiBXaXRoIG9uZSBy ZW1hcmsgYmVsb3c6DQo+IA0KPiBSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1h em9uLmNvbT4NCg0KVGhhbmtzISBJIGhhdmUgdGFrZW4gdGhpcyB0YWcgd2l0aC4uLg0KDQo+IA0K Pj4gDQo+PiAgLS8qIFByaW50IGVhcmx5IGRlYnVnIG1lc3NhZ2VzLg0KPj4gKy8qDQo+PiArICog UHJpbnQgZWFybHkgZGVidWcgbWVzc2FnZXMuDQo+PiArICogTm90ZTogVGhpcyBmdW5jdGlvbiBp cyBvbmx5IHN1cHBvc2VkIHRvIGJlIGNhbGxlZCBmcm9tIGFzc2VtYmx5Lg0KPiANCj4gSSByZWFs aXplIHRoZSB3b3JkaW5nIGlzIGp1c3QgYSBjb3B5IG9mIHdoYXQgSSB3cm90ZSBlYXJsaWVyIG9u LiBCdXQgSSB3b3VsZCB1c2UgJ211c3QnIGFzIHRoaXMgaXMgYSBzdHJvbmdlciB0aGFuICdpcyBz dXBwb3NlZCB0bycuDQoNCuKApnRoaXMgZml4ZWQgbG9jYWxseS4NCg0KPiANCj4gVGhpcyBjYW4g YmUgZGVhbHQgb24gY29tbWl0IGlmIHRoZXJlIGlzIG5vdGhpbmcgZWxzZSB0byBjaGFuZ2UuDQoN CkVpdGhlciB3YXkgd29ya3MgZm9yIG1lLCBtYXliZSB5b3UgY2FuIGFkZCB0aGlzIHBhdGNoIHRv IHlvdXIgcXVldWUNCmZvciB5b3VyIG5leHQgcm91bmQgb2YgY29tbWl0dGluZy4gSWYgSSBkb27i gJl0IHNlZSB0aGlzIHBhdGNoIGJlaW5nIGNvbW1pdHRlZA0KYnkgdGhlIHRpbWUgd2hlbiBJIHNl bmQgdjUsIEkgd2lsbCBrZWVwIHRoaXMgcGF0Y2ggaW4gdGhlIHY1IHNlcmllcyBhbmQgc2VuZA0K aXQgd2l0aCB5b3VyIFJldmlld2VkLWJ5IHRhZy4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0K PiANCj4gQ2hlZXJzLA0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Aug 10 07:27:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 07:27:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581837.911262 (Exim 4.92) (envelope-from ) id 1qU04c-000758-Og; Thu, 10 Aug 2023 07:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581837.911262; Thu, 10 Aug 2023 07:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU04c-000751-Lo; Thu, 10 Aug 2023 07:27:10 +0000 Received: by outflank-mailman (input) for mailman id 581837; Thu, 10 Aug 2023 07:27:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU04a-00074v-TG for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 07:27:09 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 49f3453a-374f-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 09:26:57 +0200 (CEST) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b9b5ee9c5aso9465701fa.1 for ; Thu, 10 Aug 2023 00:27:06 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id t18-20020a2e9d12000000b002b9fec8961bsm233152lji.123.2023.08.10.00.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 00:27:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49f3453a-374f-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691652426; x=1692257226; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=yN9CEShf+RVQzOCyA7HLL5huGCM+loDBl/b3GyqW7cM=; b=hAI2zLDeYrFyA9B2O1/1J3hre6J5vK9lgwpDrJrzByfWFjSj3ECeAAiyPUFNQLE6lr OqEp6NrSVviNuEkXD49dy0AKhzGZxEM+9TXhkVqWLmv0Oce6NKTxQadC0D9Y6rGJUG4x Mnq3yHe8Sn7pGinLvaV8xRK+dgOCgpVuC3gkbDnV5nf9E1tjFh2OdhdHQDcXju1e6JYF +T0EgaHRZ4qbq2+0o7/3khE5izxby8zFQluqlvRjgj1Qeq/cZrB21i5+EFmXnVOxzEO5 mMHoOYhB20nmxGXn1mnfsJvVIvTd6FbceVpHh4VzwANRpsdfTVFJPvF/DvoUmhk2FyND XFRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691652426; x=1692257226; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yN9CEShf+RVQzOCyA7HLL5huGCM+loDBl/b3GyqW7cM=; b=lld8lPwYJTzDStpXY2KSQp79TEZdqW/ziC5XkphnXRH6Ju/lNf2Ujn41bXs4RlZ3uV A4XbZibHztWg9hR/zfhx95EBBqJpTDY5WuCvk3Ypj5AO9C+ej9OY07ozJgRjvY6HX/ie 5Ct2odEarnNnWibSMTYgn6fBoO/WL4Rhx8rqC9W+BDq/NXeyhebN4Ey7re/XTxbZ5bac FyRnw4b10JTdFxW0WaL4e954TjwcwbX9ICUqZir06DK/tnsyn2mMWgFqe2QtHFqmOKjq KNgVRaiZizXjpsqsKZ4DCdJzZ1zjr0giNBwBI1SnkEHOYqz4XI6yUqoxGQo/C4Ja+70I Sv9g== X-Gm-Message-State: AOJu0YxUrXfTmp0Y4PA+TJ8T2/w27S4LXe0SqVIxcraHfFLwEVZkYSEE HYIT4wJKMTDXLYNTx78xKyUlJQ== X-Google-Smtp-Source: AGHT+IHgd8Hjb+gMYaO0cS0m2RHlxFtCAELWefYhbMJLayBO9cdI/BMW7X3fnqTRhT0IxW6plo9f/A== X-Received: by 2002:a2e:8559:0:b0:2b7:2db:8ea4 with SMTP id u25-20020a2e8559000000b002b702db8ea4mr1165263ljj.30.1691652425875; Thu, 10 Aug 2023 00:27:05 -0700 (PDT) From: Linus Walleij Date: Thu, 10 Aug 2023 09:27:04 +0200 Subject: [PATCH] x86/xen: Make virt_to_pfn() a static inline MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230810-virt-to-phys-x86-xen-v1-1-9e966d333e7a@linaro.org> X-B4-Tracking: v=1; b=H4sIAEiR1GQC/x3MQQqAIBBA0avErBswI9OuEi2sppyNhkYY0d2Tl m/x/wOJIlOCoXog0sWJgy9o6goWZ/1OyGsxSCFboYXGi+OJZ8DD3QmzVpjJYzP3VhnZdlYaKOk RaeP8b8fpfT+XKd7VZgAAAA== To: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Making virt_to_pfn() a static inline taking a strongly typed (const void *) makes the contract of a passing a pointer of that type to the function explicit and exposes any misuse of the macro virt_to_pfn() acting polymorphic and accepting many types such as (void *), (unitptr_t) or (unsigned long) as arguments without warnings. Also fix all offending call sites to pass a (void *) rather than an unsigned long. Since virt_to_mfn() is wrapping virt_to_pfn() this function has become polymorphic as well so the usage need to be fixed up. Signed-off-by: Linus Walleij --- arch/x86/include/asm/xen/page.h | 5 ++++- arch/x86/xen/enlighten_pv.c | 2 +- arch/x86/xen/mmu_pv.c | 12 ++++++------ arch/x86/xen/setup.c | 4 ++-- 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h index fa9ec20783fa..85e63d58c074 100644 --- a/arch/x86/include/asm/xen/page.h +++ b/arch/x86/include/asm/xen/page.h @@ -295,7 +295,10 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT <-> MACHINE conversion */ #define virt_to_machine(v) (phys_to_machine(XPADDR(__pa(v)))) -#define virt_to_pfn(v) (PFN_DOWN(__pa(v))) +static inline unsigned long virt_to_pfn(const void *v) +{ + return PFN_DOWN(__pa(v)); +} #define virt_to_mfn(v) (pfn_to_mfn(virt_to_pfn(v))) #define mfn_to_virt(m) (__va(mfn_to_pfn(m) << PAGE_SHIFT)) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 93b658248d01..7178976c5dcf 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -523,7 +523,7 @@ static void __init xen_load_gdt_boot(const struct desc_ptr *dtr) BUG_ON(size > PAGE_SIZE); BUG_ON(va & ~PAGE_MASK); - pfn = virt_to_pfn(va); + pfn = virt_to_pfn((void *)va); mfn = pfn_to_mfn(pfn); pte = pfn_pte(pfn, PAGE_KERNEL_RO); diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index e0a975165de7..c4f20581f6e7 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2202,13 +2202,13 @@ static void xen_zap_pfn_range(unsigned long vaddr, unsigned int order, mcs = __xen_mc_entry(0); if (in_frames) - in_frames[i] = virt_to_mfn(vaddr); + in_frames[i] = virt_to_mfn((void *)vaddr); MULTI_update_va_mapping(mcs.mc, vaddr, VOID_PTE, 0); - __set_phys_to_machine(virt_to_pfn(vaddr), INVALID_P2M_ENTRY); + __set_phys_to_machine(virt_to_pfn((void *)vaddr), INVALID_P2M_ENTRY); if (out_frames) - out_frames[i] = virt_to_pfn(vaddr); + out_frames[i] = virt_to_pfn((void *)vaddr); } xen_mc_issue(0); } @@ -2250,7 +2250,7 @@ static void xen_remap_exchanged_ptes(unsigned long vaddr, int order, MULTI_update_va_mapping(mcs.mc, vaddr, mfn_pte(mfn, PAGE_KERNEL), flags); - set_phys_to_machine(virt_to_pfn(vaddr), mfn); + set_phys_to_machine(virt_to_pfn((void *)vaddr), mfn); } xen_mc_issue(0); @@ -2327,7 +2327,7 @@ int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, xen_zap_pfn_range(vstart, order, in_frames, NULL); /* 2. Get a new contiguous memory extent. */ - out_frame = virt_to_pfn(vstart); + out_frame = virt_to_pfn((void *)vstart); success = xen_exchange_memory(1UL << order, 0, in_frames, 1, order, &out_frame, address_bits); @@ -2360,7 +2360,7 @@ void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order) spin_lock_irqsave(&xen_reservation_lock, flags); /* 1. Find start MFN of contiguous extent. */ - in_frame = virt_to_mfn(vstart); + in_frame = virt_to_mfn((void *)vstart); /* 2. Zap current PTEs. */ xen_zap_pfn_range(vstart, order, NULL, out_frames); diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 8b5cf7bb1f47..50c998b844fb 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -340,7 +340,7 @@ static void __init xen_do_set_identity_and_remap_chunk( WARN_ON(size == 0); - mfn_save = virt_to_mfn(buf); + mfn_save = virt_to_mfn((void *)buf); for (ident_pfn_iter = start_pfn, remap_pfn_iter = remap_pfn; ident_pfn_iter < ident_end_pfn; @@ -503,7 +503,7 @@ void __init xen_remap_memory(void) unsigned long pfn_s = ~0UL; unsigned long len = 0; - mfn_save = virt_to_mfn(buf); + mfn_save = virt_to_mfn((void *)buf); while (xen_remap_mfn != INVALID_P2M_ENTRY) { /* Map the remap information */ --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230808-virt-to-phys-x86-xen-1b7a69235a29 Best regards, -- Linus Walleij From xen-devel-bounces@lists.xenproject.org Thu Aug 10 07:27:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 07:27:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581838.911272 (Exim 4.92) (envelope-from ) id 1qU04t-0007RI-4r; Thu, 10 Aug 2023 07:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581838.911272; Thu, 10 Aug 2023 07:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU04t-0007R7-23; Thu, 10 Aug 2023 07:27:27 +0000 Received: by outflank-mailman (input) for mailman id 581838; Thu, 10 Aug 2023 07:27:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU04r-0007PN-TE for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 07:27:25 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 591e667e-374f-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 09:27:23 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 9E8544EE073F; Thu, 10 Aug 2023 09:27:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 591e667e-374f-11ee-b283-6b7b168915f2 MIME-Version: 1.0 Date: Thu, 10 Aug 2023 09:27:23 +0200 From: Simone Ballarin To: Jan Beulich Cc: consulting@bugseng.com, Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Paul Durrant , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 0/4] xen: address violations of MISRA C:2012 Rule 7.2 Reply-To: simone.ballarin@bugseng.com In-Reply-To: <8da9b4fe-3109-3a5e-9bc6-15fccc13a8f3@suse.com> References: <8da9b4fe-3109-3a5e-9bc6-15fccc13a8f3@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: simone.ballarin@bugseng.com Organization: BUGSENG Srl Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 11:15, Jan Beulich wrote: > On 09.08.2023 10:58, Simone Ballarin wrote: >> Il giorno mer 26 lug 2023 alle ore 13:04 Simone Ballarin < >> simone.ballarin@bugseng.com> ha scritto: >> >>> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose >>> headline >>> states: >>> "A 'u' or 'U' suffix shall be applied to all integer constants that >>> are >>> represented in an unsigned type". >>> >>> These violations are caused by the missing "u" or "U" suffix in >>> unsigned >>> integer constants, such as: >>> >>> xen/arch/x86/hvm/hypercall.c:132.17-132.26 >>> if ( (eax & 0x80000000) && is_viridian_domain(currd) ) >>> >>> If a rule is not met, changes are needed in order to achieve >>> compliance. >>> The patches in this series achieve compliance for MISRA C:2012 Rule >>> 7.2 by >>> adding the 'U' suffix to integers literals with unsigned type and >>> also to >>> other >>> literals used in the same contexts or near violations, when their >>> positive >>> nature is immediately clear. The latter changes are done for the sake >>> of >>> uniformity. >>> >>> Gianluca Luparini (4): >>> x86/vmx: address violations of MISRA C:2012 Rule 7.2 >>> xen/vpci: address violations of MISRA C:2012 Rule 7.2 >>> x86/viridian: address violations of MISRA C:2012 Rule 7.2 >>> xen/x86: address violations of MISRA C:2012 Rule 7.2 >>> >>> xen/arch/x86/apic.c | 2 +- >>> xen/arch/x86/cpu-policy.c | 18 +- >>> xen/arch/x86/cpu/mcheck/mce-apei.c | 4 +- >>> xen/arch/x86/cpu/vpmu_intel.c | 2 +- >>> xen/arch/x86/cpuid.c | 8 +- >>> xen/arch/x86/efi/efi-boot.h | 6 +- >>> xen/arch/x86/extable.c | 2 +- >>> xen/arch/x86/hvm/hypercall.c | 2 +- >>> xen/arch/x86/hvm/pmtimer.c | 4 +- >>> xen/arch/x86/hvm/stdvga.c | 50 +++--- >>> xen/arch/x86/hvm/viridian/viridian.c | 2 +- >>> xen/arch/x86/hvm/vlapic.c | 6 +- >>> xen/arch/x86/hvm/vmx/vmcs.c | 6 +- >>> xen/arch/x86/hvm/vmx/vvmx.c | 8 +- >>> xen/arch/x86/include/asm/apicdef.h | 2 +- >>> xen/arch/x86/include/asm/config.h | 2 +- >>> xen/arch/x86/include/asm/guest/hyperv-tlfs.h | 28 +-- >>> xen/arch/x86/include/asm/hpet.h | 2 +- >>> xen/arch/x86/include/asm/hvm/trace.h | 4 +- >>> xen/arch/x86/include/asm/hvm/vioapic.h | 2 +- >>> xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 84 ++++----- >>> xen/arch/x86/include/asm/hvm/vmx/vmx.h | 16 +- >>> xen/arch/x86/include/asm/msi.h | 2 +- >>> xen/arch/x86/include/asm/msr-index.h | 180 >>> +++++++++---------- >>> xen/arch/x86/include/asm/pci.h | 8 +- >>> xen/arch/x86/include/asm/x86-defns.h | 24 +-- >>> xen/arch/x86/percpu.c | 2 +- >>> xen/arch/x86/psr.c | 2 +- >>> xen/arch/x86/spec_ctrl.c | 8 +- >>> xen/arch/x86/x86_64/pci.c | 2 +- >>> xen/arch/x86/x86_emulate/x86_emulate.h | 2 +- >>> xen/drivers/vpci/msi.c | 2 +- >>> xen/drivers/vpci/msix.c | 2 +- >>> xen/drivers/vpci/vpci.c | 6 +- >>> xen/lib/x86/cpuid.c | 8 +- >>> xen/lib/x86/policy.c | 2 +- >>> 36 files changed, 255 insertions(+), 255 deletions(-) >>> >>> -- >>> 2.34.1 >>> >>> >> Hi all, >> the entire series has not received yet any feedback or Acked-by. >> I would kindly ask if it is possible to have at least some feedback > > I did reply to patch 4 on July 27th. For patch 2, Roger is on PTO for > another week and a half. > > Jan Thanks for the information. -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 10 07:29:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 07:29:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581848.911281 (Exim 4.92) (envelope-from ) id 1qU078-0008GK-ID; Thu, 10 Aug 2023 07:29:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581848.911281; Thu, 10 Aug 2023 07:29:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU078-0008GD-Ej; Thu, 10 Aug 2023 07:29:46 +0000 Received: by outflank-mailman (input) for mailman id 581848; Thu, 10 Aug 2023 07:29:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU077-0008G7-J4 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 07:29:45 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20606.outbound.protection.outlook.com [2a01:111:f400:fe5a::606]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a6768c51-374f-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 09:29:34 +0200 (CEST) Received: from PH8PR21CA0006.namprd21.prod.outlook.com (2603:10b6:510:2ce::18) by MN2PR12MB4471.namprd12.prod.outlook.com (2603:10b6:208:26f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 07:29:37 +0000 Received: from SA2PEPF000015C6.namprd03.prod.outlook.com (2603:10b6:510:2ce:cafe::f1) by PH8PR21CA0006.outlook.office365.com (2603:10b6:510:2ce::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.7 via Frontend Transport; Thu, 10 Aug 2023 07:29:37 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SA2PEPF000015C6.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 07:29:37 +0000 Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 02:29:36 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 00:29:36 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 02:29:35 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6768c51-374f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eDx50zOLApOqVCAJ/6RjYEN3Zq0BPun7ka51p9A7I6sGL/2igxxSuUK570MGb3mzRWobrJY9pcFvBJd1XGvlRILZsmZX3Grm8eWYx8hk3FGckeAi2o0KUyf/Kn0NxCj8FoHJKDEQu0hzc8DQWnYNWAovLNtKN5NMjFnICuyfBDSwVJZFcWcys7iHd1z/JDq/7jeIvDzz70C5T+5vAs/6pkGWrnUv8FIay3mTrK/HgqkqZYavIQhxQXrOeoHrwFgWkadiN3whLS7pdW6Njg9aZ+VRcealXGON/4tL6AjYl1+1JpGHuNZtZMaYqVcF8cOyHGDO023GAHoFTDgUo3axpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W45RutX8vcvxy5yxc9uJy4ve8MDtYjJCydP9pLv3qRw=; b=DEol5moB+F0SW6tin6tQFDEFM6Xmfst5LeX75GWWWqedNZ9806sQrCX6y2m7Y5C+A6Wq7Y+/jV6ht3kT5GDbaYK1S9uAwGDW7MgclNEn//R/lZSx4KviBRzDSkbNRITUqTRPyXL8XEVOls124Y3cREsT3355dwebH3MtFFbiElXoh0FSxBUfZMI500rYizV2gIjx96AEWm8we/ykbRU9a2ieEOKvirzNlGSVDjx3QrxMyuE3FE8LyvfKFzu5/eYSZCqUxRfuO7DmR0EL8gUAzCcCv3Z2uQIVxYAeIyHH/c+iFo6gWIfwRnT8T/+CoWWaJ+QCWo1D4HqSesLk3U4Ptw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W45RutX8vcvxy5yxc9uJy4ve8MDtYjJCydP9pLv3qRw=; b=t7OhO7b23TwcXqtz0UquoQadvNukJnTJORRUkThCN4ZEdFX+b4RkzeVx0gkGZEnmf1egYgEcP2vd0Du6S+MyPKq9N94gBDF+KRbtWc+UTG3k3G6sUlWAX382RGWhr6F1bXn6MZgpFj30O5srGv4/EZzrDn4axsxwVg/NtLXhAPY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 10 Aug 2023 09:29:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/2] automation: upgrade Alpine build and test artifact containers to 3.18 Content-Language: en-US To: Stefano Stabellini CC: , , Stefano Stabellini References: <20230810011803.311832-1-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20230810011803.311832-1-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C6:EE_|MN2PR12MB4471:EE_ X-MS-Office365-Filtering-Correlation-Id: 2dde544a-fabe-442e-34dc-08db99738d40 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f3XyznELnu4e1zqNKUBXVHCF2zwAAyElk5mqoaaQ7AXkf4gta0hPi+q1UMnC4Y6+qsc0PpA8CH22OsmC6g9LfUHyOzI+LC9jL3bGx/eebZB7viC0HnAbbE2/UCy1fZbJ8gJfZkt5kd9gOvJdibPxMCHztLFvqdOwRkjDLkX5VGC4Grn+AOPhZxPTkF1zTzAEtN7AvO1K52koYJ4RSY/SXJHXR5YGpXQC4B0eXpoTp/J1RX2I4lEjIC+RzojKXq71aPZAq53Q2Xq/EciHPaBPldaqc701IEeq295UuRC0qx5E3C/STqwU+49LeVSESV0rhSbe0eu4/SBcX4I8UdztKttjzib9jukijkA/n4pz+tDSgSm6UkO0p+i4bLKCZ3+a/s8yfTebHw+Ys5HTFn3XchrAwPyNt39GppXQcdFgAaFHpBqt0tvObpEznHjB+1a2SX2C44S0KHflL6uHyrWBeL4rm8Cczj0QEgbyMbin3/a7BgJ2Yfhc6DoiMpzmNhqG3nMNByigYERjZQNl1saVz18OmpA6a76k/lvF6nQYPUkyMoWnv9wCuWCVrJe7/jzskl/4UCTZ51/qhr6A9pN1iUzki844HaHbbRre/Iqjs9PKE3cDNpH2TPB3OPbvUDnSVdZUtJjyzHILshot1xO2NTliS37ODSMo87xZoIjE16V7vMrH786dxecwDWrYeQBbtBFBJJDiGCy9Uuac+8F2JCJlBz3/Y9rJ4kSPG8aTDgjinqW0lcUYTWq+dZIVavhv48R2tgDbcoAgvN+G/WDEMDFnY2l1a556cXKxJowlSPUorSwymzTMe6xyhU4iUIVM X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(136003)(396003)(39860400002)(186006)(1800799006)(451199021)(82310400008)(46966006)(36840700001)(40470700004)(6666004)(5660300002)(82740400003)(26005)(44832011)(8936002)(8676002)(41300700001)(36860700001)(53546011)(316002)(36756003)(16576012)(6916009)(4326008)(70206006)(47076005)(4744005)(70586007)(31686004)(356005)(83380400001)(81166007)(2906002)(336012)(426003)(40460700003)(86362001)(478600001)(54906003)(40480700001)(2616005)(31696002)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:29:37.2047 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2dde544a-fabe-442e-34dc-08db99738d40 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4471 Hi Stefano, On 10/08/2023 03:18, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > Alpine 3.12 is EOL. Also update the containerize script. > > Signed-off-by: Stefano Stabellini You could mention the python upgrade in alpine test artifacts. Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 10 07:30:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 07:30:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581854.911291 (Exim 4.92) (envelope-from ) id 1qU08E-0001FJ-Rk; Thu, 10 Aug 2023 07:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581854.911291; Thu, 10 Aug 2023 07:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU08E-0001FC-Or; Thu, 10 Aug 2023 07:30:54 +0000 Received: by outflank-mailman (input) for mailman id 581854; Thu, 10 Aug 2023 07:30:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU08D-0001Aj-07 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 07:30:53 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20615.outbound.protection.outlook.com [2a01:111:f400:fe5b::615]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf5670fb-374f-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 09:30:42 +0200 (CEST) Received: from SN7PR18CA0020.namprd18.prod.outlook.com (2603:10b6:806:f3::14) by SJ2PR12MB8010.namprd12.prod.outlook.com (2603:10b6:a03:4c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 07:30:47 +0000 Received: from SA2PEPF000015C9.namprd03.prod.outlook.com (2603:10b6:806:f3:cafe::a2) by SN7PR18CA0020.outlook.office365.com (2603:10b6:806:f3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 07:30:47 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by SA2PEPF000015C9.mail.protection.outlook.com (10.167.241.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Thu, 10 Aug 2023 07:30:46 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 02:30:46 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 00:30:46 -0700 Received: from [10.71.193.39] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 02:30:45 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf5670fb-374f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BOHTWgukssOZKdxLsafHt7a5lEl7wn7YY+x1l8LiLK9SueIEstizDItriHSmRWjAhQeTKtytU1QTG85d2vGy3SR2DD3JF1uVQBjTpdyw8imj95cbkQm9HmWxdf3HKnf8XK5IIrp8qpIsk2hG17UQ8gzG8nV+c4qFO+bGWjTB6PoQ53ko445pmFfsxKK9pHnQt0R1cA3IDCF9MR26/emxkgmY/ugygGrFKrjTLzTXBCuies/NL6xN6b0J4YPZ/2NVkLjdFm9+mZY4bkanS4BRjx2PI6POxt1AFbYGxy0Nw1zfnKm6cQraz48I8sBLsdX/18UdP2E7Qcq4+j+AqiZeTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z3lETHjnRGaV00jG7rG2wl59M1yScl/L+majtfkjCbg=; b=nASe7Y/rES46kTQTOQ2zSfK0gnvVpbo4LORzLuK+wJUbcEaQ/G5DUJJckL8hbxF+5x2R5ODMoZpClJ+JLorWduNFakQw6L3zFz7ho8+8y6wvJojq+pwdEjIaA7NvBsKHrrypZDk3IYSaBIDMPgtt5Nb9ir2u/ESdOfp08DqOzxpUy9Iy0zVUI8SLk5jUlInVMNmtnwztlsaSL73DrKx3B/uIS7f7etMDLqDj62FlQ+LDlbkIG+nfwaZc/IzC1Uva65gJ1ovamyZhDsIP99kTdKrMXidgQ4Ank7lTY7SsODi5aBVezVCjw4VJJiZhugs2zOrczodlC14+wWMEb0PMhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z3lETHjnRGaV00jG7rG2wl59M1yScl/L+majtfkjCbg=; b=yhy9m6wxt4pGUBM7vnEjXzNsr/3IhzS5l894mSg/wV2V5GFgCkbeJZVzWFva4bDt0O0SUi5awMHGm0sCUxFAcNLQ6kCh+T6iMv7rP84ZKYjNfIMKgCZBnKQXxLrhEJ6IoXFvJEgZBttQcYxlMOoOIhTywlp/1FeVaWoGEp3bPec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Message-ID: Date: Thu, 10 Aug 2023 09:30:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/2] automation: use Alpine 3.18 instead of 3.12 for all gitlab jobs Content-Language: en-US To: Stefano Stabellini CC: , , Stefano Stabellini References: <20230810011803.311832-2-sstabellini@kernel.org> From: Michal Orzel In-Reply-To: <20230810011803.311832-2-sstabellini@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015C9:EE_|SJ2PR12MB8010:EE_ X-MS-Office365-Filtering-Correlation-Id: 92788469-3f10-4e0e-4a7a-08db9973b6d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eM6fh/v7KsOdUyZj4yJsJ05yWhNtQNVNsehdPHmop/G0E+nOE8WgYHr2bsm0/oCEcYgGb8bJvWonj8Hu1ruL+MUVZBAxZIWEhgtyI7H+cR1nMEJ/tlxSq/XnCnL0e3o1lTOZ7VRN1TYITiJ8VEzcmDKS9yWft84U7JWDUC8hPavRajsicgWQ2sedYKlXN+R3wirn1s21LSZShpkyk7YATaDE7AFb8RTxrp/Pl6S0YwFjl95h9j947SsRcfL0GMvAC7LAL6Az6ggYuIjFsSplqdiUyprUADh8TFTYhiKtolMku2sIVOUDHKBJnBKoiFLWTvgSouvBLpoBwdyusUDQ+UMXRonGYpFUHDjhhT9DHwfTBfje0YrHEPzu5jgK3md4a3z19TUjEcvDcGVc0vED5OKvqeCPaxUE0JD+qSTYjp84nSesg2krbgBKtvHPtOvfL2VqPRMR4tffWpVywWANuEjnc5X58C4wgToMDMXJRT/8XVnMuMfIX0z6QgZl7/23/q59tKfjSiBKkeDfrt0eMTchpVcgAcI+SCxvhMrcVrZzcephrvwvf5O6ePbTshmJwfJiKVTsiV/9zeG9EoxWzJV3FuA7EWWhVUqpY/YKSnU00UfkScALRzTtxBL/5tytknQao1jyJ3dLTzbtOUDns9eZU+IP/w70kEEEPVSaPBpzP0LPQNJOARzD0ftzd8sjtcVbM6WffodIHP4/U0deb2Xq8woZJ03iHoqErs99COCd/aYqAkET/223xtPZg0VLLnsUn5jhNJhY3KLzGv/nLam9/ximTXp0nTbfCfUUogBIYWSK341tcw3I3b7My+Ph X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(82310400008)(1800799006)(451199021)(186006)(46966006)(36840700001)(40470700004)(2616005)(478600001)(558084003)(44832011)(31696002)(426003)(86362001)(40480700001)(6666004)(2906002)(36756003)(336012)(40460700003)(26005)(53546011)(356005)(54906003)(316002)(81166007)(70206006)(70586007)(31686004)(6916009)(4326008)(41300700001)(47076005)(5660300002)(8936002)(8676002)(16576012)(36860700001)(82740400003)(36900700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:30:46.9824 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92788469-3f10-4e0e-4a7a-08db9973b6d0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015C9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8010 Hi Stefano, On 10/08/2023 03:18, Stefano Stabellini wrote: > > > From: Stefano Stabellini > > Signed-off-by: Stefano Stabellini Reviewed-by: Michal Orzel ~Michal From xen-devel-bounces@lists.xenproject.org Thu Aug 10 07:42:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 07:42:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581862.911302 (Exim 4.92) (envelope-from ) id 1qU0It-0002ma-Vw; Thu, 10 Aug 2023 07:41:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581862.911302; Thu, 10 Aug 2023 07:41:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0It-0002mT-T3; Thu, 10 Aug 2023 07:41:55 +0000 Received: by outflank-mailman (input) for mailman id 581862; Thu, 10 Aug 2023 07:41:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0Iq-0002mN-RZ for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 07:41:52 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062c.outbound.protection.outlook.com [2a01:111:f400:7d00::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5db7ab9f-3751-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 09:41:50 +0200 (CEST) Received: from DB3PR08CA0032.eurprd08.prod.outlook.com (2603:10a6:8::45) by DB9PR08MB9755.eurprd08.prod.outlook.com (2603:10a6:10:460::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 07:41:46 +0000 Received: from DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:0:cafe::35) by DB3PR08CA0032.outlook.office365.com (2603:10a6:8::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 07:41:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT043.mail.protection.outlook.com (100.127.143.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 07:41:45 +0000 Received: ("Tessian outbound e1fdbe8a48d3:v145"); Thu, 10 Aug 2023 07:41:45 +0000 Received: from e508edc3f625.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7030C5B4-3F85-4FDD-A2D2-D617AF6ABE89.1; Thu, 10 Aug 2023 07:41:39 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e508edc3f625.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 07:41:39 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM8PR08MB6354.eurprd08.prod.outlook.com (2603:10a6:20b:367::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 07:41:37 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 07:41:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5db7ab9f-3751-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSmEdoGbXnWJoTpB5+MVGMuOF+COnyl27ANio2UNZn0=; b=y9lBCE2oEE/AMdp/axTcVIMjcroY9MG8OsyzJ/ooATxa6vBsVp0YokE3DTzsk5IVYbOuhdbKuf5ZJAYR0wMZeFqViIShlaaVkYA5so4R+9Zq9jQNwrYztHZlG/ywzpUavb9UDSMh1nQbKg8tTx6H1qo2zqV5ZVAbKVNmWc//v/c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e61c7618f1ce189a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVWib2Zwdwu/3jC8EzdAw4b5Jdg+kE94A3w0VIPeS2P1x0pFmuUHKzKfHDCx5C8hM8xVB4qj7aqYCaXA6zLqsDGhKi37cZTyPiqKXhbDq0U35t/MeoiMklgRpEsIl1/Hsvn5PVZNBmwxrYoF2kSMjQLeLqpnuPoZmt6oVOXT+NF7ZEU7RAD4EzBKqCQ7tlnXrzwGOShWm+vQU2CDC1IzCsqc1x85TssM/E+rkOpTiiWtOtuhKTiQKyf1a58y/AymvM0vLOLUHxWJx1pPt9Iei1+WHQDB7yiy2BlyV0yqA3cl8l04iQ2ZoDxiKFFp5Hp07JhJ/MX03V7UbYF0aHZh1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HSmEdoGbXnWJoTpB5+MVGMuOF+COnyl27ANio2UNZn0=; b=isEH6kaHxp4fywSBXuONQufM7E5dibgbkylAaldMNx/s6sVDB5e8VJnXTGmqX+t5stJoggkm4tEQbb3hW90j/Kgn9iEhMFqln+1IORneaPw7pkG2DGOAWoRKekbjND6vTQJncVbpUgAeyKEFJb9+GXAiL0phdVUO3rwwo76XcWgFhy1yTSRXD1/3ZhAPNQUicdMbTN8sYTCCRHJnPfP0iBLRNKqbJzXxhARiBY341nMZW8xV66fsYT0MIF7SSKUS002BS2x2JiKJHhQFdaKWRYQJLMVXMyl8yoEvskcybjVsCQvvpnyIj7mhR4T1huYczmA9TEHrFlK0CvNHC+l/Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSmEdoGbXnWJoTpB5+MVGMuOF+COnyl27ANio2UNZn0=; b=y9lBCE2oEE/AMdp/axTcVIMjcroY9MG8OsyzJ/ooATxa6vBsVp0YokE3DTzsk5IVYbOuhdbKuf5ZJAYR0wMZeFqViIShlaaVkYA5so4R+9Zq9jQNwrYztHZlG/ywzpUavb9UDSMh1nQbKg8tTx6H1qo2zqV5ZVAbKVNmWc//v/c= From: Henry Wang To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: Re: [PATCH v4 05/13] xen/arm: Move MMU related definitions from config.h to mmu/layout.h Thread-Topic: [PATCH v4 05/13] xen/arm: Move MMU related definitions from config.h to mmu/layout.h Thread-Index: AQHZxCqMQIVv2nNAnUKuY4URBAgkmK/h7woAgAFEwoA= Date: Thu, 10 Aug 2023 07:41:36 +0000 Message-ID: <228AEB4A-273E-404B-94E2-932FD8BD54B5@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-6-Henry.Wang@arm.com> <83022ef2-dfd1-438c-b8e8-2f1bf0866918@xen.org> In-Reply-To: <83022ef2-dfd1-438c-b8e8-2f1bf0866918@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AM8PR08MB6354:EE_|DBAEUR03FT043:EE_|DB9PR08MB9755:EE_ X-MS-Office365-Filtering-Correlation-Id: bfa319ed-bca4-442c-0202-08db99753f94 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HdNuQ5r/ZoDEFmCqgsQ1qjLEs+6m4279TEAxFPBaTdFXZW7fga7VVYioW/UhEPETZtI0oqjbzepFAWEAE/5ycswgDlPd827z520FVryEuYpCR+i1CpSXAx9GvmJ6fU/m3opyaK7Bf8+Ie0fzPT7jsXWBavE0mi4cELVHqPJoy8Iu4pWK+SCJLbNsgDkB0Yylz0NoOZbfjUFUYSaPSEsYUCtGkQasC6tOFxbbmwSz3Mx/oyJgZjorv2gAMRBag6GvNyEfAKNXr2sVRpJvfX8awgB+CXhr+q+sJBHaN01hizp8boh6G7Wk/EPMKAa8zwlFWz0mrR+9EbAaFpWzrdLAOZ0f/xZrogk4dy5n1yv9QEKoqQN/ROFSsCgLS6IWmoQthIetVDOcagS+dod803OcctEF/KE7yJgWzEl9nmdKNhrjJ1L3uZPBuSSeaMneDLzjE00ayfIXpSnWHVQRXgBvMeBdzI4VC4TiByDoRnzJf3GWEI/jYEcZie0Sr1ZwwZNIjULepPLhI7/8KP+9g5A0E3WSwHlHRXCkIb+lNuBGYweiuFG+LKLT8VUKv/wuW7ObdsICzJOxa7Ov9kBVRRLg2L0a91TNSxk467FHtCJeSEJ6aYLmc5pJ5Ax5WyD9GivlskxshNfCFBlf1Q4t6+vwkQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(366004)(396003)(136003)(186006)(1800799006)(451199021)(4326008)(6486002)(86362001)(478600001)(36756003)(83380400001)(33656002)(54906003)(38100700002)(2906002)(76116006)(91956017)(66946007)(6916009)(66556008)(66476007)(2616005)(64756008)(66446008)(6512007)(122000001)(26005)(41300700001)(316002)(6506007)(53546011)(5660300002)(71200400001)(8676002)(38070700005)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <443661EA238D3E46B75F33B89EC8DB98@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6354 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b493baf8-7055-41a5-af60-08db99753a22 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GuNHlRx3lFkeKX25/tR6sTPW6IwU/bjIna0OgxEVrBbkfv+UI3BJIAfyv1GEa/3yS12oRNLCxbolDTce4Q29PakXxX9p1SuCmCdkcpOFkO5xhJpZ+3ZaRNcME652OMUviXuc4zvaz1ObT5biIvLQMSsHIp+letggmHXlwgbUWlA6bSr/YoatS/O4Yykd1R08uzTxDiMPe4tDSeLekFI7/lXDzkxQzOCOFoltWx9UsGi5eVT+sy80GNsrlhnBYwTqoEBtYkOCboM7N6A4ytWWkHYqHUqEGZfRCCCbysSB4iZ2YlB/UBz6t92cRuUBaDtLTg+lWRHLMoiSo0u7rdQiLcxSezNc1bKHPFWkbBU1rvlp9qHIUpdAWrd2sJJW/iQ3KnKccwei+7hINctTNwSLYELQGYgrzpMjnDADXxmZy5KU4dM8WKEpw/wdVxeSkk+N6FoeTHk6lYRA3e3sJV7dL3x1DkWex0MOYib9jqrMtPUsCJgWh71A1D7SGlb59ONxBxHhZPm68hs10sUFBerJIJOzpjmpGmgcj3v77sQQwONqEbEvmEyobEfX6HTgiwhFZlnrMKQAZzQ1vFhSO+TEV7pt/0smVBjFwBY5EQfYnORsXCj8RS1CPTCbqtVg7FD953skvAjF5qIec2dT950xV68pzBJCFllFtDKsbRebkQuZzoBJt7xr4MfPVRTfeYk//tGUxCkxEbmP3YgoDU1Eaw0FKQ35eSM2bLRntHqbbRWSdLtflde1ugaNiytY0Qxq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(39860400002)(186006)(82310400008)(1800799006)(451199021)(40470700004)(46966006)(36840700001)(53546011)(6506007)(40460700003)(26005)(82740400003)(83380400001)(2906002)(36756003)(336012)(356005)(81166007)(40480700001)(54906003)(2616005)(36860700001)(6486002)(5660300002)(316002)(6512007)(478600001)(33656002)(6862004)(41300700001)(8676002)(8936002)(86362001)(4326008)(70586007)(70206006)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 07:41:45.9788 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bfa319ed-bca4-442c-0202-08db99753f94 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9755 SGkgSnVsaWVuLA0KDQo+IE9uIEF1ZyA5LCAyMDIzLCBhdCAyMDoxOSwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBIZW5yeSwNCj4gDQo+IE9uIDAxLzA4LzIw MjMgMDQ6NDQsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+PiBGcm9tOiBXZWkgQ2hlbiA8d2VpLmNoZW5A YXJtLmNvbT4NCj4+IFhlbiBkZWZpbmVzIHNvbWUgZ2xvYmFsIGNvbmZpZ3VyYXRpb24gbWFjcm9z IGZvciBBcm0gaW4gY29uZmlnLmguDQo+PiBIb3dldmVyIHRoZXJlIGFyZSBzb21lIGFkZHJlc3Mg bGF5b3V0IHJlbGF0ZWQgZGVmaW5pdGlvbnMgdGhhdCBhcmUNCj4+IGRlZmluZWQgZm9yIE1NVSBz eXN0ZW1zIG9ubHksIGFuZCB0aGVzZSBkZWZpbml0aW9ucyBjb3VsZCBub3QgYmUNCj4+IHVzZWQg YnkgTVBVIHN5c3RlbXMuIEFkZGluZyBpZmRlZnMgd2l0aCBDT05GSUdfSEFTX01QVSB0byBnYXRl IHRoZXNlDQo+IA0KPiBZb3UgaGF2ZW4ndCB5ZXQgaW50cm9kdWNlZCBIQVNfTVBVLiBTbyBJIHdv dWxkIHN1Z2dlc3QgdG8gd3JpdGU6ICdBZGRpbmcgaWZkZWZzIHRvIGRpZmZlcmVudGlhdGUgdGhl IE1QVSBmcm9tIE1NVSBsYXlvdXQgd2lsbCByZXN1bHQgaW4gYSAuLi4nLg0KPiANCj4+IGRlZmlu aXRpb25zIHdpbGwgcmVzdWx0IGluIGEgbWVzc3kgYW5kIGhhcmQtdG8tcmVhZC9tYWludGFpbiBj b2RlLg0KPj4gU28gbW92ZSBNTVUgcmVsYXRlZCBkZWZpbml0aW9ucyB0byBhIG5ldyBmaWxlLCBp LmUuIG1tdS9sYXlvdXQuaCB0bw0KPj4gYXZvaWQgc3ByZWFkaW5nICIjaWZkZWYiIGV2ZXJ5d2hl cmUuDQo+IA0KPiBBRkFJQ1QsIHlvdSBhcmUgbW92aW5nIGFsbCBtZW1vcnkgbGF5b3V0IGRlZmlu aXRpb24gaW4gYSBzZXBhcmF0ZSBmaWxlLiBTbyBJIHdvdWxkIHNheSBpdCBleHBsaWNpdGVseSBy YXRoZXIgdGhhbiB1c2luZyAiTU1VIHJlbGF0ZWQgZGVmaW5pdGlvbnMiLg0KPiANCj4+IFNpZ25l ZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPj4gU2lnbmVkLW9mZi1ieTog UGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBIZW5y eSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+IA0KPiBXaXRoIHRoZSBjb21tZW50cyBhZGRy ZXNzZWQ6DQo+IA0KPiBSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4NCg0KVGhhbmtzLCBJ4oCZdmUgdGFrZW4gdGhpcyB0YWcgd2l0aCBhYm92ZSB0d28gY29tbWVu dHMgZml4ZWQuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IENoZWVycywNCj4gDQo+ IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:04:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581873.911311 (Exim 4.92) (envelope-from ) id 1qU0eP-0005tt-Bu; Thu, 10 Aug 2023 08:04:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581873.911311; Thu, 10 Aug 2023 08:04:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0eP-0005tm-93; Thu, 10 Aug 2023 08:04:09 +0000 Received: by outflank-mailman (input) for mailman id 581873; Thu, 10 Aug 2023 08:04:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0eO-0005td-5Q for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:04:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0621.outbound.protection.outlook.com [2a01:111:f400:fe0e::621]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 798c9ffe-3754-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:04:05 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PA4PR04MB7646.eurprd04.prod.outlook.com (2603:10a6:102:f3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:04:03 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 08:04:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 798c9ffe-3754-11ee-b283-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxFjPyZQG+9NrIFwpo5Y16j5VZO9FGA1CvdpfUhi6NkRhsE+1PEiDRTSBf5BaqGNcZET9Yaf0Z7cE5WMMWxb5BglwbuZgCjo4FT6yTMm5OhgU153peB2YXAm81U7SMKmvFa98bv2J/URn4X3Bl2HvIWA5xfbwv6o80v3vIdTIiKFepSjjZa1Fu2teEyQWLyTm78yXGk+/ylhiU7HH+ZPh5ANlit07OwOHk7U5+OEVXAyOimNqBN6NizoAr2U9Llu1Z5WWV0CvKQ5phX03KdjesQkZTfwfvhdIsNdpEOjTzBzlq11QL1v3h+ha+twphcMp1J0Y6+1Dv1Op+HBiMbC+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PUc532/w6szC+JEuVUjiEnOWawjebcTbX3zIHF8+2PE=; b=R9SnGjegpLubivQjrK6VAewWlveoE2tbSRMkUeMYjgR+ObTgpciVBwDmg1fvwLskFVnpGATZD1tB3gnXmi9f2gR1pAe3Y8SluHBkz4fFMCm/f+ge5CZqFVGSTHgbgtHOMAt645rj1r3xNiMLbitOk5TzDdycAIi/gUJPks7ueSgrZ5gkWo19V7wZBytNzlZLwjRII4dxKj5dYhPbYw6/G9chS+j08lR5JUpyGgdvRH1d0MPPoK+eXy5JAB/4K4ym1JL1N82QBJgGWjKnrkDgrVoeRra1KnEAPqTO10IjWyWbKNxJFPaCxZaBZOb3VY3gAym9vZdSAr1XWMc0pbkvSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUc532/w6szC+JEuVUjiEnOWawjebcTbX3zIHF8+2PE=; b=lqzmF2e6HYMKqUKOPZyJBDH0Shjupmor56Rm6r4SaFsGYIY4tDSo6w2GvAlvg4EYCw69LG1LxlelFprWlKryuJf+RooGUV+BjGK43KvQ5rXjbtuWm2BiZYQ7q/xkYqUNxPo9bItjmaqI3qSNy7sWtgbIMgv5ynaxWDzXjQhnk8GXzHJ4eRnAfR+2kR2H3rFlh0+kyE6qSp9SbFj2p58/jZxwcc7eVN6pDENo1xBmHX6ySZg4U7JV4sMO6mZS5A+oOwslzV5qAFnIFhUJVwxCiKE8g0AQkjlHjQk0M6Bx+BHYbzzrwXNITxpoUnjM6G583/04XIYXv2tRmXASU7H0uQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 10:04:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 5/9] xen/ppc: Define minimal stub headers required for full build Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <9cd545a4a9ef55d06ea0b81044e22f64ee42823e.1691016993.git.sanastasio@raptorengineering.com> <21365276-8338-12b9-b3b8-2a222e7eceef@raptorengineering.com> From: Jan Beulich In-Reply-To: <21365276-8338-12b9-b3b8-2a222e7eceef@raptorengineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::28) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PA4PR04MB7646:EE_ X-MS-Office365-Filtering-Correlation-Id: 39327daf-dc5a-44af-9397-08db99785c83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uWUKMIrAGJycmAnnllomA0uLfqRtvV8DgSLMnGsY14AD4jI1tJGmP9R8Jhh0rhREksyC3GDO0bS4q3qrLFNtuh+a+hNS9u0lWjyOlxkkW15HQVzZXqm8mhmGDYhJn+UaGYx2ML9FOZwBI5O+ba6UfQ0Nlf8IRQamfUp7kLt+KLgDTWroTqxqd22pQq03qDDqzeOY157Sd96veE3cJPajXmwXZkIh1g/EOK7HQJuTwUysarKqa9cnRLA6Pb9T4+ekjLzdulpzcQOP5AgKbcLoOeaQP6eV9VlTjsIckUiNjuibjkmFwB3KkNPs283VY0Uf55xoHvDNxiGemgQu8Gltm4Fs7GZQiu6WVi9ImHQ7Mpc83jeJoHs5y/THxBpjqDLDL0VXm2IaCG4pdegBZ8wgz51kyZk/s5651vcmblMjV2UdRnM2C/s92ECrzJzyqhtH3VIe9tt1sOXO4sEDQ7Ww7sfKoZ063RM54HoCKre18DKIpfkkKqQxv8075BzD3Uxh1FTYq88ECmF2jsOfo46axMRRUNqoYd8rqxCmsCZP8uUTcjoXPY3tXkUzbOulVuXgW8Weq0xjKp3i9QRmTmgNiV3PKL3kERerWq8cCm7SkENIYv+ClnrdzbTbfueH4SoMOy47AoR0epNN165Ncfn9+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199021)(186006)(1800799006)(31686004)(66899021)(86362001)(2616005)(36756003)(2906002)(66556008)(8936002)(5660300002)(8676002)(478600001)(54906003)(31696002)(6506007)(26005)(6486002)(66476007)(66946007)(6512007)(4326008)(41300700001)(316002)(6916009)(38100700002)(53546011)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXNEVEtTTzBlbGVOUlIvMDJvYjhBY1pTL3dQc1hOcGsza3g0bXZpS0l2a0U3?= =?utf-8?B?aDlYYXplRTNnanlCa3E3M0JlQWxWR2lEajdncHN2a0hWOHNRK09maEs1Z2Zx?= =?utf-8?B?NENYSkVsL0Jibnp5Y1o0b2swRGRKcVdMSTEreDVPTlVEVWdTYTVGekYvVnZs?= =?utf-8?B?elFuL3hLZ1MvbVl4NUxWWjRRcStEZFBkSks3NnpiblYvYkMrMndhWGQzR2tF?= =?utf-8?B?MkJ4OUhZSmFPQ2MyYXV3OVNQMFFGMXIvM3d5TEVUU29XeHhsZWZRZFYrU25q?= =?utf-8?B?YnNDWFVCOUcvanpKSjFlR1FYOVVBUFJrUmhUblhDeE5EUXJ3MldIelpaZExo?= =?utf-8?B?L0ZIbzZsc1hmNTZhQzZQUGt0Mi9JTWt6NHJ3dEl2aThCbVRSdUxIdEphU2JH?= =?utf-8?B?ZnRJZlpuZEltM3QxWGxIbEFBN3JSeTRJM3VsejlPN3U4cy9IZ0JoTnpaL2h0?= =?utf-8?B?Q3RJbVhIYm1BQ2tOeTB1VzlwZEJ4MEVwRGhKN2RNRnB2WXU3RUVwaHF3dVhC?= =?utf-8?B?NHN6ZkFvaUJDYm9NZkhFV1M5R0oxL0pxamx6cDlzUFNEZndTUzR0MnNqaVZv?= =?utf-8?B?OWxRbjNuSUZyZExkRktJUEVERkFGQVVmblEyZHAwdU00cUpoVEs5VWJCVlVI?= =?utf-8?B?dTk5eHF3WXpWNEN1dzJieGZkY0R5RkwyYXBOdHdwOVZZWVhYd0QxaEwyb0dN?= =?utf-8?B?c3ZiUFdadEtEaHZ5d0d4bHN6ZkVvRk1Lc1JDSTlubHBsNEM1emxGQW15cWZm?= =?utf-8?B?RU1ybWVWdGs0WlJPeDg1K2FwN0s3NTEyS1FQVXJXREk0d1VhcFVHS1pIUGhN?= =?utf-8?B?ZVlydWtiVnZVK0RDSlNUdTNndHIzTUZ4N2ZoY0Z3akx1YlRpb3ZUODVUUklQ?= =?utf-8?B?MytnQ2dySXVUalpaS3VHcnB5NFIxL3Z5RzZTSmtxeStwaEhCMGlBY2tBMjRm?= =?utf-8?B?c3NsRzFFTkRSWGRCYjZMenlQc2NJanNmV2ZOallXWVh0a0c3enJtSHBlVUZz?= =?utf-8?B?aDliZkJIVkNDYUY2QnBFN2xiSkprMDZBRTIwRGl6MVNLRTRFZ1J1R3Zub29S?= =?utf-8?B?aXZuOWFYZ0x5UGYxN1JlVk1PNDZ2aHlaK2lJVEwrVXVRVUJvTG5SaE9RL0tY?= =?utf-8?B?MnZkSVRoZlJJZVRPYzdqYWNvVm9Ea2s0NGtOeFdWclZVQ205RXV0RUNYUUdQ?= =?utf-8?B?cUFsV3A3REZvMERGMTJpV201eHhxMnh2ZmhPblJ6bDVTMmlWL09nZ1NGbmcz?= =?utf-8?B?ZldFa0RKNVhZc3poaEVFSERhT3hOR00xQ21DQ2FLUmVXdEFUZVVPY1BrQmFs?= =?utf-8?B?TzN5dVVsUVI1c2JqbDk2dXQ4WTVJNE5TSGZJTnZ1T1o5Ly9nTnRIVTFvMmd1?= =?utf-8?B?S1JNWFQ1bFZTZTNEQ3hDR1VEM2I2UXJLNHZsTHVwQkRQWFdpSDNTZXpTWDBh?= =?utf-8?B?OVZpeTArajRHbXRKQ3NPRmZqZzVUeldvY0ZnZGtVM0pvM3dCeGdVSmRJMkR6?= =?utf-8?B?dFpnOG83djlidnhwR3dJTzI4OGF0ZjVVQ0hJem5mMHUvRVhSOFk4NDN2UzBz?= =?utf-8?B?R3dlUzRkR2NjVUQ1RDNqRW45Z2NFQXVKdGxwdWdKWUJtMXI1aXpLOVpwQUk0?= =?utf-8?B?V2g3UmlqZ0RYaUhnRC9ZY0VmSmdCYTgvL1hucGVBUExwcy9mVzZhNDJ0d08w?= =?utf-8?B?eEhXalQ3dHB1c1RXNWhzSEwwZ0xROXJoRHJnS1dRQXNsVHNzUnhjdHg3THI0?= =?utf-8?B?QmJjVDZjR2NhcHh4U2M5THE0L21Dc0NKUDMrUWY1TWwveUxGSkJzK2pWMVky?= =?utf-8?B?aGtjSmlwMlpNaVJIVFl2dERnZVNTcVBLZEZpbWcyWUIydkNld3pkQURpL1pt?= =?utf-8?B?VU1IOVVCY0hvNFZkUkFrRkNCSllaMHJVMlZqbTh4NFdsT3ZSeTVzbDVrZWxU?= =?utf-8?B?UmFVUWZwWkdpSHk4M0VvZ0hNbjNROGxoSE9iem95Y28vZlFESDRkMER2M01Z?= =?utf-8?B?S1UzODFEdTQzcGhiZzBhSE8yZUdhbTlEWUcyN2I1VVN5TlRubWtONnhkckw3?= =?utf-8?B?aHE2SzZVQWF3SVIvMC94VmNUVzhvOWhVdUUzd0c2Wm91MytCYURYTE5SVjBY?= =?utf-8?Q?OuQiRP7t0K23r2/tfxzv16xLS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39327daf-dc5a-44af-9397-08db99785c83 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:04:03.1722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oVRit6EkfkTFAxVs2utsI27aIJPgvFEkHDhyrBmANF7Sh0qnGK8p1HSg1oEx+CWziQ1iwrOBjySs59YpWb0Asw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7646 On 09.08.2023 20:41, Shawn Anastasio wrote: > On 8/8/23 4:12 AM, Jan Beulich wrote: >> On 03.08.2023 01:03, Shawn Anastasio wrote: >>> @@ -15,4 +16,10 @@ >>> >>> #define BUG_FN_REG r0 >>> >>> +#define BUG() do { \ >>> + die(); \ >>> +} while (0) >> >> This looks like it's temporary. I think any construct that later needs >> updating wants marking in some common way (such that it's easy to grep >> for items left to be dealt with; you have such a comment in e.g. >> asm/event.h). Of course if an entire header consists of _only_ stubs, >> perhaps a single such comment would suffice. > > Yes, agreed that this macro deserves a TODO comment. > > As for the rest of the stub functions that this patch implements, are > you suggesting that each file with stubs should contain a similar > comment? Well, each one needs to be (and remain) easily identifiable. > Another alternative that I thought of would be to define a > BUG_UNIMPLEMENTED() macro or similar and call that inside of all the > stub functions. I like this. Or maybe BUG_ON("unimplemented") could also be an option; not sure though if the compiler wouldn't complain about the resulting if ( unlikely("unimplemented") ). Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:05:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581878.911322 (Exim 4.92) (envelope-from ) id 1qU0fv-0006Sb-Nx; Thu, 10 Aug 2023 08:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581878.911322; Thu, 10 Aug 2023 08:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0fv-0006SU-Jo; Thu, 10 Aug 2023 08:05:43 +0000 Received: by outflank-mailman (input) for mailman id 581878; Thu, 10 Aug 2023 08:05:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0fu-0006SM-Qf for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:05:43 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on060c.outbound.protection.outlook.com [2a01:111:f400:fe1f::60c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b23628a8-3754-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:05:40 +0200 (CEST) Received: from DU2P251CA0023.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::35) by GV2PR08MB8656.eurprd08.prod.outlook.com (2603:10a6:150:b2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:05:37 +0000 Received: from DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::b) by DU2P251CA0023.outlook.office365.com (2603:10a6:10:230::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 08:05:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT007.mail.protection.outlook.com (100.127.142.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 08:05:36 +0000 Received: ("Tessian outbound ba2f3d95109c:v145"); Thu, 10 Aug 2023 08:05:36 +0000 Received: from b37406533283.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5159D727-7F3B-4A80-B3F6-A1440D0B9B4A.1; Thu, 10 Aug 2023 08:05:30 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b37406533283.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 08:05:30 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB7522.eurprd08.prod.outlook.com (2603:10a6:102:26b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:05:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 08:05:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b23628a8-3754-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JZD7CLFAqUvED8V61Les8HdNJWRfoQwW8H68dSyjoIw=; b=1VF3NtHXCmHQ0fqIW8jqJxTzKH8inJ3sOxed9ECBZhW4Q0Iixb6lOkahB1Z3gHx/mILRGw1OWIWZUtL3VeSvetR1W4lzvquyDcIsSOOpB6IiWjrXRacyi+6IHhgy67oJrXo3wkHo6KPGbmO1LoAJNy/W/UxNyo5dRWRIQZvaHoc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d6213792cd2192da X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C4vga6U14VwxOaE2uXhK3hPiWiLBY9bB95HI86X1jntBJXFAYhmo8lYq4LFlEQSbhLE+TecV2xkzg7n3H4rnhr/3wH49mmR+5C/nJf6Qix86xieqcySQ74Fr4ItooWLNZJCzdzmQSZTtDxfhB1ct+/BA8g83aw7woFO3lCQJDXya98y8CrMPVDhPUNqziMsiS+yHngnKtgHfT9RFzMJYQJ4hph/YlVniNO+UpYyBSsZI/kUXCqef3Pmg2/0tYN2k85vZvvMsJQwh1YCqp5dk+7NU5KB5aDXasv4EbyMX+fTigf33gcrkS4coYl9zW8FgS106ufqmyf1nISM1x5Gihg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JZD7CLFAqUvED8V61Les8HdNJWRfoQwW8H68dSyjoIw=; b=Y0IGfigGOvu88rI1+5BZvD9LL5jNA1WXND1BoAwQFAa8gcMeOW7pah/wr3dlfpGUgoSZNNr2Jvaesw2AY+dRArVZ+TrqgJbWRlw9W9drgPb8gdAkynwNi5T+0nyiy6rc2ATT/Zcy9yVDWdoReAI7UfGMRE28vr6JGc3ZdJLStKyUvY9nfigSM9uw5Y4ls/Vpq1YceJB8QK7U1NjFK3vW/vTAX1L/STvxFc5iNi2FG9UXGK9zeTlyXCZCtJdE3o3CneLyA2W4rQ2La8OEOEyrRrZGooECs4F+3GXsZ0jMKP7KCC0c7YmNV/UHKmV0AQIZVHWJsjtsGrAx9Kcsis45Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JZD7CLFAqUvED8V61Les8HdNJWRfoQwW8H68dSyjoIw=; b=1VF3NtHXCmHQ0fqIW8jqJxTzKH8inJ3sOxed9ECBZhW4Q0Iixb6lOkahB1Z3gHx/mILRGw1OWIWZUtL3VeSvetR1W4lzvquyDcIsSOOpB6IiWjrXRacyi+6IHhgy67oJrXo3wkHo6KPGbmO1LoAJNy/W/UxNyo5dRWRIQZvaHoc= From: Henry Wang To: Julien Grall CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Bertrand Marquis , Wei Chen , Penny Zheng , Volodymyr Babchuk Subject: Re: [PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables() Thread-Topic: [PATCH v4 06/13] xen/arm64: Move setup_fixmap() to create_page_tables() Thread-Index: AQHZxCqVen/+EDcaZkm/mD7lV8P3ta/h8aoAgAFIywA= Date: Thu, 10 Aug 2023 08:05:27 +0000 Message-ID: <9222878F-E2A2-4881-A984-D76B5A3A4430@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-7-Henry.Wang@arm.com> <1307da1d-5d56-4fe1-932a-c384323264ec@xen.org> In-Reply-To: <1307da1d-5d56-4fe1-932a-c384323264ec@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|PA4PR08MB7522:EE_|DBAEUR03FT007:EE_|GV2PR08MB8656:EE_ X-MS-Office365-Filtering-Correlation-Id: f4237f7e-7b41-4f07-c91b-08db99789459 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3wXZKfFq/yh/TXlqH48nwAkbegcKK6jedmTBPko3FhvMmv/3Z6s9346Fblvz0Q3e2YRRDnSz7AAuxfPBCxpCVYsDGh2BpcQW5RXDGZVGtrLyYz1gw30Ooy9SeWdAyNBOzHxHCtUlZmwa30j6gxhnCRwjXYIdyhnOa3Ok6ay+03vVYgRaFVUDh33Nf5XidFFR4wxnCHkYSgqhwUOL2cZ8FYWSnLRJRDwMppXbS4EgfoU70FitA0zrbNCxW8+cjaJFLlKZcLUYDkPjWnZB7LrFjbpffldtGJycrIizQqiJXE4Sz1tFOJxyOabaianZcggzDRSpkZf9JemlJTO/NASi14vONLarfgcxIoLT2xQd6AVGcgH63EBJTvsUjSLGFDBKNIRkI8BnVTMdsQenQ8HG0YmYMHytQbKTbf/fmqigOsTnxcxaMQOpIQt6p8XqHSK2WlwlxikQVxP+hPQ8aD2kwdAP/UmXVDEQ7X2cWrkfAsz0rKrL3xob7+JUdQ6PjUYuy5ex7BgbYTgtU6ux6xe0xQ3qUmkA+rXWbnJYF1aV8pzY4b9LJhT5Gym0z4dRmO98TMSxu9Is8p7H7iFOQVM4dYUIzD2QB08Tz12tF5S7p90z/yBbSGmkU1OWm9yA8QCoc7/iJBI62AlFFqkTDYvE5g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(451199021)(186006)(1800799006)(86362001)(76116006)(2616005)(36756003)(2906002)(33656002)(66556008)(8936002)(5660300002)(8676002)(478600001)(66446008)(38070700005)(64756008)(71200400001)(54906003)(6506007)(91956017)(26005)(6486002)(66476007)(66946007)(6512007)(4326008)(41300700001)(316002)(6916009)(966005)(38100700002)(122000001)(53546011)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <16AE7C9D69CB8548A0EADE0C881F1368@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7522 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 244360f3-4c76-4d5a-2fc7-08db99788f05 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ul4FYMx0Grqk7sHFTfoZf4Z5Qjr4c9yW5IWLN2G0ELreNFoZzPgiQ7ba2ol/6ymccdwraPTvwJ/m2ekrBAzf/cHt9JpO/uk1wxLFY5jAK5GCsgnEpCkHJO1rSk8KFv13oW7QufFzzR+FA+wVqhbydNMd/A6L4jf6vqbr+gEVfZPzXPihYxfuj4ec8DrVFoMqtGYxmZ4wLxPJCFZU9IiTqhL3yvFXXJJmtLiN6tlUN0Br9Nm/WSnsI0oqpDh/faRAnM1LxswIaggpqdvh+Z8H+d6Cft8Y75mbOu3sriUadDcNczI52TojuqK+wk94IeonlnlozT5DUCqR/rrFk64gWw6Y6ebQPOfGMjohSQsk1O0oFXCPs09jHKT5OYyTag9FPOzpMhVy2xUxUPAUMSC/v3YhYsTJ3lK5CyXMcRHkLx2Pnm/Ku625tQdDjVfhFGXdM2Zuj/6HBnZLvBbtagYEFcNv3dMg5Vwy+MKGgSsMxtPX+72CCXTN8wPUNQkZFT6NwI0FYLbrqfXitXTKiP2V8E+92ix+mGRCErj/fawcihPtVrXMnTpPiOE31Azofi0z0/+ZXaDux85b6lYUjI0QvOZQW6BulGu1MTiO7adcw+ta/Ju3MucLSvpo9aOIdoKhnztQ1+QtQYPvslEno9XZHcmkvaSYLVABQk7itD8Zt0kGrvb7HoOtfQ6+V0PRPqozwKMkF26Pwc4ZSk4YR5n85TM96YBoBvchKlNJvNtrHMM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(82310400008)(451199021)(1800799006)(186006)(40470700004)(46966006)(36840700001)(26005)(6862004)(53546011)(6506007)(8676002)(8936002)(41300700001)(40460700003)(107886003)(36860700001)(36756003)(33656002)(47076005)(2906002)(83380400001)(2616005)(356005)(81166007)(86362001)(82740400003)(336012)(5660300002)(40480700001)(54906003)(70586007)(4326008)(70206006)(6512007)(966005)(478600001)(6486002)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:05:36.6938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f4237f7e-7b41-4f07-c91b-08db99789459 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8656 SGkgSnVsaWVuLA0KDQo+IE9uIEF1ZyA5LCAyMDIzLCBhdCAyMDoyOCwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBIZW5yeSwNCj4gDQo+IFRpdGxlOiBOSVQ6 IEl0IGlzIG1vcmUgYSBmb2xkIHJhdGhlciB0aGFuIG1vdmUuDQoNCllvdSBhcmUgY29ycmVjdCwg dXNpbmcg4oCcZm9sZOKAnSBoZXJlIGlzIG1vcmUgYXBwcm9wcmlhdGUuDQoNCj4gDQo+IE9uIDAx LzA4LzIwMjMgMDQ6NDQsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+PiBGb3IgdGhlDQo+PiBmdXR1cmUg TVBVIHN1cHBvcnQgd29yaywgdGhlIGVhcmx5IFVBUlQgbWFwcGluZyBjb3VsZCB0aGVuIGJlIG1v dmVkDQo+PiBpbiBwcmVwYXJlX2Vhcmx5X21hcHBpbmdzKCkuDQo+IA0KPiBJIHdvdWxkIGRyb3Ag dGhpcyBzZW50ZW5jZSBhcyB0aGlzIGlzIG1vcmUgcmVsYXRlZCB0byB0aGUgZnV0dXJlIGltcGxl bWVudGF0aW9uIG9mIE1QVSByYXRoZXIgdGhhbiB0aGlzIHBhdGNoIGl0c2VsZi4NCg0KU3VyZSwg djUgd2lsbCBkcm9wIHRoaXMuDQoNCj4gDQo+PiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRl ZC4NCj4+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvNzg4NjJiYjgtZmQ3 Zi01YTUxLWE3YWUtM2M1YjU5OThlZDgwQHhlbi5vcmcvDQo+PiBTaWduZWQtb2ZmLWJ5OiBIZW5y eSBXYW5nIDxIZW5yeS5XYW5nQGFybS5jb20+DQo+PiAtLS0NCj4+IHY0Og0KPj4gLSBSZXdvcmsg Ilt2MywxMi81Ml0geGVuL21tdTogZXh0cmFjdCBlYXJseSB1YXJ0IG1hcHBpbmcgZnJvbSBzZXR1 cF9maXhtYXAiDQo+PiAtLS0NCj4+ICB4ZW4vYXJjaC9hcm0vYXJtNjQvaGVhZC5TICAgICB8ICAx IC0NCj4+ICB4ZW4vYXJjaC9hcm0vYXJtNjQvbW11L2hlYWQuUyB8IDUwICsrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25z KCspLCAzNCBkZWxldGlvbnMoLSkNCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQv aGVhZC5TIGIveGVuL2FyY2gvYXJtL2FybTY0L2hlYWQuUw0KPj4gaW5kZXggZTRmNTc5YTQ4ZS4u NTZmNjhhOGUzNyAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9hcm02NC9oZWFkLlMNCj4+ ICsrKyBiL3hlbi9hcmNoL2FybS9hcm02NC9oZWFkLlMNCj4+IEBAIC0yNzUsNyArMjc1LDYgQEAg cmVhbF9zdGFydF9lZmk6DQo+PiAgICAgICAgICBiICAgICBlbmFibGVfYm9vdF9jcHVfbW0NCj4+ ICAgIHByaW1hcnlfc3dpdGNoZWQ6DQo+PiAtICAgICAgICBibCAgICBzZXR1cF9maXhtYXANCj4+ ICAjaWZkZWYgQ09ORklHX0VBUkxZX1BSSU5USw0KPj4gICAgICAgICAgLyogVXNlIGEgdmlydHVh bCBhZGRyZXNzIHRvIGFjY2VzcyB0aGUgVUFSVC4gKi8NCj4+ICAgICAgICAgIGxkciAgIHgyMywg PUVBUkxZX1VBUlRfVklSVFVBTF9BRERSRVNTDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJt L2FybTY0L21tdS9oZWFkLlMgYi94ZW4vYXJjaC9hcm0vYXJtNjQvbW11L2hlYWQuUw0KPj4gaW5k ZXggYjdjM2RkNDIzYS4uNmJkOTRjM2E0NSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNoL2FybS9h cm02NC9tbXUvaGVhZC5TDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vYXJtNjQvbW11L2hlYWQuUw0K PiANCj4gVGhlIHNlY29uZCBwYXJhZ3JhcGggaW4gY3JlYXRlX3BhZ2VfdGFibGVzKCkgbm93IG5l ZWRzIHRvIGJlIGRyb3BwZWQuDQoNClRoYW5rcyBmb3IgZmluZGluZyB0aGlzISBZZXMgdGhpcyBz aG91bGQgYmUgZHJvcHBlZC4NCg0KPiANCj4+IEBAIC0yMzEsNiArMjMxLDIzIEBAIGxpbmtfZnJv bV9zZWNvbmRfaWQ6DQo+PiAgICAgICAgICBjcmVhdGVfdGFibGVfZW50cnkgYm9vdF9zZWNvbmRf aWQsIGJvb3RfdGhpcmRfaWQsIHgxOSwgMiwgeDAsIHgxLCB4Mg0KPj4gIGxpbmtfZnJvbV90aGly ZF9pZDoNCj4+ICAgICAgICAgIGNyZWF0ZV9tYXBwaW5nX2VudHJ5IGJvb3RfdGhpcmRfaWQsIHgx OSwgeDE5LCB4MCwgeDEsIHgyDQo+PiArDQo+PiArI2lmZGVmIENPTkZJR19FQVJMWV9QUklOVEsN Cj4+ICsgICAgICAgIC8qIEFkZCBVQVJUIHRvIHRoZSBmaXhtYXAgdGFibGUgKi8NCj4+ICsgICAg ICAgIGxkciAgIHgwLCA9RUFSTFlfVUFSVF9WSVJUVUFMX0FERFJFU1MNCj4+ICsgICAgICAgIC8q IHgyMzogRWFybHkgVUFSVCBiYXNlIHBoeXNpY2FsIGFkZHJlc3MgKi8NCj4+ICsgICAgICAgIGNy ZWF0ZV9tYXBwaW5nX2VudHJ5IHhlbl9maXhtYXAsIHgwLCB4MjMsIHgxLCB4MiwgeDMsIHR5cGU9 UFRfREVWX0wzDQo+PiArI2VuZGlmDQo+PiArICAgICAgICAvKiBNYXAgZml4bWFwIGludG8gYm9v dF9zZWNvbmQgKi8NCj4+ICsgICAgICAgIGxkciAgIHgwLCA9RklYTUFQX0FERFIoMCkNCj4+ICsg ICAgICAgIGNyZWF0ZV90YWJsZV9lbnRyeSBib290X3NlY29uZCwgeGVuX2ZpeG1hcCwgeDAsIDIs IHgxLCB4MiwgeDMNCj4+ICsgICAgICAgIC8qIEVuc3VyZSBhbnkgcGFnZSB0YWJsZSB1cGRhdGVz IG1hZGUgYWJvdmUgaGF2ZSBvY2N1cnJlZC4gKi8NCj4+ICsgICAgICAgIGRzYiAgIG5zaHN0DQo+ PiArICAgICAgICAvKg0KPj4gKyAgICAgICAgICogVGhlIGZpeG1hcCBhcmVhIHdpbGwgYmUgdXNl ZCBzb29uIGFmdGVyLiBTbyBlbnN1cmUgbm8gaGFyZHdhcmUNCj4+ICsgICAgICAgICAqIHRyYW5z bGF0aW9uIGhhcHBlbnMgYmVmb3JlIHRoZSBkc2IgY29tcGxldGVzLg0KPj4gKyAgICAgICAgICov DQo+PiArICAgICAgICBpc2INCj4gDQo+IFRoZSBEU0IvSVNCIGlzIG5vdCBuZWNlc3NhcnkgYW55 bW9yZSBhcyB5b3UgYXJlIG5vdCBtb2RpZnlpbmcgbGl2ZSBwYWdlLXRhYmxlcy4gU28gSSB3b3Vs ZCBwcmVmZXIgaWYgdGhpcyBpcyByZW1vdmVkLg0KDQpTdXJlLg0KDQpLaW5kIHJlZ2FyZHMsDQpI ZW5yeQ0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:08:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581885.911332 (Exim 4.92) (envelope-from ) id 1qU0it-00075W-57; Thu, 10 Aug 2023 08:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581885.911332; Thu, 10 Aug 2023 08:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0it-00075P-1d; Thu, 10 Aug 2023 08:08:47 +0000 Received: by outflank-mailman (input) for mailman id 581885; Thu, 10 Aug 2023 08:08:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0ir-00075H-TF for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:08:45 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061d.outbound.protection.outlook.com [2a01:111:f400:fe1a::61d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18a39fb5-3755-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:08:32 +0200 (CEST) Received: from AS9PR06CA0021.eurprd06.prod.outlook.com (2603:10a6:20b:462::27) by GVXPR08MB7751.eurprd08.prod.outlook.com (2603:10a6:150:7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:08:39 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:462:cafe::21) by AS9PR06CA0021.outlook.office365.com (2603:10a6:20b:462::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 08:08:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 08:08:39 +0000 Received: ("Tessian outbound f1e964b3a9be:v145"); Thu, 10 Aug 2023 08:08:39 +0000 Received: from 76bc1988541f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6C664300-1F04-4199-A3BB-820C38645FE2.1; Thu, 10 Aug 2023 08:07:58 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 76bc1988541f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 08:07:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB8158.eurprd08.prod.outlook.com (2603:10a6:20b:54f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:07:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::7083:22dc:6b5f:5965%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 08:07:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18a39fb5-3755-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHgmFEnPHnSNPWliSz2PwyHZIWmcUEcvkSFnMNbuE2o=; b=ilLL8wC6Qb6qLo9M1JhZPOZAZckOcTVrD+asL9Js6uey7HfnRE12nsSV6jdWneu0N0I1TXWn79EK46oHtTSIy3vglhjV6Fe/NI2AVd3Mboi6dMYSP1NSTuCzQDQpW2mWUEgfu2voipxCWEzdqEYuJ36qW9lwiV4mVSNSZBOGGKU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a41979c26f847496 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KG0tdp4NEnRbcWmVLD5gUrsK/CcG0cXeCm0Sl/o/GUQc2WDWZzoMt+sKWfW0veZJB2qt13EbwzIEpa37oo6RCuxZIzD5WcrZ4Vn2jC0b+gd/Yw9/CcXkxAkQwKiCojV036dnLDpfIIdgMTBSg1jPimvgjMgcdeCwDkpkYrNcYlgySvxqGl5rWxBGQ2wBc6+SCWhjOUy09hAoZ2skkwXUyidepp4wIzS/1wcKvK+op8bzFhyscsXNmGUiR48TX447mfp4dcAxC3YBpSh3GrRXOicwuIDH5c6Gllw9Jhb9wWKn/eKytZlHEDuST+eoM+62DfSWBfJK+8xB/ZyrT+QUKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DHgmFEnPHnSNPWliSz2PwyHZIWmcUEcvkSFnMNbuE2o=; b=NEcAPw9aUkBgFIJ9gaSUM56RDdlBubXpsTBTKA9zc6JTeyacXMpjerLFBAtAlg1BkVXW7uMvCbAq/V+OMALBqVKyWaykI50PMLfCtThM2QKdGyQBifBSo0456Tlrko//qinOWlruTnh/Y5Qkc177kV2I9d/X6aFHkb7wUKljV7CPt4MrAK9FG27l7X4umUsS4myBYYY1mhh/RprWL8X2tdvWLiZgf78StKY9ZPACqtpOThMj4YZ5J36xyZMekta7q2cRV5xE+L8HNxplcusYWfJDhkcDWG7SLuwNOMc6eXeeLWGooMxPmbUxx0KbzoMJEygIQc7sonia9FX8fB8Exg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHgmFEnPHnSNPWliSz2PwyHZIWmcUEcvkSFnMNbuE2o=; b=ilLL8wC6Qb6qLo9M1JhZPOZAZckOcTVrD+asL9Js6uey7HfnRE12nsSV6jdWneu0N0I1TXWn79EK46oHtTSIy3vglhjV6Fe/NI2AVd3Mboi6dMYSP1NSTuCzQDQpW2mWUEgfu2voipxCWEzdqEYuJ36qW9lwiV4mVSNSZBOGGKU= From: Henry Wang To: Jan Beulich CC: Penny Zheng , Paul Durrant , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Chen , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Thread-Topic: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Thread-Index: AQHZxCqigu1wJWpVm0KnP9vpRTw2qK/VD2mAgA4rvQA= Date: Thu, 10 Aug 2023 08:07:55 +0000 Message-ID: <0A1CB23B-6597-402E-8420-26C908A13ED4@arm.com> References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-14-Henry.Wang@arm.com> <6c8f904c-d7f1-343e-2208-6cf963e1e25c@suse.com> In-Reply-To: <6c8f904c-d7f1-343e-2208-6cf963e1e25c@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7991:EE_|AS8PR08MB8158:EE_|AM7EUR03FT023:EE_|GVXPR08MB7751:EE_ X-MS-Office365-Filtering-Correlation-Id: a084057b-638f-4ad8-f631-08db99790139 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Zp0dFhVnwHfx+oTsKSHTkJykPybbrJkYi42qUenR0599bWP1GUd1JgtPdFrpnYIuNPfRFyrJQwtyTkpJp4d0V3T3CBdt0Jg8fo+kFAq+XnoVLv2bT9aea1PEqYbtfnsKaoYJnciAngenehTQCCYg2KN8qS07Zx1SJD992AT4yXHBU/WKjSNDDKWGrthXYCiW2vskw7z/auyLa7MQ4oJWzCIR2NtlFJooicR+4YEni5Cz66Gf/ZVsCfvdQvpPyxZHKdFo4oawyqKW4oYTEPYh1llIqSpJJxjau/PthmF51dWjDQEO+SP5HZe9ZbldLMNVSqvKowmda+Rn5l9W46/B3Jq4RdsmafMPZPbRWXobnAmtSpDDDKnLeIXoqnlawH+19afuIBCTMv7ufzIIW+eW84xwX1rp+/ItJkGCQ7wXECHQzEcbIklkREtKMLFsLaVzs6Pz88nGi6JIE/IdeNaX6kwOMsxUfLpJ4/o+5Rp1xbY9V1rtpFqPqNabXJEP2SiZtSUh689a9cosSnmidSE3Uylkpx6+NHD6hJscHQQe871/wPCO3v746tTQsVp0Gv+RhaiVe7nvfUXJR676CHyRo3VDbg+hMusDcumYJNmfusaDlmbwi+pFrGYyo7ymYfAj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(186006)(1800799006)(451199021)(6916009)(91956017)(64756008)(76116006)(66946007)(66556008)(66476007)(66446008)(4326008)(33656002)(966005)(6512007)(478600001)(41300700001)(36756003)(316002)(6506007)(53546011)(26005)(54906003)(8936002)(5660300002)(8676002)(86362001)(6486002)(38070700005)(38100700002)(4744005)(71200400001)(83380400001)(2906002)(122000001)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <2A96DB6FF701DA4E9F4F46922EFE53D9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8158 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 77182e12-d1bf-4ebb-5bf7-08db9978e6fc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eggvb/e9z4mNfHHTEpts1idldy/T04AJDs7DlQ4ZshIoza3uotg+YDkr5/GfVMEOpSTqXvQy3eo8we1FmJHQwFMm1QiLZKWhDX7P8ugeq4Wu4n5rS2edRHLIXzY8xvZHWbxjT31zFbZukgKkiprEXeoX0XoSaUWMwdVLNGsMVUtBBCNd0EjhgC6AppLywO8Xnq78H7gnMPQoqIh5XYC40vgSXvDrIkHv+A8TTJALYTLC7XCaA1FRyf3WkAB1Svl+cCJo1d8zbKrqX9SEqFqky0YKfBwOGblnt+FFzwmZxh066KyCspunpmdwKbRB8M1PaCI+aePXYV8gkw3ePswWANlbch7DXSrE0IPVxgDPC+i9L6mRJQ5/xvymFI3UiZzWVMIGBR0lbaGvQBvx+3b03I+Y0f2YZ+AVRmtgHuYeYsXZL8VLegKcxuGtk5vre3eWS7iJmajZfQkp/OWqB6MJNYLQ0IEqGKKm1OUQZ/k0emIHmUvvRWe1Xk38d1IaPIJSqYLHWbG8uCsT3BLu/dP/jD1ZXKEWN4IPeKn8KzlVoWwgdvreAKkalEfnUww7mJuT/2AJyCOXe7H4JTgNSG6dNFhzUOeB3Mh8fKp5eY6zbjrCdLuPytM15DuQT6CgFw6ozTeE1rFZgO/KKSi31zF/i6LXUH2RS/tL4KqMPms3U6o/CI73DQlXDGRIGzL7Q84DeWyfJ8pSqpkfd8gk8owxz5g5dtWrhHjzyrH8cMtVMQk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(376002)(39860400002)(136003)(1800799006)(82310400008)(451199021)(186006)(36840700001)(46966006)(40470700004)(40460700003)(4744005)(47076005)(83380400001)(54906003)(2906002)(6512007)(53546011)(336012)(966005)(6506007)(33656002)(26005)(36756003)(6486002)(86362001)(478600001)(40480700001)(2616005)(70206006)(8676002)(8936002)(6862004)(70586007)(4326008)(316002)(81166007)(356005)(5660300002)(82740400003)(41300700001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:08:39.3256 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a084057b-638f-4ad8-f631-08db99790139 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7751 Hi Jan, > On Aug 1, 2023, at 15:43, Jan Beulich wrote: >=20 > On 01.08.2023 05:44, Henry Wang wrote: >> From: Penny Zheng >>=20 >> SMMU subsystem is only supported in MMU system, so we make it dependent >> on CONFIG_HAS_MMU. >>=20 >> Signed-off-by: Penny Zheng >> Signed-off-by: Wei Chen >> Signed-off-by: Henry Wang >=20 > While entirely Arm-specific, this looks to require a non-Arm ack: > Acked-by: Jan Beulich Based on the discussion in [1], now CONFIG_HAS_MMU is agreed to be renamed as CONFIG_MMU, I will do the renaming but I would like to confirm with you = that if I can still take your asked-by tag with such change. Thanks! [1] https://lore.kernel.org/xen-devel/429625da-ec4f-448f-a0c4-47ca0f62f395@= xen.org/ Kind regards, Henry >=20 > Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:09:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:09:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581890.911342 (Exim 4.92) (envelope-from ) id 1qU0jC-0007Tq-HN; Thu, 10 Aug 2023 08:09:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581890.911342; Thu, 10 Aug 2023 08:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0jC-0007Tj-EC; Thu, 10 Aug 2023 08:09:06 +0000 Received: by outflank-mailman (input) for mailman id 581890; Thu, 10 Aug 2023 08:09:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0jA-00075H-FM for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:09:04 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on061a.outbound.protection.outlook.com [2a01:111:f400:fe0e::61a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 247d56dd-3755-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:08:52 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB9078.eurprd04.prod.outlook.com (2603:10a6:20b:445::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:08:59 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 08:08:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 247d56dd-3755-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5xaKSsFUzB1tHUZfRRxFQCk+LN7iskJspXw9Rn44cAXfglic5leSctAc2nHkcvtfEwU29utvv3D3gxga7BovVKNcNxQlDXqt6zVbwRP0DWfZrOXX+NIDx0ywKIoIdRab491bG6uHB/HsF+4ScB+effi4eSZazJAyN0OqdJ/Bbe+VXOicCd8ybGbpUKLJqwRQdTYkGdDbEnXQkM6I6gYQu7DALfOHiae195ODZNap+HuUuJV3xJUrUDVkgTxSni8CidCs2v+qLuu5am2MG/JiVn7UwSX6Fvgjc0i8G7sDHdBsxGFgDT5hYXzF4oUoU6b9YAMisthQ6ZhRLAzXxOoMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VeqaQGm2SvFd1mSvQd1T0j7R+k314rTD9k3Q+ZG/iqY=; b=nPUm5OOPLSUzBdStMBhPKjb2KvxvoKPG+ohwtgXHfc6PxZ53oFyOtB24hBO0L+HVXGrmd7QEO+nqwvuWT/oGd4ZrvaQSb9VjG0++gyRl0Xs8jTxQPFh9dSrinIVUQeUHMOaaHcdUaN+HWYjlmuwDRhXM1FGDj/F0jYT+PEdXWrRBsfTLmJZ2OFvyY57BAn+OcR6KyJv5Siytv+rxha6ortxVDCJZctKzEtItJLxjQSKsAYZONsiWOXpgfaRE9Rh7PuMfxF8nCuoiLSvG1aqcY3RTR5JvD5ECL/8ElBcpBDN8HbKjZNA0Cr4s5ZYYmDHHAfRTiL1y9GUoT9vmeCxkXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VeqaQGm2SvFd1mSvQd1T0j7R+k314rTD9k3Q+ZG/iqY=; b=ZLKXhLyQxBW+N5w98lgFsfPg1DX4zQ4YtTcgQlgnZs4xsTkyNEkzyuc8gxE8HsB+TDPQjUsykok6Bm5ssRAPA/bYtgx+KEFggVhEQ/DnJxKnU2is3oNq1lBblfWz7xx1OtnRQAJ6yXY06ZHlwsOk6f76uh4HfCpinvwYqYmdTfg+K/6zWlPu/fdrGt6wmUFjMLm2Oil4Jws7jKtdCmDPEti8KhKJ20e1nMtyYvNrlYFHZ7EFKpXuWJA0HPg2pblF4J4Bgzfiy/BfE0ezC+N8nizNahcI4n9uZTmyfkzEg3O+pFXPnLWAk5kiImlQKY+eUGhPEHlLeiZqbR1/O4ly6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9743391f-3b89-ddba-1c79-ddbb1d143437@suse.com> Date: Thu, 10 Aug 2023 10:08:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RFC PATCH 5/5] xen: Add clang-format configuration Content-Language: en-US To: Luca Fancellu Cc: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-6-luca.fancellu@arm.com> <3c5ae070-d6c2-070c-e482-e5135e2acef1@suse.com> <394778DB-2D5E-4C52-9DA1-F23A530534A8@arm.com> From: Jan Beulich In-Reply-To: <394778DB-2D5E-4C52-9DA1-F23A530534A8@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB9078:EE_ X-MS-Office365-Filtering-Correlation-Id: 7be0eaaf-ab76-4a08-c6b6-08db99790d48 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MNL/Epfttm+//OvdpbKpp51QxS4giTUdYLzdX7MyemFasLF2IKItRxTKO5wec8YDLK4gWELT/lGZEE4/j2bTctDFj4BKOilrSyC6MpbvaadrjxC2KxdEn6Heho5qYG23OANkakUseKAaGKOD24OoTBfKqbJsV147Lz8/hhgPlODNBDzboauV9snVevgbX8ercK8sxhfx7X3+5cFu343wXBrUzozpl4TBDvtCRWwFneYRTJU8ngIvU3ldDxgBe7f+xRpSqj4eC6Cz5mpR+F5fopCU/PeqTV4n0DeCQWGGn4ISX4RHVnGIQNzHFk8e/G/+YHG54qzEoXLbTJZy6GX9WWuz4GT5wA9cdUVViI/aqwjndhDgAarz5OJI4TYwXXJz71xTSGP5th/m04qjlT4/Zau9XJLH525odG/KR3d47SQdhKliYBqGcVNZOZuoyKqIPNAW9vkeEVd6QlIgjKeTZYVhizJEyhxmSmB4Ay9lO6oKty41wGxFw4fDOknlmFCPE7Clshp4fYZUTTXbJJ61Zt2N+RSluwc+GNdXwczNMU2v1F8zTPOrjs+ZRLUgkAaJ+1pdJR+LbrrxUf89itRuldpIYmBBC7WRzNI/HsbzeUjwp1ropkwLJ+GTWftuu0N2JsQaE4gAukhUKfxPkyQxUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(366004)(346002)(136003)(39860400002)(186006)(1800799006)(451199021)(53546011)(6506007)(26005)(2906002)(36756003)(38100700002)(54906003)(2616005)(6486002)(31696002)(5660300002)(316002)(6512007)(966005)(478600001)(41300700001)(8676002)(8936002)(86362001)(31686004)(66476007)(4326008)(6916009)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWNocHRRR2VWMHErU3R4ZkdvSngwU1ZaYjdFODU1SkFQVXdJRGllZmRFTWd5?= =?utf-8?B?Wk4vY1g1bjJzQjdzSnpkZ2MveC80cVhqblN4V0N3SFVCMUU1Skt3NzFFRUpN?= =?utf-8?B?bjlqN2dPbU1JRDFUMmJOcGcwc241STVIWmRzNGxrMjNYM2hFNmc0RXFwekF2?= =?utf-8?B?T3VLVHRBeXNXTlQ4a0xUM2RTM2g3TU9TMlJIdnNZSjNXamhlMmtzNjh2U08r?= =?utf-8?B?YWpYdjlhd0hES0hGVEZ4Wnl4aS9qQUdEUzY3bEl1RDJlWGM0ZzFqczIrQ2lL?= =?utf-8?B?YmRkYjFnMW9GVXgwMWJPTXNPTFFnUCt2ZnNyU3J4UmhMaE00K1RsMlN1ODRr?= =?utf-8?B?RlRuaHlaNThlS3g0WmNHVThNeFBnWUd4aDFZVjBJSW9KYmhjbTRhM2hLS3BY?= =?utf-8?B?QWJIQWtqYVpLL2ZKbXV3Z3p3MzZJbUttWVhDa3RySlNxYXVqY1IzTit5aU5I?= =?utf-8?B?MFYyUFlOZmdzY2Mxc2FuV2Nub3gva2dTY2hXVXExVVlnWGRaSXlXdEdHMGZM?= =?utf-8?B?Y2hyclRLS0JMaEVEZWVPMWhoTVRXem9ic0FveTZmb1lFOTVST21IMnZMQTlQ?= =?utf-8?B?UzBWZ2s5b2VsdjlzVWR3SW5aRTNuWDVpT0Jzc2dBQkF2T3NIbXkxdXl2dGVZ?= =?utf-8?B?TnhRemlURVZNZ2I2VS9oNEV2bHJ3Y2xKbEdVdEhuSUNwQkxPMlZFdlAvdnIv?= =?utf-8?B?Tnc5blczTVUzWHp1NG5qdjdVeXZaaWRNN1JYWDZCQnpJSVVkaUxTQ01xRDZw?= =?utf-8?B?Qkt5SG1ORms1WlVWejVPZ3FBTWlEOVZ2SXdVZy9ycjNxRndaQ21WMmMvKzVL?= =?utf-8?B?cUN5dkNqaW9BWng2U3dGVWg4VmpsN1RiaEdONEJTNkx4N0RmQzRMOVJKWEt3?= =?utf-8?B?UmdqMnZTelFwNndmVGlXUk1tYnA0aDZqSWVFZ0pHb2tKOU9TK0UxY3VWSnBJ?= =?utf-8?B?aytTOStQa2hkN29XSGg1VDFST1VWaHJXWmg1WEFUWUswYUFIM2luZFNJSEhX?= =?utf-8?B?OEhqOHNwUTgweitIQTBIV2tUbkZiamczbmVyZGVFTTdBR3Z1bk85bm5yS3VQ?= =?utf-8?B?dWdweDQ5azBaeWp2MCtwRUdWc2YrK3N6QzRaTW85VFoxK2hKS3JRdkJ6K3lN?= =?utf-8?B?c3VQbGdwQloydGJ0WFcrLzR4TFVYeFhvaUtyUlJJenJGeWxhZnVJYmxoOENK?= =?utf-8?B?U0pPc3kxS0xZMHVHNGQzODV1bnFYUTM4T3d2YlZFZDlINTZSRFRLaWRtT3pn?= =?utf-8?B?QitBS2V1b2t4aEY2YjU1NVdWNE5BTjBwZENKdXdIbXZtcmtEVDFEaGtBOWd6?= =?utf-8?B?UXpURWxoSUc4cnhINERCditIL0ZqWGhScWZPRjJLZ3BtZkZvejdqZzY2UEow?= =?utf-8?B?dy9MV0NNamxUZ1BQRWJoZjRmd295VDIvcVdGYmpYZGVURHE5RFpaejlLazJF?= =?utf-8?B?Qkl0NXQrbGdtbnZwY1liaE82ZFVtQWxVVmJqUzhCcnRSaGc1OElJekR1dTBJ?= =?utf-8?B?V3paRktITFNaMmo5WHF6SDlGL1JwSHVHdkVWZXh6UDVEU3RwNXJkbDVKemlv?= =?utf-8?B?Ulg4VWVRLzIvU2llb2I3aW1hSkF5KzhGWEtPSS9HVWg5d1FXdWpNNHFWdGky?= =?utf-8?B?TVhTVUFYU2VNVVh0ZVhsWDVVVUdiakxlWWZQVTU3NUxpTFp4aUpOOUtUQ1ps?= =?utf-8?B?Snh6SGFNYnlndWF3em9sbk04MGhhOWk5ZmVIYVVnMUZkNFk1S2RJcmZ5cUNv?= =?utf-8?B?TnlBc3BrMWdWRHgwQlZsVTVmR0IrSXBqR0g5ZkxXV1JlVXVscjBLUlYvbnpG?= =?utf-8?B?V1g3L3lmZk9mOGtNZWpiVnZ4bXc5b2srWnl0V1hvVytkMi9pSDBTZWZYUkU4?= =?utf-8?B?aU9pVVQvdnpaZFQ3SlduMjF4clNFRmNTS1B6NEdUaTRLcUw4ZDlBTUtMUFhs?= =?utf-8?B?Q0phRGJkbkNxOVNLbVlKd1QvTnZSMUw0c1UvN3VxSW5HL3luMktWN0lxaFZ5?= =?utf-8?B?R1IyZm91K2szcGhjc21aeUgvcllEaWE3M29FeVlaRWtqeFczVFA4MEdqeFFF?= =?utf-8?B?dEJWK09mQXRpeHo1RUtQQVdxZTM5K2JnZXZQOWZqYTlMN0RTZnMxMFJGeVFQ?= =?utf-8?Q?+1lh8l2AyBBny0+q/pcISf+H8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7be0eaaf-ab76-4a08-c6b6-08db99790d48 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:08:59.7511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IkKuRkyE1CzHd2asE8/WaFyDrVVrx1xA6ptsggptDdm8YNeaHF/1zBOxmkqrpyG3XWJvzDuDvDM+Zc9WHJmUHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9078 On 09.08.2023 18:18, Luca Fancellu wrote: >> On 9 Aug 2023, at 16:48, Jan Beulich wrote: >> On 28.07.2023 10:11, Luca Fancellu wrote: >>> --- /dev/null >>> +++ b/xen/.clang-format >>> @@ -0,0 +1,693 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> +# >>> +# clang-format configuration file. Intended for clang-format >= 15. >>> +# >>> +# For more information, see: >>> +# >>> +# Documentation/process/clang-format.rst >>> +# https://clang.llvm.org/docs/ClangFormat.html >>> +# https://clang.llvm.org/docs/ClangFormatStyleOptions.html >>> +# >>> +--- >>> + >>> +# [not specified] >>> +# Align function parameter that goes into a new line, under the open bracket >>> +# (supported in clang-format 3.8) >>> +AlignAfterOpenBracket: Align >> >> I'm not convinced this rule (assuming I'm getting it right) is >> suitable in all cases, especially for functions with long names or >> very many parameters. > > Not sure I understand, I think this is the current behaviour in the codebase now. My understanding is that the above aims at (only) unsigned long function(unsigned long first_long_argument, unsigned long second_long_argument); when we also permit unsigned long function( unsigned long first_long_argument, unsigned long second_long_argument); Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:11:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:11:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581898.911352 (Exim 4.92) (envelope-from ) id 1qU0lv-0000iy-VQ; Thu, 10 Aug 2023 08:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581898.911352; Thu, 10 Aug 2023 08:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0lv-0000ir-SI; Thu, 10 Aug 2023 08:11:55 +0000 Received: by outflank-mailman (input) for mailman id 581898; Thu, 10 Aug 2023 08:11:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU0lu-0000ih-PW for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:11:54 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20602.outbound.protection.outlook.com [2a01:111:f400:fe12::602]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 905210db-3755-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:11:53 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7235.eurprd04.prod.outlook.com (2603:10a6:20b:1d1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:11:52 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 08:11:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 905210db-3755-11ee-b283-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QqsyL3uDNqmsgtCkaToTItyBDQKqGJuAvUrhfmFmRcZMSvl5UFYLLBxP0xSo49xDK2jNPTmu3aGZnHy2NCNddWO+ALOMZzDngA8D7DPRVZjYVhGg3/9QVAloBvE9LOnQRHjZF9E6ePUn7VQj4CJPO3Hwju8Y6cR0rbWvgxUcM+Jf9RxWHMu6icT7Kwv52wGo+/9nyCi8zfUbsCdvrXkAM1dgG9XQY8AokaSon1fkccwNSI3HOFVgppAAmFIVzs3nw15tltd5+g1n9dYX3LlLrpscWP2UlgML71AYfoiksqAVvmoV7SQ0Ugn+lEKR168YJz0mPYSD+Hs5Xf+FBK55vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NrEdRhPDKplCLwtRTf7LJrYIn9U9dy0ALOx2AXSyzg0=; b=HNYJGg8F5c3GO1gIYPsRGnO1nBfLB3wGMxWhFK9XhhuE6+UnikCX5Y8i26Q5vM8o+wwIicIl/qjj/2daPvHXBqFMQTLssjxUwSa6bqvVRRkm8rra48m1LIDL+KU5wgsW54S8mhznGlDVmgXly/6ubuNt2mbQpnUpMKbrUrTeY5eSd9L+UDF3sHicW0cRv2WoqYDKy3xGwkdcJf6OTjVCndYOZ9r+k7ihBRX/mLAUEvi8Jp4rV/UropsrYIpzvfg/zkg0F3iuCDlY4k2vV5u4z5ql5KbBrXPslRMs7eHHPpShpX9vBCP5uqTHjRU28VrovdZQMyr5fCJ7m5L+zocSJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NrEdRhPDKplCLwtRTf7LJrYIn9U9dy0ALOx2AXSyzg0=; b=n/p8C5CEfswzLs69+RtM+ECIN2tN5dNKZ72jOwjzm7XNiAe/P6fBTj1zD3D12PJNzXF2S51mxc78YoOH+zt6hP2AuUv0ZxDf8yfNmdb5QSm2qdFFXS8U58HwzWqOv0zJUwY4ariibS5cUjR3iiUevk7WE8esKc1csg+0kh1udeAl6+ZnNZSweIgWAbk++v3RKdkIuC+iln/868L+EO/4r9Cfxf8uS46p3iuWGoUjBjg6L2ehkzn2emEEpZCbJrNzo9Julyj6xOgHQShlVXtF83Wbj9QcvYJUIgtWPoGD96aMnlITNuS1REGSGvlKE571gAgmwHMWY/nOo68bTMdLeg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5458ff58-bbc1-9616-fa43-bd0fb67688a6@suse.com> Date: Thu, 10 Aug 2023 10:11:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 13/13] xen/arm: mmu: enable SMMU subsystem only in MMU Content-Language: en-US To: Henry Wang Cc: Penny Zheng , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Chen , "xen-devel@lists.xenproject.org" References: <20230801034419.2047541-1-Henry.Wang@arm.com> <20230801034419.2047541-14-Henry.Wang@arm.com> <6c8f904c-d7f1-343e-2208-6cf963e1e25c@suse.com> <0A1CB23B-6597-402E-8420-26C908A13ED4@arm.com> From: Jan Beulich In-Reply-To: <0A1CB23B-6597-402E-8420-26C908A13ED4@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::17) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7235:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ee4f1bb-0ede-4b7d-8553-08db997973ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CqsG9yeYyTnZ4b0O0Q1rf91V5vjYgpa2Lo4C6jP1ONwRdzCDhSEddovJRK0JWPnUV3dsO0TLAfTjeqoeUt8sLJEgdfqAV+yHkSawF0vy9wcGsPCJty/qz8R9KcaP0aZqwmgeJbrTxCyFIiIAhdAAt9Po4w0Vs+bi8AT744UaJTr2T6qg53ZG7wnE2pNDrQ9D4cW2i35RwNcHoZ5gITQDnGlLb3DOOZtSFbuuDsMWCsqYLoPAWjn9fAW/P7P/6y/kXGMHUziqOMghJunBTClHRXNlHkjnaQvOgFbQyWe8tV3HUF9co6YxyqCEsRm5DfQAbYnBlZMtWbReG/B/HrYo4av086YKWOAHOjKsVuY67EWolzkL28Eb37suiulRG57GUajvQ+u5bd9r2Efpvj/1L3PKSrTfB575wwlUkPPgYz7xN7W4meCZXu0dxg0JEiI+o+ffqwPSMIuLpOhG5wvZ6flkgGwBBbwWjO9z9pHLaggB2dAdSxdPDO3ktyeVRdr6o+3hf4r50jY3/LxJTKTavKppgmyJsYzDFR6hGmG9B5ka2013XLK2a+wcUEjP8BFz8480nl8WtLEhv46sGgh6wpxoPPk25WLcZoQRULdYxfjtwtXDFhY6pSmkNHWFwSlNVSDw/ObVc1/8BDz8TrqMPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(39860400002)(376002)(346002)(366004)(1800799006)(186006)(451199021)(66476007)(66946007)(66556008)(6916009)(53546011)(4326008)(26005)(6506007)(2616005)(36756003)(38100700002)(54906003)(83380400001)(41300700001)(6512007)(4744005)(2906002)(478600001)(316002)(5660300002)(8936002)(8676002)(6666004)(6486002)(31686004)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG5xZkJXREltUml0TVQwSEYyOWcxMHFrS01FWFZJcHk0dW1kNjJsazJOMjZx?= =?utf-8?B?QXBxUlZuM3N4S1NBOWhFTE1WTDRTb1E4SUp5RndHNHhVdGh4ejlKZDQycDBt?= =?utf-8?B?WEtBNG5zWHkrRVdCVDJQQ0dGYjd3M2xrVncvaVJxYTFXWFFBa2RVeW9tUnRv?= =?utf-8?B?MUVlY0tISktXZkxRQ0VBL0d4eXUzbmpmQjJJWmZDRGYzL04vekE5ZFQrTVdr?= =?utf-8?B?K3F2L2huMWxESHNnaGdRT3hhVlQ2cCtSbUs5ckZ3d0RLUW12WjgvZlNkZGpH?= =?utf-8?B?bU5EelIxVHBIYk1EdnAraExyTGJqcXFYd2dKYU5WUnpiaDBhMkFqbjRVY3Jv?= =?utf-8?B?S0ZadERmclJPbStBS2J4ejRjNTFQTHdqbDYvNlFoWFN1eUgxc1I0Skwzd05H?= =?utf-8?B?NHVZOFR3N0xzOEVjZFJGQWRBS0JLVUdDanhQWTdxc3V1eEtMeEVFcWFKTkNP?= =?utf-8?B?Mk9IRnJwZkFTbm4rK3BWblkvSFN1SVZKMk53TkFlQUltREV0dEQzZmRIYjcr?= =?utf-8?B?VDZHKzZWUTAyU0hleDhPbFppOVkxRVNRV1lLd09ISVM0ZkVDSm5UcFZDZU5U?= =?utf-8?B?bkhSNnN4UWRxUFVFVnNwT1B3bVBqbHJYQTlDZExCSjgwS2w1aFJCVm9aaWRt?= =?utf-8?B?RXpjWmV0SXI5c25TRnQvbWtTMGo5UVJCV2ZiSWRnREN3NytQNkpJN2h6Ukkv?= =?utf-8?B?ejE3QmVqSTJxRjVJVTcxbGJXNnQrUnUraVd5ZUFpSjY5NG1OYkhsaUlUendY?= =?utf-8?B?cDEwcjYvRHEvOFdyYVUxU29wVnJtK2YrQk5MTjVaV3VYVVZDR2Yyd2JBTFlZ?= =?utf-8?B?R3VxSlZRc1JXVERKMWZYL3dXWTRoVUhJZU1WVUE0akkrYXFDT0o0eGRFYmdu?= =?utf-8?B?eWJKRC9VNXI5UEhBdUVaeGlKeUVSWExCZ3BMczVTRERkc0c4NENTaHVVSGRr?= =?utf-8?B?YlpKemxIdy80NTBPN3daMmVvYjVHQXJzRGVrNEt5MUZhZFZ1SkF4anZhbW1N?= =?utf-8?B?R0s4R0phWjF1N0xQdElqcGNxR2FmdjdINzErVjY5OU9LTGpOR2M5S2lTWTRt?= =?utf-8?B?bEpIb2xVNVVqbVFKZUljY1VFcEdlZTdiZTNFMVJlSTVMYStRU0hVOE5tZUhh?= =?utf-8?B?c2lNK04xcnRWYmwxVlB1bEZ4ZGx4a3BPWVVuR2VNeFhEU3FZMzh1WnJ5VEx6?= =?utf-8?B?OXlnZE1yM1lxbGxBYSs5RU5oWDdSRnA4dFV1RmdRbldibEpiTlVQem44WEtU?= =?utf-8?B?TXphTjZQTmErTW5oN1dsUXhtbzNFWjhxcE4yV2d2RGlhbW1aeVNOTFF3eE96?= =?utf-8?B?UnBYVjVwaWRjK3VIUnlWVVptOFZQU0s4T214MWhHVWt3cU1PSlEyb3c0UTRp?= =?utf-8?B?Rzhzc09JbXRQRXZseGJkQVhWbHZ2ZmRzbFFBUXF5bUlBTTM3UGdxbDZxUk16?= =?utf-8?B?SHo1ZkRwR3prWWdOd3FpSmxxNW5oSDBGM2NSejZaSGpTSDRCeVVoK1F2WXQx?= =?utf-8?B?WE5jSUhhNi9zMUlwNnA1MlVPYmpZQ2c1TitHSHJOMmlxd3dPZWtoOGE5eERS?= =?utf-8?B?MDZkaEY0UStRVUFXUVFTY2NjaUZlZWx4Nko1Z3E0NWdPUXVEcjVoUVgzZlBT?= =?utf-8?B?bk1ZYkFvanNXOUswMWF2S24rTi83MDEvVUlEc2kxbStaSytXbkx4ZVBFSGZL?= =?utf-8?B?VnA3REdRbEI5aCtIMGtuK1NpN0ZKcnRyZHNaU0RwSWVBYnBVVzJ0NTI3WUkr?= =?utf-8?B?OERjZGUzVVRiUkpXWkJLQythRlRtTGdId002S0RLS0tlUWx0aStueEFUTW9S?= =?utf-8?B?SFJQdXhiTjJPWHZCMEpwMzMxcHAzNnNWZzFmZlg4L1YrU0JyMlc3YUtBcVc0?= =?utf-8?B?dUxyOUhEVVQ0T2FUbEIvemtVUFpGdDBxYVlSTTFydm9nTzlEU1U3Z2luQWtt?= =?utf-8?B?OEN3QzcvZnZZbFBGSHhyQjJ4VWM4czRQWTFMRGtGVGFHNyt5bFVkbW1adGox?= =?utf-8?B?QmZ3NEMvamlTcjFuZVVpTGJ1dVd5akhQQXNaZW1hQXpWSmhPOHZxbWNmRm1q?= =?utf-8?B?N3V3VjJDOGNkZjAyZC9pNktxYWwrRnZqbllRczFIR216YmJROEhNTDdIbjg3?= =?utf-8?Q?gQxohWVkECnnHLw+PvoTOIif6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee4f1bb-0ede-4b7d-8553-08db997973ea X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:11:51.9402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CIIsp0oAUlwb1ru0U6zrn0KZ3i/JxjBYY4NlEu8zESouplU2gWFmHnMCZWLoH+jJlA24yDxySvqeh2/IrPUOPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7235 On 10.08.2023 10:07, Henry Wang wrote: >> On Aug 1, 2023, at 15:43, Jan Beulich wrote: >> On 01.08.2023 05:44, Henry Wang wrote: >>> From: Penny Zheng >>> >>> SMMU subsystem is only supported in MMU system, so we make it dependent >>> on CONFIG_HAS_MMU. >>> >>> Signed-off-by: Penny Zheng >>> Signed-off-by: Wei Chen >>> Signed-off-by: Henry Wang >> >> While entirely Arm-specific, this looks to require a non-Arm ack: >> Acked-by: Jan Beulich > > Based on the discussion in [1], now CONFIG_HAS_MMU is agreed to be renamed > as CONFIG_MMU, I will do the renaming but I would like to confirm with you that > if I can still take your asked-by tag with such change. Thanks! Yes, that's fine to retain. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:34:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:34:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581909.911368 (Exim 4.92) (envelope-from ) id 1qU17H-0003Gn-R8; Thu, 10 Aug 2023 08:33:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581909.911368; Thu, 10 Aug 2023 08:33:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU17H-0003Gg-No; Thu, 10 Aug 2023 08:33:59 +0000 Received: by outflank-mailman (input) for mailman id 581909; Thu, 10 Aug 2023 08:33:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU17G-0003Ga-DY for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:33:58 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2075.outbound.protection.outlook.com [40.107.13.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ec5d1b2-3758-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:33:45 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB9701.eurprd04.prod.outlook.com (2603:10a6:10:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:33:26 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 08:33:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ec5d1b2-3758-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fN2v9kFvHdGvFINtlIDqZ0Nygd7V7MjP84snU4WXaBj+01iYBkhpfEtUV7w6M1dFf9WZqZvjN9Z+PN2i7n2gfkbLVFtplX3lMreCUiaVc9zZLPuDg+/Mo4OYU0T4Pw2PQFLvXfWwI7J8+IMkvWaV1Nk+JOl/3jbr8yGIqW9/RGC7alzqRjmu6xmsSNo2YlJGfN/gP8BikYsuo1WD3jo1YumhN0KZi1HhYqXzhFg3Hx1KAigHahlgi7MjAx89NQsG+go1e/i4L0h6tX7wRuFlH4fZXvxmnQmQ5NeEMe2CZt9HuTiGIDBx6BCapk/Gj+A6WUHZl0bKHWtPlC2CfAoa2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z3OkJbBC03VMDXwYdmp17cOWGy0bysdttfteuH7xhkg=; b=OnEcLM2QPCYcibQBM0f3ZfxA+v90EXNyQrQoqDnvs/VCpt7lEqQ/qVJUTXqBAyOKBmYynF8t55o7Xj5SBzLamrikNrllPxkB4ZX8SpQq6DsqjmuLoOb6xyu+ERJfSLU5MOk4QLKDsxBsXdRLbsU7GZ7kIrZX/pureb0DE9u9+ZhXLkVAQQXrt9a1QqWoJWiNdVItnGVUbYKZDHvo0Dw82h/oJXn1MdCkaFUk99WkOmcQbS5iv86cIPcmo/MuFmy68T0PceV1S43BYDDZ4FNfW8OWeVWksF00VOMOJ2VmHLkRZ8OjAHimDx2gfFm+QKYxH7UTRfD0d21OspxRdntT7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z3OkJbBC03VMDXwYdmp17cOWGy0bysdttfteuH7xhkg=; b=FBZV6wMIwrYqNRWUTph0SzordFgBJMSQHkeZqTVgjLe9vFCdxTsxTGQF9AMQBzTpRraOIu/gFpMNKiREjnF2nyOoPEKL3f1BytyeOznnCtXj81BtYd8pXi/ZgJqC5MXGJ6O0aUjooh0gbvwBihgKtvPpYCUXKYP2oKoZb6GgH2WiP4CYCKrLRyVSWfAJasLqby4SHrp4nld46NVipzShBzwecQwLAb9fPdAMqfB+P11Sm9YIbvSS0u6J3ZMC7o9G20LvIDsazigDAPfqn51HSFKGi39QgrL2rsZ3y6CbaOkO1id5Pk+ViYms60NF1mh2CXpjf+xY+m1bIPIuDcTu/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 10:33:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4 To: Stefano Stabellini Cc: Nicola Vetrini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <41edfbbbc8fae317ebee791633259d7b5c88a2c6.1691575243.git.nicola.vetrini@bugseng.com> <1cfa92d52d89b2013218cef1c518ab4d@bugseng.com> <30cd1bdb-be77-a192-eca7-6fcd60eca610@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB9701:EE_ X-MS-Office365-Filtering-Correlation-Id: 068b13c1-3f47-4ed4-0302-08db997c7725 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 69o1cNUiQrK6cM612r3zI1VJHClOktwO1PKG1nJwpuHo4lXl2/6ieMLjzoxfhCPQor93/miG8cDvQWTej5QP12V4F6OVvXyvkG0vYOGP+kInAVxeDVIzLi2NI1uEUsnSLLCSWRqgdN3WhK54SRi6MfQZur965+7qD8RCE+bDAQHjrj7YxPsUSW1M4FFooNG99G7XSCDaXHSYDtHzSJcCyJAz0382hDatYyTeQC2rkyq1RXBxECLHgzlmt1spSv1lGCLw4n+yv2egdhLrFtxur52q+TFv9ZrIapZ36lb4nzEBQhnOEZfxq6LyuI7CrqDd7TcJUvUReGiw7ESs9aciIIWqAwxBNb/WRPSQE2hmM5oJ1yQQLiNFEnV0uwJt9tynmlUhC3W6MaLtZuVyVq9L4EMlu2Euhfb6N9KBFuzfCy5hqmrGjmiJf0OYMzykTJzq0JYPcV6M61TGKM7+KLaesY0bQ3O+tPYuTlSiJW81duEbo9QB8+on/3/vWmuxj+/VA2vh77q//OzH0cehHcTW3AxdBkzwu7csxdhlV9XWGghEI1Yhcb3xDq7U4+qryDb8xRwqagKl1SCOiuKsiJSOQB56agr7myJWCILjl/cOTfOJkxAB2P7uQEl1a8YmNCkv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(376002)(396003)(39860400002)(136003)(186006)(451199021)(1800799006)(54906003)(2906002)(53546011)(6512007)(36756003)(6506007)(966005)(26005)(31696002)(86362001)(6486002)(478600001)(2616005)(66946007)(6916009)(316002)(4326008)(66556008)(8676002)(66476007)(8936002)(7416002)(5660300002)(41300700001)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2ZXekJkZzY4dm1RRk9GRTZiMWttU095Y0pZUS94Rm1vVkJ0QUh1UXk1UEti?= =?utf-8?B?YlgvYTNJQW9uT2dsWWhnamlYVE5GMmxuTXlGb2dYcmE5Ujg0V2V0a0tody9u?= =?utf-8?B?MWxsMU1xUXZ1SjFxZTFWVmozdHFFZkFxa0xIcmxTdHI4VWQ5cC9GY2lhVkdG?= =?utf-8?B?UEY2QTNtN3JncFVKd1pWRnY3bmllbksxdSsrYmJ3U0hXQWVna2FYOUpJMXlU?= =?utf-8?B?WGwxNGFoV2twVUtpbjZZSUlsTmY0QjcxdEI4Qi95Uldhd3dLK21XWDBhYW9W?= =?utf-8?B?NHZSbFF0RE01MEw4ZSt3cWVNMVJBRkxlTE96NHF0MGR4UzBsNmIyRHQyc3I0?= =?utf-8?B?UnZya21mNTJiTUh6RzhrNERJNlNBRldoYUoxL0I4V2djV2paL0w5UU0vaFd0?= =?utf-8?B?NXFqQ1kvM0VkVTlhYUlISWlwc1o1bnVqcjJrcUxZYUdSV2xRS0xhWVlHR2dV?= =?utf-8?B?bWZQdHU2bG5vRjhrNW9pWWdMOE8rRTZla01VY0prd0VBbytaQVBOVldvSUV5?= =?utf-8?B?L1Zxc1RKaE03MHRzeWIzUTFiQ0VWZTZsYjUyM1c4UEdJTDZWVVZRZnhiUzNz?= =?utf-8?B?ejJaTmlWaHRuN1JmUTM4ZWwyR2tHYkRuaWFteUc3RVgraUxqMjZ1U2xIdTZa?= =?utf-8?B?SmhEMTQ5SklSQ2xHbVM3Ky9PVm15Ni9nWlMyQzJnMmtKTzR5VXZJaVY1Mm5l?= =?utf-8?B?dEZNMVAvQXpZalF6YTVuL3VoMjhUTzBwdk1Oc3Z3cXgxSTg1bG9MaEUwZmFG?= =?utf-8?B?NE9wUmpGc0dQVlBBMTFnUXhSaGxoK0dsUGxHcVhMeFpnUTZWaVpjR2UzdUpT?= =?utf-8?B?VU9uWUE5ZytnaHlCMk9ENHJMZ0d4a2xMSDcvblZCakdTR09TQVRVdWc4eVRT?= =?utf-8?B?allld0VYVG4zTVpLZTh6SFBCOE9JbXM4MWRlUkxKYVJNeGlBR2wyZDFFY3V6?= =?utf-8?B?L3dsQ0RZazBsVWJjTGZzeFFqYmFyYlZraVpObSszdnV6S1RJUWVNclRIMXdQ?= =?utf-8?B?cTMrdU9HaG83RktUSXR5V2Z1SGZ5NWpCRGpJTEVaZkJ4UEtEc291OEdGRTcz?= =?utf-8?B?OTNnYmxXeCtaYVNyR05YQVIxNTczRjFhZGdiQllhRC9GUG1TZEE3VnpmNTNS?= =?utf-8?B?THVnTFdKNSt2NTRlcWR1MnNlb1UwZmVBTHl3cisvUWJZZUtqeDEvMFBrV0pi?= =?utf-8?B?TUFoYi9GTHJlNzBSRU52WkVYZStURWVFblFSNzlhUU02bml4TnlQbjdNWjBD?= =?utf-8?B?MG1IdmR2c0JuQ3ErdFFYTUE3UTk5SnRSUVFhKytUSmtrd0gxVjVRQ3JwcFJj?= =?utf-8?B?dDNVT2QzSlF4M3kxa3c1VmZSSUtncG83MW1KV3ZQdXUyTlFONDIzR0wvL3F0?= =?utf-8?B?TVo3NmJodGJZM2dqMUluYk92M3M3RWxXZzU3YnVxYnkzNEptOHZyRUJqQUdL?= =?utf-8?B?VUtpa0hYWlpXaGozSHpScXFhYWNNcnA2SXhsamRhalJjamlDck1qMU5xd3Q4?= =?utf-8?B?VS93aEdMV0VucFRyeVE5RXhEVXVudnZ3UjVzZGVuaTlHMGxPNy9kNGhTdHE4?= =?utf-8?B?VHR4UVk5YVc0UUtIK0o0eDVDWWpSRERIUG9aZjFpbk5zVEI2ZFZ4bEZ5WG1w?= =?utf-8?B?UEp5eFg0QnZwM2Z5WWRjV2EyWHMyUFZwejUwd2ZTN2FzaDFMU1V1U0JEaksx?= =?utf-8?B?S2FxTVpmejN2cm5QSFZ2VHZiOXgxQ0hyUnllNEtZSG9zYytxVWVqUENkYSt5?= =?utf-8?B?ZjdMckRLbFFFNmxpNEs5a1FzUEUxK0x4bU1HZzh6ZENVc25XZGVDV3B5MWtz?= =?utf-8?B?ZzFUS2VQS2pGQkVKb2JnTVdSSDMyU3BwRkV5cWJobVZSWjM4UDEyWHU2eEpF?= =?utf-8?B?NEN1VytxeUxlMFpFbng3WVdHMXJ0TFljVlJIMG9Nc3g4VmVCdE5rSjRLbFVr?= =?utf-8?B?UUpFS05nMVRrVFhBek1kNDJMdU1DWFVGNCtWZDVtbW11NWRrMFQ4NGc0QmQ0?= =?utf-8?B?TnVTeEtxMTVab1J3RlphWCttajZ2Q3BKSDZxNXhaV05vdHgzR1QvenU4NVkw?= =?utf-8?B?Q3RmbVZmRzBUYlRHSytKbWM2VjJlUHE4Vlc0cmNxWkx4OXVycE41UjdhQnAw?= =?utf-8?Q?lM5gc15bdbz8qyR/hDcZSvL3k?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 068b13c1-3f47-4ed4-0302-08db997c7725 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:33:25.8244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9OmF55/a+qBbiCkFcIqD/lD9QD9tI6tsJimRh/PhuGZFHB8GzkW1cEx0ummc4hxUswbx6coKMladloVoT3SGKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9701 On 09.08.2023 22:15, Stefano Stabellini wrote: > On Wed, 9 Aug 2023, Jan Beulich wrote: >> On 09.08.2023 16:17, Nicola Vetrini wrote: >>> On 09/08/2023 14:52, Jan Beulich wrote: >>>> On 09.08.2023 13:02, Nicola Vetrini wrote: >>>>> The additional header file makes the declaration for the function >>>>> 'init_IRQ', defined in this file visible, thereby resolving the >>>>> violation of Rule 8.4. >>>>> >>>>> No functional change. >>>>> >>>>> Signed-off-by: Nicola Vetrini >>>>> --- >>>>> xen/arch/x86/i8259.c | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c >>>>> index 6b35be10f0..9b02a3a0ae 100644 >>>>> --- a/xen/arch/x86/i8259.c >>>>> +++ b/xen/arch/x86/i8259.c >>>>> @@ -19,6 +19,7 @@ >>>>> #include >>>>> #include >>>>> #include >>>>> +#include >>>>> #include >>>>> #include >>>> >>>> A patch adding this #include has been pending for almost 3 months: >>>> https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html >>> >>> So do you prefer going forward with that patch or this one (mentioning >>> it >>> in the additional commit context of course)? >> >> I would prefer using the much older patch, but of course this requires >> someone providing R-b or A-b. > > Hi Jan, normally I'd be happy to do that but that patch makes other > changes that I don't feel confident enough to Ack. I understand that in general, but for this specific case ... > For instance: > > + for ( offs = 0, i = pic_alias_mask & -pic_alias_mask ?: 2; > + offs <= pic_alias_mask; offs += i ) > > pic_alias_mask is declared as unsigned int. ... you're concerned of me negating it? That's a common pattern to determine the largest power-of-2 factor. I'm unaware of a good alternative. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:38:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:38:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581916.911377 (Exim 4.92) (envelope-from ) id 1qU1Bo-0003xe-GV; Thu, 10 Aug 2023 08:38:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581916.911377; Thu, 10 Aug 2023 08:38:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1Bo-0003xX-Dw; Thu, 10 Aug 2023 08:38:40 +0000 Received: by outflank-mailman (input) for mailman id 581916; Thu, 10 Aug 2023 08:38:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1Bm-0003xR-TM for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:38:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0631.outbound.protection.outlook.com [2a01:111:f400:fe1f::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4cc70348-3759-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:38:37 +0200 (CEST) Received: from DU2PR04CA0031.eurprd04.prod.outlook.com (2603:10a6:10:234::6) by AS2PR08MB10128.eurprd08.prod.outlook.com (2603:10a6:20b:644::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:38:35 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:234:cafe::7e) by DU2PR04CA0031.outlook.office365.com (2603:10a6:10:234::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 08:38:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 08:38:34 +0000 Received: ("Tessian outbound d7adc65d10b4:v145"); Thu, 10 Aug 2023 08:38:34 +0000 Received: from de9826d7aad7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DD9885AC-D492-488F-9F0A-AEF804E63272.1; Thu, 10 Aug 2023 08:38:06 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id de9826d7aad7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 08:38:06 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by PAVPR08MB9062.eurprd08.prod.outlook.com (2603:10a6:102:32d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 10 Aug 2023 08:38:04 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 08:38:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cc70348-3759-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cO2tgQkAdBjGa/uthO+eyDrq7JXwsMYpicKrL8pKHco=; b=t99fSbHyJpNGBnnntSLfNlUswvGU6pu5F9vGq4lf8ULVrNx7u8o6OvnKSFECA+ismoj/kSnL0vlczJJ3A2gJWkk+hwJZbm+Y8XeZHzilGNn2Rq+iYN07vluox5eX6Ty6OohL9SWc2s8GlNMrEFyk+5l+OjH23aahDIQlciNCYuE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3f20c3922870d8ac X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AsYySa/g7NuGGbb77CoT8DD6CF4ZNSNBf1SKGOnTKfmOol8FSuU8ZAYg58AGclpv+kbN1l8bkb/wrBPT74s6EynaYlrhJn6ToxYfOulex9cknroj4+rI4qavrsS5IBbHRFHJBBx/VrJDyfOIusuWaUz8UADYS4Sf66/QhSUhHpOaQ2Qsv5mFVc/oHj7I70Mbjd6/hgY8hN5WW71BL8VjfB0LIrmvHFGpKnE+2Yo0oE4JDUDa6ZiNeYsJcUtXFJrlK9E3pLbbMcJf392K6J55zNTrXWa0AcXZLaM68TMJsU/7/tVuhHJeJCKuAy3QDPGHRmcNFBeu3HVqbY5USwj9gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cO2tgQkAdBjGa/uthO+eyDrq7JXwsMYpicKrL8pKHco=; b=efdxFPQ281aX4z+XXvsXlSp1Of6Tq/vLIJNCqQb17jhgTUDzmfJ5c/DFT4wC7JAYoQQlZrzJVgJRkh3tW+6I7n9ZYpgJUUt7CmZbWKH5Sz0DOhNhfbW6NDusTcgt6MyllanEqg6F0wgGRZJpmRVigSQcQXY3hXEZaLIi59ThGSbYJc2XlYvd/OqEH97oGTyUEHKYtc9GW02rjf5eA6k8Mmhdv5eNzx46DzqMlSg8EVmxnOAg35dNE1ubXD6q9eAZxQlzZEvFNzYQY7+40m2IB6vBs+BlEJaSYn4rNJrIeyqJf7DGlKQ5QsnHmCpOngVzxhpjztEO2aRNvV518lxwtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cO2tgQkAdBjGa/uthO+eyDrq7JXwsMYpicKrL8pKHco=; b=t99fSbHyJpNGBnnntSLfNlUswvGU6pu5F9vGq4lf8ULVrNx7u8o6OvnKSFECA+ismoj/kSnL0vlczJJ3A2gJWkk+hwJZbm+Y8XeZHzilGNn2Rq+iYN07vluox5eX6Ty6OohL9SWc2s8GlNMrEFyk+5l+OjH23aahDIQlciNCYuE= From: Luca Fancellu To: Jan Beulich CC: Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 5/5] xen: Add clang-format configuration Thread-Topic: [RFC PATCH 5/5] xen: Add clang-format configuration Thread-Index: AQHZwStJjnl5s/6RqkyuxqTMVBpDCK/iL4wAgAAIMgCAAQm9gIAACB2A Date: Thu, 10 Aug 2023 08:38:04 +0000 Message-ID: <7219AAB4-7218-405F-8B4E-D9F3E54213EA@arm.com> References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-6-luca.fancellu@arm.com> <3c5ae070-d6c2-070c-e482-e5135e2acef1@suse.com> <394778DB-2D5E-4C52-9DA1-F23A530534A8@arm.com> <9743391f-3b89-ddba-1c79-ddbb1d143437@suse.com> In-Reply-To: <9743391f-3b89-ddba-1c79-ddbb1d143437@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|PAVPR08MB9062:EE_|DBAEUR03FT046:EE_|AS2PR08MB10128:EE_ X-MS-Office365-Filtering-Correlation-Id: c8bd083e-224b-40ae-b919-08db997d2f7f x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8NYmK8eCNpqaaFY4os2IN4VCLdwaiw8vDPqN57fGcMbrTCmWH16Vm7JcLiJpEVPBUldYE++6qkL7u8d7ZCfYlhGzYoTFQ2Yo+013uveWg8/JTVzRS+c+bpqKzlciWaHaltaicfdAgtdaH/ml8CaTb2fb+M8xyUkvDdbWaVGIoP4r+sC+ZD7YQejWdTbmgXXfPXRoc1zOhJNbMzBuOQI0g7MSfLdc3PypE8/uquXDM4bYlzrCWtNL1W0nka2tdONRPk4zx9P3kkSxw0g3nReU5lSJWD7FPG8i6tG/asCe/6z1LVxjBpThOu7NH3lGuk3J5EvuG+KxNXQE1HZA3S/aG0qYLBqNqOsECXan9LQvcGzTmq326ZbdAsdqPg1htSGFWTZY5gMdq35QR+DEcE1zTAWzgBIqE3QjRoO4uIv8JzpElg8IgRBlg3aRWJ8INV8F3idrQOotkiPhYJDF4w3pG8biYYsQf/vWjR+HlwIpvRDU6rCD54wE8krBH05NOlEUN0dc/1nkrg1yPk72adruj67e16jcMtCqe3QCB2yv8RJmm8PoJC7zVjNm0xHbzSk82S+3rcu7R/9yLG7cdtHGliBkcD/Qv+d0NT94KYf3G24wvyRPlgHJ7XTOirFf9oGD+Fu2qwzc72kXNAOi1Aa1/DwdXCqrrl1U2tg5S3z4aApjN36ukB0ZS1OOwyROdhFJs4Bg9stotQAkpBq9gwtFVg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(451199021)(186006)(1800799006)(2616005)(6916009)(36756003)(6512007)(966005)(4326008)(316002)(122000001)(86362001)(54906003)(66556008)(478600001)(38100700002)(66946007)(76116006)(91956017)(66446008)(6486002)(71200400001)(33656002)(53546011)(66476007)(64756008)(6506007)(26005)(8676002)(38070700005)(8936002)(41300700001)(2906002)(5660300002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9062 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e4445f3f-6e5b-4877-002c-08db997d1d18 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wsj+svH5HxqpBTvmOPHO9LJQP4aLJMwfqVjT3BDDOJsXUwKmGOZIs+Eop0P3yhquzN2fc08uNZPeOFYNwLtiy5CD0SVmBvq5e/OKGTPFDtXVldQRFcu8pRQaWAUy/knWKWI49k9ZHEjj6ivG5+6o/EBF5pZrRsBIoZ5Wzac1MsopcmFp03x4FlQiu+iXz7hoTi+PjEXk+TPQ2N1Pee3GYFfNvUjyIqbnZBKN/XCPYnAPKuS37lEZ7gKaXRrUTsmRWScT8NrIQpfNia5XPjsthc6Z4CZD9sSTKgDqL+N7fKCQkU8+vDlMSJ1WHxFBd4NOs2TjKe2P+53FQfLjUXs5m1I82CGTf/b6TeQKrIPpZ6TopZb23OuFTbPQ2gD6bofC8uUrTK/Cr1jKJqRQRuyxj55XiEWd2m9At3UexC869qx3idDyworkXMXEyxvFi6NIjZokml5fBuSm7nH7lhgbjbbc93vU1q0t8sdkFICoC1p7fpXxqdTF+W3IitWoWnf1mjwio93/PLHXRtKBYvEL0/O8R5Aw21b4hP2noFBalR3KaQNuakBz4FPFsil5Mu6nNVLO9yVR551zLXNyHfzno/U3RAtopQmUhCsmjNTtfjVEC3/IzALsq2wsAnjNzS2PzY6E6vW3ul2pDV1QiKLRiYYiuw9XRSzvyxSlbSEnvYm9H2Xw94YIvUIiCSyLDjDGKcOEk+d+tZjeSZIa/jD8QrFeRxco2rtMEVbD33bU6Lkt3zoV9+tAUFaS8ECk/pyU X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(376002)(346002)(396003)(1800799006)(186006)(82310400008)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(40480700001)(70206006)(70586007)(336012)(54906003)(6506007)(53546011)(26005)(478600001)(36756003)(33656002)(47076005)(2616005)(36860700001)(316002)(41300700001)(6512007)(4326008)(6486002)(966005)(2906002)(8936002)(8676002)(86362001)(81166007)(82740400003)(356005)(5660300002)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:38:34.9762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8bd083e-224b-40ae-b919-08db997d2f7f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB10128 DQoNCj4gT24gMTAgQXVnIDIwMjMsIGF0IDA5OjA4LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMDkuMDguMjAyMyAxODoxOCwgTHVjYSBGYW5jZWxsdSB3 cm90ZToNCj4+PiBPbiA5IEF1ZyAyMDIzLCBhdCAxNjo0OCwgSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPiB3cm90ZToNCj4+PiBPbiAyOC4wNy4yMDIzIDEwOjExLCBMdWNhIEZhbmNlbGx1 IHdyb3RlOg0KPj4+PiAtLS0gL2Rldi9udWxsDQo+Pj4+ICsrKyBiL3hlbi8uY2xhbmctZm9ybWF0 DQo+Pj4+IEBAIC0wLDAgKzEsNjkzIEBADQo+Pj4+ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVy OiBHUEwtMi4wLW9ubHkNCj4+Pj4gKyMNCj4+Pj4gKyMgY2xhbmctZm9ybWF0IGNvbmZpZ3VyYXRp b24gZmlsZS4gSW50ZW5kZWQgZm9yIGNsYW5nLWZvcm1hdCA+PSAxNS4NCj4+Pj4gKyMNCj4+Pj4g KyMgRm9yIG1vcmUgaW5mb3JtYXRpb24sIHNlZToNCj4+Pj4gKyMNCj4+Pj4gKyMgICBEb2N1bWVu dGF0aW9uL3Byb2Nlc3MvY2xhbmctZm9ybWF0LnJzdA0KPj4+PiArIyAgIGh0dHBzOi8vY2xhbmcu bGx2bS5vcmcvZG9jcy9DbGFuZ0Zvcm1hdC5odG1sDQo+Pj4+ICsjICAgaHR0cHM6Ly9jbGFuZy5s bHZtLm9yZy9kb2NzL0NsYW5nRm9ybWF0U3R5bGVPcHRpb25zLmh0bWwNCj4+Pj4gKyMNCj4+Pj4g Ky0tLQ0KPj4+PiArDQo+Pj4+ICsjIFtub3Qgc3BlY2lmaWVkXQ0KPj4+PiArIyBBbGlnbiBmdW5j dGlvbiBwYXJhbWV0ZXIgdGhhdCBnb2VzIGludG8gYSBuZXcgbGluZSwgdW5kZXIgdGhlIG9wZW4g YnJhY2tldA0KPj4+PiArIyAoc3VwcG9ydGVkIGluIGNsYW5nLWZvcm1hdCAzLjgpDQo+Pj4+ICtB bGlnbkFmdGVyT3BlbkJyYWNrZXQ6IEFsaWduDQo+Pj4gDQo+Pj4gSSdtIG5vdCBjb252aW5jZWQg dGhpcyBydWxlIChhc3N1bWluZyBJJ20gZ2V0dGluZyBpdCByaWdodCkgaXMNCj4+PiBzdWl0YWJs ZSBpbiBhbGwgY2FzZXMsIGVzcGVjaWFsbHkgZm9yIGZ1bmN0aW9ucyB3aXRoIGxvbmcgbmFtZXMg b3INCj4+PiB2ZXJ5IG1hbnkgcGFyYW1ldGVycy4NCj4+IA0KPj4gTm90IHN1cmUgSSB1bmRlcnN0 YW5kLCBJIHRoaW5rIHRoaXMgaXMgdGhlIGN1cnJlbnQgYmVoYXZpb3VyIGluIHRoZSBjb2RlYmFz ZSBub3cuDQo+IA0KPiBNeSB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgdGhlIGFib3ZlIGFpbXMgYXQg KG9ubHkpDQo+IA0KPiB1bnNpZ25lZCBsb25nIGZ1bmN0aW9uKHVuc2lnbmVkIGxvbmcgZmlyc3Rf bG9uZ19hcmd1bWVudCwNCj4gICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgc2Vj b25kX2xvbmdfYXJndW1lbnQpOw0KPiANCj4gd2hlbiB3ZSBhbHNvIHBlcm1pdA0KPiANCj4gdW5z aWduZWQgbG9uZyBmdW5jdGlvbigNCj4gICAgdW5zaWduZWQgbG9uZyBmaXJzdF9sb25nX2FyZ3Vt ZW50LA0KPiAgICB1bnNpZ25lZCBsb25nIHNlY29uZF9sb25nX2FyZ3VtZW50KTsNCg0KT2hoIG9r IG5vdyBJIHNlZSB3aGF0IHlvdSBtZWFudCENCg0KSSBkaWQgdHJ5IHRoaXMsIG9rIHN1cmUgaXQg d2lsbCBmb3JtYXQgaXQgYXM6DQoNCnVuc2lnbmVkIGxvbmcgZnVuY3Rpb24odW5zaWduZWQgbG9u ZyBmaXJzdF9sb25nX2FyZ3VtZW50LA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGxvbmcgc2Vjb25kX2xvbmdfYXJndW1lbnQpOw0KDQpCZWNhdXNlIGl0IHNl ZXMgdGhhdCBpdCB3aWxsIGZpdCB0aGUgODAgY2hhcnMuDQoNCkF0IHNvbWUgcG9pbnQgSSB0aGlu ayB3ZSBuZWVkIHRvIG92ZXJjb21lIHRoZSB1bmNlcnRhaW50eSBhbmQgY2hvc2UgYSBzaWRlLCBv bmx5DQpmcm9tIHRoZXJlIHdlIGNhbiBiZW5lZml0IGZyb20gYW4gYXV0b21hdGljIGNoZWNrZXIg YW5kIHdlIGNhbiBnZXQgcmlkIG9mIHN0eWxlIGlzc3VlcyAobW9zdCBvZiB0aGVtKS4NCg0KVW5m b3J0dW5hdGVseSBtb3N0IG9mIHRoZSB0aW1lIHdlIGNhbuKAmXQgc2F5IHRvIHRoZSB0b29sOiB3 ZSBwZXJtaXQgdGhpcyBzdHlsZSBidXQgYWxzbyB0aGlzIHN0eWxlLCANCm9ubHkgb25lIGNhbiBi ZSBhbGxvd2VkIGFuZCBqdXN0IGZldyBkaXNjcmVwYW5jeSBtaWdodCBiZSBkZXZpYXRlZCBpZiBw cm9wZXJseSBqdXN0aWZpZWQgKGluLWNvZGUgY29tbWVudHMpLg0KDQpJIGd1ZXNzIHRoaXMgaXMg dGhlIG9ubHkgd2F5IHRvOg0KMSkgaGF2ZSBhIGZvcm1hbGlzZWQgY29kaW5nIHN0eWxlDQoyKSBo YXZlIGFuIGF1dG9tYXRpYyBjaGVja2VyDQozKSB1bmlmeSB0aGUgaHlwZXJ2aXNvciBjb2RlYmFz ZSBzdHlsZSwgdGhhdCB3aWxsIGRpdmVyZ2UgKG1vcmUgdGhhbiBub3cpIHZlcnkgcXVpY2tseSB3 aXRoIHRoZSBpbnRyb2R1Y3Rpb24NCiAgICBvZiBuZXcgYXJjaCBhbmQgZmVhdHVyZXMNCg0KQ2hl ZXJzLA0KTHVjYQ== From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581924.911400 (Exim 4.92) (envelope-from ) id 1qU1DI-0005Yp-Fn; Thu, 10 Aug 2023 08:40:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581924.911400; Thu, 10 Aug 2023 08:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DI-0005XO-BK; Thu, 10 Aug 2023 08:40:12 +0000 Received: by outflank-mailman (input) for mailman id 581924; Thu, 10 Aug 2023 08:40:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DH-0005MW-AQ for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 844667fe-3759-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:40:10 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id B79434EE0743; Thu, 10 Aug 2023 10:40:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 844667fe-3759-11ee-b283-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: [XEN PATCH v2 3/7] xen/include: make a declaration of 'get_sec' visible where needed Date: Thu, 10 Aug 2023 10:39:43 +0200 Message-Id: <37fed394315c24e7b7419e564696a534886f0d53.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A declaration for 'get_sec' is added in 'xen/include/xen/time.h' to be available for every call site (in particular 'cper.h'). This also resolves a violation of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: c8cb30cfc87a ("mce: Provide ERST interface") --- Changes in v2: - Revised commit message - Split patch --- xen/include/xen/cper.h | 3 +-- xen/include/xen/time.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/cper.h b/xen/include/xen/cper.h index 7c6a4c45ce32..de8f385bdd5c 100644 --- a/xen/include/xen/cper.h +++ b/xen/include/xen/cper.h @@ -23,8 +23,7 @@ #include #include - -extern unsigned long get_sec(void); +#include typedef struct { uint8_t b[16]; diff --git a/xen/include/xen/time.h b/xen/include/xen/time.h index 5aafdda4f392..67c586b7369c 100644 --- a/xen/include/xen/time.h +++ b/xen/include/xen/time.h @@ -36,6 +36,7 @@ s_time_t get_s_time_fixed(u64 at_tick); s_time_t get_s_time(void); unsigned long get_localtime(struct domain *d); uint64_t get_localtime_us(struct domain *d); +unsigned long get_sec(void); struct tm { int tm_sec; /* seconds */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581923.911393 (Exim 4.92) (envelope-from ) id 1qU1DI-0005QS-4p; Thu, 10 Aug 2023 08:40:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581923.911393; Thu, 10 Aug 2023 08:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DI-0005Q1-1L; Thu, 10 Aug 2023 08:40:12 +0000 Received: by outflank-mailman (input) for mailman id 581923; Thu, 10 Aug 2023 08:40:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DG-0005Mc-LE for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:10 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ca5e8bd-3759-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:39:58 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 030544EE073F; Thu, 10 Aug 2023 10:40:06 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ca5e8bd-3759-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [XEN PATCH v2 0/7] fix missing headers and static storage duration Date: Thu, 10 Aug 2023 10:39:40 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The files touched by this series contain function or variable definitions with no prior declaration visible, because it's inside an header that is not included or it's not present anywhere. This is a risk in itself, but also violates MISRA C:2012 Rule 8.4, which states the following: "A compatible declaration shall be visible when an object or function with external linkage is defined". The resolution strategies are as follows: 1. make the functions/variables static 2. include the header that contains the compatible declaration, or add one in the header if that's not the case. No functional change. Additional notes: - other cases, such as functions/variables used only in asm code will be possibly dealt with in future patches. - functions in 'gcov_base.c' are deviated, since they are called only from code generated by gcc in a particular non-release build configuration; - variables in 'xen/include/acpi/acglobal.h' are deviated temporarily, since it's uncertain whether modifying the include pattern to be compliant with the rule would introduce subtle bugs. --- Changes in v2: - Modified commit messages, with additional "Fixed" tags and mention that these are bugfixes - Split patch 4/8 of the previous version - Drop patch 7/8 of the previous version, because it's already addressed by this patch [1] [1] https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html Nicola Vetrini (7): xen/memory: make 'ioreq_server_max_frames' static xen: make 'saved_cmdline' static xen/include: make a declaration of 'get_sec' visible where needed xen/arm: make declarations visible before function definitions x86: make some functions and variables static rather than extern xen/arm: mm: add missing extern variable declaration x86/nmi: include missing header with declarations for 'watchdog_*' xen/arch/arm/include/asm/mm.h | 3 +++ xen/arch/arm/setup.c | 1 + xen/arch/arm/time.c | 1 + xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- xen/arch/x86/cpu/microcode/core.c | 2 +- xen/arch/x86/nmi.c | 3 ++- xen/arch/x86/spec_ctrl.c | 4 ++-- xen/common/kernel.c | 2 +- xen/common/memory.c | 2 +- xen/include/xen/cper.h | 3 +-- xen/include/xen/time.h | 1 + 12 files changed, 16 insertions(+), 10 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581925.911408 (Exim 4.92) (envelope-from ) id 1qU1DI-0005gt-SF; Thu, 10 Aug 2023 08:40:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581925.911408; Thu, 10 Aug 2023 08:40:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DI-0005gS-M5; Thu, 10 Aug 2023 08:40:12 +0000 Received: by outflank-mailman (input) for mailman id 581925; Thu, 10 Aug 2023 08:40:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DH-0005Mc-Aj for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d9acf43-3759-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:39:59 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D242D4EE0742; Thu, 10 Aug 2023 10:40:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d9acf43-3759-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Luca Fancellu Subject: [XEN PATCH v2 2/7] xen: make 'saved_cmdline' static Date: Thu, 10 Aug 2023 10:39:42 +0200 Message-Id: <3a3f56b54b7051a9a741f5b54e8bc266b451c5e4.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable 'saved_cmdline' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. Signed-off-by: Nicola Vetrini Fixes: e6ee01ad24b6 ("xen/version: Drop compat/kernel.c") Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v2: - Revised commit message --- xen/common/kernel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index fb919f3d9c38..52aa28762782 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -28,7 +28,7 @@ CHECK_feature_info; enum system_state system_state = SYS_STATE_early_boot; -xen_commandline_t saved_cmdline; +static xen_commandline_t saved_cmdline; static const char __initconst opt_builtin_cmdline[] = CONFIG_CMDLINE; static int assign_integer_param(const struct kernel_param *param, uint64_t val) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581922.911387 (Exim 4.92) (envelope-from ) id 1qU1DH-0005N1-RT; Thu, 10 Aug 2023 08:40:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581922.911387; Thu, 10 Aug 2023 08:40:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DH-0005Mu-Oi; Thu, 10 Aug 2023 08:40:11 +0000 Received: by outflank-mailman (input) for mailman id 581922; Thu, 10 Aug 2023 08:40:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DF-0005MW-Om for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:09 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 833e8d0a-3759-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:40:09 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 03E094EE0741; Thu, 10 Aug 2023 10:40:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 833e8d0a-3759-11ee-b283-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu , Luca Fancellu Subject: [XEN PATCH v2 1/7] xen/memory: make 'ioreq_server_max_frames' static Date: Thu, 10 Aug 2023 10:39:41 +0200 Message-Id: <7f0d3f4330a262ec17029b3d82a7a89409215fbf.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The function 'ioreq_server_max_frames' can be defined static, as its only uses are within the same file. This in turn avoids violating Rule 8.4 because no declaration is present. No functional change. Signed-off-by: Nicola Vetrini Fixes: 9244528955de ("xen/memory: Fix acquire_resource size semanticsâ€) Reviewed-by: Luca Fancellu Acked-by: Stefano Stabellini --- Changes in v2: - Revised commit message --- xen/common/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index c206fa48087d..b1dcbaf551e6 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -1120,7 +1120,7 @@ static long xatp_permission_check(struct domain *d, unsigned int space) return xsm_add_to_physmap(XSM_TARGET, current->domain, d); } -unsigned int ioreq_server_max_frames(const struct domain *d) +static unsigned int ioreq_server_max_frames(const struct domain *d) { unsigned int nr = 0; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581926.911428 (Exim 4.92) (envelope-from ) id 1qU1DL-0006O6-2Y; Thu, 10 Aug 2023 08:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581926.911428; Thu, 10 Aug 2023 08:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DK-0006Nx-UF; Thu, 10 Aug 2023 08:40:14 +0000 Received: by outflank-mailman (input) for mailman id 581926; Thu, 10 Aug 2023 08:40:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DJ-0005Mc-0J for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7e89fe20-3759-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:40:01 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 97BB84EE0744; Thu, 10 Aug 2023 10:40:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e89fe20-3759-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [XEN PATCH v2 4/7] xen/arm: make declarations visible before function definitions Date: Thu, 10 Aug 2023 10:39:44 +0200 Message-Id: <05f4dd673312ddd52dcbc8a3b7bcf0ee84993d6e.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 'xen/hypercall.h' is included in 'xen/arch/arm/setup.c' to allow the declaration of 'arch_get_xen_caps' to be visible when defining the function. The header 'xen/delay.h' is included in 'xen/arch/arm/time.c' to allow the declaration of 'udelay' to be visible. Signed-off-by: Nicola Vetrini Fixes: 7cfc339cbc2f ("arm: Implement arch_get_xen_caps") Fixes: 335ba242c55c ("arm: implement udelay()") Reviewed-by: Stefano Stabellini --- Changes in v2: - Revised commit message - Split patch --- xen/arch/arm/setup.c | 1 + xen/arch/arm/time.c | 1 + 2 files changed, 2 insertions(+) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index bbf72b69aae6..44ccea03ca14 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 0b482d7db30c..3535bd8ac7c7 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581927.911433 (Exim 4.92) (envelope-from ) id 1qU1DL-0006Qm-Hm; Thu, 10 Aug 2023 08:40:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581927.911433; Thu, 10 Aug 2023 08:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DL-0006Pr-7X; Thu, 10 Aug 2023 08:40:15 +0000 Received: by outflank-mailman (input) for mailman id 581927; Thu, 10 Aug 2023 08:40:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DJ-0005MW-Ap for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8582d30c-3759-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 10:40:12 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 004BE4EE0746; Thu, 10 Aug 2023 10:40:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8582d30c-3759-11ee-b283-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Luca Fancellu Subject: [XEN PATCH v2 6/7] xen/arm: mm: add missing extern variable declaration Date: Thu, 10 Aug 2023 10:39:46 +0200 Message-Id: <228fc4768f50ea14c38b77f9e2169b76f365617d.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a declaration for the variable 'init_ttbr' to resolve the violation of Rule 8.4 present the relative source file 'mm.c'. No functional changes. Signed-off-by: Nicola Vetrini Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring up") Reviewed-by: Luca Fancellu Reviewed-by: Stefano Stabellini --- Changes in v2: - Revised commit message --- xen/arch/arm/include/asm/mm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 2db8535a4ca8..aaacba3f044b 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -165,6 +165,9 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated +/* Non-boot CPUs use this to find the correct pagetables. */ +extern uint64_t init_ttbr; + extern mfn_t directmap_mfn_start, directmap_mfn_end; extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581928.911439 (Exim 4.92) (envelope-from ) id 1qU1DM-0006Yj-0G; Thu, 10 Aug 2023 08:40:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581928.911439; Thu, 10 Aug 2023 08:40:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DL-0006W8-Nq; Thu, 10 Aug 2023 08:40:15 +0000 Received: by outflank-mailman (input) for mailman id 581928; Thu, 10 Aug 2023 08:40:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DJ-0005Mc-Ll for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:13 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7ef50389-3759-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:40:01 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 491284EE0745; Thu, 10 Aug 2023 10:40:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ef50389-3759-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 5/7] x86: make some functions and variables static rather than extern Date: Thu, 10 Aug 2023 10:39:45 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions and variables touched by this commit can be static, as they are only used within the same unit. This in turn addresses the absence of declarations that violates Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: 741367e77d6c ("mce: Clean-up mcheck_init handler") Fixes: 45f57813f646 ("x86/MCE: implement recoverscan for AMD") Fixes: 155587481e39 ("x86/microcode: Scan the initramfs payload for microcode blob") Fixes: af50dd63cf8d ("Pull nmi/traps changes from Linux 2.6.14.") Fixes: fef244b179c0 ("x86/spec-ctrl: Knobs for STIBP and PSFD, and follow hardware STIBP hint") --- Changes in v2: - Revised commit message I'm a bit uncertain about af50dd63cf8d, because it was done long ago and it's not clear whether the variable could have been static since then. --- xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- xen/arch/x86/cpu/microcode/core.c | 2 +- xen/arch/x86/nmi.c | 2 +- xen/arch/x86/spec_ctrl.c | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index 57e1eb221e6b..6141b7eb9cf1 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -599,7 +599,7 @@ unsigned int mce_firstbank(struct cpuinfo_x86 *c) c->x86_vendor == X86_VENDOR_INTEL && c->x86_model < 0x1a; } -int show_mca_info(int inited, struct cpuinfo_x86 *c) +static int show_mca_info(int inited, struct cpuinfo_x86 *c) { static enum mcheck_type g_type = mcheck_unset; diff --git a/xen/arch/x86/cpu/mcheck/mce_amd.c b/xen/arch/x86/cpu/mcheck/mce_amd.c index adc36522cc27..72f3feeaeed8 100644 --- a/xen/arch/x86/cpu/mcheck/mce_amd.c +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c @@ -87,7 +87,7 @@ enum mc_ec_type { MC_EC_BUS_TYPE = 0x0800, }; -enum mc_ec_type +static enum mc_ec_type mc_ec2type(uint16_t errorcode) { if ( errorcode & MC_EC_BUS_TYPE ) diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index bec8b55db256..9fcb9c1c3a90 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -149,7 +149,7 @@ static int __init cf_check parse_ucode(const char *s) } custom_param("ucode", parse_ucode); -void __init microcode_scan_module( +static void __init microcode_scan_module( unsigned long *module_map, const multiboot_info_t *mbi) { diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index c5c28300b04d..104e366bd310 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -108,7 +108,7 @@ static unsigned int lapic_nmi_owner; * be enabled * -1: the lapic NMI watchdog is disabled, but can be enabled */ -int nmi_active; +static int nmi_active; #define K7_EVNTSEL_ENABLE (1 << 22) #define K7_EVNTSEL_INT (1 << 20) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index ebe56a96cdca..9b8fdb5303ad 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -43,9 +43,9 @@ static enum ind_thunk { } opt_thunk __initdata = THUNK_DEFAULT; static int8_t __initdata opt_ibrs = -1; -int8_t __initdata opt_stibp = -1; +static int8_t __initdata opt_stibp = -1; bool __ro_after_init opt_ssbd; -int8_t __initdata opt_psfd = -1; +static int8_t __initdata opt_psfd = -1; int8_t __ro_after_init opt_ibpb_ctxt_switch = -1; int8_t __read_mostly opt_eager_fpu = -1; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:40:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:40:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581929.911449 (Exim 4.92) (envelope-from ) id 1qU1DM-0006on-QS; Thu, 10 Aug 2023 08:40:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581929.911449; Thu, 10 Aug 2023 08:40:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DM-0006nG-HI; Thu, 10 Aug 2023 08:40:16 +0000 Received: by outflank-mailman (input) for mailman id 581929; Thu, 10 Aug 2023 08:40:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1DK-0005Mc-W7 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:40:14 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fc7ea8b-3759-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:40:03 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id A558D4EE0740; Thu, 10 Aug 2023 10:40:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fc7ea8b-3759-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 7/7] x86/nmi: include missing header with declarations for 'watchdog_*' Date: Thu, 10 Aug 2023 10:39:47 +0200 Message-Id: <0665857accd8f39297f4cb77329fb1874be21302.1691655814.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Include an additional header to make the declarations for functions 'watchdog_*' visible prior to their definition in the file, thereby resolving the violations of Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini Fixes: c8177e691f0f ("watchdog: Move watchdog from being x86 specific to common code") Reviewed-by: Jan Beulich --- Changes in v2: - Revised commit message --- xen/arch/x86/nmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index 104e366bd310..dc79c25e3ffd 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 08:50:02 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 08:50:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581980.911467 (Exim 4.92) (envelope-from ) id 1qU1Mi-0001bv-NO; Thu, 10 Aug 2023 08:49:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581980.911467; Thu, 10 Aug 2023 08:49:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1Mi-0001bo-KC; Thu, 10 Aug 2023 08:49:56 +0000 Received: by outflank-mailman (input) for mailman id 581980; Thu, 10 Aug 2023 08:49:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1Mh-0001bi-4f for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 08:49:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060a.outbound.protection.outlook.com [2a01:111:f400:7e1a::60a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d918dd40-375a-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 10:49:42 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU0PR04MB9636.eurprd04.prod.outlook.com (2603:10a6:10:320::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 08:49:51 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 08:49:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d918dd40-375a-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D5qcl4Zp6brUe31k4QkNzg4nEodpYrL7orvy/BzLzeq1Zn/8hj3eo9+hHfQsJXJWEq2O2LgFI+onazADCwacPk/fNWwlXlLNgwZ1gRL0NsWhHqUWMKEQ+qs2NBS4kMWdDqXYoB75+FxsnO5MQV0XMbK2vzh+SDT304bUkM2WOyIos7qldS4pnF06zpVoNRN9L4/Y5u2klOWKcn5foy9drWuWqTSOVQaUuxtTPf5VUbJq0RM5QvmL46aorrIEovqGmcqgUXDUIIQWpYqYhVXhTAIUJ3GJwnYqNIsClrsPt0JidD8AxddKKTJBvS/B4ZBvctCMFwo/+orgOzh9ocwpFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BFMvvRc9Smv0ZNt5mmqOUKJgjxlLMFe13IuIua4HKPE=; b=K0b1+TqG6WZdkfga1VQ/wLGOiG5Eyd0vwd2f9I+Bv+dwwjLL+NtLtQ4Q1slWBco1mJmQJa6US/9ircgNEI/xKpJSs5pcR9b7HBSEkZo9mkTc9FVOTz72zq6agQg2mw/a8bvKz5syNB1DqH9VcmoebKHyC6Kh1DBj0LtuBhUNGXBGEVY1D2ucFyAbFys+2DBVdGJqotDg2+MhSqzql+/Y5scUXqwgPlPeqALmYIEaJ+uuD4zCNj5FQl39GRJ7GZUss1Aw0jcixOdOxWM2TpKGqUdtNXQW20xxMexLn84y/tDz9N9p16TekSHpXPmgOIwDDc0U2bBTFm1riA2O2JNJ+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BFMvvRc9Smv0ZNt5mmqOUKJgjxlLMFe13IuIua4HKPE=; b=IhnfEdNU9WOKwNM8hCyVDwFTqfN/iUu2H+ZneRYXd6XV/Sni/C5QVrJZ2+wekfTJUOGXH60uCwlkvNa5Ub1i4GmU79xrYzy0nGCmDvGIBGy1ehmKcxDQKfMeCtsAVXnBkKWEVNx+I+7T5Xc/oaWZK3w8vtisXd6mWL4aksT1es4nbTwZv1scyNI7k+Uzk4iELcCQDriwqR0gKB1ipSWXuTqsKGINWOv1Gv8JuRYOrDya6VqdapwbMk6HSrozZPVDA7lwJHy6VMYQt0Q2efO4brILY6UmB/c9qsTfJLEi8yZuG9rl3FeFpYKuvl62VayRKr/fNyFWOQ6SshC5he3z/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 10:49:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/3] xen/ppc: Implement initial Radix MMU support Content-Language: en-US To: Shawn Anastasio Cc: Timothy Pearson , Andrew Cooper , xen-devel@lists.xenproject.org References: <55e1391e-a289-72bd-f663-62276cf4b065@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU0PR04MB9636:EE_ X-MS-Office365-Filtering-Correlation-Id: 244cc519-05c0-4bc6-c034-08db997ec25b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iOe1A4yU0ds1dS71rFpTYPatF7bGCX9m4fzN9Z3Kv1NGZADnegXSzbnlv5nPuAYR4jkl5mEyqtu5txNaPynCLtUQ6K61NpSl0tc1k56Aw0DZOQlWorSTE8zz5cpZfIJz4pmVJdalOSeaSBSckmLYTYkfnsiSw4zSJgUuAProH+NND9Gt+pQfk5MZjAUeDD8zYDQu0x48Jn0oDITSUXz2MSoYv4etio4Re5cJIQ5kQk8cRuNxaKwUWLk9PtNkxdngVJMdK+Fb2GmTH2lUSH8nIM9H+3WLf3zUeytXzLQMzuC+YN3ZYaYpu3cZAPtiy6dwZMKVqylkvGiPWSoNYshwQ9mUyQtCVnQNfwND+HrigHvzsWjY0ZdvnU9cJPjzSh97ew4X/uNVhPtJ3XYGZEuSS2sdXYJJoGlQx4/3WjeQSzw+nirat67zkqkC3BCHowviQciqCjtTnUOB/wcuSZPAl+C8QUYO0djk0+VmfoUgVC7EMmKrtxIrRqDSVobI42ofkFtcGFPLhEfrPY/qr0XxvHEowmWcZWHiQ5FsdF3ogAhSRkYa1nE1iJmoLkRnmh+j0YrykNpAZyFS+Yk0/iup9IQhYZamxFFMOTCeRUydn8eVo2Rrhv7FjwDpJsXCvwGtoTamxEjWSNosVNn9nOppeA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(136003)(396003)(346002)(376002)(1800799006)(451199021)(186006)(2616005)(478600001)(31696002)(86362001)(6512007)(2906002)(36756003)(6486002)(6506007)(26005)(53546011)(83380400001)(54906003)(316002)(31686004)(6916009)(66476007)(66556008)(66946007)(4326008)(38100700002)(41300700001)(5660300002)(8936002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHZqbHhSbVVJeC82cUpqVVNhOFVBVkNOZ3E3ajU4dGpsMGxQeHA4YTQ1NG44?= =?utf-8?B?RHh5TVJDZGtNbTFBaUw3Tm91TEJxMGJBbVVsQW5BeHNTMlJjallSdDBUZkZX?= =?utf-8?B?T1ZvUGRFYzVldE5TYlJnS1o4S054VUtBNjVwSnh0Tm1ET1lmUmdBTEd6d3Rq?= =?utf-8?B?cUJOKzRadERuUTc0OUxmR1N3UEtyZHlFZmVIV2JrQ21NL2R5YlJiMHpCc1N4?= =?utf-8?B?SWZHUlFrNVdVamxSeGtLdWZFK2VzNHJMTUNtbVZxbE04TTJVdm1QRTlDSm9O?= =?utf-8?B?a3RveTVQdlVFSGJzR1lraFBqR0J6dmNEdU1YSXVaM0dudHFtalFvSHhBOEtt?= =?utf-8?B?NlZlaG1vbEFjN3FSRndxeFcvRmF0N0FjYzhqRFRwZGwvVXpVRkFyZ1dPa0pi?= =?utf-8?B?U2x2eWx6dldlOWN2NUFNRFF5aFRSZ0dhRmRkUG9WbEJVa1dwejNaTTE2NGRG?= =?utf-8?B?cUdwcVJ2TDVJN3V2QjJrRWFzaUZzRVZxdEhXSXhXWEFzNTA3aGJnWFlUVnpy?= =?utf-8?B?L09yeE0zZkx0VkFtSC80RjFVdUZFTDVQUHMzSXppdEQ4aUlaSktWWGlsdVdN?= =?utf-8?B?enFBcTltem8wOFZLeDl6NFphUHdIU1gvRlRPdiswMWNVbU1MZnhrVWNpaC9D?= =?utf-8?B?cU92VGNzcnhZTjJoYVExZk9kYVNiSi9PZ3VjTWFNV1Jnb1g0VVJKM2NUNy8w?= =?utf-8?B?aTZDQU9UN2tsT0Z2eFRBYUc1TXJZa0dNRnBKdjBpUUJBZ2Rvc2ZmcisydWQ0?= =?utf-8?B?YzBsRndHaGlaV0c5TjIrclNmRlREbzVWS1kxNFZJZENleVE3YzN4Ui82SHVm?= =?utf-8?B?US9KMkRPSHA2TG5GNjg2UzZtU1NBZTR1YjlFdFI2QnBTa2VTV3lobEVrZFFn?= =?utf-8?B?WDJSSmQ3eGluYTZkeUFDNmNBaXNMRy9DTDdnUnh5VjRJOEVKUy9WdWV2bElO?= =?utf-8?B?cG0zZ05nbXhNT0FPbGhzZCtIR21WcnhsemJmTDRRc0RYdkpEeWxzMGd6ajhm?= =?utf-8?B?V1A1S2pEQThLUDhpQ0wwcmQ3Y3hxTWxQeldjM3hPeVNEOGZtMExYSTh2dGNu?= =?utf-8?B?SFlXSUlkRGFETmQ4bmNrWlh2TTV4cy81K3JKeS8wOGR5Mm9mWXc1eWZpNXpV?= =?utf-8?B?aFBIa096OWlOU05NZTBXcHVjS1RIek1sc0Zsb2grcG1BZGJjc2kwMDAwT0Iw?= =?utf-8?B?V3BISXBmUGsxR3BXU3ZBREJjRzlnWXkxL2lZQTNxWlZDYnR6WnBjWTYwQjIy?= =?utf-8?B?SDJjYitzdUFKbDBVbS9uZFYrT0FoSHpoaHlSOGkzV0lhWDZOMXRHTk9kVHk1?= =?utf-8?B?UWtBMjZUK0MxVFYrcEp1T1dnUmJ6RHJGc3RJSzYxLzNoUkRkbmVXNCtDR3d3?= =?utf-8?B?UTZsYjdKSm1ZVldYcFUvblF6ZDZHWUVDTk00WExyVXRYanhPNmhRZ1Vla1BC?= =?utf-8?B?OVVESURqMk5KQnRob2o5OXdaK1prY3N2U3VUMjlGc3FldlY4WUNxZ3h4T3Nu?= =?utf-8?B?cHd0engzdEFWNFFVUmJIM0xiTmVJcmhTOFpuQ2t1d0FLMVBmc2N1TEE4bGRl?= =?utf-8?B?WVh3cWhlb0NIT3o1RHJ4cmVMME9FbXF0dE1qYUJlNVUxT3NjOFJFTTYzMUJN?= =?utf-8?B?L0RqejdSZDVUZkhmRXBPNG1rOGdYNkNZSERWUEFBYnUyZHRSSThOS2J0N3pX?= =?utf-8?B?WDFZUnFjV0VRUUY2cktYOGYzUWM1NmpKbGZrTXFrUE1peDBaZjg1SFBYdjd1?= =?utf-8?B?NSsrb0ZrYVFWOU1OWGtpZFR4eUdOdG9wWnk5Q29FTVBpOVVjaTBNZHhlRGEv?= =?utf-8?B?eXpwZWZQb29SRS9ZOG9jcVdkY1FYUWJpVU1WQmJZeXVuM2cwRG1vOWd0MHNY?= =?utf-8?B?NUlldEhseHJzWTVNSTVvYzFkTXIybncyZGpLNGh0b1IwQ0RvRGt3cXhRTFRK?= =?utf-8?B?cFRwOTRCMDZQU2h2bDYzeFZoMzgxcDZCQWRBVEx0VkVGcXg1Z2tDb2hDSkxI?= =?utf-8?B?dTFRWnFVOTBrdXNSVEVpUjZpUnRBQ2llT2RRZW5OemttVDdCc1RpdWNyRTJq?= =?utf-8?B?VHYyRko4eEt0dDduQkcyRVNyQ0FDc2RWUWtKS1ZMZHFKbncwVURsSnFOMndQ?= =?utf-8?Q?jFmGmeB8QyAsOvOqnbagXPl6n?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 244cc519-05c0-4bc6-c034-08db997ec25b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 08:49:51.0104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uiOrIWqSdSuJonoxe7rzIqKqDe0okYDdWVk2DWX/KKNWT+3wh21iziQ5hBR1aK+Uk3BWlXEyPSPOWfcDCd7DFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9636 On 09.08.2023 22:54, Shawn Anastasio wrote: > On 8/1/23 8:18 AM, Jan Beulich wrote: >> On 29.07.2023 00:21, Shawn Anastasio wrote: >>> --- /dev/null >>> +++ b/xen/arch/ppc/include/asm/page.h >>> @@ -0,0 +1,178 @@ >>> +#ifndef _ASM_PPC_PAGE_H >>> +#define _ASM_PPC_PAGE_H >>> + >>> +#include >>> + >>> +#include >>> +#include >>> + >>> +#define PDE_VALID PPC_BIT(0) >>> +#define PDE_NLB_MASK 0xfffffffffffffUL >>> +#define PDE_NLB_SHIFT 5UL >>> +#define PDE_NLS_MASK 0x1f >>> + >>> +#define PTE_VALID PPC_BIT(0) >>> +#define PTE_LEAF PPC_BIT(1) >>> +#define PTE_REFERENCE PPC_BIT(55) >>> +#define PTE_CHANGE PPC_BIT(56) >>> + >>> +/* PTE Attributes */ >>> +#define PTE_ATT_SAO PPC_BIT(59) /* Strong Access Ordering */ >>> +#define PTE_ATT_NON_IDEMPOTENT PPC_BIT(58) >>> +#define PTE_ATT_TOLERANT (PPC_BIT(58) | PPC_BIT(59)) >>> + >>> +/* PTE Encoded Access Authority*/ >>> +#define PTE_EAA_PRIVILEGED PPC_BIT(60) >>> +#define PTE_EAA_READ PPC_BIT(61) >>> +#define PTE_EAA_WRITE PPC_BIT(62) >>> +#define PTE_EAA_EXECUTE PPC_BIT(63) >>> + >>> +/* Field shifts/masks */ >>> +#define PTE_RPN_MASK 0x1fffffffffffUL >>> +#define PTE_RPN_SHIFT 12UL >>> +#define PTE_ATT_MASK 0x3UL >>> +#define PTE_ATT_SHIFT 4UL >>> +#define PTE_EAA_MASK 0xfUL >> >> Did you consider introducing just *_MASK values, utilizing MASK_INSR() >> and MASK_EXTR() instead of open-coded shifting/masking? >> > > I actually wasn't aware of MASK_INSR/MASK_EXTR when writing this. I've > just looked into it though, and I don't think using them makes the code > much cleaner. Specifically I'm looking at the implementations of > `pte_to_paddr` and `pde_to_paddr` which both need to ensure that the > returned value retains its original shift. > > For example, with pte_to_paddr, this change would be: > - return be64_to_cpu(pte.pte) & (PTE_RPN_MASK << PTE_RPN_SHIFT); > + return MASK_EXTR(be64_to_cpu(pte.pte), PTE_RPN_MASK) << PTE_RPN_SHIFT; > > In addition to updating the definitions of the *_MASK macros to include > the right-most padding zeros. > > - #define PTE_RPN_MASK 0x1fffffffffffUL > + #define PTE_RPN_MASK 0x1fffffffffff000UL This is the important change. With that the above will be return be64_to_cpu(pte.pte) & PTE_RPN_MASK; and in cases where you want the un-shifted value you'd use MASK_EXTR(). >>> +/* >>> + * Calculate the index of the provided virtual address in the provided >>> + * page table struct >>> + */ >>> +#define pt_index(pt, va) _Generic((pt), \ >> >> Earlier on I did ask about the minimum compiler version you require for >> building the PPC hypervisor. Iirc you said about any, but here you're >> using another feature where I'm not sure how far back it is available. >> As indicated back then, it would be nice if ./README could gain >> respective information. >> > > I'm locally building with gcc 10 (shipped with Debian 11), and the Xen > CI image for ppc64le builds uses gcc 11 I believe. _Generic and the > other features I'm using are certainly available further back, but I > haven't personally tested anything earlier. If there's no objections, > I'm tempted to just codify gcc 10 as the minimum supported compiler > version and leave it up to users if they want to try testing on earlier > versions. Spelling out what you know works is good enough for starters. As you say, people can propose updating when found too high. >>> + for ( page_addr = map_start; page_addr < map_end; page_addr += PAGE_SIZE ) >>> + { >>> + struct lvl2_pd *lvl2; >>> + struct lvl3_pd *lvl3; >>> + struct lvl4_pt *lvl4; >>> + pde_t *pde; >>> + pte_t *pte; >>> + >>> + /* Allocate LVL 2 PD if necessary */ >>> + pde = pt_entry(lvl1, page_addr); >>> + if ( !pde_is_valid(*pde) ) >>> + { >>> + lvl2 = lvl2_pd_pool_alloc(); >>> + *pde = paddr_to_pde(__pa(lvl2), PDE_VALID, XEN_PT_ENTRIES_LOG2_LVL_2); >> >> paddr_to_pde() doesn't mask off the top bits. Are you relying on >> lvl2_pd_pool_alloc() using PIC addressing to get at the value it >> then returns? >> > > I'm not sure I understand the question here. The pointer returned by > lvl2_pd_pool_alloc() will indeed have the top address bits set in > accordance with the link address, even before paging is enabled because > of the relocation code and jump to XEN_VIRT_START in patch 2. This is > fine though, since I call __pa() to strip off these bits before passing > it to paddr_to_pde. I'm sorry, I managed to overlook the __pa(). >> Also this and the similar lines below look to be a little too long. > > Yeah, I noticed this as well, but my understanding was that lines longer > than 80 columns were permitted in cases where they don't hurt > readability. In any case, I can fix this. There's only one general exception to line limit: printk() (and alike) format strings want to live all on one line (unless there are embedded \n), to allow reasonably grep-ing for them. >>> +void radix__tlbiel_all(unsigned int action) >> >> Is the double underscore in here intentional? >> > > It matches the original Linux file from which this routine was imported > (referenced in the file's top-level comment). > > As I understand it, this is meant to indicate a private function that > shouldn't be called outside of radix-specific MMU or TLB code. As > Linux's radix support code spans multiple files, a static function > wouldn't work for that. We haven't adopted that style yet(?), but I'm also not opposed to you doing locally. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:00:43 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581987.911478 (Exim 4.92) (envelope-from ) id 1qU1X3-000419-O3; Thu, 10 Aug 2023 09:00:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581987.911478; Thu, 10 Aug 2023 09:00:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1X3-000412-Kj; Thu, 10 Aug 2023 09:00:37 +0000 Received: by outflank-mailman (input) for mailman id 581987; Thu, 10 Aug 2023 09:00:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1X2-00040w-Nn for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:00:36 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062e.outbound.protection.outlook.com [2a01:111:f400:fe1a::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5e308882-375c-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 11:00:35 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB9189.eurprd04.prod.outlook.com (2603:10a6:20b:44c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 09:00:32 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 09:00:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e308882-375c-11ee-b283-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LbHTOcpe8LJ1wO6GjPhhLHQs6iQmVfhvmIHHFum85MyMYpIRdaYAEhavL5yxNEpqbrCdxWjFzGobS5/bBud6a+cptbWG4bcVkKo+YEIMPK23A9K2goOko06Tr8r+VLJS/7tHHJg0BMOArofj2PZUIkt7HKUb4y+g1Eg4kfLU7rFZMFvu0RKV74tjuiZwTlhPoZzoCv3QXF4YUbmprGtayf5OxxMOpuQQ6gTr72j2c/ctLWAU12S6a/f8ML4j6nFwEHMFhDgsuP8d6zZnzin7jbKPZl+Uu/06YDbpgZwP/LDeNtiex7rowhgv5xCA2pksA/zVtHDj8vZ6qp52wr6ydQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40VPJiKTJTqvfzxYnOBbm5trwHZ4BPF5zYlofLlqvnI=; b=c+8Gg3/diZ3B40RQOw90m+OevvRmLMCUbCfnugVyT39ixBEBHO2ZBdSGWShNVPyrtJXopawNsiHk/64tuMOoG/fMb4JkA5cbpZ7eKF8APv7PMZsaJVTpEwRxcP5JxYd5DrH+6Bk/gZIERxYTr5RbyrJWpv2kLf0necyDkfTxKZBHp9vhcPQxjzdnV8cCMCRkLxrUKMHrJwMGudVkLxFqydRqadI796PC00K16PQE44obmYt9GX9RksHa5kgK5nD4D2H4vfIFLv55sdvyGikTZBm9IW84VMnEtxa4VicK82Z7i/6y66+7RBCEE21fFkBgT8JdemtNH3ooPHJfPzeuZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=40VPJiKTJTqvfzxYnOBbm5trwHZ4BPF5zYlofLlqvnI=; b=ItfDMcp/uTV2gj7zUYTfESiMsTb6M2L4lbJ3xvtK6ycLjCe5bheJT/WKMIfVQlsOKChMPWRpupzY45tJZU8SslrXDR6M5JuGN+iujI1JSAVuLYpHUUhtaPFp7rLj01cAsPKCc79EuSgfzlOeW4hybMSoxXRFqxNXHCDG6qZt2CwPbCLQAKkE516oUSsCZCyE1ele8IzcuWjZVLxiJAs2Xg56AM3/Zgqlw5gZ12XP6HVgwbICw+IBUnwf7E/1Dd5wb9xOooNfCPVJDZ02hyIMit65oMS6VAYgRma5/R2cXVqdXfUfQupIjl4mYPygmzBJWve2vFwR9MBwfy20i8sqqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2e62ccd1-315a-3cd6-fbfb-b86af7177e7c@suse.com> Date: Thu, 10 Aug 2023 11:00:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 1/7] xen/memory: make 'ioreq_server_max_frames' static Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , Luca Fancellu , xen-devel@lists.xenproject.org References: <7f0d3f4330a262ec17029b3d82a7a89409215fbf.1691655814.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <7f0d3f4330a262ec17029b3d82a7a89409215fbf.1691655814.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::18) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB9189:EE_ X-MS-Office365-Filtering-Correlation-Id: 95ea19ca-4d88-43bd-b5d7-08db99804091 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5OwFeLlF+yuguhyXDBRiMAqIX4bt6SDlSF2EtLczBk7wTWNghYQShtgjZNvGRE75EtM6l7pjgSbRLe5tyWQlg9PRjtHpOGIwIsRk60SmW2nKFcoB1MmW0h65BpCQBF5HhijVBwrb5NgVLFL0+878F0zzXwYZDO0+0Dg9aVOUemsWg4l3Wn8FESorNiAFqaCYa1X82PZPp3BiGRd1w3P1PHumel0hLF+25JDgUR0u05O5tzfa2a5AbkoFlR1ZQss3vXuL0BQJUbotcxIY9XE4Qj8nRS1ybpU1EI5j40WzFyPwYG+VXs7eGW2OoHacEkRw4MsnRVjan2KgtrQ7IL7g8Uft6EdmCSloK3snOR1b58cb8b3cSextV24JCw2aruhPOR4BojjapMVbk6P1olE683L0rEIdJDOV7x4L9yUBu+8SPp8HjRPydswAlbR21v+JsFCq7kQLMalNiTi/7BBNv7ycJO0ukbjp5WR2fFLr3KAoR2UgMBJVfY9NVRMlwYS2LXO8x/MtBMIk7vZQOBaK24KdNCPFrrNm24U8zvaSXF1sdTUSKVbFqcUwvVJ8LU248YtchFBIMrK1n8JDQ0GB6dXisXyjFJKojAiLYZgd3bRFP22MdqjIFoh+XNEF4bqFl3Ay5mF/HhJQN+zk9iYiKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(396003)(39860400002)(376002)(366004)(186006)(1800799006)(451199021)(6512007)(316002)(8676002)(8936002)(41300700001)(53546011)(6506007)(26005)(478600001)(36756003)(6916009)(4326008)(66476007)(66556008)(66946007)(38100700002)(54906003)(6486002)(86362001)(2616005)(7416002)(31686004)(2906002)(4744005)(5660300002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0tJZ0syYVp0T21YY205Tm14cnEwaTJUT21LZHBHL0J5by9mNUswT3hMOW5J?= =?utf-8?B?a0FlUUtzOTZQM2EzTnBVY2Z2OUt6K0twRG5SODhWRmI3UzVpTHBCVFJHNmF5?= =?utf-8?B?dHR2b1dXTUZ4S1FwU003anhCamVaeFU3VGFScHg3RndLL01sZ1VOS3dSR1c0?= =?utf-8?B?SnR3ckRwSGtyR1p1b1ZtbWU3VEpuVUcvWnpvZDdNTGdpNnp0OXRUd3UxeVpV?= =?utf-8?B?bHlnMHhIbnF4UnRKRHBaUkZHYWQ3MlJkYXFPWUxVQjZicnUyNHM3bk50bnZz?= =?utf-8?B?cWFPRzJoQWY3WGhzVU9ud0trMlNZMHlwUStmWVdUNEtRaEQ4R0tCOEdvaUh0?= =?utf-8?B?UHgrVDdOTzRlUnA5c0RhdXlHZnc3WlE4emFiN3lQblV1MEhPNExVb25jWjJQ?= =?utf-8?B?WWxvak9lbXdxSmFtRmd6UFB0OTh6ZldZWTBKdG0xYWJKSHFSYnZLblR1Z1RR?= =?utf-8?B?UWMySDBkOThjNytvMmk2R1J6cmNYMWk1cGJkVDdDZDc0TVRqaS8rWXgrUlAx?= =?utf-8?B?MHFxd0FzMUw2WmtsSnUzbGhtT2hSeEpsZXRYMHpQU0p0L2oyY3RaNXEzMitw?= =?utf-8?B?M293OU1FV1NZVm0wVVY2YUVROE1LTndCMHRRQUV5VC91b2lEK1NRQzI2aGxD?= =?utf-8?B?cmlLbFFERzQrN0FyamtyRHBOdzlRWXFxZERKbUtERnJuUzdHbVA5Yzl6L1U5?= =?utf-8?B?MWhJdVdwRThOU0l6UUpqYVhwMCtseFRnbFg4UUp4K1FBRmZCOGNpVHdLV1VZ?= =?utf-8?B?YjNKK2YxWDZVd09zaWMzWjIwSVlnRkV0YW01Y3grUVgreG8wRlBLUzBCa1Nh?= =?utf-8?B?eGU2TVlRNE05SzMyeU5BNSt6ZlZaUWpaSmRVd2N5U0hHTStJbTVtV1d3OGNM?= =?utf-8?B?SXArMDBuL2FGdE5vWGhPbng0UU5Wd29sVVpBNEJKS0xzNU4yeFFsSU1yNVhl?= =?utf-8?B?d0srdzAxYVh1VitIT0k0aG1WY29PTSt1cHZobzZ0Wkxad0FRaUh5ZHpHejY2?= =?utf-8?B?SzZjVDZZTURRb0NKVzdHMmxSVlNoUmJSUUM0ZFh4QlhiRE1CZExKVnRwOFJC?= =?utf-8?B?SmdiQktqdy91dUdJbjF0VTNtMmRibTFSeHhycEdyNUVlNk5scEVSUURKS3R2?= =?utf-8?B?SUd0a0hibWYramJaT1hueGxSb1dtYWc2UnZxczR4RUp1VzFYSFB0ZGdCYnNP?= =?utf-8?B?c0hRNWZkbEpJK3hoQ0h2ODFyRktmdmZ3c1ZNVEhJY1hkOVNvMmgvdzBlRFZK?= =?utf-8?B?ZXBSQXl0S2E3d2FPaHI0R0xoc1RRRldjc0FmSUhxWmdBL0VCdnVnNWZ0a25N?= =?utf-8?B?RUFQM0p4SkhMSVlKb1hhQWJMU2N3Vmo4K1FXK3ZVYmkvcW45Vnc2Z1hGY2Qr?= =?utf-8?B?WktjVWFCOW9Xa1RDdzUyTW1LSldOdmdLZm92YnNiM2Voem13ZlRpUkE4dVhT?= =?utf-8?B?ZWJSekZHQ2xGd01sWEhlbjJYTU5hWkVrVVV0b3BBR28yUUR4MEpkRXB1UlZy?= =?utf-8?B?ZXpLTFNYSmtaTk1BaGdDQkRaVmR5TUxyRDlGbFZULzVTbzhEK1N1WFBRMVFk?= =?utf-8?B?U0ttckkraHdmVmF6TWJjRERLYnFmbUVmbEprZmd5K3RNN3RVSkcvUzJzb21l?= =?utf-8?B?Sm4xKyt5bjhNbE1XSVA4ZTRwUmdyWUFySlREcjkxMEx3VDNnSFRhM0pkS2U2?= =?utf-8?B?cDVsT01QVmxMWXBjOExHbDZ4V3BWbGhnZ3lIbk1iS0twUGZDcUFYK1o5Ymdm?= =?utf-8?B?Nk52dTl4MW9UdzFleXYyWllkREtWcmpaK2VkMW4vU3dCai9LcWJpa0diOUlQ?= =?utf-8?B?QTVHYmpBbE44Y2Zqd2J2UkZNNUxlRGFjdXptVHZOSk0rK01BRTNBcW1rVGcw?= =?utf-8?B?K3ZpZUgxN0IwNHdOVzVkM0p0SVhDV2NXNG9PZUxTK1orYWxVUGMrWnB5Tnc5?= =?utf-8?B?bTFkRktueFd1Vk9BSHprSmhLOWlvdmpoN254MkRqUFo5bU9rZG9FclFqdXlp?= =?utf-8?B?M0pHV3BQTHY1OXI3MXg2ajZwTXc0Nm9ObGloQ2Q5elJZNmgzNFdCNy92SnB3?= =?utf-8?B?OHJpMklaT2h1YTdkenlCLzdBVVFNL2xud3FuQ1psbmEyc0JtenBJbnBxWjk3?= =?utf-8?Q?iGQ0Oiok8mCtP7MiLH3aP7ciI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95ea19ca-4d88-43bd-b5d7-08db99804091 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 09:00:32.2593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B2RCtmZH7a2iOzbl66H04I2I/erBfZ5cUmed16TgyIk57z/Jnx3zgApSCI49bR0OBnkqXtSTV7CmHPImAtdfcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9189 On 10.08.2023 10:39, Nicola Vetrini wrote: > The function 'ioreq_server_max_frames' can be defined static, > as its only uses are within the same file. This in turn avoids > violating Rule 8.4 because no declaration is present. Here and presumably in subsequent patches (I only looked at patch 2 for now) you're now missing the word Misra (ahead of Rule). I'm happy for that to be added while committing. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:01:49 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:01:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581993.911488 (Exim 4.92) (envelope-from ) id 1qU1YC-0004bT-7L; Thu, 10 Aug 2023 09:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581993.911488; Thu, 10 Aug 2023 09:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1YC-0004bM-43; Thu, 10 Aug 2023 09:01:48 +0000 Received: by outflank-mailman (input) for mailman id 581993; Thu, 10 Aug 2023 09:01:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1YB-00040w-PV for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:01:47 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20619.outbound.protection.outlook.com [2a01:111:f400:7eaf::619]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 88ad5ce5-375c-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 11:01:47 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB6928.eurprd04.prod.outlook.com (2603:10a6:803:12e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Thu, 10 Aug 2023 09:01:43 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 09:01:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88ad5ce5-375c-11ee-b283-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PN+FCmh+B0qhqVrz5Ord3qPAk34BwmXDk5WnRvdFRCZ74wFCRVmoy+0s5rirjvldfA80u1JQaEQ9oa3Z+QhVtia5PAfz0J6qCnlIevkR6EXeoRB7o0io4nI4RX8GeUhTtTW37/35lG4he7oMgYWMWVvY0vVswJEj51SiBI01slWXpK7xsNaaKB4i4omv23LbIkAognSnMP4tfsrlR2FWdSO4rMqMwAWUPETpXrQgfglxGk5bSjaqlhYQQgUNzLj7BzGGvGJjcfCPAS8tJaj62w2xf62teomRm8SQj7RgjysDJej/OFHcc5wQmOpAHZnda3qb966yhHRug1EYsCBvbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SwTKdAq1WQYnB+J98khSAMZBivdEeCyGK++sBSMLiPQ=; b=WyMBjk3UmnYC+8u7ahR1p8eTbDDlbQWSH6dwiery7JCk4FI0jhh2sVXUbvUrp41LF34whSvSfpkM6XD3VHAIIENnpTXAIn0NM4zm7RFCTn9ZWwCgcChWI6viFAvgIBzF7KS30pLhdbJwSYTOfwR7UFZ7dHrMgQZKouQyKuyq+ICVgMIFmIizG73x87hcObwpuGj4JlQ2/AVriYBivY9jcoI/THwCJXmEKbE9CM3dfkU7ctYtqo9phVndAJek+nk/7i4A2zm4GfQk4mFlEcwxFj2p/OJUZ0A+5+H66syg9HpYzexKebyPGcJrr3TC4c+vUFSGA4wVPBad15PjxnjRBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwTKdAq1WQYnB+J98khSAMZBivdEeCyGK++sBSMLiPQ=; b=ZeNDsipArC0DlVW2OTV8dqnn8tKYvbYmcMNC7GARjGBRv3N/COpGG2TMnXX3wZXk1IG9WdlFEmCyf3VdxYdtHoJfZ5cXtXnLPQpaCJGfDEcTyKiyH/2H3Q4VufsVC0pYl0Bwtzv2sfUy6p0ubBV8LGhHC5X5qT5r3ue+D6D+WHJn0QH9yZI626K78YXaznk0agPwggaTNcFHjYYEK7GCiWnuvY3TeSeCWL2Oe0ibyDZKFzVM4GjNNkoEfwtPQje5SzrLAhDpxkK52L6zrHRE2tlJs1UO5js6cu46HzOY3Qt9Zuq4jecXBSLxqN81cwP9adNIQbMzfSMkF8uxC26LOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 11:01:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 3/7] xen/include: make a declaration of 'get_sec' visible where needed Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <37fed394315c24e7b7419e564696a534886f0d53.1691655814.git.nicola.vetrini@bugseng.com> From: Jan Beulich In-Reply-To: <37fed394315c24e7b7419e564696a534886f0d53.1691655814.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::12) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB6928:EE_ X-MS-Office365-Filtering-Correlation-Id: f8d0fa6e-6c26-42dc-0a2f-08db99806aad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /aVSmOuoKzrF9/xaOsQT3y7OEnc9EPkOGj6wUUCsoQ4ZZ8YXdEnkKFZY+eCcdRhMD+XpcaxsBovFXjAlnHf4vWU5w8MtRDD+UpJaRea5nue5Eg8DI1gXmu18M4A6RhpFmlmNYaXLCZKwn12fQ+o7HR/wigzSg+bMPBdvHhAUKEEURy623e7zRuCzRSf4gNjauJTyBNotLP2G9cDN7KI1aMCYEzqeAet2ydJ/QwzioipA/Lsgp68WEiJgWQWztBMPpKZJEpkVlzRH0z7vlnlrIyO1ELHROQrxlr2MLHDSvrbiwolFf5sSmFZaBI+pqFr/B3eK+OdrNJCWVowR6AKvNHeicdnBCDVC5WUTX1Sitd+261fwiJfRpBxvYDbLFDChC7T1Jfnnq31m/+PUWl4P38QtlNFpQuC7ie46uCvT6QwDgTr5Mwj0m3x4RoCth5Kj4tBHGoQwSoS0LvX+MMb4QYfuhm9It4TgZr5A74WS8QwQdlKRomQU4sxLiDSGZEwaByddZ7peGubRJ8Ulj0BLqlDwZuM4WT5C/ZJRJNMHMHlmN4Ua7dPpmxE7ZiwUOzob5oCdoqDdEYYfui96Kcds66NslaIdK7n6KEN/YgHw9KTcsK62Y9RGa3N+CFYNTac5ov0v47lqTlJ83eU5a1ockw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199021)(1800799006)(186006)(41300700001)(6486002)(6512007)(26005)(38100700002)(6506007)(2616005)(53546011)(4744005)(316002)(54906003)(86362001)(31696002)(2906002)(66946007)(66556008)(66476007)(6916009)(4326008)(36756003)(7416002)(8676002)(31686004)(5660300002)(478600001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEZZZ1B1S042aFhUc2lnQ3VQSkU2QVRqYS9NemFENUd1MHllQ2dvUi9aRlZW?= =?utf-8?B?bWR2Tk9CSFNBdUNVTUxmN244NEpCSzRlcVFXVkNXNTRrZXJlL3hHcDRZSGds?= =?utf-8?B?cmM1TnZXd2tXZFFWaXp4aVJxK3IzMXJZOE15eTRWMFg0Q3JUdVlDV0ZnbG04?= =?utf-8?B?YXhGS1Z1SU1DL1E5Zlo0eTRHZmNPa2FHdEh5Rlh0RjJ0YytuNWx1YVFCNFNJ?= =?utf-8?B?RERlQ00yS3ZiTGxVL3drR2JyL2JZSnBQbGppZi91TWZ4Um0zN3hjVGlJa2tk?= =?utf-8?B?TWFZaVQ4WDlMYm5MTkgvbkVsd1kxMXJNa3kyelo0VmYzc1ZNWFZkQkRmaWhP?= =?utf-8?B?ckFRWGVBSWxFVVh0RHJoeHBpNU51dysxeHZ6MCtNanV1bGRsSmxHcURYbXJU?= =?utf-8?B?cVVUcGMwdXpaTGV0R29KTmc4OHVyWnExMS9wY1BoaUJLSmZIMGNQbTM1RmRR?= =?utf-8?B?aGgycis3RllnTnhoNnBNMHozOTYzY29DL1Q4OHNvcEdsOVgwb1VOY2Jpem9V?= =?utf-8?B?VkhPUGpKbjJhSE9JaUs2VmwyMTJlQ25aR0FCUExqKzVPdzk0SElkdnlBei9H?= =?utf-8?B?STBObnE2RDhwRG1VOHlyQUQwTjh4Y1dDalpjeUJDVGNCUGt2U0o3NHJ3ZUl3?= =?utf-8?B?SlliT0s0TEJIV3pmRHJ2U2YvZFJlUnNIT2ljLzluSUplWGdrYXMyZTBHMWp1?= =?utf-8?B?TFpDMDVzZHFhMGQ5RjFHMWNTMkxyUG0rekxJSUh0dWlJeU5pM0pUQ2hvRXBj?= =?utf-8?B?aWVYaEVDTUwrSHVnOWRUTUVCdWpXNlVDMFRzbElxQ1h1c1dBY0cyakRMRmpm?= =?utf-8?B?Zy9zcWNJb1RkSm5RTXRFM1hveHFqUFhIZkJwK3M5NFlvcGlPY2pLSStXUGNW?= =?utf-8?B?MlIrZTFuUDdwVnZJM1VCVmQ1K1lEQ2ZXelYxVDdsYmNTbUdMVU1oQXlMVllh?= =?utf-8?B?MHp3R2hkbHA3K1kvYnF5NElzM21xemxIMXN3YzQ1RnA1Z1FwekUxRGtEeU5M?= =?utf-8?B?Mk9kazZYYysvRElwSW5aUDdwYmQ2dDUrUnVVTnFvT0hOdUM0Z3dYdVk5YldS?= =?utf-8?B?c2FyQ1JHTGVGMDNERUpSMXEwUzljT2pBUGg1K0ZzYnZwVjd5UVlHVjZJTE1L?= =?utf-8?B?MUp0eDhxbHQxNFVyVU8zL1JpN3FDOUNtdmhaKzJhbDVFNFZaOHZGYkN1YUkr?= =?utf-8?B?U1Y5aUkvcGlTOHkwMnpIYlI3WGtRRkd0RVdRY3d0WEM2V2V6YzZMTmlwVWl5?= =?utf-8?B?TG00bDN0V25DamhMS0hTSElGL3IyQUVMKzBxZG9mZ0EyekNVTkx4WGMvWjFm?= =?utf-8?B?NzF5RnEzdWx2enphNHAwU3ZibDhoM21XUEJmR0pvZHN0bjl2WEhua21rZzc0?= =?utf-8?B?ejdhM3Rxa0l2WHFSU3NmaWFhalBIUmZaVEdFVlpjVHRDWGxDaEx5d3JOelpY?= =?utf-8?B?YXZ5Zk9DNTg1a0pJdTdBVnc0VTNmUFZVbWJkU3ZsTUMzOXBTZXdSWTNsUWxk?= =?utf-8?B?ZDdjUzFlRDFIemxWTUxFTUVic3VsRHkwTWEzU0xEcE9BTGdtM2xSVmlpbjFO?= =?utf-8?B?TXpHOFEzNHNEMDNva0ppSHpsYUcrbExwMlRMbEZSeEltWUdVTyt4ZXEraStX?= =?utf-8?B?UEhEZ0FvTzBUeE1UOXY0TFFZTERFblR4c2tlbmJ4cDdXSy90N0I1M21TRGNI?= =?utf-8?B?WDBNdHhtaTM4S1JVaW5YUlZGbmNtZ0Y0Vmp3K1dNZGFEMTZuTzFSL1RmNUJ4?= =?utf-8?B?S0dSb0EyUjNxZVk3UGJ2dzFCeDNZc1RORUMyVzczZTFtUUIvUmZ6SG1rZ0VT?= =?utf-8?B?TEI1dUVyVmREK0NCVkREY3VIdkdoNW1sQWFCOG9Tb0VES1lqYmlHZHN6MnJU?= =?utf-8?B?WEFYbm5JRUlic0FQd1drbFBoZU9GOFVnUEpHcDFBN3hQREpYZWVWazRKVmdi?= =?utf-8?B?ZWd0a0F2MlU3QnR1ZlBZZ3o1YjRKeExUSitYYnFaMXd1UzhkTkFkMVh4TnA2?= =?utf-8?B?OVo2bFlTNjlzYmhMYXVPTG9jVmd5TGlHNm1VUHZqY3dQWGNVWGJ0RG1zNmVh?= =?utf-8?B?MU1OblZVZUFhNDkrUDNpUUJvK25WTEswaHRTcTlPcC9HRFo3Zi95MTVaK2Rq?= =?utf-8?Q?Fl1v0byDhbJH7muWMc/q2aISy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8d0fa6e-6c26-42dc-0a2f-08db99806aad X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 09:01:42.8978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DiQF8GKmiz5nFWGQ3PDFtJPFCzjguKaSJDsP/qTLDTp0BrGdgbzvqsq/HHgX0DV2IAyrXBxBdpT1ZLHMKL7HRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6928 On 10.08.2023 10:39, Nicola Vetrini wrote: > A declaration for 'get_sec' is added in 'xen/include/xen/time.h' to > be available for every call site (in particular 'cper.h'). > This also resolves a violation of MISRA C:2012 Rule 8.4. > > Signed-off-by: Nicola Vetrini > Fixes: c8cb30cfc87a ("mce: Provide ERST interface") Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:03:31 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:03:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.581998.911498 (Exim 4.92) (envelope-from ) id 1qU1Zq-0005CJ-Hp; Thu, 10 Aug 2023 09:03:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581998.911498; Thu, 10 Aug 2023 09:03:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1Zq-0005CC-FA; Thu, 10 Aug 2023 09:03:30 +0000 Received: by outflank-mailman (input) for mailman id 581998; Thu, 10 Aug 2023 09:03:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1Zp-0005C6-9h for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:03:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060e.outbound.protection.outlook.com [2a01:111:f400:7e1a::60e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c48c91d5-375c-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 11:03:27 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB9082.eurprd04.prod.outlook.com (2603:10a6:10:2f1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 09:03:25 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 09:03:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c48c91d5-375c-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBl65i9j1h4b8VjazPCcar4Cm1VEisjHAEyyscLeHOC7znseL4f3ih6s0ia8zePz+mTV2NZ/1poFeCZ7mm+udmvJgMELPnCu8IG/lQeUGUnN/JeRoamaLMiNmpVyl/k9yee3mCN9yL2qpJzqvHFLowcxpt9nHY4iBTStFieD6KMtNkoQRXCqh2uUK7t1yzRQzXG7A/tGUG2ggQweuJUV4D+iVCtgFbk6GF0lxD++mOFCsb+wEFEtQiOaOgR/xxuAbbkjjXfRn5feWsPBA7iRqxvyEwIcdF/lwbOT2t8LBPnUfVTb4GbUAODqL9ggnon1sYtB1RpVLExA1JZQtua2gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bYbPWEJQzOMw3aJzgHc0ko79hzSrUrc7ncYYQOm2RWk=; b=QJ20BcuJt5HUyVhWJPb18whrvJUfQ5YXmhBhDUfxgTMJG6aUYNbacwPLgHwhUQAn+gvDn2AoE03zkLWLTwFn3CWY2xFhSSYPYo5nT26oxWQmz7qycsWEFwgcXDKptS9J1dFMHe1rCijpr84ay57CaQREFOtVe10zeyFgxbY7X30Zb8/XctTHKtUhvy8VtiqSAKSMIk15M8lGdPt2mjJXmuOzk5tZHYR625NLTlQKVJIt1PDNFJ6zmxasGhJVaf1gkEby89/ywaqouxFy89+M6ujHRl1oLw1Lr9e4UBzhPdcFa6Rh2UTS6ecCRhzdJXYexQ12lJYSDnhwbB+Pz5ItZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bYbPWEJQzOMw3aJzgHc0ko79hzSrUrc7ncYYQOm2RWk=; b=nUTC3UXm2cap1MvAJysbdZ9ULiFdQw3ZXIVGe6ZIbxzsAAiChlStMPK4MNSGmllU9zGn/Vx2Uvd8L99lRrfLVh55wGOEbTLMFApzRD2CfczWWNILLS7WKo5ILgrEwxIObHkFVFgSfL5WcclVFYL30nNQVcwHlUksfadtFDOetb3kXeYLTThUOYp7T8xPNGF6/LGRK1QDjx33I89k1F3JldtrcPibG5mwwes7d6kNJdx7S/JFsKUQ9wI1m89F4uCZr+yVCK2NoG75tskOf2IwMv1ld2e8K2x1wI+wlNVxDWcK+GlOy0qcQxMd87GwwU3s8qsr8GsDH+97tIvY6nhRJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 11:03:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH v2 5/7] x86: make some functions and variables static rather than extern Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB9082:EE_ X-MS-Office365-Filtering-Correlation-Id: f226e0a9-4cd7-4af2-6022-08db9980a7ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BSIPTuAD2/7XODCAVYwel0troF706ri3FQizu5jdRtLoZv3Y7qkMfXye/O5p4eLG22ivT4z+XqKKmplIoXV0r69CTCl0/e4Zd/wa671DEUcdrBQK7BO0Xudg6XAKL8KB0ENprZO5cnnVoxFN3KTnoYjyC+CjwVrlUciSDpzRHxwZjrxvH+/HwsKeMH1nxwjNC8oHQsr4SFH4IvvYWHJKD6fcRNIhP0D6NxwDX5HsufZOEevZZxkQMf9CaML8dFL0GJH7crfP6/1EB72bfwhyeh9kBbNZ9zc8osp/s2vqkx96FSKossGVvM3SRNW6RxDHUagDjfPMl1ZFhpukFAG+WxoVM7r8IGDoNH8IPlKSTsScJlG14Juue4Gu+njo1eVAiiCD59L3niFaLko2AQGFX7WY5rlEU5E2YRbHRYubCnog+mStEXvd0WzCjlA7Gs2sOPW9xxaQibfFJ/3ihJpogT9v8bt4ZVR6LxbMFjBIz/vh1uWao/sQ0MuYOxsz0sDxnvrRZnITCbyXSv+OPQo3qCxc+L2lOEKz/hO2+iU+fdZivgXuG8tOjuEOfXWL3rNAjbS+tO5K0K8NVjsdGfcHB2sIvZ+XqmVwbAr1SXRLLc5U1Tldhb1uGhNX7xGGaUGHg9Nb5WyhFRGwrrPDznnu+g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(186006)(1800799006)(451199021)(7416002)(66476007)(66946007)(41300700001)(6512007)(6486002)(36756003)(6916009)(4326008)(66556008)(5660300002)(8676002)(8936002)(316002)(31686004)(54906003)(4744005)(478600001)(2906002)(38100700002)(26005)(6506007)(2616005)(86362001)(31696002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm1lWW9qbTVwSkVtWDRCcEdMMnlUSlM3dEl0dWd4bXZlLzl4QUF0aVEzS1Ft?= =?utf-8?B?bGxsZTdLM3VyQWpWSXZ3RlpHNDVScmVaVGE5b04yUkdGNEJZeEVNdG1tV2l2?= =?utf-8?B?dU9ab1kxaWhXQ2V1Q2tYbktKYmRnRHlDZzFNenhjc21BQm1mb1pwMUVaa3dw?= =?utf-8?B?ZlIxK01NYVNYY3BjWDdhM1JTajNYN0IxTE5ZQUFUY0hZRnV3L0QwTU9DalJ0?= =?utf-8?B?SXgrbVFLOHdXYm1Wd3lZN01JeG4yci8yTENBdU9RcnNHYzB4aGlML2dLMHZo?= =?utf-8?B?aEc3VHA5U1NxRWwyemR6UmFyZUpuZlN1dllrRVliV2xBZ3YvQjN2eTlRRGFS?= =?utf-8?B?TldKZ3duaHRhZ0F0ckFDY1ZEbUMvbDN0ZlZFZmVpUDhHU0pES2U3eEI4dDA2?= =?utf-8?B?NUlXOWFkSXQrT1pwbHRsVWxyTTZ5bVZpb2VrcWN1WGpzbkpRN01SVWpocjJw?= =?utf-8?B?YVdVbVZmd3lYL3hxWDVDU1JEQWdYZDMrYzdMSVhXb0xlTVRIdEFFKzQ5c1Va?= =?utf-8?B?R0J6cVAwUHZPUzl1QzlWNDl5alhCQUFIRUdhZHREV2ZseXJoU3EweEdhckpF?= =?utf-8?B?WHZYU2pEOGp6S3BGZ3lkRDYwc3ljdGxNbkVwc2FKaW5EUEtjN2VNVHBxaW9D?= =?utf-8?B?QTgyTWE4ajVnUXZzMHMvUXZ1ZHNmYnYyNzhRMGZmTEkvRDFNZmhPbEVBVlBP?= =?utf-8?B?ZWdjUFZFUW9XYm1jbXBBY3lxK01oNlBOdUVBME91c1lwWXEzME56cUI2cTFW?= =?utf-8?B?UmFNbVM2SUpkQUNpaityVkxtdmUwaDhZaWo1MENzSERIVlBUQ1BoNWdPNExl?= =?utf-8?B?US9USUlFVWdkbERUajM4ZUNSSU01RFF3SGllemZpYjlUTVRuNjVRRHVTRGFa?= =?utf-8?B?REdwWG1UVUFXRUx2NFAwTXlqQmF0Q2pleVBxRDlnWWV6bUc3YngrZ3k3UEEr?= =?utf-8?B?dVJQSXp6Qkt0WDk5aFVsbCtPdHF4dHdTZXJKeWt3OU40Skl1NzVhQkNKZ08w?= =?utf-8?B?ZzBBdXkxMGRISXFTN2xXSElteHppSkloSE5VWEhJMzRoMElSanlXV3UyM0lD?= =?utf-8?B?UDlpOVQ3dWl1L0RpdkttVG1EanVPTTNjR0xVbGVIWGhvMmRRRzhuNkozc3JD?= =?utf-8?B?bmxPNG91YlNEYmI0b2xoYWhYRWo0bEl6Q1dkWVNneDFqa1R6blVxbWdZSTlE?= =?utf-8?B?UkV3YVR0bWxIMS9tVC9wcEp0WkhEYXMxdWFwbG9mdExtV1lmT25hZnIvUVJE?= =?utf-8?B?ODN0VHdiZ0I2T2JlK3ZJUmV0em1NN0RTK0lHM3kxYThZZWpNQ0pUdThxY1FD?= =?utf-8?B?ZFJyQXpwQkRFbEU5ZytpVCtCeXMxU2ZmSU9jclllYWN4NDlJYWptam1Zc21k?= =?utf-8?B?ZCtDNzczY2QxTXFGOXhQMHdjM1dkdVBGUFZ3RVNlZzBpSEtCbVg0ZnI4MXpo?= =?utf-8?B?NUJYZitTWDBHa051cG44NE1GOEZ2VlBzdGtveUp4VEVGaXFwV3kwS1ZKNXhY?= =?utf-8?B?SDRyOEdQUU5XeWRVZVNJTXB4d0lDTnVsTEJjbHhURHIyTkwvei9xUFJKQjZU?= =?utf-8?B?UlVpRmx1RnBOSmltdTNHQVZlNzVyWm9wYUtsUHhTRkJHUkcrWXArelFjTDZk?= =?utf-8?B?MXZhMVJUeElCRHh3NitQV01iTTVJc0lXSEo3SmdvZWUwb1E0dkhsRXc2blVB?= =?utf-8?B?Y2dMbTA2U2Z2U3MvRE5ia3FOeTdVNHlxMm5vNFAxb2ltaW96RGs2V3duTTVl?= =?utf-8?B?VVlQWWZ3V3ZDSlZEc2hVNWNNUzdhSnJGYk5KUnRhdVk0YUZKelgrMEpIaGln?= =?utf-8?B?d0N5aFJ5cVBDS1Vkclo2OVpSR2RuaXFzZDFlRUVUQzEzaE1GYzVNckhwQzBU?= =?utf-8?B?bW9vTUxqbVZyLzBrTEZCd1loZ0xHclprbnpRWUNGTS9VSjg5bVJaVTQwZWh2?= =?utf-8?B?cnZ1dFYxUmtpMG1BV3l2bUR1TGxYcFRFZ0R3Tk4zMFlKanhWL21QUWd2bnps?= =?utf-8?B?bkpOakczM0s3d3puZjRzTklHeFUyOEdwZWpaSG01bVg2dmJvbkhEVXJYYVYy?= =?utf-8?B?WGM3TjJ3bkxvdGFublRIZWk1cU1LenVVRGFDMHFSYld3cTdkbFovSDhVOTJa?= =?utf-8?Q?q4AkSeoolmNrW1SmTDxPZHjNq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f226e0a9-4cd7-4af2-6022-08db9980a7ed X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 09:03:25.6505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BoxxIgcJrSPRZzF5OsTyNubsDii2ukvoJDim39Q7PVo30nv5Ka6/mcyg3B+Z42aG0ypW90H+n+jQCJSYHaC7sQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9082 On 10.08.2023 10:39, Nicola Vetrini wrote: > The functions and variables touched by this commit can be static, > as they are only used within the same unit. This in turn addresses > the absence of declarations that violates Rule 8.4. > > Signed-off-by: Nicola Vetrini > Fixes: 741367e77d6c ("mce: Clean-up mcheck_init handler") > Fixes: 45f57813f646 ("x86/MCE: implement recoverscan for AMD") > Fixes: 155587481e39 ("x86/microcode: Scan the initramfs payload for microcode blob") > Fixes: af50dd63cf8d ("Pull nmi/traps changes from Linux 2.6.14.") > Fixes: fef244b179c0 ("x86/spec-ctrl: Knobs for STIBP and PSFD, and follow hardware STIBP hint") Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:07:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582007.911509 (Exim 4.92) (envelope-from ) id 1qU1dt-0005pm-6D; Thu, 10 Aug 2023 09:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582007.911509; Thu, 10 Aug 2023 09:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1dt-0005pf-0v; Thu, 10 Aug 2023 09:07:41 +0000 Received: by outflank-mailman (input) for mailman id 582007; Thu, 10 Aug 2023 09:07:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1dr-0005pZ-8g for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:07:39 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060b.outbound.protection.outlook.com [2a01:111:f400:7e1a::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 57f17162-375d-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 11:07:34 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DUZPR04MB9984.eurprd04.prod.outlook.com (2603:10a6:10:4dd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 09:07:31 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 09:07:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57f17162-375d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8ylhUali3Jy9lfS2EgcC6HB8FcbpeC4Sae5+BxegvUrwuriXE2AWn8YAwQP6zgdq/0Aso4GSAgciGun5AJE7aGJJrBP1mloyQFGku2aUQtZG7Rq418mi85qqfRoINDaMoTGLRe0eDCxphq8ElypmsHZzSYcfTMpWKx7oL5Hx1qbH5Wb6Dwj9CyqC1WPEiHl7nJ4fRpjJ6wSlzxTweX/Sk0T8Py3rasRVZcYJNS90kMahckD1VMQK3chc+PYHBKTQKt6feMzqxJlYivuk2GgS7LQqkEAe7UZ0W4QmjvRrE2E/XdG6XjrrCmBEixVZniNjaA05c22/YiHbJXTtk689g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1FfYYbck8MBH1DVoDjc0/M+BwvqhqkOAj+HgnVrQoE=; b=UcJFgzdagWpNDwLSdnVRvOGn/ozq9gekXkbcysm4LupOuQASIuqZ9ikF7ZxXR8zhodE/4P5GaLRFB3Dw3SY9IEYtcmV4Be/BEfEGs0mzdVkczDvJWOLwDAR8lezBVfOQqC6/y4RHOY15wc8lMNNC+7C7FFsTuGEGTWKufqiMvvT0cxiZSU6pG2yQbSyNFWPB20aJECxp7X4RLae6avhcM5qUt6RgTkQZ+enjKyt6HoqXR8X9tCcXF98EyZxWn4deHqvV3yra7R49uvlpimqmyds7kiqqPSM+G94Q/RNSG27hGFWtnAS2MPoMpnjr5a2Ou9RrFLurZieQBwES1yyz9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1FfYYbck8MBH1DVoDjc0/M+BwvqhqkOAj+HgnVrQoE=; b=kLXiUs9skEVjseB647z4e6FkPCSGwyC53hFDVqLTEF9pWI0iBVWttMy0RBzTd/OghKvEQGxJ9BDSYmhV2aTGFsKlmTzGp4sUeQq7GEX8d2nRsPquAb0RvN6fE73nQ0eUJsrJU2wJy6zfqslE5QePCuHm/sI4jtynOGJGgxVsgCUDK3lq47Wvf9SkkKlTeyaoRvEuesKqkWRmiDjxLGRCW5koOt/baXXyrjb+6He2h+0Z0WjaVNGGsxSvuCwch8sWk9uNJFVY9sMh+NPIPasWzP0x21s98AYEehiUeimPzT/h8hMYpTW+M4RTdeMO8owvTe9bUPX/YBVNkk2UKEEejQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 11:07:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: Moving Dom0less to common, Was: [PATCH 0/5] Fine granular configuration Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, wei.chen@arm.com, rahul.singh@arm.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , george.dunlap@citrix.com, christopher.w.clark@gmail.com, dpsmith@apertussolutions.com, Luca Fancellu , andrew.cooper3@citrix.com, roger.pau@citrix.com References: <20230808080010.3858575-1-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DUZPR04MB9984:EE_ X-MS-Office365-Filtering-Correlation-Id: 569fcf97-5d3a-4f9c-4604-08db99813a9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z8g2vIuUbs9dvTOgL3xXzy2HhSboF9jA6/9j3w7p1i3mSDx+VXUB7vB3rOoZbCXyklsRUadudItCP9CV4uadHF3wx9qgk5FU6nopnQNfxPxbxrV9NAJXX3jm08ghOMwe4EdB+yItcwW3s62UK3YAjLXglypBO3CTrk5xHy1IAQq2ZMgzUgx0QBAwMOKpzFxGbe9+Ov5JmIa+ixurnVkaMrrZecUKA8UtJt09JPYMNmvyZ1AEosLdmemXfQIJQFZGTcOzYvA2ZamSJEB0OzuSp8ZQdWRh3qp0t8M7RrkeGl1iklNPcot97r1FbTqY3YVhmPVvdLJc9ExBWI6Pf7aM97NhqCS9jg+olDdvfystMoCJjpavHzMNRoa8hnnrOLY+CMnfR2iWOD13t1D0uV9VDe44qdSkoJ5A/Ve81xTxctGqZ+D+6+Dp/vZFCK+d8DYwVvx+EZOSV7kEz1mwq0YAhdxr+XkrPr0f37QY8LTnYYqnGVOb4VJEvA34snQY79Qavl2qiD52oj2tA0erijdV0QKiSmdaln2gziRKgIQIfS6DlYS+lkGyTi7lc62HKx7WG91RsoHLUzZizUXJO/WWTP830Yn59G1leyLeKxa0oXssZCrz7AsKuWzUC1xRZH6zjdtQRNdKkhihw9bpbgfIGUfQ53Bj8vy5dppobFHIJJ8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199021)(1800799006)(186006)(2906002)(478600001)(36756003)(4744005)(26005)(6506007)(53546011)(6512007)(6486002)(31696002)(86362001)(316002)(8936002)(8676002)(7416002)(4326008)(6916009)(66556008)(66476007)(66946007)(5660300002)(41300700001)(38100700002)(31686004)(2616005)(54906003)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzlVcVdoY1IzbWFGRVFrSkdEaDNHV3V4ckNQMFp6ZFk3eStydmFOeURrYTNE?= =?utf-8?B?QXRkbVUzdGYxQjFtSGVjb0lZUzY1VXpwWHhYU3FGNnV3dlVQaEhkVEFqY2RZ?= =?utf-8?B?VWlWbWE4NGRXTlhLb0VJZ05rSzYySFBvTHZsdkNHcWNwaWtMd2djVUlZTDZw?= =?utf-8?B?Q3ZjMktUSTZOdllBYjAzL0tGV1BFQktpTVlXTFVxc0xQN0dlN1FFT1hLVU5T?= =?utf-8?B?eVR6TXV2eTAxYmRmYTh3SmltMWtZeUJnU3NGendwQWVaZU50TmdGWml1dnFK?= =?utf-8?B?U1hkK3JRM0tzTmphVVo2OFlSTkpmbkM5L0V0K1A3cG1lTDVVWXpLUjAxY3ow?= =?utf-8?B?QzRMM2lRZjlBTk81eGMzMVRTYW9JbXlZR0xLR24yTHBTVCtjd01YQVpUQ1E0?= =?utf-8?B?aTZDYzM2a1k5WUNWcWhBaXVsbzE2eEZIL1pUSzhUSnFwNGFXV3hVQ21iQ0tN?= =?utf-8?B?aEpLbWJ3THFZcko3TU1mSVBMTXBCRFZkTlBtYS9YNUh2dEw3M08vNm92U0JH?= =?utf-8?B?MER2OCtpZm9HdmNCa0hWSDk5Z3A5dDFCbGFkSmxudGI5ZzhORldwSGRKRStQ?= =?utf-8?B?aDlJKzZNMWU4WUNaVVhiMSs3eHVJcjFvQlhmV3BNTlU5SnI1bHpCR05BYTlj?= =?utf-8?B?d3pPSWdKMm8xRkJTeGdCRnlHeEFOVlllSC9vRUdUQjJiWDZyd1ppVzByTmxY?= =?utf-8?B?T2lKTFpBb2I3Y1BhOVN1anRvRVJVeGw0VVR2SkZZOEZUblJKSlhzMm9NL2dy?= =?utf-8?B?Z3ZxUG1Rd3ZIc0lmajRoeVhFcVBQZlZPd1V6Vnd6Z1NyS0I3VVBRMDhGeTJL?= =?utf-8?B?STV2WkFISzBvMWd6THZEMVdMdTgvaDNTT3FOcW1YcjFoMEQxRmVOMllsSThj?= =?utf-8?B?T1VETjdjeERXcnVMV3BwL2liNjRWak9ScmlKQTd4aVRzdlUwWDhmS2lUZ0Vm?= =?utf-8?B?bTRMTlRtU1pHd20zWEphcE1oS0JXNnJqQmsya0pHR2prcnZnS1dxWU1oRVNH?= =?utf-8?B?QlVRQnN3UlUzdUFoOEJvckNkbVNmbU13cXdKKy9FclpwZ2lvV3hINlJxZ1JF?= =?utf-8?B?UkJLdHNrRUUrUzVYWjd3dk5WR3djZUxHM0k4Z1FwWGY5VUFmY2dVbERwMSs1?= =?utf-8?B?MHh5SFdYeXd3eXhPem5IakR4Y2tSRWc1dE9oZVBQSVA4d3E2TXUrSGtDYVFI?= =?utf-8?B?L0h0NGxObFhjeFVMSWMvdkFaYXJ2am5lbFR0YkNXZUhlZkR0Z3lJdkFkMVVX?= =?utf-8?B?dGV1MGVlU2gyczFvQlRJYzFxa2Rxb1FXZUt3MDlVcnBwNnhqQ2s0ZlM1WlF5?= =?utf-8?B?d0pEWFlYNWhqV08xVThRN0dOZGdtWXBzVCtxN1BPUHF4K2MzakFiNHVYQ014?= =?utf-8?B?cDdzOFQ2U1RQNXNNRGJiMEVacEhQTWw5d0NpZXNJSGw1SDZ6b3ZOaEpBc3lV?= =?utf-8?B?NHNIbzkzL2pXbFJtSmJXcHJSb0FDMG1HTCtkQk5SZ0NjbGtEeUZldS9oeHox?= =?utf-8?B?Wld6WFp0aHV6ZzhuMTlmdnc3QUZrMFRGZXRSRGpMOWs5REhGdFdLVU9mTXRv?= =?utf-8?B?RVZxL3FoRVROK25uRi9NcjV1ZSt4Z1l3bnZOQnRnMmxBMytjcE9aMjRYQjBS?= =?utf-8?B?cDh5RDd4TE53RzQvaUExalRhZ2ltTDd3UG5KbWI5Z1JqSUhUUC9nZk1NVHBv?= =?utf-8?B?aEtHRjRtQmRSanlmUm5qc0loajhCdDl6Q2U4WVFkcWsvR0dKK2VZWXhoR1JC?= =?utf-8?B?Y3IvRGpIQ2ZSd2JkbkpBZGxTc3RBQkNaZjE3d2txVm9ZTzIyNzF5cTVETmtr?= =?utf-8?B?Vm1HWnIvanV3L3FpNTQ1RkNBeDVLQzEycWVnR3ZVSjB6V3Ercko5cHNqaTR1?= =?utf-8?B?UlNBS0puQnd4SUswK24zZlRCSHIzOGM0MmJoRStPSGhKeHBoOWRwTTJuN0cy?= =?utf-8?B?YXRwdjlTa1dRRHpya0VIUlRwclVYaDQyL3EvZlkvR2ZBT1RuTXBWdFUvZXBx?= =?utf-8?B?U0xsekJYRFlHeXhOSHJqbjY0VzNYd2ttU21Od3puUnIwUGRZaGw3ZTF5TkF4?= =?utf-8?B?N0ttWW5LbVhFYmVxWktNaWZIb3hIUFZQaHVSbFJMNHhlS2NPc1E1V2lJUjY4?= =?utf-8?Q?ssUG1g96Hts5wVMFZZ9JDFoww?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 569fcf97-5d3a-4f9c-4604-08db99813a9a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 09:07:31.7383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ocXqtzDwDl0IQsEjCjCcfa7qpmBtOz2GT6iEUmx2MashzCvf9FXCscJVQ45zzCFJ2j7t5+HMbJKkUDXMWJzAvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9984 On 09.08.2023 21:51, Stefano Stabellini wrote: > Would the x86 maintainers be OK with it too? Of course further changes > will be needed to make it useable on x86, but looking at the series from > Christopher, the two sets of internal interfaces (dom0less/ARM and > hyperlaunch/x86) are very much aligned and similar already. Moving common code to common/ is surely okay with me. How much wants moving is (apparently) a different question. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:25:24 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:25:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582014.911518 (Exim 4.92) (envelope-from ) id 1qU1ut-0008KW-LF; Thu, 10 Aug 2023 09:25:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582014.911518; Thu, 10 Aug 2023 09:25:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1ut-0008KP-He; Thu, 10 Aug 2023 09:25:15 +0000 Received: by outflank-mailman (input) for mailman id 582014; Thu, 10 Aug 2023 09:25:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1ur-0008KJ-HC for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:25:13 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20601.outbound.protection.outlook.com [2a01:111:f400:7eaf::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cdb9703e-375f-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 11:25:11 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS4PR04MB9649.eurprd04.prod.outlook.com (2603:10a6:20b:4cc::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 09:25:08 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 09:25:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdb9703e-375f-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=icnt9KSl8Od1ggSs4QerhHUn5Ye76Z0Sj5qsTm8HY1XuGf0exvAq8e76h5LpwGFAWtIN6G2ld34M4InpK4wzl22BWAIC29Z7zPY5Wlfpm75cuyUcHn1Wf+t2J/NEirKc5Y7MG/05sFaYmUdNG4upm9/+sua4rpP18b+2B4n/fiPBzXHSEbrrStFKGg9YW8vhXm2ND3PKKnQbkT42vt76MCxO1/dSZjDIFe9w9uyvKY3JKzacY11MMEAqubREiSHlZ7fSXO9tQmghogdpRGWLmhjjSi3yfIUGTBToP0P5gA8GjLbwV65yPtD+Ewcq+Qhr2kRKFLUPHhs9I5WTkBWacA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nFh5j+/Ea8FtWyGUl8QN8SBTkjmEGr3KdohpylwSnao=; b=BkiI2hbYQPw/+MhjMCh1uPBf3QGMqthmFiL30k/dLTCBMxH9ZkjIs6pRm4dt3lYOyrQmMOoZf4G+Jy4Q/aiEExa496tmFZ8HKmKrhBqKdLBhH81driaYGc5r+1j8BKXLWXxSKsnrU+UWfvTkxLzytvxGXU8CC3o9PmxrK1ujz8APtft5PgLw41mgg8JhJrpLrVEAX9gO6yIb+0XznMO3H8JSVjysHK3eOMdEiSZvRaoV85fKYR6ZJSRrWd3tS/rhMK/ECa8ib4E4X8Yvnq+JwcobuzpEwzgRp3zaxqzQxT9HbUlDWShKXg3k8hYz7sNt1A8bfh9XjH2ujCHMdre3rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nFh5j+/Ea8FtWyGUl8QN8SBTkjmEGr3KdohpylwSnao=; b=egBz+q7N76Odoa3tSBAZGxX1yzEfrxi7p8VssA6EXux8SahGyvAesdqjMi0Julex7SdLoeSO5iPVgTauUNvLTtyzS4Q7TD651zkfZMHxP0Kzb34vKyh1JALmkHSasvfQNQYTg3m2qQLiGUOMTyx2ZcIj/sq6S9CaiTIqhxWLOx99tstSEQY7arotQQb3k4bI3tkIAHv1ctgAXxN3vNcG36klufRhXOXAo2Lfnrz/G30A6cQigdh/aE+1cWn4k9NCXsv0dniSqVCO/Zfxycxnup/S2O57vlhuSKLpn8B8stUMYy3ECNXjK64IeRjl+qJn5IvLXPtAO+GhhuQJKgMchw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c707388-bfb1-1a06-edb1-8046e8c1611d@suse.com> Date: Thu, 10 Aug 2023 11:25:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: x86: AMD Zen1 Div leakage Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel References: <9072ddad-3f79-42fa-1e6f-352c9796ea52@citrix.com> From: Jan Beulich In-Reply-To: <9072ddad-3f79-42fa-1e6f-352c9796ea52@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0190.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS4PR04MB9649:EE_ X-MS-Office365-Filtering-Correlation-Id: d6906607-fe74-4559-0b10-08db9983b08c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uE8ee6vwAKYJdTV8MkV4yy53boHlPGlVruj0k3SXXRk/0yL/VUbJ6vv8e3SMZMjjTwbWhgI8cn3PnxWkPbVNqJnNrRIbQdxzxVXVipHSoRx6UWSkPdKdnWetargFDnuXtlh7g2vDI5C+MskvE/Fblc1paBSnPiXPA8vHZ6ENy3OrFR5oOblSOXPa0BAhxxjTXtMjTf1P2ZQQ7g2v0IMg5cco6zq/E0b5ex/dzBiUHU7lUM3NYnoUYge6dAD20Q3OVVlYYkb3oAJpl32UEFu7KqefPdi4IHLyJ3LsBoDeeNK6HxggC1Iwqih9SRhBQvc2Znuf2G2CTSXte5KQP9w+wVn6B/fYy2jnFKytUrtYH8Yax7CrbjLG7W1aBiRB0vXS6SCCZgoo32aj8sUCowfthVemQPh+4MyW+NDD802zClH+ftsSZAhSpYjzOPeXJ6aKyfPndMXB8+mpWAgrkA8d4dMw7T8y9OOOnkwmT0EfxLcr6xrrr9DNUR/+sNDPHBREzPKby11YszDYJLPln6iPBIz3y0peEpi9BgLkA7y9c9D0hz2V6zCdn2scJkewUjSnom5ygW77qyltlF65ZQJTklFJSsxEoNWnGk+yiEBz0RPkOmumOXtkXDmGa+EWky0bm5/fYZwXKlPPpXpdSj9/gA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(366004)(136003)(346002)(396003)(1800799006)(186006)(451199021)(83380400001)(38100700002)(54906003)(478600001)(26005)(6506007)(6512007)(966005)(6486002)(4326008)(6916009)(66946007)(66476007)(66556008)(53546011)(8936002)(8676002)(5660300002)(41300700001)(316002)(2616005)(31686004)(2906002)(86362001)(31696002)(36756003)(66899021)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGFUTnNtT2RrSHZKN3pPYTRHd0FrZ2VDbW8zeHBoTXZ3RE8zUWFKYkZaTHA2?= =?utf-8?B?MVpNdkU0Nk5EcXBRNnMydEFYcFNoYllOMTU1MXdUNFRLc3JPaGVDazNueXdF?= =?utf-8?B?cUhNaUlSbSsyVkdBK2dvalNGOFYrYUc2akRERXJDVkFMMDVCbE9sOFZtemNw?= =?utf-8?B?RmNnNVlGQVFleXE2cS9ycmE1MXlJaUM0cjNlenZPOEdldlJ3aWladjB1SjdE?= =?utf-8?B?M1NydW42MEh1dmdRZzV0cmFKMlVENHo4dlB6Q2RZanlvbHdiR0xlN1IrYzRs?= =?utf-8?B?U0JTR0piSSt3OWhZVk9LNWZGb281VE9zUkVxcVZwSDVWeWJUMENNekZRd0Z2?= =?utf-8?B?amkrNHBMYXEyR1VxUGwwUm1rT0RhczVhbldWZjlwc3l4VFlTZmRmdmd1dGtS?= =?utf-8?B?VlRTZjlRYmpOQW1IUHFmQzZOelJXK3RpR1VROXVXR1o1dDE5dHd1OHVjbm1I?= =?utf-8?B?dWp3TUljTUNnd0R0WlR5MFA1YkEvSDNOQWpMUVdsQU84VXloVkpNaVlGVDdF?= =?utf-8?B?U0RwcFBWdEJiMXJFMDlLbGIzbWxDMmxYRFBxbUorNVMzTi90UUw0Y2pDbTNX?= =?utf-8?B?UFJlb1RHQ2lhaW1KbDhXV1lhMytET1FUY01oYkIvdlhWOFV4Nk0zZm5BZDJm?= =?utf-8?B?MlV1N1R6Y3V4WWkyYVRobHFSSS9DL3VCTS9tcm5lbytRcWxuMjhXRTZyaHNm?= =?utf-8?B?T2JmL3Yxb2lSdml4U0FqOGhwbEFTa1VkNGNlNGVMYXdoQXBsM29vWHVrUGw4?= =?utf-8?B?V3VWSTJxQlBFZkxldDhXUm5EanBMRlV4cVpDbTJCTUdnb0NlMmwvY0pJS2oz?= =?utf-8?B?bVo2aDBlcTZjSlBuMTBweklyeEpUcTlXSURwUU1IWmYxVWlNQ3BzN2dKRisr?= =?utf-8?B?WExadUY1L1RSN0I1WkJLNXZYS25DWnJlK1NMZi9FU0JRRGRadkxFNC96T0F5?= =?utf-8?B?SHB4alZXM3dvTHlwcXQ3ZzVXdXVYUUdMTWlqZVpnSXRpYURvOTZpdmh1clpl?= =?utf-8?B?Z2dSYTBKV29SaGdMeWs3TWp6ei9ndVQzc3A5WloybmEvaGp2WHJHb2twZGNk?= =?utf-8?B?aGRqTjRacURZaFc4dlk2YzZOZWpnemZYNHNFcFk2TmRXd2ZqZHc2RkdJeXFM?= =?utf-8?B?cFJUcllPSHMvMmkyeG5xc1EzdDhWZlRNY2VqdWxOK1hVVko2R2FNTk5OVnpu?= =?utf-8?B?NlJrMks1Y0xsZVNNd1pFR1hGSWVOYmlWS01BT1lPcVlWZVpQdXRGeHBGdHdE?= =?utf-8?B?ZStrdWxvcFNhOVVxVEpzSHl3V252ekJaV0FrbzE4VXlmK0E5NFk2eXhOWkhD?= =?utf-8?B?cmRKcEFsWnJOSXB0U1hnUmlZUFdncE5oSmo4WTc2ekh2Zzh4SEx0N0pNT0hx?= =?utf-8?B?MUxJalp2Z1BGUGJzdTU1bGJSNDZKM243b0ZqUWEyNmNtbGI4a21uUW9lczhl?= =?utf-8?B?QzlCVTh2UC9yTE0zZUsvYW1vaE5IaG5zaDZRVHhVSGJ1bkE0dVZXMmxBcHQ3?= =?utf-8?B?SGYrcVEwY0ltOXNZbmtkY1hMYXN5ditYRGwzc0txT0pyTFNJaC9IUDJDU3B0?= =?utf-8?B?VkNnUitneEFORm5USWFERXpPNVBRcmtWVFFiSGpKbnJGUWo1ZGgyaU54V3Jh?= =?utf-8?B?UTM2QnptNnluaXREclROWHlCL2kwQ0VIZUNCSDhIUThqUlJpYytmRGRXUnFp?= =?utf-8?B?WmR6VVhFaWdRVFNTaWhFb01TS1ZuWUc4QThoZ2pNbXJpcGtMZGhwWGx0TFZZ?= =?utf-8?B?QTBQbzZwdC9IRjFvMkt4d2hVdDE3bHdTVjZqQUd5RGsvOHcxVDV5TnZRbUxY?= =?utf-8?B?QkxYRXZKNU84UkJiTDF2bnRkWlY0Mm14N0NwRWx3Ny9KUWZpc2lvVFMzM3A0?= =?utf-8?B?eHllaGVaOWF0eFhFUnZobEV6UFVnejNIcmRLbjRFSHpTbHF6ZXZQeGM5U3Fi?= =?utf-8?B?ZU92UldxbVVZam5DT1FaajRUY0YzYjQ4WEladTFYblJjTWg2eTg1WmFRK3g5?= =?utf-8?B?eEd6M2Jnd3BQVktKRWpYeExPUDVxOTVENndlMUVORFYvcFA4M3ZnYmpaNEhq?= =?utf-8?B?azdWdDgwMlh4ZEs1dHN2UE9nc29GUTdoUFVSd0lXMkNIc2pRNFFVWnNzNnda?= =?utf-8?Q?jzkmhHPOSTqoDP/GLvwLqcp6B?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6906607-fe74-4559-0b10-08db9983b08c X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 09:25:08.6386 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9C9vKJ1u5L4NGBLjekkDignfd1ijYJ2QUWY+poDstBLjbCav4cCAnLTF6J/YSkK+7HdGgkjkSVLArc29U0jfRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9649 On 09.08.2023 22:29, Andrew Cooper wrote: > This popped up with insufficient time to organise a response before the > pile of fixes yesterday. > > https://www.amd.com/en/resources/product-security/bulletin/amd-sb-7007.html > > Per my current understanding: > > * There is a single integer divider in a Zen1 pipeline.  When SMT is > active, it services uops from both threads. > > * It latches the result of the last calculation performed, but forwards > said result transiently in the case of #DE (i.e. meltdown-like). > > If this is accurate, then there's a nice covert channel between the two > threads, where they can communicate by issuing specific divides, without > ever leaving userspace.  (It's easy to hide a #DE in the shadow of some > other misprediction, and not suffer a real divide exception.) > > But, div isn't a serialising uop, so the advice of "don't divide > secrets" is tantamount to useless.  Transient execution can pick up a > div uop from any misaligned instruction, and end up caculating on > arbitrary operands. > > > In SMT=0 cases, we can scrub in Xen by executing 0 / 1, and would need > to go in the same place as VERW on Intel (i.e. very late in the > return-to-guest path). Executing 1 / 1 may be yet slightly cheaper, unless there's special casing of 0 as the dividend in hardware (in which case I would wonder whether then the result would actually be latched). Is putting this on the exit path going to be enough? Without also scrubbing on entry what was latched, speculation inside Xen could be "driven" (to a limited degree) from the outside (i.e. spectre-like). > In SMT=1 cases, I can't see any fix.  It's very much like L1TF/MDS, and > cooperating threads can snatch data a cycle or two after it was placed > in the channel. I agree, ... > As yet, I haven't started any patches to this effect, but it would be > nice to have more clarity from AMD first. ... provided nothing new turns up in what exactly the issue is. The Linux commit that attempts to address this deals with this inside the #DE handler, apparently assuming the issue can only occur when #DE is actually raised. Your (and my limited) understanding go in a different direction, though. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:30:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:30:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582020.911527 (Exim 4.92) (envelope-from ) id 1qU1za-0001Gs-5q; Thu, 10 Aug 2023 09:30:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582020.911527; Thu, 10 Aug 2023 09:30:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1za-0001GG-3H; Thu, 10 Aug 2023 09:30:06 +0000 Received: by outflank-mailman (input) for mailman id 582020; Thu, 10 Aug 2023 09:30:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU1zZ-00014T-Bg for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:30:05 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7bb95a11-3760-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 11:30:03 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id BED7F4EE073F; Thu, 10 Aug 2023 11:30:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7bb95a11-3760-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [XEN PATCH] xen/arm: traps: remove unused function 'dump_guest_s1_walk' Date: Thu, 10 Aug 2023 11:29:50 +0200 Message-Id: <23c5b1a1ffc755b5db17d699a08fc86e1f0cc788.1691659744.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function in question has no callers and its removal has already been proposed (and acked) as part of this larger series [1]. There have been further bugfixes to that function [2], but they do not add any caller, hence it can be removed. [1] https://lore.kernel.org/xen-devel/1395766541-23979-27-git-send-email-julien.grall@linaro.org/ [2] https://lore.kernel.org/xen-devel/20160720161017.4508-1-jtd@galois.com/ Signed-off-by: Nicola Vetrini Suggested-by: Julien Grall --- xen/arch/arm/traps.c | 57 -------------------------------------------- 1 file changed, 57 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 7baddfdc57b3..46c9a4031b30 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -1686,63 +1686,6 @@ void handle_ro_raz(struct cpu_user_regs *regs, handle_ro_read_val(regs, regidx, read, hsr, min_el, 0); } -void dump_guest_s1_walk(struct domain *d, vaddr_t addr) -{ - register_t ttbcr = READ_SYSREG(TCR_EL1); - uint64_t ttbr0 = READ_SYSREG64(TTBR0_EL1); - uint32_t offset; - uint32_t *first = NULL, *second = NULL; - mfn_t mfn; - - mfn = gfn_to_mfn(d, gaddr_to_gfn(ttbr0)); - - printk("dom%d VA 0x%08"PRIvaddr"\n", d->domain_id, addr); - printk(" TTBCR: 0x%"PRIregister"\n", ttbcr); - printk(" TTBR0: 0x%016"PRIx64" = 0x%"PRIpaddr"\n", - ttbr0, mfn_to_maddr(mfn)); - - if ( ttbcr & TTBCR_EAE ) - { - printk("Cannot handle LPAE guest PT walk\n"); - return; - } - if ( (ttbcr & TTBCR_N_MASK) != 0 ) - { - printk("Cannot handle TTBR1 guest walks\n"); - return; - } - - if ( mfn_eq(mfn, INVALID_MFN) ) - { - printk("Failed TTBR0 maddr lookup\n"); - goto done; - } - first = map_domain_page(mfn); - - offset = addr >> (12+8); - printk("1ST[0x%"PRIx32"] (0x%"PRIpaddr") = 0x%08"PRIx32"\n", - offset, mfn_to_maddr(mfn), first[offset]); - if ( !(first[offset] & 0x1) || - (first[offset] & 0x2) ) - goto done; - - mfn = gfn_to_mfn(d, gaddr_to_gfn(first[offset])); - - if ( mfn_eq(mfn, INVALID_MFN) ) - { - printk("Failed L1 entry maddr lookup\n"); - goto done; - } - second = map_domain_page(mfn); - offset = (addr >> 12) & 0x3FF; - printk("2ND[0x%"PRIx32"] (0x%"PRIpaddr") = 0x%08"PRIx32"\n", - offset, mfn_to_maddr(mfn), second[offset]); - -done: - if ( second ) unmap_domain_page(second); - if ( first ) unmap_domain_page(first); -} - /* * Return the value of the hypervisor fault address register. * -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 09:48:33 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 09:48:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582027.911537 (Exim 4.92) (envelope-from ) id 1qU2HL-0002y5-KN; Thu, 10 Aug 2023 09:48:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582027.911537; Thu, 10 Aug 2023 09:48:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU2HL-0002xy-Hu; Thu, 10 Aug 2023 09:48:27 +0000 Received: by outflank-mailman (input) for mailman id 582027; Thu, 10 Aug 2023 09:48:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU2HK-0002xc-If for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 09:48:26 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c24e722-3763-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 11:48:24 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 9D5554EE073F; Thu, 10 Aug 2023 11:48:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c24e722-3763-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Thu, 10 Aug 2023 11:48:23 +0200 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: Re: [XEN PATCH] xen/arm: traps: remove unused function 'dump_guest_s1_walk' In-Reply-To: <23c5b1a1ffc755b5db17d699a08fc86e1f0cc788.1691659744.git.nicola.vetrini@bugseng.com> References: <23c5b1a1ffc755b5db17d699a08fc86e1f0cc788.1691659744.git.nicola.vetrini@bugseng.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 10/08/2023 11:29, Nicola Vetrini wrote: > The function in question has no callers and its removal has already > been proposed (and acked) as part of this larger series [1]. > There have been further bugfixes to that function [2], but they do not > add > any caller, hence it can be removed. > > [1] > https://lore.kernel.org/xen-devel/1395766541-23979-27-git-send-email-julien.grall@linaro.org/ > [2] > https://lore.kernel.org/xen-devel/20160720161017.4508-1-jtd@galois.com/ > > Signed-off-by: Nicola Vetrini > Suggested-by: Julien Grall > --- Wrong mail address for Julien, sorry -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 10 10:44:25 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 10:44:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582034.911548 (Exim 4.92) (envelope-from ) id 1qU39I-00010x-NY; Thu, 10 Aug 2023 10:44:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582034.911548; Thu, 10 Aug 2023 10:44:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU39I-00010q-Kr; Thu, 10 Aug 2023 10:44:12 +0000 Received: by outflank-mailman (input) for mailman id 582034; Thu, 10 Aug 2023 10:44:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU39G-00010k-V7 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 10:44:11 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20624.outbound.protection.outlook.com [2a01:111:f400:fe16::624]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d5c78f48-376a-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 12:44:09 +0200 (CEST) Received: from AS4P192CA0050.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::12) by DB9PR08MB6620.eurprd08.prod.outlook.com (2603:10a6:10:256::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Thu, 10 Aug 2023 10:43:55 +0000 Received: from AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:658:cafe::a9) by AS4P192CA0050.outlook.office365.com (2603:10a6:20b:658::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 10:43:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT039.mail.protection.outlook.com (100.127.140.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 10:43:54 +0000 Received: ("Tessian outbound f1e964b3a9be:v145"); Thu, 10 Aug 2023 10:43:54 +0000 Received: from 067061d4fe19.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A0748E8B-85B9-4EFD-813D-A63B24F0D234.1; Thu, 10 Aug 2023 10:43:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 067061d4fe19.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 10:43:17 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AS2PR08MB8748.eurprd08.prod.outlook.com (2603:10a6:20b:544::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 10:43:15 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 10:43:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5c78f48-376a-11ee-b283-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvKQEDV988SPsQdqQ0+s2cfZqy8DBe4aB2q5bJS+yMs=; b=hGkh8mrNMLrAUtOoQIIMuC/QS59W8GNo/K1i/cRh4wut/Bzze49GH2M2/TfSeu1+mWfYhPdAFV/07s4l15vvRzuta2h9qwEJn1DnepnxQwA14izfedb4HAj4nNp7Zniy0q4b0qeRr2FytFPMC1bTNC3YReAKlDcm2A+PVuAFdC0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a07e27998903aa80 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/k11OXR8aWXsm1aAn94tZoxwoYib6j5oTgr2ktXuHiRmuN1pVgzLuKNn6yvVhkH9vh6ZpHH2E/krLz+XzbwQDF/cwQsCKqBNCcfyP3LZi3qmD7/AEJIjgVnjKwYFAy6xI6/uTMiDC7TQR9CWBWLTJ1EW1bKtwoaQiuUCO8sSTp1Ge4zUlZjk/mfqSpsD99BMCD6eZofAyyNANwQBJYSb5jVmKtYHPmv33W7GT282L70UptePbl13JSF5TytqXc0sxXZorEWlRs6npOwdUx06bpoCitAYojw2/JRaPmWhsV86S96P5cV3sdM227P5yNXJdSZ1LcVbLKF97qetRLVIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BvKQEDV988SPsQdqQ0+s2cfZqy8DBe4aB2q5bJS+yMs=; b=DGP7XF/DA+vAiW5uUaJ6wPt9B931qcaOOGzwGCMT6bq5Z8mwrO+k5Viw+dxsgJU0kJSAkdHYK1KBXVEBLInd1aNJp3IFzaHDTq47+ZuqNIA2xwbE6PiLEokLgPaN8DBkS95XEOnO7dLPqEoe+d9Dw+tQW7JSmBCvLGCmXWxJas+7p5kSv8jh+nwQCeVoXG9AKSg92yZO4luoWQrYNapPJ4XmEJJP9U+VtnWDyCebxOtuDb8Hd3miZwpN4cW2yGFt3Xu42McYToMxjUBdGFXtL0YecGJF50D8niWQBBQbqDRVhoQSXti7DFaAtGB/LRCylDnbv3WBEI8CqZ689IPftQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BvKQEDV988SPsQdqQ0+s2cfZqy8DBe4aB2q5bJS+yMs=; b=hGkh8mrNMLrAUtOoQIIMuC/QS59W8GNo/K1i/cRh4wut/Bzze49GH2M2/TfSeu1+mWfYhPdAFV/07s4l15vvRzuta2h9qwEJn1DnepnxQwA14izfedb4HAj4nNp7Zniy0q4b0qeRr2FytFPMC1bTNC3YReAKlDcm2A+PVuAFdC0= From: Luca Fancellu To: Jan Beulich CC: Stefano Stabellini , Xen-devel , Wei Chen , Rahul Singh , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "george.dunlap@citrix.com" , "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" Subject: Re: Moving Dom0less to common, Was: [PATCH 0/5] Fine granular configuration Thread-Topic: Moving Dom0less to common, Was: [PATCH 0/5] Fine granular configuration Thread-Index: AQHZyc5XC9fV6H5060OwNQm6NeqPxa/iYhuAgADedgCAABq0AA== Date: Thu, 10 Aug 2023 10:43:14 +0000 Message-ID: <18F9E2A1-1CBC-44D5-A321-D6DC72DD55F0@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AS2PR08MB8748:EE_|AM7EUR03FT039:EE_|DB9PR08MB6620:EE_ X-MS-Office365-Filtering-Correlation-Id: 0cbda5b7-d5d5-476f-3610-08db998eb1b2 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mzjltq2gNjfxz/vFdfn7FN1msp5XnrHB8ujU4ZD32tPxkzWi1jgLwl6B3OU+f512OduGLK7+Ta1ZIqFOpKwVWB5QT3v6Hmgr/1KLGsoXjDAfhw+BQm9zkfapWu1MJuA/6iorFnrJZig8prNEExKloeeSpk4x3uSInVdjNeNkAYw8B+d+gOwCkSq3XJX9vVmUSUCT/GihCsE+oBGX1OBJOODYzTvADl4M6tcDXm3XPHri/IMBpgmtDIFwKzJBmnPnBl9rgMvzJrV8gmyW0+Q49ZcN1irAV9XOUY7v8f0SoBZ3wM4hzkgyKxauUoWWO+iawx1pnLf3w9Rc2G40ntk1OoamT7HO8nTFOMiDv/jnpyjcMmektB1S0ywa6r4D+N+BBzcXVsops0P7CSY9CUS4WchP/iVU1YemB2W4hJCDsfB6FgbYvr94IuUx5cG3ImsYmXemeQjSod9GktoXfXZ0xmaBYe0QmIt2IDE2ej+iaq5ELzc7JW69fl7eN67kfjvvbkMj0uQMfwXSbki97YkNMxWMjIts1XQRRQbfBEnK5CWnQ/AdqqA6mI1qoVVcTHktL2UOG5oosCAGYflW5FNOSqAtmGOVde2SRMEC+/sSixnLY4io99lSkSGDTOJ7dnhX33SRJufEXdCmsXmqMpw4DtpNJ1mNNMSKgXgv6LG4LY8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199021)(186006)(1800799006)(53546011)(6506007)(71200400001)(478600001)(122000001)(86362001)(83380400001)(26005)(33656002)(6486002)(36756003)(6512007)(2616005)(4326008)(66446008)(76116006)(91956017)(4744005)(66556008)(6916009)(66946007)(66476007)(64756008)(316002)(2906002)(8936002)(8676002)(41300700001)(38070700005)(7416002)(5660300002)(38100700002)(54906003)(32563001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7CE8C9E4C8CEA049BED0AD9BDFC1AB39@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8748 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f3c5a3d6-7635-48d8-2456-08db998e99f5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h4rrQeC75ERPJDFjgFslMAJsE+sSmfpvQOgYqueyqSmH04HACxU0ZYjMYwl/iLgp0maFrzIfJce5qK4ti17AgDsFOzqkjZyvkVeSJTvpH3GO4GSOBvujgqXq4gkrTYHHJRoSpkFlM1Np8CB1m0+ZUQ2ZmlbJhnVWDxoHpecwR4vrroZB2Q7W9IBRDqdG5Pyv+/jZyRrEQ55bA2QL+S2pjgzIsgIX7bb9Xsun5+ztjrHJX6sUtNrE7MiydyGxOaggGS50VPwOzozosdxXfeV7UviG4btCpfSvkaJnOaziUY4aBBArAeQlp3YlszwtgPgMcS4jTs+/CZMcLQGP8UZkQjtP0Nv7EKVKMQEUKAYNQiQ/ZRKuOzwbz83VXKdxDDHwtOsjm9B+EcDwOmSZzaqwGYIPId0zduh3DuiwvH3m0+dMsnQBZIN1SR+i8xUFLfWjausPpUHOUr6UYIsjuRVAjOT8IZUFf7+GE6oRRbEaHZcTap11b7I0m+74mN2XImrjQOt1OIDdMYItQ0YKui27kh+FcC+bp2cs/Ha5LSp1O3euVsNz3QgvLBPhcEdClPecappsure4om37cB8lFAYtDuP/9tx01Z8Wbpg2cDvfRDkSs0TXcxTmvT6JBDwnJSuqa3O15LZdMq2aYF4Lc+nNhS0IkXv+Eh/944S3Aqtd3jfOjpcl1X6cd2cBv3kap3JiTMxFykpAfqSyl+vcUitXcWYcSY8RjViYSOhAumDOflLSA5kqTmKMO6XsyCVzqL11NnqeX4q/UJHoRMawXj2q8w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(136003)(396003)(346002)(186006)(82310400008)(1800799006)(451199021)(40470700004)(46966006)(36840700001)(83380400001)(478600001)(356005)(82740400003)(36860700001)(81166007)(2616005)(47076005)(336012)(40460700003)(6512007)(6506007)(107886003)(53546011)(26005)(40480700001)(70206006)(70586007)(8676002)(4326008)(4744005)(316002)(2906002)(6486002)(6862004)(36756003)(54906003)(8936002)(33656002)(41300700001)(86362001)(5660300002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 10:43:54.7459 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0cbda5b7-d5d5-476f-3610-08db998eb1b2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6620 > On 10 Aug 2023, at 10:07, Jan Beulich wrote: >=20 > On 09.08.2023 21:51, Stefano Stabellini wrote: >> Would the x86 maintainers be OK with it too? Of course further changes >> will be needed to make it useable on x86, but looking at the series from >> Christopher, the two sets of internal interfaces (dom0less/ARM and >> hyperlaunch/x86) are very much aligned and similar already. >=20 > Moving common code to common/ is surely okay with me. How much wants > moving is (apparently) a different question. Would x86 maintainers (and who is taking care of common/) be ok for the dom= 0less code to be part of common/ but in this first stage be protected by a depend= ency on the Kconfig ARM? In a second stage the hyperlaunch people would do the proper modification t= o use the common boot modules to delete that dependency. Provided that we have an answer for the question Michal raised. Cheers, Luca From xen-devel-bounces@lists.xenproject.org Thu Aug 10 10:56:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 10:56:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582041.911558 (Exim 4.92) (envelope-from ) id 1qU3LQ-0002cd-Tq; Thu, 10 Aug 2023 10:56:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582041.911558; Thu, 10 Aug 2023 10:56:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3LQ-0002cW-Q4; Thu, 10 Aug 2023 10:56:44 +0000 Received: by outflank-mailman (input) for mailman id 582041; Thu, 10 Aug 2023 10:56:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3LP-0002cQ-GN for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 10:56:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3LO-0003uT-KU; Thu, 10 Aug 2023 10:56:42 +0000 Received: from [54.239.6.185] (helo=[192.168.6.56]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qU3LO-00048L-Ai; Thu, 10 Aug 2023 10:56:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=M2ezHDveF6TOlzQjMq0Sq52KQsUckvbSE9oLTbswveU=; b=1M8FQCh0EnvZqtChPt6PCtrLWg 0lyRGJo4YVTJW5Xo6AuCyMaaqwxcsleV3xrU9Na64wq+o4336eTQB2fTcjD6bzJA2Xl1+xYBXiqNb yIdU+6Ix1PYExZu0DyYMPxmTQ4bGffKBxr10Pr1qrNlpIMvg0tpJrO5J8Mqc9uMKft3Q=; Message-ID: Date: Thu, 10 Aug 2023 11:56:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH] xen/arm: traps: remove unused function 'dump_guest_s1_walk' Content-Language: en-GB To: Nicola Vetrini , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <23c5b1a1ffc755b5db17d699a08fc86e1f0cc788.1691659744.git.nicola.vetrini@bugseng.com> From: Julien Grall In-Reply-To: <23c5b1a1ffc755b5db17d699a08fc86e1f0cc788.1691659744.git.nicola.vetrini@bugseng.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/08/2023 10:29, Nicola Vetrini wrote: > The function in question has no callers and its removal has already > been proposed (and acked) as part of this larger series [1]. This is useful information after for the reviewer to know it was already acked, but it is not really past commit. So I would move it after ---. > There have been further bugfixes to that function [2], but they do not add > any caller, hence it can be removed. If you want to mention bugfixes, then it is best to refer to a commit rather than the e-mail thread. > > [1] https://lore.kernel.org/xen-devel/1395766541-23979-27-git-send-email-julien.grall@linaro.org/ > [2] https://lore.kernel.org/xen-devel/20160720161017.4508-1-jtd@galois.com/ > > Signed-off-by: Nicola Vetrini > Suggested-by: Julien Grall Aside the e-mail address, you want to order tag in chronogical order. This was suggested by me then you wrote the patch. So it Suggested-by should be first. Other than that, I would like Bertrand/Stefano to confirm if they are Ok with the removal. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Aug 10 11:08:17 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 11:08:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582048.911570 (Exim 4.92) (envelope-from ) id 1qU3WT-0004GO-UF; Thu, 10 Aug 2023 11:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582048.911570; Thu, 10 Aug 2023 11:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3WT-0004GH-RN; Thu, 10 Aug 2023 11:08:09 +0000 Received: by outflank-mailman (input) for mailman id 582048; Thu, 10 Aug 2023 11:08:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3WT-0004G7-2B; Thu, 10 Aug 2023 11:08:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3WS-0004CY-NR; Thu, 10 Aug 2023 11:08:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3WS-0001yn-1N; Thu, 10 Aug 2023 11:08:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qU3WS-0001rd-0y; Thu, 10 Aug 2023 11:08:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ur2J5jnzBMNBvxtPIO7hXEseXQ6HB5qBlMFJI0fgV78=; b=MZgy08rf4JPyHDfF5AKJFu4nv4 lV7nmt5iNFhfagye0juVOr8pEa+h1IAUIU/V8JDjDO3pzTdKdSu1CVya+njG46n4quktWK2MjoZi6 HlgrNVk24yJ9u3pihYjUSQ/uvXH8A+YHf0DdyfCTgPDx1BmONLAIJyeilqV/4H4Wdqzk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182241: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-examine-uefi:xen-install:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=56d690efd3ca3c68e1d222f259fb3d216206e8e5 X-Osstest-Versions-That: xen=d3be806dae9c122fe94702cd9fa2e358a60828cd From: osstest service owner Date: Thu, 10 Aug 2023 11:08:08 +0000 flight 182241 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182241/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-examine-uefi 6 xen-install fail like 182227 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182227 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182227 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182227 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182227 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182227 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182227 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182227 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182227 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182227 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182227 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182227 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182227 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 56d690efd3ca3c68e1d222f259fb3d216206e8e5 baseline version: xen d3be806dae9c122fe94702cd9fa2e358a60828cd Last test of basis 182227 2023-08-08 07:17:10 Z 2 days Testing same since 182241 2023-08-08 23:10:24 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Federico Serafini Jan Beulich Luca Fancellu Shawn Anastasio jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi fail test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d3be806dae..56d690efd3 56d690efd3ca3c68e1d222f259fb3d216206e8e5 -> master From xen-devel-bounces@lists.xenproject.org Thu Aug 10 11:26:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 11:26:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582071.911643 (Exim 4.92) (envelope-from ) id 1qU3nz-0007Zc-FH; Thu, 10 Aug 2023 11:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582071.911643; Thu, 10 Aug 2023 11:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3nz-0007ZV-Bd; Thu, 10 Aug 2023 11:26:15 +0000 Received: by outflank-mailman (input) for mailman id 582071; Thu, 10 Aug 2023 11:26:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3nx-0007KG-NU for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 11:26:13 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20620.outbound.protection.outlook.com [2a01:111:f400:7eab::620]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4680bb3-3770-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 13:26:11 +0200 (CEST) Received: from MW4PR04CA0054.namprd04.prod.outlook.com (2603:10b6:303:6a::29) by SJ0PR12MB6990.namprd12.prod.outlook.com (2603:10b6:a03:449::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 11:26:04 +0000 Received: from CO1PEPF000042A9.namprd03.prod.outlook.com (2603:10b6:303:6a:cafe::95) by MW4PR04CA0054.outlook.office365.com (2603:10b6:303:6a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 11:26:04 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042A9.mail.protection.outlook.com (10.167.243.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Thu, 10 Aug 2023 11:26:03 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 06:25:54 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 06:25:53 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 06:25:52 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4680bb3-3770-11ee-b283-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3VpmIGfTSy1rvYrj5CLIHSep8xFX9j9y4+ghrmDUI7YeLPLVi+x4JJoXYo6C4errcVakD38S2ATs9t2M2cQJyrOF7b8eElesLfCjTQ4HzBpVRvbiKe8EBgbj71l/gQcj0CtZds21uoJ7Ojj+sM+apjHm6wkdsfjeEVZOzxxZVEy0nygivIeFTgeV8uS967Dh//ts5vM0VtFUUFG1a6El9DDCX6fF/7xICTy8vKObpDXy0A81/jnR35ZWWbbptyerAYwVPUNuPjkWVpu+8T2rxMNK0nLDlNrWF6kLDqvklcxj7/k9faBVCQNcIT31AnyqAtYNpVBsWgM/Q4RJnqQrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cVa18TZKbzHxsYXSBg931qTZMb32QSREUek5+T+Po5E=; b=C+FkhUBvWv4YFswIcwN7sLUPwkfhjIbbApQO1EwBCIVgL7yY290kUPY2hkEkjBWQPovJiDck4oKEa9PydKZCAiiu0FuHvShpOHfKQFB8Lq4o8cugZXTFveZ/lg9J+hHsrcHUyaBE0pWXBkDcY8qHaof5ZPnN0b4MnJgcUHMyRPRP5ipBgEBoUozK6ZohR1Gk6HcqF3zTyQryNkfmnU9yPb4ZrRGgoAFbDbjn5ulm9l3pYLuTZD8uiEWZ3z4ToD8+1ROVsqhpdVuUCgCxqMA50Qy64tnZxIi5Tup3wiRyMj0c8x3TUacm2pK5mqEtjrfYrrNh9p/z4vPfSC39/rVUOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cVa18TZKbzHxsYXSBg931qTZMb32QSREUek5+T+Po5E=; b=Ytva1UujfSmgKij1ACBfgfGWrxyhLsb3EKNA2eghn6TgV1r4QGSFh7qya7i4nReiwio9TqGYEPk6AB57TvnBFwHEBBOmLjxTYI7kMCT58cSUNmP5RvOI6BP4d7MLsfSxtfn/Zqz0xo0oCmIRTRPB5eeXVt+Hfe0tslL/tMqUFGY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/2] xen/arm: fixes around device tree generation Date: Thu, 10 Aug 2023 13:25:42 +0200 Message-ID: <20230810112544.17365-1-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A9:EE_|SJ0PR12MB6990:EE_ X-MS-Office365-Filtering-Correlation-Id: d421d8db-b058-4469-9735-08db999494f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xnx0Gul/z+H7njLBwJ98W3hSOS0+r/cNXGwS0jN4gy7CYywZJvpWsbcSTjgxZpvm3c8Ap6r6c3cUpNigMkDbwzc3HUvkpqYe3ZTLiMv1Ks4fqgIvSYvm1EXadcDP8tX1Oc+mRRXFjhhWYxC47RqcYAeiwVDJ4wUC4d9dCUJiW1hawDFshL0UvtksN64KpjlkGFzes9knu3YSTmoCGlwtpi8I3XlTQelDdmc7wFe1EmI4Z30NqxvibEQsbjHOq5JSqmIZJti/BqwekYNRXERA5qZ7m2uZ/TZCwZ13goRCyQaqfxAV/ojip2m18Ck6v8U5vtwTHn1rTL5ikNkrkVal+rCoXOEbaAXrIwoH3IhBxApfjKFNv4RbOEc7yudL1CS5EdXZqx+a1Guz/D5wUhgKdbR16ZSlTFnEWPw2uWN7Om0QVdwFkwrne/6FYcAQBVbE1rRe+MRc6egDJ2x2MlNVuYh/I/KBv7ulleeCTRTms8r/Aemiqee5goIG/506kcb/enp6bD5WgCVsV++ErN/PJF4uSFib5B3dMIVk/DsorQgTrzIWeEDzr/ePTJv2qUMJwdOWNDSKwEFlA0sZjs6oEvMLvHqaUzgF6aLb4YjZg/9CoDFe2G4aMPRbU0BLo09Fdnhj7mMJeYouXfxhSJMLyh3sO01142eRkYn7/ba1ssRiKV18+c1e+ZFLYQe+djEjI7PBmxDLlzwXPJhUvYyZjlhwcTZ6YeX10baDOaxLrE4r3TX3NdWdhiQg4Uuwz7mzMBCu3vthaEvzct7f5T1ehw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(82310400008)(1800799006)(451199021)(186006)(36840700001)(40470700004)(46966006)(26005)(1076003)(8676002)(8936002)(41300700001)(40460700003)(36860700001)(36756003)(558084003)(47076005)(2906002)(426003)(2616005)(83380400001)(356005)(81166007)(86362001)(82740400003)(336012)(40480700001)(44832011)(70206006)(6916009)(70586007)(4326008)(478600001)(6666004)(5660300002)(54906003)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 11:26:03.5180 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d421d8db-b058-4469-9735-08db999494f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6990 Michal Orzel (2): xen/arm: Fix initrd placeholders generation in make_chosen_node() xen/arm: Skip inclusion of domU nodes into hwdom dt /chosen node xen/arch/arm/domain_build.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 11:26:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 11:26:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582072.911650 (Exim 4.92) (envelope-from ) id 1qU3nz-0007d5-QS; Thu, 10 Aug 2023 11:26:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582072.911650; Thu, 10 Aug 2023 11:26:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3nz-0007cB-JA; Thu, 10 Aug 2023 11:26:15 +0000 Received: by outflank-mailman (input) for mailman id 582072; Thu, 10 Aug 2023 11:26:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3ny-0007LL-Fk for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 11:26:14 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062a.outbound.protection.outlook.com [2a01:111:f400:fe5b::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4b66cda-3770-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 13:26:11 +0200 (CEST) Received: from MW4PR03CA0262.namprd03.prod.outlook.com (2603:10b6:303:b4::27) by CH2PR12MB4136.namprd12.prod.outlook.com (2603:10b6:610:a4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 11:26:06 +0000 Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:303:b4:cafe::85) by MW4PR03CA0262.outlook.office365.com (2603:10b6:303:b4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 11:26:05 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 11:26:04 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 06:26:02 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 06:25:55 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 06:25:54 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4b66cda-3770-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PKp0N4KbQrOEtlgL4PD8o14PHKvZt2JlxB801L+XxBuY8V+ZdHIBdQr5d59CMIpb9AA37NlEOre3hZp5AsVJqWtxFVWECUXwDTTJE9bB3Litylw22DUe4mfdGpBn8nEfbz70n6UFQBemjKes9A2xBjRW5s2jMONlkpibuGvzeqyO6mZ7e0PXPclYCtvv39L701ZbVIiO2Wfa7RtdooTjPn08I4NOm8YrEyvhkd32+Hy8mNgc8B6SdEBvJ8P9KmpKApuAwi2E4JOScl3dEWAyLF124TmdPwbeFcwYoSILk6e2Y/HsxBxYFpYMqD3y9rcE5i7VSvvbJWTn/ThMQRsCWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JuleepvHl9watBMb8Yr2FhoB77ZcoX5n+rVEP21MO5Q=; b=alJ8EOZMSn5PWrV6MrHkRx6IDqSBCx2urwD9tKGpwRTnZOWo67XIjgckIT0k+EeAq+Yge28IWFWwoqEf8nQrBRQhfARF7VkBt9A3HPbHsyYswVXKQ6qO9Rty5E5cYg50M64mn4serMtr5f3aRcE2vpkCbRli2vASP04Q3e1WypEuANNxFqEHh4WttPSoDyDXP6VGKM6regp+EbS4FjP19vnT0rdIm1uQQoWt2BsixPvqWvdQBw9YI11/doBDn8QXni8zKGnWCKJ6M1FE1f8mS6JDJaIcYohdtKJKFoElZuxV8TtRX2bnSqywa8UtiM6arxgXz2iy4lbnXZa56/Q8vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JuleepvHl9watBMb8Yr2FhoB77ZcoX5n+rVEP21MO5Q=; b=w45ye4cRZ0Eyk6FiAx08c0HCOr4d2N5Brn2H9eZFtbYCtAzsU0IFfvgFGHtx8FPl3xJTUk2OJ7O7SHqPM12f2yRbj3e5zESiT6CDJcYrgGTN0RVPdLPU+YWkhei7q/IvxEqXdd65xW+yBNPPjEw1ICTQZglNtluoaL04LqAfxe0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node() Date: Thu, 10 Aug 2023 13:25:43 +0200 Message-ID: <20230810112544.17365-2-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230810112544.17365-1-michal.orzel@amd.com> References: <20230810112544.17365-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|CH2PR12MB4136:EE_ X-MS-Office365-Filtering-Correlation-Id: 957aaee4-7783-4d80-7454-08db999495cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ngULf1tCXWnr0u7vrSTOCAEp5OgiazJK3vCXUqk+qlcdmLI38OWde0DlMtIuuZx3/EUL1DndyQsTHmDroncp4kKUCRrQsBiYfKiS4P8D4ztV3Oj9sdjJCwdsQeto6AA1DXtBA51/Lw4B/UDfjhnRkeScMF6ZhcO2gty/GjjNMmuF97LNWnIOyPfz9KthydvnqrgUJ8xb61zBNKCFHduYIad4gPisYh+1sBdEkW8mukzB7A1PXXa4epfNmXZWKFLCY+4XOeuGs06ZNN4v9CjSIAhrhJDLdQTHwxWkYMGDVoJCuh4iBcgwkXrUHzkc0oI6COoEpFydTu4fyctvygz/KLeLO04ZJ0JQUEalmjElQrxOqF1omNoi5bin5QBJsK71m0NUSwVvtx5dbYPfbpbxWmwo77yTHlj13jyobnkqF7w38nTmrNZ/WQ5P05+zb4/iSbwLZFvaxG9HDV/u35vqw9YbsGQXTrE7fw4pWhNNyWHElxplpYCAlsuUaXxDxSLzX7qIvoWm++uUjr7RLb/282ph1M+eZTZV4wU1xhWEduMtH0PGoY5oc7j3rEEa/Oe1bUjTwujrWiEu2Vh8Um9LTp7X2KnaAdBzeDQTpCqKakH/lx8dWGnMnxeF6Nu2/fMDeK5XuIya08rvHEsY8AcJdy1aI9Lr+pn/LtzBhWQV4MWUD6seKn5VzBalxW6PIPElk2ka/iu0yTARi9NZPgH0OzPnaV8pHjomNUOen/QJNGFLFS1mkQUyTWPgw3OddA9IClJw3EyQXpLf7c0U9NqjHg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(1800799006)(186006)(451199021)(82310400008)(36840700001)(40470700004)(46966006)(40460700003)(40480700001)(70586007)(6916009)(336012)(70206006)(1076003)(26005)(6666004)(478600001)(36756003)(54906003)(83380400001)(47076005)(2616005)(426003)(36860700001)(41300700001)(44832011)(316002)(4326008)(2906002)(86362001)(8936002)(81166007)(8676002)(82740400003)(5660300002)(356005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 11:26:04.9105 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 957aaee4-7783-4d80-7454-08db999495cf X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4136 When booting a dom0less domU without initial ramdisk, it was observed that Xen still creates empty linux,initrd-{start,end} properties under /chosen node. This is because in make_chosen_node(), generation of initrd placeholders (later on filled with the real values) is protected with a check for presence of kernel bootmodule (always present) instead of initrd bootmodule. Fix it along with renaming the variable from "mod" to "initrd" to prevent similar mistakes in the future. Fixes: 48f4bf6bdeb4 ("arm/acpi: Create min DT stub for Dom0") Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 39b4ee03a505..c6881de8bd85 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2256,7 +2256,7 @@ int __init make_chosen_node(const struct kernel_info *kinfo) { int res; const char *bootargs = NULL; - const struct bootmodule *mod = kinfo->kernel_bootmodule; + const struct bootmodule *initrd = kinfo->initrd_bootmodule; void *fdt = kinfo->fdt; dt_dprintk("Create chosen node\n"); @@ -2276,7 +2276,7 @@ int __init make_chosen_node(const struct kernel_info *kinfo) * If the bootloader provides an initrd, we must create a placeholder * for the initrd properties. The values will be replaced later. */ - if ( mod && mod->size ) + if ( initrd && initrd->size ) { u64 a = 0; res = fdt_property(kinfo->fdt, "linux,initrd-start", &a, sizeof(a)); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 11:26:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 11:26:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582070.911632 (Exim 4.92) (envelope-from ) id 1qU3ny-0007KY-3z; Thu, 10 Aug 2023 11:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582070.911632; Thu, 10 Aug 2023 11:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3ny-0007KR-1G; Thu, 10 Aug 2023 11:26:14 +0000 Received: by outflank-mailman (input) for mailman id 582070; Thu, 10 Aug 2023 11:26:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU3nx-0007KG-34 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 11:26:13 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061f.outbound.protection.outlook.com [2a01:111:f400:7e88::61f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b50cd0c8-3770-11ee-b283-6b7b168915f2; Thu, 10 Aug 2023 13:26:11 +0200 (CEST) Received: from CY8PR19CA0046.namprd19.prod.outlook.com (2603:10b6:930:6::10) by PH7PR12MB5877.namprd12.prod.outlook.com (2603:10b6:510:1d5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 11:26:05 +0000 Received: from CY4PEPF0000E9D4.namprd03.prod.outlook.com (2603:10b6:930:6:cafe::29) by CY8PR19CA0046.outlook.office365.com (2603:10b6:930:6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 11:26:04 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D4.mail.protection.outlook.com (10.167.241.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 11:26:04 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 06:26:03 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 06:26:03 -0500 Received: from XIR-MICHALO-L1.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 06:26:02 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b50cd0c8-3770-11ee-b283-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J16ttXIWv6tekdYUf+IHpfMOtHcYf6N4i8Pc/0loM4yV17fYzn2J9Zk+Fd79Q/+FkP+HT4HnkgOqn1pV9lSReRNkFmKHiCL3n9DXSq5BBGM07XxMGwDQbVI1NKa68hLXNpOfbPSToY5OrM8rGoE1wKXGHAQ4gCythwntaXc6kBrAJtkFW3K43s8eaFqvE1Dy6KM+ZrYoj9v6XtSKyNqft6SpwKCYtIXQcJARJ0xW+xDXZYb/KyMFACTAGABCY+qF96bSw2kEjjFaJce+XtGT2Yv4LU1Og6yvRH0+Qzi7CTDX6UlS4Jpy7pl8O8hrw0YRUkDhffXhcGxxZcvrR92U0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tIq6mkZCycPFXQBXidjf4QJt8gnrX6XXIW7vDCATUws=; b=jvG3vT4nAUMCQJMRzhb7UH9xWCbN/GQ11zzG3Ca9Bm9oZlwhZ1zAAXlEApD41qbWSSkxle4s2vJWeyx17683y3S75EBVwXM8YLrlxGHvYNPfRKGyUMyWAjq+W9i9HsLIDcMTuFlFwM22nCX8+MTdTrjB/mm/9wmZVK794F1KuTDMODBYob+TbrVf3E2RZb/mmhL/epraMfScFTvrRD66AlrKB9iG0HVFatNxjKAw7kLsOYLimrYxFFi5WSjxs37/krlq6ZWw9No++F7cpImyQRc6zznrbIRwYvM9tGAyNPBFx3NgnUErqkGFs7wxy0ixX0S5P+RFz1NeJkzbKmMHxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tIq6mkZCycPFXQBXidjf4QJt8gnrX6XXIW7vDCATUws=; b=LHo0Qd84wp28X4W9Qsfr5qVIC8IHf2hhk+7cqCnvAw+AGUKfhzfoWcEdUbqLIpwAqJXPeiF1p682iv59XmxGO1lXxgf3wVXn0d3rQpJQ340YvShoCGr+nYm+CAKGiLCjh0cM0K8FQnBNQcox5BOHRBZqLsR8esrlTp+MUn69ai4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michal Orzel To: CC: Michal Orzel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: Skip inclusion of domU nodes into hwdom dt /chosen node Date: Thu, 10 Aug 2023 13:25:44 +0200 Message-ID: <20230810112544.17365-3-michal.orzel@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230810112544.17365-1-michal.orzel@amd.com> References: <20230810112544.17365-1-michal.orzel@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D4:EE_|PH7PR12MB5877:EE_ X-MS-Office365-Filtering-Correlation-Id: 0210e78c-724e-4be6-b7da-08db9994956a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gMqXbG59qU/5PTE+3hUsiZLNAf17sIcb6tv7bc/9QhEBdxmj1Fqttuumxf2A0hrFKSoRFJyYxMRDpS1mxr3rc2ezNElT46bWLJzaLZNBXGYNtxywqlwsgryxo40gNXy7xWmmotheu0SgeWt9at3Ws+F1WMAPqo3CdYzWl90VC+kbGKk0U7d7wdTijFdLcxNLNP+pXc8F1EjOC4IHdgUMWlJH6Qbvj89QK1wWFZXXsnKtkeVvK7QSkP5c6zmWsQXnA7Mh9GoOas9dF5ZAhNFxgjVSL45jSoILfObKQA0YwZxsz5J61mSCgKZUZ3klS8DkUrl9fxJzgivHEpDSIiJOcLRgPnOFCsGeYDDIhaNGK99C3d4MJVBM8j1GRSsytYBedB4kly5PtAga0es4Ip4MNRPUaAvb2dAGw635h6ULEmpULxOhR3vcJJDUTTCRX3CZEIIT1i8zFaxM3Clv92DngQXlg6XA+gzeW0l1f2VflXe7dEAEIl8l/grJY+EmD48loVy4b3hePvYSbTy4dsu3PGl8QAxHwFRLLJWVVKhpo7lxcVj+fvFkrHpQj/sFSq5wtqyO5zHRtUdJlXgoGI25J8LqTgkRVVQP/KnP4tLhe3gHbSP/zBzMi4DHhapgrvMpjqcd5xpTkCW6xka4XPoj6aQRfR1kEaarSRsL/ANn+OK5Xj7H+eUVqYs2khptJLu7CzQE6JAOtFzlFI57MRJz9pUp12iookGU8wzyTCNs61vIK9I3QYBySGnBmMz4cdRNomsaa8bVY4wk6HdGMneJLw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(376002)(396003)(1800799006)(186006)(451199021)(82310400008)(46966006)(40470700004)(36840700001)(40460700003)(40480700001)(70206006)(6916009)(70586007)(336012)(1076003)(26005)(478600001)(6666004)(54906003)(36756003)(47076005)(426003)(36860700001)(2616005)(41300700001)(44832011)(316002)(4326008)(2906002)(86362001)(356005)(81166007)(8936002)(5660300002)(82740400003)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 11:26:04.2971 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0210e78c-724e-4be6-b7da-08db9994956a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5877 Configuration for dom0less domUs is stored under /chosen/ nodes present in the host device tree provided to Xen. All the properties and sub nodes there are meant only for Xen. However, at the moment we still copy them (except for modules that we skip) into hardware domain /chosen node. Fix it by adding "xen,domain" compatible into the list of nodes to skip in handle_node(). Signed-off-by: Michal Orzel --- xen/arch/arm/domain_build.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c6881de8bd85..54bf5623c889 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2592,6 +2592,7 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, { static const struct dt_device_match skip_matches[] __initconst = { + DT_MATCH_COMPATIBLE("xen,domain"), DT_MATCH_COMPATIBLE("xen,xen"), DT_MATCH_COMPATIBLE("xen,multiboot-module"), DT_MATCH_COMPATIBLE("multiboot,module"), -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 12:58:48 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 12:58:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582090.911663 (Exim 4.92) (envelope-from ) id 1qU5FK-0000za-AZ; Thu, 10 Aug 2023 12:58:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582090.911663; Thu, 10 Aug 2023 12:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU5FK-0000zT-7g; Thu, 10 Aug 2023 12:58:34 +0000 Received: by outflank-mailman (input) for mailman id 582090; Thu, 10 Aug 2023 12:58:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU5FI-0000zN-KD for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 12:58:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061e.outbound.protection.outlook.com [2a01:111:f400:7e1a::61e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a0ba263-377d-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 14:58:29 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6795.eurprd04.prod.outlook.com (2603:10a6:10:fa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 12:58:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 12:58:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a0ba263-377d-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P+etWnIFRtdiz8/7iNY08G3owg7hIF9wtU/awVBz9veq0HlESYp4EfVxHqZm98f75F3QvacnNgIsu1v7lB3/Oz4x88tmjtJN3vfloxl5lVKa1zjggPHoqcaTpR3UUGHJX1xxhUysoPqKJDWOMb5W35DzEeSw5IES3Sa2ndLcwXj8849Cb6UlA0XXG2xu46140wZdkHYFn9G1vOB0/hNHVRF3hhNSdibBq5+qGAScxpaknmLRlqEdb/fJOBGQoqUelcltChhYge+8SCyjUb4xFi0Utxns3/jEA7Q0/UI17HdE8ppiT2yaSf0PbqUFjHSCHXtvsslMSo4m4IfmM0u7WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N/oikjZblIu2K5b55makPuKDvXK8KeamNCJisBLMO0A=; b=N6QNCHxQgnllVQWBAPK/gBG/KJpu7CLUT+1kVQXWEJRGmwR8x8N0o+ieGsnSiD4cdPi9LZ1droec4DYImXBmsR0g5Z1QLnNUiRCF8mYx7pjdu9gNYmidlSKAdUkpaMmrI0aJ8UsvrA5zBg8hVcJDG0K/RPgt4uOuwZyOOZkeg1zWI9UGOvEBgy08M0dCUWGDwVR10+DsxVxV6liN/md5hgOcsW2nHQwp2+4IMIc9J/uu/VSI3HqKSGeTFduiUmXO/E00kJuNMTmfRUCYhl4ahETNNadURsrSKNukzDNqGK7RXXa7fVdvpUgEZWw60bqsdkep+hczrpVUD+aIRb4RcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N/oikjZblIu2K5b55makPuKDvXK8KeamNCJisBLMO0A=; b=FdYHOHf6bZfMU5lMxQpmc7PVR0YNH4Is//doum2fvUwluq2i1rrYkEZ0lunUHFkJI52krPBjQMQiIHTu+rIsYgkkI2L12i4hvMNVa8xNG4csW3HjtnyazQzDnc9Z92LCE55Az+/E2bSSk1GSbN3/xbn3HZKLh5LXXMoMskK9+oRjlBYyys6QhqitfN5g95ecChnSfiwk4q7D5BvSK9R5MDKsDRXfJgPsJgjVbDrxK8k58apO8aMcgiuW2kxcWZ3TPvCpPmdM6sDa1ArCTGff7aiAUhNzE/mxk2hqEOBDn2tkR16RiEuW1WKZvvNyhmE2wZJChPk5W/8zETn0lJxynw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 14:58:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: Moving Dom0less to common, Was: [PATCH 0/5] Fine granular configuration Content-Language: en-US To: Luca Fancellu Cc: Stefano Stabellini , Xen-devel , Wei Chen , Rahul Singh , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "george.dunlap@citrix.com" , "christopher.w.clark@gmail.com" , "dpsmith@apertussolutions.com" , "andrew.cooper3@citrix.com" , "roger.pau@citrix.com" References: <20230808080010.3858575-1-luca.fancellu@arm.com> <18F9E2A1-1CBC-44D5-A321-D6DC72DD55F0@arm.com> From: Jan Beulich In-Reply-To: <18F9E2A1-1CBC-44D5-A321-D6DC72DD55F0@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6795:EE_ X-MS-Office365-Filtering-Correlation-Id: e2718808-cad1-4de1-05a5-08db99a17d5e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iwWpPax6mInXGjmLXDrruDE8JQoy/3zJ5VOLZdUNvHqVcgpkBBXMZ9mRuL3Ok4aQ7wWnGDSwKRt2Z20qJkATd7gZe4vmDKnYPlonUJiaOn4fc3OsDX7/iOdoZ9AfYKGanRqC1NGqAYXjLxqztPrnpILjH9jhsof9ys4fJ67ItKID1OFYD6v0WIMaGLQDA3/vklv+nsiNwCnSpu+ljrkBQW+2jWmPMiOa0yFN21VW4U3Q8w+CvAj1TcBzj5LAV8KjuMm7aJLJRxn3rawjgX0jHPN1G8oDd4L5pIVwEeKm493D+G+J+k6RODC8Jd5PHaK6DtI/+BhfdJN5XN6pX2WPV4683dwPbJI5VZBio1PNxEIQ44b5zccLa1jm6tx98vHml9i1f1NkGHnD3ifDpvSr7nN9mbrdKMJHSJKBYp3AwsRkpVAWEHmflP2T2cnsp/QWjyTklcQJO3X7Xa8U58UVumjUbLaLuNXrrTTWglYuAPsq/GLF3JUCAEVreeZwOdPjg8QJ96rkmxGVhZ7vj30twwO1NXXlG8VXcTNlrxVMD1YJmcQpDDKHvjHsYg2Vo7m4lTms/MalEWcBv4IkYNRjVwkGbeByb9R8llaDTRaDfYV2XbbkWF0KCPsixlpR31qlHXpDSkw6b7cMTBraxljFh1rXsGQ0tYs2ktSxPYF5dlo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(39860400002)(136003)(366004)(396003)(451199021)(186006)(1800799006)(2906002)(38100700002)(54906003)(478600001)(86362001)(2616005)(31696002)(7416002)(5660300002)(6506007)(316002)(36756003)(6512007)(6486002)(8676002)(26005)(8936002)(41300700001)(31686004)(66476007)(66946007)(66556008)(4744005)(4326008)(6916009)(53546011)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmlkcUViQkthVE41c0MvN2V1YzhwZlh0SVZrUSs0R2h6M05FLzJqaFgyaHQ5?= =?utf-8?B?dlRXNk9VRDFYUVlYZm1rZ3VKb1JnSzNlQytxUnlEeFowaXJIMk1tc1YzTmVz?= =?utf-8?B?b1M1Y3drMXZWU2RPV2NuT2ZzeW5tY2FVMndZWE9oN2xuWFZDdzRFVFpTSzZo?= =?utf-8?B?cTcyYmg2SjBxWnhRczdXZTZPaGtVSkFSS0lFWVd3V0pvMUVIUE5iU1dkRk5m?= =?utf-8?B?TTFQM2lESzRUUDE1NW9Sc0JMa291bUNMb05rbGJmOHFydERSY3MrM1Z0b0lE?= =?utf-8?B?dEdhaU56eVVBRWxFZ2pUWjBKZnBwRmxMUk5YbVl6OXh1NSswbkh6L1RGY21x?= =?utf-8?B?WThSQjJYdW5abUZvV1h5a1h4eFpGZ0FQaGxtRXhydVFIVXo4WjdXamxMVktZ?= =?utf-8?B?bTQ3S09vUzhVNm92OE02OUtqKzNBVXF4Z0FyK2dHU2FYWWdPZnlLQW1FdENU?= =?utf-8?B?MmVmL0JhOC90YStlcWh0a1B1Q1A3UzgwUVdDVTVPV054K3FWQm9PS2tpYkx5?= =?utf-8?B?SGY3MXFweldLSDUreXkzR0lETWgydWRmblN3aWhaaDZIUWlXK0RMTEZkZlha?= =?utf-8?B?c2VUU0ptL1p2TWFMT1VxZU9reExMSExFOWJmZHZLdkV6VGdCOXg2bm5lNkVZ?= =?utf-8?B?SlpVUllrRXR1MlVLZjVNdlNXWGlzSUw0L0NGU2ljb2hlYVNwNDJqOHVmMU54?= =?utf-8?B?V0lNRVBQUDI1cmU5ajA2VVlaZUZmeGl6di9yVDlScFJMQXI0VVl2QTZwa0Vm?= =?utf-8?B?QzZGbjdMTmdRMS9jSDBrVmx3VXdNTmg1WlpEUTkzeEZQV0RRa2ZLSThMeFdU?= =?utf-8?B?eUtmcDBaUjJRUTNmelo4Sk9oMldYd0J1ckIzZCt5ejFuMnJqSjBWSk40UjNG?= =?utf-8?B?UmJtUWd0VzZudmY3STA0QjhGeGR4cFhibllYajV4bTFBZEJzQk9MbGpyMWEy?= =?utf-8?B?MWVuZlJURGhFY3NlSEZKTTNkZUd6cnVsUjBGbmZ2L0VET08wbWs1a3ZKNkhF?= =?utf-8?B?UmVMclRqWXZJZHEzTmZJd014TWRxUnloYndLdUhEWVUwdnB5OGl0b25Jc2RM?= =?utf-8?B?VjBuSFpZSHp1YUs4bmt6ekVGd1h6UjRjcUJHWVZscjBZNTZGT0pBY2dZN2lt?= =?utf-8?B?VTFRbkxncTlBNjcrZUZIRDh5bC83MlNFU3I5Z0E2TVBsTW9IdVZVNWxKWmxY?= =?utf-8?B?azNlLzNEMWE5WVR2T1FXM2N1K0JCTUs1S2RsVThvOEc3MFhoR0ZqNjZkM3c2?= =?utf-8?B?Zkc4bVJIWkwzTjB4UXBCTW54bGtacFpZL1JBbkMrK0dNeEtWa2dtS2tTbG4x?= =?utf-8?B?eFlnNFRIRmVsODZ6YjJMWlV6a3JiamxZR3FqYWR3MGtkOTZtZnNhZ0hxUkdh?= =?utf-8?B?Sy9XWnRBUFp0Z1pTZ2ZhZGZQeU54QlFlaFZjdzVHcjB6WGFCMkFvVDB4Wkxl?= =?utf-8?B?UWhxbk9vK0czL1hmWUtBakREUzI3OWVCYjBUYS9nMHN0RTN0Q3V1OHVVaVdV?= =?utf-8?B?Ym5ZMVEwYlNCSkpPNzJZNlYxQUNLc3VIKys2SHlPS0U3ano0OEZDWC9ORnFC?= =?utf-8?B?bU9zM0JlSlVFWVVxSUUzNXNPWlcyT1l0U2FUTXdMWUhJNzBENlRkUVYya1dP?= =?utf-8?B?OFQ2M3NIVUdqUzgrSzNBM2c0SjBYRGRwTkM3aVZLeVdPcGlvNDFtODdKRHVl?= =?utf-8?B?OXZ4aHJFY0JiVmFXWmdZNDZpZXBCdDNFcFdvWU4xVENSeWJEU3JMMGtSZ09W?= =?utf-8?B?Vm5scEx3MDU4NkdDeUVVRStTNVpRWHBHdG0zbjYzT1YzclNTeEJVQS9iZTB0?= =?utf-8?B?c0Q5Yys0MEpYcUIvcTNabDBPOGNDbnRXK2NRaEJHL3I1QU53ZEM4QnhDY1px?= =?utf-8?B?RG1XNGs1cE41M2dSNlZtbCtQb2FKcEdoOWI2aWU2M3hVYWptNzYxV2JnaXJN?= =?utf-8?B?ekx4NEpLdkhmeVZRcXF1NkxlZHczUUl4cTRxWmZxMzUwQVlLV1EybjlPN2hC?= =?utf-8?B?OGNMb01PcEJWSGppRmtwVXVjVys4NFlnNnNPZ3dBZ1IwbTB3d1kvN2djUkov?= =?utf-8?B?RGdyR1pLVEprdk1ic2xqNE5aVEZuVWpjMHZTcXNSSlhLaVZ5cDhtclJaVEJo?= =?utf-8?Q?KRfEbCOZpekjzeUUaFHpDoyW8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2718808-cad1-4de1-05a5-08db99a17d5e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 12:58:27.6130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: akiDAI69M9Oiu4md3BzChhPc5xA5hTxUqIlwWC1el63vu09YrLuL7YB0lMnhmwrHz9xPptx37ECrss6FeiyVwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6795 On 10.08.2023 12:43, Luca Fancellu wrote: >> On 10 Aug 2023, at 10:07, Jan Beulich wrote: >> On 09.08.2023 21:51, Stefano Stabellini wrote: >>> Would the x86 maintainers be OK with it too? Of course further changes >>> will be needed to make it useable on x86, but looking at the series from >>> Christopher, the two sets of internal interfaces (dom0less/ARM and >>> hyperlaunch/x86) are very much aligned and similar already. >> >> Moving common code to common/ is surely okay with me. How much wants >> moving is (apparently) a different question. > > Would x86 maintainers (and who is taking care of common/) be ok for the dom0less > code to be part of common/ but in this first stage be protected by a dependency on the > Kconfig ARM? It's actually more than just being okay with this: I wouldn't be okay with there not being such a guard, as then x86 binaries would carry dead code. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 13:31:45 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 13:31:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582096.911673 (Exim 4.92) (envelope-from ) id 1qU5lH-0005MI-Qa; Thu, 10 Aug 2023 13:31:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582096.911673; Thu, 10 Aug 2023 13:31:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU5lH-0005MB-NZ; Thu, 10 Aug 2023 13:31:35 +0000 Received: by outflank-mailman (input) for mailman id 582096; Thu, 10 Aug 2023 13:31:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU5lF-0005M5-Kz for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 13:31:33 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on20605.outbound.protection.outlook.com [2a01:111:f400:fe16::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 36a9dc1d-3782-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 15:31:30 +0200 (CEST) Received: from AM6P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::29) by DU0PR08MB7639.eurprd08.prod.outlook.com (2603:10a6:10:320::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 13:31:23 +0000 Received: from AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::45) by AM6P191CA0016.outlook.office365.com (2603:10a6:209:8b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 13:31:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT007.mail.protection.outlook.com (100.127.140.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 13:31:22 +0000 Received: ("Tessian outbound 169aaa6bf2b7:v175"); Thu, 10 Aug 2023 13:31:22 +0000 Received: from 2833df892b3b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 46F743B2-AEEC-4948-BD68-020C8B50136C.1; Thu, 10 Aug 2023 13:31:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2833df892b3b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 13:31:11 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM7PR08MB5510.eurprd08.prod.outlook.com (2603:10a6:20b:109::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 13:31:09 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 13:31:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36a9dc1d-3782-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOxKVzseZD3tX21APUomyo7znpD9dTbWKiHyQZa8zOE=; b=LaArES63r1iOE/WY2NJkK4XX7kLWCjEZjuAaymn7/jec1lEBiMCaf/5SwJqorm3j3RKrbLW/KoeNHEcu20XbeURlq81EQ+4wKImZVmgaSWk2JgE1SAcZo1FPRpwLUJS4RvDVk47dnpYpcq/BelOtd0j1ycqLUrylfIJb8cd+NHw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 283012adc2e54b15 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ol0rNu1CRltDLnqFUhTx3PDKYsnRLeuA3UQzTZHu4jzCsF1NdG9jJMFvh3DgycrcqT208kVZFVxvTFDcMzSChIZu/EL7RaFmbSn+sp1AdFjK+8wm2w7N1tGSLb2wpGQ8Ak4j2z3pUJmW/NZq5u/oevmbIB1fXIjLyszzfvbus0b+sKKapAnM641xGhqamnQRre2mE3tTwIX3vpATG7d11wYInBJ2GwHSLO8Dgq5gQyONzz49UmiAfqeAX7fSRL59SbgJXCzi5UFnLXLxxan7IwZyIYBlc0AaqrxyymfM+bHflfvq8P6uNpDSMMx/ZKLCb+Uq2SQY0tbOw7gXg+8WpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JOxKVzseZD3tX21APUomyo7znpD9dTbWKiHyQZa8zOE=; b=TExzh8xf6+GDYRY/ONvXUcIvnnyJ8DPI4ry5OJiWFbbHbikwB1dATlmkYLMUnjEtEGlbEr6X7BRQgITYKhErf9GPwolBqX79OmVtMw1wZ22WUGNK3Ktrp4+iD8tUHCdVFZ29uNX3AE1Ydk2wsve/JqatjaY0HDXMZKCYS4PWzf6VkiZx6etxLM/6vIeC74EXxTgsY/GTic2jiRNLkp0O2KCrETLvKZrVHTYJRp+2aoXG+Caboh8SaucvQleIYRBZnDlD3sBAq3Rg5MQI2mBHKgucmEOOx7FV7gw77CGhf8m3LVSQjyQ6wzS5ze+JhloHJ8JoNsv7mY133sRCd1qqtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JOxKVzseZD3tX21APUomyo7znpD9dTbWKiHyQZa8zOE=; b=LaArES63r1iOE/WY2NJkK4XX7kLWCjEZjuAaymn7/jec1lEBiMCaf/5SwJqorm3j3RKrbLW/KoeNHEcu20XbeURlq81EQ+4wKImZVmgaSWk2JgE1SAcZo1FPRpwLUJS4RvDVk47dnpYpcq/BelOtd0j1ycqLUrylfIJb8cd+NHw= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node() Thread-Topic: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node() Thread-Index: AQHZy32D8bvJWFq2S02jfFulAD0k7K/jhs8A Date: Thu, 10 Aug 2023 13:31:09 +0000 Message-ID: References: <20230810112544.17365-1-michal.orzel@amd.com> <20230810112544.17365-2-michal.orzel@amd.com> In-Reply-To: <20230810112544.17365-2-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM7PR08MB5510:EE_|AM7EUR03FT007:EE_|DU0PR08MB7639:EE_ X-MS-Office365-Filtering-Correlation-Id: b7af7000-120b-43d3-41d0-08db99a6168b x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8Tkh+9EsaVrkaGiHpvbH0wRhXFZLfNrGVJBZTo88IGck78Sq91ozIha3MpRNwXxRhlMkDeXXiEIlgjUgXYq5jxhzGMrekE03SkQ41bPdZDGfwej+2BzTT5evgC7DNSr4umyZ1qikRN9uZhusoVPSakCidLF7G6m7a1TdP0pbbitgw2tXrPhaLUDD34xAaN+YtdDpVFO8GUlVfET2iWMIz/u9QUsN5OuY8PW6kM7vlwOuf8k0Hz1htUn4GGhUB+uDH2bJ01u1hJDVOjYNhPaZWW+V22dTVazmo9/2lKOJvyXcWzYdzwig/D7577sWYsKxNAyknwCo8wRbKPPuuwOLUHO6vb5v4dNRmKd/+ia0eR04tFNV3ZgLrawN9piMCvcPRYCZ1YZZxSaDHLqmFADJ8VnM5KkAO9zU95dgdtjhaH3pWzLSlhb4YCVAy5q48HCAfFCgEV4+2/xoHMfw6tJmQwJXX8M1mqvRUKSRYwWA31PaeGFNADD7qbEJ6u2k025OU9Z4HOgilJdDc2PcYafAlZQDUjf9Jsa3760zCsLMByUPEyw4ICTgSvtcebBlAiVqXXho8fbpBnpW0GTcGPUih7iLyEyyrlOPzKXje6EZ2ffg+7DGKLFXmZUWVfztLMs3owWECah9WCAnnPhxDHkyuQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(376002)(136003)(396003)(1800799006)(186006)(451199021)(33656002)(36756003)(71200400001)(478600001)(91956017)(54906003)(76116006)(66946007)(6916009)(66476007)(26005)(66446008)(64756008)(6506007)(66556008)(53546011)(6486002)(4326008)(4744005)(6512007)(2906002)(41300700001)(316002)(5660300002)(122000001)(38070700005)(8936002)(8676002)(86362001)(38100700002)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5510 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b22d5100-1886-4f06-42b6-08db99a60e8a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pqIDaWPdr4N1hsutO2RurTwEztxlrgjwlON3DO8wykEigWo6ATO0jciSP+ap3255kvrKWFjTWx1GzHu6Yw8P/fNPQDahcGulg/wPPPH8jOnukSjjZ/sZgzPTKbRL0DomnC7jCtpx9b7WBT1JptgmmfwHlUqbU5ygGSRZsv3gTywAdp+le0Oh7kHILM6l2NNUpJm0JozzkrByARbXt58TAhgL6N3UbXgCh19h5ZKiRybgNiWsoMWBJckkBRaCnc2LWTaAuZO8NZTFmRBsDc/lM6JeHlRRpEnkNEmRcS+omF0t7IbOXYoCZMwhUGFzQrQ/pHb+CjvliFwEhd09bE87R2NCbuKAYCdk1HUO1DIOr5dDp8BVdrZhEWb7S55mg6WsLu0Si+/KpZD/csZ+HNaLB9eBPZaiQq/w9o7e8A6OTk4eqdfnDPO9izu6R6dx1VUAtu7QlRW56noEfMh5/lAjXlIf8Nq/lY7IgwHASSsLA+JRQc9kaq2nXEcRJmMlIb3lWOxY/Gu5FL1wwvaoCOdiaeai0CMtLnMUGjIEd7ZuUmxHEYRGmyJRCOTWM2jCHIGZPLWAy0JdoDU/Jy2Upma57FXXiZO/Ez8ism6bNHbznfEgTA5GvfWy9ZIDgR2oBtISoH4JYcmvqCjqZyHQWIASwbNg8bwF16KS+LuO21C7iCZeL1pXnzBFujWm7+FNZOzdurxY1q2018VLC1vctjrQefHP6PEl/kzQZMk9KJWBnro6G/KgBwDT2LpryIK3m8qi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(376002)(346002)(39860400002)(82310400008)(1800799006)(186006)(451199021)(36840700001)(46966006)(40470700004)(4744005)(107886003)(33656002)(82740400003)(356005)(6512007)(81166007)(2906002)(6486002)(478600001)(2616005)(336012)(36756003)(5660300002)(8676002)(8936002)(6862004)(54906003)(26005)(47076005)(40460700003)(40480700001)(53546011)(41300700001)(6506007)(70206006)(70586007)(86362001)(4326008)(36860700001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 13:31:22.4434 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7af7000-120b-43d3-41d0-08db99a6168b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7639 > On 10 Aug 2023, at 12:25, Michal Orzel wrote: >=20 > When booting a dom0less domU without initial ramdisk, it was observed > that Xen still creates empty linux,initrd-{start,end} properties under > /chosen node. This is because in make_chosen_node(), generation of initrd > placeholders (later on filled with the real values) is protected with > a check for presence of kernel bootmodule (always present) instead of > initrd bootmodule. Fix it along with renaming the variable from "mod" to > "initrd" to prevent similar mistakes in the future. >=20 > Fixes: 48f4bf6bdeb4 ("arm/acpi: Create min DT stub for Dom0") > Signed-off-by: Michal Orzel Hi Michal, good catch! Reviewed-by: Luca Fancellu Cheers, Luca From xen-devel-bounces@lists.xenproject.org Thu Aug 10 13:34:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 13:34:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582101.911683 (Exim 4.92) (envelope-from ) id 1qU5oA-0005vn-8q; Thu, 10 Aug 2023 13:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582101.911683; Thu, 10 Aug 2023 13:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU5oA-0005vg-5J; Thu, 10 Aug 2023 13:34:34 +0000 Received: by outflank-mailman (input) for mailman id 582101; Thu, 10 Aug 2023 13:34:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU5o9-0005va-Ew for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 13:34:33 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20610.outbound.protection.outlook.com [2a01:111:f400:7eaf::610]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a367724d-3782-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 15:34:32 +0200 (CEST) Received: from AS8PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:20b:313::9) by DB9PR08MB7748.eurprd08.prod.outlook.com (2603:10a6:10:397::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 13:34:26 +0000 Received: from AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::95) by AS8PR04CA0064.outlook.office365.com (2603:10a6:20b:313::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 13:34:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT058.mail.protection.outlook.com (100.127.140.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Thu, 10 Aug 2023 13:34:25 +0000 Received: ("Tessian outbound c99fbc01d472:v175"); Thu, 10 Aug 2023 13:34:25 +0000 Received: from ef9790401739.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0BE6CAE2-DFC0-4773-BB13-DC66ACEBF4FD.1; Thu, 10 Aug 2023 13:34:18 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ef9790401739.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Aug 2023 13:34:18 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by AM7PR08MB5510.eurprd08.prod.outlook.com (2603:10a6:20b:109::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 13:34:16 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 13:34:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a367724d-3782-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzWXUAgdO7tbgtV/Z6I+0otW08vyX7V7DfacQSegU+w=; b=QqmIWMccn4UjWZwY+PKbZD3MryqGIYWMlwmdt0g1rDEjRxBzNe/t7EvJ9jUOVf3KhqmEZ1T7qxyEyYVsM1zzqx58XeVe0/+1OvtgkvbbsuI+2erQm5JOYd5nhSa85pa8a69jpulLLt+dPXVm92daSfiAU2wnSYC3ayjphp5vXe4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f51938f3e7633da3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NlT3eMvjNdoSbsdNWViOf9+rOSVD8DKsLAL4S4ya02h3xpZrleLJY5/Yb1CgD8ezyMymlzBVbwp1mrrsboHONbRIrf3m6mjdmkxTG66JEAiZ/aHoc0rNLf+SQzwQs57AWtow5nU8OkkO4+ihm51u+f624rD27mTuPuEYByf1zAmU6HB1w85SbvoB4c4ecWLpxeHltREeBGxNoSpHTeMEe3bsO5ffWqCZmA1KJa2rDQcmPYN+vB15nNqc3ymonBReFJWa7fKQyxASA7Z1vmyQN7OMJ7acQ7pth3KCr+sSdJ2jBcT2dHxNlFCgy3W8zf6jx8CURvt4jYBf0bwDrqJf8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LzWXUAgdO7tbgtV/Z6I+0otW08vyX7V7DfacQSegU+w=; b=nzEiZyAVqXU5TLijc8nbtQwmJufTBT1YCF8eA090NhipNzTse5U4wMRw7cik68GXqnJ8is2S1bFTseEmSn6RJS98NVQyHtmPni6Q3J9cgLiUQEg+uBHSIevwm71+FhRU2heF7SSxrMCrPbqtTYsUtn2ZBNZEtULMTVToMhPcbKo7YatT5mSnKYjLPzA6cVEKIZYgBnyk8grtHnz3fdhcmoWZHTN6Agg2595BX0pi+sT392mgmb1YL3tzr+ybfHWNzHltzrkNY6rwT8HzKn07Xafnpa0TR3+5a62EVlzdOiBOE6VV7if30M9kZq30LvdREBtwsqcQteSwIyipMQMn4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzWXUAgdO7tbgtV/Z6I+0otW08vyX7V7DfacQSegU+w=; b=QqmIWMccn4UjWZwY+PKbZD3MryqGIYWMlwmdt0g1rDEjRxBzNe/t7EvJ9jUOVf3KhqmEZ1T7qxyEyYVsM1zzqx58XeVe0/+1OvtgkvbbsuI+2erQm5JOYd5nhSa85pa8a69jpulLLt+dPXVm92daSfiAU2wnSYC3ayjphp5vXe4= From: Luca Fancellu To: Michal Orzel CC: Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: Skip inclusion of domU nodes into hwdom dt /chosen node Thread-Topic: [PATCH 2/2] xen/arm: Skip inclusion of domU nodes into hwdom dt /chosen node Thread-Index: AQHZy32N62CgBrAksUCXC1bl6i56jK/jh68A Date: Thu, 10 Aug 2023 13:34:16 +0000 Message-ID: References: <20230810112544.17365-1-michal.orzel@amd.com> <20230810112544.17365-3-michal.orzel@amd.com> In-Reply-To: <20230810112544.17365-3-michal.orzel@amd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|AM7PR08MB5510:EE_|AM7EUR03FT058:EE_|DB9PR08MB7748:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bcb0e1d-0f1a-46af-0a7d-08db99a68397 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cw7NIjP42+xiBZPKT8BY0c1/+BOxFE8xQvwVzb7TavwZGzzKgBpw45reX+nqqTel03v1wnFR7GqUmuEUCidaSL4ygEkiCPmt96SrZuQm0fpOzzIuyGM7gqqZuW4jjqObT2ot9Q3fTN5FSEGjlUhPUqDEdsYvAOhZ24I8NDcrJgjiho6Hgh7XDgFlr4F3mhwBep/2WDZDifAqNE0ztwGcMW5jZ8i2WTMjv5nR2JKlJOnoGv1+bxdPK8HyoxZ8LCqZwdolUCAGs4ac+kT7wNDJhQ9Zw9pxGiITCXXS0/iqoIf7jra+rfZXF0/jt+2VSKHLshRzUZ2P0Mm2uHUObwLHnBDI0O94bgNyRlpZwblKk6GvVQbbDO1KYouopCFcqPd1s+xLFW9aVs1G5/rnuPFRQ4KfGYgiTnnXzWQbyTC/tS7BG5ZvUrX7mvks+ON+wVBu0eLl0HCerSpc8Nc2Uxec7K4ZCk8yWd2ge0n86U6ZZbH2lU2XuRsmkWTF6+dCC0CYZkg5H9iVxsxRL2xfYgRjfa71QPDpeHF3/jLCjGInrhZ0lUEqXIPPW4OrhuSYDpRh5GefFNkTTBHIVnJBoc5DHQmsPkYbPrm07/KvW9HxEOsPeqLY4BuBTDJXYF2x4c2iVRH4XDjgZF5K+XsVAXygeA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(366004)(376002)(136003)(396003)(1800799006)(186006)(451199021)(33656002)(36756003)(71200400001)(478600001)(91956017)(54906003)(76116006)(66946007)(6916009)(66476007)(26005)(66446008)(64756008)(6506007)(66556008)(53546011)(6486002)(4326008)(4744005)(6512007)(2906002)(41300700001)(316002)(5660300002)(122000001)(38070700005)(8936002)(8676002)(86362001)(38100700002)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <5FF0E397A2207840B7E5A58C8B708D9E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5510 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 98fc1e28-e9b6-4f2e-37d5-08db99a67e4f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 64QfW413/hS1x4wZ1sMU4pUktlWtd2REcq08IEfjCe9Prg2DS9mkaQzZr7EZu8cdA5h0ysq4M+N9igR/MAXkq9ppY8QDnvgccKkm9hSoekR7AceC0Gy64WXA2DstWEZLcwG6/yQWyVN5fck0P9fFRFcTv1tsB9fLmMRUwszydE9t9VUtUAFdGXeW4e1r7P997TTyIpfsPBrEuT/NR7ArteCyuQciIfaUIiM8Tc9jewtxS3X7WITiiKv10yhoi3eFNarlmxDXZDt0f0RlgH7PNAdQO++EHTW1IYJ/yam9fkNgWNqsEC87gJ0vs8S73BgTI7+zW9UtzZZltndkY3meZJgLpMUF4bIGvjNKIrgVUeblx2oVbbF3zbVUDqqSlbw/m4snxXVz4cHSQ7Vw1fX/0xLrhFPPYjSEWJRHQQ2dB05A6fKBRDTiPefAW0i8w5agVThIf0xZ5fOLHFMYs+dP5hNGnN2hGoRbtC1y9wcUz4UftyHVuyGe56a1udnHDOHwnZBTGbMoziYFdNCuwK11zCXQ94phl/qcgiHaw62trXjjljM8Yco6kgXCMRCs0JpxZZ8tTdLOxPHxAkp0GG9r36zIBlmqzHgLUhPBL6ZutkzX1If8g7RSqlCkRc7SmgYZxudl/SP1qVbWVcn5a3GeWGwm98ywPQ+5vtcwi+jsUSOYhueegUObGHCJf8vRigw/EM8fgAKZncHSrHGL4K9jsOJ3V13Stoc1erFfqRszBKy0fQ2Wple/CX4oCHN6ucK3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(346002)(396003)(136003)(82310400008)(1800799006)(451199021)(186006)(46966006)(36840700001)(40470700004)(41300700001)(5660300002)(82740400003)(6862004)(70586007)(8676002)(70206006)(316002)(4326008)(81166007)(356005)(8936002)(36860700001)(54906003)(40460700003)(4744005)(47076005)(478600001)(86362001)(6486002)(40480700001)(2616005)(2906002)(26005)(107886003)(6512007)(336012)(53546011)(36756003)(33656002)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 13:34:25.3766 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bcb0e1d-0f1a-46af-0a7d-08db99a68397 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7748 > On 10 Aug 2023, at 12:25, Michal Orzel wrote: >=20 > Configuration for dom0less domUs is stored under /chosen/ nodes > present in the host device tree provided to Xen. All the properties and > sub nodes there are meant only for Xen. However, at the moment we still > copy them (except for modules that we skip) into hardware domain /chosen > node. Fix it by adding "xen,domain" compatible into the list of nodes to > skip in handle_node(). >=20 > Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Thu Aug 10 15:00:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 15:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582109.911694 (Exim 4.92) (envelope-from ) id 1qU78W-0006Bj-5v; Thu, 10 Aug 2023 14:59:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582109.911694; Thu, 10 Aug 2023 14:59:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU78W-0006Bc-0k; Thu, 10 Aug 2023 14:59:40 +0000 Received: by outflank-mailman (input) for mailman id 582109; Thu, 10 Aug 2023 14:59:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU78V-0006BW-5s for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 14:59:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85480f6c-378e-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 16:59:35 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB7345.eurprd04.prod.outlook.com (2603:10a6:20b:1c5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Thu, 10 Aug 2023 14:59:06 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 14:59:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85480f6c-378e-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMiA8hn2N1gF4hQnf8EoQYqomciQf7SEwDwC0/mS7Ht7SHufH3ZE32tgMgXJMzE7yfskRv3VVjZ4qwJMphnAKsWTvLmezqywM/lGLSA+z6iIUiNZR1G3T0JNHJxgX2IeBAQQX+cNurN5kZBHetfYldrmb/VfsZ5OC3SWOxQw46Og1aOIrZHeH9sd2yGaTOKhmV0fZt+O9uqpUEJAf5YO1jB3Vu2cUYflDrmfxAMtgZUSObL5f2IsDOxCrIPbeGh4KlQ6FUC4YV8MQo66hZORwABbohjlGp4xnd+tH0JnfOdvUdT2HdvkypNro0aob8XVhp/8NhPaBEp4UzDgdqrCdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+rYYKw0tV9x7V2m5N+9V7884IoTi9TEJZdeF+fwU9UE=; b=fLt+kA/HKLYGnp7prdqwPmpdISmFoPM7uurP+ocxBGGUpB4oH9MVeCII3FhSaHP2Gt6X2+Owds82wIj9l4hNaK/AvWF2teXySxOEl2S1PNsSM8Vnm3phFBjZcauX7lzGg9sdBN/MIFc9/OdEEKjjmvP2UBuFyti7E5q2zdyZu10WtmFI+Bv4lMfCjAr142ZsMgFk94fNrnKujYayN+EalKbPIcAqiDndu1exwWwgQRDd35Xhx7ZJA6/Zsf7E/ZKhzVkY/ORPNVqV6tgVK5kUCj88Bi0yqn/HNBmzavd9vnfDAz7G6tYjV1j/HVtDOsIYBMCK5yjNMnZugDxx/fmkmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+rYYKw0tV9x7V2m5N+9V7884IoTi9TEJZdeF+fwU9UE=; b=Y321hFQdcEsxCYqsELDJM2zptoAl49jhHSq5eu+3c+jDid1RHlgT+nguOkdQQk67m/fiL89SJg37qlPQDrscdiXY1X4fkRwqKHjsM+LwUP9tQDlrgmTDKLexNtj9vZerG6gHaTBKouGIqjysAhCDtkv6fZKgqs7fEDuCBxbNhIU0N+AEAq6c77D6tdiITDVXlanlC4JDQw1APiEaRn2UA6HJ/Xq4TJh52b/9Vk19aMVqqshiNqRpZFg0pXwBgQnwOgDI1oRMQuIOqV7nCFU3i/4g/WgmU3GBwuBbs1Nr7hUKvo/y45m0tReEBj/npbn75zs1LswzeB8Mhz5iaegWAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 16:59:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: adjust comparison for earlier signedness change Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::23) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB7345:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f635905-d1ce-43f8-e4ab-08db99b25810 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p4IxJVVA6eiarLIxGXs1pXcleKg73lzsxcIvrL78LQy8tqSU5YTaV9MCn3Y2gLJlJm2Bm/6a8j2CbPcChhMAk+6ZDTNLANyMEToC/+3Ql5ncLBJo2oulY6zKnHKxOMIqu9tVGqPgzEitSdgLL4ZAsgHe9fwqYdjc2ShCsepRU5XNiJH1CZhtRMK2onYjOIHYNDqHnAe9KREVo1UjOhAxJixm/4xYRX788Jh7JAj92UfCcFLPXIYmbYjomnlJyzbOmSOwQKIFVT7zgxopt/bbk+BNkw2kp2N4m9QA7dBXT0r5V/R4UyFFzW717HXsS81Eur6KfE5paP6J+/Xm6cO89G+QWLbzEyudt4wDCIWxiOHMdq461li/tkmM41LxuLIABSp9d3EzdfhZI6t1G0TYAwSV5lWKL5zqMITmjg6z/FUCulqBaDwqnzeeujakIebQ9tP2qecWlHT0RSug7DDIDdZVMpPe67z9CUu6ZdQzIpKOYSJa9Gt5dy9n2GbGyaHunD/399qT7Ojs6nvzS3vBLh18q2kEkzWkV4+Erkf2UgA/nYKgAQBC9yIKwJS93jfVzIXa9qovV8oH4IkmC/yGfWIgvr7RaaVrpXSU0os2DFzfZa2ABYXJLrskxSxzXY61FuoQ6Gzxd+Mnhn2fm2Xu6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(396003)(136003)(346002)(376002)(451199021)(186006)(1800799006)(478600001)(31686004)(6486002)(2616005)(66946007)(6512007)(4744005)(6506007)(26005)(8936002)(316002)(41300700001)(66476007)(6916009)(31696002)(2906002)(4326008)(8676002)(36756003)(38100700002)(54906003)(66556008)(86362001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXlFVytQQ1FaeVRPNERoZHpHVHpwMCtucndoU3k3TkRiSFRXczVQNHZvYzRh?= =?utf-8?B?OTNzWlg3bDBGeDkyNHR2Qk03UFJmT2VNQ0VjSFlMRVEyQXZqNTBMcU03MFNP?= =?utf-8?B?TUdlTEE4UUJBYjdWRStLRlNlNUNOQWtsVVdrejd0bXlOUi8vNHNocHB5WnFJ?= =?utf-8?B?V1g0WnRxMzNSOTNXSDd1QlM1Ni9OUTdiUTVXMDVpZGUzWFQ4QTNuMkdEQldr?= =?utf-8?B?ditKWUpwTTFtR2Q2MjFVWWFXdmtRTXJIVGZRblIrNFZlRGpQUGU3VVVkREdY?= =?utf-8?B?MmhQSjV6emhnWDkzMnRDNzgwSmhsc2g0OFErTTl5UUphSjUvV3h5MDE0WVBW?= =?utf-8?B?ZHEvOGpSUXRVRzFCb1FKNnpoMEF3amkvN0FqVjJRdzl1THRKcHlsQUFlS2ds?= =?utf-8?B?RFhtemV1VlZkL2RtTTk5NkJqQnFoK05sanFYSDMvK0FWaThEdnJmRSt6RkJP?= =?utf-8?B?OTV1ekNjdXp4UEV3K2oxV1F3TGllRnRLZHlPczVMV3NtbFAxNlEwaUJoQkdS?= =?utf-8?B?aWlFV1QzYm9scXhJWHpzVHArMCtVVXVacCtwR3NRY1BPREpJODFvTzhHQXh4?= =?utf-8?B?NGZFajM3UHZScWNqcjhRV1RLRys5U003Z0lBcVlzemRxbGFha0dBMmFLMmM0?= =?utf-8?B?KzZPd1E3MWhkNlF1cXlIOXpWb2RUMVpVTDZPZ2ZUcCtIN003THVDSTI0OUZZ?= =?utf-8?B?WDVPUHQvNS92QjhiUWc0VS8vbFZhcWs3YVNGRzBxTDFLNTJ3dUM1ZWlUclBj?= =?utf-8?B?S0J5NlVLbVR3d3hCQjNFMGFxY2hUTVYxWDFYV3FZNVVPSm9OSStMbXpHTW1o?= =?utf-8?B?VDlPdGJDaFhvU3RHY3RLNzBiOXFDcU5Da0JicWFwV0RxakRtMzdPc21RUEhz?= =?utf-8?B?c2lQMzBtaWMzRWo3N0tKaDZXMWp0bEZ4bGJMR0IwWUNXRUliUEtoU1ZiZDgr?= =?utf-8?B?d3VYbXpIRlA2YjBMQ0JPeHNqSHZqN1lVb3Ewd25YWHphKy92b3h0UUdGQlgz?= =?utf-8?B?cEs5ZU5UWDZpWVQ2bXVkU0RpSU5wb2ExaVhWY1lzVkE2NmYwTWlZRmcwVFJu?= =?utf-8?B?Z2YwODl1WHUwWlAyMEVENUZWTEU4Z0I3Ui9Qc2JvWXpCOVdCOGplb0YzNEx2?= =?utf-8?B?UUJXWUoyYzVkUTZCWWMvL2htVWIxeU1iN3dkSGFCYUlzUGpPR3dyNlVlTk96?= =?utf-8?B?d2R3OEg3a1c0SEVyRGNTYWVQcmRGNEpkL1RQSFd1UVJuUGtuelhkTy9yQ2FP?= =?utf-8?B?VkNnak1BbHZzQVlZUDJBeCt2cDlLdkQyMFRJZFVnTnNBT21SOVBkWGhwcDNz?= =?utf-8?B?V2xKQnFpQUdsc1pRRVQrUVc2dHU5YnVHUlBtaVJTUmgvUWRIZ2pLRDh2Nncr?= =?utf-8?B?dXpjQVhpY3lBWW1aWHVPMFVabmQwQ2pqcjJwY2NWdmJWWUYzZVJ1TVhULzAv?= =?utf-8?B?cHpWeCtEY3Flc1krTS9ZU01rYlFmblM1TS82WW0xUHVtRFJzUDhyZ3ZCNGlS?= =?utf-8?B?MTBITjlUYUkxTjU4bE9BRk5VR2dxeUk4SWtweU51ZUFtV21aVWYrK2V0ZWlS?= =?utf-8?B?TVRmT1RMRmpNdm52eHNOb2RjNEtXcmcwSmtlSFZMOWdhQUpTZzhZTzY0R1li?= =?utf-8?B?L1Q3Z0tRaGFQM1l0cWlvUFgwWmJjTW1YOVFEVmdmUkZRbkk3Sk1mYnJzeFBB?= =?utf-8?B?eWExWkhUeFVJT1JRbzhaZnZvZDVWUHNTWXpFNEgySlhlWmxteWtmVEZlRGY5?= =?utf-8?B?aFQraTgvZysvampBY256Y3RBbmM0T2dWOW5yMjlrTmtWb0VBdS8wVEJwbDds?= =?utf-8?B?WlhnZytWSnp2Y2J6bUpzb3N1MVdOem1Xdk1NTWdJcjZJYjdaZDc1aGFrYlBQ?= =?utf-8?B?K2poc1NRSy9Oc1JPNGMzV2dVUVFMQmlQdE82NzNXdE5ra1RQT1BMeWQrTVNx?= =?utf-8?B?Z0tIdFQ3bXBmMmdSQnNKam0yRWs2U0xJTVdhOUl4SlI2VmNvM2YrcE56TFN1?= =?utf-8?B?ZzJIZ3lhd29pZ25RYlkxODlENE5SaWhIeTlnQ0wrWktncGFGcGV3YnZMbXMw?= =?utf-8?B?bWNmVi9CUk5DMFFaZ0Fxa0dMdW9QU2VhdXZ6SU9MT0YrajVBRUV0Y0hYU21C?= =?utf-8?Q?+Rv7exulmtdesTGlk1vpFdveB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f635905-d1ce-43f8-e4ab-08db99b25810 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 14:59:06.6133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ljHh2pUN2zGJnNIh1tRdXIhpWnXjg43RmnmzsnBmHEPfztKd+Gf+4ftitmXBJ/f6OXItZISSOqtWAi2AOrM2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7345 Interestingly only Clang warns about the now bogus less-than-zero comparison. Convert it to something that's more explicitly doing what the comment says. Fixes: 4086857cc159 ("x86: implement cpuid() in terms of cpuid_count()") Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/intel_cacheinfo.c +++ b/xen/arch/x86/cpu/intel_cacheinfo.c @@ -187,7 +187,8 @@ void init_intel_cacheinfo(struct cpuinfo /* If bit 31 is set, this is an unknown format */ for ( j = 0 ; j < 3 ; j++ ) { - if ( regs[j] < 0 ) regs[j] = 0; + if ( regs[j] >> 31 ) + regs[j] = 0; } /* Byte 0 is level count, not a descriptor */ From xen-devel-bounces@lists.xenproject.org Thu Aug 10 15:22:52 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 15:22:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582115.911703 (Exim 4.92) (envelope-from ) id 1qU7Us-00017m-Vf; Thu, 10 Aug 2023 15:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582115.911703; Thu, 10 Aug 2023 15:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7Us-00017f-SF; Thu, 10 Aug 2023 15:22:46 +0000 Received: by outflank-mailman (input) for mailman id 582115; Thu, 10 Aug 2023 15:22:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7Us-00017Z-1J for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 15:22:46 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062a.outbound.protection.outlook.com [2a01:111:f400:7e1a::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c0a495e4-3791-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 17:22:44 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by GVXPR04MB9951.eurprd04.prod.outlook.com (2603:10a6:150:118::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 15:22:40 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 15:22:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0a495e4-3791-11ee-b284-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kyeEuT31jGRyVdkO3PyM2bOhSJPGZM2+UHF3Xao9ph176PQHZ+9Bmf5ETCae5dKQz+/6QDoALS+Lsb5yz06gnIP7aS8U3DfV3ADHlXUonD8nLYXAUcNNGqtQDGPAMaEmKcTjMHm6r2HpylEAYg3OReBkIdQAo9/x4OCVaWmFwAHjOA1SAKD5XN/NYXguTYdFBeY71oPmppmtYWHBcfw2ylp+UamDpdTnWOKXj+3Wr9IEG8eqTrmQjHhSU8wWsrd18ZE0lrI8xO7w1BIVKUmjQP7J6b8eRKzqHYWi25lXULg3j4pgt7UPutiMhlG0FU5PiHPvh8yYpe6rdVNWnnvhVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9yXHXhGgAaZBvGO/HRjNHzgKfun6sR+8AGqHAx4aN+w=; b=gH7WVrFcXRVPCIS0jTLd1EW4jCWsfxghw/TBT/q8DEvUgSVbyHHS9WKiwR+/1IATyHeyd2jLHXUBFeEAfjK7o84uv4G4+gwacRzx8aii1fMzNxeMk8fvrrTDW8oqLVbUMdRLXK05VjaZ5hmVqIOgcZjNKXr0nra2Apxwj5HlTq+GUSKFN1e5ZKz8bVY8XRmpKTPhrjIpnp9HVovLLi6X0/WcFrBEEsP0wA2Mqd+g6decVKUApneP5lYR2w24t8HrQLuNNNPDZwitgAZlspYLr5KivVG36jnFA7Zx9GWEkTR7xDZVO4mln7qtZgQ+jb6XYAjvJzLZIRiRtWM3zeWMPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9yXHXhGgAaZBvGO/HRjNHzgKfun6sR+8AGqHAx4aN+w=; b=q9MYga5Svovm/LzMEtJiB6IZNilME6MTqq5/BSLaj1+9mNeauB03002YYPbH755jYoe/squoIYTFGG9GSsiTdZumDUxF0gBXT8EQq/bNqHT0pgDA81Hs27oMjb4GlCmJ2+Yu/t0Km1++9NSmGhAHfCc/smcaVAO40fKS05g4etrcygRKvf8EKkLhd0oNr0vqB7/UjJScnDIKTXvEb5+XWRb6xg4sOomah8tVy8mIRG9PGQauz8wHSzh9ARE+/kHXN2tHobpZZxXIgeKWyg7QasFQG8eY63DFsFhyqIRvUG5oVqUeQADax8V+r1jfFOQ688MkCUunQ+RO3ENbcwKBmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3f700da2-e5a0-2a58-e147-6d4ad3ab544e@suse.com> Date: Thu, 10 Aug 2023 17:22:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/cpuid: enumerate and expose PREFETCHIT{0,1} Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b3::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|GVXPR04MB9951:EE_ X-MS-Office365-Filtering-Correlation-Id: 6425e173-c97a-46ae-8374-08db99b5a295 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s6PHsXJ7VST1HS9Zv/ay0TOQm/7X7DX5DIJC4iZ1y0n2+nQ0nZdQEw5HkVL4dGzIoD5YUE3gaCvfBqc7QOxsPZXq6r7X/sVYAgFCkFa3p78GD5rUzpLqL4mZ2V6oRFA/xkuj2v8dDJz5kLRPyISf9OI0ONX2SoWZM2JxDgDNJwHS6BZBh9EEH8zmk0L6rWJNXkyAwMoOflOJwdv0feZGeiSZgEZxANBUnsZMhqXmSesdb78/rMo8HceegwTOzwN8CFAe+cW04wk/J01UVj1ppXDcGFGP1sbYbGRIDM08C5Ad5FnSezgIa2gWhMZ1UjGsynBaVWmz3TUSTe/NOsdZvdAvj5ty2ixHjxGHW+wWO5Zbc1p2vEwyo+ACVmUWEQDBMnesvJtVKw9kz0Xt48xaPU+pNW4q4Qf36ftNurQqupQY6NLgYs0Df7asQSGPV5TmSytTWH0d3N410aT8cyEXW7nRcgO8ZOJIE2u/BULP3WHY97cjNX/4NRBzF3o0ul355HAj6JJJ6UnpqauF2zvvVxX9efgcml51VoNd7Ov7TTIsX6uQ9lQemmdgraqQE1LLfLU7ATJmC0+Rc7jS3GrMJBX7xVhZ2gf2++NTygzyOMXVsTd2X7DzlpaFV50+GEMXbWEzbJmSyVUglFi6FNxIqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(376002)(346002)(366004)(1800799006)(186006)(451199021)(2616005)(478600001)(6486002)(6506007)(26005)(31686004)(38100700002)(54906003)(66946007)(66476007)(66556008)(83380400001)(6512007)(6916009)(4326008)(316002)(8936002)(8676002)(5660300002)(4744005)(41300700001)(2906002)(31696002)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmNDTXk4UnB5Z0VubjRqMExWaHdxU2FSVFZPYU5lcURmWFEzVUx1SXFHeUJ4?= =?utf-8?B?WVhNSE9USlE3RHNVdGN3NjNneFdjOGNhbXpwa2VpUTdDMjY3RmVTQldnVlRw?= =?utf-8?B?VFpkQUJUMXlnZWZncldRR0N6WmxBdlhDSHRjaDdEYThQbm5SdWk5d21GQU9k?= =?utf-8?B?TjBoc0JBK1Zhd1VzazFVZ1BvSXJKRmFUTEJXTDNONTFyMGtMcW9wNkxvaXN1?= =?utf-8?B?QytXMWJpRU1KdFBZQ01mZ2JLVytycHcvQmNtUmcxd1V1ME9qOGt1OUtJQW5k?= =?utf-8?B?QTM2aVYrRmMzZzNhaHBNUDl4bHlvQkQyVFVCbU5pNE5udEFueVA3dGQzVUhv?= =?utf-8?B?S3hZbHd2aUNGZEVmZG9hUk5kK2U5WWxibkI3Mk83VklDM2VkSUNTWU90Wlds?= =?utf-8?B?NkNhNFpKZDFyT0tYZ3BZUGhSZ0FYRHRwcGQvd2phcExkakhoVWU2VlFVeSto?= =?utf-8?B?N1J4bWh5cERCOEZra3dUK2dWUSt1aTREbitCeklMbzF5b0JZa3dRWEN2ZnpG?= =?utf-8?B?NncwZWR3OTk0SXlrTmlzaTZzZVdvejFPSk5lVXVZVHpJTks2UVpOZStERVJH?= =?utf-8?B?Yk4rMGxJNUIvV21zQVlBbzhGOVdGYWppVU5SdTFsTkZ4MmdDOUF3QWs5QVBC?= =?utf-8?B?VXNSRjA2RVEyOUdFRGlVZmtYZ0M4ZTZKUlFPbG1vMHRWRk9jTW5yeVB4Qlpa?= =?utf-8?B?YWt0M25mM29KUklycWVDT2xpeTVlRGJEWGhKcE9Zam9yNUViZjZoNForanVV?= =?utf-8?B?WDdNS1MwSlZnNUoyZVdqUHZST2orTDJkQnFUTFo4VjZwd3pod0g1MzgwdGhm?= =?utf-8?B?VGtiUjNLWVMzYzdzaUt1ME5lYTVGQmJMSVNjZlNvUS94bGQ4TzJXbjlEa0ZV?= =?utf-8?B?Mm16bmdkeUwwb3pPdzFZeE0zTVlub2JsWC9GeDU5aDZoUWpnc2REbWdWdldn?= =?utf-8?B?NFFtekF2WFhiazJSekxnT3VFaW9pSlF4Rkw2Mkhma3JDZnNpS25sSjMvbTV6?= =?utf-8?B?NGNpdW9qTnZRV2oyU2d1ZnBoay9jU0U0NnEra2k0QmdCTUZWdEVIZzRQRHVw?= =?utf-8?B?NUErR204UGloMDFkR3VUTWtUazBSYzFubTdNeGs0UnZrendFRmd3eVR0MmVr?= =?utf-8?B?MHYwK0xldDMzem9jdVI2MktlOFBLKzh1WExnR2ZVZEdHK1M1K2VianhTZTA4?= =?utf-8?B?c0FtOXQzUHVubjdPK0RXQlhGRTZyY0MzN2pVS1VBZkVtVFU2QUx1cXcvRmw3?= =?utf-8?B?WlJGV25HUmtXR3VSbmZrY3kyS3d0Z01vREpocExLY1lpdUlURDZCSElvRWdX?= =?utf-8?B?SGtVMEg0NzAyZHV0NzZsT3NRS29NeDFVUys5NnY5WGwxandIL1ZnWmU4OHR0?= =?utf-8?B?ei82Y2p1VlBMa0lWUFdEM0xVd0QzYTdTV1BveEhvRTQzOXhSV0dWOHRUakhT?= =?utf-8?B?SW1WQ1diSUJzM09nbnV4WEk4UEpXTG9YOW5hZm0xa0VmaGMrNU1haTFHTGNr?= =?utf-8?B?aHZkbHNkNUdtd1NEbjVvVGdQNlZBTE4yWlFud1oyWHBiMllaZnNyeUw0emln?= =?utf-8?B?ZGJPNkRPNUoxZ3pkRTRKZlZoYnVnV1JYR0IzaU85T2tYVDdGOWdCejhDejJS?= =?utf-8?B?VFcvSUtueDZmWnNVSy8vTjR0N1dpUjhyVFFMWFdCcXZ3aFpsTDdzTVFpU1Zp?= =?utf-8?B?aHJCZ0E1MWhzQml5TFN2a0dvR0dSNFV5L25LSjVHUWlRRkQ5U01JcExEQUdi?= =?utf-8?B?TXV6Z05zc1dTdUY0elUxMnBtOERMWncrREhDZ3o0ZHY0Ly9QVWNKUUcyaHBi?= =?utf-8?B?OW5yd250alRIbTNENjRodGlENS9ocE1ydnUrd3VmRVpXUTUweTl2RDRHMEN6?= =?utf-8?B?WWdqdEtJWnhVczZyd2ZCM2kzN21MbWp3aEhlODFvSVdQbENLb2pWdE54cWpa?= =?utf-8?B?UkZESnJSTWhRRDlhUFZ6SG5qN1VxTlh1QVlKS0Jia21zYkdrQS8xVFZOOVJx?= =?utf-8?B?UkNVVFVFbGFkdm9JZUtNOE5YeUpOVFBVNkkxcWJ0cnU4NHdxcXlBSWhIRUIz?= =?utf-8?B?L0FNN0d1M3pNQk9iNk1oejNQdzZHMHRWbG1TTkd6MDZZbU9CbW1pWU5maitk?= =?utf-8?Q?bNoC3+TYuvWD5BYl9UkUHM0HB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6425e173-c97a-46ae-8374-08db99b5a295 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 15:22:40.0184 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mpu0K0h06OLYnnkmHznClKjLmvIUlKCtD0aD6WFqnseKt9kBx5+E0MWvzBVswjDvGCfRQmxcDh6vSdEfKg/44g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9951 There's nothing else that should need doing in order for guests to be able to use these insns. Signed-off-by: Jan Beulich --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -220,6 +220,8 @@ static const char *const str_7d1[32] = { [ 4] = "avx-vnni-int8", [ 5] = "avx-ne-convert", + [14] = "prefetchi", + [18] = "cet-sss", }; --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -309,6 +309,7 @@ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32 /* Intel-defined CPU features, CPUID level 0x00000007:1.edx, word 15 */ XEN_CPUFEATURE(AVX_VNNI_INT8, 15*32+ 4) /*A AVX-VNNI-INT8 Instructions */ XEN_CPUFEATURE(AVX_NE_CONVERT, 15*32+ 5) /*A AVX-NE-CONVERT Instructions */ +XEN_CPUFEATURE(PREFETCHI, 15*32+14) /*A PREFETCHIT{0,1} Instructions */ XEN_CPUFEATURE(CET_SSS, 15*32+18) /* CET Supervisor Shadow Stacks safe to use */ /* Intel-defined CPU features, MSR_ARCH_CAPS 0x10a.eax, word 16 */ From xen-devel-bounces@lists.xenproject.org Thu Aug 10 15:27:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 15:27:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582121.911714 (Exim 4.92) (envelope-from ) id 1qU7Z6-0001jF-HA; Thu, 10 Aug 2023 15:27:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582121.911714; Thu, 10 Aug 2023 15:27:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7Z6-0001j8-CU; Thu, 10 Aug 2023 15:27:08 +0000 Received: by outflank-mailman (input) for mailman id 582121; Thu, 10 Aug 2023 15:27:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7Z5-0001j0-6j for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 15:27:07 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c1f2147-3792-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 17:27:04 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 651614EE073F; Thu, 10 Aug 2023 17:27:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c1f2147-3792-11ee-8613-37d641c3527e MIME-Version: 1.0 Date: Thu, 10 Aug 2023 17:27:04 +0200 From: Nicola Vetrini To: Jan Beulich Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [XEN PATCH 1/2] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3 In-Reply-To: <35c1a691-92a3-0fb1-04f2-f75755a3b5e9@suse.com> References: <37bb5dc6f323bd2dc250c519523d05b66d17fdee.1691567429.git.nicola.vetrini@bugseng.com> <35c1a691-92a3-0fb1-04f2-f75755a3b5e9@suse.com> User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 14:45, Jan Beulich wrote: > On 09.08.2023 09:55, Nicola Vetrini wrote: >> The local variables 'irq_desc' shadow the homonymous global variable, >> declared in 'xen/arch/x86/include/asm/irq.h', therefore they are >> renamed >> 'irqd' for consistency. > > Perhaps with "for consistency" dropped (or else clarified what this > is to be consistent with) ... > >> Signed-off-by: Nicola Vetrini > > Reviewed-by: Jan Beulich > > Jan Good point. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) From xen-devel-bounces@lists.xenproject.org Thu Aug 10 15:41:19 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 15:41:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582128.911723 (Exim 4.92) (envelope-from ) id 1qU7md-0004DG-LJ; Thu, 10 Aug 2023 15:41:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582128.911723; Thu, 10 Aug 2023 15:41:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7md-0004D9-Hh; Thu, 10 Aug 2023 15:41:07 +0000 Received: by outflank-mailman (input) for mailman id 582128; Thu, 10 Aug 2023 15:41:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7mc-0004D1-1n for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 15:41:06 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50778b4c-3794-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 17:41:04 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 0B21C4EE073F; Thu, 10 Aug 2023 17:41:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50778b4c-3794-11ee-b284-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Paul Durrant Subject: [XEN PATCH] x86: address MISRA C:2012 Rule 5.3 Date: Thu, 10 Aug 2023 17:40:35 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Address some occurrences of shadowing between the global variable 'e820' in 'xen/arch/x86/e820.c' and the function parameter name of 'e820_add_range'. Since the function is only ever called with the global variable as the actual parameter, so there is no need to have it as a parameter because both are defined in the same file (mentioned above). This in turn causes several other functions to lose their parameter 'e820' because they are involved in the call chain that leads to 'e820_add_range'. Signed-off-by: Nicola Vetrini --- Other occurrences of shadowing on the same global in 'e820_change_range_type' and 'reserve_e820_ram' are not addressed in this patch and will be the subject of a future one, as the parameter needs to be renamed instead, and could potentially be part of a general name refactoring for consistency around e820. The following threads are useful to have more context about this patch, which was previously part of a series of changes related to the same MISRA Rule. - https://lore.kernel.org/xen-devel/3a9db416c6f8b2d5a549d49ff02238eb408cc905.1691492441.git.nicola.vetrini@bugseng.com/ - https://lore.kernel.org/xen-devel/896a2235560fd348f79eded33731609c5d2e74ab.1691162261.git.nicola.vetrini@bugseng.com/ --- xen/arch/x86/e820.c | 38 ++++++++++----------- xen/arch/x86/guest/hyperv/hyperv.c | 4 +-- xen/arch/x86/guest/hypervisor.c | 4 +-- xen/arch/x86/guest/xen/xen.c | 4 +-- xen/arch/x86/include/asm/e820.h | 3 +- xen/arch/x86/include/asm/guest/hypervisor.h | 6 ++-- xen/arch/x86/include/asm/pv/shim.h | 4 +-- xen/arch/x86/pv/shim.c | 10 +++--- xen/arch/x86/setup.c | 8 ++--- xen/arch/x86/x86_64/mmconf-fam10h.c | 2 +- xen/drivers/passthrough/amd/iommu_acpi.c | 2 +- 11 files changed, 42 insertions(+), 43 deletions(-) diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c index 4911e64b8cf4..6a3ce7e0a07f 100644 --- a/xen/arch/x86/e820.c +++ b/xen/arch/x86/e820.c @@ -543,27 +543,27 @@ static void __init machine_specific_memory_setup(struct e820map *raw) clip_to_limit(top_of_ram, "MTRRs do not cover all of memory."); } -/* This function relies on the passed in e820->map[] being sorted. */ -int __init e820_add_range( - struct e820map *e820, uint64_t s, uint64_t e, uint32_t type) +/* This function relies on the global e820->map[] being sorted. */ +int __init e820_add_range(uint64_t s, uint64_t e, uint32_t type) { unsigned int i; + struct e820entry *ei = e820.map; - for ( i = 0; i < e820->nr_map; ++i ) + for ( i = 0; i < e820.nr_map; ++i ) { - uint64_t rs = e820->map[i].addr; - uint64_t re = rs + e820->map[i].size; + uint64_t rs = ei[i].addr; + uint64_t re = rs + ei[i].size; - if ( rs == e && e820->map[i].type == type ) + if ( rs == e && ei[i].type == type ) { - e820->map[i].addr = s; + ei[i].addr = s; return 1; } - if ( re == s && e820->map[i].type == type && - (i + 1 == e820->nr_map || e820->map[i + 1].addr >= e) ) + if ( re == s && ei[i].type == type && + (i + 1 == e820.nr_map || ei[i + 1].addr >= e) ) { - e820->map[i].size += e - s; + ei[i].size += e - s; return 1; } @@ -574,20 +574,20 @@ int __init e820_add_range( return 0; } - if ( e820->nr_map >= ARRAY_SIZE(e820->map) ) + if ( e820.nr_map >= ARRAY_SIZE(e820.map) ) { printk(XENLOG_WARNING "E820: overflow while adding region" " %"PRIx64"-%"PRIx64"\n", s, e); return 0; } - memmove(e820->map + i + 1, e820->map + i, - (e820->nr_map - i) * sizeof(*e820->map)); + memmove(ei + i + 1, ei + i, + (e820.nr_map - i) * sizeof(*e820.map)); - e820->nr_map++; - e820->map[i].addr = s; - e820->map[i].size = e - s; - e820->map[i].type = type; + e820.nr_map++; + ei[i].addr = s; + ei[i].size = e - s; + ei[i].type = type; return 1; } @@ -694,7 +694,7 @@ unsigned long __init init_e820(const char *str, struct e820map *raw) machine_specific_memory_setup(raw); if ( cpu_has_hypervisor ) - hypervisor_e820_fixup(&e820); + hypervisor_e820_fixup(); printk("%s RAM map:\n", str); print_e820_memory_map(e820.map, e820.nr_map); diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c index aacc7a61670b..912099564ec4 100644 --- a/xen/arch/x86/guest/hyperv/hyperv.c +++ b/xen/arch/x86/guest/hyperv/hyperv.c @@ -187,11 +187,11 @@ static int cf_check ap_setup(void) return setup_vp_assist(); } -static void __init cf_check e820_fixup(struct e820map *e820) +static void __init cf_check e820_fixup(void) { uint64_t s = HV_HCALL_MFN << PAGE_SHIFT; - if ( !e820_add_range(e820, s, s + PAGE_SIZE, E820_RESERVED) ) + if ( !e820_add_range(s, s + PAGE_SIZE, E820_RESERVED) ) panic("Unable to reserve Hyper-V hypercall range\n"); } diff --git a/xen/arch/x86/guest/hypervisor.c b/xen/arch/x86/guest/hypervisor.c index b8549a131a5a..e0b046cc6c89 100644 --- a/xen/arch/x86/guest/hypervisor.c +++ b/xen/arch/x86/guest/hypervisor.c @@ -60,10 +60,10 @@ void hypervisor_resume(void) ops.resume(); } -void __init hypervisor_e820_fixup(struct e820map *e820) +void __init hypervisor_e820_fixup(void) { if ( ops.e820_fixup ) - ops.e820_fixup(e820); + ops.e820_fixup(); } int hypervisor_flush_tlb(const cpumask_t *mask, const void *va, diff --git a/xen/arch/x86/guest/xen/xen.c b/xen/arch/x86/guest/xen/xen.c index f93dfc89f724..2eed32fe46c7 100644 --- a/xen/arch/x86/guest/xen/xen.c +++ b/xen/arch/x86/guest/xen/xen.c @@ -306,10 +306,10 @@ static void cf_check resume(void) pv_console_init(); } -static void __init cf_check e820_fixup(struct e820map *e820) +static void __init cf_check e820_fixup(void) { if ( pv_shim ) - pv_shim_fixup_e820(e820); + pv_shim_fixup_e820(); } static int cf_check flush_tlb( diff --git a/xen/arch/x86/include/asm/e820.h b/xen/arch/x86/include/asm/e820.h index 213d5b5dd227..af90085d65d1 100644 --- a/xen/arch/x86/include/asm/e820.h +++ b/xen/arch/x86/include/asm/e820.h @@ -29,8 +29,7 @@ extern int reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e); extern int e820_change_range_type( struct e820map *e820, uint64_t s, uint64_t e, uint32_t orig_type, uint32_t new_type); -extern int e820_add_range( - struct e820map *, uint64_t s, uint64_t e, uint32_t type); +extern int e820_add_range(uint64_t s, uint64_t e, uint32_t type); extern unsigned long init_e820(const char *str, struct e820map *raw); extern void print_e820_memory_map(const struct e820entry *map, unsigned int entries); diff --git a/xen/arch/x86/include/asm/guest/hypervisor.h b/xen/arch/x86/include/asm/guest/hypervisor.h index 4cffea386609..c8f18a035ee6 100644 --- a/xen/arch/x86/include/asm/guest/hypervisor.h +++ b/xen/arch/x86/include/asm/guest/hypervisor.h @@ -22,7 +22,7 @@ struct hypervisor_ops { /* Resume from suspension */ void (*resume)(void); /* Fix up e820 map */ - void (*e820_fixup)(struct e820map *e820); + void (*e820_fixup)(void); /* L0 assisted TLB flush */ int (*flush_tlb)(const cpumask_t *mask, const void *va, unsigned int flags); }; @@ -33,7 +33,7 @@ const char *hypervisor_probe(void); void hypervisor_setup(void); int hypervisor_ap_setup(void); void hypervisor_resume(void); -void hypervisor_e820_fixup(struct e820map *e820); +void hypervisor_e820_fixup(void); /* * L0 assisted TLB flush. * mask: cpumask of the dirty vCPUs that should be flushed. @@ -52,7 +52,7 @@ static inline const char *hypervisor_probe(void) { return NULL; } static inline void hypervisor_setup(void) { ASSERT_UNREACHABLE(); } static inline int hypervisor_ap_setup(void) { return 0; } static inline void hypervisor_resume(void) { ASSERT_UNREACHABLE(); } -static inline void hypervisor_e820_fixup(struct e820map *e820) {} +static inline void hypervisor_e820_fixup(void) {} static inline int hypervisor_flush_tlb(const cpumask_t *mask, const void *va, unsigned int flags) { diff --git a/xen/arch/x86/include/asm/pv/shim.h b/xen/arch/x86/include/asm/pv/shim.h index 5625b90b72bd..6153e2700598 100644 --- a/xen/arch/x86/include/asm/pv/shim.h +++ b/xen/arch/x86/include/asm/pv/shim.h @@ -33,7 +33,7 @@ void pv_shim_online_memory(unsigned int nr, unsigned int order); void pv_shim_offline_memory(unsigned int nr, unsigned int order); domid_t get_initial_domain_id(void); uint64_t pv_shim_mem(uint64_t avail); -void pv_shim_fixup_e820(struct e820map *e820); +void pv_shim_fixup_e820(void); const struct platform_bad_page *pv_shim_reserved_pages(unsigned int *size); typeof(do_event_channel_op) pv_shim_event_channel_op; typeof(do_grant_table_op) pv_shim_grant_table_op; @@ -85,7 +85,7 @@ static inline uint64_t pv_shim_mem(uint64_t avail) ASSERT_UNREACHABLE(); return 0; } -static inline void pv_shim_fixup_e820(struct e820map *e820) +static inline void pv_shim_fixup_e820(void) { ASSERT_UNREACHABLE(); } diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index 404408711972..ca0e639db323 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -98,17 +98,17 @@ uint64_t pv_shim_mem(uint64_t avail) return shim_nrpages; } -static void __init mark_pfn_as_ram(struct e820map *e820, uint64_t pfn) +static void __init mark_pfn_as_ram(uint64_t pfn) { - if ( !e820_add_range(e820, pfn << PAGE_SHIFT, + if ( !e820_add_range(pfn << PAGE_SHIFT, (pfn << PAGE_SHIFT) + PAGE_SIZE, E820_RAM) && - !e820_change_range_type(e820, pfn << PAGE_SHIFT, + !e820_change_range_type(&e820, pfn << PAGE_SHIFT, (pfn << PAGE_SHIFT) + PAGE_SIZE, E820_RESERVED, E820_RAM) ) panic("Unable to add/change memory type of pfn %#lx to RAM\n", pfn); } -void __init pv_shim_fixup_e820(struct e820map *e820) +void __init pv_shim_fixup_e820(void) { uint64_t pfn = 0; unsigned int i = 0; @@ -120,7 +120,7 @@ void __init pv_shim_fixup_e820(struct e820map *e820) rc = xen_hypercall_hvm_get_param(p, &pfn); \ if ( rc ) \ panic("Unable to get " #p "\n"); \ - mark_pfn_as_ram(e820, pfn); \ + mark_pfn_as_ram(pfn); \ ASSERT(i < ARRAY_SIZE(reserved_pages)); \ reserved_pages[i++].mfn = pfn; \ }) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 80ae973d64e4..03f9a0318058 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -686,7 +686,7 @@ static void __init parse_video_info(void) #endif } -static void __init kexec_reserve_area(struct e820map *e820) +static void __init kexec_reserve_area(void) { #ifdef CONFIG_KEXEC unsigned long kdump_start = kexec_crash_area.start; @@ -700,7 +700,7 @@ static void __init kexec_reserve_area(struct e820map *e820) is_reserved = true; - if ( !reserve_e820_ram(e820, kdump_start, kdump_start + kdump_size) ) + if ( !reserve_e820_ram(&boot_e820, kdump_start, kdump_start + kdump_size) ) { printk("Kdump: DISABLED (failed to reserve %luMB (%lukB) at %#lx)" "\n", kdump_size >> 20, kdump_size >> 10, kdump_start); @@ -1308,7 +1308,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( e820.map[i].type == E820_RAM ) nr_pages += e820.map[i].size >> PAGE_SHIFT; set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); - kexec_reserve_area(&boot_e820); + kexec_reserve_area(); initial_images = mod; nr_initial_images = mbi->mods_count; @@ -1495,7 +1495,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); /* Late kexec reservation (dynamic start address). */ - kexec_reserve_area(&boot_e820); + kexec_reserve_area(); setup_max_pdx(raw_max_page); if ( highmem_start ) diff --git a/xen/arch/x86/x86_64/mmconf-fam10h.c b/xen/arch/x86/x86_64/mmconf-fam10h.c index a834ab3149be..36b32eb769e1 100644 --- a/xen/arch/x86/x86_64/mmconf-fam10h.c +++ b/xen/arch/x86/x86_64/mmconf-fam10h.c @@ -135,7 +135,7 @@ static void __init get_fam10h_pci_mmconf_base(void) return; out: - if (e820_add_range(&e820, start, start + SIZE, E820_RESERVED)) + if (e820_add_range(start, start + SIZE, E820_RESERVED)) fam10h_pci_mmconf_base = start; } diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index 3b577c9b390c..db993d6df275 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -418,7 +418,7 @@ static int __init parse_ivmd_block(const struct acpi_ivrs_memory *ivmd_block) if ( type == RAM_TYPE_UNKNOWN ) { - if ( e820_add_range(&e820, addr, addr + PAGE_SIZE, + if ( e820_add_range(addr, addr + PAGE_SIZE, E820_RESERVED) ) continue; AMD_IOMMU_ERROR("IVMD: page at %lx couldn't be reserved\n", -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 15:53:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 15:53:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582136.911733 (Exim 4.92) (envelope-from ) id 1qU7yF-0005sp-Rj; Thu, 10 Aug 2023 15:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582136.911733; Thu, 10 Aug 2023 15:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7yF-0005si-Nn; Thu, 10 Aug 2023 15:53:07 +0000 Received: by outflank-mailman (input) for mailman id 582136; Thu, 10 Aug 2023 15:53:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU7yE-0005sZ-9d for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 15:53:06 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2053.outbound.protection.outlook.com [40.107.13.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd8c59b4-3795-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 17:53:04 +0200 (CEST) Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8413.eurprd04.prod.outlook.com (2603:10a6:20b:3ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 15:52:34 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6652.025; Thu, 10 Aug 2023 15:52:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd8c59b4-3795-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fy1yztWJnftEHBxbd++hiCIHnNmE/TNxQVuVWTliGY9pSe03gVIrdpKJ0ISIbSZ9fLnQKkOpaq55576jr2iDKCVIN5uP/9pNJeWjGhKB6omAvHgVVgpeB22QxBabwZc+IDsjvYM4W4eK/Lra8X1w8xsvWg7J0Wzj3kH1vmtSJy5ZgQYSGRkBEt0redIHIO5falcpJKHvekaAsjWJ8R6WSONffD1gdhq4bg9qBG2OuiG3xTKKEbICiPZdq4ccezi+3kBbVrGTdq3+1QS9U1/CT06+zKuAOF2OAv3ZIvY/U8jHkfYiQghrnZwiNLxtTcg2PswxbAxT55HJoMjOJLP3uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z60Ti2fMSVeqHGDewhZxhZipQmInqV1YQBGZbZPUA8Q=; b=IuLn4xS5zooENP/UkYm2aVSArWR5dqVfjxYNk2OWq88uxLFvLzIXKdbCtpeJPZM5o+/ecQU+N1XqpdSUuJXrfRERAC92YuCb+9PgSEKtRmZXZ0OOjR+B5jmEGdKCBVRZn4WydsLPfpIBq7Qmzl1KMQVx0qLllS45QYU+apqcpfaOcY7TEXuqgCFD+7cfcUuqyxwCGBqOwipvbrwmwdL0yJ1IBRaYW/HKXazc+sHjZy4o7g7ESQYPC59kWMAAdY0pBXf2S+EtYeDsy2OZynWFc9s9BRkcO8n13McSCRR3Inc3+31ji8RslxG840ewS3+aWywUYrPvwfnH8Mo6UpM52w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z60Ti2fMSVeqHGDewhZxhZipQmInqV1YQBGZbZPUA8Q=; b=PGuNas/Ppk6s00uVKvFp42BFp6nlTlKEDw7cKL7ZXacS1bJV5EwL4FQ82uTPBfcC9XEg9nPzPjE2GL7oFYZEfMbjn0nyLXq/4twfwmk8A5fNqas4astbWksaTXJdVk0c/oeT2lMKl0fWeOd64DZ6AtDQ3TDXGPnSmTJ0ch7fnpTXijmKQZ33TQUAoRY8DKJj/Lo+0meGEgPvXHRducpWYPaolp/84O7N11Ts+Vb3V4HqMhLc5u64XReaG5DIWTGKs+Tx6gqJrJAHSTK9M2qGX/uSYmP2r5kcICv8WT42r1I5KlXG3MYAxSRe9CleGoIg3r0XF70gpYGDH2M40I//Hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 10 Aug 2023 17:52:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH] x86: address MISRA C:2012 Rule 5.3 Content-Language: en-US To: Nicola Vetrini Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::15) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8413:EE_ X-MS-Office365-Filtering-Correlation-Id: 0035d7a7-ed07-41dc-4415-08db99b9d025 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uFHWzIMDcigwwM3YDYvbZ0tlUIRql7fHG/UJIiPG1vkE83FRuF1B1n+FUzgVaob5exaClqXu0k0S7MJGXeU3R38dDzkApZlJNaRtUm30aQgrYY7JqmaNfFIm5luSe/fbdppTUtJ6pcKKDOUDMJPo1mQd5lhVn0kUGDgAEpt5KDUaenktxjRziZzjMtiE3x2pf/aoq6UcwcnKm50r0ZKQKrwhgACSV1RPJMxVkvPQSbctLZ3f3mBdWqk1h17z4aX5NFUZbAjUjfY0Jpyxpg/DxQoqKBjSmQ3jY0J8Gsc8CqOBnA+eb/DYQHy4irXmtiK3bBfXTr39fH1Yn1w6l+r4Tj0heTYdhgBPZDxLCNI/F2bpbebN68o7na6mxW4g2P6+B7e0GjTiIrSTpKX14CN3RTKzWDrVvgzTocdZUj+zO70/gYTvSxI3ohcxx3jDR9GMzleHBeP2gY08shttUA+IggRfHnkSKDzhqp/knNSxt1VsVfrREvFry83F6ajnTqYQFgqJ4ne2rr2SlhxsV8I2gV3hKlgiChAgb42pyk+YaqufoyzMyESjKuVU7gwFbcVPKPPIz/A2A/BCrj56w0XckXMZxsygu4CmnwOj/FjixjH637RjANjqp4Ga0mNpohmu68lW1I9bhfkmY54qEAEzsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(346002)(136003)(376002)(396003)(186006)(1800799006)(451199021)(36756003)(86362001)(66946007)(478600001)(53546011)(66556008)(66476007)(6916009)(54906003)(26005)(6486002)(6506007)(6512007)(2906002)(41300700001)(7416002)(316002)(4326008)(8936002)(5660300002)(31696002)(8676002)(38100700002)(83380400001)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlJ6Ynh6UmZvUDZRRVlXY3phTS9OMmQ4RHhmTnZGenBxU3Z5TWdKREFNS3Ja?= =?utf-8?B?RlNTcGt5SDNQMks4N3VjbkU3cGNiQnhoZXVNdjUrancyWSswc3RLSUl6RmFm?= =?utf-8?B?MVhXVzdPdWk1MUNpZGNYd3grbjUvcEFRaTBpNThDOEhPeFJtbncrWVhZdU9i?= =?utf-8?B?aUZNejYxMkhEMndYOVVpV2l4MHo5RVl4cUgvb3RKZEVBTW53R21Ic0NiSG5q?= =?utf-8?B?RmpCV3VRUG5NWnZXUml6dXY1SUdSajRYYUpVM0phTVJhcXNkOGpqZk11cVJV?= =?utf-8?B?ZXNBcmdsd0NYc09tWmo3SGg3OERUWm1ka1NJNTVmaU5jM1FvYmh4bE5lQ2x2?= =?utf-8?B?TVF6T25vZG01ZzRxMndLSU41Ky9mQWFtRmEvUW1UNTl3d3lYVFd2RmV3cHow?= =?utf-8?B?aktNdVZFNDZ5WkRBU24zSWhrRDZuaS9JaWhqSCtHZHBFMzdUa216STZqaTBZ?= =?utf-8?B?QS9mTkZHOHhnaGI0RjFzRUc1ZU5vVHN2cGNOeHhsOWRaa1NYS0hJZGpsdlQ4?= =?utf-8?B?ZEF3czVXRHozUkJXSDlZQnVsSnRQVXdzRmNRaUM5c05hNHBuQU9qTzRCVFVl?= =?utf-8?B?VnNGZEUrcDVybEEwMTEvNVdkSFRIVlJUOXpXL2ZyblNaTHFjd2tqUjlhWFhs?= =?utf-8?B?enU2TkFmTE9PM0hTbXNiaHM3ZkRiK3dEWCtudVJ4YTl2WHBlV1VjTGRUOVJq?= =?utf-8?B?TW5BbEJLNEdiNXZOdElzSGpyMnBhSldFU0VjVnlETmR0clVkU29reWFOQnZo?= =?utf-8?B?bm5uMGxuT1dIWGRGUVRoYm5ENHdvcE9yOWxQVFgwU0M2WXpsTVp0QVVFTmQ5?= =?utf-8?B?VXVNSTZORHl4cjlPbUdpYUlLYzBHdVE0c2xiSDk1RjdxWWJTSXE3TmJZWjMv?= =?utf-8?B?bUlYb3JXY1E3MnpzbTVxNHhXanR5WGFHekVJUjUyUm40NUlEeW1FZ3JPSEhT?= =?utf-8?B?Yk9YRy94SDNRRklEdEFYUzJzVEw3Y0NRd1AxTU5XWU54LzdpUG1MOVcvcVR3?= =?utf-8?B?WFdMbnNFU1R3eTI2Y3ZrZ29sV1AvNjByWGtiOGdhRmh0SWZrdXVBR0QybkVT?= =?utf-8?B?bHhLT1ZudUJpVXlDNVYrNVowazljTDE3WS9RS0REYUV4VWRBWXhoN29qbllW?= =?utf-8?B?S0JRVGN4SlZXTVFtemwzSUtnekJ0ZXk2NkZOaFM3ZEZCMnR1bFlGb2VRUlh2?= =?utf-8?B?THFtVWswckV2L205UjFPc3ErcjdHWUpnR3NxYUd4dU5wdG1mWkZsRTJKVHdM?= =?utf-8?B?NG5ZWGNna0xiRk4wdHNNK3JTS3p0aGVUNzlramw5VE1vUEs1aitVQkRFRXNT?= =?utf-8?B?dUhDNk1LSHVvZ01aT3k2T2hjeVluYy9KbDh5WmRqK0tBbkdlOGFCK3ZRc2tE?= =?utf-8?B?bklkc1A1TG5ZUlMwN0c3dTVHRmd2dmJVL1NJQ0w1NklZbUIxbXZ4MC9JeUFM?= =?utf-8?B?MUJlRTNTT29GcmNwN082TUw4dWkrc1U1R0Z0T3BhTWpad3pEWTlRYlowTytR?= =?utf-8?B?cUIweFV6ZTFKdmQzQStqeGtHMEsxVzNhclhsekpmMVNIaGNBbTdaOUhZUm94?= =?utf-8?B?aWxibXU5Q3FkQnJEclZqV3NJanVvNkVhdWdQQjM2L1BjelNEejI2bmxiTUxy?= =?utf-8?B?cGFCMXY4RHM0cFlleEtwQnNYRlMrUnUrWG9yOWNsZ3lwTGpWSXRPSDV0VlZH?= =?utf-8?B?bjVVRW92b0taUXZmVHhPRzZkR2hCbkM0c2ZGd2pRZTJiTVphWW5DTVZ6SW1I?= =?utf-8?B?Zys4dzhid1FTMFVPYlcxWm1LSmJiSytyc3F0ZHYyVWlnTGFYYjVHaWhnM0h3?= =?utf-8?B?RlJYVUhXd3ZJWEF1QmNXWmRQZVNQQm1QWW1kTDdUTnVXcE84M2ZwYXlCekFh?= =?utf-8?B?c09SN3RCa1ZKSU8zWDRlN3ljbUFMUisvS3lGVWxjNXJXbjZQd1FTRTBKYmN1?= =?utf-8?B?TFJrOGhoTUFITkRYZUp1MlJacUFnY1BhdWxFYTh3eTAwTFVMVmdIYnhIVDRo?= =?utf-8?B?bjc5OHJEUWx1bkxIejYraGFRa2dWTWxoN0tvc3ljZnB6NFdrVWs3d1hrTGJO?= =?utf-8?B?WlJMN2kvTWxhYUFXV0Y1bzEwa2dwK0tMUGJFMC9jY296M1ljUzVHSFFEcVdG?= =?utf-8?Q?k4ivFy9aiuTAOYYCRJAhbP7s5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0035d7a7-ed07-41dc-4415-08db99b9d025 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 15:52:34.4868 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ICy40V4m9TYSClGd+bgGVrLIRB7ouwX+7leZvPrBLUqKlSjcQKK50JChYYuswErEvX7VP47koN9h1OaWGwOX+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8413 On 10.08.2023 17:40, Nicola Vetrini wrote: > Address some occurrences of shadowing between the global > variable 'e820' in 'xen/arch/x86/e820.c' and the function > parameter name of 'e820_add_range'. > > Since the function is only ever called with the global variable > as the actual parameter, so there is no need to have it as a parameter > because both are defined in the same file (mentioned above). > This in turn causes several other functions to lose their parameter > 'e820' because they are involved in the call chain that leads to > 'e820_add_range'. > > Signed-off-by: Nicola Vetrini The changes look okay to me now, but ... > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -686,7 +686,7 @@ static void __init parse_video_info(void) > #endif > } > > -static void __init kexec_reserve_area(struct e820map *e820) > +static void __init kexec_reserve_area(void) > { > #ifdef CONFIG_KEXEC > unsigned long kdump_start = kexec_crash_area.start; > @@ -700,7 +700,7 @@ static void __init kexec_reserve_area(struct e820map *e820) > > is_reserved = true; > > - if ( !reserve_e820_ram(e820, kdump_start, kdump_start + kdump_size) ) > + if ( !reserve_e820_ram(&boot_e820, kdump_start, kdump_start + kdump_size) ) > { > printk("Kdump: DISABLED (failed to reserve %luMB (%lukB) at %#lx)" > "\n", kdump_size >> 20, kdump_size >> 10, kdump_start); > @@ -1308,7 +1308,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > if ( e820.map[i].type == E820_RAM ) > nr_pages += e820.map[i].size >> PAGE_SHIFT; > set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); > - kexec_reserve_area(&boot_e820); > + kexec_reserve_area(); > > initial_images = mod; > nr_initial_images = mbi->mods_count; > @@ -1495,7 +1495,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > reserve_e820_ram(&boot_e820, __pa(_stext), __pa(__2M_rwdata_end)); > > /* Late kexec reservation (dynamic start address). */ > - kexec_reserve_area(&boot_e820); > + kexec_reserve_area(); > > setup_max_pdx(raw_max_page); > if ( highmem_start ) ... this isolated set of changes wants either breaking out into a separate patch (as suggested before) or at least needs mentioning in the description. Jan From xen-devel-bounces@lists.xenproject.org Thu Aug 10 16:30:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 16:30:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582142.911743 (Exim 4.92) (envelope-from ) id 1qU8Xj-0001aV-KT; Thu, 10 Aug 2023 16:29:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582142.911743; Thu, 10 Aug 2023 16:29:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8Xj-0001aO-HW; Thu, 10 Aug 2023 16:29:47 +0000 Received: by outflank-mailman (input) for mailman id 582142; Thu, 10 Aug 2023 16:29:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8Xi-0001aE-DV; Thu, 10 Aug 2023 16:29:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8Xi-00043X-1P; Thu, 10 Aug 2023 16:29:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8Xh-0008O9-FV; Thu, 10 Aug 2023 16:29:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qU8Xh-0007dM-Ec; Thu, 10 Aug 2023 16:29:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=svFquUfXO39BkKc92Fd/LjjErHlBzprRofMwNowCO/o=; b=09WVenpPDk5IerB6rvRc7pLdhm kV3Hsx5j4yIzf9fh1GeTWZf3x395GhWB3J8qy/GVXwHn2GgtYYbrP/ycnCTjNUM8PEEDU/RRgIK6c tzJalgtdSQzrQir9THm9gGIsA1rS5HA4eXBvNvk2IxcfCfSs4Ru3ftrrdPlCc19/SWVE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182242: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=32e07fddc6d989dc5fdff4f9c9e47cb1f3911904 X-Osstest-Versions-That: qemuu=0450cf08976f9036feaded438031b4cba94f6452 From: osstest service owner Date: Thu, 10 Aug 2023 16:29:45 +0000 flight 182242 qemu-mainline real [real] flight 182262 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182242/ http://logs.test-lab.xenproject.org/osstest/logs/182262/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail pass in 182262-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182231 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182231 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182231 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182231 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182231 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182231 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182231 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182231 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 32e07fddc6d989dc5fdff4f9c9e47cb1f3911904 baseline version: qemuu 0450cf08976f9036feaded438031b4cba94f6452 Last test of basis 182231 2023-08-08 08:51:50 Z 2 days Testing same since 182242 2023-08-09 00:10:47 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex BennĂ©e Helge Deller Ilya Leoshkevich Michael Tokarev Paolo Bonzini Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 0450cf0897..32e07fddc6 32e07fddc6d989dc5fdff4f9c9e47cb1f3911904 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Aug 10 16:30:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 16:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582147.911753 (Exim 4.92) (envelope-from ) id 1qU8YH-0002rc-3H; Thu, 10 Aug 2023 16:30:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582147.911753; Thu, 10 Aug 2023 16:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8YG-0002rV-V2; Thu, 10 Aug 2023 16:30:20 +0000 Received: by outflank-mailman (input) for mailman id 582147; Thu, 10 Aug 2023 16:30:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8YF-0002q6-Qo; Thu, 10 Aug 2023 16:30:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8YF-00044a-Pw; Thu, 10 Aug 2023 16:30:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU8YF-0008Oo-EY; Thu, 10 Aug 2023 16:30:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qU8YF-00088d-E7; Thu, 10 Aug 2023 16:30:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Aoqh9SWCTBCIcPX0TeGf/olYa545k/cKAHF2sgjpEGY=; b=VLd1EMPMMigGEUg7YUw/9SevwO nr/nhN6bU+tLZ0waWF6g660ytoaiCSvYlYijpk+8zHN6zAVjlhWdZ2/ATLJQ58LzSeljsf1YLOT1+ knldnE7BCRfWaLcAkOXnQ3FDagxa0KL/3crIrgtlvDyRMZG5DcDCBkCJf28XrnadbZ+c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182261: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b70ffd23865e6c320fe2e8931f0d0366d7e03cac X-Osstest-Versions-That: xen=79c18114c7d71f0227abbbb75e24d114483765f7 From: osstest service owner Date: Thu, 10 Aug 2023 16:30:19 +0000 flight 182261 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182261/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b70ffd23865e6c320fe2e8931f0d0366d7e03cac baseline version: xen 79c18114c7d71f0227abbbb75e24d114483765f7 Last test of basis 182255 2023-08-10 01:02:13 Z 0 days Testing same since 182261 2023-08-10 14:02:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Nicola Vetrini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 79c18114c7..b70ffd2386 b70ffd23865e6c320fe2e8931f0d0366d7e03cac -> smoke From xen-devel-bounces@lists.xenproject.org Thu Aug 10 17:12:35 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 17:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582159.911763 (Exim 4.92) (envelope-from ) id 1qU9D4-0007Zy-2X; Thu, 10 Aug 2023 17:12:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582159.911763; Thu, 10 Aug 2023 17:12:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU9D3-0007Zr-Uy; Thu, 10 Aug 2023 17:12:29 +0000 Received: by outflank-mailman (input) for mailman id 582159; Thu, 10 Aug 2023 17:12:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU9D2-0007Zh-Kf; Thu, 10 Aug 2023 17:12:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU9D2-0004vr-8c; Thu, 10 Aug 2023 17:12:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qU9D1-000151-SC; Thu, 10 Aug 2023 17:12:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qU9D1-0007c8-Rj; Thu, 10 Aug 2023 17:12:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XX70+WW5YXvCCpm88vl1+mDL5R9Cz5vqHVPJTNZfTDI=; b=UbmK/wp1brmnS7XUTW1z3Xu7/W EW7IgrNbumkltaHr0CaIbTC0CPUk3vZCU0Hy1zU9Xe83DpKrHgjhrleqR669/2dyVDnwMpf0TLafg BLvGEElwKFZQpWpczo62SECnGpazhIKGtemz0UpjvlFmmh3V8hsbJq9TtRl5QAY0Ib6A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 182244: tolerable all pass - PUSHED X-Osstest-Failures: libvirt:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt:saverestore-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking libvirt:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:saverestore-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking libvirt:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking libvirt:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: libvirt=831b5a6bd6d72d58494018b7051894ccc1310c49 X-Osstest-Versions-That: libvirt=3d2f3fb72b4c1d636822606ef8b1df29ae4a2be6 From: osstest service owner Date: Thu, 10 Aug 2023 17:12:27 +0000 flight 182244 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182244/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182192 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182192 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182192 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-qcow2 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: libvirt 831b5a6bd6d72d58494018b7051894ccc1310c49 baseline version: libvirt 3d2f3fb72b4c1d636822606ef8b1df29ae4a2be6 Last test of basis 182192 2023-08-05 04:27:27 Z 5 days Testing same since 182244 2023-08-09 04:20:35 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anastasia Belova Michal Privoznik ĐĐ½Đ°ÑÑ‚Đ°ÑĐ¸Ñ Đ‘ĐµĐ»Đ¾Đ²Đ° jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-libvirt pass test-arm64-arm64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-arm64-arm64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-libvirt-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/libvirt.git 3d2f3fb72b..831b5a6bd6 831b5a6bd6d72d58494018b7051894ccc1310c49 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Aug 10 18:56:15 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 18:56:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582167.911773 (Exim 4.92) (envelope-from ) id 1qUApF-00017G-6M; Thu, 10 Aug 2023 18:56:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582167.911773; Thu, 10 Aug 2023 18:56:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUApF-000179-2r; Thu, 10 Aug 2023 18:56:01 +0000 Received: by outflank-mailman (input) for mailman id 582167; Thu, 10 Aug 2023 18:55:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUApD-000173-Kf for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 18:55:59 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89e5f34a-37af-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 20:55:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2DEA56671A; Thu, 10 Aug 2023 18:55:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91681C433C9; Thu, 10 Aug 2023 18:55:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89e5f34a-37af-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691693756; bh=1qtEapxNGDH8skkuiQdfvCd0U3w8aOvV4LLqp7mfI74=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=N5LW9thZgqRZlGbETyYJMk90Ougk+zkmkk5nJYFqj1fOXKIz1BlPpTdl1rUjfcTEt kfe1zFD1IzuJbYkfZ/ZHsjhMqVbWL7vDczXKVNEJnTvSbm25cZPxvQLPFqhYgipotd LUFFFGkhiX6qBu5qUdkLV/wh9liJuuRMBN0dVR884VKsOhbjrd/vGH0U3hZ1u96gFg dM7fg7pxXSG9xo8ZJ4/hK/a8ZQy2zebHjzTE5pxcnoP+yxEVCdmEsn4Me/azxkC2Fh C/lgRg1EY8B6R7BJnRTl8+VS4hPp5N812vdlIaT3FDhvA6gevyXs4sHy7wo4uWi2IY ISlIZmpcaoUcw== Date: Thu, 10 Aug 2023 11:55:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Nicola Vetrini , xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: Re: [XEN PATCH] xen/arm: traps: remove unused function 'dump_guest_s1_walk' In-Reply-To: Message-ID: References: <23c5b1a1ffc755b5db17d699a08fc86e1f0cc788.1691659744.git.nicola.vetrini@bugseng.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 10 Aug 2023, Julien Grall wrote: > Hi, > > On 10/08/2023 10:29, Nicola Vetrini wrote: > > The function in question has no callers and its removal has already > > been proposed (and acked) as part of this larger series [1]. > > This is useful information after for the reviewer to know it was already > acked, but it is not really past commit. So I would move it after ---. > > > There have been further bugfixes to that function [2], but they do not add > > any caller, hence it can be removed. > > If you want to mention bugfixes, then it is best to refer to a commit rather > than the e-mail thread. > > > > > [1] > > https://lore.kernel.org/xen-devel/1395766541-23979-27-git-send-email-julien.grall@linaro.org/ > > [2] https://lore.kernel.org/xen-devel/20160720161017.4508-1-jtd@galois.com/ > > > > Signed-off-by: Nicola Vetrini > > Suggested-by: Julien Grall > > Aside the e-mail address, you want to order tag in chronogical order. This was > suggested by me then you wrote the patch. So it Suggested-by should be first. > > Other than that, I would like Bertrand/Stefano to confirm if they are Ok with > the removal. Fine by me From xen-devel-bounces@lists.xenproject.org Thu Aug 10 19:13:42 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 19:13:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582173.911783 (Exim 4.92) (envelope-from ) id 1qUB6F-0003Zv-JH; Thu, 10 Aug 2023 19:13:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582173.911783; Thu, 10 Aug 2023 19:13:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6F-0003Zo-GL; Thu, 10 Aug 2023 19:13:35 +0000 Received: by outflank-mailman (input) for mailman id 582173; Thu, 10 Aug 2023 19:13:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6E-0003Ze-30 for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 19:13:34 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on20610.outbound.protection.outlook.com [2a01:111:f400:fe5a::610]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fcfebe1d-37b1-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 21:13:30 +0200 (CEST) Received: from CY5PR15CA0219.namprd15.prod.outlook.com (2603:10b6:930:88::18) by BL1PR12MB5286.namprd12.prod.outlook.com (2603:10b6:208:31d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 19:13:26 +0000 Received: from CY4PEPF0000EDD2.namprd03.prod.outlook.com (2603:10b6:930:88:cafe::a) by CY5PR15CA0219.outlook.office365.com (2603:10b6:930:88::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 19:13:26 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EDD2.mail.protection.outlook.com (10.167.241.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 19:13:25 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 14:13:25 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 12:13:24 -0700 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 14:13:24 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcfebe1d-37b1-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y08H5BOauLvq7pBlXvMs0+bChBLa2sexR/kI4Xx27Jo68wxoud+bL9MEtDdPGm18l7+rwlog9it5cLAYJc+gWIVXRGzCSzdrQqNoXU3xQKDojBIpQNSto3lD3ndVoXE598sOSRIv5ULC6SjBq/dByCKELOilyG7tdkZcZ4xZVYSHHZ55KETyGyPDsBfPrvrqBHhUi/Rtv+uKkISRXrQV4s6PooPyv+hlZJR+rcx+2QqDdR1bJ4+Cfz3Tek6MoZWc04ae/mEzc2UyUbii2UlJdV3N7z2CJyPVr9HtrNsXyZUTaBGOTAI/g7ogyCaF42EjWGivBMKpMj8VYU94rnYfwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vRNrOjRzH+p+vR5qGxvK+DfrbcxqF7sGm8KJMpyIBfM=; b=XCkv/7gIz46NiFAIM+btP5A+A/LD/O56mafsEHJqfFjh8jk3zQURb2oeWTf5iBT6H7dOcAlaozNLXU9PtvSuu1Plga2KHfCgvs8CPHuXRYvXs69VV+dZ8dO/B65Cgt9w9k9t8anZLXRyRx59LsQuleUOfPKoZ7CWrWr3qco7pxGU8ncKdEB4HnDVJyrRkTNGYVzoX3dsfqq66hXkNbZISp1SfDPY9diL9iOnkF0DlI9xbkJ0GO1q6YD2VUdiYKjZQcWvXZ7UicJCW5cUDzji3XNkA2szIyGklVLeYh39Lm4ROTMYRVZ0vee19Tf3KQvo9G8z0zb7ImnDfidD5xtiag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vRNrOjRzH+p+vR5qGxvK+DfrbcxqF7sGm8KJMpyIBfM=; b=JxtiPr8rDPZPOL+Ke+DSqQ+IC1U4oQIdodxIRPcIGyzWfE4rqQm89X9eRj4vn/FpGMhQKcKkY3gJcS1fFufnZBBvD2fLJq+d/wfdks1ei1i+sj2n2sne2Xgv8h25F/HA4Y9ISunbwn+HxS9a9BP0uws9vFBdjhgew3q/tFGgSQY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 0/3] vPCI capabilities filtering Date: Thu, 10 Aug 2023 15:12:56 -0400 Message-ID: <20230810191312.644235-1-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD2:EE_|BL1PR12MB5286:EE_ X-MS-Office365-Filtering-Correlation-Id: 9829e620-2ad0-482b-cbd6-08db99d5df6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RYw01VGg91O9AVltpsTgXafe/iNMRnV/tz9nKuMR0ul4nMqzOobfHBKO/2JCD/Sgx027wLjTq2ecZlrq9aUcNZ7Rh/PUw2VCGKBYwjWAUAfjMUu/fTkcn2y8sEBmvONKpuCzuhRQLPxsnLDeAWU+72TyxvzAyXtPJxn/sZRg8cNtW4zgOgiKL4VdFa1yX1/sbClPsDh59DCZ4QVTuWU76LVI4L4jRb4sOhd79eK9MerA//oGyLg/2BB2vqhVXbkZxTMWmrUikkIdFDvbxlsn0yJKItYBcGmx43Xsg18a6vdpouTspbYyE/rzA+K+xmpJUnCQhlksrrtFC0f7o1CotQe9QAygwE763FKWxXx/LdTGWJn3VuiI/E/Ou4JXx87R7Uut8FizGuw2ZtKV7594GgFXFDzls7vb9U2cDcRXm0Rz6Sqh5KkCL9gmhItBMhZrNbEiZYIWtxNVq1ystBM6Ghzj7WGnsfo+hVK1lyAHMjAokQkBkOzLeJmbBXA4aFrwH1Z40H5TDs8CYP2RgxEOcGFGbRaGl6msbO3ippYo8fv9bB79HOeduZ2Isus/YdB9CClAG78b3T51scHAUeaot2OlFrkb/7JkSIpSF0iC2s32WvdlofqvpWEfLIP5SN1R7DK4pbzr2kDd10uyjxCz9wA4R/xdMtkVGz4LTUmubaAqqddscIVON6CuRL/fK0VU4Yby8Y7fOQpSFxgLPP4OlRao8wCIEhW+DyOmCD2BF6nq1So4I4srZFEpQwZ2XhQ47mo8hhrLqrwYFn0Inzgcfw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(82310400008)(1800799006)(186006)(451199021)(36840700001)(40470700004)(46966006)(478600001)(54906003)(81166007)(356005)(2616005)(70586007)(70206006)(336012)(6916009)(82740400003)(316002)(41300700001)(36756003)(6666004)(8936002)(8676002)(36860700001)(44832011)(4326008)(5660300002)(66899021)(40480700001)(83380400001)(1076003)(26005)(2906002)(966005)(47076005)(40460700003)(426003)(86362001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 19:13:25.7561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9829e620-2ad0-482b-cbd6-08db99d5df6d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5286 This small series enables vPCI to filter which PCI capabilites we expose to a domU. This series adds vPCI register handlers within xen/drivers/vpci/header.c:init_bars(), along with some supporting functions. Note there are minor rebase conflicts with the in-progress vPCI series [1]. These conflicts fall into the category of functions and code being added adjacent to one another, so are easily resolved. I did not identify any dependency on the vPCI locking work, and the two series deal with different aspects of emulating the PCI header. Future work may involve adding handlers for more registers in the vPCI header, such as STATUS, VID/DID, etc. [1] https://lists.xenproject.org/archives/html/xen-devel/2023-07/msg01281.html Stewart Hildebrand (3): xen/vpci: add vpci_hw_read8 helper xen/vpci: add vpci_read_val helper xen/vpci: header: filter PCI capabilities xen/drivers/vpci/header.c | 78 +++++++++++++++++++++++++++++++++++++++ xen/drivers/vpci/vpci.c | 12 ++++++ xen/include/xen/vpci.h | 5 +++ 3 files changed, 95 insertions(+) base-commit: b70ffd23865e6c320fe2e8931f0d0366d7e03cac -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 19:13:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 19:13:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582174.911794 (Exim 4.92) (envelope-from ) id 1qUB6Z-0003vI-V8; Thu, 10 Aug 2023 19:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582174.911794; Thu, 10 Aug 2023 19:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6Z-0003vB-QG; Thu, 10 Aug 2023 19:13:55 +0000 Received: by outflank-mailman (input) for mailman id 582174; Thu, 10 Aug 2023 19:13:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6Y-0003Ze-Ey for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 19:13:54 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2062b.outbound.protection.outlook.com [2a01:111:f400:7eab::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a50274b-37b2-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 21:13:52 +0200 (CEST) Received: from MWH0EPF00056D05.namprd21.prod.outlook.com (2603:10b6:30f:fff2:0:1:0:e) by PH7PR12MB6933.namprd12.prod.outlook.com (2603:10b6:510:1b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Thu, 10 Aug 2023 19:13:47 +0000 Received: from CO1PEPF000042A9.namprd03.prod.outlook.com (2a01:111:f403:c903::) by MWH0EPF00056D05.outlook.office365.com (2603:1036:d20::b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.7 via Frontend Transport; Thu, 10 Aug 2023 19:13:46 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042A9.mail.protection.outlook.com (10.167.243.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Thu, 10 Aug 2023 19:13:45 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 14:13:45 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 12:13:44 -0700 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 14:13:44 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a50274b-37b2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IZuR4tI8Nijs/tOE+ybOzOjq2TcLMt5dFyufMIaVDsqT+vhoFl9FOUy5rOXmgOmnqMmmBb7QHEIujizcWaLkUaSKRLy48WaV7O9XpoO9W4+zCvtQrWLovql/igKbBzlnjpwZbwt24D9ccnctd7FAbz2TzlcSh+IaP//H+hxJAs3gy3m7fDK8ZWbiyTym1ljBgOee6C+Axv2FQkqIPMG5vAUThzD5yT76B1mqU2bVMWzWm9kPEBFiP6Ok4VEBfxsJaHwCK1otCWttOvqh6HUnr3SdJnGHoCVh10vd6HqirdVgnOrge2oLdGZZB6OS4rP6d3aHBO81FLa1xEaCnbNxag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J4yLLAlz56YDsP4hB+WtRJV0qGSq8/4CwsqKhUFrp3Q=; b=YNGAuAnQrULH4FTTRGU61MilkXcsE04SQ6Gn4xeeftIWWDvTgSJZdshV+VdQKnJzfWtT+r6cxGNVkDYeyXFAiu1Zss5GcDUl4rc56+E41MxbL65KJ/sgcDBO+YMzr2qsK6YawM9gTqXiDkTbXoCPPSUvWgRD37ESvJhWE1r2jmqbGyKtIABpbwrfc7/eZldLn9cQuzmo1sT1mabAeSjgnuRy5o2ONOwzzohfMjRxtDw0aHaZ4NRP/QWUFj58J2TKW5iMmTbzeUquW8bG0GsEZ+xgSuz/sICq3b19Hj2ZWYd/oZzoYhjgd6WXGN13/Kriw6IAuCikgj7lUeI42F+C/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J4yLLAlz56YDsP4hB+WtRJV0qGSq8/4CwsqKhUFrp3Q=; b=NCZSOCDOT/dBQme0CHOfIY+P/+e/SQbKYbJUA76uG72KOLDguMt4/BlkXu5cmflp9iX+OUi6YZJ3RyJzb13G6b9Hp5DnE7wLz4jYKq1D8QD1z9n3EZRAriIYnlzsWSIrQvuC3nX0jR5TYYNYEm1M0GL/Xfq5Tl4259YSvF77AXA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 1/3] xen/vpci: add vpci_hw_read8 helper Date: Thu, 10 Aug 2023 15:12:57 -0400 Message-ID: <20230810191312.644235-2-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230810191312.644235-1-stewart.hildebrand@amd.com> References: <20230810191312.644235-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A9:EE_|PH7PR12MB6933:EE_ X-MS-Office365-Filtering-Correlation-Id: c7c12e43-9aae-4bfa-61f6-08db99d5eb82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L+oMc+vEZQZaVHMNCp8Ql0UGWG4HGD5K/l47rqOXiiJbDRlbolOIiHVJwpPyPMS+1jtk2kjiwvJnW/GYGkCAxrg7cDTe/dhH9LrgGmO4RPat04bY61lJtDfGdEoG9Ss7OWUL0fJfkphve9WfBPv/LBLpNAy3w3N9sl2Q1ZyZ9VazSSvSuBUU44nJqBQoz0ChS83L31HRQubQt2tq+qN16ZUfQj4LrtSrPJOwXgYhX6rEeyV9HGT/zYwTJVTc+lVrFJnTl5aDyEXLWaB6bfsOvqtnQG+VqodV0GlSvxlXXwiyQsPPD5ZoqqvAJd91ATx3PjNalCH1OEXfHAd2CFTe0sruBi2ocO1i1GIVDIZPWwbkuJQEKsMb0hKVx6RJEQ5Yz6pFE27eGabHE72nruln8GKQDwRMLzHcl9BZWFXGTqYylcAStnnblbnBHBHqFTQmyJ23OxOGjJ2Kl6T5M7DPZlF+/sLTOXg/7a3Lb7eaI2LSc0fdq1E2MWSzHE7i7tMg4lIO/z6ed7hz+tkfPjD1vF4zdVxwkBKo3S6qALsJnHjq9j8Dw9Yn5bLZRCcArQzFiA2MaMuoLCvvk0pCvQogqglDcVwlqsyo7b993CVsS/qPtRsP52omN8/j2Kt9nS4CVaNjKijwFYjajDrXjtUrGIRUjsHrbY43um44EbR56SQpYkkexVMwgIdWBu/fb/TbfNg1Y+p5F88op3wPJ5ak1ZzU/7eedp6nO9NQUuIGanuchxcIcJt70fouYssgRAsWIBVNB3s+xKdi+QzqFmilvQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(186006)(82310400008)(451199021)(1800799006)(40470700004)(36840700001)(46966006)(1076003)(36756003)(2616005)(336012)(26005)(6666004)(81166007)(82740400003)(478600001)(356005)(70206006)(70586007)(4326008)(316002)(41300700001)(54906003)(86362001)(8676002)(8936002)(5660300002)(44832011)(426003)(40460700003)(2906002)(6916009)(36860700001)(47076005)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 19:13:45.9769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7c12e43-9aae-4bfa-61f6-08db99d5eb82 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A9.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6933 This will be used in a subsequent patch. Signed-off-by: Stewart Hildebrand --- xen/drivers/vpci/vpci.c | 6 ++++++ xen/include/xen/vpci.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index d73fa7630237..acadba1fd6c5 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -133,6 +133,12 @@ static void cf_check vpci_ignored_write( { } +uint32_t cf_check vpci_hw_read8( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + return pci_conf_read8(pdev->sbdf, reg); +} + uint32_t cf_check vpci_hw_read16( const struct pci_dev *pdev, unsigned int reg, void *data) { diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 0b8a2a3c745b..ee7a8fcdee83 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -46,6 +46,8 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size, uint32_t data); /* Passthrough handlers. */ +uint32_t cf_check vpci_hw_read8( + const struct pci_dev *pdev, unsigned int reg, void *data); uint32_t cf_check vpci_hw_read16( const struct pci_dev *pdev, unsigned int reg, void *data); uint32_t cf_check vpci_hw_read32( -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 19:14:06 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 19:14:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582175.911803 (Exim 4.92) (envelope-from ) id 1qUB6k-0004K7-9w; Thu, 10 Aug 2023 19:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582175.911803; Thu, 10 Aug 2023 19:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6k-0004Jv-6x; Thu, 10 Aug 2023 19:14:06 +0000 Received: by outflank-mailman (input) for mailman id 582175; Thu, 10 Aug 2023 19:14:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6i-0003Ze-Rx for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 19:14:04 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20601.outbound.protection.outlook.com [2a01:111:f400:7eae::601]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10c000ca-37b2-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 21:14:03 +0200 (CEST) Received: from CY5PR14CA0014.namprd14.prod.outlook.com (2603:10b6:930:2::27) by SJ0PR12MB6829.namprd12.prod.outlook.com (2603:10b6:a03:47b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 19:13:59 +0000 Received: from CY4PEPF0000EDD6.namprd03.prod.outlook.com (2603:10b6:930:2:cafe::72) by CY5PR14CA0014.outlook.office365.com (2603:10b6:930:2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 19:13:59 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EDD6.mail.protection.outlook.com (10.167.241.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 19:13:58 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 14:13:58 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 14:13:57 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 14:13:57 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10c000ca-37b2-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Frt7eqpDRVjpO63Xw4tuM2/DRqg33XW+xaMuVkGL4wIGH0FwxTqK2DpEA8ezB+PABXWn6LxcrO9WGOxUXIOgEVt7Vo5MkdS8lSM+XLtrBKCOWAGIo3iyN5eM0NrV3LmG/TYYceXrK+qCXOXPfggcozy5uWWnB8uM+m8dO5+XiPCyWyfCgNjl3upVBOuk9kKkTn0/wA/VmmnkouMfu4aF2c3H0n8gAsBage2pHJmQRBqMDfxmpeF/WEkufuZ/QDlnO+Azu0s6l23QRa2o+YM8+2B8gxvOyQzjb1HcPDGf1ogY8THYfgl3/3+tWkrF/xlIXzQdDtDDBh1LSYCAQHEcAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PlSGpBPqcY633oL1I0uwX+30drJWk9gY6gx+J9uhOBw=; b=j0m5y0FLl5ctbfLv1bfq8Wz/6DONkZNTmlQe1QdIoSPvv+0Mg0lfAjayXo6XZc0JVGGwUSXRnw9qKVekI2I0/cuViQgx4YnAOhSAG2/uIxs+kDZvtTIxOUgKF68aR+c/BZ4uJKWx3vN/CYAQ2837ox+36eg4Y3ism95RK7ahJsIeQ3M2vkag8NMlJi93q1YUKfKuNZTrBPb4MA/raadasyEbu/vlYhByOuig58+Q3VS2Pr1mXQnmc9Ws2GZbUt1q2ZsQbr3Qao1NT7ubkfkhaYdoiHUkSryFlLe/STO7pXJjyy/+Td8e4l2nf8G4m17STlgFUczBIy0GBOZX8Rq+Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PlSGpBPqcY633oL1I0uwX+30drJWk9gY6gx+J9uhOBw=; b=IWW7Yh/Qe+/0zo5VxuQER+eBriR0XXoqvVgS39BwI3uqmAPP/AIDYR0p376mK8zCPSzcrpMPRq+Vx9nEeuX91CWsQCYJSWZbAyMANCQujgoeQkxxz5chnvjRsiIN61M+mnxyl6CP0p+SwmWOGBIIMMGKysqTOEOLBUJW/wsYEpg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 2/3] xen/vpci: add vpci_read_val helper Date: Thu, 10 Aug 2023 15:12:58 -0400 Message-ID: <20230810191312.644235-3-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230810191312.644235-1-stewart.hildebrand@amd.com> References: <20230810191312.644235-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD6:EE_|SJ0PR12MB6829:EE_ X-MS-Office365-Filtering-Correlation-Id: e91fbfb2-1328-4f37-134a-08db99d5f323 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UX7+T/dui+uch7n0WnTb5dxfauOWobY1HESlu+E6usctLE2fSkOqh2t1YbSyUkhfx9EdITwo2OwsbqJ11a1i8RJMAkTIv15ywTEwtICxioCKY1/6aDm2T79MSi6SvzfjDu1ATlMF0XTzkj4T3h2kI4z3MukUX2Mft0UrK7MjVlY+iOKl47UJ7DK0lcQotU/38nZR2Cr+d60IgIaXE8thxtQf/IHua3nk95qzTHOdeG3jowR+3azzH5XAzpxboBC3WcqBqYXO2XKLJ8lpUKnphzefHsgC4zdzfcb30buY1MK41VOeRhEPDODw1psPIWRs7LAwwcuoO6jZjvjnlI6ekCIZ6v6YE/ZjFYtDWqaq0BIQujrq1jteFkcGbNZdDVfUeuOb0NAb3rfHJUrfAGEzNdzCN2X3oZGwaYUbVqso9ZbEcgokSlesZTFDIh0F9/OfzGb0mRWbw0JESsIVcG6IOnhHAvRk2TYyWZI6yfcT5lHsTV/OzZO106VW7L0AqSSDFARbR9zE1MtcCyrNUa993kgsfE9cuJ4AtaDC/MUF8f/Ra9Ae6vIagE4taISxkTsBrlENE2oEOB9EdylQt/U6tKBhFLuIi8UUDy/kMWGNfzQQ4n/fL/ANlxlqFbRt0Tm/KkVlPUVJGgTmaPUhIf1X5n0/c8AcLpu2i2TrtqKe/I2p+KOeO9D3llc5jpFFJKBkLwJxFAzIFFGJJ8H/4UEBbSFqurYj5mU8hNiif3Au70Txrqcr2oUNY7Vd3iujWecsyUBvd8gWOpu8UGfW5EFSpA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(186006)(82310400008)(1800799006)(451199021)(36840700001)(46966006)(40470700004)(478600001)(70206006)(70586007)(4326008)(6916009)(5660300002)(316002)(54906003)(41300700001)(40460700003)(8936002)(8676002)(26005)(1076003)(86362001)(82740400003)(336012)(40480700001)(44832011)(36756003)(47076005)(36860700001)(81166007)(356005)(2906002)(2616005)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 19:13:58.8209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e91fbfb2-1328-4f37-134a-08db99d5f323 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6829 Introduce a vPCI read helper function that returns a fixed value. This may be used for RAZ registers, or registers whose value doesn't change. This helper will be used in a subsequent patch. Signed-off-by: Stewart Hildebrand --- RFC: I'm not a fan of the (uintptr_t) cast, but without it I wasn't sure how to pass a value without allocating more memory (either with an xalloc function of sorts, or by adding a new element in struct vpci_register and changing the interface). Plus, in the current state, to pass a value to vpci_add_register(), it may be necessary to cast twice: (void *)(uintptr_t)myval. See next patch. Perhaps a new allocation is worth it to avoid the casts? Or maybe I'm being overly pedantic and the casts are okay? --- xen/drivers/vpci/vpci.c | 6 ++++++ xen/include/xen/vpci.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index acadba1fd6c5..4a96aa50494d 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -133,6 +133,12 @@ static void cf_check vpci_ignored_write( { } +uint32_t cf_check vpci_read_val( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + return (uintptr_t)data; +} + uint32_t cf_check vpci_hw_read8( const struct pci_dev *pdev, unsigned int reg, void *data) { diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index ee7a8fcdee83..17fd252746ec 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -45,6 +45,9 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int size); void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int size, uint32_t data); +uint32_t cf_check vpci_read_val( + const struct pci_dev *pdev, unsigned int reg, void *data); + /* Passthrough handlers. */ uint32_t cf_check vpci_hw_read8( const struct pci_dev *pdev, unsigned int reg, void *data); -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 19:14:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 19:14:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582180.911813 (Exim 4.92) (envelope-from ) id 1qUB6y-0004v4-JA; Thu, 10 Aug 2023 19:14:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582180.911813; Thu, 10 Aug 2023 19:14:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6y-0004ux-G7; Thu, 10 Aug 2023 19:14:20 +0000 Received: by outflank-mailman (input) for mailman id 582180; Thu, 10 Aug 2023 19:14:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUB6x-0004qN-5X for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 19:14:19 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20606.outbound.protection.outlook.com [2a01:111:f400:fe5b::606]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1987dcad-37b2-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 21:14:17 +0200 (CEST) Received: from CH0PR03CA0209.namprd03.prod.outlook.com (2603:10b6:610:e4::34) by CH3PR12MB9021.namprd12.prod.outlook.com (2603:10b6:610:173::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 19:14:10 +0000 Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:610:e4:cafe::79) by CH0PR03CA0209.outlook.office365.com (2603:10b6:610:e4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 19:14:10 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Thu, 10 Aug 2023 19:14:09 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 14:14:09 -0500 Received: from ubuntu.mshome.net (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 14:14:08 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1987dcad-37b2-11ee-b284-6b7b168915f2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EuvnqIb/Lo+1HHUQsz+GLNW7b3fYKuThTtzLoi6MSmleFvcriK5cc769dD2rY+Q563RvdXO6tjpeU1A7pdwWnzCiSNtGxJnSqGO0I5lMJpA3JV/0lNYxIVQ2yFZ147s8wb/t4rhFs9SdoaYG64+ddPoUZeTb71IuAZtLzpTtkroWGXi31ygJkB3YqP3YJaIpF2XJ/G8YqrDk2yZdrtsrIJlq0S3piPu+mO6NxyDf/J70tAu5lrxxVM8nQy8jkZ5TUbMxMjE/NlLlcaygtTZSkxCnocoQ+tCgS2Nx5fFCLF5hneINw49KPReBus1k4UL0b9avK2GX86+CcST2b0TCHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lytXEfn42x+yZhPe84LRwE9cDWxa0qd6RBGQUU59Ly0=; b=g4dRTSGvgsMDqTRw0FGBQGlxzce8Gje880i5DUj/oLLOH64+LurECP3u6ebezPzuKcHur5jeRYV7+HF7qrtqa6fB4dyzO2Iiz+W2U8l5C14iQN1bBP57rqrWBbqTWShoGtuUJ40eCWT02xUFrIiTQZKcxSREDuuR7FzqhjGaa/P0yMwvX5xA0rwJcJGGSTG8PRYB4cIl82d3YmVC3/PvbK0Tr5mKludxyTjUVxpT+HTuF5nb7QfmXzghxqq9/NTCGvPD2dejm22AHynmPPeUVdKHG1A7q+8nYLIg9cnHpJvgwKUGRHooTH4jJsd0mH05/3N5LZqOUGelgWCHcF7aVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lytXEfn42x+yZhPe84LRwE9cDWxa0qd6RBGQUU59Ly0=; b=zCkQI4fKYKW9VVsFhh/GW4nMeSgOjMrP28lZArTepRyxoYYT4vE0rWunevw8vwlLesMuLdY7PmdADbNAUd6viT9PAwyMk3fbDTjDX1vo05wTaIWOYZvzkqNFhzCXynwKScvuvvWXAys3Y08zxbP8cbTfU8o1/Oco2l9XuaRkueM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C From: Stewart Hildebrand To: CC: Stewart Hildebrand , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 3/3] xen/vpci: header: filter PCI capabilities Date: Thu, 10 Aug 2023 15:12:59 -0400 Message-ID: <20230810191312.644235-4-stewart.hildebrand@amd.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230810191312.644235-1-stewart.hildebrand@amd.com> References: <20230810191312.644235-1-stewart.hildebrand@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|CH3PR12MB9021:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e943005-87f0-423d-d03a-08db99d5f9cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EwROm0Lbzsr56+VaUvR7rQPESxbMiOqRULxVl7GoRBE2pD61dGhhYSAeUNKWjN7WH7qDndzcU0Sm/RakmAYVW4ox3rndqLs39STuYsxwT4BpIAkaHPqNaVY8wjEgS7RK/vWzEBBuETb/HZAVMayeE/M0VsnC/GX7+j/xXf0m6BxkGHWb+iLgOzdBDx2uFSzBevvA6PbMuBDteOkrzecANCs4z7eOdWgvtjSfPcHFds9yRK59oRjga8EowIwlWU/Gz+HU/IEtwAitjuWLXaTuh4t1vsrZndSQeYRRKXmqSE9LmHOgMQkZ8on/b6xLX5kHEiIvgIAdRm0ic6FCvDHlOz2005D0Lyx/exP0qnlSQI7LhBUPYlkAwuWpLAvmSK/C/TjbqlsXgYpLK0/JgO6/oA18C3rbzJtkZfE+NG9n1bcnP8jwnWUODJfvqwplaCd2cBXaJHFBvAppW/9XsU2Y/ACD4q8r5pyRlaOcAOSWGxvfuiih/141XXsTvUemFM/ZLpaFpcOHM+yoXWLPKF89wJ5INJtyfJ5IVhYPplMdvPrkiUAa+YERi/wces660K4GYNy9VB5Pd0aL6KR6GBtt0biqiTQLtm6HFQ1ZlQnRJzpwMBireaV+SZbj6DObeDguBSG9RZisHy2iMbbgmzUW9PyLdS+qf/FqFsIfvee+TSqh3j2l34gmDTM17Gy16jYpClLsxHfswcvmxShyvX1ud0H2Kf+dxv/zR5e0lLZvCmOesSbb7X3XvJSVv1AFluHpovcmwfajrMMTX/33XJQXow== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(136003)(396003)(1800799006)(451199021)(82310400008)(186006)(36840700001)(40470700004)(46966006)(8676002)(8936002)(1076003)(26005)(41300700001)(40460700003)(36860700001)(36756003)(47076005)(426003)(2906002)(356005)(2616005)(81166007)(86362001)(82740400003)(44832011)(336012)(6916009)(70206006)(70586007)(4326008)(54906003)(478600001)(5660300002)(40480700001)(6666004)(316002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 19:14:09.9684 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e943005-87f0-423d-d03a-08db99d5f9cc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9021 Xen vPCI only supports virtualizing the MSI and MSI-X capabilities, so all other PCI capabilities should be hidden from a domU for now. We parse the physical PCI capabilities linked list and add vPCI register handlers for the next elements, inserting our own next value, thus presenting a modified linked list to the domU. Signed-off-by: Stewart Hildebrand --- If there are no capabilities to be exposed to the guest, a future status register handler likely would want to mask the PCI_STATUS_CAP_LIST bit. I'm thinking we could track this in struct vpci_header as follows: vpci.h: struct vpci_header { ... + bool mask_cap_list : 1; } header; header.c:init_bars(): rc = vpci_add_register(pdev->vpci, vpci_read_val, NULL, PCI_CAPABILITY_LIST, 1, (void *)(uintptr_t)next); if ( rc ) return rc; + if ( !next ) + header->mask_cap_list = true; + for ( ttl = 48; ttl > 0; ttl-- ) { uint8_t pos; --- xen/drivers/vpci/header.c | 78 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 60f7049e3498..cb1304fa1eed 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -513,6 +513,36 @@ static void cf_check rom_write( rom->addr = val & PCI_ROM_ADDRESS_MASK; } +static uint8_t vpci_find_next_cap(pci_sbdf_t sbdf, uint8_t pos) +{ + uint8_t id; + int ttl; + + if ( pos < 0x40 ) + pos = pci_conf_read8(sbdf, PCI_CAPABILITY_LIST); + else + pos = pci_conf_read8(sbdf, pos + PCI_CAP_LIST_NEXT); + + for ( ttl = 48; ttl > 0; ttl-- ) + { + if ( pos < 0x40 ) + break; + + pos &= ~3; + id = pci_conf_read8(sbdf, pos + PCI_CAP_LIST_ID); + + if ( id == 0xff ) + break; + + if ( id == PCI_CAP_ID_MSI || + id == PCI_CAP_ID_MSIX ) + return pos; + + pos = pci_conf_read8(sbdf, pos + PCI_CAP_LIST_NEXT); + } + return 0; +} + static int cf_check init_bars(struct pci_dev *pdev) { uint16_t cmd; @@ -544,6 +574,54 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( rc ) return rc; + if ( !is_hardware_domain(pdev->domain) ) + { + if ( (pci_conf_read16(pdev->sbdf, PCI_STATUS) & PCI_STATUS_CAP_LIST) + == 0 ) + { + /* RAZ/WI */ + rc = vpci_add_register(pdev->vpci, vpci_read_val, NULL, + PCI_CAPABILITY_LIST, 1, NULL); + if ( rc ) + return rc; + } + else + { + /* Only expose capabilities to the guest that vPCI can handle. */ + uint8_t next, ttl; + + next = vpci_find_next_cap(pdev->sbdf, PCI_CAPABILITY_LIST); + + rc = vpci_add_register(pdev->vpci, vpci_read_val, NULL, + PCI_CAPABILITY_LIST, 1, + (void *)(uintptr_t)next); + if ( rc ) + return rc; + + for ( ttl = 48; ttl > 0; ttl-- ) + { + uint8_t pos; + + if ( !next ) + break; + + pos = next; + next = vpci_find_next_cap(pdev->sbdf, pos); + + rc = vpci_add_register(pdev->vpci, vpci_hw_read8, NULL, + pos + PCI_CAP_LIST_ID, 1, NULL); + if ( rc ) + return rc; + + rc = vpci_add_register(pdev->vpci, vpci_read_val, NULL, + pos + PCI_CAP_LIST_NEXT, 1, + (void *)(uintptr_t)next); + if ( rc ) + return rc; + } + } + } + if ( pdev->ignore_bars ) return 0; -- 2.41.0 From xen-devel-bounces@lists.xenproject.org Thu Aug 10 20:03:05 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 20:03:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582200.911823 (Exim 4.92) (envelope-from ) id 1qUBrn-0002KT-9d; Thu, 10 Aug 2023 20:02:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582200.911823; Thu, 10 Aug 2023 20:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUBrn-0002KM-6D; Thu, 10 Aug 2023 20:02:43 +0000 Received: by outflank-mailman (input) for mailman id 582200; Thu, 10 Aug 2023 20:02:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUBrl-0002KG-6C for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 20:02:41 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db350e38-37b8-11ee-8613-37d641c3527e; Thu, 10 Aug 2023 22:02:38 +0200 (CEST) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5231410ab27so1615439a12.0 for ; Thu, 10 Aug 2023 13:02:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db350e38-37b8-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691697758; x=1692302558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+rf/JiRgTxAKa0argPmibUk4LC5slrYRdDGlyKPWfyM=; b=RfcJMnLGNXCgeuU/RIOYkruNpkC9cCf7Ggs74g0LI/34ffLGGNw0TfIeCkodzY5KRt il0NHS7wiqt7dINLgpdPycj9hHNd1poEBKtbLAnzBPefO5S6xr+lhTvu2QHOmZtDPsrY LhTI8HO8ahHKZPxbfHWJgscwBGK2ZUNgU3ujkbhTh9s2aoGYlltqSPlhY3xcX1IAu/ke lgu5ZilAlSIKqtmJ4u0IwiEzU8+LF6m6mvvecgMoFZG3MdzC9Vizh+Cl/gbE+InShdIa PBZ80Wm/gMlZxakEc/1xxq6D+av8i1ZS4q+P2DDJp///HZFn109elqua5vLyDYeJQfDC jv5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691697758; x=1692302558; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+rf/JiRgTxAKa0argPmibUk4LC5slrYRdDGlyKPWfyM=; b=degovSdjlZ+JshbA4DB7ciktvY6TQYeUApyACfYMhNwFkToEDWcrOQB35OCOi7GDkQ mQf04JTzib3+dKLRENpLUqYdxPII6skGeU6b32Nds5htnlfrwk8qMFGt9/81xbwZTPsg OF0YBGAndz9ZWlKQnrB4OvLNPORqZy1fGnqJRP+7l56MzpOvp/FUZkM68FuPz/FudfVi XGzfdkLj3Fpbmmok0xw+zgtnhuneAYabpEdJT92WXNQHzZwNbydwPLV0RlS3lARyjeCm XeLVW/RNPStR6nTWdt7SK2QyOuI7unrLcbLJVPIU6rjrRcbfHMStuO63i6tsxkZPeYG4 1axg== X-Gm-Message-State: AOJu0YxqZlk+9qIN8cUXpKTcVsjVYH3MtVvRduK136yaRqYTCLpfQq1C C/o/Wv/LEEaztHchKI3LB1YymrsYtFQB/Do48Ao= X-Google-Smtp-Source: AGHT+IGxDAgS9ADpWY5Il8UlXPbJEJjVg9k5fap6/vNBtIeu1wqFr0BE5YNviKjm6yQVQsSk0HTZeXRol17NgbYtheQ= X-Received: by 2002:aa7:d7d5:0:b0:522:bca7:2a20 with SMTP id e21-20020aa7d7d5000000b00522bca72a20mr16309eds.17.1691697757906; Thu, 10 Aug 2023 13:02:37 -0700 (PDT) MIME-Version: 1.0 References: <20230809103305.30561-1-julien@xen.org> <20230809103305.30561-3-julien@xen.org> In-Reply-To: <20230809103305.30561-3-julien@xen.org> From: Jason Andryuk Date: Thu, 10 Aug 2023 16:02:26 -0400 Message-ID: Subject: Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 9, 2023 at 6:34=E2=80=AFAM Julien Grall wrote: > > From: Julien Grall > > Currently, libxl will grant IOMEM, I/O port and IRQ permissions when > a PCI is attached (see pci_add_dm_done()) for all domain types. However, > the permissions are only revoked for non-HVM domain (see do_pci_remove())= . > > This means that HVM domains will be left with extra permissions. While > this look bad on the paper, the IRQ permissions should be revoked > when the Device Model call xc_physdev_unmap_pirq() and such domain > cannot directly mapped I/O port and IOMEM regions. Instead, this has to > be done by a Device Model. > > The Device Model can only run in dom0 or PV stubdomain (upstream libxl > doesn't have support for HVM/PVH stubdomain). > > For PV/PVH stubdomain, the permission are properly revoked, so there is > no security concern. > > This leaves dom0. There are two cases: > 1) Privileged: Anyone gaining access to the Device Model would already > have large control on the host. > 2) Deprivileged: PCI passthrough require PHYSDEV operations which > are not accessible when the Device Model is restricted. > > So overall, it is believed that the extra permissions cannot be exploited= . > > Rework the code so the permissions are all removed for HVM domains. > This needs to happen after the QEMU has detached the device. So > the revocation is now moved in a separate function which is called > from pci_remove_detached(). > > Signed-off-by: Julien Grall Reviewed-by: Jason Andryuk With one suggestion below > --- > > TODO: I am getting a bit confused with the async work in libxl. I am > not entirely sure whether pci_remove_detached() is the correct place > to revoke. I think the location is fine. > TODO: For HVM, we are now getting the following error on detach: > libxl: error: libxl_pci.c:2009:pci_revoke_permissions: Domain 3:xc_physde= v_unmap_pirq irq=3D23: Invalid argument > > This is because the IRQ was unmapped by QEMU. It doesn't feel > right to skip the call. So maybe we can ignore the error? Sounds reasonable. Would be better if we could clearly differentiate between QEMU already unmapped and some other EINVAL error. > --- > tools/libs/light/libxl_pci.c | 142 ++++++++++++++++++++--------------- > 1 file changed, 80 insertions(+), 62 deletions(-) > > diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c > index 7f5f170e6eb0..f5a4b88eb2c0 100644 > --- a/tools/libs/light/libxl_pci.c > +++ b/tools/libs/light/libxl_pci.c > @@ -1943,6 +1943,79 @@ static void pci_remove_stubdom_done(libxl__egc *eg= c, > static void pci_remove_done(libxl__egc *egc, > pci_remove_state *prs, int rc); > > +static void pci_revoke_permissions(libxl__egc *egc, pci_remove_state *pr= s) > +{ > + STATE_AO_GC(prs->aodev->ao); > + libxl_ctx *ctx =3D libxl__gc_owner(gc); > + const libxl_device_pci *pci =3D &prs->pci; > + const char *sysfs_path; > + uint32_t domid =3D prs->domid; > + FILE *f; > + unsigned int start =3D 0, end =3D 0, flags =3D 0, size =3D 0; These variables ... > + int irq =3D 0; > + int i, rc; > + > + sysfs_path =3D GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", > + pci->domain, pci->bus, pci->dev, pci->func); > + > + f =3D fopen(sysfs_path, "r"); > + if (f =3D=3D NULL) { > + LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); > + goto skip_bar; > + } > + > + for (i =3D 0; i < PROC_PCI_NUM_RESOURCES; i++) { ... could move into the loop here. > + if (fscanf(f, "0x%x 0x%x 0x%x\n", &start, &end, &flags) !=3D 3) > + continue; > + size =3D end - start + 1; Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu Aug 10 20:03:16 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 20:03:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582201.911832 (Exim 4.92) (envelope-from ) id 1qUBsK-0002ir-I8; Thu, 10 Aug 2023 20:03:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582201.911832; Thu, 10 Aug 2023 20:03:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUBsK-0002ik-FJ; Thu, 10 Aug 2023 20:03:16 +0000 Received: by outflank-mailman (input) for mailman id 582201; Thu, 10 Aug 2023 20:03:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUBsI-0002fI-JM for xen-devel@lists.xenproject.org; Thu, 10 Aug 2023 20:03:14 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed687588-37b8-11ee-b284-6b7b168915f2; Thu, 10 Aug 2023 22:03:09 +0200 (CEST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-523ba00a62aso675597a12.2 for ; Thu, 10 Aug 2023 13:03:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed687588-37b8-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691697789; x=1692302589; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=czNDBwm2jJDIh7l7tzB+aDs6zI8rnPbTT69UXuSdg70=; b=DsjuaQgtHv/sbA0A5k3q0NLUiPCiGfoNRRcDxNRjzdBQR4G5HzQnR+s1ny84vDDr0k XD7HQaOYMvhokuLhqDexs5UYamZ+N/PTYYLPg155BWN+YyXYxKD3yecG7VVtRUCh6Tja 2m7z/qMnN5zA/liXwYKsT01QfayfKQZ1qIJi4Hd0mkIB0fTnwA/ehltopubrV+ojffaU jD+C/bjEFnQMPlPAY4edJ4ZET87LavMNz61q+USUD/20SP59qICWzofDYpCnxA56rFUe AJkYgDedE6kEBbLuu9qXmm7vW0NdJuUgPn6tUpgUoZfvX91N8oE4tV/AeIkFtiiEonfY hS+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691697789; x=1692302589; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=czNDBwm2jJDIh7l7tzB+aDs6zI8rnPbTT69UXuSdg70=; b=kB3mLSN1bTuuG/ktiF7I9YjAR1XNSCTAa7uhAVoMj2+i/b270GM+9c+/OMWfRpiFwf wCDgsYnWOzzkK9+04VJgHyZxPxP+zVsb3ZEofbVOsN2eiPlRcxXmrAkajsGxnD08ZR9y U/l+3313M3uiicY3FR924W8AmYJ8N/2dGUOVGp5Xq7tba8GC60Ciq1X3yq4NPm5YY4CK vRJjNKeTni43qhHY18LZesHjb70oBRc+7k9FhLWRU+rDE8hWD/v9MrJ3M0fyFa3CgXZ1 kaaSzdvt50G2rY2tf1wlKg51RD31Y1LF8Ct67xRt43p7n2V/+E2trQAwF0uyLZ2HlJtQ kyTw== X-Gm-Message-State: AOJu0YxUjZQ3TFPUyWANaGveBvElMFbsc8Fag0mQomvEyChLjjtEC6O4 NZjC93SaFsbG/MmyYvJ+V2D3dIwYfhZO7wbzEwCn4hLI X-Google-Smtp-Source: AGHT+IHAhDpGUyha751ei6f8OAsLRHOQyrAzD3Vn6WJyC1O3FGwSx3cINEewdvYVyVYAoXlA1gCwFexQqkYzwJ6mwFs= X-Received: by 2002:aa7:cf0f:0:b0:523:1400:2d7c with SMTP id a15-20020aa7cf0f000000b0052314002d7cmr6090edy.35.1691697788645; Thu, 10 Aug 2023 13:03:08 -0700 (PDT) MIME-Version: 1.0 References: <20230809103305.30561-1-julien@xen.org> <20230809103305.30561-2-julien@xen.org> In-Reply-To: <20230809103305.30561-2-julien@xen.org> From: Jason Andryuk Date: Thu, 10 Aug 2023 16:02:56 -0400 Message-ID: Subject: Re: [PATCH 1/2] tools/libs: light: Remove the variable 'domainid' do_pci_remove() To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 9, 2023 at 6:34=E2=80=AFAM Julien Grall wrote: > > From: Julien Grall > > The function do_pci_remove() has two local variables 'domid' and > 'domainid' containing the same value. > > Looking at the history, until 2cf3b50dcd8b ("libxl_pci: Use > libxl__ao_device with pci_remove") the two variables may have > different value when using a stubdomain. > > As this is not the case now, remove 'domainid'. This will reduce > the confusion between the two variables. > > Note that there are other places in libxl_pci.c which are using > the two confusing names within the same function. They are left > unchanged for now. > > No functional changes intented. > > Signed-off-by: Julien Grall Reviewed-by: Jason Andryuk From xen-devel-bounces@lists.xenproject.org Thu Aug 10 23:13:29 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 10 Aug 2023 23:13:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582215.911842 (Exim 4.92) (envelope-from ) id 1qUEqA-0005SG-5P; Thu, 10 Aug 2023 23:13:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582215.911842; Thu, 10 Aug 2023 23:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUEqA-0005S9-2r; Thu, 10 Aug 2023 23:13:14 +0000 Received: by outflank-mailman (input) for mailman id 582215; Thu, 10 Aug 2023 23:13:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUEq8-0005Rz-Vv; Thu, 10 Aug 2023 23:13:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUEq8-0004u0-Mz; Thu, 10 Aug 2023 23:13:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUEq8-0007K9-8V; Thu, 10 Aug 2023 23:13:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qUEq8-0002Nz-81; Thu, 10 Aug 2023 23:13:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sgrqMzr3VgHAvTLfxEe2H0mBaFJ9OpT4Bfy7CYKUP5Y=; b=CwriW0muebXfxE7ktwIAXVzfz0 alt+LV8T6niFXiiRFJdbMFRGjiFWcIeMlCpOFgR0VEMksFST3gMxd7KnpKcN3TgBMBDhbiPQ31lkg q19fIhxfcw87pv89hg/ASJHdD8mPeP57jW5A1fPqD8LgWOG1GVae8UhLkleZKbv6e6yQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 182247: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=13b9372068660fe4f7023f43081067376582ef3c X-Osstest-Versions-That: linux=6c538e1adbfc696ac4747fb10d63e704344f763d From: osstest service owner Date: Thu, 10 Aug 2023 23:13:12 +0000 flight 182247 linux-linus real [real] flight 182265 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182247/ http://logs.test-lab.xenproject.org/osstest/logs/182265/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 13 guest-start fail REGR. vs. 180278 test-arm64-arm64-xl-vhd 13 guest-start fail REGR. vs. 180278 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-shadow 20 guest-localmigrate/x10 fail pass in 182265-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 182265-retest test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 182265-retest Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 180278 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 180278 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 180278 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 180278 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 180278 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 13b9372068660fe4f7023f43081067376582ef3c baseline version: linux 6c538e1adbfc696ac4747fb10d63e704344f763d Last test of basis 180278 2023-04-16 19:41:46 Z 116 days Failing since 180281 2023-04-17 06:24:36 Z 115 days 207 attempts Testing same since 182247 2023-08-09 08:11:17 Z 1 days 1 attempts ------------------------------------------------------------ 3916 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 659473 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Aug 11 01:54:07 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 01:54:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582223.911853 (Exim 4.92) (envelope-from ) id 1qUHLc-0007fc-JF; Fri, 11 Aug 2023 01:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582223.911853; Fri, 11 Aug 2023 01:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUHLc-0007fG-D3; Fri, 11 Aug 2023 01:53:52 +0000 Received: by outflank-mailman (input) for mailman id 582223; Fri, 11 Aug 2023 01:53:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUHLa-0007fA-UC for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 01:53:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8a4e5af-37e9-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 03:53:47 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AF76651F7; Fri, 11 Aug 2023 01:53:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C25EC433C8; Fri, 11 Aug 2023 01:53:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8a4e5af-37e9-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691718825; bh=YRwtfgrELPlaPCQn8xHZDThKAaQOutw3UZTsU/0hUM0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=o/YVEjsWmFHbrUmi2lLmStduFykH76s51lFGh8kKtdoZnRx4F1DeJLPCEwra3m56N bO1WGOvbmCRUhwHxno07wOBjlM+YWtI/8nAa7IKYgfK0OT8Nj3oy/KdbVfCHiV5QUg 2+v8asv4CKsSWVM5LAVHGWONTHvi1dHJZoAV5Im/CgLZEYYn/jiW+UNOdgITGH3jw4 40hcUqf4yBo+sCXzSHFVHD8wzpv/0YSFNvN7SQCoSRTuDN7GQpRDjl0nY3xbD5c5B0 eWVcbg5QHJw/4R96K+sVF+I4yM2U8YM6sW9mB3WfHhqrjVH67xc67gPMZjHSvd4uXC rbVm2lvIHk8uQ== Date: Thu, 10 Aug 2023 18:53:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Jan Beulich , Bertrand Marquis , Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [RFC PATCH 5/5] xen: Add clang-format configuration In-Reply-To: <7219AAB4-7218-405F-8B4E-D9F3E54213EA@arm.com> Message-ID: References: <20230728081144.4124309-1-luca.fancellu@arm.com> <20230728081144.4124309-6-luca.fancellu@arm.com> <3c5ae070-d6c2-070c-e482-e5135e2acef1@suse.com> <394778DB-2D5E-4C52-9DA1-F23A530534A8@arm.com> <9743391f-3b89-ddba-1c79-ddbb1d143437@suse.com> <7219AAB4-7218-405F-8B4E-D9F3E54213EA@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1322985965-1691718826=:2127516" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1322985965-1691718826=:2127516 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 10 Aug 2023, Luca Fancellu wrote: > > On 10 Aug 2023, at 09:08, Jan Beulich wrote: > > > > On 09.08.2023 18:18, Luca Fancellu wrote: > >>> On 9 Aug 2023, at 16:48, Jan Beulich wrote: > >>> On 28.07.2023 10:11, Luca Fancellu wrote: > >>>> --- /dev/null > >>>> +++ b/xen/.clang-format > >>>> @@ -0,0 +1,693 @@ > >>>> +# SPDX-License-Identifier: GPL-2.0-only > >>>> +# > >>>> +# clang-format configuration file. Intended for clang-format >= 15. > >>>> +# > >>>> +# For more information, see: > >>>> +# > >>>> +# Documentation/process/clang-format.rst > >>>> +# https://clang.llvm.org/docs/ClangFormat.html > >>>> +# https://clang.llvm.org/docs/ClangFormatStyleOptions.html > >>>> +# > >>>> +--- > >>>> + > >>>> +# [not specified] > >>>> +# Align function parameter that goes into a new line, under the open bracket > >>>> +# (supported in clang-format 3.8) > >>>> +AlignAfterOpenBracket: Align > >>> > >>> I'm not convinced this rule (assuming I'm getting it right) is > >>> suitable in all cases, especially for functions with long names or > >>> very many parameters. > >> > >> Not sure I understand, I think this is the current behaviour in the codebase now. > > > > My understanding is that the above aims at (only) > > > > unsigned long function(unsigned long first_long_argument, > > unsigned long second_long_argument); > > > > when we also permit > > > > unsigned long function( > > unsigned long first_long_argument, > > unsigned long second_long_argument); > > Ohh ok now I see what you meant! > > I did try this, ok sure it will format it as: > > unsigned long function(unsigned long first_long_argument, > unsigned long second_long_argument); > > Because it sees that it will fit the 80 chars. > > At some point I think we need to overcome the uncertainty and chose a side, only > from there we can benefit from an automatic checker and we can get rid of style issues (most of them). > > Unfortunately most of the time we can’t say to the tool: we permit this style but also this style, > only one can be allowed and just few discrepancy might be deviated if properly justified (in-code comments). > > I guess this is the only way to: > 1) have a formalised coding style > 2) have an automatic checker > 3) unify the hypervisor codebase style, that will diverge (more than now) very quickly with the introduction > of new arch and features I think it is understood that we'll have to make some style choices that today are left open and also that we might have to introduce some style conversions. The question is exactly which choices and which conversions. We need to come up with a list, hopefully a short one. --8323329-1322985965-1691718826=:2127516-- From xen-devel-bounces@lists.xenproject.org Fri Aug 11 01:55:34 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 01:55:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582227.911863 (Exim 4.92) (envelope-from ) id 1qUHNF-0008DP-RS; Fri, 11 Aug 2023 01:55:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582227.911863; Fri, 11 Aug 2023 01:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUHNF-0008DI-O7; Fri, 11 Aug 2023 01:55:33 +0000 Received: by outflank-mailman (input) for mailman id 582227; Fri, 11 Aug 2023 01:55:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUHNE-0008D8-LD for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 01:55:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25f243fc-37ea-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 03:55:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7923860EAD; Fri, 11 Aug 2023 01:55:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0E6AC433C8; Fri, 11 Aug 2023 01:55:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25f243fc-37ea-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691718928; bh=sXJr4lVOJAdZnyi1KV+v/DU3uqu1sSSHS1WOYnDS/7Q=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lxj8MtsGOqBODsPmOo8aXpzc4eVnO1d2q3Ba5EmLilZL5flGexZxZSqU0+wrJAWwM jqxhNotbdh+dKs4L1jl6lKYR9pNnMvpCSMWDTkUdlVGdwpzSR+Z+LkADSgQDyFMSX9 Cqbq5DrK6ujPz8ilhEjjmBqM7UvcqfmY2X1kQ//aPbuwhw6JXaW+2VU97C43gPDUmT ruRv6Sy+zjlihscLnjfF0t7eaYUvnoaMo/4mW7e2c8Abb9K3oyCaNlvdDR8od8ftyj RHq7DFt0Ho2ZbMgUPIJ7QIpJmxjlmc7Z9CRkAZTKIs8POQXWWNCIVGGPDJHGpORw8j sBgPTkVszzOTA== Date: Thu, 10 Aug 2023 18:55:26 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Michal Orzel , Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node() In-Reply-To: Message-ID: References: <20230810112544.17365-1-michal.orzel@amd.com> <20230810112544.17365-2-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 10 Aug 2023, Luca Fancellu wrote: > > On 10 Aug 2023, at 12:25, Michal Orzel wrote: > > > > When booting a dom0less domU without initial ramdisk, it was observed > > that Xen still creates empty linux,initrd-{start,end} properties under > > /chosen node. This is because in make_chosen_node(), generation of initrd > > placeholders (later on filled with the real values) is protected with > > a check for presence of kernel bootmodule (always present) instead of > > initrd bootmodule. Fix it along with renaming the variable from "mod" to > > "initrd" to prevent similar mistakes in the future. > > > > Fixes: 48f4bf6bdeb4 ("arm/acpi: Create min DT stub for Dom0") > > Signed-off-by: Michal Orzel > > Hi Michal, good catch! > > Reviewed-by: Luca Fancellu Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 11 01:56:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 01:56:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582233.911873 (Exim 4.92) (envelope-from ) id 1qUHNq-0000JM-2B; Fri, 11 Aug 2023 01:56:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582233.911873; Fri, 11 Aug 2023 01:56:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUHNp-0000JF-Vn; Fri, 11 Aug 2023 01:56:09 +0000 Received: by outflank-mailman (input) for mailman id 582233; Fri, 11 Aug 2023 01:56:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUHNo-0008T2-TR for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 01:56:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c91920d-37ea-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 03:56:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 09CF5666DE; Fri, 11 Aug 2023 01:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93768C433CD; Fri, 11 Aug 2023 01:56:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c91920d-37ea-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691718966; bh=i8IPE+UjAwW58njxwkt29XTvoehoyO84GQsyplLavZE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=icoPaQXj3Pqe36cXHo5OiTH71XtEy0t1eXhviBIls+8XQzNvRZiV15BFlc8ElDyGr tD4FvfYrbYcrE7h7FUm9vcDxvb9kHhqKelWlT1vAMUfbzmp89OocBm6PqFaIbHq5AU X9D4VBH+jTw4w0UgXqov+L3oTs6+fEGKUZFRS4HDzK2YdK7GwMQAE6Idz5Y1jFTkea WhJcduYeNCq0PuJaLUbwMa4uGkAHRtImOzg2bqVt1Diw1VX6mJxf/4e4yBw7epLqe6 L93xkuAx6PZU0DUyseSqcP+NGXFwyS0FW40eqaUq3oO2Wy3jz1dYaQbzDfpY4+Zb2g dq6PSn9m2l/GQ== Date: Thu, 10 Aug 2023 18:56:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Luca Fancellu cc: Michal Orzel , Xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: Skip inclusion of domU nodes into hwdom dt /chosen node In-Reply-To: Message-ID: References: <20230810112544.17365-1-michal.orzel@amd.com> <20230810112544.17365-3-michal.orzel@amd.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 10 Aug 2023, Luca Fancellu wrote: > > On 10 Aug 2023, at 12:25, Michal Orzel wrote: > > > > Configuration for dom0less domUs is stored under /chosen/ nodes > > present in the host device tree provided to Xen. All the properties and > > sub nodes there are meant only for Xen. However, at the moment we still > > copy them (except for modules that we skip) into hardware domain /chosen > > node. Fix it by adding "xen,domain" compatible into the list of nodes to > > skip in handle_node(). > > > > Signed-off-by: Michal Orzel > > Reviewed-by: Luca Fancellu Acked-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Aug 11 03:58:59 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 03:58:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582242.911883 (Exim 4.92) (envelope-from ) id 1qUJIS-00052G-KE; Fri, 11 Aug 2023 03:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582242.911883; Fri, 11 Aug 2023 03:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUJIS-000529-GM; Fri, 11 Aug 2023 03:58:44 +0000 Received: by outflank-mailman (input) for mailman id 582242; Fri, 11 Aug 2023 03:58:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUJIQ-00051y-US; Fri, 11 Aug 2023 03:58:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUJIQ-0005zb-Mp; Fri, 11 Aug 2023 03:58:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUJIQ-0000kQ-87; Fri, 11 Aug 2023 03:58:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qUJIQ-00059q-7Q; Fri, 11 Aug 2023 03:58:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dVIhCAHa5SozWamb1JJizhDtHywEK2szWQXXk90vMhU=; b=Ya7icKSYS2tBsGXWY9aofNDQDG 7LxSv4R9flDE62TUW1nsfdyuQuH/PV6k6AwzGmhB/YM59tb8PSJeXjkeYPqW9EmNjIDmPcthNdlYf 6xQh8kF97//AFxs21EPIuZZysxtANqB36pPCH9QFPdiFR3pv1hey5BwyjTKUtspMHzyU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 182258: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start.2:fail:regression linux-5.4:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=21732fd224978ebddf4bded7cb99663d2be1e732 X-Osstest-Versions-That: linux=887433e4bc9394676d22c038dba33a27405f94e8 From: osstest service owner Date: Fri, 11 Aug 2023 03:58:42 +0000 flight 182258 linux-5.4 real [real] flight 182267 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182258/ http://logs.test-lab.xenproject.org/osstest/logs/182267/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 19 guest-start.2 fail in 182239 REGR. vs. 182076 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-xsm 7 xen-install fail in 182239 pass in 182258 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail in 182239 pass in 182267-retest test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 182267 pass in 182239 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail pass in 182239 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 182239 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 14 guest-start fail in 182239 like 182065 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 182239 like 182076 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 182239 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 182239 never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 182239 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 182239 never pass test-armhf-armhf-xl-credit2 14 guest-start fail like 182031 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182076 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182076 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182076 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182076 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182076 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 182076 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182076 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182076 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182076 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182076 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182076 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 182076 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182076 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182076 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 21732fd224978ebddf4bded7cb99663d2be1e732 baseline version: linux 887433e4bc9394676d22c038dba33a27405f94e8 Last test of basis 182076 2023-07-29 17:15:26 Z 12 days Testing same since 182239 2023-08-08 18:13:15 Z 2 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Arnaldo Carvalho de Melo Ben Hutchings Borislav Petkov (AMD) Borislav Petkov Daniel Sneddon Dave Hansen Geert Uytterhoeven Greg Kroah-Hartman Joerg Roedel Josh Poimboeuf Juergen Gross Kim Phillips Paolo Bonzini Peter Zijlstra (Intel) Peter Zijlstra Richard Weinberger Ross Lagerwall Sean Christopherson Thomas Gleixner Tom Lendacky jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 738 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Aug 11 05:23:30 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 05:23:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582251.911895 (Exim 4.92) (envelope-from ) id 1qUKcE-0006c3-Ix; Fri, 11 Aug 2023 05:23:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582251.911895; Fri, 11 Aug 2023 05:23:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUKcE-0006bw-G2; Fri, 11 Aug 2023 05:23:14 +0000 Received: by outflank-mailman (input) for mailman id 582251; Fri, 11 Aug 2023 05:23:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUKcC-0006bm-Ta; Fri, 11 Aug 2023 05:23:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUKcC-0008Q7-Kg; Fri, 11 Aug 2023 05:23:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUKcC-0003hj-91; Fri, 11 Aug 2023 05:23:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qUKcC-0001Hf-8U; Fri, 11 Aug 2023 05:23:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NItVQZ7wr9pMEPESudV9RQ9ZkW6kk/r97jppjR5K/Aw=; b=UvngqkwsMd0JEz7PswGBjdZD0W N1gl5NhQJ2Ud9idgboCmsYTixAtdeSKyY3PMh/QVE/3TNXusifXD7058jCBzekgqcK3dzYOOKzE3P LgfuxB1IZbJVcYTBnXhK0XSMt4SDv+XzqVpNxEeeuA8m3bypTmfoQZG/Kbu+A2T8ys6s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182268: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c6bda36af0b992d5d2042efd6cc36592fb037a1d X-Osstest-Versions-That: xen=b70ffd23865e6c320fe2e8931f0d0366d7e03cac From: osstest service owner Date: Fri, 11 Aug 2023 05:23:12 +0000 flight 182268 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182268/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c6bda36af0b992d5d2042efd6cc36592fb037a1d baseline version: xen b70ffd23865e6c320fe2e8931f0d0366d7e03cac Last test of basis 182261 2023-08-10 14:02:08 Z 0 days Testing same since 182268 2023-08-11 03:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel Nicola Vetrini Stefano Stabellini Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b70ffd2386..c6bda36af0 c6bda36af0b992d5d2042efd6cc36592fb037a1d -> smoke From xen-devel-bounces@lists.xenproject.org Fri Aug 11 06:50:51 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 06:50:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582260.911908 (Exim 4.92) (envelope-from ) id 1qULyk-0008I8-L6; Fri, 11 Aug 2023 06:50:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582260.911908; Fri, 11 Aug 2023 06:50:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qULyk-0008I1-I8; Fri, 11 Aug 2023 06:50:34 +0000 Received: by outflank-mailman (input) for mailman id 582260; Fri, 11 Aug 2023 06:50:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qULyk-0008Hv-5c for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 06:50:34 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5c73e9a3-3813-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 08:50:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6832F1F889; Fri, 11 Aug 2023 06:50:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3CFA113592; Fri, 11 Aug 2023 06:50:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xddjDTba1WR0VwAAMHmgww (envelope-from ); Fri, 11 Aug 2023 06:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c73e9a3-3813-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1691736630; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UlVjIFpsCGIZ6kFCwZDuLa4Rp2Ngcyb4pxO2PbFm6dQ=; b=czvG3J4m2Ehjkx0methcbeNN6+T9vGqIAVBaPV828QaPUM2yowELrKpHmPQfvOcUfBb2GG Tz+PfqtFD/T8D6X1XscT4GVeKhWCnmMEZAwm3/8ub2pPZ1++2h/hc/BDu+heWLQzQwMQUZ s+eTXTUtqX7MzUAGBIfSbDhz4Fho0D8= Message-ID: Date: Fri, 11 Aug 2023 08:50:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: adjust comparison for earlier signedness change Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: From: Juergen Gross Autocrypt: addr=jgross@suse.com; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNH0p1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT7CwHkEEwECACMFAlOMcK8CGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCw3p3WKL8TL8eZB/9G0juS/kDY9LhEXseh mE9U+iA1VsLhgDqVbsOtZ/S14LRFHczNd/Lqkn7souCSoyWsBs3/wO+OjPvxf7m+Ef+sMtr0 G5lCWEWa9wa0IXx5HRPW/ScL+e4AVUbL7rurYMfwCzco+7TfjhMEOkC+va5gzi1KrErgNRHH kg3PhlnRY0Udyqx++UYkAsN4TQuEhNN32MvN0Np3WlBJOgKcuXpIElmMM5f1BBzJSKBkW0Jc Wy3h2Wy912vHKpPV/Xv7ZwVJ27v7KcuZcErtptDevAljxJtE7aJG6WiBzm+v9EswyWxwMCIO RoVBYuiocc51872tRGywc03xaQydB+9R7BHPzsBNBFOMcBYBCADLMfoA44MwGOB9YT1V4KCy vAfd7E0BTfaAurbG+Olacciz3yd09QOmejFZC6AnoykydyvTFLAWYcSCdISMr88COmmCbJzn sHAogjexXiif6ANUUlHpjxlHCCcELmZUzomNDnEOTxZFeWMTFF9Rf2k2F0Tl4E5kmsNGgtSa aMO0rNZoOEiD/7UfPP3dfh8JCQ1VtUUsQtT1sxos8Eb/HmriJhnaTZ7Hp3jtgTVkV0ybpgFg w6WMaRkrBh17mV0z2ajjmabB7SJxcouSkR0hcpNl4oM74d2/VqoW4BxxxOD1FcNCObCELfIS auZx+XT6s+CE7Qi/c44ibBMR7hyjdzWbABEBAAHCwF8EGAECAAkFAlOMcBYCGwwACgkQsN6d 1ii/Ey9D+Af/WFr3q+bg/8v5tCknCtn92d5lyYTBNt7xgWzDZX8G6/pngzKyWfedArllp0Pn fgIXtMNV+3t8Li1Tg843EXkP7+2+CQ98MB8XvvPLYAfW8nNDV85TyVgWlldNcgdv7nn1Sq8g HwB2BHdIAkYce3hEoDQXt/mKlgEGsLpzJcnLKimtPXQQy9TxUaLBe9PInPd+Ohix0XOlY+Uk QFEx50Ki3rSDl2Zt2tnkNYKUCvTJq7jvOlaPd6d/W0tZqpyy7KVay+K4aMobDsodB3dvEAs6 ScCnh03dDAFgIq5nsB11j3KPKdVoPlfucX2c7kGNH+LUMbzqV6beIENfNexkOfxHfw== In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WAGvVswbNVQ6yySB0eYmhDvP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WAGvVswbNVQ6yySB0eYmhDvP Content-Type: multipart/mixed; boundary="------------TTeej60yVfTNODtu0gq5jILR"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Message-ID: Subject: Re: [PATCH] x86: adjust comparison for earlier signedness change References: In-Reply-To: --------------TTeej60yVfTNODtu0gq5jILR Content-Type: multipart/mixed; boundary="------------j9CPQKlf5M10N5bR7aLFfUr7" --------------j9CPQKlf5M10N5bR7aLFfUr7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAuMDguMjMgMTY6NTksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBJbnRlcmVzdGluZ2x5 IG9ubHkgQ2xhbmcgd2FybnMgYWJvdXQgdGhlIG5vdyBib2d1cyBsZXNzLXRoYW4temVybw0K PiBjb21wYXJpc29uLiBDb252ZXJ0IGl0IHRvIHNvbWV0aGluZyB0aGF0J3MgbW9yZSBleHBs aWNpdGx5IGRvaW5nIHdoYXQNCj4gdGhlIGNvbW1lbnQgc2F5cy4NCj4gDQo+IEZpeGVzOiA0 MDg2ODU3Y2MxNTkgKCJ4ODY6IGltcGxlbWVudCBjcHVpZCgpIGluIHRlcm1zIG9mIGNwdWlk X2NvdW50KCkiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+ DQoNCg0KSnVlcmdlbg0KDQo= --------------j9CPQKlf5M10N5bR7aLFfUr7 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------j9CPQKlf5M10N5bR7aLFfUr7-- --------------TTeej60yVfTNODtu0gq5jILR-- --------------WAGvVswbNVQ6yySB0eYmhDvP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmTV2jUFAwAAAAAACgkQsN6d1ii/Ey+z pQf/Q9Tw+KhMPRmhj6mmMtiLtJkzTO249jhVSTdtO9V7FaBv0NQdT/HbQBSG+ZwNUVnSYbn7O71f ScRhoePCVJEkNnyi59inth/fsGR3IjXdaEqeX1ZhwPYJwIV7HtGs0ga+3xa2D5E1g17OrV0BVYWG wAM2rsJatwGJs4/mcpi9G1AYk7xVIhXTmr6/g+e7IUM3hDy4P467zoYGkpdO/TUsIlC9GVHcfZl0 DeLW8jwO9r2WkOmQup6BAOEtDl183AT0FOC9aUuCKa45p2jLgdmbQzjk9iu61X0H9Wc6oikLOjxq p7NIKcndJ3b7xCh/o/F7kXOIeqghVr4oz9CUPePrWA== =29zQ -----END PGP SIGNATURE----- --------------WAGvVswbNVQ6yySB0eYmhDvP-- From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:07:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:07:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582268.911922 (Exim 4.92) (envelope-from ) id 1qUMEe-0001bH-6J; Fri, 11 Aug 2023 07:07:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582268.911922; Fri, 11 Aug 2023 07:07:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMEe-0001bA-2z; Fri, 11 Aug 2023 07:07:00 +0000 Received: by outflank-mailman (input) for mailman id 582268; Fri, 11 Aug 2023 07:06:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMEc-0001b4-W5 for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:06:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a8200aee-3815-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 09:06:56 +0200 (CEST) Received: from Dell.homenet.telecomitalia.it (host-79-55-201-67.retail.telecomitalia.it [79.55.201.67]) by support.bugseng.com (Postfix) with ESMTPSA id 6A98A4EE073F; Fri, 11 Aug 2023 09:06:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8200aee-3815-11ee-8613-37d641c3527e From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3 Date: Fri, 11 Aug 2023 09:06:48 +0200 Message-Id: <5500643d99b315aa4344e5e3a833e6efa9a0413f.1691737296.git.federico.serafini@bugseng.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Uniform the auto-generated hypercall-decls with the corresponding definitions to address violations of MISRA C:2012 Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". No functional change. Signed-off-by: Federico Serafini --- xen/include/hypercall-defs.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c index 6d361ddfce..4feddce571 100644 --- a/xen/include/hypercall-defs.c +++ b/xen/include/hypercall-defs.c @@ -107,11 +107,16 @@ defhandle: physdev_op_compat_t prefix: do PREFIX_hvm PREFIX_compat PREFIX_do_arm physdev_op(int cmd, void *arg) -prefix: do PREFIX_hvm PREFIX_compat +prefix: do PREFIX_hvm #if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM) grant_table_op(unsigned int cmd, void *uop, unsigned int count) #endif +prefix: PREFIX_compat +#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM) +grant_table_op(unsigned int cmd, void *cmp_uop, unsigned int count) +#endif + prefix: do PREFIX_hvm memory_op(unsigned long cmd, void *arg) @@ -136,7 +141,7 @@ xenoprof_op(int op, void *arg) prefix: compat set_timer_op(uint32_t lo, int32_t hi) multicall(multicall_entry_compat_t *call_list, uint32_t nr_calls) -memory_op(unsigned int cmd, void *arg) +memory_op(unsigned int cmd, void *compat) #ifdef CONFIG_IOREQ_SERVER dm_op(domid_t domid, unsigned int nr_bufs, void *bufs) #endif @@ -172,7 +177,7 @@ console_io(unsigned int cmd, unsigned int count, char *buffer) vm_assist(unsigned int cmd, unsigned int type) event_channel_op(int cmd, void *arg) mmuext_op(mmuext_op_t *uops, unsigned int count, unsigned int *pdone, unsigned int foreigndom) -multicall(multicall_entry_t *call_list, unsigned int nr_calls) +multicall(multicall_entry_t *call_list, uint32_t nr_calls) #ifdef CONFIG_PV mmu_update(mmu_update_t *ureqs, unsigned int count, unsigned int *pdone, unsigned int foreigndom) stack_switch(unsigned long ss, unsigned long esp) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582275.911932 (Exim 4.92) (envelope-from ) id 1qUMQN-0003A6-8d; Fri, 11 Aug 2023 07:19:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582275.911932; Fri, 11 Aug 2023 07:19:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMQN-00039z-4A; Fri, 11 Aug 2023 07:19:07 +0000 Received: by outflank-mailman (input) for mailman id 582275; Fri, 11 Aug 2023 07:19:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMQL-00039t-L1 for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:05 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2060b.outbound.protection.outlook.com [2a01:111:f400:fe5b::60b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 589d9e6d-3817-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 09:19:02 +0200 (CEST) Received: from BL1PR12MB5849.namprd12.prod.outlook.com (2603:10b6:208:384::18) by BN9PR12MB5275.namprd12.prod.outlook.com (2603:10b6:408:100::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.20; Fri, 11 Aug 2023 07:18:59 +0000 Received: from BL1PR12MB5849.namprd12.prod.outlook.com ([fe80::c838:299:8697:dd70]) by BL1PR12MB5849.namprd12.prod.outlook.com ([fe80::c838:299:8697:dd70%5]) with mapi id 15.20.6678.019; Fri, 11 Aug 2023 07:18:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 589d9e6d-3817-11ee-8613-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bKoVuY5xjgBEkcEz98reS+T0cRz5opLteF2+gkqYAHXTqW58pv/kwWjWAGsYi0MWUVLEdqT6M3MhqY+P68KjFJE9cr4LXTf0Wj32wV5LkOzaXk2VtNBlDomgu6wZ+f/bwSJ+KvzUIGJ6pfeE7ITycZYG6YTsa1ODQPv5QC7EoiUlnloN0vutcPzzfDrnpMap2VzTVGfwbIJyJhVjcu49loVaWPZa++zT2FrirSng8KoUp6x24Jw1JuTvAaLIYfhP786J7P+jYFT9wlPF9DZOHxx2nesHyUtwW4S8zj1xBEg6ap0EpFppGoNjw19pWUnBPKsoRyJ2LOoYVUFTpzbUPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6LQih2CHe0SY021lo2qYbsq9fAdP21DDwWynDZMOtY4=; b=FoIVQZZdqCDUXavnPvY4SQaEsOFbF/rEmr6vl1Eb/dvKDg85X8yA516zIAeMvJlGi5v+3To6irBA+EWD7ZMdj+Piv4lR+xGEKYNEyFP+DX+abcSYzUKVN/Gf83qhbO5w5w2Z7q1/bJXclzA34o64SXMzhlVY59reMeMKO90vk1gAukZ0sDq9mkcm5EP1oYXWjqkaDCfCaOXkXzbqyZY95yvIJ55Gpky2I6O+uSl+ken46GAOlt1qfysfOvLLf6YUHJjvbETDIJtd5xV2pyQW749+THk5k/ToHcdJoZSKcr6h97bsi5L4RQf+qXrCyFk14ALVKD0MlyI4iZ7hjCiyuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6LQih2CHe0SY021lo2qYbsq9fAdP21DDwWynDZMOtY4=; b=Z8ypf4lHxhPcupn6qpMpJr1bjJTAD3hh0H8Cm3a3dzDJUFK9+hTr5iaCtP8DAVWeigXy3nSw2DGvSNOPDnNBW7ltzrC+diUFEn5m9rOH0GlDlErjiUho2uW4cdbQSwg9yFZFX41io8Mfve77j1pb6Z+BSW0sXmM2qbNC+adAxmo= From: "Chen, Jiqian" To: "Chen, Jiqian" , Gerd Hoffmann , =?utf-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , "Michael S . Tsirkin" , Robert Beckett , "qemu-devel@nongnu.org" CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Anthony PERARD , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "Dr . David Alan Gilbert" , "Deucher, Alexander" , "Koenig, Christian" , "Hildebrand, Stewart" , Xenia Ragiadakou , "Huang, Honglei1" , "Zhang, Julia" , "Huang, Ray" Subject: Re: [QEMU PATCH v4 0/1] S3 support Thread-Topic: [QEMU PATCH v4 0/1] S3 support Thread-Index: AQHZuwLsbW42un3+5UCTG4JhRKUU2a/lVBMA Date: Fri, 11 Aug 2023 07:18:58 +0000 Message-ID: References: <20230720120816.8751-1-Jiqian.Chen@amd.com> In-Reply-To: <20230720120816.8751-1-Jiqian.Chen@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-imapappendstamp: BL1PR12MB5849.namprd12.prod.outlook.com (15.20.6678.019) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL1PR12MB5849:EE_|BN9PR12MB5275:EE_ x-ms-office365-filtering-correlation-id: 81742234-6698-4259-5e2e-08db9a3b3ae8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N9OeuV3Mf4KlK2+up39/ejMu0AkUVxQiKplm7kQS7b1njM+HHtrW5P2qYKIbCo4HCZGku7HpEI3Obx8DF0D5L3A03Tig8RMdMSSK6W2YcCrCXv/NUNu7E6Mag0TNIah7Mcs8beWBt8Sa/KQRpTzhewvHEOhcT/GYv2bc4KlNmEeRhohiYuu/RVFAht/j1KvVzGPgUaU1VFLjYT3g5nzOhqXz4PxArLcl4GrWv9ZjtVdM/DprV96Kvekb1OkckJmeZ0Jp22nr6RV43vU7NzEvQLXuYMLvY1xiCcw4it2PBr2KmDKF08Cz/+4mDuNvm8ojGs1DKbC47q9+TnWrKdYNL1t8+P0auxZYcukZ730HdP2acwZ/u37Nrn3Z95ItODvKa0BVM940TTODeUjqq8H0OvFYtyb3oUOG7uohfx5lemPJUZfB3R6w9SFxs22i7GXcrwmFmB+R+Q7SE+pQUJ6nzSQQj3Uc9g5/IprapnVw4oeAfq25ZCk4VJ3HtTw5NAiaKEpfY32mce8KwTEIXmLUyWLaE5NpX50VeudV1p+DRlliSlwhKaGTd2DROpy5sYH9Fbyi8gagJE8BRLY+kZWixEq0KrwDanLNSh5pd9DDDj/eX8lAfEbyq5uqMxKUC0NltfnFLdnTdsGJg9Q18a0Mng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5849.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39860400002)(346002)(376002)(396003)(186006)(1800799006)(451199021)(9686003)(966005)(33656002)(55016003)(38070700005)(122000001)(38100700002)(6506007)(53546011)(26005)(83380400001)(478600001)(110136005)(54906003)(71200400001)(7696005)(4326008)(316002)(41300700001)(8936002)(8676002)(76116006)(2906002)(7416002)(52536014)(64756008)(66446008)(5660300002)(66476007)(66556008)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dTJic25qVTUzT01tNmE2VlY1UlRXTWl4VE9rbUhsaGE3Z1dNazAzVGZVdGFP?= =?utf-8?B?L01Fb1NiblU1VGJ5bmN3bkI3YmVBTG9VZWZobGlHeFdMMlk4Qk1MUEY3Ukky?= =?utf-8?B?QUlHU1YrSjBYMzVXaTNxMkdkajlwZHFoRU84L2pDVGRRcCtxSk1RdWlabkdG?= =?utf-8?B?OUR3S3hMOVB4Z2xNZUFVTFJGUks2djZxMUJaS1ZuZEV2U3lML2oyY2h1TnJl?= =?utf-8?B?dUVZVGtYTXQvTWRDaEcxVnhWQ1hRYlIrL0xzUTRFeW1kOWdSMThtZmpqYnJw?= =?utf-8?B?TlZ0QWhpWUlma2IyU1U1bGZsVXROQzlxQlJSL2hVSVl1eHlIZFpjcml2TzRZ?= =?utf-8?B?REZscEVqbkZ4YnVSdTRzWGVON3Bra0EvWmpKMVlPbkQxMGw5OFdlalJiSEU4?= =?utf-8?B?RTFCS3diRmNkdFJLUGNjMUhYT05xTTc2TnArMnRSeXhWSXpwMHpHS3lsbUdU?= =?utf-8?B?RVhSQTdJL3lDTzQwUlNSTVY2Z0pkaXJWRDFSbStyR1pwdHFyZWhVSXlBYzUv?= =?utf-8?B?R1hUbkl5QkN4b0JJMmdtMUhjZC9DcStVMWY4eXNjK202UW5NUWFNcGhpcTdH?= =?utf-8?B?UnptamJlSFh6dHl3U3FUenpSUFliMTI4N2xkRHpBeUliNE5YRktEd3JLcDR4?= =?utf-8?B?UDhuSFRSWEZyVCthU1NBOVFNKzB3SG1RcVRiaC85WDRLREl6Vkd6YWpPUnVP?= =?utf-8?B?THRPbXlObHpGcU1VeWpvVFhNS0g1MEF1L2Uyd2R2RDlkMzNnWkFhMFNSK1RG?= =?utf-8?B?dEdhZGo1RVJ6K2lhaGw5SmhWempNSkpWbHNaSHZ2WTJnVDJJN1NXbUZ1Y2Y2?= =?utf-8?B?T0tBVUg5T1JyQklXUXphZkZmbEtXVHgyY29JeDdjRjdpMkJtdzBDL2grcDlz?= =?utf-8?B?d1FhQVpOanB1T2pHKytEWW9vK0pOa1lPdzZFdnZ2dGd1MGxkU3gyQWliRGFG?= =?utf-8?B?VEc2WWN1dWljZXZvN2xmd0svcDdGVU1XK2xLNzlxVWFiZC9CeEdQVXkyRncx?= =?utf-8?B?WC9nYUNSQXp6K3RxUDZ0SUNPZlRReEVTeFVkTmFsM3Q0UElLMURiNVVBVFRo?= =?utf-8?B?Zmlud1RsalZqQkQySHdibkdtL0VPSG41WjQ3a1VuN1BPdGtZMVFTblZXVERp?= =?utf-8?B?WDU2anlOZzFRZ2l0R3V3NC81MG9PQlN1angvWUFwQUw0RG5zSkRPN2pmZUk0?= =?utf-8?B?OFFQN3BmcFVLaTd0YkhzU0UvTFJIcVFmNXpYaGZNeHhkeCtnelhLbDh2d08v?= =?utf-8?B?U2sxY2M3amZ4Q3IyRlFCU0pqNUVNMWpiSkY2cnZsVytSUE1nQmt0enFuTzRI?= =?utf-8?B?QVBWYjRjMjRWZlpNdXpRVHJRQ0E5dGJ2S0o3aHo3ZjRoaHUzZE9oK29tZDlp?= =?utf-8?B?UW9LZnFhTVNLWjU5UGRlb2o2TDRsSEJnVVF2TkRnelpHamhJeHIxQnVSZnVU?= =?utf-8?B?MnVpdm9KNWdOZHd1ek1mSlBmMDJYbGRmMFhyMlE5bW42ZmtIUXo3cTE5aklM?= =?utf-8?B?OHdYSnVEM2R0cWJ4SWdvSWlpeGVXdC9XMENhVndtMDB6SmFuWllHSHYrTU9p?= =?utf-8?B?dTBCVjNiR2NqR1VEQ1VmcW9ONzVLOUNBVFlFdU1YVVhHbndNTEJJTXZNa1Fi?= =?utf-8?B?NEx4Q0N1UGt3MXV3TTFWV0hTZHN0RHYrc2pzRzFqd0JKenFyQkIxZjJ5WWNY?= =?utf-8?B?MDlJYTNSQkZidTRSMXplaDZUL3IxUUk3eG8wNERtVDVEK1AwNk4yQ29USlBV?= =?utf-8?B?T0YwV2o1K2wwZHkvZXFaVHJPSm5kcjFrbFRLa0NXcEZyYWxkejVzK2J5bU0z?= =?utf-8?B?bzNyTHlXTHZIbUhrZ3JHa1dnVHBBTzV2dzcvaVRndm5BODd6Umw3WFRtODVn?= =?utf-8?B?VlFGcGZ6RGtXbmdiVThJdzZzZHMyOGxiZDZUeXBlQ29Hak1ucEhqTkYwa1Zy?= =?utf-8?B?VnBWOHA1TUtIc0dwUkU2WjFrckxnT3NJanU0ZWVOMDZ0ME9naUFJY2VyeThX?= =?utf-8?B?aVN2RkNoSUxKRU9jcVlBU09JWkJwK1BnNXpRRjZGcTBKOEFCQUlvMU5Mdk1y?= =?utf-8?B?K3l4TGlDZzVXWTFJN2ZsRHV0VlMyY0g0cHBwdHpyZGhCblV4dmRFd1ZYOExn?= =?utf-8?Q?+dqU=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <7AF8FD31EDE7924F81136788368059D2@amdcloud.onmicrosoft.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5849.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81742234-6698-4259-5e2e-08db9a3b3ae8 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2023 07:18:58.4880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eJDnZ36h02beMSJttSLOJtDR7kIEGOzJlXfr+h+LbCLdwegYJgO3PuI8irZiOYx0/SxQyI56eWLAJdPLqPfzjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5275 SGkgYWxsLA0KUGxlYXNlIGZvcmdpdmUgbWUgZm9yIGFza2luZy4gRG8geW91IGhhdmUgYW55IG90 aGVyIGNvbW1lbnRzIG9uIG15IGxhdGVzdCB2ZXJzaW9uIHBhdGNoZXMgYWJvdXQgdmlydGlvLWdw dSBTMyBvbiBYZW4/IExvb2tpbmcgZm9yd2FyZCB0byB5b3VyIHJlcGx5Lg0KDQoNCk9uIDIwMjMv Ny8yMCAyMDowOCwgSmlxaWFuIENoZW4gd3JvdGU6DQo+IHY0Og0KPiANCj4gSGkgYWxsLA0KPiBU aGFua3MgZm9yIEdlcmQgSG9mZm1hbm4ncyBhZHZpY2UuIFY0IG1ha2VzIGJlbG93IGNoYW5nZXM6 DQo+ICogVXNlIGVudW0gZm9yIGZyZWV6ZSBtb2RlLCBzbyB0aGlzIGNhbiBiZSBleHRlbmRlZCB3 aXRoIG1vcmUNCj4gICBtb2RlcyBpbiB0aGUgZnV0dXJlLg0KPiAqIFJlbmFtZSBmdW5jdGlvbnMg YW5kIHBhcmF0ZW1lcnMgd2l0aCAiX1MzIiBwb3N0Zml4Lg0KPiBBbmQgbm8gZnVuY3Rpb25hbCBj aGFuZ2VzLg0KPiANCj4gbGF0ZXN0IHZlcnNpb24gb24ga2VybmVsIHNpZGU6DQo+IGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2xrbWwvMjAyMzA3MjAxMTU4MDUuODIwNi0xLUppcWlhbi5DaGVuQGFt ZC5jb20vVC8jdA0KPiANCj4gQmVzdCByZWdhcmRzLA0KPiBKaXFpYW4gQ2hlbi4NCj4gDQo+IA0K PiB2MzoNCj4gbGluaywNCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvcWVtdS1kZXZlbC8yMDIz MDcxOTA3NDcyNi4xNjEzMDg4LTEtSmlxaWFuLkNoZW5AYW1kLmNvbS9ULyN0DQo+IA0KPiBIaSBh bGwsDQo+IFRoYW5rcyBmb3IgTWljaGFlbCBTLiBUc2lya2luJ3MgYWR2aWNlLiBWMyBtYWtlcyBi ZWxvdyBjaGFuZ2VzOg0KPiAqIFJlbW92ZSBjaGFuZ2VzIGluIGZpbGUgaW5jbHVkZS9zdGFuZGFy ZC1oZWFkZXJzL2xpbnV4L3ZpcnRpb19ncHUuaA0KPiAgIEkgYW0gbm90IHN1cHBvc2VkIHRvIGVk aXQgdGhpcyBmaWxlIGFuZCBpdCB3aWxsIGJlIGltcG9ydGVkIGFmdGVyDQo+ICAgdGhlIHBhdGNo ZXMgb2YgbGludXgga2VybmVsIHdhcyBtZXJnZWQuDQo+IA0KPiANCj4gdjI6DQo+IGxpbmssDQo+ IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3FlbXUtZGV2ZWwvMjAyMzA2MzAwNzAwMTYuODQxNDU5 LTEtSmlxaWFuLkNoZW5AYW1kLmNvbS9ULyN0DQo+IA0KPiBIaSBhbGwsDQo+IFRoYW5rcyB0byBN YXJjLUFuZHLDqSBMdXJlYXUsIFJvYmVydCBCZWNrZXR0IGFuZCBHZXJkIEhvZmZtYW5uIGZvcg0K PiB0aGVpciBhZHZpY2UgYW5kIGd1aWRhbmNlLiBWMiBtYWtlcyBiZWxvdyBjaGFuZ2VzOg0KPiAN Cj4gKiBDaGFuZ2UgVklSVElPX0NQVV9DTURfU1RBVFVTX0ZSRUVaSU5HIHRvIDB4MDQwMCAoPDB4 MTAwMCkNCj4gKiBBZGQgdmlydGlvX2dwdV9kZXZpY2VfdW5yZWFsaXplIHRvIGRlc3Ryb3kgcmVz b3VyY2VzIHRvIHNvbHZlDQo+ICAgcG90ZW50aWFsIG1lbW9yeSBsZWFrIHByb2JsZW0uIFRoaXMg YWxzbyBuZWVkcyBob3QtcGx1ZyBzdXBwb3J0Lg0KPiAqIEFkZCBhIG5ldyBmZWF0dXJlIGZsYWcg VklSVElPX0dQVV9GX0ZSRUVaSU5HLCBzbyB0aGF0IGd1ZXN0IGFuZA0KPiAgIGhvc3QgY2FuIG5l Z290aWF0ZSB3aGVuZXZlciBmcmVlemluZyBpcyBzdXBwb3J0ZWQgb3Igbm90Lg0KPiANCj4gdjE6 DQo+IGxpbmssDQo+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3FlbXUtZGV2ZWwvMjAyMzA2MDgw MjU2NTUuMTY3NDM1Ny0xLUppcWlhbi5DaGVuQGFtZC5jb20vDQo+IA0KPiBIaSBhbGwsDQo+IEkg YW0gd29ya2luZyB0byBpbXBsZW1lbnQgdmlydGdwdSBTMyBmdW5jdGlvbiBvbiBYZW4uDQo+IA0K PiBDdXJyZW50bHkgb24gWGVuLCBpZiB3ZSBzdGFydCBhIGd1ZXN0IHdobyBlbmFibGVzIHZpcnRn cHUsIGFuZCB0aGVuDQo+IHJ1biAiZWNobyBtZW0gPiAvc3lzL3Bvd2VyL3N0YXRlIiB0byBzdXNw ZW5kIGd1ZXN0LiBBbmQgcnVuDQo+ICJzdWRvIHhsIHRyaWdnZXIgPGd1ZXN0IGlkPiBzM3Jlc3Vt ZSIgdG8gcmVzdW1lIGd1ZXN0LiBXZSBjYW4gZmluZCB0aGF0DQo+IHRoZSBndWVzdCBrZXJuZWwg Y29tZXMgYmFjaywgYnV0IHRoZSBkaXNwbGF5IGRvZXNuJ3QuIEl0IGp1c3Qgc2hvd24gYQ0KPiBi bGFjayBzY3JlZW4uDQo+IA0KPiBUaHJvdWdoIHJlYWRpbmcgY29kZXMsIEkgZm91bmRlZCB0aGF0 IHdoZW4gZ3Vlc3Qgd2FzIGR1cmluZyBzdXNwZW5kaW5nLA0KPiBpdCBjYWxsZWQgaW50byBRZW11 IHRvIGNhbGwgdmlydGlvX2dwdV9nbF9yZXNldC4gSW4gdmlydGlvX2dwdV9nbF9yZXNldCwNCj4g aXQgZGVzdHJveWVkIGFsbCByZXNvdXJjZXMgYW5kIHJlc2V0IHJlbmRlcmVyLiBUaGlzIG1hZGUg dGhlIGRpc3BsYXkNCj4gZ29uZSBhZnRlciBndWVzdCByZXN1bWVkLg0KPiANCj4gSSB0aGluayB3 ZSBzaG91bGQga2VlcCByZXNvdXJjZXMgb3IgcHJldmVudCB0aGV5IGJlaW5nIGRlc3Ryb3llZCB3 aGVuDQo+IGd1ZXN0IGlzIHN1c3BlbmRpbmcuIFNvLCBJIGFkZCBhIG5ldyBzdGF0dXMgbmFtZWQg ZnJlZXppbmcgdG8gdmlydGdwdSwNCj4gYW5kIGFkZCBhIG5ldyBjdHJsIG1lc3NhZ2UgVklSVElP X0dQVV9DTURfU1RBVFVTX0ZSRUVaSU5HIHRvIGdldA0KPiBub3RpZmljYXRpb24gZnJvbSBndWVz dC4gSWYgZnJlZXppbmcgaXMgc2V0IHRvIHRydWUsIGFuZCB0aGVuIFFlbXUgd2lsbA0KPiByZWFs aXplIHRoYXQgZ3Vlc3QgaXMgc3VzcGVuZGluZywgaXQgd2lsbCBub3QgZGVzdHJveSByZXNvdXJj ZXMgYW5kIHdpbGwNCj4gbm90IHJlc2V0IHJlbmRlcmVyLiBJZiBmcmVlemluZyBpcyBzZXQgdG8g ZmFsc2UsIFFlbXUgd2lsbCBkbyBpdHMgb3JpZ2luDQo+IGFjdGlvbnMsIGFuZCBoYXMgbm8gb3Ro ZXIgaW1wYWN0aW9uLg0KPiANCj4gQW5kIG5vdywgZGlzcGxheSBjYW4gY29tZSBiYWNrIGFuZCBh cHBsaWNhdGlvbnMgY2FuIGNvbnRpbnVlIHRoZWlyDQo+IHN0YXR1cyBhZnRlciBndWVzdCByZXN1 bWVzLg0KPiANCj4gSmlxaWFuIENoZW4gKDEpOg0KPiAgIHZpcnRncHU6IGRvIG5vdCBkZXN0cm95 IHJlc291cmNlcyB3aGVuIGd1ZXN0IHN1c3BlbmQNCj4gDQo+ICBody9kaXNwbGF5L3ZpcnRpby1n cHUtYmFzZS5jICAgfCAgMyArKw0KPiAgaHcvZGlzcGxheS92aXJ0aW8tZ3B1LWdsLmMgICAgIHwg MTAgKysrKysrLQ0KPiAgaHcvZGlzcGxheS92aXJ0aW8tZ3B1LXZpcmdsLmMgIHwgIDcgKysrKysN Cj4gIGh3L2Rpc3BsYXkvdmlydGlvLWdwdS5jICAgICAgICB8IDU1ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0NCj4gIGh3L3ZpcnRpby92aXJ0aW8uYyAgICAgICAgICAgICB8ICAz ICsrDQo+ICBpbmNsdWRlL2h3L3ZpcnRpby92aXJ0aW8tZ3B1LmggfCAgNiArKysrDQo+ICA2IGZp bGVzIGNoYW5nZWQsIDgxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+IA0KDQotLSAN CkJlc3QgcmVnYXJkcywNCkppcWlhbiBDaGVuLg0K From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582278.911942 (Exim 4.92) (envelope-from ) id 1qUMR9-0003fa-HE; Fri, 11 Aug 2023 07:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582278.911942; Fri, 11 Aug 2023 07:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMR9-0003fT-DU; Fri, 11 Aug 2023 07:19:55 +0000 Received: by outflank-mailman (input) for mailman id 582278; Fri, 11 Aug 2023 07:19:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMR7-0003ey-Gq for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:53 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7705ac4a-3817-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 09:19:52 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 100034EE073F; Fri, 11 Aug 2023 09:19:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7705ac4a-3817-11ee-b284-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 0/6] xen: fix missing headers and static storage duration Date: Fri, 11 Aug 2023 09:19:25 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The files touched by this series contain function or variable definitions with no prior declaration visible, because it's inside an header that is not included or it's not present anywhere. This is a risk in itself, but also violates MISRA C:2012 Rule 8.4, which states the following: "A compatible declaration shall be visible when an object or function with external linkage is defined". The resolution strategies are as follows: 1. make the functions/variables static 2. include the header that contains the compatible declaration, or add one in the header if that's not the case. No functional change. Additional notes: - This series is a continuation of the work done here [1], so the same additional notes apply. [1] https://lore.kernel.org/xen-devel/cover.1691655814.git.nicola.vetrini@bugseng.com/T/#m28da1b5ef8d9a7683937bfc345765e3438b89977 Nicola Vetrini (6): x86/hpet: make variable 'per_cpu__cpu_bc_channel' static x86/setup: add missing headers x86/vm_event: add missing include cpufreq: add missing include of header 'pmstat.h' vpic/msix: make 'get_slot' static drivers/video: make declarations of defined functions available xen/arch/x86/hpet.c | 2 +- xen/arch/x86/include/asm/setup.h | 6 ------ xen/arch/x86/setup.c | 4 +++- xen/arch/x86/vm_event.c | 1 + xen/drivers/cpufreq/cpufreq.c | 1 + xen/drivers/video/vga.c | 9 +-------- xen/drivers/vpci/msix.c | 2 +- xen/include/xen/cpuidle.h | 2 +- xen/include/xen/vga.h | 14 ++++++++++++++ 9 files changed, 23 insertions(+), 18 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:55 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582279.911946 (Exim 4.92) (envelope-from ) id 1qUMR9-0003ic-Qj; Fri, 11 Aug 2023 07:19:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582279.911946; Fri, 11 Aug 2023 07:19:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMR9-0003hx-L7; Fri, 11 Aug 2023 07:19:55 +0000 Received: by outflank-mailman (input) for mailman id 582279; Fri, 11 Aug 2023 07:19:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMR7-0003ey-Ot for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:53 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77448417-3817-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 09:19:53 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 985C04EE0742; Fri, 11 Aug 2023 09:19:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77448417-3817-11ee-b284-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 1/6] x86/hpet: make variable 'per_cpu__cpu_bc_channel' static Date: Fri, 11 Aug 2023 09:19:26 +0200 Message-Id: <5e13888db7b69cee21e5367ce8750fbdc1e22d5c.1691676251.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable is only ever used inside the file where it's defined, therefore it can have static storage. This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence of a declaration prior to the definition. Signed-off-by: Nicola Vetrini Fixes: 3ba523ff957c ("CPUIDLE: enable MSI capable HPET for timer broadcast") --- xen/arch/x86/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c index a2df1c7df401..79c07f6a9e09 100644 --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -49,7 +49,7 @@ static struct hpet_event_channel *__read_mostly hpet_events; /* msi hpet channels used for broadcast */ static unsigned int __read_mostly num_hpets_used; -DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); +static DEFINE_PER_CPU(struct hpet_event_channel *, cpu_bc_channel); unsigned long __initdata hpet_address; int8_t __initdata opt_hpet_legacy_replacement = -1; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:56 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582280.911954 (Exim 4.92) (envelope-from ) id 1qUMRA-0003mb-6J; Fri, 11 Aug 2023 07:19:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582280.911954; Fri, 11 Aug 2023 07:19:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMR9-0003lV-TG; Fri, 11 Aug 2023 07:19:55 +0000 Received: by outflank-mailman (input) for mailman id 582280; Fri, 11 Aug 2023 07:19:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMR8-0003ey-H9 for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:54 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 77998ba3-3817-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 09:19:53 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 2F49E4EE0741; Fri, 11 Aug 2023 09:19:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77998ba3-3817-11ee-b284-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 2/6] x86/setup: add missing headers Date: Fri, 11 Aug 2023 09:19:27 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The missing headers declare variables 'xen_cpuidle' and 'use_invpcid' that are then defined inside the file. This is undesirable and also violates MISRA C:2012 Rule 8.4. Adding suitable "#include"s resolves the issue. The type of the variable 'xen_cpuidle' also changes according to s/s8/int8_t/. Signed-off-by: Nicola Vetrini Fixes: 3eab82196b02 ("x86: PIT broadcast to fix local APIC timer stop issue for Deep C state") Fixes: 63dc135aeaf9 ("x86: invpcid support") --- xen/arch/x86/setup.c | 4 +++- xen/include/xen/cpuidle.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 80ae973d64e4..2bfc1fd00f8c 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -47,10 +47,12 @@ #include /* for generic_apic_probe */ #include #include +#include #include #include #include #include +#include #include #include #include @@ -88,7 +90,7 @@ boolean_param("noapic", skip_ioapic_setup); /* **** Linux config option: propagated to domain0. */ /* xen_cpuidle: xen control cstate. */ -s8 __read_mostly xen_cpuidle = -1; +int8_t __read_mostly xen_cpuidle = -1; boolean_param("cpuidle", xen_cpuidle); #ifndef NDEBUG diff --git a/xen/include/xen/cpuidle.h b/xen/include/xen/cpuidle.h index 521a8deb04c2..705d0c1135f0 100644 --- a/xen/include/xen/cpuidle.h +++ b/xen/include/xen/cpuidle.h @@ -86,7 +86,7 @@ struct cpuidle_governor void (*reflect) (struct acpi_processor_power *dev); }; -extern s8 xen_cpuidle; +extern int8_t xen_cpuidle; extern struct cpuidle_governor *cpuidle_current_governor; bool cpuidle_using_deep_cstate(void); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:57 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582282.911969 (Exim 4.92) (envelope-from ) id 1qUMRB-0004JM-AI; Fri, 11 Aug 2023 07:19:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582282.911969; Fri, 11 Aug 2023 07:19:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRB-0004Gy-4t; Fri, 11 Aug 2023 07:19:57 +0000 Received: by outflank-mailman (input) for mailman id 582282; Fri, 11 Aug 2023 07:19:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRA-00039t-08 for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:56 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77ea5903-3817-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 09:19:54 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id B9CCF4EE0744; Fri, 11 Aug 2023 09:19:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77ea5903-3817-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 3/6] x86/vm_event: add missing include Date: Fri, 11 Aug 2023 09:19:28 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The missing header included by this patch provides declarations for the functions 'vm_event_{fill_regs,set_registers,monitor_next_interrupt}' that are defined in the source file. This also resolves violations of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: adc75eba8b15 ("x86/vm_event: consolidate hvm_event_fill_regs and p2m_vm_event_fill_regs") Fixes: 975efd3baa8d ("introduce VM_EVENT_FLAG_SET_REGISTERS") Fixes: 9864841914c2 ("x86/vm_event: add support for VM_EVENT_REASON_INTERRUPT") --- xen/arch/x86/vm_event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c index 7027c08a926b..499b6b349d79 100644 --- a/xen/arch/x86/vm_event.c +++ b/xen/arch/x86/vm_event.c @@ -20,6 +20,7 @@ #include #include +#include #include /* Implicitly serialized by the domctl lock. */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582283.911977 (Exim 4.92) (envelope-from ) id 1qUMRB-0004Rd-UK; Fri, 11 Aug 2023 07:19:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582283.911977; Fri, 11 Aug 2023 07:19:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRB-0004Ot-JZ; Fri, 11 Aug 2023 07:19:57 +0000 Received: by outflank-mailman (input) for mailman id 582283; Fri, 11 Aug 2023 07:19:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRA-0003ey-J0 for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:56 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78e422eb-3817-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 09:19:56 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 5DBD54EE0745; Fri, 11 Aug 2023 09:19:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78e422eb-3817-11ee-b284-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 6/6] drivers/video: make declarations of defined functions available Date: Fri, 11 Aug 2023 09:19:31 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The declarations for 'vesa_{init,early_init,endboot}' needed by 'xen/drivers/video/vesa.c' and 'fill_console_start_info' in 'vga.c' are now available by moving the relative code inside 'vga.h' and including "" respectively. This also resolves violations of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: ebb26b509f1a ("xen/x86: make VGA support selectable") Fixes: 6d9199bd0f22 ("x86-64: enable hypervisor output on VESA frame buffer") --- xen/arch/x86/include/asm/setup.h | 6 ------ xen/drivers/video/vga.c | 9 +-------- xen/include/xen/vga.h | 14 ++++++++++++++ 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index b0e6a39e2365..dfdd9e555149 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -25,12 +25,6 @@ void subarch_init_memory(void); void init_IRQ(void); -#ifdef CONFIG_VIDEO -void vesa_init(void); -#else -static inline void vesa_init(void) {}; -#endif - int construct_dom0( struct domain *d, const module_t *image, unsigned long image_headroom, diff --git a/xen/drivers/video/vga.c b/xen/drivers/video/vga.c index 0a03508bee60..b62a47e000e7 100644 --- a/xen/drivers/video/vga.c +++ b/xen/drivers/video/vga.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include @@ -54,14 +55,6 @@ string_param("vga", opt_vga); static unsigned int columns, lines; #define ATTRIBUTE 7 -#ifdef CONFIG_X86 -void vesa_early_init(void); -void vesa_endboot(bool_t keep); -#else -#define vesa_early_init() ((void)0) -#define vesa_endboot(x) ((void)0) -#endif - void __init video_init(void) { char *p; diff --git a/xen/include/xen/vga.h b/xen/include/xen/vga.h index f72b63d446b1..ffd73c9db135 100644 --- a/xen/include/xen/vga.h +++ b/xen/include/xen/vga.h @@ -15,4 +15,18 @@ extern struct xen_vga_console_info vga_console_info; #endif +#ifdef CONFIG_X86 +void vesa_early_init(void); +void vesa_endboot(bool_t keep); +#else +#define vesa_early_init() ((void)0) +#define vesa_endboot(x) ((void)0) +#endif + +#ifdef CONFIG_VIDEO +void vesa_init(void); +#else +static inline void vesa_init(void) {}; +#endif + #endif /* _XEN_VGA_H */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:19:58 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582284.911984 (Exim 4.92) (envelope-from ) id 1qUMRC-0004gG-Hx; Fri, 11 Aug 2023 07:19:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582284.911984; Fri, 11 Aug 2023 07:19:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRC-0004cy-A5; Fri, 11 Aug 2023 07:19:58 +0000 Received: by outflank-mailman (input) for mailman id 582284; Fri, 11 Aug 2023 07:19:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRB-00039t-0F for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7842eadc-3817-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 09:19:55 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 47C104EE0743; Fri, 11 Aug 2023 09:19:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7842eadc-3817-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 4/6] cpufreq: add missing include of header 'pmstat.h' Date: Fri, 11 Aug 2023 09:19:29 +0200 Message-Id: <424e0523b9ec68eda5cf5b41a7bb6c980df2a52d.1691676251.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The missing header included by this patch provides a declaration for 'set_px_pminfo' that is visible prior to the definition in this file. This also resolves a violation of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: 452119c09420 ("x86 and ia64: move cpufreq notify code to commone place") --- xen/drivers/cpufreq/cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 2321c7dd07b1..4482bbe53a1e 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:20:00 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:20:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582285.911998 (Exim 4.92) (envelope-from ) id 1qUMRD-00056H-Qt; Fri, 11 Aug 2023 07:19:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582285.911998; Fri, 11 Aug 2023 07:19:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRD-000541-K7; Fri, 11 Aug 2023 07:19:59 +0000 Received: by outflank-mailman (input) for mailman id 582285; Fri, 11 Aug 2023 07:19:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRC-00039t-0I for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 07:19:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78aef6c2-3817-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 09:19:55 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id D4EA64EE0746; Fri, 11 Aug 2023 09:19:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78aef6c2-3817-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini Subject: [XEN PATCH 5/6] vpic/msix: make 'get_slot' static Date: Fri, 11 Aug 2023 09:19:30 +0200 Message-Id: <6ff95436f704c852e6397a584eef65f9d1713999.1691676251.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function can become static since it's used only within this file. This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence of a declaration before the function definition. Signed-off-by: Nicola Vetrini Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X table") --- xen/drivers/vpci/msix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 25bde77586a4..f9df506f29bf 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -223,7 +223,7 @@ static void __iomem *get_table(const struct vpci *vpci, unsigned int slot) return msix->table[slot]; } -unsigned int get_slot(const struct vpci *vpci, unsigned long addr) +static unsigned int get_slot(const struct vpci *vpci, unsigned long addr) { unsigned long pfn = PFN_DOWN(addr); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 07:20:08 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 07:20:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582287.912012 (Exim 4.92) (envelope-from ) id 1qUMRM-0006cq-8L; Fri, 11 Aug 2023 07:20:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582287.912012; Fri, 11 Aug 2023 07:20:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRM-0006bv-2P; Fri, 11 Aug 2023 07:20:08 +0000 Received: by outflank-mailman (input) for mailman id 582287; Fri, 11 Aug 2023 07:20:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRK-0006JH-5W; Fri, 11 Aug 2023 07:20:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRJ-0003EI-UC; Fri, 11 Aug 2023 07:20:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUMRJ-0002I9-J1; Fri, 11 Aug 2023 07:20:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qUMRJ-0006NG-IW; Fri, 11 Aug 2023 07:20:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LTw8ch5s5sfDZNsDaAfHP1nLsWnJV2VGIiKifVOZLEI=; b=viFd8uoTdArpVrbWTtZA1tVE3r 7UQZJMl9ni2A0hO6OapQcABqeFPsjGthOmGReX5ETIW3UANmaa075LjdldtbwIjtR1jM0jA43BqEu 9c+urKr6en1M7hI2Dp2VbhAi/twe17sElUsTKP94SV1HhkOJBuuaxKXNilT1tFpsRRBk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 182260: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=79c18114c7d71f0227abbbb75e24d114483765f7 X-Osstest-Versions-That: xen=56d690efd3ca3c68e1d222f259fb3d216206e8e5 From: osstest service owner Date: Fri, 11 Aug 2023 07:20:05 +0000 flight 182260 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182260/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182241 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 182241 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182241 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182241 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182241 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182241 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 182241 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 182241 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 182241 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182241 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182241 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182241 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 79c18114c7d71f0227abbbb75e24d114483765f7 baseline version: xen 56d690efd3ca3c68e1d222f259fb3d216206e8e5 Last test of basis 182241 2023-08-08 23:10:24 Z 2 days Testing same since 182260 2023-08-10 11:12:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Juergen Gross Julien Grall Michal Orzel Nicola Vetrini Shawn Anastasio Simone Ballarin Stefano Stabellini Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 56d690efd3..79c18114c7 79c18114c7d71f0227abbbb75e24d114483765f7 -> master From xen-devel-bounces@lists.xenproject.org Fri Aug 11 10:24:10 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 10:24:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582369.912104 (Exim 4.92) (envelope-from ) id 1qUPJ7-000306-Q9; Fri, 11 Aug 2023 10:23:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582369.912104; Fri, 11 Aug 2023 10:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPJ7-0002zz-MV; Fri, 11 Aug 2023 10:23:49 +0000 Received: by outflank-mailman (input) for mailman id 582369; Fri, 11 Aug 2023 10:23:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPJ5-0002zt-GJ for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 10:23:47 +0000 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [2a00:1450:4864:20::233]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 24d4bc02-3831-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 12:23:41 +0200 (CEST) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2b9f48b6796so27713271fa.3 for ; Fri, 11 Aug 2023 03:23:41 -0700 (PDT) Received: from [192.168.201.133] ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id k22-20020a2e2416000000b002b9e0aeff68sm800873ljk.95.2023.08.11.03.23.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 03:23:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24d4bc02-3831-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691749421; x=1692354221; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=7iuEY2UnDa0+QqdwZhx+2gFy5aRcIMESe8OuaPJrHSo=; b=IDMSI63tV65pDf3dtRgNNG8BM6Z5hwiYJTRQPRsCr88H8CIl684K64iMOkANC9NSkO kfRP0btMi5V0OGYsH0RB16fnVDArvs5DgEi34t4aDfsgtoJJPGM1wNhWexsByQmrJCww GnhdqZNFmZWiTkHwVwbqpiOH0XvnAv5LDjY0Dg3Cd8K0ZRtOgssemWffZVdsVwDTuCjF rsBB+ajWgW+dPfn6NTJIfJ0ACZUyBo+JhVQUGNIrtc/mNu9ipR4rTRrZO72ihljvs4eJ adrxDiOwiO+ioxn8WOxt4V/tg2yj/Xy7Fi/wTcAPjVMLga0lSQCQPw5zRbAj+5mlOWAf BLdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691749421; x=1692354221; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7iuEY2UnDa0+QqdwZhx+2gFy5aRcIMESe8OuaPJrHSo=; b=JoPMWntqqBslwA6sQ0jVghv/JLU71mBVIdhz7H2VN/O0L4ZWjnStA1qzr0QpHwVx9Y AH8bI84oJ+Co9TAMTMQOQBOeQucWMML5TSD2fsHr9+8CVtApQDuaReS7VEZvxPYLn7Dr igbfA8oY1RoakiboM65on2KVCpZWaciV1HuiXcyDbFY4Log/9oQAHaZe0IdkVuWfJPAf n5Nosh39SjfLPXwkzwaTzLDTvEnRQxNYZeIrzny2t+PrDxeL77+Q6FMHTZXFeji9foUG bOpdmarJ0dBpwx/9Vp0L98w8fKeZVgKqUmoJ0v7wzGMEf65uVMMlq0ZawngXbvdGhEBR 1eeg== X-Gm-Message-State: AOJu0Yxs267J3QKuUY0sgWewhm0NlPZYu3zfF4w8PQ0C3J174TF9GG/D /rV+h2ETNcLxfwzbGcLgcYg= X-Google-Smtp-Source: AGHT+IFzbb1poenr1s4QcsvohzII4Wq13Gd1Bxpl7pkcQ/JdxgurSBPlGmG0LiO8v+mmV1A/pqciwg== X-Received: by 2002:a2e:b60a:0:b0:2b8:3a1e:eec9 with SMTP id r10-20020a2eb60a000000b002b83a1eeec9mr1189876ljn.36.1691749420957; Fri, 11 Aug 2023 03:23:40 -0700 (PDT) Message-ID: Subject: Re: [PATCH v7 2/6] xen/riscv: introduce dummy From: Oleksii To: Jan Beulich Cc: Andrew Cooper , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org Date: Fri, 11 Aug 2023 13:23:39 +0300 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 On Mon, 2023-08-07 at 11:01 +0200, Jan Beulich wrote: > On 03.08.2023 14:05, Oleksii Kurochko wrote: > > will be used in the patch "xen/riscv: introduce > > decode_cause() stuff" and requires >=20 > While as it stands the description is accurate, I don't think that > later > patch has a need to include xen/lib.h anymore. xen/macros.h will do, > I > think. It looks like xen/lib.h should be still included as the code in traps.c uses printk(). >=20 > Also please don't write descriptions in terms of "patches" or more > generally future "commits". Their titles may change, they may > disappear > altogether, etc. Finding such a description later will end up > confusing. >=20 ~ Oleksii From xen-devel-bounces@lists.xenproject.org Fri Aug 11 10:32:21 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 10:32:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582375.912114 (Exim 4.92) (envelope-from ) id 1qUPRJ-0004W0-IC; Fri, 11 Aug 2023 10:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582375.912114; Fri, 11 Aug 2023 10:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPRJ-0004Vt-FX; Fri, 11 Aug 2023 10:32:17 +0000 Received: by outflank-mailman (input) for mailman id 582375; Fri, 11 Aug 2023 10:32:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPRI-0004Vn-Nc for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 10:32:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPRH-00084u-Ie; Fri, 11 Aug 2023 10:32:15 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.207.66]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qUPRH-0002MW-Bn; Fri, 11 Aug 2023 10:32:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ktTYnxaJliQmP6svwaLVJ0Ml4z0+NKivmbjfpX2UNjg=; b=wS0bj8eDd1I8kpL3ndrziL62KM fiQmnYd7K8Yy7bc979XbOiQlYTjA7IguhY9Rq/b1fXWhvOs7imx8xUBgY1B6pGru29WjXIQBrdBBk gKvNdaADgUCROotrzLY00gOwmbo63wKImfL+ThxcjWiCkNNPUGdvE76TAxLVbb1Q2Zcw=; Message-ID: <63f1ba1f-05ec-4400-9804-43948989d550@xen.org> Date: Fri, 11 Aug 2023 11:32:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain Content-Language: en-GB To: Jason Andryuk Cc: xen-devel@lists.xenproject.org, Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20230809103305.30561-1-julien@xen.org> <20230809103305.30561-3-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jason, On 10/08/2023 21:02, Jason Andryuk wrote: > On Wed, Aug 9, 2023 at 6:34 AM Julien Grall wrote: >> >> From: Julien Grall >> >> Currently, libxl will grant IOMEM, I/O port and IRQ permissions when >> a PCI is attached (see pci_add_dm_done()) for all domain types. However, >> the permissions are only revoked for non-HVM domain (see do_pci_remove()). >> >> This means that HVM domains will be left with extra permissions. While >> this look bad on the paper, the IRQ permissions should be revoked >> when the Device Model call xc_physdev_unmap_pirq() and such domain >> cannot directly mapped I/O port and IOMEM regions. Instead, this has to >> be done by a Device Model. >> >> The Device Model can only run in dom0 or PV stubdomain (upstream libxl >> doesn't have support for HVM/PVH stubdomain). >> >> For PV/PVH stubdomain, the permission are properly revoked, so there is >> no security concern. >> >> This leaves dom0. There are two cases: >> 1) Privileged: Anyone gaining access to the Device Model would already >> have large control on the host. >> 2) Deprivileged: PCI passthrough require PHYSDEV operations which >> are not accessible when the Device Model is restricted. >> >> So overall, it is believed that the extra permissions cannot be exploited. >> >> Rework the code so the permissions are all removed for HVM domains. >> This needs to happen after the QEMU has detached the device. So >> the revocation is now moved in a separate function which is called >> from pci_remove_detached(). >> >> Signed-off-by: Julien Grall > > Reviewed-by: Jason Andryuk Thanks for the review! > > With one suggestion below > >> --- >> >> TODO: I am getting a bit confused with the async work in libxl. I am >> not entirely sure whether pci_remove_detached() is the correct place >> to revoke. > > I think the location is fine. > >> TODO: For HVM, we are now getting the following error on detach: >> libxl: error: libxl_pci.c:2009:pci_revoke_permissions: Domain 3:xc_physdev_unmap_pirq irq=23: Invalid argument >> >> This is because the IRQ was unmapped by QEMU. It doesn't feel >> right to skip the call. So maybe we can ignore the error? > > Sounds reasonable. Would be better if we could clearly differentiate > between QEMU already unmapped and some other EINVAL error. The only way I could think is to have a distinct errno in Xen to indicate the PIRQ is not mapped. CCing the x86 maintainers to check if they would be ok with that. > >> --- >> tools/libs/light/libxl_pci.c | 142 ++++++++++++++++++++--------------- >> 1 file changed, 80 insertions(+), 62 deletions(-) >> >> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c >> index 7f5f170e6eb0..f5a4b88eb2c0 100644 >> --- a/tools/libs/light/libxl_pci.c >> +++ b/tools/libs/light/libxl_pci.c >> @@ -1943,6 +1943,79 @@ static void pci_remove_stubdom_done(libxl__egc *egc, >> static void pci_remove_done(libxl__egc *egc, >> pci_remove_state *prs, int rc); >> >> +static void pci_revoke_permissions(libxl__egc *egc, pci_remove_state *prs) >> +{ >> + STATE_AO_GC(prs->aodev->ao); >> + libxl_ctx *ctx = libxl__gc_owner(gc); >> + const libxl_device_pci *pci = &prs->pci; >> + const char *sysfs_path; >> + uint32_t domid = prs->domid; >> + FILE *f; >> + unsigned int start = 0, end = 0, flags = 0, size = 0; > > These variables ... > >> + int irq = 0; >> + int i, rc; >> + >> + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", >> + pci->domain, pci->bus, pci->dev, pci->func); >> + >> + f = fopen(sysfs_path, "r"); >> + if (f == NULL) { >> + LOGED(ERROR, domid, "Couldn't open %s", sysfs_path); >> + goto skip_bar; >> + } >> + >> + for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { > > ... could move into the loop here. You are right. I will respin the patch with this change and whatever we decide for the unmap error. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 11 11:05:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 11:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582382.912133 (Exim 4.92) (envelope-from ) id 1qUPx8-00007V-8v; Fri, 11 Aug 2023 11:05:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582382.912133; Fri, 11 Aug 2023 11:05:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPx8-00007N-6K; Fri, 11 Aug 2023 11:05:10 +0000 Received: by outflank-mailman (input) for mailman id 582382; Fri, 11 Aug 2023 11:05:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPx6-0008Js-Hv for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 11:05:08 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed8acbc8-3836-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 13:05:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 554E921867; Fri, 11 Aug 2023 11:05:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 40B5313592; Fri, 11 Aug 2023 11:05:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kdy/D+EV1mQuRQAAMHmgww (envelope-from ); Fri, 11 Aug 2023 11:05:05 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id B94BAA076F; Fri, 11 Aug 2023 13:05:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed8acbc8-3836-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691751905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5tRGa7YNpy5azfO2DILJGaxnHQqIrHRIuX4HPJpenrQ=; b=nS0o04Ko2eofWDhOvWx6o3T36EV25HqbUFvkN9WMKumyZo3DU5IiWgMskXfjyH4OXEiKYl IITYxvL5Q8pMKkFc8O6biwC3K3TxmcmnzVR3W1NQhsfgztirbY49kzZoor0HytOQKCBlyL GV3cB78+BIPaD5P0M4y2xB0Q495MkAo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691751905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5tRGa7YNpy5azfO2DILJGaxnHQqIrHRIuX4HPJpenrQ=; b=PRu3LFGsOROMaty7jNH51X1wMClD6ZMlY5AdbxYnc0QwtMHxNWZ8s/wVfL1uImLDOQT/Rl cDHfO/YvLXNV1tAw== From: Jan Kara To: Cc: , Christoph Hellwig , Jan Kara , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle Date: Fri, 11 Aug 2023 13:04:31 +0200 Message-Id: <20230810171429.31759-1-jack@suse.cz> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3218; i=jack@suse.cz; h=from:subject:message-id; bh=8um6o7br1koHMcykRc7ml18Y2BSCm69vwpPmgjRXxkk=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBk1hW86qklK68Z0G139b8b61UzO/oV2Y6qvJg1uvDC +JKlEZuJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZNYVvAAKCRCcnaoHP2RA2epoB/ 9Sgdf//aomv8tBKGEg1kRzItWS+CXbN/cjy5B6uL3IUWhEY6vxFg7DsN+znMmPFPOp7X1w/e2PExiA dGNvKiX2BNUyl6ZLFstCZUiXyzlig8pnDHrmrN4lbx3SIS3BHdNJ8igPArMWVDYXlZuosexzFn3fIW ELsTpVpNLZdp6BAxZg4925E1qscyN11eFDJecvW+IrpMA1nHR12Y/AX4zqXWcBT8MPUEiJD1Cnfxfa Leji+h3vOG0k2IQAyfN6R1cj/0POs0zJWvSVK9bZM8IYFIOHr+jpYHi0KEVh62q6NLoQxbMBVEzn9K JsmkBplP7UobjvtEWvfH0EwVENii9z X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Hello, this is a v2 of the patch series which implements the idea of blkdev_get_by_*() calls returning bdev_handle which is then passed to blkdev_put() [1]. This makes the get and put calls for bdevs more obviously matching and allows us to propagate context from get to put without having to modify all the users (again!). In particular I need to propagate used open flags to blkdev_put() to be able count writeable opens and add support for blocking writes to mounted block devices. I'll send that series separately. The series is based on Christian's vfs tree as of yesterday as there is quite some overlap. Patches have passed some reasonable testing - I've tested block changes, md, dm, bcache, xfs, btrfs, ext4, swap. This obviously doesn't cover everything so I'd like to ask respective maintainers to review / test their changes. Thanks! I've pushed out the full branch to: git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle to ease review / testing. Changes since v1: * Rebased on top of current vfs tree * Renamed final functions to bdev_open_by_*() and bdev_release() * Fixed detection of exclusive open in blkdev_ioctl() and blkdev_fallocate() * Fixed swap conversion to properly reinitialize swap_info->bdev_handle * Fixed xfs conversion to not oops with rtdev without logdev * Couple other minor fixups Honza [1] https://lore.kernel.org/all/ZJGNsVDhZx0Xgs2H@infradead.org CC: Alasdair Kergon CC: Andrew Morton CC: Anna Schumaker CC: Chao Yu CC: Christian Borntraeger CC: Coly Li CC: Dave Kleikamp CC: David Sterba CC: dm-devel@redhat.com CC: drbd-dev@lists.linbit.com CC: Gao Xiang CC: Jack Wang CC: Jaegeuk Kim CC: jfs-discussion@lists.sourceforge.net CC: Joern Engel CC: Joseph Qi CC: Kent Overstreet CC: linux-bcache@vger.kernel.org CC: linux-btrfs@vger.kernel.org CC: linux-erofs@lists.ozlabs.org CC: CC: linux-f2fs-devel@lists.sourceforge.net CC: linux-mm@kvack.org CC: linux-mtd@lists.infradead.org CC: linux-nfs@vger.kernel.org CC: linux-nilfs@vger.kernel.org CC: linux-nvme@lists.infradead.org CC: linux-pm@vger.kernel.org CC: linux-raid@vger.kernel.org CC: linux-s390@vger.kernel.org CC: linux-scsi@vger.kernel.org CC: linux-xfs@vger.kernel.org CC: "Md. Haris Iqbal" CC: Mike Snitzer CC: Minchan Kim CC: ocfs2-devel@oss.oracle.com CC: reiserfs-devel@vger.kernel.org CC: Sergey Senozhatsky CC: Song Liu CC: Sven Schnelle CC: target-devel@vger.kernel.org CC: Ted Tso CC: Trond Myklebust CC: xen-devel@lists.xenproject.org Previous versions: Link: http://lore.kernel.org/r/20230629165206.383-1-jack@suse.cz # v1 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 11:05:14 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 11:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582381.912124 (Exim 4.92) (envelope-from ) id 1qUPx7-0008KA-2O; Fri, 11 Aug 2023 11:05:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582381.912124; Fri, 11 Aug 2023 11:05:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPx6-0008K3-W0; Fri, 11 Aug 2023 11:05:08 +0000 Received: by outflank-mailman (input) for mailman id 582381; Fri, 11 Aug 2023 11:05:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUPx5-0008Js-UF for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 11:05:08 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed8acbd5-3836-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 13:05:06 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BD1191F891; Fri, 11 Aug 2023 11:05:05 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B031C139FD; Fri, 11 Aug 2023 11:05:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id P7n/KuEV1mRGRQAAMHmgww (envelope-from ); Fri, 11 Aug 2023 11:05:05 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E0560A077F; Fri, 11 Aug 2023 13:05:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed8acbd5-3836-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691751905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4+jKqQ1x0Ey1yIHBqwsn99vq9xGiNmltJzcj4Snsx4=; b=NymZwWCmDVPf+oAdkRp6Fd3W33uCeIVi+mDXP+gMel/Ag9XuCoE75HkGLq87VAtzoY82Pm NRBGYqUSqo7VuWbrTkTzLCA0urGSKJ/5ochKyN1G0WVh4j4TjzEhOXMakth4zvXTMyjtXs phXifH8SKsqXtabIeHdhAQ6M8qKgMH4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691751905; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4+jKqQ1x0Ey1yIHBqwsn99vq9xGiNmltJzcj4Snsx4=; b=GsSZk6dIGu7xkC6a1rGWdt52tNx1adZtbaEtcaKG74D2xlinnFSyKWvF4DBqQnfyI5MBxR hwouiESDYmn+fWDw== From: Jan Kara To: Cc: , Christoph Hellwig , Jan Kara , xen-devel@lists.xenproject.org Subject: [PATCH 07/29] xen/blkback: Convert to bdev_open_by_dev() Date: Fri, 11 Aug 2023 13:04:38 +0200 Message-Id: <20230811110504.27514-7-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230810171429.31759-1-jack@suse.cz> References: <20230810171429.31759-1-jack@suse.cz> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6152; i=jack@suse.cz; h=from:subject; bh=BtKISSNjUPlIJ2mx01CaoHxKal+UUOpgJzDPeV+Tjng=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBk1hXJTAApujvhW+MJCl3UP6VxhTukhoQX0oarVPIN qZbOtKeJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZNYVyQAKCRCcnaoHP2RA2YTBCA CGxviiVkdtcZrheoDeTPAHsM7pySrLUYJzmmOtb66fig1K8eNsZaga/HYJbzFzqEARVS6BHDnBMlS3 O6ZPWXyrpodgPwsFXMfYq75Qm4aYI/emJOyrnM3Eg5TRgBaYBgBwKimM3309HZVfpmKEXA+l2JqpnN N1GFvI9ldoBqGQfiATVauUfxihdiK0b7Ci5P6Q6B/FABpjHt+kD2mOftlwneWhBtpWzPbo77dCeIq6 U5qLYZLH8KswL1ZMes46IO8lZ6pC8GnmqswRKSRwsLfsX3pCaY5rhmakO5hIhf6L3AcqUD519hed5z L1KRtGnxJ+LiyTUMYbQ1H0ZIb4KQeO X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Convert xen/blkback to use bdev_open_by_dev() and pass the handle around. CC: xen-devel@lists.xenproject.org Signed-off-by: Jan Kara --- drivers/block/xen-blkback/blkback.c | 4 +-- drivers/block/xen-blkback/common.h | 4 +-- drivers/block/xen-blkback/xenbus.c | 40 +++++++++++++++-------------- 3 files changed, 25 insertions(+), 23 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index c362f4ad80ab..4defd7f387c7 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -465,7 +465,7 @@ static int xen_vbd_translate(struct phys_req *req, struct xen_blkif *blkif, } req->dev = vbd->pdevice; - req->bdev = vbd->bdev; + req->bdev = vbd->bdev_handle->bdev; rc = 0; out: @@ -969,7 +969,7 @@ static int dispatch_discard_io(struct xen_blkif_ring *ring, int err = 0; int status = BLKIF_RSP_OKAY; struct xen_blkif *blkif = ring->blkif; - struct block_device *bdev = blkif->vbd.bdev; + struct block_device *bdev = blkif->vbd.bdev_handle->bdev; struct phys_req preq; xen_blkif_get(blkif); diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h index 40f67bfc052d..5ff50e76cee5 100644 --- a/drivers/block/xen-blkback/common.h +++ b/drivers/block/xen-blkback/common.h @@ -221,7 +221,7 @@ struct xen_vbd { unsigned char type; /* phys device that this vbd maps to. */ u32 pdevice; - struct block_device *bdev; + struct bdev_handle *bdev_handle; /* Cached size parameter. */ sector_t size; unsigned int flush_support:1; @@ -360,7 +360,7 @@ struct pending_req { }; -#define vbd_sz(_v) bdev_nr_sectors((_v)->bdev) +#define vbd_sz(_v) bdev_nr_sectors((_v)->bdev_handle->bdev) #define xen_blkif_get(_b) (atomic_inc(&(_b)->refcnt)) #define xen_blkif_put(_b) \ diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index bb66178c432b..e34219ea2b05 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -81,7 +81,7 @@ static void xen_update_blkif_status(struct xen_blkif *blkif) int i; /* Not ready to connect? */ - if (!blkif->rings || !blkif->rings[0].irq || !blkif->vbd.bdev) + if (!blkif->rings || !blkif->rings[0].irq || !blkif->vbd.bdev_handle) return; /* Already connected? */ @@ -99,12 +99,13 @@ static void xen_update_blkif_status(struct xen_blkif *blkif) return; } - err = sync_blockdev(blkif->vbd.bdev); + err = sync_blockdev(blkif->vbd.bdev_handle->bdev); if (err) { xenbus_dev_error(blkif->be->dev, err, "block flush"); return; } - invalidate_inode_pages2(blkif->vbd.bdev->bd_inode->i_mapping); + invalidate_inode_pages2( + blkif->vbd.bdev_handle->bdev->bd_inode->i_mapping); for (i = 0; i < blkif->nr_rings; i++) { ring = &blkif->rings[i]; @@ -472,9 +473,9 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev) static void xen_vbd_free(struct xen_vbd *vbd) { - if (vbd->bdev) - blkdev_put(vbd->bdev, NULL); - vbd->bdev = NULL; + if (vbd->bdev_handle) + bdev_release(vbd->bdev_handle); + vbd->bdev_handle = NULL; } static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, @@ -482,7 +483,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, int cdrom) { struct xen_vbd *vbd; - struct block_device *bdev; + struct bdev_handle *bdev_handle; vbd = &blkif->vbd; vbd->handle = handle; @@ -491,17 +492,17 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, vbd->pdevice = MKDEV(major, minor); - bdev = blkdev_get_by_dev(vbd->pdevice, vbd->readonly ? + bdev_handle = bdev_open_by_dev(vbd->pdevice, vbd->readonly ? BLK_OPEN_READ : BLK_OPEN_WRITE, NULL, NULL); - if (IS_ERR(bdev)) { + if (IS_ERR(bdev_handle)) { pr_warn("xen_vbd_create: device %08x could not be opened\n", vbd->pdevice); return -ENOENT; } - vbd->bdev = bdev; - if (vbd->bdev->bd_disk == NULL) { + vbd->bdev_handle = bdev_handle; + if (vbd->bdev_handle->bdev->bd_disk == NULL) { pr_warn("xen_vbd_create: device %08x doesn't exist\n", vbd->pdevice); xen_vbd_free(vbd); @@ -509,14 +510,14 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, } vbd->size = vbd_sz(vbd); - if (cdrom || disk_to_cdi(vbd->bdev->bd_disk)) + if (cdrom || disk_to_cdi(vbd->bdev_handle->bdev->bd_disk)) vbd->type |= VDISK_CDROM; - if (vbd->bdev->bd_disk->flags & GENHD_FL_REMOVABLE) + if (vbd->bdev_handle->bdev->bd_disk->flags & GENHD_FL_REMOVABLE) vbd->type |= VDISK_REMOVABLE; - if (bdev_write_cache(bdev)) + if (bdev_write_cache(bdev_handle->bdev)) vbd->flush_support = true; - if (bdev_max_secure_erase_sectors(bdev)) + if (bdev_max_secure_erase_sectors(bdev_handle->bdev)) vbd->discard_secure = true; pr_debug("Successful creation of handle=%04x (dom=%u)\n", @@ -569,7 +570,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info struct xen_blkif *blkif = be->blkif; int err; int state = 0; - struct block_device *bdev = be->blkif->vbd.bdev; + struct block_device *bdev = be->blkif->vbd.bdev_handle->bdev; if (!xenbus_read_unsigned(dev->nodename, "discard-enable", 1)) return; @@ -930,15 +931,16 @@ static void connect(struct backend_info *be) goto abort; } err = xenbus_printf(xbt, dev->nodename, "sector-size", "%lu", - (unsigned long) - bdev_logical_block_size(be->blkif->vbd.bdev)); + (unsigned long)bdev_logical_block_size( + be->blkif->vbd.bdev_handle->bdev)); if (err) { xenbus_dev_fatal(dev, err, "writing %s/sector-size", dev->nodename); goto abort; } err = xenbus_printf(xbt, dev->nodename, "physical-sector-size", "%u", - bdev_physical_block_size(be->blkif->vbd.bdev)); + bdev_physical_block_size( + be->blkif->vbd.bdev_handle->bdev)); if (err) xenbus_dev_error(dev, err, "writing %s/physical-sector-size", dev->nodename); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Aug 11 11:54:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 11:54:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582394.912144 (Exim 4.92) (envelope-from ) id 1qUQiU-0005wD-Qp; Fri, 11 Aug 2023 11:54:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582394.912144; Fri, 11 Aug 2023 11:54:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUQiU-0005w6-Mk; Fri, 11 Aug 2023 11:54:06 +0000 Received: by outflank-mailman (input) for mailman id 582394; Fri, 11 Aug 2023 11:54:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUQiS-0005vw-W2; Fri, 11 Aug 2023 11:54:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUQiS-0001Wv-OO; Fri, 11 Aug 2023 11:54:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUQiS-0007eG-Cy; Fri, 11 Aug 2023 11:54:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qUQiS-0002yv-CQ; Fri, 11 Aug 2023 11:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ic68M7yjbs/1Z+smCsSzmQkwWNW+zZ4uXWIbDcSc3x4=; b=hC7BSnue2bC0ISFe+hVyHnfn2P +HylgtVyxn2doqoGFz+Ma3mBWDsU6ujXsxhcKC1WsEwyy+5cp5gpAikOxqOcxwuur+kQ8rW7/QuKv ZV8JBucJq3hQ6L7MzRkEMBVf1lpUhRglyZE28Yxk7S2XRJgEpF2tylyi4IPTUktrl/bo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 182273: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a9a3b432a87b27e4debd6f80f14e2cfc9f52218c X-Osstest-Versions-That: xen=c6bda36af0b992d5d2042efd6cc36592fb037a1d From: osstest service owner Date: Fri, 11 Aug 2023 11:54:04 +0000 flight 182273 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182273/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a9a3b432a87b27e4debd6f80f14e2cfc9f52218c baseline version: xen c6bda36af0b992d5d2042efd6cc36592fb037a1d Last test of basis 182268 2023-08-11 03:00:28 Z 0 days Testing same since 182273 2023-08-11 09:02:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Nicola Vetrini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c6bda36af0..a9a3b432a8 a9a3b432a87b27e4debd6f80f14e2cfc9f52218c -> smoke From xen-devel-bounces@lists.xenproject.org Fri Aug 11 12:28:27 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 12:28:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582405.912160 (Exim 4.92) (envelope-from ) id 1qURFY-00018F-DZ; Fri, 11 Aug 2023 12:28:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582405.912160; Fri, 11 Aug 2023 12:28:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURFY-000188-9j; Fri, 11 Aug 2023 12:28:16 +0000 Received: by outflank-mailman (input) for mailman id 582405; Fri, 11 Aug 2023 12:28:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURFU-000182-2V for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 12:28:15 +0000 Received: from bombadil.infradead.org (bombadil.infradead.org [2607:7c80:54:3::133]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87ccd938-3842-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 14:28:10 +0200 (CEST) Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qUREm-00Abyw-17; Fri, 11 Aug 2023 12:27:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87ccd938-3842-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=96Jyxa0hgrG24aZgu2ilDmsPaDJbIFT8CvAcqFGq7ak=; b=Lt8QMt/qiwPklQXJKNxAAayl50 ejm5z3TauQQgWXDYeiy6ev7CoxuktCUjLml+tQTXB0FrmwYo9bGjhm2G8bwiVtr2qWkYfM3c8FNl1 cPDaz7ayPa6vktH3ev1ZeHUse0hr9sV3dSKzn62142iTuA8TTM4tDaiYAHOFhJAm7nP3aQxRbODoe cl8s2GHmVFeXScu6jrXcZHGDTmN2udO8XZ0pPwfpsd5QoOiRLOiFHXD6KYR9f2MEyvA/KeT9RzHmF DIvDgADu/AxqynsuMYC3hcwdLyXOsBeZQBLnrFNVOoRqDCMnS+8kcWICKZ1ml8I/4TT3bYAOcmKWy N15IsxAA==; Date: Fri, 11 Aug 2023 05:27:28 -0700 From: Christoph Hellwig To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle Message-ID: References: <20230810171429.31759-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810171429.31759-1-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Except for a mostly cosmetic nitpick this looks good to me: Acked-by: Christoph Hellwig That's not eactly the deep review I'd like to do, but as I'm about to head out for vacation that's probably as good as it gets. From xen-devel-bounces@lists.xenproject.org Fri Aug 11 12:57:03 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 12:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582411.912170 (Exim 4.92) (envelope-from ) id 1qURhA-0004Yv-IX; Fri, 11 Aug 2023 12:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582411.912170; Fri, 11 Aug 2023 12:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURhA-0004Yo-Fx; Fri, 11 Aug 2023 12:56:48 +0000 Received: by outflank-mailman (input) for mailman id 582411; Fri, 11 Aug 2023 12:56:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURh8-0004Yi-T5 for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 12:56:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURh8-0002sY-Gi; Fri, 11 Aug 2023 12:56:46 +0000 Received: from 54-240-197-234.amazon.com ([54.240.197.234] helo=[192.168.207.66]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1qURh8-0007rc-8t; Fri, 11 Aug 2023 12:56:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VmQAQAWH4nWRtdIo8DizpFUyoelXvU2eEqiSTFWHJYM=; b=RcWBvXDQuJ7TnFR/gimuJEqNXy d9aF/i8cgoWaUD4fuJwAFtfrFqBSOxjtsT/nddAvRr0Hiz1Ws9UCt2+O0ptphKIzu90XJZD+QSD1Z YjgV685AJ4xm9oc4TkN5jko2v0eODLyy3+7+bTbLNVUCl9I93khaejJULTFmffpLMCGk=; Message-ID: Date: Fri, 11 Aug 2023 13:56:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h Content-Language: en-GB To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, rahul.singh@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230808080010.3858575-1-luca.fancellu@arm.com> <20230808080010.3858575-3-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20230808080010.3858575-3-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 08/08/2023 09:00, Luca Fancellu wrote: > Add asm/domain.h that is defining the type 'enum domain_type', it > is needed on arm64 build where this type is used for a member of > the structure kernel_info. I read "needed" as in it Xen build is broken. But AFAIK, this is more a latent issue if someone else want to include the header. Is that correct? If so, how about: The 'enum domain_type' is defined by 'asm/domain.h' which is not included (directly or indirectly) by 'asm/kernel.h'. This currently doesn't break the compilation because asm/domain.h will included by the user of 'kernel.h'. But it would be better to avoid relying on it. So add the include in 'asm/domain.h'. > Fixes: 66e994a5e74f ("xen: arm64: add guest type to domain field.") While we aim to have header self-contained, this has never been a guarantee in Xen. So I would argue this is not a fix in the sense it someone would want to ingest it in there tree. Cheers, > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/include/asm/kernel.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h > index 4617cdc83bac..0a23e86c2d37 100644 > --- a/xen/arch/arm/include/asm/kernel.h > +++ b/xen/arch/arm/include/asm/kernel.h > @@ -7,6 +7,7 @@ > #define __ARCH_ARM_KERNEL_H__ > > #include > +#include > #include > > /* -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Aug 11 13:03:53 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 13:03:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582417.912180 (Exim 4.92) (envelope-from ) id 1qURnx-000662-AG; Fri, 11 Aug 2023 13:03:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582417.912180; Fri, 11 Aug 2023 13:03:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURnx-00065v-6l; Fri, 11 Aug 2023 13:03:49 +0000 Received: by outflank-mailman (input) for mailman id 582417; Fri, 11 Aug 2023 13:03:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURnw-00065l-Ls; Fri, 11 Aug 2023 13:03:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURnw-000329-Dm; Fri, 11 Aug 2023 13:03:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qURnv-0001tp-UZ; Fri, 11 Aug 2023 13:03:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1qURnv-0006HD-U9; Fri, 11 Aug 2023 13:03:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KmwnWzKr/Lf+f4sdO6At9MuZtvjbCE1mXLJlQJthVMY=; b=0B0mYqKbZsUge4keO/gJKdI2jx vdc/Dr2ulSHVT5Cah/aaN7UxwvqlCiQJVjUn/H40QdrViBp9zQcHkkIt5OflM2RM367TKxUXg6lHm XxiFSyg6FOa/dgChq+m0l55RXdzF/Ua0g3Zqacf296TM9WRd13aklKuUaL3FbtaKbVlQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 182263: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=64d3be986f9e2379bc688bf1d0aca0557e0035ca X-Osstest-Versions-That: qemuu=32e07fddc6d989dc5fdff4f9c9e47cb1f3911904 From: osstest service owner Date: Fri, 11 Aug 2023 13:03:47 +0000 flight 182263 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182263/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 182242 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 182242 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 182242 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 182242 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 182242 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 182242 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182242 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 182242 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 64d3be986f9e2379bc688bf1d0aca0557e0035ca baseline version: qemuu 32e07fddc6d989dc5fdff4f9c9e47cb1f3911904 Last test of basis 182242 2023-08-09 00:10:47 Z 2 days Testing same since 182263 2023-08-10 16:32:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ankit Kumar Helge Deller Ilya Leoshkevich Klaus Jensen Richard Henderson Stafford Horne jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 32e07fddc6..64d3be986f 64d3be986f9e2379bc688bf1d0aca0557e0035ca -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Aug 11 13:41:20 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 13:41:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582426.912192 (Exim 4.92) (envelope-from ) id 1qUSO8-00023h-4M; Fri, 11 Aug 2023 13:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582426.912192; Fri, 11 Aug 2023 13:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUSO8-00023a-1g; Fri, 11 Aug 2023 13:41:12 +0000 Received: by outflank-mailman (input) for mailman id 582426; Fri, 11 Aug 2023 13:41:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUSO7-00023U-4w for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 13:41:11 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20608.outbound.protection.outlook.com [2a01:111:f400:7e1b::608]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b5be010a-384c-11ee-b284-6b7b168915f2; Fri, 11 Aug 2023 15:41:01 +0200 (CEST) Received: from DUZPR01CA0317.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::27) by AM9PR08MB6178.eurprd08.prod.outlook.com (2603:10a6:20b:2db::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19; Fri, 11 Aug 2023 13:40:53 +0000 Received: from DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4ba:cafe::2c) by DUZPR01CA0317.outlook.office365.com (2603:10a6:10:4ba::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.31 via Frontend Transport; Fri, 11 Aug 2023 13:40:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT015.mail.protection.outlook.com (100.127.142.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.19 via Frontend Transport; Fri, 11 Aug 2023 13:40:52 +0000 Received: ("Tessian outbound 0b7d6027328f:v175"); Fri, 11 Aug 2023 13:40:52 +0000 Received: from 39db14bd1755.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 14EEAE9E-1CA2-495B-904A-EEE56D2FEB9F.1; Fri, 11 Aug 2023 13:40:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 39db14bd1755.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Aug 2023 13:40:41 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com (2603:10a6:20b:8f::22) by DB9PR08MB9755.eurprd08.prod.outlook.com (2603:10a6:10:460::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Fri, 11 Aug 2023 13:40:39 +0000 Received: from AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a]) by AM6PR08MB3749.eurprd08.prod.outlook.com ([fe80::4c7d:6a1:e742:3b1a%4]) with mapi id 15.20.6652.029; Fri, 11 Aug 2023 13:40:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5be010a-384c-11ee-b284-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQfkcMShEh69JqDG4f+QFUhttAHBQxbmuASOiHoiTqY=; b=aBJHnaKgI/Yahpu4tQ6K+Cxjen4fEpFDkVqh7F/J5aDohepbNlw3b/0oRY6AVst3XmQrzjsxdt+dky34HFLQ0hFJ5ajfd3puN5j5sU49HgfzlkYsgEUsoTVsy8Jd3TgwfRR9bVIZmQBT7ntT5vWWwBO32n5HBtTG7aA9Ehpzo8c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3afc0bbbbf87df7a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzMvbIlWFKobRRwNlTG7iDmURJ1lrxNm9RwVnO8CMliITZuwHrGesU1jsR0LxVgMsX2QgdtaWtNfYcqptOnHxZSFCxFOCW0eFvxq1eTWYRaNAZmMcOBNTXjbRagr/zn7r7nNZrOQu1QXlwabs92q33vgLcfrYqU+6o1FyUU2A9AT/nC4CU1J0Gig/Cp8eHqO3cdqY+ilek+qol2uYWOlqJpbn4DHpZ9PepkLIJUuZV2jXAzWu8K+GmAyc8Qu8FgwlvmIXwUuvdEHl4j2EHo0tsw6LNjJZTOy2mpDSBzjc2YNY1gfCJ6ay8XQiG9oSu5f8DwkHfkVSgwr6Zw5A3hBuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KQfkcMShEh69JqDG4f+QFUhttAHBQxbmuASOiHoiTqY=; b=Fp0hbRSx8LORZgVCgBw5AFFwwmt5Fk041JiskCkSTWAVqizPlyGLKcFsCgRkZJwuwSCeESJmdqd8krvN1kbIlDDTwYk+q8b+QDGltakGdSQcM93Rt4L0VxsZkvQc3Xq4qHMw26L5/0EL63ExmcZwoPbOKz7xr4+O12e/nH3oZFjwdHY5ZunZ1CrPsE1gulz8WqQoD70h8oXUs7Iw8R0inYL3D3MftZPb0efGzv5mWY4D6gzCFYer3vonH1Ni+G2z2CRuKNXxBgJolCL8D9XErZynHYmkuec8yvOjr6Qm+1XQcvEGMK121PG9tmrr8dKLFu/5toZLES/ZYIqYYl7WCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQfkcMShEh69JqDG4f+QFUhttAHBQxbmuASOiHoiTqY=; b=aBJHnaKgI/Yahpu4tQ6K+Cxjen4fEpFDkVqh7F/J5aDohepbNlw3b/0oRY6AVst3XmQrzjsxdt+dky34HFLQ0hFJ5ajfd3puN5j5sU49HgfzlkYsgEUsoTVsy8Jd3TgwfRR9bVIZmQBT7ntT5vWWwBO32n5HBtTG7aA9Ehpzo8c= From: Luca Fancellu To: Julien Grall CC: Xen-devel , Wei Chen , Rahul Singh , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h Thread-Topic: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h Thread-Index: AQHZyc51AtDCvMz7Yk+h8v6wea9TNK/lEvIAgAAMOAA= Date: Fri, 11 Aug 2023 13:40:39 +0000 Message-ID: <3C46ADAD-477D-46BB-BCCB-81C3198517E5@arm.com> References: <20230808080010.3858575-1-luca.fancellu@arm.com> <20230808080010.3858575-3-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3731.700.6) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AM6PR08MB3749:EE_|DB9PR08MB9755:EE_|DBAEUR03FT015:EE_|AM9PR08MB6178:EE_ X-MS-Office365-Filtering-Correlation-Id: 6da6726b-ab14-4233-7b87-08db9a7094ff x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DhWzsPFQhEcvlm2sRbB6oOerGVSvxOFY4tr/z5aMI6cSQRzZSdeBLDpJUXKFs1u/6PVkPeQSroKIiuTSZuTMk39HW2emvhadZUJ0LCl7o8CrnyyOQBJ1pRXsxjXKqOztsTXf+PbbHDSjwvqn+gKthZWYISrvA4tNcr8b+dXlqgoVG50DIbJj9CcUFIzGlVR5oHdRHWeJWziEd5qZo2Gp89Sk29xVDt06IUWfxpvk4ucNOhapKWb9bGg03astCAIPZb3lq75NmntiHAIdzLU/M+6BEVYsiAPWV+JJlyjza5vNaZIL9gQS+9WbW10UHCNMWHk06/XkoCRSf7uWiJllwPlY7tJOlZHktA8ElOvY+YHKHS13NF7zlSk19FIt3ijvqLh5Dxc7V/FU4+PwIb9VdgMJPNihJLXAkL3UWWHKp17aDv6rHmcprMVq3QY22frOtJOQ3FFc9CgwlkaGSRSGr3RlU8fbvn4tclHZ3bz2EjfgStAEyMABMcA7S8yBDVtXeollO4XBPxBdeJMkGqFYwTlLx2k33IwLAozg8arhhEV3ArATS1z3h9zrAbfeSFY8ssOokmrMBU8urkv0g/eePkhVK+4EdAbSZmZ1Jugeg77076wb23I8d1r4kZWvZzcyETaA/zgWzBgS+k8nTAiIJQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3749.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(396003)(136003)(376002)(366004)(39860400002)(451199021)(1800799006)(186006)(316002)(6512007)(478600001)(2616005)(38070700005)(5660300002)(6486002)(76116006)(64756008)(66556008)(66946007)(66446008)(66476007)(86362001)(8936002)(33656002)(41300700001)(8676002)(6916009)(71200400001)(91956017)(4326008)(122000001)(36756003)(2906002)(53546011)(6506007)(26005)(54906003)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9755 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: df77153c-9988-4d95-dc50-08db9a708d11 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uoiSakOLJu4PYbbnPQV9yvrdAKVyPsofAYU69EsKsHiVyZy4wgGVXGJ2B9XDa3vTeigvzM0EGpRufG8mfUjYM/wA1srzG2JoqESuDph48ZT+Z/zpWYGBl8htjhlQ4Zr5egSOkWyuv503crDsme5nFVJ49tWyUT02h5Ns+KSzD0jORb03JdbRlpyFYhXR9FWYmreXCUazJUQBio1znNQ2R+14ilgJYnfuKny3dE3GBdLWzPJW55bAGN64C72axS/JUVk3WjtXdd+KESoLaOIN89d4YyMUZS+dV/NefOEXzd6Ju6kjKxLehep9hSqfl/M0kt7q3r7X2q0M8SoLjC3ojiBBddNZZZK3ej9029luoADIUEW4CNoe6eNwGk9LgN45pyOFsr6VmlLY1Znt1WLlBDzzo7QswJMXo7C0y9ZtIKWlmaef7eCL4t2XZkzWE06Xymcrkt1u4hRKPu63ZlfLj2LtH4ZesL7b2Gacy7KP2FuEG9/QosxjOhBcT8p77sjtaBIYgyveHrmDIB9cVB8G2zNC4zbOGT6+2CUJLmpJeuXr7MfJsZayDCIrSacq+Uun2Rg+q4UOOuCZcd+F7eZ/Lt5sVfmb3V3FGr+h6xUfGgy3IJn1o4SWImSvKtuW1Wkm1y6OzPVdu4LcCF4AM1zLgtTROzDZ/5mICYRH1JTrAclxQK+YwqMzJ3dqaPYXsDZK1fH7oHroMXnMk+diTZZJJk9EsuKDgMj1WUV9T+VXq8UlHGHP7gRbi3kju1MuomcC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(346002)(396003)(136003)(82310400008)(1800799006)(186006)(451199021)(40470700004)(36840700001)(46966006)(356005)(53546011)(81166007)(82740400003)(336012)(6512007)(6506007)(107886003)(26005)(36860700001)(47076005)(2616005)(41300700001)(40460700003)(36756003)(2906002)(478600001)(54906003)(8676002)(86362001)(5660300002)(33656002)(8936002)(6486002)(6862004)(4326008)(70206006)(40480700001)(316002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2023 13:40:52.9686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6da6726b-ab14-4233-7b87-08db9a7094ff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6178 DQoNCj4gT24gMTEgQXVnIDIwMjMsIGF0IDEzOjU2LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBPbiAwOC8wOC8yMDIzIDA5OjAwLCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4gQWRkIGFzbS9kb21haW4uaCB0aGF0IGlzIGRlZmluaW5n IHRoZSB0eXBlICdlbnVtIGRvbWFpbl90eXBlJywgaXQNCj4+IGlzIG5lZWRlZCBvbiBhcm02NCBi dWlsZCB3aGVyZSB0aGlzIHR5cGUgaXMgdXNlZCBmb3IgYSBtZW1iZXIgb2YNCj4+IHRoZSBzdHJ1 Y3R1cmUga2VybmVsX2luZm8uDQo+IA0KPiBJIHJlYWQgIm5lZWRlZCIgYXMgaW4gaXQgWGVuIGJ1 aWxkIGlzIGJyb2tlbi4gQnV0IEFGQUlLLCB0aGlzIGlzIG1vcmUgYSBsYXRlbnQgaXNzdWUgaWYg c29tZW9uZSBlbHNlIHdhbnQgdG8gaW5jbHVkZSB0aGUgaGVhZGVyLiBJcyB0aGF0IGNvcnJlY3Q/ DQoNClllcyBjb3JyZWN0DQoNCj4gDQo+IElmIHNvLCBob3cgYWJvdXQ6DQo+IA0KPiBUaGUgJ2Vu dW0gZG9tYWluX3R5cGUnIGlzIGRlZmluZWQgYnkgJ2FzbS9kb21haW4uaCcgd2hpY2ggaXMgbm90 IGluY2x1ZGVkIChkaXJlY3RseSBvciBpbmRpcmVjdGx5KSBieSAnYXNtL2tlcm5lbC5oJy4NCj4g DQo+IFRoaXMgY3VycmVudGx5IGRvZXNuJ3QgYnJlYWsgdGhlIGNvbXBpbGF0aW9uIGJlY2F1c2Ug YXNtL2RvbWFpbi5oIHdpbGwgaW5jbHVkZWQgYnkgdGhlIHVzZXIgb2YgJ2tlcm5lbC5oJy4gQnV0 IGl0IHdvdWxkIGJlIGJldHRlciB0byBhdm9pZCByZWx5aW5nIG9uIGl0LiBTbyBhZGQgdGhlIGlu Y2x1ZGUgaW4gJ2FzbS9kb21haW4uaCcuDQoNClllYWggbXVjaCBiZXR0ZXIsIHNob3VsZCBJIHB1 c2ggYSB2Mj8NCg0KPiANCj4+IEZpeGVzOiA2NmU5OTRhNWU3NGYgKCJ4ZW46IGFybTY0OiBhZGQg Z3Vlc3QgdHlwZSB0byBkb21haW4gZmllbGQuIikNCj4gDQo+IFdoaWxlIHdlIGFpbSB0byBoYXZl IGhlYWRlciBzZWxmLWNvbnRhaW5lZCwgdGhpcyBoYXMgbmV2ZXIgYmVlbiBhIGd1YXJhbnRlZSBp biBYZW4uIFNvIEkgd291bGQgYXJndWUgdGhpcyBpcyBub3QgYSBmaXggaW4gdGhlIHNlbnNlIGl0 IHNvbWVvbmUgd291bGQgd2FudCB0byBpbmdlc3QgaXQgaW4gdGhlcmUgdHJlZS4NCg0KT2sgSSBz ZWUsIEkgdGhvdWdodCBpdCBjb3VsZCBiZSBsaW5rZWQgdG8gdGhlIGlzc3VlIGFib3V0IHNvcnRp bmcgaGVhZGVycyB0aGF0IGxlZCB0byBidWlsZCBicmVha2FnZSwgYnV0IEnigJl2ZQ0Kbm90IGlu dmVzdGlnYXRlZCBmdXJ0aGVyIHNvIEkgd291bGQgYmUgb2sgdG8gZHJvcCB0aGUgRml4ZXM6DQoN Cj4gDQo+IENoZWVycywNCj4gDQo+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNh LmZhbmNlbGx1QGFybS5jb20+DQo+PiAtLS0NCj4+ICB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20v a2VybmVsLmggfCAxICsNCj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20va2VybmVsLmggYi94ZW4vYXJjaC9h cm0vaW5jbHVkZS9hc20va2VybmVsLmgNCj4+IGluZGV4IDQ2MTdjZGM4M2JhYy4uMGEyM2U4NmMy ZDM3IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNtL2tlcm5lbC5oDQo+ PiArKysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20va2VybmVsLmgNCj4+IEBAIC03LDYgKzcs NyBAQA0KPj4gICNkZWZpbmUgX19BUkNIX0FSTV9LRVJORUxfSF9fDQo+PiAgICAjaW5jbHVkZSA8 eGVuL2RldmljZV90cmVlLmg+DQo+PiArI2luY2x1ZGUgPGFzbS9kb21haW4uaD4NCj4+ICAjaW5j bHVkZSA8YXNtL3NldHVwLmg+DQo+PiAgICAvKg0KPiANCj4gLS0gDQo+IEp1bGllbiBHcmFsbA0K DQo= From xen-devel-bounces@lists.xenproject.org Fri Aug 11 13:48:37 2023 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 11 Aug 2023 13:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.582434.912206 (Exim 4.92) (envelope-from ) id 1qUSVF-0002mm-11; Fri, 11 Aug 2023 13:48:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 582434.912206; Fri, 11 Aug 2023 13:48:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUSVE-0002mf-Sz; Fri, 11 Aug 2023 13:48:32 +0000 Received: by outflank-mailman (input) for mailman id 582434; Fri, 11 Aug 2023 13:48:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qUSVD-0002mZ-KR for xen-devel@lists.xenproject.org; Fri, 11 Aug 2023 13:48:31 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf5cc135-384d-11ee-8613-37d641c3527e; Fri, 11 Aug 2023 15:48:29 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf5cc135-384d-11ee-8613-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1691761709; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VcAlDHWjEj39BbRxxve0Ky/5ytlZc4/cWq9eYds5w08=; b=Jkp8zpgFmhrDI5oeyw8YpkOJEAfW0gnwL+oAQFaL5mSyOE1R8BK9Ysrh hI1TjGCnau2/rNRZc9gTRbMsatzwmu9Frn8ZC7w7g3vcMJbX83SHi4JCB tdHejq9HpiPMdVpLLjlNtB+X+VEsOXlrmfOzPYp4Pn6QIQS+nvH/1HdI6 A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 119249411 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:BDpqiKo94Q0cPrzj1gqHG24VHm5eBmLJZRIvgKrLsJaIsI4StFCzt garIBmGO/+MZWGhfop0Pdm39R9QuZGEyoRqHFZspX83FnlHpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weOziBNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXACwqagmugsDt/LGYRLVRusk7Nc/kYpxK7xmMzRmBZRonaZXKQqGM7t5ExjYgwMtJGJ4yZ eJAN2ApNk6ZJUQSZBFOUslWcOSA3xETdxVRrk6VoqwmpXDe1gVr3JDmMcbPe8zMTsJQ9qqdj jufrj6lU01DbbRzzxKe8Vu+jKzPuRjqc5keHeyfr9pIrGWMkzl75Bo+CgLg/KjRZlSFc9BVJ lEQ+yEuhbMv70HtRd74NzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM0rQT0n0 HeZktWvAiZg2JWOUm6U/LqQqTK0OAAWIHUEaCtCShEKi/H8pKkjgxSJScxseIa8ltDvECv86 yyLpiM5wb4UiKY2O76TpA6dxWj2/96QE1Bzv1+MNo640u9nTJKCY5WF7HqA0fVjItqkclSZp X4LxdfLuYjiEqqxvCCKRewMGpSg6PCELCDQjDZTInUxy9i+0yX9JN4NuVmSMG8sa59ZImGxP Cc/rCsLvPdu0G2Wgbibim5bI+Aj1uDeGNvsTZg4hfIeM8EqJGdrEMyDDHN8PlwBcmB2zcnT2 r/BK65A6Er27ow2pAdav89HjdcWKtkWnAs/v6zTwRW9yqa5b3WIU7oDO1bmRrlnvfra8V+Pr IcBapDiJ/BjvAvWOHa/HWk7dwpiEJTGLcqu95w/mhCrfWKK513N+9eOmOh8KuSJboxel/vS/ 2HVZ6Or4AOXuJEzEi3TMioLQOq2Df5CQYcTYXRE0aCAhyJyPu5CLc43K/MKQFXQ3LA6laElF aVVIJno7zYmYm2vxgnxpKLV9ORKHClHTyrUV8Z5SFDTp6JdejE= IronPort-HdrOrdr: A9a23:fvHIwK7/zkLzpo1KVQPXwFfXdLJyesId70hD6qkRc20uTiX8ra qTdZsgtSMc9wxhOk3I9erwQJVoIkmzyXcW2/h2AZ6YUAHtuW21Mbx45YHhzyaIIVyaygc178 4JGJSWY+eAdGSS4/yKmzWQIpIJytOA7Ke0wcDZ0ndjTQtjdqFn6ENFGh+We3cGJzWuxqBUKH Nf3Kd6TvabFkg/X4CdAGQEUOjIr8DKkpX9CCR2YyIP2U2oiy6p577xGwWZ2BAFFxhI3bAp/S zklAP+j5/T1M1TAyW861Pu X-Talos-CUID: 9a23:R50XjWGOSqY6LwfwqmJ700oNN8UHKUHe73mMHnO1EX9vR+OKHAo= X-Talos-MUID: =?us-ascii?q?9a23=3A34PGsA2svp0QNDBT7w8hIoaeZjUj+KeHGkpOkbE?= =?us-ascii?q?9quKfOSUhHG65rhiPXdpy?= X-IronPort-AV: E=Sophos;i="6.01,165,1684814400"; d="scan'208";a="119249411" Date: Fri, 11 Aug 2023 14:48:21 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options Message-ID: <9dd1134b-8bc8-4fea-a2d7-dd20bd6af9c5@perard> References: <10ce72fb-4fb7-67de-41ec-7291dbac0038@suse.com> <60da37cf-abec-be58-d433-e98eec0c59bd@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <60da37cf-abec-be58-d433-e98eec0c59bd@suse.com> On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: > In options like -march=, it may be only the sub-option which is > unrecognized by the compiler. In such an event the error message often > splits option and argument, typically saying something like "bad value > '' for '